7cd9e8b2917b333a8fe7cff66806119ae943c18e
[WebKit-https.git] / Tools / ChangeLog
1 2019-05-28  Nikita Vasilyev  <nvasilyev@apple.com>
2
3         Web Inspector: Provide UIString descriptions to improve localizations
4         https://bugs.webkit.org/show_bug.cgi?id=195132
5         <rdar://problem/48457817>
6
7         Reviewed by Devin Rousso.
8
9         Allow WI.UIString to take:
10         - WI.UIString(string, key, comment)
11         - WI.UIString(string, comment)
12         - WI.UIString(string)
13
14         * Scripts/extract-localizable-js-strings:
15
16 2019-05-25  Dewei Zhu  <dewei_zhu@apple.com>
17
18         Limit run-benchmark http server to specific interface.
19         https://bugs.webkit.org/show_bug.cgi?id=198247
20
21         Reviewed by Ryosuke Niwa.
22
23         Add '--interface' option to 'twisted_http_server.py'.
24         'SimpleHTTPServerDriver' should specify interface for http server.
25         Update regex that determines http server port from 'lsof' output to support ipv6 address.
26
27         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
28         Added '--interface' argument.
29         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
30         Limited http server to a specific interfce.
31         Added '-P' option to 'lsof' invocation to inhibits the conversion of port numbers to port name so script won't
32         fail if it's listening on a 'well-known' port.
33         Abstracted '_check_http_server_is_running' to allow potential child class to have its own implementation.
34         (SimpleHTTPServerDriver.serve): Updated regex that determines http server port from 'lsof' output to support ipv6 address.
35         (SimpleHTTPServerDriver.kill_server): Added null check for 'self._server_process'.
36
37 2019-05-28  David Xiong  <w_xiong@apple.com>
38
39         webkitpy: Switch run-webkit-tests to tailspin
40         https://bugs.webkit.org/show_bug.cgi?id=198144
41         <rdar://problem/32463212>
42
43         Reviewed by Jonathan Bedard.
44
45         Changes run-webkit-tests to run tailspin on test time out
46         rather than spindump, and edited tests to look for tailspin logs
47         instead.
48
49         * Scripts/webkitpy/port/darwin.py:
50         (DarwinPort.sample_process): Replaced spindump with tailspin (+ symbolication)
51         (DarwinPort):
52         (DarwinPort.tailspin_file_path):
53         (DarwinTest.spindump_file_path): Deleted.
54         * Scripts/webkitpy/port/darwin_testcase.py:
55         (DarwinTest.test_tailspin): Changed spindump test (below) to test for tailspin instead
56         (DarwinTest.test_spindump): Deleted.
57         (DarwinTest.test_spindump.logging_run_command): Deleted.
58         * Scripts/webkitpy/port/ios_device_unittest.py:
59         (IOSDeviceTest.test_tailspin): Changed spindump tests (inc. below) to test for tailspin instead
60         (IOSDeviceTest.test_sample_process.logging_run_command):
61         (IOSDeviceTest.test_sample_process_exception.throwing_run_command):
62         (IOSDeviceTest.test_spindump): Deleted.
63         (IOSDeviceTest.test_spindump.logging_run_command): Deleted.
64
65 2019-05-28  David Xiong  <w_xiong@apple.com>
66
67         webkitpy: Using sudo on iOS device during timeout spindumps 
68         https://bugs.webkit.org/show_bug.cgi?id=198142
69
70         Reviewed by Jonathan Bedard.
71
72         * Scripts/webkitpy/port/darwin.py:
73         (DarwinPort.sample_process): Check target host instead of source host for sudo command.
74
75 2019-05-28  Aakash Jain  <aakash_jain@apple.com>
76
77         [ews-build] Remove unused buildbot tabs
78         https://bugs.webkit.org/show_bug.cgi?id=198108
79
80         Reviewed by Jonathan Bedard.
81
82         * BuildSlaveSupport/ews-build/templates/build.jade: Removed unused 'Changes' and 'Responsible Users' tabs.
83
84 2019-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
85
86         [GTK] Use WPEBackend-fdo for accelerating compositing in Wayland instead of the nested compositor
87         https://bugs.webkit.org/show_bug.cgi?id=197944
88
89         Reviewed by Michael Catanzaro.
90
91         Add WPEBackend-fdo to jhbuild moduleset.
92
93         * gtk/jhbuild.modules:
94
95 2019-05-27  Wenson Hsieh  <wenson_hsieh@apple.com>
96
97         [iOS] Dropping in an editable element should result in a ranged selection
98         https://bugs.webkit.org/show_bug.cgi?id=198267
99         <rdar://problem/51145977>
100
101         Reviewed by Tim Horton.
102
103         Adjust some existing API tests that currently check for selection rects after a drop. Instead of checking for
104         visible selection rects, simply check for the start caret rect, as determined by WKContentView's
105         -selectionRange.
106
107         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
108         (TestWebKitAPI::TEST):
109         (makeCGRectValue): Deleted.
110         (checkSelectionRectsWithLogging): Deleted.
111         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
112
113         Replace finalSelectionRects with finalSelectionStartRect.
114
115         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
116         (-[DragAndDropSimulator _resetSimulatedState]):
117         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
118         (-[DragAndDropSimulator finalSelectionRects]): Deleted.
119
120 2019-05-27  Oriol Brufau  <obrufau@igalia.com>
121
122         [css-grid] Preserve repeat() notation when serializing declared values
123         https://bugs.webkit.org/show_bug.cgi?id=197840
124
125         Reviewed by Manuel Rego Casasnovas.
126
127         Adapt CSSPropertyParserTest to CSSGridIntegerRepeatValue.
128
129         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
130         (TestWebKitAPI::computeNumberOfTracks):
131
132 2019-05-26  Wenson Hsieh  <wenson_hsieh@apple.com>
133
134         [iOS] Dropped text, attachments, and images should animate into place
135         https://bugs.webkit.org/show_bug.cgi?id=198243
136         <rdar://problem/35205373>
137
138         Reviewed by Tim Horton.
139
140         Adjusts the iOS dragging simulator, and adds a new API test. See below for more detail.
141
142         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
143         (TestWebKitAPI::isCompletelyWhite):
144         (TestWebKitAPI::TEST):
145
146         Add a test that drags and drops an image into a contenteditable element, and then observes the resulting
147         UITargetedDragPreviews upon drop.
148
149         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
150         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
151         (-[DragAndDropSimulator _resetSimulatedState]):
152         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
153         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
154
155         Teach the iOS version of DragAndDropSimulator to invoke -dropInteraction:concludeDrop: on the drop interaction
156         delegate when the drop finishes. This additionally uses _doAfterReceivingEditDragSnapshotForTesting: to defer
157         the end of the simulated drag and drop until after drag previews have been received during an edit drag.
158
159         (-[DragAndDropSimulator dropPreviews]):
160         (-[DragAndDropSimulator delayedDropPreviews]):
161
162         Have the drag and drop simulator remember which previews were returned by the delegate on drop, as well as which
163         previews were provided asynchronously.
164
165         (-[DragAndDropSimulator _webView:dataInteractionOperationWasHandled:forSession:itemProviders:]):
166         * TestWebKitAPI/ios/UIKitSPI.h:
167
168         Stage the new private drop interacton delegate method.
169
170 2019-05-25  Simon Fraser  <simon.fraser@apple.com>
171
172         MobileMiniBrowser: Add iPad support, and allow insecure loads
173         https://bugs.webkit.org/show_bug.cgi?id=198249
174
175         Reviewed by Tim Horton.
176
177         Add iPad support to MobileMiniBrowser, and allow insecure loads.
178
179         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
180         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
181
182 2019-05-25  Wenson Hsieh  <wenson_hsieh@apple.com>
183
184         [iOS] Respect -[NSItemProvider preferredPresentationSize] when dropping images
185         https://bugs.webkit.org/show_bug.cgi?id=198242
186
187         Reviewed by Beth Dakin.
188
189         Add a new test that simulates dropping an image with a preferred presentation size into an editable element
190         with attachment elements enabled.
191
192         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
193         (TestWebKitAPI::TEST):
194
195 2019-05-24  Yusuke Suzuki  <ysuzuki@apple.com>
196
197         Make display-profiler-output work with newer HighLine
198         https://bugs.webkit.org/show_bug.cgi?id=198205
199
200         Reviewed by Saam Barati.
201
202         Newer HighLine does not have SystemExtensions. Access @terminal member in default instance of HighLine.
203
204         * Scripts/display-profiler-output:
205
206 2019-05-23  Fujii Hironori  <Hironori.Fujii@sony.com>
207
208         run-webkit-tests: Remove feature detection support
209         https://bugs.webkit.org/show_bug.cgi?id=198105
210
211         Reviewed by Jonathan Bedard.
212
213         Feature detection support was added to DRT for Windows and old
214         run-webkit-tests in Bug 35610. It was added for NRWT in Bug 41842.
215         But, it doesn't work for DRT for Windows because of feature name
216         mismatches. Since USE(ACCELERATED_COMPOSITING) flag has been
217         removed in Bug 127833, it is not needed anymore.
218
219         * DumpRenderTree/win/DumpRenderTree.cpp:
220         (main):
221         * Scripts/webkitpy/port/base.py:
222         (Port._tests_for_other_platforms):
223         (Port._skipped_tests_for_unsupported_features):
224         (Port._runtime_feature_list): Deleted.
225         (Port.nm_command): Deleted.
226         (Port._modules_to_search_for_symbols): Deleted.
227         (Port._symbols_string): Deleted.
228         (Port._missing_feature_to_skipped_tests): Deleted.
229         (Port._has_test_in_directories): Deleted.
230         * Scripts/webkitpy/port/darwin.py:
231         (DarwinPort.make_command):
232         (DarwinPort.nm_command): Deleted.
233         * Scripts/webkitpy/port/ios_simulator.py:
234         (IOSSimulatorPort.reset_preferences):
235         (IOSSimulatorPort.nm_command): Deleted.
236         * Scripts/webkitpy/port/port_testcase.py:
237         (TestWebKitPort.__init__):
238         (TestWebKitPort.all_test_configurations):
239         (PortTestCase.test_path_to_test_expectations_file):
240         (TestWebKitPort._symbols_string): Deleted.
241         (PortTestCase.test_skipped_directories_for_features): Deleted.
242         (PortTestCase.test_skipped_directories_for_features_no_matching_tests_in_test_list): Deleted.
243         (PortTestCase.test_skipped_tests_for_unsupported_features_empty_test_list): Deleted.
244         * Scripts/webkitpy/port/watch_simulator.py:
245         (WatchSimulatorPort.reset_preferences):
246         (WatchSimulatorPort.nm_command): Deleted.
247         * Scripts/webkitpy/port/win.py:
248         (WinPort.show_results_html_file):
249         (WinPort._runtime_feature_list): Deleted.
250         * Scripts/webkitpy/port/win_unittest.py:
251         (WinPortTest.test_operating_system):
252         (WinPortTest.test_runtime_feature_list): Deleted.
253         * WebKitTestRunner/Options.cpp:
254         (WTR::OptionsHandler::OptionsHandler):
255         (WTR::handleOptionPrintSupportedFeatures): Deleted.
256         * WebKitTestRunner/Options.h:
257         * WebKitTestRunner/TestController.cpp:
258         (WTR::TestController::initialize):
259
260 2019-05-23  Commit Queue  <commit-queue@webkit.org>
261
262         Unreviewed, rolling out r245665.
263         https://bugs.webkit.org/show_bug.cgi?id=198203
264
265         Inspector appears blank, again. (Requested by NVI on #webkit).
266
267         Reverted changeset:
268
269         "Web Inspector: Provide UIString descriptions to improve
270         localizations"
271         https://bugs.webkit.org/show_bug.cgi?id=195132
272         https://trac.webkit.org/changeset/245665
273
274 2019-05-23  Stephan Szabo  <stephan.szabo@sony.com>
275
276         [Win][CMake] Pass architecture to cmake via -A for both x64 and Win32
277         https://bugs.webkit.org/show_bug.cgi?id=198098
278
279         Reviewed by Don Olmstead.
280
281         With current CMake and Visual Studio 2019, the default
282         architecture will match the host, so we should make sure
283         to explicitly mention the architecture we want for 32-bit
284         builds as well for cases where we are on x64 and not in an
285         x64_x32 cross-build vcvars environment.
286
287         * Scripts/webkitdirs.pm:
288         (getVisualStudioToolset): Get toolset name for cmake/msbuild
289         (getMSBuildPlatformArgument): Update to use getVisualStudioToolset
290         (getCMakeWindowsToolsetArgument): Get -A argument for cmake
291         based on toolset
292         (generateBuildSystemFromCMakeProject): Remove explicit -A x64
293         in 64-bit mode in favor of new getCMakeWindowsToolsetArgument.
294
295 2019-05-23  Youenn Fablet  <youenn@apple.com>
296
297         Set default WebsiteDataStore storage quota based on StorageQuotaManager
298         https://bugs.webkit.org/show_bug.cgi?id=198133
299         <rdar://problem/51031436>
300
301         Reviewed by Geoffrey Garen.
302
303         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
304         (doTest):
305
306 2019-05-23  Keith Rollin  <krollin@apple.com>
307
308         generate-xcfilelists should not store temporary build files in /tmp
309         https://bugs.webkit.org/show_bug.cgi?id=198136
310
311         Reviewed by Jonathan Bedard.
312
313         Provide the build infrastructure control of the location of
314         generate-xcfilelists' temporary files by creating them in the build
315         directory when possible.
316
317         * Scripts/webkitpy/generate_xcfilelists_lib/application.py:
318         (get_xcode_project_temp_dir):
319         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
320         (BaseGenerator._generate_derived):
321         (BaseGenerator._generate_unified):
322         (BaseGenerator):
323         (BaseGenerator._get_temp_dir):
324
325 2019-05-23  Philippe Normand  <philn@igalia.com>
326
327         [JHBuild][GStreamer] Enable libsrtp
328         https://bugs.webkit.org/show_bug.cgi?id=198041
329
330         Reviewed by Xabier Rodriguez-Calvar.
331
332         * gstreamer/jhbuild.modules: Enable libsrtp. The system version
333         can't be used from Stretch because it's too old.
334
335 2019-05-22  Ryan Haddad  <ryanhaddad@apple.com>
336
337         Move win-ews queue bubble to Win10 section of dashboard
338         https://bugs.webkit.org/show_bug.cgi?id=198159
339
340         Reviewed by Alexey Proskuryakov.
341
342         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
343         (BubbleQueueServer): Change platform to Windows10 to match the OS version of the bots.
344
345 2019-05-22  Myles C. Maxfield  <mmaxfield@apple.com>
346
347         [Mac] Add API test to make sure the system font is drawn just like in native code
348         https://bugs.webkit.org/show_bug.cgi?id=198010
349
350         Reviewed by Daniel Bates.
351
352         We can compare the width of using font-family:system-ui to a CTLine.
353
354         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
355         * TestWebKitAPI/Tests/WebKitCocoa/TextWidth.html: Added.
356         * TestWebKitAPI/Tests/WebKitCocoa/TextWidth.mm: Added.
357         (TEST):
358
359 2019-05-22  Nikita Vasilyev  <nvasilyev@apple.com>
360
361         Web Inspector: Provide UIString descriptions to improve localizations
362         https://bugs.webkit.org/show_bug.cgi?id=195132
363         <rdar://problem/48457817>
364
365         Reviewed by Devin Rousso.
366
367         Allow WI.UIString to take:
368         - WI.UIString(string, key, comment)
369         - WI.UIString(string, comment)
370         - WI.UIString(string)
371
372         * Scripts/extract-localizable-js-strings:
373
374 2019-05-22  Wenson Hsieh  <wenson_hsieh@apple.com>
375
376         [iOS] The shouldIgnoreMetaViewport test option incorrectly persists across layout tests
377         https://bugs.webkit.org/show_bug.cgi?id=198135
378         <rdar://problem/51001306>
379
380         Reviewed by Alexey Proskuryakov.
381
382         When shouldIgnoreMetaViewport=true is specified on a test, if the following test does not use a flexible
383         viewport, we will continue ignoring the meta viewport, since we'll bail before we attempt to reset
384         WKPreferences' _shouldIgnoreMetaViewport property to NO.
385
386         We fix this by simply allowing shouldIgnoreMetaViewport to take precedence over useFlexibleViewport, such that
387         -[WKPreferences _shouldIgnoreMetaViewport] will always be updated to its intended value between tests.
388
389         * WebKitTestRunner/ios/TestControllerIOS.mm:
390         (WTR::TestController::platformConfigureViewForTest):
391
392 2019-05-22  Sihui Liu  <sihui_liu@apple.com>
393
394         API Test landed in r245540 [Mac WK2] TestWebKitAPI.WKWebView.LocalStorageProcessCrashes is a flaky failure
395         https://bugs.webkit.org/show_bug.cgi?id=198090
396         <rdar://problem/51003644>
397
398         Reviewed by Youenn Fablet.
399
400         WebView was wrongly loaded multiple times.
401
402         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
403         (TEST):
404
405 2019-05-22  Jiewen Tan  <jiewen_tan@apple.com>
406
407         [WebAuthN] Support Attestation Conveyance Preference
408         https://bugs.webkit.org/show_bug.cgi?id=192722
409         <rdar://problem/49939647>
410
411         Reviewed by Brent Fulgham.
412
413         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
414         (TestWebKitAPI::TEST):
415         Updates the test with AttestationConveyancePreference.
416
417 2019-05-22  Zalan Bujtas  <zalan@apple.com>
418
419         [Paste] Add support for preferred presentation size when pasting an image
420         https://bugs.webkit.org/show_bug.cgi?id=198132
421         <rdar://problem/50886917>
422
423         Reviewed by Wenson Hsieh.
424
425         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
426         (TestWebKitAPI::TEST):
427
428 2019-05-22  Keith Rollin  <krollin@apple.com>
429
430         Use a different variable when testing for Xcode context in generate-xcfilelists
431         https://bugs.webkit.org/show_bug.cgi?id=198130
432         <rdar://problem/51032752>
433
434         Reviewed by Jonathan Bedard.
435
436         The generate-xcfilelists script can run stand-alone or in the context
437         of Xcode. There are a couple of places where it helps to know which
438         context is current. To determine the context, genreate-xfilelists
439         checks an environment variable that should be defined only when Xcode
440         is running. The variable chosen was XCODE_INSTALL_PATH. It turns out
441         that this variable is not always defined. Therefore, switch to
442         checking XCODE_PRODUCT_BUILD_VERSION.
443
444         * Scripts/webkitpy/generate_xcfilelists_lib/util.py:
445         (subprocess_run):
446         (is_running_under_xcode):
447
448 2019-05-22  Carlos Garcia Campos  <cgarcia@igalia.com>
449
450         Unreviewed. Fix WPE unit tests after r245565
451
452         Backend creation is failing when the a11y bus is not running because atk produces warning messages. We should
453         not make warnings fatal during backend creation.
454
455         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
456         (testAutomationSessionRequestSession):
457         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
458         (testWebViewGeolocationPermissionRequests):
459         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
460         (Test::createWebViewBackend):
461         (Test::addLogFatalFlag):
462         (Test::removeLogFatalFlag):
463
464 2019-05-21  Aakash Jain  <aakash_jain@apple.com>
465
466         [ews-build] Use custom templates for Buildbot (follow-up fix)
467         https://bugs.webkit.org/show_bug.cgi?id=198076
468
469         Unreviewed minor follow-up fix.
470
471         * BuildSlaveSupport/ews-build/templates/build.jade:
472
473 2019-05-21  Alex Christensen  <achristensen@webkit.org>
474
475         Fix branch build.
476         <rdar://problem/50625279>
477
478         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
479         We need to explicitly include WebKit.h on the branch.
480
481 2019-05-21  Aakash Jain  <aakash_jain@apple.com>
482
483         [ews-build] Use custom templates for Buildbot
484         https://bugs.webkit.org/show_bug.cgi?id=198076
485
486         Rubber-stamped by Jonathan Bedard.
487
488         * BuildSlaveSupport/ews-build/master.cfg:
489         * BuildSlaveSupport/ews-build/templates: Added.
490         * BuildSlaveSupport/ews-build/templates/build.jade: Copied from https://github.com/buildbot/buildbot/blob/v1.7.0/www/base/src/app/builders/builds/build.tpl.jade
491
492 2019-05-21  Chris Dumez  <cdumez@apple.com>
493
494         [PSON] Assertion hit when navigating back after a process swap forced by the client
495         https://bugs.webkit.org/show_bug.cgi?id=198006
496
497         Reviewed by Alex Christensen.
498
499         Add API test coverage.
500
501         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
502
503 2019-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
504
505         Unreviewed. Fix the build with HAVE(ACCESSIBILITY) disabled
506
507         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
508         (WTR::AccessibilityController::elementAtPoint):
509         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
510         (WTR::AccessibilityController::rootElement):
511         (WTR::AccessibilityController::focusedElement):
512
513 2019-05-21  Carlos Garcia Campos  <cgarcia@igalia.com>
514
515         [WPE] Add initial accessibility support using ATK
516         https://bugs.webkit.org/show_bug.cgi?id=197413
517
518         Reviewed by Michael Catanzaro.
519
520         Add accessibility support in MiniBrowser and backends used by MiniBrowser and tests.
521
522         * MiniBrowser/wpe/CMakeLists.txt:
523         * MiniBrowser/wpe/main.cpp:
524         (main):
525         * TestWebKitAPI/PlatformWPE.cmake:
526         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
527         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
528         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
529         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
530         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
531         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
532         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityControllerWPE.cpp: Removed.
533         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp: Removed.
534         * WebKitTestRunner/PlatformWPE.cmake:
535         * wpe/backends/CMakeLists.txt:
536         * wpe/backends/HeadlessViewBackend.cpp:
537         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
538         * wpe/backends/ViewBackend.cpp:
539         (WPEToolingBackends::addKeyEventListener):
540         (WPEToolingBackends::removeKeyEventListener):
541         (WPEToolingBackends::notifyAccessibilityKeyEventListeners):
542         (WPEToolingBackends::ViewBackend::initialize):
543         (WPEToolingBackends::ViewBackend::initializeAccessibility):
544         (WPEToolingBackends::ViewBackend::updateAccessibilityState):
545         (WPEToolingBackends::ViewBackend::setAccessibleChild):
546         (WPEToolingBackends::ViewBackend::addActivityState):
547         (WPEToolingBackends::ViewBackend::removeActivityState):
548         (WPEToolingBackends::ViewBackend::dispatchInputKeyboardEvent):
549         * wpe/backends/ViewBackend.h:
550         * wpe/backends/WebKitAccessibleApplication.cpp: Added.
551         (webkitAccessibleApplicationWindowInterfaceInit):
552         (webkitAccessibleApplicationFinalize):
553         (webkitAccessibleApplicationInitialize):
554         (webkitAccessibleApplicationGetNChildren):
555         (webkitAccessibleApplicationRefChild):
556         (webkitAccessibleApplicationGetName):
557         (webkit_accessible_application_class_init):
558         (webkit_accessible_application_init):
559         (webkitAccessibleApplicationNew):
560         (webkitAccessibleApplicationSetChild):
561         * wpe/backends/WebKitAccessibleApplication.h: Added.
562         * wpe/backends/WindowViewBackend.cpp:
563         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
564         * wpe/jhbuild.modules:
565
566 2019-05-20  Fujii Hironori  <Hironori.Fujii@sony.com>
567
568         run-webkit-tests not gathering crash logs on Cygwin Python and Windows Python
569         https://bugs.webkit.org/show_bug.cgi?id=179828
570
571         Reviewed by Jonathan Bedard.
572
573         ServerProcess should store its Windows PID for Cygwin before
574         process crashing because the Windows PID is required to get a
575         correct CrashLog.
576
577         CrashLog format has been changed. CrashLogs.GLOBAL_PID_REGEX
578         should accept the new format.
579
580         * Scripts/webkitpy/common/system/crashlogs.py:
581         (CrashLogs.GLOBAL_PID_REGEX): Accept any words between 'Global' and 'PID:'.
582
583         * Scripts/webkitpy/port/driver.py:
584         (Driver.has_crashed):
585         (Driver._check_for_driver_crash_or_unresponsiveness):
586         (Driver._read_block):
587         Store server_process.system_pid() to self._crashed_pid instead of server_process.pid().
588
589         * Scripts/webkitpy/port/server_process.py:
590         (ServerProcess.__init__):
591         (ServerProcess.system_pid): Added.
592         (ServerProcess._find_system_pid): Added.
593         (ServerProcess._start): Set self._system_pid.
594         * Scripts/webkitpy/port/win.py:
595         (WinPort._get_crash_log): Removed broken old code converting Cygwin pid to Windows pid.
596
597 2019-05-20  Aakash Jain  <aakash_jain@apple.com>
598
599         Windows 10 test results missing on flakiness dashboard
600         https://bugs.webkit.org/show_bug.cgi?id=198058
601
602         Rubber-stamped by Alexey Proskuryakov.
603
604         * TestResultServer/static-dashboards/flakiness_dashboard.js:
605
606 2019-05-20  Sihui Liu  <sihui_liu@apple.com>
607
608         Move Web Storage to Network Process
609         https://bugs.webkit.org/show_bug.cgi?id=197636
610  
611         Reviewed by Youenn Fablet.
612  
613         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
614         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageDatabaseTracker.mm: Remove the wait for database file update.
615         (TEST):
616         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm: Add a test for network process crash recovery.
617         (TEST):
618         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm: Fix a typo and add a test case to cover it.
619         * TestWebKitAPI/Tests/WebKitCocoa/local-storage-process-crashes.html: Added.
620
621 2019-05-20  Keith Rollin  <krollin@apple.com>
622
623         generate-xcfilelists is stranding temporary files
624         https://bugs.webkit.org/show_bug.cgi?id=198008
625         <rdar://problem/50893659>
626
627         Reviewed by Jonathan Bedard.
628
629         generate-xcfilelists makes use of temporary files on disk. These files
630         are opened with the OS's "temporary" bit set, causing them to get
631         deleted when closed or the process exists. However, these temporary
632         files actually end up persisting after the script exists. This is
633         because `sed` is used to process the files, and is done so in a way
634         that causes the "temporary" bit to get cleared.
635
636         Address this issue by no longer using `sed` and instead performing the
637         equivalent processing the file content in-memory.
638
639         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
640         (BaseGenerator._generate_derived):
641         (BaseGenerator._generate_unified):
642         (BaseGenerator._replace):
643         (BaseGenerator._unexpand):
644         (BaseGenerator._find_added_lines.get_lines):
645         (BaseGenerator._find_added_lines):
646
647 2019-05-20  Ludovico de Nittis  <ludovico.denittis@collabora.com>
648
649         [WPE][Qt] Use C++17 instead of C++14
650         https://bugs.webkit.org/show_bug.cgi?id=197415
651
652         Reviewed by Philippe Normand.
653
654         There was a regression introduced with the commit https://bugs.webkit.org/show_bug.cgi?id=197131
655         The WPE Qt port was not updated to C++17 and this leaded to a compilation error.
656
657         * TestWebKitAPI/glib/CMakeLists.txt:
658
659 2019-05-20  Ludovico de Nittis  <ludovico.denittis@collabora.com>
660
661         [Flatpak][Qt] Meson: Unknown type feature for gstreamer
662         https://bugs.webkit.org/show_bug.cgi?id=197408
663
664         Reviewed by Philippe Normand.
665
666         This is a regression that has been introduced when
667         GStreamer was updated to version 1.16.0
668         https://bugs.webkit.org/show_bug.cgi?id=197157
669
670         Now GStreamer requires meson >= 0.47.0
671         Updating the Kde runtime to version 5.12 we fulfill
672         this requirement.
673
674         * flatpak/org.webkit.WPEQT.yaml:
675
676 2019-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
677
678         [GLIB] Crash when instantiating a js object registered with jsc_context_register_class on window object cleared
679         https://bugs.webkit.org/show_bug.cgi?id=198037
680
681         Reviewed by Michael Catanzaro.
682
683         Add a test case to check the crash is fixed.
684
685         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
686         (testWebExtensionWindowObjectCleared):
687         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
688         (windowObjectCleared):
689
690 2019-05-20  Carlos Garcia Campos  <cgarcia@igalia.com>
691
692         [GLIB] Repeating timer is not stopped when stop is called from the callback
693         https://bugs.webkit.org/show_bug.cgi?id=197986
694
695         Reviewed by Michael Catanzaro.
696
697         Check the timer is no longer active after it has been stopped.
698
699         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
700         (TestWebKitAPI::TEST):
701
702 2019-05-19  Darin Adler  <darin@apple.com>
703
704         Change String::number to use "shortest" instead of "fixed precision 6 digits"
705         https://bugs.webkit.org/show_bug.cgi?id=178319
706
707         Reviewed by Sam Weinig.
708
709         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
710         (TestWebKitAPI::testStringNumberFixedPrecision): Use String::numberToStringFixedPrecision.
711
712         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
713         (attributesOfElement): Use appendFixedPrecisionNumber.
714
715 2019-05-18  Jiewen Tan  <jiewen_tan@apple.com>
716
717         [WebAuthN] Allow authenticators that support both CTAP and U2F to try U2F if CTAP fails in authenticatorGetAssertion
718         https://bugs.webkit.org/show_bug.cgi?id=197974
719         <rdar://problem/50879746>
720
721         Reviewed by Brent Fulgham.
722
723         Add a canDowngrade option for mock hid devices to simulate the situation.
724
725         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
726         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
727
728 2019-05-18  Tadeu Zagallo  <tzagallo@apple.com>
729
730         Add extra information to dumpJITMemory
731         https://bugs.webkit.org/show_bug.cgi?id=197998
732
733         Reviewed by Saam Barati.
734
735         Add description for the new dumpJITMemory trace point code.
736
737         * Tracing/SystemTracePoints.plist:
738
739 2019-05-17  Justin Michaud  <justin_michaud@apple.com>
740
741         [WASM-References] Add support for Anyref in parameters and return types, Ref.null and Ref.is_null for Anyref values.
742         https://bugs.webkit.org/show_bug.cgi?id=197969
743
744         Run wasm tests additionally with wasmBBQUsesAir=0.
745
746         Reviewed by Keith Miller.
747
748         * Scripts/run-jsc-stress-tests:
749
750 2019-05-17  Don Olmstead  <don.olmstead@sony.com>
751
752         [CMake] Use builtin FindICU
753         https://bugs.webkit.org/show_bug.cgi?id=197934
754
755         Reviewed by Michael Catanzaro.
756
757         Remove uses of ICU_INCLUDE_DIRS and ICU_LIBRARIES.
758
759         * TestWebKitAPI/PlatformMac.cmake:
760         * TestWebKitAPI/PlatformPlayStation.cmake:
761         * TestWebKitAPI/PlatformWin.cmake:
762         * WebKitTestRunner/CMakeLists.txt:
763
764 2019-05-17  Alex Christensen  <achristensen@webkit.org>
765
766         Enable legacy EME for iOS WKWebView
767         https://bugs.webkit.org/show_bug.cgi?id=197964
768         <rdar://problem/50625666>
769
770         Reviewed by Wenson Hsieh.
771
772         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
773         (TEST):
774
775 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
776
777         [ews-build] Add clickable url in UI for uploaded S3 archive
778         https://bugs.webkit.org/show_bug.cgi?id=197996
779
780         Reviewed by Jonathan Bedard.
781
782         * BuildSlaveSupport/ews-build/steps.py:
783
784 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
785
786         [ews-app] Status bubble should not turn orange when any build step has warnings
787         https://bugs.webkit.org/show_bug.cgi?id=198000
788
789         Reviewed by Jonathan Bedard.
790
791         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
792         (StatusBubble._does_build_contains_any_failed_step):
793
794 2019-05-17  Alex Christensen  <achristensen@webkit.org>
795
796         Add SPI to set a list of hosts to which to send custom header fields cross-origin
797         https://bugs.webkit.org/show_bug.cgi?id=197397
798
799         Reviewed by Geoff Garen.
800
801         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
802         (TEST):
803         (expectLegacyHeaders):
804         (expectHeaders):
805         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
806         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
807         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
808
809 2019-05-17  Keith Rollin  <krollin@apple.com>
810
811         Unreviewed build fix.
812
813         Teach generate-xcfilelists about iphonesimulator.
814
815         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
816         (JavaScriptCoreGenerator):
817         (WebCoreGenerator):
818         (WebKitGenerator):
819
820 2019-05-17  Keith Rollin  <krollin@apple.com>
821
822         Re-enable generate-xcfilelists
823         https://bugs.webkit.org/show_bug.cgi?id=197933
824         <rdar://problem/50831677>
825
826         Reviewed by Jonathan Bedard.
827
828         The following two tasks have been completed, and we can re-enable
829         generate-xcfilelists:
830
831         Bug 197619 <rdar://problem/50507392> Temporarily disable generate-xcfilelists (197619)
832         Bug 197622 <rdar://problem/50508222> Rewrite generate-xcfilelists in Python (197622)
833
834         * DumpRenderTree/Scripts/check-xcfilelists.sh:
835         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
836
837 2019-05-17  Commit Queue  <commit-queue@webkit.org>
838
839         Unreviewed, rolling out r245401.
840         https://bugs.webkit.org/show_bug.cgi?id=197990
841
842         Causing internal build failures (Requested by ShawnRoberts on
843         #webkit).
844
845         Reverted changeset:
846
847         "Add SPI to set a list of hosts to which to send custom header
848         fields cross-origin"
849         https://bugs.webkit.org/show_bug.cgi?id=197397
850         https://trac.webkit.org/changeset/245401
851
852 2019-05-17  Commit Queue  <commit-queue@webkit.org>
853
854         Unreviewed, rolling out r245418.
855         https://bugs.webkit.org/show_bug.cgi?id=197989
856
857         New API test causing crashes on Mojave testers (Requested by
858         ShawnRoberts on #webkit).
859
860         Reverted changeset:
861
862         "Add a unit test for client certificate authentication"
863         https://bugs.webkit.org/show_bug.cgi?id=197800
864         https://trac.webkit.org/changeset/245418
865
866 2019-05-17  Aakash Jain  <aakash_jain@apple.com>
867
868         [ews-build] Add build step to Transfer archive to S3
869         https://bugs.webkit.org/show_bug.cgi?id=197922
870
871         Reviewed by Jonathan Bedard.
872
873         * BuildSlaveSupport/ews-build/steps.py:
874         (TransferToS3):
875         (TransferToS3.finished): Invoke triggers after transfer is successful.
876         (TransferToS3.getResultSummary): Create more readable failure string.
877         (UploadBuiltProduct.finished): Deleted. Moved the trigger invocation after TransferToS3.
878         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
879
880 2019-05-16  Carlos Garcia Campos  <cgarcia@igalia.com>
881
882         [GTK] Need WebKitContextMenuItemType to open emoji picker
883         https://bugs.webkit.org/show_bug.cgi?id=176760
884
885         Reviewed by Michael Catanzaro.
886
887         Update context menu test to check insert emoji action is included in default context menu for editable content.
888
889         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
890
891 2019-05-16  Aakash Jain  <aakash_jain@apple.com>
892
893         [ews-build] Download archives from S3
894         https://bugs.webkit.org/show_bug.cgi?id=197949
895
896         Reviewed by Jonathan Bedard.
897
898         * BuildSlaveSupport/ews-build/steps.py:
899         (DownloadBuiltProduct): Updated to use S3 URL.
900         (DownloadBuiltProduct.getResultSummary): Method to display custom failure string.
901         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
902
903 2019-05-16  David Kilzer  <ddkilzer@apple.com>
904
905         REGRESSION (r15133): Fix leak of JSStringRef in minidom
906         <https://webkit.org/b/197968>
907         <rdar://problem/50872430>
908
909         Reviewed by Joseph Pecoraro.
910
911         * TestWebKitAPI/Tests/WebKitObjC/UserContentTest.mm:
912         (expectScriptValueIsString): Drive-by fix to use adopt() instead
913         of JSRetainPtr<JSStringRef> string(Adopt, JSValueToStringCopy(...)).
914
915 2019-05-16  David Kilzer  <ddkilzer@apple.com>
916
917         REGRESSION (r84160): Leak of OpaqueJSString under WTR::JSTestRunner::pathToLocalResource (32 bytes) in com.apple.WebKit.WebContent running layout tests
918         <https://webkit.org/b/197965>
919
920         Reviewed by Joseph Pecoraro.
921
922         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
923         (WTR::TestRunner::pathToLocalResource): Don't call
924         JSStringRetain() here because the JSRetainPtr<JSStringRef>
925         return type will increment the retain count for us.
926
927 2019-05-16  Alex Christensen  <achristensen@webkit.org>
928
929         Add a unit test for client certificate authentication
930         https://bugs.webkit.org/show_bug.cgi?id=197800
931
932         Reviewed by Youenn Fablet.
933
934         Make better abstractions for reading and writing from/to TCPServer.
935         Add a unit test that causes a client certificate authentication challenge to happen.
936
937         * TestWebKitAPI/TCPServer.cpp:
938         (TestWebKitAPI::TCPServer::TCPServer):
939         (TestWebKitAPI::TCPServer::read):
940         (TestWebKitAPI::TCPServer::write):
941         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
942         (TestWebKitAPI::TCPServer::respondWithOK):
943         * TestWebKitAPI/TCPServer.h:
944         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
945         (credentialWithIdentity):
946         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
947         (TEST):
948         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
949         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
950         (-[ClientCertificateDelegate challengeCount]):
951         (TestWebKitAPI::TEST):
952         (respondWithChallengeThenOK): Deleted.
953         (credentialWithIdentityAndKeychainPath): Deleted.
954         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
955         (TEST):
956         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
957         (TestWebKitAPI::TEST):
958         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
959         (TEST):
960         (readRequest): Deleted.
961         (writeResponse): Deleted.
962         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
963         (TestWebKitAPI::TEST):
964         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
965
966 2019-05-16  Alex Christensen  <achristensen@webkit.org>
967
968         Add SPI to set a list of hosts to which to send custom header fields cross-origin
969         https://bugs.webkit.org/show_bug.cgi?id=197397
970
971         Reviewed by Geoff Garen.
972
973         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
974         (TEST):
975         (expectLegacyHeaders):
976         (expectHeaders):
977         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
978         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
979         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
980
981 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
982
983         Replace double-quotes with single quotes in steps.py
984         https://bugs.webkit.org/show_bug.cgi?id=197921
985
986         Reviewed by Jonathan Bedard.
987
988         * BuildSlaveSupport/ews-build/steps.py:
989
990 2019-05-15  Keith Rollin  <krollin@apple.com>
991
992         Rewrite generate-xcfilelists in Python
993         https://bugs.webkit.org/show_bug.cgi?id=197622
994         <rdar://problem/50508222>
995
996         Reviewed by Jonathan Bedard, Alex Christensen.
997
998         For a number of reasons, rewrite generate-xcfilelists in Python:
999
1000         - The previous bash script was large and unmaintainable.
1001         - We have more internal expertise with Python than with bash.
1002         - The bash script used temporary files in /tmp that got stranded and
1003           were owned by root, making them awkward to clear out.
1004           <rdar://problem/49490262>
1005         - We needed to complete support for engineers that built with Xcode
1006           rather than the command line.
1007         - There are some bugs leading to mildly corrupted .xcfilelist files.
1008           It's not apparent the source of the bugs, but one general reason
1009           might be due to approaches born of using bash. Rewriting in Python
1010           may clear these up.
1011
1012         * Scripts/generate-xcfilelists:
1013         * Scripts/webkitpy/common/attribute_saver.py: Added.
1014         (AttributeSaver):
1015         (AttributeSaver.__init__):
1016         (AttributeSaver.__enter__):
1017         (AttributeSaver.__exit__):
1018         * Scripts/webkitpy/common/attribute_saver_unittest.py: Added.
1019         (AttributeSaverTest):
1020         (AttributeSaverTest.SimpleTestClass):
1021         (AttributeSaverTest.SimpleTestClass.__init__):
1022         (AttributeSaverTest.test_class):
1023         (AttributeSaverTest.test_normal_default):
1024         (AttributeSaverTest.test_normal_value):
1025         (AttributeSaverTest.test_normal_value_on_exception):
1026         (AttributeSaverTest.test_normal_value_on_normal_exit):
1027         (AttributeSaverTest.test_normal_value_with_finally_on_exception):
1028         (AttributeSaverTest.test_normal_value_with_finally_on_normal_exit):
1029         (AttributeSaverTest.test_normal_value_with_else_on_exception):
1030         (AttributeSaverTest.test_normal_value_with_else_on_normal_exit):
1031         * Scripts/webkitpy/generate_xcfilelists_lib/__init__.py: Added.
1032         * Scripts/webkitpy/generate_xcfilelists_lib/application.py: Added.
1033         (Application):
1034         (Application.__init__):
1035         (Application.run):
1036         (Application._initialize):
1037         (Application._initialize.collect_attributes):
1038         (Application._create_parser):
1039         (_validate_args):
1040         (_cmd_generate):
1041         (_cmd_check):
1042         (_cmd_subgenerate):
1043         (_cmd_help):
1044         (_do_generate):
1045         (_do_merge):
1046         (_report_results):
1047         (_report_merge_results):
1048         (_report_remediation_steps):
1049         (_report_remediation_steps.add_to_message):
1050         (_any_have_errors):
1051         (_any_have_actions):
1052         (_log_progress):
1053         (_log_results):
1054         (get_generate_xcfilelists_script_path):
1055         (_get_root_dir):
1056         (get_opensource_dir):
1057         (get_build_scripts_dir):
1058         (get_extract_dependencies_from_makefile_script):
1059         (get_xcode_built_products_dir):
1060         (_getenv):
1061         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py: Added.
1062         (BaseGenerator):
1063         (BaseGenerator.__init__):
1064         (BaseGenerator.__str__):
1065         (BaseGenerator.generate):
1066         (BaseGenerator._sublaunch_under_xcode):
1067         (BaseGenerator.subgenerate):
1068         (BaseGenerator.merge):
1069         (BaseGenerator.pickle_to_file):
1070         (BaseGenerator.has_action):
1071         (BaseGenerator.has_error):
1072         (BaseGenerator.is_valid):
1073         (BaseGenerator.report_error):
1074         (BaseGenerator._generate_derived):
1075         (BaseGenerator._merge_derived):
1076         (BaseGenerator._generate_unified):
1077         (BaseGenerator._merge_unified):
1078         (BaseGenerator._replace):
1079         (BaseGenerator._unexpand):
1080         (BaseGenerator._find_added_lines):
1081         (BaseGenerator._merge_added_lines):
1082         (BaseGenerator._get_file_lines):
1083         (BaseGenerator._getenv):
1084         (BaseGenerator._get_project_file_path):
1085         (BaseGenerator._get_project_dir):
1086         (BaseGenerator._get_project_file_name):
1087         (BaseGenerator._get_project_name):
1088         (BaseGenerator._get_sym_root):
1089         (BaseGenerator._get_obj_root):
1090         (BaseGenerator._get_shared_precomps_dir):
1091         (BaseGenerator._get_build_dirs):
1092         (BaseGenerator._get_build_dirs.define_xcode_build_dirs):
1093         (BaseGenerator._get_build_dirs.define_xcode_build_dirs.read_xcode_user_default):
1094         (BaseGenerator._get_build_dirs.define_command_line_build_dirs):
1095         (BaseGenerator._get_derived_sources_dir):
1096         (BaseGenerator._get_xcfilelist_dir):
1097         (BaseGenerator._get_input_derived_xcfilelist_project_path):
1098         (BaseGenerator._get_output_derived_xcfilelist_project_path):
1099         (BaseGenerator._get_input_unified_xcfilelist_project_path):
1100         (BaseGenerator._get_output_unified_xcfilelist_project_path):
1101         (BaseGenerator._get_generate_derived_sources_script):
1102         (BaseGenerator._get_generate_unified_sources_script):
1103         (JavaScriptCoreGenerator):
1104         (JavaScriptCoreGenerator._get_project_file_path):
1105         (JavaScriptCoreGenerator._get_generate_derived_sources_script):
1106         (JavaScriptCoreGenerator._get_generate_unified_sources_script):
1107         (WebCoreGenerator):
1108         (WebCoreGenerator._get_project_file_path):
1109         (WebCoreGenerator._get_generate_derived_sources_script):
1110         (WebCoreGenerator._get_generate_unified_sources_script):
1111         (WebKitGenerator):
1112         (WebKitGenerator._get_project_file_path):
1113         (WebKitGenerator._get_derived_sources_dir):
1114         (WebKitGenerator._get_generate_derived_sources_script):
1115         (WebKitGenerator._get_generate_unified_sources_script):
1116         (DumpRenderTreeGenerator):
1117         (DumpRenderTreeGenerator._get_project_file_path):
1118         (DumpRenderTreeGenerator._get_generate_derived_sources_script):
1119         (WebKitTestRunnerGenerator):
1120         (WebKitTestRunnerGenerator._get_project_file_path):
1121         (WebKitTestRunnerGenerator._get_generate_derived_sources_script):
1122         * Scripts/webkitpy/generate_xcfilelists_lib/util.py: Added.
1123         (debug_log):
1124         (LogEntryHelper):
1125         (LogEntryHelper.__init__):
1126         (LogEntryHelper.log_entry):
1127         (LogEntryHelper.log_result):
1128         (LogEntryHelper.log_exception):
1129         (LogEntryHelper._print):
1130         (LogEntryExit):
1131         (LogEntryExit._show_debug_logging):
1132         (LogEntryExitClass):
1133         (LogEntryExitClass._show_debug_logging):
1134         (LogEntryExitGlobal):
1135         (LogEntryExitGlobal._show_debug_logging):
1136         (subprocess_run):
1137         (is_running_under_xcode):
1138         (CheckValidItemAction):
1139         (CheckValidItemAction.__init__):
1140         (CheckValidItemAction.__call__):
1141         (CheckValidItemAction.validate_item):
1142         (CheckCommandAction):
1143         (CheckCommandAction.__call__):
1144         (InvalidCommandError):
1145         (InvalidArgumentError):
1146         (InvalidConfigurationError):
1147         (CalledProcessError):
1148         (CalledProcessError.__str__):
1149         * Scripts/webkitpy/xcode/__init__.py:
1150         (xcode_hash_for_path):
1151         (xcode_hash_for_path.convert_to_string):
1152         * Scripts/webkitpy/xcode/sdk.py: Added.
1153         (SDK):
1154         (SDK.__init__):
1155         (SDK.__repr__):
1156         (SDK.as_xcode_specification):
1157         (SDK.get_preferred_sdk_for_platform):
1158         (SDK._parse_sdk):
1159         * Scripts/webkitpy/xcode/sdk_unittest.py: Added.
1160         (SDKTest):
1161
1162 2019-05-15  Aakash Jain  <aakash_jain@apple.com>
1163
1164         [ews-build] Enabling uploading EWS archives to S3
1165         https://bugs.webkit.org/show_bug.cgi?id=197914
1166
1167         Reviewed by Jonathan Bedard.
1168
1169         * BuildSlaveSupport/Shared: Added.
1170         * BuildSlaveSupport/Shared/transfer-archive-to-s3: Moved from Tools/BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3.
1171         (archiveExists): Replace tab with space.
1172         (main): Added main method.
1173         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1174         (TransferToS3): Updated path to the script.
1175         * BuildSlaveSupport/build.webkit.org-config/transfer-archive-to-s3: Moved to Shared folder.
1176
1177 2019-05-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1178
1179         inputmode="numeric" should show a number pad with digits 0-9, instead of the numeric keyplane
1180         https://bugs.webkit.org/show_bug.cgi?id=197916
1181         <rdar://problem/50815427>
1182
1183         Reviewed by Timothy Hatcher.
1184
1185         Re-enable this previously flaky test, and rebaseline the result to to expect UIKeyboardTypeNumberPad for
1186         inputmode="numeric".
1187
1188         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1189         (TestWebKitAPI::TEST):
1190
1191 2019-05-15  Youenn Fablet  <youenn@apple.com>
1192
1193         Reuse existing WebPageProxy quota handler for NetworkProcessProxy quota requests
1194         https://bugs.webkit.org/show_bug.cgi?id=197463
1195         <rdar://problem/47403621>
1196
1197         Reviewed by Alex Christensen.
1198
1199         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm: Added.
1200         (-[QuotaDelegate init]):
1201         (-[QuotaDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
1202         (-[QuotaDelegate quotaDelegateCalled]):
1203         (-[QuotaDelegate grantQuota]):
1204         (-[StorageSchemes webView:startURLSchemeTask:]):
1205         (-[StorageSchemes webView:stopURLSchemeTask:]):
1206         (-[QuotaMessageHandler userContentController:didReceiveScriptMessage:]):
1207         (doTest):
1208
1209 2019-05-15  Youenn Fablet  <youenn@apple.com>
1210
1211         Constant crashes under WebPage::isThrottleable() after r245299
1212         https://bugs.webkit.org/show_bug.cgi?id=197902
1213         <rdar://problem/50793796>
1214
1215         Reviewed by Alex Christensen.
1216
1217         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1218
1219 2019-05-15  Philippe Normand  <pnormand@igalia.com>
1220
1221         [GTK][jhbuild] misc cleanups and bumps
1222         https://bugs.webkit.org/show_bug.cgi?id=197913
1223
1224         Reviewed by Xabier Rodriguez-Calvar.
1225
1226         * gstreamer/jhbuild.modules: Bump to libva 2.4.1 and switch to Meson.
1227         * gtk/jhbuild.modules: Bump to Brotli 1.0.5 and Wayland 1.16.
1228
1229 2019-05-15  Chris Dumez  <cdumez@apple.com>
1230
1231         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
1232         https://bugs.webkit.org/show_bug.cgi?id=195102
1233         <rdar://problem/48456786>
1234
1235         Reviewed by Alex Christensen.
1236
1237         Try to wait longer for the number of processes to reach the expected number
1238         and before failing.
1239
1240         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1241
1242 2019-05-15  Alex Christensen  <achristensen@webkit.org>
1243
1244         Allow NSFileCoordinator to be called from WebContent process
1245         https://bugs.webkit.org/show_bug.cgi?id=197895
1246         <rdar://problem/50107679>
1247
1248         Reviewed by Brent Fulgham.
1249
1250         Add a unit test that verifies calling the block succeeds.
1251
1252         * TestWebKitAPI/Tests/WebKitCocoa/AdditionalReadAccessAllowedURLsPlugin.mm:
1253         (-[AdditionalReadAccessAllowedURLsPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1254
1255 2019-05-14  Andy Estes  <aestes@apple.com>
1256
1257         [Apple Pay] Payment APIs should be completely disabled in web views into which clients have injected user scripts
1258         https://bugs.webkit.org/show_bug.cgi?id=197751
1259         <rdar://problem/50631563>
1260
1261         Reviewed by Alex Christensen.
1262
1263         Added new API tests.
1264
1265         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm:
1266         (-[TestApplePayScriptMessageHandler initWithAPIsAvailableExpectation:canMakePaymentsExpectation:]):
1267         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1268         (TestWebKitAPI::TEST):
1269         (-[TestApplePayScriptMessageHandler initWithExpectation:]): Deleted.
1270         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html:
1271
1272 2019-05-14  Youenn Fablet  <youenn@apple.com>
1273
1274         A service worker process should app nap when all its clients app nap
1275         https://bugs.webkit.org/show_bug.cgi?id=185626
1276         <rdar://problem/46785908>
1277
1278         Reviewed by Alex Christensen.
1279
1280         Allow to enable app nap through test header.
1281
1282         * WebKitTestRunner/TestController.cpp:
1283         (WTR::TestController::resetPreferencesToConsistentValues):
1284         (WTR::updateTestOptionsFromTestHeader):
1285         * WebKitTestRunner/TestOptions.h:
1286         (WTR::TestOptions::hasSameInitializationOptions const):
1287
1288 2019-05-14  Commit Queue  <commit-queue@webkit.org>
1289
1290         Unreviewed, rolling out r245281.
1291         https://bugs.webkit.org/show_bug.cgi?id=197887
1292
1293         Broke API Test TestWebKitAPI.Challenge.ClientCertificate
1294         (Requested by aakashjain on #webkit).
1295
1296         Reverted changeset:
1297
1298         "Add a unit test for client certificate authentication"
1299         https://bugs.webkit.org/show_bug.cgi?id=197800
1300         https://trac.webkit.org/changeset/245281
1301
1302 2019-05-14  Youenn Fablet  <youenn@apple.com>
1303
1304         Add support for webkit-test-runner options to WPT importer
1305         https://bugs.webkit.org/show_bug.cgi?id=197826
1306
1307         Reviewed by Alex Christensen.
1308
1309         In case of overwriting an existing test, check if the existing test
1310         contains a <!-- webkit-test-runner --> comment and insert it back if
1311         needed in the new test.
1312
1313         For exporter, forbid creating a WPT PR if there are changes containing
1314         the webkit-test-runner string.
1315
1316         * Scripts/webkitpy/w3c/test_converter.py:
1317         (convert_for_webkit):
1318         (_W3CTestConverter.__init__):
1319         (_W3CTestConverter.add_webkit_test_runner_options_if_needed):
1320         (_W3CTestConverter.handle_starttag):
1321         (_W3CTestConverter.handle_comment):
1322         (_W3CTestConverter.handle_decl):
1323         (_W3CTestConverter.handle_pi):
1324         * Scripts/webkitpy/w3c/test_exporter.py:
1325         (WebPlatformTestExporter.write_git_patch_file):
1326         (WebPlatformTestExporter.make_pull_request):
1327         * Scripts/webkitpy/w3c/test_importer.py:
1328         (TestImporter.webkit_test_runner_options):
1329         (TestImporter):
1330         (TestImporter.add_webkit_test_runner_options_to_content):
1331         (TestImporter.copy_html_file):
1332         (TestImporter.write_html_template):
1333         (TestImporter.write_html_files_for_templated_js_tests):
1334         (TestImporter.import_tests):
1335         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1336         (test_manual_slow_test):
1337         (test_webkit_test_runner_options):
1338
1339 2019-05-14  Aakash Jain  <aakash_jain@apple.com>
1340
1341         [ews-app] Status bubble should turn orange when any build step fails
1342         https://bugs.webkit.org/show_bug.cgi?id=197812
1343
1344         Reviewed by Jonathan Bedard.
1345
1346         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1347         (StatusBubble._build_bubble): Turn status-bubble orange if there is any failed step in the on-going build.
1348         (StatusBubble._does_build_contains_any_failed_step): Method to check if build contains any failed step.
1349
1350 2019-05-14  Alex Christensen  <achristensen@webkit.org>
1351
1352         Add a unit test for client certificate authentication
1353         https://bugs.webkit.org/show_bug.cgi?id=197800
1354
1355         Reviewed by Youenn Fablet.
1356
1357         Make better abstractions for reading and writing from/to TCPServer.
1358         Add a unit test that causes a client certificate authentication challenge to happen.
1359
1360         * TestWebKitAPI/TCPServer.cpp:
1361         (TestWebKitAPI::TCPServer::TCPServer):
1362         (TestWebKitAPI::TCPServer::read):
1363         (TestWebKitAPI::TCPServer::write):
1364         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
1365         (TestWebKitAPI::TCPServer::respondWithOK):
1366         * TestWebKitAPI/TCPServer.h:
1367         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1368         (credentialWithIdentity):
1369         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1370         (TEST):
1371         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
1372         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1373         (-[ClientCertificateDelegate challengeCount]):
1374         (TestWebKitAPI::TEST):
1375         (respondWithChallengeThenOK): Deleted.
1376         (credentialWithIdentityAndKeychainPath): Deleted.
1377         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1378         (TEST):
1379         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1380         (TestWebKitAPI::TEST):
1381         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1382         (TEST):
1383         (readRequest): Deleted.
1384         (writeResponse): Deleted.
1385         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1386         (TestWebKitAPI::TEST):
1387         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
1388
1389 2019-05-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
1390
1391         [CG] Adding support for HEIF-sequence ('public.heics') images
1392         https://bugs.webkit.org/show_bug.cgi?id=197384
1393
1394         Reviewed by Simon Fraser.
1395
1396         * DumpRenderTree/TestOptions.cpp:
1397         (TestOptions::TestOptions):
1398         * DumpRenderTree/TestOptions.h:
1399         * DumpRenderTree/mac/DumpRenderTree.mm:
1400         (resetWebViewToConsistentStateBeforeTesting):
1401         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
1402         Make DRT call setAdditionalSupportedImageTypesForTesting() before starting
1403         the test.
1404
1405         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1406         (WTR::InjectedBundle::stringForKey):
1407         (WTR::InjectedBundle::beginTesting):
1408         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1409         * WebKitTestRunner/TestController.cpp:
1410         (WTR::TestController::resetStateToConsistentValues):
1411         (WTR::updateTestOptionsFromTestHeader):
1412         * WebKitTestRunner/TestInvocation.cpp:
1413         (WTR::TestInvocation::createTestSettingsDictionary):
1414         * WebKitTestRunner/TestOptions.h:
1415         (WTR::TestOptions::hasSameInitializationOptions const):
1416         Parse the new webkit-test-runner paramter: additionalSupportedImageTypes.
1417         Make WTR call setAdditionalSupportedImageTypesForTesting() before starting
1418         the test.
1419
1420 2019-05-12  Yusuke Suzuki  <ysuzuki@apple.com>
1421
1422         [JSC] Compress Watchpoint size by using enum type and Packed<> data structure
1423         https://bugs.webkit.org/show_bug.cgi?id=197730
1424
1425         Reviewed by Filip Pizlo.
1426
1427         * TestWebKitAPI/CMakeLists.txt:
1428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1429         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1430         (TestWebKitAPI::TEST):
1431         * TestWebKitAPI/Tests/WTF/Packed.cpp: Added.
1432         (TestWebKitAPI::TEST):
1433
1434 2019-05-10  Chris Dumez  <cdumez@apple.com>
1435
1436         Unreviewed, fix ProcessSwap.OpenerLinkAfterAPIControlledProcessSwappingOfOpener API test
1437
1438         It became flaky after r245198.
1439
1440         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1441
1442 2019-05-10  Youenn Fablet  <youenn@apple.com>
1443
1444         A service worker instance should be terminated when its SWServer is destroyed
1445         https://bugs.webkit.org/show_bug.cgi?id=197801
1446         <rdar://problem/50587270>
1447
1448         Reviewed by Chris Dumez.
1449
1450         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1451
1452 2019-05-10  Chris Dumez  <cdumez@apple.com>
1453
1454         Do not wait until requestPermission() is called to fire deviceorientation events if permission was already granted
1455         https://bugs.webkit.org/show_bug.cgi?id=197750
1456
1457         Reviewed by Geoffrey Garen.
1458
1459         Add API test coverage.
1460
1461         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1462         (TEST):
1463
1464 2019-05-10  Keith Miller  <keith_miller@apple.com>
1465
1466         Remove legacy test262 import script
1467         https://bugs.webkit.org/show_bug.cgi?id=197788
1468
1469         Reviewed by Yusuke Suzuki.
1470
1471         import-test262-tests doesn't work anymore. We should be using test262-import instead.
1472
1473         * Scripts/import-test262-tests: Removed.
1474
1475 2019-05-10  Charlie Turner  <cturner@igalia.com>
1476
1477         [WPE] Forward libepoxy cflags
1478         https://bugs.webkit.org/show_bug.cgi?id=197784
1479
1480         Reviewed by Žan Doberšek.
1481
1482         Patch by Zan Dobersek.
1483
1484         * wpe/backends/CMakeLists.txt: This is required to keep
1485         -DMESA_EGL_NO_X11_HEADERS in the build, if we don't do this, EGL ends
1486         up trying to include X11 headers even when they're not present in the
1487         environment.
1488
1489 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1490
1491         Fix a bunch of compiler warnings
1492         https://bugs.webkit.org/show_bug.cgi?id=197785
1493
1494         Reviewed by Don Olmstead.
1495
1496         Add preprocessor guards to avoid -Wunused-function warnings.
1497
1498         * TestWebKitAPI/Tests/WebCore/FloatRect.cpp:
1499         * TestWebKitAPI/Tests/WebCore/IntRect.cpp:
1500         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
1501
1502 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1503
1504         [WPE][GTK] Add webkit_frame_get_id() API
1505         https://bugs.webkit.org/show_bug.cgi?id=197270
1506
1507         Reviewed by Carlos Garcia Campos.
1508
1509         This was hard, but I added a test to verify that two different WebKitFrames of the same
1510         WebKitWebPage return two different frame IDs.
1511
1512         * TestWebKitAPI/Tests/WebKitGLib/FrameTest.cpp:
1513         (WebKitFrameTest::willSubmitFormCallback):
1514         (WebKitFrameTest::testSubframe):
1515         (registerTests):
1516         * TestWebKitAPI/Tests/WebKitGLib/TestFrame.cpp:
1517         (testWebKitFrameSubframe):
1518         (beforeAll):
1519         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1520         (willSubmitFormCallback):
1521         * TestWebKitAPI/Tests/WebKitGLib/resources/form-in-frame.html: Added.
1522         * TestWebKitAPI/Tests/WebKitGLib/resources/webkitglib-tests.gresource.xml:
1523
1524 2019-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1525
1526         [WPE][GTK] Add WebKitWebPage::did-associate-form-controls-for-frame and deprecate original did-associate-form-controls
1527         https://bugs.webkit.org/show_bug.cgi?id=197271
1528
1529         Reviewed by Youenn Fablet.
1530
1531         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
1532         (formControlsAssociatedForFrameCallback):
1533         (pageCreatedCallback):
1534         (formControlsAssociatedCallback): Deleted.
1535
1536 2019-05-10  Adrian Perez de Castro  <aperez@igalia.com>
1537
1538         [Flatpak] Use the safe PyYAML loader if available
1539         https://bugs.webkit.org/show_bug.cgi?id=197771
1540
1541         Reviewed by Philippe Normand.
1542
1543         * flatpak/flatpakutils.py:
1544         (load_manifest): Use yaml.safe_load() if available, with yaml.load()
1545         still used as fallback when the former is not provided by the module.
1546
1547 2019-05-09  Fujii Hironori  <Hironori.Fujii@sony.com>
1548
1549         WinCairo WebKitTestRunner should take platform/wk2/TestExpectations into account
1550         https://bugs.webkit.org/show_bug.cgi?id=197734
1551
1552         Reviewed by Don Olmstead.
1553
1554         * Scripts/webkitpy/port/win.py:
1555         (WinCairoPort._search_paths): Add 'wk2' and
1556         additional_platform_directory to paths as well as other ports do.
1557
1558 2019-05-09  Daniel Bates  <dabates@apple.com>
1559
1560         [iOS] Numpad comma key has incorrect keyIdentifier property
1561         https://bugs.webkit.org/show_bug.cgi?id=197753
1562         <rdar://problem/50636274>
1563
1564         Reviewed by Brent Fulgham.
1565
1566         Recognize "numpadComma" and return the appropriate HID usage code.
1567
1568         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1569         (hidUsageCodeForCharacter):
1570
1571 2019-05-09  Eric Carlson  <eric.carlson@apple.com>
1572
1573         Refine AudioSession route sharing policy
1574         https://bugs.webkit.org/show_bug.cgi?id=197742
1575         <rdar://problem/50590818>
1576
1577         Reviewed by Darin Adler.
1578
1579         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1580         (TestWebKitAPI::TEST):
1581
1582 2019-05-09  Alex Christensen  <achristensen@webkit.org>
1583
1584         Remove unnecessary test SPI after r244883
1585         https://bugs.webkit.org/show_bug.cgi?id=197575
1586
1587         Reviewed by Tim Horton.
1588
1589         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1590         (TEST):
1591         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1592         (TestWebKitAPI::TEST):
1593
1594 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
1595
1596         [ews-app] Add migrations file to repository
1597         https://bugs.webkit.org/show_bug.cgi?id=197729
1598
1599         Reviewed by Jonathan Bedard.
1600
1601         * BuildSlaveSupport/ews-app/ews/migrations/0001_initial.py: Added. Auto-generated by Django based on models' information.
1602
1603 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
1604
1605         [ews-build] Fix formatting issues and typos
1606         https://bugs.webkit.org/show_bug.cgi?id=197737
1607
1608         Reviewed by Jonathan Bedard.
1609
1610         * BuildSlaveSupport/ews-build/steps.py:
1611         (CompileWebKit.evaluateCommand): Removed extra empty line.
1612         * BuildSlaveSupport/ews-build/steps_unittest.py:
1613         (TestRunWebKitPerlTests): Fixed typo.
1614         * BuildSlaveSupport/ews-app/ews/models/step.py:
1615         (Step.save_step): Changed log level to info so that it is logged in production.
1616
1617 2019-05-09  Aakash Jain  <aakash_jain@apple.com>
1618
1619         [ews-app] Production and Development env should configure DEBUG appropriately
1620         https://bugs.webkit.org/show_bug.cgi?id=197700
1621
1622         Reviewed by Jonathan Bedard.
1623
1624         * BuildSlaveSupport/ews-app/ews-app/settings.py:
1625
1626 2019-05-09  Xan López  <xan@igalia.com>
1627
1628         [CMake] Detect SSE2 at compile time
1629         https://bugs.webkit.org/show_bug.cgi?id=196488
1630
1631         Reviewed by Carlos Garcia Campos.
1632
1633         * Scripts/webkitdirs.pm:
1634         (generateBuildSystemFromCMakeProject): Do not add SSE2 flags here
1635         for x86 builds. This is now handled in WebKitCompilerFlags.cmake.
1636
1637 2019-05-08  Adrian Perez de Castro  <aperez@igalia.com>
1638
1639         [WPE] Update dependencies to use libwpe + WPEBackend-fdo 1.3.0
1640         https://bugs.webkit.org/show_bug.cgi?id=197697
1641
1642         Reviewed by Žan Doberšek.
1643
1644         * flatpak/org.webkit.WPEModules.yaml: Bump version and update checksums.
1645         * wpe/jhbuild.modules: Ditto.
1646
1647 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
1648
1649         Update ANGLE
1650         https://bugs.webkit.org/show_bug.cgi?id=197676
1651
1652         Reviewed by Alex Christensen.
1653
1654         * TestWebKitAPI/PlatformWin.cmake:
1655         Remove unnecessary library linkage.
1656
1657 2019-05-08  Stephan Szabo  <stephan.szabo@sony.com> and Fujii Hironori  <Hironori.Fujii@sony.com>
1658
1659         [Win] build-webkit should be ready for Visual Studio 2019
1660         https://bugs.webkit.org/show_bug.cgi?id=196622
1661
1662         Reviewed by Ross Kirsling.
1663
1664         1. Accommodated to the new msbuild.exe location of VS 2019.
1665         2. Removed the hard coded "Visual Studio 15" generator.
1666
1667         build-webkit is going to choose a Visual Studio generator version
1668         matching with the latest installed VS. If you invoke vcvars.bat
1669         before build-webkit, it chooses the corresponding Visual Studio
1670         generator version by cheking 'VisualStudioVersion' env var which
1671         is set by vcvars.bat.
1672
1673         * Scripts/webkitdirs.pm: Renamed $vcBuildPath to $msBuildPath. Removed $msBuildInstallDir.
1674         (msBuildPath): When looking for MSBuild, look in
1675         "MSBuild\Current\bin" (the new expected location) and fallback
1676         to "MSBuild\15.0\bin" if we can't find an MSBuild.exe in the
1677         first location.
1678         (msBuildInstallDir): Renamed to msBuildPath.
1679         (generateBuildSystemFromCMakeProject): Use -A switch to specify x64.
1680         Add -G "Visual Studio " switch if a env var 'VisualStudioVersion'
1681
1682 2019-05-08  Don Olmstead  <don.olmstead@sony.com>
1683
1684         [PlayStation] Update port options
1685         https://bugs.webkit.org/show_bug.cgi?id=197723
1686
1687         Reviewed by Ross Kirsling.
1688
1689         ICU headers were missing from TestWTF.
1690
1691         * TestWebKitAPI/PlatformPlayStation.cmake:
1692
1693 2019-05-08  Alex Christensen  <achristensen@webkit.org>
1694
1695         Don't crash when DOMNode.addEventListener:listener:useCapture: is called with a nil listener
1696         https://bugs.webkit.org/show_bug.cgi?id=197712
1697         <rdar://problem/50429770>
1698
1699         Reviewed by Tim Horton.
1700
1701         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm:
1702         (TestWebKitAPI::TEST):
1703
1704 2019-05-08  Jonathan Bedard  <jbedard@apple.com>
1705
1706         Change my status to be a WebKit reviewer.
1707
1708         * Scripts/webkitpy/common/config/contributors.json:
1709
1710 2019-05-08  Ryan Haddad  <ryanhaddad@apple.com>
1711
1712         Unreviewed, rolling out r244952.
1713
1714         Caused inspector to appear blank.
1715
1716         Reverted changeset:
1717
1718         "Web Inspector: Provide UIString descriptions to improve
1719         localizations"
1720         https://bugs.webkit.org/show_bug.cgi?id=195132
1721         https://trac.webkit.org/changeset/244952
1722
1723 2019-05-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1724
1725         TestRunnerWKWebView's menu callbacks should be cleared upon UI script completion
1726         https://bugs.webkit.org/show_bug.cgi?id=197685
1727
1728         Reviewed by Alex Christensen.
1729
1730         Fixes a bug in the test runner wherein didShowMenuCallback and didHideMenuCallback are not reset upon UI script
1731         completion. See LayoutTests/ChangeLog for more details.
1732
1733         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1734         (WTR::UIScriptController::platformClearAllCallbacks):
1735
1736 2019-05-07  Oriol Brufau  <obrufau@igalia.com>
1737
1738         Unreviewed. Add myself as a committer.
1739
1740         * Scripts/webkitpy/common/config/contributors.json:
1741
1742 2019-05-07  Ryan Haddad  <ryanhaddad@apple.com>
1743
1744         Unreviewed, rolling out r245038.
1745
1746         Breaks internal builds.
1747
1748         Reverted changeset:
1749
1750         "Add SPI to set a list of hosts to which to send custom header
1751         fields cross-origin"
1752         https://bugs.webkit.org/show_bug.cgi?id=197397
1753         https://trac.webkit.org/changeset/245038
1754
1755 2019-05-07  Joonghun Park  <pjh0718@gmail.com>
1756
1757         Unreviewed. Add myself as a committer.
1758
1759         * Scripts/webkitpy/common/config/contributors.json:
1760
1761 2019-05-07  Eric Carlson  <eric.carlson@apple.com>
1762
1763         Define media buffering policy
1764         https://bugs.webkit.org/show_bug.cgi?id=196979
1765         <rdar://problem/28383861>
1766
1767         Reviewed by Jer Noble.
1768
1769         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1770         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm: Added.
1771         (waitUntilBufferingPolicyIsEqualTo):
1772         (TEST):
1773
1774 2019-05-07  Alex Christensen  <achristensen@webkit.org>
1775
1776         Add SPI to set a list of hosts to which to send custom header fields cross-origin
1777         https://bugs.webkit.org/show_bug.cgi?id=197397
1778
1779         Reviewed by Geoff Garen.
1780
1781         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1782         (TEST):
1783         (expectLegacyHeaders):
1784         (expectHeaders):
1785         (-[CustomHeaderFieldsDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1786         (-[CustomHeaderFieldsDelegate webView:startURLSchemeTask:]):
1787         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1788
1789 2019-05-07  Keith Rollin  <krollin@apple.com>
1790
1791         Add option to build-webkit to control whether or not XCBuild is used
1792         https://bugs.webkit.org/show_bug.cgi?id=197668
1793         <rdar://problem/50549728>
1794
1795         Reviewed by Tim Horton.
1796
1797         Add --[no-]xcbuild to build-webkit to force the use of XCBuild or not.
1798         Also update build-webkit and the makefiles with the foundation for
1799         automatically using XCBuild when the conditions allow it. This latter
1800         facility is currently turned off until Xcode fully supports building
1801         WebKit with XCBuild.
1802
1803         * Scripts/build-webkit:
1804         * Scripts/webkitdirs.pm:
1805         (XcodeOptions):
1806         (canUseXCBuild):
1807
1808 2019-05-07  Andy Estes  <aestes@apple.com>
1809
1810         run-bindings-tests should test global scope constructor generation
1811         https://bugs.webkit.org/show_bug.cgi?id=197669
1812
1813         Reviewed by Alex Christensen.
1814
1815         * Scripts/webkitpy/bindings/main.py:
1816         Updated to specify --testGlobalContextName and --testGlobalScopeConstructorsFile when
1817         invoking preprocess-idls.pl.
1818
1819 2019-05-07  Youenn Fablet  <youenn@apple.com>
1820
1821         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageDefaultDirectories
1822         https://bugs.webkit.org/show_bug.cgi?id=195997
1823         <rdar://problem/50509884>
1824
1825         Reviewed by Chris Dumez.
1826
1827         Spin test until successful.
1828
1829         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1830
1831 2019-05-07  Adrian Perez de Castro  <aperez@igalia.com>
1832
1833         [Flatpak] webkit-build fails due to missing GTK2 in build environment
1834         https://bugs.webkit.org/show_bug.cgi?id=197352
1835
1836         Reviewed by Philippe Normand.
1837
1838         The Flatpak runtimes do not include GTK 2.x anymore, which means that we need
1839         to build it ourselves on top in order to be able to build the GTK 2.x plugin
1840         process.
1841
1842         * flatpak/org.webkit.GTK.yaml: Add gtk2 package.
1843
1844 2019-05-07  Wenson Hsieh  <wenson_hsieh@apple.com>
1845
1846         [macOS] Avoid crashing the UI process when writing empty data to the pasteboard
1847         https://bugs.webkit.org/show_bug.cgi?id=197644
1848         <rdar://problem/50526364>
1849
1850         Reviewed by Tim Horton.
1851
1852         Add a new API test to exercise a possible scenario where we may crash while writing data to the pasteboard.
1853
1854         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegate.mm:
1855         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1856         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1857         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:pasteboardDataForRange:]):
1858
1859 2019-05-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1860
1861         [GTK][WPE] MiniBrowser: load about:blank for new web views in automation mode
1862         https://bugs.webkit.org/show_bug.cgi?id=197651
1863
1864         Reviewed by Žan Doberšek.
1865
1866         This is required since the process creation was delayed until something is loaded in the view.
1867
1868         * MiniBrowser/gtk/BrowserWindow.c:
1869         (browser_window_get_or_create_web_view_for_automation):
1870         * MiniBrowser/wpe/main.cpp:
1871         (main):
1872
1873 2019-05-06  Tim Horton  <timothy_horton@apple.com>
1874
1875         _overrideViewportWithArguments does not work when called before loading
1876         https://bugs.webkit.org/show_bug.cgi?id=197638
1877         <rdar://problem/50505111>
1878
1879         Reviewed by Wenson Hsieh.
1880
1881         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1882         (TEST):
1883
1884 2019-05-04  Per Arne Vollan  <pvollan@apple.com>
1885
1886         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1887         https://bugs.webkit.org/show_bug.cgi?id=197510
1888
1889         Reviewed by Alex Christensen.
1890
1891         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1892         (TestWebKitAPI::TEST):
1893
1894 2019-05-06  Keith Rollin  <krollin@apple.com>
1895
1896         Temporarily disable generate-xcfilelists
1897         https://bugs.webkit.org/show_bug.cgi?id=197619
1898         <rdar://problem/50507392>
1899
1900         Reviewed by Alex Christensen.
1901
1902         We need to perform a significant update to the generate-xcfilelist
1903         scripts. This work involves coordinated work with another facility. If
1904         the work does not occur in tandem, the build will be broken. To avoid
1905         this, disable the invoking of the scripts during the transition. The
1906         checking will be restored once the new scripts are in place.
1907
1908         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1909         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1910
1911 2019-05-04  Alex Christensen  <achristensen@webkit.org>
1912
1913         Revert r244953 and r244954 because they broke internal builds.
1914         https://bugs.webkit.org/show_bug.cgi?id=197534
1915
1916         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1917         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1918         * DumpRenderTree/mac/DumpRenderTree.mm:
1919         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1920         * DumpRenderTree/mac/TestRunnerMac.mm:
1921         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1922         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1923         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1924         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1925         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1926         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1927         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
1928         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1929         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1930         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1931         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1932         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1933         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1934         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1935         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1936         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1937         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1938         * TestWebKitAPI/ios/UIKitSPI.h: Added.
1939         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1940         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
1941         * WebKitTestRunner/ios/HIDEventGenerator.h:
1942         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1943         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1944         * WebKitTestRunner/ios/TestControllerIOS.mm:
1945         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1946         * WebKitTestRunner/ios/mainIOS.mm:
1947
1948 2019-05-04  Alex Christensen  <achristensen@webkit.org>
1949
1950         Merge the three UIKitSPI.h files into a single one in PAL
1951         https://bugs.webkit.org/show_bug.cgi?id=197534
1952
1953         Reviewed by Darin Adler.
1954
1955         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1956         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1957         * DumpRenderTree/mac/DumpRenderTree.mm:
1958         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1959         * DumpRenderTree/mac/TestRunnerMac.mm:
1960         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1961         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
1962         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1963         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1964         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1965         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1966         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
1967         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1968         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1969         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1970         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1971         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
1972         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
1973         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1974         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1975         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1976         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1977         * TestWebKitAPI/ios/UIKitSPI.h: Removed.
1978         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1979         * WebKitTestRunner/ios/GeneratedTouchesDebugWindow.mm:
1980         * WebKitTestRunner/ios/HIDEventGenerator.h:
1981         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1982         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1983         * WebKitTestRunner/ios/TestControllerIOS.mm:
1984         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1985         * WebKitTestRunner/ios/mainIOS.mm:
1986
1987 2019-05-04  Nikita Vasilyev  <nvasilyev@apple.com>
1988
1989         Web Inspector: Provide UIString descriptions to improve localizations
1990         https://bugs.webkit.org/show_bug.cgi?id=195132
1991         <rdar://problem/48457817>
1992
1993         Reviewed by Devin Rousso.
1994
1995         Allow WI.UIString to take:
1996         - WI.UIString(string, key, comment)
1997         - WI.UIString(string, comment)
1998         - WI.UIString(string)
1999
2000         * Scripts/extract-localizable-js-strings:
2001
2002 2019-05-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2003
2004         REGRESSION (r244897): Caret may appear wider than normal after zooming to focus an editable element
2005         https://bugs.webkit.org/show_bug.cgi?id=197579
2006
2007         Reviewed by Tim Horton.
2008
2009         Fixes a couple of flaky layout tests (ModifyInputAssistantItemBarButtonGroups and
2010         OverrideInputAssistantItemBarButtonGroups) by programmatically blurring focused elements and waiting for the
2011         input session to change, rather than relying on -resignFirstResponder and -waitForNextPresentationUpdate to
2012         ensure that the the focused element has been blurred.
2013
2014         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2015
2016 2019-05-02  Alexey Proskuryakov  <ap@apple.com>
2017
2018         Add a tool to block spammer accounts
2019         https://bugs.webkit.org/show_bug.cgi?id=197537
2020
2021         Reviewed by Darin Adler.
2022
2023         Usage: block-spammers email1 email2 ...
2024
2025         The tool finds and hides all bugs and comments from this account. Before any work
2026         is done, these bugs and comments are displayed for confirmation.
2027
2028         * Scripts/block-spammers: Added.
2029         (get_bugzilla_token):
2030         (invalidate_bugzilla_token):
2031         (get_user_info):
2032         (get_user_info_self):
2033         (can_use_this_tool):
2034         (disable_user):
2035         (get_bugs_created_by_user):
2036         (get_bugs_commented_on_by_user):
2037         (get_comments):
2038         (hide_bug):
2039         (hide_comments):
2040         (ask_yes_no):
2041         (sanitized_string):
2042         (main):
2043
2044 2019-05-03  Jonathan Bedard  <jbedard@apple.com>
2045
2046         run-apit-tests: Add --iterations and --repeat-each
2047         https://bugs.webkit.org/show_bug.cgi?id=197563
2048
2049         Reviewed by Aakash Jain.
2050
2051         * Scripts/webkitpy/api_tests/manager.py:
2052         (Manager.run): Add --iterations and --repeat-each/
2053         * Scripts/webkitpy/api_tests/run_api_tests.py:
2054         (parse_args): Duplicate the test list based on --iterations and --repeat-each.
2055
2056 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2057
2058         New EWS: Clicking on white bubble navigates to page with only bubbles
2059         https://bugs.webkit.org/show_bug.cgi?id=197520
2060
2061         Reviewed by Lucas Forschler.
2062
2063         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Disable clicking if bubble doesn't have any url.
2064
2065 2019-05-03  Daniel Bates  <dabates@apple.com>
2066
2067         [lldb-webkit] Support adding pretty-printing for qualified types
2068         https://bugs.webkit.org/show_bug.cgi?id=197518
2069
2070         Reviewed by Darin Adler.
2071
2072         Remove all "::"s from the name of the specified type when computing the name for the Python classes
2073         that will provide summary and synthetic details as LLDB is not happy about registering such classes
2074         when they contain :: in their name.
2075
2076         * lldb/lldb_webkit.py:
2077         (addSummaryAndSyntheticFormattersForRawBitmaskType):
2078
2079 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2080
2081         New EWS: patches on recently added queues listed as #1 for older bugs
2082         https://bugs.webkit.org/show_bug.cgi?id=197496
2083
2084         Reviewed by Lucas Forschler.
2085
2086         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2087         (StatusBubble._build_bubble):
2088         (StatusBubble._queue_position):
2089
2090 2019-05-03  Aakash Jain  <aakash_jain@apple.com>
2091
2092         webkit-patch --no-review upload does not submit patch to New EWS
2093         https://bugs.webkit.org/show_bug.cgi?id=197519
2094         <rdar://problem/50424887>
2095
2096         Reviewed by Lucas Forschler.
2097
2098         * Scripts/webkitpy/tool/steps/submittoews.py:
2099         (SubmitToEWS.run): Submit to both old and new EWS.
2100         * Scripts/webkitpy/common/config/urls.py: Added url for new EWS server.
2101         * Scripts/webkitpy/common/net/ewsserver.py: Added.
2102         (EWSServer._server_url): Method to return server url.
2103         (EWSServer._post_patch_to_ews): Method to post patch to ews.
2104         (EWSServer.submit_to_ews): Method to submit the patch to ews using NetworkTransaction.
2105         * Scripts/webkitpy/common/net/ewsserver_mock.py: Added Mock EWS Server.
2106         * Scripts/webkitpy/common/net/ewsserver_unittest.py: Added unit-test for EWS Server.
2107         * Scripts/webkitpy/common/net/statusserver_mock.py:
2108         (MockStatusServer.submit_to_ews): Updated the log text.
2109         * Scripts/webkitpy/tool/commands/queues_unittest.py: Updated unit-tests.
2110         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
2111         * Scripts/webkitpy/tool/main.py:
2112         (WebKitPatch.__init__): Initialize ews_server. 
2113         * Scripts/webkitpy/tool/mocktool.py:
2114         (MockTool.__init__): Ditto.
2115
2116 2019-05-03  Chris Dumez  <cdumez@apple.com>
2117
2118         ASSERTION FAILED: [weakThis->m_view window] == weakThis->m_targetWindowForMovePreparation
2119         https://bugs.webkit.org/show_bug.cgi?id=197574
2120         <rdar://problem/50453181>
2121
2122         Reviewed by Tim Horton.
2123
2124         Add API test coverage.
2125
2126         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2127         (TEST):
2128
2129 2019-05-03  Yusuke Suzuki  <ysuzuki@apple.com>
2130
2131         [JSC] Generator CodeBlock generation should be idempotent
2132         https://bugs.webkit.org/show_bug.cgi?id=197552
2133
2134         Reviewed by Keith Miller.
2135
2136         * Scripts/run-javascriptcore-tests:
2137         (runJSCStressTests):
2138         * Scripts/run-jsc-stress-tests:
2139
2140 2019-05-03  Commit Queue  <commit-queue@webkit.org>
2141
2142         Unreviewed, rolling out r244881.
2143         https://bugs.webkit.org/show_bug.cgi?id=197559
2144
2145         Breaks compilation of jsconly on linux, breaking compilation
2146         for jsc-i386-ews, jsc-mips-ews and jsc-armv7-ews (Requested by
2147         guijemont on #webkit).
2148
2149         Reverted changeset:
2150
2151         "[CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into
2152         WEBKIT_COPY_FILES"
2153         https://bugs.webkit.org/show_bug.cgi?id=197174
2154         https://trac.webkit.org/changeset/244881
2155
2156 2019-05-03  Zan Dobersek  <zdobersek@igalia.com>
2157
2158         Unreviewed WPE build fix after r244898.
2159
2160         * WebKitTestRunner/wpe/TestControllerWPE.cpp:
2161         (WTR::TestController::abortModal): Add the missing (no-op) definition.
2162
2163 2019-05-02  Alex Christensen  <achristensen@webkit.org>
2164
2165         Mark U+01C0 as a homograph of U+006C
2166         https://bugs.webkit.org/show_bug.cgi?id=197526
2167         <rdar://problem/50301904>
2168
2169         Reviewed by Tim Horton.
2170
2171         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
2172         (TestWebKitAPI::TEST):
2173
2174 2019-05-02  Chris Dumez  <cdumez@apple.com>
2175
2176         Add test coverage for <rdar://problem/49731231>
2177         https://bugs.webkit.org/show_bug.cgi?id=196730
2178         <rdar://problem/49731231>
2179
2180         Reviewed by Ryosuke Niwa.
2181
2182         Add support for testRunner.abortModal() in macOS's WebKitTestRunner in order
2183         to match DumpRenderTree.
2184
2185         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2186         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2187         (WTR::TestRunner::abortModal):
2188         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2189         * WebKitTestRunner/TestController.cpp:
2190         (WTR::TestController::runModal):
2191         * WebKitTestRunner/TestController.h:
2192         * WebKitTestRunner/TestInvocation.cpp:
2193         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2194         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2195         (WTR::TestController::abortModal):
2196         * WebKitTestRunner/ios/TestControllerIOS.mm:
2197         (WTR::TestController::abortModal):
2198         * WebKitTestRunner/mac/TestControllerMac.mm:
2199         (WTR::TestController::abortModal):
2200         * WebKitTestRunner/win/TestControllerWin.cpp:
2201         (WTR::TestController::abortModal):
2202
2203 2019-05-02  Christopher Reid  <chris.reid@sony.com>
2204
2205         [CMake] Add support for LTO builds
2206         https://bugs.webkit.org/show_bug.cgi?id=188986
2207
2208         Reviewed by Don Olmstead.
2209
2210         Add support to configure --lto-mode with cmake builds.
2211
2212         * Scripts/build-webkit:
2213         * Scripts/webkitdirs.pm:
2214         (generateBuildSystemFromCMakeProject):
2215
2216 2019-05-02  John Wilander  <wilander@apple.com>
2217
2218         Make both filterForRegistrableDomains() in WebKit::NetworkProcess use WebCore::RegistrableDomain::uncheckedCreateFromHost()
2219         https://bugs.webkit.org/show_bug.cgi?id=197521
2220         <rdar://problem/49651503>
2221
2222         Reviewed by Brent Fulgham.
2223
2224         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
2225         (TestWebKitAPI::TEST):
2226            Added a test for host strings with leading dots since they are
2227            often used for the domain attribute in cookies.
2228
2229 2019-05-02  Per Arne Vollan  <pvollan@apple.com>
2230
2231         -[WKWebsiteDataStore removeDataOfTypes:forDataRecords:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
2232         https://bugs.webkit.org/show_bug.cgi?id=197510
2233
2234         Reviewed by Alex Christensen.
2235
2236         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2237         (TestWebKitAPI::TEST):
2238
2239 2019-05-02  Don Olmstead  <don.olmstead@sony.com>
2240
2241         [CMake] Refactor WEBKIT_MAKE_FORWARDING_HEADERS into WEBKIT_COPY_FILES
2242         https://bugs.webkit.org/show_bug.cgi?id=197174
2243
2244         Reviewed by Alex Christensen.
2245
2246         Make TestJSC dependent on JavaScriptCorePrivateFrameworkHeaders.
2247
2248         * TestWebKitAPI/PlatformGTK.cmake:
2249         * TestWebKitAPI/PlatformWPE.cmake:
2250
2251 2019-05-02  Alex Christensen  <achristensen@webkit.org>
2252
2253         Build fix for internal branch.
2254
2255         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2256         RetainPtr.h was not explicitly included.
2257
2258 2019-05-02  Jonathan Bedard  <jbedard@apple.com>
2259
2260         webkitpy: Ignore errors when shutting down an already shutdown simulator
2261         <https://bugs.webkit.org/show_bug.cgi?id=197514>
2262         <rdar://problem/50390247>
2263
2264         Reviewed by Lucas Forschler.
2265
2266         * Scripts/webkitpy/xcode/simulated_device.py:
2267         (SimulatedDevice._shut_down):
2268
2269 2019-05-02  Frederic Wang  <fwang@igalia.com>
2270
2271         [GTK][WPE] Disable "thin", "thick", "medium" values of mfrac@linethickness at runtime
2272         https://bugs.webkit.org/show_bug.cgi?id=196142
2273
2274         This patch introduces some experimental runtime flag to let users
2275         disable MathML features that are removed from MathML Core [1]. For now,
2276         these features are only disabled on GTK and WPE ports.
2277
2278         [1] https://mathml-refresh.github.io/mathml-core/
2279
2280         Reviewed by Rob Buis.
2281
2282         * DumpRenderTree/TestOptions.cpp:
2283         (TestOptions::TestOptions):
2284         * DumpRenderTree/TestOptions.h:
2285         * DumpRenderTree/mac/DumpRenderTree.mm:
2286         (setWebPreferencesForTestOptions):
2287
2288 2019-05-01  Don Olmstead  <don.olmstead@sony.com>
2289
2290         TestWebKitAPI config.h should be aware of what suite is being built
2291         https://bugs.webkit.org/show_bug.cgi?id=196583
2292
2293         Reviewed by Konstantin Tokarev.
2294
2295         Migrate to WEBKIT_EXECUTABLE to define the Test* executables. As an added
2296         benefit the macro defines BUILDING_* for the executable which allows the includes
2297         of the config.h to be tailored to the test suite being built. Because of that the
2298         dependencies of the Test* executable are specific to the test suite which may
2299         speed up the build.
2300
2301         Some source files were including "PlatformUtilities.h" which includes WebKit headers
2302         when "Utilities.h" is what was needed.
2303
2304         * TestWebKitAPI/CMakeLists.txt:
2305         * TestWebKitAPI/PlatformGTK.cmake:
2306         * TestWebKitAPI/PlatformJSCOnly.cmake:
2307         * TestWebKitAPI/PlatformMac.cmake:
2308         * TestWebKitAPI/PlatformPlayStation.cmake:
2309         * TestWebKitAPI/PlatformUtilities.h:
2310         * TestWebKitAPI/PlatformWPE.cmake:
2311         * TestWebKitAPI/PlatformWin.cmake:
2312         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2313         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2314         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
2315         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
2316         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm:
2317         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm:
2318         * TestWebKitAPI/config.h:
2319
2320 2019-05-01  Jiewen Tan  <jiewen_tan@apple.com>
2321
2322         Move Document::domainIsRegisterable to SecurityOrigin::isMatchingRegistrableDomainSuffix
2323         https://bugs.webkit.org/show_bug.cgi?id=181950
2324         <rdar://problem/43357371>
2325
2326         Reviewed by Brent Fulgham.
2327
2328         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
2329         (TestWebKitAPI::TEST_F):
2330
2331 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
2332
2333         Remove webkitpy and bindings EWS queues from dashboard
2334         https://bugs.webkit.org/show_bug.cgi?id=197475
2335
2336         Reviewed by Alexey Proskuryakov.
2337
2338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
2339
2340 2019-05-01  Aakash Jain  <aakash_jain@apple.com>
2341
2342         Remove webkitpy and bindings test queues from old EWS
2343         https://bugs.webkit.org/show_bug.cgi?id=197468
2344
2345         Reviewed by Alexey Proskuryakov.
2346
2347         * QueueStatusServer/config/queues.py:
2348
2349 2019-04-30  Tim Horton  <timothy_horton@apple.com>
2350
2351         Fix the WebKitTestRunner build
2352         https://bugs.webkit.org/show_bug.cgi?id=197449
2353         <rdar://problem/50334169>
2354
2355         Reviewed by Alexey Proskuryakov.
2356
2357         * WebKitTestRunner/mac/EventSenderProxy.mm:
2358         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2359         (WTR::EventSenderProxy::mouseForceChanged):
2360         Use some SPI instead of IPI.
2361
2362 2019-04-30  Chris Dumez  <cdumez@apple.com>
2363
2364         Regression(PSON) URL scheme handlers can no longer respond asynchronously
2365         https://bugs.webkit.org/show_bug.cgi?id=197426
2366         <rdar://problem/50256169>
2367
2368         Reviewed by Brady Eidson.
2369
2370         Add API test coverage.
2371
2372         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2373         (-[PSONScheme setShouldRespondAsynchronously:]):
2374         (-[PSONScheme webView:startURLSchemeTask:]):
2375         (-[PSONScheme webView:stopURLSchemeTask:]):
2376
2377 2019-04-30  Chris Dumez  <cdumez@apple.com>
2378
2379         Unreviewed, rolling out r244802.
2380
2381         Caused an API test failure
2382
2383         Reverted changeset:
2384
2385         "Regression(PSON) URL scheme handlers can no longer respond
2386         asynchronously"
2387         https://bugs.webkit.org/show_bug.cgi?id=197426
2388         https://trac.webkit.org/changeset/244802
2389
2390 2019-04-30  Chris Dumez  <cdumez@apple.com>
2391
2392         Regression(PSON) URL scheme handlers can no longer respond asynchronously
2393         https://bugs.webkit.org/show_bug.cgi?id=197426
2394         <rdar://problem/50256169>
2395
2396         Reviewed by Brady Eidson.
2397
2398         Add API test coverage.
2399
2400         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2401         (-[PSONScheme setShouldRespondAsynchronously:]):
2402         (-[PSONScheme webView:startURLSchemeTask:]):
2403         (-[PSONScheme webView:stopURLSchemeTask:]):
2404
2405 2019-04-30  Chris Dumez  <cdumez@apple.com>
2406
2407         Only use a related page's process if that page has not been closed yet
2408         https://bugs.webkit.org/show_bug.cgi?id=197393
2409         <rdar://problem/50302423>
2410
2411         Reviewed by Tim Horton.
2412
2413         Add API test coverage.
2414
2415         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2416
2417 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2418
2419         [ews-build] Enable Bindings tests queue on new EWS
2420         https://bugs.webkit.org/show_bug.cgi?id=197424
2421
2422         Reviewed by Lucas Forschler.
2423
2424         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2425         (StatusBubble):
2426         * BuildSlaveSupport/ews-build/config.json:
2427
2428 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2429
2430         [ews-build] Configure ews151 for running various tests
2431         https://bugs.webkit.org/show_bug.cgi?id=197419
2432
2433         Reviewed by Lucas Forschler.
2434
2435         * BuildSlaveSupport/ews-build/config.json:
2436
2437 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2438
2439         [ews-build] Parse and display bindings test failures
2440         https://bugs.webkit.org/show_bug.cgi?id=197423
2441
2442         Reviewed by Lucas Forschler.
2443
2444         * BuildSlaveSupport/ews-build/steps.py:
2445         (RunBindingsTests.__init__): Set timeout of 5 minutes.
2446         (RunBindingsTests.start): Initialize log_observer for json output.
2447         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
2448         (RunBindingsTests._addToLog): Method to add message to log.
2449         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
2450
2451 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
2452
2453         Unreviewed. Add myself as a committer.
2454
2455         * Scripts/webkitpy/common/config/contributors.json:
2456
2457 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2458
2459         [ews-build] Enable webkitpy queue on new EWS
2460         https://bugs.webkit.org/show_bug.cgi?id=197396
2461
2462         Reviewed by Lucas Forschler.
2463
2464         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2465         (StatusBubble):
2466         * BuildSlaveSupport/ews-build/config.json:
2467
2468 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
2469
2470         [ews-build] Parse and display webkitpy failures
2471         https://bugs.webkit.org/show_bug.cgi?id=197395
2472
2473         Reviewed by Lucas Forschler.
2474
2475         * BuildSlaveSupport/ews-build/steps.py:
2476         (RunWebKitPyTests.start): Initialize log_observer for json output.
2477         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
2478         (RunWebKitPyTests._addToLog): Method to add message to log.
2479         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
2480
2481 2019-04-29  Alex Christensen  <achristensen@webkit.org>
2482
2483         <rdar://problem/50299396> Fix internal High Sierra build
2484         https://bugs.webkit.org/show_bug.cgi?id=197388
2485
2486         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2487         * MiniBrowser/Configurations/Base.xcconfig:
2488         * MobileMiniBrowser/Configurations/Base.xcconfig:
2489         * TestWebKitAPI/Configurations/Base.xcconfig:
2490         * WebKitTestRunner/Configurations/Base.xcconfig:
2491
2492 2019-04-29  Youenn Fablet  <youenn@apple.com>
2493
2494         Remove spurious GVA printf logging
2495         https://bugs.webkit.org/show_bug.cgi?id=197368
2496         <rdar://problem/35975256>
2497
2498         Reviewed by Alexey Proskuryakov.
2499
2500         * Scripts/webkitpy/port/mac.py:
2501         (MacPort.logging_patterns_to_strip):
2502
2503 2019-04-29  Youenn Fablet  <youenn@apple.com>
2504
2505         getDisplayMedia should be called on user gesture
2506         https://bugs.webkit.org/show_bug.cgi?id=197356
2507         <rdar://problem/50296074>
2508
2509         Reviewed by Eric Carlson.
2510
2511         Update test configuration to inject internals
2512         so that we can use it to simulate a user click to call getDisplayMedia.
2513
2514         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
2515         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
2516         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
2517
2518 2019-04-26  Stephanie Lewis  <slewis@apple.com>
2519
2520         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
2521         https://bugs.webkit.org/show_bug.cgi?id=197339
2522
2523         Reviewed by Dewei Zhu.
2524
2525         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
2526         test run for setup steps that are too expensive to do every iteration.
2527
2528         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2529         (BenchmarkRunner._run_benchmark):
2530         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2531         (BrowserDriver):
2532         (BrowserDriver.prepare_initial_env):
2533         (BrowserDriver.restore_env_after_all_testing):
2534         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
2535         (LinuxBrowserDriver.prepare_initial_env):
2536         (LinuxBrowserDriver.restore_env_after_all_testing):
2537         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2538         (OSXBrowserDriver.prepare_initial_env):
2539         (OSXBrowserDriver.restore_env_after_all_testing):
2540
2541 2019-04-28  Andy Estes  <aestes@apple.com>
2542
2543         Fix the watchOS engineering build.
2544
2545         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
2546         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
2547
2548 2019-04-27  Chris Dumez  <cdumez@apple.com>
2549
2550         [WKTR] Move test timeout handling to the UIProcess
2551         https://bugs.webkit.org/show_bug.cgi?id=197333
2552
2553         Reviewed by Darin Adler.
2554
2555         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
2556         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
2557         every WebContent process in the case of swapping.
2558
2559         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
2560         would lead to crashes when firing the timer.
2561
2562         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2563         (WTR::InjectedBundle::didReceiveMessageToPage):
2564         (WTR::InjectedBundle::done):
2565         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2566         (WTR::InjectedBundle::shouldDumpPixels const):
2567         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2568         (WTR::TestRunner::TestRunner):
2569         (WTR::TestRunner::waitUntilDone):
2570         (WTR::TestRunner::setWaitUntilDone):
2571         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2572         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2573         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2574         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2575         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
2576         * WebKitTestRunner/TestInvocation.cpp:
2577         (WTR::TestInvocation::TestInvocation):
2578         (WTR::TestInvocation::createTestSettingsDictionary):
2579         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2580         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2581         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
2582         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
2583         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
2584         (WTR::TestInvocation::setWaitUntilDone):
2585         (WTR::TestInvocation::done):
2586         * WebKitTestRunner/TestInvocation.h:
2587
2588 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
2589
2590         [JSC] linkPolymorphicCall now does GC
2591         https://bugs.webkit.org/show_bug.cgi?id=197306
2592
2593         Reviewed by Saam Barati.
2594
2595         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
2596         To add this test, we add `runWithoutBaseOption`.
2597
2598         * Scripts/run-jsc-stress-tests:
2599
2600 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
2601
2602         Update inactive reviewers' status to 'contributor'.
2603
2604         Accidentally skipped one at first.
2605
2606         * Scripts/webkitpy/common/config/contributors.json:
2607
2608 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
2609
2610         Update inactive reviewers' status to 'contributor'.
2611
2612         * Scripts/webkitpy/common/config/contributors.json: The change.
2613
2614         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2615         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2616         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2617         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2618         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2619         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2620         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2621         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2622         Sadly, regression tests operate on a crazy mix of mock and live data for
2623         contributors.json. It would be a substantial project to mock all code paths,
2624         so changing the tests instead.
2625
2626 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
2627
2628         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2629         https://bugs.webkit.org/show_bug.cgi?id=197171
2630         <rdar://problem/47454979>
2631
2632         Reviewed by Youenn Fablet.
2633
2634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2635         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2636         (TestWebKitAPI::TEST):
2637
2638 2019-04-26  David Kilzer  <ddkilzer@apple.com>
2639
2640         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
2641         <https://webkit.org/b/197314>
2642         <rdar://problem/50245252>
2643
2644         Reviewed by Simon Fraser.
2645
2646         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2647         (WTR::UIScriptController::lastUndoLabel const):
2648         (WTR::UIScriptController::firstRedoLabel const):
2649         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
2650
2651         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2652         (-[HIDEventGenerator sendEventStream:completionBlock:]):
2653         - Call -autorelease to fix leak of NSDictionary.
2654
2655         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2656         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
2657         (WTR::UIScriptController::selectFormPopoverTitle const):
2658         (WTR::UIScriptController::textContentType const):
2659         (WTR::UIScriptController::formInputLabel const):
2660         (WTR::UIScriptController::scrollingTreeAsText const):
2661         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
2662
2663 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
2664
2665         webkitpy: Running a single test will always use the default device
2666         https://bugs.webkit.org/show_bug.cgi?id=195472
2667         <rdar://problem/48724825>
2668
2669         Reviewed by Lucas Forschler.
2670
2671         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
2672         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
2673         requested will be run regardless of what shard they are in.
2674
2675         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2676         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
2677         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2678         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
2679         on the default device type.
2680         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2681         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
2682         (RunTest.test_run_part): Ditto.
2683
2684 2019-04-26  Alex Christensen  <achristensen@webkit.org>
2685
2686         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
2687         https://bugs.webkit.org/show_bug.cgi?id=197165
2688
2689         Reviewed by Youenn Fablet.
2690
2691         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2692
2693 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
2694
2695         Replace iOS build queue hardware
2696         https://bugs.webkit.org/show_bug.cgi?id=197312
2697
2698         Reviewed by Aakash Jain.
2699
2700         * BuildSlaveSupport/build.webkit.org-config/config.json:
2701         Use newer hardware that supports macOS Mojave.
2702
2703 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
2704
2705         check-webkit-style complains the first block in while loop.
2706         https://bugs.webkit.org/show_bug.cgi?id=197307
2707
2708         The style checker shouldn't complain about an open brace on
2709         its own line if the last non-whitespace character on the previous
2710         non-blank line is another open brace, because it's likely to
2711         indicate the begining of a nested code block.
2712
2713         Reviewed by Alex Christensen.
2714
2715         * Scripts/webkitpy/style/checkers/cpp.py:
2716         (check_braces):
2717         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2718         (WebKitStyleTest.test_braces):
2719
2720 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
2721
2722         Stop IDB transactions to release locked database files when network process is ready to suspend
2723         https://bugs.webkit.org/show_bug.cgi?id=196372
2724         <rdar://problem/48930116>
2725
2726         Reviewed by Brady Eidson.
2727
2728         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2729         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
2730         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
2731         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
2732         (runTestAndCheckResult):
2733         (keepNetworkProcessActive):
2734         (TEST):
2735
2736 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
2737
2738         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
2739         https://bugs.webkit.org/show_bug.cgi?id=188357
2740         <rdar://problem/42986633>
2741
2742         Reviewed by Dean Jackson.
2743
2744         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
2745         tests would fall into low memory mode and have different behavior.
2746         
2747         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
2748         to Internals, so it's shared by DRT and WTR.
2749         
2750         We no longer need the WK2 C SPI glue.
2751
2752         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2753         (WTR::InjectedBundlePage::prepare):
2754
2755 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
2756
2757         webkitpy: Including skipped tests in the final count
2758         https://bugs.webkit.org/show_bug.cgi?id=197298
2759         <rdar://problem/49705424>
2760
2761         Reviewed by Lucas Forschler.
2762
2763         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
2764         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
2765
2766 2019-04-25  Timothy Hatcher  <timothy@apple.com>
2767
2768         Disable date and time inputs on iOSMac.
2769         https://bugs.webkit.org/show_bug.cgi?id=197287
2770         rdar://problem/46794376
2771
2772         Reviewed by Wenson Hsieh.
2773
2774         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2775
2776 2019-04-25  Alex Christensen  <achristensen@webkit.org>
2777
2778         Fix test-webkitpy after r244653
2779         https://bugs.webkit.org/show_bug.cgi?id=197131
2780
2781         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2782         Also use C++17.
2783
2784 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
2785
2786         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
2787         https://bugs.webkit.org/show_bug.cgi?id=196991
2788         <rdar://problem/45507423>
2789
2790         Reviewed by Alex Christensen.
2791
2792         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2793         (-[NavigationTestDelegate init]):
2794         (-[NavigationTestDelegate waitForDidFinishNavigation]):
2795         (-[NavigationTestDelegate webView:didFinishNavigation:]):
2796         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
2797         (TestWebKitAPI::TEST):
2798         (TEST): Deleted.
2799
2800 2019-04-25  Alex Christensen  <achristensen@webkit.org>
2801
2802         Revert some code accidentally committed with r244653
2803         https://bugs.webkit.org/show_bug.cgi?id=197131
2804
2805         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
2806         (TestWebKitAPI::TEST):
2807
2808 2019-04-25  Alex Christensen  <achristensen@webkit.org>
2809
2810         Start using C++17
2811         https://bugs.webkit.org/show_bug.cgi?id=197131
2812
2813         Reviewed by Darin Adler.
2814
2815         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2816         * MiniBrowser/Configurations/Base.xcconfig:
2817         * MobileMiniBrowser/Configurations/Base.xcconfig:
2818         * TestWebKitAPI/Configurations/Base.xcconfig:
2819         * WebKitTestRunner/Configurations/Base.xcconfig:
2820
2821 2019-04-25  Commit Queue  <commit-queue@webkit.org>
2822
2823         Unreviewed, rolling out r244627.
2824         https://bugs.webkit.org/show_bug.cgi?id=197282
2825
2826         Causing internal build failures (Requested by ShawnRoberts on
2827         #webkit).
2828
2829         Reverted changeset:
2830
2831         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
2832         https://bugs.webkit.org/show_bug.cgi?id=197171
2833         https://trac.webkit.org/changeset/244627
2834
2835 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2836
2837         [GTK] Hardcoded text color in input fields
2838         https://bugs.webkit.org/show_bug.cgi?id=126907
2839
2840         Reviewed by Michael Catanzaro.
2841
2842         Add dark-mode command line option to MiniBrowser.
2843
2844         * MiniBrowser/gtk/main.c:
2845         (main):
2846
2847 2019-04-24  Zalan Bujtas  <zalan@apple.com>
2848
2849         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2850         https://bugs.webkit.org/show_bug.cgi?id=196948
2851         <rdar://problem/49927131>
2852
2853         Reviewed by Tim Horton.
2854
2855         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2856         (TEST):
2857         The expected order of incoming events is
2858         1. didInvalidateIntrinsicContentSize
2859         2. didFirstLayout
2860         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
2861         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
2862         (and remember, all we care about is ordering).
2863
2864 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
2865
2866         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
2867         https://bugs.webkit.org/show_bug.cgi?id=197171
2868         <rdar://problem/47454979>
2869
2870         Reviewed by Youenn Fablet.
2871
2872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2873         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
2874         (TestWebKitAPI::TEST):
2875
2876 2019-04-24  Brady Eidson  <beidson@apple.com>
2877
2878         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
2879         https://bugs.webkit.org/show_bug.cgi?id=191362
2880
2881         Reviewed by Alex Christensen.
2882
2883         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
2884           from an XHR to a custom protocol.
2885
2886 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
2887
2888         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
2889         https://bugs.webkit.org/show_bug.cgi?id=197273
2890
2891         Reviewed by Dean Jackson.
2892
2893         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
2894         so that WebCoreTestSupport::resetInternalsObject() is always run.
2895
2896         * DumpRenderTree/mac/DumpRenderTree.mm:
2897         (resetWebViewToConsistentStateBeforeTesting):
2898         (runTest):
2899
2900 2019-04-24  John Wilander  <wilander@apple.com>
2901
2902         Age out unconverted Ad Click Attributions after one week.
2903         https://bugs.webkit.org/show_bug.cgi?id=197238
2904         <rdar://problem/50177349>
2905
2906         Reviewed by Chris Dumez.
2907
2908         This patch adds infrastructure to allow tests to expire all unconverted
2909         attributions early.
2910
2911         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2912         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2913         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
2914         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2915         * WebKitTestRunner/TestController.cpp:
2916         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
2917         * WebKitTestRunner/TestController.h:
2918         * WebKitTestRunner/TestInvocation.cpp:
2919         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2920
2921 2019-04-24  Chris Dumez  <cdumez@apple.com>
2922
2923         Fix flaky crashes in a couple of PSON API tests
2924         https://bugs.webkit.org/show_bug.cgi?id=197239
2925
2926         Reviewed by Tim Horton.
2927
2928         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
2929
2930         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2931
2932 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
2933
2934         Make it possible to control the renderTreeAsText output by setting options on testRunner
2935         https://bugs.webkit.org/show_bug.cgi?id=197133
2936
2937         Reviewed by Sam Weinig.
2938
2939         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
2940         that make sense in testing (those that don't dump unstable data like addresses), and plumb
2941         these flags through the various framework layers.
2942
2943         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
2944
2945         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
2946         and hand-code DumpRenderTree bindings.
2947
2948         Some cleanup of the TestRunners, using member initializers.
2949
2950         * DumpRenderTree/TestRunner.cpp:
2951         (TestRunner::TestRunner):
2952         (setRenderTreeDumpOptionsCallback):
2953         (TestRunner::staticFunctions):
2954         (TestRunner::setRenderTreeDumpOptions):
2955         * DumpRenderTree/TestRunner.h:
2956         (TestRunner::renderTreeDumpOptions const):
2957         * DumpRenderTree/mac/DumpRenderTree.mm:
2958         (dump):
2959         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2960         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2961         (WTR::InjectedBundlePage::dump):
2962         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2963         (WTR::TestRunner::TestRunner):
2964         (WTR::TestRunner::setRenderTreeDumpOptions):
2965         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2966         (WTR::TestRunner::renderTreeDumpOptions const):
2967
2968 2019-04-24  Alex Christensen  <achristensen@webkit.org>
2969
2970         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
2971         https://bugs.webkit.org/show_bug.cgi?id=197078
2972         <rdar://problem/49564348>
2973
2974         Reviewed by Geoff Garen.
2975
2976         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2977         (TEST_F):
2978         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
2979         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
2980         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
2981
2982 2019-04-24  Alex Christensen  <achristensen@webkit.org>
2983
2984         Add unit test for r239322
2985         https://bugs.webkit.org/show_bug.cgi?id=197236
2986
2987         Reviewed by Chris Dumez.
2988
2989         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
2990         May as well add the test infrastructure which was needed before and will be needed in the future.
2991
2992         * TestWebKitAPI/TCPServer.cpp:
2993         (TestWebKitAPI::TCPServer::TCPServer):
2994         * TestWebKitAPI/TCPServer.h:
2995         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2996         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2997         (TestWebKitAPI::TEST):
2998         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2999         (TestWebKitAPI::downloadAtRate):
3000         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
3001         (TEST):
3002         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
3003         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3004         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3005         (TestWebKitAPI::TEST):
3006         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3007         (TEST):
3008
3009 2019-04-24  Chris Dumez  <cdumez@apple.com>
3010
3011         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
3012         https://bugs.webkit.org/show_bug.cgi?id=197214
3013         <rdar://problem/49237544>
3014
3015         Reviewed by Alex Christensen.
3016
3017         Extend API test coverage.
3018
3019         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
3020         (TEST):
3021
3022 2019-04-24  Philippe Normand  <pnormand@igalia.com>
3023
3024         [Build][GStreamer] Update to 1.16.0
3025         https://bugs.webkit.org/show_bug.cgi?id=197157
3026
3027         Reviewed by Xabier Rodriguez-Calvar.
3028
3029         The upstreamed patches were removed and a new one was added for a
3030         regression detected in the scaletempo GStreamer element. The GNOME
3031         Flatpak was migrated to 3.32 and I switched a few modules to Meson
3032         on the way, as it is the preferred build system now in GStreamer
3033         1.16.
3034
3035         * flatpak/files/httpd-autogen.sh:
3036         * flatpak/flatpakutils.py:
3037         (FlatpakPackage.install):
3038         (WebkitFlatpak.run_in_sandbox):
3039         * flatpak/org.webkit.CommonModules.yaml:
3040         * flatpak/org.webkit.WebKit.yaml:
3041         * gstreamer/jhbuild.modules:
3042         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
3043         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
3044         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
3045         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
3046         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
3047         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
3048         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
3049         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
3050         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
3051         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
3052         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
3053         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
3054         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
3055         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
3056         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
3057         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
3058         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
3059         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
3060         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
3061         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
3062         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
3063         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
3064
3065 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3066
3067         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
3068         https://bugs.webkit.org/show_bug.cgi?id=197156
3069
3070         Reviewed by Michael Catanzaro.
3071
3072         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
3073         support was added.
3074
3075         * MiniBrowser/gtk/BrowserTab.c:
3076         (browser_tab_set_background_color): Set the passed in color as web view background color.
3077         * MiniBrowser/gtk/BrowserTab.h:
3078         * MiniBrowser/gtk/BrowserWindow.c:
3079         (browser_window_init): Initialize backgroundColor.
3080         (browser_window_append_view): Call browser_tab_set_background_color().
3081         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
3082         are added.
3083         * MiniBrowser/gtk/main.c:
3084         (main): Call browser_window_set_background_color() before creating the tabs.
3085
3086 2019-04-23  John Wilander  <wilander@apple.com>
3087
3088         Move Ad Click Attribution from internal feature to experimental feature
3089         https://bugs.webkit.org/show_bug.cgi?id=197218
3090         <rdar://problem/47651691>
3091
3092         Reviewed by Brent Fulgham.
3093
3094         * DumpRenderTree/TestOptions.cpp:
3095         (TestOptions::TestOptions):
3096
3097 2019-04-23  Andy Estes  <aestes@apple.com>
3098
3099         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
3100         https://bugs.webkit.org/show_bug.cgi?id=196749
3101         <rdar://problem/35773454>
3102
3103         Reviewed by Daniel Bates.
3104
3105         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
3106
3107         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3108         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
3109         (-[QuickLookDelegate webView:didFinishNavigation:]):
3110         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
3111         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3112         (runTest):
3113         (runTestDecideBeforeLoading):
3114         (runTestDecideAfterLoading):
3115         (TEST):
3116
3117 2019-04-23  John Wilander  <wilander@apple.com>
3118
3119         Remove Ad Click Attribution data when removing website data
3120         https://bugs.webkit.org/show_bug.cgi?id=197215
3121         <rdar://problem/47668988>
3122
3123         Reviewed by Chris Dumez.
3124
3125         This patch adds test infrastructure to delete Ad Click Attribution data
3126         through WebsiteDataStore::removeData().
3127
3128         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3129         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3130         (WTR::TestRunner::clearAdClickAttribution):
3131         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
3132         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3133         * WebKitTestRunner/TestController.cpp:
3134         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
3135         * WebKitTestRunner/TestController.h:
3136         * WebKitTestRunner/TestInvocation.cpp:
3137         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3138
3139 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
3140
3141         webkitpy: Kill unresponsive worker processes
3142         https://bugs.webkit.org/show_bug.cgi?id=197205
3143         <rdar://problem/50104388>
3144
3145         Reviewed by Lucas Forschler.
3146
3147         * Scripts/webkitpy/common/message_pool.py:
3148         (_MessagePool.__init__): Add close timeout.
3149         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
3150
3151 2019-04-23  Alex Christensen  <achristensen@webkit.org>
3152
3153         Add unit tests for WKWebView.serverTrust
3154         https://bugs.webkit.org/show_bug.cgi?id=197202
3155
3156         Reviewed by Youenn Fablet
3157
3158         * TestWebKitAPI/TCPServer.cpp:
3159         (TestWebKitAPI::deleter<BIO>::operator()):
3160         (TestWebKitAPI::deleter<SSL>::operator()):
3161         (TestWebKitAPI::deleter<X509>::operator()):
3162         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
3163         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
3164         (TestWebKitAPI::TCPServer::TCPServer):
3165         (TestWebKitAPI::TCPServer::listenForConnections):
3166         * TestWebKitAPI/TCPServer.h:
3167         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3168         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3169         (TestWebKitAPI::TEST):
3170         (verifyCertificateAndPublicKey):
3171         (-[ServerTrustDelegate webView:didFinishNavigation:]):
3172         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3173         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3174         (TestWebKitAPI::downloadAtRate):
3175         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
3176         (TEST):
3177         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
3178         (TEST):
3179
3180 2019-04-23  Commit Queue  <commit-queue@webkit.org>
3181
3182         Unreviewed, rolling out r244556.
3183         https://bugs.webkit.org/show_bug.cgi?id=197212
3184
3185         Causing build failures on multiple builders (Requested by
3186         ShawnRoberts on #webkit).
3187
3188         Reverted changeset:
3189
3190         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
3191         https://bugs.webkit.org/show_bug.cgi?id=197171
3192         https://trac.webkit.org/changeset/244556
3193
3194 2019-04-23  Alex Christensen  <achristensen@webkit.org>
3195
3196         Fix iOS build.
3197         https://bugs.webkit.org/show_bug.cgi?id=195537
3198
3199         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3200         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
3201         AdoptWK constructor is private now.  Use adoptWK instead.
3202
3203 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
3204
3205         Accessibility text search and selection API enhancements.
3206         https://bugs.webkit.org/show_bug.cgi?id=197095
3207         <rdar://problem/48181791>
3208
3209         Reviewed by Chris Fleizach.
3210
3211         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
3212
3213         * DumpRenderTree/AccessibilityTextMarker.h:
3214         * DumpRenderTree/AccessibilityUIElement.cpp:
3215         (searchTextWithCriteriaCallback):
3216         (AccessibilityUIElement::getJSClass):
3217         * DumpRenderTree/AccessibilityUIElement.h:
3218         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3219         (convertVectorToObjectArray):
3220         (convertNSArrayToVector):
3221         (searchTextParameterizedAttributeForCriteria):
3222         (AccessibilityUIElement::getLinkedUIElements):
3223         (AccessibilityUIElement::getDocumentLinks):
3224         (AccessibilityUIElement::getChildren):
3225         (AccessibilityUIElement::getChildrenWithRange):
3226         (AccessibilityUIElement::rowHeaders const):
3227         (AccessibilityUIElement::columnHeaders const):
3228         (AccessibilityUIElement::uiElementArrayAttributeValue const):
3229         (AccessibilityUIElement::searchTextWithCriteria):
3230         (AccessibilityUIElement::attributesOfColumnHeaders):
3231         (AccessibilityUIElement::attributesOfRowHeaders):
3232         (AccessibilityUIElement::attributesOfColumns):
3233         (AccessibilityUIElement::attributesOfRows):
3234         (AccessibilityUIElement::attributesOfVisibleCells):
3235         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3236         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3237         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3238         (WTR::convertVectorToObjectArray):
3239         (WTR::convertNSArrayToVector):
3240         (WTR::searchTextParameterizedAttributeForCriteria):
3241         (WTR::AccessibilityUIElement::getLinkedUIElements):
3242         (WTR::AccessibilityUIElement::getDocumentLinks):
3243         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
3244         (WTR::AccessibilityUIElement::getChildren):
3245         (WTR::AccessibilityUIElement::getChildrenWithRange):
3246         (WTR::AccessibilityUIElement::rowHeaders const):
3247         (WTR::AccessibilityUIElement::columnHeaders const):
3248         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
3249         (WTR::AccessibilityUIElement::searchTextWithCriteria):
3250         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
3251         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
3252         (WTR::AccessibilityUIElement::attributesOfColumns):
3253         (WTR::AccessibilityUIElement::attributesOfRows):
3254         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
3255         (WTR::convertElementsToObjectArray): Deleted.
3256
3257 2019-04-23  Guy Lewin  <guy@lewin.co.il>
3258
3259         Multiple File Input Icon Set Regardless of File List
3260         https://bugs.webkit.org/show_bug.cgi?id=195537
3261
3262         Reviewed by Alexey Proskuryakov.
3263
3264         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
3265         display string in iOS file inputs
3266
3267         * DumpRenderTree/TestRunner.cpp:
3268         (SetOpenPanelFilesMediaIconCallback):
3269         (TestRunner::staticFunctions):
3270         (TestRunner::setOpenPanelFilesMediaIcon):
3271         * DumpRenderTree/TestRunner.h:
3272         (TestRunner::openPanelFilesMediaIcon const):
3273         * DumpRenderTree/mac/UIDelegate.mm:
3274         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
3275         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3276         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3277         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
3278         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3279         * WebKitTestRunner/TestController.cpp:
3280         (WTR::runOpenPanel):
3281         (WTR::TestController::resetStateToConsistentValues):
3282         * WebKitTestRunner/TestController.h:
3283         (WTR::TestController::openPanelFileURLsMediaIcon const):
3284         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
3285         * WebKitTestRunner/TestInvocation.cpp:
3286         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3287
3288 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
3289
3290         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
3291         https://bugs.webkit.org/show_bug.cgi?id=197171
3292         <rdar://problem/47454979>
3293
3294         Reviewed by Youenn Fablet.
3295
3296         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3297         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
3298         (TestWebKitAPI::TEST):
3299
3300 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3301
3302         [ews-build] Add unit tests for UnApplyPatchIfRequired
3303         https://bugs.webkit.org/show_bug.cgi?id=197197
3304
3305         Reviewed by Lucas Forschler.
3306
3307         * BuildSlaveSupport/ews-build/steps_unittest.py:
3308         (TestUnApplyPatchIfRequired):
3309         (TestUnApplyPatchIfRequired.test_success):
3310         (TestUnApplyPatchIfRequired.test_failure):
3311         (TestUnApplyPatchIfRequired.test_skip):
3312
3313 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3314
3315         [ews-build] Add unit tests for CleanWorkingDirectory
3316         https://bugs.webkit.org/show_bug.cgi?id=197195
3317
3318         Reviewed by Lucas Forschler.
3319
3320         * BuildSlaveSupport/ews-build/steps_unittest.py:
3321         (TestCleanWorkingDirectory):
3322         (TestCleanWorkingDirectory.test_success):
3323         (TestCleanWorkingDirectory.test_failure):
3324
3325 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3326
3327         [ews-build] Use explicit imports instead of wildcard imports
3328         https://bugs.webkit.org/show_bug.cgi?id=197194
3329
3330         Reviewed by Lucas Forschler.
3331
3332         * BuildSlaveSupport/ews-build/factories.py:
3333         * BuildSlaveSupport/ews-build/loadConfig.py:
3334         * BuildSlaveSupport/ews-build/steps_unittest.py:
3335
3336 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3337
3338         [ews-build] Add unit tests for DownloadBuiltProduct
3339         https://bugs.webkit.org/show_bug.cgi?id=197193
3340
3341         Reviewed by Lucas Forschler.
3342
3343         * BuildSlaveSupport/ews-build/steps_unittest.py:
3344         (TestDownloadBuiltProduct):
3345         (TestDownloadBuiltProduct.setUp):
3346         (TestDownloadBuiltProduct.tearDown):
3347         (TestDownloadBuiltProduct.test_success):
3348         (TestDownloadBuiltProduct.test_failure):
3349
3350 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
3351
3352         [ews-app] Exception while loading status-bubble when no build step has started
3353         https://bugs.webkit.org/show_bug.cgi?id=196676
3354
3355         Reviewed by Lucas Forschler.
3356
3357         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3358         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
3359
3360 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
3361
3362         [PlayStation] Support running of JSC tests on remote playstation devices
3363         https://bugs.webkit.org/show_bug.cgi?id=197170
3364
3365         Reviewed by Ross Kirsling.
3366
3367         Script changes
3368
3369         * Scripts/run-javascriptcore-tests:
3370         (runJSCStressTests): Pass arguments for playstation to
3371         run-jsc-stress-tests
3372         * Scripts/run-jsc-stress-tests:
3373         Handle $hostOS=="playstation" for determineArchitecture, turning
3374         off $isFTLPlatform and runProfiler and defaulting test writer.
3375         * Scripts/webkitdirs.pm:
3376         (jscPath): PlayStation WebKit executables have .elf extension
3377         (executableProductDir): PlayStation builds on Windows hosts but
3378         uses bin directory rather than bin64/bin32 for executable output
3379         location.
3380         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
3381
3382 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
3383
3384         [CMake][Win] Use target oriented design for WebKit
3385         https://bugs.webkit.org/show_bug.cgi?id=197173
3386
3387         Reviewed by Alex Christensen.
3388
3389         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
3390         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
3391
3392 2019-04-23  Chris Dumez  <cdumez@apple.com>
3393
3394         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
3395         https://bugs.webkit.org/show_bug.cgi?id=197097
3396         <rdar://problem/50048318>
3397
3398         Reviewed by Alex Christensen.
3399
3400         Add API test coverage.
3401
3402         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3403         (-[PSONScheme webView:startURLSchemeTask:]):
3404
3405 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3406
3407         [ATK] Implement AtkComponentIface scroll_to methods
3408         https://bugs.webkit.org/show_bug.cgi?id=196856
3409
3410         Reviewed by Michael Catanzaro.
3411
3412         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3413         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
3414         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
3415         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
3416
3417 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
3418
3419         [ews-build] Improve summary for UploadBuiltProduct step
3420         https://bugs.webkit.org/show_bug.cgi?id=197182
3421
3422         Reviewed by Lucas Forschler.
3423
3424         * BuildSlaveSupport/ews-build/steps.py:
3425         (UploadBuiltProduct): Added descriptionDone.
3426         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
3427         * BuildSlaveSupport/ews-build/steps_unittest.py:
3428         (TestUploadBuiltProduct.test_success): Updated unit-test.
3429         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
3430
3431 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
3432
3433         [ews-build] Trigger queues only after uploading the archive
3434         https://bugs.webkit.org/show_bug.cgi?id=197180
3435
3436         Reviewed by Lucas Forschler.
3437
3438         * BuildSlaveSupport/ews-build/factories.py:
3439         (Factory.__init__):
3440         (BuildFactory.__init__): Remove trigger step from factories.
3441         (BuildFactory.propertiesToPassToTriggers): Deleted.
3442         * BuildSlaveSupport/ews-build/steps.py:
3443         (ConfigureBuild.__init__): Confiure triggers property.
3444         (Trigger): Step to trigger other queues.
3445         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
3446         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
3447
3448 2019-04-22  Alex Christensen  <achristensen@webkit.org>
3449
3450         Deprecate WKContextCreateWithInjectedBundlePath
3451         https://bugs.webkit.org/show_bug.cgi?id=197169
3452
3453         Reviewed by Youenn Fablet.
3454
3455         * TestWebKitAPI/PlatformUtilities.cpp:
3456         (TestWebKitAPI::Util::createContextWithInjectedBundle):
3457         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
3458
3459 2019-04-22  Alex Christensen  <achristensen@webkit.org>
3460
3461         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
3462         https://bugs.webkit.org/show_bug.cgi?id=197093
3463         <rdar://problem/49708268>
3464
3465         Reviewed by Chris Dumez.
3466
3467         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
3468         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
3469         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
3470         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
3471         and one for loads without credentials, so there are two TCP connections to the same server in this test.
3472
3473         * TestWebKitAPI/TCPServer.cpp:
3474         (TestWebKitAPI::TCPServer::TCPServer):
3475         (TestWebKitAPI::TCPServer::~TCPServer):
3476         (TestWebKitAPI::TCPServer::socketBindListen):
3477         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
3478         * TestWebKitAPI/TCPServer.h:
3479         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3480         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
3481         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
3482         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
3483         (respondWithChallengeThenOK):
3484         (TestWebKitAPI::TEST):
3485         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
3486         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3487         (TEST):
3488
3489 2019-04-22  Chris Dumez  <cdumez@apple.com>
3490
3491         Delayed WebProcessLaunch may break the _relatedWebView SPI
3492         https://bugs.webkit.org/show_bug.cgi?id=197160
3493
3494         Reviewed by Alex Christensen.
3495
3496         Add API test coverage.
3497
3498         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3499
3500 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
3501
3502         Use curl to download packages for webkitpy autoinstaller
3503         https://bugs.webkit.org/show_bug.cgi?id=197164
3504
3505         Reviewed by Darin Adler.
3506
3507         * Scripts/webkitpy/common/system/autoinstall.py:
3508         (AutoInstaller._download): Use curl(1) to download packages necessary for
3509         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
3510         errors which are not present when using curl(1).
3511
3512 2019-04-22  Chris Dumez  <cdumez@apple.com>
3513
3514         Unreviewed, rolling out r244502.
3515
3516         Caused crashes on the bots
3517
3518         Reverted changeset:
3519
3520         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
3521         https://bugs.webkit.org/show_bug.cgi?id=197160
3522         https://trac.webkit.org/changeset/244502
3523
3524 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
3525
3526         Unreviewed, rolling out r244437.
3527
3528         Still breaks internal tests.
3529
3530         Reverted changeset:
3531
3532         "InjectedBundle parameters often need initialization function
3533         called before unarchiving"
3534         https://bugs.webkit.org/show_bug.cgi?id=189709
3535         https://trac.webkit.org/changeset/244437
3536
3537 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
3538
3539         [ews-build] Use singular verb in failure description in case of single api test failure
3540         https://bugs.webkit.org/show_bug.cgi?id=197013
3541
3542         Reviewed by Lucas Forschler.
3543
3544         * BuildSlaveSupport/ews-build/steps.py:
3545         (AnalyzeAPITestsResults.analyzeResults):
3546
3547 2019-04-22  Chris Dumez  <cdumez@apple.com>
3548
3549         Delayed WebProcessLaunch may break the _relatedWebView SPI
3550         https://bugs.webkit.org/show_bug.cgi?id=197160
3551
3552         Reviewed by Alex Christensen.
3553
3554         Add API test coverage.
3555
3556         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3557
3558 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3559
3560         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
3561         https://bugs.webkit.org/show_bug.cgi?id=194630
3562
3563         Reviewed by Michael Catanzaro.
3564
3565         Return early from getAttributeSet() is passed in accessible is nullptr.
3566
3567         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3568
3569 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
3570
3571         Defer EditorState updates until the next layer tree flush in a few additional circumstances
3572         https://bugs.webkit.org/show_bug.cgi?id=197145
3573         <rdar://problem/50078170>
3574
3575         Reviewed by Darin Adler.
3576
3577         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
3578         focus, or showing the font manager.
3579
3580         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3581         (TestWebKitAPI::TEST):
3582         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
3583         (TEST):
3584         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
3585         (TestWebKitAPI::TEST):
3586
3587 2019-04-21  Brian Burg  <bburg@apple.com>
3588
3589         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
3590         https://bugs.webkit.org/show_bug.cgi?id=197125
3591         <rdar://problem/50061468>
3592
3593         Reviewed by Darin Adler.
3594
3595         Sometimes I want to run wptserve independently of tests. Make it easier to script that
3596         using this class rather than making our own ./wpt serve invocation.
3597
3598         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
3599         (WebDriverW3CWebServer):
3600         (WebDriverW3CWebServer.document_root): Expose this to clients.
3601         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
3602
3603         (WebDriverW3CWebServer.__enter__):
3604         (WebDriverW3CWebServer.__exit__):
3605         Make it possible to use the web server with a 'with' statement.
3606
3607 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
3608
3609         [CMake][Win] Use target oriented design for WebKitLegacy
3610         https://bugs.webkit.org/show_bug.cgi?id=197112
3611
3612         Reviewed by Konstantin Tokarev.
3613
3614         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
3615
3616         * DumpRenderTree/CMakeLists.txt:
3617         * DumpRenderTree/PlatformWin.cmake:
3618         * DumpRenderTree/win/EventSender.cpp:
3619
3620 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
3621
3622         Update text for old EWS submit button
3623         https://bugs.webkit.org/show_bug.cgi?id=197140
3624
3625         Reviewed by Alexey Proskuryakov.
3626
3627         * QueueStatusServer/templates/statusbubble.html:
3628
3629 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
3630
3631         [ews-app] New EWS should poll bugzilla more frequently
3632         https://bugs.webkit.org/show_bug.cgi?id=197138
3633
3634         Reviewed by Alexey Proskuryakov.
3635
3636         * BuildSlaveSupport/ews-app/ews/fetcher.py:
3637         (FetchLoop.__init__):
3638
3639 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
3640
3641         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
3642         https://bugs.webkit.org/show_bug.cgi?id=197139
3643
3644         Reviewed by Alexey Proskuryakov.
3645
3646         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3647         * QueueStatusServer/templates/statusbubble.html:
3648
3649 2019-04-20  Chris Dumez  <cdumez@apple.com>
3650
3651         Unreviewed, fix iOS build with recent SDKs.
3652
3653         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3654
3655 2019-04-19  Keith Miller  <keith_miller@apple.com>
3656
3657         Add script to merge run_benchmark jsons
3658         https://bugs.webkit.org/show_bug.cgi?id=197107
3659
3660         Reviewed by Michael Saboff.
3661
3662         The script basically recursively decends through all json objects until it gets
3663         to an array or JSON primitive and concats or takes the first value, respectively.
3664
3665         This patch also adds +x bits to the compare-results script so it
3666         can be run directly from the command line. I had to add a new line so that svn
3667         will accept the change... yay svn!
3668
3669         * Scripts/compare-results:
3670         * Scripts/merge-result-jsons: Added.
3671         (readJSONFile):
3672         (deepAppend):
3673         (mergeJSONs):
3674         (main):
3675
3676 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
3677
3678         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
3679         https://bugs.webkit.org/show_bug.cgi?id=197079
3680
3681         Reviewed by Darin Adler.
3682
3683         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
3684
3685         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3686         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
3687
3688 2019-04-18  Commit Queue  <commit-queue@webkit.org>
3689
3690         Unreviewed, rolling out r244434.
3691         https://bugs.webkit.org/show_bug.cgi?id=197089
3692
3693         caused 1 API test failure (Requested by zalan on #webkit).
3694
3695         Reverted changeset:
3696
3697         "Regression (r244291): Broken API Test
3698         AutoLayoutRenderingProgressRelativeOrdering"
3699         https://bugs.webkit.org/show_bug.cgi?id=196948
3700         https://trac.webkit.org/changeset/244434
3701
3702 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3703
3704         Add new compatibility mode API on WKNavigation
3705         https://bugs.webkit.org/show_bug.cgi?id=197069
3706         <rdar://problem/50025800>
3707
3708         Reviewed by Tim Horton.
3709
3710         Add a block property for -didCommitNavigation to TestNavigationDelegate.
3711
3712         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3713         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3714         (-[TestNavigationDelegate webView:didCommitNavigation:]):
3715
3716 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
3717
3718         [CMake] Make WebCore headers copies
3719         https://bugs.webkit.org/show_bug.cgi?id=182512
3720         <rdar://problem/37510435>
3721
3722         Reviewed by Alex Christensen.
3723
3724         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
3725         ports.
3726
3727         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
3728         of WebCore headers using "*.h" were modified to <WebCore/*.h>
3729
3730         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3731         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
3732         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
3733         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
3734         * TestWebKitAPI/CMakeLists.txt:
3735         * TestWebKitAPI/PlatformWin.cmake:
3736         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
3737         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
3738         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3739
3740 2019-04-18  Jer Noble  <jer.noble@apple.com>
3741
3742         Add support for parsing FairPlayStreaming PSSH boxes.
3743         https://bugs.webkit.org/show_bug.cgi?id=197064
3744
3745         Reviewed by Eric Carlson.
3746
3747         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
3748         (TestWebKitAPI::TEST):
3749
3750 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
3751
3752         InjectedBundle parameters often need initialization function called before unarchiving
3753         https://bugs.webkit.org/show_bug.cgi?id=189709
3754         <rdar://problem/44573653>
3755
3756         Reviewed by Ryosuke Niwa.
3757
3758         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
3759         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
3760
3761 2019-04-18  Zalan Bujtas  <zalan@apple.com>
3762
3763         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
3764         https://bugs.webkit.org/show_bug.cgi?id=196948
3765         <rdar://problem/49927131>
3766
3767         Reviewed by Tim Horton.
3768
3769         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
3770         (TEST): 
3771         The expected order of incoming events is
3772         1. didInvalidateIntrinsicContentSize
3773         2. didFirstLayout
3774         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
3775         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
3776         (and remember, all we care about is ordering).
3777
3778 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
3779
3780         Unreviewed, rolling out r244299.
3781
3782         Breaks internal tests.
3783
3784         Reverted changeset:
3785
3786         "InjectedBundle parameters often need initialization function
3787         called before unarchiving"
3788         https://bugs.webkit.org/show_bug.cgi?id=189709
3789         https://trac.webkit.org/changeset/244299
3790
3791 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
3792
3793         [WTF] StringBuilder should set correct m_is8Bit flag when merging
3794         https://bugs.webkit.org/show_bug.cgi?id=197053
3795
3796         Reviewed by Saam Barati.
3797
3798         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3799         (TestWebKitAPI::TEST):
3800
3801 2019-04-17  Tim Horton  <timothy_horton@apple.com>
3802
3803         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
3804         https://bugs.webkit.org/show_bug.cgi?id=197028
3805         <rdar://problem/49985290>
3806
3807         Reviewed by Wenson Hsieh.
3808
3809         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
3810         (TEST):
3811         Liberal application of waitForNextPresentationUpdate works around a race
3812         where if the page rapidly changes its viewport arguments (or an API client
3813         rapidly changes its viewport arguments), we'd get stuck thinking that the
3814         user had intentionally zoomed the page, and stop resetting the initial scale.
3815         This deserves a separate bug, but no need to keep the test failing while
3816         we think about it.
3817
3818 2019-04-17  Tim Horton  <timothy_horton@apple.com>
3819
3820         REGRESSION (r241988): Switching tabs is slow
3821         https://bugs.webkit.org/show_bug.cgi?id=197037
3822         <rdar://problem/49951473>
3823
3824         Reviewed by Simon Fraser.
3825
3826         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3827         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
3828         (TEST):
3829         * TestWebKitAPI/cocoa/TestWKWebView.h:
3830         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3831         (-[TestWKWebView addToTestWindow]):
3832         Add a test that hangs without this fix.
3833
3834 2019-04-17  Truitt Savell  <tsavell@apple.com>
3835
3836         Unreviewed, rolling out r244400.
3837
3838         Caused testing to exit early with assertionon Debug WK2
3839
3840         Reverted changeset:
3841
3842         "UI↔Web deadlock when printing with a JavaScript alert
3843         visible"
3844         https://bugs.webkit.org/show_bug.cgi?id=196839
3845         https://trac.webkit.org/changeset/244400
3846
3847 2019-04-17  Brady Eidson  <beidson@apple.com>
3848
3849         Link clicks in PDFs shouldn't send referrer headers.
3850         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
3851
3852         Reviewed by Tim Horton.
3853
3854         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3855         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
3856         (putPDFBytesCallback):
3857         (emptyReleaseInfoCallback):
3858         (createPDFWithLinkToURL):
3859         (TEST):
3860
3861 2019-04-17  Tim Horton  <timothy_horton@apple.com>
3862
3863         UI↔Web deadlock when printing with a JavaScript alert visible
3864         https://bugs.webkit.org/show_bug.cgi?id=196839
3865         <rdar://problem/49157642>
3866
3867         Reviewed by Andy Estes.
3868
3869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3870         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
3871         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3872         (TEST):
3873
3874 2019-04-17  Alex Christensen  <achristensen@webkit.org>
3875
3876         WKRetainPtr's adoption constructor should be private
3877         https://bugs.webkit.org/show_bug.cgi?id=197019
3878
3879         Reviewed by Tim Horton.
3880
3881         * DumpRenderTree/mac/DumpRenderTree.mm:
3882         (dumpFramesAsText):
3883         * TestWebKitAPI/InjectedBundleController.cpp:
3884         (TestWebKitAPI::InjectedBundleController::initialize):
3885         * TestWebKitAPI/PlatformUtilities.cpp:
3886         (TestWebKitAPI::Util::createContextWithInjectedBundle):
3887         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
3888         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
3889         (TestWebKitAPI::Util::toWK):
3890         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
3891         (TestWebKitAPI::TEST):
3892         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
3893         (TestWebKitAPI::TEST):
3894         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
3895         (TestWebKitAPI::TEST):
3896         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
3897         (TestWebKitAPI::TEST):
3898         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
3899         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
3900         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
3901         (TestWebKitAPI::TEST):
3902         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
3903         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
3904         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
3905         (TestWebKitAPI::TEST):
3906         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
3907         (TestWebKitAPI::TEST):
3908         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
3909         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
3910         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
3911         (TestWebKitAPI::TEST):
3912         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
3913         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
3914         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
3915         (TestWebKitAPI::TEST):
3916         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
3917         (TestWebKitAPI::TEST):
3918         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
3919         (TestWebKitAPI::TEST):
3920         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
3921         (TestWebKitAPI::TEST):
3922         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
3923         (TestWebKitAPI::TEST):
3924         * TestWebKitAPI/Tests/WebKit/Find.cpp:
3925         (TestWebKitAPI::TEST):
3926         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
3927         (TestWebKitAPI::TEST):
3928         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
3929         (TestWebKitAPI::TEST):
3930         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
3931         (TestWebKitAPI::TEST):
3932         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
3933         (TestWebKitAPI::TEST):
3934         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
3935         (TestWebKitAPI::TEST):
3936         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
3937         (TestWebKitAPI::TEST):
3938         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3939         (TestWebKitAPI::TEST):
3940         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
3941         (TestWebKitAPI::TEST):
3942         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
3943         (TestWebKitAPI::TEST):
3944         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
3945         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
3946         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
3947         (TestWebKitAPI::TEST):
3948         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
3949         (TestWebKitAPI::TEST):
3950         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
3951         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
3952         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
3953         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
3954         (TestWebKitAPI::TEST):
3955         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
3956         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
3957         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
3958         (TestWebKitAPI::TEST):
3959         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
3960         (TestWebKitAPI::TEST):
3961         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
3962         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
3963         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3964         (TestWebKitAPI::TEST):
3965         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
3966         (TestWebKitAPI::loadAlternateHTMLString):
3967         (TestWebKitAPI::TEST):
3968         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
3969         (TestWebKitAPI::TEST):
3970         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
3971         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
3972         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
3973         (TestWebKitAPI::buildAndPerformTest):
3974         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
3975         (TestWebKitAPI::TEST):
3976         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
3977         (TestWebKitAPI::TEST):
3978         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
3979         (TestWebKitAPI::TEST):
3980         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
3981         (TestWebKitAPI::TEST):
3982         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
3983         (TestWebKitAPI::TEST):
3984         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
3985         (TestWebKitAPI::TEST):
3986         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
3987         (TestWebKitAPI::TEST):
3988         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3989         (TestWebKitAPI::TEST):
3990         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
3991         (TestWebKitAPI::TEST):
3992         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
3993         (TestWebKitAPI::TEST):
3994         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
3995         (TestWebKitAPI::TEST):
3996         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
3997         (TestWebKitAPI::TEST):
3998         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
3999         (TestWebKitAPI::TEST):
4000         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
4001         (TestWebKitAPI::TEST):
4002         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
4003         (TestWebKitAPI::TEST):
4004         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
4005         (TestWebKitAPI::TEST):
4006         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
4007         (TestWebKitAPI::TEST):
4008         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
4009         (TestWebKitAPI::TEST):
4010         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
4011         (TestWebKitAPI::TEST):
4012         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
4013         (TestWebKitAPI::TEST):
4014         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
4015         (TestWebKitAPI::TEST):
4016         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
4017         (TestWebKitAPI::TEST):
4018         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
4019         (TestWebKitAPI::TEST):
4020         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
4021         (TestWebKitAPI::TEST):
4022         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
4023         (TestWebKitAPI::TEST):
4024         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
4025         (TestWebKitAPI::TEST):
4026         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
4027         (TestWebKitAPI::TEST):
4028         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
4029         (TestWebKitAPI::TEST):
4030         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
4031         (TestWebKitAPI::TEST):
4032         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
4033         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
4034         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
4035         (TestWebKitAPI::TEST):
4036         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
4037         (TestWebKitAPI::TEST):
4038         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
4039         (TestWebKitAPI::TEST):
4040         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
4041         (TestWebKitAPI::TEST):
4042         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
4043         (TestWebKitAPI::TEST):
4044         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
4045         (TestWebKitAPI::TEST):
4046         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
4047         (TestWebKitAPI::TEST):
4048         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
4049         (TestWebKitAPI::TEST):
4050         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
4051         (TestWebKitAPI::TEST):
4052         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
4053         (TestWebKitAPI::TEST):
4054         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
4055         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
4056         (TEST):
4057         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
4058         (TEST):
4059         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4060         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
4061         (TEST):
4062         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
4063         (TestWebKitAPI::TEST):
4064         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
4065         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
4066         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
4067         (WTR::getMenuItemTitleCallback):
4068         (WTR::createMouseMessageBody):
4069         (WTR::EventSendingController::mouseDown):
4070         (WTR::EventSendingController::mouseUp):
4071         (WTR::EventSendingController::mouseMoveTo):
4072         (WTR::EventSendingController::mouseForceClick):
4073         (WTR::EventSendingController::startAndCancelMouseForceClick):
4074         (WTR::EventSendingController::mouseForceDown):
4075         (WTR::EventSendingController::mouseForceUp):
4076         (WTR::EventSendingController::mouseForceChanged):
4077         (WTR::EventSendingController::leapForward):
4078         (WTR::EventSendingController::scheduleAsynchronousClick):
4079         (WTR::createKeyDownMessageBody):
4080         (WTR::EventSendingController::keyDown):
4081         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
4082         (WTR::EventSendingController::mouseScrollBy):
4083         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
4084         (WTR::EventSendingController::continuousMouseScrollBy):
4085         (WTR::EventSendingController::addTouchPoint):
4086         (WTR::EventSendingController::updateTouchPoint):
4087         (WTR::EventSendingController::setTouchModifier):
4088         (WTR::EventSendingController::setTouchPointRadius):
4089         (WTR::EventSendingController::touchStart):
4090         (WTR::EventSendingController::touchMove):
4091         (WTR::EventSendingController::touchEnd):
4092         (WTR::EventSendingController::touchCancel):
4093         (WTR::EventSendingController::clearTouchPoints):
4094         (WTR::EventSendingController::releaseTouchPoint):
4095         (WTR::EventSendingController::cancelTouchPoint):
4096         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4097         (WTR::InjectedBundle::didCreatePage):
4098         (WTR::InjectedBundle::didReceiveMessage):
4099         (WTR::InjectedBundle::didReceiveMessageToPage):
4100         (WTR::InjectedBundle::booleanForKey):
4101         (WTR::InjectedBundle::done):
4102         (WTR::InjectedBundle::dumpToStdErr):
4103         (WTR::InjectedBundle::outputText):
4104         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
4105         (WTR::InjectedBundle::postAddChromeInputField):
4106         (WTR::InjectedBundle::postRemoveChromeInputField):
4107         (WTR::InjectedBundle::postFocusWebView):
4108         (WTR::InjectedBundle::postSetBackingScaleFactor):
4109         (WTR::InjectedBundle::postSetWindowIsKey):
4110         (WTR::InjectedBundle::postSetViewSize):
4111         (WTR::InjectedBundle::postSimulateWebNotificationClick):
4112         (WTR::InjectedBundle::postSetAddsVisitedLinks):
4113         (WTR::InjectedBundle::setGeolocationPermission):
4114         (WTR::InjectedBundle::setMockGeolocationPosition):
4115         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
4116         (WTR::InjectedBundle::isGeolocationProviderActive const):
4117         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
4118         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
4119         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
4120         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
4121         (WTR::InjectedBundle::setCustomPolicyDelegate):
4122         (WTR::InjectedBundle::setHidden):
4123         (WTR::InjectedBundle::setCacheModel):
4124         (WTR::InjectedBundle::shouldProcessWorkQueue const):
4125         (WTR::InjectedBundle::processWorkQueue):
4126         (WTR::InjectedBundle::queueBackNavigation):
4127         (WTR::InjectedBundle::queueForwardNavigation):
4128         (WTR::InjectedBundle::queueLoad):
4129         (WTR::InjectedBundle::queueLoadHTMLString):
4130         (WTR::InjectedBundle::queueReload):
4131         (WTR::InjectedBundle::queueLoadingScript):
4132         (WTR::InjectedBundle::queueNonLoadingScript):
4133         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4134         (WTR::frameToStr):
4135         (WTR::InjectedBundlePage::InjectedBundlePage):
4136         (WTR::dumpFrameDescriptionSuitableForTestResult):
4137         (WTR::dumpFrameScrollPosition):
4138         (WTR::dumpDescendantFrameScrollPositions):
4139         (WTR::dumpFrameText):
4140         (WTR::dumpDescendantFramesText):
4141         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4142         (WTR::TestRunner::shouldDumpPixels const):
4143         (WTR::TestRunner::setDumpPixels):
4144         (WTR::TestRunner::whatToDump const):
4145         (WTR::TestRunner::setWhatToDump):
4146         (WTR::TestRunner::setWaitUntilDone):
4147         (WTR::TestRunner::shouldWaitUntilDone const):
4148         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
4149         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
4150         (WTR::TestRunner::clearAllDatabases):
4151         (WTR::TestRunner::setIDBPerOriginQuota):
4152         (WTR::TestRunner::originsWithApplicationCache):
4153         (WTR::TestRunner::setCanOpenWindows):
4154         (WTR::TestRunner::setXSSAuditorEnabled):
4155         (WTR::TestRunner::setMediaDevicesEnabled):
4156         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
4157         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
4158         (WTR::TestRunner::setCustomUserAgent):
4159         (WTR::TestRunner::setWebAPIStatisticsEnabled):
4160         (WTR::TestRunner::setModernMediaControlsEnabled):
4161         (WTR::TestRunner::setWebGL2Enabled):
4162         (WTR::TestRunner::setWritableStreamAPIEnabled):
4163         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
4164         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
4165         (WTR::TestRunner::setAllowsAnySSLCertificate):
4166         (WTR::TestRunner::setPluginsEnabled):
4167         (WTR::TestRunner::setValueForUser):
4168         (WTR::TestRunner::setAudioResult):
4169         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
4170         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
4171         (WTR::TestRunner::setAlwaysAcceptCookies):
4172         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
4173         (WTR::TestRunner::isDoingMediaCapture const):
4174         (WTR::TestRunner::queueLoad):
4175         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
4176         (WTR::TestRunner::setHandlesAuthenticationChallenges):
4177         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
4178         (WTR::TestRunner::setShouldLogDownloadCallbacks):
4179         (WTR::TestRunner::setAuthenticationUsername):
4180         (WTR::TestRunner::setAuthenticationPassword):
4181         (WTR::TestRunner::secureEventInputIsEnabled const):
4182         (WTR::TestRunner::setBlockAllPlugins):
4183         (WTR::TestRunner::setPluginSupportedMode):
4184         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
4185         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
4186         (WTR::TestRunner::setNavigationGesturesEnabled):
4187         (WTR::TestRunner::setIgnoresViewportScaleLimits):
4188         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
4189         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
4190         (WTR::TestRunner::terminateNetworkProcess):
4191         (WTR::TestRunner::terminateServiceWorkerProcess):
4192         (WTR::TestRunner::runUIScript):
4193         (WTR::TestRunner::setStatisticsDebugMode):
4194         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
4195         (WTR::TestRunner::setStatisticsLastSeen):
4196         (WTR::TestRunner::setStatisticsPrevalentResource):
4197         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
4198         (WTR::TestRunner::dumpResourceLoadStatistics):
4199         (WTR::TestRunner::isStatisticsPrevalentResource):
4200         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
4201         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
4202         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
4203         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
4204         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
4205         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
4206         (WTR::TestRunner::setStatisticsGrandfathered):
4207         (WTR::TestRunner::isStatisticsGrandfathered):
4208         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
4209         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
4210         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
4211         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
4212         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
4213         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
4214         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
4215         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
4216         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
4217         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
4218         (WTR::TestRunner::statisticsUpdateCookieBlocking):
4219         (WTR::TestRunner::statisticsSubmitTelemetry):
4220         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
4221         (WTR::TestRunner::setStatisticsIsRunningTest):
4222         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
4223         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
4224         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
4225         (WTR::TestRunner::setStatisticsGrandfatheringTime):
4226         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
4227         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
4228         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
4229         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
4230         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
4231         (WTR::TestRunner::statisticsDeleteCookiesForHost):
4232         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
4233         (WTR::TestRunner::statisticsResetToConsistentState):
4234         (WTR::TestRunner::setStorageAccessAPIEnabled):
4235         (WTR::TestRunner::getAllStorageAccessEntries):
4236         (WTR::TestRunner::addMockMediaDevice):
4237         (WTR::TestRunner::clearMockMediaDevices):
4238         (WTR::TestRunner::removeMockMediaDevice):
4239         (WTR::TestRunner::resetMockMediaDevices):
4240         (WTR::TestRunner::connectMockGamepad):
4241         (WTR::TestRunner::disconnectMockGamepad):
4242         (WTR::TestRunner::setMockGamepadDetails):
4243         (WTR::TestRunner::setMockGamepadAxisValue):
4244         (WTR::TestRunner::setMockGamepadButtonValue):
4245         (WTR::TestRunner::removeAllSessionCredentials):
4246         (WTR::TestRunner::clearDOMCache):
4247         (WTR::TestRunner::clearDOMCaches):
4248         (WTR::TestRunner::hasDOMCache):
4249         (WTR::TestRunner::domCacheSize):
4250         (WTR::TestRunner::setAllowStorageQuotaIncrease):
4251         (WTR::TestRunner::getApplicationManifestThen):
4252         (WTR::TestRunner::injectUserScript):
4253         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
4254         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
4255         (WTR::TestRunner::addTestKeyToKeychain):
4256         (WTR::TestRunner::cleanUpKeychain):
4257         (WTR::TestRunner::keyExistsInKeychain):
4258         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
4259         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
4260         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
4261         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
4262         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
4263         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
4264         * WebKitTestRunner/TestController.cpp:
4265         (WTR::TestController::initialize):
4266         (WTR::parseStringTestHeaderValueAsRelativePath):
4267         (WTR::updateTestOptionsFromTestHeader):
4268         (WTR::TestController::runTest):
4269         (WTR::TestController::didReceiveLiveDocumentsList):
4270         (WTR::TestController::didReceiveMessageFromInjectedBundle):
4271         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
4272         (WTR::TestController::didFinishNavigation):
4273         (WTR::TestController::didReceiveAuthenticationChallenge):
4274         * WebKitTestRunner/TestInvocation.cpp:
4275         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4276         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4277         (WTR::TestInvocation::uiScriptDidComplete):
4278         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
4279         * WebKitTestRunner/WebNotificationProvider.cpp:
4280         (WTR::WebNotificationProvider::closeWebNotification):
4281         * WebKitTestRunner/WorkQueueManager.cpp:
4282         (WTR::ScriptItem::ScriptItem):
4283         (WTR::WorkQueueManager::queueLoad):
4284         (WTR::WorkQueueManager::queueLoadHTMLString):
4285
4286 2019-04-17  Alex Christensen  <achristensen@webkit.org>
4287
4288         Add a comment to make my test from r244139 less mysterious.
4289         https://bugs.webkit.org/show_bug.cgi?id=196744
4290
4291         As suggested by Darin Adler.
4292
4293         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
4294         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
4295
4296 2019-04-17  Chris Dumez  <cdumez@apple.com>
4297
4298         Remember device orientation permission for the duration of the browsing session
4299         https://bugs.webkit.org/show_bug.cgi?id=196992
4300         <rdar://problem/49946067>
4301
4302         Reviewed by Alex Christensen.
4303
4304         Add API test coverage.
4305
4306         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
4307         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
4308         (TEST):
4309
4310 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
4311
4312         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
4313         https://bugs.webkit.org/show_bug.cgi?id=196675
4314
4315         Reviewed by Lucas Forschler.
4316
4317         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
4318         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
4319
4320 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
4321
4322         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
4323         https://bugs.webkit.org/show_bug.cgi?id=196919
4324         <rdar://problem/41630459>
4325
4326         Reviewed by Tim Horton.
4327
4328         Add iOS support for several new testing hooks. See below for more detail.
4329
4330         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4331         (WTR::UIScriptController::isDismissingMenu const):
4332
4333         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
4334         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
4335         by UIKit when dismissing the callout bar (i.e. UIMenuController).
4336
4337         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4338<