7cd0256d86e25baf8d5e278446121cb2a0ffee68
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-20  Youenn Fablet  <youenn@apple.com>
2
3         [WebRTC][Mac] Activate libwebrtc
4         https://bugs.webkit.org/show_bug.cgi?id=167293
5         <rdar://problem/30401864>
6
7         Reviewed by Alex Christensen.
8
9         Fixing paths to allow loading libwebrtc.dylib successfully.
10
11         * Scripts/build-webkit:
12         * Scripts/webkitdirs.pm:
13         (setupMacWebKitEnvironment):
14         (setupIOSWebKitEnvironment):
15
16 2017-02-20  Ryan Haddad  <ryanhaddad@apple.com>
17
18         Unreviewed, rolling out r212685.
19
20         This change broke the 32-bit Sierra build.
21
22         Reverted changeset:
23
24         "Resource Load Statistics: Add alternate classification
25         method"
26         https://bugs.webkit.org/show_bug.cgi?id=168347
27         http://trac.webkit.org/changeset/212685
28
29 2017-02-20  John Wilander  <wilander@apple.com>
30
31         Resource Load Statistics: Add alternate classification method
32         https://bugs.webkit.org/show_bug.cgi?id=168347
33         <rdar://problem/30352793>
34
35         Reviewed by Alex Christensen.
36
37         Added three testRunner functions to facilitate layout tests:
38         - setStatisticsSubframeUnderTopFrameOrigin()
39         - setStatisticsSubresourceUnderTopFrameOrigin()
40         - setStatisticsSubresourceUniqueRedirectTo()
41
42         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
43         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
44         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
45         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
46         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
47         * WebKitTestRunner/InjectedBundle/TestRunner.h:
48         * WebKitTestRunner/TestController.cpp:
49         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
50         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
51         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
52         * WebKitTestRunner/TestController.h:
53         * WebKitTestRunner/TestInvocation.cpp:
54         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
55
56 2017-02-20  Anders Carlsson  <andersca@apple.com>
57
58         Use the new drag code path when dragging links
59         https://bugs.webkit.org/show_bug.cgi?id=168612
60
61         Reviewed by Tim Horton.
62
63         If a type is not dynamic, just use the static UTI.
64
65         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm:
66         (-[LocalPasteboard writeObjects:]):
67
68 2017-02-17  Anders Carlsson  <andersca@apple.com>
69
70         Add a new drag code path and use it for dragging plain text
71         https://bugs.webkit.org/show_bug.cgi?id=168534
72
73         Reviewed by Geoffrey Garen.
74
75         Update the testing infrastructure to handle NSDraggingSession.
76
77         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
78         * DumpRenderTree/mac/DumpRenderTreePasteboard.mm: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreePasteboard.m.
79         (-[LocalPasteboard writeObjects:]):
80         Implement this in terms of the legacy pasteboard API.
81
82         * DumpRenderTree/mac/EventSendingController.mm:
83         (drt_WebHTMLView_beginDraggingSessionWithItemsEventSource):
84         (+[EventSendingController initialize]):
85         Swizzle the drag method instead of adding a delegate method (like the old code does).
86
87 2017-02-20  Florian Bruhin  <git@the-compiler.org>
88
89         Handle EINTR during webkitpy server process select()
90         https://bugs.webkit.org/show_bug.cgi?id=168361
91
92         Reviewed by Michael Catanzaro.
93
94         Otherwise, on my machine, resizing the terminal run-webkit-tests is running in
95         makes it die.
96
97         * Scripts/webkitpy/port/server_process.py:
98         (ServerProcess._wait_for_data_and_update_buffers_using_select):
99
100 2017-02-20  Carlos Garcia Campos  <cgarcia@igalia.com>
101
102         Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/default-menu.
103
104         It can happen that the window onload event is dispatched after the load finished is received in the UI
105         process. Move the script to select the text to the body instead of using a window onload handler.
106
107         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
108         (testContextMenuDefaultMenu):
109
110 2017-02-20  Manuel Rego Casasnovas  <rego@igalia.com>
111
112         [css-grid] Remove compilation flag ENABLE_CSS_GRID_LAYOUT
113         https://bugs.webkit.org/show_bug.cgi?id=167693
114
115         Reviewed by Sergio Villar Senin.
116
117         * Scripts/webkitperl/FeatureList.pm:
118         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
119         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
120         (TestWebKitAPI::computeNumberOfTracks):
121         (TestWebKitAPI::TEST):
122         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp:
123         (TestWebKitAPI::TEST):
124
125 2017-02-19  Commit Queue  <commit-queue@webkit.org>
126
127         Unreviewed, rolling out r212466.
128         https://bugs.webkit.org/show_bug.cgi?id=168577
129
130         causes crashes on AArch64 on linux, maybe it's causing crashes
131         on iOS too (Requested by pizlo on #webkit).
132
133         Reverted changeset:
134
135         "The collector thread should only start when the mutator
136         doesn't have heap access"
137         https://bugs.webkit.org/show_bug.cgi?id=167737
138         http://trac.webkit.org/changeset/212466
139
140 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
141
142         Fix failure from r212579.
143
144         Unreviewed build-fix.
145
146         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py:
147         (CheckPatchRelevance._changes_are_relevant): Return true for all groups others than jsc for now.
148
149 2017-02-17  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
150
151         EWS should run JavaScriptCore tests
152         https://bugs.webkit.org/show_bug.cgi?id=162458
153
154         Reviewed by Alexey Proskuryakov.
155
156         * QueueStatusServer/config/queues.py: Add jsc-ews queue.
157         * QueueStatusServer/model/queuestatus.py:
158         (QueueStatus.did_skip): Returns whether patch was skipped, based on status.
159         * QueueStatusServer/handlers/statusbubble.py:
160         (StatusBubble._should_show_bubble_for): Add logic to hide jsc-ews bubble if the patch does not touch jsc.
161         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
162         (MockSCM.__init__): Add _mockChangedFiles variable.
163         (MockSCM.changed_files): Change to use _mockChangedFiles variables.
164         * Scripts/webkitpy/common/config/ews.json: Add config info for JSC EWS.
165         * Scripts/webkitpy/common/config/ports.py: Add support for JSC EWS in Mac Port.
166         (DeprecatedPort._append_build_style_flag): Helper function to append build_style to a command.
167         (DeprecatedPort.build_jsc_command): Added - command to build JSC only (quicker than building all of WebKit).
168         (DeprecatedPort.run_javascriptcore_tests_command): Allow JSC EWS to only run JSC tests.
169         (MacPort.run_webkit_tests_command): Check for JSC.
170         * Scripts/webkitpy/common/config/ports_mock.py:
171         (MockPort.run_javascriptcore_tests_command): Add build_style argument.
172         * Scripts/webkitpy/common/config/ports_unittest.py:
173         (DeprecatedPortTest.test_mac_port): Add unit tests for build-jsc shell command.
174         * Scripts/webkitpy/common/net/abstracttestresults.py: Added.
175         (AbstractTestResults): Abstract superclass of JSCTestResults and JSCTestResults.
176         (AbstractTestResults.test_results): Stub.
177         (AbstractTestResults.failing_tests): Stub.
178         (AbstractTestResults.did_exceed_test_failure_limit): Stub.
179         * Scripts/webkitpy/common/net/jsctestresults.py: Added.
180         (JSCTestResults): Added.
181         (JSCTestResults.intersection): Return a JSCTestResults object with failures common to both input objects.
182         (JSCTestResults.results_from_string): Use json library to parse results.
183         (JSCTestResults.__init__): Initialize members.
184         (JSCTestResults.equals): This enables unit testing.
185         (JSCTestResults.is_subset): Checks if one set of failures is a subset of another.
186         (JSCTestResults.all_passed): Getter.
187         (JSCTestResults.failing_tests): Getter.
188         (JSCTestResults.did_exceed_test_failure_limit): Getter.
189         * Scripts/webkitpy/common/net/jsctestresults_unittest.py: Added.
190         (JSCTestResultsTest): Class to test JSCTestResults.
191         (JSCTestResultsTest.test_results_from_string): Tests parsing.
192         (JSCTestResultsTest.test_intersection_api_tests): Unit test for intersection() class method.
193         (JSCTestResultsTest.test_intersection_stress_tests): Unit test for intersection() class method.
194         (JSCTestResultsTest.test_intersection_general_case): Unit test for intersection() class method.
195         * Scripts/webkitpy/port/base.py:
196         (Port.jsc_results_directory): Returns the directory for the JSC test results JSON file.
197         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
198         (EarlyWarningSystemTask.run): Add check_patch_relevance step.
199         * Scripts/webkitpy/tool/bot/jscews_unittest.py: Added.
200         (MockPatchAnalysisTask): Mocked-out version of PatchAnalysisTask that doesn't run commands.
201         (MockPatchAnalysisTask.__init__): Sets attributes.
202         (MockPatchAnalysisTask._test): Override to not run command.
203         (MockPatchAnalysisTask._build_and_test_without_patch): Override to not run command.
204         (MockPatchAnalysisTask.validate): Assume mocked patch is valid for purposes of testing retry logic.
205         (MockPatchAnalysisTask.test_run_count): Specific to the mocked version, to test retry logic.
206         (MockJSCEarlyWarningSystem): Mocked-out version of AbstarctEarlyWarningSystem so we can provide test results.
207         (MockJSCEarlyWarningSystem.__init__): Sets attributes, also sets group to jsc.
208         (MockJSCEarlyWarningSystem.test_results): Returns test results provided by us, instead of using a JSON reader.
209         (JSCEarlyWarningSystemTest): Class to test retry logic in below situations.
210         (JSCEarlyWarningSystemTest._create_task): Helper function to abstract out common code.
211         (JSCEarlyWarningSystemTest._results_indicate_all_passed): False if input is None or has failures, else True.
212         (JSCEarlyWarningSystemTest.test_success_case): Clean patch on clean tree.
213         (JSCEarlyWarningSystemTest.test_test_failure): Failed patch on clean tree.
214         (JSCEarlyWarningSystemTest.test_fix): Patch that fixes all tree redness.
215         (JSCEarlyWarningSystemTest.test_ineffective_patch): Patch that has same failures as tree.
216         (JSCEarlyWarningSystemTest.test_partially_effective_patch): Patch fixes some failures but adds no new failures.
217         (JSCEarlyWarningSystemTest.test_different_test_failures_in_patch_and_tree): Patch has some failures not in tree.
218         (JSCEarlyWarningSystemTest.test_first_results_could_not_be_read): Patch results not readable.
219         (JSCEarlyWarningSystemTest.test_second_results_could_not_be_read): Patch results not readable on second run.
220         (JSCEarlyWarningSystemTest.test_clean_results_could_not_be_read): Results from clean tree not readable.
221         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass): Patch has one flake and no failures.
222         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_pass_v2): Patch has one flake and no failures.
223         (JSCEarlyWarningSystemTest.test_flaky_results_on_clean_tree_failure): Patch has flakes and failed tests.
224         (JSCEarlyWarningSystemTest.test_flaky_results_on_red_tree_pass): Patch has same failures as tree, plus a flake.
225         * Scripts/webkitpy/tool/bot/jsctestresultsreader.py: Added.
226         (JSCTestResultsReader): Reads results file.
227         (JSCTestResultsReader.__init__): Sets attributes.
228         (JSCTestResultsReader._read_file_contents): Reads file.
229         (JSCTestResultsReader.results): Reads the results file and returns a JSCTestResults object.
230         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
231         (PatchIsNotApplicable): Exception for when patch doesn't have relevant changes.
232         (PatchAnalysisTask._check_patch_relevance): Added.
233         (PatchAnalysisTask._build): Check for JSC.
234         (PatchAnalysisTask._build_without_patch): Check for JSC.
235         (PatchAnalysisTask._test): Check for JSC.
236         (PatchAnalysisTask._build_and_test_without_patch): Check for JSC.
237         (PatchAnalysisTask._retry_jsc_tests): Retry logic for JSC EWS.
238         (PatchAnalysisTask._retry_layout_tests): Retry logic for layout tests EWS.
239         (PatchAnalysisTask._test_patch): Add retry logic for JSC.
240         * Scripts/webkitpy/tool/commands/download.py:
241         (CheckPatchRelevance): Add check-patch-relevance command.
242         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
243         (AbstractEarlyWarningSystem._create_task): Abstract out to enable mocking.
244         (AbstractEarlyWarningSystem.begin_work_queue): Use JSCTestResultsReader not LayoutTestResultsReader in JSC EWS.
245         (AbstractEarlyWarningSystem.review_patch): Handle PatchIsApplicable.
246         (AbstractEarlyWarningSystem.test_results): _layout_test_results_reader -> _test_results_reader.
247         (AbstractEarlyWarningSystem.archive_last_test_results): _layout_test_results_reader -> _test_results_reader.
248         (AbstractEarlyWarningSystem.group): This attribute determines the type of EWS (eg. JSC).
249         (AbstractEarlyWarningSystem.load_ews_classes): Add _group, and make classes of type cls to enable mocking.
250         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
251         (TestEWS): Sample layout test EWS class used for unit testing.
252         (TestJSCEWS): Sample JSC EWS class used for unit testing.
253         (AbstractEarlyWarningSystemTest.test_failing_tests_message.TestEWS): Add _group.
254         (AbstractEarlyWarningSystemTest.test_failing_jsc_tests_message.TestEWS): Added test for jsc failures message.
255         (AbstractEarlyWarningSystemTest): Add _group variable.
256         (EarlyWarningSystemTest._default_expected_logs): Add check-patch-relevance step, inconclusive logs, and group.
257         (EarlyWarningSystemTest._test_ews): Add logs_are_conclusive option to pass through to default_expected_logs().
258         (EarlyWarningSystemTest.test_inconclusive_test_results): Test not removing patch from queue if not conclusive.
259         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults): Added.
260         (MockAbstractEarlyWarningSystemForInconclusiveJSCResults._test_patch): Simulates running tests but not getting a conclusive result.
261         (MockEarlyWarningSystemTaskForInconclusiveJSCResults): Added.
262         (MockEarlyWarningSystemTaskForInconclusiveJSCResults._create_task): Use MockEarlyWarningSystemTask (not EarlyWarningSystemTask).
263         * Scripts/webkitpy/tool/steps/__init__.py: Add CheckPatchRelevance import.
264         * Scripts/webkitpy/tool/steps/build.py:
265         (Build.options): Check for JSC.
266         (Build.build): Check for JSC.
267         (Build.run): Check for JSC.
268         * Scripts/webkitpy/tool/steps/checkpatchrelevance.py: Added.
269         (CheckPatchRelevance): Added.
270         (CheckPatchRelevance._does_contain_change_in_paths): Abstract function to perform regex matching.
271         (CheckPatchRelevance.run): Check if changed files in patch belong in certain folders.
272         * Scripts/webkitpy/tool/steps/options.py:
273         (Options): Add --group command line option.
274         * Scripts/webkitpy/tool/steps/runtests.py:
275         (RunTests.options): Add group.
276         (RunTests.run): Check for JSC.
277         (RunTests._run_webkit_tests): Check for JSC.
278         (RunTests): Add _group attribute.
279         (RunTests._run_javascriptcore_tests): New.
280         * Scripts/webkitpy/tool/steps/steps_unittest.py: Unit tests.
281
282 2017-02-17  Aakash Jain  <aakash_jain@apple.com>
283
284         Fix tools that were broken by Efl removal
285         https://bugs.webkit.org/show_bug.cgi?id=168496
286
287         Reviewed by Alexey Proskuryakov.
288
289         * QueueStatusServer/config/queues.py:
290         * Scripts/webkitpy/common/config/ews.json:
291         * TestResultServer/static-dashboards/builders.jsonp:
292         * TestResultServer/static-dashboards/flakiness_dashboard.js:
293         * TestResultServer/static-dashboards/loader_unittests.js:
294
295 2017-02-16  Lucas Forschler  <lforschler@apple.com>
296
297         https://bugs.webkit.org/show_bug.cgi?id=168442
298         Move the SVN checkout from http -> https.
299         Update unit tests.
300
301         Reviewed by Alexey Proskuryakov.
302
303         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
304         (CheckOutSource.__init__):
305         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
306         (SVNMirrorTest.get_SVNMirrorFromConfig):
307         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
308
309 2017-02-16  Commit Queue  <commit-queue@webkit.org>
310
311         Unreviewed, rolling out r212514.
312         https://bugs.webkit.org/show_bug.cgi?id=168489
313
314         broke test runner (Requested by alexchristensen on #webkit).
315
316         Reverted changeset:
317
318         "Remove EFL-specific files in Tools."
319         http://trac.webkit.org/changeset/212514
320
321 2017-02-16  Alex Christensen  <achristensen@webkit.org>
322
323         Remove EFL-specific files in Tools.
324
325         Rubber-stamped by Anders Carlsson.
326
327         * ImageDiff/efl: Removed.
328         * ImageDiff/efl/ImageDiff.cpp: Removed.
329         * MiniBrowser/efl: Removed.
330         * MiniBrowser/efl/CMakeLists.txt: Removed.
331         * MiniBrowser/efl/main.c: Removed.
332         * Scripts/run-efl-tests: Removed.
333         * Scripts/update-webkitefl-libs: Removed.
334         * Scripts/webkitpy/port/efl.py: Removed.
335         * Scripts/webkitpy/port/efl_unittest.py: Removed.
336         * TestWebKitAPI/Tests/WebKit2/efl: Removed.
337         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Removed.
338         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Removed.
339         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Removed.
340         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Removed.
341         * TestWebKitAPI/efl: Removed.
342         * TestWebKitAPI/efl/InjectedBundleController.cpp: Removed.
343         * TestWebKitAPI/efl/PlatformUtilities.cpp: Removed.
344         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed.
345         * TestWebKitAPI/efl/main.cpp: Removed.
346         * WebKitTestRunner/InjectedBundle/efl: Removed.
347         * WebKitTestRunner/InjectedBundle/efl/ActivateFontsEfl.cpp: Removed.
348         * WebKitTestRunner/InjectedBundle/efl/FontManagement.cpp: Removed.
349         * WebKitTestRunner/InjectedBundle/efl/FontManagement.h: Removed.
350         * WebKitTestRunner/InjectedBundle/efl/InjectedBundleEfl.cpp: Removed.
351         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Removed.
352         * WebKitTestRunner/efl: Removed.
353         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp: Removed.
354         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed.
355         * WebKitTestRunner/efl/TestControllerEfl.cpp: Removed.
356         * WebKitTestRunner/efl/main.cpp: Removed.
357         * efl: Removed.
358         * efl/install-dependencies: Removed.
359         * efl/jhbuild-optional.modules: Removed.
360         * efl/jhbuild.modules: Removed.
361         * efl/jhbuildrc: Removed.
362         * efl/patches: Removed.
363         * efl/patches/evas-fix-build-with-giflib5.patch: Removed.
364         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Removed.
365         * efl/patches/gst-libav.patch: Removed.
366         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Removed.
367         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Removed.
368         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Removed.
369         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Removed.
370
371 2017-02-16  Myles C. Maxfield  <mmaxfield@apple.com>
372
373         font-weight in @font-face can cause a font to be downloaded even when it's not used
374         https://bugs.webkit.org/show_bug.cgi?id=168114
375         <rdar://problem/30301317>
376
377         Reviewed by Darin Adler.
378
379         LastResort needs to be usable in tests.
380
381         * DumpRenderTree/mac/DumpRenderTree.mm:
382         (allowedFontFamilySet):
383         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
384         (WTR::allowedFontFamilySet):
385         * WebKitTestRunner/mac/TestControllerMac.mm:
386         (WTR::allowedFontFamilySet):
387
388 2017-02-16  Alex Christensen  <achristensen@webkit.org>
389
390         Remove old URL parser
391         https://bugs.webkit.org/show_bug.cgi?id=168483
392
393         Reviewed by Tim Horton.
394
395         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
396         (TestWebKitAPI::checkURL):
397         (TestWebKitAPI::checkRelativeURL):
398         (TestWebKitAPI::checkURLDifferences):
399         (TestWebKitAPI::checkRelativeURLDifferences):
400
401 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
402
403         [WK2] Add additional test infrastructure and unit tests for data interaction
404         https://bugs.webkit.org/show_bug.cgi?id=168439
405         <rdar://problem/30557942>
406
407         Reviewed by Tim Horton.
408
409         Adds test support for additional data interaction scenarios that we currently cannot test, and also adds 7 new
410         test cases to DataInteractionTests. Most of the changes here refactor and augment DataInteractionSimulator to
411         support data interaction from  See per-method descriptions below for more details.
412
413         * Configurations/TestWebKitAPI.xcconfig:
414
415         Add MobileCoreServices to the list of additional frameworks to link against on iOS.
416
417         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
418
419         Add a new build phase that copies additional resources from WebKitAdditions/Resources/TestWebKitAPI and dumps
420         them into TestWebKitAPI.resources/ in the build directory, if the WebKitAdditions folder exists.
421
422         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
423         (-[TestWKWebView editorContainsImageElement]):
424         (-[TestWKWebView editorValue]):
425
426         New helper methods for querying information from the "editor" element in a test page.
427
428         (TestWebKitAPI::TEST):
429         (TestWebKitAPI::runTestsExpectingToObserveEvents): Deleted.
430
431         Moves logic for capturing events during a simulated data interaction run from the test file to
432         DataInteractionSimulator. See -[DataInteractionSimulator observedEventNames].
433
434         * TestWebKitAPI/cocoa/TestWKWebView.h:
435         * TestWebKitAPI/cocoa/TestWKWebView.mm:
436         (-[TestMessageHandler removeMessage:]):
437         (-[TestWKWebView clearMessageHandlers:]):
438
439         Add the ability to clear message handlers from the TestWKWebView.
440
441         * TestWebKitAPI/ios/DataInteractionSimulator.h:
442         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
443         (dataInteractionEventNames):
444         (-[DataInteractionSimulator initWithWebView:]):
445         (-[DataInteractionSimulator _resetSimulatedState]):
446
447         Moves logic to clear test harness state from any previous runs into a helper. Called at the beginning when
448         simulating data interaction.
449
450         (-[DataInteractionSimulator observedEventNames]):
451
452         Returns a list of the names of events relevant to data interaction that were observed over the course of the
453         most recent run.
454
455         (-[DataInteractionSimulator runFrom:to:]):
456
457         Changes -run to -runFrom:to:, which takes window-relative start and end locations. This allows the test harness
458         to run the same data interaction for multiple simulated gestures.
459
460         (-[DataInteractionSimulator _advanceProgress]):
461         (-[DataInteractionSimulator _finishDataInteraction]):
462         (-[DataInteractionSimulator externalItemProvider]):
463         (-[DataInteractionSimulator setExternalItemProvider:]):
464
465         Adds the -externalItemProvider property to DataInteractionSimulator. Setting this skips the gesture recognition
466         phase of a test run.
467
468         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
469         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
470         (-[DataInteractionSimulator webViewDidSendDataInteractionStartRequest:]):
471         (-[DataInteractionSimulator webView:didReceiveDataInteractionStartResponse:]):
472
473         While a request to start data interaction is in flight, put the remainder of the test on hold until the web
474         process returns. Then continue the test by scheduling a progress advance call. This addresses a race condition
475         wherein the the web process might take longer than usual to process the request to start data interaction, and
476         in the meantime, DataInteractionSimulator would end up completing the rest of the test before a response from
477         the web process is received, which then causes no simulated delegate methods to be fired.
478
479         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]): Deleted.
480         (-[DataInteractionSimulator run]): Deleted.
481
482 2017-02-16  Wenson Hsieh  <wenson_hsieh@apple.com>
483
484         Remove unused test pages in TestWebKitAPI
485         https://bugs.webkit.org/show_bug.cgi?id=168462
486
487         Reviewed by Anders Carlsson.
488
489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
490         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Removed.
491         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Removed.
492         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Removed.
493         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Removed.
494         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Removed.
495
496 2017-02-16  Alex Christensen  <achristensen@webkit.org>
497
498         Special URLs without a host are invalid
499         https://bugs.webkit.org/show_bug.cgi?id=168461
500
501         Reviewed by Tim Horton.
502
503         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
504         (TestWebKitAPI::TEST_F):
505
506 2017-02-10  Filip Pizlo  <fpizlo@apple.com>
507
508         The collector thread should only start when the mutator doesn't have heap access
509         https://bugs.webkit.org/show_bug.cgi?id=167737
510
511         Reviewed by Keith Miller.
512         
513         Make more tests collect continuously.
514
515         * Scripts/run-jsc-stress-tests:
516
517 2017-02-16  Tim Horton  <timothy_horton@apple.com>
518
519         WKWebView inside a UICollectionView flashes when items are inserted above it
520         https://bugs.webkit.org/show_bug.cgi?id=168376
521         <rdar://problem/29322051>
522
523         Reviewed by Simon Fraser.
524
525         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
526         (-[TestRunnerWKWebView _setStableStateOverride:]):
527         Update the one external caller of this internal method...
528
529         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
530         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
531         * DumpRenderTree/mac/UIScriptControllerMac.mm:
532         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
533         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
534         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
535         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
536         * TestRunnerShared/UIScriptContext/UIScriptController.h:
537         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
538         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
539         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
540         (WTR::UIScriptController::doAfterVisibleContentRectUpdate):
541         Expose doAfterVisibleContentRectUpdate to DRT and WKTR. It is called
542         back after we dispatch a visible content rect update from the UI process
543         to the Web Content process, so any messages sent from the block will arrive
544         after the visible content rect update.
545
546 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
547
548         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS.
549         https://bugs.webkit.org/show_bug.cgi?id=168321
550
551         This bots should be added to the trunk build scheduler.
552         Unreviewed fix after r212429.
553
554         * BuildSlaveSupport/build.webkit.org-config/config.json:
555
556 2017-02-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
557
558         [GTK] Add two new buildbots that build-only test on Debian stable and Ubuntu LTS
559         https://bugs.webkit.org/show_bug.cgi?id=168321
560
561         Reviewed by Michael Catanzaro.
562
563         The additionalArgument --default-cmake-features is used both to
564         skip the JHBuild (InstallGtkDependencies) build step and to build
565         with the default features from the CMake config.
566
567         * BuildSlaveSupport/build.webkit.org-config/config.json:
568         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
569         (Factory.__init__):
570         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
571
572 2017-02-15  Lucas Forschler  <lforschler@apple.com>
573
574         https://bugs.webkit.org/show_bug.cgi?id=168386
575         Remove EFL from build.webkit.org
576
577         Reviewed by Alex Christensen
578
579         * BuildSlaveSupport/build.webkit.org-config/config.json:
580         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
581         (DeleteStaleBuildFiles.start):
582         (appendCustomBuildFlags):
583         (RunWebKitTests.start):
584         (RunBuiltinsTests):
585         (Factory.__init__):
586         (TestFactory.__init__):
587         (loadBuilderConfig):
588         (InstallEflDependencies): Deleted.
589         (RunEflAPITests): Deleted.
590         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
591         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
592         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
593         (BubbleQueueServer):
594         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
595         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
596         (Analyzer.prototype._triggeringQueue):
597         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
598         (WebKitBuildbot):
599         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
600         (table.queue-grid tr.platform.linux-efl img.logo): Deleted.
601         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
602         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
603         (_should_file_trigger_build):
604
605 2017-02-15  Alex Christensen  <achristensen@webkit.org>
606
607         Unreviewed, rolling out r212169.
608
609         Broke iOS WebInspector
610
611         Reverted changeset:
612
613         "WebInspector: refactor RemoteInspector to move cocoa specific
614         code to their own files"
615         https://bugs.webkit.org/show_bug.cgi?id=166681
616         http://trac.webkit.org/changeset/212169
617
618 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
619
620         webkitpy: Fix DarwinPort._get_crash_log()
621         https://bugs.webkit.org/show_bug.cgi?id=168372
622         <rdar://problem/30535156>
623
624         Reviewed by Daniel Bates.
625
626         Callers of _get_crash_log expect a pair to be returned and do not check it's return value.  
627         DarwinPort should return the expected return value for _get_crash_log.
628
629         * Scripts/webkitpy/port/darwin.py:
630         (DarwinPort._get_crash_log): Call parent class's implementation of _get_crash_log.
631
632 2017-02-15  Chris Dumez  <cdumez@apple.com>
633
634         [iOS] Form Validation Bubble should be sensitive to Dynamic Type
635         https://bugs.webkit.org/show_bug.cgi?id=168291
636         <rdar://problem/30508593>
637
638         Reviewed by Tim Horton.
639
640         Drop overridePreference() implementation in iOS's UIScriptController
641         as it was only used for the minimum font size setting and this setting
642         is not exposed on iOS.
643
644         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
645         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
646         (WTR::UIScriptController::overridePreference):
647         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
648
649 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
650
651         webkitpy: Memoize app_identifier_from_bundle for efficiency, call parent class for _get_crash_log
652         https://bugs.webkit.org/show_bug.cgi?id=168329
653         <rdar://problem/30518832>
654
655         Reviewed by Daniel Bates.
656
657         When testing on device, app_identifier_from_bundle is repeatedly called but the return value will
658         never change given the same input arguments.  Memoize function for efficiency.
659
660         * Scripts/webkitpy/port/darwin.py: Add memoized import.
661         (DarwinPort):
662         (DarwinPort.app_identifier_from_bundle): Memoize to avoid extra executions of PlistBuddy.
663         
664
665 2017-02-15  Jonathan Bedard  <jbedard@apple.com>
666
667         webkitpy: Remove unused import from darwin.py
668         https://bugs.webkit.org/show_bug.cgi?id=168371
669
670         Reviewed by Alex Christensen.
671
672         * Scripts/webkitpy/port/darwin.py: Remove unused 'time' module.
673
674 2017-02-15  Carlos Garcia Campos  <cgarcia@igalia.com>
675
676         [SOUP] Credentials stored by libsoup are used even StoredCredentials policy is DoNotAllowStoredCredentials
677         https://bugs.webkit.org/show_bug.cgi?id=168364
678
679         Reviewed by Michael Catanzaro.
680
681         This can happen if a previous load with allowed to use stored credentials authenticated successfully, saving the
682         credentials in libsoup. It's actually a libsoup bug, but since it's causing layout test failures and we have
683         patches for them, let's patch out jhbuild until we have a new libsoup version to depend on.
684
685         Fixes: http/tests/security/credentials-from-different-domains.html
686                http/tests/xmlhttprequest/cross-origin-no-authorization.html
687
688         * gtk/jhbuild.modules:
689         * gtk/patches/libsoup-auth-Fix-async-authentication-when-flag-SOUP_MESSAGE.patch: Added.
690         * gtk/patches/libsoup-auth-do-not-use-cached-credentials-in-lookup-method-.patch: Added.
691
692 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
693
694         [GTK] Update cookie manager API to properly work with ephemeral sessions
695         https://bugs.webkit.org/show_bug.cgi?id=168230
696
697         Reviewed by Michael Catanzaro.
698
699         Update unit tests and add new cases for the new API.
700
701         * MiniBrowser/gtk/main.c:
702         (gotWebsiteDataCallback):
703         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
704         (testCookieManagerEphemeral):
705         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
706         (testWebContextEphemeral):
707         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
708         (testWebViewEphemeral):
709         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
710         (serverCallback):
711         (testWebsiteDataEphemeral):
712         (testWebsiteDataCookies):
713         (beforeAll):
714
715 2017-02-14  Wenson Hsieh  <wenson_hsieh@apple.com>
716
717         [WK2] Support data interaction on links
718         https://bugs.webkit.org/show_bug.cgi?id=168331
719         <rdar://problem/30200837>
720
721         Reviewed by Tim Horton.
722
723         Adds 2 unit tests checking that data interaction from a link (with or without a background image) into an
724         editable area results in the link URL being inserted.
725
726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
727         * TestWebKitAPI/Tests/WebKit2Cocoa/background-image-link-and-input.html: Added.
728         * TestWebKitAPI/Tests/WebKit2Cocoa/link-and-input.html: Added.
729         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
730         (TestWebKitAPI::TEST):
731
732 2017-02-14  Jason Rinn  <jrinn@apple.com>
733
734         Add a test for new WebKit Cocoa API, _getContentsAsString.
735         https://bugs.webkit.org/show_bug.cgi?id=168147
736         <rdar://problem/30502539>
737
738         Reviewed by Tim Horton.
739
740         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
741         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewGetContents.mm: Added.
742         (TEST):
743
744 2017-02-14  Matt Rajca  <mrajca@apple.com>
745
746         Website policies: iframes should respect the autoplay policy of the top-level document
747         https://bugs.webkit.org/show_bug.cgi?id=168333
748
749         Reviewed by Alex Christensen.
750
751         * TestWebKitAPI/Tests/WebKit2/autoplay-check-frame.html: Added.
752         * TestWebKitAPI/Tests/WebKit2/autoplay-check-in-iframe.html: Added.
753         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
754         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
755         (TEST):
756
757 2017-02-14  Chris Dumez  <cdumez@apple.com>
758
759         HTML Form Validation bubble should take minimum font size setting into consideration
760         https://bugs.webkit.org/show_bug.cgi?id=168271
761         <rdar://problem/29869869>
762
763         Reviewed by Simon Fraser.
764
765         Extend UIScriptController's contentsOfUserInterfaceItem() to also return the
766         font size of the validation bubble.
767
768         Add an overridePreference() method to UIScriptController. This is currently
769         used to override the value of the minimumFontSize setting. testRunner's
770         overridePreference() is not usable on WK2 because it does not update the
771         value of the preference on the UIProcess side.
772
773         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
774         (WTR::UIScriptController::overridePreference):
775         * DumpRenderTree/mac/UIScriptControllerMac.mm:
776         (WTR::UIScriptController::overridePreference):
777         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
778         * TestRunnerShared/UIScriptContext/UIScriptController.h:
779         * WebKitTestRunner/TestController.cpp:
780         (WTR::TestController::resetPreferencesToConsistentValues):
781         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
782         (WTR::UIScriptController::overridePreference):
783         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
784         (WTR::UIScriptController::contentsOfUserInterfaceItem):
785         (WTR::UIScriptController::overridePreference):
786
787 2017-02-14  Florian Bruhin  <git@the-compiler.org>
788
789         Use a set instead of a list for tests when parsing expectations
790         https://bugs.webkit.org/show_bug.cgi?id=168304
791
792         In _collect_matching_tests, a lot of membership tests are done on a giant list
793         of strings. By making it a set instead, we can make those much faster, and
794         there's no reason for it to be a list.
795
796         With ~45k tests and some 1000 expectations, this reduces the parse time from 34s
797         to 3s on my machine.
798
799         Reviewed by Ryosuke Niwa.
800
801         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
802         (TestExpectationParser.__init__):
803         (TestExpectationParser._collect_matching_tests):
804
805 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
806
807         Unreviewed build-fix after r212297.
808
809         * Scripts/webkitpy/port/simulator_process.py:
810         (SimulatorProcess.stop): Should return value of the ServerProcess's stop.
811
812 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
813
814         [CMake] build-webkit should allow building with the default cmake configuration
815         https://bugs.webkit.org/show_bug.cgi?id=168323
816
817         Reviewed by Michael Catanzaro.
818
819         Add a --default-cmake-features switch that makes the script pass
820         no value for any of the features defined by build-webkit, that
821         way the default values from the port cmake config will be used.
822
823         * Scripts/build-webkit:
824         (cMakeArgsFromFeatures):
825
826 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
827
828         Unreviewed build-fix after r212297.
829
830         * Scripts/webkitpy/port/simulator_process.py:
831         (SimulatorProcess.stop): Handle case where there is no process to kill.
832
833 2017-02-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
834
835         [CMake] build-webkit should print the cmake command executed
836         https://bugs.webkit.org/show_bug.cgi?id=168318
837
838         Reviewed by Michael Catanzaro.
839
840         Run the cmake commands to configure or start the build through
841         a wrapper that prints the command before executing it.
842
843         * Scripts/webkitdirs.pm:
844         (systemVerbose):
845         (generateBuildSystemFromCMakeProject):
846         (buildCMakeGeneratedProject):
847         (cleanCMakeGeneratedProject):
848
849 2017-02-14  Jonathan Bedard  <jbedard@apple.com>
850
851         run-webkit-tests for iOS Simulator always complains that stopping WebKitTestRunnerApp.app times out
852         https://bugs.webkit.org/show_bug.cgi?id=168150
853
854         Reviewed by Alexey Proskuryakov.
855
856         * Scripts/webkitpy/port/simulator_process.py:
857         (SimulatorProcess.stop): Close app before calling ServerProcess's stop.
858         (SimulatorProcess._kill): Move closing of app into stop().
859         * Scripts/webkitpy/xcode/simulator.py:
860         (Device.launch_app):
861         (Device.terminate_app): Deleted.
862
863 2017-02-14  Carlos Garcia Campos  <cgarcia@igalia.com>
864
865         REGRESSION(r212192): [GTK] Broke downloads API tests
866         https://bugs.webkit.org/show_bug.cgi?id=168193
867
868         Unreviewed. Update test expectations after r212192.
869
870         The suggested filename now includes a file extensions if the MIME type is known.
871
872         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
873         (testDownloadRemoteFile):
874         (testDownloadMIMEType):
875
876 2017-02-14  Commit Queue  <commit-queue@webkit.org>
877
878         Unreviewed, rolling out r212237.
879         https://bugs.webkit.org/show_bug.cgi?id=168298
880
881         This was a wrong fix (Requested by rniwa on #webkit).
882
883         Reverted changeset:
884
885         "Nwtr unexpectedly passes mismatch ref test if the hashes
886         doesn't match but no diff"
887         https://bugs.webkit.org/show_bug.cgi?id=168221
888         http://trac.webkit.org/changeset/212237
889
890 2017-02-13  Alex Christensen  <achristensen@webkit.org>
891
892         URLs with an invalid IPv4 address should be invalid
893         https://bugs.webkit.org/show_bug.cgi?id=168260
894
895         Reviewed by Tim Horton.
896
897         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
898         (TestWebKitAPI::TEST_F):
899         Update tests to reflect new correct behavior.
900
901 2017-02-13  Don Olmstead  <don.olmstead@am.sony.com>
902
903         [WinCairo] Add Build Slave
904         https://bugs.webkit.org/show_bug.cgi?id=168263
905
906         Reviewed by Lucas Forschler.
907
908         * BuildSlaveSupport/build.webkit.org-config/config.json:
909
910 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
911
912         Fix the build after r212254
913
914         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
915         (-[DataInteractionSimulator _currentLocation]):
916
917 2017-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
918
919         [WK2] Add test infrastructure and unit tests for data interaction
920         https://bugs.webkit.org/show_bug.cgi?id=168159
921         <rdar://problem/30477634>
922
923         Reviewed by Tim Horton.
924
925         Uses the testing delegate introduced in WebKit2 to override the gesture recognizer used to initiate data
926         interaction. Instead of being driven by UIKit, the DataInteractionSimulator drives this overridden gesture
927         recognizer by making the WKContentView call its dataInteractionGestureRecognized method. To simulate an actual
928         gesture being performed, we fire the gesture recognizer (or call the data interaction delegate methods, if the
929         gesture has already been recognized) at regular intervals over the course of the test.
930
931         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
932         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocus-contenteditable.html: Added.
933         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-contenteditable.html: Added.
934         * TestWebKitAPI/Tests/WebKit2Cocoa/image-and-textarea.html: Added.
935
936         New test pages for data interaction.
937
938         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm: Added.
939         (TestWebKitAPI::runTestsExpectingToObserveEvents):
940         (TestWebKitAPI::TEST):
941         * TestWebKitAPI/cocoa/TestWKWebView.mm:
942         (-[TestWKWebView stringByEvaluatingJavaScript:]):
943         * TestWebKitAPI/ios/DataInteractionSimulator.h: Added.
944         * TestWebKitAPI/ios/DataInteractionSimulator.mm: Added.
945         (-[MockLongPressGestureRecognizer initWithWindow:]):
946         (-[MockLongPressGestureRecognizer locationInView:]):
947         (-[MockLongPressGestureRecognizer state]):
948         (-[MockLongPressGestureRecognizer numberOfTouches]):
949         (-[DataInteractionSimulator initWithWebView:startLocation:endLocation:]):
950         (-[DataInteractionSimulator dealloc]):
951         (-[DataInteractionSimulator run]):
952
953         Performs a data interaction gesture from the start location to the end location with linear interpolation. For
954         now, the timestep and progress per tick are 30ms and 3.33%, respectively, which means that tests should complete
955         in a little under 1 second, though this can be easily changed to be configurable in the future if needed.
956
957         (-[DataInteractionSimulator _advanceProgress]):
958
959         Fired periodically to drive the data interaction gesture. Schedules a call of itself until the test is
960         completed, and calls _finishDataInteraction when progress is at 1.
961
962         (-[DataInteractionSimulator _finishDataInteraction]):
963         (-[DataInteractionSimulator _currentLocation]):
964         (-[DataInteractionSimulator _scheduleAdvanceProgress]):
965         (-[DataInteractionSimulator _recognizeGestureAtLocation:withState:]):
966         (-[DataInteractionSimulator dataInteractionGestureRecognizer]):
967         (-[DataInteractionSimulator webViewDidPerformDataInteractionControllerOperation:]):
968         (-[DataInteractionSimulator webView:beginDataInteractionWithSourceIndex:gestureRecognizer:]):
969
970 2017-02-13  Alex Christensen  <achristensen@webkit.org>
971
972         Percent should be allowed in non-special URL hosts
973         https://bugs.webkit.org/show_bug.cgi?id=168255
974
975         Reviewed by Tim Horton.
976
977         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
978         (TestWebKitAPI::TEST_F):
979
980 2017-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
981
982         Nwtr unexpectedly passes mismatch ref test if the hashes doesn't match but no diff
983         https://bugs.webkit.org/show_bug.cgi?id=168221
984
985         Reviewed by Ryosuke Niwa.
986
987         There is a logic error in comparing mismatch ref test images. In
988         mismatch ref tests, it should be failed if two images has no diff.
989         But, if the hashes are different, nwtr unexpectedly pass the
990         mismatch ref test.
991
992         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
993         (SingleTestRunner._compare_output_with_reference): Fail the
994         mismatch ref test if hashes of two images are equal. Invoke
995         ImageDiff if the hashes don't match.
996
997 2017-02-13  Myles C. Maxfield  <mmaxfield@apple.com>
998
999         Update custom line breaking iterators to the latest version of Unicode
1000         https://bugs.webkit.org/show_bug.cgi?id=168182
1001
1002         Reviewed by Zalan Bujtas.
1003
1004         Treat the system's ICU as the source of truth to compare breaking positions against.
1005
1006         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1007         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm: Added.
1008         (generateJavaScriptForTest):
1009         (breakingLocationsFromICU):
1010         (testAFewStrings):
1011         (TEST):
1012         * TestWebKitAPI/Tests/WebKit2Cocoa/AllAhem.svg: Renamed from LayoutTests/css3/line-break/resources/AllAhem.svg.
1013         * TestWebKitAPI/Tests/WebKit2Cocoa/LineBreaking.html: Added.
1014
1015 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1016
1017         [GTK] Several failing WebViewEditor API tests
1018         https://bugs.webkit.org/show_bug.cgi?id=161608
1019
1020         Reviewed by Carlos Garcia Campos.
1021
1022         Selection.collapse() requires arguments; passing no arguments means the JS that selects the
1023         text range here never gets evaluated. Perhaps there was a DOM API change? Changing it to use
1024         Selection.removeAllRanges(), which seems like a better function anyway, fixes all the tests
1025         except the first one, which is still broken due to unrelated bug #151654.
1026
1027         * Scripts/run-gtk-tests:
1028         (TestRunner):
1029         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1030
1031 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1032
1033         Unreviewed, skip flaky WebKitPrintOperation/custom-widget test
1034
1035         * Scripts/run-gtk-tests:
1036         (TestRunner):
1037
1038 2017-02-12  Michael Catanzaro  <mcatanzaro@igalia.com>
1039
1040         Unreviewed, skip flaky form-controls-associated-signal test
1041
1042         * Scripts/run-gtk-tests:
1043         (TestRunner):
1044
1045 2017-02-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1046
1047         [GTK] Handle caps lock indicator in event modifiers
1048         https://bugs.webkit.org/show_bug.cgi?id=168186
1049
1050         Reviewed by Michael Catanzaro.
1051
1052         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1053         (WTR::webkitModifiersToGDKModifiers): Handle kWKEventModifiersCapsLockKey.
1054
1055 2017-02-11  Simon Fraser  <simon.fraser@apple.com>
1056
1057         MiniBrowser WK1 fails to update URL for within-page navigations
1058         https://bugs.webkit.org/show_bug.cgi?id=168173
1059
1060         Reviewed by Tim Horton.
1061         
1062         Implement -webView:didChangeLocationWithinPageForFrame: so that clicking on named
1063         anchors updates the URL field.
1064
1065         * MiniBrowser/mac/WK1BrowserWindowController.m:
1066         (-[WK1BrowserWindowController webView:didChangeLocationWithinPageForFrame:]):
1067
1068 2017-02-10  John Wilander  <wilander@apple.com>
1069
1070         Updates to Resource Load Statistics: Get the right website data store and introduce timeout for user interaction
1071         https://bugs.webkit.org/show_bug.cgi?id=167474
1072         <rdar://problem/24681808>
1073         <rdar://problem/24703286>
1074         <rdar://problem/30290270>
1075
1076         This patch adds test infrastructure to allow testing 
1077         of the various rules in place for data records removal.
1078
1079         Reviewed by Andy Estes.
1080
1081         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1082         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1083         (WTR::InjectedBundle::didReceiveMessageToPage):
1084             Callback mechanism to tell pages that a website data store
1085             scan has happened.
1086         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1087         (WTR::TestRunner::setStatisticsPrevalentResource):
1088         (WTR::TestRunner::isStatisticsPrevalentResource):
1089         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1090         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1091         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1092         (WTR::TestRunner::installStatisticsDidModifyDataRecordsCallback):
1093         (WTR::TestRunner::statisticsDidModifyDataRecordsCallback):
1094         (WTR::TestRunner::statisticsFireDataModificationHandler):
1095         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1096         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1097         (WTR::TestRunner::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1098         (WTR::TestRunner::statisticsResetToConsistentState):
1099         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1100         * WebKitTestRunner/TestController.cpp:
1101         (WTR::TestController::setStatisticsPrevalentResource):
1102         (WTR::TestController::isStatisticsPrevalentResource):
1103         (WTR::TestController::setStatisticsHasHadUserInteraction):
1104         (WTR::TestController::isStatisticsHasHadUserInteraction):
1105         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1106         (WTR::TestController::statisticsFireDataModificationHandler):
1107         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1108         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1109         (WTR::TestController::setStatisticsMinimumTimeBetweeenDataRecordsRemoval):
1110         (WTR::TestController::statisticsResetToConsistentState):
1111         * WebKitTestRunner/TestController.h:
1112             These are all configuration and test functions.
1113         * WebKitTestRunner/TestInvocation.cpp:
1114         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1115
1116 2017-02-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1117
1118         REGRESSION(r182916) run-perf-tests never timeouts
1119         https://bugs.webkit.org/show_bug.cgi?id=167626
1120
1121         Reviewed by Ryosuke Niwa.
1122
1123         The --time-out-ms value (defaults to 600 seconds) of run-perf-tests
1124         was beeing ignored because the driver was created with no_timeout=True
1125         unconditionally.
1126         This adds a new parameter --no-timeout (disabled by default), that
1127         allows to use the driver with the expected timeout values.
1128         It also passes --no-timeout to DRT/WTR to ensure that timeouts
1129         are always controlled by the Python Driver.
1130
1131         * Scripts/webkitpy/performance_tests/perftest.py:
1132         (PerfTest._create_driver): Only disable timeout if --no-timeout is passed.
1133         (PerfTest.run): Disabling timeout should be done when the Driver is created.
1134         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1135         (PerfTestsRunner.__init__): Ensure --no-timeout is passed to DRT/WTR
1136         (PerfTestsRunner._parse_args): Add a --no-timeout parameter.
1137         (_run_tests_set): Pass the no-timeout parameter.
1138         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1139         (MainTest.test_drt_notimeout): Test --no-timeout is passed to DRT/WTR
1140         (MainTest.test_default_args): Test default values for additional_drt_flag and no_timeout.
1141         (MainTest.test_parse_args): Test that the argument no-timeout.
1142
1143 2017-02-10  Daniel Bates  <dabates@apple.com>
1144
1145         Detach frame from document when entering page cache
1146         https://bugs.webkit.org/show_bug.cgi?id=166774
1147         <rdar://problem/29904368>
1148
1149         Reviewed by Chris Dumez.
1150
1151         * DumpRenderTree/mac/DumpRenderTree.mm:
1152         (resetWebPreferencesToConsistentValues):
1153         * DumpRenderTree/win/DumpRenderTree.cpp:
1154         (resetWebPreferencesToConsistentValues):
1155         * WebKitTestRunner/TestController.cpp:
1156         (WTR::TestController::resetPreferencesToConsistentValues):
1157
1158 2017-02-10  Tim Horton  <timothy_horton@apple.com>
1159
1160         Infinite UI process hang under ensurePositionInformationIsUpToDate
1161         https://bugs.webkit.org/show_bug.cgi?id=168154
1162         <rdar://problem/30428673>
1163
1164         Reviewed by Simon Fraser.
1165
1166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1167         * TestWebKitAPI/Tests/WebKit2Cocoa/InteractionDeadlockAfterCrash.mm: Added.
1168         (recursiveFindHighlightLongPressRecognizer):
1169         (TEST):
1170         Add a somewhat nasty test that does an async interaction information update, but
1171         kills the Web process before it arrives, and then does a sync interaction
1172         information update, which will wait for the oustanding async interaction
1173         information update if we still think it's coming. Before the patch, this
1174         test times out with the UI process stuck under ensurePositionInformationIsUpToDate.
1175
1176 2017-02-10  Simon Fraser  <simon.fraser@apple.com>
1177
1178         Make sure the "inwindow" flag propagates to TiledBackings for masks and reflections
1179         https://bugs.webkit.org/show_bug.cgi?id=168127
1180         rdar://problem/30467120
1181
1182         Reviewed by Tim Horton.
1183
1184         Reparent the web view before we try to fetch it via:
1185             [[[window contentView] subviews] objectAtIndex:0];
1186         which would throw an exception if the test unparented it.
1187
1188         * DumpRenderTree/mac/DumpRenderTree.mm:
1189         (resetWebViewToConsistentStateBeforeTesting):
1190         (runTest):
1191
1192 2017-02-10  Joseph Pecoraro  <pecoraro@apple.com>
1193
1194         [Resource Timing] Enable Resource Timing by default in Tests
1195         https://bugs.webkit.org/show_bug.cgi?id=168145
1196
1197         Reviewed by Ryosuke Niwa.
1198
1199         * DumpRenderTree/mac/DumpRenderTree.mm:
1200         (resetWebPreferencesToConsistentValues):
1201         * DumpRenderTree/win/DumpRenderTree.cpp:
1202         (resetWebPreferencesToConsistentValues):
1203         * WebKitTestRunner/TestController.cpp:
1204         (WTR::TestController::resetPreferencesToConsistentValues):
1205
1206 2017-02-10  Jonathan Bedard  <jbedard@apple.com>
1207
1208         Removing LayoutTestRelay
1209         https://bugs.webkit.org/show_bug.cgi?id=165927
1210
1211         Reviewed by Daniel Bates.
1212         Part 2
1213
1214         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
1215         simulators through simctl (iOS 10 and later), use this functionality instead.
1216
1217         * BuildSlaveSupport/built-product-archive:
1218         (archiveBuiltProduct): Remove archiving of LayoutTestRelay as it is no longer being built.
1219         Added a FIXME that we will need to implement similar archiving machinery once we build
1220         ImageDiff for Mac when building WebKit for iOS. Currently ImageDiff is built with the iOS SDK.
1221         * BuildSlaveSupport/kill-old-processes:
1222         (main): Remove LayoutTestRelay from list of processes.
1223         * LayoutTestRelay: Removed LayoutTestRelay.
1224         * Makefile:
1225         * Scripts/build-layouttestrelay: Removed.
1226         * Scripts/build-webkit: Removed LayoutTestRelay references.
1227
1228 2017-02-10  Jiewen Tan  <jiewen_tan@apple.com>
1229
1230         [WebCrypto] Add WebCryptoAPI to watchlist
1231         https://bugs.webkit.org/show_bug.cgi?id=168138
1232
1233         Reviewed by Youenn Fablet.
1234
1235         * Scripts/webkitpy/common/config/watchlist:
1236
1237 2017-02-10  Brady Eidson  <beidson@apple.com>
1238
1239         Replace all WebKit Library Version checks in WK2 with SDK version checks.
1240         https://bugs.webkit.org/show_bug.cgi?id=168124
1241
1242         Reviewed by Geoffrey Garen.
1243
1244         For each of our tools that use WebKit2, opt them in to the new linkedOnOrAfter(Everything) setting.
1245         
1246         * MiniBrowser/mac/main.m:
1247         (main):
1248         * MobileMiniBrowser/MobileMiniBrowser/main.m:
1249         (main):
1250         * TestWebKitAPI/ios/mainIOS.mm:
1251         (main):
1252         * TestWebKitAPI/mac/mainMac.mm:
1253         (main):
1254         * WebKitTestRunner/ios/mainIOS.mm:
1255         (main):
1256         * WebKitTestRunner/mac/main.mm:
1257         (setDefaultsToConsistentValuesForTesting):
1258
1259 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1260
1261         Fix El Capitan build.
1262
1263         * Scripts/build-webkit:
1264         Don't build libwebrtc anywhere for now.
1265
1266 2017-02-10  Andy Estes  <aestes@apple.com>
1267
1268         Move two MiniBrowserBundle settings out of the .pbxproj
1269         https://bugs.webkit.org/show_bug.cgi?id=168106
1270
1271         Reviewed by Tim Horton.
1272
1273         INFOPLIST_FILE was specified in MiniBrowserBundle.xcconfig but overridden to "" in
1274         the project file. This removes the project file override.
1275
1276         WRAPPER_EXTENSION was moved from the project file to MiniBrowserBundle.xcconfig.
1277
1278         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig:
1279         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1280
1281 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1282
1283         Fix 32-and-64-bit build on El Capitan.
1284
1285         * Scripts/build-webkit:
1286         Somebody's building with something like this:
1287         build-webkit ARCHS="i386 x86_64"
1288         We want this to also not build libwebrtc for now.
1289
1290 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1291
1292         Fix 32-bit build on El Capitan.
1293
1294         * Scripts/build-webkit:
1295         The bot uses ARCHS=i386 instead of --32-bit.
1296         This is a hack, but it should fix the bot until I can do a better fix in the morning.
1297
1298 2017-02-10  Alex Christensen  <achristensen@webkit.org>
1299
1300         Fix 32-bit build on El Capitan.
1301
1302         * Scripts/build-webkit:
1303         Don't build i386 libwebrtc.
1304
1305 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1306
1307         Unreviewed, rolling out r212040.
1308
1309         Broke build.  I'm not surprised
1310
1311         Reverted changeset:
1312
1313         "[WebRTC][Mac] Activate libwebrtc"
1314         https://bugs.webkit.org/show_bug.cgi?id=167293
1315         http://trac.webkit.org/changeset/212040
1316
1317 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1318
1319         Build libwebrtc on bots without using it yet
1320         https://bugs.webkit.org/show_bug.cgi?id=168062
1321
1322         Reviewed by Brent Fulgham.
1323
1324         * Scripts/build-webkit:
1325
1326 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1327
1328         Don't build libwebrtc.
1329
1330         * Scripts/build-webkit:
1331         Not ready yet.  It broke El Capitan and iOS.
1332
1333 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1334
1335         Build libwebrtc on bots without using it yet
1336         https://bugs.webkit.org/show_bug.cgi?id=168062
1337
1338         Reviewed by Brent Fulgham.
1339
1340         * Scripts/build-webkit:
1341
1342 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1343
1344         Rename isAppleMacWebKit to isAppleCocoaWebKit
1345         https://bugs.webkit.org/show_bug.cgi?id=168075
1346
1347         Reviewed by Geoffrey Garen.
1348
1349         It returns true for Mac and iOS.  "isAppleMacWebKit" is confusing and wrong.
1350
1351         * Scripts/build-api-tests:
1352         * Scripts/build-dumprendertree:
1353         * Scripts/build-jsc:
1354         (buildMyProject):
1355         * Scripts/build-layouttestrelay:
1356         * Scripts/build-webkit:
1357         * Scripts/build-webkittestrunner:
1358         * Scripts/run-api-tests:
1359         (isSupportedPlatform):
1360         (runTest):
1361         (listAllTests):
1362         (prepareEnvironmentForRunningTestTool):
1363         * Scripts/run-content-extension-tester:
1364         * Scripts/run-javascriptcore-tests:
1365         * Scripts/run-minibrowser:
1366         * Scripts/show-pretty-diff:
1367         * Scripts/webkitdirs.pm:
1368         (determineBaseProductDir):
1369         (determineArchitecture):
1370         (determinePassedArchitecture):
1371         (safariPath):
1372         (builtDylibPathForName):
1373         (checkFrameworks):
1374         (isAppleWebKit):
1375         (isAppleCocoaWebKit):
1376         (determineNmPath):
1377         (launcherName):
1378         (wrapperPrefixIfNeeded):
1379         (isCMakeBuild):
1380         (mobileSafariBundle):
1381         (debugSafari):
1382         (runSafari):
1383         (runMiniBrowser):
1384         (debugMiniBrowser):
1385         (runWebKitTestRunner):
1386         (debugWebKitTestRunner):
1387         (isAppleMacWebKit): Deleted.
1388         * Scripts/webkitperl/FeatureList.pm:
1389
1390 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1391
1392         Revert r211991
1393         https://bugs.webkit.org/show_bug.cgi?id=168062
1394
1395         * Scripts/build-webkit:
1396         Not quite ready yet.
1397
1398 2017-02-09  Alex Christensen  <achristensen@webkit.org>
1399
1400         Build libwebrtc on bots without using it yet
1401         https://bugs.webkit.org/show_bug.cgi?id=168062
1402
1403         Reviewed by Brent Fulgham.
1404
1405         * Scripts/build-webkit:
1406         Build libwebrtc on Mac when we build ANGLE.
1407
1408 2017-02-09  Youenn Fablet  <youenn@apple.com>
1409
1410         Improve W3C importer command line options
1411         https://bugs.webkit.org/show_bug.cgi?id=167448
1412
1413         Reviewed by Ryosuke Niwa.
1414
1415         Making the list of test paths to import the main arguments of the script.
1416         Allow passing the source directory to import as a -s option.
1417         Adding a warning when given test paths are skipped by default in ImportExpectations.
1418
1419         Making link conversion off by default when importing from a specific directory since this script is mostly used with web-platform-tests.
1420         Link conversion rules do not change when imported tests are downloaded by the script.
1421
1422         * Scripts/webkitpy/w3c/test_importer.py:
1423         (main):
1424         (parse_args):
1425         (TestImporter.__init__):
1426         (TestImporter.do_import):
1427         (TestImporter):
1428         (TestImporter.check_imported_expectations):
1429
1430 2017-02-08  Chris Dumez  <cdumez@apple.com>
1431
1432         Update web-platform-tests resources
1433         https://bugs.webkit.org/show_bug.cgi?id=168026
1434
1435         Reviewed by Youenn Fablet.
1436
1437         Stop copying testharness.js from resources/ to web-platform-tests/resources.
1438
1439         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1440         (WebPlatformTestServer._copy_webkit_test_files):
1441
1442 2017-02-08  Andy Estes  <aestes@apple.com>
1443
1444         Custom protocols should not continue loading after a network process crash
1445         https://bugs.webkit.org/show_bug.cgi?id=168028
1446         <rdar://problem/27607520>
1447
1448         Reviewed by Brady Eidson.
1449
1450         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
1451         (processGroup):
1452         (-[CloseWhileStartingProtocol startLoading]):
1453         (-[CloseWhileStartingProtocol stopLoading]):
1454         (TestWebKitAPI::runTest):
1455         (TestWebKitAPI::TEST):
1456
1457 2017-02-08  Dan Bernstein  <mitz@apple.com>
1458
1459         [Cocoa] WKRemoteObjectCoder doesn’t handle CGSize
1460         https://bugs.webkit.org/show_bug.cgi?id=168031
1461
1462         Reviewed by Tim Horton.
1463
1464         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
1465         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
1466         (TEST):
1467         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
1468         (-[RemoteObjectRegistryPlugIn takeSize:completionHandler:]):
1469
1470 2017-02-08  Chris Dumez  <cdumez@apple.com>
1471
1472         Use smaller tiles in windows that are not active to facilitate App Napping
1473         https://bugs.webkit.org/show_bug.cgi?id=167997
1474         <rdar://problem/30358835>
1475
1476         Reviewed by Simon Fraser.
1477
1478         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1479         (WTR::PlatformWebView::setWindowIsKey):
1480         Actually update windowIsKey state of NSWindow so the WebView
1481         properly updates its activity state.
1482
1483 2017-02-08  Wenson Hsieh  <wenson_hsieh@apple.com>
1484
1485         Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData
1486         https://bugs.webkit.org/show_bug.cgi?id=167942
1487         <rdar://problem/30315079>
1488
1489         Reviewed by Tim Horton.
1490
1491         Adds a new test case that simulates dragging from a source that only vends JPEG images or UTF8 plaintext into a
1492         contenteditable area. An image element and the plain text content, respectively, should be inserted into the
1493         contenteditable in these cases.
1494
1495         The DragSource and DragInfo are used to mock dragging into the WebView. There is no reliance on using mouse
1496         events in this test, since we call the dragging delegate methods (draggingEntered:, draggingUpdated:, and
1497         performDragOperation:) directly.
1498
1499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1500         * TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm: Added.
1501         (+[FrameLoadCompletionListener listenerWithCompletionBlock:]):
1502         (-[FrameLoadCompletionListener initWithCompletionBlock:]):
1503         (-[FrameLoadCompletionListener webView:didFinishLoadForFrame:]):
1504         (-[DragSource draggingSourceOperationMaskForLocal:]):
1505         (-[DragInfo initWithImage:offset:pasteboard:source:destinationWindow:]):
1506         (-[DragInfo lastMousePosition]):
1507         (-[DragInfo setLastMousePosition:]):
1508         (-[DragInfo draggingDestinationWindow]):
1509         (-[DragInfo draggingSourceOperationMask]):
1510         (-[DragInfo draggingLocation]):
1511         (-[DragInfo draggedImageLocation]):
1512         (-[DragInfo draggedImage]):
1513         (-[DragInfo draggingPasteboard]):
1514         (-[DragInfo draggingSource]):
1515         (-[DragInfo draggingSequenceNumber]):
1516         (-[DragInfo slideDraggedImageTo:]):
1517         (-[DragInfo namesOfPromisedFilesDroppedAtDestination:]):
1518         (-[DragInfo draggingFormation]):
1519         (-[DragInfo setDraggingFormation:]):
1520         (-[DragInfo animatesToDestination]):
1521         (-[DragInfo setAnimatesToDestination:]):
1522         (-[DragInfo numberOfValidItemsForDrop]):
1523         (-[DragInfo setNumberOfValidItemsForDrop:]):
1524         (-[DragInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
1525         (-[DragInfo springLoadingHighlight]):
1526         (-[DragInfo resetSpringLoading]):
1527         (TestWebKitAPI::getTestImage):
1528         (TestWebKitAPI::webViewAfterPerformingDragOperation):
1529         (TestWebKitAPI::TEST):
1530         * TestWebKitAPI/Tests/mac/full-page-contenteditable.html: Added.
1531
1532 2017-02-08  Jer Noble  <jer.noble@apple.com>
1533
1534         Move FullscreenClient creation into WebViewImpl, for use in (deprecated) WKView.
1535         https://bugs.webkit.org/show_bug.cgi?id=168007
1536
1537         Reviewed by Alex Christensen.
1538
1539         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenDelegate.mm:
1540         (didFinishLoadForFrame):
1541         (TestWebKitAPI::TEST):
1542
1543 2017-02-08  Commit Queue  <commit-queue@webkit.org>
1544
1545         Unreviewed, rolling out r211873.
1546         https://bugs.webkit.org/show_bug.cgi?id=168001
1547
1548         It's in jhbuild for consistent layout tests (Requested by
1549         mcatanzaro on #webkit).
1550
1551         Reverted changeset:
1552
1553         "[GTK] Add icu packages to Tools/gtk/install-dependencies"
1554         https://bugs.webkit.org/show_bug.cgi?id=167993
1555         http://trac.webkit.org/changeset/211873
1556
1557 2017-02-08  Adrian Perez de Castro  <aperez@igalia.com>
1558
1559         [GTK] Add icu packages to Tools/gtk/install-dependencies
1560         https://bugs.webkit.org/show_bug.cgi?id=167993
1561
1562         Reviewed by Michael Catanzaro.
1563
1564         * gtk/install-dependencies: Add "icu" to the list of required packages (or "icu-dev", or "icu-devel"
1565         depending in the GNU/Linux distribution)
1566
1567 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1568
1569         Update flakiness dashboard configuration.
1570         https://bugs.webkit.org/show_bug.cgi?id=167957
1571
1572         Reviewed by Alexey Proskuryakov.
1573
1574         * TestResultServer/static-dashboards/builders.jsonp:
1575
1576 2017-02-07  Ryan Haddad  <ryanhaddad@apple.com>
1577
1578         Replace a bot that has an incorrect configuration.
1579         https://bugs.webkit.org/show_bug.cgi?id=167747
1580
1581         Rubber-stamped by Alexey Proskuryakov.
1582
1583         * BuildSlaveSupport/build.webkit.org-config/config.json:
1584
1585 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
1586
1587         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
1588         https://bugs.webkit.org/show_bug.cgi?id=167927
1589
1590         Reviewed by Brent Fulgham.
1591
1592         Enable ComplexTextController API tests on the Win and GTK ports.
1593
1594         * TestWebKitAPI/PlatformGTK.cmake:
1595         * TestWebKitAPI/PlatformWin.cmake:
1596
1597 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
1598
1599         File index appended to previous file in svn-create-patch with SVN 1.9
1600         https://bugs.webkit.org/show_bug.cgi?id=167903
1601         <rdar://problem/30387395>
1602
1603         Reviewed by Daniel Bates.
1604
1605         * Scripts/VCSUtils.pm:
1606         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
1607         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
1608         trailing newline character from the expected result before comparing it to the actual result.
1609
1610 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
1611
1612         [webkitdirs] remove unused host_processor variable in determineArchitecture()
1613         https://bugs.webkit.org/show_bug.cgi?id=167936
1614
1615         Reviewed by Michael Catanzaro.
1616
1617         * Scripts/webkitdirs.pm:
1618         (determineArchitecture):
1619         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
1620         since r195083.
1621
1622 2017-02-07  Youenn Fablet  <youenn@apple.com>
1623
1624         Use a JSON file to define which WPT files/folders to import
1625         https://bugs.webkit.org/show_bug.cgi?id=167923
1626
1627         Reviewed by Alex Christensen.
1628
1629         * Scripts/webkitpy/w3c/test_downloader.py:
1630         (TestDownloader.__init__):
1631         (TestDownloader._init_paths_from_expectations):
1632         * Scripts/webkitpy/w3c/test_importer.py:
1633         (parse_args):
1634         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1635
1636 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
1637
1638         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
1639         https://bugs.webkit.org/show_bug.cgi?id=167916
1640
1641         Reviewed by Carlos Garcia Campos.
1642
1643         URL of mesa-11.0.6.tar.xz has been moved.
1644
1645         * gtk/jhbuild.modules: Fix the module path.
1646
1647 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
1648
1649         Static Analyzer: Address some leaks in MiniBrowser
1650         https://bugs.webkit.org/show_bug.cgi?id=167897
1651
1652         Reviewed by Alexey Proskuryakov.
1653
1654         * MiniBrowser/mac/BrowserWindowController.m:
1655         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
1656         * MiniBrowser/mac/ExtensionManagerWindowController.m:
1657         (-[ExtensionManagerWindowController add:]):
1658         (-[ExtensionManagerWindowController remove:]):
1659         * MiniBrowser/mac/SettingsController.m:
1660         (-[SettingsController _populateMenu]):
1661         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
1662         Address obvious leaks caught by the static analyzer.
1663
1664 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
1665
1666         Migrate ComplexTextController to use platform-independent types
1667         https://bugs.webkit.org/show_bug.cgi?id=167833
1668
1669         Reviewed by Brent Fulgham.
1670
1671         Migrate tests away from platform-dependent types.
1672
1673         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
1674         (TestWebKitAPI::TEST_F):
1675
1676 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
1677
1678         Correct File Path Handling in SecurityOrigin and FileSystem
1679         https://bugs.webkit.org/show_bug.cgi?id=167894
1680         <rdar://problem/30380080>
1681
1682         Reviewed by Alexey Proskuryakov.
1683
1684         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
1685         and perform same-volume checks using filesystem-compatible paths.        
1686         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
1687         filesystem paths, and perform validation of same-volume checks.
1688         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
1689         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
1690         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
1691         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
1692
1693 2017-02-06  Jer Noble  <jer.noble@apple.com>
1694
1695         Playback stalls when a SourceBuffer append causes frame eviction
1696         https://bugs.webkit.org/show_bug.cgi?id=167834
1697
1698         Reviewed by Eric Carlson.
1699
1700         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
1701         for the WTF::MediaTime class.
1702
1703         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1704         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1705         (TestWebKitAPI::TEST):
1706         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
1707         (WTF::operator<<):
1708         (TestWebKitAPI::TestSample::create):
1709         (TestWebKitAPI::TestSample::TestSample):
1710         (TestWebKitAPI::TEST_F):
1711
1712 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
1713
1714         Change capitalization in platform name after r211735.
1715
1716         Unreviewed dashboard fix.
1717
1718         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1719         (WebKitBuildbot):
1720
1721 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
1722
1723         Move the Leaks bot to Sierra
1724         https://bugs.webkit.org/show_bug.cgi?id=167886
1725
1726         Reviewed by Daniel Bates.
1727
1728         * BuildSlaveSupport/build.webkit.org-config/config.json:
1729         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1730         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1731         (LeaksViewer._displayURLPrompt):
1732         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1733         (WebKitBuildbot):
1734
1735 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
1736
1737         Prevent app crash on launch during simctl install workaround
1738         https://bugs.webkit.org/show_bug.cgi?id=167685
1739
1740         Reviewed by Daniel Bates.
1741
1742         * Scripts/webkitpy/port/simulator_process.py:
1743         (SimulatorProcess.__init__): Pass environment to install.
1744         * Scripts/webkitpy/xcode/simulator.py:
1745         (Device.install_app): Accept environment, pass environment to launch.
1746
1747 2017-02-06  Alex Christensen  <achristensen@webkit.org>
1748
1749         Rebase API tests after r211638
1750         https://bugs.webkit.org/show_bug.cgi?id=167779
1751
1752         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1753         (TestWebKitAPI::TEST_F):
1754         URLs with non-special schemes and characters like % in the host now fail to parse,
1755         more like their special counterparts and according to spec.
1756
1757 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
1758
1759         Unreviewed trivial fix after r211697.
1760         https://bugs.webkit.org/show_bug.cgi?id=167863
1761
1762         * Scripts/run-javascriptcore-tests:
1763         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
1764
1765 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
1766
1767         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
1768         https://bugs.webkit.org/show_bug.cgi?id=167850
1769
1770         Reviewed by Tim Horton.
1771
1772         * DumpRenderTree/TestRunner.cpp:
1773         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
1774
1775 2017-02-04  Andreas Kling  <akling@apple.com>
1776
1777         Plug some leaks in TestController and UIScriptContext.
1778         <https://webkit.org/b/167839>
1779
1780         Reviewed by Alexey Proskuryakov.
1781
1782         Fix a couple of the leaks seen on the leaks bot.
1783
1784         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
1785         (UIScriptContext::runUIScript):
1786         * WebKitTestRunner/TestController.cpp:
1787         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
1788         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
1789
1790 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
1791
1792         WK1 mouse events are missing movementX and movementY for pointerlock.
1793         https://bugs.webkit.org/show_bug.cgi?id=167775
1794         rdar://problem/30343810
1795
1796         Reviewed by Alexey Proskuryakov.
1797
1798         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
1799
1800         * DumpRenderTree/mac/EventSendingController.mm:
1801         (-[EventSendingController mouseMoveToX:Y:]):
1802         * WebKitTestRunner/mac/EventSenderProxy.mm:
1803         (WTR::EventSenderProxy::mouseMoveTo):
1804
1805 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
1806
1807         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
1808         https://bugs.webkit.org/show_bug.cgi?id=167774
1809
1810         Reviewed by Tim Horton.
1811
1812         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
1813         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
1814         web process are async, so the callback fires after the web process gets the new state.
1815
1816         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1817         (WTR::UIScriptController::removeViewFromWindow):
1818         (WTR::UIScriptController::addViewToWindow):
1819         * DumpRenderTree/mac/DumpRenderTree.mm:
1820         (createWebViewAndOffscreenWindow):
1821         (resetWebViewToConsistentStateBeforeTesting):
1822         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1823         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1824         (WTR::UIScriptController::removeViewFromWindow):
1825         (WTR::UIScriptController::addViewToWindow):
1826         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1827         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1828         (WTR::UIScriptController::removeViewFromWindow):
1829         (WTR::UIScriptController::addViewToWindow):
1830         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1831         * WebKitTestRunner/PlatformWebView.h:
1832         * WebKitTestRunner/TestController.cpp:
1833         (WTR::TestController::resetStateToConsistentValues):
1834         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1835         (WTR::PlatformWebView::removeFromWindow):
1836         (WTR::PlatformWebView::addToWindow):
1837         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1838         (WTR::UIScriptController::removeViewFromWindow):
1839         (WTR::UIScriptController::addViewToWindow):
1840         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1841         (WTR::PlatformWebView::removeFromWindow):
1842         (WTR::PlatformWebView::addToWindow):
1843         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1844         (WTR::UIScriptController::removeViewFromWindow):
1845         (WTR::UIScriptController::addViewToWindow):
1846
1847 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
1848
1849         Remove check for SkipSafariExecutableEntitlementChecks
1850         https://bugs.webkit.org/show_bug.cgi?id=167762
1851
1852         Reviewed by Dan Bernstein.
1853
1854         Follow-up fix: don't break internal behavior.
1855
1856         * Scripts/webkitdirs.pm:
1857         (safariPath):
1858         (executableHasEntitlements): Deleted.
1859         (safariPathFromSafariBundle): Deleted.
1860         (installedSafariPath): Deleted.
1861
1862 2017-02-03  Daniel Bates  <dabates@apple.com>
1863
1864         [Mac][WK2] Add SPI to override the Content Security Policy of a page
1865         https://bugs.webkit.org/show_bug.cgi?id=167810
1866         <rdar://problem/30102568>
1867
1868         Reviewed by Anders Carlsson.
1869
1870         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
1871
1872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1873         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
1874         (TEST):
1875         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
1876         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
1877         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
1878         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
1879
1880 2017-02-02  Alex Christensen  <achristensen@webkit.org>
1881
1882         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
1883         https://bugs.webkit.org/show_bug.cgi?id=167773
1884         <rdar://problem/30221102>
1885
1886         Reviewed by Ryosuke Niwa.
1887
1888         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1889         (TestWebKitAPI::TEST_F):
1890
1891 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
1892
1893         Remove check for SkipSafariExecutableEntitlementChecks
1894         https://bugs.webkit.org/show_bug.cgi?id=167762
1895         rdar://problem/22480673
1896
1897         Reviewed by Dan Bernstein.
1898
1899         * Scripts/webkitdirs.pm:
1900         (safariPathFromSafariBundle):
1901         (skipSafariExecutableEntitlementChecks): Deleted.
1902
1903 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
1904
1905         Undefined subroutine in svn-create-patch
1906         https://bugs.webkit.org/show_bug.cgi?id=167742
1907
1908         Unreviewed build-fix after r211543.
1909
1910         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
1911
1912 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1913
1914         Unreviewed. Fix jhbuild dependencies build.
1915
1916         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
1917         Patch updated.
1918
1919 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1920
1921         [EME][GStreamer] Fixed decryptor selection
1922         https://bugs.webkit.org/show_bug.cgi?id=167588
1923
1924         Reviewed by Žan Doberšek.
1925
1926         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
1927
1928         * gtk/jhbuild.modules: Added patches to gstreamer and
1929         gst-plugins-good packages.
1930         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
1931         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
1932
1933 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
1934
1935         Make run-benchmark script supports 'config' key in test plan.
1936         https://bugs.webkit.org/show_bug.cgi?id=167715
1937
1938         Reviewed by Ryosuke Niwa.
1939
1940         Add support for 'config' key in test paln.
1941         'config' key is a dictionary that specifies environment configurations while test is running.
1942         Specifies orientation to be portrait in MotionMark benchmark.
1943
1944         * Scripts/webkitpy/benchmark_runner/README.md:
1945         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1946         (BenchmarkRunner.__init__):
1947         (BenchmarkRunner._run_benchmark):
1948         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1949         (BrowserDriver.prepare_env):
1950         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
1951         (LinuxBrowserDriver.prepare_env):
1952         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1953         (OSXBrowserDriver.prepare_env):
1954         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1955         (OSXSafariDriver.prepare_env):
1956         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
1957
1958 2017-02-01  Daniel Bates  <dabates@apple.com>
1959
1960         REGRESSION (r210820): svn-create-patch does not emit property change only diff
1961         https://bugs.webkit.org/show_bug.cgi?id=167169
1962
1963         Reviewed by David Kilzer.
1964
1965         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
1966         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
1967         header from the output of "svn diff" on a file that was copied or moved.
1968
1969         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
1970         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
1971         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
1972         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
1973         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
1974         of a file with only a property change also does not contain any chunk range lines. Therefore
1975         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
1976         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
1977         we should directly test for the presence of a leading SVN diff header with an empty body and
1978         remove such lines from the diff.
1979
1980         * Scripts/VCSUtils.pm:
1981         (fixSVNPatchForAdditionWithHistory): Added.
1982         * Scripts/svn-create-patch:
1983         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
1984         we have a non empty patch for an added file with history (i.e. a copied or moved file).
1985         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
1986
1987 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
1988
1989         [Mac] Update CARingBuffer class
1990         https://bugs.webkit.org/show_bug.cgi?id=167656
1991
1992         Reviewed by Jer Noble.
1993
1994         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1995         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
1996         (TestWebKitAPI::CARingBufferTest::SetUp):
1997         (TestWebKitAPI::CARingBufferTest::setup):
1998         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
1999         (TestWebKitAPI::CARingBufferTest::description):
2000         (TestWebKitAPI::CARingBufferTest::bufferList):
2001         (TestWebKitAPI::CARingBufferTest::ringBuffer):
2002         (TestWebKitAPI::CARingBufferTest::capacity):
2003         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
2004         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
2005         (TestWebKitAPI::TEST_F):
2006         (TestWebKitAPI::MixingTest::run):
2007
2008 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
2009
2010         [Mac] TestWebKitAPI includes system frameworks incorrectly
2011         https://bugs.webkit.org/show_bug.cgi?id=167703
2012         rdar://problem/30301498
2013
2014         Reviewed by Ryosuke Niwa.
2015
2016         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
2017         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
2018
2019         Also, reduced the number of subframework search paths, looks like we only need one now.
2020
2021         * TestWebKitAPI/Configurations/Base.xcconfig:
2022
2023 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
2024
2025         Correct "filesHaveSameVolume" predicate
2026         https://bugs.webkit.org/show_bug.cgi?id=167696
2027         <rdar://problem/30298722>
2028
2029         Reviewed by David Kilzer.
2030
2031         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
2032         percent-escaped path inputs.
2033
2034         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
2035         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
2036         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
2037         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
2038         (TestWebKitAPI::TEST_F):
2039
2040 2017-02-01  Tomas Popela  <tpopela@redhat.com>
2041
2042         Unreviewed. Fix coding style in MiniBrowser
2043
2044         * MiniBrowser/gtk/BrowserWindow.c:
2045         (editingCommandCallback):
2046         (insertImageCommandCallback):
2047         (insertLinkCommandCallback):
2048
2049 2017-02-01  Tomas Popela  <tpopela@redhat.com>
2050
2051         [GTK] Add an API to add a custom tab into the print dialog
2052         https://bugs.webkit.org/show_bug.cgi?id=151998
2053
2054         Reviewed by Carlos Garcia Campos.
2055
2056         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
2057         that is testing a newly added API.
2058
2059         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
2060         (testPrintCustomWidget):
2061         (beforeAll):
2062
2063 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
2064
2065         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
2066         https://bugs.webkit.org/show_bug.cgi?id=166529
2067
2068         Reviewed by Xabier Rodriguez-Calvar.
2069
2070         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
2071         New patch version accepted in GStreamer upstream.
2072
2073 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2074
2075         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
2076         https://bugs.webkit.org/show_bug.cgi?id=167498
2077
2078         Reviewed by Carlos Garcia Campos.
2079
2080         Depending on the distro version you can need either libxfont1-dev
2081         or libfont-dev to build with jhbuild.
2082
2083         * gtk/install-dependencies:
2084
2085 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2086
2087         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
2088         https://bugs.webkit.org/show_bug.cgi?id=167594
2089
2090         Unreviewed test gardening.
2091
2092         Disabling this test while we investigate the cause of a timeout on ios-simulator.
2093
2094         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
2095         (TEST):
2096
2097 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
2098
2099         Move slow-running microbenchmarks out of JSTests/microbenchmarks
2100         https://bugs.webkit.org/show_bug.cgi?id=167676
2101
2102         Reviewed by Saam Barati.
2103
2104         * Scripts/run-javascriptcore-tests:
2105         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
2106
2107 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
2108
2109         Make Dump Render Tree not crash
2110         https://bugs.webkit.org/show_bug.cgi?id=167667
2111
2112         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
2113         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
2114         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
2115         This does not fix any tests, it just fixes the crash.
2116         
2117         Reviewed by Simon Fraser.
2118
2119         * DumpRenderTree/TestRunner.cpp:
2120         (TestRunner::callUIScriptCallback):
2121
2122 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2123
2124         Workaround for simctl install failing to report install failure
2125         https://bugs.webkit.org/show_bug.cgi?id=167654
2126
2127         Reviewed by Daniel Bates.
2128
2129         simctl install will sometimes report success even though install has failed.
2130         To workaround this bug, we attempt an app launch after install to ensure
2131         install has succeeded.
2132
2133         * Scripts/webkitpy/xcode/simulator.py:
2134         (Device.install_app): Attempt app launch after install, retry install if launch fails.
2135         (Device.launch_app): Correct comment.
2136
2137 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
2138
2139         Unreviewed webkitpy fix after r211405.
2140
2141         * Scripts/webkitpy/xcode/simulator.py:
2142         (Device.launch_app): Remove @staticmethod on _log_debug_error.
2143
2144 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2145
2146         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
2147
2148         * gtk/manifest.txt.in:
2149
2150 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
2151
2152         AX: enable search predication for iOS
2153         https://bugs.webkit.org/show_bug.cgi?id=167558
2154         <rdar://problem/30251367>
2155
2156         Reviewed by Joanmarie Diggs.
2157
2158         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2159         (AccessibilityUIElement::uiElementForSearchPredicate):
2160         * DumpRenderTree/mac/AccessibilityCommonMac.h:
2161         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
2162         (searchPredicateParameterizedAttributeForSearchCriteria):
2163         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2164         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2165         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2166         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
2167         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
2168         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2169         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2170         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
2171         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2172         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
2173         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2174
2175 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2176
2177         Workaround for simctl launch bug
2178         https://bugs.webkit.org/show_bug.cgi?id=167613
2179
2180         Reviewed by Daniel Bates.
2181
2182         simctl launch will sometimes fail because of a race condition when many
2183         simulators are being run simultaneously. These failures will always have
2184         an exit code of 1. This change attempts to launch an app multiple times
2185         before reporting a failure to workaround this bug.
2186
2187         * Scripts/webkitpy/xcode/simulator.py:
2188         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
2189
2190 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
2191
2192         Commit queue fails to look at real name aliases for the reviewer
2193         https://bugs.webkit.org/show_bug.cgi?id=167422
2194
2195         Reviewed by Joseph Pecoraro.
2196
2197         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2198         (test_has_valid_reviewer): Added tests.
2199
2200         * Scripts/webkitpy/common/config/committers.py:
2201         (CommitterList._name_to_contributor_map):
2202         Made _name_to_contributor_map include alias names.
2203
2204         * Scripts/webkitpy/common/config/committers_unittest.py:
2205         (CommittersTest.test_contributors_by_fuzzy_match):
2206         Removed subtests that are now obsolete, as these matches are strict. It is not
2207         obvious if distance based fuzzy matching for names is useful at all, but we can
2208         look into that some other time.
2209
2210 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
2211
2212         QueueStatusServer should have an explicit timeout for _fetch_url
2213         https://bugs.webkit.org/show_bug.cgi?id=167467
2214
2215         Reviewed by Alexey Proskuryakov.
2216
2217         * Scripts/webkitpy/common/net/statusserver.py:
2218         (StatusServer._fetch_url): Add an explicit timeout of 300s.
2219
2220 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
2221
2222         Add support for Trac instances that host multiple projects.
2223         https://bugs.webkit.org/show_bug.cgi?id=167524
2224
2225         Reviewed by Alexey Proskuryakov.
2226
2227         When multiple projects are hosted on a single Trac instance, the current
2228         behavior will retrieve changesets from all tracked projects.
2229         This patch teaches Trac.js to get project-specific changesets from Trac.
2230         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
2231         when querying the Trac timeline.
2232
2233         To tell Trac to be aware of multi-project instances we leverage the 
2234         `options` parameter when creating a new instance: 
2235
2236             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
2237
2238         If this option is not provided, the original behaviour will prevail.
2239         Additionally, add corresponding tests.
2240
2241         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
2242         (Trac): Reason about new optional parameter 'projectIdentifier'.
2243         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
2244         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
2245         replace default parameter `changeset=on` with `repo-projectname=on`.
2246         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
2247         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
2248         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
2249         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
2250         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
2251         Add the following tests:
2252             test("revisionURL")
2253             test("revisionURL with Trac Identifier")
2254             test("_xmlTimelineURL")
2255             test("_xmlTimelineURL with Trac Identifier")
2256         (this.view._latestProductiveIteration): Fix missing ';'.
2257
2258 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
2259
2260         Correct spacing regression on inter-element complex path shaping on some fonts
2261         https://bugs.webkit.org/show_bug.cgi?id=166013
2262
2263         Reviewed by Simon Fraser.
2264
2265         Unskip existing tests and make some new tests:
2266         - Testing complex text with no origins
2267         - Testing initial expansions
2268         - Testing the sign of vertical advances
2269
2270         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2271         (TestWebKitAPI::TEST_F):
2272
2273 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2274
2275         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
2276         https://bugs.webkit.org/show_bug.cgi?id=167596
2277
2278         Reviewed by Daniel Bates.
2279
2280         We avoid needing a thin directory by invoking the zip program with
2281         the list of directories from the build directory to be zipped,
2282         and by using the zip feature to exclude files matching a pattern.
2283
2284         * BuildSlaveSupport/built-product-archive:
2285         (copyBuildFiles):
2286         (createZipFromList):
2287         (archiveBuiltProduct):
2288
2289 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
2290
2291         Use simctl instead of LayoutTestRelay
2292         https://bugs.webkit.org/show_bug.cgi?id=165927
2293
2294         Reviewed by Daniel Bates.
2295
2296         Part 1
2297
2298         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
2299         simulators through simctl (iOS 10 and later), use this functionality instead.
2300
2301         * Scripts/webkitpy/port/base.py:
2302         (Port.__init__): Added _test_runner_process_constructor.
2303         * Scripts/webkitpy/port/darwin.py:
2304         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
2305         * Scripts/webkitpy/port/driver.py:
2306         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
2307         (IOSSimulatorDriver): Deleted.
2308         * Scripts/webkitpy/port/driver_unittest.py:
2309         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
2310         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
2311         (DriverTest.test_start_actually_starts): Ditto.
2312         * Scripts/webkitpy/port/ios.py:
2313         (IOSSimulatorPort): Remove relay_name.
2314         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
2315         (IOSSimulatorPort._create_simulators): Formatting change.
2316         (IOSSimulatorPort.relay_path): Deleted.
2317         (IOSSimulatorPort._check_relay): Deleted.
2318         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
2319         (IOSSimulatorPort._build_relay): Deleted.
2320         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
2321         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
2322         * Scripts/webkitpy/port/ios_unittest.py:
2323         (iosTest.test_32bit): Update test.
2324         (iosTest.test_64bit): Update test.
2325         * Scripts/webkitpy/port/server_process.py:
2326         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
2327         (ServerProcess._set_file_nonblocking): Added to share common code.
2328         * Scripts/webkitpy/port/server_process_mock.py:
2329         (MockServerProcess.__init__): Added argument worker_number.
2330         * Scripts/webkitpy/port/simulator_process.py: Added.
2331         (SimulatorProcess): Added.
2332         (SimulatorProcess.Popen): Added.
2333         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
2334         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
2335         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
2336         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
2337         (SimulatorProcess._reset): Added. Unlink fifos.
2338         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
2339         (SimulatorProcess._kill): Added. Shutdown app on simulator.
2340         * Scripts/webkitpy/xcode/simulator.py:
2341         (Device.__init__): Accept host to run install/launch/terminate.
2342         (Device.install_app): Install app to target Device.
2343         (Device.launch_app): Launch app on target Device.
2344         (Device.terminate_app): Shutdown app on target Device.
2345         (Simulator._parse_devices): Pass host to Device.
2346
2347 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2348
2349         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
2350         https://bugs.webkit.org/show_bug.cgi?id=167411
2351
2352         Reviewed by Michael Catanzaro.
2353
2354         Disable the ARM iwMMXt fast path for pixman, because it triggers
2355         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
2356
2357         * gtk/jhbuild.modules:
2358
2359 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2360
2361         [GTK] Add API to handle the accelerated compositing policy
2362         https://bugs.webkit.org/show_bug.cgi?id=167509
2363
2364         Reviewed by Michael Catanzaro.
2365
2366         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
2367         as a special case. Also add test cases to the get/set API.
2368
2369         * MiniBrowser/gtk/BrowserSettingsDialog.c:
2370         (hardwareAccelerationPolicyToString):
2371         (stringToHardwareAccelerationPolicy):
2372         (cellRendererChanged):
2373         (browserSettingsDialogConstructed):
2374         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2375         (testWebKitSettings):
2376
2377 2017-01-29  Andy Estes  <aestes@apple.com>
2378
2379         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
2380         https://bugs.webkit.org/show_bug.cgi?id=167563
2381         <rdar://problem/30253207>
2382
2383         Reviewed by Andreas Kling.
2384
2385         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
2386         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2387         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2388         (runTest):
2389         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
2390         (TEST):
2391
2392 2017-01-29  Dan Bernstein  <mitz@apple.com>
2393
2394         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
2395         https://bugs.webkit.org/show_bug.cgi?id=167565
2396
2397         Reviewed by Sam Weinig.
2398
2399         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2400         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
2401         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
2402         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
2403         (TEST):
2404         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
2405         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2406         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
2407         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
2408
2409 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
2410
2411         Add Link Preload as an off-by-default experimental feature menu item.
2412         https://bugs.webkit.org/show_bug.cgi?id=167201
2413
2414         Reviewed by Ryosuke Niwa.
2415
2416         * DumpRenderTree/mac/DumpRenderTree.mm:
2417         (resetWebPreferencesToConsistentValues):
2418         * DumpRenderTree/win/DumpRenderTree.cpp:
2419         (resetWebPreferencesToConsistentValues):
2420
2421 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2422
2423         Add User Timing Experimental Feature
2424         https://bugs.webkit.org/show_bug.cgi?id=167542
2425         <rdar://problem/22746307>
2426
2427         Reviewed by Ryosuke Niwa.
2428
2429         * DumpRenderTree/mac/DumpRenderTree.mm:
2430         (enableExperimentalFeatures):
2431         (resetWebPreferencesToConsistentValues):
2432         * DumpRenderTree/win/DumpRenderTree.cpp:
2433         (enableExperimentalFeatures):
2434
2435 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
2436
2437         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
2438         https://bugs.webkit.org/show_bug.cgi?id=167519
2439
2440         Reviewed by Ryosuke Niwa.
2441
2442         * QueueStatusServer/templates/statusbubble.html:
2443         To measure the bubbleContainer's width, it must not be wrapping based
2444         on its parent container. So when measuring the width temporarily set
2445         the parent to a very large width so as to not artificially wrap us.
2446         Restore the parent's width after measuring.
2447
2448 2017-01-27  Andy Estes  <aestes@apple.com>
2449
2450         [iOS] Add a test for _WKNSFileManagerExtras
2451         https://bugs.webkit.org/show_bug.cgi?id=167478
2452
2453         Reviewed by Andreas Kling.
2454
2455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2456         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
2457         (expectAttributes):
2458         (TEST):
2459
2460 2017-01-27  Keith Miller  <keith_miller@apple.com>
2461
2462         run-benchmarks should make sure it passes the test url to the right application
2463         https://bugs.webkit.org/show_bug.cgi?id=167533
2464
2465         Reviewed by Joseph Pecoraro.
2466
2467         This fixes an issue when trying to run-benchmark script with the
2468         system default browser set to STP. Previously, it would run
2469         the test in STP rather than the provided build. Now, it should run
2470         in the provided build.
2471
2472         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2473         (OSXSafariDriver.launch_url):
2474
2475 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2476
2477         [Cocoa] Prepare ComplexTextController for unit testing
2478         https://bugs.webkit.org/show_bug.cgi?id=167493
2479
2480         Reviewed by Simon Fraser.
2481
2482         Addressing post-review comments from Simon Fraser.
2483
2484         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
2485         (TestWebKitAPI::TEST_F):
2486
2487 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
2488
2489         [Cocoa] Prepare ComplexTextController for unit testing
2490         https://bugs.webkit.org/show_bug.cgi?id=167493
2491
2492         Reviewed by Dean Jackson.
2493
2494         Create four unit tests.
2495
2496         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2497         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
2498         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
2499         (TestWebKitAPI::TEST_F):
2500
2501 2017-01-26  Chris Dumez  <cdumez@apple.com>
2502
2503         Crash when navigating back to a page in PacheCache when one of its frames has been removed
2504         https://bugs.webkit.org/show_bug.cgi?id=167421
2505         <rdar://problem/30188490>
2506
2507         Reviewed by Darin Adler.
2508
2509         Add a new setting allowing layout tests to enable PageCache in a window
2510         that has an opener, for convenience.
2511
2512         * DumpRenderTree/mac/DumpRenderTree.mm:
2513         (resetWebPreferencesToConsistentValues):
2514         * DumpRenderTree/win/DumpRenderTree.cpp:
2515         (resetWebPreferencesToConsistentValues):
2516         * WebKitTestRunner/TestController.cpp:
2517         (WTR::TestController::resetPreferencesToConsistentValues):
2518
2519 2017-01-26  Keith Miller  <keith_miller@apple.com>
2520
2521         classInfo should take a VM so it is not materialized from the object on each call
2522         https://bugs.webkit.org/show_bug.cgi?id=167424
2523
2524         Rubber Stamped by Michael Saboff.
2525
2526         Previously, classInfo() would get the VM from the target's
2527         MarkedBlock.  Most callers already have a VM on hand, so it is
2528         wasteful to compute the VM from the marked block every time. This
2529         patch refactors some of the most common callers of classInfo(),
2530         jsDynamicCast and inherits to take a VM as well.
2531
2532         * DumpRenderTree/TestRunner.cpp:
2533         (setAudioResultCallback):
2534
2535 2017-01-26  Jer Noble  <jer.noble@apple.com>
2536
2537         Autoplay muted videos stop playback of any streaming app in the background
2538         https://bugs.webkit.org/show_bug.cgi?id=163993
2539         <rdar://problem/29020431>
2540
2541         Reviewed by Eric Carlson.
2542
2543         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2544         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
2545         (TestWebKitAPI::TEST):
2546         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
2547
2548 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
2549
2550         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
2551         https://bugs.webkit.org/show_bug.cgi?id=167466
2552
2553         Unreviewed test gardening.
2554
2555         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2556         (TEST):
2557
2558 2017-01-26  Matt Rajca  <mrajca@apple.com>
2559
2560         Notify clients when the user plays media otherwise prevented from autoplaying
2561         https://bugs.webkit.org/show_bug.cgi?id=167390
2562
2563         Reviewed by Alex Christensen.
2564
2565         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2566         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2567         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2568         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2569         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2570         (TEST):
2571         * TestWebKitAPI/cocoa/TestWKWebView.h:
2572         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2573         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2574         (-[TestWKWebView waitForLoad]):
2575         (-[TestWKWebView mouseUpAtPoint:]):
2576         * WebKitTestRunner/TestController.cpp:
2577         (WTR::TestController::createOtherPage):
2578         (WTR::TestController::createWebViewWithOptions):
2579
2580 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
2581
2582         Crash when setting custom scale factor.
2583         https://bugs.webkit.org/show_bug.cgi?id=167369
2584
2585         Reviewed by Sam Weinig.
2586
2587         Added API test.
2588
2589         * TestWebKitAPI/PlatformWin.cmake:
2590         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
2591         (TestWebKitAPI::WebKitCreateInstance):
2592         (TestWebKitAPI::ScaleWebView::SetUp):
2593         (TestWebKitAPI::ScaleWebView::TearDown):
2594         (TestWebKitAPI::TEST_F):
2595
2596 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2597
2598         run-benchmark nests MotionMark results by the suite name twice
2599         https://bugs.webkit.org/show_bug.cgi?id=164948
2600
2601         Reviewed by Said Abou-Hallawa.
2602
2603         Use a single level MotionMark now that this is the name of the benchmark,
2604         and we no longer have tests that aren't part of the MotionMark suite.
2605
2606         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
2607
2608 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
2609
2610         Unreviewed, rolling out r211193.
2611
2612         This change broke internal builds.
2613
2614         Reverted changeset:
2615
2616         "Notify clients when the user plays media otherwise prevented
2617         from autoplaying"
2618         https://bugs.webkit.org/show_bug.cgi?id=167390
2619         http://trac.webkit.org/changeset/211193
2620
2621 2017-01-25  Matt Rajca  <mrajca@apple.com>
2622
2623         Notify clients when the user plays media otherwise prevented from autoplaying
2624         https://bugs.webkit.org/show_bug.cgi?id=167390
2625
2626         Reviewed by Alex Christensen.
2627
2628         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2629         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
2630         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
2631         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2632         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
2633         (TEST):
2634         * TestWebKitAPI/cocoa/TestWKWebView.h:
2635         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2636         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
2637         (-[TestWKWebView waitForLoad]):
2638         (-[TestWKWebView mouseUpAtPoint:]):
2639         * WebKitTestRunner/TestController.cpp:
2640         (WTR::TestController::createOtherPage):
2641         (WTR::TestController::createWebViewWithOptions):
2642
2643 2017-01-25  Matt Rajca  <mrajca@apple.com>
2644
2645         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
2646         https://bugs.webkit.org/show_bug.cgi?id=167385
2647
2648         Reviewed by Alex Christensen.
2649
2650         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
2651         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
2652         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2653         (TEST): Allow inline (rather than full screen) media playback on iOS.
2654
2655 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2656
2657         [GTK] Icon Database should be in private browsing mode for ephemeral web views
2658         https://bugs.webkit.org/show_bug.cgi?id=167414
2659
2660         Reviewed by Michael Catanzaro.
2661
2662         Add a test case to check ephemeral web views don't write favicons to the database.
2663
2664         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
2665         (ephemeralViewLoadChanged):
2666         (testPrivateBrowsing):
2667         (testFaviconDatabase):
2668
2669 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2670
2671         [GTK] Add a private browsing mode to MiniBrowser
2672         https://bugs.webkit.org/show_bug.cgi?id=167413
2673
2674         Reviewed by Michael Catanzaro.
2675
2676         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
2677         private windows, even on non-private instances.
2678
2679         * MiniBrowser/gtk/BrowserWindow.c:
2680         (webViewTitleChanged): Add [Private] to title window for private windows.
2681         (webViewCreate): Pass web context to browser_window_new.
2682         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
2683         (browserWindowFinalize): Disconnect web context signal handlers.
2684         (browser_window_init): Add shortcut for opening private window.
2685         (browser_window_new): It now receives the context and connect to download-started here.
2686         (browser_window_get_web_context): Return the context.
2687         * MiniBrowser/gtk/BrowserWindow.h:
2688         * MiniBrowser/gtk/main.c:
2689         (createBrowserTab): Create the web view for the window web context.
2690         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
2691         (aboutDataHandleRequest): Ditto.
2692         (aboutURISchemeRequestCallback): Ditto.
2693         (main): Create ephemeral web context if private command line option is used.
2694
2695 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
2696
2697         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
2698         https://bugs.webkit.org/show_bug.cgi?id=167409
2699
2700         Reviewed by Antti Koivisto.
2701
2702         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
2703         as well as tests for the newly added matchingElementInFlatTree.
2704
2705         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
2706         (TestWebKitAPI::runJavaScriptAlert):
2707         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
2708         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
2709         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
2710
2711 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2712
2713         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
2714         https://bugs.webkit.org/show_bug.cgi?id=167370
2715
2716         Reviewed by Michael Catanzaro.
2717
2718         Add several test cases of ephemeral web views.
2719
2720         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
2721         (testWebViewAuthenticationStorage):
2722         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
2723         (ephemeralViewloadChanged):
2724         (testCookieManagerEphemeral):
2725         (beforeAll):
2726         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2727         (testWebKitSettings):
2728         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2729         (testWebContextEphemeral):
2730         (ephemeralViewloadChanged):
2731         (testWebContextProxySettings):
2732         (beforeAll):
2733         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2734         (ephemeralViewloadChanged):
2735         (testWebViewEphemeral):
2736         (beforeAll):
2737         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
2738         (ephemeralViewloadChanged):
2739         (testWebsiteDataEphemeral):
2740         (beforeAll):
2741
2742 2017-01-24  Alex Christensen  <achristensen@webkit.org>
2743
2744         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
2745         https://bugs.webkit.org/show_bug.cgi?id=167402
2746
2747         Reviewed by Ryosuke Niwa.
2748
2749         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
2750         (TestWebKitAPI::TEST):
2751
2752 2017-01-24  Zalan Bujtas  <zalan@apple.com>
2753
2754         Add simple line layout toggle to MiniBrowser
2755         https://bugs.webkit.org/show_bug.cgi?id=167405
2756
2757         Reviewed by Andreas Kling.
2758
2759         * MiniBrowser/mac/SettingsController.h:
2760         * MiniBrowser/mac/SettingsController.m:
2761         (-[SettingsController _populateMenu]):
2762         (-[SettingsController validateMenuItem:]):
2763         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
2764         (-[SettingsController simpleLineLayoutEnabled]):
2765         * MiniBrowser/mac/WK1BrowserWindowController.m:
2766         (-[WK1BrowserWindowController didChangeSettings]):
2767         * MiniBrowser/mac/WK2BrowserWindowController.m:
2768         (-[WK2BrowserWindowController didChangeSettings]):
2769
2770 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2771
2772         WKR does not include my nick when commit-queue lands my patch
2773         https://bugs.webkit.org/show_bug.cgi?id=167388
2774
2775         Reviewed by Ryosuke Niwa.
2776
2777         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2778         (NewCommitBot._summarize_commit_log):
2779         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2780         Perform nickname insertion before grabbing "Patch by" details.
2781         This way we can include the nickname with the full name.
2782
2783 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
2784
2785         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
2786         https://bugs.webkit.org/show_bug.cgi?id=167394
2787
2788         Reviewed by Ryosuke Niwa.
2789
2790         * Scripts/webkitperl/FeatureList.pm:
2791         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2792
2793 2017-01-24  Youenn Fablet  <youenn@apple.com>
2794
2795         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
2796         https://bugs.webkit.org/show_bug.cgi?id=167353
2797
2798         Reviewed by Alex Christensen.
2799
2800         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2801         (CMakeGenerator.initialize_targets):
2802
2803 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
2804
2805         WKR should not confuse Miguel Gomez with Andres Gomez
2806         https://bugs.webkit.org/show_bug.cgi?id=167389
2807
2808         Reviewed by Lucas Forschler.
2809
2810         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
2811         "mAndres Gomez". Fix this.
2812
2813         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2814         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
2815         space on each side of the email address, so expect both spaces to be there before
2816         considering the email for replacement.
2817         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
2818
2819 2017-01-24  Matt Rajca  <mrajca@apple.com>
2820
2821         Pass down website autoplay policies to media elements
2822         https://bugs.webkit.org/show_bug.cgi?id=167355
2823
2824         Reviewed by Alex Christensen.
2825
2826         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2827         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
2828         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
2829         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
2830         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
2831         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
2832         (TEST):
2833
2834 2017-01-24  Nan Wang  <n_wang@apple.com>
2835
2836         AX: Speak Selection does not work in an iframe
2837         https://bugs.webkit.org/show_bug.cgi?id=166794
2838         <rdar://problem/29913013>
2839
2840         Reviewed by Chris Fleizach.
2841
2842         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2843         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2844         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2845         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2846         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2847         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2848         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2849         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2850         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2851         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2852         (-[TestRunnerWKWebView dealloc]):
2853         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
2854         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
2855         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2856         (WTR::UIScriptController::retrieveSpeakSelectionContent):
2857         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
2858
2859 2017-01-24  Daniel Bates  <dabates@apple.com>
2860
2861         StringView.split() should use an iterator design pattern instead of allocating a Vector
2862         https://bugs.webkit.org/show_bug.cgi?id=163225
2863
2864         Reviewed by Darin Adler.
2865
2866         Add unit tests for StringView.split().
2867
2868         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2869         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
2870         used in the StringView.split() unit tests.
2871         (TestWebKitAPI::stringViewFromUTF8): Ditto.
2872         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
2873         object to a Vector of String objects.
2874         (TestWebKitAPI::TEST): Added the following tests:
2875             - WTF.StringViewSplitEmptyAndNullStrings
2876             - WTF.StringViewSplitBasic
2877             - WTF.StringViewSplitWithConsecutiveSeparators
2878
2879 2017-01-23  Anders Carlsson  <andersca@apple.com>
2880
2881         The Score Esports crashes on launch
2882         https://bugs.webkit.org/show_bug.cgi?id=167338
2883         rdar://problem/29948645
2884
2885         Reviewed by Dan Bernstein.
2886
2887         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
2888         (TestWebKitAPI::TEST):
2889         Add a test.
2890
2891 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2892
2893         [GTK] Add API to WebKitWebsiteDataManager to handle website data
2894         https://bugs.webkit.org/show_bug.cgi?id=146589
2895
2896         Reviewed by Michael Catanzaro.
2897
2898         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
2899         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
2900
2901         * MiniBrowser/gtk/BrowserWindow.c:
2902         (webViewDecidePolicy):
2903         (newTabCallback):
2904         * MiniBrowser/gtk/main.c:
2905         (createBrowserTab):
2906         (aboutDataRequestFree):
2907         (aboutDataRequestNew):
2908         (aboutDataRequestForView):
2909         (websiteDataRemovedCallback):
2910         (websiteDataClearedCallback):
2911         (aboutDataScriptMessageReceivedCallback):
2912         (domainListFree):
2913         (aboutDataFillTable):
2914         (gotWebsiteDataCallback):
2915         (aboutDataHandleRequest):
2916         (aboutURISchemeRequestCallback):
2917         (main):
2918         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2919         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2920         (serverCallback):
2921         (beforeAll):
2922         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
2923         (serverCallback):
2924         (WebsiteDataTest::WebsiteDataTest):
2925         (WebsiteDataTest::~WebsiteDataTest):
2926         (WebsiteDataTest::fetch):
2927         (WebsiteDataTest::remove):
2928         (WebsiteDataTest::clear):
2929         (testWebsiteDataConfiguration):
2930         (testWebsiteDataCache):
2931         (testWebsiteDataStorage):
2932         (testWebsiteDataDatabases):
2933         (testWebsiteDataAppcache):
2934         (beforeAll):
2935         (afterAll):
2936
2937 2017-01-23  Commit Queue  <commit-queue@webkit.org>
2938
2939         Unreviewed, rolling out r211062.
2940         https://bugs.webkit.org/show_bug.cgi?id=167354
2941
2942         broke API tests (Requested by alexchristensen on #webkit).
2943
2944         Reverted changeset:
2945
2946         "Pass down website autoplay policies to media elements"
2947         https://bugs.webkit.org/show_bug.cgi?id=167132
2948         http://trac.webkit.org/changeset/211062
2949
2950 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2951
2952         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
2953         https://bugs.webkit.org/show_bug.cgi?id=167330
2954
2955         Reviewed by Tim Horton.
2956
2957         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2958         (TestWebKitAPI::TEST_F):
2959
2960 2017-01-23  Alex Christensen  <achristensen@webkit.org>
2961
2962         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
2963         https://bugs.webkit.org/show_bug.cgi?id=167317
2964
2965         Reviewed by Sam Weinig.
2966
2967         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2968         (TestWebKitAPI::TEST_F):
2969
2970 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
2971
2972         svn-create-patch should emit properties when files are moved or copied
2973         https://bugs.webkit.org/show_bug.cgi?id=167264
2974
2975         Reviewed by Daniel Bates.
2976
2977         * Scripts/svn-create-patch:
2978         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
2979
2980 2017-01-23  Youenn Fablet  <youenn@apple.com>
2981
2982         [WebRTC] Filter libwebrtc link flags
2983         https://bugs.webkit.org/show_bug.cgi?id=167287
2984
2985         Reviewed by Alex Christensen.
2986
2987         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
2988         (CMakeGenerator._compute_link_flags):
2989         (CMakeGenerator._compute_link_flags.keep_flag):
2990         (CMakeGenerator._generate_compile_target_options):
2991
2992 2017-01-23  Youenn Fablet  <youennf@gmail.com>
2993
2994         [WebRTC] Make VP8 optional in libwebrtc
2995         https://bugs.webkit.org/show_bug.cgi?id=167257
2996
2997         Reviewed by Darin Adler.
2998
2999         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3000         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
3001
3002 2017-01-23  Jer Noble  <jer.noble@apple.com>
3003
3004         Video details does not apear and missing scrubber in Control Center
3005         https://bugs.webkit.org/show_bug.cgi?id=167233
3006
3007         Reviewed by Alex Christensen.
3008
3009         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
3010         NowPlayingControlTests for iOS.
3011
3012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3013         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
3014         (-[NowPlayingTestWebView setWindowVisible:]):
3015         (TestWebKitAPI::TEST):
3016         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
3017         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
3018         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
3019         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
3020         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
3021         (SOFT_LINK_CLASS):
3022         (-[TestMessageHandler addMessage:withHandler:]):
3023         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
3024         (__simulated_forceClickAssociatedEventsMask):
3025         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
3026         (-[TestWKWebViewHostWindow isKeyWindow]):
3027         (-[TestWKWebViewHostWindow makeKeyWindow]):
3028         (-[TestWKWebViewHostWindow resignKeyWindow]):
3029         (-[TestWKWebView initWithFrame:]):
3030         (-[TestWKWebView initWithFrame:configuration:]):
3031         (-[TestWKWebView _setUpTestWindow:]):
3032         (-[TestWKWebView performAfterReceivingMessage:action:]):
3033         (-[TestWKWebView loadTestPageNamed:]):
3034         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
3035         (-[TestWKWebView stringByEvaluatingJavaScript:]):
3036         (-[TestWKWebView waitForMessage:]):
3037         (-[TestWKWebView performAfterLoading:]):
3038         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
3039         (-[TestWKWebView typeCharacter:]):
3040
3041 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3042
3043         Unreviewed. Bring back gtk-doc error messages after r209981.
3044
3045         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
3046         impossible to know what's wrong.
3047
3048         * gtk/gtkdoc.py:
3049         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
3050
3051 2017-01-20  Youenn Fablet  <youennf@gmail.com>
3052
3053         [WebRTC] Update build system to make G711 optional in libwebrtc
3054         https://bugs.webkit.org/show_bug.cgi?id=167256
3055
3056         Reviewed by Alex Christensen.
3057
3058         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
3059         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
3060
3061 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3062
3063         Cleanup RuntimeEnabledFeatures
3064         https://bugs.webkit.org/show_bug.cgi?id=167228
3065
3066         Reviewed by Simon Fraser.
3067
3068         * DumpRenderTree/mac/DumpRenderTree.mm:
3069         (enableExperimentalFeatures):
3070         (resetWebPreferencesToConsistentValues):
3071         (setWebPreferencesForTestOptions):
3072         (resetWebViewToConsistentStateBeforeTesting):
3073         * DumpRenderTree/win/DumpRenderTree.cpp:
3074         (enableExperimentalFeatures):
3075         (resetWebPreferencesToConsistentValues):
3076         More closely match WebKitTestRunner initialization of preferences
3077         for experimental features.
3078
3079 2017-01-20  Alex Christensen  <achristensen@webkit.org>
3080
3081         Build Fix for Windows DumpRenderTree after r210976
3082         https://bugs.webkit.org/show_bug.cgi?id=167115
3083
3084         * DumpRenderTree/win/DumpRenderTree.cpp:
3085         (resetWebPreferencesToConsistentValues):
3086
3087 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3088
3089         Remove outdated ENABLE(CSP_NEXT) build flag
3090         https://bugs.webkit.org/show_bug.cgi?id=167252
3091
3092         Reviewed by Brent Fulgham.
3093
3094         * Scripts/webkitperl/FeatureList.pm:
3095         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3096
3097 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3098
3099         Build Fix for Windows DumpRenderTree after r210976
3100
3101         * DumpRenderTree/win/DumpRenderTree.cpp:
3102         (resetWebPreferencesToConsistentValues):
3103
3104 2017-01-20  Antoine Quint  <graouts@apple.com>
3105
3106         Web Animations should be off by default and enabled as an experimental feature
3107         https://bugs.webkit.org/show_bug.cgi?id=167115
3108         <rdar://problem/30048963>
3109
3110         Reviewed by Joseph Pecoraro.
3111
3112         Turn Web Animations on in DRT.
3113
3114         * DumpRenderTree/mac/DumpRenderTree.mm:
3115         (resetWebPreferencesToConsistentValues):
3116         * DumpRenderTree/win/DumpRenderTree.cpp:
3117         (resetWebPreferencesToConsistentValues):
3118
3119 2017-01-20  Youenn Fablet  <youenn@apple.com>
3120
3121         [WebRTC] Add libwebrtc build infrastructure
3122         https://bugs.webkit.org/show_bug.cgi?id=167207
3123
3124         Reviewed by Alex Christensen.
3125
3126         Adding a script doing the libwebrtc project json to CMake file conversion.
3127
3128         * Scripts/generate-libwebrtc-cmake: Added.
3129         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
3130         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
3131
3132 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
3133
3134         Mini Browser: Show tooltip for Experimental Features
3135         https://bugs.webkit.org/show_bug.cgi?id=167225
3136
3137         Reviewed by Alex Christensen.
3138
3139         * MiniBrowser/mac/SettingsController.m:
3140         (-[SettingsController _populateMenu]):
3141         Include the full details string as a tooltip.
3142
3143 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
3144
3145         [Win] Test output results should not be written twice.
3146         https://bugs.webkit.org/show_bug.cgi?id=167197
3147
3148         Reviewed by Brent Fulgham.
3149
3150         Prevent test output from being written twice by returning early from
3151         the dump() function, if it already has been called.
3152         This patch also adds a missing newline to a test output line. 
3153         
3154         * DumpRenderTree/win/DumpRenderTree.cpp:
3155         (dump):
3156
3157 2017-01-20  Antoine Quint  <graouts@apple.com>
3158
3159         [Modern Media Controls] Turn modern media controls on by default
3160         https://bugs.webkit.org/show_bug.cgi?id=165668
3161
3162         Reviewed by Dean Jackson.
3163
3164         Enabled modern media controls by default in test runners.
3165
3166         * DumpRenderTree/TestOptions.h:
3167         * WebKitTestRunner/TestOptions.h:
3168
3169 2017-01-19  Chris Dumez  <cdumez@apple.com>
3170
3171         iterable<> should be enabled on WK1
3172         https://bugs.webkit.org/show_bug.cgi?id=167221
3173         <rdar://problem/30108531>
3174
3175         Reviewed by Youenn Fablet.
3176
3177         * DumpRenderTree/mac/DumpRenderTree.mm:
3178         (resetWebPreferencesToConsistentValues):
3179         * DumpRenderTree/win/DumpRenderTree.cpp:
3180         (resetWebPreferencesToConsistentValues):
3181         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3182         (WTR::InjectedBundle::beginTesting):
3183         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3184         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
3185         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3186
3187 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
3188
3189         Ensure status server logs go to log file
3190         https://bugs.webkit.org/show_bug.cgi?id=167210
3191
3192         Reviewed by Alexey Proskuryakov.
3193
3194         * Scripts/webkitpy/common/net/statusserver.py:
3195         (StatusServer.next_work_item): Change log level from debug to info in
3196         order to facilitate deubgging issues.
3197         (StatusServer.update_work_items): Same.
3198
3199 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
3200
3201         Additional selection tests and interpolation fix
3202         https://bugs.webkit.org/show_bug.cgi?id=167171
3203
3204         Reviewed by Simon Fraser.
3205
3206         We weren't adding the final event when interpolating event streams.
3207
3208         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3209         (-[HIDEventGenerator interpolatedEvents:]):
3210
3211 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
3212
3213         [Cocoa] Variation fonts are erroneously disabled on iOS
3214         https://bugs.webkit.org/show_bug.cgi?id=167172
3215
3216         Reviewed by Simon Fraser.
3217
3218         OpenSource builders don't seem to understand sdk=embedded*.
3219
3220         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3221
3222 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3223
3224         Unreviewed. Fix GTK+ unit tests failing since r210531.
3225
3226         Avoid using paths to files that don't actually exist.
3227
3228         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
3229         (testWebKitConsoleMessageNetworkError):
3230         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3231         (testContextMenuDefaultMenu):
3232         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
3233         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
3234         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
3235
3236 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3237
3238         [GTK] Provide API to set proxy settings
3239         https://bugs.webkit.org/show_bug.cgi?id=128674
3240
3241         Reviewed by Michael Catanzaro.
3242
3243         Add tests for new proxy settings API.
3244
3245         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3246         (serverCallback):
3247         (ProxyTest::ProxyTest):
3248         (ProxyTest::~ProxyTest):
3249         (ProxyTest::loadURIAndGetMainResourceData):
3250         (ProxyTest::proxyServerPortAsString):
3251         (testWebContextProxySettings):
3252         (beforeAll):
3253
3254 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3255
3256         Add back my old email address so old commits will still match it.
3257
3258         * Scripts/webkitpy/common/config/contributors.json:
3259
3260 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
3261
3262         Remove my old email address from contributors.json and watchlist.
3263
3264         * Scripts/validate-committer-lists:
3265         (CommitterListFromGit): Change the mapping to the correct email.
3266         * Scripts/webkitpy/common/config/contributors.json:
3267         * Scripts/webkitpy/common/config/watchlist:
3268
3269 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
3270
3271         Unreviewed, rolling out r210848.
3272
3273         This change introduced media-related LayoutTest failures and
3274         crashes on macOS.
3275
3276         Reverted changeset:
3277
3278         "[Modern Media Controls] Turn modern media controls on by
3279         default"
3280         https://bugs.webkit.org/show_bug.cgi?id=165668
3281         http://trac.webkit.org/changeset/210848
3282
3283 2017-01-18  Andreas Kling  <akling@apple.com>
3284
3285         Document::securityOrigin() should return a reference.
3286         <https://webkit.org/b/167124>
3287
3288         Reviewed by Sam Weinig.
3289
3290         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3291         (TestWebKitAPI::TEST_F):
3292
3293 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
3294
3295         [Win] Clipboard tests are flaky.
3296         https://bugs.webkit.org/show_bug.cgi?id=167088
3297
3298         Reviewed by Brent Fulgham.
3299
3300         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
3301         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
3302
3303         * DumpRenderTree/win/DumpRenderTree.cpp:
3304         (main):
3305
3306 2017-01-18  Antoine Quint  <graouts@apple.com>
3307
3308         [Modern Media Controls] Turn modern media controls on by default
3309         https://bugs.webkit.org/show_bug.cgi?id=165668
3310
3311         Reviewed by Dean Jackson.
3312
3313         Enabled modern media controls by default in test runners. 
3314
3315         * DumpRenderTree/TestOptions.h:
3316         * WebKitTestRunner/TestOptions.h:
3317
3318 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
3319
3320         Unreviewed, rolling out r210834
3321         https://bugs.webkit.org/show_bug.cgi?id=165668
3322
3323         It introduced dozens of test timeouts.
3324
3325         Reverted changeset:
3326         "[Modern Media Controls] Turn modern media controls on by default"
3327         https://bugs.webkit.org/show_bug.cgi?id=165668
3328         http://trac.webkit.org/changeset/210834
3329
3330 2017-01-17  Antoine Quint  <graouts@apple.com>
3331
3332         [Modern Media Controls] Turn modern media controls on by default
3333         https://bugs.webkit.org/show_bug.cgi?id=165668
3334
3335         Reviewed by Dean Jackson.
3336
3337         Enabled modern media controls by default in test runners. 
3338
3339         * DumpRenderTree/TestOptions.h:
3340         * WebKitTestRunner/TestOptions.h:
3341
3342 2017-01-17  Chris Dumez  <cdumez@apple.com>
3343
3344         Document title changed twice when setting document.title
3345         https://bugs.webkit.org/show_bug.cgi?id=167065
3346
3347         Reviewed by Darin Adler.
3348
3349         Add WebKit2GTK API test that was written by Michael Catanzaro.
3350
3351         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3352         (testWebViewTitleChange):
3353         (beforeAll):
3354
3355 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
3356
3357         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
3358         https://bugs.webkit.org/show_bug.cgi?id=116551
3359         <rdar://problem/13949830>
3360
3361         Reviewed by Alex Christensen.
3362
3363         * Scripts/webkitperl/FeatureList.pm:
3364         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
3365         that is part of the existing WEB_TIMING feature.
3366
3367         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3368
3369 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
3370
3371         'webkit-patch post' no longer works with moved/copied files
3372         https://bugs.webkit.org/show_bug.cgi?id=166914
3373         <rdar://problem/29979707>
3374
3375         Reviewed by Daniel Bates.
3376
3377         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
3378         file outputs only the "Index:" line with an empty body.  This workaround
3379         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
3380         public email list tracking this bug is below.
3381         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
3382         
3383
3384         * Scripts/svn-create-patch:
3385         (generateDiff): Ignore an "Index:" line with an empty body.
3386
3387 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
3388
3389         Remove the REQUEST_ANIMATION_FRAME flag
3390         https://bugs.webkit.org/show_bug.cgi?id=156980
3391         <rdar://problem/25906849>
3392
3393         Reviewed by Simon Fraser.
3394
3395         * Scripts/webkitperl/FeatureList.pm:
3396         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3397
3398 2017-01-15  Sam Weinig  <sam@webkit.org>
3399
3400         Add the ability to use numbers in makeString()
3401         https://bugs.webkit.org/show_bug.cgi?id=167087
3402
3403         Reviewed by Darin Adler.
3404
3405         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3406         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
3407         Add tests for StringConcatenate, focusing on new numeric additions.
3408
3409 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
3410
3411         Unreviewed, remove stale comment.
3412
3413         This test was fixed by r163173.
3414
3415         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3416
3417 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
3418
3419         Annotate large string tests with largeHeap
3420         https://bugs.webkit.org/show_bug.cgi?id=167054
3421
3422         Reviewed by Filip Pizlo.
3423
3424         * Scripts/run-javascriptcore-tests:
3425         * Scripts/run-jsc-stress-tests:
3426
3427 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
3428
3429         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
3430         https://bugs.webkit.org/show_bug.cgi?id=167043
3431
3432         Reviewed by Darin Adler.
3433
3434         * Scripts/webkitperl/FeatureList.pm:
3435
3436 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
3437
3438         Remove ENABLE(DETAILS_ELEMENT) guards
3439         https://bugs.webkit.org/show_bug.cgi?id=167042
3440
3441         Reviewed by Alex Christensen.
3442
3443         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3444
3445 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
3446
3447         26 MotionMark performance tests failing
3448         https://bugs.webkit.org/show_bug.cgi?id=166854
3449
3450         Reviewed by Ryosuke Niwa.
3451
3452         Unrelated change. This is the last place that we need to rename Animometer
3453         to MotionMark.
3454
3455         * Scripts/webkitpy/common/config/watchlist:
3456
3457 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
3458
3459         run-jsc-benchmarks' echo should have -e option
3460         https://bugs.webkit.org/show_bug.cgi?id=167009
3461
3462         Reviewed by Sam Weinig.
3463
3464         echo requires `-e` option to use escape sequence.
3465         Without it, in some environment (in my Fedora 25), the escape sequence is not
3466         recognized and just dumped as `\c` etc.
3467
3468         * Scripts/run-jsc-benchmarks:
3469
3470 2017-01-12  Chris Dumez  <cdumez@apple.com>
3471
3472         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3473         https://bugs.webkit.org/show_bug.cgi?id=166995
3474
3475         Reviewed by Jer Noble.
3476
3477         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
3478         as some people are having trouble building without it.
3479
3480         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3481
3482 2017-01-12  Sam Weinig  <sam@webkit.org>
3483
3484         Add the ability to filter the set of bindings tests you want to run
3485         https://bugs.webkit.org/show_bug.cgi?id=166977
3486
3487         Reviewed by Tim Horton.
3488
3489         Allows doing things like:
3490             run-bindings-tests TestObj* TestCEReactions*
3491         
3492         to run only those tests that match the patterns.
3493
3494         * Scripts/run-bindings-tests:
3495         (main):
3496         Switch to using optparse and pass the remaining args as the filters.
3497
3498         * Scripts/webkitpy/bindings/main.py:
3499         (BindingsTests.__init__):
3500         Store the pattens.
3501
3502         (BindingsTests.test_matches_patterns):
3503         Add helper predicate to determine if a test should be run. When no
3504         patterns are present, all tests should run.
3505
3506         (BindingsTests.run_tests):
3507         Filter tests using the passed in patterns.
3508
3509 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
3510
3511         Followup fix after r210503.
3512         https://bugs.webkit.org/show_bug.cgi?id=166887
3513
3514         Reviewed by Alex Christensen.
3515
3516         After <http://trac.webkit.org/changeset/210503>, test results are written to a
3517         duplicated file handle on Windows. This patch fixes the remaining call sites.
3518
3519         * DumpRenderTree/PixelDumpSupport.cpp:
3520         * DumpRenderTree/TestRunner.cpp:
3521         (TestRunner::waitToDumpWatchdogTimerFired):
3522         * DumpRenderTree/TestRunner.h:
3523         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3524         * DumpRenderTree/win/DumpRenderTree.cpp:
3525         * DumpRenderTree/win/DumpRenderTreeWin.h:
3526         * DumpRenderTree/win/TestRunnerWin.cpp:
3527         (TestRunner::setSpellCheckerLoggingEnabled):
3528
3529 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
3530
3531         Add committer status for Megan
3532         https://bugs.webkit.org/show_bug.cgi?id=166954
3533
3534         Reviewed by Tim Horton.
3535
3536         Add committer status for Megan Gardner
3537
3538         * Scripts/webkitpy/common/config/contributors.json:
3539
3540 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3541
3542         Unreviewed test fix after r210599.
3543
3544         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
3545         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
3546
3547 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3548
3549         Unreviewed build fix after r210599.
3550
3551         Add missing files.
3552
3553         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3554         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3555
3556 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
3557
3558         File scheme should not allow access of a resource on a different volume.
3559         https://bugs.webkit.org/show_bug.cgi?id=158552
3560         <rdar://problem/15307582>
3561
3562         Reviewed by Alex Christensen.
3563
3564         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3565         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3566         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3567
3568 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
3569
3570         Unreviewed, rolling out r210571.
3571
3572         This change broke the 32-bit macOS build and caused LayoutTest
3573         failures.
3574
3575         Reverted changeset:
3576
3577         "File scheme should not allow access of a resource on a
3578         different volume."
3579         https://bugs.webkit.org/show_bug.cgi?id=158552
3580         http://trac.webkit.org/changeset/210571
3581
3582 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3583
3584         [GTK] install-dependencies script misses gdb
3585         https://bugs.webkit.org/show_bug.cgi?id=166917
3586
3587         Reviewed by Michael Catanzaro.
3588
3589         gdb is needed for generating the crash logs.
3590
3591         * gtk/install-dependencies:
3592
3593 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3594
3595         [GTK] No way for applications to set notification permissions without waiting for permission request
3596         https://bugs.webkit.org/show_bug.cgi?id=163366
3597
3598         Reviewed by Carlos Garcia Campos.
3599
3600         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3601         (testWebViewNotification):
3602         (setInitialNotificationPermissionsAllowedCallback):
3603         (setInitialNotificationPermissionsDisallowedCallback):
3604         (testWebViewNotificationInitialPermissionAllowed):
3605         (testWebViewNotificationInitialPermissionDisallowed):
3606         (beforeAll):
3607         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3608         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3609         (WebViewTest::WebViewTest):
3610         (WebViewTest::initializeWebView):
3611         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
3612
3613 2017-01-10  Tim Horton  <timothy_horton@apple.com>
3614
3615         MobileMiniBrowser tests don't work by default
3616         https://bugs.webkit.org/show_bug.cgi?id=166910
3617
3618         Reviewed by Alex Christensen.
3619
3620         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
3621         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
3622
3623 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
3624
3625         File scheme should not allow access of a resource on a different volume.
3626         https://bugs.webkit.org/show_bug.cgi?id=158552
3627         <rdar://problem/15307582>
3628
3629         Reviewed by Alex Christensen.
3630
3631         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3632         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3633         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3634
3635 2017-01-10  Mark Lam  <mark.lam@apple.com>
3636
3637         Reverting run-jsc-stress-tests' $buildType to use string values.
3638         https://bugs.webkit.org/show_bug.cgi?id=166912
3639
3640         Rubber stamped by Filip Pizlo.
3641
3642         This is so that we can test for it in the tests e.g.
3643         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
3644
3645         * Scripts/run-jsc-stress-tests:
3646
3647 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
3648
3649         Temporarily add back the file removed in r210463 to unbreak internal bots.
3650
3651         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
3652
3653 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
3654
3655         svn-apply failed to apply a patch (deleting file with svn property)
3656         https://bugs.webkit.org/show_bug.cgi?id=165953
3657
3658         Reviewed by Daniel Bates.
3659
3660         * Scripts/VCSUtils.pm:
3661         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
3662         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
3663
3664 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3665
3666         Update flakiness dashboard configuration.
3667         https://bugs.webkit.org/show_bug.cgi?id=166869
3668
3669         Reviewed by Alexey Proskuryakov.
3670
3671         * TestResultServer/static-dashboards/builders.jsonp:
3672         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3673
3674 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3675
3676         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
3677         https://bugs.webkit.org/show_bug.cgi?id=165232
3678
3679         Unreviewed follow-up patch after r210539 and r210523.
3680
3681         Instead of using that environment variable, the argument
3682         --display-server=xorg should be passed now.
3683
3684         The GTK+ performance bot was the only bot using this, and is
3685         already passing --display-server=xorg after r210539.
3686
3687         * Scripts/webkitpy/port/gtk.py:
3688         (GtkPort._driver_class):
3689
3690 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3691
3692         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
3693         https://bugs.webkit.org/show_bug.cgi?id=166872
3694
3695         Reviewed by Michael Catanzaro.
3696
3697         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
3698         Define the required "--display-server=driver" in the bot additionalArguments config entry.
3699         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
3700         The step RunWebKitTests already has support for it.
3701
3702         * BuildSlaveSupport/build.webkit.org-config/config.json:
3703         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3704         (RunGtkAPITests.start):
3705         (RunAndUploadPerfTests.start):
3706         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3707
3708 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
3709
3710         Unreviewed, rolling out r210531.
3711
3712         This change broke the 32-bit macOS build and caused LayoutTest
3713         failures.
3714
3715         Reverted changeset:
3716
3717         "File scheme should not allow access of a resource on a
3718         different volume."
3719         https://bugs.webkit.org/show_bug.cgi?id=158552
3720         http://trac.webkit.org/changeset/210531
3721
3722 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
3723
3724         File scheme should not allow access of a resource on a different volume.
3725         https://bugs.webkit.org/show_bug.cgi?id=158552
3726         <rdar://problem/15307582>
3727
3728         Reviewed by Alex Christensen.
3729
3730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3731         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
3732         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
3733
3734 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3735
3736         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
3737         https://bugs.webkit.org/show_bug.cgi?id=165232
3738
3739         Reviewed by Michael Catanzaro.
3740
3741         Add a new WaylandDriver to run the tests in the user current wayland session.
3742
3743         Also merge all the configuration options for selecting the display server inside one
3744         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
3745
3746         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
3747
3748         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
3749         (TestRunner._create_driver):
3750         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3751         (parse_args):
3752         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3753         (PerfTestsRunner._parse_args):
3754         * Scripts/webkitpy/port/gtk.py:
3755         (GtkPort.__init__):
3756         (GtkPort._driver_class):
3757         (GtkPort._search_paths):
3758         * Scripts/webkitpy/port/waylanddriver.py: Added.
3759         (WaylandDriver):
3760         (WaylandDriver.check_driver):
3761         (WaylandDriver._setup_environ_for_test):
3762         (WaylandDriver._start):
3763
3764 2017-01-09  Andy Estes  <aestes@apple.com>
3765
3766         [QuickLook] Add a layout test for webkit.org/b/135651
3767         https://bugs.webkit.org/show_bug.cgi?id=166855
3768
3769         Reviewed by Andreas Kling.
3770
3771         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3772         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
3773         errors with code WebKitErrorCannotShowURL.
3774         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3775         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
3776         not specific to WebKit2 error codes.
3777
3778 2017-01-09  Antoine Quint  <graouts@apple.com>
3779
3780         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
3781         https://bugs.webkit.org/show_bug.cgi?id=166837
3782
3783         Reviewed by Alex Christensen.
3784
3785         We now correctly handle the --absolutePath argument in DumpRenderTree and use
3786         the provided value when trying to determine the path to the test file. Failing
3787         that, we use the computed URL or the raw path provided to cover all cases.
3788         
3789         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
3790         by applying this patch and seeing the number test failures dramatically reduced
3791         with WK1 due to the option to turn modern media controls off for older media controls
3792         tests.
3793
3794         * DumpRenderTree/DumpRenderTree.h:
3795         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3796         (parseInputLine):
3797         * DumpRenderTree/TestOptions.h:
3798         * DumpRenderTree/TestOptions.mm:
3799         (TestOptions::TestOptions):
3800         * DumpRenderTree/mac/DumpRenderTree.mm:
3801         (runTest):
3802
3803 2017-01-09  Milan Crha  <mcrha@redhat.com>
3804
3805         prepare-ChangeLog: Correct help string for --style option
3806         https://bugs.webkit.org/show_bug.cgi?id=166725
3807
3808         Reviewed by Alexey Proskuryakov.
3809
3810         * Scripts/prepare-ChangeLog:
3811         (main):
3812
3813 2017-01-09  Lucas Forschler  <lforschler@apple.com>
3814
3815         https://bugs.webkit.org/show_bug.cgi?id=166839
3816         Add php7 support for macOS.
3817         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
3818
3819         Reviewed by Alexey Proskuryakov.
3820
3821         * Scripts/webkitpy/port/base.py:
3822         (Port._is_darwin_php_version_7):
3823         (Port._debian_php_version):
3824         (Port):
3825         (Port._darwin_php_version):
3826         (Port._apache_config_file_name_for_platform):
3827
3828 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
3829
3830         [GTK] Should support key and code properties on keyboard events
3831         https://bugs.webkit.org/show_bug.cgi?id=166759
3832
3833         Reviewed by Carlos Garcia Campos.
3834
3835         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3836         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
3837         on tests.
3838
3839 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
3840
3841         [Win] Some tests are flaky because certain DLLs are writing to stdout.
3842         https://bugs.webkit.org/show_bug.cgi?id=166760
3843
3844         Reviewed by Darin Adler.
3845
3846         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
3847         We can work around that by duplicating and redirecting stdout.
3848
3849         * DumpRenderTree/PixelDumpSupport.cpp:
3850         (dumpWebViewAsPixelsAndCompareWithExpected):
3851         (printPNG):
3852         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3853         (logEventProc):
3854         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
3855         (DRTDesktopNotificationPresenter::showDesktopNotification):
3856         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
3857         (DRTDesktopNotificationPresenter::requestNotificationPermission):
3858         * DumpRenderTree/win/DumpRenderTree.cpp:
3859         (dumpFrameScrollPosition):
3860         (dumpHistoryItem):
3861         (dumpBackForwardList):
3862         (dump):
3863         (runTest):
3864         (main):
3865         * DumpRenderTree/win/DumpRenderTreeWin.h:
3866         * DumpRenderTree/win/EditingDelegate.cpp:
3867         (EditingDelegate::shouldBeginEditingInDOMRange):
3868         (EditingDelegate::shouldEndEditingInDOMRange):
3869         (EditingDelegate::shouldInsertNode):
3870         (EditingDelegate::shouldInsertText):
3871         (EditingDelegate::shouldDeleteDOMRange):
3872         (EditingDelegate::shouldChangeSelectedDOMRange):
3873         (EditingDelegate::shouldApplyStyle):
3874         (EditingDelegate::shouldChangeTypingStyle):
3875         (EditingDelegate::doPlatformCommand):
3876         (EditingDelegate::webViewDidBeginEditing):
3877         (EditingDelegate::webViewDidChange):
3878         (EditingDelegate::webViewDidEndEditing):
3879         (EditingDelegate::webViewDidChangeTypingStyle):
3880         (EditingDelegate::webViewDidChangeSelection):
3881         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3882         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
3883         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
3884         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
3885         (FrameLoadDelegate::didFailProvisionalLoadWithError):
3886         (FrameLoadDelegate::didCommitLoadForFrame):
3887         (FrameLoadDelegate::didReceiveTitle):
3888         (FrameLoadDelegate::didFinishLoadForFrame):
3889         (FrameLoadDelegate::didFailLoadWithError):
3890         (FrameLoadDelegate::willPerformClientRedirectToURL):
3891         (FrameLoadDelegate::didCancelClientRedirectForFrame):
3892         (FrameLoadDelegate::windowScriptObjectAvailable):
3893         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
3894         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
3895         (FrameLoadDelegate::didDisplayInsecureContent):
3896         (FrameLoadDelegate::didRunInsecureContent):
3897         (FrameLoadDelegate::webViewProgressFinishedNotification):
3898         * DumpRenderTree/win/HistoryDelegate.cpp:
3899         (HistoryDelegate::didNavigateWithNavigationData):
3900         (HistoryDelegate::didPerformClientRedirectFromURL):
3901         (HistoryDelegate::didPerformServerRedirectFromURL):
3902         (HistoryDelegate::updateHistoryTitle):
3903         (HistoryDelegate::populateVisitedLinksForWebView):
3904         * DumpRenderTree/win/PolicyDelegate.cpp:
3905         (PolicyDelegate::decidePolicyForNavigationAction):
3906         (PolicyDelegate::unableToImplementPolicyWithError):
3907         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3908         (ResourceLoadDelegate::willSendRequest):
3909         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
3910         (ResourceLoadDelegate::didReceiveResponse):
3911         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
3912         (ResourceLoadDelegate::didFailLoadingWithError):
3913         * DumpRenderTree/win/TestRunnerWin.cpp:
3914         (TestRunner::addDisallowedURL):
3915         (TestRunner::originsWithApplicationCache):
3916         (TestRunner::setStorageDatabaseIdleInterval):
3917         (TestRunner::closeIdleLocalStorageDatabases):
3918         (TestRunner::copyDecodedHostName):
3919         (TestRunner::copyEncodedHostName):
3920         (TestRunner::numberOfPendingGeolocationPermissionRequests):
3921         (TestRunner::isGeolocationProviderActive):
3922         (TestRunner::pathToLocalResource):
3923         (TestRunner::setMockDeviceOrientation):
3924         (TestRunner::setMockGeolocationPosition):
3925         (TestRunner::setMockGeolocationPositionUnavailableError):
3926         (TestRunner::setSpatialNavigationEnabled):
3927         (TestRunner::setAutomaticLinkDetectionEnabled):
3928         (TestRunner::isCommandEnabled):
3929         (TestRunner::authenticateSession):
3930         (TestRunner::addChromeInputField):
3931         (TestRunner::removeChromeInputField):
3932         (TestRunner::focusWebView):
3933         (TestRunner::grantWebNotificationPermission):
3934         (TestRunner::denyWebNotificationPermission):
3935         (TestRunner::removeAllWebNotificationPermissions):
3936         (TestRunner::simulateWebNotificationClick):
3937         (TestRunner::imageCountInGeneralPasteboard):
3938         * DumpRenderTree/win/UIDelegate.cpp:
3939         (UIDelegate::runJavaScriptAlertPanelWithMessage):
3940         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
3941         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
3942         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
3943         (UIDelegate::webViewAddMessageToConsole):
3944         (UIDelegate::exceededDatabaseQuota):
3945         (UIDelegate::setStatusText):
3946         (UIDelegate::didPressMissingPluginButton):
3947
3948 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3949
3950         Add a setting to create editable MiniBrowser windows by default
3951         https://bugs.webkit.org/show_bug.cgi?id=166806
3952
3953         Reviewed by Beth Dakin.
3954
3955         * MiniBrowser/mac/AppDelegate.m:
3956         (-[BrowserAppDelegate createBrowserWindowController:]):
3957         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
3958         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
3959         * MiniBrowser/mac/SettingsController.h:
3960         * MiniBrowser/mac/SettingsController.m:
3961         (-[SettingsController _populateMenu]):
3962         (-[SettingsController validateMenuItem:]):
3963         (-[SettingsController toggleCreateEditorByDefault:]):
3964         (-[SettingsController createEditorByDefault]):
3965         Add a setting and update the key equivalents accordingly.
3966         Also make sure to make the right kind of window on launch.
3967
3968 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3969
3970         Fix the 32-bit build.
3971
3972         * MiniBrowser/mac/BrowserWindowController.h:
3973         * MiniBrowser/mac/BrowserWindowController.m:
3974
3975 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3976
3977         Fix the 32-bit build.
3978
3979         * MiniBrowser/mac/BrowserWindowController.m:
3980
3981 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3982
3983         Make it possible to drop HTML files on the MiniBrowser icon
3984         https://bugs.webkit.org/show_bug.cgi?id=166802
3985
3986         Reviewed by Simon Fraser.
3987
3988         * MiniBrowser/mac/AppDelegate.m:
3989         (-[BrowserAppDelegate application:openFile:]):
3990         * MiniBrowser/mac/Info.plist:
3991         If you're using an editable window, the usual trick of dropping on the
3992         window doesn't work anymore (it makes an <attachment> instead).
3993
3994 2017-01-07  Tim Horton  <timothy_horton@apple.com>
3995
3996         MiniBrowser window gets smaller each time it is instantiated
3997         https://bugs.webkit.org/show_bug.cgi?id=166807
3998
3999         Reviewed by Andy Estes.
4000
4001         * MiniBrowser/mac/BrowserWindowController.m:
4002         (-[BrowserWindowController windowDidLoad]):
4003         * MiniBrowser/mac/BrowserWindow.xib:
4004         Turn on full-window content view support with IB, instead of waiting
4005         until after the views have been loaded. This seems to resolve the
4006         longstanding ever-shrinking-window problem.
4007
4008 2017-01-07  Tim Horton  <timothy_horton@apple.com>
4009
4010         Add indent/outdent items to MiniBrowser's new format menu
4011         https://bugs.webkit.org/show_bug.cgi?id=166805
4012
4013         Reviewed by Dan Bernstein.
4014
4015         * MiniBrowser/mac/MainMenu.xib:
4016
4017 2017-01-07  Tim Horton  <timothy_horton@apple.com>
4018
4019         Add a stock Format menu to MiniBrowser
4020         https://bugs.webkit.org/show_bug.cgi?id=166804
4021
4022         Reviewed by Andy Estes.
4023
4024         * MiniBrowser/mac/MainMenu.xib:
4025         Many of the features automatically work with editable web views.
4026         However, this seems to expose a bug where none of the font-related features
4027         (Cmd-B, for example) work until the first time the font panel is shown,
4028         per process, which will need to be investigated separately.
4029
4030 2017-01-07  Tim Horton  <timothy_horton@apple.com>
4031
4032         Remove unused applicationWillTerminate methods from MiniBrowser
4033         https://bugs.webkit.org/show_bug.cgi?id=166803
4034
4035         Reviewed by Andy Estes.
4036
4037         * MiniBrowser/mac/AppDelegate.m:
4038         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
4039         * MiniBrowser/mac/BrowserWindowController.h:
4040         * MiniBrowser/mac/BrowserWindowController.m:
4041         (-[BrowserWindowController applicationTerminating]): Deleted.
4042         * MiniBrowser/mac/WK1BrowserWindowController.m:
4043         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
4044         * MiniBrowser/mac/WK2BrowserWindowController.m:
4045         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
4046
4047 2017-01-07  Tim Horton  <timothy_horton@apple.com>
4048
4049         Add the ability to create empty contentEditable windows in MiniBrowser
4050         https://bugs.webkit.org/show_bug.cgi?id=166801
4051
4052         Reviewed by Wenson Hsieh.
4053
4054         * MiniBrowser/mac/AppDelegate.h:
4055         * MiniBrowser/mac/AppDelegate.m:
4056         (-[BrowserAppDelegate createBrowserWindowController:]):
4057         (-[BrowserAppDelegate newWindow:]):
4058         (-[BrowserAppDelegate newEditorWindow:]):
4059         (-[BrowserAppDelegate openDocument:]):
4060         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
4061         * MiniBrowser/mac/BrowserWindowController.h:
4062         * MiniBrowser/mac/BrowserWindowController.m:
4063         (-[BrowserWindowController loadHTMLString:]):
4064         (-[BrowserWindowController toggleEditable:]):
4065         * MiniBrowser/mac/MainMenu.xib:
4066         * MiniBrowser/mac/WK1BrowserWindowController.m:
4067         (-[WK1BrowserWindowController awakeFromNib]):
4068         (-[WK1BrowserWindowController loadHTMLString:]):
4069         (-[WK1BrowserWindowController validateMenuItem:]):
4070         (-[WK1BrowserWindowController setEditable:]):
4071         (-[WK1BrowserWindowController updateTitle:]):
4072         * MiniBrowser/mac/WK2BrowserWindowController.m:
4073         (-[WK2BrowserWindowController awakeFromNib]):
4074         (-[WK2BrowserWindowController validateMenuItem:]):
4075         (-[WK2BrowserWindowController setEditable:]):
4076         (-[WK2BrowserWindowController updateTitle:]):
4077         (-[WK2BrowserWindowController loadHTMLString:]):
4078         Merge more functionality from WebEditingTester.
4079         Add two menu items for creating empty editable WebKit1/2 windows.
4080         Add a menu item to the Edit menu to toggle editability on any window.
4081
4082 2017-01-07  Tim Horton  <timothy_horton@apple.com>
4083
4084         Implement find-in-page in MiniBrowser
4085         https://bugs.webkit.org/show_bug.cgi?id=166799
4086
4087         Reviewed by Andy Estes.
4088
4089         * MiniBrowser/mac/BrowserWindow.xib:
4090         * MiniBrowser/mac/BrowserWindowController.h:
4091         * MiniBrowser/mac/BrowserWindowController.m:
4092         (-[BrowserWindowController find:]): Deleted.
4093         * MiniBrowser/mac/MainMenu.xib:
4094         * MiniBrowser/mac/WK1BrowserWindowController.m:
4095         (-[WK1BrowserWindowController toggleShrinkToFit:]):
4096         (-[WK1BrowserWindowController find:]): Deleted.
4097         * MiniBrowser/mac/WK2BrowserWindowController.m:
4098         (-[WK2BrowserWindowController awakeFromNib]):
4099         (-[WK2BrowserWindowController dealloc]):
4100         (-[WK2BrowserWindowController validateMenuItem:]):
4101         (-[WK2BrowserWindowController performTextFinderAction:]):
4102         (-[WK2BrowserWindowController findBarView]):
4103         (-[WK2BrowserWindowController setFindBarView:]):
4104         (-[WK2BrowserWindowController isFindBarVisible]):
4105         (-[WK2BrowserWindowController setFindBarVisible:]):
4106         (-[WK2BrowserWindowController contentView]):
4107         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
4108         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
4109         (-[WK2BrowserWindowController find:]): Deleted.
4110         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
4111         protocol. At first glance, it's pretty broken, but vaguely works.
4112
4113 2017-01-07  Tim Horton  <timothy_horton@apple.com>
4114
4115         Share the implementation of MiniBrowser view hiding functionality
4116         https://bugs.webkit.org/show_bug.cgi?id=166800
4117
4118         Reviewed by Andy Estes.
4119
4120         * MiniBrowser/mac/BrowserWindowController.m:
4121         (-[BrowserWindowController showHideWebView:]):
4122         (-[BrowserWindowController removeReinsertWebView:]):
4123         * MiniBrowser/mac/WK1BrowserWindowController.m:
4124         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
4125         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
4126         * MiniBrowser/mac/WK2BrowserWindowController.m:
4127         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
4128         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
4129         Move the implementation of these two things to the shared superclass,
4130         since they don't depend on WebKit-specific things.
4131         Also, there was no reason to retain the (WK)WebView while it was unparented,
4132         as the BrowserWindowController maintains a reference the entire time.
4133
4134 2017-01-06  Andy Estes  <aestes@apple.com>
4135
4136         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
4137         https://bugs.webkit.org/show_bug.cgi?id=166789
4138
4139         Reviewed by Alex Christensen.
4140
4141         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4142         * DumpRenderTree/PlatformMac.cmake:
4143         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
4144         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
4145         * DumpRenderTree/mac/DumpRenderTree.mm:
4146         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
4147         createXMLStringFromWebArchiveData().
4148         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
4149         * WebKitTestRunner/Configurations/Base.xcconfig:
4150         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
4151         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4152         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
4153         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
4154         createXMLStringFromWebArchiveData().
4155         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
4156         * WebKitTestRunner/PlatformMac.cmake:
4157         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4158         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
4159
4160 2017-01-06  Tim Horton  <timothy_horton@apple.com>
4161
4162         Minor cleanups to IndentOutdentCommand and related code
4163         https://bugs.webkit.org/show_bug.cgi?id=166791
4164
4165         Reviewed by Simon Fraser.
4166
4167         * WebEditingTester/EditingOperations.m:
4168         (editingOperations):
4169         Add the outdent operation to WebEditingTester.
4170
4171 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
4172
4173         Create a plan and a patch files for MotionMark and delete the Animometer's ones
4174         https://bugs.webkit.org/show_bug.cgi?id=166785
4175
4176         Reviewed by Ryosuke Niwa.
4177
4178         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
4179         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
4180
4181 2017-01-06  Antoine Quint  <graouts@apple.com>
4182
4183         Support webkit-test-runner key-value pairs in http tests
4184         https://bugs.webkit.org/show_bug.cgi?id=149812
4185
4186         Reviewed by Alex Christensen.
4187
4188         We pass the absolute path for a test through to WKTR so that we can parse
4189         tests that are running as URLs for webkit-test-runner options.
4190
4191         * DumpRenderTree/DumpRenderTreeCommon.cpp:
4192         (parseInputLine):
4193
4194         Explicitly skip the --absolute-path option in DRT or else we'd crash.
4195
4196         * Scripts/webkitpy/port/driver.py:
4197         (Driver._command_from_driver_input):
4198
4199         Pass the absolute path to the file through the CLI.
4200
4201         * WebKitTestRunner/TestController.cpp:
4202         (WTR::updateTestOptionsFromTestHeader):
4203         (WTR::TestController::testOptionsForTest):
4204         (WTR::parseInputLine):
4205         (WTR::TestController::runTest):
4206         * WebKitTestRunner/TestController.h:
4207
4208 2017-01-06  Tim Horton  <timothy_horton@apple.com>
4209
4210         Warning about unconnectable outlets when opening a MiniBrowser window
4211         https://bugs.webkit.org/show_bug.cgi?id=166756
4212
4213         Reviewed by Dan Bernstein.
4214
4215         * MiniBrowser/mac/BrowserWindow.xib:
4216         When launching MiniBrowser, it says:
4217         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
4218             (MBToolbarItem): missing setter or instance variable
4219         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
4220             (NSButtonCell): missing setter or instance variable.
4221
4222         It looks like someone added the connection from the share button
4223         to the BrowserWindowController three times; only one of the connections
4224         is valid. Remove the other two.
4225
4226 2017-01-05  Keith Rollin  <krollin@apple.com>
4227
4228         Add WebCore::URL::protocolHostAndPort
4229         https://bugs.webkit.org/show_bug.cgi?id=166426
4230
4231         Reviewed by Alex Christensen.
4232
4233         Add test for protocolHostAndPort.
4234
4235         * TestWebKitAPI/Tests/WebCore/URL.cpp:
4236         (TestWebKitAPI::TEST_F):
4237
4238 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
4239
4240         [Win] Archive test result is failing.
4241         https://bugs.webkit.org/show_bug.cgi?id=166720
4242
4243         Reviewed by Alex Christensen.
4244
4245         Deleting the layout test result folder is sometimes failing
4246         on Windows. This is not a critical error.
4247
4248         * BuildSlaveSupport/test-result-archive:
4249         (archiveTestResults):
4250
4251 2017-01-04  Tomas Popela  <tpopela@redhat.com>
4252
4253         [GTK] Minibrowser: Add printing support
4254         https://bugs.webkit.org/show_bug.cgi?id=165298
4255
4256         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
4257         an error during the print, it's printed on the console.
4258
4259         Reviewed by Michael Catanzaro.
4260
4261         * MiniBrowser/gtk/BrowserWindow.c:
4262         (webKitPrintOperationFailedCallback):
4263         (printPage):
4264         (browser_window_init):
4265
4266 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
4267
4268         [css-grid] Fix crash clamping grid lines
4269         https://bugs.webkit.org/show_bug.cgi?id=166637
4270
4271         Reviewed by Darin Adler.
4272
4273         Creates new unit test to verify that the maximum tracks limit
4274         is used in GridPosition too.
4275
4276         * TestWebKitAPI/PlatformEfl.cmake:
4277         * TestWebKitAPI/PlatformGTK.cmake:
4278         * TestWebKitAPI/PlatformWin.cmake:
4279         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4280         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
4281         (TestWebKitAPI::TEST):
4282
4283 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
4284
4285         Move editing history scripts to WebCore PrivateHeaders
4286         https://bugs.webkit.org/show_bug.cgi?id=166709
4287         <rdar://problem/29876612>
4288
4289         Reviewed by Dan Bernstein.
4290
4291         Update references to editing script files in WebCore that were moved.
4292
4293         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
4294
4295 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
4296
4297         Unreviewed, build fix after r210313 part 2
4298         https://bugs.webkit.org/show_bug.cgi?id=166676
4299
4300         Add 'U' suffix.
4301
4302         * TestWebKitAPI/Tests/WTF/StringView.cpp:
4303         (TestWebKitAPI::TEST):
4304         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
4305         (TestWebKitAPI::TEST):
4306
4307 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>