7c6c2cc4f2aa7a8969abfa3b345c500b8a28c522
[WebKit-https.git] / Tools / ChangeLog
1 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
2
3         [WinCairo] Unreviewed test correction.
4
5         * Scripts/webkitdirs.pm:
6         (argumentsForConfiguration): Add 'wincairo' option to the set of
7         configuration flags used by run-javascript-core tests, so that it
8         does not attempt to run Apple's release version.
9
10 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
11
12         [WinCairo] Unreviewed test correction.
13
14         * BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set
15          of known build slave types so that test-result-archive won't fail
16          when running tests.
17
18 2011-10-06  Martin Robinson  <mrobinson@igalia.com>
19
20         The GTK+ WebKit2 headers produce a lot of style warnings
21         https://bugs.webkit.org/show_bug.cgi?id=69481
22
23         Reviewed by David Levin.
24
25         Prevent emitting so many style warnings for GTK+ API. We skip header
26         files in the WebKit2 GTK+ API directory and also avoid warnings about
27         identifier names that begin with "webkit_" in files that contain the
28         string "gtk".
29
30         * Scripts/webkitpy/style/checker.py: Do not check header files in
31         Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
32         adding the ability to specify a regular expression in the skip list. Remove
33         a few files from the skipped list that no longer exist.
34         * Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
35         * Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn
36         about identifiers that begin with "webkit_".
37         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.
38
39 2011-10-06  Brent Fulgham  <bfulgham@webkit.org>
40
41         [WinCairo] Correct config.json for WinCairo Test builds.
42         https://bugs.webkit.org/show_bug.cgi?id=69272
43
44         Reviewed by Ryosuke Niwa.
45
46         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove
47          old 'WinCairo Debug (Build)' label and replace with correct
48          'WinCairo Release' label.
49
50 2011-10-06  David Levin  <levin@chromium.org>
51
52         Add a style checker watchlist definition and add myself to it.
53         https://bugs.webkit.org/show_bug.cgi?id=69564
54
55         Reviewed by Daniel Bates.
56
57         * Scripts/webkitpy/common/config/watchlist:
58
59 2011-10-06  Raphael Kubo da Costa  <kubo@profusion.mobi>
60
61         [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.
62         https://bugs.webkit.org/show_bug.cgi?id=69450
63
64         Reviewed by Ryosuke Niwa.
65
66         This should avoid stderr messages when running
67         webarchive/test-link-rel-icon.html.
68
69         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
70         (LayoutTestController::setIconDatabaseEnabled):
71
72 2011-10-06  Alejandro G. Castro  <alex@igalia.com>
73
74         [WK2] [GTK] Add Skipped file for Webkit2 test runner
75         https://bugs.webkit.org/show_bug.cgi?id=69517
76
77         Use the shared WK2 skipped file also in GTK port.
78
79         Reviewed by Martin Robinson.
80
81         * Scripts/old-run-webkit-tests:
82         (readSkippedFiles):
83
84 2011-10-06  Elliot Poger  <epoger@google.com>
85
86         allow new-run-webkit-tests to run on Lion
87         https://bugs.webkit.org/show_bug.cgi?id=69429
88
89         Add fallback lists for chromium-mac-lion, and add chromium-mac-snowleopard
90         directory to fallback lists (even though that directory doesn't exist yet)
91
92         Reviewed by Adam Barth.
93
94         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
95         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
96
97 2011-10-03  Hans Wennborg  <hans@chromium.org>
98
99         IndexedDB: Remove SQLite-LevelDB migration code
100         https://bugs.webkit.org/show_bug.cgi?id=69264
101
102         Reviewed by Tony Chang.
103
104         Remove setOverrideIndexedDBBackingStore. It was used in the layout
105         test for migration.
106
107         * DumpRenderTree/chromium/LayoutTestController.cpp:
108         (LayoutTestController::LayoutTestController):
109         * DumpRenderTree/chromium/LayoutTestController.h:
110
111 2011-10-05  James Robinson  <jamesr@chromium.org>
112
113         [chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
114         https://bugs.webkit.org/show_bug.cgi?id=69498
115
116         Reviewed by Adam Barth.
117
118         * DumpRenderTree/chromium/DumpRenderTree.cpp:
119         (main):
120         * DumpRenderTree/chromium/TestShell.cpp:
121         (TestShell::TestShell):
122         (TestShell::resetWebSettings):
123         * DumpRenderTree/chromium/TestShell.h:
124         (TestShell::setThreadedCompositingEnabled):
125         * DumpRenderTree/chromium/WebPreferences.cpp:
126         (WebPreferences::reset):
127         (WebPreferences::applyTo):
128         * DumpRenderTree/chromium/WebPreferences.h:
129         * Scripts/webkitpy/layout_tests/port/chromium.py:
130         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
131
132 2011-10-05  Erik Arvidsson  <arv@chromium.org>
133
134         [QT] Fix DRT after r96779
135
136         unreviewed.
137
138         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
139         (WebCore::dumpHistoryItem):
140
141 2011-10-05  Erik Arvidsson  <arv@chromium.org>
142
143         window.location.href and others needlessly decodes URI-encoded characters
144         https://bugs.webkit.org/show_bug.cgi?id=30225
145
146         Reviewed by Darin Adler.
147
148         * DumpRenderTree/chromium/TestShell.cpp:
149         (normalizeLayoutTestURLInternal): Remove extra encode.
150
151 2011-10-05  Darin Adler  <darin@apple.com>
152
153         Fix build.
154
155         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
156         (TestWebKitAPI::TEST): Remove underscore prefix from call to
157         WKContextRegisterURLSchemeAsEmptyDocument.
158
159 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
160
161         [WinCairo] Switch to building Release target, and activate tests.
162         https://bugs.webkit.org/show_bug.cgi?id=69272
163
164         Reviewed by Adam Barth.
165
166         * BuildSlaveSupport/build.webkit.org-config/config.json:
167         Change from debug to release target. Switch from "Build" to
168         "BuildAndTest"
169
170 2011-10-05  Simon Fraser  <simon.fraser@apple.com>
171
172         In WebKitTestRunner, text has font smoothing in pixel snapshots
173         https://bugs.webkit.org/show_bug.cgi?id=69396
174
175         Reviewed by Darin Adler.
176         
177         Call the new WKContext method that disables font smoothing in
178         WebKitTestRunner, so that pixel snapshots don't have font smoothing
179         enabled. Remove leading underscore from a WKContext function call.
180
181         * WebKitTestRunner/TestController.cpp:
182         (WTR::TestController::resetStateToConsistentValues):
183
184 2011-10-05  David Levin  <levin@chromium.org>
185
186         Improve the watchlist for threading entries.
187         https://bugs.webkit.org/show_bug.cgi?id=69463
188
189         Reviewed by Adam Barth.
190
191         * Scripts/webkitpy/common/config/watchlist:
192
193 2011-10-05  Adam Roben  <aroben@apple.com>
194
195         Add tests for using RetainPtrs inside HashMap and HashSet
196
197         Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
198         in HashMap/HashSet fails to compile
199
200         Reviewed by John Sullivan.
201
202         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
203         (TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
204         and value type of HashMap.
205
206         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
207         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
208         Added new file.
209
210 2011-10-05  Adam Barth  <abarth@webkit.org>
211
212         Mark as Expected in garden-o-matic is confusing
213         https://bugs.webkit.org/show_bug.cgi?id=69452
214
215         Reviewed by David Levin.
216
217         krit didn't understand the difference between this button and the
218         Rebaseline button because both of them seem to indicate that the new
219         behavior is expected.  This patch renames "Mark as Expected" to "Expect
220         Failure" to make it clear that we're just expecting the test to fail
221         rather than accepting the new results as passing.  We might need to
222         iterate on these names a bit more if folks continue to find them
223         confusing.
224
225         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
226
227 2011-10-05  Adam Barth  <abarth@webkit.org>
228
229         Add watchlist entries for abarth
230         https://bugs.webkit.org/show_bug.cgi?id=69461
231
232         Reviewed by David Levin.
233
234         I might have gone a bit overboard.  We'll see if this is too much spam
235         for me.
236
237         * Scripts/webkitpy/common/config/watchlist:
238
239 2011-10-05  Brent Fulgham  <bfulgham@webkit.org>
240
241         [WinCairo] Teach old-run-webkit-tests about wincairo.
242         https://bugs.webkit.org/show_bug.cgi?id=69280
243
244         Reviewed by Adam Roben.
245
246         * Scripts/old-run-webkit-tests: Handle wincairo case.
247         (buildPlatformResultHierarchy):
248         (readSkippedFiles): Ditto
249         * Scripts/webkitdirs.pm: Deal with wincairo build case.
250         (determineConfiguration):
251
252 2011-10-05  Chang Shu  <cshu@webkit.org>
253
254         [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
255         https://bugs.webkit.org/show_bug.cgi?id=68924
256
257         Added TextInputController files and JS interfaces for the above functions.
258
259         Reviewed by Darin Adler.
260
261         * WebKitTestRunner/DerivedSources.make:
262         * WebKitTestRunner/DerivedSources.pro:
263         * WebKitTestRunner/GNUmakefile.am:
264         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
265         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
266         (WTR::InjectedBundle::beginTesting):
267         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
268         (WTR::InjectedBundle::textInputController):
269         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
270         (WTR::InjectedBundlePage::didClearWindowForFrame):
271         * WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.
272         (WTR::TextInputController::create):
273         (WTR::TextInputController::TextInputController):
274         (WTR::TextInputController::~TextInputController):
275         (WTR::TextInputController::wrapperClass):
276         (WTR::TextInputController::makeWindowObject):
277         (WTR::TextInputController::setMarkedText):
278         (WTR::TextInputController::hasMarkedText):
279         (WTR::TextInputController::unmarkText):
280         (WTR::TextInputController::insertText):
281         * WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
282         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
283         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
284         * WebKitTestRunner/win/InjectedBundle.vcproj:
285
286 2011-10-04  Oliver Hunt  <oliver@apple.com>
287
288         Add rudimentary filtering to write barriers
289         https://bugs.webkit.org/show_bug.cgi?id=69392
290
291         Reviewed by Filip Pizlo.
292
293         When we're recording gc phase times Heap.o picks up
294         some exit time destructors, so we'll just ignore Heap.o
295         in this check.
296
297         * Scripts/check-for-exit-time-destructors:
298
299 2011-10-05  Chang Shu  <cshu@webkit.org>
300
301         [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
302         https://bugs.webkit.org/show_bug.cgi?id=69365
303
304         Reviewed by Darin Adler.
305
306         Added js API in WTR LayoutTestController.
307
308         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
309         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
310         (WTR::LayoutTestController::dumpConfigurationForViewport):
311         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
312
313 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
314
315         [EFL] ImageDiff: Do not clear the image before it is processed and compared
316         https://bugs.webkit.org/show_bug.cgi?id=69378
317
318         Reviewed by Antonio Gomes.
319
320         Commit 61836 to Evas added a few cleanup calls to some
321         evas_object_image functions which effectively made ImageDiff consider
322         all images to be equal.
323
324         It turns out that now evas_object_image_colorspace_set clears any
325         data set, so the call to evas_object_image_data_set was not having any
326         effect.
327
328         * DumpRenderTree/efl/ImageDiff.cpp:
329         (readImageFromStdin): Call evas_object_image_data_set after
330         evas_object_image_colorspace_set.
331
332 2011-10-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
333
334         [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
335         https://bugs.webkit.org/show_bug.cgi?id=68449
336
337         Reviewed by Antonio Gomes.
338
339         evas_render() must be called to close up temporary files and unmap unused
340         resources. evas_object_image_data_set() must be called after an
341         evas_object_image_data_get() to balance an internal reference count.
342
343         * DumpRenderTree/efl/ImageDiff.cpp:
344         (differenceImageFromDifferenceBuffer):
345         (calculateDifference):
346         (printImage):
347         (printImageDifferences):
348
349 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
350
351         [Qt][WK2] Unreviewed build fix.
352
353         Don't use WebCore directly in WTR.
354
355         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
356         (WTR::PlatformWebView::addChromeInputField):
357         (WTR::PlatformWebView::removeChromeInputField):
358         (WTR::PlatformWebView::makeWebViewFirstResponder):
359
360 2011-10-05  David Levin  <levin@chromium.org>
361
362         watchlist: Add more rules for chromium public api and sort the file.
363         https://bugs.webkit.org/show_bug.cgi?id=69323
364
365         Reviewed by Adam Barth.
366
367         * Scripts/webkitpy/common/config/watchlist:
368
369 2011-10-05  David Levin  <levin@chromium.org>
370
371         watchlist: Don't add the same message to a bug more than once.
372         https://bugs.webkit.org/show_bug.cgi?id=69303
373
374         Reviewed by Adam Barth.
375
376         * Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
377         if a message is in the comments already.
378         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
379         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
380         Pick a bug supplied by the mock. Change the test due to different output
381         from the mock watch list tool.
382         * Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
383         another email so it will be filtered out, fix bugs to have the cc and comment fields,
384         and fix fetch_bug to handle bug_id's which are text (because that took me way too long
385         to debug).
386         * Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
387         and/or cc's that are already in the bug.
388         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
389         and remove a comment that is filtered out.
390
391 2011-10-05  Balazs Kelemen  <kbalazs@webkit.org>
392
393         [Qt][WK2] Unreviewed build fix after r96643.
394
395         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
396         (WTR::PlatformWebView::addChromeInputField):
397         (WTR::PlatformWebView::removeChromeInputField):
398         (WTR::PlatformWebView::makeWebViewFirstResponder):
399
400 2011-10-04  Kent Tamura  <tkent@chromium.org>
401
402         Introduce feature flags for incomplete input types
403         https://bugs.webkit.org/show_bug.cgi?id=68971
404
405         Reviewed by Hajime Morita.
406
407         * Scripts/build-webkit:
408         Add --input-type-{date,datetime,datetimelocal,month,time,week} flags.
409         They are disabled by default.
410
411 2011-10-04  Adam Barth  <abarth@webkit.org>
412
413         garden-o-matic doesn't launch it's UI on Lion
414         https://bugs.webkit.org/show_bug.cgi?id=69349
415
416         Reviewed by Darin Adler.
417
418         It turns out that Lion is a bit more picky about file URLs.  This patch
419         switches us from using a path to using an actual file URL, silencing
420         the warning and making the tool actually launch on Lion.
421
422         * Scripts/webkitpy/tool/servers/gardeningserver.py:
423
424 2011-10-04  Daniel Bates  <dbates@rim.com>
425
426         Fix Perl undefined variable warning when using run-safari after
427         <http://trac.webkit.org/changeset/96448> (https://bugs.webkit.org/show_bug.cgi?id=68662)
428
429         Rubber-stamped by Alexey Proskuryakov.
430
431         * Scripts/webkitdirs.pm:
432         (runMacWebKitApp): Check that the optional function argument $useOpenCommand
433         is defined before using it in a comparison operation.
434
435 2011-10-04  Scott Graham  <scottmg@chromium.org>
436
437         Add GAMEPAD feature flag
438         https://bugs.webkit.org/show_bug.cgi?id=66859
439
440         Reviewed by Darin Fisher.
441
442         * Scripts/build-webkit:
443
444 2011-10-04  Jon Lee  <jonlee@apple.com>
445
446         REGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from chrome to webview
447         https://bugs.webkit.org/show_bug.cgi?id=68412
448         <rdar://problem/9988252>
449
450         Reviewed by Darin Adler.
451
452         In order to create a test for the bug, I had to update DRT and WKTR to create some
453         widget that allows first responder status to move away from the main web view.
454
455         Three methods were added to layoutTestController: addChromeInputField,
456         removeChromeInputField, and focusWebView. addChromeInputField adds a text field
457         that is a sibling to the web view, and sets up the key event loop between the two.
458         removeChromeInputField removes that field. focusWebView moves first responder
459         status to the web view.
460
461         The test makes the call via layoutTestController and passes a callback that it
462         assumes will be executed once the task is completed. In DRT the callback is called
463         synchronously. In WKTR this is handled with message passing between the two
464         processes.
465
466         * DumpRenderTree/LayoutTestController.cpp:
467         (addChromeInputFieldCallback):
468         (removeChromeInputFieldCallback):
469         (focusWebViewCallback):
470         (LayoutTestController::staticFunctions):
471         * DumpRenderTree/LayoutTestController.h:
472         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
473         (LayoutTestController::addChromeInputField):
474         (LayoutTestController::removeChromeInputField):
475         (LayoutTestController::focusWebView):
476         * DumpRenderTree/mac/DumpRenderTree.mm:
477         (resetWebViewToConsistentStateBeforeTesting): When resetting for the next test,
478         make sure to remove the chrome input field.
479         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
480         (LayoutTestController::addChromeInputField):
481         (LayoutTestController::removeChromeInputField):
482         (LayoutTestController::focusWebView):
483         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
484         (LayoutTestController::addChromeInputField):
485         (LayoutTestController::removeChromeInputField):
486         (LayoutTestController::focusWebView):
487         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
488         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
489         (WTR::InjectedBundle::didReceiveMessage):
490         (WTR::InjectedBundle::postAddChromeInputField):
491         (WTR::InjectedBundle::postRemoveChromeInputField):
492         (WTR::InjectedBundle::postFocusWebView):
493         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
494         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
495         (WTR::callbackMap): Create a hash map that keeps track of the callbacks provided
496         through JS.
497         (WTR::cacheLayoutTestControllerCallback):
498         (WTR::callLayoutTestControllerCallback):
499         (WTR::LayoutTestController::addChromeInputField):
500         (WTR::LayoutTestController::removeChromeInputField):
501         (WTR::LayoutTestController::focusWebView):
502         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
503         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
504         (WTR::LayoutTestController::callFocusWebViewCallback):
505         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
506         * WebKitTestRunner/PlatformWebView.h:
507         * WebKitTestRunner/TestController.cpp:
508         (WTR::TestController::resetStateToConsistentValues):
509         * WebKitTestRunner/TestInvocation.cpp:
510         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
511         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
512         (WTR::PlatformWebView::addChromeInputField):
513         (WTR::PlatformWebView::removeChromeInputField):
514         (WTR::PlatformWebView::makeWebViewFirstResponder):
515         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
516         (WTR::PlatformWebView::addChromeInputField):
517         (WTR::PlatformWebView::removeChromeInputField):
518         (WTR::PlatformWebView::makeWebViewFirstResponder):
519         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
520         (WTR::PlatformWebView::addChromeInputField):
521         (WTR::PlatformWebView::removeChromeInputField):
522         (WTR::PlatformWebView::makeWebViewFirstResponder):
523
524         * DumpRenderTree/mac/LayoutTestControllerMac.mm: These functions have nothing to do
525         with the patch-- just cleaning up style.
526         (LayoutTestController::addDisallowedURL):
527         (originsArrayToJS):
528         (LayoutTestController::queueLoad):
529         (LayoutTestController::setMockDeviceOrientation):
530         (LayoutTestController::setIconDatabaseEnabled):
531         (LayoutTestController::setEditingBehavior):
532
533 2011-10-04  Simon Fraser  <simon.fraser@apple.com>
534
535         Move font-fixup code in WebKitTestRunner to a better place
536         https://bugs.webkit.org/show_bug.cgi?id=69356
537
538         Reviewed by Sam Weinig.
539         
540         Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
541         already contains font-related code.
542
543         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
544         (WTR::InjectedBundle::initialize):
545         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
546         (WTR::allowedFontFamilySet):
547         (WTR::drt_NSFontManager_availableFontFamilies):
548         (WTR::drt_NSFontManager_availableFonts):
549         (WTR::swizzleNSFontManagerMethods):
550         (WTR::activateFonts):
551         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
552         (WTR::InjectedBundle::platformInitialize):
553
554 2011-10-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
555
556         [EFL] DRT: Add DumpRenderTree.cpp
557         https://bugs.webkit.org/show_bug.cgi?id=62034
558
559         Reviewed by Antonio Gomes.
560
561         This is the main implementation file for EFL's DumpRenderTree.
562
563         * DumpRenderTree/efl/DumpRenderTree.cpp: Added.
564         (dumpFramesAsText):
565         (dumpFrameScrollPosition):
566         (shouldLogFrameLoadDelegates):
567         (shouldDumpAsText):
568         (sendPixelResultsEOF):
569         (invalidateAnyPreviousWaitToDumpWatchdog):
570         (onEcoreEvasResize):
571         (onCloseWindow):
572         (useLongRunningServerMode):
573         (parseCommandLineOptions):
574         (getFinalTestURL):
575         (getExpectedPixelHash):
576         (createLayoutTestController):
577         (runTest):
578         (runTestingServerLoop):
579         (adjustOutputTypeByMimeType):
580         (dumpFrameContentsAsText):
581         (shouldDumpFrameScrollPosition):
582         (shouldDumpPixelsAndCompareWithExpected):
583         (shouldDumpBackForwardList):
584         (initEfl):
585         (shutdownEfl):
586         (displayWebView):
587         (dump):
588         (initEcoreEvas):
589         (main):
590
591 2011-10-03  Adam Barth  <abarth@webkit.org>
592
593         garden-o-matic should remove builders from the failure grid once they start to pass
594         https://bugs.webkit.org/show_bug.cgi?id=69309
595
596         Unreviewed.  dglazkov is on vacation.  I need to interest someone else
597         in reviewing these patches.
598
599         This patch follows the update/purge model from UpdateTracker.  This
600         patch is less awesome than it could be because it causes the UI to
601         flash slightly.  In a future patch, we'll want to use these
602         update/purge notifications to update the UI without flashing.  However,
603         that's not such a big deal because this UI is hidden in the default
604         view.
605
606         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
607         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
610
611 2011-10-03  David Levin  <levin@chromium.org>
612
613         webkitpy: Expose cc_emails and comments from bug.py
614         https://bugs.webkit.org/show_bug.cgi?id=69308
615
616         Reviewed by Adam Barth.
617
618         * Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
619         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
620         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
621         to comments being exposed.
622
623 2011-10-03  James Robinson  <jamesr@chromium.org>
624
625         Add myself to the watchlist for platform/graphics/chromium
626         https://bugs.webkit.org/show_bug.cgi?id=69297
627
628         Reviewed by David Levin.
629
630         * Scripts/webkitpy/common/config/watchlist:
631
632 2011-10-03  Anders Carlsson  <andersca@apple.com>
633
634         Remove custom scrollbar painting hooks
635         https://bugs.webkit.org/show_bug.cgi?id=69163
636
637         Reviewed by Alexey Proskuryakov.
638
639         * DumpRenderTree/chromium/WebPreferences.cpp:
640         (WebPreferences::applyTo):
641         No need to enable custom scrollbar painting.
642
643 2011-10-03  David Levin  <levin@chromium.org>
644
645         watchlist: Make watchlist run on a bot.
646         https://bugs.webkit.org/show_bug.cgi?id=68974
647
648         Reviewed by Adam Barth.
649
650         * Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
651         * Scripts/webkitpy/tool/commands/queues_unittest.py:
652         Change to log what is run so that we can see the style command
653         and the watchlist command being run.
654
655 2011-10-03  David Levin  <levin@chromium.org>
656
657         watchlist: Allow specified a bug to attach the watchlist info to.
658         https://bugs.webkit.org/show_bug.cgi?id=69288
659
660         Reviewed by Eric Seidel.
661
662         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
663         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
664         Add tests and fix an existing test because the unit tests do not go through the
665         normal command line processing (so the -g argument remained when we determined bug ids).
666         * Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
667         get the assert raises regex method.
668         * Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
669
670 2011-10-03  Leandro Pereira  <leandro@profusion.mobi>
671
672         [EFL] DRT: Add JSStringUtils.{cpp,h}
673         https://bugs.webkit.org/show_bug.cgi?id=66397
674
675         Reviewed by Ryosuke Niwa.
676         
677         Adds helper functions to compare the equality of C-style strings and
678         JSStringRef objects.
679
680         * DumpRenderTree/efl/JSStringUtils.cpp: Added.
681         (equals):
682         * DumpRenderTree/efl/JSStringUtils.h: Added.
683
684 2011-10-03  Adam Barth  <abarth@webkit.org>
685
686         garden-o-matic should work in Safari 5.1
687         https://bugs.webkit.org/show_bug.cgi?id=69290
688
689         Reviewed by Sam Weinig.
690
691         My old implementation of bind was too clever by half.  This one seems
692         to work better, at least according to this test.
693
694         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
695         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
696
697 2011-09-29  Ademar de Souza Reis Jr.  <ademar.reis@openbossa.org>
698
699         Unreviewed: change my e-mail in commiters.py
700
701         (I'm leaving the company and my @openbossa.org will be no more)
702
703         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
704
705 2011-10-01  Brent Fulgham  <bfulgham@webkit.org>
706
707         Correct post-build step for WinCairo test runs.
708         https://bugs.webkit.org/show_bug.cgi?id=69191 
709
710         Reviewed by Brian Weinstein.
711
712         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
713         shell case to handle the CFLite build.
714
715 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
716
717         Added myself to reviewers, because I'm now a reviewer.
718
719         * Scripts/webkitpy/common/config/committers.py:
720
721 2011-10-01  Filip Pizlo  <fpizlo@apple.com>
722
723         Bencher script makes it difficult to do automated performance testing
724         https://bugs.webkit.org/show_bug.cgi?id=69207
725
726         Reviewed by Sam Weinig.
727         
728         This adds two new features:
729         
730         The ability to disable automatic VM detection, which is flaky if any
731         profiling features are enabled in jsc.
732         
733         The ability to compute, and report, a scaled result for all benchmark
734         suites. It is the geometric mean of three numbers: SunSpider's
735         arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
736         It is also possible to turn off all other output from bencher and just
737         get this number with the --brief option.
738
739         * Scripts/bencher:
740
741 2011-10-01  Sam Weinig  <sam@webkit.org>
742
743         WTR is not successfully changing the NSUserDefaults
744         https://bugs.webkit.org/show_bug.cgi?id=69204
745
746         Reviewed by Dan Bernstein.
747
748         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
749         (WTR::InjectedBundle::platformInitialize):
750         Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
751         get our overrides picked up.
752
753 2011-09-30  Daniel Bates  <dbates@rim.com>
754
755         Cleanup: Extract code to launch a Mac WebKit application into a common function
756         https://bugs.webkit.org/show_bug.cgi?id=68662
757
758         Reviewed by Adam Roben.
759
760         Extracts common code to launch a WebKit application on Mac OS X into a function
761         so that we can remove duplicate code.
762
763         * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
764         * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
765         (runMacWebKitApp): Added.
766         (runSafari): Modified to use webkitdirs::runMacWebKitApp().
767         (runMiniBrowser): Ditto.
768         (runWebKitTestRunner): Ditto.
769         (runTestWebKitAPI): Ditto.
770
771 2011-09-29  David Levin  <levin@chromium.org>
772
773         watchlist: Add webkit-patch command to run watchlist.
774         https://bugs.webkit.org/show_bug.cgi?id=68973
775
776         Reviewed by Eric Seidel.
777
778         * Scripts/webkitpy/common/host.py: Exposed the watch_list.
779         * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
780         the cc and messages as sorted lists. To allow for deterministic ordering.
781         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
782         * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
783         that it will be exposed as a command by webkit-patch.
784         * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
785         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
786         * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
787         * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
788         * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
789         * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
790         * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
791         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
792
793 2011-09-30  David Levin  <levin@chromium.org>
794
795         watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
796         https://bugs.webkit.org/show_bug.cgi?id=69031
797
798         Reviewed by Adam Barth.
799
800         * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
801         a comment to explain something important about the email addresses, and
802         a comment to let emacs know to treat the file as a python file.
803         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
804         Detects increases or decreases in a pattern.
805         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
806         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
807         Added unit tests for watchlist which has "more" or "less".
808         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
809         Added support for "more" or "less".
810
811 2011-09-30  Sam Weinig  <sam@webkit.org>
812
813         Add support for eventSender.mouseScrollBy in WTR
814         https://bugs.webkit.org/show_bug.cgi?id=69189
815
816         Add implementation of eventSender.mouseScrollBy for the mac.
817
818         Reviewed by Simon Fraser.
819
820         * WebKitTestRunner/EventSenderProxy.h:
821         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
822         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
823         (WTR::EventSendingController::keyDown):
824         (WTR::EventSendingController::mouseScrollBy):
825         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
826         * WebKitTestRunner/TestController.cpp:
827         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
828         * WebKitTestRunner/mac/EventSenderProxy.mm:
829         (WTR::EventSenderProxy::mouseScrollBy):
830
831 2011-09-30  Simon Fraser  <simon.fraser@apple.com>
832
833         fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
834         https://bugs.webkit.org/show_bug.cgi?id=35273
835
836         Reviewed by Dan Bernstein.
837         
838         There are two types of font issue that can cause layout test failure.
839         First, the user may have non-standard fonts installed that affect the layout
840         of some tests. For example, some tests use the MS Gothic font if installed.
841         
842         Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
843         which override the system fonts (e.g. a copy of Arial from MS Office). For
844         some tests, this can affect font metrics or fallback behavior.
845         
846         This change addresses the first problem only. It limits the set of fonts
847         available through NSFontManager, by swizzling some methods to return
848         a list of fonts or font families which only include fonts from a hardcoded
849         whitelist.
850         
851         * DumpRenderTree/mac/DumpRenderTree.mm:
852         (allowedFontFamilySet):
853         (drt_NSFontManager_availableFontFamilies):
854         (drt_NSFontManager_availableFonts):
855         (swizzleNSFontManagerMethods):
856         (activateTestingFonts):
857         (adjustFonts):
858         (createWebViewAndOffscreenWindow):
859         (prepareConsistentTestingEnvironment):
860         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
861         (WTR::allowedFontFamilySet):
862         (WTR::drt_NSFontManager_availableFontFamilies):
863         (WTR::drt_NSFontManager_availableFonts):
864         (WTR::swizzleNSFontManagerMethods):
865         (WTR::InjectedBundle::platformInitialize):
866
867 2011-09-30  David Levin  <levin@chromium.org>
868
869         Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
870         https://bugs.webkit.org/show_bug.cgi?id=69039
871
872         Reviewed by Adam Barth.
873
874         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
875         Actually skip only one specific test that is failing on Windows.
876
877 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
878
879         [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
880
881         For DRT we didn't install the message handler early enough to
882         catch output while constructing the QApplication. For WTR we
883         didn't even install a message handler.
884
885         Since the UI process will forward any output from the web process
886         we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
887         in WTR before the web process is started. This is picked up by the
888         web process which installs its own message handler.
889
890         The environment variable can be overriden on the command line if you
891         want to see output from the web process, or you can pass --verbose to
892         WTR to see output from both processes.
893
894         https://bugs.webkit.org/show_bug.cgi?id=69132
895
896         Reviewed by Andreas Kling.
897
898         * DumpRenderTree/qt/main.cpp:
899         * WebKitTestRunner/qt/main.cpp:
900
901 2011-09-30  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
902
903         [Qt] Make sure WTR sizes the window and item correctly
904
905         Revision 96345 changed the logic for how the view and
906         window was created, but missed a vital part, setting
907         the size.
908
909         We now use a QSGView for the window, that has a simple
910         item as its root object that is always resized to fit
911         within the window. The webview is then parented to the
912         root object and set to anchors.fill: parent. That way
913         any window geometry changes will propagate to the web
914         view.
915
916         https://bugs.webkit.org/show_bug.cgi?id=69134
917
918         Reviewed by Andreas Kling.
919
920         * WebKitTestRunner/PlatformWebView.h:
921         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
922
923 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
924
925         [EFL] Only save the current viewport in PixelDumpSupportEfl.
926         https://bugs.webkit.org/show_bug.cgi?id=68450
927
928         Reviewed by Antonio Gomes.
929
930         The previous implementation saved the whole page contents in the final
931         PNG, however the baselines and expectations in the tree only want the
932         current viewport (with a scrollbar, if needed), so we now only save the
933         currently visible contents.
934
935         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
936         (createBitmapContextFromWebView): Use
937         ewk_frame_visible_content_geometry_get instead of
938         ewk_frame_contents_size_get.
939
940 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
941
942         [EFL] Support and keep track of extra windows (views).
943         https://bugs.webkit.org/show_bug.cgi?id=68454
944
945         Reviewed by Antonio Gomes.
946
947         So far, window.open and related JavaScript code would not work, as
948         DRTView did not implementation
949         Ewk_View_Smart_Class::window_{open,close}. The default implementation
950         in ewk just returns the current window/view, which broke any
951         layouttest which relied on window.open.
952
953         We now properly create and remove these new views. Unfortunately, the
954         current way ewk works (and due to the fact that we cannot pass class
955         methods as function pointers to the EFL functions), DRTView needs to
956         know that DRTChrome exists and call `browser' directly in some points.
957
958         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
959         (onWindowCreate):
960         (onWindowCloseDelayed):
961         (onWindowClose):
962         (drtViewTiledAdd):
963
964 2011-09-30  Qi Zhang  <qi.2.zhang@nokia.com>
965
966         WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
967         https://bugs.webkit.org/show_bug.cgi?id=42698
968
969         Reviewed by Andreas Kling.
970
971         Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
972         and call clearApplicationCache when layoutTest start up.
973
974         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
975         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
976         (WTR::InjectedBundle::beginTesting):
977         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
978         (WTR::LayoutTestController::clearAllApplicationCaches):
979         (WTR::LayoutTestController::setAppCacheMaximumSize):
980         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
981
982 2011-09-30  Zeno Albisser  <zeno.albisser@nokia.com>
983
984         [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
985         https://bugs.webkit.org/show_bug.cgi?id=69145
986
987         This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
988         Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
989         and is perfectly suitable for SceneGraph as well. GraphicsScene events
990         will not be available in QtGui anymore in future. Therefore we also have to change
991         QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
992
993         Reviewed by Chang Shu.
994
995         * WebKitTestRunner/EventSenderProxy.h:
996         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
997         (WTR::EventSenderProxy::createMouseEvent):
998         (WTR::EventSenderProxy::mouseDown):
999         (WTR::EventSenderProxy::mouseUp):
1000         (WTR::EventSenderProxy::mouseMoveTo):
1001
1002 2011-09-30  James Robinson  <jamesr@chromium.org>
1003
1004         [chromium] Add WebKit API for sending input events to the compositor thread
1005         https://bugs.webkit.org/show_bug.cgi?id=69117
1006
1007         Reviewed by Darin Fisher.
1008
1009         Adds support for creating and setting a compositor thread in DRT.
1010
1011         * DumpRenderTree/chromium/WebViewHost.cpp:
1012         (WebViewHost::WebViewHost):
1013         * DumpRenderTree/chromium/WebViewHost.h:
1014
1015 2011-09-29  David Levin  <levin@chromium.org>
1016
1017         watchlist: Add cross-checks for WatchList once it is filled.
1018         https://bugs.webkit.org/show_bug.cgi?id=68975
1019
1020         Reviewed by Eric Seidel.
1021
1022         * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
1023         instead of having trivial getter and setters.
1024         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
1025         pass the validation checks.
1026         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
1027         and fix a few style nits.
1028         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
1029         validation checks.
1030         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
1031
1032 2011-09-29  Xianzhu Wang  <wangxianzhu@chromium.org>
1033
1034         run-api-tests fails on chromium-win bot
1035         https://bugs.webkit.org/show_bug.cgi?id=69121
1036
1037         On Windows running a perl script needs the interpreter.
1038
1039         Reviewed by Adam Barth.
1040
1041         * Scripts/run-api-tests:
1042         (buildTestTool):
1043
1044 2011-09-29  Adam Barth  <abarth@webkit.org>
1045
1046         Attempt to make this tool work on Windows.
1047
1048         * Scripts/run-api-tests:
1049         (buildTestTool):
1050
1051 2011-09-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1052
1053         [Qt] Try to fix the minial build
1054
1055         * QtTestBrowser/launcherwindow.cpp:
1056         * QtTestBrowser/webpage.cpp:
1057
1058 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1059
1060         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
1061
1062         QWidget and friends now live in the QtWidgets library. We update
1063         includes in implementation files and private headers to us the
1064         non-module-prefixed path, and leave the lookup for the include
1065         path. For public headers we have to ifdef the includes as the
1066         user might now have the modules we need in his QT config.
1067
1068         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
1069         have to update our code and use windowHandle() for setting the
1070         parent relationships.
1071
1072         https://bugs.webkit.org/show_bug.cgi?id=68687
1073
1074         Reviewed by Andreas Kling.
1075
1076         * DumpRenderTree/qt/DumpRenderTree.pro:
1077         * DumpRenderTree/qt/ImageDiff.pro:
1078         * MiniBrowser/qt/BrowserView.cpp:
1079         * MiniBrowser/qt/BrowserView.h:
1080         * MiniBrowser/qt/BrowserWindow.cpp:
1081         * MiniBrowser/qt/BrowserWindow.h:
1082         * MiniBrowser/qt/MiniBrowser.pro:
1083         * MiniBrowser/qt/MiniBrowserApplication.h:
1084         * MiniBrowser/qt/main.cpp:
1085         * QtTestBrowser/QtTestBrowser.pro:
1086         * QtTestBrowser/launcherwindow.cpp:
1087         * QtTestBrowser/launcherwindow.h:
1088         * QtTestBrowser/locationedit.h:
1089         * QtTestBrowser/main.cpp:
1090         * QtTestBrowser/mainwindow.cpp:
1091         * QtTestBrowser/mainwindow.h:
1092         * QtTestBrowser/webinspector.h:
1093         * QtTestBrowser/webpage.cpp:
1094         * QtTestBrowser/webview.cpp:
1095         * WebKitTestRunner/PlatformWebView.h:
1096         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1097
1098 2011-09-29  Ravi Phaneendra Kasibhatla  <ravi.kasibhatla@motorola.com>
1099
1100         Initial implementation of WebInspector for WebKit2 GTK port.
1101         https://bugs.webkit.org/show_bug.cgi?id=68235
1102
1103         Reviewed by Martin Robinson.
1104
1105         * MiniBrowser/gtk/BrowserWindow.c:
1106         (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
1107
1108 2011-09-29  Adam Barth  <abarth@webkit.org>
1109
1110         Unbreak the "update expectatations" button by using the existing
1111         machinery to create the failureInfo objects.
1112
1113         Unbreak the "close" button on the progress dialog by using |this|
1114         instead of the old name of the object.
1115
1116         Teach the controllers unit test not to talk to the actual network.
1117
1118         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1119         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
1120         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1121
1122 2011-09-29  Hans Wennborg  <hans@chromium.org>
1123
1124         IndexedDB: Use LevelDB also for in-memory databases
1125         https://bugs.webkit.org/show_bug.cgi?id=68903
1126
1127         Reviewed by Steve Block.
1128
1129         Remove the temporary dir that was necessary before LevelDB supported
1130         in-memory databases.
1131
1132         * DumpRenderTree/chromium/TestShell.cpp:
1133         (TestShell::TestShell):
1134         * DumpRenderTree/chromium/TestShell.h:
1135
1136 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
1137
1138         Run TestWebKitAPI on Chromium buildbots
1139         https://bugs.webkit.org/show_bug.cgi?id=68678
1140
1141         Reviewed by Tony Chang.
1142
1143         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1144
1145 2011-09-28  Dimitri Glazkov  <dglazkov@chromium.org>
1146
1147         garden-o-matic results should anticipate 0 unexpected failures.
1148         https://bugs.webkit.org/show_bug.cgi?id=69036
1149
1150         Also fixes controllers: UnexpectedFailures test.
1151
1152         Reviewed by Adam Barth.
1153
1154         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
1155
1156 2011-09-28  Dirk Pranke  <dpranke@chromium.org>
1157
1158         Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
1159
1160         https://bugs.webkit.org/show_bug.cgi?id=67253
1161
1162         Reviewed by Eric Seidel.
1163
1164         Nearly all of the work in this was done by Simon Fraser; I'm
1165         just repackaging it and cleaning it up a bit. This change
1166         modifies port.diff_image() to return a tuple of (pass/fail,
1167         %age), adds the value to the FailureImageHashMismatch, and
1168         writes the value into the full_results.json files to be
1169         displayed in the results page.
1170
1171         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1172         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1173         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1174         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1175         * Scripts/webkitpy/layout_tests/port/base.py:
1176         * Scripts/webkitpy/layout_tests/port/chromium.py:
1177         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1178         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1179         * Scripts/webkitpy/layout_tests/port/test.py:
1180         * Scripts/webkitpy/layout_tests/port/webkit.py:
1181         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1182
1183 2011-09-25  Kentaro Hara  <haraken@chromium.org>
1184
1185         Unreviewed. Adding myself to committers.py.
1186
1187         * Scripts/webkitpy/common/config/committers.py:
1188
1189 2011-09-28  Adam Barth  <abarth@webkit.org>
1190
1191         garden-o-matic shouldn't depend on test-results.appspot.com
1192         https://bugs.webkit.org/show_bug.cgi?id=69019
1193
1194         Reviewed by Dimitri Glazkov.
1195
1196         This patch moves garden-o-matic from getting full_results.json from
1197         test-results.appspot.com to getting that information directly from the
1198         buildbot.  This patch improve the load time and accuracy of
1199         garden-o-matic because test-results.appspot.com is slow and is dropping
1200         a significant number of writes (see
1201         https://bugs.webkit.org/show_bug.cgi?id=68748).
1202
1203         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
1204         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1205         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
1206
1207 2011-09-28  David Levin  <levin@chromium.org>
1208
1209         watchlist: Add a way to load the watchlist from config.
1210         https://bugs.webkit.org/show_bug.cgi?id=68991
1211
1212         Reviewed by Eric Seidel.
1213
1214         * Scripts/webkitpy/common/config/watchlist: Added.
1215         * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
1216         Support for loading the watch list.
1217         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
1218         Tests for the loading.
1219         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1220         Adjusted to use the common base class.
1221         * Scripts/webkitpy/common/webkitunittest.py: Added.
1222         Made a common base class for functionality used in more than one.
1223
1224 2011-09-28  David Levin  <levin@chromium.org>
1225
1226         Attempt fix for Leopard python unit test run.
1227
1228         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1229
1230 2011-09-27  Dimitri Glazkov  <dglazkov@chromium.org>
1231
1232         REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
1233         https://bugs.webkit.org/show_bug.cgi?id=68938
1234
1235         Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
1236
1237         Reviewed by David Hyatt.
1238
1239         * DumpRenderTree/chromium/WebViewHost.cpp:
1240         (WebViewHost::didUpdateLayout): Added width/height queries.
1241         * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
1242
1243 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
1244
1245         Get rebaseline server running again
1246         https://bugs.webkit.org/show_bug.cgi?id=69020
1247
1248         Reviewed by Adam Barth.
1249
1250         Make rebaseline server run again after r90337 (missing format_date_time
1251         import, results_json wasn't outputting anything).
1252
1253         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1254         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1255
1256 2011-09-28  David Grogan  <dgrogan@chromium.org>
1257
1258         Move dgrogan from contributor to committer
1259         https://bugs.webkit.org/show_bug.cgi?id=69021
1260
1261         * Scripts/webkitpy/common/config/committers.py:
1262
1263 2011-09-28  Mihai Parparita  <mihaip@chromium.org>
1264
1265         Add Mac Skia GPU bots to builders.py
1266         https://bugs.webkit.org/show_bug.cgi?id=69016
1267
1268         Reviewed by Eric Seidel.
1269
1270         This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
1271         GPU tests.
1272
1273         * Scripts/webkitpy/layout_tests/port/builders.py:
1274         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1275
1276 2011-09-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1277
1278         Second try at fixing the GTK+ build.
1279
1280         * GNUmakefile.am:
1281
1282 2011-09-28  Xianzhu Wang  <wangxianzhu@chromium.org>
1283
1284         Let TestWebKitAPI and webkit_unit_tests work for chromium-win
1285         https://bugs.webkit.org/show_bug.cgi?id=68680
1286
1287         Reviewed by Tony Chang.
1288
1289         * Scripts/run-chromium-webkit-unit-tests:
1290         * Scripts/webkitdirs.pm:
1291         (determineBaseProductDir):
1292
1293 2011-09-28  Kaustubh Atrawalkar  <kaustubh@motorola.com>
1294
1295         [Gtk] Implement textInputController.doCommand
1296         https://bugs.webkit.org/show_bug.cgi?id=66496
1297
1298         Reviewed by Martin Robinson.
1299
1300         * DumpRenderTree/gtk/TextInputController.cpp:
1301         (doCommandCallback): Callback function for textInputController.doCommand
1302
1303 2011-09-28  David Levin  <levin@chromium.org>
1304
1305         watchlist: Suggest corrections for typos and improve error message consistency.
1306         https://bugs.webkit.org/show_bug.cgi?id=68976
1307
1308         Reviewed by Adam Barth.
1309
1310         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
1311         for typos and improve consistency of the error messages.
1312         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
1313         and improve the regex that were already present.
1314
1315 2011-09-28  David Levin  <levin@chromium.org>
1316
1317         watchlist: Add support for matching added or deleted lines.
1318         https://bugs.webkit.org/show_bug.cgi?id=68972
1319
1320         Reviewed by Adam Barth.
1321
1322         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
1323         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
1324         * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
1325         to the pattern match to only have the diff lines instead of the DiffFile.
1326         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
1327         Add tests for the new patterns and combinations of the patterns.
1328         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1329         Sort imports. Add changeline support.
1330
1331 2011-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1332
1333         [GTK] Add WebKitError to GTK+ WebKit2 API
1334         https://bugs.webkit.org/show_bug.cgi?id=68508
1335
1336         Reviewed by Martin Robinson.
1337
1338         * GNUmakefile.am: Add path to webkitgtk derived sources to the
1339         include path.
1340
1341 2011-09-28  Philippe Normand  <pnormand@igalia.com>
1342
1343         [GTK] missing WebKit2 support in run-gtk-tests
1344         https://bugs.webkit.org/show_bug.cgi?id=68992
1345
1346         Rubber-stamped by Andreas Kling.
1347
1348         * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
1349         webkit2 directory.
1350
1351 2011-09-27  Philippe Normand  <pnormand@igalia.com>
1352
1353         [GTK] build-webkit --no-webkit2 still builds WebKit2
1354         https://bugs.webkit.org/show_bug.cgi?id=68892
1355
1356         Reviewed by Martin Robinson.
1357
1358         Take the --no-webkit2 option in account when building WebKitGTK+.
1359
1360         * Scripts/build-webkit:
1361         * Scripts/webkitdirs.pm:
1362         (buildAutotoolsProject):
1363         (buildGtkProject):
1364
1365 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
1366
1367         Make Chromium Win Release (Tests) a core builder
1368         https://bugs.webkit.org/show_bug.cgi?id=68906
1369
1370         Reviewed by Adam Barth.
1371
1372         Add Chromium Win Release (Tests) to the list of core builders.
1373
1374         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1375         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1376
1377 2011-09-27  Adam Barth  <abarth@webkit.org>
1378
1379         garden-o-matic should load faster and inform the user what is happening
1380         https://bugs.webkit.org/show_bug.cgi?id=68954
1381
1382         Reviewed by Dimitri Glazkov.
1383
1384         This test disables the expected failures tab.  The web inspector showed
1385         that loading the data for this tab was slowing down the loading time
1386         for the whole app.  We need to find a way to load that data lazily.
1387
1388         This patch also improves the update message to better describe the
1389         progress the app is making analyzing data from the buildbot.
1390
1391         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
1392         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1393         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
1394
1395 2011-09-27  Adam Barth  <abarth@webkit.org>
1396
1397         garden-o-matic should show the first result when examining results
1398         https://bugs.webkit.org/show_bug.cgi?id=68960
1399
1400         Reviewed by Dimitri Glazkov.
1401
1402         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1403
1404 2011-09-27  David Levin  <levin@chromium.org>
1405
1406         watchlist: Add support for cc and message rules.
1407         https://bugs.webkit.org/show_bug.cgi?id=68950
1408
1409         Reviewed by Adam Barth.
1410
1411         * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
1412         the cc's and messages for a patch.
1413         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
1414         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
1415         for the rules.
1416         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
1417         A generic encapsulation of either a message list or a cc list.
1418         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
1419
1420 2011-09-27  Tom Zakrajsek  <tomz@codeaurora.org>
1421
1422         webkit-patch doesn't like UTF-8 characters in reviewers names
1423         https://bugs.webkit.org/show_bug.cgi?id=63452
1424
1425         Reviewed by Eric Seidel.
1426
1427         * Scripts/webkit-patch:
1428
1429 2011-09-27  Adam Barth  <abarth@webkit.org>
1430
1431         garden-o-matic examine buttons shows both expected and unexpected failures
1432         https://bugs.webkit.org/show_bug.cgi?id=68918
1433
1434         Reviewed by Dimitri Glazkov.
1435
1436         This was a copy/paste error when I refactored this classes to share
1437         more code.
1438
1439         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1440
1441 2011-09-27  Ryosuke Niwa  <rniwa@webkit.org>
1442
1443         Add Kaustubh Atrawalkar to the list of contributors.
1444
1445         * Scripts/webkitpy/common/config/committers.py:
1446
1447 2011-09-27  Mihai Parparita  <mihaip@chromium.org>
1448
1449         [Chromium] Fixed layout mode tests break subsequent tests
1450         https://bugs.webkit.org/show_bug.cgi?id=68923
1451         
1452         Reviewed by Adam Barth.        
1453
1454         Reset fixed layout mode between tests, so that tests that run after
1455         platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
1456         regular 800x600 non-fixed layout.
1457
1458         * DumpRenderTree/chromium/TestShell.cpp:
1459         (TestShell::resetTestController):
1460
1461 2011-09-27  David Levin  <levin@chromium.org>
1462
1463         watchlist: Add the filename pattern for definitions.
1464         https://bugs.webkit.org/show_bug.cgi?id=68917
1465
1466         Reviewed by Adam Barth.
1467
1468         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
1469         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
1470         * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
1471         for definitions.
1472         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
1473         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
1474
1475 2011-09-27  Adam Barth  <abarth@webkit.org>
1476
1477         garden-o-matic results view should sort test and builder names
1478         https://bugs.webkit.org/show_bug.cgi?id=68488
1479
1480         Reviewed by Andy Estes.
1481
1482         Previously, the test and builder names were displayed in an arbitrary
1483         order that changed from time to time.  That confused one user study
1484         participant.  This patch sorts the lists so that they occur in a
1485         predictable order.
1486
1487         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1488
1489 2011-09-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1490
1491         Unreviewed, rolling out r96108, r96111, r96113, and r96116.
1492         http://trac.webkit.org/changeset/96108
1493         http://trac.webkit.org/changeset/96111
1494         http://trac.webkit.org/changeset/96113
1495         http://trac.webkit.org/changeset/96116
1496         https://bugs.webkit.org/show_bug.cgi?id=68913
1497
1498         Wait for working Qt5 (Requested by ossy on #webkit).
1499
1500         * DumpRenderTree/qt/DumpRenderTree.pro:
1501         * DumpRenderTree/qt/ImageDiff.pro:
1502         * MiniBrowser/qt/BrowserView.cpp:
1503         (BrowserView::BrowserView):
1504         * MiniBrowser/qt/BrowserView.h:
1505         * MiniBrowser/qt/BrowserWindow.cpp:
1506         (BrowserWindow::BrowserWindow):
1507         (BrowserWindow::urlChanged):
1508         (BrowserWindow::~BrowserWindow):
1509         * MiniBrowser/qt/BrowserWindow.h:
1510         * MiniBrowser/qt/MiniBrowser.pro:
1511         * MiniBrowser/qt/MiniBrowserApplication.h:
1512         * MiniBrowser/qt/main.cpp:
1513         * QtTestBrowser/QtTestBrowser.pro:
1514         * QtTestBrowser/launcherwindow.cpp:
1515         * QtTestBrowser/launcherwindow.h:
1516         * QtTestBrowser/locationedit.h:
1517         * QtTestBrowser/main.cpp:
1518         * QtTestBrowser/mainwindow.cpp:
1519         * QtTestBrowser/mainwindow.h:
1520         * QtTestBrowser/webinspector.h:
1521         * QtTestBrowser/webpage.cpp:
1522         * QtTestBrowser/webview.cpp:
1523         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1524         * WebKitTestRunner/PlatformWebView.h:
1525         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1526         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1527         (WTR::WebView::wkView):
1528         (WTR::WebView::pageRef):
1529         (WTR::WebView::~WebView):
1530         (WTR::WebView::WebView):
1531         (WTR::PlatformWebView::PlatformWebView):
1532         (WTR::PlatformWebView::sendEvent):
1533         (WTR::PlatformWebView::postEvent):
1534         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1535
1536 2011-09-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1537
1538         [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
1539         https://bugs.webkit.org/show_bug.cgi?id=65178
1540
1541         Reviewed by Martin Robinson.
1542
1543         * GNUmakefile.am:
1544         * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
1545
1546 2011-09-27  Csaba Osztrogonác  <ossy@webkit.org>
1547
1548         [Qt][WK2] Buildfix after r96108.
1549
1550         Rubber-stamped by Andreas Kling.
1551
1552         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1553         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1554         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1555
1556 2011-09-27  David Levin  <levin@chromium.org>
1557
1558         watchlist: Change watchlistparser.py to be class based.
1559         https://bugs.webkit.org/show_bug.cgi?id=68869
1560
1561         Reviewed by Eric Seidel.
1562
1563         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1564         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1565
1566 2011-09-27  David Levin  <levin@chromium.org>
1567
1568         watchlist: Break out the diff boilerplate to allow for re-use.
1569         https://bugs.webkit.org/show_bug.cgi?id=68871
1570
1571         Reviewed by Eric Seidel.
1572
1573         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1574         Break out the diff into a new file.
1575         * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
1576
1577 2011-09-27  Ilya Tikhonovsky  <loislo@chromium.org>
1578
1579         Web Inspector: UI performance: introduce heap size tracking stats.
1580         https://bugs.webkit.org/show_bug.cgi?id=68901
1581
1582         It is interesting how much the heap memory is used by Inspector in order of running the test.
1583
1584         Reviewed by Yury Semikhatsky.
1585
1586         * DumpRenderTree/chromium/TestShell.cpp:
1587         (TestShell::showDevTools):
1588         (TestShell::closeDevTools):
1589
1590 2011-09-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1591
1592         [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
1593
1594         QWidget and friends now live in the QtWidgets library. We update
1595         includes in implementation files and private headers to us the
1596         non-module-prefixed path, and leave the lookup for the include
1597         path. For public headers we have to ifdef the includes as the
1598         user might now have the modules we need in his QT config.
1599
1600         Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
1601         have to update our code and use windowHandle() for setting the
1602         parent relationships.
1603
1604         https://bugs.webkit.org/show_bug.cgi?id=68687
1605
1606         Reviewed by Andreas Kling.
1607
1608         * DumpRenderTree/qt/DumpRenderTree.pro:
1609         * DumpRenderTree/qt/ImageDiff.pro:
1610         * MiniBrowser/qt/BrowserView.cpp:
1611         * MiniBrowser/qt/BrowserView.h:
1612         * MiniBrowser/qt/BrowserWindow.cpp:
1613         * MiniBrowser/qt/BrowserWindow.h:
1614         * MiniBrowser/qt/MiniBrowser.pro:
1615         * MiniBrowser/qt/MiniBrowserApplication.h:
1616         * MiniBrowser/qt/main.cpp:
1617         * QtTestBrowser/QtTestBrowser.pro:
1618         * QtTestBrowser/launcherwindow.cpp:
1619         * QtTestBrowser/launcherwindow.h:
1620         * QtTestBrowser/locationedit.h:
1621         * QtTestBrowser/main.cpp:
1622         * QtTestBrowser/mainwindow.cpp:
1623         * QtTestBrowser/mainwindow.h:
1624         * QtTestBrowser/webinspector.h:
1625         * QtTestBrowser/webpage.cpp:
1626         * QtTestBrowser/webview.cpp:
1627         * WebKitTestRunner/PlatformWebView.h:
1628         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1629
1630 2011-09-26  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
1631
1632         [Qt][WK2] Add support for hover API in Qt WebKit2
1633         https://bugs.webkit.org/show_bug.cgi?id=68369
1634
1635         Reviewed by Andreas Kling.
1636
1637         Change the statusbar to show the link URL when hovering links in
1638         MiniBrowser using QDesktopWebView.
1639
1640         * MiniBrowser/qt/BrowserWindow.cpp:
1641         (BrowserWindow::BrowserWindow):
1642         (BrowserWindow::onLinkHovered):
1643         * MiniBrowser/qt/BrowserWindow.h:
1644
1645 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
1646
1647         garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
1648         https://bugs.webkit.org/show_bug.cgi?id=68864
1649
1650         Reviewed by Adam Barth.
1651
1652         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
1653         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
1654         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
1655         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
1656
1657 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1658
1659         [Qt][WK2] One more unreviewed buildfix after r96005.
1660
1661         * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
1662
1663 2011-09-26  Csaba Osztrogonác  <ossy@webkit.org>
1664
1665         [Qt][WK2] Unreviewed buildfix after r96005.
1666
1667         * WebKitTestRunner/qt/TestInvocationQt.cpp:
1668         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1669
1670 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
1671
1672         garden-o-matic should be pretty in Open Sans.
1673         https://bugs.webkit.org/show_bug.cgi?id=68845
1674
1675         Reviewed by Adam Barth.
1676
1677         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
1678
1679 2011-09-26  Dimitri Glazkov  <dglazkov@chromium.org>
1680
1681         garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
1682         https://bugs.webkit.org/show_bug.cgi?id=68841
1683
1684         Reviewed by Adam Barth.
1685
1686         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
1687         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
1688         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
1689
1690 2011-09-26  David Levin  <levin@chromium.org>
1691
1692         watchlist: Add parsing for definition section.
1693         https://bugs.webkit.org/show_bug.cgi?id=68850
1694
1695         Reviewed by Adam Barth.
1696
1697         * Scripts/webkitpy/common/watchlist/watchlist.py:
1698         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1699         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1700
1701 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
1702
1703         Fix WebKitTestRunner builds for Cairo, Windows and Qt.
1704
1705         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1706         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1707         * WebKitTestRunner/win/TestInvocationWin.cpp:
1708         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1709
1710 2011-09-26  Simon Fraser  <simon.fraser@apple.com>
1711
1712         Repaint tests don't work in WebKit2
1713         https://bugs.webkit.org/show_bug.cgi?id=68453
1714
1715         Reviewed by Sam Weinig.
1716         
1717         Convert DumpRenderTree to use use the repaint rects
1718         exposed via WebKit API when generating the repaint test
1719         overlay.
1720         
1721         Fix WebKitTestRunner to work with repaint tests, again
1722         using the repaint rects exposed from WK2.
1723         
1724         In both cases, layoutTestController.display() now just
1725         forces a display of the web view, and turns on repaint
1726         rect tracking on the main FrameView.
1727         
1728         Later, when pixel results are requested, the alpha overlay
1729         that shows the repaint rects is generated using the list
1730         of rects supplied by WebCore.
1731
1732         * DumpRenderTree/mac/DumpRenderTree.mm:
1733         (resetDefaultsToConsistentValues):
1734         (resetWebViewToConsistentStateBeforeTesting):
1735         (displayWebView):
1736         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1737         (paintRepaintRectOverlay):
1738         (createBitmapContextFromWebView):
1739         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1740         (WTR::InjectedBundle::beginTesting):
1741         (WTR::InjectedBundle::done):
1742         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1743         (WTR::InjectedBundle::setRepaintRects):
1744         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1745         (WTR::InjectedBundlePage::reset):
1746         (WTR::InjectedBundlePage::dump):
1747         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1748         (WTR::LayoutTestController::display):
1749         * WebKitTestRunner/TestInvocation.cpp:
1750         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1751         * WebKitTestRunner/TestInvocation.h:
1752         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1753         (WTR::paintRepaintRectOverlay):
1754         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1755
1756 2011-09-26  Nayan Kumar K  <nayankk@motorola.com>
1757
1758         Get hover'ed element URL from HitTest.
1759
1760         mouseDidMoveOverElement now gets the hover'ed element link using
1761         WKHitTestResult API's.
1762         https://bugs.webkit.org/show_bug.cgi?id=68426 
1763
1764         Reviewed by Anders Carlsson.
1765
1766         * MiniBrowser/gtk/BrowserWindow.c:
1767         (mouseDidMoveOverElement):
1768
1769 2011-09-26  David Levin  <levin@chromium.org>
1770
1771         Add skeleton parsing for a WatchList.
1772         https://bugs.webkit.org/show_bug.cgi?id=68823
1773
1774         Reviewed by Adam Barth.
1775
1776         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
1777         Parses the top level watch list sections -- none are defined yet -- and
1778         throws an exception if an invalid one is listed.
1779         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
1780         Verify the exception for an invalid section in a watch list.
1781         * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
1782
1783 2011-09-26  Adam Roben  <aroben@apple.com>
1784
1785         Clean up code imported from WebKitAPITest
1786
1787         Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
1788         TestWebKitAPI conventions
1789
1790         Reviewed by David Levin.
1791
1792         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
1793         and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
1794         namespace name.
1795
1796         (TestWebKitAPI::WebViewDestruction::SetUp):
1797         (TestWebKitAPI::WebViewDestruction::webViewCount):
1798         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
1799         (TestWebKitAPI::WebViewDestruction::runMessagePump):
1800         (TestWebKitAPI::WebViewDestruction::TearDown):
1801         (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
1802         Moved functionality from free functions into these new test fixtures.
1803
1804         * TestWebKitAPI/win/HostWindow.cpp:
1805         * TestWebKitAPI/win/HostWindow.h:
1806         Prefixed Win32 API calls with ::. Updated namespace name.
1807
1808 2011-09-23  Adam Roben  <aroben@apple.com>
1809
1810         Merge WebKitAPITest into TestWebKitAPI
1811
1812         This also means that our formerly-WebKitAPITest tests will be run on the bots!
1813
1814         I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
1815         them more idiomatic in a separate pass.
1816
1817         Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
1818         functionality (and names!)
1819
1820         Reviewed by Anders Carlsson.
1821
1822         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
1823         * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
1824         * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
1825
1826         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
1827
1828         * TestWebKitAPI/win/main.cpp:
1829         (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
1830
1831         * WebKitAPITest: Removed this directory and its contents.
1832
1833 2011-09-23  Adam Roben  <aroben@apple.com>
1834
1835         Remove two failing WebKitAPITest tests
1836
1837         The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
1838
1839         Reviewed by Anders Carlsson.
1840
1841         * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
1842         MainFrameAfterClose tests.
1843
1844 2011-09-25  Adam Barth  <abarth@webkit.org>
1845
1846         Finish removing PLATFORM(BREWMP) by removing associated code
1847         https://bugs.webkit.org/show_bug.cgi?id=68779
1848
1849         Reviewed by Sam Weinig.
1850
1851         * Scripts/webkitpy/common/config/build.py:
1852         * waf/build/settings.py:
1853
1854 2011-09-21  Ai Makabi  <makabi@google.com>
1855
1856         Provides a simple LRU cache class in Python.
1857
1858         https://bugs.webkit.org/show_bug.cgi?id=67823
1859
1860         Reviewed by Tony Chang.
1861
1862         * Scripts/webkitpy/common/lru_cache.py:
1863         * Scripts/webkitpy/common/lru_cache_unittest.py:
1864
1865 2011-09-25  Adam Barth  <abarth@webkit.org>
1866
1867         Remove PLATFORM(HAIKU) and associated code
1868         https://bugs.webkit.org/show_bug.cgi?id=68774
1869
1870         Reviewed by Sam Weinig.
1871
1872         * Scripts/webkitpy/common/config/build.py:
1873         * waf/build/settings.py:
1874
1875 2011-09-24  Adam Barth  <abarth@webkit.org>
1876
1877         Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
1878         https://bugs.webkit.org/show_bug.cgi?id=68767
1879
1880         Reviewed by Eric Seidel.
1881
1882         * Scripts/build-webkit:
1883
1884 2011-09-24  Adam Barth  <abarth@webkit.org>
1885
1886         Remove ENABLE(WCSS) and associated code
1887         https://bugs.webkit.org/show_bug.cgi?id=68759
1888
1889         Reviewed by Darin Adler.
1890
1891         * Scripts/build-webkit:
1892         * Scripts/old-run-webkit-tests:
1893         * Scripts/webkitperl/features.pm:
1894         (hasFeature):
1895         * Scripts/webkitpy/layout_tests/port/webkit.py:
1896         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1897
1898 2011-09-24  Alejandro G. Castro  <alex@igalia.com>
1899
1900         Fixed GTK compilation after r95878, the operator== was defined
1901         twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
1902
1903         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1904
1905 2011-09-23  Raphael Kubo da Costa  <kubo@profusion.mobi>
1906
1907         [DRT] Include the right config file for EFL's DRT.
1908         https://bugs.webkit.org/show_bug.cgi?id=67042
1909
1910         Reviewed by Martin Robinson.
1911
1912         Ports which use CMake as their buildsystem (such as the EFL one) also
1913         have config.h files, but they are named differently, so include the
1914         right one depending on the buildsystem being used.
1915
1916         * DumpRenderTree/config.h:
1917
1918 2011-09-23  Adam Klein  <adamk@chromium.org>
1919
1920         Add ENABLE_MUTATION_OBSERVERS feature flag
1921         https://bugs.webkit.org/show_bug.cgi?id=68732
1922
1923         Reviewed by Ojan Vafai.
1924
1925         This flag will guard an implementation of the "Mutation Observers" proposed in
1926         http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
1927
1928         * Scripts/build-webkit:
1929
1930 2011-09-23  Chang Shu  <cshu@webkit.org>
1931
1932         [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
1933         https://bugs.webkit.org/show_bug.cgi?id=68556
1934
1935         Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
1936
1937         Reviewed by Darin Adler.
1938
1939         * WebKitTestRunner/EventSenderProxy.h:
1940         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1941         * WebKitTestRunner/PlatformWebView.h:
1942         * WebKitTestRunner/mac/EventSenderProxy.mm:
1943         (WTR::EventSenderProxy::EventSenderProxy):
1944         (WTR::EventSenderProxy::leapForward):
1945         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
1946         (WTR::EventSenderProxy::EventSenderProxy):
1947         (WTR::getMouseButton):
1948         (WTR::getModifiers):
1949         (WTR::EventSenderProxy::updateClickCountForButton):
1950         (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
1951         (WTR::EventSenderProxy::mouseDown):
1952         (WTR::EventSenderProxy::mouseUp):
1953         (WTR::EventSenderProxy::mouseMoveTo):
1954         (WTR::EventSenderProxy::leapForward):
1955         (WTR::EventSenderProxy::sendOrQueueEvent):
1956         (WTR::EventSenderProxy::replaySavedEvents):
1957         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1958         (WTR::PlatformWebView::postEvent):
1959         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1960
1961 2011-09-23  Lei Zhang  <thestig@chromium.org>
1962
1963         [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
1964         https://bugs.webkit.org/show_bug.cgi?id=68026
1965
1966         Reviewed by Dirk Pranke.
1967
1968         * Scripts/webkitpy/layout_tests/port/chromium.py:
1969
1970 2011-09-23  Elliot Poger  <epoger@google.com>
1971
1972         update layout_tests to account for new default of use_skia=1
1973         https://bugs.webkit.org/show_bug.cgi?id=68698
1974
1975         Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
1976         from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
1977         (Chromium-on-Mac now uses the Skia graphics library instead of
1978         Core Graphics).
1979
1980         Also updates layout_test code to work with that change.
1981
1982         Reviewed by Mihai Parparita.
1983
1984         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1985         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1986
1987 2011-09-23  Mark Rowe  <mrowe@apple.com>
1988
1989         Fix the build.
1990         
1991         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
1992         the WTF namespace.
1993
1994 2011-09-22  Dirk Pranke  <dpranke@chromium.org>
1995
1996         enable NRWT for run-webkit-tests on Lion
1997         https://bugs.webkit.org/show_bug.cgi?id=68673
1998
1999         Reviewed by Eric Seidel.
2000
2001         * Scripts/run-webkit-tests:
2002         (useNewRunWebKitTests):
2003
2004 2011-09-22  Xianzhu Wang  <wangxianzhu@chromium.org>
2005
2006         Add unit test for existing StringBuilder
2007         https://bugs.webkit.org/show_bug.cgi?id=67080
2008
2009         Reviewed by Darin Adler.
2010
2011         * TestWebKitAPI/TestWebKitAPI.gypi:
2012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2013         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
2014         (operator<<):
2015         (TestWebKitAPI::expectBuilderContent):
2016         (TestWebKitAPI::expectEmpty):
2017         (TestWebKitAPI::TEST):
2018
2019 2011-09-22  Raphael Kubo da Costa  <kubo@profusion.mobi>
2020
2021         [EFL] Use ewk_view to navigate in history instead of ewk_history.
2022         https://bugs.webkit.org/show_bug.cgi?id=68455
2023
2024         Reviewed by Antonio Gomes.
2025
2026         BackForwardItem::invoke() was using ewk_history functions to navigate
2027         in history; however, this will only call WebCore::BackForwardListImpl
2028         and not move between pages at all. We now call ewk_view_navigate and
2029         its siblings to make sure the navigation actually happens.
2030
2031         This should make tests like fast/dom/navigation-type-back-forward.html
2032         stop timing out.
2033
2034         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2035         (BackForwardItem::invoke):
2036
2037 2011-09-22  Dean Jackson  <dino@apple.com>
2038
2039         Add ENABLE_CSS_FILTERS
2040         https://bugs.webkit.org/show_bug.cgi?id=68652
2041
2042         Reviewed by Simon Fraser.
2043
2044         * Scripts/build-webkit:
2045
2046 2011-09-22  Anders Carlsson  <andersca@apple.com>
2047
2048         EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
2049         https://bugs.webkit.org/show_bug.cgi?id=68660
2050
2051         Reviewed by Adam Barth.
2052
2053         * WebKitTestRunner/mac/EventSenderProxy.mm:
2054         (WTR::EventSenderProxy::mouseUp):
2055
2056 2011-09-22  Adam Roben  <aroben@apple.com>
2057
2058         Remove FindSafari
2059
2060         It isn't used or built anymore.
2061
2062         Fixes <http://webkit.org/b/68628>
2063
2064         Reviewed by Darin Adler.
2065
2066         * FindSafari: Removed this directory and its contents.
2067
2068 2011-09-22  Adam Roben  <aroben@apple.com>
2069
2070         Remove FindSafari from all our .sln files
2071
2072         It isn't used anymore, so there's no point in building it.
2073
2074         Part of <http://webkit.org/b/68628> Remove FindSafari
2075
2076         Reviewed by Steve Falkenburg.
2077
2078         * DumpRenderTree/DumpRenderTree.sln:
2079         * WebKitTestRunner/WebKitTestRunner.sln:
2080
2081 2011-09-22  Adam Roben  <aroben@apple.com>
2082
2083         Remove all uses of FindSafari
2084
2085         It isn't really needed anymore.
2086
2087         Fixes <http://webkit.org/b/68626>.
2088
2089         Reviewed by Darin Adler.
2090
2091         * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
2092
2093         * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
2094         WebKit, but now we use WebKit.exe for that.
2095
2096         * Scripts/webkitdirs.pm:
2097         (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
2098         do the same thing.
2099
2100         (readRegistryString):
2101         (writeRegistryString):
2102         Moved here from old-run-webkit-tests.
2103
2104 2011-09-22  Adam Roben  <aroben@apple.com>
2105
2106         Use the "direct object" form of system() to run WebKit.exe
2107
2108         This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
2109         path to WebKit.exe.
2110
2111         Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
2112         %WEBKITOUTPUTDIR%
2113
2114         Reviewed by Steve Falkenburg.
2115
2116         * Scripts/webkitdirs.pm:
2117         (runSafari):
2118
2119 2011-09-22  Adam Roben  <aroben@apple.com>
2120
2121         Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
2122
2123         Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
2124         spaces in the path to the WebKit source tree
2125
2126         Reviewed by John Sullivan.
2127
2128         * Scripts/webkitdirs.pm:
2129         (setupCygwinEnv):
2130
2131 2011-09-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2132
2133         [Qt] Use same DPI for application font as rest of app in DRT and WTR
2134
2135         QApplication will initialize the default application font based
2136         on the application DPI at construction time, but we then override
2137         the application DPI using QX11Info (hard-coding it to 96 for
2138         consistency). This hard-coding is not reflected in the application
2139         font, so we explicitly have update the font ourselves.
2140
2141         The 6 test results that are updated were originally produced with
2142         a DPI of 75, as this is the default fallback DPI when a QFont is
2143         constructed before QApplication. This was wrong, and the results
2144         are updated to match a DPI of 96.
2145
2146         Reviewed by Csaba Osztrogonác.
2147
2148         * DumpRenderTree/qt/main.cpp:
2149         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2150
2151 2011-09-21  Anna Cavender  <annacc@chromium.org>
2152
2153         Update committers.py with a new contributor contact        
2154         https://bugs.webkit.org/show_bug.cgi?id=68565
2155
2156         Reviewed by Eric Carlson.
2157
2158         * Scripts/webkitpy/common/config/committers.py:
2159
2160 2011-09-21  Chang Shu  <cshu@webkit.org>
2161
2162         [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
2163         https://bugs.webkit.org/show_bug.cgi?id=68108
2164
2165         This patch implements the event sender mouse events through WebKit2 UIProcess which is
2166         closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
2167         platform as the first step so the existing code is still kept for other platforms.
2168
2169         Reviewed by Darin Adler.
2170
2171         * WebKitTestRunner/EventSenderProxy.h:
2172         (WTR::EventSenderProxy::EventSenderProxy):
2173         (WTR::EventSenderProxy::leapForward):
2174         (WTR::EventSenderProxy::currentEventTime):
2175         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2176         (WTR::EventSendingController::EventSendingController):
2177         (WTR::EventSendingController::mouseDown):
2178         (WTR::EventSendingController::mouseUp):
2179         (WTR::EventSendingController::mouseMoveTo):
2180         (WTR::EventSendingController::leapForward):
2181         (WTR::EventSendingController::keyDown):
2182         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2183         * WebKitTestRunner/TestController.cpp:
2184         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2185         * WebKitTestRunner/mac/EventSenderProxy.mm:
2186         (WTR::eventTypeForMouseButtonAndAction):
2187         (WTR::operator==):
2188         (WTR::EventSenderProxy::updateClickCountForButton):
2189         (WTR::EventSenderProxy::mouseDown):
2190         (WTR::EventSenderProxy::mouseUp):
2191         (WTR::EventSenderProxy::mouseMoveTo):
2192         (WTR::EventSenderProxy::keyDown):
2193         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2194         (WTR::EventSenderProxy::keyDown):
2195         (WTR::EventSenderProxy::mouseDown):
2196         (WTR::EventSenderProxy::mouseUp):
2197         (WTR::EventSenderProxy::mouseMoveTo):
2198
2199 2011-09-21  Dan Bernstein  <mitz@apple.com>
2200
2201         Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
2202         https://bugs.webkit.org/show_bug.cgi?id=68451
2203
2204         Reviewed by Darin Adler.
2205
2206         * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
2207         Objective-C classes with names not having one of a list of prefixes
2208         passed on the command line.
2209
2210 2011-09-21  Xianzhu Wang  <wangxianzhu@chromium.org>
2211
2212         Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
2213         https://bugs.webkit.org/show_bug.cgi?id=68206
2214
2215         Reviewed by Tony Chang.
2216
2217         * Scripts/webkitdirs.pm:
2218         (determineBaseProductDir): add support for chromium-mac
2219         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2220         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2221
2222 2011-09-21  Adam Barth  <abarth@webkit.org>
2223
2224         garden-o-matic command should explain that it is starting a local server
2225         https://bugs.webkit.org/show_bug.cgi?id=68486
2226
2227         Reviewed by Dimitri Glazkov.
2228
2229         In the user study, both participants didn't understand why the
2230         garden-o-matic command appeared to hang.  This patch adds an
2231         explaination of what's going on.  It also adds a confirmation prompt
2232         before launching the browser to give the user a chance to read the
2233         text.  If that's too much of a speed bump, we can iterate.
2234
2235         * Scripts/webkitpy/tool/commands/gardenomatic.py:
2236
2237 2011-09-21  Chang Shu  <cshu@webkit.org>
2238
2239         [Qt] Implement KeyDown function for WebKit2 EventSender.
2240         https://bugs.webkit.org/show_bug.cgi?id=56485
2241
2242         Implement the KeyDown function on Qt platform.
2243
2244         Reviewed by Andreas Kling.
2245
2246         * WebKitTestRunner/PlatformWebView.h:
2247         * WebKitTestRunner/TestController.cpp:
2248         (WTR::TestController::TestController):
2249         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2250         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
2251         (WTR::getModifiers):
2252         (WTR::EventSenderProxy::keyDown):
2253         (buildModifierFlags):
2254         (EventSenderProxy::keyDown):
2255         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2256         (WTR::PlatformWebView::sendEvent):
2257         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2258
2259 2011-09-20  Adam Barth  <abarth@webkit.org>
2260
2261         garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
2262         https://bugs.webkit.org/show_bug.cgi?id=68496
2263
2264         Reviewed by Dimitri Glazkov.
2265
2266         This patch adds a bunch of sorting to make sure things happen in a
2267         predictable order in both JavaScriptCore and V8.  We've talked before
2268         about whether these two JavaScript engines should enumerate
2269         dictionaries in the same order, but the consensus has been that they
2270         shouldn't.  Personally, I disagree with that consensus, but such is life.
2271
2272         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2273         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2274         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2275         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2276
2277 2011-09-20  Adam Barth  <abarth@webkit.org>
2278
2279         garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
2280         https://bugs.webkit.org/show_bug.cgi?id=68495
2281
2282         Reviewed by Dimitri Glazkov.
2283
2284         This patch adds an implementation of Function.prototype.bind if the browser lacks one.
2285
2286         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2287
2288 2011-09-20  Eric Seidel  <eric@webkit.org>
2289
2290         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
2291         https://bugs.webkit.org/show_bug.cgi?id=65781
2292
2293         Reviewed by Ryosuke Niwa.
2294
2295         Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
2296         to resolve the passed in url relative to the absolute url for the test.
2297         For http tests, since the test url is an http url, we can't resolve relative
2298         to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
2299         for resolving.
2300
2301         I believe this is a better approach than the on used in the Qt and Chromium DRT's
2302         (which resolves the path relative to the built location of the DRT executable)
2303         and we should move this new code into a shared location in a follow-up patch.
2304
2305         It turns out that there was a second use for pathToLocalResource, used by one
2306         test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
2307         To support this test I made the new pathToLocalResource smart enough to map
2308         /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
2309
2310         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2311         (LayoutTestController::pathToLocalResource):
2312         * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
2313
2314 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
2315
2316         Need to specify a django version, instead of using default
2317         https://bugs.webkit.org/show_bug.cgi?id=68398
2318
2319         Reviewed by Eric Seidel.
2320
2321         * QueueStatusServer/__init__.py:
2322         * QueueStatusServer/main.py:
2323
2324 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
2325
2326         Update committers.py with a few more contributor contacts
2327         https://bugs.webkit.org/show_bug.cgi?id=68487
2328
2329         Reviewed by Eric Seidel.
2330
2331         * Scripts/webkitpy/common/config/committers.py:
2332
2333 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
2334
2335         Fix webkitpy unit tests after 95547 and 95549
2336         https://bugs.webkit.org/show_bug.cgi?id=68483
2337
2338         Reviewed by Adam Barth.
2339         
2340         Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
2341
2342         * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
2343         parse_entries_from_file(), use StringIO and entry.reviewer_text().
2344         While testing parse_latest_entry_from_file(), expect the correct
2345         touched_files() list.
2346
2347 2011-09-20  Adam Barth  <abarth@webkit.org>
2348
2349         garden-o-matic makes it hard to compare images when scroll bars appear
2350         https://bugs.webkit.org/show_bug.cgi?id=68482
2351
2352         Reviewed by Eric Seidel.
2353
2354         Because we autoscale image width, the images rescale if we overflow
2355         vertically and get a scrollbar.  That makes it hard to compare two sets
2356         of images.  This patch reserves space for the scrollbar so we won't
2357         have the layout change.
2358
2359         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
2360
2361 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2362
2363         Unreviewed, rolling out r95565.
2364         http://trac.webkit.org/changeset/95565
2365         https://bugs.webkit.org/show_bug.cgi?id=68470
2366
2367         Broke builds (Requested by andersca on #webkit).
2368
2369         * MiniBrowser/gtk/BrowserWindow.c:
2370         (mouseDidMoveOverElement):
2371
2372 2011-09-20  Nayan Kumar K  <nayankk@motorola.com>
2373
2374         Get hover'ed element URL from HitTest.
2375         
2376         mouseDidMoveOverElement now gets the hover'ed element link using
2377         WKHitTestResult API's.
2378         https://bugs.webkit.org/show_bug.cgi?id=68426
2379
2380         Reviewed by Anders Carlsson.
2381
2382         * MiniBrowser/gtk/BrowserWindow.c:
2383         (mouseDidMoveOverElement):
2384
2385 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
2386
2387         Changelog class should have a method to return all entries
2388         https://bugs.webkit.org/show_bug.cgi?id=68399
2389         
2390         Implement ChangeLog.parse_entries_from_file(). This method returns a generator
2391         of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
2392
2393         Reviewed by Ryosuke Niwa.
2394
2395         * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
2396         and adapt it to become a generator.
2397         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
2398
2399 2011-09-20  Jarred Nicholls  <jarred@sencha.com>
2400
2401         [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
2402         https://bugs.webkit.org/show_bug.cgi?id=51159
2403
2404         Permit any URL with a local scheme to set a user style sheet. Allow qrc
2405         resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
2406         
2407         Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
2408
2409         Reviewed by Kenneth Rohde Christiansen.
2410
2411         * DumpRenderTree/qt/DumpRenderTree.pro:
2412         * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
2413         * DumpRenderTree/qt/resources/user.css: Added.
2414         (body):
2415         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2416         * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
2417         * WebKitTestRunner/qt/resources/user.css: Added.
2418         (body):
2419
2420 2011-09-20  Leandro Pereira  <leandro@profusion.mobi>
2421
2422         ChangeLogEntry class should contain a list of touched files
2423         https://bugs.webkit.org/show_bug.cgi?id=68115
2424
2425         Reviewed by Eric Seidel.
2426         
2427         Add method to return the list of files touched in a ChangeLog entry.
2428
2429         * Scripts/webkitpy/common/checkout/changelog.py: Add
2430         touched_files_regexp and touched_files() method.
2431         * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
2432         unit tests for touched_files() method.
2433
2434 2011-09-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2435
2436         Unreviewed, rolling out r95526 and r95541.
2437         http://trac.webkit.org/changeset/95526
2438         http://trac.webkit.org/changeset/95541
2439         https://bugs.webkit.org/show_bug.cgi?id=68443
2440
2441         It broke 6 tests (Requested by ossy_ on #webkit).
2442
2443         * DumpRenderTree/qt/main.cpp:
2444         (main):
2445         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2446         (WTR::activateFonts):
2447
2448 2011-09-20  Tom Zakrajsek  <tomz@codeaurora.org>
2449
2450         Fix patch and bug numbering in the mocktool simulation code
2451         https://bugs.webkit.org/show_bug.cgi?id=68374
2452
2453         Reviewed by Adam Barth.
2454
2455         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2456         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2457         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2458         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2459         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2460         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2461         * Scripts/webkitpy/tool/commands/download_unittest.py:
2462         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2463         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2464         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2465         * Scripts/webkitpy/tool/commands/queuestest.py:
2466         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2467         * Scripts/webkitpy/tool/mocktool.py:
2468         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2469         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2470
2471 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2472
2473         [Qt] Don't override default QApplication font for DRT and WTR
2474
2475         Revision 95526 moved the relevant code below the QApplication
2476         constructor, to fix a potential crash, and that made the code
2477         take effect, breaking 6 tests.
2478
2479         We should rely on the QWebSettings to set default fonts, and
2480         this QApplication::setFont() is a relic from when we didn't
2481         have that option, so we remove the code.
2482
2483         Reviewed by Csaba Osztrogonác.
2484
2485         * DumpRenderTree/qt/main.cpp:
2486         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2487
2488 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2489
2490         WebKitTestRunner: Provide usage if run without arguments
2491
2492         If WTR is run without either one or more filenames, or
2493         a '-' to indicate server mode, we don't need to start
2494         up the test machinery. Doing so might actually crash,
2495         as we'll exit the application immedeatly after anyways.
2496
2497         Reviewed by Simon Hausmann.
2498
2499         * WebKitTestRunner/TestController.cpp:
2500         (WTR::TestController::initialize):
2501
2502 2011-09-20  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2503
2504         [Qt] Don't use QFont before initializing QApplication
2505
2506         Could potentially result in crash.
2507
2508         Reviewed by Simon Hausmann.
2509
2510         * DumpRenderTree/qt/main.cpp:
2511         (main):
2512
2513 2011-09-19  Adam Barth  <abarth@webkit.org>
2514
2515         Always enable ENABLE(EVENTSOURCE)
2516         https://bugs.webkit.org/show_bug.cgi?id=68414
2517
2518         Reviewed by Eric Seidel.
2519
2520         * Scripts/build-webkit:
2521
2522 2011-09-19  David Levin  <levin@chromium.org>
2523
2524         Sheriffbot rollout should be more intuitive.
2525         https://bugs.webkit.org/show_bug.cgi?id=68415
2526
2527         Reviewed by Adam Barth.
2528
2529         * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
2530         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
2531           and a few others cases.
2532         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
2533
2534 2011-09-19  David Levin  <levin@chromium.org>
2535
2536         check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
2537         https://bugs.webkit.org/show_bug.cgi?id=68391
2538
2539         Reviewed by Darin Adler.
2540
2541         * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
2542         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
2543
2544 2011-09-19  Alexis Menard  <alexis.menard@openbossa.org>
2545
2546         Style checker should not check public Qt WK2 API for parameter_name.
2547         https://bugs.webkit.org/show_bug.cgi?id=68359
2548
2549         Reviewed by Andreas Kling.
2550
2551         The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
2552         Add an exception in the style checker to disable the check. Also added the test for it.
2553
2554         * Scripts/webkitpy/style/checker.py:
2555         * Scripts/webkitpy/style/checker_unittest.py:
2556
2557 2011-09-19  Leandro Pereira  <leandro@profusion.mobi>
2558
2559         GTK DRT leaks memory while comparing history items
2560         https://bugs.webkit.org/show_bug.cgi?id=68086
2561
2562         Reviewed by Martin Robinson.
2563         
2564         webkit_web_history_item_get_target() returns a g_strdup()'d string,
2565         so memory must be freed before compareHistoryItems() returns.
2566
2567         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2568         (compareHistoryItems): Use GOwnPtr to manage memory automatically.
2569
2570 2011-09-19  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2571
2572         Buildbot marks a nrwt bot red when tests are missing results
2573         https://bugs.webkit.org/show_bug.cgi?id=64812
2574
2575         Reviewed by Ryosuke Niwa.
2576
2577         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2578         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2579
2580 2011-09-19  Jessie Berlin  <jberlin@apple.com>
2581
2582         Sites that use history pushState or replaceState are recorded in history in Private Browsing
2583         mode.
2584         https://bugs.webkit.org/show_bug.cgi?id=68208
2585
2586         Reviewed by Brady Eidson.
2587
2588         Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
2589         updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
2590
2591         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
2592         (TestWebKitAPI::didNavigateWithNavigationData):
2593         This is a context history client callback, so it should not be called when in Private
2594         Browsing. Add a call to FAIL().
2595         (TestWebKitAPI::didSameDocumentNavigationForFrame):
2596         This is a page load client callback that happens after the didNavigateWithNavigationData
2597         callback. End the test.
2598         (TestWebKitAPI::TEST):
2599         Enable Private Browsing and load a page that uses history.pushState.
2600
2601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2602         Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
2603         * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
2604         Ditto.
2605         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2606         Ditto.
2607         * TestWebKitAPI/win/copy-resources.cmd:
2608         Ditto.
2609
2610 2011-09-16  Elliot Poger  <epoger@google.com>
2611
2612         add non-CG Webkit-Mac builds to flakiness dashboard
2613         https://bugs.webkit.org/show_bug.cgi?id=68265
2614
2615         Reviewed by Adam Barth.
2616
2617         As Chromium-on-Mac approaches the switchover from Core Graphics to
2618         Skia, we need to add the Skia version to the flakiness dashboard.
2619
2620         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2621         * TestResultServer/static-dashboards/builders.js:
2622         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2623
2624 2011-09-16  Jochen Eisinger  <jochen@chromium.org>
2625
2626         Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
2627         https://bugs.webkit.org/show_bug.cgi?id=68071
2628
2629         Reviewed by Adam Barth.
2630
2631         * DumpRenderTree/chromium/WebPermissions.cpp:
2632         (WebPermissions::allowImage):
2633         * DumpRenderTree/chromium/WebPermissions.h:
2634
2635 2011-09-16  Tom Zakrajsek  <tomz@codeaurora.org>
2636
2637         update-webkit-chromium should retry the gclient call if it fails once
2638         https://bugs.webkit.org/show_bug.cgi?id=68252
2639
2640         Reviewed by Adam Barth.
2641
2642         * Scripts/update-webkit-chromium:
2643
2644 2011-09-16  Rob Buis  <rbuis@rim.com>
2645
2646         Add Eli's rim address and change the nick.
2647
2648         * Scripts/webkitpy/common/config/committers.py:
2649
2650 2011-09-16  Anders Carlsson  <andersca@apple.com>
2651
2652         Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
2653         https://bugs.webkit.org/show_bug.cgi?id=68269
2654
2655         Reviewed by Geoffrey Garen.
2656
2657         Update client function signatures.
2658
2659         * MiniBrowser/gtk/BrowserWindow.c:
2660         (browserWindowUIClientInit):
2661         * MiniBrowser/mac/BrowserWindowController.m:
2662         (mouseDidMoveOverElement):
2663         (-[BrowserWindowController awakeFromNib]):
2664         * MiniBrowser/win/BrowserView.cpp:
2665         (BrowserView::create):
2666         * WebKitTestRunner/TestController.cpp:
2667         (WTR::TestController::createOtherPage):
2668         (WTR::TestController::initialize):
2669
2670 2011-09-16  Anders Carlsson  <andersca@apple.com>
2671
2672         Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
2673         https://bugs.webkit.org/show_bug.cgi?id=68266
2674
2675         Reviewed by John Sullivan.
2676
2677         * MiniBrowser/mac/BrowserWindowController.m:
2678         (mouseDidMoveOverElement):
2679
2680 2011-09-16  Vincent Scheib  <scheib@chromium.org>
2681
2682         Add Vincent Scheib to the committers list.
2683
2684         * Scripts/webkitpy/common/config/committers.py:
2685
2686 2011-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>
2687
2688         Unreviewed, rolling out r95285.
2689         http://trac.webkit.org/changeset/95285
2690         https://bugs.webkit.org/show_bug.cgi?id=68247
2691
2692         It broke a webkitpy test (Requested by ossy on #webkit).
2693
2694         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2695
2696 2011-09-16  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
2697
2698         Buildbot marks a nrwt bot red when tests are missing results
2699         https://bugs.webkit.org/show_bug.cgi?id=64812
2700
2701         Reviewed by Dirk Pranke.
2702
2703         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2704
2705 2011-09-16  Martin Robinson  <mrobinson@igalia.com>
2706
2707         [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
2708         https://bugs.webkit.org/show_bug.cgi?id=68178
2709
2710         Reviewed by Xan Lopez.
2711
2712         Add a work-around to enable WebKit2 when using build-webkit.
2713
2714         * Scripts/webkitdirs.pm:
2715         (buildAutotoolsProject): 
2716
2717 2011-09-15  James Robinson  <jamesr@chromium.org>
2718
2719         Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
2720
2721         * Scripts/webkitpy/common/config/committers.py:
2722
2723 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
2724
2725         UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
2726         https://bugs.webkit.org/show_bug.cgi?id=68003
2727
2728         Reviewed by Adam Barth.
2729
2730         * Scripts/webkitpy/tool/mocktool.py:
2731         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2732         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
2733
2734 2011-09-15  Tom Zakrajsek  <tomz@codeaurora.org>
2735
2736         Python version check is confusing in test-webkitpy
2737         https://bugs.webkit.org/show_bug.cgi?id=68004
2738
2739         Reviewed by Adam Barth.
2740
2741         * Scripts/test-webkitpy:
2742
2743 2011-09-15  Eric Seidel  <eric@webkit.org>
2744
2745         Reviewed by Adam Barth.
2746
2747         webkit-patch should be able to find users and add them to bugzilla groups
2748         https://bugs.webkit.org/show_bug.cgi?id=63351
2749
2750         These are both very basic commands.  But it's now possible to find
2751         all users matching a regexp, as well as add all users matching a regexp
2752         to a set of groups.
2753
2754         bugzilla.py already knew how to find users (for validate-committer-lists)
2755         but now it has the ability to modify the user records.
2756
2757         I split some of the logic out into a new EditUsersParser class
2758         to try and reduce the amount of code in Bugzilla/BugzillaQueries.
2759
2760         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2761         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2762         * Scripts/webkitpy/tool/commands/__init__.py:
2763         * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
2764         * Scripts/webkitpy/tool/commands/findusers.py: Added.
2765
2766 2011-09-15  Eric Seidel  <eric@webkit.org>
2767
2768         Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
2769         https://bugs.webkit.org/show_bug.cgi?id=68182
2770
2771         Reviewed by Adam Barth.
2772
2773         * Scripts/build-webkit:
2774         * waf/build/settings.py:
2775
2776 2011-09-15  Eric Seidel  <eric@webkit.org>
2777
2778         Unreviewed.  Make contributor email look-up case-insensitive.
2779
2780         validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
2781         was missing from committers.py due to case sensitivity.
2782
2783         This also includes a test expectations update to committers_unittest.py
2784         after my previous change.
2785
2786         * Scripts/webkitpy/common/config/committers.py:
2787         * Scripts/webkitpy/common/config/committers_unittest.py:
2788         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2789
2790 2011-09-15  Eric Seidel  <eric@webkit.org>
2791
2792         Unreviewed.  Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
2793
2794         Add a bunch of email aliases to committers.py for regular contributors
2795         who are committing using other email addresses than they have listed in the file.
2796
2797         * Scripts/webkitpy/common/config/committers.py:
2798
2799 2011-09-15  Eric Seidel  <eric@webkit.org>
2800
2801         Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
2802         https://bugs.webkit.org/show_bug.cgi?id=68022
2803
2804         Reviewed by Ryosuke Niwa.
2805
2806         * Scripts/build-webkit:
2807         * waf/build/settings.py:
2808
2809 2011-09-15  Anders Carlsson  <andersca@apple.com>
2810
2811         Fix Mac build by including config.h where needed.
2812
2813         * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2814         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2815         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2816         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2817         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2818         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
2819         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2820         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
2821         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
2822         * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
2823         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2824         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2825         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2826         * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
2827         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2828         * TestWebKitAPI/mac/main.mm:
2829
2830 2011-09-15  Xianzhu Wang  <wangxianzhu@chromium.org>
2831
2832         Let TestWebKitAPI work for chromium
2833         https://bugs.webkit.org/show_bug.cgi?id=67756
2834
2835         Reviewed by Sam Weinig.
2836
2837         * Scripts/build-api-tests:
2838         * Scripts/run-api-tests:
2839         (isSupportedPlatform):
2840         (runTest):
2841         (populateTests):
2842         * Scripts/webkitdirs.pm:
2843         (determineBaseProductDir):
2844         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2845         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2846         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2847         * TestWebKitAPI/InjectedBundleController.cpp:
2848         * TestWebKitAPI/InjectedBundleMain.cpp:
2849         * TestWebKitAPI/JavaScriptTest.cpp:
2850         * TestWebKitAPI/PlatformUtilities.cpp:
2851         * TestWebKitAPI/TestWebKitAPI.gypi: Added.
2852         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2853         * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
2854         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2855         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2856         * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
2857         * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
2858         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2859         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2860         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2861         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2862         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2863         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2864         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2865         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2866         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2867         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2868         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2869         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2870         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2871         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2872         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2873         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2874         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2875         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2876         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2877         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2878         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2879         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2880         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2881         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2882         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2883         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2884         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2885         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2886         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2887         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2888         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2889         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
2890         * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
2891         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
2892         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
2893         * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
2894         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
2895         * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
2896         * TestWebKitAPI/TestsController.cpp:
2897         * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
2898         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
2899         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2900         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
2901         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2902         * TestWebKitAPI/win/main.cpp:
2903
2904 2011-09-15  Jochen Eisinger  <jochen@chromium.org>
2905
2906         [chromium] extract normalization of LayoutTests URLs to a method of TestShell
2907         https://bugs.webkit.org/show_bug.cgi?id=68145
2908
2909         This will allow for other classes in DumpRenderTree to reuse this functionality
2910
2911         Reviewed by David Levin.
2912
2913         * DumpRenderTree/chromium/TestShell.cpp:
2914         (normalizeLayoutTestURLInternal):
2915         (dumpHistoryItem):
2916         (TestShell::normalizeLayoutTestURL):
2917         * DumpRenderTree/chromium/TestShell.h:
2918
2919 2011-09-14  Ada Chan  <adachan@apple.com>
2920
2921         Add test for WKBundleFrameCopyWebArchive().
2922         https://bugs.webkit.org/show_bug.cgi?id=67857
2923
2924         Reviewed by Anders Carlsson.
2925
2926         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
2927         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
2928         the returned data is a valid webarchive.
2929         (TestWebKitAPI::setInjectedBundleClient):
2930         (TestWebKitAPI::didFinishLoadForFrame):
2931         (TestWebKitAPI::TEST): Load simple.html in a WebView.  Wait for it to finish loading, and then ask the
2932         injected bundle for the webarchive and check the returned webarchive.
2933         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
2934         (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
2935         (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
2936         the web archive.
2937
2938         Add files to project.
2939         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
2940         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
2941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2942
2943 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2944
2945         committers.py should support multiple IRC nicknames
2946         https://bugs.webkit.org/show_bug.cgi?id=68110
2947
2948         Reviewed by Eric Seidel.
2949
2950         Add multiple IRC nickname support to committers.py
2951
2952         * Scripts/webkitpy/common/config/committers.py:
2953         * Scripts/webkitpy/common/config/committers_unittest.py:
2954         * Scripts/webkitpy/tool/bot/irc_command.py:
2955         * Scripts/webkitpy/tool/bot/sheriff.py:
2956
2957 2011-09-14  Jon Lee  <jonlee@apple.com>
2958
2959         Implement globalFlag for WebKitTestRunner
2960         https://bugs.webkit.org/show_bug.cgi?id=68033
2961         <rdar://problem/10119204>
2962
2963         Reviewed by Sam Weinig.
2964
2965         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
2966         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2967         (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
2968         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
2969         (WTR::LayoutTestController::globalFlag): simple getter
2970         (WTR::LayoutTestController::setGlobalFlag): simple setter
2971
2972 2011-09-13  Eric Seidel  <eric@webkit.org>
2973
2974         Remove ENABLE_SVG_USE as <use> is required by HTML5
2975         https://bugs.webkit.org/show_bug.cgi?id=68019
2976
2977         Reviewed by Ryosuke Niwa.
2978
2979         * Scripts/build-webkit:
2980         * waf/build/settings.py:
2981
2982 2011-09-14  Ryosuke Niwa  <rniwa@webkit.org>
2983
2984         Remove Jan Erik Hanssen (added in my r95078) from the list for now
2985         since I can't confirm acceptable his committership.
2986
2987         * Scripts/webkitpy/common/config/committers.py:
2988
2989 2011-09-14  Jochen Eisinger  <jochen@chromium.org>
2990
2991         [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
2992         https://bugs.webkit.org/show_bug.cgi?id=68066
2993
2994         Reviewed by Adam Barth.
2995
2996         * DumpRenderTree/chromium/WebViewHost.cpp:
2997         * DumpRenderTree/chromium/WebViewHost.h:
2998
2999 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3000
3001         committers.py is missing some contributors
3002         https://bugs.webkit.org/show_bug.cgi?id=68059
3003
3004         Reviewed by Adam Barth.
3005
3006         Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
3007
3008         Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
3009
3010         * Scripts/webkitpy/common/config/committers.py:
3011
3012 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3013
3014         Fix webkit python test after r95061.
3015
3016         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3017
3018 2011-09-13  Xianzhu Wang  <wangxianzhu@chromium.org>
3019
3020         Add myself as a contributor. No review needed.
3021
3022         * Scripts/webkitpy/common/config/committers.py:
3023
3024 2011-09-13  Adam Barth  <abarth@webkit.org>
3025
3026         garden-o-matic has unfriendly error messages when the local server is not available
3027         https://bugs.webkit.org/show_bug.cgi?id=68042
3028
3029         Reviewed by Dimitri Glazkov.
3030
3031         This patch moves us from using alert to showing the error inline in the
3032         progress dialog.
3033
3034         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3036         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3037         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3038         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3039
3040 2011-09-13  Adam Barth  <abarth@webkit.org>
3041
3042         FailureGrid in garden-o-matic should link to the builder's waterfall page
3043         https://bugs.webkit.org/show_bug.cgi?id=68036
3044
3045         Reviewed by Dimitri Glazkov.
3046
3047         One of the users in the user study thought the configurations names in
3048         the failure grid would link to the underlying bots.  That makes sense,
3049         so this patch adds the behavior.
3050
3051         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3052         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3053         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3054         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3055
3056 2011-09-13  Adam Barth  <abarth@webkit.org>
3057
3058         garden-o-matic should be able to mark failures as expected
3059         https://bugs.webkit.org/show_bug.cgi?id=68027
3060
3061         Reviewed by Dimitri Glazkov.
3062
3063         All the back-end infrastructure exists for this operation.  This patch
3064         just adds some UI to the front-end and wires that UI up to the back
3065         end.  This exact UI will likely need some more polish, but this should
3066         be a reasonable first cut.
3067
3068         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3069         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3070         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3071         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3072         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3073
3074 2011-09-13  Adam Barth  <abarth@webkit.org>
3075
3076         garden-o-matic should tell you about the progress of your rebaseline
3077         https://bugs.webkit.org/show_bug.cgi?id=67967
3078
3079         Reviewed by Dimitri Glazkov.
3080
3081         This patch adds ui.MessageBox, which is a light wrapper around jQuery
3082         UI's dialog widget.  We then use ui.MessageBox to show status messages
3083         about in-progress rebaselines.  As each baseline is downloaded, the
3084         MessageBox updates.  This UI replaces our temporary "alert"-based UI.
3085
3086         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3087         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3092
3093 2011-09-13  Leandro Pereira  <leandro@profusion.mobi>
3094
3095         GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
3096         https://bugs.webkit.org/show_bug.cgi?id=68024
3097
3098         Reviewed by Gustavo Noronha Silva.
3099         
3100         Using g_list_count() and g_list_nth_data() together on a loop is
3101         inneficient since they're both O(n). Iterate over lists in a saner
3102         way.
3103
3104         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3105         (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
3106         iterate on it using g_list_next(). Free the list after done with it.
3107         (dumpBackForwardListForWebView): Instead of appending (which is
3108         expensive in GLists) history items and then iterating from the tail
3109         of the itemsToPrint list, prepend items and walk forwards as usual.
3110         (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
3111         remove the (unneeded) viewList variable.
3112
3113 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3114
3115         Add Eric's IRC nick.
3116
3117         * Scripts/webkitpy/common/config/committers.py:
3118
3119 2011-09-13  Anders Carlsson  <andersca@apple.com>
3120
3121         Disable C++ exceptions when building with clang
3122         https://bugs.webkit.org/show_bug.cgi?id=68031
3123         <rdar://problem/9556880>
3124
3125         Reviewed by Mark Rowe.
3126
3127         * MiniBrowser/Configurations/Base.xcconfig:
3128         * TestWebKitAPI/Configurations/Base.xcconfig:
3129         * WebKitTestRunner/Configurations/Base.xcconfig:
3130
3131 2011-09-13  Ojan Vafai  <ojan@chromium.org>
3132
3133         [chromium] fix flakiness dashboard for chromium interactive tests
3134         https://bugs.webkit.org/show_bug.cgi?id=68029
3135
3136         Reviewed by Tony Chang.
3137
3138         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3139         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
3140
3141 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3142
3143         Add Alice and Aryeh to the list of contributors.
3144
3145         * Scripts/webkitpy/common/config/committers.py:
3146
3147 2011-09-13  Ryosuke Niwa  <rniwa@webkit.org>
3148
3149         sheriffbot whois should also tell us email addresses
3150         https://bugs.webkit.org/show_bug.cgi?id=67975
3151
3152         Reviewed by Eric Seidel and David Levin.
3153
3154         Taught sheriffbot how to tell us contributor's email addresses.
3155
3156         * Scripts/webkitpy/tool/bot/irc_command.py:
3157         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3158
3159 2011-09-13  Eric Seidel  <eric@webkit.org>
3160
3161         Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
3162         https://bugs.webkit.org/show_bug.cgi?id=68018
3163
3164         Reviewed by Ryosuke Niwa.
3165
3166         * Scripts/build-webkit:
3167         * waf/build/settings.py:
3168
3169 2011-09-13  Chang Shu  <cshu@webkit.org>
3170
3171         [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
3172         https://bugs.webkit.org/show_bug.cgi?id=57515
3173
3174         The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
3175         TestController synchronously. The latter then sends simulated event to WebKit2 module,
3176         which is synchronous, too.
3177
3178         Reviewed by Darin Adler.
3179
3180         * WebKitTestRunner/EventSenderProxy.h: Added.
3181         (WTR::EventSenderProxy::EventSenderProxy):
3182         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
3183         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3184         (WTR::EventSendingController::keyDown):
3185         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
3186         * WebKitTestRunner/PlatformWebView.h:
3187         (WTR::PlatformWebView::platformWindow):
3188         * WebKitTestRunner/TestController.cpp:
3189         (WTR::TestController::TestController):
3190         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
3191         * WebKitTestRunner/TestController.h:
3192         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3193         * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
3194         (WTR::buildModifierFlags):
3195         (WTR::EventSenderProxy::keyDown):
3196
3197 2011-09-12  Leandro Pereira  <leandro@profusion.mobi>
3198
3199         [EFL] DRT: Add DumpRenderTreeEfl.h
3200         https://bugs.webkit.org/show_bug.cgi?id=63993
3201
3202         Reviewed by Eric Seidel.
3203         
3204         This header contains some global variables used by EFL's
3205         DumpRenderTree implementation.
3206
3207         * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
3208         appropriate.
3209         * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
3210
3211 2011-09-12  Raphael Kubo da Costa  <kubo@profusion.mobi>
3212
3213         [EFL] Send the right key names for PageUp and PageDown.
3214         https://bugs.webkit.org/show_bug.cgi?id=67044
3215
3216         Reviewed by Kenneth Rohde Christiansen.
3217
3218         PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
3219         PageDown (which is close to the defines in WindowsKeyboardCodes.h).
3220         However, EventSender was sending "Page_Up" and "Page_Down", so tests
3221         such as editing/input/page-up-down-scrolls.html were timing out due to
3222         the right key down events not being sent.
3223
3224         * DumpRenderTree/efl/EventSender.cpp:
3225         (keyPadNameFromJSValue):
3226         (keyNameFromJSValue):
3227
3228 2011-09-12  Eric Seidel  <eric@webkit.org>
3229
3230         sheriffbot whois is case sensitive
3231         https://bugs.webkit.org/show_bug.cgi?id=67972
3232
3233         Reviewed by Adam Barth.
3234
3235         I also fixed a typo in the "More than 5 contributors" message
3236         from my previous commit.
3237
3238         * Scripts/webkitpy/common/config/committers.py:
3239         * Scripts/webkitpy/common/config/committers_unittest.py:
3240         * Scripts/webkitpy/tool/bot/irc_command.py:
3241         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3242
3243 2011-09-12  Eric Seidel  <eric@webkit.org>
3244
3245         sheriffbot whois should be smarter
3246         https://bugs.webkit.org/show_bug.cgi?id=67971
3247
3248         Reviewed by Adam Barth.
3249
3250         This makes sheriffbot whois basically grep the committers list
3251         making it much easier to find a contributor by name.
3252
3253         Unfortunately the current unittests depend on the real committers.py
3254         file, so as we add more eric's to the project, this unittest result will
3255         change.  I think that's OK for now.  We'll fix it when it breaks.
3256
3257         * Scripts/webkitpy/common/config/committers.py:
3258         * Scripts/webkitpy/tool/bot/irc_command.py:
3259         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3260
3261 2011-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3262
3263         Unreviewed, rolling out r94976.
3264         http://trac.webkit.org/changeset/94976
3265         https://bugs.webkit.org/show_bug.cgi?id=67953
3266
3267         Broke a bunch of security/load& tests (Requested by rniwa on
3268         #webkit).
3269
3270         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3271         (LayoutTestController::pathToLocalResource):
3272
3273 2011-09-12  Eric Seidel  <eric@webkit.org>
3274
3275         Rubber-stamped by Adam Barth.
3276
3277         Remove the "the tree is burning!" warning previously shown
3278         when landing patches.  It was a dream.  But it's just noise now.
3279
3280         Some bots will require a restart to notice the removal of the option
3281         so I've left the --ignore-builders option in for now.
3282
3283         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3284         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
3285         * Scripts/webkitpy/tool/commands/download.py:
3286         * Scripts/webkitpy/tool/commands/download_unittest.py:
3287         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3288         * Scripts/webkitpy/tool/steps/__init__.py:
3289         * Scripts/webkitpy/tool/steps/commit.py:
3290         * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
3291         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
3292
3293 2011-09-12  Eric Seidel  <eric@webkit.org>
3294
3295         [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
3296         https://bugs.webkit.org/show_bug.cgi?id=65781
3297
3298         Reviewed by Ryosuke Niwa.
3299
3300         Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
3301         to resolve the passed in url relative to the absolute url for the test.
3302
3303         I believe this is a better approach than the on used in the Qt and Chromium DRT's
3304         (which resolves the path relative to the built location of the DRT executable)
3305         and we should move this new code into a shared location in a follow-up patch.
3306
3307         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3308         (LayoutTestController::pathToLocalResource):
3309
3310 2011-09-12  Eric Seidel  <eric@webkit.org>
3311
3312         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
3313         https://bugs.webkit.org/show_bug.cgi?id=67530
3314
3315         Reviewed by Adam Barth.
3316
3317         I believe I've fixed the bug in the original patch which prompted the rollout.
3318         The previous patch was using the wrong deadline for the initial read,
3319         subtracting time.time() twice from the deadline value.
3320
3321         * Scripts/webkitpy/layout_tests/port/webkit.py:
3322         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3323
3324 2011-09-12  Balazs Kelemen  <kbalazs@webkit.org>
3325
3326         [Qt][WK2] WebKitTestRunner does not produce crash logs
3327         https://bugs.webkit.org/show_bug.cgi?id=67714
3328
3329         Reviewed by Chang Shu.
3330
3331         Added a simple way of generating backtrace on crash
3332         to the web process. The implementation is similar what
3333         we have in DRT. It depends on GNU libc functionality
3334         so it is only enabled where we are running in such an environment.
3335
3336         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3337         (WTR::printBacktrace):
3338         (WTR::crashHandler):
3339         (WTR::InjectedBundle::platformInitialize):
3340
3341 2011-09-11  Filip Pizlo  <fpizlo@apple.com>
3342
3343         Added my IRC nick to the committers file.
3344
3345         * Scripts/webkitpy/common/config/committers.py:
3346
3347 2011-09-01  Filip Pizlo  <fpizlo@apple.com>
3348
3349         The executable allocator makes it difficult to free individual
3350         chunks of executable memory
3351         https://bugs.webkit.org/show_bug.cgi?id=66363
3352
3353         Reviewed by Oliver Hunt.
3354         
3355         Introduced a best-fit, balanced-tree based allocator. The allocator
3356         required a balanced tree that does not allocate memory and that
3357         permits the removal of individual nodes directly (as opposed to by
3358         key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
3359         Changed all references to executable code to use a reference counted
3360         handle.
3361
3362         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3363         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
3364         (TestWebKitAPI::TEST_F):
3365         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
3366         (TestWebKitAPI::Pair::findExact):
3367         (TestWebKitAPI::Pair::remove):
3368         (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
3369         (TestWebKitAPI::Pair::assertFoundAndRemove):
3370         (TestWebKitAPI::Pair::assertEqual):
3371         (TestWebKitAPI::Pair::assertSameValuesForKey):
3372         (TestWebKitAPI::Pair::testDriver):
3373         (TestWebKitAPI::TEST_F):
3374
3375 2011-09-10  Andy Estes  <aestes@apple.com>
3376
3377         Move myself from committers_unable_to_review to reviewers_list.
3378
3379         * Scripts/webkitpy/common/config/committers.py:
3380
3381 2011-09-10  Kevin Ollivier  <kevino@theolliviers.com>
3382
3383         [wx] Unreviewed build fix. MSW build fixes.
3384
3385         * DumpRenderTree/config.h:
3386         * waf/build/wxpresets.py:
3387
3388 2011-09-10  Andreas Kling  <kling@webkit.org>
3389
3390         Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
3391         https://bugs.webkit.org/show_bug.cgi?id=59328
3392
3393         Reviewed by Kenneth Rohde Christiansen.
3394
3395         * MiniBrowser/mac/BrowserWindowController.m:
3396         (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
3397
3398 2011-09-10  Adam Barth  <abarth@webkit.org>
3399
3400         Build fix for Android.  DumpRenderTree is a client of the WebKit API
3401         and does not have access to notImplemented().
3402
3403         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3404         (openStartupDialog):
3405
3406 2011-09-09  Alexey Proskuryakov  <ap@apple.com>
3407
3408         Add a script to create a monolithic script-test
3409         https://bugs.webkit.org/show_bug.cgi?id=67747
3410
3411         Reviewed by Darin Adler.
3412
3413         * Scripts/make-new-script-test: Added.
3414
3415 2011-09-09  Luiz Agostini  <luiz@webkit.org>
3416
3417         Adding myself to the reviewers list.
3418
3419         * Scripts/webkitpy/common/config/committers.py:
3420
3421 2011-09-09  Ryosuke Niwa  <rniwa@webkit.org>
3422
3423         Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
3424         https://bugs.webkit.org/show_bug.cgi?id=67855
3425
3426         Reviewed by Dirk Pranke.
3427
3428         The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
3429         and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
3430
3431         Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
3432
3433         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3434
3435 2011-09-09  Mark Hahnenberg  <mhahnenberg@apple.com>
3436
3437         Add myself to committers.py
3438         https://bugs.webkit.org/show_bug.cgi?id=67853
3439
3440         Reviewed by Darin Adler.
3441
3442         * Scripts/webkitpy/common/config/committers.py:
3443
3444 2011-09-09  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3445
3446         [Qt] Remove common.pri
3447         https://bugs.webkit.org/show_bug.cgi?id=67814
3448
3449         Reviewed by Andreas Kling.
3450
3451         * Tools.pro:
3452
3453 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3454
3455         [NRWT] the nrwt check httpd with --no-http option
3456         https://bugs.webkit.org/show_bug.cgi?id=67835
3457
3458         Reviewed by Tony Chang.
3459
3460         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3461         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3462
3463 2011-09-09  Hao Zheng  <zhenghao@chromium.org>
3464
3465         [chromium] Implement DRT support for Android.
3466         https://bugs.webkit.org/show_bug.cgi?id=67590
3467
3468         Reviewed by Tony Chang.
3469
3470         Add 2 mechanism to make DRT interaction more robust on Android:
3471         - Send 'QUIT' to DRT to make it stop.
3472         - Wait until receiving '#READY' from DRT, so that DRT won't miss any
3473         input commands before it starts.
3474         And LayoutTestController.cpp needs to include <cctype> for 'tolower'
3475         and <clocale> for 'LC_ALL' to compile on Android.
3476
3477         Also change to use sigaction instead of signal for TestShellGtk.cpp,
3478         as signal() man page recommends using sigaction().
3479
3480         * DumpRenderTree/DumpRenderTree.gypi:
3481         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3482         (main):
3483         * DumpRenderTree/chromium/LayoutTestController.cpp:
3484         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
3485         (AlarmHandler):
3486         (TestShell::waitTestFinished):
3487         (platformInit):
3488         (openStartupDialog):
3489         (checkLayoutTestSystemDependencies):
3490         * DumpRenderTree/chromium/TestShellGtk.cpp:
3491         (AlarmHandler):
3492         (TestShell::waitTestFinished):
3493
3494 2011-09-09  Kevin Ollivier  <kevino@theolliviers.com>
3495
3496         [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
3497
3498         * waf/build/settings.py:
3499
3500 2011-09-09  Sheriff Bot  <webkit.review.bot@gmail.com>
3501
3502         Unreviewed, rolling out r94851.
3503         http://trac.webkit.org/changeset/94851
3504         https://bugs.webkit.org/show_bug.cgi?id=67847
3505
3506         It broke a webkitpy test (Requested by ossy on #webkit).
3507
3508         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3509
3510 2011-09-09  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3511
3512         [NRWT] the nrwt check httpd with --no-http option
3513         https://bugs.webkit.org/show_bug.cgi?id=67835
3514
3515         Reviewed by Csaba Osztrogonác.
3516
3517         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3518
3519 2011-09-08  Brian Weinstein  <bweinstein@apple.com>
3520
3521         WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
3522         https://bugs.webkit.org/show_bug.cgi?id=67794
3523         <rdar://problem/9892024>
3524         
3525         Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
3526
3527         Reviewed by Brady Eidson.
3528
3529         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
3530         (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
3531         (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
3532         (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
3533             Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
3534             didPerformServerRedirect.
3535
3536         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
3537         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
3538             our InjectedBundleTest.
3539         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
3540             from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
3541             the request.
3542         (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
3543
3544         * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
3545         
3546         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
3547         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
3548         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
3549         * TestWebKitAPI/win/copy-resources.cmd: Ditto.
3550
3551 2011-09-08  David Levin  <levin@chromium.org>
3552
3553         check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
3554         https://bugs.webkit.org/show_bug.cgi?id=67797
3555
3556         Reviewed by Eric Seidel.
3557
3558         * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
3559         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
3560
3561 2011-09-08  Fady Samuel  <fsamuel@chromium.org>
3562
3563         Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
3564         https://bugs.webkit.org/show_bug.cgi?id=67723
3565
3566         Reviewed by Adam Barth.
3567
3568         * DumpRenderTree/chromium/EventSender.h:
3569         * DumpRenderTree/chromium/LayoutTestController.cpp:
3570         (LayoutTestController::LayoutTestController):
3571         (LayoutTestController::enableFixedLayoutMode):
3572         (LayoutTestController::setFixedLayoutSize):
3573         * DumpRenderTree/chromium/LayoutTestController.h:
3574
3575 2011-09-07  Matthew Delaney  <mdelaney@apple.com>
3576
3577         Add standalone script that filters the output of build-webkit to be more human-readable
3578         https://bugs.webkit.org/show_bug.cgi?id=44081
3579
3580         Reviewed by Daniel Bates.
3581
3582         * Scripts/filter-build-webkit: Added. Just need to feed it the output of
3583         a build script (e.g. build-webkit) and it spits out a prettier version.
3584         * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
3585         * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
3586
3587 2011-09-07  Noel Gordon  <noel.gordon@gmail.com>
3588
3589         Add myself to committers.py                 
3590         https://bugs.webkit.org/show_bug.cgi?id=67696
3591
3592         Reviewed by Kent Tamura.
3593
3594         * Scripts/webkitpy/common/config/committers.py:
3595
3596 2011-09-07  Adam Barth  <abarth@webkit.org>
3597
3598         rebaseline button in garden-o-matic details view should work
3599         https://bugs.webkit.org/show_bug.cgi?id=67738
3600
3601         Reviewed by Dimitri Glazkov.
3602
3603         This patch wires up the rebaseline button in garden-o-matic results
3604         details view.  The button is current per-test, so there isn't a way to
3605         rebaseline individual bots.  This is a place to start.  If we decide we
3606         want per-bot rebaselining, we'll need to think of some better UI.
3607
3608         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3609         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
3610         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3611         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3612
3613 2011-09-07  Eric Seidel  <eric@webkit.org>
3614
3615         Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
3616         https://bugs.webkit.org/show_bug.cgi?id=67737
3617
3618         Reviewed by Adam Barth.
3619
3620         I got a little over-eager when deprecating host.port_factory in the previous commit.
3621         Turns out that Host.port_factory was already the "modern" port/factory.py
3622         it was just the Module object.  I un-deprecated the variable, and changed it from
3623         being the module to being an actual PortFactory, passing it a host object.
3624         I also taught PortFactory how to set user/executive/filesystem in the kwargs
3625         when instantiating a new Port object.
3626         This magically fixed the test_rebaseline test, since its now no longer talking
3627         to the real filesystem.
3628
3629         * Scripts/webkitpy/common/host.py:
3630         * Scripts/webkitpy/layout_tests/port/factory.py:
3631         * Scripts/webkitpy/tool/commands/queries.py:
3632         * Scripts/webkitpy/tool/mocktool.py:
3633
3634 2011-09-07  Eric Seidel  <eric@webkit.org>
3635
3636         Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
3637         https://bugs.webkit.org/show_bug.cgi?id=67734
3638
3639         Reviewed by Adam Barth.
3640
3641         Right now every place that creates a Port object has to be very careful
3642         to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
3643         The correct fix is for port/factory.py (which creates most port objects)
3644         to know how to pass these in automatically.  However, currently all port/factory.py
3645         functions are free functions instead of being on an object.  This patch
3646         adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
3647
3648         In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
3649         pass along the proper scm/user/filesystem to the Port object.
3650
3651         * Scripts/webkitpy/common/host.py:
3652         * Scripts/webkitpy/layout_tests/port/factory.py:
3653         * Scripts/webkitpy/tool/commands/queries.py:
3654         * Scripts/webkitpy/tool/mocktool.py:
3655
3656 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3657
3658         Unreviewed, rolling out r94441.
3659         http://trac.webkit.org/changeset/94441
3660         https://bugs.webkit.org/show_bug.cgi?id=67731
3661
3662         "MacEWSes are backed up due to new machines not able to reach
3663         git.webkit.org.  Disabling tests for now" (Requested by
3664         eseidel2 on #webkit).
3665
3666         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3667
3668 2011-09-07  Elliot Poger  <epoger@google.com>
3669
3670         filter test_expectations properly for chromium-mac vs chromium-cg-mac
3671         https://bugs.webkit.org/show_bug.cgi?id=67324
3672
3673         Reviewed by Dirk Pranke.
3674
3675         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3676         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3677         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3678         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3679         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3680
3681 2011-09-07  Eric Boren  <borenet@gmail.com>
3682
3683         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
3684         https://bugs.webkit.org/show_bug.cgi?id=66800
3685
3686         Reviewed by Darin Fisher.
3687
3688         * DumpRenderTree/chromium/EventSender.cpp:
3689         (EventSender::sendCurrentTouchEvent):
3690
3691 2011-09-07  Jarred Nicholls  <jarred@sencha.com>
3692
3693         [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
3694         https://bugs.webkit.org/show_bug.cgi?id=67254
3695
3696         Reviewed by Csaba Osztrogonác.
3697
3698         Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
3699         derived from the running location of DumpRenderTree binary.
3700
3701         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3702         (LayoutTestController::pathToLocalResource):
3703         (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
3704
3705 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3706
3707         REGRESSION(r94288) build-webkit doesn't work on Symbian
3708         https://bugs.webkit.org/show_bug.cgi?id=67706
3709
3710         * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
3711         (buildQMakeProject):
3712
3713 2011-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3714
3715         REGRESSION(r94288) build-webkit doesn't work on Windows
3716         https://bugs.webkit.org/show_bug.cgi?id=67646
3717
3718         Roll back r94655 with a small fix.
3719
3720         * Scripts/webkitdirs.pm:
3721         (buildQMakeProject):
3722
3723 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3724
3725         Unreviewed, rolling out r94635.
3726         http://trac.webkit.org/changeset/94635
3727         https://bugs.webkit.org/show_bug.cgi?id=67704
3728
3729         Linux Touch build is failing to compile this change.
3730         (Requested by loislo on #webkit).
3731
3732         * DumpRenderTree/chromium/EventSender.cpp:
3733         (EventSender::sendCurrentTouchEvent):
3734
3735 2011-09-07  Sheriff Bot  <webkit.review.bot@gmail.com>
3736
3737         Unreviewed, rolling out r94655.
3738         http://trac.webkit.org/changeset/94655
3739         https://bugs.webkit.org/show_bug.cgi?id=67703
3740
3741         It broke Leopard debug bot (Requested by ossy on #webkit).
3742
3743         * Scripts/webkitdirs.pm:
3744
3745 2011-09-07  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3746
3747         REGRESSION(r94288) build-webkit doesn't work on Windows
3748         https://bugs.webkit.org/show_bug.cgi?id=67646
3749
3750         Reviewed by Csaba Osztrogonác.
3751
3752         * Scripts/webkitdirs.pm:
3753
3754 2011-09-06  Eric Boren  <borenet@gmail.com>
3755
3756         [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
3757         https://bugs.webkit.org/show_bug.cgi?id=66800
3758
3759         Reviewed by Darin Fisher.
3760
3761         * DumpRenderTree/chromium/EventSender.cpp:
3762         (EventSender::sendCurrentTouchEvent):
3763
3764 2011-09-06  Adam Barth  <abarth@webkit.org>
3765
3766         garden-o-matic details view should having working rebaseline and next/previous buttons
3767         https://bugs.webkit.org/show_bug.cgi?id=67659
3768
3769         Reviewed by Dimitri Glazkov.
3770
3771         This patch wires up basic back/forward buttons that let you traverse
3772         through the results we're examining in the details view.  This ended up
3773         being more code than I expected, but I wanted to keep all the state
3774         information in the DOM itself.
3775
3776         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3777         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3778         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3779
3780 2011-09-01  Dirk Pranke  <dpranke@chromium.org>
3781
3782         fix MockFileSystem.glob(), refactor filesystem tests
3783         https://bugs.webkit.org/show_bug.cgi?id=67462
3784
3785         Reviewed by Eric Seidel.
3786
3787         In debugging why my proposed change for MockFileSystem.glob()
3788         in bug 66228 didn't work, I stumbled across two real bugs
3789         that cancelled each other out for the unit tests. I fixed those
3790         (glob shouldn't recurse into subdirs, and we weren't populating
3791         self.dirs from self.files properly).
3792
3793         I have also created a "mixin" class for tests that can be shared
3794         between the real filesystem and the mock filesystem - MockFileSystem
3795         is being used enough it needs its own tests.
3796
3797         * Scripts/webkitpy/common/system/filesystem_mock.py:
3798         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
3799         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3800
3801 2011-09-06  Anders Carlsson  <andersca@apple.com>
3802
3803         Move NPAPI headers in bridge to plugins
3804         https://bugs.webkit.org/show_bug.cgi?id=67661
3805
3806         Update forwarding headers.
3807
3808         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
3809         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
3810
3811 2011-09-06  Tony Chang  <tony@chromium.org>
3812
3813         [chromium] Check in 'build' for compiled binaries first
3814         https://bugs.webkit.org/show_bug.cgi?id=67549
3815
3816         Reviewed by Dirk Pranke.
3817
3818         I'm working on moving the windows build output to a common location
3819         rather than relative to the sln file.  Because of that, we need to
3820         check those build locations first for DumpRenderTree.exe.
3821
3822         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3823
3824 2011-09-06  Adam Barth  <abarth@webkit.org>
3825
3826         Use a hierarchial structure for the garden-o-matic results view
3827         https://bugs.webkit.org/show_bug.cgi?id=67620
3828
3829         Reviewed by Dimitri Glazkov.
3830
3831         This patch re-organizes the results view to use a hierachial structure
3832         for selection.  At the top-level are sections for each test.  Expanding
3833         the test section shows a tab selector for builders.
3834
3835         This structure prepares us for wiring up various actions to this view.
3836
3837         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3838         (.):
3839         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3840         ():
3841         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3842         (.):
3843         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3844         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3845         (.results-view>.toolbar):
3846         (.results-view>.toolbar ul.actions):
3847         (.results-view>.toolbar ul.actions li):
3848         (.results-grid table):
3849         (.results-grid table td, .results-view table th):
3850         (.results-grid table th):
3851         (.results-grid .text-result):
3852         (.results-grid .image-result):
3853
3854 2011-09-06  Adam Barth  <abarth@webkit.org>
3855
3856         garden-o-matic's base.probe generates spam in the JavaScript console
3857         https://bugs.webkit.org/show_bug.cgi?id=67622
3858
3859         Reviewed by Dimitri Glazkov.
3860
3861         Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
3862         instead of HTMLScriptElement to test whether results exist.  This
3863         reduces the console.log spam and saves bandwidth because we can use a
3864         HEAD request instead of a GET request.
3865
3866         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
3867
3868 2011-09-05  Adam Barth  <abarth@webkit.org>
3869
3870         Add a tab to garden-o-matic for viewing expected failures
3871         https://bugs.webkit.org/show_bug.cgi?id=67619
3872
3873         Reviewed by Dimitri Glazkov.
3874
3875         This patch adds a basic tab to garden-o-matic that shows all the tests
3876         failing on the bots, including the expected failures.  This patch
3877         mostly involves refactoring existing classes to allow new subclasses.
3878
3879         This view is useful for when gardeners mark tests as expected to fail
3880         and then rebaseline them later.
3881
3882         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3883         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
3884         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
3885         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
3886         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3887         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3888         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3889
3890 2011-09-05  Adam Barth  <abarth@webkit.org>
3891
3892         Fix global variable leak in garden-o-matic
3893         https://bugs.webkit.org/show_bug.cgi?id=67617
3894
3895         Reviewed by Dimitri Glazkov.
3896
3897         Caught by running the unit tests with noglobals turned on.
3898
3899         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3900
3901 2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>
3902
3903         [Qt][WK2] Add pixel test support
3904         https://bugs.webkit.org/show_bug.cgi?id=66283
3905
3906         Reviewed by Andreas Kling.
3907
3908         Implemented pixel result generation by reusing the logic
3909         that we have in DumpRenderTree.
3910         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3911         (WTR::dumpImage):
3912         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3913
3914 2011-09-04  Robin Dunn  <robin@alldunn.com>
3915
3916         [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
3917         https://bugs.webkit.org/show_bug.cgi?id=67577
3918
3919         Reviewed by Kevin Ollivier.
3920
3921         * waf/build/settings.py:
3922
3923 2011-09-03  Kevin Ollivier  <kevino@theolliviers.com>
3924
3925         [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
3926
3927         * waf/build/settings.py:
3928
3929 2011-09-03  Dan Bernstein  <mitz@apple.com>
3930
3931         32-bit build fix.
3932
3933         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3934         (TestWebKitAPI::Util::toSTD):
3935
3936 2011-09-03  Dan Bernstein  <mitz@apple.com>
3937
3938         Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
3939         https://bugs.webkit.org/show_bug.cgi?id=67559
3940
3941         Reviewed by Darin Adler.
3942
3943         * DumpRenderTree/mac/DumpRenderTree.mm:
3944         (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
3945         the call to it.
3946         * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
3947         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
3948         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
3949         (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
3950         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3951         (TestWebKitAPI::Util::toSTD): Added.
3952
3953 2011-09-03  Adam Barth  <abarth@webkit.org>
3954
3955         garden-o-matic results view should have a better results selector
3956         https://bugs.webkit.org/show_bug.cgi?id=67542
3957
3958         Reviewed by Dimitri Glazkov.
3959
3960         This patch adds a basic grid-based results selector to the results
3961         view.  Currently, this grid just shows how the tests fail on the
3962         various bots.  A future patch will let you select which failure to view
3963         and to mark the failures for rebaselining.
3964
3965         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3967           - Add some more basic functions for manipulating dictionaries.
3968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3971
3972 2011-09-03  Adam Barth  <abarth@webkit.org>
3973
3974         garden-o-matic results view should show Actual and Expected results for text failures
3975         https://bugs.webkit.org/show_bug.cgi?id=67536
3976
3977         Reviewed by Eric Seidel.
3978
3979         In the past, we didn't show actual and expected text results (we just
3980         showed the diff) because we didn't have the awesome six-by-two results
3981         grid.  Now that we do, we can move show these results.
3982
3983         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
3984         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
3985           - Fixed some typos that were preventing these unit tests from running.
3986         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
3987         (.):
3988         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3989           - Report -actual.txt and -expected.txt as possible results URLs.
3990
3991 2011-09-03  Adam Barth  <abarth@webkit.org>
3992
3993         garden-o-matic shows "ghost" failures that are already fixed
3994         https://bugs.webkit.org/show_bug.cgi?id=67535
3995
3996         Reviewed by Eric Seidel.
3997
3998         About 10% of writes fail to stick on test-results.appspot.com.  This
3999         patch causes us to fetch the full_results.json blob directly from
4000         build.chromium.org rather than relying upon AppEngine.
4001
4002         Unforuntately, we still need to get historical information from
4003         AppEngine.  That will take several patches to fix becuase I need to
4004         change the bots to write the full_results.json file to the
4005         build-specific directory in addition to the zip file.
4006
4007         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
4008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
4009         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
4010
4011 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
4012
4013         Unreviewed, rolling out r94458.
4014         http://trac.webkit.org/changeset/94458
4015         https://bugs.webkit.org/show_bug.cgi?id=67558
4016
4017         Caused appcache test to fail on various bots (Requested by
4018         rniwa on #webkit).
4019
4020         * Scripts/webkitpy/layout_tests/port/webkit.py:
4021         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4022
4023 2011-09-03  Sheriff Bot  <webkit.review.bot@gmail.com>
4024
4025         Unreviewed, rolling out r94453.
4026         http://trac.webkit.org/changeset/94453
4027         https://bugs.webkit.org/show_bug.cgi?id=67557
4028
4029         Caused appcache test to fail on various bots (Requested by
4030         rniwa on #webkit).
4031
4032         * Scripts/webkitpy/layout_tests/port/webkit.py:
4033
4034 2011-09-02  Michael Saboff  <msaboff@apple.com>
4035
4036         Add JSC:RegExp functional tests
4037         https://bugs.webkit.org/show_bug.cgi?id=67339
4038
4039         New perl script to build JavaScriptCore and run the RegExp tests.
4040
4041         Reviewed by Gavin Barraclough.
4042
4043         * Scripts/run-regexp-tests: Added.
4044
4045 2011-09-02  Michael Saboff  <msaboff@apple.com>
4046
4047         Add JSC:RegExp functional tests
4048         https://bugs.webkit.org/show_bug.cgi?id=67339
4049
4050         New perl script to build JavaScriptCore and run the RegExp tests.
4051
4052         Reviewed by Gavin Barraclough.
4053
4054         * Scripts/run-regexp-tests: Added.
4055
4056 2011-09-02  Eric Seidel  <eric@webkit.org>
4057
4058         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
4059         https://bugs.webkit.org/show_bug.cgi?id=67530
4060
4061         Unreviewed.  Fixing typo from previous commit.
4062
4063         Turns out there was *no* unittesting of WebKitDriver.  Added a basic test of _read_block
4064         which exercises the code I previously made a typo in.
4065
4066         * Scripts/webkitpy/layout_tests/port/webkit.py:
4067         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
4068
4069 2011-09-02  Eric Seidel  <eric@webkit.org>
4070
4071         Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
4072         https://bugs.webkit.org/show_bug.cgi?id=67530
4073
4074         Reviewed by Adam Barth.
4075
4076         No functional change, just reshuffling code.
4077
4078         * Scripts/webkitpy/layout_tests/port/webkit.py:
4079
4080 2011-09-02  Darin Adler  <darin@apple.com>
4081
4082         Added Subversion ignore for .pyc generated files.
4083
4084         * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
4085         * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
4086         * Scripts/webkitpy/tool/servers: Added property svn:ignore.
4087
4088 2011-09-02  Adam Barth  <abarth@webkit.org>
4089
4090         Enable testing on mac-ews
4091         https://bugs.webkit.org/show_bug.cgi?id=67505
4092
4093         Reviewed by Eric Seidel.
4094
4095         This patch enables testing on the Mac EWS, which should help
4096         contributors not turn the Mac bots red.
4097
4098         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
4099
4100 2011-09-01  Beth Dakin  <bdakin@apple.com>
4101
4102         https://bugs.webkit.org/show_bug.cgi?id=67451
4103         Add a test for going back to a cached page after changing the device scale factor
4104
4105         Reviewed by Adam Roben.
4106
4107         New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
4108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4109         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
4110         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
4111         (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
4112         (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
4113         (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
4114         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
4115         (TestWebKitAPI::TEST_F):
4116
4117         Added new function to WebKitAgnosticTest to goBack. Separated 
4118         waitForLoadToFinish() into its own function (instead of being a part of 
4119         loadAndWaitUntilFinished()) so that it can be called from goBack as 
4120         well. Also added initializeView() so we can set the cache model.
4121         * TestWebKitAPI/mac/WebKitAgnosticTest.h:
4122         (TestWebKitAPI::WebKitAgnosticTest::initializeView):
4123         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
4124         (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
4125         (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
4126         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
4127         (TestWebKitAPI::WebKitAgnosticTest::loadURL):
4128         (TestWebKitAPI::WebKitAgnosticTest::goBack):
4129         (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
4130
4131 2011-09-02  Anders Carlsson  <andersca@apple.com>
4132
4133         Build fix.
4134
4135         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
4136         (PrivateBrowsing::ScriptableObject::pluginTest):
4137
4138 2011-09-02  Anders Carlsson  <andersca@apple.com>
4139
4140         Move private browsing test to a PluginTest subclass
4141         https://bugs.webkit.org/show_bug.cgi?id=67498
4142
4143         Reviewed by Darin Adler.
4144
4145         * DumpRenderTree/DumpRenderTree.gypi:
4146         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
4147         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
4148         (pluginGetProperty):
4149         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
4150         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
4151         (PluginTest::NPP_SetValue):
4152         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
4153         * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
4154         (PrivateBrowsing::PrivateBrowsing):
4155         (PrivateBrowsing::privateBrowsingEnabled):
4156         (PrivateBrowsing::cachedPrivateBrowsingEnabled):
4157         (PrivateBrowsing::ScriptableObject::hasProperty):
4158         (PrivateBrowsing::ScriptableObject::getProperty):
4159         (PrivateBrowsing::ScriptableObject::pluginTest):
4160         (PrivateBrowsing::NPP_New):
4161         (PrivateBrowsing::NPP_GetValue):
4162         (PrivateBrowsing::NPP_SetValue):
4163         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4164         (NPP_New):
4165         (NPP_SetValue):
4166         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
4167         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
4168         * GNUmakefile.am:
4169
4170 2011-09-02  Csaba Osztrogonác  <ossy@webkit.org>
4171
4172         [Qt] Build dependency problems
4173         https://bugs.webkit.org/show_bug.cgi?id=38054
4174
4175         Trivial fix after r94288.
4176
4177         Rubber-stamped by Andras Becsi.
4178
4179         * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
4180         (buildQMakeProject):
4181
4182 2011-09-02  Andras Becsi  <andras.becsi@nokia.com>
4183
4184         Remove my old e-mail address and add my new one.
4185
4186         Rubber-stamped by Tor Arne Vestbø.
4187
4188         * Scripts/webkitpy/common/config/committers.py:
4189
4190 2011-09-02  Philippe Normand  <pnormand@igalia.com>
4191
4192         [GTK] run-gtk-tests leaves a zombie Xvfb process
4193         https://bugs.webkit.org/show_bug.cgi?id=67389
4194
4195         Reviewed by Martin Robinson.
4196
4197         * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
4198         child process instead of doing shell redirection.
4199
4200 2011-09-01  Mark Rowe  <mrowe@apple.com>
4201
4202         Fix the build by adding some more missing return types.
4203
4204         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
4205         (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
4206
4207 2011-09-01  Eric Seidel  <eric@webkit.org>
4208
4209         REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
4210         https://bugs.webkit.org/show_bug.cgi?id=66228
4211
4212         Reviewed by Dirk Pranke.
4213
4214         ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
4215         The LeaksViewer tool globs for all *-leaks.txt files.
4216         This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
4217
4218         In order to test this I had to fix a limitation in our MockFileSystem.glob
4219         method.  However, doing so uncovered a typo and bug in the integration tests.
4220         I've disabled the offending integration tests.
4221
4222         * Scripts/webkitpy/common/system/filesystem_mock.py:
4223         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
4224         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
4225
4226 2011-09-01  Dominic Mazzoni  <dmazzoni@google.com>
4227
4228         Adds a LayoutTestController method to make it possible to test
4229         starting speech input via an API call.
4230         https://bugs.webkit.org/show_bug.cgi?id=60170
4231
4232         Reviewed by Dimitri Glazkov.
4233
4234         * DumpRenderTree/LayoutTestController.h:
4235         * DumpRenderTree/chromium/LayoutTestController.cpp:
4236         (LayoutTestController::LayoutTestController):
4237         (LayoutTestController::startSpeechInput):
4238         * DumpRenderTree/chromium/LayoutTestController.h:
4239         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
4240         (LayoutTestController::startSpeechInput):
4241         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4242         (LayoutTestController::startSpeechInput):
4243         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
4244         (LayoutTestController::startSpeechInput):
4245         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
4246         (LayoutTestController::startSpeechInput):
4247         * DumpRenderTree/qt/LayoutTestControllerQt.h:
4248         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
4249         (LayoutTestController::startSpeechInput):
4250         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
4251         (LayoutTestController::startSpeechInput):
4252
4253 2011-09-01  Tim Horton  <hortont424@gmail.com>
4254
4255         Fix TestWebKitAPI build on clang-2.0
4256
4257         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
4258
4259 2011-09-01  Adam Barth  <abarth@webkit.org>
4260
4261         Remove unused "extension" parameter from rebaseline gardeningserver handler
4262         https://bugs.webkit.org/show_bug.cgi?id=67384
4263
4264         Reviewed by James Robinson.
4265
4266         This parameter hasn't done anything in a while.
4267
4268         * Scripts/webkitpy/tool/commands/rebaseline.py:
4269         * Scripts/webkitpy/tool/servers/gardeningserver.py:
4270         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
4271
4272 2011-09-01  Eric Seidel  <eric@webkit.org>
4273
4274         Unreviewed.
4275
4276         Fix a typo in unittests.  Unfortunately fixing it
4277         caused several assertions.  Just disabling the test
4278         instead, since it was providing no value before due to the typo.
4279
4280         * Scripts/webkitpy/layout_tests/port/test.py:
4281
4282 2011-09-01  Adam Barth  <abarth@webkit.org>
4283
4284         Add a "rebaseline" button to the garden-o-matic summary page
4285         https://bugs.webkit.org/show_bug.cgi?id=67382
4286
4287         Reviewed by Dimitri Glazkov.
4288
4289         As much as we might wish folks to not rebaseline entire test groups at
4290         once, the truth is that doing so is a common operation.  Adding a
4291         button for this operation is likely to make folks happy.
4292
4293         This patch also cleans up a bunch of plumbing surrounding failureInfo
4294         objects.
4295
4296         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
4297         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
4298         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
4299         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
4300         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
4301         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
4302         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
4303         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
4304         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
4305         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
4306
4307 2011-09-01  Adam Barth  <abarth@webkit.org>
4308
4309         garden-o-matic should let the gardener assign blame for a group of test failures
4310         https://bugs.webkit.org/show_bug.cgi?id=67379
4311
4312         Reviewed by Dimitri Glazkov.
4313
4314         If a group of test failures has a large revision range, the gardener
4315         might wish to blame a specific revision for the failure.  Currently,
4316         this only effect of assigning blame in this way is to hide the other
4317         suspect commits.
4318
4319         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
4320         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
4321         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
4322
4323 2011-09-01  Adam Barth  <abarth@webkit.org>
4324
4325         Hide garden-o-matic failure table until hover
4326         https://bugs.webkit.org/show_bug.cgi?id=67376
4327
4328         Reviewed by Dimitri Glazkov.
4329
4330         This patch removes the failure table for build failures (because it
4331         does not make sense) and hides the failure table for test groups until
4332         the user hovers over the test failure block, reducing visual noise.
4333
4334         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
4335         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
4336         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
4337
4338 2011-09-01  Adam Barth  <abarth@webkit.org>