Prepare to move manual-tests out of WebCore
[WebKit-https.git] / Tools / ChangeLog
1 2011-11-18  Adam Barth  <abarth@webkit.org>
2
3         Prepare to move manual-tests out of WebCore
4         https://bugs.webkit.org/show_bug.cgi?id=72782
5
6         Reviewed by Eric Seidel.
7
8         Update this file to refer to the new location of ManualTests.
9
10         * Scripts/webkitpy/common/config/build.py:
11
12 2011-11-18  James Robinson  <jamesr@chromium.org>
13
14         [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
15         https://bugs.webkit.org/show_bug.cgi?id=72778
16
17         Reviewed by Kenneth Russell.
18
19         Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
20
21         * DumpRenderTree/chromium/EventSender.cpp:
22         (EventSender::scalePageBy):
23
24 2011-11-18  Scott Graham  <scottmg@chromium.org>
25
26         IDL changes for gamepad support
27         https://bugs.webkit.org/show_bug.cgi?id=71753
28
29         Reviewed by Adam Barth.
30
31         Runtime enable gamepad in chromium test shell.
32
33         * DumpRenderTree/chromium/TestShell.cpp:
34         (TestShell::TestShell):
35
36 2011-10-27  Darin Fisher  <darin@chromium.org>
37
38         [chromium] Improve fullscreen API
39         https://bugs.webkit.org/show_bug.cgi?id=70477
40
41         Reviewed by Adam Barth.
42
43         Implement enter/exitFullScreen.  The implementation is asynchronous,
44         via postDelayedTask, to simulate how the browser actually behaves.
45
46         * DumpRenderTree/chromium/WebViewHost.cpp:
47         (WebViewHost::enterFullScreen):
48         (WebViewHost::exitFullScreen):
49         (WebViewHost::setAddressBarURL):
50         (WebViewHost::enterFullScreenNow):
51         (WebViewHost::exitFullScreenNow):
52         * DumpRenderTree/chromium/WebViewHost.h:
53
54 2011-11-18  Adam Roben  <aroben@apple.com>
55
56         Ignore an ANGLE leak that is not WebKit's fault
57
58         * Scripts/old-run-webkit-tests:
59         (countAndPrintLeaks):
60         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
61         (LeakDetector._callstacks_to_exclude_from_leaks):
62         Added ScanFromString to the call stacks to exclude on all OS versions.
63
64 2011-11-18  Adam Roben  <aroben@apple.com>
65
66         Ignore another Lion-specific leak that is not WebKit's fault
67
68         * Scripts/old-run-webkit-tests:
69         (countAndPrintLeaks):
70         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
71         (LeakDetector._callstacks_to_exclude_from_leaks):
72         Added SecTransformExecute to the call stacks to exclude.
73
74 2011-11-18  Yuta Kitamura  <yutak@chromium.org>
75
76         [Qt] Enable WebSocket hybi tests
77         https://bugs.webkit.org/show_bug.cgi?id=72687
78
79         Reviewed by Simon Hausmann.
80
81         Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
82
83         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
84         (WebCore::WebPage::resetSettings):
85         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
86         (LayoutTestController::overridePreference):
87
88 2011-11-18  Sergio Villar Senin  <svillar@igalia.com>
89
90         [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
91         https://bugs.webkit.org/show_bug.cgi?id=72707
92
93         Reviewed by Philippe Normand.
94
95         Make new-run-webkit-tests use the right path to locate the test
96         plugin used by WebKitTestRunner.
97
98         * Scripts/webkitpy/layout_tests/port/gtk.py:
99
100 2011-11-18  Simon Hausmann  <simon.hausmann@nokia.com>
101
102         [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
103         https://bugs.webkit.org/show_bug.cgi?id=72697
104
105         Reviewed by Kenneth Rohde Christiansen.
106
107         * Tools.pro: Make WTR linux only for the moment.
108         * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
109         * WebKitTestRunner/Target.pri: Ditto.
110         * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
111         with ELF visibility on Linux. Instead we're temporarily using an LD version script.
112
113 2011-11-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
114
115         [Qt] Change default size of the MiniBrowser
116
117         Reviewed by Simon Hausmann.
118
119         As we lay out desktop pages using the width of 980, change our default
120         size to 980x735 so that we are not scaling down by default.
121
122         * MiniBrowser/qt/MiniBrowserApplication.h:
123         (WindowOptions::WindowOptions):
124
125 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
126
127         [EFL] Clean up the use of DATA_DIR in the buildsystem
128         https://bugs.webkit.org/show_bug.cgi?id=72681
129
130         Reviewed by Daniel Bates.
131
132         Instead of adding -DDATA_DIR in all scopes, only define it in
133         WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
134         it.
135
136         We can then define DATA_DIR to the generated theme directory for
137         EWebLauncher, since it's what we want here.
138
139         * CMakeListsEfl.txt:
140
141 2011-11-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
142
143         [EFL] Move platform includes last in DRT's include directories.
144         https://bugs.webkit.org/show_bug.cgi?id=72684
145
146         Reviewed by Daniel Bates.
147
148         This is the first step in fixing the build when a platform include (in
149         this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
150         is included instead of WebKit's.
151
152         * DumpRenderTree/efl/CMakeLists.txt:
153
154 2011-11-17  Ryosuke Niwa  <rniwa@webkit.org>
155
156         fuzzy_match doesn't recognize "Dan B" or "hyatt"
157         https://bugs.webkit.org/show_bug.cgi?id=72636
158
159         Reviewed by Eric Seidel.
160
161         Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
162         and user names of email addreses such as rniwa in rniwa@webkit.org.
163
164         Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
165
166         * Scripts/webkitpy/common/config/committers.py:
167         * Scripts/webkitpy/common/config/committers_unittest.py:
168
169 2011-11-17  Eric Seidel  <eric@webkit.org>
170
171         Remove support for running check-webkit-style w/o a webkit checkout
172         https://bugs.webkit.org/show_bug.cgi?id=72678
173
174         Reviewed by Adam Barth.
175
176         After talking to Dave Levin we've decided to remove this
177         code.  I know of no users of check-webkit-style w/o a webkit checkout
178         and this needlessly adds complexity.
179
180         * Scripts/webkitpy/style/main.py:
181
182 2011-11-17  Eric Seidel  <eric@webkit.org>
183
184         Remove more direct uses of os.path
185         https://bugs.webkit.org/show_bug.cgi?id=72677
186
187         Reviewed by Adam Barth.
188
189         Remove more uses of os.path, including refactoring
190         CommitterValidator to use a Host object instead of
191         manual hacks to emulate what SCM and FileSystem provide.
192
193         * Scripts/webkitpy/common/checkout/changelog.py:
194         * Scripts/webkitpy/common/config/committervalidator.py:
195         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
196         * Scripts/webkitpy/common/system/filesystem_mock.py:
197          - Turns out none of our unittests actually looked at this path.
198            now I've made it be a valid path.
199         * Scripts/webkitpy/tool/bot/feeders.py:
200         * Scripts/webkitpy/tool/commands/queues.py:
201
202 2011-11-17  Eric Seidel  <eric@webkit.org>
203
204         Teach TextFileReader about FileSystem
205         https://bugs.webkit.org/show_bug.cgi?id=72673
206
207         Reviewed by Adam Barth.
208
209         Unfortunately TextFileReader doesn't use FileSystem
210         everywhere yet, so we can't move the unittests to
211         using MockFileSystem, but we're close.
212
213         * Scripts/webkitpy/style/filereader.py:
214         * Scripts/webkitpy/style/filereader_unittest.py:
215         * Scripts/webkitpy/style/main.py:
216
217 2011-11-17  Eric Seidel  <eric@webkit.org>
218
219         Give check-webkit-style a Host
220         https://bugs.webkit.org/show_bug.cgi?id=72670
221
222         Reviewed by Adam Barth.
223
224         * Scripts/webkitpy/common/checkout/scm/detection.py:
225         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
226          - We don't run these unittests, but this one was looking for the wrong exception.
227         * Scripts/webkitpy/style/main.py:
228         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
229          - This was create a new scm object even though it already had one?
230
231 2011-11-17  Eric Seidel  <eric@webkit.org>
232
233         Move check-webkit-style change_directory code to more modern mocks
234         https://bugs.webkit.org/show_bug.cgi?id=72664
235
236         Reviewed by Adam Barth.
237
238         * Scripts/check-webkit-style:
239         * Scripts/webkitpy/style/main.py:
240         * Scripts/webkitpy/style/main_unittest.py:
241
242 2011-11-17  Zan Dobersek  <zandobersek@gmail.com>
243
244         [GTK] enable ref tests
245         https://bugs.webkit.org/show_bug.cgi?id=72601
246
247         Re-enable ref tests. Run the driver under evenly numbered display if performing
248         pixel tests or under oddly numbered display otherwise. This prevents the ref tests
249         being run in an already used Xvfb instance if pixel tests are disabled.
250
251         Reviewed by Tony Chang.
252
253         * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
254         after the process is killed
255
256 2011-11-17  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
257
258         Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
259         https://bugs.webkit.org/show_bug.cgi?id=72620
260
261         Reviewed by David Levin.
262
263         Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
264         adding the suffix the cpp file. One example of false positive
265         https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
266
267         * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
268         basename contains the cpp's basename.
269         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
270
271 2011-11-17  Eric Seidel  <eric@webkit.org>
272
273         Move check-webkit-style's guts into webkitpy/style/main.py
274         https://bugs.webkit.org/show_bug.cgi?id=72657
275
276         Reviewed by Adam Barth.
277
278         * Scripts/check-webkit-style:
279         * Scripts/webkitpy/style/main.py:
280
281 2011-11-17  Eric Seidel  <eric@webkit.org>
282
283         new-run-webkit-tests is locale dependent
284         https://bugs.webkit.org/show_bug.cgi?id=68691
285
286         Reviewed by Adam Barth.
287
288         Make NRWT use a clean environment, just like ORWT did.
289
290         * Scripts/webkitpy/layout_tests/port/base.py:
291         * Scripts/webkitpy/layout_tests/port/chromium.py:
292         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
293         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
294         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
295         * Scripts/webkitpy/layout_tests/port/efl.py:
296         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
297         * Scripts/webkitpy/layout_tests/port/mac.py:
298         * Scripts/webkitpy/layout_tests/port/qt.py:
299         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
300         * Scripts/webkitpy/layout_tests/port/webkit.py:
301         * Scripts/webkitpy/layout_tests/port/win.py:
302
303 2011-11-17  Dirk Pranke  <dpranke@chromium.org>
304
305         Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
306         https://bugs.webkit.org/show_bug.cgi?id=72615
307
308         Reviewed by James Robinson.
309
310         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
311
312 2011-11-17  Simon Hausmann  <simon.hausmann@nokia.com>
313
314         [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
315         https://bugs.webkit.org/show_bug.cgi?id=72595
316
317         Reviewed by Noam Rosenthal.
318
319         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
320         (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
321         ensure the registration of the DRTNode JS bindings.
322         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
323         (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
324         registration of QWebElement (now done implicitly through QWebPage ->
325         QtWebElementRunTime::initialize code path)
326
327 2011-11-17  Adam Roben  <aroben@apple.com>
328
329         Fix a crash-inducing typo I introduced in r100648
330
331         Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
332         handling a crashing test
333
334         Reviewed by Adam Barth.
335
336         * Scripts/webkitpy/layout_tests/port/chromium.py:
337         (ChromiumDriver.run_test): Get the driver name from the port.
338
339         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
340         (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
341         right crashed process name.
342
343 2011-11-17  Adam Roben  <aroben@apple.com>
344
345         Fix NRWT's parsing of the number of excluded leaks
346
347         Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
348         leaks were excluded
349
350         Reviewed by Adam Barth.
351
352         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
353         (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
354         regular expression match, not the entire matched string.
355
356         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
357         (LeakDetectorTest): Added some example output that shows how things look when leaks are
358         excluded.
359         (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
360         correctly.
361
362 2011-11-17  Adam Roben  <aroben@apple.com>
363
364         Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
365
366         Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
367         when web process crashes, but WebProcess crash log should get saved instead
368
369         Reviewed by Eric Seidel.
370
371         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
372         (write_test_result): Simplified a little to share more code between the case where we
373         crashed when running the test and where we crashed when checking the expected rendering for
374         a reftest. Changed to pass the crashed process name down to write_crash_report.
375         (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
376         along to CrashLogs.find_newest_log rather than always using the driver name.
377
378         * Scripts/webkitpy/layout_tests/port/chromium.py:
379         (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
380         crashed.
381
382         * Scripts/webkitpy/layout_tests/port/test.py:
383         (TestInstance.__init__): Initialize new web_process_crash attribute.
384         (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
385         test this patch adds.
386         (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
387         specifies that the driver crashed or the web process crashed.
388
389         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
390         (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
391         which we pretend the web process crashed rather than the driver process.
392
393         (MainTest.test_run_singly_actually_runs_tests):
394         (MainTest.test_unexpected_failures):
395         (EndToEndTest.test_end_to_end):
396         Updated magic numbers to account for new unexpected failing test added to unit_test_list.
397
398 2011-11-17  Tony Chang  <tony@chromium.org>
399
400         [chromium] stop spamming features warning on every build
401         https://bugs.webkit.org/show_bug.cgi?id=72629
402
403         Reviewed by Ojan Vafai.
404
405         We toggle $blobSupport on if $mediaStreamSupport is on.  Since
406         $mediaStreamSupport is on by default for chromium, make the default
407         for $blobSupport also on.
408
409         * Scripts/build-webkit:
410
411 2011-11-17  Adam Roben  <aroben@apple.com>
412
413         Remove extra quoting of call stacks and types passed to run-leaks by NRWT
414
415         Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
416         that are supposed to be ignored
417
418         Reviewed by Adam Barth.
419
420         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
421         (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
422         required when passing arguments via the shell (which we aren't doing here). It is not
423         required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
424
425         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
426         (LeakDetectorTest.test_leaks_args): Updated expectations.
427
428 2011-11-17  Philippe Normand  <pnormand@igalia.com>
429
430         Unreviewed, run-bindings-tests fix after r91028.
431
432         * Scripts/run-bindings-tests: Use scm.detection module.
433
434 2011-11-17  Jochen Eisinger  <jochen@chromium.org>
435
436         Silence a warning about control reaching the end of a non-void function
437         https://bugs.webkit.org/show_bug.cgi?id=72616
438
439         Reviewed by Tony Gentilcore.
440
441         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
442         (AccessibilityUIElement::verticalScrollbar):
443
444 2011-11-17  Adam Roben  <aroben@apple.com>
445
446         Ignore some leaks in frameworks we link against on Lion
447
448         Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
449         aren't WebKit's fault
450
451         Reviewed by Antti Koivisto.
452
453         * Scripts/old-run-webkit-tests:
454         (countAndPrintLeaks):
455         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
456         (LeakDetector._callstacks_to_exclude_from_leaks):
457         Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
458
459         * Scripts/webkitpy/layout_tests/port/mac.py:
460         (MacPort.is_lion): Added.
461
462         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
463         (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
464         methods.
465
466 2011-11-17  Philippe Normand  <pnormand@igalia.com>
467
468         [GTK] Disable ref tests
469         https://bugs.webkit.org/show_bug.cgi?id=72599
470
471         Reviewed by Xan Lopez.
472
473         * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
474         tests to avoid massive flakiness.
475
476 2011-11-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
477
478         [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
479
480         A new extension object has been added to QQuickWebView (the same approach should be used
481         for other API classes that need experimental APIs). The QML extension mechanism is then
482         built on top of the experimental object.
483
484         https://bugs.webkit.org/show_bug.cgi?id=72522
485
486         Reviewed by Simon Hausmann.
487
488         * MiniBrowser/qt/BrowserWindow.cpp:
489         (BrowserWindow::BrowserWindow):
490         (BrowserWindow::webView):
491         * MiniBrowser/qt/BrowserWindow.h:
492         * MiniBrowser/qt/UrlLoader.cpp:
493         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
494         * qmake/mkspecs/features/default_post.prf:
495         * qmake/mkspecs/features/default_pre.prf:
496         * qmake/mkspecs/features/qtwebkit-private.prf: Added.
497         * qmake/mkspecs/features/qtwebkit.prf:
498
499 2011-11-17  Adam Barth  <abarth@webkit.org>
500
501         Move test_results_uploader.py out of layout_package
502         https://bugs.webkit.org/show_bug.cgi?id=72590
503
504         Reviewed by Eric Seidel.
505
506         Most of the lines of code in this file are wrong, but I've restrained
507         myself and only changed a few of them to generalized this class to the
508         common package.
509
510         This is part of a series of patches to remove layout_package.
511
512         * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
513         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
514         * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
515
516 2011-11-17  Adam Barth  <abarth@webkit.org>
517
518         Unreviewed. Fix style nits in printing.py.
519
520         * Scripts/webkitpy/layout_tests/views/printing.py:
521
522 2011-11-17  Adam Barth  <abarth@webkit.org>
523
524         Minor style nits in run_webkit_tests.py
525         https://bugs.webkit.org/show_bug.cgi?id=72583
526
527         Reviewed by Eric Seidel.
528
529         This patch just fixes some minor style issues as I work my way back
530         into this code.
531
532         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
533
534 2011-11-17  Adam Barth  <abarth@webkit.org>
535
536         Move test_result_writer out of layout_package
537         https://bugs.webkit.org/show_bug.cgi?id=72586
538
539         Rubber-stamped by Eric Seidel.
540
541         This is part of a series of patches to remove layout_package.
542
543         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
544         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
545         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
546         * Scripts/webkitpy/tool/commands/rebaseline.py:
547
548 2011-11-17  Adam Barth  <abarth@webkit.org>
549
550         svn-apply shouldn't magically move files into Source anymore
551         https://bugs.webkit.org/show_bug.cgi?id=72579
552
553         Reviewed by Eric Seidel.
554
555         The Source directory has existed for long enough that we don't need
556         svn-apply to magically re-write old-style patches anymore.
557
558         * Scripts/VCSUtils.pm:
559         (parseGitDiffHeader):
560         (parseSvnDiffHeader):
561
562 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
563
564         Add a list of contribution areas
565         https://bugs.webkit.org/show_bug.cgi?id=72566
566
567         Reviewed by Eric Seidel.
568
569         Added ContributionAreas class.
570
571         * Scripts/webkitpy/common/config/contributionareas.py: Added.
572         * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
573
574 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
575
576         Refactor ChangeLogTest.test_parse_reviewer_text
577         https://bugs.webkit.org/show_bug.cgi?id=72572
578
579         Reviewed by Eric Seidel.
580
581         Refactored the test code by introduing two helper functions.
582
583         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
584
585 2011-11-16  Eric Seidel  <eric@webkit.org>
586
587         Add SCMDetector object to make scm detection mockable
588         https://bugs.webkit.org/show_bug.cgi?id=72247
589
590         Reviewed by Adam Barth.
591
592         I think SCM detection may eventually be rolled into Checkout,
593         but this patch at least makes it possible to mock code-paths
594         which rely on scm detection.
595         In the process of replacing callers of these free-functions
596         I found that one of the functions was no longer used,
597         and that one of the callers could instead just use the SCM
598         object it already had access to through port.host.scm().
599         I also discovered that I was not calling Host._initialize_scm()
600         and thus host.scm() was always returning None!
601
602         * Scripts/check-webkit-style:
603         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
604         * Scripts/webkitpy/common/checkout/deps.py:
605         * Scripts/webkitpy/common/checkout/scm/__init__.py:
606         * Scripts/webkitpy/common/checkout/scm/detection.py:
607         * Scripts/webkitpy/common/checkout/scm/git.py:
608         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
609         * Scripts/webkitpy/common/checkout/scm/svn.py:
610         * Scripts/webkitpy/common/host.py:
611         * Scripts/webkitpy/common/host_mock.py:
612         * Scripts/webkitpy/layout_tests/controllers/manager.py:
613         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
614         * Scripts/webkitpy/layout_tests/port/base.py:
615         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
616         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
617         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
618         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
619
620 2011-11-16  Mark Rowe  <mrowe@apple.com>
621
622         Fix the build.
623
624         The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
625         Apply the workaround that we use in other projects to WebKitTestRunner.
626
627         * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
628         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
629         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
630
631 2011-11-16  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
632
633         [Qt] Fix build after WTR AX support
634         https://bugs.webkit.org/show_bug.cgi?id=72560
635
636         Reviewed by Geoffrey Garen.
637
638         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
639         * WebKitTestRunner/InjectedBundle/Target.pri:
640
641 2011-11-16  Tony Chang  <tony@chromium.org>
642
643         repurpose the flexbox bot for grid layout
644         https://bugs.webkit.org/show_bug.cgi?id=72557
645
646         Reviewed by Ryosuke Niwa.
647
648         Since new flexbox is enabled everywhere, we don't need this bot
649         anymore.  However, work on grid layout has begun, so we can use this
650         bot to compile with ENABLE_CSS_GRID_LAYOUT.
651
652         * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
653         the bot on the waterfall, I will change the slave config to enable
654         the compile flag and tests.
655
656 2011-11-11  Adrienne Walker  <enne@google.com>
657
658         [chromium] Expose mock scrollbars to window.internals
659         https://bugs.webkit.org/show_bug.cgi?id=72195
660
661         Reviewed by James Robinson.
662
663         Because mock scrollbars are a global setting, reset between runs.
664
665         * DumpRenderTree/chromium/WebPreferences.cpp:
666         (WebPreferences::applyTo):
667
668 2011-11-16  James Robinson  <jamesr@chromium.org>
669
670         [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
671         https://bugs.webkit.org/show_bug.cgi?id=72562
672
673         Reviewed by Dirk Pranke.
674
675         * DumpRenderTree/chromium/TestShell.cpp:
676         (TestShell::runFileTest):
677
678 2011-11-16  Tony Chang  <tony@chromium.org>
679
680         [NRWT] speculative fix for multiple subprocess test on cygwin
681         https://bugs.webkit.org/show_bug.cgi?id=72518
682
683         Reviewed by Adam Barth.
684
685         * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
686             tries to emulate posix fd behavior.
687         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
688
689 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
690
691         Revert r100509; change was committed twice (first time as r100491).
692         Unreviewed, build fix.
693
694         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
695
696 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
697
698         Run a dummy test in the gpu configurations if there's nothing to do.
699         https://bugs.webkit.org/show_bug.cgi?id=72498
700
701         Reviewed by James Robinson.
702
703         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
704
705 2011-11-16  Ryosuke Niwa  <rniwa@webkit.org>
706
707         contributors_by_fuzzy_match is super slow
708         https://bugs.webkit.org/show_bug.cgi?id=72540
709
710         Reviewed by Eric Seidel.
711
712         Make contributors_by_name do case insensitive search using a dictionary.
713
714         Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
715         because that's the most common case.
716
717         * Scripts/webkitpy/common/config/committers.py:
718         * Scripts/webkitpy/common/config/committers_unittest.py:
719
720 2011-11-16  David Levin  <levin@chromium.org>
721
722         check-webkit-style should recognize functions even if they have OVERRIDE after them.
723         https://bugs.webkit.org/show_bug.cgi?id=72515
724
725         Reviewed by Adam Barth.
726
727         * Scripts/webkitpy/style/checkers/cpp.py:
728         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
729
730 2011-11-16  Tony Chang  <tony@chromium.org>
731
732         [NRWT] refactor drivers to require pixel_tests param
733         https://bugs.webkit.org/show_bug.cgi?id=72517
734
735         Reviewed by Ojan Vafai.
736
737         No tests, just a refactoring.
738
739         * Scripts/webkitpy/layout_tests/port/chromium.py:
740         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
741         * Scripts/webkitpy/layout_tests/port/webkit.py:
742         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
743
744 2011-11-16  Dirk Pranke  <dpranke@chromium.org>
745
746         Run a dummy test in the gpu configurations if there's nothing to do.
747         https://bugs.webkit.org/show_bug.cgi?id=72498
748
749         Reviewed by James Robinson.
750
751         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
752
753 2011-11-16  Chris Fleizach  <cfleizach@apple.com>
754
755         WebKitTestRunner needs to support accessibility-related DRT APIs
756         https://bugs.webkit.org/show_bug.cgi?id=42131
757
758         Reviewed by Beth Dakin.
759
760         Port the AX code in DRT to WKTestRunner by using IDL.
761
762         * DumpRenderTree/AccessibilityUIElement.cpp:
763         (horizontalScrollbarCallback):
764         (verticalScrollbarCallback):
765         (AccessibilityUIElement::horizontalScrollbar):
766         (AccessibilityUIElement::verticalScrollbar):
767         (AccessibilityUIElement::getJSClass):
768         * DumpRenderTree/AccessibilityUIElement.h:
769         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
770         (AccessibilityUIElement::horizontalScrollbar):
771         (AccessibilityUIElement::verticalScrollbar):
772         * WebKitTestRunner/DerivedSources.make:
773         * WebKitTestRunner/GNUmakefile.am:
774         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
775         (WTR::AccessibilityController::create):
776         (WTR::AccessibilityController::AccessibilityController):
777         (WTR::AccessibilityController::~AccessibilityController):
778         (WTR::AccessibilityController::makeWindowObject):
779         (WTR::AccessibilityController::wrapperClass):
780         (WTR::AccessibilityController::rootElement):
781         (WTR::AccessibilityController::focusedElement):
782         (WTR::AccessibilityController::elementAtPoint):
783         * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
784         (WTR::AccessibilityController::logFocusEvents):
785         (WTR::AccessibilityController::logValueChangeEvents):
786         (WTR::AccessibilityController::logScrollingStartEvents):
787         (WTR::AccessibilityController::logAccessibilityEvents):
788         (WTR::AccessibilityController::addNotificationListener):
789         (WTR::AccessibilityController::notificationReceived):
790         (WTR::AccessibilityController::resetToConsistentState):
791         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
792         (WTR::AccessibilityTextMarker::create):
793         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
794         (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
795         (WTR::AccessibilityTextMarker::platformTextMarker):
796         (WTR::AccessibilityTextMarker::wrapperClass):
797         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
798         (WTR::AccessibilityTextMarker::isEqual):
799         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
800         (WTR::AccessibilityTextMarkerRange::create):
801         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
802         (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
803         (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
804         (WTR::AccessibilityTextMarkerRange::wrapperClass):
805         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
806         (WTR::AccessibilityTextMarkerRange::isEqual):
807         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
808         (WTR::AccessibilityUIElement::create):
809         (WTR::AccessibilityUIElement::wrapperClass):
810         (WTR::AccessibilityUIElement::isValid):
811         (WTR::AccessibilityUIElement::AccessibilityUIElement):
812         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
813         (WTR::AccessibilityUIElement::isEqual):
814         (WTR::AccessibilityUIElement::elementAtPoint):
815         (WTR::AccessibilityUIElement::childAtIndex):
816         (WTR::AccessibilityUIElement::indexOfChild):
817         (WTR::AccessibilityUIElement::childrenCount):
818         (WTR::AccessibilityUIElement::titleUIElement):
819         (WTR::AccessibilityUIElement::parentElement):
820         (WTR::AccessibilityUIElement::takeFocus):
821         (WTR::AccessibilityUIElement::takeSelection):
822         (WTR::AccessibilityUIElement::addSelection):
823         (WTR::AccessibilityUIElement::removeSelection):
824         (WTR::AccessibilityUIElement::allAttributes):
825         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
826         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
827         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
828         (WTR::AccessibilityUIElement::attributesOfChildren):
829         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
830         (WTR::AccessibilityUIElement::increment):
831         (WTR::AccessibilityUIElement::decrement):
832         (WTR::AccessibilityUIElement::showMenu):
833         (WTR::AccessibilityUIElement::press):
834         (WTR::AccessibilityUIElement::stringAttributeValue):
835         (WTR::AccessibilityUIElement::uiElementAttributeValue):
836         (WTR::AccessibilityUIElement::numberAttributeValue):
837         (WTR::AccessibilityUIElement::boolAttributeValue):
838         (WTR::AccessibilityUIElement::isAttributeSupported):
839         (WTR::AccessibilityUIElement::isAttributeSettable):
840         (WTR::AccessibilityUIElement::isActionSupported):
841         (WTR::AccessibilityUIElement::role):
842         (WTR::AccessibilityUIElement::subrole):
843         (WTR::AccessibilityUIElement::roleDescription):
844         (WTR::AccessibilityUIElement::title):
845         (WTR::AccessibilityUIElement::description):
846         (WTR::AccessibilityUIElement::language):
847         (WTR::AccessibilityUIElement::stringValue):
848         (WTR::AccessibilityUIElement::accessibilityValue):
849         (WTR::AccessibilityUIElement::helpText):
850         (WTR::AccessibilityUIElement::orientation):
851         (WTR::AccessibilityUIElement::x):
852         (WTR::AccessibilityUIElement::y):
853         (WTR::AccessibilityUIElement::width):
854         (WTR::AccessibilityUIElement::height):
855         (WTR::AccessibilityUIElement::intValue):
856         (WTR::AccessibilityUIElement::minValue):
857         (WTR::AccessibilityUIElement::maxValue):
858         (WTR::AccessibilityUIElement::valueDescription):
859         (WTR::AccessibilityUIElement::insertionPointLineNumber):
860         (WTR::AccessibilityUIElement::selectedTextRange):
861         (WTR::AccessibilityUIElement::isEnabled):
862         (WTR::AccessibilityUIElement::isRequired):
863         (WTR::AccessibilityUIElement::isFocused):
864         (WTR::AccessibilityUIElement::isFocusable):
865         (WTR::AccessibilityUIElement::isSelected):
866         (WTR::AccessibilityUIElement::isSelectable):
867         (WTR::AccessibilityUIElement::isMultiSelectable):
868         (WTR::AccessibilityUIElement::setSelectedChild):
869         (WTR::AccessibilityUIElement::selectedChildrenCount):
870         (WTR::AccessibilityUIElement::selectedChildAtIndex):
871         (WTR::AccessibilityUIElement::isExpanded):
872         (WTR::AccessibilityUIElement::isChecked):
873         (WTR::AccessibilityUIElement::isVisible):
874         (WTR::AccessibilityUIElement::isOffScreen):
875         (WTR::AccessibilityUIElement::isCollapsed):
876         (WTR::AccessibilityUIElement::isIgnored):
877         (WTR::AccessibilityUIElement::hasPopup):
878         (WTR::AccessibilityUIElement::hierarchicalLevel):
879         (WTR::AccessibilityUIElement::clickPointX):
880         (WTR::AccessibilityUIElement::clickPointY):
881         (WTR::AccessibilityUIElement::documentEncoding):
882         (WTR::AccessibilityUIElement::documentURI):
883         (WTR::AccessibilityUIElement::url):
884         (WTR::AccessibilityUIElement::speak):
885         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
886         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
887         (WTR::AccessibilityUIElement::attributesOfColumns):
888         (WTR::AccessibilityUIElement::attributesOfRows):
889         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
890         (WTR::AccessibilityUIElement::attributesOfHeader):
891         (WTR::AccessibilityUIElement::indexInTable):
892         (WTR::AccessibilityUIElement::rowIndexRange):
893         (WTR::AccessibilityUIElement::columnIndexRange):
894         (WTR::AccessibilityUIElement::rowCount):
895         (WTR::AccessibilityUIElement::columnCount):
896         (WTR::AccessibilityUIElement::selectedRowAtIndex):
897         (WTR::AccessibilityUIElement::disclosedByRow):
898         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
899         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
900         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
901         (WTR::AccessibilityUIElement::ariaIsGrabbed):
902         (WTR::AccessibilityUIElement::ariaDropEffects):
903         (WTR::AccessibilityUIElement::lineForIndex):
904         (WTR::AccessibilityUIElement::rangeForLine):
905         (WTR::AccessibilityUIElement::boundsForRange):
906         (WTR::AccessibilityUIElement::setSelectedTextRange):
907         (WTR::AccessibilityUIElement::stringForRange):
908         (WTR::AccessibilityUIElement::attributedStringForRange):
909         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
910         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
911         (WTR::AccessibilityUIElement::cellForColumnAndRow):
912         (WTR::AccessibilityUIElement::horizontalScrollbar):
913         (WTR::AccessibilityUIElement::verticalScrollbar):
914         (WTR::AccessibilityUIElement::addNotificationListener):
915         (WTR::AccessibilityUIElement::removeNotificationListener):
916         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
917         (WTR::AccessibilityUIElement::textMarkerRangeLength):
918         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
919         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
920         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
921         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
922         (WTR::AccessibilityUIElement::textMarkerForPoint):
923         (WTR::AccessibilityUIElement::previousTextMarker):
924         (WTR::AccessibilityUIElement::nextTextMarker):
925         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
926         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
927         (WTR::AccessibilityUIElement::platformUIElement):
928         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
929         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
930         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
931         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
932         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
933         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
934         (WTR::InjectedBundle::beginTesting):
935         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
936         (WTR::InjectedBundle::accessibilityController):
937         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
938         (WTR::InjectedBundlePage::didClearWindowForFrame):
939         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
940         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
941         (WTR::LayoutTestController::platformName):
942         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
943         (WTR::AccessibilityTextMarker::isEqual):
944         * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
945         (WTR::AccessibilityTextMarkerRange::isEqual):
946         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
947         (+[NSString stringWithJSStringRef:]):
948         (-[NSString createJSStringRef]):
949         (-[AccessibilityNotificationHandler initWithPlatformElement:]):
950         (-[AccessibilityNotificationHandler dealloc]):
951         (-[AccessibilityNotificationHandler _notificationReceived:]):
952         (-[AccessibilityNotificationHandler setCallback:]):
953         (WTR::AccessibilityUIElement::AccessibilityUIElement):
954         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
955         (WTR::AccessibilityUIElement::isEqual):
956         (WTR::descriptionOfValue):
957         (WTR::attributesOfElement):
958         (WTR::concatenateAttributeAndValue):
959         (WTR::convertNSArrayToVector):
960         (WTR::descriptionOfElements):
961         (WTR::AccessibilityUIElement::getLinkedUIElements):
962         (WTR::AccessibilityUIElement::getDocumentLinks):
963         (WTR::AccessibilityUIElement::getChildren):
964         (WTR::AccessibilityUIElement::getChildrenWithRange):
965         (WTR::AccessibilityUIElement::childrenCount):
966         (WTR::AccessibilityUIElement::elementAtPoint):
967         (WTR::AccessibilityUIElement::indexOfChild):
968         (WTR::AccessibilityUIElement::childAtIndex):
969         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
970         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
971         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
972         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
973         (WTR::AccessibilityUIElement::selectedChildAtIndex):
974         (WTR::AccessibilityUIElement::selectedChildrenCount):
975         (WTR::AccessibilityUIElement::selectedRowAtIndex):
976         (WTR::AccessibilityUIElement::titleUIElement):
977         (WTR::AccessibilityUIElement::parentElement):
978         (WTR::AccessibilityUIElement::disclosedByRow):
979         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
980         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
981         (WTR::AccessibilityUIElement::attributesOfChildren):
982         (WTR::AccessibilityUIElement::allAttributes):
983         (WTR::AccessibilityUIElement::stringAttributeValue):
984         (WTR::AccessibilityUIElement::numberAttributeValue):
985         (WTR::AccessibilityUIElement::uiElementAttributeValue):
986         (WTR::AccessibilityUIElement::boolAttributeValue):
987         (WTR::AccessibilityUIElement::isAttributeSettable):
988         (WTR::AccessibilityUIElement::isAttributeSupported):
989         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
990         (WTR::AccessibilityUIElement::role):
991         (WTR::AccessibilityUIElement::subrole):
992         (WTR::AccessibilityUIElement::roleDescription):
993         (WTR::AccessibilityUIElement::title):
994         (WTR::AccessibilityUIElement::description):
995         (WTR::AccessibilityUIElement::orientation):
996         (WTR::AccessibilityUIElement::stringValue):
997         (WTR::AccessibilityUIElement::language):
998         (WTR::AccessibilityUIElement::helpText):
999         (WTR::AccessibilityUIElement::x):
1000         (WTR::AccessibilityUIElement::y):
1001         (WTR::AccessibilityUIElement::width):
1002         (WTR::AccessibilityUIElement::height):
1003         (WTR::AccessibilityUIElement::clickPointX):
1004         (WTR::AccessibilityUIElement::clickPointY):
1005         (WTR::AccessibilityUIElement::intValue):
1006         (WTR::AccessibilityUIElement::minValue):
1007         (WTR::AccessibilityUIElement::maxValue):
1008         (WTR::AccessibilityUIElement::valueDescription):
1009         (WTR::AccessibilityUIElement::insertionPointLineNumber):
1010         (WTR::AccessibilityUIElement::isActionSupported):
1011         (WTR::AccessibilityUIElement::isEnabled):
1012         (WTR::AccessibilityUIElement::isRequired):
1013         (WTR::AccessibilityUIElement::isFocused):
1014         (WTR::AccessibilityUIElement::isSelected):
1015         (WTR::AccessibilityUIElement::isExpanded):
1016         (WTR::AccessibilityUIElement::isChecked):
1017         (WTR::AccessibilityUIElement::hierarchicalLevel):
1018         (WTR::AccessibilityUIElement::speak):
1019         (WTR::AccessibilityUIElement::ariaIsGrabbed):
1020         (WTR::AccessibilityUIElement::ariaDropEffects):
1021         (WTR::AccessibilityUIElement::lineForIndex):
1022         (WTR::AccessibilityUIElement::rangeForLine):
1023         (WTR::AccessibilityUIElement::boundsForRange):
1024         (WTR::AccessibilityUIElement::stringForRange):
1025         (WTR::AccessibilityUIElement::attributedStringForRange):
1026         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1027         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1028         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
1029         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
1030         (WTR::AccessibilityUIElement::attributesOfColumns):
1031         (WTR::AccessibilityUIElement::attributesOfRows):
1032         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
1033         (WTR::AccessibilityUIElement::attributesOfHeader):
1034         (WTR::AccessibilityUIElement::rowCount):
1035         (WTR::AccessibilityUIElement::columnCount):
1036         (WTR::AccessibilityUIElement::indexInTable):
1037         (WTR::AccessibilityUIElement::rowIndexRange):
1038         (WTR::AccessibilityUIElement::columnIndexRange):
1039         (WTR::AccessibilityUIElement::cellForColumnAndRow):
1040         (WTR::AccessibilityUIElement::horizontalScrollbar):
1041         (WTR::AccessibilityUIElement::verticalScrollbar):
1042         (WTR::AccessibilityUIElement::selectedTextRange):
1043         (WTR::AccessibilityUIElement::setSelectedTextRange):
1044         (WTR::AccessibilityUIElement::increment):
1045         (WTR::AccessibilityUIElement::decrement):
1046         (WTR::AccessibilityUIElement::showMenu):
1047         (WTR::AccessibilityUIElement::press):
1048         (WTR::AccessibilityUIElement::setSelectedChild):
1049         (WTR::AccessibilityUIElement::accessibilityValue):
1050         (WTR::AccessibilityUIElement::documentEncoding):
1051         (WTR::AccessibilityUIElement::documentURI):
1052         (WTR::AccessibilityUIElement::url):
1053         (WTR::AccessibilityUIElement::addNotificationListener):
1054         (WTR::AccessibilityUIElement::removeNotificationListener):
1055         (WTR::AccessibilityUIElement::isFocusable):
1056         (WTR::AccessibilityUIElement::isSelectable):
1057         (WTR::AccessibilityUIElement::isMultiSelectable):
1058         (WTR::AccessibilityUIElement::isVisible):
1059         (WTR::AccessibilityUIElement::isOffScreen):
1060         (WTR::AccessibilityUIElement::isCollapsed):
1061         (WTR::AccessibilityUIElement::isIgnored):
1062         (WTR::AccessibilityUIElement::hasPopup):
1063         (WTR::AccessibilityUIElement::takeFocus):
1064         (WTR::AccessibilityUIElement::takeSelection):
1065         (WTR::AccessibilityUIElement::addSelection):
1066         (WTR::AccessibilityUIElement::removeSelection):
1067         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1068         (WTR::AccessibilityUIElement::textMarkerRangeLength):
1069         (WTR::AccessibilityUIElement::previousTextMarker):
1070         (WTR::AccessibilityUIElement::nextTextMarker):
1071         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
1072         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
1073         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
1074         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
1075         (WTR::AccessibilityUIElement::textMarkerForPoint):
1076         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
1077         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
1078         (WTR::LayoutTestController::platformName):
1079         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1080         (WTR::LayoutTestController::platformName):
1081         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
1082         (WTR::LayoutTestController::platformName):
1083         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1084         * WebKitTestRunner/win/InjectedBundle.vcproj:
1085
1086 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1087
1088         [Qt] Fix use of config.tests
1089
1090         We were checking @buildArgs to determine if the optional argument was
1091         passed or not, but this is not the right way to do that in Perl. The
1092         right way is to not use a prototype for the function, and to pass
1093         the list as a reference (to avoid list expansion). That way we can
1094         check the number of arguments, and choose the right code path based
1095         on that.
1096
1097         We were also missing a default-value of 0 for any feature that's not
1098         set in features.prf.
1099
1100         Reviewed by Kenneth Rohde Christiansen.
1101
1102         * Scripts/build-webkit:
1103         * Scripts/webkitdirs.pm:
1104         (qtFeatureDefaults):
1105         (buildQMakeProject):
1106
1107 2011-11-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1108
1109         [Qt] Prospective fix for broken plugin tests
1110
1111         Don't hide symbols for the NPAPI test plugin
1112
1113         Rubber-stamped by Andreas Kling.
1114
1115         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1116
1117 2011-11-16  Adam Roben  <aroben@apple.com>
1118
1119         Move filenames/line numbers off to the right edge in Leaks Viewer
1120
1121         Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
1122         because filenames/line numbers are right next to function names
1123
1124         Reviewed by Andreas Kling.
1125
1126         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
1127         (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
1128         function name. Use the filename as the profile node's URL (we don't have enough info to
1129         compute a real URL currently) and the line number as the profile node's line number so the
1130         Inspector code will put them on the right side of the callstack graph.
1131
1132         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
1133         (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
1134         passed here, just filenames.
1135
1136         (WebInspector.linkifyURLAsNode):
1137         (WebInspector.linkifyResourceAsNode):
1138         Copied and slightly modified from inspector.js.
1139
1140 2011-11-16  Adam Roben  <aroben@apple.com>
1141
1142         Make Leaks Viewer load builds from the new Lion Leaks bot
1143
1144         Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
1145
1146         Reviewed by Andreas Kling.
1147
1148         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
1149         (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
1150         SnowLeopard one.
1151
1152 2011-11-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
1153
1154         [EFL] Clean up the offline apps-related functions in ewk_settings.
1155         https://bugs.webkit.org/show_bug.cgi?id=72132
1156
1157         Reviewed by Kenneth Rohde Christiansen.
1158
1159         `ewk_settings_cache' and `ewk_view_setting_cache' are too common
1160         prefixes for code that is related only to the HTML5 app cache
1161         features.
1162
1163         Use `ewk_settings_application_cache' and
1164         `ewk_view_setting_application_cache' instead.
1165
1166         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1167         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1168
1169 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1170
1171         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1172
1173         Reviewed by Tor Arne Vestbø.
1174
1175         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1176         magic here where we handle all TEMPLATE = lib .pro files (except plugins).
1177         * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
1178         removes the .so.0.0.0 and just produces .so.
1179
1180 2011-11-16  Peter Beverloo  <peter@chromium.org>
1181
1182         Explicitly include unistd.h in TestNetscapePlugIn
1183         https://bugs.webkit.org/show_bug.cgi?id=72385
1184
1185         This is needed for the sleep() call in the indicateTestFailure method,
1186         which seems to be implicitly available for other platforms. This is not
1187         the case on Android.
1188
1189         Reviewed by Steve Block.
1190
1191         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1192
1193 2011-11-16  Peter Beverloo  <peter@chromium.org>
1194
1195         [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
1196         https://bugs.webkit.org/show_bug.cgi?id=72384
1197
1198         Update to Android NDK r7, which was released last Friday. This adds
1199         support for RTTI and the -mimplicit-it gcc flag, which are required to
1200         respectively build ICU and Skia.
1201
1202         Reviewed by Steve Block.
1203
1204         * Scripts/update-webkit-chromium:
1205         * Scripts/webkitdirs.pm:
1206         (buildChromiumMakefile):
1207
1208 2011-11-16  Simon Hausmann  <simon.hausmann@nokia.com>
1209
1210         Unreviewed, rolling out r100266.
1211         http://trac.webkit.org/changeset/100266
1212
1213         Broke WTR.
1214
1215         * qmake/mkspecs/features/default_post.prf:
1216
1217 2011-11-16  Eric Seidel  <eric@webkit.org>
1218
1219         check-webkit-style broken by r99773: "Could not determine the port"
1220         https://bugs.webkit.org/show_bug.cgi?id=72275
1221
1222         Reviewed by Adam Barth.
1223
1224         I will continue engaging hacks, until windows improves.
1225
1226         * Scripts/webkitpy/common/host.py:
1227          - Host uses self.executive instead of self._executive like Port does.
1228          - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
1229
1230 2011-11-16  Eric Seidel  <eric@webkit.org>
1231
1232         check-webkit-style broken by r99773: "Could not determine the port"
1233         https://bugs.webkit.org/show_bug.cgi?id=72275
1234
1235         Reviewed by Adam Barth.
1236
1237         Engage windows hacks harder.
1238
1239         This is a speculative fix for ChromiumWin.  We're now
1240         creating an SCM object much earlier, so we need to
1241         engage our "awesome" windows hacks earlier.
1242
1243         * Scripts/webkitpy/common/host.py:
1244         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1245
1246 2011-11-15  Darin Adler  <darin@apple.com>
1247
1248         DRT's uiElementAttributeValueCallback function is leaky
1249         https://bugs.webkit.org/show_bug.cgi?id=72453
1250
1251         Reviewed by Dan Bernstein.
1252
1253         * DumpRenderTree/AccessibilityUIElement.cpp:
1254         (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
1255
1256 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1257
1258         Implement edit-distance based reviewer recognition algorithm
1259         https://bugs.webkit.org/show_bug.cgi?id=72351
1260
1261         Reviewed by Eric Seidel.
1262
1263         Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
1264         its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
1265         Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
1266         "build fix" to a reviewer's name (e.g. with with edit distance 9).
1267
1268         This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
1269         the edit distance is implemented in edit_distance.py.
1270
1271         Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
1272         on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
1273
1274         * Scripts/webkitpy/common/checkout/changelog.py:
1275         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1276         * Scripts/webkitpy/common/config/committers.py:
1277         * Scripts/webkitpy/common/config/committers_unittest.py:
1278         * Scripts/webkitpy/common/editdistance.py: Added.
1279         * Scripts/webkitpy/common/editdistance_unittest.py: Added.
1280         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1281         * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
1282
1283 2011-11-15  Tony Chang  <tony@chromium.org>
1284
1285         Skip a failing webkitpy test on cygwin.
1286
1287         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1288
1289 2011-11-15  Sam Weinig  <sam@webkit.org>
1290
1291         TestWebKitAPI should not put its resources in the root products directory
1292         https://bugs.webkit.org/show_bug.cgi?id=72446
1293
1294         Reviewed by Anders Carlsson.
1295
1296         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1297         Change the copy resources phase to place the resources in a TestWebKitAPI.resources
1298         directory.
1299
1300         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1301         (TEST_F):
1302         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1303         (TestWebKitAPI::TEST):
1304         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1305         (TestWebKitAPI::DeviceScaleFactorOnBack::url):
1306         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1307         (TestWebKitAPI::DynamicDeviceScaleFactor::url):
1308         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
1309         (TestWebKitAPI::Util::createURLForResource):
1310         Update calls to retrieve files from the bundle to look in the newly
1311         created subdirectory.
1312
1313 2011-11-15  Tony Chang  <tony@chromium.org>
1314
1315         Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
1316
1317         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1318
1319 2011-11-15  Tony Chang  <tony@chromium.org>
1320
1321         Unreviewed, fix test-webkitpy tests.  Move the check for image results
1322         earlier.
1323
1324         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1325         * Scripts/webkitpy/layout_tests/port/webkit.py:
1326
1327 2011-11-15  James Robinson  <jamesr@chromium.org>
1328
1329         [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
1330         https://bugs.webkit.org/show_bug.cgi?id=72444
1331
1332         Reviewed by Adam Barth.
1333
1334         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1335
1336 2011-11-15  Tony Chang  <tony@chromium.org>
1337
1338         Unreviewed, better fix for ref tests failures on SL Intel bot.
1339         Revert the previous change and return None if pixel results from
1340         either the test page or the expected page is missing.
1341
1342         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1343         * Scripts/webkitpy/layout_tests/port/webkit.py:
1344
1345 2011-11-15  James Robinson  <jamesr@chromium.org>
1346
1347         [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
1348         https://bugs.webkit.org/show_bug.cgi?id=72402
1349
1350         Reviewed by Dirk Pranke.
1351
1352         Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
1353         triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
1354         and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
1355         and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
1356         the normal compositing triggers since we currently run the compositing tests in only one configuration - with
1357         compositing enabled.
1358
1359         Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
1360         patch should not impact any tests.
1361
1362         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1363         (main):
1364         * DumpRenderTree/chromium/TestShell.cpp:
1365         (TestShell::TestShell):
1366         (TestShell::resetWebSettings):
1367         * DumpRenderTree/chromium/TestShell.h:
1368         (TestShell::setAcceleratedCompositingForVideoEnabled):
1369         * DumpRenderTree/chromium/WebPreferences.cpp:
1370         (WebPreferences::reset):
1371         (WebPreferences::applyTo):
1372         * DumpRenderTree/chromium/WebPreferences.h:
1373         * Scripts/webkitpy/layout_tests/port/chromium.py:
1374         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1375         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1376
1377 2011-11-15  Tony Chang  <tony@chromium.org>
1378
1379         Unreviewed, try to fix ref tests failures on SL Intel bot.
1380         It looks like ImageDiff isn't returning an image diff.
1381
1382         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
1383
1384 2011-11-15  Tony Chang  <tony@chromium.org>
1385
1386         Unreviewed fix of ref-tests on GTK+.
1387         If a driver is never started, _xvfb_process is never set.
1388
1389         * Scripts/webkitpy/layout_tests/port/gtk.py:
1390
1391 2011-11-14  Tony Chang  <tony@chromium.org>
1392
1393         [NRWT] Reftests should run even when pixel tests are disabled.
1394         https://bugs.webkit.org/show_bug.cgi?id=60605
1395
1396         Reviewed by Dirk Pranke.
1397
1398         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
1399             Also add an assert to make sure we get image hashes back when running ref tests.
1400         * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
1401         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1402         * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
1403         * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
1404             of starting a pixel driver if needed.  It handles the logic of sending the test
1405             to the correct driver.  Also renamed Driver.poll() to Driver.has_crashed().
1406         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1407         * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
1408         * Scripts/webkitpy/layout_tests/port/webkit.py:
1409         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
1410         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
1411
1412 2011-11-15  David Kilzer  <ddkilzer@apple.com>
1413
1414         Don't use File::Slurp for run-leaks unit tests
1415         <http://webkit.org/b/72356>
1416
1417         Reviewed by Daniel Bates.
1418
1419         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
1420         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
1421         Extracted common package logic into RunLeaks.pm.  Fixed call to
1422         RunLeaks::parseLeaksOutput().
1423         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
1424         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
1425
1426 2011-11-15  Peter Kasting  <pkasting@google.com>
1427
1428         Handle svn 1.7 when detecting whether a directory is in an svn checkout.
1429         https://bugs.webkit.org/show_bug.cgi?id=72349
1430
1431         Reviewed by Adam Roben.
1432
1433         * Scripts/VCSUtils.pm:
1434         (isSVNDirectory):
1435
1436 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1437
1438         [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
1439
1440         Reviewed by Tor Arne Vestbø.
1441
1442         * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
1443         magic here where we handle all TEMPLATE = lib .pro files.
1444
1445 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1446
1447         [Qt] Unreviewed prospective --minimal build fix.
1448
1449         * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
1450         and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
1451
1452 2011-11-15  Simon Hausmann  <simon.hausmann@nokia.com>
1453
1454         [Qt] Unreviewed --minimal build fix.
1455
1456         * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
1457         a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
1458         to make moc's preprocessor abort.
1459
1460 2011-11-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
1461
1462         build-webkit: Accept --cmakearg to pass additional arguments to CMake.
1463         https://bugs.webkit.org/show_bug.cgi?id=72156
1464
1465         Reviewed by Daniel Bates.
1466
1467         Similar to --makearg and --qmakearg, --cmakearg lets one pass
1468         additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
1469
1470         * Scripts/build-webkit:
1471         * Scripts/webkitdirs.pm:
1472         (generateBuildSystemFromCMakeProject):
1473
1474 2011-11-14  Ryosuke Niwa  <rniwa@webkit.org>
1475
1476         Improve ChangeLogEntry's reviewer parsing algorithm part 2
1477         https://bugs.webkit.org/show_bug.cgi?id=72340
1478
1479         Reviewed by Eric Seidel.
1480
1481         This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
1482         and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
1483
1484         * Scripts/webkitpy/common/checkout/changelog.py:
1485         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1486
1487 2011-11-14  Eric Seidel  <eric@webkit.org>
1488
1489         check-webkit-style broken by r99773: "Could not determine the port"
1490         https://bugs.webkit.org/show_bug.cgi?id=72275
1491
1492         Reviewed by Adam Barth.
1493
1494         The TestExpectationsChecker was using a generic try/except block
1495         which caught all exceptions, so we didn't notice that failing
1496         to pass a Host to PortFactory was causing an exception in port instantiation.
1497         I've factored out the "lookup the port" logic into a separate function
1498         which I've now unittested.  This should fix the bug and prevent
1499         others like it from occuring the the future.
1500
1501         * Scripts/webkitpy/style/checkers/test_expectations.py:
1502         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1503
1504 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1505
1506         Add --css-grid-layout to build-webkit and the build systems
1507         https://bugs.webkit.org/show_bug.cgi?id=72320
1508
1509         Reviewed by Ojan Vafai.
1510
1511         * Scripts/build-webkit:
1512         Added the option.
1513
1514 2011-11-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1515
1516         Unreviewed, rolling out r100192.
1517         http://trac.webkit.org/changeset/100192
1518         https://bugs.webkit.org/show_bug.cgi?id=72328
1519
1520         Caused infinite tests to fail (Requested by abarth on
1521         #webkit).
1522
1523         * Scripts/webkitpy/layout_tests/port/base.py:
1524         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1525
1526 2011-11-14  Tony Chang  <tony@chromium.org>
1527
1528         Remove the CSS3_FLEXBOX compile time flag and enable on all ports
1529         https://bugs.webkit.org/show_bug.cgi?id=72196
1530
1531         Reviewed by Ojan Vafai.
1532
1533         * Scripts/build-webkit:
1534
1535 2011-11-14  John Yani  <vanuan@gmail.com>
1536
1537         new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
1538         Override LOCALE to en_US.
1539
1540         Reviewed by Eric Seidel.
1541
1542         * Scripts/webkitpy/layout_tests/port/base.py:
1543
1544 2011-11-14  Julien Chaffraix  <jchaffraix@webkit.org>
1545
1546         [Chromium] build-webkit silently drops the features flags
1547         https://bugs.webkit.org/show_bug.cgi?id=72293
1548
1549         Reviewed by Tony Chang.
1550
1551         Chromium still ignores @features but now we give a warning!
1552
1553         * Scripts/build-webkit: Check if one of the features is different
1554         from the default and print a warning in this case.
1555
1556 2011-11-14  David Kilzer  <ddkilzer@apple.com>
1557
1558         run-leaks does not work on Lion?
1559         <http://webkit.org/b/71059>
1560         <rdar://problem/10428527>
1561
1562         Reviewed by Adam Roben.
1563
1564         The output of leaks(1) changed again in Lion to move the
1565         "leaks Report Version: 2.0" line from the first line of the
1566         output to just above the "Process " lines that run-leaks is
1567         interested in parsing.  This required using a more generic
1568         algorithm to find the start of the "Process " lines.
1569
1570         * Scripts/run-leaks:
1571         (parseLeaksOutput): Make the code to skip headers more generic.
1572         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
1573         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
1574         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
1575
1576 2011-11-14  Lei Zhang  <thestig@chromium.org>
1577
1578         Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
1579         https://bugs.webkit.org/show_bug.cgi?id=72088
1580
1581         Reviewed by Tony Chang.
1582
1583         * DumpRenderTree/chromium/AccessibilityUIElement.h:
1584
1585 2011-11-14  Andrew Scherkus  <scherkus@chromium.org>
1586
1587         [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
1588         https://bugs.webkit.org/show_bug.cgi?id=72147
1589
1590         Reviewed by Adam Barth.
1591
1592         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1593
1594 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1595
1596         [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
1597
1598         Reviewed by Simon Hausmann.
1599
1600         * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
1601
1602 2011-11-14  Simon Hausmann  <simon.hausmann@nokia.com>
1603
1604         [Qt] Disable plugins on X11 for WK2
1605
1606         Reviewed by Kenneth Rohde Christiansen.
1607
1608         Currently plugins are in-process and they crash in the likely case of
1609         a plugin installation that uses Qt 4, which beautifully clashes with the
1610         Qt 5 based QtWebProcess.
1611
1612         * qmake/mkspecs/features/features.prf:
1613
1614 2011-11-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1615
1616         [Qt] Add support for config tests for Qt 5
1617
1618         This allows us to build and run configure-tests at build
1619         time to determine if a given platform feature is available.
1620
1621         Reviewed by Simon Hausmann.
1622
1623         * Scripts/build-webkit:
1624         * Scripts/webkitdirs.pm:
1625         (qtFeatureDefaults):
1626         * qmake/configure.pro: Added.
1627         * qmake/mkspecs/features/features.prf:
1628         * qmake/sync.profile: Added.
1629
1630 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1631
1632         [Qt] Remove the QStyle dependency in Qt's mobile theme
1633         https://bugs.webkit.org/show_bug.cgi?id=67773
1634
1635         This refactoring splits up RenderThemeQt with two
1636         subclasses, a QStyle-backed one, and a Mobile version
1637         that uses the old mobile theme for now.
1638
1639         QStyle availability is detected at compile time, and
1640         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1641         environment variable.
1642
1643         Reviewed by Simon Hausmann.
1644
1645         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1646         (WTR::activateFonts):
1647         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1648         based on availability of QtWidgets.
1649         * qmake/mkspecs/features/webcore.prf: cleanup.
1650
1651 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1652
1653         Unreviewed, rolling out r100116.
1654         http://trac.webkit.org/changeset/100116
1655
1656         r100104 was rolled out, so no longer needed
1657
1658         * Scripts/run-bindings-tests:
1659
1660 2011-11-14  Tony Gentilcore  <tonyg@chromium.org>
1661
1662         Unreviewed, rolling out r100104.
1663         http://trac.webkit.org/changeset/100104
1664         https://bugs.webkit.org/show_bug.cgi?id=72247
1665
1666         broke windows builds
1667
1668         * Scripts/check-webkit-style:
1669         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1670         * Scripts/webkitpy/common/checkout/deps.py:
1671         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1672         * Scripts/webkitpy/common/checkout/scm/detection.py:
1673         * Scripts/webkitpy/common/checkout/scm/git.py:
1674         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1675         * Scripts/webkitpy/common/checkout/scm/svn.py:
1676         * Scripts/webkitpy/common/host.py:
1677         * Scripts/webkitpy/common/host_mock.py:
1678         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1679         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1680         * Scripts/webkitpy/layout_tests/port/base.py:
1681         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1682         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1683         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1684         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1685
1686 2011-11-14  Philippe Normand  <pnormand@igalia.com>
1687
1688         Unreviewed, build fix after r100104. run-binding-tests broke.
1689
1690         * Scripts/run-bindings-tests: Explicitely use scm.detection.
1691
1692 2011-11-13  Eric Seidel  <eric@webkit.org>
1693
1694         Add SCMDetector object to make scm detection mockable
1695         https://bugs.webkit.org/show_bug.cgi?id=72247
1696
1697         Reviewed by Adam Barth.
1698
1699         I think SCM detection may eventually be rolled into Checkout,
1700         but this patch at least makes it possible to mock code-paths
1701         which rely on scm detection.
1702         In the process of replacing callers of these free-functions
1703         I found that one of the functions was no longer used,
1704         and that one of the callers could instead just use the SCM
1705         object it already had access to through port.host.scm().
1706         I also discovered that I was not calling Host._initialize_scm()
1707         and thus host.scm() was always returning None!
1708
1709         * Scripts/check-webkit-style:
1710         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1711         * Scripts/webkitpy/common/checkout/deps.py:
1712         * Scripts/webkitpy/common/checkout/scm/__init__.py:
1713         * Scripts/webkitpy/common/checkout/scm/detection.py:
1714         * Scripts/webkitpy/common/checkout/scm/git.py:
1715         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1716         * Scripts/webkitpy/common/checkout/scm/svn.py:
1717         * Scripts/webkitpy/common/host.py:
1718         * Scripts/webkitpy/common/host_mock.py:
1719         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1720         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1721         * Scripts/webkitpy/layout_tests/port/base.py:
1722         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1723         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1724         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1725         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1726
1727 2011-11-13  Gavin Peters  <gavinp@chromium.org>
1728
1729         command line control of webcore log channels in chromium DumpRenderTree
1730         https://bugs.webkit.org/show_bug.cgi?id=72126
1731         
1732         The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
1733         what chromium takes.
1734
1735         Reviewed by Kent Tamura.
1736
1737         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1738         (main):
1739
1740 2011-11-12  Ariya Hidayat  <ariya@sencha.com>
1741
1742         [Qt] Fix minor config typo in the build tool documentation
1743         https://bugs.webkit.org/show_bug.cgi?id=72194
1744
1745         Reviewed by Andreas Kling.
1746
1747         * qmake/README:
1748
1749 2011-11-11  Stephen Chenney  <schenney@chromium.org>
1750
1751         [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
1752         https://bugs.webkit.org/show_bug.cgi?id=49257
1753
1754         Adds the remaining missing layout test functionality for printing.
1755
1756         Reviewed by Darin Fisher.
1757
1758         * DumpRenderTree/chromium/LayoutTestController.cpp:
1759         (LayoutTestController::LayoutTestController): Add bindings for new JS methods
1760         (parsePageNumber): Method to parse JS arguments for a page number
1761         (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
1762         (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
1763         (LayoutTestController::isPageBoxVisible): get the visibility status for printing
1764         (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
1765         * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
1766
1767 2011-11-11  Darin Adler  <darin@apple.com>
1768
1769         Remove all releaseRef implementations except for RetainPtr
1770         https://bugs.webkit.org/show_bug.cgi?id=71423
1771
1772         Reviewed by Julien Chaffraix.
1773
1774         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
1775         (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
1776
1777 2011-11-11  Ryosuke Niwa  <rniwa@webkit.org>
1778
1779         Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
1780         https://bugs.webkit.org/show_bug.cgi?id=72090
1781
1782         Reviewed by Eric Seidel.
1783
1784         Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
1785         ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
1786
1787         yay! r100002.
1788
1789         * Scripts/webkitpy/common/checkout/changelog.py:
1790         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1791
1792 2011-11-11  Tony Chang  <tony@chromium.org>
1793
1794         Remove --force from gclient sync.  The bots seem to have made it past
1795         the update step.
1796
1797         * Scripts/update-webkit:
1798
1799 2011-11-11  Tony Chang  <tony@chromium.org>
1800
1801         Add --force to gclient sync. Once the cq bots cycle, we can remove
1802         this since it slows down the normal sync.
1803
1804         * Scripts/update-webkit:
1805
1806 2011-11-11  Marc-Antoine Ruel  <maruel@chromium.org>
1807
1808         When --force is used, also use --reset
1809         https://bugs.webkit.org/show_bug.cgi?id=72129
1810
1811         Reviewed by Dimitri Glazkov.
1812
1813         * Scripts/update-webkit-chromium:
1814
1815 2011-11-11  Tony Chang  <tony@chromium.org>
1816
1817         allow two chromium drivers to run at the same time in NRWT
1818         https://bugs.webkit.org/show_bug.cgi?id=72067
1819
1820         Reviewed by Dirk Pranke.
1821
1822         * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
1823             posix prevents the subprocesses from sharing the same fd for stdin.
1824             Sharing the same fd prevents us from closing the files unless all references
1825             to the fd are closed.
1826         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
1827             to adding a test for this, speed up a test (from 3sec to 0) by fixing
1828             the timeout override. It looks like it regressed in r95875.
1829
1830 2011-11-11  Sheriff Bot  <webkit.review.bot@gmail.com>
1831
1832         Unreviewed, rolling out r99964.
1833         http://trac.webkit.org/changeset/99964
1834         https://bugs.webkit.org/show_bug.cgi?id=72124
1835
1836         Broke too many Qt tests (Requested by tronical_ on #webkit).
1837
1838         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1839         (WTR::activateFonts):
1840         * qmake/mkspecs/features/features.prf:
1841         * qmake/mkspecs/features/webcore.prf:
1842
1843 2011-11-11  Pierre Rossi  <pierre.rossi@gmail.com>
1844
1845         [Qt] Remove the QStyle dependency in Qt's mobile theme
1846         https://bugs.webkit.org/show_bug.cgi?id=67773
1847
1848         This refactoring splits up RenderThemeQt with two
1849         subclasses, a QStyle-backed one, and a Mobile version
1850         that uses the old mobile theme for now.
1851
1852         QStyle availability is detected at compile time, and
1853         its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
1854         environment variable.
1855
1856         Reviewed by Simon Hausmann.
1857
1858         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
1859         (WTR::activateFonts):
1860         * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
1861         based on availability of QtWidgets.
1862         * qmake/mkspecs/features/webcore.prf: cleanup.
1863
1864 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1865
1866         [Qt] Add missing include to PlatformWebViewQt
1867
1868         Reviewed by Simon Hausmann.
1869
1870         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1871
1872 2011-11-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1873
1874         [Qt] Fix incremental builds on Windows after buildsystem refactor
1875
1876         The qmake rules to ensure that we run make on the derived sources
1877         before running qmake on the target were inside a unix-scope, which
1878         resulted in flakey builds on Windows.
1879
1880         We now generate a rule on all platforms that ensures that "make qmake"
1881         will always run make on the derived sources. In addition, on platforms
1882         that have GNU make (where "make incremental" does not run "make qmake",
1883         but only "make"), we add a similar rule that ensures that any time the
1884         target makefile is regenerated we first run qmake and make on the derived
1885         sources. This rule relies on GNU make's order-only-prerequisites to
1886         not trigger a qmake-run of the target every time we run make.
1887
1888         https://bugs.webkit.org/show_bug.cgi?id=71778
1889
1890         Reviewed by Simon Hausmann.
1891
1892         * qmake/mkspecs/features/functions.prf:
1893
1894 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1895
1896         [Qt][WK2] Remove QWebNavigationController
1897         https://bugs.webkit.org/show_bug.cgi?id=72113
1898
1899         Reviewed by Andreas Kling.
1900
1901         Adapt to the move of the QWebNavigationController functions/properties to
1902         QQuickWebView.
1903
1904         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1905         * MiniBrowser/qt/qml/BrowserWindow.qml:
1906
1907 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1908
1909         [Qt] Build system tweak
1910
1911         Reviewed by Tor Arne Vestbø.
1912
1913         Be a good qmake citizen, return true from our linkStaticLibrary
1914         "test" function.
1915
1916         * qmake/mkspecs/features/functions.prf:
1917
1918 2011-11-11  Simon Hausmann  <simon.hausmann@nokia.com>
1919
1920         [Qt] Add support for QT += webkit-private
1921
1922         Reviewed by Tor Arne Vestbø.
1923
1924         * qmake/qt_webkit.pri: Declare private headers.
1925
1926 2011-11-11  Philippe Normand  <pnormand@igalia.com>
1927
1928         Unreviewed, build fix attempt after r99907. Since that revision
1929         GTK layout tests were not running at all...
1930
1931         * Scripts/webkitpy/layout_tests/port/gtk.py:
1932
1933 2011-11-10  Andrew Scherkus  <scherkus@chromium.org>
1934
1935         [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
1936         https://bugs.webkit.org/show_bug.cgi?id=72001
1937
1938         Reviewed by Dirk Pranke.
1939
1940         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1941
1942 2011-11-05  Filip Pizlo  <fpizlo@apple.com>
1943
1944         bencher script should support remote benchmarking
1945         https://bugs.webkit.org/show_bug.cgi?id=71618
1946
1947         Rubber-stamped by Geoff Garen.
1948         
1949         Added the following features:
1950         
1951         - Benchmark report tells you the hostname and machine model (according to
1952           'sysctl hw.model') of the machine you did the run on, and svn revision number
1953           (according to 'svn info') of the VMs you're testing.
1954         
1955         - The --remote option. You give this an ssh-style hostname (i.e. user@host is
1956           acceptable, in addition to just host, in which case your username is used)
1957           and it automatically packages the build directories of the VMs you're testing,
1958           sends them to the remote machine along with your copy of the bencher script
1959           and all of the options you passed.  This pretty much seamlessly allows you
1960           to run a set of benchmarks on any machine that is sufficiently compatible with
1961           yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
1962           must now include a tempPath setting that tells bencher where to put files
1963           when that machine is used as a slave in a remote benchmarking run.
1964           
1965         - Added yet another way of specifying which benchmarks to run. This was sort of
1966           necessary for --remote to work as expected. Previously, you either said what
1967           suites to exclude (for example --exclude-sunspider) or that you only wanted
1968           to run one suite to the exclusion of others (--sunspider-only). But it's
1969           often better to just be able to specify the list of suites you want. This is
1970           now supported. You can say, for example, --v8 --sunspider, which means, just
1971           run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
1972           still supported.
1973
1974         * Scripts/bencher:
1975
1976 2011-11-10  Tony Chang  <tony@chromium.org>
1977
1978         Lazily start DRT instances in NRWT
1979         https://bugs.webkit.org/show_bug.cgi?id=72038
1980
1981         Reviewed by Eric Seidel.
1982
1983         Just a refactoring, no new tests.
1984
1985         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1986         * Scripts/webkitpy/layout_tests/port/chromium.py:
1987         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1988         * Scripts/webkitpy/layout_tests/port/test.py:
1989         * Scripts/webkitpy/layout_tests/port/webkit.py:
1990
1991 2011-11-10  Ryosuke Niwa  <rniwa@webkit.org>
1992
1993         ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
1994         https://bugs.webkit.org/show_bug.cgi?id=72057
1995
1996         Reviewed by Eric Seidel.
1997
1998         Make the regular expression more explicit.
1999
2000         * Scripts/webkitpy/common/checkout/changelog.py:
2001         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2002
2003 2011-11-10  Balazs Kelemen  <kbalazs@webkit.org>
2004
2005         [Qt] X11 plugins need to be reworked for Qt5
2006         https://bugs.webkit.org/show_bug.cgi?id=70023
2007
2008         Reviewed by Simon Hausmann.
2009
2010         Rework our basic plugin support in a way that does
2011         not need a bridge between Qt and X. The solution is
2012         based on getting the content drawed by the plugin
2013         from the server as an image and creating a QImage
2014         from it.
2015
2016         * qmake/mkspecs/features/features.prf: Enable X11
2017         plugins if Qt is built with the xcb-xlib backend.
2018
2019 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2020
2021         [Qt] Fix keyboard related layout tests after API refactoring
2022
2023         Reviewed by Tor Arne Vestbø.
2024
2025         Send key events to the handling page item, not the view.
2026
2027         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2028         (WTR::PlatformWebView::sendEvent):
2029         (WTR::PlatformWebView::postEvent):
2030
2031 2011-11-10  Alexandre Mazari  <amazari@igalia.com>
2032
2033         [GTK] Make the ENABLE(FEATURE) macro work in DRT
2034         https://bugs.webkit.org/show_bug.cgi?id=71940
2035
2036         Reviewed by Philippe Normand.
2037
2038         * GNUmakefile.am:
2039         Add webcore_cppflags to Programs_DumpRenderTree_CPP so
2040         ENABLE_* variables are part of the environment.
2041
2042 2011-11-10  Simon Hausmann  <simon.hausmann@nokia.com>
2043
2044         [Qt] Fix focus related layout tests after API refactoring
2045
2046         Reviewed by Tor Arne Vestbø.
2047
2048         Make sure the focus is set on the page now, not on the view
2049         (which doesn't actually handle the focus).
2050
2051         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2052         (WTR::WrapperWindow::WrapperWindow):
2053         (WTR::WrapperWindow::handleStatusChanged):
2054
2055 2011-11-10  Alexis Menard  <alexis.menard@openbossa.org>
2056
2057         [Qt] Merge QTouchWebView and QDesktopWebView into one class
2058         https://bugs.webkit.org/show_bug.cgi?id=71355
2059
2060         Reviewed by Kenneth Rohde Christiansen.
2061
2062         Make MiniBrowser and WebKitTestRunner work again after the
2063         merge.
2064
2065         * MiniBrowser/qt/BrowserWindow.cpp:
2066         (BrowserWindow::BrowserWindow):
2067         (BrowserWindow::webView):
2068         * MiniBrowser/qt/MiniBrowser.pro:
2069         * MiniBrowser/qt/MiniBrowser.qrc:
2070         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2071         * MiniBrowser/qt/main.cpp:
2072         * MiniBrowser/qt/qml/BrowserWindow.qml:
2073         * MiniBrowser/qt/qml/DesktopView.qml: Removed.
2074         * MiniBrowser/qt/qml/TouchView.qml: Removed.
2075         * WebKitTestRunner/PlatformWebView.h:
2076         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2077         (WTR::PlatformWebView::PlatformWebView):
2078
2079 2011-11-10  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2080
2081         [Qt] Change semantics of the haveQt() function to match API promises
2082
2083         Having Qt 5 does not imply that we have Qt 4, from an API point of
2084         view, as a major version can in theory break BC/SC. Our minimum
2085         version of Qt 4 will always be the latest released version of Qt 4,
2086         so the only place we should use haveQt(4, x) is when checking for
2087         the minimum requirements.
2088
2089         Reviewed by Simon Hausmann.
2090
2091         * qmake/mkspecs/features/default_pre.prf:
2092         * qmake/mkspecs/features/features.prf:
2093         * qmake/mkspecs/features/functions.prf:
2094
2095 2011-11-07  Kaustubh Atrawalkar  <kaustubh@motorola.com> and Sergio Villar Senin  <svillar@igalia.com>
2096
2097         [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
2098         https://bugs.webkit.org/show_bug.cgi?id=69411
2099
2100         Reviewed by Martin Robinson.
2101
2102         * WebKitTestRunner/EventSenderProxy.h:
2103         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2104         * WebKitTestRunner/TestController.cpp:
2105         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2106         use the EventSender instead of WebProcess Event Simulation.
2107         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2108         (WTR::WTREventQueueItem::WTREventQueueItem):
2109         (WTR::EventSenderProxy::EventSenderProxy):
2110         (WTR::getMouseButtonModifiers):
2111         (WTR::eventSenderButtonToGDKButton):
2112         (WTR::EventSenderProxy::createMouseButtonEvent):
2113         (WTR::EventSenderProxy::updateClickCountForButton):
2114         (WTR::EventSenderProxy::replaySavedEvents):
2115         (WTR::EventSenderProxy::sendOrQueueEvent):
2116         (WTR::webkitModifiersToGDKModifiers):
2117         (WTR::getGDKKeySymForKeyRef):
2118         (WTR::EventSenderProxy::keyDown):
2119         (WTR::EventSenderProxy::mouseDown):
2120         (WTR::EventSenderProxy::mouseUp):
2121         (WTR::EventSenderProxy::mouseMoveTo):
2122         (WTR::EventSenderProxy::mouseScrollBy):
2123         (WTR::EventSenderProxy::leapForward):
2124
2125 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2126
2127         [Qt] Enable exports and constructor functions in static libs
2128
2129         Reviewed by Tor Arne Vestbø.
2130
2131         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2132         mac/win32-msvc equivalents when linking static libraries into a shared
2133         library or executable.
2134
2135 2011-11-09  Hayato Ito  <hayato@chromium.org>
2136
2137         [NRWT] Make results.html aware of reference filename in reftests.
2138         https://bugs.webkit.org/show_bug.cgi?id=71574
2139
2140         Reviewed by Ryosuke Niwa.
2141
2142         If a reference filename is different from the default one, include that in result summary
2143         so results.html can link to the correct reference file.
2144
2145         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2146         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2147
2148 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2149
2150         [wx] Unreviewed build fix. Update project files and
2151         add LTC stubs for new methods.
2152
2153         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2154         (LayoutTestController::addChromeInputField):
2155         (LayoutTestController::removeChromeInputField):
2156         (LayoutTestController::focusWebView):
2157         (LayoutTestController::setBackingScaleFactor):
2158         * waf/build/settings.py:
2159
2160 2011-11-09  Kevin Ollivier  <kevino@theolliviers.com>
2161
2162         [wx] Unreviewed build fix. Support XCode 4 when building deps.
2163
2164         * wx/install-unix-extras:
2165
2166 2011-11-09  Eric Seidel  <eric@webkit.org>
2167
2168         Remove the concept of platform-dependent unittests
2169         https://bugs.webkit.org/show_bug.cgi?id=71963
2170
2171         Unreviewed.  Fix test-webkitpy on cygwin.
2172
2173         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2174
2175 2011-11-09  Dana Jansens  <danakj@chromium.org>
2176
2177         Add cc-bugs group to watch changes in chromium graphics
2178         https://bugs.webkit.org/show_bug.cgi?id=71690
2179
2180         Reviewed by David Levin.
2181
2182         * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
2183         * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
2184         * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
2185         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
2186
2187 2011-11-09  Eric Seidel  <eric@webkit.org>
2188
2189         Remove more platform-dependent unittests
2190         https://bugs.webkit.org/show_bug.cgi?id=71971
2191
2192         Reviewed by Adam Barth.
2193
2194         Tests which only run on a couple platforms will break.
2195         All tests should run on all platforms where possible.
2196
2197         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2198         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2199         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2200         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2201
2202 2011-11-09  Ojan Vafai  <ojan@chromium.org>
2203
2204         Merge in results to the test results server even if build numbers conflict
2205         https://bugs.webkit.org/show_bug.cgi?id=71967
2206
2207         Reviewed by Tony Chang.
2208
2209         This was initially meant to be a sanity check that we don't
2210         enter duplicate runs, but it turns out that we can reasonably get
2211         in these situations when a builder is clobbered (e.g. the build
2212         numbers start over again from 0).
2213
2214         * TestResultServer/model/jsonresults.py:
2215         * TestResultServer/model/jsonresults_unittest.py:
2216
2217 2011-11-09  Eric Seidel  <eric@webkit.org>
2218
2219         Remove the concept of platform-dependent unittests
2220         https://bugs.webkit.org/show_bug.cgi?id=71963
2221
2222         Reviewed by Adam Barth.
2223
2224         These have been the source of never-ending sadness.
2225         We'd change behavior and forget to update results in
2226         some unittests because they were only run on certain platforms.
2227         This change removes a large source of these platform-dependent
2228         unittests, which was caused by the port_maker stuff.
2229
2230         It's possible that this change will break test-webkitpy
2231         on some platforms, but that will be a one-time cost.
2232         I will fix the breakage by removing the platform-dependantness
2233         of any such broken tests.
2234
2235         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2236         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2237         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2238         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2239         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2240         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2241         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
2242         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2243         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2244         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2245         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2246         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2247         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2248
2249 2011-11-09  Eric Seidel  <eric@webkit.org>
2250
2251         Make the Port object have a Host
2252         https://bugs.webkit.org/show_bug.cgi?id=71961
2253
2254         Reviewed by Adam Barth.
2255
2256         This has been a long time coming.
2257         Now that Port has a Host object, it's very easy
2258         to write unittests which use a properly mocked Port.
2259         Soon we will remove the executive, filesystem and user
2260         members of Port and get everything through the Host.
2261
2262         Note how in many callsites we're actually removing
2263         explicit mocks, since we're now always going to get the
2264         correct Executive/User/FileSystem from the
2265         Host and callsites don't need to be careful to pass each one.
2266
2267         This is prep-work for adding a new Environment member to
2268         Host and needing to be able to access the Environment
2269         member from Port functions w/o needing to pass an Environment
2270         object (or appropriate Mock) every place we create a Port object.
2271         Now that we have a single Host object to reach out through, its
2272         simple to add additional functionality (like Environment) while
2273         keeping our unittests properly mocked.
2274
2275         * Scripts/webkitpy/common/host.py:
2276         * Scripts/webkitpy/common/net/credentials_unittest.py:
2277         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2278         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2279         * Scripts/webkitpy/layout_tests/port/apple.py:
2280         * Scripts/webkitpy/layout_tests/port/base.py:
2281         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2282         * Scripts/webkitpy/layout_tests/port/chromium.py:
2283         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2284         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2285         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2286         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2287         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2288         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2289         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2290         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2291         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2292         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2293         * Scripts/webkitpy/layout_tests/port/efl.py:
2294         * Scripts/webkitpy/layout_tests/port/factory.py:
2295         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2296         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2297         * Scripts/webkitpy/layout_tests/port/gtk.py:
2298         * Scripts/webkitpy/layout_tests/port/mac.py:
2299         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2300         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2301         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2302         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2303         * Scripts/webkitpy/layout_tests/port/qt.py:
2304         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2305         * Scripts/webkitpy/layout_tests/port/test.py:
2306         * Scripts/webkitpy/layout_tests/port/webkit.py:
2307         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2308         * Scripts/webkitpy/layout_tests/port/win.py:
2309         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
2310         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2311         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2312         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2313         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2314
2315 2011-11-09  Dominic Mazzoni  <dmazzoni@google.com>
2316
2317         [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
2318         https://bugs.webkit.org/show_bug.cgi?id=71561
2319
2320         Reviewed by Dimitri Glazkov.
2321
2322         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
2323         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
2324
2325 2011-11-09  Benjamin Poulain  <bpoulain@apple.com>
2326
2327         Implement dumpProgressFinishedCallback() for Mac layoutTestController
2328         https://bugs.webkit.org/show_bug.cgi?id=66772
2329
2330         Reviewed by Simon Fraser.
2331
2332         When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
2333         "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
2334
2335         On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
2336         in the FrameLoadDelegate and print the output in response to the notification.
2337
2338         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2339         (-[FrameLoadDelegate init]):
2340         (-[FrameLoadDelegate dealloc]):
2341         (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
2342
2343 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2344
2345         [GTK][DRT] window internals object is not reset after each test
2346         https://bugs.webkit.org/show_bug.cgi?id=71890
2347
2348         Reviewed by Martin Robinson.
2349
2350         Call WebCoreTestSupport::resetInternalsObject without going
2351         through DumpRenderTreeSupport.
2352
2353         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2354         (runTest):
2355
2356 2011-11-09  Beth Dakin  <bdakin@apple.com>
2357
2358         Build fix.
2359
2360         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2361         (AccessibilityUIElement::uiElementAttributeValue):
2362
2363 2011-11-09  Beth Dakin  <bdakin@apple.com>
2364
2365         Speculative build fix.
2366
2367         * DumpRenderTree/AccessibilityUIElement.h:
2368
2369 2011-11-09  Julien Chaffraix  <jchaffraix@webkit.org>
2370
2371         Unreviewed build fix.
2372
2373         * DumpRenderTree/AccessibilityUIElement.cpp:
2374         (AccessibilityUIElement::makeJSAccessibilityUIElement):
2375         A bad merge added this check that is making the bots sad.
2376
2377 2011-11-09  Chris Fleizach  <cfleizach@apple.com>
2378
2379         AX: crash when accessing selectedTab in a tab list
2380         https://bugs.webkit.org/show_bug.cgi?id=70938
2381
2382         Reviewed by Beth Dakin.
2383
2384         Add the ability to retrieve an element through an arbitrary attribute.
2385
2386         * DumpRenderTree/AccessibilityUIElement.cpp:
2387         (uiElementAttributeValueCallback):
2388         (AccessibilityUIElement::uiElementAttributeValue):
2389         (AccessibilityUIElement::getJSClass):
2390         * DumpRenderTree/AccessibilityUIElement.h:
2391         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2392         (AccessibilityUIElement::uiElementAttributeValue):
2393
2394 2011-11-09  Andy Wingo  <wingo@igalia.com>
2395
2396         Add webkitdirs.pm:getArchitecture implementation for GTK
2397         https://bugs.webkit.org/show_bug.cgi?id=71370
2398
2399         Reviewed by Xan Lopez.
2400
2401         * Scripts/webkitdirs.pm (determineArchitecture): Add an
2402         implementation for ports using autotools, so that a vanilla
2403         `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
2404         to build-jsc on x86-64 machines.
2405
2406 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2407
2408         Unreviewed, rolling out r99707.
2409         http://trac.webkit.org/changeset/99707
2410
2411         Re-enable until we can disable it together with tests in one
2412         shot.
2413
2414         * qmake/mkspecs/features/features.prf:
2415
2416 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2417
2418         [Qt] Disable use of QtUiTools if the library/module is not found
2419
2420         We rely on the lookup order of prf files to inject our own uitools.prf
2421         that will verify that QtUiTools is in fact present before allowing the
2422         CONFIG += uitools to have any effect.
2423
2424         Reviewed by Simon Hausmann.
2425
2426         * DumpRenderTree/qt/DumpRenderTree.pro:
2427         * QtTestBrowser/QtTestBrowser.pro:
2428         * qmake/mkspecs/features/uitools.prf: Added.
2429
2430 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2431
2432         Unreviewed, rolling out r99701.
2433         http://trac.webkit.org/changeset/99701
2434
2435         Breaks Qt mac build
2436
2437         * qmake/mkspecs/features/functions.prf:
2438
2439 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2440
2441         [Qt] Prospective build fix for Win32/Mac with xmlpatterns
2442
2443         Reviewed by Tor Arne Vestbø.
2444
2445         * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
2446         We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
2447         is not up to the task of full XSLT support, so we should disable it.
2448
2449 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2450
2451         [Qt] Enable exports and constructor functions in static libs
2452
2453         Reviewed by Tor Arne Vestbø.
2454
2455         * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
2456         mac/win32-msvc equivalents when linking static libraries into a shared
2457         library or executable.
2458
2459 2011-11-09  Philippe Normand  <pnormand@igalia.com>
2460
2461         [GTK][DRT] window internals object is not reset after each test
2462         https://bugs.webkit.org/show_bug.cgi?id=71890
2463
2464         Reviewed by Xan Lopez.
2465
2466         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2467         (runTest): reset the Internals object after each test.
2468
2469 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2470
2471         [Qt] Detect presence of QtUiTools and enable it only when available
2472
2473         The disable_uitools option was a workaround for missing detection.
2474
2475         Reviewed by Simon Hausmann.
2476
2477         * QtTestBrowser/QtTestBrowser.pro:
2478         * qmake/mkspecs/features/default_post.prf:
2479         * qmake/mkspecs/features/default_pre.prf:
2480
2481 2011-11-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2482
2483         [Qt] Don't override config for the build_pass of debug_and_release
2484
2485         Qmake will parse the profile once for each configuration (debug and
2486         release), with the build_pass option set. In that situation we don't
2487         want to override what qmake is setting explicitly, otherwise the
2488         debug-step will end up hitting all the release-scopes.
2489
2490         Reviewed by Simon Hausmann.
2491
2492         * qmake/mkspecs/features/default_pre.prf:
2493
2494 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2495
2496         [Qt] Unbreak the Qt build (copy & paste mistake - oops)
2497
2498         * qmake/mkspecs/features/functions.prf:
2499
2500 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2501
2502         [Qt] Centralize duplicated code for linking the static libs
2503
2504         Reviewed by Tor Arne Vestbø.
2505
2506         * qmake/mkspecs/features/functions.prf:
2507         * qmake/mkspecs/features/javascriptcore.prf:
2508         * qmake/mkspecs/features/webcore.prf:
2509         * qmake/mkspecs/features/webkit2.prf:
2510
2511 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
2512
2513         [Qt] Build system cleanup
2514         https://bugs.webkit.org/show_bug.cgi?id=71815
2515
2516         Reviewed by Kenneth Rohde Christiansen.
2517
2518         * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
2519         static library.
2520         * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
2521         (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
2522
2523 2011-11-08  Hayato Ito  <hayato@chromium.org>
2524
2525         [NRWT] Make single_test_runner aware of reference filename of test_input.
2526         https://bugs.webkit.org/show_bug.cgi?id=71567
2527
2528         Reviewed by Ryosuke Niwa.
2529
2530         Make single_test_runner honor a reference filename of given test_input so that
2531         we can use any file as reference html, instead of depending on implicit naming convention.
2532         The typical use case is to support w3c reftests.
2533
2534         No tests since no functional changes until there is a client.
2535         Test should be easily written with future clients.
2536
2537         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2538         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2539         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2540         * Scripts/webkitpy/layout_tests/models/test_input.py:
2541
2542 2011-11-08  Lucas Forschler  <lforschler@apple.com>
2543
2544         https://bugs.webkit.org/show_bug.cgi?id=71839
2545         Update the leaks bot OS to Lion.
2546         Update the config.json to reflect the update.
2547
2548         Reviewed by Stephanie Lewis.
2549
2550         * BuildSlaveSupport/build.webkit.org-config/config.json:
2551
2552 2011-11-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2553
2554         Unreviewed, rolling out r99626.
2555         http://trac.webkit.org/changeset/99626
2556         https://bugs.webkit.org/show_bug.cgi?id=71866
2557
2558         "C++ exceptions cannot be disabled without influencing the
2559         Objective-C exceptions" (Requested by benjaminp on #webkit).
2560
2561         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2562
2563 2011-11-08  Benjamin Poulain  <bpoulain@apple.com>
2564
2565         [Mac] Disable C++ exceptions from DumpRenderTree
2566         https://bugs.webkit.org/show_bug.cgi?id=71834
2567
2568         Reviewed by Darin Adler.
2569
2570         DumpRenderTree Mac does not handle C++ exceptions. When such exception
2571         happens, it tends to cause the AutoReleasePool stack to be corrupted,
2572         which leads to crashes long after the exception was raised.
2573
2574         This patch disabled C++ exceptions in order to catch the problems where
2575         they happen when a C++ exception is raised.
2576
2577         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2578
2579 2011-11-08  Julien Chaffraix  <jchaffraix@webkit.org>
2580
2581         Moved myself to the reviewer list (yay!).
2582
2583         * Scripts/webkitpy/common/config/committers.py:
2584
2585 2011-11-08  Zeno Albisser  <zeno@webkit.org>
2586
2587         Added myself as a committer.
2588
2589         * Scripts/webkitpy/common/config/committers.py:
2590
2591 2011-11-08  Andy Wingo  <wingo@igalia.com>
2592
2593         Skip some ECMAScript tests that fail on Linux in some time zones.
2594         https://bugs.webkit.org/show_bug.cgi?id=71371
2595
2596         Reviewed by Martin Robinson.
2597
2598         * Scripts/run-javascriptcore-tests: Skip some more tests.
2599
2600 2011-11-08  Csaba Osztrogonác  <ossy@webkit.org>
2601
2602         [Qt] Unreviewed trivial fix after build system refactoring.
2603
2604         * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
2605
2606 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2607
2608         [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
2609
2610         If a pro file needs to access the OBJECTS_DIR it should use the
2611         form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
2612         after defaults_post has been processed.
2613
2614         Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
2615         the command line will override whatever we set in defaults_pre.
2616
2617         Reviewed by Simon Hausmann.
2618
2619         * qmake/mkspecs/features/default_post.prf:
2620         * qmake/mkspecs/features/default_pre.prf:
2621
2622 2011-11-08  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2623
2624         [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
2625
2626         Reviewed by Simon Hausmann.
2627
2628         * qmake/mkspecs/features/default_post.prf:
2629
2630 2011-11-07  Zeno Albisser  <zeno.albisser@nokia.com>
2631
2632         [Qt][WK2] MiniBrowser should use urlFromUserInput()
2633         https://bugs.webkit.org/show_bug.cgi?id=71680
2634
2635         Use urlFromUserInput() / QUrl::fromUserInput() to automatically
2636         complete urls in MiniBrowser.
2637
2638         Reviewed by Tor Arne Vestbø.
2639
2640         * MiniBrowser/qt/BrowserWindow.cpp:
2641         (BrowserWindow::BrowserWindow):
2642         (BrowserWindow::load):
2643         * MiniBrowser/qt/qml/BrowserWindow.qml:
2644         * MiniBrowser/qt/utils.cpp:
2645         (Utils::urlFromUserInput):
2646         * MiniBrowser/qt/utils.h:
2647         (Utils::Utils):
2648
2649 2011-11-07  Yuqiang Xian  <yuqiang.xian@intel.com>
2650
2651         Added myself as a committer.
2652
2653         * Scripts/webkitpy/common/config/committers.py:
2654
2655 2011-11-07  Csaba Osztrogonác  <ossy@webkit.org>
2656
2657         Unreviewed webkitpy test fix after r99512.
2658
2659         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
2660         Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
2661
2662 2011-11-07  Xianzhu Wang  <wangxianzhu@chromium.org>
2663
2664         Added myself as a committer.
2665
2666         * Scripts/webkitpy/common/config/committers.py:
2667
2668 2011-11-07  Sheriff Bot  <webkit.review.bot@gmail.com>
2669
2670         Unreviewed, rolling out r99470.
2671         http://trac.webkit.org/changeset/99470
2672         https://bugs.webkit.org/show_bug.cgi?id=71740
2673
2674         "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
2675
2676         * Scripts/webkitpy/common/config/watchlist:
2677
2678 2011-11-07  Tony Chang  <tony@chromium.org>
2679
2680         [chromium] update flakiness dashboard to reflect current bots
2681
2682         Reviewed by Ojan Vafai.
2683
2684         * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
2685             bots and merged linux debug bots into a single bot.
2686         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2687         (setupExpectationsTest):
2688
2689 2011-11-07  Dana Jansens  <danakj@chromium.org>
2690
2691         Add cc-bugs group to watch changes in chromium graphics
2692         https://bugs.webkit.org/show_bug.cgi?id=71690
2693
2694         Reviewed by James Robinson.
2695
2696         * Scripts/webkitpy/common/config/watchlist:
2697
2698 2011-11-07  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
2699
2700         [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
2701         https://bugs.webkit.org/show_bug.cgi?id=70912
2702
2703         Reviewed by Ojan Vafai.
2704
2705         * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
2706         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
2707
2708 2011-11-07  Eric Seidel  <eric@webkit.org>
2709
2710         new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
2711         https://bugs.webkit.org/show_bug.cgi?id=62199
2712
2713         Reviewed by Dirk Pranke.
2714
2715         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2716         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2717         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2718
2719 2011-11-07  Fady Samuel  <fsamuel@chromium.org>
2720
2721         [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
2722         https://bugs.webkit.org/show_bug.cgi?id=71485
2723
2724         Reviewed by Darin Fisher.
2725
2726         * DumpRenderTree/chromium/EventSender.cpp:
2727         (EventSender::scalePageBy):
2728         * DumpRenderTree/chromium/TestShell.cpp:
2729         (TestShell::resetTestController):
2730
2731 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2732
2733         [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
2734
2735         Allows us to not package up the whole Source/JavaScriptCore directory for the
2736         buildbots.
2737
2738         Reviewed-by Simon Hausmann.
2739
2740         * BuildSlaveSupport/built-product-archive:
2741         * Scripts/webkitdirs.pm:
2742         (jscProductDir):
2743
2744 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2745
2746         [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
2747
2748         Reviewed-by Simon Hausmann.
2749
2750         * qmake/mkspecs/features/default_post.prf:
2751
2752 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2753
2754         [Qt] Sanitize qmake paths correctly before comparing
2755
2756         The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
2757         which caused us to always generate derived webcore sources, but never build
2758         them. The bug has been fixed, and we now also sanitize paths for the injected
2759         bundle derived sources.
2760
2761         Reviewed by Simon Hausmann.
2762
2763         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2764         * qmake/mkspecs/features/functions.prf:
2765
2766 2011-11-07  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2767
2768         [Qt] Print right order for changing feature defines
2769
2770         Reviewed by Simon Hausmann.
2771
2772         * Scripts/webkitdirs.pm:
2773         (buildQMakeProject):
2774
2775 2011-11-06  Csaba Osztrogonác  <ossy@webkit.org>
2776
2777         [Qt] Unreviewed trivial fix after build system refactoring.
2778
2779         * Scripts/run-qtwebkit-tests: Fix qml_import_path.
2780
2781 2011-11-06  Eric Seidel  <eric@webkit.org>
2782
2783         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2784         https://bugs.webkit.org/show_bug.cgi?id=66078
2785
2786         Unreviewed.  Add an assert about the type of "args"
2787         to our Executive Mocks and fix a piece of code
2788         from this patch which was hitting that assert
2789         when executing for real.
2790
2791         * Scripts/webkitpy/common/system/executive_mock.py:
2792         * Scripts/webkitpy/layout_tests/port/webkit.py:
2793
2794 2011-11-06  Eric Seidel  <eric@webkit.org>
2795
2796         Split chunk handling out of prepare_lists_and_print_output to make it more readable
2797         https://bugs.webkit.org/show_bug.cgi?id=71629
2798
2799         Reviewed by Adam Barth.
2800
2801         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2802
2803 2011-11-06  Eric Seidel  <eric@webkit.org>
2804
2805         Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
2806         https://bugs.webkit.org/show_bug.cgi?id=66078
2807
2808         Reviewed by Adam Barth.
2809
2810         The runtime feature detection was fixed to work in bug 64472.
2811         In this bug I moved the symbol-based feature detection from
2812         popen() to Executive.run_command and cleaned up the callers
2813         and unittests to make sure that we're correctly parsing the
2814         nm output correctly.  The old code happened to work even though
2815         the runtime-features path was using "str in list" and the
2816         symbol features path was using "str in str" and it just happened
2817         to do what we wanted to.  Now runtime features and symbol feature
2818         blacklists are computed separately (and with better documentation).
2819
2820         This system remains confusing, partially because these are black-lists
2821         which are amended to whatever static blacklist may exist for the
2822         port as part of a Skipped list file.
2823
2824         For example, notice how the runtime feature list only has directory
2825         blacklists for a couple features.  If all features are off,
2826         how do we skip enough tests with only 2 entries in the blacklist map?
2827         The answer is that Windows is the only port to use runtime feature
2828         detection, and the win/Skipped file turns off all the other features
2829         statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
2830         which use symbol-based feature detection turn of mathml, wcss, etc
2831         using the blacklists found in _missing_symbol_to_skipped_tests.
2832
2833         I also noticed a couple places where we still referenced xhtmlmp
2834         even though support for such has been removed from WebKit.  Removed those.
2835
2836         This should result in no functional change.
2837
2838         * Scripts/webkitpy/layout_tests/port/gtk.py:
2839          - Use self._filesystem instead of os.path
2840         * Scripts/webkitpy/layout_tests/port/webkit.py:
2841         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2842
2843 2011-11-06  Dan Bernstein  <mitz@apple.com>
2844
2845         Made show-pretty-diff work when the input path contains spaces.
2846
2847         Reviewed by Anders Carlsson.
2848
2849         * Scripts/show-pretty-diff:
2850
2851 2011-11-05  Daniel Cheng  <dcheng@chromium.org>
2852
2853         [chromium] Use the security origin instead of the URL when checking notification permissions
2854         https://bugs.webkit.org/show_bug.cgi?id=71590
2855
2856         Reviewed by Adam Barth.
2857
2858         * DumpRenderTree/chromium/NotificationPresenter.cpp:
2859         (NotificationPresenter::checkPermission):
2860         * DumpRenderTree/chromium/NotificationPresenter.h:
2861
2862 2011-11-05  Darin Adler  <darin@apple.com>
2863
2864         Fix a small leak in Mac version of LayoutTestController
2865         https://bugs.webkit.org/show_bug.cgi?id=71615
2866
2867         Reviewed by Mark Rowe.
2868
2869         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2870         (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
2871         (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
2872
2873 2011-11-04  Eric Seidel  <eric@webkit.org>
2874
2875         Upgrade to the latest Mechanize
2876         https://bugs.webkit.org/show_bug.cgi?id=71594
2877
2878         Reviewed by Adam Barth.
2879
2880         I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
2881         Mechanize is no longer two separate libraries, so importing it is much simpler.
2882
2883         * Scripts/webkitpy/thirdparty/__init__.py:
2884
2885 2011-11-04  Stephen Chenney  <schenney@chromium.org>
2886
2887         Crash in ScrollAnimator.cpp
2888         https://bugs.webkit.org/show_bug.cgi?id=69865
2889
2890         The code in ScrollAnimator assumes that horizontal per-page mouse
2891         wheel events cannot happen, which is not true. This patch adds layout
2892         tests for all paging wheel event situations and fixes the broken
2893         horizontal case.
2894
2895         Reviewed by Anders Carlsson
2896
2897         * DumpRenderTree/chromium/EventSender.cpp:
2898         (EventSender::handleMouseWheel): Added the ability to specify that a
2899         mouse wheel event should be paging.
2900
2901 2011-11-04  Eric Seidel  <eric@webkit.org>
2902
2903         Remove deprecated free functions in port.factory
2904         https://bugs.webkit.org/show_bug.cgi?id=71494
2905
2906         Unreviewed.  Fix exception when running new-run-webkit-httpd.
2907
2908         * Scripts/new-run-webkit-httpd:
2909
2910 2011-11-04  Adam Roben  <aroben@apple.com>
2911
2912         Remove Leopard-specific code from build.webkit.org
2913
2914         We don't have any Leopard bots anymore.
2915
2916         Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
2917
2918         Reviewed by Mark Rowe.
2919
2920         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
2921         and StopATSServer steps.
2922         (unitTestsSupported): Removed check for mac-leopard.
2923         (TestFactory.__init__): Removed Leopard-specific steps.
2924
2925 2011-11-04  Eric Seidel  <eric@webkit.org>
2926
2927         new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
2928         https://bugs.webkit.org/show_bug.cgi?id=71549
2929
2930         Reviewed by Adam Barth.
2931
2932         Several members of Host didn't really belong there
2933         and were instead specific to WebKitPatch, so I've moved
2934         them up onto that class.
2935
2936         * Scripts/webkitpy/common/host.py:
2937         * Scripts/webkitpy/common/host_mock.py:
2938         * Scripts/webkitpy/tool/main.py:
2939         * Scripts/webkitpy/tool/mocktool.py:
2940         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2941
2942 2011-11-04  Tony Chang  <tony@chromium.org>
2943
2944         garden-o-matic: bring back party time!
2945         https://bugs.webkit.org/show_bug.cgi?id=71582
2946
2947         Reviewed by Adam Barth.
2948
2949         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
2950         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
2951         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
2952         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
2953         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
2954         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
2955
2956 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
2957
2958         [EFL] DRT: Fix the order of the items in the dumped history list.
2959         https://bugs.webkit.org/show_bug.cgi?id=71562
2960
2961         It did not make much sense to hold the history list in a map, as we do not need
2962         the keys. And the printed items must be sorted by target, which is more easily
2963         done with a vector.
2964
2965         Should make tests such as http/tests/navigation/error404-frames.html pass.
2966
2967         Reviewed by Antonio Gomes.
2968
2969         * DumpRenderTree/efl/DumpHistoryItem.cpp:
2970         (compareHistoryItemsByTarget):
2971         (dumpHistoryItem):
2972
2973 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
2974
2975         [Qt] Remove ENABLE_SQLITE from qmake files
2976         https://bugs.webkit.org/show_bug.cgi?id=71546
2977
2978         Reviewed by Simon Hausmann.
2979
2980         * qmake/mkspecs/features/features.prf:
2981         * qmake/mkspecs/features/webcore.prf:
2982
2983 2011-11-04  Adam Barth  <abarth@webkit.org>
2984
2985         watchlist for WebIDL shouldn't trigger on Internals.idl
2986         https://bugs.webkit.org/show_bug.cgi?id=70657
2987
2988         Reviewed by David Levin.
2989
2990         Internals.idl isn't part of the Web-facing IDL in the project.
2991
2992         * Scripts/webkitpy/common/config/watchlist:
2993
2994 2011-11-04  Anders Carlsson  <andersca@apple.com>
2995
2996         Fix WKTR crash when running NPN_ConvertPoint test.
2997
2998         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
2999
3000         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3001         (ConvertPoint::NPP_SetWindow):
3002
3003 2011-11-04  Anders Carlsson  <andersca@apple.com>
3004
3005         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
3006         https://bugs.webkit.org/show_bug.cgi?id=71570
3007
3008         Reviewed by Simon Fraser.
3009
3010         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3011         (PluginTest::NPP_SetWindow):
3012         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3013         Remove the NPP parameter from NPP_SetWindow.
3014
3015         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
3016         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
3017         Remove the NPP parameter from NPP_SetWindow.
3018
3019         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3020         (PassDifferentNPPStruct::NPP_SetWindow):
3021         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
3022
3023         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
3024         (ConvertPoint::NPP_SetWindow):
3025         Run the test from NPP_SetWindow and call notifyDone() when done.
3026
3027         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3028         (NPP_SetWindow):
3029         Remove unnecessary parameter.
3030
3031 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3032
3033         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
3034
3035         Rubber-stamped by Tor Arne Vestbø.
3036
3037         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
3038         changed slightly after the refactoring.
3039
3040 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3041
3042         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
3043
3044         Reviewed by Simon Hausmann.
3045
3046         * qmake/mkspecs/features/default_pre.prf:
3047
3048 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3049
3050         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
3051
3052         Reviewed by Simmon Hausmann.
3053
3054         * qmake/mkspecs/features/default_pre.prf:
3055
3056 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3057
3058         [Qt] Disable STDIN check before cleaning build dir
3059
3060         It didn't work on the bots.
3061
3062         Reviewed by Ossy.
3063
3064         * Scripts/webkitdirs.pm:
3065
3066 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3067
3068         [Qt] Don't build all of webkit when running build-jsc
3069
3070         In case the whole webkit project was built, but we then subsequently
3071         want to build only JSC, we need to run make in the proper subdirectory.
3072
3073         This also means the incremental target needs to be added to all
3074         makefiles.
3075
3076         Reviewed by Simmon Hausmann.
3077
3078         * Scripts/webkitdirs.pm:
3079         (buildQMakeProject):
3080         * qmake/mkspecs/features/default_post.prf:
3081
3082 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3083
3084         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
3085
3086         Reviewed by Tor Arne Vestbø.
3087
3088         * Scripts/webkitdirs.pm:
3089         (jscProductDir): jsc path changed.
3090
3091 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3092
3093         [Qt] Error out early if trying to build against Qt < 4.8
3094
3095         Reviewed by Simon Hausmann.
3096
3097         * qmake/mkspecs/features/default_pre.prf:
3098
3099 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
3100
3101         Fix run-launcher for Qt and Gtk.
3102
3103         Rubber-stamped by Tor Arne Vestbø.
3104
3105         * Scripts/webkitdirs.pm:
3106         (isWK2): Re-add isWK2(), as it's used in run-launcher.
3107
3108 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3109
3110         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
3111
3112         Reviewed by Simon Hausmann.
3113
3114         * Scripts/build-webkit:
3115
3116 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3117
3118         [GTK] Use web view title as window title in MiniBrowser
3119         https://bugs.webkit.org/show_bug.cgi?id=71544
3120
3121         Reviewed by Philippe Normand.
3122
3123         * MiniBrowser/gtk/BrowserWindow.c:
3124         (webViewURIChanged): Removed extra space.
3125         (webViewTitleChanged): Set window title using
3126         webkit_web_view_get_title().
3127         (browser_window_init): Set initial default window title.
3128         (browserWindowConstructed): Connect to WebView notify::title
3129         signal.
3130
3131 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3132
3133         [Qt] Refactor and clean up the qmake build system
3134
3135         The qmake build system has accumulated a bit of cruft and redundancy
3136         over time. There's also a fairly tight coupling between how to build
3137         the various targets, and _what_ to build, making it harder to add new
3138         rules or sources. This patch aims to elevate these issues somewhat.
3139
3140         This is a short-list of the changes:
3141
3142           * The rules for how to build targets are now mostly contained as
3143             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
3144             allows us to do pre- and post-processing of each project file,
3145             which helps to clean up the actual project files.
3146
3147           * Derived sources are no longer generated as a separate make-step
3148             but is part of each target's project file as a subdir. Makefile
3149             rules are used to ensure that we run make on the derived sources
3150             before running qmake on the actual target makefile. This makes
3151             it easier to keep a proper dependency between derived sources
3152             and the target.
3153
3154           * We use GNU make and the compiler to generate dependencies on
3155             UNIX-based systems running Qt 5. This allows us to lessen the
3156             need to run qmake, which should reduce compile time.
3157
3158           * WebKit2 is now build by default if building with Qt 5. It can
3159             be disabled by passing --no-webkit2 to build-webkit.
3160
3161         The result of these changes are hopefully a cleaner and easier
3162         build system to modify, and faster build times due to no longer
3163         running qmake on every single build. It's also a first step
3164         towards possibly generating the list of sources using another
3165         build system.
3166
3167         https://bugs.webkit.org/show_bug.cgi?id=71222
3168
3169         Reviewed by Simon Hausmann.
3170
3171         * DerivedSources.pro: Removed.
3172         * DumpRenderTree/qt/DumpRenderTree.pro:
3173         * DumpRenderTree/qt/ImageDiff.pro:
3174         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3175         * MiniBrowser/qt/MiniBrowser.pro:
3176         * QtTestBrowser/QtTestBrowser.pro:
3177         * QtTestBrowser/launcherwindow.cpp:
3178         (LauncherWindow::initializeView):
3179         (LauncherWindow::createChrome):
3180         (LauncherWindow::screenshot):
3181         * QtTestBrowser/launcherwindow.h:
3182         (WindowOptions::WindowOptions):
3183         * Scripts/build-webkit:
3184         (unlinkZeroFiles):
3185         * Scripts/webkitdirs.pm:
3186         (qtFeatureDefaults):
3187         (promptUser):
3188         (buildQMakeProject):
3189         * Tools.pro:
3190         * WebKitTestRunner/DerivedSources.pri: Added.
3191         * WebKitTestRunner/DerivedSources.pro: Removed.
3192         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
3193         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
3194         * WebKitTestRunner/InjectedBundle/Target.pri: Added.
3195         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
3196         * WebKitTestRunner/Target.pri: Added.
3197         * WebKitTestRunner/WebKitTestRunner.pro:
3198         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3199         * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
3200         * qmake/README: Added.
3201         * qmake/mkspecs/features/default_post.prf: Added.
3202         * qmake/mkspecs/features/default_pre.prf: Added.
3203         * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
3204         * qmake/mkspecs/features/functions.prf: Added.
3205         * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
3206         * qmake/mkspecs/features/mac/default_post.prf: Added.
3207         * qmake/mkspecs/features/mac/default_pre.prf: Added.
3208         * qmake/mkspecs/features/minimal_qt.prf: Added.
3209         * qmake/mkspecs/features/qtwebkit.prf: Added.
3210         * qmake/mkspecs/features/rpath.prf: Added.
3211         * qmake/mkspecs/features/unix/default_post.prf: Added.
3212         * qmake/mkspecs/features/unix/default_pre.prf: Added.
3213         * qmake/mkspecs/features/valgrind.prf: Added.
3214         * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
3215         * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
3216         * qmake/mkspecs/features/win32/default_post.prf: Added.
3217         * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
3218         * qmake/syncqt-4.8: Added.
3219         (showUsage):
3220         ():
3221         (copyFile):
3222         (symlinkFile):
3223
3224 2011-11-04  Eric Seidel  <eric@webkit.org>
3225
3226         Remove deprecated free functions in port.factory
3227         https://bugs.webkit.org/show_bug.cgi?id=71494
3228
3229         Unreviewed.  Fixing exception seen when running test-webkitpy.
3230
3231         Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
3232         unittest, since that script is nearly ready to be deleted.  But I added
3233         it back at the last second and failed to run the tests. :(
3234         This fixes the exception the bots were seeing.
3235
3236         * Scripts/webkitpy/style/checkers/test_expectations.py:
3237         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3238         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3239
3240 2011-11-02  Xiaomei Ji  <xji@chromium.org>
3241
3242         Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
3243         https://bugs.webkit.org/show_bug.cgi?id=71163
3244
3245         Reviewed by Ryosuke Niwa.
3246
3247         * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
3248         (WebPreferences::applyTo):
3249
3250 2011-11-03  Eric Seidel  <eric@webkit.org>
3251
3252         Remove deprecated free functions in port.factory
3253         https://bugs.webkit.org/show_bug.cgi?id=71494
3254
3255         Reviewed by Adam Barth.
3256
3257         I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
3258         free functions in factory.py.  To remove these required fixing all callsites
3259         to use MockHost, Host, or PortFactory where appropriate.  After this change
3260         we're only left with a handfull of places where we inappropraitely use a
3261         real Executive, FileSystem or User object during unittesting.
3262
3263         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3264          - These PortFactory overrides were from an earlier edition of my previous patch
3265            in the end, I removed MockPortFactory so all tests ended up with this same
3266            real PortFactory() with a MockHost.  This was simply redundent code.
3267         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3268          - Use MockHost to get a mocked-out PortFactory.
3269         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
3270          - This code has no access to a Host object, so we just use a default PortFactory
3271            for now.  This will still incorrectly create real Executive/FileSystem objects
3272            durring unittesting, which is wrong. :(
3273         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
3274          - Use a MockHost to get a mocked PortFactory.
3275         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3276          - Use a MockHost to get a mocked PortFactory.
3277         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
3278          - ditto.
3279         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3280          - ditto.
3281         * Scripts/webkitpy/layout_tests/port/__init__.py:
3282          - factory.get no longer exists.  Yay!
3283         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3284          - Use a MockHost to get a mocked PortFactory.
3285            To do this efficiently, I created a helper function
3286            and combined all these (mostly redundant) tests into one test
3287            with several calls to the helper function.
3288         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3289          - Pass MockUser and MockExecutive in these port testing subclasses.
3290          - I also removed a bunch of unecessary uses of mocktool. namespacing.
3291         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3292          - Awesome windows hacks should only happen on win32.  Once we started
3293            using MockExecutives these 'svn help' commands started printing in
3294            other tests, which is how I found this bug.
3295         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3296          - DryRunPort has no Host, so just use a PortFactory() directly.
3297            This will do the wrong thing if we're unittesting the DryRun port
3298            but it's no worse than the existing code.
3299         * Scripts/webkitpy/layout_tests/port/factory.py:
3300          - Remove the free functions.
3301          - Fix argument overriding to be able to override None.
3302         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3303          - Use a mocked-out PortFactory during testing.
3304         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3305          - Pass MockExecutive and MockUser to these manual Port instantiations.
3306         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
3307          - No access to a Host object here, so just using PortFactory directly.
3308            This is wrong, but no more wrong than the existing code was.
3309         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3310          - Use a MockHost to get a mocked out PortFactory.
3311         * Scripts/webkitpy/layout_tests/port/test.py:
3312          - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
3313         * Scripts/webkitpy/layout_tests/port/win.py:
3314          - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
3315            now that we're actually passing MockExecutive to most Port instantiations during testing.
3316         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3317          - Pass our new "unittesting" bool to _detect_version when actually unittesting.
3318         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3319          - Host is the future.
3320         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3321          - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
3322            we don't need to pass MockUser explicitly, it does that automatically for us.
3323         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3324          - Use a MockHost to get a mocked out PortFactory.
3325         * Scripts/webkitpy/style/checkers/test_expectations.py:
3326          - We don't have access to a Host object, so using PortFactory() directly.
3327         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3328          - Remove unused variable.
3329         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
3330          - Host isn't accessible here, so using PortFactory() directly, which
3331            although unfortunate is no worse than before.
3332         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
3333          - Testing is much easier when you don't need to hack global state...
3334         * Scripts/webkitpy/tool/commands/expectations.py:
3335          - Use the port_factory on the tool.
3336         * Scripts/webkitpy/tool/commands/rebaseline.py:
3337          - ditto.
3338         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3339          - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
3340            the arguments in the right order.  Fixing that made it use a MockFileSystem
3341            (like it had been trying to), which then required us to actually populate
3342            that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
3343         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
3344          - Get the port_factory from the tool.
3345         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3346          - Ditto.
3347         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3348          - Use a MockHost to get a mocked out Port object.
3349
3350 2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
3351
3352         [EFL] DRT: Allow choosing which backing store to use.
3353         https://bugs.webkit.org/show_bug.cgi?id=70532
3354
3355         Reviewed by Antonio Gomes.
3356
3357         This change makes it possible to change the backing store used by DRT
3358         from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
3359         setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
3360
3361         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3362         (DumpRenderTreeChrome::createView):
3363         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3364         (shouldUseSingleBackingStore):
3365         (chooseAndInitializeAppropriateSmartClass):
3366         (drtViewAdd):
3367         * DumpRenderTree/efl/DumpRenderTreeView.h:
3368
3369 2011-11-02  Erik Arvidsson  <arv@chromium.org>
3370
3371         JS Test Harness: Remove more link tags
3372         https://bugs.webkit.org/show_bug.cgi?id=71339
3373
3374         Reviewed by Ojan Vafai.
3375
3376         * Scripts/make-new-script-test:
3377         (writeTestFile): Don't output <link>
3378
3379 2011-11-03  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
3380
3381         Reviewed by Martin Robinson.
3382
3383         [GTK] arguments passed to build-jsc are not taken into account
3384         https://bugs.webkit.org/show_bug.cgi?id=58333
3385
3386         * Scripts/build-jsc:
3387
3388 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3389
3390         [GTK] Show url of history items in a status bar in MiniBrowser
3391         https://bugs.webkit.org/show_bug.cgi?id=71474
3392
3393         Reviewed by Martin Robinson.
3394
3395         * MiniBrowser/gtk/BrowserWindow.c:
3396         (browserWindowSetStatusText): Set status text and show/hide the
3397         status label.
3398         (resetStatusText): Reset status text when history menu is hidden.
3399         (browserWindowHistoryItemSelected): Show url of currently selected
3400         history item.
3401         (browserWindowCreateBackForwardMenu): Connect to hide signal of
3402         menu to reset the status text.
3403         (browserWindowConstructed): Use GtkOverlay if available to show
3404         status text.
3405
3406 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3407
3408         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
3409         https://bugs.webkit.org/show_bug.cgi?id=71466
3410
3411         Reviewed by Martin Robinson.
3412
3413         * MiniBrowser/gtk/BrowserWindow.c:
3414         (browserWindowHistoryItemActivated): Go to selected back formard
3415         list item using webkit_web_view_go_to_back_forward_list_item()
3416         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
3417         given GList of WebKitBackForwardListItems.
3418         (browserWindowUpdateNavigationActions): Enable/disable back and
3419         forward buttons depending on whether it's possible to go
3420         back/forward. Create a menu for back and forward toolbar buttons.
3421         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
3422         (browserWindowConstructed): Connect to WebKitBackForwardList
3423         changed signal.
3424
3425 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3426
3427         [Qt] Remove Maemo specific code paths
3428         https://bugs.webkit.org/show_bug.cgi?id=71476
3429
3430         Reviewed by Kenneth Rohde Christiansen.
3431
3432         * QtTestBrowser/launcherwindow.cpp:
3433         (LauncherWindow::~LauncherWindow):
3434         (LauncherWindow::init):
3435         (LauncherWindow::showLinkHover):
3436         (LauncherWindow::selectElements):
3437         (LauncherWindow::showFPS):
3438         (LauncherWindow::updateFPS):
3439         * QtTestBrowser/launcherwindow.h:
3440         (WindowOptions::WindowOptions):
3441         * QtTestBrowser/locationedit.cpp:
3442         * QtTestBrowser/locationedit.h:
3443
3444 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3445
3446         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
3447         https://bugs.webkit.org/show_bug.cgi?id=71461
3448
3449         Reviewed by Martin Robinson.
3450
3451         * MiniBrowser/gtk/BrowserWindow.c:
3452         (resetEntryProgress): Reset the entry progress after a while when
3453         load has been completed.
3454         (webViewLoadProgressChanged): Update location entry progress.
3455         (browserWindowConstructed): Connect to WebView
3456         notify::estimated-load-progress signal.
3457
3458 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3459
3460         [GTK] Remove WebKit2 C API from MiniBrowser
3461         https://bugs.webkit.org/show_bug.cgi?id=71459
3462
3463         Reviewed by Martin Robinson.
3464
3465         Use the GTK+ API instead to add minimum functionality. The other
3466         features will be ported to GTK+ API in following patches.
3467
3468         * MiniBrowser/gtk/BrowserWindow.c:
3469         (activateUriEntryCallback): Use webkit_web_view_load_uri().
3470         (goBackCallback): Use webkit_web_view_go_back().
3471         (goForwardCallback): Use webkit_web_view_go_forward().
3472         (webViewURIChanged): Update location entry with current uri using
3473         webkit_web_view_get_uri().
3474         (browserWindowFinalize):
3475         (browserWindowGetProperty):
3476         (browserWindowSetProperty):
3477         (browser_window_init):
3478         (browserWindowConstructed): Connect to notify::uri signal of
3479         WebView to be notified when the URI changes.
3480         (browser_window_class_init):
3481         (browser_window_new): Use WebKitWebView.
3482         (browser_window_get_view): Use WebKitWebView
3483         * MiniBrowser/gtk/BrowserWindow.h:
3484         * MiniBrowser/gtk/GNUmakefile.am:
3485         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
3486         * MiniBrowser/gtk/main.c:
3487         (loadURI): Use webkit_web_view_new().
3488         (main):
3489
3490 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
3491
3492         [Qt] Unable to start MiniBrowser after run-webkit-tests
3493         https://bugs.webkit.org/show_bug.cgi?id=71469
3494
3495         Reviewed by Csaba Osztrogonác.
3496
3497         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
3498         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
3499         line arguments.
3500
3501 2011-11-03  Philippe Normand  <pnormand@igalia.com>
3502
3503         [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
3504         https://bugs.webkit.org/show_bug.cgi?id=71445
3505
3506         Reviewed by Martin Robinson.
3507
3508         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3509         (initializeFonts): set directoriesDescription only when needed.
3510         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3511         (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
3512         refactored the font files loading code to avoid copy/pastes, ease
3513         maintenance and future font directories additions.
3514
3515 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3516
3517         [GTK] Remove GtkLauncher2
3518         https://bugs.webkit.org/show_bug.cgi?id=71449
3519
3520         Reviewed by Martin Robinson.
3521
3522         GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
3523         made sense when we wanted to implement the exactly same wk1 API
3524         for wk2. Now the code would require an ifdef for most the api, so
3525         it's better to remove GtkLauncher2 and port MiniBrowser to the new
3526         GTK+ API.
3527
3528         * GNUmakefile.am:
3529         * GtkLauncher/main.c:
3530         (notifyProgressCb):
3531         (closeWebViewCb):
3532         (createBrowser):
3533         (addWebSettingsGroupToContext):
3534         (main):
3535
3536 2011-11-02  Philippe Normand  <pnormand@igalia.com>
3537
3538         [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
3539         https://bugs.webkit.org/show_bug.cgi?id=71359
3540
3541         Reviewed by Martin Robinson.
3542
3543         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3544         (initializeFonts): Add the new font path for Debian fonts and
3545         refactored the font files loading code to avoid copy/pastes, ease
3546         maintenance and future font directories additions.
3547
3548 2011-11-02  Eric Seidel  <eric@webkit.org>
3549
3550         Move Mocks into _mock files near their implementations
3551         https://bugs.webkit.org/show_bug.cgi?id=71425
3552
3553         Reviewed by Adam Barth.
3554
3555         This entire change is splitting mocktool.py into separate _mock.py files
3556         and placing them next to their real implementations.
3557
3558         I also deleted MockPortFactory (since it was wrong) and was just hiding
3559         the fact that the "skipped-ports" command was broken (and has been for a long time).
3560         So I made MockHost use a real PortFactory (passed a MockHost) and changed
3561         the skipped-ports implementation to use modern PortFactory methods.
3562
3563         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
3564         * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
3565         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3566         * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3567         * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
3568         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3569         * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3570         * Scripts/webkitpy/common/host.py:
3571         * Scripts/webkitpy/common/host_mock.py: Added.
3572         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
3573         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3574         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
3575         * Scripts/webkitpy/common/net/credentials_unittest.py:
3576         * Scripts/webkitpy/common/net/failuremap_unittest.py:
3577         * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3578         * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3579         * Scripts/webkitpy/common/net/statusserver_unittest.py:
3580         * Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3581         * Scripts/webkitpy/common/system/executive.py:
3582         * Scripts/webkitpy/common/system/executive_mock.py:
3583         * Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3584         * Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
3585         * Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3586         * Scripts/webkitpy/common/system/workspace_unittest.py:
3587         * Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
3588         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3589         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
3590         * Scripts/webkitpy/layout_tests/port/__init__.py:
3591         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3592         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3593         * Scripts/webkitpy/layout_tests/port/factory.py:
3594         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3595         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3596         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
3597         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
3598         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3599         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3600         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3601         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3602         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3603         * Scripts/webkitpy/test/main.py:
3604         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
3605         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3606         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3607         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3608         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3609         * Scripts/webkitpy/tool/mocktool.py:
3610         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3611
3612 2011-11-02  Dan Bernstein  <mitz@apple.com>
3613
3614         Fixed the build and removed another copy to ColorBits.ttf.
3615
3616         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3617         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3618         * WebKitTestRunner/fonts/ColorBits.ttf: Removed.
3619
3620 2011-11-02  Dan Bernstein  <mitz@apple.com>
3621
3622         REGRESSION (r98759-r98773): platform/mac/fonts/c