[Qt] Fix -Werror for the buildbots
[WebKit-https.git] / Tools / ChangeLog
1 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
2
3         [Qt] Fix -Werror for the buildbots
4         https://bugs.webkit.org/show_bug.cgi?id=88223
5
6         Rubber-stamped by Tor Arne Vestbø.
7
8         Revert a part of r119269 to enable Werror again for non qt-developer-builds. (for bots for example)
9
10         * qmake/mkspecs/features/unix/default_post.prf:
11
12 2012-06-12  Balazs Kelemen  <kbalazs@webkit.org>
13
14         [REGRESSION][WTR] Build fail with werror after r120054
15         https://bugs.webkit.org/show_bug.cgi?id=88862
16
17         Reviewed by Csaba Osztrogonác.
18
19         Some static helpers become unused after counterValueForElementById
20         has moved to Internals. Let's remove them.
21
22         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
23         (WTR):
24
25 2012-06-12  Csaba Osztrogonác  <ossy@webkit.org>
26
27         [Qt] Slave losts cause build break on bots
28         https://bugs.webkit.org/show_bug.cgi?id=38980
29
30         Minor fix after r59261.
31
32         Reviewed by Tor Arne Vestbø.
33
34         * Scripts/build-webkit:
35         (unlinkZeroFiles): Don't remove 0 byte sized directories, because they are always 0 byte sized on Windows.
36
37 2012-06-11  Kaustubh Atrawalkar  <kaustubh@motorola.com>
38
39         [DRT] LTC:: counterValueForElementById() could be moved to Internals.
40         https://bugs.webkit.org/show_bug.cgi?id=84406
41
42         Reviewed by Hajime Morita.
43
44         Move the counterValueForElementById from LayoutTestCotroller to Internals and
45         remove the old platform specific implementations as it exclusively tests WebCore functionality.
46
47         * DumpRenderTree/LayoutTestController.cpp:
48         (LayoutTestController::staticFunctions):
49         * DumpRenderTree/LayoutTestController.h:
50         (LayoutTestController):
51         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
52         * DumpRenderTree/chromium/LayoutTestController.cpp:
53         (LayoutTestController::LayoutTestController):
54         (LayoutTestController::setPOSIXLocale):
55         * DumpRenderTree/chromium/LayoutTestController.h:
56         (LayoutTestController):
57         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
58         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
59         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
60         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
61         * DumpRenderTree/qt/LayoutTestControllerQt.h:
62         (LayoutTestController):
63         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
64         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
65         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
66         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
67         (WTR):
68         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
69         (LayoutTestController):
70
71 2012-06-11  Hans Wennborg  <hans@chromium.org>
72
73         Speech JavaScript API: Make SpeechRecognitionError an Event
74         https://bugs.webkit.org/show_bug.cgi?id=88784
75
76         Reviewed by Adam Barth.
77
78         Make it possible to have MockWebSpeechRecognizer fire error events.
79
80         * DumpRenderTree/chromium/LayoutTestController.cpp:
81         (LayoutTestController::LayoutTestController):
82         (LayoutTestController::setMockSpeechRecognitionError):
83         * DumpRenderTree/chromium/LayoutTestController.h:
84         (LayoutTestController):
85         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
86         (WebKit):
87         (ErrorTask):
88         (WebKit::ErrorTask::ErrorTask):
89         (MockWebSpeechRecognizer::addMockResult):
90         (MockWebSpeechRecognizer::setError):
91         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
92         (MockWebSpeechRecognizer):
93
94 2012-06-11  Ojan Vafai  <ojan@chromium.org>
95
96         Don't show the ASAN builders in garden-o-matic since they don't get block WebKit rolls.
97         https://bugs.webkit.org/show_bug.cgi?id=88836
98
99         Reviewed by Dirk Pranke.
100
101         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
102         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
103
104 2012-06-11  Christophe Dumez  <christophe.dumez@intel.com>
105
106         [EFL] Remove CMakeCache.txt before building
107         https://bugs.webkit.org/show_bug.cgi?id=88717
108
109         Reviewed by Antonio Gomes.
110
111         Remove CMake cache file before every build to avoid using outdated
112         build flags when new features get enabled. This will avoid unexpected
113         failures on the bots due to outdated build flags.
114
115         * Scripts/webkitdirs.pm:
116         (generateBuildSystemFromCMakeProject):
117
118 2012-06-11  Vincent Scheib  <scheib@chromium.org>
119
120         Add new Pointer Lock spec attribute webkitPointerLockElement.
121         https://bugs.webkit.org/show_bug.cgi?id=88799
122
123         Reviewed by Dimitri Glazkov.
124
125         Part of a series of refactoring changes to update pointer lock API to
126         the fullscreen locking style. https://bugs.webkit.org/show_bug.cgi?id=84402
127
128         New attribute webkitPointerLockElement added. Follow up patches
129         will remove the previous isLocked attribute. Tests updated to use
130         the new attribute.
131
132         WebViewHost logic required modification to correctly repond to
133         a lock, unlock, pointerLockElement call series. Specifically,
134         unlocking must be queued after a lock command is issued always
135         as the lock state may not be set yet with a lock request in flight.
136
137         * DumpRenderTree/chromium/WebViewHost.cpp:
138         (WebViewHost::requestPointerUnlock): Always post didLosePointerLock task.
139         (WebViewHost::didLosePointerLock): Signal didLosePointerLock only if pointer was locked.
140
141 2012-06-11  Alexis Menard  <alexis.menard@openbossa.org>
142
143         [CSS3 Backgrounds and Borders] Protect box-decoration-break behind a feature flag.
144         https://bugs.webkit.org/show_bug.cgi?id=88804
145
146         Reviewed by Tony Chang.
147
148         Protect box-decoration-break behind a feature flag enabled by default.
149
150         * Scripts/webkitperl/FeatureList.pm:
151         * qmake/mkspecs/features/features.pri:
152
153 2012-06-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
154
155         [CMAKE][EFL] Remove duplicated executable output path
156         https://bugs.webkit.org/show_bug.cgi?id=88765
157
158         Reviewed by Daniel Bates.
159
160         CMake files for EFL port have redefined executable output path. However, EFL port doesn't
161         need to define again because it is already defined in top-level CMake file.
162
163         * DumpRenderTree/efl/CMakeLists.txt:
164         * EWebLauncher/CMakeLists.txt:
165
166 2012-06-11  Ojan Vafai  <ojan@chromium.org>
167
168         Don't consider show warnings in the garden-o-matic UI for non-layout test failures
169         https://bugs.webkit.org/show_bug.cgi?id=88816
170
171         Reviewed by Dirk Pranke.
172
173         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
174         Expose a way to clear AsynchronousCaches.
175         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
176         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
177         Clear the buildInfo cache at the beginning of each test in order to avoid having one test affect another.
178
179 2012-06-11  Dirk Pranke  <dpranke@chromium.org>
180
181         nrwt exits early too frequently
182         https://bugs.webkit.org/show_bug.cgi?id=73843
183
184         Reviewed by Ryosuke Niwa.
185
186         Change the defaults for new-run-webkit-tests for both
187         --exit-after-n-failures and --exit-after-n-crashes-or-timeouts
188         to zero (i.e., we will never exit early by default).
189
190         If people want their buildbots to exit early it is their
191         responsibility to update their buildbot configs appropriately.
192
193         Note that we have tests that ensure that these flags work for
194         non-zero numbers, but we don't have tests that either test the
195         default or ensure that zero means "run all of the tests". I
196         think that's okay but can add tests if others disagree.
197
198         Also note that it looks like no changes on the build.webkit.org
199         master.cfg are necessary; all of the bots seem to be using the
200         RunWebKitTests wrapper which is already setting the flags. There
201         is a NewRunWebKitTests wrapper, but that looks to be unused; I
202         will delete that in a separate patch.
203
204         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
205         (parse_args):
206
207 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
208
209         [EFL] [DRT] Reset CacheModel before running each test
210         https://bugs.webkit.org/show_bug.cgi?id=87534
211
212         Reviewed by Gustavo Noronha Silva.
213
214         Reset cache model to default before running each test to fix some
215         flaky tests on EFL build bots. Also fix case value in setCacheModel.
216
217         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
218         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
219         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
220         (LayoutTestController::setCacheModel):
221
222 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
223
224         [GTK] Memory leaks in DRT EventSender.cpp
225         https://bugs.webkit.org/show_bug.cgi?id=88774
226
227         Reviewed by Martin Robinson.
228
229         Fix a few possible memory leaks in EventSender code.
230
231         * DumpRenderTree/gtk/EventSender.cpp:
232         (contextClickCallback): Free the event returned by gdk_event_new().
233         (mouseDownCallback): Ditto.
234         (mouseUpCallback): Ditto.
235
236 2012-06-11  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
237
238         [EFL] REGRESSION (r119788): tests rely on pathToLocalResource are failing after r119788
239         https://bugs.webkit.org/show_bug.cgi?id=88661
240
241         Reviewed by Dirk Pranke.
242
243         Pass string length explicitly when creating String object from
244         non-null-terminated UChar* returned by characters().
245
246         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
247         (LayoutTestController::pathToLocalResource):
248
249 2012-06-11  David Dorwin  <ddorwin@chromium.org>
250
251         [chromium] Provide access to the WebPlugin created by the helper plugin widget
252         https://bugs.webkit.org/show_bug.cgi?id=88028
253
254         Reviewed by Adam Barth.
255
256         Added isPlaceholder() to WebPlugin.
257
258         * DumpRenderTree/chromium/TestWebPlugin.h:
259         (TestWebPlugin::isPlaceholder):
260
261 2012-06-11  Tony Chang  <tony@chromium.org>
262
263         rebaseline from garden-o-matic leaves N processes each time it is run
264         https://bugs.webkit.org/show_bug.cgi?id=88586
265
266         Reviewed by Dirk Pranke.
267
268         This appears to only be a problem on python 2.7. Maybe a bug causing
269         pools to not be garbage collected?
270
271         * Scripts/webkitpy/common/system/executive.py:
272         (Executive.run_in_parallel): close() and join() the process pool.
273         * Scripts/webkitpy/common/system/executive_unittest.py:
274         (ExecutiveTest.test_run_in_parallel):
275
276 2012-06-11  Zoltan Horvath  <zoltan@webkit.org>
277
278         [Qt] Add config tests for WEBP imagedecoder library, modify HAVE(decoderlibrary) to USE(...)
279         https://bugs.webkit.org/show_bug.cgi?id=87841
280
281         Reviewed by Simon Hausmann.
282
283         * qmake/config.tests/libwebp/libwebp.cpp: Added.
284         (main):
285         * qmake/config.tests/libwebp/libwebp.pro: Added.
286         * qmake/sync.profile:
287
288 2012-06-10  Ryosuke Niwa  <rniwa@webkit.org>
289
290         Expose layoutTestController as testRunner
291         https://bugs.webkit.org/show_bug.cgi?id=88210
292
293         Reviewed by Darin Adler.
294
295         * DumpRenderTree/LayoutTestController.cpp:
296         (LayoutTestController::makeWindowObject):
297         * DumpRenderTree/chromium/TestShell.cpp:
298         (TestShell::bindJSObjectsToWindow):
299         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
300         (WebCore::DumpRenderTree::initJSObjects):
301         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
302         (WTR::LayoutTestController::makeWindowObject):
303
304 2012-06-09  Dominic Cooney  <dominicc@chromium.org>
305
306         [Chromium] Remove JavaScriptCore dependencies from gyp
307         https://bugs.webkit.org/show_bug.cgi?id=88510
308
309         Reviewed by Adam Barth.
310
311         Chromium doesn't support JSC any more and there doesn't seem to be
312         a strong interest in using GYP as the common build system in other
313         ports.
314
315         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
316         * Scripts/generate-project-files: Removed.
317
318 2012-06-09  Sukolsak Sakshuwong  <sukolsak@google.com>
319
320         Add UNDO_MANAGER flag
321         https://bugs.webkit.org/show_bug.cgi?id=87908
322
323         Reviewed by Tony Chang.
324
325         * Scripts/webkitperl/FeatureList.pm:
326         * qmake/mkspecs/features/features.pri:
327
328 2012-06-08  Ryosuke Niwa  <rniwa@webkit.org>
329
330         webkit-patch land-safely should set cq? if the patch author is not in committers.py
331         https://bugs.webkit.org/show_bug.cgi?id=88689
332
333         Reviewed by Dirk Pranke.
334
335         When posting a patch on Bugzilla, trun cq+ into cq? if the Bugzilla login is not listed
336         in committers.py or the contributor cannot commit. If anything, the contributor can still
337         set cq+ on thier patches manually so I don't think this will be an issue for people who
338         don't list their Bugzille email on committers.py.
339
340         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
341         (Bugzilla._commit_queue_flag):
342         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
343         (test_commit_queue_flag):
344         (test_commit_queue_flag.assert_commit_queue_flag):
345
346 2012-06-08  Dirk Pranke  <dpranke@chromium.org>
347
348         remove obsolete NewRunWebKitTests buildbot master factory classes
349         https://bugs.webkit.org/show_bug.cgi?id=88693
350
351         Reviewed by Ryosuke Niwa.
352
353         I believe these aren't used any more ...
354
355         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
356         (RunWebKitTests.getText2):
357         (BuildAndTestLeaksFactory):
358
359 2012-06-08  Xianzhu Wang  <wangxianzhu@chromium.org>
360
361         [Chromium-Android] Build DumpRenderTree with Android SDK
362         https://bugs.webkit.org/show_bug.cgi?id=88598
363
364         Change WebKit side of DRT related code according to some recent changes at chromium side.
365
366         Reviewed by Adam Barth.
367
368         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
369         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
370         (ChromiumAndroidPort.__init__):
371         (ChromiumAndroidPort._path_to_driver):
372
373 2012-06-08  Wei James  <james.wei@intel.com>
374
375         Add app_abi option for DumpRenderTree_apk
376         https://bugs.webkit.org/show_bug.cgi?id=88626
377
378         Reviewed by Adam Barth.
379
380         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
381
382 2012-06-08  Carlos Garcia Campos  <cgarcia@igalia.com>
383
384         [GTK] Add API to get the library version to WebKit2 GTK+
385         https://bugs.webkit.org/show_bug.cgi?id=88426
386
387         Reviewed by Martin Robinson.
388
389         * gtk/generate-gtkdoc:
390         (get_webkit2_options): Add built sources to the list of files, but
391         ignore enum types and marshallers.
392
393 2012-06-07  Vincent Scheib  <scheib@chromium.org>
394
395         Layout Test pointer-lock/pointerlockchange-pointerlockerror-events.html is failing
396         https://bugs.webkit.org/show_bug.cgi?id=88604
397
398         Reviewed by Kent Tamura.
399
400         DumpRenderTree fixed to not call didLosePointerLock if pointer is not currently locked.
401         Fixes debug only assert crash in pointer-lock/pointerlockchange-pointerlockerror-events.html test.
402
403         * DumpRenderTree/chromium/WebViewHost.cpp:
404         (WebViewHost::requestPointerUnlock):
405
406 2012-06-08  Hans Wennborg  <hans@chromium.org>
407
408         Speech JavaScript API: mock WebSpeechRecognizer for DumpRenderTree
409         https://bugs.webkit.org/show_bug.cgi?id=87976
410
411         Reviewed by Kent Tamura.
412
413         Provide a mock implementation of WebSpeechRecognizer for
414         DumpRenderTree. This will allow better testing of the API via layout
415         tests.
416
417         * DumpRenderTree/DumpRenderTree.gypi:
418         * DumpRenderTree/chromium/LayoutTestController.cpp:
419         (LayoutTestController::LayoutTestController):
420         (LayoutTestController::addMockSpeechRecognitionResult):
421         * DumpRenderTree/chromium/LayoutTestController.h:
422         (LayoutTestController):
423         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp: Added.
424         (MockWebSpeechRecognizer::create):
425         (MockWebSpeechRecognizer::start):
426         (MockWebSpeechRecognizer::stop):
427         (MockWebSpeechRecognizer::abort):
428         (MockWebSpeechRecognizer::MockWebSpeechRecognizer):
429         (MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
430         (MockWebSpeechRecognizer::ResultTask::runIfValid):
431         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h: Added.
432         (WebKit):
433         (MockWebSpeechRecognizer):
434         (MockWebSpeechRecognizer::addMockResult):
435         (MockWebSpeechRecognizer::taskList):
436         (ClientCallTask):
437         (MockWebSpeechRecognizer::ClientCallTask::ClientCallTask):
438         (ResultTask):
439         (MockWebSpeechRecognizer::ResultTask::ResultTask):
440         (NoMatchTask):
441         (MockWebSpeechRecognizer::NoMatchTask::NoMatchTask):
442         * DumpRenderTree/chromium/WebViewHost.cpp:
443         (WebViewHost::speechRecognizer):
444         * DumpRenderTree/chromium/WebViewHost.h:
445         (WebViewHost):
446         (WebViewHost::mockSpeechRecognizer):
447
448 2012-06-07  Kinuko Yasuda  <kinuko@chromium.org>
449
450         check-webkit-style needs to be taught about <public/Foo.h>
451         https://bugs.webkit.org/show_bug.cgi?id=88524
452
453         Reviewed by David Levin.
454
455         * Scripts/webkitpy/style/checkers/cpp.py:
456         (_classify_include):
457         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
458         (OrderOfIncludesTest.test_public_primary_header):
459         (OrderOfIncludesTest.test_classify_include):
460
461 2012-06-07  Joshua Lock  <joshua.lock@intel.com>
462
463         [EFL][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
464         https://bugs.webkit.org/show_bug.cgi?id=67255
465
466         Reviewed by Dirk Pranke.
467
468         Implement pathToLocalResource to redirect file:///tmp URL's to
469         DUMPRENDERTREE_TEMP and file:///tmp/LayoutTests to point to the
470         LayoutTests sub-directory of the WebKit source tree.
471
472         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
473         (LayoutTestController::pathToLocalResource):
474
475 2012-06-07  Tony Payne  <tpayne@chromium.org>
476
477         [chromium] Allow LayoutTests under new git workflow
478         https://bugs.webkit.org/show_bug.cgi?id=88575
479
480         On Windows, chromium indirects through git.bat. Adds the same hack that
481         is currently used for discovering svn.bat to support the new git
482         workflow.
483
484         Reviewed by Dirk Pranke.
485
486         * Scripts/webkitpy/common/checkout/scm/git.py:
487         (Git): Replaces all hard-coded references to 'git' with the class
488         variable executable_name.
489         (Git._check_git_architecture):
490         (Git.in_working_directory):
491         (Git.find_checkout_root):
492         (Git.read_git_config):
493         (Git.discard_local_commits):
494         (Git.local_commits):
495         (Git.working_directory_is_clean):
496         (Git.clean_working_directory):
497         (Git.status_command):
498         (Git.add_list):
499         (Git.delete_list):
500         (Git.exists):
501         (Git._current_branch):
502         (Git.changed_files):
503         (Git._changes_files_for_commit):
504         (Git.revisions_changing_file):
505         (Git.conflicted_files):
506         (Git.svn_revision):
507         (Git.create_patch):
508         (Git._run_git_svn_find_rev):
509         (Git.contents_at_revision):
510         (Git.diff_for_file):
511         (Git.show_head):
512         (Git.committer_email_for_revision):
513         (Git.apply_reverse_diff):
514         (Git.revert_files):
515         (Git.commit_with_message):
516         (Git._commit_on_branch):
517         (Git.svn_commit_log):
518         (Git.last_svn_commit_log):
519         (Git.svn_blame):
520         (Git._branch_ref_exists):
521         (Git.delete_branch):
522         (Git.remote_merge_base):
523         (Git.commit_locally_with_message):
524         (Git.push_local_commits_to_server):
525         (Git.commit_ids_from_commitish_arguments):
526         (Git.commit_message_for_local_commit):
527         (Git.files_changed_summary_for_commit):
528         * Scripts/webkitpy/common/host.py:
529         (Host._engage_awesome_windows_hacks): Adds an awesome 'git.bat' hack
530         that duplicates the logic in the existing 'svn.bat' hack.
531
532 2012-06-07  Ojan Vafai  <ojan@chromium.org>
533
534         Style build architectures like build versions for non-layout test failures
535         https://bugs.webkit.org/show_bug.cgi?id=88590
536
537         Reviewed by Tony Chang.
538
539         Since we show the list of failing tests after the architecture, we want the
540         buildtype and architecture to be grouped together visually.
541
542         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
543         (.effects a.failing-builder>span.architecture):
544
545 2012-06-07  Xianzhu Wang  <wangxianzhu@chromium.org>
546
547         [Chromium] Remove header dependency of ImageDiff to WTF
548         https://bugs.webkit.org/show_bug.cgi?id=88422
549
550         Reviewed by Ryosuke Niwa.
551
552         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
553         * DumpRenderTree/chromium/ImageDiff.cpp:
554         (untestedCompareImages):
555
556 2012-06-07  Dongwoo Im  <dw.im@samsung.com>
557
558         [EFL] [DRT] DRT enables WebAudio when WebAudio feature is enabled.
559         https://bugs.webkit.org/show_bug.cgi?id=88491
560
561         Reviewed by Dirk Pranke.
562
563         DRT should enable WebAudio when WebAudio feature is enabled,
564         so that the WebAudio feature could be tested by the Layouttest.
565
566         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Enable WebAudio when WebAudio feature is enabled.
567         (LayoutTestController::overridePreference):
568
569 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
570
571         webkit-patch rebaseline-expectations should only rebaseline the appropriate suffixes for the failure in question
572         https://bugs.webkit.org/show_bug.cgi?id=88581
573
574         Reviewed by Ojan Vafai.
575
576         webkit-paptch rebaseline-expectations was ignoring what the
577         expected results for a test were and pulling down all the result
578         files from a bot. This could lead to us pulling down old,
579         incorrect .txt or .png files. With this patch we will now only
580         pull down expectations of the appropriate file types (so an
581         IMAGE failure will only pull the png and not the txt file).
582
583         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
584         (has_pixel_failures):
585         (suffixes_for_expectations):
586         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
587         (FunctionsTest.test_suffixes_for_expectations):
588         * Scripts/webkitpy/tool/commands/rebaseline.py:
589         (AbstractRebaseliningCommand.__init__):
590         (RebaselineExpectations._is_supported_port):
591         (RebaselineExpectations._update_expectations_file):
592         (RebaselineExpectations._tests_to_rebaseline):
593         (RebaselineExpectations._rebaseline_port):
594         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
595         (test_overrides_are_included_correctly):
596
597 2012-06-07  Ojan Vafai  <ojan@chromium.org>
598
599         Fix recent null pointer error regression in the flakiness dashboard
600         https://bugs.webkit.org/show_bug.cgi?id=88573
601
602         Reviewed by Dirk Pranke.
603
604         * TestResultServer/static-dashboards/builders.js:
605         (requestBuilderList):
606         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
607
608 2012-06-07  Konrad Piascik  <kpiascik@rim.com>
609
610         Add Konrad Piascik to committers.py
611         https://bugs.webkit.org/show_bug.cgi?id=88560
612
613         Unreviewed.
614
615         * Scripts/webkitpy/common/config/committers.py:
616
617 2012-06-07  Tony Chang  <tony@chromium.org>
618
619         [chromium] Win mock scrollbars appear to overflow by a pixel to the right and bottom
620         https://bugs.webkit.org/show_bug.cgi?id=77368
621
622         Reviewed by Ojan Vafai.
623
624         It doesn't look like we ever get a rect with width or height of 0.
625         I ran css1, css2.1, fast/forms, and tables without any crashes.
626
627         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
628         (webRectToSkIRect): Correctly convert a WebRect to a SkIRect.
629
630 2012-06-07  Dirk Pranke  <dpranke@chromium.org>
631
632         run-webkit-tests --lint-test-files gives an error when run on linux
633         https://bugs.webkit.org/show_bug.cgi?id=88551
634
635         Reviewed by Ojan Vafai.
636
637         We weren't mapping the expectations properly for the
638         google-chrome ports.
639
640         * Scripts/webkitpy/layout_tests/port/base.py:
641         (Port.path_to_test_expectations_file):
642         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
643         (TestGoogleChromePort.test_path_to_expectations):
644
645 2012-06-07  Daniel Erat  <derat@chromium.org>
646
647         [chromium] Add LayoutTestController::setTextSubpixelPositioning() for Linux.
648         https://bugs.webkit.org/show_bug.cgi?id=88263
649
650         Reviewed by Tony Chang.
651
652         * DumpRenderTree/chromium/LayoutTestController.cpp:
653         (LayoutTestController::LayoutTestController):
654         (LayoutTestController::reset):
655         (LayoutTestController::setTextSubpixelPositioning):
656         * DumpRenderTree/chromium/LayoutTestController.h:
657         (LayoutTestController):
658         * DumpRenderTree/chromium/fonts.conf:
659
660 2012-06-07  Zan Dobersek  <zandobersek@gmail.com>
661
662         [Gtk] Assertions in gtk_widget_draw when acquiring pixel output
663         https://bugs.webkit.org/show_bug.cgi?id=88060
664
665         Reviewed by Martin Robinson.
666
667         Spin the main loop before acquiring the pixel content. This ensures things
668         like late size allocations are finished before calling gtk_widget_draw,
669         avoiding assertions and subsequent empty pixel results.
670
671         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
672         (createBitmapContextFromWebView):
673
674 2012-06-06  Kenneth Rohde Christiansen  <kenneth@webkit.org>
675
676         [Qt] Improve the visual of the viewport info box
677         https://bugs.webkit.org/show_bug.cgi?id=88410
678
679         Reviewed by Tor Arne Vestbø.
680
681         Improve the visual and make it possible to see the content more easy.
682
683         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
684
685 2012-06-06  Mariusz Grzegorczyk  <mariusz.g@samsung.com>
686
687         [EFL][WK2] Compile webkit1 and webkit2 by default.
688         https://bugs.webkit.org/show_bug.cgi?id=85041
689
690         Reviewed by Chang Shu.
691
692         Compile webkit1 and webkit2 while running Tools/Scripts/build-webkit --efl.
693         Webkit2 build can be skipped by adding --no-webkit2 option to build-webkit script.
694
695         * Scripts/build-webkit:
696
697 2012-06-06  Sheriff Bot  <webkit.review.bot@gmail.com>
698
699         Unreviewed, rolling out r119662.
700         http://trac.webkit.org/changeset/119662
701         https://bugs.webkit.org/show_bug.cgi?id=88487
702
703         Broke builds (Requested by rniwa on #webkit).
704
705         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
706         * DumpRenderTree/chromium/ImageDiff.cpp:
707         (untestedCompareImages):
708
709 2012-06-06  Xianzhu Wang  <wangxianzhu@chromium.org>
710
711         [Chromium] Remove header dependency of ImageDiff to WTF
712         https://bugs.webkit.org/show_bug.cgi?id=88422
713
714         Reviewed by Adam Barth.
715
716         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
717         * DumpRenderTree/chromium/ImageDiff.cpp:
718         (untestedCompareImages):
719
720 2012-06-06  Amy Ousterhout  <aousterh@chromium.org>
721
722         [WebKit] DeviceOrientation cleanup
723         https://bugs.webkit.org/show_bug.cgi?id=88406
724
725         Reviewed by Kent Tamura.
726
727         Updated LayoutTestController to use new public default constructor in WebDeviceOrientation.h.
728
729         * DumpRenderTree/chromium/LayoutTestController.cpp:
730         (LayoutTestController::setMockDeviceOrientation):
731
732 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
733
734         webkitpy: add support for an ordered dict of test expectations
735         https://bugs.webkit.org/show_bug.cgi?id=87802
736
737         Reviewed by Ojan Vafai.
738
739         As per https://bugs.webkit.org/show_bug.cgi?id=65834 we want to
740         support a cascaded list of test expectations files. An easy way
741         to think of this is as an ordered dictionary of name -> contents
742         for files, where the name is usually a path on disk (I say
743         usually because we want to support other kinds of expectations
744         like the compile-time skips for unsupported features in
745         webkit.py, and we want to continue to support "in-memory" test
746         expectations that don't require a filesystem).
747
748         Conveniently there is an OrderedDict implementation in Python
749         2.7+ and it is available as a backport, so the first step in
750         adding this support is to use that implementation. Subsequent
751         patches will update the test_expectations.py module (and other
752         callers) to access the dict directly.
753
754         This patch just changes the base internal implementation and
755         provides wrappers for compatibility. The derived ports
756         (WebKitPort, TestPort, etc.) still need to be updated.
757
758         * Scripts/webkitpy/layout_tests/port/base.py:
759         (Port._expectations_dict):
760         (Port.test_expectations):
761         (Port):
762         (Port._expectations_overrides_dict):
763         (Port.test_expectations_overrides):
764         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
765         (PortTestCase.test_expectations_ordering):
766         (PortTestCase):
767         (PortTestCase.test_expectations_overrides_ordering):
768         * Scripts/webkitpy/thirdparty/ordered_dict.py: Added.
769         (OrderedDict):
770         (OrderedDict.__init__):
771         (OrderedDict.clear):
772         (OrderedDict.__setitem__):
773         (OrderedDict.__delitem__):
774         (OrderedDict.__iter__):
775         (OrderedDict.__reversed__):
776         (OrderedDict.popitem):
777         (OrderedDict.__reduce__):
778         (OrderedDict.__repr__):
779         (OrderedDict.copy):
780         (OrderedDict.fromkeys):
781
782 2012-06-06  Mario Sanchez Prada  <msanchez@igalia.com>
783
784         Unreviewed gardening. Unit test fails on GTK 64bit debug bot.
785
786         * gtk/run-api-tests:
787         (TestRunner): Skip TestWebKitAPI/WTF/TestHashMap.
788
789 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
790
791         nrwt should look in 'out' for binaries on chromium win to support ninja
792         https://bugs.webkit.org/show_bug.cgi?id=88273
793
794         Reviewed by Tony Chang.
795
796         This patch standardizes the search algorithm the chromium ports
797         use to figure out which driver to run. We will look in a
798         chromium location before a webkit location (e.g., in
799         Source/WebKit/chromium/out before out/) and we will look in the
800         "legacy" directory (xcodebuild) before the directory ninja uses
801         (out).
802
803         Unfortunately due to the way the test code is set up testing the
804         properly requires some duplication of test code. I will fix that
805         in a followup patch.
806
807         * Scripts/webkitpy/layout_tests/port/chromium.py:
808         (ChromiumPort):
809         (ChromiumPort._static_build_path):
810         (ChromiumPort._build_path):
811         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
812         (ChromiumLinuxPort):
813         (ChromiumLinuxPort._determine_driver_path_statically):
814         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
815         (ChromiumLinuxPortTest.test_build_path):
816         (ChromiumLinuxPortTest):
817         (ChromiumLinuxPortTest.test_driver_name_option):
818         (ChromiumLinuxPortTest.path_to_image_diff):
819         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
820         (ChromiumMacPort):
821         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
822         (ChromiumMacPortTest.test_build_path):
823         (ChromiumMacPortTest):
824         (ChromiumMacPortTest.test_driver_name_option):
825         (ChromiumMacPortTest.path_to_image_diff):
826         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
827         (ChromiumPortTest.test_overrides_and_builder_names):
828         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
829         (ChromiumWinPort):
830         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
831         (ChromiumWinTest.test_build_path):
832         (ChromiumWinTest.test_operating_system):
833         (ChromiumWinTest):
834         (ChromiumWinTest.test_driver_name_option):
835         (ChromiumWinPortTest.path_to_image_diff):
836         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
837         (PortTestCase.assert_build_path):
838
839 2012-06-06  Jessie Berlin  <jberlin@apple.com>
840
841         Remove very red Windows WebKit2 testers
842         https://bugs.webkit.org/show_bug.cgi?id=88452
843
844         Reviewed by Steve Falkenburg.
845
846         Remove the Windows 7 Release WK2 testers so that the hardware can be repurposed. We are
847         need to focus on getting the WK1 testers green.
848
849         * BuildSlaveSupport/build.webkit.org-config/config.json:
850
851 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
852
853         get rebaselining tools to kinda work with the skia overrides file
854         https://bugs.webkit.org/show_bug.cgi?id=88456
855
856         Reviewed by Ryosuke Niwa.
857
858         Update rebaseline-expectations so that we read in the overrides
859         when looking for tests to rebaseline, but don't read in the
860         overrides when we are writing the expectations file back out.
861         This prevents the overrides from getting written into the main
862         file. This is kind of a hack but will have to do until we
863         support multiple expectations files properly.
864
865         * Scripts/webkitpy/tool/commands/rebaseline.py:
866         (RebaselineExpectations._expectations):
867         (RebaselineExpectations._update_expectations_file):
868         (RebaselineExpectations._tests_to_rebaseline):
869         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
870         (test_overrides_are_included_correctly):
871
872 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
873
874         webkitpy: two manager_worker_broker_unittest tests are broken
875         https://bugs.webkit.org/show_bug.cgi?id=88445
876
877         Reviewed by Ojan Vafai.
878
879         These tests were never updated when we removed the
880         --worker-model argument, and we were passing 'inline' instead of
881         1 (for the number of workers) :(. As a result we were creating
882         multiprocessing queues unnecessarily and that was failing on cygwin.
883
884         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
885         (InterfaceTest.test_managerconnection_is_abstract):
886         (InterfaceTest.test_workerconnection_is_abstract):
887
888 2012-06-06  Ryosuke Niwa  <rniwa@webkit.org>
889
890         REGRESSION(r117789): "webkit-patch rebaseline-expectations" copies contents in skia_test_expectations.txt into test_expectations.txt
891         https://bugs.webkit.org/show_bug.cgi?id=87406
892
893         Reviewed by Dirk Pranke.
894
895         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
896         (TestExpectations.__init__):
897         * Scripts/webkitpy/tool/commands/rebaseline.py:
898         (RebaselineTest._update_expectations_file):
899         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
900         (test_rebaseline_does_not_include_overrides):
901
902 2012-06-06  Dirk Pranke  <dpranke@chromium.org>
903
904         webkitpy: perf tests unit tests fail on chromium win
905         https://bugs.webkit.org/show_bug.cgi?id=88279
906
907         Reviewed by Ryosuke Niwa.
908
909         I'm seeing weird failures running the unit tests in my win32
910         checkout, and we don't really expect webpagereplay to work on
911         win32 anyway, so I'm skipping the import of that module for now
912         and adding a warning.
913
914         * Scripts/run-perf-tests:
915         * Scripts/webkitpy/performance_tests/perftest.py:
916
917 2012-06-06  Yong Li <yoli@rim.com>
918
919         Unreviewed. Update my email address in committers.py.
920
921         * Scripts/webkitpy/common/config/committers.py:
922
923 2012-06-06  Robert Kroeger  <rjkroege@chromium.org>
924
925         Add Robert Kroeger  to commiters.py
926         https://bugs.webkit.org/show_bug.cgi?id=88415
927
928         Unreviewed.
929
930         * Scripts/webkitpy/common/config/committers.py:
931
932 2012-06-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
933
934         [EFL][DRT] http/tests/globalhistory testcases do not pass
935         https://bugs.webkit.org/show_bug.cgi?id=82579
936
937         Reviewed by Csaba Osztrogonác.
938
939         DRT has provided callbacks for ewk_view "global history delegate" signals.
940
941         * DumpRenderTree/efl/DumpRenderTree.cpp:
942         (isGlobalHistoryTest): Aux function to ident global history testcase.
943         (createLayoutTestController):
944         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
945         (DumpRenderTreeChrome::createView):
946         (DumpRenderTreeChrome::onTitleChanged): Handles also some global history testcases.
947         (DumpRenderTreeChrome::onWebViewNavigatedWithData): New callback function.
948         (DumpRenderTreeChrome::onWebViewServerRedirect): Ditto.
949         (DumpRenderTreeChrome::onWebViewClientRedirect): Ditto.
950         (DumpRenderTreeChrome::onWebViewPopulateVisitedLinks): Ditto.
951         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
952         (DumpRenderTreeChrome):
953
954 2012-06-06  János Badics  <jbadics@inf.u-szeged.hu>
955
956         [Qt] run-qtwebkit-tests hangs with -j1
957         run-qtwebkit-tests used to hang when wk2 API tests were run with -j1 and --timeout.
958         This could happen due to an uncancelled timer after results were returned. This timer was
959         started only if --timeout was set.
960         https://bugs.webkit.org/show_bug.cgi?id=85475
961
962         Reviewed by Csaba Osztrogonác.
963
964         * Scripts/run-qtwebkit-tests:
965         (run_test):
966
967 2012-06-06  Michael Brüning  <michael.bruning@nokia.com>
968
969         [Qt][WK2] Add preferredMinimumContentsWidth to the viewport info in MiniBrowser.
970         https://bugs.webkit.org/show_bug.cgi?id=88327
971
972         Reviewed by Kenneth Rohde Christiansen.
973
974         * MiniBrowser/qt/MiniBrowser.qrc: Added contents_width.png.
975         * MiniBrowser/qt/icons/contents_width.png: Added.
976         * MiniBrowser/qt/qml/BrowserWindow.qml: Added button for toggling preferredMinimumContentsWidth.
977         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added display of preferredMinimumContentsWidth.
978
979 2012-06-05  Jon Lee  <jonlee@apple.com>
980
981         Buildbot fix.
982
983         * BuildSlaveSupport/build.webkit.org-config/master.cfg: We lose the type attribute earlier
984         in the function. Store in a local variable.
985         (loadBuilderConfig):
986
987 2012-06-05  Jon Lee  <jonlee@apple.com>
988
989         Buildbot fix.
990
991         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
992         (loadBuilderConfig):
993
994 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
995
996         webkitpy: clean up win-specific path handling and tests
997         https://bugs.webkit.org/show_bug.cgi?id=88281
998
999         Reviewed by Adam Barth.
1000
1001         There was a bunch of inconsistent logic for handling path
1002         conversions for win32 and cygwin paths due to us sometimes
1003         looking at sys.platform and sometimes using mock hosts. This
1004         patch cleans everything up so that we are required to pass
1005         PlatformInfo objects to the path module and stop trying to do
1006         different things when running on cygwin or win32 hosts (except
1007         in the path_unittest module itself).
1008
1009         This may slightly reduce test coverage for the win32 code paths
1010         but will be a lot easier to follow and maintain.
1011
1012         * Scripts/webkitpy/common/system/path.py:
1013         (abspath_to_uri):
1014         (_convert_path):
1015         * Scripts/webkitpy/common/system/path_unittest.py:
1016         (AbspathTest.platforminfo):
1017         (AbspathTest.test_abspath_to_uri_cygwin):
1018         (AbspathTest.test_abspath_to_uri_unixy):
1019         (AbspathTest.test_abspath_to_uri_win):
1020         (AbspathTest.test_abspath_to_uri_escaping_unixy):
1021         (AbspathTest.test_abspath_to_uri_escaping_cygwin):
1022         (AbspathTest.test_stop_cygpath_subprocess):
1023         * Scripts/webkitpy/common/system/platforminfo.py:
1024         (PlatformInfo.__init__):
1025         (PlatformInfo.is_cygwin):
1026         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1027         (MockPlatformInfo.is_cygwin):
1028         * Scripts/webkitpy/layout_tests/port/base.py:
1029         (Port.to.show_results_html_file):
1030         * Scripts/webkitpy/layout_tests/port/driver.py:
1031         (Driver.test_to_uri):
1032         (Driver.uri_to_test):
1033         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1034         (DriverTest.test_test_to_uri):
1035         (DriverTest.test_uri_to_test):
1036         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1037         (MockDRTPortTest.make_port):
1038         (MockDRTTest.input_line):
1039         (MockChromiumDRTTest.test_pixeltest__fails):
1040         * Scripts/webkitpy/layout_tests/port/test.py:
1041         * Scripts/webkitpy/layout_tests/port/win.py:
1042         (WinPort.show_results_html_file):
1043         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1044         (MainTest.test_unexpected_failures):
1045         (MainTest.test_results_directory_absolute):
1046         (MainTest.test_results_directory_default):
1047         (MainTest.test_results_directory_relative):
1048
1049 2012-06-05  Jon Lee  <jonlee@apple.com>
1050
1051         Workaround buildbot bug when merging build requests.
1052         https://bugs.webkit.org/show_bug.cgi?id=88158
1053
1054         Reviewed by Mark Rowe.
1055
1056         For expediency, we still want testers to pick the latest build to test, but to ensure
1057         that the builders are reporting the correct revision number, we should let the building bots
1058         run as they normally would. That is, the builder picks the oldest revision, and merges
1059         subsequent requests. Because merged requests get appended to the list of changes for a given
1060         build, the last change in that list is also the latest change. When we used pickLatestBuild
1061         for the builders, this was not the case (it would always report the penultimate change).
1062
1063         http://trac.buildbot.net/ticket/2309 is tracking the buildbot bug.
1064
1065         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove the mergeRequests override
1066         for all Apple builders.
1067         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Have only non-building bots pick
1068         the latest build to run.
1069         (loadBuilderConfig):
1070
1071 2012-06-05  Jessie Berlin  <jberlin@apple.com>
1072
1073         [Win] DumpRenderTree should call resetInternalsObject
1074         https://bugs.webkit.org/show_bug.cgi?id=88346
1075
1076         Reviewed by Simon Fraser.
1077
1078         Invoke it on Windows in the same place it is invoked on Mac.
1079
1080         * DumpRenderTree/win/DumpRenderTree.cpp:
1081         (resetWebViewToConsistentStateBeforeTesting):
1082
1083 2012-06-05  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1084
1085         [GTK] Fix two more memory leaks in DRT
1086         https://bugs.webkit.org/show_bug.cgi?id=88255
1087
1088         Reviewed by Martin Robinson.
1089
1090         Fixed memory leaks in GTK's DRT code.
1091
1092         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1093         (dumpHistoryItem): webkit_web_history_item_get_target() returns a
1094         g_strdup()'d string. So, use GOwnPtr to manage memory automatically.
1095         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
1096         (createBitmapContextFromWebView): Free the cairo surface.
1097
1098 2012-06-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
1099
1100         [Qt] Building when a top directory is named Source
1101         https://bugs.webkit.org/show_bug.cgi?id=77727
1102
1103         Reviewed by Tor Arne Vestbø.
1104
1105         Change regex to only replace the last instance of OUT_PWD.
1106
1107         * qmake/mkspecs/features/default_pre.prf:
1108
1109 2012-06-05  Dongwoo Im  <dw.im@samsung.com>
1110
1111         Add 'isProtocolHandlerRegistered' and 'unregisterProtocolHandler'.
1112         https://bugs.webkit.org/show_bug.cgi?id=73176
1113
1114         Reviewed by Adam Barth.
1115
1116         Two more APIs are added in Custom Scheme Handler specification.
1117         http://dev.w3.org/html5/spec/Overview.html#custom-handlers
1118         One is 'isProtocolHandlerRegistered' to query whether the specific URL
1119         is registered or not.
1120         The other is 'unregisterProtocolHandler' to remove the registered URL.
1121
1122         * Scripts/webkitperl/FeatureList.pm: Add a macro 'ENABLE_CUSTOM_SCHEME_HANDLER'.
1123
1124 2012-06-05  Mario Sanchez Prada  <msanchez@igalia.com>
1125
1126         [GTK][WK2] Implement API for Geolocation permission requests in the GTK port
1127         https://bugs.webkit.org/show_bug.cgi?id=83879
1128
1129         Reviewed by Carlos Garcia Campos.
1130
1131         Make minibrowser connect to the new 'permission requests' signal
1132         to allow users handle the Geolocation permission requests.
1133
1134         * MiniBrowser/gtk/BrowserWindow.c:
1135         (geolocationRequestDialogCallback): Callback for the dialog asking
1136         the user for allowing or not geolocation permission requests.
1137         (webViewDecidePermissionRequest): Launch a dialog to ask the user
1138         whether to allow or deny geolocation permission requests.
1139         (browserWindowConstructed): Connect to 'permission-request' signal.
1140
1141 2012-06-04  Chase Phillips  <cmp@google.com>
1142
1143         Make a builder group support+expect multiple loads.
1144         https://bugs.webkit.org/show_bug.cgi?id=88260
1145
1146         Change BuilderGroup to allow expecting multiple
1147         loads.  This allows merging results for a given set
1148         of builders into one group.
1149
1150         Add a test that verifies that the group count
1151         increments correctly based on successful and failed
1152         list loads.
1153
1154         Reviewed by Ojan Vafai.
1155
1156         * TestResultServer/static-dashboards/builders.js:
1157         (BuilderGroup):
1158         (BuilderGroup.prototype.setbuilder):
1159         (BuilderGroup.prototype.append):
1160         (BuilderGroup.prototype.loaded):
1161         (requestBuilderList.xhr.onload):
1162         (requestBuilderList.xhr.onerror):
1163         (onErrorLoadingBuilderList):
1164         (loadBuildersList):
1165         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1166         (test):
1167         * TestResultServer/static-dashboards/run-unittests.html:
1168
1169 2012-06-04  Ryosuke Niwa  <rniwa@webkit.org>
1170
1171         Python test fix attempt for Chromium Windows.
1172
1173         * Scripts/webkitpy/layout_tests/port/driver.py:
1174         (Driver.uri_to_test):
1175
1176 2012-06-04  Hugo Parente Lima  <hugo.lima@openbossa.org>
1177
1178         Turn LEGACY_VIEWPORT_ADAPTION USE flag into an ENABLE flag.
1179         https://bugs.webkit.org/show_bug.cgi?id=88243
1180
1181         Reviewed by Adam Barth.
1182
1183         * qmake/mkspecs/features/features.prf:
1184
1185 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1186
1187         webkitpy.layout_tests.port.server_process_unittest.TestServerProcess.test_basic is flaky
1188         https://bugs.webkit.org/show_bug.cgi?id=88280
1189
1190         Unreviewed, build fix.
1191
1192         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1193         (TestServerProcess.test_basic):
1194
1195 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1196
1197         test-webkitpy is hanging under cygwin
1198         https://bugs.webkit.org/show_bug.cgi?id=88269
1199
1200         Reviewed by Ryosuke Niwa.
1201
1202         The 'multiprocessing' module doesn't work correctly under Cygwin yet,
1203         so we need to skip any tests that use it.
1204
1205         * Scripts/webkitpy/common/system/executive.py:
1206         (Executive.run_in_parallel):
1207         * Scripts/webkitpy/common/system/executive_unittest.py:
1208         (ExecutiveTest.test_run_in_parallel):
1209
1210 2012-06-04  Dirk Pranke  <dpranke@chromium.org>
1211
1212         test-webkitpy is failing on win32 after r115054
1213         https://bugs.webkit.org/show_bug.cgi?id=88264
1214
1215         Reviewed by Ryosuke Niwa.
1216
1217         The failing http_server test was improperly suppressed (the
1218         tuple was missing a comma, and so wasn't a tuple at all, just a
1219         string) and so we were skipping *all* tests on win32. The right
1220         way to skip a single test is to disable it inside the test
1221         itself.
1222
1223         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
1224         (TestHttpServer.test_start_cmd):
1225         * Scripts/webkitpy/test/test_finder.py:
1226         (TestFinder._default_names):
1227         * Scripts/webkitpy/test/main.py:
1228         (Tester.run): Add error message if we don't find any tests to run.
1229         * Scripts/webkitpy/test/main_unittest.py:
1230             
1231
1232 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1233
1234         [GTK] Memory leaks in AccessibilityUIElementGtk.cpp
1235         https://bugs.webkit.org/show_bug.cgi?id=88215
1236
1237         Reviewed by Martin Robinson.
1238
1239         Fixed memory leaks in AccessibilityUIElement by using GOwnPtr
1240         for newly allocated strings.
1241
1242         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
1243         (attributeSetToString):
1244         (AccessibilityUIElement::allAttributes):
1245
1246 2012-06-04  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1247
1248         [GTK] Memory leaks in DumpRenderTree.cpp
1249         https://bugs.webkit.org/show_bug.cgi?id=88213
1250
1251         Reviewed by Martin Robinson.
1252
1253         Fixed memory leaks in DumpRenderTree.
1254
1255         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1256         (appendString): Accepts const gchar* as the second argument.
1257         (dumpFramesAsText): Free the string returned by g_strdup_printf().
1258         (dumpHistoryItem): Free the string returned by g_uri_parse_scheme().
1259
1260 2012-06-04  David Dorwin  <ddorwin@chromium.org>
1261
1262         Enable Chromium media player to instantiate a plugin
1263         https://bugs.webkit.org/show_bug.cgi?id=87399
1264
1265         Reviewed by Kent Tamura.
1266
1267         Adds WebHelperPlugin, an off-screen widget that contains an <object> tag.
1268
1269         * DumpRenderTree/chromium/WebViewHost.cpp:
1270         (WebViewHost::createPopupMenu):
1271
1272 2012-06-04  Mario Sanchez Prada  <msanchez@igalia.com>
1273
1274         [GTK][WK2] Implement geolocation provider for the GTK port
1275         https://bugs.webkit.org/show_bug.cgi?id=83877
1276
1277         Reviewed by Carlos Garcia Campos.
1278
1279         * gtk/generate-gtkdoc:
1280         (get_webkit2_options): Ignore WebKitGeolocationProvider files.
1281
1282 2012-06-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1283
1284         [EFL] Reset "WebKitTabToLinksPreferenceKey" in DumpRenderTreeChrome::resetDefaultsToConsistentValues
1285         https://bugs.webkit.org/show_bug.cgi?id=87668
1286
1287         Reviewed by Ryosuke Niwa.
1288
1289         Layout test controller "WebKitTabToLinksPreferenceKey" setting should be reset to false
1290         otherwise LayoutTests/fast/html/tab-order.html is failing as it has a link inside the test description which might 
1291         be included in focus chain (if "WebKitTabToLinksPreferenceKey" setting is set to true). 
1292
1293         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1294         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1295
1296 2012-06-04  Tomasz Morawski  <t.morawski@samsung.com>
1297
1298         [EFL] Refactor ewk_view_context_paint code.
1299         https://bugs.webkit.org/show_bug.cgi?id=85588
1300
1301         Reviewed by Hajime Morita.
1302
1303         * DumpRenderTree/efl/CMakeLists.txt: Added include directory.
1304
1305 2012-06-04  Christophe Dumez  <christophe.dumez@intel.com>
1306
1307         [EFL] Compilation warning in DumpRenderTreeView.cpp on 64-Bit
1308         https://bugs.webkit.org/show_bug.cgi?id=87869
1309
1310         Reviewed by Andreas Kling.
1311
1312         Replace %lld by PRId64 macro to print an int64_t value and silent a
1313         compilation warning on 64-Bit.
1314
1315         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1316         (onExceededApplicationCacheQuota):
1317
1318 2012-06-03  Varun Jain  <varunjain@google.com>
1319
1320         [chromium] Add new gesture type (two finger tap) that triggers context menu.
1321         https://bugs.webkit.org/show_bug.cgi?id=88173
1322
1323         Reviewed by Adam Barth.
1324
1325         * DumpRenderTree/chromium/EventSender.cpp:
1326         (EventSender::EventSender):
1327         (EventSender::gestureTwoFingerTap):
1328         (EventSender::gestureEvent):
1329         * DumpRenderTree/chromium/EventSender.h:
1330         (EventSender):
1331
1332 2012-06-02  Zeno Albisser  <zeno@webkit.org>
1333
1334         Fix and enable WebGL for WebKit2 on Qt.
1335         https://bugs.webkit.org/show_bug.cgi?id=86214
1336
1337         Enable WebGL by default for Qt MiniBrowser.
1338
1339         Reviewed by Noam Rosenthal.
1340
1341         * MiniBrowser/qt/qml/BrowserWindow.qml:
1342
1343 2012-06-02  Ryosuke Niwa  <rniwa@webkit.org>
1344
1345         Teach svn-apply how to apply changes in test_expectations.txt to TestExpectations
1346         https://bugs.webkit.org/show_bug.cgi?id=88164
1347
1348         Reviewed by Kentaro Hara.
1349
1350         Just like r74856, adjust git/svn headers from test_expectations.txt to TestExpectations.
1351         Also replace all occurrences of /test_expectations.txt: by /TestExpectations: in change log entries.
1352
1353         * Scripts/VCSUtils.pm:
1354         (adjustPathForRecentRenamings):
1355         (fixChangeLogPatch):
1356
1357 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1358
1359         Rename test_expectations.txt to TestExpectations
1360         https://bugs.webkit.org/show_bug.cgi?id=86690
1361
1362         Reviewed by Dirk Pranke.
1363
1364         Make webkitpy aware of both test_expectations.txt and TestExpectations while we rename files.
1365         We can the code to read test_expectations.txt once we've successfully transitioned.
1366
1367         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1368         (TestExpectationParser._check_path_does_not_exist):
1369         (TestExpectationParser._tokenize):
1370         (TestExpectations): Removed TEST_LIST, which is not used anywhere.
1371         * Scripts/webkitpy/layout_tests/port/base.py:
1372         (Port.path_to_test_expectations_file): Moved from WebKitPort and ChromiumPort. Returns the path to
1373         test_expectations.txt if one exists and the path to TestExpectations otherwise.
1374         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1375         (PortTest.test_virtual_methods): path_to_test_expectations_file and test_expectations are no longer
1376         virtual.
1377         * Scripts/webkitpy/layout_tests/port/chromium.py:
1378         (ChromiumPort.path_from_chromium_base):
1379         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1380         (ChromiumAndroidPort.test_expectations):
1381         * Scripts/webkitpy/layout_tests/port/test.py:
1382         (add_unit_tests_to_mock_filesystem): Use TestExpectations instead of test_expectations.txt.
1383         (TestPort.__init__):
1384         * Scripts/webkitpy/layout_tests/port/webkit.py:
1385         (WebKitPort.baseline_search_path):
1386         (WebKitPort.test_expectations):
1387         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added some test cases. We should move these
1388         tests to base as a follow up.
1389         (WebKitPortTest.test_path_to_test_expectations_file):
1390         (test_test_expectations):
1391         (test_legacy_test_expectations):
1392         * Scripts/webkitpy/style/checker.py:
1393         (CheckerDispatcher.should_skip_without_warning): Replace the check for legacy drt_expectations.txt
1394         with one for TestExpectations.
1395         * Scripts/webkitpy/style/checkers/test_expectations.py:
1396         (TestExpectationsChecker): Accept both test_expectations.txt and TestExpectations in warning outputs.
1397         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1398         (TestExpectationsTestCase._expect_port_for_expectations_path): Test both TestExpectations and
1399         test_expectations.txt.
1400         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
1401         (TestExpectationsTestCase.assert_lines_lint):
1402         * Scripts/webkitpy/tool/commands/queries.py:
1403         (PrintExpectations.__init__):
1404         * Scripts/webkitpy/tool/commands/rebaseline.py:
1405         (RebaselineExpectations):
1406         * Scripts/webkitpy/tool/steps/commit.py:
1407         (Commit._check_test_expectations):
1408         * Scripts/webkitpy/tool/steps/commit_unittest.py:
1409         (CommitTest._test_check_test_expectations): Extracted from test_check_test_expectations.
1410         (CommitTest.test_check_test_expectations): For TestExpectations.
1411         (CommitTest.test_check_legacy_test_expectations): For test_expectations.txt
1412         * TestResultServer/static-dashboards/dashboard_base.js:
1413         (requestExpectationsFile): Look for TestExpectations first, and fallback to test_expectations.txt.
1414         Error only when neither exists.
1415         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1416         (processMissingAndExtraExpectations):
1417         (htmlForTestsWithExpectationsButNoFailures):
1418         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1419
1420 2012-06-01  Xianzhu Wang  <wangxianzhu@chromium.org>
1421
1422         Remove dependency from ImageDiff to WTF
1423         https://bugs.webkit.org/show_bug.cgi?id=88147
1424
1425         Reviewed by Adam Barth.
1426
1427         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1428
1429 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1430
1431         NRWT seems to leak (more?) temp dirs
1432         https://bugs.webkit.org/show_bug.cgi?id=88126
1433
1434         Re-land r119297 with chromium fix (weren't calling the
1435         super() method if not in --test-shell mode in start().
1436         Add unit tests to chromium_unittest as well to check.
1437
1438         * Scripts/webkitpy/layout_tests/port/chromium.py:
1439         (ChromiumDriver.start):
1440         * Scripts/webkitpy/layout_tests/port/webkit.py:
1441         (WebKitDriver.__del__):
1442         (WebKitDriver._start):
1443         (WebKitDriver.run_test):
1444         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1445         (WebKitDriverTest.test_check_for_driver_crash):
1446         (WebKitDriverTest.test_stop_cleans_up_properly):
1447         (WebKitDriverTest):
1448         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1449         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1450         (ChromiumDriverTest.test_stop_cleans_up_properly):
1451         (ChromiumDriverTest.test_two_starts_cleans_up_properly):
1452
1453 2012-06-01  Tim Horton  <timothy_horton@apple.com>
1454
1455         Lots of "failed download-built-product" on Apple bots
1456         https://bugs.webkit.org/show_bug.cgi?id=88158
1457
1458         Reviewed by Jessie Berlin.
1459         
1460         Disable mergeRequests on all Apple builders. This is a speculative fix.
1461
1462         * BuildSlaveSupport/build.webkit.org-config/config.json:
1463
1464 2012-06-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1465
1466         Unreviewed, rolling out r119297.
1467         http://trac.webkit.org/changeset/119297
1468         https://bugs.webkit.org/show_bug.cgi?id=88156
1469
1470         May have broken Chromium bots (Requested by rniwa on #webkit).
1471
1472         * Scripts/webkitpy/layout_tests/port/webkit.py:
1473         (WebKitDriver.__del__):
1474         (WebKitDriver.run_test):
1475         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1476         (WebKitDriverTest.test_check_for_driver_crash):
1477         (WebKitDriverTest.test_stop_cleans_up_properly):
1478
1479 2012-06-01  Dirk Pranke  <dpranke@chromium.org>
1480
1481         nrwt seems to leak tmpdirs
1482         https://bugs.webkit.org/show_bug.cgi?id=88126
1483
1484         Reviewed by Ojan Vafai.
1485
1486         Fix leak possibly introduced in r118979 - we now will
1487         make sure we clean up any stale temp directories during the
1488         start routine and attempt to clean up again in __del__. It
1489         turns out that asserting in __del__ logs a message but is
1490         caught by the runtime, so it's mostly useless.
1491
1492         * Scripts/webkitpy/layout_tests/port/webkit.py:
1493         (WebKitDriver.__del__):
1494         (WebKitDriver._start):
1495         (WebKitDriver.run_test):
1496         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1497         (WebKitDriverTest.test_check_for_driver_crash):
1498         (WebKitDriverTest.test_stop_cleans_up_properly):
1499         (WebKitDriverTest):
1500         (WebKitDriverTest.test_two_starts_cleans_up_properly):
1501
1502 2012-06-01  Michael Saboff  <msaboff@apple.com>
1503
1504         WebFrame::_stringByEvaluatingJavaScriptFromString methods don't handle nil string
1505         https://bugs.webkit.org/show_bug.cgi?id=88109
1506
1507         Reviewed by Geoffrey Garen.
1508
1509         Additional test case.
1510
1511         * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
1512         (TestWebKitAPI::TEST):
1513
1514 2012-06-01  Simon Hausmann  <simon.hausmann@nokia.com>
1515
1516         [Qt] Use -Werror only in developer builds
1517
1518         Rubber-stamped by Tor Arne Vestbø.
1519
1520         In production builds -Werror with custom toolchains and wierd system
1521         headers, -Werror is of no use and just creates confusion. So use it
1522         only if Qt is configured with -developer-build.
1523
1524         * qmake/mkspecs/features/default_pre.prf: Move qt_developer_build determination here...
1525         * qmake/mkspecs/features/unix/default_post.prf: ... so that we can use it here to do -Werror
1526         only if qt_developer_build is set.
1527
1528 2012-06-01  Jochen Eisinger  <jochen@chromium.org>
1529
1530         [watchlist] Add myself to loader and v8 bindings changes
1531         https://bugs.webkit.org/show_bug.cgi?id=88112
1532
1533         Reviewed by Adam Barth.
1534
1535         * Scripts/webkitpy/common/config/watchlist:
1536
1537 2012-06-01  Jacky Jiang  <zhajiang@rim.com>
1538
1539         Adding Jacky Jiang to committers.py
1540         https://bugs.webkit.org/show_bug.cgi?id=88122
1541
1542         Reviewed by Rob Buis.
1543
1544         Adding myself to committers.py as a Committer.
1545
1546         * Scripts/webkitpy/common/config/committers.py:
1547
1548 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1549
1550         Fix Windows build.
1551
1552         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1553
1554 2012-06-01  Jessie Berlin  <jberlin@apple.com>
1555
1556         Windows WK2 MouseMoveAfterCrash API test failing
1557         https://bugs.webkit.org/show_bug.cgi?id=69982
1558
1559         Disable the test on Windows to get the bots greener.
1560
1561         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
1562         (TestWebKitAPI::TEST):
1563
1564 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1565
1566         [EFL] EFL port does not enable WEB_INTENTS_TAG flag
1567         https://bugs.webkit.org/show_bug.cgi?id=86866
1568
1569         Reviewed by Adam Barth.
1570
1571         Catch new "intent,service,register" signal on the frame and print out
1572         information about the Web Intent service in EFL's DumpRenderTree.
1573
1574         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1575         (DumpRenderTreeChrome::createView):
1576         (DumpRenderTreeChrome::onFrameCreated):
1577         (DumpRenderTreeChrome::onFrameIntentServiceRegistration):
1578         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1579         (DumpRenderTreeChrome):
1580
1581 2012-06-01  Martin Robinson  <mrobinson@igalia.com>
1582
1583         The ChangeLog parser cannot handle reviewers with initials in their name
1584         https://bugs.webkit.org/show_bug.cgi?id=87864
1585
1586         Reviewed by Ryosuke Niwa.
1587
1588         Add support in the ChangeLog parser for reviewer names that have
1589         initials in them.
1590
1591         * Scripts/webkitpy/common/checkout/changelog.py:
1592         (ChangeLogEntry): Add a new group of regular expressions that need a backreference
1593         in the replacement string. This allows for matching the word characters before a
1594         period, without totally throwing them away.
1595         (ChangeLogEntry._parse_reviewer_text): Use the new regular expression.
1596         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1597         (test_fuzzy_reviewer_match_initial): Add a test for a reviewer name that has an initial.
1598
1599 2012-06-01  Christophe Dumez  <christophe.dumez@intel.com>
1600
1601         [EFL] EFL's LayoutTestController needs to implement deliverWebIntent
1602         https://bugs.webkit.org/show_bug.cgi?id=86865
1603
1604         Reviewed by Adam Barth.
1605
1606         Add deliverWebIntent method to LayoutTestController and provide
1607         implementation for EFL port.
1608
1609         * DumpRenderTree/LayoutTestController.cpp:
1610         (deliverWebIntentCallback):
1611         (LayoutTestController::staticFunctions):
1612         * DumpRenderTree/LayoutTestController.h:
1613         (LayoutTestController):
1614         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
1615         (LayoutTestController::deliverWebIntent):
1616         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1617         (LayoutTestController::deliverWebIntent):
1618         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1619         (LayoutTestController::deliverWebIntent):
1620         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1621         (LayoutTestController::deliverWebIntent):
1622         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1623         (LayoutTestController::deliverWebIntent):
1624         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
1625         (LayoutTestController::deliverWebIntent):
1626
1627 2012-06-01  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1628
1629         [Qt] Make Qt Creator aware of files in webkitpy/perl for easy editing
1630
1631         Reviewed by Simon Hausmann.
1632
1633         * Tools.pro:
1634
1635 2012-06-01  Ryosuke Niwa  <rniwa@webkit.org>
1636
1637         Add public page loading performance tests using web-page-replay
1638         https://bugs.webkit.org/show_bug.cgi?id=84008
1639
1640         Reviewed by Dirk Pranke.
1641
1642         Add the primitive implementation of replay performance tests. We use web-page-replay (http://code.google.com/p/web-page-replay/)
1643         to cache data locally. Each replay test is represented by a text file with .replay extension containing a single URL.
1644         To hash out bugs and isolate them from the rest of performance tests, replay tests are hidden behind --replay flag.
1645
1646         Run "run-perf-tests --replay PerformanceTests/Replay" after changing the system network preference to forward HTTP and HTTPS requests
1647         to localhost:8080 and localhost:8443 respectively (i.e. configure the system as if there are HTTP proxies at ports 8080 and 8443)
1648         excluding: *.webkit.org, *.googlecode.com, *.sourceforge.net, pypi.python.org, and www.adambarth.com for thirdparty Python dependencies.
1649         run-perf-tests starts web-page-replay, which provides HTTP proxies at ports 8080 and 8443 to replay pages.
1650
1651         * Scripts/webkitpy/layout_tests/port/driver.py:
1652         (Driver.is_external_http_test): Added.
1653         * Scripts/webkitpy/layout_tests/port/webkit.py:
1654         (WebKitDriver._command_from_driver_input): Allow test names that starts with http:// or https://.
1655         * Scripts/webkitpy/performance_tests/perftest.py:
1656         (PerfTest.__init__): Takes port.
1657         (PerfTest.prepare): Added. Overridden by ReplayPerfTest.
1658         (PerfTest):
1659         (PerfTest.run): Calls run_single.
1660         (PerfTest.run_single): Extracted from PageLoadingPerfTest.run.
1661         (ChromiumStylePerfTest.__init__):
1662         (PageLoadingPerfTest.__init__):
1663         (PageLoadingPerfTest.run):
1664         (ReplayServer): Added. Responsible for starting and stopping replay.py in the web-page-replay.
1665         (ReplayServer.__init__):
1666         (ReplayServer.wait_until_ready): Wait until port 8080 is ready. I have tried looking at the piped output from web-page-replay
1667         but it caused a dead lock on some web pages.
1668         (ReplayServer.stop):
1669         (ReplayServer.__del__):
1670         (ReplayPerfTest):
1671         (ReplayPerfTest.__init__):
1672         (ReplayPerfTest._start_replay_server):
1673         (ReplayPerfTest.prepare): Creates test.wpr and test-expected.png to cache the page when a replay test is ran for the first time.
1674         The subsequent runs of the same test will just use test.wpr.
1675         (ReplayPerfTest.run_single):
1676         (PerfTestFactory):
1677         (PerfTestFactory.create_perf_test):
1678         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1679         (MainTest.test_parse_output):
1680         (MainTest.test_parse_output_with_failing_line):
1681         (TestPageLoadingPerfTest.test_run):
1682         (TestPageLoadingPerfTest.test_run_with_bad_output):
1683         (TestReplayPerfTest):
1684         (TestReplayPerfTest.ReplayTestPort):
1685         (TestReplayPerfTest.ReplayTestPort.__init__):
1686         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver):
1687         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
1688         (TestReplayPerfTest.ReplayTestPort._driver_class):
1689         (TestReplayPerfTest.MockReplayServer):
1690         (TestReplayPerfTest.MockReplayServer.__init__):
1691         (TestReplayPerfTest.MockReplayServer.stop):
1692         (TestReplayPerfTest._add_file):
1693         (TestReplayPerfTest._setup_test):
1694         (TestReplayPerfTest.test_run_single):
1695         (TestReplayPerfTest.test_run_single.run_test):
1696         (TestReplayPerfTest.test_run_single_fails_without_webpagereplay):
1697         (TestReplayPerfTest.test_prepare_fails_when_wait_until_ready_fails):
1698         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
1699         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
1700         (TestReplayPerfTest.test_prepare):
1701         (TestReplayPerfTest.test_prepare.run_test):
1702         (TestReplayPerfTest.test_prepare_calls_run_single):
1703         (TestReplayPerfTest.test_prepare_calls_run_single.run_single):
1704         (TestPerfTestFactory.test_regular_test):
1705         (TestPerfTestFactory.test_inspector_test):
1706         (TestPerfTestFactory.test_page_loading_test):
1707         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1708         (PerfTestsRunner):
1709         (PerfTestsRunner._parse_args): Added --replay flag to enable replay tests.
1710         (PerfTestsRunner._collect_tests): Collect .replay files when replay tests are enabled.
1711         (PerfTestsRunner._collect_tests._is_test_file):
1712         (PerfTestsRunner.run): Exit early if one of calls to prepare() fails.
1713         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1714         (create_runner):
1715         (run_test):
1716         (_tests_for_runner):
1717         (test_run_test_set):
1718         (test_run_test_set_kills_drt_per_run):
1719         (test_run_test_pause_before_testing):
1720         (test_run_test_set_for_parser_tests):
1721         (test_run_test_set_with_json_output):
1722         (test_run_test_set_with_json_source):
1723         (test_run_test_set_with_multiple_repositories):
1724         (test_run_with_upload_json):
1725         (test_upload_json):
1726         (test_upload_json.MockFileUploader.upload_single_text_file):
1727         (_add_file):
1728         (test_collect_tests):
1729         (test_collect_tests_with_multile_files):
1730         (test_collect_tests_with_multile_files.add_file):
1731         (test_collect_tests_with_skipped_list):
1732         (test_collect_tests_with_page_load_svg):
1733         (test_collect_tests_should_ignore_replay_tests_by_default):
1734         (test_collect_tests_with_replay_tests):
1735         (test_parse_args):
1736         * Scripts/webkitpy/thirdparty/__init__.py: Added the dependency for web-page-replay version 1.1.1.
1737         (AutoinstallImportHook.find_module):
1738         (AutoinstallImportHook._install_webpagereplay):
1739
1740 2012-05-31  Yaron Friedman  <yfriedman@chromium.org>
1741
1742         Support building the Android port of chromium with Ninja
1743         https://bugs.webkit.org/show_bug.cgi?id=87545
1744
1745         Reviewed by Adam Barth.
1746
1747         Ensures that shared libraries are looked up in a generator-agnostic
1748         way and that output is placed in the correct directory.
1749
1750         Depends on http://codereview.chromium.org/10386188/
1751
1752         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1753
1754 2012-05-31  Ryosuke Niwa  <rniwa@webkit.org>
1755
1756         [Chromium] Chromium DRT should be able to load external resources
1757         https://bugs.webkit.org/show_bug.cgi?id=87893
1758
1759         Reviewed by Dirk Pranke.
1760
1761         Allow external resources to be loaded when the main frame's URL is also an external resource.
1762         This change is analogous to r118231 for Mac port.
1763
1764         * DumpRenderTree/chromium/WebViewHost.cpp:
1765         (blockRequest):
1766         (isLocalhost):
1767         (hostIsUsedBySomeTestsToGenerateError):
1768         (WebViewHost::willSendRequest):
1769
1770 2012-05-31  Anders Carlsson  <andersca@apple.com>
1771
1772         Build fixes.
1773
1774         Disable the C++11 extensions warning.
1775
1776         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1777         * TestWebKitAPI/Configurations/Base.xcconfig:
1778         * WebKitTestRunner/Configurations/Base.xcconfig:
1779
1780 2012-05-31  Alexey Proskuryakov  <ap@apple.com>
1781
1782         [WK2] window.internals settings are not reset between tests
1783         https://bugs.webkit.org/show_bug.cgi?id=87783
1784
1785         Reviewed by Mihai Parparita.
1786
1787         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1788         (WTR::InjectedBundle::done): Call resetAfterTest().
1789
1790         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1791         (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
1792         (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
1793         This needs to be done after a tets, because the code assumes that there is an object
1794         with this name in global scope.
1795
1796         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1797
1798 2012-05-31  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1799
1800         [EFL][DRT] EFL's DRT navigation_policy_decision implementation
1801         https://bugs.webkit.org/show_bug.cgi?id=85006
1802
1803         Reviewed by Tor Arne Vestbø.
1804
1805         Added navigation_policy_decision implementation for DumpRenderTreeView.
1806         Added LayoutTestController::setCustomPolicyDelegate implementation.
1807         Modified LayoutTestController::waitForPolicyDelegate.
1808
1809         * DumpRenderTree/efl/DumpRenderTree.cpp:
1810         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1811         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1812         * DumpRenderTree/efl/DumpRenderTreeEfl.h:
1813         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1814         (navigationTypeToString): aux function
1815         (onNavigationPolicyDecision): navigation_policy_decision implementation
1816         (drtViewAdd):
1817         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1818         (LayoutTestController::setCustomPolicyDelegate):
1819         (LayoutTestController::waitForPolicyDelegate):
1820
1821 2012-05-31  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1822
1823         [EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
1824         https://bugs.webkit.org/show_bug.cgi?id=86195
1825
1826         Reviewed by Gustavo Noronha Silva.
1827
1828         Implement clearApplicationCacheForOrigin in EFL
1829         LayoutTestController.
1830
1831         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1832         (LayoutTestController::clearApplicationCacheForOrigin):
1833
1834 2012-05-31  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1835
1836         [Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
1837         https://bugs.webkit.org/show_bug.cgi?id=87955
1838
1839         Reviewed by Simon Hausmann.
1840
1841         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1842         * DumpRenderTree/qt/EventSenderQt.cpp:
1843         * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
1844         * DumpRenderTree/qt/main.cpp:
1845         * QtTestBrowser/cookiejar.cpp:
1846         * QtTestBrowser/launcherwindow.cpp:
1847         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1848         * qmake/mkspecs/features/default_post.prf:
1849
1850 2012-05-31  Zoltan Horvath  <zoltan@webkit.org>
1851
1852         [Qt] Don't enforce the version of libpng for the config test when passing the option to the linker
1853
1854         Rubber-stamped by Kenneth Rohde Christiansen.
1855
1856         * qmake/config.tests/libpng/libpng.pro:
1857
1858 2012-05-30  Peter Beverloo  <peter@chromium.org>
1859
1860         [Chromium] Automatically install 64-bit linker for Android
1861         https://bugs.webkit.org/show_bug.cgi?id=79780
1862
1863         Reviewed by Adam Barth.
1864
1865         Change the update-webkit-chromium script to check whether the 64-bit
1866         linker needs to be installed as part of the update process. The actual
1867         code for doing these checks and "installing" it has been added to the
1868         webkitdirs.pm script.
1869
1870         The linker itself is part of the third_party/aosp repository, which
1871         will be pulled in through the DEPS change.
1872
1873         * Scripts/update-webkit-chromium:
1874         * Scripts/webkitdirs.pm:
1875         (chromiumInstall64BitAndroidLinkerIfNeeded):
1876         (chromiumReplaceAndroidLinkerIfNeeded):
1877
1878 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1879
1880         https://bugs.webkit.org/show_bug.cgi?id=87803
1881         Layout tests often fail trying to stat nonexistent logs 
1882
1883         Reviewed by Dirk Pranke.
1884
1885         CrashReporter removes logs using a heuristic to conserve space.  Wrap a 
1886         try/catch block around accessing the logs as a precaution.
1887
1888         * Scripts/webkitpy/common/system/crashlogs.py:
1889         (CrashLogs._find_newest_log_darwin):
1890
1891 2012-05-30  Gavin Peters  <gavinp@chromium.org>
1892
1893         Add a LayoutTest for prerender remove after stop.
1894         https://bugs.webkit.org/show_bug.cgi?id=87860
1895
1896         These very boring mocks in DumpRenderTree mean that the basic Prerendering API
1897         can be tested by LayoutTests now.
1898
1899         Reviewed by Adam Barth.
1900
1901         * DumpRenderTree/DumpRenderTree.gypi:
1902         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Added.
1903         (MockWebPrerenderingSupport::MockWebPrerenderingSupport):
1904         (MockWebPrerenderingSupport::~MockWebPrerenderingSupport):
1905         (MockWebPrerenderingSupport::add):
1906         (MockWebPrerenderingSupport::cancel):
1907         (MockWebPrerenderingSupport::abandon):
1908         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Added.
1909         (MockWebPrerenderingSupport):
1910         * DumpRenderTree/chromium/TestShell.cpp:
1911         (TestShell::initialize):
1912         * DumpRenderTree/chromium/TestShell.h:
1913         (TestShell):
1914         * DumpRenderTree/chromium/WebViewHost.cpp:
1915         (WebViewHost::willAddPrerender):
1916         (WebViewHost::setWebWidget):
1917         * DumpRenderTree/chromium/WebViewHost.h:
1918         (WebViewHost):
1919
1920 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1921
1922         https://bugs.webkit.org/show_bug.cgi?id=87717
1923         Unresponsive WebProcesses can be mistaken for WebProcess crashes.
1924
1925         Reviewed by Dirk Pranke.
1926
1927         Change the error message from #CRASHED to #UNRESPONSIVE PROCESS
1928         If there isn't a crash log found for the process add a message saying
1929         the process was unresponsive.
1930
1931         * Scripts/webkitpy/layout_tests/port/webkit.py:
1932         (WebKitDriver.__init__):
1933         (WebKitDriver._check_for_driver_crash):
1934         (WebKitDriver.run_test):
1935         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1936         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
1937         (WebKitDriverTest):
1938         (WebKitDriverTest.test_check_for_driver_crash):
1939         * WebKitTestRunner/TestController.cpp:
1940         (WTR):
1941         (WTR::TestController::runTest):
1942
1943 2012-05-30  Stephanie Lewis  <slewis@apple.com>
1944
1945         https://bugs.webkit.org/show_bug.cgi?id=87714
1946         Mac crash logs can take a really long time to be written out.
1947
1948         Reviewed by Dirk Pranke.
1949
1950         Make a second pass looking for crash logs after the tests have completed running.
1951
1952         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1953         (use_trac_links_in_results_html):
1954         (Manager.run):
1955         * Scripts/webkitpy/layout_tests/port/base.py:
1956         (Port.repository_paths):
1957         (Port.look_for_new_crash_logs):
1958         * Scripts/webkitpy/layout_tests/port/mac.py:
1959         (MacPort.look_for_new_crash_logs):
1960         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1961         (test_get_crash_log):
1962         (test_look_for_new_crash_logs):
1963         (test_look_for_new_crash_logs.fake_time_cb):
1964
1965 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
1966
1967         [wx] Fix 2.9 issues with c_str() type by using the wx fprintf wrapper.
1968
1969         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1970         (LayoutWebViewEventHandler::OnAlertEvent):
1971         (LayoutWebViewEventHandler::OnConfirmEvent):
1972         (LayoutWebViewEventHandler):
1973         (LayoutWebViewEventHandler::OnPromptEvent):
1974         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1975         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
1976
1977 2012-05-30  Ojan Vafai  <ojan@chromium.org>
1978
1979         Only give lint errors for -expected.png png files that lack a checksum
1980         https://bugs.webkit.org/show_bug.cgi?id=87875
1981
1982         Reviewed by Tony Chang.
1983
1984         We have other pngs in the tree, e.g. for the inspector, that legitimately
1985         lack a checksum.
1986
1987         * Scripts/webkitpy/style/checkers/png.py:
1988         (PNGChecker.check):
1989         * Scripts/webkitpy/style/checkers/png_unittest.py:
1990         (PNGCheckerTest.test_check):
1991
1992 2012-05-30  Dirk Pranke  <dpranke@chromium.org>
1993
1994         nrwt: seems to leak temp dirs
1995         https://bugs.webkit.org/show_bug.cgi?id=87795
1996
1997         Reviewed by Ojan Vafai.
1998
1999         There appears to be a bug where the chromium bots are creating
2000         temporary directories and not cleaning them up that started
2001         after the switch to WebKitDriver. It's possible that __del__
2002         wasn't getting called in a timely manner (or at all), and it's
2003         generally bad style to rely on __del__ being called, so this
2004         code changes things so that we create a temp dir in
2005         driver.start() and remove it in driver.stop(). We could be
2006         paranoid and leave the __del__ code in, but there doesn't seem
2007         to be much advantage to it. If there are bugs that result in
2008         drivers being started but not stopped, we have other problems.
2009
2010         * Scripts/webkitpy/common/system/filesystem_mock.py:
2011         (MockFileSystem.__init__):
2012         (MockFileSystem._mktemp):
2013         (MockFileSystem.mkdtemp):
2014         * Scripts/webkitpy/layout_tests/port/webkit.py:
2015         (WebKitDriver.__init__):
2016         (WebKitDriver._start):
2017         (WebKitDriver.stop):
2018         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2019         (WebKitDriverTest.test_check_for_driver_crash):
2020         (WebKitDriverTest):
2021         (WebKitDriverTest.test_creating_a_port_does_not_write_to_the_filesystem):
2022         (WebKitDriverTest.test_stop_cleans_up_properly):
2023
2024 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
2025
2026         [EFL] EFL's DRT should print the number of MessagePorts for new each new intent
2027         https://bugs.webkit.org/show_bug.cgi?id=86841
2028
2029         Reviewed by Adam Barth.
2030
2031         Print the number of MessagePorts for each new intent in EFL's DRT.
2032         This output is expected by several Web Intents test cases.
2033
2034         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2035         (DumpRenderTreeChrome::onFrameIntentNew):
2036
2037 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
2038
2039         [wx] Unreviewed build fix after removal of setJavaScriptProfilingEnabled.
2040
2041         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2042
2043 2012-05-30  Christophe Dumez  <christophe.dumez@intel.com>
2044
2045         [EFL] Ewk_Intent_Request's postResult/postFailure should take serialized script values in argument
2046         https://bugs.webkit.org/show_bug.cgi?id=87829
2047
2048         Reviewed by Adam Barth.
2049
2050         EFL's LayoutTestController now makes uses of the new helper method in
2051         DumpRenderTreeSupportEfl in order to send the intent response. This is
2052         now needed because the Ewk_Intent_Request postResult / postFailure
2053         methods were made private.
2054
2055         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2056         (LayoutTestController::sendWebIntentResponse):
2057
2058 2012-05-30  Xueqing Huang  <huangxueqing@baidu.com>
2059
2060         eventSender.beginDragWithFiles should be implemented in Windows, which blocked drag and drop related tests.
2061         https://bugs.webkit.org/show_bug.cgi?id=86296
2062
2063         Reviewed by Tony Chang.
2064
2065         * DumpRenderTree/win/DRTDataObject.cpp: Added.
2066         (cfHDropFormat):
2067         (cfFileNameWFormat):
2068         (cfUrlWFormat):
2069         (WCEnumFormatEtc):
2070         (WCEnumFormatEtc::WCEnumFormatEtc):
2071         (WCEnumFormatEtc::QueryInterface):
2072         (WCEnumFormatEtc::AddRef):
2073         (WCEnumFormatEtc::Release):
2074         (WCEnumFormatEtc::Next):
2075         (WCEnumFormatEtc::Skip):
2076         (WCEnumFormatEtc::Reset):
2077         (WCEnumFormatEtc::Clone):
2078         (DRTDataObject::createInstance):
2079         (DRTDataObject::DRTDataObject):
2080         (DRTDataObject::~DRTDataObject):
2081         (DRTDataObject::QueryInterface):
2082         (DRTDataObject::AddRef):
2083         (DRTDataObject::Release):
2084         (DRTDataObject::GetData):
2085         (DRTDataObject::GetDataHere):
2086         (DRTDataObject::QueryGetData):
2087         (DRTDataObject::GetCanonicalFormatEtc):
2088         (DRTDataObject::SetData):
2089         (DRTDataObject::CopyMedium):
2090         (DRTDataObject::EnumFormatEtc):
2091         (DRTDataObject::DAdvise):
2092         (DRTDataObject::DUnadvise):
2093         (DRTDataObject::EnumDAdvise):
2094         (DRTDataObject::clearData):
2095         * DumpRenderTree/win/DRTDataObject.h: Added.
2096         (DRTDataObject):
2097         * DumpRenderTree/win/DRTDropSource.cpp: Added.
2098         (DRTDropSource::DRTDropSource):
2099         (DRTDropSource::~DRTDropSource):
2100         (DRTDropSource::QueryInterface):
2101         (DRTDropSource::AddRef):
2102         (DRTDropSource::Release):
2103         (DRTDropSource::createInstance):
2104         (DRTDropSource::QueryContinueDrag):
2105         (DRTDropSource::GiveFeedback):
2106         * DumpRenderTree/win/DRTDropSource.h: Added.
2107         (DRTDropSource):
2108         * DumpRenderTree/win/DumpRenderTree.vcproj:
2109         * DumpRenderTree/win/EventSender.cpp:
2110         (beginDragWithFilesCallback):
2111
2112 2012-05-30  Marcelo Lira  <marcelo.lira@openbossa.org>
2113
2114         WebKit2: Implement layoutTestController.setPluginsEnabled() in WebKitTestRunner.
2115         https://bugs.webkit.org/show_bug.cgi?id=58593
2116
2117         Adds the ability to change the pluginsEnabled flag in WebCore::Settings
2118         to WebKitTestRunner's LayoutTestController. The flag is modified via the
2119         public C API of the WebProcess.
2120
2121         Reviewed by Darin Adler.
2122
2123         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2124         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2125         (WTR::LayoutTestController::setPluginsEnabled): Just calls the
2126         WKBundleSetPluginsEnabled function in the public C API of WebProcess.
2127         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2128
2129 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2130
2131         [EFL][DRT] http/tests/navigation/new-window-redirect-history.html does not pass
2132         https://bugs.webkit.org/show_bug.cgi?id=87848
2133
2134         Reviewed by Csaba Osztrogonác.
2135
2136         The reason was that DumpRenderTreeChrome::extraViews() returned copy of the vector
2137         and dumpBackForwardListForWebViews() used iterators belonging actually to different vectors
2138         (browser->extraViews().begin() and browser->extraViews().end()) as if they had belonged to the same vector.
2139
2140         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2141         (DumpRenderTreeChrome::extraViews):
2142         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
2143         (DumpRenderTreeChrome):
2144
2145 2012-05-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2146
2147         [EFL][DRT] EFL's DRT needs "postProgressFinishedNotification" message
2148         https://bugs.webkit.org/show_bug.cgi?id=87833
2149
2150         Reviewed by Tor Arne Vestbø.
2151
2152         Print "postProgressFinishedNotification" message if frame load finished 
2153         to unskip http/tests/loading/progress-finished-callback.html.
2154
2155         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2156         (DumpRenderTreeChrome::onFrameLoadFinished):
2157
2158 2012-05-30  Mariusz Grzegorczyk  <mariusz.g@samsung.com>, Ryuan Choi  <ryuan.choi@samsung.com>
2159
2160         [EFL][WK2] Fix WebKit2-EFL build
2161         https://bugs.webkit.org/show_bug.cgi?id=83693
2162
2163         Reviewed by Carlos Garcia Campos.
2164
2165         * CMakeLists.txt:  Guard Webkit1 related codes with ENABLE_WEBKIT.
2166
2167 2012-05-29  János Badics  <jbadics@inf.u-szeged.hu>
2168
2169         [Qt] Modified ORWT and NRWT to check for test expectations in platform/qt-5.0-wk1 too
2170         (They only used to check for Skipped in platform/qt-5.0-wk1)
2171         https://bugs.webkit.org/show_bug.cgi?id=87376
2172
2173         Reviewed by Csaba Osztrogonác.
2174
2175         * Scripts/old-run-webkit-tests:
2176         (buildPlatformResultHierarchy):
2177         * Scripts/webkitpy/layout_tests/port/qt.py:
2178         (QtPort.baseline_search_path):
2179
2180 2012-05-29  Ojan Vafai  <ojan@chromium.org>
2181
2182         Add a linter error for pngs that lack an embedded checksum
2183         https://bugs.webkit.org/show_bug.cgi?id=87793
2184
2185         Reviewed by Dirk Pranke.
2186
2187         * Scripts/read-checksum-from-png:
2188         * Scripts/webkitpy/common/read_checksum_from_png.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png.py.
2189         (read_checksum):
2190         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py: Renamed from Tools/Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py.
2191         (ReadChecksumFromPngTest):
2192         (ReadChecksumFromPngTest.test_read_checksum):
2193         * Scripts/webkitpy/layout_tests/port/base.py:
2194         * Scripts/webkitpy/style/checkers/png.py:
2195         (PNGChecker.check):
2196         * Scripts/webkitpy/style/checkers/png_unittest.py:
2197         (PNGCheckerTest.test_check):
2198
2199 2012-05-29  Stephanie Lewis  <slewis@apple.com>
2200
2201         https://bugs.webkit.org/show_bug.cgi?id=87720
2202         WebProcess is often killed due to being unresponsive on the bots
2203
2204         Reviewed by Alexey Proskuryakov.
2205
2206         Blind attempt to improve flakiness on the bots by reducing the number
2207         of crashes due to an unresponsive process.  This helped on my personal machine
2208         under stress conditions.  I don't have enough cores to hit the problem
2209         under normal conditions.
2210
2211         * WebKitTestRunner/TestController.cpp:
2212         (WTR):
2213
2214 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2215
2216         webkitpy: rename 'rm' to 'delete' in rebaseline scm output
2217         https://bugs.webkit.org/show_bug.cgi?id=87779
2218
2219         Reviewed by Eric Seidel.
2220
2221         Update output to match the names in scm.py as per
2222         https://bugs.webkit.org/show_bug.cgi?id=87451#c26 .
2223
2224         * Scripts/webkitpy/tool/commands/rebaseline.py:
2225         (RebaselineTest.execute):
2226         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2227         (test_rebaseline_test_and_print_scm_changes):
2228         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2229         (GardeningServerTest.test_rebaselineall):
2230
2231 2012-05-29  Stephanie Lewis  <slewis@apple.com>
2232
2233         https://bugs.webkit.org/show_bug.cgi?id=87711
2234
2235         Reviewed by Jessie Berlin.
2236
2237         Remove Snowleopard testers so the hardware can be repurposed.  The lion bots
2238         are better maintained.
2239
2240         * BuildSlaveSupport/build.webkit.org-config/config.json:
2241
2242 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2243
2244         webkit-patch optimize-baselines should add/delete files in batches from the vcs
2245         https://bugs.webkit.org/show_bug.cgi?id=87538
2246
2247         Reviewed by Ojan Vafai.
2248
2249         Invoking git and svn on one file at a time is kinda slow. We
2250         should batch the add and rm operations together.
2251
2252         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2253         (BaselineOptimizer._move_baselines):
2254
2255 2012-05-29  Dirk Pranke  <dpranke@chromium.org>
2256
2257         garden-o-matic should rebaseline baselines in parallel
2258         https://bugs.webkit.org/show_bug.cgi?id=87451
2259
2260         Reviewed by Ojan Vafai.
2261                                                                                
2262         This modifies garden-o-matic so that we will fetch all                  
2263         of the baselines in parallel from the bots, and then                    
2264         optimize the baselines serially (since that should be fairly            
2265         quick and we get into trouble if we optimize in parallel due            
2266         to concurrent access to the source control system).                     
2267
2268         This change adds a flag to webkit-patch rebaseline-test (--print-scm-changes)
2269         so that the files that need to be modified in the SCM are returned to 
2270         garden-o-matic rather than actually added or removed. This is done so that
2271         we can run multiple rebaseline-tests in parallel (we can't modify the SCM
2272         concurrently). In order to safely return the files (as a JSON dict) I
2273         needed to shift all of the logging in rebaseline-test to use the logging
2274         module (and hence log to stderr).
2275
2276         I also had to stub out a line in chromium.py that would get confused if
2277         the skia overrides file didn't exist in a mock checkout.
2278
2279         * Scripts/webkitpy/common/system/executive.py:
2280         (Executive.popen):
2281         (Executive):
2282         (Executive.run_in_parallel):
2283         (_run_command_thunk):
2284         * Scripts/webkitpy/common/system/executive_mock.py:
2285         (MockExecutive.run_in_parallel):
2286         * Scripts/webkitpy/common/system/executive_unittest.py:
2287         (ExecutiveTest.test_run_in_parallel):
2288         * Scripts/webkitpy/layout_tests/port/chromium.py:
2289         (ChromiumPort._expectations_file_contents):
2290         * Scripts/webkitpy/tool/commands/rebaseline.py:
2291         (AbstractRebaseliningCommand.__init__):
2292         (RebaselineTest.__init__):
2293         (RebaselineTest._copy_existing_baseline):
2294         (RebaselineTest._save_baseline):
2295         (RebaselineTest):
2296         (RebaselineTest._add_to_scm):
2297         (RebaselineTest._rebaseline_test):
2298         (RebaselineTest.execute):
2299         (RebaselineExpectations._rebaseline_port):
2300         (RebaselineExpectations.execute):
2301         (Rebaseline._builder_to_pull_from):
2302         (Rebaseline.execute):
2303         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2304         (test_rebaseline_updates_expectations_file):
2305         (test_rebaseline_test):
2306         (test_rebaseline_test_and_print_scm_changes):
2307         (test_rebaseline_and_copy_test):
2308         (test_rebaseline_and_copy_test_no_existing_result):
2309         (test_rebaseline_and_copy_test_with_lion_result):
2310         (test_rebaseline_and_copy_no_overwrite_test):
2311         (test_rebaseline_expectations):
2312         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2313         (GardeningHTTPRequestHandler._rebaseline_commands):
2314         (GardeningHTTPRequestHandler):
2315         (GardeningHTTPRequestHandler._files_to_add):
2316         (GardeningHTTPRequestHandler._optimize_baselines):
2317         (GardeningHTTPRequestHandler.rebaselineall):
2318         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2319         (GardeningServerTest._post_to_path):
2320         (GardeningServerTest.test_rebaselineall):
2321         (GardeningServerTest.test_rebaselineall.run_command):
2322
2323 2012-05-29  Benjamin Poulain  <bpoulain@apple.com>
2324
2325         Fix the type of dispatch_time() offset
2326
2327         Rubber-stamped by Joseph Pecoraro.
2328
2329         In r118631, I erroneously used the type NSTimeInterval for the delta of dispatch_time().
2330
2331         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2332         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2333
2334 2012-05-29  Arvid Nilsson  <anilsson@rim.com>
2335
2336         2012-05-29  Arvid Nilsson  <anilsson@rim.com>
2337
2338         [BlackBerry] OpenGL content is not rendered on simulator
2339         https://bugs.webkit.org/show_bug.cgi?id=87721
2340
2341         Reviewed by George Staikos.
2342
2343         Fixed by enabling GLES2 support in simulator builds.
2344
2345         To experiment with building without OpenGL support, you can set the
2346         DISABLE_GLES2 environment variable to a non-empty string and rebuild.
2347
2348         PR #150695
2349
2350         * Scripts/webkitdirs.pm:
2351         (blackberryCMakeArguments):
2352
2353 2012-05-29  David Barr  <davidbarr@chromium.org>
2354
2355         Introduce ENABLE_CSS_IMAGE_RESOLUTION compile flag
2356         https://bugs.webkit.org/show_bug.cgi?id=87685
2357
2358         Reviewed by Eric Seidel.
2359
2360         Add a configuration option for CSS image-resolution support, disabling it by default.
2361
2362         * Scripts/webkitperl/FeatureList.pm:
2363         * qmake/mkspecs/features/features.pri:
2364
2365 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2366
2367         [Qt] Don't add cxx-flags to QMAKE_CFLAGS
2368
2369         Prevents warnings such as: "command line option ‘-Wno-c++0x-compat’ is
2370             valid for C++/ObjC++ but not for C [enabled by default]"
2371
2372         Reviewed by Simon Hausmann.
2373
2374         * qmake/mkspecs/features/unix/default_post.prf:
2375
2376 2012-05-29  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2377
2378         [Qt] Sync up favicon-implementation with WebView url changes in r118158
2379
2380         https://bugs.webkit.org/show_bug.cgi?id=87133
2381
2382         We now base64-encode the page url in the image-provider url, so that any
2383         normalization done by QUrl will not mess up the page-url. The logic of
2384         creating and parsing the provider-url has been moved into the image
2385         provider, to keep it in one place.
2386
2387         We were also releasing icons (even ones we hadn't retained), which we can't
2388         do since we don't know when the icon url is no longer in use.
2389
2390         Reviewed-by Simon Hausmann.
2391
2392         * MiniBrowser/qt/icons/favicon.png:
2393         * MiniBrowser/qt/qml/BrowserWindow.qml:
2394
2395 2012-05-29  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2396
2397         [EFL] Refactoring. Get rid of unnecessary singleCharacterString() function
2398         https://bugs.webkit.org/show_bug.cgi?id=87654
2399
2400         Reviewed by Csaba Osztrogonác.
2401
2402         Event sender provides strings for all the key events.
2403         Also KeyEventInfo constructor parameters order was changed to simplify the case when
2404         a key event has empty string.
2405
2406         * DumpRenderTree/efl/EventSender.cpp:
2407         (KeyEventInfo::KeyEventInfo):
2408         (keyPadNameFromJSValue):
2409         (keyNameFromJSValue):
2410
2411 2012-05-23  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2412
2413         [Qt] Cancel potential url-edit when going back/forward
2414
2415         Reviewed by Kenneth Rohde Christiansen.
2416
2417         * MiniBrowser/qt/qml/BrowserWindow.qml:
2418
2419 2012-05-29  Christophe Dumez  <christophe.dumez@intel.com>
2420
2421         [EFL] Compilation warning in DumpRenderTreeView.cpp
2422         https://bugs.webkit.org/show_bug.cgi?id=87636
2423
2424         Reviewed by Filip Pizlo.
2425
2426         Fix compilation error in DumpRenderTreeView.cpp due to wrong format
2427         specifier in printf. Also fix the return type for
2428         onExceededApplicationCacheQuota callback.
2429
2430         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2431         (onExceededApplicationCacheQuota):
2432
2433 2012-05-29  Hironori Bono  <hbono@chromium.org>
2434
2435         Adding Hironori Bono to committers.py.
2436         https://bugs.webkit.org/show_bug.cgi?id=87697
2437
2438         * Scripts/webkitpy/common/config/committers.py:
2439
2440 2012-05-28  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
2441
2442         [BlackBerry] http authenticate dialog popup only once no matter authentication pass or fail
2443         https://bugs.webkit.org/show_bug.cgi?id=80135
2444
2445         Reviewed by Rob Buis.
2446
2447         Implemented interface function didReceiveAuthenticationChallenge in class
2448         DumpRenderTree.
2449
2450         Resubmit the patch reverted by r115104 after the digest infinite loop
2451         issue for BlackBerry porting get identified and fixed.
2452
2453         Internally reviewed by Joe Mason <jmason@rim.com>
2454
2455         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2456         (drtCredentialDescription):
2457         (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
2458         (WebKit):
2459         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2460         (WebCore):
2461         (DumpRenderTree):
2462
2463 2012-05-25  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2464
2465         WebKitTestRunner needs to support layoutTestController.setJavaScriptProfilingEnabled
2466         https://bugs.webkit.org/show_bug.cgi?id=42328
2467
2468         Reviewed by Eric Seidel.
2469
2470         Removed unneeded setJavaScriptProfilingEnabled function from DRT after its
2471         move to windows.internals.settings.
2472
2473         * DumpRenderTree/LayoutTestController.cpp:
2474         (LayoutTestController::staticFunctions):
2475         * DumpRenderTree/LayoutTestController.h:
2476         (LayoutTestController):
2477         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2478         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2479         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2480         (DRTDevToolsAgent):
2481         * DumpRenderTree/chromium/LayoutTestController.cpp:
2482         (LayoutTestController::LayoutTestController):
2483         * DumpRenderTree/chromium/LayoutTestController.h:
2484         (LayoutTestController):
2485         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2486         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2487         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2488         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2489         * DumpRenderTree/mac/DumpRenderTree.mm:
2490         (resetWebViewToConsistentStateBeforeTesting):
2491         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2492         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2493         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2494         (LayoutTestController):
2495         * DumpRenderTree/win/DumpRenderTree.cpp:
2496         (resetWebViewToConsistentStateBeforeTesting):
2497         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2498         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2499         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2500         (LayoutTestController):
2501
2502 2012-05-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2503
2504         Move allowRoundingHacks to Internals interface
2505         https://bugs.webkit.org/show_bug.cgi?id=87328
2506
2507         Reviewed by Hajime Morita.
2508
2509         Remove allowRoundingHacks functions, because it is able to work in the
2510         cross-port way through the Internals interface.
2511
2512         * DumpRenderTree/LayoutTestController.cpp:
2513         (LayoutTestController::staticFunctions):
2514         * DumpRenderTree/LayoutTestController.h:
2515         (LayoutTestController):
2516         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2517         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2518         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2519         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2520         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2521         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2522
2523 2012-05-28  Luke Macpherson  <macpherson@chromium.org>
2524
2525         Fix mac build with older XCode by defining NSEC_PER_MSEC.
2526         https://bugs.webkit.org/show_bug.cgi?id=87616
2527
2528         Reviewed by Hajime Morita.
2529
2530         The following patch introduced the use of NSEC_PER_MSEC which is not defined for older XCode versions.
2531         http://trac.webkit.org/changeset/118631/trunk/Tools/DumpRenderTree/mac/FrameLoadDelegate.mm
2532         Patch just adds a #ifndef / #define check.
2533
2534         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2535         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2536
2537 2012-05-27  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2538
2539         [EFL] Enable blob support for the EFL port
2540         https://bugs.webkit.org/show_bug.cgi?id=85363
2541
2542         Reviewed by Hajime Morita.
2543
2544         Enable Blob support by default for the EFL port.
2545
2546         * Scripts/webkitperl/FeatureList.pm:
2547
2548 2012-05-27  Benjamin Poulain  <bpoulain@apple.com>
2549
2550         When pages are loaded from AppCache with DeferredLoading, willSendRequest() is never called
2551         https://bugs.webkit.org/show_bug.cgi?id=87582
2552
2553         Reviewed by Darin Adler.
2554
2555         Extend DumpRenderTree to support loading the main resource deferred with a delay. This makes it
2556         possible to test pages in a similar way as they are loaded in Browsers.
2557
2558         * DumpRenderTree/LayoutTestController.cpp:
2559         (LayoutTestController::LayoutTestController):
2560         (setUseDeferredFrameLoadingCallback):
2561         (LayoutTestController::staticFunctions):
2562         * DumpRenderTree/LayoutTestController.h:
2563         (LayoutTestController::useDeferredFrameLoading):
2564         (LayoutTestController::setUseDeferredFrameLoading):
2565         (LayoutTestController):
2566         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2567         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]):
2568
2569 2012-05-27  David Barton  <dbarton@mathscribe.com>
2570
2571         [watchlist] Improve MathML rule
2572         https://bugs.webkit.org/show_bug.cgi?id=87592
2573
2574         Reviewed by Adam Barth.
2575
2576         The old rule "filename": r".*mathml" works fine because "filename" is a prefix match,
2577         but if this changed the rule would be slow. We protect against this, clarify the rule,
2578         and make it more similar to existing rules.
2579
2580         * Scripts/webkitpy/common/config/watchlist:
2581
2582 2012-05-27  David Barton  <dbarton@mathscribe.com>
2583
2584         [watchlist] Add myself & a rule for MathML
2585         https://bugs.webkit.org/show_bug.cgi?id=87586
2586
2587         Reviewed by Adam Barth.
2588
2589         * Scripts/webkitpy/common/config/watchlist:
2590
2591 2012-05-26  David Kilzer  <ddkilzer@apple.com>
2592
2593         Use xcrun to find path to nm for Mac port
2594         <http://webkit.org/b/87588>
2595
2596         Reviewed by Dan Bernstein.
2597
2598         * Scripts/webkitpy/layout_tests/port/mac.py:
2599         (MacPort.nm_command): Add. Tries to find a path for the nm
2600         command using xcrun.  Falls back to returning 'nm'.
2601         * Scripts/webkitpy/layout_tests/port/webkit.py:
2602         (WebKitPort.nm_command): Add. Returns 'nm'.
2603         (WebKitPort._webcore_symbols_string): Call self.nm_command().
2604
2605 2012-05-25  Lynn Neir  <lynn.neir@skype.net>
2606
2607         Added windows implementation in DRT for TextInputController, https://bugs.webkit.org/show_bug.cgi?id=32021
2608
2609         Reviewed by Eric Seidel.
2610
2611         * DumpRenderTree/win/DumpRenderTree.vcproj:
2612         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2613         (FrameLoadDelegate::FrameLoadDelegate):
2614         (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
2615         * DumpRenderTree/win/FrameLoadDelegate.h:
2616         (FrameLoadDelegate):
2617         * DumpRenderTree/win/TextInputController.cpp: Added.
2618         (setMarkedTextCallback):
2619         (hasMarkedTextCallback):
2620         (unmarkTextCallback):
2621         (markedRangeCallback):
2622         (insertTextCallback):
2623         (firstRectForCharacterRangeCallback):
2624         (selectedRangeCallback):
2625         (TextInputController::makeWindowObject):
2626         (TextInputController::getJSClass):
2627         (TextInputController::staticValues):
2628         (TextInputController::staticFunctions):
2629         * DumpRenderTree/win/TextInputController.h: Added.
2630         (TextInputController):
2631         * DumpRenderTree/win/TextInputControllerWin.cpp: Added.
2632         (TextInputController::setMarkedText):
2633         (TextInputController::hasMarkedText):
2634         (TextInputController::unmarkText):
2635         (TextInputController::markedRange):
2636         (TextInputController::insertText):
2637         (TextInputController::firstRectForCharacterRange):
2638         (TextInputController::selectedRange):
2639
2640 2012-05-25  Dirk Pranke  <dpranke@chromium.org>
2641
2642         webkitpy: change scm.add(), scm.delete() to accept multiple paths
2643         https://bugs.webkit.org/show_bug.cgi?id=87528
2644
2645         Reviewed by Ojan Vafai.
2646
2647         launching git or svn for individual files can be slow; this
2648         change will hand multiple paths at once to git and svn so they
2649         can be added in a batch.
2650
2651         * Scripts/webkitpy/common/checkout/scm/git.py:
2652         (Git.add_list):
2653         (Git.delete_list):
2654         * Scripts/webkitpy/common/checkout/scm/scm.py:
2655         (SCM.add):
2656         (SCM):
2657         (SCM.add_list):
2658         (SCM.delete):
2659         (SCM.delete_list):
2660         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2661         (MockSCM.add):
2662         (MockSCM):
2663         (MockSCM.add_list):
2664         (MockSCM.delete):
2665         (MockSCM.delete_list):
2666         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2667         (_shared_test_exists):
2668         (_shared_test_added_files):
2669         (_test_delete_list):
2670         * Scripts/webkitpy/common/checkout/scm/svn.py:
2671         (SVN.add_list):
2672         (SVN.delete_list):
2673
2674 2012-05-25  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2675
2676         [NRWT] Add unit testing for perf tests on locked shards
2677         https://bugs.webkit.org/show_bug.cgi?id=87489
2678
2679         Reviewed by Dirk Pranke.
2680
2681         Adding utests that makes sure that perf tests are running in locked
2682         shards and by passing --no-http won't break NRWT (r118421).
2683
2684         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2685         (ShardingTests):
2686         (ShardingTests.test_shard_by_dir):
2687         (ShardingTests.test_shard_every_file):
2688         (ShardingTests.test_shard_in_two):
2689         (ShardingTests.test_multiple_locked_shards):
2690         (LockCheckingManager):
2691         (LockCheckingManager.__init__):
2692         (LockCheckingManager.handle_finished_list):
2693         (ManagerTest.test_http_locking):
2694         (ManagerTest):
2695         (ManagerTest.test_perf_locking):
2696         * Scripts/webkitpy/layout_tests/port/test.py:
2697
2698 2012-05-25  Jessie Berlin  <jberlin@apple.com>
2699
2700         [Win] fast/events/keydown-leftright-keys.html failing since introduction in r118001
2701         https://bugs.webkit.org/show_bug.cgi?id=87511
2702
2703         Reviewed by Alexey Proskuryakov.
2704
2705         Update the Windows implementation of keyDown to match the Mac one changed in r118001.
2706
2707         * DumpRenderTree/win/EventSender.cpp:
2708         (keyDownCallback):
2709
2710 2012-05-25  Ken Buchanan  <kenrb@chromium.org>
2711
2712         Adding Ken Buchanan to committers.py
2713         https://bugs.webkit.org/show_bug.cgi?id=87443
2714
2715         Unreviewed.
2716
2717         Adding self to committers.py as a Committer.
2718
2719         * Scripts/webkitpy/common/config/committers.py:
2720
2721 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2722
2723         [Qt] Buildfix for newer Qt5
2724         https://bugs.webkit.org/show_bug.cgi?id=87257
2725
2726         Reviewed by Simon Hausmann.
2727
2728         * MiniBrowser/qt/MiniBrowserApplication.h: QtDeclarative -> QtQml renaming.
2729
2730 2012-05-25  Csaba Osztrogonác  <ossy@webkit.org>
2731
2732         [Qt] Unreviewed fix after r118484.
2733
2734         Enable CSS_EXCLUSIONS and CSS_REGIONS.
2735         They were enabled uncoditinally before r118484.
2736
2737         * qmake/mkspecs/features/features.pri:
2738
2739 2012-05-24  Tim Horton  <timothy_horton@apple.com>
2740
2741         Add feature defines for web-facing parts of CSS Regions and Exclusions
2742         https://bugs.webkit.org/show_bug.cgi?id=87442
2743         <rdar://problem/10887709>
2744
2745         Reviewed by Dan Bernstein.
2746
2747         * Scripts/webkitperl/FeatureList.pm:
2748
2749 2012-05-24  Hironori Bono  <hbono@chromium.org>
2750
2751         Enable grammar checking on Chromium when we paste text (Take 2)
2752         https://bugs.webkit.org/show_bug.cgi?id=74393
2753
2754         Reviewed by Ryosuke Niwa.
2755
2756         This change enables grammar checking on Chromium and implements a mock grammar
2757         checker to fix a failing test.
2758
2759         * DumpRenderTree/DumpRenderTree.gypi:
2760         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2761         (MockGrammarCheck::checkGrammarOfString):
2762         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2763         (WebKit):
2764         (MockGrammarCheck):
2765         * DumpRenderTree/chromium/WebViewHost.cpp:
2766         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2767
2768 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2769
2770         [EFL] [DRT] Add support for WebKitOfflineWebApplicationCacheEnabled preference
2771         https://bugs.webkit.org/show_bug.cgi?id=86842
2772
2773         Reviewed by Antonio Gomes.
2774
2775         Add support for overriding the application cache support preference
2776         through EFL's LayoutTestController.
2777
2778         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2779         (LayoutTestController::overridePreference):
2780
2781 2012-05-24  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2782
2783         [EFL] Remove unnecessary extra call to set developer extras setting on the test startup
2784         https://bugs.webkit.org/show_bug.cgi?id=85209
2785
2786         Reviewed by Antonio Gomes.
2787
2788         Set developer extras setting called twice on the test startup. Hence, removing
2789         an unnecessary extra call which set wrong value. 
2790
2791         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2792         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2793
2794 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2795
2796         garden-o-matic should not fetch from debug bots if it also knows about the release bots
2797         https://bugs.webkit.org/show_bug.cgi?id=86916
2798
2799         Reviewed by Adam Barth.
2800
2801         Note that if release and debug are failing differently, debug
2802         will be ignored ...
2803
2804         Note: also change the use of a fake port name from
2805         "mock-port-name" to "test-mac-leopard" to make it more friendly
2806         to the port factory ("mock" actually is a real port).
2807
2808         * Scripts/webkitpy/tool/servers/gardeningserver.py:
2809         (GardeningHTTPRequestHandler._builders_to_fetch_from):
2810         (GardeningHTTPRequestHandler.rebaselineall):
2811         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2812         (GardeningServerTest.test_rebaselineall):
2813         (GardeningServerTest.test_rebaseline_new_port):
2814
2815 2012-05-24  Dirk Pranke  <dpranke@chromium.org>
2816
2817         nrwt: fix baseline search path for official chrome builders
2818         https://bugs.webkit.org/show_bug.cgi?id=87432
2819
2820         Reviewed by Tony Chang.
2821
2822         The official chrome builders need to use the win7 and SL
2823         baseline paths, not the XP and Leopard paths. Linux is correct.
2824
2825         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2826         (GoogleChromeMacPort.determine_full_port_name):
2827         (GoogleChromeWinPort.determine_full_port_name):
2828         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2829         (TestGoogleChromePort._verify_baseline_search_path_startswith):
2830         (TestGoogleChromePort.test_get_google_chrome_port):
2831
2832 2012-05-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2833
2834         [NRWT] REGRESSION(r116021): Assertion when running with --no-http
2835         https://bugs.webkit.org/show_bug.cgi?id=86800
2836
2837         Reviewed by Dirk Pranke.
2838
2839         Don't launch a HTTP server with lock based only on the existence of
2840         locked shards since we now run perf on locked shards too.
2841
2842         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2843         (Manager._run_tests):
2844
2845 2012-05-24  Jochen Eisinger  <jochen@chromium.org>
2846
2847         Add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
2848         https://bugs.webkit.org/show_bug.cgi?id=87128
2849
2850         Reviewed by Dirk Pranke.
2851
2852         * Scripts/webkitpy/layout_tests/port/base.py:
2853         (Port.driver_name):
2854         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2855         (ChromiumLinuxPort._path_to_driver):
2856         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2857         (ChromiumPortTest.test_driver_name_option):
2858         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2859         (ChromiumWinPort._path_to_driver):
2860         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2861         (parse_args):
2862
2863 2012-05-24  John Mellor  <johnme@chromium.org>
2864
2865         Font Boosting: Add compile flag and runtime setting
2866         https://bugs.webkit.org/show_bug.cgi?id=87394
2867
2868         Reviewed by Adam Barth.
2869
2870         Add ENABLE_FONT_BOOSTING.
2871
2872         * Scripts/webkitperl/FeatureList.pm:
2873         * qmake/mkspecs/features/features.pri:
2874
2875 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2876
2877         [EFL] [DRT] keyboard-related tests do not pass
2878         https://bugs.webkit.org/show_bug.cgi?id=85369
2879
2880         Reviewed by Gustavo Noronha Silva.
2881
2882         Add SHIFT modifier for capital letters as VK_ 
2883         codes do not distinguish between lows and caps and also to be consistent
2884         with other ports which send caps as lowercase letters with the shift key down.
2885
2886         * DumpRenderTree/efl/EventSender.cpp:
2887         (keyNameFromJSValue): 
2888
2889 2012-05-24  Alexey Proskuryakov  <ap@apple.com>
2890
2891         [WK2] Let the client give local files universal access on a case by case basis
2892         https://bugs.webkit.org/show_bug.cgi?id=87174
2893         <rdar://problem/11024330>
2894
2895         Reviewed by Maciej Stachowiak.
2896
2897         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::InjectedBundlePage):
2898         Added initialization of a new structure member to prevent build failure.
2899
2900 2012-05-24  Raphael Kubo da Costa  <rakuco@webkit.org>
2901
2902         [EFL] Modify keycode conversion functions to return keycodes with location information after r118001.
2903         https://bugs.webkit.org/show_bug.cgi?id=87203
2904
2905         Reviewed by Andreas Kling.
2906
2907         Add the required changes to make
2908         fast/events/keydown-leftright-keys.html pass after r118001.
2909
2910         * DumpRenderTree/efl/EventSender.cpp:
2911         (keyNameFromJSValue): Translate "{left,right}{Shift,Alt,Control}"
2912         into the proper X11 keysym definitions.
2913
2914 2012-05-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2915
2916         Unreviewed, rolling out r118352.
2917         http://trac.webkit.org/changeset/118352
2918         https://bugs.webkit.org/show_bug.cgi?id=87390
2919
2920         Caused 6 editing/spelling tests crash/fail on chromium in
2921         debug. (Requested by vsevik on #webkit).
2922
2923         * DumpRenderTree/DumpRenderTree.gypi:
2924         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Removed.
2925         * DumpRenderTree/chromium/MockGrammarCheck.h: Removed.
2926         * DumpRenderTree/chromium/WebViewHost.cpp:
2927         (WebViewHost::finishLastTextCheck):
2928
2929 2012-05-24  Peter Beverloo  <peter@chromium.org>
2930
2931         Add John Mellor as a contributor
2932         https://bugs.webkit.org/show_bug.cgi?id=87389
2933
2934         Reviewed by Kenneth Rohde Christiansen.
2935
2936         John will be working on Font Boosting and is very involved with various
2937         web-facing subjects of Chrome for Android, such as viewport.
2938
2939         * Scripts/webkitpy/common/config/committers.py:
2940
2941 2012-05-24  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2942
2943         [EFL][DRT] LayoutTestController's setCacheModel() implementation
2944         https://bugs.webkit.org/show_bug.cgi?id=86840
2945
2946         Reviewed by Csaba Osztrogonác.
2947
2948         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2949         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Reset dead decoded data deletion interval.
2950         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2951         (LayoutTestController::setCacheModel): Implementation added.
2952
2953 2012-05-24  Hironori Bono  <hbono@chromium.org>
2954
2955         Enable grammar checking on Chromium when we paste text.
2956         https://bugs.webkit.org/show_bug.cgi?id=74393
2957
2958         Reviewed by Hajime Morita.
2959
2960         This change enables grammar checking on Chromium and implements a mock grammar
2961         checker to fix a failing test.
2962
2963         * DumpRenderTree/DumpRenderTree.gypi:
2964         * DumpRenderTree/chromium/MockGrammarCheck.cpp: Added.
2965         (MockGrammarCheck::checkGrammarOfString):
2966         * DumpRenderTree/chromium/MockGrammarCheck.h: Added.
2967         (WebKit):
2968         (MockGrammarCheck):
2969         * DumpRenderTree/chromium/WebViewHost.cpp:
2970         (WebViewHost::finishLastTextCheck): Call MockGrammarCheck::checkGrammarOfString to check grammatical errors.
2971
2972 2012-05-24  Csaba Osztrogonác  <ossy@webkit.org>
2973
2974         [Qt] Unreviewed fix, add ENABLE_CSS3_FLEXBOX after r118304.
2975
2976         * qmake/mkspecs/features/features.pri:
2977
2978 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
2979
2980         [EFL] EFL's LayoutTestController needs to implement sendWebIntentResponse
2981         https://bugs.webkit.org/show_bug.cgi?id=86867
2982
2983         Reviewed by Adam Barth.
2984
2985         Add implementation for sendWebIntentResponse() in EFL's
2986         LayoutTestController and add empty implementation for other ports.
2987
2988         * DumpRenderTree/LayoutTestController.cpp:
2989         (sendWebIntentResponseCallback):
2990         (LayoutTestController::staticFunctions):
2991         * DumpRenderTree/LayoutTestController.h:
2992         (LayoutTestController):
2993         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2994         (LayoutTestController::sendWebIntentResponse):
2995         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2996         (DumpRenderTreeChrome::currentIntentRequest):
2997         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2998         (DumpRenderTreeChrome::onFrameIntentNew):
2999         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3000         (DumpRenderTreeChrome):
3001         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3002         (LayoutTestController::sendWebIntentResponse):
3003         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3004         (LayoutTestController::sendWebIntentResponse):
3005         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3006         (LayoutTestController::sendWebIntentResponse):
3007         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3008         (LayoutTestController::sendWebIntentResponse):
3009         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3010         (LayoutTestController::sendWebIntentResponse):
3011
3012 2012-05-24  Christophe Dumez  <christophe.dumez@intel.com>
3013
3014         [EFL] The EFL port has no support for title directionality
3015         https://bugs.webkit.org/show_bug.cgi?id=86462
3016
3017         Reviewed by Gustavo Noronha Silva.
3018
3019         Update "title,changed" signal handlers in DRT and EWebLauncher to
3020         reflect the change from const char* to Ewk_Text_With_Direction* type
3021         for the title.
3022
3023         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3024         (DumpRenderTreeChrome::onTitleChanged):
3025         * EWebLauncher/main.c:
3026         (title_set):
3027         (on_title_changed):
3028         (on_key_down):
3029
3030 2012-05-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3031
3032         Change EFL debug build name with more detail one
3033         https://bugs.webkit.org/show_bug.cgi?id=87254
3034
3035         Reviewed by Ryosuke Niwa.
3036
3037         EFL Linux Debug buildbot name needs to be consistent with other EFL buildbot name.
3038         In addition, remove efl-linux-debug triggerable since nobody uses it.
3039
3040         * BuildSlaveSupport/build.webkit.org-config/config.json:
3041
3042 2012-05-23  Kangil Han  <kangil.han@samsung.com>
3043
3044         [EFL][DRT] Fix WebCore library path and rebaseline result
3045         https://bugs.webkit.org/show_bug.cgi?id=86355
3046
3047         Reviewed by Dirk Pranke.
3048
3049         Currently EFL DRT uses wrong WebCore library path when running DRT.
3050         Therefore, this patch adjusted the path correctly.
3051
3052         * Scripts/webkitpy/layout_tests/port/efl.py:
3053         (EflPort._path_to_webcore_library):
3054
3055 2012-05-23  Ojan Vafai  <ojan@chromium.org>
3056
3057         add back the ability to disable flexbox
3058         https://bugs.webkit.org/show_bug.cgi?id=87147
3059
3060         Reviewed by Tony Chang.
3061
3062         * Scripts/webkitperl/FeatureList.pm:
3063
3064 2012-05-23  Tony Chang  <tony@chromium.org>
3065
3066         Remove the Chromium Grid Layout bot from the waterfall
3067         https://bugs.webkit.org/show_bug.cgi?id=87311
3068
3069         Reviewed by Ryosuke Niwa.
3070
3071         I removed the compiler define in r117613, so we don't need a separate
3072         bot to compile/test this code.
3073
3074         * BuildSlaveSupport/build.webkit.org-config/config.json:
3075
3076 2012-05-23  Ian Vollick  <vollick@chromium.org>
3077
3078         Add vollick to list of contributors.
3079         https://bugs.webkit.org/show_bug.cgi?id=87305
3080
3081         Reviewed by Adam Barth.
3082
3083         * Scripts/webkitpy/common/config/committers.py:
3084
3085 2012-05-23  Xianzhu Wang  <wangxianzhu@chromium.org>
3086
3087         [Chromium-Android] Fix chromium_android_unittest
3088         https://bugs.webkit.org/show_bug.cgi?id=87196
3089
3090         Reviewed by Tony Chang.
3091
3092         Update unit tests after ChromiumAndroidPort supported apk based
3093         DumpRenderTree.
3094
3095         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3096         (ChromiumAndroidPortTest):
3097         (ChromiumAndroidPortTest.mock_run_command_fn): Moved out from test_get_last_stacktrace so that other tests can use it as a common command line handler.
3098         (ChromiumAndroidPortTest.test_get_last_stacktrace):
3099         (ChromiumAndroidPortTest.test_get_crash_log): Added to test our overridden _get_crash_log()
3100         (ChromiumAndroidDriverTest):
3101         (ChromiumAndroidDriverTest.setUp):
3102         (ChromiumAndroidDriverTest.test_cmd_line): Added to test our overridden cmd_line()
3103         (ChromiumAndroidDriverTest.test_write_command_and_read_line): Added test of unexpected EOF (indicating crash on Android)
3104
3105 2012-05-23  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
3106
3107         [watchlist] Add myself and create a watch rule to catch Attribute related patches
3108         https://bugs.webkit.org/show_bug.cgi?id=87303
3109
3110         Reviewed by Alexis Menard.
3111
3112         * Scripts/webkitpy/common/config/watchlist:
3113
3114 2012-05-23  Dirk Pranke  <dpranke@chromium.org>
3115
3116         garden-o-matic should not fetch from debug bots if it also knows about the release bots
3117         https://bugs.webkit.org/show_bug.cgi?id=86916
3118
3119         Reviewed by Adam Barth.
3120
3121         This change pushes all of the logic for rebaselining a cluster
3122         of failures (a list of tests failing a list of suffixes on a
3123         list of bots) onto the server, so there is a single call from
3124         the web page; we will then be able to optimize the performance
3125         of the rebaselining better.
3126
3127         Also remove the 'optimizebaseline' entry point on garden-o-matic
3128         (and the client-side call) since we don't need it any more.
3129
3130         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
3131         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
3132         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3133         (GardeningHTTPRequestHandler.rebaselineall):
3134         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
3135
3136 2012-05-21  Ryosuke Niwa  <rniwa@webkit.org>
3137
3138         Mac DRT should be able to load external URLs for replay performance tests
3139         https://bugs.webkit.org/show_bug.cgi?id=86191
3140
3141         Reviewed by Alexey Proskuryakov.
3142
3143         Let external URL requests go through if the test file is not a local file or hosted at localhost.
3144         e.g. "DumpRenderTree http://webkit.org/" as supposed to "DumpRenderTree test.html" or
3145         "DumpRenderTree http://localhost:8000/".
3146
3147         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3148         (isLocalhost):
3149         (hostIsUsedBySomeTestsToGenerateError):
3150         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3151
3152 2012-05-23  Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
3153
3154         [wx] In wxWebKit release builds on MSW, keep release settings but also build the 
3155         debug symbols for easier debugging.
3156         https://bugs.webkit.org/show_bug.cgi?id=87151
3157
3158         Reviewed by Kevin Ollivier.
3159
3160         * waf/build/settings.py:
3161         (common_configure):
3162
3163 2012-05-23  Carlos Garcia Campos  <cgarcia@igalia.com>
3164
3165         Unreviewed. Move myself to reviewers.
3166
3167         * Scripts/webkitpy/common/config/committers.py:
3168
3169 2012-05-23  Dongwoo Im  <dw.im@samsung.com>
3170
3171         [EFL] Implements the registerProtocolHandler method and option.
3172         https://bugs.webkit.org/show_bug.cgi?id=73638
3173
3174         Reviewed by Andreas Kling.
3175
3176         * Scripts/webkitperl/FeatureList.pm: Turn on the ENABLE_REGISTER_PROTOCOL_HANDLER option as default on EFL port.
3177
3178 2012-05-23  Zan Dobersek  <zandobersek@gmail.com>
3179
3180         [Gtk] EventSender should properly handle (left|right)(control|shift|alt) after r118001
3181         https://bugs.webkit.org/show_bug.cgi?id=87221
3182
3183         Reviewed by Martin Robinson.
3184
3185         Convert leftAlt, leftControl, leftShift, rightAlt, rightControl and
3186         rightShift key names into proper GDK key symbols.
3187
3188         * DumpRenderTree/gtk/EventSender.cpp:
3189         (createKeyPressEvent):
3190
3191 2012-04-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3192
3193         [Qt] Make the web view's url property follow the active url
3194
3195         https://bugs.webkit.org/show_bug.cgi?id=77554
3196
3197         Update  the location bar in the minibrowser to behave
3198         a bit more like normal browsers in terms of when the url will change
3199         and how active focus is handled.
3200
3201         Reviewed by Simon Hausmann.
3202
3203         * MiniBrowser/qt/qml/BrowserWindow.qml:
3204
3205 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
3206
3207         [Qt] Remove references to $$QT_SOURCE_TREE
3208
3209         With a modularized Qt, it's ambigious. What we really want is qtbase,
3210         which qtcore is a proxy for (we assume it will always live in qtbase).
3211
3212         Reviewed by Tor Arne Vestbø.
3213
3214         * DumpRenderTree/qt/DumpRenderTree.pro:
3215
3216 2012-05-23  Oswald Buddenhagen  <oswald.buddenhagen@nokia.com>
3217
3218         [Qt] Fix qmake conditional for c++-11 compat warnings
3219
3220         Reviewed by Tor Arne Vestbø.
3221
3222         * qmake/mkspecs/features/unix/default_post.prf:
3223
3224 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
3225
3226         [EFL] EFL's DRT does not print didFailProvisionalLoadWithError messages
3227         https://bugs.webkit.org/show_bug.cgi?id=85956
3228
3229         Reviewed by Gustavo Noronha Silva.
3230
3231         Catch new "load,provisional,failed" signal and print
3232         didFailProvisionalLoadWithError messages when LayoutTestController's
3233         dumpFrameLoadCallbacks() returns true. Also make sure the
3234         didFailLoadWithError message is not printed in case of provisional
3235         load failure.
3236
3237         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3238         (DumpRenderTreeChrome::createView):
3239         (DumpRenderTreeChrome::onFrameCreated):
3240         (DumpRenderTreeChrome::onFrameProvisionalLoadFailed):
3241         (DumpRenderTreeChrome::onFrameLoadError):
3242         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
3243         (DumpRenderTreeChrome):
3244
3245 2012-05-23  Christophe Dumez  <christophe.dumez@intel.com>
3246
3247         [EFL] EFL's DRT needs to call Settings::setValidationMessageTimerMagnification(-1)
3248         https://bugs.webkit.org/show_bug.cgi?id=86366
3249
3250         Reviewed by Antonio Gomes.
3251
3252         Call Settings::setValidationMessageTimerMagnification(-1) between the tests.
3253
3254         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3255         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3256
3257 2012-05-22  Darin Adler  <darin@apple.com>
3258
3259         * Scripts/webkitpy/thirdparty/mod_pywebsocket: Added property svn:ignore.
3260         * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake: Added property svn:ignore.
3261
3262 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3263
3264         [Chromium-Android] Run DumpRenderTree as an apk (C++ and gyp part)
3265         https://bugs.webkit.org/show_bug.cgi?id=86922
3266
3267         Because we have new platformInit() in TestShellAndroid.cpp, and
3268         we still need the timeout part in TestShellLinux.cpp, TestShellLinux.cpp
3269         is split into TestShellPosix.cpp and TestShellX11.cpp.
3270
3271         Reviewed by Kent Tamura.
3272
3273         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3274         * DumpRenderTree/DumpRenderTree.gypi:
3275         * DumpRenderTree/chromium/TestShellAndroid.cpp: Added. Handles command lines to redirect stdin/stdout/stderr.
3276         (platformInit):
3277         * DumpRenderTree/chromium/TestShellGtk.cpp: Removed. Merged into TestShellX11.cpp
3278         * DumpRenderTree/chromium/TestShellLinux.cpp: Removed. Split into TestShellPosix.cpp and TestShellX11.cpp.
3279         * DumpRenderTree/chromium/TestShellPosix.cpp: Split from TestShellLinux.cpp, containing the timeout handling part, compiled when os_posix=1 (excluding mac).
3280         (AlarmHandler):
3281         (TestShell::waitTestFinished):
3282         * DumpRenderTree/chromium/TestShellX11.cpp: Split from TestShellLinux.cpp, containing the fontconfig part, compiled when use_x11=1
3283         (openStartupDialog): from TestShellGtk.cpp
3284         (checkLayoutTestSystemDependencies): from TestShellGtk.cpp.
3285         (setupFontconfig):
3286         (platformInit):
3287
3288 2012-05-22  Kangil Han  <kangil.han@samsung.com>
3289
3290         [EFL][DRT] Implement touch event
3291         https://bugs.webkit.org/show_bug.cgi?id=86720
3292
3293         Reviewed by Hajime Morita.
3294
3295         Currently EFL DRT doesn't support touch event.
3296         Therefore, this patch enabled it and implemented some eventSender function callbacks.
3297
3298         * DumpRenderTree/efl/EventSender.cpp:
3299         (TouchEventInfo::TouchEventInfo):
3300         (TouchEventInfo):
3301         (touchPointList):
3302         (sendTouchEvent):
3303         (addTouchPointCallback):
3304         (touchStartCallback):
3305         (updateTouchPointCallback):
3306         (touchMoveCallback):
3307         (cancelTouchPointCallback):
3308         (touchCancelCallback):
3309         (releaseTouchPointCallback):
3310         (touchEndCallback):
3311         (clearTouchPointsCallback):
3312         (setTouchModifierCallback):
3313         * Scripts/webkitperl/FeatureList.pm:
3314
3315 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3316
3317         [Chromium-Android] Fix chromium_android_unittest
3318         https://bugs.webkit.org/show_bug.cgi?id=87196
3319
3320         Not reviewed.
3321         Temporarily disable chromium_android_unittest.
3322
3323         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3324         (ChromiumAndroidPortTest):
3325         (ChromiumAndroidDriverTest):
3326
3327 2012-05-22  Jessie Berlin  <jberlin@apple.com>
3328
3329         WebKitTestRunner needs an implementation of layoutTestController.setDefersLoading
3330         https://bugs.webkit.org/show_bug.cgi?id=64313
3331
3332         Reviewed by Jon Honeycutt.
3333
3334         Add it.
3335
3336         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3337         Make sure to generate the binding.
3338
3339         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3340         (WTR::LayoutTestController::setDefersLoading):
3341         Call WKBundlePageSetDefersLoading.
3342         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3343
3344 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3345
3346         [Chromium-Android] Run DumpRenderTree as an apk (python part)
3347         https://bugs.webkit.org/show_bug.cgi?id=86923
3348
3349         chromium_android.py is modified to support running DumpRenderTree as
3350         an apk, so that we can run the tests (e.g. video) requiring features
3351         implemented in Java on Android.
3352
3353         Reviewed by Adam Barth.
3354
3355         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3356         (ChromiumAndroidPort.__init__):
3357         (ChromiumAndroidPort.default_child_processes):
3358         (ChromiumAndroidPort.check_wdiff):
3359         (ChromiumAndroidPort.check_build):
3360         (ChromiumAndroidPort.start_helper):
3361         (ChromiumAndroidPort.skipped_layout_tests):
3362         (ChromiumAndroidPort):
3363         (ChromiumAndroidPort._path_to_driver):
3364         (ChromiumAndroidPort._get_crash_log):
3365         (ChromiumAndroidPort._push_executable):
3366         (ChromiumAndroidPort._run_adb_command):
3367         (ChromiumAndroidPort._get_last_stacktrace):
3368         (ChromiumAndroidPort._get_logcat):
3369         (ChromiumAndroidPort._setup_performance):
3370         (ChromiumAndroidDriver):
3371         (ChromiumAndroidDriver.__init__):
3372         (ChromiumAndroidDriver._command_wrapper):
3373         (ChromiumAndroidDriver.cmd_line):
3374         (ChromiumAndroidDriver._file_exists_on_device):
3375         (ChromiumAndroidDriver._deadlock_detector):
3376         (ChromiumAndroidDriver._start):
3377         (ChromiumAndroidDriver.run_test):
3378         (ChromiumAndroidDriver.stop):
3379         (ChromiumAndroidDriver._write_command_and_read_line):
3380         (ChromiumAndroidDriver._output_image):
3381         (ChromiumAndroidDriver._get_stderr):
3382
3383 2012-05-22  Joshua Bell  <jsbell@chromium.org>
3384
3385         [Chromium] Reverting r118084 - webkit_tests failing on chromium mac.
3386
3387         Unreviewed gardening.
3388
3389         * Scripts/webkitpy/layout_tests/port/base.py:
3390         (Port.driver_name):
3391         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3392         (ChromiumLinuxPort._path_to_driver):
3393         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3394         (ChromiumPortTest.test_overrides_and_builder_names):
3395         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3396         (ChromiumWinPort._path_to_driver):
3397         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3398         (parse_args):
3399
3400 2012-05-22  Xianzhu Wang  <wangxianzhu@chromium.org>
3401
3402         [Chromium] Move conditions in DumpRenderTree.gypi into DumpRenderTree.gyp
3403         https://bugs.webkit.org/show_bug.cgi?id=87176
3404
3405         Reviewed by Tony Chang.
3406
3407         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3408         * DumpRenderTree/DumpRenderTree.gypi:
3409
3410 2012-05-22  Jochen Eisinger  <jochen@chromium.org>
3411
3412         [chromium] add --driver-name option to run_webkit_tests.py to allow for selecting alternative DRT binaries
3413         https://bugs.webkit.org/show_bug.cgi?id=87128
3414
3415         Reviewed by Dirk Pranke.
3416
3417         * Scripts/webkitpy/layout_tests/port/base.py:
3418         (Port.driver_name):
3419         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3420         (ChromiumLinuxPort._path_to_driver):
3421         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3422         (ChromiumPortTest.test_driver_name_option):
3423         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3424         (ChromiumWinPort._path_to_driver):
3425         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3426         (parse_args):
3427
3428 2012-05-22  Jessie Berlin  <jberlin@apple.com>
3429
3430         WTR fix after r118001.
3431
3432         Rubber-stamped by Alexey Proskuryakov.
3433
3434         Update the WTR implementation of keyDown to match the DRT one changed in r118001.
3435
3436         * WebKitTestRunner/mac/EventSenderProxy.mm:
3437         (WTR::EventSenderProxy::keyDown):
3438
3439 2012-05-22  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
3440
3441         [Chromium] Use overloaded printBegin() webkit API to support auto fit to page functionality.
3442         https://bugs.webkit.org/show_bug.cgi?id=86684
3443
3444         Reviewed by Darin Fisher.
3445
3446         * DumpRenderTree/chromium/LayoutTestController.cpp:
3447         (LayoutTestController::numberOfPages):
3448         * DumpRenderTree/chromium/WebViewHost.cpp:
3449         (WebViewHost::printPage):
3450
3451 == Rolled over to ChangeLog-2012-05-22 ==