7bd258157514dba50fc19050f75dc9088d05bfd7
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-03  Chris Dumez  <cdumez@apple.com>
2
3         Unreviewed, fix typo in the name of API test added in r243848.
4
5         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
6         (TestWebKitAPI::TEST):
7
8 2019-04-03  Chris Dumez  <cdumez@apple.com>
9
10         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
11         https://bugs.webkit.org/show_bug.cgi?id=196588
12         <rdar://problem/49365787>
13
14         Reviewed by Ryosuke Niwa.
15
16         Add API test coverage.
17
18         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
19         (TestWebKitAPI::nullJavaScriptCallback):
20         (TestWebKitAPI::didCrashCheckFrames):
21         (TestWebKitAPI::TEST):
22
23 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
24
25         run-webkit-tests: Upload test results (new results database)
26         https://bugs.webkit.org/show_bug.cgi?id=196577
27         <rdar://problem/34841155>
28
29         Reviewed by Lucas Forschler.
30
31         * Scripts/webkitpy/layout_tests/controllers/manager.py:
32         (Manager.run): Upload results after each device shard, since the configuration will be
33         different for each device.
34         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
35         uploaded to a results database.
36         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
37         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
38
39 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
40
41         -apple-trailing-word is needed for browser detection
42         https://bugs.webkit.org/show_bug.cgi?id=196575
43
44         Unreviewed.
45
46         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
47
48 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
49
50         [CMake][WTF] Mirror XCode header directories
51         https://bugs.webkit.org/show_bug.cgi?id=191662
52
53         Reviewed by Konstantin Tokarev.
54
55         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
56         builds.
57
58         * CMakeLists.txt:
59         * DumpRenderTree/CMakeLists.txt:
60         * DumpRenderTree/PlatformWin.cmake:
61         * MiniBrowser/win/CMakeLists.txt:
62         * TestWebKitAPI/CMakeLists.txt:
63         * TestWebKitAPI/PlatformWin.cmake:
64         * WebKitTestRunner/PlatformGTK.cmake:
65         * WebKitTestRunner/PlatformWin.cmake:
66
67 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
68
69         [ews-app] Status bubble should not display certain infrastructure status messages
70         https://bugs.webkit.org/show_bug.cgi?id=196550
71
72         Reviewed by Lucas Forschler.
73
74         Do not display the steps which are un-needed for end-user. This information is still avaiable
75         if the user click on the bubble and look at the Buildbot build.
76         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
77         (StatusBubble._steps_messages):
78         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
79
80 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
81
82         [ews-build] Use https for sending data to ews-app
83         https://bugs.webkit.org/show_bug.cgi?id=196492
84
85         Reviewed by Lucas Forschler.
86
87         * BuildSlaveSupport/ews-build/events.py:
88
89 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
90
91         Remove support for -apple-trailing-word
92         https://bugs.webkit.org/show_bug.cgi?id=196525
93
94         Reviewed by Zalan Bujtas.
95
96         This CSS property is nonstandard and not used.
97
98         * Scripts/webkitperl/FeatureList.pm:
99         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
100
101 2019-04-03  Youenn Fablet  <youenn@apple.com>
102
103         Add a test for DOMCache on multiple browsing in case of private browsing
104         https://bugs.webkit.org/show_bug.cgi?id=196524
105
106         Reviewed by Alex Christensen.
107
108         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
109         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
110
111 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
112
113         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
114         https://bugs.webkit.org/show_bug.cgi?id=196540
115
116         Reviewed by Aakash Jain.
117
118         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
119
120 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
121
122         Add plumbing for a compatibility mode preference in WebKit
123         https://bugs.webkit.org/show_bug.cgi?id=196005
124
125         Reviewed by Tim Horton.
126
127         Add new API tests.
128
129         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
130         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
131
132 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
133
134         [WPE][GTK] Update libsrtp dependency package for Debian
135         https://bugs.webkit.org/show_bug.cgi?id=196528
136
137         Reviewed by Frédéric Wang.
138
139         * gtk/install-dependencies:
140         * wpe/install-dependencies:
141
142 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
143
144         [WK2] Add support for Window's beforeprint / afterprint events
145         https://bugs.webkit.org/show_bug.cgi?id=196478
146         <rdar://problem/49535124>
147
148         Unreviewed build fix for MSVC.
149
150         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
151
152         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
153
154         * WebKitTestRunner/TestController.cpp:
155         (WTR::printFrame): Use int and float literals.
156
157 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
158
159         [ews-build] Reassign bots to queues
160
161         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
162
163 2019-04-02  Chris Dumez  <cdumez@apple.com>
164
165         [WK2] Add support for Window's beforeprint / afterprint events
166         https://bugs.webkit.org/show_bug.cgi?id=196478
167
168         Reviewed by Alex Christensen.
169
170         Add minimal implementation for printFrame in WebKitTestRunner.
171
172         * WebKitTestRunner/TestController.cpp:
173         (WTR::printFrame):
174         (WTR::TestController::createOtherPage):
175         (WTR::TestController::createWebViewWithOptions):
176
177 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
178
179         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
180         https://bugs.webkit.org/show_bug.cgi?id=196491
181
182         Reviewed by Lucas Forschler.
183
184         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
185
186 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
187
188         [ews-build] Configure buildbot try credentials in environment variables
189         https://bugs.webkit.org/show_bug.cgi?id=196501
190
191         Reviewed by Lucas Forschler.
192
193         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
194         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
195         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
196
197 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
198
199         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
200         https://bugs.webkit.org/show_bug.cgi?id=196496
201         <rdar://problem/49521634>
202
203         Reviewed by Chris Dumez.
204
205         Add new API tests (see WebKit ChangeLog for more detail).
206
207         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
208         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
209         (TEST):
210
211 2019-04-02  David Kilzer  <ddkilzer@apple.com>
212
213         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
214         <https://webkit.org/b/196499>
215
216         Reviewed by Alexey Proskuryakov.
217
218         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
219         ENABLE_ADDRESS_SANITIZER.
220
221 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
222
223         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
224         https://bugs.webkit.org/show_bug.cgi?id=182757
225
226         Reviewed by Don Olmstead.
227
228         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
229         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
230
231 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
232
233         run-api-tests: Upload test results
234         https://bugs.webkit.org/show_bug.cgi?id=196323
235         <rdar://problem/49356714>
236
237         Reviewed by Lucas Forschler.
238
239         * Scripts/webkitpy/api_tests/manager.py:
240         (Manager):
241         (Manager.run): Upload results to a results database.
242         * Scripts/webkitpy/api_tests/run_api_tests.py:
243         (parse_args): Add upload arguments.
244         * Scripts/webkitpy/port/base.py:
245         (Port):
246         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
247         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
248         with commits from any other associated repositories.
249         * Scripts/webkitpy/port/device.py:
250         (Device):
251         (Device.build_version): Access build_versoin of underlying platform device.
252         * Scripts/webkitpy/port/ios_simulator_unittest.py:
253         (IOSSimulatorTest):
254         (IOSSimulatorTest.test_configuration_for_upload):
255         * Scripts/webkitpy/port/device_port.py:
256         (DevicePort):
257         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
258         the same as the machine uploading results.
259         * Scripts/webkitpy/port/mac.py:
260         (MacPort):
261         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
262         * Scripts/webkitpy/port/mac_unittest.py:
263         (MacTest):
264         (MacTest.test_configuration_for_upload):
265         * Scripts/webkitpy/xcode/simulated_device.py:
266         (SimulatedDeviceManager._create_device_with_runtime):
267         (SimulatedDevice.__init__): Create simulated device with a build_version.
268         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
269         (test_existing_simulator):
270
271 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
272
273         Remove extra newline characters (Follow-up fix to r243707)
274
275         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
276
277 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
278
279         [ews-app] Use API_KEY to accept results data
280         https://bugs.webkit.org/show_bug.cgi?id=196461
281
282         Reviewed by Dewei Zhu.
283
284         * BuildSlaveSupport/ews-app/ews/views/results.py:
285         (Results.post): Validate EWS_API_KEY before accepting any data.
286         * BuildSlaveSupport/ews-build/events.py:
287         (Events.sendData): Send EWS_API_KEY if available along with event data.
288
289 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
290
291         Unable to copy and paste a PDF from Notes into Mail compose body
292         https://bugs.webkit.org/show_bug.cgi?id=196442
293         <rdar://problem/48573098>
294
295         Reviewed by Tim Horton.
296
297         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
298         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
299         to be specified on the item providers.
300
301         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
302         (TestWebKitAPI::mapItemForTesting):
303         (TestWebKitAPI::contactItemForTesting):
304
305 2019-04-01  Tim Horton  <timothy_horton@apple.com>
306
307         Make UIWKDocumentContext rects per-character instead of per-word
308         https://bugs.webkit.org/show_bug.cgi?id=196459
309
310         Reviewed by Wenson Hsieh.
311
312         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
313         (TEST):
314         Adjust test results due to switching to per-character rects.
315
316 2019-04-01  Chris Dumez  <cdumez@apple.com>
317
318         UIProcess crash when a prewarmed process is terminated
319         https://bugs.webkit.org/show_bug.cgi?id=196451
320         <rdar://problem/49245471>
321
322         Reviewed by Geoffrey Garen.
323
324         Add API test coverage.
325
326         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
327         (TEST):
328
329 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
330
331         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
332         https://bugs.webkit.org/show_bug.cgi?id=196449
333
334         Reviewed by Lucas Forschler.
335
336         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
337         (StatusBubble.get_os_details): Method to get OS and Xcode details.
338         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
339         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
340
341 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
342
343         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
344         https://bugs.webkit.org/show_bug.cgi?id=196444
345
346         Reviewed by Lucas Forschler.
347
348         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
349
350 2019-04-01  Alex Christensen  <achristensen@webkit.org>
351
352         Add SPI to canonicalize NSURLs with WTF::URL
353         https://bugs.webkit.org/show_bug.cgi?id=196415
354         <rdar://problem/44980271>
355
356         Reviewed by Darin Adler.
357
358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
359         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
360         (TestWebKitAPI::TEST):
361
362 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
363
364         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
365         https://bugs.webkit.org/show_bug.cgi?id=196441
366
367         Reviewed by Carlos Garcia Campos.
368
369         Don't cache the wpe_view_backend object that might not exist yet at the
370         time of EventSenderProxy constructor invocation, but instead retrieve
371         that object whenever it's required for event dispatching. This should
372         avoid crashes in this constructor now that it's invoked before any
373         PlatformWindow has been set up (as changed in r243496).
374
375         * WebKitTestRunner/EventSenderProxy.h:
376         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
377         (WTR::viewBackend):
378         (WTR::EventSenderProxy::EventSenderProxy):
379         (WTR::EventSenderProxy::mouseDown):
380         (WTR::EventSenderProxy::mouseUp):
381         (WTR::EventSenderProxy::mouseMoveTo):
382         (WTR::EventSenderProxy::mouseScrollBy):
383         (WTR::EventSenderProxy::keyDown):
384         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
385
386 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
387
388         [Win][WebKit] MiniBrowser should support high DPI display
389         https://bugs.webkit.org/show_bug.cgi?id=196391
390
391         Reviewed by Alex Christensen.
392
393         * MiniBrowser/win/WebKitBrowserWindow.cpp:
394         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
395         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
396         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
397
398 2019-03-31  Sam Weinig  <weinig@apple.com>
399
400         Remove more i386 specific configurations
401         https://bugs.webkit.org/show_bug.cgi?id=196430
402
403         Reviewed by Alexey Proskuryakov.
404
405         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
406         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
407
408 2019-03-31  Andy Estes  <aestes@apple.com>
409
410         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
411         https://bugs.webkit.org/show_bug.cgi?id=196433
412         <rdar://problem/49293305>
413
414         Reviewed by Tim Horton.
415
416         Enhanced API test coverage to include all navigation response policy decisions in both
417         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
418
419         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
420         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
421         (TestWebKitAPI::TEST):
422         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
423         (readFile):
424         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
425         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
426         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
427         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
428         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
429         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
430         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
431         (-[QuickLookDelegate _downloadDidStart:]):
432         (-[QuickLookDelegate _download:didReceiveResponse:]):
433         (-[QuickLookDelegate _download:didReceiveData:]):
434         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
435         (-[QuickLookDelegate _downloadDidFinish:]):
436         (-[QuickLookDelegate _download:didFailWithError:]):
437         (-[QuickLookDelegate _downloadDidCancel:]):
438         (-[QuickLookDelegate verifyDownload]):
439         (runTest):
440         (runTestDecideBeforeLoading):
441         (runTestDecideAfterLoading):
442         (TEST):
443         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
444         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
445         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
446         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
447         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
448         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
449         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
450         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
451         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
452         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
453         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
454         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
455         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
456         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
457
458 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
459
460         [CMake] add testdfg as target with build-jsc
461         https://bugs.webkit.org/show_bug.cgi?id=196393
462
463         Reviewed by Saam Barati.
464
465         Added testdfg as one of the targets to build when
466         using CMake.
467
468         * Scripts/build-jsc:
469
470 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
471
472         Delete WebMetal implementation in favor of WebGPU
473         https://bugs.webkit.org/show_bug.cgi?id=195418
474
475         Reviewed by Dean Jackson.
476
477         * DumpRenderTree/mac/DumpRenderTree.mm:
478         (enableExperimentalFeatures):
479         (resetWebPreferencesToConsistentValues):
480         * Scripts/webkitperl/FeatureList.pm:
481         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
482         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
483         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
484         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
485         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
486         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
487         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
488         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
489         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
490         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
491         (WTR::InjectedBundle::beginTesting):
492         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
493         (WTR::TestRunner::setWebMetalEnabled): Deleted.
494         * WebKitTestRunner/InjectedBundle/TestRunner.h:
495
496 2019-03-29  Chris Dumez  <cdumez@apple.com>
497
498         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
499         https://bugs.webkit.org/show_bug.cgi?id=196405
500         <rdar://problem/49428130>
501
502         Reviewed by Wenson Hsieh.
503
504         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
505         the popover presentation methods to be no-ops. Use this in the new test added in
506         r243523 so that we do not swizzle those methods for all tests. This is needed because
507         those WatchOS tests rely on the popover getting presented and interactive.
508
509         * WebKitTestRunner/TestController.cpp:
510         (WTR::updateTestOptionsFromTestHeader):
511         * WebKitTestRunner/TestController.h:
512         * WebKitTestRunner/TestOptions.h:
513         (WTR::TestOptions::hasSameInitializationOptions const):
514         * WebKitTestRunner/ios/TestControllerIOS.mm:
515         (WTR::TestController::platformInitialize):
516         (WTR::TestController::platformResetStateToConsistentValues):
517
518 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
519
520         [Curl] Add Server Trust Evaluation Support.
521         https://bugs.webkit.org/show_bug.cgi?id=191646
522
523         Reviewed by Fujii Hironori.
524
525         Implemented MiniBrowser UI for asking if user trusts the server.
526
527         * MiniBrowser/win/Common.cpp:
528         (askServerTrustEvaluation):
529         (replaceString):
530         * MiniBrowser/win/Common.h:
531         * MiniBrowser/win/MiniBrowserLib.rc:
532         * MiniBrowser/win/MiniBrowserLibResource.h:
533         * MiniBrowser/win/WebKitBrowserWindow.cpp:
534         (createPEMString):
535         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
536         (WebKitBrowserWindow::canTrustServerCertificate):
537         * MiniBrowser/win/WebKitBrowserWindow.h:
538
539 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
540
541         Implement ResizeObserver.
542         https://bugs.webkit.org/show_bug.cgi?id=157743
543
544         Reviewed by Simon Fraser.
545
546         Support resizeObserverEnabled webPreferences.
547
548         * DumpRenderTree/TestOptions.cpp:
549         (TestOptions::TestOptions):
550         * DumpRenderTree/TestOptions.h:
551         * DumpRenderTree/mac/DumpRenderTree.mm:
552         (setWebPreferencesForTestOptions):
553         * DumpRenderTree/win/DumpRenderTree.cpp:
554         (enableExperimentalFeatures):
555         * Scripts/webkitperl/FeatureList.pm:
556         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
557
558 2019-03-28  John Wilander  <wilander@apple.com>
559
560         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
561         https://bugs.webkit.org/show_bug.cgi?id=196281
562         <rdar://problem/48938748>
563
564         Reviewed by Alex Christensen.
565
566         This patch adds the function isStatisticsHasLocalStorage() to the
567         TestRunner. With it, the page can query the WebsiteDataStore in the
568         UI process to make sure that it sees LocalStorage.
569
570         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
571         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
572         (WTR::TestRunner::isStatisticsHasLocalStorage):
573         * WebKitTestRunner/InjectedBundle/TestRunner.h:
574         * WebKitTestRunner/TestController.cpp:
575         (WTR::TestController::isStatisticsHasLocalStorage):
576         * WebKitTestRunner/TestController.h:
577         * WebKitTestRunner/TestInvocation.cpp:
578         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
579
580 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
581
582         API::Data::createWithoutCopying should do a null check before calling CFRelease
583         https://bugs.webkit.org/show_bug.cgi?id=196276
584         <rdar://problem/48059859>
585
586         Reviewed by Alex Christensen.
587
588         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
589
590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
591         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
592         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
593         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
594         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
595         (TestWebKitAPI::TEST):
596
597 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
598
599         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
600         https://bugs.webkit.org/show_bug.cgi?id=186276
601
602         Reviewed by Carlos Garcia Campos.
603
604         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
605         (webViewLoadChanged):
606         (testWebResourceGetDataError):
607         (testWebResourceGetDataEmpty):
608         (beforeAll):
609         (webViewloadChanged): Deleted.
610
611 2019-03-27  Andy Estes  <aestes@apple.com>
612
613         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
614         https://bugs.webkit.org/show_bug.cgi?id=196317
615
616         Reviewed by Dan Bernstein.
617
618         package-root copies built products into a staging directory using ditto(1), which does not
619         follow symbolic links as it traverses a directory. Now that the files in
620         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
621         itself, these become broken links when ditto'd into the staging directory.
622
623         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
624
625         * Scripts/package-root:
626
627 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
628
629         [ews-app] Update display text of Submit for ews analysis
630         https://bugs.webkit.org/show_bug.cgi?id=196309
631
632         Reviewed by Dewei Zhu.
633
634         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
635
636 2019-03-27  David Kilzer  <ddkilzer@apple.com>
637
638         run-webkit-tests should check for leaks in WebKit processes
639         <https://webkit.org/b/193772>
640         <rdar://problem/46526680>
641
642         Reviewed by Ryosuke Niwa.
643
644         This works by doing the following:
645         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
646           The list of child processes are returned one per line:
647           process.name: pid
648         - Run the "#LIST CHILD PROCESSES" command just before the
649           "#CHECK FOR WORLD LEAKS" command, and store the list of child
650           processes on the ServerProcess object.
651         - When the `--leaks` switch is handled, run check_for_leaks() on
652           each child process after the main test harness.
653
654         * DumpRenderTree/mac/DumpRenderTree.mm:
655         (handleControlCommand):
656         - Use strncmp() instead of strcmp().
657         - Add support for handling "#LIST CHILD PROCESSES" command.
658
659         * Scripts/webkitpy/port/base.py:
660         (Port.check_for_leaks):
661         * Scripts/webkitpy/port/darwin.py:
662         (DarwinPort.check_for_leaks):
663         - Rename redundant 'process_pid' argument to 'process_id'.
664
665         * Scripts/webkitpy/port/driver.py:
666         (Driver.do_post_tests_work):
667         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
668           longer the only command this sends to WebKitTestRunner.
669         - If the `--leaks` switch is present, send the
670           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
671           result using Port.set_webkit_processes().
672         (Driver._parse_child_processes_output):
673         - Add helper method to parse list of child process names and
674           process IDs returned from WebKitTestRunner.
675
676         * Scripts/webkitpy/port/ios_device.py:
677         (IOSDevicePort.check_for_leaks):
678         - Rename redundant 'process_pid' argument to 'process_id'.
679
680         * Scripts/webkitpy/port/leakdetector.py:
681         (LeakDetector._parse_leaks_output):
682         - Return early if there is no leaks_output.
683         (LeakDetector.check_for_leaks):
684         - Rename redundant 'process_pid' argument to 'process_id'.
685
686         * Scripts/webkitpy/port/server_process.py:
687         (ServerProcess.__init__):
688         (ServerProcess.child_processes):
689         (ServerProcess.set_child_processes):
690         - Add instance variable to Port to store list of child process
691           names and process IDs returned from WebKitTestRunner.
692         (ServerProcess._start):
693         - Clear self._child_processes.
694         (ServerProcess.stop):
695         - If self._child_processes is set, call
696           self._port.check_for_leaks() for each child process.
697
698         * Scripts/webkitpy/port/server_process_unittest.py:
699         (TrivialMockPort.check_for_leaks):
700         - Rename redundant 'process_pid' argument to 'process_id'.
701
702         * Scripts/webkitpy/port/simulator_process.py:
703         (SimulatorProcess.stop):
704         - If self._child_processes is set, call
705           self._port.check_for_leaks() for each child process.
706
707         * Scripts/webkitpy/port/watch_device.py:
708         (WatchDevicePort.check_for_leaks):
709         - Rename redundant 'process_pid' argument to 'process_id'.
710
711         * WebKitTestRunner/TestController.cpp:
712         (WTR::TestController::dumpResponse):
713         - Extract method from findAndDumpWorldLeaks() so that it may be
714           reused by findAndDumpWebKitProcessIdentifiers().
715         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
716         - Add method to output process name and process ID of both the
717           WebContent and Networking processes.
718         (WTR::TestController::findAndDumpWorldLeaks):
719         - Fix missing newline in output when there were no abandoned
720           documents.
721         - Call dumpResponse() for extracted code.
722         (WTR::TestController::handleControlCommand):
723         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
724         - Use strncmp() instead of strcmp().
725         - Call findAndDumpWebKitProcessIdentifiers() when
726           "#LIST CHILD PROCESSES" command is sent.
727         * WebKitTestRunner/TestController.h:
728         (WTR::TestController::dumpResponse):
729         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
730         - Declare methods.
731
732 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
733
734         Unreviewed. Add GLib API test cases after r243434.
735
736         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
737         (testWebViewActiveURI):
738         (serverCallback):
739         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
740         (sendRequestCallback):
741
742 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
743
744         Geolocation request not complete when watch request was started in a different web process
745         https://bugs.webkit.org/show_bug.cgi?id=195996
746
747         Reviewed by Alex Christensen.
748
749         Add a test case.
750
751         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
752         (TestWebKitAPI::runJavaScriptAlert):
753         (TestWebKitAPI::TEST):
754
755 2019-03-26  Keith Rollin  <krollin@apple.com>
756
757         Update the way generate-xcfilelists returns strings from functions
758         https://bugs.webkit.org/show_bug.cgi?id=195975
759         <rdar://problem/49040807>
760
761         Reviewed by Dean Jackson.
762
763         There are places where generate-xcfilelists executes assignments with
764         statements like:
765
766             FOO=$(some_function)
767
768         where "some_function" return a string by echoing it. E.g.
769
770             some_function()
771             {
772                 echo "Hello, World"
773             }
774
775         This is a common idiom, but it has a problem if "some_function" needs
776         to call "exit" in an attempt to halt the entire script right then and
777         there. Since "some_function" is called inside of $(), it's being
778         executed in a sub-shell. Calling exit in that sub-shell simply exits
779         that shell; it doesn't not exit the outer shell in which the main part
780         of the script is still running. As such, the main script keeps
781         executing when the intent was for the script to halt.
782
783         The solution to this is to use a different idiom for returning
784         strings. The one we now is to pass in the name of the variable to
785         receive the string result:
786
787             some_function()
788             {
789                 variable_name=$1
790                 eval $variable_name ="Hello, World"
791             }
792
793         The call site now looks like
794
795             some_function FOO
796
797         Because there's no invocation of a sub-shell, some_function can now
798         call "exit" if it wants to, and the entire script will exit at that
799         point.
800
801         * Scripts/generate-xcfilelists:
802
803 2019-03-26  Chris Dumez  <cdumez@apple.com>
804
805         Add basic layout test coverage for File Picker on iOS
806         https://bugs.webkit.org/show_bug.cgi?id=196265
807
808         Reviewed by Wenson Hsieh.
809
810         Add layout test infrastructure to test the file picker on iOS.
811
812         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
813         (WTR::UIScriptController::dismissFilePicker):
814         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
815         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
816         (WTR::UIScriptController::dismissFilePicker):
817         * TestRunnerShared/UIScriptContext/UIScriptController.h:
818         * WebKitTestRunner/TestController.cpp:
819         (WTR::TestController::createWebViewWithOptions):
820         (WTR::updateTestOptionsFromTestHeader):
821         * WebKitTestRunner/TestOptions.h:
822         (WTR::TestOptions::hasSameInitializationOptions const):
823         * WebKitTestRunner/ios/TestControllerIOS.mm:
824         (overridePresentViewController):
825         (WTR::TestController::platformInitialize):
826         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
827         (WTR::UIScriptController::dismissFilePicker):
828
829 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
830
831         Implement async paste method on UIWKInteractionViewProtocol
832         https://bugs.webkit.org/show_bug.cgi?id=196267
833         <rdar://problem/49236346>
834
835         Reviewed by Tim Horton.
836
837         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
838         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
839         are now a part of all iOS 12 internal SDKs.
840
841         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
842
843         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
844         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
845
846         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
847         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
848         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
849         * TestWebKitAPI/ios/UIKitSPI.h:
850
851 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
852
853         [ews-build] Use PostgreSQL for ews.webkit.org database
854         https://bugs.webkit.org/show_bug.cgi?id=196270
855
856         Reviewed by Lucas Forschler.
857
858         * BuildSlaveSupport/ews-app/ews-app/settings.py:
859
860 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
861
862         [ews] Reset simctl states on reboot
863         https://bugs.webkit.org/show_bug.cgi?id=196260
864
865         Rubber-stamped by Aakash Jain.
866
867         * EWSTools/start-queue-mac.sh:
868
869 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
870
871         [ews-build] Use PostgreSQL for ews-build database
872         https://bugs.webkit.org/show_bug.cgi?id=196229
873
874         Reviewed by Lucas Forschler.
875
876         * BuildSlaveSupport/ews-build/master.cfg:
877
878 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
879
880         [ews-build] Get master_hostname dynamically in master.cfg
881         https://bugs.webkit.org/show_bug.cgi?id=196255
882
883         Reviewed by Lucas Forschler.
884
885         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
886         send events data in test mode.
887
888 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
889
890         [ews-app] Set db_constraint to False for Foreign Keys
891         https://bugs.webkit.org/show_bug.cgi?id=196252
892
893         Reviewed by Lucas Forschler.
894
895         * BuildSlaveSupport/ews-app/ews/models/build.py:
896         * BuildSlaveSupport/ews-app/ews/models/step.py:
897
898 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
899
900         [ews-build] is_test_mode_enabled should default to True
901         https://bugs.webkit.org/show_bug.cgi?id=196248
902
903         Reviewed by Lucas Forschler.
904
905         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
906
907 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
908
909         [ews-app] Add webkitperl to ENABLED_QUEUES
910         https://bugs.webkit.org/show_bug.cgi?id=196253
911
912         Reviewed by Lucas Forschler.
913
914         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
915
916 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
917
918         Address NSWindow sometimes using WebKitTestRunnerEvent too early
919         https://bugs.webkit.org/show_bug.cgi?id=196211
920         rdar://problem/49110552
921
922         Reviewed by Tim Horton.
923
924         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
925         Make sure that EventSenderProxy always exists when running tests. We used to create
926         it when resetting before the first test, which is a bit too late.
927
928         * WebKitTestRunner/TestController.h:
929         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
930         (WTR::TestController::platformCreateWebView):
931         (WTR::TestController::platformCreateOtherPage):
932         (WTR::TestController::finishCreatingPlatformWebView):
933         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
934         (WTR::PlatformWebView::PlatformWebView):
935         Moved some code that made NSWindow use NSEvent during web view creation. We may
936         need to move more if some other case us found, but this is enough for now.
937
938 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
939
940         Unreviewed. Fix typo in GLib geolocation API after r243285.
941
942         gelocation -> geolocation.
943
944         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
945         (testGeolocationManagerWatchPosition):
946
947 2019-03-25  Alex Christensen  <achristensen@webkit.org>
948
949         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
950         https://bugs.webkit.org/show_bug.cgi?id=196213
951
952         Reviewed by Geoff Garen.
953
954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
955         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
956         (credentialWithIdentityAndKeychainPath):
957         (-[ChallengeDelegate webView:didFinishNavigation:]):
958         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
959         (TestWebKitAPI::TEST):
960
961 2019-03-25  Alex Christensen  <achristensen@webkit.org>
962
963         Expected shouldn't assume its contained types are copyable
964         https://bugs.webkit.org/show_bug.cgi?id=195986
965
966         Reviewed by JF Bastien.
967
968         * TestWebKitAPI/Tests/WTF/Expected.cpp:
969         (TestWebKitAPI::NonCopyable::operator== const):
970         (TestWebKitAPI::NonCopyable::operator!= const):
971         (TestWebKitAPI::TEST):
972
973 2019-03-25  Tim Horton  <timothy_horton@apple.com>
974
975         Remove some now-unnecessary dynamic class lookup
976         https://bugs.webkit.org/show_bug.cgi?id=196237
977
978         Reviewed by Simon Fraser.
979
980         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
981         (makeRequest):
982         (TEST):
983
984 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
985
986         Unreviewed, rolling out r243450.
987
988         AppleWin and WinCairo port builds get broken.
989
990         Reverted changeset:
991
992         "Add test for fix of #196095"
993         https://bugs.webkit.org/show_bug.cgi?id=196097
994         https://trac.webkit.org/changeset/243450
995
996 2019-03-25  Commit Queue  <commit-queue@webkit.org>
997
998         Unreviewed, rolling out r243465.
999         https://bugs.webkit.org/show_bug.cgi?id=196226
1000
1001         the test doesn't build (Requested by thorton on #webkit).
1002
1003         Reverted changeset:
1004
1005         "Do not terminate the NetworkProcess if a third party
1006         application sends a NSCredential with a SecIdentityRef"
1007         https://bugs.webkit.org/show_bug.cgi?id=196213
1008         https://trac.webkit.org/changeset/243465
1009
1010 2019-03-25  Alex Christensen  <achristensen@webkit.org>
1011
1012         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
1013         https://bugs.webkit.org/show_bug.cgi?id=196213
1014
1015         Reviewed by Geoff Garen.
1016
1017         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1018         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
1019         (credentialWithIdentityAndKeychainPath):
1020         (-[ChallengeDelegate webView:didFinishNavigation:]):
1021         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1022         (TestWebKitAPI::TEST):
1023
1024 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1025
1026         [ews-build] Gracefully handle missing patch_id in events
1027         https://bugs.webkit.org/show_bug.cgi?id=196216
1028
1029         Reviewed by Lucas Forschler.
1030
1031         * BuildSlaveSupport/ews-build/events.py:
1032
1033 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
1034
1035         [ews-build] use lz4 compression for improving buildbot performance
1036         https://bugs.webkit.org/show_bug.cgi?id=196155
1037
1038         Reviewed by Lucas Forschler.
1039
1040         * BuildSlaveSupport/ews-build/master.cfg:
1041
1042 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1043
1044         Pull some API testing helper methods out of TestWKWebView
1045         https://bugs.webkit.org/show_bug.cgi?id=196212
1046
1047         Reviewed by Tim Horton.
1048
1049         Refactor some more API testing utility methods, so that they can be used in
1050         tests that do not use TestWKWebView.
1051
1052         * TestWebKitAPI/cocoa/TestWKWebView.h:
1053         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1054         (-[WKWebView loadTestPageNamed:]):
1055         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
1056         (-[WKWebView synchronouslyLoadHTMLString:]):
1057         (-[WKWebView synchronouslyLoadTestPageNamed:]):
1058         (-[TestWKWebView loadTestPageNamed:]): Deleted.
1059         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
1060         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
1061         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
1062
1063 2019-03-25  Jer Noble  <jer.noble@apple.com>
1064
1065         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
1066         https://bugs.webkit.org/show_bug.cgi?id=196097
1067
1068         Reviewed by Eric Carlson.
1069
1070         Drive-by bug fix: allow tests to play audio without a user gesture by default.
1071
1072         * DumpRenderTree/mac/DumpRenderTree.mm:
1073         (resetWebPreferencesToConsistentValues):
1074         * WebKitTestRunner/TestController.cpp:
1075         (WTR::TestController::resetPreferencesToConsistentValues):
1076
1077 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1078
1079         Pull IPadUserInterfaceSwizzler out into a separate header file
1080         https://bugs.webkit.org/show_bug.cgi?id=196193
1081
1082         Reviewed by Anders Carlsson.
1083
1084         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
1085         be used in other API tests.
1086
1087         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1088         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
1089         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
1090         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.
1091         * TestWebKitAPI/ios/IPadUserInterfaceSwizzler.h: Added.
1092         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler):
1093         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom):
1094
1095 2019-03-25  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1096
1097         Remove NavigatorContentUtils in WebCore/Modules
1098         https://bugs.webkit.org/show_bug.cgi?id=196070
1099
1100         Reviewed by Alex Christensen.
1101
1102         NavigatorContentUtils was to support the custom scheme spec [1].
1103         However, in WebKit side, no port has supported the feature in
1104         WebKit layer after EFL port was removed. So there has been the
1105         only IDL implementation of the NavigatorContentUtils in WebCore.
1106         So we don't need to keep the implementation in WebCore anymore.
1107
1108         [1] https://html.spec.whatwg.org/multipage/system-state.html#custom-handlers
1109
1110         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1111
1112 2019-03-24  Andy Estes  <aestes@apple.com>
1113
1114         [watchOS] Remove unused Proximity Networking code
1115         https://bugs.webkit.org/show_bug.cgi?id=196188
1116
1117         Reviewed by Tim Horton.
1118
1119         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1120         (TEST):
1121
1122 2019-03-23  Keith Miller  <keith_miller@apple.com>
1123
1124         Refactor clz/ctz and fix getLSBSet.
1125         https://bugs.webkit.org/show_bug.cgi?id=196162
1126
1127         Reviewed by Saam Barati.
1128
1129         Add tests for clz, ctz, getLSBSet, and getMSBSet.
1130
1131         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1132         (TestWebKitAPI::TEST):
1133
1134 2019-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1135
1136         [GTK][WPE] check-webkit-style doesn't complain about identifiers with underscores in files under glib, gtk or wpe dirs
1137         https://bugs.webkit.org/show_bug.cgi?id=196143
1138
1139         Reviewed by Michael Catanzaro.
1140
1141         Fix the check for the exception of identifiers starting with webkit_ in files under glib, gtk or wpe
1142         directories.
1143
1144         * Scripts/webkitpy/style/checkers/cpp.py:
1145         (check_identifier_name_in_declaration):
1146         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1147         (WebKitStyleTest.test_names):
1148
1149 2019-03-22  Philippe Normand  <pnormand@igalia.com>
1150
1151         [Flatpak] Manifest expanding fails for qt WPE extension
1152         https://bugs.webkit.org/show_bug.cgi?id=196148
1153
1154         Reviewed by Alex Christensen.
1155
1156         * flatpak/flatpakutils.py:
1157         (expand_submodules_recurse): The last recurse manifest expand
1158         iteration might lead to a single module so take it into account
1159         and don't try to recurse further.
1160
1161 2019-03-22  Chris Dumez  <cdumez@apple.com>
1162
1163         [ iOS Simulator] REGRESSION (r241821) Layout Test platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html is a flaky failure on bots
1164         https://bugs.webkit.org/show_bug.cgi?id=195348
1165         <rdar://problem/48622090>
1166
1167         Reviewed by Alex Christensen.
1168
1169         Make sure webView.configuration.preferences._shouldIgnoreMetaViewport gets reset
1170         to NO when test.options().shouldIgnoreMetaViewport is false.
1171
1172         * WebKitTestRunner/ios/TestControllerIOS.mm:
1173         (WTR::TestController::platformConfigureViewForTest):
1174
1175 2019-03-22  Chris Dumez  <cdumez@apple.com>
1176
1177         Prewarmed processes should be usable with any website data store
1178         https://bugs.webkit.org/show_bug.cgi?id=196104
1179
1180         Reviewed by Alex Christensen.
1181
1182         Add API test coverage.
1183
1184         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1185         (runInitialWarmedProcessUsedTest):
1186         (TEST):
1187
1188 2019-03-22  David Kilzer  <ddkilzer@apple.com>
1189
1190         Back out local changes to Alex's Subversion working directory
1191
1192         They were accidentally committed.
1193
1194         * Scripts/webkitpy/common/system/abstractexecutive.py:
1195         (AbstractExecutive.wait_newest):
1196         * Scripts/webkitpy/common/system/executive.py:
1197         (Executive.running_pids):
1198         * Scripts/webkitpy/common/system/executive_mock.py:
1199         (MockExecutive.running_pids):
1200         * Scripts/webkitpy/common/system/executive_unittest.py:
1201         (ExecutiveTest.serial_test_running_pids):
1202         * Scripts/webkitpy/port/darwin.py:
1203         (DarwinPort.check_for_leaks):
1204         * Scripts/webkitpy/port/leakdetector.py:
1205         (LeakDetector.check_for_leaks):
1206         - This was the hack attached to Bug 193772.
1207
1208         * WebKitTestRunner/mac/WebKitTestRunnerEvent.mm:
1209         (+[WebKitTestRunnerEvent mouseLocation]):
1210         - This works around a crash on an internal build.
1211
1212 2019-03-22  Tim Horton  <timothy_horton@apple.com>
1213
1214         Fix the build after r243354
1215         https://bugs.webkit.org/show_bug.cgi?id=196138
1216         <rdar://problem/49145951>
1217
1218         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1219         (TEST):
1220         * TestWebKitAPI/ios/UIKitSPI.h:
1221
1222 2019-03-21  Tim Horton  <timothy_horton@apple.com>
1223
1224         Adopt UIWKDocumentContext
1225         https://bugs.webkit.org/show_bug.cgi?id=196040
1226         <rdar://problem/48642440>
1227
1228         Reviewed by Ryosuke Niwa.
1229
1230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1231         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm: Added.
1232         (makeRequest):
1233         (-[TestWKWebView synchronouslyRequestDocumentContext:]):
1234         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]):
1235         (applyStyle):
1236         (TEST):
1237         Add tests for UIWKDocumentContext.
1238
1239         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewEditingActions.mm:
1240         (TEST):
1241         (recursiveFindWKContentView): Deleted.
1242         * TestWebKitAPI/cocoa/TestWKWebView.h:
1243         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1244         (recursiveFindWKContentView):
1245         (-[TestWKWebView wkContentView]):
1246         * TestWebKitAPI/ios/UIKitSPI.h:
1247         Share the WKContentView finding code between tests.
1248
1249 2019-03-21  Simon Fraser  <simon.fraser@apple.com>
1250
1251         [iOS WK2] Turn on async overflow scrolling by default
1252         https://bugs.webkit.org/show_bug.cgi?id=196011
1253         rdar://problem/48453859
1254
1255         Reviewed by Antti Koivisto.
1256         
1257         Explicitly turn off the async overflow scrolling internal feature for tests by default,
1258         since so many basic layout tests have different results when compositing is triggered for
1259         overflow.
1260         
1261         Individual tests will re-enable with <!-- webkit-test-runner [ internal:AsyncOverflowScrollingEnabled=true ] -->.
1262
1263         * WebKitTestRunner/TestController.cpp:
1264         (WTR::TestController::resetPreferencesToConsistentValues):
1265
1266 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1267
1268         [ews-build] Retry API test in case of failures
1269         https://bugs.webkit.org/show_bug.cgi?id=196004
1270
1271         Reviewed by Lucas Forschler.
1272
1273         * BuildSlaveSupport/ews-build/steps.py:
1274         (UnApplyPatchIfRequired.doStepIf): Updated doStepIf to include patchFailedAPITests.
1275         (CompileWebKitToT.doStepIf): Ditto.
1276         (RunAPITests.evaluateCommand): Check if tests failed and retry them if required.
1277         (ReRunAPITests): Re-run API tests.
1278         (ReRunAPITests.evaluateCommand): Check if tests failed and retry on clean build if required.
1279         (RunAPITestsWithoutPatch): Run API tests without patch.
1280         (RunAPITestsWithoutPatch.doStepIf):
1281         (RunAPITestsWithoutPatch.hideStepIf):
1282         (RunAPITestsWithoutPatch.evaluateCommand):
1283         (AnalyzeAPITestsResults): Analyze API test results from previous runs.
1284         (AnalyzeAPITestsResults.start):
1285         (AnalyzeAPITestsResults.analyzeResults): Analyze API test results.
1286         (AnalyzeAPITestsResults.getBuildStepByName): Search for a build step by name.
1287         (AnalyzeAPITestsResults.getTestsResults): Get the test results from previous API tesst steps.
1288         * BuildSlaveSupport/ews-build/steps_unittest.py: Monkey patched FakeBuild.
1289
1290 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1291
1292         [ews-build] Update queues configurations
1293         https://bugs.webkit.org/show_bug.cgi?id=196074
1294
1295         Reviewed by Dewei Zhu.
1296
1297         * BuildSlaveSupport/ews-build/config.json: Updated queues from iOS11 to iOS12,
1298         added new bots, reassigned bots for various builders, moved few builders to another scheduler.
1299
1300 2019-03-21  Aakash Jain  <aakash_jain@apple.com>
1301
1302         [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
1303         https://bugs.webkit.org/show_bug.cgi?id=195680
1304         <rdar://problem/48903534>
1305
1306         Unreviewed infrastructure fix.
1307
1308         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1309         (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
1310
1311 2019-03-21  Andy Estes  <aestes@apple.com>
1312
1313         [iOS] Apple Pay should be available in documents with no user agent scripts
1314         https://bugs.webkit.org/show_bug.cgi?id=196061
1315         <rdar://problem/48649391>
1316
1317         Reviewed by Brady Eidson.
1318
1319         Added API tests and related infrastructure.
1320
1321         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1322         * TestWebKitAPI/Tests/WebKitCocoa/ApplePay.mm: Added.
1323         (-[TestApplePayScriptMessageHandler initWithExpectation:]):
1324         (-[TestApplePayScriptMessageHandler userContentController:didReceiveScriptMessage:]):
1325         (TestWebKitAPI::TEST):
1326         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-active-session.html: Added.
1327         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability-in-iframe.html: Added.
1328         * TestWebKitAPI/Tests/WebKitCocoa/apple-pay-availability.html: Added.
1329         * TestWebKitAPI/cocoa/TestProtocol.mm:
1330         (-[TestProtocol startLoading]):
1331         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.h: Added.
1332         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugInWithInternals.mm: Added.
1333         (-[WebProcessPlugInWithInternals webProcessPlugIn:didCreateBrowserContextController:]):
1334         (-[WebProcessPlugInWithInternals webProcessPlugInBrowserContextController:didClearWindowObjectForFrame:inScriptWorld:]):
1335
1336 2019-03-21  Jonathan Bedard  <jbedard@apple.com>
1337
1338         REGRESSSION (r243297): webkitpy tests broken
1339         https://bugs.webkit.org/show_bug.cgi?id=196108
1340
1341         Reviewed by Aakash Jain.
1342
1343         r243297 updated contributors.json, which broke a few unit tests.
1344
1345         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1346         (IRCCommandTest.test_whois):
1347         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
1348
1349 2019-03-21  Chris Dumez  <cdumez@apple.com>
1350
1351         WebKit should throw when trying to create a WKWebView with a related view that is using a different data store
1352         https://bugs.webkit.org/show_bug.cgi?id=196041
1353         <rdar://problem/49083230>
1354
1355         Reviewed by Alex Christensen.
1356
1357         Add API test coverage.
1358
1359         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewConfiguration.mm:
1360         (TEST):
1361
1362 2019-03-21  Alex Christensen  <achristensen@webkit.org>
1363
1364         Add SPI to inform applications of WKContentRuleList actions
1365         https://bugs.webkit.org/show_bug.cgi?id=195965
1366         <rdar://problem/42664365>
1367
1368         Reviewed by Geoff Garen.
1369
1370         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1371         (TestWebKitAPI::allActionsForResourceLoad):
1372         (TestWebKitAPI::testRequest):
1373         (TestWebKitAPI::TEST_F):
1374         * TestWebKitAPI/Tests/WebKitCocoa/ContentRuleListNotification.mm:
1375         (Notification::description):
1376         (Notification::operator== const):
1377         (toVector):
1378         (-[ContentRuleListNotificationDelegate _webView:URL:contentRuleListIdentifiers:notifications:]):
1379         (-[ContentRuleListNotificationDelegate _webView:contentRuleListWithIdentifier:performedActionOnURL:blockedLoad:blockedCookies:madeHTTPS:notifications:]):
1380         (makeContentRuleList):
1381         (TEST):
1382         (makeWarnContentRuleList): Deleted.
1383
1384 2019-03-21  Timothy Hatcher  <timothy@apple.com>
1385
1386         Style check error "WK_MAC_TBA is neither a version number nor WK_IOS_TBA" is confusing.
1387         https://bugs.webkit.org/show_bug.cgi?id=196088
1388
1389         Reviewed by Brian Burg.
1390
1391         Fix the error messages used when looking for macos(WK_IOS_TBA) or ios(WK_MAC_TBA).
1392         Support checks when only one platform is specified. Also deprecate macosx() and
1393         force the use of macos() instead.
1394
1395         * Scripts/webkitpy/style/checkers/cpp.py:
1396         (check_min_versions_of_wk_api_available):
1397         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1398         (WebKitStyleTest.test_min_versions_of_wk_api_available):
1399
1400 2019-03-21  Alexey Proskuryakov  <ap@apple.com>
1401
1402         Update status inactive committers' status to 'contributor'.
1403
1404         * Scripts/webkitpy/common/config/contributors.json:
1405
1406 2019-03-21  Xan Lopez  <xan@igalia.com>
1407
1408         [JSC][x86] Drop support for x87 floating point
1409         https://bugs.webkit.org/show_bug.cgi?id=194853
1410
1411         Reviewed by Don Olmstead.
1412
1413         Force SSE2 on x86/32bit builds.
1414
1415         * Scripts/webkitdirs.pm:
1416         (generateBuildSystemFromCMakeProject):
1417
1418 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1419
1420         [GLIB] User data not correctly passed to callback of functions and constructors with no parameters
1421         https://bugs.webkit.org/show_bug.cgi?id=196073
1422
1423         Reviewed by Michael Catanzaro.
1424
1425         Add test cases to check functions and constructors with no arguments but receiving user data.
1426
1427         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1428         (checkUserData):
1429         (testJSCFunction):
1430         (fooCreateWithUserData):
1431         (testJSCClass):
1432
1433 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1434
1435         Unreviewed. Fix GTK build with GLib < 2.58 after r243285.
1436
1437         Add g_assert_cmpfloat_with_epsilon macro if not defined.
1438
1439         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1440
1441 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1442
1443         [GTK][WPE] Add API to provide geolocation information
1444         https://bugs.webkit.org/show_bug.cgi?id=195940
1445
1446         Reviewed by Michael Catanzaro.
1447
1448         Add a new test to check the new API.
1449
1450         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp: Added.
1451         (testGeolocationManagerCurrentPosition):
1452         (testGeolocationManagerWatchPosition):
1453         (beforeAll):
1454         (afterAll):
1455         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1456         (testWebViewGeolocationPermissionRequests): Stop using ENABLE(GEOLOCATION) conditionals for geolocation tests.
1457         (beforeAll): Ditto.
1458         * TestWebKitAPI/glib/CMakeLists.txt:
1459
1460 2019-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1461
1462         [GLib] Returning G_TYPE_OBJECT from a method does not work
1463         https://bugs.webkit.org/show_bug.cgi?id=195574
1464
1465         Reviewed by Michael Catanzaro.
1466
1467         Add new test cases to check the behavior of constructors and functions returning GObject and boxed types.
1468
1469         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1470         (getGFile):
1471         (getParent):
1472         (createGString):
1473         (getGString):
1474         (getGStringCopyWillRaise):
1475         (getGStringCopy):
1476         (getGStringStr):
1477         (getGStringLen):
1478         (freeGString):
1479         (testJSCClass):
1480
1481 2019-03-20  Saam Barati  <sbarati@apple.com>
1482
1483         DFG::AbstractValue::validateOSREntry is wrong when isHeapTop and the incoming value is Empty
1484         https://bugs.webkit.org/show_bug.cgi?id=195721
1485
1486         Reviewed by Filip Pizlo.
1487
1488         * Scripts/run-javascriptcore-tests:
1489
1490 2019-03-20  Simon Fraser  <simon.fraser@apple.com>
1491
1492         Rename ENABLE_ACCELERATED_OVERFLOW_SCROLLING macro to ENABLE_OVERFLOW_SCROLLING_TOUCH
1493         https://bugs.webkit.org/show_bug.cgi?id=196049
1494
1495         Reviewed by Tim Horton.
1496
1497         This macro is about the -webkit-overflow-scrolling CSS property, not accelerated
1498         overflow scrolling in general, so rename it.
1499
1500         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1501
1502 2019-03-20  Daniel Bates  <dabates@apple.com>
1503
1504         REGRESSION (r243153): [iOS] TestWebKitAPI.FocusPreservationTests.ChangingFocusedNodeResetsFocusPreservationState is failing
1505         https://bugs.webkit.org/show_bug.cgi?id=196031
1506         <rdar://problem/49078172>
1507
1508         Reviewed by Tim Horton.
1509
1510         The test incorrectly assumes that calling -[WKWebView resignFirstResponder] is identical to dismissing the
1511         <select> picker. This is no longer the case following r243135. Instead use testing SPI that invokes that
1512         same code path used when the Done button is pressed to dismiss the <select> picker.
1513
1514         * TestWebKitAPI/Tests/ios/FocusPreservationTests.mm:
1515         (TestWebKitAPI::TEST):
1516
1517 2019-03-20  Chris Dumez  <cdumez@apple.com>
1518
1519         Regression(PSON): ViewGestureController is not properly notified of process swaps on iOS
1520         https://bugs.webkit.org/show_bug.cgi?id=196029
1521         <rdar://problem/48954651>
1522
1523         Reviewed by Tim Horton.
1524
1525         Add API test coverage.
1526
1527         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1528
1529 2019-03-20  Aakash Jain  <aakash_jain@apple.com>
1530
1531         [ews-build] Improve failure summary string for ApplyPatch step
1532         https://bugs.webkit.org/show_bug.cgi?id=195995
1533
1534         Reviewed by Alexey Proskuryakov.
1535
1536         * BuildSlaveSupport/ews-build/steps.py:
1537         (ApplyPatch.getResultSummary): Override getResultSummary.
1538
1539 2019-03-20  Joanmarie Diggs  <jdiggs@igalia.com>
1540
1541         AX: Implement support for new meter ARIA role
1542         https://bugs.webkit.org/show_bug.cgi?id=195966
1543
1544         Reviewed by Chris Fleizach.
1545
1546         Update Core role for ATK_ROLE_LEVEL_BAR from AXProgressIndicator
1547         to AXLevelIndicator.
1548
1549         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1550
1551 2019-03-19  Jiewen Tan  <jiewen_tan@apple.com>
1552
1553         [WebAuthN] Implement FIDO AppID extension
1554         https://bugs.webkit.org/show_bug.cgi?id=143491
1555         <rdar://problem/48298273>
1556
1557         Reviewed by Brent Fulgham.
1558
1559         Add a test that covers the new flag of convertToU2fSignCommand.
1560
1561         * TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:
1562         (TestWebKitAPI::TEST):
1563         * TestWebKitAPI/Tests/WebCore/FidoTestData.h:
1564         * TestWebKitAPI/Tests/WebCore/U2fCommandConstructorTest.cpp:
1565         (TestWebKitAPI::TEST):
1566
1567 2019-03-19  Keith Rollin  <krollin@apple.com>
1568
1569         Add support for more platforms to generate-xcfilelists
1570         https://bugs.webkit.org/show_bug.cgi?id=195977
1571
1572         Reviewed by Alexey Proskuryakov.
1573
1574         generate-xcfilelists incorrectly complains when involved with building
1575         WebKit for iphonesimulator:
1576
1577             $ make debug SDKROOT=iphonesimulator.internal -C Internal/
1578             …
1579             ### (die get_canonical_platform_name main main) Unrecognized platform name: iphonesimulator
1580
1581         Address this by teaching generate-xcfilelists about more platforms.
1582
1583         * Scripts/generate-xcfilelists:
1584
1585 2019-03-19  John Wilander  <wilander@apple.com>
1586
1587         Resource Load Statistics (experimental): Clear non-cookie website data for sites that have been navigated to, with link decoration, by a prevalent resource
1588         https://bugs.webkit.org/show_bug.cgi?id=195923
1589         <rdar://problem/49001272>
1590
1591         Reviewed by Alex Christensen.
1592
1593         This patch does the following to the TestRunner:
1594         - Adds setStatisticsCrossSiteLoadWithLinkDecoration().
1595         - Makes setStatisticsTimeToLiveUserInteraction() wait for completion.
1596         - Makes statisticsProcessStatisticsAndDataRecords() wait for completion.
1597
1598         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1599         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1600         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1601         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1602         * WebKitTestRunner/TestController.cpp:
1603         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
1604         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
1605         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
1606         * WebKitTestRunner/TestController.h:
1607         * WebKitTestRunner/TestInvocation.cpp:
1608         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1609
1610 2019-03-19  Christopher Reid  <chris.reid@sony.com>
1611
1612         [CMake] Support more clang and gcc sanitizers
1613         https://bugs.webkit.org/show_bug.cgi?id=195956
1614
1615         Reviewed by Michael Catanzaro.
1616
1617         * Scripts/webkitdirs.pm: Updating ENABLE_ADDRESS_SANITIZER to ENABLE_SANITIZERS=address
1618
1619 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1620
1621         [ews-build] Improve summary for PrintConfiguration step
1622         https://bugs.webkit.org/show_bug.cgi?id=195945
1623
1624         Reviewed by Lucas Forschler.
1625
1626         * BuildSlaveSupport/ews-build/steps.py:
1627         (PrintConfiguration.getResultSummary): Override getResultSummary.
1628
1629 2019-03-19  Aakash Jain  <aakash_jain@apple.com>
1630
1631         [ews-build] Improve summary for CheckOutSource step
1632         https://bugs.webkit.org/show_bug.cgi?id=195963
1633
1634         Reviewed by Lucas Forschler.
1635
1636         * BuildSlaveSupport/ews-build/steps.py:
1637         (CheckOutSource.getResultSummary):
1638
1639 2019-03-19  Daniel Bates  <dabates@apple.com>
1640
1641         [iOS] Focus not preserved when switching between tabs
1642         https://bugs.webkit.org/show_bug.cgi?id=195820
1643         <rdar://problem/43614450>
1644
1645         Reviewed by Brent Fulgham.
1646
1647         Add tests to ensure that we restore focus when resigning and becoming first responder.
1648
1649         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
1650         (TestWebKitAPI::TEST):
1651
1652 2019-03-19  Alex Christensen  <achristensen@webkit.org>
1653
1654         Make WTFLogChannelState and WTFLogLevel enum classes
1655         https://bugs.webkit.org/show_bug.cgi?id=195904
1656
1657         Reviewed by Eric Carlson.
1658
1659         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1660         (TestWebKitAPI::TEST_F):
1661
1662 2019-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1663
1664         [GStreamer][EME] Backported mssdemux protection data crash fix
1665         https://bugs.webkit.org/show_bug.cgi?id=195918
1666
1667         Reviewed by Philippe Normand.
1668
1669         * gstreamer/jhbuild.modules:
1670         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Added.
1671
1672 2019-03-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1673
1674         Unreviewed, rolling out r243132.
1675
1676         Broke GTK build
1677
1678         Reverted changeset:
1679
1680         "Make WTFLogChannelState and WTFLogLevel enum classes"
1681         https://bugs.webkit.org/show_bug.cgi?id=195904
1682         https://trac.webkit.org/changeset/243132
1683
1684 2019-03-19  Zan Dobersek  <zdobersek@igalia.com>
1685
1686         Unreviewed follow-up to r243073, fixing WPE MiniBrowser launching.
1687
1688         * Scripts/webkitdirs.pm:
1689         (builtDylibPathForName): Adjust the shared library name that's changed
1690         with the API version bump in r243073.
1691
1692 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1693
1694         Make WTFLogChannelState and WTFLogLevel enum classes
1695         https://bugs.webkit.org/show_bug.cgi?id=195904
1696
1697         Reviewed by Eric Carlson.
1698
1699         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1700         (TestWebKitAPI::TEST_F):
1701
1702 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1703
1704         Disable flaky test added in r2431100
1705         https://webkit.org/b/195785
1706
1707         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1708         (TestWebKitAPI::TEST):
1709         Apparently bots don't hit 150kb/s as reliably as I do locally.  Can't say I'm too surprised.
1710
1711 2019-03-18  Timothy Hatcher  <timothy@apple.com>
1712
1713         WKWebView.GetContentsShouldReturnAttributedString is crashing on iOS Simulator.
1714         https://bugs.webkit.org/show_bug.cgi?id=195916
1715
1716         Reviewed by Tim Horton.
1717
1718         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1719         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Fix iOS code path to pass.
1720
1721 2019-03-18  Alexey Proskuryakov  <ap@apple.com>
1722
1723         Add a secondary e-mail address for Fujii Hironori to make tools happier.
1724
1725         * Scripts/webkitpy/common/config/contributors.json:
1726
1727 2019-03-18  Alex Christensen  <achristensen@webkit.org>
1728
1729         Implement DownloadMonitor to prevent long-running slow downloads from background apps
1730         https://bugs.webkit.org/show_bug.cgi?id=195785
1731
1732         Reviewed by Geoffrey Garen.
1733
1734         * TestWebKitAPI/TCPServer.cpp: Added.
1735         (TestWebKitAPI::TCPServer::TCPServer):
1736         (TestWebKitAPI::TCPServer::~TCPServer):
1737         (TestWebKitAPI::TCPServer::socketBindListen):
1738         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests):
1739         * TestWebKitAPI/TCPServer.h: Added.
1740         (TestWebKitAPI::TCPServer::port const):
1741         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1742         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1743         (-[DownloadMonitorTestDelegate _downloadDidStart:]):
1744         (-[DownloadMonitorTestDelegate _downloadDidCancel:]):
1745         (-[DownloadMonitorTestDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
1746         (-[DownloadMonitorTestDelegate _download:didReceiveData:]):
1747         (TestWebKitAPI::respondSlowly):
1748         (TestWebKitAPI::webViewWithDownloadMonitorSpeedMultiplier):
1749         (TestWebKitAPI::downloadAtRate):
1750         (TestWebKitAPI::TEST):
1751
1752 2019-03-18  Saam Barati  <sbarati@apple.com>
1753
1754         Add a plan file for JetStream 2
1755         https://bugs.webkit.org/show_bug.cgi?id=190734
1756
1757         Reviewed by Mark Lam.
1758
1759         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream2.plan: Added.
1760
1761 2019-03-18  Chris Dumez  <cdumez@apple.com>
1762
1763         Delay WebProcess launch until a load is triggered in a Web view
1764         https://bugs.webkit.org/show_bug.cgi?id=195758
1765         <rdar://problem/48126013>
1766
1767         Reviewed by Geoff Garen.
1768
1769         Add API test coverage. Also update some existing API tests to not expect
1770         constructing a WKWebView to launch both a WebProcess and a NetworkProcess.
1771
1772         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
1773         (TestWebKitAPI::TEST):
1774         * TestWebKitAPI/Tests/WebKit/mac/GetBackingScaleFactor.mm:
1775         (TestWebKitAPI::TEST):
1776         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
1777         (TEST):
1778         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1779         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1780         (TEST):
1781         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1782         (TEST):
1783         (testDidResignInputElementStrongPasswordAppearanceAfterEvaluatingJavaScript):
1784
1785 2019-03-18  Xan Lopez  <xan@igalia.com>
1786
1787         [CMake] Prevent potential warning when determining $architecture
1788         https://bugs.webkit.org/show_bug.cgi?id=195891
1789
1790         Reviewed by Michael Catanzaro.
1791
1792         It's possible for generateBuildSystemForCMakeProject to be called
1793         before determineArchitecture() is ever called. This will make the
1794         first eq check with $architecture to be bogus (and print a
1795         warning). Change that to an eq check with architecture(), which
1796         implicitly calls determineArchitecture() if needed, and change all
1797         the other similar cases in the method in the same way to prevent
1798         future bugs like this one.
1799
1800         * Scripts/webkitdirs.pm:
1801         (generateBuildSystemFromCMakeProject):
1802
1803 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1804
1805         [WPE] Tarballs generated with “make dist” cannot build documentation
1806         https://bugs.webkit.org/show_bug.cgi?id=195885
1807
1808         Reviewed by Carlos Garcia Campos.
1809
1810         * wpe/manifest.txt.in: Add missing Tools/glib/common.py file to be included in release tarballs.
1811
1812 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1813
1814         [GTK][WPE] Cryptic error from Tools/gtkdoc/generate-gtkdoc
1815         https://bugs.webkit.org/show_bug.cgi?id=195883
1816
1817         Reviewed by Carlos Garcia Campos.
1818
1819         * gtkdoc/gtkdoc.py:
1820         (GTKDoc._run_command): When commands fail to run, include the full command line for
1821         the program invocation and the output it has generated on the standard error stream.
1822
1823 2019-03-18  Adrian Perez de Castro  <aperez@igalia.com>
1824
1825         [WPE] Bump dependencies to wpe-1.0 and wpebackend-fdo-1.0
1826         https://bugs.webkit.org/show_bug.cgi?id=195786
1827
1828         Reviewed by Philippe Normand.
1829
1830         * flatpak/org.webkit.WPEModules.yaml: Use libwpe 1.1.90 and wpebackend-fdo 1.1.91.
1831         * wpe/jhbuild.modules: Ditto.
1832
1833 2019-03-16  Aakash Jain  <aakash_jain@apple.com>
1834
1835         [ews-build] Don't run clean builds on EWS builders
1836         https://bugs.webkit.org/show_bug.cgi?id=195851
1837
1838         Reviewed by Geoffrey Garen.
1839
1840         * BuildSlaveSupport/ews-build/factories.py:
1841
1842 2019-03-16  Sihui Liu  <sihui_liu@apple.com>
1843
1844         REGRESSION (r243019): Failing API test: WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming
1845         https://bugs.webkit.org/show_bug.cgi?id=195849
1846
1847         Reviewed by Chris Dumez.
1848
1849         We should expect IDB database files to be at path IndexedDB/v1/ after r243019.
1850
1851         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1852         (runWebsiteDataStoreCustomPaths):
1853
1854 2019-03-15  Jonathan Bedard  <jbedard@apple.com>
1855
1856         webkitpy: Upload test results
1857         https://bugs.webkit.org/show_bug.cgi?id=195755
1858         <rdar://problem/48896182>
1859
1860         Reviewed by Aakash Jain.
1861
1862         Establish a new format for uploading results that is not tied to layout tests, apply
1863         that format to webkitpy tests.
1864
1865         * Scripts/webkitpy/common/checkout/scm/git.py:
1866         (Git.native_branch): Return what branch the current checkout is on.
1867         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
1868         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1869         * Scripts/webkitpy/common/checkout/scm/svn.py:
1870         (SVN.native_branch): Ditto.
1871         * Scripts/webkitpy/common/system/platforminfo.py:
1872         (PlatformInfo.build_version): Return a build version for Mac.
1873         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1874         (MockPlatformInfo.__init__):
1875         (MockPlatformInfo.build_version):
1876         * Scripts/webkitpy/results: Added.
1877         * Scripts/webkitpy/results/__init__.py: Added.
1878         * Scripts/webkitpy/results/options.py: Added.
1879         (upload_options): OptParse list for upload options.
1880         * Scripts/webkitpy/results/upload.py: Added.
1881         (Upload): Class which enforces the upload format expected by the results server.
1882         (Upload.Expectations):
1883         (Upload.create_configuration):
1884         (Upload.create_commit):
1885         (Upload.create_details):
1886         (Upload.create_run_stats):
1887         (Upload.create_test_result):
1888         (Upload.__init__):
1889         (Upload.Encoder): Encode Upload object as json.
1890         (Upload.upload): Upload results to the results server, returning 'True' if the upload is successful.
1891         * Scripts/webkitpy/results/upload_unittest.py: Added.
1892         * Scripts/webkitpy/test/main.py:
1893         (Tester._parse_args): Add upload arguments.
1894         (Tester._run_tests): Allow results to be uploaded.
1895         * Scripts/webkitpy/test/runner.py:
1896         (Runner.__init__): Record which tests were run, rather than just counting them.
1897         (Runner.handle):
1898         * Scripts/webkitpy/test/runner_unittest.py:
1899         (RunnerTest.test_run):
1900         * Scripts/webkitpy/thirdparty/__init__.py:
1901         (AutoinstallImportHook.find_module): Add requests auto-install.
1902         (AutoinstallImportHook._install_requests):
1903         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1904         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Update os name for testing.
1905
1906 2019-03-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1907
1908         [iOS] Crash under -[TestRunnerWKWebView _didShowMenu] while running layout tests on iOS simulator
1909         https://bugs.webkit.org/show_bug.cgi?id=195810
1910
1911         Reviewed by Tim Horton.
1912
1913         Ensure that the process of resetting web view state between tests doesn't also invoke testing callbacks
1914         registered by the previous layout test. This fixes an occasional crash when hiding the callout menu after
1915         ending certain layout tests.
1916
1917         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1918         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1919         (-[TestRunnerWKWebView dealloc]):
1920         (-[TestRunnerWKWebView resetInteractionCallbacks]):
1921
1922         Pull logic to reset all of TestRunnerWKWebView's callback handler blocks into a separate helper method; use this
1923         helper method when destroying the web view, and when resetting state between tests.
1924
1925         * WebKitTestRunner/ios/TestControllerIOS.mm:
1926         (WTR::TestController::platformResetStateToConsistentValues):
1927
1928         Hide the callout menu *after* clearing out interaction callbacks registered on the web view.
1929
1930 2019-03-15  Sihui Liu  <sihui_liu@apple.com>
1931
1932         [ Mojave WK1 ] Layout Test storage/indexeddb/database-odd-names.html is failing
1933         https://bugs.webkit.org/show_bug.cgi?id=190350
1934         <rdar://problem/45089503>
1935
1936         Reviewed by Geoffrey Garen.
1937
1938         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1939         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1940         (TEST):
1941         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3:
1942         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-shm:
1943         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDB.sqlite3-wal:
1944         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-1.html: Added.
1945         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName-2.html: Added.
1946         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBFileName.mm: Added.
1947         (-[IndexedDBFileNameMessageHandler userContentController:didReceiveScriptMessage:]):
1948         (runTest):
1949         (createDirectories):
1950         (TEST):
1951         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
1952         (TEST):
1953         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
1954         (TEST):
1955
1956 2019-03-15  Timothy Hatcher  <timothy@apple.com>
1957
1958         Add support to WebPage for getting the contents as an attributed string.
1959         https://bugs.webkit.org/show_bug.cgi?id=195636
1960         rdar://problem/45055697
1961
1962         Reviewed by Tim Horton.
1963
1964         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
1965         (TEST(WKWebView, GetContentsShouldReturnAttributedString): Added.
1966
1967 2019-03-15  Chris Dumez  <cdumez@apple.com>
1968
1969         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
1970         https://bugs.webkit.org/show_bug.cgi?id=195747
1971
1972         Reviewed by Geoff Garen.
1973
1974         Add API test coverage.
1975
1976         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1977
1978 2019-03-15  Shawn Roberts  <sroberts@apple.com>
1979
1980         Unreviewed, rolling out r242952.
1981
1982         Causing API failures on iOS Simulator
1983
1984         Reverted changeset:
1985
1986         "[PSON] Make sure the WebProcessCache is leverage when
1987         relaunching a process after termination"
1988         https://bugs.webkit.org/show_bug.cgi?id=195747
1989         https://trac.webkit.org/changeset/242952
1990
1991 2019-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
1992
1993         [Win][MinBrowser][WK2] Implement createNewPage of WKPageUIClient to open a new window
1994         https://bugs.webkit.org/show_bug.cgi?id=195740
1995
1996         Reviewed by Ross Kirsling.
1997
1998         window.open doesn't work for WebKitBrowserWindow because it is not
1999         implemented yet.
2000
2001         1. Implemented createNewPage callback of WKPageUIClient.
2002         2. Changed MainWindow to take a BrowserWindow factory function
2003           instead of BrowserWindowType to be flexible to create
2004           BrowserWindow with extra settings.
2005         3. Renamed MainWindow::BrowserWindowType to BrowserWindowType
2006           because it is not relevant with MainWindow anymore.
2007
2008         * MiniBrowser/win/Common.cpp:
2009         (parseCommandLine):
2010         * MiniBrowser/win/Common.h:
2011         (CommandLineOptions::CommandLineOptions):
2012         * MiniBrowser/win/MainWindow.cpp:
2013         (MainWindow::MainWindow):
2014         (MainWindow::create):
2015         (MainWindow::init):
2016         (MainWindow::WndProc):
2017         * MiniBrowser/win/MainWindow.h:
2018         * MiniBrowser/win/PrintWebUIDelegate.cpp:
2019         (PrintWebUIDelegate::createWebViewWithRequest):
2020         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2021         (WebKitBrowserWindow::create): Moved WKPageConfigurationRef related code from WebKitBrowserWindow::WebKitBrowserWindow.
2022         (WebKitBrowserWindow::WebKitBrowserWindow): Added a WKPageConfigurationRef parameter.
2023         (WebKitBrowserWindow::updateProxySettings):
2024         (WebKitBrowserWindow::createNewPage):
2025         * MiniBrowser/win/WebKitBrowserWindow.h:
2026         * MiniBrowser/win/WinMain.cpp:
2027         (wWinMain):
2028
2029 2019-03-14  Simon Fraser  <simon.fraser@apple.com>
2030
2031         Make it possible to test scrolling tree layer manipulation more easily
2032         https://bugs.webkit.org/show_bug.cgi?id=195780
2033
2034         Reviewed by Tim Horton.
2035         
2036         Add a boolean attribute 'scrollUpdatesDisabled' on UIScriptController that
2037         cuts off communication of scrolling tree scrolls back to the web process
2038         (in RemoteScrollingCoordinatorProxy::scrollingTreeNodeDidScroll()). This
2039         allows tests to trigger scrolls which run the scrolling tree layer positioning
2040         logic, but never get another commit from the web process that might mask
2041         scrolling tree bugs.
2042         
2043         WKWebView's testing protocol get @property _scrollingUpdatesDisabledForTesting,
2044         whose getters and setters are overridden by TestRunnerWKWebView. Plumbing
2045         via PageClient and WebPageProxy makes this flag reachable by RemoteScrollingCoordinatorProxy.
2046
2047         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2048         (WTR::UIScriptController::scrollUpdatesDisabled const):
2049         (WTR::UIScriptController::setScrollUpdatesDisabled):
2050         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2051         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2052         (WTR::UIScriptController::scrollUpdatesDisabled const):
2053         (WTR::UIScriptController::setScrollUpdatesDisabled):
2054         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2055         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2056         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2057         (-[TestRunnerWKWebView _scrollingUpdatesDisabledForTesting]):
2058         (-[TestRunnerWKWebView _setScrollingUpdatesDisabledForTesting:]):
2059         * WebKitTestRunner/ios/TestControllerIOS.mm:
2060         (WTR::TestController::platformResetStateToConsistentValues):
2061         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2062         (WTR::UIScriptController::scrollUpdatesDisabled const):
2063         (WTR::UIScriptController::setScrollUpdatesDisabled):
2064
2065 2019-03-14  Youenn Fablet  <youenn@apple.com>
2066
2067         Move IDB storage in private browsing mode to NetworkProcess
2068         https://bugs.webkit.org/show_bug.cgi?id=195602
2069
2070         Reviewed by Brady Eidson.
2071
2072         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2073         (TEST):
2074
2075 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2076
2077         [ews-build] Make descriptionDone messages more readable
2078         https://bugs.webkit.org/show_bug.cgi?id=195760
2079
2080         Reviewed by Lucas Forschler.
2081
2082         * BuildSlaveSupport/ews-build/steps.py:
2083         * BuildSlaveSupport/ews-build/steps_unittest.py:
2084
2085 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2086
2087         [ews-build] Generate status-bubble hover-over messages
2088         https://bugs.webkit.org/show_bug.cgi?id=195680
2089
2090         Reviewed by Lucas Forschler.
2091
2092         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2093         (StatusBubble):
2094         (StatusBubble._build_bubble): Generate bubble['details_message'] which would be displayed
2095         on hover-over.
2096         (StatusBubble._iso_time):
2097         (StatusBubble._steps_messages): Returns status messages from steps to be displayed in
2098         hover-over message.
2099         (StatusBubble._most_recent_step_message): Returns status message from most recent step.
2100
2101 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2102
2103         [ews-app] Gracefully handle the case when state_string is None
2104         https://bugs.webkit.org/show_bug.cgi?id=195753
2105
2106         Reviewed by Lucas Forschler.
2107
2108         * BuildSlaveSupport/ews-app/ews/models/build.py:
2109         * BuildSlaveSupport/ews-app/ews/models/step.py:
2110
2111 2019-03-14  Aakash Jain  <aakash_jain@apple.com>
2112
2113         [ews-app] Status bubble display pending for currently running build step
2114         https://bugs.webkit.org/show_bug.cgi?id=195744
2115
2116         Reviewed by Lucas Forschler.
2117
2118         * BuildSlaveSupport/ews-build/events.py:
2119         (Events.stepStarted): If state_string is pending, replace it with step name.
2120
2121 2019-03-14  Chris Dumez  <cdumez@apple.com>
2122
2123         Add WebsitePolicy for the client to specify the device orientation & motion access policy
2124         https://bugs.webkit.org/show_bug.cgi?id=195750
2125
2126         Reviewed by Geoffrey Garen.
2127
2128         Add API test coverage.
2129
2130         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2131         (-[WebsitePoliciesDeviceOrientationDelegate initWithDeviceOrientationAccessPolicy:]):
2132         (-[WebsitePoliciesDeviceOrientationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2133         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2134
2135 2019-03-14  Chris Dumez  <cdumez@apple.com>
2136
2137         [PSON] Make sure the WebProcessCache is leverage when relaunching a process after termination
2138         https://bugs.webkit.org/show_bug.cgi?id=195747
2139
2140         Reviewed by Geoff Garen.
2141
2142         Add API test coverage.
2143
2144         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2145
2146 2019-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
2147
2148         Make -[_WKAttachment setFileWrapper:contentType:completion:] robust when given a nil completion handler
2149         https://bugs.webkit.org/show_bug.cgi?id=195725
2150         <rdar://problem/48545062>
2151
2152         Reviewed by Tim Horton.
2153
2154         Test that we don't crash when changing the file wrapper of an invalid attachment, if the given completion
2155         handler is nil.
2156
2157         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2158         (TestWebKitAPI::TEST):
2159
2160 2019-03-13  Sam Weinig  <sam@webkit.org>
2161
2162         Add utility function to allow easy reverse range-based iteration of a container
2163         https://bugs.webkit.org/show_bug.cgi?id=195542
2164
2165         Reviewed by Antti Koivisto.
2166
2167         * TestWebKitAPI/CMakeLists.txt:
2168         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2169         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2170         (TestWebKitAPI::TEST):
2171         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2172
2173 2019-03-13  Chris Dumez  <cdumez@apple.com>
2174
2175         Use a ServiceWorker process per registrable domain
2176         https://bugs.webkit.org/show_bug.cgi?id=195649
2177
2178         Reviewed by Youenn Fablet.
2179
2180         Update API test coverage.
2181
2182         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2183
2184 2019-03-13  Chris Dumez  <cdumez@apple.com>
2185
2186         REGRESSION(PSON, r240660): Navigation over process boundary is flashy when using Cmd-left/right arrow to navigate
2187         https://bugs.webkit.org/show_bug.cgi?id=195684
2188         <rdar://problem/48294714>
2189
2190         Reviewed by Antti Koivisto.
2191
2192         Add API test coverage.
2193
2194         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2195
2196 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2197
2198         [ews-app] Remove unused patch view
2199         https://bugs.webkit.org/show_bug.cgi?id=195669
2200
2201         Reviewed by Lucas Forschler.
2202
2203         * BuildSlaveSupport/ews-app/ews/urls.py:
2204         * BuildSlaveSupport/ews-app/ews/views/patch.py: Removed.
2205
2206 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2207
2208         [ews-app] Use Buildbot result code variables
2209         https://bugs.webkit.org/show_bug.cgi?id=195668
2210
2211         Reviewed by Alexey Proskuryakov.
2212
2213         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
2214         (Buildbot): Added Buildbot result code variables.
2215         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2216         (StatusBubble._build_bubble): Used Buildbot result code variables.
2217
2218 2019-03-13  Thibault Saunier  <tsaunier@igalia.com>
2219
2220         [Flatpak] Expand submodule recursively
2221         https://bugs.webkit.org/show_bug.cgi?id=195672
2222
2223         Building WPE with flatpak was impossible without that as it was raising an exception.
2224         Also update wpebackend-fdo to match what is built in jhbuild
2225
2226         Reviewed by Philippe Normand.
2227
2228         * flatpak/flatpakutils.py:
2229         (expand_submodules_recurse):
2230         (expand_manifest):
2231         * flatpak/org.webkit.WPEModules.yaml:
2232
2233 2019-03-13  Aakash Jain  <aakash_jain@apple.com>
2234
2235         [ews-app] status bubble should be hidden for certain builds
2236         https://bugs.webkit.org/show_bug.cgi?id=194597
2237
2238         Reviewed by Dewei Zhu.
2239
2240         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2241         (StatusBubble._build_bubble):
2242         (StatusBubble._should_show_bubble_for_build): Hide bubble for builds which were skipped
2243         because the patch didn't have relevant changes.
2244         (StatusBubble._should_show_bubble_for_queue): Hide bubbles for queues which are not deployed
2245         in production yet.
2246
2247 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
2248
2249         [Win] Fix a slew of simple clang-cl warnings.
2250         https://bugs.webkit.org/show_bug.cgi?id=195652
2251
2252         Reviewed by Don Olmstead.
2253
2254         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2255         (WTR::PlatformWebView::windowSnapshotImage): -Wunused-variable
2256
2257 2019-03-12  Justin Fan  <justin_fan@apple.com>
2258
2259         [Web GPU] Update GPURenderPipelineDescriptor and add GPUColorStateDescriptor.format
2260         https://bugs.webkit.org/show_bug.cgi?id=195518
2261         <rdar://problem/46322356>
2262
2263         Reviewed by Myles C. Maxfield.
2264
2265         * DumpRenderTree/DerivedSources-input.xcfilelist:
2266         * DumpRenderTree/DerivedSources-output.xcfilelist:
2267
2268 2019-03-12  Commit Queue  <commit-queue@webkit.org>
2269
2270         Unreviewed, rolling out r242825.
2271         https://bugs.webkit.org/show_bug.cgi?id=195648
2272
2273         "Broke webkitpy tests with my change to
2274         lldb_dump_class_layout.py" (Requested by rmorisset on
2275         #webkit).
2276
2277         Reverted changeset:
2278
2279         "Alter Tools/Scripts/dump-class-layout to be able to dump all
2280         classes with suspicious padding"
2281         https://bugs.webkit.org/show_bug.cgi?id=195573
2282         https://trac.webkit.org/changeset/242825
2283
2284 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2285
2286         [ews-build] Show status bubbles while the patch is waiting in queue
2287         https://bugs.webkit.org/show_bug.cgi?id=195618
2288
2289         Reviewed by Lucas Forschler.
2290
2291         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2292         (StatusBubble): Added ALL_QUEUES and ENABLED_QUEUES. Only certain queues are 
2293         enabled in initial deployment.
2294         (StatusBubble._build_bubble): Display bubble even when build hasn't started.
2295         (StatusBubble.get_latest_build_for_queue): Get latest build for a given queue.
2296         (StatusBubble.get_builds_for_queue): Get all builds for a given queue.
2297         (StatusBubble._should_show_bubble_for): Display bubble for only ENABLED_QUEUES for now.
2298         (StatusBubble._build_bubbles_for_patch):
2299
2300 2019-03-12  Robin Morisset  <rmorisset@apple.com>
2301
2302         Alter Tools/Scripts/dump-class-layout to be able to dump all classes with suspicious padding
2303         https://bugs.webkit.org/show_bug.cgi?id=195573
2304
2305         Reviewed by Simon Fraser.
2306
2307         Also modified the script so that when multiple types match a given name it shows them all and not arbitrarily pick one.
2308
2309         * Scripts/dump-class-layout:
2310         (main):
2311         * lldb/lldb_dump_class_layout.py:
2312         (ClassLayout.__init__):
2313         (ClassLayout._compute_padding_recursive):
2314         (LLDBDebuggerInstance.dump_layout_for_classname):
2315         (LLDBDebuggerInstance):
2316         (LLDBDebuggerInstance.dump_all_wasteful_layouts):
2317         (LLDBDebuggerInstance.layout_for_classname): Deleted.
2318
2319 2019-03-12  Chris Dumez  <cdumez@apple.com>
2320
2321         Device Orientation access permission should be denied unless explicitly granted by the client
2322         https://bugs.webkit.org/show_bug.cgi?id=195625
2323
2324         Reviewed by Youenn Fablet.
2325
2326         add API test coverage.
2327
2328         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2329         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm: Added.
2330         (-[DeviceOrientationMessageHandler userContentController:didReceiveScriptMessage:]):
2331         (-[DeviceOrientationPermissionUIDelegate initWithHandler:]):
2332         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2333         (runDeviceOrientationTest):
2334         (TEST):
2335         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2336         (-[WebsitePoliciesDeviceOrientationUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
2337
2338 2019-03-12  Jer Noble  <jer.noble@apple.com>
2339
2340         Flaky API Test TestWebKitAPI.WebKitLegacy.ScrollingDoesNotPauseMedia
2341         https://bugs.webkit.org/show_bug.cgi?id=195137
2342         <rdar://problem/48810307>
2343
2344         Reviewed by Eric Carlson.
2345
2346         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
2347         (TestWebKitAPI::TEST):
2348
2349 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2350
2351         [ews-build] Change urls from uat to production
2352         https://bugs.webkit.org/show_bug.cgi?id=195566
2353
2354         Reviewed by Lucas Forschler.
2355
2356         * BuildSlaveSupport/ews-app/ews/config.py:
2357         * BuildSlaveSupport/ews-build/events.py:
2358         * BuildSlaveSupport/ews-build/steps.py:
2359
2360 2019-03-12  Aakash Jain  <aakash_jain@apple.com>
2361
2362         [ews-build] change max_builds for local-worker to 1
2363         https://bugs.webkit.org/show_bug.cgi?id=195568
2364
2365         Reviewed by Lucas Forschler.
2366
2367         * BuildSlaveSupport/ews-build/loadConfig.py:
2368
2369 2019-03-12  Tim Horton  <timothy_horton@apple.com>
2370
2371         Fix the build
2372
2373         * TestRunnerShared/spi/PencilKitTestSPI.h:
2374         * TestWebKitAPI/ios/PencilKitTestSPI.h:
2375
2376 2019-03-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2377
2378         [WPE][GTK] Load events may occur in unexpected order when JS redirects page before subresource load finishes
2379         https://bugs.webkit.org/show_bug.cgi?id=194131
2380
2381         Reviewed by Michael Catanzaro.
2382
2383         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
2384         (uriChanged):
2385         (testUnfinishedSubresourceLoad):
2386         (serverCallback):
2387         (beforeAll):
2388
2389 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2390
2391         WTF::Expected should use std::addressof instead of operator&
2392         https://bugs.webkit.org/show_bug.cgi?id=195604
2393
2394         Reviewed by Myles Maxfield.
2395
2396         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2397         (TestWebKitAPI::Unique::Unique):
2398         (TestWebKitAPI::Unique::operator&):
2399         (TestWebKitAPI::TEST):
2400
2401 2019-03-11  Ross Kirsling  <ross.kirsling@sony.com>
2402
2403         Add Optional to Forward.h.
2404         https://bugs.webkit.org/show_bug.cgi?id=195586
2405
2406         Reviewed by Darin Adler.
2407
2408         * TestWebKitAPI/Tests/WebCore/ApduTest.cpp:
2409         * TestWebKitAPI/Tests/WebCore/FidoHidMessageTest.cpp:
2410         Remove unnecessary includes from headers.
2411
2412 2019-03-11  Simon Fraser  <simon.fraser@apple.com>
2413
2414         Add testing API to hit-test and scroll overflow scrollers
2415         https://bugs.webkit.org/show_bug.cgi?id=195278
2416
2417         Reviewed by Antti Koivisto.
2418         
2419         Add UIScriptController::immediateScrollElementAtContentPointToOffset() to enable
2420         testing of the view hit-testing code path, and immediate scrolling of overflow:scroll.
2421         
2422         Tests: scrollingcoordinator/ios/scroll-element-at-point.html
2423
2424         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2425         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2426         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2427         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2428         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2429         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2430         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2431         (WTR::enclosingScrollViewIncludingSelf):
2432         (WTR::UIScriptController::immediateScrollElementAtContentPointToOffset):
2433
2434 2019-03-11  Tim Horton  <timothy_horton@apple.com>
2435
2436         API test WebKit.RequestTextInputContext fails on iOS
2437         https://bugs.webkit.org/show_bug.cgi?id=195585
2438
2439         Reviewed by Wenson Hsieh and Simon Fraser.
2440
2441         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2442         (applyStyle):
2443         (TEST):
2444         Add a viewport, so that the coordinates match up on iOS.
2445         Scroll by moving the UIScrollView's contentOffset.
2446
2447 2019-03-11  Chris Dumez  <cdumez@apple.com>
2448
2449         Assert in WebPageProxy::suspendCurrentPageIfPossible()
2450         https://bugs.webkit.org/show_bug.cgi?id=195506
2451         <rdar://problem/48733477>
2452
2453         Reviewed by Alex Christensen.
2454
2455         Add API test coverage.
2456
2457         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2458
2459 2019-03-11  Shawn Roberts  <sroberts@apple.com>
2460
2461         Adding myself to contributors.json
2462
2463         Unreviewed, addming myself to contributors.json .
2464
2465         * Scripts/webkitpy/common/config/contributors.json:
2466
2467 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2468
2469         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2470         https://bugs.webkit.org/show_bug.cgi?id=195511
2471         <rdar://problem/44873269>
2472
2473         Reviewed by Darin Adler.
2474
2475         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2476         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2477         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2478         (TEST_F):
2479
2480 2019-03-11  Chris Dumez  <cdumez@apple.com>
2481
2482         Regression(r242664) WebKit.WebsitePoliciesDeviceOrientationEventEnabled API test is timing out
2483         https://bugs.webkit.org/show_bug.cgi?id=195561
2484
2485         Reviewed by Youenn Fablet.
2486
2487         Make sure the JS in the test requests for permission to receive device orientation events.
2488
2489         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2490
2491 2019-03-11  Youenn Fablet  <youenn@apple.com>
2492
2493         Allow storage quota increase by default in WTR
2494         https://bugs.webkit.org/show_bug.cgi?id=195541
2495
2496         Reviewed by Geoffrey Garen.
2497
2498         Allow storage quota increase by default in WTR.
2499         Move from testRunner.allowStorageQuotaIncrease to testRunner.setAllowStorageQuotaIncrease.
2500         Use this for tests that explicitly need cache increase.
2501
2502         Instead of increasing quota by 2, make sure the next request is
2503         granted by adding all given parameters.
2504
2505         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2506         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2507         (WTR::TestRunner::setAllowStorageQuotaIncrease):
2508         (WTR::TestRunner::allowCacheStorageQuotaIncrease): Deleted.
2509         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2510         * WebKitTestRunner/TestController.cpp:
2511         (WTR::TestController::setAllowStorageQuotaIncrease):
2512         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2513         * WebKitTestRunner/TestController.h:
2514         * WebKitTestRunner/TestInvocation.cpp:
2515         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2516         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2517         (WTR::TestController::cocoaResetStateToConsistentValues):
2518         (WTR::TestController::setAllowStorageQuotaIncrease):
2519         (WTR::TestController::allowCacheStorageQuotaIncrease): Deleted.
2520         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
2521         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2522
2523 2019-03-11  Xan Lopez  <xan@igalia.com>
2524
2525         [CMake] Build 32bit binaries on Linux/64bit when the --32-bit is passed to build-jsc
2526         https://bugs.webkit.org/show_bug.cgi?id=194147
2527
2528         Reviewed by Michael Saboff.
2529
2530         To make --32-bit work correctly on Linux/64bit we need to:
2531
2532         - Set FORCE_32BIT on, which will be read by CMake to set WTF_CPU
2533         correctly. Ideally we'd just redefine CMAKE_SYSTEM_PROCESSOR, but
2534         unfortunately CMake only allows us to do this during
2535         crosscompilation, which is overkill here.
2536         - Set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_ARCHITECTURE so that the
2537         pkg-config detection module uses the x86 .pc files instead of the
2538         x86_64 ones.
2539         - Set the -m32 flags for the compiler.
2540
2541         * Scripts/webkitdirs.pm:
2542         (generateBuildSystemFromCMakeProject):
2543
2544 2019-03-08  Dewei Zhu  <dewei_zhu@apple.com>
2545
2546         Add MotionMark-1.1 plan file for run-benchmark script.
2547         https://bugs.webkit.org/show_bug.cgi?id=195481
2548
2549         Rubber-stamped by Darin Adler.
2550
2551         Run-benchmark script should support MontionMark-1.1.
2552
2553         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark1.1.plan: Added.
2554
2555 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2556
2557         [ews-app] Add support for submit-to-ews url
2558         https://bugs.webkit.org/show_bug.cgi?id=195477
2559
2560         Reviewed by Lucas Forschler.
2561
2562         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2563         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
2564         * BuildSlaveSupport/ews-app/ews/templates/submittoews.html: Copied from QueueStatusServer/templates/submittoews.html.
2565         * BuildSlaveSupport/ews-app/ews/urls.py:
2566         * BuildSlaveSupport/ews-app/ews/views/submittoews.py: Added.
2567
2568 2019-03-11  Ryan Haddad  <ryanhaddad@apple.com>
2569
2570         Unreviewed, rolling out r242688, r242643, r242624.
2571
2572         Caused multiple layout test failures and crashes on iOS and macOS.
2573
2574         Reverted changeset:
2575
2576         "requestAnimationFrame should execute before the next frame"
2577         https://bugs.webkit.org/show_bug.cgi?id=177484
2578         https://trac.webkit.org/changeset/242624/webkit
2579
2580         * Tracing/SystemTracePoints.plist:
2581
2582 2019-03-11  John Wilander  <wilander@apple.com>
2583
2584         Resource Load Statistics: Make it possible exclude localhost from classification
2585         https://bugs.webkit.org/show_bug.cgi?id=195474
2586         <rdar://problem/47520577>
2587
2588         Reviewed by Brent Fulgham.
2589
2590         This patch allows for localhost to be excluded from classification and
2591         treatment as a prevalent resource.
2592
2593         The WebKit Tools change adds a new function called
2594         testRunner.setStatisticsIsRunningTest() which can be used to control this
2595         behavior.
2596
2597         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2598         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2599         (WTR::TestRunner::setStatisticsIsRunningTest):
2600         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2601         * WebKitTestRunner/TestController.cpp:
2602         (WTR::TestController::setStatisticsIsRunningTest):
2603         * WebKitTestRunner/TestController.h:
2604         * WebKitTestRunner/TestInvocation.cpp:
2605         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2606
2607 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2608
2609         [ews-build] Disable waterfall and console view for ews-build.webkit.org
2610         https://bugs.webkit.org/show_bug.cgi?id=195560
2611
2612         Reviewed by Lucas Forschler.
2613
2614         * BuildSlaveSupport/ews-build/master.cfg:
2615
2616 2019-03-11  Alex Christensen  <achristensen@webkit.org>
2617
2618         Unreviewed, rolling out r242698.
2619
2620         API test crashes on bots.
2621
2622         Reverted changeset:
2623
2624         "Add a WKContentRuleList variant that uses copied memory
2625         instead of mmap'd shared memory for class A containerized
2626         apps"
2627         https://bugs.webkit.org/show_bug.cgi?id=195511
2628         https://trac.webkit.org/changeset/242698
2629
2630 2019-03-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2631
2632         [WPE] Enable web process sandbox
2633         https://bugs.webkit.org/show_bug.cgi?id=195169
2634
2635         Reviewed by Daniel Bates.
2636
2637         * wpe/install-dependencies:
2638         * wpe/jhbuild.modules:
2639
2640 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2641
2642         [ews-app] Use port 17000 for worker communication
2643         https://bugs.webkit.org/show_bug.cgi?id=195558
2644
2645         Reviewed by Lucas Forschler.
2646
2647         * BuildSlaveSupport/ews-build/master.cfg:
2648
2649 2019-03-11  Aakash Jain  <aakash_jain@apple.com>
2650
2651         [ews-build] unit-tests fail when passwords.json is missing
2652         https://bugs.webkit.org/show_bug.cgi?id=195557
2653
2654         Reviewed by Lucas Forschler.
2655
2656         * BuildSlaveSupport/ews-build/loadConfig.py:
2657         (loadBuilderConfig):
2658         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2659         (ConfigDotJSONTest.test_configuration):
2660         * BuildSlaveSupport/ews-build/master.cfg:
2661
2662 2019-03-11  Truitt Savell  <tsavell@apple.com>
2663
2664         Unreviewed, rolling out r242702.
2665
2666         Broke High Sierra builders.
2667
2668         Reverted changeset:
2669
2670         "Add utility function to allow easy reverse range-based
2671         iteration of a container"
2672         https://bugs.webkit.org/show_bug.cgi?id=195542
2673         https://trac.webkit.org/changeset/242702
2674
2675 2019-03-11  Sam Weinig  <sam@webkit.org>
2676
2677         Add utility function to allow easy reverse range-based iteration of a container
2678         https://bugs.webkit.org/show_bug.cgi?id=195542
2679
2680         Reviewed by Antti Koivisto.
2681
2682         * TestWebKitAPI/CMakeLists.txt:
2683         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2684         * TestWebKitAPI/Tests/WTF/IteratorRange.cpp: Added.
2685         (TestWebKitAPI::TEST):
2686         Add test to ensure WTF::makeReversedRange() works correctly and uses the correct types.
2687
2688 2019-03-10  Alex Christensen  <achristensen@webkit.org>
2689
2690         Add a WKContentRuleList variant that uses copied memory instead of mmap'd shared memory for class A containerized apps
2691         https://bugs.webkit.org/show_bug.cgi?id=195511
2692         <rdar://problem/44873269>
2693
2694         Reviewed by Darin Adler.
2695
2696         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
2697         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]):
2698         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]):
2699         (TEST_F):
2700
2701 2019-03-10  Tim Horton  <timothy_horton@apple.com>
2702
2703         Add SPI to retrieve the set of text inputs in a given rect, and later focus one
2704         https://bugs.webkit.org/show_bug.cgi?id=195499
2705
2706         Reviewed by Darin Adler.
2707
2708         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2709         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm: Added.
2710         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]):
2711         (-[WKWebView synchronouslyFocusTextInputContext:]):
2712         (applyStyle):
2713         (applyIframe):
2714         (TEST):
2715         Add some tests for this SPI.
2716
2717 2019-03-10  Yusuke Suzuki <utatane.tea@gmail.com>
2718
2719         [WTF] Align assumption in RunLoopWin to the other platform's RunLoop
2720         https://bugs.webkit.org/show_bug.cgi?id=181151
2721
2722         Reviewed by Don Olmstead.
2723
2724         * TestWebKitAPI/CMakeLists.txt:
2725         * TestWebKitAPI/PlatformWin.cmake:
2726         Enable TestWTF RunLoop tests in all platforms.
2727
2728         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2729         (TestWebKitAPI::DerivedOneShotTimer::DerivedOneShotTimer):
2730         (TestWebKitAPI::DerivedOneShotTimer::fired):
2731         (TestWebKitAPI::TEST):
2732         Only a few platforms support nested RunLoop.
2733
2734         (TestWebKitAPI::DerivedRepeatingTimer::DerivedRepeatingTimer):
2735         (TestWebKitAPI::DerivedRepeatingTimer::fired):
2736
2737 2019-03-10  David Quesada  <david_quesada@apple.com>
2738
2739         ASSERT(m_downloads.isEmpty()) fails in DownloadProxyMap::~DownloadProxyMap()
2740         https://bugs.webkit.org/show_bug.cgi?id=152480
2741
2742         Reviewed by Chris Dumez.
2743
2744         Add a unit test based on Daniel Bates's test case that starts a download, ensures
2745         there are no additional references to the process pool besides the one held by
2746         the download, waits for the download to finish (in the sense that the
2747         DownloadProxyMap is done tracking the DownloadProxy), and doesn't crash. For good
2748         measure, also check that the process pool has been deallocated at the end of the
2749         test. The test wouldn't be meaningful if the process pool were still alive.
2750
2751         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2752         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
2753         (-[WaitUntilDownloadCanceledDelegate _downloadDidCancel:]):
2754             The download will be canceled because the delegate does not implement the
2755             method to decide the download's destination, so this is where we know the
2756             DownloadProxyMap is done with the DownloadProxy.
2757         (TEST):
2758
2759 2019-03-08  Chris Dumez  <cdumez@apple.com>
2760
2761         Add support for Device Orientation / Motion permission API
2762         https://bugs.webkit.org/show_bug.cgi?id=195329
2763         <rdar://problem/47645367>
2764
2765         Reviewed by Geoffrey Garen.
2766
2767         Add test infrastructure to help test the Device Orientation / Motion permission API.
2768
2769         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2770         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2771         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
2772         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2773         * WebKitTestRunner/TestController.cpp:
2774         (WTR::shouldAllowDeviceOrientationAndMotionAccess):
2775         (WTR::TestController::createWebViewWithOptions):
2776         (WTR::TestController::resetStateToConsistentValues):
2777         (WTR::TestController::handleDeviceOrientationAndMotionAccessRequest):
2778         * WebKitTestRunner/TestController.h:
2779         (WTR::TestController::setShouldAllowDeviceOrientationAndMotionAccess):
2780         * WebKitTestRunner/TestInvocation.cpp:
2781         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2782
2783 2019-03-08  Saam barati  <sbarati@apple.com>
2784
2785         Add a compare-results script to compare benchmark results
2786         https://bugs.webkit.org/show_bug.cgi?id=195486
2787         <rdar://problem/48723397>
2788
2789         Reviewed by Geoffrey Garen.
2790
2791         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
2792         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
2793         to extend it to learn about our other benchmarks.
2794
2795         * Scripts/compare-results: Added.
2796         (readJSONFile):
2797         (detectJetStream2):
2798         (JetStream2Results):
2799         (detectSpeedometer2):
2800         (Speedometer2Results):
2801         (detectPLT5):
2802         (PLT5Results):
2803         (detectBenchmark):
2804         (biggerIsBetter):
2805         (ttest):
2806         (getOptions):
2807         (main):
2808
2809 2019-03-08  Stephanie Lewis  <slewis@apple.com>
2810
2811         Ensure old tab state is cleared between iterations of run-benchmark
2812         https://bugs.webkit.org/show_bug.cgi?id=195393
2813         <rdar://problem/46885583>
2814
2815         Reviewed by Dewei Zhu.
2816
2817         a) ensure the default to restore state is not set
2818         b) terminate Safari correctly
2819         c) Set the system default to ignore Persistent State in Safari
2820
2821         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2822         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
2823         (OSXBrowserDriver.prepare_env): 
2824         (OSXBrowserDriver.restore_env):
2825         (OSXBrowserDriver.close_browsers):
2826         (OSXBrowserDriver._terminate_processes):
2827         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
2828         (OSXChromeDriver):
2829         (OSXChromeCanaryDriver):
2830         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
2831         (OSXFirefoxDriver):
2832         (OSXFirefoxNightlyDriver):
2833         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
2834         (OSXSafariDriver):
2835         (OSXSafariDriver.prepare_env):
2836
2837 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
2838
2839         [GTK] Several InputMethodFilter tests are failing
2840         https://bugs.webkit.org/show_bug.cgi?id=195408
2841
2842         Reviewed by Carlos Garcia Campos.
2843
2844         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
2845         Regressed in r241751.
2846         Hexadecimal values of keycodes are expressed now in upper letters.
2847         Composited characters should be cast to UTF8 strings.
2848
2849         (TestWebKitAPI::TEST):
2850
2851 2019-03-07  Tomas Popela  <tpopela@redhat.com>
2852
2853         [GTK] Make Tools/gtkdoc python3 compatible
2854         https://bugs.webkit.org/show_bug.cgi?id=195359
2855
2856         Reviewed by Carlos Garcia Campos.
2857
2858         * gtkdoc/generate-gtkdoc:
2859         ConfigParser was reworked in Python 3.2 so we have adapt the code to
2860         work with Python 2 and 3.
2861         (get_gtkdoc_module_paths):
2862         The iteritems() was removed in Python 3, so let's use items() that's
2863         available in Python 2 and 3.
2864         (get_generator_for_config):
2865         * gtkdoc/gtkdoc.py:
2866         (GTKDoc._run_command):
2867         The sys.stdout.write() is expecting str in Python 3 and not bytes
2868         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
2869         for passing the bytes there.
2870
2871 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
2872
2873         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2874         https://bugs.webkit.org/show_bug.cgi?id=195346
2875         <rdar://problem/48667048>
2876
2877         Unreviewed build fix for clang-cl.
2878
2879         * DumpRenderTree/win/DumpRenderTree.cpp:
2880         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
2881
2882 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2883
2884         requestAnimationFrame should execute before the next frame
2885         https://bugs.webkit.org/show_bug.cgi?id=177484
2886
2887         Reviewed by Simon Fraser.
2888
2889         Add trace points for the page RenderingUpdate.
2890
2891         * Tracing/SystemTracePoints.plist:
2892
2893 2019-03-07  Zalan Bujtas  <zalan@apple.com>
2894
2895         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
2896         https://bugs.webkit.org/show_bug.cgi?id=195353
2897         <rdar://problem/48626394>
2898
2899         Reviewed by Simon Fraser.
2900
2901         * WebKitTestRunner/ios/TestControllerIOS.mm:
2902         (WTR::TestController::platformResetPreferencesToConsistentValues):
2903
2904 2019-03-07  John Wilander  <wilander@apple.com>
2905
2906         Resource Load Statistics: Make it possible to purge only script-accessible cookies
2907         https://bugs.webkit.org/show_bug.cgi?id=195383
2908         <rdar://problem/48570136>
2909
2910         Reviewed by Brent Fulgham.
2911
2912         This patch adds test infrastructure to purge only script-accessible cookies,
2913         including a new testRunner function called statisticsDeleteCookiesForHost().git a
2914
2915         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2916         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2917         (WTR::TestRunner::statisticsDeleteCookiesForHost):
2918         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2919         * WebKitTestRunner/TestController.cpp:
2920         (WTR::TestController::statisticsDeleteCookiesForHost):
2921         * WebKitTestRunner/TestController.h:
2922         * WebKitTestRunner/TestInvocation.cpp:
2923         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2924
2925 2019-03-07  Commit Queue  <commit-queue@webkit.org>
2926
2927         Unreviewed, rolling out r242354.
2928         https://bugs.webkit.org/show_bug.cgi?id=195402
2929
2930         breaks layout tests in all configurations (Requested by
2931         zdobersek on #webkit).
2932
2933         Reverted changeset:
2934
2935         "[WPE] Enable web process sandbox"
2936         https://bugs.webkit.org/show_bug.cgi?id=195169
2937         https://trac.webkit.org/changeset/242354
2938
2939 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
2940
2941         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
2942         https://bugs.webkit.org/show_bug.cgi?id=195346
2943
2944         Reviewed by Fujii Hironori.
2945
2946         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
2947         (TestWebKitAPI::TEST):
2948         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
2949
2950         * DumpRenderTree/win/DumpRenderTree.cpp:
2951         (findFontFallback):
2952         (addFontFallbackIfPresent):
2953         (removeFontFallbackIfPresent):
2954         (main):
2955         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
2956         (TestWebKitAPI::Util::moduleDirectory):
2957         (TestWebKitAPI::Util::createInjectedBundlePath):
2958         Use wchar helpers as needed.
2959
2960 2019-03-06  Rob Buis  <rbuis@igalia.com>
2961
2962         Consider supporting the `referrerpolicy` attribute.
2963         https://bugs.webkit.org/show_bug.cgi?id=179053
2964
2965         Reviewed by Darin Adler.
2966
2967         Add a runtime flag for referrerpolicy attribute.
2968
2969         * DumpRenderTree/mac/DumpRenderTree.mm:
2970         (enableExperimentalFeatures):
2971
2972 2019-03-05  Daniel Bates  <dabates@apple.com>
2973
2974         Update expected API test result following r242379
2975         (https://bugs.webkit.org/show_bug.cgi?id=195125)
2976
2977         Update expected x-coordinate of selection rect now that the left padding of
2978         a textarea is sized in ems (so dependent on the font size) just like the left
2979         padding of a text field.
2980
2981         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2982         (TestWebKitAPI::TEST):
2983
2984 2019-03-05  David Quesada  <david_quesada@apple.com>
2985
2986         [WK2] It should be possible to follow links with 'download' attributes
2987         https://bugs.webkit.org/show_bug.cgi?id=195145
2988         rdar://problem/48462642
2989
2990         Reviewed by Alex Christensen.
2991
2992         Add a unit test to verify that activating links with 'download' attributes now
2993         navigates to the linked resource, rather than starts downloading it. Add another
2994         to verify that it is still possible to explicitly download the link via the
2995         'Download' navigation action policy.
2996
2997         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2998         (-[DownloadAttributeTestDelegate init]):
2999         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
3000         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
3001         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
3002         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
3003         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3004         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
3005         (TEST):
3006         * WebKitTestRunner/TestController.cpp:
3007         (WTR::TestController::decidePolicyForNavigationAction):
3008         * WebKitTestRunner/TestController.h:
3009
3010 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
3011
3012         [Curl] Implement Cookie Accept Policy.
3013         https://bugs.webkit.org/show_bug.cgi?id=191645
3014
3015         Reviewed by Fujii Hironori.
3016
3017         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3018         (TestWebKitAPI::Curl::TEST_F):
3019
3020 2019-03-05  Youenn Fablet  <youenn@apple.com>
3021
3022         Rename requestCacheStorageSpace to requestStorageSpace
3023         https://bugs.webkit.org/show_bug.cgi?id=195282
3024
3025         Reviewed by Chris Dumez.
3026
3027         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
3028         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
3029         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
3030
3031 2019-03-05  Brady Eidson  <beidson@apple.com>
3032
3033         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
3034         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
3035
3036         Reviewed by Tim Horton.
3037
3038         Loading a file: URL into a WKWebView and then loading another file: url from a completely
3039         different directory into that same WKWebView should work.
3040
3041         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3042         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
3043
3044 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
3045
3046         Add WeakHashSet
3047         https://bugs.webkit.org/show_bug.cgi?id=195152
3048
3049         Reviewed by Antti Koivisto.
3050
3051         Added tests for WeakHashSet.
3052
3053         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
3054         (TestWebKitAPI::Base::Base): Moved.
3055         (TestWebKitAPI::Derived::foo): Moved.
3056         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
3057         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
3058         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
3059         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
3060
3061 2019-03-04  Chris Dumez  <cdumez@apple.com>
3062
3063         Do not share WebProcesses between private and regular sessions
3064         https://bugs.webkit.org/show_bug.cgi?id=195189
3065         <rdar://problem/48421064>
3066
3067         Reviewed by Alex Christensen.
3068
3069         Add API test coverage.
3070
3071         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3072         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3073
3074 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
3075
3076         [WPE] Enable web process sandbox
3077         https://bugs.webkit.org/show_bug.cgi?id=195169
3078
3079         Reviewed by Daniel Bates.
3080
3081         * wpe/install-dependencies:
3082         * wpe/jhbuild.modules:
3083
3084 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
3085
3086         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
3087         https://bugs.webkit.org/show_bug.cgi?id=195206
3088
3089         Reviewed by Žan Doberšek.
3090
3091         Add a new test case.
3092
3093         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3094         (testJSCClass):
3095
3096 2019-03-04  Charlie Turner  <cturner@igalia.com>
3097
3098         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
3099         https://bugs.webkit.org/show_bug.cgi?id=194898
3100
3101         Reviewed by Žan Doberšek.
3102
3103         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
3104         a GCC extension that permits arithmetic on void* pointer. Inline
3105         the macro until this issue is fixed upstream.
3106
3107 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3108
3109         Rid the world of WK_API_ENABLED
3110         https://bugs.webkit.org/show_bug.cgi?id=195263
3111
3112         Reviewed by Dan Bernstein.
3113
3114         List of changed files elided because it's useless.
3115
3116 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
3117
3118         Unreviewed follow-up to r242292.
3119
3120         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
3121
3122         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3123         (TestWebKitAPI::testStrip): Renamed from strip.
3124         (TestWebKitAPI::TEST):
3125
3126 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
3127
3128         Unreviewed, remove accidentally-committed URLHelpers.cpp test
3129
3130         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
3131         and bug #194272 for details.
3132
3133         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
3134
3135 2019-03-03  Tim Horton  <timothy_horton@apple.com>
3136
3137         Remove some more unused 32-bit code
3138         https://bugs.webkit.org/show_bug.cgi?id=195255
3139
3140         Reviewed by Darin Adler.
3141
3142         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3143         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
3144         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3145         (NPP_New):
3146         (NPP_HandleEvent):
3147         (handleEventCarbon): Deleted.
3148
3149 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
3150
3151         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
3152
3153         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3154         (TestWebKitAPI::TEST):
3155
3156 2019-03-01  Darin Adler  <darin@apple.com>
3157
3158         Finish removing String::format
3159         https://bugs.webkit.org/show_bug.cgi?id=194893
3160
3161         Reviewed by Daniel Bates.
3162 '
3163         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
3164
3165 2019-03-01  Alex Christensen  <achristensen@webkit.org>
3166
3167         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
3168         https://bugs.webkit.org/show_bug.cgi?id=195229
3169         <rdar://problem/48520362>
3170
3171         Reviewed by Chris Dumez.
3172
3173         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3174         (TEST):
3175
3176 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
3177
3178         Add a system trace scope for event region building
3179         https://bugs.webkit.org/show_bug.cgi?id=195226
3180
3181         Reviewed by Jon Lee.
3182
3183         This trace scope measures the time spend converting element rects into Region objects,
3184         which can be large on some pages.
3185
3186         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
3187
3188         * Tracing/SystemTracePoints.plist:
3189
3190 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
3191
3192         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
3193         https://bugs.webkit.org/show_bug.cgi?id=194612
3194
3195         Reviewed by Alex Christensen.
3196
3197         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
3198         Just test the new string-processing function and don't touch the actual environment.
3199         (Test cases are all as before, but based on operator== instead of strcmp.)
3200
3201 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
3202
3203         [ews-app] Update primary keys for handling multiple Buildbot instances
3204         https://bugs.webkit.org/show_bug.cgi?id=195120
3205
3206         Reviewed by Stephanie Lewis.
3207
3208         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
3209         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
3210         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
3211
3212         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
3213         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
3214         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
3215         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
3216         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
3217         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
3218
3219 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
3220
3221         [WinCairo] Enable service worker
3222         https://bugs.webkit.org/show_bug.cgi?id=188318
3223
3224         Reviewed by Youenn Fablet.
3225
3226         * DumpRenderTree/DumpRenderTreePrefix.h:
3227         * TestWebKitAPI/PlatformWin.cmake:
3228         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
3229         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
3230         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3231
3232 2019-03-01  Justin Fan  <justin_fan@apple.com>
3233
3234         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
3235         https://bugs.webkit.org/show_bug.cgi?id=195191
3236
3237         Rubber-stamped by Dean Jackson.
3238
3239         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
3240
3241         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3242
3243 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
3244
3245         Unreviewed, fix lldb webkitpy tests
3246         https://bugs.webkit.org/show_bug.cgi?id=194375
3247
3248         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
3249
3250         * lldb/lldb_webkit.py:
3251         (WTFStringImplProvider.is_8bit):
3252
3253 2019-02-28  David Quesada  <david_quesada@apple.com>
3254
3255         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
3256         https://bugs.webkit.org/show_bug.cgi?id=195121
3257         rdar://problem/48450302
3258
3259         Reviewed by Alex Christensen.
3260
3261         Add API tests for -WKNavigationAction._shouldPerformDownload in various
3262         configurations where the 'download' attribute is absent, blank, or populated
3263         with a filename, and where the anchor element is same-origin or cross-origin
3264         (meaning the 'download' attribute shouldn't be honored).
3265
3266         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3267         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
3268         (-[NavigationActionTestDelegate init]):
3269         (-[NavigationActionTestDelegate navigationAction]):
3270         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
3271         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
3272         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3273         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
3274         (TEST):
3275
3276 2019-02-28  Antoine Quint  <graouts@apple.com>
3277
3278         Enable the Pointer Events runtime flag by default
3279         https://bugs.webkit.org/show_bug.cgi?id=195156
3280
3281         Reviewed by Dean Jackson.
3282
3283         * DumpRenderTree/mac/DumpRenderTree.mm:
3284         (enableExperimentalFeatures):
3285
3286 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3287
3288         Several PasteImage API tests are flaky
3289         https://bugs.webkit.org/show_bug.cgi?id=195160
3290
3291         Reviewed by Tim Horton.
3292
3293         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
3294         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
3295         listening for a "load" event after image load is already complete.
3296
3297         To address this, make these tests first register a "load" event handler, then run script to insert an image
3298         element into the document, and finally wait until the load event is observed before checking image size.
3299
3300         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
3301
3302 2019-02-28  Chris Dumez  <cdumez@apple.com>
3303
3304         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
3305         https://bugs.webkit.org/show_bug.cgi?id=195107
3306
3307         Reviewed by Alex Christensen.
3308
3309         Give some time for the zoom level to get restored.
3310
3311         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3312
3313 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
3314
3315         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
3316         https://bugs.webkit.org/show_bug.cgi?id=194958
3317
3318         Reviewed by Geoffrey Garen.
3319
3320         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
3321         (TEST):
3322
3323 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
3324
3325         [ews-app] Update method to save build to handle builder_display_name
3326         https://bugs.webkit.org/show_bug.cgi?id=195047
3327
3328         Reviewed by Dewei Zhu.
3329
3330         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
3331         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
3332
3333 2019-02-28  Justin Fan  <justin_fan@apple.com>
3334
3335         [Web GPU] Enable Web GPU only on 64-bit
3336         https://bugs.webkit.org/show_bug.cgi?id=195139
3337
3338         Because Metal is only supported on 64 bit apps.
3339
3340         Unreviewed build fix.
3341
3342         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3343
3344 2019-02-27  Youenn Fablet  <youenn@apple.com>
3345
3346         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
3347         https://bugs.webkit.org/show_bug.cgi?id=194959
3348
3349         Reviewed by Chris Dumez.
3350
3351         Spin loop until getting the condition to remove flakiness.
3352
3353         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3354
3355 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
3356
3357         [ews-build] Buildbot should include builder_display_name in the build events
3358         https://bugs.webkit.org/show_bug.cgi?id=195045
3359
3360         Reviewed by Dewei Zhu.
3361
3362         * BuildSlaveSupport/ews-build/events.py:
3363         (Events.buildStarted): Included builder_display_name in event data. Also renamed
3364         buildername to builder_name to be consistent in naming style.
3365         (Events.buildFinished): Ditto.
3366
3367 2019-02-27  Chris Dumez  <cdumez@apple.com>
3368
3369         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
3370         https://bugs.webkit.org/show_bug.cgi?id=194480
3371
3372         Reviewed by Brady Eidson.
3373
3374         Update existing API test to make it more likely to reproduce the issue.
3375
3376         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3377
3378 2019-02-27  Brady Eidson  <beidson@apple.com>
3379
3380         Universal links from Google search results pages don't open the app.
3381         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
3382
3383         Reviewed by Geoffrey Garen.
3384
3385         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
3386         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3387         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3388         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3389
3390 2019-02-27  Chris Dumez  <cdumez@apple.com>
3391
3392         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
3393         https://bugs.webkit.org/show_bug.cgi?id=195102
3394
3395         Reviewed by Geoffrey Garen.
3396
3397         If the number of processes is not yet what we expect, wait a bit and check again to give
3398         processes some time to exit.
3399
3400         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3401
3402 2019-02-27  Chris Dumez  <cdumez@apple.com>
3403
3404         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
3405         https://bugs.webkit.org/show_bug.cgi?id=194545
3406
3407         Reviewed by Brady Eidson.
3408
3409         Make sure the test navigates forward and then back only once. Previously, navigating
3410         back would trigger a navigation again in a timer.
3411
3412         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3413
3414 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
3415
3416         High Sierra Debug JSC test queue should use faster hardware
3417         https://bugs.webkit.org/show_bug.cgi?id=194603
3418
3419         Rubber-stamped by Alexey Proskuryakov.
3420
3421         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
3422
3423         * BuildSlaveSupport/build.webkit.org-config/config.json:
3424         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3425         (BubbleQueueServer):
3426         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3427         (WebKitBuildbot):
3428         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3429         * QueueStatusServer/config/queues.py:
3430         * Scripts/webkitpy/common/config/ews.json:
3431         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3432         (test_ews_name):
3433
3434 2019-02-27  John Wilander  <wilander@apple.com>
3435
3436         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
3437         https://bugs.webkit.org/show_bug.cgi?id=195071
3438         <rdar://problem/48417690>
3439
3440         Reviewed by Alex Christensen and Brent Fulgham.
3441
3442         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3443         (TestWebKitAPI::createURL):
3444             Convenience function.
3445         (TestWebKitAPI::TEST):
3446             WebCore::AdClickAttribution now takes a URL when creating Source and
3447             Destination.
3448         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
3449         (TestWebKitAPI::TEST):
3450             WebCore::AdClickAttribution now takes a URL when creating Source and
3451             Destination.
3452
3453 2019-02-27  Antoine Quint  <graouts@apple.com>
3454
3455         Support Pointer Events on macOS
3456         https://bugs.webkit.org/show_bug.cgi?id=195008
3457         <rdar://problem/47454419>
3458
3459         Reviewed by Dean Jackson.
3460
3461         * DumpRenderTree/mac/DumpRenderTree.mm:
3462         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
3463         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3464
3465 2019-02-26  Mark Lam  <mark.lam@apple.com>
3466
3467         Remove remaining poisoning code.
3468         https://bugs.webkit.org/show_bug.cgi?id=194138
3469
3470         Reviewed by Saam Barati.
3471
3472         * TestWebKitAPI/CMakeLists.txt:
3473         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3474         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
3475         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
3476         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
3477         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
3478         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
3479         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
3480
3481 2019-02-26  Alex Christensen  <achristensen@webkit.org>
3482
3483         Move ephemeral local storage from WebProcess to UIProcess
3484         https://bugs.webkit.org/show_bug.cgi?id=195074
3485         <rdar://problem/47937975>
3486
3487         Reviewed by Geoff Garen.
3488
3489         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3490
3491 2019-02-20  Jer Noble  <jer.noble@apple.com>
3492
3493         [Cocoa] Media elements will restart network buffering just before suspending
3494         https://bugs.webkit.org/show_bug.cgi?id=193691
3495
3496         Reviewed by Eric Carlson.
3497
3498         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3499         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
3500         (TEST):
3501
3502 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
3503
3504         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
3505         https://bugs.webkit.org/show_bug.cgi?id=191652
3506
3507         Reviewed by Alex Christensen.
3508
3509         Fix WinCairo MiniBrowser behavior of authentication dialog.
3510
3511         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3512         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3513
3514 2019-02-26  Youenn Fablet  <youenn@apple.com>
3515
3516         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
3517         https://bugs.webkit.org/show_bug.cgi?id=195028
3518         <rdar://problem/48243733>
3519
3520         Reviewed by Eric Carlson.
3521
3522         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3523
3524 2019-02-26  Philippe Normand  <pnormand@igalia.com>
3525
3526         [WPE] Add API for webview background color configuration
3527         https://bugs.webkit.org/show_bug.cgi?id=192305
3528
3529         Reviewed by Michael Catanzaro.
3530
3531         * MiniBrowser/wpe/main.cpp:
3532         (main): Add a new option to configure the webview background
3533         color. Example: --bg-color=transparent.
3534         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
3535         (testWebViewBackgroundColor): Enable background color API tests for WPE.
3536         (beforeAll): Ditto.
3537
3538 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
3539
3540         scalableNativeWebpageParameters() is not preserved on new page navigation.
3541         https://bugs.webkit.org/show_bug.cgi?id=194892
3542         <rdar://problem/47538280>
3543
3544         Reviewed by Wenson Hsieh.
3545         
3546         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
3547
3548         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3549         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3550         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3551         (WTR::UIScriptController::allowsViewportShrinkToFit):
3552         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3553         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3554         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3555         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3556         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3557         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
3558
3559 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3560
3561         [ews-app] Add model for handling multiple Buildbot instances
3562         https://bugs.webkit.org/show_bug.cgi?id=194863
3563
3564         Reviewed by Stephanie Lewis.
3565
3566         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
3567
3568 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
3569
3570         [ews-app] Remove BuilderMapping table
3571         https://bugs.webkit.org/show_bug.cgi?id=194961
3572
3573         Reviewed by Stephanie Lewis.
3574
3575         Store builder name directly in build table, instead of having a separate
3576         table for it.
3577
3578         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
3579         * BuildSlaveSupport/ews-app/ews/models/build.py:
3580         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
3581         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3582
3583 2019-02-25  John Wilander  <wilander@apple.com>
3584
3585         Introduce and adopt new class RegistrableDomain for eTLD+1
3586         https://bugs.webkit.org/show_bug.cgi?id=194791
3587         <rdar://problem/48179240>
3588
3589         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
3590
3591         This patch adds an API test and replaces two instances of
3592         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
3593
3594         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3595         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
3596         (TestWebKitAPI::TEST):
3597             Changed two strings to make sure the registrable domains are still considered
3598             invalid and pass the test.
3599         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
3600         (TestWebKitAPI::TEST):
3601         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3602         (WTR::InjectedBundle::didReceiveMessageToPage):
3603
3604 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
3605
3606         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
3607         https://bugs.webkit.org/show_bug.cgi?id=195001
3608
3609         Reviewed by Carlos Garcia Campos.
3610
3611         API version 1.0 always includes the functionality previously guarded with
3612         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
3613         unconditionally.
3614
3615         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
3616         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
3617         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
3618         (WebViewTest::showInWindow): Ditto.
3619         (WebViewTest::hideView): Ditto.
3620         * wpe/backends/HeadlessViewBackend.cpp:
3621         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
3622         * wpe/backends/ViewBackend.cpp:
3623         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
3624         * wpe/backends/WindowViewBackend.cpp:
3625         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
3626         WPE_BACKEND_CHECK_VERSION().
3627         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
3628
3629 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
3630
3631         [Flatpak] Add support for flatpak > 1.1.2
3632         https://bugs.webkit.org/show_bug.cgi?id=194088
3633
3634         Flatpak 1.2 is now out so we need to support that
3635         version now.
3636
3637         Reviewed by Michael Catanzaro.
3638
3639         * flatpak/flatpakutils.py:
3640         (check_flatpak):
3641         (FlatpakPackages.__init__):
3642         (FlatpakPackages.__detect_packages):
3643         (FlatpakPackages.__detect_packages.in):
3644         (FlatpakRepos.update):
3645
3646 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
3647
3648         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
3649         https://bugs.webkit.org/show_bug.cgi?id=194998
3650
3651         Reviewed by Carlos Garcia Campos.
3652
3653         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
3654         to a Git checkout and using the latest commit containing various fixes
3655         and improvements.
3656
3657 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3658
3659         [WPE][GTK] Remove user agent quirk for washingtonpost.com
3660         https://bugs.webkit.org/show_bug.cgi?id=194981
3661
3662         Reviewed by Žan Doberšek.
3663
3664         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3665         (TestWebKitAPI::TEST):
3666
3667 2019-02-23  Keith Miller  <keith_miller@apple.com>
3668
3669         Add new mac target numbers
3670         https://bugs.webkit.org/show_bug.cgi?id=194955
3671
3672         Reviewed by Tim Horton.
3673
3674         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3675         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3676         * MiniBrowser/Configurations/Base.xcconfig:
3677         * TestWebKitAPI/Configurations/Base.xcconfig:
3678         * WebKitTestRunner/Configurations/Base.xcconfig:
3679
3680 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
3681
3682         [WinCairo] Enable wk1/wk2 suffix for platform search path.
3683         https://bugs.webkit.org/show_bug.cgi?id=194846
3684
3685         Reviewed by Don Olmstead.
3686
3687         Added _search_paths() and _port_specific_expectations_files() for
3688         WinCairoPort.
3689
3690         * Scripts/webkitpy/port/win.py:
3691         (WinCairoPort.default_baseline_search_path):
3692         (WinCairoPort):
3693         (WinCairoPort._port_specific_expectations_files):
3694         (WinCairoPort._search_paths):
3695
3696 2019-02-22  Tim Horton  <timothy_horton@apple.com>
3697
3698         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
3699         https://bugs.webkit.org/show_bug.cgi?id=194963
3700
3701         Reviewed by Dean Jackson.