[Flatpak] Implement icecream and ccache support
[WebKit-https.git] / Tools / ChangeLog
1 2018-10-02  Thibault Saunier  <tsaunier@igalia.com>
2
3         [Flatpak] Implement icecream and ccache support
4         https://bugs.webkit.org/show_bug.cgi?id=190146
5
6         Reviewed by Alejandro G. Castro.
7
8         * flatpak/flatpakutils.py:
9         (WebkitFlatpak.load_from_args):
10         (WebkitFlatpak.__init__):
11         (WebkitFlatpak.clean_args):
12         (WebkitFlatpak.run_in_sandbox):
13         (WebkitFlatpak.save_config):
14         (WebkitFlatpak):
15         (WebkitFlatpak.setup_ccache):
16         (WebkitFlatpak.setup_icecc):
17         (WebkitFlatpak.setup_dev_env):
18         * flatpak/org.webkit.WebKit.yaml:
19
20 2018-10-02  Michael Catanzaro  <mcatanzaro@igalia.com>
21
22         Unreviewed, fix missing return value in TestController::keyExistsInKeychain
23
24         * WebKitTestRunner/TestController.cpp:
25         (WTR::TestController::keyExistsInKeychain):
26
27 2018-10-02  Basuke Suzuki  <Basuke.Suzuki@sony.com>
28
29         [WinCairo] Enable WPT tests environment.
30         https://bugs.webkit.org/show_bug.cgi?id=190128
31
32         Reviewed by Youenn Fablet.
33
34         Escaping backslash of the path not to confuse the JSON parser.
35
36         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
37         (WebPlatformTestServer._prepare_config):
38
39 2018-10-01  Ross Kirsling  <ross.kirsling@sony.com>
40
41         [Win][DRT] Actually set "experimental:WebAnimationsCSSIntegrationEnabled" when requested
42         https://bugs.webkit.org/show_bug.cgi?id=190150
43
44         Reviewed by Fujii Hironori.
45
46         * DumpRenderTree/win/DumpRenderTree.cpp:
47         (setWebPreferencesForTestOptions):
48         DRT has been recognizing this field, but not propagating its value to WebPreferences.
49
50 2018-10-01  Alex Christensen  <achristensen@webkit.org>
51
52         Unreviewed, rolling out r236551.
53
54         Fails URL validating too aggressively
55
56         Reverted changeset:
57
58         "URLWithUserTypedString should return nil for URLs deemed to
59         be invalid by WebCore::URL"
60         https://bugs.webkit.org/show_bug.cgi?id=189979
61         https://trac.webkit.org/changeset/236551
62
63 2018-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
64
65         [iOS] Add SPI to customize the input accessory view when focusing an element
66         https://bugs.webkit.org/show_bug.cgi?id=190152
67         <rdar://problem/42754975>
68
69         Reviewed by Dan Bernstein.
70
71         Add an API test to verify that setting a custom input accessory view and custom input view on the form input
72         session when focusing an element overrides the first responder's (i.e. WKContentView's) `-inputView` and
73         `-inputAccessoryView`.
74
75         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
76         (webViewWithAutofocusedInput):
77         (TestWebKitAPI::TEST):
78         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
79         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
80         (-[TestInputDelegate setWillStartInputSessionHandler:]):
81         (-[TestInputDelegate willStartInputSessionHandler]):
82         (-[TestInputDelegate _webView:willStartInputSession:]):
83
84 2018-10-01  Sihui Liu  <sihui_liu@apple.com>
85
86         Remove StorageProcess
87         https://bugs.webkit.org/show_bug.cgi?id=189975
88
89         Reviewed by Geoffrey Garen.
90
91         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
92         (TEST):
93         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
94         * TestWebKitAPI/Tests/WebKitCocoa/WebProcessKillIDBCleanup.mm:
95         (TEST):
96         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
97         (TEST):
98         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
99         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
100         (WTR::TestRunner::terminateStorageProcess): Deleted.
101         * WebKitTestRunner/InjectedBundle/TestRunner.h:
102         * WebKitTestRunner/TestController.cpp:
103         (WTR::TestController::generatePageConfiguration):
104         (WTR::TestController::databaseProcessName): Deleted.
105         (WTR::TestController::databaseProcessDidCrash): Deleted.
106         (WTR::TestController::terminateStorageProcess): Deleted.
107         * WebKitTestRunner/TestController.h:
108         * WebKitTestRunner/TestInvocation.cpp:
109         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
110
111 2018-10-01  Jiewen Tan  <jiewen_tan@apple.com>
112
113         [WebAuthN] Import a JS CBOR coder
114         https://bugs.webkit.org/show_bug.cgi?id=189877
115         <rdar://problem/44701124>
116
117         Reviewed by Chris Dumez.
118
119         Add logic to only process privateKeyBase64, userCertificateBase64 and intermediateCACertificateBase64
120         only if acceptAttestation is true.
121
122         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
123         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
124
125 2018-10-01  Chris Dumez  <cdumez@apple.com>
126
127         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
128         https://bugs.webkit.org/show_bug.cgi?id=190052
129
130         Reviewed by Ryosuke Niwa.
131
132         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
133         to log those events. It also uses console.log() before sending those events to indicate what the test is about
134         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
135         so that it can log the message.
136         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
137         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
138         handler to be transformed into synchronous IPC.
139         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
140         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
141         messages may end up being out of order, leading to flakiness.
142
143         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicated
144         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
145         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
146
147         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
148         (WTR::InjectedBundle::outputText):
149
150 2018-10-01  Daniel Bates  <dabates@apple.com>
151
152         [iOS] Special keys are misidentified in DOM keyboard events
153         https://bugs.webkit.org/show_bug.cgi?id=189974
154
155         Reviewed by Wenson Hsieh.
156
157         Add support for testing keys Forward Delete and Num Lock / Clear.
158
159         * WebKitTestRunner/ios/HIDEventGenerator.mm:
160         (hidUsageCodeForCharacter):
161
162 2018-10-01  Alex Christensen  <achristensen@webkit.org>
163
164         URL should not use TextEncoding internally
165         https://bugs.webkit.org/show_bug.cgi?id=190111
166
167         Reviewed by Andy Estes.
168
169         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
170         (TestWebKitAPI::testUserPass):
171         (TestWebKitAPI::TEST_F):
172
173 2018-10-01  Daniel Bates  <dabates@apple.com>
174
175         LLDB tests may use wrong configuration of lldbWebKitTester
176         https://bugs.webkit.org/show_bug.cgi?id=189011
177
178         Reviewed by Dean Jackson.
179
180         Fixes an issue where the LLDB unit tests may use the wrong configuration of lldbWebKitTester.
181         Additionally, add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
182
183         Currently the unit tests pick the LLDBWebKitTester binary based on the configuration set by
184         script set-webkit-configuration. This may not be the same configuration specified to test-webkitpy.
185         So, the unit tests may use the wrong binary. Instead we have test-webkitpy store the path
186         to the correct lldbWebKitTester binary that the unit tests should use in an environment variable,
187         called LLDB_WEBKIT_TESTER_EXECUTABLE. (We use an environment variable because the test driver,
188         test-webkitpy, and the unit tests cannot talk to each other directly due the limitations of
189         the Python unittest module, the Python multiprocessing module, and the general principle of unit
190         tests - to test code in isolation). The unit tests make use of the value of this environment
191         variable to launch lldbWebKitTester binary.
192
193         * Scripts/build-lldbwebkittester: We only support building lldbWebKitTester on Mac for now. Error
194         out if this script is invoked for a non-Mac platform.
195         * Scripts/webkitpy/test/main.py:
196         (Tester._run_tests): Build lldbWebKitTester and store the path to it in the environment variable
197         LLDB_WEBKIT_TESTER_EXECUTABLE.
198         (_build_lldb_webkit_tester): Deleted.
199         * lldb/dump_class_layout_unittest.py:
200         (TestDumpClassLayout.shouldSkip): Use SystemHost() here and remove the _host global variable as
201         this is the only call site that needs the Host object now.
202         (TestDumpClassLayout.setUpClass): Take the path to the lldbWebKitTester binary from the value of
203         the environment variable LLDB_WEBKIT_TESTER_EXECUTABLE.
204         * lldb/lldbWebKitTester/main.cpp:
205         (testSummaryProviders): Add back unit test support infrastructure originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
206         * lldb/lldb_webkit_unittest.py:
207         (LLDBDebugSession.setup): Take the path to the lldbWebKitTester binary from the value of the environment
208         variable LLDB_WEBKIT_TESTER_EXECUTABLE.
209         (TestSummaryProviders):
210         (TestSummaryProviders.shouldSkip): Skip the tests on non-Mac platforms.
211         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
212         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_empty):
213         (TestSummaryProviders.serial_test_WTFOptionSet_SummaryProvider_simple):
214         (TestSummaryProviders.serial_test_WTFOptionSetProvider_empty):
215         (TestSummaryProviders.serial_test_WTFOptionSetProvider_simple):
216         Add back the unit tests originally added in r235376 (https://bugs.webkit.org/show_bug.cgi?id=188936).
217
218 2018-10-01  Olivier Blin  <olivier.blin@softathome.com>
219
220         [WPE] Update install-dependencies
221         https://bugs.webkit.org/show_bug.cgi?id=190127
222
223         Reviewed by Michael Catanzaro.
224
225         * wpe/install-dependencies:
226         libxrandr-dev is needed for gstreamer-vaapi in jhbuild
227         It is used by gstvaapidisplay_x11.c.
228         Add it only for Apt, already ok for Pacman and DNF.
229
230         Install libevent-dev for WebRTC (like GTK)
231
232         Install libasound2-dev for WebRTC.
233         Add it only for Apt, already ok for Pacam and DNF.
234
235         Install libgbm-dev for HeadlessViewBackend, which uses gbm.h
236
237 2018-10-01  Thibault Saunier  <tsaunier@igalia.com>
238
239         [Flatpak] Add libunwind in the sandbox
240         https://bugs.webkit.org/show_bug.cgi?id=190123
241
242         Allowing us to get proper traces in GStreamer trace grabing
243         debug functions.
244
245         Reviewed by Philippe Normand.
246
247         * flatpak/org.webkit.WebKit.yaml:
248
249 2018-09-29  Commit Queue  <commit-queue@webkit.org>
250
251         Unreviewed, rolling out r236631.
252         https://bugs.webkit.org/show_bug.cgi?id=190112
253
254         Caused various eventSender tests, including fast/css/pseudo-
255         active-style-sharing*, to fail (Requested by smfr on #webkit).
256
257         Reverted changeset:
258
259         "Regression(r236512): http/tests/navigation/keyboard-events-
260         during-provisional-navigation.html is flaky"
261         https://bugs.webkit.org/show_bug.cgi?id=190052
262         https://trac.webkit.org/changeset/236631
263
264 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
265
266         [WHLSL] Fix build after r236635
267         https://bugs.webkit.org/show_bug.cgi?id=189210
268
269         Unreviewed.
270
271         * WebGPUShadingLanguageRI/Intrinsics.js:
272         (Intrinsics.):
273         * WebGPUShadingLanguageRI/Test.js:
274         (tests.atomicsNull):
275         (tests.numThreads):
276         (tests.textureDimensionsNull):
277
278 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
279
280         [WHLSL] Allow uniform buffers to be used in the interpreter
281         https://bugs.webkit.org/show_bug.cgi?id=189210
282
283         Reviewed by Filip Pizlo.
284
285         Every lvalue is associated with an address space, and the propagation of these address spaces
286         matches the propagation of lvalues. Luckily, there was already the infrastructure to do most
287         of this, so this patch just goes the last few yards. It also updates the standard library to
288         allow for writing into all writable address spaces for out-params.
289
290         * WebGPUShadingLanguageRI/Checker.js:
291         (Checker.prototype.visitAssignment):
292         (Checker.prototype._finishVisitingPropertyAccess):
293         * WebGPUShadingLanguageRI/Intrinsics.js:
294         (Intrinsics.):
295         (Intrinsics.checkFalse):
296         (Intrinsics):
297         * WebGPUShadingLanguageRI/StandardLibrary.js:
298         (let.standardLibrary):
299         * WebGPUShadingLanguageRI/Test.js:
300         (tests.threadArrayRefLoad):
301         (tests.threadArrayRefLoadIntLiteral):
302         (tests.deviceArrayRefLoad):
303         (tests.threadArrayRefStore):
304         (tests.deviceArrayRefStore):
305         (tests.deviceArrayRefStoreIntLiteral):
306         (tests.threadPointerLoad):
307         (tests.threadPointerStore):
308         (tests.devicePointerLoad):
309         (tests.devicePointerStore):
310         (tests.arrayLoad):
311         (tests.constantAddressSpace):
312         (tests.standardLibraryDevicePointers):
313         (tests.threadArrayLoad): Deleted.
314         (tests.threadArrayLoadIntLiteral): Deleted.
315         (tests.deviceArrayLoad): Deleted.
316         (tests.threadArrayStore): Deleted.
317         (tests.deviceArrayStore): Deleted.
318         (tests.deviceArrayStoreIntLiteral): Deleted.
319
320 2018-09-28  Wenson Hsieh  <wenson_hsieh@apple.com>
321
322         No DOM API to instantiate an attachment for an img element
323         https://bugs.webkit.org/show_bug.cgi?id=189934
324         <rdar://problem/44743222>
325
326         Reviewed by Ryosuke Niwa.
327
328         Adds 3 new API tests in WKAttachmentTests:
329
330         `AddAttachmentToConnectedImageElement` verifies that an image element that's already in the document can gain an
331         attachment element via `HTMLAttachmentElement.getAttachmentIdentifier`.
332
333         `ChangeFileWrapperForPastedImage` verifies that an image that has been pasted produces a _WKAttachment in the UI
334         process, and changing the file wrapper of that _WKAttachment changes the pasted image.
335
336         `ConnectImageWithAttachmentToDocument` verifies that script can create an image element, ensure that it has an
337         attachment, and set a file wrapper for the generated _WKAttachment. Connecting the image to the document should
338         then result in an image element with the contents of the _WKAttachment's file wrapper.
339
340         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
341         (-[TestWKWebView imageElementSize]):
342         (-[TestWKWebView waitForImageElementSizeToBecome:]):
343         (TestWebKitAPI::TEST):
344         (-[TestWKWebView waitForAttachmentElementSizeToBecome:]): Deleted.
345
346 2018-09-28  Chris Dumez  <cdumez@apple.com>
347
348         Regression(r236512): http/tests/navigation/keyboard-events-during-provisional-navigation.html is flaky
349         https://bugs.webkit.org/show_bug.cgi?id=190052
350
351         Reviewed by Ryosuke Niwa.
352
353         The test relies on EventSender to send events to the page synchronously to the page and then uses console.log
354         to log those events. It also uses console.log() before sending those events to indicate what the test is about
355         to do. Note that console.log() normally causes the WebKitTestRunner to send an asynchronous IPC to the UIProcess
356         so that it can log the message.
357         The issue is that EventSender uses IPC::SendOption::UseFullySynchronousModeForTesting when sending the
358         sync IPC to the UIProcess. This option causes follow-up *asynchronous* IPC sent from the synchronous IPC reply
359         handler to be transformed into synchronous IPC.
360         As a result, some of the console.log IPC ended up being asynchronous and some other ended up being synchronous.
361         Because synchronous and asynchronous IPC is not necessarily processed in-order by the UIProcess, the logged
362         messages may end up being out of order, leading to flakiness.
363
364         To address the issue, we now make sure that InjectedBundle::outputText() uses a new IPC::SendOption indicating
365         that the IPC should always be sent asynchronously, even if the connection is in fully synchronous mode. As a
366         result, all text outputing IPC to the UIProcess will be asynchronous, and thus in order.
367
368         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
369         (WTR::InjectedBundle::outputText):
370
371 2018-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
372
373         [WHLSL] Pointers should have automatically-generated equality checks
374         https://bugs.webkit.org/show_bug.cgi?id=189986
375
376         Reviewed by Filip Pizlo.
377
378         C allows for pointer equality, and we need it so people can do null checks.
379         This is generated the same way all our other NativeFuncs are generated - by Checker
380         creating NativeFuncs inside CallExpression.resolve().
381
382         This patch also does some general cleanup.
383
384         * WebGPUShadingLanguageRI/All.js: Everything the late checker does is no longer necessary.
385         The last thing it was doing was making sure that only primitive types are in resources, but
386         it's totally reasonable to put structs and arrays in resources, so I removed this pass. We
387         still have to add a check to make sure resources can't live within resources, but I expect
388         that will be done in the same place that semantics are checked.
389         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js:
390         (allocateAtEntryPoints.updateFunction.UpdateFunctions.prototype._addVariableDeclaration):
391         Name the global struct for debugging purposes.
392         * WebGPUShadingLanguageRI/CallExpression.js: 
393         (CallExpression.prototype._resolveByInstantiation): Cleanup
394         (CallExpression.prototype._resolveWithOperatorAnderIndexer): Ditto
395         (CallExpression.prototype._resolveWithOperatorLength): Ditto
396         (CallExpression.prototype._resolveWithReferenceComparator): Add support to automatically
397         generate pointer equality NativeFuncs.
398         * WebGPUShadingLanguageRI/EPtr.js: Implement pointer equality in the interpreter.
399         * WebGPUShadingLanguageRI/LateChecker.js: Removed.
400         * WebGPUShadingLanguageRI/LayoutBuffers.js: Renamed from Tools/WebGPUShadingLanguageRI/LateCheckAndLayoutBuffers.js.
401         (layoutBuffers):
402         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj:
403         * WebGPUShadingLanguageRI/NativeFunc.js:
404         * WebGPUShadingLanguageRI/OperatorArrayRefLength.js:
405         (OperatorArrayRefLength.prototype.instantiateImplementation):
406         (OperatorArrayRefLength):
407         * WebGPUShadingLanguageRI/Prepare.js:
408         (let.prepare):
409         * WebGPUShadingLanguageRI/SPIRV.html:
410         * WebGPUShadingLanguageRI/Test.html:
411         * WebGPUShadingLanguageRI/Test.js:
412         (tests.ternaryExpression):
413         (tests.break): Speed up testing time
414         (tests.doWhile): Ditto
415         (tests.forLoop): Ditto
416         (tests.atomics): Ditto
417         (tests.atomicsNull): Ditto
418         (tests.pointerEquality): Test pointer equality
419         (tests.standardLibraryDevicePointers):
420         (tests.devicePtrPtr): Deleted.
421         (tests.threadgroupPtrPtr): Deleted.
422         (tests.constantPtrPtr): Deleted.
423         * WebGPUShadingLanguageRI/index.html:
424
425 2018-09-28  Jiewen Tan  <jiewen_tan@apple.com>
426
427         [WebAuthN] Polish WebAuthN auto-test environment
428         https://bugs.webkit.org/show_bug.cgi?id=189283
429         <rdar://problem/44117828>
430
431         Reviewed by Chris Dumez.
432
433         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
434         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
435
436 2018-09-28  Chris Dumez  <cdumez@apple.com>
437
438         Drop support for cross-origin-window-policy header
439         https://bugs.webkit.org/show_bug.cgi?id=190081
440
441         Reviewed by Ryosuke Niwa.
442
443         190081_DropCrossOriginWindowPolicy
444
445         * DumpRenderTree/mac/DumpRenderTree.mm:
446         (enableExperimentalFeatures):
447         * DumpRenderTree/win/DumpRenderTree.cpp:
448         (enableExperimentalFeatures):
449         * WebKitTestRunner/TestController.cpp:
450         (WTR::TestController::resetPreferencesToConsistentValues):
451
452 2018-09-28  Koby Boyango  <koby.b@mce.systems>
453
454         [WTF] Add ExternalStringImpl, a StringImpl for user controlled buffers
455         https://bugs.webkit.org/show_bug.cgi?id=189991
456
457         Reviewed by Yusuke Suzuki.
458
459         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
460
461 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
462
463         Update flakiness dashboard configuration for Mojave queues
464         https://bugs.webkit.org/show_bug.cgi?id=190068
465
466         Reviewed by Alexey Proskuryakov.
467
468         * TestResultServer/static-dashboards/builders.jsonp:
469
470 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
471
472         Bring up queues for Mojave
473         https://bugs.webkit.org/show_bug.cgi?id=189935
474
475         Unreviewed infrastructure fix.
476
477         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove trigger, update bot assignment.
478
479 2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
480
481         Bring up queues for Mojave
482         https://bugs.webkit.org/show_bug.cgi?id=189935
483
484         Reviewed by Alexey Proskuryakov.
485
486         * BuildSlaveSupport/build.webkit.org-config/config.json:
487         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
488         (WebKitBuildbot):
489         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
490
491 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
492
493         Increase the timeout for iOS Simulator data migration
494         https://bugs.webkit.org/show_bug.cgi?id=190059
495
496         Reviewed by Aakash Jain.
497
498         3 minutes isn't always enough time for the data migrator to complete
499         when booting up multiple iOS Simulators. Change the timeout to 10 minutes.
500
501         * Scripts/webkitpy/xcode/simulated_device.py:
502         (SimulatedDeviceManager): Create a constant for the default timeout.
503         (SimulatedDeviceManager.initialize_devices): Use new constant.
504         (SimulatedDeviceManager.swap): Ditto.
505         (SimulatedDeviceManager.wait_until_data_migration_is_done): Ditto.
506
507 2018-09-27  Alex Christensen  <achristensen@webkit.org>
508
509         URLParser should use TextEncoding through an abstract class
510         https://bugs.webkit.org/show_bug.cgi?id=190027
511
512         Reviewed by Andy Estes.
513
514         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
515         (TestWebKitAPI::checkURL):
516         (TestWebKitAPI::TEST_F):
517
518 2018-09-27  Ryan Haddad  <ryanhaddad@apple.com>
519
520         iOS Simulator bots should pass '--dedicated-simulators' to run-webkit-tests
521         https://bugs.webkit.org/show_bug.cgi?id=190042
522
523         Reviewed by Aakash Jain.
524
525         To make iOS Simulator bots resilient to issues that can arise from reusing
526         existing simulators, ensure that dedicated simulators are created for each test run.
527
528         * Scripts/webkitpy/common/config/ports.py:
529         (IOSSimulatorWK2Port.run_webkit_tests_command):
530
531 2018-09-27  Alex Christensen  <achristensen@webkit.org>
532
533         URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
534         https://bugs.webkit.org/show_bug.cgi?id=189979
535
536         Reviewed by Youenn Fablet.
537
538         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
539         (TestWebKitAPI::originalDataAsString):
540         (TestWebKitAPI::TEST):
541
542 2018-09-27  Basuke Suzuki  <Basuke.Suzuki@sony.com>
543
544         [Win][WebKit] Implement authentication dialog on MiniBrowser.
545         https://bugs.webkit.org/show_bug.cgi?id=189846
546
547         Reviewed by Fujii Hironori.
548
549         It was implemented for WebKitLegacy, but not for WebKit.
550         Also added text field to display Realm information.
551
552         * MiniBrowser/win/Common.cpp:
553         (authDialogProc):
554         (askCredential):
555         (displayAuthDialog): Deleted.
556         * MiniBrowser/win/Common.h:
557         * MiniBrowser/win/MiniBrowserLib.rc:
558         * MiniBrowser/win/MiniBrowserLibResource.h:
559         * MiniBrowser/win/ResourceLoadDelegate.cpp:
560         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
561         * MiniBrowser/win/WebKitBrowserWindow.cpp:
562         (createString):
563         (createUTF8String):
564         (createWKString):
565         (createWKURL):
566         (WebKitBrowserWindow::WebKitBrowserWindow):
567         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
568         (toNullTerminatedUTF8): Deleted.
569         * MiniBrowser/win/WebKitBrowserWindow.h:
570
571 2018-09-27  Youenn Fablet  <youenn@apple.com>
572
573         Enable getUserMedia in mini browser
574         https://bugs.webkit.org/show_bug.cgi?id=190012
575
576         Reviewed by Eric Carlson.
577
578         Enable MediaDevices and mock capture devices.
579         Grant mock devices access to any getUserMedia call.
580         Covered by manual testing.
581
582         * MiniBrowser/mac/AppDelegate.m:
583         (defaultConfiguration):
584         * MiniBrowser/mac/WK2BrowserWindowController.m:
585         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
586         (-[WK2BrowserWindowController _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
587
588 2018-09-27  Antoine Quint  <graouts@apple.com>
589
590         [Web Animations] Turn Web Animations with CSS integration on
591         https://bugs.webkit.org/show_bug.cgi?id=184819
592         <rdar://problem/39597337>
593
594         Reviewed by Dean Jackson.
595
596         * DumpRenderTree/TestOptions.h:
597
598 2018-09-26  Alex Christensen  <achristensen@webkit.org>
599
600         Unreviewed, rolling out r236524.
601
602         Broke API tests
603
604         Reverted changeset:
605
606         "URLWithUserTypedString should return nil for URLs deemed to
607         be invalid by WebCore::URL"
608         https://bugs.webkit.org/show_bug.cgi?id=189979
609         https://trac.webkit.org/changeset/236524
610
611 2018-09-26  James Savage  <james.savage@apple.com>
612
613         Allow override of viewport configuration.
614         https://bugs.webkit.org/show_bug.cgi?id=188772.
615         <rdar://problem/43538892>.
616
617         Reviewed by Simon Fraser.
618
619         * WebKitTestRunner/TestController.cpp:
620         (WTR::updateTestOptionsFromTestHeader): Parse new test option key from comments.
621         * WebKitTestRunner/TestOptions.h:
622         * WebKitTestRunner/ios/TestControllerIOS.mm:
623         (WTR::TestController::platformConfigureViewForTest): Handle new test option by
624         modifying the web view's preferences accordingly.
625
626 2018-09-26  Alex Christensen  <achristensen@webkit.org>
627
628         URLs with mismatched surrogate pairs in the host should fail to parse
629         https://bugs.webkit.org/show_bug.cgi?id=190005
630
631         Reviewed by Chris Dumez.
632
633         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
634         (TestWebKitAPI::TEST_F):
635
636 2018-09-26  Alex Christensen  <achristensen@webkit.org>
637
638         URLWithUserTypedString should return nil for URLs deemed to be invalid by WebCore::URL
639         https://bugs.webkit.org/show_bug.cgi?id=189979
640         <rdar://problem/44119696>
641
642         Reviewed by Chris Dumez.
643
644         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
645         (TestWebKitAPI::TEST):
646
647 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
648
649         Selection should work across shadow boundary when initiated by a mouse drag
650         https://bugs.webkit.org/show_bug.cgi?id=151380
651         <rdar://problem/24363872>
652
653         Reviewed by Wenson Hsieh.
654
655         Added the support for internal:selectionAcrossShadowBoundariesEnabled test option.
656
657         * DumpRenderTree/TestOptions.cpp:
658         (TestOptions::TestOptions):
659         * DumpRenderTree/TestOptions.h:
660         * DumpRenderTree/mac/DumpRenderTree.mm:
661         (resetWebPreferencesToConsistentValues):
662         (setWebPreferencesForTestOptions):
663
664 2018-09-26  Ryosuke Niwa  <rniwa@webkit.org>
665
666         MiniBrowser doesn't respect default enabled-ness of experimental and internal debug features
667         https://bugs.webkit.org/show_bug.cgi?id=189989
668
669         Reviewed by Simon Fraser.
670
671         When the preference isn't found in user defaults, use the default value of each feature's enabledness.
672
673         * MiniBrowser/mac/AppDelegate.m:
674         (defaultConfiguration):
675
676 2018-09-26  Philippe Normand  <pnormand@igalia.com>
677
678         [Flatpak] Bump to apr 1.6.5
679
680         Version 1.6.3 is no longer available on Apache's website.
681
682         Rubber-stamped by Michael Catanzaro.
683
684         * flatpak/org.webkit.WebKit.yaml:
685
686 2018-09-25  Jiewen Tan  <jiewen_tan@apple.com>
687
688         [WebAuthN] Make AuthenticatorManager
689         https://bugs.webkit.org/show_bug.cgi?id=189279
690         <rdar://problem/44116792>
691
692         Reviewed by Chris Dumez.
693
694         Besides the functionality to set the WebAuthenticationMockConfiguration. Three operations are
695         added to manipulate Keychain: addTestKeyToKeychain, cleanUpKeychain and keyExistedInKeychain.
696
697         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
698         * TestWebKitAPI/Tests/ios/LocalAuthenticator.mm: Removed.
699         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
700         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
701         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
702         (WTR::TestRunner::addTestKeyToKeychain):
703         (WTR::TestRunner::cleanUpKeychain):
704         (WTR::TestRunner::isKeyExisted):
705         * WebKitTestRunner/InjectedBundle/TestRunner.h:
706         * WebKitTestRunner/TestController.cpp:
707         (WTR::TestController::addTestKeyToKeychain):
708         (WTR::TestController::cleanUpKeychain):
709         (WTR::TestController::isKeyExisted):
710         (WTR::TestController::setWebAuthenticationMockConfiguration):
711         * WebKitTestRunner/TestController.h:
712         * WebKitTestRunner/TestInvocation.cpp:
713         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
714         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
715         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
716         (WTR::TestController::addTestKeyToKeychain):
717         (WTR::TestController::cleanUpKeychain):
718         (WTR::TestController::keyExistedInKeychain):
719
720 2018-09-25  Sihui Liu  <sihui_liu@apple.com>
721
722         Move Service Worker Management from Storage Process to Network Process
723         https://bugs.webkit.org/show_bug.cgi?id=189422
724
725         Reviewed by Youenn Fablet.
726
727         Change a check in ServiceWorkers.HasServiceWorkerRegistrationBit as storage process is not
728         launched during service worker operations now.
729
730         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
731
732 2018-09-25  Eric Carlson  <eric.carlson@apple.com>
733
734         [MediaStream] Update constraints supported by getDisplayMedia
735         https://bugs.webkit.org/show_bug.cgi?id=189930
736         <rdar://problem/44740305>
737
738         Unreviewed, fix test broken by r236465.
739
740         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
741         (TestWebKitAPI::TEST_F):
742
743 2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
744
745         [WHSL] Implement semantics
746         https://bugs.webkit.org/show_bug.cgi?id=189134
747
748         Reviewed by Filip Pizlo.
749
750         This patch adds parsing support and adds the checks required to support HLSL-style semantics.
751
752         There are 3 places where semantics are allowed:
753
754         1. In a field in a struct. E.g.
755
756         struct R {
757             float4 position : SV_Position;
758         }
759         vertex R foo() {
760             ...
761         }
762
763         2. In a parameter of a function. If the function is not an entry point, the semantic is ignored.
764
765         compute void foo(device float[] data : buffer(u0)) {
766             ...
767         }
768
769         3. On a function. This is so you don't have to create structs for the return types of simple vertex shaders.
770
771         vertex float4 foo() : SV_Position {
772             ...
773         }
774
775         The semantics are partitioned into 4 types:
776
777         1. Built-in variables. For example, : SV_Position.
778         2. Resources. For example, : register(u0).
779         3. Stage-in / stage-out variables. For example, : attribute(0).
780         4. Specialization constants. For example, : specialized.
781
782         The semantics are validated according to a collection of rules:
783
784         - The same entry point can't list the same semantic twice
785         - Each built-in type has an appropriate type that is listed in the spec. 
786         - Each built-in is appropriate as either an input or an output of a particular shader stage
787         - Resource semantics have to have the appropriate type (e.g. can't use register(s0) on a buffer)
788         - Resources can't be output from entry points
789         - The resource semantic mode must match the address space of the resource
790         - Stage-in and stage-out variables have to be POD
791         - Specialization constants can't be output from entry points, and have to be numbers
792
793         * WebGPUShadingLanguageRI/All.js:
794         * WebGPUShadingLanguageRI/BuiltInSemantic.js: Added.
795         (BuiltInSemantic):
796         (BuiltInSemantic.prototype.get name):
797         (BuiltInSemantic.prototype.get extraArguments):
798         (BuiltInSemantic.prototype.isAcceptableType):
799         (BuiltInSemantic.prototype.isAcceptableForShaderType):
800         (BuiltInSemantic.prototype.toString):
801         * WebGPUShadingLanguageRI/CallExpression.js:
802         (CallExpression.prototype._resolveWithOperatorAnderIndexer):
803         (CallExpression.prototype._resolveWithOperatorLength):
804         * WebGPUShadingLanguageRI/Checker.js:
805         (Checker):
806         (Checker.prototype.visitProgram):
807         (Checker.prototype._checkSemantics.Item):
808         (Checker.prototype._checkSemantics.Item.prototype.get type):
809         (Checker.prototype._checkSemantics.Item.prototype.get semantic):
810         (Checker.prototype._checkSemantics.Gatherer):
811         (Checker.prototype._checkSemantics.Gatherer.prototype.reset):
812         (Checker.prototype._checkSemantics.Gatherer.prototype.set currentSemantic):
813         (Checker.prototype._checkSemantics.Gatherer.prototype.get currentSemantic):
814         (Checker.prototype._checkSemantics.Gatherer.prototype.get result):
815         (Checker.prototype._checkSemantics.Gatherer.prototype.visitEnumType):
816         (Checker.prototype._checkSemantics.Gatherer.prototype.visitVectorType):
817         (Checker.prototype._checkSemantics.Gatherer.prototype.visitMatrixType):
818         (Checker.prototype._checkSemantics.Gatherer.prototype.visitNativeType):
819         (Checker.prototype._checkSemantics.Gatherer.prototype.visitStructType):
820         (Checker.prototype._checkSemantics.Gatherer.prototype.visitTypeRef):
821         (Checker.prototype._checkSemantics.Gatherer.prototype.visitPtrType):
822         (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayRefType):
823         (Checker.prototype._checkSemantics.Gatherer.prototype.visitArrayType):
824         (Checker.prototype._checkSemantics.Gatherer.prototype.visitFuncParameter):
825         (Checker.prototype._checkSemantics.checkDuplicateSemantics):
826         (Checker.prototype._checkSemantics.checkSemanticTypes):
827         (Checker.prototype._checkSemantics.checkSemanticForShaderType):
828         (Checker.prototype._checkSemantics.PODChecker.prototype.visitEnumType):
829         (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayType):
830         (Checker.prototype._checkSemantics.PODChecker.prototype.visitVectorType):
831         (Checker.prototype._checkSemantics.PODChecker.prototype.visitMatrixType):
832         (Checker.prototype._checkSemantics.PODChecker.prototype.visitNativeType):
833         (Checker.prototype._checkSemantics.PODChecker.prototype.visitPtrType):
834         (Checker.prototype._checkSemantics.PODChecker.prototype.visitArrayRefType):
835         (Checker.prototype._checkSemantics.PODChecker.prototype.visitStructType):
836         (Checker.prototype._checkSemantics.PODChecker.prototype.visitTypeRef):
837         (Checker.prototype._checkSemantics.PODChecker):
838         (Checker.prototype._checkSemantics.checkPODData):
839         (Checker.prototype._checkSemantics):
840         (Checker.prototype._checkShaderType):
841         (Checker.prototype._checkOperatorOverload):
842         (Checker.prototype.visitFuncDef):
843         (Checker.prototype.visitEnumType):
844         (Checker.prototype.visitArrayType):
845         (Checker.prototype.visitMakePtrExpression):
846         (Checker.prototype.visitMakeArrayRefExpression):
847         (Checker.prototype._finishVisitingPropertyAccess):
848         (Checker.prototype.visitIndexExpression):
849         (Checker.prototype.visitReturn):
850         (Checker.prototype.visitSwitchStatement):
851         (Checker.prototype.visitTernaryExpression):
852         (Checker.prototype.visitCallExpression):
853         * WebGPUShadingLanguageRI/Field.js:
854         (Field):
855         (Field.prototype.get semantic):
856         (Field.prototype.toString):
857         * WebGPUShadingLanguageRI/Func.js:
858         (Func):
859         (Func.prototype.get semantic):
860         (Func.prototype.toDeclString):
861         * WebGPUShadingLanguageRI/FuncDef.js:
862         (FuncDef):
863         * WebGPUShadingLanguageRI/FuncParameter.js:
864         (FuncParameter):
865         (FuncParameter.prototype.get semantic):
866         (FuncParameter.prototype.toString):
867         * WebGPUShadingLanguageRI/Intrinsics.js:
868         * WebGPUShadingLanguageRI/LateChecker.js:
869         (LateChecker.prototype.visitReferenceType):
870         (LateChecker):
871         (LateChecker.prototype._checkShaderType): Deleted.
872         (LateChecker.prototype.visitFuncDef): Deleted.
873         * WebGPUShadingLanguageRI/NativeFunc.js:
874         (NativeFunc):
875         * WebGPUShadingLanguageRI/Parse.js:
876         (parseParameter):
877         (parseFuncDecl):
878         (parseFuncDef):
879         (parseStageInOutSemantic):
880         (parseResourceSemantic):
881         (parseSpecializationConstantSemantic):
882         (parseBuiltInSemantic):
883         (parseField):
884         (parseNativeFunc):
885         * WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js:
886         (programWithUnnecessaryThingsRemoved):
887         * WebGPUShadingLanguageRI/ResourceSemantic.js: Added.
888         (ResourceSemantic):
889         (ResourceSemantic.prototype.get resourceMode):
890         (ResourceSemantic.prototype.get index):
891         (ResourceSemantic.prototype.get space):
892         (ResourceSemantic.prototype.isAcceptableType):
893         (ResourceSemantic.prototype.isAcceptableForShaderType):
894         (ResourceSemantic.prototype.toString):
895         * WebGPUShadingLanguageRI/Rewriter.js:
896         (Rewriter.prototype.visitFuncParameter):
897         (Rewriter.prototype.visitField):
898         (Rewriter.prototype.visitBuiltInSemantic):
899         (Rewriter.prototype.visitResourceSemantic):
900         (Rewriter.prototype.visitStageInOutSemantic):
901         (Rewriter.prototype.visitSpecializationConstantSemantic):
902         (Rewriter):
903         * WebGPUShadingLanguageRI/SPIRV.html:
904         * WebGPUShadingLanguageRI/Semantic.js: Added.
905         (Semantic):
906         (Semantic.prototype.get origin):
907         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitBuiltInSemantic):
908         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitResourceSemantic):
909         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitStageInOutSemantic):
910         (Semantic.prototype.equalToOtherSemantic.Comparer.prototype.visitSpecializationConstantSemantic):
911         (Semantic.prototype.equalToOtherSemantic.Comparer):
912         (Semantic.prototype.equalToOtherSemantic):
913         * WebGPUShadingLanguageRI/SpecializationConstantSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/Field.js.
914         (SpecializationConstantSemantic):
915         (SpecializationConstantSemantic.prototype.isAcceptableType):
916         (SpecializationConstantSemantic.prototype.isAcceptableForShaderType):
917         (SpecializationConstantSemantic.prototype.toString):
918         * WebGPUShadingLanguageRI/StageInOutSemantic.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
919         (StageInOutSemantic):
920         (StageInOutSemantic.prototype.get index):
921         (StageInOutSemantic.prototype.isAcceptableType):
922         (StageInOutSemantic.prototype.isAcceptableForShaderType):
923         (StageInOutSemantic.prototype.toString):
924         * WebGPUShadingLanguageRI/StatementCloner.js:
925         (StatementCloner.prototype.visitNativeFunc):
926         * WebGPUShadingLanguageRI/SynthesizeArrayOperatorLength.js:
927         (synthesizeArrayOperatorLength):
928         * WebGPUShadingLanguageRI/SynthesizeCopyConstructorOperator.js:
929         (synthesizeCopyConstructorOperator):
930         * WebGPUShadingLanguageRI/SynthesizeDefaultConstructorOperator.js:
931         (synthesizeDefaultConstructorOperator):
932         * WebGPUShadingLanguageRI/SynthesizeEnumFunctions.js:
933         (synthesizeEnumFunctions):
934         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
935         (setupAnder):
936         (synthesizeStructAccessorsForStructType):
937         * WebGPUShadingLanguageRI/Test.html:
938         * WebGPUShadingLanguageRI/Test.js:
939         (tests.shaderTypes):
940         * WebGPUShadingLanguageRI/Visitor.js:
941         (Visitor.prototype.visitFunc):
942         (Visitor.prototype.visitFuncParameter):
943         (Visitor.prototype.visitField):
944         (Visitor.prototype.visitBuiltInSemantic):
945         (Visitor.prototype.visitResourceSemantic):
946         (Visitor.prototype.visitStageInOutSemantic):
947         (Visitor.prototype.visitSpecializationConstantSemantic):
948         (Visitor):
949         * WebGPUShadingLanguageRI/index.html:
950
951 2018-09-25  Thomas Denney  <tdenney@apple.com>
952
953         [WHLSL] Test suite for Metal code generation
954         https://bugs.webkit.org/show_bug.cgi?id=187738
955
956         Reviewed by Myles C. Maxfield.
957
958         This patch adds an Xcode project that contains a Cocoa app that can be
959         used for running WHLSL shaders on the GPU. It also contains an Xcode
960         test suite that runs all of the tests in Test.js on the GPU.
961
962         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/.gitignore: Added.
963         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.h: Added.
964         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/AppDelegate.m: Added.
965         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
966         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Assets.xcassets/Contents.json: Added.
967         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Base.lproj/Main.storyboard: Added.
968         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.h: Added.
969         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CompileResult.m: Added.
970         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.h: Added.
971         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Compiler.m: Added.
972         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.h: Added.
973         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/CustomMetalView.m: Added.
974         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Default.whlsl: Added.
975         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Julia.whlsl: Added.
976         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Demo shaders/Mandelbrot.whlsl: Added.
977         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Info.plist: Added.
978         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.h: Added.
979         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OffscreenRenderer.m: Added.
980         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.h: Added.
981         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/OnscreenRenderer.m: Added.
982         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.h: Added.
983         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/Renderer/Renderer.m: Added.
984         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.h: Added.
985         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestCallArgument.m: Added.
986         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.h: Added.
987         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestDescription.m: Added.
988         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.h: Added.
989         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamily.m: Added.
990         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.h: Added.
991         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/TestFamilyRunner.m: Added.
992         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.h: Added.
993         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/ViewController.m: Added.
994         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/WHLSL.entitlements: Added.
995         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/_SharedMetal.txt: Added.
996         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/Core/main.m: Added.
997         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL Tests.xcodeproj/project.pbxproj: Added.
998         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/Info.plist: Added.
999         * WebGPUShadingLanguageRI/Metal/WHLSL Tests/WHLSL ToyTests/WHLSL_ToyTests.m: Added.
1000         * WebGPUShadingLanguageRI/Test.js:
1001         (tests.lotsOfLocalVariables):
1002
1003 2018-09-25  Myles C. Maxfield  <mmaxfield@apple.com>
1004
1005         Unreviewed build fix after r236455
1006         https://bugs.webkit.org/show_bug.cgi?id=189121
1007
1008         * WebGPUShadingLanguageRI/Test.js:
1009         (tests.shaderStages):
1010
1011 2018-09-24  Myles C. Maxfield  <mmaxfield@apple.com>
1012
1013         [WHLSL] Not all functions should be able to run in all shader stages
1014         https://bugs.webkit.org/show_bug.cgi?id=189121
1015
1016         Reviewed by Filip Pizlo.
1017
1018         ddx() and ddy() can only run in fragment shaders, and the barrier functions can only run in compute shaders.
1019         ddx_coarse() & friends are currently implemented as just calling ddx(), so we only need to modify those functions
1020         if/when we make them native.
1021
1022         The texture sampling functions that use implicit derivatives can run in any shader stage - they just use a LOD of
1023         0. Therefore, those functions are unchanged.
1024
1025         * WebGPUShadingLanguageRI/All.js:
1026         * WebGPUShadingLanguageRI/Intrinsics.js:
1027         * WebGPUShadingLanguageRI/LateChecker.js:
1028         (LateChecker.prototype._checkShaderType):
1029         * WebGPUShadingLanguageRI/NativeFunc.js:
1030         (NativeFunc):
1031         (NativeFunc.prototype.get stage):
1032         (NativeFunc.prototype.toDeclString):
1033         * WebGPUShadingLanguageRI/Parse.js:
1034         (parseFuncDecl):
1035         (parseNativeFunc):
1036         (parseNative):
1037         * WebGPUShadingLanguageRI/Prepare.js:
1038         (let.prepare):
1039         * WebGPUShadingLanguageRI/SPIRV.html:
1040         * WebGPUShadingLanguageRI/StandardLibrary.js:
1041         (let.standardLibrary):
1042         * WebGPUShadingLanguageRI/StatementCloner.js:
1043         (StatementCloner.prototype.visitNativeFunc):
1044         * WebGPUShadingLanguageRI/Test.html:
1045         * WebGPUShadingLanguageRI/Test.js:
1046         (tests.shaderStages):
1047         * WebGPUShadingLanguageRI/WSyntaxError.js:
1048         (WSyntaxError.prototype.toString):
1049         (WSyntaxError):
1050         * WebGPUShadingLanguageRI/index.html:
1051
1052 2018-09-24  Thomas Denney  <tdenney@apple.com>
1053
1054         [WHLSL] Implement trap statements in Metal code generation
1055         https://bugs.webkit.org/show_bug.cgi?id=189615
1056
1057         Reviewed by Myles C. Maxfield.
1058
1059         Each function called by an entry point now receives an additional
1060         boolean pointer parameter, which is set to false if the function traps.
1061         After each function call (to a non-native function) this trap parameter
1062         is checked. The behavior of the interpreter has also been updated so
1063         that a function entry point catches the trap and instead returns zero,
1064         matching the behavior of compiled code.
1065
1066         * WebGPUShadingLanguageRI/Evaluator.js: Adds a new flag to allow the
1067         test suite to check for traps and also returns zero from entry points
1068         whose invocation trapped.
1069         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Pass program to function
1070         declarations.
1071         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Update dependencies.
1072         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Add program
1073         property.
1074         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Ditto.
1075         * WebGPUShadingLanguageRI/Metal/MSLInsertTrapParameter.js: Added.
1076         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Conforms to the
1077         new trapping behavior.
1078         * WebGPUShadingLanguageRI/Test.js: Update tests that trap.
1079
1080 2018-09-24  Thomas Denney  <tdenney@apple.com>
1081
1082         [WHLSL] It shouldn’t be possible to use ternary expressions as l-values
1083         https://bugs.webkit.org/show_bug.cgi?id=189290
1084
1085         Reviewed by Myles C. Maxfield.
1086
1087         It is no longer possible for a ternary expression to be treated as an
1088         l-value. This patch adds several test cases to verify that this is the
1089         case.
1090
1091         * WebGPUShadingLanguageRI/Checker.js:
1092         (Checker.prototype.visitTernaryExpression): No longer check isLValue.
1093         * WebGPUShadingLanguageRI/NormalUsePropertyResolver:
1094         (NormalUsePropertyResolver.visitTernaryExpression): Deleted.
1095         * WebGPUShadingLanguageRI/Rewriter.js:
1096         (Rewriter.prototype.visitTernaryExpression): No longer copy isLValue.
1097         * WebGPUShadingLanguageRI/TernaryExpression.js:
1098         (TernaryExpression):
1099         (TernaryExpression.prototype.get elseExpression):
1100         (TernaryExpression.prototype.get isLValue): Deleted.
1101         (TernaryExpression.prototype.set isLValue): Deleted.
1102         * WebGPUShadingLanguageRI/Test.js:
1103         (tests.ternaryExpression): Add checks for failure if a failure is used
1104         as an l-value.
1105         (ternaryExpressionIsLValue.node.TernaryExpressionVisitor.prototype.visitTernaryExpression): Deleted.
1106         (ternaryExpressionIsLValue.node.TernaryExpressionVisitor): Deleted.
1107         (tests.ternaryExpressionIsLValue): Deleted.
1108
1109 2018-09-24  Jer Noble  <jer.noble@apple.com>
1110
1111         SharedBuffer should have an equality test
1112         https://bugs.webkit.org/show_bug.cgi?id=189919
1113
1114         Reviewed by Alex Christensen.
1115
1116         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp:
1117         (TestWebKitAPI::TEST_F):
1118
1119 2018-09-24  Alex Christensen  <achristensen@webkit.org>
1120
1121         Prepare to replace WKBundleFileHandleCreateWithPath with a version that takes a WKBundlePageRef
1122         https://bugs.webkit.org/show_bug.cgi?id=189929
1123
1124         Reviewed by Andy Estes.
1125
1126         * TestWebKitAPI/Tests/WebKit/WKBundleFileHandle_Bundle.cpp:
1127
1128 2018-09-24  Thomas Denney  <tdenney@apple.com>
1129
1130         [WHLSL] Casting user-created types to themselves should always work
1131         https://bugs.webkit.org/show_bug.cgi?id=189113
1132
1133         Reviewed by Myles C. Maxfield.
1134
1135         Casting user-defined types to themselves worked already, but we didn't
1136         test it anywhere.
1137
1138         * WebGPUShadingLanguageRI/Test.js:
1139         (tests.selfCasts):
1140
1141 2018-09-24  Zan Dobersek  <zdobersek@igalia.com>
1142
1143         Unreviewed build fix for Jhbuild-using ports.
1144
1145         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch:
1146         Adjust the patch so it applies cleanly on the 1.14.3 version of the
1147         gst-plugins-good package.
1148
1149 2018-09-24  Ryan Haddad  <ryanhaddad@apple.com>
1150
1151         Update flakiness dashboard configuration for iOS 12 queues
1152         https://bugs.webkit.org/show_bug.cgi?id=189688
1153
1154         Reviewed by Alexey Proskuryakov.
1155
1156         * TestResultServer/static-dashboards/builders.jsonp:
1157
1158 2018-09-24  Alicia Boya García  <aboya@igalia.com>
1159
1160         [GStreamer] Unreviewed build fix.
1161
1162         A GStreamer patch was not applying cleanly on 1.14.3.
1163
1164         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch:
1165
1166 2018-09-24  Alicia Boya García  <aboya@igalia.com>
1167
1168         [MSE][GStreamer] Use no-more-pads event for noticing initialization segments
1169         https://bugs.webkit.org/show_bug.cgi?id=189868
1170
1171         Reviewed by Xabier Rodriguez-Calvar.
1172
1173         Added patch from https://bugzilla.gnome.org/show_bug.cgi?id=797187
1174
1175         * gstreamer/jhbuild.modules:
1176         * gstreamer/patches/gst-plugins-good-0010-matroskademux-Emit-no-more-pads-after-parsing-Tracks.patch: Added.
1177
1178 2018-09-24  Alicia Boya García  <aboya@igalia.com>
1179         [MSE][GStreamer] Add patch to jhbuild: matroskademux: Allow Matroska headers to be read more than once
1180         https://bugs.webkit.org/show_bug.cgi?id=185731
1181
1182         Reviewed by Xabier Rodriguez-Calvar.
1183
1184         Upstream bug in GStreamer: https://bugzilla.gnome.org/show_bug.cgi?id=793333
1185
1186         This fixes YTTV 35. AppendMultipleInitOpusAudio (and any other use
1187         case where two WebM initialization segments are appended on a row).
1188
1189         * gstreamer/jhbuild.modules:
1190         * gstreamer/patches/gst-plugins-good-0007-matroskademux-Allow-Matroska-headers-to-be-read-more.patch: Added.
1191         * gstreamer/patches/gst-plugins-good-0008-matroskademux-Refactor-track-parsing-out-from-adding.patch: Added.
1192         * gstreamer/patches/gst-plugins-good-0009-matroskademux-Parse-successive-Tracks-elements.patch: Added.
1193
1194 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
1195
1196         [WHSL] Need grammar to specify kernel group size
1197         https://bugs.webkit.org/show_bug.cgi?id=189108
1198
1199         Reviewed by Dean Jackson.
1200
1201         In HLSL, compute functions are annotated with their workgroup size.
1202         For example,
1203
1204         [numthreads(3, 4, 5)] compute void foo(...) { ... }
1205
1206         * WebGPUShadingLanguageRI/All.js:
1207         * WebGPUShadingLanguageRI/Func.js:
1208         (Func):
1209         (Func.prototype.get attributeBlock):
1210         * WebGPUShadingLanguageRI/FuncAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
1211         (FuncAttribute):
1212         * WebGPUShadingLanguageRI/FuncDef.js:
1213         (FuncDef):
1214         * WebGPUShadingLanguageRI/FuncNumThreadsAttribute.js: Copied from Tools/WebGPUShadingLanguageRI/FuncDef.js.
1215         (FuncNumThreadsAttribute):
1216         (FuncNumThreadsAttribute.prototype.get x):
1217         (FuncNumThreadsAttribute.prototype.get y):
1218         (FuncNumThreadsAttribute.prototype.get z):
1219         * WebGPUShadingLanguageRI/LateChecker.js:
1220         (LateChecker.prototype._checkShaderType):
1221         * WebGPUShadingLanguageRI/Parse.js:
1222         (parseAttributeBlock):
1223         (parseFuncDecl):
1224         (parseFuncDef):
1225         (parseNativeFunc):
1226         * WebGPUShadingLanguageRI/SPIRV.html:
1227         * WebGPUShadingLanguageRI/StatementCloner.js:
1228         (StatementCloner.prototype.visitFuncDef):
1229         (StatementCloner.prototype.visitFuncNumThreadsAttribute):
1230         (StatementCloner):
1231         * WebGPUShadingLanguageRI/Test.html:
1232         * WebGPUShadingLanguageRI/Test.js:
1233         (tests.numThreads):
1234         * WebGPUShadingLanguageRI/Visitor.js:
1235         (Visitor.prototype.visitFunc):
1236         (Visitor.prototype.visitFuncNumThreadsAttribute):
1237         (Visitor):
1238         * WebGPUShadingLanguageRI/index.html:
1239
1240 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
1241
1242         Native functions which accept pointers need to do null checks
1243         https://bugs.webkit.org/show_bug.cgi?id=189883
1244
1245         Reviewed by Dean Jackson.
1246
1247         Simply guard all the places where we write through an author-provided pointer.
1248
1249         * WebGPUShadingLanguageRI/Intrinsics.js:
1250         (Intrinsics.):
1251         * WebGPUShadingLanguageRI/Test.js:
1252         (tests.textureDimensionsNull):
1253
1254 2018-09-22  Myles C. Maxfield  <mmaxfield@apple.com>
1255
1256         [WHLSL] Implement atomic operations and barriers
1257         https://bugs.webkit.org/show_bug.cgi?id=189025
1258
1259         Reviewed by Dean Jackson.
1260
1261         In the interpreter, atomic operations don't need to be atomic.
1262
1263         * WebGPUShadingLanguageRI/Intrinsics.js:
1264         (Intrinsics.):
1265         * WebGPUShadingLanguageRI/StandardLibrary.js:
1266         (let.standardLibrary):
1267         * WebGPUShadingLanguageRI/Test.js:
1268         (tests.atomics):
1269
1270 2018-09-22  Thibault Saunier  <tsaunier@igalia.com>
1271
1272         [WPE] Be very permissive in the MiniBrowser.
1273         https://bugs.webkit.org/show_bug.cgi?id=189800
1274
1275         This is just a test tool and we should make
1276         it just work, security and privacy is not really
1277         a primary focus here.
1278
1279         Reviewed by Žan Doberšek.
1280
1281         * MiniBrowser/wpe/main.cpp:
1282         (decidePermissionRequest):
1283         (main):
1284
1285 2018-09-21  Thomas Denney  <tdenney@apple.com>
1286
1287         [WHLSL] Local variables should be statically allocated
1288         https://bugs.webkit.org/show_bug.cgi?id=188402
1289
1290         Reviewed by Myles C. Maxfield.
1291
1292         An additional preparation stage is now performed so that all local
1293         variables and function parameters are allocated in a single struct at
1294         entry points. A pointer to this struct is then passed for function
1295         calls.
1296
1297         * WebGPUShadingLanguageRI/All.js: Update dependencies.
1298         * WebGPUShadingLanguageRI/AllocateAtEntryPoints.js: Added new stage.
1299         * WebGPUShadingLanguageRI/CallExpression.js:
1300         (CallExpression.prototype.set argumentList): Add setter because
1301         allocateAtEntryPoints needs to change this.
1302         * WebGPUShadingLanguageRI/EBufferBuilder.js: Remove a redundant
1303         constructor that wasn't used anywhere.
1304         * WebGPUShadingLanguageRI/Func.js:
1305         (Func.prototype.set parameters): Add setter.
1306         * WebGPUShadingLanguageRI/FuncDef.js:
1307         (FuncDef.prototype.set body): Ditto.
1308         * WebGPUShadingLanguageRI/Prepare.js:
1309         (let.prepare): Add call to allocateAtEntryPoints. This call cannot
1310         happen any earlier because it depends on having types for call
1311         arguments.
1312         * WebGPUShadingLanguageRI/Rewriter.js:
1313         (Rewriter.prototype.visitReturn): Resolve issue where the return
1314         statement's function wasn't copied. A null check is required as the
1315         Rewriter might be used before this property is set.
1316         * WebGPUShadingLanguageRI/SPIRV.html: Update dependencies.
1317         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js: Abstracted logic
1318         into a separate function so that allocateAtEntryPoints can create the
1319         accessors for the struct type it introduces.
1320         * WebGPUShadingLanguageRI/Test.html: Update dependencies.
1321         * WebGPUShadingLanguageRI/Test.js: Add new tests to verify the static
1322         allocation transform works safely.
1323         * WebGPUShadingLanguageRI/index.html: Update dependencies.
1324
1325 2018-09-21  Jonathan Bedard  <jbedard@apple.com>
1326
1327         Bring up queues for iOS 12 (Build fix)
1328         https://bugs.webkit.org/show_bug.cgi?id=189683
1329
1330         Unreviewed build fix.
1331
1332         We should not build ImageDiff as x86 by default since 32 bit projects are
1333         deprecated in Xcode. ImageDiff should only be built once.
1334
1335         * Scripts/build-webkit:
1336         * Scripts/webkitdirs.pm:
1337         (argumentsForConfiguration):
1338
1339 2018-09-21  Adrian Perez de Castro  <aperez@igalia.com>
1340
1341         [WPE] Built RPM of WPE webkit fails to install with "nothing provides libWPEToolingBackends.so()"
1342         https://bugs.webkit.org/show_bug.cgi?id=189797
1343
1344         Reviewed by Žan Doberšek.
1345
1346         * wpe/backends/CMakeLists.txt: Make libWPEToolingBackends a static library to avoid
1347         the need for installing it. This works fine because the library only contains utility
1348         code intended to be reused from other various components (MiniBrowser, WebKitTestRunner).
1349
1350 2018-09-20  Daniel Bates  <dabates@apple.com>
1351
1352         Move IOKitSPI.h from TestRunnerShared to PAL
1353         https://bugs.webkit.org/show_bug.cgi?id=189804
1354
1355         Reviewed by Wenson Hsieh.
1356
1357         Towards fixing <https://bugs.webkit.org/show_bug.cgi?id=189604> move the IOKit SPI forward
1358         declarations to PAL so that they can be shared by WebKit, DumpRenderTree and WebKitTestRunner.
1359
1360         No functionality changed. So, no new tests.
1361
1362         * TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:
1363         * TestRunnerShared/spi/UIKitTestSPI.h:
1364         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1365         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1366
1367 2018-09-20  Thomas Denney  <tdenney@apple.com>
1368
1369         [WHLSL] Metal code generation
1370         https://bugs.webkit.org/show_bug.cgi?id=187735
1371
1372         Reviewed by Myles C. Maxfield.
1373
1374         Adds support for generating Metal Shading Language from WHLSL. Clients
1375         should include the file MetalCodegenAll.js and then call whlslToMsl
1376         with their program source code to compile to Metal.
1377
1378         * WebGPUShadingLanguageRI/ArrayType.js:
1379         (ArrayType.prototype.get arrayRefType): Adds the arrayRefType method to
1380         all types to find the type of that expression when it is used in a
1381         MakeArrayRefExpression.
1382         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js:
1383         (MakeArrayRefExpression):
1384         (MakeArrayRefExpression.prototype.get type): Uses the new arrayRefType
1385         getter on all types to find the type of the expression.
1386         * WebGPUShadingLanguageRI/Metal/MSLBackend.js: Added.
1387         * WebGPUShadingLanguageRI/Metal/MSLCodegenAll.js: Added.
1388         * WebGPUShadingLanguageRI/Metal/MSLCompileResult.js: Added.
1389         * WebGPUShadingLanguageRI/Metal/MSLConstexprEmitter.js: Added.
1390         * WebGPUShadingLanguageRI/Metal/MSLFunctionDeclaration.js: Added.
1391         * WebGPUShadingLanguageRI/Metal/MSLFunctionDefinition.js: Added.
1392         * WebGPUShadingLanguageRI/Metal/MSLFunctionForwardDeclaration.js: Added.
1393         * WebGPUShadingLanguageRI/Metal/MSLNameMangler.js: Added.
1394         * WebGPUShadingLanguageRI/Metal/MSLNativeFunctionCall.js: Added.
1395         * WebGPUShadingLanguageRI/Metal/MSLStatementEmitter.js: Added.
1396         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributes.js: Added.
1397         * WebGPUShadingLanguageRI/Metal/MSLTypeAttributesMap.js: Added.
1398         * WebGPUShadingLanguageRI/Metal/MSLTypeUnifier.js: Added.
1399         * WebGPUShadingLanguageRI/Metal/TypeOf.js: Added.
1400         * WebGPUShadingLanguageRI/Metal/WhlslToMsl.js: Added.
1401         * WebGPUShadingLanguageRI/PropertyResolver.js:
1402         * WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:
1403         * WebGPUShadingLanguageRI/Test.js: Added awkward tests for the compiler
1404         to generate code for.
1405         (tests.incrementAndDecrement):
1406         (tests.returnIntLiteralUint):
1407         (tests.returnIntLiteralFloat):
1408         (tests.nestedSubscriptWithArraysInStructs):
1409         (tests.nestedSubscript):
1410         (tests.lotsOfLocalVariables):
1411         * WebGPUShadingLanguageRI/Type.js:
1412         (Type.prototype.get arrayRefType): See above.
1413
1414 2018-09-20  Ryan Haddad  <ryanhaddad@apple.com>
1415
1416         Bring up queues for iOS 12
1417         https://bugs.webkit.org/show_bug.cgi?id=189683
1418
1419         Unreviewed infrastructure fix.
1420
1421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12@2x.png: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png.
1422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1423         (BubbleQueueServer): Move EWS bubbles to the iOS 12 section of the dashboard.
1424
1425 2018-09-20  Ryan Haddad  <ryanhaddad@apple.com>
1426
1427         Bring up queues for iOS 12
1428         https://bugs.webkit.org/show_bug.cgi?id=189683
1429
1430         Reviewed by Aakash Jain.
1431
1432         * BuildSlaveSupport/build.webkit.org-config/config.json:
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12.png: Added.
1434         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator.png: Added.
1435         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS12Simulator@2x.png: Added.
1436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/iOS12@2x.png: Added.
1437         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1439         (WebKitBuildbot):
1440         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1441         (table.queue-grid tr.platform.ios-simulator-12 img.logo):
1442         (table.queue-grid tr.platform.ios-12 img.logo):
1443         (table.queue-grid tr.platform.ios-simulator-11 img.logo): Deleted.
1444         (table.queue-grid tr.platform.ios-11 img.logo): Deleted.
1445         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1446         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1447         (_should_file_trigger_build):
1448         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1449         (ShouldBuildTest):
1450         (ShouldBuildTest.test_should_build):
1451
1452 2018-09-20  Basuke Suzuki  <Basuke.Suzuki@sony.com>
1453
1454         [Win] TestRunner::queueLoad() fails to generate correct url for some urls.
1455         https://bugs.webkit.org/show_bug.cgi?id=189679
1456
1457         Reviewed by Fujii Hironori.
1458
1459         Replace the implementation with correct API call.
1460
1461         * DumpRenderTree/win/TestRunnerWin.cpp:
1462         (TestRunner::queueLoad): Call UrlCombineW.
1463
1464 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1465
1466         [WPE] fails to build on ARM arches complaining about undefined reference to `epoxy_eglMakeCurrent'
1467         https://bugs.webkit.org/show_bug.cgi?id=189556
1468
1469         Reviewed by Konstantin Tokarev.
1470
1471         This is only a speculative build fix as I didn't attempt to reproduce. Explicitly link to
1472         libepoxy.
1473
1474         * wpe/backends/CMakeLists.txt:
1475
1476 2018-09-20  Daniel Bates  <dabates@apple.com>
1477
1478         [iOS] Support testing more hardware special keys
1479         https://bugs.webkit.org/show_bug.cgi?id=189793
1480
1481         Reviewed by Simon Fraser.
1482
1483         * TestRunnerShared/spi/IOKitSPI.h: Add more SPI constants.
1484         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1485         (keyCodeForDOMFunctionKey): Extracted out logic from hidUsageCodeForCharacter() to return the
1486         key code for the F1, F2, ..., F12 keys and extended the code to compute the key code for the
1487         F13, F14, ..., F24 keys.
1488         (hidUsageCodeForCharacter): Modified to call keyCodeForDOMFunctionKey().
1489
1490 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1491
1492         Unreviewed, remove accidentally-committed debugging changes from flatpakutils script
1493
1494         Aaaaaah maybe this is why changes are supposed to be reviewed.
1495
1496         * flatpak/flatpakutils.py:
1497         (WebkitFlatpak.clean_args):
1498
1499 2018-09-20  Michael Catanzaro  <mcatanzaro@igalia.com>
1500
1501         Unreviewed, manually rollout our switch to master runtime
1502
1503         Phil wants html5-codecs, which aren't available yet here. Let's switch back to 3.28 in the
1504         meantime, where we were already building GStreamer ourselves anyway. But use an updated
1505         SDK revision.
1506
1507         * flatpak/files/httpd-autogen.sh: Added.
1508         * flatpak/flatpakutils.py:
1509         (WebkitFlatpak.clean_args):
1510         * flatpak/org.webkit.GTK.yaml:
1511         * flatpak/org.webkit.WebKit.yaml:
1512         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
1513         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Added.
1514
1515 2018-09-20  Thibault Saunier  <tsaunier@igalia.com>
1516
1517         [WPE][GTK] webkit-flatpak intercepts --help for other commands
1518         https://bugs.webkit.org/show_bug.cgi?id=189058
1519
1520         The approach of run_in_sandbox_if_available is that we basically have the
1521         same set of arguments to setup the sandbox (ie. port name, build type, etc...)
1522         and we can pass those args first to setup the flatpak launcher object
1523         and then to the underlying script. That doesn't work well with the `--help` argument
1524         as once processed it 1. prints the help (which make no sense to the user of the calling script)
1525         2. exits the app - The solution is to just make sure that `--help` is not used when using
1526         flatpakutils from any script that is not `webkit-flatpak` itself.
1527
1528         Reviewed by Michael Catanzaro.
1529
1530         * flatpak/flatpakutils.py:
1531         (WebkitFlatpak.load_from_args):
1532         (run_in_sandbox_if_available):
1533
1534 2018-09-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1535
1536         Unreviewed. Add W3C imported tests to the MSEEME watchlist.
1537
1538         * Scripts/webkitpy/common/config/watchlist:
1539
1540 2018-09-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1541
1542         Unreviewed. Fix the Streams API watchlist.
1543
1544         * Scripts/webkitpy/common/config/watchlist:
1545
1546 2018-09-19  Chris Dumez  <cdumez@apple.com>
1547
1548         Crash under WebProcessProxy::suspendedPageWasDestroyed(WebKit::SuspendedPageProxy&)
1549         https://bugs.webkit.org/show_bug.cgi?id=189721
1550         <rdar://problem/44359788>
1551
1552         Reviewed by Geoffrey Garen.
1553
1554         Add API test coverage.
1555
1556         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1557
1558 2018-09-19  Thomas Denney  <tdenney@apple.com>
1559
1560         [WHLSL] Improve test suite type safety
1561         https://bugs.webkit.org/show_bug.cgi?id=189502
1562
1563         Reviewed by Myles C. Maxfield.
1564
1565         Each of the 'makeT' functions now call the relevant cast function on the
1566         value before hand. The checkNumber function has also been removed and
1567         its uses have been replaced with functions that also check the type.
1568         Some of the arithmetic checks have been updated to reflect that the
1569         casts happen outside of WHLSL evaluation. Other tests have also been
1570         updated to reflect that some values cannot be precisely expressed in
1571         32-bit floating point.
1572
1573         * WebGPUShadingLanguageRI/Casts.js:
1574         (castToBool): Added.
1575         (castAndCheckValue): Added.
1576         (isBitwiseEquivalent): Moved from Intrinsics.js.
1577         * WebGPUShadingLanguageRI/Intrinsics.js: Ditto.
1578         * WebGPUShadingLanguageRI/SPIRV.html: Update depdencies.
1579         * WebGPUShadingLanguageRI/Test.html: Ditto.
1580         * WebGPUShadingLanguageRI/Test.js: Update makeT functions to do a cast
1581         and check the result. Some tests were also updated to reflect the change
1582         in the behavior of these functions.
1583         * WebGPUShadingLanguageRI/index.html: Update dependencies.
1584
1585 2018-09-19  John Wilander  <wilander@apple.com>
1586
1587         Resource Load Statistics: Add optional cap on partitioned cache max age
1588         https://bugs.webkit.org/show_bug.cgi?id=189711
1589         <rdar://problem/39246837>
1590
1591         Reviewed by Antti Koivisto and Chris Dumez.
1592
1593         This change adds infrastructure for layout tests of capped cache max age.
1594
1595         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1596         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1597         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1598         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1599         * WebKitTestRunner/TestController.cpp:
1600         (WTR::TestController::setStatisticsCacheMaxAgeCap):
1601         * WebKitTestRunner/TestController.h:
1602         * WebKitTestRunner/TestInvocation.cpp:
1603         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1604
1605 2018-09-19  Dawei Fenton  <realdawei@apple.com>
1606
1607        Unreviewed. Update my email and alias in list of contributors.
1608
1609         * Scripts/webkitpy/common/config/contributors.json:
1610
1611 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1612
1613         [WPE][GTK] Unreviewed, try #3 to fix a typo
1614
1615         I feel like Charlie Brown, how hard this has been for me....
1616
1617         * Scripts/run-minibrowser:
1618         * Scripts/webkitdirs.pm:
1619         (runInFlatpakIfAvailable):
1620         (runInFlatpakIfAvailible): Deleted.
1621
1622 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1623
1624         [WPE][GTK] Unreviewed, fix that typo in more places
1625
1626         It got copied into webkitdirs.pm!
1627
1628         * Scripts/webkitdirs.pm:
1629         (runInFlatpakIfAvailible):
1630         (runInFlatpakIfAvalaible): Deleted.
1631
1632 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1633
1634         [WPE][GTK] Unreviewed, fix a pervasive typo in the webkit-flatpak script
1635
1636         * flatpak/flatpakutils.py:
1637         (WebkitFlatpak.load_from_args):
1638         (WebkitFlatpak.__init__):
1639         (WebkitFlatpak.run):
1640
1641 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1642
1643         [WPE][GTK] Unreviewed, update to latest GNOME SDK
1644
1645         * flatpak/org.webkit.WebKit.yaml:
1646
1647 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1648
1649         Unreviewed, rolling out r235500.
1650
1651         Time to switch back to master runtime
1652
1653         Reverted changeset:
1654
1655         "Unreviewed, rolling out r235114."
1656         https://bugs.webkit.org/show_bug.cgi?id=188731
1657         https://trac.webkit.org/changeset/235500
1658
1659 2018-09-19  Adrian Perez de Castro  <aperez@igalia.com>
1660
1661         Unreviewed. Add Pablo Saavedra to the list of contributors.
1662
1663         * Scripts/webkitpy/common/config/contributors.json:
1664
1665 2018-09-19  Philippe Normand  <pnormand@igalia.com>
1666
1667         [GStreamer] Add support for AV1 decoding
1668         https://bugs.webkit.org/show_bug.cgi?id=189647
1669
1670         Reviewed by Žan Doberšek.
1671
1672         Add patches required for AV1 decoding support. They're all
1673         upstream already and will be shipped in GStreamer 1.16. The aom
1674         GStreamer plugin depends on the aom library for which there's no
1675         official release yet.
1676
1677         * gstreamer/jhbuild.modules:
1678         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Added.
1679         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Added.
1680         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Added. This one is unrelated but an implicit dependency of the next one.
1681         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Added.
1682         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Added.
1683         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Added.
1684
1685 2018-09-18  Jonathan Bedard  <jbedard@apple.com>
1686
1687         webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports
1688         https://bugs.webkit.org/show_bug.cgi?id=189702
1689         <rdar://problem/44541704>
1690
1691         Reviewed by Aakash Jain.
1692
1693         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1694         (Manager._set_up_run): Move build check and clobbering to run, since set up is
1695         run multiple times for iOS simulator.
1696         (Manager.run):
1697
1698 2018-09-18  Chris Dumez  <cdumez@apple.com>
1699
1700         "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache
1701         https://bugs.webkit.org/show_bug.cgi?id=189681
1702         <rdar://problem/44526171>
1703
1704         Reviewed by Alex Christensen and Zalan Bujtas.
1705
1706         Add API test coverage.
1707
1708         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1709         (TestWebKitAPI::didFinishNavigation):
1710         (TestWebKitAPI::TEST):
1711
1712 2018-09-18  Claudio Saavedra  <csaavedra@igalia.com>
1713
1714         [WPE] Implement mouse event modifiers
1715         https://bugs.webkit.org/show_bug.cgi?id=189697
1716
1717         Reviewed by Carlos Garcia Campos.
1718
1719         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
1720         (WTR::wkEventModifiersToWPE):
1721         (WTR::EventSenderProxy::mouseDown):
1722         (WTR::EventSenderProxy::mouseUp):
1723
1724 2018-09-17  Yusuke Suzuki  <utatane.tea@gmail.com>
1725
1726         [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
1727         https://bugs.webkit.org/show_bug.cgi?id=185339
1728
1729         Reviewed by Mark Lam.
1730
1731         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
1732         (TestWebKitAPI::ToUpperConverter::stopProducing):
1733         (TestWebKitAPI::ToUpperConverter::stopConsuming):
1734
1735 2018-09-17  Simon Fraser  <simon.fraser@apple.com>
1736
1737         Many modern media control tests leak documents in testing
1738         https://bugs.webkit.org/show_bug.cgi?id=189437
1739
1740         Reviewed by Darin Adler.
1741         
1742         In order to accurately detect leaks in media controls tests which use lots of
1743         SVGImages, we have to:
1744         - Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
1745           to clear references to elements.
1746         - Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
1747           to drop the last handle to the CachedResource for an SVGImage.
1748         - Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
1749           to run again after that timer has fired.
1750         
1751         This should fix most of the spurious leak reports involving SVGImage documents.
1752
1753         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1754         (WTR::InjectedBundle::reportLiveDocuments):
1755         (WTR::InjectedBundle::didReceiveMessageToPage):
1756
1757 2018-09-17  Chris Dumez  <cdumez@apple.com>
1758
1759         PSON: window.open() with 'noopener' should only process-swap cross-site, not cross-origin
1760         https://bugs.webkit.org/show_bug.cgi?id=189602
1761         <rdar://problem/44430549>
1762
1763         Reviewed by Geoff Garen.
1764
1765         Add API test coverage.
1766
1767         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1768
1769 2018-09-17  Philippe Normand  <pnormand@igalia.com>
1770
1771         [JHBuild] Update to GStreamer 1.14.3
1772         https://bugs.webkit.org/show_bug.cgi?id=189450
1773
1774         Reviewed by Xabier Rodriguez-Calvar.
1775
1776         * gstreamer/jhbuild.modules: Bump GStreamer modules from 1.14.1 to 1.14.3.
1777
1778 2018-09-17  Philippe Normand  <pnormand@igalia.com>
1779
1780         [JHBuild] Doesn't check sha256 sums
1781         https://bugs.webkit.org/show_bug.cgi?id=189646
1782
1783         Reviewed by Michael Catanzaro.
1784
1785         * gstreamer/jhbuild.modules: Properly set the sha256: prefix on hashes.
1786
1787 2018-09-17  Sihui Liu  <sihui_liu@apple.com>
1788
1789         Move IndexedDB to Network Process
1790         https://bugs.webkit.org/show_bug.cgi?id=189415
1791         <rdar://problem/44396973>
1792
1793         Reviewed by Chris Dumez.
1794
1795         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
1796         (TEST):
1797         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
1798         (TEST):
1799         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
1800         (TEST):
1801         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
1802         (TEST):
1803         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
1804         (TEST):
1805
1806 2018-09-08  Darin Adler  <darin@apple.com>
1807
1808         Streamline JSRetainPtr, fix leaks of JSString and JSGlobalContext
1809         https://bugs.webkit.org/show_bug.cgi?id=189455
1810
1811         Reviewed by Keith Miller.
1812
1813         There is a lot of copied and pasted code for WebKit vs. Legacy WebKit
1814         testing and even for macOS vs. iOS vs. Windows platform-specific code.
1815         For now, this patch just makes corresponding changes to the copied code.
1816         Later we might get better results by merging more code instead of having
1817         all these separate copies.
1818
1819         * DumpRenderTree/AccessibilityController.cpp:
1820         (AccessibilityController::makeWindowObject): Use the adopt function
1821         instead of the special Adopt constructor of JSRetainPtr.
1822
1823         * DumpRenderTree/AccessibilityTextMarker.cpp: Removed unneeded include.
1824
1825         * DumpRenderTree/AccessibilityUIElement.cpp: Ditto.
1826         (allAttributesCallback): Don't adopt at this level; changed the
1827         underlying function to return a JSRetainPtr so the adopt is right next
1828         to the call to the create or copy function.
1829         (attributesOfLinkedUIElementsCallback): Ditto.
1830         (attributesOfDocumentLinksCallback): Ditto.
1831         (attributesOfChildrenCallback): Ditto.
1832         (parameterizedAttributeNamesCallback): Ditto.
1833         (attributesOfColumnHeadersCallback): Ditto.
1834         (attributesOfRowHeadersCallback): Ditto.
1835         (attributesOfColumnsCallback): Ditto.
1836         (attributesOfRowsCallback): Ditto.
1837         (attributesOfVisibleCellsCallback): Ditto.
1838         (attributesOfHeaderCallback): Ditto.
1839         (rowIndexRangeCallback): Ditto.
1840         (columnIndexRangeCallback): Ditto.
1841         (rangeForLineCallback): Ditto.
1842         (boundsForRangeCallback): Ditto.
1843         (rangeForPositionCallback): Ditto.
1844         (stringForRangeCallback): Ditto.
1845         (attributedStringForRangeCallback): Ditto.
1846         (uiElementCountForSearchPredicateCallback): Use the free adopt
1847         function instead of the adopt member function.
1848         (uiElementForSearchPredicateCallback): Ditto.
1849         (selectTextWithCriteriaCallback): Don't adopt at this level.
1850         (attributedStringForElementCallback): Ditto.
1851         (setValueCallback): Use free adopt.
1852         (stringAttributeValueCallback): Don't adopt at this level.
1853         (uiElementArrayAttributeValueCallback): Ditto.
1854         (uiElementAttributeValueCallback): Ditto.
1855         (stringForTextMarkerRangeCallback): Ditto.
1856         (attributedStringForTextMarkerRangeCallback): Ditto.
1857         (attributedStringForTextMarkerRangeWithOptionsCallback): Ditto.
1858         (getARIADropEffectsCallback): Ditto.
1859         (getClassListCallback): Ditto.
1860         (getRoleCallback): Ditto.
1861         (getSubroleCallback): Ditto.
1862         (getRoleDescriptionCallback): Ditto.
1863         (getComputedRoleStringCallback): Ditto.
1864         (getTitleCallback): Ditto.
1865         (getDescriptionCallback): Ditto.
1866         (getStringValueCallback): Ditto.
1867         (getLanguageCallback): Ditto.
1868         (getHelpTextCallback): Ditto.
1869         (getOrientationCallback): Ditto.
1870         (getPathDescriptionCallback): Ditto.
1871         (getSelectedTextRangeCallback): Ditto.
1872         (speakAsCallback): Ditto.
1873         (getValueDescriptionCallback): Ditto.
1874         (getAccessibilityValueCallback): Ditto.
1875         (getDocumentEncodingCallback): Ditto.
1876         (getDocumentURICallback): Ditto.
1877         (getURLCallback): Ditto.
1878         (characterAtOffsetCallback): Ditto.
1879         (wordAtOffsetCallback): Ditto.
1880         (lineAtOffsetCallback): Ditto.
1881         (sentenceAtOffsetCallback): Ditto.
1882         (stringForSelectionCallback): Ditto.
1883         (getIdentifierCallback): Ditto.
1884         (getTraitsCallback): Ditto.
1885         (supportedActionsCallback): Ditto.
1886         (mathPostscriptsDescriptionCallback): Ditto.
1887         (mathPrescriptsDescriptionCallback): Ditto.
1888         (AccessibilityUIElement::rangeForLine): Updated to return JSRetainPtr.
1889         (AccessibilityUIElement::rangeForPosition): Ditto.
1890         (AccessibilityUIElement::speakAs): Ditto.
1891         (AccessibilityUIElement::pathDescription const): Ditto.
1892         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
1893         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
1894         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
1895
1896         * DumpRenderTree/AccessibilityUIElement.h: Use JSRetainPtr instead of
1897         raw pointers for the results of the functions that create strings.
1898         The old way was difficult to get right; the functions didn't even follow
1899         the create/copy naming rule.
1900
1901         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
1902         (_platformTypeConstructor): Use the adopt function instead of the
1903         JSRetainPtr adopt constructor. Also nullptr instead of 0.
1904
1905         * DumpRenderTree/GCController.cpp:
1906         (GCController::makeWindowObject): Use adopt function instead of constructor.
1907
1908         * DumpRenderTree/TestRunner.cpp:
1909         (pathToLocalResourceCallback): Use adopt function instead of constructor.
1910         (addDisallowedURLCallback): Ditto.
1911         (addURLToRedirectCallback): Ditto.
1912         (clearApplicationCacheForOriginCallback): Ditto.
1913         (applicationCacheDiskUsageForOriginCallback): Ditto.
1914         (decodeHostNameCallback): Don't adopt at this level.
1915         (encodeHostNameCallback): Ditto.
1916         (execCommandCallback): Use adopt instead of JSRetainPtr::adopt.
1917         (findStringCallback): Use adopt function instead of constructor.
1918         (isCommandEnabledCallback): Ditto.
1919         (overridePreferenceCallback): Ditto.
1920         (queueLoadCallback): Ditto.
1921         (queueLoadHTMLStringCallback): Ditto.
1922         (queueLoadingScriptCallback): Ditto.
1923         (queueNonLoadingScriptCallback): Ditto.
1924         (setAuthenticationPasswordCallback): Ditto.
1925         (setAuthenticationUsernameCallback): Ditto.
1926         (setDomainRelaxationForbiddenForURLSchemeCallback): Ditto.
1927         (setMockGeolocationPositionUnavailableErrorCallback): Ditto.
1928         (setPOSIXLocaleCallback): Ditto.
1929         (setPersistentUserStyleSheetLocationCallback): Ditto.
1930         (setUserStyleSheetLocationCallback): Ditto.
1931         (setValueForUserCallback): Ditto.
1932         (setWillSendRequestClearHeaderCallback): Ditto.
1933         (setPageVisibilityCallback): Ditto.
1934         (evaluateInWebInspectorCallback): Ditto.
1935         (evaluateScriptInIsolatedWorldCallback): Ditto.
1936         (evaluateScriptInIsolatedWorldAndReturnValueCallback): Ditto.
1937         (addOriginAccessWhitelistEntryCallback): Ditto.
1938         (removeOriginAccessWhitelistEntryCallback): Ditto.
1939         (setScrollbarPolicyCallback): Ditto.
1940         (addUserScriptCallback): Ditto.
1941         (addUserStyleSheetCallback): Ditto.
1942         (apiTestNewWindowDataLoadBaseURLCallback): Ditto.
1943         (authenticateSessionCallback): Ditto.
1944         (getTitleTextDirectionCallback): Ditto.
1945         (getInspectorTestStubURLCallback): Ditto.
1946         (simulateLegacyWebNotificationClickCallback): Ditto.
1947         (setTextDirectionCallback): Ditto.
1948         (grantWebNotificationPermissionCallback): Ditto.
1949         (denyWebNotificationPermissionCallback): Ditto.
1950         (accummulateLogsForChannel): Ditto.
1951         (runUIScriptCallback): Ditto.
1952         (TestRunner::makeWindowObject): Ditto.
1953         (TestRunner::uiScriptDidComplete): Ditto.
1954         (TestRunner::setOpenPanelFiles): Ditto.
1955
1956         * DumpRenderTree/TestRunner.h: Use JSRetainPtr instead of
1957         raw pointers for the results of the functions that create strings.
1958
1959         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1960         (AccessibilityController::platformName const): Use the adopt
1961         function instead of the adopt constructor.
1962
1963         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1964         (createEmptyJSString): Added. This helper function makes reduces the
1965         repetitive code to create empty strings.
1966         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
1967         (AccessibilityUIElement::identifier): Ditto.
1968         (AccessibilityUIElement::traits): Ditto.
1969         (AccessibilityUIElement::url): Ditto.
1970         (AccessibilityUIElement::speakAs): Ditto.
1971         (AccessibilityUIElement::stringForSelection): Ditto.
1972         (AccessibilityUIElement::stringForRange): Ditto.
1973         (AccessibilityUIElement::attributedStringForRange): Ditto.
1974         (AccessibilityUIElement::attributedStringForElement): Ditto.
1975         (AccessibilityUIElement::pathDescription const): Ditto.
1976         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
1977         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
1978         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
1979         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
1980         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
1981         (AccessibilityUIElement::attributesOfChildren): Ditto.
1982         (AccessibilityUIElement::allAttributes): Ditto.
1983         (AccessibilityUIElement::stringAttributeValue): Ditto.
1984         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
1985         (AccessibilityUIElement::role): Ditto.
1986         (AccessibilityUIElement::subrole): Ditto.
1987         (AccessibilityUIElement::roleDescription): Ditto.
1988         (AccessibilityUIElement::computedRoleString): Ditto.
1989         (AccessibilityUIElement::title): Ditto.
1990         (AccessibilityUIElement::description): Ditto.
1991         (AccessibilityUIElement::orientation const): Ditto.
1992         (AccessibilityUIElement::stringValue): Ditto.
1993         (AccessibilityUIElement::language): Ditto.
1994         (AccessibilityUIElement::helpText const): Ditto.
1995         (AccessibilityUIElement::valueDescription): Ditto.
1996         (AccessibilityUIElement::ariaDropEffects const): Ditto.
1997         (AccessibilityUIElement::boundsForRange): Ditto.
1998         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
1999         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
2000         (AccessibilityUIElement::attributesOfColumns): Ditto.
2001         (AccessibilityUIElement::attributesOfRows): Ditto.
2002         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
2003         (AccessibilityUIElement::attributesOfHeader): Ditto.
2004         (AccessibilityUIElement::rowIndexRange): Ditto.
2005         (AccessibilityUIElement::columnIndexRange): Ditto.
2006         (AccessibilityUIElement::selectedTextRange): Ditto.
2007         (AccessibilityUIElement::accessibilityValue const): Ditto.
2008         (AccessibilityUIElement::documentEncoding): Ditto.
2009         (AccessibilityUIElement::documentURI): Ditto.
2010         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
2011         (AccessibilityUIElement::classList const): Ditto.
2012
2013         * DumpRenderTree/mac/AccessibilityCommonMac.h: Changed the
2014         createJSStringRef method to return a JSRetainPtr.
2015         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
2016         (-[NSString createJSStringRef]): Ditto.
2017         (searchPredicateParameterizedAttributeForSearchCriteria): Use the
2018         adopt function instead of the adopt constructor.
2019         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2020         (AccessibilityController::platformName const): Ditto.
2021
2022         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2023         (-[NSString createJSStringRef]): Return a JSRetainPtr.
2024         (makeValueRefForValue): Updated for the above, no adopt needed here now.
2025         (makeObjectRefForDictionary): Ditto.
2026         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
2027
2028         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2029         (createEmptyJSString): Added. This helper function makes reduces the
2030         repetitive code to create empty strings.
2031         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
2032         (descriptionOfElements): Ditto.
2033         (selectTextParameterizedAttributeForCriteria): Ditto.
2034         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
2035         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
2036         (AccessibilityUIElement::attributesOfChildren): Ditto.
2037         (AccessibilityUIElement::allAttributes): Ditto.
2038         (AccessibilityUIElement::stringAttributeValue): Ditto.
2039         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
2040         (AccessibilityUIElement::role): Ditto.
2041         (AccessibilityUIElement::subrole): Ditto.
2042         (AccessibilityUIElement::roleDescription): Ditto.
2043         (AccessibilityUIElement::computedRoleString): Ditto.
2044         (AccessibilityUIElement::title): Ditto.
2045         (AccessibilityUIElement::description): Ditto.
2046         (AccessibilityUIElement::orientation const): Ditto.
2047         (AccessibilityUIElement::stringValue): Ditto.
2048         (AccessibilityUIElement::language): Ditto.
2049         (AccessibilityUIElement::helpText const): Ditto.
2050         (AccessibilityUIElement::valueDescription): Ditto.
2051         (AccessibilityUIElement::speakAs): Ditto.
2052         (AccessibilityUIElement::classList const): Ditto.
2053         (AccessibilityUIElement::ariaDropEffects const): Ditto.
2054         (AccessibilityUIElement::rangeForLine): Ditto.
2055         (AccessibilityUIElement::rangeForPosition): Ditto.
2056         (AccessibilityUIElement::boundsForRange): Ditto.
2057         (AccessibilityUIElement::stringForRange): Ditto.
2058         (AccessibilityUIElement::attributedStringForRange): Ditto.
2059         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
2060         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
2061         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
2062         (AccessibilityUIElement::attributesOfColumns): Ditto.
2063         (AccessibilityUIElement::attributesOfRows): Ditto.
2064         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
2065         (AccessibilityUIElement::attributesOfHeader): Ditto.
2066         (AccessibilityUIElement::rowIndexRange): Ditto.
2067         (AccessibilityUIElement::columnIndexRange): Ditto.
2068         (AccessibilityUIElement::pathDescription const): Ditto.
2069         (AccessibilityUIElement::selectedTextRange): Ditto.
2070         (AccessibilityUIElement::accessibilityValue const): Ditto.
2071         (AccessibilityUIElement::documentEncoding): Ditto.
2072         (AccessibilityUIElement::documentURI): Ditto.
2073         (AccessibilityUIElement::url): Ditto.
2074         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
2075         (createJSStringRef): Ditto.
2076         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
2077         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
2078         (AccessibilityUIElement::supportedActions): Ditto.
2079         (AccessibilityUIElement::mathPostscriptsDescription const): Ditto.
2080         (AccessibilityUIElement::mathPrescriptsDescription const): Ditto.
2081
2082         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2083         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
2084         Use the adopt function instead of the adopt constructor.
2085         * DumpRenderTree/mac/TestRunnerMac.mm:
2086         (originsArrayToJS): Ditto.
2087         (TestRunner::copyDecodedHostName): Return a JSRetainPtr.
2088         (TestRunner::copyEncodedHostName): Ditto.
2089         (TestRunner::pathToLocalResource): Ditto.
2090         (TestRunner::queueLoad): Use adopt function instead of constructor.
2091         (TestRunner::findString): Ditto.
2092         (TestRunner::inspectorTestStubURL): Return a JSRetainPtr.
2093
2094         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2095         (AccessibilityController::winNotificationReceived): Use adopt function
2096         instead of adopt constructor.
2097         (AccessibilityController::platformName const): Ditto.
2098
2099         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2100         (createEmptyJSString): Added. This helper function makes reduces the
2101         repetitive code to create empty strings.
2102         (AccessibilityUIElement::allAttributes): Changed to return a JSRetainPtr.
2103         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
2104         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
2105         (AccessibilityUIElement::attributesOfChildren): Ditto.
2106         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
2107         (AccessibilityUIElement::role): Ditto.
2108         (AccessibilityUIElement::subrole): Ditto.
2109         (AccessibilityUIElement::roleDescription): Ditto.
2110         (AccessibilityUIElement::computedRoleString): Ditto.
2111         (AccessibilityUIElement::title): Ditto.
2112         (AccessibilityUIElement::description): Ditto.
2113         (AccessibilityUIElement::stringValue): Ditto.
2114         (AccessibilityUIElement::language): Ditto.
2115         (AccessibilityUIElement::helpText const): Ditto.
2116         (AccessibilityUIElement::valueDescription): Ditto.
2117         (AccessibilityUIElement::ariaDropEffects const): Ditto.
2118         (AccessibilityUIElement::orientation const): Ditto.
2119         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
2120         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
2121         (AccessibilityUIElement::attributesOfColumns): Ditto.
2122         (AccessibilityUIElement::attributesOfRows): Ditto.
2123         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
2124         (AccessibilityUIElement::attributesOfHeader): Ditto.
2125         (AccessibilityUIElement::rowIndexRange): Ditto.
2126         (AccessibilityUIElement::columnIndexRange): Ditto.
2127         (AccessibilityUIElement::boundsForRange): Ditto.
2128         (AccessibilityUIElement::stringForRange): Ditto.
2129         (AccessibilityUIElement::attributedStringForRange): Ditto.
2130         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
2131         (AccessibilityUIElement::selectedTextRange): Ditto.
2132         (AccessibilityUIElement::stringAttributeValue): Ditto.
2133         (AccessibilityUIElement::accessibilityValue const): Ditto.
2134         (AccessibilityUIElement::documentEncoding): Ditto.
2135         (AccessibilityUIElement::documentURI): Ditto.
2136         (AccessibilityUIElement::url): Ditto.
2137         (AccessibilityUIElement::classList const): Ditto.
2138
2139         * DumpRenderTree/win/TestRunnerWin.cpp:
2140         (TestRunner::copyDecodedHostName): Changed to return a JSRetainPtr.
2141         (TestRunner::copyEncodedHostName): Ditto.
2142         (TestRunner::pathToLocalResource): Ditto.
2143         (TestRunner::queueLoad): Ditto.
2144         (TestRunner::findString): Ditto.
2145         (TestRunner::inspectorTestStubURL): Ditto.
2146
2147         * TestRunnerShared/Bindings/JSWrapper.h:
2148         (WTR::setProperty): Use adopt function instead of constructor.
2149         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
2150         (UIScriptContext::UIScriptContext): Ditto.
2151         (UIScriptContext::runUIScript): Ditto.
2152         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2153         (WTR::toDeviceOrientation): Ditto.
2154
2155         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2156         (nsTextCheckingType): Changed this function to not take an rvalue
2157         reference to a JSRetainPtr since it doesn't take ownership.
2158         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Updated
2159         for the above change.
2160
2161         * TestWebKitAPI/JavaScriptTest.cpp:
2162         (TestWebKitAPI::javaScriptCallback): Use adopt function instead of
2163         adopt member function.
2164
2165         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp: Removed unneeded include.
2166         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm: Ditto.
2167         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Use adopt function instead of
2168         adopt constructor.
2169         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm: Ditto.
2170
2171         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2172         Removed unneeded includes.
2173         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
2174         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
2175         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
2176
2177         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2178         (_platformTypeConstructor): Use the adopt function instead of the
2179         JSRetainPtr adopt constructor. Also nullptr instead of 0.
2180
2181         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2182         (WTR::arrayLength): Use adopt function instead of constructor.
2183         (WTR::parseModifierArray): Ditto.
2184         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2185         (WTR::propertyValue): Ditto.
2186         (WTR::dumpPath): Ditto.
2187         (WTR::toJS): Ditto.
2188         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2189         (WTR::TestRunner::findString): Ditto.
2190         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Ditto.
2191         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Ditto.
2192         (WTR::TestRunner::setOpenPanelFiles): Ditto.
2193         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
2194         (WTR::AccessibilityController::platformName): Ditto.
2195
2196         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2197         (-[NSString createJSStringRef]): Return a JSRetainPtr.
2198         This fixes storage leaks in many functions below, which were using
2199         the create function and putting the value right into a JSRetainPtr
2200         without adoption.
2201         (WTR::createEmptyJSString): Added. This helper function reduces the
2202         repetitive code to create empty strings.
2203         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
2204         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
2205         Use createEmptyJSString, fixing a storage leak due to missing adoption.
2206         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
2207         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
2208         (WTR::AccessibilityUIElement::allAttributes): Ditto.
2209         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
2210         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Ditto.
2211         (WTR::AccessibilityUIElement::role): Ditto.
2212         (WTR::AccessibilityUIElement::subrole): Ditto.
2213         (WTR::AccessibilityUIElement::roleDescription): Ditto.
2214         (WTR::AccessibilityUIElement::computedRoleString): Ditto.
2215         (WTR::AccessibilityUIElement::title): Ditto.
2216         (WTR::AccessibilityUIElement::orientation const): Ditto.
2217         (WTR::AccessibilityUIElement::language): Ditto.
2218         (WTR::AccessibilityUIElement::valueDescription): Ditto.
2219         (WTR::AccessibilityUIElement::ariaDropEffects const): Ditto.
2220         (WTR::AccessibilityUIElement::boundsForRange): Ditto.
2221         (WTR::AccessibilityUIElement::stringForRange): Removed unneeded null check.
2222         (WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
2223         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
2224         Use createEmptyJSString, fixing a storage leak due to missing adoption.
2225         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Ditto.
2226         (WTR::AccessibilityUIElement::attributesOfColumns): Ditto.
2227         (WTR::AccessibilityUIElement::attributesOfRows): Ditto.
2228         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Ditto.
2229         (WTR::AccessibilityUIElement::attributesOfHeader): Ditto.
2230         (WTR::AccessibilityUIElement::selectedTextRange): Ditto.
2231         (WTR::AccessibilityUIElement::accessibilityValue const): Ditto.
2232         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2233         (WTR::AccessibilityUIElement::documentURI): Ditto.
2234         (WTR::AccessibilityUIElement::stringForSelection): Removed unneeded
2235         null check.
2236         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
2237         Use createEmptyJSString, fixing a storage leak due to missing adoption.
2238
2239         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
2240         Use JSRetainPtr for the return value of createJSStringRef.
2241         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
2242         (-[NSString createJSStringRef]): Ditto.
2243         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Use the
2244         adopt function instead of the adopt constructor.
2245         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2246         (WTR::AccessibilityController::platformName): Ditto
2247
2248         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2249         (-[NSString createJSStringRef]): Return a JSRetainPtr.
2250         (makeValueRefForValue): Updated for above by removing adopt.
2251         (makeObjectRefForDictionary): Ditto.
2252         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
2253
2254         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2255         (WTR::createEmptyJSString): Added. This helper function makes reduces the
2256         repetitive code to create empty strings.
2257         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
2258         (WTR::descriptionOfElements): Ditto.
2259         (WTR::selectTextParameterizedAttributeForCriteria): Ditto.
2260         (WTR::AccessibilityUIElement::accessibilityValue const): Use createEmptyJSString,
2261         fixing a storage leak due to missing adoption.
2262         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
2263         (WTR::AccessibilityUIElement::documentURI): Ditto.
2264         (WTR::createJSStringRef): Return a JSRetainPtr.
2265
2266         * WebKitTestRunner/StringFunctions.h:
2267         (WTR::toWK): Take a const& to eliminate a little bit of reference count churn.
2268         (WTR::toJS): Use the adopt function instead of the constructor.
2269
2270 2018-09-14  Dean Jackson  <dino@grorg.org>
2271
2272         Add Justin Michaud.
2273
2274         * Scripts/webkitpy/common/config/contributors.json:
2275
2276 2018-09-14  Ryan Haddad  <ryanhaddad@apple.com>
2277
2278         bots should pass --clobber-old-results to run-webkit-tests
2279         https://bugs.webkit.org/show_bug.cgi?id=189623
2280
2281         Reviewed by Aakash Jain.
2282
2283         In order to ensure that bots to not produce confusing results due to transient execptions,
2284         or run out of space if they continually hit an exception, old layout test results should be clobbered.
2285
2286         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2287         (RunWebKitTests):
2288
2289 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
2290
2291         Unreviewed, rolling out r235954.
2292
2293         Breaks the watchOS build.
2294
2295         Reverted changeset:
2296
2297         "Move IndexedDB to Network Process"
2298         https://bugs.webkit.org/show_bug.cgi?id=189415
2299         https://trac.webkit.org/changeset/235954
2300
2301 2018-09-13  Daniel Bates  <dabates@apple.com>
2302
2303         Add Copy WebKit Permalink plugin for Sublime Text
2304         https://bugs.webkit.org/show_bug.cgi?id=189589
2305
2306         Rubber-stamped by Joseph Pecoraro.
2307
2308         Port the Copy WebKit Permalink Automator service to a Sublime Text plugin. Once installed you can
2309         use the plugin to copy to the Clipboard a trac.webkit.org hyperlink to the selected line in the
2310         active document with or without blame annotations.
2311
2312         Once installed, you can Control-click (on Mac) or right-click (on Windows and Linux) on a line and
2313         choose Copy WebKit Permalink or Copy WebKit Permalink to Blame from the context menu to copy to the
2314         Clipboard a permanent hyperlink to the selected line without or with blame annotations, respectively.
2315         On Mac you can also invoke the same functionality using the keyboard shortcuts Command + Shift + Control + C
2316         and Command + Shift + Control + Option + C, respectively.
2317
2318         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu: Added.
2319         * CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py: Added.
2320         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Default (OSX).sublime-keymap: Added.
2321         * CopyPermalink/Sublime Text/INSTALL: Added.
2322         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/Info.plist: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist.
2323         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/document.wflow: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow.
2324         * CopyPermalink/Xcode/INSTALL: Renamed from Tools/CopyPermalink/README.
2325
2326 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2327
2328         Unreviewed. Fix WebDriver tests after r235225.
2329
2330         Use wpt serve command to run the http server.
2331
2332         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
2333         (WebDriverW3CWebServer.__init__):
2334         (WebDriverW3CWebServer.start):
2335         (WebDriverW3CWebServer.stop):
2336
2337 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2338
2339         [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
2340         https://bugs.webkit.org/show_bug.cgi?id=189544
2341
2342         Reviewed by Michael Catanzaro.
2343
2344         Add test cases for the new API.
2345
2346         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2347         (testWebViewJavaScriptDialogs):
2348
2349 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2350
2351         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
2352         https://bugs.webkit.org/show_bug.cgi?id=189496
2353         <rdar://problem/44370981>
2354
2355         Unreviewed warning fix.
2356
2357         r235929 has introduced a new compilation warning:
2358         > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:34:70: warning: unused parameter ‘imageSize’ [-Wunused-parameter]
2359
2360         * ImageDiff/cairo/PlatformImageCairo.cpp:
2361         (ImageDiff::PlatformImage::createFromStdin): Removed the variable name.
2362
2363 2018-09-12  Dan Bernstein  <mitz@apple.com>
2364
2365         [Cocoa] Complete support for Paste as Quotation
2366         https://bugs.webkit.org/show_bug.cgi?id=189504
2367
2368         Reviewed by Wenson Hsieh.
2369
2370         * MiniBrowser/mac/MainMenu.xib: Added a Paste as Quotation command in the Edit menu.
2371
2372 2018-09-12  Sihui Liu  <sihui_liu@apple.com>
2373
2374         Move IndexedDB to Network Process
2375         https://bugs.webkit.org/show_bug.cgi?id=189415
2376
2377         Reviewed by Geoffrey Garen.
2378
2379         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
2380         (TEST):
2381         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2382         (TEST):
2383         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
2384         (TEST):
2385         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
2386         (TEST):
2387         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
2388         (TEST):
2389
2390 2018-09-12  Chris Dumez  <cdumez@apple.com>
2391
2392         PSON: No process swap on back navigation after URL bar navigation
2393         https://bugs.webkit.org/show_bug.cgi?id=189557
2394         <rdar://problem/44353108>
2395
2396         Reviewed by Alex Christensen.
2397
2398         Add API test coverage.
2399
2400         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2401
2402 2018-09-11  Dean Jackson  <dino@apple.com>
2403
2404         Header parsing for experimental and internal debug features
2405         https://bugs.webkit.org/show_bug.cgi?id=189486
2406         <rdar://problem/44320618>
2407
2408         Reviewed by Tim Horton.
2409
2410         Keep track of experimental and internal debug features in TestOptions, and
2411         allow webkit-test-runner headers to toggle them by name.
2412
2413         * DumpRenderTree/TestOptions.cpp:
2414         (TestOptions::TestOptions):
2415         * WebKitTestRunner/TestController.cpp:
2416         (WTR::TestController::resetPreferencesToConsistentValues):
2417         (WTR::updateTestOptionsFromTestHeader):
2418         * WebKitTestRunner/TestOptions.h:
2419         (WTR::TestOptions::hasSameInitializationOptions const):
2420
2421 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
2422
2423         [Win][Clang][DumpRenderTree] 0 and nullptr can't be implicitly converted to AccessibilityUIElement
2424         https://bugs.webkit.org/show_bug.cgi?id=189492
2425
2426         Reviewed by Alex Christensen.
2427
2428         0 and nullptr can't be implicitly converted to
2429         AccessibilityUIElement because only Windows port typedefs
2430         PlatformUIElement as COMPtr<IAccessible> not a pointer.
2431
2432         Replaced "return 0" and "return nullptr" with "return { nullptr }".
2433
2434         * DumpRenderTree/AccessibilityUIElement.cpp:
2435         (AccessibilityUIElement::horizontalScrollbar const):
2436         (AccessibilityUIElement::verticalScrollbar const):
2437         (AccessibilityUIElement::uiElementAttributeValue const):
2438         (AccessibilityUIElement::accessibilityElementForTextMarker):
2439         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2440         (AccessibilityController::elementAtPoint):
2441         (AccessibilityController::accessibleElementById):
2442         (AccessibilityController::focusedElement):
2443         (AccessibilityController::rootElement):
2444         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2445         (AccessibilityUIElement::elementAtPoint):
2446         (AccessibilityUIElement::linkedUIElementAtIndex):
2447         (AccessibilityUIElement::getChildAtIndex):
2448         (AccessibilityUIElement::titleUIElement):
2449         (AccessibilityUIElement::parentElement):
2450         (AccessibilityUIElement::uiElementForSearchPredicate):
2451         (AccessibilityUIElement::cellForColumnAndRow):
2452         (AccessibilityUIElement::disclosedRowAtIndex):
2453         (AccessibilityUIElement::ariaOwnsElementAtIndex):
2454         (AccessibilityUIElement::ariaFlowToElementAtIndex):
2455         (AccessibilityUIElement::ariaControlsElementAtIndex):
2456         (AccessibilityUIElement::selectedRowAtIndex):
2457         (AccessibilityUIElement::rowAtIndex):
2458         (AccessibilityUIElement::disclosedByRow):
2459         (AccessibilityUIElement::selectedChildAtIndex const):
2460
2461 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2462
2463         FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
2464         https://bugs.webkit.org/show_bug.cgi?id=189382
2465
2466         Reviewed by Ryosuke Niwa.
2467
2468         Fix the test by specifying colors in RGB colorspace.
2469
2470         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2471         (TestWebKitAPI::TEST):
2472
2473 2018-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
2474
2475         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
2476         https://bugs.webkit.org/show_bug.cgi?id=189496
2477
2478         Reviewed by Alex Christensen.
2479
2480         * ImageDiff/cairo/PlatformImageCairo.cpp:
2481         (ImageDiff::PlatformImage::createFromStdin): Removed unnecessary ReadContext struct.
2482         (ImageDiff::PlatformImage::writeAsPNGToStdout): Use '%lu' format type specifier for unsigned long.
2483
2484 2018-09-07  Dean Jackson  <dino@apple.com>
2485
2486         Add and expose Internal features from WebKit
2487         https://bugs.webkit.org/show_bug.cgi?id=189442
2488         <rdar://problem/44243404>
2489
2490         Reviewed by Simon Fraser.
2491
2492         Update MiniBrowser to expose an Internal feature menu.
2493
2494         * MiniBrowser/mac/AppDelegate.m:
2495         (defaultConfiguration):
2496         * MiniBrowser/mac/SettingsController.m:
2497         (-[SettingsController _populateMenu]):
2498         (-[SettingsController validateMenuItem:]):
2499         (-[SettingsController toggleExperimentalFeature:]):
2500         (-[SettingsController toggleInternalDebugFeature:]):
2501
2502 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2503
2504         [macOS] [WK2] Support changing foreground colors via color panel
2505         https://bugs.webkit.org/show_bug.cgi?id=189382
2506         <rdar://problem/44227311>
2507
2508         Reviewed by Ryosuke Niwa.
2509
2510         Add an API test that uses NSColorPanel to change the color of selected text, and also apply typing styles when
2511         the selection is collapsed. The test also exercises switching between opaque colors (alpha = 1) and transparent
2512         colors, as well as making different parts of a word different colors.
2513
2514         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
2515         (-[TestWKWebView collapseToEnd]):
2516         (webViewForFontManagerTesting):
2517         (TestWebKitAPI::TEST):
2518         * TestWebKitAPI/cocoa/TestWKWebView.h:
2519
2520 == Rolled over to ChangeLog-2018-09-11 ==