webkitpy: clean up options for specifying multiple platforms at once
[WebKit-https.git] / Tools / ChangeLog
1 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
2
3         webkitpy: clean up options for specifying multiple platforms at once
4         https://bugs.webkit.org/show_bug.cgi?id=101140
5
6         Reviewed by Ojan Vafai.
7
8         This patch reworks how we display the help strings for --platform
9         options and how we filter out platforms matching a glob. This will
10         be useful as I add patches to ensure that all the webkit-patch
11         commands are using --platform consistently to filter ports.
12
13         There should be no functional changes resulting from this patch.
14
15         * Scripts/webkitpy/layout_tests/port/factory.py:
16         (platform_options):
17         (PortFactory.all_port_names):
18         (PortFactory.get_from_builder_name):
19         * Scripts/webkitpy/tool/commands/queries.py:
20         (PrintExpectations.__init__):
21         (PrintBaselines.__init__):
22         * Scripts/webkitpy/tool/commands/rebaseline.py:
23         (AbstractRebaseliningCommand):
24         (RebaselineJson.__init__):
25         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
26         (TestRebaselineExpectations.setUp):
27         (TestRebaselineExpectations.test_rebaseline_expectations):
28
29 2012-11-05  Peter Beverloo  <peter@chromium.org>
30
31         The layout test runner shouldn't wait for data if stdout/stderr have been closed
32         https://bugs.webkit.org/show_bug.cgi?id=101233
33
34         Reviewed by Dirk Pranke.
35
36         Trying to read the file descriptor for the stdout or stderr pipes when DumpRenderTree
37         has crashed during a Chromium Android layout test-run, which uses FIFOs for
38         communication, causes the File.fileno() method to raise a ValueError. Return early
39         if either of the pipes has already been closed.
40
41         * Scripts/webkitpy/layout_tests/port/server_process.py:
42         (ServerProcess._wait_for_data_and_update_buffers_using_select):
43
44 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
45
46         webkit-patch rebaseline is broken
47         https://bugs.webkit.org/show_bug.cgi?id=101235
48
49         Reviewed by Ojan Vafai.
50
51         It didn't get updated to handle the change in parsing --suffixes
52         properly, and the unit test didn't get updated either, masking the
53         problem.
54
55         * Scripts/webkitpy/tool/commands/rebaseline.py:
56         (Rebaseline._tests_to_update):
57         (Rebaseline.execute):
58         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
59         (TestRebaseline.test_rebaseline):
60
61 2012-11-05  Dirk Pranke  <dpranke@chromium.org>
62
63         lint-webkitpy doesn't autoinstall pylint properly.
64         https://bugs.webkit.org/show_bug.cgi?id=101106
65
66         Reviewed by Ojan Vafai.
67
68         Re-land r133381 with fix; ironically, lint-webkitpy would've
69         complained about the problem. Also modify pylintrc and clean up
70         any other lint errors in the modified files.
71
72         * Scripts/webkitpy/common/system/autoinstall.py:
73         (AutoInstaller._set_up_target_dir):
74         (AutoInstaller):
75         (AutoInstaller._make_package):
76         (AutoInstaller._create_scratch_directory):
77         (AutoInstaller._install):
78         (AutoInstaller.install):
79         * Scripts/webkitpy/pylintrc:
80         * Scripts/webkitpy/thirdparty/__init__.py:
81         (AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
82         (AutoinstallImportHook):
83         (AutoinstallImportHook.find_module):
84         (AutoinstallImportHook._install_pylint):
85         (AutoinstallImportHook._install_coverage):
86         (AutoinstallImportHook._install_eliza):
87         (AutoinstallImportHook._install_webpagereplay):
88         (AutoinstallImportHook._install):
89         * Scripts/webkitpy/thirdparty/__init___unittest.py:
90         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
91         (ThirdpartyTest.test_import_hook):
92         (ThirdpartyTest.test_imports):
93
94 2012-11-05  KyungTae Kim  <ktf.kim@samsung.com>
95
96         [EFL] Fix build warning in EWebLauncher/main.c
97         https://bugs.webkit.org/show_bug.cgi?id=101197
98
99         Reviewed by Kentaro Hara.
100
101         Because the strp of _Ecore_Getopt_Value is char** (Ecore_Getopt.h),
102         The parameter of ECORE_GETOPT_VALUE_STR should be char*
103
104         * EWebLauncher/main.c:
105         (_User_Arguments):
106
107 2012-11-05  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
108
109         [EFL][WK2] Add --window-size command line option to EFL MiniBrowser
110         https://bugs.webkit.org/show_bug.cgi?id=100942
111
112         Reviewed by Kenneth Rohde Christiansen.
113
114         Added window-size (-s) command line option to EFL MiniBrowser.
115
116         * MiniBrowser/efl/main.c:
117         (window_create):
118         (parse_window_size):
119         (elm_main):
120
121 2012-11-05  Christophe Dumez  <christophe.dumez@intel.com>
122
123         [EFL][WK2] The icon database path should be set by the client
124         https://bugs.webkit.org/show_bug.cgi?id=101182
125
126         Reviewed by Kenneth Rohde Christiansen.
127
128         Enable favicon database functionality in MiniBrowser since
129         it is used and it is no longer enabled by default.
130
131         * MiniBrowser/efl/main.c:
132         (elm_main):
133
134 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
135
136         [Qt][WK2] setPlatformStrategies always asserts after r132744
137         https://bugs.webkit.org/show_bug.cgi?id=100838
138
139         Reviewed by Simon Hausmann.
140
141         Reland with build fixes.
142
143         Turned test runners to use the new QtTestSupport.
144
145         * DumpRenderTree/qt/DumpRenderTree.pro:
146         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
147         (main):
148         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
149         (WebCore::DumpRenderTree::open):
150         * DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
151         * MiniBrowser/qt/MiniBrowser.pro:
152         * QtTestBrowser/QtTestBrowser.pro:
153         * QtTestBrowser/qttestbrowser.cpp:
154         (LauncherApplication::handleUserOptions):
155         * WebKitTestRunner/InjectedBundle/Target.pri:
156         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
157         (WTR::activateFonts):
158         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
159         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
160         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
161         (WTR::TestRunner::platformInitialize):  Removed the comment from here
162         because it was just lying, apparently two times. First, it is not incorrect
163         to reinitialize our font set and clear font caches, it is what the tests
164         expect. Second, the use of QRawFont has nothing to do with the font cache.
165         * WebKitTestRunner/Target.pri:
166         * WebKitTestRunner/qt/main.cpp:
167         (main):
168
169 2012-11-04  Sheriff Bot  <webkit.review.bot@gmail.com>
170
171         Unreviewed, rolling out r133381.
172         http://trac.webkit.org/changeset/133381
173         https://bugs.webkit.org/show_bug.cgi?id=101161
174
175         It made webkit-patch useless (Requested by Ossy_weekend on
176         #webkit).
177
178         * Scripts/webkitpy/common/system/autoinstall.py:
179         (AutoInstaller._create_scratch_directory):
180         (AutoInstaller._install):
181         (AutoInstaller.install):
182         * Scripts/webkitpy/thirdparty/__init__.py:
183         (AutoinstallImportHook.__init__):
184         (AutoinstallImportHook._install_pylint):
185         (AutoinstallImportHook._install_coverage):
186         (AutoinstallImportHook._install_eliza):
187         (AutoinstallImportHook._install):
188         * Scripts/webkitpy/thirdparty/__init___unittest.py:
189         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
190         (ThirdpartyTest.test_import_hook):
191
192 2012-11-03  Sheriff Bot  <webkit.review.bot@gmail.com>
193
194         Unreviewed, rolling out r133403, r133404, and r133409.
195         http://trac.webkit.org/changeset/133403
196         http://trac.webkit.org/changeset/133404
197         http://trac.webkit.org/changeset/133409
198         https://bugs.webkit.org/show_bug.cgi?id=101158
199
200         "Broke tests" (Requested by kbalazs on #webkit).
201
202         * DumpRenderTree/qt/DumpRenderTree.pro:
203         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
204         (main):
205         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
206         (WebCore::DumpRenderTree::open):
207         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
208         (WebKit):
209         (WebKit::initializeTestFonts):
210         * DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
211         (WebKit):
212         * MiniBrowser/qt/MiniBrowser.pro:
213         * MiniBrowser/qt/MiniBrowserApplication.cpp:
214         (MiniBrowserApplication::handleUserOptions):
215         * QtTestBrowser/QtTestBrowser.pro:
216         * QtTestBrowser/qttestbrowser.cpp:
217         (LauncherApplication::handleUserOptions):
218         * WebKitTestRunner/InjectedBundle/Target.pri:
219         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
220         (WTR::activateFonts):
221         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
222         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
223         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
224         (WTR::TestRunner::platformInitialize):
225         * WebKitTestRunner/Target.pri:
226         * WebKitTestRunner/qt/main.cpp:
227         (main):
228
229 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
230
231         [Qt][WK2] setPlatformStrategies always asserts after r132744
232         https://bugs.webkit.org/show_bug.cgi?id=100838
233
234         2nd unreviewed buildfix.
235
236         * MiniBrowser/qt/MiniBrowserApplication.cpp:
237
238 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
239
240         [Qt][WK2] setPlatformStrategies always asserts after r132744
241         https://bugs.webkit.org/show_bug.cgi?id=100838
242
243         Unreviewed buildfix.
244
245         * WebKitTestRunner/Target.pri:
246
247 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
248
249         [Qt][WK2] setPlatformStrategies always asserts after r132744
250         https://bugs.webkit.org/show_bug.cgi?id=100838
251
252         Reviewed by Simon Hausmann.
253
254         Reland with build fix.
255
256         Turned test runners to use the new QtTestSupport.
257
258         * DumpRenderTree/qt/DumpRenderTree.pro:
259         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
260         (main):
261         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
262         (WebCore::DumpRenderTree::open):
263         * DumpRenderTree/qt/QtInitializeTestFonts.h: Removed.
264         * MiniBrowser/qt/MiniBrowser.pro:
265         * QtTestBrowser/QtTestBrowser.pro:
266         * QtTestBrowser/qttestbrowser.cpp:
267         (LauncherApplication::handleUserOptions):
268         * WebKitTestRunner/InjectedBundle/Target.pri:
269         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
270         (WTR::activateFonts):
271         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
272         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
273         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
274         (WTR::TestRunner::platformInitialize):  Removed the comment from here
275         because it was just lying, apparently two times. First, it is not incorrect
276         to reinitialize our font set and clear font caches, it is what the tests
277         expect. Second, the use of QRawFont has nothing to do with the font cache.
278         * WebKitTestRunner/Target.pri:
279         * WebKitTestRunner/qt/main.cpp:
280         (main):
281
282 2012-11-03  Sheriff Bot  <webkit.review.bot@gmail.com>
283
284         Unreviewed, rolling out r133397.
285         http://trac.webkit.org/changeset/133397
286         https://bugs.webkit.org/show_bug.cgi?id=101155
287
288         "Broke Qt. No way to force the damn bots to do a clean build.
289         I'm giving up." (Requested by kbalazs on #webkit).
290
291         * DumpRenderTree/qt/DumpRenderTree.pro:
292         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
293         (main):
294         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
295         (WebCore::DumpRenderTree::open):
296         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
297         (WebKit):
298         (WebKit::initializeTestFonts):
299         * DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
300         (WebKit):
301         * QtTestBrowser/QtTestBrowser.pro:
302         * QtTestBrowser/qttestbrowser.cpp:
303         (LauncherApplication::handleUserOptions):
304         * WebKitTestRunner/InjectedBundle/Target.pri:
305         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
306         (WTR::activateFonts):
307         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
308         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
309         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
310         (WTR::TestRunner::platformInitialize):
311         * WebKitTestRunner/Target.pri:
312         * WebKitTestRunner/qt/main.cpp:
313         (main):
314
315 2012-11-03  Balazs Kelemen  <kbalazs@webkit.org>
316
317         [Qt][WK2] setPlatformStrategies always asserts after r132744
318         https://bugs.webkit.org/show_bug.cgi?id=100838
319
320         Reviewed by Simon Hausmann.
321
322         Turned test runners to use the new QtTestSupport.
323
324         * DumpRenderTree/qt/DumpRenderTree.pro:
325         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
326         (main):
327         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
328         (WebCore::DumpRenderTree::open):
329         * QtTestBrowser/QtTestBrowser.pro:
330         * QtTestBrowser/qttestbrowser.cpp:
331         (LauncherApplication::handleUserOptions):
332         * WebKitTestRunner/InjectedBundle/Target.pri:
333         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
334         (WTR::activateFonts):
335         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
336         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
337         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
338         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
339         (WTR::TestRunner::platformInitialize): Removed the comment from here
340         because it was just lying, apparently two times. First, it is not incorrect
341         to reinitialize our font set and clear font caches, it is what the tests
342         expect. Second, the use of QRawFont has nothing to do with the font cache.
343         * WebKitTestRunner/Target.pri:
344         * WebKitTestRunner/qt/main.cpp:
345         (main):
346
347 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
348
349         webkit-patch rebaseline is broken
350         https://bugs.webkit.org/show_bug.cgi?id=101081
351
352         Reviewed by Ojan Vafai.
353
354         I broke this in r133061 and the unit tests weren't covering this
355         code path. Fixed the issue and the tests. --results-directory
356         doesn't make sense for either 'webkit-patch rebaseline' or
357         'webkit-patch rebaseline-expectations', so we don't want to expose
358         that as a command line option, but they all call a common
359         _rebaseline() routine that references options.results_directory,
360         so we need to set a default value.
361
362         * Scripts/webkitpy/tool/commands/rebaseline.py:
363         (RebaselineExpectations.execute):
364         (Rebaseline.execute):
365         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
366         (TestRebaseline):
367         (TestRebaseline.test_rebaseline):
368
369 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
370
371         lint-webkitpy doesn't autoinstall pylint properly
372         https://bugs.webkit.org/show_bug.cgi?id=101106
373
374         Reviewed by Ojan Vafai.
375
376         Turns out the autoinstalling code for pylint didn't install
377         pylint's dependencies, and the autoinstaller code didn't work
378         using nested directories (e.g., "logilab/astng"). Fix those issues,
379         clean up the autoinstaller code, and add tests to make sure everything
380         imports successfully.
381
382         * Scripts/webkitpy/common/system/autoinstall.py:
383         (AutoInstaller._create_scratch_directory):
384         (AutoInstaller._install):
385         (AutoInstaller.install):
386         * Scripts/webkitpy/thirdparty/__init__.py:
387         (AutoinstallImportHook._ensure_autoinstalled_dir_is_in_sys_path):
388         (AutoinstallImportHook._install_pylint):
389         (AutoinstallImportHook._install_coverage):
390         (AutoinstallImportHook._install_eliza):
391         (AutoinstallImportHook._install):
392         * Scripts/webkitpy/thirdparty/__init___unittest.py:
393         (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
394         (ThirdpartyTest.test_import_hook):
395         (ThirdpartyTest.test_imports):
396
397 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
398
399         nrwt prints an awkward result message for missing results
400         https://bugs.webkit.org/show_bug.cgi?id=100915
401
402         Reviewed by Ojan Vafai.
403
404         Completely rework how we print out the description of
405         each tests's result - we now will print either "passed" or "failed",
406         followed by " unexpectedly" if we weren't expecting the result,
407         followed by a short description of each type of failure that happened
408         (in parentheses). Also reworked the description of each type of
409         failure slightly to be clearer.
410
411         Also rework the tests to make sure we have coverage of all of the
412         messages. Examples of the new output are posted as an attachment to
413         the bug.
414
415         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
416         (TestExpectations):
417         * Scripts/webkitpy/layout_tests/models/test_failures.py:
418         (FailureTimeout.message):
419         (FailureMissingResult.message):
420         (FailureTextMismatch.message):
421         (FailureMissingImageHash.message):
422         (FailureMissingImage.message):
423         (FailureImageHashMismatch.message):
424         (FailureImageHashIncorrect.message):
425         (FailureReftestMismatch.message):
426         (FailureReftestMismatchDidNotOccur.message):
427         (FailureReftestNoImagesGenerated.message):
428         (FailureMissingAudio.message):
429         (FailureAudioMismatch.message):
430         (FailureEarlyExit.message):
431         * Scripts/webkitpy/layout_tests/port/test.py:
432         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
433         (MainTest.test_run_singly_actually_runs_tests):
434         (MainTest.test_missing_and_unexpected_results):
435         * Scripts/webkitpy/layout_tests/views/printing.py:
436         (Printer._print_result_summary_entry):
437         (Printer.print_finished_test):
438         (Printer._result_message):
439         (Printer._print_unexpected_results):
440         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
441         * Scripts/webkitpy/tool/commands/queues_unittest.py:
442
443 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
444
445         webkitpy: clean up logging in common.system.autoinstall
446         https://bugs.webkit.org/show_bug.cgi?id=101090
447
448         Reviewed by Ojan Vafai.
449
450         This module logged way too much, much of which was logging that
451         was either really redundant or useful only during initial development.
452         This patch deletes a lot of code and tweaks the remaining log messages
453         to be more useful now.
454
455         Also, clean up a bunch of lint errors and warnings.
456
457         * Scripts/webkitpy/common/system/autoinstall.py:
458         (AutoInstaller.__init__):
459         (AutoInstaller._write_file):
460         (AutoInstaller._set_up_target_dir):
461         (AutoInstaller._create_scratch_directory):
462         (AutoInstaller._url_downloaded_path):
463         (AutoInstaller._is_downloaded):
464         (AutoInstaller._record_url_downloaded):
465         (AutoInstaller._extract_targz):
466         (AutoInstaller._extract_all):
467         (AutoInstaller._unzip):
468         (AutoInstaller._download_to_stream):
469         (AutoInstaller._download):
470         (AutoInstaller._install):
471         (AutoInstaller.install):
472
473 2012-11-02  Dirk Pranke  <dpranke@chromium.org>
474
475         webkit-patch analyze-baselines output is weak
476         https://bugs.webkit.org/show_bug.cgi?id=100998
477
478         Reviewed by Ojan Vafai.
479
480         Currently analyze-baselines prints a list of baselines that have
481         the same checksum per line, but the format is hard to read;
482         this patch cleans up the output to print by directory instead
483         and use the same format I recently added for debugging optimize-baselines,
484         then refactors the code so that we share and adds tests for
485         analyze-baselines (which was untested).
486
487         Also, I got rid of a couple of unnecessarily-hardcoded port names,
488         and modified the baseline optimizer to log the current world when
489         optimize fails.
490
491         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
492         (BaselineOptimizer.read_results_by_directory):
493         (BaselineOptimizer.write_by_directory):
494         (BaselineOptimizer.optimize):
495         * Scripts/webkitpy/tool/commands/rebaseline.py:
496         (OptimizeBaselines.execute):
497         (AnalyzeBaselines.__init__):
498         (AnalyzeBaselines._write):
499         (AnalyzeBaselines._analyze_baseline):
500         (AnalyzeBaselines.execute):
501         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
502         (_FakeOptimizer):
503         (_FakeOptimizer.read_results_by_directory):
504         (TestAnalyzeBaselines):
505         (TestAnalyzeBaselines.setUp):
506         (TestAnalyzeBaselines.test_default):
507         (TestAnalyzeBaselines.test_missing_baselines):
508
509 2012-11-02  Adam Barth  <abarth@webkit.org>
510
511         ENABLE(UNDO_MANAGER) is disabled everywhere and is not under active development
512         https://bugs.webkit.org/show_bug.cgi?id=100711
513
514         Reviewed by Eric Seidel.
515
516         * Scripts/webkitperl/FeatureList.pm:
517         * qmake/mkspecs/features/features.pri:
518
519 2012-11-02  Sheriff Bot  <webkit.review.bot@gmail.com>
520
521         Unreviewed, rolling out r133303.
522         http://trac.webkit.org/changeset/133303
523         https://bugs.webkit.org/show_bug.cgi?id=101068
524
525         "Broke qt wk2 build (seems like bots fails to rerun qmake if
526         needed)" (Requested by kbalazs on #webkit).
527
528         * DumpRenderTree/qt/DumpRenderTree.pro:
529         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
530         (main):
531         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
532         (WebCore::DumpRenderTree::open):
533         * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
534         (WebKit):
535         (WebKit::initializeTestFonts):
536         * DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
537         (WebKit):
538         * QtTestBrowser/QtTestBrowser.pro:
539         * QtTestBrowser/qttestbrowser.cpp:
540         (LauncherApplication::handleUserOptions):
541         * WebKitTestRunner/InjectedBundle/Target.pri:
542         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
543         (WTR::activateFonts):
544         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
545         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
546         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
547         (WTR::TestRunner::platformInitialize):
548         * WebKitTestRunner/Target.pri:
549         * WebKitTestRunner/qt/main.cpp:
550         (main):
551
552 2012-11-02  Balazs Kelemen  <kbalazs@webkit.org>
553
554         [Qt][WK2] setPlatformStrategies always asserts after r132744
555         https://bugs.webkit.org/show_bug.cgi?id=100838
556
557         Reviewed by Simon Hausmann.
558
559         Turned test runners to use the new QtTestSupport.
560
561         * DumpRenderTree/qt/DumpRenderTree.pro:
562         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
563         (main):
564         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
565         (WebCore::DumpRenderTree::open):
566         * QtTestBrowser/QtTestBrowser.pro:
567         * QtTestBrowser/qttestbrowser.cpp:
568         (LauncherApplication::handleUserOptions):
569         * WebKitTestRunner/InjectedBundle/Target.pri:
570         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
571         (WTR::activateFonts):
572         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
573         * WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
574         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
575         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
576         (WTR::TestRunner::platformInitialize): Removed the comment from here
577         because it was just lying, apparently two times. First, it is not incorrect
578         to reinitialize our font set and clear font caches, it is what the tests
579         expect. Second, the use of QRawFont has nothing to do with the font cache.
580         * WebKitTestRunner/Target.pri:
581         * WebKitTestRunner/qt/main.cpp:
582         (main):
583
584 2012-11-02  Peter Beverloo  <peter@chromium.org>
585
586         Output Android's device status before running tests on the bots
587         https://bugs.webkit.org/show_bug.cgi?id=100944
588
589         Reviewed by Dirk Pranke.
590
591         This adds a new step to the build master which will be run prior to the
592         actual tests-suites on the Chromium Android tester, and soon the Chromium
593         Android Perf bot. For each attached device, it outputs the build
594         information, battery level, battery temperature and username.
595
596         The Android tester currently is very flaky, and this will help tremendously
597         in being able to figure out what's wrong with the bot.
598
599         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
600         (OutputAndroidDeviceStatus):
601         (TestFactory.__init__):
602         * BuildSlaveSupport/chromium/output-android-device-status: Added.
603         (GetAttachedDevices):
604         (AndroidDeviceStatus):
605         (AndroidDeviceStatus.__init__):
606         (AndroidDeviceStatus._run_adb_command):
607         (AndroidDeviceStatus.device_type):
608         (AndroidDeviceStatus.device_build):
609         (AndroidDeviceStatus.device_fingerprint):
610         (AndroidDeviceStatus.battery_level):
611         (AndroidDeviceStatus.battery_temperature):
612         (AndroidDeviceStatus.username):
613         (main):
614
615 2012-11-02  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
616
617         [Qt] WTR: Make sure that eventSender.mouseDown sends a press event for the second press
618         https://bugs.webkit.org/show_bug.cgi?id=101033
619
620         Reviewed by Simon Hausmann.
621
622         eventSender.mouseDown doesn't work properly since r133153 where
623         MouseButtonDblClick events aren't interpreted as Press events anymore.
624         The problem is that mouseDown sends a DblClick event instead of a Press,
625         while the correct way is to send both events.
626
627         Since QQuickWebView isn't doing anything with DblClick events anymore,
628         simply send Press events all the time and let WebCore figure out
629         where the double clicks are.
630
631         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
632         (WTR::EventSenderProxy::updateClickCountForButton):
633         (WTR::EventSenderProxy::mouseDown):
634
635 2012-11-02  Christophe Dumez  <christophe.dumez@intel.com>
636
637         [EFL][WK2] Add HTTP authentication support to MiniBrowser
638         https://bugs.webkit.org/show_bug.cgi?id=100953
639
640         Reviewed by Kenneth Rohde Christiansen.
641
642         Add HTTP authentication support to MiniBrowser. An authentication
643         dialog now pops up to ask the user for credentials whenever
644         a Web site requires authentication.
645
646         * MiniBrowser/efl/main.c:
647         (auth_popup_close):
648         (on_auth_cancel):
649         (on_auth_ok):
650         (on_authentication_request):
651         (window_create):
652
653 2012-11-01  Yury Semikhatsky  <yurys@chromium.org>
654
655         Memory instrumentation: do not call checkCountedObject with wrong pointers
656         https://bugs.webkit.org/show_bug.cgi?id=100958
657
658         Reviewed by Alexander Pavlov.
659
660         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: test that if there
661         if there is class A derived from classes B and C and we have pointer B* to an
662         object of class A then MemoryInstrumentationClient::checkoutCountedObject won't
663         be called for B* but only for A*
664
665         Also MemoryInstrumentation implementation used in the test was refactored to
666         allow passing client as a parameter. The client implementation was extracted into
667         a top-level class MemoryInstrumentationTestClient.
668
669 2012-11-01  Christophe Dumez  <christophe.dumez@intel.com>
670
671         [EFL][WK2] Make File Chooser dialog modal in MiniBrowser
672         https://bugs.webkit.org/show_bug.cgi?id=100962
673
674         Reviewed by Gyuyoung Kim.
675
676         Make File Chooser dialog modal in MiniBrowser and make
677         sure it is closed and freed when its parent window is
678         closed.
679
680         * MiniBrowser/efl/main.c:
681         (close_file_picker):
682         (on_filepicker_parent_deletion):
683         (on_file_chooser_request):
684
685 2012-11-01  Seonae Kim  <sunaeluv.kim@samsung.com>
686
687         [EFL][DRT] Support Geolocation
688         https://bugs.webkit.org/show_bug.cgi?id=97427
689
690         Reviewed by Gyuyoung Kim. 
691
692         Implement methods to use GeolocationClientMock in DumpRenderTree.
693         This client attaches to the page whenever a view is created.
694
695         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
696         (DumpRenderTreeChrome::createView):
697         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
698         * DumpRenderTree/efl/TestRunnerEfl.cpp:
699         (TestRunner::setMockGeolocationPosition):
700         (TestRunner::setMockGeolocationPositionUnavailableError):
701         (TestRunner::setGeolocationPermission):
702         (TestRunner::numberOfPendingGeolocationPermissionRequests):
703
704 2012-11-01  Ryosuke Niwa  <rniwa@webkit.org>
705
706         Remove tests no longer needed after r133229.
707
708         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
709         (TestPerfTestFactory.test_inspector_test):
710         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
711         (test_collect_tests_with_skipped_list):
712
713 2012-11-01  Nico Weber  <thakis@chromium.org>
714
715         [chromium] Try to find ninja if it's not in the path already
716         https://bugs.webkit.org/show_bug.cgi?id=100988
717
718         Reviewed by Ryosuke Niwa.
719
720         Similar to the gclient detection logic in update-webkit-chromium
721
722         * Scripts/webkitdirs.pm:
723         (buildChromiumNinja):
724
725 2012-11-01  Eric Seidel  <eric@webkit.org>
726
727         Add Glenn Adams to the Contributor list
728         https://bugs.webkit.org/show_bug.cgi?id=100982
729
730         Reviewed by Adam Barth.
731
732         I CC him enough on bugs it would help me to have him listed here.
733
734         * Scripts/webkitpy/common/config/committers.py:
735
736 2012-11-01  Jer Noble  <jer.noble@apple.com>
737
738         Add Python-LLDB support for WTF::Vector types.
739         https://bugs.webkit.org/show_bug.cgi?id=100980
740
741         Reviewed by Anders Carlsson.
742
743         Add a synthetic child provider for WTF::Vector types.
744
745         * lldb/lldb_webkit.py:
746         (__lldb_init_module): Add both the summary and synthetic providers for WTF::Vector
747         (WTFVector_SummaryProvider): Wrapper around WTFVectorProvider
748         (WTFVectorProvider):
749         (WTFVectorProvider.__init__):
750         (WTFVectorProvider.num_children): Return m_size+2 children to account for synthesized children.
751         (WTFVectorProvider.get_child_index): Synthesize child indexes for each entry in the Vector.
752         (WTFVectorProvider.get_child_at_index): Synthesize children for each entry in the Vector.
753         (WTFVectorProvider.update): Retrieve state from the underlying Vector.
754         (WTFVectorProvider.has_children): Vectors always have children.
755
756 2012-11-01  Zoltan Horvath  <zoltan@webkit.org>
757
758         Remove PageLoad directory entry from PerformanceTests pattern_map
759         https://bugs.webkit.org/show_bug.cgi?id=100989
760
761         Reviewed by Ryosuke Niwa.
762
763         Since we removed PageLoad directory from PerformanceTests we don't need this entry in pattern_map.
764
765         * Scripts/webkitpy/performance_tests/perftest.py:
766         (PerfTestFactory):
767
768 2012-11-01  Jer Noble  <jer.noble@apple.com>
769
770         Add LLDB-Python scripts to support WebKit data types.
771         https://bugs.webkit.org/show_bug.cgi?id=100898
772
773         Reviewed by Anders Carlsson.
774
775         Add Summary providers for common WebKit string types.
776
777         * lldb/lldb_webkit.py: Added.
778         (__lldb_init_module): Register these providers with the debugger.
779         (WTFString_SummaryProvider): Wrapper around WTFStringProvider.
780         (WTFStringImpl_SummaryProvider): Wrapper around WTFStringImplProvider.
781         (WTFAtomicString_SummaryProvider): Ditto.
782         (guess_string_length): Walk through the string looking for a null-byte(s).
783         (ustring_to_string): Walk through the string, extracting two-byte values, and concatenate them.
784         (lstring_to_string): Walk through the string, extracting byte values, and concatenate them.
785         (WTFStringImplProvider): 
786         (WTFStringImplProvider.__init__):
787         (WTFStringImplProvider.get_length): Extract the m_length variable.
788         (WTFStringImplProvider.get_data8): Extract the m_data8 variable.
789         (WTFStringImplProvider.get_data16): Extract the m_data16 variable.
790         (WTFStringImplProvider.to_string): Pass the appropriate data variable to {u,l}string_to_string.
791         (WTFStringImplProvider.is_8bit): Check the m_hashAndFlags variable.
792         (WTFStringProvider):
793         (WTFStringProvider.__init__):
794         (WTFStringProvider.stringimpl): Extract the m_impl variable.
795         (WTFStringProvider.get_length): Pass through to WTFStringImplProvider.
796         (WTFStringProvider.to_string): Ditto.
797
798 2012-11-01  Peter Beverloo  <peter@chromium.org>
799
800         [Chromium-Android] Apache doesn't properly clean up ipc semaphores after a layout test run
801         https://bugs.webkit.org/show_bug.cgi?id=100950
802
803         Reviewed by Dirk Pranke.
804
805         When a test run would fail to complete due to an exception in one of
806         the workers, the HTTP server wouldn't get a chance to gracefully shut
807         down. This caused too much IPC semaphores to be left on the server,
808         causing Apache to fail to start in subsequent runs.
809
810         By unifying the Android-specific code with other ports, we no longer
811         fail to call the ChromiumPort/Base setup_test_run() and clean_up_test_run()
812         methods either. Furthermore, the number_of_servers argument for starting
813         the HTTP server is now available as well.
814
815         Because not all tests require an HTTP server, it's not guaranteed that
816         it will be started. Android depends on this, so add a new method to Port
817         and override it for Android: requires_http_server().
818
819         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
820         (LayoutTestRunner.run_tests):
821         * Scripts/webkitpy/layout_tests/controllers/manager.py:
822         (Manager._run_tests):
823         * Scripts/webkitpy/layout_tests/port/base.py:
824         (Port.to.requires_http_server):
825         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
826         (PortTest.test_dont_require_http_server):
827         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
828         (ChromiumAndroidPort.requires_http_server):
829         (ChromiumAndroidPort.start_http_server):
830         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
831         (ChromiumAndroidPortTest.test_must_require_http_server):
832
833 2012-11-01  Adam Roben  <aroben@webkit.org>
834
835         Crash beneath WKRelease after failed load in MiniBrowser
836         https://bugs.webkit.org/show_bug.cgi?id=100954
837
838         Reviewed by Sam Weinig.
839
840         There were just some simple retain/release bugs.
841
842         * MiniBrowser/mac/WK2BrowserWindowController.m:
843         (-[WK2BrowserWindowController updateTextFieldFromURL:]):
844         (-[WK2BrowserWindowController updateProvisionalURLForFrame:]):
845         Don't try to release null URLs.
846
847         (-[WK2BrowserWindowController updateCommittedURLForFrame:]): Don't
848         release a URL for which we don't have ownership.
849
850 2012-10-31  Rob Buis  <rbuis@rim.com>
851
852         [BlackBerry] Fix editing/text-iterator/findString-expected.html fail
853         https://bugs.webkit.org/show_bug.cgi?id=100902
854
855         Reviewed by Yong Li.
856
857         PR 210039
858
859         Fix the test my using the Page::findString method instead of our own in-page searcher.
860         This also syncs some of the changes we did regarding String usage.
861
862         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
863         (BlackBerry::WebKit::DumpRenderTree::dumpFramesAsText):
864         (BlackBerry::WebKit::dumpHistoryItem):
865         (BlackBerry::WebKit::dumpBackForwardListForWebView):
866         (BlackBerry::WebKit::DumpRenderTree::dump):
867         (BlackBerry::WebKit::DumpRenderTree::didFinishDocumentLoadForFrame):
868         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
869         (BlackBerry::WebKit::DumpRenderTree::runJavaScriptAlert):
870         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
871         (DumpRenderTree):
872         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
873         (TestRunner::setMockGeolocationError):
874         (TestRunner::layerTreeAsText):
875         (TestRunner::findString):
876         (TestRunner::setStorageDatabaseIdleInterval):
877
878 2012-11-01  Christophe Dumez  <christophe.dumez@intel.com>
879
880         [EFL][WK2] Add File Chooser dialog support to MiniBrowser
881         https://bugs.webkit.org/show_bug.cgi?id=100822
882
883         Reviewed by Kenneth Rohde Christiansen.
884
885         Add very basic file picker dialog to MiniBrowser so that
886         the user can select a file from the file system when
887         clicking an input element of type "file".
888
889         * MiniBrowser/efl/main.c:
890         (close_file_picker):
891         (on_filepicker_deletion):
892         (on_fileselector_done):
893         (on_file_chooser_request):
894         (window_create):
895
896 2012-11-01  Yael Aharon  <yael.aharon@intel.com>
897
898         Unreviewed. Change my email address.
899
900         * Scripts/webkitpy/common/config/committers.py:
901
902 2012-11-01  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
903
904         [Qt] Double clicks/taps aren't passed down to the page
905         https://bugs.webkit.org/show_bug.cgi?id=100949
906
907         Reviewed by Kenneth Rohde Christiansen.
908
909         Touch mocking shouldn't transform double click events as well,
910         this adds an extra touch update between clicks which prevents
911         double-tap detection from triggering on web pages.
912
913         Tested on the mobile version of Google maps.
914
915         * MiniBrowser/qt/MiniBrowserApplication.cpp:
916         (MiniBrowserApplication::notify):
917
918 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
919
920         NRWT: lint warnings don't show up by default
921         https://bugs.webkit.org/show_bug.cgi?id=100914
922
923         Reviewed by Ryosuke Niwa.
924
925         NRWT wasn't printing any warnings if you had errors in your
926         TestExpectations files; this means you would only notice this
927         with --lint-test-files, which is probably bad. I'm not sure
928         when this requested, but perhaps when we changed the
929         warnings to not be fatal if you weren't linting the files.
930
931         Now they're still not fatal, but at least we print them.
932
933         Also fix one warning message where we were printing the test name twice.
934
935         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
936         (TestExpectationsModel._already_seen_better_match):
937         (TestExpectations._report_warnings):
938         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
939         (MiscTests.test_parse_warnings_are_logged_if_not_in_lint_mode(self): Added.
940
941 2012-10-31  Terry Anderson  <tdanderson@chromium.org>
942
943         Missing stderr output when using run-webkit-tests
944         https://bugs.webkit.org/show_bug.cgi?id=100709
945
946         Reviewed by Dirk Pranke.
947
948         Appends #EOF to the end of the stderr output only at the end of a test,
949         not possibly part-way through. This will allow all of the stderr output 
950         to appear on the results page after running run-webkit-tests.
951
952         * DumpRenderTree/chromium/TestEventPrinter.cpp:
953         (TestEventPrinter::handleTextFooter):
954         (TestEventPrinter::handleTestFooter):
955
956 2012-10-30  Mark Lam  <mark.lam@apple.com>
957
958         A JSC printf (support for %J+s and %b).
959         https://bugs.webkit.org/show_bug.cgi?id=100566.
960
961         Reviewed by Michael Saboff.
962
963         Added regression tests for VMInspector::fprintf() sprintf() and snprintf().
964
965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
966         * TestWebKitAPI/Tests/JavaScriptCore: Added.
967         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Added.
968
969 2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
970
971         Added viewport at-rule to the CSS parser and tokenizer
972         https://bugs.webkit.org/show_bug.cgi?id=95961
973
974         Reviewed by Kenneth Rohde Christiansen.
975
976         Enable CSS Device Adaptation by default on EFL.
977
978         * Scripts/webkitperl/FeatureList.pm:
979
980 2012-10-31  Terry Anderson  <tdanderson@chromium.org>
981
982         [touchadjustment] touch-links-two-finger-tap test pass incorrectly
983         https://bugs.webkit.org/show_bug.cgi?id=100619
984
985         Reviewed by Antonio Gomes.
986
987         Store the touch area when sending a GestureTwoFingerTap event.
988
989         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
990         (WebTestRunner):
991         (WebTestRunner::EventSender::gestureEvent):
992
993 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
994
995         nrwt is not killing stuck DRTs on chromium win
996         https://bugs.webkit.org/show_bug.cgi?id=100886
997
998         Unreviewed, build fix.
999
1000         In the original implementation of NRWT for Chromium, we used
1001         to assume that DRT would always manage to exit on its own and
1002         so NRWT wouldn't attempt to kill DRT if it was stuck (this was the
1003         "hung worker" problem, and meant that if DRT hung, NRWT would hang).
1004
1005         Eventually, we merged the chromium code with the other ports and
1006         now will always try to shut down DRTs if a test times out, but as
1007         part of that merge we left in a code path where we wouldn't
1008         shut the driver down on windows. This was resulting in stray
1009         DRTs being left around, and NRWT sometimes not exiting cleanly as
1010         a result.
1011
1012         No unit tests added because this was a windows-only code path (hence
1013         hard to test) and that is now gone.
1014
1015         * Scripts/webkitpy/layout_tests/port/server_process.py:
1016         (ServerProcess.stop):
1017
1018 2012-10-31  Ami Fischman  <fischman@chromium.org>
1019
1020         [chromium] DRT and WTR should clear the cache between tests
1021         https://bugs.webkit.org/show_bug.cgi?id=93195
1022
1023         Reviewed by Tony Chang.
1024
1025         This change makes chromium DRT match the GTK+, Qt, and EFL ports.
1026
1027         * DumpRenderTree/chromium/TestShell.cpp:
1028         (TestShell::resetTestController): added a WebCache::clear() call to achieve the goal of the bug.
1029
1030 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1031
1032         Fix typos introduced in r133061.
1033         Unreviewed, build fix.
1034
1035         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1036         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1037         (ReflectionHandler._serve_file):
1038
1039 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1040
1041         garden-o-matic should work for local results
1042         https://bugs.webkit.org/show_bug.cgi?id=100805
1043
1044         Reviewed by Adam Barth.
1045
1046         This is the next step in making garden-o-matic replace
1047         'webkit-patch rebaseline-server' and be able to deal with local
1048         results. garden-o-matic now accepts a '--results-directory' option
1049         that will point to a layout-test-results directory. At the moment
1050         this will only work if you are also filtering to a single bot/
1051         platform at a time (we can't handle multiple bots' worth of local
1052         results, but that is a logical next step).
1053
1054         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1055         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1056         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
1057         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1058         (GardenOMatic.__init__):
1059         (GardenOMatic.execute):
1060         * Scripts/webkitpy/tool/commands/rebaseline.py:
1061         (AbstractRebaseliningCommand):
1062         (RebaselineTest.__init__):
1063         (RebaselineTest._rebaseline_test):
1064         (RebaselineTest._rebaseline_test_and_update_expectations):
1065         (RebaselineTest.execute):
1066         (AbstractParallelRebaselineCommand._rebaseline_commands):
1067         (AbstractParallelRebaselineCommand._rebaseline):
1068         (RebaselineJson.__init__):
1069         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1070         (_BaseTestCase):
1071         (test_rebaseline_updates_expectations_file):
1072         (test_rebaseline_does_not_include_overrides):
1073         (test_rebaseline_test):
1074         (test_rebaseline_test_and_print_scm_changes):
1075         (test_rebaseline_and_copy_test):
1076         (test_rebaseline_and_copy_test_no_existing_result):
1077         (test_rebaseline_and_copy_test_with_lion_result):
1078         (test_rebaseline_and_copy_no_overwrite_test):
1079         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
1080         (TestRebaselineJson.test_rebaseline_all):
1081         (TestRebaselineJson.test_rebaseline_debug):
1082         (TestRebaselineJson.test_move_overwritten):
1083         (TestRebaselineJson.test_no_optimize):
1084         (TestRebaselineExpectations.test_rebaseline_expectations):
1085         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1086         (GardeningHTTPRequestHandler.rebaselineall):
1087         (GardeningHTTPRequestHandler):
1088         (GardeningHTTPRequestHandler.localresult):
1089         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
1090         (ReflectionHandler.do_POST):
1091         (ReflectionHandler):
1092         (ReflectionHandler.do_HEAD):
1093
1094 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1095
1096         garden-o-matic should support gardening a single port and specifying how to deal with overwritten baselines
1097         https://bugs.webkit.org/show_bug.cgi?id=100563
1098
1099         Reviewed by Ojan Vafai.
1100
1101         This patch starts the process of making garden-o-matic more useful for
1102         bringing up a single new port in two ways. The goal is to fully
1103         obsolete webkit-patch rebaseline-server.
1104         
1105         First, it adds support for the --platform arguments to garden-o-matic
1106         (so that the UI will default to the right cluster of bots), and if the platform arg
1107         specifies a single bot, filters the results down to just that bot.
1108
1109         Second, it adds support for --move-overwritten-baselines and changes
1110         the implementation of the move_overwritten_baselines setting in builders.py
1111         so that it is only used if this flag is provided.
1112
1113         Future patches will make it possible to use local copies of the build
1114         results (rather than going to the bots) and other optimizations to make
1115         it faster to review lots of changes on a single bot.
1116
1117         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1118         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1119         (.):
1120         * Scripts/webkitpy/layout_tests/port/builders.py:
1121         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1122         (GardenOMatic):
1123         (GardenOMatic.execute):
1124         * Scripts/webkitpy/tool/commands/rebaseline.py:
1125         (AbstractRebaseliningCommand):
1126         (AbstractRebaseliningCommand.__init__):
1127         (RebaselineTest):
1128         (OptimizeBaselines):
1129         (AnalyzeBaselines):
1130         (AbstractParallelRebaselineCommand):
1131         (AbstractParallelRebaselineCommand._rebaseline_commands):
1132         (AbstractParallelRebaselineCommand._rebaseline):
1133         (Rebaseline.__init__):
1134         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1135         (GardeningHTTPServer.url):
1136         (GardeningHTTPRequestHandler.rebaselineall):
1137
1138 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1139
1140         test-webkitpy: fix running modules and classes on the command line
1141         https://bugs.webkit.org/show_bug.cgi?id=100787
1142
1143         Reviewed by Eric Seidel.
1144
1145         Handling modules and classes are arguments on the command line
1146         was broken due to the way we were parsing test names looking for
1147         parallel and serial tests.
1148
1149         * Scripts/webkitpy/test/main.py:
1150         (Tester._test_names):
1151         (_Loader):
1152         * Scripts/webkitpy/test/main_unittest.py:
1153         (TestStubs.integration_test_empty):
1154         (TestStubs):
1155         (TestStubs.serial_test_empty):
1156         (TestStubs.serial_integration_test_empty):
1157         (TesterTest._find_test_names):
1158         (TesterTest):
1159         (TesterTest.test_individual_names_are_not_run_twice):
1160         (TesterTest.test_integration_tests_are_not_found_by_default):
1161         (TesterTest.test_integration_tests_are_found):
1162
1163 2012-10-31  Dirk Pranke  <dpranke@chromium.org>
1164
1165         webkitpy: refactor common command line arguments for --platform, rebaseline commands
1166         https://bugs.webkit.org/show_bug.cgi?id=100800
1167
1168         Reviewed by Ojan Vafai.
1169
1170         This change shuffles around how we share command-line options
1171         between NRWT and the various webkit-patch rebaselining commands.
1172
1173         There are no functional changes in this patch but it should make
1174         things clearer and will be useful in a couple of upcoming patches.
1175
1176         * Scripts/webkitpy/layout_tests/port/__init__.py:
1177         * Scripts/webkitpy/layout_tests/port/factory.py:
1178         (platform_options):
1179         (configuration_options):
1180         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1181         (parse_args):
1182         * Scripts/webkitpy/tool/commands/queries.py:
1183         (PrintExpectations.__init__):
1184         (PrintBaselines.__init__):
1185         * Scripts/webkitpy/tool/commands/rebaseline.py:
1186         (AbstractRebaseliningCommand):
1187         (AbstractRebaseliningCommand.__init__):
1188         (RebaselineTest.__init__):
1189         (OptimizeBaselines.__init__):
1190         (AnalyzeBaselines.__init__):
1191         (AbstractParallelRebaselineCommand):
1192         (RebaselineJson.__init__):
1193         (RebaselineExpectations.__init__):
1194         (Rebaseline.__init__):
1195
1196 2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1197
1198         [NRWT] Xvfb driver is leaking application cache files
1199         https://bugs.webkit.org/show_bug.cgi?id=100864
1200
1201         Reviewed by Kenneth Rohde Christiansen.
1202
1203         Application Cache looks for XDG_CACHE_HOME which is now
1204         prepended with DUMPRENDERTREE_TEMP and cleaned up when
1205         the test worker finishes his job.
1206
1207         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
1208         (XvfbDriver._start):
1209
1210 2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1211
1212         [EFL] DRT doesn't clean up after itself
1213         https://bugs.webkit.org/show_bug.cgi?id=100346
1214
1215         Reviewed by Kenneth Rohde Christiansen.
1216
1217         The test driver exports an environment variable DUMPRENDERTREE_TEMP
1218         which is used by both DRT and WTR as the folder for storing icons,
1219         databases, application cache, etc, overriding the default XDG_* path.
1220
1221         We don't need to create these folders because in fact, they are never
1222         used and also never cleaned. Things created inside DUMPRENDERTREE_TEMP
1223         are automatically removed after the test run.
1224
1225         * Scripts/webkitpy/layout_tests/port/efl.py:
1226         (EflPort.setup_environ_for_server):
1227
1228 2012-10-31  Thiago Marcos P. Santos  <thiago.santos@intel.com>
1229
1230         [WTR] WebKitTestRunner is not cleaning up the icon database
1231         https://bugs.webkit.org/show_bug.cgi?id=100678
1232
1233         Reviewed by Kenneth Rohde Christiansen.
1234
1235         The icon database was not being set to the temporary folder created for
1236         the test runner by the test driver, which is removed automatically
1237         after the run.
1238
1239         * WebKitTestRunner/TestController.cpp:
1240         (WTR::TestController::initialize):
1241
1242 2012-10-31  Mike West  <mkwst@chromium.org>
1243
1244         Script run from an isolated world should bypass a page's CSP.
1245         https://bugs.webkit.org/show_bug.cgi?id=97398
1246
1247         Reviewed by Adam Barth.
1248
1249         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1250         (DRTTestRunner::DRTTestRunner):
1251         (DRTTestRunner::setIsolatedWorldContentSecurityPolicy):
1252         * DumpRenderTree/chromium/DRTTestRunner.h:
1253         (DRTTestRunner):
1254             Adding a mechanism to set the Content Security Policy for an
1255             isolated world to Chromium's testRunner.
1256
1257 2012-10-31  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1258
1259         [EFL][DRT] EventSender requires contextClick implementation
1260         https://bugs.webkit.org/show_bug.cgi?id=86091
1261
1262         Reviewed by Gyuyoung Kim.
1263
1264         Add contextClick for DumpRenderTreeEventSender basing on WebKit GTK
1265         implementation.
1266
1267         * DumpRenderTree/efl/EventSender.cpp:
1268         (getMenuItemTitleCallback):
1269         (setMenuItemTitleCallback):
1270         (menuItemClickCallback):
1271         (contextClickCallback):
1272
1273 2012-10-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1274
1275         [WTR] Memory leaks in TestWebKitAPI::didReceiveMessageFromInjectedBundle()
1276         https://bugs.webkit.org/show_bug.cgi?id=100770
1277
1278         Reviewed by Sam Weinig.
1279
1280         Adopt strings returned by WKStringCreateWithUTF8CString() in
1281         didReceiveMessageFromInjectedBundle() to avoid memory leaks.
1282
1283         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
1284         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1285
1286 2012-10-30  Kangil Han  <kangil.han@samsung.com>
1287
1288         Fix broken python unit test
1289         https://bugs.webkit.org/show_bug.cgi?id=100810
1290
1291         Reviewed by Dirk Pranke.
1292
1293         BUG 100755 has broken python unit test, e.g. assertion fail, since it modified baseline path.
1294         Therefore, this patch fixes it.
1295
1296         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1297         (TestRebaselineTest.test_baseline_directory):
1298
1299 2012-10-30  Dirk Pranke  <dpranke@chromium.org>
1300
1301         webkit-patch rebaseline*: add more helpful logging
1302         https://bugs.webkit.org/show_bug.cgi?id=100562
1303
1304         Reviewed by Ojan Vafai.
1305
1306         This change rewires the garden-o-matic and rebaseline* commands
1307         in webkit-patch so that --verbose propagates through all the
1308         subcommand invocations properly, and cleans up the logging so
1309         that you can actually tell what is happening. For now, we
1310         leave all of the logging at the logging.DEBUG level, which
1311         means that it gets mixed in will all the other debug logging noise
1312         and is harder to read, but we'll fix that in subsequent patches.
1313
1314         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1315         (BaselineOptimizer._platform):
1316         (BaselineOptimizer._move_baselines):
1317         (BaselineOptimizer.optimize):
1318         * Scripts/webkitpy/tool/commands/gardenomatic.py:
1319         (GardenOMatic.execute):
1320         * Scripts/webkitpy/tool/commands/rebaseline.py:
1321         (RebaselineTest._copy_existing_baseline):
1322         (RebaselineTest._rebaseline_test):
1323         (OptimizeBaselines._optimize_baseline):
1324         (OptimizeBaselines.execute):
1325         (AbstractParallelRebaselineCommand._run_webkit_patch):
1326         (AbstractParallelRebaselineCommand._rebaseline_commands):
1327         (AbstractParallelRebaselineCommand._files_to_add):
1328         (AbstractParallelRebaselineCommand._optimize_baselines):
1329         (AbstractParallelRebaselineCommand._rebaseline):
1330         (RebaselineExpectations._add_tests_to_rebaseline_for_port):
1331         (Rebaseline.execute):
1332         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1333         (GardeningHTTPServer.__init__):
1334         (GardeningHTTPRequestHandler):
1335         (GardeningHTTPRequestHandler._run_webkit_patch):
1336         (GardeningHTTPRequestHandler.rebaselineall):
1337
1338 2012-10-30  Dirk Pranke  <dpranke@chromium.org>
1339
1340         clean up tests for webkit-patch rebaseline* commands
1341         https://bugs.webkit.org/show_bug.cgi?id=100793
1342
1343         Reviewed by Ojan Vafai.
1344
1345         The tests in rebaseline_unittest.py had a lot of code cloning,
1346         and many of the tests tested whether things passed or failed by
1347         looking at what was logged instead of what was actually done;
1348         as a result the tests were kinda hard to understand and harder to
1349         maintain.
1350
1351         This patch adds hooks to MockWeb() and MockExecutive() so we can
1352         directly see which URLs were fetched and calls invoked, and
1353         then reworks all of the unit tests to be easier to follow and
1354         maintain and not sensitive to the logging. Also there were a
1355         couple of tests that were redundant.
1356
1357         There are no functional changes in this patch, and I verified that
1358         the coverage remains the same.
1359
1360         * Scripts/webkitpy/common/net/web_mock.py:
1361         (MockWeb.__init__):
1362         (MockWeb.get_binary):
1363         * Scripts/webkitpy/common/system/executive_mock.py:
1364         (MockExecutive.__init__):
1365         (MockExecutive.run_command):
1366         (MockExecutive.kill_all):
1367         (MockExecutive):
1368         (MockExecutive.kill_process):
1369         (MockExecutive.popen):
1370         (MockExecutive.run_in_parallel):
1371         (MockExecutive2):
1372         (MockExecutive2.__init__):
1373         (MockExecutive2.run_command):
1374         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1375         (_BaseTestCase):
1376         (_BaseTestCase.setUp):
1377         (_BaseTestCase._expand):
1378         (_BaseTestCase._read):
1379         (_BaseTestCase._write):
1380         (_BaseTestCase._zero_out_test_expectations):
1381         (TestRebaselineTest):
1382         (TestRebaselineTest.test_baseline_directory):
1383         (TestRebaselineTest.test_rebaseline_updates_expectations_file_noop):
1384         (test_rebaseline_updates_expectations_file):
1385         (test_rebaseline_does_not_include_overrides):
1386         (test_rebaseline_test):
1387         (test_rebaseline_test_and_print_scm_changes):
1388         (test_rebaseline_and_copy_test):
1389         (test_rebaseline_and_copy_test_no_existing_result):
1390         (test_rebaseline_and_copy_test_with_lion_result):
1391         (test_rebaseline_and_copy_no_overwrite_test):
1392         (test_rebaseline_test_internal_with_move_overwritten_baselines_to):
1393         (TestRebaselineJson):
1394         (TestRebaselineJson.setUp):
1395         (TestRebaselineJson.tearDown):
1396         (TestRebaselineJson.test_rebaseline_all):
1397         (TestRebaselineJson.test_rebaseline_debug):
1398         (TestRebaseline):
1399         (TestRebaseline.test_tests_to_update):
1400         (TestRebaseline.test_rebaseline):
1401         (TestRebaseline.test_rebaseline.rebaseline_stub):
1402         (TestRebaselineExpectations):
1403         (TestRebaselineExpectations.setUp):
1404         (TestRebaselineExpectations.test_rebaseline_expectations):
1405         (TestRebaselineExpectations.test_rebaseline_expectations_noop):
1406         (TestRebaselineExpectations.disabled_test_overrides_are_included_correctly):
1407
1408 2012-10-30  Dirk Pranke  <dpranke@chromium.org>
1409
1410         test-webkitpy: fix import of coverage so that it works in a clean install
1411         https://bugs.webkit.org/show_bug.cgi?id=100780
1412
1413         Reviewed by Tony Chang.
1414
1415         The coverage module is written so that the parent directory needs
1416         to be in PYTHONPATH; work around that ...
1417
1418         * Scripts/webkitpy/test/main_unittest.py:
1419         (TestStubs.test_empty):
1420         (TesterTest.test_individual_names_are_not_run_twice):
1421         (TesterTest):
1422         (TesterTest.integration_test_coverage_works):
1423         * Scripts/webkitpy/thirdparty/__init__.py:
1424         (AutoinstallImportHook._install_coverage):
1425
1426 2012-10-30  Anders Carlsson  <andersca@apple.com>
1427
1428         Another build fix.
1429
1430         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
1431         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1432
1433 2012-10-30  Anders Carlsson  <andersca@apple.com>
1434
1435         Build fix.
1436
1437         * WebKitTestRunner/mac/EventSenderProxy.mm:
1438         (WTR::EventSenderProxy::mouseScrollBy):
1439
1440 2012-10-30  Rick Byers  <rbyers@chromium.org>
1441
1442         [touchadjustment] touch-links-longpress tests passes incorrectly
1443         https://bugs.webkit.org/show_bug.cgi?id=96810
1444
1445         Reviewed by Antonio Gomes.
1446
1447         Add support for suppling width/height information for longpress
1448         gesture (as for other gestures like tapDown) for the purposes
1449         of touch adjustment.
1450
1451         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1452         (WebTestRunner):
1453         (WebTestRunner::EventSender::gestureEvent):
1454
1455 2012-10-29  Anders Carlsson  <andersca@apple.com>
1456
1457         Build WebKit as C++11 on Mac
1458         https://bugs.webkit.org/show_bug.cgi?id=100720
1459
1460         Reviewed by Daniel Bates.
1461
1462         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1463         * MiniBrowser/Configurations/Base.xcconfig:
1464         * TestWebKitAPI/Configurations/Base.xcconfig:
1465         * WebKitTestRunner/Configurations/Base.xcconfig:
1466         Add CLANG_CXX_LANGUAGE_STANDARD=gnu++0x.
1467
1468 2012-10-30  Christophe Dumez  <christophe.dumez@intel.com>
1469
1470         [EFL][JHBUILD] Update EFL libraries to v1.7.1 stable release
1471         https://bugs.webkit.org/show_bug.cgi?id=100759
1472
1473         Reviewed by Kenneth Rohde Christiansen.
1474
1475         Update Bump EFL libraries to the new stable release (v1.7.1)
1476         in JHBuild to pull the latest bug fixes.
1477
1478         * efl/jhbuild.modules:
1479
1480 2012-10-29  Anders Carlsson  <andersca@apple.com>
1481
1482         String::createCFString should return a RetainPtr
1483         https://bugs.webkit.org/show_bug.cgi?id=100419
1484
1485         Reviewed by Andreas Kling.
1486
1487         Update callers of String::createCFString.
1488
1489         * WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
1490         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
1491
1492 2012-10-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1493
1494         [WK2][WTR] WebKitTestRunner needs testRunner.queueLoadHTMLString
1495         https://bugs.webkit.org/show_bug.cgi?id=100747
1496
1497         Reviewed by Kenneth Rohde Christiansen.
1498
1499         Added testRunner.queueLoadHTMLString implementation.
1500
1501         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1502         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1503         (WTR::InjectedBundle::queueLoadHTMLString):
1504         (WTR):
1505         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1506         (InjectedBundle):
1507         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1508         (WTR::TestRunner::queueLoadHTMLString):
1509         (WTR):
1510         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1511         (TestRunner):
1512         * WebKitTestRunner/TestInvocation.cpp:
1513         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1514         * WebKitTestRunner/WorkQueueManager.cpp:
1515         (WTR::WorkQueueManager::queueLoadHTMLString):
1516         (WTR):
1517         * WebKitTestRunner/WorkQueueManager.h:
1518         (WorkQueueManager):
1519
1520 2012-10-30  Kangil Han  <kangil.han@samsung.com>
1521
1522         [EFL] Baseline search path should consider both WK1 and WK2 on layout test.
1523         https://bugs.webkit.org/show_bug.cgi?id=100755
1524
1525         Reviewed by Gyuyoung Kim.
1526
1527         Current implementation doesn't consider WK1 case in baseline search path.
1528         Therefore, this patch fixes it.
1529
1530         * Scripts/webkitpy/layout_tests/port/efl.py:
1531         (EflPort.default_baseline_search_path):
1532
1533 2012-10-30  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1534
1535         [QT][DRT] Remove unneeded testRunner.setMediaType() implementation
1536         https://bugs.webkit.org/show_bug.cgi?id=100740
1537
1538         Reviewed by Kenneth Rohde Christiansen.
1539
1540         Removed unneeded testRunner.setMediaType() implementation, as tests use
1541         cross-platform window.internals.settings.setMediaTypeOverride instead.
1542
1543         * DumpRenderTree/qt/TestRunnerQt.cpp:
1544         * DumpRenderTree/qt/TestRunnerQt.h:
1545         (TestRunner):
1546
1547 2012-10-30  Kangil Han  <kangil.han@samsung.com>
1548
1549         [EFL][DRT] Bitmap should show whole view area.
1550         https://bugs.webkit.org/show_bug.cgi?id=100642
1551
1552         Reviewed by Gyuyoung Kim.
1553
1554         css sticky position test cases haven't been passed even though implementation has been landed by BUG 95182.
1555         This is because current create bitmap implementation refers to geometry position that considers scroll movement even though
1556         paint does it. Therefore, this patch always reflects current view size and remove duplicated graphic operation to dump correct bitmap image.
1557
1558         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
1559         (createBitmapContextFromWebView):
1560
1561 2012-10-30  Jinwoo Song  <jinwoo7.song@samsung.com>
1562
1563         [EFL] Refactor tooltip callback signal in WebKit1
1564         https://bugs.webkit.org/show_bug.cgi?id=100571
1565
1566         Reviewed by Gyuyoung Kim.
1567
1568         Separate tooltip callback signal into 'tooltip,text,set'
1569         and 'tooltip,text,unset' to be consistent with WebKit2.
1570
1571         * EWebLauncher/main.c:
1572         (on_tooltip_text_set):
1573         (on_tooltip_text_unset):
1574         (browserCreate):
1575
1576 2012-10-29  Csaba Osztrogonác  <ossy@webkit.org>
1577
1578         Unreviewed, rolling out r132819.
1579         http://trac.webkit.org/changeset/132819
1580         https://bugs.webkit.org/show_bug.cgi?id=100388
1581
1582         It made layout testing 40% slower and storage tests assert
1583
1584         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1585         (WebCore::DumpRenderTree::DumpRenderTree):
1586         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1587         (WebCore::DumpRenderTree::dump):
1588         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1589         (DumpRenderTree):
1590         * DumpRenderTree/qt/TestRunnerQt.cpp:
1591         (TestRunner::reset):
1592         * DumpRenderTree/qt/TestRunnerQt.h:
1593         (TestRunner):
1594
1595 2012-10-29  Jochen Eisinger  <jochen@chromium.org>
1596
1597         [chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build
1598         https://bugs.webkit.org/show_bug.cgi?id=100658
1599
1600         Reviewed by Tony Chang.
1601
1602         Before, this was compiled into DumpRenderTree. I also dropped the
1603         include_dirs and dependencies block as TestRunner already has them.
1604
1605         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1606
1607 2012-10-29  Takashi Sakamoto  <tasak@google.com>
1608
1609         Unreviewed. Adding myself as a committer.
1610
1611         * Scripts/webkitpy/common/config/committers.py:
1612
1613 2012-10-28  Mark Rowe  <mrowe@apple.com>
1614
1615         Simplify Xcode configuration settings that used to vary between OS versions.
1616
1617         Reviewed by Dan Bernstein.
1618
1619         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1620         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1621         * MiniBrowser/Configurations/Base.xcconfig:
1622         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1623         * TestWebKitAPI/Configurations/Base.xcconfig:
1624         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1625         * WebKitTestRunner/Configurations/Base.xcconfig:
1626         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1627
1628 2012-10-28  Mark Rowe  <mrowe@apple.com>
1629
1630         Remove references to unsupported OS and Xcode versions.
1631
1632         Reviewed by Anders Carlsson.
1633
1634         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1635         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1636         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Removed.
1637         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1638         * MiniBrowser/Configurations/Base.xcconfig:
1639         * MiniBrowser/Configurations/CompilerVersion.xcconfig: Removed.
1640         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1641         * TestWebKitAPI/Configurations/Base.xcconfig:
1642         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Removed.
1643         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1644         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1645         * WebKitTestRunner/Configurations/Base.xcconfig:
1646         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Removed.
1647         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1648         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1649
1650 2012-10-26  Dirk Pranke  <dpranke@chromium.org>
1651
1652         webkitpy: change non-verbose log format for webkit-patch
1653         https://bugs.webkit.org/show_bug.cgi?id=100561
1654
1655         Reviewed by Ojan Vafai.
1656
1657         Logging the module name and the log level is annoying and nearly useless.
1658         For starters, this change removes that unless you are doing verbose/
1659         debug logging. In the future we should split out the concepts of
1660         verbose and debug logging (like we did in test-webkitpy and
1661         run-webkit-tests) so that you could get this in debug logging.
1662
1663         * Scripts/webkitpy/common/system/logutils.py:
1664         (_default_handlers):
1665         (configure_logging):
1666         * Scripts/webkitpy/common/system/logutils_unittest.py:
1667         (ConfigureLoggingTest.test_info_message):
1668         (ConfigureLoggingTest):
1669         (ConfigureLoggingTest.test_debug_message):
1670         (ConfigureLoggingTest.test_two_messages):
1671         (ConfigureLoggingVerboseTest):
1672         (ConfigureLoggingVerboseTest._logging_level):
1673         (ConfigureLoggingVerboseTest.test_info_message):
1674         (ConfigureLoggingVerboseTest.test_debug_message):
1675         (ConfigureLoggingCustomLevelTest.test_logged_message):
1676
1677 2012-10-29  Christophe Dumez  <christophe.dumez@intel.com>
1678
1679         [CMAKE] Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMakeLists.txt
1680         https://bugs.webkit.org/show_bug.cgi?id=100681
1681
1682         Reviewed by Anders Carlsson.
1683
1684         Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMake since
1685         it is needed by plugins/npruntime/npruntime-calls-with-null-npp.html
1686         layout test.
1687
1688         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1689
1690 2012-10-29  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1691
1692         [Qt] Flaky security tests
1693         https://bugs.webkit.org/show_bug.cgi?id=100388
1694
1695         Reviewed by Jocelyn Turcotte.
1696
1697         Disable text dumping and load a blank URL to ensure the documentLoader is cleared 
1698         before we start dumping text for the new page. Otherwise messages from the old page
1699         may end up in the text output of the new test.
1700
1701         This matches what WebKitTestRunner does, and reuses the Qt code for waiting for flag.
1702
1703         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1704         (WebCore::DumpRenderTree::DumpRenderTree):
1705         (WebCore::runUntil):
1706         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1707         (WebCore::DumpRenderTree::finishedResetting):
1708         (WebCore::DumpRenderTree::dump):
1709         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1710         (DumpRenderTree):
1711         * DumpRenderTree/qt/TestRunnerQt.cpp:
1712         (TestRunner::resetDumping):
1713         (TestRunner::reset):
1714         * DumpRenderTree/qt/TestRunnerQt.h:
1715         (TestRunner):
1716
1717 2012-10-29  Christophe Dumez  <christophe.dumez@intel.com>
1718
1719         [WK2][WKTR] Enable Shadow DOM at runtime if compiled with SHADOW_DOM support
1720         https://bugs.webkit.org/show_bug.cgi?id=100668
1721
1722         Reviewed by Kenneth Rohde Christiansen.
1723
1724         Enable Shadow DOM functionality at run time in WebKitTestRunner
1725         if compiled with SHADOW_DOM flag set. This is needed to run
1726         the Shadow DOM layout tests.
1727
1728         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1729         (WTR::InjectedBundle::beginTesting):
1730
1731 2012-10-29  Yael Aharon  <yael.aharon@intel.com>
1732
1733         [EFL][AC] Fix bugs preventing us from running layout tests with AC turned on
1734         https://bugs.webkit.org/show_bug.cgi?id=100598
1735
1736         Reviewed by Kenneth Rohde Christiansen.
1737
1738         Make sure to use opengl_x11 engine when AC is turned on and X11 is in use.
1739         We cannot create a gl context otherwise.
1740
1741         * MiniBrowser/efl/main.c:
1742         (elm_main):
1743         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1744         (WTR::initEcoreEvas):
1745         * DumpRenderTree/efl/DumpRenderTree.cpp:
1746         (initEcoreEvas):
1747         * EWebLauncher/efl/main.c:
1748         (windowCreate):
1749
1750 2012-10-29  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1751
1752         [EFL][WK2] REGRESSION(r132342): fast/events/frame-tab-focus.html fails
1753         https://bugs.webkit.org/show_bug.cgi?id=100646
1754
1755         Reviewed by Kenneth Rohde Christiansen.
1756
1757         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1758         (WTR::PlatformWebView::focus): Improve the check we perform to
1759         decide whether the focus should be taken out of the view before
1760         focusing it again so that we do not unnecessarily unfocus it and
1761         cause blur/focus events to be triggered. Instead of just verifying
1762         if the Evas_Object representing the view has focus, use the WK C
1763         API to check that the currently focused frame is not the main
1764         frame.
1765
1766 2012-10-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1767
1768         Unreviewed, rolling out r132782.
1769         http://trac.webkit.org/changeset/132782
1770         https://bugs.webkit.org/show_bug.cgi?id=100653
1771
1772         It made 400+ tests fail and 180 tests flakey on Qt (Requested
1773         by Ossy on #webkit).
1774
1775         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1776         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1777
1778 2012-10-29  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1779
1780         [Qt] Flaky security tests
1781         https://bugs.webkit.org/show_bug.cgi?id=100388
1782
1783         Reviewed by Jocelyn Turcotte.
1784
1785         Disable text output and load a blank URL to ensure the documentLoader is cleared
1786         before we start dumping text for the new page. Otherwise messages from the old page
1787         may end up in the text output of the new test.
1788
1789         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1790         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
1791
1792 2012-10-29  Jochen Eisinger  <jochen@chromium.org>
1793
1794         [chromium] remove remaining usages of webkit_support from the TestRunner library
1795         https://bugs.webkit.org/show_bug.cgi?id=100344
1796
1797         Reviewed by Adam Barth.
1798
1799         The most important part is to not rely on calling out to gdk/X11 to
1800         translate keycodes to hardware keycodes, as this is not possible inside
1801         the sandbox.
1802
1803         * DumpRenderTree/DumpRenderTree.gypi:
1804         * DumpRenderTree/chromium/DRTTestRunner.h:
1805         (WebKit):
1806         (webkit_support):
1807         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1808         (WebTestDelegate):
1809         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
1810         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
1811         (WebTestRunner):
1812         (WebTestRunner::EventSender::doDragDrop):
1813         (WebTestRunner::EventSender::updateClickCountForButton):
1814         (WebTestRunner::EventSender::mouseDown):
1815         (WebTestRunner::EventSender::mouseUp):
1816         (WebTestRunner::EventSender::mouseMoveTo):
1817         (WebTestRunner::EventSender::keyDown):
1818         (WebTestRunner::EventSender::replaySavedEvents):
1819         (WebTestRunner::EventSender::contextClick):
1820         (WebTestRunner::EventSender::beginDragWithFiles):
1821         (WebTestRunner::EventSender::sendCurrentTouchEvent):
1822         (WebTestRunner::EventSender::handleMouseWheel):
1823         (WebTestRunner::EventSender::gestureEvent):
1824         (WebTestRunner::EventSender::gestureFlingCancel):
1825         (WebTestRunner::EventSender::gestureFlingStart):
1826         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added.
1827         (WebTestRunner):
1828         (WebTestRunner::NativeKeyCodeForWindowsKeyCode):
1829         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.
1830         (WebTestRunner):
1831         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
1832         (TestDelegate):
1833         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1834         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1835         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1836         (WebTestInterfaces::Internal):
1837         (WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond):
1838         (WebTestRunner):
1839         (WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path):
1840         * DumpRenderTree/chromium/WebViewHost.cpp:
1841         (WebViewHost::getCurrentTimeInMillisecond):
1842         (WebViewHost::getAbsoluteWebStringFromUTF8Path):
1843         * DumpRenderTree/chromium/WebViewHost.h:
1844         (WebViewHost):
1845
1846 2012-10-29  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1847
1848         Unreviewed. Add jonathan.dong@torchmobile.com.cn as a committer.
1849         https://bugs.webkit.org/show_bug.cgi?id=100629
1850
1851         * Scripts/webkitpy/common/config/committers.py:
1852
1853 2012-10-27  Dan Bernstein  <mitz@apple.com>
1854
1855         REAL_PLATFORM_NAME build setting is no longer needed
1856         https://bugs.webkit.org/show_bug.cgi?id=100587
1857
1858         Reviewed by Mark Rowe.
1859
1860         Removed the definition of REAL_PLATFORM_NAME and replaced references to it with references
1861         to PLATFORM_NAME.
1862
1863         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1864         * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
1865         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1866         * MiniBrowser/Configurations/Base.xcconfig:
1867         * MiniBrowser/Configurations/CompilerVersion.xcconfig:
1868         * TestWebKitAPI/Configurations/Base.xcconfig:
1869         * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
1870         * WebKitTestRunner/Configurations/Base.xcconfig:
1871         * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
1872         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1873
1874 2012-10-26  Anders Carlsson  <andersca@apple.com>
1875
1876         Crash when making NPRuntime calls with a null NPP pointer
1877         https://bugs.webkit.org/show_bug.cgi?id=100569
1878
1879         Reviewed by Darin Adler.
1880
1881         Add new NPRuntimeCallsWithNullNPP plug-in test.
1882
1883         * DumpRenderTree/DumpRenderTree.gypi:
1884         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1885         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1886         (PluginTest::NPN_ReleaseVariantValue):
1887         (PluginTest::netscapeFuncs):
1888         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1889         (PluginTest):
1890         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp: Added.
1891         (NPRuntimeCallsWithNullNPP):
1892         (NPRuntimeCallsWithNullNPP::NPRuntimeCallsWithNullNPP):
1893         (NPRuntimeCallsWithNullNPP::NPP_New):
1894         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1895         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1896         * GNUmakefile.am:
1897
1898 2012-10-26  Dominic Mazzoni  <dmazzoni@google.com>
1899
1900         AX: Notification should be sent when accessibilityIsIgnored changes
1901         https://bugs.webkit.org/show_bug.cgi?id=99547
1902
1903         Reviewed by Chris Fleizach.
1904
1905         Add additional accessibility notifications.
1906
1907         * DumpRenderTree/chromium/WebViewHost.cpp:
1908         (WebViewHost::postAccessibilityNotification):
1909
1910 2012-10-25  Roger Fong  <roger_fong@apple.com>
1911
1912         Get rid of (<X%) failing output for old-run-webkit-tests.
1913         https://bugs.webkit.org/show_bug.cgi?id=100447
1914
1915         Reviewed by Jessie Berlin.
1916
1917         Not a particularly useful piece of information. It's pretty much never above 1%.
1918         new-run-webkit-tests does not output this either.
1919
1920         * Scripts/old-run-webkit-tests:
1921         (printResults):
1922
1923 2012-10-26  Xianzhu Wang  <wangxianzhu@chromium.org>
1924
1925         Build bot gives incorrect link to EWS build failure
1926         https://bugs.webkit.org/show_bug.cgi?id=100436
1927
1928         Reviewed by Adam Barth.
1929
1930         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1931         (MockCommitQueue.__init__):
1932         (MockCommitQueue.command_failed): Return incremental failure_status_id
1933         (CommitQueueTaskTest.test_red_tree_patch_rejection): Check failure_status_id
1934         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1935         (PatchAnalysisTask._test_patch): Use the failure_status_id of test with patch when test without patch fails and test with patch has unexpected failures.
1936
1937 2012-10-26  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1938
1939         webkitpy: Pass the `Listen' Apache directive from webkitpy, not the httpd.conf files.
1940         https://bugs.webkit.org/show_bug.cgi?id=98602
1941
1942         Reviewed by Dirk Pranke.
1943
1944         Unify all the different `Listen' directives present in the several
1945         httpd.conf files we have in LayoutTests/http/conf. For one, we
1946         were already passing `Listen 127.0.0.1:8000' via webkitpy before,
1947         and opening the other ports from the conf files.
1948
1949         The configuration files differed mostly in the way they handled
1950         IPV6 ports. Some of them did not listen to IPV6 ports because the
1951         systems which used them sometimes did not have IPV6 support. The
1952         `http_server_supports_ipv6' method has been added to Port to
1953         address that. cygwin, on its turn, still seems to use Apache 1.3,
1954         which does not support IPV6 at all; the newly-added method has a
1955         special case for that. Plus, perform a socket.getaddrinfo() call
1956         the same way Apache itself does so we are sure we only enable IPV6
1957         when setting that up in the httpd server is not going to fail.
1958
1959         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1960         (MockPlatformInfo.is_cygwin):
1961         * Scripts/webkitpy/layout_tests/port/base.py:
1962         (Port.baseline_version_dir):
1963         (Port.to.start_websocket_server):
1964         (Port.to):
1965         (Port.to.http_server_supports_ipv6):
1966         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1967         (PortTest.test_http_server_supports_ipv6):
1968         (PortTest.test_build_path):
1969         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
1970         (LayoutTestApacheHttpd):
1971         (LayoutTestApacheHttpd.__init__):
1972
1973 2012-10-26  David Barton  <dbarton@mathscribe.com>
1974
1975         Unreviewed. Update my IRC nickname to a registered one.
1976
1977         * Scripts/webkitpy/common/config/committers.py:
1978
1979 2012-10-26  Simon Hausmann  <simon.hausmann@digia.com>
1980
1981         [Qt] Fix the LLInt build on Windows
1982         https://bugs.webkit.org/show_bug.cgi?id=97648
1983
1984         Reviewed by Tor Arne Vestbø.
1985
1986         Added BIN_EXTENSION variable - similar to automake - that expands to .exe as suffix for
1987         executable programs on Windows. Empty otherwise. Also added support for force_build_all
1988         to allow overriding us disabling build_all for TEMPLATE = app.
1989
1990         * qmake/mkspecs/features/default_pre.prf:
1991
1992 2012-10-26  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1993
1994         [BlackBerry] Support pixel tests for BlackBerry DRT
1995         https://bugs.webkit.org/show_bug.cgi?id=100210
1996
1997         Reviewed by Rob Buis.
1998
1999         (The following 2 files are missed in previous patch(r132582), adding them
2000         again.)
2001
2002         * DumpRenderTree/blackberry/build: Added.
2003         * DumpRenderTree/blackberry/src.pro: Added.
2004         Adds 2 files for building ImageDiff, by Christopher Wells.
2005
2006 2012-10-26  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2007
2008         Add feature flags for CSS Device Adaptation
2009         https://bugs.webkit.org/show_bug.cgi?id=95960
2010
2011         Reviewed by Kenneth Rohde Christiansen.
2012
2013         * Scripts/webkitperl/FeatureList.pm:
2014
2015 2012-10-26  Sheriff Bot  <webkit.review.bot@gmail.com>
2016
2017         Unreviewed, rolling out r132552.
2018         http://trac.webkit.org/changeset/132552
2019         https://bugs.webkit.org/show_bug.cgi?id=100486
2020
2021         Makes typeahead tests crash in debug. (Requested by pfeldman
2022         on #webkit).
2023
2024         * DumpRenderTree/DumpRenderTree.gypi:
2025         * DumpRenderTree/chromium/DRTTestRunner.h:
2026         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2027         (WebTestDelegate):
2028         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
2029         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2030         (WebTestRunner):
2031         (WebTestRunner::EventSender::doDragDrop):
2032         (WebTestRunner::EventSender::updateClickCountForButton):
2033         (WebTestRunner::EventSender::mouseDown):
2034         (WebTestRunner::EventSender::mouseUp):
2035         (WebTestRunner::EventSender::mouseMoveTo):
2036         (WebTestRunner::EventSender::keyDown):
2037         (WebTestRunner::EventSender::replaySavedEvents):
2038         (WebTestRunner::EventSender::contextClick):
2039         (WebTestRunner::EventSender::beginDragWithFiles):
2040         (WebTestRunner::EventSender::sendCurrentTouchEvent):
2041         (WebTestRunner::EventSender::handleMouseWheel):
2042         (WebTestRunner::EventSender::gestureEvent):
2043         (WebTestRunner::EventSender::gestureFlingCancel):
2044         (WebTestRunner::EventSender::gestureFlingStart):
2045         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
2046         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
2047         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2048         (TestDelegate):
2049         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2050         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2051         (WebKit):
2052         (webkit_support):
2053         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2054         (WebTestInterfaces::Internal):
2055         * DumpRenderTree/chromium/WebViewHost.cpp:
2056         * DumpRenderTree/chromium/WebViewHost.h:
2057         (WebViewHost):
2058
2059 2012-10-26  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2060
2061         [BlackBerry] Support pixel tests for BlackBerry DRT
2062         https://bugs.webkit.org/show_bug.cgi?id=100210
2063
2064         Reviewed by Rob Buis.
2065
2066         The implementation is based on the patch from Christopher Wells.
2067
2068         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
2069         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
2070         (BlackBerry::WebKit::DumpRenderTree::runTest):
2071         (BlackBerry::WebKit::DumpRenderTree::runCurrentTest):
2072         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
2073         (BlackBerry::WebKit::DumpRenderTree::runTests):
2074         (BlackBerry::WebKit::DumpRenderTree::dump):
2075         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
2076         (DumpRenderTree):
2077
2078         * DumpRenderTree/blackberry/PNGImageEncoder.cpp:
2079         (BGRAtoRGBA):
2080         (encodeBitmapToPNG):
2081         * DumpRenderTree/blackberry/PNGImageEncoder.h:
2082         The changes to PNGImageEncoder files are from master_40, patched by Tyler
2083         Abbott and Rob Buis.
2084
2085         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2086         (createBitmapContextFromWebView):
2087         (computeMD5HashStringForBitmapContext):
2088         (printPNG):
2089         (dumpBitmap):
2090         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h:
2091         (BitmapContext::createByAdoptingData):
2092         (BitmapContext::~BitmapContext):
2093         (BitmapContext):
2094         (BitmapContext::BitmapContext):
2095
2096         * DumpRenderTree/blackberry/build: Added.
2097         * DumpRenderTree/blackberry/src.pro: Added.
2098         Adds 2 files for building ImageDiff, by Christopher Wells.
2099
2100 2012-10-25  Min Qin  <qinmin@chromium.org>
2101
2102         Fix a layout test crash if a TestWebkitPlugin is put inside an iframe
2103         https://bugs.webkit.org/show_bug.cgi?id=100406
2104
2105         Reviewed by Adam Barth.
2106
2107         Resize the context with an empty rect will cause a gl_error in gles2_cmd_decoder.cc.
2108         Don't paint the plugin if m_rect is empty.
2109
2110         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2111         (TestWebPlugin::updateGeometry):
2112
2113 2012-10-25  Jinwoo Song  <jinwoo7.song@samsung.com>
2114
2115         [EFL][WK2] Display tooltip in MiniBrowser
2116         https://bugs.webkit.org/show_bug.cgi?id=99322
2117
2118         Reviewed by Kenneth Rohde Christiansen.
2119
2120         Display tooltip in MiniBrowser using elm_object_tooltip_text_set().
2121
2122         * MiniBrowser/efl/main.c:
2123         (on_tooltip_text_set):
2124         (on_tooltip_text_unset):
2125         (window_create):
2126
2127 2012-10-25  Jochen Eisinger  <jochen@chromium.org>
2128
2129         [chromium] remove remaining usages of webkit_support from the TestRunner library
2130         https://bugs.webkit.org/show_bug.cgi?id=100344
2131
2132         Reviewed by Adam Barth.
2133
2134         The most important part is to not rely on calling out to gdk/X11 to
2135         translate keycodes to hardware keycodes, as this is not possible inside
2136         the sandbox.
2137
2138         * DumpRenderTree/DumpRenderTree.gypi:
2139         * DumpRenderTree/chromium/DRTTestRunner.h:
2140         (WebKit):
2141         (webkit_support):
2142         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2143         (WebTestDelegate):
2144         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h:
2145         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2146         (WebTestRunner):
2147         (WebTestRunner::EventSender::doDragDrop):
2148         (WebTestRunner::EventSender::updateClickCountForButton):
2149         (WebTestRunner::EventSender::mouseDown):
2150         (WebTestRunner::EventSender::mouseUp):
2151         (WebTestRunner::EventSender::mouseMoveTo):
2152         (WebTestRunner::EventSender::keyDown):
2153         (WebTestRunner::EventSender::replaySavedEvents):
2154         (WebTestRunner::EventSender::contextClick):
2155         (WebTestRunner::EventSender::beginDragWithFiles):
2156         (WebTestRunner::EventSender::sendCurrentTouchEvent):
2157         (WebTestRunner::EventSender::handleMouseWheel):
2158         (WebTestRunner::EventSender::gestureEvent):
2159         (WebTestRunner::EventSender::gestureFlingCancel):
2160         (WebTestRunner::EventSender::gestureFlingStart):
2161         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Added.
2162         (WebTestRunner):
2163         (WebTestRunner::NativeKeyCodeForWindowsKeyCode):
2164         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.
2165         (WebTestRunner):
2166         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2167         (TestDelegate):
2168         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2169         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2170         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2171         (WebTestInterfaces::Internal):
2172         (WebTestRunner::WebTestInterfaces::Internal::getCurrentTimeInMillisecond):
2173         (WebTestRunner):
2174         (WebTestRunner::WebTestInterfaces::Internal::getAbsoluteWebStringFromUTF8Path):
2175         * DumpRenderTree/chromium/WebViewHost.cpp:
2176         (WebViewHost::getCurrentTimeInMillisecond):
2177         (WebViewHost::getAbsoluteWebStringFromUTF8Path):
2178         * DumpRenderTree/chromium/WebViewHost.h:
2179         (WebViewHost):
2180
2181 2012-10-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2182
2183         Unreviewed, rolling out r132514.
2184         http://trac.webkit.org/changeset/132514
2185         https://bugs.webkit.org/show_bug.cgi?id=100440
2186
2187         "Broke chromium content_browsertests AccessibilityAriaMenu
2188         AccessibilityInputRange AccessibilityListMarkers" (Requested
2189         by scheib on #webkit).
2190
2191         * DumpRenderTree/chromium/WebViewHost.cpp:
2192         (WebViewHost::postAccessibilityNotification):
2193
2194 2012-10-25  Dirk Pranke  <dpranke@chromium.org>
2195
2196         rwt --lint-test-files doesn't handle the cascade properly
2197         https://bugs.webkit.org/show_bug.cgi?id=100315
2198
2199         Reviewed by Ojan Vafai.
2200
2201         We were only linting the first file in each port's list of
2202         expectations.
2203
2204         This change pushes more of the logic for linting files into
2205         the TestExpectations classes themselves, but it's still a bit of
2206         a hack. A better solution will require splitting out the actual
2207         parsing of the files from the TestExpectations constructor.
2208
2209         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2210         (TestExpectations):
2211         (TestExpectations.__init__):
2212         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2213         (parse_exp):
2214         (SkippedTests.check):
2215         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2216         (lint):
2217         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2218         (LintTest.test_all_configurations.FakePort.__init__):
2219         (LintTest.test_all_configurations):
2220         (LintTest.test_lint_test_files__errors):
2221         * Scripts/webkitpy/style/checkers/test_expectations.py:
2222         (TestExpectationsChecker.check_test_expectations):
2223
2224 2012-10-25  Zan Dobersek  <zandobersek@gmail.com>
2225
2226         Unreviewed GTK gardening.
2227
2228         Skipping the atspi-basic-hierarchy test case in the TestWebKitAccessibility
2229         WebKit2 API test since the test is currently failing.
2230
2231         * Scripts/run-gtk-tests:
2232         (TestRunner):
2233
2234 2012-10-25  Dominic Mazzoni  <dmazzoni@google.com>
2235
2236         AX: Notification should be sent when accessibilityIsIgnored changes
2237         https://bugs.webkit.org/show_bug.cgi?id=99547
2238
2239         Reviewed by Chris Fleizach.
2240
2241         Add additional accessibility notifications.
2242
2243         * DumpRenderTree/chromium/WebViewHost.cpp:
2244         (WebViewHost::postAccessibilityNotification):
2245
2246 2012-10-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2247
2248         Conditionalize XHR timeout support
2249         https://bugs.webkit.org/show_bug.cgi?id=100356
2250
2251         Reviewed by Adam Barth.
2252
2253         Adding XHR_TIMEOUT feature in perl and qmake files.
2254
2255         * Scripts/webkitperl/FeatureList.pm:
2256         * qmake/mkspecs/features/features.pri:
2257
2258 2012-10-25  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2259
2260         Unreviewed. Update my contact info.
2261
2262         * Scripts/webkitpy/common/config/committers.py:
2263
2264 2012-10-25  Terry Anderson  <tdanderson@chromium.org>
2265
2266         Unreviewed. Adding myself as a committer.
2267
2268         * Scripts/webkitpy/common/config/committers.py:
2269
2270 2012-10-25  Zeno Albisser  <zeno@webkit.org>
2271
2272         [Qt] Adjust library name in webkitdirs.pm after r131300.
2273         https://bugs.webkit.org/show_bug.cgi?id=100376
2274
2275         The library was renamed from QtWebKit to QtWebKitWidgets.
2276         run-launcher was still looking for QtWebKit.
2277
2278         Reviewed by Simon Hausmann.
2279
2280         * Scripts/webkitdirs.pm:
2281         (builtDylibPathForName):
2282
2283 2012-10-22  Mikhail Naganov  <mnaganov@chromium.org>
2284
2285         [Chromium] Add supportMultipleWindows setting, needed for Android
2286         https://bugs.webkit.org/show_bug.cgi?id=99716
2287
2288         Reviewed by Adam Barth.
2289
2290         Add supportMultipleWindows settings for reusing the same view when
2291         opening popups. This is required for emulating the behavior of
2292         Android WebView. Adding into WebCore, as other ports might want to
2293         use this setting in the future.
2294
2295         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2296         (DRTTestRunner::overridePreference):
2297         * DumpRenderTree/chromium/WebPreferences.cpp:
2298         (WebPreferences::reset):
2299         (WebPreferences::applyTo):
2300         * DumpRenderTree/chromium/WebPreferences.h:
2301         (WebPreferences):
2302
2303 2012-10-25  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2304
2305         [EFL][WK2] JavaScript popups are not focused when opened
2306         https://bugs.webkit.org/show_bug.cgi?id=100354
2307
2308         Reviewed by Kenneth Rohde Christiansen.
2309
2310         Move focus to the JavaScript popups when opened so that the key events
2311         are forwarded to the popups instead of web view.
2312
2313         * MiniBrowser/efl/main.c:
2314         (on_javascript_alert):
2315         (on_javascript_confirm):
2316         (on_javascript_prompt):
2317
2318 2012-10-25  Eugene Klyuchnikov  <eustas.bug@gmail.com>
2319
2320         Web Inspector: Fix "check-inspector-strings" script and fix localized strings.
2321         https://bugs.webkit.org/show_bug.cgi?id=100090
2322
2323         Reviewed by Vsevolod Vlasov.
2324
2325         Script "check-inspector-strings" seems to be broken.
2326         Fixed it, refined search algorithm.
2327
2328         * Scripts/check-inspector-strings: Fixed and refined.
2329
2330 2012-10-24  Dirk Pranke  <dpranke@chromium.org>
2331
2332         nrwt: fix a couple of minor crashing issues under cygwin
2333         https://bugs.webkit.org/show_bug.cgi?id=100309
2334
2335         Reviewed by Ojan Vafai.
2336
2337         Cygwin was crashing on a null object reference and then
2338         an oserror in kill().
2339
2340         * Scripts/webkitpy/common/system/executive.py:
2341         (Executive.kill_process):
2342         * Scripts/webkitpy/layout_tests/port/server_process.py:
2343         (ServerProcess.stop):
2344
2345 2012-10-24  Dirk Pranke  <dpranke@chromium.org>
2346
2347         nrwt: truncate meter lines properly on windows
2348         https://bugs.webkit.org/show_bug.cgi?id=100062
2349
2350         Reviewed by Tony Chang.
2351
2352         This change adds the code to figure out the terminal width
2353         on windows (it was already there for Unixen) and moves it
2354         to a platform-specific object.
2355
2356         * Scripts/webkitpy/common/system/platforminfo.py:
2357         (PlatformInfo.terminal_width):
2358         * Scripts/webkitpy/common/system/platforminfo_mock.py:
2359         (MockPlatformInfo.total_bytes_memory):
2360         (MockPlatformInfo):
2361         (MockPlatformInfo.terminal_width):
2362         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2363         (MeteredStream.__init__):
2364         (MeteredStream.number_of_columns):
2365         (MeteredStream.flush):
2366         * Scripts/webkitpy/layout_tests/views/printing.py:
2367         (Printer.__init__):
2368         (Printer._test_status_line):
2369
2370 2012-10-24  Dirk Pranke  <dpranke@chromium.org>
2371
2372         tweak debug logging in webkit-patch optimize-baselines
2373         https://bugs.webkit.org/show_bug.cgi?id=100294
2374
2375         Reviewed by Ojan Vafai.
2376
2377         This changes the logging to print out the baselines found
2378         (and their checksums) even when we don't do anything.
2379
2380         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
2381         (BaselineOptimizer.optimize):
2382
2383 2012-10-24  Sailesh Agrawal  <sail@chromium.org>
2384
2385         Incorrect keycodes for numpad /, -, +, .
2386         https://bugs.webkit.org/show_bug.cgi?id=99188
2387
2388         Reviewed by Tony Chang.
2389
2390         Add key mappings for all numpad keys.
2391
2392         * DumpRenderTree/mac/EventSendingController.mm:
2393         (KeyMappingEntry):
2394         (-[EventSendingController keyDown:withModifiers:withLocation:]): Added all numpad keys.
2395
2396 2012-10-24  Dirk Pranke  <dpranke@chromium.org>
2397
2398         webkitpy: clean up references to Skipped files
2399         https://bugs.webkit.org/show_bug.cgi?id=100045
2400
2401         Reviewed by Ojan Vafai.
2402
2403         Since they are no longer used or needed ...
2404
2405         * Scripts/webkitpy/layout_tests/port/apple.py:
2406         (ApplePort._generate_all_test_configurations):
2407         * Scripts/webkitpy/layout_tests/port/base.py:
2408         (Port.skipped_layout_tests):
2409         (Port.expectations_files):
2410         (Port._wk2_port_name):
2411         * Scripts/webkitpy/layout_tests/port/gtk.py:
2412         (GtkPort):
2413         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2414         (MacTest.test_default_timeout_ms):
2415         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2416         (test_expectations_files):
2417         (test_expectations_files.platform_dirs):
2418         * Scripts/webkitpy/layout_tests/port/qt.py:
2419         (QtPort.__init__):
2420
2421 2012-10-24  Jochen Eisinger  <jochen@chromium.org>
2422
2423         [chromium] Use include paths relative to Source/ in the TestRunner's public API
2424         https://bugs.webkit.org/show_bug.cgi?id=100079
2425
2426         Reviewed by Adam Barth.
2427
2428         For a inside-chromium build, we usually don't add the WebKit API paths
2429         as include paths, so including files by name only does not work.
2430
2431         Eventually we might want to move to a model where all includes are
2432         relative to Source/, so we're using that here already now.
2433
2434         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2435         * DumpRenderTree/chromium/TestRunner/public/WebEventSender.h:
2436         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2437
2438 2012-10-24  Ojan Vafai  <ojan@chromium.org>
2439
2440         Show an error when there are no completed builds in the past 20 runs
2441         https://bugs.webkit.org/show_bug.cgi?id=100266
2442
2443         Reviewed by Dimitri Glazkov.
2444
2445         Right now we get a cryptic JS error in the console when loading the gtk port. This at least gives an error in
2446         the notification stream. We should probably tweak this UI to make it so we can make
2447         errors in the notification stream stick out (e.g. make the text red).
2448
2449         We should also consider making the number of runs to load dynamic (e.g. if 20 runs don't work,
2450         try 40).
2451
2452         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
2453         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
2454         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
2455
2456 2012-10-24  Ian Vollick  <vollick@chromium.org>
2457
2458         [chromium] Explicitly disable accelerated animations in DRT
2459         https://bugs.webkit.org/show_bug.cgi?id=100241
2460
2461         Reviewed by Adrienne Walker.
2462
2463         Disable accelerated animations by default in DRT.        
2464
2465         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2466         (main):
2467         * DumpRenderTree/chromium/TestShell.cpp:
2468         (TestShell::setAcceleratedAnimationEnabled):
2469         * DumpRenderTree/chromium/TestShell.h:
2470         (TestShell):
2471
2472 2012-10-24  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2473
2474         [Qt] Move the QQuickWebViewExperimental pointer to QQuickWebViewPrivate
2475         https://bugs.webkit.org/show_bug.cgi?id=100253
2476
2477         Reviewed by Kenneth Rohde Christiansen.
2478
2479         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2480         (WTR::WrapperWindow::handleStatusChanged):
2481         Use QQuickWebView::experimental rather than creating a new instance.
2482
2483 2012-10-24  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2484
2485         [EFL] run-webkit-tests writes garbage on stderr when running on Xvfb
2486         https://bugs.webkit.org/show_bug.cgi?id=100243
2487
2488         Reviewed by Kenneth Rohde Christiansen.
2489
2490         These errors generate noise on the reports and in some cases, like when
2491         running perf tests, makes the test fail. By using Xext, we can add a
2492         dummy handler to ignore these errors.
2493
2494         We could have added this handler on the top level EWK API, but that
2495         would be intrusive and could override handlers defined by the user.
2496
2497         * WebKitTestRunner/PlatformEfl.cmake:
2498         * WebKitTestRunner/efl/main.cpp:
2499         (dummyExtensionErrorHandler):
2500         (main):
2501
2502 2012-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2503
2504         Unreviewed. Fix the GTK+ build.
2505
2506         * TestWebKitAPI/GNUmakefile.am: Add GTK_FLAGS to
2507         libTestWebKitAPIMain and webcore cflags to TestGtk.
2508
2509 2012-10-24  Zeno Albisser  <zeno@webkit.org>
2510
2511         Implement GraphicsSurface for Windows.
2512         https://bugs.webkit.org/show_bug.cgi?id=98147
2513
2514         Reviewed by Kenneth Rohde Christiansen.
2515
2516         * qmake/mkspecs/features/features.prf:
2517                 Activate GraphicsSurface on windows in case opengles2 (ANGLE)
2518                 is available in QT_CONFIG.
2519
2520 2012-10-24  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2521
2522         [EFL][WK2] fast/repaint/delete-into-nested-block.html and fast/repaint/4776765.html are flaky
2523         https://bugs.webkit.org/show_bug.cgi?id=100010
2524
2525         Reviewed by Kenneth Rohde Christiansen.
2526
2527         Force the main view to receive focus even if Evas already
2528         considers it to be focused.
2529
2530         It might happen that a different frame is focused by a page and
2531         the focus change notification does not reach Evas. When another
2532         test is run, the main frame is then not considered to be focused
2533         by WebCore, and things such as focus rings are not drawn as
2534         expected.
2535
2536         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2537         (WTR::PlatformWebView::focus):
2538
2539 2012-10-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2540
2541         Unreviewed, rolling out r132333.
2542         http://trac.webkit.org/changeset/132333
2543         https://bugs.webkit.org/show_bug.cgi?id=100234
2544
2545         Crashes many tests on the EFL-WK2 bot. (Requested by rakuco on
2546         #webkit).
2547
2548         * WebKitTestRunner/TestController.cpp:
2549         (WTR::TestController::resetStateToConsistentValues):
2550         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2551         (WTR::TestController::platformInitializeContext):
2552
2553 2012-10-24  Dongwoo Joshua Im  <dw.im@samsung.com>
2554
2555         [GTK] Fix build break - undefined reference to 'gtk_init'
2556         https://bugs.webkit.org/show_bug.cgi?id=100221
2557
2558         Unreviewed build fix.
2559
2560         GTK_LIBS is needed for TestWTF.
2561
2562         * TestWebKitAPI/GNUmakefile.am:
2563
2564 2012-10-24  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2565
2566         WebKitTestRunner needs to turn on 'setContinuousSpellCheckingEnabled'
2567         https://bugs.webkit.org/show_bug.cgi?id=93611
2568
2569         Reviewed by Hajime Morita.
2570
2571         WebKitTestRunner enables spelling feature to pass the layout tests from editing/spelling.
2572
2573         * WebKitTestRunner/TestController.cpp:
2574         (WTR::TestController::resetStateToConsistentValues):
2575         Enables spelling by WebKit2 C API.
2576
2577         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2578         (WTR::TestController::platformInitializeContext):
2579         Attaches WKTextChecker's client and sets default language for WebKit2-EFL port.
2580
2581 2012-10-24  Mario Sanchez Prada  <mario@webkit.org>
2582
2583         [WK2] [GTK] TestWebKitAccessibility is not being run
2584         https://bugs.webkit.org/show_bug.cgi?id=100102
2585
2586         Reviewed by Carlos Garcia Campos.
2587
2588         Removed wrong early return in _start_accessibility_daemons().
2589
2590         * Scripts/run-gtk-tests:
2591         (TestRunner._lookup_atspi2_binary): Removed wrong line.
2592
2593 2012-10-24  Noel Gordon  <noel.gordon@gmail.com>
2594
2595         [chromium] Plumb DRT WebkitShouldRespectImageOrientation through to page settings 
2596         https://bugs.webkit.org/show_bug.cgi?id=100197
2597
2598         Reviewed by Kent Tamura.
2599
2600         fast/images/exif-orientation.html and fast/images/exif-orientation-css.html require a DRT
2601         WebkitShouldRespectImageOrientation preference.  Add the chromium implementation for this
2602         preference and plumb it through to page settings.
2603
2604         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2605         (DRTTestRunner::overridePreference): Update the tests WebkitShouldRespectImageOrientation
2606         setting in DRT prefs.
2607         * DumpRenderTree/chromium/WebPreferences.cpp:
2608         (WebPreferences::reset): Disable the preference before and after each test.
2609         (WebPreferences::applyTo): Apply the preference to the page settings of each test.
2610         * DumpRenderTree/chromium/WebPreferences.h:
2611         (WebPreferences):
2612
2613 2012-10-23  Carlos Garcia Campos  <cgarcia@igalia.com>
2614
2615         [GTK] TestWebKitAPI/TestWebKit2 and TestWebKitAPI/TestGtk link to the installed libs
2616         https://bugs.webkit.org/show_bug.cgi?id=100134
2617
2618         Reviewed by Martin Robinson.
2619
2620         Do not share the LDADD variable among TestWTF, TestWebKit2 and
2621         TestGtk.
2622
2623         * TestWebKitAPI/GNUmakefile.am:
2624
2625 2012-10-23  Kihong Kwon  <kihong.kwon@samsung.com>
2626
2627         Unreviewed. Adding myself as committer.
2628
2629         * Scripts/webkitpy/common/config/committers.py:
2630
2631 2012-10-23  Dan Bernstein  <mitz@apple.com>
2632
2633         Tools changes for <rdar://problem/2966974> [mac] Kerning and ligatures are not enabled by default
2634         https://bugs.webkit.org/show_bug.cgi?id=100188
2635
2636         Reviewed by Sam Weinig.
2637
2638         Disable kerning and ligatures by default when running the tests.
2639
2640         * DumpRenderTree/mac/DumpRenderTree.mm:
2641         (resetDefaultsToConsistentValues): Set a value of NO for the
2642         WebKitKerningAndLigaturesEnabledByDefault user default.
2643         * WebKitTestRunner/mac/main.mm:
2644         (main): Register a value of NO for the WebKitKerningAndLigaturesEnabledByDefault user
2645         default.
2646
2647 2012-10-23  Simon Fraser  <simon.fraser@apple.com>
2648
2649         Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText()
2650         https://bugs.webkit.org/show_bug.cgi?id=100159
2651
2652         Reviewed by Tim Horton.
2653
2654         Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
2655         whose path includes "tiled-drawing". It does this by passing around a WKDictionary 
2656         of options, and if the current PlatformWebView doesn't support those options, it will
2657         create a new one.
2658
2659         * WebKitTestRunner/PlatformWebView.h:
2660         (PlatformWebView): Add a WKDictionaryRef options dictionary argument.
2661         (WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
2662         supports the options in the WKDictionaryRef.
2663         * WebKitTestRunner/TestController.cpp:
2664         (WTR::TestController::initialize): Call createWebViewWithOptions() with
2665         no options in the normal case.
2666         (WTR::TestController::createWebViewWithOptions): Moved code into this fuction
2667         so we can call it in two places.
2668         (WTR::TestController::ensureViewSupportsOptions): If the current view
2669         doesn't support the given options, throw it away and makea  new one that does.
2670         * WebKitTestRunner/TestController.h:
2671         * WebKitTestRunner/TestInvocation.cpp:
2672         (WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
2673         (WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
2674         the view supports the given options. No-op for non-Mac platforms.
2675         (WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().
2676         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2677         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
2678         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2679         (WTR::PlatformWebView::PlatformWebView):  New constructor parameter.
2680         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2681         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
2682         (-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
2683         a custom value from this method.
2684         (WTR::PlatformWebView::PlatformWebView):
2685         (WTR::PlatformWebView::viewSupportsOptions):
2686         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2687         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
2688         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2689         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
2690
2691 2012-10-23  Sheriff Bot  <webkit.review.bot@gmail.com>
2692
2693         Unreviewed, rolling out r132276.
2694         http://trac.webkit.org/changeset/132276
2695         https://bugs.webkit.org/show_bug.cgi?id=100189
2696
2697         It broke the Qt-WK2 build intentionally (Requested by
2698         Ossy_night on #webkit).
2699
2700         * WebKitTestRunner/PlatformWebView.h:
2701         (PlatformWebView):
2702         * WebKitTestRunner/TestController.cpp:
2703         (WTR::TestController::initialize):
2704         * WebKitTestRunner/TestController.h:
2705         (TestController):
2706         * WebKitTestRunner/TestInvocation.cpp:
2707         (WTR):
2708         (WTR::TestInvocation::invoke):
2709         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2710         (WTR::PlatformWebView::PlatformWebView):
2711         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2712         (WTR::PlatformWebView::PlatformWebView):
2713         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2714         (WTR::PlatformWebView::PlatformWebView):
2715         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2716         (WTR::PlatformWebView::PlatformWebView):
2717         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2718         (WTR::PlatformWebView::PlatformWebView):
2719
2720 2012-10-23  Martin Robinson  <mrobinson@igalia.com>
2721
2722         [GTK][Soup] Implement the default authentication dialog via WebCoreSupport
2723         https://bugs.webkit.org/show_bug.cgi?id=99351
2724
2725         Reviewed by Carlos Garcia Campos.
2726
2727         We no longer need to turn off the soup authentication dialog soup feature,
2728         because it's not installed.
2729
2730         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2731         (setDefaultsToConsistentStateValuesForTesting): Don't turn off the feature any longer.
2732
2733 2012-10-23  Simon Fraser  <simon.fraser@apple.com>
2734
2735         Allow tests to run with a tile cache, and optionally dump the tile cache via layerTreeAsText()
2736         https://bugs.webkit.org/show_bug.cgi?id=100159
2737
2738         Reviewed by Tim Horton.
2739
2740         Make WebKitTestRunner use a WKView with a tile cache for tests run in a directory
2741         whose path includes "tiled-drawing". It does this by passing around a WKDictionary 
2742         of options, and if the current PlatformWebView doesn't support those options, it will
2743         create a new one.
2744
2745         * WebKitTestRunner/PlatformWebView.h:
2746         (PlatformWebView): Add a WKDictionaryRef options dictionary argument.
2747         (WTR::PlatformWebView::viewSupportsOptions): Returns true if the view
2748         supports the options in the WKDictionaryRef.
2749         * WebKitTestRunner/TestController.cpp:
2750         (WTR::TestController::initialize): Call createWebViewWithOptions() with
2751         no options in the normal case.
2752         (WTR::TestController::createWebViewWithOptions): Moved code into this fuction
2753         so we can call it in two places.
2754         (WTR::TestController::ensureViewSupportsOptions): If the current view
2755         doesn't support the given options, throw it away and makea  new one that does.
2756         * WebKitTestRunner/TestController.h:
2757         * WebKitTestRunner/TestInvocation.cpp:
2758         (WTR::shouldUseTiledDrawing): Return true if the directory contains "tiled-drawing".
2759         (WTR::updateTiledDrawingForCurrentTest): Tell the TestController to check whether
2760         the view supports the given options. No-op for non-Mac platforms.
2761         (WTR::TestInvocation::invoke): Call updateTiledDrawingForCurrentTest().
2762         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2763         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
2764         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2765         (WTR::PlatformWebView::PlatformWebView):  New constructor parameter.
2766         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2767         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:useTiledDrawing:]):
2768         (-[TestRunnerWKView _shouldUseTiledDrawingArea]): Subclass the WKView so we can return
2769         a custom value from this method.
2770         (WTR::PlatformWebView::PlatformWebView):
2771         (WTR::PlatformWebView::viewSupportsOptions):
2772         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2773         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
2774         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2775         (WTR::PlatformWebView::PlatformWebView): New constructor parameter.
2776
2777 2012-10-23  David Barton  <dbarton@mathscribe.com>
2778
2779         [MathML] Symbol font uses greek letters for roman ones on linux and Windows
2780         https://bugs.webkit.org/show_bug.cgi?id=99921
2781
2782         Reviewed by Eric Seidel.
2783
2784         Enable the STIXSizeOneSym font for testing.
2785
2786         * DumpRenderTree/mac/DumpRenderTree.mm:
2787         (allowedFontFamilySet):
2788         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2789         (WTR::allowedFontFamilySet):
2790
2791 2012-10-23  Tony Chang  <tony@chromium.org>
2792
2793         [chromium] Chromium window build system does not rebuild correctly when enabling/disabling a feature
2794         https://bugs.webkit.org/show_bug.cgi?id=38926
2795
2796         Reviewed by Eric Seidel.
2797
2798         Remove hack for clobbering build when features.gypi changes. Now that
2799         Chromium requires VS2010 or newer, this bug has gone away.
2800
2801         * Scripts/update-webkit:
2802
2803 2012-10-23  Jochen Eisinger  <jochen@chromium.org>
2804
2805         [chromium] remove the const qualifier from WebTestDelegate::printMessage
2806         https://bugs.webkit.org/show_bug.cgi?id=100082
2807
2808         Reviewed by Adam Barth.
2809
2810         There's no reason the method should be const, and indeed for
2811         content_shell we want to send an IPC which is a non-const operation.
2812
2813         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2814         (WebTestDelegate):
2815         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2816         (TestDelegate):
2817         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2818         (WebTestInterfaces::Internal):
2819         (WebTestRunner::WebTestInterfaces::Internal::printMessage):
2820         * DumpRenderTree/chromium/WebViewHost.cpp:
2821         (WebViewHost::printMessage):
2822         * DumpRenderTree/chromium/WebViewHost.h:
2823         (WebViewHost):
2824
2825 2012-10-23  Kenneth Rohde Christiansen  <kenneth@webkit.org>
2826
2827         Add support for resolution media query
2828         https://bugs.webkit.org/show_bug.cgi?id=99077
2829
2830         Reviewed by Antti Koivisto.
2831
2832         Add support for the RESOLUTION_MEDIA_QUERY feature flag.
2833
2834         * Scripts/webkitperl/FeatureList.pm:
2835         * qmake/mkspecs/features/features.pri:
2836
2837 2012-10-23  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
2838
2839         Adding myself to commiters.py
2840         https://bugs.webkit.org/show_bug.cgi?id=100122
2841
2842         Unreviewed update to commiters.py.
2843
2844         * Scripts/webkitpy/common/config/committers.py:
2845
2846 2012-10-23  Timothy Hatcher  <timothy@apple.com>
2847
2848         Unreviewed watchlist change to monitor Inspector IDLs.
2849
2850         * Scripts/webkitpy/common/config/watchlist:
2851
2852 2012-10-23  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2853
2854         [WK2] [WTR] WebKitTestRunner needs testRunner.queueForwardNavigation
2855         https://bugs.webkit.org/show_bug.cgi?id=99700
2856
2857         Reviewed by Kenneth Rohde Christiansen.
2858
2859         Implemented testRunner.queueForwardNavigation, made little refactoring in Work Queue
2860         to obviate code duplication.
2861
2862         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2863         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2864         (WTR::InjectedBundle::queueBackNavigation):
2865         (WTR):
2866         (WTR::InjectedBundle::queueForwardNavigation):
2867         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2868         (InjectedBundle):
2869         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2870         (WTR::TestRunner::queueForwardNavigation):
2871         (WTR):
2872         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2873         (TestRunner):
2874         * WebKitTestRunner/TestInvocation.cpp:
2875         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2876         * WebKitTestRunner/WorkQueueManager.cpp:
2877         (NavigationItem):
2878         (WTR::NavigationItem::NavigationItem):
2879         (WTR::NavigationItem::invoke):
2880         (WTR):
2881         (WTR::WorkQueueManager::queueBackNavigation):
2882         (WTR::WorkQueueManager::queueForwardNavigation):
2883         * WebKitTestRunner/WorkQueueManager.h:
2884         (WorkQueueManager):
2885
2886 2012-10-23  Simon Hausmann  <simon.hausmann@digia.com>
2887
2888         Unreviewed trivial Qt build fix: Fix build without USE_3D_GRAPHICS
2889
2890         Disable USE_GRAPHICS_SURFACE if we don't have USE_3D_GRAPHICS because
2891         GraphicsSurface.h needs GraphicsContext3D.
2892
2893         * qmake/mkspecs/features/features.prf:
2894
2895 2012-10-23  Simon Pena  <spena@igalia.com>
2896
2897         Unreviewed. Adding myself as committer.
2898
2899         * Scripts/webkitpy/common/config/committers.py:
2900
2901 2012-10-22  Jochen Eisinger  <jochen@chromium.org>
2902
2903         [chromium] Move the call to RegisterIsolatedFileSystem to the WebTestDelegate interface
2904         https://bugs.webkit.org/show_bug.cgi?id=100048
2905
2906         Reviewed by Adam Barth.
2907
2908         The call needs to be done outside of the sandbox.
2909
2910         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2911         (WebTestDelegate):
2912         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
2913         (WebTestRunner):
2914         (WebTestRunner::EventSender::beginDragWithFiles):
2915         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
2916         (TestDelegate):
2917         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2918         (WebTestInterfaces::Internal):
2919         (WebTestRunner::WebTestInterfaces::Internal::registerIsolatedFileSystem):
2920         (WebTestRunner):
2921         * DumpRenderTree/chromium/WebViewHost.cpp:
2922         (WebViewHost::registerIsolatedFileSystem):
2923         * DumpRenderTree/chromium/WebViewHost.h:
2924         (WebViewHost):
2925
2926 2012-10-22  Dirk Pranke  <dpranke@chromium.org>
2927
2928         webkitpy: remove unneeded debug messages from find_files()
2929         https://bugs.webkit.org/show_bug.cgi?id=100041
2930
2931         Reviewed by Adam Barth.
2932
2933         This routine gets called all the time when loading the virtual
2934         suites, and the debug messages were spamming me.
2935
2936         * Scripts/webkitpy/common/find_files.py:
2937         (_normalized_find):
2938
2939 2012-10-22  Tony Chang  <tony@chromium.org>
2940
2941         [chromium] Add Mac 10.7 Debug bot since it's on the waterfall
2942         https://bugs.webkit.org/show_bug.cgi?id=100028
2943
2944         Reviewed by Eric Seidel.
2945
2946         garden-o-matic can't baseline without this entry.
2947
2948         * Scripts/webkitpy/layout_tests/port/builders.py:
2949
2950 2012-10-22  Jochen Eisinger  <jochen@chromium.org>
2951
2952         [chromium] introduce WebTask to the TestRunner library
2953         https://bugs.webkit.org/show_bug.cgi?id=99964
2954
2955         Reviewed by Adam Barth.
2956
2957         I'm also removing the dependency on webkit_support, and instead go
2958         through the WebTestDelegate interface.
2959
2960         * DumpRenderTree/DumpRenderTree.gypi:
2961         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2962         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2963         (DRTDevToolsAgent::taskList):
2964         * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
2965         * DumpRenderTree/chromium/DRTDevToolsClient.h:
2966         (DRTDevToolsClient::taskList):
2967         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2968         (InvokeCallbackTask::InvokeCallbackTask):
2969         * DumpRenderTree/chromium/DRTTestRunner.h:
2970         (DRTTestRunner::taskList):
2971         (DRTTestRunner::WorkQueue::taskList):
2972         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2973         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2974         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
2975         (RTCStatsRequestSucceededTask::RTCStatsRequestSucceededTask):
2976         (RTCVoidRequestTask::RTCVoidRequestTask):
2977         (StringDataTask::StringDataTask):
2978         (CharPtrDataTask::CharPtrDataTask):
2979         (DataChannelReadyStateTask::DataChannelReadyStateTask):
2980         (RTCPeerConnectionReadyStateTask::RTCPeerConnectionReadyStateTask):
2981         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2982         (MockWebRTCPeerConnectionHandler):
2983         (MockWebRTCPeerConnectionHandler::taskList):
2984         * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
2985         (MockWebSpeechInputController::SpeechTask::SpeechTask):
2986         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
2987         (MockWebSpeechInputController::taskList):
2988         (MockWebSpeechInputController):
2989         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2990         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
2991         (MockWebSpeechRecognizer::taskList):
2992         (MockWebSpeechRecognizer):
2993         (MockWebSpeechRecognizer::StepTask::StepTask):
2994         * DumpRenderTree/chromium/Task.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/Task.cpp.
2995         (WebTestRunner):
2996         (WebTestRunner::invokeTask):
2997         (TaskWrapper):
2998         (WebTestRunner::TaskWrapper::TaskWrapper):
2999         (WebTestRunner::TaskWrapper::~TaskWrapper):
3000         (WebTestRunner::TaskWrapper::Run):
3001         (postTask):
3002         (postDelayedTask):
3003         * DumpRenderTree/chromium/Task.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestRunner.h.
3004         (WebTestRunner):
3005         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/Task.h.
3006         (WebTestRunner):
3007         (WebTask):
3008         (WebTaskList):
3009         (WebMethodTask):
3010         (WebTestRunner::WebMethodTask::WebMethodTask):
3011         (WebTestRunner::WebMethodTask::~WebMethodTask):
3012         (WebTestRunner::WebMethodTask::run):
3013         (WebTestRunner::WebMethodTask::cancel):
3014         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3015         (WebTestRunner):
3016         (WebTestDelegate):
3017         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3018         (WebTestRunner):
3019         (WebTestRunner::EventSender::scheduleAsynchronousClick):
3020         (WebTestRunner::KeyDownTask::KeyDownTask):
3021         (WebTestRunner::EventSender::scheduleAsynchronousKeyDown):
3022         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
3023         (WebTestRunner::EventSender::taskList):
3024         (EventSender):
3025         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
3026         (WebTestRunner):
3027         (TestDelegate):
3028         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3029         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/Task.cpp.
3030         (WebTestRunner):
3031         (WebTestRunner::WebTask::WebTask):
3032         (WebTestRunner::WebTask::~WebTask):
3033         (WebTestRunner::WebTaskList::WebTaskList):
3034         (WebTestRunner::WebTaskList::~WebTaskList):
3035         (WebTestRunner::WebTaskList::registerTask):
3036         (WebTestRunner::WebTaskList::unregisterTask):
3037         (WebTestRunner::WebTaskList::revokeAll):
3038         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3039         (WebTestInterfaces::Internal):
3040         (WebTestRunner::WebTestInterfaces::Internal::postTask):
3041         (WebTestRunner):
3042         (WebTestRunner::WebTestInterfaces::Internal::postDelayedTask):
3043         * DumpRenderTree/chromium/TestShell.cpp:
3044         (TestShell::initialize):
3045         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
3046         (UserMediaRequestTask::UserMediaRequestTask):
3047         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
3048         (WebUserMediaClientMock::taskList):
3049         (WebUserMediaClientMock):
3050         * DumpRenderTree/chromium/WebViewHost.cpp:
3051         (WebViewHost::postTask):
3052         (WebViewHost::postDelayedTask):
3053         * DumpRenderTree/chromium/WebViewHost.h:
3054         (WebViewHost):
3055         (WebViewHost::taskList):
3056         (WebViewHost::HostMethodTask::HostMethodTask):
3057
3058 2012-10-22  Ojan Vafai  <ojan@chromium.org>
3059
3060         Update flakiness dashboard to match the state of the builders.
3061         * TestResultServer/static-dashboards/builders.js:
3062         (isChromiumDepsGTestRunner):
3063         Broaden the filter since Chromium naming scheme is not consistent.
3064         (loadBuildersList):
3065         The main Chromium master now only runs builders, no tests.
3066         * TestResultServer/static-dashboards/dashboard_base.js:
3067         Remove test suites that no longer run on any of these masters.
3068
3069 2012-10-22  Jochen Eisinger  <jochen@chromium.org>
3070
3071         [chromium] add a method for printing message to the WebTestDelegate
3072         https://bugs.webkit.org/show_bug.cgi?id=99960
3073
3074         Reviewed by Adam Barth.
3075
3076         When using the TestRunner library from the content_shell, we can't print
3077         message directly but need to send them to the browser process.
3078
3079         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3080         (WebTestDelegate):
3081         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
3082         (WebTestRunner::AccessibilityController::fallbackCallback):
3083         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
3084         (WebTestRunner::AccessibilityController::setDelegate):
3085         (AccessibilityController):
3086         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3087         (WebTestRunner):
3088         (WebTestRunner::EventSender::dumpFilenameBeingDragged):
3089         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
3090         (GamepadController::connect):
3091         (GamepadController::disconnect):
3092         (GamepadController::setId):
3093         (GamepadController::setButtonCount):
3094         (GamepadController::setButtonData):
3095         (GamepadController::setAxisCount):
3096         (GamepadController::setAxisData):
3097         (GamepadController::fallbackCallback):
3098         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
3099         (TestDelegate):
3100         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3101         (TestInterfaces::~TestInterfaces):
3102         (TestInterfaces::setDelegate):
3103         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3104         (WebTestInterfaces::Internal):
3105         (WebTestRunner::WebTestInterfaces::Internal::printMessage):
3106         (WebTestRunner):
3107         * DumpRenderTree/chromium/WebViewHost.cpp:
3108         (WebViewHost::didBeginEditing):
3109         (WebViewHost::lastContextMenuData):
3110         (WebViewHost::clearContextMenuData):
3111         (WebViewHost::setEditCommand):
3112         (WebViewHost::clearEditCommand):
3113         (WebViewHost::fillSpellingSuggestionList):
3114         (WebViewHost::setGamepadData):
3115         (WebViewHost::printMessage):
3116         * DumpRenderTree/chromium/WebViewHost.h:
3117         (WebViewHost):
3118
3119 2012-10-22  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3120
3121         I now only watch Selectors instead of all of CSS.
3122
3123         Unreviewed update of watchlist.
3124
3125         * Scripts/webkitpy/common/config/watchlist:
3126
3127 2012-10-22  Yury Semikhatsky  <yurys@chromium.org>
3128
3129         Make sure base and derived class pointers are different in MemoryInstrumentationTest.instrumentedWithMultipleAncestors
3130         https://bugs.webkit.org/show_bug.cgi?id=99987
3131
3132         Reviewed by Alexander Pavlov.
3133
3134         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: changed first parent
3135         class in the list so that it has virtual table as well as the second one. This
3136         way we may be sure that pointer to the second ancestor class will differ from
3137         the pointer to the derived class.
3138
3139 2012-10-22  Yury Semikhatsky  <yurys@chromium.org>
3140
3141         Unreviewed. Fix compilation after r132059.
3142
3143         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3144
3145 2012-10-22  Dominik Röttsches  <dominik.rottsches@intel.com>
3146
3147         Adding Cairo and Harfbuzz watchlist entries
3148
3149         Unreviewed watchlist update.
3150
3151         Added myself to these new ones and SVG.
3152
3153         * Scripts/webkitpy/common/config/watchlist:
3154
3155 2012-10-22  Yury Semikhatsky  <yurys@chromium.org>
3156
3157         Web Inspector: do not double count memory of objects with multiple ancestors
3158         https://bugs.webkit.org/show_bug.cgi?id=99958
3159
3160         Reviewed by Alexander Pavlov.
3161
3162         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: Test that there
3163         is no double counting in case of multiple inheritance.
3164
3165 2012-10-22  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3166
3167         [Qt] Basic gesture event handling
3168         https://bugs.webkit.org/show_bug.cgi?id=66173
3169
3170         Reviewed by Simon Hausmann.
3171
3172         Add support for eventSender.gestureLongPress.
3173
3174         * DumpRenderTree/qt/EventSenderQt.cpp:
3175         (EventSender::EventSender):
3176         (EventSender::gestureLongPress):
3177         * DumpRenderTree/qt/EventSenderQt.h:
3178         (EventSender):
3179
3180 2012-10-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3181
3182         [WTR] Properly initialize TestRunner::m_dumpSelectionRect.
3183         https://bugs.webkit.org/show_bug.cgi?id=99970
3184
3185         Reviewed by Kenneth Rohde Christiansen.
3186
3187         Follow-up to r131476: actually initialize m_dumpSelectionRect to
3188         some value to avoid some flakyness in the tests.
3189
3190         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3191         (WTR::TestRunner::TestRunner):
3192
3193 2012-10-22  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
3194
3195         [Qt] Don't build any of the tools in production_build
3196
3197         Reviewed by Simon Hausmann.
3198
3199         * Tools.pro:
3200         * qmake/mkspecs/features/configure.prf:
3201
3202 2012-10-22  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
3203
3204         [Qt] Move OBJECTS_DIR and friends to default_pre.prf
3205
3206         The introduction of load(qt_build_config) in .qmake.conf meant
3207         that we started loading qtmodule.pri, which in turn set both
3208         MOC_DIR, RCC_DIR, and OBJECTS_DIR.
3209
3210         We were setting OBJECTS_DIR in default_post under a isEmpty() guard
3211         so that project files could override the objects dir. Instead of
3212         using the isEmpty() check we move it to defaul_pre, which will
3213         override the qtmodule.pri settings, but still allow project files
3214         to override it.
3215
3216         Reviewed by Ossy.
3217
3218         * qmake/mkspecs/features/default_post.prf:
3219         * qmake/mkspecs/features/default_pre.prf:
3220
3221 2012-10-22  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3222
3223         WebKitTestRunner needs testRunner.queueLoadingScript and testRunner.queueNonLoadingScript
3224         https://bugs.webkit.org/show_bug.cgi?id=42675
3225
3226         Reviewed by Kenneth Rohde Christiansen.
3227
3228         Added implementation of testRunner.queueLoadingScript and testRunner.queueNonLoadingScript.
3229
3230         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3231         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3232         (WTR::InjectedBundle::queueLoadingScript):
3233         (WTR):
3234         (WTR::InjectedBundle::queueNonLoadingScript):
3235         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3236         (InjectedBundle):
3237         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3238         (WTR::TestRunner::queueLoadingScript):
3239         (WTR):
3240         (WTR::TestRunner::queueNonLoadingScript):
3241         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3242         (TestRunner):
3243         * WebKitTestRunner/TestInvocation.cpp:
3244         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3245         * WebKitTestRunner/WorkQueueManager.cpp:
3246         (WTR):
3247         (WTR::runJavaScriptFunction):
3248         (ScriptItem):
3249         (WTR::ScriptItem::ScriptItem):
3250         (WTR::ScriptItem::invoke):
3251         (WTR::WorkQueueManager::queueBackNavigation):
3252         (WTR::WorkQueueManager::queueLoadingScript):
3253         (WTR::WorkQueueManager::queueNonLoadingScript):
3254         * WebKitTestRunner/WorkQueueManager.h:
3255         (WorkQueueManager):
3256
3257 2012-10-22  Zan Dobersek  <zandobersek@gmail.com>
3258
3259         Unreviewed, a follow-up to r132034 where I forgot to address
3260         Ojan's review comment about the race condition in handleLocationChange.
3261
3262         * TestResultServer/static-dashboards/dashboard_base.js:
3263         (handleLocationChange):
3264
3265 2012-10-22  Zan Dobersek  <zandobersek@gmail.com>
3266
3267         [TestResultServer] Move the resource loading into a dedicated class
3268         https://bugs.webkit.org/show_bug.cgi?id=99246
3269
3270         Reviewed by Ojan Vafai.
3271
3272         A new 'loader' namespace is created, containing the request method (previously located in dashboard_base.js)
3273         and the new Loader object, which handles the loading of all the necessary data the dashboard might require.
3274
3275         * TestResultServer/static-dashboards/aggregate_results.html: Include the loader.js source file.
3276         * TestResultServer/static-dashboards/builders.js:
3277         (requestBuilderList): Use the request method located in the loader namespace instead of the removed doXHR method.
3278         (onBuilderListLoad): Now parses the response text of the passed-in XHR. When all the builder lists are loaded the
3279         resource loader object is notified appropriately.
3280         (onErrorLoadingBuilderList): The partial function that calls this function also adds an XHR parameter.
3281         * TestResultServer/static-dashboards/dashboard_base.js: Much of the resource loading-related code is moved to loader.js.
3282         The Loader object is now used to load all the required resources.
3283         (parseParameters): Don't push the 'builder' parameter into the current state if the unit tests are being run.
3284         (resourceLoadingComplete): This method gets called when all the resources are loaded and the dashboard should
3285         proceed with generating the page.
3286         (handleLocationChange):
3287         * TestResultServer/static-dashboards/flakiness_dashboard.html: Include the loader.js source file.
3288         * TestResultServer/static-dashboards/flakiness_dashboard.js: The request method has been relocated to the loader namespace.
3289         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: The affected test cases are modified appropriately.
3290         (test):
3291         * TestResultServer/static-dashboards/loader.js: Added.
3292         (.): A new namespace is introduced, publicly exporting the request method that performs an XHR operation and a Loader object
3293         which oversees resource loading. The loading is done in steps, first loading the builders list, after that the results files
3294         the current dashboard needs, and lastly the TestExpectations files if they are required by the dashboard. When done the loader
3295         calls the resourceLoadingComplete method located in dashboard_base.js. This signals the dashboard all resources are available
3296         and it can proceed with generating the dashboard page.
3297         * TestResultServer/static-dashboards/loader_unittests.js: Added. Contains unit tests for the Loader object, covering the
3298         incremental loading and the loading of results files and TestExpectations files. The builders list loading is currently not
3299         tested as the unit tests page overrides related methods that possibly affect other tests' behavior.
3300         * TestResultServer/static-dashboards/run-unittests.html: Now includes the loader.js and loader_unittests.js source file.
3301         Refactors the code a bit due to changes in how onBuilderListLoad behaves.
3302         * TestResultServer/static-dashboards/timeline_explorer.html: Now includes the loader.js source file.
3303         * TestResultServer/static-dashboards/treemap.html: Ditto. Also refactors the code to take into account
3304         that all the test files are now loaded before generating the dashboard page.
3305
3306 2012-10-21  Jochen Eisinger  <jochen@chromium.org>
3307
3308         [chromium] introduce a public API for the TestRunner library
3309         https://bugs.webkit.org/show_bug.cgi?id=99904
3310
3311         Reviewed by Adam Barth.
3312
3313         The API decouples the public API from the underlying implementation, so
3314         embedders can depend on it. I'm also changing DRT to consume the
3315         TestRunner API through the public API, except for DRTTestRunner and all
3316         places that require Task.h. These two will be migrated in later changes.
3317
3318         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3319         * DumpRenderTree/DumpRenderTree.gypi:
3320         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3321         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3322         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3323         (MockSpellCheck::fillSuggestionList):
3324         * DumpRenderTree/chromium/MockSpellCheck.h:
3325         (MockSpellCheck):
3326         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3327         * DumpRenderTree/chromium/MockWebSpeechInputController.h:
3328         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
3329         * DumpRenderTree/chromium/TestRunner/public/WebAccessibilityController.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3330         (WebKit):
3331         (WebTestRunner):
3332         (WebAccessibilityController):
3333         * DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3334         (WebKit):
3335         (WebTestRunner):
3336         (WebEventSender):
3337         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3338         (WebKit):
3339         (WebTestRunner):
3340         (WebTestDelegate):
3341         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h.
3342         (WebKit):
3343         (WebTestRunner):
3344         (WebTestInterfaces):
3345         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
3346         (WebTestRunner):
3347         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
3348         (WebTestRunner):
3349         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3350         (WebTestRunner):
3351         (WebTestRunner::makeMenuItemStringsFor):
3352         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
3353         (WebTestRunner):
3354         * DumpRenderTree/chromium/TestRunner/src/TestDelegate.h:
3355         (TestDelegate):
3356         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3357         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3358         (TestInterfaces):
3359         * DumpRenderTree/chromium/TestRunner/src/WebAccessibilityController.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3360         (WebTestRunner):
3361         (WebTestRunner::WebAccessibilityController::WebAccessibilityController):
3362         (WebTestRunner::WebAccessibilityController::setFocusedElement):
3363         (WebTestRunner::WebAccessibilityController::notificationReceived):
3364         (WebTestRunner::WebAccessibilityController::shouldLogAccessibilityEvents):
3365         * DumpRenderTree/chromium/TestRunner/src/WebEventSender.cpp: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/TestDelegate.h.
3366         (WebTestRunner):
3367         (WebTestRunner::WebEventSender::WebEventSender):
3368         (WebTestRunner::WebEventSender::doDragDrop):
3369         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Added.
3370         (WebTestRunner):
3371         (WebTestInterfaces::Internal):
3372         (WebTestRunner::WebTestInterfaces::Internal::testInterfaces):
3373         (WebTestRunner::WebTestInterfaces::Internal::accessibilityController):
3374         (WebTestRunner::WebTestInterfaces::Internal::eventSender):
3375         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3376         (WebTestRunner::WebTestInterfaces::Internal::~Internal):
3377         (WebTestRunner::WebTestInterfaces::Internal::setDelegate):
3378         (WebTestRunner::WebTestInterfaces::Internal::clearContextMenuData):
3379         (WebTestRunner::WebTestInterfaces::Internal::clearEditCommand):
3380         (WebTestRunner::WebTestInterfaces::Internal::fillSpellingSuggestionList):
3381         (WebTestRunner::WebTestInterfaces::Internal::setEditCommand):
3382         (WebTestRunner::WebTestInterfaces::Internal::lastContextMenuData):
3383         (WebTestRunner::WebTestInterfaces::Internal::setGamepadData):
3384         (WebTestRunner::WebTestInterfaces::WebTestInterfaces):
3385         (WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
3386         (WebTestRunner::WebTestInterfaces::setWebView):
3387         (WebTestRunner::WebTestInterfaces::setDelegate):
3388         (WebTestRunner::WebTestInterfaces::bindTo):
3389         (WebTestRunner::WebTestInterfaces::resetAll):
3390         (WebTestRunner::WebTestInterfaces::accessibilityController):
3391         (WebTestRunner::WebTestInterfaces::eventSender):
3392         * DumpRenderTree/chromium/TestShell.cpp:
3393         (TestShell::initialize):
3394         * DumpRenderTree/chromium/TestShell.h:
3395         (TestShell::eventSender):
3396         (TestShell::accessibilityController):
3397         (TestShell):
3398         * DumpRenderTree/chromium/WebUserMediaClientMock.h:
3399         * DumpRenderTree/chromium/WebViewHost.cpp:
3400         (WebViewHost::finishLastTextCheck):
3401         (WebViewHost::fillSpellingSuggestionList):
3402         * DumpRenderTree/chromium/WebViewHost.h:
3403         (WebViewHost):
3404
3405 2012-10-21  Viatcheslav Ostapenko  <v.ostapenko@samsung.com>
3406
3407         Unreviewed. Updating my emails.
3408
3409         * Scripts/webkitpy/common/config/committers.py:
3410
3411 2012-10-20  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3412
3413         [EFL][DRT] Implement tracking and painting repaint rectangles.
3414         https://bugs.webkit.org/show_bug.cgi?id=99838
3415
3416         Reviewed by Gyuyoung Kim.
3417
3418         Implement displayWebView() and start tracking/painting the repaint
3419         rectangles for the repaint tests that rely on it.
3420
3421         * DumpRenderTree/efl/DumpRenderTree.cpp:
3422         (displayWebView):
3423         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3424         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3425         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3426         (createBitmapContextFromWebView):
3427
3428 2012-10-19  Dan Bernstein  <mitz@apple.com>
3429
3430         Add bundle API for hit-testing
3431         https://bugs.webkit.org/show_bug.cgi?id=99907
3432
3433         Reviewed by Sam Weinig.
3434
3435         Added an API test for WKBundleFrameCreateHitTest().
3436
3437         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added InjectedBundleFrameHitTest.cpp,
3438         InjectedBundleFrameHitTest_bundle.cpp, and link-with-title.html.
3439
3440         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp: Added.
3441         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Checks that the message contains the
3442         title of the link in link-with-title.html.
3443         (TestWebKitAPI::setInjectedBundleClient):
3444         (TestWebKitAPI::TEST):
3445         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp: Added.
3446         (TestWebKitAPI::InjectedBundleFrameHitTestTest::InjectedBundleFrameHitTestTest):
3447         (TestWebKitAPI::didFinishLoadForFrameCallback): Hit tests at (50, 50) and sends the link title
3448         from the result back to the UI process.
3449         (TestWebKitAPI::InjectedBundleFrameHitTestTest::didCreatePage):
3450         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
3451         * TestWebKitAPI/Tests/WebKit2/link-with-title.html: Added.
3452
3453 2012-10-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3454
3455         Unreviewed, rolling out r131944.
3456         http://trac.webkit.org/changeset/131944
3457         https://bugs.webkit.org/show_bug.cgi?id=99891
3458
3459         On second thoughts, not such a great idea (Requested by jamesr
3460         on #webkit).
3461
3462         * DumpRenderTree/chromium/TestShell.cpp:
3463         (TestShell::createNewWindow):
3464
3465 2012-10-19  Alexandre Elias  <aelias@chromium.org>
3466
3467         [chromium] API to pass impl thread via WebLayerTreeView
3468         https://bugs.webkit.org/show_bug.cgi?id=99863
3469
3470         Reviewed by James Robinson.
3471
3472         This adds an API to pass the compositor impl thread via WebView and
3473         WebLayerTreeView. This is currently a no-op change, but in the future
3474         this codepath will supercede WebCompositor. The goal is to avoid statics
3475         in compositor initialization.
3476
3477         * DumpRenderTree/chromium/TestShell.cpp:
3478         (TestShell::createNewWindow):
3479
3480 2012-10-19  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
3481
3482         [Cairo][WTR] Implement the painting of repaint rectangles.
3483         https://bugs.webkit.org/show_bug.cgi?id=99839
3484
3485         Reviewed by Martin Robinson.
3486
3487         Implement the required code to paint the gray overlay with
3488         transparent regions for the repaint rectangles, as other ports
3489         already do and as is already done in most WK1 ports.
3490
3491         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3492         (WTR::paintRepaintRectOverlay):
3493         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3494
3495 2012-09-08  Alpha Lam  <hclam@chromium.org>
3496
3497         [chromium] Implement deferred image decoding
3498         https://bugs.webkit.org/show_bug.cgi?id=94240
3499
3500         Reviewed by Stephen White.
3501
3502         Add --enable-deferred-image-decoding to DRT.
3503
3504         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3505         (main):
3506         * DumpRenderTree/chromium/TestShell.cpp:
3507         (TestShell::TestShell):
3508         (TestShell::resetWebSettings):
3509         * DumpRenderTree/chromium/TestShell.h:
3510         (TestShell::setDeferredImageDecodingEnabled):
3511         (TestShell):
3512         * DumpRenderTree/chromium/WebPreferences.cpp:
3513         (WebPreferences::reset):
3514         (WebPreferences::applyTo):
3515         * DumpRenderTree/chromium/WebPreferences.h:
3516         (WebPreferences):
3517         * Scripts/webkitpy/layout_tests/port/chromium.py:
3518         (ChromiumPort.virtual_test_suites):
3519
3520 2012-10-19  Dongwoo Joshua Im  <dw.im@samsung.com>
3521
3522         Rename ENABLE_CSS3_TEXT_DECORATION to ENABLE_CSS3_TEXT
3523         https://bugs.webkit.org/show_bug.cgi?id=99804
3524
3525         Reviewed by Julien Chaffraix.
3526
3527         CSS3 text related properties will be implemented under this flag,
3528         including text decoration, text-align-last, and text-justify.
3529
3530         * Scripts/webkitperl/FeatureList.pm:
3531         * qmake/mkspecs/features/features.pri:
3532
3533 2012-10-19  Balazs Kelemen  <kbalazs@webkit.org>
3534
3535         [Qt][WTR] renderToOffscreenBuffer should not be set if the real render loop is active
3536         https://bugs.webkit.org/show_bug.cgi?id=99831
3537
3538         Reviewed by Jocelyn Turcotte.
3539
3540         Do not set renderToOffscreenBuffer if we have called setRenderWithoutShowing.
3541         We do not need it in this case and these things are actually conflicting.
3542
3543         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3544         (WTR::WrapperWindow::handleStatusChanged):
3545         (WTR::PlatformWebView::PlatformWebView):
3546         (WTR::PlatformWebView::windowShapshotEnabled): Added a comment
3547         describing why this workaround is needed.
3548
3549 2012-10-19  Zan Dobersek  <zandobersek@gmail.com>
3550
3551         [WK2][GTK] Fullscreen tests timing out in bots
3552         https://bugs.webkit.org/show_bug.cgi?id=93973
3553
3554         Reviewed by Philippe Normand.
3555
3556         Add webcore_cppflags to the CPPFLAGS for WebKitTestRunner and the
3557         injected bundle library. webcore_cppflags contains all the feature
3558         defines' macros so the ENABE(*) compilation guards should now work
3559         properly (i.e. enable the code behind them when the feature is enabled).
3560
3561         * WebKitTestRunner/GNUmakefile.am:
3562
3563 2012-10-19  Simon Hausmann  <simon.hausmann@digia.com>
3564
3565         Unreviewed, rolling out r131734.
3566         http://trac.webkit.org/changeset/131734
3567
3568         Broke ANGLE build where we end up with @echo foo && @echo -n
3569
3570         * qmake/mkspecs/features/default_post.prf:
3571
3572 2012-10-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3573
3574         REGRESSION (r130640 - r130644): TestCookieManager API test is failing
3575         https://bugs.webkit.org/show_bug.cgi?id=98738
3576
3577         Reviewed by Philippe Normand.
3578
3579         * Scripts/run-gtk-tests:
3580         (TestRunner): Unskip /webkit2/WebKitCookieManager/accept-policy.
3581
3582 2012-10-19  Tommy Widenflycht  <tommyw@google.com>
3583
3584         MediaStream API: Update the RuntimeEnabledFeatures flags
3585         https://bugs.webkit.org/show_bug.cgi?id=99714
3586
3587         Reviewed by Adam Barth.
3588
3589         Enabling the DeprecatedPeerConnection so that all tests still run.
3590
3591         * DumpRenderTree/chromium/TestShell.cpp:
3592         (TestShell::TestShell):
3593
3594 2012-10-18  Dominic Mazzoni  <dmazzoni@google.com>
3595
3596         AX: labelForElement is slow when there are a lot of DOM elements
3597         https://bugs.webkit.org/show_bug.cgi?id=97825
3598
3599         Reviewed by Ryosuke Niwa.
3600
3601         Implement titleUIElement in the chromium port of DRT, and
3602         fix getAccessibleElementById so that it ensures the backing store
3603         is up-to-date.
3604
3605         * DumpRenderTree/chromium/TestRunner/AccessibilityControllerChromium.cpp:
3606         (AccessibilityController::getAccessibleElementById):
3607         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
3608         (AccessibilityUIElement::titleUIElementCallback):
3609
3610 2012-10-17  Ilya Tikhonovsky  <loislo@chromium.org>
3611
3612         Web Inspector: NMI provide data for mixing with tcmalloc heap dumps.
3613         https://bugs.webkit.org/show_bug.cgi?id=99457
3614
3615         Reviewed by Yury Semikhatsky.
3616
3617         countObjectSize now requires pointer to object as the first argument.
3618
3619         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3620
3621 2012-10-18  Dirk Pranke  <dpranke@chromium.org>
3622
3623         make move_overwritten_baselines_to work again while rebaselining
3624         https://bugs.webkit.org/show_bug.cgi?id=99793
3625
3626         Reviewed by Ojan Vafai.
3627
3628         We used&n