REGRESSION: run-perf-tests no longer reports the total test time
[WebKit-https.git] / Tools / ChangeLog
1 2012-09-19  Ryosuke Niwa  <rniwa@webkit.org>
2
3         REGRESSION: run-perf-tests no longer reports the total test time
4         https://bugs.webkit.org/show_bug.cgi?id=97138
5
6         Reviewed by Tony Chang.
7
8         Report the finished time as a info-level log as opposed to a debug level log.
9
10         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
11         (PerfTestsRunner._run_single_test):
12         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
13         (MainTest.normalizeFinishedTime): Added. It replaces all finished times by 0.1 seconds.
14         (test_run_test_pause_before_testing):
15         (test_run_test_set_for_parser_tests):
16         (test_run_memory_test):
17         (_test_run_with_json_output):
18
19 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
20
21         Support new TestExpectations format alongside old one
22         https://bugs.webkit.org/show_bug.cgi?id=96588
23
24         Reviewed by Ojan Vafai.
25
26         This patch adds support for actually reading in lines formatted
27         in the new style, and when we re-serialize/write out the file,
28         all lines will be written in the new style. Note that reading in
29         the old style is still supported, and no updates are being made
30         to the actual TestExpectations files as part of this change.
31
32         This change updates most but not all of the unit tests to use
33         the new syntax. I will update the rest when (or before where
34         possible) I drop support for the old format.
35
36         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
37         (TestExpectationParser):
38         (TestExpectationParser._tokenize_line):
39         (TestExpectationParser._tokenize_line_using_new_format):
40         (TestExpectationLine.to_string):
41         (TestExpectationLine._format_line):
42         (TestExpectations):
43         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
44         (test_parse_warning):
45         (SkippedTests.test_skipped_entry_dont_exist):
46         (NewExpectationSyntaxTests.test_warnings):
47         (RemoveConfigurationsTest.test_remove):
48         (test_remove_line):
49         (RebaseliningTest.test_remove):
50         (RebaseliningTest.test_no_get_rebaselining_failures):
51         (TestExpectationParserTests.test_tokenize_blank):
52         (TestExpectationParserTests.test_tokenize_extra_colon):
53         (TestExpectationParserTests.test_tokenize_missing_equal):
54         (TestExpectationParserTests.test_tokenize_extra_equal):
55         (TestExpectationSerializationTests.test_unparsed_to_string):
56         (TestExpectationSerializationTests.test_unparsed_list_to_string):
57         (TestExpectationSerializationTests.test_parsed_to_string):
58         (TestExpectationSerializationTests.test_format_line):
59         (TestExpectationSerializationTests.test_string_roundtrip):
60         (TestExpectationSerializationTests.test_list_roundtrip):
61         (TestExpectationSerializationTests.test_reconstitute_only_these):
62         (TestExpectationSerializationTests.test_string_whitespace_stripping):
63         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
64         (LintTest.test_lint_test_files__errors):
65         * Scripts/webkitpy/tool/commands/queries_unittest.py:
66         (PrintExpectationsTest.test_basic):
67         (PrintExpectationsTest.test_multiple):
68         (PrintExpectationsTest.test_full):
69         (PrintExpectationsTest.test_exclude):
70         * Scripts/webkitpy/tool/commands/rebaseline.py:
71         (RebaselineExpectations.execute):
72         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
73         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
74         (test_rebaseline_updates_expectations_file):
75         (test_rebaseline_does_not_include_overrides):
76         (test_rebaseline_expectations_noop):
77         (test_overrides_are_included_correctly):
78
79 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
80
81         implement first part of support for the new TestExpectations syntax
82         https://bugs.webkit.org/show_bug.cgi?id=96569
83
84         Reviewed by Ryosuke Niwa.
85
86         This patch implements support for parsing a line of the new
87         format for the TestExpectations file and converting it back into
88         the old format for compatibility. This routine is not yet used
89         by anything.
90
91         The new format is documented at:
92           http://trac.webkit.org/wiki/TestExpectations
93
94         but, in short:
95
96           [bugs] [ "[" modifiers "]" ] test_name [ "[" expectations "]" ]
97
98         - Comments are indicated with "#" instead of "//"
99         - If no expectations are specified we default to Skip for
100           compatibility with the Skipped files (these two changes make
101           Skipped files a subset of TestExpectations files)
102
103         - All of the tokens are now CamelCase instead of ALLCAPS.
104         - FAIL -> Failure
105         - IMAGE -> ImageOnlyFailure
106         - WONTFIX -> WontFix
107         - modifiers refer to just the platforms and configurations
108           (release/debug) that the line applies to.
109         - WontFix, Rebaseline, Slow, and Skip move to the right-hand side as
110           expectations
111         - expectations will typically be written out in lexicographic order
112         - We use webkit.org/b/12345, crbug.com/12345, and Bug(dpranke)
113           instead of BUGWK12345, BUGCR12345, and BUGDPRANKE.
114
115         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
116         (TestExpectationParser):
117         (TestExpectationParser._tokenize_line_using_new_format):
118         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
119         (NewExpectationSyntaxTests):
120         (NewExpectationSyntaxTests.assert_exp):
121         (NewExpectationSyntaxTests.test_bare_name):
122         (NewExpectationSyntaxTests.test_bare_name_and_bugs):
123         (NewExpectationSyntaxTests.test_comments):
124         (NewExpectationSyntaxTests.test_config_modifiers):
125         (NewExpectationSyntaxTests.test_unknown_config):
126         (NewExpectationSyntaxTests.test_unknown_expectation):
127         (NewExpectationSyntaxTests.test_skip):
128         (NewExpectationSyntaxTests.test_slow):
129         (NewExpectationSyntaxTests.test_wontfix):
130         (NewExpectationSyntaxTests.test_blank_line):
131         (NewExpectationSyntaxTests.test_warnings):
132
133 2012-09-19  Dirk Pranke  <dpranke@chromium.org>
134
135         nrwt: replace TEXT, AUDIO, and IMAGE+TEXT with FAIL
136         https://bugs.webkit.org/show_bug.cgi?id=96845
137
138         Reviewed by Ojan Vafai.
139
140         In preparation for the new TestExpectations syntax, we replace
141         all TEXT, IMAGE+TEXT, and AUDIO failures with FAIL. This will
142         make switching to the new syntax lossless (i.e., we lose
143         information now, not then).
144
145         Note that we can still parse in results.json files that have the
146         old data for backwards compatibility.
147         
148
149         * Scripts/webkitpy/common/net/resultsjsonparser.py:
150         (JSONTestResult._failure_types_from_actual_result):
151         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
152         (ResultsJSONParserTest):
153         (test_basic):
154         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
155         (ResultSummaryTest.test_summarized_results_wontfix):
156         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
157         (JSONLayoutResultsGenerator):
158         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
159         (TestExpectations):
160         (TestExpectations.remove_pixel_failures):
161         (TestExpectations.has_pixel_failures):
162         (TestExpectations.suffixes_for_expectations):
163         (TestExpectations.get_rebaselining_failures):
164         (TestExpectations.remove_configuration_from_test):
165         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
166         (assert_bad_expectations):
167         (BasicTests):
168         (BasicTests.test_basic):
169         (MiscTests):
170         (MiscTests.test_multiple_results):
171         (MiscTests.test_result_was_expected):
172         (MiscTests.test_remove_pixel_failures):
173         (MiscTests.test_suffixes_for_expectations):
174         (test_get_expectations_string):
175         (test_parse_warning):
176         (test_error_on_different_platform):
177         (test_error_on_different_build_type):
178         (test_overrides):
179         (test_overrides__directory):
180         (test_overrides__duplicate):
181         (test_pixel_tests_flag):
182         (test_more_specific_override_resets_skip):
183         (SkippedTests.test_skipped_file_overrides_expectations):
184         (SkippedTests.test_skipped_dir_overrides_expectations):
185         (SkippedTests.test_skipped_file_overrides_overrides):
186         (SkippedTests.test_skipped_dir_overrides_overrides):
187         (ExpectationSyntaxTests.test_missing_colon):
188         (ExpectationSyntaxTests.test_too_many_equals_signs):
189         (SemanticTests.test_bug_format):
190         (SemanticTests.test_bad_bugid):
191         (SemanticTests.test_missing_bugid):
192         (SemanticTests.test_rebaseline):
193         (test_missing_file):
194         (test_more_modifiers):
195         (test_order_in_file):
196         (test_macro_overrides):
197         (RemoveConfigurationsTest.test_remove):
198         (test_remove_line):
199         (RebaseliningTest.test_remove):
200         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
201         * Scripts/webkitpy/layout_tests/models/test_failures.py:
202         (determine_result_type):
203         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
204         (test_test_expectations):
205         * Scripts/webkitpy/layout_tests/port/test.py:
206         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
207         (MainTest.test_missing_and_unexpected_results):
208         (MainTest.test_retrying_and_flaky_tests):
209         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
210         (TestExpectationsTestCase.test_valid_expectations):
211         * Scripts/webkitpy/tool/commands/queries_unittest.py:
212         (PrintExpectationsTest.test_basic):
213         (PrintExpectationsTest.test_multiple):
214         (PrintExpectationsTest.test_full):
215         (PrintExpectationsTest.test_exclude):
216         (PrintExpectationsTest.test_csv):
217         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
218         (test_rebaseline_does_not_include_overrides):
219         (test_overrides_are_included_correctly):
220
221 2012-09-19  Dominic Mazzoni  <dmazzoni@google.com>
222
223         AX: A few control types are returning the wrong answer for isReadOnly
224         https://bugs.webkit.org/show_bug.cgi?id=96735
225
226         Reviewed by Chris Fleizach.
227
228         Exposing isReadOnly in an AccessibilityObject to DumpRenderTree.
229
230         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
231         (AccessibilityUIElement::AccessibilityUIElement):
232         (AccessibilityUIElement::isReadOnlyGetterCallback):
233         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
234         (AccessibilityUIElement):
235
236 2012-09-19  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
237
238         [WTR] Memory leaks in TestRunner::deliverWebIntent()
239         https://bugs.webkit.org/show_bug.cgi?id=97111
240
241         Reviewed by Kenneth Rohde Christiansen.
242
243         Fix memory leaks in deliverWebIntent() by adopting strings
244         created with WKStringCreateWithUTF8CString().
245
246         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
247         (WTR::TestRunner::deliverWebIntent):
248
249 2012-09-19  Simon Hausmann  <simon.hausmann@digia.com>
250
251         [Qt] Fix incremental builds with all-in-one-files and gccdepends
252
253         Reviewed by Tor Arne Vestbø.
254
255         Pass -MP to gcc when we use the gcc depends feature, to ensure that implicit rules
256         are not only created for header files but also for .cpp files. AllInOne.cpp files
257         include other .cpp files, and when those are removed we need those dummy rules to
258         avoid a "No rule to make Foo.cpp required by AllInOne.o" error.
259
260         * qmake/config.tests/gccdepends/empty.cpp:
261         (main):
262         * qmake/config.tests/gccdepends/gccdepends.pro:
263         * qmake/mkspecs/features/default_pre.prf:
264
265 2012-09-19  Rick Byers  <rbyers@chromium.org>
266
267         Do touch adjustment on GestureTapDown
268         https://bugs.webkit.org/show_bug.cgi?id=96677
269
270         Reviewed by Antonio Gomes.
271
272         Allow radius to be set for GestureTapDown events.
273         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
274         (EventSender::gestureEvent):
275
276 2012-09-19  Christophe Dumez  <christophe.dumez@intel.com>
277
278         [EFL] EFL's DRT does not support overriding 'WebKitCSSRegionsEnabled' preference
279         https://bugs.webkit.org/show_bug.cgi?id=97100
280
281         Reviewed by Gyuyoung Kim.
282
283         EFL's DRT now supports overriding the 'WebKitCSSRegionsEnabled'
284         preference, in order to match WebKitTestRunner functionality.
285
286         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
287         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
288         * DumpRenderTree/efl/TestRunnerEfl.cpp:
289         (TestRunner::overridePreference):
290
291 2012-09-18  Kangil Han  <kangil.han@samsung.com>
292
293         [WK2][WTR] CodeGeneratorTestRunner could keep original copyright.
294         https://bugs.webkit.org/show_bug.cgi?id=96181
295
296         Reviewed by Daniel Bates.
297
298         This patch enabled derived files, in DerivedSources/InjectedBundle, to keep original copyright.
299
300         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
301         (new):
302         (_parseLicenseBlock):
303         (_parseLicenseBlockFromFile):
304         (_defaultLicenseBlock):
305         (_licenseBlock):
306         (_generateHeaderFile):
307         (_generateImplementationFile):
308
309 2012-09-18  Byungwoo Lee  <bw80.lee@samsung.com>
310
311         Title string should be changed when document.title is set to ''.
312         https://bugs.webkit.org/show_bug.cgi?id=96793
313
314         Reviewed by Kenneth Rohde Christiansen.
315
316         Change dump format of dumpTitleChanges more understandable.
317         Uses single quotation marks for the title string.
318
319         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
320         (BlackBerry::WebKit::DumpRenderTree::didReceiveTitleForFrame):
321         * DumpRenderTree/chromium/WebViewHost.cpp:
322         (WebViewHost::didReceiveTitle):
323         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
324         (DumpRenderTreeChrome::onFrameTitleChanged):
325         * DumpRenderTree/gtk/DumpRenderTree.cpp:
326         (webViewTitleChanged):
327         * DumpRenderTree/mac/FrameLoadDelegate.mm:
328         (-[FrameLoadDelegate webView:didReceiveTitle:forFrame:]):
329         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
330         (WebCore::DumpRenderTree::titleChanged):
331         * DumpRenderTree/win/FrameLoadDelegate.cpp:
332         (FrameLoadDelegate::didReceiveTitle):
333         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
334         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
335         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
336         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
337
338 2012-09-18  Szilard Ledan  <szledan@inf.u-szeged.hu>
339
340         EWS shouldn't sleep if there are new patches in its queue
341         https://bugs.webkit.org/show_bug.cgi?id=83038
342
343         Reviewed by Eric Seidel.
344
345         EWS tries to process a security patch. Of course it can't, because the EWS isn't
346         the member of the security group. But the problem is that after it can't process
347         the attachment, it says that queue is empty (but it isn't!) and it sleeps 2 minutes
348         and push the security patch to the end of the queue.
349         Now it stays in the loop until it finds a patch or the queue gets empty.
350
351         * Scripts/webkitpy/tool/commands/queues.py:
352         (AbstractPatchQueue._next_patch):
353         * Scripts/webkitpy/tool/commands/queues_unittest.py:
354         (AbstractPatchQueueTest.test_next_patch):
355
356 2012-09-18  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
357
358         [WK2][WTR] InjectedBundle::booleanForKey() should handle literals effectively
359         https://bugs.webkit.org/show_bug.cgi?id=97014
360
361         Reviewed by Kenneth Rohde Christiansen.
362
363         According to http://trac.webkit.org/wiki/EfficientStrings WTF::StringBuilder::appendLiteral() shall
364         be used for literals rather than WTF::StringBuilder::append().
365
366         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
367         (WTR::InjectedBundle::booleanForKey):
368
369 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
370
371         Update my e-mail address.
372
373         * Scripts/webkitpy/common/config/committers.py:
374
375 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
376
377         Update my e-mail address.
378
379         Unreviewed.
380
381         * Scripts/webkitpy/common/config/committers.py:
382
383 2012-09-18  Andras Becsi  <andras.becsi@digia.com>
384
385         [Qt] qt_webkit.pri should not be listed in Tools.pro
386
387         Reviewed and rubber-stamped by Simon Hausmann and Tor Arne Vestbø.
388
389         Since r128751 the module pri file is auto-generated
390         but it was still listed in OTHER_FILES.
391
392         * Tools.pro: Remove unneeded line.
393
394 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
395
396         [Qt] Fix build with some versions of the gold linker
397
398         Reviewed by Tor Arne Vestbø.
399
400         Don't unconditionally pass --no-keep-memory to the linker, some versions might not support it.
401         Instead run a compile/link test first to see if it works.
402
403         * qmake/config.tests/gnuld/gnuld.pro: Added.
404         * qmake/config.tests/gnuld/main.cpp: Added.
405         (main):
406         * qmake/mkspecs/features/unix/default_post.prf:
407
408 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
409
410         [Qt] Remove forced use of gold.
411
412         Reviewed by Tor Arne Vestbø.
413
414         The choice of what linker to use with WebKit should be taken by Qt's build system and ideally the same for all
415         modules of Qt. Then in turn it is usually up to the administrator of the machine. Recent Debian based systems
416         often offer the automatic use of gold through a symlink and a dpkg-diversion when installing the gold package.
417
418         * qmake/mkspecs/features/unix/default_post.prf:
419
420 2012-09-18  Simon Hausmann  <simon.hausmann@digia.com>
421
422         [Qt] Prospective Qt/Windows cross-compiling fix
423
424         Reviewed by Tor Arne Vestbø.
425
426         The win32 scope is not set when cross-compiling from Linux to Windows.
427
428         * qmake/mkspecs/features/functions.prf:
429
430 2012-09-18  Seokju Kwon  <seokju.kwon@samsung.com>
431
432         [EFL] Remove background view on EWebLauncher and MiniBrowser
433         https://bugs.webkit.org/show_bug.cgi?id=96905
434
435         Reviewed by Gyuyoung Kim.
436
437         The size of webview was changed after adding url bar.
438         And the background view is not necessary anymore, since it was used for debugging back in the day.
439
440         * EWebLauncher/main.c:
441         (_ELauncher):
442         (on_ecore_evas_resize):
443         (browserCreate):
444         * MiniBrowser/efl/main.c:
445         (_MiniBrowser):
446         (on_ecore_evas_resize):
447         (browserCreate):
448
449 2012-09-18  Sergio Villar Senin  <svillar@igalia.com>
450
451         [GTK] run-webkit-tests unable to find TestExpectations for WK2
452         https://bugs.webkit.org/show_bug.cgi?id=96998
453
454         Reviewed by Philippe Normand.
455
456         We should look for TestExpectations files in all the locations where
457         we currently look for Skipped files. This will allow
458         run-webkit-tests to look for TestExpectations files in
459         platform/gtk-wk2 and platform/wk2 if the "-2" flag is used.
460
461         * Scripts/webkitpy/layout_tests/port/gtk.py:
462         (GtkPort.expectations_files):
463
464 2012-09-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
465
466         [Qt] Fix build without the QtQuick module
467
468         Reviewed by Simon Hausmann.
469
470         * qmake/mkspecs/features/features.prf:
471
472 2012-09-18  Stephanie Lewis  <slewis@apple.com>
473
474         Build fix after http://trac.webkit.org/projects/webkit/changeset/128852.
475
476         Unreviewed.
477
478         * DumpRenderTree/mac/DumpRenderTree.mm:
479         (poseAsClass):
480
481 2012-09-18  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
482
483         Unreviewed update of email addresses for Berlin QtWebKit office.
484
485         * Scripts/webkitpy/common/config/committers.py:
486
487 2012-09-17  Zan Dobersek  <zandobersek@gmail.com>
488
489         [GTK] fast/loader/display-image-unset-can-block-image-and-can-reload-in-place.html failing after r128645
490         https://bugs.webkit.org/show_bug.cgi?id=96899
491
492         Reviewed by Martin Robinson.
493
494         When overriding the 'WebKitDisplayImageKey' preference, use the
495         'auto-load-images' property of WebKitWebSettings as the property which
496         should be updated with the corresponding preference value.
497
498         * DumpRenderTree/gtk/DumpRenderTree.cpp:
499         (resetDefaultsToConsistentValues):
500         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
501         (TestRunner::overridePreference):
502
503 2012-09-17  Pratik Solanki  <psolanki@apple.com>
504
505         DumpRenderTree and WebKitTestRunner should compile with -Wundef on Mac
506         https://bugs.webkit.org/show_bug.cgi?id=96973
507
508         Reviewed by Dan Bernstein.
509
510         * DumpRenderTree/mac/Configurations/Base.xcconfig:
511         * WebKitTestRunner/Configurations/Base.xcconfig:
512         * WebKitTestRunner/PlatformWebView.h: Use #ifdef __OBJC__ and not #if.
513
514 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
515
516         nrwt: remove "unexpected EOF" warnings
517         https://bugs.webkit.org/show_bug.cgi?id=96970
518
519         Reviewed by Ojan Vafai.
520
521         After debugging this a bit, it looks like there aren't any cases
522         that I can reproduce where a read() of zero indicates something
523         actually wrong; either it is a prelude to a crash, or a false
524         negative. So, I'm removing these warnings and adding a comment.
525
526         * Scripts/webkitpy/layout_tests/port/server_process.py:
527         (ServerProcess._wait_for_data_and_update_buffers_using_select):
528
529 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
530
531         [chromium] ASAN bot is crashing at the end of the run
532         https://bugs.webkit.org/show_bug.cgi?id=96967
533
534         Reviewed by Abhishek Arya.
535
536         The ASAN bot is crashing attempting to decode some output into
537         UTF-8; there's no reason to do this, so let's not do this and
538         see if something else is going on as well.
539
540         * Scripts/webkitpy/layout_tests/port/chromium.py:
541         (ChromiumPort._get_crash_log):
542
543 2012-09-17  Dirk Pranke  <dpranke@chromium.org>
544
545         nrwt: --results-directory isn't getting printed properly
546         https://bugs.webkit.org/show_bug.cgi?id=96965
547
548         Reviewed by Ojan Vafai.
549
550         options.results_directory isn't actually initialized with the
551         default values until after we call print_config(), so this
552         changes things to print the value directly.
553
554         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
555         (run):
556         * Scripts/webkitpy/layout_tests/views/printing.py:
557         (Printer.print_config):
558         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
559         (Testprinter.test_print_config):
560
561 2012-09-17  Rob Buis  <rbuis@rim.com>
562
563         [BlackBerry] Enable VIDEO_TRACK
564         https://bugs.webkit.org/show_bug.cgi?id=96949
565
566         Reviewed by Antonio Gomes.
567
568         * Scripts/webkitperl/FeatureList.pm:
569
570 2012-09-17  Rick Byers  <rbyers@chromium.org>
571
572         Add handling of new GestureTapCancel in DRT
573
574         https://bugs.webkit.org/show_bug.cgi?id=96183
575
576         Reviewed by Antonio Gomes.
577
578         * DumpRenderTree/chromium/TestWebPlugin.cpp:
579         (TestWebPlugin::handleInputEvent):
580         * DumpRenderTree/chromium/EventSender.cpp:
581         (EventSender::gestureTapCancel):
582
583 2012-09-17  Philip Rogers  <pdr@google.com>
584
585         Teach style checker about preprocessor directive indentation rules
586         https://bugs.webkit.org/show_bug.cgi?id=96874
587
588         Reviewed by Adam Barth.
589
590         Preprocessor directives (#ifdef, #include, #define, etc.) should not be indented.
591         This is not explicit in our style guide but is generally followed in our code.
592         Searching for violations in our codebase shows these are rarely indented:
593             #include - indented in 6 files
594             #ifdef - indented in 0 files
595             #ifndef - indented in 1 file
596             #define - indented in 11 files
597             #if - indented in 7 files
598
599         * Scripts/webkitpy/style/checkers/cpp.py:
600         (check_directive_indentation):
601
602             This is the simple test where we look for spaces followed by a #.
603
604         (check_style):
605         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
606
607             A few tests needed to be modified because they had unintentionally indented
608             preprocessor directives.
609
610         (CppStyleTest.test_build_class.Foo):
611         (CppStyleTest.test_build_class):
612         (CppStyleTest.test_build_class.DERIVE_FROM_GOO):
613         (WebKitStyleTest.test_line_breaking):
614         (WebKitStyleTest.test_directive_indentation):
615
616 2012-09-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
617
618         [Qt] Auto-generate the module pri file for QtWebKit
619
620         Reviewed by Simon Hausmann.
621
622         * qmake/qt_webkit.pri: Removed.
623
624 2012-09-14  Dirk Pranke  <dpranke@chromium.org>
625
626         nrwt: --additional-platform-dir is broken on chromium ports
627         https://bugs.webkit.org/show_bug.cgi?id=96840
628
629         Reviewed by Ojan Vafai.
630
631         Looks like I broke this when cleaning things up as part of
632         adding ML support. Fixing and adding a test.
633
634         * Scripts/webkitpy/layout_tests/port/chromium.py:
635         (ChromiumPort.default_baseline_search_path):
636         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
637         (ChromiumAndroidPort.default_baseline_search_path):
638         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
639         (ChromiumLinuxPort.default_baseline_search_path):
640         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
641         (ChromiumMacPort.__init__):
642         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
643         (ChromiumWinPort.setup_environ_for_server):
644         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
645         (test_check_build):
646         (test_additional_platform_directory):
647
648 2012-09-13  Stephanie Lewis  <slewis@apple.com>
649
650         mac-future ignores previous platform TestExpectations.
651         https://bugs.webkit.org/show_bug.cgi?id=96718.
652
653         Reviewed by Dirk Pranke.
654
655         TestExpectations match an expectation's configuraton against a list of configurations that are 
656         valid for that port.  That list does not contain mac-future so none of the expectations can be
657         applied.
658
659         * Scripts/webkitpy/layout_tests/port/apple.py:
660         (ApplePort._generate_all_test_configurations):
661
662 2012-09-14  Adam Barth  <abarth@webkit.org>
663
664         Remove webkitPostMessage
665         https://bugs.webkit.org/show_bug.cgi?id=96577
666
667         Reviewed by Ojan Vafai.
668
669         Add ENABLE_LEGACY_VENDOR_PREFIXES flag.
670
671         * Scripts/webkitperl/FeatureList.pm:
672         * qmake/mkspecs/features/features.pri:
673
674 2012-09-14  Alexey Proskuryakov  <ap@apple.com>
675
676         [WK2] webarchive/loading/javascript-url-iframe-crash.html fails
677         https://bugs.webkit.org/show_bug.cgi?id=96817
678
679         Reviewed by Kenneth Rohde Christiansen.
680
681         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
682         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): This callback
683         got overlooked when adding logging elsewhere.
684
685 2012-09-14  Peter Beverloo  <peter@chromium.org>
686
687         [Chromium] Build fix for DumpRenderTree following r128628
688         https://bugs.webkit.org/show_bug.cgi?id=96808
689
690         Reviewed by Tony Chang.
691
692         When building DumpRenderTree from the Chromium project, a compile error
693         shows up because including the header ForwardIOStreamsAndroid.h cannot
694         be located. TestWebKitAPI does this correctly.
695
696         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
697
698 2012-09-14  Dana Jansens  <danakj@chromium.org>
699
700         Change cc-bugs@google.com watchlist to cc-bugs@chromium.org
701         https://bugs.webkit.org/show_bug.cgi?id=96805
702
703         Reviewed by Dirk Pranke.
704
705         * Scripts/webkitpy/common/config/committers.py:
706         * Scripts/webkitpy/common/config/watchlist:
707
708 2012-09-14  Peter Beverloo  <peter@chromium.org>
709
710         [Chromium] Support the --{in,out,err}-fifo arguments on TestWebKitAPI and webkit_unit_tests
711         https://bugs.webkit.org/show_bug.cgi?id=96687
712
713         Reviewed by Tony Chang.
714
715         Android's DumpRenderTree currently supports these arguments, implemented
716         as part of TestShellAndroid:
717         http://trac.webkit.org/browser/trunk/Tools/DumpRenderTree/chromium/TestShellAndroid.cpp?rev=128496
718
719         They're used by the layout test runner to get the STDOUT and STDERR while
720         a layout test run is in process, which is a safer alternative to parsing
721         all the logcat output manually. The implementation can be seen here:
722         http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py?rev=128496#L590
723
724         This patch generalizes parsing of and applying the effects of these arguments
725         so that they can be used for TestWebKitAPI and webkit_unit_tests as well.
726         After this patch, this will make it possible to pull out the output-reading
727         code from Android's layout test port and generalize it so it can be re-used
728         in the new test-runner for the other two test suites.
729
730         This has no effect when compiling and running these tests as part of Chromium
731         code, which has a much more advanced test-runner that does parse complete log
732         output, but also directly depends on code licensed under Apache 2.
733
734         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
735         * DumpRenderTree/chromium/TestShellAndroid.cpp:
736         (platformInit):
737         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
738
739 2012-09-14  Zoltan Horvath  <zoltan@webkit.org>
740
741         check-webkit-style should not warn in case of NONCOPYABLE and FAST_ALLOCATED macros
742         https://bugs.webkit.org/show_bug.cgi?id=96656
743
744         Reviewed by Adam Barth.
745
746         We should allow to use WTF_MAKE_NONCOPYABLE(ClassName) and WTF_MAKE_FAST_ALLOCATED
747         macros in 1 line.
748
749         * Scripts/webkitpy/style/checkers/cpp.py:
750         (check_style.definitions):
751         (check_style): Add rule.
752         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
753         (WebKitStyleTest.test_line_breaking): Add unittest.
754
755 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
756
757         WebKitTestRunner needs layoutTestController.dumpDatabaseCallbacks
758         https://bugs.webkit.org/show_bug.cgi?id=57570
759
760         Reviewed by Kenneth Rohde Christiansen.
761
762         Implement testRunner.dumpDatabaseCallbacks in WebKitTestRunner
763         and dump the information expected by the test cases.
764
765         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
766         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
767         (WTR::InjectedBundle::beginTesting): Explicitly set the default
768         database quota.
769         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
770         (WTR::securityOriginToStr): New convenience function to convert
771         a security origin to the string expected in test results.
772         (WTR):
773         (WTR::InjectedBundlePage::InjectedBundlePage):
774         (WTR::InjectedBundlePage::didExceedDatabaseQuota):
775         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota): Minor
776         refactoring to share code with didExceedDatabaseQuota.
777         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
778         (InjectedBundlePage):
779         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
780         (WTR::TestRunner::TestRunner):
781         * WebKitTestRunner/InjectedBundle/TestRunner.h:
782         (WTR::TestRunner::dumpDatabaseCallbacks):
783         (WTR::TestRunner::shouldDumpDatabaseCallbacks):
784         (TestRunner):
785
786 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
787
788         [Qt] Set force_static_libs_as_shared early enough to be caught by configure
789
790         Rubber-stamped by Simon Hausmann.
791
792         * qmake/mkspecs/features/default_post.prf:
793
794 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
795
796         [Qt] Remove old cruft from the qmake build system
797
798         Rubber-stamped by Simon Hausmann.
799
800         * DumpRenderTree/qt/DumpRenderTree.pro:
801         * qmake/mkspecs/features/default_post.prf:
802
803 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
804
805         [Qt] Enable force_static_libs_as_shared for development
806
807         Not enabled for buildbots or production-builds (part of Qt5)
808
809         Reviewed by Simon Hausmann.
810
811         * qmake/mkspecs/features/default_post.prf:
812
813 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
814
815         [Qt] Make force_static_libs_as_shared work on Mac OS
816
817         We had to move a few LIBS += around that were in the wrong place,
818         and not caught when everything was just linked into the final
819         QtWebKit library.
820
821         Reviewed by Simon Hausmann.
822
823         * qmake/mkspecs/features/default_post.prf:
824         * qmake/mkspecs/features/force_static_libs_as_shared.prf:
825
826 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
827
828         [Qt] Fix build of WTR on Windows
829
830         Reviewed by Tor Arne Vestbø.
831
832         WTR/qt/main.cpp includes TestController.h, which lives in just WTR/
833         With qmake's unix makefile generator as well as with the MingW generator,
834         the directory where the pro file lives (WTR/) is automatically added to
835         the include search path, but not so with MSVC. Instead of relying on qmake's
836         implicit feature here, add WTR/ explicitly to the include search path.
837
838         * WebKitTestRunner/Target.pri:
839
840 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
841
842         WebKitTestRunner needs layoutTestController.setStopProvisionalFrameLoads
843         https://bugs.webkit.org/show_bug.cgi?id=42691
844
845         Reviewed by Kenneth Rohde Christiansen.
846
847         Add implementation for testrunner.setStopProvisionalFrameLoads()
848         in WebKitTestRunner.
849
850         Original patch by Alexey Proskuryakov.
851
852         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
853         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
854         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
855         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
856         (WTR::TestRunner::TestRunner):
857         * WebKitTestRunner/InjectedBundle/TestRunner.h:
858         (TestRunner):
859         (WTR::TestRunner::setStopProvisionalFrameLoads):
860         (WTR::TestRunner::shouldStopProvisionalFrameLoads):
861
862 2012-09-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
863
864         [Qt] Fix handling of debug/release/debug_and_release/build_all
865
866         We now pick up the defaults from Qt, in default_pre (CONFIG already
867         contains the appropriate values for debug and release). We then let
868         the command line arguments to qmake, or the project files themselves,
869         override the configuration, and finally we sanitize the configuration
870         in default_post.
871
872         Reviewed by Simon Hausmann.
873
874         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
875         * Scripts/webkitdirs.pm:
876         (buildQMakeProjects):
877         * qmake/mkspecs/features/default_post.prf:
878         * qmake/mkspecs/features/default_pre.prf:
879         * qmake/mkspecs/features/mac/default_pre.prf:
880
881 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
882
883         WebKitTestRunner needs layoutTestController.setTabKeyCyclesThroughElements
884         https://bugs.webkit.org/show_bug.cgi?id=42687
885
886         Reviewed by Kenneth Rohde Christiansen.
887
888         Implement testRunner.setTabKeyCyclesThroughElements for
889         WebKitTestRunner.
890
891         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
892         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
893         (WTR::InjectedBundle::beginTesting):
894         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
895         (WTR::TestRunner::setTabKeyCyclesThroughElements):
896         (WTR):
897         * WebKitTestRunner/InjectedBundle/TestRunner.h:
898         (TestRunner):
899
900 2012-09-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
901
902         EventSendingController::keyDown does not support non-array modifier arguments
903         https://bugs.webkit.org/show_bug.cgi?id=96727
904
905         Reviewed by Kenneth Rohde Christiansen.
906
907         Add support for handling a string as modifier argument to
908         EventSendingController::keyDown.
909
910         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
911         (WTR::parseModifierArray):
912
913 2012-09-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
914
915         WebKitTestRunner needs layoutTestController.setCustomPolicyDelegate
916         https://bugs.webkit.org/show_bug.cgi?id=42546
917
918         Reviewed by Kenneth Rohde Christiansen.
919
920         Exported TestRunner::setCustomPolicyDelegate() method.
921         Allowed Policy Delegate dumping even if we're not in 'waitUntilDone' mode.
922
923         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
924         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
925         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
926
927 2012-09-14  Zan Dobersek  <zandobersek@gmail.com>
928
929         [GTK] Clear application cache between tests in DumpRenderTree
930         https://bugs.webkit.org/show_bug.cgi?id=96543
931
932         Reviewed by Philippe Normand.
933
934         Call the new DumpRenderTreeSupportGtk method to clear application cache
935         after each test in DumpRenderTree.
936
937         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
938         as well. It's now being set in XvfbDriver._start so that each driver is assigned
939         a cache directory that's constructed out of the driver's name and its worker
940         number. These directories are located in the layout tests results directory.
941         At least on the builders this ensures a driver-specific empty cache directory
942         with each test run.
943
944         * DumpRenderTree/gtk/DumpRenderTree.cpp:
945         (runTest):
946         * Scripts/webkitpy/layout_tests/port/gtk.py:
947         (GtkPort.setup_environ_for_server):
948         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
949         (XvfbDriver._start):
950
951 2012-09-14  Simon Hausmann  <simon.hausmann@nokia.com>
952
953         [Qt] Fix linking on Windows
954
955         Reviewed by Tor Arne Vestbø.
956
957         When compiling code _after_ QtWebKit.dll, we need to make sure that the QWEBKIT_EXPORT
958         macro turns into an import macro, which means QT_MAKEDLL should only be set _up until_
959         the QtWebKit.dll creation in the build process and be off afterwards. This is done in
960         win32/default_post.prf using a !contains(QT, webkit): DEFINES += QT_MAKEDLL.
961
962         r128450 sanitized the values of QT and PKGCONFIG to only contain the dependencies we
963         want for QtWebKit.dll, but unfortunately that code was applied to any binary built also
964         after the module. Therefore QT did never contain webkit anymore and we always passed
965         QT_MAKEDLL to DEFINES, resulting in QWEBKIT_EXPORT to _not_ turn into an import macro.
966
967         This patch introduces a creating_module configuration that is used to
968         scope the qt/pkgconfig sanitization.
969
970         * qmake/mkspecs/features/default_post.prf:
971
972 2012-09-14  Christophe Dumez  <christophe.dumez@intel.com>
973
974         [WK2][WKTR] TestRunner is not dumping some frame load callbacks information
975         https://bugs.webkit.org/show_bug.cgi?id=96740
976
977         Reviewed by Kenneth Rohde Christiansen.
978
979         Dump information expected by the test cases about the following
980         frame load callbacks:
981         "didDisplayInsecureContentForFrame"
982         "didRunInsecureContentForFrame"
983         "didDetectXSSForFrame"
984
985         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
986         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Print a URL
987         as expected by test results by calling pathSuitableForTestResult() instead
988         of printing raw URL.
989         (WTR::InjectedBundlePage::didDisplayInsecureContentForFrame):
990         (WTR::InjectedBundlePage::didRunInsecureContentForFrame):
991         (WTR::InjectedBundlePage::didDetectXSSForFrame):
992
993 2012-09-14  Peter Beverloo  <peter@chromium.org>
994
995         The runtime/unsigned category should be valid in the cpp style-checker.
996         https://bugs.webkit.org/show_bug.cgi?id=96748
997
998         Reviewed by Csaba Osztrogonác.
999
1000         This is causing the webkitpy tests to fail because it's not listed in the
1001         category array. Furthermore, change an "int" to "long" because it's
1002         throwing a double error in one of the earlier asserts.
1003
1004         * Scripts/webkitpy/style/checkers/cpp.py:
1005         (CppChecker):
1006         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1007         (WebKitStyleTest.test_names):
1008
1009 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1010
1011         Evas_Object* is a ref'ed structure, so tread it as such
1012         https://bugs.webkit.org/show_bug.cgi?id=96659
1013
1014         Reviewed by Adam Barth.
1015
1016         Replace OwnPtr<Evas_Object> with RefPtr.
1017
1018         * DumpRenderTree/efl/ImageDiff.cpp:
1019         (calculateDifference):
1020         (printImageDifferences):
1021         (readImageFromStdin):
1022         (main):
1023
1024 2012-09-14  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1025
1026         Unreviewed, rolling out r128507.
1027         http://trac.webkit.org/changeset/128507
1028         https://bugs.webkit.org/show_bug.cgi?id=96659
1029
1030         Revert. r128507 makes too many crashes in EFL layout test bots.
1031
1032         * DumpRenderTree/efl/ImageDiff.cpp:
1033         (calculateDifference):
1034         (printImageDifferences):
1035         (readImageFromStdin):
1036         (main):
1037
1038 2012-09-13  Kevin Funk  <kevin.funk@kdab.com>
1039
1040         Make compile with both OS(WINCE) and PLATFORM(QT) support
1041         https://bugs.webkit.org/show_bug.cgi?id=95536
1042
1043         Reviewed by Simon Hausmann.
1044
1045         Fix wince support in qmake files
1046
1047         * Tools.pro:
1048         * qmake/mkspecs/features/configure.prf:
1049         * qmake/mkspecs/features/default_post.prf:
1050         * qmake/mkspecs/features/features.prf:
1051         * qmake/mkspecs/features/functions.prf:
1052
1053 2012-09-13  KwangYong Choi  <ky0.choi@samsung.com>
1054
1055         [WK2] Add color picker API support for WebKit2
1056         https://bugs.webkit.org/show_bug.cgi?id=95058
1057
1058         Reviewed by Gyuyoung Kim.
1059
1060         Initialization code for color picker callbacks in UI client.
1061
1062         * MiniBrowser/mac/BrowserWindowController.m:
1063         (-[BrowserWindowController awakeFromNib]):
1064         * MiniBrowser/win/BrowserView.cpp:
1065         (BrowserView::create):
1066         * WebKitTestRunner/TestController.cpp:
1067         (WTR::TestController::createOtherPage):
1068         (WTR::TestController::initialize):
1069
1070 2012-09-13  Yuta Kitamura  <yutak@chromium.org>
1071
1072         Upgrade yutak to reviewer
1073         https://bugs.webkit.org/show_bug.cgi?id=96721
1074
1075         Reviewed by Kent Tamura.
1076
1077         * Scripts/webkitpy/common/config/committers.py:
1078
1079 2012-09-13  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1080
1081         Make the style checker report usage of "unsigned int"
1082         https://bugs.webkit.org/show_bug.cgi?id=96693
1083
1084         Reviewed by Dirk Pranke.
1085
1086         Add a rule to check for uses of unsigned int, as the updated coding style recomends.
1087
1088         * Scripts/webkitpy/style/checkers/cpp.py:
1089         (check_language):
1090
1091 2012-09-13  Philip Rogers  <pdr@google.com>
1092
1093         Add gender-neutral form of webkit-patch land-cowboy
1094         https://bugs.webkit.org/show_bug.cgi?id=96709
1095
1096         Reviewed by Adam Barth.
1097
1098         Add webkit-patch land-cowhand, the confident and courageous form of webkit-patch for everyone.
1099
1100         * Scripts/webkitpy/tool/commands/download.py:
1101         (LandCowhand):
1102
1103 2012-09-13  Seokju Kwon  <seokju.kwon@samsung.com>
1104
1105         [EFL] Remove some parameters in browserCreate()
1106         https://bugs.webkit.org/show_bug.cgi?id=96499
1107
1108         Reviewed by Kenneth Rohde Christiansen.
1109
1110         There are too many parameters in browserCreate(). Lots of it seems like settings from command line argument.
1111         And I have moved some parameters into User_Arguments.
1112
1113         * EWebLauncher/main.c:
1114         (_User_Arguments):
1115         (_ELauncher):
1116         (on_key_down):
1117         (browserCreate):
1118         (findThemePath):
1119         (parseUserArguments):
1120         (main):
1121
1122 2012-09-13  Mark Lam  <mark.lam@apple.com>
1123
1124         Unreviewed. Adding myself to the committers list.
1125
1126         * Scripts/webkitpy/common/config/committers.py:
1127
1128 2012-09-13  Ryosuke Niwa  <rniwa@webkit.org>
1129
1130         run-perf-tests output cryptic error when the config file is missing.
1131         https://bugs.webkit.org/show_bug.cgi?id=96453
1132
1133         Reviewed by Tony Chang.
1134
1135         Add a special error message when a configuration file is missing.
1136
1137         Also update the help message of --source-json-path to signify the fact it specifies
1138         the configuration file on performance tests bots.
1139
1140         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1141         (PerfTestsRunner._parse_args):
1142         (PerfTestsRunner._generate_and_show_results):
1143         (PerfTestsRunner._merge_slave_config_json):
1144         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1145         (_test_run_with_json_output): Make upload to fail by default and assert the result
1146         in the function so that we can return logs instead.
1147         (_test_run_with_json_output.mock_upload_json):
1148         (test_run_with_json_output):
1149         (test_run_with_description):
1150         (test_run_respects_no_results):
1151         (test_run_with_slave_config_json):
1152         (test_run_with_bad_slave_config_json):
1153         (test_run_with_multiple_repositories):
1154
1155 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1156
1157         Evas_Object* is a ref'ed structure, so tread it as such
1158         https://bugs.webkit.org/show_bug.cgi?id=96659
1159
1160         Reviewed by Adam Barth.
1161
1162         Replace OwnPtr<Evas_Object> with RefPtr.
1163
1164         * DumpRenderTree/efl/ImageDiff.cpp:
1165         (calculateDifference):
1166         (printImageDifferences):
1167         (readImageFromStdin):
1168         (main):
1169
1170 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1171
1172         One more unreviewed trivial fix after r128399.
1173
1174         * BuildSlaveSupport/build.webkit.org-config/config.json: Fix URLs of the SVN mirror server.
1175
1176 2012-09-13  Csaba Osztrogonác  <ossy@webkit.org>
1177
1178         Unreviewed trivial fix after r128399.
1179
1180         * BuildSlaveSupport/wait-for-SVN-server.py: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py.
1181         (getLatestSVNRevision):
1182         (waitForSVNRevision):
1183
1184 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1185
1186         [WK2][WTR] WebKitTestRunner needs testRunner.callShouldCloseOnWebView
1187         https://bugs.webkit.org/show_bug.cgi?id=96366
1188
1189         Reviewed by Anders Carlsson.
1190
1191         Implement testRunner.callShouldCloseOnWebView for WebKitTestRunner
1192         by calling shouldClose() on the FrameLoader.
1193
1194         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1195         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1196         (WTR::TestRunner::callShouldCloseOnWebView):
1197         (WTR):
1198         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1199         (TestRunner):
1200
1201 2012-09-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1202
1203         Unreviewed, rolling out r128453.
1204         http://trac.webkit.org/changeset/128453
1205         https://bugs.webkit.org/show_bug.cgi?id=96681
1206
1207         Having tests use the same appcache directory leads to timeouts
1208         (Requested by zdobersek on #webkit).
1209
1210         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1211         (runTest):
1212         * Scripts/webkitpy/layout_tests/port/gtk.py:
1213         (GtkPort.setup_environ_for_server):
1214
1215 2012-09-13  James Robinson  <jamesr@chromium.org>
1216
1217         [chromium] Temporarily remove Android Builder (dbg) from garden-o-matic view
1218         https://bugs.webkit.org/show_bug.cgi?id=96678
1219
1220         Reviewed by Dirk Pranke.
1221
1222         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1223         (.):
1224
1225 2012-09-13  Rob Buis  <rbuis@rim.com>
1226
1227         Unreviewed changes to watchlist.
1228
1229         - Add myself to BlackBerry bugs
1230
1231         * Scripts/webkitpy/common/config/watchlist:
1232
1233 2012-09-13  Stephen Chenney  <schenney@chromium.org>
1234
1235         Add an SVG entry to the watchlist
1236
1237         Unreviewed config change.
1238
1239         * Scripts/webkitpy/common/config/watchlist:
1240         - Created a new SVG watchlist label covering WebCore/svg and WebCore/rendering/svg
1241         - Added myself and pdr as watchers
1242
1243 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1244
1245         [Qt] Make WebKit2 work on Windows with Qt 5
1246         https://bugs.webkit.org/show_bug.cgi?id=76776
1247
1248         Reviewed by Tor Arne Vestbø.
1249
1250         WebKit2 should compile with Qt on Windows now, so enable it. This patch in fact corrects
1251         the check to disable WebKit when we don't have USE_3D_GRAPHICS available, because we need
1252         that for the GL TextureMapper (it's only built when that feature is set).
1253
1254         * qmake/mkspecs/features/configure.prf:
1255
1256 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1257
1258         [Qt] Ensure that QT is finalized before loading qt_module.prf
1259
1260         As qt_module.prf does dependency tracking based on the content of the
1261         QT variable. The intermediate WebKit modules modify the variable in
1262         their .pri files, so we have to ensure we've loaded all the modules
1263         before loading qt_module.
1264
1265         Reviewed by Tor Arne Vestbø.
1266         Patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com> on 2012-09-13
1267
1268         * qmake/mkspecs/features/default_post.prf:
1269         * qmake/mkspecs/features/webkit_modules.prf: Added.
1270
1271 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1272
1273         [Qt] Fix build of Qt WTR/MiniBrowser with MSVC and nmake
1274         https://bugs.webkit.org/show_bug.cgi?id=96633
1275
1276         Reviewed by Csaba Osztrogonác.
1277
1278         WTR and MiniBrowser both have DRT in their include path (for the shared font stuff). Batch
1279         builds with MSVC and nmake result in nmake picking up main.cpp from the wrong directory.
1280         It's the usual problem and the usual solution is to rename one of the conflicting files.
1281         This patch chooses to rename DRT instead of WTR and MBR.
1282
1283         Fixed include order at the same time to match style guide.
1284
1285         * DumpRenderTree/qt/DumpRenderTree.pro:
1286         * DumpRenderTree/qt/DumpRenderTreeMain.cpp: Renamed from Tools/DumpRenderTree/qt/main.cpp.
1287         (messageHandler):
1288         (isOption):
1289         (takeOptionValue):
1290         (printUsage):
1291         (main):
1292
1293 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1294
1295         The Script run-launcher should support -2 in combination with --efl
1296         https://bugs.webkit.org/show_bug.cgi?id=96639
1297
1298         Reviewed by Simon Hausmann.
1299
1300         Support running the MiniBrowser then supplied -2 as argument.
1301
1302         * Scripts/run-launcher:
1303
1304 2012-09-13  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1305
1306         Unreviewed, add my Intel email address to the list.
1307
1308         * Scripts/webkitpy/common/config/committers.py:
1309
1310 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1311
1312         [Qt] Don't overwrite LIBS_PRIVATE when sanitizing LIBS
1313
1314         Reviewed by Ossy.
1315
1316         * qmake/mkspecs/features/default_post.prf:
1317
1318 2012-09-13  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1319
1320         [EFL][DRT] Implement LayoutTestController::layerTreeAsText
1321         https://bugs.webkit.org/show_bug.cgi?id=82294
1322
1323         Reviewed by Gyuyoung Kim.
1324
1325         Implement layerTreeAsText using the DumpRenderTreeSupportEfl method.
1326
1327         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1328         (TestRunner::layerTreeAsText):
1329
1330 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1331
1332         [GTK] Clear application cache between tests in DumpRenderTree
1333         https://bugs.webkit.org/show_bug.cgi?id=96543
1334
1335         Reviewed by Philippe Normand.
1336
1337         Call the new DumpRenderTreeSupportGtk method to clear application cache
1338         after each test.
1339
1340         Set the XDG_CACHE_HOME environment variable when running DumpRenderTree
1341         as well. Currently it points to a subdirectory in the layout tests results
1342         directory. At least on the builders this ensures an empty cache directory
1343         with each test run.
1344
1345         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1346         (runTest):
1347         * Scripts/webkitpy/layout_tests/port/gtk.py:
1348         (GtkPort.setup_environ_for_server):
1349
1350 2012-09-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1351
1352         [Qt] Make sure LIBS, PKGCONFIG, and QT, do not affect QtWebKit's prl file
1353
1354         Unless it's actually a dependency of the public QtWebKit API.
1355
1356         We could replace every occurance of LIBS, PKGCONFIG, and QT, in the pri
1357         files with their _PRIVATE equivivalent, but that's likely to break when
1358         someone adds a new QT/LIBS/PKGCONFIG += foo line somewhere. Instead we
1359         clean up the variables in default_post.
1360
1361         This means that the CONFIG -= explicitlib in linkAgainstLibrary() is no
1362         longer needed, as it was a workaround for the intermediate libraries ending
1363         up in the prl file. And, since CONFIG -= staticlib was there to support
1364         the explicitlib option, we can remove that too (as well as the exception
1365         for gprof, since it would be empty). If gprof needs tweaks to always link
1366         statically they should go in gprof.prf.
1367
1368         Reviewed by Simon Hausmann.
1369
1370         * qmake/mkspecs/features/default_post.prf:
1371         * qmake/mkspecs/features/functions.prf:
1372
1373 2012-09-13  Mario Sanchez Prada  <msanchez@igalia.com>
1374
1375         [GTK] "Infinite" loop in AccessibilityUIElementGtk.cpp
1376         https://bugs.webkit.org/show_bug.cgi?id=96632
1377
1378         Reviewed by Carlos Garcia Campos.
1379
1380         Fix this by using atk_object_get_n_accessible_children instead of
1381         calling getChildren() from childCount.
1382
1383         * WebKitTestRunner/InjectedBundle/gtk/AccessibilityUIElementGtk.cpp:
1384         (WTR::AccessibilityUIElement::childrenCount): Avoid the infinite
1385         loop by using atk_object_get_n_accessible_children().
1386
1387 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1388
1389         [Qt][Win] Enable USE(3D_GRAPHICS)
1390         https://bugs.webkit.org/show_bug.cgi?id=90879
1391
1392         Reviewed by Kenneth Rohde Christiansen.
1393
1394         Enable it on Windows as well as on QNX (bug fixed).
1395
1396         * qmake/mkspecs/features/features.prf:
1397
1398 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1399
1400         [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old
1401         https://bugs.webkit.org/show_bug.cgi?id=96359
1402
1403         Reviewed by Tor Arne Vestbø.
1404
1405         GnuWin32's flex is 2.5.4 and that is too old for ANGLE's preprocessor
1406         lexer. The only viable alternative I could find on Windows that provides
1407         binaries is the winflexbison distribution (http://sourceforge.net/projects/winflexbison/),
1408         so let's use that one instead.
1409
1410         * Scripts/webkitdirs.pm:
1411         (checkRequiredSystemConfig):
1412         * qmake/mkspecs/features/default_pre.prf:
1413
1414 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1415
1416         [Qt] Add configuration for production builds
1417         https://bugs.webkit.org/show_bug.cgi?id=96607
1418
1419         Reviewed by Kenneth Rohde Christiansen.
1420
1421         Add configuration tweaks for production builds, to ease memory pressure with the GNU toolchain
1422         and enable all-in-one-files optimizations.
1423
1424         * qmake/mkspecs/features/production_build.prf: Added.
1425
1426 2012-09-13  Simon Hausmann  <simon.hausmann@nokia.com>
1427
1428         [Qt] GStreamer detection does not work when cross-compiling
1429         https://bugs.webkit.org/show_bug.cgi?id=96608
1430
1431         Reviewed by Kenneth Rohde Christiansen.
1432
1433         When cross-compiling it is not safe to just use system(pkg-config),
1434         because there is a high probability that it will find packages in the
1435         host system instead of in the target one. Instead use qmake's new
1436         packagesExist() function that takes care of this delicate aspect of
1437         cross compilation by setting PKG_CONFIG_SYSROOT_DIR and
1438         PKG_CONFIG_LIBDIR accordingly.
1439
1440         * qmake/mkspecs/features/features.prf:
1441
1442 2012-09-13  Christophe Dumez  <christophe.dumez@intel.com>
1443
1444         [WK2][WTR] More efficient string handling in InjectedBundlePage
1445         https://bugs.webkit.org/show_bug.cgi?id=96609
1446
1447         Reviewed by Kenneth Rohde Christiansen.
1448
1449         Update StringBuilder usage in InjectedBundlePage to follow
1450         the latest recommandations for efficient string handling:
1451         http://trac.webkit.org/wiki/EfficientStrings
1452
1453         This involves using appendLiteral() or appendNumber()
1454         instead of append() whenever possible.
1455
1456         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1457         (WTR::dumpPath):
1458         (WTR::rangeToStr):
1459         (WTR::styleDecToStr):
1460         (WTR::frameToStr):
1461         (WTR::dumpResourceURL):
1462         (WTR):
1463         (WTR::dumpFrameDescriptionSuitableForTestResult):
1464         (WTR::dumpRequestDescriptionSuitableForTestResult):
1465         (WTR::dumpResponseDescriptionSuitableForTestResult):
1466         (WTR::dumpErrorDescriptionSuitableForTestResult):
1467         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1468         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1469         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1470         (WTR::InjectedBundlePage::didReceiveServerRedirectForProvisionalLoadForFrame):
1471         (WTR::InjectedBundlePage::didCommitLoadForFrame):
1472         (WTR::InjectedBundlePage::didFinishProgress):
1473         (WTR::dumpFrameScrollPosition):
1474         (WTR::dumpFrameText):
1475         (WTR::dumpDescendantFramesText):
1476         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1477         (WTR::InjectedBundlePage::didReceiveTitleForFrame):
1478         (WTR::InjectedBundlePage::didCancelClientRedirectForFrame):
1479         (WTR::InjectedBundlePage::willPerformClientRedirectForFrame):
1480         (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
1481         (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame):
1482         (WTR::InjectedBundlePage::willSendRequestForFrame):
1483         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1484         (WTR::InjectedBundlePage::didFinishLoadForResource):
1485         (WTR::InjectedBundlePage::didFailLoadForResource):
1486         (WTR::InjectedBundlePage::shouldCacheResponse):
1487         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1488         (WTR::InjectedBundlePage::willAddMessageToConsole):
1489         (WTR::InjectedBundlePage::willSetStatusbarText):
1490         (WTR::InjectedBundlePage::willRunJavaScriptAlert):
1491         (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
1492         (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
1493         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1494         (WTR::InjectedBundlePage::shouldBeginEditing):
1495         (WTR::InjectedBundlePage::shouldEndEditing):
1496         (WTR::InjectedBundlePage::shouldInsertNode):
1497         (WTR::InjectedBundlePage::shouldInsertText):
1498         (WTR::InjectedBundlePage::shouldDeleteRange):
1499         (WTR::InjectedBundlePage::shouldChangeSelectedRange):
1500         (WTR::InjectedBundlePage::shouldApplyStyle):
1501         (WTR::InjectedBundlePage::didBeginEditing):
1502         (WTR::InjectedBundlePage::didEndEditing):
1503         (WTR::InjectedBundlePage::didChange):
1504         (WTR::InjectedBundlePage::didChangeSelection):
1505         (WTR::InjectedBundlePage::supportsFullScreen):
1506         (WTR::InjectedBundlePage::enterFullScreenForElement):
1507         (WTR::InjectedBundlePage::exitFullScreenForElement):
1508         (WTR::InjectedBundlePage::beganEnterFullScreen):
1509         (WTR::InjectedBundlePage::beganExitFullScreen):
1510         (WTR::InjectedBundlePage::closeFullScreen):
1511         (WTR::dumpBackForwardListItem):
1512         (WTR::InjectedBundlePage::dumpBackForwardList):
1513
1514 2012-09-13  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1515
1516         [Qt][WK2] Memory leaks in Qt's TestRunner
1517         https://bugs.webkit.org/show_bug.cgi?id=96603
1518
1519         Reviewed by Csaba Osztrogonác.
1520
1521         Fix memory leaks in Qt's TestRunner code by adopting WKString
1522         created with WKStringCreateWithUTF8CString().
1523
1524         * WebKitTestRunner/qt/TestControllerQt.cpp:
1525         (WTR::TestController::initializeInjectedBundlePath):
1526         (WTR::TestController::initializeTestPluginDirectory):
1527
1528 2012-09-13  Zan Dobersek  <zandobersek@gmail.com>
1529
1530         [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration)
1531         https://bugs.webkit.org/show_bug.cgi?id=96506
1532
1533         Reviewed by Dirk Pranke.
1534
1535         Lower the timeout value to 6 seconds for release configuration and 12 seconds
1536         for debug configuration. These are the same values the Chromium port uses.
1537
1538         Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
1539         the layout tests under WebKit2 generally) requires more attention and gardening
1540         than what the current effort produces.
1541
1542         The unit test is updated as well to test these changes.
1543
1544         * Scripts/webkitpy/layout_tests/port/gtk.py:
1545         (GtkPort.default_timeout_ms):
1546         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1547         (GtkPortTest.test_default_timeout_ms):
1548         (GtkPortTest.assertLinesEqual):
1549
1550 2012-09-12  Csaba Osztrogonác  <ossy@webkit.org>
1551
1552         Add SVN mirror handling feature to build.webkit.org
1553         https://bugs.webkit.org/show_bug.cgi?id=85887
1554
1555         Reviewed by Dirk Pranke.
1556
1557         * BuildSlaveSupport/build.webkit.org-config/config.json: Add SVN mirrors for Qt buildslaves hosted in Szeged.
1558         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1559         (ConfigureBuild.__init__): Add SVNMirror property to be able to watch which slaves use which mirror on build.webkit.org.
1560         (ConfigureBuild.start):
1561         (CheckOutSource.__init__): Set baseURL to the SVNMirror or the default http://svn.webkit.org/repository/webkit/
1562         (WaitForSVNServer): Add new buildstep for waiting the SVNMirror to be in sync with http://svn.webkit.org/repository/webkit/
1563         (Factory.__init__):
1564         (BuildFactory.__init__):
1565         (TestFactory.__init__):
1566         (BuildAndTestFactory.__init__):
1567         (BuildAndPerfTestFactory.__init__):
1568         (BuildAndPerfTestWebKit2Factory.__init__):
1569         (DownloadAndPerfTestFactory.__init__):
1570         (DownloadAndPerfTestWebKit2Factory.__init__):
1571         (loadBuilderConfig): Use kwargs instead of args to be able to add the optional SVNMirror factory argument.
1572         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1573         (SVNMirrorTest):
1574         (SVNMirrorTest.setUp): Load config.json once at startup.
1575         (SVNMirrorTest.get_SVNMirrorFromConfig): Get the SVNMirror from config.json for a given buildslave.
1576         (SVNMirrorTest.test_CheckOutSource): Compare CheckOutSource.baseURL with SVNMirror in config.json for all builders
1577         * BuildSlaveSupport/build.webkit.org-config/wait-for-SVN-server.py: Added.
1578         (getLatestSVNRevision): Get the latest SVN revison from the given server.
1579         (waitForSVNRevision): Wait until the given SVN revision is committed to the given server. It doesn't wait if the
1580                               SVN revision is empty (force build triggered without revision) or the server is unavailable.
1581
1582 2012-09-12  Kangil Han  <kangil.han@samsung.com>
1583
1584         [WK2][WTR] Set waitUntilDone watchdog timer value equal to WK1.
1585         https://bugs.webkit.org/show_bug.cgi?id=81606
1586
1587         Reviewed by Tim Horton.
1588
1589         6 seconds is harsh for some jquery test cases.
1590         Therefore, adjust the value to match DumpRenderTree.
1591
1592         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1593         (WTR):
1594
1595 2012-09-12  KyungTae Kim  <ktf.kim@samsung.com>
1596
1597         [EFL] Support download attribute feature
1598         https://bugs.webkit.org/show_bug.cgi?id=96462
1599
1600         Reviewed by Gyuyoung Kim.
1601
1602         Enable DOWNLOAD_ATTRIBUTE feature for EFL port,
1603         and add "download,request" callback to the DumpRenderTree for EFL.
1604
1605         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1606         (DumpRenderTreeChrome::createView):
1607         (DumpRenderTreeChrome::onDownloadRequest):
1608         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
1609         (DumpRenderTreeChrome):
1610         * Scripts/webkitperl/FeatureList.pm:
1611
1612 2012-09-12  Stephanie Lewis  <slewis@apple.com>
1613
1614         Reduce parallism on the wk2 testers.
1615         https://bugs.webkit.org/show_bug.cgi?id=95906
1616
1617         Reviewed by Dirk Pranke.
1618
1619         The wk2 testers on Mountain Lion are getting stuck and timing out.  The problem appears to be due to
1620         resource contention.  Reducing the number of processes alleviates the issue.  
1621
1622         Starting by reducing 25%.
1623
1624         * Scripts/webkitpy/layout_tests/port/mac.py:
1625         (MacPort.default_child_processes):
1626
1627 2012-09-12  Brady Eidson  <beidson@apple.com>
1628
1629         Assert in NetscapePlugin::destroy() with async plugin init
1630         <rdar://problem/12277595> and https://bugs.webkit.org/show_bug.cgi?id=96576
1631
1632         Reviewed by Anders Carlsson.
1633
1634         Expose NPN_Invoke to plug-in tests:
1635         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1636         (PluginTest::NPN_Invoke):
1637         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1638         (PluginTest):
1639
1640         Add a test that uses NPN_Invoke on the window object from inside NPP_New to remove the plug-in element:
1641         * DumpRenderTree/TestNetscapePlugIn/Tests/InvokeDestroysPluginWithinNPP_New.cpp: Added.
1642         (InvokeDestroysPluginWithinNPP_New):
1643         (InvokeDestroysPluginWithinNPP_New::InvokeDestroysPluginWithinNPP_New):
1644         (InvokeDestroysPluginWithinNPP_New::NPP_New):
1645         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1646
1647 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1648
1649         refactor TestExpectations tokenization slightly in preparation for the new syntax
1650         https://bugs.webkit.org/show_bug.cgi?id=96564
1651
1652         Reviewed by Ojan Vafai.
1653
1654         This change changes how we will tokenize/lex the
1655         TestExpectations files, in preparation for supporting both the
1656         old syntax and the new one. This change by itself should be a
1657         no-op.
1658
1659         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1660         (TestExpectationParser._tokenize_line):
1661         (TestExpectationParser):
1662         (TestExpectationParser._tokenize_line_using_old_format):
1663         (TestExpectationParser._tokenize_line_using_new_format):
1664
1665 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1666
1667         remove unused testexpectations editing code from webkitpy, garden-o-matic
1668         https://bugs.webkit.org/show_bug.cgi?id=96562
1669
1670         Reviewed by Adam Barth.
1671
1672         This code was prototyped but never fully realized. Removing
1673         until it reanimates :).
1674
1675         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1676         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
1677         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Removed.
1678         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Removed.
1679         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1680         (BuildCoverageExtrapolator.extrapolate_test_configurations):
1681         (GardeningHTTPRequestHandler._run_webkit_patch):
1682         (GardeningHTTPRequestHandler.ping):
1683         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1684         (BuildCoverageExtrapolatorTest.test_extrapolate):
1685         (GardeningServerTest.test_rebaseline_new_port):
1686
1687 2012-09-12  Lucas Forschler  <lforschler@apple.com>
1688
1689         Remove unused bot, apple-xserve-1.
1690         https://bugs.webkit.org/show_bug.cgi?id=96570
1691         
1692         Reviewed by Stephanie Lewis.
1693
1694         * BuildSlaveSupport/build.webkit.org-config/config.json:
1695
1696 2012-09-12  Xan Lopez  <xlopez@igalia.com>
1697
1698         [GTK] We attempt to rebase documentation even if it's not present
1699         https://bugs.webkit.org/show_bug.cgi?id=96553
1700
1701         Reviewed by Martin Robinson.
1702
1703         Do not make the documentation rebase step fatal. This allows make
1704         install to succeed when there's no documentation generated.
1705
1706         * gtk/generate-gtkdoc:
1707
1708 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1709
1710         Respect WEBKITOUTPUTDIR when running EFL tests
1711         https://bugs.webkit.org/show_bug.cgi?id=96528
1712
1713         Reviewed by Dirk Pranke.
1714
1715         Expose user set WEBKITOUTPUTDIR to the web process.
1716
1717         * Scripts/webkitpy/layout_tests/port/driver.py:
1718         (Driver._start): Add WEBKITOUTPUTDIR to the environment
1719         of the web process and its potential jhbuild wrapper.
1720
1721 2012-09-12  Dirk Pranke  <dpranke@chromium.org>
1722
1723         webkitdirs: fix uname version handling for cygwin
1724         https://bugs.webkit.org/show_bug.cgi?id=96436
1725
1726         Reviewed by Jon Honeycutt.
1727
1728         Newer versions of cygwin embed an additional version string
1729         inside parentheses, so you get "1.7.16(0.249/5/3)" instead of "1.7.16".
1730         Update the code to handle that.
1731
1732         * Scripts/webkitdirs.pm:
1733         (setupAppleWinEnv):
1734
1735 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1736
1737         Regression(r128338): Broke Windows build
1738         https://bugs.webkit.org/show_bug.cgi?id=96537
1739
1740         Unreviewed build fix.
1741
1742         Fix Apple-Win build by allocating array dynamically
1743         since its size is not constant.
1744
1745         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1746         (WTR::stringArrayToJS):
1747
1748 2012-09-12  Alex Sakhartchouk  <alexst@chromium.org>
1749
1750         [chromium] Add a virtual test suite for fast/hidpi
1751         https://bugs.webkit.org/show_bug.cgi?id=90192
1752
1753         Reviewed by Dirk Pranke.
1754
1755         Add a virtual test suite to make sure the pixel tests in fast/hidpi give the same result
1756         on the hardware accelerated path as the software path.
1757
1758         * DumpRenderTree/chromium/WebPreferences.cpp:
1759         (WebPreferences::applyTo):
1760         * Scripts/webkitpy/layout_tests/port/chromium.py:
1761         (ChromiumPort.virtual_test_suites):
1762
1763 2012-09-12  Adam Klein  <adamk@chromium.org>
1764
1765         [chromium] Add content_browsertests to the flakiness dashboard
1766         https://bugs.webkit.org/show_bug.cgi?id=96535
1767
1768         Reviewed by Ojan Vafai.
1769
1770         * TestResultServer/static-dashboards/dashboard_base.js:
1771
1772 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1773
1774         [WK2][WKTR] TestRunner needs to implement originsWithApplicationCache
1775         https://bugs.webkit.org/show_bug.cgi?id=96496
1776
1777         Reviewed by Kenneth Rohde Christiansen.
1778
1779         Add implementation for originsWithApplicationCache to
1780         WebKitTestRunner.
1781
1782         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1783         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1784         (WTR::stringArrayToJS):
1785         (WTR):
1786         (WTR::TestRunner::originsWithApplicationCache):
1787         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1788         (TestRunner):
1789
1790 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1791
1792         Fix Qt/Windows build with Python3
1793         https://bugs.webkit.org/show_bug.cgi?id=96473
1794
1795         Reviewed by Csaba Osztrogonác.
1796
1797         In Python 3 print is a real function, so we must use parentheses around
1798         the function parameters. This is backwards compatible with Python 2.
1799
1800         * Scripts/generate-win32-export-forwards:
1801
1802 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1803
1804         Unreviewed trivial build fix for Qt/Windows after bug #96358.
1805
1806         As pointed out by Kevin, we should inject the "set PATH=..." statement
1807         to add the GnuWin32 directory only if that directory actually exists.
1808
1809         * qmake/mkspecs/features/default_post.prf:
1810
1811 2012-09-12  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1812
1813         [EFL] [WK2] Memory leaks in TestControllerEfl
1814         https://bugs.webkit.org/show_bug.cgi?id=96525
1815
1816         Reviewed by Kenneth Rohde Christiansen.
1817
1818         Fix memory leaks in EFL's TestRunner code by adopting an allocation
1819         of WKString created with WKStringCreateWithUTF8CString().
1820
1821         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1822         (WTR::TestController::initializeInjectedBundlePath):
1823         (WTR::TestController::initializeTestPluginDirectory):
1824
1825 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
1826
1827         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
1828         https://bugs.webkit.org/show_bug.cgi?id=96374
1829
1830         Reviewed by Kenneth Rohde Christiansen.
1831
1832         Implement support for dumpApplicationCacheDelegateCallbacks
1833         and disallowIncreaseForApplicationCacheQuota in
1834         WebKitTestRunner and properly dump the information
1835         expected by the tests.
1836
1837         If the application cache quota is reached for a given
1838         security origin, WebKitTestRunner will reset the quota
1839         to its default value, unless intructed not to via
1840         disallowIncreaseForApplicationCacheQuota().
1841
1842         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1843         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1844         (WTR::InjectedBundlePage::InjectedBundlePage):
1845         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
1846         (WTR):
1847         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1848         (InjectedBundlePage):
1849         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1850         (WTR::TestRunner::TestRunner):
1851         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
1852         (WTR):
1853         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1854         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
1855         (TestRunner):
1856         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
1857         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
1858
1859 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
1860
1861         [chromium] remove deprecated and unused sets import from chromium_android driver
1862         https://bugs.webkit.org/show_bug.cgi?id=96485
1863
1864         Reviewed by Dirk Pranke.
1865
1866         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1867
1868 2012-09-12  Zan Dobersek  <zandobersek@gmail.com>
1869
1870         Flakiness dashboard doesn't recognize new Chromium Android test builder
1871         https://bugs.webkit.org/show_bug.cgi?id=96523
1872
1873         Reviewed by Ojan Vafai.
1874
1875         Properly return 'ANDROID' as the Chromium platform for Android builders.
1876
1877         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1878         (chromiumPlatform):
1879         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1880         (test):
1881
1882 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1883
1884         [Qt] Build on Windows requires bison/flex in PATH
1885         https://bugs.webkit.org/show_bug.cgi?id=96358
1886
1887         Reviewed by Tor Arne Vestbø.
1888
1889         The build requires flex, bison, etc. and they need to be in the PATH when building. On Mac OS X
1890         and Linux that is rarely a problem given how easily available the tools are. On Windows however
1891         a separate installation of various GNU tools is required as the operating system doesn't come with
1892         them. To make the development more convenient, Qt 5 provides a copy of the most essential tools in
1893         the gnuwin32 directory of the qt5.git top-level repository.
1894
1895         This patch tries to detect the presence of those tools and prepends them to the PATH if found.
1896
1897         This is required in preparation for the elimination of qt5/qtwebkit.pri, which currently expands
1898         PATH before calling build-webkit. It it also required for the upcoming introduction of win_flex
1899         as dependency over flex, which can be done with less hassle when qt5's gnuwin32 directory has been
1900         updated with the new tool.
1901
1902         * Scripts/webkitdirs.pm:
1903         (checkRequiredSystemConfig):
1904         * qmake/mkspecs/features/default_post.prf:
1905
1906 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1907
1908         [Qt] Update build-jsc after r128174
1909
1910         Reviewed by Ossy.
1911
1912         * Scripts/build-jsc:
1913
1914 2012-09-12  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1915
1916         [Qt] Teach addStrictSubdirOrderBetween to handle more than two targets
1917
1918         By hard-coding the names of the targets we defined we ended up just
1919         redefining the previous target when using addStrictSubdirOrderBetween
1920         more than once in a single project file.
1921
1922         We now embed the two base targets into the target names.
1923
1924         Reviewed by Simon Hausmann.
1925
1926         * qmake/mkspecs/features/functions.prf:
1927
1928 2012-09-12  Philippe Liard  <pliard@google.com>
1929
1930         Depend on {base,net} GYP targets rather than {base,net}_java.
1931         https://bugs.webkit.org/show_bug.cgi?id=95690
1932
1933         Reviewed by Adam Barth.
1934
1935         {base,net}_java became 'private' targets on the Chromium side that
1936         clients should not depend on (see
1937         https://chromiumcodereview.appspot.com/10913083/).
1938         This removes a bunch of trailing white spaces additionally in
1939         TestWebkitAPI.gyp (which includes non-trailing white space changes).
1940
1941         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1942         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1943
1944 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1945
1946         [Qt] Fix the build with ENABLE_NETSCAPE_PLUGIN_API=0
1947         https://bugs.webkit.org/show_bug.cgi?id=96494
1948
1949         Reviewed by Tor Arne Vestbø.
1950
1951         WK2's ENABLE_PLUGIN_PROCESS uses the NPAPI functions unconditionally, so disable the
1952         plugin process feature if we don't have NPAPI.
1953
1954         * qmake/mkspecs/features/features.prf:
1955
1956 2012-09-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1957
1958         Unreviewed, rolling out r128280.
1959         http://trac.webkit.org/changeset/128280
1960         https://bugs.webkit.org/show_bug.cgi?id=96498
1961
1962         it broke compilation on windows debug bot (Requested by loislo
1963         on #webkit).
1964
1965         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1966         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1967         (WTR::InjectedBundlePage::InjectedBundlePage):
1968         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1969         (InjectedBundlePage):
1970         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1971         (WTR::TestRunner::TestRunner):
1972         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1973         (TestRunner):
1974
1975 2012-09-12  Simon Hausmann  <simon.hausmann@nokia.com>
1976
1977         [Qt] Make it possible to build with "make release" and "make debug" on Windows
1978         https://bugs.webkit.org/show_bug.cgi?id=96488
1979
1980         Reviewed by Tor Arne Vestbø.
1981
1982         A "make debug" is passed through recursively and currently it aborts at Makefile.DerivedSources
1983         because there are no such targets. We want the generated sources to be independent from release
1984         or debug build configurations, so it is sufficient to provide fake debug and release targets that
1985         redirect to the same general-purpose target (first) of creating the derived sources.
1986
1987         * qmake/mkspecs/features/default_post.prf:
1988
1989 2012-09-12  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1990
1991         [EFL] Make DumpRenderTree smarter at finding the fonts
1992         http://webkit.org/b/96281
1993
1994         Reviewed by Gyuyoung Kim.
1995
1996         Respect WEBKITOUTPUTDIR and expand the font dir from it.
1997         Use CString consistently.
1998
1999         * DumpRenderTree/efl/FontManagement.cpp:
2000         (buildPath):
2001         (getCoreFontFiles):
2002         (addFontDirectory):
2003         (addFontFiles):
2004         (getCustomBuildDir):
2005         (getPlatformFontsPath):
2006         (addFontsToEnvironment):
2007
2008 2012-09-12  Christophe Dumez  <christophe.dumez@intel.com>
2009
2010         [WK2][WKTR] TestRunner needs to implement dumpApplicationCacheDelegateCallbacks
2011         https://bugs.webkit.org/show_bug.cgi?id=96374
2012
2013         Reviewed by Kenneth Rohde Christiansen.
2014
2015         Implement support for dumpApplicationCacheDelegateCallbacks
2016         and disallowIncreaseForApplicationCacheQuota in
2017         WebKitTestRunner and properly dump the information
2018         expected by the tests.
2019
2020         If the application cache quota is reached for a given
2021         security origin, WebKitTestRunner will reset the quota
2022         to its default value, unless intructed not to via
2023         disallowIncreaseForApplicationCacheQuota().
2024
2025         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2026         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2027         (WTR::InjectedBundlePage::InjectedBundlePage):
2028         (WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):
2029         (WTR):
2030         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2031         (InjectedBundlePage):
2032         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2033         (WTR::TestRunner::TestRunner):
2034         (WTR::TestRunner::disallowIncreaseForApplicationCacheQuota):
2035         (WTR):
2036         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2037         (WTR::TestRunner::dumpApplicationCacheDelegateCallbacks):
2038         (TestRunner):
2039         (WTR::TestRunner::shouldDisallowIncreaseForApplicationCacheQuota):
2040         (WTR::TestRunner::shouldDumpApplicationCacheDelegateCallbacks):
2041
2042 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2043
2044         [WK2] [WTR] WebKitTestRunner needs TestRunner.workerThreadCount
2045         https://bugs.webkit.org/show_bug.cgi?id=96388
2046
2047         Reviewed by Kenneth Rohde Christiansen.
2048
2049         Exported TestRunner.workerThreadCount as readonly attribute.
2050
2051         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2052         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Added workerThreadCount() method implementation.
2053         (WTR::TestRunner::workerThreadCount): Returns count of worker threads.
2054         (WTR):
2055         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added workerThreadCount() method. 
2056         (TestRunner):
2057
2058 2012-09-12  Jochen Eisinger  <jochen@chromium.org>
2059
2060         [chromium] Consume a user gesture when creating a new view.
2061         https://bugs.webkit.org/show_bug.cgi?id=96373
2062
2063         Reviewed by Adam Barth.
2064
2065         * DumpRenderTree/chromium/WebViewHost.cpp:
2066         (WebViewHost::createView):
2067
2068 2012-09-12  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2069
2070         [WK2][WTR] Some of TestRunner special options are not reset before testing
2071         https://bugs.webkit.org/show_bug.cgi?id=96384
2072
2073         Reviewed by Kenneth Rohde Christiansen.
2074
2075         Now values of the following special options are reset:
2076         void setAcceptsEditing(in boolean value);
2077         void setCloseRemainingWindowsWhenComplete(in boolean value);
2078         void setXSSAuditorEnabled(in boolean value);
2079         void setAllowFileAccessFromFileURLs(in boolean value);
2080         void setPluginsEnabled(in boolean value);
2081         void setPopupBlockingEnabled(in boolean value);
2082
2083         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2084         (WTR::InjectedBundle::beginTesting):
2085
2086 2012-09-11  Ryuan Choi  <ryuan.choi@samsung.com>
2087
2088         [CMAKE] Supply feature defines to CodeGeneratorTestRunner.
2089         https://bugs.webkit.org/show_bug.cgi?id=96273
2090
2091         Reviewed by Gyuyoung Kim.
2092
2093         Passed FEATURE_DEFINES_WITH_SPACE_SEPARATOR to CodeGeneratorTestRunner
2094         in order to distinguish compile time options such as ENABLE(TOUCH_EVENTS).
2095
2096         * WebKitTestRunner/CMakeLists.txt:
2097
2098 2012-09-11  Dirk Pranke  <dpranke@chromium.org>
2099
2100         [chromium] rename webkit_resources
2101         https://bugs.webkit.org/show_bug.cgi?id=95874
2102
2103         Reviewed by James Robinson.
2104
2105         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2106
2107 2012-09-11  Jochen Eisinger  <jochen@chromium.org>
2108
2109         [chromium] don't include content shell builders in the garden-o-matic view
2110         https://bugs.webkit.org/show_bug.cgi?id=96418
2111
2112         Reviewed by James Robinson.
2113
2114         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2115
2116 2012-09-11  Adam Klein  <adamk@chromium.org>
2117
2118         Garden-o-matic should ignore a wider variety of warnings in buildbot json
2119         https://bugs.webkit.org/show_bug.cgi?id=96411
2120
2121         Reviewed by Adam Barth.
2122
2123         Previously only the exact string "warning" was treated as a warning
2124         result. This patch treats any string with "warning" as a substring
2125         as a warning (e.g., "warnings", as seen on the cr-win buildbots).
2126
2127         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
2128         (.):
2129         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2130
2131 2012-09-11  Marcelo Lira  <marcelo.lira@openbossa.org>
2132
2133         Restore original value of mock scrollbars enabled in InternalSettings
2134         https://bugs.webkit.org/show_bug.cgi?id=87680
2135
2136         Reviewed by Adam Barth.
2137
2138         Added backup support for mock scrollbars state in
2139         InternalSettings::Backup, and removed support for these
2140         from Qt's DumpRenderTree.
2141
2142         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2143         (WebCore::WebPage::resetSettings):
2144         * DumpRenderTree/qt/TestRunnerQt.cpp:
2145         (TestRunner::setFrameFlatteningEnabled):
2146         * DumpRenderTree/qt/TestRunnerQt.h:
2147         (TestRunner):
2148
2149 2012-09-11  Dan Bernstein  <mitz@apple.com>
2150
2151         Fixed a bug where kill-old-processes failed to kill clang++.
2152
2153         Rubber-stamped by Alexey Proskuryakov.
2154
2155         * BuildSlaveSupport/kill-old-processes: Escape the + signs in "clang++"
2156         where it is passed as a regular expression to killall.
2157
2158 2012-09-11  Philippe Liard  <pliard@google.com>
2159
2160         Make sure that md5sum is not setup on non-Chromium Android platforms.
2161         https://bugs.webkit.org/show_bug.cgi?id=96393
2162
2163         Reviewed by Adam Barth.
2164
2165         Previously md5sum was setup in ChromiumAndroidDriver's constructor
2166         which is also invoked on non-Chromium Android platforms. The following patch
2167         moves this logic to _startup_test() which is guaranteed to be invoked
2168         only on Android.
2169
2170         This also updates the prompt unit test in chromium_android_unittest.py.
2171
2172         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2173         (ChromiumAndroidDriver.__init__):
2174         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
2175         (ChromiumAndroidDriver._setup_test):
2176
2177 2012-09-11  Raphael Kubo da Costa  <rakuco@webkit.org>
2178
2179         [EFL] Rewrite the EFL-related Find modules
2180         https://bugs.webkit.org/show_bug.cgi?id=95237
2181
2182         Reviewed by Kenneth Rohde Christiansen.
2183
2184         * DumpRenderTree/efl/CMakeLists.txt: Stop setting the LINK_FLAGS
2185         property and include all the Enlightenment Foundation Libraries
2186         required by the target.
2187         * EWebLauncher/CMakeLists.txt: Ditto.
2188         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2189         * TestWebKitAPI/PlatformEfl.cmake: Add missing include directories
2190         now that they are not added implicitly.
2191         * WebKitTestRunner/CMakeLists.txt: Stop setting the LINK_FLAGS
2192         property.
2193         * WebKitTestRunner/PlatformEfl.cmake: Stop setting the LINK_FLAGS
2194         property and include all the Enlightenment Foundation Libraries
2195         required by the target.
2196
2197 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2198
2199         [WK2][WKTR] TestRunner needs to implement setApplicationCacheOriginQuota
2200         https://bugs.webkit.org/show_bug.cgi?id=96379
2201
2202         Reviewed by Kenneth Rohde Christiansen.
2203
2204         Add implementation for setApplicationCacheOriginQuota
2205         to WebKitTestRunner.
2206
2207         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2208         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2209         (WTR::TestRunner::setApplicationCacheOriginQuota):
2210         (WTR):
2211         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2212         (TestRunner):
2213
2214 2012-09-11  Luciano Wolf  <luciano.wolf@openbossa.org>
2215
2216         [Qt] [WK2] editing/inserting/typing-tab-designmode tests are failing
2217         https://bugs.webkit.org/show_bug.cgi?id=91988
2218
2219         Reviewed by Kenneth Rohde Christiansen.
2220
2221         Regular key events generated by Qt for the tab key fill both
2222         keyCode and keyText, so we should do the same for our fake events.
2223
2224         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2225         (WTR::EventSenderProxy::keyDown):
2226
2227 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2228
2229         [WK2][WTR] WebKitTestRunner needs testRunner.setSpatialNavigationEnabled
2230         https://bugs.webkit.org/show_bug.cgi?id=96269
2231
2232         Reviewed by Kenneth Rohde Christiansen.
2233
2234         Exported missing testRunner.setSpatialNavigationEnabled() method.
2235
2236         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2237         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2238         (WTR::InjectedBundle::beginTesting):
2239         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2240         (WTR::TestRunner::setSpatialNavigationEnabled):
2241         (WTR):
2242         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2243         (TestRunner):
2244
2245 2012-09-11  Philippe Liard  <pliard@chromium.org>
2246
2247         Support LayoutTests on non-rooted devices for Chromium Android.
2248         https://bugs.webkit.org/show_bug.cgi?id=95346
2249
2250         Reviewed by Dirk Pranke.
2251
2252         We were requiring root permissions to sync resource files with the
2253         device by comparing host and device files' timestamp after we
2254         synchronized the device and host clocks.
2255         We now rely on md5sum provided by Chromium to handle data files
2256         synchronization.
2257
2258         * Scripts/webkitpy/layout_tests/port/chromium.py:
2259         (ChromiumPort._check_driver_build_up_to_date):
2260         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2261         (ChromiumAndroidDriver.__init__):
2262         (ChromiumAndroidDriver._setup_test):
2263         (ChromiumAndroidDriver._push_executable):
2264         (ChromiumAndroidDriver._push_test_resources):
2265         (ChromiumAndroidDriver._read_prompt):
2266
2267 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2268
2269         [Qt] Fix output paths on Windows
2270
2271         Reviewed by Tor Arne Vestbø.
2272
2273         BUILD_ROOT_RELATIVE_TO_OUT_PWD was calculated incorrectly Windows, resulting in an incorrect
2274         DESTDIR transformation at the end of default_post.prf. The calculation should be baased no qmake
2275         paths, which can use drive letters but always use forward slashes. So the use of QMAKE_DIR_SEP is
2276         incorrect here and instead for the calculation we should use forward slashes.
2277
2278         * qmake/mkspecs/features/default_pre.prf:
2279
2280 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2281
2282         [Qt] Fix passing of defines from the build system
2283
2284         We explicitly have to pass -DENABLE_FOO=0 for every single feature
2285         that's not explicitly enabled in WEBKIT_CONFIG, since Platform.h
2286         will add it's own defaults if the features are not defined.
2287
2288         At some point we might want to run a configure-test to inspect what
2289         Platform.h will do, so we can sync up the build system's view of
2290         the feature-defines with the compile-time situation.
2291
2292         Reviewed by Simon Hausmann.
2293
2294         * qmake/mkspecs/features/functions.prf:
2295
2296 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2297
2298         [Qt] Fix --qt option to build-webkit
2299
2300         Reviewed by Ossy.
2301
2302         * Scripts/webkitdirs.pm:
2303         (buildQMakeProjects):
2304
2305 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2306
2307         [Qt] Add a configure step to the Qt build system
2308
2309         This allows building the Qt port using just 'qmake WebKit.pro'. Using
2310         the build-webkit script is still supported, and will add slightly more
2311         logic to the build, such as detecting the need for clean or incremental
2312         builds.
2313
2314         Internally, the build system now uses a new variable, WEBKIT_CONFIG, for
2315         all things related to configuring the build, such as use/have/enable flags,
2316         and these are translated to defines in default_post. Project files should
2317         no longer check contains(DEFINES,...) to detect features, but use the new
2318         enable?(), use?(), and have?() functions. The no_webkit1 and no_webkit2
2319         options have been translated into WEBKIT_CONFIG options as well, and can
2320         be checked using build?().
2321
2322         Reviewed by Simon Hausmann.
2323
2324         * DumpRenderTree/qt/DumpRenderTree.pro:
2325         * MiniBrowser/qt/MiniBrowser.pro:
2326         * QtTestBrowser/QtTestBrowser.pro:
2327         * Scripts/build-webkit:
2328         * Scripts/webkitdirs.pm:
2329         (qtFeatureDefaults):
2330         (buildQMakeProjects):
2331         * Tools.pro:
2332         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
2333         * WebKitTestRunner/InjectedBundle/Target.pri:
2334         * WebKitTestRunner/Target.pri:
2335         * qmake/.qmake.cache: Added.
2336         * qmake/configure.pri: Removed.
2337         * qmake/configure.pro: Removed.
2338         * qmake/dump-features: Added.
2339         * qmake/mkspecs/features/configure.prf: Added.
2340         * qmake/mkspecs/features/default_post.prf:
2341         * qmake/mkspecs/features/default_pre.prf:
2342         * qmake/mkspecs/features/features.prf:
2343         * qmake/mkspecs/features/features.pri:
2344         * qmake/mkspecs/features/functions.prf:
2345         * qmake/mkspecs/features/gprof.prf:
2346         * qmake/mkspecs/features/mac/default_pre.prf:
2347         * qmake/mkspecs/features/win32/default_pre.prf:
2348
2349 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2350
2351         [WK2][WKTR] TestRunner needs to implement clearApplicationCacheForOrigin
2352         https://bugs.webkit.org/show_bug.cgi?id=96372
2353
2354         Reviewed by Kenneth Rohde Christiansen.
2355
2356         Implement clearApplicationCacheForOrigin() in WebKitTestRunner.
2357
2358         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2359         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2360         (WTR::TestRunner::clearApplicationCacheForOrigin):
2361         (WTR):
2362         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2363         (TestRunner):
2364
2365 2012-09-11  Peter Beverloo  <peter@chromium.org>
2366
2367         Don't ignore .pak files when making an archive for Android
2368         https://bugs.webkit.org/show_bug.cgi?id=96375
2369
2370         Reviewed by Jochen Eisinger.
2371
2372         The .pak files do need to be pushed to the device, which is currently
2373         preventing the layout test runner from correctly pushing all files.
2374
2375         * BuildSlaveSupport/built-product-archive:
2376         (archiveBuiltProduct):
2377
2378 2012-09-11  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2379
2380         [WK2][WTR] WebKitTestRunner needs layoutTestController.setMinimumTimerInterval
2381         https://bugs.webkit.org/show_bug.cgi?id=96256
2382
2383         Reviewed by Kenneth Rohde Christiansen.
2384
2385         Exported TestRunner::setMinimumTimerInterval() method.
2386
2387         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2388         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2389         (WTR::InjectedBundle::beginTesting):
2390         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2391         (WTR::TestRunner::setMinimumTimerInterval):
2392         (WTR):
2393         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2394         (TestRunner):
2395
2396 2012-09-11  Tommy Widenflycht  <tommyw@google.com>
2397
2398         MediaStream API: add RTCPeerConnection::onnegotiationneeded
2399         https://bugs.webkit.org/show_bug.cgi?id=96097
2400
2401         Reviewed by Adam Barth.
2402
2403         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2404         (MockWebRTCPeerConnectionHandler::addStream):
2405         (MockWebRTCPeerConnectionHandler::removeStream):
2406
2407 2012-09-11  Peter Beverloo  <peter@chromium.org>
2408
2409         Recognize the "--chromium-android" argument in run-webkit-tests
2410         https://bugs.webkit.org/show_bug.cgi?id=96369
2411
2412         Reviewed by Jochen Eisinger.
2413
2414         Chromium for the Android platform cannot determine the platform based on
2415         the host itself, so we'll use the --chromium-android argument as the build
2416         master passes to run-webkit-tests. Make sure the layout test runner
2417         can pick the right port when doing so.
2418
2419         * Scripts/run-webkit-tests:
2420         * Scripts/webkitpy/layout_tests/port/factory.py:
2421         (port_options):
2422
2423 2012-09-11  Simon Hausmann  <simon.hausmann@nokia.com>
2424
2425         [QT] Fix build with newer qmake from Qt 5
2426
2427         Rubber-stamped by Tor Arne Vestbø.
2428
2429         Support for "qmake -query QMAKE_MKSPECS" was removed from qmake. Replace
2430         it with the use of QT_HOST_DATA/mkspecs.
2431         Based on patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>.
2432
2433         * Scripts/webkitdirs.pm:
2434         (builtDylibPathForName):
2435         (qtMakeCommand):
2436
2437 2012-09-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2438
2439         [Qt] Remove Qt 4 syncqt, no longer needed
2440
2441         Reviewed by Simon Hausmann.
2442
2443         * qmake/syncqt-4.8: Removed.
2444
2445 2012-09-11  Andras Becsi  <andras.becsi@nokia.com>
2446
2447         [Qt][WK2] Fix the build with recent Qt5
2448         https://bugs.webkit.org/show_bug.cgi?id=96283
2449
2450         Reviewed by Simon Hausmann.
2451
2452         We should not use deprecated Qt API because doing that results
2453         in build failure since all the deprecated API was disabled
2454         in qtbase (https://codereview.qt-project.org/#change,24890).
2455
2456         * DumpRenderTree/qt/main.cpp:
2457         (main):
2458         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2459         (MiniBrowserApplication::notify):
2460         * MiniBrowser/qt/raw/View.cpp:
2461         (View::exposeEvent):
2462         (main):
2463
2464 2012-09-11  Christophe Dumez  <christophe.dumez@intel.com>
2465
2466         WTR needs an implementation of applicationCacheDiskUsageForOrigin
2467         https://bugs.webkit.org/show_bug.cgi?id=87188
2468
2469         Reviewed by Kenneth Rohde Christiansen.
2470
2471         Add implementation for applicationCacheDiskUsageForOrigin()
2472         in WebKitTestRunner.
2473
2474         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2475         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2476         (WTR::TestRunner::applicationCacheDiskUsageForOrigin):
2477         (WTR):
2478         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2479         (TestRunner):
2480
2481 2012-09-10  Joanmarie Diggs  <jdiggs@igalia.com>
2482
2483         Properly expose <legend> elements to ATs
2484         https://bugs.webkit.org/show_bug.cgi?id=84137
2485
2486         Reviewed by Chris Fleizach.
2487
2488         Created a new WebCore Accessibility Role, LegendRole. Used it to map to
2489         the expected platform role, ATK_ROLE_LABEL. Also established the needed
2490         AtkRelation pair, label-for/labelled-by between the legend and fieldset.
2491
2492         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2493         (roleToString): added "Legend" string for WebAccessibilityRoleLegend
2494
2495 2012-09-10  Jer Noble  <jer.noble@apple.com>
2496
2497         Unreviewed; rolling out r128081.
2498         http://trac.webkit.org/changeset/128081
2499         https://bugs.webkit.org/show_bug.cgi?id=96134
2500
2501         New test http/tests/media/video-donottrack.html fails to run on Apple test bots.
2502
2503         * DumpRenderTree/TestRunner.cpp:
2504         (TestRunner::TestRunner):
2505         (TestRunner::staticFunctions):
2506         * DumpRenderTree/TestRunner.h:
2507         (TestRunner):
2508         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2509         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2510         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2511         (WTR::InjectedBundlePage::InjectedBundlePage):
2512         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2513         (InjectedBundlePage):
2514         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2515         (WTR::TestRunner::TestRunner):
2516         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2517         (TestRunner):
2518
2519 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2520
2521         TestExpectationsChecker._determine_port_from_expectations_path() does not support cascaded TestExpectations
2522         https://bugs.webkit.org/show_bug.cgi?id=96205
2523
2524         Reviewed by Tony Chang.
2525
2526         _determine_port_from_expectations_path() was calling port.path_to_test_expectations_file()
2527         internally, which means that it would support only 1 TestExpectations file per port. This
2528         is an issue for ports such as EFL that support cascased TestExpectations (efl-wk2 -> efl
2529         and efl-wk1 -> efl).
2530
2531         This patch makes _determine_port_from_expectations_path() call port.expectations_files()
2532         instead so that all the ports TestExpectations are recognized. The ports are also
2533         constructed twice, with "webkit_test_runner" option set to True and False so that we
2534         retrieve the TestExpectations paths for both WebKit1 and WebKit2.
2535
2536         * Scripts/webkitpy/style/checkers/test_expectations.py:
2537         (TestExpectationsChecker._determine_port_from_expectations_path):
2538         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add corresponding unit test.
2539         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
2540
2541 2012-09-10  Ryuan Choi  <ryuan.choi@samsung.com>
2542
2543         [WTR] Generated source files should include config.h
2544         https://bugs.webkit.org/show_bug.cgi?id=96254
2545
2546         Reviewed by Benjamin Poulain.
2547
2548         Current coding style has encouraged to include config.h at the first position,
2549         But derived sources, generated by CodeGeneratorTestRunner.pm, don't follow
2550         this rule.
2551         Therefore, this patch added it.
2552
2553         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
2554         (_generateImplementationFile):
2555
2556 2012-09-10  Rick Byers  <rbyers@chromium.org>
2557
2558         Add handling of new GestureTapCancel in DRT
2559         
2560         https://bugs.webkit.org/show_bug.cgi?id=96183
2561
2562         Reviewed by Adam Barth.
2563
2564         * DumpRenderTree/chromium/TestWebPlugin.cpp:
2565         (TestWebPlugin::handleInputEvent):
2566
2567 2012-09-10  Brady Eidson  <beidson@apple.com>
2568
2569         Javascript in foreground tabs should not wait synchronously for plug-ins to load
2570         <rdar://problem/12067415> and https://bugs.webkit.org/show_bug.cgi?id=96167
2571
2572         Reviewed by Geoff Garen.
2573
2574         Enhance the "Slow NPP_New" plug-in to also be able to return properties to javascript.
2575
2576         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp:
2577         (PluginObject):
2578         (SlowNPPNew::PluginObject::PluginObject):
2579         (SlowNPPNew::PluginObject::~PluginObject):
2580         (SlowNPPNew::PluginObject::hasProperty):
2581         (SlowNPPNew::PluginObject::getProperty):
2582         (SlowNPPNew::NPP_GetValue):
2583         (SlowNPPNew):
2584
2585 2012-09-10  Tim Horton  <timothy_horton@apple.com>
2586
2587         WKTR often reports an unresponsive WebProcess on Mac bots
2588         https://bugs.webkit.org/show_bug.cgi?id=95906
2589
2590         Reviewed by Dan Bernstein.
2591
2592         Attempt to work around resource contention issues by increasing the NRWT
2593         timeout when running against WKTR, as well as WKTR's own WebProcess timeout.
2594
2595         * Scripts/webkitpy/layout_tests/port/base.py:
2596         (Port.default_timeout_ms): Default timeout when using WKTR -> 80 seconds.
2597         * WebKitTestRunner/TestController.cpp:
2598         (WTR): LongTimeout (used when waiting for WebProcess to finish) -> 60 seconds.
2599
2600 2012-09-07  Jer Noble  <jer.noble@apple.com>
2601
2602         <audio> and <video> should send Do Not Track when appropriate
2603         https://bugs.webkit.org/show_bug.cgi?id=96134
2604
2605         Reviewed by Eric Carlson.
2606
2607         Add a testRunner JS API for calling setShouldSendDoNotTrackHTTPHeader to DRT and 
2608         WTR. Add FrameLoaderClient client methods for retrieving that value.
2609
2610         * DumpRenderTree/TestRunner.cpp:
2611         (setShouldSendDoNotTrackHTTPHeaderCallback): Pass through to the TestRunner.
2612         (TestRunner::staticFunctions): Add the setShouldSendDoNotTrackHTTPHeader function.
2613         * DumpRenderTree/TestRunner.h:
2614         (TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple setter.
2615         (TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2616         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2617         (-[FrameLoadDelegate webViewShouldSendDoNotTrackHTTPHeader:]): 
2618             Pass the question on to the TestRunner.
2619         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2620         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2621         (WTR::InjectedBundlePage::InjectedBundlePage):
2622             Add the setShouldSendDoNotTrackHTTPHeader client function.
2623         (WTR::InjectedBundlePage::shouldSendDoNotTrackHTTPHeader):
2624             Pass the question on to the TestRunner.
2625         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2626         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2627         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2628         (WTR::TestRunner::shouldSendDoNotTrackHTTPHeader): Simple getter.
2629         (WTR::TestRunner::setShouldSendDoNotTrackHTTPHeader): Simple Setter.
2630
2631 2012-09-10  Ojan Vafai  <ojan@chromium.org>
2632
2633         Make EFL bots work on the flakiness dashboard
2634         https://bugs.webkit.org/show_bug.cgi?id=96164
2635
2636         Reviewed by Tony Chang.
2637
2638         Also, update outdated unittests that had started failing.
2639
2640         * TestResultServer/static-dashboards/builders.js:
2641         (isWebkitTestRunner):
2642         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2643         (nonChromiumPlatform):
2644         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2645         (test):
2646
2647 2012-09-10  Tommy Widenflycht  <tommyw@google.com>
2648
2649         [chromium] MediaStream API: Remove the Descriptor postfix
2650         https://bugs.webkit.org/show_bug.cgi?id=96268
2651
2652         Reviewed by Adam Barth.
2653
2654         After consideration I realized that there is no need whatsoever in using the Descriptor prefix
2655         in the WekKit embedder API. Removed from WebRTCSessionDescription and WebRTCICECandidate to start with.
2656
2657         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2658         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
2659         (MockWebRTCPeerConnectionHandler::createOffer):
2660         (MockWebRTCPeerConnectionHandler::createAnswer):
2661         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2662         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2663         (MockWebRTCPeerConnectionHandler::localDescription):
2664         (MockWebRTCPeerConnectionHandler::remoteDescription):
2665         (MockWebRTCPeerConnectionHandler::addICECandidate):
2666         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2667         (MockWebRTCPeerConnectionHandler):
2668
2669 2012-09-10  Arnaud Renevier  <a.renevier@sisa.samsung.com>
2670
2671         [Gtk] failure to build jhbuild dependencies with cups 1.6
2672         https://bugs.webkit.org/show_bug.cgi?id=95991
2673
2674         Reviewed by Gustavo Noronha Silva.
2675
2676         Bump gtk+ and gnome-themes-standard dependencies to 3.4.2 to allow
2677         building with cups >= 1.6 [GNOME #670373].
2678
2679         * gtk/jhbuild.modules:
2680
2681 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2682
2683         [EFL][DRT] Encoding issue in printed console messages
2684         https://bugs.webkit.org/show_bug.cgi?id=96263
2685
2686         Reviewed by Kenneth Rohde Christiansen.
2687
2688         Correctly handle CONSOLE messages that contain non-ascii
2689         characters in EFL's DRT. We need to use String::fromUTF8()
2690         to construct a WTF::String from a raw string.
2691
2692         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
2693         (onConsoleMessage):
2694
2695 2012-09-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2696
2697         [WK2][WTR] User style sheet location should be reset before each test
2698         https://bugs.webkit.org/show_bug.cgi?id=96262
2699
2700         Reviewed by Kenneth Rohde Christiansen.
2701
2702         User style sheet location is reset before each test now.
2703
2704         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2705         (WTR::InjectedBundle::beginTesting):
2706
2707 2012-09-10  Simon Hausmann  <simon.hausmann@nokia.com>
2708
2709         Fix build of WTR with Qt on Windows
2710         https://bugs.webkit.org/show_bug.cgi?id=96249
2711
2712         Reviewed by Kenneth Rohde Christiansen.
2713
2714         Windows loves to define min and max as macros, which beautifully
2715         clashes in many places where min and max are used as variable or method
2716         names. It can be convinced not to do this when min and max are already
2717         define as macros (expanding to themselves). We have this kind of
2718         workaround in config.h files all over WebKit and as it turns out when
2719         building WTR with Qt on Windows we do end up with such a clash. Therefore
2720         we need the same workaround.
2721
2722         * WebKitTestRunner/config.h:
2723
2724 2012-09-10  Christophe Dumez  <christophe.dumez@intel.com>
2725
2726         [WK2] New fast/forms/number/number-interactive-validation-required.html fails
2727         https://bugs.webkit.org/show_bug.cgi?id=95936
2728
2729         Reviewed by Kenneth Rohde Christiansen.
2730
2731         Enable interactive form validation setting in WebKitTestRunner as
2732         we are currently doing in DumpRenderTree. This is needed for some
2733         tests to pass.
2734
2735         * WebKitTestRunner/TestController.cpp:
2736         (WTR::TestController::resetStateToConsistentValues):
2737
2738 2012-09-09  Zan Dobersek  <zandobersek@gmail.com>
2739
2740         Clean up the code in XvfbDriver
2741         https://bugs.webkit.org/show_bug.cgi?id=96202
2742
2743         Reviewed by Philippe Normand.
2744
2745         Changes:
2746         - Remove unneeded imports,
2747         - assign the _lock_file member variable when the display number is determined,
2748         - no need for parentheses around a single string format argument,
2749         - use FileSystem.exists method when checking if lock file is present as it
2750         makes the intention much more clearer.
2751
2752         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2753         (XvfbDriver._start):
2754         (XvfbDriver.stop):
2755
2756 2012-09-09  Patrick Gansterer  <paroga@webkit.org>
2757
2758         Make the String initialization on the function side of String::number()
2759         https://bugs.webkit.org/show_bug.cgi?id=95940
2760
2761         Reviewed by Benjamin Poulain.
2762
2763         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp:
2764         (testBoundaries):
2765         (testNumbers):
2766
2767 2012-09-09  Pierre Rossi  <pierre.rossi@gmail.com>
2768
2769         [WK2] expose element rect for color input type
2770         https://bugs.webkit.org/show_bug.cgi?id=91664
2771
2772         Reviewed by Simon Hausmann.
2773
2774         Update the QML logic in MiniBrowser to take advantage of this.
2775         The picker size is now hardcoded and we try to place it below the
2776         input element if possible.
2777
2778         * MiniBrowser/qt/qml/ColorChooser.qml:
2779
2780 2012-09-08  Christophe Dumez  <christophe.dumez@intel.com>
2781
2782         [WK2] New fast/events/tab-focus-link-in-canvas fails from r126908
2783         https://bugs.webkit.org/show_bug.cgi?id=95329
2784
2785         Reviewed by Kenneth Rohde Christiansen.
2786
2787         Explicitely disable TabToLinks setting in WebKitTestRunner.
2788         Tests override the "WebKitTabToLinksPreferenceKey" preference
2789         to enable it.
2790
2791         * WebKitTestRunner/TestController.cpp:
2792         (WTR::TestController::resetStateToConsistentValues):
2793
2794 2012-09-08  Kenichi Ishibashi  <bashi@chromium.org>
2795
2796         webkit.py gdb pretty printer can't print CString
2797         https://bugs.webkit.org/show_bug.cgi?id=96068
2798
2799         Reviewed by Tony Chang.
2800
2801         Update WTFCStringPrinter to follow r126191.
2802
2803         * gdb/webkit.py:
2804         (WTFCStringPrinter.to_string):
2805
2806 2012-09-07  Benjamin Poulain  <bpoulain@apple.com>
2807
2808         Rename the ustring() accessor to string()
2809         https://bugs.webkit.org/show_bug.cgi?id=95919
2810
2811         Reviewed by Geoffrey Garen.
2812
2813         Update EFL's DRT.
2814
2815         Fix some string conversion that have been made useless
2816         with recent changes.
2817
2818         * DumpRenderTree/efl/EventSender.cpp:
2819         (keyPadNameFromJSValue):
2820         (keyNameFromJSValue):
2821         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2822         (TestRunner::queueLoad):
2823         (TestRunner::addOriginAccessWhitelistEntry):
2824         (TestRunner::removeOriginAccessWhitelistEntry):
2825         (TestRunner::setUserStyleSheetLocation):
2826         (TestRunner::setValueForUser):
2827         (TestRunner::elementDoesAutoCompleteForElementWithId):
2828         (TestRunner::execCommand):
2829         (TestRunner::findString):
2830         (TestRunner::isCommandEnabled):
2831         (TestRunner::clearApplicationCacheForOrigin):
2832         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2833         (TestRunner::pauseAnimationAtTimeOnElementWithId):
2834         (TestRunner::pauseTransitionAtTimeOnElementWithId):
2835         (toInt):
2836         (TestRunner::overridePreference):
2837         (TestRunner::addUserScript):
2838         (TestRunner::addUserStyleSheet):
2839         (TestRunner::evaluateInWebInspector):
2840         (TestRunner::evaluateScriptInIsolatedWorld):
2841         (TestRunner::setTextDirection):
2842         * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
2843         (LoadItem::invoke):
2844         (LoadHTMLStringItem::invoke):
2845         (ScriptItem::invoke):
2846
2847 2012-09-06  Jeffrey Pfau  <jpfau@apple.com>
2848
2849         Extend third-party storage blocking API to optionally allow blocking all storage
2850         https://bugs.webkit.org/show_bug.cgi?id=95915
2851
2852         Reviewed by Brady Eidson.
2853
2854         Modified API test to use new revised API.
2855
2856         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2857         (TestWebKitAPI::TEST):
2858
2859 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2860
2861         AX: WebCore accessibility roles should be cross-platform
2862         https://bugs.webkit.org/show_bug.cgi?id=94870
2863
2864         Reviewed by Chris Fleizach.
2865
2866         Add debug strings to Chromium for new accessibility roles.
2867
2868         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2869         (roleToString):
2870
2871 2012-09-07  Dominic Mazzoni  <dmazzoni@google.com>
2872
2873         AX: Chromium needs access to canvasHasFallbackContent
2874         https://bugs.webkit.org/show_bug.cgi?id=96124
2875
2876         Reviewed by Chris Fleizach.
2877
2878         Distinguish between canvas roles with and without fallback
2879         content on Chromium.
2880
2881         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2882         (getRole):
2883
2884 2012-09-07  Ojan Vafai  <ojan@chromium.org>
2885
2886         Handle non-existant TestExpectations files gracefully
2887         https://bugs.webkit.org/show_bug.cgi?id=96149
2888
2889         Reviewed by Eric Seidel.
2890
2891         Even when we get rid of Skipped files, we shouldn't have each port
2892         require a TestExpectations file for each platform if it doesn't
2893         need one.
2894
2895         * Scripts/webkitpy/layout_tests/port/base.py:
2896         (Port.expectations_dict):
2897         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2898         (PortTest.test_nonexistant_expectations):
2899
2900 2012-09-07  Tony Chang  <tony@chromium.org>
2901
2902         Regression: check-webkit-style no longer checks TestExpectations for syntax errors
2903         https://bugs.webkit.org/show_bug.cgi?id=96136
2904
2905         Reviewed by Ojan Vafai.
2906
2907         When we renamed the file to TestExpectations, it was no longer considered a text file so
2908         it was no longer being checked. Since then, test_expectations_overrides() has been removed
2909         from the port object, so I've removed that from the check. I'm not sure what it was
2910         supposed to do.
2911
2912         * Scripts/webkitpy/style/checker.py:
2913         (CheckerDispatcher._file_type): Mark TestExpectations as a text file.
2914         * Scripts/webkitpy/style/checkers/test_expectations.py:
2915         (TestExpectationsChecker.check_test_expectations): Remove overrides param.
2916         (TestExpectationsChecker.check): Remove overrides param.
2917         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2918         (TestExpectationsTestCase.assert_lines_lint): Remove overrides param.
2919
2920 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
2921
2922         [EFL] Use same default minimum logical font size in DRT and WTR
2923         https://bugs.webkit.org/show_bug.cgi?id=96116
2924
2925         Reviewed by Martin Robinson.
2926
2927         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2928         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Set minimum
2929         logical font size to 9 to match the value used in WTR.
2930         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2931         (WTR::InjectedBundle::beginTesting): Explicitly set the minimum
2932         logical font size to 9 (default value in WK2)
2933
2934 2012-09-07  Tommy Widenflycht  <tommyw@google.com>
2935
2936         MediaStream API: add RTCPeerConnection::createAnswer
2937         https://bugs.webkit.org/show_bug.cgi?id=96092
2938
2939         Reviewed by Adam Barth.
2940
2941         Expanding and enhancing MockWebRTCPeerConnectionHandler.
2942
2943         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
2944         (MockWebRTCPeerConnectionHandler::createOffer):
2945         (MockWebRTCPeerConnectionHandler::createAnswer):
2946         (MockWebRTCPeerConnectionHandler::setLocalDescription):
2947         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
2948         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
2949         (MockWebRTCPeerConnectionHandler):
2950
2951 2012-09-07  Dean Jackson  <dino@apple.com>
2952
2953         Unreviewed changes to watchlist.
2954
2955         - Add new WebGL and Filters definitions
2956         - Add myself to OpenGL bugs
2957
2958         * Scripts/webkitpy/common/config/watchlist:
2959
2960 2012-09-07  Peter Beverloo  <peter@chromium.org>
2961
2962         Actually trigger the Android Tester
2963         https://bugs.webkit.org/show_bug.cgi?id=96118
2964
2965         Reviewed by Adam Barth.
2966
2967         * BuildSlaveSupport/build.webkit.org-config/config.json:
2968
2969 2012-09-07  Dominic Mazzoni <dmazzoni@google.com>
2970
2971         New time input needs accessibility
2972         https://bugs.webkit.org/show_bug.cgi?id=96032
2973
2974         Reviewed by Chris Fleizach.
2975
2976         Add support for valueDescription for testing.
2977
2978         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
2979         (getValueDescription):
2980         (AccessibilityUIElement::AccessibilityUIElement):
2981         (AccessibilityUIElement::valueDescriptionGetterCallback):
2982         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.h:
2983         (AccessibilityUIElement):
2984
2985 2012-09-07  Peter Beverloo  <peter@chromium.org>
2986
2987         Add the google-android-tests build slave to the master's config
2988         https://bugs.webkit.org/show_bug.cgi?id=96113
2989
2990         Reviewed by Csaba Osztrogonác.
2991
2992         * BuildSlaveSupport/build.webkit.org-config/config.json:
2993
2994 2012-09-07  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2995
2996         [WK2] [EFL] Set theme for WebKit2 API test runner
2997         https://bugs.webkit.org/show_bug.cgi?id=96100
2998
2999         Reviewed by Kenneth Rohde Christiansen.
3000
3001         Set the theme generated by the build for the WebKit2 API test runner.
3002
3003         * TestWebKitAPI/PlatformEfl.cmake:
3004         * TestWebKitAPI/efl/PlatformWebView.cpp:
3005         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3006
3007 2012-09-07  Csaba Osztrogonác  <ossy@webkit.org>
3008
3009         Unreviewed. Add Gábor Ballabás as contributor.
3010
3011         * Scripts/webkitpy/common/config/committers.py:
3012
3013 2012-09-07  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3014
3015         [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build.
3016         https://bugs.webkit.org/show_bug.cgi?id=96078
3017
3018         Reviewed by Tor Arne Vestbø.
3019
3020         Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation.
3021
3022         * qmake/mkspecs/features/default_pre.prf:
3023
3024 2012-09-07  Christophe Dumez  <christophe.dumez@intel.com>
3025
3026         [EFL] Add TestExpectations file for efl-wk1
3027         https://bugs.webkit.org/show_bug.cgi?id=96019
3028
3029         Reviewed by Gyuyoung Kim.
3030
3031         Update TestExpectations cascading for EFL port
3032         so that we use efl-wk1 -> efl search paths
3033         for WebKit1 EFL.
3034
3035         * Scripts/webkitpy/layout_tests/port/efl.py:
3036         (EflPort._search_paths):
3037
3038 2012-09-07  Zan Dobersek  <zandobersek@gmail.com>
3039
3040         [NRWT] XvfbDriver should stop the Xvfb more aggressively
3041         https://bugs.webkit.org/show_bug.cgi?id=95097
3042
3043         Reviewed by Dirk Pranke.
3044
3045         The Xvfb process is now killed when the XvfbDriver is stopping. Simply
3046         terminating the process does not always work as expected, leading to timeouts
3047         in run-webkit-tests on the buildbot. The lock file Xvfb creates is also removed
3048         as it's not removed by the killed Xvfb process.
3049
3050         Also included is a thorough unittest for XvfbDriver. Proper starting of the driver
3051         is tested in different circumstances - whether pixel tests are enabled or not,
3052         with an arbitrary worker number or with an Xorg process already running on the system.
3053         The stopping of the driver is tested by checking that the Xvfb process is truly killed
3054         and then set to None.
3055
3056         * BuildSlaveSupport/kill-old-processes:
3057         Kill any stale Xvfb processes at the start of the build cycle so no Xvfb
3058         is left running, potentially clogging up a display at a certain position.
3059         * Scripts/webkitpy/common/system/executive_mock.py:
3060         (MockExecutive.__init__):
3061         The _running_pids is now a dictionary with process names as keys and pids
3062         as values.
3063         (MockExecutive.check_running_pid):
3064         Check whether the passed-in pid is in the _running_pids dictionary's values.
3065         (MockExecutive):
3066         (MockExecutive.running_pids):
3067         This method returns the list of all the process pids of which the name passes
3068         through the process_name_filter.
3069         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3070         Use the Executive object of the port's host to check for running pids and open
3071         new subprocesses or kill them throughout the class.
3072         (XvfbDriver._start):
3073         Use the _server_process_constructor to make testing the XvfbDriver possible. Also,
3074         start the server process after it's created.
3075         (XvfbDriver.stop):
3076         Now kills the Xvfb process instead of terminating it and waiting for it to close.
3077         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py: Added.
3078         (XvfbDriverTest):
3079         (XvfbDriverTest.make_driver):
3080         (XvfbDriverTest.assertDriverStartSuccessful):
3081         (XvfbDriverTest.test_start_no_pixel_tests):
3082         (XvfbDriverTest.test_start_pixel_tests):
3083         (XvfbDriverTest.test_start_arbitrary_worker_number):
3084         (XvfbDriverTest.test_start_existing_xorg_process):
3085         (XvfbDriverTest.test_stop):
3086         (XvfbDriverTest.test_stop.FakeXvfbProcess):
3087
3088 2012-09-06  Peter Beverloo  <peter@chromium.org>
3089
3090         Introduce the Chromium Android Release (Tests) bot
3091         https://bugs.webkit.org/show_bug.cgi?id=95980
3092
3093         Reviewed by Adam Barth.
3094
3095         This adds the Chromium Android Release (Tests) bot to the WebKit waterfall,
3096         which will be running layout tests on actual Android devices. Right now,
3097         four Galaxy Nexus phones are attached.
3098
3099         * BuildSlaveSupport/build.webkit.org-config/config.json:
3100
3101 2012-09-06  James Robinson  <jamesr@chromium.org>
3102
3103         [chromium] Use WebCompositorSupport functions instead of WebCompositor statics
3104         https://bugs.webkit.org/show_bug.cgi?id=96007
3105
3106         Reviewed by Adrienne Walker.
3107
3108         Fixes initialization / settings code to use WebCompositorSupport.
3109
3110         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3111         (main):
3112         * DumpRenderTree/chromium/TestShell.cpp:
3113         (TestShell::initialize):
3114         (TestShell::setPerTilePaintingEnabled):
3115
3116 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3117
3118         [EFL][WK2] Provide implementation for PlatformWebView::windowFrame()
3119         https://bugs.webkit.org/show_bug.cgi?id=95995
3120
3121         Reviewed by Kenneth Rohde Christiansen.
3122
3123         Provide proper implementation for PlatformWebView::windowFrame()
3124         in EFL's WebKitTestRunner.
3125
3126         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3127         (WTR::PlatformWebView::windowFrame):
3128
3129 2012-09-06  Fady Samuel  <fsamuel@chromium.org>
3130
3131         Fix WTF.Lrint on 32-bit platforms
3132         https://bugs.webkit.org/show_bug.cgi?id=96003
3133
3134         Reviewed by Benjamin Poulain.
3135
3136         Fixed failing WTF.Lrint test on 32-bit platforms.
3137
3138         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3139         (TestWebKitAPI::TEST):
3140
3141 2012-09-06  Tommy Widenflycht  <tommyw@google.com>
3142
3143         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3144         https://bugs.webkit.org/show_bug.cgi?id=95839
3145
3146         Reviewed by Adam Barth.
3147
3148         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3149         up the task definitions a bit. There was no need to have them in the header file.
3150
3151         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3152         (RTCSessionDescriptionRequestSuccededTask):
3153         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3154         (RTCSessionDescriptionRequestFailedTask):
3155         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3156         (RTCVoidRequestTask):
3157         (RTCVoidRequestTask::RTCVoidRequestTask):
3158         (MockWebRTCPeerConnectionHandler::createOffer):
3159         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3160         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3161         (MockWebRTCPeerConnectionHandler::localDescription):
3162         (MockWebRTCPeerConnectionHandler::remoteDescription):
3163         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3164         (MockWebRTCPeerConnectionHandler):
3165
3166 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3167
3168         [Qt] Fix build on Mac OS X 10.6
3169         https://bugs.webkit.org/show_bug.cgi?id=95200
3170
3171         Reviewed by Tor Arne Vestbø.
3172
3173         The build on Mac OS X 10.6 is broken when using QuickTime. Enable it only for
3174         10.7 and newer.
3175
3176         * qmake/mkspecs/features/features.prf:
3177
3178 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3179
3180         [WKTR] addSelectionKey should be mapped to "Control" modifiers on other OSes than Mac
3181         https://bugs.webkit.org/show_bug.cgi?id=95973
3182
3183         Reviewed by Kenneth Rohde Christiansen.
3184
3185         Correctly map "addSelectionKey" to "Control" modifier
3186         in WKTR's EventSender on other OSes than Mac OS X,
3187         instead of mapping it to the "Meta" modifier.
3188
3189         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3190         (WTR::parseModifier):
3191
3192 2012-09-06  Balazs Kelemen  <kbalazs@webkit.org>
3193
3194         [nrwt] Harden against empty stdout/stderr after stopping a crashed/timed out driver
3195         https://bugs.webkit.org/show_bug.cgi?id=95710
3196
3197         Reviewed by Dirk Pranke.
3198
3199         The stdout / stderr output can be None so make sure
3200         we won't raise an exception in this case.
3201
3202         * Scripts/webkitpy/layout_tests/port/driver.py:
3203         (Driver.run_test):
3204
3205 2012-09-06  Christophe Dumez  <christophe.dumez@intel.com>
3206
3207         [EFL] Sanitize URLs in EWebLauncher / Minibrowser
3208         https://bugs.webkit.org/show_bug.cgi?id=95849
3209
3210         Reviewed by Kenneth Rohde Christiansen.
3211
3212         Sanitize URLs passed by the user as program
3213         argument or typed in the URL bar in order to
3214         be more tolerant.
3215
3216         * EWebLauncher/CMakeLists.txt:
3217         * EWebLauncher/main.c:
3218         (main):
3219         * EWebLauncher/url_bar.c:
3220         (_url_bar_url_get_with_protocol):
3221         (on_urlbar_key_down):
3222         * EWebLauncher/url_utils.c: Added.
3223         (has_scheme):
3224         (url_from_user_input): Add utility function to construct a
3225         URL from user input.
3226         * EWebLauncher/url_utils.h: Added.
3227         * MiniBrowser/efl/CMakeLists.txt:
3228         * MiniBrowser/efl/main.c:
3229         (main):
3230
3231 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3232
3233         [Qt] Various small Windows / MSVC build fixes
3234         https://bugs.webkit.org/show_bug.cgi?id=95934
3235
3236         Reviewed by Kenneth Rohde Christiansen.
3237
3238         setFocus takes a boolean as argument: Don't try to implicitly convert
3239         an enum to a boolean, MSVC doesn't like that. The intent here is to
3240         enable focus, so just pass true.
3241
3242         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3243         (WTR::PlatformWebView::focus):
3244
3245 2012-09-06  Simon Hausmann  <simon.hausmann@nokia.com>
3246
3247         [Qt] Fix build with ANGLE on platforms that provide EGL/GLESv2
3248         https://bugs.webkit.org/show_bug.cgi?id=95965
3249
3250         Reviewed by Tor Arne Vestbø.
3251
3252         Add ANGLE as a static library module to the Qt WebKit build system.
3253
3254         * qmake/mkspecs/features/default_post.prf:
3255         * qmake/mkspecs/modules/angle.prf: Added.
3256
3257 2012-09-06  Andras Becsi  <andras.becsi@nokia.com>
3258
3259         [WK2] Make [Qt]ViewportHandler cross platform
3260         https://bugs.webkit.org/show_bug.cgi?id=91257
3261
3262         Reviewed by Kenneth Rohde Christiansen.
3263
3264         Remove initial scale from viewport info item since it is
3265         set to -1 after applied thus it does not hold any valuable
3266         information.
3267
3268         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
3269
3270 2012-09-05  Tony Chang  <tony@chromium.org>
3271
3272         [chromium] Remove dependency on webkit_user_agent
3273         https://bugs.webkit.org/show_bug.cgi?id=95886
3274
3275         Reviewed by Adam Barth.
3276
3277         The code isn't used by DumpRenderTree.
3278
3279         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3280
3281 2012-09-05  Rick Byers  <rbyers@chromium.org>
3282
3283         Update chromium DumpRenderTree for new WebGestureEvent fields
3284         https://bugs.webkit.org/show_bug.cgi?id=95573
3285
3286         Reviewed by James Robinson.
3287
3288         Update EventSender to write gesture details into the appropriate
3289         type-specific WebGestureEvent fields.
3290         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3291         (EventSender::gestureEvent):
3292         (EventSender::gestureFlingStart):
3293
3294 2012-09-05  Dirk Pranke  <dpranke@chromium.org>
3295
3296         NRWT lies about the number of tests that it's skipping when used with --repeat-each
3297         https://bugs.webkit.org/show_bug.cgi?id=95789
3298
3299         Reviewed by Ojan Vafai.
3300
3301         Fix miscalculation in log message.
3302
3303         * Scripts/webkitpy/layout_tests/views/printing.py:
3304         (Printer.print_found):
3305
3306 2012-09-05  Kenichi Ishibashi  <bashi@chromium.org>
3307
3308         Unreviewed, rolling out r127612, r127660, and r127664.
3309         http://trac.webkit.org/changeset/127612
3310         http://trac.webkit.org/changeset/127660
3311         http://trac.webkit.org/changeset/127664
3312         https://bugs.webkit.org/show_bug.cgi?id=95920
3313
3314         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3315         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3316         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3317         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3318         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3319         (MockWebRTCPeerConnectionHandler::createOffer):
3320         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3321         (MockWebRTCPeerConnectionHandler):
3322         (SuccessCallbackTask):
3323         (FailureCallbackTask):
3324
3325 2012-09-05  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
3326
3327         Ignore-metrics includes scroll offsets.
3328         https://bugs.webkit.org/show_bug.cgi?id=95845
3329
3330         Reviewed by Dirk Pranke.
3331
3332         Strip scroll-offsets the same way scroll-height and scroll-width is stripped.
3333
3334         * Scripts/old-run-webkit-tests:
3335         (stripMetrics):
3336         * Scripts/webkitpy/layout_tests/port/driver.py:
3337         (DriverOutput):
3338
3339 2012-09-05  Zan Dobersek  <zandobersek@gmail.com>
3340
3341         Unreviewed test fix.
3342
3343         Including a plugin source file into the build that was added in r127595.
3344
3345         * GNUmakefile.am:
3346
3347 2012-09-05  Tommy Widenflycht  <tommyw@google.com>
3348
3349         MediaStream API: Add the local and remote description functionality to RTCPeerConnection
3350         https://bugs.webkit.org/show_bug.cgi?id=95839
3351
3352         Reviewed by Adam Barth.
3353
3354         In addition to adding the new methods to MockWebRTCPeerConnectionHandler I cleaned
3355         up the task definitions a bit. There was no need to have them in the header file.
3356
3357         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3358         (RTCSessionDescriptionRequestSuccededTask):
3359         (RTCSessionDescriptionRequestSuccededTask::RTCSessionDescriptionRequestSuccededTask):
3360         (RTCSessionDescriptionRequestFailedTask):
3361         (RTCSessionDescriptionRequestFailedTask::RTCSessionDescriptionRequestFailedTask):
3362         (RTCVoidRequestTask):
3363         (RTCVoidRequestTask::RTCVoidRequestTask):
3364         (MockWebRTCPeerConnectionHandler::createOffer):
3365         (MockWebRTCPeerConnectionHandler::setLocalDescription):
3366         (MockWebRTCPeerConnectionHandler::setRemoteDescription):
3367         (MockWebRTCPeerConnectionHandler::localDescription):
3368         (MockWebRTCPeerConnectionHandler::remoteDescription):
3369         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3370         (MockWebRTCPeerConnectionHandler):
3371
3372 2012-09-05  Kangil Han  <kangil.han@samsung.com>
3373
3374         [EFL] Remove '+=' usage in String
3375         https://bugs.webkit.org/show_bug.cgi?id=95808
3376
3377         Reviewed by Benjamin Poulain.
3378
3379         Replaced use of String operator '+=' with StringBuilder.append*() in order to adopt efficient String concatenation.
3380
3381         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3382         (descriptionSuitableForTestResult):
3383
3384 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3385
3386         [EFL][WK2] Provide implementation for TestRunner::pathToLocalResource()
3387         https://bugs.webkit.org/show_bug.cgi?id=95842
3388
3389         Reviewed by Kenneth Rohde Christiansen.
3390
3391         Provide proper implementation for TestRunner::pathToLocalResource()
3392         in EFL WKTR, identical to the one for DumpRenderTree.
3393
3394         Map /tmp to ${DUMPRENDERTREE_TEMP} environment variable and
3395         /tmp/LayoutTests to ${LOCAL_RESOURCE_ROOT} so that local resources
3396         are found my WebKitTestRunner.
3397
3398         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
3399         (WTR::TestRunner::pathToLocalResource):
3400
3401 2012-09-05  Brady Eidson  <beidson@apple.com>
3402
3403         Frequent crashes in PluginView::scriptObject under runtimeObjectCustomGetOwnPropertySlot
3404         <rdar://problem/12142226> and https://bugs.webkit.org/show_bug.cgi?id=95026
3405
3406         Reviewed by Andy Estes.
3407
3408         Add a plug-in that always fails to initialize:
3409         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPNewFails.cpp: Added.
3410         (NPPNewFails):
3411         (NPPNewFails::NPPNewFails):
3412         (NPPNewFails::NPP_New):
3413
3414         Add it to all the project files:
3415         * DumpRenderTree/DumpRenderTree.gypi:
3416         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3417         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
3418         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3419         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3420
3421 2012-09-05  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3422
3423         [Qt] Fix makefile race condition between derived sources and target
3424
3425         r121966 removed too much of the old qmake logic, including the rule
3426         that ensured that qmake_all would not trigger dual runs of qmake --
3427         one of the derived sources -qmake-all rule, and one for making the
3428         derived sources.
3429
3430         We now follow a similar pattern as before, by introducing a custom
3431         target that explicitly depends on the derived sources' qmake-all before
3432         doing a manual run of make. That ensures a single qmake run for the derived
3433         sources.
3434
3435         https://bugs.webkit.org/show_bug.cgi?id=93847
3436
3437         Reviewed by Csaba Osztrogonác.
3438
3439         * qmake/mkspecs/features/functions.prf:
3440
3441 2012-09-05  Christophe Dumez  <christophe.dumez@intel.com>
3442
3443         WKTR doesn't implement dumpWillCacheResponse()
3444         https://bugs.webkit.org/show_bug.cgi?id=94607
3445
3446         Reviewed by Kenneth Rohde Christiansen.
3447
3448         Define shouldCacheResponse() callback in resource
3449         load client and provide implementation for
3450         dumpWillCacheResponse() in WebKitTestRunner.
3451
3452         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3453         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3454         (WTR::InjectedBundlePage::InjectedBundlePage):
3455         (WTR::InjectedBundlePage::shouldCacheResponse):
3456         (WTR):
3457         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
3458         (InjectedBundlePage):
3459         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3460         (WTR::TestRunner::TestRunner):
3461         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3462         (WTR::TestRunner::dumpWillCacheResponse):
3463         (WTR::TestRunner::shouldDumpWillCacheResponse):
3464         (TestRunner):
3465
3466 2012-09-05  Kaustubh Atrawalkar  <kaustubh@motorola.com>
3467
3468         [DRT] LTC:: Move printing related APIs from LayoutTestController to Internals
3469         https://bugs.webkit.org/show_bug.cgi?id=92735
3470
3471         Reviewed by Hajime Morita.
3472
3473         Move numberOfPages, pageProperty & pageSizeAndMarginsInPixels in Internals and remove duplicated code from DumprenderTree & WebkitTestRunner.
3474
3475         * DumpRenderTree/TestRunner.cpp:
3476         (TestRunner::staticFunctions):
3477         * DumpRenderTree/TestRunner.h:
3478         (TestRunner):
3479         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
3480         (TestRunner::addUserStyleSheet):
3481         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3482         (DRTTestRunner::DRTTestRunner):
3483         (DRTTestRunner::hasCustomPageSizeStyle):
3484         * DumpRenderTree/chromium/DRTTestRunner.h:
3485         (DRTTestRunner):
3486         * DumpRenderTree/efl/TestRunnerEfl.cpp:
3487         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
3488         * DumpRenderTree/mac/TestRunnerMac.mm:
3489         * DumpRenderTree/qt/TestRunnerQt.cpp:
3490         (TestRunner::evaluateScriptInIsolatedWorld):
3491         * DumpRenderTree/qt/TestRunnerQt.h:
3492         (TestRunner):
3493         * DumpRenderTree/win/TestRunnerWin.cpp:
3494         * DumpRenderTree/wx/TestRunnerWx.cpp:
3495         (TestRunner::abortModal):
3496         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3497         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3498         (WTR):
3499         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3500         (TestRunner):
3501
3502 2012-09-05  Simon Hausmann  <simon.hausmann@nokia.com>
3503
3504         [Qt] Automate the use of AllInOne files in the Qt build
3505         https://bugs.webkit.org/show_bug.cgi?id=95837
3506
3507         Reviewed by Tor Arne Vestbø.
3508
3509         New feature file that implements the all-in-one file automation by
3510         adding the requested all-in-one files to SOURCES and removing the files
3511         it includes from SOURCES.
3512
3513         * qmake/mkspecs/features/use_all_in_one_files.prf: Added.
3514
3515 2012-09-04  Tim Horton  <timothy_horton@apple.com>
3516
3517         Have NRWT log more output when crash logs are missing
3518         https://bugs.webkit.org/show_bug.cgi?id=95814
3519
3520         Reviewed by Dan Bernstein.
3521
3522         Log the stderr and stdout of the test, in order to provide slightly more
3523         context when the WebProcess times out while running tests.
3524
3525         * Scripts/webkitpy/layout_tests/port/driver.py:
3526         (Driver.run_test):
3527
3528 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3529
3530         [Chromium-Android] Include device serial number in ChromiumAndroidDriver log messages
3531         https://bugs.webkit.org/show_bug.cgi?id=95770
3532
3533         Reviewed by Adam Barth.
3534
3535         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3536         (ChromiumAndroidDriver.__init__):
3537         (ChromiumAndroidDriver._log_error): Added to replace original _log.error().
3538         (ChromiumAndroidDriver._log_debug): Added to replace original _log.debug().
3539         (ChromiumAndroidDriver._abort): Added to replace original raise AssertionError().
3540         (ChromiumAndroidDriver._push_executable):
3541         (ChromiumAndroidDriver._push_fonts):
3542         (ChromiumAndroidDriver._push_test_resources):
3543         (ChromiumAndroidDriver._run_adb_command):
3544         (ChromiumAndroidDriver._get_last_stacktrace):
3545         (ChromiumAndroidDriver._get_crash_log):
3546         (ChromiumAndroidDriver._start):
3547         (ChromiumAndroidDriver._start_once):
3548         (ChromiumAndroidDriver._start_once.deadlock_detector):
3549         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3550         (ChromiumAndroidDriverTest.test_get_crash_log):
3551
3552 2012-09-04  Satish Sampath  <satish@chromium.org>
3553
3554         Run git commands within the checkout directory
3555         https://bugs.webkit.org/show_bug.cgi?id=95742
3556
3557         Reviewed by Eric Seidel.
3558
3559         git commands run from scm/git.py are sometimes run with cwd set to the
3560         checkout_root and other times with whatever directory was the default cwd.
3561         Instead all these should run with the checkout root set as the cwd
3562         (except where we explicitly need a different path)
3563
3564         * Scripts/webkitpy/common/checkout/scm/git.py:
3565         (Git._run_git):
3566         (Git.find_checkout_root):
3567         (Git.discard_local_commits):
3568         (Git.local_commits):
3569         (Git.working_directory_is_clean):
3570         (Git.clean_working_directory):
3571         (Git.add_list):
3572         (Git.delete_list):
3573         (Git.exists):
3574         (Git._current_branch):
3575         (Git._changes_files_for_commit):
3576         (Git.revisions_changing_file):
3577         (Git.svn_revision):
3578         (Git._run_git_svn_find_rev):
3579         (Git.contents_at_revision):
3580         (Git.diff_for_file):
3581         (Git.show_head):
3582         (Git.committer_email_for_revision):
3583         (Git.apply_reverse_diff):
3584         (Git.revert_files):
3585         (Git.commit_with_message):
3586         (Git._commit_on_branch):
3587         (Git.svn_commit_log):
3588         (Git.last_svn_commit_log):
3589         (Git.svn_blame):
3590         (Git._branch_ref_exists):
3591         (Git.delete_branch):
3592         (Git.remote_merge_base):
3593         (Git.commit_locally_with_message):
3594         (Git.push_local_commits_to_server):
3595         (Git.commit_ids_from_commitish_arguments):
3596         (Git.commit_message_for_local_commit):
3597         (Git.files_changed_summary_for_commit):
3598
3599 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3600
3601         MediaStream API: Add the async createOffer functionality to RTCPeerConnection
3602         https://bugs.webkit.org/show_bug.cgi?id=95734
3603
3604         Reviewed by Adam Barth.
3605
3606         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
3607         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::SuccessCallbackTask):
3608         (MockWebRTCPeerConnectionHandler::SuccessCallbackTask::runIfValid):
3609         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::FailureCallbackTask):
3610         (MockWebRTCPeerConnectionHandler::FailureCallbackTask::runIfValid):
3611         (MockWebRTCPeerConnectionHandler::createOffer):
3612         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
3613         (MockWebRTCPeerConnectionHandler):
3614         (MockWebRTCPeerConnectionHandler::taskList):
3615         (SuccessCallbackTask):
3616         (FailureCallbackTask):
3617
3618 2012-09-04  Xianzhu Wang  <wangxianzhu@chromium.org>
3619
3620         [Chromium-Android] Output time and thread info in crash log
3621         https://bugs.webkit.org/show_bug.cgi?id=95768
3622
3623         Reviewed by Adam Barth.
3624
3625         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3626         (ChromiumAndroidDriver._get_logcat): Add '-v threadtime' to adb logcat command line to get time and thread info.
3627
3628 2012-09-04  Tommy Widenflycht  <tommyw@google.com>
3629
3630         MediaStream API: Change the MediaStreamTrackList track added/removed signaling
3631         https://bugs.webkit.org/show_bug.cgi?id=95721
3632
3633         Reviewed by Adam Barth.
3634
3635         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3636         (MockWebMediaStreamCenter::didAddMediaStreamTrack):
3637         (MockWebMediaStreamCenter::didRemoveMediaStreamTrack):
3638         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
3639         (MockWebMediaStreamCenter):
3640
3641 2012-09-04  Tony Chang  <tony@chromium.org>
3642
3643         Elide test names when running new-run-webkit-tests
3644         https://bugs.webkit.org/show_bug.cgi?id=95626
3645
3646         Reviewed by Dirk Pranke.
3647
3648         When the test name exceeds the number of terminal columns, it leaves
3649         text on the screen. Avoid this by eliding the test name when running
3650         tests. This is similar to what ninja does when compiling.
3651
3652         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
3653         (MeteredStream):
3654         (MeteredStream.number_of_columns): Helper method to get number of
3655         terminal columns. Won't work on Win32 python, but meh.
3656         * Scripts/webkitpy/layout_tests/views/printing.py:
3657         (Printer._test_status_line): New method for eliding the text. Doesn't use \u2026
3658         because stderr appears to be ascii only.
3659         (Printer.print_started_test): Route through _test_status_line.
3660         (Printer.print_finished_test): Route through _test_status_line.
3661         (Printer._print_test_trace): Route through _test_status_line.
3662         (Printer._print_baseline): Route through _test_status_line.
3663         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3664         (test_test_status_line): Test for _test_status_line.
3665
3666 2012-09-04  Martin Robinson  <mrobinson@igalia.com>
3667
3668         [GTK] Print API missing documentation when generating gtkdoc
3669         https://bugs.webkit.org/show_bug.cgi?id=95703
3670
3671         Reviewed by Carlos Garcia Campos.
3672
3673         Print out API missing documentation when generating gtkdoc. This makes it
3674         easier to fix documentation errors.
3675