7afbe313dadaf62d9b152e75785ed213cb999bf3
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2
3         clampTo(): do not convert the input to double when dealing with integers
4         https://bugs.webkit.org/show_bug.cgi?id=194263
5         <rdar://problem/47692312>
6
7         Reviewed by Darin Adler.
8
9         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
10         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
11         (TestWebKitAPI::testClampFloatingPointToInteger):
12         (TestWebKitAPI::testClampSameSignIntegers):
13         (TestWebKitAPI::testClampUnsignedToSigned):
14         (TestWebKitAPI::testClampSignedToUnsigned):
15
16 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
17
18         webkitpy: Respect --dedicated-simulators flag
19         https://bugs.webkit.org/show_bug.cgi?id=194416
20         <rdar://problem/47894722>
21
22         Reviewed by Lucas Forschler.
23
24         * Scripts/webkitpy/port/device_port.py:
25         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
26         available devices can be safely ignored.
27
28 2019-02-07  Keith Rollin  <krollin@apple.com>
29
30         Remove extra copy of 100x100-red.tga
31         https://bugs.webkit.org/show_bug.cgi?id=194371
32         <rdar://problem/47873465>
33
34         Reviewed by Said Abou-Hallawa.
35
36         In order to help it pass its tests, Bug 194190 added a second copy of
37         the file 100x100-red.tga. However, it turns out that this additional
38         file wasn't actually needed, and that that sole previous copy was
39         sufficient. At the same time, this second copy -- which was copied to
40         the same location in the build output as the first copy -- now caused
41         XCBuild to complain because there were two production rules for the
42         same output file. Address this by removing the newly-added extra copy.
43
44         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
45         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
46
47 2019-02-07  Alex Christensen  <achristensen@webkit.org>
48
49         Deprecate WKBundlePageSetDefersLoading
50         https://bugs.webkit.org/show_bug.cgi?id=191394
51
52         Reviewed by Dean Jackson.
53
54         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
55         (WTR::TestRunner::setDefersLoading):
56
57 2019-02-07  Zalan Bujtas  <zalan@apple.com>
58
59         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
60         https://bugs.webkit.org/show_bug.cgi?id=194391
61
62         Reviewed by Antti Koivisto.
63
64         * LayoutReloaded/misc/LFC-passing-tests.txt:
65
66 2019-02-06  Keith Rollin  <krollin@apple.com>
67
68         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
69         https://bugs.webkit.org/show_bug.cgi?id=193975
70         <rdar://problem/47643306>
71
72         Reviewed by Tim Horton.
73
74         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
75         the Info.plist file into the bundle. This step is not necessary as the
76         implicit "bundle up all the build products into a framework" build
77         phase does this already. Having the Copy Bundle Resources phase do
78         this causes a conflict under XCBuild, which objects to two build
79         phases producing the same file (Info.plist). Address this by removing
80         Info.plist from the Copy Bundle Resources phase.
81
82         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
83
84 2019-02-06  Keith Rollin  <krollin@apple.com>
85
86         Really enable the automatic checking and regenerations of .xcfilelists during builds
87         https://bugs.webkit.org/show_bug.cgi?id=194357
88         <rdar://problem/47861231>
89
90         Reviewed by Chris Dumez.
91
92         Bug 194124 was supposed to enable the automatic checking and
93         regenerating of .xcfilelist files during the build. While related
94         changes were included in that patch, the change to actually enable the
95         operation somehow was omitted. This patch actually enables the
96         operation. The check-xcfilelist.sh scripts now check
97         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
98         from the checking.
99
100         * DumpRenderTree/Scripts/check-xcfilelists.sh:
101         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
102
103 2019-02-06  David Kilzer  <ddkilzer@apple.com>
104
105         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
106         <https://webkit.org/b/194286>
107         <rdar://problem/47815558>
108
109         Reviewed by Alexey Proskuryakov.
110
111         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
112         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
113         WKRetainPtr<> to avoid leaking the WKDataRef.
114
115 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
116
117         Unreviewed, fix a typo
118
119         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
120
121 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
122
123         [GTK][WPE] force libpsl build to use ICU in jhbuild
124         https://bugs.webkit.org/show_bug.cgi?id=194288
125
126         Reviewed by Carlos Garcia Campos.
127
128         * gtk/jhbuild.modules:
129         Require ICU for libpsl build in jhbuild, like done in WPE.
130
131 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
132
133         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
134         https://bugs.webkit.org/show_bug.cgi?id=194209
135
136         Reviewed by Carlos Garcia Campos.
137
138         Enhance TestCookieManager to ensure this doesn't happen again.
139
140         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
141         (testCookieManagerPersistentStorage):
142         (beforeAll):
143
144 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
145
146         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
147         https://bugs.webkit.org/show_bug.cgi?id=194324
148
149         Reviewed by Andy Estes.
150
151         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
152         part of the name is already implicit, since this is in testing code in TestOptions.
153
154         * WebKitTestRunner/TestController.cpp:
155         (WTR::TestController::generateContextConfiguration const):
156         (WTR::updateTestOptionsFromTestHeader):
157         * WebKitTestRunner/TestOptions.h:
158         (WTR::TestOptions::hasSameInitializationOptions const):
159
160 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
161
162         [ews-build] Allow * as platform for builders and workers
163         https://bugs.webkit.org/show_bug.cgi?id=188533
164
165         Reviewed by Lucas Forschler.
166
167         * BuildSlaveSupport/ews-build/loadConfig.py:
168         (checkWorkersAndBuildersForConsistency):
169
170 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
171
172         [ews-build] Add few bots to config.json
173         https://bugs.webkit.org/show_bug.cgi?id=194304
174
175         Reviewed by Lucas Forschler.
176
177         * BuildSlaveSupport/ews-build/config.json:
178
179 2019-02-05  Keith Rollin  <krollin@apple.com>
180
181         Enable the automatic checking and regenerations of .xcfilelists during builds
182         https://bugs.webkit.org/show_bug.cgi?id=194124
183         <rdar://problem/47721277>
184
185         Reviewed by Tim Horton.
186
187         Bug 193790 add a facility for checking -- during build time -- that
188         any needed .xcfilelist files are up-to-date and for updating them if
189         they are not. This facility was initially opt-in by setting
190         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
191         the process seemed robust. Its now time to enable this facility and
192         make it opt-out. If there is a need to disable this facility, set and
193         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
194         running `make` or `build-webkit`, or before running Xcode from the
195         command line.
196
197         Additionally, remove the step that generates a list of source files
198         going into the UnifiedSources build step. It's only necessarily to
199         specify Sources.txt and SourcesCocoa.txt as inputs.
200
201         * Scripts/generate-xcfilelists:
202
203 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
204
205         [GTK][WPE] force libpsl build to use ICU in jhbuild
206         https://bugs.webkit.org/show_bug.cgi?id=194288
207
208         Reviewed by Philippe Normand.
209
210         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
211         This can cause build failures if libidn is detected but libunistring is not available.
212
213         Make sure that ICU is used for runtime and builtin PSL data.
214
215         * gtk/jhbuild.modules:
216         * wpe/jhbuild.modules:
217
218 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
219
220         [ews-app] Modified timestamp should be updated on updating data
221         https://bugs.webkit.org/show_bug.cgi?id=194295
222
223         Reviewed by Lucas Forschler.
224
225         * BuildSlaveSupport/ews-app/ews/models/build.py:
226         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
227         * BuildSlaveSupport/ews-app/ews/models/step.py:
228
229 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
230
231         Unreviewed, rolling out r240742.
232
233         Causes crashes on iOS simulator.
234
235         Reverted changeset:
236
237         "[iOS] Keyups for non-modifier keys identified as "Dead" when
238         not focused in a content-editable element"
239         https://bugs.webkit.org/show_bug.cgi?id=192824
240         https://trac.webkit.org/changeset/240742
241
242 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
243
244         run-webkit-tests emits message "...running None" when running tests
245         https://bugs.webkit.org/show_bug.cgi?id=194133
246         <rdar://problem/47724738>
247
248         Reviewed by Lucas Forschler.
249
250         * Scripts/webkitpy/xcode/device_type.py:
251         (DeviceType.__str__): Use both version mapping tables and use just the variant
252         name if no version name is available.
253         * Scripts/webkitpy/xcode/device_type_unittest.py:
254         (DeviceTypeTest):
255         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
256         an associated named.
257
258 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
259
260         [WPE] require python3-setuptools for meson build in jhbuild
261         https://bugs.webkit.org/show_bug.cgi?id=194287
262
263         Reviewed by Philippe Normand.
264
265         python3-setuptools is needed to build meson in jhbuild.
266         It is already required by the GTK port.
267
268         * wpe/install-dependencies:
269
270 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
271
272         [ews-app] Add method to save BuilderMapping to database
273         https://bugs.webkit.org/show_bug.cgi?id=194264
274
275         Reviewed by Lucas Forschler.
276
277         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
278         (BuilderMapping.__str__):
279         (BuilderMapping):
280         (BuilderMapping.save_mapping):
281         (BuilderMapping.update_mapping):
282         (BuilderMapping.get_existing_mapping):
283         (BuilderMapping.is_valid_mapping):
284
285 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
286
287         [ews-app] Add timestamp fields for BuilderMappings
288         https://bugs.webkit.org/show_bug.cgi?id=194266
289
290         Reviewed by Lucas Forschler.
291
292         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
293         (BuilderMapping):
294
295 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
296
297         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
298         https://bugs.webkit.org/show_bug.cgi?id=174816
299
300         Reviewed by Michael Catanzaro.
301
302         Add tests for webkit_uri_for_display().
303
304         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
305         (testURIForDisplayUnaffected):
306         (testURIForDisplayAffected):
307         (beforeAll):
308         (afterAll):
309         * TestWebKitAPI/glib/CMakeLists.txt:
310
311 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
312
313         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
314         https://bugs.webkit.org/show_bug.cgi?id=194158
315         <rdar://problem/47737268>
316
317         Rubber-stamped by Aakash Jain.
318
319         * Scripts/webkitpy/port/device_port.py:
320         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
321
322 2019-02-04  Said Abou-Hallawa  <said@apple.com>
323
324         [CG] Enable setAdditionalSupportedImageTypes for WK1
325         https://bugs.webkit.org/show_bug.cgi?id=194190
326
327         Reviewed by Tim Horton.
328
329         Add a test similar to the one under WebKit Cocoa but make it create a
330         WebView instead of a WKWebView.
331
332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
333         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
334         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
335         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
336         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
337         (TestWebKitAPI::runTest):
338         (TestWebKitAPI::TEST):
339
340 2019-02-04  Zalan Bujtas  <zalan@apple.com>
341
342         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
343         https://bugs.webkit.org/show_bug.cgi?id=194168
344
345         Reviewed by Simon Fraser.
346
347         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
348
349         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
350         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
351         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
352         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
353         (TEST):
354         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
355         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
356
357 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
358
359         REGRESSION (r237269): webkit-patch what-broke is broken 
360         https://bugs.webkit.org/show_bug.cgi?id=193025
361
362         Reviewed by Aakash Jain.
363
364         * Scripts/webkitpy/common/host.py:
365         (Host.buildbot):
366         (Host.bugzilla): Renamed to 'buildbot'.
367
368 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
369
370         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
371         https://bugs.webkit.org/show_bug.cgi?id=194207
372
373         Reviewed by Tim Horton.
374
375         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
376         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
377         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
378         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
379         start and delete forwards to remove the original attachment.
380
381         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
382         (TestWebKitAPI::TEST):
383
384 2019-02-04  Youenn Fablet  <youenn@apple.com>
385
386         Capture state should be managed consistently when doing process swapping
387         https://bugs.webkit.org/show_bug.cgi?id=194122
388         <rdar://problem/47609293>
389
390         Reviewed by Eric Carlson.
391
392         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
393         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
394         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
395         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
396         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
398         (WTR::TestRunner::isDoingMediaCapture const):
399         * WebKitTestRunner/InjectedBundle/TestRunner.h:
400         * WebKitTestRunner/TestController.cpp:
401         (WTR::TestController::isDoingMediaCapture const):
402         * WebKitTestRunner/TestController.h:
403         * WebKitTestRunner/TestInvocation.cpp:
404         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
405         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
406         (WTR::TestController::isDoingMediaCapture const):
407
408 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
409
410         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
411         https://bugs.webkit.org/show_bug.cgi?id=194142
412
413         Reviewed by Ross Kirsling.
414
415         There three 'separator' variables in TestController.cpp. Renamed
416         it 'pathSeparator', and unified them.
417
418         * WebKitTestRunner/TestController.cpp:
419         (WTR::TestController::generateContextConfiguration const):
420         (WTR::createTestURL):
421         (WTR::TestController::platformAdjustContext):
422
423 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
424
425         Make setNeedsLayout on the root more explicitly about triggering its side-effects
426         https://bugs.webkit.org/show_bug.cgi?id=194198
427
428         Reviewed by Antti Koivisto.
429
430         No need to set the banner heights on navigation now, since Page stores them.
431
432         * MiniBrowser/mac/WK2BrowserWindowController.m:
433         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
434
435 2019-02-03  John Wilander  <wilander@apple.com>
436
437         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
438         https://bugs.webkit.org/show_bug.cgi?id=194104
439         <rdar://problem/47649991>
440
441         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
442
443         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
444         (TestWebKitAPI::TEST):
445             Changed numeric types from unsigned short to uint32_t.
446
447 2019-02-02  David Kilzer  <ddkilzer@apple.com>
448
449         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
450         <https://webkit.org/b/194178>
451         <rdar://problem/47753473>
452
453         Reviewed by Alexey Proskuryakov.
454
455         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
456         (WTR::uninstallFakeHelvetica): Pass nullptr into
457         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
458
459 2019-02-02  Zalan Bujtas  <zalan@apple.com>
460
461         [LFC] Initialize ICB's style with fixed width/height.
462         https://bugs.webkit.org/show_bug.cgi?id=194188
463
464         Reviewed by Antti Koivisto.
465
466         * LayoutReloaded/misc/LFC-passing-tests.txt:
467
468 2019-02-02  Zalan Bujtas  <zalan@apple.com>
469
470         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
471         https://bugs.webkit.org/show_bug.cgi?id=194185
472
473         Reviewed by Antti Koivisto.
474
475         * LayoutReloaded/misc/LFC-passing-tests.txt:
476
477 2018-12-16  Darin Adler  <darin@apple.com>
478
479         Convert additional String::format clients to alternative approaches
480         https://bugs.webkit.org/show_bug.cgi?id=192746
481
482         Reviewed by Alexey Proskuryakov.
483
484         * WebKitTestRunner/TestController.cpp:
485         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
486         as an intermediate in code that ultimately constructs a WTF::String.
487         (WTR::userMediaOriginHash): Use makeString.
488         (WTR::TestController::didNavigateWithNavigationData): More of the same.
489         (WTR::TestController::didPerformClientRedirect): Ditto.
490         (WTR::TestController::didPerformServerRedirect): Ditto.
491         (WTR::TestController::didUpdateHistoryTitle): Ditto.
492
493 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
494
495         [ews-build] Add unit test to verify builder keys
496         https://bugs.webkit.org/show_bug.cgi?id=194152
497
498         Reviewed by Lucas Forschler.
499
500         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
501         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
502
503 2019-02-01  Zalan Bujtas  <zalan@apple.com>
504
505         [LFC] Expand tests coverage (12 new tests -> 787)
506
507         Unreviewed test gardening.
508
509         * LayoutReloaded/misc/LFC-passing-tests.txt:
510
511 2019-02-01  Zalan Bujtas  <zalan@apple.com>
512
513         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
514         https://bugs.webkit.org/show_bug.cgi?id=194163
515
516         Reviewed by Simon Fraser.
517
518         775
519
520         * LayoutReloaded/misc/LFC-passing-tests.txt:
521
522 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
523
524         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
525         https://bugs.webkit.org/show_bug.cgi?id=194140
526         <rdar://problem/47728098>
527
528         Reviewed by Tim Horton.
529
530         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
531         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
532         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
533
534         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
535         test to induce an IPC deadlock when presenting a modal alert during touch start.
536
537         * WebKitTestRunner/InjectedBundle/TestRunner.h:
538         * WebKitTestRunner/TestController.cpp:
539         (WTR::runJavaScriptAlert):
540
541         Add a client callback function for running JavaScript alerts.
542
543         (WTR::TestController::createOtherPage):
544         (WTR::TestController::generateContextConfiguration const):
545
546         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
547         the fix in this patch.
548
549         (WTR::TestController::createWebViewWithOptions):
550
551         Plumb TestOptions to generateContextConfiguration.
552
553         (WTR::TestController::resetPreferencesToConsistentValues):
554         (WTR::TestController::resetStateToConsistentValues):
555         (WTR::updateTestOptionsFromTestHeader):
556         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
557         (WTR::TestController::handleJavaScriptAlert):
558         * WebKitTestRunner/TestController.h:
559         * WebKitTestRunner/TestInvocation.cpp:
560         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
561         * WebKitTestRunner/TestOptions.h:
562         (WTR::TestOptions::hasSameInitializationOptions const):
563
564 2019-02-01  Chris Dumez  <cdumez@apple.com>
565
566         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
567         https://bugs.webkit.org/show_bug.cgi?id=193740
568         <rdar://problem/47527267>
569
570         Reviewed by Alex Christensen.
571
572         Add API test coverage.
573
574         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
575
576 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
577
578         [ews-app] Add display name field to BuilderMapping model
579         https://bugs.webkit.org/show_bug.cgi?id=194153
580
581         Reviewed by Lucas Forschler.
582
583         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
584         (BuilderMapping):
585
586 2019-02-01  Youenn Fablet  <youenn@apple.com>
587
588         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
589         https://bugs.webkit.org/show_bug.cgi?id=194155
590
591         Reviewed by Eric Carlson.
592
593         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
594         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
595         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
596
597 2019-02-01  Zalan Bujtas  <zalan@apple.com>
598
599         [LFC] Adjust replaced element's intrinsic ratio
600         https://bugs.webkit.org/show_bug.cgi?id=194154
601
602         Reviewed by Antti Koivisto.
603
604         761
605
606         * LayoutReloaded/misc/LFC-passing-tests.txt:
607
608 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
609
610         [WPE] Show test results in minibrowser
611         https://bugs.webkit.org/show_bug.cgi?id=194150
612
613         Reviewed by Žan Doberšek.
614
615         * Scripts/webkitpy/port/wpe.py:
616         (WPEPort.show_results_html_file):
617
618 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
619
620         [WPE] MiniBrowser: add ky bindings for back/forward navigation
621         https://bugs.webkit.org/show_bug.cgi?id=194151
622
623         Reviewed by Žan Doberšek.
624
625         ALT + <- go back
626         ALT + -> go forward
627
628         * MiniBrowser/wpe/main.cpp:
629         (main):
630
631 2019-02-01  Zalan Bujtas  <zalan@apple.com>
632
633         [LFC] Set intrinsic size on Layout::Replaced
634         https://bugs.webkit.org/show_bug.cgi?id=194139
635
636         Reviewed by Antti Koivisto.
637
638         744
639
640         * LayoutReloaded/misc/LFC-passing-tests.txt:
641
642 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
643
644         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
645         https://bugs.webkit.org/show_bug.cgi?id=194146
646
647         Reviewed by Xabier Rodriguez-Calvar.
648
649         It allows to open relative paths.
650
651         * MiniBrowser/wpe/main.cpp:
652         (main):
653
654 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
655
656         Update flakiness dashboard configuration after recent queue changes
657         https://bugs.webkit.org/show_bug.cgi?id=194127
658
659         Rubber-stamped by Aakash Jain.
660
661         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
662
663         * TestResultServer/static-dashboards/builders.jsonp:
664
665 2019-01-31  Youenn Fablet  <youenn@apple.com>
666
667         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
668         https://bugs.webkit.org/show_bug.cgi?id=194106
669         <rdar://problem/47676333>
670
671         Reviewed by Ryosuke Niwa.
672
673         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
674         (TestWebKitAPI::didFinishNavigation):
675         (TestWebKitAPI::TEST):
676         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
677
678 2019-01-31  Chris Dumez  <cdumez@apple.com>
679
680         Page zoom level is lost after a process swap or a crash
681         https://bugs.webkit.org/show_bug.cgi?id=194105
682         <rdar://problem/47610781>
683
684         Reviewed by Alex Christensen.
685
686         Add API test coverage.
687
688         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
689         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
690
691 2019-01-31  Alex Christensen  <achristensen@webkit.org>
692
693         Revert r238819 which is unneeded and caused a performance regression.
694         https://bugs.webkit.org/show_bug.cgi?id=192272
695         <rdar://problem/46664625>
696
697         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
698         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
699         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
700
701 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
702
703         Formalize WebKitAdditions mechanism of LoadOptimizer
704         https://bugs.webkit.org/show_bug.cgi?id=193886
705         <rdar://problem/47696809>
706
707         Reviewed by Brent Fulgham.
708
709         * MiniBrowser/MiniBrowser.entitlements:
710         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
711
712 2019-01-31  Zalan Bujtas  <zalan@apple.com>
713
714         [LFC] Margin before/after/start/end initial value is 0 and not auto.
715         https://bugs.webkit.org/show_bug.cgi?id=194090
716
717         Reviewed by Antti Koivisto.
718
719         * LayoutReloaded/misc/LFC-passing-tests.txt:
720
721 2019-01-31  Zalan Bujtas  <zalan@apple.com>
722
723         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
724         https://bugs.webkit.org/show_bug.cgi?id=194074
725
726         Reviewed by Antti Koivisto.
727
728         * LayoutReloaded/misc/LFC-passing-tests.txt:
729
730 2019-01-31  Zalan Bujtas  <zalan@apple.com>
731
732         [LFC][BFC] Add support for block level replaced box.
733         https://bugs.webkit.org/show_bug.cgi?id=194071
734
735         Reviewed by Antti Koivisto.
736
737         * LayoutReloaded/misc/LFC-passing-tests.txt:
738
739 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
740
741         Fix WebKitTestRunner's testPath with Windows full paths
742         https://bugs.webkit.org/show_bug.cgi?id=194012
743
744         Reviewed by Alex Christensen.
745
746         updateTestOptionsFromTestHeader failed to open test files because
747         testPath returned wrong file paths. It returned a path "/C:/..."
748         if a URL "file:///C:/..." was given.
749
750         * WebKitTestRunner/TestController.cpp:
751         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
752
753 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
754
755         [WPE] Bump font related dependencies to match the GTK+ port
756         https://bugs.webkit.org/show_bug.cgi?id=194017
757
758         Reviewed by Žan Doberšek.
759
760         * wpe/jhbuild.modules:
761         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
762         * wpe/patches/icudata-stdlibs.patch: Added.
763
764 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
765
766         Enable swipe tests on iOS
767         https://bugs.webkit.org/show_bug.cgi?id=194076
768
769         Reviewed by Geoffrey Garen.
770
771         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
772         it causes a debug assertion failure in runUIScript.
773
774         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
775         (WTR::UIScriptController::beginBackSwipe):
776         (WTR::UIScriptController::completeBackSwipe):
777
778 2019-01-30  Keith Rollin  <krollin@apple.com>
779
780         Use correct printf format specifier
781         https://bugs.webkit.org/show_bug.cgi?id=194062
782         <rdar://problem/47686167>
783
784         Reviewed by Alexey Proskuryakov.
785
786         LayoutTestSpellChecker.mm is trying to format a variable of type
787         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
788         actually an unsigned long long. Fix this by formatting with %llu.
789
790         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
791         (-[LayoutTestTextCheckingResult description]):
792
793 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
794
795         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
796         https://bugs.webkit.org/show_bug.cgi?id=193979
797
798         Reviewed by Wenson Hsieh.
799
800         Fix the test for iOS. Make the test work with iOS UA string.
801
802         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
803
804 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
805
806         Replace High Sierra LLINT CLoop bot due to hardware failure
807         https://bugs.webkit.org/show_bug.cgi?id=194066
808
809         Reviewed by Aakash Jain.
810
811         * BuildSlaveSupport/build.webkit.org-config/config.json:
812
813 2019-01-30  Keith Rollin  <krollin@apple.com>
814
815         [NSDragItem init] is unavailable
816         https://bugs.webkit.org/show_bug.cgi?id=194059
817         <rdar://problem/47685715>
818
819         Reviewed by Wenson Hsieh.
820
821         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
822         DumpRenderTree and TestWebKitAPI, which both try to create an
823         NSDragItem in a manner that invokes this method. Address this by using
824         -initWithPasteboardWriter instead.
825
826         Note that the parameter passed to initWithPasteboardWriter is likely
827         incorrect. In both cases, the object passed does not conform to
828         NSPasteboardWriting. However, with this fix, we're no worse off than
829         before, and can now perform builds with newer compilers and SDKs until
830         a real fix can be crafted. That work is tracked in
831         https://bugs.webkit.org/show_bug.cgi?id=194060
832
833         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
834         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
835         * TestWebKitAPI/mac/TestDraggingInfo.mm:
836         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
837
838 2019-01-30  Daniel Bates  <dabates@apple.com>
839
840         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
841         https://bugs.webkit.org/show_bug.cgi?id=192824
842         <rdar://problem/47100332>
843
844         Reviewed by Wenson Hsieh.
845
846         Fix a bug where the wrong usage code was used for F13 thru F24.
847
848         * WebKitTestRunner/ios/HIDEventGenerator.mm:
849         (keyCodeForDOMFunctionKey):
850
851 2019-01-30  Chris Dumez  <cdumez@apple.com>
852
853         Regression(PSON) Load hang can occur on history navigation
854         https://bugs.webkit.org/show_bug.cgi?id=194030
855         <rdar://problem/47656939>
856
857         Reviewed by Antti Koivisto.
858
859         Add API test coverage.
860
861         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
862
863 2019-01-30  Zalan Bujtas  <zalan@apple.com>
864
865         [LFC] Expand tests coverage.
866
867         Unreviewed test gardening.
868
869         * LayoutReloaded/misc/LFC-passing-tests.txt:
870
871 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
872
873         [Flatpak] Add openjpeg support
874         https://bugs.webkit.org/show_bug.cgi?id=194019
875
876         Reviewed by Michael Catanzaro.
877
878         * flatpak/org.webkit.CommonModules.yaml:
879
880 2019-01-30  Commit Queue  <commit-queue@webkit.org>
881
882         Unreviewed, rolling out r240708.
883         https://bugs.webkit.org/show_bug.cgi?id=194022
884
885         It broke WPE build (Requested by KaL on #webkit).
886
887         Reverted changeset:
888
889         "[WPE] Bump font related dependencies to match the GTK+ port"
890         https://bugs.webkit.org/show_bug.cgi?id=194017
891         https://trac.webkit.org/changeset/240708
892
893 2019-01-30  Zalan Bujtas  <zalan@apple.com>
894
895         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
896         https://bugs.webkit.org/show_bug.cgi?id=194001
897
898         Reviewed by Antti Koivisto.
899
900         * LayoutReloaded/misc/LFC-passing-tests.txt:
901
902 2019-01-30  Zalan Bujtas  <zalan@apple.com>
903
904         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
905         https://bugs.webkit.org/show_bug.cgi?id=194020
906
907         Reviewed by Antti Koivisto.
908
909         * LayoutReloaded/misc/LFC-passing-tests.txt:
910
911 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
912
913         AX: Support color well on iOS
914         https://bugs.webkit.org/show_bug.cgi?id=194010
915
916         Reviewed by Joanmarie Diggs.
917
918         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
919         (WTR::AccessibilityUIElement::stringAttributeValue):
920
921 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
922
923         [WPE] Bump font related dependencies to match the GTK+ port
924         https://bugs.webkit.org/show_bug.cgi?id=194017
925
926         Reviewed by Žan Doberšek.
927
928         * wpe/jhbuild.modules:
929         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
930         * wpe/patches/icudata-stdlibs.patch: Added.
931
932 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
933
934         [Mac] Update window scale API usage
935         https://bugs.webkit.org/show_bug.cgi?id=193991
936         rdar://problem/47614795
937
938         Reviewed by Tim Horton.
939
940         * DumpRenderTree/mac/DumpRenderTree.mm:
941         (changeWindowScaleIfNeeded):
942         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
943         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
944         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
945
946 2019-01-29  Chris Dumez  <cdumez@apple.com>
947
948         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
949         https://bugs.webkit.org/show_bug.cgi?id=193977
950         <rdar://problem/47643716>
951
952         Reviewed by Geoff Garen.
953
954         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
955         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
956         to the previous provisional committing *before* we make the last load. 
957
958         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
959
960 2019-01-29  Youenn Fablet  <youenn@apple.com>
961
962         Adopt new SPI to evaluate server certificate trust
963         https://bugs.webkit.org/show_bug.cgi?id=193355
964
965         Reviewed by Alex Christensen.
966
967         Add infrastructure to handle HTTPS server trust evaluation testing.
968
969         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
970         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
971         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
972         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
973         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
974         * WebKitTestRunner/InjectedBundle/TestRunner.h:
975         * WebKitTestRunner/TestController.cpp:
976         (WTR::TestController::resetPreferencesToConsistentValues):
977         (WTR::TestController::didReceiveAuthenticationChallenge):
978         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
979         * WebKitTestRunner/TestController.h:
980         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
981         * WebKitTestRunner/TestInvocation.cpp:
982         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
983         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
984         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
985
986 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
987
988         [ews-build] Add build step to print bot Configuration
989         https://bugs.webkit.org/show_bug.cgi?id=193887
990
991         Reviewed by Lucas Forschler.
992
993         * BuildSlaveSupport/ews-build/steps.py:
994         (PrintConfiguration): Build step to print configuration.
995         * BuildSlaveSupport/ews-build/factories.py:
996
997 2019-01-29  Chris Dumez  <cdumez@apple.com>
998
999         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
1000         https://bugs.webkit.org/show_bug.cgi?id=193967
1001         <rdar://problem/47635348>
1002
1003         Reviewed by Alex Christensen.
1004
1005         Add API test coverage.
1006
1007         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1008         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
1009
1010 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1011
1012         [ews-app] Handle incoming results data
1013         https://bugs.webkit.org/show_bug.cgi?id=193973
1014
1015         Reviewed by Lucas Forschler.
1016
1017         * BuildSlaveSupport/ews-app/ews/views/results.py:
1018
1019 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1020
1021         [ews-app] Make the results url generic
1022         https://bugs.webkit.org/show_bug.cgi?id=193928
1023
1024         Reviewed by Lucas Forschler.
1025
1026         * BuildSlaveSupport/ews-app/ews/urls.py:
1027
1028 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
1029
1030         [ews-build] Configure buildbot to send events to ews-app
1031         https://bugs.webkit.org/show_bug.cgi?id=193968
1032
1033         Reviewed by Lucas Forschler.
1034
1035         * BuildSlaveSupport/ews-build/events.py: Added.
1036         * BuildSlaveSupport/ews-build/master.cfg:
1037
1038 2019-01-29  Keith Rollin  <krollin@apple.com>
1039
1040         Add .xcfilelists to Run Script build phases
1041         https://bugs.webkit.org/show_bug.cgi?id=193792
1042         <rdar://problem/47201785>
1043
1044         Reviewed by Alex Christensen.
1045
1046         As part of supporting XCBuild, update the necessary Run Script build
1047         phases in their Xcode projects to refer to their associated
1048         .xcfilelist files.
1049
1050         Note that the addition of these files bumps the Xcode project version
1051         number to something that's Xcode 10 compatible. This change means that
1052         older versions of the Xcode IDE can't read these projects. Nor can it
1053         fully load workspaces that refer to these projects (the updated
1054         projects are shown as non-expandable placeholders). `xcodebuild` can
1055         still build these projects; it's just that the IDE can't open them.
1056
1057         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1058         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1059
1060 2019-01-29  John Wilander  <wilander@apple.com>
1061
1062         Add data abstraction and validation for Ad Click Attribution
1063         https://bugs.webkit.org/show_bug.cgi?id=193916
1064         <rdar://problem/47603481>
1065
1066         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
1067
1068         Ad click attribution has two steps. First, the storage of an ad
1069         campaign ID for a click that takes the user to a destination
1070         site. Second, a conversion on the destination site that can be
1071         attributed to the ad click.
1072
1073         This patch adds a class that represents a request for ad click
1074         attribution. Validation makes sure that the bits of entropy
1075         reported through this mechanism is limited.
1076
1077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1078         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
1079         (TestWebKitAPI::TEST):
1080
1081 2019-01-29  Chris Dumez  <cdumez@apple.com>
1082
1083         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
1084         https://bugs.webkit.org/show_bug.cgi?id=193932
1085         <rdar://problem/47598947>
1086
1087         Reviewed by Brady Eidson.
1088
1089         Add API test coverage.
1090
1091         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1092
1093 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1094
1095         Adding new passing LFC tests.
1096
1097         Unreviewed test gardening.
1098
1099         * LayoutReloaded/misc/LFC-passing-tests.txt:
1100
1101 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1102
1103         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
1104         https://bugs.webkit.org/show_bug.cgi?id=193964
1105
1106         Reviewed by Antti Koivisto.
1107
1108         * LayoutReloaded/misc/LFC-passing-tests.txt:
1109
1110 2019-01-29  Zalan Bujtas  <zalan@apple.com>
1111
1112         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
1113         https://bugs.webkit.org/show_bug.cgi?id=193954
1114
1115         Reviewed by Antti Koivisto.
1116
1117         * LayoutReloaded/misc/LFC-passing-tests.txt:
1118
1119 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
1120
1121         WebDriver: add support for running subtests
1122         https://bugs.webkit.org/show_bug.cgi?id=193904
1123
1124         Reviewed by Michael Catanzaro.
1125
1126         pytest already supports it by passing test.py::subtest, so we can do the same.
1127
1128         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
1129         (get_item_name): Made this global.
1130         (CollectRecorder.__init__): Receive the parameter to ignore.
1131         (CollectRecorder.pytest_collectreport): Collect also the subtests.
1132         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
1133         (collect): Add parameter to ignore.
1134         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
1135         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
1136         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
1137         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
1138         (WebDriverTestRunnerSelenium.run): Ditto.
1139         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
1140         (WebDriverTestRunnerW3C.collect_tests): Ditto.
1141         (WebDriverTestRunnerW3C.run): Ditto.
1142
1143 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
1144
1145         User agent string override for navigator.userAgent should be site specific quirks
1146         https://bugs.webkit.org/show_bug.cgi?id=193950
1147
1148         Reviewed by Brent Fulgham.
1149
1150         Updated per the _WKWebsitePolicies rename.
1151
1152         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1153         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1154
1155 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
1156
1157         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
1158         https://bugs.webkit.org/show_bug.cgi?id=193941
1159
1160         Reviewed by Alex Christensen.
1161
1162         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
1163         * TestWebKitAPI/Tests/WTF/Condition.cpp:
1164         * TestWebKitAPI/Tests/WTF/Lock.cpp:
1165         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1166         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
1167         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1168         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
1169         * TestWebKitAPI/Tests/WTF/Time.cpp:
1170         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
1171         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
1172         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
1173         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1174
1175 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
1176
1177         Unreviewed, reorder my emails to fix autocomplete in bugzilla
1178
1179         * Scripts/webkitpy/common/config/contributors.json:
1180
1181 2019-01-28  Andy Estes  <aestes@apple.com>
1182
1183         [watchOS] Enable Parental Controls content filtering
1184         https://bugs.webkit.org/show_bug.cgi?id=193939
1185         <rdar://problem/46641912>
1186
1187         Reviewed by Ryosuke Niwa.
1188
1189         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1190
1191 2019-01-28  David Kilzer  <ddkilzer@apple.com>
1192
1193         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
1194         <https://webkit.org/b/193884>
1195
1196         Reviewed by Jiewen Tan.
1197
1198         * Scripts/webkitpy/style/checkers/cpp.py:
1199         (check_language): Add LocalAuthentication to
1200         `frameworks_with_soft_links`.
1201
1202 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
1203
1204         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
1205         https://bugs.webkit.org/show_bug.cgi?id=193891
1206
1207         Reviewed by Ross Kirsling.
1208
1209         There were three problems in window sizes of WebView and the host window.
1210         1. The sizes of pixel image output were incorrect.
1211         2. The host window is going to appear after window.resize was invoked.
1212         3. window.resize resized only the host window, not WebView.
1213
1214         This change solves them with a following approach.
1215         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
1216         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
1217            as well as DumpRenderTree in order to match the client area and the window area.
1218         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
1219         d. PlatformWebView::setWindowFrame changes both window sizes.
1220         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
1221
1222         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1223         (WTR::PlatformWebView::PlatformWebView): Create the host window
1224         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
1225         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
1226         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
1227
1228 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1229
1230         [ews-app] Add method to save Step data to database
1231         https://bugs.webkit.org/show_bug.cgi?id=193890
1232
1233         Reviewed by Lucas Forschler.
1234
1235         * BuildSlaveSupport/ews-app/ews/models/step.py:
1236         (Step.save_step): Method to save step data.
1237         (Step.update_step): Method to update step data.
1238         (Step.get_existing_step): Method to fetch existing step from database.
1239         (Step.is_valid_result): Method to validate valid step result.
1240
1241 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1242
1243         [ews-app] Add method to save Build data to database
1244         https://bugs.webkit.org/show_bug.cgi?id=193735
1245
1246         Reviewed by Lucas Forschler.
1247
1248         * BuildSlaveSupport/ews-app/ews/models/build.py:
1249         (Build.save_build): Method to save build information to database.
1250         (Build.get_existing_build): Method to fetch existing build from database.
1251         (Build.is_valid_result): Method to validate build result.
1252         * BuildSlaveSupport/ews-app/ews/common/util.py:
1253         (is_valid_int_id): Method to validate valid id.
1254
1255 2019-01-28  Chris Dumez  <cdumez@apple.com>
1256
1257         Regression(PSON) Crash under WebPageProxy::didStartProgress()
1258         https://bugs.webkit.org/show_bug.cgi?id=193915
1259         <rdar://problem/47560907>
1260
1261         Reviewed by Alex Christensen.
1262
1263         Add API test coverage.
1264
1265         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1266
1267 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1268
1269         [ews-app] Rename id variables
1270         https://bugs.webkit.org/show_bug.cgi?id=193883
1271
1272         Reviewed by Lucas Forschler.
1273
1274         * BuildSlaveSupport/ews-app/ews/models/build.py:
1275         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1276         * BuildSlaveSupport/ews-app/ews/models/step.py:
1277         * BuildSlaveSupport/ews-app/ews/urls.py:
1278         * BuildSlaveSupport/ews-app/ews/views/patch.py:
1279         * BuildSlaveSupport/ews-app/ews/views/results.py:
1280         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1281
1282 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
1283
1284         [ews-app] Allow certain fields to be empty
1285         https://bugs.webkit.org/show_bug.cgi?id=193892
1286
1287         Reviewed by Lucas Forschler.
1288
1289         * BuildSlaveSupport/ews-app/ews/models/build.py:
1290         * BuildSlaveSupport/ews-app/ews/models/step.py:
1291
1292 2019-01-28  Rob Buis  <rbuis@igalia.com>
1293
1294         Update MIME type parser
1295         https://bugs.webkit.org/show_bug.cgi?id=180526
1296
1297         Reviewed by Frédéric Wang.
1298
1299         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1300         (TestWebKitAPI::TEST):
1301
1302 2019-01-28  Zalan Bujtas  <zalan@apple.com>
1303
1304         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
1305         https://bugs.webkit.org/show_bug.cgi?id=193896
1306
1307         Reviewed by Antti Koivisto.
1308
1309         * LayoutReloaded/misc/LFC-passing-tests.txt:
1310
1311 2018-12-15  Darin Adler  <darin@apple.com>
1312
1313         Replace many uses of String::format with more type-safe alternatives
1314         https://bugs.webkit.org/show_bug.cgi?id=192742
1315
1316         Reviewed by Mark Lam.
1317
1318         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1319         (WTR::cacheTestRunnerCallback): Use makeString.
1320         * WebKitTestRunner/TestController.cpp:
1321         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
1322         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
1323
1324 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
1325
1326         Use a load optimizer for some sites
1327         https://bugs.webkit.org/show_bug.cgi?id=193881
1328         <rdar://problem/46325455>
1329
1330         Reviewed by Brent Fulgham.
1331
1332         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1333         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
1334
1335 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
1336
1337         AX: Introduce a static accessibility tree
1338         https://bugs.webkit.org/show_bug.cgi?id=193348
1339         <rdar://problem/47203295>
1340
1341         Reviewed by Ryosuke Niwa.
1342
1343         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1344
1345 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1346
1347         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
1348         https://bugs.webkit.org/show_bug.cgi?id=193867
1349
1350         Reviewed by Antti Koivisto.
1351
1352         * LayoutReloaded/misc/LFC-passing-tests.txt:
1353
1354 2019-01-26  Zalan Bujtas  <zalan@apple.com>
1355
1356         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
1357         https://bugs.webkit.org/show_bug.cgi?id=193865
1358
1359         Reviewed by Antti Koivisto.
1360
1361         * LayoutReloaded/misc/LFC-passing-tests.txt:
1362
1363 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1364
1365         Need a mechanism to override navigator.userAgent
1366         https://bugs.webkit.org/show_bug.cgi?id=193762
1367         <rdar://problem/47504939>
1368
1369         Reviewed by Brent Fulgham.
1370
1371         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
1372
1373         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1374         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
1375         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
1376
1377 2019-01-25  Dean Jackson  <dino@apple.com>
1378
1379         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
1380         https://bugs.webkit.org/show_bug.cgi?id=193831
1381         <rdar://problem/47399263>
1382
1383         Reviewed by Chris Dumez.
1384
1385         Two new tests that exercise cross-origin and same-origin System
1386         Previews.
1387
1388         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1389
1390 2019-01-25  Keith Rollin  <krollin@apple.com>
1391
1392         Update Xcode projects with "Check .xcfilelists" build phase
1393         https://bugs.webkit.org/show_bug.cgi?id=193790
1394         <rdar://problem/47201374>
1395
1396         Reviewed by Alex Christensen.
1397
1398         Support for XCBuild includes specifying inputs and outputs to various
1399         Run Script build phases. These inputs and outputs are specified as
1400         .xcfilelist files. Once created, these .xcfilelist files need to be
1401         kept up-to-date. In order to check that they are up-to-date or not,
1402         add an Xcode build step that invokes an external script that performs
1403         the checking. If the .xcfilelists are found to be out-of-date, update
1404         them, halt the build, and instruct the developer to restart the build
1405         with up-to-date files.
1406
1407         At this time, the checking and regenerating is performed only if the
1408         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
1409         who want to use this facility can set this variable and test out the
1410         checking/regenerating. Once it seems like there are no egregious
1411         issues that upset a developer's workflow, we'll unconditionally enable
1412         this facility.
1413
1414         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1415         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
1416         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
1417         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1418
1419 2019-01-25  Keith Rollin  <krollin@apple.com>
1420
1421         Update Xcode projects with "Apply Configuration to XCFileLists" build target
1422         https://bugs.webkit.org/show_bug.cgi?id=193781
1423         <rdar://problem/47201153>
1424
1425         Reviewed by Alex Christensen.
1426
1427         Part of generating the .xcfilelists used as part of adopting XCBuild
1428         includes running `make DerivedSources.make` from a standalone script.
1429         It’s important for this invocation to have the same environment as
1430         when the actual build invokes `make DerivedSources.make`. If the
1431         environments are different, then the two invocations will provide
1432         different results. In order to get the same environment in the
1433         standalone script, have the script launch xcodebuild targeting the
1434         "Apply Configuration to XCFileLists" build target, which will then
1435         re-invoke our standalone script. The script is now running again, this
1436         time in an environment with all workspace, project, target, xcconfig
1437         and other environment variables established.
1438
1439         The "Apply Configuration to XCFileLists" build target accomplishes
1440         this task via a small embedded shell script that consists only of:
1441
1442             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
1443
1444         The process that invokes "Apply Configuration to XCFileLists" first
1445         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
1446         evaluated and exports it into the shell environment. When xcodebuild
1447         is invoked, it inherits the value of this variable and can `eval` the
1448         contents of that variable. Our external standalone script can then set
1449         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
1450         of command-line parameters needed to restart itself in the appropriate
1451         state.
1452
1453         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1454         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1455
1456 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1457
1458         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
1459         https://bugs.webkit.org/show_bug.cgi?id=193802
1460         <rdar://problem/46010580>
1461
1462         Reviewed by Andy Estes.
1463
1464         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1465         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
1466         (TEST):
1467
1468 2019-01-25  Daniel Bates  <dabates@apple.com>
1469
1470         [iOS] uiController.keyDown() does not translate Control modified key
1471         https://bugs.webkit.org/show_bug.cgi?id=192898
1472
1473         Reviewed by Wenson Hsieh.
1474
1475         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
1476         key translation, as applicable. Among other cases, key translation occurs when performing
1477         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
1478         also makes the behavior of uiController.keyDown() more closely match the behavior of a
1479         human pressing down and releasing key(s) using a hardware keyboard.
1480
1481         * WebKitTestRunner/ios/HIDEventGenerator.h:
1482         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1483         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
1484
1485         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
1486         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
1487         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1488         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1489         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
1490         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
1491         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
1492         (-[HIDEventGenerator longPress:completionBlock:]):
1493         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
1494         Update code for above renaming.
1495
1496         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
1497         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
1498
1499         (-[HIDEventGenerator keyDown:]): Added.
1500         (-[HIDEventGenerator keyUp:]): Added.
1501         (-[HIDEventGenerator keyPress:completionBlock:]):
1502         (-[HIDEventGenerator eventDispatchThreadEntry:]):
1503         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
1504         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1505         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
1506         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
1507         (WTR::parseModifier): Deleted.
1508
1509 2019-01-25  Keith Rollin  <krollin@apple.com>
1510
1511         Complete the implementation of generate-xcfilelists
1512         https://bugs.webkit.org/show_bug.cgi?id=193782
1513
1514         Reviewed by Alex Christensen.
1515
1516         A preliminary version of generate-xcfilelists was added in r238008.
1517         This patch updates that script in order to:
1518
1519         - Support checking of .xcfilelists
1520         - Perform better execution of `make DerivedSources.make` by
1521           relaunching generate-xcfilelists under xcodebuild
1522         - Support incremental generation and checking of .xcfilelists
1523         - Support supplementary .xcfilelists files from WebKitAdditions
1524         - Support being wrapped by parallel version of generate-xcfilelists in
1525           Internal that adds support for (re)generating WebKit projects in
1526           that repo.
1527         - Support builds that have been performed in WebKitBuild as well as
1528           ~/Library/Developer/code/DerivedData
1529         - Increase robustness and debugging facilities.
1530
1531         * Scripts/generate-xcfilelists:
1532
1533 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1534
1535         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1536         https://bugs.webkit.org/show_bug.cgi?id=193297
1537         <rdar://problem/47158841>
1538
1539         Unreviewed test case fix.
1540
1541         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
1542         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
1543
1544         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1545         (TEST):
1546
1547 2019-01-25  Keith Rollin  <krollin@apple.com>
1548
1549         Update existing .xcfilelists
1550         https://bugs.webkit.org/show_bug.cgi?id=193791
1551         <rdar://problem/47201706>
1552
1553         Reviewed by Alex Christensen.
1554
1555         Many .xcfilelist files were added in r238824 in order to support
1556         XCBuild. Update these with recent changes to the set of build files
1557         and with the current generate-xcfilelist script.
1558
1559         * DumpRenderTree/DerivedSources-input.xcfilelist:
1560         * DumpRenderTree/DerivedSources-output.xcfilelist:
1561         * WebKitTestRunner/DerivedSources-input.xcfilelist:
1562         * WebKitTestRunner/DerivedSources-output.xcfilelist:
1563
1564 2019-01-25  Keith Rollin  <krollin@apple.com>
1565
1566         Fix missing dependencies in extract-dependencies-from-makefile
1567         https://bugs.webkit.org/show_bug.cgi?id=193783
1568         <rdar://problem/47201571>
1569
1570         Reviewed by Alex Christensen.
1571
1572         The extract-dependencies-from-makefile script generates .xcfilelists
1573         for XCBuild by invoking a makefile in --debug mode, parsing the
1574         dependency information in the output, and extracting information
1575         regarding targets and dependents. However, the way `make` emits this
1576         dependency information is not rigorous, and so we need to determine
1577         what lines to look for and parse by trial and error. This approach
1578         didn't coriginally atch all the information we needed to collect, so
1579         update the script to look for the additional lines we now know to look
1580         for.
1581
1582         * Scripts/extract-dependencies-from-makefile:
1583         (Parser):
1584         (Parser.addTarget):
1585         (Parser.addPrereq):
1586         (Parser.doParse):
1587
1588 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
1589
1590         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1591         https://bugs.webkit.org/show_bug.cgi?id=193297
1592         <rdar://problem/47158841>
1593
1594         Reviewed by Alex Christensen.
1595
1596         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
1597             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
1598         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1599         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1600         activating the message used to trigger the callback when it is set.
1601
1602 2019-01-25  Alex Christensen  <achristensen@webkit.org>
1603
1604         WKWebView.goBack should reload if there is a safe browsing warning
1605         https://bugs.webkit.org/show_bug.cgi?id=193805
1606         <rdar://problem/46908216>
1607
1608         Reviewed by Geoff Garen.
1609
1610         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1611         (+[Simple3LookupContext sharedLookupContext]):
1612         (-[Simple3LookupContext lookUpURL:completionHandler:]):
1613         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
1614         (TEST):
1615
1616 2019-01-25  Chris Dumez  <cdumez@apple.com>
1617
1618         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
1619         https://bugs.webkit.org/show_bug.cgi?id=193788
1620         <rdar://problem/47531231>
1621
1622         Reviewed by Alex Christensen.
1623
1624         Add API test coverage.
1625
1626         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1627         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1628
1629 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
1630
1631         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
1632         https://bugs.webkit.org/show_bug.cgi?id=193771
1633
1634         Unreviewed infrastructure fix.
1635
1636         * Scripts/webkitpy/port/darwin.py:
1637         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
1638
1639 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1640
1641         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
1642
1643 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
1644
1645         Add contributors.json entries for Ling Ho and for a new bot watchers group.
1646
1647         * Scripts/webkitpy/common/config/contributors.json:
1648
1649 2019-01-25  Chris Dumez  <cdumez@apple.com>
1650
1651         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
1652         https://bugs.webkit.org/show_bug.cgi?id=193779
1653         <rdar://problem/46170903>
1654
1655         Reviewed by Antti Koivisto.
1656
1657         Add API test that quickly navigates forward to a previous process without waiting for it to
1658         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
1659         the process' previous page when reconnecting the it for the forward navigation.
1660
1661         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1662
1663 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1664
1665         Need a way for JavaScript (or bundle) code to participate in undo
1666         https://bugs.webkit.org/show_bug.cgi?id=190009
1667         <rdar://problem/44807048>
1668
1669         Reviewed by Ryosuke Niwa.
1670
1671         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
1672         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
1673
1674         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1675         (WTR::UIScriptController::lastUndoLabel const):
1676         (WTR::UIScriptController::firstRedoLabel const):
1677         (WTR::UIScriptController::platformUndoManager const):
1678         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1679         (WTR::UIScriptController::lastUndoLabel const):
1680         (WTR::UIScriptController::firstRedoLabel const):
1681         (WTR::UIScriptController::platformUndoManager const):
1682         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1683         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1684         (WTR::UIScriptController::lastUndoLabel const):
1685         (WTR::UIScriptController::firstRedoLabel const):
1686         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1687         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1688         (WTR::UIScriptController::lastUndoLabel const):
1689         (WTR::UIScriptController::firstRedoLabel const):
1690         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1691         (WTR::UIScriptController::platformUndoManager const):
1692         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1693         (WTR::UIScriptController::platformUndoManager const):
1694
1695 2019-01-25  Zalan Bujtas  <zalan@apple.com>
1696
1697         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
1698         https://bugs.webkit.org/show_bug.cgi?id=193824
1699
1700         Reviewed by Antti Koivisto.
1701
1702         * LayoutReloaded/misc/LFC-passing-tests.txt:
1703
1704 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
1705
1706         Update macOS JSC bot configurations
1707         https://bugs.webkit.org/show_bug.cgi?id=193739
1708
1709         Reviewed by Alexey Proskuryakov.
1710
1711         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
1712         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1713         (BubbleQueueServer): Move JSC EWS to Mojave section.
1714         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1715         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
1716         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
1717
1718 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
1719
1720         [Win][WebKitTestRunner] Implement EventSenderProxy
1721         https://bugs.webkit.org/show_bug.cgi?id=193755
1722
1723         Reviewed by Don Olmstead.
1724
1725         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
1726         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
1727         (WTR::EventSenderProxy::dispatchMessage):
1728         (WTR::EventSenderProxy::EventSenderProxy):
1729         (WTR::EventSenderProxy::mouseDown):
1730         (WTR::EventSenderProxy::mouseUp):
1731         (WTR::EventSenderProxy::mouseMoveTo):
1732         (WTR::EventSenderProxy::mouseScrollBy):
1733         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
1734
1735 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1736
1737         Unreviewed fix for API test failure after r240437.
1738
1739         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
1740
1741         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
1742
1743 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1744
1745         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
1746         https://bugs.webkit.org/show_bug.cgi?id=193787
1747         <rdar://problem/47497634>
1748
1749         Reviewed by Alexey Proskuryakov.
1750
1751         * Scripts/webkitdirs.pm:
1752         (iosSimulatorApplicationsPath): Pick from available runtime directories.
1753
1754 2019-01-24  Truitt Savell  <tsavell@apple.com>
1755
1756         Unreviewed, rolling out r240446.
1757
1758         Casued 5 API failures
1759
1760         Reverted changeset:
1761
1762         "Activate the WebResourceLoadStatisticsStore in the
1763         NetworkProcess and deactivate it in the UIProcess."
1764         https://bugs.webkit.org/show_bug.cgi?id=193297
1765         https://trac.webkit.org/changeset/240446
1766
1767 2019-01-24  Zalan Bujtas  <zalan@apple.com>
1768
1769         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
1770         https://bugs.webkit.org/show_bug.cgi?id=193741
1771         <rdar://problem/47135030>
1772
1773         Reviewed by Antti Koivisto and Simon Fraser.
1774
1775         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1776         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1777         (TestWebKitAPI::TEST):
1778
1779 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
1780
1781         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
1782         https://bugs.webkit.org/show_bug.cgi?id=193297
1783         <rdar://problem/47158841>
1784
1785         Reviewed by Alex Christensen.
1786
1787         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1788         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
1789         activating the message used to trigger the callback when it is set.
1790
1791 2019-01-24  John Wilander  <wilander@apple.com>
1792
1793         Add Ad Click Attribution as an internal/experimental feature
1794         https://bugs.webkit.org/show_bug.cgi?id=193685
1795         <rdar://problem/47450399>
1796
1797         Reviewed by Brent Fulgham.
1798
1799         Added test option adClickAttributionEnabled.
1800
1801         * DumpRenderTree/TestOptions.cpp:
1802         (TestOptions::TestOptions):
1803         * DumpRenderTree/TestOptions.h:
1804         * DumpRenderTree/mac/DumpRenderTree.mm:
1805         (setWebPreferencesForTestOptions):
1806
1807 2019-01-24  Antti Koivisto  <antti@apple.com>
1808
1809         [PSON] Flash on back navigation on Mac
1810         https://bugs.webkit.org/show_bug.cgi?id=193716
1811         <rdar://problem/47148458>
1812
1813         Reviewed by Chris Dumez.
1814
1815         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1816
1817         Closing of the previous page is delayed so waiting for didFinishNavigation is
1818         not sufficient to guarantee we have received all the messages. Wait for them.
1819
1820 2019-01-24  Chris Dumez  <cdumez@apple.com>
1821
1822         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
1823         https://bugs.webkit.org/show_bug.cgi?id=193761
1824         <rdar://problem/47456405>
1825
1826         Reviewed by Alex Christensen.
1827
1828         Add API test coverage.
1829
1830         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1831
1832 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
1833
1834         webkitpy: Missing PID in crashlog name should not be fatal
1835         https://bugs.webkit.org/show_bug.cgi?id=193771
1836
1837         If we can't determine the PID of a crashlog, just ignore the crashlog instead
1838         of raising an exception.
1839
1840         Reviewed by Lucas Forschler.
1841
1842         * Scripts/webkitpy/port/darwin.py:
1843         (DarwinPort._merge_crash_logs):
1844
1845 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1846
1847         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
1848         https://bugs.webkit.org/show_bug.cgi?id=193746
1849
1850         Reviewed by Youenn Fablet.
1851
1852         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
1853         so we'd best just not call it.
1854
1855         * Scripts/webkitpy/w3c/test_exporter.py:
1856         (WebPlatformTestExporter.create_branch_with_patch):
1857
1858 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
1859
1860         Move FileSystem to WTF
1861         https://bugs.webkit.org/show_bug.cgi?id=193602
1862
1863         Reviewed by Yusuke Suzuki.
1864
1865         * DumpRenderTree/win/DumpRenderTree.cpp:
1866         * TestWebKitAPI/CMakeLists.txt:
1867         * TestWebKitAPI/PlatformGTK.cmake:
1868         * TestWebKitAPI/PlatformJSCOnly.cmake:
1869         * TestWebKitAPI/PlatformPlayStation.cmake:
1870         * TestWebKitAPI/PlatformWPE.cmake:
1871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1872         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
1873         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
1874         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1875         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
1876         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
1877         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
1878         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1879         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
1880         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1881
1882 2019-01-24  Philippe Normand  <pnormand@igalia.com>
1883
1884         [WPE] Remove hard dependency on subprocess32 for the API tests
1885
1886         Rubber-stamped by Carlos Garcia Campos.
1887
1888         * glib/api_test_runner.py:
1889         (TestRunner._run_test_qt): Lazily import subprocess32 and check
1890         its presence only when running WPEQt tests.
1891
1892 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1893
1894         [GLIB] Expose JavaScriptCore options in GLib public API
1895         https://bugs.webkit.org/show_bug.cgi?id=188742
1896
1897         Reviewed by Michael Catanzaro.
1898
1899         Add a test for the new API.
1900
1901         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1902         (testsJSCOptions):
1903         (main):
1904
1905 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1906
1907         [GTK][WPE] Support JPEG 2000 images
1908         https://bugs.webkit.org/show_bug.cgi?id=186272
1909
1910         Reviewed by Žan Doberšek.
1911
1912         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
1913
1914         * gtk/jhbuild.modules:
1915         * wpe/jhbuild.modules:
1916
1917 2019-01-23  David Kilzer  <ddkilzer@apple.com>
1918
1919         check-webkit-style should warn when using soft-linking macros in a header
1920         <https://webkit.org/b/193750>
1921
1922         Reviewed by Darin Adler.
1923
1924         * Scripts/webkitpy/style/checkers/cpp.py:
1925         (check_language): Add softlink/header check by refactoring the
1926         softlink/framework check.
1927         (CppChecker): Enable softlink/header check by default.
1928         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1929         (CppStyleTest.test_softlink_framework): Rename from
1930         CppStyleTest.test_softlink() and change test framework name in
1931         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
1932         files. Set file_name for macros that only appear in headers.
1933         (CppStyleTest.test_softlink_header): Add tests for using
1934         soft-link macros in headers.
1935
1936 2019-01-23  Chris Dumez  <cdumez@apple.com>
1937
1938         Deprecate API to limit the maximum number of WebProcesses
1939         https://bugs.webkit.org/show_bug.cgi?id=193725
1940         <rdar://problem/47464879>
1941
1942         Reviewed by Geoff Garen.
1943
1944         Update existing API tests to stop using deprecated API.
1945
1946         * MiniBrowser/mac/AppDelegate.m:
1947         (defaultConfiguration):
1948         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1949         (TestWebKitAPI::TEST):
1950         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
1951         (TestWebKitAPI::TEST):
1952         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1953         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1954         (TEST):
1955         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
1956         (TEST):
1957
1958 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1959
1960         [ews-app] Rename ews model buildermappings to buildermapping
1961         https://bugs.webkit.org/show_bug.cgi?id=193729
1962
1963         Reviewed by Lucas Forschler.
1964
1965         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
1966         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
1967         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
1968
1969 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1970
1971         [ews-app] Rename ews model steps to step
1972         https://bugs.webkit.org/show_bug.cgi?id=193697
1973
1974         Reviewed by Lucas Forschler.
1975
1976         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
1977         (Step): Renamed Steps to Step.
1978
1979 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
1980
1981         Clean up IndexedDB files between tests
1982         https://bugs.webkit.org/show_bug.cgi?id=192796
1983         <rdar://problem/46824999>
1984
1985         Reviewed by Geoffrey Garen.
1986
1987         * DumpRenderTree/mac/DumpRenderTree.mm:
1988         (runTest):
1989         * WebKitTestRunner/TestController.cpp:
1990         (WTR::TestController::resetStateToConsistentValues):
1991         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
1992         (WTR::RemoveAllIndexedDatabasesCallback):
1993         (WTR::TestController::ClearIndexedDatabases):
1994         * WebKitTestRunner/TestController.h:
1995         * WebKitTestRunner/TestInvocation.cpp:
1996         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1997
1998 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
1999
2000         [ews-app] Rename ews model Builds to Build
2001         https://bugs.webkit.org/show_bug.cgi?id=193695
2002
2003         Reviewed by Lucas Forschler.
2004
2005         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
2006         (Build): Renamed Builds to Build.
2007
2008 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2009
2010         webkitpy: Wait longer when launching WebKitTestRunner
2011         https://bugs.webkit.org/show_bug.cgi?id=193734
2012
2013         Reviewed by Aakash Jain.
2014
2015         * Scripts/webkitpy/port/simulator_process.py:
2016         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.
2017
2018 2019-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
2019
2020         [iOS] fast/events/touch/ios/hover-when-style-change-is-async.html times out
2021         https://bugs.webkit.org/show_bug.cgi?id=193182
2022         <rdar://problem/47452154>
2023
2024         Reviewed by Tim Horton.
2025
2026         This test was timing out because one of its preceding tests (drag-to-autoscroll-in-single-line-editable.html)
2027         long presses and drags to select text, but does not end the touch by lifting up; subsequently, the tap gesture
2028         recognizer isn't fired when simulating a tap in hover-when-style-change-is-async.html.
2029
2030         To fix this, tweak the test runner to make it safe for tests to end while touching the web view without
2031         preventing later tests from recognizing gestures.
2032
2033         * WebKitTestRunner/ios/TestControllerIOS.mm:
2034         (WTR::TestController::platformResetStateToConsistentValues):
2035
2036         Cancel all touches in the UIApplication when resetting to a consistent state between tests.
2037
2038 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
2039
2040         webkitpy: Use correct config for --iphone-simulator and --ipad-simulator
2041         https://bugs.webkit.org/show_bug.cgi?id=193722
2042         <rdar://problem/47481475>
2043
2044         Reviewed by Lucas Forschler.
2045
2046         iPhone and iPad ports should both use the iOS config.
2047
2048         * Scripts/webkitpy/port/ios_simulator.py:
2049         (IPhoneSimulatorPort.__init__):
2050         (IPadSimulatorPort.__init__):
2051
2052 2019-01-23  Rob Buis  <rbuis@igalia.com>
2053
2054         Update MIME type parser
2055         https://bugs.webkit.org/show_bug.cgi?id=180526
2056
2057         Reviewed by Frédéric Wang.
2058
2059         Add unit tests for both parse modes of ParsedContentType.
2060
2061         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2062         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp: Added.
2063         (TestWebKitAPI::TEST):
2064
2065 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2066
2067         [ews-app] fetch loop should not stop on network issues
2068         https://bugs.webkit.org/show_bug.cgi?id=193666
2069
2070         Reviewed by Lucas Forschler.
2071
2072         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2073         (FetchLoop.run): Ensure that fetch loop doesn't exit on any exception.
2074
2075 2019-01-22  Wenson Hsieh  <wenson_hsieh@apple.com>
2076
2077         [iOS] Multiple WKWebViewAutofillTests are flaky failures
2078         https://bugs.webkit.org/show_bug.cgi?id=189165
2079         <rdar://problem/47433765>
2080
2081         Reviewed by Tim Horton.
2082
2083         These tests are currently flaky because they expect an invocation of "Element.blur()" in the web process to
2084         immediately dispatch an IPC message to notify the UI process that the element has been blurred. In particular,
2085         the -textInputHasAutofillContext helper assumes that waiting for the next remote layer tree commit in the UI
2086         process in sufficient to ensure that any previous action that blurred the focused element in the web process
2087         would make its way to the UI process by the time the layer tree commit is finished.
2088
2089         However, WebPage::elementDidBlur sends its IPC message to the UI process asynchronously, using callOnMainThread.
2090         This means that if a layer tree flush was already scheduled in the web process before the element was blurred,
2091         the element blur IPC message to the UI process will lose the race against the layer tree commit, and the test
2092         will fail because it asks for -_autofillContext too early.
2093
2094         To fix this, we tweak these tests to actually wait until the intended input session change triggered by script
2095         is handled in the UI process.
2096
2097         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
2098
2099         Tweak some of these tests to wait for input session changes before checking for the presence of an autofill
2100         context. The only exception is an existing test that doesn't allow programmatic focus to begin input sessions
2101         by default; to fix this test, we simply wait for _WKInputDelegate to be invoked, instead of waiting for a new
2102         input session.
2103
2104         (-[AutofillTestView textInputHasAutofillContext]):
2105
2106         Remove the incorrect presentation update here. This helper now assumes that the UI process is up to date.
2107
2108         * TestWebKitAPI/cocoa/TestWKWebView.h:
2109         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2110         (nextInputSessionChangeCount):
2111
2112         Monotonically increasing identifier that's incremented whenever an input session is started in the UI process.
2113         This includes changing the focused element from one to another.
2114
2115         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2116         (-[TestWKWebView didStartFormControlInteraction]):
2117         (-[TestWKWebView didEndFormControlInteraction]):
2118         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2119
2120         Add a helper to evaluate JavaScript and wait for this script to cause some change in the input session. This
2121         handles three cases: (1) changing focus from an element that doesn't require an input session to one that does,
2122         (2) changing focus between elements that require input sessions, and (3) changing focus from an input session
2123         that doesn't require an input session to one that doesn't.
2124
2125 2019-01-22  David Kilzer  <ddkilzer@apple.com>
2126
2127         check-webkit-style reports false-positive whitespace/init warning in C++ initialization parameters
2128         <https://webkit.org/b/193676>
2129
2130         Reviewed by Alexey Proskuryakov.
2131
2132         * Scripts/webkitpy/style/checkers/cpp.py:
2133         (check_member_initialization_list):
2134         - Don't report missing whitespace around colon if the colon at
2135           the start of the line is formatted correctly.
2136         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2137         (WebKitStyleTest.test_member_initialization_list):
2138         - Add a test for a missing permutation of existing tests.
2139         - Add a test this false-positive.
2140         - Add blank lines between subtests to make them easier to read.
2141
2142 2019-01-22  Aakash Jain  <aakash_jain@apple.com>
2143
2144         [build.webkit.org] Unit-test failure after r237113
2145         https://bugs.webkit.org/show_bug.cgi?id=193669
2146
2147         Reviewed by Michael Catanzaro.
2148
2149         * BuildSlaveSupport/build.webkit.org-config/factories.py:
2150         (Factory.__init__): Properly check for --no-experimental-features flag when additionalArguments has 
2151         multiple or zero flags.
2152
2153 2019-01-22  Tadeu Zagallo  <tzagallo@apple.com>
2154
2155         Cache bytecode to disk
2156         https://bugs.webkit.org/show_bug.cgi?id=192782
2157         <rdar://problem/46084932>
2158
2159         Reviewed by Keith Miller.
2160
2161         Add test helper to execute bytecode-cache tests: it executes each test
2162         twice, the first with JSC_diskCachePath set to a temporary directory
2163         and second with JSC_forceDiskCache=true (in addition to the cache path)
2164         to guarantee that only the disk cache is being used and no new
2165         UnlinkedCodeBlocks are being created.
2166
2167         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh: Added.
2168         * Scripts/run-jsc-stress-tests:
2169
2170 2019-01-22  Oriol Brufau  <obrufau@igalia.com>
2171
2172         [css-logical] Implement flow-relative margin, padding and border shorthands
2173         https://bugs.webkit.org/show_bug.cgi?id=188697
2174
2175         Reviewed by Simon Fraser and Antti Koivisto.
2176
2177         * DumpRenderTree/TestOptions.cpp:
2178         (TestOptions::TestOptions):
2179         * DumpRenderTree/TestOptions.h:
2180         * DumpRenderTree/mac/DumpRenderTree.mm:
2181         (setWebPreferencesForTestOptions):
2182         Allow tests to enable the CSSLogicalEnabled flag in WK1.
2183
2184         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2185         (JSONCSSPropertiesChecker.check_codegen_properties):
2186         Allow CSS property definitions to have a 'runtime-flag' parameter which
2187         disables the property when the specified runtime flag is disabled.
2188
2189 2019-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
2190
2191         [GTK][WPE] libgcrypt-1.7.6 can't be compiled on Ubuntu 18.10
2192         https://bugs.webkit.org/show_bug.cgi?id=193643
2193
2194         Reviewed by Michael Catanzaro.
2195
2196         * gtk/jhbuild.modules: Bumped to libgcrypt-1.8.4.
2197         * wpe/jhbuild.modules: Ditto.
2198
2199 2019-01-21  Zalan Bujtas  <zalan@apple.com>
2200
2201         [LFC][Floats] Take float top position into account when computing containing block height.
2202         https://bugs.webkit.org/show_bug.cgi?id=193655
2203
2204         Reviewed by Antti Koivisto.
2205
2206         * LayoutReloaded/misc/LFC-passing-tests.txt:
2207
2208 2019-01-21  David Kilzer  <ddkilzer@apple.com>
2209
2210         Switch remaining VideoToolbox soft-linking in WebCore over to VideoToolboxSoftLink.{cpp,h}
2211         <https://webkit.org/b/193645>
2212         <rdar://problem/47421574>
2213
2214         Reviewed by Alex Christensen.
2215
2216         - Now checks for local soft-linking of all frameworks that have
2217           their own *SoftLinking.{cpp,h,mm} files.
2218         - Changes softlink/uikit warning to softlink/framework.
2219
2220         * Scripts/webkitpy/style/checkers/cpp.py:
2221         (check_language):
2222         (CppChecker):
2223         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2224         (CppStyleTest):
2225
2226 2019-01-20  Saam Barati  <sbarati@apple.com>
2227
2228         Rollout r240210: It broke tests on iOS
2229         https://bugs.webkit.org/show_bug.cgi?id=193640
2230
2231         Unreviewed.
2232
2233         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper:
2234         * Scripts/run-jsc-stress-tests:
2235
2236 2019-01-20  chris fleizach  <cfleizach@apple.com>
2237
2238         AX: Support returning relative frames for accessibility
2239         https://bugs.webkit.org/show_bug.cgi?id=193414
2240         <rdar://problem/47268501>
2241
2242         Reviewed by Zalan Bujtas.
2243
2244         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2245         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2246         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2247         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2248         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2249         (WTR::attributesOfElement):
2250         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2251
2252 2019-01-20  Yusuke Suzuki  <ysuzuki@apple.com>
2253
2254         Unreviewed, add my new email address
2255
2256         * Scripts/webkitpy/common/config/contributors.json:
2257
2258 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2259
2260         [LFC][BFC] <body>'s overflow property value is propagated to viewport
2261         https://bugs.webkit.org/show_bug.cgi?id=193617
2262
2263         Reviewed by Antti Koivisto.
2264
2265         * LayoutReloaded/misc/LFC-passing-tests.txt:
2266
2267 2019-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2268
2269         Unreviewed, rolling out r240209.
2270
2271         Broke GTK/WPE injected bundle
2272
2273         Reverted changeset:
2274
2275         "AX: Support returning relative frames for accessibility"
2276         https://bugs.webkit.org/show_bug.cgi?id=193414
2277         https://trac.webkit.org/changeset/240209
2278
2279 2019-01-12  Dan Bernstein  <mitz@apple.com>
2280
2281         [Cocoa] Avoid importing directly from subumbrella frameworks
2282         https://bugs.webkit.org/show_bug.cgi?id=186016
2283         <rdar://problem/40591038>
2284
2285         Reviewed by Sam Weinig.
2286
2287         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
2288           LaunchServices header.
2289         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2290           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2291         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
2292           when using SDKs earlier than 10.13.
2293         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
2294           and OTHER_CPLUSPLUSFLAGS.
2295         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
2296           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
2297         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
2298           LaunchServices header.
2299
2300 2019-01-20  Tadeu Zagallo  <tzagallo@apple.com>
2301
2302         Cache bytecode to disk
2303         https://bugs.webkit.org/show_bug.cgi?id=192782
2304         <rdar://problem/46084932>
2305
2306         Reviewed by Keith Miller.
2307
2308         Add test helper to execute bytecode-cache tests: it executes each test
2309         twice, the first with JSC_diskCachePath set to a temporary directory
2310         and second with JSC_forceDiskCache=true (in addition to the cache path)
2311         to guarantee that only the disk cache is being used and no new
2312         UnlinkedCodeBlocks are being created.
2313
2314         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper: Added.
2315         * Scripts/run-jsc-stress-tests:
2316
2317 2019-01-20  chris fleizach  <cfleizach@apple.com>
2318
2319         AX: Support returning relative frames for accessibility
2320         https://bugs.webkit.org/show_bug.cgi?id=193414
2321         <rdar://problem/47268501>
2322
2323         Reviewed by Zalan Bujtas.
2324
2325         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2326         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2327         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2328         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2329         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2330         (WTR::attributesOfElement):
2331         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
2332
2333 2019-01-20  Antoine Quint  <graouts@apple.com>
2334
2335         Add a POINTER_EVENTS feature flag
2336         https://bugs.webkit.org/show_bug.cgi?id=193577
2337         <rdar://problem/47408511>
2338
2339         Unreviewed. Also enable Pointer Events for iosmac.
2340
2341         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2342
2343 2019-01-19  Zalan Bujtas  <zalan@apple.com>
2344
2345         [LFC][Floats] Ensure that floats in FloatingContext::m_floats are always horizontally ordered.
2346         https://bugs.webkit.org/show_bug.cgi?id=193613
2347
2348         Reviewed by Antti Koivisto.
2349
2350         * LayoutReloaded/misc/LFC-passing-tests.txt:
2351
2352 2019-01-19  Antoine Quint  <graouts@apple.com>
2353
2354         Add a POINTER_EVENTS feature flag
2355         https://bugs.webkit.org/show_bug.cgi?id=193577
2356
2357         Reviewed by Dean Jackson.
2358
2359         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2360
2361 2019-01-18  Zhifei FANG  <zhifei_fang@apple.com>
2362
2363         Disable the run-jsc-stress-test remote host key check [second round].
2364         https://bugs.webkit.org/show_bug.cgi?id=192988
2365
2366         Reviewed by Dewei Zhu.
2367
2368         * Scripts/run-jsc-stress-tests:
2369
2370 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2371
2372         [build.webkit.org] unit-test failure Builder GTK Linux 32-bit Release doesn't exist
2373         https://bugs.webkit.org/show_bug.cgi?id=193597
2374
2375         Reviewed by Lucas Forschler.
2376
2377         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2378
2379 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2380
2381         [build.webkit.org] api tests failures are incorrectly named as unit test failures
2382         https://bugs.webkit.org/show_bug.cgi?id=193595
2383
2384         Reviewed by Lucas Forschler.
2385
2386         * BuildSlaveSupport/build.webkit.org-config/factories.py: Renamed RunUnitTests to RunAPITests.
2387         * BuildSlaveSupport/build.webkit.org-config/steps.py: Ditto.
2388         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Ditto.
2389
2390 2019-01-18  Chris Dumez  <cdumez@apple.com>
2391
2392         Regression(PSON) Content blockers are sometimes lost on back navigation cross-site
2393         https://bugs.webkit.org/show_bug.cgi?id=193588
2394         <rdar://problem/47131566>
2395
2396         Reviewed by Alex Christensen.
2397
2398         Add layout test coverage.
2399
2400         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2401
2402 2019-01-18  Jer Noble  <jer.noble@apple.com>
2403
2404         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2405         https://bugs.webkit.org/show_bug.cgi?id=189553
2406
2407         Reviewed by Tim Horton.
2408
2409         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2410
2411         * ContentExtensionTester/Configurations/Base.xcconfig:
2412         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2413         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2414         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2415         * ImageDiff/cg/Configurations/Base.xcconfig:
2416         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2417         * MiniBrowser/Configurations/Base.xcconfig:
2418         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2419         * MobileMiniBrowser/Configurations/Base.xcconfig:
2420         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2421         * Scripts/webkitpy/style/checker.py:
2422         (_all_categories):
2423         (FileType):
2424         (CheckerDispatcher._file_type):
2425         (CheckerDispatcher._create_checker):
2426         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2427         (SDKVariantChecker):
2428         (SDKVariantChecker.__init__):
2429         (SDKVariantChecker.check):
2430         * TestWebKitAPI/Configurations/Base.xcconfig:
2431         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2432         * WebEditingTester/Configurations/Base.xcconfig:
2433         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2434         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2435         * WebKitTestRunner/Configurations/Base.xcconfig:
2436         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2437         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2438         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2439
2440 2019-01-18  David Kilzer  <ddkilzer@apple.com>
2441
2442         Switch remaining UIKit soft-linking in WebCore, WebKitLegacy over to UIKitSoftLink.{cpp,h}
2443         <https://webkit.org/b/193568>
2444         <rdar://problem/47381130>
2445
2446         Reviewed by Alex Christensen.
2447
2448         Make sure no one re-introduces UIKit soft-linking by adding a
2449         style rule.
2450
2451         * Scripts/webkitpy/style/checkers/cpp.py:
2452         (check_language): Add softlink/uikit check.
2453         (CppChecker): Enable softlink/uikit check.
2454         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2455         (CppStyleTest): Add test for softlink/uikit.
2456
2457 2019-01-18  Joanmarie Diggs  <jdiggs@igalia.com>
2458
2459         [GTK] install-dependencies tool looks for libunistring-dev for dnf
2460         https://bugs.webkit.org/show_bug.cgi?id=193584
2461
2462         Change "-dev" to "-devel".
2463
2464         Reviewed by Michael Catanzaro.
2465
2466         * gtk/install-dependencies:
2467
2468 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2469
2470         webkitpy: Add iPhone and iPad ports
2471         https://bugs.webkit.org/show_bug.cgi?id=193537
2472         <rdar://problem/47353390>
2473
2474         Reviewed by Lucas Forschler.
2475
2476         Add --iphone-simulator and --ipad-simulator commands to run-webkit-tests which separate iPhone and iPad into separate
2477         ports. Note that this separation is optional, the --ios-simulator command remains.
2478
2479         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2480         (RunTest.test_device_type_test_division): Drive-by fix.
2481         (RunTest.test_device_type_specific_listing): Ditto.
2482         (RunTest.test_ipad_test_division):
2483         (RunTest):
2484         (RunTest.test_ipad_listing):
2485         * Scripts/webkitpy/port/factory.py:
2486         (platform_options): Add --iphone-simulator and --ipad-simulator flags.
2487         (PortFactory):
2488         * Scripts/webkitpy/port/ios_simulator.py:
2489         (IPhoneSimulatorPort):
2490         (IPadSimulatorPort):
2491
2492 2019-01-18  Chris Dumez  <cdumez@apple.com>
2493
2494         Regression(PSON) Scroll position is not always restored properly when navigating back
2495         https://bugs.webkit.org/show_bug.cgi?id=193578
2496         <rdar://problem/47386331>
2497
2498         Reviewed by Tim Horton.
2499
2500         Add API test coverage.
2501
2502         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2503
2504 2019-01-18  Youenn Fablet  <youenn@apple.com>
2505
2506         Add a new SPI to request for cache storage quota increase
2507         https://bugs.webkit.org/show_bug.cgi?id=193323
2508
2509         Reviewed by Alex Christensen.
2510
2511         Implement WebsiteDataStore quota delegate to handle quota requests.
2512         By default, do not update quota.
2513         Update quota if test calls the new testRunner.allowCacheStorageQuotaIncrease method.
2514
2515         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2516         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2517         (WTR::TestRunner::allowCacheStorageQuotaIncrease):
2518         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2519         * WebKitTestRunner/TestController.cpp:
2520         (WTR::TestController::allowCacheStorageQuotaIncrease):
2521         * WebKitTestRunner/TestController.h:
2522         * WebKitTestRunner/TestInvocation.cpp:
2523         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2524         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2525         (-[CacheStorageQuotaManager init]):
2526         (-[CacheStorageQuotaManager _requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
2527         (WTR::initializeWebViewConfiguration):
2528         (WTR::TestController::cocoaResetStateToConsistentValues):
2529         (WTR::TestController::allowCacheStorageQuotaIncrease):
2530
2531 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2532
2533         [ews-build] Pass owner to the triggered builds
2534         https://bugs.webkit.org/show_bug.cgi?id=193574
2535
2536         Reviewed by Lucas Forschler.
2537
2538         * BuildSlaveSupport/ews-build/factories.py:
2539         (BuildFactory.propertiesToPassToTriggers):
2540
2541 2019-01-18  Aakash Jain  <aakash_jain@apple.com>
2542
2543         [ews-app] Send patch author as a build property
2544         https://bugs.webkit.org/show_bug.cgi?id=193560
2545
2546         Reviewed by Lucas Forschler.
2547
2548         * BuildSlaveSupport/ews-app/ews/fetcher.py:
2549         (BugzillaPatchFetcher.fetch):
2550
2551 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2552
2553         webkitpy: Implement device type specific expected results (Follow-up fix)
2554         https://bugs.webkit.org/show_bug.cgi?id=192162
2555         <rdar://problem/46345449>
2556
2557         Unreviewed infrastructure fix.
2558
2559         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2560         (Manager.run): Don't boot a device if no tests are available to run on it.
2561
2562 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2563
2564         webkitpy: Implement device type specific expected results (Follow-up fix)
2565         https://bugs.webkit.org/show_bug.cgi?id=192162
2566         <rdar://problem/46345449>
2567
2568         Unreviewed infrastructure fix.
2569
2570         * Scripts/webkitpy/api_tests/manager.py:
2571         (Manager._initialize_devices): Use DEVICE_TYPE when running API tests.
2572
2573 2019-01-18  Jonathan Bedard  <jbedard@apple.com>
2574
2575         webkitpy: Implement device type specific expected results (Part 2)
2576         https://bugs.webkit.org/show_bug.cgi?id=192162
2577         <rdar://problem/46345449>
2578
2579         Rubber-stamped by Aakash Jain.
2580
2581         This change uses device_type to select a different set of TestExpectation files based on the type of device running
2582         tests. This requires multiple baseline search paths to be used in a single instantiation of run-webkit-tests. Note
2583         that while multiple baseline search paths are used, any single test will only ever be run on a single device type.
2584
2585         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
2586         (LayoutTestFinder.find_tests): Pass device_type through.
2587         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder_unittest.py:
2588         (LayoutTestFinderTests.test_touched_but_skipped_test): Allow device_type to be passed in.
2589         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2590         (Manager.__init__): Make _expectations an OrderedDict indexed by device_type, add current_device_type.
2591         (Manager._collect_tests): Pass device type to test finder.
2592         (Manager._needs_web_platform_test):
2593         (Manager._prepare_lists): Index _expectations by device type.
2594         (Manager._test_input_for_file):
2595         (Manager._test_is_slow): Ditto.
2596         (Manager._test_should_dump_jsconsolelog_in_stderr):
2597         (Manager._test_should_dump_jsconsolelog_in_stderr): Ditto.
2598         (Manager._get_test_inputs):
2599         (Manager._update_worker_count):
2600         (Manager._set_up_run): Use current_device_type instead of passing device_type in.
2601         (Manager.run): Re-write function to gather and parse expectations from multiple baseline search paths. In the event
2602         that a test can be run on multiple device types, the first device in the device type list which is eligible will be
2603         the one which runs the test.
2604         (Manager._run_test_subset):
2605         (Manager._run_tests): Index _expectations by current_device_type.
2606         (Manager._print_expectation_line_for_test): Ditto.
2607         (Manager._print_expectations_for_subset): Ditto.
2608         (Manager.print_expectations): Re-write function to gather and parse expectations from multiple baseline search paths.
2609         Unlike run, this function will behave the same regardless of what devices are available.
2610         (Manager._custom_device_for_test): Deleted.
2611         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2612         (ManagerTest.test_uses_custom_device): Deleted.
2613         (ManagerTest.test_uses_custom_device.get_manager): Deleted.
2614         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
2615         (JSONLayoutResultsGenerator.__init__): Pass expectations as a dictionary indexed by device type.
2616         (JSONLayoutResultsGenerator._insert_failure_summaries): The number of fixable tests must take into consideration
2617         all of the expectations.
2618         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2619         (FakePort.skipped_layout_tests): Allow device_type to be passed in.
2620         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2621         (TestExpectations.__init__): Allow device_type to be passed through.
2622         (TestExpectations.parse_all_expectations): Pick expectations_dict by device type.
2623         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Allow device_type to be passed in.
2624         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2625         (summarize_results):
2626         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2627         (summarized_results): Expectations are stored in a dictionary indexed by device_type. When determining the expectation
2628         a test ran with, one must check all expectations to find the first non-skip expectation.
2629         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2630         (RunTest.test_device_type_test_division):
2631         (RunTest):
2632         (RunTest.test_device_type_specific_listing):
2633         * Scripts/webkitpy/port/base.py:
2634         (Port): Add default values for DEVICE_TYPE and DEFAULT_DEVICE_TYPES.
2635         (Port.supported_device_types): The result of this function will change based on what devices are available.
2636         * Scripts/webkitpy/port/device_port.py:
2637         (DevicePort._device_type_with_version): Replace DEFAULT_DEVICE_TYPE with DEVICE_TYPE.
2638         (DevicePort.default_child_processes): DEVICE_TYPE is a general type, so the built-in comparison of the DeviceType object
2639         can be used.
2640         (DevicePort.supported_device_types): Generates a list of device types determined by the available devices, if there are
2641         any, or the DEFAULT_DEVICE_TYPES of the port.
2642         * Scripts/webkitpy/port/ios.py:
2643         (IOSPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2644         * Scripts/webkitpy/port/ios_simulator.py:
2645         (IOSSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the devices currently used to run layout tests.
2646         * Scripts/webkitpy/port/watch.py:
2647         (WatchPort): Change DEFAULT_DEVICE_TYPE to DEVICE_TYPE.
2648         * Scripts/webkitpy/port/watch_simulator.py:
2649         (WatchSimulatorPort): Set the DEFAULT_DEVICE_TYPES to the device currently used to run layout tests.
2650         * Scripts/webkitpy/xcode/device_type.py:
2651         (DeviceType):
2652         (DeviceType.__hash__): Allow DeviceType to be used as a dictionary index.
2653
2654 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2655
2656         [WPE] run-qt-wpe-minibrowser needlessly expects a --wpe argument
2657         https://bugs.webkit.org/show_bug.cgi?id=193575
2658
2659         Reviewed by Michael Catanzaro.
2660
2661         Allow the script to run without explicit port argument because
2662         it's specific to the WPE port anyway.
2663
2664         * Scripts/run-qt-wpe-minibrowser: Manually insert --wpe in argv
2665         and simplify the rest of the code accordingly.
2666
2667 2019-01-18  Charlie Turner  <cturner@igalia.com>
2668
2669         [GStreamer][EME][ClearKey] Request keys from CDMInstance rather than passing via bus messages
2670         https://bugs.webkit.org/show_bug.cgi?id=192229
2671
2672         Reviewed by Xabier Rodriguez-Calvar.
2673
2674         * MiniBrowser/wpe/main.cpp:
2675         (main): Enable encrypted-media by default.
2676
2677 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2678
2679         [Flatpak] Missing KeyboardInterrupt exception handler
2680         https://bugs.webkit.org/show_bug.cgi?id=193570
2681
2682         Reviewed by Michael Catanzaro.
2683
2684         * flatpak/flatpakutils.py:
2685         (WebkitFlatpak.run_in_sandbox): Basic KeyboardInterrupt handling.
2686
2687 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2688
2689         [LFC][BFC][MarginCollapsing] Collapsing through should not ignore floats.
2690         https://bugs.webkit.org/show_bug.cgi?id=193564
2691
2692         Reviewed by Antti Koivisto.
2693
2694         * LayoutReloaded/misc/LFC-passing-tests.txt:
2695
2696 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2697
2698         [LFC] Do not skip float boxes that are not part of the current formatting context when computing bottom.
2699         https://bugs.webkit.org/show_bug.cgi?id=193562
2700
2701         Reviewed by Antti Koivisto.
2702
2703         * LayoutReloaded/misc/LFC-passing-tests.txt:
2704
2705 2019-01-18  Zalan Bujtas  <zalan@apple.com>
2706
2707         [LFC][BFC] Check for inflow children while computing height for block formatting context roots.
2708         https://bugs.webkit.org/show_bug.cgi?id=193555
2709
2710         Reviewed by Antti Koivisto.
2711
2712         * LayoutReloaded/misc/LFC-passing-tests.txt:
2713
2714 2019-01-18  Philippe Normand  <pnormand@igalia.com>
2715
2716         [WPE] Add Qt extension
2717         https://bugs.webkit.org/show_bug.cgi?id=191464
2718
2719         Reviewed by Carlos Garcia Campos.
2720
2721         MiniBrowser and API tests for the WPE Qt API. To run the
2722         MiniBrowser a new script is introduced. Example invocation:
2723
2724         $ run-qt-wpe-minibrowser -platform wayland https://webkit.org
2725
2726         Also note-worthy is the introduction of the python2-subprocess32
2727         dependency to run the GLib API tests.
2728
2729         * MiniBrowser/wpe/CMakeLists.txt:
2730         * MiniBrowser/wpe/qt/CMakeLists.txt: Added.
2731         * MiniBrowser/wpe/qt/main.cpp: Added.
2732         (main):
2733         * MiniBrowser/wpe/qt/main.qml: Added.
2734         * MiniBrowser/wpe/qt/qml.qrc: Added.
2735         * Scripts/run-gtk-tests:
2736         (GtkTestRunner.is_google_test):
2737         (GtkTestRunner):
2738         (GtkTestRunner.is_qt_test):
2739         * Scripts/run-qt-wpe-minibrowser: Added.
2740         * Scripts/run-wpe-tests:
2741         (WPETestRunner):
2742         (WPETestRunner.is_google_test):
2743         (WPETestRunner.is_qt_test):
2744         * TestWebKitAPI/Tests/WPEQt/TestLoad.cpp: Added.
2745         (TestLoad::main):
2746         * TestWebKitAPI/Tests/WPEQt/TestLoadHtml.cpp: Added.
2747         (TestLoadHtml::main):
2748         * TestWebKitAPI/Tests/WPEQt/TestLoadRequest.cpp: Added.
2749         (TestLoadRequest::main):
2750         * TestWebKitAPI/Tests/WPEQt/TestRunJavaScript.cpp: Added.
2751         (TestRunJavaScript::main):
2752         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.cpp: Added.
2753         (waitForSignal):
2754         * TestWebKitAPI/Tests/WPEQt/WPEQtTest.h: Added.
2755         (LoadSpy::LoadSpy):
2756         (LoadSpy::~LoadSpy):
2757         (LoadSpy::onLoadingChanged):
2758         (LoadStartedCatcher::LoadStartedCatcher):
2759         (LoadStartedCatcher::~LoadStartedCatcher):
2760         (LoadStartedCatcher::onLoadingChanged):
2761         (waitForLoadSucceeded):
2762         (waitForLoadFailed):
2763         * TestWebKitAPI/glib/CMakeLists.txt:
2764         * flatpak/flatpakutils.py:
2765         (WebkitFlatpak.load_from_args):
2766         (WebkitFlatpak.__init__):
2767         (WebkitFlatpak.clean_args):
2768         (WebkitFlatpak.run_in_sandbox):
2769         * flatpak/org.webkit.CommonModules.yaml:
2770         * flatpak/org.webkit.WPE.yaml:
2771         * flatpak/org.webkit.WPEModules.yaml:
2772         * flatpak/org.webkit.WPEQT.yaml: Copied from Tools/flatpak/org.webkit.WebKit.yaml.
2773         * flatpak/org.webkit.WebKit.yaml:
2774         * glib/api_test_runner.py:
2775         (TestRunner._run_test_qt):
2776         (TestRunner.is_qt_test):
2777         (TestRunner._run_test):
2778
2779 2019-01-17  Wenson Hsieh  <wenson_hsieh@apple.com>
2780
2781         [iOS] Content offset jumps erratically when autoscrolling near scroll view content inset areas
2782         https://bugs.webkit.org/show_bug.cgi?id=193494
2783         <rdar://problem/46859627>
2784
2785         Reviewed by Simon Fraser and Tim Horton.
2786
2787         Add a new test option to add a top content inset to the test runner's WKWebView's scroll view, and automatically
2788         scroll to reveal this top content inset area when beginning the test (i.e., scroll to (0, -topContentInset)).
2789
2790         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2791         (WTR::UIScriptController::contentOffsetX const):
2792         (WTR::UIScriptController::contentOffsetY const):
2793         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2794         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2795         (WTR::UIScriptController::contentOffsetX const):
2796         (WTR::UIScriptController::contentOffsetY const):
2797         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2798
2799         Also add new UIScriptController methods to ask for the content offset of the platform scroll view.
2800
2801         * WebKitTestRunner/TestController.cpp:
2802         (WTR::updateTestOptionsFromTestHeader):
2803         * WebKitTestRunner/TestOptions.h:
2804         (WTR::TestOptions::hasSameInitializationOptions const):
2805         * WebKitTestRunner/ios/TestControllerIOS.mm:
2806         (WTR::TestController::platformResetStateToConsistentValues):
2807         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2808         (WTR::UIScriptController::contentOffsetX const):
2809         (WTR::UIScriptController::contentOffsetY const):
2810
2811 2019-01-17  Truitt Savell  <tsavell@apple.com>
2812
2813         Unreviewed, rolling out r240124.
2814
2815         This commit broke an internal build.
2816
2817         Reverted changeset:
2818
2819         "SDK_VARIANT build destinations should be separate from non-
2820         SDK_VARIANT builds"
2821         https://bugs.webkit.org/show_bug.cgi?id=189553
2822         https://trac.webkit.org/changeset/240124
2823
2824 2019-01-17  Alex Christensen  <achristensen@webkit.org>
2825
2826         Fix string concatenation API test after r239920
2827         https://bugs.webkit.org/show_bug.cgi?id=193551
2828         <rdar://problem/47359304>
2829
2830         Reviewed by Youenn Fablet.
2831
2832         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2833         (TestWebKitAPI::TEST):
2834         Cocoa platforms' interpretation of UChar/unsigned short equality is not affected by ICU's recent change of UChar's type
2835         in WebKit's build configuration like it apparently is on Linux.
2836
2837 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2838
2839         [ews-build] validate-patch should handle the case when bug_id is None
2840         https://bugs.webkit.org/show_bug.cgi?id=193547
2841
2842         Reviewed by Lucas Forschler.
2843
2844         * BuildSlaveSupport/ews-build/steps.py:
2845         (ValidatePatch._is_bug_closed): Gracefully handle the case when bug_id is None.
2846         (ValidatePatch.start): If bug_id is set as None in build properties, fetch it from the patch.
2847
2848 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2849
2850         [ews-build] Add patch author information in build
2851         https://bugs.webkit.org/show_bug.cgi?id=193465
2852
2853         Reviewed by Lucas Forschler.
2854
2855         * BuildSlaveSupport/ews-build/steps.py:
2856         (ValidatePatch._is_patch_obsolete):
2857
2858 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2859
2860         [ews-build] Pass bug_id to the triggered builds
2861         https://bugs.webkit.org/show_bug.cgi?id=193548
2862
2863         Reviewed by Lucas Forschler.
2864
2865         * BuildSlaveSupport/ews-build/factories.py:
2866         (BuildFactory.propertiesToPassToTriggers):
2867
2868 2019-01-17  Jer Noble  <jer.noble@apple.com>
2869
2870         SDK_VARIANT build destinations should be separate from non-SDK_VARIANT builds
2871         https://bugs.webkit.org/show_bug.cgi?id=189553
2872
2873         Reviewed by Tim Horton.
2874
2875         Add a check-webkit-style check that ensures all SDKVariant.xcconfig files match.
2876
2877         * ContentExtensionTester/Configurations/Base.xcconfig:
2878         * ContentExtensionTester/Configurations/SDKVariant.xcconfig: Added.
2879         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2880         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig: Added.
2881         * ImageDiff/cg/Configurations/Base.xcconfig:
2882         * ImageDiff/cg/Configurations/SDKVariant.xcconfig: Added.
2883         * MiniBrowser/Configurations/Base.xcconfig:
2884         * MiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2885         * MobileMiniBrowser/Configurations/Base.xcconfig:
2886         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig: Added.
2887         * Scripts/webkitpy/style/checker.py:
2888         (_all_categories):
2889         (FileType):
2890         (CheckerDispatcher._file_type):
2891         (CheckerDispatcher._create_checker):
2892         * Scripts/webkitpy/style/checkers/sdkvariant.py: Added.
2893         (SDKVariantChecker):
2894         (SDKVariantChecker.__init__):
2895         (SDKVariantChecker.check):
2896         * TestWebKitAPI/Configurations/Base.xcconfig:
2897         * TestWebKitAPI/Configurations/SDKVariant.xcconfig: Added.
2898         * WebEditingTester/Configurations/Base.xcconfig:
2899         * WebEditingTester/Configurations/SDKVariant.xcconfig: Added.
2900         * WebKitLauncher/Configurations/SDKVariant.xcconfig: Added.
2901         * WebKitTestRunner/Configurations/Base.xcconfig:
2902         * WebKitTestRunner/Configurations/SDKVariant.xcconfig: Added.
2903         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
2904         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig: Added.
2905
2906 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2907
2908         [LFC][BFC] An element with transform is a containing block for positioned descendants.
2909         https://bugs.webkit.org/show_bug.cgi?id=193534
2910
2911         Reviewed by Antti Koivisto.
2912
2913         * LayoutReloaded/misc/LFC-passing-tests.txt:
2914
2915 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2916
2917         [LFC][BFC][Quirk] Take body padding and border into account when stretching height.
2918         https://bugs.webkit.org/show_bug.cgi?id=193528
2919
2920         Reviewed by Antti Koivisto.
2921
2922         * LayoutReloaded/misc/LFC-passing-tests.txt:
2923
2924 2019-01-17  Zalan Bujtas  <zalan@apple.com>
2925
2926         [LFC][BFC] For height computation, the bottom edge of the last line box value should include top border/padding
2927         https://bugs.webkit.org/show_bug.cgi?id=193520
2928
2929         Reviewed by Antti Koivisto.
2930
2931         * LayoutReloaded/misc/LFC-passing-tests.txt:
2932
2933 2019-01-17  Aakash Jain  <aakash_jain@apple.com>
2934
2935         [ews-build] unapply-patch step should not update source
2936         https://bugs.webkit.org/show_bug.cgi?id=193234
2937
2938         Reviewed by Lucas Forschler.
2939
2940         * BuildSlaveSupport/ews-build/steps.py:
2941         (CleanWorkingDirectory): Use clean-webkit script to clean the working directory.
2942         (UnApplyPatchIfRequired): Use CleanWorkingDirectory as base class.
2943
2944 2019-01-16  Youenn Fablet  <youenn@apple.com>
2945
2946         Add a new SPI for controlling getUserMedia
2947         https://bugs.webkit.org/show_bug.cgi?id=192793
2948
2949         Reviewed by Eric Carlson.
2950
2951         * MiniBrowser/mac/WK2BrowserWindowController.m:
2952         (-[WK2BrowserWindowController _webView:requestUserMediaAuthorizationForFrame:devices:decisionHandler:]):
2953         (-[WK2BrowserWindowController _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2954         * TestWebKitAPI/Tests/WebKit/GetUserMediaNavigation.mm:
2955         (-[NavigationWhileGetUserMediaPromptDisplayedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2956         * TestWebKitAPI/Tests/WebKit/GetUserMediaReprompt.mm:
2957         (-[GetUserMediaRepromptUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2958         * TestWebKitAPI/Tests/WebKit/MediaStreamTrackDetached.mm:
2959         (-[MediaStreamTrackDetachedUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2960         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
2961         (-[UserMediaUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2962         (-[UserMediaUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2963         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaSimulateFailedSandbox.mm:
2964         (-[SimulateFailedSandboxUIDelegate _webView:requestMediaCaptureAuthorizationForFrame:devices:decisionHandler:]):
2965         (-[SimulateFailedSandboxUIDelegate _webView:isMediaCaptureAuthorizedForFrame:decisionHandler:]):
2966
2967 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2968
2969         [LFC][BFC] Inflow non-replaced used width should not be negative.
2970         https://bugs.webkit.org/show_bug.cgi?id=193495
2971
2972         Reviewed by Antti Koivisto.
2973
2974         * LayoutReloaded/misc/LFC-passing-tests.txt:
2975
2976 2019-01-16  Chris Dumez  <cdumez@apple.com>
2977
2978         Regression(PSON) View becomes blank after click a cross-site download link
2979         https://bugs.webkit.org/show_bug.cgi?id=193361
2980         <rdar://problem/47099573>
2981
2982         Reviewed by Geoffrey Garen.
2983
2984         Add API test coverage.
2985
2986         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2987         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2988
2989 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2990
2991         [LFC][Out-of-flow] Set used vertical margin values when top/height/bottom are non-auto.
2992         https://bugs.webkit.org/show_bug.cgi?id=193470
2993
2994         Reviewed by Antti Koivisto.
2995
2996         * LayoutReloaded/misc/LFC-passing-tests.txt:
2997
2998 2019-01-16  Zalan Bujtas  <zalan@apple.com>
2999
3000         [LFC] Adjust margin box verification.
3001         https://bugs.webkit.org/show_bug.cgi?id=193482
3002
3003         Reviewed by Antti Koivisto.
3004
3005         * LayoutReloaded/misc/LFC-passing-tests.txt:
3006
3007 2019-01-15  Sihui Liu  <sihui_liu@apple.com>
3008
3009         Fix API test WebKit.WebsiteDataStoreCustomPathsWithoutPrewarming after 193354
3010         https://bugs.webkit.org/show_bug.cgi?id=193451
3011
3012         Reviewed by Geoffrey Garen.
3013
3014         * TestWebKitAPI/Tests/WebKitCocoa/DuplicateCompletionHandlerCalls.mm:
3015         (TEST):
3016         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3017         (runWebsiteDataStoreCustomPaths):
3018
3019 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3020
3021         webkitpy: Support boolean simctl isAvailable
3022         https://bugs.webkit.org/show_bug.cgi?id=193472
3023         <rdar://problem/47296150>
3024
3025         Reviewed by Ryosuke Niwa.
3026
3027         * Scripts/webkitpy/xcode/simulated_device.py:
3028         (SimulatedDeviceManager._create_runtimes):
3029         (SimulatedDeviceManager._create_device_with_runtime):
3030
3031 2019-01-15  Chris Dumez  <cdumez@apple.com>
3032
3033         Unreviewed, rolling out r239993, r239995, r239997, and
3034         r239999.
3035
3036         Caused assertions under
3037         ViewGestureController::disconnectFromProcess()
3038
3039         Reverted changesets:
3040
3041         "Regression(PSON) View becomes blank after click a cross-site
3042         download link"
3043         https://bugs.webkit.org/show_bug.cgi?id=193361
3044         https://trac.webkit.org/changeset/239993
3045
3046         "Unreviewed iOS build fix after r239993."
3047         https://trac.webkit.org/changeset/239995
3048
3049         "Fix iOS build after r239993"
3050         https://bugs.webkit.org/show_bug.cgi?id=193361
3051         https://trac.webkit.org/changeset/239997
3052
3053         "Unreviewed, revert part of r239997 as it is not needed to fix
3054         the build."
3055         https://trac.webkit.org/changeset/239999
3056
3057 2019-01-15  Tim Horton  <timothy_horton@apple.com>
3058
3059         Cannot tab out of WKWebView on macOS
3060         https://bugs.webkit.org/show_bug.cgi?id=161448
3061         <rdar://problem/28100085>
3062
3063         Reviewed by Dean Jackson.
3064
3065         Add a test that tabbing into and out of WKWebView works correctly.
3066
3067         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3068         * TestWebKitAPI/Tests/WebKitCocoa/CommandBackForward.mm:
3069         (WebKit2_CommandBackForwardTest::SetUp):
3070         (-[CommandBackForwardOffscreenWindow isKeyWindow]): Deleted.
3071         (-[CommandBackForwardOffscreenWindow isVisible]): Deleted.
3072         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm: Added.
3073         (-[FocusableView canBecomeKeyView]):
3074         (TEST):
3075         * TestWebKitAPI/mac/OffscreenWindow.h: Added.
3076         * TestWebKitAPI/mac/OffscreenWindow.mm: Added.
3077         (-[OffscreenWindow initWithSize:]):
3078         (-[OffscreenWindow isKeyWindow]):
3079         (-[OffscreenWindow isVisible]):
3080         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3081         (TestWebKitAPI::PlatformWebView::initialize):
3082         (-[ActiveOffscreenWindow isKeyWindow]): Deleted.
3083         (-[ActiveOffscreenWindow isVisible]): Deleted.
3084         Factor ActiveOffscreenWindow out into OffscreenWindow and share it.
3085
3086 2019-01-15  Ryan Haddad  <ryanhaddad@apple.com>
3087
3088         Adjust the arguments passed to run-javascriptcore-tests for the 32-bit JSC bot
3089         https://bugs.webkit.org/show_bug.cgi?id=193459
3090
3091         Reviewed by Mark Lam.
3092
3093         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3094         (Run32bitJSCTests): This queue should not run JIT, testair, testb3, or testmasm.
3095
3096 2019-01-15  Chris Dumez  <cdumez@apple.com>
3097
3098         Regression(PSON) View becomes blank after click a cross-site download link
3099         https://bugs.webkit.org/show_bug.cgi?id=193361
3100         <rdar://problem/47099573>
3101
3102         Reviewed by Geoff Garen.
3103
3104         Add API test coverage.
3105
3106         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3107         (-[PSONNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3108
3109 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3110
3111         [LFC][Out-of-flow] Ignore bottom when the vertical values are over-constrained
3112         https://bugs.webkit.org/show_bug.cgi?id=193448
3113
3114         Reviewed by Antti Koivisto.
3115
3116         * LayoutReloaded/misc/LFC-passing-tests.txt:
3117
3118 2019-01-15  Jonathan Bedard  <jbedard@apple.com>
3119
3120         webkitpy: Implement device type specific expected results (Part 1)
3121         https://bugs.webkit.org/show_bug.cgi?id=192162
3122
3123         Reviewed by Lucas Forschler.
3124
3125         Device type specific expected results covers two related ideas. The first (covered by this change)
3126         is where to search for -expected.* files. The second is which tests to run based on the
3127         TestExpectations.txt file.
3128
3129         After this change, the baseline search path will be determined by the type of device running a
3130         test. Device type will be passed into any function which picks a file based on the baseline search
3131         path.
3132
3133         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3134         (Worker._update_test_input): Pass device_type to self._port.reference_files(...).
3135         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3136         (Manager.run): Print baseline search path for each round of devices.
3137         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3138         (SingleTestRunner.__init__): Pass device_type into expected_*(...).
3139         (SingleTestRunner._expected_driver_output): Ditto.
3140         (SingleTestRunner._driver_input): Ditto.
3141         * Scripts/webkitpy/layout_tests/views/printing.py:
3142         (Printer.print_config): Move printing of baseline search path to a separate function.
3143         (Printer.print_baseline_search_path): Moved from Printer.print_config.
3144         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3145         (Testprinter.test_print_config):
3146         (Testprinter.test_print_baseline_search_path):
3147         * Scripts/webkitpy/port/base.py:
3148         (Port.baseline_search_path): Pass device_type through.
3149         (Port._expected_baselines_for_suffixes): Ditto.
3150         (Port.expected_baselines): Ditto.
3151         (Port.expected_filename): Ditto.
3152         (Port.expected_checksum): Ditto.
3153         (Port.expected_image): Ditto.
3154         (Port.expected_audio): Ditto.
3155         (Port.expected_text): Ditto.
3156         (Port.reference_files): Ditto.
3157         (Port.tests): Ditto.
3158         (Port._expanded_paths): Ditto.
3159         (Port.skipped_layout_tests): Ditto.
3160         (Port.expectations_dict): Ditto.
3161         (Port._port_specific_expectations_files): Ditto.
3162         (Port.expectations_files): Ditto.
3163         (Port.test_search_path): Ditto.
3164         (Port._tests_for_other_platforms): Ditto.
3165         * Scripts/webkitpy/port/base_unittest.py:
3166         (PortTest.test_additional_platform_directory): Accept, but do not use, device_type.
3167         (PortTest.test_nonexistant_expectations): Ditto.
3168         (test_ref_tests_platform_directory): Ditto.
3169         * Scripts/webkitpy/port/darwin.py:
3170         (DarwinPort._port_specific_expectations_files): Accept device_type.
3171         * Scripts/webkitpy/port/driver.py:
3172         (DriverProxy):
3173         (DriverProxy.host): Expose _target_host for device_type information.
3174         * Scripts/webkitpy/port/gtk.py:
3175         (GtkPort._port_specific_expectations_files): Accept, but do not use, device_type.
3176         * Scripts/webkitpy/port/ios.py:
3177         (IOSPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3178         * Scripts/webkitpy/port/mac.py:
3179         (MacPort. default_baseline_search_path): Ditto.
3180         * Scripts/webkitpy/port/port_testcase.py:
3181         (TestWebKitPort._tests_for_other_platforms): Accept, but do not use, device_type.
3182         * Scripts/webkitpy/port/test.py:
3183         * Scripts/webkitpy/port/watch.py:
3184         (WatchPort. default_baseline_search_path): Remove memoized, since it does not accept **kwargs.
3185         * Scripts/webkitpy/port/win.py:
3186         (WinPort.test_search_path): Accept, but do not use, device_type.
3187         * Scripts/webkitpy/port/wpe.py:
3188         (WPEPort._port_specific_expectations_files): Ditto.
3189         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
3190         (get_test_baselines.AllPlatformsPort.baseline_search_path): Ditto.
3191
3192 2019-01-15  Zalan Bujtas  <zalan@apple.com>
3193
3194         [LFC] Use the containing block's padding box to position out-of-flow elements.
3195         https://bugs.webkit.org/show_bug.cgi?id=193431
3196
3197         Reviewed by Antti Koivisto.
3198
3199         * LayoutReloaded/misc/LFC-passing-tests.txt:
3200
3201 2019-01-14  Tim Horton  <timothy_horton@apple.com>
3202
3203         Move a test implementation file that got misplaced in the Xcode project
3204
3205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3206
3207 2019-01-14  Commit Queue  <commit-queue@webkit.org>
3208
3209         Unreviewed, rolling out r239901, r239909, r239910, r239912,
3210         r239913, and r239914.
3211         https://bugs.webkit.org/show_bug.cgi?id=193407
3212
3213         These revisions caused an internal failure (Requested by
3214         Truitt on #webkit).
3215
3216         Reverted changesets:
3217
3218         "[Cocoa] Avoid importing directly from subumbrella frameworks"
3219         https://bugs.webkit.org/show_bug.cgi?id=186016
3220         https://trac.webkit.org/changeset/239901
3221
3222         "Tried to fix USE(APPLE_INTERNAL_SDK) builds after r239901."
3223         https://trac.webkit.org/changeset/239909
3224
3225         "Tried to fix the build."
3226         https://trac.webkit.org/changeset/239910
3227
3228         "Fixed iOS builds after r239910."
3229         https://trac.webkit.org/changeset/239912
3230
3231         "More build fixing."
3232         https://trac.webkit.org/changeset/239913
3233
3234         "Tried to fix USE(APPLE_INTERNAL_SDK) 32-bit builds."
3235         https://trac.webkit.org/changeset/239914
3236
3237 2019-01-14  Mark Lam  <mark.lam@apple.com>
3238
3239         Re-enable ability to build --cloop builds.
3240         https://bugs.webkit.org/show_bug.cgi?id=192955
3241         <rdar://problem/46882363>
3242
3243         Reviewed by Saam barati and Keith Miller.
3244
3245         The --cloop build option was being ignored this whole time since r236381.
3246         This patch makes it possible to build CLoop builds again.
3247
3248         * Scripts/build-jsc:
3249         * Scripts/webkitperl/FeatureList.pm:
3250         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3251
3252 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3253
3254         webkitpy: Expose device_type from host-like objects
3255         https://bugs.webkit.org/show_bug.cgi?id=193406
3256         <rdar://problem/47262305>
3257
3258         Reviewed by Lucas Forschler.
3259
3260         Devices should expose device_type. As a result, all host objects should
3261         provide a device_type property, even if they do not yet define a device_type.
3262
3263         * Scripts/webkitpy/common/system/systemhost.py:
3264         (SystemHost):
3265         (SystemHost.device_type):
3266         * Scripts/webkitpy/common/system/systemhost_mock.py:
3267         (MockSystemHost):
3268         (MockSystemHost.device_type):
3269         * Scripts/webkitpy/port/device.py:
3270         (Device):
3271         (Device.device_type):
3272         * Scripts/webkitpy/xcode/simulated_device.py:
3273         (SimulatedDeviceManager._find_exisiting_device_for_request):
3274         (SimulatedDeviceManager._disambiguate_device_type):
3275         (SimulatedDeviceManager._does_fulfill_request):
3276         (SimulatedDeviceManager.device_count_for_type):
3277         (SimulatedDeviceManager.initialize_devices):
3278         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3279         (test_available_devices):
3280         (test_swapping_devices):
3281
3282 2019-01-14  Jonathan Bedard  <jbedard@apple.com>
3283
3284         webkitpy: Support alternate simctl device list output (Follow-up fix)
3285         https://bugs.webkit.org/show_bug.cgi?id=193362
3286         <rdar://problem/47122965>
3287
3288         Rubber-stamped by Lucas Forschler.
3289
3290         * Scripts/webkitpy/xcode/simulated_device.py:
3291         (SimulatedDeviceManager.populate_available_devices):
3292
3293 2019-01-14  Wenson Hsieh  <wenson_hsieh@apple.com>
3294
3295         [iOS] Expose SPI to access the current sentence boundary and selection state
3296         https://bugs.webkit.org/show_bug.cgi?id=193398
3297         <rdar://problem/45893108>
3298
3299         Reviewed by Dean Jackson.
3300
3301         Add an API test to verify that an SPI client can observe changes in the `@"_selectionAttributes"` key path on
3302         WKWebView, and that inserting text, deleting, and changing the selection cause selection attributes to change as
3303         expected.
3304
3305         * TestWebKitAPI/EditingTestHarness.h:
3306         * TestWebKitAPI/EditingTestHarness.mm:
3307         (-[EditingTestHarness moveBackward]):
3308         (-[EditingTestHarness moveForward]):
3309         (-[EditingTestHarness moveForwardAndExpectEditorStateWith:]):
3310
3311         Add a couple of new helper methods on EditingTestHarness.
3312
3313         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
3314         (-[SelectionChangeObserver initWithWebView:]):
3315         (-[SelectionChangeObserver webView]):
3316         (-[SelectionChangeObserver observeValueForKeyPath:ofObject:change:context:]):
3317         (-[SelectionChangeObserver currentSelectionAttributes]):
3318
3319 2019-01-14  Zalan Bujtas  <zalan@apple.com>
3320
3321         [LFC][BFC] Add basic box-sizing support.
3322         https://bugs.webkit.org/show_bug.cgi?id=193392
3323
3324         Reviewed by Antti Koivisto.
3325
3326         * LayoutReloaded/misc/LFC-passing-tests.txt:
3327
3328 2019-01-14  Charlie Turner  <cturner@igalia.com>
3329
3330         [WPE] API test gardening
3331         https://bugs.webkit.org/show_bug.cgi?id=193319
3332
3333         Reviewed by Michael Catanzaro.
3334
3335         * TestWebKitAPI/glib/TestExpectations.json: Remove some now
3336         passing tests.
3337
3338 2019-01-14  Charlie Turner  <cturner@igalia.com>
3339
3340         [GStreamer] Add sharedBuffer utility to GstMappedBuffer, and a testsuite
3341         https://bugs.webkit.org/show_bug.cgi?id=192977
3342
3343         Reviewed by Carlos Garcia Campos.
3344
3345         * TestWebKitAPI/PlatformGTK.cmake: Build the new GStreamer test harness
3346         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3347         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.cpp: Added.
3348         (TestWebKitAPI::GStreamerTest::SetUp):
3349         (TestWebKitAPI::GStreamerTest::TearDown):
3350         * TestWebKitAPI/Tests/WebCore/gstreamer/GStreamerTest.h: Added.
3351         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp: Added.
3352         (TestWebKitAPI::TEST_F):
3353
3354 2019-01-14  Charlie Turner  <cturner@igalia.com>
3355
3356         [WPE] Workaround for incorrect template specialization being selected when UChar=char16_t
3357         https://bugs.webkit.org/show_bug.cgi?id=193332
3358
3359         Reviewed by Michael Catanzaro.
3360
3361         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: When UChar is
3362         defined as a char16_t, which changed in ICU 59, the
3363         StringTypeAdapter<UnsignedInt, ...> overload catches casts to
3364         unsigned short. This test is relying on the behaviour that
3365         UChar=unsigned short, which doesn't hold across platforms and ICU
3366         library versions. The full fix would be a special syntax for
3367         literal characters so that these ambiguities do not arise. That
3368         work is proposed in https://bugs.webkit.org/show_bug.cgi?id=193101.
3369         (TestWebKitAPI::TEST):
3370
3371 2019-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
3372
3373         Unreviewed. [GTK][WPE] Run distcheck with gtkdoc and MiniBrowser enabled
3374
3375         * Scripts/make-dist:
3376         (Distcheck.configure):
3377
3378 2019-01-13  Aakash Jain  <aakash_jain@apple.com>
3379
3380         [ews-build] Update macOS queue configurations
3381         https://bugs.webkit.org/show_bug.cgi?id=193365
3382         <rdar://problem/47221073>
3383
3384         Unreviewed, renamed mac-high-sierra to mac-highsierra to match with build.webkit.org configuration.
3385
3386         * BuildSlaveSupport/ews-build/config.json:
3387
3388 2019-01-13  Zalan Bujtas  <zalan@apple.com>
3389
3390         [LFC] Adjust assert for statically positioned fixed elements
3391         https://bugs.webkit.org/show_bug.cgi?id=193385
3392
3393         Reviewed by Antti Koivisto.
3394
3395         * LayoutReloaded/misc/LFC-passing-tests.txt:
3396
3397 2019-01-13  Philippe Normand  <pnormand@igalia.com>
3398
3399         [WPE][MiniBrowser] Ephemeral WebContext leaks in automation mode
3400         https://bugs.webkit.org/show_bug.cgi?id=193387
3401
3402         Reviewed by Carlos Garcia Campos.
3403
3404         * MiniBrowser/wpe/main.cpp:
3405         (main):
3406
3407 2019-01-12  Timothy Hatcher  <timothy@apple.com>
3408
3409         Have prefers-color-scheme: light always match on macOS versions before Mojave.
3410         https://bugs.webkit.org/show_bug.cgi?id=191655
3411         rdar://problem/46074680
3412
3413         Reviewed by Megan Gardner.
3414
3415         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: ENABLE_DARK_MODE_CSS_macosx for all OS versions.
3416         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
3417
3418 2019-01-12  Dan Bernstein  <mitz@apple.com>
3419
3420         [Cocoa] Avoid importing directly from subumbrella frameworks
3421         https://bugs.webkit.org/show_bug.cgi?id=186016
3422         <rdar://problem/40591038>
3423
3424         Reviewed by Sam Weinig.
3425
3426         * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Include CoreServices.h instead of a
3427           LaunchServices header.
3428         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3429           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3430         * DumpRenderTree/mac/LayoutTestHelper.m: Import ApplicationServices.h instead of ColorSync.h
3431           when using SDKs earlier than 10.13.
3432         * TestWebKitAPI/Configurations/Base.xcconfig: Removed -iframework options from OTHER_CFLAGS
3433           and OTHER_CPLUSPLUSFLAGS.
3434         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Removed -iframework options from
3435           OTHER_CFLAGS and OTHER_CPLUSPLUSFLAGS.
3436         * WebKitTestRunner/cg/TestInvocationCG.cpp: Include CoreServices.h instead of a
3437           LaunchServices header.
3438
3439 2019-01-11  John Wilander  <wilander@apple.com>
3440
3441         Compile out Web API Statistics Collection
3442         https://bugs.webkit.org/show_bug.cgi?id=193370
3443         <rdar://problem/45388584>
3444
3445         Reviewed by Brent Fulgham.
3446
3447         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3448             Defined ENABLE_WEB_API_STATISTICS, off by default.
3449
3450 2019-01-11  Carlos Eduardo Ramalho  <cadubentzen@gmail.com>
3451
3452         [WPE] Add gtk-doc
3453         https://bugs.webkit.org/show_bug.cgi?id=178900
3454
3455         Reviewed by Michael Catanzaro.
3456
3457         Add Tools/gtkdoc to manifest.txt.in files.
3458         This should have been done in r238853 and caused failure in building WebKitGTK+ unstable release 2.23.2.
3459
3460         * gtk/manifest.txt.in: Add Tools/gtkdoc directory.
3461         * wpe/manifest.txt.in: Add Tools/gtkdoc directory and uncomment lines to move documentation artifacts.
3462
3463 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3464
3465         [iOS] Precision drop state thrashes when dragging near the top edge of an editable element
3466         https://bugs.webkit.org/show_bug.cgi?id=193364
3467         <rdar://problem/47214117>
3468
3469         Reviewed by Tim Horton.
3470
3471         Add a test to verify that dragging near the top of a textarea element does not flag the drop proposal as
3472         precise, whereas dragging near the middle of the textarea does.
3473
3474         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
3475         (TestWebKitAPI::TEST):
3476
3477 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3478
3479         webkitpy: Support alternate simctl device list output
3480         https://bugs.webkit.org/show_bug.cgi?id=193362
3481         <rdar://problem/47122965>
3482
3483         Reviewed by Lucas Forschler.
3484
3485         * Scripts/webkitpy/xcode/simulated_device.py:
3486         (SimulatedDeviceManager.populate_available_devices):
3487
3488 2019-01-11  Aakash Jain  <aakash_jain@apple.com>
3489
3490         [ews-build] Update macOS queue configurations
3491         https://bugs.webkit.org/show_bug.cgi?id=193365
3492
3493         Reviewed by Lucas Forschler.
3494
3495         * BuildSlaveSupport/ews-build/config.json:
3496
3497 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3498
3499         webkitpy: Incorporate device type into baseline search path
3500         https://bugs.webkit.org/show_bug.cgi?id=193356
3501         <rdar://problem/47215515>
3502
3503         Reviewed by Lucas Forschler.
3504
3505         We need a way to include device type in the baseline search path for iOS to support device specific test expectations.
3506
3507         * Scripts/webkitpy/port/base.py:
3508         (Port.default_baseline_search_path): Allow device type to be passed in.
3509         * Scripts/webkitpy/port/gtk.py:
3510         (GtkPort.default_baseline_search_path): Ignore device type.
3511         * Scripts/webkitpy/port/ios.py:
3512         (IOSPort.default_baseline_search_path): Optionally allow device type to be incorporated into the baseline search path.
3513         (IOSPort.test_expectations_file_position): Update index for the additional device-type specific baseline search path.
3514         * Scripts/webkitpy/port/ios_device_unittest.py:
3515         (IOSDeviceTest):
3516         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3517         (IOSSimulatorTest):
3518         * Scripts/webkitpy/port/mac.py:
3519         (MacPort.default_baseline_search_path): Ignore device type.
3520         * Scripts/webkitpy/port/watch.py:
3521         (WatchPort.default_baseline_search_path): Ditto.
3522         * Scripts/webkitpy/port/win.py:
3523         (WinPort.default_baseline_search_path): Ditto.
3524         (WinCairoPort.default_baseline_search_path): Ditto.
3525         * Scripts/webkitpy/port/wpe.py:
3526         (WPEPort.default_baseline_search_path): Ditto.
3527
3528 2019-01-11  Jonathan Bedard  <jbedard@apple.com>
3529
3530         webkitpy: Print abbreviated baseline search path that includes only folders that exist
3531         https://bugs.webkit.org/show_bug.cgi?id=193352
3532         <rdar://problem/47210736>
3533
3534         Reviewed by Lucas Forschler.
3535
3536         * Scripts/webkitpy/layout_tests/views/printing.py:
3537         (Printer.print_config): Print list on only baseline search paths which exist. 
3538         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3539         (Testprinter.test_print_config):
3540
3541 2019-01-11  Joseph Pecoraro  <pecoraro@apple.com>
3542
3543         Cleanup possible WK*Copy/Create leaks in WebKitTestRunner
3544         https://bugs.webkit.org/show_bug.cgi?id=193340
3545
3546         Reviewed by David Kilzer.
3547
3548         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3549         (WTR::InjectedBundle::didReceiveMessageToPage):
3550         Pull the strings out into a WKRetainPtr.
3551
3552         * WebKitTestRunner/WebNotificationProvider.cpp:
3553         (WTR::WebNotificationProvider::closeWebNotification):
3554         Adopt the created value into the WKRetainPtr.
3555
3556         * WebKitTestRunner/mac/TestControllerMac.mm:
3557         (WTR::generateWhitelist):
3558         Immediately adopt a created value to avoid potential mistakes.
3559
3560 2019-01-11  Dominik Infuehr  <dinfuehr@igalia.com>
3561
3562         Enable DFG on ARM/Linux again
3563         https://bugs.webkit.org/show_bug.cgi?id=192496
3564
3565         Reviewed by Yusuke Suzuki.
3566
3567         After changing the bytecode format DFG was disabled on all 32-bit
3568         architectures. Enable DFG now again on ARM/Linux. Run again JIT-tests
3569         on ARM by default.
3570
3571         * Scripts/run-jsc-stress-tests:
3572
3573 2019-01-11  Timothy Hatcher  <timothy@apple.com>
3574
3575         Unreviewed, fix #ifdef in API test added in r239851.
3576         https://bugs.webkit.org/show_bug.cgi?id=193327
3577         rdar://problem/47093222
3578
3579         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
3580
3581 2019-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
3582
3583         Introduce IDL files for runtime-enabled UndoManager and UndoItem JavaScript API
3584         https://bugs.webkit.org/show_bug.cgi?id=193109
3585         <rdar://problem/44807048>
3586
3587         Reviewed by Ryosuke Niwa.
3588
3589         Introduce and respect a test option to enable the UndoManager API.
3590
3591         * WebKitTestRunner/TestController.cpp:
3592         (WTR::updateTestOptionsFromTestHeader):
3593         * WebKitTestRunner/TestOptions.h:
3594         (WTR::TestOptions::hasSameInitializationOptions const):
3595         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3596         (WTR::TestController::platformCreateWebView):
3597
3598 2019-01-11  Zalan Bujtas  <zalan@apple.com>
3599
3600         [LFC][BFC][MarginCollapsing] Adjust vertical position when box margin collapses through.
3601         https://bugs.webkit.org/show_bug.cgi?id=193346
3602
3603         Reviewed by Antti Koivisto.
3604
3605         * LayoutReloaded/misc/LFC-passing-tests.txt:
3606
3607 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3608
3609         Unreviewed, fix typo that breaks dashboard link.
3610
3611         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3612         (WebKitBuildbot):
3613
3614 2019-01-10  Ryan Haddad  <ryanhaddad@apple.com>
3615
3616         Update macOS queue configurations
3617         https://bugs.webkit.org/show_bug.cgi?id=193329
3618
3619         Reviewed by Alexey Proskuryakov.
3620
3621         * BuildSlaveSupport/build.webkit.org-config/config.json:
3622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3623         (BubbleQueueServer):
3624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3626         (WebKitBuildbot):
3627         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3628         (table.queue-grid tr.platform.macos-sierra img.logo): Deleted.
3629         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3630
3631 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3632
3633         MiniBrowser should be able to navigate to about:blank
3634         https://bugs.webkit.org/show_bug.cgi?id=193345
3635
3636         Reviewed by Simon Fraser.
3637
3638         * MiniBrowser/mac/BrowserWindowController.m:
3639         (-[BrowserWindowController addProtocolIfNecessary:]):
3640         Don't prepend "http://" to "about:" prefixed URLs like "about:blank".
3641
3642         * MiniBrowser/mac/WK1BrowserWindowController.m:
3643         (-[WK1BrowserWindowController fetch:]):
3644         * MiniBrowser/mac/WK2BrowserWindowController.m:
3645         (-[WK2BrowserWindowController fetch:]):
3646         Clean up the code that uses this to match style.
3647
3648 2019-01-10  Joseph Pecoraro  <pecoraro@apple.com>
3649
3650         Remove MiniBrowser custom "Process Swap" menu item which does not work
3651         https://bugs.webkit.org/show_bug.cgi?id=193344
3652
3653         Reviewed by Simon Fraser.
3654
3655         There is a menu item under the Experimental menu that does work.
3656
3657         * MiniBrowser/mac/AppDelegate.m:
3658         (defaultConfiguration):
3659         * MiniBrowser/mac/SettingsController.h:
3660         * MiniBrowser/mac/SettingsController.m:
3661         (-[SettingsController _populateMenu]):
3662         (-[SettingsController validateMenuItem:]):
3663         (-[SettingsController processSwapOnNavigationEnabled]): Deleted.
3664         (-[SettingsController toggleProcessSwapOnNavigation:]): Deleted.
3665
3666 2019-01-10  Timothy Hatcher  <timothy@apple.com>
3667
3668         Add WKBundlePage SPI to temporarily force light or dark appearance on a page.
3669         https://bugs.webkit.org/show_bug.cgi?id=193327
3670         rdar://problem/47093222
3671
3672         Reviewed by Tim Horton.
3673
3674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3675         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm: Added.
3676         (TestWebKitAPI::didFinishNavigation):
3677         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
3678         (TestWebKitAPI::TEST):
3679         * TestWeb