Another buid fix for master.cfg.
[WebKit-https.git] / Tools / ChangeLog
1 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
2
3         Another buid fix for master.cfg.
4
5         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
6         (CompileWebKit.start):
7
8 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
9
10         Another buid fix for master.cfg.
11
12         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
13         (CompileWebKit.start):
14
15 2016-06-19  Lucas Forschler  <lforschler@apple.com>
16
17         Fix master.cfg
18         
19         Unreviewed build fix.
20
21         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
22         (CompileWebKit.start):
23
24 2016-06-19  Lucas Forschler  <lforschler@apple.com>
25
26         Test another commit.
27         
28         Unreviewed.
29
30 2016-06-19  Lucas Forschler  <lforschler@apple.com>
31
32         Testing fix for trac-mirror.
33         
34         Unreviewed.
35
36 2016-06-19  Lucas Forschler  <lforschler@apple.com>
37
38         Test a commit against the SVN 1.9 server upgrade.
39         
40         Unreviewed.
41         
42 2016-06-17  Daniel Bates  <dabates@apple.com>
43
44         Unreviewed, rolling out r202186.
45
46         Broke the Apple Windows, Apple Yosemite, GTK, and WinCairo
47         builds.
48
49         Reverted changeset:
50
51         "File scheme should not allow access of a resource on a
52         different volume."
53         https://bugs.webkit.org/show_bug.cgi?id=158552
54         http://trac.webkit.org/changeset/202186
55
56 2016-06-17  Pranjal Jumde  <pjumde@apple.com>
57
58         File scheme should not allow access of a resource on a different volume.
59         https://bugs.webkit.org/show_bug.cgi?id=158552
60         <rdar://problem/15307582>
61
62         Reviewed by Brent Fulgham.
63
64         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
65         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
66         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
67         (-[CrossPartitionFileSchemeAccessNavigationDelegate webView:didFinishNavigation:]):
68         When the main page load is complete fetch the contents of the document to check if iframe was loaded
69         (createPartition):
70         Create a disk image and load the contents of the file.
71         (cleanUp):
72         (TestWebKitAPI::TEST):
73
74 2016-06-17  Enrique Ocaña González  <eocanha@igalia.com>
75
76         Unreviewed. Added myself to the list of committers.
77
78         * Scripts/webkitpy/common/config/contributors.json:
79
80 2016-06-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
81
82         [EFL][GTK] LayoutTest doesn't run on Ubuntu 16.04
83         https://bugs.webkit.org/show_bug.cgi?id=158141
84
85         Reviewed by Michael Catanzaro.
86
87         * Scripts/webkitpy/port/base.py: Detect php version in system, then use it.
88         (Port._is_debian_php_version_7):
89         (Port._debian_php_version):
90         (Port._apache_config_file_name_for_platform):
91         * efl/install-dependencies:
92         * gtk/install-dependencies:
93
94 2016-06-16  Filip Pizlo  <fpizlo@apple.com>
95
96         Baseline JIT should be concurrent
97         https://bugs.webkit.org/show_bug.cgi?id=158755
98
99         Reviewed by Geoffrey Garen.
100         
101         Need to disable concurrent JIT when running profiler tests. We should have been doing this
102         all along.
103
104         * Scripts/run-jsc-stress-tests:
105
106 2016-06-16  Per Arne Vollan  <pvollan@apple.com>
107
108         [Win] Accessibility implementation unable to recurse through document (sometimes) to find named elements
109         https://bugs.webkit.org/show_bug.cgi?id=140798
110
111         Reviewed by Brent Fulgham.
112        
113         Make sure layout is up-to-date before trying to find named elements. 
114
115         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
116         (AccessibilityController::rootElement):
117
118 2016-06-16  Chris Dumez  <cdumez@apple.com>
119
120         Unreviewed, rolling out r202002 and r202111.
121
122         Ryosuke says this was a JSBench regression on iOS
123
124         Reverted changesets:
125
126         "Make HashMap and HashSet work with Refs"
127         https://bugs.webkit.org/show_bug.cgi?id=158638
128         http://trac.webkit.org/changeset/202002
129
130         "Improve HashMap and HashSet support for Ref"
131         https://bugs.webkit.org/show_bug.cgi?id=158789
132         http://trac.webkit.org/changeset/202111
133
134 2016-06-15  Simon Fraser  <simon.fraser@apple.com>
135
136         [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location
137         https://bugs.webkit.org/show_bug.cgi?id=158828
138
139         Reviewed by Enrica Casucci.
140         
141         Expose "forceIPadStyleZoomOnInputFocus" on UIScriptController, which allows iPad-style
142         zooming behavior on <input> focus in the iPhone simulator, which is used for testing.
143
144         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
145         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
146         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
147         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
148         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
149         * WebKitTestRunner/ios/TestControllerIOS.mm:
150         (WTR::TestController::platformResetStateToConsistentValues):
151         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
152         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
153         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
154
155 2016-06-15  Sam Weinig  <sam@webkit.org>
156
157         Forward/Back keyboard shortcuts need to flip for RTL
158         https://bugs.webkit.org/show_bug.cgi?id=158823
159         <rdar://problem/25975359>
160
161         Reviewed by Darin Adler.
162
163         Add tests for flipping the behavior of command-left and command-right
164         under RTL mode.
165
166         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
167         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Added.
168         (-[CommandBackForwardOffscreenWindow isKeyWindow]):
169         (-[CommandBackForwardOffscreenWindow isVisible]):
170         (simulateCommandArrow):
171         (WebKit2_CommandBackForwardTest::SetUp):
172         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame):
173         (WebKit2_CommandBackForwardTestWKView::SetUp):
174         (WebKit2_CommandBackForwardTestWKView::loadFiles):
175         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]):
176         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
177         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
178
179 2016-06-15  Tim Horton  <timothy_horton@apple.com>
180
181         Expose _shouldExpandContentToViewHeightForAutoLayout SPI on WKWebView
182         https://bugs.webkit.org/show_bug.cgi?id=158824
183         <rdar://problem/23713857>
184
185         Reviewed by Simon Fraser.
186
187         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
188         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
189         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
190         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
191         (TEST):
192         Add a test for _shouldExpandContentToViewHeightForAutoLayout.
193
194 2016-06-13  Simon Fraser  <simon.fraser@apple.com>
195
196         [iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
197         https://bugs.webkit.org/show_bug.cgi?id=158714
198
199         Reviewed by Enrica Casucci.
200
201         Add UIScriptController.keyboardAccessoryBar{Next,Previous} and hook it up to the WKContentView
202         method that gets called from UIKit.
203
204         Add a test that exercises it.
205
206         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
207         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
208         (WTR::UIScriptController::keyboardAccessoryBarNext):
209         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
210         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
211         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
212         (WTR::UIScriptController::keyboardAccessoryBarNext):
213         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
214
215 2016-06-15  Sam Weinig  <sam@webkit.org>
216
217         Improve HashMap and HashSet support for Ref
218         https://bugs.webkit.org/show_bug.cgi?id=158789
219
220         Reviewed by Chris Dumez.
221
222         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
223         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
224         Add more cases to WTF_HashMap.Ref_Key, WTF_HashMap.Ref_Value and WTF_HashSet.Ref
225
226 2016-06-15  Aakash Jain  <aakash_jain@apple.com>
227
228         Too much log data generated during layout-tests on iOS Simulator
229         https://bugs.webkit.org/show_bug.cgi?id=158751
230
231         Reviewed by Alexey Proskuryakov.
232
233         * Scripts/webkitpy/port/ios.py:
234         (IOSSimulatorPort.developer_dir): memoized the property so that it is not called
235         repeatedly.
236
237 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
238
239         [Win][CMake] Changes in WebKit options are not reflected in incremental builds.
240         https://bugs.webkit.org/show_bug.cgi?id=158727
241
242         Reviewed by Alex Christensen.
243
244         Delete CMake cache file if WebKit options have been modified.
245
246         * Scripts/build-webkit:
247         * Scripts/webkitdirs.pm:
248         (shouldRemoveCMakeCache):
249
250 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
251
252         Enabling Shadow DOM for all platforms
253         https://bugs.webkit.org/show_bug.cgi?id=158738
254
255         Reviewed by Ryosuke Niwa.
256
257         Removed Shadow DOM from options (enabled by default)
258
259         * Scripts/webkitperl/FeatureList.pm:
260         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
261
262 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
263
264         [Win] The test accessibility/selected-text-range-aria-elements.html is failing.
265         https://bugs.webkit.org/show_bug.cgi?id=158732
266
267         Reviewed by Brent Fulgham.
268
269         Implement selectedTextRange() method.
270
271         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
272         (AccessibilityUIElement::selectedTextRange):
273
274 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
275
276         [Win] MiniBrowser is not DPI aware.
277         https://bugs.webkit.org/show_bug.cgi?id=158733
278
279         Reviewed by Brent Fulgham.
280
281         Call Win32 api function to let Windows know that we will scale the contents ourselves.
282
283         * MiniBrowser/win/WinMain.cpp:
284         (wWinMain):
285
286 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
287
288         Unreviewed: add new email address to contributors.json.
289
290         * Scripts/webkitpy/common/config/contributors.json:
291
292 2016-06-14  Keith Miller  <keith_miller@apple.com>
293
294         JSBench should use geometric mean
295         https://bugs.webkit.org/show_bug.cgi?id=158775
296
297         Reviewed by Mark Lam.
298
299         For some reason JSBench was using algebraic mean. Since each test
300         is pretty substantially different it should use geometric mean
301         instead.
302
303         * Scripts/run-jsc-benchmarks:
304
305 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
306
307         Debug crash logs are not fully symbolicated on Yosemite
308         https://bugs.webkit.org/show_bug.cgi?id=158760
309
310         Reviewed by Darin Adler.
311
312         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
313         for debug builds on Yosemite.
314
315 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
316
317         Tests don't work in iOS Simulator when ASan is enabled
318         https://bugs.webkit.org/show_bug.cgi?id=158726
319
320         Reviewed by David Kilzer.
321
322         * Scripts/webkitpy/port/driver.py:
323         (Driver._setup_environ_for_driver): Added a FIXME.
324         * Scripts/webkitpy/port/ios.py:
325         (IOSSimulatorPort.setup_environ_for_server): Don't try to insert a dylib built for
326         simulator into LayoutTestRelay, which is a macOS tool.
327
328 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
329
330         Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
331         https://bugs.webkit.org/show_bug.cgi?id=158756
332
333         Reviewed by Alexey Proskuryakov.
334
335         * Scripts/webkitpy/xcode/simulator.py:
336         (Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
337         the "simulator device" is still in booted state. Since we ensured that simulator device 
338         was in booted state earlier in this method, this indicates that simulator device has shut down
339         unexpectedly.
340
341 2016-06-14  David Kilzer  <ddkilzer@apple.com>
342
343         Follow-up fix #2: REGRESSION (r202020): El Capitan CMake Debug build broken
344         <https://webkit.org/b/158743>
345
346         Unreviewed build fix.
347
348         * DumpRenderTree/PlatformMac.cmake: Fix silly typo.
349
350 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
351
352         Too much log data generated during layout-tests on iOS Simulator
353         https://bugs.webkit.org/show_bug.cgi?id=158751
354
355         Reviewed by Alexey Proskuryakov.
356
357         * Scripts/webkitpy/port/ios.py:
358         (IOSSimulatorPort._quit_ios_simulator): Do not use -v flag.
359         (IOSSimulatorPort.clean_up_test_run): Ditto.
360         (IOSSimulatorPort._createSimulatorApp): Ditto.
361
362 2016-06-14  David Kilzer  <ddkilzer@apple.com>
363
364         Follow-up fix: REGRESSION (r202020): El Capitan CMake Debug build broken
365         <https://webkit.org/b/158743>
366
367         Unreviewed build fix.
368
369         The fix in r202056 clobbered DumpRenderTree_SOURCES and
370         TestNetscapePlugin_SOURCES from DumpRenderTree/CMakeLists.txt,
371         so the build failure is now that we're not building the common
372         sources.
373
374         Fix that by saving the common sources (which are all C++ source
375         files) into *_Cpp_SOURCES lists first, then setting the compiler
376         flags, then creating the final *_SOURCES lists.
377
378         * DumpRenderTree/PlatformMac.cmake: Add
379         ${TestNetscapePlugin_Cpp_SOURCES} to list that needs
380         "-std=c++14" compiler switch.
381         (TestNetscapePlugin_Cpp_SOURCES): Add new list for C++ source
382         files for TestNetscapePlugin.  Seeded with
383         ${TestNetscapePlugin_SOURCES} from CMakeLists.txt.
384         (TestNetscapePlugin_SOURCES): Add
385         ${TestNetscapePlugin_Cpp_SOURCES} to the list of files.
386         (DumpRenderTree_Cpp_SOURCES): Seed list for C++ source files
387         with ${DumpRenderTree_SOURCES} from CMakeLists.txt.
388         (DumpRenderTree_SOURCES): Reformat and sort source lists.
389
390 2016-06-14  David Kilzer  <ddkilzer@apple.com>
391
392         REGRESSION (r202020): El Capitan CMake Debug build broken
393         <https://webkit.org/b/158743>
394
395         Reviewed by Alex Christensen.
396
397         The bug was that pure C++ source files (and Objective-C source
398         files) were being compiled as Objective-C++ source files.  This
399         is obviously incorrect, so the fix was to split out the list of
400         source files by language, then define compiler switches based on
401         each file type.
402
403         * DumpRenderTree/PlatformMac.cmake: Replace add_definitions()
404         with separate foreach loops that set compiler flags based on
405         each source file's type.
406         (TestNetscapePlugin_ObjCpp_SOURCES): Rename from
407         TestNetscapePlugin_SOURCES.
408         (TestNetscapePlugin_SOURCES): Create based on
409         ${TestNetscapePlugin_ObjCpp_SOURCES}.
410         (DumpRenderTree_ObjC_SOURCES): Split from DumpRenderTree_SOURCES.
411         (DumpRenderTree_Cpp_SOURCES): Ditto.
412         (DumpRenderTree_ObjCpp_SOURCES): Ditto.
413         (DumpRenderTree_SOURCES): Create from above three lists.
414
415 2016-06-14  Lucas Forschler  <lforschler@apple.com>
416
417         <rdar://problem/26685782>
418         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
419
420         Rubber-stamped by Jessie Berlin.
421
422         * Scripts/copy-webkitlibraries-to-product-directory:
423
424 2016-06-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
425
426         Activate CMake export compile commands option
427         https://bugs.webkit.org/show_bug.cgi?id=158734
428
429         Reviewed by Alex Christensen.
430
431         * Scripts/webkitdirs.pm:
432         (generateBuildSystemFromCMakeProject): Activating this option for all CMake builds.
433         This allows using ymcd for WebKit hacking.
434
435 2016-06-14  David Kilzer  <ddkilzer@apple.com>
436
437         Modernize DumpRenderTreeMac.h
438         <https://webkit.org/b/158721>
439
440         Reviewed by Andy Estes.
441
442         * DumpRenderTree/mac/DumpRenderTreeMac.h:
443         - Update copyright.
444         - Update license.
445         - Use #pragma once.
446         - Use OBJC_CLASS macro.
447
448 2016-06-13  David Kilzer  <ddkilzer@apple.com>
449
450         False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm
451         <https://webkit.org/b/158716>
452
453         Reviewed by Andy Estes.
454
455         * DumpRenderTree/mac/DumpRenderTree.mm:
456         (destroyWebViewAndOffscreenWindow): Change this function to take
457         a WebView, and assert that it's the same as [mainFrame webView].
458         (dumpRenderTree): Pass 'webView' into
459         destroyWebViewAndOffscreenWindow().
460         * DumpRenderTree/mac/DumpRenderTreeMac.h:
461         (createWebViewAndOffscreenWindow): Add NS_RETURNS_RETAINED since
462         this function returns a +1 WebView.  Declare this method only for
463         Objective-C[++] source.
464
465 2016-06-13  Sam Weinig  <sam@webkit.org>
466
467         Make HashMap and HashSet work with Refs
468         https://bugs.webkit.org/show_bug.cgi?id=158638
469
470         Reviewed by Darin Adler.
471
472         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
473         (TestWebKitAPI::TEST):
474         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
475         (TestWebKitAPI::TEST):
476         Add tests for using Refs in HashMaps (both as key and value) and HashSets.
477
478 2016-06-13  Mark Lam  <mark.lam@apple.com>
479
480         Add a mechanism for collecting LLINT stats.
481         https://bugs.webkit.org/show_bug.cgi?id=158668
482
483         Reviewed by Filip Pizlo.
484
485         * DumpRenderTree/mac/DumpRenderTree.mm:
486         (DumpRenderTreeMain):
487
488 2016-06-13  Romain Bellessort  <romain.bellessort@crf.canon.fr>
489
490         [GTK] Enabling Shadow DOM by default
491         https://bugs.webkit.org/show_bug.cgi?id=158686
492
493         Reviewed by Carlos Garcia Campos.
494
495         Added support for enabling Shadow DOM by default for GTK.
496         Changed GTK test expectations for fast/shadow-dom tests (most tests
497         pass).
498
499         * Scripts/webkitperl/FeatureList.pm:
500
501 2016-06-12  Aakash Jain  <aakash_jain@apple.com>
502
503         run-safari/run-webkit-app fail to quit iOS simulator after Xcode installation
504         https://bugs.webkit.org/show_bug.cgi?id=158651
505         rdar://problem/26499824
506
507         Reviewed by Daniel Bates.
508
509         This change is to make our tools more robust. Sometimes run-safari/run-webkit-app fails 
510         to start the tests as one of the first thing these scripts do is to relaunch iOS Simulators,
511         and in process call quitIOSSimulator. In case the Simulator is not registered in LaunchServices
512         for some reason, quitIOSSimulator fails and the script stops. This change will make the scripts
513         still continue when they fail to quit iOS Simuator, and modify the way Simulator is opened, 
514         so that Simulator is implicitly registered with LaunchServices while opening it.
515
516         * Scripts/webkitdirs.pm:
517         (relaunchIOSSimulator):
518         Launch iOS Simulator using complete path. Partially reverting http://trac.webkit.org/changeset/184202.
519         (quitIOSSimulator):
520         Do not die if quitting ios Simulator fails, so that relaunchIOSSimulator can still 
521         attempt to launch the simulator.
522         (waitUntilIOSSimulatorDeviceIsInState):
523         Added a FIXME.
524
525 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
526
527         Addressing post-review comments after r201978.
528         https://bugs.webkit.org/show_bug.cgi?id=158649
529         <rdar://problem/13258122>
530
531         Unreviewed.
532
533         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
534         (TestWebKitAPI::TEST):
535
536 2016-06-11  Alexey Proskuryakov  <ap@apple.com>
537
538         Unreviewed leak fix after r201863.
539
540         * DumpRenderTree/mac/DumpRenderTree.mm:
541         (dumpFramesAsText):
542
543 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
544
545         [Cocoa] Map commonly used Chinese Windows font names to names present on Cocoa operating systems
546         https://bugs.webkit.org/show_bug.cgi?id=158649
547         <rdar://problem/13258122>
548
549         Reviewed by Darin Adler.
550
551         * TestWebKitAPI/Tests/WTF/WTFString.h:
552         (TestWebKitAPI::TEST):
553
554 2016-06-10  Alex Christensen  <achristensen@webkit.org>
555
556         Fix CMake build.
557
558         * TestWebKitAPI/PlatformMac.cmake:
559
560 2016-06-10  Filip Pizlo  <fpizlo@apple.com>
561
562         Rename JSAir to Air.js
563
564         Rubber stamped by Mark Lam.
565
566         * Scripts/run-javascriptcore-tests:
567
568 2016-06-10  Filip Pizlo  <fpizlo@apple.com>
569
570         JSC Stress Test failing: jsair-tests.yaml/test.js.ftl-eager-no-cjit
571         https://bugs.webkit.org/show_bug.cgi?id=158571
572
573         Reviewed by Keith Miller.
574         
575         Unskip the JSAir test.
576
577         * Scripts/run-javascriptcore-tests:
578         (runJSCStressTests):
579
580 2016-06-10  Sam Weinig  <sam@webkit.org>
581
582         Re-disable the UserMedia tests which are timing out.
583
584         They used to be accidentally disabled, due to not including
585         the FeatureDefines correctly, but not we explicitly disable it.
586
587         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
588         (TestWebKitAPI::TEST):
589
590 2016-06-10  Alex Christensen  <achristensen@webkit.org>
591
592         Introduce WTF::UniqueRef
593         https://bugs.webkit.org/show_bug.cgi?id=158596
594
595         Reviewed by Brady Eidson.
596
597         * TestWebKitAPI/CMakeLists.txt:
598         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
599         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp: Added.
600         (TestWebKitAPI::B::B):
601         (TestWebKitAPI::C::C):
602         (TestWebKitAPI::function):
603         (TestWebKitAPI::TEST):
604
605 2016-06-10  Sam Weinig  <sam@webkit.org>
606
607         Refactor TestWebKitAPI to allow just testing WTF
608         https://bugs.webkit.org/show_bug.cgi?id=158625
609
610         Reviewed by Tim Horton.
611
612         Extract all the WTF tests into a new target to allow a faster build / test / fix
613         cycle when working on WTF bugs and features.
614         
615         By calling `run-api-tests --wtf-only`, you don't need to have a build of JavaScriptCore/WebCore/etc
616         to test WTF only changes.
617
618         * Scripts/build-api-tests:
619         * Scripts/run-api-tests:
620         (buildTestTool):
621         (testToolPaths):
622         Add new options to build-api-tests and run-api-tests to only build/run the WTF test runner.
623
624         * TestWebKitAPI/CMakeLists.txt:
625         * TestWebKitAPI/Configurations/TestWTF.xcconfig: Added.
626         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Added.
627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
628         Add two new targets, TestWTFLibrary which contains all the WTF tests, and TestWTF,
629         the test runner that runs the WTF tests.
630     
631         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
632         Use Utilities.h rather than PlatformUtilities.h.
633
634         * TestWebKitAPI/Utilities.h: Added.
635         * TestWebKitAPI/PlatformUtilities.h:
636         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
637         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm: Added.
638         Move the sleep and run functions into a new Utilities.h/cpp file. This file contains utilities
639         that don't depend on anything in the WebKit project. 
640
641 2016-06-10  Brady Eidson  <beidson@apple.com>
642
643         REGRESSION(r201928?) API test WTF.StringOperators failing
644         https://bugs.webkit.org/show_bug.cgi?id=158623
645
646         Unreviewed, but buddy coded with Alex Christensen.
647
648         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
649         (TestWebKitAPI::LifetimeLogger::fullName): Only one file in all of TestWebKitAPI is allowed
650           to use string concatenation, otherwise the linker will mess up on the symbol related to
651           this bizarre WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING macro expansion.
652
653 2016-06-10  Brady Eidson  <beidson@apple.com>
654
655         WTF_CrossThreadTask.Basic fails in all non mac ports.
656         https://bugs.webkit.org/show_bug.cgi?id=158612
657
658         Reviewed by Alex Christensen.
659
660         The test is very sensitive to argument evaluation order which is explicitly undefined in C++.
661         
662         Instead, we should just count the appropriate events to forget their order.
663         
664         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
665         (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
666         (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
667         (TestWebKitAPI::LifetimeLogger::isolatedCopy):
668         (TestWebKitAPI::LifetimeLogger::fullName):
669         (TestWebKitAPI::testFunction):
670         (TestWebKitAPI::TEST):
671         (TestWebKitAPI::LifetimeLogger::log): Deleted.
672         (TestWebKitAPI::LifetimeLogger::takeLogStr): Deleted.
673
674 2016-06-09  Alex Christensen  <achristensen@webkit.org>
675
676         Clean up Tools *.vcxproj after switching to CMake.
677
678         * DumpRenderTree/DumpRenderTree.sln: Removed.
679         * DumpRenderTree/DumpRenderTree.vcxproj: Removed.
680         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Removed.
681         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
682         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
683         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Removed.
684         * DumpRenderTree/PlatformWin.cmake:
685         * DumpRenderTree/win/TestNetscapePlugin.def: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def.
686         * DumpRenderTree/win/TestNetscapePlugin.rc: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc.
687         * DumpRenderTree/win/resource.h: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h.
688         * MiniBrowser/MiniBrowser.vcxproj: Removed.
689         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Removed.
690         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Removed.
691         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Removed.
692         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Removed.
693         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Removed.
694         * MiniBrowser/MiniBrowser.vcxproj/small.ico: Removed.
695         * MiniBrowser/win/CMakeLists.txt:
696         * MiniBrowser/win/MiniBrowser.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico.
697         * MiniBrowser/win/MiniBrowser.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc.
698         * MiniBrowser/win/MiniBrowserLib.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc.
699         * MiniBrowser/win/MiniBrowserLibResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h.
700         * MiniBrowser/win/MiniBrowserResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h.
701         * MiniBrowser/win/small.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/small.ico.
702         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
703         * win/DLLLauncher/DLLLauncherWinCairo.props: Removed.
704
705 2016-06-09  Zalan Bujtas  <zalan@apple.com>
706
707         Add testing support for 3x device scale factor.
708         https://bugs.webkit.org/show_bug.cgi?id=158597
709
710         Reviewed by Simon Fraser.
711
712         Set 3x device scale factor on the test canvas when the test url is prefixed with hidpi-3x-. 
713
714         * DumpRenderTree/mac/DumpRenderTree.mm:
715         (changeWindowScaleIfNeeded):
716         * WebKitTestRunner/TestController.cpp:
717         (WTR::TestController::updateWindowScaleForTest):
718         * WebKitTestRunner/TestOptions.cpp:
719         (WTR::deviceScaleFactorForTest):
720         (WTR::TestOptions::TestOptions):
721         (WTR::isHiDPITestPath): Deleted.
722         * WebKitTestRunner/TestOptions.h:
723
724 2016-06-09  Michael Catanzaro  <mcatanzaro@igalia.com>
725
726         Add comments to clarify feature enablement
727         https://bugs.webkit.org/show_bug.cgi?id=158567
728
729         Reviewed by Alex Christensen.
730
731         * Scripts/webkitperl/FeatureList.pm:
732
733 2016-06-09  Filip Pizlo  <fpizlo@apple.com>
734
735         Unreviewed, skip jsair tests while we figure out the debug timeouts.
736
737         * Scripts/run-javascriptcore-tests:
738         (runJSCStressTests):
739
740 2016-06-09  Commit Queue  <commit-queue@webkit.org>
741
742         Unreviewed, rolling out r201815.
743         https://bugs.webkit.org/show_bug.cgi?id=158570
744
745         This broke the cmake build. (Requested by lforschler on
746         #webkit).
747
748         Reverted changeset:
749
750         "Teach cmake about libWebKitSystemInterfaceOSX10.12"
751         http://trac.webkit.org/changeset/201815
752
753 2016-06-09  Brady Eidson  <beidson@apple.com>
754
755         Greatly simplify CrossThreadTask.h.
756         https://bugs.webkit.org/show_bug.cgi?id=158542
757
758         Reviewed by Darin Adler.
759
760         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
761         (TestWebKitAPI::TEST):
762
763 2016-06-09  Chris Dumez  <cdumez@apple.com>
764
765         Unreviewed, rolling out r201836, r201845, and r201848.
766
767         Looks like a 1-2% PLT regression on iOS
768
769         Reverted changesets:
770
771         "[JSC] Change some parameters based on a random search"
772         https://bugs.webkit.org/show_bug.cgi?id=158514
773         http://trac.webkit.org/changeset/201836
774
775         "Tempory fix for the debug bots"
776         http://trac.webkit.org/changeset/201845
777
778         "Change thresholdForOptimizeSoon to match
779         thresholdForOptimizeAfterWarmUp"
780         http://trac.webkit.org/changeset/201848
781
782 2016-06-09  Michael Saboff  <msaboff@apple.com>
783
784         WebKitTestRunner and DumpRenderTree do not handle dangling surrogate characters
785         https://bugs.webkit.org/show_bug.cgi?id=154863
786
787         Reviewed by Alexey Proskuryakov.
788
789         Added a non-strict verions of WKStringGetUTF8CString() that will handle dangling
790         surrogates.  Changed the extraction of inner text from frames in DumpRenderTree
791         to use the new WKStringGetUTF8CStringNonStrict() function instead of NSString
792         conversion since NSString doesn't have a way to handle dangling surrogates.
793         The code added in DumpRenderTree matches what was changed in WebKitTestRunner.
794
795         * DumpRenderTree/mac/DumpRenderTree.mm:
796         (dumpFramesAsText):
797         * WebKitTestRunner/StringFunctions.h:
798         (WTR::toWTFString):
799
800 2016-06-08  Hunseop Jeong  <hs85.jeong@samsung.com>
801
802         Try to fix the EFL build. 
803
804         Unreviewed. 
805
806         * TestWebKitAPI/CMakeLists.txt:
807
808 2016-06-08  Alex Christensen  <achristensen@webkit.org>
809
810        Fix WinCairo build
811
812         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
813
814 2016-06-08  Alex Christensen  <achristensen@webkit.org>
815
816         Fix WinCairo build
817
818         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
819         (BitmapContext::createByAdoptingBitmapAndContext):
820         (BitmapContext::~BitmapContext):
821
822 2016-06-08  Benjamin Poulain  <benjamin@webkit.org>
823
824         [JSC] Change some parameters based on a random search
825         https://bugs.webkit.org/show_bug.cgi?id=158514
826
827         Reviewed by Filip Pizlo.
828
829         * Scripts/run-jsc-stress-tests:
830
831 2016-06-08  Aakash Jain  <aakash_jain@apple.com>
832
833         tests fail if display sleeps while run-webkit-tests is running
834         https://bugs.webkit.org/show_bug.cgi?id=153919
835
836         Reviewed by Alexey Proskuryakov.
837
838         * DumpRenderTree/mac/LayoutTestHelper.m:
839         (releaseSleepAssertions): Release both Display sleep and System sleep assertions.
840         (addSleepAssertions): Add sleep assertion for both Display sleep and System sleep.
841
842 2016-06-08  Lucas Forschler  <lforschler@apple.com>
843
844         Reverted changeset 201814.
845
846         * Scripts/copy-webkitlibraries-to-product-directory:
847
848 2016-06-08  Per Arne Vollan  <pvollan@apple.com>
849
850         [Win] Shadow DOM tests are failing.
851         https://bugs.webkit.org/show_bug.cgi?id=158524
852
853         Reviewed by Brent Fulgham.
854
855         Enable Shadow DOM when running tests.
856
857         * DumpRenderTree/win/DumpRenderTree.cpp:
858         (resetWebPreferencesToConsistentValues):
859
860 2016-06-08  Lucas Forschler  <lforschler@apple.com>
861
862         Teach cmake about libWebKitSystemInterfaceOSX10.12
863         This patch also removes duplicated logic inside DumpRenderTree/PlatformMac.cmake
864
865         Rubber-stamped by Alex Christensen.
866  
867         * DumpRenderTree/PlatformMac.cmake:
868         * WebKitTestRunner/PlatformMac.cmake:
869
870 2016-06-07  Lucas Forschler  <lforschler@apple.com>
871
872         <rdar://problem/26685782>
873         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
874
875         Rubber-stamped by Jessie Berlin.
876
877         * Scripts/copy-webkitlibraries-to-product-directory:
878
879 2016-06-08  Aakash Jain  <aakash_jain@apple.com>
880
881         Don't try to cleanup non-existing ios Simulators
882         https://bugs.webkit.org/show_bug.cgi?id=158510
883
884         Reviewed by Alexey Proskuryakov.
885
886         * Scripts/webkitpy/port/ios.py:
887         (IOSSimulatorPort.clean_up_test_run): 
888         Check if simulator exists before trying to clean it up.
889
890 2016-06-08  Brady Eidson  <beidson@apple.com>
891
892         Try to fix the Windows build.
893
894         Unreviewed.
895
896         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
897         (TestWebKitAPI::LifetimeLogger::log):
898         (TestWebKitAPI::LifetimeLogger::takeLogStr):
899         (TestWebKitAPI::testFunction):
900         (TestWebKitAPI::TEST):
901         (TestWebKitAPI::log): Deleted. (VS was seeing it as a dupe symbol)
902         (TestWebKitAPI::takeLogStr): Deleted. (VS was seeing it as a dupe symbol)
903
904 2016-06-08  Brady Eidson  <beidson@apple.com>
905
906         Make CrossThreadCopier more efficient (fewer copies!).
907         https://bugs.webkit.org/show_bug.cgi?id=158456
908
909         Reviewed by Alex Christensen.
910
911         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
912         (TestWebKitAPI::TEST):
913
914 2016-06-07  Filip Pizlo  <fpizlo@apple.com>
915
916         Add result validation to JSAir
917         https://bugs.webkit.org/show_bug.cgi?id=158493
918
919         Reviewed by Saam Barati.
920         
921         Run JSAir.
922
923         * Scripts/run-javascriptcore-tests:
924         (runJSCStressTests):
925
926 2016-06-08  Brady Eidson  <beidson@apple.com>
927
928         Add an API test that confirms object constructor/destructor calls during creation of a CrossThreadTask.
929         https://bugs.webkit.org/show_bug.cgi?id=158528
930
931         Reviewed by Alex Christensen.
932
933         * TestWebKitAPI/CMakeLists.txt:
934         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
935         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: Added.
936         (TestWebKitAPI::log):
937         (TestWebKitAPI::takeLogStr):
938         (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
939         (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
940         (TestWebKitAPI::LifetimeLogger::isolatedCopy):
941         (TestWebKitAPI::testFunction):
942         (TestWebKitAPI::TEST):
943
944 2016-06-08  Konstantin Tokarev  <annulen@yandex.ru>
945
946         TestWebKitAPI: Removed redunandant check PLATFORM(GTK) && !defined(BUILDING_WEBKIT2__)
947         https://bugs.webkit.org/show_bug.cgi?id=158521
948
949         Reviewed by Carlos Garcia Campos.
950
951         * TestWebKitAPI/config.h:
952
953 2016-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
954
955         [GTK] Use a longer timeout for glib unit tests
956         https://bugs.webkit.org/show_bug.cgi?id=158476
957
958         Reviewed by Darin Adler.
959
960         The timeout is supposed to be per test case, but in the case of GLib tests it affects all the tests cases of the
961         same test program. Some test programs like TestLoaderClient, that have a lot of test cases, often time out in
962         the bots because the timeout is not enough to run all the tests cases. So, we should use a longer timeout for
963         GLib tests.
964
965         * Scripts/run-gtk-tests:
966         (TestRunner._run_test_glib):
967
968 2016-06-07  Keith Rollin  <krollin@apple.com>
969
970         Remove all uses of PassRefPtr in WTF
971         https://bugs.webkit.org/show_bug.cgi?id=157596
972         <rdar://problem/26234391>
973
974         Reviewed by Chris Dumez.
975
976         Update calls to interfaces that no longer take or return PassRefPtrs.
977
978         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
979         (TestWebKitAPI::stringFromUTF8):
980         (TestWebKitAPI::TEST):
981
982 2016-06-07  Per Arne Vollan  <pvollan@apple.com>
983
984         [Win] Imported markup insertion test is failing.
985         https://bugs.webkit.org/show_bug.cgi?id=158477
986
987         Reviewed by Darin Adler.
988
989         Make sure the empty synchronous request is loaded after each test.
990
991         * DumpRenderTree/win/DumpRenderTree.cpp:
992         (runTest):
993
994 2016-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
995
996         REGRESSION(r201449) [GTK] ARMv7 build fails with libicudata.so.55: cannot open shared object file on gtkdoc-scangobj step.
997         https://bugs.webkit.org/show_bug.cgi?id=158417
998
999         Reviewed by Michael Catanzaro.
1000
1001         The toolchain on armhf (ARMv7) seems unable to properly handle
1002         a shared library that doesn't link with anything.
1003
1004         And libicudata is built by default in this way because it only
1005         contains static data.
1006
1007         That makes icu unusable on armhf because the linker will be
1008         unable to resolve the libicudata dependencies.
1009
1010         Most (if not all) distributions workaround this by linking
1011         libicudata with libc6, which is already a needed dependency for
1012         any of the other icu shared libraries.
1013
1014         So import here the Debian patch fixing this issue. For further
1015         details check https://bugs.debian.org/653457
1016
1017         * gtk/jhbuild.modules:
1018         * gtk/patches/icudata-stdlibs.patch: Added.
1019
1020 2016-06-06  Per Arne Vollan  <pvollan@apple.com>
1021
1022         REGRESSION (r104174): 500+ tests failing on Windows
1023         https://bugs.webkit.org/show_bug.cgi?id=75965
1024
1025         Reviewed by Michael Catanzaro.
1026
1027         Reset WebView scale factors before running next test.
1028
1029         * DumpRenderTree/win/DumpRenderTree.cpp:
1030         (resetWebViewToConsistentStateBeforeTesting):
1031
1032 2016-06-04  Alexey Proskuryakov  <ap@apple.com>
1033
1034         REGRESSION (r201263): Some tests have become flaky timeouts.
1035         https://bugs.webkit.org/show_bug.cgi?id=157990
1036
1037         Reviewed by Darin Adler.
1038
1039         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
1040         It is somewhat legitimate for WebContent to not respond to messages after the test
1041         is done; it can be e.g. re-doing a costly repaint. So, we should restart is silently,
1042         without making the current test fail.
1043
1044 2016-06-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1045
1046         [GTK] Update YouCompleteMe script to make all include paths absolute
1047         https://bugs.webkit.org/show_bug.cgi?id=158301
1048
1049         Reviewed by Michael Catanzaro.
1050
1051         Before this patch, some include paths were not made absolute.
1052         This could make YouCompleteMe plugin to fail extracting information or validating cpp files.
1053
1054         * gtk/ycm_extra_conf.py:
1055
1056 2016-06-03  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
1057
1058         Unreviewed: add myself to the committers list.
1059
1060         * Scripts/webkitpy/common/config/contributors.json:
1061
1062 2016-06-02  Per Arne Vollan  <pvollan@apple.com>
1063
1064         [Win] Fetch API tests are failing.
1065         https://bugs.webkit.org/show_bug.cgi?id=158296
1066
1067         Reviewed by Alex Christensen.
1068
1069         Enable Fetch API when running tests.
1070
1071         * DumpRenderTree/win/DumpRenderTree.cpp:
1072         (resetWebPreferencesToConsistentValues):
1073
1074 2016-06-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1075
1076         Really display failing JSC stress tests in buildbot dashboard
1077         https://bugs.webkit.org/show_bug.cgi?id=158324
1078
1079         Reviewed by Alexey Proskuryakov.
1080
1081         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1082         (BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.
1083         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1084         (BuildbotIteration.prototype._parseData): Correctly check for string membership in array.
1085         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1086         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
1087         membership in array.
1088         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
1089         generated after the first time.
1090         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1091         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.
1092
1093 2016-06-02  Michael Saboff  <msaboff@apple.com>
1094
1095         [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled
1096         https://bugs.webkit.org/show_bug.cgi?id=158317
1097
1098         Reviewed by Saam Barati.
1099
1100         Added defaultNoNoLLIntRun variant to run the default tests with the exception of the no-llint
1101         variant.
1102
1103         * Scripts/run-jsc-stress-tests:
1104
1105 2016-06-02  Aakash Jain  <aakash_jain@apple.com>
1106
1107         LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
1108         https://bugs.webkit.org/show_bug.cgi?id=158305
1109
1110         Reviewed by Alexey Proskuryakov.
1111
1112         * Scripts/webkitpy/port/ios.py:
1113         (IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.
1114
1115 2016-06-01  Brian Burg  <bburg@apple.com>
1116
1117         REGRESSION(r191907): Can't enter combining diacritic marks in Web Inspector fields
1118         https://bugs.webkit.org/show_bug.cgi?id=158227
1119         <rdar://problem/26232464>
1120
1121         Reviewed by Alexey Proskuryakov.
1122
1123         Add a regression test that runs on Mac only.
1124
1125         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1126         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Added.
1127         (-[DummyNavigationDelegate webView:didFinishNavigation:]):
1128         (TEST):
1129         * TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Added.
1130
1131 2016-06-01  Chris Fleizach  <cfleizach@apple.com>
1132
1133         AX: iOS: VoiceOver can't access attachments in mail messages
1134         https://bugs.webkit.org/show_bug.cgi?id=158198
1135
1136         Reviewed by Joanmarie Diggs.
1137
1138         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1139         (AccessibilityUIElement::stringForRange):
1140         (AccessibilityUIElement::attributedStringForRange):
1141         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1142         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1143         (WTR::AccessibilityUIElement::attributedStringForRange):
1144         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1145
1146 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1147
1148         Unreviewed. Mark GTK+ test /webkit2/WebKitWebInspectorServer/test-open-debugging-session as slow.
1149
1150         It's timing out in the bots, but it seems to pass when running run-gtk-tests with no timeout. For GLib tests the
1151         timeout is applied per tester program not per test case, so we need to mark the whole test
1152         WebKit2Gtk/TestInspectorServer as slow.
1153
1154         * Scripts/run-gtk-tests:
1155         (TestRunner):
1156         (TestRunner._run_test_glib):
1157
1158 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1159
1160         Unreviewed. Skip media permission request GTK+ unit tests.
1161
1162         They are timing out in the bots.
1163
1164         * Scripts/run-gtk-tests:
1165         (TestRunner):
1166
1167 2016-05-31  Jer Noble  <jer.noble@apple.com>
1168
1169         Yet another unreviewed build fix; move the closing brace of the namespace declaration inside
1170         the #if check.
1171
1172         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1173
1174 2016-05-31  Jer Noble  <jer.noble@apple.com>
1175
1176         Further unreviewed build fix; only run FullscreenTopContentInset test on Mac.
1177
1178         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1179
1180 2016-05-31  Jer Noble  <jer.noble@apple.com>
1181
1182         Unreviewed build fix; only run FullscreetTopContentInset test on platforms
1183         where WK_API_ENABLED is set.
1184
1185         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1186
1187 2016-05-31  Jer Noble  <jer.noble@apple.com>
1188
1189         REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
1190         https://bugs.webkit.org/show_bug.cgi?id=158156
1191         <rdar://problem/26519589>
1192
1193         Reviewed by Darin Adler.
1194
1195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1196         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added.
1197         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added.
1198         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1199         (TestWebKitAPI::TEST):
1200
1201 2016-05-31  Jon Lee  <jonlee@apple.com>
1202
1203         Unreviewed: add myself to the reviewers list.
1204
1205         * Scripts/webkitpy/common/config/contributors.json:
1206
1207 2016-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1208
1209         [GTK] Provide alternative mirror for the ICU tarball.
1210         https://bugs.webkit.org/show_bug.cgi?id=154530
1211
1212         Unreviewed.
1213
1214         * gtk/jhbuild.modules: After r201449 the GTK+ ARM buildbot is having
1215         a hard time trying to download the ICU tarball from download.icu-project.org
1216         (which redirects to sourceforge and gives problems with something related to
1217         SSL). Provide this alternative mirror to make things working back.
1218
1219 2016-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1220
1221         [GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing since r201423
1222         https://bugs.webkit.org/show_bug.cgi?id=158200
1223
1224         Reviewed by Philippe Normand.
1225
1226         This is because geolocation is no longer allowed for non secure sites, like HTTP. In that case
1227         POSITION_UNAVAILABLE is returned without asking the API layer.
1228
1229         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1230         (testWebViewGeolocationPermissionRequests): Keep the HTTP case to check that it indeed returns
1231         POSITION_UNAVAILABLE and use HTTPS URLs to check permission requests are allowed or denied. Also stop using the
1232         document title, and use user script messages that are more reliable instead.
1233
1234 2016-05-28  Aakash Jain  <aakash_jain@apple.com>
1235
1236         tests fail if display sleeps while run-webkit-tests is running
1237         https://bugs.webkit.org/show_bug.cgi?id=153919
1238
1239         Reviewed by Darin Adler.
1240
1241         * DumpRenderTree/mac/LayoutTestHelper.m:
1242         (addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool.
1243
1244 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1245
1246         Display failing JSC stress tests in buildbot dashboard
1247         https://bugs.webkit.org/show_bug.cgi?id=156595
1248
1249         Reviewed by Alexey Proskuryakov.
1250
1251         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1252         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
1253         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
1254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1255         (BuildbotCombinedQueueView.prototype.update):
1256         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1257         (BuildbotIteration):
1258         (BuildbotIteration.prototype._parseData):
1259         (BuildbotIteration.prototype.loadLayoutTestResults):
1260         (BuildbotIteration.prototype.):
1261         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults):
1262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1263         (BuildbotQueueView.prototype._createLoadingIndicator):
1264         (BuildbotQueueView.prototype.):
1265         (BuildbotQueueView.prototype._onPopoverCopy):
1266         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions):
1267         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions):
1268         (BuildbotQueueView.prototype._addIterationHeadingToPopover):
1269         (BuildbotQueueView.prototype._testStepFailureDescription):
1270         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount):
1271         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1272         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
1273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1274         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
1275         (BuildbotTesterQueueView.prototype.update):
1276         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1277         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions):
1278         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted.
1279         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted.
1280         (BuildbotTesterQueueView.prototype.): Deleted.
1281         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted.
1282         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:
1283         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
1284         (MockBuildbot):
1285         (MockBuildbot.prototype.buildPageURLForIteration):
1286         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
1287         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
1288         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
1289         (MockBuildbotQueue):
1290         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
1291         (MockBuildbotTestResults):
1292         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
1293         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
1294         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1295
1296 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1297
1298         Display failing JSC stress tests in buildbot dashboard
1299         https://bugs.webkit.org/show_bug.cgi?id=156595
1300
1301         Reviewed by Alexey Proskuryakov.
1302
1303         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1304         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Generate the URL for raw JSON output of
1305         JSC tests.
1306         (Buildbot.prototype.javaScriptCoreTestStdioURLForIteration): Generate the URL for human-readable stdio output
1307         of JSC tests.
1308         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1309         (BuildbotCombinedQueueView.prototype.update): Display JSC test results in popover.
1310         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1311         (BuildbotIteration): Add javaScriptCoreTestResults variable.
1312         (BuildbotIteration.prototype.): Check for javascriptcore tests step.
1313         (BuildbotIteration.prototype.loadLayoutTestResults): Add comma at closing brace.
1314         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults): Fetch JSON from Buildbot server.
1315         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1316         (BuildbotQueueView.prototype._createLoadingIndicator): Reusable function.
1317         (BuildbotQueueView.prototype._onPopoverCopy): Reusable copy event handler to allow accurate copying of text
1318         from popovers.
1319         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Generates the popover bubble's
1320         inner HTML from the JSC failure data.
1321         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Generate the popover bubble
1322         for JSC results and handle request failures.
1323         (BuildbotQueueView.prototype._testStepFailureDescription): Moved from subclass.
1324         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount): Moved from subclass.
1325         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1326         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Parse JSON into a list of failing tests.
1327         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1328         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Instantiate PopoverTrackers for builds whose 
1329         only failures are JSC tests.
1330         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Use _onPopoverCopy.
1331         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Use _createLoadingIndicator.
1332         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted. Moved to superclass.
1333         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted. Moved to superclass.
1334         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted. Using superclass's reusable function as copy handler instead.
1335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Add new script files.
1336         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Added.
1337         (MockBuildbot): Mocked version of Buildbot, only containing URL methods.
1338         (MockBuildbot.prototype.buildPageURLForIteration): Same as real Buildbot.js
1339         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Points to local file containing JSON for test.
1340         (MockBuildbot.prototype.javaScriptCoreTestStdioURLForIteration): Same as real Buildbot.js
1341         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
1342         (MockBuildbotQueue): Use a MockBuildbot() instead of a string.
1343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Added.
1344         (MockBuildbotTestResults): Mocked version of BuildbotTestResults.
1345         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Sets the 'regressions' variable.
1346         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
1347         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Add four groups of tests.
1348
1349 2016-05-27  Chris Dumez  <cdumez@apple.com>
1350
1351         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables
1352         https://bugs.webkit.org/show_bug.cgi?id=158111
1353
1354         Reviewed by Darin Adler.
1355
1356         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables.
1357         These are often used cross-thread and copying the captured lambda variables can be
1358         dangerous (e.g. we do not want to copy a String after calling isolatedCopy() upon
1359         capture).
1360
1361         * WebKitTestRunner/TestController.cpp:
1362         (WTR::TestController::decidePolicyForNavigationAction):
1363
1364 2016-05-27  Brady Eidson  <beidson@apple.com>
1365
1366         Modern IDB: After closing a Netflix video, trying to watch it again fails.
1367         <rdar://problem/25092473> and https://bugs.webkit.org/show_bug.cgi?id=158160
1368
1369         Reviewed by Alex Christensen.
1370
1371         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1372         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Added.
1373         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Added.
1374         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Added.
1375
1376 2016-05-27  Joanmarie Diggs  <jdiggs@igalia.com>
1377
1378         AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416
1379         https://bugs.webkit.org/show_bug.cgi?id=158152
1380
1381         Reviewed by Chris Fleizach.
1382
1383         The failure is actually a bug fix because only one child is being added, but two
1384         notifications were being emitted. Now there is only one notification. To verify
1385         this was the case, we really should examine the child reportedly being added. That
1386         child is the ATK event's any_data, so pass along that child to the listener.
1387
1388         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1389
1390 2016-05-26  Alex Christensen  <achristensen@webkit.org>
1391
1392         Expose content extension failure error codes in SPI
1393         https://bugs.webkit.org/show_bug.cgi?id=158095
1394         rdar://problem/26475651
1395
1396         Reviewed by Anders Carlsson.
1397
1398         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1399         (checkDomain):
1400         (TEST_F):
1401         Add tests that use the new enum.
1402
1403 2016-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1404
1405         New intl-numberformat.js test fails on many Linux platforms
1406         https://bugs.webkit.org/show_bug.cgi?id=154530
1407
1408         Reviewed by Darin Adler.
1409
1410         The test is actually failing because of a bug in the icu version installed in the bots, using a newer version of
1411         icu makes the tests pass and explains why it worked for some people. So, let's add icu 55.1 to the internal
1412         jhbuild to ensure JSC tests pass in the bots no matter what the icu version installed is.
1413
1414         * gtk/jhbuild.modules:
1415
1416 2016-05-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1417
1418         [JSC] Allow JSBench to use precise time
1419         https://bugs.webkit.org/show_bug.cgi?id=158050
1420
1421         Reviewed by Geoffrey Garen.
1422
1423         JSBench use `new Date().getTime()` without options and there is no way to use precise time.
1424         This patch modifies the JSBench code to inject the code taking the precise time.
1425         `currentTimeInMS` is given by the benchmerk harness and JSBench uses it.
1426         run-jsc-benchmark switches this function's implementation between `Date.now()` and
1427         testRunner's precise time one.
1428
1429         While this patch modifies the code of JSBench, the last release of JSBench is Jan 2013 and
1430         the contents are not changed for a long time. As described in the original paper[1], the
1431         tests can be generated by using JSBench's record & replay system, but in that case, we can
1432         adopt this modification by changing the tool side.
1433
1434         We also add currentTimeInMS implementation in harness.js and u?rem.js directly.
1435         u?rem.js implementation is required when it is executed in u?rem.html without harness.
1436         And harness.js implementation is required when it is executed in the JSBench's harness.
1437         In these implementation, we follow the JetStream's time measuring function: performance.now(),
1438         preciseTime(), or Date.now().
1439
1440         [1]: http://dl.acm.org/citation.cfm?id=2048119
1441
1442         * Scripts/run-jsc-benchmarks:
1443
1444 2016-05-26  Brent Fulgham  <bfulgham@apple.com>
1445
1446         Unreviewed test fix after r201427.
1447         https://bugs.webkit.org/show_bug.cgi?id=157423
1448         <rdar://problem/23751632>
1449
1450         A debug assertion was firing during some test runs due to the Geolocation permission
1451         being turned off during the test. The timer logic was originally written to assert
1452         if the timer fired when permissions were disabled. But this is no longer valid,
1453         because we expect the Geolocation system to be active and become deactivated if the
1454         browsing context violates one of the security criteria.
1455
1456         * DumpRenderTree/mac/UIDelegate.mm:
1457         (-[UIDelegate timerFired]): Remove invalid assertion.
1458
1459 2016-05-26  Filip Pizlo  <fpizlo@apple.com>
1460
1461         ScopedLambda should have a lifetime story that makes sense to the compiler
1462         https://bugs.webkit.org/show_bug.cgi?id=158118
1463
1464         Reviewed by Mark Lam.
1465         
1466         Added a test case. This test crashes before the fix and now it passes.
1467
1468         * TestWebKitAPI/CMakeLists.txt:
1469         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1470         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp: Added.
1471         (TestWebKitAPI::TEST):
1472
1473 2016-05-26  Myles C. Maxfield  <mmaxfield@apple.com>
1474
1475         Build fix
1476
1477         Rubber stamped by Lucas Forschler.
1478
1479         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1480         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1481
1482 2016-05-25  Anders Carlsson  <andersca@apple.com>
1483
1484         Get rid of WTF/Functional.h
1485         https://bugs.webkit.org/show_bug.cgi?id=158081
1486
1487         Reviewed by Chris Dumez.
1488
1489         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1490         * TestWebKitAPI/Tests/WTF/Functional.cpp: Removed.
1491         (TestWebKitAPI::returnFortyTwo): Deleted.
1492         (TestWebKitAPI::TEST): Deleted.
1493         (TestWebKitAPI::multiplyByTwo): Deleted.
1494         (TestWebKitAPI::multiplyByOneAndAHalf): Deleted.
1495         (TestWebKitAPI::multiply): Deleted.
1496         (TestWebKitAPI::subtract): Deleted.
1497         (TestWebKitAPI::A::A): Deleted.
1498         (TestWebKitAPI::A::f): Deleted.
1499         (TestWebKitAPI::A::addF): Deleted.
1500         (TestWebKitAPI::B::B): Deleted.
1501         (TestWebKitAPI::B::~B): Deleted.
1502         (TestWebKitAPI::B::ref): Deleted.
1503         (TestWebKitAPI::B::deref): Deleted.
1504         (TestWebKitAPI::B::f): Deleted.
1505         (TestWebKitAPI::B::g): Deleted.
1506         (TestWebKitAPI::Number::create): Deleted.
1507         (TestWebKitAPI::Number::~Number): Deleted.
1508         (TestWebKitAPI::Number::value): Deleted.
1509         (TestWebKitAPI::Number::Number): Deleted.
1510         (TestWebKitAPI::multiplyNumberByTwo): Deleted.
1511
1512 2016-05-25  Daniel Bates  <dabates@apple.com> and Brent Fulgham  <bfulgham@apple.com>
1513
1514         [WebSockets] No infrastructure for testing secure web sockets (wss)
1515         https://bugs.webkit.org/show_bug.cgi?id=157884
1516         <rdar://problem/26477197>
1517
1518         Reviewed by Andy Estes.
1519
1520         Add support to webkitpy to start and stop a secure Web Socket server running on port 9323
1521         using the certificate, private-key from file LayoutTests/http/conf/webkit-httpd.pem. Also
1522         teaches run-webkit-httpd to start and stop the Web Socket servers.
1523
1524         Modify DumpRenderTree and WebKitTestRunner to understand a new testRunner method,
1525         'setAllowsAnySSLCertificate', which allows us to use the same self-signed test certificate
1526         we do for our HTTPS tests.
1527         
1528         * DumpRenderTree/TestRunner.cpp:
1529         (setAllowsAnySSLCertificateCallback):
1530         (TestRunner::setAllowsAnySSLCertificate):
1531         * DumpRenderTree/TestRunner.h:
1532         * DumpRenderTree/mac/DumpRenderTree.mm:
1533         (resetWebViewToConsistentStateBeforeTesting): Make sure we turn off the new flag between tests.
1534         * Scripts/run-webkit-httpd:
1535         (main): Start the websocket server at launch.
1536         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1537         (Manager.__init__): Remove dead code.
1538         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1539         (PyWebSocket.__init__): Cleanup code.
1540         (PyWebSocket): Pass '--tls-client-ca' to start command.
1541         (PyWebSocket._prepare_config): Cleanups.
1542         * Scripts/webkitpy/port/base.py:
1543         (Port.to.start_http_server):
1544         (Port.to):
1545         (Port.to._extract_certificate_from_pem): Added.
1546         (Port.to._extract_private_key_from_pem): Added.
1547         (Port.to.start_websocket_server): Start secure socket server.
1548         (Port.to.stop_websocket_server): Stop secure socket server.
1549         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add new API.
1550         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1551         (WTR::InjectedBundle::setAllowsAnySSLCertificate): Added.
1552         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1553         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1554         (WTR::TestRunner::setAllowsAnySSLCertificate): Added.
1555         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1556
1557 2016-05-25  Keith Miller  <keith_miller@apple.com>
1558
1559         run-jsc-benchmarks should use the new JSBench rather than look for it in the config file.
1560         https://bugs.webkit.org/show_bug.cgi?id=158077
1561
1562         Reviewed by Mark Lam.
1563
1564         Since we didn't have JSBench in the tree before we needed to lookup the path to it from
1565         benchmark config file. That's no longer the case so we should just fix it in the script.
1566
1567         * Scripts/run-jsc-benchmarks:
1568
1569 2016-05-24  Aakash Jain  <aakash_jain@apple.com>
1570
1571         Reorganize dashboard code: move code from _timeIntervalString to base class
1572         https://bugs.webkit.org/show_bug.cgi?id=158047
1573         rdar://problem/26457274
1574
1575         Reviewed by Alexey Proskuryakov and Dean Johnson.
1576
1577         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
1578         (BubbleQueueView.prototype._timeIntervalString): Moved core logic to base class so as to make it re-usable.
1579         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1580         (QueueView.prototype._readableTimeString): Same.
1581
1582 2016-05-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1583
1584         [JSC][GTK][EFL] Allow run-jsc-benchmark to use WebKitTestRunner in EFL / GTK ports
1585         https://bugs.webkit.org/show_bug.cgi?id=158016
1586
1587         Reviewed by Darin Adler.
1588
1589         This patch easily allows run-jsc-benchmark to run WebKitTestRunner-based tests in GTK / EFL ports.
1590         This change encourages us to run tests with the browser-heap in nix environments.
1591         Two things are modified.
1592
1593         1. Add a fall-back to look up the library path in GTK / EFL / JSCOnly environment.
1594
1595             In GTK / EFL / JSCOnly ports, the hierarchy of the build directory is slightly different from Apple port.
1596             For example, the jsc bin locate at "WebKitBuild/XXX/Release/bin/jsc" and the lib path is "WebKitBuild/XXX/Release/lib"
1597             while the one of Apple port is "WebKitBuild/XXX/Release/jsc" and "WebKitBuild/XXX/Release/lib".
1598             And based on this library path, we configure the required environment variables to run WebKitTestRunner in GTK / EFL ports.
1599
1600         2. Add --dependencies option to add dependent library paths.
1601
1602             While Apple ports does not require any additional dependent library path, GTK and EFL ports require this path,
1603             typically WebKitBuild/DependenciesGTK and WebKitBuild/DependenciesEFL respectively. So we need to add such paths to LD_LIBRARY_PATH.
1604             Instead of adding platform options like --gtk / --efl, we add --dependencies option to add the additional dependent library paths.
1605             The platform options still require the build path to look up the dependent library directory. So we pass it directly through --dependencies.
1606             Multiple additional dependent library paths can be added by using --dependencies multiple times.
1607
1608         By using these change, we can run benchmarks that require WebKitTestRunner in GTK / EFL ports (If you would like to run them in a headless manner, you can use xvbuf.).
1609         Example:
1610             `Tools/Scripts/run-jsc-benchmarks baseline:WebKitBuild/baseline/Release/bin/WebKitTestRunner patched:WebKitBuild/patched/Release/bin/WebKitTestRunner --dependencies WebKitBuild/DependenciesGTK/Root/lib --js-bench`
1611
1612         * Scripts/run-jsc-benchmarks:
1613
1614 2016-05-20  Keith Miller  <keith_miller@apple.com>
1615         We should have JSBench in PerformanceTests
1616         https://bugs.webkit.org/show_bug.cgi?id=157952
1617
1618         Rubber-stamped by Saam Barati.
1619
1620         This changes the runner to use the layout of the newest version of JSBench.
1621
1622         * Scripts/run-jsc-benchmarks:
1623
1624 2016-05-24  Chris Dumez  <cdumez@apple.com>
1625
1626         Use auto for some of our lambda function parameters
1627         https://bugs.webkit.org/show_bug.cgi?id=158001
1628
1629         Reviewed by Darin Adler.
1630
1631         Use auto for some of our lambda function parameters now that we build with c++14.
1632
1633         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1634         (WTR::InjectedBundle::willDestroyPage):
1635
1636 2016-05-23  Brady Eidson  <beidson@apple.com>
1637
1638         check-webkit-style gets flags std::literals::chrono_literals as bad naming.
1639         https://bugs.webkit.org/show_bug.cgi?id=157969
1640
1641         Reviewed by Alex Christensen.
1642
1643         * Scripts/webkitpy/style/checkers/cpp.py:
1644         (check_identifier_name_in_declaration):
1645         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1646         (WebKitStyleTest.test_names):
1647
1648 2016-05-22  Alexey Proskuryakov  <ap@apple.com>
1649
1650         RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests
1651         https://bugs.webkit.org/show_bug.cgi?id=157977
1652         rdar://problem/20874156
1653
1654         Reviewed by David Kilzer.
1655
1656         * WebKitTestRunner/TestInvocation.cpp:
1657         (WTR::TestInvocation::invoke): Be more certain to launch a new process when there was
1658         a timeout detected. If we don't, there is a chance that the process is not quite frozen,
1659         and will still send a response that we no longer expect.
1660         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Print timeout details to stderr
1661         too, as stdout is not available, at least not in the case that I was observing.
1662
1663 2016-05-22  Brady Eidson  <beidson@apple.com>
1664
1665         Move to C++14.
1666         https://bugs.webkit.org/show_bug.cgi?id=157948
1667
1668         Reviewed by Michael Catanzaro.
1669
1670         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1671         * MiniBrowser/Configurations/Base.xcconfig:
1672         * TestWebKitAPI/Configurations/Base.xcconfig:
1673         * WebKitTestRunner/Configurations/Base.xcconfig:
1674
1675 2016-05-21  Aakash Jain  <aakash_jain@apple.com>
1676
1677         Simulator launch fails intermittently due to failure in checking simulator boot status
1678         https://bugs.webkit.org/show_bug.cgi?id=157965
1679         rdar://problem/26402404
1680
1681         Reviewed by Alexey Proskuryakov.
1682
1683         * Scripts/webkitpy/xcode/simulator.py:
1684         (Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
1685         whether simulator has finished booting.
1686
1687 2016-05-21  Dan Bernstein  <mitz@apple.com>
1688
1689         Silence warnings from svn propget when using newer versions of Subversion.
1690         https://bugs.webkit.org/show_bug.cgi?id=157879
1691
1692         Reviewed by Daniel Bates.
1693
1694         * Scripts/prepare-ChangeLog:
1695         (attributeCommand): Redirect svn propget stderr to /dev/null.
1696         * Scripts/svn-create-patch:
1697         (findMimeType): Ditto.
1698
1699 2016-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1700
1701         run-benchmark's results should contain Animometer's debug output
1702         https://bugs.webkit.org/show_bug.cgi?id=157941
1703
1704         Reviewed by Stephanie Lewis.
1705
1706         Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array.
1707         The result can be dragged and dropped into Animometer's developer.html page.
1708
1709         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1710         (BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites.
1711         (BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately.
1712         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
1713         Modified the patch to store the debug output.
1714         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1715         (ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined
1716         when the request body is larger than a certain size on twisted.
1717
1718 2016-05-20  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1719
1720         Use clearer names for JSON output of javascriptcore test results
1721         https://bugs.webkit.org/show_bug.cgi?id=157921
1722
1723         Reviewed by Alexey Proskuryakov.
1724
1725         "failures" and "apiTestResult" were somewhat ambiguous names. 
1726         
1727         * Scripts/run-javascriptcore-tests:
1728         (runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed".
1729
1730 2016-05-20  Chris Dumez  <cdumez@apple.com>
1731
1732         Unreviewed, fix API test introduced in r201213.
1733
1734         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1735         (TestWebKitAPI::TEST):
1736
1737 2016-05-20  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
1738
1739         Implement operator== for WeakPtr
1740         https://bugs.webkit.org/show_bug.cgi?id=157883
1741
1742         Reviewed by Chris Dumez.
1743
1744         Implement operator== and operator!= for WeakPtr and update code to use the operators.
1745
1746         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1747         (TestWebKitAPI::TEST):
1748
1749 2016-05-19  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1750
1751         Add JSON results to 32-bit and CLoop JSC tests
1752         https://bugs.webkit.org/show_bug.cgi?id=157929
1753
1754         Reviewed by Alexey Proskuryakov.
1755
1756         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1757         (RunLLINTCLoopTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
1758         (Run32bitJSCTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
1759
1760 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1761
1762         Typo fix in import-test262-tests
1763         https://bugs.webkit.org/show_bug.cgi?id=157902
1764
1765         Reviewed by Keith Miller.
1766
1767         * Scripts/import-test262-tests:
1768
1769 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1770
1771         [EFL] Fix the gst-libav build on ARM Thumb2 after r199649
1772         https://bugs.webkit.org/show_bug.cgi?id=157893
1773
1774         Reviewed by Antonio Gomes.
1775
1776         * efl/patches/gst-libav.patch:
1777
1778 2016-05-19  Jer Noble  <jer.noble@apple.com>
1779
1780         REGRESSION(r200951): VideoControlsManager API tests time out
1781         https://bugs.webkit.org/show_bug.cgi?id=157896
1782         <rdar://problem/26326293>
1783
1784         Reviewed by Eric Carlson.
1785
1786         Explicitly disable user gesture requirements for playback.
1787
1788         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1789         (TestWebKitAPI::TEST):
1790
1791 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1792
1793         Slow JSC stress tests times out in 32 bit debug mode
1794         https://bugs.webkit.org/show_bug.cgi?id=154964
1795
1796         Reviewed by Michael Catanzaro.
1797
1798         * Scripts/run-javascriptcore-tests:
1799         (runJSCStressTests): Pass through the --debug option.
1800         * Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.
1801
1802 2016-05-18  Aakash Jain  <aakash_jain@apple.com>
1803
1804         Remove underline from Status Bubbles on dashboard
1805         https://bugs.webkit.org/show_bug.cgi?id=157870
1806         rdar://problem/26332321
1807
1808         Reviewed by Alexey Proskuryakov.
1809
1810         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style 
1811         change made in http://trac.webkit.org/r200880
1812
1813 2016-05-18  Michael Saboff  <msaboff@apple.com>
1814
1815         r199812 broke test262
1816         https://bugs.webkit.org/show_bug.cgi?id=157595
1817
1818         Reviewed by Filip Pizlo.
1819
1820         Added a new run type, runOneLargeHeap, for tests that use a large amount of memory.
1821         This run type will not run with the --memory-limited option.  Without that option,
1822         we'll only the default test variant.
1823
1824         * Scripts/run-jsc-stress-tests:
1825
1826 2016-05-18  Simon Fraser  <simon.fraser@apple.com>
1827
1828         REGRESSION (r200534) Command-+ no longer zooms pages 
1829         https://bugs.webkit.org/show_bug.cgi?id=157826
1830         rdar://problem/26334636
1831
1832         Reviewed by Dean Jackson.
1833
1834         * DumpRenderTree/mac/DumpRenderTree.mm:
1835         (resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828).
1836
1837 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
1838
1839         [GTK] accessibility/meter-element.html is failing
1840         https://bugs.webkit.org/show_bug.cgi?id=115633
1841
1842         Reviewed by Chris Fleizach.
1843
1844         Implement AccessibilityUIElement::valueDescription() and add mapping
1845         from ATK_ROLE_LEVEL_BAR to AXProgressIndicator.
1846
1847         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1848         (WTR::AccessibilityUIElement::valueDescription):
1849
1850 2016-05-18  Brady Eidson  <beidson@apple.com>
1851
1852         Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
1853         https://bugs.webkit.org/show_bug.cgi?id=157823
1854
1855         Reviewed by Alex Christensen.
1856
1857         * DumpRenderTree/mac/TestRunnerMac.mm:
1858         (TestRunner::clearAllDatabases):
1859         
1860         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1861         (WTR::TestRunner::clearAllDatabases):
1862         
1863         * WebKitTestRunner/TestInvocation.cpp:
1864         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1865
1866 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
1867
1868         AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description
1869         https://bugs.webkit.org/show_bug.cgi?id=157822
1870
1871         Reviewed by Chris Fleizach.
1872
1873         Fix AccessibilityUIElement::helpText() so that it returns an empty string rather than
1874         nullptr upon failure.
1875
1876         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1877         (WTR::AccessibilityUIElement::helpText):
1878
1879 2016-05-17  Beth Dakin  <bdakin@apple.com>
1880
1881         Make handleAcceptedCandidate a public function
1882         https://bugs.webkit.org/show_bug.cgi?id=157763
1883         -and corresponding-
1884         rdar://problem/26206397
1885
1886         Reviewed by Tim Horton.
1887
1888         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1889         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Added.
1890         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Added.
1891         (-[DoNotLeakWebView dealloc]):
1892         (-[DoNotLeakWebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1893         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
1894         (TestWebKitAPI::TEST):
1895
1896 2016-05-17  Keith Miller  <keith_miller@apple.com>
1897
1898         Add test262 harness support code
1899         https://bugs.webkit.org/show_bug.cgi?id=157797
1900
1901         Reviewed by Filip Pizlo.
1902
1903         The import-test262-tests script is used to generate the yaml file used to run test262. It
1904         takes a path to the local copy of the Test262 repository as well as an optional path to file
1905         containing a list of failures. This script currently just creates the yaml file used to run
1906         the script. It does not relocate the test files into our tests directory. In the future I
1907         plan to add that feature but it didn't seem essential for the first iteration. Since many
1908         test262 tests need to be run in both strict and non-strict mode, import-test262-tests
1909         creates two separate runs for those tests. This enables us to distinguish between failures
1910         in only one of the two modes.
1911
1912         This patch also updates the run-jsc-stress-tests Script to run tests from Test262. In order
1913         to do so two new run commands were needed runTest262 and prepareTest262Fixture. runTest262
1914         takes an actual test file along with the metadata associated with it. prepareTest262Fixture
1915         takes a fixture file (used by module tests for importing) and makes sure that file is
1916         properly relocated to the test runner directory.
1917
1918         The proccess I used to import the tests was to first run import-test262-tests to create a
1919         yaml for all the tests (import-test262-tests assumes all tests pass if to failures file is
1920         passed). Then I ran the generated yaml file with "run-jsc-stress-tests -v -c 1" piping the
1921         output to a file and collected all the lines with "FAIL" in it. Finally, I reran
1922         import-test262-tests with the new failure file to create the final yaml.
1923
1924         * Scripts/import-test262-tests: Added.
1925         * Scripts/run-jsc-stress-tests:
1926
1927 2016-05-16  Enrica Casucci  <enrica@apple.com>
1928
1929         build fix after r200968 and r200969
1930
1931         Unreviewed.
1932
1933         * DumpRenderTree/mac/EventSendingController.mm:
1934         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1935
1936 2016-05-16  Jer Noble  <jer.noble@apple.com>
1937
1938         API test WebKit2.MSEIsPlayingAudio timing out after r200951
1939         https://bugs.webkit.org/show_bug.cgi?id=157748
1940
1941         Reviewed by Eric Carlson.
1942
1943         The file-with-mse.html testcase only calls play() once it's own XHR loading is complete; the
1944         "user gesture" check fails at that point.  Call play() up front; playback will begin as soon
1945         as enough data is loaded.
1946
1947         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html:
1948
1949 2016-05-16  Enrica Casucci  <enrica@apple.com>
1950
1951         Remove unused initializer for WebEvent on iOS.
1952         https://bugs.webkit.org/show_bug.cgi?id=157689
1953
1954         Reviewed by Anders Carlsson.
1955
1956         Adopting different initializer for WebEvent to fix the build.
1957
1958         * DumpRenderTree/mac/EventSendingController.mm:
1959         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1960
1961 2016-05-16  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1962
1963         Add machine-readable results for JSC API tests to the Buildbot json log
1964         https://bugs.webkit.org/show_bug.cgi?id=157642
1965
1966         Reviewed by Geoffrey Garen.
1967
1968         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1969         (RunJavaScriptCoreTests): Use --no-fail-fast option on run-javascriptcore-tests
1970         * Scripts/run-javascriptcore-tests:
1971         (runJSCStressTests): Abstracted out writing JSON to file (new function below)
1972         (writeJsonDataIfApplicable): Added
1973
1974 2016-04-06  Jer Noble  <jer.noble@apple.com>
1975
1976         [WK2] Add API to WKWebViewConfiguration to control autoplay policy.
1977         https://bugs.webkit.org/show_bug.cgi?id=156312
1978
1979         Reviewed by Dan Bernstein.
1980
1981         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1982         (WTR::initializeWebViewConfiguration):
1983         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1984         (TEST_F):
1985
1986 2016-05-16  Brent Fulgham  <bfulgham@apple.com>
1987
1988         REGRESSION (r192098): Content missing after copy and paste to Notes App on retina displays
1989         https://bugs.webkit.org/show_bug.cgi?id=157630
1990         <rdar://problem/25277577>
1991
1992         Reviewed by Simon Fraser.
1993
1994         Update test infrastructure to support checking the number of images in the pasteboard.
1995
1996         * DumpRenderTree/TestRunner.cpp:
1997         (imageCountInGeneralPasteboardCallback): Added.
1998         (TestRunner::staticFunctions):
1999         * DumpRenderTree/TestRunner.h:
2000         * DumpRenderTree/mac/TestRunnerMac.mm:
2001         (TestRunner::imageCountInGeneralPasteboard): Added.
2002         * DumpRenderTree/win/TestRunnerWin.cpp:
2003         (TestRunner::imageCountInGeneralPasteboard): Added stub method.
2004         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2005         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2006         (WTR::InjectedBundle::imageCountInGeneralPasteboard): Added.
2007         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2008         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2009         (WTR::TestRunner::imageCountInGeneralPasteboard): Added.
2010         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2011         * WebKitTestRunner/TestController.cpp:
2012         (WTR::TestController::imageCountInGeneralPasteboard): Added stub implementation.
2013         * WebKitTestRunner/TestController.h:
2014         * WebKitTestRunner/TestInvocation.cpp:
2015         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Handle copy message.
2016         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2017         (WTR::TestController::imageCountInGeneralPasteboard): Added.
2018
2019 2016-05-13  Dewei Zhu  <dewei_zhu@apple.com>
2020
2021         Fix JSBench which causes math domain error in run-benchmark script.
2022         https://bugs.webkit.org/show_bug.cgi?id=157697
2023         <rdar://problem/26279292>
2024
2025         Reviewed by Ryosuke Niwa.
2026
2027         Some tests of JSBench give time usage to be 0 ms which will causes error while calculating geometric mean.
2028         Also fix a round-off error while calculating stdev.
2029
2030         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
2031         (BenchmarkResults._format_values):
2032         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
2033
2034 2016-05-13  Brady Eidson  <beidson@apple.com>
2035
2036         Extend protector naming code style guideline to cover operator= assignment.
2037         https://bugs.webkit.org/show_bug.cgi?id=157693
2038
2039         Reviewed by Darin Adler.
2040
2041         * Scripts/webkitpy/style/checkers/cpp.py:
2042         (check_identifier_name_in_declaration):
2043         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2044         (WebKitStyleTest.test_names):
2045
2046 2016-05-13  Aakash Jain  <aakash_jain@apple.com>
2047
2048         Dashboard code restructuring
2049         https://bugs.webkit.org/show_bug.cgi?id=157680
2050         <rdar://problem/14736888>
2051
2052         Reviewed by Alexey Proskuryakov.
2053
2054         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
2055         (BubbleQueueView.prototype.addLinkToRow): Moved to base class.
2056         (BubbleQueueView.prototype.addTextToRow): Moved to base class.
2057         (BubbleQueueView.prototype._addDividerToPopover): Moved to base class.
2058         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2059         (BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
2060         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2061         (BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
2062         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2063         (BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
2064         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2065         (BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take
2066         additional argument.
2067         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class.
2068         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class.
2069         (BuildbotQueueView.prototype._addDividerToPopover): Moved to base class.
2070         (BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class.
2071         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2072         (documentReady): Display any customView if available.
2073         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2074         (QueueView.prototype.addLinkToRow): Moved from child class, no changes.
2075         (QueueView.prototype.addTextToRow): Moved from child class, no changes.
2076         (QueueView.prototype._addDividerToPopover): Moved from child class, no changes.
2077         (QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic
2078         by taking latestIterationGetter method as an argument.
2079         (QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes.
2080         (QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes.
2081         (QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes.
2082         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2083         (a:hover:link): Underline only when there is a link.
2084
2085 2016-05-13  Yoav Weiss  <yoav@yoav.ws>
2086
2087         Turn on WEB_TIMING for all ports
2088         https://bugs.webkit.org/show_bug.cgi?id=157673
2089
2090         Reviewed by Alex Christensen.
2091
2092         * Scripts/webkitperl/FeatureList.pm: Make sure that WEB_TIMING is on by default.
2093
2094 2016-05-13  Brady Eidson  <beidson@apple.com>
2095
2096         Protector Ref/RefPtrs should have a specified naming style.
2097         https://bugs.webkit.org/show_bug.cgi?id=157591
2098
2099         Reviewed by Darin Adler.
2100
2101         * Scripts/webkitpy/style/checkers/cpp.py:
2102         (check_identifier_name_in_declaration):
2103         (CppChecker):
2104         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2105         (WebKitStyleTest.test_names):
2106
2107 2016-05-12  Csaba Osztrogonác  <ossy@webkit.org>
2108
2109         Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
2110         https://bugs.webkit.org/show_bug.cgi?id=157564
2111
2112         Reviewed by Darin Adler.
2113
2114         * Scripts/webkitperl/FeatureList.pm:
2115         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2116
2117 2016-05-11  Joanmarie Diggs  <jdiggs@igalia.com>
2118
2119         [GTK] accessibility/aria-readonly.html is failing
2120         https://bugs.webkit.org/show_bug.cgi?id=98357
2121
2122         Reviewed by Chris Fleizach.
2123
2124         Add checks to isAttributeSettable() for ATK_STATE_READ_ONLY and the 'readonly'
2125         AtkObject attribute along with ATK_STATE_CHECKABLE for toggle-able elements,
2126         ATK_STATE_SELECTABLE for select elements, and ATK_STATE_FOCUSABLE combined
2127         with range verification for inputs which implement AtkValue. The latter two
2128         additions are admittedly a heuristic workaround for platform accessibility
2129         API differences. But they should be sufficient to facilitate cross-platform
2130         testing of isAttributeSettable() for form elements which lack ARIA attributes.
2131
2132         Bump the minimum version of at-spi2-core and at-spi2-atk
2133         to 2.15.4 (earliest version that supports STATE_READ_ONLY).
2134
2135         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2136         (WTR::AccessibilityUIElement::isAttributeSettable):
2137         * gtk/jhbuild.modules:
2138
2139 2016-05-10  Ryan Haddad  <ryanhaddad@apple.com>
2140
2141         Another attempt to fix the build after r200668.
2142
2143         Unreviewed build fix.
2144
2145         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2146         (TEST):
2147
2148 2016-05-10  Dan Bernstein  <mitz@apple.com>
2149
2150         Tried to fix the Mac build after r200668.
2151
2152         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2153         (WTR::TestController::platformCreateWebView):
2154
2155 2016-05-10  Sam Weinig  <sam@webkit.org>
2156
2157         Tweak underline style for data detected links
2158         https://bugs.webkit.org/show_bug.cgi?id=157546
2159
2160         Reviewed by Tim Horton.
2161
2162         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2163         * TestWebKitAPI/Tests/WebCore/Color.cpp: Added.
2164         (TestWebKitAPI::TEST):
2165         Add tests for the new Color::getHSV() function.
2166
2167 2016-05-10  Filip Pizlo  <fpizlo@apple.com>
2168
2169         Internal JSC profiler should have a timestamped log of events for each code block
2170         https://bugs.webkit.org/show_bug.cgi?id=157538
2171
2172         Reviewed by Benjamin Poulain.
2173
2174         * Scripts/display-profiler-output:
2175
2176 2016-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2177
2178         [Linux] Remove seccomp filters support
2179         https://bugs.webkit.org/show_bug.cgi?id=157380
2180
2181         Reviewed by Darin Adler.
2182
2183         * Scripts/webkitperl/FeatureList.pm:
2184         * TestWebKitAPI/PlatformEfl.cmake:
2185         * TestWebKitAPI/PlatformGTK.cmake:
2186         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Removed.
2187         * efl/jhbuild.modules:
2188         * gtk/jhbuild.modules:
2189
2190 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
2191
2192         [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling
2193         https://bugs.webkit.org/show_bug.cgi?id=157496
2194         rdar://problem/22963278
2195
2196         Reviewed by Tim Horton.
2197
2198         Enhance UIScriptController to generate a drag, which is useful for scrolling.
2199
2200         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2201         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2202         (WTR::UIScriptController::dragFromPointToPoint):
2203         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2204         * WebKitTestRunner/ios/HIDEventGenerator.h:
2205         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2206         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2207         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2208         (WTR::UIScriptController::dragFromPointToPoint):
2209
2210 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
2211
2212         Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
2213         https://bugs.webkit.org/show_bug.cgi?id=157480
2214
2215         Reviewed by Zalan Bujtas.
2216
2217         Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
2218         and move it next to the other iOS text autosizing tests.
2219         
2220         Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree.
2221
2222         * DumpRenderTree/TestRunner.cpp:
2223         (setTextAutosizingEnabledCallback): Deleted.
2224         (TestRunner::staticFunctions): Deleted.
2225         * DumpRenderTree/mac/TestRunnerMac.mm:
2226         (TestRunner::setTextAutosizingEnabled): Deleted.
2227
2228 2016-05-07  Darin Adler  <darin@apple.com>
2229
2230         Next step on dictionary bindings, along with other bindings refinements
2231         https://bugs.webkit.org/show_bug.cgi?id=157451
2232
2233         Reviewed by Chris Dumez.
2234
2235         * Scripts/do-webcore-rename: Use this to rename JSDOMBuild.h to JSDOMConvert.h.
2236         Also skip test expectations in a directory that this was modifying unnecessarily.
2237
2238 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
2239
2240         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
2241         https://bugs.webkit.org/show_bug.cgi?id=157432
2242         rdar://problem/16406720
2243
2244         Reviewed by Dean Jackson.
2245
2246         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
2247
2248         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
2249         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
2250         These two settings are shared with TEXT_AUTOSIZING.
2251
2252         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
2253
2254         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
2255         without changes.
2256
2257         An implication of this set of changes is that the way clients enable text autosizing
2258         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
2259         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
2260         on iPhone only, not iPad.
2261
2262         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
2263         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
2264
2265         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
2266         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
2267         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
2268
2269         * DumpRenderTree/mac/DumpRenderTree.mm:
2270         (resetWebPreferencesToConsistentValues):
2271         * DumpRenderTree/mac/TestRunnerMac.mm:
2272         (TestRunner::setTextAutosizingEnabled):
2273         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2274         * WebKitTestRunner/ios/TestControllerIOS.mm:
2275         (WTR::TestController::platformResetPreferencesToConsistentValues):
2276
2277 2016-05-06  Dean Jackson  <dino@apple.com>
2278
2279         Regions, Shapes and Tracks don't need runtime features
2280         https://bugs.webkit.org/show_bug.cgi?id=157426
2281         <rdar://problem/26146262>
2282
2283         Reviewed by Simon Fraser.
2284
2285         The following RuntimeEnabledFeatures can be removed since
2286         we have no need to disable them (they are stable and have
2287         shipped for a while):
2288         - CSS Regions
2289         - CSS Shapes
2290         - Media tracks
2291
2292         * DumpRenderTree/mac/DumpRenderTree.mm:
2293         (resetWebPreferencesToConsistentValues): Deleted.
2294
2295 2016-05-06  Ryan Haddad  <ryanhaddad@apple.com>
2296
2297         Increase delay when launching multiple ios-simulators in parallel
2298         https://bugs.webkit.org/show_bug.cgi?id=157422
2299
2300         Reviewed by Alexey Proskuryakov.
2301
2302         Tests are intermittently failing when launching multiple simulators in parallel due to "You are opening
2303         this application for the first time" confirmation dialogs. Increasing the delay to alleviate this issue.
2304
2305         * Scripts/webkitpy/port/ios.py:
2306         (IOSSimulatorPort.setup_test_run):
2307
2308 2016-05-06  Per Arne Vollan  <peavo@outlook.com>
2309
2310         [Win] Remove WinXP support.
2311         https://bugs.webkit.org/show_bug.cgi?id=157416
2312
2313         Reviewed by Brent Fulgham.
2314
2315         * win/DLLLauncher/DLLLauncherMain.cpp:
2316         (enableTerminationOnHeapCorruption):
2317
2318 2016-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
2319
2320         [css-grid] Unprefix CSS Grid Layout properties
2321         https://bugs.webkit.org/show_bug.cgi?id=157137
2322
2323         Reviewed by Simon Fraser.
2324
2325         Remove "-webkit" prefix from all the grid layout properties,
2326         including the display value.
2327         Update the source code to remove the prefix where it was used too.
2328
2329         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
2330         (TestWebKitAPI::TEST):
2331
2332 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
2333
2334         Partially revert http://trac.webkit.org/r200504
2335         Improve HTTP test names in WebKitTestRunner's crash report information
2336         https://bugs.webkit.org/show_bug.cgi?id=157389
2337
2338         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Turns out that we can't have URLs
2339         in crash reporter information.
2340
2341 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
2342
2343         Improve HTTP test names in WebKitTestRunner's crash report information
2344         https://bugs.webkit.org/show_bug.cgi?id=157389
2345
2346         Reviewed by Alex Christensen.
2347
2348         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2349         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.
2350
2351         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
2352         (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
2353         use other port numbers too. For http tests, return the complete URL string, not
2354         just the path.
2355
2356 2016-05-04  Alex Christensen  <achristensen@webkit.org>
2357
2358         Blocked redirected main resource requests need descriptive errors
2359         https://bugs.webkit.org/show_bug.cgi?id=156828
2360         rdar://problem/25711316
2361
2362         Reviewed by Daniel Bates.
2363
2364         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2365         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2366         Print out the error type to make sure we have the most descriptive error type.
2367
2368 2016-05-05  Enrique Ocaña González  <eocanha@igalia.com>
2369
2370         [GStreamer] Bump internal jhbuild versions to 1.8.0 and patches to support MSE
2371         https://bugs.webkit.org/show_bug.cgi?id=157341
2372
2373         Reviewed by Xabier Rodriguez-Calvar.
2374
2375         * gtk/jhbuild.modules:
2376         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
2377         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
2378
2379 2016-05-04  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2380
2381         Add JSC test results in JSON format to a Buildbot log
2382         https://bugs.webkit.org/show_bug.cgi?id=156920
2383
2384         Reviewed by Daniel Bates.
2385
2386         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2387         (RunJavaScriptCoreTests): Move command-line option for output file out
2388         of WithProperties.
2389
2390 2016-05-04  Dean Jackson  <dino@apple.com>
2391
2392         TestRunner should always enable all the experimental features
2393         https://bugs.webkit.org/show_bug.cgi?id=157360
2394         <rdar://problem/26099748>
2395
2396         Reviewed by Anders Carlsson.
2397
2398         Call the new SPI that enables all the experimental features.
2399
2400         * WebKitTestRunner/TestController.cpp:
2401         (WTR::TestController::resetPreferencesToConsistentValues):
2402
2403 2016-05-04  Mark Lam  <mark.lam@apple.com>
2404
2405         ES6 Function.name inferred from property names of literal objects can break some websites.
2406         https://bugs.webkit.org/show_bug.cgi?id=157246
2407
2408         Reviewed by Geoffrey Garen.
2409
2410         * WebKitTestRunner/TestController.cpp:
2411         (WTR::TestController::resetPreferencesToConsistentValues):
2412         (WTR::updateTestOptionsFromTestHeader):
2413         * WebKitTestRunner/TestOptions.h:
2414
2415         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2416         (WTR::PlatformWebView::viewSupportsOptions):
2417         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2418         (WTR::PlatformWebView::viewSupportsOptions):
2419         - Add needsSiteSpecificQuirks to WKTR options that can be set. 
2420
2421 2016-05-04  Joanmarie Diggs  <jdiggs@igalia.com>
2422
2423         AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
2424         https://bugs.webkit.org/show_bug.cgi?id=157331
2425
2426         Reviewed by Chris Fleizach.
2427
2428         Add AXLandmarkRegion to the landmark strings handled by roleToString
2429         for objects with ATK_ROLE_LANDMARK.
2430
2431         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2432
2433 2016-05-03  Beth Dakin  <bdakin@apple.com>
2434
2435         Add VideoControlsManager tests
2436         https://bugs.webkit.org/show_bug.cgi?id=157332
2437         -and corresponding-
2438         rdar://problem/24358431
2439
2440         Reviewed by Sam Weinig.
2441
2442         This patch adds three VideoControlsManager tests.
2443
2444         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2445         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
2446         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Added.
2447         (-[DidPlayMessageHandler initWithWKWebView:]):
2448         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2449         (TestWebKitAPI::TEST):
2450         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Added.
2451         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Added.
2452         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Added.
2453
2454 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
2455
2456         [ATK] accessibility/document-attributes.html is failing
2457         https://bugs.webkit.org/show_bug.cgi?id=125348
2458
2459         Reviewed by Chris Fleizach.
2460
2461         The test was failing because the WebArea is now being exposed with the role of
2462         ATK_ROLE_DOCUMENT_WEB; not ATK_ROLE_DOCUMENT_FRAME. Unfortunately, when that
2463         change was made, documentEncoding() and documentURI() were not updated accordingly.
2464
2465         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2466         (WTR::AccessibilityUIElement::documentEncoding):
2467         (WTR::AccessibilityUIElement::documentURI):
2468
2469 2016-05-03  Brent Fulgham  <bfulgham@apple.com>
2470
2471         [Win] Unreviewed build fix.
2472
2473         * EWSTools/start-queue-win.sh: Establish proper VS2015 build
2474         environment at start of queue run.
2475
2476 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
2477
2478         [ATK] accessibility/content-editable-as-textarea.html fails
2479         https://bugs.webkit.org/show_bug.cgi?id=155353
2480
2481         Reviewed by Darin Adler.
2482
2483         The test was timing out because it expected an AXValueChanged notification.
2484         In ATK, AXValueChanged notifications are made for widgets which implement
2485         the AtkValue interface (sliders, progress bars, etc.). We should be listening
2486         for AXTextChanged instead. AtkText's text-insert and text-remove have been
2487         added to the AccessibilityNotificationHandler.
2488
2489         Also, ATK's AccessibilityUIElement support had a number of unimplemented
2490         methods that are being used as part of the previously-failing test. Those
2491         methods are now implemented so that the ATK results are much more similar
2492         to those on the Mac.
2493
2494         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2495         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2496         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2497         (WTR::AccessibilityUIElement::stringAttributeValue):
2498         (WTR::AccessibilityUIElement::rangeForLine):
2499         (WTR::AccessibilityUIElement::boundsForRange):
2500         (WTR::AccessibilityUIElement::attributedStringForRange):
2501
2502 2016-05-02  Brady Eidson  <beidson@apple.com>
2503
2504         Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts.
2505         https://bugs.webkit.org/show_bug.cgi?id=157274
2506
2507         Reviewed by Alex Christensen.
2508
2509         Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout,
2510         and reset them in between tests:
2511         * DumpRenderTree/TestRunner.cpp:
2512         (accummulateLogsForChannel):
2513         (TestRunner::staticFunctions):
2514         (TestRunner::waitToDumpWatchdogTimerFired):
2515         (TestRunner::setAccummulateLogsForChannel):
2516         * DumpRenderTree/TestRunner.h:
2517         * DumpRenderTree/mac/DumpRenderTree.mm:
2518         (resetWebViewToConsistentStateBeforeTesting):
2519
2520         Also add the new method to WKTR's TestRunner, but just stubbed for now:
2521         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2523         (WTR::TestRunner::accummulateLogsForChannel):
2524         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2525
2526 2016-05-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2527
2528         Add fail-fast option to run-javascriptcore-tests
2529         https://bugs.webkit.org/show_bug.cgi?id=157270
2530
2531         Reviewed by Geoffrey Garen.
2532
2533         * Scripts/run-javascriptcore-tests: Add fail-fast command line option.
2534         Defaults to yes, which is the current behavior.
2535
2536 2016-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2537
2538         [CMake] MiniBrowser fails to build because libsoup link flags are not defined.
2539         https://bugs.webkit.org/show_bug.cgi?id=157268
2540
2541         Reviewed by Michael Catanzaro.
2542
2543         * MiniBrowser/gtk/CMakeLists.txt:
2544
2545 2016-04-30  Darin Adler  <darin@apple.com>
2546
2547         Streamline and remove unused bindings generation code
2548         https://bugs.webkit.org/show_bug.cgi?id=157237
2549
2550         Reviewed by Chris Dumez.
2551
2552         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2553         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2554         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2555         Replace non-standard "int" with standard "long", which means the same thing.
2556
2557 2016-04-30  Darin Adler  <darin@apple.com>
2558
2559         Next batch of conversions to use C++ enum class instead of strings for enumerations
2560         https://bugs.webkit.org/show_bug.cgi?id=157232
2561
2562         Reviewed by Chris Dumez.
2563
2564         * Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style
2565         checking. We don't want to waste time trying to make our generated code match our style.
2566
2567 2016-04-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2568
2569         Add JSC test results in JSON format to a Buildbot log.
2570         https://bugs.webkit.org/show_bug.cgi?id=156920
2571
2572         Reviewed by Daniel Bates.
2573
2574         Generate JSON results for JSC tests and upload them to the master
2575         using Buildbot's logfiles machinery.
2576
2577         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2578         (RunJavaScriptCoreTests): Use --json-output option when invoking the
2579         run-javascriptcore-tests Perl script, and expose this JSON output as a 
2580         Buildbot log.
2581         * Scripts/run-javascriptcore-tests:
2582         (runJSCStressTests): Change key names and remove redundant count key.
2583
2584 2016-04-29  Joanmarie Diggs  <jdiggs@igalia.com>
2585
2586         [ATK] Expose the value of aria-roledescription via an AtkObject attribute
2587         https://bugs.webkit.org/show_bug.cgi?id=146719
2588
2589         Reviewed by Chris Fleizach.
2590
2591         Implement roleDescription() so that the implementation can be tested.
2592
2593         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2594         (WTR::AccessibilityUIElement::roleDescription):
2595
2596 2016-04-27  Alexey Proskuryakov  <ap@apple.com>
2597
2598         Don't throttle GuardMalloc on 8-core Macs
2599         https://bugs.webkit.org/show_bug.cgi?id=157108
2600
2601         Reviewed by Alex Christensen.
2602
2603         This was making them slower unnecessarily.
2604
2605         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
2606
2607 2016-04-26  Konstantin Tokarev  <annulen@yandex.ru>
2608
2609         Unreviewed: add myself to the committers list.
2610
2611         * Scripts/webkitpy/common/config/contributors.json:
2612
2613 2016-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2614
2615         Fix text in log files autogenerated by import-w3c-tests
2616         https://bugs.webkit.org/show_bug.cgi?id=157021
2617
2618         Unreviewed. Fixing the second typo.
2619
2620         * Scripts/webkitpy/w3c/test_importer.py:
2621         (TestImporter.write_import_log):
2622
2623 2016-04-26  Filip Pizlo  <fpizlo@apple.com>
2624
2625         WebCore on Mac ignores the user's preferred region (country) while getting the language
2626         https://bugs.webkit.org/show_bug.cgi?id=156993
2627
2628         Reviewed by Geoffrey Garen.
2629
2630         Change the test expectations for this test. If the variant is not explicitly specified in
2631         the AppleLanguage, then we use the locale's country code, which this test assumes is US.
2632
2633         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2634         (TestWebKitAPI::languageForSystemLanguage):
2635         (TestWebKitAPI::TEST):
2636
2637 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2638
2639         Remove the build flag for template elements
2640         https://bugs.webkit.org/show_bug.cgi?id=157022
2641
2642         Reviewed by Daniel Bates.
2643
2644         Removed the build option.
2645
2646         * Scripts/webkitperl/FeatureList.pm:
2647
2648 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2649
2650         Fix text in log files autogenerated by import-w3c-tests
2651         https://bugs.webkit.org/show_bug.cgi?id=157021
2652
2653         Reviewed by Chris Dumez.
2654
2655         s/Webkit/WebKit/ and end each sentence with a period.
2656
2657         * Scripts/webkitpy/w3c/test_importer.py:
2658         (TestImporter.write_import_log):
2659
2660 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
2661
2662         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
2663         https://bugs.webkit.org/show_bug.cgi?id=156929
2664
2665         Reviewed by Darin Adler.
2666
2667         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2668         (TestWebKitAPI::TEST):
2669
2670 2016-04-25  Caitlin Potter  <caitp@igalia.com>
2671
2672         [Tools] whitelist all-uppercase JSTokenType enum in JavaScriptCore
2673         https://bugs.webkit.org/show_bug.cgi?id=156976
2674
2675         Reviewed by Darin Adler.
2676
2677         Mitigate style-checker spam on bugs which introduce new JavaScript
2678         token types.
2679
2680         * Scripts/webkitpy/style/checkers/cpp.py:
2681         (_EnumState.__init__):
2682         (_EnumState.process_clean_line):
2683         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2684         (NoNonVirtualDestructorsTest.test_enum_casing):
2685
2686 2016-04-25  Simon Fraser  <simon.fraser@apple.com>
2687
2688         Fix issues with content-animation performance tests
2689         https://bugs.webkit.org/show_bug.cgi?id=157001
2690
2691         Reviewed by Sam Weinig.
2692
2693         Add patch content for svg-animation.html, and fix the paths in the patch so
2694         it applies correctly.
2695
2696         Add the patch file to the .plan file.
2697
2698         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
2699         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2700
2701 2016-04-25  Brady Eidson  <beidson@apple.com>
2702
2703         Tweaking IndexedDB watchlist and adding myself to it.
2704
2705         * Scripts/webkitpy/common/config/watchlist:
2706
2707 2016-04-25  Commit Queue  <commit-queue@webkit.org>
2708
2709         Unreviewed, rolling out r199916.
2710         https://bugs.webkit.org/show_bug.cgi?id=156989
2711
2712         Might break buildbot when master is restarted (Requested by
2713         Srinivasan Vijayaraghava, Guest100, on #webkit).
2714
2715         Reverted changeset:
2716
2717         "Add JSC test results in json format to a buildbot log"
2718         https://bugs.webkit.org/show_bug.cgi?id=156920
2719         http://trac.webkit.org/changeset/199916
2720
2721 2016-04-23  Chris Dumez  <cdumez@apple.com>
2722
2723         [WebIDL] Drop [Default] WebKit-IDL extended attribute
2724         https://bugs.webkit.org/show_bug.cgi?id=156955
2725
2726         Reviewed by Darin Adler.
2727
2728         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2729
2730 2016-04-23  Csaba Osztrogonác  <ossy@webkit.org>
2731
2732         Really enable INDEXED_DATABASE on Apple Mac cmake build
2733         https://bugs.webkit.org/show_bug.cgi?id=156902
2734
2735         Reviewed by Michael Catanzaro.
2736
2737         * Scripts/webkitperl/FeatureList.pm:
2738
2739 2016-04-23  Andy Estes  <aestes@apple.com>
2740
2741         check-webkit-style: fix false-positive warnings about @synchronized
2742         https://bugs.webkit.org/show_bug.cgi?id=156957
2743
2744         Reviewed by Dan Bernstein.
2745
2746         * Scripts/webkitpy/style/checkers/cpp.py:
2747         (check_spacing_for_function_call): Ignore @synchronized lines.
2748         (check_braces): Ditto.
2749         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2750         (CppStyleTest.test_brace_at_begin_of_line): Added a test case.
2751
2752 2016-04-22  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2753
2754         Add JSC test results in json format to a buildbot log
2755         https://bugs.webkit.org/show_bug.cgi?id=156920
2756
2757         Reviewed by Alexey Proskuryakov.
2758
2759         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2760         (RunJavaScriptCoreTests):
2761         Add runtime flag to output json into buildbot
2762         * Scripts/run-javascriptcore-tests:
2763         (runJSCStressTests):
2764         Change key names and remove redundant count key
2765
2766 2016-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2767
2768         Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854
2769
2770         Unreviewed test gardening.
2771
2772         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2773         (TestWebKitAPI::TEST):
2774
2775 2016-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2776
2777         [GTK] Enable the download attribute support
2778         https://bugs.webkit.org/show_bug.cgi?id=99025
2779
2780         Reviewed by Žan Doberšek.
2781
2782         * Scripts/webkitperl/FeatureList.pm:
2783
2784 2016-04-21  Keith Miller  <keith_miller@apple.com>
2785
2786         WebScriptObject description swizzler should work in a multi-threaded world
2787         https://bugs.webkit.org/show_bug.cgi?id=156808
2788
2789         Add a test for our NSObject swizzling TLS implementation. The test runs on
2790         two threads. One in JS and another in Objective-C. We expect the JS thread
2791         to use our NSObject description override and the Objective-C thread to act
2792         as though it was using the original NSObject description method.
2793
2794         Reviewed by Geoffrey Garen.
2795
2796         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2797         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.html: Added.
2798         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm: Added.
2799         (nsObjectDescriptionTest):
2800         (-[WebScriptDescriptionTest webView:didFinishLoadForFrame:]):
2801         (TestWebKitAPI::TEST):
2802
2803 2016-04-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2804
2805         [GTK] WebKitWebView should claim the contents size as its natural size
2806         https://bugs.webkit.org/show_bug.cgi?id=156835
2807
2808         Reviewed by Žan Doberšek.
2809
2810         Add test case to check the WebKitWebView preferred size.
2811
2812         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2813         (testWebViewPreferredSize):
2814         (beforeAll):
2815
2816 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
2817
2818         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
2819         https://bugs.webkit.org/show_bug.cgi?id=156827
2820         
2821         Update the .plan file now that the files are present in SVN.
2822
2823         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2824
2825 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
2826
2827         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
2828         https://bugs.webkit.org/show_bug.cgi?id=156827
2829         rdar://problem/24358135
2830
2831         Reviewed by Stephanie Lewis.
2832
2833         Enhance benchmark_runner so that a benchmark can load a set of tests sequentially,
2834         and collate results across them. Also add the ability for the browser_driver to supply
2835         additional results, allowing for tests that collect results data in native code, rather
2836         than generating it in the web page.
2837
2838         Add a set of "content animation" tests that use this new functionality, which test
2839         CSS animation and requestAnimationFrame performance.
2840
2841         'plan' files have two new optional keys:
2842             'test_files': a list of files to run as a suite
2843             'options': optional parameters. Currently supports one new option,
2844                 'animation_command', which affects the way that iOS tests are run,
2845                 and is passed to MobileSafari as a parameter on launch.
2846
2847         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2848         (BenchmarkRunner.__init__): If options is not specified in the plan file, set it to an empty dictionary.
2849         (BenchmarkRunner._get_result): Allow the browser_driver to modify the test results.
2850         (BenchmarkRunner):
2851         (BenchmarkRunner._run_one_test): Factored out of _run_benchmark, this contains logic for
2852         running a single test. It starts and stops the http_server_driver.
2853         (BenchmarkRunner._run_benchmark): Run a test in the traditional way if the plan has an 'entry_point'
2854         key, otherwise look for the new 'test_files' and load each in a loop.
2855         (BenchmarkRunner._dump):
2856         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2857         (BrowserDriver.launch_url): Pass options.
2858         (BrowserDriver.add_additional_results): Allow a driver to supply additional results.
2859         (BrowserDriver):
2860         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py:
2861         (GTKMiniBrowserDriver.launch_url):
2862         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2863         (OSXBrowserDriver.close_browsers):
2864         (OSXBrowserDriver._terminate_processes): Fix spelling mistake.
2865         (OSXBrowserDriver._terminiate_processes): Deleted.
2866         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2867         (OSXChromeDriver.launch_url):
2868         (OSXChromeCanaryDriver.launch_url):
2869         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2870         (OSXFirefoxDriver.launch_url):
2871         (OSXFirefoxNightlyDriver.launch_url):
2872         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2873         (OSXSafariDriver.launch_url):
2874         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: Added.
2875         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: Added.
2876
2877 2016-04-20  Dustin Falgout  <dustin@falgout.us>
2878
2879         [GTK] Expose AllowUniversalAccessFromFileURLs preference now that calling localStorage.getItem() results in SecurityError: DOM Exception 18
2880         https://bugs.webkit.org/show_bug.cgi?id=156651
2881
2882         Reviewed by Michael Catanzaro.
2883
2884         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2885         (testWebKitSettings):
2886
2887 2016-04-20  Brady Eidson  <beidson@apple.com>
2888
2889         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
2890         https://bugs.webkit.org/show_bug.cgi?id=156782
2891
2892         Reviewed by Alex Christensen.
2893
2894         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2895
2896 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
2897
2898         Unreviewed build fix after r199752.
2899
2900         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2901         (FrameLoadDelegate::didChangeIcons): Remove call to removed function.
2902
2903 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
2904
2905         Remove remaining bits of dynamic <link> rel='icon' loading
2906         https://bugs.webkit.org/show_bug.cgi?id=156727
2907
2908         Reviewed by Darin Adler.
2909
2910         Remove unused test infrastructure. This code never existed in WebKit2
2911         testing since was only used on Windows.
2912
2913         * DumpRenderTree/TestRunner.cpp:
2914         (dumpIconChangesCallback): Deleted.
2915         * DumpRenderTree/TestRunner.h:
2916         (TestRunner::dumpIconChanges): Deleted.
2917         (TestRunner::setDumpIconChanges): Deleted.
2918
2919 2016-04-19  Keith Miller  <keith_miller@apple.com>
2920
2921         ObjcInstance::stringValue should not call NSObject's description method
2922         https://bugs.webkit.org/show_bug.cgi?id=156758
2923
2924         Reviewed by Geoffrey Garen.
2925
2926         Add new methods to ObjCController that expose two Types of WebScriptObjects. The first is
2927         an NSObject and the second is an NSArray of NSObjects. These are used to test that we don't
2928         call the NSObjects description method without first swizzling it.
2929
2930         * DumpRenderTree/mac/ObjCController.m:
2931         (+[ObjCController isSelectorExcludedFromWebScript:]):
2932         (+[ObjCController webScriptNameForSelector:]):
2933         (-[ObjCController testArrayOfObjects]):
2934         (-[ObjCController testObject]):
2935
2936 2016-04-18  Dan Bernstein  <mitz@apple.com>
2937
2938         Fixed building with old Xcode.
2939
2940         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2941         (TEST):
2942
2943 2016-04-18  Dean Jackson  <dino@apple.com>
2944
2945         New SPI to export a dictionary of runtime features
2946         https://bugs.webkit.org/show_bug.cgi?id=156645
2947         <rdar://problem/23621666>
2948
2949         Reviewed by Darin Adler.
2950
2951         Test the experimental features SPI on WKPreferences.
2952
2953         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2954
2955 2016-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
2956
2957         [JSCOnly] Implement RunLoop and remove glib dependency
2958         https://bugs.webkit.org/show_bug.cgi?id=155706
2959
2960         Reviewed by Michael Catanzaro.
2961
2962         Add TestWTF to JSCOnly port to test WorkQueue and RunLoop.
2963         Platform specific ones locate under jsconly directory since
2964         it is not `generic` (Since it includes the GLIB event loop case).
2965
2966         * CMakeLists.txt:
2967         * TestWebKitAPI/PlatformJSCOnly.cmake: Added.
2968         * TestWebKitAPI/PlatformUtilities.h:
2969         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2970         (TestWebKitAPI::TEST):
2971         * TestWebKitAPI/config.h:
2972         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp: Renamed from Source/WTF/wtf/none/RunLoopNone.cpp.
2973         (TestWebKitAPI::Util::run):
2974         (TestWebKitAPI::Util::sleep):
2975         * TestWebKitAPI/jsconly/main.cpp: Renamed from Source/WTF/wtf/none/WorkQueueNone.cpp.
2976         (main):
2977
2978 2016-04-18  Jon Lee  <jonlee@apple.com>
2979
2980         Update Animometer plan.
2981         https://bugs.webkit.org/show_bug.cgi?id=156652
2982
2983         Reviewed by Darin Adler.
2984
2985         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199616.
2986
2987 2016-04-18  Dana Burkart  <dburkart@apple.com>
2988
2989         svn-apply: add option for ignoring changes to ChangeLog files
2990         https://bugs.webkit.org/show_bug.cgi?id=156618
2991
2992         Reviewed by Darin Adler.
2993
2994         This change adds a new option to svn-apply, --skip-changelogs, which short-circuits out of
2995         patch() if the file in question is a ChangeLog.
2996
2997         * Scripts/svn-apply:
2998         (patch):
2999
3000 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3001
3002         Pending API Request URL is wrong after reloading
3003         https://bugs.webkit.org/show_bug.cgi?id=139342
3004
3005         Reviewed by Darin Adler.
3006
3007         Update test case to check that the active URL should remain the
3008         same after a reload.
3009
3010         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp:
3011         (TestWebKitAPI::TEST):
3012
3013 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3014
3015         Pending API request URL no set when loading Data, Alternate HTML or plain text
3016         https://bugs.webkit.org/show_bug.cgi?id=136916
3017
3018         Reviewed by Darin Adler.
3019
3020         Add new test to check that active URL is the requested one right
3021         after calling WKPage load methods.
3022
3023         * TestWebKitAPI/PlatformEfl.cmake:
3024         * TestWebKitAPI/PlatformGTK.cmake:
3025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3026         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
3027         (TestWebKitAPI::TEST):
3028         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3029         (WebViewTest::loadPlainText): Remove FIXME.
3030         (WebViewTest::loadBytes): Ditto.
3031         (WebViewTest::loadAlternateHTML): Ditto.
3032
3033 2016-04-18  Commit Queue  <commit-queue@webkit.org>
3034
3035         Unreviewed, rolling out r199660.
3036         https://bugs.webkit.org/show_bug.cgi?id=156691
3037
3038         It broke the iOS build (Requested by KaL on #webkit).
3039
3040         Reverted changeset:
3041
3042         "Pending API request URL no set when loading Data, Alternate
3043         HTML or plain text"
3044         https://bugs.webkit.org/show_bug.cgi?id=136916
3045         http://trac.webkit.org/changeset/199660
3046
3047 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3048
3049         Pending API request URL no set when loading Data, Alternate HTML or plain text
3050         https://bugs.webkit.org/show_bug.cgi?id=136916
3051
3052         Reviewed by Darin Adler.
3053
3054         Add new test to check that active URL is the requested one right
3055         after calling WKPage load methods.
3056
3057         * TestWebKitAPI/PlatformEfl.cmake:
3058         * TestWebKitAPI/PlatformGTK.cmake:
3059         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3060         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
3061         (TestWebKitAPI::TEST):
3062         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3063         (WebViewTest::loadPlainText): Remove FIXME.
3064         (WebViewTest::loadBytes): Ditto.
3065         (WebViewTest::loadAlternateHTML): Ditto.
3066
3067 2016-04-18  Jeremy Huddleston Sequoia  <jeremyhu@apple.com>
3068
3069         Fix incorrect assumption that APPLE implies Mac.
3070         https://bugs.webkit.org/show_bug.cgi?id=156679
3071
3072         Addresses build failure introduced in r198947
3073
3074         Reviewed by Alex Christensen.
3075
3076         * CMakeLists.txt:
3077
3078 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3079
3080         [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
3081         https://bugs.webkit.org/show_bug.cgi?id=156621
3082
3083         Reviewed by Martin Robinson.
3084
3085         This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
3086         scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
3087         simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
3088
3089         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3090         (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
3091
3092 2016-04-17  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3093
3094         [EFL] Bump gstreamer from 1.4.4 to 1.6.3
3095         https://bugs.webkit.org/show_bug.cgi?id=156655
3096
3097         Reviewed by Antonio Gomes.
3098
3099         To support html5 video feature, we should bump gstreamer version.
3100
3101         * efl/jhbuild.modules:
3102         * efl/patches/gst-libav.patch: Update against newer version.
3103         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed because this patch was merged.
3104
3105 2016-04-16  Sam Weinig  <sam@webkit.org>
3106
3107         More build fixing.
3108
3109         * MiniBrowser/mac/BrowserWindowController.m:
3110         (-[BrowserWindowController share:]):
3111
3112 2016-04-16  Sam Weinig  <sam@webkit.org>
3113
3114         Another build fix.
3115
3116         * MiniBrowser/mac/BrowserWindowController.m:
3117         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
3118
3119 2016-04-16  Sam Weinig  <sam@webkit.org>
3120
3121         Fix 32-bit build.
3122
3123         * MiniBrowser/mac/BrowserWindowController.m:
3124         (-[BrowserWindowController share:]):
3125         (-[BrowserWindowController fetch:]):
3126         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
3127
3128 2016-04-15  Sam Weinig  <sam@webkit.org>
3129
3130         Add support for NSSharingService to MiniBrowser, for no great reasons
3131         https://bugs.webkit.org/show_bug.cgi?id=156658
3132
3133         Reviewed by Darin Adler.
3134
3135         * MiniBrowser/mac/BrowserWindow.xib:
3136         * MiniBrowser/mac/BrowserWindowController.h:
3137         Add the share button.
3138
3139         * MiniBrowser/mac/BrowserWindowController.m:
3140         (-[BrowserWindowController windowDidLoad]):
3141         Set the share button to fire it's actions on mouse down, as it is supposed to act like a menu.
3142
3143         (-[BrowserWindowController share:]):
3144         Show the picker when the button is pressed.
3145         (-[BrowserWindowController mainContentView]):
3146         Add a new override to get the main content view of derived classes (either a WKWebView or the WebView).
3147
3148         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
3149         (-[BrowserWindowController sharingServicePicker:delegateForSharingService:]):
3150         (-[BrowserWindowController sharingServicePicker:didChooseSharingService:]):
3151         (-[BrowserWindowController sharingService:sourceFrameOnScreenForShareItem:]):
3152         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
3153         (-[BrowserWindowController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3154         Add delegate methods.
3155
3156         * MiniBrowser/mac/WK1BrowserWindowController.m:
3157         (-[WK1BrowserWindowController mainContentView]):
3158         * MiniBrowser/mac/WK2BrowserWindowController.m:
3159         (-[WK2BrowserWindowController mainContentView]):
3160         Implement to return the web view.
3161
3162 2016-04-16  Alexey Proskuryakov  <ap@apple.com>
3163
3164         Build fix.
3165
3166         Temporary workaround for rdar://problem/25754945.
3167
3168         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3169
3170 2016-04-15  Commit Queue  <commit-queue@webkit.org>
3171
3172         Unreviewed, rolling out r199600.
3173         https://bugs.webkit.org/show_bug.cgi?id=156642
3174
3175         It didn't help (Requested by ap_ on #webkit).
3176
3177         Reverted changeset:
3178
3179         "Build fix."
3180         http://trac.webkit.org/changeset/199600
3181
3182 2016-04-15  Alexey Proskuryakov  <ap@apple.com>
3183
3184         Build fix.
3185
3186         * LayoutTestRelay/LayoutTestRelay/main.m: Allow some deprecated methods.
3187
3188 2016-04-14  Alexey Proskuryakov  <ap@apple.com>
3189
3190         Some GuardMalloc bots are not happy when running many parallel processes
3191         https://bugs.webkit.org/show_bug.cgi?id=156614
3192         rdar://problem/24711525
3193
3194         Reviewed by David Kilzer.
3195
3196         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
3197
3198 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
3199
3200         Make <a download> a runtime enabled option
3201         https://bugs.webkit.org/show_bug.cgi?id=156583
3202         <rdar://problem/25733449>
3203
3204         Reviewed by Alex Christensen.
3205
3206         * DumpRenderTree/mac/DumpRenderTree.mm:
3207         (resetWebPreferencesToConsistentValues):
3208         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3209         (WTR::InjectedBundle::beginTesting):
3210         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3211         (WTR::TestRunner::setDownloadAttributeEnabled):
3212         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3213
3214 2016-04-14  Anders Carlsson  <andersca@apple.com>
3215
3216         Another build fix attempt.
3217
3218         * MiniBrowser/mac/WK2BrowserWindowController.m:
3219
3220 2016-04-14  Anders Carlsson  <andersca@apple.com>
3221
3222         Fix build.
3223
3224         * MiniBrowser/mac/WK2BrowserWindowController.m:
3225         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3226
3227 2016-04-14  Anders Carlsson  <andersca@apple.com>
3228
3229         [Mac] Add API for open panel handling to WKWebView
3230         https://bugs.webkit.org/show_bug.cgi?id=137759
3231         rdar://problem/23278623
3232
3233         Reviewed by Tim Horton.
3234
3235         Have MiniBrowser implement the new delegate method.
3236
3237         * MiniBrowser/mac/WK2BrowserWindowController.m:
3238         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3239
3240 2016-04-14  Jiewen Tan  <jiewen_tan@apple.com>
3241
3242         Unreviewed, rolling out r199554.
3243
3244         The change breaks Yosemite Release/Debug build
3245
3246         Reverted changeset:
3247
3248         "[Mac] Add API for open panel handling to WKWebView"
3249         https://bugs.webkit.org/show_bug.cgi?id=137759
3250         http://trac.webkit.org/changeset/199554
3251
3252 2016-04-14  Anders Carlsson  <andersca@apple.com>
3253
3254         [Mac] Add API for open panel handling to WKWebView
3255         https://bugs.webkit.org/show_bug.cgi?id=137759
3256         rdar://problem/23278623
3257
3258         Reviewed by Tim Horton.
3259
3260         Have MiniBrowser implement the new delegate method.
3261
3262         * MiniBrowser/mac/WK2BrowserWindowController.m:
3263         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3264
3265 2016-04-14  Jon Lee  <jonlee@apple.com>
3266
3267         Update Animometer plan
3268         https://bugs.webkit.org/show_bug.cgi?id=156569
3269
3270         Reviewed by Alex Christensen.
3271
3272         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199328. Includes update to screen
3273         resolution, starting with complexity of 1, and fixing SVG, multiply, and text tests.
3274
3275 2016-04-13  Alex Christensen  <achristensen@webkit.org>
3276
3277         CMake MiniBrowser should be an app bundle
3278         https://bugs.webkit.org/show_bug.cgi?id=156521
3279
3280         Reviewed by Brent Fulgham.
3281
3282         * MiniBrowser/mac/CMakeLists.txt:
3283         Make an app bundle and compile nibs.
3284         * MiniBrowser/mac/Info.plist:
3285         CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it.  This is just MiniBrowser.
3286
3287 2016-04-13  Chris Dumez  <cdumez@apple.com>
3288
3289         We should not speculatively revalidate cached redirects
3290         https://bugs.webkit.org/show_bug.cgi?id=156548
3291         <rdar://problem/25583886>
3292
3293         Reviewed by Darin Adler.
3294
3295         Re-enable speculative loading in the context of layout tests. This was
3296         turned off by mistake when speculative loading was turned into a
3297         setting recently.
3298
3299         * WebKitTestRunner/TestController.cpp:
3300         (WTR::TestController::generatePageConfiguration):
3301
3302 2016-04-12  Alexey Proskuryakov  <ap@apple.com>
3303
3304         Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
3305         https://bugs.webkit.org/show_bug.cgi?id=155367
3306
3307         Reviewed by Darin Adler.
3308
3309         * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
3310         Don't flakily consume the return code with waitpid, callers need to do waitpid on
3311         their own. Not sure if this line of code was even intentional.
3312
3313 2016-04-12  Myles C. Maxfield  <mmaxfield@apple.com>
3314
3315         [OS X] Flakey crash after ScrollAnimatorMac destruction
3316         https://bugs.webkit.org/show_bug.cgi?id=156372
3317
3318         Reviewed by Darin Adler.
3319
3320         Implement the new <!-- webkit-test-runner --> flag.
3321
3322         * WebKitTestRunner/TestController.cpp:
3323         (WTR::TestController::createWebViewWithOptions):
3324         (WTR::TestController::ensureViewSupportsOptionsForTest):
3325         (WTR::TestController::resetPreferencesToConsistentValues):
3326         (WTR::TestController::resetStateToConsistentValues):
3327         (WTR::updateTestOptionsFromTestHeader):
3328         * WebKitTestRunner/TestController.h:
3329         * WebKitTestRunner/TestInvocation.cpp:
3330         (WTR::TestInvocation::invoke):
3331         * WebKitTestRunner/TestOptions.h:
3332         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3333         (WKR::PlatformWebView::viewSupportsOptions):
3334
3335 2016-04-12  Tomas Popela  <tpopela@redhat.com>
3336
3337         Modify the CXXFLAGS in webkitdirs.pm just on architectures where the flags are supported
3338         https://bugs.webkit.org/show_bug.cgi?id=156338
3339
3340         Reviewed by Michael Catanzaro.
3341
3342         Add the "-march=pentium4 -msse2 -mfpmath=sse " into the CXXFLAGS just
3343         for the i686 where it is supported and not for other architectures
3344         (such as s390(x) and ppc(64)) where the build will fail with these
3345         CXXFLAGS.
3346
3347         * Scripts/webkitdirs.pm:
3348         (generateBuildSystemFromCMakeProject):
3349
3350 2016-04-11  Alex Christensen  <achristensen@webkit.org>
3351
3352         Build MiniBrowser with CMake on Mac
3353         https://bugs.webkit.org/show_bug.cgi?id=156471
3354
3355         Reviewed by Daniel Bates.
3356
3357         * CMakeLists.txt:
3358         * DumpRenderTree/CMakeLists.txt:
3359         * DumpRenderTree/PlatformWin.cmake:
3360         * MiniBrowser/mac/CMakeLists.txt: Added.
3361
3362 2016-04-11  Ryuan Choi  <ryuan.choi@navercorp.com>
3363
3364         [EFL] Do not pass context to EwkViewCreate
3365         https://bugs.webkit.org/show_bug.cgi?id=156461
3366
3367         Reviewed by Darin Adler.
3368
3369         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
3370         (TestWebKitAPI::TEST): Removed context argument from EwkViewCreate calls.
3371         * TestWebKitAPI/efl/PlatformWebView.cpp:
3372         (TestWebKitAPI::PlatformWebView::PlatformWebView): Ditto.
3373         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3374         (WTR::PlatformWebView::PlatformWebView): Ditto.
3375
3376 2016-04-11  Fujii Hironori  <Hironori.Fujii@jp.sony.com>
3377
3378         [CMake] Make FOLDER property INHERITED
3379         https://bugs.webkit.org/show_bug.cgi?id=156460
3380
3381         Reviewed by Brent Fulgham.
3382
3383         * CMakeLists.txt:
3384         * DumpRenderTree/CMakeLists.txt:
3385         * DumpRenderTree/PlatformWin.cmake:
3386         * ImageDiff/CMakeLists.txt:
3387         * MiniBrowser/efl/CMakeLists.txt:
3388         * MiniBrowser/gtk/CMakeLists.txt:
3389         * MiniBrowser/win/CMakeLists.txt:
3390         Set FOLDER property as a directory property not a target property
3391
3392 2016-04-10  Caitlin Potter  <caitp@igalia.com>
3393
3394         [Tools] correctly check for braces in multiline branches in macro definition
3395         https://bugs.webkit.org/show_bug.cgi?id=156441
3396
3397         Reviewed by Darin Adler.
3398
3399         Prevents emitting whitespace/braces warning for code like the
3400         following:
3401
3402         ```
3403         #define MACRO(x) \
3404             if (x) { \
3405                 doTheThing(); \
3406                 continue; \
3407             }
3408         ```
3409
3410         * Scripts/webkitpy/style/checkers/cpp.py:
3411         (check_braces):
3412         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3413         (WebKitStyleTest.test_line_breaking):
3414
3415 2016-04-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3416
3417         Testharness-based tests that time out should be able to produce a detailed output
3418         https://bugs.webkit.org/show_bug.cgi?id=145313
3419
3420         Reviewed by Xabier Rodriguez-Calvar.
3421
3422         Adding timeout readonly accessor to TestRunner for both WK1 and WK2.
3423
3424         * DumpRenderTree/TestRunner.cpp:
3425         (getTimeoutCallback): The js "timeout" property getter.
3426         (TestRunner::staticValues): Adding "timeout" property to DumpRenderTree so that testRunner.timeout called from JS returns the timeout value.
3427         * DumpRenderTree/TestRunner.h:
3428         (TestRunner::timeout): Adding access to DRT m_timeout private value.
3429         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding timeout readonly attribute so that testRunner.timeout can be called from JS.
3430         * WebKitTestRunner/InjectedBundle/TestRunner.h: Adding DOM timeout getter to implement timeout IDL definition.
3431         (WTR::TestRunner::timeout):
3432
3433 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
3434
3435         stylebot should know about TestWebKitAPI FeatureDefines.xcconfig
3436         https://bugs.webkit.org/show_bug.cgi?id=156387
3437
3438         Rubber-stamped by Dan Bernstein.
3439
3440         * Scripts/webkitpy/style/checkers/featuredefines.py:
3441         (FeatureDefinesChecker.check):
3442
3443 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
3444
3445         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
3446         https://bugs.webkit.org/show_bug.cgi?id=156384
3447
3448         Reviewed by Ryosuke Niwa.
3449
3450         * Scripts/webkitperl/FeatureList.pm:
3451         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3452
3453 2016-04-06  Dean Jackson  <dino@apple.com>
3454
3455         Watchlist modifications:
3456         - remove roger_fong
3457         - add myself to a few areas
3458         - remove graouts from WebInspectorAPI
3459
3460         * Scripts/webkitpy/common/config/watchlist:
3461
3462 2016-04-07  Simon Fraser  <simon.fraser@apple.com>
3463
3464         Make it possible to test effect of view exposed rect on tiled backing
3465         https://bugs.webkit.org/show_bug.cgi?id=156365
3466
3467         Reviewed by Tim Horton.
3468
3469         Expose testRunner.setViewSize() and internals.setViewExposedRect() to enable
3470         testing of tile coverage when setViewExposedRect() is passed a non-null rectangle.
3471
3472         testRunner.setViewSize() is used instead of using window.resizeTo(), since we
3473         can't easily resize a window to larger than the screen being tested on.
3474
3475         * DumpRenderTree/TestRunner.cpp:
3476         (setViewSizeCallback):
3477         (TestRunner::staticFunctions):
3478         * DumpRenderTree/TestRunner.h:
3479         * DumpRenderTree/mac/TestRunnerMac.mm:
3480         (TestRunner::setViewSize):
3481         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3482         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3483         (WTR::InjectedBundle::postSetViewSize):
3484         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3485         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3486         (WTR::TestRunner::setViewSize):
3487         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3488         * WebKitTestRunner/TestInvocation.cpp:
3489         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3490
3491 2016-04-07  Jason Marcell  <jmarcell@apple.com>
3492
3493         Adding layout tests for the bot watcher's dashboard QUnit tests.
3494         https://bugs.webkit.org/show_bug.cgi?id=155272
3495
3496         Reviewed by Daniel Bates.
3497
3498         Moved supporting resources into a resources folder and updated index.html accordingly
3499         to point to the new locations. Added code to tests.js to dumpAsText when QUnit is done.
3500
3501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt: Added.
3502         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Updated to point to tests.js and Mock files in resources directory.
3503         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: Renamed from
3504         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js.
3505         (MockBuildbotQueue):
3506         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueueView.js: Renamed from
3507         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js.
3508         (MockBuildbotQueueView):
3509         (MockBuildbotQueueView.prototype._latestProductiveIteration):
3510         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js: Renamed from
3511         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js.
3512         (MockTrac):
3513         (MockTrac.prototype.get oldestRecordedRevisionNumber):
3514         (MockTrac.prototype.get latestRecordedRevisionNumber):
3515         (MockTrac.prototype.loadMoreHistoricalData):
3516         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-git-trac-rss.xml: Renamed from
3517         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml.
3518         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-trac-rss.xml: Renamed from
3519         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml.
3520         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Renamed from
3521         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js.
3522         Updated the unit tests for Trac._loaded() to point to the XML files that are now located in the 'resources' directory.
3523         (QUnit.done): Added. Removes machine-specific output from test results and calls testRunner.notifyDone to let the layout test harness know that all testing is done.
3524         * Scripts/run-dashboard-tests: Added.
3525
3526 2016-04-06  ChangSeok Oh  <changseok@webkit.org>
3527
3528         Unreviewed, Update my primary email address and expertise.
3529
3530         * Scripts/webkitpy/common/config/contributors.json:
3531
3532 2016-04-06  Jon Lee  <jonlee@apple.com>
3533
3534         Update the Animometer patch and plan files
3535         https://bugs.webkit.org/show_bug.cgi?id=156263
3536
3537         Reviewed by Ryosuke Niwa.
3538
3539         Measure the latest set of tests by updating the plan revision to r199134.
3540
3541         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Update to run the master suite only.
3542         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to use the release page instead
3543         of the developer page.
3544
3545 2016-04-06  Saam barati  <sbarati@apple.com>
3546
3547         jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989
3548         https://bugs.webkit.org/show_bug.cgi?id=156187
3549
3550         Reviewed by Keith Miller.
3551
3552         * Scripts/run-jsc-stress-tests:
3553
3554 2016-04-06  Alex Christensen  <achristensen@webkit.org>
3555
3556         Compile WebKitTestRunner with CMake on Mac
3557         https://bugs.webkit.org/show_bug.cgi?id=156310
3558
3559         Reviewed by Daniel Bates.
3560
3561         * CMakeLists.txt:
3562         * WebKitTestRunner/CMakeLists.txt:
3563         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3564         * WebKitTestRunner/PlatformEfl.cmake:
3565         * WebKitTestRunner/PlatformGTK.cmake:
3566         * WebKitTestRunner/PlatformMac.cmake: Added.
3567
3568 2016-04-05  Simon Fraser  <simon.fraser@apple.com>
3569
3570         Implement operator== and operator!= for Optional<>
3571         https://bugs.webkit.org/show_bug.cgi?id=156266
3572
3573         Reviewed by Anders Carlsson.
3574
3575         * TestWebKitAPI/Tests/WTF/Optional.cpp:
3576         (TestWebKitAPI::TEST):
3577
3578 2016-04-05  Alex Christensen  <achristensen@webkit.org>
3579
3580         Make CMake-generated binaries on Mac able to run
3581         https://bugs.webkit.org/show_bug.cgi?id=156268
3582
3583         Reviewed by Daniel Bates.
3584
3585         * DumpRenderTree/CMakeLists.txt:
3586         * DumpRenderTree/PlatformMac.cmake:
3587         * DumpRenderTree/PlatformWin.cmake:
3588         * TestWebKitAPI/PlatformMac.cmake:
3589
3590 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3591
3592         [Fetch API] Add a runtime flag to fetch API and related constructs
3593         https://bugs.webkit.org/show_bug.cgi?id=156113
3594  
3595         Reviewed by Alex Christensen.
3596
3597         * DumpRenderTree/TestRunner.h:
3598         * DumpRenderTree/mac/DumpRenderTree.mm:
3599         (resetWebPreferencesToConsistentValues):
3600         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3601         (WTR::InjectedBundle::beginTesting):
3602         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3603         (WTR::TestRunner::setWebGL2Enabled):
3604         (WTR::TestRunner::setFetchAPIEnabled):
3605         (WTR::TestRunner::setAllowUniversalAccessFromFileURLs):
3606         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3607
3608 2016-04-05  Keith Miller  <keith_miller@apple.com>
3609
3610         Make Keith a reviewer!
3611         https://bugs.webkit.org/show_bug.cgi?id=156246
3612
3613         Reviewed by Mark Lam.
3614
3615         * Scripts/webkitpy/common/config/contributors.json:
3616
3617 2016-04-05  Antoine Quint  <graouts@apple.com>
3618
3619         [WebGL2] Allow enabling WebGL2 with a runtime flag
3620         https://bugs.webkit.org/show_bug.cgi?id=156166
3621         <rdar://problem/25526929>
3622
3623         Always enable WebGL2 during testing.
3624
3625         Reviewed by Dean Jackson.
3626
3627         * DumpRenderTree/mac/DumpRenderTree.mm:
3628         (resetWebPreferencesToConsistentValues):
3629         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3630         (WTR::InjectedBundle::beginTesting):
3631         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3632         (WTR::TestRunner::setWebGL2Enabled):
3633         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3634
3635 2016-04-04  Bill Ming  <mbbill@gmail.com>
3636
3637         [win] run-webkit-tests failed to launch DumpRenderTree
3638         https://bugs.webkit.org/show_bug.cgi?id=156150
3639
3640         Reviewed by Alex Christensen.
3641
3642         * Tools/Scripts/webkitpy/port/base.py:
3643
3644 2016-04-04  Bill Ming  <mbbill@gmail.com>
3645
3646         prepare-ChangeLog set endl incorrectly.
3647         https://bugs.webkit.org/show_bug.cgi?id=156151
3648
3649         Reviewed by Alex Christensen.
3650
3651         * Tools/Scripts/prepare-ChangeLog:
3652
3653 2016-04-03  Sam Weinig  <sam@webkit.org>
3654
3655         Add SPI to allow install script message handlers in isolated worlds
3656         https://bugs.webkit.org/show_bug.cgi?id=156153
3657
3658         Reviewed by Anders Carlsson.
3659
3660         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3661         Add new test, WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld