1 2015-03-10 Benjamin Poulain <bpoulain@apple.com>
3 Extend URL filter's Term definition to support groups/subpatterns
4 https://bugs.webkit.org/show_bug.cgi?id=142519
6 Reviewed by Alex Christensen.
8 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
9 (TestWebKitAPI::testURL):
11 2015-03-06 Jer Noble <jer.noble@apple.com>
13 Add an option to run-webkit-tests to override the LayoutTests/ directory
14 https://bugs.webkit.org/show_bug.cgi?id=142418
16 Reviewed by David Kilzer.
18 Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
19 directory. The base port will parse the options during initialization and store the override
20 location if present. layout_tests_dir() will return this overridden location if set.
22 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
24 * Scripts/webkitpy/port/base.py:
26 (Port.layout_tests_dir):
28 2015-03-09 Martin Robinson <mrobinson@igalia.com>
30 [CMake] Enable WorkQueue tests for CMake ports
31 https://bugs.webkit.org/show_bug.cgi?id=142473
33 Reviewed by Darin Adler.
35 * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
36 the list of source files.
37 * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
38 to the list of include directories for EFL.
40 2015-03-09 David Kilzer <ddkilzer@apple.com>
42 Attempt to fix timeouts on iOS Simulator layout tests
44 * Scripts/webkitpy/port/ios.py:
45 (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
46 Simulator end after the first 50 tests time out. Some analysis
47 this past weekend shows that the 'Booted' status in the output
48 of `xcrun simctl list` is not sufficient (and watching the test
49 run shows that SpringBoard hasn't fully started to the point
50 where it's displaying icons on the home screen). The workaround
51 until we have a better fix is to add an arbitrary timeout to let
52 SpringBoard finish launching. In practice, 15 seconds is
53 probably enough, but 30 seconds should nearly always work.
55 2015-03-09 Per Arne Vollan <peavo@outlook.com>
57 Unreviewed. Add myself as a committer.
59 * Scripts/webkitpy/common/config/contributors.json:
61 2015-03-09 David Kilzer <ddkilzer@apple.com>
63 Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
65 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
66 (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
67 an expectation that will fail if we hit the race condition.
68 This test is inherently racy and will deadlock if the first job
69 for queue2 takes the mutex lock before the second job for
72 2015-03-08 Brent Fulgham <bfulgham@apple.com>
74 [Win] WTF::WorkQueue does not balance ref/deref properly
75 https://bugs.webkit.org/show_bug.cgi?id=142471
77 Reviewed by Antti Koivisto.
79 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
80 (TestWebKitAPI::TEST): Check that the refcount is correct.
82 2015-03-08 Gyuyoung Kim <gyuyoung.kim@samsung.com>
84 Do not show passing test result on output of EFL layout test
85 https://bugs.webkit.org/show_bug.cgi?id=142380
87 Reviewed by Darin Adler.
89 To show passing tests has caused inconvenience when we detect problem tests
90 in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
91 in order not to show passing tests in the output of EFL layout test.
93 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
94 (RunWebKitTests.start):
96 2015-03-08 Brent Fulgham <bfulgham@apple.com>
100 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
101 (TestWebKitAPI::TEST): Remove two unused variables.
103 2015-03-08 Brent Fulgham <bfulgham@apple.com>
105 Add some WorkQueue tests to TestWebKitAPI
106 https://bugs.webkit.org/show_bug.cgi?id=142447
108 Reviewed by Sam Weinig.
110 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
111 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
112 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
113 * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
114 (TestWebKitAPI::simpleTest):
115 (TestWebKitAPI::longTest):
116 (TestWebKitAPI::thirdTest):
117 (TestWebKitAPI::finishedTests):
118 (TestWebKitAPI::TEST):
119 (TestWebKitAPI::longTest2):
121 2015-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
123 Remove willDestroyFrame in WKBundlePageLoaderClient
124 https://bugs.webkit.org/show_bug.cgi?id=142389
126 Reviewed by Anders Carlsson.
128 * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
129 (WTR::InjectedBundlePage::InjectedBundlePage):
131 2015-03-07 Brent Fulgham <bfulgham@apple.com>
133 [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
134 https://bugs.webkit.org/show_bug.cgi?id=142433
136 Reviewed by Darin Adler.
138 Include more TestWebKitAPI tests when building for Windows. Also
139 fix a build error in MetaAllocator.cpp caused by one of the
140 Microsoft headers #defining 'small'.
142 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
143 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
144 * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
146 2015-03-06 Sam Weinig <sam@webkit.org>
148 [Content Extensions] Move compiling of content extensions to the UIProcess
149 https://bugs.webkit.org/show_bug.cgi?id=142402
151 Reviewed by Benjamin Poulain.
153 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
154 * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
155 (TestWebKitAPI::InMemoryCompiledContentExtension::create):
156 (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
157 (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
158 (TestWebKitAPI::TEST_F):
159 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
160 Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
163 2015-03-06 Brent Fulgham <bfulgham@apple.com>
165 [Win] Correct Windows build.
167 Rubberstamped by Michael Saboff
169 * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
172 2015-03-06 Carlos Garcia Campos <cgarcia@igalia.com>
174 [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
175 https://bugs.webkit.org/show_bug.cgi?id=142385
177 Reviewed by Sergio Villar Senin.
179 Use stack allocated GMainLoopSources to make sure they are
180 cancelled automatically if the test finishes before they have
183 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
184 (testWebViewSyncRequestOnMaxConns):
186 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
188 Remove Mountain Lion libraries since ML isn't supported
189 https://bugs.webkit.org/show_bug.cgi?id=142332
191 Reviewed by Darin Adler.
193 * Scripts/copy-webkitlibraries-to-product-directory:
195 2015-03-06 Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet <youenn.fablet@crf.canon.fr>
197 Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
198 https://bugs.webkit.org/show_bug.cgi?id=142083
200 Reviewed by Simon Fraser.
202 Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
204 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
205 (WebPlatformTestServer._copy_webkit_test_files):
207 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
209 setup-git-clone fails due to the failure to download python-irclib-0.4.8
210 https://bugs.webkit.org/show_bug.cgi?id=141946
212 Reviewed by Ryosuke Niwa.
214 Check in ircbot.py and irclib.py to avoid network problems in the future.
216 * Scripts/webkitpy/common/net/irc/ircbot.py:
217 * Scripts/webkitpy/thirdparty/__init__.py:
218 (AutoinstallImportHook.find_module):
219 (AutoinstallImportHook._install_irc): Deleted.
220 * Scripts/webkitpy/thirdparty/__init___unittest.py:
221 (ThirdpartyTest.test_imports):
222 * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
223 * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
224 * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
226 2015-03-06 David Kilzer <ddkilzer@apple.com>
228 Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
230 See also fix to config.json in r181097.
232 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
233 (WebKitBuildbot): Add missing "WK2" to the names of the perf
236 2015-03-06 Csaba Osztrogonác <ossy@webkit.org>
238 run-jsc-stress-tests should determine the architecture from ELF binaries
239 https://bugs.webkit.org/show_bug.cgi?id=142335
241 Reviewed by Darin Adler.
243 * Scripts/run-jsc-stress-tests:
245 2015-03-05 David Kilzer <ddkilzer@apple.com>
247 [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
248 <http://webkit.org/b/142226>
250 Reviewed by Darin Adler.
252 * Scripts/webkitpy/port/ios.py:
253 (IOSSimulatorPort.default_baseline_search_path): Switch the
254 TestExpectations order of ios-simulator-wk2 from this:
255 ios-simulator-wk2, wk2, ios-simulator
257 ios-simulator-wk2, ios-simualtor, wk2
259 2015-03-05 Brent Fulgham <bfulgham@apple.com>
261 [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
262 https://bugs.webkit.org/show_bug.cgi?id=142370
264 Reviewed by Dean Jackson.
266 * Scripts/webkitdirs.pm:
267 (buildVisualStudioProject): Tell MSBuild to output log files to two separate
268 logs, one for warnings, the other for errors.
269 * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
270 into the standard BuildOutput.htm document.
272 2015-03-05 David Kilzer <ddkilzer@apple.com>
274 Dashboard has trouble parsing iOS test output
275 <http://webkit.org/b/142364>
277 Reviewed by Alex Christensen.
279 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
280 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
281 Add fallback path to build a regex using 'matchString' so that
282 it matches anywhere in the line. In practice, 'matchString' is
283 a prefix for the label following the number.
285 2015-03-05 Alex Christensen <achristensen@webkit.org>
287 Fix linker warnings in TestWebKitAPI.
288 https://bugs.webkit.org/show_bug.cgi?id=141912
290 Reviewed by David Kilzer.
292 * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
293 Do not export TearDownTestCase or SetUpTestCase symbols.
295 2015-03-05 Brent Fulgham <bfulgham@apple.com>
297 [Win] Unreviewed EWS fix.
299 * Scripts/webkitdirs.pm:
300 (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
301 the EWS output more usable.
303 2015-03-05 Chris Dumez <cdumez@apple.com>
305 Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
306 https://bugs.webkit.org/show_bug.cgi?id=142350
308 Reviewed by Michael Saboff and Benjamin Poulain.
310 Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
311 crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
313 * TestWebKitAPI/Tests/WTF/WTFString.cpp:
314 (TestWebKitAPI::TEST):
316 2015-03-05 Brent Fulgham <bfulgham@apple.com>
318 [Win] Ensure build target directory exists when launching MSBuild
319 https://bugs.webkit.org/show_bug.cgi?id=142360
321 Reviewed by Dean Jackson.
323 Create the build output directory (if it doesn't exist) before
324 launching MSBuild so that it can immediately begin writing logs.
326 * Scripts/webkitdirs.pm:
327 (buildVisualStudioProject):
329 2015-03-05 Chris Dumez <cdumez@apple.com>
331 run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
332 https://bugs.webkit.org/show_bug.cgi?id=142325
334 Reviewed by Csaba Osztrogonác.
336 run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
337 As a result, "--webkit-test-runner / -2" parameters are replaced by
338 "--dump-render-tree / -1" so developers can run DumpRenderTree rather
339 than WebKitTestRunner.
341 * BuildSlaveSupport/build.webkit.org-config/config.json:
342 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
344 (RunWebKit1Tests.start):
345 (RunWebKit1LeakTests):
346 (RunWebKit1LeakTests.start):
347 (RunAndUploadPerfTestsWebKit1):
348 (RunAndUploadPerfTestsWebKit1.start):
350 (TestWebKit1LeaksFactory):
351 (TestWebKit1LeaksFactory.__init__):
352 (TestWebKit1Factory):
353 (TestWebKit1AllButJSCFactory):
354 (TestAllButJSCFactory):
355 (BuildAndPerfTestWebKit1Factory):
356 (BuildAndPerfTestWebKit1Factory.__init__):
357 (BuildAndPerfTestFactory):
358 (BuildAndPerfTestFactory.__init__):
359 (DownloadAndPerfTestWebKit1Factory):
360 (DownloadAndPerfTestWebKit1Factory.__init__):
361 (DownloadAndPerfTestFactory):
362 (DownloadAndPerfTestFactory.__init__):
363 (RunWebKitLeakTests): Deleted.
364 (RunWebKitLeakTests.start): Deleted.
365 (RunWebKit2Tests): Deleted.
366 (RunWebKit2Tests.start): Deleted.
367 (RunAndUploadPerfTestsWebKit2): Deleted.
368 (RunAndUploadPerfTestsWebKit2.start): Deleted.
369 (TestLeaksFactory): Deleted.
370 (TestLeaksFactory.__init__): Deleted.
371 (TestWebKit2Factory): Deleted.
372 (TestWebKit2AndJSCFactory): Deleted.
373 (BuildAndPerfTestWebKit2Factory): Deleted.
374 (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
375 (DownloadAndPerfTestWebKit2Factory): Deleted.
376 (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
377 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
379 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
380 (PerfTestsRunner._parse_args):
381 * Scripts/webkitpy/port/port_testcase.py:
382 (PortTestCase.test_build_driver):
384 2015-03-05 Brent Fulgham <bfulgham@apple.com>
386 [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
387 https://bugs.webkit.org/show_bug.cgi?id=140845
389 Reviewed by David Kilzer.
391 Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
392 and generate suitable build commands to drive a full build from our
393 existing solution files.
395 * Scripts/webkitdirs.pm:
396 (msBuildInstallDir): Added.
397 (determineConfigurationForVisualStudio): Revise to use MSBuild command
398 line arguments to drive the build.
399 (setupCygwinEnv): Warn user if MSBuild cannot be located.
400 (buildVisualStudioProject): Revise to use MSBuild command line arguments
401 to specify build architecture.
402 * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
403 output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
404 bother looking for CoreUI or SafariTheme build logs.
406 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
408 [buildbot] mastercfg_unittest.py should be runnable easily
409 https://bugs.webkit.org/show_bug.cgi?id=142219
411 Reviewed by Chris Dumez.
413 Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
414 the last Twisted version works together with this buildbot version.
416 * Scripts/webkitpy/common/system/autoinstall.py:
417 (AutoInstaller): Added prepend_to_search_path argument to be able
418 to prefer autoinstalled package to system package.
419 (AutoInstaller.__init__):
420 (AutoInstaller._set_up_target_dir):
421 (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
422 (AutoInstaller._prepare_package):
423 (AutoInstaller._extract_targz): Renamed to _extract_tar.
424 * Scripts/webkitpy/thirdparty/__init__.py:
425 (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
427 2015-03-05 Lukasz Bialek <l.bialek@samsung.com>
429 [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
430 https://bugs.webkit.org/show_bug.cgi?id=131162
432 Reviewed by Gyuyoung Kim.
434 * MiniBrowser/efl/main.c:
435 (on_download_request):
436 (on_download_finished):
437 (on_download_failed):
439 Adapt download callbacks to new callback mechanism
441 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
443 Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
445 In r180927 we updated the libsoup version used by the jhbuild. In
446 this new version the sniffer uses image/x-icon instead of
447 image/vnd.microsoft.icon for blank.ico resource.
449 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
450 (testWebResourceMimeType):
452 2015-03-05 Carlos Garcia Campos <cgarcia@igalia.com>
454 [SOUP] Check TLS errors as soon as they are set in the SoupMessage
455 https://bugs.webkit.org/show_bug.cgi?id=142244
457 Reviewed by Sergio Villar Senin.
459 Check that the SSL server doesn't process any request in case of
460 TLS errors when the policy is set to FAIL.
462 * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
463 (testTLSErrorsPolicy):
464 (testTLSErrorsRedirect):
465 (testTLSErrorsHTTPAuth):
466 (testLoadFailedWithTLSErrors):
467 (testSubresourceLoadFailedWithTLSErrors):
468 (httpsServerCallback):
470 2015-03-05 Pawel Forysiuk <p.forysiuk@samsung.com>
472 [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
473 https://bugs.webkit.org/show_bug.cgi?id=141154
475 Reviewed by Jer Noble.
477 Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
479 For the sake of completeness WebKitTestRunner should specify temporary
480 folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
482 Default non legacy paths are set up in ProcessPoolConfiguration constructor.
483 They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
484 to get data storage paths. Only Mac port has an actual implementation of it.
485 However, WebKitTestRunner overrides them in favour of unique temporary dir
486 which is taken from libraryPathForTesting().
488 Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
489 is not implemented for EFL and GTK ports it returns an empty string.
490 All default data folders besides MediaKeys are overridden in TestRunner
491 code with unique temporary folders derived from DUMPRENDERTREE_TEMP
494 GTK port does not enable encrypted keys by default so
495 WebMediaKeyStorageManager::initialize() code path is never triggered.
497 * WebKitTestRunner/TestController.cpp:
498 (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
501 2015-03-05 Csaba Osztrogonác <ossy@webkit.org>
503 [buildbot] Add regression test to check which builder runs which tests
504 https://bugs.webkit.org/show_bug.cgi?id=142166
506 Reviewed by Alexey Proskuryakov.
508 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
509 (BuildStepsConstructorTest.createTest):
511 (BuildStepsTest.generateTests):
512 (BuildStepsTest.createTest):
513 (BuildStepsTest.createTest.doTest):
514 (BuildStepsTest.test_unnecessary_expected_results):
516 2015-03-04 Commit Queue <commit-queue@webkit.org>
518 Unreviewed, rolling out r181054.
519 https://bugs.webkit.org/show_bug.cgi?id=142320
521 Broke the api tests (Requested by sundiamonde on #webkit).
525 "Fix linker warnings in TestWebKitAPI."
526 https://bugs.webkit.org/show_bug.cgi?id=141912
527 http://trac.webkit.org/changeset/181054
529 2015-03-04 Alex Christensen <achristensen@webkit.org>
531 Fix linker warnings in TestWebKitAPI.
532 https://bugs.webkit.org/show_bug.cgi?id=141912
534 Reviewed by David Kilzer.
536 * TestWebKitAPI/Configurations/Base.xcconfig:
537 Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
539 2015-03-04 Alexey Proskuryakov <ap@apple.com>
541 [Mac] Set SystemUIFontSelect in DRT and WKTR
542 https://bugs.webkit.org/show_bug.cgi?id=142303
544 Reviewed by Myles C. Maxfield.
546 * DumpRenderTree/mac/DumpRenderTree.mm:
547 (setDefaultsToConsistentValuesForTesting):
548 * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
549 (WTR::InjectedBundle::platformInitialize):
551 2015-03-04 Chris Dumez <cdumez@apple.com>
553 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
554 https://bugs.webkit.org/show_bug.cgi?id=142314
555 <rdar://problem/20046835>
557 Reviewed by Ryosuke Niwa.
559 Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
560 to get WK2 code coverage.
562 * BuildSlaveSupport/build.webkit.org-config/config.json:
564 2015-03-04 Alex Christensen <achristensen@webkit.org>
566 Move content extensions test to properly named directory.
567 https://bugs.webkit.org/show_bug.cgi?id=142299
569 Reviewed by Tim Horton.
571 * WebKitTestRunner/mac/TestControllerMac.mm:
572 (WTR::TestController::platformConfigureViewForTest):
574 2015-03-04 Youenn Fablet <youenn.fablet@crf.canon.fr>
576 W3C test importer should use filesystem instead of os.walk
577 https://bugs.webkit.org/show_bug.cgi?id=142085
579 Reviewed by Bem Jones-Bey.
581 Added FileSystem.dirs_under to remove the use of os.walk in test importer.
582 Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
583 Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
585 Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
586 Added a unit test to check that test importer is now black-box testable using a Mock system.
588 * Scripts/webkitpy/common/system/filesystem.py:
589 (FileSystem.dirs_under): Returns a list of filtered sub-directories.
590 (FileSystem.dirs_under.filter_all):
591 * Scripts/webkitpy/common/system/filesystem_mock.py:
592 (MockFileSystem.dirs_under):
593 (MockFileSystem.dirs_under.filter_all):
594 (MockFileSystem.getsize):
595 * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
596 (MockFileSystemTest.test_dirs_under):
597 (MockFileSystemTest.test_dirs_under.filter_dir):
598 * Scripts/webkitpy/common/system/filesystem_unittest.py:
599 (RealFileSystemTest.test_sep):
600 (RealFileSystemTest):
601 (RealFileSystemTest.test_dirs_under):
602 (RealFileSystemTest.test_dirs_under.filter_this_dir):
603 * Scripts/webkitpy/w3c/test_importer.py:
604 (TestImporter.do_import):
605 (TestImporter.find_importable_tests.should_keep_subdir):
606 (TestImporter.find_importable_tests):
607 (TestImporter.should_keep_subdir): Deleted.
608 (TestImporter.should_skip_file): Deleted.
609 * Scripts/webkitpy/w3c/test_importer_unittest.py:
610 (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
612 2015-03-04 Timothy Horton <timothy_horton@apple.com>
614 [WebEditingTester] Add support for the find and replace bar
615 https://bugs.webkit.org/show_bug.cgi?id=142247
617 Reviewed by Enrica Casucci.
619 While it's not hooked up yet in WKWebView, adding support for the
620 find bar to WebEditingTester will help us implement that functionality.
622 * WebEditingTester/AppDelegate.h:
623 * WebEditingTester/AppDelegate.m:
624 (-[WebEditingAppDelegate performTextFinderAction:]):
625 * WebEditingTester/MainMenu.xib:
626 Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
628 * WebEditingTester/WK2WebDocumentController.m:
629 (-[WK2WebDocumentController awakeFromNib]):
630 (-[WK2WebDocumentController performTextFinderAction:]):
631 (-[WK2WebDocumentController findBarView]):
632 (-[WK2WebDocumentController setFindBarView:]):
633 (-[WK2WebDocumentController isFindBarVisible]):
634 (-[WK2WebDocumentController setFindBarVisible:]):
635 (-[WK2WebDocumentController findBarViewDidChangeHeight]):
636 (-[WK2WebDocumentController layout]):
637 Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
638 pointing at the WKWebView (currently nothing will work, but the bar will
639 show up). Install and uninstall the bar as needed.
641 * WebEditingTester/WebDocument.xib:
642 Don't use a full-size content view. There's no need, and it makes find
645 * WebEditingTester/WebDocumentController.h:
646 * WebEditingTester/WebDocumentController.m:
647 (-[WebDocumentController performTextFinderAction:]):
649 2015-03-03 Sam Weinig <sam@webkit.org>
651 [Content Extensions] Split parsing and compiling of content extensions into their own files
652 https://bugs.webkit.org/show_bug.cgi?id=142259
654 Reviewed by Anders Carlsson.
656 Add basic unit test for the content filter compiler.
658 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
659 * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
660 (WebCore::ContentExtensions::operator<<):
661 (TestWebKitAPI::ContentFilterTest::SetUp):
662 (TestWebKitAPI::TEST_F):
664 2015-03-04 Matthew Mirman <mmirman@apple.com>
666 Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
667 https://bugs.webkit.org/show_bug.cgi?id=142230
669 Reviewed by Csaba Osztrogonác.
671 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
673 (TestFactory.getProduct): Added
674 (TestFactory.__init__): moved downloader to getProduct
675 (BuildAndTestFactory):
676 (BuildAndTestFactory.getProduct): Added
677 (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
678 (BuildAndTestWebKit2Factory): Deleted. Wasn't used anywhere.
680 2015-03-04 Debarshi Ray <debarshir@gnome.org>
682 [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
683 https://bugs.webkit.org/show_bug.cgi?id=142225
685 Reviewed by Carlos Garcia Campos.
687 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
688 (testWebViewWebContextLifetime):
691 2015-03-03 David Kilzer <ddkilzer@apple.com>
693 [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
694 <http://webkit.org/b/142243>
696 Reviewed by Alexey Proskuryakov.
698 * WebKitTestRunner/TestController.cpp:
699 (WTR::TestController::webProcessName):
700 (WTR::TestController::networkProcessName):
701 - Return the same process name on iOS and Mac because they both
702 use the same process name for local engineering builds.
704 2015-03-03 David Kilzer <ddkilzer@apple.com>
706 check-webkit-style: Add exception for FrameworkSoftLink.h header order
707 <http://webkit.org/b/141872>
709 Reviewed by Alex Christensen.
711 * Scripts/webkitpy/style/checkers/cpp.py: Remove unneeded
712 semi-colons in various places and fix whitespace.
713 (_IncludeState): Add _SOFT_LINK_HEADER and _SOFT_LINK_SECTION
715 (_IncludeState.__init__): Add self._visited_soft_link_section
716 boolean state variable.
717 (_IncludeState.visited_soft_link_section): Getter for
718 self._visited_soft_link_section.
719 (_IncludeState.check_next_include_order): Update state machine
720 for soft-link headers. Add check that soft-link headers always
722 (_classify_include): Add check for soft-link header type.
723 (check_include_line): Return early if there is a soft-link
726 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
727 (OrderOfIncludesTest.test_public_primary_header): Add tests for
728 including soft-link headers.
729 (OrderOfIncludesTest.test_classify_include): Add test for
730 _SOFT_LINK_HEADER type.
732 2015-03-03 Alexey Proskuryakov <ap@apple.com>
734 build.webkit.org/dashboard: Don't repeatedly handle each test type
735 https://bugs.webkit.org/show_bug.cgi?id=142211
737 Reviewed by Tim Horton and Matt Hanson.
739 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
740 (Buildbot.prototype.javascriptTestResultsURLForIteration): Deleted.
741 (Buildbot.prototype.apiTestResultsURLForIteration): Deleted.
742 (Buildbot.prototype.platformAPITestResultsURLForIteration): Deleted.
743 (Buildbot.prototype.webkitpyTestResultsURLForIteration): Deleted.
744 (Buildbot.prototype.webkitperlTestResultsURLForIteration): Deleted.
745 (Buildbot.prototype.bindingsTestResultsURLForIteration): Deleted.
746 Removed functions that build a link to test step results. The buildbot provides
749 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
750 (BuildbotIteration): Put failing tests into an array, instead of named variables.
751 (BuildbotIteration.ProductiveSteps): Removed step names that are not used on build.webkit.org.
752 We can easily add them to the map as needed.
753 (BuildbotIteration.TestSteps): Added a list of test steps to be displayed by test queues.
754 (BuildbotIteration.prototype._parseData): Moved code for parsing step results away
755 to BuildbotTestResults class. We used to parse here, build an intermediate data structure,
756 and then build a BuildbotTestResults object, which was strange.
757 (BuildbotIteration.prototype.loadLayoutTestResults): Ditto.
759 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
760 Corrected an unrelated assertion that was buggy, and kept firing.
762 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
763 (BuildbotTestResults):
764 (BuildbotTestResults.prototype._parseResults.resultSummarizer):
765 (BuildbotTestResults.prototype._parseResults):
766 (BuildbotTestResults.prototype.addFullLayoutTestResults):
767 Moved the code for parsing JSON results for a single step here.
769 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
770 (BuildbotTesterQueueView.prototype._testStepFailureDescription):
771 (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount):
772 (BuildbotTesterQueueView.prototype._presentPopoverForGenericTestFailures):
773 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Deleted.
774 (BuildbotTesterQueueView.prototype.update): Deleted.
775 (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Deleted.
776 Updated for the new data structures. One behavior change is that we now display individual
777 counts when multiple test kinds fail, e.g. "1 javascript test failure, 83+ layout
778 test failures, 3 platform api test failures".
780 2015-03-03 Matthew Mirman <mmirman@apple.com>
782 JSC tests should not be repeated twice for each branch builder, and should if possible have their own queue.
783 https://bugs.webkit.org/show_bug.cgi?id=142094
785 Reviewed by Csaba Osztrogonác.
787 * BuildSlaveSupport/build.webkit.org-config/config.json: Added bots 155 and 157
788 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
790 (TestFactory.__init__): Made running of JSC tests conditional.
791 (TestAllButJSCFactory):
792 (TestJSCFactory): Added.
793 (TestJSCFactory.__init__):
794 (TestWebKit2AndJSCFactory): Added factory to not run JSC tests on WebKit2.
796 2015-03-03 David Kilzer <ddkilzer@apple.com>
798 `build-webkit --help` is wrong about how to build for the iOS simulator
799 <http://webkit.org/b/142223>
801 Reviewed by Csaba Osztrogonác.
803 * Scripts/build-webkit: Fix help.
805 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
807 Unreviewed. Bump libsoup version to 2.49.91.1 to fix 32 bit build.
809 * gtk/jhbuild.modules:
811 2015-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
813 [SOUP] Synchronous XMLHttpRequests can time out when we reach the max connections limit
814 https://bugs.webkit.org/show_bug.cgi?id=141508
816 Reviewed by Sergio Villar Senin.
818 Add a unit test to check that synchronous XHRs load even if the
819 maximum connection limits are reached.
821 * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
822 (testWebViewSyncRequestOnMaxConns):
825 * gtk/jhbuild.modules: Bump libsoup version to 2.49.91.
827 2015-03-02 Alexey Proskuryakov <ap@apple.com>
829 Update the name of ASan build step.
831 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
833 2015-03-02 Jer Noble <jer.noble@apple.com>
835 [WK1][WK2][Mac] Fullscreen animation is incorrect when page is scaled.
836 https://bugs.webkit.org/show_bug.cgi?id=142121
838 Reviewed by Simon Fraser.
840 Add a test which changes the WebView's page scale, then enters fullscreen mode, and verifies
841 that the initial and final screen rects for the web content are as expected.
843 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
844 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.html: Added.
845 * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm: Added.
846 (-[FullscreenStateDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:]):
847 (runJavaScriptAlert):
848 (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
849 (TestWebKitAPI::FullscreenZoomInitialFrame::teardownView):
850 (TestWebKitAPI::FullscreenZoomInitialFrame::setPageScale):
851 (TestWebKitAPI::FullscreenZoomInitialFrame::sendMouseDownEvent):
852 (TestWebKitAPI::FullscreenZoomInitialFrame::runTest):
853 (TestWebKitAPI::TEST_F):
855 2015-03-01 David Kilzer <ddkilzer@apple.com>
857 LayoutTestRealy: Prepend __XPC_ to the key, not the value!
861 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
862 <http://webkit.org/b/142145>
864 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
865 (-[LTRelayController _environmentVariables]): Fix think-o.
867 2015-03-01 David Kilzer <ddkilzer@apple.com>
869 LayoutTestRelay: App environment variables not set for --guard-malloc or --leaks
870 <http://webkit.org/b/142145>
872 Reviewed by Simon Fraser.
874 * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
875 (-[LTRelayController _environmentVariables]): Add.
876 (-[LTRelayController launchApp]): Use -_environmentVariables.
878 2015-02-28 David Kilzer <ddkilzer@apple.com>
880 [iOS] Stop running webkit-build-directory on every layout test
882 This was originally fixed by David Farler for Bug 135409 in
885 * Scripts/webkitpy/port/ios.py:
886 (IOSSimulatorPort.relay_path): Mark as @memoized so it doesn't
887 run webkit-build-directory every time it's called.
889 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr>
891 W3C importer should use filesystem instead of shutil/host
892 https://bugs.webkit.org/show_bug.cgi?id=142012
894 Reviewed by Bem Jones-Bey.
896 Removed direct use of python shutil and os, except for os.walk which will require its own fix.
898 * Scripts/webkitpy/w3c/test_importer.py:
900 (TestImporter.do_import):
901 (TestImporter.find_importable_tests):
902 (TestImporter.import_tests):
903 (TestImporter.remove_deleted_files):
904 (TestImporter.write_import_log):
906 2015-02-28 Youenn Fablet <youenn.fablet@crf.canon.fr>
908 W3C test importer should use filesystem to read and write files
909 https://bugs.webkit.org/show_bug.cgi?id=142084
911 Reviewed by Bem Jones-Bey.
913 Use of FileSystem.write_binary_file, read_text_file and write_text_file in lieu of open().
915 * Scripts/webkitpy/w3c/test_importer.py:
916 (TestImporter.import_tests):
917 (TestImporter.remove_deleted_files):
918 (TestImporter.write_import_log):
920 2015-02-27 Sam Weinig <sam@webkit.org>
922 Add WebKit2 SPI to create a DOM File object
923 https://bugs.webkit.org/show_bug.cgi?id=142109
925 Reviewed by Tim Horton.
927 Add a test for WKBundleFileHandleRef.
929 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
930 * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle.cpp: Added.
931 (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
932 (TestWebKitAPI::didFinishLoadForFrame):
933 (TestWebKitAPI::TEST):
934 * TestWebKitAPI/Tests/WebKit2/WKBundleFileHandle_Bundle.cpp: Added.
935 (TestWebKitAPI::WKBundleFileHandleTest::WKBundleFileHandleTest):
936 * TestWebKitAPI/Tests/WebKit2/bundle-file.html: Added.
938 2015-02-27 Michael Saboff <msaboff@apple.com>
940 Add ability for run-jsc-benchmarks to set library path from test binary when run on a build bot
941 https://bugs.webkit.org/show_bug.cgi?id=142112
943 Reviewed by Filip Pizlo.
945 Added check for VMs in the form of <someDir>/{DumpRenderTree,webkitTestRunner,jsc} and use
946 <someDir> as the library path.
948 * Scripts/run-jsc-benchmarks:
950 2015-02-27 Alex Christensen <achristensen@webkit.org>
952 [WinCairo] Unreviewed build fix.
954 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props:
955 Use TestWebKitAPIPrefix.h like in TestWebKitAPICommon.props.
957 2015-02-27 Anders Carlsson <andersca@apple.com>
959 Add infrastructure for handling website data in the network process
960 https://bugs.webkit.org/show_bug.cgi?id=142092
962 Reviewed by Andreas Kling.
964 Add a menu item that will fetch all website data, delete the returned data records, and
965 fetch all website data again so we can confirm that it's all empty.
967 * MiniBrowser/mac/WK2BrowserWindowController.m:
968 (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
970 2015-02-26 Brent Fulgham <bfulgham@apple.com>
972 [Win] Remove remaining SafariTheme cruft
973 https://bugs.webkit.org/show_bug.cgi?id=142075
975 Reviewed by Anders Carlsson.
977 Remove reference to SafariTheme-switching preference.
979 * DumpRenderTree/win/DumpRenderTree.cpp:
980 (resetWebPreferencesToConsistentValues):
981 (prepareConsistentTestingEnvironment):
983 2015-02-26 Doug Russell <d_russell@apple.com>
985 AX: Expose caret browsing preference to accessibility API
986 https://bugs.webkit.org/show_bug.cgi?id=141862
988 Reviewed by Chris Fleizach.
990 Exposing the caret browsing setting on WebCore::Frame via the accessibility API would allow assistive tech apps to enable it contextually (for example, when the assistive tech app is running).
991 Enabling caret browsing when assistive tech apps are running greatly improves the reliability of keyboard navigation on the web. Most especially in cases where selection would be disrupted by focus events.
993 * DumpRenderTree/AccessibilityUIElement.cpp:
994 (setBoolAttributeValueCallback):
995 (selectedTextMarkerRangeCallback):
996 (resetSelectedTextMarkerRangeCallback):
997 (AccessibilityUIElement::setBoolAttributeValue):
998 (AccessibilityUIElement::selectedTextMarkerRange):
999 (AccessibilityUIElement::resetSelectedTextMarkerRange):
1000 (AccessibilityUIElement::getJSClass):
1001 * DumpRenderTree/AccessibilityUIElement.h:
1002 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1003 (AccessibilityUIElement::setBoolAttributeValue):
1004 (AccessibilityUIElement::selectedTextMarkerRange):
1005 (AccessibilityUIElement::resetSelectedTextMarkerRange):
1006 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1007 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1008 (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1009 (WTR::AccessibilityUIElement::setBoolAttributeValue):
1010 * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1011 * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1012 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1013 (WTR::AccessibilityUIElement::setBoolAttributeValue):
1014 (WTR::AccessibilityUIElement::selectedTextMarkerRange):
1015 (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
1017 2015-02-26 Brent Fulgham <bfulgham@apple.com>
1019 [Win] Remove WebKitExportGenerator project (and related)
1020 https://bugs.webkit.org/show_bug.cgi?id=142035
1022 Reviewed by Dean Jackson.
1024 * win/AssembleBuildLogs/AssembleLogs.cmd: Don't look for a
1025 build log from WebKitExportGenerator.
1027 2015-02-26 Csaba Osztrogonác <ossy@webkit.org>
1029 [EFL] Bump EFL version to 1.13.0
1030 https://bugs.webkit.org/show_bug.cgi?id=141708
1032 Reviewed by Gyuyoung Kim.
1034 * efl/jhbuild.modules:
1036 2015-02-26 Sam Weinig <sam@webkit.org>
1038 Check in missing WebEditingTester.xcconfig file.
1040 * WebEditingTester/Configurations/WebEditingTester.xcconfig: Added.
1042 2015-02-26 Csaba Osztrogonác <ossy@webkit.org>
1044 [webkitpy] Remove skipped file related crufts
1045 https://bugs.webkit.org/show_bug.cgi?id=142046
1047 Reviewed by Ryosuke Niwa.
1049 * Scripts/webkitpy/port/base.py:
1050 (Port.skipped_layout_tests):
1051 (Port._tests_from_skipped_file_contents): Deleted.
1053 (Port._expectations_from_skipped_files): Deleted.
1054 * Scripts/webkitpy/port/mac_unittest.py:
1055 (MacTest.test_default_timeout_ms):
1057 (test_tests_from_skipped_file_contents): Deleted.
1059 2015-02-26 Brent Fulgham <bfulgham@apple.com>
1061 [Win] Unreviewed WinCairo build fix after r180653.
1063 TestWebKitAPI should know about proper WEBCORE_EXPORT definitions.
1065 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1066 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1067 * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
1068 * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Added.
1069 * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Added.
1071 2015-02-25 Brent Fulgham <bfulgham@apple.com>
1073 [Win] Use WEBCORE_EXPORT instead of Definition file
1074 https://bugs.webkit.org/show_bug.cgi?id=141734
1076 Reviewed by Alex Christensen.
1078 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
1079 Use a precompiled header so we can define our export macros properly.
1080 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters:
1081 Visual studio automatic update stuff.
1082 * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
1083 Set up Precompiled Header use for project..
1084 * DumpRenderTree/win/DumpRenderTreePrefix.cpp: Added.
1085 * DumpRenderTree/DumpRenderTreePrefix.h: Update with proper export
1086 declarations for building DumpRenderTree as a client of
1089 2015-02-25 Mark Lam <mark.lam@apple.com>
1091 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack.
1092 <https://webkit.org/b/141672>
1094 Reviewed by Alexey Proskuryakov.
1096 ASan does not like the fact that we memcpy the stack for GC scans. So,
1097 we're working around this by using our own memcpy (asanUnsafeMemcpy)
1098 implementation that we can tell ASan to ignore.
1100 Also removed the previous added directive to ignore *tryCopyOtherThreadStack*
1101 which isn't effective for working around this issue.
1103 * asan/webkit-asan-ignore.txt:
1105 2015-02-25 Benjamin Poulain <bpoulain@apple.com>
1107 CodeBlock crashes when dumping op_push_name_scope
1108 https://bugs.webkit.org/show_bug.cgi?id=141953
1110 Reviewed by Filip Pizlo.
1112 * Scripts/run-jsc-stress-tests:
1114 2015-02-25 Youenn Fablet <youenn.fablet@crf.canon.fr>
1116 W3C test importer should use argparse instead of optparse
1117 https://bugs.webkit.org/show_bug.cgi?id=142013
1119 Reviewed by Bem Jones-Bey.
1121 * Scripts/webkitpy/w3c/test_importer.py:
1122 (main): Updating according argparse.
1123 (parse_args): Moving from optparse to argparse.
1125 2015-02-25 Brady Eidson <beidson@apple.com>
1127 Get rid of TestInvocation::pathOrURL
1128 https://bugs.webkit.org/show_bug.cgi?id=142021
1130 Reviewed by Tim Horton.
1132 The pathOrURL string is a relative path used as an argument to WebKitTestRunner,
1133 but most code that uses it expected an absolute path.
1135 This gets rid of the member and replaces all uses with a more descriptive "urlContains" method.
1137 * WebKitTestRunner/TestController.cpp:
1138 (WTR::TestController::updateWebViewSizeForTest):
1139 (WTR::TestController::updateWindowScaleForTest):
1140 (WTR::shouldUseFixedLayout):
1141 (WTR::TestController::updateLayoutTypeForTest):
1143 * WebKitTestRunner/TestInvocation.cpp:
1144 (WTR::TestInvocation::TestInvocation):
1145 (WTR::TestInvocation::urlContains):
1146 (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1147 (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1148 (WTR::TestInvocation::invoke):
1149 (WTR::shouldLogFrameLoadDelegates): Deleted.
1150 (WTR::shouldLogHistoryClientCallbacks): Deleted.
1151 * WebKitTestRunner/TestInvocation.h:
1152 (WTR::TestInvocation::pathOrURL): Deleted.
1154 * WebKitTestRunner/ios/TestControllerIOS.mm:
1155 (WTR::shouldMakeViewportFlexible):
1156 (WTR::TestController::platformConfigureViewForTest):
1158 * WebKitTestRunner/mac/TestControllerMac.mm:
1159 (WTR::shouldUseThreadedScrolling):
1160 (WTR::TestController::platformConfigureViewForTest):
1162 2015-02-25 Brady Eidson <beidson@apple.com>
1164 Layout test support for user content filters
1165 https://bugs.webkit.org/show_bug.cgi?id=142018
1167 Reviewed by Tim Horton.
1169 * WebKitTestRunner/TestController.cpp:
1170 (WTR::TestController::resetStateToConsistentValues): Clear all user content filters between tests.
1172 * WebKitTestRunner/mac/TestControllerMac.mm:
1173 (WTR::TestController::platformConfigureViewForTest): For all tests with usercontentfilter/ in their path try to load a matching .json
1174 file before loading the test itself.
1176 2015-02-24 Sam Weinig <sam@webkit.org>
1178 Convert WebEditingTester to use xcconfig files
1179 https://bugs.webkit.org/show_bug.cgi?id=141879
1181 Reviewed by Darin Adler.
1183 Add xcconfig files to WebEditingTester based on the ones used by MiniBrowser.
1185 * WebEditingTester/Configurations: Added.
1186 * WebEditingTester/Configurations/Base.xcconfig: Added.
1187 * WebEditingTester/Configurations/DebugRelease.xcconfig: Added.
1188 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1190 2015-02-24 Andy Estes <aestes@apple.com>
1192 Teach MiniBrowser how to disable per-window web processes
1193 https://bugs.webkit.org/show_bug.cgi?id=141988
1195 Reviewed by Darin Adler.
1197 * MiniBrowser/mac/AppDelegate.m:
1198 (defaultConfiguration): Created a _WKProcessPoolConfiguration with maximumProcessCount == 1 if per-window web processes are disabled.
1199 * MiniBrowser/mac/SettingsController.h:
1200 * MiniBrowser/mac/SettingsController.m:
1201 (-[SettingsController _populateMenu]): Added a new Settings menu item.
1202 (-[SettingsController validateMenuItem:]): Validated the new Settings menu item.
1203 (-[SettingsController togglePerWindowWebProcessesDisabled:]): Displayed an alert informing the user that MiniBrowser must be restarted for the setting to take effect.
1204 (-[SettingsController perWindowWebProcessesDisabled]): Returned the value from user defaults.
1206 2015-02-24 Alexey Proskuryakov <ap@apple.com>
1208 Bot watcher's dashboard sometimes hits an assertion: data.num_missing === this.layoutTestResults.testsWithMissingResults.length
1209 https://bugs.webkit.org/show_bug.cgi?id=141889
1211 Reviewed by Darin Adler.
1213 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1215 2015-02-24 Yusuke Suzuki <utatane.tea@gmail.com>
1217 REGRESSION(r179429): Can't type comments in Facebook
1218 https://bugs.webkit.org/show_bug.cgi?id=141859
1220 Reviewed by Brent Fulgham.
1222 Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1224 * DumpRenderTree/mac/DumpRenderTree.mm:
1225 (resetWebPreferencesToConsistentValues):
1226 * DumpRenderTree/win/DumpRenderTree.cpp:
1227 (resetWebPreferencesToConsistentValues):
1228 * WebKitTestRunner/TestController.cpp:
1229 (WTR::TestController::resetPreferencesToConsistentValues):
1231 2015-02-24 Michael Catanzaro <mcatanzaro@igalia.com>
1233 Crash loading local file with WebPageProxy::loadAlternateHTMLString
1234 https://bugs.webkit.org/show_bug.cgi?id=141867
1236 Reviewed by Anders Carlsson.
1238 * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1239 (TestWebKitAPI::loadAlternateHTMLString): Split most of this test into a function so it can
1240 be shared with the new test.
1241 (TestWebKitAPI::TEST): Add a cross-platform test for this crash.
1242 * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Add a GTK+ test for this crash.
1243 (testLoadAlternateHTMLForLocalPage):
1246 2015-02-24 David Kilzer <ddkilzer@apple.com>
1248 [iOS] Implement WTR::activateFonts() to fix missing fonts in WebKit2 test runs
1249 <http://webkit.org/b/141900>
1251 Reviewed by Myles C. Maxfield.
1253 * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
1254 (OTHER_LDFLAGS_BASE): Link to CoreText.framework.
1255 * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm: Rename from Tools/WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm.
1256 - Rename to share code with iOS.
1257 - Add USE(APPKIT) around AppKit-specific headers and code.
1258 - Fix a check-webkit-style warning.
1259 * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Remove.
1260 * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1261 - Rename mac/ActivateFonts.mm to cocoa/ActivateFontsCocoa.mm.
1262 - Remove ios/ActivateFontsIOS.mm.
1263 - Fix InjectedBundle/cocoa group to represent the directory on
1264 disk. Includes a change to InjectedBundlePageCocoa.mm.
1266 2015-02-23 Commit Queue <commit-queue@webkit.org>
1268 Unreviewed, rolling out r180547 and r180550.
1269 https://bugs.webkit.org/show_bug.cgi?id=141957
1271 Broke 10 Windows tests. (Requested by bfulgham_ on #webkit).
1273 Reverted changesets:
1275 "REGRESSION(r179429): Can't type comments in Facebook"
1276 https://bugs.webkit.org/show_bug.cgi?id=141859
1277 http://trac.webkit.org/changeset/180547
1279 "Constructor returning null should construct an object instead
1281 https://bugs.webkit.org/show_bug.cgi?id=141640
1282 http://trac.webkit.org/changeset/180550
1284 2015-02-23 Yusuke Suzuki <utatane.tea@gmail.com>
1286 REGRESSION(r179429): Can't type comments in Facebook
1287 https://bugs.webkit.org/show_bug.cgi?id=141859
1289 Reviewed by Geoffrey Garen.
1291 Drop javaScriptExperimentsEnabled and specify JavaScriptRuntimeFlagsAllEnabled as KJavaScriptRuntimeFlags.
1293 * DumpRenderTree/mac/DumpRenderTree.mm:
1294 (resetWebPreferencesToConsistentValues):
1295 * WebKitTestRunner/TestController.cpp:
1296 (WTR::TestController::resetPreferencesToConsistentValues):
1298 2015-02-23 KwangHyuk Kim <hyuki.kim@samsung.com>
1301 https://bugs.webkit.org/show_bug.cgi?id=141909
1303 Reviewed by Gyuyoung Kim.
1305 Fix eo errors that occur whenever minibrowser is launched.
1306 - elm_obj_entry_text_style_user_push can only be applied for elm_entry
1307 - elm_obj_win_resize_object_add's first parameter should be elm_win
1309 * MiniBrowser/efl/main.c:
1312 2015-02-23 Ryosuke Niwa <rniwa@webkit.org>
1314 Unreviewed build fix after r180535. Removed the test case that wasn't compiling.
1316 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1317 (TestWebKitAPI::TEST):
1319 2015-02-23 Brent Fulgham <bfulgham@apple.com>
1321 WTF::WeakPtr should rename 'forgot' to 'clear' and support nullptr assignment
1322 https://bugs.webkit.org/show_bug.cgi?id=141935
1324 Reviewed by Myles C. Maxfield.
1326 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1327 (TestWebKitAPI::TEST): Updated for 'clear' method rename, and added a few
1328 tests for assigning from nullptr.
1330 2015-02-23 Brent Fulgham <bfulgham@apple.com>
1332 WTF::WeakPtr should have a 'forget' method.
1333 https://bugs.webkit.org/show_bug.cgi?id=141923
1335 Reviewed by Myles C. Maxfield.
1337 * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1338 (TestWebKitAPI::TEST): Added 'Forget' tests case.
1340 2015-02-23 Alexey Proskuryakov <ap@apple.com>
1342 build.webkit.org/dashboard CrashOnly queues should not show two green bubbles
1343 https://bugs.webkit.org/show_bug.cgi?id=141920
1345 Reviewed by Tim Horton.
1347 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1348 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1349 Do the same thing as we do for regular green bubbles.
1351 2015-02-23 Alexey Proskuryakov <ap@apple.com>
1353 Bot watcher's dashboard doesn't show a popover for commit history when all commits were to another branch
1354 https://bugs.webkit.org/show_bug.cgi?id=141925
1356 Reviewed by Tim Horton.
1358 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1359 (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1361 2015-02-23 Anders Carlsson <andersca@apple.com>
1363 Add API for fetching website data records to _WKWebsiteDataStore
1364 https://bugs.webkit.org/show_bug.cgi?id=141926
1366 Reviewed by Beth Dakin.
1368 * MiniBrowser/mac/MainMenu.xib:
1369 * MiniBrowser/mac/WK2BrowserWindowController.m:
1370 (-[WK2BrowserWindowController fetchWebsiteData:]):
1371 Add menu item to fetch and dump website data.
1373 2015-02-23 David Kilzer <ddkilzer@apple.com>
1375 [iOS] run-webkit-tests --leaks is broken because IOSSimulatorPort has no is_snowleopard attribute
1376 <http://webkit.org/b/141884>
1378 Reviewed by Alexey Proskuryakov.
1380 * Scripts/webkitpy/port/leakdetector.py:
1381 (LeakDetector._callstacks_to_exclude_from_leaks): Remove
1382 snowleopard, lion and older leaks. Add known leak for
1383 mavericks, but check Port.operating_system before calling
1385 * Scripts/webkitpy/port/mac.py:
1386 (MacPort.is_snowleopard): Delete.
1387 (MacPort.is_lion): Delete.
1388 (MacPort.is_mavericks): Add.
1390 2015-02-23 Alexey Proskuryakov <ap@apple.com>
1392 build.webkit.org/dashboard should filter out commits to other branches
1393 https://bugs.webkit.org/show_bug.cgi?id=140362
1395 Reviewed by Tim Horton.
1397 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1399 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1400 (BuildbotQueueView.prototype._presentPopoverForPendingCommits):
1401 (BuildbotQueueView.prototype._presentPopoverForRevisionRange):
1402 (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration):
1403 (BuildbotQueueView.prototype.revisionContentForIteration):
1404 (BuildbotQueueView.prototype._appendPendingRevisionCount): Deleted.
1405 (BuildbotQueueView.prototype._popoverLinesForCommitRange): Deleted.
1406 (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Deleted.
1407 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
1408 (Trac.prototype.get oldestRecordedRevisionNumber):
1409 (Trac.prototype.commitsOnBranch):
1410 (Trac.prototype._xmlTimelineURL):
1411 (Trac.prototype._convertCommitInfoElementToObject):
1412 (Trac.prototype._update):
1413 (Trac.prototype.startPeriodicUpdates):
1414 (Trac.prototype.loadMoreHistoricalData):
1415 (Trac.prototype.update): Deleted.
1417 2015-02-21 Youenn Fablet <youenn.fablet@crf.canon.fr>
1419 Tests don't work on some bots: Failed to stop wptwk
1420 https://bugs.webkit.org/show_bug.cgi?id=141235
1422 Reviewed by Ryosuke Niwa.
1424 Logging of server subprocesses in launcher script.
1425 Killing of server subprocesses when stopping/before starting.
1426 Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore.
1428 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
1429 (main): Removed empty __init.py__ file creation as importer now ensures these files cannot be empty anymore. Added logging in a file of server subprocesses to clean them in case of abnormal shutdown.
1430 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1431 (WebPlatformTestServer.__init__):
1432 (WebPlatformTestServer._stop_running_subservers): Kill server subprocesses based on file created by wpt launcher.
1433 (WebPlatformTestServer):
1434 (WebPlatformTestServer.stop): Overriden to ensure killing subprocesses in case of orphaned process.
1435 (WebPlatformTestServer._stop_running_server): Killing of wpt launcher process after regular shutdown.
1436 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
1437 (TestWebPlatformTestServer.test_server_closes_previously_spawned_instance): Reworked the test to call start/stop with an existing pid file.
1438 (TestWebPlatformTestServer.test_import_web_platform_test_modules): No change.
1439 (TestWebPlatformTestServer):
1440 (TestWebPlatformTestServer.test_corrupted_subserver_files): Checked that server subprocess cleaning does not throw in case of bad server pid file.
1442 2015-02-20 Timothy Horton <timothy_horton@apple.com>
1444 [WebEditingTester] Allow dropping HTML files on the app
1445 https://bugs.webkit.org/show_bug.cgi?id=141834
1447 Reviewed by Simon Fraser.
1449 * WebEditingTester/AppDelegate.m:
1450 (-[WebEditingAppDelegate openDocument:]):
1451 (-[WebEditingAppDelegate application:openFile:]):
1452 Implement application:openFile:, factoring file loading code out of openDocument.
1454 * WebEditingTester/Info.plist:
1455 Register as an editor for HTML files.
1457 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1458 Enrica is not an organization.
1460 2015-02-20 Timothy Horton <timothy_horton@apple.com>
1462 [WebEditingTester] Expand "WK" to "WebKit" in a few places
1463 https://bugs.webkit.org/show_bug.cgi?id=141833
1465 Reviewed by Anders Carlsson.
1467 * WebEditingTester/AppDelegate.h:
1468 * WebEditingTester/AppDelegate.m:
1469 (-[WebEditingAppDelegate newEditor:]):
1470 (-[WebEditingAppDelegate toggleUseWebKit2ByDefault:]):
1471 (-[WebEditingAppDelegate validateMenuItem:]):
1472 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
1473 (-[WebEditingAppDelegate applicationDidFinishLaunching:]): Deleted.
1474 (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
1475 (-[WebEditingAppDelegate showOperations:]): Deleted.
1476 * WebEditingTester/MainMenu.xib:
1477 The WK abbreviation is unnaturally grating in menu items for some reason.
1479 2015-02-20 Timothy Horton <timothy_horton@apple.com>
1481 [WebEditingTester] Add a custom protocol for loading canned content
1482 https://bugs.webkit.org/show_bug.cgi?id=141830
1484 Reviewed by Enrica Casucci.
1486 Add a canned:// protocol handler, which can be used to emulate behaviors
1487 in WebKit client apps (like Mail) that use custom protocol handlers,
1488 which can have important effects on editing (mostly, the URLs are only
1489 valid inside of the client application, but not when copied/dragged out).
1491 For now, we only support two canned files:
1493 canned://dice is a PNG of dice (stolen from LayoutTests/)
1494 canned://text is the string "canned text" served as text/html
1496 In the future we could support things like very large (generated) files,
1497 progressive loading, etc. to further simulate conditions in other apps.
1499 * WebEditingTester/AppDelegate.m:
1500 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1501 Register the protocol with CFNetwork, and the scheme with WebKit2.
1503 * WebEditingTester/Canned Content/dice.png: Added.
1504 * WebEditingTester/CannedContent.h: Added.
1505 * WebEditingTester/CannedContent.m: Added.
1506 (-[CannedContent initWithRequest:cachedResponse:client:]):
1507 (+[CannedContent canonicalRequestForRequest:]):
1508 (+[CannedContent canInitWithRequest:]):
1509 We only want to handle canned:// URLs.
1511 (-[CannedContent startLoading]):
1512 For now, immediately load the two files we know about.
1513 Otherwise, immediately fail the load.
1515 (-[CannedContent stopLoading]):
1516 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1518 2015-02-20 Timothy Horton <timothy_horton@apple.com>
1520 [WebEditingTester] Implement an open panel
1521 https://bugs.webkit.org/show_bug.cgi?id=141829
1523 Reviewed by Simon Fraser.
1525 * WebEditingTester/AppDelegate.m:
1526 (-[WebEditingAppDelegate _useWebKit1ForOpeningDocument:]):
1527 (-[WebEditingAppDelegate _useWebKit2ForOpeningDocument:]):
1528 (-[WebEditingAppDelegate openDocument:]):
1529 Add an open panel (with radio buttons to pick which WebKit to open with).
1530 Loads the file as an HTML string.
1532 2015-02-20 Simon Fraser <simon.fraser@apple.com>
1534 [WebEditingTester] @properties, dot syntax, and remember the window position
1535 https://bugs.webkit.org/show_bug.cgi?id=141843
1537 Reviewed by Tim Horton.
1539 Modernize a bit with more dot syntax, use @property for the web views,
1540 and give the main window an Autosave name so it remembers the widow position.
1542 * WebEditingTester/WK1WebDocumentController.m:
1543 (-[WK1WebDocumentController awakeFromNib]):
1544 (-[WK1WebDocumentController loadHTMLString:]):
1545 * WebEditingTester/WK2WebDocumentController.m:
1546 (-[WK2WebDocumentController awakeFromNib]):
1547 * WebEditingTester/WebDocument.xib:
1549 2015-02-20 Timothy Horton <timothy_horton@apple.com>
1551 [WebEditingTester] Hook up key equivalents for new window action
1552 https://bugs.webkit.org/show_bug.cgi?id=141828
1554 Reviewed by Enrica Casucci.
1556 * WebEditingTester/AppDelegate.h:
1557 * WebEditingTester/AppDelegate.m:
1558 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1559 (-[WebEditingAppDelegate newEditor:]):
1560 (-[WebEditingAppDelegate _defaultWebDocumentControllerClass]):
1561 (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
1562 (-[WebEditingAppDelegate _updateNewWindowKeyEquivalents]):
1563 (defaultConfiguration): Deleted.
1564 (-[WebEditingAppDelegate applicationWillTerminate:]): Deleted.
1565 Move WKWebViewConfiguration setup into WK2WebDocumentController.
1566 Remove unused application termination code.
1567 Update new-window menu item key equivalents when launching and when
1568 changing the use-WebKit2-by-default setting.
1569 Make WebDocumentController subclasses all initialized the same way,
1570 and use that to factor out alloc/init.
1571 Rename loadContent to loadHTMLString for future use.
1573 * WebEditingTester/MainMenu.xib:
1574 Add default key equivalents.
1575 Cmd-N will always make the default kind of window (controlled by the pref).
1576 Cmd-Opt-N will always make the other kind.
1577 The menu items are configured as alternates so they only show up if you
1578 press alt (just like in MiniBrowser).
1580 * WebEditingTester/WK1WebDocumentController.m:
1581 (-[WK1WebDocumentController loadHTMLString:]):
1582 (-[WK1WebDocumentController loadContent]): Deleted.
1583 * WebEditingTester/WK2WebDocumentController.h:
1584 * WebEditingTester/WK2WebDocumentController.m:
1585 (defaultConfiguration):
1586 (-[WK2WebDocumentController awakeFromNib]):
1587 (-[WK2WebDocumentController loadHTMLString:]):
1588 (-[WK2WebDocumentController initWithConfiguration:]): Deleted.
1589 (-[WK2WebDocumentController dealloc]): Deleted.
1590 * WebEditingTester/WebDocumentController.h:
1591 * WebEditingTester/WebDocumentController.m:
1592 (-[WebDocumentController init]):
1593 (-[WebDocumentController initWithWindow:]):
1594 (+[WebDocumentController defaultEditingSource]):
1595 (-[WebDocumentController loadHTMLString:]):
1596 (-[WebDocumentController windowDidLoad]): Deleted.
1597 (-[WebDocumentController defaultEditingSource]): Deleted.
1598 (-[WebDocumentController applicationTerminating]): Deleted.
1599 (-[WebDocumentController loadContent]): Deleted.
1601 2015-02-20 Timothy Horton <timothy_horton@apple.com>
1603 [WebEditingTester] ARC-ify WebEditingTester
1604 https://bugs.webkit.org/show_bug.cgi?id=141827
1606 Reviewed by Sam Weinig.
1608 * WebEditingTester/AppDelegate.m:
1609 (-[WebEditingAppDelegate showOperations:]):
1610 * WebEditingTester/EditingOperations.m:
1611 (editingOperations):
1612 * WebEditingTester/WK1WebDocumentController.m:
1613 (-[WK1WebDocumentController dealloc]): Deleted.
1614 * WebEditingTester/WK2WebDocumentController.m:
1615 (-[WK2WebDocumentController dealloc]): Deleted.
1616 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1617 Turn on ARC and remove a few retain/release/autorelease calls.
1618 We don't need to implement dealloc in either document controller
1619 because WebView and WKWebView's UIDelegate property does not hold a
1622 2015-02-20 Timothy Horton <timothy_horton@apple.com>
1624 [WebEditingTester] Factor out list of editing operations
1625 https://bugs.webkit.org/show_bug.cgi?id=141826
1627 Reviewed by Sam Weinig.
1629 * WebEditingTester/AppDelegate.m:
1630 (-[WebEditingAppDelegate showOperations:]):
1631 * WebEditingTester/EditingOperations.h: Added.
1632 * WebEditingTester/EditingOperations.m: Added.
1633 (editingOperations):
1634 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj:
1635 Move EditingOperations array to its own file, and make it an NSArray
1636 instead of a C array. Adjust accordingly in showOperations:.
1638 2015-02-20 Michael Saboff <msaboff@apple.com>
1640 DFG JIT needs to check for stack overflow at the start of Program and Eval execution
1641 https://bugs.webkit.org/show_bug.cgi?id=141676
1643 Reviewed by Filip Pizlo.
1645 Set the newly added --maximumEvalCacheableSourceLength option for eager test runs. This is needed
1646 to allow the eval out of stack tests to tier up. Without this option, we don't cache the likely
1647 large string expression that we want to eval.
1649 * Scripts/run-jsc-stress-tests:
1651 2015-02-19 Daniel Bates <dabates@apple.com>
1653 REGRESSION (r180239): run-webkit-test fails to boot simulator device that was booted by previous test run
1654 https://bugs.webkit.org/show_bug.cgi?id=141815
1655 <rdar://problem/19893933>
1657 Reviewed by Simon Fraser.
1659 Fixes an issue where run-webkit-tests would fail to boot the WebKit Tester simulator device if it
1660 was booted by iOS Simulator in a previous run of run-webkit-test.
1662 * Scripts/webkitpy/port/ios.py:
1663 (IOSSimulatorPort.check_sys_deps): Added logic moved from IOSSimulatorPort.setup_test_run().
1664 (IOSSimulatorPort.setup_test_run): Moved logic to quit the iOS Simulator app and wait for the
1665 testing device to be in the shutdown state from here to IOSSimulatorPort.check_sys_deps().
1667 2015-02-19 David Kilzer <ddkilzer@apple.com>
1669 check-webkit-style: do not warn about missing primary header for *SoftLink.cpp files
1670 <http://webkit.org/b/141799>
1672 Reviewed by Alex Christensen.
1674 * Scripts/webkitpy/style/checkers/cpp.py:
1675 (_IncludeState.check_next_include_order): Don't emit a warning
1676 if the primary header exists and the source file name ends with
1677 "SoftLink.cpp". Add 'filename' argument to method.
1678 (check_include_line): Pass in 'filename'.
1680 * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1681 (OrderOfIncludesTest.test_check_next_include_order__no_config):
1682 (OrderOfIncludesTest.test_check_next_include_order__no_self):
1683 (OrderOfIncludesTest.test_check_next_include_order__likely_then_config):
1684 (OrderOfIncludesTest.test_check_next_include_order__other_then_config):
1685 (OrderOfIncludesTest.test_check_next_include_order__config_then_other_then_likely):
1686 - Add test filename arguments for calls to
1687 check_next_include_order().
1688 (OrderOfIncludesTest.test_primary_header): Add test for a file
1689 name ending in "SoftLink.cpp".
1691 2015-02-18 Enrica Casucci <enrica@apple.com>
1693 Add new tool to test editable Webviews.
1694 https://bugs.webkit.org/show_bug.cgi?id=141772
1696 Reviewed by Tim Horton.
1698 Adding WebEditingTester, a Cocoa application to
1699 test WK1 and Wk2 views in editable mode.
1701 * WebEditingTester: Added.
1702 * WebEditingTester/AppDelegate.h: Added.
1703 * WebEditingTester/AppDelegate.m: Added.
1704 (-[WebEditingAppDelegate init]):
1705 (defaultConfiguration):
1706 (-[WebEditingAppDelegate applicationDidFinishLaunching:]):
1707 (-[WebEditingAppDelegate applicationWillTerminate:]):
1708 (-[WebEditingAppDelegate newEditor:]):
1709 (-[WebEditingAppDelegate showOperations:]):
1710 (-[WebEditingAppDelegate useWebKit2ByDefault]):
1711 (-[WebEditingAppDelegate toggleUseWK2ByDefault:]):
1712 (-[WebEditingAppDelegate validateMenuItem:]):
1713 * WebEditingTester/Info.plist: Added.
1714 * WebEditingTester/MainMenu.xib: Added.
1715 * WebEditingTester/WK1WebDocumentController.h: Added.
1716 * WebEditingTester/WK1WebDocumentController.m: Added.
1717 (-[WK1WebDocumentController awakeFromNib]):
1718 (-[WK1WebDocumentController loadContent]):
1719 (-[WK1WebDocumentController dealloc]):
1720 (-[WK1WebDocumentController pasteAsMarkup:]):
1721 * WebEditingTester/WK2WebDocumentController.h: Added.
1722 * WebEditingTester/WK2WebDocumentController.m: Added.
1723 (-[WK2WebDocumentController initWithConfiguration:]):
1724 (-[WK2WebDocumentController pasteAsMarkup:]):
1725 (-[WK2WebDocumentController awakeFromNib]):
1726 (-[WK2WebDocumentController dealloc]):
1727 (-[WK2WebDocumentController loadContent]):
1728 * WebEditingTester/WebDocument.xib: Added.
1729 * WebEditingTester/WebDocumentController.h: Added.
1730 * WebEditingTester/WebDocumentController.m: Added.
1731 (-[WebDocumentController initWithWindow:]):
1732 (-[WebDocumentController windowDidLoad]):
1733 (-[WebDocumentController defaultEditingSource]):
1734 (-[WebDocumentController applicationTerminating]):
1735 (-[WebDocumentController loadContent]):
1736 * WebEditingTester/WebEditingTester.xcodeproj: Added.
1737 * WebEditingTester/WebEditingTester.xcodeproj/project.pbxproj: Added.
1738 * WebEditingTester/main.m: Added.
1741 2015-02-18 Csaba Osztrogonác <ossy@webkit.org>
1743 Run JSC tests on ARM EFL bots
1744 https://bugs.webkit.org/show_bug.cgi?id=141165
1746 Reviewed by Alexey Proskuryakov.
1748 * BuildSlaveSupport/build.webkit.org-config/config.json:
1749 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1750 (RunJavaScriptCoreTests.countFailures):
1751 (RunRemoteJavaScriptCoreTests):
1752 (RunRemoteJavaScriptCoreTests.start):
1753 (BuildAndRemoteJSCTestsFactory):
1754 (BuildAndRemoteJSCTestsFactory.__init__):
1756 2015-02-18 Alexey Proskuryakov <ap@apple.com>
1758 Streamline unexported function build fixes
1759 https://bugs.webkit.org/show_bug.cgi?id=141761
1761 Reviewed by Alex Christensen.
1763 * Scripts/check-for-weak-vtables-and-externals: (readXcode5SymbolsToIgnore): Deleted.
1764 We don't need to ignore symbols that are not exported due to the .unexp file.
1766 2015-02-18 Timothy Horton <timothy_horton@apple.com>
1768 Remove more references to WebCore.exp.in
1769 https://bugs.webkit.org/show_bug.cgi?id=141747
1771 Reviewed by Alexey Proskuryakov.
1773 * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
1776 2015-02-17 Myles C. Maxfield <mmaxfield@apple.com>
1778 Windows test results should not fall back to mac-mountainlion after r180176
1779 https://bugs.webkit.org/show_bug.cgi?id=141719
1781 Reviewed by Brent Fulgham.
1783 * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1784 (_should_file_trigger_build):
1785 * Scripts/webkitpy/port/win.py:
1786 (WinPort.default_baseline_search_path):
1787 * Scripts/webkitpy/port/win_unittest.py:
1788 (WinPortTest.test_baseline_search_path):
1790 2015-02-17 Daniel Bates <dabates@apple.com>
1792 [iOS] run-webkit-tests should check that simctl can boot and shutdown simulator device before running tests
1793 https://bugs.webkit.org/show_bug.cgi?id=141718
1795 Reviewed by Alex Christensen.
1797 We should only run layout tests if simctl can successfully boot and shutdown the testing device.
1799 * Scripts/webkitpy/port/ios.py:
1800 (IOSSimulatorPort.check_sys_deps): Modified to call Simulator.check_simulator_device_and_erase_if_needed().
1801 Log a error and return False if we are unable to boot the simulator device so that the caller can take
1802 appropriate action, say exit(3) before running any layout tests.
1803 * Scripts/webkitpy/xcode/simulator.py:
1804 (Simulator._boot_and_shutdown_simulator_device): Added. Boot and then shut down the simulator device
1805 with the specified UDID.
1806 (Simulator.check_simulator_device_and_erase_if_needed): Added. Checks that simulator device
1807 with the specified UDID can successfully boot and shut down. We make at most two attempts to
1808 boot and shut down the device, erasing the device between tries so as to restore the device
1809 to a known good state.
1811 2015-02-17 Daniel Bates <dabates@apple.com>
1813 run_webkit_tests.py should not know about iOS Simulator details
1814 https://bugs.webkit.org/show_bug.cgi?id=141711
1816 Reviewed by Alex Christensen.
1818 Run_webkit_tests.py should only parse the iOS-specific command
1819 line options --runtime and --device-type. Let the port-specific
1820 logic in ios.py validate the parsed options and instantiate
1821 internal data structures.
1823 Currently run_webkit_tests.py parses the iOS-specific command
1824 line options --runtime and --device-type, validates them, and
1825 instantiates internal data structures from the parsed strings.
1826 Instead the validation logic and instantiation of internal
1827 data structures should be handled by the iOS port object.
1829 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1830 (_set_up_derived_options): Remove logic to validate --runtime and --device-type
1831 and instantiate internal data structures for them.
1832 * Scripts/webkitpy/port/driver.py:
1833 (IOSSimulatorDriver.cmd_line): Modified to reference IOSSimulatorPort.simulator_runtime
1834 and IOSSimulatorPort.simulator_device_type for the iOS Simulator runtime and device type,
1836 * Scripts/webkitpy/port/ios.py: Sort the list of imports.
1837 (IOSSimulatorPort.simulator_runtime): Added. Instantiates a Runtime
1838 object from --runtime, if specified. Otherwise, instantiates a Runtime
1839 object for the latest installed iphonesimulator SDK version.
1840 (IOSSimulatorPort.simulator_device_type): Added. Instantiates a DeviceType
1841 object from --device-type, if specified. Otherwise, instantiates
1842 a DeviceType object for a iPhone 5 or iPhone 5s when on a 32-bit and 64-bit
1843 machine, respectively.
1844 (IOSSimulatorPort.check_sys_deps): Added. Validate if the chosen iOS simulator
1845 runtime is available to use.
1846 (IOSSimulatorPort.testing_device): Modified to make use of properties simulator_device_type
1847 and simulator_runtime for the iOS Simulator device type and runtime, respectively.
1848 * Scripts/webkitpy/xcode/simulator.py:
1849 (Runtime.from_version_string): Added. Turns around and calls Runtime.from_identifier()
1850 with a runtime identifier for the specified iOS version.
1852 2015-02-17 Dana Burkart <dburkart@apple.com>
1854 ASan does not like JSC::MachineThreads::tryCopyOtherThreadStack
1855 https://bugs.webkit.org/show_bug.cgi?id=141672
1857 Reviewed by David Kilzer.
1859 * asan/webkit-asan-ignore.txt:
1861 2015-02-17 Alex Christensen <achristensen@webkit.org>
1863 Remove WebCore.exp.in and clean up.
1864 https://bugs.webkit.org/show_bug.cgi?id=141491
1866 Reviewed by Andreas Kling.
1868 * Scripts/sort-export-file: Removed.
1869 * Scripts/webkitpy/style/checker.py:
1872 (CheckerDispatcher._file_type):
1873 (CheckerDispatcher._create_checker):
1874 Don't check if the export files are sorted.
1875 * Scripts/webkitpy/style/checkers/exportfile.py: Removed.
1876 * Scripts/webkitpy/style/checkers/exportfile_unittest.py: Removed.
1878 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
1880 Unreviewed. Fix GTK+ make distcheck.
1882 Do not exclude bmalloc directory from the tarball.
1884 * gtk/manifest.txt.in:
1886 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
1888 Unreviewed. Fix /webkit2/WebKitDOMNode/dom-cache after r180214.
1890 I forgot to add the return of a bool function.
1892 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1893 (WebKitDOMNodeTest::testDOMCache):
1895 2015-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
1897 [GTK] GObject DOM bindings object are cached forever
1898 https://bugs.webkit.org/show_bug.cgi?id=141558
1900 Reviewed by Sergio Villar Senin.
1902 Add checks for all DOM objects to ensure they are not leaked. Also
1903 add a dedicated test for the DOM Object Cache.
1905 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1906 (WebKitDOMNodeFilterTest::testTreeWalker):
1907 (WebKitDOMNodeFilterTest::testNodeIterator):
1908 * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1909 (WebKitDOMNodeTest::testHierarchyNavigation):
1910 (WebKitDOMNodeTest::testInsertion):
1911 (WebKitDOMNodeTest::testTagNames):
1912 (WebKitDOMNodeTest::testDOMCache):
1914 * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1915 (WebKitDOMXPathNSResolverTest::evaluateFooChildTextAndCheckResult):
1916 (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
1917 (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
1918 * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
1919 (testWebKitDOMObjectCache):
1921 * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1922 (documentLoadedCallback):
1924 2015-02-16 Carlos Garcia Campos <cgarcia@igalia.com>
1926 [GTK] WebKitFrame objects are never released
1927 https://bugs.webkit.org/show_bug.cgi?id=141641
1929 Reviewed by Martin Robinson.
1931 Add a way to check GObjects leaks for WebProcess tests and check
1932 WebKitFrame objects are not leaked.
1934 * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
1935 (WebKitFrameTest::testMainFrame):
1936 (WebKitFrameTest::testURI):
1937 (WebKitFrameTest::testJavaScriptContext):
1938 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1939 (WebProcessTest::assertObjectIsDeletedWhenTestFinishes):
1941 * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1943 2015-02-16 Tim Horton <timothy_horton@apple.com>
1945 Fix the MiniBrowser build with newer clang
1947 * MiniBrowser/mac/SettingsController.m:
1948 (-[SettingsController _toggleBooleanDefault:]):
1949 * MiniBrowser/mac/WK1BrowserWindowController.m:
1950 (-[WK1BrowserWindowController windowWillClose:]):
1951 * MiniBrowser/mac/WK2BrowserWindowController.m:
1952 (-[WK2BrowserWindowController windowWillClose:]):
1953 NSApp is id and clang gets confused about which -delegate we're talking about.
1955 2015-02-16 Antti Koivisto <antti@apple.com>
1957 Develop/Disable Caches does not properly disable disk cache
1958 https://bugs.webkit.org/show_bug.cgi?id=141636
1960 Reviewed by Anders Carlsson.
1962 Make testRunner.setCacheModel() use the WKContext interface so the model gets passed to
1963 the network process too.
1965 This makes setCacheModel asynchronous but there don't seem to be any tests that expect otherwise.
1967 * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1968 (WTR::InjectedBundle::beginTesting):
1969 (WTR::InjectedBundle::setCacheModel):
1970 * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1971 * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1973 Forward to TestController.
1975 (WTR::TestRunner::setCacheModel):
1976 * WebKitTestRunner/TestInvocation.cpp:
1977 (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1979 2015-02-16 Andrzej Badowski <a.badowski@samsung.com>
1981 Unreviewed. Add myself as a committer.
1983 * Scripts/webkitpy/common/config/contributors.json:
1985 2015-02-15 David Kilzer <ddkilzer@apple.com>
1987 REGRESSION (r180082): WebCore Debug builds fail on Mavericks due to weak export symbols
1988 <http://webkit.org/b/141607>
1990 * Scripts/check-for-weak-vtables-and-externals: Ignore weak
1991 externals in Source/WebCore/Configurations/WebCore.unexp when
1992 building with Xcode 5.x.
1993 (readXcode5SymbolsToIgnore): Add.
1995 2015-02-15 KwangHyuk Kim <hyuki.kim@samsung.com>
1997 [EFL] fix Evas GL engine error.
1998 https://bugs.webkit.org/show_bug.cgi?id=141621
2000 Reviewed by Gyuyoung Kim.
2002 As new elm engine api was added from efl 1.10, replace elm_config_preferred_engine_set with elm_config_accel_preference_set.
2004 * MiniBrowser/efl/main.c:
2007 2015-02-14 Csaba Osztrogonác <ossy@webkit.org>
2009 [buildbot] Enable run-api-tests on release Mac bots
2010 https://bugs.webkit.org/show_bug.cgi?id=141518
2012 Reviewed by Darin Adler.
2014 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2016 (BuildFactory.__init__):
2017 (TestFactory.__init__):
2018 (BuildAndTestFactory.__init__):
2019 (RunUnitTests.start): Deleted.
2020 (unitTestsSupported): Deleted.
2022 2015-02-13 Anders Carlsson <andersca@apple.com>
2024 Add a move constructor and move assignment operator to Deque
2025 https://bugs.webkit.org/show_bug.cgi?id=141571
2027 Reviewed by Andreas Kling.
2029 * TestWebKitAPI/Tests/WTF/Deque.cpp:
2030 (TestWebKitAPI::TEST):
2032 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
2034 run-jsc-stress-tests --remote should skip profiler tests
2035 https://bugs.webkit.org/show_bug.cgi?id=141470
2037 Reviewed by Filip Pizlo.
2039 * Scripts/run-jsc-stress-tests:
2041 2015-02-13 Anders Carlsson <andersca@apple.com>
2043 Add an initializer list constructor to Deque
2044 https://bugs.webkit.org/show_bug.cgi?id=141565
2046 Reviewed by Andreas Kling.
2048 * TestWebKitAPI/Tests/WTF/Deque.cpp:
2049 (TestWebKitAPI::TEST):
2051 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
2053 [buildbot] Remove buildJSCTool cruft from master.cfg
2054 https://bugs.webkit.org/show_bug.cgi?id=141513
2056 Reviewed by Alexey Proskuryakov.
2058 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2059 (RunJavaScriptCoreTests):
2060 (RunJavaScriptCoreTests.start):
2062 (RunWebKitTests.start):
2063 (TestFactory.__init__):
2064 (TestLeaksFactory.__init__):
2065 (RunJavaScriptCoreTests.__init__): Deleted.
2066 (RunWebKitTests.__init__): Deleted.
2068 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
2070 Unreviewed, remove empty directories.
2072 * DumpRenderTree/gtk: Removed.
2073 * DumpRenderTree/gtk/fonts: Removed.
2074 * DumpRenderTree/unix: Removed.
2075 * DumpRenderTree/unix/TestNetscapePlugin: Removed.
2076 * GtkLauncher: Removed.
2077 * TestWebKitAPI/Tests/WebKitGtk: Removed.
2078 * TestWebKitAPI/Tests/WebKitGtk/resources: Removed.
2079 * WebKitTestRunner/WebKitTestRunnerAppTests: Removed.
2080 * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj: Removed.
2082 2015-02-13 Csaba Osztrogonác <ossy@webkit.org>
2084 Remove Windows cruft from Tools/Scripts/build-webkittestrunner
2085 https://bugs.webkit.org/show_bug.cgi?id=141519
2087 Reviewed by Alexey Proskuryakov.
2089 * Scripts/build-webkittestrunner:
2091 2015-02-12 Alex Christensen <achristensen@webkit.org>
2093 Removed empty directory.
2095 * WinCELauncher: Removed.
2097 2015-02-12 Csaba Osztrogonác <ossy@webkit.org>
2099 run-jsc-stress-tests --remote should be able add the necessary libraries to the bundle on Linux
2100 https://bugs.webkit.org/show_bug.cgi?id=141202
2102 Reviewed by Darin Adler.
2104 * Scripts/run-jsc-stress-tests:
2106 2015-02-12 Brent Fulgham <bfulgham@apple.com>
2108 [Win] Test bot infrastructure should not try to find/use old Safari DLLs
2109 https://bugs.webkit.org/show_bug.cgi?id=141517
2111 Reviewed by Anders Carlsson.
2113 We do not need to locate or use the DLL's that came with Safari, so stop
2114 failing when we cannot find them. Also remove some old Qt cruft from this
2117 * BuildSlaveSupport/built-product-archive:
2118 (archiveBuiltProduct):
2119 (extractBuiltProduct):
2121 2015-02-11 Brent Fulgham <bfulgham@apple.com>
2123 [Win] [64-bit] Work around MSVC2013 Runtime Bug
2124 https://bugs.webkit.org/show_bug.cgi?id=141498
2125 <rdar://problem/19803642>
2127 Reviewed by Anders Carlsson.
2129 Disable FMA3 instruction use in the MSVC math library to
2130 work around a VS2013 runtime crash. We can remove this
2131 workaround when we switch to VS2015.
2133 * DumpRenderTree/cg/ImageDiffCG.cpp: Call _set_FMA3_enable(0) to
2134 disable FMA3 support.
2135 * DumpRenderTree/win/DumpRenderTree.cpp: Ditto.
2136 * DumpRenderTree/win/ImageDiffCairo.cpp: Ditto.
2137 * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
2138 * Scripts/webkitperl/httpd.pm: Ditto.
2139 * TestWebKitAPI/win/main.cpp: Ditto.
2140 * WinLauncher/Common.cpp: Ditto.
2141 * win/DLLLauncher/DLLLauncherMain.cpp: Ditto.
2143 2015-02-12 Csaba Osztrogonác <ossy@webkit.org>
2145 run-jsc-stress-tests should accept remote host config from JSON file
2146 https://bugs.webkit.org/show_bug.cgi?id=141509
2148 Reviewed by Michael Saboff.
2150 * Scripts/run-javascriptcore-tests:
2151 (runJSCStressTests):
2152 * Scripts/run-jsc-stress-tests:
2154 2015-02-12 Carlos Garcia Campos <cgarcia@igalia.com>
2156 [GTK] Add API to allow overriding the default color chooser implementation
2157 https://bugs.webkit.org/show_bug.cgi?id=98935
2159 Reviewed by Gustavo Noronha Silva.
2161 Add a color chooser implementation for MiniBrowser using
2162 GtkPopover when the GTK+ version is recent enough.
2163 And a test case to check the new color chooser API.
2165 * MiniBrowser/gtk/BrowserWindow.c:
2166 (colorChooserRGBAChanged):
2167 (popoverColorClosed):
2168 (colorChooserRequestFinished):
2169 (runColorChooserCallback):
2170 (browserWindowConstructed):
2171 * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
2172 (testWebViewColorChooserRequest):
2175 2015-02-11 Csaba Osztrogonác <ossy@webkit.org>
2177 Make run-jsc-stress-tests --remote work with make-based runner
2178 https://bugs.webkit.org/show_bug.cgi?id=141079
2180 Reviewed by Darin Adler.
2182 * Scripts/run-javascriptcore-tests:
2183 (runJSCStressTests): Pass through the --shell-runner and --make-runner arguments.
2184 * Scripts/run-jsc-stress-tests: Made the make-based runner the default runner,
2185 except for remote testing on Darwin. Unified runShellTestRunner and runMakeTestRunner
2186 to avoid code duplication.
2188 2015-02-11 Csaba Osztrogonác <ossy@webkit.org>
2190 run-jsc-stress tests should detect the number of processors on the remote machine too
2191 https://bugs.webkit.org/show_bug.cgi?id=141196
2193 Reviewed by Darin Adler.
2195 * Scripts/run-javascriptcore-tests:
2196 (runJSCStressTests): Pass through the --child-processes argument.
2197 * Scripts/run-jsc-stress-tests: Added determineNumberOfProcessors function
2198 to detect the number of local and remote processors with the same algorithm.
2199 Additionally introduced $numChildProcesses to emphasize it isn't necessarily
2200 same as $numProcessors.
2202 2015-02-11 Csaba Osztrogonác <ossy@webkit.org>
2204 run-jsc-stress-tests should pass JSC_timeout to remote hosts
2205 https://bugs.webkit.org/show_bug.cgi?id=141164
2207 Reviewed by Darin Adler.
2209 Additonally removed IMPORTANT_ENVS, since JSC_timeout was the only one.
2211 * Scripts/run-jsc-stress-tests:
2213 2015-02-11 Carlos Garcia Campos <cgarcia@igalia.com>
2215 [GTK] Add default color chooser implementation using GtkColorChooserDialog
2216 https://bugs.webkit.org/show_bug.cgi?id=141392
2218 Reviewed by Gustavo Noronha Silva.
2220 Enable INPUT_TYPE_COLOR by default for GTK+ port.
2222 * Scripts/webkitperl/FeatureList.pm:
2224 2015-02-09 Csaba Osztrogonác <ossy@webkit.org>
2226 run-jsc-stress-tests shell test runner should run tests in fixed order
2227 https://bugs.webkit.org/show_bug.cgi?id=141383
2229 Reviewed by Darin Adler.
2231 * Scripts/jsc-stress-test-helpers/shell-runner.sh:
2233 2015-02-08 Chris Fleizach <cfleizach@apple.com>
2235 AX: VoiceOver appears unresponsive when JavaScript alerts are triggered via focus or blur events
2236 https://bugs.webkit.org/show_bug.cgi?id=140485
2238 Reviewed by Anders Carlsson.
2240 Implement takeFocus() as a way to set focus through accessibility wrappers.
2242 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2243 (AccessibilityUIElement::takeFocus):
2244 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2245 (WTR::AccessibilityUIElement::takeFocus):
2247 2015-02-08 Darin Adler <darin@apple.com>
2249 Remove the SVG instance tree
2250 https://bugs.webkit.org/show_bug.cgi?id=140602
2252 Reviewed by Dean Jackson.
2254 * Scripts/check-for-global-initializers: Removed special case for
2255 SVGElementInstance.o.
2257 2015-02-07 David Kilzer <ddkilzer@apple.com>
2259 [iOS] run-webkit-tests fails due to simulator devices from previous SDK installs being marked as unavailable
2260 <http://webkit.org/b/141365>
2262 Reviewed by Daniel Bates.
2264 * Scripts/webkitpy/xcode/simulator.py:
2265 (Simulator): Add unavailable_version_re precompiled regex.
2266 (Simulator._parse_devices): Check for unavailable versions and
2267 ignore them if found when parsing the output of
2268 `xcrun simctl list`.
2269 * Scripts/webkitpy/xcode/simulator_unittest.py:
2270 (test_unavailable_devices): Add test with output from
2271 `xcrun simctl list` with unavailable runtimes that fails before
2274 2015-02-07 Chris Dumez <cdumez@apple.com>
2276 Add Vector::removeFirstMatching() / removeAllMatching() methods taking lambda functions
2277 https://bugs.webkit.org/show_bug.cgi?id=141321
2279 Reviewed by Darin Adler.
2281 Use new Vector::removeFirstMatching() / removeAllMatching() methods.
2283 2015-02-07 David Kilzer <ddkilzer@apple.com>
2285 [iOS] Make Simulator class testable
2286 <http://webkit.org/b/141358>
2288 Rubber-stamped by Darin Adler.
2290 * Scripts/webkitpy/common/system/platforminfo.py:
2291 (PlatformInfo.xcode_simctl_list): Move `xcrun simctl list`
2292 command to here from Simulator.refresh() in xcode/simulator.py
2293 so that the output of the command can be mocked.
2295 * Scripts/webkitpy/common/system/platforminfo_mock.py:
2296 (MockPlatformInfo.__init__): Set self.expected_xcode_simctl_list
2298 (MockPlatformInfo.xcode_simctl_list): Add method that returns
2299 self.expected_xcode_simctl_list expectation.
2301 * Scripts/webkitpy/xcode/simulator.py: Add missing copyright
2303 (Simulator.__init__): Add optional 'host' parameter to make it
2304 possible to pass in a mock object for testing. Set self._host
2305 to 'host' parameter or create Host() object.
2306 (Simulator.refresh): Call new PlatformInfo.xcode_simctl_list()
2309 * Scripts/webkitpy/xcode/simulator_unittest.py: Add unit test
2312 (SimulatorTest.setUp):
2313 (SimulatorTest._set_expected_xcrun_simctl_list):
2314 (SimulatorTest.test_simulator_device_types):
2315 (test_invalid_device_types_header):
2316 (test_invalid_runtimes_header):
2317 (test_invalid_devices_header):
2319 2015-02-07 Csaba Osztrogonác <ossy@webkit.org>
2321 run-jsc-stress-tests --remote should use the default ssh port
2322 https://bugs.webkit.org/show_bug.cgi?id=141287
2324 Reviewed by Darin Adler.
2326 * Scripts/run-jsc-stress-tests: Extended URI module to be able to handle ssh scheme with the default 22 port number.
2328 2015-02-06 Dana Burkart <dburkart@apple.com>
2330 dashboard: BuildbotTesterQueueView crashesOnly logic is wrong
2331 https://bugs.webkit.org/show_bug.cgi?id=141349
2333 Reviewed by Alexey Proskuryakov.
2335 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2336 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2337 (BuildbotTesterQueueView.prototype.update):
2339 2015-02-06 Alexey Proskuryakov <ap@apple.com>
2341 Report network process crashes during layout tests
2342 https://bugs.webkit.org/show_bug.cgi?id=139646
2344 Reviewed by Anders Carlsson.
2346 * WebKitTestRunner/TestController.cpp:
2347 (WTR::TestController::initialize):
2348 (WTR::TestController::networkProcessName):
2349 (WTR::TestController::networkProcessDidCrash):
2350 * WebKitTestRunner/TestController.h:
2352 2015-02-06 Csaba Osztrogonác <ossy@webkit.org>
2354 run-jsc-stress-tests --remote should create remote directory before copying the bundle
2355 https://bugs.webkit.org/show_bug.cgi?id=141329
2357 Reviewed by Michael Saboff.
2359 * Scripts/run-jsc-stress-tests:
2361 2015-02-06 Carlos Garcia Campos <cgarcia@igalia.com>
2363 [GTK] Remove WebKitWebView::close-notification signal
2364 https://bugs.webkit.org/show_bug.cgi?id=141330
2366 Reviewed by Gustavo Noronha Silva.
2368 Update notifications unit tests according to the API changes, and
2369 add a test case to check that onclose event is fired when a
2370 notification is closed by the user.
2372 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2373 (testWebViewNotification):
2375 2015-02-05 Alexey Proskuryakov <ap@apple.com>
2377 Dashboard doesn't consider building ASan a productive step
2378 https://bugs.webkit.org/show_bug.cgi?id=141312
2380 Reviewed by Simon Fraser.
2382 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2384 2015-02-05 Daniel Bates <dabates@apple.com>
2386 [iOS] webkitpy.xcode.simulator.Runtime.from_identifier() returns wrong result for non-existent runtime
2387 https://bugs.webkit.org/show_bug.cgi?id=141306
2389 Reviewed by Alexey Proskuryakov.
2391 The function webkitpy.xcode.simulator.Runtime.from_identifier always returns a Runtime object
2392 corresponding to the last-most runtime parsed from the output of `simctl list` for any non-
2395 * Scripts/webkitpy/xcode/simulator.py:
2396 (Runtime.from_identifier):
2398 2015-02-05 Daniel Bates <dabates@apple.com>
2400 LayoutTestRelay does not install DumpRenderTree.app/WebKitTestRunnerApp.app
2401 https://bugs.webkit.org/show_bug.cgi?id=139746
2402 <rdar://problem/19283658>
2404 Reviewed by Alexey Proskuryakov.
2406 Fixes an issues where LayoutTestRelay may fail to install DumpRenderTree.app/WebKitTestRunnerApp.app
2407 if the simulator device is not in state Booted.
2409 Currently run-webkit-test --ios-sim executes LayoutTestRelay immediately after
2410 launching/relaunching the iOS Simulator app and a simulator app can only be installed
2411 on a device that is in the Booted state. LayoutTestRelay may run before the
2412 device is booted and hence fail to install DumpRenderTree.app/WebKitTestRunnerApp.app.
2413 We should defer executing LayoutTestRelay until the simulator device booted by
2414 iOS Simulator is in the Booted state.
2416 * Scripts/webkitpy/port/ios.py: Import webkitpy.xcode.simulator.Simulator to avoid prefixing
2417 Simulator methods with the module name, simulator.
2418 (IOSSimulatorPort.setup_test_run): Wait for the simulator device to be in the Booted state
2419 after launching iOS Simulator. Also, wait until the simulator device is in the Shutdown state
2420 before launching iOS Simulator to boot it.
2421 (IOSSimulatorPort.testing_device): Fix up caller since we now import webkitpy.xcode.simulator.Simulator.
2422 (IOSSimulatorPort.simulator_path): Deleted; moved this function to class Simulator and renamed to device_directory().
2423 * Scripts/webkitpy/xcode/simulator.py:
2424 (Device.__init__): Remove parameter state and an instance variable of the same name, which represented
2425 the state of the device when we created this object as part of parsing the output of `simctl list`. Callers
2426 interested in the state of the device are more likely interested in the current state of the device as
2427 opposed to the state of the device when the Device object was created.
2428 (Device.state): Added; turn around and call Simulator.device_state() for the current state of the device.
2429 (Device.path): Extracted implementation into Simulator.device_directory() so that it can be called
2430 from both this function and Simulator.device_state().
2431 (Device.create): Use Simulator.wait_until_device_is_in_state() to simplify the implementation of this function.
2432 (Simulator.DeviceState): Added; class of constants.
2433 (Simulator.wait_until_device_is_in_state): Added; this function does not return until the specified
2434 device is in the specified state.
2435 (Simulator.device_state): Added; parses the state of the device from the appropriate CoreSimulator device.plist file.
2436 (Simulator.device_directory): Added.
2437 (Simulator._parse_devices): Do not pass argument state to Device constructor as it no longer accepts it.
2439 2015-02-05 Alexey Proskuryakov <ap@apple.com>
2441 Disable retries on Mac debug testers
2442 https://bugs.webkit.org/show_bug.cgi?id=141296
2444 Reviewed by Simon Fraser.
2446 * BuildSlaveSupport/build.webkit.org-config/config.json:
2448 2015-02-05 Dan Bernstein <mitz@apple.com>
2450 Need a way to force $xcodeSDK in webkitdirs.pm
2451 https://bugs.webkit.org/show_bug.cgi?id=141291
2453 Reviewed by Anders Carlsson.
2455 * Scripts/webkitdirs.pm:
2456 (setXcodeSDK): Added.
2458 2015-02-05 Youenn Fablet <youenn.fablet@crf.canon.fr> and Xabier Rodriguez Calvar <calvaris@igalia.com>
2460 [Streams API] Implement a barebone ReadableStream interface
2461 https://bugs.webkit.org/show_bug.cgi?id=141045
2463 Reviewed by Benjamin Poulain.
2465 * Scripts/webkitperl/FeatureList.pm: Added streams-api compilation switch.
2467 2015-02-04 Joseph Pecoraro <pecoraro@apple.com>
2469 filter-build-webkit: reduce more unfiltered output
2470 https://bugs.webkit.org/show_bug.cgi?id=141282
2472 Reviewed by Daniel Bates.
2474 * Scripts/filter-build-webkit:
2475 Report CompileDTraceScript and Preprocess lines as successful.
2477 2015-02-04 Dana Burkart <dburkart@apple.com>
2479 Botwatcher's Dashboard is cramped
2480 https://bugs.webkit.org/show_bug.cgi?id=140273
2482 Reviewed by Alexey Proskuryakov.
2484 Add a heading key which will allow for arbitrary headings in builder queues.
2486 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2487 (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
2488 (BuildbotBuilderQueueView.prototype.update):
2489 (BuildbotBuilderQueueView.prototype.update.appendBuildArchitecture): Deleted.
2490 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2491 (BuildbotIteration.prototype._parseData):
2492 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2493 (BuildbotLeaksQueueView.prototype.update):
2494 (BuildbotLeaksQueueView.prototype.update.appendBuild): Deleted.
2495 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2496 (BuildbotPerformanceQueueView.prototype.update):
2497 (BuildbotPerformanceQueueView.prototype.update.appendBuild): Deleted.
2498 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2500 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2501 (BuildbotQueueView.prototype._unauthorizedAccess):
2502 (BuildbotQueueView.prototype._appendBuild):
2503 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2504 (BuildbotTestResults):
2505 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2506 (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2507 (BuildbotTesterQueueView.prototype.update):
2508 (BuildbotTesterQueueView.prototype.update.appendBuild): Deleted.
2510 2015-02-04 Simon Fraser <simon.fraser@apple.com>
2512 WKTR should not use -mainScreen to pick a color profile
2513 https://bugs.webkit.org/show_bug.cgi?id=141265
2515 Reviewed by Tim Horton.
2517 -[NSScreen mainScreen] depends on the active window, so use the first screen
2518 (which is the one we put the window on anyway).
2520 Do some cleanup in DRT that makes the code look similar.
2522 * DumpRenderTree/mac/DumpRenderTree.mm:
2523 (createWebViewAndOffscreenWindow):
2524 * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2525 (WTR::PlatformWebView::PlatformWebView):
2527 2015-02-04 Simon Fraser <simon.fraser@apple.com>
2529 LayoutTestHelper should set the color profile of all displays
2530 https://bugs.webkit.org/show_bug.cgi?id=141260
2532 Reviewed by Tim Horton.
2534 WebKitTestRunner can (erroneously) grab the colorspace of the "main" screen.
2535 which is the screen with the active window. Make things more robust by changing
2536 the colorspace of all displays, not just the main screen, when running layout tests.
2538 * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Enable ARC
2539 * DumpRenderTree/mac/LayoutTestHelper.m:
2540 (originalColorProfileURLs):
2541 (colorProfileURLForDisplay):
2542 (displayUUIDStrings):
2543 (saveDisplayColorProfiles):
2544 (setDisplayColorProfile):
2545 (restoreDisplayColorProfiles):
2546 (installLayoutTestColorProfile):
2547 (restoreUserColorProfile):
2549 Store display color profiles by map of UUID strings to URLs (NSUUID and CFUUID are not
2550 toll-free bridged, sadly). Use the map to restore all profiles on exit.
2551 Convert to use more Obj-C types.
2553 2015-02-04 Daniel Bates <dabates@apple.com>
2555 test-webkitpy fails on Mac without iphoneos SDK
2556 https://bugs.webkit.org/show_bug.cgi?id=141255
2557 <rdar://problem/19619691>
2559 I inadvertently committed the wrong exception message. Fix up the exception message
2560 to instruct a person to install the iOS SDK when it cannot be found.
2562 * Scripts/webkitpy/port/ios.py:
2563 (IOSPort.determine_full_port_name):
2565 2015-02-04 Youenn Fablet <youenn.fablet@crf.canon.fr>
2567 W3C test importer should sort the list of files when generating the w3c-import.log
2568 https://bugs.webkit.org/show_bug.cgi?id=141156
2570 Reviewed by Bem Jones-Bey.
2572 Sort explicitly the list of imported files written in the w3c-import.log.
2573 Removed logging of the import date.
2575 * Scripts/webkitpy/w3c/test_importer.py:
2576 (TestImporter.write_import_log):
2578 2015-02-04 Daniel Bates <dabates@apple.com>
2580 test-webkitpy fails on Mac without iphoneos SDK
2581 https://bugs.webkit.org/show_bug.cgi?id=141255
2582 <rdar://problem/19619691>
2584 Reviewed by David Kilzer and Alexey Proskuryakov.
2586 Fixes an issue where test-webkitpy fails on a Mac without the iOS SDK. We should
2587 should not require the iphoneos SDK to be installed to run the webkitpy tests.
2589 * Scripts/webkitpy/common/system/platforminfo.py:
2590 (PlatformInfo.xcode_sdk_version): Added; return the version of the specified SDK, if
2591 installed. We take advantage of the behavior that xcrun --show-sdk-version only writes
2592 to standard output if the SDK is installed to return the empty string if the SDK is
2594 * Scripts/webkitpy/common/system/platforminfo_mock.py:
2595 (MockPlatformInfo.xcode_sdk_version): Added.
2596 * Scripts/webkitpy/port/ios.py:
2597 (IOSPort.determine_full_port_name): Modified to call PlatformInfo.xcode_sdk_version()
2598 to get the version of the iphoneos SDK, if installed.
2600 2015-02-04 Alexey Proskuryakov <ap@apple.com>
2602 run-webkit-tests doesn't always capture ASan violation reports
2603 https://bugs.webkit.org/show_bug.cgi?id=141231
2605 Reviewed by Darin Adler.
2607 * Scripts/webkitpy/port/driver.py:
2608 (Driver.run_test): Don't look for CrashReporter crash logs if a log was provided
2609 by the driver already (as is the case with ASan violations, which are printed to
2611 (Driver._check_for_address_sanitizer_violation): Check if the line is a start of ASan
2613 (Driver._read_block): Give ASan enough time to symbolicate a crash, and put it into
2614 a separate variable for reporting.
2616 2015-02-03 Ryosuke Niwa <rniwa@webkit.org>
2618 [webkitpy] Add platform specific Skipped file mechanism for performance tests
2619 https://bugs.webkit.org/show_bug.cgi?id=141152
2621 Reviewed by Csaba Osztrogonác.
2623 Support a test-expectation-like syntax in performance tests' skipped files.
2624 e.g. [Mac] Parsed/BadTest.html will skip Parsed/BadTest.html on Mac ports.
2626 * Scripts/webkitpy/port/base.py:
2627 (Port.skipped_perf_tests): Implemented the syntax support by a regular expression.
2629 * Scripts/webkitpy/port/base_unittest.py:
2630 (PortTest.test_skipped_perf_tests): Test the new syntax.
2632 2015-02-04 Alexey Proskuryakov <ap@apple.com>
2634 When tests fail on leaks bot so much that there are no leaks detected, dashboard erroneously shows green
2635 https://bugs.webkit.org/show_bug.cgi?id=141236
2637 Reviewed by Sam Weinig.
2639 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2640 (BuildbotLeaksQueueView.prototype.update.appendLeaksQueueStatus):
2642 2015-02-04 Chris Dumez <cdumez@apple.com>
2644 Add removeFirst(value) / removeAll(value) methods to WTF::Vector
2645 https://bugs.webkit.org/show_bug.cgi?id=141192
2647 Reviewed by Benjamin Poulain.
2649 Add API tests for Vector::removeFirst(value) and
2650 Vector::removeAll(value).
2652 * TestWebKitAPI/Tests/WTF/Vector.cpp:
2653 (TestWebKitAPI::TEST):
2655 2015-02-03 Tim Horton <timothy_horton@apple.com>
2657 Add WKPageNavigationClient as C SPI around API::NavigationClient, and adopt in WKTR
2658 https://bugs.webkit.org/show_bug.cgi?id=141217
2660 Reviewed by Sam Weinig.
2662 * WebKitTestRunner/TestController.cpp:
2663 (WTR::copyWebCryptoMasterKey):
2664 (WTR::TestController::createOtherPage):
2665 (WTR::TestController::createWebViewWithOptions):
2666 (WTR::TestController::ensureViewSupportsOptions):
2667 (WTR::TestController::didCommitNavigation):
2668 (WTR::TestController::didFinishNavigation):
2669 (WTR::TestController::canAuthenticateAgainstProtectionSpace):
2670 (WTR::TestController::didReceiveAuthenticationChallenge):
2671 (WTR::TestController::decidePolicyForPluginLoad):
2672 (WTR::TestController::decidePolicyForNavigationAction):
2673 (WTR::TestController::decidePolicyForNavigationResponse):
2674 (WTR::TestController::didCommitLoadForFrame): Deleted.
2675 (WTR::TestController::didFinishLoadForFrame): Deleted.
2676 * WebKitTestRunner/TestController.h:
2677 Adopt WKPageNavigationClient and adjust to its semantics (navigations are main-frame-only, etc.)
2679 2015-02-03 Dhi Aurrahman <diorahman@rockybars.com>
2681 Unreviewed. Add myself as a committer.
2683 * Scripts/webkitpy/common/config/contributors.json:
2685 2015-02-03 Brent Fulgham <bfulgham@apple.com>
2687 [Win] Unreviewed test fix.
2689 * DumpRenderTree/win/PolicyDelegate.cpp:
2690 (PolicyDelegate::unableToImplementPolicyWithError): The message was missing a linefeed,
2691 so was not matching expected output.
2693 2015-02-03 Youenn Fablet <youenn.fablet@crf.canon.fr>
2695 Unreviewed. Moving myself to the committer section at last.
2697 * Scripts/webkitpy/common/config/contributors.json:
2699 2015-02-03 Brent Fulgham <bfulgham@apple.com>
2701 [Win] Tests fail because DRT reports '(null)' instead of an empty string
2702 https://bugs.webkit.org/show_bug.cgi?id=141205
2704 Reviewed by Anders Carlsson.
2706 * DumpRenderTree/win/HistoryDelegate.cpp:
2707 (HistoryDelegate::didNavigateWithNavigationData): Deal with empty BSTR values
2708 properly so that we match expected DumpRenderTree output.
2710 2015-02-03 Michael Catanzaro <mcatanzaro@igalia.com>
2712 [GTK] TestWebKitAccessibility is not skipped
2713 https://bugs.webkit.org/show_bug.cgi?id=141179
2715 Reviewed by Carlos Garcia Campos.
2717 Don't attempt to skip TestWebKitAccessibility. This path is wrong so it was not being
2718 skipped, and it apparently works reliably on the bots.
2720 * Scripts/run-gtk-tests:
2723 2015-02-03 Carlos Alberto Lopez Perez <clopez@igalia.com>
2725 run-perf-tests: allow to specify a wrapper command.
2726 https://bugs.webkit.org/show_bug.cgi?id=141172
2728 Reviewed by Ryosuke Niwa.
2730 * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2731 (parse_args): Update text to indicate is also valid for WTR.
2732 * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2733 (PerfTestsRunner._parse_args): Add wrapper command.
2735 2015-02-03 Brent Fulgham <bfulgham@apple.com>
2737 [Win] Correct version parsing warning in update-webkit
2738 https://bugs.webkit.org/show_bug.cgi?id=141200
2740 Reviewed by Anders Carlsson.
2742 * Scripts/webkitdirs.pm:
2743 (setupAppleWinEnv): Strip out any specific version build level
2744 from the Cygwin version information.
2747 2015-02-03 Brent Fulgham <bfulgham@apple.com>
2749 [Win] Attempt to improve the reliability of HTTP service
2750 https://bugs.webkit.org/show_bug.cgi?id=141191
2752 Reviewed by Darin Adler.
2754 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2755 (LayoutTestApacheHttpd.__init__): Use default XAMPP pidfile location.
2756 (LayoutTestApacheHttpd._stop_running_server): Delete the abandoned PID file
2757 when stopping the service doesn't do so on its own (for Windows runs).
2759 2015-02-03 Youenn Fablet <youenn.fablet@crf.canon.fr>
2761 Web platform test server should not need to create __init__.py files
2762 https://bugs.webkit.org/show_bug.cgi?id=141030
2764 Reviewed by Ryosuke Niwa.
2766 W3C TestImporter ensures that copied __init__.py files are not empty.
2767 If needed, a comment is inserted in __init__.py files.
2768 Added a unit test to check that web-platform-tests tools and scripts python modules can be imported.
2770 * Scripts/webkitpy/common/system/filesystem.py:
2771 (FileSystem.getsize):
2772 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:
2773 (TestWebPlatformTestServer.test_start_cmd):
2774 (TestWebPlatformTestServer):
2775 (TestWebPlatformTestServer.test_import_web_platform_test_modules):
2776 * Scripts/webkitpy/w3c/test_importer.py:
2777 (TestImporter.import_tests):
2779 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
2781 Unreviewed. Moving myself to the committer section.
2783 * Scripts/webkitpy/common/config/contributors.json:
2785 2015-02-02 Saam Barati <saambarati1@gmail.com>
2787 Create tests for JSC's Control Flow Profiler
2788 https://bugs.webkit.org/show_bug.cgi?id=141123
2790 Reviewed by Filip Pizlo.
2792 * Scripts/run-javascriptcore-tests:
2793 (runJSCStressTests):
2794 * Scripts/run-jsc-stress-tests:
2796 2015-02-02 Csaba Osztrogonác <ossy@webkit.org>
2798 Remove copy/paste code from run-jsc-stress-tests to determine numberOfTests
2799 https://bugs.webkit.org/show_bug.cgi?id=141158
2801 Reviewed by Darin Adler.
2803 * Scripts/run-jsc-stress-tests:
2805 2015-02-02 Michael Catanzaro <mcatanzaro@igalia.com>
2807 [GTK] MiniBrowser should close itself on Ctrl+W or Ctrl+Q
2808 https://bugs.webkit.org/show_bug.cgi?id=141142
2810 Reviewed by Carlos Garcia Campos.
2812 * MiniBrowser/gtk/BrowserWindow.c:
2813 (browser_window_init): Quit on Ctrl+W or Ctrl+Q
2815 2015-02-01 Youenn Fablet <youenn.fablet@crf.canon.fr>
2817 Web platform test server is not always launching properly on Mac EWS bots
2818 https://bugs.webkit.org/show_bug.cgi?id=141141
2822 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2823 (create_wpt_empty_file_if_needed): Removed creation of empty __init.py__ files from AutoInstalled modules.
2825 2015-01-31 Sam Weinig <sam@webkit.org>
2827 Remove even more Mountain Lion support
2828 https://bugs.webkit.org/show_bug.cgi?id=141124
2830 Reviewed by Alexey Proskuryakov.
2832 * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2833 (AccessibilityUIElement::attributedStringRangeIsMisspelled):
2834 * DumpRenderTree/mac/Configurations/Base.xcconfig:
2835 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2836 * DumpRenderTree/mac/DumpRenderTree.mm:
2837 (activateTestingFonts):
2838 (prepareConsistentTestingEnvironment):
2839 * DumpRenderTree/mac/EventSendingController.mm:
2840 (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2841 (-[EventSendingController contextClick]):
2842 * DumpRenderTree/mac/TextInputController.m:
2843 * LayoutTestRelay/Configurations/Base.xcconfig:
2844 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2845 * MiniBrowser/Configurations/Base.xcconfig:
2846 * MiniBrowser/Configurations/DebugRelease.xcconfig:
2847 * MiniBrowser/mac/WK2BrowserWindowController.m:
2848 (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2849 (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2850 (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2851 * TestWebKitAPI/Configurations/Base.xcconfig:
2852 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2853 * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2854 (-[DownloadDelegate _downloadDidFinish:]):
2855 * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2856 (TestWebKitAPI::TEST):
2857 * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
2858 (TestWebKitAPI::InjectedBundleController::platformInitialize):
2859 * WebKitLauncher/Configurations/Base.xcconfig:
2860 * WebKitTestRunner/Configurations/Base.xcconfig:
2861 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2862 * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2863 (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
2864 * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2865 (WTR::activateFonts):
2866 * WebKitTestRunner/TestController.cpp:
2867 (WTR::TestController::initialize):
2868 (WTR::TestController::webProcessName):
2869 * WebKitTestRunner/mac/EventSenderProxy.mm:
2870 * asan/asan.xcconfig:
2872 2015-01-31 Commit Queue <commit-queue@webkit.org>
2874 Unreviewed, rolling out r179408.
2875 https://bugs.webkit.org/show_bug.cgi?id=141117
2877 This didn't fully fix the issue (Requested by anttik on
2882 "OSObjectPtr does not work with dispatch_data_t on Maverics"
2883 https://bugs.webkit.org/show_bug.cgi?id=141081
2884 http://trac.webkit.org/changeset/179408
2886 2015-01-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
2888 https://trac.webkit.org/changeset/179439 breaks a python test
2889 https://bugs.webkit.org/show_bug.cgi?id=141114
2893 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2894 (WebPlatformTestServer._install_modules): Checks whether WPTModules file exists before reading it as no such file exists in mock tests.
2896 2015-01-31 Youenn Fablet <youenn.fablet@crf.canon.fr>
2898 Import W3C web platform tests infrastructure
2899 https://bugs.webkit.org/show_bug.cgi?id=140934
2901 Reviewed by Ryosuke Niwa.
2903 Loading necessary web platform tests modules before launching server.
2904 Ensuring that some empty __init__.py files are present and create them if necessary.
2906 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:
2907 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2909 2015-01-30 Brent Fulgham <bfulgham@apple.com>
2911 [Win] Another unreviewed test fix.
2913 Correct copy/paste error in buildbot handling.
2915 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2916 (LayoutTestApacheHttpd.__init__):
2917 (LayoutTestApacheHttpd._get_apache_config_file_path):
2919 2015-01-30 Brent Fulgham <bfulgham@apple.com>
2921 [Win] Unreviewed test fix.
2923 Correct path handling based on failures on test bots to get things running again.
2925 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2926 (LayoutTestApacheHttpd.__init__):
2927 (LayoutTestApacheHttpd._get_apache_config_file_path):
2929 2015-01-30 Chris Dumez <cdumez@apple.com>
2931 Unreviewed. Fix Windows build after r179409.
2933 * DumpRenderTree/win/TestRunnerWin.cpp:
2934 (TestRunner::notifyDone):
2935 (TestRunner::queueLoad):
2937 2015-01-30 Chris Dumez <cdumez@apple.com>
2939 Rename shared() static member functions to singleton() for singleton classes.
2940 https://bugs.webkit.org/show_bug.cgi?id=141088
2942 Reviewed by Ryosuke Niwa and Benjamin Poulain.
2944 Rename shared() static member functions to singleton() for singleton
2945 classes as per the recent coding style change.
2947 2015-01-30 Antti Koivisto <antti@apple.com>
2949 OSObjectPtr does not work with dispatch_data_t on Maverics
2950 https://bugs.webkit.org/show_bug.cgi?id=141081
2952 Reviewed by Pratik Solanki.
2954 * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
2955 (TestWebKitAPI::TEST):
2957 2015-01-30 Brent Fulgham <bfulgham@apple.com>
2959 [Win] Switch to Apache on Windows
2960 https://bugs.webkit.org/show_bug.cgi?id=141060
2962 Reviewed by Alexey Proskuryakov.
2964 Update our scripts under Windows (and Cygwin) to locate and use
2965 the XAMPP installation of Apache for running tests.
2967 * Scripts/run-webkit-httpd:
2968 * Scripts/webkitperl/httpd.pm:
2970 (getDefaultConfigForTestDirectory):
2971 (getHTTPDConfigPathForTestDirectory):
2972 * Scripts/webkitpy/common/system/executive_unittest.py:
2973 (ExecutiveTest.serial_test_kill_process):
2974 * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2975 (LayoutTestApacheHttpd.__init__):
2976 (LayoutTestApacheHttpd._get_apache_config_file_path):
2977 (LayoutTestApacheHttpd._stop_running_server):
2978 * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2979 (HttpServerBase._is_server_running_on_all_ports):
2980 * Scripts/webkitpy/port/base.py:
2981 (Port._apache_config_file_name_for_platform):
2982 * Scripts/webkitpy/port/port_testcase.py:
2983 (test_apache_config_file_name_for_platform):
2984 * Scripts/webkitpy/port/win.py:
2985 (WinPort.show_results_html_file):
2986 (WinPort._uses_apache):
2988 (WinPort._path_to_apache):
2990 2015-01-29 Alexey Proskuryakov <ap@apple.com>
2992 Built result takes too long to be compressed on bots
2993 https://bugs.webkit.org/show_bug.cgi?id=141056
2995 Reviewed by Daniel Bates.
2997 Reduces compression time from ~3.5 min to ~1.5 min. Archive size gets 2% bigger.
2999 * BuildSlaveSupport/test-result-archive: (archiveTestResults):
3001 2015-01-29 Sam Weinig <sam@webkit.org>
3003 Remove support for screen font substitution
3004 https://bugs.webkit.org/show_bug.cgi?id=141038
3006 Reviewed by Tim Horton.
3008 * DumpRenderTree/win/DumpRenderTree.cpp:
3009 (resetWebPreferencesToConsistentValues):
3010 Remove call to now setScreenFontSubstitutionEnabled() which is a no-op.
3012 2015-01-29 Csaba Osztrogonác <ossy@webkit.org>
3014 Make run-jsc-stress-tests --remote work on Linux too
3015 https://bugs.webkit.org/show_bug.cgi?id=141000
3017 Reviewed by Darin Adler.
3019 * Scripts/jsc-stress-test-helpers/shell-runner.sh: Omit error message of sysctl,
3020 use bash/dash compatible signal names, use Linux/Mac compatible find options,
3021 use bash/dash compatible functions.
3022 * Scripts/run-jsc-stress-tests: Use Linux/Mac compatible find options.
3024 2015-01-29 Csaba Osztrogonác <ossy@webkit.org>
3026 [buildbot] Simplify jscore-test buildstep
3027 https://bugs.webkit.org/show_bug.cgi?id=140821
3029 Reviewed by Alexey Proskuryakov.
3031 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3032 (RunJavaScriptCoreTests): Inherited from TestWithFailureCount and removed useless actual.html logfile.
3033 (RunJavaScriptCoreTests.countFailures): Added.
3034 (RunJavaScriptCoreTests.commandComplete): Deleted.
3035 (RunJavaScriptCoreTests.evaluateCommand): Deleted.
3036 (RunJavaScriptCoreTests.getText): Deleted.
3037 (RunJavaScriptCoreTests.getText2): Deleted.
3038 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated.
3039 (RunJavaScriptCoreTestsTest.test_mozilla_failure_old_output):
3040 (RunJavaScriptCoreTestsTest.test_mozilla_failures_old_output):
3041 (RunJavaScriptCoreTestsTest.test_jsc_stress_failure_new_output):
3042 (RunJavaScriptCoreTestsTest.test_jsc_stress_failures_new_output):
3044 2015-01-29 Csaba Osztrogonác <ossy@webkit.org>
3046 Unreviewed, revert r179337, we don't need this dependency.
3048 * efl/install-dependencies:
3049 * gtk/install-dependencies:
3051 2015-01-28 Shivakumar JM <shiva.jm@samsung.com>
3053 Unreviewed. Moving myself to the committer section.
3055 * Scripts/webkitpy/common/config/contributors.json:
3057 2015-01-28 Csaba Osztrogonác <ossy@webkit.org>
3059 URTBF after r179326, added uuid-dev package as new dependency.
3061 * efl/install-dependencies:
3062 * gtk/install-dependencies:
3064 2015-01-28 Timothy Horton <timothy_horton@apple.com>
3066 Add a WebKitMessageRecorder DTrace provider, exposing IPC details to DTrace
3067 https://bugs.webkit.org/show_bug.cgi?id=140673
3069 Reviewed by Sam Weinig.
3071 * Scripts/dtrace/trace-webkit2-messages.d: Added.
3072 Add a DTrace script that outputs a small blob of JSON per message.
3074 2015-01-28 Geoffrey Garen <ggaren@apple.com>
3076 Removed fastMallocForbid / fastMallocAllow
3077 https://bugs.webkit.org/show_bug.cgi?id=141012
3079 Reviewed by Mark Hahnenberg.
3081 Fixed a test bug I noticed while testing.
3083 * DumpRenderTree/JavaScriptThreading.cpp:
3084 (stopJavaScriptThreads): Lock the javaScriptThreads lock before
3085 accessing javaScriptThreads -- otherwise, you'll ASSERT.
3087 2015-01-28 Dana Burkart <dburkart@apple.com>
3089 asan.xcconfig should use CLANG_ADDRESS_SANITIZER=YES instead of -fsanitize=address
3090 https://bugs.webkit.org/show_bug.cgi?id=141015
3092 Reviewed by Alexey Proskuryakov.
3094 * asan/asan.xcconfig:
3096 2015-01-28 Sam Weinig <sam@webkit.org>
3100 * Scripts/copy-webkitlibraries-to-product-directory:
3102 2015-01-28 Lucas Forschler <lforschler@apple.com>
3104 Increase the FileUpload block size in an attempt to improve network performance.
3106 Reviewed by Alexey Proskuryakov.
3108 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3109 (UploadBuiltProduct.__init__):
3111 2015-01-28 Dana Burkart <dburkart@apple.com>
3113 Move ASan flag settings from DebugRelease.xcconfig to Base.xcconfig
3114 https://bugs.webkit.org/show_bug.cgi?id=136765
3116 Reviewed by Alexey Proskuryakov.
3118 * DumpRenderTree/mac/Configurations/Base.xcconfig:
3119 * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3120 * LayoutTestRelay/Configurations/Base.xcconfig:
3121 * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
3122 * MiniBrowser/Configurations/Base.xcconfig:
3123 * MiniBrowser/Configurations/DebugRelease.xcconfig:
3124 * TestWebKitAPI/Configurations/Base.xcconfig:
3125 * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3126 * WebKitLauncher/Configurations/Base.xcconfig:
3127 * WebKitTestRunner/Configurations/Base.xcconfig:
3128 * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3130 2015-01-28 Joanmarie Diggs <jdiggs@igalia.com>
3132 AX: [ATK] Implement support for new AtkRole types for MathML
3133 https://bugs.webkit.org/show_bug.cgi?id=140916
3135 Reviewed by Chris Fleizach.
3137 * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Add mapping for new ATK roles
3138 * gtk/jhbuild.modules: Bump minimum version of ATK used by jhbuild to 2.15.4
3140 2015-01-28 Carlos Garcia Campos <cgarcia@igalia.com>
3142 [GTK] Stop removing color marks from unit tests output
3143 https://bugs.webkit.org/show_bug.cgi?id=140996
3145 Reviewed by Philippe Normand.
3147 Since r178236 google tests use a custom simplified output without
3148 any colors, so we don't need to handle the case of non ttys to
3149 remove the color marks.
3151 * Scripts/run-gtk-tests:
3152 (TestRunner.__init__):
3153 (TestRunner._run_test_command.parse_line):
3155 2015-01-28 Carlos Garcia Campos <cgarcia@igalia.com>
3157 [GTK] Unit test /webkit2/WebKitWebView/page-visibility from WebKit2Gtk/TestWebKitWebView fails
3158 https://bugs.webkit.org/show_bug.cgi?id=131731
3160 Reviewed by Žan Doberšek.
3162 A web page loaded offscreen is in prerender state not hidden.
3164 * Scripts/run-gtk-tests:
3165 (TestRunner): Unskip /webkit2/WebKitWebView/page-visibility.
3166 * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3167 (testWebViewPageVisibility):
3169 2015-01-27 Alexey Proskuryakov <ap@apple.com>
3171 Partially revert r178802.
3173 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png:
3174 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png:
3176 2015-01-27 Alexey Proskuryakov <ap@apple.com>
3178 build.webkit.org/dashboard asserts on some commits
3179 https://bugs.webkit.org/show_bug.cgi?id=140926
3181 Reviewed by Tim Horton.
3183 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3184 (Trac.prototype._convertCommitInfoElementToObject): Added a case for another root directory.
3186 2015-01-27 Alexey Proskuryakov <ap@apple.com>
3188 Make flakiness dashboard OS list actually match test_expectations.py
3189 https://bugs.webkit.org/show_bug.cgi?id=140969
3191 Reviewed by Ryosuke Niwa.
3193 * TestResultServer/static-dashboards/flakiness_dashboard.js:
3195 2015-01-27 Brent Fulgham <bfulgham@apple.com>
3197 [Win] WinLauncher crashes on eleventh site visited
3198 https://bugs.webkit.org/show_bug.cgi?id=140960
3200 Reviewed by Anders Carlsson.
3202 * WinLauncher/WinLauncher.cpp:
3203 (WinLauncher::showLastVisitedSites): Don't access off the end of
3206 2015-01-27 Alexey Proskuryakov <ap@apple.com>
3208 [Mac] Disable building Java applets by default
3209 https://bugs.webkit.org/show_bug.cgi?id=140957
3210 rdar://problem/19619529
3212 Reviewed by Anders Carlsson.
3214 It was actually already disabled unconditionally, by accident.
3216 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: (parse_args):
3217 * Scripts/webkitpy/port/mac.py:
3218 (MacPort._check_port_build):
3219 (MacPort._build_java_test_support):
3221 2015-01-27 Daniel Bates <dabates@apple.com>
3223 [iOS] run-webkit-tests --platform=ios* --lint-test-files does not work
3224 https://bugs.webkit.org/show_bug.cgi?id=140949
3226 Reviewed by Alexey Proskuryakov.
3228 Add "ios-simulator" and "ios-simulator-wk2" to the list of ports without
3229 builders so that run-webkit-tests can lint the appropriate TestExpectation
3232 * Scripts/webkitpy/port/builders.py:
3233 * Scripts/webkitpy/port/ios.py:
3234 (IOSSimulatorPort.__init__): Move logic to query for the Mac build directory from here...
3235 (IOSSimulatorPort.relay_path): to here as this is the only caller that makes use of that
3236 information to find the LayoutTestRelay tool. Otherwise, "self.assertEqual(len(calls), 1)"
3237 in unit test webkitpy.tool.commands.rebaseline_unittest.TestRebaselineExpectations.test_rebaseline_expectations
3238 will fail because IOSSimulatorPort.__init__() ultimately calls Tools/Scripts/webkit-build-directory
3239 to determine the Mac build directory for each instantiation of IOSSimulatorPort. And this unit
3240 test instantiates a port object for each builder listed in file Scripts/webkitpy/port/builders.py.
3243 2015-01-27 Alexey Proskuryakov <ap@apple.com>
3245 Update bots on the flakiness dashboard
3246 https://bugs.webkit.org/show_bug.cgi?id=140956
3248 Reviewed by Ryosuke Niwa.
3250 * TestResultServer/static-dashboards/builders.jsonp:
3251 * TestResultServer/static-dashboards/flakiness_dashboard.js:
3253 2015-01-27 Daniel Bates <dabates@apple.com>
3255 [iOS WK2] Add directory LayoutTests/platform/wk2 to the list of baseline search paths
3256 https://bugs.webkit.org/show_bug.cgi?id=140942
3258 Reviewed by Alexey Proskuryakov.
3260 The directory LayoutTests/platform/wk2 contains test expectations and test results that
3261 are applicable to all WebKit2 ports. We should make use of this information when
3262 running layout tests using iOS WebKit2.
3264 Additionally, make use of the convenience function Port._wk2_port_name() for the name
3265 of the WebKit2 port instead of directly using string concatenation.
3267 * Scripts/webkitpy/port/ios.py:
3268 (IOSSimulatorPort.default_baseline_search_path):
3270 2015-01-27 Csaba Osztrogonác <ossy@webkit.org>
3272 [Win] Disable FTL stress tests
3273 https://bugs.webkit.org/show_bug.cgi?id=140932
3275 Reviewed by Brent Fulgham.
3277 * Scripts/run-javascriptcore-tests:
3279 2015-01-27 Daniel Bates <dabates@apple.com>
3281 REGRESSION (r179130): Perl warns about subroutine redefinition when running configure-xcode-for-ios-development
3282 https://bugs.webkit.org/show_bug.cgi?id=140939
3284 Reviewed by Eric Carlson.
3286 Fixes the Perl warning: "Subroutine wanted redefined at Tools/Scripts/configure-xcode-for-ios-development line 106."
3288 * Scripts/webkitdirs.pm:
3289 (hasUserInstalledAppInSimulatorDevice): Pass a reference to an anonymous function instead
3290 of a named function to find() to avoid redefinition warnings in scripts that include webkitdirs.pm
3291 and define a function called wanted.
3293 2015-01-27 Daniel Bates <dabates@apple.com>
3295 Teach run-webkit-app --simulator how to install custom built app
3296 https://bugs.webkit.org/show_bug.cgi?id=140691
3298 Fix inadvertent omission of directory test flag in expression to check for the
3299 existence of the iOS simulator device-specific directory for user installed apps.
3301 * Scripts/webkitdirs.pm:
3302 (hasUserInstalledAppInSimulatorDevice):
3304 2015-01-26 Brent Fulgham <bfulgham@apple.com>
3306 [Win] ASSERTION FAILED !m_ptr under AccessibilityController::winAddNotificationListener
3307 https://bugs.webkit.org/show_bug.cgi?id=87426
3308 <rdar://problem/11527899>
3310 Reviewed by Darin Adler.
3312 Revise COMPtr to work better with our HashMap implementation. Use
3315 * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3316 (AccessibilityController::~AccessibilityController):
3317 (AccessibilityController::winNotificationReceived):
3318 * DumpRenderTree/win/DumpRenderTree.cpp:
3319 (dumpBackForwardListForAllWindows):
3321 2015-01-26 Csaba Osztrogonác <ossy@webkit.org>
3323 [Win] Enable JSC stress tests by default
3324 https://bugs.webkit.org/show_bug.cgi?id=128307
3326 Reviewed by Brent Fulgham.
3328 * Scripts/run-javascriptcore-tests:
3330 2015-01-26 Simon Fraser <simon.fraser@apple.com>
3332 [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in
3333 arguments for build and test scripts
3334 https://bugs.webkit.org/show_bug.cgi?id=139748
3336 Reviewed by Daniel Bates.
3338 There was much confusion resulting from the multitude of aliases used to build/test for
3339 the iOS simulator. Standardize on "--ios-simulator", which is also the name of the layout
3342 This fixes an issue where run-api-tests and some other scripts failed when run with
3345 * Scripts/build-webkit:
3346 * Scripts/package-root:
3348 * Scripts/webkitdirs.pm:
3349 (argumentsForConfiguration):
3350 (determineXcodeSDK):
3351 * Scripts/webkitpy/port/factory.py:
3354 2015-01-26 Simon Fraser <simon.fraser@apple.com>
3356 [iOS WK2] Fix possible crash when -[WKWebView evaluateJavaScript:completionHandler:] was called then the WKWebView is destroyed
3357 https://bugs.webkit.org/show_bug.cgi?id=140203
3358 rdar://problem/19198492
3360 Reviewed by Sam Weinig.
3362 * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3363 * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm: Added.
3366 2015-01-26 David Kilzer <ddkilzer@apple.com>
3368 Add iOS EWS to build.webkit.org/dashboard
3369 <http://webkit.org/b/140627>
3371 Reviewed by Alexey Proskuryakov.
3373 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice.png: Add.
3374 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOSDevice@2x.png: Add.
3375 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3376 (BubbleQueueServer): Add ios-ews queue info.
3377 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3378 Add iOS8Device platform.
3379 * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3380 (table.queue-grid tr.platform.ios-8 img.logo): Add CSS to draw
3383 2015-01-26 Filip Pizlo <fpizlo@apple.com>
3385 copy-webkitlibraries-to-product-directory's hack to build LLVM from source should be hardened for Xcode deciding it needs SDKROOT set
3386 https://bugs.webkit.org/show_bug.cgi?id=140896
3388 Reviewed by Michael Saboff.
3390 I've encountered some Xcode setups where you need to set SDKROOT to get llvm to build. This
3391 makes our script do this.
3393 Note that an alternative would be to run clang via "xcrun clang" rather than directly, but
3394 this would be harder given llvm's autoconf setup.
3396 * Scripts/copy-webkitlibraries-to-product-directory:
3398 2015-01-26 Alexey Proskuryakov <ap@apple.com>
3400 Update bot assignments.
3402 * BuildSlaveSupport/build.webkit.org-config/config.json:
3404 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
3406 Integrate WP python server into WebKit test framework
3407 https://bugs.webkit.org/show_bug.cgi?id=127094
3409 Reviewed by Ryosuke Niwa.
3411 This patch adds W3C web server (wptserver) as a new HTTP server.
3412 wptserver is used to serve all tests inside LayoutTests/imported/w3c/wpt.
3413 wptserver implementation should be imported within the import of the Web Platform Test suite (to ensure keeping server and tests in sync) in LayoutTests/imported/w3c/wpt.
3415 Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py serves as main entry point to wpt spawned process.
3416 Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py is responsible to start/stop the wpt server process.
3417 It also sets up the server config and testharness.js/testharnessreport.js files at start and stop of the wpt server.
3419 * Scripts/webkitpy/common/system/executive_mock.py:
3420 (MockProcess.communicate):
3421 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py: Adding start/stop of web platform test server according boolean parameter.
3422 (LayoutTestRunner.__init__):
3423 (LayoutTestRunner.run_tests):
3424 (LayoutTestRunner.start_servers):
3425 (LayoutTestRunner.stop_servers):
3426 * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py: Updated to check for wpt server start/stop.
3427 (LayoutTestRunnerTests._run_tests):
3428 (LayoutTestRunnerTests.test_servers_started.start_web_platform_test_server):
3429 (LayoutTestRunnerTests.test_servers_started.stop_web_platform_test_server):
3430 (LayoutTestRunnerTests):
3431 (LayoutTestRunnerTests.test_servers_started):
3432 * Scripts/webkitpy/layout_tests/controllers/manager.py: Updated to check whether a test is a wpt test and whether wpt server launch is needed.
3434 (Manager._is_http_test):
3435 (Manager._is_web_platform_test):
3436 (Manager._run_tests):
3437 * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3438 (ManagerTest.test_needs_servers.get_wpt_doc_root):
3439 (ManagerTest.test_needs_servers.get_manager):
3440 (ManagerTest.test_needs_servers):
3441 * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Added an option to control the doc_root of the wpt server.
3443 * Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py: Added.
3445 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py: Added.
3448 (WebPlatformTestServer):
3449 (WebPlatformTestServer.__init__):
3450 (WebPlatformTestServer._set_start_cmd):
3451 (WebPlatformTestServer._copy_webkit_test_files):
3452 (WebPlatformTestServer._clean_webkit_test_files):
3453 (WebPlatformTestServer._prepare_config):
3454 (WebPlatformTestServer._spawn_process):
3455 (WebPlatformTestServer._stop_running_server):
3456 * Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py: Added.
3457 (TestWebPlatformTestServer):
3458 (TestWebPlatformTestServer.test_start_cmd):
3459 * Scripts/webkitpy/port/base.py:
3461 (Port.to.start_web_platform_test_server):
3463 (Port.to.web_platform_test_server_doc_root):
3464 (Port.to.web_platform_test_server_base_url):
3465 (Port.to.stop_web_platform_test_server):
3466 * Scripts/webkitpy/port/driver.py: Updated the test name <-> test URL conversion routines.
3468 (Driver.is_web_platform_test):
3469 (Driver.test_to_uri):
3470 (Driver.uri_to_test):
3471 (Driver._command_from_driver_input):
3472 * Scripts/webkitpy/port/driver_unittest.py: Updated tests according new conversion rules.
3473 (DriverTest.test_test_to_uri):
3474 (DriverTest.test_uri_to_test):
3476 2015-01-26 Daniel Bates <dabates@apple.com>
3478 Teach run-webkit-app --simulator how to install custom built app
3479 https://bugs.webkit.org/show_bug.cgi?id=140691
3481 Reviewed by David Kilzer.
3483 We should teach run-webkit-app --simulator how to install a custom built app.
3485 Currently run-webkit-app --simulator can only run a system app or an app that
3486 was installed using the simctl command line tool. For convenience we should
3487 teach run-webkit-app --simulator how to install a custom built app.
3489 As a side effect of this change run-safari --simulator will install and run
3490 a custom built of MobileSafari (if it exists).
3492 * Scripts/webkitdirs.pm:
3493 (iOSSimulatorDevices): Added FIXME comment to decouple device representation in
3494 Perl from the structure of the device.plist file.
3495 (plistPathFromBundle): Fix if-statement condition so that we actually perform a
3496 file system check to determine the plist path for a Mac app bundle.
3497 (appIdentifierFromBundle): Pass absolute files system path to defaults(1). Otherwise,
3498 it will complain that it cannot find the file: "Domain ... does not exist".
3499 (appDisplayNameFromBundle): Ditto.
3500 (waitUntilIOSSimulatorDeviceIsInState): Added; helper function that does not return
3501 until a simulator device is the specified state.
3502 (relaunchIOSSimulator): Renamed; formerly named openIOSSimulator. Quits iOS Simulator
3503 (if it's open) before opening it again so as to ensure that the iOS Simulator boots
3504 the specified device.
3505 (quitIOSSimulator): Added optional parameter, $waitForShutdownOfSimulatedDeviceUDID.
3506 As implied by its name, this function will not return until the specified simulator
3507 device UDID is in the shutdown state.
3508 (iosSimulatorDeviceByUDID): Added; returns the device dictionary object for the simulator
3509 device with the specified UDID.
3510 (isIOSSimulatorSystemInstalledApp): Resolve symbolic links in iosSimulatorApplicationsPath()
3511 before using it as part of a prefix match to avoid a mismatch. In the public iOS 8.1 SDK the
3512 return value of iosSimulatorApplicationsPath(), which returns a result analogous to the shell
3513 expression echo `xcrun --sdk iphonesimulator --show-sdk-path`/Applications/, contains a
3514 symbolic link. Specifically, echo `xcrun --sdk iphonesimulator --show-sdk-path` returns
3515 /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator8.1.sdk,
3516 which is a symbolic link to /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator.sdk.
3517 (hasUserInstalledAppInSimulatorDevice): Added.
3518 (isSimulatorDeviceBooted): Added; returns whether the specified simulator device is in the
3520 (runIOSWebKitAppInSimulator): Modified to install a custom built app (if needed). For now,
3521 switching between a system installed app and a custom built version of the same app (e.g.
3522 custom build of MobileSafari) will erase all contents and settings in the simulator device.
3523 (eraseIOSSimulatorDevice): Deleted; inline implementation into runIOSWebKitAppInSimulator()
3524 as that was the only caller of this function.
3525 (bootedIOSSimulatorDevice): Deleted.
3526 (openIOSSimulator): Deleted.
3528 2015-01-26 Alexey Proskuryakov <ap@apple.com>
3530 Update bot assignments.
3532 * BuildSlaveSupport/build.webkit.org-config/config.json:
3534 2015-01-26 Alexey Proskuryakov <ap@apple.com>
3536 Leaks bot shouldn't run JSC tests
3537 https://bugs.webkit.org/show_bug.cgi?id=140877
3539 Reviewed by Darin Adler.
3541 Shaves off 48 minutes of time.
3543 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3544 (TestLeaksFactory): Slim down the leaks queue.
3546 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3547 * Scripts/webkitpy/port/ios.py:
3548 (IOSSimulatorPort.print_leaks_summary):
3549 * Scripts/webkitpy/port/mac.py:
3550 (MacPort.print_leaks_summary):
3551 Don't yell when leaks are detected.
3553 2015-01-26 Csaba Osztrogonác <ossy@webkit.org>
3555 Refactor run-javascriptcore-tests
3556 https://bugs.webkit.org/show_bug.cgi?id=140824
3558 Reviewed by Darin Adler.
3560 Separated mozilla, stress test code paths and
3561 determining skipped mozilla tests into subroutines.
3563 * Scripts/run-javascriptcore-tests:
3565 (runJSCStressTests):
3566 (defaultJsDriverArgsForMozillaTests):
3568 2015-01-26 Csaba Osztrogonác <ossy@webkit.org>
3570 [buildbot] Fix grammar of TestWithFailureCount
3571 https://bugs.webkit.org/show_bug.cgi?id=140884
3573 Reviewed by Alexey Proskuryakov.
3575 * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3576 (TestWithFailureCount):
3577 (TestWithFailureCount.commandComplete):
3578 (TestWithFailureCount.getText2):
3582 (RunLLINTCLoopTests):
3584 * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3585 (RunLLINTCLoopTestsTest.test_failure):
3586 (Run32bitJSCTestsTest.test_failure):
3587 (RunUnitTestsTest.assertFailures):
3589 2015-01-26 Youenn Fablet <youenn.fablet@crf.canon.fr>
3591 Unreviewed. Moving myself to the committer section.
3593 * Scripts/webkitpy/common/config/contributors.json:
3595 2015-01-26 Michael Catanzaro <mcatanzaro@igalia.com> and Carlos Garcia Campos <cgarcia@igalia.com>
3597 [GTK] gtkdoc does not appear in DevHelp
3598 https://bugs.webkit.org/show_bug.cgi?id=139369
3600 Reviewed by Philippe Normand.
3602 * gtk/generate-gtkdoc: Create the generators in the main function
3603 and use them to get the local cross renference dependencies. Also
3604 pass the generator module name to webkitdom.write_doc_files().
3605 (get_gtkdoc_module_paths): Receive a list of local cross reference
3607 (get_generator_for_config): Set the main_sgml_file property of the
3608 GtkDoc object from the configuration file.
3609 (generate_documentation): Generate the documentation for the given
3611 (generate_documentation_for_config): Deleted.
3612 * gtk/manifest.txt.in: Expect the API version in the gtkdoc filenames.
3614 (write_doc_files): Receive the module name used to build the
3615 -sections.txt filename.
3617 2015-01-26 Commit Queue <commit-queue@webkit.org>
3619 Unreviewed, rolling out r179107.
3620 https://bugs.webkit.org/show_bug.cgi?id=140880
3622 The GCC in the bots doesn't support the AsyncTask
3623 implementation (Requested by KaL on #webkit).
3627 "[GTK] Enable IndexedDB"
3628 https://bugs.webkit.org/show_bug.cgi?id=98932
3629 http://trac.webkit.org/changeset/179107
3631 2015-01-26 Csaba Osztrogonác <ossy@webkit.org>
3633 [EFL] Bump libseccomp version to 2.1.1
3634 https://bugs.webkit.org/show_bug.cgi?id=140357
3636 Reviewed by Gyuyoung Kim.
3638 * efl/jhbuild.modules: