[Flatpak] Add support for flatpak > 1.1.2
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
2
3         [Flatpak] Add support for flatpak > 1.1.2
4         https://bugs.webkit.org/show_bug.cgi?id=194088
5
6         Flatpak 1.2 is now out so we need to support that
7         version now.
8
9         Reviewed by Michael Catanzaro.
10
11         * flatpak/flatpakutils.py:
12         (check_flatpak):
13         (FlatpakPackages.__init__):
14         (FlatpakPackages.__detect_packages):
15         (FlatpakPackages.__detect_packages.in):
16         (FlatpakRepos.update):
17
18 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
19
20         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
21         https://bugs.webkit.org/show_bug.cgi?id=194998
22
23         Reviewed by Carlos Garcia Campos.
24
25         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
26         to a Git checkout and using the latest commit containing various fixes
27         and improvements.
28
29 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
30
31         [WPE][GTK] Remove user agent quirk for washingtonpost.com
32         https://bugs.webkit.org/show_bug.cgi?id=194981
33
34         Reviewed by Žan Doberšek.
35
36         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
37         (TestWebKitAPI::TEST):
38
39 2019-02-23  Keith Miller  <keith_miller@apple.com>
40
41         Add new mac target numbers
42         https://bugs.webkit.org/show_bug.cgi?id=194955
43
44         Reviewed by Tim Horton.
45
46         * DumpRenderTree/mac/Configurations/Base.xcconfig:
47         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
48         * MiniBrowser/Configurations/Base.xcconfig:
49         * TestWebKitAPI/Configurations/Base.xcconfig:
50         * WebKitTestRunner/Configurations/Base.xcconfig:
51
52 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
53
54         [WinCairo] Enable wk1/wk2 suffix for platform search path.
55         https://bugs.webkit.org/show_bug.cgi?id=194846
56
57         Reviewed by Don Olmstead.
58
59         Added _search_paths() and _port_specific_expectations_files() for
60         WinCairoPort.
61
62         * Scripts/webkitpy/port/win.py:
63         (WinCairoPort.default_baseline_search_path):
64         (WinCairoPort):
65         (WinCairoPort._port_specific_expectations_files):
66         (WinCairoPort._search_paths):
67
68 2019-02-22  Tim Horton  <timothy_horton@apple.com>
69
70         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
71         https://bugs.webkit.org/show_bug.cgi?id=194963
72
73         Reviewed by Dean Jackson.
74
75         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
76         Do a `contains` check instead of `equals`, because in debug builds we
77         put the GraphicsLayer pointer in a prefix.
78
79 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
80
81         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
82         https://bugs.webkit.org/show_bug.cgi?id=194873
83         <rdar://problem/46701974>
84
85         Reviewed by Tim Horton.
86
87         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
88
89         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
90         (WTR::UIScriptController::menuRect const):
91         (WTR::UIScriptController::isShowingMenu const):
92         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
93         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
94         (WTR::UIScriptController::menuRect const):
95
96         Add a function to query the bounds of the callout menu in content coordinates.
97
98         (WTR::UIScriptController::isShowingMenu const):
99
100         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
101
102         * TestRunnerShared/UIScriptContext/UIScriptController.h:
103         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
104         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
105         (WTR::UIScriptController::rectForMenuAction const):
106         (WTR::UIScriptController::menuRect const):
107         (WTR::UIScriptController::isShowingMenu const):
108         (WTR::findViewInHierarchyOfType): Deleted.
109
110 2019-02-22  Chris Dumez  <cdumez@apple.com>
111
112         Regression(PSON) Unable to preview password-protected documents on iCloud.com
113         https://bugs.webkit.org/show_bug.cgi?id=194954
114         <rdar://problem/48127957>
115
116         Reviewed by Alex Christensen.
117
118         Add API test coverage.
119
120         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
121         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
122         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
123         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
124
125 2019-02-22  Chris Dumez  <cdumez@apple.com>
126
127         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
128         https://bugs.webkit.org/show_bug.cgi?id=194924
129         <rdar://problem/48216125>
130
131         Reviewed by Geoffrey Garen.
132
133         Add API test coverage.
134
135         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
136
137 2019-02-22  Chris Dumez  <cdumez@apple.com>
138
139         Unreviewed, disable API test added in r241928 on iOS.
140
141         The cache is not enabled on devices with less than 3GB of RAM.
142
143         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
144
145 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
146
147         Hardcode Visual Viewports on everywhere except iOS WK1
148         https://bugs.webkit.org/show_bug.cgi?id=194928
149
150         Reviewed by Zalan Bujtas.
151
152         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
153         change the default value of the Setting to 'true', and hardcode WebView on iOS to
154         set it to false. The setting has shipped for several years and there's no need to turn
155         it off now.
156
157         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
158         Visual Viewports are not enabled.
159         
160         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
161         that only runs in WK2
162
163         * MiniBrowser/mac/SettingsController.h:
164         * MiniBrowser/mac/SettingsController.m:
165         (-[SettingsController init]):
166         (-[SettingsController _populateMenu]):
167         (-[SettingsController validateMenuItem:]):
168         (-[SettingsController visualViewportEnabled]): Deleted.
169         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
170         * MiniBrowser/mac/WK1BrowserWindowController.m:
171         (-[WK1BrowserWindowController didChangeSettings]):
172         * MiniBrowser/mac/WK2BrowserWindowController.m:
173         (-[WK2BrowserWindowController didChangeSettings]):
174
175 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
176
177         Discard cached processes when clearing website data store
178         https://bugs.webkit.org/show_bug.cgi?id=194894
179
180         Reviewed by Chris Dumez.
181
182         Added a test case.
183
184         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
185         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
186
187 2019-02-21  Alex Christensen  <achristensen@webkit.org>
188
189         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
190         https://bugs.webkit.org/show_bug.cgi?id=194914
191         <rdar://problem/47586889>
192
193         Reviewed by Geoffrey Garen.
194
195         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
196         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
197         (TEST):
198         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
199
200 2019-02-21  David Kilzer  <ddkilzer@apple.com>
201
202         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
203         <https://webkit.org/b/194761>
204
205         Reviewed by Myles Maxfield.
206
207         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
208         (WTR::activateSystemCoreWebFonts): Log `error` to console if
209         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
210         to use ARC-compliant cast.
211         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
212         ARC-compliant cast.
213         (WTR::installFakeHelvetica): Log `error` to console if
214         CTFontManagerRegisterFontsForURL() fails, but only on supported
215         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
216         Call CFRelease() on `error` to fix the leak.  Update to use
217         ARC-compliant cast.
218         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
219         cast.
220
221 2019-02-21  Chris Dumez  <cdumez@apple.com>
222
223         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
224         https://bugs.webkit.org/show_bug.cgi?id=194481
225
226         Reviewed by Alex Christensen.
227
228         Give the processes a chance to shutdown and wait until we reached the expected number
229         of processes.
230
231         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
232
233 2019-02-21  Tim Horton  <timothy_horton@apple.com>
234
235         Fix the macOS build
236
237         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
238
239 2019-02-21  Tim Horton  <timothy_horton@apple.com>
240
241         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
242
243         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
244         I am a backwards.
245
246 2019-02-21  Tim Horton  <timothy_horton@apple.com>
247
248         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
249
250         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
251         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
252         We could force on UI-side compositing, but I feel like the test might be more
253         valuable exercising the normal path on each platform (though the original
254         bug was also UI-side specific). Though we can't validate that the overlay
255         layer was installed successfully, there are layout tests that do that.
256
257 2019-02-21  Tim Horton  <timothy_horton@apple.com>
258
259         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
260         https://bugs.webkit.org/show_bug.cgi?id=194845
261         <rdar://problem/47944579>
262
263         Reviewed by Antti Koivisto.
264
265         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
266         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
267
268 2019-02-21  Zalan Bujtas  <zalan@apple.com>
269
270         [LFC][Floats] Add support for placing formatting roots in-between floats.
271         https://bugs.webkit.org/show_bug.cgi?id=194902
272
273         Reviewed by Antti Koivisto.
274
275         * LayoutReloaded/misc/LFC-passing-tests.txt:
276
277 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
278
279         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
280         https://bugs.webkit.org/show_bug.cgi?id=194901
281
282         Unreviewed build fix.
283
284         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
285         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
286         WPEBackend-fdo-0.1 as library name.
287
288 2019-02-21  Rob Buis  <rbuis@igalia.com>
289
290         Update MIME type parser
291         https://bugs.webkit.org/show_bug.cgi?id=180526
292
293         Reviewed by Darin Adler.
294
295         Add tests involving leading and trailing whitespace, non-token
296         characters and quoted strings.
297
298         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
299         (TestWebKitAPI::TEST):
300
301 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
302
303         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
304         https://bugs.webkit.org/show_bug.cgi?id=194884
305
306         Reviewed by Michael Catanzaro.
307
308         * PlatformWin.cmake:
309
310 2019-02-20  Chris Dumez  <cdumez@apple.com>
311
312         Add API test for <rdar://problem/47471222>
313         https://bugs.webkit.org/show_bug.cgi?id=194847
314
315         Reviewed by Alex Christensen.
316
317         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
318
319 2019-02-20  Chris Dumez  <cdumez@apple.com>
320
321         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
322         https://bugs.webkit.org/show_bug.cgi?id=194872
323         <rdar://problem/47924500>
324
325         Reviewed by Alex Christensen.
326
327         Add API test coverage.
328
329         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
330
331 2019-02-20  Jer Noble  <jer.noble@apple.com>
332
333         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
334         https://bugs.webkit.org/show_bug.cgi?id=191332
335
336         Reviewed by Dean Jackson.
337
338         * Scripts/git-is-in-range: Added.
339
340 2019-02-20  Andy Estes  <aestes@apple.com>
341
342         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
343         https://bugs.webkit.org/show_bug.cgi?id=194869
344
345         Rubber-stamped by Jer Noble.
346
347         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
348         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
349         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
350         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
351         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
352         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
353
354 2019-02-20  Chris Dumez  <cdumez@apple.com>
355
356         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
357         https://bugs.webkit.org/show_bug.cgi?id=194857
358         <rdar://problem/47759323>
359
360         Reviewed by Alex Christensen.
361
362         Add API test coverage.
363
364         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
365
366 2019-02-20  Chris Dumez  <cdumez@apple.com>
367
368         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
369         https://bugs.webkit.org/show_bug.cgi?id=194829
370         <rdar://problem/47889906>
371
372         Reviewed by Alexey Proskuryakov.
373
374         Every time the TestOptions were changing we were creating both a new Web view and
375         a new WKContext, which would start a new Network process. In most cases, we only
376         need to contruct a new Web view and we do can keep reusing the same WKContext.
377         This patch implements this optimization and thus avoids spinning a lot of new
378         Network processes while running the layout tests.
379
380         * WebKitTestRunner/TestController.cpp:
381         (WTR::TestController::generateContextConfiguration const):
382         (WTR::TestController::generatePageConfiguration):
383         (WTR::TestController::createWebViewWithOptions):
384         (WTR::TestController::resetPreferencesToConsistentValues):
385         (WTR::updateTestOptionsFromTestHeader):
386         * WebKitTestRunner/TestController.h:
387         * WebKitTestRunner/TestOptions.h:
388         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
389         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
390         (WTR::TestOptions::hasSameInitializationOptions const):
391         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
392         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
393         (WTR::TestController::platformAddTestOptions const):
394
395 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
396
397         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
398         https://bugs.webkit.org/show_bug.cgi?id=167941
399
400         Reviewed by Carlos Garcia Campos.
401
402         * MiniBrowser/gtk/main.c:
403         (filterSavedCallback): Added.
404         (main): Support loading a JSON rule set file for content filtering.
405         * MiniBrowser/wpe/main.cpp:
406         (filterSavedCallback): Added.
407         (main): Support loading a JSON rule set file for content filtering.
408         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
409         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
410         (WTF::derefGPtr): Ditto.
411         (testEmptyStore):
412         (testSaveInvalidFilter):
413         (testSaveLoadFilter):
414         (testSavedFilterIdentifierMatch):
415         (testRemoveFilter):
416         (testSaveMultipleFilters):
417         (testSaveFilterFromFile):
418         (testFilterPersistence):
419         (beforeAll):
420         (afterAll):
421         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
422         (removeOldInjectedContentAndResetLists): Also reset content filters.
423         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
424         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
425         the element affected by the style sheet.
426         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
427         and returns it to be used by tests.
428         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
429         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
430         (serverCallback): Add support for serving a CSS style sheet for testing.
431         (beforeAll): Add call to testUserContentManagerContentFilter().
432         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
433
434 2019-02-19  Keith Rollin  <krollin@apple.com>
435
436         Add timing information to build output
437         https://bugs.webkit.org/show_bug.cgi?id=194839
438         <rdar://problem/48219609>
439
440         Reviewed by Alexey Proskuryakov.
441
442         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
443         emit each project's build time to its output. E.g.,
444
445             ** BUILD SUCCEEDED ** [0.132 sec]
446
447         * Scripts/webkitdirs.pm:
448         (XcodeOptions):
449
450 2019-02-19  Truitt Savell  <tsavell@apple.com>
451
452         Unreviewed, rolling out r241784.
453
454         Broke all OpenSource builds.
455
456         Reverted changeset:
457
458         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
459         instances view"
460         https://bugs.webkit.org/show_bug.cgi?id=172848
461         https://trac.webkit.org/changeset/241784
462
463 2019-02-19  Zalan Bujtas  <zalan@apple.com>
464
465         [LFC][Floats] Remove redundant intersecting logic
466         https://bugs.webkit.org/show_bug.cgi?id=194804
467
468         Reviewed by Antti Koivisto.
469
470         * LayoutReloaded/misc/LFC-passing-tests.txt:
471
472 2019-02-19  Dean Jackson  <dino@apple.com>
473
474         Clean-up output from generate-xcfilelists so it can be filtered
475         https://bugs.webkit.org/show_bug.cgi?id=194795
476
477         Reviewed by Joseph Pecoraro (and Keith Rollin).
478
479         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
480         make a slight tweak to filter-build-webkit so such lines are marked
481         as plain.
482
483         * Scripts/filter-build-webkit:
484         * Scripts/generate-xcfilelists:
485
486 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
487
488         pytest is not correctly auto-installed
489         https://bugs.webkit.org/show_bug.cgi?id=194707
490
491         Reviewed by Carlos Garcia Campos.
492
493         * Scripts/webkitpy/thirdparty/__init__.py:
494         (AutoinstallImportHook._install_pytest):
495
496 2019-02-18  Chris Dumez  <cdumez@apple.com>
497
498         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
499         https://bugs.webkit.org/show_bug.cgi?id=194797
500         <rdar://problem/48055151>
501
502         Reviewed by Geoffrey Garen.
503
504         Add API test coverage.
505
506         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
507
508 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
509
510         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
511         https://bugs.webkit.org/show_bug.cgi?id=194670
512         <rdar://problem/39066529>
513
514         Reviewed by Tim Horton.
515
516         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
517         pasted in an editable area as attachment elements.
518
519         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
520         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
521         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
522         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
523         (TestWebKitAPI::TEST):
524         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
525         (WTR::InjectedBundlePage::InjectedBundlePage):
526
527 2019-02-18  Alex Christensen  <achristensen@webkit.org>
528
529         Fix API test after r241728
530        ​https://bugs.webkit.org/show_bug.cgi?id=194723
531
532         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
533         (TEST):
534         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
535
536 2019-02-18  Daniel Bates  <dabates@apple.com>
537
538         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
539         https://bugs.webkit.org/show_bug.cgi?id=192824
540         <rdar://problem/47100332>
541
542         Reviewed by Wenson Hsieh.
543
544         Fix a bug where the wrong usage code was used for F13 thru F24.
545
546         * WebKitTestRunner/ios/HIDEventGenerator.mm:
547         (keyCodeForDOMFunctionKey):
548
549 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
550
551         Bytecode cache should a have a boot-specific validation
552         https://bugs.webkit.org/show_bug.cgi?id=194769
553         <rdar://problem/48149509>
554
555         Reviewed by Keith Miller.
556
557         Add test for WTF::bootSessionUUIDString()
558
559         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
560         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
561         (TEST):
562
563 2019-02-18  Alex Christensen  <achristensen@webkit.org>
564
565         Disable safe browsing in WKWebView and remove its WKPreferences API
566         https://bugs.webkit.org/show_bug.cgi?id=194723
567         <rdar://problem/48122993>
568
569         Reviewed by Geoffrey Garen.
570
571         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
572         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
573         (TEST):
574         (safeBrowsingView):
575         Make tests use SPI instead of API.
576
577 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
578
579         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
580         https://bugs.webkit.org/show_bug.cgi?id=194586
581
582         Reviewed by Ross Kirsling.
583
584         * DumpRenderTree/win/DumpRenderTree.cpp:
585         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
586         * Scripts/webkitpy/port/driver.py:
587         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
588
589 2019-02-17  David Kilzer  <ddkilzer@apple.com>
590
591         Unreviewed, rolling out r241620.
592
593         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
594         (Requested by ddkilzer on #webkit.)
595
596         Reverted changeset:
597
598         "[WTF] Add environment variable helpers"
599         https://bugs.webkit.org/show_bug.cgi?id=192405
600         https://trac.webkit.org/changeset/241620
601
602 2019-02-16  Zalan Bujtas  <zalan@apple.com>
603
604         [LFC] RenderImage's default intrinsic size is 0.
605         https://bugs.webkit.org/show_bug.cgi?id=194745
606
607         Reviewed by Antti Koivisto.
608
609         * LayoutReloaded/misc/LFC-passing-tests.txt:
610
611 2019-02-16  Zalan Bujtas  <zalan@apple.com>
612
613         [LFC][BFC] Add support for block replaced intrinsic width.
614         https://bugs.webkit.org/show_bug.cgi?id=194705
615
616         Reviewed by Simon Fraser.
617
618         * LayoutReloaded/misc/LFC-passing-tests.txt:
619
620 2019-02-16  Zalan Bujtas  <zalan@apple.com>
621
622         [LFC] Apply min/max width constraints to preferred width computation
623         https://bugs.webkit.org/show_bug.cgi?id=194739
624
625         Reviewed by Simon Fraser.
626
627         * LayoutReloaded/misc/LFC-passing-tests.txt:
628
629 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
630
631         [WTF] Add environment variable helpers
632         https://bugs.webkit.org/show_bug.cgi?id=192405
633
634         Reviewed by Michael Catanzaro.
635
636         * DumpRenderTree/mac/DumpRenderTree.mm:
637         (libraryPathForDumpRenderTree):
638         * DumpRenderTree/win/DumpRenderTree.cpp:
639         (libraryPathForDumpRenderTree):
640         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
641         (setUpIOSLayoutTestCommunication):
642         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
643         (beforeAll):
644         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
645         (main):
646         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
647         (WebKitTestBus::run):
648         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
649         (WTR::getOutputDir):
650         (WTR::initializeFontConfigSetting):
651         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
652         (WTR::InjectedBundle::platformInitialize):
653         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
654         (WTR::topLevelPath):
655         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
656         (WTR::topLevelPath):
657         (WTR::getOutputDir):
658         (WTR::activateFonts):
659         * WebKitTestRunner/TestController.cpp:
660         (WTR::TestController::libraryPathForTesting):
661         (WTR::TestController::generateContextConfiguration const):
662         (WTR::TestController::generatePageConfiguration):
663         (WTR::TestController::decideDestinationWithSuggestedFilename):
664         (WTR::TestController::platformAdjustContext):
665         * WebKitTestRunner/TestController.h:
666         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
667         (WTR::TestController::cocoaPlatformInitialize):
668         (WTR::TestController::platformAdjustContext):
669         * WebKitTestRunner/gtk/main.cpp:
670         (main):
671         * WebKitTestRunner/mac/TestControllerMac.mm:
672         (WTR::TestController::configureContentExtensionForTest):
673         * WebKitTestRunner/wpe/main.cpp:
674         (main):
675         Utilize WTF::Environment where possible.
676
677 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
678
679         [iOS] WKWebView callout bar is missing Change Writing Direction item
680         https://bugs.webkit.org/show_bug.cgi?id=190015
681         <rdar://problem/44810366>
682
683         Reviewed by Tim Horton.
684
685         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
686         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
687
688         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
689         (TestWebKitAPI::TEST):
690
691 2019-02-15  Chris Dumez  <cdumez@apple.com>
692
693         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
694         https://bugs.webkit.org/show_bug.cgi?id=194717
695         <rdar://problem/47884404>
696
697         Reviewed by Brady Eidson.
698
699         Add API test coverage.
700
701         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
702
703 2019-02-15  Youenn Fablet  <youenn@apple.com>
704
705         Make navigator.mediaDevices SecureContext
706         https://bugs.webkit.org/show_bug.cgi?id=194666
707
708         Reviewed by Eric Carlson.
709
710         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
711         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
712         (TEST_F):
713
714 2019-02-15  Brian Burg  <bburg@apple.com>
715
716         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
717         https://bugs.webkit.org/show_bug.cgi?id=194411
718         <rdar://problem/47787614>
719
720         Reviewed by Joseph Pecoraro.
721
722         Remove unnecessary soft linking macro usage.
723
724         * DumpRenderTree/mac/TestRunnerMac.mm:
725         (TestRunner::inspectorTestStubURL):
726         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
727         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
728         (WTR::TestRunner::inspectorTestStubURL):
729
730 2019-02-15  Commit Queue  <commit-queue@webkit.org>
731
732         Unreviewed, rolling out r241559 and r241566.
733         https://bugs.webkit.org/show_bug.cgi?id=194710
734
735         Causes layout test crashes under GuardMalloc (Requested by
736         ryanhaddad on #webkit).
737
738         Reverted changesets:
739
740         "[WTF] Add environment variable helpers"
741         https://bugs.webkit.org/show_bug.cgi?id=192405
742         https://trac.webkit.org/changeset/241559
743
744         "Unreviewed build fix for WinCairo Debug after r241559."
745         https://trac.webkit.org/changeset/241566
746
747 2019-02-15  Zalan Bujtas  <zalan@apple.com>
748
749         [LFC] Out-of-flow box is never a float box
750         https://bugs.webkit.org/show_bug.cgi?id=194704
751
752         Reviewed by Antti Koivisto.
753
754         * LayoutReloaded/misc/LFC-passing-tests.txt:
755
756 2019-02-10  Darin Adler  <darin@apple.com>
757
758         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
759         https://bugs.webkit.org/show_bug.cgi?id=194487
760
761         Reviewed by Daniel Bates.
762
763         * DumpRenderTree/win/DumpRenderTree.cpp:
764         (applicationId): Use makeString instead of String::format.
765         (main): Ditto.
766         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
767         (TestWebKitAPI::Util::createURLForResource): Ditto.
768         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
769         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
770
771         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
772         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
773         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
774         (WTR::createStringWithAttributes): Use appendLiteral.
775         (WTR::AccessibilityUIElement::helpText const): Ditto.
776         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
777         directly instead of using String::format.
778         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
779         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
780
781 2019-02-15  Truitt Savell  <tsavell@apple.com>
782
783         Unreviewed, rolling out r241564.
784
785         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
786
787         Reverted changeset:
788
789         "[Mac] WebInspectorUI.framework does not need to be soft-
790         linked anymore"
791         https://bugs.webkit.org/show_bug.cgi?id=194411
792         https://trac.webkit.org/changeset/241564
793
794 2019-02-15  Saam barati  <sbarati@apple.com>
795
796         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
797         https://bugs.webkit.org/show_bug.cgi?id=194036
798
799         Reviewed by Yusuke Suzuki.
800
801         * Scripts/run-jsc-stress-tests:
802
803 2019-02-14  Tim Horton  <timothy_horton@apple.com>
804
805         Fix the build.
806
807         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
808         (WTR::UIScriptController::drawSquareInEditableImage):
809         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
810         (TestWebKitAPI::drawSquareInEditableImage):
811
812 2019-02-14  Tim Horton  <timothy_horton@apple.com>
813
814         Fix the build.
815
816         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
817         (WTR::UIScriptController::drawSquareInEditableImage):
818         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
819         (TestWebKitAPI::drawSquareInEditableImage):
820
821 2019-02-14  Brian Burg  <bburg@apple.com>
822
823         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
824         https://bugs.webkit.org/show_bug.cgi?id=194411
825         <rdar://problem/47787614>
826
827         Reviewed by Joseph Pecoraro.
828
829         Remove unnecessary soft linking macro usage.
830
831         * DumpRenderTree/mac/TestRunnerMac.mm:
832         (TestRunner::inspectorTestStubURL):
833         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
834         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
835         (WTR::TestRunner::inspectorTestStubURL):
836
837 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
838
839         [ews-app] status bubble should fetch builder name info from BuilderMapping table
840         https://bugs.webkit.org/show_bug.cgi?id=194599
841
842         Reviewed by Lucas Forschler.
843
844         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
845         (StatusBubble._build_bubble):
846
847 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
848
849         [ews-app] Set Foreign Key in Django build model
850         https://bugs.webkit.org/show_bug.cgi?id=194667
851
852         Reviewed by Lucas Forschler.
853
854         * BuildSlaveSupport/ews-app/ews/models/build.py:
855         (Build):
856
857 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
858
859         [WTF] Add environment variable helpers
860         https://bugs.webkit.org/show_bug.cgi?id=192405
861
862         Reviewed by Michael Catanzaro.
863
864         * DumpRenderTree/mac/DumpRenderTree.mm:
865         (libraryPathForDumpRenderTree):
866         * DumpRenderTree/win/DumpRenderTree.cpp:
867         (libraryPathForDumpRenderTree):
868         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
869         (setUpIOSLayoutTestCommunication):
870         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
871         (TestWebKitAPI::strip):
872         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
873         (beforeAll):
874         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
875         (main):
876         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
877         (WebKitTestBus::run):
878         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
879         (WTR::getOutputDir):
880         (WTR::initializeFontConfigSetting):
881         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
882         (WTR::InjectedBundle::platformInitialize):
883         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
884         (WTR::topLevelPath):
885         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
886         (WTR::topLevelPath):
887         (WTR::getOutputDir):
888         (WTR::activateFonts):
889         * WebKitTestRunner/TestController.cpp:
890         (WTR::TestController::libraryPathForTesting):
891         (WTR::TestController::generateContextConfiguration const):
892         (WTR::TestController::generatePageConfiguration):
893         (WTR::TestController::decideDestinationWithSuggestedFilename):
894         (WTR::TestController::platformAdjustContext):
895         * WebKitTestRunner/TestController.h:
896         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
897         (WTR::TestController::cocoaPlatformInitialize):
898         (WTR::TestController::platformAdjustContext):
899         * WebKitTestRunner/gtk/main.cpp:
900         (main):
901         * WebKitTestRunner/mac/TestControllerMac.mm:
902         (WTR::TestController::configureContentExtensionForTest):
903         * WebKitTestRunner/wpe/main.cpp:
904         (main):
905         Utilize WTF::Environment where possible.
906
907 2019-02-14  Chris Dumez  <cdumez@apple.com>
908
909         [PSON] Introduce a WebContent Process cache
910         https://bugs.webkit.org/show_bug.cgi?id=194594
911         <rdar://problem/46793397>
912
913         Reviewed by Geoff Garen.
914
915         Update API tests to turn on the WebContent Process cache.
916
917         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
918
919 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
920
921         Unreviewed, build fix after r241480
922
923         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
924         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
925         (-[DragAndDropSimulator initWithWebView:]):
926
927 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
928
929         AX: ARIA Reflection was disabled in error
930         https://bugs.webkit.org/show_bug.cgi?id=194647
931         <rdar://problem/48068336>
932
933         Reviewed by Ryosuke Niwa.
934
935         Remove test override now that this feature should be enabled by default.
936
937         * WebKitTestRunner/TestController.cpp:
938         (WTR::TestController::resetPreferencesToConsistentValues):
939
940 2019-02-14  Commit Queue  <commit-queue@webkit.org>
941
942         Unreviewed, rolling out r241486.
943         https://bugs.webkit.org/show_bug.cgi?id=194655
944
945         causing API failures in builds (Requested by ShawnRoberts on
946         #webkit).
947
948         Reverted changeset:
949
950         "[Cocoa] Media elements will restart network buffering just
951         before suspending"
952         https://bugs.webkit.org/show_bug.cgi?id=193691
953         https://trac.webkit.org/changeset/241486
954
955 2019-02-14  Zalan Bujtas  <zalan@apple.com>
956
957         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
958         https://bugs.webkit.org/show_bug.cgi?id=194622
959
960         Reviewed by Antti Koivisto.
961
962         * LayoutReloaded/misc/LFC-passing-tests.txt:
963
964 2019-02-14  Zalan Bujtas  <zalan@apple.com>
965
966         [LFC] Shrink-to-fit-width should be constrained by min/max width
967         https://bugs.webkit.org/show_bug.cgi?id=194653
968
969         Reviewed by Antti Koivisto.
970
971         * LayoutReloaded/misc/LFC-passing-tests.txt:
972
973 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
974
975         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
976         https://bugs.webkit.org/show_bug.cgi?id=194641
977
978         Reviewed by Geoffrey Garen.
979
980         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
981         so that the test would fail without this fix.
982
983         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
984         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
985
986 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
987
988         [ews-app] Change log level for a log statement
989
990         Unreviewed minor fix.
991
992         * BuildSlaveSupport/ews-app/ews/models/patch.py:
993         (Patch.save_patch):
994
995 2019-02-13  Jer Noble  <jer.noble@apple.com>
996
997         [Cocoa] Media elements will restart network buffering just before suspending
998         https://bugs.webkit.org/show_bug.cgi?id=193691
999
1000         Reviewed by Eric Carlson.
1001
1002         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1003         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1004         (TEST):
1005
1006 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1007
1008         [ews-app] Fetch builder id to name mapping
1009         https://bugs.webkit.org/show_bug.cgi?id=194355
1010
1011         Reviewed by Lucas Forschler.
1012
1013         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1014         (Buildbot.get_builder_id_to_name_mapping):
1015         (Buildbot._get_display_name_from_builder_name):
1016
1017 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1018
1019         Further restricting webarchive loads
1020         https://bugs.webkit.org/show_bug.cgi?id=194567
1021         <rdar://problem/47610130>
1022
1023         Reviewed by Youenn Fablet.
1024
1025         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1026         navigations on drop.
1027
1028         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1029         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1030         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1031         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1032         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1033         (TestWebKitAPI::TEST):
1034         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1035         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1036         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1037         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1038         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1039         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1040         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1041
1042 2019-02-13  John Wilander  <wilander@apple.com>
1043
1044         Store Ad Click Attribution requests in the network process
1045         https://bugs.webkit.org/show_bug.cgi?id=194510
1046         <rdar://problem/47650118>
1047
1048         Reviewed by Alex Christensen and Daniel Bates.
1049
1050         This patch adds two TestRunner functions:
1051         - dumpAdClickAttribution()
1052         - clearAdClickAttribution()
1053
1054         They call into the network process to dump and clear Ad Click
1055         Attribution state, respectively.
1056
1057         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1058         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1059         (WTR::TestRunner::dumpAdClickAttribution):
1060         (WTR::TestRunner::clearAdClickAttribution):
1061         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1062         * WebKitTestRunner/TestController.cpp:
1063         (WTR::TestController::resetStateToConsistentValues):
1064         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1065         (WTR::adClickAttributionStringResultCallback):
1066         (WTR::TestController::dumpAdClickAttribution):
1067         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1068         (WTR::adClickAttributionVoidCallback):
1069         (WTR::TestController::clearAdClickAttribution):
1070         * WebKitTestRunner/TestController.h:
1071         * WebKitTestRunner/TestInvocation.cpp:
1072         (WTR::TestInvocation::dumpResults):
1073         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1074         (WTR::TestInvocation::dumpAdClickAttribution):
1075         * WebKitTestRunner/TestInvocation.h:
1076
1077 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1078
1079         [ews-app] Generate status-bubble
1080         https://bugs.webkit.org/show_bug.cgi?id=194572
1081
1082         Reviewed by Lucas Forschler.
1083
1084         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1085         (StatusBubble._build_bubble):
1086         (StatusBubble._should_show_bubble_for):
1087         (StatusBubble._build_bubbles_for_patch):
1088
1089 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1090
1091         [ews-app] Add status bubble html template
1092         https://bugs.webkit.org/show_bug.cgi?id=194571
1093
1094         Reviewed by Lucas Forschler.
1095
1096         * BuildSlaveSupport/ews-app/ews/templates: Added.
1097         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1098
1099 2019-02-12  Chris Dumez  <cdumez@apple.com>
1100
1101         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1102         https://bugs.webkit.org/show_bug.cgi?id=194568
1103         <rdar://problem/47944490>
1104
1105         Reviewed by Ryosuke Niwa.
1106
1107         Add API test coverage.
1108
1109         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1110         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1111
1112 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1113
1114         webkitpy: Remove bug_dummy from parsed test expectations
1115         https://bugs.webkit.org/show_bug.cgi?id=194562
1116         <rdar://problem/47853999>
1117
1118         Reviewed by Lucas Forschler.
1119
1120         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1121         (TestExpectationParser):
1122         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1123         skipped tests.
1124         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1125
1126 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1127
1128         [ews-app] Add method to fetch patch
1129         https://bugs.webkit.org/show_bug.cgi?id=194518
1130
1131         Reviewed by Lucas Forschler.
1132
1133         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1134         (Patch.get_patch):
1135
1136 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1137
1138         [LFC] Expand tests coverage (60 new tests -> 860)
1139
1140         Unreviewed test gardening (run-singly, --child-processes=1).
1141
1142         * LayoutReloaded/misc/LFC-passing-tests.txt:
1143
1144 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1145
1146         Allow pages to trigger programmatic paste from script on iOS
1147         https://bugs.webkit.org/show_bug.cgi?id=194271
1148         <rdar://problem/47808810>
1149
1150         Reviewed by Tim Horton.
1151
1152         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1153
1154         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1155         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1156         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1157         (WTR::UIScriptController::rectForMenuAction const):
1158
1159         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1160         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1161         for when the menu is shown or hidden.
1162
1163         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1164         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1165         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1166         (WTR::UIScriptController::setDidShowMenuCallback):
1167         (WTR::UIScriptController::didShowMenuCallback const):
1168         (WTR::UIScriptController::setDidHideMenuCallback):
1169         (WTR::UIScriptController::didHideMenuCallback const):
1170         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1171         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1172         (WTR::UIScriptController::rectForMenuAction const):
1173         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1174         * WebKitTestRunner/TestController.cpp:
1175         (WTR::TestController::resetPreferencesToConsistentValues):
1176         (WTR::updateTestOptionsFromTestHeader):
1177         * WebKitTestRunner/TestOptions.h:
1178
1179         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1180         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1181
1182         (WTR::TestOptions::hasSameInitializationOptions const):
1183         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1184         (WTR::UIScriptController::calendarType const):
1185         (WTR::UIScriptController::platformUndoManager const):
1186         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1187         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1188         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1189         (-[TestRunnerWKWebView dealloc]):
1190         (-[TestRunnerWKWebView _didShowMenu]):
1191         (-[TestRunnerWKWebView _didHideMenu]):
1192
1193         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1194
1195         * WebKitTestRunner/ios/TestControllerIOS.mm:
1196         (WTR::handleMenuWillHideNotification):
1197         (WTR::handleMenuDidHideNotification):
1198         (WTR::TestController::platformInitialize):
1199         (WTR::TestController::platformDestroy):
1200         (WTR::TestController::platformResetStateToConsistentValues):
1201
1202         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1203         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1204
1205         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1206         (WTR::forEachViewInHierarchy):
1207         (WTR::findViewInHierarchyOfType):
1208
1209         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1210         functions that dig through a given view's hierarchy in search of a view of a given class.
1211
1212         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1213         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1214         (WTR::UIScriptController::selectionCaretViewRect const):
1215         (WTR::UIScriptController::selectionRangeViewRects const):
1216         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1217         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1218
1219         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1220
1221         (WTR::UIScriptController::rectForMenuAction const):
1222
1223         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1224         callout bar) whose label matches the given string.
1225
1226         (WTR::UIScriptController::platformContentView const):
1227
1228         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1229         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1230         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1231
1232         (WTR::UIScriptController::platformUndoManager const): Deleted.
1233         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1234         (WTR::UIScriptController::platformContentView const):
1235         (WTR::UIScriptController::platformUndoManager const): Deleted.
1236
1237 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1238
1239         webkitpy: No option to only show unexpected failures in results.html for iPad
1240         https://bugs.webkit.org/show_bug.cgi?id=194554
1241         <rdar://problem/47922442>
1242
1243         Rubber-stamped by Aakash Jain.
1244
1245         Just because a TestExpecations file does not exist for a specific platform does not mean that
1246         TestExpecations are not being used, given that platforms inherit test expectations.
1247
1248         * Scripts/webkitpy/port/base.py:
1249         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1250         * Scripts/webkitpy/port/base_unittest.py:
1251         (PortTest.test_uses_test_expectations_file):
1252
1253 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1254
1255         Remove setDefersLoading infrastructure from WebKit2
1256         https://bugs.webkit.org/show_bug.cgi?id=194506
1257
1258         Reviewed by Brady Eidson.
1259
1260         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1261         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1262         (WTR::TestRunner::setDefersLoading): Deleted.
1263         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1264
1265 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1266
1267         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1268         https://bugs.webkit.org/show_bug.cgi?id=194522
1269         <rdar://problem/47789393>
1270
1271         Reviewed by Chris Dumez.
1272
1273         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1274         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1275         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1276         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1277
1278 2019-02-12  Andy Estes  <aestes@apple.com>
1279
1280         [iOSMac] Enable Parental Controls Content Filtering
1281         https://bugs.webkit.org/show_bug.cgi?id=194521
1282         <rdar://39732376>
1283
1284         Reviewed by Tim Horton.
1285
1286         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1287
1288 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1289
1290         [LFC][IFC] Add intrinsic width support for float boxes.
1291         https://bugs.webkit.org/show_bug.cgi?id=194528
1292
1293         Reviewed by Antti Koivisto.
1294
1295         Expand tests coverage (2 new tests -> 800).
1296         (This is the correct test ordering --runs-singly --child-processes=1)
1297
1298         * LayoutReloaded/misc/LFC-passing-tests.txt:
1299
1300 2019-02-12  Rob Buis  <rbuis@igalia.com>
1301
1302         Implement serializing in MIME type parser
1303         https://bugs.webkit.org/show_bug.cgi?id=193909
1304
1305         Reviewed by Darin Adler.
1306
1307         Add various tests involving upper case, non-ASCII, control/null characters,
1308         various HTTP whitespace, single quotes and an unpaired surrogate.
1309
1310         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1311         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1312         (TestWebKitAPI::serializeIfValid):
1313         (TestWebKitAPI::TEST):
1314
1315 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1316
1317         [Cocoa] Ask platform for generic font family mappings
1318         https://bugs.webkit.org/show_bug.cgi?id=187723
1319         <rdar://problem/41892438>
1320
1321         Reviewed by Brent Fulgham.
1322
1323         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1324
1325         * DumpRenderTree/mac/DumpRenderTree.mm:
1326         (allowedFontFamilySet):
1327         * WebKitTestRunner/mac/TestControllerMac.mm:
1328         (WTR::allowedFontFamilySet):
1329
1330 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1331
1332         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1333         https://bugs.webkit.org/show_bug.cgi?id=193622
1334
1335         Reviewed by Michael Catanzaro.
1336
1337         This adds support for loading content extension rule sets from the JSON files which
1338         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1339         of WKTR for this could be removed, but that is left for a follow-up patch with
1340         cleanups.
1341
1342         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1343         * WebKitTestRunner/TestController.cpp:
1344         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1345         avoid having the null-terminator copied into the result.
1346         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1347         part of the preparations to run a test.
1348         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1349         (WTR::contentExtensionStoreCallback): Added.
1350         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1351         used for content extensions test.
1352         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1353         extensions and compiling the JSON rule set for tests involving content extensions.
1354         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1355         testing and disables content extensions.
1356         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1357         resetContentExtensions().
1358         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1359         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1360         configureContentExtensionForTest(), and userContentController().
1361
1362 2019-02-11  Daniel Bates  <dabates@apple.com>
1363
1364         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1365         https://bugs.webkit.org/show_bug.cgi?id=191446
1366         <rdar://problem/45929460>
1367
1368         Reviewed by Tim Horton.
1369
1370         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1371
1372         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1373         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1374         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1375         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1376         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1377         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1378         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1379         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1380         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1381         (WTR::arrayLength):
1382         (WTR::parseModifierArray):
1383         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1384         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1385         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1386         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1387
1388 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1389
1390         Unreviewed, rolling out r241272 and r241276.
1391         https://bugs.webkit.org/show_bug.cgi?id=194514
1392
1393         Broke the Apple Internal build and the fix requires human
1394         intervention :( (Requested by dydz on #webkit).
1395
1396         Reverted changesets:
1397
1398         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1399         https://bugs.webkit.org/show_bug.cgi?id=191446
1400         https://trac.webkit.org/changeset/241272
1401
1402         "Fix internal iOS build after r241272"
1403         https://bugs.webkit.org/show_bug.cgi?id=191446
1404         https://trac.webkit.org/changeset/241276
1405
1406 2019-02-11  Truitt Savell  <tsavell@apple.com>
1407
1408         Unreviewed, rolling out r241269.
1409
1410         Caused 5 layout tests crashes on Mac WK1
1411
1412         Reverted changeset:
1413
1414         "DumpRenderTree should report unknown options"
1415         https://bugs.webkit.org/show_bug.cgi?id=191303
1416         https://trac.webkit.org/changeset/241269
1417
1418 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1419
1420         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1421         https://bugs.webkit.org/show_bug.cgi?id=194313
1422
1423         Reviewed by Tim Horton.
1424
1425         Add a helper to determine whether the web view is presenting modal UI.
1426
1427         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1428         (WTR::UIScriptController::isPresentingModally const):
1429         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1430         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1431         (WTR::UIScriptController::isPresentingModally const):
1432         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1433         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1434         (WTR::UIScriptController::calendarType const): Deleted.
1435         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1436         (WTR::UIScriptController::isPresentingModally const):
1437         (WTR::UIScriptController::calendarType const):
1438         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1439         (WTR::UIScriptController::calendarType const):
1440
1441 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1442
1443         GCHeapInspector: Show the retained sizes in more places
1444         https://bugs.webkit.org/show_bug.cgi?id=194464
1445
1446         Reviewed by Simon Fraser.
1447
1448         * GCHeapInspector/gc-heap-inspector.html:
1449         * GCHeapInspector/script/interface.js:
1450         (HeapInspectorUtils.humanReadableSize):
1451         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1452         (HeapInspectorUtils.spanForNode.span.span):
1453         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1454         (HeapSnapshotInspector.prototype.buildRoots):
1455
1456 2019-02-11  Daniel Bates  <dabates@apple.com>
1457
1458         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1459         https://bugs.webkit.org/show_bug.cgi?id=191446
1460         <rdar://problem/45929460>
1461
1462         Reviewed by Tim Horton.
1463
1464         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1465
1466         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1467         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1468         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1469         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1470         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1471         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1472         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1473         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1474         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1475         (WTR::arrayLength):
1476         (WTR::parseModifierArray):
1477         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1478         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1479         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1480         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1481
1482 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1483
1484         DumpRenderTree should report unknown options
1485         https://bugs.webkit.org/show_bug.cgi?id=191303
1486
1487         Reviewed by Frédéric Wang.
1488
1489         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1490         to report unknown options.
1491         Added and assigned test options which are currently used in tests.
1492
1493         * DumpRenderTree/TestOptions.cpp:
1494         (TestOptions::TestOptions):
1495
1496 2019-02-11  Truitt Savell  <tsavell@apple.com>
1497
1498         Unreviewed, rolling out r241229.
1499
1500         Revision broke internal builds for watchOS.
1501
1502         Reverted changeset:
1503
1504         "[Cocoa] Ask platform for generic font family mappings"
1505         https://bugs.webkit.org/show_bug.cgi?id=187723
1506         https://trac.webkit.org/changeset/241229
1507
1508 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1509
1510         [WinCairo][MiniBrowser] Basic authentication always fails.
1511         https://bugs.webkit.org/show_bug.cgi?id=194496
1512
1513         Reviewed by Don Olmstead.
1514
1515         * MiniBrowser/win/DialogHelper.h:
1516         (Dialog::getText):
1517
1518 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1519
1520         [GStreamer] GstMappedBuffer testsuite build fails
1521         https://bugs.webkit.org/show_bug.cgi?id=194495
1522
1523         Reviewed by Carlos Garcia Campos.
1524
1525         Fix the build by explicitely adding the gstreamer1.0-audio include
1526         directories to the include path.
1527
1528         * TestWebKitAPI/PlatformGTK.cmake:
1529         * TestWebKitAPI/PlatformWPE.cmake:
1530
1531 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1532
1533         [GTK][WPE] Add enable-javascript-markup setting
1534         https://bugs.webkit.org/show_bug.cgi?id=193439
1535
1536         Reviewed by Michael Catanzaro.
1537
1538         Add test cases to check the new setting.
1539
1540         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1541         (testWebKitSettings):
1542         (testWebKitSettingsJavaScriptMarkup):
1543         (beforeAll):
1544
1545 2019-02-10  Darin Adler  <darin@apple.com>
1546
1547         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1548         https://bugs.webkit.org/show_bug.cgi?id=194485
1549
1550         Reviewed by Daniel Bates.
1551
1552         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1553
1554 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1555
1556         Add more tests for clampTo<>()
1557         https://bugs.webkit.org/show_bug.cgi?id=194462
1558
1559         Reviewed by Geoffrey Garen.
1560
1561         Darin suggested to test the very last floating point number
1562         at the boundaries when truncating to integer.
1563         I added test for max/min and max-1/min-1.
1564
1565         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1566         (TestWebKitAPI::TEST):
1567
1568 2019-02-09  Darin Adler  <darin@apple.com>
1569
1570         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1571         https://bugs.webkit.org/show_bug.cgi?id=194021
1572
1573         Reviewed by Geoffrey Garen.
1574
1575         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1576         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1577         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1578
1579 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1580
1581         [LFC][IFC] Add intrinsic width support for basic inline containers
1582         https://bugs.webkit.org/show_bug.cgi?id=194473
1583
1584         Reviewed by Antti Koivisto.
1585
1586         Expand tests coverage (11 new tests -> 798)
1587
1588         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1589
1590 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1591
1592         Fix MiniBrowser's entitlements
1593         https://bugs.webkit.org/show_bug.cgi?id=192431
1594
1595         Reviewed by Joseph Pecoraro.
1596
1597         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1598         files, making it impossible to load any extension.
1599
1600         * MiniBrowser/MiniBrowser.entitlements:
1601
1602 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1603
1604         [Cocoa] Ask platform for generic font family mappings
1605         https://bugs.webkit.org/show_bug.cgi?id=187723
1606         <rdar://problem/41892438>
1607
1608         Reviewed by Brent Fulgham.
1609
1610         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1611
1612         * DumpRenderTree/mac/DumpRenderTree.mm:
1613         (allowedFontFamilySet):
1614         * WebKitTestRunner/mac/TestControllerMac.mm:
1615         (WTR::allowedFontFamilySet):
1616
1617 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1618
1619         [GTK] Implement back/forward touchpad gesture
1620         https://bugs.webkit.org/show_bug.cgi?id=193919
1621
1622         Reviewed by Michael Catanzaro.
1623
1624         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1625         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1626
1627 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1628
1629         Add SPI to use networking daemon instead of XPC service
1630         https://bugs.webkit.org/show_bug.cgi?id=194427
1631
1632         Reviewed by Geoffrey Garen
1633
1634         * MiniBrowser/MiniBrowser.entitlements:
1635
1636 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1637
1638         [ews-build] Ensure that every builder in config.json has short name
1639         https://bugs.webkit.org/show_bug.cgi?id=194461
1640
1641         Reviewed by Lucas Forschler.
1642
1643         * BuildSlaveSupport/ews-build/loadConfig.py:
1644         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1645
1646 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1647
1648         [ews-build] Add short name to config.json
1649         https://bugs.webkit.org/show_bug.cgi?id=194456
1650
1651         Reviewed by Lucas Forschler.
1652
1653         * BuildSlaveSupport/ews-build/config.json: Added short name.
1654         * BuildSlaveSupport/ews-build/loadConfig.py:
1655         (loadBuilderConfig): Set the short name as the builder description.
1656
1657 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1658
1659         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1660         https://bugs.webkit.org/show_bug.cgi?id=194418
1661
1662         Reviewed by Lucas Forschler.
1663
1664         Do not include errors trying when finding crashlogs at the end of
1665         a run-webkit-tests run since we don't process those errors.
1666
1667         * Scripts/webkitpy/port/darwin.py:
1668         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1669         * Scripts/webkitpy/port/ios_device.py:
1670         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1671         * Scripts/webkitpy/port/watch_device.py:
1672         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1673
1674 2019-02-08  Beth Dakin  <bdakin@apple.com>
1675
1676         Add afterScreenUpdates to WKSnapshotConfiguration
1677         https://bugs.webkit.org/show_bug.cgi?id=194362
1678         -and corresponding-
1679         <rdar://problem/40655528> Please add an "after screen updates" property to 
1680         WKSnapshotConfiguration (to solve blank snapshots)
1681
1682         Reviewed by Tim Horton.
1683
1684         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1685         (TEST):
1686
1687 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1688
1689         clampTo(): do not convert the input to double when dealing with integers
1690         https://bugs.webkit.org/show_bug.cgi?id=194263
1691         <rdar://problem/47692312>
1692
1693         Reviewed by Darin Adler.
1694
1695         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1696         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1697         (TestWebKitAPI::testClampFloatingPointToInteger):
1698         (TestWebKitAPI::testClampSameSignIntegers):
1699         (TestWebKitAPI::testClampUnsignedToSigned):
1700         (TestWebKitAPI::testClampSignedToUnsigned):
1701
1702 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1703
1704         webkitpy: Respect --dedicated-simulators flag
1705         https://bugs.webkit.org/show_bug.cgi?id=194416
1706         <rdar://problem/47894722>
1707
1708         Reviewed by Lucas Forschler.
1709
1710         * Scripts/webkitpy/port/device_port.py:
1711         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1712         available devices can be safely ignored.
1713
1714 2019-02-07  Keith Rollin  <krollin@apple.com>
1715
1716         Remove extra copy of 100x100-red.tga
1717         https://bugs.webkit.org/show_bug.cgi?id=194371
1718         <rdar://problem/47873465>
1719
1720         Reviewed by Said Abou-Hallawa.
1721
1722         In order to help it pass its tests, Bug 194190 added a second copy of
1723         the file 100x100-red.tga. However, it turns out that this additional
1724         file wasn't actually needed, and that that sole previous copy was
1725         sufficient. At the same time, this second copy -- which was copied to
1726         the same location in the build output as the first copy -- now caused
1727         XCBuild to complain because there were two production rules for the
1728         same output file. Address this by removing the newly-added extra copy.
1729
1730         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1731         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1732
1733 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1734
1735         Deprecate WKBundlePageSetDefersLoading
1736         https://bugs.webkit.org/show_bug.cgi?id=191394
1737
1738         Reviewed by Dean Jackson.
1739
1740         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1741         (WTR::TestRunner::setDefersLoading):
1742
1743 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1744
1745         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1746         https://bugs.webkit.org/show_bug.cgi?id=194391
1747
1748         Reviewed by Antti Koivisto.
1749
1750         * LayoutReloaded/misc/LFC-passing-tests.txt:
1751
1752 2019-02-06  Keith Rollin  <krollin@apple.com>
1753
1754         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1755         https://bugs.webkit.org/show_bug.cgi?id=193975
1756         <rdar://problem/47643306>
1757
1758         Reviewed by Tim Horton.
1759
1760         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1761         the Info.plist file into the bundle. This step is not necessary as the
1762         implicit "bundle up all the build products into a framework" build
1763         phase does this already. Having the Copy Bundle Resources phase do
1764         this causes a conflict under XCBuild, which objects to two build
1765         phases producing the same file (Info.plist). Address this by removing
1766         Info.plist from the Copy Bundle Resources phase.
1767
1768         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1769
1770 2019-02-06  Keith Rollin  <krollin@apple.com>
1771
1772         Really enable the automatic checking and regenerations of .xcfilelists during builds
1773         https://bugs.webkit.org/show_bug.cgi?id=194357
1774         <rdar://problem/47861231>
1775
1776         Reviewed by Chris Dumez.
1777
1778         Bug 194124 was supposed to enable the automatic checking and
1779         regenerating of .xcfilelist files during the build. While related
1780         changes were included in that patch, the change to actually enable the
1781         operation somehow was omitted. This patch actually enables the
1782         operation. The check-xcfilelist.sh scripts now check
1783         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1784         from the checking.
1785
1786         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1787         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1788
1789 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1790
1791         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1792         <https://webkit.org/b/194286>
1793         <rdar://problem/47815558>
1794
1795         Reviewed by Alexey Proskuryakov.
1796
1797         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1798         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1799         WKRetainPtr<> to avoid leaking the WKDataRef.
1800
1801 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1802
1803         Unreviewed, fix a typo
1804
1805         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1806
1807 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1808
1809         [GTK][WPE] force libpsl build to use ICU in jhbuild
1810         https://bugs.webkit.org/show_bug.cgi?id=194288
1811
1812         Reviewed by Carlos Garcia Campos.
1813
1814         * gtk/jhbuild.modules:
1815         Require ICU for libpsl build in jhbuild, like done in WPE.
1816
1817 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1818
1819         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1820         https://bugs.webkit.org/show_bug.cgi?id=194209
1821
1822         Reviewed by Carlos Garcia Campos.
1823
1824         Enhance TestCookieManager to ensure this doesn't happen again.
1825
1826         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1827         (testCookieManagerPersistentStorage):
1828         (beforeAll):
1829
1830 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1831
1832         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1833         https://bugs.webkit.org/show_bug.cgi?id=194324
1834
1835         Reviewed by Andy Estes.
1836
1837         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1838         part of the name is already implicit, since this is in testing code in TestOptions.
1839
1840         * WebKitTestRunner/TestController.cpp:
1841         (WTR::TestController::generateContextConfiguration const):
1842         (WTR::updateTestOptionsFromTestHeader):
1843         * WebKitTestRunner/TestOptions.h:
1844         (WTR::TestOptions::hasSameInitializationOptions const):
1845
1846 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1847
1848         [ews-build] Allow * as platform for builders and workers
1849         https://bugs.webkit.org/show_bug.cgi?id=188533
1850
1851         Reviewed by Lucas Forschler.
1852
1853         * BuildSlaveSupport/ews-build/loadConfig.py:
1854         (checkWorkersAndBuildersForConsistency):
1855
1856 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1857
1858         [ews-build] Add few bots to config.json
1859         https://bugs.webkit.org/show_bug.cgi?id=194304
1860
1861         Reviewed by Lucas Forschler.
1862
1863         * BuildSlaveSupport/ews-build/config.json:
1864
1865 2019-02-05  Keith Rollin  <krollin@apple.com>
1866
1867         Enable the automatic checking and regenerations of .xcfilelists during builds
1868         https://bugs.webkit.org/show_bug.cgi?id=194124
1869         <rdar://problem/47721277>
1870
1871         Reviewed by Tim Horton.
1872
1873         Bug 193790 add a facility for checking -- during build time -- that
1874         any needed .xcfilelist files are up-to-date and for updating them if
1875         they are not. This facility was initially opt-in by setting
1876         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1877         the process seemed robust. Its now time to enable this facility and
1878         make it opt-out. If there is a need to disable this facility, set and
1879         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1880         running `make` or `build-webkit`, or before running Xcode from the
1881         command line.
1882
1883         Additionally, remove the step that generates a list of source files
1884         going into the UnifiedSources build step. It's only necessarily to
1885         specify Sources.txt and SourcesCocoa.txt as inputs.
1886
1887         * Scripts/generate-xcfilelists:
1888
1889 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1890
1891         [GTK][WPE] force libpsl build to use ICU in jhbuild
1892         https://bugs.webkit.org/show_bug.cgi?id=194288
1893
1894         Reviewed by Philippe Normand.
1895
1896         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1897         This can cause build failures if libidn is detected but libunistring is not available.
1898
1899         Make sure that ICU is used for runtime and builtin PSL data.
1900
1901         * gtk/jhbuild.modules:
1902         * wpe/jhbuild.modules:
1903
1904 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1905
1906         [ews-app] Modified timestamp should be updated on updating data
1907         https://bugs.webkit.org/show_bug.cgi?id=194295
1908
1909         Reviewed by Lucas Forschler.
1910
1911         * BuildSlaveSupport/ews-app/ews/models/build.py:
1912         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1913         * BuildSlaveSupport/ews-app/ews/models/step.py:
1914
1915 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1916
1917         Unreviewed, rolling out r240742.
1918
1919         Causes crashes on iOS simulator.
1920
1921         Reverted changeset:
1922
1923         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1924         not focused in a content-editable element"
1925         https://bugs.webkit.org/show_bug.cgi?id=192824
1926         https://trac.webkit.org/changeset/240742
1927
1928 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1929
1930         run-webkit-tests emits message "...running None" when running tests
1931         https://bugs.webkit.org/show_bug.cgi?id=194133
1932         <rdar://problem/47724738>
1933
1934         Reviewed by Lucas Forschler.
1935
1936         * Scripts/webkitpy/xcode/device_type.py:
1937         (DeviceType.__str__): Use both version mapping tables and use just the variant
1938         name if no version name is available.
1939         * Scripts/webkitpy/xcode/device_type_unittest.py:
1940         (DeviceTypeTest):
1941         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1942         an associated named.
1943
1944 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1945
1946         [WPE] require python3-setuptools for meson build in jhbuild
1947         https://bugs.webkit.org/show_bug.cgi?id=194287
1948
1949         Reviewed by Philippe Normand.
1950
1951         python3-setuptools is needed to build meson in jhbuild.
1952         It is already required by the GTK port.
1953
1954         * wpe/install-dependencies:
1955
1956 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1957
1958         [ews-app] Add method to save BuilderMapping to database
1959         https://bugs.webkit.org/show_bug.cgi?id=194264
1960
1961         Reviewed by Lucas Forschler.
1962
1963         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1964         (BuilderMapping.__str__):
1965         (BuilderMapping):
1966         (BuilderMapping.save_mapping):
1967         (BuilderMapping.update_mapping):
1968         (BuilderMapping.get_existing_mapping):
1969         (BuilderMapping.is_valid_mapping):
1970
1971 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1972
1973         [ews-app] Add timestamp fields for BuilderMappings
1974         https://bugs.webkit.org/show_bug.cgi?id=194266
1975
1976         Reviewed by Lucas Forschler.
1977
1978         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1979         (BuilderMapping):
1980
1981 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
1982
1983         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
1984         https://bugs.webkit.org/show_bug.cgi?id=174816
1985
1986         Reviewed by Michael Catanzaro.
1987
1988         Add tests for webkit_uri_for_display().
1989
1990         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
1991         (testURIForDisplayUnaffected):
1992         (testURIForDisplayAffected):
1993         (beforeAll):
1994         (afterAll):
1995         * TestWebKitAPI/glib/CMakeLists.txt:
1996
1997 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
1998
1999         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2000         https://bugs.webkit.org/show_bug.cgi?id=194158
2001         <rdar://problem/47737268>
2002
2003         Rubber-stamped by Aakash Jain.
2004
2005         * Scripts/webkitpy/port/device_port.py:
2006         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2007
2008 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2009
2010         [CG] Enable setAdditionalSupportedImageTypes for WK1
2011         https://bugs.webkit.org/show_bug.cgi?id=194190
2012
2013         Reviewed by Tim Horton.
2014
2015         Add a test similar to the one under WebKit Cocoa but make it create a
2016         WebView instead of a WKWebView.
2017
2018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2019         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2020         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2021         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2022         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2023         (TestWebKitAPI::runTest):
2024         (TestWebKitAPI::TEST):
2025
2026 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2027
2028         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2029         https://bugs.webkit.org/show_bug.cgi?id=194168
2030
2031         Reviewed by Simon Fraser.
2032
2033         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2034
2035         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2036         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2037         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2038         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2039         (TEST):
2040         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2041         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2042
2043 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2044
2045         REGRESSION (r237269): webkit-patch what-broke is broken 
2046         https://bugs.webkit.org/show_bug.cgi?id=193025
2047
2048         Reviewed by Aakash Jain.
2049
2050         * Scripts/webkitpy/common/host.py:
2051         (Host.buildbot):
2052         (Host.bugzilla): Renamed to 'buildbot'.
2053
2054 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2055
2056         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2057         https://bugs.webkit.org/show_bug.cgi?id=194207
2058
2059         Reviewed by Tim Horton.
2060
2061         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2062         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2063         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2064         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2065         start and delete forwards to remove the original attachment.
2066
2067         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2068         (TestWebKitAPI::TEST):
2069
2070 2019-02-04  Youenn Fablet  <youenn@apple.com>
2071
2072         Capture state should be managed consistently when doing process swapping
2073         https://bugs.webkit.org/show_bug.cgi?id=194122
2074         <rdar://problem/47609293>
2075
2076         Reviewed by Eric Carlson.
2077
2078         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2079         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2080         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2081         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2082         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2083         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2084         (WTR::TestRunner::isDoingMediaCapture const):
2085         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2086         * WebKitTestRunner/TestController.cpp:
2087         (WTR::TestController::isDoingMediaCapture const):
2088         * WebKitTestRunner/TestController.h:
2089         * WebKitTestRunner/TestInvocation.cpp:
2090         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2091         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2092         (WTR::TestController::isDoingMediaCapture const):
2093
2094 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2095
2096         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2097         https://bugs.webkit.org/show_bug.cgi?id=194142
2098
2099         Reviewed by Ross Kirsling.
2100
2101         There three 'separator' variables in TestController.cpp. Renamed
2102         it 'pathSeparator', and unified them.
2103
2104         * WebKitTestRunner/TestController.cpp:
2105         (WTR::TestController::generateContextConfiguration const):
2106         (WTR::createTestURL):
2107         (WTR::TestController::platformAdjustContext):
2108
2109 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2110
2111         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2112         https://bugs.webkit.org/show_bug.cgi?id=194198
2113
2114         Reviewed by Antti Koivisto.
2115
2116         No need to set the banner heights on navigation now, since Page stores them.
2117
2118         * MiniBrowser/mac/WK2BrowserWindowController.m:
2119         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2120
2121 2019-02-03  John Wilander  <wilander@apple.com>
2122
2123         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2124         https://bugs.webkit.org/show_bug.cgi?id=194104
2125         <rdar://problem/47649991>
2126
2127         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2128
2129         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2130         (TestWebKitAPI::TEST):
2131             Changed numeric types from unsigned short to uint32_t.
2132
2133 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2134
2135         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2136         <https://webkit.org/b/194178>
2137         <rdar://problem/47753473>
2138
2139         Reviewed by Alexey Proskuryakov.
2140
2141         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2142         (WTR::uninstallFakeHelvetica): Pass nullptr into
2143         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2144
2145 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2146
2147         [LFC] Initialize ICB's style with fixed width/height.
2148         https://bugs.webkit.org/show_bug.cgi?id=194188
2149
2150         Reviewed by Antti Koivisto.
2151
2152         * LayoutReloaded/misc/LFC-passing-tests.txt:
2153
2154 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2155
2156         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2157         https://bugs.webkit.org/show_bug.cgi?id=194185
2158
2159         Reviewed by Antti Koivisto.
2160
2161         * LayoutReloaded/misc/LFC-passing-tests.txt:
2162
2163 2018-12-16  Darin Adler  <darin@apple.com>
2164
2165         Convert additional String::format clients to alternative approaches
2166         https://bugs.webkit.org/show_bug.cgi?id=192746
2167
2168         Reviewed by Alexey Proskuryakov.
2169
2170         * WebKitTestRunner/TestController.cpp:
2171         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2172         as an intermediate in code that ultimately constructs a WTF::String.
2173         (WTR::userMediaOriginHash): Use makeString.
2174         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2175         (WTR::TestController::didPerformClientRedirect): Ditto.
2176         (WTR::TestController::didPerformServerRedirect): Ditto.
2177         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2178
2179 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2180
2181         [ews-build] Add unit test to verify builder keys
2182         https://bugs.webkit.org/show_bug.cgi?id=194152
2183
2184         Reviewed by Lucas Forschler.
2185
2186         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2187         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2188
2189 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2190
2191         [LFC] Expand tests coverage (12 new tests -> 787)
2192
2193         Unreviewed test gardening.
2194
2195         * LayoutReloaded/misc/LFC-passing-tests.txt:
2196
2197 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2198
2199         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2200         https://bugs.webkit.org/show_bug.cgi?id=194163
2201
2202         Reviewed by Simon Fraser.
2203
2204         775
2205
2206         * LayoutReloaded/misc/LFC-passing-tests.txt:
2207
2208 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2209
2210         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2211         https://bugs.webkit.org/show_bug.cgi?id=194140
2212         <rdar://problem/47728098>
2213
2214         Reviewed by Tim Horton.
2215
2216         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2217         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2218         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2219
2220         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2221         test to induce an IPC deadlock when presenting a modal alert during touch start.
2222
2223         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2224         * WebKitTestRunner/TestController.cpp:
2225         (WTR::runJavaScriptAlert):
2226
2227         Add a client callback function for running JavaScript alerts.
2228
2229         (WTR::TestController::createOtherPage):
2230         (WTR::TestController::generateContextConfiguration const):
2231
2232         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2233         the fix in this patch.
2234
2235         (WTR::TestController::createWebViewWithOptions):
2236
2237         Plumb TestOptions to generateContextConfiguration.
2238
2239         (WTR::TestController::resetPreferencesToConsistentValues):
2240         (WTR::TestController::resetStateToConsistentValues):
2241         (WTR::updateTestOptionsFromTestHeader):
2242         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2243         (WTR::TestController::handleJavaScriptAlert):
2244         * WebKitTestRunner/TestController.h:
2245         * WebKitTestRunner/TestInvocation.cpp:
2246         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2247         * WebKitTestRunner/TestOptions.h:
2248         (WTR::TestOptions::hasSameInitializationOptions const):
2249
2250 2019-02-01  Chris Dumez  <cdumez@apple.com>
2251
2252         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2253         https://bugs.webkit.org/show_bug.cgi?id=193740
2254         <rdar://problem/47527267>
2255
2256         Reviewed by Alex Christensen.
2257
2258         Add API test coverage.
2259
2260         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2261
2262 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2263
2264         [ews-app] Add display name field to BuilderMapping model
2265         https://bugs.webkit.org/show_bug.cgi?id=194153
2266
2267         Reviewed by Lucas Forschler.
2268
2269         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2270         (BuilderMapping):
2271
2272 2019-02-01  Youenn Fablet  <youenn@apple.com>
2273
2274         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2275         https://bugs.webkit.org/show_bug.cgi?id=194155
2276
2277         Reviewed by Eric Carlson.
2278
2279         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2280         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2281         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2282
2283 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2284
2285         [LFC] Adjust replaced element's intrinsic ratio
2286         https://bugs.webkit.org/show_bug.cgi?id=194154
2287
2288         Reviewed by Antti Koivisto.
2289
2290         761
2291
2292         * LayoutReloaded/misc/LFC-passing-tests.txt:
2293
2294 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2295
2296         [WPE] Show test results in minibrowser
2297         https://bugs.webkit.org/show_bug.cgi?id=194150
2298
2299         Reviewed by Žan Doberšek.
2300
2301         * Scripts/webkitpy/port/wpe.py:
2302         (WPEPort.show_results_html_file):
2303
2304 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2305
2306         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2307         https://bugs.webkit.org/show_bug.cgi?id=194151
2308
2309         Reviewed by Žan Doberšek.
2310
2311         ALT + <- go back
2312         ALT + -> go forward
2313
2314         * MiniBrowser/wpe/main.cpp:
2315         (main):
2316
2317 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2318
2319         [LFC] Set intrinsic size on Layout::Replaced
2320         https://bugs.webkit.org/show_bug.cgi?id=194139
2321
2322         Reviewed by Antti Koivisto.
2323
2324         744
2325
2326         * LayoutReloaded/misc/LFC-passing-tests.txt:
2327
2328 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2329
2330         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2331         https://bugs.webkit.org/show_bug.cgi?id=194146
2332
2333         Reviewed by Xabier Rodriguez-Calvar.
2334
2335         It allows to open relative paths.
2336
2337         * MiniBrowser/wpe/main.cpp:
2338         (main):
2339
2340 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2341
2342         Update flakiness dashboard configuration after recent queue changes
2343         https://bugs.webkit.org/show_bug.cgi?id=194127
2344
2345         Rubber-stamped by Aakash Jain.
2346
2347         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2348
2349         * TestResultServer/static-dashboards/builders.jsonp:
2350
2351 2019-01-31  Youenn Fablet  <youenn@apple.com>
2352
2353         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2354         https://bugs.webkit.org/show_bug.cgi?id=194106
2355         <rdar://problem/47676333>
2356
2357         Reviewed by Ryosuke Niwa.
2358
2359         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2360         (TestWebKitAPI::didFinishNavigation):
2361         (TestWebKitAPI::TEST):
2362         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2363
2364 2019-01-31  Chris Dumez  <cdumez@apple.com>
2365
2366         Page zoom level is lost after a process swap or a crash
2367         https://bugs.webkit.org/show_bug.cgi?id=194105
2368         <rdar://problem/47610781>
2369
2370         Reviewed by Alex Christensen.
2371
2372         Add API test coverage.
2373
2374         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2375         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2376
2377 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2378
2379         Revert r238819 which is unneeded and caused a performance regression.
2380         https://bugs.webkit.org/show_bug.cgi?id=192272
2381         <rdar://problem/46664625>
2382
2383         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2384         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2385         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2386
2387 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2388
2389         Formalize WebKitAdditions mechanism of LoadOptimizer
2390         https://bugs.webkit.org/show_bug.cgi?id=193886
2391         <rdar://problem/47696809>
2392
2393         Reviewed by Brent Fulgham.
2394
2395         * MiniBrowser/MiniBrowser.entitlements:
2396         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2397
2398 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2399
2400         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2401         https://bugs.webkit.org/show_bug.cgi?id=194090
2402
2403         Reviewed by Antti Koivisto.
2404
2405         * LayoutReloaded/misc/LFC-passing-tests.txt:
2406
2407 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2408
2409         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2410         https://bugs.webkit.org/show_bug.cgi?id=194074
2411
2412         Reviewed by Antti Koivisto.
2413
2414         * LayoutReloaded/misc/LFC-passing-tests.txt:
2415
2416 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2417
2418         [LFC][BFC] Add support for block level replaced box.
2419         https://bugs.webkit.org/show_bug.cgi?id=194071
2420
2421         Reviewed by Antti Koivisto.
2422
2423         * LayoutReloaded/misc/LFC-passing-tests.txt:
2424
2425 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2426
2427         Fix WebKitTestRunner's testPath with Windows full paths
2428         https://bugs.webkit.org/show_bug.cgi?id=194012
2429
2430         Reviewed by Alex Christensen.
2431
2432         updateTestOptionsFromTestHeader failed to open test files because
2433         testPath returned wrong file paths. It returned a path "/C:/..."
2434         if a URL "file:///C:/..." was given.
2435
2436         * WebKitTestRunner/TestController.cpp:
2437         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2438
2439 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2440
2441         [WPE] Bump font related dependencies to match the GTK+ port
2442         https://bugs.webkit.org/show_bug.cgi?id=194017
2443
2444         Reviewed by Žan Doberšek.
2445
2446         * wpe/jhbuild.modules:
2447         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2448         * wpe/patches/icudata-stdlibs.patch: Added.
2449
2450 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2451
2452         Enable swipe tests on iOS
2453         https://bugs.webkit.org/show_bug.cgi?id=194076
2454
2455         Reviewed by Geoffrey Garen.
2456
2457         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2458         it causes a debug assertion failure in runUIScript.
2459
2460         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2461         (WTR::UIScriptController::beginBackSwipe):
2462         (WTR::UIScriptController::completeBackSwipe):
2463
2464 2019-01-30  Keith Rollin  <krollin@apple.com>
2465
2466         Use correct printf format specifier
2467         https://bugs.webkit.org/show_bug.cgi?id=194062
2468         <rdar://problem/47686167>
2469
2470         Reviewed by Alexey Proskuryakov.
2471
2472         LayoutTestSpellChecker.mm is trying to format a variable of type
2473         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2474         actually an unsigned long long. Fix this by formatting with %llu.
2475
2476         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2477         (-[LayoutTestTextCheckingResult description]):
2478
2479 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2480
2481         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2482         https://bugs.webkit.org/show_bug.cgi?id=193979
2483
2484         Reviewed by Wenson Hsieh.
2485
2486         Fix the test for iOS. Make the test work with iOS UA string.
2487
2488         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2489
2490 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2491
2492         Replace High Sierra LLINT CLoop bot due to hardware failure
2493         https://bugs.webkit.org/show_bug.cgi?id=194066
2494
2495         Reviewed by Aakash Jain.
2496
2497         * BuildSlaveSupport/build.webkit.org-config/config.json:
2498
2499 2019-01-30  Keith Rollin  <krollin@apple.com>
2500
2501         [NSDragItem init] is unavailable
2502         https://bugs.webkit.org/show_bug.cgi?id=194059
2503         <rdar://problem/47685715>
2504
2505         Reviewed by Wenson Hsieh.
2506
2507         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2508         DumpRenderTree and TestWebKitAPI, which both try to create an
2509         NSDragItem in a manner that invokes this method. Address this by using
2510         -initWithPasteboardWriter instead.
2511
2512         Note that the parameter passed to initWithPasteboardWriter is likely
2513         incorrect. In both cases, the object passed does not conform to
2514         NSPasteboardWriting. However, with this fix, we're no worse off than
2515         before, and can now perform builds with newer compilers and SDKs until
2516         a real fix can be crafted. That work is tracked in
2517         https://bugs.webkit.org/show_bug.cgi?id=194060
2518
2519         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2520         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2521         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2522         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2523
2524 2019-01-30  Daniel Bates  <dabates@apple.com>
2525
2526         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2527         https://bugs.webkit.org/show_bug.cgi?id=192824
2528         <rdar://problem/47100332>
2529
2530         Reviewed by Wenson Hsieh.
2531
2532         Fix a bug where the wrong usage code was used for F13 thru F24.
2533
2534         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2535         (keyCodeForDOMFunctionKey):
2536
2537 2019-01-30  Chris Dumez  <cdumez@apple.com>
2538
2539         Regression(PSON) Load hang can occur on history navigation
2540         https://bugs.webkit.org/show_bug.cgi?id=194030
2541         <rdar://problem/47656939>
2542
2543         Reviewed by Antti Koivisto.
2544
2545         Add API test coverage.
2546
2547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2548
2549 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2550
2551         [LFC] Expand tests coverage.
2552
2553         Unreviewed test gardening.
2554
2555         * LayoutReloaded/misc/LFC-passing-tests.txt:
2556
2557 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2558
2559         [Flatpak] Add openjpeg support
2560         https://bugs.webkit.org/show_bug.cgi?id=194019
2561
2562         Reviewed by Michael Catanzaro.
2563
2564         * flatpak/org.webkit.CommonModules.yaml:
2565
2566 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2567
2568         Unreviewed, rolling out r240708.
2569         https://bugs.webkit.org/show_bug.cgi?id=194022
2570
2571         It broke WPE build (Requested by KaL on #webkit).
2572
2573         Reverted changeset:
2574
2575         "[WPE] Bump font related dependencies to match the GTK+ port"
2576         https://bugs.webkit.org/show_bug.cgi?id=194017
2577         https://trac.webkit.org/changeset/240708
2578
2579 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2580
2581         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2582         https://bugs.webkit.org/show_bug.cgi?id=194001
2583
2584         Reviewed by Antti Koivisto.
2585
2586         * LayoutReloaded/misc/LFC-passing-tests.txt:
2587
2588 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2589
2590         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2591         https://bugs.webkit.org/show_bug.cgi?id=194020
2592
2593         Reviewed by Antti Koivisto.
2594
2595         * LayoutReloaded/misc/LFC-passing-tests.txt:
2596
2597 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2598
2599         AX: Support color well on iOS
2600         https://bugs.webkit.org/show_bug.cgi?id=194010
2601
2602         Reviewed by Joanmarie Diggs.
2603
2604         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2605         (WTR::AccessibilityUIElement::stringAttributeValue):
2606
2607 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2608
2609         [WPE] Bump font related dependencies to match the GTK+ port
2610         https://bugs.webkit.org/show_bug.cgi?id=194017
2611
2612         Reviewed by Žan Doberšek.
2613
2614         * wpe/jhbuild.modules:
2615         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2616         * wpe/patches/icudata-stdlibs.patch: Added.
2617
2618 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2619
2620         [Mac] Update window scale API usage
2621         https://bugs.webkit.org/show_bug.cgi?id=193991
2622         rdar://problem/47614795
2623
2624         Reviewed by Tim Horton.
2625
2626         * DumpRenderTree/mac/DumpRenderTree.mm:
2627         (changeWindowScaleIfNeeded):
2628         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2629         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2630         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2631
2632 2019-01-29  Chris Dumez  <cdumez@apple.com>
2633
2634         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2635         https://bugs.webkit.org/show_bug.cgi?id=193977
2636         <rdar://problem/47643716>
2637
2638         Reviewed by Geoff Garen.
2639
2640         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2641         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2642         to the previous provisional committing *before* we make the last load. 
2643
2644         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2645
2646 2019-01-29  Youenn Fablet  <youenn@apple.com>
2647
2648         Adopt new SPI to evaluate server certificate trust
2649         https://bugs.webkit.org/show_bug.cgi?id=193355
2650
2651         Reviewed by Alex Christensen.
2652
2653         Add infrastructure to handle HTTPS server trust evaluation testing.
2654
2655         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2656         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2657         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2658         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2659         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2660         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2661         * WebKitTestRunner/TestController.cpp:
2662         (WTR::TestController::resetPreferencesToConsistentValues):
2663         (WTR::TestController::didReceiveAuthenticationChallenge):
2664         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2665         * WebKitTestRunner/TestController.h:
2666         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2667         * WebKitTestRunner/TestInvocation.cpp:
2668         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2669         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2670         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2671
2672 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2673
2674         [ews-build] Add build step to print bot Configuration
2675         https://bugs.webkit.org/show_bug.cgi?id=193887
2676
2677         Reviewed by Lucas Forschler.
2678
2679         * BuildSlaveSupport/ews-build/steps.py:
2680         (PrintConfiguration): Build step to print configuration.
2681         * BuildSlaveSupport/ews-build/factories.py:
2682
2683 2019-01-29  Chris Dumez  <cdumez@apple.com>
2684
2685         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2686         https://bugs.webkit.org/show_bug.cgi?id=193967
2687         <rdar://problem/47635348>
2688
2689         Reviewed by Alex Christensen.
2690
2691         Add API test coverage.
2692
2693         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2694         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2695
2696 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2697
2698         [ews-app] Handle incoming results data
2699         https://bugs.webkit.org/show_bug.cgi?id=193973
2700
2701         Reviewed by Lucas Forschler.
2702
2703         * BuildSlaveSupport/ews-app/ews/views/results.py:
2704
2705 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2706
2707         [ews-app] Make the results url generic
2708         https://bugs.webkit.org/show_bug.cgi?id=193928
2709
2710         Reviewed by Lucas Forschler.
2711
2712         * BuildSlaveSupport/ews-app/ews/urls.py:
2713
2714 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2715
2716         [ews-build] Configure buildbot to send events to ews-app
2717         https://bugs.webkit.org/show_bug.cgi?id=193968
2718
2719         Reviewed by Lucas Forschler.
2720
2721         * BuildSlaveSupport/ews-build/events.py: Added.
2722         * BuildSlaveSupport/ews-build/master.cfg:
2723
2724 2019-01-29  Keith Rollin  <krollin@apple.com>
2725
2726         Add .xcfilelists to Run Script build phases
2727         https://bugs.webkit.org/show_bug.cgi?id=193792
2728         <rdar://problem/47201785>
2729
2730         Reviewed by Alex Christensen.
2731
2732         As part of supporting XCBuild, update the necessary Run Script build
2733         phases in their Xcode projects to refer to their associated
2734         .xcfilelist files.
2735
2736         Note that the addition of these files bumps the Xcode project version
2737         number to something that's Xcode 10 compatible. This change means that
2738         older versions of the Xcode IDE can't read these projects. Nor can it
2739         fully load workspaces that refer to these projects (the updated
2740         projects are shown as non-expandable placeholders). `xcodebuild` can
2741         still build these projects; it's just that the IDE can't open them.
2742
2743         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2744         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2745
2746 2019-01-29  John Wilander  <wilander@apple.com>
2747
2748         Add data abstraction and validation for Ad Click Attribution
2749         https://bugs.webkit.org/show_bug.cgi?id=193916
2750         <rdar://problem/47603481>
2751
2752         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2753
2754         Ad click attribution has two steps. First, the storage of an ad
2755         campaign ID for a click that takes the user to a destination
2756         site. Second, a conversion on the destination site that can be
2757         attributed to the ad click.
2758
2759         This patch adds a class that represents a request for ad click
2760         attribution. Validation makes sure that the bits of entropy
2761         reported through this mechanism is limited.
2762
2763         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2764         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2765         (TestWebKitAPI::TEST):
2766
2767 2019-01-29  Chris Dumez  <cdumez@apple.com>
2768
2769         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2770         https://bugs.webkit.org/show_bug.cgi?id=193932
2771         <rdar://problem/47598947>
2772
2773         Reviewed by Brady Eidson.
2774
2775         Add API test coverage.
2776
2777         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2778
2779 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2780
2781         Adding new passing LFC tests.
2782
2783         Unreviewed test gardening.
2784
2785         * LayoutReloaded/misc/LFC-passing-tests.txt:
2786
2787 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2788
2789         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2790         https://bugs.webkit.org/show_bug.cgi?id=193964
2791
2792         Reviewed by Antti Koivisto.
2793
2794         * LayoutReloaded/misc/LFC-passing-tests.txt:
2795
2796 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2797
2798         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2799         https://bugs.webkit.org/show_bug.cgi?id=193954
2800
2801         Reviewed by Antti Koivisto.
2802
2803         * LayoutReloaded/misc/LFC-passing-tests.txt:
2804
2805 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2806
2807         WebDriver: add support for running subtests
2808         https://bugs.webkit.org/show_bug.cgi?id=193904
2809
2810         Reviewed by Michael Catanzaro.
2811
2812         pytest already supports it by passing test.py::subtest, so we can do the same.
2813
2814         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2815         (get_item_name): Made this global.
2816         (CollectRecorder.__init__): Receive the parameter to ignore.
2817         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2818         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2819         (collect): Add parameter to ignore.
2820         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2821         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2822         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2823         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2824         (WebDriverTestRunnerSelenium.run): Ditto.
2825         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2826         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2827         (WebDriverTestRunnerW3C.run): Ditto.
2828
2829 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2830
2831         User agent string override for navigator.userAgent should be site specific quirks
2832         https://bugs.webkit.org/show_bug.cgi?id=193950
2833
2834         Reviewed by Brent Fulgham.
2835
2836         Updated per the _WKWebsitePolicies rename.
2837
2838         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2839         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2840
2841 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2842
2843         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2844         https://bugs.webkit.org/show_bug.cgi?id=193941
2845
2846         Reviewed by Alex Christensen.
2847
2848         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2849         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2850         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2851         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2852         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2853         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2854         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2855         * TestWebKitAPI/Tests/WTF/Time.cpp:
2856         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2857         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2858         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2859         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2860
2861 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2862
2863         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2864
2865         * Scripts/webkitpy/common/config/contributors.json:
2866
2867 2019-01-28  Andy Estes  <aestes@apple.com>
2868
2869         [watchOS] Enable Parental Controls content filtering
2870         https://bugs.webkit.org/show_bug.cgi?id=193939
2871         <rdar://problem/46641912>
2872
2873         Reviewed by Ryosuke Niwa.
2874
2875         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2876
2877 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2878
2879         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2880         <https://webkit.org/b/193884>
2881
2882         Reviewed by Jiewen Tan.
2883
2884         * Scripts/webkitpy/style/checkers/cpp.py:
2885         (check_language): Add LocalAuthentication to
2886         `frameworks_with_soft_links`.
2887
2888 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2889
2890         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2891         https://bugs.webkit.org/show_bug.cgi?id=193891
2892
2893         Reviewed by Ross Kirsling.
2894
2895         There were three problems in window sizes of WebView and the host window.
2896         1. The sizes of pixel image output were incorrect.
2897         2. The host window is going to appear after window.resize was invoked.
2898         3. window.resize resized only the host window, not WebView.
2899
2900         This change solves them with a following approach.
2901         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2902         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2903            as well as DumpRenderTree in order to match the client area and the window area.
2904         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2905         d. PlatformWebView::setWindowFrame changes both window sizes.
2906         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2907
2908         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2909         (WTR::PlatformWebView::PlatformWebView): Create the host window
2910         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2911         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2912         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2913
2914 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2915
2916         [ews-app] Add method to save Step data to database
2917         https://bugs.webkit.org/show_bug.cgi?id=193890
2918
2919         Reviewed by Lucas Forschler.
2920
2921         * BuildSlaveSupport/ews-app/ews/models/step.py:
2922         (Step.save_step): Method to save step data.
2923         (Step.update_step): Method to update step data.
2924         (Step.get_existing_step): Method to fetch existing step from database.
2925         (Step.is_valid_result): Method to validate valid step result.
2926
2927 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2928
2929         [ews-app] Add method to save Build data to database
2930         https://bugs.webkit.org/show_bug.cgi?id=193735
2931
2932         Reviewed by Lucas Forschler.
2933
2934         * BuildSlaveSupport/ews-app/ews/models/build.py:
2935         (Build.save_build): Method to save build information to database.
2936         (Build.get_existing_build): Method to fetch existing build from database.
2937         (Build.is_valid_result): Method to validate build result.
2938         * BuildSlaveSupport/ews-app/ews/common/util.py:
2939         (is_valid_int_id): Method to validate valid id.
2940
2941 2019-01-28  Chris Dumez  <cdumez@apple.com>
2942
2943         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2944         https://bugs.webkit.org/show_bug.cgi?id=193915
2945         <rdar://problem/47560907>
2946
2947         Reviewed by Alex Christensen.
2948
2949         Add API test coverage.
2950
2951         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2952
2953 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2954
2955         [ews-app] Rename id variables
2956         https://bugs.webkit.org/show_bug.cgi?id=193883
2957
2958         Reviewed by Lucas Forschler.
2959
2960         * BuildSlaveSupport/ews-app/ews/models/build.py:
2961         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2962         * BuildSlaveSupport/ews-app/ews/models/step.py:
2963         * BuildSlaveSupport/ews-app/ews/urls.py:
2964         * BuildSlaveSupport/ews-app/ews/views/patch.py:
2965         * BuildSlaveSupport/ews-app/ews/views/results.py:
2966         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2967
2968 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2969
2970         [ews-app] Allow certain fields to be empty
2971         https://bugs.webkit.org/show_bug.cgi?id=193892
2972
2973         Reviewed by Lucas Forschler.
2974
2975         * BuildSlaveSupport/ews-app/ews/models/build.py:
2976         * BuildSlaveSupport/ews-app/ews/models/step.py:
2977
2978 2019-01-28  Rob Buis  <rbuis@igalia.com>
2979
2980         Update MIME type parser
2981         https://bugs.webkit.org/show_bug.cgi?id=180526
2982
2983         Reviewed by Frédéric Wang.
2984
2985         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2986         (TestWebKitAPI::TEST):
2987
2988 2019-01-28  Zalan Bujtas  <zalan@apple.com>
2989
2990         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
2991         https://bugs.webkit.org/show_bug.cgi?id=193896
2992
2993         Reviewed by Antti Koivisto.
2994
2995         * LayoutReloaded/misc/LFC-passing-tests.txt:
2996
2997 2018-12-15  Darin Adler  <darin@apple.com>
2998
2999         Replace many uses of String::format with more type-safe alternatives
3000         https://bugs.webkit.org/show_bug.cgi?id=192742
3001
3002         Reviewed by Mark Lam.
3003
3004         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3005         (WTR::cacheTestRunnerCallback): Use makeString.
3006         * WebKitTestRunner/TestController.cpp:
3007         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3008         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3009
3010 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3011
3012         Use a load optimizer for some sites
3013         https://bugs.webkit.org/show_bug.cgi?id=193881
3014         <rdar://problem/46325455>
3015
3016         Reviewed by Brent Fulgham.
3017
3018         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3019         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3020
3021 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3022
3023         AX: Introduce a static accessibility tree
3024         https://bugs.webkit.org/show_bug.cgi?id=193348
3025         <rdar://problem/47203295>
3026
3027         Reviewed by Ryosuke Niwa.
3028
3029         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3030
3031 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3032
3033         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3034         https://bugs.webkit.org/show_bug.cgi?id=193867
3035
3036         Reviewed by Antti Koivisto.
3037
3038         * LayoutReloaded/misc/LFC-passing-tests.txt:
3039
3040 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3041
3042         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3043         https://bugs.webkit.org/show_bug.cgi?id=193865
3044
3045         Reviewed by Antti Koivisto.
3046
3047         * LayoutReloaded/misc/LFC-passing-tests.txt:
3048
3049 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3050
3051         Need a mechanism to override navigator.userAgent
3052         https://bugs.webkit.org/show_bug.cgi?id=193762
3053         <rdar://problem/47504939>
3054
3055         Reviewed by Brent Fulgham.
3056
3057         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3058
3059         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3060         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3061         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3062
3063 2019-01-25  Dean Jackson  <dino@apple.com>
3064
3065         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3066         https://bugs.webkit.org/show_bug.cgi?id=193831
3067         <rdar://problem/47399263>
3068
3069         Reviewed by Chris Dumez.
3070
3071         Two new tests that exercise cross-origin and same-origin System
3072         Previews.
3073
3074         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3075
3076 2019-01-25  Keith Rollin  <krollin@apple.com>
3077
3078         Update Xcode projects with "Check .xcfilelists" build phase
3079         https://bugs.webkit.org/show_bug.cgi?id=193790
3080         <rdar://problem/47201374>
3081
3082         Reviewed by Alex Christensen.
3083
3084         Support for XCBuild includes specifying inputs and outputs to various
3085         Run Script build phases. These inputs and outputs are specified as
3086         .xcfilelist files. Once created, these .xcfilelist files need to be
3087         kept up-to-date. In order to check that they are up-to-date or not,
3088         add an Xcode build step that invokes an external script that performs
3089         the checking. If the .xcfilelists are found to be out-of-date, update
3090         them, halt the build, and instruct the developer to restart the build
3091         with up-to-date files.
3092
3093         At this time, the checking and regenerating is performed only if the
3094         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3095         who want to use this facility can set this variable and test out the
3096         checking/regenerating. Once it seems like there are no egregious
3097         issues that upset a developer's workflow, we'll unconditionally enable
3098         this facility.
3099
3100         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3101         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3102         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3103         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3104
3105 2019-01-25  Keith Rollin  <krollin@apple.com>
3106
3107         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3108         https://bugs.webkit.org/show_bug.cgi?id=193781
3109         <rdar://problem/47201153>
3110
3111         Reviewed by Alex Christensen.
3112
3113         Part of generating the .xcfilelists used as part of adopting XCBuild
3114         includes running `make DerivedSources.make` from a standalone script.
3115         It’s important for this invocation to have the same environment as
3116         when the actual build invokes `make DerivedSources.make`. If the
3117         environments are different, then the two invocations will provide
3118         different results. In order to get the same environment in the
3119         standalone script, have the script launch xcodebuild targeting the
3120         "Apply Configuration to XCFileLists" build target, which will then
3121         re-invoke our standalone script. The script is now running again, this
3122         time in an environment with all workspace, project, target, xcconfig
3123         and other environment variables established.
3124
3125         The "Apply Configuration to XCFileLists" build target accomplishes
3126         this task via a small embedded shell script that consists only of:
3127
3128             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3129
3130         The process that invokes "Apply Configuration to XCFileLists" first
3131         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3132         evaluated and exports it into the shell environment. When xcodebuild
3133         is invoked, it inherits the value of this variable and can `eval` the
3134         contents of that variable. Our external standalone script can then set
3135         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3136         of command-line parameters needed to restart itself in the appropriate
3137         state.
3138
3139         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3140         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3141
3142 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3143
3144         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3145         https://bugs.webkit.org/show_bug.cgi?id=193802
3146         <rdar://problem/46010580>
3147
3148         Reviewed by Andy Estes.
3149
3150         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3151         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3152         (TEST):
3153
3154 2019-01-25  Daniel Bates  <dabates@apple.com>
3155
3156         [iOS] uiController.keyDown() does not translate Control modified key
3157         https://bugs.webkit.org/show_bug.cgi?id=192898
3158
3159         Reviewed by Wenson Hsieh.
3160
3161         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3162         key translation, as applicable. Among other cases, key translation occurs when performing
3163         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3164         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3165         human pressing down and releasing key(s) using a hardware keyboard.
3166
3167         * WebKitTestRunner/ios/HIDEventGenerator.h:
3168         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3169         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3170
3171         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3172         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3173         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3174         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3175         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3176         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3177         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3178         (-[HIDEventGenerator longPress:completionBlock:]):
3179         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3180         Update code for above renaming.
3181
3182         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3183         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3184
3185         (-[HIDEventGenerator keyDown:]): Added.
3186         (-[HIDEventGenerator keyUp:]): Added.
3187         (-[HIDEventGenerator keyPress:completionBlock:]):
3188         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3189         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3190         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3191         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3192         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3193         (WTR::parseModifier): Deleted.
3194
3195 2019-01-25  Keith Rollin  <krollin@apple.com>
3196
3197         Complete the implementation of generate-xcfilelists
3198         https://bugs.webkit.org/show_bug.cgi?id=193782
3199
3200         Reviewed by Alex Christensen.
3201
3202         A preliminary version of generate-xcfilelists was added in r238008.
3203         This patch updates that script in order to:
3204
3205         - Support checking of .xcfilelists
3206         - Perform better execution of `make DerivedSources.make` by
3207           relaunching generate-xcfilelists under xcodebuild
3208         - Support incremental generation and checking of .xcfilelists
3209         - Support supplementary .xcfilelists files from WebKitAdditions
3210         - Support being wrapped by parallel version of generate-xcfilelists in
3211           Internal that adds support for (re)generating WebKit projects in
3212           that repo.
3213         - Support builds that have been performed in WebKitBuild as well as
3214           ~/Library/Developer/code/DerivedData
3215         - Increase robustness and debugging facilities.
3216
3217         * Scripts/generate-xcfilelists:
3218
3219 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3220
3221         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3222         https://bugs.webkit.org/show_bug.cgi?id=193297
3223         <rdar://problem/47158841>
3224
3225         Unreviewed test case fix.
3226
3227         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3228         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3229
3230         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3231         (TEST):
3232
3233 2019-01-25  Keith Rollin  <krollin@apple.com>
3234
3235         Update existing .xcfilelists
3236         https://bugs.webkit.org/show_bug.cgi?id=193791
3237         <rdar://problem/47201706>
3238
3239         Reviewed by Alex Christensen.
3240
3241         Many .xcfilelist files were added in r238824 in order to support
3242         XCBuild. Update these with recent changes to the set of build files
3243         and with the current generate-xcfilelist script.
3244
3245         * DumpRenderTree/DerivedSources-input.xcfilelist:
3246         * DumpRenderTree/DerivedSources-output.xcfilelist:
3247         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3248         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3249
3250 2019-01-25  Keith Rollin  <krollin@apple.com>
3251
3252         Fix missing dependencies in extract-dependencies-from-makefile
3253         https://bugs.webkit.org/show_bug.cgi?id=193783
3254         <rdar://problem/47201571>
3255
3256         Reviewed by Alex Christensen.
3257
3258         The extract-dependencies-from-makefile script generates .xcfilelists
3259         for XCBuild by invoking a makefile in --debug mode, parsing the
3260         dependency information in the output, and extracting information
3261         regarding targets and dependents. However, the way `make` emits this
3262         dependency information is not rigorous, and so we need to determine
3263         what lines to look for and parse by trial and error. This approach
3264         didn't coriginally atch all the information we needed to collect, so
3265         update the script to look for the additional lines we now know to look
3266         for.
3267
3268         * Scripts/extract-dependencies-from-makefile:
3269         (Parser):
3270         (Parser.addTarget):
3271         (Parser.addPrereq):
3272         (Parser.doParse):
3273
3274 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3275
3276         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3277         https://bugs.webkit.org/show_bug.cgi?id=193297
3278         <rdar://problem/47158841>
3279
3280         Reviewed by Alex Christensen.
3281
3282         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3283             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3284         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3285         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3286         activating the message used to trigger the callback when it is set.
3287
3288 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3289
3290         WKWebView.goBack should reload if there is a safe browsing warning
3291         https://bugs.webkit.org/show_bug.cgi?id=193805
3292         <rdar://problem/46908216>
3293
3294         Reviewed by Geoff Garen.
3295
3296         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3297         (+[Simple3LookupContext sharedLookupContext]):
3298         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3299         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3300         (TEST):
3301
3302 2019-01-25  Chris Dumez  <cdumez@apple.com>
3303
3304         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3305         https://bugs.webkit.org/show_bug.cgi?id=193788
3306         <rdar://problem/47531231>
3307
3308         Reviewed by Alex Christensen.
3309
3310         Add API test coverage.
3311
3312         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3313         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3314
3315 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3316
3317         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3318         https://bugs.webkit.org/show_bug.cgi?id=193771
3319
3320         Unreviewed infrastructure fix.
3321
3322         * Scripts/webkitpy/port/darwin.py:
3323         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3324
3325 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3326
3327         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3328
3329 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3330
3331         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3332
3333         * Scripts/webkitpy/common/config/contributors.json:
3334
3335 2019-01-25  Chris Dumez  <cdumez@apple.com>
3336
3337         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3338         https://bugs.webkit.org/show_bug.cgi?id=193779
3339         <rdar://problem/46170903>
3340
3341         Reviewed by Antti Koivisto.
3342
3343         Add API test that quickly navigates forward to a previous process without waiting for it to
3344         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3345         the process' previous page when reconnecting the it for the forward navigation.
3346
3347         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3348
3349 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3350
3351         Need a way for JavaScript (or bundle) code to participate in undo
3352         https://bugs.webkit.org/show_bug.cgi?id=190009
3353         <rdar://problem/44807048>
3354
3355         Reviewed by Ryosuke Niwa.
3356
3357         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3358         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3359
3360         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3361         (WTR::UIScriptController::lastUndoLabel const):
3362         (WTR::UIScriptController::firstRedoLabel const):
3363         (WTR::UIScriptController::platformUndoManager const):
3364         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3365         (WTR::UIScriptController::lastUndoLabel const):
3366         (WTR::UIScriptController::firstRedoLabel const):
3367         (WTR::UIScriptController::platformUndoManager const):
3368         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3369         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3370         (WTR::UIScriptController::lastUndoLabel const):
3371         (WTR::UIScriptController::firstRedoLabel const):
3372         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3373         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3374         (WTR::UIScriptController::lastUndoLabel const):
3375         (WTR::UIScriptController::firstRedoLabel const):
3376         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3377         (WTR::UIScriptController::platformUndoManager const):
3378         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3379         (WTR::UIScriptController::platformUndoManager const):
3380
3381 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3382
3383         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3384         https://bugs.webkit.org/show_bug.cgi?id=193824
3385
3386         Reviewed by Antti Koivisto.
3387
3388         * LayoutReloaded/misc/LFC-passing-tests.txt:
3389
3390 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3391
3392         Update macOS JSC bot configurations
3393         https://bugs.webkit.org/show_bug.cgi?id=193739
3394
3395         Reviewed by Alexey Proskuryakov.
3396
3397         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3398         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3399         (BubbleQueueServer): Move JSC EWS to Mojave section.
3400         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3401         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3402         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3403
3404 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3405
3406         [Win][WebKitTestRunner] Implement EventSenderProxy
3407         https://bugs.webkit.org/show_bug.cgi?id=193755
3408
3409         Reviewed by Don Olmstead.
3410
3411         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3412         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3413         (WTR::EventSenderProxy::dispatchMessage):
3414         (WTR::EventSenderProxy::EventSenderProxy):
3415         (WTR::EventSenderProxy::mouseDown):
3416         (WTR::EventSenderProxy::mouseUp):
3417         (WTR::EventSenderProxy::mouseMoveTo):
3418         (WTR::EventSenderProxy::mouseScrollBy):
3419         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3420
3421 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3422
3423         Unreviewed fix for API test failure after r240437.
3424
3425         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3426
3427         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3428
3429 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3430
3431         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3432         https://bugs.webkit.org/show_bug.cgi?id=193787
3433         <rdar://problem/47497634>
3434
3435         Reviewed by Alexey Proskuryakov.
3436
3437         * Scripts/webkitdirs.pm:
3438         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3439
3440 2019-01-24  Truitt Savell  <tsavell@apple.com>
3441
3442         Unreviewed, rolling out r240446.
3443
3444         Casued 5 API failures
3445
3446         Reverted changeset:
3447
3448         "Activate the WebResourceLoadStatisticsStore in the
3449         NetworkProcess and deactivate it in the UIProcess."
3450         https://bugs.webkit.org/show_bug.cgi?id=193297
3451         https://trac.webkit.org/changeset/240446
3452
3453 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3454
3455         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3456         https://bugs.webkit.org/show_bug.cgi?id=193741
3457         <rdar://problem/47135030>
3458
3459         Reviewed by Antti Koivisto and Simon Fraser.
3460
3461         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3462         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3463         (TestWebKitAPI::TEST):
3464
3465 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3466
3467         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3468         https://bugs.webkit.org/show_bug.cgi?id=193297
3469         <rdar://problem/47158841>
3470
3471         Reviewed by Alex Christensen.
3472
3473         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3474         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3475         activating the message used to trigger the callback when it is set.
3476
3477 2019-01-24  John Wilander  <wilander@apple.com>
3478
3479         Add Ad Click Attribution as an internal/experimental feature
3480         https://bugs.webkit.org/show_bug.cgi?id=193685
3481         <rdar://problem/47450399>
3482
3483         Reviewed by Brent Fulgham.
3484
3485         Added test option adClickAttributionEnabled.
3486
3487         * DumpRenderTree/TestOptions.cpp:
3488         (TestOptions::TestOptions):
3489         * DumpRenderTree/TestOptions.h:
3490         * DumpRenderTree/mac/DumpRenderTree.mm:
3491         (setWebPreferencesForTestOptions):
3492
3493 2019-01-24  Antti Koivisto  <antti@apple.com>
3494
3495         [PSON] Flash on back navigation on Mac
3496         https://bugs.webkit.org/show_bug.cgi?id=193716
3497         <rdar://problem/47148458>
3498
3499         Reviewed by Chris Dumez.
3500
3501         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3502
3503         Closing of the previous page is delayed so waiting for didFinishNavigation is
3504         not sufficient to guarantee we have received all the messages. Wait for them.
3505
3506 2019-01-24  Chris Dumez  <cdumez@apple.com>
3507
3508         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3509         https://bugs.webkit.org/show_bug.cgi?id=193761
3510         <rdar://problem/47456405>
3511
3512         Reviewed by Alex Christensen.
3513
3514         Add API test coverage.
3515
3516         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3517
3518 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3519
3520         webkitpy: Missing PID in crashlog name should not be fatal
3521         https://bugs.webkit.org/show_bug.cgi?id=193771
3522
3523         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3524         of raising an exception.
3525
3526         Reviewed by Lucas Forschler.
3527
3528         * Scripts/webkitpy/port/darwin.py:
3529         (DarwinPort._merge_crash_logs):
3530
3531 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3532
3533         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3534         https://bugs.webkit.org/show_bug.cgi?id=193746
3535
3536         Reviewed by Youenn Fablet.
3537
3538         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3539         so we'd best just not call it.
3540
3541         * Scripts/webkitpy/w3c/test_exporter.py:
3542         (WebPlatformTestExporter.create_branch_with_patch):
3543
3544 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3545
3546         Move FileSystem to WTF
3547         https://bugs.webkit.org/show_bug.cgi?id=193602
3548
3549         Reviewed by Yusuke Suzuki.
3550
3551         * DumpRenderTree/win/DumpRenderTree.cpp:
3552         * TestWebKitAPI/CMakeLists.txt:
3553         * TestWebKitAPI/PlatformGTK.cmake:
3554         * TestWebKitAPI/PlatformJSCOnly.cmake:
3555         * TestWebKitAPI/PlatformPlayStation.cmake:
3556         * TestWebKitAPI/PlatformWPE.cmake:
3557         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3558         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3559         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3560         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3561         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3562         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3563         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3564         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3565         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3566         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3567
3568 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3569
3570         [WPE] Remove hard dependency on subprocess32 for the API tests
3571
3572         Rubber-stamped by Carlos Garcia Campos.
3573
3574         * glib/api_test_runner.py:
3575         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3576         its presence only when running WPEQt tests.
3577
3578 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3579
3580         [GLIB] Expose JavaScriptCore options in GLib public API
3581         https://bugs.webkit.org/show_bug.cgi?id=188742
3582
3583         Reviewed by Michael Catanzaro.
3584
3585         Add a test for the new API.
3586
3587         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3588         (testsJSCOptions):
3589         (main):
3590
3591 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3592
3593         [GTK][WPE] Support JPEG 2000 images
3594         https://bugs.webkit.org/show_bug.cgi?id=186272
3595
3596         Reviewed by Žan Doberšek.
3597
3598         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3599
3600         * gtk/jhbuild.modules:
3601         * wpe/jhbuild.modules:
3602
3603 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3604
3605         check-webkit-style should warn when using soft-linking macros in a header
3606         <https://webkit.org/b/193750>
3607
3608         Reviewed by Darin Adler.
3609
3610         * Scripts/webkitpy/style/checkers/cpp.py:
3611         (check_language): Add softlink/header check by refactoring the
3612         softlink/framework check.
3613         (CppChecker): Enable softlink/header check by default.
3614         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3615         (CppStyleTest.test_softlink_framework): Rename from
3616         CppStyleTest.test_softlink() and change test framework name in
3617         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3618         files. Set file_name for macros that only appear in headers.
3619         (CppStyleTest.test_softlink_header): Add tests for using
3620         soft-link macros in headers.
3621
3622 2019-01-23  Chris Dumez  <cdumez@apple.com>
3623
3624         Deprecate API to limit the maximum number of WebProcesses
3625         https://bugs.webkit.org/show_bug.cgi?id=193725
3626         <rdar://problem/47464879>
3627
3628         Reviewed by Geoff Garen.
3629
3630         Update existing API tests to stop using deprecated API.
3631
3632         * MiniBrowser/mac/AppDelegate.m:
3633         (defaultConfiguration):
3634         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3635         (TestWebKitAPI::TEST):
3636         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3637         (TestWebKitAPI::TEST):
3638         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3639         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3640         (TEST):
3641         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3642         (TEST):
3643
3644 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3645
3646         [ews-app] Rename ews model buildermappings to buildermapping
3647         https://bugs.webkit.org/show_bug.cgi?id=193729
3648
3649         Reviewed by Lucas Forschler.
3650
3651         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3652         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3653         * BuildSlaveSupport/ews-app/ews/models/__init__.py: Ditto.
3654
3655 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3656
3657         [ews-app] Rename ews model steps to step
3658         https://bugs.webkit.org/show_bug.cgi?id=193697
3659
3660         Reviewed by Lucas Forschler.
3661
3662         * BuildSlaveSupport/ews-app/ews/models/step.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/steps.py.
3663         (Step): Renamed Steps to Step.
3664
3665 2019-01-23  Sihui Liu  <sihui_liu@apple.com>
3666
3667         Clean up IndexedDB files between tests
3668         https://bugs.webkit.org/show_bug.cgi?id=192796
3669         <rdar://problem/46824999>
3670
3671         Reviewed by Geoffrey Garen.
3672
3673         * DumpRenderTree/mac/DumpRenderTree.mm:
3674         (runTest):
3675         * WebKitTestRunner/TestController.cpp:
3676         (WTR::TestController::resetStateToConsistentValues):
3677         (WTR::RemoveAllIndexedDatabasesCallbackContext::RemoveAllIndexedDatabasesCallbackContext):
3678         (WTR::RemoveAllIndexedDatabasesCallback):
3679         (WTR::TestController::ClearIndexedDatabases):
3680         * WebKitTestRunner/TestController.h:
3681         * WebKitTestRunner/TestInvocation.cpp:
3682         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3683
3684 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3685
3686         [ews-app] Rename ews model Builds to Build
3687         https://bugs.webkit.org/show_bug.cgi?id=193695
3688
3689         Reviewed by Lucas Forschler.
3690
3691         * BuildSlaveSupport/ews-app/ews/models/build.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/builds.py.
3692         (Build): Renamed Builds to Build.
3693
3694 2019-01-23  Jonathan Bedard  <jbedard@apple.com>
3695
3696         webkitpy: Wait longer when launching WebKitTestRunner
3697         https://bugs.webkit.org/show_bug.cgi?id=193734
3698
3699         Reviewed by Aakash Jain.
3700
3701         * Scripts/webkitpy/port/simulator_process.py:
3702         (SimulatorProcess._start): Increase timeout from 6 seconds to 15 seconds.