7a511d57cb0d062dc4b22733821451ea42356055
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-26  Philippe Normand  <pnormand@igalia.com>
2
3         [Flatpak SDK] Pass all the arguments of build-webkit to webkit-flatpak
4         https://bugs.webkit.org/show_bug.cgi?id=209558
5
6         Reviewed by Žan Doberšek.
7
8         When using flatpak some of the arguments we pass to build-webkit
9         are not meant to be used by that script but by webkit-flatpak. However we are
10         not passing all of them to webkit-flatpak but just the configuration ones
11         (port, release/debug...). This means that all the arguments that configure the
12         behaviour of webkit-flatpak are lost.
13
14         * Scripts/webkitdirs.pm:
15         (runInFlatpak): Filter-out Flatpak SDK-specific arguments to a
16         separate array, passed to webkit-flatpak.
17
18 2020-03-26  Commit Queue  <commit-queue@webkit.org>
19
20         Unreviewed, reverting r259035.
21         https://bugs.webkit.org/show_bug.cgi?id=209597
22
23         broke windows layout-tests (Requested by aakashjain on
24         #webkit).
25
26         Reverted changeset:
27
28         "[Win] lld-link: error: /manifestdependency: is not allowed in
29         .drectve"
30         https://bugs.webkit.org/show_bug.cgi?id=204831
31         https://trac.webkit.org/changeset/259035
32
33 2020-03-26  Philippe Normand  <pnormand@igalia.com>
34
35         [Flatpak SDK] update-webkitgtk-libs fails
36         https://bugs.webkit.org/show_bug.cgi?id=209546
37
38         Reviewed by Žan Doberšek.
39
40         Simplify the code a bit, add a `--assumeyes` argument to the
41         `flatpak update` command to make it non-interactive and improve
42         error handling/reporting a bit as well.
43
44         * flatpak/flatpakutils.py:
45         (FlatpakObject.flatpak):
46         (WebkitFlatpak.main):
47         (WebkitFlatpak.run):
48         (WebkitFlatpak.install_all):
49         (WebkitFlatpak.update_all): Deleted.
50
51 2020-03-26  Philippe Normand  <pnormand@igalia.com>
52
53         [Flatpak SDK] Crash post-mortem debugging is broken
54         https://bugs.webkit.org/show_bug.cgi?id=209537
55
56         Reviewed by Žan Doberšek.
57
58         webkit-flatpak --gdb now properly launches gdb to inspect the last
59         crash reported to coredumpctl. The -m argument can be used to
60         select another crash dump.
61
62         * flatpak/flatpakutils.py:
63         (WebkitFlatpak.clean_args):
64         (WebkitFlatpak.run_in_sandbox):
65         (WebkitFlatpak.run_gdb):
66
67 2020-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
68
69         [Win] lld-link: error: /manifestdependency: is not allowed in .drectve
70         https://bugs.webkit.org/show_bug.cgi?id=204831
71
72         Reviewed by Ross Kirsling.
73
74         * TestWebKitAPI/win/main.cpp:
75         * win/DLLLauncher/DLLLauncherMain.cpp:
76
77 2020-03-25  Alexey Shvayka  <shvaikalesh@gmail.com>
78
79         Invalid numeric and named references should be early syntax errors
80         https://bugs.webkit.org/show_bug.cgi?id=178175
81
82         Reviewed by Ross Kirsling.
83
84         Removes FIXME as YarrParser is correct not to throw errors as it is
85         parsing in non-Unicode mode. Also adds a few named groups tests.
86
87         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
88
89 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
90
91         [Timeline] A better default get label function, which fit the assumpation the label is always a string
92         https://bugs.webkit.org/show_bug.cgi?id=209567
93
94         Reviewed by Jonathan Bedard.
95
96         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
97
98 2020-03-25  Zhifei Fang  <zhifei_fang@apple.com>
99
100         [Timeline] Fix the out of bound dot index
101         https://bugs.webkit.org/show_bug.cgi?id=209492
102
103         Reviewed by Jonathan Bedard.
104
105         * resultsdbpy/resultsdbpy/view/static/library/js/components/TimelineComponents.js:
106         (Timeline.CanvasSeriesComponent):
107
108 2020-03-25  Daniel Bates  <dabates@apple.com>
109
110         Element context character rects may be in wrong coordinate system
111         https://bugs.webkit.org/show_bug.cgi?id=209493
112         <rdar://problem/60840261>
113
114         Reviewed by Wenson Hsieh.
115
116         Add some tests.
117
118         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
119         (TEST):
120
121 2020-03-25  Doug Kelly  <dougk@apple.com>
122
123         Unreviewed, add new committer to contributors.json
124
125         * Scripts/webkitpy/common/config/contributors.json:
126
127 2020-03-25  Frank Yang  <guowei_yang@apple.com>
128
129         Unprefix -webkit-text-orientation
130         https://bugs.webkit.org/show_bug.cgi?id=196139
131
132         Reviewed by Myles C. Maxfield.
133
134         This change is made to add the extra flag "related-property" in CSSProperty.json
135         in the jsonchecker so that the jsonchecker would not complain about unrecognized key
136
137         * Scripts/webkitpy/style/checkers/jsonchecker.py: added check for related-property
138         (JSONCSSPropertiesChecker.check_codegen_properties): 
139
140 2020-03-25  Aakash Jain  <aakash_jain@apple.com>
141
142         [ews] commit-queue should comment on bug if it fails to find any modified ChangeLog
143         https://bugs.webkit.org/show_bug.cgi?id=209550
144
145         Reviewed by Jonathan Bedard.
146
147         * BuildSlaveSupport/ews-build/steps.py:
148         (FindModifiedChangeLogs): Set haltOnFailure to false.
149         (FindModifiedChangeLogs.getResultSummary):
150         (FindModifiedChangeLogs.evaluateCommand): Add build steps to comment on bug and set cq- on patch appropriately.
151         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
152
153 2020-03-25  Aakash Jain  <aakash_jain@apple.com>
154
155         [ews] status-bubble should link to buildbot queue while waiting in queue
156         https://bugs.webkit.org/show_bug.cgi?id=209543
157
158         Reviewed by Jonathan Bedard.
159
160         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
161         (StatusBubble._build_bubble): Link to buildbot queue whil patch is waiting in queue.
162         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
163         (Buildbot.update_icons_for_queues_mapping): Generate the mapping for shortname to full queue name.
164
165 2020-03-25  Ting-Wei Lan  <lantw44@gmail.com>
166
167         [GTK] Add user agent quirk for auth.mayohr.com
168         https://bugs.webkit.org/show_bug.cgi?id=209378
169
170         Reviewed by Michael Catanzaro.
171
172         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
173         (TestWebKitAPI::assertUserAgentForURLHasNoSafariVersionQuirk):
174         (TestWebKitAPI::TEST):
175
176 2020-03-24  Daniel Bates  <dabates@apple.com>
177
178         Unreviewed, reverting r258945.
179
180         Revert change that broke API tests while I investigate
181         offline.
182
183         Reverted changeset:
184
185         "Element context character rects may be in wrong coordinate
186         system"
187         https://bugs.webkit.org/show_bug.cgi?id=209493
188         https://trac.webkit.org/changeset/258945
189
190 2020-03-24  Jiewen Tan  <jiewen_tan@apple.com>
191
192         Unreviewed, skips a test for iOS
193
194         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
195
196 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
197
198         results.webkit.org: Documentation for uncollapsed failure endpoints is wrong
199         https://bugs.webkit.org/show_bug.cgi?id=209496
200
201         Rubber-stamped by Aakash Jain.
202
203         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
204
205 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
206
207         results.webkit.org: Filter suite results by expectation by default
208         https://bugs.webkit.org/show_bug.cgi?id=209500
209
210         Rubber-stamped by Aakash Jain.
211
212         * resultsdbpy/resultsdbpy/view/static/js/timeline.js: Allow the Legend constructor
213         to set a willFilterExpected default.
214         * resultsdbpy/resultsdbpy/view/templates/suite_results.html:
215
216 2020-03-24  Per Arne Vollan  <pvollan@apple.com>
217
218         [Cocoa] Fix launch time regression with CF prefs direct mode enabled
219         https://bugs.webkit.org/show_bug.cgi?id=209244
220
221         Reviewed by Darin Adler.
222
223         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
224         (TEST):
225         (sharedInstanceMethodOverride):
226
227 2020-03-24  Jonathan Bedard  <jbedard@apple.com>
228
229         results.webkit.org: Correct UUID capitalization in documentation
230         https://bugs.webkit.org/show_bug.cgi?id=209497
231
232         Reviewed by Aakash Jain.
233
234         * resultsdbpy/resultsdbpy/view/templates/documentation.html:
235
236 2020-03-24  Aakash Jain  <aakash_jain@apple.com>
237
238         [ews] commit-queue should comment on bug if it fails to create git commit
239         https://bugs.webkit.org/show_bug.cgi?id=209487
240
241         Reviewed by Jonathan Bedard.
242
243         * BuildSlaveSupport/ews-build/steps.py:
244         (CreateLocalGITCommit):
245         (CreateLocalGITCommit.start):
246         (CreateLocalGITCommit.evaluateCommand):
247         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
248
249 2020-03-24  Daniel Bates  <dabates@apple.com>
250
251         Element context character rects may be in wrong coordinate system
252         https://bugs.webkit.org/show_bug.cgi?id=209493
253         <rdar://problem/60840261>
254
255         Reviewed by Wenson Hsieh.
256
257         Add some tests.
258
259         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
260         (TEST):
261
262 2020-03-24  Aakash Jain  <aakash_jain@apple.com>
263
264         [ews] position in queue shown in status-bubble is larger than actual position
265         https://bugs.webkit.org/show_bug.cgi?id=209481
266
267         Reviewed by Jonathan Bedard.
268
269         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
270         (StatusBubble._queue_position): Use created timestamp instead of modified.
271
272 2020-03-24  Daniel Bates  <dabates@apple.com>
273
274         [iOS][WK2] Set text trait isSingleLineDocument
275         https://bugs.webkit.org/show_bug.cgi?id=209391
276         <rdar://problem/60705870>
277
278         Reviewed by Darin Adler.
279
280         Add a test.
281
282         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
283         (TestWebKitAPI::TEST):
284         * TestWebKitAPI/ios/UIKitSPI.h: Expose more SPI.
285
286 2020-03-24  Alex Christensen  <achristensen@webkit.org>
287
288         Unreviewed, reverting r258862.
289
290         SPI was not what was needed
291
292         Reverted changeset:
293
294         "Add SPI to move localStorage to a different domain"
295         https://bugs.webkit.org/show_bug.cgi?id=209260
296         https://trac.webkit.org/changeset/258862
297
298 2020-03-24  Chris Lord  <clord@igalia.com>
299
300         [GTK][WPE] WEB_PROCESS_CMD_PREFIX and others have stopped working
301         https://bugs.webkit.org/show_bug.cgi?id=209478
302
303         Make sure *_PROCESS_CMD_PREFIX variables are whitelisted in the Flatpak sandbox.
304
305         Reviewed by Philippe Normand.
306
307         * flatpak/flatpakutils.py:
308         (WebkitFlatpak.run_in_sandbox):
309
310 2020-03-23  Simon Fraser  <simon.fraser@apple.com>
311
312         [mac-wk1] fast/scrolling/arrow-key-scroll-in-rtl-document.html is a flaky timeout
313         https://bugs.webkit.org/show_bug.cgi?id=209427
314
315         Reviewed by Wenson Hsieh.
316         
317         0 => NULL
318
319         * DumpRenderTree/mac/DumpRenderTree.mm:
320         (invalidateAnyPreviousWaitToDumpWatchdog):
321
322 2020-03-23  Dean Jackson  <dino@apple.com>
323
324         webkitpy Git class must expose the repository URL
325         https://bugs.webkit.org/show_bug.cgi?id=209439
326         <rdar://problem/60792668>
327
328         Reviewed by Simon Fraser.
329
330         Some internal tools were relying on the svn_url() method
331         that was changed/removed in r258164. Add a replacement.
332
333         * Scripts/webkitpy/common/checkout/scm/git.py:
334         (Git.svn_repository_url):
335
336 2020-03-23  Alex Christensen  <achristensen@webkit.org>
337
338         Fix memory leak introduced in r257726
339         https://bugs.webkit.org/show_bug.cgi?id=208399
340
341         Reviewed by John Wilander.
342
343         * WebKitTestRunner/TestController.cpp:
344         (WTR::TestController::websiteDataStore):
345         We were leaking page configurations.
346
347 2020-03-23  John Wilander  <wilander@apple.com>
348
349         Add the capability to change all of a website's cookies to SameSite=Strict
350         https://bugs.webkit.org/show_bug.cgi?id=209369
351         <rdar://problem/60710690>
352
353         Reviewed by Alex Christensen and David Kilzer.
354
355         These changes add TestRunner function statisticsSetToSameSiteStrictCookies().
356
357         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
358         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
359         (WTR::InjectedBundle::didReceiveMessageToPage):
360         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
361         (WTR::TestRunner::statisticsSetToSameSiteStrictCookies):
362         (WTR::TestRunner::statisticsCallDidSetToSameSiteStrictCookiesCallback):
363         * WebKitTestRunner/InjectedBundle/TestRunner.h:
364         * WebKitTestRunner/TestController.cpp:
365         (WTR::TestController::setStatisticsToSameSiteStrictCookies):
366         * WebKitTestRunner/TestController.h:
367         * WebKitTestRunner/TestInvocation.cpp:
368         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
369         (WTR::TestInvocation::didSetToSameSiteStrictCookies):
370         * WebKitTestRunner/TestInvocation.h:
371
372 2020-03-23  Nikos Mouchtaris  <nmouchtaris@apple.com>
373
374         Uneviewed, added myself to contributors.json.
375
376         * Scripts/webkitpy/common/config/contributors.json:
377
378 2020-03-23  Daniel Bates  <dabates@apple.com>
379
380         Support inserting text or dictation alternative by simulating keyboard input
381         https://bugs.webkit.org/show_bug.cgi?id=209380
382         <rdar://problem/59445102>
383
384         Reviewed by Darin Adler.
385
386         Add tests to ensure that DOM events are dispatched on insertion when shouldSimulateKeyboardInput
387         is enabled.
388
389         I also added a convenience assertion function, EXPECT_NS_EQUAL, that can
390         compare NSObjects so long as they implement -isEqual and -description. I
391         make use of this to compare the actual array of fired DOM events types to
392         an expected array.
393
394         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
395         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
396         (TestWebKitAPI::shouldSimulateKeyboardInputOnTextInsertionOverride):
397         (TestWebKitAPI::TEST):
398         * TestWebKitAPI/cocoa/TestCocoa.h:
399         (TestWebKitAPI::Util::assertNSObjectsAreEqual): Added.
400         (EXPECT_NS_EQUAL): Added.
401         * TestWebKitAPI/ios/insert-text.html: Added.
402
403 2020-03-23  Kate Cheney  <katherine_cheney@apple.com>
404
405         Add checks for app-bound navigations when evaluating user style sheets
406         https://bugs.webkit.org/show_bug.cgi?id=209368
407         <rdar://problem/60204230>
408
409         Reviewed by Brent Fulgham.
410
411         Tested cases based on those in UserContentController.mm.
412
413         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
414         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
415         (expectScriptEvaluatesToColor):
416         (TEST):
417
418
419 2020-03-23  Alex Christensen  <achristensen@webkit.org>
420
421         Add SPI to move localStorage to a different domain
422         https://bugs.webkit.org/show_bug.cgi?id=209260
423         <rdar://problem/60285683>
424
425         Reviewed by Brady Eidson.
426
427         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
428         (TEST):
429
430 2020-03-23  youenn fablet  <youenn@apple.com>
431
432         Disable TestWebKitAPI.ProcessSwap.GetUserMediaCaptureState if getUserMedia is not supported
433         https://bugs.webkit.org/show_bug.cgi?id=209428
434
435         Reviewed by Jonathan Bedard.
436
437         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
438
439 2020-03-23  Chris Lord  <clord@igalia.com>
440
441         Add missing committer status to Chris Lord in contributors.json
442
443         Unreviewed
444
445         * Scripts/webkitpy/common/config/contributors.json:
446
447 2020-03-23  youenn fablet  <youenn@apple.com>
448
449         StringView::startsWith and String::startsWith do not treat null strings the same
450         https://bugs.webkit.org/show_bug.cgi?id=209273
451
452         Reviewed by Darin Adler.
453
454         * TestWebKitAPI/Tests/WTF/StringView.cpp:
455         (TestWebKitAPI::TEST):
456         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
457         (TestWebKitAPI::TEST):
458
459 2020-03-22  Antoine Quint  <graouts@apple.com>
460
461         DocumentTimeline / CSSTransition objects are leaking on CNN.com
462         https://bugs.webkit.org/show_bug.cgi?id=208069
463         <rdar://problem/59680143>
464
465         Reviewed by Simon Fraser, Geoffrey Garen and Darin Adler.
466
467         Add a test that checks that a ListHashSet containing RefPtr<> types correctly calls the destructor for those items when the assignment operator is used.
468
469         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
470         (TestWebKitAPI::ListHashSetReferencedItem::create):
471         (TestWebKitAPI::ListHashSetReferencedItem::ListHashSetReferencedItem):
472         (TestWebKitAPI::ListHashSetReferencedItem::~ListHashSetReferencedItem):
473         (TestWebKitAPI::FakeElementAnimationRareData::FakeElementAnimationRareData):
474         (TestWebKitAPI::FakeElementAnimationRareData::~FakeElementAnimationRareData):
475         (TestWebKitAPI::FakeElementAnimationRareData::collection):
476         (TestWebKitAPI::FakeElementAnimationRareData::setCollection):
477         (TestWebKitAPI::TEST):
478
479 2020-03-21  Michael Catanzaro  <mcatanzaro@gnome.org>
480
481         [GTK] Use ${PYTHON_EXECUTABLE} to run generate-gtkdoc
482         https://bugs.webkit.org/show_bug.cgi?id=208970
483
484         Reviewed by Konstantin Tokarev.
485
486         We are allowed to use /usr/bin/env in this script because it's not installed (so not
487         packaged). Therefore we can make the shebang compatible with FreeBSD in this particularl
488         case.
489
490         * gtkdoc/generate-gtkdoc:
491
492 2020-03-20  Jonathan Bedard  <jbedard@apple.com>
493
494         run-webkit-tests: Report MacCatalyst as a unique platform
495         https://bugs.webkit.org/show_bug.cgi?id=209361
496
497         Rubber-stamped by Aakash Jain.
498
499         * Scripts/webkitpy/port/mac.py:
500         (MacCatalystPort):
501         (MacCatalystPort.configuration_for_upload): Treat MacCatalyst as a separate platform from Mac.
502
503 2020-03-20  Alex Christensen  <achristensen@webkit.org>
504
505         CORS-disabling SPI introduced in r253978 should make responses non-opaque
506         https://bugs.webkit.org/show_bug.cgi?id=209351
507         <rdar://problem/60024850>
508
509         Reviewed by Chris Dumez.
510
511         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
512
513 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
514
515         commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue
516         https://bugs.webkit.org/show_bug.cgi?id=208938
517
518         Reviewed by Jonathan Bedard.
519
520         * BuildSlaveSupport/ews-build/steps.py:
521         (RunWebKitTests.doStepIf): Skip testing if patch already passed mac-wk2 tests.
522         (CheckPatchStatusOnEWSQueues): Build-step to check patch status on other queues.
523         (CheckPatchStatusOnEWSQueues.get_patch_status):
524         (CheckPatchStatusOnEWSQueues.start):
525         * BuildSlaveSupport/ews-build/steps_unittest.py:
526         (test_skip_for_mac_wk2_passed_patch_on_commit_queue): Added unit-tests.
527         * BuildSlaveSupport/ews-build/factories.py: Added build-step to check the patch status on other queues.
528         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
529         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added the new step status to STEPS_TO_HIDE.
530
531 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
532
533         [ews] Better organize patch status api data
534         https://bugs.webkit.org/show_bug.cgi?id=209342
535
536         Reviewed by Jonathan Bedard.
537
538         * BuildSlaveSupport/ews-app/ews/views/status.py:
539         (Status._build_status):
540         (Status._build_statuses_for_patch): Updated to return dictionary instead of list.
541         (Status.get): Remove safe=false now that we are returning a dictionary.
542
543 2020-03-20  Tim Horton  <timothy_horton@apple.com>
544
545         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
546         https://bugs.webkit.org/show_bug.cgi?id=209307
547
548         Reviewed by Andy Estes.
549
550         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
551
552 2020-03-20  Jacob Uphoff  <jacob_uphoff@apple.com>
553
554         Unreviewed, reverting r258748.
555
556         This commit broke the Catalina build
557
558         Reverted changeset:
559
560         "Upstream a variety of Cocoa-platform HAVE and ENABLE macros"
561         https://bugs.webkit.org/show_bug.cgi?id=209307
562         https://trac.webkit.org/changeset/258748
563
564 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
565
566         [ews] commit-queue should comment on bug if patch fails to apply
567         https://bugs.webkit.org/show_bug.cgi?id=209334
568
569         Reviewed by Jonathan Bedard.
570
571         * BuildSlaveSupport/ews-build/steps.py:
572         (ApplyPatch):
573         (ApplyPatch.evaluateCommand): Overridden to check build status and queue name and comment on bug accordingly.
574         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
575         (TestApplyPatch):
576         (TestApplyPatch.setUp):
577         (TestApplyPatch.setUp.mock_start):
578         (TestApplyPatch.tearDown):
579         (TestApplyPatch.test_success):
580         (TestApplyPatch.test_failure):
581         (TestApplyPatch.test_failure_on_commit_queue):
582
583 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
584
585         [EWS] Limit number of builds to display in status-bubble hover over message in case of lot of retried builds
586         https://bugs.webkit.org/show_bug.cgi?id=209122
587
588         Reviewed by Jonathan Bedard.
589
590         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
591         (StatusBubble._build_bubble):
592
593 2020-03-19  Tim Horton  <timothy_horton@apple.com>
594
595         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
596         https://bugs.webkit.org/show_bug.cgi?id=209307
597
598         Reviewed by Andy Estes.
599
600         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
601
602 2020-03-19  Alex Christensen  <achristensen@webkit.org>
603
604         Remove test failing after r258734
605         https://bugs.webkit.org/show_bug.cgi?id=209303
606
607         We removed the functionality it was testing because it did nothing useful except call the callback.
608         I'm about to remove the only user of WKContextGetStatistics.
609
610         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
611         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
612
613 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
614
615         commit-queue status-bubble shows incorrect position in queue
616         https://bugs.webkit.org/show_bug.cgi?id=209313
617
618         Reviewed by Jonathan Bedard.
619
620         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
621         (StatusBubble._queue_position):
622
623 2020-03-19  Takashi Komori  <Takashi.Komori@sony.com>
624
625         [Curl] Add an API returns description of verification errors.
626         https://bugs.webkit.org/show_bug.cgi?id=208913
627
628         Reviewed by Fujii Hironori.
629
630         WKCertificateInfoCopyVerificationErrorDescription returns the description of SSL verification error as human readable string.
631         Browser can display more precise error information with this API.
632
633         API Test: Curl.CertificateAPI
634
635         * MiniBrowser/win/Common.cpp:
636         (askServerTrustEvaluation):
637         * MiniBrowser/win/Common.h:
638         * MiniBrowser/win/WebKitBrowserWindow.cpp:
639         (createPEMString):
640         (WebKitBrowserWindow::canTrustServerCertificate):
641         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp:
642         (TestWebKitAPI::Curl::TEST):
643
644 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
645
646         Update build.webkit.org link for EWS
647         https://bugs.webkit.org/show_bug.cgi?id=209280
648
649         Reviewed by Alexey Proskuryakov.
650
651         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
652
653 2020-03-19  Stephan Szabo  <stephan.szabo@sony.com>
654
655         [WinCairo] extract-built-product fails after r258612
656         https://bugs.webkit.org/show_bug.cgi?id=209285
657
658         extractBuiltProduct also references the old name for the
659         requirements on wincairo.
660
661         Reviewed by Ross Kirsling.
662
663         * BuildSlaveSupport/built-product-archive:
664
665 2020-03-19  Philippe Normand  <pnormand@igalia.com>
666
667         [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
668         https://bugs.webkit.org/show_bug.cgi?id=209223
669
670         Reviewed by Carlos Alberto Lopez Perez.
671
672         flatpak build doesn't expose a --socket option for white-listing
673         the systemd journal socket. So white-list everything in /run. 🤷
674
675         * flatpak/flatpakutils.py:
676         (WebkitFlatpak.run_in_sandbox):
677
678 2020-03-19  Charlie Turner  <cturner@igalia.com>
679
680         Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
681         https://bugs.webkit.org/show_bug.cgi?id=209146
682
683         Reviewed by Darin Adler.
684
685         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
686         (TestWebKitAPI::TEST):
687         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
688         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
689         (testDownloadMIMEType):
690         (testContextMenuDownloadActions):
691         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
692
693 2020-03-19  Carlos Garcia Campos  <cgarcia@igalia.com>
694
695         [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
696         https://bugs.webkit.org/show_bug.cgi?id=209278
697
698         Reviewed by Philippe Normand.
699
700         This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
701         means flatpak.
702
703         * Scripts/webkitdirs.pm:
704         (shouldUseFlatpak): Return early if WEBKIT_JHBUILD is set.
705
706 2020-03-19  Philippe Normand  <pnormand@igalia.com>
707
708         [CMake] cache not cleared when build-webkit options change
709         https://bugs.webkit.org/show_bug.cgi?id=209277
710
711         Reviewed by Adrian Perez de Castro.
712
713         * Scripts/webkitdirs.pm:
714         (shouldRemoveCMakeCache): The expected function signature never
715         included the cache file path. Remove it.
716
717 2020-03-18  Philippe Normand  <pnormand@igalia.com>
718
719         REGRESSION(r258626): webkit-dirs warning
720         https://bugs.webkit.org/show_bug.cgi?id=209221
721
722         Reviewed by Adrian Perez de Castro.
723
724         * Scripts/webkitdirs.pm:
725         (buildCMakeProjectOrExit): Fix Perl Warning. 😎
726
727 2020-03-19  Chris Lord  <clord@igalia.com>
728
729         Add Chris Lord (clord@igalia.com) to the list of contributors
730         https://bugs.webkit.org/show_bug.cgi?id=209274
731
732         Unreviewed
733
734         * Scripts/webkitpy/common/config/contributors.json:
735
736 2020-03-19  Ryan Haddad  <ryanhaddad@apple.com>
737
738         Remove commit queue bubble from bot watchers dashboard
739         https://bugs.webkit.org/show_bug.cgi?id=209271
740
741         Reviewed by Alexey Proskuryakov.
742
743         Remove commit queue bubble from bot watchers dashboard now that it has moved to the new EWS.
744
745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
746         (BubbleQueueServer): 
747
748 2020-03-18  Simon Fraser  <simon.fraser@apple.com>
749
750         eventSender.monitorWheelEvents() is very fragile
751         https://bugs.webkit.org/show_bug.cgi?id=197819
752         <rdar://problem/51319456>
753
754         Reviewed by Tim Horton.
755
756         Deflake tests using eventSender.monitorWheelEvents() by fixing several causes of flakiness,
757         adding back changes from r257844 that were reverted in r258558.
758         
759         First, have EventSendingController keep track of whether it's seen then "end" event
760         for the scrolling and momentum phases, and pass this down to WheelEventTestMonitor, which
761         now waits until it sees these, which prevents premature triggering which was a common cause of
762         failure before.
763         
764         Second, remove WheelEventTestMonitor's 1/60s timer and instead have WheelEventTestMonitor test
765         for completion in a callout from the end of Page::updateRendering(), which makes it test
766         and fire at a more consistent time.
767         
768         Third, push WheelEventTestMonitor to the ScrollingTree, so that reasons for deferral
769         can be added on the scrolling thread. This fixes an issue where the RunLoop::main().dispatch()
770         used to send the "ScrollingThreadSyncNeeded" reason to the main thread would get delayed,
771         also resulting in a premature trigger.
772
773         * DumpRenderTree/mac/EventSendingController.h:
774         * DumpRenderTree/mac/EventSendingController.mm:
775         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
776         (-[EventSendingController monitorWheelEvents]):
777         (-[EventSendingController callAfterScrollingCompletes:]):
778         * DumpRenderTree/win/EventSender.cpp:
779         (mouseScrollBy):
780         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
781         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
782         (WTR::EventSendingController::monitorWheelEvents):
783         (WTR::EventSendingController::callAfterScrollingCompletes):
784         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
785
786 2020-03-18  John Wilander  <wilander@apple.com>
787
788         WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener() should call its ephemeral counterpart when appropriate
789         https://bugs.webkit.org/show_bug.cgi?id=209245
790         <rdar://problem/60511121>
791
792         Reviewed by Chris Dumez.
793
794         These changes to the TestRunner makes sure that
795         - statisticsClearInMemoryAndPersistentStore()
796         - statisticsClearInMemoryAndPersistentStoreModifiedSinceHours()
797         ... use their own StatisticsDidClearInMemoryAndPersistentStoreCallbackID
798         and adds the infrastructure for that.
799
800         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
801         (WTR::InjectedBundle::didReceiveMessageToPage):
802         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
803         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
804         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
805         (WTR::TestRunner::statisticsCallClearInMemoryAndPersistentStoreCallback):
806         * WebKitTestRunner/InjectedBundle/TestRunner.h:
807         * WebKitTestRunner/TestController.cpp:
808         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
809         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
810         * WebKitTestRunner/TestInvocation.cpp:
811         (WTR::TestInvocation::didClearStatisticsInMemoryAndPersistentStore):
812         * WebKitTestRunner/TestInvocation.h:
813
814 2020-03-18  Wenson Hsieh  <wenson_hsieh@apple.com>
815
816         REGRESSION (r257214): Targeted preview animates to the wrong place when dropping in editable content
817         https://bugs.webkit.org/show_bug.cgi?id=209218
818         <rdar://problem/60560831>
819
820         Reviewed by Tim Horton.
821
822         Augment the drag and drop test harness to verify that for all targeted previews, if they have container views,
823         those views must be parented (i.e. they must be connected to a UIWindow).
824
825         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
826         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
827         (-[DragAndDropSimulator _expectNoDropPreviewsWithUnparentedContainerViews]):
828         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
829
830 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
831
832         [ews] commit-queue should comment on bug in case of test failures
833         https://bugs.webkit.org/show_bug.cgi?id=209226
834
835         Reviewed by Jonathan Bedard.
836
837         * BuildSlaveSupport/ews-build/steps.py:
838         (AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
839         (BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
840         (SetBuildSummary): Ditto.
841         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
842
843 2020-03-18  Philippe Normand  <pnormand@igalia.com>
844
845         REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
846         https://bugs.webkit.org/show_bug.cgi?id=209238
847
848         Reviewed by Jonathan Bedard.
849
850         * Scripts/test262-runner: Perform the flatpak check on Linux only.
851
852 2020-03-18  Stephan Szabo  <stephan.szabo@sony.com>
853
854         [WinCairo] archive-built-product fails after r258612
855         https://bugs.webkit.org/show_bug.cgi?id=209237
856
857         Reviewed by Alex Christensen.
858
859         * BuildSlaveSupport/built-product-archive:
860         Update name of version file for requirements version
861         file for wincairo.
862
863 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
864
865         commit-queue should allow patches which are reviewed by patch author
866         https://bugs.webkit.org/show_bug.cgi?id=209231
867
868         Reviewed by Jonathan Bedard.
869
870         * BuildSlaveSupport/ews-build/steps.py:
871         (BugzillaMixin._does_patch_have_acceptable_review_flag):
872
873 2020-03-18  Philippe Normand  <pnormand@igalia.com>
874
875         [JHBuild] Flatpak used for run-minibrowser even when forcing jhbuild
876         https://bugs.webkit.org/show_bug.cgi?id=209222
877
878         Reviewed by Carlos Alberto Lopez Perez.
879
880         * Scripts/webkitdirs.pm:
881         (runInFlatpakIfAvailable): If a command wrapper is required it
882         means Flatpak shouldn't be used.
883
884 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
885
886         [ews] commit-queue should comment on bug in case patch fails to build
887         https://bugs.webkit.org/show_bug.cgi?id=209227
888
889         Reviewed by Jonathan Bedard.
890
891         * BuildSlaveSupport/ews-build/steps.py:
892         (AnalyzeCompileWebKitResults.start):
893         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
894
895 2020-03-18  Philippe Normand  <pnormand@igalia.com>
896
897         [GTK][WPE] Migrate to Flatpak-based dev SDK
898         https://bugs.webkit.org/show_bug.cgi?id=205658
899
900         Reviewed by Carlos Alberto Lopez Perez.
901
902         JHBuild will now be used only if the WEBKIT_JHBUILD environment
903         variable is set to 1, which is the case for the time being on the
904         GTK and WPE EWS/build bots.
905
906         By default the build dependencies are now locally installed from a
907         Flatpak repository hosted at https://software.igalia.com. The
908         repository can be regenerated with the scripts from the
909         webkit-flatpak-sdk Github project
910         (https://github.com/Igalia/webkit-flatpak-sdk). This is done
911         transparently with the update-webkit{gtk,wpe}-libs scripts. As
912         there is no need to rebuild the dependencies from scratch, the
913         developer user-experience should now be much more friendly and
914         overall build times reduced.
915
916         As an additional commodity, the new environment supports the
917         GStreamer gst-build-based workflow. Just set the GST_BUILD_PATH
918         environment variable to your gst-build path. This feature was
919         contributed by Thibault Saunier.
920
921         The JHBuild infrastructure will be removed once all the bots have
922         been switched over to Flatpak.
923
924         * BuildSlaveSupport/ews-build/steps.py:
925         (InstallGtkDependencies):
926         (InstallWpeDependencies):
927         (CompileWebKit.start):
928         * BuildSlaveSupport/gtk/buildbot/run:
929         * Scripts/build-webkit:
930         * Scripts/run-bindings-tests:
931         * Scripts/run-builtins-generator-tests:
932         * Scripts/run-gtk-tests:
933         * Scripts/run-javascriptcore-tests:
934         * Scripts/run-minibrowser:
935         * Scripts/run-qt-wpe-minibrowser:
936         * Scripts/run-webdriver-tests:
937         * Scripts/run-wpe-tests:
938         * Scripts/test-webkitperl:
939         * Scripts/test-webkitpy:
940         * Scripts/test262-runner:
941         * Scripts/update-webkit-flatpak: Renamed from Tools/Scripts/update-webkitgtk-flatpak.
942         * Scripts/update-webkitgtk-libs:
943         * Scripts/update-webkitwpe-flatpak: Removed.
944         * Scripts/update-webkitwpe-libs:
945         * Scripts/webkitdirs.pm:
946         (getUserFlatpakPath):
947         (inFlatpakSandbox):
948         (runInFlatpakIfAvailable):
949         (wrapperPrefixIfNeeded):
950         (shouldUseJhbuild):
951         (shouldUseFlatpak):
952         (shouldRemoveCMakeCache):
953         * Scripts/webkitpy/common/system/executive.py:
954         (Executive.kill_all):
955         * Scripts/webkitpy/port/base.py:
956         (Port._path_to_apache):
957         (Port._should_run_as_pixel_test):
958         (Port._in_flatpak_sandbox):
959         * Scripts/webkitpy/port/gtk.py:
960         (GtkPort.setup_environ_for_server):
961         (GtkPort._get_crash_log):
962         * Scripts/webkitpy/port/linux_get_crash_log.py:
963         (GDBCrashLogGenerator):
964         (GDBCrashLogGenerator.__init__):
965         (GDBCrashLogGenerator.generate_crash_log):
966         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
967         (GDBCrashLogGeneratorTest.test_generate_crash_log):
968         * Scripts/webkitpy/port/wpe.py:
969         (WPEPort.setup_environ_for_server):
970         (WPEPort._get_crash_log):
971         * Scripts/webkitpy/port/xvfbdriver.py:
972         (XvfbDriver._setup_environ_for_test):
973         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
974         (WTR::getFontsPath):
975         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
976         (WTR::getFontsPath):
977         * flatpak/files/default.xkm: Removed.
978         * flatpak/files/httpd-autogen.sh: Removed.
979         * flatpak/flatpakutils.py:
980         (check_flatpak):
981         (FlatpakRepos.update):
982         (FlatpakPackage.__repr__):
983         (FlatpakPackage.__str__):
984         (WebkitFlatpak.load_from_args):
985         (WebkitFlatpak.__init__):
986         (WebkitFlatpak.clean_args):
987         (WebkitFlatpak.setup_builddir):
988         (WebkitFlatpak):
989         (WebkitFlatpak.setup_gstbuild):
990         (WebkitFlatpak.run_in_sandbox):
991         (WebkitFlatpak.run):
992         (WebkitFlatpak.has_environment):
993         (WebkitFlatpak.save_config):
994         (WebkitFlatpak.setup_dev_env):
995         (WebkitFlatpak.install_all):
996         (WebkitFlatpak.run_gdb):
997         * flatpak/org.webkit.CommonModules.yaml: Removed.
998         * flatpak/org.webkit.GTK.yaml: Removed.
999         * flatpak/org.webkit.WPE.yaml: Removed.
1000         * flatpak/org.webkit.WPEModules.yaml: Removed.
1001         * flatpak/org.webkit.WPEQT.yaml: Removed.
1002         * flatpak/org.webkit.WebKit.yaml: Removed.
1003         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
1004         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
1005         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Removed.
1006
1007 2020-03-17  Kate Cheney  <katherine_cheney@apple.com>
1008
1009         Expand In-App-Browser-Privacy testing
1010         https://bugs.webkit.org/show_bug.cgi?id=209142
1011         <rdar://problem/60496618>
1012
1013         Reviewed by Darin Adler.
1014
1015         Expanded test coverage by adding new tests and creating a custom url
1016         scheme handler to get around the fact that local file loads are
1017         always classified as app-bound.
1018
1019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1020         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1021         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
1022         If the path indicates testing user scripts on load, notify the script message
1023         handler that the navigation has finished. If the path indicates
1024         testing user-agent scripts, set the window.wkUserScriptInjected
1025         variable to true. A user agent script will attempt to read this
1026         variable and should fail.
1027
1028         (-[InAppBrowserSchemeHandler webView:stopURLSchemeTask:]):
1029         (initializeInAppBrowserPrivacyTestSettings):
1030         Basic test setup. Initialize the main run loop and make sure we are
1031         starting with a clean state.
1032
1033         (TEST):
1034         Add tests for all protocols checked in shouldBeTreatedAsAppBound,
1035         except for blob files which must be generated within the web content.
1036
1037         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html: Added.
1038         Basic html document to test local file loads are classified as
1039         app-bound.
1040
1041         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Removed.
1042         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Removed.
1043         These files are no longer needed as their content is directly copied
1044         into the URL scheme handler.
1045
1046 2020-03-17  Chris Dumez  <cdumez@apple.com>
1047
1048         REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing
1049         https://bugs.webkit.org/show_bug.cgi?id=207307
1050         <rdar://problem/59206964>
1051
1052         Reviewed by Alex Christensen.
1053
1054         When [MockWebNotificationProvider reset] was called at the end of the test, it would remove all
1055         notifications from the map but not tell WebCore that the notification were discarded. As a result,
1056         WebCore would later tell the MockWebNotificationProvider to cancel the notification but this
1057         notification would no longer be in the map, causing us to hit an assertion in debug.
1058
1059         To address the issue, we now call Notification::finalize() in [MockWebNotificationProvider reset]
1060         to let WebCore know the notification was discarded. This is similar to what is already done for
1061         WebKit2 in WebNotificationManager::clearNotifications().
1062
1063         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
1064         (-[MockWebNotificationProvider reset]):
1065
1066 2020-03-17  Don Olmstead  <don.olmstead@sony.com>
1067
1068         [WinCairo][FTW] Update path to requirements download
1069         https://bugs.webkit.org/show_bug.cgi?id=209202
1070
1071         Reviewed by Ross Kirsling.
1072
1073         Repository was renamed from WinCairoRequirements to WebKitRequirements in the
1074         WebKitForWindows org on GitHub. Additionally the .zip file was renamed to
1075         WebKitRequirementsWin64.zip.
1076
1077         * Scripts/update-webkit-wincairo-libs.py:
1078
1079 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
1080
1081         [ews] Resubmit patches to commit-queue which were cq- by commit-queue and later cq+
1082         https://bugs.webkit.org/show_bug.cgi?id=208920
1083
1084         Reviewed by Jonathan Bedard.
1085
1086         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1087         (Buildbot.update_builder_name_to_id_mapping): Method to generate builder name to id mapping.
1088         (Buildbot.fetch_pending_and_inprogress_builds): Method to fetch pendign and in-progress builds from buildbot.
1089         (Buildbot.get_patches_in_queue): Method to fetch list of patches which are pending or are in-progress on buildbot.
1090         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1091         (Bugzilla.get_cq_plus_timestamp): Get UTC timestamp when cq+ flag was set.
1092         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1093         (FetchLoop.run): Update builder name to id mapping. We just need to update it one-time, since we need the id only
1094         for commit-queue which isn't expected to change.
1095         (BugzillaPatchFetcher.fetch_commit_queue_patches):
1096         (BugzillaPatchFetcher.send_patches_to_buildbot): Allow sending the patch again to commit-queue.
1097         (BugzillaPatchFetcher.patches_to_send_to_commit_queue): Find patches which needs to be sent to commit-queue. Filter
1098         out patches which are already waiting or in-progress on commit-queue, or whose recent build was completed after
1099         setting cq+ flag on bugzilla.
1100
1101 2020-03-17  Chris Dumez  <cdumez@apple.com>
1102
1103         [WKTR] testRunner API that takes in a completion handler should use async IPC
1104         https://bugs.webkit.org/show_bug.cgi?id=209187
1105
1106         Reviewed by John Wilander.
1107
1108         testRunner API that takes in a completion handler should use async IPC. This hangs
1109         the WebProcess for no reason and can cause deadlocks if the UIProcess then tries
1110         to IPC the WebProcess as a result of this testRunner call.
1111
1112         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1113         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1114         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1115         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1116         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1117         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1118         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
1119         (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode):
1120         (WTR::TestRunner::statisticsResetToConsistentState):
1121         (WTR::TestRunner::getAllStorageAccessEntries):
1122         (WTR::TestRunner::removeAllSessionCredentials):
1123         (WTR::TestRunner::getApplicationManifestThen):
1124         * WebKitTestRunner/TestInvocation.cpp:
1125         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1126         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1127
1128 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
1129
1130         [ews-app] Timestamp shown in status-bubble hover-over message is in future
1131         https://bugs.webkit.org/show_bug.cgi?id=196628
1132
1133         Reviewed by Jonathan Bedard.
1134
1135         * BuildSlaveSupport/ews-build/events.py:
1136         (JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.
1137         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1138         (StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the 
1139         timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.
1140
1141 2020-03-17  Alex Christensen  <achristensen@webkit.org>
1142
1143         Add WKUIDelegatePrivate SPI _webView:printFrame:completionHandler:
1144         https://bugs.webkit.org/show_bug.cgi?id=209192
1145         <rdar://problem/51313336>
1146
1147         Reviewed by Geoff Garen.
1148
1149         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
1150         (-[PrintDelegateWithCompletionHandler _webView:printFrame:completionHandler:]):
1151         (-[PrintDelegateWithCompletionHandler waitForPrintFrameCall]):
1152         (TEST):
1153
1154 2020-03-17  Chris Dumez  <cdumez@apple.com>
1155
1156         Use less sync IPC for ITP testRunner methods
1157         https://bugs.webkit.org/show_bug.cgi?id=209184
1158
1159         Reviewed by Alex Christensen.
1160
1161         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1162         (WTR::TestRunner::setStatisticsDebugMode):
1163         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1164         (WTR::TestRunner::setStatisticsLastSeen):
1165         (WTR::TestRunner::setStatisticsMergeStatistic):
1166         (WTR::TestRunner::setStatisticsPrevalentResource):
1167         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1168         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1169         * WebKitTestRunner/TestInvocation.cpp:
1170         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1171         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1172
1173 2020-03-17  Chris Dumez  <cdumez@apple.com>
1174
1175         [WKTR] Crash when trying to open a new window in an ephemeral session test
1176         https://bugs.webkit.org/show_bug.cgi?id=209181
1177
1178         Reviewed by Geoffrey Garen.
1179
1180         Make sure that the new WKWebView is using the same data store as its related WKWebView.
1181
1182         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1183         (WTR::TestController::platformCreateOtherPage):
1184
1185 2020-03-17  Jacob Uphoff  <jacob_uphoff@apple.com>
1186
1187         Unreviewed, reverting r257844.
1188
1189         this revision caused a test to start timing out
1190
1191         Reverted changeset:
1192
1193         "(r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-
1194         zero.html is a flaky failure"
1195         https://bugs.webkit.org/show_bug.cgi?id=207948
1196         https://trac.webkit.org/changeset/257844
1197
1198 2020-03-16  Justin Michaud  <justin_michaud@apple.com>
1199
1200         Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
1201         https://bugs.webkit.org/show_bug.cgi?id=209151
1202
1203         Reviewed by Yusuke Suzuki.
1204
1205         * Scripts/webkitpy/common/config/contributors.json:
1206
1207 2020-03-16  Chris Dumez  <cdumez@apple.com>
1208
1209         Crash under WebCookieCache::clearForHost()
1210         https://bugs.webkit.org/show_bug.cgi?id=209149
1211         <rdar://problem/60453086>
1212
1213         Reviewed by Alex Christensen.
1214
1215         Add API test coverage.
1216
1217         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
1218         (TEST):
1219
1220 2020-03-16  Keith Rollin  <krollin@apple.com>
1221
1222         Remove support for WebKitSystemInterface
1223         https://bugs.webkit.org/show_bug.cgi?id=208894
1224         <rdar://problem/60297590>
1225
1226         Reviewed by Brent Fulgham.
1227
1228         This project provided support for facilities that are now handled
1229         elsewhere and is no longer needed.
1230
1231         * Scripts/copy-webkitlibraries-to-product-directory:
1232
1233 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
1234
1235         [macOS] Accessibility sandbox regressions
1236         https://bugs.webkit.org/show_bug.cgi?id=209065
1237
1238         Reviewed by Brent Fulgham.
1239
1240         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
1241         (TEST):
1242         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
1243         (TEST):
1244
1245 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
1246
1247         Unreviewed infrastructure fix.
1248
1249         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
1250         while the hardware is out for repair.
1251
1252 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
1253
1254         [WebXR] IDLs, stubs and build configuration for WPE
1255         https://bugs.webkit.org/show_bug.cgi?id=208702
1256
1257         Reviewed by Dean Jackson.
1258
1259         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
1260         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
1261
1262 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
1263
1264         [Cocoa] Limit set of classes that can be decoded when a preference has changed
1265         https://bugs.webkit.org/show_bug.cgi?id=208012
1266
1267         Reviewed by Brent Fulgham.
1268
1269         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
1270         (TEST):
1271
1272 2020-03-16  youenn fablet  <youenn@apple.com>
1273
1274         Unique origins should not be Potentially Trustworthy
1275         https://bugs.webkit.org/show_bug.cgi?id=209049
1276
1277         Reviewed by Darin Adler.
1278
1279         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1280         (TestWebKitAPI::TEST_F):
1281
1282 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
1283
1284         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
1285         https://bugs.webkit.org/show_bug.cgi?id=207324
1286
1287         Reviewed by Darin Adler.
1288
1289         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
1290         (TestWebKitAPI::generateRandomData): Added.
1291         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
1292
1293 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
1294
1295         Should not use variable-length-array (VLA)
1296         https://bugs.webkit.org/show_bug.cgi?id=209043
1297
1298         Reviewed by Mark Lam.
1299
1300         * ContentExtensionTester/Configurations/Base.xcconfig:
1301         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
1302
1303 2020-03-13  Alex Christensen  <achristensen@webkit.org>
1304
1305         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
1306         https://bugs.webkit.org/show_bug.cgi?id=209011
1307         <rdar://problem/59370588>
1308
1309         Reviewed by Youenn Fablet.
1310
1311         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1312         (TestWebKitAPI::TEST):
1313
1314 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1315
1316         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
1317         https://bugs.webkit.org/show_bug.cgi?id=209089
1318
1319         Reviewed by Tim Horton.
1320
1321         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
1322         marketing name for the feature.
1323
1324         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1325         (runUntilReceivesAutoplayEvent):
1326
1327         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
1328         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
1329         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
1330         be any compelling reason to compare against different types here (especially since we only set
1331         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
1332         these all to be `_WKAutoplayEvent`.
1333
1334         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
1335         (-[AutoFillTestView _autofillInputView]):
1336         (-[AutoFillTestView textInputHasAutoFillContext]):
1337         (TestWebKitAPI::TEST):
1338         (-[AutofillTestView initWithFrame:]): Deleted.
1339         (-[AutofillTestView _autofillInputView]): Deleted.
1340         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
1341         * TestWebKitAPI/ios/UIKitSPI.h:
1342
1343 2020-03-13  Chris Dumez  <cdumez@apple.com>
1344
1345         Unreviewed, reverting r256232.
1346
1347         Caused ResizeObserver tests to become flaky
1348
1349         Reverted changeset:
1350
1351         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
1352         override TestOptions"
1353         https://bugs.webkit.org/show_bug.cgi?id=207481
1354         https://trac.webkit.org/changeset/256232
1355
1356 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1357
1358         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
1359         https://bugs.webkit.org/show_bug.cgi?id=209016
1360         <rdar://problem/60329530> 
1361
1362         Reviewed by Chris Dumez.
1363
1364         Re-initialize the app-bound domains when the correct
1365         TestOptions parameter is set.
1366
1367         * WebKitTestRunner/TestController.cpp:
1368         (WTR::TestController::createWebViewWithOptions):
1369         (WTR::TestController::reinitializeAppBoundDomains):
1370         * WebKitTestRunner/TestController.h:
1371
1372 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1373
1374         Report all third party loads on a per-page basis
1375         https://bugs.webkit.org/show_bug.cgi?id=209032
1376         <rdar://problem/60397323>
1377
1378         Reviewed by Chris Dumez.
1379
1380         Mostly naming updates to reflect the change in use for this SPI call.
1381         It now returns all loaded third party domains, not just prevalent ones.
1382
1383         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1384         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1385         (WTR::InjectedBundle::didReceiveMessageToPage):
1386         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1387         (WTR::TestRunner::getLoadedThirdPartyDomains):
1388         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
1389         (WTR::TestRunner::getPrevalentDomains): Deleted.
1390         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
1391         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1392         * WebKitTestRunner/TestController.cpp:
1393         (WTR::TestController::resetStateToConsistentValues):
1394         (WTR::TestController::getLoadedThirdPartyDomains):
1395         (WTR::TestController::clearLoadedThirdPartyDomains):
1396         (WTR::TestController::getPrevalentDomains): Deleted.
1397         (WTR::TestController::clearPrevalentDomains): Deleted.
1398         * WebKitTestRunner/TestController.h:
1399         * WebKitTestRunner/TestInvocation.cpp:
1400         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1401         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
1402         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
1403         * WebKitTestRunner/TestInvocation.h:
1404         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1405         (WTR::TestController::getLoadedThirdPartyDomains):
1406         (WTR::TestController::clearLoadedThirdPartyDomains):
1407         (WTR::TestController::getPrevalentDomains): Deleted.
1408         (WTR::TestController::clearPrevalentDomains): Deleted.
1409
1410 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1411
1412         [ews] run FindModifiedChangeLogs early in the build
1413         https://bugs.webkit.org/show_bug.cgi?id=209060
1414
1415         Reviewed by Jonathan Bedard.
1416
1417         * BuildSlaveSupport/ews-build/factories.py:
1418         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
1419
1420 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
1421
1422         [GTK] Add EWS testers to run GTK layout tests
1423         https://bugs.webkit.org/show_bug.cgi?id=207648
1424
1425         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
1426
1427         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
1428         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
1429         tests (layout tests).
1430
1431         * BuildSlaveSupport/ews-build/config.json: Added new queue for
1432         WK2 tests.
1433         * BuildSlaveSupport/ews-build/factories.py:
1434         (GTKTestsFactory):
1435         * BuildSlaveSupport/ews-build/factories_unittest.py:
1436         (TestCommitQueueFactory.test_commit_queue_factory):
1437         (TestGTKFactory): Added unit-test.
1438         (TestGTKFactory.test_gtk_factory):
1439         * BuildSlaveSupport/ews-build/loadConfig.py:
1440         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1441         (TagsForBuilderTest.test_getTagsForBuilder):
1442
1443 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1444
1445         Add API endpoint in EWS django app to provide patch status in json format
1446         https://bugs.webkit.org/show_bug.cgi?id=208940
1447
1448         Reviewed by Jonathan Bedard.
1449
1450         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
1451         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
1452
1453 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
1454
1455         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
1456         https://bugs.webkit.org/show_bug.cgi?id=209055
1457         <rdar://problem/60272692>
1458
1459         Reviewed by Simon Fraser.
1460
1461         Now that WebKitTestRunner has a bundleID, its' user default values
1462         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
1463         to NO before running tests. It will be set to YES in PlatformWebView
1464         if specified by the test.
1465
1466         * WebKitTestRunner/mac/main.mm:
1467         (setDefaultsToConsistentValuesForTesting):
1468
1469 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
1470
1471         [CMake] Eleminate mismatches between Find* module names and variables they set
1472         https://bugs.webkit.org/show_bug.cgi?id=208948
1473
1474         Reviewed by Michael Catanzaro.
1475
1476         * wpe/backends/CMakeLists.txt:
1477
1478 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
1479
1480         [ews-app] reduce logging
1481         https://bugs.webkit.org/show_bug.cgi?id=209062
1482
1483         Reviewed by Jonathan Bedard.
1484
1485         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1486         (BugzillaBeautifulSoup.authenticate):
1487         (BugzillaBeautifulSoup._load_query):
1488
1489 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
1490
1491         Crash in TextIterator::node via TextManipulationController::replace
1492         https://bugs.webkit.org/show_bug.cgi?id=209048
1493
1494         Reviewed by Wenson Hsieh.
1495
1496         Added a regression test.
1497
1498         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1499         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
1500
1501 2020-03-13  Saam Barati  <sbarati@apple.com>
1502
1503         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
1504         https://bugs.webkit.org/show_bug.cgi?id=209038
1505
1506         Reviewed by Keith Miller.
1507
1508         This allows us to automatically pull in some tests that are in non open sourced Apple
1509         checkouts.
1510
1511         * Scripts/run-javascriptcore-tests:
1512         (runJSCStressTests):
1513
1514 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
1515
1516         Crash in TextManipulationController::replace
1517         https://bugs.webkit.org/show_bug.cgi?id=209021
1518
1519         Reviewed by Wenson Hsieh.
1520
1521         Added a regression test.
1522
1523         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1524         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
1525
1526 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
1527
1528         [macOS] _AXSApplicationAccessibilityEnabled should not be called
1529         https://bugs.webkit.org/show_bug.cgi?id=208953
1530
1531         Reviewed by Brent Fulgham.
1532
1533         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1534
1535 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
1536
1537         Resource load statistics data summary should return all third party data
1538         https://bugs.webkit.org/show_bug.cgi?id=209000
1539         <rdar://problem/60348306>
1540
1541         Reviewed by John Wilander.
1542
1543         Marked only 2 of 3 domains prevalent in data summary tests to ensure
1544         the call returns all third parties, not just prevalent ones.
1545         Added a more aggressive check for the size of the array at the
1546         beginning of the test to ensure the array is still returning 3 values. 
1547         Also removed the ASSERT statements as they seem to cause timeouts (not
1548         clear crashes) when they are not true, which is hard to debug.
1549         If these values are nil, the test will fail in the EXPECT_WK_STREQ
1550         checks, we don't need ASSERT statements.
1551
1552         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1553         (TEST):
1554
1555 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
1556
1557         resultsdpy: Add script to run local instance
1558         https://bugs.webkit.org/show_bug.cgi?id=208746
1559
1560         Rubber-stamped by Aakash Jain.
1561
1562         * resultsdbpy/resultsdbpy/example: Added.
1563         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
1564         * resultsdbpy/resultsdbpy/example/environment.py: Added.
1565         (Environment): Organize environment variables used by results database.
1566         (ModelFromEnvironment): Construct the database model from the environment.
1567         (main): Create and drop tables, if required.
1568         * resultsdbpy/resultsdbpy/example/main.py: Added.
1569         (health): Web-server health check.
1570         (handle_errors):
1571         (main): Run results database web-server.
1572         * resultsdbpy/resultsdbpy/example/worker.py: Added.
1573         (main): Asynchronously process uploaded results.
1574         * resultsdbpy/resultsdbpy/run: Added.
1575
1576 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1577
1578         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
1579         https://bugs.webkit.org/show_bug.cgi?id=209004
1580
1581         Reviewed by Tim Horton.
1582
1583         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
1584         `use_gpu_process` is specified.
1585
1586         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1587         (parse_args):
1588
1589 2020-03-12  Matt Lewis  <jlewis3@apple.com>
1590
1591         Make flatpack import for run-webkit-tests only happen on linux systems
1592         https://bugs.webkit.org/show_bug.cgi?id=208954
1593
1594         Reviewed by Philippe Normand.
1595
1596         * Scripts/run-webkit-tests: Added an if statement to find the system platform
1597         to determine if we need the flatpackutils import. 
1598
1599 2020-03-12  Alex Christensen  <achristensen@webkit.org>
1600
1601         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
1602         https://bugs.webkit.org/show_bug.cgi?id=207609
1603
1604         Reviewed by Ryosuke Niwa.
1605
1606         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1607         (TestWebKitAPI::TEST):
1608
1609 2020-03-12  Daniel Bates  <dabates@apple.com>
1610
1611         FocusController::setFocusedElement() should tell client of refocused element
1612         https://bugs.webkit.org/show_bug.cgi?id=208880
1613
1614         Reviewed by Wenson Hsieh.
1615
1616         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
1617         to start an input session. Currently, it does not even try.
1618
1619         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1620         (TEST):
1621
1622 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
1623
1624         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
1625         https://bugs.webkit.org/show_bug.cgi?id=208970
1626
1627         Reviewed by Daniel Bates.
1628
1629         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
1630         #!/usr/bin/env python.
1631
1632         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
1633         probably has similar rules.
1634
1635         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
1636         Everything else that does so is probably only used by webkit-build.
1637
1638         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
1639
1640         * gtkdoc/generate-gtkdoc:
1641
1642 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
1643
1644         [WebAuthn] Formalize the Keychain schema
1645         https://bugs.webkit.org/show_bug.cgi?id=183533
1646         <rdar://problem/43347926>
1647
1648         Reviewed by Brent Fulgham.
1649
1650         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
1651         the original combination of RP ID and user handle.
1652
1653         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1654         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1655         (WTR::TestRunner::cleanUpKeychain):
1656         (WTR::TestRunner::keyExistsInKeychain):
1657         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1658         * WebKitTestRunner/TestController.h:
1659         * WebKitTestRunner/TestInvocation.cpp:
1660         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1661         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1662         (WTR::TestController::cleanUpKeychain):
1663         (WTR::TestController::keyExistsInKeychain):
1664
1665 2020-03-11  Keith Miller  <keith_miller@apple.com>
1666
1667         Test262-runner should always consider crashes as new failures
1668         https://bugs.webkit.org/show_bug.cgi?id=208943
1669
1670         Reviewed by Yusuke Suzuki.
1671
1672         Right now the runner will consider crashes with no output as passes, which is obviously bad.
1673         Since we should never crash on a conformance test we should consider a crash as a new failure
1674         100% of the time.
1675
1676         * Scripts/test262/Runner.pm:
1677         (processFile):
1678         (runTest):
1679         (processResult):
1680
1681 2020-03-11  Chris Dumez  <cdumez@apple.com>
1682
1683         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
1684         https://bugs.webkit.org/show_bug.cgi?id=208927
1685         <rdar://problem/55448331>
1686
1687         Reviewed by Alex Christensen.
1688
1689         Add API test coverage.
1690
1691         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1692
1693 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
1694
1695         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
1696         https://bugs.webkit.org/show_bug.cgi?id=208860
1697
1698         Reviewed by Carlos Alberto Lopez Perez.
1699
1700         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1701         (StatusBubble): Added 'api-gtk'.
1702         * BuildSlaveSupport/ews-build/config.json:
1703         * BuildSlaveSupport/ews-build/factories.py:
1704         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
1705         GTK.
1706         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
1707         GTK.
1708         (GTKBuildFactory):
1709         (GTKBuildFactory.__init__): Deleted.
1710         (GTKBuildAndTestFactory): Deleted.
1711         (GTKBuildAndTestFactory.__init__): Deleted.
1712         (GTKAPIBuildAndTestFactory): Deleted.
1713         * BuildSlaveSupport/ews-build/loadConfig.py:
1714
1715 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
1716
1717         [ews] Add unit test to prevent multiple schedulers for a builder.
1718         https://bugs.webkit.org/show_bug.cgi?id=208917
1719
1720         Reviewed by Carlos Alberto Lopez Perez.
1721
1722         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1723         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
1724         (TagsForBuilderTest): Fixed a typo.
1725
1726 2020-03-11 Philippe Normand  <pnormand@igalia.com>
1727
1728         [GTK] Failing API tests under the Flatpak SDK environment
1729         https://bugs.webkit.org/show_bug.cgi?id=208871
1730
1731         Reviewed by Michael Catanzaro.
1732
1733         The load-failed signal callback should return a boolean result,
1734         otherwise we enter in unknown territory depending on how the
1735         toolchain compiles this, possibly triggering bad behavior (with
1736         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
1737         GCC toolchain on buildbots).
1738
1739         Patch suggested by Michael Catanzaro.
1740
1741         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1742         (loadFailedCallback):
1743
1744 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
1745
1746         Sync FeatureList.pm with CMake definitions
1747         https://bugs.webkit.org/show_bug.cgi?id=208866
1748
1749         Reviewed by Michael Catanzaro.
1750
1751         * Scripts/webkitperl/FeatureList.pm:
1752
1753 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1754
1755         [ews] Add unit tests for commit queue factory
1756         https://bugs.webkit.org/show_bug.cgi?id=208862
1757
1758         Reviewed by Jonathan Bedard.
1759
1760         * BuildSlaveSupport/ews-build/factories_unittest.py:
1761         (TestCommitQueueFactory):
1762         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
1763
1764 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1765
1766         [ews-app] Status bubble should only display important messages in pop-over - part 3
1767         https://bugs.webkit.org/show_bug.cgi?id=208865
1768
1769         Reviewed by Jonathan Bedard.
1770
1771         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1772         (StatusBubble): Added more strings to STEPS_TO_HIDE.
1773
1774 2020-03-10  Lauro Moura  <lmoura@igalia.com>
1775
1776         [WPE] MiniBrowser: Close child WebViews when exiting
1777         https://bugs.webkit.org/show_bug.cgi?id=208689
1778
1779         Reviewed by Carlos Garcia Campos.
1780
1781         Store created views so we can release them before exiting.
1782
1783         * MiniBrowser/wpe/main.cpp:
1784         (webViewClose):
1785         (createWebView):
1786         (main):
1787
1788 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1789
1790         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
1791         https://bugs.webkit.org/show_bug.cgi?id=208861
1792
1793         Reviewed by Jonathan Bedard.
1794
1795         * BuildSlaveSupport/ews-build/factories.py:
1796         (Factory.__init__): Remove verifycqplus parameter.
1797         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
1798         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
1799         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
1800
1801 2020-03-10  Philippe Normand  <pnormand@igalia.com>
1802
1803         [GTK] API favicon test flaky timeouts
1804         https://bugs.webkit.org/show_bug.cgi?id=208189
1805
1806         Reviewed by Carlos Garcia Campos.
1807
1808         Sometimes the favicon changes already during the load. Keeping
1809         track of it in the WebView favicon property notification handler
1810         gets us rid of the race.
1811
1812         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1813         (testFaviconDatabaseGetFavicon):
1814
1815 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1816
1817         Generate commit-queue status bubble from new EWS
1818         https://bugs.webkit.org/show_bug.cgi?id=208811
1819
1820         Reviewed by Jonathan Bedard.
1821
1822         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1823         (StatusBubble._build_bubbles_for_patch):
1824
1825 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
1826
1827         Remove obsolete feature flags
1828         https://bugs.webkit.org/show_bug.cgi?id=208830
1829
1830         Reviewed by Alex Christensen.
1831
1832         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
1833         are no longer used.
1834
1835         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
1836         when the compilation flag was removed in r258148.
1837
1838         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
1839         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
1840
1841         * Scripts/webkitperl/FeatureList.pm:
1842         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1843
1844 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
1845
1846         WebKitTestRunner bundleID should not be cleared before every test
1847         https://bugs.webkit.org/show_bug.cgi?id=208823
1848         <rdar://problem/60204539>
1849
1850         Reviewed by Per Arne Vollan.
1851
1852         This is causing test failures for layout tests which rely on the Info.plist 
1853         bundle identifier (not the one set via the override method).
1854
1855         * WebKitTestRunner/TestController.cpp:
1856         (WTR::TestController::createWebViewWithOptions):
1857         (WTR::TestController::ensureViewSupportsOptionsForTest):
1858         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1859
1860 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
1861
1862         [macOS] Notification observer is not removed
1863         https://bugs.webkit.org/show_bug.cgi?id=208834
1864
1865         Reviewed by Tim Horton.
1866
1867         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1868         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
1869         (TEST):
1870
1871 2020-03-06  Brian Burg  <bburg@apple.com>
1872
1873         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
1874         https://bugs.webkit.org/show_bug.cgi?id=208729
1875         <rdar://problem/60105447>
1876
1877         Reviewed by Jonathan Bedard.
1878
1879         Improve upload.py to look for the svn branch and revision for the 'webkit'
1880         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
1881
1882         * Scripts/webkitpy/common/checkout/scm/git.py:
1883         (Git):
1884         (Git.git_svn_id_regexp):
1885         (Git._field_from_git_svn_id):
1886         (Git.svn_revision):
1887         (Git.svn_branch):
1888         (Git.svn_url):
1889         (Git.native_branch):
1890         Refactor svn revision, branch, url to use the same regexp and helper code.
1891
1892         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1893         (StubRepository.svn_branch):
1894         Expose a stub since this is used unconditionally by Port.commits_for_upload.
1895
1896         * Scripts/webkitpy/common/checkout/scm/svn.py:
1897         (SVN.svn_branch):
1898         (SVN.native_revision):
1899         (SVN):
1900         (SVN.native_branch):
1901         Refactor so the actual implementation is contained in svn_revision / svn_branch.
1902         The native_* methods call out to the SVN equivalents since this is an SVN repository.
1903
1904         * Scripts/webkitpy/port/base.py:
1905         (Port.commits_for_upload):
1906         Add special git-svn handling for the WebKit repository so that SVN branch and revision
1907         is preferred over the git equivalents.
1908
1909 2020-03-09  Antoine Quint  <graouts@apple.com>
1910
1911         TestWebKitAPI fails to build on watchOS
1912         https://bugs.webkit.org/show_bug.cgi?id=208820
1913
1914         Reviewed by Tim Horton.
1915
1916         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1917
1918 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
1919
1920         resultsdbpy: Add tool to manage resultsdbpy container
1921         https://bugs.webkit.org/show_bug.cgi?id=208743
1922
1923         Rubber-stamped by Aakash Jain.
1924
1925         Add tool to start, stop and restart the resultsdbpy Docker container.
1926
1927         * resultsdbpy/resultsdbpy/container: Added.
1928
1929 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1930
1931         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
1932         https://bugs.webkit.org/show_bug.cgi?id=208706
1933
1934         Reviewed by Žan Doberšek.
1935
1936         Add test case to check surrounding text in multiline context.
1937
1938         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
1939         (testWebKitInputMethodContextSurrounding):
1940
1941 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
1942
1943         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
1944         https://bugs.webkit.org/show_bug.cgi?id=208783
1945
1946         Reviewed by Brent Fulgham.
1947
1948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1949
1950 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
1951
1952         Replace the use of term "rollout" to "revert" in various tools
1953         https://bugs.webkit.org/show_bug.cgi?id=208775
1954
1955         Reviewed by Ryosuke Niwa.
1956
1957         See this webkit-dev thread for the originating discussion:
1958         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
1959
1960         'rollout' is a confusing term to anyone unacquainted with WebKit;
1961         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
1962
1963         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
1964         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
1965
1966         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
1967         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1969         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
1970         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
1971         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1972         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1973         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1974         * BuildSlaveSupport/ews-build/steps.py:
1975         * BuildSlaveSupport/ews-build/steps_unittest.py:
1976         * Scripts/webkit-tools-completion.sh:
1977         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1978         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1979         * Scripts/webkitpy/common/checkout/scm/svn.py:
1980         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1981         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1982         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1983         * Scripts/webkitpy/tool/bot/feeders.py:
1984         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1985         * Scripts/webkitpy/tool/bot/irc_command.py:
1986         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1987         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1988         * Scripts/webkitpy/tool/bot/sheriff.py:
1989         * Scripts/webkitpy/tool/commands/download.py:
1990         * Scripts/webkitpy/tool/commands/download_unittest.py:
1991         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1992         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1993         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1994         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1995         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1996         * Scripts/webkitpy/tool/steps/__init__.py:
1997         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1998         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1999         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2000         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
2001
2002 2020-03-07  David Quesada  <david_quesada@apple.com>
2003
2004         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
2005         https://bugs.webkit.org/show_bug.cgi?id=208781
2006         rdar://problem/60061016
2007
2008         Reviewed by Alex Christensen.
2009
2010         Add a test that recreates the conditions of this crash:
2011         - Send a message from the injected bundle to the UI process that contains a reply block.
2012         - Hold a reference to the reply block.
2013         - Let the web view deallocate.
2014         - Call the block, and expect not to crash.
2015
2016         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
2017         (localObjectInterface):
2018         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
2019         (-[LocalObject doSomethingWithCompletionHandler:]):
2020         (TEST):
2021         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
2022         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
2023
2024 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
2025
2026         TextManipulationController should work with ARIA labels
2027         https://bugs.webkit.org/show_bug.cgi?id=208759
2028
2029         Reviewed by Wenson Hsieh.
2030
2031         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2032         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
2033         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
2034         the expected number of tokens for the first item as the very first image is correctly
2035         detected per the code change. 
2036         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
2037
2038 2020-03-07  Alex Christensen  <achristensen@webkit.org>
2039
2040         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
2041         https://bugs.webkit.org/show_bug.cgi?id=208767
2042
2043         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2044         The frameID of the main frame before loading is only 0 on Mac right now.
2045         The test is still good because it validates that execution works in the main frame before loading.
2046
2047 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
2048
2049         [ews] commit queue is not skipping layout tests for rollout patches
2050         https://bugs.webkit.org/show_bug.cgi?id=208716
2051
2052         Unreviewed minor fix.
2053
2054         * BuildSlaveSupport/ews-build/steps.py:
2055         (RunWebKitTests.doStepIf):
2056         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
2057         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
2058
2059 2020-03-05  Sam Weinig  <weinig@apple.com>
2060
2061         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2062         https://bugs.webkit.org/show_bug.cgi?id=207436
2063         <rdar://problem/59296762>
2064
2065         Reviewed by Darin Adler.
2066
2067         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2068         Remove JSC related defines.
2069
2070 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
2071
2072         AX: Provide a way to run tests in isolated tree mode
2073         https://bugs.webkit.org/show_bug.cgi?id=208629
2074         <rdar://problem/60075583>
2075
2076         Reviewed by Ryosuke Niwa.
2077
2078         Provide the ability to run tests for accessibility in the isolated tree mode.
2079         This sends a flag over to the injected bundle which calls the right HIServices override so that
2080         the system thinks it is in isolated mode.
2081
2082         * Scripts/compare-webkit-configurations:
2083         (flag_for_comparison):
2084         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2085         (parse_args):
2086         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2087         (parse_args):
2088         * Scripts/webkitpy/port/driver.py:
2089         (Driver.cmd_line):
2090         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2091         (WTR::AccessibilityController::AccessibilityController):
2092         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
2093         (WTR::AccessibilityController::updateIsolatedTreeMode):
2094         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
2095         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2096         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2097         (WTR::InjectedBundle::didReceiveMessageToPage):
2098         (WTR::InjectedBundle::beginTesting):
2099         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2100         * WebKitTestRunner/Options.cpp:
2101         (WTR::handleOptionAccessibilityIsolatedTreeMode):
2102         (WTR::OptionsHandler::OptionsHandler):
2103         * WebKitTestRunner/Options.h:
2104         * WebKitTestRunner/TestController.cpp:
2105         (WTR::TestController::initialize):
2106         (WTR::TestController::resetPreferencesToConsistentValues):
2107         (WTR::TestController::resetStateToConsistentValues):
2108         * WebKitTestRunner/TestController.h:
2109         (WTR::TestController::accessibilityIsolatedTreeMode const):
2110
2111 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
2112
2113         [Cocoa] Re-enable CFPrefs direct mode
2114         https://bugs.webkit.org/show_bug.cgi?id=208690
2115
2116         Reviewed by Brent Fulgham.
2117
2118         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2119         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
2120         (TEST):
2121         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
2122         (TestWebKitAPI::TEST):
2123
2124 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
2125
2126         UIProcess needs mechanism to specify AppBound domains
2127         https://bugs.webkit.org/show_bug.cgi?id=208528
2128         <rdar://problem/59980340>
2129
2130         Reviewed by Brent Fulgham.
2131
2132         Added test app-bound domains to the plist and tested that the domains
2133         are properly stored in the website data store after a navigation.
2134
2135         * TestWebKitAPI/Info.plist:
2136         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
2137         (TEST):
2138
2139 2020-03-06  Alex Christensen  <achristensen@webkit.org>
2140
2141         Add SPI to disable cross origin access control checks
2142         https://bugs.webkit.org/show_bug.cgi?id=208748
2143
2144         Reviewed by Tim Hatcher.
2145
2146         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2147         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
2148
2149 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
2150
2151         [webkitpy] Fix executive on Windows to run wpt server correctly
2152         https://bugs.webkit.org/show_bug.cgi?id=208693
2153
2154         Reviewed by Jonathan Bedard.
2155
2156         Bug fix for Windows environment a) fixing a typo. b) fixing path
2157         c) fix how to kill subprocesses.
2158
2159         * Scripts/webkitpy/common/system/executive.py:
2160         (Executive._windows_kill_command):
2161         (Executive.interrupt):
2162         (Executive.kill_all):
2163         * Scripts/webkitpy/port/base.py:
2164         (Port.web_platform_test_server_doc_root):
2165
2166 2020-03-06  Alex Christensen  <achristensen@webkit.org>
2167
2168         Evaluating JavaScript in main frame before loading should succeed
2169         https://bugs.webkit.org/show_bug.cgi?id=208733
2170
2171         Reviewed by Tim Horton.
2172
2173         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2174
2175 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
2176
2177         TextManipulationController should preserve images
2178         https://bugs.webkit.org/show_bug.cgi?id=208692
2179
2180         Reviewed by Wenson Hsieh.
2181
2182         Added tests for preserving images and their ordering.
2183
2184         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2185         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
2186         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
2187         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
2188
2189 2020-03-06  David Quesada  <david_quesada@apple.com>
2190
2191         Add _WKResourceLoadInfo.resourceType SPI
2192         https://bugs.webkit.org/show_bug.cgi?id=208723
2193
2194         Reviewed by Alex Christensen.
2195
2196         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2197         (TEST):
2198
2199 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
2200
2201         Stop reporting to webkit-test-results.webkit.org
2202         https://bugs.webkit.org/show_bug.cgi?id=207218
2203
2204         Reviewed by Alexey Proskuryakov.
2205
2206         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2207         (RunWebKitTests):
2208
2209 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
2210
2211         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
2212         https://bugs.webkit.org/show_bug.cgi?id=208365
2213         <rdar://problem/59877296>
2214
2215         Reviewed by Geoffrey Garen.
2216
2217         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2218         (TEST):
2219
2220 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
2221
2222         EWS should be able to fetch patch status for security bugs while processing them
2223         https://bugs.webkit.org/show_bug.cgi?id=206511
2224
2225         Reviewed by Alexey Proskuryakov.
2226
2227         * BuildSlaveSupport/ews-build/steps.py:
2228         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
2229         (BugzillaMixin.get_patch_json): 
2230         (BugzillaMixin.get_bug_json):
2231         (BugzillaMixin._is_bug_closed):
2232         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
2233         (TransferToS3.hideStepIf): Ditto.
2234
2235 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
2236
2237         [ews] commit-queue should show the trac url for the commit on the build page
2238         https://bugs.webkit.org/show_bug.cgi?id=208715
2239
2240         Reviewed by Jonathan Bedard.
2241
2242         * BuildSlaveSupport/ews-build/steps.py:
2243         (PushCommitToWebKitRepo.evaluateCommand):
2244
2245 2020-03-06  Alex Christensen  <achristensen@webkit.org>
2246
2247         Fix ResourceLoadDelegate.LoadInfo API test after r257816
2248         https://bugs.webkit.org/show_bug.cgi?id=208550
2249
2250         * TestWebKitAPI/cocoa/HTTPServer.mm:
2251         (TestWebKitAPI::HTTPServer::respondToRequests):
2252         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
2253         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
2254
2255 2020-03-06  Lauro Moura <lmoura@igalia.com>
2256
2257         [WPE][WebDriver] MiniBrowser should react to close session commands
2258         https://bugs.webkit.org/show_bug.cgi?id=207529
2259
2260         Reviewed by Carlos Garcia Campos.
2261
2262         Do not call g_object_unref on the first created view if it has already
2263         been disposed in the "close" signal handler.
2264
2265         Based on original patch by Yury Semikhatsky.
2266
2267         * MiniBrowser/wpe/main.cpp:
2268         (main):
2269
2270 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
2271
2272         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
2273         https://bugs.webkit.org/show_bug.cgi?id=208647
2274
2275         Reviewed by Carlos Garcia Campos.
2276
2277         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2278         (TestWebKitAPI::TEST):
2279
2280 2020-03-05  Alex Christensen  <achristensen@webkit.org>
2281
2282         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
2283         https://bugs.webkit.org/show_bug.cgi?id=208670
2284
2285         Reviewed by Brady Eidson.
2286
2287         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2288         (-[FrameNavigationDelegate waitForNavigations:]):
2289         (-[FrameNavigationDelegate requests]):
2290         (-[FrameNavigationDelegate frames]):
2291         (-[FrameNavigationDelegate callbacks]):
2292         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
2293         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
2294         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
2295         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
2296         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
2297         (TEST):
2298
2299 2020-03-05  Alex Christensen  <achristensen@webkit.org>
2300
2301         Add WKFrameInfo._parentFrameHandle SPI
2302         https://bugs.webkit.org/show_bug.cgi?id=208674
2303
2304         Reviewed by Brady Eidson.
2305
2306         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2307
2308 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
2309
2310         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
2311         https://bugs.webkit.org/show_bug.cgi?id=208626
2312         <rdar://problem/60074148>
2313
2314         Reviewed by Brent Fulgham.
2315
2316         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2317         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2318         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
2319         (TestWebKitAPI::TEST):
2320         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
2321         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
2322         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
2323
2324 2020-03-05  Antoine Quint  <graouts@apple.com>
2325
2326         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
2327         https://bugs.webkit.org/show_bug.cgi?id=208644
2328         <rdar://problem/60042429>
2329
2330         Reviewed by Brady Eidson.
2331
2332         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
2333         
2334         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
2335            empty document has been removed in favor of the document for the requested URL,
2336         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
2337            correctly does not injected the style sheet.
2338
2339         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2340
2341 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2342
2343         [ews] Add build step to push commit to WebKit repository
2344         https://bugs.webkit.org/show_bug.cgi?id=208589
2345
2346         Reviewed by Jonathan Bedard.
2347
2348         * BuildSlaveSupport/ews-build/steps.py:
2349         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
2350         (PushCommitToWebKitRepo.start): Initialize log observer.
2351         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
2352         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
2353         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
2354         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
2355         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2356         * BuildSlaveSupport/ews-build/factories.py:
2357
2358 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2359
2360         [ews] Add unit tests for ValidateCommiterAndReviewer build step
2361         https://bugs.webkit.org/show_bug.cgi?id=208262
2362
2363         Reviewed by Jonathan Bedard.
2364
2365         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
2366
2367 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2368
2369         commit-queue should run WK2 tests instead of WK1 tests
2370         https://bugs.webkit.org/show_bug.cgi?id=208544
2371
2372         Reviewed by Jonathan Bedard.
2373
2374         * BuildSlaveSupport/ews-build/factories.py:
2375
2376 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
2377
2378         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
2379         https://bugs.webkit.org/show_bug.cgi?id=208645
2380
2381         Reviewed by Alexey Proskuryakov.
2382
2383         * BuildSlaveSupport/ews-build/steps.py:
2384         (ValidateCommiterAndReviewer.load_contributors):
2385         (ValidateCommiterAndReviewer.start):
2386
2387 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2388
2389         style-checker: Add UAF to the list of security words to warn about.
2390         https://bugs.webkit.org/show_bug.cgi?id=208643
2391
2392         Reviewed by Jonathan Bedard.
2393
2394         UAF is a common acronym used for use after free.
2395
2396         * Scripts/webkitpy/style/checkers/changelog.py:
2397         (ChangeLogChecker.check_for_unwanted_security_phrases):
2398
2399 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
2400
2401         [MSVC] Add .natvis support of WebKit types
2402         https://bugs.webkit.org/show_bug.cgi?id=193119
2403
2404         Reviewed by Don Olmstead.
2405
2406         To help the WebKit developer while debugging, this file defines how
2407         WebKit types are displayed in debugger of Visual Studio.
2408         Very limited set of WebKit types, but it changes the world.
2409
2410         * VisualStudio/WebKit.natvis: Added.
2411
2412 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2413
2414         Add system trace points around display list replay
2415         https://bugs.webkit.org/show_bug.cgi?id=208616
2416
2417         Reviewed by Simon Fraser.
2418
2419         Add a new "Display list replay" trace point.
2420
2421         * Tracing/SystemTracePoints.plist:
2422
2423 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2424
2425         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
2426         https://bugs.webkit.org/show_bug.cgi?id=208615
2427         <rdar://problem/59406743>
2428
2429         Reviewed by Alex Christensen.
2430
2431         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2432         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
2433         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2434         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
2435         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2436         (TEST):
2437         Also make a test written in bug 206310 actually run code.
2438
2439 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2440
2441         [build.webkit.org] Remove leaks queue
2442         https://bugs.webkit.org/show_bug.cgi?id=208580
2443
2444         Reviewed by Jonathan Bedard.
2445
2446         * BuildSlaveSupport/build.webkit.org-config/config.json:
2447         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
2448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2449
2450 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2451
2452         Add SPI to evaluate JavaScript in an iframe
2453         https://bugs.webkit.org/show_bug.cgi?id=208605
2454
2455         Reviewed by Brady Eidson.
2456
2457         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2458
2459 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
2460
2461         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
2462         https://bugs.webkit.org/show_bug.cgi?id=208533
2463         <rdar://problem/60010184>
2464
2465         Reviewed by Alex Christensen.
2466
2467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2468         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2469         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
2470         (TestWebKitAPI::TEST):
2471         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
2472         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
2473
2474 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2475
2476         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
2477         https://bugs.webkit.org/show_bug.cgi?id=208593
2478
2479         Reviewed by Brady Eidson.
2480
2481         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2482         (TestWebKitAPI::TEST):
2483
2484 2020-03-04  Alex Christensen  <achristensen@webkit.org>
2485
2486         WKWebView's frames accessor should return a traversable type
2487         https://bugs.webkit.org/show_bug.cgi?id=208591
2488
2489         Reviewed by Brady Eidson.
2490
2491         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
2492
2493 2020-03-04  Antoine Quint  <graouts@apple.com>
2494
2495         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
2496         https://bugs.webkit.org/show_bug.cgi?id=208575
2497         <rdar://problem/59773690>
2498
2499         Reviewed by Brady Eidson.
2500
2501         Add new tests for the new SPI which check:
2502         
2503         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
2504            specified WKWebView alone,
2505         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
2506         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
2507         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
2508         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
2509         6. and that the same test also works with PSON enabled.
2510
2511         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2512
2513 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
2514
2515         [macOS] test-lldb-webkit failing on debug bots
2516         https://bugs.webkit.org/show_bug.cgi?id=208545
2517
2518         Reviewed by Jonathan Bedard.
2519
2520         The lldb-webkit-test step must pass in the build configuration as an
2521         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
2522         binary that is downloaded with the rest of the build products. Without this
2523         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
2524         regardless of their actual build configuration.
2525
2526         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2527         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
2528         * Scripts/test-lldb-webkit:
2529         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
2530
2531 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2532
2533         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
2534         https://bugs.webkit.org/show_bug.cgi?id=208539
2535
2536         Unreviewed follow-up fix.
2537
2538         * BuildSlaveSupport/ews-build/steps.py:
2539
2540 2020-03-04  Daniel Bates  <dabates@apple.com>
2541
2542         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
2543         https://bugs.webkit.org/show_bug.cgi?id=208565
2544
2545         Reviewed by Wenson Hsieh.
2546
2547         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
2548         of its frame as a means to find all the editable elements in the visible content area
2549         of the web view.
2550
2551         Coincidentally this makes no difference to the test results right now because the web view
2552         happens to be located at the origin (0, 0) in the window. However if in the future the
2553         web view would be located at some other point then the tests may fail because the rectangle
2554         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
2555         rectangle for the visible content area.
2556
2557         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2558         (TEST):
2559
2560 2020-03-04  Daniel Bates  <dabates@apple.com>
2561
2562         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
2563         https://bugs.webkit.org/show_bug.cgi?id=208564
2564
2565         Reviewed by Alex Christensen.
2566
2567         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
2568         to make it easy to run just these tests.
2569
2570         Currently, the tests are organized under the test case name WebKit. This means you need to
2571         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
2572         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
2573         so that a person can run just these test using:
2574         
2575                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
2576
2577         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2578         (TEST):
2579
2580 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2581
2582         [ews] Add build step to create local git commit for commit-queue
2583         https://bugs.webkit.org/show_bug.cgi?id=208539
2584
2585         Reviewed by Jonathan Bedard.
2586
2587         * BuildSlaveSupport/ews-build/steps.py:
2588         (CreateLocalGITCommit): Build step to create local git commit.
2589         (CreateLocalGITCommit.start):
2590         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
2591         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
2592         * BuildSlaveSupport/ews-build/factories.py:
2593
2594 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
2595
2596         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
2597         https://bugs.webkit.org/show_bug.cgi?id=207948
2598
2599         Reviewed by Zalan Bujtas.
2600
2601         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
2602         so that it receives the wheel events.
2603
2604         * DumpRenderTree/mac/EventSendingController.mm:
2605         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2606         * DumpRenderTree/win/EventSender.cpp:
2607         (mouseScrollBy):
2608
2609 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
2610
2611         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
2612         https://bugs.webkit.org/show_bug.cgi?id=208520
2613         <rdar://problem/60000214>
2614
2615         Reviewed by Chris Fleizach.
2616
2617         Calling InjectedBundle::singleton().page()->page() in the constructor
2618         of the AccessibilityController is having this side effect on iOS.
2619         So #if to MAC where it's actually being used.
2620
2621         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2622         (WTR::AccessibilityController::AccessibilityController):
2623
2624 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2625
2626         Add SPI _WKResourceLoadInfo.loadedFromCache
2627         https://bugs.webkit.org/show_bug.cgi?id=208554
2628
2629         Reviewed by Wenson Hsieh.
2630
2631         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2632         (TEST):
2633
2634 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2635
2636         Batch observations and completions of text manipulations
2637         https://bugs.webkit.org/show_bug.cgi?id=208406
2638
2639         Reviewed by Wenson Hsieh.
2640
2641         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
2642         multiple paragraphs at once.
2643
2644         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2645         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
2646         (-[TextManipulationDelegate items]):
2647         (-[LegacyTextManipulationDelegate init]):
2648         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
2649         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
2650         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
2651         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
2652         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
2653         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
2654         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
2655
2656 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
2657
2658         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2659         https://bugs.webkit.org/show_bug.cgi?id=208415
2660
2661         Reviewed by Brent Fulgham.
2662
2663         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2664         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2665         (TEST):
2666
2667 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2668
2669         Add response to _WKResourceLoadDelegate didCompleteWithError callback
2670         https://bugs.webkit.org/show_bug.cgi?id=208553
2671
2672         Reviewed by Simon Fraser.
2673
2674         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2675         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
2676         (TEST):
2677         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
2678
2679 2020-03-03  Brady Eidson  <beidson@apple.com>
2680
2681         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
2682         https://bugs.webkit.org/show_bug.cgi?id=198795
2683
2684         Reviewed by Chris Dumez.
2685
2686         This test appears to no longer be flaky.
2687         
2688         Let's re-enable it.
2689         
2690         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2691         (TestWebKitAPI::TEST):
2692
2693 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2694
2695         Requests sent to _WKResourceLoadDelegate should include HTTPBody
2696         https://bugs.webkit.org/show_bug.cgi?id=208550
2697
2698         Reviewed by Tim Hatcher.
2699
2700         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2701         (TEST):
2702         * TestWebKitAPI/cocoa/HTTPServer.mm:
2703         (TestWebKitAPI::HTTPServer::respondToRequests):
2704         HTTPServer now looks for Content-Length in its request.
2705         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
2706
2707 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2708
2709         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
2710         https://bugs.webkit.org/show_bug.cgi?id=208522
2711
2712         Reviewed by Brian Weinstein.
2713
2714         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2715         (TEST):
2716
2717 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2718
2719         commit-queue should update working directory and reapply patch just before commiting
2720         https://bugs.webkit.org/show_bug.cgi?id=208521
2721
2722         Reviewed by Jonathan Bedard.
2723
2724         * BuildSlaveSupport/ews-build/factories.py:
2725
2726 2020-03-03  Matt Lewis  <jlewis3@apple.com>
2727
2728         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
2729         https://bugs.webkit.org/show_bug.cgi?id=208485
2730
2731         Reviewed by Jonathan Bedard.
2732
2733         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2734         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
2735         that we don't have to recreate the variables that are already created.
2736         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
2737         from each module, rather than making extra imports that we don't need.
2738         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
2739         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
2740         and not part of the host.
2741         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
2742         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
2743         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
2744         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
2745         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
2746         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
2747         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
2748         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
2749         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
2750         if we were geting any value at all
2751         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
2752         sure we aren't gabking the wrong key:value pair
2753         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
2754         come with the MockHosts and MockHost inherits from MockSystemHost.
2755         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
2756         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
2757         to the various upload steps.
2758
2759 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2760
2761         [ews] Add build step to find list of modified changelogs
2762         https://bugs.webkit.org/show_bug.cgi?id=208514
2763
2764         Reviewed by Jonathan Bedard.
2765
2766         * BuildSlaveSupport/ews-build/factories.py:
2767         * BuildSlaveSupport/ews-build/steps.py:
2768         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
2769         (FindModifiedChangeLogs.start): Initialize log observer.
2770         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
2771         (FindModifiedChangeLogs.evaluateCommand):
2772         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
2773         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
2774         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
2775         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2776
2777 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
2778
2779         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
2780         https://bugs.webkit.org/show_bug.cgi?id=208451
2781
2782         Unreviewed test gardening.
2783
2784         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
2785
2786 2020-03-03  Jiten Mehta  <jmehta@apple.com>
2787
2788         Adopt HTTP Alternative Services Storage
2789         https://bugs.webkit.org/show_bug.cgi?id=208387
2790
2791         Reviewed by Alex Christensen.
2792
2793         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2794         (checkUntilEntryFound):
2795         (TEST):
2796
2797 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
2798
2799         Check for navigation to app-bound domain during script evaluation
2800         https://bugs.webkit.org/show_bug.cgi?id=208319
2801         <rdar://problem/57569321>
2802
2803         Reviewed by Brent Fulgham.
2804
2805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2806         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
2807         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2808         (TEST):
2809         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
2810         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
2811
2812 2020-03-03  Commit Queue  <commit-queue@webkit.org>
2813
2814         Unreviewed, rolling out r257754.
2815         https://bugs.webkit.org/show_bug.cgi?id=208513
2816
2817         Introduced API test failure (Requested by perarne on #webkit).
2818
2819         Reverted changeset:
2820
2821         "[Cocoa] Mapping from MIME type to UTI type should be done in
2822         the UI process"
2823         https://bugs.webkit.org/show_bug.cgi?id=208415
2824         https://trac.webkit.org/changeset/257754
2825
2826 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
2827
2828         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
2829         https://bugs.webkit.org/show_bug.cgi?id=208506
2830
2831         Reviewed by Carlos Garcia Campos.
2832
2833         * WebKitTestRunner/TestController.cpp:
2834         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
2835
2836 2020-03-02  Ben Nham  <nham@apple.com>
2837
2838         Add performance probes for HTML parsing
2839         https://bugs.webkit.org/show_bug.cgi?id=208271
2840
2841         Reviewed by Daniel Bates.
2842
2843         This adds probes that show which lines of HTML are have been parsed.
2844
2845         * Tracing/SystemTracePoints.plist:
2846
2847 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2848
2849         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2850         https://bugs.webkit.org/show_bug.cgi?id=208415
2851
2852         Reviewed by Brent Fulgham.
2853
2854         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2855         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2856         (TEST):
2857
2858 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2859
2860         Unreviewed, rolling out r257725.
2861
2862         This commit caused 10 API tests to fail
2863
2864         Reverted changeset:
2865
2866         "[Cocoa] Mapping from MIME type to UTI type should be done in
2867         the UI process"
2868         https://bugs.webkit.org/show_bug.cgi?id=208415
2869         https://trac.webkit.org/changeset/257725
2870
2871 2020-03-02  Saam Barati  <sbarati@apple.com>
2872
2873         Don't skip tests unnecessarily on arm64
2874         https://bugs.webkit.org/show_bug.cgi?id=208470
2875         <rdar://problem/59968869>
2876
2877         Reviewed by Tadeu Zagallo.
2878
2879         * Scripts/run-jsc-stress-tests:
2880
2881 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
2882
2883         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
2884         https://bugs.webkit.org/show_bug.cgi?id=208434
2885
2886         Reviewed by Chris Fleizach.
2887
2888         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2889         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
2890         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
2891         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2892         (WTR::AccessibilityController::accessibleElementById): Same as above.
2893
2894 2020-03-02  John Wilander  <wilander@apple.com>
2895
2896         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
2897         https://bugs.webkit.org/show_bug.cgi?id=208399
2898         <rdar://problem/24731650>
2899
2900         Reviewed by Brent Fulgham.
2901
2902         The majority of the changes in WTR::TestController is (partially) fixing a bug
2903         where the TestRunner would statically use the default website datastore instead
2904         of the website data store configure for the page. This worked for persistent
2905         storage testing but not for ephemeral sessions which is what this patch is all
2906         about. The previous TestController::websiteDataStore() is now called
2907         TestController::defaultWebsiteDataStore() and the new
2908         TestController::websiteDataStore() returns the configured website data store.
2909         Most of the use of the default website data store should probably change but
2910         that's not really for this patch to deal with. I did however move all of
2911         resource load statistics' use to the new TestController::websiteDataStore().
2912
2913         A new TestRunner function was added: isStatisticsEphemeral()
2914         It allows test cases to query the ephemeral status of resource load statistics.
2915
2916         One problem that is mitigated in this patch but not fully fixed is that for
2917         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
2918         TestController::generatePageConfiguration() via C API 
2919         WKPageConfigurationSetWebsiteDataStore(), and then again in 
2920         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
2921         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
2922         I tried removing the latter since one session for all platforms should be
2923         Enough but got broken behavior as a result. So now both are still there
2924         and both enable resource load statistics.
2925
2926         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2927         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2928         (WTR::TestRunner::isStatisticsEphemeral):
2929         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2930         * WebKitTestRunner/TestController.cpp:
2931         (WTR::TestController::defaultWebsiteDataStore):
2932         (WTR::TestController::websiteDataStore):
2933         (WTR::TestController::generatePageConfiguration):
2934         (WTR::TestController::resetPreferencesToConsistentValues):
2935         (WTR::TestController::resetStateToConsistentValues):
2936         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2937         (WTR::TestController::decidePolicyForNavigationAction):
2938         (WTR::TestController::platformAdjustContext):
2939         (WTR::TestController::clearServiceWorkerRegistrations):
2940         (WTR::TestController::clearDOMCache):
2941         (WTR::TestController::clearDOMCaches):
2942         (WTR::TestController::clearIndexedDatabases):
2943         (WTR::TestController::clearLocalStorage):
2944         (WTR::TestController::hasDOMCache):
2945         (WTR::TestController::domCacheSize):
2946         (WTR::TestController::setStatisticsEnabled):
2947         (WTR::TestController::isStatisticsEphemeral):
2948         (WTR::TestController::setStatisticsDebugMode):
2949         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
2950         (WTR::TestController::setStatisticsLastSeen):
2951         (WTR::TestController::setStatisticsMergeStatistic):
2952         (WTR::TestController::setStatisticsPrevalentResource):
2953         (WTR::TestController::setStatisticsVeryPrevalentResource):
2954         (WTR::TestController::dumpResourceLoadStatistics):
2955         (WTR::TestController::isStatisticsPrevalentResource):
2956         (WTR::TestController::isStatisticsVeryPrevalentResource):
2957         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
2958         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2959         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2960         (WTR::TestController::setStatisticsHasHadUserInteraction):
2961         (WTR::TestController::isStatisticsHasHadUserInteraction):
2962         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
2963         (WTR::TestController::setStatisticsGrandfathered):
2964         (WTR::TestController::isStatisticsGrandfathered):
2965         (WTR::TestController::setUseITPDatabase):
2966         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
2967         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
2968         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
2969         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
2970         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
2971         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
2972         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2973         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2974         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2975         (WTR::TestController::statisticsUpdateCookieBlocking):
2976         (WTR::TestController::statisticsSubmitTelemetry):
2977         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2978         (WTR::TestController::setStatisticsIsRunningTest):
2979         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2980         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2981         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2982         (WTR::TestController::setStatisticsGrandfatheringTime):
2983         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2984         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2985         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2986         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2987         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
2988         (WTR::TestController::statisticsDeleteCookiesForHost):
2989         (WTR::TestController::isStatisticsHasLocalStorage):
2990         (WTR::TestController::setStatisticsCacheMaxAgeCap):
2991         (WTR::TestController::hasStatisticsIsolatedSession):
2992         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
2993         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
2994         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
2995         (WTR::TestController::statisticsResetToConsistentState):
2996         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2997         * WebKitTestRunner/TestController.h:
2998         * WebKitTestRunner/TestInvocation.cpp:
2999         (WTR::TestInvocation::invoke):
3000         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3001         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3002         (WTR::initializeWebViewConfiguration):
3003         (WTR::TestController::platformCreateWebView):
3004
3005 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
3006
3007         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
3008         https://bugs.webkit.org/show_bug.cgi?id=208415
3009
3010         Reviewed by Brent Fulgham.
3011
3012         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3013         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
3014         (TEST):
3015
3016 2020-03-02  Daniel Bates  <dabates@apple.com>
3017
3018         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
3019         https://bugs.webkit.org/show_bug.cgi?id=208352
3020         <rdar://problem/59867815>
3021
3022         Reviewed by Wenson Hsieh.
3023
3024         Update test results to reflect the new behavior. To do this I also need to fix up the test code
3025         to actually scroll the web content. This also means we now execute the same code on both Mac and
3026         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
3027         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
3028         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
3029
3030         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3031         (TEST):
3032
3033 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
3034
3035         Unreviewed, rolling out r257687.
3036
3037         This commit caused debug tests to crash for macOS & iOS
3038
3039         Reverted changeset:
3040
3041         "[Cocoa] Mapping from MIME type to UTI type should be done in
3042         the UI process"
3043         https://bugs.webkit.org/show_bug.cgi?id=208415
3044         https://trac.webkit.org/changeset/257687
3045
3046 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3047
3048         Unreviewed, rolling out r257618.
3049
3050         This allegedly causes Safari to crash when closing a window
3051         (see rdar://problem/59922725).
3052
3053         Reverted changeset:
3054
3055         "UIProcess crash after using _prepareForMoveToWindow, then
3056         deallocating the WKWebView before moving to the window"
3057         https://bugs.webkit.org/show_bug.cgi?id=208365
3058         https://trac.webkit.org/changeset/257618
3059
3060 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
3061
3062         Remove std::lock_guard
3063         https://bugs.webkit.org/show_bug.cgi?id=206451
3064
3065         Reviewed by Anders Carlsson.
3066
3067         Add std::lock_guard lint rule to prevent from using it.
3068
3069         * Scripts/webkitpy/style/checkers/cpp.py:
3070         (check_lock_guard):
3071         (check_style):
3072         (CppChecker):
3073         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3074         (WebKitStyleTest.test_lock_guard):
3075         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3076         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3077         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
3078         (assertHasObjects):
3079         (assertHasOnlyObjects):
3080         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3081         (WTR::AXThread::dispatch):
3082         (WTR::AXThread::dispatchFunctionsFromAXThread):
3083         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3084         (WTR::AXThread::initializeRunLoop):
3085
3086 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
3087
3088         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
3089         https://bugs.webkit.org/show_bug.cgi?id=208415
3090
3091         Reviewed by Brent Fulgham.
3092
3093         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3094         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
3095         (TEST):
3096
3097 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3098
3099         Unreviewed, rolling out r257565.
3100
3101         It broke WinCairo MiniBrowser
3102
3103         Reverted changeset:
3104
3105         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
3106         https://bugs.webkit.org/show_bug.cgi?id=206894
3107         https://trac.webkit.org/changeset/257565
3108
3109 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
3110
3111         EWS fails to retry build in case of kill-old-processes exception
3112         https://bugs.webkit.org/show_bug.cgi?id=208003
3113
3114         Reviewed by Jonathan Bedard.
3115
3116         * BuildSlaveSupport/ews-build/steps.py:
3117         (KillOldProcesses.evaluateCommand):
3118         (KillOldProcesses.getResultSummary):
3119
3120 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
3121
3122         [ews] commit-queue should update the ChangeLog with Reviewer name
3123         https://bugs.webkit.org/show_bug.cgi?id=206535
3124
3125         Reviewed by Jonathan Bedard.
3126
3127         * BuildSlaveSupport/ews-build/steps.py:
3128         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
3129
3130 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
3131
3132         run-javascriptcore-tests: Make upload format valid
3133         https://bugs.webkit.org/show_bug.cgi?id=208341
3134
3135         Rubber-stamped by Aakash Jain.
3136
3137         * Scripts/run-javascriptcore-tests:
3138         (uploadResults): Remove. FIXME.
3139         * Scripts/webkitdirs.pm:
3140         (splitVersionString): Handle case where the subminor version number has a - in it.
3141         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
3142
3143 2020-02-28  youenn fablet  <youenn@apple.com>
3144
3145         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
3146         https://bugs.webkit.org/show_bug.cgi?id=208130
3147
3148         Reviewed by Eric Carlson.
3149
3150         * WebKitTestRunner/TestOptions.h:
3151         Use GPU process to capture by default.
3152         We will remove this option once done verifying that every test works smoothly.
3153
3154 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
3155
3156         [ews] commit queue should skip building and testing for rollout patches
3157         https://bugs.webkit.org/show_bug.cgi?id=208329
3158
3159         Reviewed by Jonathan Bedard.
3160
3161         * BuildSlaveSupport/ews-build/steps.py:
3162         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
3163         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
3164         (RunWebKit1Tests.doStepIf): Ditto.
3165         * BuildSlaveSupport/ews-build/steps_unittest.py:
3166         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
3167         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
3168
3169 2020-02-28  Daniel Bates  <dabates@apple.com>
3170
3171         Update my watch list preferences and contributor's entry.
3172
3173         * Scripts/webkitpy/common/config/contributors.json:
3174         * Scripts/webkitpy/common/config/watchlist:
3175
3176 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
3177
3178         Fix WebCore export macros for declspec
3179         https://bugs.webkit.org/show_bug.cgi?id=208363
3180
3181         Reviewed by Konstantin Tokarev.
3182
3183         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
3184         files. Removed precompiled headers that were empty.
3185
3186         * DumpRenderTree/DumpRenderTreePrefix.h:
3187         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
3188         * MiniBrowser/win/stdafx.h:
3189         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
3190         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
3191         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
3192         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
3193         * WebKitTestRunner/PlatformFTW.cmake:
3194         * WebKitTestRunner/PlatformWin.cmake:
3195         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
3196
3197 2020-02-27  Tim Horton  <timothy_horton@apple.com>
3198
3199         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
3200         https://bugs.webkit.org/show_bug.cgi?id=208365
3201
3202         Reviewed by Alex Christensen.
3203
3204         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
3205         (TEST):
3206         Add a test! It was a 100% repro crash before this change.
3207
3208 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
3209
3210         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
3211         https://bugs.webkit.org/show_bug.cgi?id=208260
3212         <rdar://problem/59820107>
3213
3214         Reviewed by Tim Horton.
3215
3216         Followed instructions for adding an Info.plist for Single-File Tools
3217         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
3218
3219         The default WebsiteDataStore file path will change with this test to
3220         reflect the new bundleID so we must change expectations for any api
3221         tests which rely on knowing the path.
3222
3223         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3224         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3225         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
3226         (TEST):
3227         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
3228         (TEST):
3229         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
3230         (TEST):
3231         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
3232         (TEST):
3233         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
3234         (TEST):
3235         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
3236         (TEST):
3237         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
3238         (TEST):
3239         (defaultWebsiteCacheDirectory):
3240         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
3241         (TEST):
3242         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3243         (TEST):
3244         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3245         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
3246         (TEST):
3247         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3248         (TEST):
3249         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3250         (runWebsiteDataStoreCustomPaths):
3251         (TEST):
3252         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
3253         (TestWebKitAPI::resetTestState):
3254         Now that we set a bundleID, we have to reset the cache model between
3255         tests, otherwise it gets stored between tests.
3256
3257         (TestWebKitAPI::TEST):
3258         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3259         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3260
3261 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
3262
3263         TextManipulationController should not generate a new item for content in manipulated paragraphs
3264         https://bugs.webkit.org/show_bug.cgi?id=208286
3265
3266         Reviewed by Wenson Hsieh.
3267
3268         Added a regression test.
3269
3270         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
3271         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
3272
3273 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
3274
3275         run-javascriptcore-tests: Make upload format valid
3276         https://bugs.webkit.org/show_bug.cgi?id=208341
3277
3278         Reviewed by Aakash Jain.
3279
3280         * Scripts/run-javascriptcore-tests:
3281         (uploadResults): Print json blob for upload after failure for debugging.
3282
3283 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
3284
3285         [CMake] Add WebKit::PAL target
3286         https://bugs.webkit.org/show_bug.cgi?id=198493
3287
3288         Reviewed by Michael Catanzaro.
3289
3290         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
3291
3292         * DumpRenderTree/PlatformWin.cmake:
3293
3294 2020-02-27  Alex Christensen  <achristensen@webkit.org>
3295
3296         Add SPI to query WKFrameInfos in a WKWebView
3297         https://bugs.webkit.org/show_bug.cgi?id=208212
3298
3299         Reviewed by Brady Eidson.
3300
3301         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3302         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
3303         * WebKitTestRunner/TestController.cpp:
3304         (WTR::TestController::saltForOrigin):
3305
3306 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
3307
3308         Unreviewed, rolling out r257530.
3309
3310         This commit seems to have broke the build internally for
3311         watchOS
3312
3313         Reverted changeset:
3314
3315         "Add SPI to query WKFrameInfos in a WKWebView"
3316         https://bugs.webkit.org/show_bug.cgi?id=208212
3317         https://trac.webkit.org/changeset/257530
3318
3319 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
3320
3321         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
3322         https://bugs.webkit.org/show_bug.cgi?id=206894
3323
3324         Reviewed by Adrian Perez de Castro.
3325
3326         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
3327         MiniBrowsers.
3328
3329         * MiniBrowser/gtk/CMakeLists.txt:
3330         * MiniBrowser/win/CMakeLists.txt:
3331         * MiniBrowser/wpe/CMakeLists.txt:
3332
3333 2020-02-26  Alex Christensen  <achristensen@webkit.org>
3334
3335         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
3336         https://bugs.webkit.org/show_bug.cgi?id=206456
3337
3338         Reviewed by Brady Eidson.
3339
3340         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3341         (TEST):
3342
3343 2020-02-26  Alex Christensen  <achristensen@webkit.org>
3344
3345         _WKUserContentWorld should be a wrapper around WKContentWorld
3346         https://bugs.webkit.org/show_bug.cgi?id=208274
3347
3348         Reviewed by Brady Eidson.
3349
3350         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
3351         (TEST):
3352         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3353         (TEST):
3354
3355 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
3356
3357         Unreviewed, rolling out r257522.
3358
3359         Caused 16 API test failures on the bots
3360
3361         Reverted changeset:
3362
3363         "TestWebKitAPI and WebKitTestRunner should have bundle
3364         identifiers"
3365         https://bugs.webkit.org/show_bug.cgi?id=208260
3366         https://trac.webkit.org/changeset/257522
3367
3368 2020-02-26  Alex Christensen  <achristensen@webkit.org>
3369
3370         Add SPI to query WKFrameInfos in a WKWebView
3371         https://bugs.webkit.org/show_bug.cgi?id=208212
3372
3373         Reviewed by Brady Eidson.
3374
3375         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3376         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
3377         * WebKitTestRunner/TestController.cpp:
3378         (WTR::TestController::saltForOrigin):
3379
3380 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
3381
3382         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
3383         https://bugs.webkit.org/show_bug.cgi?id=208260
3384         <rdar://problem/59820107>
3385
3386         Reviewed by Tim Horton.
3387
3388         Followed instructions for adding an Info.plist for Single-File Tools
3389         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
3390
3391         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3392         * TestWebKitAPI/Info.plist: Added.
3393         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3394         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3395         * WebKitTestRunner/Info.plist: Added.
3396         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3397
3398 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
3399
3400         Tests should each use a unique ResourceLoadStatistics file path for its database store
3401         https://bugs.webkit.org/show_bug.cgi?id=208206
3402         <rdar://problem/59690272>
3403
3404         Reviewed by Brady Eidson.
3405
3406         Initialize a default website data store before checking for the ITP
3407         store to ensure the directory exists after the file has been deleted.
3408
3409         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
3410         (TEST):
3411
3412 2020-02-26  Christopher Reid  <chris.reid@sony.com>
3413
3414         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
3415         https://bugs.webkit.org/show_bug.cgi?id=197684
3416         <rdar://problem/59467397>
3417
3418         Reviewed by Yusuke Suzuki.
3419
3420         Add test for FileSystem::createFile
3421
3422         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3423
3424 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
3425
3426         [ews] commit-queue should verify patch committer and reviewer
3427         https://bugs.webkit.org/show_bug.cgi?id=206532
3428
3429         Reviewed by Jonathan Bedard.
3430
3431         * BuildSlaveSupport/ews-build/steps.py:
3432         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
3433         (ValidateCommiterAndReviewer._addToLog):
3434         (ValidateCommiterAndReviewer.getResultSummary):
3435         (ValidateCommiterAndReviewer.fail_build):
3436         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
3437         (ValidateCommiterAndReviewer.is_reviewer):
3438         (ValidateCommiterAndReviewer.is_committer):
3439         (ValidateCommiterAndReviewer.full_name_from_email):
3440         (ValidateCommiterAndReviewer.start):
3441
3442 2020-02-26  Daniel Bates  <dabates@apple.com>
3443
3444         [iOS] Send focus update immediately on becoming or resigning first responder
3445         https://bugs.webkit.org/show_bug.cgi?id=208082
3446         <rdar://problem/59688413>
3447
3448         Rubber-stamped by Jer Noble.
3449
3450         Add a test to ensure that selecting a position at a point after the web view
3451         becomes first responder is allowed. Such an operation is only allowed if the
3452         web view is focused.
3453
3454         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
3455         (-[TestWKWebView selectPositionAtPoint:]):
3456         (TEST):
3457         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
3458
3459 2020-02-26  Chris Dumez  <cdumez@apple.com>
3460
3461         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
3462
3463         The test was added for macOS and times out on iOS.
3464
3465         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3466         (TEST):
3467
3468 2020-02-26  Youenn Fablet  <youenn@apple.com>
3469
3470         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
3471         https://bugs.webkit.org/show_bug.cgi?id=208238
3472
3473         Reviewed by Eric Carlson.
3474
3475         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3476         (TEST):
3477         Remove use of deleted parameter.
3478
3479 2020-02-25  Devin Rousso  <drousso@apple.com>
3480
3481         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
3482         https://bugs.webkit.org/show_bug.cgi?id=206911
3483         <rdar://problem/58026635>
3484
3485         Reviewed by Brian Burg.
3486
3487         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3488         (TestWebKitAPI::TEST):
3489         Add test for `WTF::HashSet::reserveInitialCapacity`.
3490
3491         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3492         (TestWebKitAPI::TEST):
3493         Actually check the value of `WTF::HashMap::capacity`.
3494
3495         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
3496         (-[InspectorDelegate _webView:didAttachInspector:])
3497         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
3498         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
3499         (TestWebKitAPI::TEST):
3500         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
3501         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
3502         (TestWebKitAPI::TEST): Deleted.
3503
3504 2020-02-25  Matt Lewis  <jlewis3@apple.com>
3505
3506         Add checkout_root to stubrepository.py
3507         https://bugs.webkit.org/show_bug.cgi?id=208213
3508
3509         Reviewed by Jonathan Bedard.
3510
3511         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
3512         (StubRepository.__init__):
3513
3514         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
3515         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
3516
3517 2020-02-25  Daniel Bates  <dabates@apple.com>
3518
3519         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
3520         https://bugs.webkit.org/show_bug.cgi?id=208214
3521
3522         Reviewed by Wenson Hsieh.
3523
3524         Wait until the copy operation completes before loading the second web view and testing paste
3525         to ensure that something was actually copied to the clipboard.
3526
3527         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
3528         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3529         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
3530         so that we wait until the command completes.
3531
3532 2020-02-25  Chris Dumez  <cdumez@apple.com>
3533
3534         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
3535         https://bugs.webkit.org/show_bug.cgi?id=208199
3536         <rdar://problem/59746887>
3537
3538         Reviewed by Alex Christensen.
3539
3540         Add API test coverage.
3541
3542         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3543         (TEST):
3544
3545 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3546
3547         spinRunLoop should take a non-zero integer as parameter
3548         https://bugs.webkit.org/show_bug.cgi?id=208148
3549         <rdar://problem/59766682>
3550
3551         Unreviewed iOS build fix.
3552
3553         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3554         (TestWebKitAPI::Util::spinRunLoop):
3555
3556 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3557
3558         spinRunLoop should take a non-zero integer as parameter
3559         https://bugs.webkit.org/show_bug.cgi?id=208148
3560
3561         Reviewed by Darin Adler.
3562
3563         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3564         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3565         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3566         (TestWebKitAPI::Util::spinRunLoop):
3567
3568 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3569
3570         [WTF] Add tests for CompactRefPtrTuple
3571         https://bugs.webkit.org/show_bug.cgi?id=208172
3572
3573         Reviewed by Darin Adler.
3574
3575         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
3576         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
3577
3578         * TestWebKitAPI/CMakeLists.txt:
3579         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3580         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
3581         (TestWebKitAPI::TEST):
3582
3583 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
3584
3585         [ews] commit-queue should check that patch have appropriate review flag
3586         https://bugs.webkit.org/show_bug.cgi?id=208138
3587
3588         Reviewed by Jonathan Bedard.
3589
3590         * BuildSlaveSupport/ews-build/steps.py:
3591         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
3592         (BugzillaMixin._is_patch_cq_plus):
3593         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
3594         (ValidatePatch.start):
3595
3596 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
3597
3598         [WebAuthn] Implement SPI for the platform authenticator
3599         https://bugs.webkit.org/show_bug.cgi?id=208087
3600         <rdar://problem/59369305>
3601
3602         Reviewed by Brent Fulgham.
3603
3604         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
3605
3606         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
3607         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3608         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3609         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3610         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
3611         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
3612         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
3613         (TestWebKitAPI::TEST):
3614         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
3615         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
3616         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
3617         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
3618
3619 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3620
3621         Unreviewed, updating LLDB test for CompactPointerTuple.
3622         https://bugs.webkit.org/show_bug.cgi?id=207827
3623
3624         * lldb/lldb_webkit.py:
3625         (WTFCompactPointerTupleProvider):
3626         (WTFCompactPointerTupleProvider.update):
3627
3628 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
3629
3630         Provide alternate way to name Web Content process
3631         https://bugs.webkit.org/show_bug.cgi?id=205224
3632         rdar://57038084
3633
3634         Reviewed by Alex Christensen.
3635
3636         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3637         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
3638         (TestWebKitAPI::TEST):
3639
3640 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
3641
3642         results.webkit.org: Link to result archives
3643         https://bugs.webkit.org/show_bug.cgi?id=207646
3644         <rdar://problem/59395807>
3645
3646         Rubber-stamped by Aakash Jain.
3647
3648         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
3649         (_ArchiveRouter): Retrieve json from archive-router endpoint.
3650         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
3651         return the most specific value.
3652         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
3653         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
3654         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
3655         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3656         (parametersForInstance): Extract from lambda function.
3657         (testRunLink): Use parametersForInstance instead of a lambda function.
3658         (archiveLink): Return an archive link for data. 
3659         (contentForData): Add archive link to view.
3660         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3661         (TimelineFromEndpoint): Accept both suite and test.
3662         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
3663         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
3664         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
3665         * resultsdbpy/resultsdbpy/view/view_routes.py:
3666         (ViewRoutes.__init__): Add archive_route dictionary.
3667
3668 2020-02-24  Alex Christensen  <achristensen@webkit.org>
3669
3670         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
3671         https://bugs.webkit.org/show_bug.cgi?id=208035
3672         <rdar://problem/58011337>
3673
3674         Reviewed by Tim Hatcher.
3675
3676         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3677
3678 2020-02-22  Darin Adler  <darin@apple.com>
3679
3680         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
3681         https://bugs.webkit.org/show_bug.cgi?id=208099
3682
3683         Reviewed by Antti Koivisto.
3684
3685         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3686         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
3687         so we can use the -[NSString createJSStringRef] method.
3688         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
3689         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
3690
3691 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3692
3693         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
3694         https://bugs.webkit.org/show_bug.cgi?id=208096
3695         <rdar://problem/59632008>
3696
3697         Reviewed by Alexey Proskuryakov.
3698
3699         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
3700         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
3701         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
3702
3703         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
3704         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
3705         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
3706         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
3707         in the credit card expiry field.
3708
3709         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
3710
3711         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3712         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3713         (WTR::UIScriptController::setDefaultCalendarType):
3714         * WebKitTestRunner/TestController.h:
3715
3716         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
3717         identifier and calendar locale identifier.
3718
3719         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3720         (WTR::swizzledCalendar):
3721         (WTR::TestController::overriddenCalendarIdentifier const):
3722         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
3723
3724         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
3725
3726         (WTR::TestController::setDefaultCalendarType):
3727
3728         Plumb the new calendar's locale identifier through this method.
3729
3730         (WTR::TestController::cocoaResetStateToConsistentValues):
3731         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
3732         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
3733         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
3734         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
3735
3736 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
3737
3738         App-bound domains should have separate Network Sessions
3739         https://bugs.webkit.org/show_bug.cgi?id=208026
3740         <rdar://problem/59434006>
3741
3742         Reviewed by Brent Fulgham.
3743
3744         This patch is mostly test infrastructure involving 3 functions.
3745         One sets in-app browser privacy as enabled in the network process
3746         manually for the test. One ensures that setting the WebView category
3747         works properly, and the last one checks for an app-bound session for
3748         an app-bound navigation.
3749
3750         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3751         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3752         (WTR::InjectedBundle::didReceiveMessageToPage):
3753         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3754         (WTR::TestRunner::getWebViewCategory):
3755         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
3756         (WTR::TestRunner::hasAppBoundSession):
3757         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
3758         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
3759         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3760         * WebKitTestRunner/TestController.cpp:
3761         (WTR::TestController::ensureViewSupportsOptionsForTest):
3762         Clearing the bundleID should happen right before setting a new one, 
3763         otherwise it clears the ID after it is set and returns a null ID.
3764
3765         (WTR::TestController::resetStateToConsistentValues):
3766         (WTR::TestController::getWebViewCategory):
3767         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
3768         (WTR::inAppBrowserPrivacyBooleanResultCallback):
3769         (WTR::inAppBrowserPrivacyVoidResultCallback):
3770         (WTR::TestController::hasAppBoundSession):
3771         (WTR::TestController::setInAppBrowserPrivacyEnabled):
3772         * WebKitTestRunner/TestController.h:
3773         * WebKitTestRunner/TestInvocation.cpp:
3774         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3775         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3776         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
3777         (WTR::TestInvocation::didReceivePrevalentDomains):
3778         (WTR::TestInvocation::didReceiveWebViewCategory):
3779         * WebKitTestRunner/TestInvocation.h:
3780         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3781         (WTR::TestController::getWebViewCategory):
3782
3783 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
3784
3785         Build DumpRenderTree and WebKitTestRunner for macCatalyst
3786         https://bugs.webkit.org/show_bug.cgi?id=208068
3787         <rdar://problem/59676596>
3788
3789         Reviewed by Tim Horton.
3790
3791         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
3792         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3793         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
3794         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
3795         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
3796         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
3797         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
3798         * DumpRenderTree/mac/EventSendingController.h: Ditto.
3799         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
3800         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
3801         * Makefile: Add DumpRenderTree and WebKitTestRunner.
3802         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3803         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
3804         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
3805
3806 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3807
3808         [ews] Add build step to Validate ChangeLog for commit-queue
3809         https://bugs.webkit.org/show_bug.cgi?id=208064
3810
3811         Reviewed by Jonathan Bedard.
3812
3813         * BuildSlaveSupport/ews-build/steps.py:
3814         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
3815         (ValidateChangeLogAndReviewer.start):
3816         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
3817         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
3818
3819 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3820
3821         [ews] Add build step to set cq- flag on bugzilla patch
3822         https://bugs.webkit.org/show_bug.cgi?id=208021
3823
3824         Reviewed by Jonathan Bedard.
3825
3826         * BuildSlaveSupport/ews-build/steps.py:
3827         (BugzillaMixin.set_cq_minus_flag_on_patch):
3828         (SetCommitQueueMinusFlagOnPatch):
3829         (SetCommitQueueMinusFlagOnPatch.start):
3830         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
3831
3832 2020-02-20  Matt Lewis  <jlewis3@apple.com>
3833
3834         Stub repositories fail to upload some results due to missing head svn revision
3835         https://bugs.webkit.org/show_bug.cgi?id=207684
3836
3837         Reviewed by Jonathan Bedard.
3838
3839         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
3840         (MockHost.__init__):
3841         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3842         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
3843         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3844         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
3845         * Scripts/webkitpy/port/base.py:
3846         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
3847         from using mock SCMs and more
3848         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
3849
3850 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
3851
3852         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
3853         https://bugs.webkit.org/show_bug.cgi?id=208051
3854
3855         Reviewed by Carlos Alberto Lopez Perez.
3856
3857         Verbose flag prints out each test name executed. Without this flag
3858         stdout prints out one or two periods.
3859
3860         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3861         (RunJavaScriptCoreTests.start):
3862
3863 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
3864
3865         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
3866         https://bugs.webkit.org/show_bug.cgi?id=207984
3867
3868         Reviewed by Daniel Bates.
3869
3870         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3871         (TestWebKitAPI::TEST):
3872
3873 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
3874
3875         [GTK] Improve user agent quirk for Google Docs and Google Drive
3876         https://bugs.webkit.org/show_bug.cgi?id=206506
3877
3878         Reviewed by Carlos Garcia Campos.
3879
3880         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3881         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3882         (TestWebKitAPI::TEST):
3883
3884 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3885
3886         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
3887         https://bugs.webkit.org/show_bug.cgi?id=207380
3888
3889         Reviewed by Jonathan Bedard.
3890
3891         Added a new rule 'build/export_macro'.
3892
3893         Removed a obsolete rule 'readability/webkit_export' which was used
3894         only by Chromium port (r148185).
3895
3896         * Scripts/webkitpy/style/checkers/cpp.py:
3897         (_FunctionState.export_macro):
3898         (check_function_definition):
3899         (_unix_path): Added.
3900         (is_generated_file): Use _unix_path.
3901         (check_has_config_header): Ditto.
3902         (CppChecker):
3903         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3904         (WebKitStyleTest.test_export_macro_check):
3905         (WebKitStyleTest.test_webkit_export_check): Deleted.
3906
3907 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3908
3909         [Win][MiniBrowser] Add prettier toolbar button icons
3910         https://bugs.webkit.org/show_bug.cgi?id=207999
3911
3912         Reviewed by Ross Kirsling.
3913
3914         Use a custom toolbar button icons instead of system stock icons.
3915
3916         Fixed a bug toolbar button dropdown arrows always looked being
3917         hovered. TBSTYLE_FLAT should be given.
3918
3919         Removed the window border line of Progress Indicator.
3920
3921         * MiniBrowser/win/MainWindow.cpp:
3922         (MainWindow::createToolbar):
3923         * MiniBrowser/win/MiniBrowserLib.rc:
3924         * MiniBrowser/win/MiniBrowserLibResource.h:
3925         * MiniBrowser/win/toolbar.bmp: Added.
3926
3927 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
3928
3929         Update run-webkit-tests help description for skip-failing-tests
3930         https://bugs.webkit.org/show_bug.cgi?id=208031
3931
3932         Reviewed by Alexey Proskuryakov.
3933
3934         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3935
3936 2020-02-20  Chris Dumez  <cdumez@apple.com>
3937
3938         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
3939         https://bugs.webkit.org/show_bug.cgi?id=208015
3940         <rdar://problem/59591630>
3941
3942         Reviewed by Geoffrey Garen.
3943
3944         Add API test coverage.
3945
3946         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3947         (TEST):
3948
3949 2020-02-20  Tim Horton  <timothy_horton@apple.com>
3950
3951         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
3952         https://bugs.webkit.org/show_bug.cgi?id=207998
3953         <rdar://problem/40942425>
3954
3955         Reviewed by Sam Weinig.
3956
3957         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3958         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
3959         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3960         (TestWebKitAPI::TEST):
3961         Add some tests for top content insets.
3962
3963 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
3964
3965         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
3966         https://bugs.webkit.org/show_bug.cgi?id=207910
3967
3968         Unreviewed infrastructure fix.
3969
3970         * Scripts/run-javascriptcore-tests:
3971         (configurationForUpload): Use the major version instead of the sub-minor version
3972         for version name.
3973
3974 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
3975
3976         [CMake] Add WPE::libwpe target
3977         https://bugs.webkit.org/show_bug.cgi?id=207970
3978
3979         Reviewed by Adrian Perez de Castro.
3980
3981         Use the WPE::libwpe target.
3982
3983         * MiniBrowser/wpe/CMakeLists.txt:
3984         * TestWebKitAPI/PlatformWPE.cmake:
3985         * TestWebKitAPI/glib/PlatformWPE.cmake:
3986         * wpe/backends/CMakeLists.txt:
3987
3988 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
3989
3990         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
3991         https://bugs.webkit.org/show_bug.cgi?id=207749
3992
3993         Reviewed by Ross Kirsling.
3994
3995         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
3996
3997         * MiniBrowser/win/MainWindow.cpp:
3998         (MainWindow::createToolbar):
3999         (MainWindow::WndProc):
4000         (MainWindow::setDefaultURLToCurrentURL):
4001         (MainWindow::goHome): Added.
4002         (MainWindow::onURLBarEnter):
4003         * MiniBrowser/win/MainWindow.h:
4004         * MiniBrowser/win/MiniBrowserLib.rc:
4005         * MiniBrowser/win/MiniBrowserLibResource.h:
4006         * MiniBrowser/win/MiniBrowserReplace.h:
4007         * MiniBrowser/win/WinMain.cpp:
4008         (wWinMain):
4009
4010 2020-02-19  Peng Liu  <peng.liu6@apple.com>
4011
4012         Fix check-webkit-style errors related to AVFoundationSPI.h
4013         https://bugs.webkit.org/show_bug.cgi?id=207834
4014
4015         Reviewed by Daniel Bates.
4016
4017         Revert the change in r256770 regarding the headers ordering.
4018         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
4019
4020         * Scripts/webkitpy/style/checkers/cpp.py:
4021         (check_include_line):
4022
4023 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
4024
4025         results.webkit.org: Correctly report JSC tests for windows
4026         https://bugs.webkit.org/show_bug.cgi?id=207910
4027
4028         Rubber-stamped by Aakash Jain.
4029
4030         * Scripts/run-javascriptcore-tests:
4031         (configurationForUpload): Give Windows a version name.
4032         * Scripts/webkitdirs.pm:
4033         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
4034         Version dictionary.
4035
4036 2020-02-19  Chris Dumez  <cdumez@apple.com>
4037
4038         Unreviewed, fix assertions in storage access API layout tests after r256882.
4039
4040         Drop dead testRunner code to toggle storage access API feature.
4041
4042         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4043         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4044         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
4045         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4046         * WebKitTestRunner/TestInvocation.cpp:
4047         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4048
4049 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
4050
4051         [WPE] Support 2D axis, smooth-motion events
4052         https://bugs.webkit.org/show_bug.cgi?id=207881
4053
4054         Reviewed by Carlos Garcia Campos.
4055
4056         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
4057
4058 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
4059
4060         Unreviewed, rolling out r256851.
4061
4062         Broke internal bots
4063
4064         Reverted changeset:
4065
4066         "Stub repositories fail to upload some results due to missing
4067         head svn revision"
4068         https://bugs.webkit.org/show_bug.cgi?id=207684
4069         https://trac.webkit.org/changeset/256851
4070
4071 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
4072
4073         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
4074         https://bugs.webkit.org/show_bug.cgi?id=207883
4075
4076         Reviewed by Ross Kirsling.
4077
4078         Unlike other mouse buttons, 4th and 5th mouse buttons are
4079         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
4080         WM_XBUTTONUP events to the window under the mouse cursor.
4081         Unhandled WM_XBUTTONUP events are automatically converted to
4082         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
4083         parent window.
4084         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
4085
4086         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
4087         handled.
4088
4089         * MiniBrowser/win/BrowserWindow.h:
4090         * MiniBrowser/win/MainWindow.cpp:
4091         (MainWindow::WndProc):
4092         * MiniBrowser/win/WebKitBrowserWindow.cpp:
4093         (WebKitBrowserWindow::navigateForwardOrBackward):
4094         * MiniBrowser/win/WebKitBrowserWindow.h:
4095         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
4096         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
4097         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
4098
4099 2020-02-18  Alex Christensen  <achristensen@webkit.org>
4100
4101         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
4102         https://bugs.webkit.org/show_bug.cgi?id=207912
4103         <rdar://problem/59556922>
4104
4105         Reviewed by Brian Weinstein.
4106
4107         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
4108         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
4109         (TEST):
4110         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
4111         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
4112
4113 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
4114
4115         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
4116         https://bugs.webkit.org/show_bug.cgi?id=207899
4117         <rdar://problem/55658207>
4118
4119         Reviewed by Tim Horton and Simon Fraser.
4120
4121         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
4122
4123         * WebKitTestRunner/TestController.cpp:
4124         (WTR::updateTestOptionsFromTestHeader):
4125         * WebKitTestRunner/TestOptions.h:
4126         (WTR::TestOptions::hasSameInitializationOptions const):
4127         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4128         (WTR::TestController::platformCreateWebView):
4129
4130 2020-02-18  Matt Lewis  <jlewis3@apple.com>
4131
4132         Stub repositories fail to upload some results due to missing head svn revision
4133         https://bugs.webkit.org/show_bug.cgi?id=207684
4134
4135         Reviewed by Jonathan Bedard.
4136
4137         * Scripts/webkitpy/api_tests/run_api_tests.py:
4138         (main): Added initializing the scm to the host object.
4139         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
4140         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
4141         it in line with modern code.
4142         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4143         (main): Added inializing the scm to the host object.
4144         * Scripts/webkitpy/port/base.py:
4145         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
4146         from using mock SCMs and more
4147         * Scripts/webkitpy/test/main.py:
4148         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
4149         and converted the webkit_root variable to the SCM checkout root.
4150         (Tester._run_tests):
4151
4152 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
4153
4154         Move [UIDevice currentDevice] calls to UI process
4155         https://bugs.webkit.org/show_bug.cgi?id=204320
4156
4157         Reviewed by Darin Adler.
4158
4159         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4160         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
4161         (TEST):
4162
4163 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
4164
4165         Move from "layer flush" terminology to "rendering update"
4166         https://bugs.webkit.org/show_bug.cgi?id=207870
4167
4168         Reviewed by Tim Horton.
4169
4170         Rename various functions and member variables to move away from the legacy "layer flush"
4171         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
4172         that we have layers is an implementation detail.
4173         
4174         Change LayerFlushThrottlingState to be an OptionSet<>.
4175
4176         * Tracing/SystemTracePoints.plist:
4177
4178 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
4179
4180         [Webkit.css] Adding popover style element
4181         This help to prevent us reinventing the wheel ever again
4182         https://bugs.webkit.org/show_bug.cgi?id=207787
4183
4184         Reviewed by Dean Jackson.
4185
4186         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
4187         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
4188         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
4189         (.popover):
4190         (.popover>.content):
4191         (.popover.display):
4192         (.popover .arrow):
4193         (.popover .arrow.point-top):
4194         (.popover .arrow.point-bottom):
4195         (.popover .arrow.point-left):
4196         (.popover .arrow.point-right):
4197         (@media (prefers-color-scheme: dark) .popover>.content):
4198         (@media (prefers-color-scheme: dark) .popover.display):
4199         (@media (prefers-color-scheme: dark) .popover .arrow):
4200         (.popover>.content>.section): Deleted.
4201         (.popover:focus>.content, .popover:hover>.content): Deleted.
4202         (.popover.right>.content): Deleted.
4203         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
4204         (.popover.left>.content): Deleted.
4205         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
4206         (.popover.bottom>.content): Deleted.
4207         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
4208
4209 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
4210
4211         Update WebKit Tools to issue mach extensions as needed
4212         https://bugs.webkit.org/show_bug.cgi?id=207850
4213         <rdar://problem/59521019>
4214
4215         Reviewed by Per Arne Vollan.
4216
4217         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
4218         to its child processes (WebContent, GPU, Network, etc.) as needed.
4219
4220         * MiniBrowser/MiniBrowser.entitlements:
4221         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
4222         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
4223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4224         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
4225
4226 2020-02-17  Peng Liu  <peng.liu6@apple.com>
4227
4228         Fix check-webkit-style errors related to AVFoundationSPI.h
4229         https://bugs.webkit.org/show_bug.cgi?id=207834
4230
4231         Reviewed by Eric Carlson.
4232
4233         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
4234         Soft-link headers can be included as either "file.h" or <file.h>.
4235
4236         * Scripts/webkitpy/style/checkers/cpp.py:
4237         (_classify_include):
4238         (check_include_line):
4239
4240 2020-02-17  Keith Rollin  <krollin@apple.com>
4241
4242         Unreviewed build fix after r256715.
4243
4244         Fix tvOS and watchOS builds.
4245
4246         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
4247
4248 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
4249
4250         Use CF prefs direct mode in the WebContent process
4251         https://bugs.webkit.org/show_bug.cgi?id=203420
4252
4253         Reviewed by Brent Fulgham.
4254
4255         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4256         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
4257         (TEST):
4258
4259 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
4260
4261         EWS should be able to file Bugzilla bugs
4262         https://bugs.webkit.org/show_bug.cgi?id=207845
4263
4264         Reviewed by Alexey Proskuryakov.
4265
4266         * BuildSlaveSupport/ews-build/steps.py:
4267         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
4268
4269 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
4270
4271         EWS should be able to comment on Bugzilla
4272         https://bugs.webkit.org/show_bug.cgi?id=201927
4273
4274         Reviewed by Jonathan Bedard.
4275
4276         * BuildSlaveSupport/ews-build/steps.py:
4277         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
4278         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
4279         (BugzillaMixin.close_bug): Ditto.
4280         (CommentOnBug): Build step to comment on bugzilla bug.
4281
4282 2020-02-17  Antti Koivisto  <antti@apple.com>
4283
4284         [macOS] Add trace points for layer flush runloop observer
4285         https://bugs.webkit.org/show_bug.cgi?id=207837
4286
4287         Reviewed by Sam Weinig.
4288
4289         * Tracing/SystemTracePoints.plist:
4290
4291 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
4292
4293         [CMake] Use builtin targets
4294         https://bugs.webkit.org/show_bug.cgi?id=205166
4295
4296         Reviewed by Darin Adler.
4297
4298         * TestWebKitAPI/PlatformWin.cmake:
4299
4300 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
4301
4302         [ews] add SetBuildSummary step for Windows EWS
4303         https://bugs.webkit.org/show_bug.cgi?id=207556
4304
4305         Reviewed by Jonathan Bedard.
4306
4307         * BuildSlaveSupport/ews-build/factories.py:
4308         (WindowsFactory.__init__):
4309         (GTKBuildAndTestFactory.__init__):
4310         * BuildSlaveSupport/ews-build/factories_unittest.py:
4311         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
4312
4313 2020-02-17  Alberto Garcia  <berto@igalia.com>
4314
4315         [WPE] Change the QML plugin install path
4316         https://bugs.webkit.org/show_bug.cgi?id=207761
4317
4318         Reviewed by Philippe Normand.
4319
4320         * Scripts/run-qt-wpe-minibrowser:
4321         * glib/api_test_runner.py:
4322         (TestRunner._run_test_qt):
4323
4324 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
4325
4326         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
4327         https://bugs.webkit.org/show_bug.cgi?id=207746
4328
4329         Reviewed by Don Olmstead.
4330
4331         * MiniBrowser/win/stdafx.h:
4332
4333 2020-02-16  Brady Eidson  <beidson@apple.com>
4334
4335         Expose "allowsContentJavaScript" on WKWebpagePreferences
4336 &n