Tools/ChangeLog

   1 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
   2
   3         Support Trac 1.0.x XML timeline link format
   4         https://bugs.webkit.org/show_bug.cgi?id=149786
   5
   6         Reviewed by Lucas Forschler.
   7
   8         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
   9         (Trac.prototype._convertCommitInfoElementToObject):
  10
  11 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
  12
  13         Fix some errors on bot watcher's dashboard
  14         https://bugs.webkit.org/show_bug.cgi?id=149789
  15
  16         Reviewed by Lucas Forschler.
  17
  18         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
  19         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): We may not get to layout
  20         tests step, in which case layoutTestResults.tooManyFailures would raise an exception.
  21
  22 2015-10-04  Alexey Proskuryakov  <ap@apple.com>
  23
  24         Bot watcher's dashboard builders should turn yellow when svn fails
  25         https://bugs.webkit.org/show_bug.cgi?id=149791
  26
  27         Reviewed by Lucas Forschler.
  28
  29         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
  30         (BuildbotBuilderQueueView.prototype.appendBuilderQueueStatus):
  31         (BuildbotBuilderQueueView.prototype.update):
  32
  33 2015-10-02  Daniel Bates  <dabates@apple.com>
  34
  35         Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
  36         https://bugs.webkit.org/show_bug.cgi?id=149769
  37
  38         Reviewed by Alexey Proskuryakov.
  39
  40         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
  41         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
  42         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  43         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
  44         (WebKitBuildbot):
  45         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
  46         (table.queue-grid tr.platform.ios-simulator-9 img.logo):
  47
  48 2015-10-02  Ryosuke Niwa  <rniwa@webkit.org>
  49
  50         REGRESSION(r190370): Speedometer spits out an extra console message
  51         https://bugs.webkit.org/show_bug.cgi?id=149720
  52
  53         Unreviewed. Temporarily ignore the console error message.
  54
  55         * Scripts/webkitpy/performance_tests/perftest.py:
  56         (PerfTest._filter_output):
  57
  58 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
  59
  60         Provide "--no-ninja" option to avoid using Ninja
  61         https://bugs.webkit.org/show_bug.cgi?id=149757
  62
  63         Reviewed by Alex Christensen.
  64
  65         Add a new command line argument understood by webkitdirs.pm so
  66         that we can conditionally avoid using Ninja. This is an
  67         'opt-out' argument, so no existing Ninja users should be affected.
  68
  69         * Scripts/webkitdirs.pm:
  70         (canUseNinja): Check for option and block ninja if present.
  71
  72 2015-10-02  Aakash Jain  <aakash_jain@apple.com>
  73
  74         Flakiness dashboard should support OS X El Capitan
  75         https://bugs.webkit.org/show_bug.cgi?id=149648
  76
  77         Reviewed by Alexey Proskuryakov.
  78
  79         * TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
  80
  81 2015-10-02  Daniel Bates  <dabates@apple.com>
  82
  83         Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
  84         (https://bugs.webkit.org/show_bug.cgi?id=149753)
  85
  86         For now, pass --ios-simulator.
  87
  88         * Scripts/webkitpy/port/ios.py:
  89         (IOSSimulatorPort._build_relay):
  90
  91 2015-10-02  Simon Fraser  <simon.fraser@apple.com>
  92
  93         Remove a "nullable" that breaks the iOS 8 build.
  94
  95         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
  96         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):
  97
  98 2015-10-02  Daniel Bates  <dabates@apple.com>
  99
 100         LayoutTestRelay is not built and archived when building for iOS Simulator
 101         https://bugs.webkit.org/show_bug.cgi?id=149753
 102
 103         Reviewed by Alexey Proskuryakov and Andy Estes.
 104
 105         Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
 106         and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
 107         product archive when building for iOS Simulator, respectively.
 108
 109         * BuildSlaveSupport/built-product-archive:
 110         (main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
 111         differentiate between iOS device and iOS Simulator platforms.
 112         (webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
 113         from determineWebKitBuildDirectories() into this function so that it can be used by both
 114         determineWebKitBuildDirectories() and archiveBuiltProduct().
 115         (determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
 116         webkitBuildDirectoryForConfigurationAndPlatform().
 117         (createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
 118         we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
 119         argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
 120         when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
 121         and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
 122         for the limitation that ditto(1) can only accept a single directory to archive on its command line.
 123         (archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
 124         For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
 125         build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
 126         LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.
 127         * Scripts/build-layouttestrelay:
 128             - Remove unnecessary include of Perl module POSIX.
 129             - Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
 130         * Scripts/build-webkit:
 131             - Invoke script build-layouttestrelay when building for iOS Simulator.
 132
 133 2015-10-02  Brent Fulgham  <bfulgham@apple.com>
 134
 135         [Win] Unreviewed test fix.
 136
 137         You cannot run 'run-webkit-tests' from the command line because it does not know
 138         to append the binary subdirectory (bin32/bin64). We don't see this on our builders
 139         because they explicitly set use the 'root' argument to provide the full path to
 140         the test binaries.
 141
 142         * Scripts/webkitpy/port/win.py:
 143         (WinPort._build_path): Added.
 144
 145 2015-10-02  Alex Christensen  <achristensen@webkit.org>
 146
 147         Reloading without content blockers doesn't apply to resource loads after the main frame finishes
 148         https://bugs.webkit.org/show_bug.cgi?id=149430
 149         rdar://problem/22742222
 150
 151         Reviewed by Geoffrey Garen.
 152
 153         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
 154         (WTR::TestController::cocoaResetStateToConsistentValues):
 155         * WebKitTestRunner/mac/TestControllerMac.mm:
 156         (WTR::TestController::platformConfigureViewForTest):
 157         Test what happens when you disable content blockers from the SPI.
 158
 159 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
 160
 161         [Win] Unreviewed build fix for run-api-tests
 162
 163         * Scripts/run-api-tests:
 164         (testToolPaths): Windows run needs to specify the binary path.
 165
 166 2015-10-01  Daniel Bates  <dabates@apple.com>
 167
 168         Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
 169         (https://bugs.webkit.org/show_bug.cgi?id=149695)
 170
 171         Following r190424 we can now rely on webkit-build-directory to return the path to
 172         the correct configuration-specific build directory on Windows.
 173
 174         * BuildSlaveSupport/built-product-archive:
 175         (archiveBuiltProduct):
 176
 177 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
 178
 179         [Win] Unreviewed build fix.
 180
 181         * Scripts/webkitdirs.pm:
 182         (setupAppleWinEnv): Use 64-bit build tools if available
 183
 184 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
 185
 186         [Win] Fix TestWebKitAPI build under CMake.
 187
 188         Reviewed by Alex Christensen.
 189
 190         * TestWebKitAPI/PlatformWin.cmake: Add missing link command
 191         for Psapi.lib.
 192
 193 2015-10-01  Brent Fulgham  <bfulgham@apple.com>
 194
 195         [Win] Fix behavior of webkit-build-directory script
 196         https://bugs.webkit.org/show_bug.cgi?id=149718
 197
 198         Reviewed by Alex Christensen.
 199
 200         * Scripts/webkitdirs.pm:
 201         (determineConfigurationProductDir): Do not include the binary
 202         sub-directory in the configuration product directory output.
 203         (jscProductDir): Append correct binary path for Windows build.
 204         (setPathForRunningWebKitApp): Include properly binary subdirectories.
 205         (runSafari): Update for revised productDir behavior.
 206         (runMiniBrowser): Ditto.
 207
 208 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
 209
 210         Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
 211         use iOS SDK, like with all the others.
 212
 213         * Scripts/build-webkit:
 214
 215 2015-10-01  Daniel Bates  <dabates@apple.com>
 216
 217         Attempt to fix the iOS 9 Simulator testers
 218
 219         Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
 220         build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
 221         LayoutTestRelay when building for iOS Simulator.
 222
 223         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 224         * Scripts/build-webkit:
 225
 226 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
 227
 228         [GTK] Websites with invalid auth header keep loading forever
 229         https://bugs.webkit.org/show_bug.cgi?id=149710
 230
 231         Reviewed by Martin Robinson.
 232
 233         Add test case to check that we can authenticate sites with an
 234         empty realm.
 235
 236         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
 237         (testWebViewAuthenticationEmptyRealm):
 238         (serverCallback):
 239         (beforeAll):
 240
 241 2015-10-01  Alexey Proskuryakov  <ap@apple.com>
 242
 243         [Mac] Make run-api-tests work with System Integrity Protection
 244         https://bugs.webkit.org/show_bug.cgi?id=149711
 245         rdar://problem/22928202
 246
 247         Reviewed by Dan Bernstein.
 248
 249         * Scripts/run-api-tests:
 250         (runTest):
 251         (archCommandLineArgumentsForRestrictedEnvironmentVariables):
 252
 253 2015-10-01  Daniel Bates  <dabates@apple.com>
 254
 255         Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
 256         (https://bugs.webkit.org/show_bug.cgi?id=149695)
 257
 258         For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
 259         For now, use the path to the top-level WebKit build directory instead of using the configuration-
 260         specific build directory.
 261
 262         * BuildSlaveSupport/built-product-archive:
 263         (archiveBuiltProduct):
 264
 265 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
 266
 267         [EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
 268         https://bugs.webkit.org/show_bug.cgi?id=145837
 269
 270         Reviewed by Philippe Normand.
 271
 272         * efl/jhbuild.modules:
 273         * efl/patches/openwebrtc-clang-warning-fix.patch: Added.
 274         * efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
 275
 276 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
 277
 278         Unreviewed. Fix the iOS build after r190407.
 279
 280         * WebKitTestRunner/ios/IOKitSPI.h:
 281
 282 2015-10-01  Wenson Hsieh  <wenson_hsieh@apple.com>
 283
 284         Implement keyboard event sending for iOS in WebKitTestRunner
 285         https://bugs.webkit.org/show_bug.cgi?id=149676
 286
 287         Reviewed by Simon Fraser.
 288
 289         Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
 290         way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
 291         allows us to run code when the keyboard is shown or hidden.
 292
 293         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
 294         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
 295         (WTR::UIScriptController::setDidShowKeyboardCallback):
 296         (WTR::UIScriptController::didShowKeyboardCallback):
 297         (WTR::UIScriptController::setDidHideKeyboardCallback):
 298         (WTR::UIScriptController::didHideKeyboardCallback):
 299         (WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
 300         (WTR::UIScriptController::platformSetDidShowKeyboardCallback):
 301         (WTR::UIScriptController::platformSetDidHideKeyboardCallback):
 302         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
 303         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
 304         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
 305         (-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to
 306                 the notifications that the keyboard has been raised or lowered.
 307         (-[TestRunnerWKWebView _keyboardDidShow:]):
 308         (-[TestRunnerWKWebView _keyboardDidHide:]):
 309         * WebKitTestRunner/ios/HIDEventGenerator.h:
 310         * WebKitTestRunner/ios/HIDEventGenerator.m:
 311         (-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
 312         (shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
 313         (hidUsageCodeForCharacter): Ditto.
 314         (-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering
 315                 a keyDown event in WebKit.
 316         * WebKitTestRunner/ios/IOKitSPI.h:
 317         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 318
 319 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
 320
 321         Unreviewed, rolling out r190399.
 322
 323         Tests are still failing even after r190362
 324
 325         Reverted changeset:
 326
 327         "Unreviewed. Unskip GTK+ user media unit tests after r190362."
 328         http://trac.webkit.org/changeset/190399
 329
 330 2015-10-01  Csaba Osztrogonác  <ossy@webkit.org>
 331
 332         [jhbuild] switch to new upstream usrsctp library
 333         https://bugs.webkit.org/show_bug.cgi?id=149494
 334
 335         Reviewed by Philippe Normand.
 336
 337         * efl/jhbuild.modules:
 338         * gtk/jhbuild.modules:
 339
 340 2015-10-01  Carlos Garcia Campos  <cgarcia@igalia.com>
 341
 342         Unreviewed. Unskip GTK+ user media unit tests after r190362.
 343
 344         They should pass now.
 345
 346         * Scripts/run-gtk-tests:
 347         (TestRunner):
 348
 349 2015-09-30  Daniel Bates  <dabates@apple.com>
 350
 351         Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
 352         (https://bugs.webkit.org/show_bug.cgi?id=149695)
 353
 354         * BuildSlaveSupport/built-product-archive:
 355         (determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
 356         (extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.
 357
 358 2015-09-30  Daniel Bates  <dabates@apple.com>
 359
 360         Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
 361         (https://bugs.webkit.org/show_bug.cgi?id=149695)
 362
 363         Actually, we need to pass --configuration to script webkit-build-directory to have
 364         it return the path to the configuration-specific build directory.
 365
 366         * BuildSlaveSupport/built-product-archive:
 367         (determineWebKitBuildDirectories):
 368
 369 2015-09-30  Daniel Bates  <dabates@apple.com>
 370
 371         built-product-archive archives incorrect build directory for iOS port
 372         https://bugs.webkit.org/show_bug.cgi?id=149695
 373
 374         Reviewed by Darin Adler.
 375
 376         Fixes an issue where the script built-product-archive archives a non-existent
 377         build directory for the iOS port. Without loss of generality, the script assumes
 378         the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
 379         But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.
 380
 381         Currently the script built-product-archive calls `webkit-build-directory --top-level ...`
 382         to determine the top-level build directory and computes the configuration-specific
 383         build directory to be the concatenation of the the top-level build directory and
 384         the configuration (e.g. Release). This is incorrect. Instead we should call
 385         webkit-build-directory omitting the flag --top-level to compute the path to the
 386         configuration-specific build directory.
 387
 388         * BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.
 389         (main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
 390         its purpose and added global variable _configurationBuildDirectory to store the path
 391         to the configuration-specific build directory. Ensure that we have a non-empty string
 392         for both the top-level and configuration-specific build directories.
 393         (determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
 394         Compute the configuration-specific build directory and store it in the global variable
 395         _configurationBuildDirectory.
 396         (archiveBuiltProduct): Modified to use _configurationBuildDirectory.
 397         (extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
 398         as needed.
 399         (determineWebKitBuildDirectory): Deleted.
 400
 401 2015-09-30  Hunseop Jeong  <hs85.jeong@samsung.com>
 402
 403         [EFL] css3/device-adapt/* tests failed after r190335.
 404         https://bugs.webkit.org/show_bug.cgi?id=149655
 405
 406         Reviewed by Simon Fraser.
 407
 408         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
 409         overwritten by updatePlatformSpecificViewOptionsForTest after r190335.
 410
 411         * WebKitTestRunner/efl/TestControllerEfl.cpp:
 412         (WTR::shouldUseFixedLayout):
 413
 414 2015-09-30  Dewei Zhu  <dewei_zhu@apple.com>
 415
 416         Extend JetStream timeout for slow devices.
 417
 418         Reviewed by Chris Dumez.
 419
 420         Extend JetStream timeout to 20 minutes.
 421
 422         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
 423
 424 2015-09-30  Daniel Bates  <dabates@apple.com>
 425
 426         Rename iOS builders/testers to include version
 427         https://bugs.webkit.org/show_bug.cgi?id=149685
 428
 429         Reviewed by Simon Fraser.
 430
 431         Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
 432         make it clear to a reader the version of iOS these builders/testers are using.
 433
 434         * BuildSlaveSupport/build.webkit.org-config/config.json:
 435         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 436
 437 2015-09-30  Daniel Bates  <dabates@apple.com>
 438
 439         Add iOS criterion for triggering a build
 440         https://bugs.webkit.org/show_bug.cgi?id=149679
 441
 442         Rubber-stamped by Alexey Proskuryakov.
 443
 444         First pass at defining criterion for triggering an iOS build.
 445
 446         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
 447         (_should_file_trigger_build):
 448         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
 449         (ShouldBuildTest):
 450         (ShouldBuildTest.test_should_build):
 451
 452 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
 453
 454         [iOS] Allow tests to generate user gestures for UI testing
 455         https://bugs.webkit.org/show_bug.cgi?id=149653
 456
 457         Reviewed by Tim Horton.
 458
 459         Expose functionality in UIScriptController to allow for testing single- and double-tap,
 460         and to listen for completion of scrolling and zooming in the WKWebView.
 461
 462         Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
 463         which hides the complexity of creating these events. Event dispatch is asynchronous.
 464         We detect when the last event has been handled by dispatching a vendor-specific event,
 465         which is detected via -_handleHIDEvent: in our UIApplication subclass.
 466
 467         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
 468         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties
 469         for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
 470         single and double taps.
 471         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:
 472         (UIScriptContext::registerCallback): Used to store the callbacks for zooming.
 473         Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
 474         (UIScriptContext::unregisterCallback):
 475         (UIScriptContext::callbackWithID):
 476         (UIScriptContext::fireCallback):
 477         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
 478         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
 479         (WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
 480         (WTR::UIScriptController::willBeginZoomingCallback): Ditto.
 481         (WTR::UIScriptController::setDidEndZoomingCallback):
 482         (WTR::UIScriptController::didEndZoomingCallback):
 483         (WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
 484         (WTR::UIScriptController::doubleTapAtPoint): Ditto.
 485         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
 486         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
 487         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
 488         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 489         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
 490         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
 491         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
 492         (-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
 493         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
 494         (-[TestRunnerWKWebView onDidEndZooming:]): Deleted.
 495         * WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
 496         * WebKitTestRunner/ios/HIDEventGenerator.m: Added.
 497         (simpleDragCurve):
 498         (calculateNextLocation):
 499         (delayBetweenMove):
 500         (+[HIDEventGenerator sharedHIDEventGenerator]):
 501         (+[HIDEventGenerator nextEventCallbackID]):
 502         (-[HIDEventGenerator init]):
 503         (-[HIDEventGenerator _createIOHIDEventType:]):
 504         (-[HIDEventGenerator _sendHIDEvent:]):
 505         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
 506         (-[HIDEventGenerator _updateTouchPoints:count:]):
 507         (-[HIDEventGenerator touchDownAtPoints:touchCount:]):
 508         (-[HIDEventGenerator touchDown:touchCount:]):
 509         (-[HIDEventGenerator touchDown:]):
 510         (-[HIDEventGenerator liftUpAtPoints:touchCount:]):
 511         (-[HIDEventGenerator liftUp:touchCount:]):
 512         (-[HIDEventGenerator liftUp:]):
 513         (-[HIDEventGenerator moveToPoints:touchCount:duration:]):
 514         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
 515         (-[HIDEventGenerator tap:completionBlock:]):
 516         (-[HIDEventGenerator doubleTap:completionBlock:]):
 517         (-[HIDEventGenerator twoFingerTap:completionBlock:]):
 518         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
 519         (-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
 520         (-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
 521         (-[HIDEventGenerator markerEventReceived:]):
 522         * WebKitTestRunner/ios/IOKitSPI.h: Added.
 523         * WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
 524         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
 525         (WTR::globalToContentCoordinates):
 526         (WTR::UIScriptController::singleTapAtPoint):
 527         (WTR::UIScriptController::doubleTapAtPoint):
 528         (WTR::UIScriptController::platformSetWillBeginZoomingCallback):
 529         (WTR::UIScriptController::platformSetDidEndZoomingCallback):
 530         * WebKitTestRunner/ios/mainIOS.mm:
 531         (-[WebKitTestRunnerApp _handleHIDEvent:]):
 532
 533 2015-09-30  Dana Burkart  <dburkart@apple.com>
 534
 535         git-add-reviewer should trim trailing spaces/newlines
 536         https://bugs.webkit.org/show_bug.cgi?id=149513
 537
 538         Reviewed by Darin Adler.
 539
 540         * Scripts/git-add-reviewer:
 541         (nonInteractive):
 542
 543 2015-09-30  Eric Carlson  <eric.carlson@apple.com>
 544
 545         REGRESSION(r190262): User media unit test failures after r190262
 546         https://bugs.webkit.org/show_bug.cgi?id=149580
 547
 548         Reviewed by Darin Adler.
 549
 550         * WebKitTestRunner/TestController.cpp:
 551         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter
 552           order to WKUserMediaPermissionRequestAllow.
 553
 554 2015-09-30  Daniel Bates  <dabates@apple.com>
 555
 556         Add iOS builders and testers
 557         https://bugs.webkit.org/show_bug.cgi?id=149549
 558
 559         Reviewed by Alexey Proskuryakov.
 560
 561         Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
 562         builder that builds universal release binaries for armv7, armv7s and arm64 architectures.
 563
 564         * BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
 565         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
 566
 567 2015-09-30  Timothy Hatcher  <timothy@apple.com>
 568
 569         Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
 570         https://bugs.webkit.org/show_bug.cgi?id=149674
 571
 572         Reviewed by Lucas Forschler.
 573
 574         * WebKitLauncher/WebKitLauncher.entitlements: Added.
 575         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
 576
 577 2015-09-30  Jason Marcell  <jmarcell@apple.com>
 578
 579         BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
 580         have an associated trac instance.
 581         https://bugs.webkit.org/show_bug.cgi?id=149673
 582
 583         Reviewed by Alexey Proskuryakov.
 584
 585         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
 586         (BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
 587         have an associated trac instance.
 588
 589 2015-09-30  Daniel Bates  <dabates@apple.com>
 590
 591         Prioritize testing latest build request on iOS test bots
 592         https://bugs.webkit.org/show_bug.cgi?id=149669
 593
 594         Reviewed by Darin Adler.
 595
 596         We should prioritize testing of the latest build request on the iOS test bots
 597         as we do for Mac and Windows test bots.
 598
 599         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 600         (loadBuilderConfig):
 601
 602 2015-09-30  Daniel Bates  <dabates@apple.com>
 603
 604         Add buildbot category for iOS builders and testers
 605         https://bugs.webkit.org/show_bug.cgi?id=149667
 606
 607         Reviewed by Darin Adler.
 608
 609         Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
 610         for iOS to the build.webkit.org home page.
 611
 612         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 613         (loadBuilderConfig):
 614         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
 615
 616 2015-09-30  Daniel Bates  <dabates@apple.com>
 617
 618         Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
 619         (https://bugs.webkit.org/show_bug.cgi?id=149539)
 620
 621         I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
 622         in <http://trac.webkit.org/changeset/190351>.
 623
 624         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 625         (CompileWebKit.start):
 626
 627 2015-09-30  Daniel Bates  <dabates@apple.com>
 628
 629         Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
 630         (https://bugs.webkit.org/show_bug.cgi?id=149539)
 631
 632         {32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
 633         respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.
 634
 635         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
 636         (CompileWebKit.start):
 637
 638 2015-09-30  Lucas Forschler  <lforschler@apple.com>
 639
 640         bot210 was configured for a queue instead of bot126.
 641
 642         Unreviewed config.json fix.
 643
 644         * BuildSlaveSupport/build.webkit.org-config/config.json:
 645
 646 2015-09-30  Lucas Forschler  <lforschler@apple.com>
 647
 648         Bring El Capitan buildbot infrastructure online.
 649         https://bugs.webkit.org/show_bug.cgi?id=149605
 650
 651         Reviewed by Darin Adler.
 652
 653         * BuildSlaveSupport/build.webkit.org-config/config.json:
 654
 655 2015-09-30  Tomas Popela  <tpopela@redhat.com>
 656
 657         [GTK] Deprecation warnings in DOMNodeTest
 658         https://bugs.webkit.org/show_bug.cgi?id=149663
 659
 660         After the webkit_dom_document_get_elements_by_tag_name deprecation we
 661         need to update the tests to use webkit_dom_document_query_selector_all
 662         to avoid compilation warnings.
 663
 664         Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
 665         (the suggested replacement for the deprecated function).
 666
 667         Reviewed by Carlos Garcia Campos.
 668
 669         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
 670         (WebKitDOMNodeTest::testTagNamesNodeList):
 671         (WebKitDOMNodeTest::testTagNamesHTMLCollection):
 672         (registerTests):
 673         (WebKitDOMNodeTest::testTagNames): Deleted.
 674         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
 675         (prepareDOMForTagNamesTests):
 676         (testWebKitDOMNodeTagNamesNodeList):
 677         (testWebKitDOMNodeTagNamesHTMLCollection):
 678         (beforeAll):
 679         (testWebKitDOMNodeTagNames): Deleted.
 680
 681 2015-09-29  Simon Fraser  <simon.fraser@apple.com>
 682
 683         WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
 684         https://bugs.webkit.org/show_bug.cgi?id=149650
 685
 686         Reviewed by Tim Horton.
 687
 688         TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
 689         looks at the file path, and not the custom options that come from file comments.
 690
 691         Fix by computing TestOptions before making the TestInvocation, and setting them
 692         as const TestInvocation data. This meant changing various call sites to take
 693         the std::string pathOrURL, rather than the TestInvocation itself.
 694
 695         Also initialize TestInvocation with a WKURLRef, rather than a std::string.
 696
 697         * WebKitTestRunner/CMakeLists.txt:
 698         * WebKitTestRunner/TestController.cpp:
 699         (WTR::TestController::ensureViewSupportsOptionsForTest):
 700         (WTR::testPath):
 701         (WTR::createTestURL):
 702         (WTR::updateTestOptionsFromTestHeader):
 703         (WTR::TestController::testOptionsForTest):
 704         (WTR::TestController::updateWebViewSizeForTest):
 705         (WTR::TestController::updateWindowScaleForTest):
 706         (WTR::TestController::runTest):
 707         * WebKitTestRunner/TestController.h:
 708         * WebKitTestRunner/TestInvocation.cpp:
 709         (WTR::TestInvocation::TestInvocation):
 710         (WTR::TestInvocation::invoke):
 711         (WTR::createWKURL): Deleted.
 712         (WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
 713         (WTR::TestInvocation::shouldUseFixedLayout): Deleted.
 714         * WebKitTestRunner/TestInvocation.h:
 715         (WTR::TestInvocation::options):
 716         * WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
 717         (WTR::pathContains):
 718         (WTR::shouldMakeViewportFlexible):
 719         (WTR::shouldUseFixedLayout):
 720         (WTR::isSVGTestPath):
 721         (WTR::isHiDPITestPath):
 722         (WTR::TestOptions::TestOptions):
 723         * WebKitTestRunner/TestOptions.h:
 724         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 725         * WebKitTestRunner/efl/TestControllerEfl.cpp:
 726         (WTR::pathContains):
 727         (WTR::shouldUseFixedLayout):
 728         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 729         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
 730         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 731         * WebKitTestRunner/ios/TestControllerIOS.mm:
 732         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 733         * WebKitTestRunner/mac/TestControllerMac.mm:
 734         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
 735
 736 2015-09-29  Aakash Jain  <aakash_jain@apple.com>
 737
 738         Flakiness dashboard should support OS X El Capitan
 739         https://bugs.webkit.org/show_bug.cgi?id=149648
 740
 741         Reviewed by Alexey Proskuryakov.
 742
 743         * QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of
 744         difference between new appscale and old Google App Engine implementation.
 745         * TestResultServer/app.yaml: Same.
 746         * TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
 747
 748 2015-09-29  Daniel Bates  <dabates@apple.com>
 749
 750         configure-xcode-for-ios-development does not work with Xcode 7
 751         https://bugs.webkit.org/show_bug.cgi?id=149640
 752
 753         Reviewed by Alexey Proskuryakov.
 754
 755         When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
 756         because it cannot find the Xcode specification files for iOS simulator and device. These
 757         files have moved to a new location in Xcode 7 distribution. Moreover we must add the
 758         relevant definitions to the Xcode 7 specification files directly as opposed to creating
 759         new specification files with the added definitions (as we did in older versions of Xcode)
 760         in order for Xcode 7 to honor these definitions.
 761
 762         * Scripts/configure-xcode-for-ios-development: Sorted forward declarations.
 763         (updateXcodeSpecificationFilesForSDKIfNeeded): Added.
 764         (updateXcode7SpecificationFile): Added.
 765         (createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
 766         (writeXcodeSpecification): Moved congratulations line to caller so as to write out the
 767         appropriate success message.
 768         (mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
 769         (createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
 770         (createXcodeSpecificationFromSpecificationAndId): Deleted.
 771
 772 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
 773
 774         [Win] Allow 'prepare-ChangeLog' to be used without Cygwin
 775         https://bugs.webkit.org/show_bug.cgi?id=149639
 776
 777         Reviewed by Alex Christensen.
 778
 779         * Scripts/VCSUtils.pm:
 780         (exitStatus): Use 'isWindows()' method.
 781         (isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
 782         an error. This method could probably just go away.
 783         (normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
 784         always changing to Unix style.
 785         (unixPath): Added. Needed so Windows can always show a Unix path in the
 786         ChangeLog file.
 787         (changeLogName): Work around the fact that 'getpwuid' is not available on
 788         a pure Windows build of Perl.
 789         * Scripts/prepare-ChangeLog:
 790         (generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
 791         path on Windows.
 792         (svnUpdateCommand): Added helper function. Needed because Windows Perl does not
 793         support using arrays for 'open' arguments.
 794         (resolveChangeLogsPath): Ditto.
 795         (resolveConflictedChangeLogs): Use new helper functions.
 796         (generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
 797         (diffCommand): Use double-quotes for paths, since Windows doesn't understand single
 798         quotes. Unix systems are happy either way.
 799         (statusCommand): Ditto.
 800         * Scripts/webkitdirs.pm:
 801         (launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.
 802
 803 2015-09-29  Brent Fulgham  <bfulgham@apple.com>
 804
 805         [Win] Unreviewed 64-bit build fix after switch to CMake.
 806
 807         * Scripts/webkitdirs.pm:
 808         (determineIsWin64FromArchitecture): Added.
 809
 810 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
 811
 812         printing does not use minimum page zoom factor
 813         https://bugs.webkit.org/show_bug.cgi?id=108507
 814
 815         Reviewed by Darin Adler.
 816
 817         WebKitTestRunner always takes the snapshots from the UI process
 818         (expect for IOS), so in the case of printing, the layout in the
 819         web view is not the expected one. When printing, we need to take
 820         the snapshot in the web process and ensure it's rendered with a
 821         PrintContext.
 822
 823         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 824         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
 825         kWKSnapshotOptionsPrinting option to
 826         WKBundlePageCreateSnapshotWithOptions() when printing.
 827
 828 2015-09-28  Carlos Garcia Campos  <cgarcia@igalia.com>
 829
 830         [WTR] Pixel tests generate the snapshots twice in Web and UI processes
 831         https://bugs.webkit.org/show_bug.cgi?id=149595
 832
 833         Reviewed by Tim Horton.
 834
 835         All ports except IOS implement
 836         PlatformWebView::windowSnapshotImage() to generate the snapshot
 837         for the pixel tests in the UI process. But we are still generating
 838         a snapshot for pixel tests in the Web process too, that is passed
 839         to the UI process but ignored.
 840         Whether a pixel result is needed or not, is only known by the web
 841         process depending on whether the test called dumpAsText with
 842         dumpPixels == true or not. Since the pixels are now dump in the UI
 843         process, we need to pass that information to the UI process when
 844         the test is done. For that we set a PixelResultIsPending bool
 845         parameter to the Done message, and we only add the PixelResult
 846         when UI process doesn't need to generate the pixels dump.
 847
 848         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 849         (WTR::InjectedBundle::didReceiveMessageToPage): Set
 850         m_pixelResultIsPending to false on reset.
 851         (WTR::InjectedBundle::done): Add PixelResultIsPending parameter to the
 852         Done message, and set the PixelResult if m_pixelResultIsPending is false.
 853         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 854         (WTR::InjectedBundle::setPixelResult): Set m_pixelResultIsPending to false.
 855         (WTR::InjectedBundle::setNeedsPixelResult): Set m_pixelResultIsPending.
 856         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 857         (WTR::InjectedBundlePage::dump): Only create a snapshot for IOS
 858         port.
 859         * WebKitTestRunner/TestInvocation.cpp:
 860         (WTR::TestInvocation::dumpResults): Use either the pixel result
 861         from the web process or generate a pixel result from the web view
 862         if need it.
 863         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
 864         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
 865         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
 866         is created by the caller now, but the CG implementation needs to
 867         know if it's a Web or UI process snapshot.
 868         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
 869         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
 870         cairo surface for the given image.
 871         * WebKitTestRunner/cg/TestInvocationCG.cpp:
 872         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
 873         CGContext for the given image.
 874
 875 2015-09-28  Dean Johnson  <dean_johnson@apple.com>
 876
 877         Fix JS errors on dashboard metrics page
 878         https://bugs.webkit.org/show_bug.cgi?id=149608
 879
 880         Reviewed by Alexey Proskuryakov.
 881
 882         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Updated to use Settings.
 883         (initPlatformsByFamily):
 884         (updateHiddenPlatforms):
 885         (parsePlatformFamily): Deleted.
 886         (updateToggleButtons): Deleted.
 887         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
 888         (updateHiddenPlatforms): Added to remove errors.
 889         (initPlatformsByFamily): Added to remove errors.
 890         (unhiddenQueues): Updated to use Settings.
 891         (documentReady): Added logic to add toggle buttons to the settings menu.
 892         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
 893         (Settings.prototype.parsePlatformFamily): Moved duplicate logic from Main.js and
 894         MetricsMain.js to Settings.
 895         (Settings.prototype.updateToggleButtons): Moved duplicate logic from Main.js and
 896         MetricsMain.js to Settings.
 897         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
 898         (QueueView.prototype._updateHiddenState): Updated to use Settings.
 899
 900 2015-09-28  Aakash Jain  <aakash_jain@apple.com>
 901
 902         Appscale query fails because of missing index
 903         https://bugs.webkit.org/show_bug.cgi?id=149609
 904
 905         Reviewed by Darin Adler.
 906
 907         * QueueStatusServer/index.yaml: Added the required index.
 908
 909 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
 910
 911         [Win] Fix the 64-bit build after switch to cmake.
 912
 913         Reviewed by Alex Christensen.
 914
 915         * Scripts/webkitdirs.pm:
 916         (generateBuildSystemFromCMakeProject): Use correct arguments for cmake to
 917         run a 64-bit build.
 918
 919 2015-09-28  Brent Fulgham  <bfulgham@apple.com>
 920
 921         [Win] Allow Windows to run test-webkitpy without Cygwin
 922         https://bugs.webkit.org/show_bug.cgi?id=149602
 923
 924         Reviewed by Alex Christensen.
 925
 926         These changes mostly shift from hard-coded paths using UNIX-style
 927         separators to Python's "os.path.join" syntax that uses the correct
 928         path separator for each platform.
 929
 930         * Scripts/webkitpy/common/system/path.py:
 931         (cygpath): Don't pass paths through Cygpath on native Windows.
 932         * Scripts/webkitpy/port/win.py:
 933         (WinPort._path_to_apache): Use os.path.join.
 934         (WinPort._ntsd_location): Support 64-bit environment (ProgramW6432 doesn't exist
 935         in 64-bit environments).
 936         * Scripts/webkitpy/style/checker.py: Use os.path.join.
 937         * Scripts/webkitpy/style/checker_unittest.py:
 938         (GlobalVariablesTest.test_path_rules_specifier.assertNoCheck): Use os.path.join.
 939         (GlobalVariablesTest.test_path_rules_specifier): Ditto.
 940         (GlobalVariablesTest): Ditto.
 941         (GlobalVariablesTest.test_max_reports_per_category): Ditto.
 942         (CheckerDispatcherSkipTest.test_should_skip_with_warning): Ditto.
 943         (CheckerDispatcherDispatchTest.test_js_paths): Ditto.
 944         (CheckerDispatcherDispatchTest.test_json_paths): Ditto.
 945         (CheckerDispatcherDispatchTest.test_python_paths): Ditto.
 946         (CheckerDispatcherDispatchTest.test_text_paths): Ditto.
 947         (CheckerDispatcherDispatchTest.test_xml_paths): Ditto.
 948         (StyleProcessor_CodeCoverageTest._create_carriage_checker_class): Ditto.
 949         (StyleProcessor_CodeCoverageTest): Ditto.
 950         (StyleProcessor_CodeCoverageTest.test_should_process__skip_without_warning): Ditto.
 951         (StyleProcessor_CodeCoverageTest.test_should_process__skip_with_warning): Ditto.
 952         (StyleProcessor_CodeCoverageTest.test_should_process__true_result): Ditto.
 953         * Scripts/webkitpy/w3c/test_parser_unittest.py: Uses os.path.join rather than
 954         manual string concatenation of paths.
 955
 956 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
 957
 958         Add bugzilla addresses of committers to contributors.json
 959         https://bugs.webkit.org/show_bug.cgi?id=149520
 960
 961         Reviewed by Darin Adler.
 962
 963         * Scripts/webkitpy/common/config/contributors.json:
 964
 965 2015-09-28  Csaba Osztrogonác  <ossy@webkit.org>
 966
 967         validate-committer-lists -b shouldn't need edituser privileges
 968         https://bugs.webkit.org/show_bug.cgi?id=149519
 969
 970         Reviewed by Darin Adler.
 971
 972         * Scripts/validate-committer-lists:
 973         (CommitterListBugzillaChecker._has_invalid_bugzilla_email):
 974         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 975         (BugzillaQueries.is_invalid_bugzilla_email):
 976         (BugzillaQueries): Deleted.
 977         (BugzillaQueries.fetch_logins_matching_substring): Deleted.
 978
 979 2015-09-26  Carlos Garcia Campos  <cgarcia@igalia.com>
 980
 981         Unreviewed. Gardening: skip media stream tests failing after r190262.
 982
 983         * Scripts/run-gtk-tests:
 984         (TestRunner):
 985
 986 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
 987
 988         [Mac] USE_INTERNAL_SDK is used undefined in tools projects
 989         https://bugs.webkit.org/show_bug.cgi?id=149571
 990
 991         Reviewed by Dan Bernstein.
 992
 993         Use the same pattern as in Source directory configurations (so, also get rid of AspenFamily.xcconfig).
 994
 995         * DumpRenderTree/mac/Configurations/Base.xcconfig:
 996         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
 997         * LayoutTestRelay/Configurations/Base.xcconfig:
 998         * MiniBrowser/Configurations/Base.xcconfig:
 999         * MiniBrowser/Configurations/DebugRelease.xcconfig:
1000         * TestWebKitAPI/Configurations/Base.xcconfig:
1001         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
1002         * WebEditingTester/Configurations/Base.xcconfig:
1003         * WebEditingTester/Configurations/DebugRelease.xcconfig:
1004         * WebKitTestRunner/Configurations/Base.xcconfig:
1005         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1006         * WebKitTestRunner/iOS.xcconfig: Removed.
1007
1008 2015-09-25  Eric Carlson  <eric.carlson@apple.com>
1009
1010         Clean up user media request internal API
1011         https://bugs.webkit.org/show_bug.cgi?id=149527
1012
1013         Reviewed by Tim Horton.
1014
1015         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
1016         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): Update for API changes.
1017
1018         * WebKitTestRunner/TestController.cpp:
1019         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Ditto.
1020
1021 2015-09-25  Simon Fraser  <simon.fraser@apple.com>
1022
1023         [iOS WK2] Add viewport tests and fix runUIScript() timing issues
1024         https://bugs.webkit.org/show_bug.cgi?id=149577
1025
1026         Reviewed by Tim Horton.
1027
1028         When calling testRunner.runUIScript() from a page load event, the script could run
1029         in the UI process before the current remote layer tree transaction had been handled
1030         there. This meant that runUIScript() could query state which was about to change.
1031
1032         Fix by delaying the execution of the UI script until a layer tree transaction has
1033         been handled by the UI process, leveraging the existing DrawingAreaProxy::dispatchAfterEnsuringDrawing().
1034
1035         * WebKitTestRunner/TestInvocation.cpp:
1036         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1037         (WTR::TestInvocation::runUISideScriptAfterUpdateCallback):
1038         * WebKitTestRunner/TestInvocation.h:
1039
1040 2015-09-25  Alexey Proskuryakov  <ap@apple.com>
1041
1042         [Mac] Media tests start to time out after a few days of bot uptime
1043         https://bugs.webkit.org/show_bug.cgi?id=149468
1044
1045         Reviewed by Darin Adler.
1046
1047         Delete cache directory in addition to the temporary one. Don't delete /private/tmp/MediaCache,
1048         as it's not longer used by tests. Set TMPDIR and DIRHELPER_USER_DIR_SUFFIX to make
1049         all temporary and cache files go to a custom location.
1050
1051         * Scripts/webkitpy/port/base.py:
1052         * Scripts/webkitpy/port/driver.py:
1053         * Scripts/webkitpy/port/mac.py:
1054         * Scripts/webkitpy/port/win.py:
1055         (WinPort._driver_tempdir_for_environment): Deleted unused function.
1056
1057 2015-09-25  Dan Bernstein  <mitz@apple.com>
1058
1059         Removed MiniBrowser.entitlements.
1060
1061         Rubber-stamped by Anders Carlsson.
1062
1063         The entitlements weren’t used anyway.
1064
1065         * MiniBrowser/MiniBrowser.entitlements: Removed.
1066         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1067
1068 2015-09-24  Daniel Bates  <dabates@apple.com>
1069
1070         Add WebKitSystemInterface for iOS 9.0
1071         https://bugs.webkit.org/show_bug.cgi?id=149550
1072
1073         Rubber-stamped by Alexey Proskuryakov.
1074
1075         * Scripts/copy-webkitlibraries-to-product-directory:
1076
1077 2015-09-24  Daniel Bates  <dabates@apple.com>
1078
1079         Support building for arbitrary architectures
1080         https://bugs.webkit.org/show_bug.cgi?id=149539
1081
1082         Reviewed by Alexey Proskuryakov.
1083
1084         Teach buildbot to pass the architectures associated with the builder to build-webkit
1085         when building on OS X and iOS. As a side effect of this change we now support building
1086         universal binaries when multiples architectures are specified.
1087
1088         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1089         (CompileWebKit.start):
1090
1091 2015-09-24  Daniel Bates  <dabates@apple.com>
1092
1093         Fix the build after <http://trac.webkit.org/changeset/190212>
1094         (http://trac.webkit.org/changeset/190212)
1095
1096         I inadvertently did not remove the fullPlatform argument from one of the callers of archiveBuiltProduct().
1097
1098         * BuildSlaveSupport/built-product-archive:
1099         (main):
1100
1101 2015-09-24  Daniel Bates  <dabates@apple.com>
1102
1103         Support running unit tests on iOS Simulator test bot
1104         https://bugs.webkit.org/show_bug.cgi?id=149536
1105
1106         Reviewed by Alexey Proskuryakov.
1107
1108         Implements support for running unit tests on a iOS test bot. At the time of writing,
1109         the script run-api-tests supports running unit tests on Mac, Windows and iOS Simulator.
1110
1111         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1112         (RunUnitTests.start): Append appropriate command line flag when invoking script run-api-tests.
1113         (TestFactory.__init__): Add step RunUnitTests when the test bot is for the iOS Simulator platform.
1114
1115 2015-09-24  Daniel Bates  <dabates@apple.com>
1116
1117         Add support infrastructure for OpenSource iOS builders and testers
1118         https://bugs.webkit.org/show_bug.cgi?id=149534
1119
1120         Reviewed by Darin Adler.
1121
1122         Towards setting up OpenSource iOS build bots, teach buildbot and its support
1123         scripts about iOS.
1124
1125         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1126         (appendCustomBuildFlags): Require the caller to pass parameter fullPlatform and append
1127         --ios-simulator or --device for a builder/tester whose full platform name begins with
1128         "ios-simulator" or "ios", respectively.
1129         (RunJavaScriptCoreTests.start): Pass the full platform name to appendCustomBuildFlags().
1130         * BuildSlaveSupport/built-product-archive:
1131         (main): Pass the full platform name to determineWebKitBuildDirectory().
1132         (determineWebKitBuildDirectory): Call script webkit-build-directory with the appropriate
1133         command line flag when building for iOS.
1134         (archiveBuiltProduct): Use the same logic for iOS as we do for Mac. Also, remove unused
1135         parameter fullPlatform. This parameter was originally added in r125066 to support the
1136         Chromium Android port, which has since been removed from the OpenSource WebKit Project.
1137         (extractBuiltProduct): Use the same logic for iOS as we do for Mac.
1138         * BuildSlaveSupport/clean-build:
1139         (main): Call script webkit-build-directory with the appropriate command line flag when
1140         building for iOS.
1141         * BuildSlaveSupport/delete-stale-build-files:
1142         (main): Use the same logic for iOS as we do for Mac.
1143         (webkitBuildDirectory): Call script webkit-build-directory with the appropriate command line
1144         flag when building for iOS.
1145         * BuildSlaveSupport/test-result-archive:
1146         (archiveTestResults): Use the same logic for iOS as we do for Mac.
1147
1148 2015-09-24  Daniel Bates  <dabates@apple.com>
1149
1150         Remove Chromium-specific changes to script built-product-archive
1151         https://bugs.webkit.org/show_bug.cgi?id=149530
1152
1153         Rubber-stamped by Csaba Osztrogonác.
1154
1155         Reverts changes made in r113074 and r113067 to support Chromium testers. The
1156         Chromium code has long since been removed from the OpenSource WebKit Project.
1157
1158         * BuildSlaveSupport/built-product-archive:
1159         (createZipManually):
1160         (createZip):
1161         (archiveBuiltProduct):
1162
1163 2015-09-24  Dan Bernstein  <mitz@apple.com>
1164
1165         Build fix.
1166
1167         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1168
1169 2015-09-24  Mark Lam  <mark.lam@apple.com>
1170
1171         Unreviewed. Make Lucas Forschler a WebKit reviewer.
1172
1173         * Scripts/webkitpy/common/config/contributors.json:
1174
1175 2015-09-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1176
1177         Unreviewed. Fix GObject DOM API breaks after r190120.
1178
1179         Bring back code removed in r169931 to handle documentation of
1180         deleted classes.
1181
1182         * gtk/webkitdom.py:
1183         (WebKitDOMDocGenerator):
1184         (WebKitDOMDocGenerator.write_deleted_classes):
1185         (WebKitDOMDocGenerator.generate):
1186         (write_deleted_classes):
1187         (WebKitDOMDocGeneratorSections._deleted_class):
1188         (WebKitDOMDocGeneratorSections._deleted_class.in):
1189         (WebKitDOMDocGeneratorSections.write_deleted_classes):
1190         (WebKitDOMDocGeneratorSections.write_deleted_classes.with):
1191
1192 2015-09-23  Myles C. Maxfield  <mmaxfield@apple.com>
1193
1194         [Cocoa] [Font Features] Implement font-variant-*
1195         https://bugs.webkit.org/show_bug.cgi?id=148413
1196
1197         Reviewed by Darin Adler.
1198
1199         Update test font to use "lnum" feature.
1200
1201         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1202         (Generator::appendGSUBTable):
1203
1204 2015-09-22  Andy Estes  <aestes@apple.com>
1205
1206         ContentFiltering.AllowDownloadAfterAddData is very flaky
1207         https://bugs.webkit.org/show_bug.cgi?id=148885
1208         <rdar://problem/22729563>
1209
1210         Reviewed by Alexey Proskuryakov.
1211
1212         The AllowDownload* tests were relying on -_downloadDidStart: being called before -webView:didFinishNavigation:,
1213         but there is no guarantee of this. For tests that should allow a download, spin the runloop until
1214         -_downloadDidStart: is called. The test will now timeout on failure, but will no longer produce false failures.
1215
1216         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
1217         (downloadTest):
1218
1219 2015-09-22  Alexey Proskuryakov  <ap@apple.com>
1220
1221         Mavericks: Media tests start to time out after a few days of bot uptime
1222         https://bugs.webkit.org/show_bug.cgi?id=149468
1223
1224         Reviewed by Chris Dumez.
1225
1226         * Scripts/webkitpy/port/base.py:
1227         * Scripts/webkitpy/port/driver.py:
1228         * Scripts/webkitpy/port/mac.py:
1229
1230 2015-09-22  Nan Wang  <n_wang@apple.com>
1231
1232         Unreviewed, add myself to the committers list.
1233
1234         * Scripts/webkitpy/common/config/contributors.json:
1235
1236 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1237
1238         Remove 'nullable' to fix older iOS builds.
1239
1240         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1241         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1242
1243 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1244
1245         [Win] Show tiled drawing debug overlay on Windows
1246         https://bugs.webkit.org/show_bug.cgi?id=149426
1247
1248         Reviewed by Dean Jackson.
1249
1250         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Add new menu option.
1251         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Ditto.
1252         * MiniBrowser/win/Common.cpp:
1253         (::ToggleMenuItem): Recognize new menu item and toggle the 'showTiledScrollingIndicator'
1254         flag if needed.
1255         * MiniBrowser/win/MiniBrowser.h: Update to use new IWebPreferencesPrivate3 class.
1256
1257 2015-09-21  Brent Fulgham  <bfulgham@apple.com>
1258
1259         [Win] Use command-line argument to launch in regular or High DPI mode.
1260         https://bugs.webkit.org/show_bug.cgi?id=149417
1261
1262         Reviewed by Dean Jackson.
1263
1264         * MiniBrowser/win/Common.cpp:
1265         (parseCommandLine): Ignore the '--highDPI' argument. It's used at the
1266         very start of execution, before the MiniBrowser.dll is loaded.
1267         * win/DLLLauncher/DLLLauncherMain.cpp:
1268         (shouldUseHighDPI): Check for '--highDPI', and use this mode if
1269         present. On WinCairo, always use High DPI.
1270
1271 2015-09-21  Ryosuke Niwa  <rniwa@webkit.org>
1272
1273         32-bit Mac build fix attempt after r190065.
1274
1275         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1276
1277 2015-09-21  Alexey Proskuryakov  <ap@apple.com>
1278
1279         [OS X] Update for Xcode 7.0 on Yosemite
1280         https://bugs.webkit.org/show_bug.cgi?id=149389
1281
1282         Reviewed by Dan Bernstein.
1283
1284         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1285         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1286         Removed unneeded declarations - conforming to a protocol is sufficient.
1287
1288         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1289         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1290         Changed the definitions to be compiled whenever the SDK requires it (so we will have
1291         dead code compiled in when building for 10.10 with 10.11 SDK, somewhat unfortunately).
1292
1293 2015-09-21  Simon Fraser  <simon.fraser@apple.com>
1294
1295         Add the ability for tests to run script in the UI process in WebKitTestRunner
1296         https://bugs.webkit.org/show_bug.cgi?id=149356
1297
1298         Reviewed by Tim Horton.
1299
1300         This change adds testRunner.runUIScript(script, callback), which allows a test
1301         to execute script in a JSContext which runs in the UI process. That context
1302         has bindings exposed through the UIScriptController interface; currently one test
1303         function, and some iOS-specific functions are included. UIScriptController can be
1304         async with a callback, and runUIScript() itself is asynchronous. When the UI
1305         script is complete, it calls uiController.uiScriptComplete(result), where 'result'
1306         is a string passed back to the web process, and given to the runUIScript()
1307         callback function.
1308
1309         Thanks to Gyuyoung Kim for help with the Gtk/Efl build.
1310
1311         * WebKitTestRunner/DerivedSources.make: Build UIScriptController.idl.
1312         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add runUIScript().
1313         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1314         (WTR::InjectedBundle::didReceiveMessageToPage): When the UI-side script is
1315         complete, call back into TestRunner.
1316         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1317         (WTR::nextUIScriptCallbackID):
1318         (WTR::TestRunner::runUIScript): Post a message to the injected bundle to run the UI script.
1319         (WTR::TestRunner::runUIScriptCallback): When the UI script is done, execute its callback function.
1320         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1321         * WebKitTestRunner/PlatformWebView.h:
1322         * WebKitTestRunner/TestController.cpp:
1323         (WTR::updateTestOptionsFromTestHeader):
1324         (WTR::TestController::testOptionsForTest): Support "useFlexibleViewport" as a test argument.
1325         (WTR::shouldUseFixedLayout): Deleted. Moved to a TestInvocation function.
1326         * WebKitTestRunner/TestInvocation.cpp:
1327         (WTR::TestInvocation::shouldUseFixedLayout):
1328         (WTR::TestInvocation::shouldUseThreadedScrolling):
1329         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1330         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1331         (WTR::TestInvocation::runUISideScript): Run the UI-side script!
1332         (WTR::TestInvocation::uiScriptDidComplete): Send a message back to the injected bundle.
1333         * WebKitTestRunner/TestInvocation.h:
1334         * WebKitTestRunner/TestOptions.h:
1335         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1336         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1337         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1338         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm: Added.
1339         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]):
1340         (-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]):
1341         (-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]):
1342         (-[TestRunnerWKWebView onDidEndZooming:]): Allow a test to hook into the end of zooming.
1343         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1344         (WTR::PlatformWebView::PlatformWebView): Make a TestRunnerWKWebView on iOS.
1345         * WebKitTestRunner/ios/UIScriptControllerIOS.mm: Added.
1346         (WTR::UIScriptController::doAsyncTask):
1347         (WTR::UIScriptController::zoomToScale):
1348         (WTR::UIScriptController::zoomScale):
1349         (WTR::UIScriptController::minimumZoomScale):
1350         (WTR::UIScriptController::maximumZoomScale):
1351         (WTR::UIScriptController::contentVisibleRect):
1352         * WebKitTestRunner/mac/EventSenderProxy.mm:
1353         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1354         (-[TestRunnerWKWebView dragImage:at:offset:event:pasteboard:source:slideBack:]): Deleted.
1355         * WebKitTestRunner/mac/TestControllerMac.mm:
1356         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1357         (WTR::shouldUseThreadedScrolling): Deleted. Moved to TestInvocation.
1358         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1359         * WebKitTestRunner/uiscriptcontext/UIScriptContext.cpp: Added. Owns the JS context in the UI process.
1360         (UIScriptContext::UIScriptContext):
1361         (UIScriptContext::~UIScriptContext):
1362         (UIScriptContext::runUIScript): Entrypoint to running the UI script. If the script didn't do anything
1363         asynchronous, call the callback.
1364         (UIScriptContext::nextTaskCallbackID):
1365         (UIScriptContext::prepareForAsyncTask): Do setup for one async task (i.e. a UIScriptController function
1366         that has a callback). Has to store the callbackID of the script, so code called from the completion
1367         callback knows which UI script invoked it.
1368         (UIScriptContext::asyncTaskComplete): Called when one task is finished.
1369         (UIScriptContext::uiScriptComplete):
1370         (UIScriptContext::objectFromRect): Make a JS object from a rect.
1371         * WebKitTestRunner/uiscriptcontext/UIScriptContext.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1372         (WTR::UIScriptContext::hasOutstandingAsyncTasks):
1373         * WebKitTestRunner/uiscriptcontext/UIScriptController.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.
1374         (WTR::UIScriptController::UIScriptController):
1375         (WTR::UIScriptController::makeWindowObject):
1376         (WTR::UIScriptController::wrapperClass):
1377         (WTR::UIScriptController::doAsyncTask):
1378         (WTR::UIScriptController::zoomToScale):
1379         (WTR::UIScriptController::zoomScale):
1380         (WTR::UIScriptController::minimumZoomScale):
1381         (WTR::UIScriptController::maximumZoomScale):
1382         (WTR::UIScriptController::contentVisibleRect):
1383         (WTR::UIScriptController::uiScriptComplete):
1384         * WebKitTestRunner/uiscriptcontext/UIScriptController.h: Copied from Tools/WebKitTestRunner/TestOptions.h.
1385         (WTR::UIScriptController::create):
1386         * WebKitTestRunner/uiscriptcontext/bindings/UIScriptController.idl: Copied from Tools/WebKitTestRunner/TestOptions.h.
1387
1388 2015-09-21  Tim Horton  <timothy_horton@apple.com>
1389
1390         Turn on threaded scrolling by default in the tests
1391         https://bugs.webkit.org/show_bug.cgi?id=149377
1392
1393         Reviewed by Simon Fraser.
1394
1395         * WebKitTestRunner/mac/TestControllerMac.mm:
1396         (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
1397         (WTR::shouldUseThreadedScrolling): Deleted.
1398         Turn on threaded scrolling by default.
1399
1400 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1401
1402         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
1403         https://bugs.webkit.org/show_bug.cgi?id=149252
1404
1405         Reviewed by Darin Adler.
1406
1407         In case of glib tests the test runner notifies about tests
1408         crashing, but for google tests we don't get any feedback, which
1409         means that in case of a test crashing we get a list of **PASS**
1410         messages and at the summary we are notified that the test suite
1411         has failed, but it's impossible to know which test cases have failed.
1412
1413         * Scripts/run-gtk-tests:
1414         (TestRunner._run_google_test): Add a **CRASH** message if test
1415         case crashed.
1416
1417 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1418
1419         WebKitTestRunner can leak user content script results between tests
1420         https://bugs.webkit.org/show_bug.cgi?id=149391
1421
1422         Reviewed by Sam Weinig.
1423
1424         Move WKBundlePageRemoveAllUserContent call so that it's executed before loading
1425         about:blank, and thus about:blank doesn't have unintended side effects.
1426
1427         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1428         (WTR::InjectedBundle::beginTesting):
1429         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1430         (WTR::InjectedBundlePage::resetAfterTest):
1431
1432 2015-09-20  Alexey Proskuryakov  <ap@apple.com>
1433
1434         [Mac, iOS] AccessibilityController doesn't uninstall global notification handler
1435         https://bugs.webkit.org/show_bug.cgi?id=149384
1436
1437         Reviewed by Chris Fleizach.
1438
1439         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1440         (AccessibilityController::addNotificationListener): Fixed a leak, and cleaned up the code.
1441         (AccessibilityController::platformResetToConsistentState): Actually remove the handler,
1442         regardless of whether someone else holds a reference (we also call -stopListening in
1443         -dealloc).
1444
1445         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1446         (AccessibilityController::platformResetToConsistentState):
1447         (AccessibilityController::addNotificationListener):
1448         Ditto.
1449
1450 2015-09-20  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1451
1452         Remove XHR_TIMEOUT compilation guard
1453         https://bugs.webkit.org/show_bug.cgi?id=149260
1454
1455         Reviewed by Benjamin Poulain.
1456
1457         * Scripts/webkitperl/FeatureList.pm:
1458
1459 2015-09-19  Dan Bernstein  <mitz@apple.com>
1460
1461         Attempted build fix.
1462
1463         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1464
1465 2015-09-18  Commit Queue  <commit-queue@webkit.org>
1466
1467         Unreviewed, rolling out r189908.
1468         https://bugs.webkit.org/show_bug.cgi?id=149368
1469
1470         Broke run-webkit-tests --pixel (Requested by ap on #webkit).
1471
1472         Reverted changeset:
1473
1474         "printing does not use minimum page zoom factor"
1475         https://bugs.webkit.org/show_bug.cgi?id=108507
1476         http://trac.webkit.org/changeset/189908
1477
1478 2015-09-18  Andy Estes  <aestes@apple.com>
1479
1480         [iOS] did{Start,Finish}LoadForQuickLookDocumentInMainFrame is never called on WKNavigationDelegate
1481         https://bugs.webkit.org/show_bug.cgi?id=149360
1482
1483         Reviewed by Tim Horton.
1484
1485         Added an API test.
1486
1487         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1488         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm: Added.
1489         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
1490         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
1491         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]):
1492         (TEST):
1493         * TestWebKitAPI/ios/pages.pages: Added.
1494
1495 2015-09-18  Nan Wang  <n_wang@apple.com>
1496
1497         AX: Implement ARIA 1.1 @aria-current on iOS
1498         https://bugs.webkit.org/show_bug.cgi?id=149297
1499
1500         Reviewed by Chris Fleizach.
1501
1502         Added support to test aria-current on iOS.
1503
1504         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1505         (AccessibilityUIElement::stringAttributeValue):
1506         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1507         (WTR::AccessibilityUIElement::stringAttributeValue):
1508
1509 2015-09-18  Alexey Proskuryakov  <ap@apple.com>
1510
1511         iOS WebKitTestRunner frequently crashes in WKContextGetIconDatabase
1512         https://bugs.webkit.org/show_bug.cgi?id=149352
1513
1514         Reviewed by Simon Fraser.
1515
1516         * WebKitTestRunner/TestController.cpp: (WTR::TestController::~TestController):
1517         m_context can be null. This may indicate a bug in webkitpy too, but
1518         WebKitTestRunner should handle this situation nicely, there is nothing intrinsically
1519         wrong with opening and immediately closing it.
1520
1521 2015-09-18  Daniel Bates  <dabates@apple.com>
1522
1523         isGitSVNDirectory() returns true when Git is not installed
1524         https://bugs.webkit.org/show_bug.cgi?id=149351
1525
1526         Reviewed by Alexey Proskuryakov.
1527
1528         Fixes an issue where VCSUtils::isGitSVNDirectory() returns true for any arbitrary directory if
1529         Git is not installed on the machine.
1530
1531         * Scripts/VCSUtils.pm:
1532         (isGitSVNDirectory): Ensure that `git config --get svn-remote.svn.fetch 2>& 1` exits with
1533         status code 0 (success).
1534
1535 2015-09-18  Alex Christensen  <achristensen@webkit.org>
1536
1537         Prevent build-webkit from building four times on Windows
1538         https://bugs.webkit.org/show_bug.cgi?id=149336
1539
1540         Reviewed by Brent Fulgham.
1541
1542         * Scripts/build-webkit:
1543         Move the Windows code out of the for loop iterating over each subdirectory to be build.
1544         They're built all at once.
1545         * Scripts/webkitdirs.pm:
1546         (buildVisualStudioProject):
1547         (cmakeGeneratedBuildfile):
1548         Don't generate the Visual Studio solution if it already exists.
1549         It will run CMake again if necessary.
1550
1551 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1552
1553         [iOS WK2] WTR fails to set the key window in the UIKit sense
1554         https://bugs.webkit.org/show_bug.cgi?id=149325
1555
1556         Reviewed by Tim Horton.
1557
1558         -[WebKitTestRunnerWindow isKeyWindow] just returned _platformWebView->windowIsKey().
1559         This causes UIKit to bypass code that actually sets the key window, resulting in
1560         [UIAppliation sharedApplication].keyWindow always being nil.
1561
1562         Fix by PlatformWebView::setWindowIsKey() actually call -makeKeyWindow, and having
1563         -[WebKitTestRunnerWindow isKeyWindow] call super.
1564
1565         * WebKitTestRunner/PlatformWebView.h:
1566         (WTR::PlatformWebView::setWindowIsKey): Deleted.
1567         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
1568         (WTR::PlatformWebView::setWindowIsKey):
1569         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1570         (WTR::PlatformWebView::setWindowIsKey):
1571         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1572         (-[WebKitTestRunnerWindow isKeyWindow]):
1573         (WTR::PlatformWebView::PlatformWebView):
1574         (WTR::PlatformWebView::~PlatformWebView):
1575         (WTR::PlatformWebView::setWindowIsKey):
1576         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1577         (WTR::PlatformWebView::setWindowIsKey):
1578
1579 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1580
1581         [iOS WK2] When loading viewport tests, use the normal web page viewport configuration
1582         https://bugs.webkit.org/show_bug.cgi?id=149321
1583
1584         Reviewed by Tim Horton.
1585
1586         InjectedBundlePage::platformDidStartProvisionalLoadForFrame() unconditionally
1587         enabled the "testing" viewport configuration, which disables page scaling.
1588
1589         If we're running viewport tests, we want the normal web page configuration.
1590         Do that by passing a flag in the dictionary sent to InjectedBundle::beginTesting(),
1591         based on whether the test is in a "viewport" directory.
1592
1593         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1594         (WTR::InjectedBundle::beginTesting):
1595         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
1596         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Deleted.
1597         * WebKitTestRunner/TestInvocation.cpp:
1598         (WTR::TestInvocation::shouldLogFrameLoadDelegates):
1599         (WTR::TestInvocation::shouldLogHistoryClientCallbacks):
1600         (WTR::TestInvocation::shouldMakeViewportFlexible):
1601         (WTR::TestInvocation::invoke):
1602         * WebKitTestRunner/TestInvocation.h:
1603         * WebKitTestRunner/ios/TestControllerIOS.mm:
1604         (WTR::TestController::platformConfigureViewForTest):
1605         (WTR::shouldMakeViewportFlexible): Deleted.
1606
1607 2015-09-17  Simon Fraser  <simon.fraser@apple.com>
1608
1609         Give iOS WebKitTestRunner a launch storyboard
1610         https://bugs.webkit.org/show_bug.cgi?id=149314
1611
1612         Reviewed by Dan Bates.
1613
1614         Add a launch storyboard to iOS WebKitTestRunner so that Springboard recognizes
1615         that it's been built for specific device configurations, and puts the window
1616         at the top of the screen. This simplifies coordinate conversions in a future patch.
1617
1618         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1619         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1620         * WebKitTestRunner/ios/Launch.storyboard: Added.
1621
1622 2015-09-17  Myles C. Maxfield  <mmaxfield@apple.com>
1623
1624         Update licence in r189890
1625         https://bugs.webkit.org/show_bug.cgi?id=149306
1626
1627         Reviewed by Dean Jackson.
1628
1629         * FontWithFeatures/FontWithFeatures/FontCreator.cpp:
1630         * FontWithFeatures/FontWithFeatures/FontCreator.h:
1631         * FontWithFeatures/FontWithFeatures/main.cpp:
1632
1633 2015-09-17  Mark Lam  <mark.lam@apple.com>
1634
1635         Add the ability to skip JIT stress tests in run-javascriptcore-tests.
1636         https://bugs.webkit.org/show_bug.cgi?id=149285
1637
1638         Reviewed by Saam Barati.
1639
1640         Just need to add an option to pass --no-jit to run-jsc-stress-test.
1641
1642         * Scripts/run-javascriptcore-tests:
1643         (runJSCStressTests):
1644
1645 2015-09-17  Alex Christensen  <achristensen@webkit.org>
1646
1647         Switch AppleWin build to use CMake
1648         https://bugs.webkit.org/show_bug.cgi?id=149163
1649
1650         Reviewed by Brent Fulgham.
1651
1652         * Scripts/build-webkit:
1653         * Scripts/run-api-tests:
1654         (runTest):
1655         (listAllTests):
1656         (prepareEnvironmentForRunningTestTool):
1657         (testToolPaths):
1658         (testToolPath): Deleted.
1659         Run the API tests as separate executables on Windows.
1660         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1661         * Scripts/webkitdirs.pm:
1662         (checkRequiredSystemConfig):
1663         (jhbuildWrapperPrefixIfNeeded):
1664         (generateBuildSystemFromCMakeProject):
1665         Fix configuration quirks.
1666
1667 2015-09-17  Dean Johnson  <dean_johnson@apple.com>
1668
1669         Added toggle options for hiding and showing certain platform families on the dashboard.
1670         https://bugs.webkit.org/show_bug.cgi?id=148403
1671
1672         Reviewed by David Kilzer.
1673
1674         This patch removes "hiddenPlatforms" from use in the code and local storage. We also removed
1675         individual hide/show buttons for platforms because we've added toggle options to hide/show entire
1676         families. Examples of these are "mac", "ios", and "linux". "Show All Platforms" was also removed
1677         in lieu of an "all" button in the toggle menu.
1678
1679         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1680         (parsePlatformFamily): Helper function to parse out a platform family.
1681         (initPlatformsByFamily): Initializes platformsByFamily, which organizes platforms on the
1682         page by platformsByFamily[<family>] = <list of platforms belonging to that family>.
1683         (updateToggleButtons): Updates the status of the toggle buttons.
1684         (updateHiddenPlatforms): Changed to work with the new implementation of hiding/showing platforms.
1685         (documentReady): Added creation of toggle buttons.
1686         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1687         (unhiddenQueues): Updated to search by platform family instead of the individual platform name.
1688         (documentReady): Changed hiddenPlatforms => hiddenPlatformFamilies.
1689         (updateHiddenPlatforms): Deleted. After removing the individual hide button code,
1690         this did the exact same thing as the updateHiddenPlatforms in Scripts/Main.js so it was removed.
1691         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1692         (QueueView): Updated to use hiddenPlatformFamilies.
1693         (QueueView.prototype._updateHiddenState): Updated to use hiddenPlatformFamilies.
1694         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
1695         (Settings.prototype.toggleHiddenPlatformFamily): Renamed function and some variables.
1696         (Settings.prototype.clearHiddenPlatformFamilies): Now uses hiddenPlatformFamilies for events.
1697         (Settings.prototype.toggleHiddenPlatform): Deleted.
1698         (Settings.prototype.clearHiddenPlatforms): Deleted.
1699         (Settings.prototype.toggleShowPlatformFamily): Deleted.
1700         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1701         (div.cellButton, div.accessibilityButton, div.platformFamilyToggleButton):
1702         (div.cellButton.unhide, div.accessibilityButton.unhide, div.platformFamilyToggleButton.unhide):
1703         (.settings-visible div.settingsWrapper.hide, .settings-visible div.settingsWrapper):
1704         (table.queue-grid tr.headers th):
1705         (div.settingsWrapper.hide):
1706         (div.settingsWrapper):
1707         (div.familyToggleWrapper):
1708         (div.platformFamilyToggleButton):
1709         (div.platformFamilyShowToggleButton:not(:last-child)):
1710         (div.familyShown):
1711         (div.accessibilityButton):
1712         (div.cellButton, div.accessibilityButton): Added platformFamilyToggleButton class.
1713         (div.cellButton.unhide, div.accessibilityButton.unhide): Added platformFamilyToggleButton class.
1714         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide): Added
1715         platformFamilyToggleButton and settingsWrapper class.
1716         (.accessibilityButton): Deleted.
1717
1718 2015-09-17  Tim Horton  <timothy_horton@apple.com>
1719
1720         Add a test ensuring that scrolling in the middle of a page can't start a swipe gesture
1721         https://bugs.webkit.org/show_bug.cgi?id=148904
1722
1723         Reviewed by Myles Maxfield.
1724
1725         * WebKitTestRunner/TestController.cpp:
1726         (WTR::parseBooleanTestHeaderValue):
1727         (WTR::updateViewOptionsFromTestHeader):
1728         Check for the key "useThreadedScrolling".
1729         Add some code to check for "true" and "false" for boolean options.
1730
1731         (WTR::TestController::viewOptionsForTest):
1732         Apply the test's overrides last, even after the platform's.
1733
1734 2015-09-16  Carlos Garcia Campos  <cgarcia@igalia.com>
1735
1736         printing does not use minimum page zoom factor
1737         https://bugs.webkit.org/show_bug.cgi?id=108507
1738
1739         Reviewed by Darin Adler.
1740
1741         WebKitTestRunner always takes the snapshots from the UI process
1742         (expect for IOS), so in the case of printing, the layout in the
1743         web view is not the expected one. When printing, we need to take
1744         the snapshot in the web process and ensure it's rendered with a
1745         PrintContext.
1746
1747         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1748         (WTR::InjectedBundlePage::dump): When dumping pixels, pass
1749         kWKSnapshotOptionsPrinting option to
1750         WKBundlePageCreateSnapshotWithOptions() when printing. When not
1751         printing, don't even create the snapshot, since it will be ignored
1752         by the UI process that always creates its own from the WebView (expect for IOS platform)
1753         * WebKitTestRunner/TestInvocation.cpp:
1754         (WTR::TestInvocation::dumpResults): Use always the snapshot image
1755         received from the web process if any when comparing pixel
1756         results. Now we only receive a snapshot from the web process in
1757         case of printing, or when platform is IOS. Otherwhise, generate
1758         the snapshot from the WebView as usual.
1759         * WebKitTestRunner/TestInvocation.h: Add SnapshotResultType enum
1760         parameter to dumpPixelsAndCompareWithExpected, since the snapshot
1761         is created by the caller now, but the CG implementation needs to
1762         know if it's a Web or UI process snapshot.
1763         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
1764         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1765         cairo surface for the given image.
1766         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1767         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Create a
1768         CGContext for the given image.
1769
1770 2015-09-16  Myles C. Maxfield  <mmaxfield@apple.com>
1771
1772         Create a font which can be used for testing font features
1773         https://bugs.webkit.org/show_bug.cgi?id=149237
1774
1775         Reviewed by Simon Fraser.
1776
1777         This patch adds a new project in the Tools/ directory which generates a font which can
1778         be used for testing font features. This is a standalone project consisting of two files:
1779         1. A file which actually generates the byte vector representing the font. This file has
1780         a single public function: std::vector<uint8_t> generateFont(). This file is not platform
1781         specific, and only relies on the C++ STL.
1782         2. A file with a main() which calls generateFont() and writes out the font, as well as
1783         uses the font to render some demonstration text into a .png file. This file is platform
1784         specific.
1785
1786         The font itself only supports the following characters:
1787         ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz
1788         However, the shape of these letters are either an X or a check mark.
1789
1790         The letter "A" always is a check mark.
1791         The letter "B" always is an X.
1792         Without any font features turned on, the rest of the letters are shown as X.
1793
1794         Each font feature has an letter associated with it. When the font feature is enabled,
1795         that letter is shown as a check mark. For example, when "smcp" is enabled, "J" is shown
1796         as a check mark.
1797
1798         Here are the mappings of font features to letters:
1799         liga: C
1800         clig: D
1801         dlig: E
1802         hlig: F
1803         calt: G
1804         subs: H
1805         sups: I
1806         smcp: J
1807         c2sc: K
1808         pcap: L
1809         c2pc: M
1810         unic: N
1811         titl: O
1812         onum: P
1813         pnum: Q
1814         tnum: R
1815         frac: S
1816         afrc: T
1817         ordn: U
1818         zero: V
1819         hist: W
1820         jp78: X
1821         jp83: Y
1822         jp90: Z
1823         jp04: a
1824         smpl: b
1825         trad: c
1826         fwid: d
1827         pwid: e
1828         ruby: f
1829
1830         * FontWithFeatures/FontWithFeatures.xcodeproj/project.pbxproj: Added.
1831         * FontWithFeatures/FontWithFeatures/FontCreator.cpp: Added.
1832         (integralLog2):
1833         (roundDownToPowerOfTwo):
1834         (isFourByteAligned):
1835         (clampTo):
1836         (append32):
1837         (writeCFFEncodedNumber):
1838         (CFFBuilder::CFFBuilder):
1839         (CFFBuilder::takeResult):
1840         (CFFBuilder::moveTo):
1841         (CFFBuilder::lineTo):
1842         (CFFBuilder::curveToCubic):
1843         (CFFBuilder::closePath):
1844         (CFFBuilder::writePoint):
1845         (generateBoxCharString):
1846         (generateCheckCharString):
1847         (generateXCharString):
1848         (charStringForGlyph):
1849         (Generator::generate):
1850         (Generator::Placeholder::Placeholder):
1851         (Generator::Placeholder::populate):
1852         (Generator::Placeholder::~Placeholder):
1853         (Generator::placeholder):
1854         (Generator::append16):
1855         (Generator::append32):
1856         (Generator::append32BitCode):
1857         (Generator::overwrite16):
1858         (Generator::overwrite32):
1859         (Generator::appendCFFTable):
1860         (Generator::appendSubstitutionSubtable):
1861         (Generator::appendScriptSubtable):
1862         (Generator::appendGSUBTable):
1863         (Generator::appendOS2Table):
1864         (Generator::appendFormat12CMAPTable):
1865         (Generator::appendFormat4CMAPTable):
1866         (Generator::appendCMAPTable):
1867         (Generator::appendHEADTable):
1868         (Generator::appendHHEATable):
1869         (Generator::appendHMTXTable):
1870         (Generator::appendMAXPTable):
1871         (Generator::appendNAMETable):
1872         (Generator::appendPOSTTable):
1873         (Generator::calculateChecksum):
1874         (Generator::appendTable):
1875         (generateFont):
1876         * FontWithFeatures/FontWithFeatures/FontCreator.h: Added.
1877         * FontWithFeatures/FontWithFeatures/main.cpp: Added.
1878         (drawTextWithFeature):
1879         (main):
1880
1881 2015-09-16  Commit Queue  <commit-queue@webkit.org>
1882
1883         Unreviewed, rolling out r189875 and r189878.
1884         https://bugs.webkit.org/show_bug.cgi?id=149235
1885
1886         cygwin cmake build not ready yet (Requested by alexchristensen
1887         on #webkit).
1888
1889         Reverted changesets:
1890
1891         "Switch AppleWin build to use CMake"
1892         https://bugs.webkit.org/show_bug.cgi?id=149163
1893         http://trac.webkit.org/changeset/189875
1894
1895         "Cygwin build fix after r189875"
1896         http://trac.webkit.org/changeset/189878
1897
1898 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1899
1900         Cygwin build fix after r189875
1901
1902         * Scripts/build-webkit:
1903         * Scripts/webkitdirs.pm:
1904         (jhbuildWrapperPrefixIfNeeded):
1905         (generateBuildSystemFromCMakeProject):
1906         Make things work with cygwin and cmake.
1907
1908 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1909
1910         Switch AppleWin build to use CMake
1911         https://bugs.webkit.org/show_bug.cgi?id=149163
1912
1913         Reviewed by Brent Fulgham.
1914
1915         * Scripts/build-webkit:
1916         Build with CMake.
1917         * Scripts/run-api-tests:
1918         (runTest):
1919         (listAllTests):
1920         (prepareEnvironmentForRunningTestTool):
1921         (testToolPaths):
1922         (testToolPath): Deleted.
1923         Run the API tests as separate executables on Windows.
1924         It used to be TestWebKitAPI.exe, and it is now TestWTF.exe, TestWebCore.exe, and TestWebKit.exe.
1925
1926 2015-09-16  Alexey Proskuryakov  <ap@apple.com>
1927
1928         Add newer build.webkit.org pages to robots.txt
1929         https://bugs.webkit.org/show_bug.cgi?id=149219
1930
1931         Reviewed by Darin Adler.
1932
1933         Indexing bot watcher's dashboard can't be good.
1934
1935         * BuildSlaveSupport/build.webkit.org-config/public_html/robots.txt:
1936
1937 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1938
1939         Rollout r189851 and 189853 because they didn’t actually fix the permissions issue
1940
1941         * BuildSlaveSupport/built-product-archive:
1942         (unzipArchive):
1943
1944 2015-09-16  Csaba Osztrogonác  <ossy@webkit.org>
1945
1946         [EFL] Fix the help message of separated web process option of MiniBrowser
1947         https://bugs.webkit.org/show_bug.cgi?id=149212
1948
1949         Reviewed by Gyuyoung Kim.
1950
1951         * MiniBrowser/efl/main.c:
1952
1953 2015-09-16  Alex Christensen  <achristensen@webkit.org>
1954
1955         Fix python syntax after r189851.
1956
1957         * BuildSlaveSupport/built-product-archive:
1958         (unzipArchive):
1959         For loops need a colon.
1960
1961 2015-09-15  Alex Christensen  <achristensen@webkit.org>
1962
1963         Fix Windows test bots after changing to non-cygwin build
1964         https://bugs.webkit.org/show_bug.cgi?id=149196
1965
1966         Reviewed by Daniel Bates.
1967
1968         * BuildSlaveSupport/built-product-archive:
1969         (unzipArchive):
1970         Using different versions of python makes what I think is https://bugs.python.org/issue15795
1971         prevent us from executing files from the archive on the test bots.
1972
1973 2015-09-15  Ryosuke Niwa  <rniwa@webkit.org>
1974
1975         Add ShadowRoot interface and Element.prototype.attachShadow
1976         https://bugs.webkit.org/show_bug.cgi?id=149187
1977
1978         Reviewed by Antti Koivisto.
1979
1980         * Scripts/webkitperl/FeatureList.pm:
1981
1982 2015-09-15  Aakash Jain  <aakash_jain@apple.com>
1983
1984         Appscale queue status json output lacks bots
1985         https://bugs.webkit.org/show_bug.cgi?id=149194
1986         <rdar://problem/22171089>
1987
1988         Reviewed by Alexey Proskuryakov.
1989
1990         * QueueStatusServer/handlers/queuestatusjson.py:
1991         (QueueStatusJSON._bots): Order the results by date so as to get latest events, this was default in AppEngine.
1992         * QueueStatusServer/index.yaml: Index according to appscale requirements.
1993
1994 2015-09-15  Brent Fulgham  <bfulgham@apple.com>
1995
1996         [Win] Provide a means for viewing the layer tree
1997         https://bugs.webkit.org/show_bug.cgi?id=149165
1998
1999         Reviewed by Simon Fraser.
2000
2001         Update MiniBrowser with a new Debug menu option that will
2002         dump the current layer tree to the debug console.
2003
2004         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc:
2005         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h:
2006         * MiniBrowser/win/Common.cpp:
2007         (WndProc): Add handler for 'Print Layer Tree' menu option.
2008         * MiniBrowser/win/MiniBrowser.cpp:
2009         (MiniBrowser::printLayerTree): Added Handler.
2010         * MiniBrowser/win/MiniBrowser.h:
2011
2012 2015-09-14  Myles C. Maxfield  <mmaxfield@apple.com>
2013
2014         WebKitTestRunner declarative language setting is broken for iOS
2015         https://bugs.webkit.org/show_bug.cgi?id=149119
2016
2017         Unreviewed.
2018
2019         In all of the patches on webkit.org/b/189669, my patch to get this working on iOS was
2020         lost in the final version which got committed. This simply implements the existing
2021         OS X behavior on iOS.
2022
2023         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
2024         (WTR::InjectedBundle::platformInitialize):
2025
2026 2015-09-14  Dewei Zhu  <dewei_zhu@apple.com>
2027
2028         Unreviewed, add myself to committers list.
2029
2030         * Scripts/webkitpy/common/config/contributors.json:
2031
2032 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2033
2034         [Cocoa] Allow testing with the system language
2035         https://bugs.webkit.org/show_bug.cgi?id=148671
2036
2037         Reviewed by Anders Carlsson and Alexey Proskuryakov.
2038
2039         React to tests marked with language=lang1,lang2,etc in their header.
2040         Once this information is parsed, pass it to
2041         WKContextConfigurationSetOverrideLanguages().
2042
2043         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2044         (WTR::InjectedBundle::platformInitialize): Don't clobber the language
2045         list.
2046         * WebKitTestRunner/TestController.cpp:
2047         (WTR::TestController::createWebViewWithOptions): Call
2048         WKContextConfigurationSetOverrideLanguages().
2049         (WTR::updateTestOptionsFromTestHeader): Inspect the language option.
2050         * WebKitTestRunner/TestOptions.h:
2051         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2052         (WTR::PlatformWebView::viewSupportsOptions): Cause a differing language
2053         option to restart the web process.
2054         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2055         (WTR::PlatformWebView::viewSupportsOptions): Ditto.
2056
2057 2015-09-12  Myles C. Maxfield  <mmaxfield@apple.com>
2058
2059         [WKTR] Allow changing the WKContextConfiguration between successive tests
2060         https://bugs.webkit.org/show_bug.cgi?id=148833
2061
2062         Reviewed by Tim Horton.
2063
2064         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2065         However, there are certain tests which require specifying options in this object. This patch makes
2066         our existing code for recreating the test runner web view also recreate the WKContext.
2067
2068         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2069         class.
2070
2071         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2072         * WebKitTestRunner/PlatformWebView.h:
2073         (WTR::PlatformWebView::options):
2074         * WebKitTestRunner/TestController.cpp:
2075         (WTR::TestController::initialize):
2076         (WTR::TestController::generateContextConfiguration):
2077         (WTR::TestController::generatePageConfiguration):
2078         (WTR::TestController::createWebViewWithOptions):
2079         (WTR::TestController::ensureViewSupportsOptionsForTest):
2080         (WTR::updateContextConfigurationOptionsFromTestHeader):
2081         (WTR::TestController::contextConfigurationOptionsForTest):
2082         (WTR::TestController::platformCreateWebView):
2083         (WTR::TestController::platformCreateOtherPage):
2084         (WTR::updateViewOptionsFromTestHeader): Deleted.
2085         (WTR::TestController::viewOptionsForTest): Deleted.
2086         * WebKitTestRunner/TestController.h:
2087         (WTR::TestController::injectedBundlePath):
2088         (WTR::TestController::testPluginDirectory):
2089         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2090         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2091         (WTR::TestController::platformCreateWebView):
2092         (WTR::TestController::platformCreateOtherPage):
2093         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2094         (WTR::PlatformWebView::PlatformWebView):
2095         (WTR::PlatformWebView::viewSupportsOptions):
2096         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2097         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2098         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2099         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2100         (WTR::PlatformWebView::PlatformWebView):
2101         (WTR::PlatformWebView::viewSupportsOptions):
2102         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2103         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2104         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2105         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2106         (WTR::PlatformWebView::PlatformWebView):
2107         (WTR::PlatformWebView::viewSupportsOptions):
2108         * WebKitTestRunner/ios/TestControllerIOS.mm:
2109         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2110         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2111         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2112         (WTR::PlatformWebView::PlatformWebView):
2113         (WTR::PlatformWebView::viewSupportsOptions):
2114         * WebKitTestRunner/mac/TestControllerMac.mm:
2115         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2116         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2117
2118 2015-09-11  Michael Saboff  <msaboff@apple.com>
2119
2120         LayoutTestHelper crashes if a color profile isn't set for a 3rd party monitor
2121         https://bugs.webkit.org/show_bug.cgi?id=149083
2122
2123         Reviewed by Alexey Proskuryakov.
2124
2125         Check to make sure that we have a valid factoryProfile CFDictionaryRef before using it.
2126
2127         * DumpRenderTree/mac/LayoutTestHelper.m:
2128         (colorProfileURLForDisplay):
2129
2130 2015-09-11  Saam barati  <sbarati@apple.com>
2131
2132         There should be a defaultSpotCheck-like mode that doesn't run the MaximalFlushInsertionPhase in run-jsc-stress-tests
2133         https://bugs.webkit.org/show_bug.cgi?id=149058
2134
2135         Reviewed by Geoffrey Garen.
2136
2137         * Scripts/run-jsc-stress-tests:
2138
2139 2015-09-10  Commit Queue  <commit-queue@webkit.org>
2140
2141         Unreviewed, rolling out r189595.
2142         https://bugs.webkit.org/show_bug.cgi?id=149052
2143
2144         The tests still fail (Requested by ap on #webkit).
2145
2146         Reverted changeset:
2147
2148         "Spurious output on Windows tests: AQMEIOManager::FindIOUnit:
2149         error -1"
2150         https://bugs.webkit.org/show_bug.cgi?id=142929
2151         http://trac.webkit.org/changeset/189595
2152
2153 2015-09-10  Alexey Proskuryakov  <ap@apple.com>
2154
2155         Spurious output on Windows tests: AQMEIOManager::FindIOUnit: error -1
2156         https://bugs.webkit.org/show_bug.cgi?id=142929
2157
2158         Reviewed by Brent Fulgham.
2159
2160         Silence the logging. We'll track fixing the root cause in Radar.
2161
2162         * Scripts/webkitpy/port/mac.py:
2163         (MacPort.stderr_patterns_to_strip): Added a FIXME.
2164
2165         * Scripts/webkitpy/port/win.py:
2166         (WinPort.logging_patterns_to_strip): Added.
2167
2168 2015-09-09  Andy Estes  <aestes@apple.com>
2169
2170         [iOS] Teach run-webkit-tests how to parse simulator runtimes when version numbers contain a revision
2171         https://bugs.webkit.org/show_bug.cgi?id=149022
2172
2173         Reviewed by Daniel Bates.
2174
2175         Simulator runtime versions can contain a revision number (e.g. 8.4.1), but the regex for matching runtimes
2176         did not account for this.
2177
2178         * Scripts/webkitpy/xcode/simulator.py:
2179         (Simulator): Optionally matched a revision at the end of a runtime version number.
2180         * Scripts/webkitpy/xcode/simulator_unittest.py: Added a test.
2181
2182 2015-09-09  Andy Estes  <aestes@apple.com>
2183
2184         [iOS] Teach run-webkit-tests how to parse `simctl list` when a tvOS SDK is installed
2185         https://bugs.webkit.org/show_bug.cgi?id=149029
2186         <rdar://problem/22432624>
2187
2188         Reviewed by Daniel Bates.
2189
2190         * Scripts/webkitpy/xcode/simulator.py:
2191         (Simulator): Taught to parse tvOS runtimes.
2192         * Scripts/webkitpy/xcode/simulator_unittest.py: Added tests.
2193
2194 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2195
2196         Fix bit rot on bot watcher's dashboard page
2197         https://bugs.webkit.org/show_bug.cgi?id=149012
2198
2199         Reviewed by Tim Horton.
2200
2201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2202         The code path used by the metrics page was trying to add properties to an undefined.
2203
2204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2205         Silence an expection that would occur when the step has no logs. This should never
2206         happen, but it did (perhaps buildbot was misconfigured for a while).
2207
2208 2015-09-09  Alexey Proskuryakov  <ap@apple.com>
2209
2210         Update LayoutTestRelay xcconfig file.
2211
2212         Rubber-stamped by Dan Bernstein.
2213
2214         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2215
2216 2015-09-09  Saam barati  <sbarati@apple.com>
2217
2218         DFG should have a debugging option that runs a phase that flushes all locals
2219         https://bugs.webkit.org/show_bug.cgi?id=148916
2220
2221         Reviewed by Filip Pizlo.
2222
2223         * Scripts/run-jsc-stress-tests:
2224
2225 2015-09-09  Commit Queue  <commit-queue@webkit.org>
2226
2227         Unreviewed, rolling out r189530 and r189534.
2228         https://bugs.webkit.org/show_bug.cgi?id=148996
2229
2230         Caused assertion failures on Yosemite (Requested by litherum
2231         on #webkit).
2232
2233         Reverted changesets:
2234
2235         "[WKTR] Allow changing the WKContextConfiguration between
2236         successive tests"
2237         https://bugs.webkit.org/show_bug.cgi?id=148833
2238         http://trac.webkit.org/changeset/189530
2239
2240         "[Cocoa] Fix the tests after r189530"
2241         http://trac.webkit.org/changeset/189534
2242
2243 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2244
2245         [Cocoa] Fix the tests after r189530
2246
2247         Unreviewed.
2248
2249         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2250         (WTR::initializeWebViewConfiguration):
2251
2252 2015-09-08  Myles C. Maxfield  <mmaxfield@apple.com>
2253
2254         [WKTR] Allow changing the WKContextConfiguration between successive tests
2255         https://bugs.webkit.org/show_bug.cgi?id=148833
2256
2257         Reviewed by Tim Horton.
2258
2259         Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
2260         However, there are certain tests which require specifying options in this object. This patch makes
2261         our existing code for recreating the test runner web view also recreate the WKContext.
2262
2263         As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
2264         class.
2265
2266         * WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
2267         * WebKitTestRunner/PlatformWebView.h:
2268         (WTR::PlatformWebView::options):
2269         * WebKitTestRunner/TestController.cpp:
2270         (WTR::TestController::initialize):
2271         (WTR::TestController::generateContextConfiguration):
2272         (WTR::TestController::generatePageConfiguration):
2273         (WTR::TestController::createWebViewWithOptions):
2274         (WTR::TestController::ensureViewSupportsOptionsForTest):
2275         (WTR::updateContextConfigurationOptionsFromTestHeader):
2276         (WTR::TestController::contextConfigurationOptionsForTest):
2277         (WTR::TestController::platformCreateWebView):
2278         (WTR::TestController::platformCreateOtherPage):
2279         (WTR::updateViewOptionsFromTestHeader): Deleted.
2280         (WTR::TestController::viewOptionsForTest): Deleted.
2281         * WebKitTestRunner/TestController.h:
2282         (WTR::TestController::injectedBundlePath):
2283         (WTR::TestController::testPluginDirectory):
2284         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2285         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2286         (WTR::TestController::platformCreateWebView):
2287         (WTR::TestController::platformCreateOtherPage):
2288         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2289         (WTR::PlatformWebView::PlatformWebView):
2290         (WTR::PlatformWebView::viewSupportsOptions):
2291         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2292         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2293         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2294         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2295         (WTR::PlatformWebView::PlatformWebView):
2296         (WTR::PlatformWebView::viewSupportsOptions):
2297         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2298         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2299         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2300         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2301         (WTR::PlatformWebView::PlatformWebView):
2302         (WTR::PlatformWebView::viewSupportsOptions):
2303         * WebKitTestRunner/ios/TestControllerIOS.mm:
2304         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2305         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2306         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2307         (WTR::PlatformWebView::PlatformWebView):
2308         (WTR::PlatformWebView::viewSupportsOptions):
2309         * WebKitTestRunner/mac/TestControllerMac.mm:
2310         (WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
2311         (WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
2312
2313 2015-09-08  Daniel Bates  <dabates@apple.com>
2314
2315         [Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
2316         https://bugs.webkit.org/show_bug.cgi?id=148980
2317
2318         Reviewed by Alexey Proskuryakov.
2319
2320         Add setting to enable/disable accelerated drawing so as to support testing
2321         this feature in MiniBrowser on Mac.
2322
2323         * MiniBrowser/mac/SettingsController.h:
2324         * MiniBrowser/mac/SettingsController.m:
2325         (-[SettingsController _populateMenu]): Add menu item.
2326         (-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
2327         (-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
2328         (-[SettingsController acceleratedDrawingEnabled]): Added.
2329         * MiniBrowser/mac/WK1BrowserWindowController.m:
2330         (-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
2331         * MiniBrowser/mac/WK2BrowserWindowController.m:
2332         (-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.
2333
2334 2015-09-08  Jason Marcell  <jmarcell@apple.com>
2335
2336         Unreviewed. Added myself as a commiter in contributors.json.
2337
2338         * Scripts/webkitpy/common/config/contributors.json:
2339
2340 2015-09-08  Keith Miller  <keith_miller@apple.com>
2341
2342         Unreviewed, added myself to the list of contributors.
2343
2344         * Scripts/webkitpy/common/config/contributors.json:
2345
2346 2015-09-08  Daniel Bates  <dabates@apple.com>
2347
2348         Dashboard: Remove use of z-index for ring overlay; use DOM ordering
2349         https://bugs.webkit.org/show_bug.cgi?id=148921
2350
2351         Reviewed by Alexey Proskuryakov.
2352
2353         The ring image is positioned above the platform icon in markup and we specify the CSS
2354         property z-index for the ring image so that it is painted on top of the platform icon
2355         instead of below it (by DOM ordering). Instead we can take advantage of the transparency
2356         of the ring image, switch the order of these DOM elements and remove the use of the CSS
2357         property z-index to achieve a similar effect.
2358
2359         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2360         (documentReady): Create the platform icon image element before the ring image such that
2361         the ring image is painted on top of the platform icon.
2362         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2363         (table.queue-grid td.logo img.ring): Removed property z-index.
2364
2365 2015-09-08  Daniel Bates  <dabates@apple.com>
2366
2367         Dashboard: Remove duplicate gear icon data URLs
2368         https://bugs.webkit.org/show_bug.cgi?id=148920
2369
2370         Reviewed by Alexey Proskuryakov.
2371
2372         Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
2373         background-image associated with each of the three gear icon states: collapsed (.settings), hover
2374         (.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
2375         as a mask and make use of the CSS background-color to define the fill color for each of these three
2376         states.
2377
2378         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2379         (.settings): Use gear icon as mask and define CSS background-color for collapsed state.
2380         (.settings:hover): Override CSS background-color for hover state.
2381         (.settings-visible .settings): Override CSS background-color for expanded state.
2382
2383 2015-09-07  Andy Estes  <aestes@apple.com>
2384
2385         [Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
2386         https://bugs.webkit.org/show_bug.cgi?id=148946
2387         <rdar://problem/22603981>
2388
2389         Reviewed by Dan Bernstein.
2390
2391         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2392         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2393
2394 2015-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
2395
2396         [EFL] Many of the css3/device-adapt/* tests failed after r188548.
2397         https://bugs.webkit.org/show_bug.cgi?id=148927
2398
2399         Reviewed by Csaba Osztrogonác.
2400
2401         device-adapt/* tests need the fixedLayout option but useFixedLayout option is
2402         overwritten by updatePlatformSpecificViewOptionsForTest after r188548.
2403
2404         * WebKitTestRunner/TestController.cpp:
2405         (WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
2406         * WebKitTestRunner/efl/TestControllerEfl.cpp:
2407         (WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.
2408
2409 2015-09-07  Andy Estes  <aestes@apple.com>
2410
2411         Fix the Production build after r189455.
2412
2413         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
2414         In-App Purchase template instead of the Aggregate template. Whoops.
2415
2416 2015-09-06  Andy Estes  <aestes@apple.com>
2417
2418         WebKit.xcworkspace should be be able to build iOS platforms
2419         https://bugs.webkit.org/show_bug.cgi?id=148881
2420
2421         Reviewed by Daniel Bates.
2422
2423         Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
2424         for all supported platforms.
2425
2426         * MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
2427         * MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
2428         * MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
2429         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.
2430
2431 2015-09-06  Andy Estes  <aestes@apple.com>
2432
2433         WebKitTestRunner should build for iOS using the default target
2434         https://bugs.webkit.org/show_bug.cgi?id=148918
2435
2436         Reviewed by Daniel Bates.
2437
2438         When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
2439         iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
2440         non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.
2441
2442         This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
2443         both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
2444         and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
2445         WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
2446         WebKitTestRunner is skipped when installing on iOS.
2447
2448         The target dependency graph now looks like this:
2449
2450             All
2451                 WebKitTestRunnerApp
2452                     WebKitTestRunner (Library)
2453                         WebKitTestRunnerInjectedBundle
2454                             Derived Sources
2455                 WebKitTestRunner
2456                     WebKitTestRunner (Library)
2457                         WebKitTestRunnerInjectedBundle
2458                             Derived Sources
2459
2460         * Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
2461         * Scripts/build-webkittestrunner: Ditto.
2462         * WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
2463         * WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
2464         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
2465         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
2466         excluded iOS-only files, and skipped installing on iOS.
2467         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
2468         excluded Mac-only files, and skipped installing on Mac.
2469         * WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
2470         * WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
2471         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
2472         Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
2473         new configuration files.
2474
2475 2015-09-05  Joseph Pecoraro  <pecoraro@apple.com>
2476
2477         Web Inspector: Improve prepare-ChangeLog for multiple cases
2478         https://bugs.webkit.org/show_bug.cgi?id=148875
2479
2480         Reviewed by Timothy Hatcher.
2481
2482         * Scripts/prepare-ChangeLog:
2483         (get_function_line_ranges_for_javascript):
2484         - We were ignoring everything inside of an anonymous function expression,
2485           such as (function(){ ... }), which made InjectedScriptSource produce nothing.
2486           Better handle this by inserting a few tweaks.
2487         - Allow method syntax outside of classes as long as they are at the global level.
2488         - Avoid treating "get" and "set" as getter/setter functions in bad contexts.
2489
2490         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2491         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2492         (Foo.prototype.method1):
2493         (Foo.prototype.method2):
2494         (Foo.prototype.method3.innerFunction):
2495         (Foo.prototype.method3):
2496         (insideGlobalAnonymousFunctionExpression):
2497         (foo.insideGlobalFunctionExpression):
2498         (IssueWithMapGetAndSet.prototype.method1.nestedFunctionInsideMethod1):
2499         (IssueWithMapGetAndSet.prototype.method1):
2500         (IssueWithMapGetAndSet.prototype.method2):
2501         (IssueWithMapGetAndSet.prototype.method3):
2502         (IssueWithMapGetAndSet):
2503
2504 2015-09-05  Yusuke Suzuki  <utatane.tea@gmail.com>
2505
2506         [ES6] Enable ES6 Module in JSC shell by default
2507         https://bugs.webkit.org/show_bug.cgi?id=148689
2508
2509         Reviewed by Geoffrey Garen.
2510
2511         * Scripts/run-javascriptcore-tests:
2512         (runJSCStressTests):
2513         * Scripts/run-jsc-stress-tests:
2514
2515 2015-09-04  Basile Clement  <basile_clement@apple.com>
2516
2517         Unreviewed, change my email address.
2518
2519         * Scripts/webkitpy/common/config/contributors.json:
2520
2521 2015-09-04  Beth Dakin  <bdakin@apple.com>
2522
2523         Should have a test to make sure links don't navigate after a cancelled force
2524         click
2525         https://bugs.webkit.org/show_bug.cgi?id=148846
2526
2527         Reviewed by Tim Horton.
2528
2529         New EventSender function for a started then cancelled force click.
2530         * WebKitTestRunner/EventSenderProxy.h:
2531         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2532         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2533         (WTR::EventSendingController::mouseForceClick):
2534         (WTR::EventSendingController::startAndCancelMouseForceClick):
2535         (WTR::EventSendingController::mouseForceDown):
2536         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2537         * WebKitTestRunner/TestController.cpp:
2538         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2539         * WebKitTestRunner/mac/EventSenderProxy.mm:
2540         (WTR::EventSenderProxy::mouseForceClick):
2541         (WTR::EventSenderProxy::startAndCancelMouseForceClick):
2542         (WTR::EventSenderProxy::mouseForceDown):
2543         (WTR::EventSenderProxy::mouseMoveTo):
2544
2545 2015-09-04  Tim Horton  <timothy_horton@apple.com>
2546
2547         Add a test for r179736 (programmatic navigation during swipe causing a crash)
2548         https://bugs.webkit.org/show_bug.cgi?id=148830
2549
2550         Reviewed by Beth Dakin.
2551
2552         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2553         (WTR::InjectedBundle::beginTesting):
2554         Make sure that TestRunner callbacks don't leak between tests!
2555
2556 2015-09-04  Anders Carlsson  <andersca@apple.com>
2557
2558         It should be possible to pass relative HTTP test paths to DumpRenderTree
2559         https://bugs.webkit.org/show_bug.cgi?id=148825
2560         <rdar://problem/22583866>
2561
2562         Reviewed by Tim Horton.
2563
2564         Convert the path to an absolute path if needed.
2565
2566         * DumpRenderTree/mac/DumpRenderTree.mm:
2567         (computeTestURL):
2568
2569 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2570
2571         Fix Swift unit tests for prepare-ChangeLog.
2572         https://bugs.webkit.org/show_bug.cgi?id=148817
2573
2574         Reviewed by Alexey Proskuryakov.
2575
2576         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Fixed
2577         Swift unit tests for prepare-ChangeLog.
2578
2579 2015-09-04  Lucas Forschler  <lforschler@apple.com>
2580
2581         Modifications to the webkit-nightly logic.
2582
2583         * WebKitLauncher/WebKitNightlyEnablerSparkle.m:
2584         (updateAlertPanel):
2585         * WebKitLauncher/main.m:
2586         (displayErrorAndQuit):
2587
2588 2015-09-04  Beth Dakin  <bdakin@apple.com>
2589
2590         Speculative build fix.
2591
2592         * WebKitTestRunner/mac/EventSenderProxy.mm:
2593
2594 2015-09-04  Brian Burg  <bburg@apple.com>
2595
2596         Web Inspector: InspectorController should support multiple frontend channels
2597         https://bugs.webkit.org/show_bug.cgi?id=148538
2598
2599         Reviewed by Joseph Pecoraro.
2600
2601         InspectorClients must explicitly disconnect their frontend channel(s) from the
2602         inspected page's InspectorController.
2603
2604         To make this possible, DumpRenderTree should not destroy non-primary views until
2605         it has tried to close any abandoned Web Inspector instances. Performing teardown
2606         in the reverse order prevents disconnection of the frontend channel because that
2607         prematurely destroys the inspector frontend client.
2608
2609         * DumpRenderTree/mac/DumpRenderTree.mm:
2610         (runTest):
2611         * DumpRenderTree/win/DumpRenderTree.cpp:
2612         (runTest):
2613
2614 2015-09-04  Beth Dakin  <bdakin@apple.com>
2615
2616         Need to be able to test default behaviors on force click
2617         https://bugs.webkit.org/show_bug.cgi?id=148758
2618
2619         Reviewed by Tim Horton.
2620
2621         This patch adds a new eventSender method to do a full, completed force click,
2622         and it re-works all of the existing force methods to dispatch their events in
2623         such a way that they will trigger the NSImmediateAction gesture recognizer.
2624         To do this, first we need to send the events to the app rather than straight
2625         to the view, and also needed to tweak some state and send the events in a
2626         delayed fashion.
2627
2628         New public function mouseForceClick() and private helper functions to make
2629         NSEvents.
2630         * WebKitTestRunner/EventSenderProxy.h:
2631
2632         New public function mouseForceClick().
2633         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2634         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2635         (WTR::EventSendingController::mouseMoveTo):
2636         (WTR::EventSendingController::mouseForceClick):
2637         (WTR::EventSendingController::mouseForceDown):
2638         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2639         * WebKitTestRunner/TestController.cpp:
2640         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2641
2642         initPressureEventAtLocation needs to take a stageTransition and a window.
2643         * WebKitTestRunner/mac/EventSenderProxy.mm:
2644         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
2645         (-[EventSenderSyntheticEvent stageTransition]):
2646         (-[EventSenderSyntheticEvent timestamp]):
2647         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2648         (-[EventSenderSyntheticEvent window]):
2649
2650         In order to enter the gesture recognizer, we need to start with a mouse down
2651         that has a NSEventMaskPressure modifier.
2652         (WTR::EventSenderProxy::sendMouseDownToStartPressureEvents):
2653
2654         This ensures that the events queue properly for the force monitor in AppKit.
2655         (WTR::spinRunLoopForForce):
2656
2657          We need to start the pressure change events with a began.
2658         (WTR::EventSenderProxy::beginPressureEvent):
2659
2660         These functions can be used to create the NSEvent for a pressure change every
2661         time we need one.
2662         (WTR::EventSenderProxy::pressureChangeEvent):
2663
2664         Send the right series of events to emulate a full, completed force click.
2665         (WTR::EventSenderProxy::mouseForceClick):
2666
2667         Use all of the new things for these existing functions.
2668         (WTR::EventSenderProxy::mouseForceDown):
2669         (WTR::EventSenderProxy::mouseForceUp):
2670         (WTR::EventSenderProxy::mouseForceChanged):
2671
2672         Set NSFakeForceTouchDevice to YES.
2673         * WebKitTestRunner/mac/main.mm:
2674         (setDefaultsToConsistentValuesForTesting):
2675
2676 2015-09-04  Jason Marcell  <jmarcell@apple.com>
2677
2678         prepare-ChangeLog needs to know how to parse Swift files.
2679         https://bugs.webkit.org/show_bug.cgi?id=148784
2680         <rdar://problem/22510062>
2681
2682         Reviewed by Darin Adler.
2683
2684         * Scripts/prepare-ChangeLog:
2685         (get_function_line_ranges): Added entry for get_function_line_ranges_for_swift.
2686         (get_function_line_ranges_for_swift): Added function that knows how to parse Swift code.
2687         (parseSwiftFunctionArgs): Added function that knows how to parse Swift function arguments.
2688         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
2689         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests-expected.txt: Ditto.
2690         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/swift_unittests.swift: Ditto.
2691         (freeFunction): Ditto.
2692         (MyClass.function): Ditto.
2693         (MyClass.functionWithArgument(_:)): Ditto.
2694         (MyClass.functionWithMoreArguments(_:arg2:)): Ditto.
2695         (MyClass.functionWithNamedFirstArgument(argument:)): Ditto.
2696         (MyClass.functionWithNamedFirstAndSecondArgument(first:second:)): Ditto.
2697         (MyClass.classFunction): Ditto.
2698         (MyClass.readWriteComputedVariable): Ditto.
2699         (MyClass.readOnlyComputedVariable): Ditto.
2700
2701 2015-09-04  Ryosuke Niwa  <rniwa@webkit.org>
2702
2703         Import css/css-color-3
2704         https://bugs.webkit.org/show_bug.cgi?id=148803
2705
2706         Reviewed by Chris Dumez.
2707
2708         Fixed a bug that the imported reference files used the same extention as tests.
2709         This would result in parsing errors if the tests were XML and references were HTML and vice versa.
2710
2711         * Scripts/webkitpy/w3c/test_importer.py:
2712         (TestImporter.find_importable_tests):
2713
2714 2015-09-03  Commit Queue  <commit-queue@webkit.org>
2715
2716         Unreviewed, rolling out r189338.
2717         https://bugs.webkit.org/show_bug.cgi?id=148785
2718
2719         Caused tons of crashes (Requested by cdumez on #webkit).
2720
2721         Reverted changeset:
2722
2723         "Web Inspector: InspectorController should support multiple
2724         frontend channels"
2725         https://bugs.webkit.org/show_bug.cgi?id=148538
2726         http://trac.webkit.org/changeset/189338
2727
2728 2015-09-03  Brian Burg  <bburg@apple.com>
2729
2730         Web Inspector: InspectorController should support multiple frontend channels
2731         https://bugs.webkit.org/show_bug.cgi?id=148538
2732
2733         Reviewed by Joseph Pecoraro.
2734
2735         InspectorClients must explicitly disconnect their frontend channel(s) from the
2736         inspected page's InspectorController.
2737
2738         To make this possible, DumpRenderTree should not destroy non-primary views until
2739         it has tried to close any abandoned Web Inspector instances. Performing teardown
2740         in the reverse order prevents disconnection of the frontend channel because that
2741         prematurely destroys the inspector frontend client.
2742
2743         * DumpRenderTree/mac/DumpRenderTree.mm:
2744         (runTest):
2745         * DumpRenderTree/win/DumpRenderTree.cpp:
2746         (runTest):
2747
2748 2015-09-03  Timothy Hatcher  <timothy@apple.com>
2749
2750         Update WebKit nightly icon to be more like Safari
2751         https://bugs.webkit.org/show_bug.cgi?id=148768
2752
2753         Reviewed by Joseph Pecoraro.
2754
2755         * WebKitLauncher/webkit.icns:
2756
2757 2015-09-03  Geoffrey Garen  <ggaren@apple.com>
2758
2759         JavaScriptCore should have some ES6 conformance tests
2760         https://bugs.webkit.org/show_bug.cgi?id=148771
2761
2762         Reviewed by Chris Dumez.
2763
2764         * Scripts/run-javascriptcore-tests:
2765         (runJSCStressTests): Added es6 as a test suite.
2766
2767         * Scripts/run-jsc-stress-tests: Added es6 as a test suite.
2768
2769         Some of these tests currently fail, so I also added a way to expect
2770         failure for now. We'll migrate failing tests to expected passes as we
2771         fix them.
2772
2773 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2774
2775         Add a test for swipe-start hysteresis
2776         https://bugs.webkit.org/show_bug.cgi?id=148756
2777
2778         Reviewed by Anders Carlsson.
2779
2780         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2781         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2782         (WTR::cacheTestRunnerCallback):
2783         (WTR::TestRunner::clearTestRunnerCallbacks):
2784         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2785         Make sure that we log if a client tries to install a callback twice
2786         (since we use .add, the second call would not work).
2787
2788         Also, add clearTestRunnerCallbacks so tests can swap out installed
2789         callbacks.
2790
2791 2015-09-03  Anders Carlsson  <andersca@apple.com>
2792
2793         DumpRenderTree should automatically compute HTTP URLs for HTTP tests
2794         https://bugs.webkit.org/show_bug.cgi?id=148746
2795         rdar://problem/22568073
2796
2797         Reviewed by Tim Horton.
2798
2799         * DumpRenderTree/mac/DumpRenderTree.mm:
2800         (computeTestURL):
2801         Compute the test URL from the passed in path or URL. Special-case paths that contain /LayoutTests/http/tests.
2802
2803         (runTest):
2804         Call computeTestURL.
2805
2806         (testPathFromURL):
2807         Get rid of this; computeTestURL does this for us now.
2808
2809         * Scripts/webkitpy/port/driver.py:
2810         (Driver._command_from_driver_input):
2811         Don't convert HTTP test paths to URLS before passing them to DumpRenderTree on Mac. That's handled by DRT itself now.
2812
2813 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2814
2815         Swipe tests fail on Mavericks
2816         https://bugs.webkit.org/show_bug.cgi?id=148752
2817
2818         Reviewed by Beth Dakin.
2819
2820         * WebKitTestRunner/mac/EventSenderProxy.mm:
2821
2822 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2823
2824         Fix the 32-bit build
2825
2826         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2827         (WTR::PlatformWebView::setNavigationGesturesEnabled):
2828
2829 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2830
2831         Remove some logging that wasn't meant to be in the tree
2832
2833         * WebKitTestRunner/mac/EventSenderProxy.mm:
2834         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2835
2836 2015-09-03  Tim Horton  <timothy_horton@apple.com>
2837
2838         [Mac] Add support for testing swipes
2839         https://bugs.webkit.org/show_bug.cgi?id=148700
2840
2841         Reviewed by Beth Dakin.
2842
2843         * WebKitTestRunner/EventSenderProxy.h:
2844         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
2845         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2846         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2847         (WTR::cgEventPhaseFromString):
2848         (WTR::cgEventMomentumPhaseFromString):
2849         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2850         (WTR::EventSendingController::swipeGestureWithWheelAndMomentumPhases):
2851         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
2852         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2853         (WTR::InjectedBundle::didReceiveMessageToPage):
2854         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2855         (WTR::TestRunner::installDidBeginSwipeCallback):
2856         (WTR::TestRunner::installWillEndSwipeCallback):
2857         (WTR::TestRunner::installDidEndSwipeCallback):
2858         (WTR::TestRunner::installDidRemoveSwipeSnapshotCallback):
2859         (WTR::TestRunner::callDidBeginSwipeCallback):
2860         (WTR::TestRunner::callWillEndSwipeCallback):
2861         (WTR::TestRunner::callDidEndSwipeCallback):
2862         (WTR::TestRunner::callDidRemoveSwipeSnapshotCallback):
2863         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2864         * WebKitTestRunner/TestController.cpp:
2865         (WTR::TestController::createOtherPage):
2866         (WTR::TestController::createWebViewWithOptions):
2867         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2868         (WTR::TestController::didBeginNavigationGesture):
2869         (WTR::TestController::willEndNavigationGesture):
2870         (WTR::TestController::didEndNavigationGesture):
2871         (WTR::TestController::didRemoveNavigationGestureSnapshot):
2872         * WebKitTestRunner/TestController.h:
2873         * WebKitTestRunner/TestInvocation.cpp:
2874         (WTR::TestInvocation::didBeginSwipe):
2875         (WTR::TestInvocation::willEndSwipe):
2876         (WTR::TestInvocation::didEndSwipe):
2877         (WTR::TestInvocation::didRemoveSwipeSnapshot):
2878         * WebKitTestRunner/TestInvocation.h:
2879         Add callbacks when navigation gestures didBegin/willEnd/didEnd, and
2880         when the snapshot is removed.
2881
2882         Add swipeGestureWithWheelAndMomentumPhases, just like the equivalent
2883         mouseScrollBy function.
2884
2885         * WebKitTestRunner/mac/EventSenderProxy.mm:
2886         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
2887         (-[EventSenderSyntheticEvent type]):
2888         (-[EventSenderSyntheticEvent subtype]):
2889         (-[EventSenderSyntheticEvent locationInWindow]):
2890         (-[EventSenderSyntheticEvent location]):
2891         (-[EventSenderSyntheticEvent momentumPhase]):
2892         (-[EventSenderSyntheticEvent _isTouchesEnded]):
2893         (-[EventSenderSyntheticEvent _cgsEventRecord]):
2894         Rename EventSenderPressureEvent to EventSenderSyntheticEvent and add some
2895         more adjustable values.
2896
2897         (WTR::EventSenderProxy::mouseForceDown):
2898         (WTR::EventSenderProxy::mouseForceUp):
2899         (WTR::EventSenderProxy::mouseForceChanged):
2900         Adopt EventSenderSyntheticEvent.
2901
2902         (WTR::nsEventPhaseFromCGEventPhase):
2903         (WTR::EventSenderProxy::swipeGestureWithWheelAndMomentumPhases):
2904         Make use of EventSenderSyntheticEvent to synthesize swipe gesture events.
2905
2906         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2907         (WTR::PlatformWebView::PlatformWebView):
2908         Enable swipe.
2909
2910 2015-09-03  Myles C. Maxfield  <mmaxfield@apple.com>
2911
2912         [WK2] Allow tagging tests with metadata which needs to be known at web process creation time
2913         https://bugs.webkit.org/show_bug.cgi?id=148723
2914
2915         Reviewed by Anders Carlsson.
2916
2917         * WebKitTestRunner/TestController.cpp:
2918         (WTR::testPath):
2919         (WTR::updateViewOptionsFromTestHeader):
2920         (WTR::TestController::viewOptionsForTest):
2921
2922 2015-09-03  Lucas Forschler  <lforschler@apple.com>
2923
2924         Test commit.
2925
2926 2015-09-02  Tim Horton  <timothy_horton@apple.com>
2927
2928         Add a modern API way to know that the navigation gesture snapshot was removed, for WebKitTestRunner
2929         https://bugs.webkit.org/show_bug.cgi?id=148693
2930
2931         Reviewed by Anders Carlsson.
2932
2933         * WebKitTestRunner/TestController.cpp:
2934         (WTR::TestController::createOtherPage):
2935         (WTR::TestController::createWebViewWithOptions):
2936
2937 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2938
2939         REGRESSION(r188548): Some tests crash after r188548 because injected bundle messages are received after the test finishes
2940         https://bugs.webkit.org/show_bug.cgi?id=148529
2941
2942         Reviewed by Darin Adler.
2943
2944         When there are pending EventSender messages after a test finishes,
2945         they could be processed in the main loop started by the
2946         resetStateToConsistentValues(), but the old EventSender has been
2947         replaced by a new one at that point. The new Eventsender can crash
2948         when processing messages that were sent to the old one. To avoid
2949         this, we return early when receiving an EventSender message and
2950         the TestController state is not RunningTest.
2951
2952         * WebKitTestRunner/TestController.cpp:
2953         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
2954         (WTR::TestController::didReceiveMessageFromInjectedBundle):
2955
2956 2015-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2957
2958         REGRESSION(r188548): TestController state is Resseting while tests are running after r188548
2959         https://bugs.webkit.org/show_bug.cgi?id=148528
2960
2961         Reviewed by Darin Adler.
2962
2963         Before r188548 resetStateToConsistentValues() was called in
2964         TestController::run(), before tests are run, but now it's called
2965         for every test in TestInvocation::invoke(), after m_status has
2966         changed to RunningTest.
2967
2968         * WebKitTestRunner/TestController.cpp:
2969         (WTR::TestController::resetStateToConsistentValues): Use
2970         TemporaryChange to reset m_state ot its previous value after reset
2971         is done.
2972
2973 2015-08-31  Jason Marcell  <jmarcell@apple.com>
2974
2975         Modify prepare-Changelog to be aware of files that are marked as tests as well as files
2976         that are marked as requiring corresponding tests.
2977         https://bugs.webkit.org/show_bug.cgi?id=148498
2978         <rdar://problem/21555314>
2979
2980         Reviewed by Dan Bernstein and David Kilzer.
2981
2982         * Scripts/prepare-ChangeLog: Added "attributeCache" to cache Subversion properties in order to
2983         simulate Git's attribute behevaior.
2984         (main): Added "requiresTests" array to contain files that require tests.
2985         (generateNewChangeLogs): Checks "requiresTests" array to determine whether to inject "tests"
2986         section in ChangeLog.
2987         (attributeCommand): Queries a given file for a given Git attribute value. If using Subversion,
2988         however, we check if the file or any containing folder has the given property set to "1" and
2989         return 1 if so; return 0 otherwise.
2990         (generateFileList): Adds files to "requiresTests" array if Git attribute is set to "1". Also
2991         adds files to "addedRegressionTests" array if "test" attribute is set to "1".
2992
2993 2015-08-26  Andy Estes  <aestes@apple.com>
2994
2995         [Content Filtering] Determine navigation and content policy before continuing to filter a load
2996         https://bugs.webkit.org/show_bug.cgi?id=148506
2997
2998         Reviewed by Brady Eidson.
2999
3000         Added download API tests covering every decision and decision point.
3001         Removed _WKDownload.AsynchronousDownloadPolicy in favor of these new tests.
3002
3003         * TestWebKitAPI/Configurations/Base.xcconfig: Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to the header search path.
3004         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig: Removed it from here.
3005         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleParametersPlugIn.mm:
3006         (-[BundleParametersPlugIn observeValueForKeyPath:ofObject:change:context:]): Called -valueForKeyPath:, which
3007         returns an id, instead of -valueForKey:, which always returns an NSString even if the object is of another type.
3008         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm: Added a class that can send a MockContentFilter
3009         decision and decision point as a bundle parameter.
3010         (+[MockContentFilterEnabler supportsSecureCoding]):
3011         (-[MockContentFilterEnabler copyWithZone:]):
3012         (-[MockContentFilterEnabler initWithCoder:]):
3013         (-[MockContentFilterEnabler initWithDecision:decisionPoint:]):
3014         (-[MockContentFilterEnabler encodeWithCoder:]):
3015         (configurationWithContentFilterSettings): Added a helper function to create a WKWebViewConfiguration with MockConentFilter settings.
3016         (TEST): Renamed ContentFiltering.ServerRedirect to ContentFiltering.URLAfterServerRedirect.
3017         (-[BecomeDownloadDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Decided _WKNavigationResponsePolicyBecomeDownload.
3018         (-[BecomeDownloadDelegate webView:didFailProvisionalNavigation:withError:]): Set isDone to true.
3019         (-[BecomeDownloadDelegate webView:didFinishNavigation:]): Ditto.
3020         (-[ContentFilteringDownloadDelegate _downloadDidStart:]): Set downloadDidStart to true.
3021         (downloadTest): Added a helper function to test downloads with a given decision and decision point.
3022         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm: Added a corresponding bundle class that decodes
3023         the MockContentFilter decision and decision point, and sets these values in the MockContentFilterSettings
3024         singleton. This class is duplicated in the bundle to prevent TestWebKitAPI from having to link to WebCoreTestSupport.
3025         (+[MockContentFilterEnabler supportsSecureCoding]):
3026         (-[MockContentFilterEnabler copyWithZone:]):
3027         (-[MockContentFilterEnabler initWithCoder:]):
3028         (-[MockContentFilterEnabler dealloc]):
3029         (-[MockContentFilterEnabler encodeWithCoder:]):
3030         (-[ContentFilteringPlugIn webProcessPlugIn:initializeWithObject:]): Start observing changes to the MockContentFilterEnabler key path.
3031         (-[ContentFilteringPlugIn dealloc]): Stop observing.
3032         (-[ContentFilteringPlugIn observeValueForKeyPath:ofObject:change:context:]): Store a MockContentFilterEnabler in _contentFilterEnabler.
3033         (+[ServerRedirectPlugIn initialize]): Deleted.
3034         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3035         (-[AsynchronousDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3036         (-[AsynchronousDownloadDelegate _downloadDidStart:]): Deleted.
3037         (TEST): Deleted.
3038
3039 2015-08-31  Filip Pizlo  <fpizlo@apple.com>
3040
3041         Skip slow lock tests on Windows/debug
3042         https://bugs.webkit.org/show_bug.cgi?id=148643
3043
3044         Reviewed by Alexey Proskuryakov.
3045
3046         The lock tests simulate a critical section by doing some floating point math, and then either
3047         make those critical sections very long or invoke them many times. This appears to be
3048         particularly slow on Windows in debug mode, maybe because Visual Studio's debug build makes
3049         that kind of computation slow.
3050
3051         These tests are almost as useful in release as they are in debug, so it's probably better to
3052         just skip the in debug on platforms where this causes timeouts.
3053
3054         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3055         (TestWebKitAPI::runLockTest):
3056         (TestWebKitAPI::skipSlow):
3057         (TestWebKitAPI::TEST):
3058
3059 2015-08-29  Chris Fleizach  <cfleizach@apple.com>
3060
3061         AX: When navigating the elements of a scrollable element with VoiceOver, the scrollTop() position of the element does not permanently change
3062         https://bugs.webkit.org/show_bug.cgi?id=125720
3063
3064         Reviewed by Daniel Bates.
3065
3066         Add support for scrollToMakeVisibleWithSubFocus and scrollToGlobalPoint.
3067
3068         * DumpRenderTree/AccessibilityUIElement.cpp:
3069         (pressCallback):
3070         (scrollToMakeVisibleWithSubFocusCallback):
3071         (scrollToGlobalPointCallback):
3072         (scrollToMakeVisibleCallback):
3073         (AccessibilityUIElement::getJSClass):
3074         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3075         (AccessibilityUIElement::scrollToMakeVisible):
3076         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3077         (AccessibilityUIElement::scrollToGlobalPoint):
3078         (AccessibilityUIElement::selectedTextRange):
3079         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3080         (AccessibilityUIElement::AccessibilityUIElement):
3081         (AccessibilityUIElement::mathPrescriptsDescription):
3082         (AccessibilityUIElement::scrollToMakeVisible):
3083         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3084         (AccessibilityUIElement::scrollToGlobalPoint):
3085         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3086         (WTR::AccessibilityUIElement::isTextMarkerValid):
3087         (WTR::AccessibilityUIElement::textMarkerForIndex):
3088         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3089         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3090         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3091         (WTR::AccessibilityUIElement::supportedActions):
3092         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
3093         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3094         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3095         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3096         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3097         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3098         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3099         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3100         (WTR::AccessibilityUIElement::selectedTextRange):
3101         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3102         (WTR::AccessibilityUIElement::scrollToMakeVisible):
3103         (WTR::AccessibilityUIElement::scrollToGlobalPoint):
3104         (WTR::AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
3105         (WTR::AccessibilityUIElement::selectedTextRange):
3106
3107 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3108
3109         Add a mysteriously nonproblematic missing comma.
3110
3111         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3112         (TestExpectationParser._collect_matching_tests):
3113         (TestExpectationParser):
3114
3115 2015-08-28  Timothy Horton  <timothy_horton@apple.com>
3116
3117         Remove an old temporary script that has served its purpose
3118
3119         * Scripts/convert-test-expectations: Removed.
3120
3121 2015-08-28  Jer Noble  <jer.noble@apple.com>
3122
3123         [iOS] Add WebKit/WebKit2 settings to control automatic data loading
3124         https://bugs.webkit.org/show_bug.cgi?id=148579
3125
3126         Reviewed by Anders Carlsson.
3127
3128         In DumpRenderTree, set the new mediaDataLoadsAutomatically preference to YES.
3129
3130         In WebKitTestRunner, do the same for the new _mediaDataLoadsAutomatically configuration property,
3131         and also set the existing requiresUserActionForMediaPlayback configuration property to NO.
3132
3133         * DumpRenderTree/mac/DumpRenderTree.mm:
3134         (resetWebPreferencesToConsistentValues):
3135         (resetWebViewToConsistentStateBeforeTesting):
3136         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3137         (WTR::initializeWebViewConfiguration):
3138
3139 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3140
3141         Fix run-webkit-tests --additional-env-var="DYLD_INSERT_LIBRARIES=..."
3142         https://bugs.webkit.org/show_bug.cgi?id=148592
3143
3144         Reviewed by Tim Horton.
3145
3146         * Scripts/webkitpy/port/base.py:
3147         (Port.to.setup_environ_for_server):
3148         (Port.to):
3149         (Port.to._append_value_colon_separated):
3150         (Port.to.show_results_html_file):
3151         * Scripts/webkitpy/port/ios.py:
3152         (IOSSimulatorPort.setup_environ_for_server):
3153         * Scripts/webkitpy/port/mac.py:
3154         (MacPort.setup_environ_for_server):
3155
3156 2015-08-28  Filip Pizlo  <fpizlo@apple.com>
3157
3158         LICM should be sound even if the CFG has changed
3159         https://bugs.webkit.org/show_bug.cgi?id=148259
3160
3161         Reviewed by Benjamin Poulain.
3162
3163         Add a utility for creating tests that set some uncommon option.
3164
3165         * Scripts/run-jsc-stress-tests:
3166
3167 2015-08-28  Brent Fulgham  <bfulgham@apple.com>
3168
3169         [Win] Unreviewed EWS correction.
3170
3171         * EWSTools/start-queue-win.sh: Update settings to point to VS2015.
3172
3173 2015-08-28  Jer Noble  <jer.noble@apple.com>
3174
3175         [iOS] Make the AllowsInlineMediaPlayback preference work in WebKit / WebKit2.
3176         https://bugs.webkit.org/show_bug.cgi?id=147512
3177
3178         Reviewed by Anders Carlsson.
3179
3180         Set the value of WebKitAllowsInlineMediaPlayback / WKPreferencesSetMediaPlaybackAllowsInline()
3181         to a consistent (true) value.
3182
3183         * DumpRenderTree/mac/DumpRenderTree.mm:
3184         (setDefaultsToConsistentValuesForTesting):
3185         * WebKitTestRunner/TestController.cpp:
3186         (WTR::TestController::resetPreferencesToConsistentValues):
3187
3188 2015-08-28  Tim Horton  <timothy_horton@apple.com>
3189
3190         Add navigation gesture callbacks to WKPageNavigationClient
3191         https://bugs.webkit.org/show_bug.cgi?id=148568
3192         <rdar://problem/22371346>
3193
3194         Reviewed by Anders Carlsson.
3195
3196         * WebKitTestRunner/TestController.cpp:
3197         (WTR::TestController::createOtherPage):
3198         (WTR::TestController::createWebViewWithOptions):
3199         Add some zeroes.
3200
3201 2015-08-28  Alexey Proskuryakov  <ap@apple.com>
3202
3203         [Mac] kill-old-processes should kill more processes
3204         https://bugs.webkit.org/show_bug.cgi?id=148577
3205
3206         Reviewed by Tim Horton.
3207
3208         * BuildSlaveSupport/kill-old-processes:
3209
3210 2015-08-28  Jason Marcell  <jmarcell@apple.com>
3211
3212         The status message for combined builder queues should say "all builds succeeded" if everything
3213         built correctly.
3214         https://bugs.webkit.org/show_bug.cgi?id=148535
3215
3216         Reviewed by David Kilzer and Alexey Proskuryakov.
3217
3218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3219         (BuildbotCombinedQueueView.prototype.update): Make status message for combined builder queues
3220         say "all builds succeeded" if everything built correctly.
3221
3222 2015-08-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3223
3224         [GTK] Simplify the internal API to create a WebView
3225         https://bugs.webkit.org/show_bug.cgi?id=148570
3226
3227         Reviewed by Žan Doberšek.
3228
3229         * TestWebKitAPI/PlatformWebView.h: Add initialize method for GTK+ too.
3230         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3231         (TestWebKitAPI::PlatformWebView::PlatformWebView): Implement all
3232         PlatformWebView constructors that end up calling initialize with a PageConfiguration.
3233         (TestWebKitAPI::PlatformWebView::initialize): Create the WebView
3234         passing the received PageConfiguration.
3235         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3236         (WTR::PlatformWebView::PlatformWebView): Create the WebView
3237         passing the received PageConfiguration.
3238
3239 2015-08-27  Aakash Jain  <aakash_jain@apple.com>
3240
3241         iOS Simulator API tests fails as Simulator is not running
3242         https://bugs.webkit.org/show_bug.cgi?id=148501
3243         rdar://problem/22447525
3244
3245         Reviewed by Daniel Bates.
3246
3247         This change is a workaround for <rdar://problem/22388812>.
3248
3249          * Scripts/run-api-tests: Launch the iOS Simulator before starting the API Tests
3250          and quit it on program termination when running tests on the iOS port.
3251          * Scripts/webkitdirs.pm: Store string "For WebKit Development" in constant
3252          SIMULATOR_DEVICE_SUFFIX_FOR_WEBKIT_DEVELOPMENT to make it consistently reusable.
3253
3254 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3255
3256         Make DLLLauncherMain executables dependent on dll
3257         https://bugs.webkit.org/show_bug.cgi?id=148548
3258
3259         Reviewed by Brent Fulgham.
3260
3261         * DumpRenderTree/CMakeLists.txt:
3262         * DumpRenderTree/PlatformWin.cmake:
3263         * MiniBrowser/win/CMakeLists.txt:
3264         * TestWebKitAPI/CMakeLists.txt:
3265         * TestWebKitAPI/PlatformWin.cmake:
3266
3267 2015-08-27  Lucas Forschler  <lforschler@apple.com>
3268
3269         Remove Mac slaves 188/189 after being replaced with 400/401.
3270
3271         Unreviewed.
3272
3273         * BuildSlaveSupport/build.webkit.org-config/config.json:
3274
3275 2015-08-27  Lucas Forschler  <lforschler@apple.com>
3276
3277         Add two bots to the Mac Yosemite queue.
3278         This is to eventually replace bots188/189, which will be removed after 400/401 are vetted.
3279
3280         Unreviewed.
3281
3282         * BuildSlaveSupport/build.webkit.org-config/config.json:
3283
3284 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3285
3286         [Win CMake] Fix incremental build after r188673
3287         https://bugs.webkit.org/show_bug.cgi?id=148539
3288
3289         Reviewed by Brent Fulgham.
3290
3291         * TestWebKitAPI/PlatformWin.cmake:
3292         Copy forwarding headers from WebCore before building in case that was not yet done.
3293         It used to be done when running CMake, but now it's a build step.
3294
3295 2015-08-27  Nan Wang  <n_wang@apple.com>
3296
3297         AX: Fix accessibility/select-element-at-index.html test
3298         https://bugs.webkit.org/show_bug.cgi?id=148516
3299
3300         Reviewed by Chris Fleizach.
3301
3302         Implemented setSelectedChildAtIndex and removeSelectionAtIndex for mac.
3303
3304         * DumpRenderTree/AccessibilityUIElement.cpp:
3305         (setSelectedChildCallback):
3306         (setSelectedChildAtIndexCallback):
3307         (removeSelectionAtIndexCallback):
3308         (elementAtPointCallback):
3309         (sentenceAtOffsetCallback):
3310         (stringForSelectionCallback):
3311         (AccessibilityUIElement::getJSClass):
3312         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3313         (AccessibilityUIElement::setSelectedChild):
3314         (AccessibilityUIElement::setSelectedChildAtIndex):
3315         (AccessibilityUIElement::removeSelectionAtIndex):
3316         (AccessibilityUIElement::accessibilityValue):
3317         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3318         (WTR::AccessibilityUIElement::wordAtOffset):
3319         (WTR::AccessibilityUIElement::lineAtOffset):
3320         (WTR::AccessibilityUIElement::sentenceAtOffset):
3321         (WTR::AccessibilityUIElement::isSelectable):
3322         (WTR::AccessibilityUIElement::isMultiSelectable):
3323         (WTR::AccessibilityUIElement::setSelectedChild):
3324         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3325         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3326         (WTR::AccessibilityUIElement::selectedChildrenCount):
3327         (WTR::AccessibilityUIElement::selectedChildAtIndex):
3328         (WTR::AccessibilityUIElement::isExpanded):
3329         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3330         (WTR::AccessibilityUIElement::setSelectedChild):
3331         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
3332         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
3333         (WTR::AccessibilityUIElement::accessibilityValue):
3334
3335 2015-08-27  Alex Christensen  <achristensen@webkit.org>
3336
3337         Build fix after r188982
3338
3339         * MiniBrowser/win/CMakeLists.txt:
3340         The directory structure changed in the move.
3341
3342 2015-08-27  Michael Catanzaro  <mcatanzaro@igalia.com>
3343
3344         [GTK] Unreviewed, install-dependencies should install geoclue2 on Fedora
3345
3346         geoclue-devel is for obsolete geoclue. Install geoclue2-devel instead.
3347
3348         * gtk/install-dependencies:
3349
3350 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3351
3352         Unreviewed. Mark WTF_WordLock.ContendedShortSection as slow too.
3353
3354         * Scripts/run-gtk-tests:
3355         (TestRunner):
3356
3357 2015-08-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3358
3359         Fix GTK+ WTR crashes in initializeMainRunLoop()
3360
3361         Rubber-stamped by Žan Doberšek.
3362
3363         Initialize threading and main thread before
3364         RunLoop::initializeMainRunLoop(), since the GLib implementation of
3365         the RunLoop uses isMainThread() to decide whether to create a new
3366         GMainContext or use the default one. Also use RunLoop::run() and
3367         ::stop() instead of gtk_main/quit.
3368
3369         * WebKitTestRunner/TestController.cpp:
3370         (WTR::TestController::initialize):
3371         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3372         (WTR::TestController::notifyDone):
3373         (WTR::TestController::platformRunUntil):
3374
3375 2015-08-27  Filip Pizlo  <fpizlo@apple.com>
3376
3377         Unreviewed, further shorten a test that times out because it's very long
3378         running.
3379
3380         I've locally run these tests on repeat for 24 hours and found no genuine
3381         failures, like deadlocks. So, the timeouts are probably because the test
3382         machine is slow and debug is slow. We should just run this test for fewer
3383         iterations.
3384
3385         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3386         (TestWebKitAPI::TEST):
3387
3388 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3389
3390         Unreviewed build fix attempt on EFL
3391
3392         * WebKitTestRunner/PlatformEfl.cmake:
3393
3394 2015-08-26  Alex Christensen  <achristensen@webkit.org>
3395
3396         Build fix after r188982
3397
3398         * MiniBrowser/win/CMakeLists.txt:
3399         Find .rc files in correct directory.
3400
3401 2015-08-26  Ryuan Choi  <ryuan.choi@navercorp.com>
3402
3403         [EFL] Bump cairo version to 1.14.2
3404         https://bugs.webkit.org/show_bug.cgi?id=148474
3405
3406         Reviewed by Csaba Osztrogonác.
3407
3408         * efl/jhbuild.modules:
3409
3410 2015-08-26  Andy Estes  <aestes@apple.com>
3411
3412         Crash when following a Google search link to Twitter with Limit Adult Content enabled
3413         https://bugs.webkit.org/show_bug.cgi?id=147651
3414
3415         Rubber-stamped by Brady Eidson.
3416
3417         Taught TestRunner how to decide the navigation policy after a delay.
3418
3419         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3420         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3421         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
3422         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3423         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
3424         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3425         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
3426         * WebKitTestRunner/TestController.cpp:
3427         (WTR::TestController::initialize):
3428         (WTR::TestController::resetStateToConsistentValues):
3429         (WTR::TestController::decidePolicyForNavigationAction):
3430         * WebKitTestRunner/TestController.h:
3431         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
3432         * WebKitTestRunner/TestInvocation.cpp:
3433         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3434
3435 2015-08-26  Brent Fulgham  <bfulgham@apple.com>
3436
3437         [Win] Rename 'WinLauncher' to 'MiniBrowser'
3438         https://bugs.webkit.org/show_bug.cgi?id=148485
3439
3440         Reviewed by Alex Christensen
3441
3442         Move the WinLauncher project and source files to a subdirectory
3443         of MiniBrowser. Globally change WinLauncher -> MiniBrowser in the
3444         source code and project files.
3445
3446         * MiniBrowser/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj.
3447         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.ico.
3448         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.rc.
3449         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.
3450         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters.
3451         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCF.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCF.props.
3452         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCFLite.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCFLite.props.
3453         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props.
3454         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherDebug.props.
3455         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc.
3456         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.
3457         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.vcxproj.filters: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters.
3458         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibCommon.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibCommon.props.
3459         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibDebug.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibDebug.props.
3460         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd.
3461         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd.
3462         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props.
3463         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props.
3464         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h.
3465         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPostBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPostBuild.cmd.
3466         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserPreBuild.cmd: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherPreBuild.cmd.
3467         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserProduction.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props.
3468         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserRelease.props: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props.
3469         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Copied from WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h.
3470         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.ico: Removed.
3471         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.rc: Removed.
3472         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj: Removed.
3473         * MiniBrowser/MiniBrowser.vcxproj/WinLauncher.vcxproj.filters: Removed.
3474         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCF.props: Removed.
3475         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCFLite.props: Removed.
3476         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherCommon.props: Removed.
3477         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherDebug.props: Removed.
3478         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.rc: Removed.
3479         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj: Removed.
3480         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3481         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibCommon.props: Removed.
3482         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibDebug.props: Removed.
3483         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3484         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3485         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibProduction.props: Removed.
3486         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibRelease.props: Removed.
3487         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherLibResource.h: Removed.
3488         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPostBuild.cmd: Removed.
3489         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherPreBuild.cmd: Removed.
3490         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherProduction.props: Removed.
3491         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherRelease.props: Removed.
3492         * MiniBrowser/MiniBrowser.vcxproj/WinLauncherResource.h: Removed.
3493         * MiniBrowser/win: Copied from WinLauncher.
3494         * MiniBrowser/win/Common.cpp:
3495         * MiniBrowser/win/MiniBrowser.cpp: Copied from WinLauncher/WinLauncher.cpp.
3496         * MiniBrowser/win/MiniBrowser.h: Copied from WinLauncher/WinLauncher.h.
3497         * MiniBrowser/win/MiniBrowserReplace.h: Copied from WinLauncher/WinLauncherReplace.h.
3498         * MiniBrowser/win/MiniBrowserWebHost.cpp: Copied from WinLauncher/WinLauncherWebHost.cpp.
3499         * MiniBrowser/win/MiniBrowserWebHost.h: Copied from WinLauncher/WinLauncherWebHost.h.
3500         * MiniBrowser/win/PageLoadTestClient.cpp:
3501         * MiniBrowser/win/PageLoadTestClient.h:
3502         * MiniBrowser/win/ResourceLoadDelegate.cpp:
3503         * MiniBrowser/win/ResourceLoadDelegate.h:
3504         * MiniBrowser/win/WinLauncher.cpp: Removed.
3505         * MiniBrowser/win/WinLauncher.h: Removed.
3506         * MiniBrowser/win/WinLauncher.vcxproj: Removed.
3507         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3508         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3509         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3510         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.
3511         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCF.props: Removed.
3512         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCFLite.props: Removed.
3513         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherCommon.props: Removed.
3514         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherDebug.props: Removed.
3515         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.rc: Removed.
3516         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Removed.
3517         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Removed.
3518         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibCommon.props: Removed.
3519         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibDebug.props: Removed.
3520         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPostBuild.cmd: Removed.
3521         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibPreBuild.cmd: Removed.
3522         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibProduction.props: Removed.
3523         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibRelease.props: Removed.
3524         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherLibResource.h: Removed.
3525         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPostBuild.cmd: Removed.
3526         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherPreBuild.cmd: Removed.
3527         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherProduction.props: Removed.
3528         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherRelease.props: Removed.
3529         * MiniBrowser/win/WinLauncher.vcxproj/WinLauncherResource.h: Removed.
3530         * MiniBrowser/win/WinLauncher.vcxproj/small.ico: Removed.
3531         * MiniBrowser/win/WinLauncherReplace.h: Removed.
3532         * MiniBrowser/win/WinLauncherWebHost.cpp: Removed.
3533         * MiniBrowser/win/WinLauncherWebHost.h: Removed.
3534         * MiniBrowser/win/WinMain.cpp:
3535         * WinLauncher: Removed.
3536         * WinLauncher/AccessibilityDelegate.cpp: Removed.
3537         * WinLauncher/AccessibilityDelegate.h: Removed.
3538         * WinLauncher/CMakeLists.txt: Removed.
3539         * WinLauncher/Common.cpp: Removed.
3540         * WinLauncher/DOMDefaultImpl.cpp: Removed.
3541         * WinLauncher/DOMDefaultImpl.h: Removed.
3542         * WinLauncher/PageLoadTestClient.cpp: Removed.
3543         * WinLauncher/PageLoadTestClient.h: Removed.
3544         * WinLauncher/PrintWebUIDelegate.cpp: Removed.
3545         * WinLauncher/PrintWebUIDelegate.h: Removed.
3546         * WinLauncher/ResourceLoadDelegate.cpp: Removed.
3547         * WinLauncher/ResourceLoadDelegate.h: Removed.
3548         * WinLauncher/WebDownloadDelegate.cpp: Removed.
3549         * WinLauncher/WebDownloadDelegate.h: Removed.
3550         * WinLauncher/WinLauncher.cpp: Removed.
3551         * WinLauncher/WinLauncher.h: Removed.
3552         * WinLauncher/WinLauncher.vcxproj: Removed.
3553         * WinLauncher/WinLauncher.vcxproj/WinLauncher.ico: Removed.
3554         * WinLauncher/WinLauncher.vcxproj/WinLauncher.rc: Removed.
3555         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Removed.
3556         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Removed.