Implemented new API for RTCStatsReport object.
[WebKit-https.git] / Tools / ChangeLog
1 2013-03-08  Harald Alvestrand  <hta@chromium.org>
2
3         Implemented new API for RTCStatsReport object.
4         https://bugs.webkit.org/show_bug.cgi?id=110333
5
6         Reviewed by Adam Barth.
7
8         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
9         (WebTestRunner::MockWebRTCPeerConnectionHandler::getStats):
10
11 2013-03-08  Dirk Pranke  <dpranke@chromium.org>
12
13         [chromium] use custom freetype on linux asan builds again
14         https://bugs.webkit.org/show_bug.cgi?id=111884
15
16         Reviewed by Tony Chang.
17
18         We no longer need the workaround after chromium r186540.
19
20         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
21
22 2013-03-08  Ryosuke Niwa  <rniwa@webkit.org>
23
24         Warning about the user not having edit rights on Bugzilla is confusing new contributors
25         https://bugs.webkit.org/show_bug.cgi?id=111798
26
27         Reviewed by Dirk Pranke.
28
29         Don't scare people by the warning. Instead, tell them to ignore it if they don't have EditBugs privileges.
30
31         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
32
33 2013-03-08  James Robinson  <jamesr@chromium.org>
34
35         [chromium] Remove WebLayerTreeViewClient and WebLayerTreeView::Settings
36         https://bugs.webkit.org/show_bug.cgi?id=111632
37
38         Reviewed by Adrienne Walker.
39
40         * DumpRenderTree/chromium/WebViewHost.cpp:
41         (WebViewHost::initializeLayerTreeView):
42         * DumpRenderTree/chromium/WebViewHost.h:
43         (WebViewHost):
44
45 2013-03-08  Benjamin Poulain  <benjamin@webkit.org>
46
47         [Mac] Add a feature flag for 'view-mode' Media Feature, disable it on Mac
48         https://bugs.webkit.org/show_bug.cgi?id=111297
49
50         Reviewed by Kenneth Rohde Christiansen.
51
52         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
53         (WTR::TestRunner::setViewModeMediaFeature):
54
55 2013-03-08  Chris Fleizach  <cfleizach@apple.com>
56
57         [Mac] [WK2] platform/mac/accessibility/press-action-is-first.html fails
58         https://bugs.webkit.org/show_bug.cgi?id=111814
59
60         Reviewed by Ryosuke Niwa.
61
62         Add the needed supportedActions() attribute to WKTestRunner.
63
64         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
65         (WTR::AccessibilityUIElement::supportedActions):
66         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
67         (AccessibilityUIElement):
68         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
69         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
70         (WTR::AccessibilityUIElement::supportedActions):
71
72 2013-03-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
73
74         [EFL] Memory leak at WKViewClientWebProcessCallbacks API test
75         https://bugs.webkit.org/show_bug.cgi?id=111851
76
77         Reviewed by Kenneth Rohde Christiansen.
78
79         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
80         (TestWebKitAPI::TEST):
81
82             Fixed WKURLRef instance leaking.
83
84 2013-03-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
85
86         [EFL] [WK2] Some authentication tests fail in WebKit2
87         https://bugs.webkit.org/show_bug.cgi?id=106407
88
89         Reviewed by Kenneth Rohde Christiansen.
90
91         Add patch from upstream for libsoup 2.40 to fix several authentication
92         test cases.
93
94         * efl/jhbuild.modules:
95         * efl/patches/libsoup-2.40-auth-fix.patch: Added.
96
97 2013-03-08  Zan Dobersek  <zdobersek@igalia.com>
98
99         [GTK] Enable Web Audio in development builds
100         https://bugs.webkit.org/show_bug.cgi?id=111831
101
102         Reviewed by Philippe Normand.
103
104         Web Audio is already quite well supported on the GTK port but still has a few issues
105         that must be addressed before it is enabled by default. Despite that it should be enabled
106         in development builds just so we are up-to-date with future feature infrastructure changes.
107         The Web Audio-related layout tests are not run yet due to missing support in DRT/WKTR, but
108         that's an obvious goal before enabling the feature in release builds.
109
110         * Scripts/webkitperl/FeatureList.pm:
111
112 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
113
114         [chromium] delay clearing the TestRunners until the main view was deleted
115         https://bugs.webkit.org/show_bug.cgi?id=111823
116
117         Reviewed by Eric Seidel.
118
119         During WebViewHost::shutdown, we navigate the WebView to about:blank.
120         This may call into the test runners which assume that the delegate is
121         always non-NULL.
122
123         * DumpRenderTree/chromium/TestShell.cpp:
124         (TestShell::~TestShell):
125
126 2013-03-07  Alan Cutter  <alancutter@chromium.org>
127
128         Sheriffbot whois command can't search by full name
129         https://bugs.webkit.org/show_bug.cgi?id=111825
130
131         Reviewed by Eric Seidel.
132
133         Allowed multiple arguments to Sheriffbot's whois command.
134         Updated test expectations.
135
136         * Scripts/webkitpy/tool/bot/irc_command.py:
137         (Whois.execute):
138         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
139         (IRCCommandTest.test_whois):
140
141 2013-03-07  Nils Barth  <nbarth@chromium.org>
142
143         Add Nils Barth and Koji Hara to committers.py
144         https://bugs.webkit.org/show_bug.cgi?id=111806
145
146         Reviewed by Eric Seidel.
147
148         * Scripts/webkitpy/common/config/committers.py:
149
150 2013-03-07  Glenn Adams  <glenn@skynav.com>
151
152         run-pert-tests should have a --test-runner-count option
153         https://bugs.webkit.org/show_bug.cgi?id=111726
154
155         Reviewed by Ryosuke Niwa.
156
157         Add --test-runner-count option to run-perf-tests, with default value of 4.
158         This option allows command line configuration of the number of times to invoke
159         the test runner (serially, not in parallel) when running a specific test in
160         a test set.
161
162         * Scripts/webkitpy/performance_tests/perftest.py:
163         (PerfTest): Add DEFAULT_TEST_RUNNER_COUNT constant.
164         (PerfTest.__init__): Rename process_run_count to test_runner_count (throughout).
165         (PerfTest.run): Rename process_run_count to test_runner_count.
166         (SingleProcessPerfTest.__init__): Add test_runner_count optional argument.
167         (ChromiumStylePerfTest.__init__): Add test_runner_count optional argument.
168         (ReplayPerfTest.__init__): Add test_runner_count optional argument.
169         (PerfTestFactory.create_perf_test): Add test_runner_count optional argument.
170         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
171         (PerfTestsRunner._parse_args): Add '--test-runner-count' option.
172         (PerfTestsRunner._collect_tests): Use test_runner_count when creating PerfTest.
173         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
174         (MainTest._test_run_with_json_output): Add optional compare_logs argument.
175         (MainTest.test_run_with_repeat):
176         (MainTest.test_run_with_test_runner_count): Add new test for test-runner-count option semantics.
177         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
178         (MainTest.test_default_args): Add test for default option argument values.
179         (MainTest.test_parse_args): Add test for test-runner-count option parsing.
180
181 2013-03-07  Christian Biesinger  <cbiesinger@chromium.org>
182
183         Add myself to reviewers.py
184         https://bugs.webkit.org/show_bug.cgi?id=111757
185
186         Reviewed by Eric Seidel.
187
188         * Scripts/webkitpy/common/config/committers.py:
189
190 2013-03-07  Glenn Adams  <glenn@skynav.com>
191
192         run-perf-tests should have a --repeat option
193         https://bugs.webkit.org/show_bug.cgi?id=100030
194
195         Reviewed by Ryosuke Niwa.
196
197         Add --repeat option to run-perf-tests, with default value of 1. When greater
198         than 1, runs test set specified number of times. Note that multiple runs are
199         not aggregated for statistical purposes.
200
201         Incidentally fixed typo: s/suceeds/succeeds/.
202
203         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
204         (PerfTestsRunner._parse_args): Add repeat option.
205         (PerfTestsRunner.run): Add outer repeat loop.
206         (PerfTestsRunner._generate_results): Split from original _generate_and_show_results.
207         (PerfTestsRunner._upload_and_show_results): Split from original _generate_and_show_results.
208         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
209         (MainTest._test_run_with_json_output): Add repeat optional argument for generating expected logs. Fix typo.
210         (MainTest._test_run_with_json_output.mock_upload_json): Fix typo.
211         (MainTest.test_run_with_json_output): Fix typo.
212         (MainTest.test_run_with_description): Fix typo.
213         (MainTest.test_run_respects_no_results): Fix typo.
214         (MainTest.test_run_with_slave_config_json): Fix typo.
215         (MainTest.test_run_with_multiple_repositories): Fix typo.
216         (MainTest.test_run_with_upload_json): Fix typo.
217         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Fix typo.
218         (MainTest.test_run_with_repeat): Added new test for repeat count semantics.
219         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
220         (MainTest.test_parse_args): Add test for repeat option parsing.
221
222 2013-03-07  Julie Parent  <jparent@chromium.org>
223
224         showAllRuns checkbox no longer works on the stats dashboard
225         https://bugs.webkit.org/show_bug.cgi?id=111673
226
227         Reviewed by Ojan Vafai.
228
229         Stats dashboard does not have any DB_SPECIFIC_INVALIDATING_PARAMETERS,
230         so we were trying to index into an undefined object.
231         
232         * TestResultServer/static-dashboards/dashboard_base.js:
233         (invalidateQueryParameters):
234
235 2013-03-07  Mark Pilgrim  <pilgrim@chromium.org>
236
237         [Chromium] Update #include for WebStorageNamespace.h
238         https://bugs.webkit.org/show_bug.cgi?id=111748
239
240         Reviewed by Adam Barth.
241
242         In anticipation of removing
243         WK/chromium/public/WebStorageNamespace.h (once downstream
244         references have been updated)
245
246         * DumpRenderTree/chromium/WebViewHost.cpp:
247
248 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
249
250         run-perf-tests fails due to svn_revision not working on a pure git clone
251         https://bugs.webkit.org/show_bug.cgi?id=110839
252
253         Reviewed by Ryosuke Niwa.
254
255         Previously we would call git svn find-rev to look up the commit for
256         a given revision, and that'll hang in a pure git checkout.
257
258         This patch changes the way we look up svn revisions in a git
259         repository to use git log --grep 'git-svn-id', which is much faster
260         than grepping ourselves. It also renames timestamp_of_latest_commit()
261         to timestamp_of_revision() in order to accurately reflect what
262         the method is doing. Note that this patch only changes the logic
263         inside latest_revision() and svn_revision(). I'll file a separate
264         bug to change git_commit_from_svn_revision().
265
266         This patch also contains some fixes to unit tests that had bit-rotted
267         or were otherwise fragile, so that test-webkitpy --all would pass
268         cleanly, and a fix to outputcapture so that
269         test-webkitpy -p would work correctly again.
270
271         * Scripts/webkitpy/common/checkout/scm/git.py:
272         (Git.svn_revision):
273         (Git.timestamp_of_revision):
274         * Scripts/webkitpy/common/checkout/scm/scm.py:
275         (SCM.svn_revision):
276         (SCM.timestamp_of_revision):
277         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
278         (MockSCM.timestamp_of_revision):
279         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
280         (_shared_test_commit_with_message):
281         (test_commit_without_authorization):
282         (test_timestamp_of_revision):
283         * Scripts/webkitpy/common/checkout/scm/svn.py:
284         (SVN.timestamp_of_revision):
285         * Scripts/webkitpy/common/system/outputcapture.py:
286           Importing unittest2 directly may not be safe if this module is
287           imported before the autoinstaller gets a chance to set things up
288           properly. We don't actually need unittest2 here.
289         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
290         (PerfTestsRunner._generate_results_dict):
291
292 2013-03-07  Christophe Dumez  <ch.dumez@sisa.samsung.com>
293
294         [EFL] Bump libsoup dependency to 2.40.3 to fix regressions
295         https://bugs.webkit.org/show_bug.cgi?id=111756
296
297         Reviewed by Kenneth Rohde Christiansen.
298
299         Bump libsoup to v2.40.3 to fix the regressions introduced by
300         previous v2.40.0 bump.
301
302         * efl/jhbuild.modules:
303
304 2013-03-07  Roger Fong  <roger_fong@apple.com>
305
306         Re-enable Win EWS tests.
307
308         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
309         (WinEWS):
310
311 2013-03-07  Dirk Pranke  <dpranke@chromium.org>
312
313         [nrwt] handle corrupt http server pid files cleanly
314         https://bugs.webkit.org/show_bug.cgi?id=111628
315
316         Reviewed by Eric Seidel.
317
318         If the pid file from a previous http server is corrupt for some
319         reason, NRWT will just raise errors and not clean it up or recover.
320         This patch fixes that to at least delete the pid file and
321         not throw; not that we may still have stale http servers left on
322         the system, since there's no way to know which pid to kill if
323         the file was corrupted.
324
325         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
326         (HttpServerBase.start):
327         (HttpServerBase.stop):
328         (HttpServerBase._remove_pid_file):
329         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py: Added.
330         (TestHttpServerBase):
331         (TestHttpServerBase.test_corrupt_pid_file):
332
333 2013-03-07  Chris Fleizach  <cfleizach@apple.com>
334
335         AX: Can't activate links with VoiceOver in Safari
336         https://bugs.webkit.org/show_bug.cgi?id=111755
337
338         Reviewed by Tim Horton.
339
340         * DumpRenderTree/AccessibilityUIElement.cpp:
341         (supportedActionsCallback):
342         (AccessibilityUIElement::getJSClass):
343         * DumpRenderTree/AccessibilityUIElement.h:
344         (AccessibilityUIElement):
345         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
346         (AccessibilityUIElement::supportedActions):
347
348 2013-03-07  Roger Fong  <roger_fong@apple.com>
349
350         Windows debug layout tests are crashing like crazy again.
351         Disable tests on Win EWS bots temporarily.
352
353         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
354         (WinEWS):
355
356 2013-03-07  Roger Fong  <roger_fong@apple.com>
357
358         Make EWS bots build and test in release.
359
360         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
361         (WinEWS):
362         * Scripts/webkitpy/tool/steps/runtests.py:
363         (RunTests.run):
364
365 2013-03-07  Jochen Eisinger  <jochen@chromium.org>
366
367         [chromium] don't track the top loading frame if no layout test is currently running
368         https://bugs.webkit.org/show_bug.cgi?id=111716
369
370         Reviewed by Kentaro Hara.
371
372         In DRT, we synchronously stop the test and start loading the next test
373         URL. However, in content_shell, this happens asynchronously. It's
374         important that the top loading frame is not changed due to stray
375         navigation events before the next test starts.
376
377         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
378         (WebTestRunner::TestRunner::setTopLoadingFrame):
379
380 2013-03-06  Julie Parent  <jparent@chromium.org>
381
382         Dashboard cleanup: Move all dashboard ui related code into ui.js.
383         https://bugs.webkit.org/show_bug.cgi?id=111621
384
385         Reviewed by Ojan Vafai.
386         
387         Creates ui.js, a package for the common UI code the various
388         dashboards use. HTML generation is now in the ui.html namespace
389         and popup handling is in ui.popup.
390         Also moves the event listening for popups to ui.popup.show and
391         removes it on ui.popup.hid rather than having listener always
392         around.
393
394         * TestResultServer/static-dashboards/aggregate_results.html:
395         * TestResultServer/static-dashboards/dashboard_base.js:
396         * TestResultServer/static-dashboards/flakiness_dashboard.html:
397         * TestResultServer/static-dashboards/flakiness_dashboard.js:
398         (showPopupForBuild):
399         (htmlForNavBar):
400         (generatePageForIndividualTests.if):
401         (generatePageForIndividualTests):
402         * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js:
403         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
404         * TestResultServer/static-dashboards/run-embedded-unittests.html:
405         * TestResultServer/static-dashboards/run-unittests.html:
406         * TestResultServer/static-dashboards/timeline_explorer.html:
407         * TestResultServer/static-dashboards/treemap.html:
408         * TestResultServer/static-dashboards/ui.js: Added.
409         (.):
410
411 2013-03-06  Krzysztof Czech  <k.czech@samsung.com>
412
413         [EFL] Missing implementation of AccessibilityControllerEfl and AccessibilityUIElementEfl files
414         https://bugs.webkit.org/show_bug.cgi?id=110584
415
416         Reviewed by Gyuyoung Kim.
417
418         Adds missing implementation of AccessibilityControllerEfl
419         and AccessibilityUIElementEfl files. Modify DumpRenderTreeChrome
420         so that it can make accessibilityController as a js object.
421
422         * DumpRenderTree/AccessibilityController.h:
423         (AccessibilityController):
424         * DumpRenderTree/AccessibilityUIElement.h:
425         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
426         (AccessibilityController::childElementById): Moved declaration to base class.
427         Implementation can be shared among other ports.
428         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp: Copied from Tools/DumpRenderTree/gtk/AccessibilityControllerGtk.cpp.
429         (AccessibilityController::focusedElement):
430         (AccessibilityController::rootElement):
431         (AccessibilityController::accessibleElementById):
432         * DumpRenderTree/efl/AccessibilityUIElementEfl.cpp: Copied from Tools/DumpRenderTree/atk/AccessibilityControllerAtk.cpp.
433         (AccessibilityUIElement::helpText):
434         * DumpRenderTree/efl/CMakeLists.txt:
435         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
436         (DumpRenderTreeChrome::DumpRenderTreeChrome):
437         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
438         (DumpRenderTreeChrome::onWindowObjectCleared):
439         (DumpRenderTreeChrome::accessibilityController):
440         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
441         (DumpRenderTreeChrome):
442         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
443
444 2013-03-06  Benjamin Poulain  <benjamin@webkit.org>
445
446         WebKitTestRunner needs layoutTestController.elementDoesAutoCompleteForElementWithId
447         https://bugs.webkit.org/show_bug.cgi?id=42696
448
449         Reviewed by Andreas Kling.
450
451         * DumpRenderTree/TestRunner.cpp:
452         (TestRunner::staticFunctions):
453         * DumpRenderTree/TestRunner.h:
454         (TestRunner):
455         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
456         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
457         (WebTestRunner::TestRunner::TestRunner):
458         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
459         (TestRunner):
460         * DumpRenderTree/efl/TestRunnerEfl.cpp:
461         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
462         * DumpRenderTree/mac/TestRunnerMac.mm:
463         * DumpRenderTree/qt/TestRunnerQt.cpp:
464         * DumpRenderTree/qt/TestRunnerQt.h:
465         (TestRunnerQt):
466         * DumpRenderTree/win/TestRunnerWin.cpp:
467         * DumpRenderTree/wx/TestRunnerWx.cpp:
468
469 2013-03-06  Roger Fong  <roger_fong@apple.com>
470
471         Re-enable WinEWS test and decrease iterations before clean build back to 10.
472
473         * EWSTools/start-queue-win.sh:
474         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
475         (WinEWS):
476
477 2013-03-06  Manuel Rego Casasnovas  <rego@igalia.com>
478
479         [WK2][GTK] Fix unit test WebKit2APITests/WebKitWebView/mouse-target
480         https://bugs.webkit.org/show_bug.cgi?id=82866
481
482         Reviewed by Martin Robinson.
483
484         * Scripts/run-gtk-tests:
485         (TestRunner): Unflag WebKit2APITests/WebKitWebView/mouse-target test as
486         it is passing now.
487
488 2013-03-06  Julie Parent  <jparent@chromium.org>
489
490         Dashboard cleanup: remove dashboard time logging.
491         https://bugs.webkit.org/show_bug.cgi?id=111608
492
493         Reviewed by Dirk Pranke.
494
495         Remove logTime.  It was never accurate, and the dev tools
496         have better ways to measure this if anyone cares to look
497         into dashboard perf.
498         
499         * TestResultServer/static-dashboards/dashboard_base.js:
500         * TestResultServer/static-dashboards/flakiness_dashboard.js:
501         (processTestRunsForBuilder):
502         (appendHTML):
503
504 2013-03-06  Tony Chang  <tony@chromium.org>
505
506         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
507         https://bugs.webkit.org/show_bug.cgi?id=111509
508
509         Reviewed by Dirk Pranke.
510
511         Add DumpRenderTree.pak to DumpRenderTree.app again.
512
513         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
514
515 2013-03-06  Jochen Eisinger  <jochen@chromium.org>
516
517         [chromium] introduce WebUserGestureIndicator
518         https://bugs.webkit.org/show_bug.cgi?id=111531
519
520         Reviewed by Adam Barth.
521
522         * DumpRenderTree/chromium/WebViewHost.cpp:
523         (WebViewHost::createView):
524
525 2013-03-06  Alan Cutter  <alancutter@chromium.org>
526
527         sheriffbot roll-chromium-deps shouldn't create a bug with None as the new revision.
528         https://bugs.webkit.org/show_bug.cgi?id=73482
529
530         Reviewed by Ryosuke Niwa.
531
532         Added input checking to the UpdateChromiumDEPS step.
533         Removed the default use of LKGR when the revision input is invalid. "LKGR" must be explicitly given instead.
534
535         * Scripts/webkitpy/tool/bot/irc_command.py: Updated input validation and error message handling.
536         (RollChromiumDEPS):
537         (RollChromiumDEPS._parse_args):
538         (RollChromiumDEPS.execute):
539         * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Updated unit tests.
540         (IRCCommandTest.test_roll_chromium_deps):
541         * Scripts/webkitpy/tool/bot/ircbot_unittest.py: Updated unit tests.
542         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
543         * Scripts/webkitpy/tool/commands/roll_unittest.py: Updated unit tests.
544         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added input validation and added new error handling cases. Changed the logic of deciding to use LKGR to be only when the input is "LKGR".
545         (UpdateChromiumDEPS._fetch_last_known_good_revision):
546         (UpdateChromiumDEPS):
547         (UpdateChromiumDEPS._parse_revision_number):
548         (UpdateChromiumDEPS._validate_revisions):
549         (UpdateChromiumDEPS.run):
550         * Scripts/webkitpy/tool/steps/updatechromiumdeps_unittest.py: Added unit tests.
551         (UpdateChromiumDEPSTest):
552         (UpdateChromiumDEPSTest.test_parse_revision_number):
553         * Scripts/webkitpy/tool/commands/roll.py: Updated help text.
554         (RollChromiumDEPS):
555         (PostChromiumDEPSRoll):
556
557 2013-03-06  Andras Becsi  <andras.becsi@digia.com>
558
559         [Qt][MiniBrowser] Touch mocking broken for chained getures
560         https://bugs.webkit.org/show_bug.cgi?id=111430
561
562         Reviewed by Jocelyn Turcotte.
563
564         Make it possible again to use touch mocking to test gesture chains
565         like pan->pinch->pan->pinch without lifting the primary "finger".
566         For this to work we need to track the pressed mouse buttons and
567         only synthesize touch release events when the ctrl key is released
568         if no mouse button is pressed. Else the pressed mouse button(s)
569         should result in a stationary touch point in a touch update event.
570         Since it has been fixed in Qt 5.0.1 use QGuiApplication::keyboardModifiers()
571         to check for the state of the ctrl key modifier instead of getting
572         it from the mouse events.
573
574         * MiniBrowser/qt/MiniBrowserApplication.cpp:
575         (MiniBrowserApplication::MiniBrowserApplication):
576         (MiniBrowserApplication::notify):
577
578 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
579
580         [chromium] don't use custom freetype on linux asan for now
581         https://bugs.webkit.org/show_bug.cgi?id=111516
582
583         Unreviewed, build fix.
584
585         Turns out the custom lib is getting picked up by other binaries
586         on our bot, which is bad.
587
588         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
589
590 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
591
592         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
593         https://bugs.webkit.org/show_bug.cgi?id=111509
594
595         Unreviewed, build fix.
596
597         Actually comment out the flag :(.
598
599         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
600
601 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
602
603         [chromium] making DumpRenderTree_resources a separate bundle breaks xcode
604         https://bugs.webkit.org/show_bug.cgi?id=111509
605
606         Unreviewed, build fix.
607
608         r144863 appears to have broken the xcode build; I'm temporarily
609         trying this instead, and if this doesn't work, I'll revert the
610         other changes.
611
612         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
613
614 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
615
616         [chromium] build a DumpRenderTree.pak even on windows
617         https://bugs.webkit.org/show_bug.cgi?id=111504
618
619         Reviewed by Tony Chang.
620
621         The Chromium Aura build uses the default theme to draw
622         controls, and that theme requires the ui ResourceBundle
623         to be initialized. On every other platform, we build
624         a DumpRenderTree.pak that works for this, but on Windows we
625         still compile the resources directly into DRT. As a first step,
626         let's build the pak file. I will then need to land a patch
627         in Chromium to actually load it. Then I can go back and move
628         the resources over to just use the .pak file and no longer need
629         the .rc's.
630
631         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
632
633 2013-03-05  Julie Parent  <jparent@chromium.org>
634         Dashboard cleanup: move string utilities into their own namespace.
635         
636         https://bugs.webkit.org/show_bug.cgi?id=111485
637
638         Reviewed by Ojan Vafai.
639         
640         One of many pieces to clean up dashboard_base.
641         
642         Moves string utility functions into separate file (string.js) and into their own namespace rather than cluttering up the global scope.
643
644         * TestResultServer/static-dashboards/aggregate_results.html:
645         * TestResultServer/static-dashboards/dashboard_base.js:
646         (isTreeMap):
647         (isFlakinessDashboard):
648         * TestResultServer/static-dashboards/flakiness_dashboard.html:
649         * TestResultServer/static-dashboards/flakiness_dashboard.js:
650         (determineWKPlatform):
651         (chromiumPlatform):
652         (platformAndBuildType):
653         (substringList):
654         (individualTestsForSubstringList):
655         (filterBugs):
656         (populateExpectationsData):
657         (processMissingTestsWithExpectations):
658         (processMissingAndExtraExpectations):
659         (htmlForSingleTestRow):
660         (.dummyNode.onload):
661         (expectationsTitle):
662         * TestResultServer/static-dashboards/run-embedded-unittests.html:
663         * TestResultServer/static-dashboards/run-unittests.html:
664         * TestResultServer/static-dashboards/string.js: Added.
665         * TestResultServer/static-dashboards/timeline_explorer.html:
666         * TestResultServer/static-dashboards/treemap.html:
667
668 2013-03-05  Ryuan Choi  <ryuan.choi@samsung.com>
669
670         [EFL] Build break with latest EFL libraries
671         https://bugs.webkit.org/show_bug.cgi?id=111028
672
673         Reviewed by Dirk Pranke.
674
675         * MiniBrowser/efl/CMakeLists.txt: Added ECORE_XXX_INCLUDE_DIRS.
676         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
677         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
678
679 2013-03-05  Roger Fong  <roger_fong@apple.com>
680
681         Increase number of WinEWS iterations to 20.
682         Don't reboot after each iteration set.
683         Make EWS bots just build temporarily so that the queue catches up again.
684
685         * EWSTools/start-queue-win.sh:
686         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
687         (WinEWS):
688
689 2013-03-04  James Robinson  <jamesr@chromium.org>
690
691         [chromium] Move check for threaded compositing from WebCompositorSupport to Platform
692         https://bugs.webkit.org/show_bug.cgi?id=111386
693
694         Reviewed by Adrienne Walker.
695
696         * DumpRenderTree/chromium/TestShell.cpp:
697         (TestShell::initialize):
698
699 2013-03-05  Min Qin  <qinmin@chromium.org>
700
701         Copy dictionary to the external storage before running layout test on android
702         https://bugs.webkit.org/show_bug.cgi?id=111480
703
704         Reviewed by Adam Barth.
705
706         TestWebKitPlatformSupport now needs to read an external dictionary file.
707         This file does not exist on the device. We need to copy it before running layout tests.
708
709         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
710         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
711         (ChromiumAndroidDriver._push_platform_resources):
712
713 2013-03-05  Dirk Pranke  <dpranke@chromium.org>
714
715         [chromium] DRT crashes in an Aura/Win build
716         https://bugs.webkit.org/show_bug.cgi?id=111394
717
718         Reviewed by Tony Chang.
719
720         When building (and running) with use_aura=1, we assume that
721         we're using the default theme engine, but DRT creates the
722         DRTWin theme engine and overwrites the default, leading to crashes
723         in basically every test from the mismatch.
724
725         This fix gets us down to at least "lots of crashes" :).
726
727         * DumpRenderTree/chromium/TestShellWin.cpp:
728         (platformInit):
729
730 2013-03-05  Eric Seidel  <eric@webkit.org>
731
732         Add html-parser-threaded perf test now that the threaded parser is enabled by default
733         https://bugs.webkit.org/show_bug.cgi?id=111200
734
735         Reviewed by Ryosuke Niwa.
736
737         Had to teach run-perf-tests to ignore one more warning.
738
739         * Scripts/webkitpy/performance_tests/perftest.py:
740         (PerfTest):
741
742 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
743
744         Update list of builders for test results server
745         https://bugs.webkit.org/show_bug.cgi?id=111166
746
747         Reviewed by Ojan Vafai.
748
749         * TestResultServer/static-dashboards/builders.jsonp:
750
751 2013-03-05  Martin Robinson  <mrobinson@igalia.com> and Tomas Popela  <tpopela@redhat.com>
752
753         [GTK] Move basic dependency installation to a script
754         https://bugs.webkit.org/show_bug.cgi?id=110692
755
756         Reviewed by Gustavo Noronha Silva.
757
758         * gtk/install-dependencies: Added. A Script which installs all dependencies
759         necessary for building for Debian-based distributions and Fedora.
760
761 2013-03-05  James Robinson  <jamesr@chromium.org>
762
763         Chromium DumpRenderTree dumps a core every time it's run (Linux/Debug)
764         https://bugs.webkit.org/show_bug.cgi?id=111440
765
766         Reviewed by Adrienne Walker.
767
768         Remove unnecessary WebCompositorSupport::shutdown call
769
770         * DumpRenderTree/chromium/DumpRenderTree.cpp:
771         (main):
772
773 2013-03-05  Gustavo Noronha Silva  <gns@gnome.org>
774
775         Unreviewed build fix.
776
777         * GNUmakefile.am: add generate-feature-defines-files scripts to EXTRA_DIST.
778
779 2013-03-05  Andras Becsi  <andras.becsi@digia.com>
780
781         [Qt][MiniBrowser] Improve the update of touch indicators
782         https://bugs.webkit.org/show_bug.cgi?id=111429
783
784         Reviewed by Jocelyn Turcotte.
785
786         MiniBrowserApplication::sendTouchEvent sends an empty list
787         to BrowserWindow::updateVisualMockTouchPoints if the control
788         button is released, in which case the touch indicators should
789         be hidden so that we never end up with a leftover indicator
790         sticking on the screen.
791         This patch also simplifies the lookup of the indicator items by
792         replacing the findChild search in the item tree with a QHash
793         that stores the touch ID's and the pointers to the corresponding
794         indicator items.
795
796         * MiniBrowser/qt/BrowserWindow.cpp:
797         (BrowserWindow::updateVisualMockTouchPoints):
798         * MiniBrowser/qt/BrowserWindow.h:
799         (BrowserWindow):
800
801 2013-03-05  Tim Horton  <timothy_horton@apple.com>, Grzegorz Czajkowski  <g.czajkowski@samsung.com>
802
803         [WK2] WTR needs an implementation of setAsynchronousSpellCheckingEnabled
804         https://bugs.webkit.org/show_bug.cgi?id=81042
805
806         Reviewed by Enrica Casucci.
807
808         Add setAsynchronousSpellCheckingEnabled implementation for
809         WebKitTestRunner to have the possibility to test asynchronous
810         spell checking implementation from bug 109577.
811
812         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
813         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
814         (WTR::TestRunner::setAsynchronousSpellCheckingEnabled):
815         * WebKitTestRunner/InjectedBundle/TestRunner.h:
816         * WebKitTestRunner/TestController.cpp:
817         (WTR::TestController::resetStateToConsistentValues):
818
819 2013-03-05  Tommy Widenflycht  <tommyw@google.com>
820
821         MediaStream API: Add the getStreamById method on RTCPeerConnection
822         https://bugs.webkit.org/show_bug.cgi?id=111311
823
824         Reviewed by Adam Barth.
825
826         Changing mocks to be more realistic.
827
828         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp:
829         (WebTestRunner::MockWebRTCPeerConnectionHandler::addStream):
830         (WebTestRunner::MockWebRTCPeerConnectionHandler::removeStream):
831         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp:
832         (WebTestRunner::WebUserMediaClientMock::requestUserMedia):
833
834 2013-03-05  Jochen Eisinger  <jochen@chromium.org>
835
836         Add content shell bots to garden-o-matic for general failurse
837         https://bugs.webkit.org/show_bug.cgi?id=111168
838
839         Reviewed by Adam Barth.
840
841         All but the WebKit (Content Shell) Android bot is stable enough. While
842         they're not green yet, there must not be any non-layout test failures on
843         them.
844
845         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
846         (.):
847
848 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
849
850         [chromium] remove deprecated WebTestRunner::setFocus API
851         https://bugs.webkit.org/show_bug.cgi?id=111354
852
853         Reviewed by James Robinson.
854
855         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
856         (WebTestDelegate):
857
858 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
859
860         Run the bindings generation tests on EWS and CQ bots
861         https://bugs.webkit.org/show_bug.cgi?id=111358
862
863         Reviewed by Adam Barth.
864
865         The tests are super fast and not flaky.
866
867         * Scripts/webkitpy/common/config/ports.py:
868         (DeprecatedPort.run_bindings_tests_command):
869         * Scripts/webkitpy/common/config/ports_mock.py:
870         (MockPort.run_webkit_tests_command):
871         (MockPort):
872         (MockPort.run_bindings_tests_command):
873         * Scripts/webkitpy/tool/commands/download_unittest.py:
874         * Scripts/webkitpy/tool/steps/runtests.py:
875         (RunTests.run):
876         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
877         (RunTestsTest.test_webkit_run_unit_tests):
878         * Scripts/webkitpy/tool/steps/steps_unittest.py:
879
880 2013-03-04  Eric Seidel  <eric@webkit.org>
881
882         run-webkit-tests should support --profile and --profiler= just like run-perf-tests does
883         https://bugs.webkit.org/show_bug.cgi?id=111384
884
885         Reviewed by Ryosuke Niwa.
886
887         Sometimes I want to know why various LayoutTests are slow
888         without having to convert them into PerformanceTests in order
889         to use our fancy profiling.  The Driver already knows how to
890         do the right thing, we just need to expose the options to the user.
891
892         Handling of these options is already unittested in the perftests_unittest.
893
894         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
895         (parse_args):
896
897 2013-03-04  Alan Cutter  <alancutter@chromium.org>
898
899         check-webkit-style says "Have to enable auto props in the subversion config file"
900         https://bugs.webkit.org/show_bug.cgi?id=107724
901
902         Reviewed by Tony Chang.
903
904         Added a standard svn config file for WebKit developers to use.
905         Updated the style and commit queue bot build scripts to load this file.
906
907         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
908         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
909         * EWSTools/configure-svn-config.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
910         * svn-config: Added.
911
912 2013-03-04  James Robinson  <jamesr@chromium.org>
913
914         [chromium] Switch to new webkit_support::CreateLayerTreeView interface
915         https://bugs.webkit.org/show_bug.cgi?id=111285
916
917         Reviewed by Adrienne Walker.
918
919         This removes the need for WebCompositorSupport::initialize and exposes
920         slightly fewer entry points across the repository boundary.
921
922         * DumpRenderTree/chromium/TestShell.cpp:
923         (TestShell::initialize):
924         * DumpRenderTree/chromium/TestShell.h:
925         (TestShell::webCompositorThread):
926         (TestShell):
927         * DumpRenderTree/chromium/WebViewHost.cpp:
928         (WebViewHost::initializeLayerTreeView):
929
930 2013-03-04  Roger Fong  <roger_fong@apple.com>
931
932         Unreviewed. Get rid of some AppleWin VS2010 build warnings.
933
934         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
935
936 2013-03-04  David Kilzer  <ddkilzer@apple.com>
937
938         BUILD FIX (r144657): Fix DumpRenderTree build failure on iOS
939
940             Tools/DumpRenderTree/ios/AccessibilityControllerIOS.mm:95:29: error: class method '+stringWithJSStringRef:' not found (return type defaults to 'id') [-Werror,-Wobjc-method-access]
941                 NSString *idAttribute = [NSString stringWithJSStringRef:idAttributeRef];
942                                         ^         ~~~~~~~~~~~~~~~~~~~~~
943             1 error generated.
944
945         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Import
946         AccessibilityCommonMac.h.
947
948 2013-03-04  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
949
950         [WK2][EFL] Add callbacks to the WKViewClient to handle Web Process crash and relaunch
951         https://bugs.webkit.org/show_bug.cgi?id=109828
952
953         Reviewed by Kenneth Rohde Christiansen.
954
955         Added API test for newly added Web Process crash and Web Process relaunch WKViewClient
956         callbacks.
957
958         * TestWebKitAPI/CMakeLists.txt:
959
960             Tests located in 'TestWebKitAPI/Tests/WebKit2' subdirectories are also
961             considered.
962
963         * TestWebKitAPI/PlatformEfl.cmake:
964         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp: Added.
965         (TestWebKitAPI):
966         (TestWebKitAPI::didFinishLoadForFrame):
967         (TestWebKitAPI::setPageLoaderClient):
968         (TestWebKitAPI::webProcessCrashed):
969         (TestWebKitAPI::webProcessDidRelaunch):
970         (TestWebKitAPI::setViewClient):
971         (TestWebKitAPI::TEST):
972
973 2013-03-04  Chris Fleizach  <cfleizach@apple.com>
974
975         AX: Upstream iOS Accessibility DumpRenderTree changes
976         https://bugs.webkit.org/show_bug.cgi?id=111220
977
978         Reviewed by David Kilzer.
979
980         Upstream the iOS changes for accessibility in DumpRenderTree.
981
982         * DumpRenderTree/AccessibilityUIElement.cpp:
983         (headerElementAtIndexCallback):
984         (linkedElementCallback):
985         (elementsForRangeCallback):
986         (increaseTextSelectionCallback):
987         (decreaseTextSelectionCallback):
988         (assistiveTechnologySimulatedFocusCallback):
989         (stringForSelectionCallback):
990         (getIPhoneLabelCallback):
991         (getIPhoneHintCallback):
992         (getIPhoneValueCallback):
993         (getIPhoneIdentifierCallback):
994         (getIPhoneTraitsCallback):
995         (getIPhoneIsElementCallback):
996         (getIPhoneElementTextPositionCallback):
997         (getIPhoneElementTextLengthCallback):
998         (AccessibilityUIElement::getJSClass):
999         * DumpRenderTree/AccessibilityUIElement.h:
1000         (AccessibilityUIElement):
1001         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1002         * DumpRenderTree/ios: Added.
1003         * DumpRenderTree/ios/AccessibilityControllerIOS.mm: Added.
1004         (AccessibilityController::AccessibilityController):
1005         (AccessibilityController::~AccessibilityController):
1006         (AccessibilityController::elementAtPoint):
1007         (AccessibilityController::focusedElement):
1008         (AccessibilityController::rootElement):
1009         (findAccessibleObjectById):
1010         (AccessibilityController::accessibleElementById):
1011         (AccessibilityController::setLogFocusEvents):
1012         (AccessibilityController::setLogScrollingStartEvents):
1013         (AccessibilityController::setLogValueChangeEvents):
1014         (AccessibilityController::setLogAccessibilityEvents):
1015         (AccessibilityController::addNotificationListener):
1016         (AccessibilityController::removeNotificationListener):
1017         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added.
1018         (AccessibilityUIElement::AccessibilityUIElement):
1019         (AccessibilityUIElement::~AccessibilityUIElement):
1020         (concatenateAttributeAndValue):
1021         (AccessibilityUIElement::iphoneLabel):
1022         (AccessibilityUIElement::iphoneHint):
1023         (AccessibilityUIElement::iphoneValue):
1024         (AccessibilityUIElement::iphoneIdentifier):
1025         (AccessibilityUIElement::iphoneTraits):
1026         (AccessibilityUIElement::iphoneIsElement):
1027         (AccessibilityUIElement::iphoneElementTextPosition):
1028         (AccessibilityUIElement::iphoneElementTextLength):
1029         (AccessibilityUIElement::url):
1030         (AccessibilityUIElement::x):
1031         (AccessibilityUIElement::y):
1032         (AccessibilityUIElement::width):
1033         (AccessibilityUIElement::height):
1034         (AccessibilityUIElement::clickPointX):
1035         (AccessibilityUIElement::clickPointY):
1036         (AccessibilityUIElement::getChildren):
1037         (AccessibilityUIElement::getChildrenWithRange):
1038         (AccessibilityUIElement::childrenCount):
1039         (AccessibilityUIElement::elementAtPoint):
1040         (AccessibilityUIElement::indexOfChild):
1041         (AccessibilityUIElement::getChildAtIndex):
1042         (AccessibilityUIElement::headerElementAtIndex):
1043         (AccessibilityUIElement::linkedElement):
1044         (AccessibilityUIElement::linkedUIElementAtIndex):
1045         (AccessibilityUIElement::ariaOwnsElementAtIndex):
1046         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1047         (AccessibilityUIElement::disclosedRowAtIndex):
1048         (AccessibilityUIElement::selectedRowAtIndex):
1049         (AccessibilityUIElement::rowAtIndex):
1050         (AccessibilityUIElement::titleUIElement):
1051         (AccessibilityUIElement::parentElement):
1052         (AccessibilityUIElement::disclosedByRow):
1053         (AccessibilityUIElement::increaseTextSelection):
1054         (AccessibilityUIElement::decreaseTextSelection):
1055         (AccessibilityUIElement::stringForSelection):
1056         (AccessibilityUIElement::stringForRange):
1057         (AccessibilityUIElement::attributedStringForRange):
1058         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1059         (AccessibilityUIElement::elementsForRange):
1060         (AccessibilityUIElement::getLinkedUIElements):
1061         (AccessibilityUIElement::getDocumentLinks):
1062         (AccessibilityUIElement::attributesOfLinkedUIElements):
1063         (AccessibilityUIElement::attributesOfDocumentLinks):
1064         (AccessibilityUIElement::attributesOfChildren):
1065         (AccessibilityUIElement::allAttributes):
1066         (AccessibilityUIElement::stringAttributeValue):
1067         (AccessibilityUIElement::isPressActionSupported):
1068         (AccessibilityUIElement::isIncrementActionSupported):
1069         (AccessibilityUIElement::isDecrementActionSupported):
1070         (AccessibilityUIElement::boolAttributeValue):
1071         (AccessibilityUIElement::isAttributeSettable):
1072         (AccessibilityUIElement::isAttributeSupported):
1073         (AccessibilityUIElement::parameterizedAttributeNames):
1074         (AccessibilityUIElement::role):
1075         (AccessibilityUIElement::subrole):
1076         (AccessibilityUIElement::roleDescription):
1077         (AccessibilityUIElement::title):
1078         (AccessibilityUIElement::description):
1079         (AccessibilityUIElement::orientation):
1080         (AccessibilityUIElement::stringValue):
1081         (AccessibilityUIElement::language):
1082         (AccessibilityUIElement::helpText):
1083         (AccessibilityUIElement::intValue):
1084         (AccessibilityUIElement::minValue):
1085         (AccessibilityUIElement::maxValue):
1086         (AccessibilityUIElement::valueDescription):
1087         (AccessibilityUIElement::insertionPointLineNumber):
1088         (AccessibilityUIElement::isEnabled):
1089         (AccessibilityUIElement::isRequired):
1090         (AccessibilityUIElement::isFocused):
1091         (AccessibilityUIElement::isSelected):
1092         (AccessibilityUIElement::isExpanded):
1093         (AccessibilityUIElement::isChecked):
1094         (AccessibilityUIElement::hierarchicalLevel):
1095         (AccessibilityUIElement::ariaIsGrabbed):
1096         (AccessibilityUIElement::ariaDropEffects):
1097         (AccessibilityUIElement::lineForIndex):
1098         (AccessibilityUIElement::boundsForRange):
1099         (AccessibilityUIElement::attributesOfColumnHeaders):
1100         (AccessibilityUIElement::attributesOfRowHeaders):
1101         (AccessibilityUIElement::attributesOfColumns):
1102         (AccessibilityUIElement::attributesOfRows):
1103         (AccessibilityUIElement::attributesOfVisibleCells):
1104         (AccessibilityUIElement::attributesOfHeader):
1105         (AccessibilityUIElement::rowCount):
1106         (AccessibilityUIElement::columnCount):
1107         (AccessibilityUIElement::indexInTable):
1108         (AccessibilityUIElement::rowIndexRange):
1109         (AccessibilityUIElement::columnIndexRange):
1110         (AccessibilityUIElement::cellForColumnAndRow):
1111         (AccessibilityUIElement::selectedTextRange):
1112         (AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1113         (AccessibilityUIElement::setSelectedTextRange):
1114         (AccessibilityUIElement::increment):
1115         (AccessibilityUIElement::decrement):
1116         (AccessibilityUIElement::showMenu):
1117         (AccessibilityUIElement::press):
1118         (AccessibilityUIElement::accessibilityValue):
1119         (AccessibilityUIElement::documentEncoding):
1120         (AccessibilityUIElement::documentURI):
1121         (_accessibilityNotificationCallback):
1122         (AccessibilityUIElement::addNotificationListener):
1123         (AccessibilityUIElement::removeNotificationListener):
1124         (AccessibilityUIElement::isFocusable):
1125         (AccessibilityUIElement::isSelectable):
1126         (AccessibilityUIElement::isMultiSelectable):
1127         (AccessibilityUIElement::isSelectedOptionActive):
1128         (AccessibilityUIElement::isVisible):
1129         (AccessibilityUIElement::isOffScreen):
1130         (AccessibilityUIElement::isCollapsed):
1131         (AccessibilityUIElement::isIgnored):
1132         (AccessibilityUIElement::hasPopup):
1133         (AccessibilityUIElement::takeFocus):
1134         (AccessibilityUIElement::takeSelection):
1135         (AccessibilityUIElement::addSelection):
1136         (AccessibilityUIElement::removeSelection):
1137         (AccessibilityUIElement::uiElementForSearchPredicate):
1138         (AccessibilityUIElement::numberAttributeValue):
1139
1140 2013-03-04  Jochen Eisinger  <jochen@chromium.org>
1141
1142         [chromium] pass all focus handling methods through the WebTestDelegate
1143         https://bugs.webkit.org/show_bug.cgi?id=111328
1144
1145         Reviewed by Nico Weber.
1146
1147         In content_shell, the focus handling is asynchronous. To allow for
1148         switching the focus synchronously between WebViews, we need to intercept
1149         didFocus and didBlur and forward it to the WebTestDelegate.
1150
1151         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
1152         (WebTestDelegate):
1153         (WebTestRunner::WebTestDelegate::setFocus):
1154         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1155         (WebTestRunner::WebTestProxy::didFocus):
1156         (WebTestRunner::WebTestProxy::didBlur):
1157         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1158         (WebTestRunner::TestRunner::setWindowIsKey):
1159         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1160         (WebTestRunner::WebTestProxyBase::didFocus):
1161         (WebTestRunner):
1162         (WebTestRunner::WebTestProxyBase::didBlur):
1163         * DumpRenderTree/chromium/WebViewHost.cpp:
1164         (WebViewHost::didFocus):
1165         (WebViewHost::didBlur):
1166         (WebViewHost::setFocus):
1167         * DumpRenderTree/chromium/WebViewHost.h:
1168         (WebViewHost):
1169
1170 2013-03-04  Claudio Saavedra  <csaavedra@igalia.com>
1171
1172         [GTK] No need to manually add system paths to jhbuildrc
1173         https://bugs.webkit.org/show_bug.cgi?id=110850
1174
1175         Reviewed by Gustavo Noronha Silva.
1176
1177         * gtk/jhbuildrc: Remove calls to addpath() for items that jhbuild
1178         already takes care of.
1179
1180 2013-03-04  Kinuko Yasuda  <kinuko@chromium.org>
1181
1182         [chromium] TestWebKitAPI WTF.StringHasher_addCharacters is broken on Chromium Android
1183         https://bugs.webkit.org/show_bug.cgi?id=111284
1184
1185         Disabling the failing two tests on Android.
1186
1187         Reviewed by Jochen Eisinger.
1188
1189         * TestWebKitAPI/Tests/WTF/StringHasher.cpp:
1190         (TestWebKitAPI):
1191         (TestWebKitAPI::TEST):
1192
1193 2013-03-04  Kunihiko Sakamoto  <ksakamoto@chromium.org>
1194
1195         Add build flag for FontLoader
1196         https://bugs.webkit.org/show_bug.cgi?id=111289
1197
1198         Reviewed by Benjamin Poulain.
1199
1200         Add ENABLE_FONT_LOAD_EVENTS build flag (disabled by default).
1201
1202         * Scripts/webkitperl/FeatureList.pm:
1203         * qmake/mkspecs/features/features.pri:
1204
1205 2013-03-03  Benjamin Poulain  <benjamin@webkit.org>
1206
1207         [Mac] Get rid of a useless method from DOMHTMLInputElement
1208         https://bugs.webkit.org/show_bug.cgi?id=111279
1209
1210         Reviewed by Sam Weinig.
1211
1212         * DumpRenderTree/mac/TestRunnerMac.mm:
1213         (TestRunner::setValueForUser):
1214         The method _setValueForUser: was added for testing. This feature is already
1215         exposed by DOMHTMLInputElement as a private API and it is how this code is exercised
1216         in real use cases. Get rid of the method created for testing, use the real thing
1217         instead.
1218
1219 2013-03-03  Ryosuke Niwa  <rniwa@webkit.org>
1220
1221         Some perf. tests have variances that differ greatly between runs
1222         https://bugs.webkit.org/show_bug.cgi?id=97510
1223
1224         Reviewed by Benjamin Poulain.
1225
1226         Use multiple instances of DumpRenderTree or WebKitTestRunner to amortize the effect of the runtime
1227         environment on test results (we run each instance after one another, not in parallel).
1228
1229         We use 4 instances of the test runner, each executing 5 in-process iterations, for the total of 20
1230         iterations as it was done previously in single process. These values are hard-coded in perftest.py
1231         and runner.js but they are to be configurable in the future.
1232
1233         Set of 5 iterations obtained by the same test runner is treated as an "iteration group" and each
1234         metric now reports an array of the length 4 with each element containing an array of 5 iteration
1235         values obtained by each test runner instance as opposed to a flattened array of 20 iteration values.
1236
1237         Unfortunately, we can use the same trick on Dromaeo because we're already doing only 5 iterations
1238         and repeating the entire Dromaeo 4 times will take too long. We need to disable more Dromaeo tests
1239         as needed. To this end, added SingleProcessPerfTest to preserve the old behavior.
1240
1241         * Scripts/webkitpy/performance_tests/perftest.py:
1242         (PerfTestMetric.append_group): Renamed from append.
1243         (PerfTestMetric.grouped_iteration_values): Added.
1244         (PerfTestMetric.flattened_iteration_values): Renamed from iteration_values.
1245
1246         (PerfTest.__init__): Takes the number of processes (drivers) to run tests with.
1247         This parameter is only used by SingleProcessPerfTest.
1248
1249         (PerfTest.run): Repeat tests using different driver processes.
1250         (PerfTest._run_with_driver): Returns a boolean instead of a list of measured metrics
1251         since metrics are shared between multiple drivers (i.e. multiple calls to _run_with_driver).
1252         We instead use _ensure_metrics to obtain the matched metrics and store the data there.
1253         (PerfTest._ensure_metrics): Added.
1254
1255         (SingleProcessPerfTest): Added. Used to run Dromaeo tests where running it on 4 different
1256         instances of DumpRenderTree/WebKitTestRunner takes too long.
1257         (SingleProcessPerfTest.__init__):
1258
1259         (ReplayPerfTest._run_with_driver): Updated to use _ensure_metrics.
1260
1261         (PerfTestFactory): Use SingleProcessPerfTest to run Dromaeo tests.
1262
1263         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated various tests that expect
1264         _run_with_driver to return a list of metrics. Now it returns a boolean indicating whether
1265         the test succeeded or not. Obtain the dictionary of metrics via test._metrics instead.
1266
1267         (TestPerfTestMetric.test_append): Updated per name and added some test cases for
1268         grouped_iteration_values.
1269
1270         (TestPerfTest._assert_results_are_correct):
1271
1272         (TestSingleProcessPerfTest): Added.
1273         (TestSingleProcessPerfTest.test_use_only_one_process):
1274         (TestSingleProcessPerfTest.test_use_only_one_process.run_single):
1275
1276         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1277         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1278
1279         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Updated values of
1280         sample standard deviations since we're now running tests 4 times.
1281         (MainTest._test_run_with_json_output.mock_upload_json):
1282         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
1283
1284 2013-03-03  Alexandre Elias  <aelias@chromium.org>
1285
1286         [chromium] Remove WebLayerTreeView::setViewportSize call
1287         https://bugs.webkit.org/show_bug.cgi?id=110727
1288
1289         Reviewed by James Robinson.
1290
1291         After https://codereview.chromium.org/12328080 lands,
1292         setViewportSize is called from the Chromium side. The multiplication
1293         by deviceScaleFactor here was prone to off-by-one errors.
1294         The layoutSize() function was only used here so delete it as well.
1295
1296         DumpRenderTree WebViewHost must now call this method as well.
1297
1298         * DumpRenderTree/chromium/WebViewHost.cpp:
1299         (WebViewHost::initializeLayerTreeView):
1300         (WebViewHost::setWindowRect):
1301         (WebViewHost::setDeviceScaleFactor):
1302         (WebViewHost::updateViewportSize):
1303         * DumpRenderTree/chromium/WebViewHost.h:
1304         (WebViewHost):
1305
1306 2013-02-27  Darin Adler  <darin@apple.com>
1307
1308         StringHasher functions require alignment that call sites do not all guarantee
1309         https://bugs.webkit.org/show_bug.cgi?id=110171
1310
1311         Reviewed by Benjamin Poulain.
1312
1313         * TestWebKitAPI/CMakeLists.txt:
1314         * TestWebKitAPI/GNUmakefile.am:
1315         * TestWebKitAPI/TestWebKitAPI.gypi:
1316         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1317         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1318         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1319         * TestWebKitAPI/Tests/WTF/WTF.pro:
1320         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1321         Added the StringHasher.cpp file.
1322
1323         * TestWebKitAPI/Tests/WTF/StringHasher.cpp: Added. Contains a bunch of tests
1324         for the functions in the StringHasher class.
1325
1326 2013-03-02  Benjamin Poulain  <bpoulain@apple.com>
1327
1328         Move computedStyleIncludingVisitedInfo from TestRunner to Internals
1329         https://bugs.webkit.org/show_bug.cgi?id=109772
1330
1331         Reviewed by Andreas Kling.
1332
1333         * DumpRenderTree/TestRunner.cpp:
1334         (TestRunner::staticFunctions):
1335         * DumpRenderTree/TestRunner.h:
1336         (TestRunner):
1337         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1338         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1339         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1340         * DumpRenderTree/mac/TestRunnerMac.mm:
1341         * DumpRenderTree/qt/TestRunnerQt.cpp:
1342         * DumpRenderTree/qt/TestRunnerQt.h:
1343         (TestRunner):
1344         * DumpRenderTree/win/TestRunnerWin.cpp:
1345         * DumpRenderTree/wx/TestRunnerWx.cpp:
1346         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1347         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1348         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1349         (TestRunner):
1350
1351 2013-03-01  Ilya Tikhonovsky  <loislo@chromium.org>
1352
1353         Web Inspector: Native Memory Instrumentation: do not visit raw pointers by default.
1354         https://bugs.webkit.org/show_bug.cgi?id=110943
1355
1356         Reviewed by Yury Semikhatsky.
1357
1358         Unfortunately in many cases raw pointer may point to an object that has been deleted.
1359         There is no working solution to solve this problem in general.
1360         It could be solved only on case by case basis.
1361
1362         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
1363         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
1364         (TestWebKitAPI::TEST):
1365
1366 2013-03-01  Jason Anderssen  <janderssen@gmail.com>
1367
1368         Move markerTextForListItem from TestRunner to Internals
1369         https://bugs.webkit.org/show_bug.cgi?id=110939
1370
1371         Reviewed by Benjamin Poulain.
1372
1373         * DumpRenderTree/TestRunner.cpp:
1374         (TestRunner::staticFunctions):
1375         * DumpRenderTree/TestRunner.h:
1376         (TestRunner):
1377         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1378         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1379         (WebTestRunner::TestRunner::TestRunner):
1380         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1381         (TestRunner):
1382         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1383         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1384         * DumpRenderTree/mac/TestRunnerMac.mm:
1385         * DumpRenderTree/qt/TestRunnerQt.cpp:
1386         * DumpRenderTree/qt/TestRunnerQt.h:
1387         (TestRunnerQt):
1388         * DumpRenderTree/win/TestRunnerWin.cpp:
1389         * DumpRenderTree/wx/TestRunnerWx.cpp:
1390         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1391         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1392         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1393         (TestRunner):
1394
1395 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1396
1397         Don't use legacy test names when returning results from PerfTest.run
1398         https://bugs.webkit.org/show_bug.cgi?id=111148
1399
1400         Reviewed by Dirk Pranke.
1401
1402         * Scripts/webkitpy/performance_tests/perftest.py:
1403         (PerfTestMetric.name): Renamed from metric.
1404         (PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
1405         (PerfTest.run): Use metric name instead of the legacy name to store iteration values.
1406         (ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.
1407
1408         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1409         (TestPerfTestMetric.test_init_set_time_metric):
1410         (TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
1411         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1412         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1413
1414         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1415         (PerfTestsRunner.__init__):
1416         (PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
1417         to obtain the trac URL instead of hard coding it.
1418         (PerfTestsRunner._run_tests_set):
1419
1420 2013-03-01  Roger Fong  <roger_fong@apple.com>
1421
1422         Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
1423         https://bugs.webkit.org/show_bug.cgi?id=111202
1424
1425         This is useful for running VCExpress builds from command line because there is
1426         no unified solution output, only per project build logs.
1427         The project will be run as the last project in the solution.
1428
1429         * win/AssembleBuildLogs: Added.
1430         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
1431         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
1432         * win/AssembleBuildLogs/AssembleLogs.cmd: Added.
1433         * win/AssembleBuildLogs/README: Added.
1434
1435 2013-03-01  Roger Fong  <roger_fong@apple.com>
1436
1437         Unreviewed. Increase number of patches processed before clean building on WinEWS bots.
1438
1439         * EWSTools/start-queue-win.sh:
1440
1441 2013-03-01  Ryosuke Niwa  <rniwa@webkit.org>
1442
1443         Don't return statistics in PerfTest.run
1444         https://bugs.webkit.org/show_bug.cgi?id=111145
1445
1446         Reviewed by Dirk Pranke.
1447
1448         Simply return a list of values obtained in each iteration from PerfTest.run.
1449         Also simplify various methods as needed.
1450
1451         * Scripts/webkitpy/performance_tests/perftest.py:
1452         (PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
1453         as needed from PerfTestsRunner._generate_results_dict.
1454
1455         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
1456         that we don't have to worry about the backward compatibility here.
1457
1458         (PerfTestMetric.iteration_values): Added.
1459         (PerfTestMetric.unit): Added.
1460         (PerfTestMetric.metric_to_unit):
1461         (PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.
1462
1463         (PerfTest.run):
1464         (PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.
1465
1466         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1467         (TestPerfTestMetric.test_init_set_missing_unit):
1468         (TestPerfTestMetric.test_init_set_time_metric): Added.
1469         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
1470         (TestPerfTestMetric.test_append):
1471         (TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
1472         test cases and it's not critical to keep math right as they're not used in output JSON anymore.
1473         (TestPerfTest._assert_results_are_correct):
1474         (TestReplayPerfTest.test_run_with_driver_accumulates_results):
1475         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):
1476
1477         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1478         (PerfTestsRunner._generate_results_dict):
1479
1480         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1481         (EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
1482         (SomeParserTestData): Ditto.
1483         (MemoryTestData): Ditto.
1484
1485 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1486
1487         [Qt] Enable LINK_PREFETCH
1488         https://bugs.webkit.org/show_bug.cgi?id=111158
1489
1490         Reviewed by Simon Hausmann.
1491
1492         * qmake/mkspecs/features/features.pri:
1493
1494 2013-03-01  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1495
1496         [Qt] Update features.pri with new features
1497         https://bugs.webkit.org/show_bug.cgi?id=111157
1498
1499         Reviewed by Jocelyn Turcotte.
1500
1501         * qmake/mkspecs/features/features.pri:
1502
1503 2013-03-01  Jochen Eisinger  <jochen@chromium.org>
1504
1505         [chromium] put WebTestProxy::scheduleComposite back in place
1506         https://bugs.webkit.org/show_bug.cgi?id=111146
1507
1508         Reviewed by Nico Weber.
1509
1510         The call was removed in http://trac.webkit.org/changeset/144398 because
1511         DRT doesn't need it. However, content shell depends on this call.
1512
1513         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1514         (WebTestRunner::WebTestProxy::scheduleComposite):
1515
1516 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1517
1518         Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
1519         https://bugs.webkit.org/show_bug.cgi?id=111142
1520
1521         Reviewed by Adam Barth.
1522
1523         Merged _run_single_test into _run_tests_set. The code looks much cleaner now.
1524
1525         Also removed _print_status since it's never used anywhere.
1526
1527         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1528         (PerfTestsRunner.run):
1529         (PerfTestsRunner._run_tests_set):
1530         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1531         (MainTest.run_test):
1532         (MainTest.test_run_test_set):
1533         (MainTest.test_run_test_set_kills_drt_per_run):
1534         (MainTest.test_run_test_set_for_parser_tests):
1535
1536 2013-02-28  Kiran Muppala  <cmuppala@apple.com>
1537
1538         Disable window occlusion detection for WebKitTestRunner Web View on Mac
1539         https://bugs.webkit.org/show_bug.cgi?id=111116
1540
1541         Reviewed by Simon Fraser.
1542
1543         Window occlusion notifications were causing WebKitTestRunner's Web View
1544         to be detected as occluded and causing a few JavaScript timer layout
1545         tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
1546         by initializing the page visibility to "visible" after creating the view.
1547         But a better solution is to disable window occlusion detection, so that
1548         not only the page but also the view is treated as visible.
1549
1550         * WebKitTestRunner/TestController.cpp:
1551         (WTR::TestController::createWebViewWithOptions): Remove call to
1552         setVisibilityState, since it is no longer necessary.
1553         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1554         (WTR::PlatformWebView::PlatformWebView): Disable window occlusion
1555         detection for the created WKView.
1556
1557 2013-02-28  Li Yin  <li.yin@intel.com>
1558
1559         [chromium] Events can't be triggered on MediaStreamTrack
1560         https://bugs.webkit.org/show_bug.cgi?id=110930
1561
1562         Reviewed by Kentaro Hara.
1563
1564         Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream
1565
1566         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
1567         (WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):
1568
1569 2013-02-27  James Robinson  <jamesr@chromium.org>
1570
1571         [chromium] Use DumpRenderTree-specific interface for DRT's compositor embedding
1572         https://bugs.webkit.org/show_bug.cgi?id=111017
1573
1574         Reviewed by Adam Barth.
1575
1576         This decouples DumpRenderTree from WebLayerTreeViewClient.
1577
1578         * DumpRenderTree/chromium/WebViewHost.cpp:
1579         (WebViewHostDRTLayerTreeViewClient):
1580         (WebViewHostDRTLayerTreeViewClient::WebViewHostDRTLayerTreeViewClient):
1581         (WebViewHostDRTLayerTreeViewClient::~WebViewHostDRTLayerTreeViewClient):
1582         (WebViewHostDRTLayerTreeViewClient::Layout):
1583         (WebViewHostDRTLayerTreeViewClient::ScheduleComposite):
1584         (WebViewHost::initializeLayerTreeView):
1585         * DumpRenderTree/chromium/WebViewHost.h:
1586         (webkit_support):
1587         (WebViewHost):
1588
1589 2013-02-28  Ryuan Choi  <ryuan.choi@samsung.com>
1590
1591         Unreviewed, add my secondary email address to the list.
1592
1593         * Scripts/webkitpy/common/config/committers.py:
1594
1595 2013-02-28  Philip Rogers  <pdr@google.com>
1596
1597         Add Philip Rogers as a reviewer.
1598
1599         Unreviewed update of committers.py.
1600
1601         * Scripts/webkitpy/common/config/committers.py:
1602
1603 2013-02-28  Ryosuke Niwa  <rniwa@webkit.org>
1604
1605         Merge more methods on PerfTest
1606         https://bugs.webkit.org/show_bug.cgi?id=111030
1607
1608         Reviewed by Dirk Pranke.
1609
1610         Merged parse_output into _run_with_driver as it was the only caller. Also merged _should_ignore_line_in_stderr
1611         and _should_ignore_line_in_parser_test_result into _filter_output since it was their only caller.
1612
1613         This makes the control flow a lot more comprehensible.
1614
1615         * Scripts/webkitpy/performance_tests/perftest.py:
1616         (PerfTest._run_with_driver):
1617         (PerfTest._should_ignore_line):
1618         (PerfTest._filter_output):
1619
1620         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1621         (TestPerfTest._assert_results_are_correct):
1622         (test_ignored_stderr_lines):
1623
1624 2013-02-28  Robert Hogan  <robert@webkit.org>
1625
1626         Update my IRC nick
1627
1628         Unreviewed.
1629
1630         * Scripts/webkitpy/common/config/committers.py:
1631
1632 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1633
1634         [Qt] Enable thin archives before parsing the project files
1635
1636         Rubber-stamped by Simon Hausmann.
1637
1638         The targetSubDir() function can be called before default_post.prf has been
1639         parsed therefore the gnu_thin_archives option has to be set in default_pre.prf
1640         which is parsed before the main project file.
1641         This issue was revealed by r144299 and fixes the clean build.
1642
1643         * qmake/mkspecs/features/default_post.prf:
1644         * qmake/mkspecs/features/default_pre.prf:
1645
1646 2013-02-28  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1647
1648         [Qt] Enable CANVAS_PATH flag
1649         https://bugs.webkit.org/show_bug.cgi?id=108508
1650
1651         Reviewed by Simon Hausmann.
1652
1653         Also enable CANVAS_PATH flag for Qt.
1654
1655         * qmake/mkspecs/features/features.pri:
1656
1657 2013-02-28  Andras Becsi  <andras.becsi@digia.com>
1658
1659         [Qt][TestWebKitAPI] The activeBuildConfig() function has been replaced with targetSubDir()
1660
1661         Rubber-stamped by Csaba Osztrogonác.
1662
1663         Besides suppressing a warning about the non-existing function this
1664         fixes the build if there is a subdirectory (eg. debug-and-release).
1665
1666         * TestWebKitAPI/InjectedBundle.pri:
1667         * TestWebKitAPI/TestWebKitAPI.pri:
1668
1669 2013-02-28  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1670
1671         [EFL][WTR] WTR cannot load injected bundle
1672         https://bugs.webkit.org/show_bug.cgi?id=111063
1673
1674         Reviewed by Csaba Osztrogonác.
1675
1676         WTR was not able to load injected bundle because of undefined 
1677         symbols for AccessibilityUIElement::scrollToMakeVisible(). 
1678         Adding empty implementation of this function to AccessibilityUIElementAtk.cpp
1679         solves the problem.
1680
1681         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1682         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1683
1684 2013-02-28  Alberto Garcia  <albgarcia@rim.com>
1685
1686         [BlackBerry] TestRunnerBlackBerry: remove layerTreeAsText, it's gone from upstream
1687         https://bugs.webkit.org/show_bug.cgi?id=110464
1688
1689         Reviewed by Rob Buis.
1690
1691         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1692
1693 2013-02-28  Xan Lopez  <xlopez@rim.com>
1694
1695         [BlackBerry] DumpRenderTreeSupport: update the set position methods
1696         https://bugs.webkit.org/show_bug.cgi?id=110578
1697
1698         Reviewed by Rob Buis.
1699
1700         TestRunner::setMockGeolocationPosition() changed in r130416:
1701         http://trac.webkit.org/changeset/130416/trunk/Tools/DumpRenderTree/TestRunner.h
1702
1703         DumpRenderTreeSupport::setMockGeolocationError() was renamed to
1704         setMockGeolocationPositionUnavailableError() in r129444:
1705         http://trac.webkit.org/changeset/129444/trunk/Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.h
1706
1707         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1708         (TestRunner::setMockGeolocationPosition):
1709         (TestRunner::setMockGeolocationPositionUnavailableError):
1710
1711 2013-02-28  Xan Lopez  <xlopez@rim.com>
1712
1713         [BlackBerry] WorkQueueItemBlackBerry: use the new FrameLoader API
1714         https://bugs.webkit.org/show_bug.cgi?id=110465
1715
1716         Reviewed by Rob Buis.
1717
1718         * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
1719         (LoadItem::invoke):
1720
1721 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1722
1723         PerfTestRunner doesn't need _needs_http and _has_http_lock
1724         https://bugs.webkit.org/show_bug.cgi?id=111037
1725
1726         Reviewed by Adam Barth.
1727
1728         Delete these variables in favor of using a local variable.
1729
1730         Member variables are like global variables. They introduce implicit dependencies
1731         between member functions.
1732
1733         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1734         (PerfTestsRunner.__init__):
1735         (PerfTestsRunner._start_http_servers):
1736         (PerfTestsRunner):
1737         (PerfTestsRunner._stop_http_servers):
1738         (PerfTestsRunner.run):
1739
1740 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1741
1742         Unreviewed, rolling out r144224.
1743         http://trac.webkit.org/changeset/144224
1744         https://bugs.webkit.org/show_bug.cgi?id=111045
1745
1746         Caused plugins/pass-different-npp-struct.html to time out
1747         (Requested by abarth on #webkit).
1748
1749         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1750         (PassDifferentNPPStruct::NPP_SetWindow):
1751         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1752         (NPP_SetWindow):
1753
1754 2013-02-27  Adam Barth  <abarth@webkit.org>
1755
1756         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
1757         https://bugs.webkit.org/show_bug.cgi?id=110907
1758
1759         Reviewed by Eric Seidel.
1760
1761         This patch changes --enable-threaded-html-parser into
1762         --disable-threaded-html-parser and thereby enables the threaded HTML
1763         parser by default for the Chromium port.
1764
1765         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1766         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
1767         (WebTestRunner::WebPreferences::reset):
1768         * DumpRenderTree/chromium/TestShell.cpp:
1769         (TestShell::TestShell):
1770
1771 2013-02-27  Kiran Muppala  <cmuppala@apple.com>
1772
1773         Initialize page visibility after creating WebKitTestRunner WebView on Mac
1774         https://bugs.webkit.org/show_bug.cgi?id=111025
1775
1776         Reviewed by Simon Fraser.
1777
1778         Set page visibility to "visible" after creating WebView to override
1779         visibility state inferred from window occlusion notifications on Mac.
1780
1781         * WebKitTestRunner/TestController.cpp:
1782         (WTR::TestController::createWebViewWithOptions): Add call to
1783         setVisibilityState.
1784
1785 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1786
1787         Merge PageLoadingPerfTest into ReplayPerfTest
1788         https://bugs.webkit.org/show_bug.cgi?id=111027
1789
1790         Reviewed by Dirk Pranke.
1791
1792         Merged two classes.
1793
1794         We should really move ahead with the bug 100991 and get rid of PageLoadingPerfTest
1795         part of ReplayPerfTest.
1796
1797         * Scripts/webkitpy/performance_tests/perftest.py:
1798         (ReplayPerfTest): Moved _FORCE_GC_FILE here.
1799         (ReplayPerfTest.__init__):
1800         (ReplayPerfTest._run_with_driver): Moved from PageLoadingPerfTest.
1801         (ReplayPerfTest.run_single): Load the GC page as run_single on PageLoadingPerfTest did.
1802         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1803         (TestReplayPerfTest):
1804         (TestReplayPerfTest.test_run_single.run_test):
1805         (TestReplayPerfTest.test_run_single): Make sure test_time is passed down properly from output.
1806         (TestReplayPerfTest.test_run_with_driver_accumulates_results): Renamed from
1807         TestPageLoadingPerfTest.test_run.
1808         (TestReplayPerfTest.test_run_with_driver_accumulates_results.mock_run_signle):
1809         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Renamed from
1810         TestPageLoadingPerfTest.test_run_with_memory_output
1811         (TestReplayPerfTest.test_run_with_driver_accumulates_memory_results.mock_run_signle):
1812         (TestReplayPerfTest.test_prepare_calls_run_single):
1813
1814 2013-02-27  Eric Seidel  <eric@webkit.org>
1815
1816         Add --additional-drt-flag option to run-perf-tests to make it easy to test runtime options
1817         https://bugs.webkit.org/show_bug.cgi?id=111021
1818
1819         Reviewed by Dirk Pranke.
1820
1821         The underlying code (which is shared with run-webkit-tests)
1822         already knew how to support this option, it just wasn't exposed
1823         via the run-perf-tests front-end.  This patch fixes that.
1824
1825         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1826         (PerfTestsRunner._parse_args):
1827
1828 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1829
1830         Stop uploading results to webkit-perf.appspot.com
1831         https://bugs.webkit.org/show_bug.cgi?id=110954
1832
1833         Reviewed by Benjamin Poulain.
1834
1835         Pass in perf.webkit.org instead of webkit-perf.appspot.com as the test results server.
1836
1837         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1838         (RunAndUploadPerfTests):
1839
1840 2013-02-27  James Simonsen  <simonjam@chromium.org>
1841
1842         [chromium] Lower priority of preloaded images
1843         https://bugs.webkit.org/show_bug.cgi?id=110527
1844
1845         Plumb the didChangePriority signal into DRT so it can be tested.
1846
1847         Reviewed by Nate Chapin.
1848
1849         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
1850         (WebKit):
1851         (WebTestRunner::WebTestProxy::didChangeResourcePriority):
1852         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1853         (WebTestRunner::TestRunner::TestRunner):
1854         (WebTestRunner::TestRunner::reset):
1855         (WebTestRunner::TestRunner::shouldDumpResourcePriorities):
1856         (WebTestRunner):
1857         (WebTestRunner::TestRunner::dumpResourceRequestPriorities):
1858         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1859         (TestRunner):
1860         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1861         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
1862         (WebTestRunner::WebTestProxyBase::willSendRequest):
1863         (WebTestRunner::WebTestProxyBase::didChangeResourcePriority):
1864         (WebTestRunner):
1865
1866 2013-02-27  Chris Fleizach  <cfleizach@apple.com>
1867
1868         AX: Mac platform should support ability to scroll an element into visible
1869         https://bugs.webkit.org/show_bug.cgi?id=109860
1870
1871         Reviewed by Beth Dakin.
1872
1873         * DumpRenderTree/AccessibilityUIElement.cpp:
1874         (scrollToMakeVisibleCallback):
1875         (AccessibilityUIElement::getJSClass):
1876         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1877         (AccessibilityUIElement::scrollToMakeVisible):
1878         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1879         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1880         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1881         (AccessibilityUIElement):
1882         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1883         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1884         (WTR::AccessibilityUIElement::scrollToMakeVisible):
1885         (WTR):
1886
1887 2013-02-27  John Bauman  <jbauman@chromium.org>
1888
1889         Plugin in iframe may not display
1890         https://bugs.webkit.org/show_bug.cgi?id=109879
1891
1892         Reviewed by Simon Fraser.
1893
1894         LogNPPSetWindow will be used with other ports as well.
1895
1896         * DumpRenderTree/DumpRenderTree.gypi:
1897         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1898
1899 2013-02-27  Jochen Eisinger  <jochen@chromium.org>
1900
1901         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
1902         https://bugs.webkit.org/show_bug.cgi?id=110973
1903
1904         Reviewed by Adam Barth.
1905
1906         There is nothing that ensures that the log messages from the plugin
1907         come in before the layout test finished loading.
1908
1909         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
1910         (PassDifferentNPPStruct::NPP_SetWindow):
1911         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
1912         (NPP_SetWindow):
1913
1914 2013-02-27  Glenn Adams  <glenn@skynav.com>
1915
1916         Add ENABLE_CSS3_TEXT_LINE_BREAK flag.
1917         https://bugs.webkit.org/show_bug.cgi?id=110944
1918
1919         Reviewed by Dean Jackson.
1920
1921         * Scripts/webkitperl/FeatureList.pm:
1922         * qmake/mkspecs/features/features.pri:
1923
1924 2013-02-27  Yong Li  <yong.li.webkit@outlook.com>
1925
1926         Unreviewed. Remove myself from watchlist.
1927
1928         * Scripts/webkitpy/common/config/watchlist:
1929
1930 2013-02-27  Allan Sandfeld Jensen  <allan.jensen@digia.com>
1931
1932         Switch QtWebKit to GStreamer 1.0.
1933         https://bugs.webkit.org/show_bug.cgi?id=106669.
1934
1935         Original patch by Sebastian Dröge.
1936         Reviewed by Csaba Osztrogonác.
1937
1938         Build with GStreamer 1.0 if available, but support GStreamer 0.10 
1939         temporarily to make upgrading easy and the patch suitable for Qt5.
1940
1941         * qmake/mkspecs/features/features.prf:
1942
1943 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
1944
1945         Unreviewed. Added myself to committers.py
1946
1947         * Scripts/webkitpy/common/config/committers.py:
1948
1949 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1950
1951         Unreviewed, rolling out r144192.
1952         http://trac.webkit.org/changeset/144192
1953         https://bugs.webkit.org/show_bug.cgi?id=110984
1954
1955         Stored svn password on wrong computer (Requested by kkristof
1956         on #webkit).
1957
1958         * Scripts/webkitpy/common/config/committers.py:
1959
1960 2013-02-27  Szilard Ledan  <szledan@inf.u-szeged.hu>
1961
1962         Unreviewed. Added myself to committers.py
1963
1964         * Scripts/webkitpy/common/config/committers.py:
1965
1966 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1967
1968         Build fix after r144155. The report page is located at /api/report, not /api/test/report.
1969
1970         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1971         (PerfTestsRunner._upload_json):
1972
1973 2013-02-27  Ryosuke Niwa  <rniwa@webkit.org>
1974
1975         Stop uploading results to webkit-perf.appspot.com
1976         https://bugs.webkit.org/show_bug.cgi?id=110954
1977
1978         Reviewed by Benjamin Poulain.
1979
1980         When the specified test results server was webkit-perf.appspot.com, replace it by perf.webkit.org.
1981         Also, always use the new JSON format. Removed the code to generate the old format.
1982
1983         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1984         (PerfTestsRunner._generate_and_show_results):
1985         (PerfTestsRunner._generate_results_dict):
1986         (PerfTestsRunner._merge_slave_config_json):
1987         (PerfTestsRunner._generate_output_files):
1988
1989 2013-02-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1990
1991         Unreviewed, rolling out r144136, r144143, and r144147.
1992         http://trac.webkit.org/changeset/144136
1993         http://trac.webkit.org/changeset/144143
1994         http://trac.webkit.org/changeset/144147
1995         https://bugs.webkit.org/show_bug.cgi?id=110950
1996
1997         Caused some timeouts and flaky crashes (Requested by abarth on
1998         #webkit).
1999
2000         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2001         (main):
2002         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2003         (WebTestRunner::WebPreferences::reset):
2004         * DumpRenderTree/chromium/TestShell.cpp:
2005         (TestShell::TestShell):
2006
2007 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2008
2009         Use perf.webkit.org JSON format in results page
2010         https://bugs.webkit.org/show_bug.cgi?id=110842
2011
2012         Reviewed by Benjamin Poulain.
2013
2014         Change the default JSON format from that of webkit-perf.appspot.com to that of perf.webkit.org.
2015
2016         A whole bunch of integration tests have been updated to use the new JSON format.
2017
2018         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2019         (PerfTestsRunner._generate_and_show_results): Renamed output and output_path to legacy_output
2020         and legacy_output_json_path respectively.
2021         (PerfTestsRunner._generate_results_dict): Don't assume meta build information is always available.
2022         (PerfTestsRunner._generate_output_files): Make json_output, which is used to generate the default
2023         JSON file and the results page out of perf_webkit_output instead of legacy_output.
2024
2025         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2026         (MainTest.test_run_memory_test):
2027         (MainTest._test_run_with_json_output.mock_upload_json):
2028         (MainTest):
2029         (MainTest.test_run_with_json_output):
2030         (MainTest.test_run_with_description):
2031         (MainTest.test_run_generates_json_by_default):
2032         (MainTest.test_run_merges_output_by_default):
2033         (MainTest.test_run_respects_reset_results):
2034         (MainTest.test_run_generates_and_show_results_page):
2035         (MainTest.test_run_with_slave_config_json):
2036         (MainTest.test_run_with_multiple_repositories):
2037         (MainTest.test_run_with_upload_json):
2038         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):
2039
2040 2013-02-26  Adam Barth  <abarth@webkit.org>
2041
2042         [Chromium] Enable threaded HTML parser by default in DumpRenderTree
2043         https://bugs.webkit.org/show_bug.cgi?id=110907
2044
2045         Reviewed by Eric Seidel.
2046
2047         This patch changes --enable-threaded-html-parser into
2048         --disable-threaded-html-parser and thereby enables the threaded HTML
2049         parser by default for the Chromium port.
2050
2051         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2052         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2053         (WebTestRunner::WebPreferences::reset):
2054         * DumpRenderTree/chromium/TestShell.cpp:
2055         (TestShell::TestShell):
2056
2057 2013-02-26  Dirk Pranke  <dpranke@chromium.org>
2058
2059         [chromium] Re-enable the fixed version of freetype on linux
2060         https://bugs.webkit.org/show_bug.cgi?id=110542
2061
2062         Reviewed by Tony Chang.
2063
2064         Re-land the change in r143794 to switch to building with a fixed
2065         version of FreeType for just DumpRenderTree. This allows us to share
2066         one version of pixel baselines for both Lucid and Precise, and run the
2067         layout tests in a stock Precise install (instead of a Lucid chroot).
2068         Going forward, this approach isolates us from os-level changes to the
2069         version of FreeType. Note that Chromium itself still uses the system
2070         FreeType and is unaffected by this change.
2071         
2072         This setting can still be turned off (at compile/gyp-time) by
2073         manually setting use_custom_freetype=0.
2074
2075         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2076
2077 2013-02-26  Nico Weber  <thakis@chromium.org>
2078
2079         [chromium] content shell drt: Enable WebKit::setLayoutTestMode()
2080         https://bugs.webkit.org/show_bug.cgi?id=110890
2081
2082         Reviewed by Jochen Eisinger.
2083
2084         Several functions in webkit check that bit to change rendering
2085         in layout test mode. For example, platform/graphics/skia/FrontSkia.cpp
2086         disables font smoothing in this mode. TestShell and DRT both set
2087         this flag, so content shell drt should set it too.
2088
2089         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2090         (WebTestRunner::TestInterfaces::TestInterfaces):
2091
2092 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
2093
2094         new-commit-bot: Fix the unit test newcommitbot-unittest.py due to r144040
2095         https://bugs.webkit.org/show_bug.cgi?id=110884
2096
2097         Reviewed by Csaba Osztrogonác.
2098
2099         Adding the missing spaces before ':' in the unit test.
2100
2101         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2102
2103 2013-02-26  Vivek Galatage  <vivek.vg@samsung.com>
2104
2105         new-commit-bot: Some IRC clients doesn't linkify rollout messages
2106         https://bugs.webkit.org/show_bug.cgi?id=110861
2107
2108         Reviewed by Ryosuke Niwa.
2109
2110         Adding the space before ':' in order to fix the links shown for the rollout message.
2111
2112         * Scripts/webkitpy/tool/commands/newcommitbot.py:
2113         (NewCommitBot._summarize_commit_log):
2114
2115 2013-02-26  Joone Hur  <joone.hur@intel.com>
2116
2117         [GTK] Add Clutter to jhbuild
2118         https://bugs.webkit.org/show_bug.cgi?id=110245
2119
2120         Reviewed by Martin Robinson.
2121
2122         Add clutter, cogl, clutter-gtk, and atk to the optional moduleset.
2123         This allows to build WebKitGtk+ with clutter as an acceleration backend
2124         within the jhbuild environment. 
2125
2126         * gtk/jhbuild-optional.modules:
2127
2128 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2129
2130         Another fix attempt after r143991 since having \r? after a greedy match doesn't help.
2131
2132         * Scripts/webkitpy/common/checkout/scm/svn.py:
2133         (SVN.value_from_svn_info):
2134
2135 2013-02-25  Alan Cutter  <alancutter@chromium.org>
2136
2137         GCE EWS bots failing intermittently on HTTP 502 error while updating their status
2138         https://bugs.webkit.org/show_bug.cgi?id=110845
2139
2140         Unreviewed EWS bot fix.
2141
2142         Switch the Queue Status Server address the EWS bots use to a more direct URL that
2143         doesn't seem to be having problems from GCE like queues.webkit.org.
2144
2145         * Scripts/webkitpy/common/net/statusserver.py:
2146         (StatusServer):
2147
2148 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2149
2150         Forgot to delete a no-longer-needed unit test after r143980.
2151
2152         Unreviewed, build fix.
2153
2154         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2155         (ChromiumWinTest.test_path_to_image_diff):
2156
2157 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2158
2159         Build fix. run-perf-tests was reporting with revision numbers ending with \r.
2160         Don't include \r at the end of svn info lines on Windows.
2161
2162         This is similar to r143839.
2163
2164         * Scripts/webkitpy/common/checkout/scm/svn.py:
2165         (SVN.value_from_svn_info):
2166
2167 2013-02-25  James Simonsen  <simonjam@chromium.org>
2168
2169         [Resource Timing] Update test suite so it can be exported to the W3C
2170         https://bugs.webkit.org/show_bug.cgi?id=107343
2171
2172         Reviewed by Tony Gentilcore.
2173
2174         * Scripts/export-w3c-performance-wg-tests: Clean up output.
2175         * Scripts/import-w3c-performance-wg-tests:
2176
2177 2013-02-25  Anders Carlsson  <andersca@apple.com>
2178
2179         Add a new unavailablePluginButtonClicked callback that takes a WKDictionary of plug-in information
2180         https://bugs.webkit.org/show_bug.cgi?id=110821
2181         <rdar://problem/13265303>
2182
2183         Reviewed by Beth Dakin.
2184
2185         Update for WebKit2 changes.
2186
2187         * MiniBrowser/mac/WK2BrowserWindowController.m:
2188         (-[WK2BrowserWindowController awakeFromNib]):
2189         * WebKitTestRunner/TestController.cpp:
2190         (WTR::TestController::createOtherPage):
2191         (WTR::TestController::createWebViewWithOptions):
2192         (WTR::TestController::unavailablePluginButtonClicked):
2193         * WebKitTestRunner/TestController.h:
2194         (TestController):
2195
2196 2013-02-21  Jeffrey Pfau  <jpfau@apple.com>
2197
2198         Optionally partition cache to prevent using cache for tracking
2199         https://bugs.webkit.org/show_bug.cgi?id=110269
2200
2201         Reviewed by Maciej Stachowiak.
2202
2203         Add test suite for public suffix functions on Mac.
2204
2205         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2206         * TestWebKitAPI/Tests/mac/PublicSuffix.mm: Added.
2207         (TestWebKitAPI):
2208         (TestWebKitAPI::TEST_F):
2209
2210 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2211
2212         nrwt: reenable multiple http shards on chromium win
2213         https://bugs.webkit.org/show_bug.cgi?id=110814
2214
2215         Reviewed by Tony Chang.
2216
2217         The underlying bug in DumpRenderTree that was causing us to look for a
2218         pac file and timeout under load was fixed a while ago.
2219
2220         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2221         (ChromiumWinPort.relative_test_filename):
2222
2223 2013-02-25  Dirk Pranke  <dpranke@chromium.org>
2224
2225         Make ninja the default w/ build-webkit --chromium on windows.
2226         https://bugs.webkit.org/show_bug.cgi?id=110731
2227
2228         Unreviewed - TBR'ing thakis :).
2229
2230         * Scripts/update-webkit-chromium:
2231
2232 2013-02-25  Anders Carlsson  <andersca@apple.com>
2233
2234         Add a new pluginDidFail callback that takes a WKDictionary of plug-in information
2235         https://bugs.webkit.org/show_bug.cgi?id=110793
2236         <rdar://problem/13265303>
2237
2238         Reviewed by Sam Weinig.
2239
2240         Update for WebKit2 API changes.
2241
2242         * MiniBrowser/mac/WK2BrowserWindowController.m:
2243         (-[WK2BrowserWindowController awakeFromNib]):
2244         * WebKitTestRunner/TestController.cpp:
2245         (WTR::TestController::createWebViewWithOptions):
2246
2247 2013-02-25  Nico Weber  <thakis@chromium.org>
2248
2249         Fix python unit tests after yoli's email address update in http://trac.webkit.org/changeset/143922
2250         https://bugs.webkit.org/show_bug.cgi?id=110775
2251
2252         Unreviewed, basically a rebaseline.
2253
2254         * Scripts/webkitpy/common/config/watchlist:
2255
2256 2013-02-25  Nico Weber  <thakis@chromium.org>
2257
2258         [chromium] Try to get the webkit builder to use msvs again
2259         https://bugs.webkit.org/show_bug.cgi?id=110771
2260
2261         Reviewed by Eric Seidel.
2262
2263         The msvs gyp generator apparently doesn't write the sln file on every
2264         run, so check the vcxproj file instead.
2265
2266         * Scripts/webkitdirs.pm:
2267         (determineIsChromiumNinja):
2268
2269 2013-02-25  Nico Weber  <thakis@chromium.org>
2270
2271         [chromium] try to unbreak run-chromium-webkit-unit-tests on the mac bots
2272         https://bugs.webkit.org/show_bug.cgi?id=110767
2273
2274         Reviewed by Eric Seidel.
2275
2276         The tester runs gyp, which generates out/Release/build.ninja. The bot
2277         scripts use existence (and timestamp) of that file to decide if the
2278         current build is supposed to be ninja or xcodebuild. The file exists,
2279         so the snapshot is extracted to out/Release. The snapshot doesn't
2280         contain build.ninja however due to
2281         http://trac.webkit.org/changeset/140375 , so after extracting the
2282         snapshot the scripts think that this is an xcodebuild build. So remove
2283         the part of that revision that removed ninja files from the archive,
2284         and the bots should be happy again.
2285
2286         * BuildSlaveSupport/built-product-archive:
2287         (archiveBuiltProduct):
2288
2289 2013-02-25  Nico Weber  <thakis@chromium.org>
2290
2291         Fix tests after r143910
2292         https://bugs.webkit.org/show_bug.cgi?id=110757
2293
2294         Reviewed by Andreas Kling.
2295
2296         While here, also add a test for the bug r143910 fixed.
2297
2298         * Scripts/webkitpy/common/system/executive_unittest.py:
2299         (ScriptErrorTest.test_message_with_output):
2300         (ScriptErrorTest):
2301         (ScriptErrorTest.test_message_with_tuple):
2302
2303 2013-02-25  Nico Weber  <thakis@chromium.org>
2304
2305         [chromium] Apparently built-product-archive is written in Python, not Perl :-/
2306         https://bugs.webkit.org/show_bug.cgi?id=110755
2307
2308         Reviewed by Jochen Eisinger.
2309
2310         * BuildSlaveSupport/built-product-archive:
2311         (archiveBuiltProduct):
2312         (extractBuiltProduct):
2313
2314 2013-02-25  Sheriff Bot  <webkit.review.bot@gmail.com>
2315
2316         Unreviewed, rolling out r143895.
2317         http://trac.webkit.org/changeset/143895
2318         https://bugs.webkit.org/show_bug.cgi?id=110758
2319
2320         broke a bunch of tests (Requested by thakis__ on #webkit).
2321
2322         * Scripts/update-webkit-chromium:
2323
2324 2013-02-25  Andreas Kling  <akling@apple.com>
2325
2326         Unreviewed, fix simple mistake in r143903.
2327         <http://webkit.org/b/110746>
2328
2329         Reviewed by Andreas Kling.
2330
2331         Pass git revision, not svn revision, to git shell command.
2332
2333         * Scripts/webkitpy/common/checkout/scm/git.py:
2334         (Git.timestamp_of_latest_commit):
2335
2336 2013-02-25  Nico Weber  <thakis@chromium.org>
2337
2338         [chromium] Let built-product-archive log which directory it's archiving from and extracting to
2339         https://bugs.webkit.org/show_bug.cgi?id=110748
2340
2341         Reviewed by Jochen Eisinger.
2342
2343         One of the mac testers runs DRT from out/ but WebKitUnitTests from
2344         xcodebuild. I'm trying to understand what's going on.
2345
2346         * BuildSlaveSupport/built-product-archive:
2347         (archiveBuiltProduct):
2348         (extractBuiltProduct):
2349
2350 2013-02-23  Ilya Tikhonovsky  <loislo@chromium.org>
2351
2352         Web Inspector: Native Memory Instrumentation: replace String with const char* in MemoryObjectInfo
2353         https://bugs.webkit.org/show_bug.cgi?id=110599
2354
2355         Reviewed by Yury Semikhatsky.
2356
2357         Due to potentially dynamic nature of names and classNames we need to make a copy of the strings
2358         that were given us via MemoryInstrumentation calls.
2359         So I extended client api with registerString method that pushes the strings
2360         down to the serializer.
2361
2362         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2363         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
2364         (TestWebKitAPI::Helper::Helper):
2365         (Helper):
2366         (TestWebKitAPI::Helper::addNode):
2367         (TestWebKitAPI::TEST):
2368
2369 2013-02-25  Nico Weber  <thakis@chromium.org>
2370
2371         Make ScriptError not crash when args is a tuple
2372         https://bugs.webkit.org/show_bug.cgi?id=110747
2373
2374         Reviewed by Jochen Eisinger.
2375
2376         I'm trying to understand the error on
2377         http://build.webkit.org/builders/Chromium%20Win%20Release%20%28Tests%29/builds/34563/steps/layout-test/logs/stdio
2378         better. I'll likely have to revert the ninja switch on windows, but
2379         having error reporting code that doesn't itself crash sounds like a
2380         good thing to have anyways.
2381
2382         The problem is that '%s' % (1, 2) errors out, and args is sometimes a
2383         tuple not a list.
2384
2385         * Scripts/run-chromium-webkit-unit-tests:
2386         * Scripts/webkitpy/common/system/executive.py:
2387         (ScriptError.__init__):
2388
2389 2013-02-25  Laszlo Gombos  <l.gombos@samsung.com>
2390
2391         [EFL] Align feature defaults
2392         https://bugs.webkit.org/show_bug.cgi?id=110715
2393
2394         Enable 3D_RENDERING in FeatureList.pm as it is enabled by default in
2395         OptionsEfl.cmake.
2396
2397         Reviewed by Gyuyoung Kim.
2398
2399         * Scripts/webkitperl/FeatureList.pm:
2400
2401 2013-02-25  Ryosuke Niwa  <rniwa@webkit.org>
2402
2403         run-perf-tests reports wrong commit time
2404         https://bugs.webkit.org/show_bug.cgi?id=110746
2405
2406         Reviewed by Andreas Kling.
2407
2408         The bug was caused by running "svn info" on a subdirectory, which returns a timestamp
2409         of when the subdirectory was last modified.
2410
2411         Run "svn info -r <revision> <repository root>" instead. Specifying revision number is
2412         insufficient since running "svn log -r <revision>" on a partial checkout only returns
2413         an empty result if the revision didn't modify the subdirectory.
2414
2415         For git, there is no partial checkout, so we just need to pass in "-r" option to keep
2416         the interface compatible with svn.
2417
2418         * Scripts/webkitpy/common/checkout/scm/git.py:
2419         (Git.timestamp_of_latest_commit):
2420         * Scripts/webkitpy/common/checkout/scm/scm.py:
2421         (SCM.timestamp_of_latest_commit):
2422         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2423         (MockSCM.timestamp_of_latest_commit):
2424         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2425         (test_timestamp_of_latest_commit):
2426         * Scripts/webkitpy/common/checkout/scm/svn.py:
2427         (SVN.timestamp_of_latest_commit):
2428         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2429         (PerfTestsRunner._generate_results_dict):
2430
2431 2013-02-25  Jochen Eisinger  <jochen@chromium.org>
2432
2433         [chromium] move WebRuntimeFeatures configuration to TestRunner library
2434         https://bugs.webkit.org/show_bug.cgi?id=110712
2435
2436         Reviewed by Nico Weber.
2437
2438         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2439         (WebTestRunner::TestInterfaces::TestInterfaces):
2440         * DumpRenderTree/chromium/TestShell.cpp:
2441         (TestShell::TestShell):
2442
2443 2013-02-25  Nico Weber  <thakis@chromium.org>
2444
2445         Make ninja the default build system for build-webkit --chromium on windows
2446         https://bugs.webkit.org/show_bug.cgi?id=110731
2447
2448         Reviewed by Jochen Eisinger.
2449
2450         With http://crbug.com/169945 fixed, this should now work.
2451
2452         * Scripts/update-webkit-chromium:
2453
2454 2013-02-24  Gustavo Noronha Silva  <gns@gnome.org>
2455
2456         [GTK] GTK+ 2 build broken since GTK_API_VERSION_2 moved to autoconfig.h
2457         https://bugs.webkit.org/show_bug.cgi?id=110702
2458
2459         Reviewed by Martin Robinson.
2460
2461         * GtkLauncher/main.c: include autotoolsconfig.h.
2462         * Scripts/webkitpy/style/checker.py: make GtkLauncher/main.c exempt of
2463         the include ordering check, since it uses autotoolsconfig.h which needs to
2464         come first.
2465
2466 2013-02-24  Hajime Morrita  <morrita@google.com>
2467
2468         [Custom Elements] Implement bare-bone document.register()
2469         https://bugs.webkit.org/show_bug.cgi?id=100229
2470
2471         Reviewed by Adam Barth.
2472
2473         Added enableCustomDOMElements flag.
2474
2475         * DumpRenderTree/chromium/TestShell.cpp:
2476         (TestShell::TestShell):
2477
2478 2013-02-23  Mark Pilgrim  <pilgrim@chromium.org>
2479
2480         [Chromium] DumpRenderTree TestShell::initialize should take Platform* now that WebKitPlatformSupport is empty
2481         https://bugs.webkit.org/show_bug.cgi?id=110606
2482
2483         Reviewed by Adam Barth.
2484
2485         Part of a larger refactoring series; see tracking bug 82948.
2486
2487         * DumpRenderTree/DumpRenderTree.gypi:
2488         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2489         (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
2490         (WebKitSupportTestEnvironment::mockPlatform):
2491         (WebKitSupportTestEnvironment):
2492         * DumpRenderTree/chromium/MockPlatform.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp.
2493         (MockPlatform::create):
2494         (MockPlatform::MockPlatform):
2495         (MockPlatform::~MockPlatform):
2496         (MockPlatform::setInterfaces):
2497         (MockPlatform::cryptographicallyRandomValues):
2498         (MockPlatform::createMediaStreamCenter):
2499         (MockPlatform::createRTCPeerConnectionHandler):
2500         * DumpRenderTree/chromium/MockPlatform.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
2501         (MockPlatform):
2502         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp: Removed.
2503         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h: Removed.
2504         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2505         (WebTestDelegate):
2506         * DumpRenderTree/chromium/TestShell.cpp:
2507         (TestShell::initialize):
2508         * DumpRenderTree/chromium/TestShell.h:
2509         (TestShell):
2510
2511 2013-02-23  Ryosuke Niwa  <rniwa@webkit.org>
2512
2513         Chromium Windows Perf bot fix. Tolerate CR at the end of the line that contains the timestamp.
2514
2515         * Scripts/webkitpy/common/checkout/scm/svn.py:
2516         (SVN.timestamp_of_latest_commit):
2517
2518 2013-02-23  Jason Anderssen  <janderssen@gmail.com>
2519
2520         Move setAutofilled from TestRunner to WebCore
2521         https://bugs.webkit.org/show_bug.cgi?id=110521
2522
2523         Reviewed by Benjamin Poulain.
2524
2525         * DumpRenderTree/TestRunner.cpp:
2526         (TestRunner::staticFunctions):
2527         * DumpRenderTree/TestRunner.h:
2528         (TestRunner):
2529         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2530         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2531         (WebTestRunner::TestRunner::TestRunner):
2532         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2533         (TestRunner):
2534         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2535         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2536         * DumpRenderTree/mac/TestRunnerMac.mm:
2537         * DumpRenderTree/qt/TestRunnerQt.cpp:
2538         * DumpRenderTree/qt/TestRunnerQt.h:
2539         (TestRunnerQt):
2540         * DumpRenderTree/win/TestRunnerWin.cpp:
2541         * DumpRenderTree/wx/TestRunnerWx.cpp:
2542
2543 2013-02-22  Ryosuke Niwa  <rniwa@webkit.org>
2544
2545         Upload results to perf.webkit.org in addition to the one specified by --test-results-server
2546         https://bugs.webkit.org/show_bug.cgi?id=108577
2547
2548         Reviewed by Dirk Pranke.
2549
2550         Upload results to perf.webkit.org using new JSON format as well as the host specified by
2551         --test-results-server. The new format is needed to provide extra information perf.webkit.org
2552         need such as the subversion commit time and test URLs. This is a temporarily measure until
2553         we complete the transition and the old JSON format and the code to upload results to
2554         webkit-perf.appspot.com can be deleted.
2555
2556         This patch adds scm.timestamp_of_latest_commit to obtain the timestamp of the latest commit present
2557         in a svn checkout or a git clone. This information is embedded in JSON submitted to perf.webkit.org
2558         so that the app can sort performance test results based on the timestamp of the last commit.
2559
2560         It also changes the repository names returned by port objects to be properly capitalized
2561         human readable names such as WebKit instead of lowercased names such as webkit since these names
2562         are displayed on perf.webkit.org for humans. Several users of this feature has been updated
2563         to explicitly lowercase the names.
2564
2565
2566         * Scripts/webkitpy/common/checkout/scm/git.py:
2567         (Git.timestamp_of_latest_commit): Added. Obtains the timestamp of the last commit. Unfortunately,
2568         git's timestamp granularity is seconds so we're losing some information compared to using a regular
2569         subversion client. To make matters worse, git doesn't have any option to show ISO-format timestamp in
2570         UTC so we're going to manually fiddle with timezone.
2571
2572         * Scripts/webkitpy/common/checkout/scm/scm.py:
2573         (SCM.timestamp_of_latest_commit): Added.
2574
2575         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2576         (MockSCM.timestamp_of_latest_commit): Added.
2577
2578         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2579         (test_timestamp_of_latest_commit): Added a test for Git.timestamp_of_latest_commit.
2580
2581         * Scripts/webkitpy/common/checkout/scm/svn.py:
2582         (SVN.timestamp_of_latest_commit): Added. With svn, all we need to do is to use --xml option and parse
2583         the timestamp which is always in UTC.
2584
2585         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2586         (JSONResultsGeneratorBase._insert_generic_metadata): Lowercase the name. Note that the name
2587         'chromium' needs to be substituted by 'chrome' for historical reasons.
2588
2589         * Scripts/webkitpy/layout_tests/port/base.py:
2590         (Port.repository_paths): Return WebKit instead of webkit as noted above.
2591
2592         * Scripts/webkitpy/layout_tests/port/chromium.py:
2593         (ChromiumPort.repository_paths): Return Chromium instead of chromium as noted above.
2594
2595         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2596         (PerfTestsRunner.__init__): Store the current time in UTC as well as in local time.
2597         (PerfTestsRunner._collect_tests):
2598
2599         (PerfTestsRunner._generate_and_show_results): Retrieve both regular output and one for perf.webkit.org,
2600         and upload them appropriately.
2601
2602         (PerfTestsRunner._generate_results_dict): Store WebKit and Chromium revisions at which tests were ran
2603         in revisions_for_perf_webkit and construct an output for perf.webkit.org.
2604
2605         (PerfTestsRunner._datetime_in_ES5_compatible_iso_format): Added.
2606
2607         (PerfTestsRunner._merge_slave_config_json): Merge slave configuration files into both regular output
2608         and one for perf.webkit.org. Here, we prefix each key with "builder" for perf.webkit.org.
2609         e.g. "processor" would be renamed to "builderProcessor".
2610
2611         (PerfTestsRunner._generate_output_files):
2612
2613         (PerfTestsRunner._upload_json): Added a remote path as an argument since we upload JSONs to /api/report
2614         on perf.webkit.org whereas we upload it to /api/test/report on webkit-perf.appspot.com. Also added the code
2615         to parse response as JSON when possible since perf.webkit.org returns a JSON response as opposed to
2616         webkit-perf.appspot.com which spits out a plaintext response.
2617
2618         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2619         (MainTest._test_run_with_json_output.mock_upload_json): Tolerate perf.webkit.org/api/report for now.
2620         (MainTest._test_run_with_json_output): Store a UTC time as perftestrunner would do.
2621         (MainTest.test_run_with_upload_json_should_generate_perf_webkit_json): Added.
2622
2623         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2624         (MainTest.test_upload_json): Moved from itegrationtest.py since it really is a unit test. Also added test
2625         cases to parse JSON responses.
2626         (MainTest.test_upload_json.MockFileUploader): Refactored.
2627         (MainTest.test_upload_json.MockFileUploader.reset): Added.
2628         (MainTest.test_upload_json.MockFileUploader.__init__):
2629         (MainTest.test_upload_json.MockFileUploader.upload_single_text_file):
2630
2631 2013-02-22  Roger Fong  <roger_fong@apple.com>
2632
2633         Unreviewed. Update bot config for OpenSource bots to add two new Win7 Debug testers and get rid of WinXP Debug testers.
2634
2635         * BuildSlaveSupport/build.webkit.org-config/config.json:
2636
2637 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2638
2639         Unreviewed, rolling out r143794.
2640         http://trac.webkit.org/changeset/143794
2641         https://bugs.webkit.org/show_bug.cgi?id=110542
2642
2643         debug linux builds broken?
2644
2645         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2646
2647 2013-02-22  Dirk Pranke  <dpranke@chromium.org>
2648
2649         [chromium] enable the fixed version of freetype on linux
2650         https://bugs.webkit.org/show_bug.cgi?id=110542
2651
2652         Reviewed by Tony Chang.
2653
2654         Switch to building with a fixed version of FreeType for
2655         just DumpRenderTree. This allows us to share one version
2656         of pixel baselines for both Lucid and Precise, and run
2657         the layout tests in a stock Precise install (instead of a Lucid
2658         chroot). Going forward, this approach isolates us from os-level
2659         changes to the version of FreeType. Note that Chromium itself
2660         still uses the system FreeType and is unaffected by this change.
2661         
2662         This setting can still be turned off (at compile/gyp-time) by
2663         manually setting use_custom_freetype=0.
2664
2665         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2666
2667 2013-02-22  Anders Carlsson  <andersca@apple.com>
2668
2669         Move pluginLoadPolicy to the page loader client
2670         https://bugs.webkit.org/show_bug.cgi?id=110635
2671
2672         Reviewed by Sam Weinig.
2673
2674         * MiniBrowser/mac/WK2BrowserWindowController.m:
2675         (-[WK2BrowserWindowController awakeFromNib]):
2676         * WebKitTestRunner/TestController.cpp:
2677         (WTR::TestController::createOtherPage):
2678         (WTR::TestController::createWebViewWithOptions):
2679
2680 2013-02-22  Kenneth Russell  <kbr@google.com>
2681
2682         Unreviewed. Changed gman's primary address for auto-complete in Bugzilla.
2683
2684         * Scripts/webkitpy/common/config/committers.py:
2685
2686 2013-02-22  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2687
2688         [WTR] Do not dump information about empty subframes.
2689         https://bugs.webkit.org/show_bug.cgi?id=110585
2690
2691         Reviewed by Simon Fraser.
2692
2693         Follow DumpRenderTree more closely by skipping empty frames
2694         (frames which have no document). We are not really interested in
2695         showing anything about them.
2696
2697         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2698         (WTR::dumpDescendantFramesText): Do not print subframe names when they
2699         have no associated Document.
2700
2701 2013-02-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
2702
2703         [EFL][DRT] Do not dump empty frames.
2704         https://bugs.webkit.org/show_bug.cgi?id=110474
2705
2706         Reviewed by Kenneth Rohde Christiansen.
2707
2708         Follow the original Mac implementation more closely by skipping
2709         empty frames (frames which have no document). We are not really
2710         interested in showing anything about them.
2711
2712         * DumpRenderTree/efl/DumpRenderTree.cpp:
2713         (dumpFramesAsText):
2714
2715 2013-02-21  Dirk Pranke  <dpranke@chromium.org>
2716
2717         [chromium] support the lucid version of freetype on precise in DRT
2718         https://bugs.webkit.org/show_bug.cgi?id=107338
2719
2720         Reviewed by Tony Chang.
2721
2722         Modify the DRT build so that we can optionally link against
2723         a fixed version of Freetype2. This allows us to share pixel test
2724         results across multiple versions of Ubuntu without having to
2725         worry about differences in font rendering.
2726
2727         At the moment this feature is off by default. Eventually it will
2728         be on by default on linux.
2729
2730         Note that this only affects DRT; the regular Chromium binary
2731         (and, for now, content_shell) will still use the system version
2732         of Freetype.
2733
2734         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2735
2736 2013-02-21  Rouslan Solomakhin  <rouslan@chromium.org>
2737
2738         [Chromium] Remove the word "cheher" from the list of misspelled words
2739         https://bugs.webkit.org/show_bug.cgi?id=110447
2740
2741         Reviewed by Tony Chang.
2742
2743         Other platforms do not mark "cheher" as a misspelled word in layout tests.
2744         This change is to bring Chromium platform in line with the rest of the
2745         platforms.
2746
2747         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
2748         (WebTestRunner::MockSpellCheck::hasInCache): Changed "cheher" to "wellcome".
2749         (WebTestRunner::MockSpellCheck::fillSuggestionList): Removed "cheher" misspelling and "checker" suggestion.
2750         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Removed "cheher" misspelling.
2751
2752 2013-02-21  Jochen Eisinger  <jochen@chromium.org>
2753
2754         [chromium] document WebTestDelegate and WebTestRunner interfaces
2755         https://bugs.webkit.org/show_bug.cgi?id=110472
2756
2757         Reviewed by Adam Barth.
2758
2759         Also remove the default implementation of the remaining WebTestDelegate
2760         methods now that all embedders provide this interface.
2761
2762         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2763         (WebTestDelegate):
2764         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2765         (WebTestRunner):
2766
2767 2013-02-19  Mark Hahnenberg  <mhahnenberg@apple.com>
2768
2769         Objective-C API: Need a way to use the Objective-C JavaScript API with WebKit
2770         https://bugs.webkit.org/show_bug.cgi?id=106059
2771
2772         Reviewed by Geoffrey Garen.
2773
2774         Added new tests for the WebKit API portion of the JSC Objective-C API.
2775
2776         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2777         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache1.html: Added.
2778         * TestWebKitAPI/Tests/mac/JSContextBackForwardCache2.html: Added.
2779         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm: Added.
2780         (-[MyConsole log:]):
2781         (-[MyConsole printHelloWorld]):
2782         (-[MyConsole add:to:]):
2783         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didFinishLoadForFrame:]):
2784         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
2785         (TestWebKitAPI):
2786         (TestWebKitAPI::TEST):
2787
2788 2013-02-21  Stephen Chenney  <schenney@chromium.org>
2789
2790         Unreviewed, add myself as a reviewer
2791
2792         * Scripts/webkitpy/common/config/committers.py:
2793
2794 2013-02-21  Jer Noble  <jer.noble@apple.com>
2795
2796         Unreviewed; add myself to the Media watchlist and update my committers.py setting to Reviewer.
2797
2798         * Scripts/webkitpy/common/config/committers.py:
2799         * Scripts/webkitpy/common/config/watchlist:
2800
2801 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
2802
2803         gtk/DumpRenderTree.cpp is missing <locale.h> include
2804         https://bugs.webkit.org/show_bug.cgi?id=109386
2805
2806         * DumpRenderTree/gtk/DumpRenderTree.cpp: Fix the WebKitGTK+ Mac build
2807         by include locale.h when we use setlocale.
2808
2809 2013-02-21  Martin Robinson  <mrobinson@igalia.com>
2810
2811         [GTK] Move feature overriding to the configure phase
2812         https://bugs.webkit.org/show_bug.cgi?id=110293
2813
2814         Reviewed by Gustavo Noronha Silva.
2815
2816         * Scripts/webkitdirs.pm:
2817         (runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
2818         WebKitFeatureOverrides.txt to better match the other filenames used in
2819         the new feature processing.
2820         * gtk/generate-feature-defines-files: Added. A script which takes as an argument
2821         the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
2822         and writes WebKitFeatures.txt and WebKitFeatures.h.
2823         * gtk/override-feature-defines: Removed.
2824
2825 2013-02-21  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
2826
2827         [Qt] Remove obsolete DEPENDPATH assignment
2828
2829         Reviewed by Simon Hausmann
2830
2831         qmake now adds CONFIG+=depend_includepath by default, making manual
2832         DEPENDPATH setup unnecessary.
2833
2834         * qmake/mkspecs/features/default_post.prf:
2835
2836 2013-02-20  Vivek Galatage  <vivekg@webkit.org>
2837
2838         Unreviewed. Changing primary email id.
2839
2840         * Scripts/webkitpy/common/config/committers.py:
2841
2842 2013-02-14  James Robinson  <jamesr@chromium.org>
2843
2844         [chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
2845         https://bugs.webkit.org/show_bug.cgi?id=109634
2846
2847         Reviewed by Adrienne Walker.
2848
2849         * DumpRenderTree/chromium/WebViewHost.cpp:
2850         (WebViewHost::createOutputSurface):
2851         (WebViewHost::initializeLayerTreeView):
2852
2853 2013-02-20  Martin Robinson  <mrobinson@igalia.com>
2854
2855         [GTK] Re-enable 3D CSS transforms when using build-webkit
2856         https://bugs.webkit.org/show_bug.cgi?id=110402
2857
2858         Reviewed by Xan Lopez.
2859
2860         * Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
2861         when building WebKitGTK+.
2862
2863 2013-02-20  Roger Fong  <roger_fong@apple.com>
2864
2865         Get VS2010 Solution B&I ready.
2866         <rdar://problem/1322988>
2867
2868         Rubberstamped by Timothy Horton.        
2869         
2870         Add Production configurations.
2871         
2872         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2873         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2874         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherProduction.props: Added.
2875         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props:
2876         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeProduction.props: Added.
2877         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props:
2878         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2879         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2880         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherProduction.props: Added.
2881         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props:
2882         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffProduction.props: Added.
2883         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props:
2884         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2885         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginProduction.props: Added.
2886         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props:
2887         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2888         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIProduction.props: Added.
2889         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIRelease.props:
2890         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2891         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2892         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibProduction.props: Added.
2893         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibRelease.props:
2894         * WinLauncher/WinLauncher.vcxproj/WinLauncherProduction.props: Added.
2895         * WinLauncher/WinLauncher.vcxproj/WinLauncherRelease.props:
2896         * win/record-memory/record-memory.vcxproj:
2897         * win/record-memory/record-memoryProduction.props: Added.
2898         * win/record-memory/record-memoryRelease.props:
2899
2900 2013-02-20  Dirk Schulze  <krit@webkit.org>
2901
2902         Enable CANVAS_PATH flag
2903         https://bugs.webkit.org/show_bug.cgi?id=108508
2904
2905         Reviewed by Simon Fraser.
2906
2907         Enable CANVAS_PATH flag on trunk.
2908
2909         * Scripts/webkitperl/FeatureList.pm:
2910
2911 2013-02-20  Tony Chang  <tony@chromium.org>
2912
2913         Parse author names with commas in ChangeLogs
2914         https://bugs.webkit.org/show_bug.cgi?id=110356
2915
2916         Reviewed by Dirk Pranke.
2917
2918         Paweł's name has a comma in it, which was confusing the ChangeLog parser.
2919
2920         * Scripts/webkitpy/common/checkout/changelog.py:
2921         (ChangeLogEntry): Move name splitting regexp into a constant.
2922         (ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
2923         (ChangeLogEntry._split_reviewer_names): Rename to be more specific.
2924         (ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
2925         (ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
2926         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2927         (test_parse_authors): Test case with Paweł's name.
2928
2929 2013-02-15  Dirk Schulze  <krit@webkit.org>
2930
2931         [Chromium] Add runtime flag for CanvasPath
2932         https://bugs.webkit.org/show_bug.cgi?id=109997
2933
2934         Reviewed by Adam Barth.
2935
2936         Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
2937         the constructor for Path on DOMWindow would never be activatable, since the script
2938         is running after creating the DOMWindow object.
2939
2940         * DumpRenderTree/chromium/TestShell.cpp:
2941         (TestShell::TestShell):
2942
2943 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
2944
2945         [chromium] use a WebTestProxyBase pointer to identify the window we need the history for
2946         https://bugs.webkit.org/show_bug.cgi?id=110346
2947
2948         Reviewed by Adam Barth.
2949
2950         Using an index is very brittle, as the TestRunner API does not define
2951         any ordering of windows.
2952
2953         Also, make TestRunner::shouldDumpBackForwardList() so content shell can
2954         trigger the capturing in the browser process before generating the
2955         text dump.
2956
2957         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2958         (WebTestRunner):
2959         (WebTestRunner::WebTestDelegate::captureHistoryForWindow):
2960         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
2961         (WebTestRunner):
2962         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2963         (TestRunner):
2964         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2965         (WebTestRunner::WebTestProxyBase::captureTree):
2966         * DumpRenderTree/chromium/WebViewHost.cpp:
2967         (WebViewHost::captureHistoryForWindow):
2968         * DumpRenderTree/chromium/WebViewHost.h:
2969         (WebViewHost):
2970
2971 2013-02-19  Rouslan Solomakhin  <rouslan@chromium.org>
2972
2973         [Chromium] Serve spellcheck suggestions for editing/spelling/spelling-changed-text.html from cache
2974         https://bugs.webkit.org/show_bug.cgi?id=109220
2975
2976         Reviewed by Tony Chang.
2977
2978         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp:
2979         (WebTestRunner::MockSpellCheck::hasInCache): Added a method to detect whether spellcheck results can be served from cache.
2980         (WebTestRunner):
2981         (WebTestRunner::MockSpellCheck::fillSuggestionList): Modified to suggest "checker" for the word "cheher".
2982         (WebTestRunner::MockSpellCheck::initializeIfNeeded): Modified to mark "cheher" as misspelling.
2983         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h:
2984         (MockSpellCheck):
2985         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp:
2986         (WebTestRunner::SpellCheckClient::requestCheckingOfText): Modified to serve spellcheck suggestions from cache when possible.
2987
2988 2013-02-20  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2989
2990         [Gtk] HTML5 Media controls require a design refresh
2991         https://bugs.webkit.org/show_bug.cgi?id=83869
2992
2993         Reviewed by Philippe Normand.
2994
2995         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2996         (initializeGtkFontSettings): Added gnome as default icon theme for
2997         the DRT.
2998         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2999         (WTR::initializeGtkSettings): Added gnome as default icon theme for
3000         the WTR.
3001         * gtk/jhbuild.modules: Added gnome-icon-theme-symbolic as external
3002         dependency.
3003
3004 2013-02-20  Jochen Eisinger  <jochen@chromium.org>
3005
3006         [chromium] move most of the remaining mocks to TestRunner library
3007         https://bugs.webkit.org/show_bug.cgi?id=110217
3008
3009         Reviewed by Nico Weber.
3010
3011         While most of the functionality provided by these mocks is also
3012         available in the content module, there is no straight forward way to
3013         inject the mock results required for layout tests.
3014
3015         * DumpRenderTree/DumpRenderTree.gypi:
3016         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3017         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3018         (WebKit):
3019         (WebTestRunner):
3020         (WebTestRunner::WebTestProxy::geolocationClient):
3021         (WebTestRunner::WebTestProxy::speechInputController):
3022         (WebTestRunner::WebTestProxy::speechRecognizer):
3023         (WebTestRunner::WebTestProxy::deviceOrientationClient):
3024         (WebTestRunner::WebTestProxy::requestPointerLock):
3025         (WebTestRunner::WebTestProxy::requestPointerUnlock):
3026         (WebTestRunner::WebTestProxy::isPointerLocked):
3027         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.cpp.
3028         (WebTestRunner::MockWebSpeechInputController::MockWebSpeechInputController):
3029         (WebTestRunner):
3030         (WebTestRunner::MockWebSpeechInputController::~MockWebSpeechInputController):
3031         (WebTestRunner::MockWebSpeechInputController::setDelegate):
3032         (WebTestRunner::MockWebSpeechInputController::addMockRecognitionResult):
3033         (WebTestRunner::MockWebSpeechInputController::setDumpRect):
3034         (WebTestRunner::MockWebSpeechInputController::clearResults):
3035         (WebTestRunner::MockWebSpeechInputController::startRecognition):
3036         (WebTestRunner::MockWebSpeechInputController::cancelRecognition):
3037         (WebTestRunner::MockWebSpeechInputController::stopRecording):
3038         (WebTestRunner::MockWebSpeechInputController::speechTaskFired):
3039         (WebTestRunner::MockWebSpeechInputController::SpeechTask::SpeechTask):
3040         (WebTestRunner::MockWebSpeechInputController::SpeechTask::stop):
3041         (WebTestRunner::MockWebSpeechInputController::SpeechTask::runIfValid):
3042         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechInputController.h.
3043         (WebKit):
3044         (WebTestRunner):
3045         (MockWebSpeechInputController):
3046         (WebTestRunner::MockWebSpeechInputController::taskList):
3047         (SpeechTask):
3048         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp.
3049         (WebTestRunner::MockWebSpeechRecognizer::MockWebSpeechRecognizer):
3050         (WebTestRunner):
3051         (WebTestRunner::MockWebSpeechRecognizer::~MockWebSpeechRecognizer):
3052         (WebTestRunner::MockWebSpeechRecognizer::setDelegate):
3053         (WebTestRunner::MockWebSpeechRecognizer::start):
3054         (WebTestRunner::MockWebSpeechRecognizer::stop):
3055         (WebTestRunner::MockWebSpeechRecognizer::abort):
3056         (WebTestRunner::MockWebSpeechRecognizer::addMockResult):
3057         (WebTestRunner::MockWebSpeechRecognizer::setError):
3058         (WebTestRunner::MockWebSpeechRecognizer::startTaskQueue):
3059         (WebTestRunner::MockWebSpeechRecognizer::clearTaskQueue):
3060         (WebTestRunner::MockWebSpeechRecognizer::StepTask::runIfValid):
3061         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Renamed from Tools/DumpRenderTree/chromium/MockWebSpeechRecognizer.h.
3062         (WebKit):
3063         (WebTestRunner):
3064         (MockWebSpeechRecognizer):
3065         (WebTestRunner::MockWebSpeechRecognizer::wasAborted):
3066         (WebTestRunner::MockWebSpeechRecognizer::client):
3067         (WebTestRunner::MockWebSpeechRecognizer::handle):
3068         (WebTestRunner::MockWebSpeechRecognizer::taskList):
3069         (Task):
3070         (WebTestRunner::MockWebSpeechRecognizer::Task::Task):
3071         (WebTestRunner::MockWebSpeechRecognizer::Task::~Task):
3072         (StepTask):
3073         (WebTestRunner::MockWebSpeechRecognizer::StepTask::StepTask):
3074         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3075         (WebTestRunner::TestInterfaces::TestInterfaces):
3076         (WebTestRunner::TestInterfaces::windowOpened):
3077         (WebTestRunner):
3078         (WebTestRunner::TestInterfaces::windowClosed):
3079         (WebTestRunner::TestInterfaces::windowList):
3080         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
3081         (TestInterfaces):
3082         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3083         (WebTestRunner::TestRunner::TestRunner):
3084         (WebTestRunner::TestRunner::reset):
3085         (WebTestRunner::TestRunner::requestPointerLock):
3086         (WebTestRunner):
3087         (WebTestRunner::TestRunner::requestPointerUnlock):
3088         (WebTestRunner::TestRunner::isPointerLocked):
3089         (WebTestRunner::TestRunner::didAcquirePointerLockInternal):
3090         (WebTestRunner::TestRunner::didNotAcquirePointerLockInternal):
3091         (WebTestRunner::TestRunner::didLosePointerLockInternal):
3092         (WebTestRunner::TestRunner::windowCount):
3093         (WebTestRunner::TestRunner::setMockDeviceOrientation):
3094         (WebTestRunner::TestRunner::numberOfPendingGeolocationPermissionRequests):
3095         (WebTestRunner::TestRunner::setGeolocationPermission):
3096         (WebTestRunner::TestRunner::setMockGeolocationPosition):
3097         (WebTestRunner::TestRunner::setMockGeolocationPositionUnavailableError):
3098         (WebTestRunner::TestRunner::addMockSpeechInputResult):
3099         (WebTestRunner::TestRunner::setMockSpeechInputDumpRect):
3100         (WebTestRunner::TestRunner::addMockSpeechRecognitionResult):
3101         (WebTestRunner::TestRunner::setMockSpeechRecognitionError):
3102         (WebTestRunner::TestRunner::wasMockSpeechRecognitionAborted):
3103         (WebTestRunner::TestRunner::didAcquirePointerLock):
3104         (WebTestRunner::TestRunner::didNotAcquirePointerLock):
3105         (WebTestRunner::TestRunner::didLosePointerLock):
3106         (WebTestRunner::TestRunner::setPointerLockWillRespondAsynchronously):
3107         (WebTestRunner::TestRunner::setPointerLockWillFailSynchronously):
3108         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3109         (WebTestRunner):
3110         (TestRunner):
3111         (HostMethodTask):
3112         (WebTestRunner::TestRunner::HostMethodTask::HostMethodTask):
3113         (WebTestRunner::TestRunner::HostMethodTask::runIfValid):
3114         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3115         (WebTestRunner::WebTestProxyBase::~WebTestProxyBase):
3116         (WebTestRunner::WebTestProxyBase::setInterfaces):
3117         (WebTestRunner::WebTestProxyBase::setDelegate):
3118         (WebTestRunner::WebTestProxyBase::reset):
3119         (WebTestRunner::WebTestProxyBase::captureTree):
3120         (WebTestRunner::WebTestProxyBase::geolocationClientMock):
3121         (WebTestRunner):
3122         (WebTestRunner::WebTestProxyBase::deviceOrientationClientMock):
3123         (WebTestRunner::WebTestProxyBase::speechInputControllerMock):
3124         (WebTestRunner::WebTestProxyBase::speechRecognizerMock):
3125         (WebTestRunner::WebTestProxyBase::geolocationClient):
3126         (WebTestRunner::WebTestProxyBase::speechInputController):
3127         (WebTestRunner::WebTestProxyBase::speechRecognizer):
3128         (WebTestRunner::WebTestProxyBase::deviceOrientationClient):
3129         (WebTestRunner::WebTestProxyBase::requestPointerLock):
3130         (WebTestRunner::WebTestProxyBase::requestPointerUnlock):
3131         (WebTestRunner::WebTestProxyBase::isPointerLocked):
3132         * DumpRenderTree/chromium/WebViewHost.cpp:
3133         (WebViewHost::reset):
3134         * DumpRenderTree/chromium/WebViewHost.h:
3135         (WebKit):
3136         (WebViewHost):
3137
3138 2013-02-20  Andras Becsi  <andras.becsi@digia.com>
3139
3140         [Qt] Make debug builds possible on 32bit Linux
3141         https://bugs.webkit.org/show_bug.cgi?id=110231
3142
3143         Reviewed by Tor Arne Vestbø.
3144
3145         Use the stabs format for debug builds to make the object files
3146         a bit smaller so that they can be linked on a 32bit system.
3147
3148         * qmake/mkspecs/features/unix/default_post.prf:
3149
3150 2013-02-20  Takashi Toyoshima  <toyoshim@chromium.org>
3151
3152         Unreviewed. Add myself to watch lists.
3153
3154         * Scripts/webkitpy/common/config/committers.py:
3155         * Scripts/webkitpy/common/config/watchlist:
3156
3157 2013-02-19  Joshua Bell  <jsbell@chromium.org>
3158
3159         Remove warning from run-bindings-tests
3160         https://bugs.webkit.org/show_bug.cgi?id=110285
3161
3162         Reviewed by Kentaro Hara.
3163
3164         Since wkrev.com/139331 run-bindings-tests has been harmlessly emitting
3165         "Unknown option: idlattributesfile". That option was removed from
3166         bindings/scripts/preprocess-idls.pl but was still being passed by
3167         the test script. Remove it.
3168
3169         * Scripts/webkitpy/bindings/main.py:
3170         (BindingsTests.generate_supplemental_dependency): Remove unused arg.
3171
3172 2013-02-19  Elliott Sprehn  <esprehn@chromium.org>
3173
3174         Unreviewed. Add myself to watch lists.
3175
3176         * Scripts/webkitpy/common/config/committers.py:
3177         * Scripts/webkitpy/common/config/watchlist:
3178
3179 2013-02-19  Hans Muller  <hmuller@adobe.com>
3180
3181         Unreviewed, corrected primary email.
3182
3183         * Scripts/webkitpy/common/config/committers.py:
3184
3185 2013-02-19  Hans Muller  <hmuller@adobe.com>
3186
3187         Unreviewed. Adding myself as a committer.
3188
3189         * Scripts/webkitpy/common/config/committers.py:
3190
3191 2013-02-19  Pravin D  <pravind@webkit.org>
3192
3193         Unreviewed, changing primary email.
3194
3195         * Scripts/webkitpy/common/config/committers.py:
3196
3197 2013-02-19  Alan Cutter  <alancutter@chromium.org>
3198
3199         REGRESSION: Sheriffbot is failing to process rollout requests
3200         https://bugs.webkit.org/show_bug.cgi?id=106945
3201
3202         Reviewed by Adam Barth.
3203
3204         Modified Sheriffbot build script to track the svn repo from git and add bot user details to the git repo config file.
3205         This resolves problems when Sheriffbot attempts to perform a rollout request.
3206
3207         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3208         * EWSTools/configure-git-svn.sh: Copied from Tools/EWSTools/create-webkit-git.
3209         * EWSTools/configure-git-user.sh: Renamed from Tools/EWSTools/create-webkit-git.
3210
3211 2013-02-19  Claudio Saavedra  <csaavedra@igalia.com>
3212
3213         Unreviewed build fix.
3214
3215         * efl/jhbuild.modules:
3216         * gtk/jhbuild.modules:
3217
3218         Bump harfbuzz module to 0.9.7. See related bug 110145.
3219
3220 2013-02-19  Simon Hausmann  <simon.hausmann@digia.com>
3221
3222         [Qt] Skip the build with a warning if certain tools cannot be found in the PATH
3223         https://bugs.webkit.org/show_bug.cgi?id=110215
3224
3225         Reviewed by Tor Arne Vestbø.
3226
3227         Check that gperf, python, ruby, perl, bison and flex are in the PATH before
3228         continuing the build. Otherwise skip with an error message explaining which
3229         programs are missing from the build.
3230
3231         * qmake/mkspecs/features/configure.prf:
3232         * qmake/mkspecs/features/functions.prf:
3233
3234 2013-02-19  Sheriff Bot  <webkit.review.bot@gmail.com>
3235
3236         Unreviewed, rolling out r143319.
3237         http://trac.webkit.org/changeset/143319
3238         https://bugs.webkit.org/show_bug.cgi?id=110214
3239
3240         Causes build issues on win32 (Requested by carewolf on
3241         #webkit).
3242
3243         * qmake/mkspecs/features/features.pri:
3244
3245 2013-02-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3246
3247         [Qt] Enable MathML
3248         https://bugs.webkit.org/show_bug.cgi?id=110205
3249
3250         Reviewed by Simon Hausmann.
3251
3252         * qmake/mkspecs/features/features.pri:
3253
3254 2013-02-17  Andrei Bucur  <abucur@adobe.com>
3255
3256         Unreviewed. Adding myself as a committer.
3257
3258         * Scripts/webkitpy/common/config/committers.py:
3259
3260 2013-02-19  Hajime Morrita  <morrita@google.com>
3261
3262         Unreviewed, updated spelling of my name.
3263
3264         * Scripts/webkitpy/common/config/committers.py:
3265
3266 2013-02-18  Ilya Tikhonovsky  <loislo@chromium.org>
3267
3268         Unreviewed. Adjust expectations.
3269
3270         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp:
3271         (TestWebKitAPI::TEST):
3272
3273 2013-02-18  Zan Dobersek  <zdobersek@igalia.com>
3274
3275         Unreviewed GTK gardening.
3276
3277         * Scripts/run-gtk-tests:
3278         (TestRunner): Skipped the ReloadPageAfterCrash unit test as it is flakily timing out.
3279
3280 2013-02-18  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3281
3282         [Qt][WK2] Remove duped test name and append new test in project file
3283         https://bugs.webkit.org/show_bug.cgi?id=110117
3284
3285         A new WK2 API test has landed recently (ResizeWindowAfterCrash), this patch will
3286         add this test into the runnable test suite and remove a duped test in project file.
3287
3288         Reviewed by Jocelyn Turcotte.
3289
3290         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
3291
3292 2013-02-18  Jochen Eisinger  <jochen@chromium.org>
3293
3294         [chromium] remove log spew from dumpAllBackForwardLists
3295         https://bugs.webkit.org/show_bug.cgi?id=110108
3296
3297         Reviewed by Nico Weber.
3298
3299         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3300
3301 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3302
3303         [EFL][WK2] Disable failing API tests
3304         https://bugs.webkit.org/show_bug.cgi?id=110081
3305
3306         Reviewed by Kenneth Rohde Christiansen.
3307
3308         Disable DOMWindowExtensionBasic WK2 test on EFL port as it times out.
3309
3310         * TestWebKitAPI/PlatformEfl.cmake:
3311
3312 2013-02-18  Simon Hausmann  <simon.hausmann@digia.com>
3313
3314         [Qt] Disable the build if certain configure checks fail
3315         https://bugs.webkit.org/show_bug.cgi?id=110094
3316
3317         Reviewed by Tor Arne Vestbø.
3318
3319         Allow for the build to be skipped (clear out SUBDIRS) if certain
3320         configure conditions aren't met.
3321
3322         * qmake/mkspecs/features/configure.prf:
3323
3324 2013-02-15  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3325
3326         [Qt][WK2] Support WK2 API tests
3327         https://bugs.webkit.org/show_bug.cgi?id=109843
3328
3329         Reviewed by Jocelyn Turcotte.
3330
3331         * TestWebKitAPI/DerivedSources.pri: Added.
3332         * TestWebKitAPI/InjectedBundle.pri: Added.
3333         * TestWebKitAPI/PlatformWebView.h:
3334         * TestWebKitAPI/TestWebKitAPI.pri:
3335         * TestWebKitAPI/TestWebKitAPI.pro:
3336         * TestWebKitAPI/Tests/JavaScriptCore/JavaScriptCore.pro: Added.
3337         * TestWebKitAPI/Tests/WTF/WTF.pro:
3338         * TestWebKitAPI/Tests/WebKit2/WebKit2.pro: Added.
3339         * TestWebKitAPI/qt/PlatformUtilitiesQt.cpp:
3340         (TestWebKitAPI::Util::sleep):
3341         (TestWebKitAPI::Util::createInjectedBundlePath):
3342         (TestWebKitAPI::Util::createURLForResource):
3343         (TestWebKitAPI::Util::isKeyDown):
3344         (Util):
3345         * TestWebKitAPI/qt/PlatformWebViewQt.cpp: Added.
3346         (TestWebKitAPI):
3347         (WrapperWindow):
3348         (TestWebKitAPI::WrapperWindow::WrapperWindow):
3349         (TestWebKitAPI::WrapperWindow::handleStatusChanged):
3350         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3351         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3352         (TestWebKitAPI::PlatformWebView::resizeTo):
3353         (TestWebKitAPI::PlatformWebView::page):
3354         (TestWebKitAPI::PlatformWebView::focus):
3355         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3356         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
3357         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3358         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3359         * TestWebKitAPI/qt/main.cpp:
3360         (addQtWebProcessToPath):
3361         (main):
3362
3363 2013-02-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3364
3365         [EFL][WK2] Refactor Ewk_Favicon code and stop relying on internal C++ API
3366         https://bugs.webkit.org/show_bug.cgi?id=108598
3367
3368         Reviewed by Kenneth Rohde Christiansen.
3369
3370         Update EFL's MiniBrowser to make use of new Ewk_Favicon API.
3371
3372         * MiniBrowser/efl/main.c:
3373         (update_view_favicon):
3374         (on_view_favicon_changed):
3375         (window_create):
3376
3377 2013-02-18  Zoltan Arvai  <zarvai@inf.u-szeged.hu>
3378
3379         Unreviewed. Add myself as a committer.
3380
3381         * Scripts/webkitpy/common/config/committers.py:
3382
3383 2013-02-13  Ilya Tikhonovsky  <loislo@chromium.org>
3384
3385         Web Inspector: Native Memory Instrumentation: reportLeaf method doesn't report the leaf node properly.
3386         https://bugs.webkit.org/show_bug.cgi?id=109554
3387
3388         In some cases leaves have no pointer so with the old schema we can't generate nodeId for them because we
3389         can't insert 0 into hashmap. It happens when we call addPrivateBuffer method.
3390
3391         Drive by fix: I introduced a client interface for the HeapGraphSerializer.
3392         It helps me to do the tests for the serializer.
3393
3394         Reviewed by Yury Semikhatsky.
3395
3396         It is covered by newly added tests in TestWebKitAPI.
3397
3398         * TestWebKitAPI/TestWebKitAPI.gypi:
3399         * TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Added.
3400         (TestWebKitAPI):
3401         (HeapGraphReceiver):
3402         (TestWebKitAPI::HeapGraphReceiver::HeapGraphReceiver):
3403         (TestWebKitAPI::HeapGraphReceiver::printGraph):
3404         (TestWebKitAPI::HeapGraphReceiver::dumpNodes):
3405         (TestWebKitAPI::HeapGraphReceiver::dumpEdges):
3406         (TestWebKitAPI::HeapGraphReceiver::dumpBaseToRealNodeId):
3407         (TestWebKitAPI::HeapGraphReceiver::dumpStrings):
3408         (TestWebKitAPI::HeapGraphReceiver::serializer):
3409         (TestWebKitAPI::HeapGraphReceiver::chunkPart):
3410         (TestWebKitAPI::HeapGraphReceiver::dumpPart):
3411         (TestWebKitAPI::HeapGraphReceiver::stringValue):
3412         (TestWebKitAPI::HeapGraphReceiver::intValue):
3413         (TestWebKitAPI::HeapGraphReceiver::nodeToString):
3414         (TestWebKitAPI::HeapGraphReceiver::edgeToString):
3415         (TestWebKitAPI::HeapGraphReceiver::printNode):
3416         (Helper):
3417         (TestWebKitAPI::Helper::Helper):
3418         (TestWebKitAPI::Helper::addNode):
3419         (TestWebKitAPI::Helper::addEdge):
3420         (TestWebKitAPI::Helper::done):
3421         (Object):
3422         (TestWebKitAPI::Helper::Object::Object):
3423         (TestWebKitAPI::TEST):
3424         (Owner):
3425         (TestWebKitAPI::Owner::Owner):
3426         (TestWebKitAPI::Owner::reportMemoryUsage):
3427
3428 2013-02-18  Ryosuke Niwa  <rniwa@webkit.org>
3429
3430         WKR build fix. Always use ascii since irclib/ircbot doesn't support unicode.
3431
3432         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3433         (NewCommitBot.next_work_item):
3434
3435 2013-02-17  Kangil Han  <kangil.han@samsung.com>
3436
3437         Unreviewed. Add myself as a committer.
3438
3439         * Scripts/webkitpy/common/config/committers.py:
3440
3441 2013-02-17  Alan Cutter  <alancutter@chromium.org>
3442
3443         GCE EWS bots are all offline
3444         https://bugs.webkit.org/show_bug.cgi?id=110069
3445
3446         Reviewed by Eric Seidel.
3447
3448         Updated GCE EWS build scripts to use the gcel-10-04-v20130104 image instead of the obsoleted ubuntu-10-04-v20120621.
3449         This changed the ephemeral disk path to /dev/sdb and required /etc/hosts to be chmodded to 644.
3450
3451         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
3452         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
3453         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh:
3454         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh:
3455         * EWSTools/build-vm.sh:
3456         * EWSTools/start-queue.sh:
3457
3458 2013-02-18  Eugene Klyuchnikov  <eustas@chromium.org>
3459
3460         Unreviewed, add myself to commiters.py.
3461
3462         * Scripts/webkitpy/common/config/committers.py:
3463
3464 2013-02-17  Dongwoo Joshua Im  <dw.im@samsung.com>
3465
3466         Unreviewed. Add myself as a committer.
3467
3468         * Scripts/webkitpy/common/config/committers.py:
3469
3470 2013-02-17  Roger Fong  <roger_fong@apple.com>
3471
3472         Unreviewed. Fix typo in script.
3473
3474         * EWSTools/start-queue-win.sh:
3475
3476 2013-02-15  Roger Fong  <roger_fong@apple.com>
3477
3478         Pass in bot name as parameter to start-queue-win script.
3479         https://bugs.webkit.org/show_bug.cgi?id=109998.
3480
3481         Reviewed by Darin Adler.
3482
3483         * EWSTools/start-queue-win.sh:
3484
3485 2013-02-18  Byungwoo Lee  <bw80.lee@samsung.com>
3486
3487         Unreviewed. Add myself as a committer.
3488
3489         * Scripts/webkitpy/common/config/committers.py:
3490
3491 2013-02-17  Ryosuke Niwa  <rniwa@webkit.org>
3492
3493         Rename new-commit-bot to WKR to disambiguate it from commit-queue.
3494
3495         Rubber-stamped by Andreas Kling.
3496
3497         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3498         (NewCommitBot.begin_work_queue):
3499
3500 2013-02-16  Glenn Adams  <glenn@skynav.com>
3501
3502         Unreviewed. Add myself as a committer.
3503
3504         * Scripts/webkitpy/common/config/committers.py:
3505
3506 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
3507
3508         new-commit-bot should report the full name of committer and reviewer instead of just nicks
3509         https://bugs.webkit.org/show_bug.cgi?id=110040
3510
3511         Reviewed by Darin Adler.
3512
3513         Have it report names like "Ryosuke Niwa (rniwa)" instead of just "rniwa".
3514
3515         * Scripts/webkitpy/tool/commands/newcommitbot.py:
3516         (NewCommitBot):
3517         (NewCommitBot._summarize_commit_log):
3518         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
3519
3520 2013-02-16  Ryosuke Niwa  <rniwa@webkit.org>
3521
3522         We need a CIA replacement
3523         https://bugs.webkit.org/show_bug.cgi?id=110008
3524
3525         Reviewed by Andreas Kling.
3526
3527         Added new-commit-bot.
3528
3529         * Scripts/webkitpy/tool/bot/queueengine.py:
3530         (QueueEngine.__init__):
3531         (QueueEngine): Made the sleep tiem configurable.
3532         (QueueEngine._sleep_message):
3533         (QueueEngine._sleep):
3534         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3535         (QueueEngineTest.test_sleep_message):
3536         * Scripts/webkitpy/tool/commands/__init__.py:
3537         * Scripts/webkitpy/tool/commands/newcommitbot.py: Added.
3538         (PingPong): Added. Implements the ping pong protocol.
3539         (NewCommitBot):
3540         (NewCommitBot.begin_work_queue):
3541         (NewCommitBot.work_item_log_path):
3542         (NewCommitBot.next_work_item): Update SVN revision and report any new commits made since
3543         the last time we checked the head SVN revision.
3544         (NewCommitBot.process_work_item):
3545         (NewCommitBot._update_checkout): svn up.
3546         (NewCommitBot._new_svn_revisions): Returns a range of new revisions.
3547         (NewCommitBot._summarize_commit_log): Summarize a commit log to be posted on IRC.
3548         (NewCommitBot.handle_unexpected_error):
3549         (NewCommitBot.handle_script_error):
3550         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Added.
3551         (NewCommitBotTest.test_summarize_commit_log_basic): Tests for summarizing non-rollout commits.
3552         (NewCommitBotTest.test_summarize_commit_log_rollout): Tests for summarizing rollouts.
3553         * Scripts/webkitpy/tool/commands/queues.py:
3554         (AbstractQueue.execute):
3555         * Scripts/webkitpy/tool/commands/queuestest.py:
3556         (MockQueueEngine.__init__):
3557         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
3558         (SheriffBotTest.test_command_aliases):
3559         * Scripts/webkitpy/tool/main.py:
3560         (WebKitPatch):
3561
3562 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
3563
3564         [chromium] initialize all variables of TestRunner classes
3565         https://bugs.webkit.org/show_bug.cgi?id=110013
3566
3567         Reviewed by Adam Barth.
3568
3569         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
3570         (WebTestRunner::TestInterfaces::TestInterfaces):
3571         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3572         (WebTestRunner::TestRunner::TestRunner):
3573
3574 2013-02-16  Jochen Eisinger  <jochen@chromium.org>
3575
3576         [chromium] destroy the TestPlugin when the destroy() method is invoked.
3577         https://bugs.webkit.org/show_bug.cgi?id=110012
3578
3579         Reviewed by Adam Barth.
3580
3581         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp:
3582         (WebTestRunner::TestPlugin::destroy):
3583
3584 2013-02-15  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3585
3586         [WK2] Write a test to simulate crashed WebProcess followed by Window resize
3587         https://bugs.webkit.org/show_bug.cgi?id=109842
3588
3589         Reviewed by Benjamin Poulain.
3590
3591         This new test will kill WebProcess, followed by next resizing the Window. It helps to
3592         identify if the port is testing for WebPageProxy data members state (e.g. DrawingArea, Frames)
3593         before making calls into them.
3594
3595         * TestWebKitAPI/GNUmakefile.am:
3596         * TestWebKitAPI/PlatformEfl.cmake:
3597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3598         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp: Added.
3599         (TestWebKitAPI):
3600         (TestWebKitAPI::didFinishLoad):
3601         (TestWebKitAPI::didCrash):
3602         (TestWebKitAPI::TEST):
3603
3604 2013-02-15  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3605
3606         Add CString operators for comparison with const char*
3607         https://bugs.webkit.org/show_bug.cgi?id=109947
3608
3609         Reviewed by Darin Adler.
3610
3611         Add tests for WTF::CString's comparison operators.
3612
3613         * TestWebKitAPI/Tests/WTF/CString.cpp:
3614         (TEST):
3615
3616 2013-02-15  Zan Dobersek  <zdobersek@igalia.com>
3617
3618         webkit-patch suggest-reviewers should limit itself to 5 reviewers
3619         https://bugs.webkit.org/show_bug.cgi?id=107528
3620
3621         Reviewed by Eric Seidel.
3622
3623         * Scripts/webkitpy/common/checkout/checkout.py:
3624         (Checkout.suggested_reviewers): Iterate through the sorted commit info list,
3625         scraping reviewers from the commit information and in the end producing a list
3626         of reviewers that's sorted from the most to least recent activity of any reviewer
3627         that has reviewed or authored patches for the changed files.
3628         * Scripts/webkitpy/tool/commands/queries.py:
3629         (SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
3630         the same logic.
3631         (SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
3632         defaults to False.
3633         * Scripts/webkitpy/tool/steps/suggestreviewers.py:
3634         (SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
3635         on a single line.  Only ask for CC-ing the suggested reviewers to the bug if the
3636         bug ID is located in the command's state.
3637
3638 2013-02-15  Pablo Flouret  <pablof@motorola.com>
3639
3640         Unreviewed. Add myself as a committer.
3641
3642         * Scripts/webkitpy/common/config/committers.py:
3643
3644 2013-02-15  Roger Fong  <roger_fong@apple.com>
3645
3646         Get Win EWS startup script checked into tree so we can make changes to all the EWS bots more easily.
3647
3648         * EWSTools/start-queue-win.sh: Added.
3649
3650 2013-02-15  Andreas Kling  <akling@apple.com>
3651
3652         Unbreak webkit-patch -- can't have both Committer and Contributor entry with same e-mail address.
3653
3654         * Scripts/webkitpy/common/config/committers.py:
3655
3656 2013-02-15  Joanmarie Diggs  <jdiggs@igalia.com>