2011-04-11 Dirk Pranke <dpranke@chromium.org>
[WebKit-https.git] / Tools / ChangeLog
1 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
2
3         Reviewed by Adam Roben.
4
5         new-run-webkit-tests: fix crash when running under windows cmd.exe
6         https://bugs.webkit.org/show_bug.cgi?id=58197
7
8         We would intermittently crash when running NRWT directly under
9         cmd.exe on windows because we were sharing the stdin file
10         descriptor between the python process and the http server.
11         cmd.exe really didn't like that, and there was no reason to
12         share the descriptor, so we now use a PIPE instead.
13
14         * Scripts/webkitpy/layout_tests/port/http_server.py:
15
16 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
17
18         Reviewed by Ojan Vafai.
19
20         new-run-webkit-tests: add unit tests for Port.diff_image()
21         https://bugs.webkit.org/show_bug.cgi?id=58196
22
23         Add the unit tests for the fix in bug 58195.
24
25         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
26         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
27         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
28
29 2011-04-11  Dirk Pranke  <dpranke@chromium.org>
30
31         Reviewed by Tony Chang.
32
33         new-run-webkit-tests: implement support for audio, take two
34         https://bugs.webkit.org/show_bug.cgi?id=58195
35
36         Attempt to re-land the fix for bug 58101 (which was initially
37         landed in r83330, but rolled out). This is the same patch but
38         fixes crashes in Port.diff_image() caused by the change for
39         empty image files being None instead of ''.
40
41         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
42         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
43         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
44         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
45         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
46         * Scripts/webkitpy/layout_tests/port/base.py:
47         * Scripts/webkitpy/layout_tests/port/chromium.py:
48         * Scripts/webkitpy/layout_tests/port/dryrun.py:
49         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
50         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
51         * Scripts/webkitpy/layout_tests/port/test.py:
52         * Scripts/webkitpy/layout_tests/port/webkit.py:
53
54 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
55
56         Reviewed by Xan Lopez.
57
58         [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
59         https://bugs.webkit.org/show_bug.cgi?id=57854
60
61         Implement missing features in GTK's DRT.
62
63         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
64         (indexRangeInTable): New helper function to get the range string
65         for the current cell inside the parent table, either from the
66         point of view of rows or columns.
67         (AccessibilityUIElement::rowIndexRange): Implemented by relying on
68         the new helper function indexRangeInTable().
69         (AccessibilityUIElement::columnIndexRange): Ditto.
70
71 2011-04-11  Mario Sanchez Prada  <msanchez@igalia.com>
72
73         Reviewed by Chris Fleizach.
74
75         [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
76         https://bugs.webkit.org/show_bug.cgi?id=57826
77
78         Implement missing feature in GTK's DRT.
79
80         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
81         (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
82         relying on the analogous function from the AtkTable interface.
83
84 2011-04-05  Timothy Hatcher  <timothy@apple.com>
85
86         Fix the extract-localizable-strings script errors that started after
87         WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
88
89         * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
90
91 2011-04-11  Tony Chang  <tony@chromium.org>
92
93         Reviewed by Eric Seidel.
94
95         fix crc computation on 64 bit machines
96         https://bugs.webkit.org/show_bug.cgi?id=58243
97
98         unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
99
100         * DumpRenderTree/CyclicRedundancyCheck.cpp:
101         (makeCrcTable):
102         (computeCrc):
103         * DumpRenderTree/CyclicRedundancyCheck.h:
104         * DumpRenderTree/PixelDumpSupport.cpp:
105         (appendIntToVector):
106         (convertChecksumToPNGComment):
107
108 2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
109
110         Reviewed by Eric Seidel.
111
112         Require no undefined symbols during compilation.
113
114         [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
115         https://bugs.webkit.org/show_bug.cgi?id=54896
116
117         Add -Wl,--no-undefined to catch missing symbols early.
118
119         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
120         * WebKitTestRunner/qt/WebKitTestRunner.pro:
121
122 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
123
124         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
125
126         * wx/build/settings.py:
127
128 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
129
130         [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
131
132         * wx/build/settings.py:
133
134 2011-04-10  David Levin  <levin@chromium.org>
135
136         Reviewed by Dimitri Glazkov.
137
138         REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
139         https://bugs.webkit.org/show_bug.cgi?id=58201
140
141         * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
142         and filed bug 58202.
143
144 2011-04-09  David Levin  <levin@chromium.org>
145
146         Unreviewed, rolling out r83394.
147         http://trac.webkit.org/changeset/83394
148         https://bugs.webkit.org/show_bug.cgi?id=53625
149
150         Patch was incorrect as noted in the bug.
151
152         * Scripts/svn-apply:
153
154 2011-04-09  David Levin  <levin@chromium.org>
155
156         Reviewed by Adam Barth.
157
158         svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
159         https://bugs.webkit.org/show_bug.cgi?id=53625
160
161         * Scripts/svn-apply: Ensure that the portions of patches
162         which are for vcproj/vsprops files has DOS line endings.
163
164 2011-04-09  Dirk Pranke  <dpranke@chromium.org>
165
166         Reviewed by Tony Chang.
167
168         It looks like NRWT has not been stopping DRT/TestShell
169         instances properly on windows, probably for a long time.
170         This would go a long way to explaining why we often have
171         processes lying around :)
172
173         https://bugs.webkit.org/show_bug.cgi?id=57807
174
175         * Scripts/webkitpy/layout_tests/port/chromium.py:
176         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
177
178 2011-04-09  Keith Kyzivat  <keith.kyzivat@nokia.com>
179
180         Reviewed by Laszlo Gombos.
181
182         [Qt] Don't link against fontconfig or X11 if embedded
183         https://bugs.webkit.org/show_bug.cgi?id=58104
184
185         * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
186         * QtTestBrowser/QtTestBrowser.pro: ditto
187         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
188         * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
189
190 2011-04-08  Jon Honeycutt  <jhoneycutt@apple.com>
191
192         http/tests/loading/preload-append-scan.php is failing on Windows
193         https://bugs.webkit.org/show_bug.cgi?id=58178
194
195         Reviewed by Brian Weinstein.
196
197         * DumpRenderTree/win/DumpRenderTree.cpp:
198         (lastPathComponent):
199         Use CFURL API to find the last path component, rather than
200         PathFindFileName(), because the latter will include the query string.
201
202 2011-04-08  Jian Li  <jianli@chromium.org>
203
204         Unreviewed, rolling out r83327, r83330 since these patches are very
205         likely to break chromium webkit mac10.6 builders.
206
207         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
208         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
209         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
210         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
211         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
212         * Scripts/webkitpy/layout_tests/port/base.py:
213         * Scripts/webkitpy/layout_tests/port/chromium.py:
214         * Scripts/webkitpy/layout_tests/port/dryrun.py:
215         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
216         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
217         * Scripts/webkitpy/layout_tests/port/test.py:
218         * Scripts/webkitpy/layout_tests/port/webkit.py:
219
220 2011-04-08  Vincent Scheib  <scheib@chromium.org>
221
222         Reviewed by Eric Seidel.
223
224         add chromium-gpu-linux-x86_64 to the recognized list of ports
225         https://bugs.webkit.org/show_bug.cgi?id=58099
226
227         Add chromium-gpu-linux-x86_64 to fix assert.
228
229         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
230
231 2011-04-08  Alpha Lam  <hclam@chromium.org>
232
233         Unreviewed, rolling out r83335.
234         http://trac.webkit.org/changeset/83335
235         https://bugs.webkit.org/show_bug.cgi?id=53556
236
237         GTK and QT bots are broken
238
239         * Scripts/build-webkit:
240
241 2011-04-07  Anna Cavender  <annacc@chromium.org>
242
243         Reviewed by Eric Carlson.
244
245         Setup ENABLE(TRACK) feature define
246         https://bugs.webkit.org/show_bug.cgi?id=53556
247
248         * Scripts/build-webkit:
249
250 2011-04-08  Dirk Pranke  <dpranke@chromium.org>
251
252         Reviewed by Adam Roben.
253
254         new-run-webkit-tests: configure a NRWT test bot for Mac SL
255         https://bugs.webkit.org/show_bug.cgi?id=58114
256
257         This change removes the old new-run-webkit-tests entry and
258         updates it for a new test-only bot.
259
260         * BuildSlaveSupport/build.webkit.org-config/config.json:
261
262 2011-04-08  Dominic Cooney  <dominicc@google.com>
263
264         Reviewed by Adam Roben.
265
266         Make layoutTestController.shadowRoot return null, not undefined,
267         when its argument is invalid.
268         https://bugs.webkit.org/show_bug.cgi?id=58121
269
270         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
271         (LayoutTestController::shadowRoot):
272         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
273         (WTR::LayoutTestController::shadowRoot):
274
275 2011-04-08  Pere Martir  <pere.martir4@gmail.com>
276
277         Reviewed by Adam Roben.
278
279         Locate NSTD.EXE in 64-bit Windows
280         https://bugs.webkit.org/show_bug.cgi?id=57847
281
282         * Scripts/old-run-webkit-tests:
283
284 2011-04-08  Adam Roben  <aroben@apple.com>
285
286         Qt build fix
287
288         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
289
290 2011-04-07  Adam Roben  <aroben@apple.com>
291
292         Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
293
294         Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
295         plugin
296
297         Reviewed by Anders Carlsson.
298
299         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
300         (pluginLogWithArguments): Moved code to format and log the message here...
301         (pluginLog): ...from here.
302
303         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
304
305         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
306         (PluginTest::log): Added. Calls through to pluginLogWithArguments.
307
308         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
309
310         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
311         (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
312         to begin.
313         (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
314         constructor.
315         (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
316         can be used to invoke our setWillBeDestroyed function.
317         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
318         anything unexpected happens).
319         (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
320         NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
321         NPP_SetWindow was *not* called during destruction.
322         (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
323         method, setWillBeDestroyed.
324         (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
325         object.
326
327         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
328         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
329         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
330         * GNUmakefile.am:
331         Added new test.
332
333         * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
334         WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
335
336 2011-04-08  Mario Sanchez Prada  <msanchez@igalia.com>
337
338         Reviewed by Martin Robinson.
339
340         [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
341         https://bugs.webkit.org/show_bug.cgi?id=58039
342
343         Implement missing functions in GTK's DRT.
344
345         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
346         (AccessibilityUIElement::increment): Implemented.
347         (AccessibilityUIElement::decrement): Implemented.
348
349 2011-04-08  Dominic Cooney  <dominicc@google.com>
350
351         Reviewed by Kent Tamura.
352
353         Make WK2 layoutTestController.shadowRoot return undefined, not
354         null, when its argument is not an element.
355         https://bugs.webkit.org/show_bug.cgi?id=58121
356
357         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
358         (WTR::LayoutTestController::shadowRoot):
359
360 2011-04-07  Dirk Pranke  <dpranke@chromium.org>
361
362         Reviewed by Mihai Parparita.
363
364         Change reference port for Mac GPU baselines from
365         Leopard to SnowLeopard, XP to Win7, and Linux-x86
366         to Linux x86-64.
367
368         https://bugs.webkit.org/show_bug.cgi?id=58099
369
370         * Scripts/webkitpy/layout_tests/port/chromium.py:
371
372 2011-04-07  Andrew Scherkus  <scherkus@chromium.org>
373
374         Revert ENABLE_TRACK patch due to compile failures.
375
376         * Scripts/build-webkit:
377
378 2011-04-07  Tony Chang  <tony@chromium.org>
379
380         Reviewed by Eric Seidel.
381
382         update DRT to embed checksums in png files
383         https://bugs.webkit.org/show_bug.cgi?id=57871
384
385         We insert the bytes for the comment in printPNG rather than at encode
386         time because each platform does its own PNG encoding (either using CG
387         or cairo).  Putting this in pringPNG avoids having to duplicate this
388         code, although it's not as clean as doing it at encoding time.
389
390         We insert the comment right after the IHDR chunk of the PNG.
391
392         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
393         * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
394         (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
395         (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
396         * DumpRenderTree/CyclicRedundancyCheck.h: Added.
397         * DumpRenderTree/PixelDumpSupport.cpp:
398         (dumpWebViewAsPixelsAndCompareWithExpected):
399         (convertChecksumToPNGComment): Generate the bytes to insert.
400         (printPNG): Insert the png comment before the first IDAT section.
401         * DumpRenderTree/PixelDumpSupport.h:
402         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
403         (printPNG):
404         (dumpBitmap):
405         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
406         (printPNG):
407         (dumpBitmap):
408         * DumpRenderTree/win/DumpRenderTree.vcproj:
409         * GNUmakefile.am:
410
411 2011-04-07  Jeff Miller  <jeffm@apple.com>
412
413         Reviewed by Adam Roben.
414
415         Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
416         https://bugs.webkit.org/show_bug.cgi?id=58058
417
418         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
419         (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
420
421 2011-04-07  Chang Shu  <cshu@webkit.org>
422
423         Reviewed by Darin Adler.
424
425         WebKitTestRunner needs layoutTestController.isPageBoxVisible
426         https://bugs.webkit.org/show_bug.cgi?id=42695
427
428         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
429         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
430         (WTR::LayoutTestController::isPageBoxVisible):
431         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
432
433 2011-04-07  Adam Roben  <aroben@apple.com>
434
435         Build fix
436
437         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
438
439 2011-04-07  Adam Roben  <aroben@apple.com>
440
441         Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
442
443         commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
444         (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
445         hook we have, so we have to do our work there. I added a new addCustomURLs method which can
446         be overridden by subclasses to provide extra URLs before we call up to the base class (after
447         which adding more URLs is no longer possible).
448
449         Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
450         bot results page
451
452         Reviewed by John Sullivan.
453
454         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
455         (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
456         (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
457         method is never called for MasterShellCommands.
458         (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
459         with this method (which is).
460
461 2011-04-07  Adam Roben  <aroben@apple.com>
462
463         Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
464
465         This matches how most of our other build steps work, so is good just for improving
466         consistency between build steps. It should also make it possible for
467         ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
468         trying to do this in finished() after we had called up to the base class, but that was
469         apparently too late to add more URLs.)
470
471         Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
472         results page
473
474         Reviewed by John Sullivan.
475
476         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
477         (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
478         call setText to get the right text to show up for this step. This matches how most of our
479         other build steps work.
480         (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
481         This is how most of our other build steps work.
482         (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
483         function, to match the base class.
484
485 2011-04-07  Adam Barth  <abarth@webkit.org>
486
487         Reviewed by Maciej Stachowiak.
488
489         webkit-patch shouldn't state the whole working copy when calling check-webkit-style
490         https://bugs.webkit.org/show_bug.cgi?id=58022
491
492         Previously, we were ignoring the args variable!  This patch fixes the
493         regression introduced in http://trac.webkit.org/changeset/82771.
494
495         * Scripts/webkitpy/tool/commands/download_unittest.py:
496         * Scripts/webkitpy/tool/mocktool.py:
497         * Scripts/webkitpy/tool/steps/checkstyle.py:
498
499 2011-04-07  Maciej Stachowiak  <mjs@apple.com>
500
501         Reviewed by Adam Barth.
502
503         REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
504         https://bugs.webkit.org/show_bug.cgi?id=58017
505
506         * Scripts/webkitpy/common/checkout/scm.py:
507         * Scripts/webkitpy/common/checkout/scm_unittest.py:
508
509 2011-04-06  Chang Shu  <cshu@webkit.org>
510
511         Reviewed by Darin Adler.
512
513         WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
514         https://bugs.webkit.org/show_bug.cgi?id=57984
515
516         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
517         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
518         (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
519         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
520
521 2011-04-06  Chris Rogers  <crogers@google.com>
522
523         Reviewed by Tony Chang.
524
525         Add web audio support to DumpRenderTree (mac port)
526         https://bugs.webkit.org/show_bug.cgi?id=57969
527
528         * DumpRenderTree/LayoutTestController.cpp:
529         (LayoutTestController::LayoutTestController):
530         (setEncodedAudioDataCallback):
531         (LayoutTestController::staticFunctions):
532         * DumpRenderTree/LayoutTestController.h:
533         (LayoutTestController::dumpAsAudio):
534         (LayoutTestController::setDumpAsAudio):
535         (LayoutTestController::encodedAudioData):
536         (LayoutTestController::setEncodedAudioData):
537         * DumpRenderTree/mac/DumpRenderTree.mm:
538         (dumpAudio):
539         (dump):
540
541 2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>
542
543         Reviewed by Kenneth Rohde Christiansen.
544
545         [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
546         https://bugs.webkit.org/show_bug.cgi?id=56086
547
548         Add the missing method.
549
550         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
551         (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
552         * DumpRenderTree/qt/DumpRenderTreeQt.h:
553         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
554         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
555
556 2011-04-06  Dai Mikurube  <dmikurube@chromium.org>
557
558         Reviewed by David Levin.
559
560         Add QUOTA build flag for unified quota API
561         https://bugs.webkit.org/show_bug.cgi?id=57918
562
563         * Scripts/build-webkit: Added QUOTA build flag
564
565 2011-04-06  Dirk Pranke  <dpranke@chromium.org>
566
567         Reviewed by Tony Chang.
568
569         Adjust the apple webkit port's default timeout to match
570         old-run-webkit-tests at 35 seconds.
571
572         https://bugs.webkit.org/show_bug.cgi?id=37738
573
574         * Scripts/webkitpy/layout_tests/port/mac.py:
575
576 2011-04-06  Scott Cameron  <sccameron@rim.com>
577
578         Reviewed by Eric Seidel.
579
580         Remove global variable $httpdPath and replace with the return value of
581         getHTTPDPath().  Also remove unnecessary calls to getHTTPDPath().
582         https://bugs.webkit.org/show_bug.cgi?id=53499
583
584         * Scripts/run-iexploder-tests:
585         * Scripts/webkitperl/httpd.pm:
586
587 2011-04-06  Kevin Ollivier  <kevino@theolliviers.com>
588
589         Reviewed by Darin Adler.
590
591         Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
592         
593         https://bugs.webkit.org/show_bug.cgi?id=27551
594         
595         * DumpRenderTree/config.h:
596         * WebKitAPITest/config.h:
597         * WebKitTestRunner/config.h:
598
599 2011-04-06  Tony Chang  <tony@chromium.org>
600
601         Reviewed by Darin Adler.
602
603         teach run-webkit-tests to read checksums from png files
604         https://bugs.webkit.org/show_bug.cgi?id=57993
605
606         * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
607           no .checksum and look for the checksum in there.
608
609 2011-04-06  David Dorwin  <ddorwin@chromium.org>
610
611         Reviewed by David Levin.
612
613         Enable fullscreen layout tests for Chromium
614         https://bugs.webkit.org/show_bug.cgi?id=55726
615
616         Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
617
618         * DumpRenderTree/chromium/WebPreferences.cpp:
619         (WebPreferences::applyTo):
620
621 2011-04-06  Adam Roben  <aroben@apple.com>
622
623         Add a "view leaks" link to builds on SnowLeopard Intel Leaks
624
625         Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
626
627         Reviewed by David Kilzer.
628
629         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
630         (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
631         build's results directory here...
632         (ExtractTestResults.finished): ...from here.
633         (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
634         (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
635         leaks" link to point to Leaks Viewer for this build.
636         (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
637         but it seemed good to add for consistency with BuildAndTestFactory.
638         (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
639         (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
640         that we'll get a "view leaks" link.
641
642 2011-04-06  Zan Dobersek  <zandobersek@gmail.com>
643
644         Reviewed by Eric Seidel.
645
646         [Gtk] plugins/set-status.html fails
647         https://bugs.webkit.org/show_bug.cgi?id=57844
648
649         Allow an empty status text to be dumped.
650
651         * DumpRenderTree/gtk/DumpRenderTree.cpp:
652         (webViewStatusBarTextChanged):
653
654 2011-04-06  Chang Shu  <cshu@webkit.org>
655
656         Reviewed by Darin Adler.
657
658         WebKitTestRunner needs layoutTestController.pageNumberForElementById
659         https://bugs.webkit.org/show_bug.cgi?id=42329
660
661         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
662         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
663         (WTR::LayoutTestController::pageNumberForElementById):
664         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
665
666 2011-04-06  Sergio Villar Senin  <svillar@igalia.com>
667
668         Reviewed by Martin Robinson.
669
670         [GTK] DumpRenderTree: do not try to free NULL SoupURIs
671         https://bugs.webkit.org/show_bug.cgi?id=57932
672
673         Some Layout tests have invalid URIs that do not generate valid
674         SoupURI instances. Do not try to free those NULL SoupURIs.
675
676         * DumpRenderTree/gtk/DumpRenderTree.cpp:
677         (willSendRequestCallback):
678
679 2011-04-06  Csaba Osztrogonác  <ossy@webkit.org>
680
681         Reviewed by Andreas Kling.
682
683         ORWT shouldn't generate diff files for tests without expected files
684         https://bugs.webkit.org/show_bug.cgi?id=57846
685
686         * Scripts/old-run-webkit-tests:
687
688 2011-04-05  Kevin Ollivier  <kevino@theolliviers.com>
689
690         [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
691         to deps.
692
693         * wx/install-unix-extras:
694
695 2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
696
697         Unreviewed, rolling out r82978, r82999, and r83001.
698         http://trac.webkit.org/changeset/82978
699         http://trac.webkit.org/changeset/82999
700         http://trac.webkit.org/changeset/83001
701         https://bugs.webkit.org/show_bug.cgi?id=57913
702
703         Does not work in Python 2.5 (Requested by abarth on #webkit).
704
705         * Scripts/webkitpy/common/system/executive.py:
706         * Scripts/webkitpy/common/system/executive_unittest.py:
707
708 2011-04-05  Chang Shu  <cshu@webkit.org>
709
710         Reviewed by Darin Adler.
711
712         WebKitTestRunner needs layoutTestController.numberOfPages
713         https://bugs.webkit.org/show_bug.cgi?id=42694
714
715         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
716         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
717         (WTR::LayoutTestController::numberOfPages):
718         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
719
720 2011-04-05  Tony Chang  <tony@chromium.org>
721
722         Reviewed by Mihai Parparita.
723
724         [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
725         https://bugs.webkit.org/show_bug.cgi?id=57889
726
727         * Scripts/webkitpy/layout_tests/port/chromium.py:
728         * Scripts/webkitpy/layout_tests/port/test.py:
729         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
730
731 2011-04-05  Adam Barth  <abarth@webkit.org>
732
733         Silly with statement, from the future!
734
735         * Scripts/webkitpy/common/system/executive.py:
736
737 2011-04-05  Adam Barth  <abarth@webkit.org>
738
739         Reviewed by Tony Chang.
740
741         Don't use Exception.message because it's deprecated
742         https://bugs.webkit.org/show_bug.cgi?id=57892
743
744         Suppress the warning for now.  When we move to Python 3, we might need
745         to something more dramatic.
746
747         * Scripts/webkitpy/common/system/executive.py:
748
749 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
750
751         Reviewed by Ojan Vafai.
752
753         Add builders.js to dashboard file list
754         https://bugs.webkit.org/show_bug.cgi?id=57899
755
756         Add file added by http://crrev.com/80538 to dashboard file list.
757
758         * TestResultServer/handlers/dashboardhandler.py:
759
760 2011-04-05  MORITA Hajime  <morrita@google.com>
761
762         Reviewed by Adam Barth.
763
764         webkit-patch should print git's stderr when git svn dcommit fail
765         http://webkit.org/b/57861
766
767         * Scripts/webkitpy/common/checkout/scm.py:
768
769 2011-04-05  Mihai Parparita  <mihaip@chromium.org>
770
771         Reviewed by Tony Chang.
772
773         Add --baseline-search-path to NRWT
774         https://bugs.webkit.org/show_bug.cgi?id=56233
775         
776         Add NRWT option to specify additional directories to look for baselines
777         (will be used by hardware GPU bots which will have local per-bot
778         expectations for some tests)
779
780         * Scripts/webkitpy/common/system/filesystem_mock.py:
781         * Scripts/webkitpy/layout_tests/port/base.py:
782         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
783         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
784
785 2011-04-05  Adam Roben  <aroben@apple.com>
786
787         Strip off /results.html from results URLs before trying to load leaks files from them
788
789         r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
790         files, rather than pointing to the directory that contains them. This is more convenient for
791         people browsing build.webkit.org, but confused Leaks Viewer.
792
793         Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
794         list don't work
795
796         Reviewed by Joseph Pecoraro.
797
798         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
799         (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
800
801 2011-04-05  Carol Szabo  <carol@webkit.org>
802
803         Unreviewed.
804
805         Updated my info in committers.py
806
807         Scripts\webkitpy\common\config\committers.py 
808
809 2011-04-05  Csaba Osztrogonác  <ossy@webkit.org>
810
811         Reviewed by Laszlo Gombos.
812
813         [Qt] Make WebKitLibraries optional for building QtWebKit
814         https://bugs.webkit.org/show_bug.cgi?id=57542
815
816         * Scripts/build-webkit:
817
818 2011-04-05  Chang Shu  <cshu@webkit.org>
819
820         Reviewed by Laszlo Gombos.
821
822         [Qt] MiniBrowser defaultUrl does not work
823         https://bugs.webkit.org/show_bug.cgi?id=57021
824
825         Match the behavior and coding of MiniBrowser to QtTestBrowser.
826         * MiniBrowser/qt/main.cpp:
827         (main):
828
829 2011-04-05  Jade Han  <jade.han@nokia.com>
830
831         Reviewed by Laszlo Gombos.
832
833         [Qt] [Symbian] Disable WebKitTestRunner for Symbian
834         https://bugs.webkit.org/show_bug.cgi?id=54977
835
836         This change is a preparation to enable building webkit2 for Symbian.
837         Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
838
839         * Tools.pro:
840
841 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
842
843         Reviewed by Andreas Kling.
844
845         [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
846         https://bugs.webkit.org/show_bug.cgi?id=57832
847
848         Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
849
850         * MiniBrowser/qt/UrlLoader.cpp:
851         (UrlLoader::UrlLoader):
852
853 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
854
855         [Qt] Linux Release minimal build fix after r82919.
856
857         * MiniBrowser/qt/BrowserWindow.cpp:
858         (BrowserWindow::loadURLListFromFile):
859         * QtTestBrowser/launcherwindow.cpp:
860         (LauncherWindow::loadURLListFromFile):
861
862 2011-04-05  Zoltan Horvath  <zoltan@webkit.org>
863
864         Reviewed by Andreas Kling.
865
866         [Qt] Make URL loader accessible from testbrowser's menus
867         https://bugs.webkit.org/show_bug.cgi?id=57823
868
869         Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
870
871         * MiniBrowser/qt/BrowserWindow.cpp:
872         (BrowserWindow::BrowserWindow):
873         (BrowserWindow::loadURLListFromFile):
874         (BrowserWindow::~BrowserWindow):
875         * MiniBrowser/qt/BrowserWindow.h:
876         * QtTestBrowser/launcherwindow.cpp:
877         (LauncherWindow::LauncherWindow):
878         (LauncherWindow::~LauncherWindow):
879         (LauncherWindow::createChrome):
880         (LauncherWindow::loadURLListFromFile):
881         * QtTestBrowser/launcherwindow.h:
882
883 2011-04-04  Sam Weinig  <sam@webkit.org>
884
885         Reviewed by Brian Weinstein.
886
887         Remove duplicate API from WKContext
888         <rdar://problem/8727879>
889         https://bugs.webkit.org/show_bug.cgi?id=57815
890
891         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
892         * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
893         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
894         Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
895
896 2011-04-04  Tony Chang  <tony@chromium.org>
897
898         Reviewed by Ojan Vafai.
899
900         [chromium] don't write .checksum files if a fallback platform has an embedded checksum
901         https://bugs.webkit.org/show_bug.cgi?id=57783
902
903         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
904         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
905
906 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
907
908         [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
909         from WebKitBuild.
910
911         * Scripts/webkitdirs.pm:
912
913 2011-04-04  Martin Robinson  <mrobinson@igalia.com>
914
915         Reviewed by Gustavo Noronha Silva.
916
917         [GTK] WebGL support
918         https://bugs.webkit.org/show_bug.cgi?id=31517
919
920         Add support to the DRT for turning on WebGL when a layout tests requests it.
921
922         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
923         (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
924
925 2011-04-04  Chang Shu  <cshu@webkit.org>
926
927         Reviewed by Darin Adler.
928
929         WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
930         https://bugs.webkit.org/show_bug.cgi?id=57572
931
932         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
933         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
934         (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
935         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
936
937 2011-04-04  Keith Kyzivat  <keith.kyzivat@nokia.com>
938
939         Reviewed by Csaba Osztrogonác.
940
941         [Qt] DumpRenderTree breaks compilation in some uClibc environments
942         https://bugs.webkit.org/show_bug.cgi?id=57602
943
944         * DumpRenderTree/qt/main.cpp:
945         (get_backtrace):
946
947 2011-04-04  Kevin Ollivier  <kevino@theolliviers.com>
948
949         [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
950
951         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
952         (LayoutTestController::shadowRoot):
953
954 2011-04-04  Pavel Podivilov  <podivilov@chromium.org>
955
956         Unreviewed, fix exception in rebaseline tool.
957
958         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
959
960 2011-04-02  Beth Dakin  <bdakin@apple.com>
961
962         Rubber-stamped by Geoff Garen.
963
964         For Dan!
965         * DumpRenderTree/mac/DumpRenderTree.mm:
966         (resetWebViewToConsistentStateBeforeTesting):
967
968 2011-04-02  Beth Dakin  <bdakin@apple.com>
969
970         Rubber-stamped by Geoff Garen.
971
972         Need to reset the scale, much like zoom.
973         * DumpRenderTree/mac/DumpRenderTree.mm:
974         (resetWebViewToConsistentStateBeforeTesting):
975
976 2011-04-02  Sam Weinig  <sam@webkit.org>
977
978         Reviewed by Beth Dakin.
979
980         https://bugs.webkit.org/show_bug.cgi?id=57605
981         Frame::pageScaleFactor() should not affect getBoundingClientRect() or 
982         getClientRects()
983         -and corresponding-
984         <rdar://problem/9194541>
985
986         Add DRT support for the scaleWebView SPI.
987         * DumpRenderTree/mac/EventSendingController.mm:
988         (+[EventSendingController isSelectorExcludedFromWebScript:]):
989         (+[EventSendingController webScriptNameForSelector:]):
990         (-[EventSendingController scalePageBy:atX:andY:]):
991         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
992         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
993         (WTR::EventSendingController::scalePageBy):
994         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
995         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
996         (WTR::InjectedBundlePage::reset):
997
998 2011-04-02  Dominic Cooney  <dominicc@google.com>
999
1000         Reviewed by Martin Robinson.
1001
1002         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1003         https://bugs.webkit.org/show_bug.cgi?id=57551
1004
1005         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1006         (LayoutTestController::shadowRoot):
1007
1008 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1009
1010         Reviewed by Eric Seidel.
1011
1012         Remove AbstractStep._run_script and move script names to ports.py
1013         https://bugs.webkit.org/show_bug.cgi?id=57704
1014
1015         Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
1016
1017         * Scripts/webkitpy/common/config/ports.py:
1018         * Scripts/webkitpy/tool/commands/download_unittest.py:
1019         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1020         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1021         * Scripts/webkitpy/tool/steps/abstractstep.py:
1022         * Scripts/webkitpy/tool/steps/checkstyle.py:
1023         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1024         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1025         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1026
1027 2011-04-02  Patrick Gansterer  <paroga@webkit.org>
1028
1029         Reviewed by Eric Seidel.
1030
1031         Emulate shebang on Win32
1032         https://bugs.webkit.org/show_bug.cgi?id=55927
1033
1034         Scripts on Windows work only if they are called with the explicit interpreter.
1035         Read the first line of scripts to detect the correct executable.
1036
1037         * Scripts/webkitpy/common/config/ports.py:
1038         * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
1039         * Scripts/webkitpy/common/system/executive_unittest.py:
1040
1041 2011-04-01  Adam Barth  <abarth@webkit.org>
1042
1043         Reviewed by Eric Seidel.
1044
1045         apos entities shouldn't show up in ChangeLogs when using webkit-patch
1046         https://bugs.webkit.org/show_bug.cgi?id=57692
1047
1048         Previously, we were using BeautifulSoup to process XML from
1049         bugs.webkit.org, but that's incorrect.  We should be using
1050         BeautifulStoneSoup to process the XML.  We were getting the &apos;
1051         entity wrong because &apos; is an XML entity but not an HTML entity.
1052
1053         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1054         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1055
1056 2011-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1057
1058         Unreviewed, rolling out r82721.
1059         http://trac.webkit.org/changeset/82721
1060         https://bugs.webkit.org/show_bug.cgi?id=57687
1061
1062         This patch introduced assertion failures on the GTK+ bots.
1063         (Requested by mrobinson on #webkit).
1064
1065         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1066         (LayoutTestController::shadowRoot):
1067
1068 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1069
1070         Unreviewed buildfix.
1071
1072         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1073         https://bugs.webkit.org/show_bug.cgi?id=55074
1074
1075         * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
1076         (The isWK2() function removes it from @ARGV, but not from @options.)
1077
1078 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
1079
1080         Reviewed by Csaba Osztrogonác.
1081
1082         [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
1083         https://bugs.webkit.org/show_bug.cgi?id=57666
1084
1085         * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
1086
1087 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1088
1089         Reviewed by Adam Barth.
1090
1091         new-run-webkit-tests: fix feature detection, skipped platform lists on mac
1092
1093         We apparently never implemented the code to skip tests based on
1094         what was compiled into DRT. Also, change the logic used to skip
1095         platform directories to match what old-run-webkit-tests does: 
1096         skip every test not in a directory in the baseline search path.
1097
1098         https://bugs.webkit.org/show_bug.cgi?id=57662
1099
1100         * Scripts/webkitpy/layout_tests/port/mac.py:
1101         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1102         * Scripts/webkitpy/layout_tests/port/webkit.py:
1103
1104 2011-03-29  Mark Rowe  <mrowe@apple.com>
1105
1106         Reviewed by Jon Honeycutt.
1107
1108         <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
1109
1110         Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
1111
1112         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1113         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1114         * Scripts/webkitpy/layout_tests/port/mac.py:
1115         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1116
1117 2011-04-01  Chang Shu  <cshu@webkit.org>
1118
1119         Reviewed by Csaba Osztrogonác.
1120
1121         [Qt][WK2] Build Webkit2 using "-2" option on Qt
1122         https://bugs.webkit.org/show_bug.cgi?id=55074
1123
1124         * Scripts/build-webkit:
1125
1126 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1127
1128         Reviewed by Tony Chang.
1129
1130         new-run-webkit-tests: remove spurious port version override in webkit.py
1131         base.py provides a default implementation so this is just
1132         breaking things.
1133
1134         https://bugs.webkit.org/show_bug.cgi?id=57667
1135
1136         * Scripts/webkitpy/layout_tests/port/webkit.py:
1137         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1138
1139 2011-04-01  Csaba Osztrogonác  <ossy@webkit.org>
1140
1141         Reviewed by Adam Roben.
1142
1143         Make view results on waterfall direct link to results.html
1144         https://bugs.webkit.org/show_bug.cgi?id=57671
1145
1146         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
1147         * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
1148
1149 2011-04-01  Sam Weinig  <sam@webkit.org>
1150
1151         Fix windows build.
1152
1153         * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
1154         (TestWebKitAPI::TEST):
1155         * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
1156         (TestWebKitAPI::flushMessages):
1157
1158 2011-04-01  Sam Weinig  <sam@webkit.org>
1159
1160         Reviewed by Adam Roben.
1161
1162         Add adoptWK to WKRetainPtr.h
1163         https://bugs.webkit.org/show_bug.cgi?id=57670
1164
1165         * TestWebKitAPI/PlatformUtilities.h:
1166         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
1167         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
1168         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
1169         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
1170         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
1171         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1172         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
1173         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
1174         (TestWebKitAPI::createSessionStateContainingFormData):
1175         * WebKitTestRunner/StringFunctions.h:
1176         Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
1177
1178 2011-04-01  Sam Weinig  <sam@webkit.org>
1179
1180         Reviewed by Adam Roben.
1181
1182         Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
1183
1184         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1185         (WTR::LayoutTestController::shadowRoot):
1186         Make judicious use of adoptWK().
1187
1188 2011-04-01  Sam Weinig  <sam@webkit.org>
1189
1190         Reviewed by Timothy Hatcher.
1191
1192         Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
1193
1194         * Scripts/extract-localizable-strings:
1195
1196 2011-04-01  Anders Carlsson  <andersca@apple.com>
1197
1198         Reviewed by Sam Weinig.
1199
1200         Shockwave plug-in doesn't accept mouse events
1201         https://bugs.webkit.org/show_bug.cgi?id=57653
1202         <rdar://problem/8483273>
1203
1204         Add a plug-in test.
1205
1206         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1207         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
1208         (PluginTest::indicateTestFailure):
1209         Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
1210
1211         (PluginTest::NPN_ConvertPoint):
1212         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
1213         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
1214         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
1215         Call indicateTestFailure.
1216
1217         * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
1218         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
1219         (ConvertPoint::ConvertPoint):
1220         (ConvertPoint::testConvert):
1221         (ConvertPoint::NPP_New):
1222
1223 2011-04-01  Dominic Cooney  <dominicc@google.com>
1224
1225         Reviewed by Martin Robinson.
1226
1227         Add layoutTestController.shadowRoot to GTK DumpRenderTree.
1228         https://bugs.webkit.org/show_bug.cgi?id=57551
1229
1230         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
1231         (LayoutTestController::shadowRoot):
1232
1233 2011-04-01  Sam Weinig  <sam@webkit.org>
1234
1235         Reviewed by Anders Carlsson.
1236
1237         WebKitTestRunner needs layoutTestController.shadowRoot
1238         https://bugs.webkit.org/show_bug.cgi?id=57661
1239
1240         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1241         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1242         (WTR::LayoutTestController::shadowRoot):
1243         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1244         Implement layoutTestController.shadowRoot for WebKit2.
1245
1246 2011-04-01  Chang Shu  <cshu@webkit.org>
1247
1248         Reviewed by Darin Adler.
1249
1250         WebKitTestRunner needs layoutTestController.setDatabaseQuota
1251         https://bugs.webkit.org/show_bug.cgi?id=57568
1252
1253         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1254         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1255         (WTR::LayoutTestController::setDatabaseQuota):
1256         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1257
1258 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1259
1260         Reviewed by Tony Chang.
1261
1262         This patch completes the cleanup of
1263         rebaseline-chromium-webkit-tests to work with all of the
1264         variants of a platform (we can now rebaseline gpu- and non-gpu
1265         files at the same time).
1266
1267         When the rebaselining is complete, any lines declared as
1268         REBASELINE in the expectations file that matches a test that was
1269         actually rebaselined will be deleted, even if only one of the
1270         variants was actually rebaselined. This may cause odd problems,
1271         but is better than where we're at today.
1272
1273         This change removes the -g flag and deprecates -w. The -g flag is gone
1274         because GPU baselines are handled just like any other variant.
1275         The -w flag is deprecated because this tool now only works
1276         against the canaries, since that's the only place we have a full
1277         set of bots. It will be trivial to change this to
1278         build.webkit.org if we decide that's where we want them to be.
1279
1280         Also, this patch deletes a lot of cruft that is no longer needed
1281         in the test_expectations code and the port-specific code.
1282
1283         https://bugs.webkit.org/show_bug.cgi?id=55191
1284
1285         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1286         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1287         * Scripts/webkitpy/layout_tests/port/base.py:
1288         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1289         * Scripts/webkitpy/layout_tests/port/chromium.py:
1290         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1291         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1292         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1293         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1294         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1295         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1296         * Scripts/webkitpy/layout_tests/port/mac.py:
1297         * Scripts/webkitpy/layout_tests/port/test.py:
1298         * Scripts/webkitpy/layout_tests/port/webkit.py:
1299         * Scripts/webkitpy/layout_tests/port/win.py:
1300         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1301         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1302
1303 2011-04-01  Dirk Pranke  <dpranke@chromium.org>
1304
1305         Reviewed by Adam Barth.
1306
1307         rebaseline-chromium-webkit-tests does not work correctly with
1308         version-specific baselines. This patch updates the tool to use
1309         all of the version-specific bots on the canaries, and will now
1310         attempt to rebaseline all of the versions by default, although
1311         it will not update both GPU and CPU versions.
1312         
1313         Also, it will no longer modify the test_expectations.txt file
1314         *at all*. You will have to manually delete the REBASELINE lines
1315         after running the tool and determining that it did what you
1316         wanted it to do. This should be fixed in a separate bug - see
1317         webkit bug #55191.
1318
1319         https://bugs.webkit.org/show_bug.cgi?id=55608
1320
1321         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1322         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1323         * Scripts/webkitpy/layout_tests/port/chromium.py:
1324         * Scripts/webkitpy/layout_tests/port/test.py:
1325         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1326         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1327
1328 2011-03-31  Tony Chang  <tony@chromium.org>
1329
1330         Reviewed by Ojan Vafai.
1331
1332         [chromium] update the rebaseline tool to know about pngs with checksums
1333         https://bugs.webkit.org/show_bug.cgi?id=57481
1334
1335         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
1336         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1337
1338 2011-04-01  Adam Roben  <aroben@apple.com>
1339
1340         Retrieve revision numbers from the build's got_revision property in Leaks Viewer
1341
1342         Previously, we were getting the revision of the first revision that triggered a build.
1343         Choosing the last revision would have been more accurate. But got_revision is what is used
1344         everywhere else on build.webkit.org, and should work even when there were no changes that
1345         triggered a build (e.g., if someone clicked the Force Build button).
1346
1347         Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
1348         recent builds list
1349
1350         Reviewed by Anders Carlsson.
1351
1352         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1353         (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
1354         property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
1355
1356         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
1357         (Array.prototype.first): Added this helper function to return the first element in an array
1358         that matches the given predicate, or null if no such element exists.
1359
1360 2011-03-31  Adam Roben  <aroben@apple.com>
1361
1362         Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
1363
1364         Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
1365
1366         Reviewed by Darin Adler.
1367
1368         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1369         (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
1370         URL on its own line.
1371
1372         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1373         (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
1374         progression, and added a new test that uses a short bug URL while I was at it.
1375
1376 2011-04-01  Adam Roben  <aroben@apple.com>
1377
1378         Mark .vcproj/.vsprops/.sln files as being Windows-only
1379
1380         Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
1381
1382         Reviewed by Anders Carlsson.
1383
1384         * Scripts/webkitpy/common/config/build.py:
1385         (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
1386         directories as Windows-only.
1387
1388         * Scripts/webkitpy/common/config/build_unittest.py:
1389         (ShoulBuildTest): Added test cases for the above.
1390
1391 2011-04-01  Keith Kyzivat  <keith.kyzivat@nokia.com>
1392
1393         Reviewed by Laszlo Gombos.
1394
1395         [Qt] Build MiniBrowser for Symbian
1396         https://bugs.webkit.org/show_bug.cgi?id=56319
1397
1398         Have MiniBrowser reference it's own copy of useragentlist.txt instead
1399         of copying QtTestBrowser's.
1400         Remove Tools/MiniBrowser/DerivedSources.pro
1401         This reduces complexity in the Tools scripts due to Symbian limitations.
1402
1403         * DerivedSources.pro:
1404         * MiniBrowser/DerivedSources.pro: Removed.
1405         * MiniBrowser/MiniBrowser.qrc:
1406         * MiniBrowser/qt/MiniBrowser.pro:
1407         * Scripts/webkitdirs.pm:
1408
1409 2011-03-31  Chang Shu  <cshu@webkit.org>
1410
1411         Reviewed by Darin Adler.
1412
1413         WebKitTestRunner needs layoutTestController.clearAllDatabases
1414         https://bugs.webkit.org/show_bug.cgi?id=42540
1415
1416         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1417         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1418         (WTR::InjectedBundle::beginTesting):
1419         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1420         (WTR::LayoutTestController::clearAllDatabases):
1421         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1422
1423 2011-03-31  Chang Shu  <cshu@webkit.org>
1424
1425         Reviewed by Darin Adler.
1426
1427         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
1428         https://bugs.webkit.org/show_bug.cgi?id=42692
1429
1430         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1431
1432 2011-03-31  Darin Adler  <darin@apple.com>
1433
1434         Reviewed by Sam Weinig.
1435
1436         Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
1437         https://bugs.webkit.org/show_bug.cgi?id=57573
1438
1439         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1440         Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
1441         Removed fake definitions of keyDown and contextClick.
1442
1443         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1444         (WTR::operator==): Added. So we can compare two WKPoint structs.
1445         (WTR::parseModifier): Added.
1446         (WTR::parseModifierArray): Added.
1447         (WTR::EventSendingController::EventSendingController): Initialize the
1448         new data members.
1449         (WTR::EventSendingController::mouseDown): Added. Calls
1450         WKBundlePageSimulateMouseDown.
1451         (WTR::EventSendingController::mouseUp): Added. Calls
1452         WKBundlePageSimulateMouseUp.
1453         (WTR::EventSendingController::mouseMoveTo): Added. Calls
1454         WKBundlePageSimulateMouseMotion.
1455         (WTR::EventSendingController::leapForward): Added.
1456         (WTR::EventSendingController::updateClickCount): Added. Used by the
1457         mouseDown/Up functions to create a click count.
1458
1459         * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
1460         for the changes above.
1461
1462 2011-03-31  Sergio Villar Senin  <svillar@igalia.com>
1463
1464         Reviewed by Martin Robinson.
1465
1466         [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
1467         https://bugs.webkit.org/show_bug.cgi?id=57362
1468
1469         Do not generate DRT output if willSendRequestReturnsNull is set.
1470
1471         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1472         (willSendRequestCallback):
1473
1474 2011-03-31  Vamshikrishna.Yellenki  <vamshi@motorola.com> and Alejandro G. Castro  <alex@igalia.com>
1475
1476         Reviewed by Martin Robinson.
1477
1478         Implement MiniBrowser for Gtk port.
1479         https://bugs.webkit.org/show_bug.cgi?id=48512
1480
1481         Initial implementation of the Gtk MiniBrowser.
1482
1483         * MiniBrowser/gtk/GNUmakefile.am: Added.
1484         * MiniBrowser/gtk/main.c: Added.
1485         (activateUriEntryCallback):
1486         (destroyCallback):
1487         (goBackCallback):
1488         (goForwardCallback):
1489         (createToolbar):
1490         (createWebView):
1491         (createWindow):
1492         (argumentToURL):
1493         (main):
1494
1495 2011-03-30  Dominic Cooney  <dominicc@google.com>
1496
1497         Reviewed by Dimitri Glazkov.
1498
1499         Adds layoutTestController.shadowRoot accessor to Mac DRT.
1500         https://bugs.webkit.org/show_bug.cgi?id=57415
1501
1502         * DumpRenderTree/LayoutTestController.cpp:
1503         (shadowRootCallback):
1504         (LayoutTestController::staticFunctions):
1505         * DumpRenderTree/LayoutTestController.h:
1506         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1507         (LayoutTestController::shadowRoot):
1508         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
1509         (LayoutTestController::shadowRoot):
1510
1511 2011-03-30  Matthew Delaney  <mdelaney@apple.com>
1512
1513         Reviewed by Chris Marrin.
1514
1515         Update fast/canvas tests to avoid dumping the render tree when possible
1516         https://bugs.webkit.org/show_bug.cgi?id=57493
1517
1518         * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
1519           accelerated drawing and accelerated drawing for canvas
1520
1521 2011-03-30  Adam Roben  <aroben@apple.com>
1522
1523         Stop ignoring leaks in CGGradientCreateWithColorStops
1524
1525         Fixes <rdar://problem/7888547>.
1526
1527         Rubber-stamped by John Sullivan.
1528
1529         * Scripts/old-run-webkit-tests:
1530         (countAndPrintLeaks): Removed some code to ignore those leaks.
1531
1532 2011-03-30  Timur Iskhodzhanov  <timurrrr@google.com>
1533
1534         Reviewed by Alexey Proskuryakov.
1535
1536         Add some dynamic annotations to JavaScriptCore/wtf
1537         https://bugs.webkit.org/show_bug.cgi?id=53747
1538
1539         By using these annotations we can improve the precision of finding
1540         WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
1541         These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
1542
1543         These files don't add new functionality, so don't need extra tests.
1544
1545         * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
1546
1547 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1548
1549         Reviewed by Adam Roben.
1550
1551         Share most vsprops between Release and Production builds in releaseproduction.vsprops
1552         https://bugs.webkit.org/show_bug.cgi?id=57508
1553
1554         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1555         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
1556         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
1557         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1558         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
1559         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
1560         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1561         * DumpRenderTree/win/ImageDiffRelease.vsprops:
1562         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
1563         * FindSafari/FindSafariProduction.vsprops:
1564         * FindSafari/FindSafariRelease.vsprops:
1565         * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
1566         * FindSafari/FindSafariReleasePGO.vsprops:
1567         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1568         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
1569         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
1570         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
1571         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
1572         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1573         * WebKitAPITest/WebKitAPITestRelease.vsprops:
1574         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
1575         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1576         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
1577         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
1578         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1579         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
1580         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
1581         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1582         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
1583         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
1584         * WinLauncher/WinLauncherProduction.vsprops:
1585         * WinLauncher/WinLauncherRelease.vsprops:
1586         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
1587         * record-memory-win/record-memory-winProduction.vsprops:
1588         * record-memory-win/record-memory-winRelease.vsprops:
1589         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
1590
1591 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1592
1593         Reviewed by Adam Roben.
1594
1595         Update Windows production build logic for new production configurations
1596         https://bugs.webkit.org/show_bug.cgi?id=57494
1597
1598         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
1599         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
1600         * DumpRenderTree/win/ImageDiffProduction.vsprops:
1601         * FindSafari/FindSafariProduction.vsprops:
1602         * FindSafari/FindSafariReleasePGO.vsprops:
1603         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
1604         * WebKitAPITest/WebKitAPITestProduction.vsprops:
1605         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
1606         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
1607         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
1608         * WinLauncher/WinLauncherProduction.vsprops:
1609         * record-memory-win/record-memory-winProduction.vsprops:
1610
1611 2011-03-30  Robert Hogan  <robert@webkit.org>
1612
1613         Reviewed by Antonio Gomes.
1614
1615         [Qt] Fix LoadHTMLStringItem::invoke() after r75966
1616         Unskip http/tests/navigation/go-back-to-error-page.html
1617
1618         Also add the location of DumpRenderTreeSupportQt.h
1619         to DRT's include paths.
1620
1621         https://bugs.webkit.org/show_bug.cgi?id=52614
1622
1623         * DumpRenderTree/qt/DumpRenderTree.pro:
1624         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1625         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1626         * DumpRenderTree/qt/GCControllerQt.cpp:
1627         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1628         (LayoutTestController::queueLoadHTMLString):
1629         * DumpRenderTree/qt/LayoutTestControllerQt.h:
1630         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1631         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1632         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1633         (LoadAlternateHTMLStringItem::invoke):
1634         * DumpRenderTree/qt/WorkQueueItemQt.h:
1635         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1636         * QtTestBrowser/QtTestBrowser.pro:
1637         * QtTestBrowser/launcherwindow.h:
1638
1639 2011-03-30  Adam Barth  <abarth@webkit.org>
1640
1641         Reviewed by Adam Roben.
1642
1643         SheriffBot rollouts take too long
1644         https://bugs.webkit.org/show_bug.cgi?id=57498
1645
1646         We used to build before landing rollouts via the commit-queue to
1647         prevent further breakage, but now that our individual commit-queue
1648         machines are slower, building takes too long.  I can't remember the
1649         last time a rollout broke compile.  It seems like just landing the
1650         patch is the better trade-off.
1651
1652         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1653         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1654
1655 2011-03-30  Adam Barth  <abarth@webkit.org>
1656
1657         Remove platform/chromium-mac-snowleopard
1658         https://bugs.webkit.org/show_bug.cgi?id=57486
1659
1660         This directory no longer exists, so we can remove it from the fallback
1661         chain.
1662
1663         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1664
1665 2011-03-30  Steve Falkenburg  <sfalken@apple.com>
1666
1667         Reviewed by Adam Roben.
1668
1669         Rename Windows configuration Release_LTCG to Production for clarity
1670         https://bugs.webkit.org/show_bug.cgi?id=57465
1671
1672         * DumpRenderTree/DumpRenderTree.sln:
1673         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1674         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
1675         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
1676         * DumpRenderTree/win/DumpRenderTree.vcproj:
1677         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
1678         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
1679         * DumpRenderTree/win/ImageDiff.vcproj:
1680         * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
1681         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
1682         * FindSafari/FindSafari.vcproj:
1683         * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
1684         * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
1685         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
1686         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
1687         * MiniBrowser/MiniBrowser.vcproj:
1688         * Scripts/webkitdirs.pm:
1689         * TestWebKitAPI/win/TestWebKitAPI.sln:
1690         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
1691         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
1692         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
1693         * WebKitAPITest/WebKitAPITest.vcproj:
1694         * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
1695         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
1696         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1697         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
1698         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
1699         * WebKitTestRunner/WebKitTestRunner.sln:
1700         * WebKitTestRunner/win/InjectedBundle.vcproj:
1701         * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
1702         * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
1703         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
1704         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1705         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
1706         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
1707         * WinLauncher/WinLauncher.vcproj:
1708         * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
1709         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
1710         * record-memory-win/record-memory-win.vcproj:
1711         * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
1712         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
1713
1714 2011-03-30  MORITA Hajime  <morrita@google.com>
1715
1716         Reviewed by Dimitri Glazkov.
1717
1718         [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
1719         https://bugs.webkit.org/show_bug.cgi?id=56573
1720
1721         Added LayoutTestController.shadowRoot() to Chromium DRT.
1722
1723         * DumpRenderTree/chromium/LayoutTestController.cpp:
1724         (LayoutTestController::LayoutTestController):
1725         (LayoutTestController::shadowRoot):
1726         * DumpRenderTree/chromium/LayoutTestController.h:
1727
1728 2011-03-30  Yuta Kitamura  <yutak@chromium.org>
1729
1730         Reviewed by Kent Tamura.
1731
1732         [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
1733         https://bugs.webkit.org/show_bug.cgi?id=57430
1734
1735         * DumpRenderTree/chromium/LayoutTestController.cpp:
1736         (LayoutTestController::LayoutTestController):
1737         (LayoutTestController::setPluginsEnabled):
1738         * DumpRenderTree/chromium/LayoutTestController.h:
1739
1740 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
1741
1742         Reviewed by Adam Barth.
1743
1744         make webkit-patch upload respect -d
1745         https://bugs.webkit.org/show_bug.cgi?id=57425
1746
1747         * Scripts/webkitpy/common/checkout/scm.py:
1748         * Scripts/webkitpy/tool/steps/commit.py:
1749
1750 2011-03-30  Maciej Stachowiak  <mjs@apple.com>
1751
1752         Reviewed by Adam Barth.
1753
1754         Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
1755         https://bugs.webkit.org/show_bug.cgi?id=57429
1756
1757         * Scripts/webkitpy/common/checkout/scm.py:
1758
1759 2011-03-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1760
1761         Unreviewed, rolling out r82383.
1762         http://trac.webkit.org/changeset/82383
1763         https://bugs.webkit.org/show_bug.cgi?id=57417
1764
1765         "nrwt isn't shutting down cleanly" (Requested by dpranke on
1766         #webkit).
1767
1768         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1769         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1770         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1771
1772 2011-03-29  Kent Tamura  <tkent@chromium.org>
1773
1774         Reviewed by Dimitri Glazkov.
1775
1776         Make validation message bubble testable
1777         https://bugs.webkit.org/show_bug.cgi?id=57290
1778
1779         * DumpRenderTree/mac/DumpRenderTree.mm:
1780         (createWebViewAndOffscreenWindow): Change a setting so that validation
1781           bubbles isn't hidden automatically.
1782
1783 2011-03-29  Dirk Pranke  <dpranke@chromium.org>
1784
1785         Reviewed by Ojan Vafai.
1786
1787         new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
1788
1789         It's a bit unclear whether multiple threads or multiple
1790         processes will be a better model on windows. This change will
1791         test threads for now while we're still working out the bugs in
1792         multiple-processes.
1793
1794         https://bugs.webkit.org/show_bug.cgi?id=57410
1795
1796         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1797         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1798         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1799
1800 2011-03-29  David Levin  <levin@chromium.org>
1801
1802         Reviewed by Shinichiro Hamaji.
1803
1804         check-webkit-style confused by two ChangeLog entries in a row from same user
1805         https://bugs.webkit.org/show_bug.cgi?id=57250
1806
1807         * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
1808         * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
1809         * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
1810           It basically assumes only one ChangeLog entry is being processed because that is the standard case and
1811           checking more than that would be very messey.
1812         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
1813         * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
1814
1815 2011-03-29  Kent Tamura  <tkent@chromium.org>
1816
1817         Reviewed by Dimitri Glazkov.
1818
1819         [Mac] Enable interactive-validation tests on Mac DRT
1820         https://bugs.webkit.org/show_bug.cgi?id=57308
1821
1822         * DumpRenderTree/mac/DumpRenderTree.mm:
1823         (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
1824
1825 2011-03-29  Chang Shu  <cshu@webkit.org>
1826
1827         Reviewed by Kenneth Rohde Christiansen.
1828
1829         WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
1830         https://bugs.webkit.org/show_bug.cgi?id=42692
1831
1832         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1833         (WTR::InjectedBundle::beginTesting):
1834         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1835         (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
1836         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1837
1838 2011-03-24  Martin Robinson  <mrobinson@igalia.com>
1839
1840         Reviewed by Xan Lopez.
1841
1842         [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
1843         https://bugs.webkit.org/show_bug.cgi?id=57067
1844
1845         Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
1846         will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
1847         update DRT and pixel results as hundreds of results will need to be updated.
1848
1849         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1850         (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
1851         by overriding the theme RC/CSS files.
1852
1853 2011-03-29  Steve Falkenburg  <sfalken@apple.com>
1854
1855         Reviewed by Adam Roben.
1856
1857         Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
1858         https://bugs.webkit.org/show_bug.cgi?id=57394
1859
1860         Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
1861         InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
1862         the IDE. To avoid this, add a separate vsprops file for each project configuration that
1863         contains the required inherited property sheets.
1864
1865         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
1866         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
1867         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
1868         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
1869         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
1870         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
1871         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
1872         * DumpRenderTree/win/DumpRenderTree.vcproj:
1873         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
1874         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
1875         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
1876         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
1877         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
1878         * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
1879         * DumpRenderTree/win/ImageDiff.vcproj:
1880         * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
1881         * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
1882         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
1883         * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
1884         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
1885         * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
1886         * FindSafari/FindSafari.vcproj:
1887         * FindSafari/FindSafariDebug.vsprops: Added.
1888         * FindSafari/FindSafariDebugAll.vsprops: Added.
1889         * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
1890         * FindSafari/FindSafariRelease.vsprops: Added.
1891         * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
1892         * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
1893         * FindSafari/FindSafariReleasePGO.vsprops: Added.
1894         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
1895         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
1896         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
1897         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
1898         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
1899         * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
1900         * MiniBrowser/MiniBrowser.vcproj:
1901         * WebKitAPITest/WebKitAPITest.vcproj:
1902         * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
1903         * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
1904         * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
1905         * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
1906         * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
1907         * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
1908         * WebKitLauncherWin/WebKitLauncherWin.vcproj:
1909         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
1910         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
1911         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
1912         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
1913         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
1914         * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
1915         * WebKitTestRunner/win/InjectedBundle.vcproj:
1916         * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
1917         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
1918         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
1919         * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
1920         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
1921         * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
1922         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
1923         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
1924         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
1925         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
1926         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
1927         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
1928         * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
1929         * WinLauncher/WinLauncher.vcproj:
1930         * WinLauncher/WinLauncherDebug.vsprops: Added.
1931         * WinLauncher/WinLauncherDebugAll.vsprops: Added.
1932         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
1933         * WinLauncher/WinLauncherRelease.vsprops: Added.
1934         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
1935         * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
1936         * record-memory-win/record-memory-win.vcproj:
1937         * record-memory-win/record-memory-winDebug.vsprops: Added.
1938         * record-memory-win/record-memory-winDebugAll.vsprops: Added.
1939         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
1940         * record-memory-win/record-memory-winRelease.vsprops: Added.
1941         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
1942         * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
1943
1944 2011-03-29  Adam Barth  <abarth@webkit.org>
1945
1946         Reviewed by Darin Adler.
1947
1948         test_runner2.py can crash due to undefined variable
1949         https://bugs.webkit.org/show_bug.cgi?id=57356
1950
1951         Replace reference to undefined variable with a variable that's actually
1952         defined.  AFAICT, there's no way to test this code.
1953
1954         * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
1955
1956 2011-03-29  Tony Chang  <tony@chromium.org>
1957
1958         Reviewed by Eric Seidel.
1959
1960         cleanup rebaseline-chromium-webkit-tests
1961         https://bugs.webkit.org/show_bug.cgi?id=57375
1962
1963         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1964             - Split _extract_and_add_new_baselines into 3 functions
1965             - Reduce the amount of line wrapping (the file already has lines
1966               over 80 col, so may as well try to make the file consistent)
1967             - Remove unnecessary ()s
1968
1969 2011-03-29  Brent Fulgham  <bfulgham@webkit.org>
1970
1971         Reviewed by Adam Roben.
1972
1973         Make WinCairo a core builder.
1974         https://bugs.webkit.org/show_bug.cgi?id=57373
1975
1976         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
1977         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
1978
1979 2011-03-29  Timothy Hatcher  <timothy@apple.com>
1980
1981         Update update-webkit-localizable-strings to understand that WebKit and
1982         WebKit2 strings go in WebCore.
1983
1984         Also make extract-localizable-strings optionally use an exclude file. No individual
1985         warnings are produced about unlocalized strings when there is no exclude file. This
1986         is needed for WebCore, since there are too many bare strings.
1987
1988         https://webkit.org/b/57354
1989
1990         Reviewed by Sam Weinig.
1991
1992         * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
1993         * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
1994
1995 2011-03-29  Darin Adler  <darin@apple.com>
1996
1997         Reviewed by Adam Roben.
1998
1999         WebKit2 bundle page needs to offer generated file hooks
2000         https://bugs.webkit.org/show_bug.cgi?id=57279
2001
2002         (Land missing part of the original patch after r82289.)
2003
2004         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2005         (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
2006
2007 2011-03-29  Tony Chang  <tony@chromium.org>
2008
2009         Reviewed by Ojan Vafai.
2010
2011         [chromium] NRWT should be able to read checksums from png comments
2012         https://bugs.webkit.org/show_bug.cgi?id=57280
2013
2014         * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
2015             from a file.
2016         * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
2017         * Scripts/webkitpy/common/system/filesystem_mock.py:
2018         * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
2019             if the -checksum.txt file doesn't exist, try looking in the png.
2020         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2021         * Scripts/webkitpy/layout_tests/port/test.py:
2022         * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
2023             2k for a png comment with the checksum
2024         * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
2025
2026 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2027
2028         Rubber-stamped by Gustavo Noronha Silva.
2029
2030         [GTK] http/tests/uri/username-with-no-hostname.html fails
2031         https://bugs.webkit.org/show_bug.cgi?id=57325
2032
2033         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2034         (willSendRequestCallback): URI host value check done case-insensitively.
2035
2036 2011-03-29  Philippe Normand  <pnormand@igalia.com>
2037
2038         Reviewed by Martin Robinson.
2039
2040         [GTK] http/tests/uri/username-with-no-hostname.html fails
2041         https://bugs.webkit.org/show_bug.cgi?id=57325
2042
2043         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2044         (willSendRequestCallback): Check URI before submitting the request
2045         to WebCore.
2046
2047 2011-03-29  Noel Gordon  <noel.gordon@gmail.com>
2048
2049         Reviewed by Ojan Vafai.
2050
2051         [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
2052         https://bugs.webkit.org/show_bug.cgi?id=57303
2053
2054         * DumpRenderTree/chromium/EventSender.cpp:
2055         (EventSender::doDragDrop):
2056         (EventSender::beginDragWithFiles):
2057
2058 2011-03-29  Zoltan Horvath  <zoltan@webkit.org>
2059
2060         Reviewed by Andreas Kling.
2061
2062         [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
2063         https://bugs.webkit.org/show_bug.cgi?id=57314
2064
2065         Provide possibility to print loaded urls to the standard output.
2066
2067         * MiniBrowser/qt/BrowserWindow.cpp:
2068         (BrowserWindow::BrowserWindow):
2069         (BrowserWindow::printURL):
2070         * MiniBrowser/qt/BrowserWindow.h:
2071         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2072         (MiniBrowserApplication::handleUserOptions):
2073         * MiniBrowser/qt/MiniBrowserApplication.h:
2074         (WindowOptions::WindowOptions):
2075         * QtTestBrowser/launcherwindow.cpp:
2076         (LauncherWindow::initializeView):
2077         (LauncherWindow::printURL):
2078         (LauncherWindow::cloneWindow):
2079         * QtTestBrowser/launcherwindow.h:
2080         (WindowOptions::WindowOptions):
2081         * QtTestBrowser/main.cpp:
2082         (LauncherApplication::handleUserOptions):
2083
2084 2011-03-29  Gabor Loki  <loki@webkit.org>
2085
2086         Rubber-stamped by Csaba Osztrogonác.
2087
2088         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2089         https://bugs.webkit.org/show_bug.cgi?id=56918
2090
2091         * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
2092
2093 2011-03-28  Gabor Loki  <loki@webkit.org>
2094
2095         Reviewed by Csaba Osztrogonác.
2096
2097         [Qt] Teach build-jsc how to build JavaScriptCore on Qt
2098         https://bugs.webkit.org/show_bug.cgi?id=56918
2099
2100         * Scripts/build-jsc:
2101         * Scripts/webkitdirs.pm:
2102
2103 2011-03-28  Andrew Foster  <andrewf@chromium.org>
2104
2105         Reviewed by Ojan Vafai.
2106
2107         webkit-patch should be more intelligent about whether a bug applies to a patch
2108         Create a new function, parse_bug_id_from_changelog() which determines
2109         that a bug is related to a patch by parsing the output generated from
2110         prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
2111         the description of a patch.
2112         https://bugs.webkit.org/show_bug.cgi?id=56989
2113
2114         * Scripts/webkitpy/common/checkout/api.py:
2115         * Scripts/webkitpy/common/checkout/changelog.py:
2116         * Scripts/webkitpy/common/net/bugzilla/__init__.py:
2117         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2118         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
2119         * Scripts/webkitpy/style/checkers/changelog.py:
2120         * Scripts/webkitpy/tool/commands/upload.py:
2121
2122 2011-03-28  Maciej Stachowiak  <mjs@apple.com>
2123
2124         Revert accidentally commited change.
2125
2126         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2127         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2128
2129 2011-03-28  Tony Chang  <tony@chromium.org>
2130
2131         Reviewed by Adam Barth.
2132
2133         [chromium] have DRT write the png checksum into a png comment
2134         https://bugs.webkit.org/show_bug.cgi?id=57255
2135
2136         * DumpRenderTree/chromium/TestShell.cpp:
2137         (TestShell::dumpImage):
2138
2139 2011-03-28  Adele Peterson  <adele@apple.com>
2140
2141         Removing Qt stub, since it doesn't use the same header as the others.
2142
2143         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2144
2145 2011-03-28  Adele Peterson  <adele@apple.com>
2146
2147         Added a few more stubs.
2148
2149         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2150         (LayoutTestController::hasGrammarMarker):
2151         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2152         (LayoutTestController::hasGrammarMarker):
2153         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2154         (LayoutTestController::hasGrammarMarker):
2155
2156 2011-03-28  Adele Peterson  <adele@apple.com>
2157
2158         Build fix.
2159
2160         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2161         (LayoutTestController::hasGrammarMarker):
2162
2163 2011-03-28  Adele Peterson  <adele@apple.com>
2164
2165         Reviewed by Eric Seidel.
2166
2167         Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
2168         https://bugs.webkit.org/show_bug.cgi?id=57173
2169
2170         * DumpRenderTree/LayoutTestController.cpp:
2171         (hasGrammarMarkerCallback): Added.
2172         (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
2173         * DumpRenderTree/LayoutTestController.h:
2174         * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
2175         * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
2176
2177 2011-03-28  Csaba Osztrogonác  <ossy@webkit.org>
2178
2179         Reviewed by Benjamin Poulain.
2180
2181         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2182         https://bugs.webkit.org/show_bug.cgi?id=57087
2183
2184         Trivial typo fix after r82082.
2185
2186         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2187         (WTR::activateFonts):
2188
2189 2011-03-28  Alexis Menard  <alexis.menard@openbossa.org>
2190
2191         Reviewed by Andreas Kling.
2192
2193         Add myself to the committers list.
2194
2195         * Scripts/webkitpy/common/config/committers.py:
2196
2197 2011-03-28  Simon Fraser  <simon.fraser@apple.com>
2198
2199         Reviewed by Sam Weinig.
2200
2201         WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
2202         to link against WebKit.framework for now.
2203
2204         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2205
2206 2011-03-28  Benjamin Poulain  <benjamin.poulain@nokia.com>
2207
2208         Reviewed by Andreas Kling.
2209
2210         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2211         https://bugs.webkit.org/show_bug.cgi?id=57087
2212
2213         Disable QT_ASCII_CAST_WARNINGS for applications.
2214
2215         * DumpRenderTree/qt/DumpRenderTree.pro:
2216         * DumpRenderTree/qt/ImageDiff.pro:
2217         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2218         * MiniBrowser/qt/MiniBrowser.pro:
2219         * QtTestBrowser/QtTestBrowser.pro:
2220         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2221
2222 2011-03-28  Andreas Kling  <kling@webkit.org>
2223
2224         Reviewed by Kenneth Rohde Christiansen.
2225
2226         [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
2227         https://bugs.webkit.org/show_bug.cgi?id=57224
2228
2229         * QtTestBrowser/mainwindow.cpp:
2230         (MainWindow::buildUI):
2231         (MainWindow::onTitleChanged):
2232         * QtTestBrowser/mainwindow.h:
2233
2234 2011-03-27  Jer Noble  <jer.noble@apple.com>
2235
2236         Reviewed by Maciej Stachowiak.
2237
2238         Full Screen: disable keyboard access by default
2239         https://bugs.webkit.org/show_bug.cgi?id=56684
2240
2241         Accept the withKeyboard parameter to supportsFullScreenForElement.
2242
2243         * DumpRenderTree/mac/UIDelegate.mm:
2244         (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
2245
2246 2011-03-27  Patrick Gansterer  <paroga@webkit.org>
2247
2248         Reviewed by David Levin.
2249
2250         check-webkit-style should check ChangeLog for a valid bug number
2251         https://bugs.webkit.org/show_bug.cgi?id=57184
2252
2253         * Scripts/webkitpy/style/checker.py:
2254         * Scripts/webkitpy/style/checker_unittest.py:
2255         * Scripts/webkitpy/style/checkers/changelog.py: Added.
2256         * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
2257
2258 2011-03-27  Benjamin Poulain  <benjamin.poulain@nokia.com>
2259
2260         Reviewed by Andreas Kling.
2261
2262         [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
2263         https://bugs.webkit.org/show_bug.cgi?id=57087
2264
2265         Use explicit conversion for string to avoid depending on the default codec
2266         installed by the user code.
2267
2268         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2269         (WTR::activateFonts):
2270
2271 2011-03-26  Maciej Stachowiak  <mjs@apple.com>
2272
2273         Revert inadvertantly committed changes.
2274
2275         * Scripts/old-run-webkit-tests:
2276         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2277
2278 2011-03-26  Andreas Kling  <kling@webkit.org>
2279
2280         Reviewed by Kenneth Rohde Christiansen.
2281
2282         [Qt] Show page icons (favicons) in QtTestBrowser location bar.
2283         https://bugs.webkit.org/show_bug.cgi?id=57162
2284
2285         * QtTestBrowser/QtTestBrowser.qrc:
2286         * QtTestBrowser/favicon.png: Added.
2287         * QtTestBrowser/locationedit.cpp:
2288         (defaultPageIcon):
2289         (LocationEdit::LocationEdit):
2290         (LocationEdit::setPageIcon):
2291         (LocationEdit::resizeEvent):
2292         (LocationEdit::updateInternalGeometry):
2293         * QtTestBrowser/locationedit.h:
2294         * QtTestBrowser/mainwindow.cpp:
2295         (MainWindow::buildUI):
2296         (MainWindow::onIconChanged):
2297         (MainWindow::onLoadStarted):
2298         * QtTestBrowser/mainwindow.h:
2299
2300 2011-03-23  Martin Robinson  <mrobinson@igalia.com>
2301
2302         Reviewed by Xan Lopez.
2303
2304         [GTK] Force DumpRenderTree to use 96 DPI
2305         https://bugs.webkit.org/show_bug.cgi?id=56866
2306
2307         Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
2308         broader compatibility with WebKit2 and makes setting font sizes more straightforward.
2309
2310         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2311         (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
2312         (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
2313         (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
2314
2315 2011-03-25  Andy Estes  <aestes@apple.com>
2316
2317         Reviewed by Adele Peterson.
2318
2319         REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
2320         https://bugs.webkit.org/show_bug.cgi?id=49016
2321
2322         TestNetscapePlugIn needs to register support for an image MIME type so
2323         we can test that the embed tag prefers plug-ins to render image MIME
2324         types.
2325
2326         * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
2327         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2328         (NP_GetMIMEDescription): Ditto.
2329         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
2330
2331 2011-03-25  Jessie Berlin  <jberlin@apple.com>
2332
2333         Reviewed by Sam Weinig.
2334
2335         WebKit2: Need to be able to set and get the Cookie Storage Policy.
2336         https://bugs.webkit.org/show_bug.cgi?id=50780
2337
2338         Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
2339
2340         The test is named "CookieManager" so that we can eventually exercise more of the
2341         CookieManager functionality in the test.
2342
2343         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
2344         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
2345         Assert that the policy returned is equal to the policy set in
2346         didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
2347         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
2348         Set the policy to something different than the user's policy and get the policy again.
2349         (TestWebKitAPI::didFinishLoadForFrame):
2350         Get the user's policy so that it can be restored at the end of the test.
2351         (TestWebKitAPI::TEST):
2352         Load about:blank so that the Web Process gets instatiated (needed to get the
2353         CookieManager).
2354
2355         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2356         Add CookieManager.cpp.
2357
2358 2011-03-24  Kevin Ollivier  <kevino@theolliviers.com>
2359
2360         [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
2361
2362         * wx/build/settings.py:
2363
2364 2011-03-24  Ilya Sherman  <isherman@chromium.org>
2365
2366         Reviewed by Adam Roben.
2367
2368         Implement layoutTestController.setAutoFilled in DRT on Windows
2369         https://bugs.webkit.org/show_bug.cgi?id=56828
2370
2371         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2372         (LayoutTestController::setAutofilled): Implemented.
2373
2374 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
2375
2376         Unreviewed build correction.
2377
2378         Correct vsprops file for Debug variant of the CFLite build.
2379         Disable a CFNETWORK-specific test when building for CFLite.
2380
2381         * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
2382         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2383
2384 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
2385
2386         Reviewed by Adam Barth.
2387
2388         fix regressions introduced in 81908 - there were a couple of
2389         code paths that only fired under python 2.5 that I missed.
2390
2391         Also change a couple of 'python' references to sys.executable
2392         in order to handle runing test-webkitpy with a binary other than
2393         something called 'python'.
2394
2395         https://bugs.webkit.org/show_bug.cgi?id=57063
2396
2397         * Scripts/webkitpy/layout_tests/port/mac.py:
2398         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2399         * Scripts/webkitpy/test/cat.py:
2400         * Scripts/webkitpy/test/echo.py:
2401
2402 2011-03-24  Brent Fulgham  <bfulgham@webkit.org>
2403
2404         Unreviewed build correction.
2405
2406         Add a stub implementation of the TestInvocation dumping logic.
2407         Update project files to reflect new file.
2408
2409         * WebKitTestRunner/cairo: Added.
2410         * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
2411         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2412         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2413
2414 2011-03-24  Dirk Pranke  <dpranke@chromium.org>
2415
2416         Reviewed by Tony Chang.
2417
2418         new-run-webkit-tests: clean up worker model defaults. This
2419         changes the default behavior to 'threads' instead of
2420         'old-threads', and clarifies that chromium-win-* and
2421         chromium-mac-leopard are exceptions.
2422
2423         https://bugs.webkit.org/show_bug.cgi?id=56971
2424
2425         * Scripts/webkitpy/layout_tests/port/base.py:
2426         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2427         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2428         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2429         * Scripts/webkitpy/layout_tests/port/test.py:
2430         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2431
2432 2011-03-23  Leandro Gracia Gil  <leandrogracia@chromium.org>
2433
2434         Reviewed by Darin Adler.
2435
2436         Media Stream API: fix the order of the options in build-webkit.
2437         https://bugs.webkit.org/show_bug.cgi?id=56949
2438
2439         Fix the order of the options in build-webkit.
2440
2441         * Scripts/build-webkit:
2442
2443 2011-03-23  Adam Klein  <adamk@chromium.org>
2444
2445         Reviewed by Mihai Parparita.
2446
2447         Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
2448         https://bugs.webkit.org/show_bug.cgi?id=56884
2449
2450         This option will be utilized by Chromium's ui_tests to allow
2451         referencing js-test-resources from a layout test over HTTP.
2452
2453         * Scripts/new-run-webkit-httpd:
2454         Added --layout_tests_dir option.
2455         * Scripts/webkitpy/layout_tests/port/http_server.py:
2456         Plumbed through as layout_tests_dir param.
2457
2458 2011-03-23  Dirk Pranke  <dpranke@chromium.org>
2459
2460         Reviewed by Mihai Parparita.
2461
2462         new-run-webkit-tests: run tests in ascending alphabetical order per
2463         dir. This is a second attempt at the fix; the first attempt, in 
2464         r81597, broke the behavior on the old-inline and old-threads
2465         worker models.
2466
2467         https://bugs.webkit.org/show_bug.cgi?id=56760
2468
2469         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2470         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2471         * Scripts/webkitpy/layout_tests/port/test.py:
2472         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2473
2474 2011-03-23  Mario Sanchez Prada  <msanchez@igalia.com>
2475
2476         Reviewed by Martin Robinson.
2477
2478         [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
2479         https://bugs.webkit.org/show_bug.cgi?id=56953
2480
2481         Print the string for the detail of 'property-change' signal.
2482
2483         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2484         (axObjectEventListener): Print the detail string.
2485
2486 2011-03-23  Yury Semikhatsky  <yurys@chromium.org>
2487
2488         Reviewed by Pavel Feldman.
2489
2490         [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
2491         https://bugs.webkit.org/show_bug.cgi?id=56843
2492
2493         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
2494         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
2495
2496 2011-03-22  Eric Seidel  <eric@webkit.org>
2497
2498         Reviewed by Adam Barth.
2499
2500         Teach update-webkit about gyp
2501         https://bugs.webkit.org/show_bug.cgi?id=56881
2502
2503         This makes it possible for someone who builds from Xcode
2504         to just run update-webkit --gyp and have the project files
2505         generated after update automatically.
2506
2507         I also added a stand-alone "generate-project-files" script
2508         wrapping Source/gyp/configure.  This makes running gyp simpler
2509         since most people will not have gyp or Source/gyp in their path.
2510
2511         * Scripts/build-webkit:
2512         * Scripts/generate-project-files: Added.
2513         * Scripts/update-webkit:
2514
2515 2011-03-22  Anton D'Auria  <adauria@apple.com>
2516
2517         Reviewed by Alexey Proskuryakov.
2518
2519         Add +[WebApplicationCache getOriginsWithCache]
2520         https://bugs.webkit.org/show_bug.cgi?id=56722
2521
2522         * DumpRenderTree/LayoutTestController.cpp:
2523         (originsWithApplicationCacheCallback):
2524         (LayoutTestController::staticFunctions):
2525         * DumpRenderTree/LayoutTestController.h:
2526         * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
2527         (LayoutTestController::originsWithApplicationCache):
2528         * DumpRenderTree/chromium/LayoutTestController.h:
2529         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
2530         (LayoutTestController::originsWithApplicationCache):
2531         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
2532         (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
2533         (LayoutTestController::originsWithApplicationCache):
2534         (LayoutTestController::originsWithLocalStorage):
2535         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
2536         (LayoutTestController::originsWithApplicationCache):
2537         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2538         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
2539         (LayoutTestController::originsWithApplicationCache):
2540         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
2541         (LayoutTestController::originsWithApplicationCache):
2542
2543 2011-03-22  Eric Seidel  <eric@webkit.org>
2544
2545         Reviewed by Adam Barth.
2546
2547         Add support to build-webkit for building with gyp-generated project files
2548         https://bugs.webkit.org/show_bug.cgi?id=56877
2549
2550         build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
2551         Eventually we'll want to support gyp-generated projects in a more general manner.
2552
2553         * Scripts/build-webkit:
2554
2555 2011-03-22  David Kilzer  <ddkilzer@apple.com>
2556
2557         <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
2558
2559         Reviewed by Joseph Pecoraro.
2560
2561         * Scripts/build-webkit: Updated usage statement to include
2562         --dsym.
2563         * Scripts/webkitdirs.pm: Added $generateDsym variable.
2564         (generateDsym): Added. Call determineGenerateDsym() and
2565         return $generateDsym.
2566         (determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
2567         $generateDsym.
2568         (argumentsForXcode): Added.  Returns additional arguments for
2569         xcodebuild based on command-line switches.
2570         (XcodeOptions): Updated to include argumentsForXcode() in the
2571         array returned.
2572
2573 2011-03-22  Adam Roben  <aroben@apple.com>
2574
2575         Make Leopard Debug bots and Windows XP Debug (Tests) core builders
2576
2577         These bots are consistently green again.
2578
2579         Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
2580         core builders
2581
2582         Rubber-stamped by Antti Koivisto.
2583
2584         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2585         (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
2586
2587         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2588         (BuildBotTest.test_builder_name_regexps): Updated expectations.
2589
2590 2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>
2591
2592         Unreviewed, rolling out r81597.
2593         http://trac.webkit.org/changeset/81597
2594         https://bugs.webkit.org/show_bug.cgi?id=56801
2595
2596         Change results in lots of unexpected flaky on the dashboard.
2597         (Requested by pfeldman on #webkit).
2598
2599         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2600         * Scripts/webkitpy/layout_tests/port/test.py:
2601         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2602
2603 2011-03-21  Sam Weinig  <sam@webkit.org>
2604
2605         Fix failing tests on the WebKit2 bots.
2606
2607         * WebKitTestRunner/TestController.cpp:
2608         (WTR::TestController::resetStateToConsistentValues):
2609
2610 2011-03-21  Daniel Sievers  <sievers@google.com>
2611
2612         Reviewed by Simon Fraser.
2613
2614         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
2615         https://bugs.webkit.org/show_bug.cgi?id=56139
2616
2617         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2618         (main):
2619         * DumpRenderTree/chromium/LayoutTestController.cpp:
2620         (LayoutTestController::LayoutTestController):
2621         (LayoutTestController::layerTreeAsText):
2622         * DumpRenderTree/chromium/LayoutTestController.h:
2623         (LayoutTestController::setShowDebugLayerTree):
2624         * DumpRenderTree/chromium/TestShell.cpp:
2625         (TestShell::runFileTest):
2626         (TestShell::dump):
2627         * DumpRenderTree/chromium/TestShell.h:
2628         (TestParams::TestParams):
2629
2630 2011-03-21  Adam Roben  <aroben@apple.com>
2631
2632         Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
2633
2634         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
2635         output as plain text
2636
2637         Reviewed by David Kilzer.
2638
2639         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2640         (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
2641         to the master.
2642         (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
2643         since we're running on the build master, not the slave. Instead, turn the raw source of
2644         actual.html which the build slave uploaded into an HTML log.
2645
2646 2011-03-21  Dirk Pranke  <dpranke@chromium.org>
2647
2648         Reviewed by Mihai Parparita.
2649
2650         new-run-webkit-tests: run tests in ascending alphabetical order per dir
2651         https://bugs.webkit.org/show_bug.cgi?id=56760
2652
2653         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2654         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2655         * Scripts/webkitpy/layout_tests/port/test.py:
2656
2657 2011-03-21  Leandro Gracia Gil  <leandrogracia@chromium.org>
2658
2659         Reviewed by Steve Block.
2660
2661         Media Stream API patch 0: adding compilation guards.
2662         https://bugs.webkit.org/show_bug.cgi?id=56458
2663
2664         Adding options to enable the media stream API feature in Chromium.
2665
2666         * Scripts/build-webkit:
2667
2668 2011-03-21  Qi Zhang  <qi.2.zhang@nokia.com>
2669
2670         Reviewed by Laszlo Gombos.
2671
2672         [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
2673         https://bugs.webkit.org/show_bug.cgi?id=56323
2674
2675         Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide 
2676         "--stdout" or "--stderr" option.
2677
2678         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2679         (WebCore::DumpRenderTree::~DumpRenderTree):
2680         (WebCore::DumpRenderTree::processArgsLine):
2681         (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
2682         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2683         (WebCore::DumpRenderTree::setRedirectOutputFileName):
2684         (WebCore::DumpRenderTree::setRedirectErrorFileName):
2685         * DumpRenderTree/qt/main.cpp:
2686         (isOption):
2687         (takeOptionValue):
2688         (printUsage):
2689         (main):
2690
2691 2011-03-21  Adam Roben  <aroben@apple.com>
2692
2693         Fix exceptions on the buildbot due to my last change
2694
2695         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2696         (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
2697
2698 2011-03-21  Adam Roben  <aroben@apple.com>
2699
2700         Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
2701
2702         Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
2703         output as plain text
2704
2705         Reviewed by Darin Adler.
2706
2707         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2708         (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
2709         logs.
2710         (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
2711         the build master. This will correctly treat it as HTML.
2712
2713 2011-03-20  Bill Budge  <bbudge@chromium.org>
2714
2715         Reviewed by Adam Barth.
2716
2717         Rename ThreadSafeShared to ThreadSafeRefCounted
2718         https://bugs.webkit.org/show_bug.cgi?id=56714
2719
2720         No new tests. Exposes no new functionality.
2721
2722         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
2723         * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
2724         * Scripts/do-webcore-rename:
2725
2726 2011-03-19  Anton D'Auria  <adauria@apple.com>
2727
2728         Reviewed by Dan Bernstein.
2729
2730         Add stub to LayoutTestControllerGtk.cpp to fix GTK build
2731         https://bugs.webkit.org/show_bug.cgi?id=56719
2732
2733         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
2734         (LayoutTestController::clearApplicationCacheForOrigin):
2735
2736 2011-03-19  Anton D'Auria  <adauria@apple.com>
2737
2738         Reviewed by Alexey Proskuryakov.
2739
2740         ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
2741         https://bugs.webkit.org/show_bug.cgi?id=56415
2742
2743         * DumpRenderTree/LayoutTestController.cpp:
2744         (clearApplicationCacheForOriginCallback):
2745         (LayoutTestController::staticFunctions):
2746         * DumpRenderTree/LayoutTestController.h:
2747         * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
2748         (LayoutTestController::LayoutTestController):
2749         (LayoutTestController::clearAllApplicationCaches):
2750         (LayoutTestController::clearApplicationCacheForOrigin): 
2751         * DumpRenderTree/chromium/LayoutTestController.h:
2752         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
2753         (LayoutTestController::clearApplicationCacheForOrigin):
2754         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
2755         (LayoutTestController::clearApplicationCacheForOrigin):
2756         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2757         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
2758         (LayoutTestController::clearApplicationCacheForOrigin):
2759         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
2760         (LayoutTestController::clearApplicationCacheForOrigin):
2761
2762 2011-03-18  Dan Bernstein  <mitz@apple.com>
2763
2764         Revised build fix for r81135.
2765
2766         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2767         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2768
2769 2011-03-18  Adam Roben  <aroben@apple.com>
2770
2771         Windows build fix
2772
2773         * WebKitTestRunner/config.h: Add a missing #endif.
2774
2775 2011-03-18  Andreas Kling  <kling@webkit.org>
2776
2777         Unbreak Qt build after r81494.
2778
2779         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2780         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2781
2782 2011-03-18  Sam Weinig  <sam@webkit.org>
2783
2784         Fix windows build. This was really Adam Roben's fault. I swear!
2785
2786         * WebKitTestRunner/config.h:
2787
2788 2011-03-18  Sam Weinig  <sam@webkit.org>
2789
2790         Reviewed by Adam Roben.
2791
2792         Pixel tests don't work in WebKitTestRunner on Windows
2793         https://bugs.webkit.org/show_bug.cgi?id=56630
2794
2795         Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
2796         built-in snapshotting instead of using the window server on the Mac.
2797
2798         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2799         (WTR::InjectedBundle::InjectedBundle):
2800         (WTR::InjectedBundle::didReceiveMessage):
2801         (WTR::InjectedBundle::beginTesting):
2802         (WTR::InjectedBundle::done):
2803         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2804         (WTR::InjectedBundle::setPixelResult):
2805         (WTR::InjectedBundle::shouldDumpPixels):
2806         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2807         (WTR::InjectedBundlePage::dump):
2808         Take the snapshot in the bundle and send it to the UIProcess for dumping.
2809
2810         * WebKitTestRunner/TestInvocation.cpp:
2811         (WTR::TestInvocation::invoke):
2812         (WTR::TestInvocation::dump):
2813         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2814         * WebKitTestRunner/TestInvocation.h:
2815         * WebKitTestRunner/cg: Added.
2816         * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
2817         (WTR::createCGContextFromImage):
2818         (WTR::computeMD5HashStringForContext):
2819         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2820         * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
2821         Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
2822
2823         * WebKitTestRunner/win/TestInvocationWin.cpp:
2824         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2825         Keep stub for Cairo build.
2826
2827         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
2828         Add CG configuration.
2829
2830         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2831         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
2832         Add new files.
2833
2834 2011-03-18  Adam Roben  <aroben@apple.com>
2835
2836         Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
2837
2838         Rubber-stamped by Simon Fraser.
2839
2840         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2841         (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
2842         overflow-y:overlay so that the scrollbar doesn't overlay the content.
2843
2844 2011-03-18  Adam Roben  <aroben@apple.com>
2845
2846         Don't ellipsize long or indented function names in Leaks Viewer
2847
2848         Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
2849         scrollbar
2850
2851         Reviewed by Simon Fraser.
2852
2853         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
2854         (.data-grid .data-container):
2855         (.data-grid td > div, .data-grid th > div):
2856         Allow the contents to extend to the right.
2857
2858 2011-03-18  Adam Roben  <aroben@apple.com>
2859
2860         Fix some leaks in DRT seen on the leaks bot
2861
2862         Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
2863         setWillSendRequestClearHeaderCallback in DRT are leaky
2864
2865         Reviewed by Alexey Proskuryakov.
2866
2867         * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
2868
2869         * DumpRenderTree/LayoutTestController.cpp:
2870         (addURLToRedirectCallback):
2871         (setWillSendRequestClearHeaderCallback):
2872         Use OwnArrayPtr to cause the strings to be deleted.
2873
2874 2011-03-18  Adam Roben  <aroben@apple.com>
2875
2876         Fix a NSURLCredential leak seen on the leaks bot
2877
2878         Fixes <http://webkit.org/b/56637> -[SynchronousLoader
2879         connection:didReceiveAuthenticationChallenge:] is leaky
2880
2881         Reviewed by John Sullivan.
2882
2883         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2884         (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
2885         cause the NSURLCredential to be released.
2886
2887 2011-03-18  John Knottenbelt  <jknotten@chromium.org>
2888
2889         Unreviewed.
2890
2891         Remove unnecessary brackets around my email address.
2892
2893         * Scripts/webkitpy/common/config/committers.py:
2894
2895 2011-03-18  Adam Roben  <aroben@apple.com>
2896         
2897         Remove some files I accidentally added in r81454
2898
2899         * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
2900         * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
2901
2902 2011-03-18  Adam Roben  <aroben@apple.com>
2903
2904         Ignore an NSNumberFormatter leak on SnowLeopard
2905
2906         * Scripts/old-run-webkit-tests:
2907         (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
2908         getObjectValue:forString:errorDescription:].
2909
2910 2011-03-18  Adam Roben  <aroben@apple.com>
2911
2912         Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
2913
2914         Rubber-stamped by Mark Rowe.
2915
2916         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2917         (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
2918         released.
2919
2920 2011-03-17  Adam Roben  <aroben@apple.com>
2921
2922         Address a review comment I missed in r81445
2923
2924         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2925         (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
2926         leaked bytes to speed up searching on long lines.
2927
2928 2011-03-17  Adam Roben  <aroben@apple.com>
2929
2930         Mark leaky builds orange, even if all regression tests passed
2931
2932         Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
2933         build.webkit.org when all tests pass even though there are still leaks
2934
2935         Reviewed by Dan Bernstein.
2936
2937         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2938         (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
2939         be marked orange if this build step generates warnings.
2940
2941 2011-03-17  Adam Roben  <aroben@apple.com>
2942
2943         Allow values in Leaks Viewer to be shown as percentages
2944
2945         Double-clicking on a column will toggle between showing percentages and showing real values.
2946
2947         Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
2948         number of leaked bytes in Leaks Viewer
2949
2950         Reviewed by Joe Pecoraro.
2951
2952         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2953         (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
2954         node's totalTime, which is used in calculating percentages.
2955
2956         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2957         (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
2958         showing them as percentages.
2959
2960 2011-03-17  Adam Roben  <aroben@apple.com>
2961
2962         Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
2963
2964         The Self and Total columns now report the number of leaked bytes. The new Calls column shows
2965         the number of leaked allocations. And the new Average column shows the average number of
2966         leaked bytes per call.
2967
2968         Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
2969         just how many allocations
2970
2971         Reviewed by Joe Pecoraro.
2972
2973         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
2974         (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
2975         line and store it with the leak stack.
2976         (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
2977         properties.
2978         (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
2979         property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
2980         .numberOfCalls now holds the number of leaked allocations.
2981
2982         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
2983         (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
2984         appear.
2985         (monkeyPatchInspectorObjects): Format the values as bytes.
2986
2987 2011-03-17  Adam Roben  <aroben@apple.com>
2988
2989         Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
2990
2991         Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
2992         regression tests
2993
2994         Reviewed by James Robinson.
2995
2996         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
2997         (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
2998         is always populated, even when all regression tests pass.
2999
3000 2011-03-10  Hayato Ito  <hayato@chromium.org>
3001
3002         Reviewed by Tony Chang.
3003
3004         Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
3005
3006         https://bugs.webkit.org/show_bug.cgi?id=56076
3007
3008         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
3009
3010 2011-03-17  Adam Roben  <aroben@apple.com>
3011
3012         Skip a compositing-sensitive test when accelerated compositing is disabled
3013
3014         Reviewed by Sam Weinig.
3015
3016         * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
3017         accelerated compositing is disabled.
3018
3019 2011-03-17  Adam Roben  <aroben@apple.com>
3020
3021         Start using PlatformSpecificScheduler for the Mac builders
3022
3023         The current set of file/directory patterns should work for Mac builders. We may discover
3024         that there are more files and directories we can exclude from the Mac builds, but they can
3025         be added later.
3026
3027         Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
3028
3029         Reviewed by Mark Rowe.
3030
3031         * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
3032         PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
3033
3034         * Scripts/webkitpy/common/config/build.py:
3035         (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
3036         cleaned up patterns a little bit.
3037
3038         * Scripts/webkitpy/common/config/build_unittest.py:
3039         (ShouldBuildTest): Fixed some expected results.
3040         (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
3041         platforms.
3042
3043 2011-03-17  Jeff Miller  <jeffm@apple.com>
3044
3045         Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
3046         
3047         *.mode*
3048         *.pbxuser
3049         *.perspective*
3050         project.xcworkspace
3051         xcuserdata
3052
3053         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
3054         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
3055         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
3056         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
3057         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
3058
3059 2011-03-17  Adam Roben  <aroben@apple.com>
3060
3061         Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
3062
3063         Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
3064         mac-wk2
3065
3066         Reviewed by Anders Carlsson.
3067
3068         * Scripts/old-run-webkit-tests:
3069         (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
3070         directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
3071         we're running in WebKit2 mode.
3072
3073 2011-03-17  Mikhail Naganov  <mnaganov@chromium.org>
3074
3075         Reviewed by Yury Semikhatsky.
3076
3077         Web Inspector: Clean up Inspector strings.
3078         https://bugs.webkit.org/show_bug.cgi?id=56557
3079
3080         Modify the script to deal correctly with "\xNN" escapes, and to
3081         check strings in Chromium's DevTools.js.
3082
3083         * Scripts/check-inspector-strings:
3084
3085 2011-03-17  Keith Kyzivat  <keith.kyzivat@nokia.com>
3086
3087         Reviewed by Benjamin Poulain.
3088
3089         Update autoinstall to install mechanize 0.2.4
3090         https://bugs.webkit.org/show_bug.cgi?id=56499
3091
3092         Newer versions of mechanize support HTTPS proxies, which is necessary
3093         for people using webkit-patch behind firewalls.
3094
3095         * Scripts/webkitpy/common/system/autoinstall.py:
3096         * Scripts/webkitpy/thirdparty/__init__.py:
3097
3098 2011-03-16  Sam Weinig  <sam@webkit.org>
3099
3100         Reviewed by Adam Roben.
3101
3102         REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
3103         https://bugs.webkit.org/show_bug.cgi?id=56541
3104
3105         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3106         (WTR::InjectedBundlePage::willSendRequestForFrame):
3107         Check for an empty host in addition to a null host.  This bug was introduced
3108         when porting off of the KURL code and onto the WKURLRef version.
3109
3110 2011-03-16  Sam Weinig  <sam@webkit.org>
3111
3112         Reviewed by Adam Roben.
3113
3114         Add Lucas Forschler to the list of WebKit committers.
3115
3116         * Scripts/webkitpy/common/config/committers.py:
3117
3118 2011-03-16  Sam Weinig  <sam@webkit.org>
3119
3120         Reviewed upon and dictated through Adam Roben.
3121
3122         Escape crashing function names in results.html. This fixes an issue
3123         when a crash involves a type with templates.
3124
3125         * Scripts/old-run-webkit-tests:
3126
3127 2011-03-16  Daniel Sievers  <sievers@google.com>
3128
3129         Reviewed by James Robinson.
3130
3131         Add setting to always force compositing mode
3132         https://bugs.webkit.org/show_bug.cgi?id=56156
3133
3134         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3135         (main):
3136         * DumpRenderTree/chromium/TestShell.cpp:
3137         (TestShell::TestShell):
3138         (TestShell::resetWebSettings):
3139         * DumpRenderTree/chromium/TestShell.h:
3140         (TestShell::setForceCompositingMode):
3141         * DumpRenderTree/chromium/WebPreferences.cpp:
3142         (WebPreferences::reset):
3143         (WebPreferences::applyTo):
3144         * DumpRenderTree/chromium/WebPreferences.h:
3145
3146 2011-03-15  Hayato Ito  <hayato@chromium.org>
3147
3148         Reviewed by Ojan Vafai.
3149
3150         Ignore files that will be used by reftests in old-run-webkit-tests.
3151
3152         https://bugs.webkit.org/show_bug.cgi?id=55936
3153
3154         * Scripts/old-run-webkit-tests:
3155
3156 2011-03-15  Felipe Oliveira da Silva Netto  <f.dachshund@gmail.com>
3157
3158         Reviewed by Adam Roben.
3159
3160         Function relativeScriptsDir doesn't return the correct relative
3161         Scripts directory.
3162
3163         * Scripts/webkitdirs.pm:
3164         (relativeScriptsDir): Ensure we use the directory that contains
3165         webkitdirs.pm, not the one that contains the original script that
3166         was invoked.
3167
3168 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3169
3170         [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
3171         fix to link against the Security framework after recent WebKitSystemInterface changes.
3172
3173         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3174         (LayoutTestController::originsWithLocalStorage):
3175         * wx/build/settings.py:
3176         * wx/build/waf_extensions.py:
3177
3178 2011-03-15  Sam Weinig  <sam@webkit.org>
3179
3180         Reviewed by Darin Adler.
3181
3182         Add script to convert a patch to a prettypatch and show in the default browser
3183         https://bugs.webkit.org/show_bug.cgi?id=56416
3184
3185         This can be used either like
3186             $ svn-create-patch | show-pretty-diff
3187         or
3188             $ show-pretty-diff patch.diff
3189
3190         * Scripts/show-pretty-diff: Added.
3191
3192 2011-03-15  Brian Weinstein  <bweinstein@apple.com>
3193
3194         Rubber-stamped by Adam Roben.
3195
3196         Adding myself as a reviewer.
3197
3198         * Scripts/webkitpy/common/config/committers.py:
3199
3200 2011-03-15  Anders Carlsson  <andersca@apple.com>
3201
3202         Try to fix the Windows build.
3203
3204         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
3205         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3206
3207 2011-03-15  Anders Carlsson  <andersca@apple.com>
3208
3209         Reviewed by Sam Weinig.
3210
3211         Make sure that NP_Shutdown is always the last NPP function called
3212         https://bugs.webkit.org/show_bug.cgi?id=56391
3213
3214         Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
3215
3216         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3217         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
3218         (PluginTest::PluginTest):
3219         (PluginTest::NP_Shutdown):
3220         (PluginTest::registerNPShutdownFunction):
3221         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
3222         * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
3223         (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
3224         (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
3225         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
3226         (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
3227         (NPDeallocateCalledBeforeNPShutdown::NPP_New):
3228         (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
3229         (NPDeallocateCalledBeforeNPShutdown::shutdown):
3230         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3231         (NP_Shutdown):
3232         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
3233         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3234         * GNUmakefile.am:
3235
3236 2011-03-15  Ilya Sherman  <isherman@chromium.org>
3237
3238         Reviewed by Tony Chang.
3239
3240         Autofilled form elements are assigned fixed background color but not text color
3241         https://bugs.webkit.org/show_bug.cgi?id=48382
3242
3243         * DumpRenderTree/LayoutTestController.cpp:
3244         (setAutofilledCallback): Added.
3245         (LayoutTestController::staticFunctions):
3246         * DumpRenderTree/LayoutTestController.h:
3247         * DumpRenderTree/chromium/LayoutTestController.cpp:
3248         (LayoutTestController::LayoutTestController):
3249         (LayoutTestController::setAutofilled): Added.
3250         * DumpRenderTree/chromium/LayoutTestController.h:
3251         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3252         (LayoutTestController::setAutofilled): Added.
3253         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3254         (LayoutTestController::setAutofilled): Added.
3255         (LayoutTestController::setValueForUser): Style tweak.
3256         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3257         (LayoutTestController::setAutofilled): Added (stub).
3258         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3259         (LayoutTestController::setAutofilled): Added (stub).
3260
3261 2011-03-15  Dan Bernstein  <mitz@apple.com>
3262
3263         Build fix after r81135.
3264
3265         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
3266
3267 2011-03-15  Dan Bernstein  <mitz@apple.com>
3268
3269         Build fix after r81135.
3270
3271         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
3272         * WebKitTestRunner/mac/TestControllerMac.mm:
3273         * WebKitTestRunner/mac/TestInvocationMac.mm:
3274         * WebKitTestRunner/mac/main.mm:
3275
3276 2011-03-15  Balazs Kelemen  <kbalazs@webkit.org>
3277
3278         Reviewed by Adam Barth.
3279
3280         REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
3281         https://bugs.webkit.org/show_bug.cgi?id=56349
3282
3283         * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
3284         on platforms where we use it. Copied from DumpRenderTree.pro.
3285
3286 2011-03-15  Dan Bernstein  <mitz@apple.com>
3287
3288         Build fix after r81135.
3289
3290         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
3291         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
3292
3293 2011-03-15  Kevin Ollivier  <kevino@theolliviers.com>
3294
3295         Reviewed by Darin Adler.
3296
3297         Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
3298         info into the headers rather than in export symbol definition files, but disable it on 
3299         all platforms initially so we can deal with port build issues one port at a time.
3300         
3301         https://bugs.webkit.org/show_bug.cgi?id=27551
3302
3303         * DumpRenderTree/cg/ImageDiffCG.cpp:
3304         * DumpRenderTree/chromium/config.h:
3305         * DumpRenderTree/config.h:
3306         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3307         * TestWebKitAPI/TestWebKitAPIPrefix.h:
3308         * WebKitAPITest/HostWindow.cpp:
3309         * WebKitAPITest/TestsController.cpp:
3310         * WebKitAPITest/config.h: Added.
3311         * WebKitAPITest/main.cpp:
3312         * WebKitAPITest/tests/WebViewDestruction.cpp:
3313         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
3314         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
3315         * WebKitTestRunner/InjectedBundle/GCController.cpp:
3316         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3317         * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
3318         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3319         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3320         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
3321         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3322         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3323         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
3324         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
3325         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
3326         * WebKitTestRunner/TestController.cpp:
3327         * WebKitTestRunner/TestInvocation.cpp:
3328         * WebKitTestRunner/config.h: Added.
3329         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3330         * WebKitTestRunner/qt/TestControllerQt.cpp:
3331         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3332         * WebKitTestRunner/qt/main.cpp:
3333         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3334         * WebKitTestRunner/win/TestControllerWin.cpp:
3335         * WebKitTestRunner/win/TestInvocationWin.cpp:
3336         * WebKitTestRunner/win/main.cpp:
3337         * wx/build/settings.py:
3338
3339 2011-03-15  Hayato Ito  <hayato@chromium.org>
3340
3341         Reviewed by Shinichiro Hamaji.
3342
3343         [NRWT] Add support for reftests to new-run-webkit-tests.
3344
3345         https://bugs.webkit.org/show_bug.cgi?id=55457
3346
3347         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
3348         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3349         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
3350         * Scripts/webkitpy/layout_tests/port/base.py:
3351         * Scripts/webkitpy/layout_tests/port/dryrun.py:
3352         * Scripts/webkitpy/layout_tests/port/test.py:
3353         * Scripts/webkitpy/layout_tests/port/test_files.py:
3354         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3355
3356 2011-03-15  Alejandro G. Castro  <alex@igalia.com>
3357
3358         Reviewed by Martin Robinson.
3359
3360         [GTK] Fix compilation warning after r80892
3361         https://bugs.webkit.org/show_bug.cgi?id=56302
3362
3363         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3364         (LayoutTestController::originsWithLocalStorage):
3365
3366 2011-03-15  Robert Hogan  <robert@webkit.org>
3367
3368         Reviewed by Adam Barth.
3369
3370         Document the qmakearg argument, and hint how to build webkit2 on Qt
3371         https://bugs.webkit.org/show_bug.cgi?id=56326
3372
3373         * Scripts/build-webkit: add --qmakearg to build-webkit --help
3374
3375 2011-03-15  Adam Roben  <aroben@apple.com>
3376
3377         Make Windows 7 Release (Tests) a core builder
3378
3379         We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
3380         give it a few more days of greenness first.
3381
3382         Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
3383
3384         Reviewed by Sam Weinig.
3385
3386         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3387         (BuildBot): Added a regexp to match Windows 7 Release (Tests).
3388
3389         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3390         (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
3391         Updated the core regexps to match the buildbot module. Updated the expected results to match
3392         the current set of core builders.
3393
3394 2011-03-14  Adam Roben  <aroben@apple.com>
3395
3396         Add forgotten file from r81116
3397
3398         * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
3399
3400 2011-03-14  Sam Weinig  <sam@webkit.org>
3401
3402         Reviewed by Adam Roben.
3403
3404         about:blank fake responses don't get serialized when sent the UIProcess
3405         <rdar://problem/9108119>
3406         https://bugs.webkit.org/show_bug.cgi?id=56357
3407
3408         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
3409         (TestWebKitAPI::decidePolicyForResponse):
3410         (TestWebKitAPI::TEST):
3411         Add test that loads of about:blank have a response with a MIMEType of text/html.
3412
3413         * TestWebKitAPI/PlatformUtilities.h:
3414         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
3415         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3416         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3417         (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
3418         Add helper to get the MIMEType from a WKURLResponse.
3419
3420         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3421         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3422         Add new files.
3423
3424 2011-03-14  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>
3425
3426         Reviewed by Kenneth Rohde Christiansen.
3427
3428         [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
3429         https://bugs.webkit.org/show_bug.cgi?id=56006
3430
3431         * QtTestBrowser/launcherwindow.cpp:
3432         (LauncherWindow::initializeView):
3433         * QtTestBrowser/main.cpp:
3434         (LauncherApplication::handleUserOptions):
3435
3436 2011-03-14  James Kozianski  <koz@chromium.org>
3437
3438         Reviewed by Ojan Vafai.
3439
3440         Add method to make BuildBot return test outputs
3441         https://bugs.webkit.org/show_bug.cgi?id=54374
3442
3443         The Builder.latest_cached_build will be used by the new rebaseline
3444         script to determine the build to use baselines from.
3445
3446         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3447         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3448
3449 2011-03-14  Adam Roben  <aroben@apple.com>
3450
3451         Test that WKBundlePageCanHandleRequest returns true for empty document URLs
3452
3453         Reviewed by Sam Weinig.
3454
3455         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
3456         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
3457         (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
3458         (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
3459         ensure the web process is initialized, then ask the bundle to run the test and assert that
3460         it succeeded.
3461
3462         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
3463         (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
3464         (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
3465         handle a given URL.
3466         (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
3467         URL type cannot be handled).
3468         (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
3469         result.
3470
3471         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3472         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3473         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
3474         Added new files to the project.
3475
3476 2011-03-14  Sheriff Bot  <webkit.review.bot@gmail.com>
3477
3478         Unreviewed, rolling out r81094.
3479         http://trac.webkit.org/changeset/81094
3480         https://bugs.webkit.org/show_bug.cgi?id=56355
3481
3482         Broke the chromium DRT related build. (Requested by dave_levin
3483         on #webkit).
3484
3485         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3486         (main):
3487         * DumpRenderTree/chromium/LayoutTestController.cpp:
3488         (LayoutTestController::LayoutTestController):
3489         (LayoutTestController::layerTreeAsText):
3490         * DumpRenderTree/chromium/LayoutTestController.h:
3491         * DumpRenderTree/chromium/TestShell.cpp:
3492         (TestShell::runFileTest):
3493         (TestShell::dump):
3494         * DumpRenderTree/chromium/TestShell.h:
3495         (TestParams::TestParams):
3496
3497 2011-03-14  Daniel Sievers  <sievers@google.com>
3498
3499         Reviewed by Simon Fraser.
3500
3501         [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
3502         https://bugs.webkit.org/show_bug.cgi?id=56139
3503
3504         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3505         (main):
3506         * DumpRenderTree/chromium/LayoutTestController.cpp:
3507         (LayoutTestController::LayoutTestController):
3508         (LayoutTestController::layerTreeAsText):
3509         * DumpRenderTree/chromium/LayoutTestController.h:
3510         (LayoutTestController::setShowDebugLayerTree):
3511         * DumpRenderTree/chromium/TestShell.cpp:
3512         (TestShell::runFileTest):
3513         (TestShell::dump):
3514         * DumpRenderTree/chromium/TestShell.h:
3515         (TestParams::TestParams):
3516
3517 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
3518
3519         Reviewed by Adam Roben.
3520
3521         [Qt][WK2]Unbreak InjectedBundle on Qt
3522         https://bugs.webkit.org/show_bug.cgi?id=54109
3523
3524         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3525         (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
3526         API's instead of KURL to analyze the URL.
3527         * WebKitTestRunner/StringFunctions.h:
3528         (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
3529         in the WebKitTestRunner project.
3530         (WTR::toWK): Use adoptWK.
3531         (WTR::operator<<): Added helper for printing a WKURL.
3532         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
3533         against WebCore.
3534
3535 2011-03-14  Balazs Kelemen  <kbalazs@webkit.org>
3536
3537         Reviewed by Kenneth Rohde Christiansen.
3538
3539         check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
3540         https://bugs.webkit.org/show_bug.cgi?id=56321
3541
3542         * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
3543         to the list of exceptions for WebKit2 C API headers.
3544
3545 2011-03-14  Adam Roben  <aroben@apple.com>
3546
3547         Show the list of recent leaky builds in reverse chronological order
3548
3549         Previously they were being shown in a deterministic but surprising order based on
3550         lexicographically sorting the build offsets (-1, -10, -2, -3...).
3551
3552         Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
3553
3554         Reviewed by Darin Adler.
3555
3556         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3557         (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
3558         callback.
3559
3560 2011-03-14  Adam Roben  <aroben@apple.com>
3561
3562         Show a list of up to 10 recent leaky builds when Leaks Viewer loads
3563
3564         Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
3565         analyze
3566
3567         Reviewed by David Kilzer and Joe Pecoraro.
3568
3569         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
3570         (#url-prompt): Made this a bit taller to make room for the list of builds.
3571
3572         (#recent-builds-loading-indicator):
3573         (#recent-builds-list):
3574         Added styles for the build list and loading indicator.
3575
3576         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
3577         (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
3578         it. This will unescape it.
3579         (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
3580         (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
3581         (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
3582         (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
3583         prompt UI.
3584         (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
3585         now also used when a recent build is clicked.
3586
3587         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
3588         (RecentBuildsLoader): Store the callback.
3589         (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
3590         builder. Find the revision number, leak count, and results URL for each one. Pass the
3591         resulting info to our callback.
3592
3593         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
3594         (range): Added this helper function to return an array containing the integers [0, n).
3595
3596         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
3597         RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
3598
3599 2011-03-14  Mark Rowe  <mrowe@apple.com>
3600
3601         Reviewed by Adam Roben.
3602
3603         Fix two memory leaks within LayoutTestController's storage support.
3604
3605         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3606         (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
3607         by JSStringCreateWithCFString.
3608         (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
3609         allocate.
3610
3611 2011-03-14  Mark Rowe  <mrowe@apple.com>
3612
3613         Reviewed by Oliver Hunt.
3614
3615         <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
3616
3617         * DumpRenderTree/LayoutTestController.cpp:
3618         (LayoutTestController::staticFunctions): Remove duplicate entries.
3619
3620 2011-03-14  Alice Liu  <alice.liu@apple.com>
3621
3622         Reviewed by Dan Bernstein.
3623
3624         DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
3625
3626         * DumpRenderTree/mac/PerlSupport/Makefile:
3627         Add whitespace when joining "-arch" with the architectures passed in as arguments.
3628
3629 2011-03-14  Daniel Bates  <dbates@rim.com>
3630
3631         https://bugs.webkit.org/show_bug.cgi?id=55438
3632         Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
3633         when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
3634
3635         * Scripts/build-webkit:
3636
3637 2011-03-14  Daniel Bates  <dbates@rim.com>
3638
3639         Reviewed by David Kilzer.
3640
3641         Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
3642         https://bugs.webkit.org/show_bug.cgi?id=55438
3643
3644         Separate out the EFL- and WinCE-specific logic from the port-independent logic in
3645         webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
3646         CMake arguments for feature defines.
3647
3648         * Scripts/build-webkit:
3649           - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
3650           - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
3651           - Sorted forward declarations.
3652           - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
3653             Modified call sites as needed.
3654         * Scripts/webkitdirs.pm:
3655           - Added cleanCMakeGeneratedProject() to clean a CMake build.
3656           - Added buildCMakeGeneratedProject() to build using generated build system.
3657           - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
3658           - Added generateBuildSystemFromCMakeProject() to generate the build system from
3659             a CMake project.
3660           - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
3661
3662 2011-03-14  John Knottenbelt  <jknotten@chromium.org>
3663
3664         Reviewed by Steve Block.
3665
3666         Detach Geolocation from Frame when Page destroyed.
3667         https://bugs.webkit.org/show_bug.cgi?id=52877
3668
3669         Extend the layout test controller to expose the number of pending
3670         geolocation requests, so that we can test that the requests have
3671         been cancelled on page close.