795c87470deca197eaa9056b4dd5517a216984c1
[WebKit-https.git] / Tools / ChangeLog
1 2018-01-11  Alexey Proskuryakov  <ap@apple.com>
2
3         run-webkit-tests fails when there is a curly brace in Xcode build output
4         https://bugs.webkit.org/show_bug.cgi?id=181254
5
6         Reviewed by Daniel Bates.
7
8         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
9         (MeteredStream.write):
10
11 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
12
13         webkitpy: Reimplement simulator code (Part 3)
14         https://bugs.webkit.org/show_bug.cgi?id=180555
15         <rdar://problem/36131381>
16
17         Reviewed by Aakash Jain.
18
19         Remove old simulator code.
20
21         * Scripts/webkitpy/xcode/__init__.py: Remove import statement.
22         * Scripts/webkitpy/xcode/simulated_device.py: Removed.
23         * Scripts/webkitpy/xcode/simulator.py: Removed.
24         * Scripts/webkitpy/xcode/simulator_unittest.py: Removed.
25
26 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
27
28         [Attachment Support] Support moving attachment elements in editable areas using drag and drop
29         https://bugs.webkit.org/show_bug.cgi?id=181337
30         <rdar://problem/36324813>
31
32         Reviewed by Tim Horton.
33
34         Add 3 new API tests for attachment element dragging.
35
36         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
37         (-[TestWKWebView expectElementTag:toComeBefore:]):
38         (-[NSItemProvider expectType:withData:]):
39         (TestWebKitAPI::TEST):
40
41 2018-01-11  Jonathan Bedard  <jbedard@apple.com>
42
43         REGRESSION(r225856): Incorrectly managing 'future' baseline_search_paths. 
44         https://bugs.webkit.org/show_bug.cgi?id=179621
45         <rdar://problem/35589585>
46
47         Unreviewed infrastructure fix.
48
49         * Scripts/webkitpy/port/mac.py:
50         (MacPort.default_baseline_search_path): Include 'future' in the version_fallback
51         list if we are the VERSION_MAX, which usually corresponds with future.
52
53 2018-01-11  Filip Pizlo  <fpizlo@apple.com>
54
55         CodeBlocks should be in IsoSubspaces
56         https://bugs.webkit.org/show_bug.cgi?id=180884
57
58         Reviewed by Saam Barati.
59         
60         Remove some less important benchmarks from the default run. Doing run-jsc-benchmarks
61         shouldn't take a long time due to benchmarks we don't optimize for.
62         
63         * Scripts/run-jsc-benchmarks:
64
65 2018-01-11  Ms2ger  <Ms2ger@igalia.com>
66
67         Test gardening for GTK.
68         https://bugs.webkit.org/show_bug.cgi?id=181477
69
70         Unreviewed test gardening.
71
72         * TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp: Correct the file name.
73         * TestWebKitAPI/Tests/WebKitGLib/TestConsoleMessage.cpp: Adjust the expected console message.
74
75 2018-01-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
76
77         Add the new JSCOnly bot to the scheduler.
78         https://bugs.webkit.org/show_bug.cgi?id=181487
79
80         Unreviewed follow-up patch after r226729
81
82         On r226729 I missed to add the new JSCOnly bot the default scheduler.
83         This is needed to make the bot automatically pick each commit for testing.
84
85         * BuildSlaveSupport/build.webkit.org-config/config.json:
86
87 2018-01-11  Wenson Hsieh  <wenson_hsieh@apple.com>
88
89         [Attachment Support] Support dragging attachment elements out as files on iOS
90         https://bugs.webkit.org/show_bug.cgi?id=181199
91         <rdar://problem/36299316>
92
93         Reviewed by Tim Horton, Andy Estes and Joseph Pecoraro.
94
95         Add support in the drag and drop simulator for testing blob-backed attachment element dragging, and also add new
96         attachment API tests.
97
98         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
99         (-[NSItemProvider expectType:withData:]):
100         (TestWebKitAPI::TEST):
101
102         Add two new WKAttachmentTests to exercise dragging data- and file-backed blobs via attachment elements. These
103         tests first insert attachments via drop or WKWebView SPI, and then drag these attachments out and use the
104         -expectType:withData: helper to inspect the item providers created from the drag source.
105
106         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
107         (TestWebKitAPI::TEST):
108         * TestWebKitAPI/ios/DataInteractionSimulator.h:
109         * TestWebKitAPI/ios/DataInteractionSimulator.mm:
110         (-[MockDragSession localContext]):
111         (-[MockDragSession setLocalContext:]):
112         (-[DataInteractionSimulator _resetSimulatedState]):
113         (-[DataInteractionSimulator simulateAllTouchesCanceled:]):
114         (-[DataInteractionSimulator _concludeDataInteractionAndPerformOperationIfNecessary]):
115         (-[DataInteractionSimulator _advanceProgress]):
116         (-[DataInteractionSimulator endDataTransfer]):
117
118         Make some tweaks to the iOS drag and drop simulator. In particular, this patch (1) adds a new hook to tell
119         WebKit that data transfers have been completed, (2) fixes incorrect drop proposal handling when returning
120         UIDropOperationForbidden by replacing _shouldPerformOperation with a UIDropProposal, and (3) teach the
121         MockDragSession to hold on to a localContext.
122
123 2018-01-11  Ali Juma  <ajuma@chromium.org>
124
125         Unreviewed. Add Ali Juma as contributor
126
127         * Scripts/webkitpy/common/config/contributors.json:
128
129 2018-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
130
131         Unreviewed. Update Selenium WebDriver imported tests.
132
133         New version of selenium uses command line options to pass driver and browser binaries to pytest instead of
134         environment variables.
135
136         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
137         (collect): Reorder the arguments to make pytest happy.
138         (run): Ditto.
139         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
140         (WebDriverSeleniumExecutor.__init__): Add driver binary, browser binary and browser args as arguments.
141
142 2018-01-11  Ling Ho  <lingcherd_ho@apple.com>
143
144         Move Commit Queue and EWS Queues to Sierra on Bot Watcher's Dasboard
145         https://bugs.webkit.org/show_bug.cgi?id=181492
146         <rdar://problem/36359679>
147
148         Reviewed by Alexey Proskuryakov. 
149
150 2018-01-10  Adrian Perez de Castro  <aperez@igalia.com>
151
152         [GTK] Tools/gtk/install-dependencies: Packages geoclue, ruby-highline, xorg-utils do not exist in Arch Linux
153         https://bugs.webkit.org/show_bug.cgi?id=181475
154
155         Reviewed by Michael Catanzaro.
156
157         * gtk/install-dependencies: Update package list for Arch Linux, extend
158         message shown at end of installation with additional tips.
159
160 2018-01-10  Wenson Hsieh  <wenson_hsieh@apple.com>
161
162         REGRESSION(r222507): Composition highlight doesn't render when using IME
163         https://bugs.webkit.org/show_bug.cgi?id=181485
164         <rdar://problem/35896516>
165
166         Reviewed by Ryosuke Niwa.
167
168         Add a `suppressUnderline` argument to TextInputController.setMarkedText. This suppresses the custom underlines
169         rendered when testing IME on iOS in WebKit2. In this new test, suppressing underline rendering is needed to
170         allow rendering composition backgrounds (see InlineTextBox::paint).
171
172         * DumpRenderTree/ios/TextInputControllerIOS.m:
173         (+[TextInputController isSelectorExcludedFromWebScript:]):
174         (+[TextInputController webScriptNameForSelector:]):
175         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
176         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
177         * DumpRenderTree/mac/TextInputControllerMac.m:
178         (+[TextInputController isSelectorExcludedFromWebScript:]):
179         (+[TextInputController webScriptNameForSelector:]):
180         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]):
181         (-[TextInputController setMarkedText:selectedFrom:length:]): Deleted.
182         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
183         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
184         (WTR::TextInputController::setMarkedText):
185         * WebKitTestRunner/InjectedBundle/TextInputController.h:
186
187 2018-01-10  JF Bastien  <jfbastien@apple.com>
188
189         Poison small JSObject derivatives which only contain pointers
190         https://bugs.webkit.org/show_bug.cgi?id=181483
191         <rdar://problem/36407127>
192
193         Reviewed by Mark Lam.
194
195         Test the new move-assign and move-copy from unique_ptr, as well as
196         nullptr_t ctors.
197
198         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
199         (TestWebKitAPI::TEST):
200         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:
201         (TestWebKitAPI::TEST):
202         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:
203         (TestWebKitAPI::TEST):
204
205 2018-01-10  Chris Dumez  <cdumez@apple.com>
206
207         Multiple http/wpt/beacon/contentextensions/ test are flaky.
208         https://bugs.webkit.org/show_bug.cgi?id=179256
209         <rdar://problem/35401978>
210
211         Reviewed by Alex Christensen.
212
213         Update WebKitTestRunner to set a temporary path for content extensions so that its WKTR
214         instance gets its own folder to avoid conflicts and flakiness.
215
216         * WebKitTestRunner/mac/TestControllerMac.mm:
217         (WTR::TestController::platformConfigureViewForTest):
218
219 2018-01-10  Tim Horton  <timothy_horton@apple.com>
220
221         REGRESSION (r213590): Swipe from edge to go to previous page is significantly slower than tapping back button on Twitter
222         https://bugs.webkit.org/show_bug.cgi?id=181269
223         <rdar://problem/35110344>
224
225         Reviewed by Simon Fraser.
226
227         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
228         (WTR::UIScriptController::beginBackSwipe):
229         (WTR::UIScriptController::completeBackSwipe):
230         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
231         (WTR::UIScriptController::beginBackSwipe):
232         (WTR::UIScriptController::completeBackSwipe):
233         (WTR::UIScriptController::overridePreference):
234         (WTR::UIScriptController::replaceTextAtRange):
235         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
236         (WTR::PlatformWebView::setNavigationGesturesEnabled):
237         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
238         (WTR::UIScriptController::beginBackSwipe):
239         (WTR::UIScriptController::completeBackSwipe):
240         Implement beginBackSwipe and completeBackSwipe on iOS (they already
241         exist on Mac) in terms of the new WKWebView testing SPI.
242
243 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
244
245         REGRESSION (r226715): ignore WARNING output in linter tests
246         https://bugs.webkit.org/show_bug.cgi?id=181486
247         <rdar://problem/36408847>
248
249         Reviewed by Aakash Jain.
250
251         Linter unit tests should not be interested in logs at the the INFO or WARNING levels.
252
253         * Scripts/webkitpy/common/system/outputcapture.py:
254         (OutputCapture.__init__): Pass logging level to be captured.
255         * Scripts/webkitpy/style/main_unittest.py:
256         (ExpectationLinterInStyleCheckerTest.test_no_linter_errors): Capture logging at the ERROR level.
257         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line): Ditto.
258         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_no_edit): Ditto.
259         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_edit_in_file): Ditto.
260         (ExpectationLinterInStyleCheckerTest.test_linter_duplicate_line_only_deletes): Ditto.
261         (ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Ditto.
262         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file): Ditto.
263         (ExpectationLinterInStyleCheckerTest.test_linter_deleted_file_no_edit): Ditto.
264
265 2018-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
266
267         Add a JSCOnly MIPS buildbot
268         https://bugs.webkit.org/show_bug.cgi?id=181487
269
270         Reviewed by Michael Catanzaro.
271
272         Add the new bot configs definitions for the master and update the unit tests.
273
274         * BuildSlaveSupport/build.webkit.org-config/config.json:
275         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
276
277 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
278
279         REGRESSION (r226715): don't re-check number of simulators in child processes
280         https://bugs.webkit.org/show_bug.cgi?id=181484
281         <rdar://problem/36407151>
282
283         Reviewed by Aakash Jain.
284
285         * Scripts/webkitpy/port/ios_simulator.py:
286         (IOSSimulatorPort.__init__): Skip the number of simulators check if simulators
287         are already initialized.
288
289 2018-01-10  Commit Queue  <commit-queue@webkit.org>
290
291         Unreviewed, rolling out r226667 and r226673.
292         https://bugs.webkit.org/show_bug.cgi?id=181488
293
294         This caused a flaky crash. (Requested by mlewis13 on #webkit).
295
296         Reverted changesets:
297
298         "CodeBlocks should be in IsoSubspaces"
299         https://bugs.webkit.org/show_bug.cgi?id=180884
300         https://trac.webkit.org/changeset/226667
301
302         "REGRESSION (r226667): CodeBlocks should be in IsoSubspaces"
303         https://bugs.webkit.org/show_bug.cgi?id=180884
304         https://trac.webkit.org/changeset/226673
305
306 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
307
308         Follow-up fix to r226715
309         https://bugs.webkit.org/show_bug.cgi?id=180555
310         <rdar://problem/36131381>
311
312         Unreviewed infrastructure fix.
313
314         * Scripts/webkitpy/xcode/new_simulated_device.py:
315         (SimulatedDeviceManager._create_or_find_device_for_request): Use _delete instead
316         of delete.
317
318 2018-01-10  Jonathan Bedard  <jbedard@apple.com>
319
320         webkitpy: Refactor simulator code (Part 2)
321         https://bugs.webkit.org/show_bug.cgi?id=180555
322         <rdar://problem/36131381>
323
324         Reviewed by Aakash Jain.
325
326         The patch leverages the SimulatedDeviceManager when running layout tests.
327         This patch is primarily code removal, since much of the IOSSimulatorPort
328         was dedicated to managing simulators. The removed code is either now owned by the
329         SimulatedDeviceManager (and committed in Part 1) or supported a technique to
330         boot multiple simulators which was made obsolete in Xcode 9.
331
332         * Scripts/webkitpy/layout_tests/controllers/manager.py:
333         (Manager._custom_device_for_test.in): Device names now have spaces in them,
334         strip those spaces.
335         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
336         (parse_args): Remove '--runtime' flag, this is achieved with the --version flag.
337         * Scripts/webkitpy/port/ios.py:
338         (IOSPort.__init__): The _current_device idiom is no longer required since the
339         SimulatedDeviceManager keeps track of any previously booted devices.
340         (IOSPort.target_host): Even when only a single device is used, it will be accessed
341         through the array of managed devices.
342         (IOSPort.using_multiple_devices): Deleted.
343         * Scripts/webkitpy/port/ios_device.py:
344         (IOSDevicePort.using_multiple_devices): Deleted.
345         * Scripts/webkitpy/port/ios_simulator.py:
346         (IOSSimulatorPort): Remove constants required to manage simulators, change device
347         class strings so they can be parsed by the DeviceType class.
348         (IOSSimulatorPort.__init__): Determine the number of processes to use by checking
349         the number of simulators currently booted, the number of child processes specified
350         and the maximum number of simulators supported by this system.
351         (IOSSimulatorPort._device_for_worker_number_map):Return the array of initialized
352         devices owned by the SimulatedDeviceManager.
353         (IOSSimulatorPort.ios_version): Remove support for the --runtime option.
354         (IOSSimulatorPort.default_child_processes): Use the SimulatedDeviceManager to check
355         the maximum number of supported simulators on this system.
356         (IOSSimulatorPort._create_devices): Construct a list of device requests with a
357         request for each child process and send this list to the SimulatedDeviceManager to
358         initialize the devices.
359         (IOSSimulatorPort.clean_up_test_run):
360         (IOSSimulatorPort.check_sys_deps): Check that there are simulators running the
361         specified version of iOS.
362         (IOSSimulatorPort.reset_preferences):
363         (IOSSimulatorPort.simulator_runtime): Deleted.
364         (IOSSimulatorPort.simulator_device_type): Deleted.
365         (IOSSimulatorPort._teardown_managed_simulators): Deleted.
366         (IOSSimulatorPort.use_multiple_simulator_apps): Deleted.
367         (IOSSimulatorPort._create_simulators): Deleted.
368         (IOSSimulatorPort._quit_ios_simulator): Deleted.
369         (IOSSimulatorPort._using_dedicated_simulators): Deleted.
370         (IOSSimulatorPort.using_multiple_devices): Deleted.
371         (IOSSimulatorPort._create_device): Deleted.
372         (IOSSimulatorPort.get_simulator_path): Deleted.
373         (IOSSimulatorPort._createSimulatorApps): Deleted.
374         (IOSSimulatorPort._createSimulatorApp): Deleted.
375         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
376         (TestRebaseline.test_rebaseline): Filter out commands run when determining the
377         maximum number of simulators run on this system.
378         (TestRebaselineExpectations.test_rebaseline_expectations): Ditto.
379         * Scripts/webkitpy/xcode/new_simulated_device.py:
380         (SimulatedDeviceManager._does_fulfill_request): Fixed log statement.
381
382 2018-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
383
384         WebDriver: run-webdriver-tests doesn't handle test names with a '/' correctly
385         https://bugs.webkit.org/show_bug.cgi?id=181474
386
387         Reviewed by Carlos Alberto Lopez Perez.
388
389         We use os.path.basename() to get the subtest name. If the test name contains a slash we get part of the subtest
390         name as the name.
391
392         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
393         (WebDriverTestRunnerW3C._subtest_name): Helper function to get the subtest name.
394         (WebDriverTestRunnerW3C.run): Use _subtest_name() instead of os.path.basename().
395
396 2018-01-09  Andy Estes  <aestes@apple.com>
397
398         [Xcode] Use the Apple Internal SDK if available when building ImageDiff
399         https://bugs.webkit.org/show_bug.cgi?id=181459
400
401         Reviewed by Dan Bernstein.
402
403         * ImageDiff/cg/Configurations/Base.xcconfig:
404
405 2018-01-09  Myles C. Maxfield  <mmaxfield@apple.com>
406
407         font-display:fallback can cause a visual flash (which is supposed to be impossible)
408         https://bugs.webkit.org/show_bug.cgi?id=181374
409
410         Reviewed by Simon Fraser.
411
412         The test requires Palatino.
413
414         * DumpRenderTree/mac/DumpRenderTree.mm:
415         (allowedFontFamilySet):
416         * WebKitTestRunner/mac/TestControllerMac.mm:
417         (WTR::allowedFontFamilySet):
418
419 2018-01-09  Saam Barati  <sbarati@apple.com>
420
421         Give some slack in display-profiler-outputs computation of the terminal window's number of columns
422         https://bugs.webkit.org/show_bug.cgi?id=181449
423
424         Reviewed by JF Bastien.
425
426         This allows me to Cmd+f in my terminal to search for things without
427         having the results become misaligned.
428
429         * Scripts/display-profiler-output:
430
431 2018-01-09  Basuke Suzuki  <Basuke.Suzuki@sony.com>
432
433         [webkitpy] PlatformInfo should have default argument for casual use
434         https://bugs.webkit.org/show_bug.cgi?id=180827
435
436         Reviewed by David Kilzer.
437
438         PlatformInfo should be the only way to check platform specific thing instead
439         of sys.platform or other various checks. If there is something you want to check,
440         it should be placed in PlatformInfo.
441
442         Currently to instantiate PlatformInfo, it requires arguments, which is usually
443         sys, platform and Executive(). They are straight forward and should be handled
444         by default arguments. Then we can instantiate PlatformInfo more casual.
445
446         * Scripts/webkitpy/common/system/platforminfo.py:
447         (PlatformInfo): Use relative module path import
448         (PlatformInfo.__init__):
449         (PlatformInfo.executive): Lazy instantiation of Executive()
450         (PlatformInfo.total_bytes_memory): Accessing via above property
451         (PlatformInfo.xcode_sdk_version): Ditto
452         (PlatformInfo.xcode_simctl_list): Ditto
453         (PlatformInfo.xcode_version): Ditto
454         (PlatformInfo._win_version_str): Ditto
455         * Scripts/webkitpy/common/system/systemhost.py:
456         (SystemHost.__init__):
457         * Scripts/webkitpy/common/system/user.py:
458         (User.__init__):
459
460 2018-01-09  Yoshiaki Jitsukawa  <Yoshiaki.Jitsukawa@sony.com>
461
462         [Win] Remove workaround for Bug 176442 after stopping MSVC 2015 support
463         https://bugs.webkit.org/show_bug.cgi?id=176443
464
465         Reviewed by Darin Adler.
466
467         * TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
468         (TEST):
469
470 2018-01-09  Frederic Wang  <fwang@igalia.com.fr>
471
472         check-webkit-style: Verify syntax for WK_API_AVAILABLE
473         https://bugs.webkit.org/show_bug.cgi?id=181394
474
475         Reviewed by Darin Adler.
476
477         A common syntax error for WK_API_AVAILABLE is to write ios(WK_MAC_TBA)
478         as the second parameter instead of ios(WK_IOS_TBA). This generally
479         builds for iOS on EWS but not when using the public SDK. See r224057,
480         r223207 and r226211 for example. This patch adds a basic style check
481         for that macro to prevent this kind of mistake.
482
483         * Scripts/webkitpy/style/checkers/cpp.py:
484         (check_min_versions_of_wk_api_available): New function to verify the parameters of WX_API_AVAILABLE.
485         (check_style): Run new style check.
486         (CppChecker): Add build type for the new style check.
487         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
488         (WebKitStyleTest.test_min_versions_of_wk_api_available): Add tests for the new style check.
489
490 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
491
492         [Attachment Support] Expose HTMLAttachmentElement.uniqueIdentifier to bindings
493         https://bugs.webkit.org/show_bug.cgi?id=181420
494         <rdar://problem/36365827>
495
496         Reviewed by Alex Christensen.
497
498         Adjusts some existing API tests to verify that attachment elements' uniqueIdentifiers match the uniqueIdentifier
499         of corresponding _WKAttachments.
500
501         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
502         (TestWebKitAPI::TEST):
503
504 2018-01-08  Alex Christensen  <achristensen@webkit.org>
505
506         Add WKNavigationDelegate SPI exposing WebProcess crash reason
507         https://bugs.webkit.org/show_bug.cgi?id=181410
508         <rdar://problem/36167199>
509
510         Reviewed by Wenson Hsieh.
511
512         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
513         (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]):
514         (TEST):
515
516 2018-01-08  Alex Christensen  <achristensen@webkit.org>
517
518         Add SPI for WKOpenPanelParameters._acceptedMIMETypes and _acceptedFileExtensions
519         https://bugs.webkit.org/show_bug.cgi?id=181408
520         <rdar://problem/35884960>
521
522         Reviewed by Tim Horton.
523
524         * TestWebKitAPI/Tests/WebKitCocoa/RunOpenPanel.mm:
525         (-[RunOpenPanelUIDelegate webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
526
527 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
528
529         [Attachment Support] Expose file name and content type of WKAttachment
530         https://bugs.webkit.org/show_bug.cgi?id=181390
531         <rdar://problem/36336837>
532
533         Reviewed by Tim Horton.
534
535         Adjusts some existing tests in WKAttachmentTests to exercise -requestInfo:.
536
537         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
538         (-[_WKAttachment synchronouslyRequestInfo:]):
539         (-[_WKAttachment synchronouslyRequestData:]):
540
541         Reimplement this in terms of -synchronouslyRequestInfo:.
542
543         (-[_WKAttachment expectRequestedDataToBe:]):
544         (TestWebKitAPI::TEST):
545
546 2018-01-08  Wenson Hsieh  <wenson_hsieh@apple.com>
547
548         Copying, pasting, and then deleting an attachment element breaks attachment data requests
549         https://bugs.webkit.org/show_bug.cgi?id=181365
550         <rdar://problem/36340647>
551
552         Reviewed by Tim Horton.
553
554         Adds two new attachment API tests to verify that copying and pasting an existing attachment inserts an
555         attachment element that may be edited independently of the original attachment. See WebCore/ChangeLog for more
556         detail.
557
558         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
559         (TestWebKitAPI::TEST):
560
561 2018-01-08  Youenn Fablet  <youenn@apple.com>
562
563         navigator.onLine does not work inside service workers
564         https://bugs.webkit.org/show_bug.cgi?id=181079
565         <rdar://problem/36178606>
566
567         Reviewed by Darin Adler.
568
569         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
570         (WTR::InjectedBundle::initialize): Setting service worker creation callback to inject ServiceWorkerInternals object.
571
572 2018-01-07  Saam Barati  <sbarati@apple.com>
573
574         Add total exits and total compilations sorting mode to the "full" command in display-profiler-output
575         https://bugs.webkit.org/show_bug.cgi?id=181372
576
577         Reviewed by Filip Pizlo.
578
579         Adding these sorting modes makes it easier to analyze functions
580         that recompile a lot and exit a lot.
581
582         * Scripts/display-profiler-output:
583
584 2018-01-06  Julien Brianceau  <julien.brianceau@gmail.com>
585
586         Unreviewed, remove my Cisco email from contributors.json
587
588         * Scripts/webkitpy/common/config/contributors.json:
589
590 2018-01-05  JF Bastien  <jfbastien@apple.com>
591
592         WebAssembly: poison JS object's secrets
593         https://bugs.webkit.org/show_bug.cgi?id=181339
594         <rdar://problem/36325001>
595
596         Reviewed by Mark Lam.
597
598         Update tests for swap(Poisoned<k, T>, T*)
599
600         * TestWebKitAPI/Tests/WTF/ConstExprPoisoned.cpp:
601         (TestWebKitAPI::TEST):
602         * TestWebKitAPI/Tests/WTF/Poisoned.cpp:
603         (TestWebKitAPI::TEST):
604         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp:
605         (TestWebKitAPI::TEST):
606
607 2018-01-05  Wenson Hsieh  <wenson_hsieh@apple.com>
608
609         REGRESSION(r226396) DataInteractionTests: ContentEditableToContentEditable and ContentEditableToTextarea are failing
610         https://bugs.webkit.org/show_bug.cgi?id=181359
611
612         Reviewed by Tim Horton.
613
614         Ensure that these tests still pass using older SDKs.
615
616         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
617         (TestWebKitAPI::TEST):
618
619 2018-01-05  Alex Christensen  <achristensen@webkit.org>
620
621         Rebase API test after r226469
622         https://bugs.webkit.org/show_bug.cgi?id=181308
623
624         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
625         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
626         A URL with < or > in it is now recognized as invalid by WebKit.  This is intentional, and matches our behavior before enabling the new URLParser.
627
628 2018-01-05  Alex Christensen  <achristensen@webkit.org>
629
630         Restrict navigation-time WKWebsiteDataStore swapping to main frame navigations
631         https://bugs.webkit.org/show_bug.cgi?id=181217
632
633         Reviewed by Tim Horton.
634
635         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
636         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
637         (TEST):
638
639 2018-01-05  Alex Christensen  <achristensen@webkit.org>
640
641         Add WKBundleFrameCreateFrameHandle
642         https://bugs.webkit.org/show_bug.cgi?id=181232
643         <rdar://problem/35926696>
644
645         Reviewed by Tim Horton.
646
647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
648         * TestWebKitAPI/Tests/WebKitCocoa/FrameHandleSerialization.mm: Added.
649         (mouseDidMoveOverElement):
650         (-[FrameHandleSerialization webProcessPlugIn:didCreateBrowserContextController:]):
651         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
652         (-[MouseMoveOverElementDelegate _webView:mouseDidMoveOverElement:withFlags:userInfo:]):
653         (TEST):
654
655 2018-01-05  Chris Fleizach  <cfleizach@apple.com>
656
657         iOS: Build fix after r226432.
658         
659         Unreviewed. Stop duplicating speakAs symbols for iOS.
660
661         * DumpRenderTree/AccessibilityUIElement.cpp:
662         (AccessibilityUIElement::speakAs):
663
664 2018-01-05  Javier Fernandez  <jfernandez@igalia.com>
665
666         Unreviewed, added myself as WebKit reviewer
667
668         * Scripts/webkitpy/common/config/contributors.json:
669
670 2018-01-05  Claudio Saavedra  <csaavedra@igalia.com>
671
672         WPE: Build fix after r226432.
673
674         Unreviewed. Rename ::speak() to ::speakAs().
675         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
676         (WTR::AccessibilityUIElement::speakAs):
677         (WTR::AccessibilityUIElement::speak): Deleted.
678
679 2018-01-04  Chris Fleizach  <cfleizach@apple.com>
680
681         AX: Implement updated CSS3 Speech for 'speak' and 'speak-as' properties
682         https://bugs.webkit.org/show_bug.cgi?id=180361
683
684         Reviewed by Zalan Bujtas.
685
686         * DumpRenderTree/AccessibilityUIElement.cpp:
687         (speakAsCallback):
688         (AccessibilityUIElement::speakAs):
689         (AccessibilityUIElement::getJSClass):
690         (speakCallback): Deleted.
691         (AccessibilityUIElement::speak): Deleted.
692         * DumpRenderTree/AccessibilityUIElement.h:
693         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
694         (AccessibilityUIElement::speakAs):
695         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
696         (AccessibilityUIElement::speakAs):
697         (AccessibilityUIElement::speak): Deleted.
698         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
699         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
700         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
701         (WTR::AccessibilityUIElement::speakAs):
702         (WTR::AccessibilityUIElement::speak): Deleted.
703         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
704         (WTR::AccessibilityUIElement::speakAs):
705         (WTR::AccessibilityUIElement::speak): Deleted.
706
707 2018-01-04  Jonathan Bedard  <jbedard@apple.com>
708
709         REGRESSION (r226395): test-webkitperl test expectations incorrect
710         https://bugs.webkit.org/show_bug.cgi?id=181307
711         <rdar://problem/36306558>
712
713         Rubber-stamped by Aakash Jain.
714
715         r226395 added two lines towards the beginning of
716         Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl, the line
717         numbers in the test expectations need to update.
718
719         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
720
721 2018-01-04  Tim Horton  <timothy_horton@apple.com>
722
723         WKWebView loses minimum layout size overrides that happen while the process is terminated
724         https://bugs.webkit.org/show_bug.cgi?id=181306
725         <rdar://problem/34398288>
726
727         Reviewed by Dan Bernstein.
728
729         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
730         (TEST):
731         Add a test that calling _overrideLayoutParametersWithMinimumLayoutSize
732         while the process is terminated results in the page getting the correct
733         minimum layout size.
734
735 2018-01-04  Eric Carlson  <eric.carlson@apple.com>
736
737         [MediaStream] Add Mock screen capture source
738         https://bugs.webkit.org/show_bug.cgi?id=181291
739         <rdar://problem/36298164>
740
741         Reviewed by Dean Jackson.
742
743         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test.
744         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
745         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
746
747 2018-01-04  Lucas Forschler  <lforschler@apple.com>
748
749         <rdar://problem/36300930> Change proxy server setting on master config to reach s3 servers
750
751         Reviewed by Ling Ho.
752
753         * BuildSlaveSupport/build.webkit.org-config/steps.py:
754
755 2018-01-03  Wenson Hsieh  <wenson_hsieh@apple.com>
756
757         [Attachment Support] Create attachment elements when dropping files on iOS
758         https://bugs.webkit.org/show_bug.cgi?id=181192
759         <rdar://problem/36280945>
760
761         Reviewed by Tim Horton.
762
763         Adds 3 new API tests to exercise different use cases of dropping content as attachment elements when the runtime
764         switch is enabled. See below for more details.
765
766         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
767         (-[NSItemProvider registerData:type:]):
768         (platformCopyPNG):
769         (TestWebKitAPI::TEST):
770         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
771
772         Fix some currently failing iOS drag and drop tests. In this case, there's no reason RTFD should appear in the
773         source item provider when dragging rich text *without* attachments, so this should have been a check for just
774         kUTTypeRTF instead.
775
776         (TestWebKitAPI::TEST):
777
778         Tests a few cases of inserting attachment elements via drop:
779         1.  We should distinguish between drops containing rich/plain text files from just dropping rich/plain text.
780             Instead of inserting the contents as inline web content, this should generate attachment elements.
781         2.  Test the fallback mechanism for inserting attachment elements. If the preferred presentation style is not
782             explicitly set, but there's nothing WebKit would otherwise do with the dropped content, then we should fall
783             back to inserting the content as an attachment.
784         3.  Test that if multiple attachments and inline item providers are present, WebKit will respect the order in
785             which they were inserted by the source (as opposed to, for instance, putting all of the attachments in front
786             or at the end).
787
788         * TestWebKitAPI/cocoa/TestWKWebView.h:
789         * TestWebKitAPI/cocoa/TestWKWebView.mm:
790         (-[TestWKWebView objectByEvaluatingJavaScript:]):
791
792         Add a helper method to return an object that represents the result of evaluating some given script, and rewrite
793         -stringByEvaluatingJavaScript to just turn around and call this.
794
795         (-[TestWKWebView stringByEvaluatingJavaScript:]):
796
797 2018-01-03  Ting-Wei Lan  <lantw44@gmail.com>
798
799         Replace hard-coded paths in shebangs with #!/usr/bin/env
800         https://bugs.webkit.org/show_bug.cgi?id=181040
801
802         Reviewed by Alex Christensen.
803
804         * BuildSlaveSupport/build-launcher-app:
805         * BuildSlaveSupport/build-launcher-dmg:
806         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
807         * BuildSlaveSupport/built-product-archive:
808         * BuildSlaveSupport/clean-build:
809         * BuildSlaveSupport/delete-stale-build-files:
810         * BuildSlaveSupport/download-built-product:
811         * BuildSlaveSupport/gtk/buildbot/log/run:
812         * BuildSlaveSupport/gtk/buildbot/run:
813         * BuildSlaveSupport/gtk/pulseaudio/run:
814         * BuildSlaveSupport/kill-old-processes:
815         * BuildSlaveSupport/test-result-archive:
816         * BuildSlaveSupport/win/kill-old-processes:
817         * Scripts/SpacingHeuristics.pm:
818         * Scripts/add-include:
819         * Scripts/build-api-tests:
820         * Scripts/build-dumprendertree:
821         * Scripts/build-imagediff:
822         * Scripts/build-jsc:
823         * Scripts/build-webkit:
824         * Scripts/build-webkittestrunner:
825         * Scripts/check-Xcode-source-file-types:
826         * Scripts/check-dom-results:
827         * Scripts/check-for-exit-time-destructors:
828         * Scripts/check-for-global-initializers:
829         * Scripts/check-for-inappropriate-objc-class-names:
830         * Scripts/check-for-weak-vtables-and-externals:
831         * Scripts/clean-header-guards:
832         * Scripts/compare-timing-files:
833         * Scripts/configure-xcode-for-ios-development:
834         * Scripts/copy-webkitlibraries-to-product-directory:
835         * Scripts/create-exports:
836         * Scripts/debug-minibrowser:
837         * Scripts/debug-safari:
838         * Scripts/debug-test-runner:
839         * Scripts/do-file-rename:
840         * Scripts/do-webcore-rename:
841         * Scripts/dump-webkit-tests-run:
842         * Scripts/ensure-valid-python:
843         * Scripts/execAppWithEnv:
844         * Scripts/extract-localizable-js-strings:
845         * Scripts/filter-build-webkit:
846         * Scripts/find-extra-includes:
847         * Scripts/fix-blink-patch:
848         * Scripts/generate-coverage-data:
849         * Scripts/git-add-reviewer:
850         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
851         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
852         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz:
853         * Scripts/make-new-script-test:
854         * Scripts/make-script-test-wrappers:
855         * Scripts/package-root:
856         * Scripts/parse-malloc-history:
857         * Scripts/report-include-statistics:
858         * Scripts/resolve-ChangeLogs:
859         * Scripts/run-api-tests:
860         * Scripts/run-bindings-tests:
861         * Scripts/run-content-extension-tester:
862         * Scripts/run-iexploder-tests:
863         * Scripts/run-javascriptcore-tests:
864         * Scripts/run-jsc:
865         * Scripts/run-leaks:
866         * Scripts/run-mangleme-tests:
867         * Scripts/run-minibrowser:
868         * Scripts/run-pageloadtest:
869         * Scripts/run-regexp-tests:
870         * Scripts/run-safari:
871         * Scripts/run-sunspider:
872         * Scripts/run-test-runner:
873         * Scripts/run-webkit-app:
874         * Scripts/run-webkit-httpd:
875         * Scripts/run-webkit-websocketserver:
876         * Scripts/set-webkit-configuration:
877         * Scripts/show-pretty-diff:
878         * Scripts/sort-Xcode-project-file:
879         * Scripts/split-file-by-class:
880         * Scripts/sunspider-compare-results:
881         * Scripts/svn-apply:
882         * Scripts/svn-unapply:
883         * Scripts/test-webkit-scripts:
884         * Scripts/test-webkitperl:
885         * Scripts/update-iexploder-cssproperties:
886         * Scripts/update-javascriptcore-test-results:
887         * Scripts/update-webkit:
888         * Scripts/update-webkit-auxiliary-libs:
889         * Scripts/update-webkit-dependency:
890         * Scripts/update-webkit-libs-jhbuild:
891         * Scripts/update-webkit-localizable-strings:
892         * Scripts/update-webkit-support-libs:
893         * Scripts/update-webkitgtk-libs:
894         * Scripts/update-webkitwpe-libs:
895         * Scripts/webkit-build-directory:
896         * Scripts/webkitperl/LoadAsModule.pm:
897         * Scripts/webkitperl/VCSUtils_unittest/decodeGitBinaryPatch.pl:
898         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
899         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl:
900         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl:
901         * Scripts/webkitperl/VCSUtils_unittest/generatePatchCommand.pl:
902         * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
903         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
904         * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
905         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
906         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
907         * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl:
908         * Scripts/webkitperl/VCSUtils_unittest/parseGitDiffHeader.pl:
909         * Scripts/webkitperl/VCSUtils_unittest/parsePatch.pl:
910         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
911         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
912         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
913         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
914         * Scripts/webkitperl/VCSUtils_unittest/parseUnifiedDiffHeader.pl:
915         * Scripts/webkitperl/VCSUtils_unittest/prepareParsedPatch.pl:
916         * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl:
917         * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl:
918         * Scripts/webkitperl/VCSUtils_unittest/runPatchCommand.pl:
919         * Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl:
920         * Scripts/webkitperl/auto-version_unittest/autoVersionTests.pl:
921         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl:
922         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
923         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl:
924         * Scripts/webkitperl/prepare-ChangeLog_unittest/fetchRadarURLFromBugXMLData.pl:
925         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
926         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
927         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
928         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
929         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl:
930         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl:
931         * Scripts/webkitperl/webkitdirs_unittest/appendToEnvironmentVariableList.pl:
932         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRef.pl:
933         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
934         * Scripts/webkitperl/webkitdirs_unittest/extractNonMacOSHostConfiguration.pl:
935         * Scripts/webkitperl/webkitdirs_unittest/prependToEnvironmentVariableList.pl:
936         * Scripts/webkitpy/layout_tests/servers/run_webkit_httpd.py:
937         * ccache/ccache-clang:
938         * ccache/ccache-clang++:
939         * ccache/ccache-wrapper:
940         * gtk/install-dependencies:
941         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi:
942         * iExploder/iexploder-1.3.2/htdocs/webserver.rb:
943         * iExploder/iexploder-1.3.2/tools/lasthit.rb:
944         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb:
945         * iExploder/iexploder-1.3.2/tools/showtest.rb:
946         * iExploder/iexploder-1.7.2/src/browser_harness.rb:
947         * iExploder/iexploder-1.7.2/src/iexploder.cgi:
948         * iExploder/iexploder-1.7.2/src/webserver.rb:
949         * iExploder/iexploder-1.7.2/tools/lasthit.rb:
950         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb:
951         * wpe/install-dependencies:
952
953 2018-01-03  Simon Fraser  <simon.fraser@apple.com>
954
955         filter-build-webkit filters out useful compiler error lines
956         https://bugs.webkit.org/show_bug.cgi?id=179864
957
958         Reviewed by Tim Horton.
959
960         Don't filter out lines that contain information about build errors by always showing lines
961         after a line that contains "note:" or "error:".
962
963         * Scripts/filter-build-webkit:
964         (shouldShowSubsequentLine):
965         (shouldIgnoreLine):
966
967 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
968
969         REGRESSION(r226366): [GTK] Broke TestBackForwardList and TestWebKitWebView
970         https://bugs.webkit.org/show_bug.cgi?id=173915
971
972         Unreviewed follow-up. Fix /webkit2/WebKitWebView/session-state-with-form-data and
973         /webkit2/WebKitWebView/submit-form. The form ID may be NULL, but we can't put NULL into a
974         GVariant unless we use maybe types, and maybe types are incompatible with D-Bus. So use an
975         empty string in this case.
976
977         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
978         (emitFormSubmissionEvent):
979
980 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
981
982         [GTK] Add web process API to detect when form is submitted via JavaScript
983         https://bugs.webkit.org/show_bug.cgi?id=173915
984
985         Reviewed by Carlos Garcia Campos.
986
987         Test it.
988
989         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
990         (FormSubmissionTest::FormSubmissionTest):
991         (FormSubmissionTest::~FormSubmissionTest):
992         (FormSubmissionTest::testFormSubmissionResult):
993         (FormSubmissionTest::willSendDOMEventCallback):
994         (FormSubmissionTest::willCompleteCallback):
995         (FormSubmissionTest::runJavaScriptAndWaitUntilFormSubmitted):
996         (testWebExtensionFormSubmissionSteps):
997         (beforeAll):
998         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
999         (DelayedSignal::DelayedSignal):
1000         (emitFormSubmissionEvent):
1001         (handleFormSubmissionCallback):
1002         (willSubmitFormCallback):
1003         (pageCreatedCallback):
1004
1005 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1006
1007         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/databases
1008         https://bugs.webkit.org/show_bug.cgi?id=181251
1009
1010         * Scripts/run-gtk-tests:
1011         (GtkTestRunner):
1012
1013 2018-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
1014
1015         Unreviewed, skip broken API test /webkit2/WebKitWebsiteData/ephemeral
1016         https://bugs.webkit.org/show_bug.cgi?id=181136
1017
1018         * Scripts/run-gtk-tests:
1019         (GtkTestRunner):
1020
1021 2018-01-02  Brent Fulgham  <bfulgham@apple.com>
1022
1023         [macOS, iOS] Adopt new secure coding APIs in WebKit
1024         https://bugs.webkit.org/show_bug.cgi?id=181085
1025         <rdar://problem/34837397>
1026
1027         Reviewed by Tim Horton.
1028
1029         Update API tests to use secure coding wherever possible. Currently, NSView/UIView-based classes are not
1030         capable of supporting NSSecureCoding, so pass through the current coding routines.
1031
1032         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Updated for NSSecureCoding.
1033         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm:
1034         (encodeAndDecode): Check if class supports the NSSecureCoding protocol and use non-secure coding
1035         routines if necessary.
1036         (TEST): Updated for NSSecureCoding.
1037         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm:
1038         (TestWebKitAPI::TEST): Updated for NSSecureCoding.
1039
1040 2017-12-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1041
1042         Remove std::chrono completely
1043         https://bugs.webkit.org/show_bug.cgi?id=181186
1044
1045         Reviewed by Alex Christensen.
1046
1047         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1048         (WTR::TestController::platformRunUntil):
1049
1050 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1051
1052         REGRESSION(r223253): Broke ResourceLoadStatistics layout tests for non-Cocoa ports
1053         https://bugs.webkit.org/show_bug.cgi?id=181231
1054
1055         Reviewed by Alex Christensen.
1056
1057         Implement TestController APIs needed by ResourceLoadStatistics tests.
1058
1059         * WebKitTestRunner/TestController.cpp:
1060         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
1061         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
1062
1063 2018-01-02  Tim Horton  <timothy_horton@apple.com>
1064
1065         Disable WKAttachmentTests if UIPasteboard.itemProviders is not available
1066         https://bugs.webkit.org/show_bug.cgi?id=181219
1067
1068         Reviewed by Wenson Hsieh.
1069
1070         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1071
1072 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1073
1074         Add a WebAuthentication runtime feature flag
1075         https://bugs.webkit.org/show_bug.cgi?id=181220
1076         <rdar://problem/36055305>
1077
1078         Reviewed by Brent Fulgham.
1079
1080         Renames the CredentialManagement runtime feature flag into WebAuthentication.
1081
1082         * DumpRenderTree/TestOptions.h:
1083         * DumpRenderTree/TestOptions.mm:
1084         (TestOptions::TestOptions):
1085         * DumpRenderTree/mac/DumpRenderTree.mm:
1086         (enableExperimentalFeatures):
1087         (setWebPreferencesForTestOptions):
1088         * WebKitTestRunner/TestController.cpp:
1089         (WTR::TestController::resetPreferencesToConsistentValues):
1090         (WTR::updateTestOptionsFromTestHeader):
1091         * WebKitTestRunner/TestOptions.h:
1092         (WTR::TestOptions::hasSameInitializationOptions const):
1093
1094 2018-01-02  Wenson Hsieh  <wenson_hsieh@apple.com>
1095
1096         [Attachment Support] Don't Blob-convert images and attachments with https:, http: or data: urls
1097         https://bugs.webkit.org/show_bug.cgi?id=181143
1098         <rdar://problem/36200381>
1099
1100         Reviewed by Tim Horton.
1101
1102         Add a new API test to ensure that a copied image with a data URL does not get pasted as an attachment when
1103         attachment elements are enabled.
1104
1105         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1106         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1107         (TestWebKitAPI::TEST):
1108
1109 2018-01-02  Jiewen Tan  <jiewen_tan@apple.com>
1110
1111         Update Credential Management API for WebAuthentication
1112         https://bugs.webkit.org/show_bug.cgi?id=181082
1113         <rdar://problem/36055239>
1114
1115         Reviewed by Brent Fulgham.
1116
1117         Enable Credential Management API for testing.
1118
1119         * DumpRenderTree/TestOptions.h:
1120         * WebKitTestRunner/TestOptions.h:
1121
1122 2018-01-02  Michael Catanzaro  <mcatanzaro@igalia.com>
1123
1124         [GTK] Test /webkit2/WebKitWebExtension/form-controls-associated-signal is flaky
1125         https://bugs.webkit.org/show_bug.cgi?id=168194
1126
1127         Reviewed by Carlos Garcia Campos.
1128
1129         Fix an assertion and unskip the test. The order that form controls are associated is not
1130         guaranteed.
1131
1132         * Scripts/run-gtk-tests:
1133         (GtkTestRunner):
1134         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1135         (didAssociateFormControlsCallback):
1136
1137 2018-01-02  Alex Christensen  <achristensen@webkit.org>
1138
1139         Use new WebsiteDataStore passed in through decidePolicyForNavigation SPI
1140         https://bugs.webkit.org/show_bug.cgi?id=180897
1141         <rdar://problem/35535328>
1142
1143         Reviewed by Brent Fulgham.
1144
1145         Test two forms of storage to be sure we are using a different WebsiteDataStore: cookies and sessionStorage.
1146
1147         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1148         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1149         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:startURLSchemeTask:]):
1150         (-[WebsitePoliciesWebsiteDataStoreDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1151         (websiteDataStoreTestWebView):
1152         (TEST):
1153
1154 == Rolled over to ChangeLog-2018-01-01 ==