78bd7919f975b1916992e2ace08edbcf8dcb2c91
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2
3         Unreviewed, rolling out r74881.
4         http://trac.webkit.org/changeset/74881
5         https://bugs.webkit.org/show_bug.cgi?id=52357
6
7         The EFL builder has been red for days (Requested by abarth on
8         #webkit).
9
10         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
11         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
12
13 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
14
15         Reviewed by David Levin.
16
17         Add beforeunload support to WebKitTestRunner
18         https://bugs.webkit.org/show_bug.cgi?id=52353
19         
20         This makes a number of currently failing tests pass.
21
22         * WebKitTestRunner/TestController.cpp:
23         (WTR::runBeforeUnloadConfirmPanel):
24         (WTR::createOtherPage):
25         (WTR::TestController::initialize):
26
27 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
28
29         Reviewed by Sam Weinig.
30
31         Detect, identify and recover from WebProcess crashes in run-webkit-tests
32         https://bugs.webkit.org/show_bug.cgi?id=52330
33
34         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
35         a web process crash.
36         * WebKitTestRunner/TestController.cpp:
37         (WTR::TestController::initialize): Set up a processDidCrash
38         callback.
39         (WTR::TestController::processDidCrash): Report that the Web process
40         crashed.
41         * WebKitTestRunner/TestController.h:
42
43 2011-01-12  David Levin  <levin@chromium.org>
44
45         Reviewed by Shinichiro Hamaji.
46
47         check-webkit-style -- close_expression function doesn't work correctly.
48         https://bugs.webkit.org/show_bug.cgi?id=52272
49
50         * Scripts/webkitpy/style/checkers/cpp.py:
51         (Position.__str__): Added a way to convert it to a string which is useful in tests.
52         (Position.__cmp__): Added a way to compare Position which is useful in tests and
53         generally useful (for upcoming code changes).
54         (close_expression): Changed to use Position for input and output.
55         Also, fixed many bugs such as only working correctly for parenthesis,
56         not working correctly if given an offset in a line and not finding
57         the real closing element if there were multiple closing elements in
58         the same line.
59         (detect_functions): Adjusted due to the change in arguments for
60         close_expression.
61         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
62         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
63         two positions are the same.
64         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
65         (CppStyleTest.test_close_expression): Added tests to catch the issues
66         that were fixed.
67
68 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
69
70         Unreviewed, rolling out r75576.
71         http://trac.webkit.org/changeset/75576
72         https://bugs.webkit.org/show_bug.cgi?id=52304
73
74         broke rebaseline-chromium-webkit-test (Requested by thakis on
75         #webkit).
76
77         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
78         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
79         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
80         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
81         * Scripts/webkitpy/layout_tests/port/base.py:
82         * Scripts/webkitpy/layout_tests/port/chromium.py:
83         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
84         * Scripts/webkitpy/layout_tests/port/test.py:
85         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
86         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
87         * Scripts/webkitpy/style/checkers/test_expectations.py:
88         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
89
90 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
91
92         Reviewed by Darin Adler.
93
94         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
95         https://bugs.webkit.org/show_bug.cgi?id=52307
96
97         * Scripts/old-run-webkit-tests:
98
99 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
100
101         Reviewed by Martin Robinson.
102
103         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
104         https://bugs.webkit.org/show_bug.cgi?id=50867
105
106         Fixed library extention for Mac in webkitdirs.pm and type conflict in
107         TestNetscapePlugin.cpp 
108
109         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
110         * Scripts/webkitdirs.pm:
111
112 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
113
114         Reviewed by Pavel Feldman.
115
116         Add check-inspector-strings script.
117
118         https://bugs.webkit.org/show_bug.cgi?id=52295
119
120         * Scripts/check-inspector-strings: Added.
121
122 2011-01-12  Adam Roben  <aroben@apple.com>
123
124         Advertise the .testnetscape file extension on Windows
125
126         Fixes <http://webkit.org/b/52298>
127         plugins/no-mime-with-valid-extension.html fails on Windows
128
129         Reviewed by Dan Bernstein.
130
131         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
132         FileExtents field to map the .testnetscape file extension to the
133         application/x-webkit-test-netscape MIME type, just as we do on Mac.
134
135 2011-01-12  Adam Barth  <abarth@webkit.org>
136
137         Reviewed by Eric Seidel.
138
139         Make webkit-patch support subdirectories for SVN checkouts
140         https://bugs.webkit.org/show_bug.cgi?id=52261
141
142         os.relpath does not exist on Python 2.5, so we need to call our version
143         of the API.
144
145         * Scripts/webkitpy/common/checkout/scm.py:
146
147 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
148
149         Reviewed by Eric Seidel.
150
151         Close additional pages opened during a test once the test completes.
152         https://bugs.webkit.org/show_bug.cgi?id=52276
153
154         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
155         (WTR::InjectedBundle::done):
156
157 2011-01-11  David Levin  <levin@chromium.org>
158
159         Reviewed by Eric Seidel.
160
161         Errors should be separated from the command line in bot messages.
162         https://bugs.webkit.org/show_bug.cgi?id=52275
163
164         * Scripts/webkitpy/common/system/executive.py:
165         (ScriptError.message_with_output): Added a newline to separate the command
166         line from the errors.
167         * Scripts/webkitpy/common/system/executive_unittest.py:
168         (ScriptErrorTest.test_message_with_output): Added tests for the various code
169         paths in message_with_output.
170
171 2011-01-11  Eric Seidel  <eric@webkit.org>
172
173         Unreviewed.
174
175         commit-queue should know how to upload archived results (for test flakes or general failures)
176         https://bugs.webkit.org/show_bug.cgi?id=52048
177
178         The zips are mostly empty due to forgetting -r.
179         Expected diffs were not being pulled from the archive due
180         to the archive having longer paths than I realized.
181
182         * Scripts/webkitpy/common/system/workspace.py:
183         * Scripts/webkitpy/common/system/workspace_unittest.py:
184         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
185         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
186
187 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
188
189         Reviewed by Ojan Vafai.
190
191         The current modifier parsing code in test_expectations is
192         fragile and hard-coded, so it's not easy to understand the logic
193         or easily add new types of modifiers (like GPU vs. CPU testing
194         for graphics tests, or 32-bit vs. 64-bit differences).
195
196         This is the first of two patches that will add in more generic
197         support and then eliminate the GPU-specific test expectations
198         files for Chromium.
199
200         This patch adds two standalone objects for handling modifiers. The
201         rules for interpreting modifiers, precedence, and conflicts are
202         given in the docstring to the ModifierMatcher class, which
203         returns ModifierMatchResult objects.
204         
205         This patch also adds routines to the Port interface and a
206         default set of values in the base object, in order to obtain the
207         values needed on a given test run. These values are then passed
208         to the expectation parser. This also allows us to clean up the
209         logic used to lint all of the different configurations in a
210         single test_expectations.txt file.
211
212         The next patch will merge in the separate GPU expectations file.
213
214         https://bugs.webkit.org/show_bug.cgi?id=51222
215
216         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
217         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
218         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
219         * Scripts/webkitpy/layout_tests/port/base.py:
220         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
221         * Scripts/webkitpy/layout_tests/port/chromium.py:
222         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
223         * Scripts/webkitpy/layout_tests/port/test.py:
224         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
225         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
226
227 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
228
229         Reviewed by Adam Barth.
230
231         Make webkit-patch support subdirectories for SVN checkouts
232         https://bugs.webkit.org/show_bug.cgi?id=52261
233
234         * Scripts/webkitpy/common/checkout/scm.py:
235         * Scripts/webkitpy/style_references.py:
236         * Scripts/webkitpy/tool/main.py:
237         * Scripts/webkitpy/tool/steps/preparechangelog.py:
238
239 2011-01-11  Eric Seidel  <eric@webkit.org>
240
241         Unreviewed.
242
243         commit-queue should know how to upload archived results (for test flakes or general failures)
244         https://bugs.webkit.org/show_bug.cgi?id=52048
245
246         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
247         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
248
249         * Scripts/webkitpy/common/system/workspace.py:
250         * Scripts/webkitpy/common/system/workspace_unittest.py:
251         * Scripts/webkitpy/tool/commands/queues.py:
252
253 2011-01-11  Sam Weinig  <sam@webkit.org>
254
255         Roll r75474 back in.
256
257 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
258
259         Reviewed by Kenneth Rohde Christiansen.
260
261         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
262         https://bugs.webkit.org/show_bug.cgi?id=51204
263
264         * QtTestBrowser/webpage.h:
265         (QtNAMThread::QtNAMThread):
266         (QtNAMThread::networkAccessManager):
267         (QtNAMThread::run):
268
269 2011-01-11  Peter Varga  <pvarga@webkit.org>
270
271         Unreviewed.
272
273         Add myself to committers' list.
274
275         * Scripts/webkitpy/common/config/committers.py:
276
277 2011-01-11  Eric Seidel  <eric@webkit.org>
278
279         Reviewed by Adam Barth.
280
281         commit-queue should know how to upload archived results (for test flakes or general failures)
282         https://bugs.webkit.org/show_bug.cgi?id=52048
283
284         Now the queue will always upload results.  Either the entire zip, or just
285         the diffs.txt in the case of text failures.
286
287         This should make understanding flakes much easier, and paves the way
288         for having the EWS run layout tests (and upload failures).
289
290         In order to upload .zip files I had to teach bugzilla.py to autodetect
291         mime types from the filename.  Since mimetypes.py doesn't include a mapping
292         for .patch files, I have it add one before calling guess_type.
293
294         We may find that always uploading the whole zip instead of just the -diffs.txt
295         file is preferable, but for now I'm keeping the old behavior because it makes
296         quickly understanding text failures easy.
297
298         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
299         * Scripts/webkitpy/common/system/workspace.py: Added.
300         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
301         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
302         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
303         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
304         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
305         * Scripts/webkitpy/tool/commands/queues.py:
306         * Scripts/webkitpy/tool/commands/queues_unittest.py:
307
308 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
309
310         Unreviewed, rolling out r75464.
311         http://trac.webkit.org/changeset/75464
312         https://bugs.webkit.org/show_bug.cgi?id=52193
313
314         Followup rollout for 75474 (Requested by Ossy on #webkit).
315
316         * MiniBrowser/mac/BrowserWindowController.m:
317         (-[BrowserWindowController awakeFromNib]):
318         * MiniBrowser/win/BrowserView.cpp:
319         (BrowserView::create):
320         * WebKitTestRunner/TestController.cpp:
321         (WTR::createOtherPage):
322         (WTR::TestController::initialize):
323
324 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
325
326         Reviewed by Csaba Osztrogonác.
327
328         [Qt] Baseline qt_minimal configuration
329         https://bugs.webkit.org/show_bug.cgi?id=51313
330
331         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
332         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
333         QT_NO_UNDOSTACK guard.
334
335         * QtTestBrowser/launcherwindow.cpp:
336         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
337         guards.
338         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
339         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
340         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
341         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
342
343         * QtTestBrowser/launcherwindow.h:
344         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
345         * QtTestBrowser/locationedit.h: Ditto.
346
347         * QtTestBrowser/mainwindow.cpp:
348         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
349         QT_NO_UNDOSTACK guards.
350         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
351         (MainWindow::changeLocation): Ditto.
352         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
353         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
354
355         * QtTestBrowser/webpage.cpp:
356         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
357         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
358
359         * QtTestBrowser/webview.cpp:
360         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
361         (WebViewGraphicsBased::animatedYFlip): Ditto.
362
363 2011-01-10  Sam Weinig  <sam@webkit.org>
364
365         Fix build.
366
367         * MiniBrowser/mac/BrowserWindowController.m:
368         (-[BrowserWindowController awakeFromNib]):
369         * MiniBrowser/win/BrowserView.cpp:
370         (BrowserView::create):
371         * WebKitTestRunner/TestController.cpp:
372         (WTR::createOtherPage):
373         (WTR::TestController::initialize):
374
375 2011-01-10  Eric Seidel  <eric@webkit.org>
376
377         Reviewed by Ojan Vafai.
378
379         style-queue messages are way too long for big patches
380         https://bugs.webkit.org/show_bug.cgi?id=52161
381
382         We definitely could build much fancier list-to-string-with-limit functions
383         but this should be sufficient for our needs at the moment.
384
385         * Scripts/webkitpy/common/system/executive.py:
386         * Scripts/webkitpy/common/system/executive_unittest.py:
387
388 2011-01-10  Tony Chang  <tony@chromium.org>
389
390         Unreviewed, rolling out r75398.
391         http://trac.webkit.org/changeset/75398
392         https://bugs.webkit.org/show_bug.cgi?id=52008
393
394         Some layout tests are crashing on Chromium Win.
395
396         * DumpRenderTree/chromium/WebViewHost.cpp:
397         (WebViewHost::updatePaintRect):
398         * DumpRenderTree/chromium/WebViewHost.h:
399
400 2011-01-10  Adam Roben  <aroben@apple.com>
401
402         Roll out r75392
403
404         It isn't needed now that r75289 has been rolled out.
405
406         * Scripts/run-javascriptcore-tests:
407
408 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
409
410         Reviewed by Anders Carlsson.
411
412         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
413         https://bugs.webkit.org/show_bug.cgi?id=52160
414
415         * WebKitTestRunner/mac/TestControllerMac.mm:
416         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
417         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
418         anyway.
419
420 2011-01-10  Tony Chang  <tony@chromium.org>
421
422         Reviewed by Mihai Parparita.
423
424         [chromium] fix for animated gif layout tests
425         https://bugs.webkit.org/show_bug.cgi?id=52008
426
427         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
428             to trigger gif animations.
429         (WebViewHostPaintTask::WebViewHostPaintTask):
430         (WebViewHostPaintTask::runIfValid):
431         (WebViewHost::updatePaintRect):
432         * DumpRenderTree/chromium/WebViewHost.h:
433         (WebViewHost::taskList):
434
435 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
436
437         Reviewed by Xan Lopez.
438
439         [GTK] Fix gtk2 compilation for master
440         https://bugs.webkit.org/show_bug.cgi?id=51885
441
442         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
443         (createBitmapContextFromWebView): Replaced the old
444         gdk_drawable_get_size with gdk_pixmap_get_size.
445
446 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
447
448         Reviewed by Laszlo Gombos.
449
450         [WINCE] Reenable NPAPI after r75203
451         https://bugs.webkit.org/show_bug.cgi?id=52109
452
453         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
454         it with !isEfl(), because EFL port does not support NPAPI (yet).
455
456         * Scripts/build-webkit:
457
458 2011-01-10  Adam Roben  <aroben@apple.com>
459
460         Skip some asserting JS tests
461
462         See <http://webkit.org/b/52156>.
463
464         * Scripts/run-javascriptcore-tests:
465
466 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
467
468         Reviewed by Xan Lopez.
469
470         [GTK] build-webkit disable Blob support via arguments passed to automake
471         https://bugs.webkit.org/show_bug.cgi?id=52097
472
473         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
474         build-webkit.
475
476 2011-01-10  Adam Roben  <aroben@apple.com>
477
478         Use the same name and description for TestNetscapePlugin on Windows and
479         Mac
480
481         Fixes <http://webkit.org/b/52151>
482         fast/frames/iframe-reparenting-plugins.html fails on Windows
483
484         Reviewed by Steve Falkenburg.
485
486         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
487         the name and description from Mac's Info.plist.
488
489 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
490
491         Reviewed by Laszlo Gombos.
492
493         [Qt][WK2] Guard gcc-specific syntax
494
495         Non-gcc based compliers choke on the "-include"
496         syntax for preinclude, place guard around it.
497
498         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
499         * WebKitTestRunner/qt/WebKitTestRunner.pro:
500
501 2011-01-10  Andreas Kling  <kling@webkit.org>
502
503         Reviewed by Simon Hausmann.
504
505         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
506         https://bugs.webkit.org/show_bug.cgi?id=52111
507
508         When getting a createNewPage() callback from QWKPage, create the
509         new page with the same QWKContext as the page that is passed to
510         the callback.
511
512         * MiniBrowser/qt/BrowserView.h:
513         * MiniBrowser/qt/BrowserWindow.cpp:
514         (newPageFunction):
515         (BrowserWindow::BrowserWindow):
516         * MiniBrowser/qt/BrowserWindow.h:
517
518 2011-01-10  Andreas Kling  <kling@webkit.org>
519
520         Reviewed by Kenneth Rohde Christiansen.
521
522         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
523
524         BrowserView set its own useless createNewPage() callback on QWKPage.
525         This was immediately overridden by BrowserWindow anyway, so remove
526         the BrowserView one.
527
528         * MiniBrowser/qt/BrowserView.cpp:
529         (BrowserView::BrowserView):
530
531 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
532
533         Reviewed by Jeremy Orlow.
534
535         [Chromium] Remove non-client-based Geolocation code
536         https://bugs.webkit.org/show_bug.cgi?id=50921
537
538         * DumpRenderTree/chromium/LayoutTestController.cpp:
539         (LayoutTestController::setGeolocationPermission):
540         (LayoutTestController::setMockGeolocationPosition):
541         (LayoutTestController::setMockGeolocationError):
542         * DumpRenderTree/chromium/WebViewHost.cpp:
543         (WebViewHost::geolocationClientMock):
544         (WebViewHost::reset):
545         * DumpRenderTree/chromium/WebViewHost.h:
546
547 2011-01-10  Eric Seidel  <eric@webkit.org>
548
549         Reviewed by Adam Barth.
550
551         Commit bot tried to land r? cq+ patch
552         https://bugs.webkit.org/show_bug.cgi?id=36638
553
554         It should now be possible to post a patch with r? and cq+ and the
555         commit-queue will correctly wait for the r+ before attempting to land the patch.
556         (This was a feature requested by several users.)
557
558         One caveat: We don't actually reject r-, cq+ patches from the queue
559         (we just ignore them), but I think that's OK for now.
560
561         I also noticed that setting r- once a commit-queue node had grabbed
562         a patch would not properly cancel the landing.  That's fixed and
563         tested in this patch.
564
565         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
566         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
567         * Scripts/webkitpy/tool/bot/feeders.py:
568         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
569
570 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
571
572         Reviewed by Kenneth Rohde Christiansen.
573
574         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
575         https://bugs.webkit.org/show_bug.cgi?id=51934
576
577         When accessing the network from the destructor of QWebPage, the network access manager
578         was already deleted because the object WebPage was already destructed.
579
580         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
581         The object is now destructed in the destructor of QObject.
582
583         * QtTestBrowser/webpage.cpp:
584         (WebPage::WebPage):
585         (WebPage::setQnamThreaded):
586         * QtTestBrowser/webpage.h:
587         (QtNAMThread::QtNAMThread):
588
589 2011-01-08  Eric Seidel  <eric@webkit.org>
590
591         Reviewed by Ojan Vafai.
592
593         test_failures.py should not mention TestShell (long live DumpRenderTree!)
594         https://bugs.webkit.org/show_bug.cgi?id=52067
595
596         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
597         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
598
599         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
600
601 2011-01-08  Eric Seidel  <eric@webkit.org>
602
603         Reviewed by Mihai Parparita.
604
605         commit-queue hangs when the ChangeLog diff is bad
606         https://bugs.webkit.org/show_bug.cgi?id=52072
607
608         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
609         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
610
611 2011-01-08  Adam Barth  <abarth@webkit.org>
612
613         Teach svn-apply how to re-write WebCore to Source/WebCore.
614
615         * Scripts/VCSUtils.pm:
616
617 2011-01-07  Adam Barth  <abarth@webkit.org>
618
619         Rubber-stamped by Eric Seidel.
620
621         Move WebCore to Source
622         https://bugs.webkit.org/show_bug.cgi?id=52050
623
624         Update the tools to understand WebCore's new location.
625
626         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
627         * DumpRenderTree/wscript:
628         * GNUmakefile.am:
629         * Scripts/build-webkit:
630         * Scripts/do-file-rename:
631         * Scripts/do-webcore-rename:
632         * Scripts/generate-qt-inspector-resource:
633         * Scripts/prepare-ChangeLog:
634         * Scripts/run-bindings-tests:
635         * Scripts/update-iexploder-cssproperties:
636         * Scripts/update-sources-list.py:
637         * Scripts/update-webkit-localizable-strings:
638         * Scripts/webkitdirs.pm:
639         * Scripts/webkitpy/common/config/build.py:
640         * Scripts/webkitpy/common/config/build_unittest.py:
641         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
642         * Scripts/webkitpy/style/checker.py:
643         * Scripts/webkitpy/style/checker_unittest.py:
644         * WebKitTestRunner/DerivedSources.pro:
645         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
646         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
647         * wx/browser/wscript:
648         * wx/build/settings.py:
649
650 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
651
652         Reviewed by Sam Weinig.
653
654         Make WebKitTestRunner rest between loads more robust to avoid test crashes
655         https://bugs.webkit.org/show_bug.cgi?id=52086
656
657         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
658         (WTR::InjectedBundle::didReceiveMessage):
659         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
660         (WTR::LayoutTestController::notifyDone):
661         * WebKitTestRunner/TestController.cpp:
662         (WTR::TestController::resetStateToConsistentValues):
663         (WTR::TestController::run):
664
665 2011-01-07  James Robinson  <jamesr@chromium.org>
666
667         Revert "Implement mozilla's animationTime property"
668         https://bugs.webkit.org/show_bug.cgi?id=51952
669
670         This approach isn't quite right.
671
672         * DumpRenderTree/chromium/WebViewHost.cpp:
673         (WebViewHost::paintInvalidatedRegion):
674
675 2011-01-07  Adam Roben  <aroben@apple.com>
676
677         Build master fix
678
679         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
680         (RunWebKitTests.start): Don't try to concatenate a list and a string.
681
682 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
683
684         Reviewed by Csaba Osztrogonác.
685
686         run-qtwebkit-tests should be able to kill a testsuite.
687
688         Add new option in the script that can setup a timeout for a test.
689         If the test execution takes more then specified time then the test
690         would be terminated.
691
692         [Qt] run-qtwebkit-tests needs timeout
693         https://bugs.webkit.org/show_bug.cgi?id=51894
694
695         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
696         * Scripts/run-qtwebkit-tests:
697
698 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
699
700         Unreviewed fix after r75233.
701
702         Based on idea from Eric Seidel.
703
704         Add remote zip file handling to webkitpy.
705         https://bugs.webkit.org/show_bug.cgi?id=50901
706
707         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
708
709 2011-01-07  Shane Stephens  <shanestephens@google.com>
710
711         Reviewed by Eric Seidel.
712
713         svn-apply: should support git binary delta diffs
714         https://bugs.webkit.org/show_bug.cgi?id=38864
715
716         * Scripts/VCSUtils.pm:
717         * Scripts/svn-apply:
718
719 2011-01-06  Julie Parent  <jparent@chromium.org>
720
721         Reviewed by Eric Seidel.
722
723         Test Result Server not removing old results.
724         https://bugs.webkit.org/show_bug.cgi?id=52012
725
726         * TestResultServer/model/jsonresults.py:
727         Fix off-by-one: Truncate if >= num_runs, not just >.
728         * TestResultServer/model/jsonresults_unittest.py:
729         Add unit test to test that merging in a new result with the same value
730         as the last result causes previous result to fall off.
731
732 2011-01-06  James Kozianski  <koz@chromium.org>
733
734         Reviewed by Mihai Parparita.
735
736         Add classes to provide a consistent interface to a set of files.
737         https://bugs.webkit.org/show_bug.cgi?id=50901
738
739         These classes allow us to write code that is agnostic to whether a
740         particular set of files resides in a local directory or in a zip file
741         on a remote machine.
742
743         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
744         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
745         * Scripts/webkitpy/common/system/fileset.py: Added.
746         * Scripts/webkitpy/common/system/filesystem.py:
747         * Scripts/webkitpy/common/system/filesystem_mock.py:
748         * Scripts/webkitpy/common/system/zipfileset.py: Added.
749         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
750
751 2011-01-06  Eric Seidel  <eric@webkit.org>
752
753         Reviewed by Adam Barth.
754
755         NetworkTransaction should log the url it is retrying
756         https://bugs.webkit.org/show_bug.cgi?id=52043
757
758         * Scripts/webkitpy/common/net/networktransaction.py:
759         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
760
761 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
762
763         Windows build fix.
764         Import os before using it.
765
766         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
767
768 2011-01-06  Eric Seidel  <eric@webkit.org>
769
770         Reviewed by Adam Barth.
771
772         StyleQueue fails to report errors when patches have many files
773         https://bugs.webkit.org/show_bug.cgi?id=52042
774
775         This is one of at least two errors preventing style error reporting at the moment.
776         When we moved to passing the list of files to check explicitly,
777         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
778         We could change the type of the QueueStatus.message type, or we could
779         just teach statusserver.py how to clamp values (and warn when it does).
780         I chose the latter path.
781
782         * Scripts/webkitpy/common/net/statusserver.py:
783
784 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
785
786         Reviewed by Stephanie Lewis.
787         
788         Fix syntax error in script.
789
790         Windows bots need to archive/unarchive builds to/from configuration-specific directories
791         https://bugs.webkit.org/show_bug.cgi?id=51996
792
793         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
794
795 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
796
797         Unreviewed, fixing WinCE build after r75196.
798
799         WinCE port does not (yet) support NPAPI.
800
801         * Scripts/build-webkit:
802
803 2011-01-06  Xan Lopez  <xlopez@igalia.com>
804
805         Reviewed by Darin Adler.
806
807         File::Spec->rel2abs in sunspider-compare-results mangles parameters
808         https://bugs.webkit.org/show_bug.cgi?id=52015
809
810         * Scripts/sunspider-compare-results: call rel2abs on our arguments
811         after the platform has been detected, otherwise the script will
812         mangle things like '--gtk' into '/a/path/--gtk', breaking the
813         detection.
814
815 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
816
817         Reviewed by Eric Seidel.
818
819         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
820         https://bugs.webkit.org/show_bug.cgi?id=51346
821
822         * Scripts/build-webkit:
823
824 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
825
826         Reviewed by Adam Roben.
827
828         Windows bots need to archive/unarchive builds to/from configuration-specific directories
829         https://bugs.webkit.org/show_bug.cgi?id=51996
830         
831         After the configuration directory change, we were archiving the incorrect directory for
832         build product, so we were running tests on the wrong binaries.
833         
834         This change archives the correct directory, and also unarchives it into a configuration-
835         specific directory.
836
837         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
838         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
839
840 2011-01-06  Eric Seidel  <eric@webkit.org>
841
842         Reviewed by Mihai Parparita.
843
844         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
845         https://bugs.webkit.org/show_bug.cgi?id=52002
846
847         See an example of this here:
848         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
849
850         It's due to the fact that we pass around TestFailure() instance
851         objects and yet expect them to all compare to be the same.
852
853         This is bad.  We should either have shared instances of these values
854         or we should just pass around the class names.  There are already hacks
855         in place to make TestFailure objects pass equality tests, I just added
856         a __hash__ implementation so they can be used in sets as expected.
857
858         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
859         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
860
861 2011-01-06  Evan Martin  <evan@chromium.org>
862
863         Reviewed by Tony Chang.
864
865         [gdb] handle inaccessible memory and UChar*
866         https://bugs.webkit.org/show_bug.cgi?id=52003
867
868         To pretty-print a UChar*, we just grope around in the memory
869         looking for a terminating NUL.  We need to handle the exception
870         that can occur when we poke into an invalid location.
871
872         Additionally, the logic for choosing which pretty-printer would
873         early return before hitting the point where we'd use the UChar*
874         printer.  (Did this ever work?  How did it regress?)
875
876         * gdb/webkit.py:
877
878 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
879
880         Reviewed by Ada Chan.
881
882         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
883         https://bugs.webkit.org/show_bug.cgi?id=51969
884         
885         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
886
887         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
888         (WTR::InjectedBundlePage::InjectedBundlePage):
889         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
890         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
891
892 2011-01-06  James Robinson  <jamesr@chromium.org>
893
894         Reviewed by Simon Fraser.
895
896         Implement mozilla's animationTime property
897         https://bugs.webkit.org/show_bug.cgi?id=51952
898
899         Chromium DRT support for webkitAnimationTime.
900
901         * DumpRenderTree/chromium/WebViewHost.cpp:
902         (WebViewHost::paintInvalidatedRegion):
903
904 2011-01-06  Julie Parent  <jparent@chromium.org>
905
906         Reviewed by Tony Chang.
907
908         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
909         https://bugs.webkit.org/show_bug.cgi?id=51217
910
911         * TestResultServer/model/jsonresults.py:
912         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
913         Adds missing documentation.
914         * TestResultServer/model/jsonresults_unittest.py:
915         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
916         Update test_merge to take a number of builds to truncate at.
917
918 2011-01-06  Adam Barth  <abarth@webkit.org>
919
920         Reviewed by Eric Seidel.
921
922         The EWS should log outside of the working directory
923         https://bugs.webkit.org/show_bug.cgi?id=51986
924
925         This patch prepare us for using git clean -x -d -f in the EWS wrapper
926         script, which will actually clean the working copy back to a pristine
927         state instead of leaving untracked directories and ignored files.
928
929         * Scripts/webkitpy/tool/commands/queues.py:
930         * Scripts/webkitpy/tool/commands/queues_unittest.py:
931
932 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
933
934         Windows build fix.
935         Back out attempted change to built-product-archive.
936
937         * BuildSlaveSupport/built-product-archive:
938
939 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
940
941         Windows build fix.
942         Include configuration name when unpacking a build archive.
943
944         Needed, since we split Windows build results into configuration-specific directories
945         under WebKitOutputDir.
946
947         * BuildSlaveSupport/built-product-archive:
948
949 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
950
951         Reviewed by Darin Adler.
952
953         Debug and Release builds on Windows clobber each other
954         https://bugs.webkit.org/show_bug.cgi?id=49185
955
956         Changes the structure of WebKitBuild build products directory so we
957         completely separate each build configuration into independent directories.
958         
959         Although we previously had per-configuration directories for obj, this change adds
960         per-configuration directories for bin, lib, obj, and include. Each configuration's
961         build products are stored within a directory inside of WebKitBuild.
962         
963         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
964         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
965
966         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
967         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
968         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
969         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
970         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
971         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
972         * DumpRenderTree/win/ImageDiffCommon.vsprops:
973         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
974         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
975         * FindSafari/FindSafari.vcproj:
976         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
977         * MiniBrowser/MiniBrowserPostBuild.cmd:
978         * MiniBrowser/MiniBrowserPreBuild.cmd:
979         * Scripts/webkitdirs.pm:
980         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
981         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
982         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
983         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
984         * TestWebKitAPI/win/copy-resources.cmd:
985         * WebKitAPITest/WebKitAPITestCommon.vsprops:
986         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
987         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
988         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
989         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
990         * WebKitTestRunner/win/InjectedBundle.vcproj:
991         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
992         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
993         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
994         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
995         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
996         * WinLauncher/WinLauncherCommon.vsprops:
997         * WinLauncher/WinLauncherPostBuild.cmd:
998         * WinLauncher/WinLauncherPreBuild.cmd:
999
1000 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
1001
1002         Reviewed by Ariya Hidayat.
1003
1004         [Qt] TestNetscapePlugin doesn't link on OS X
1005         https://bugs.webkit.org/show_bug.cgi?id=51948
1006
1007         Only add a dependency on libX11 on X11 systems
1008
1009         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1010
1011 2011-01-05  Jeff Miller  <jeffm@apple.com>
1012
1013         Reviewed by Adam Roben.
1014
1015         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
1016         https://bugs.webkit.org/show_bug.cgi?id=51970
1017
1018         * Scripts/webkitpy/style/checker.py:
1019         Add -readability/naming for WebKit2 C API directories.
1020
1021 2011-01-05  Eric Seidel  <eric@webkit.org>
1022
1023         Unreviewed, just fixing one more log error from my previous python patch.
1024
1025         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1026         https://bugs.webkit.org/show_bug.cgi?id=51802
1027
1028         webkit-patch failure-reason was logging about parsing errors
1029         due to my misunderstanding of how BeautifulSoup.findAll worked.
1030
1031         Fixed, and added a unit test.
1032
1033         * Scripts/webkitpy/common/net/layouttestresults.py:
1034         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1035
1036 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
1037
1038         Reviewed by Kenneth Rohde Christiansen.
1039
1040         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
1041         https://bugs.webkit.org/show_bug.cgi?id=51951
1042
1043         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
1044         to create new window from WebKit.
1045
1046         * MiniBrowser/qt/BrowserWindow.cpp:
1047         (newPageFunction):
1048         (BrowserWindow::BrowserWindow):
1049         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
1050         (BrowserWindow::newWindow):
1051         (BrowserWindow::updateUserAgentList):
1052         (BrowserWindow::showUserAgentDialog):
1053         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
1054         define the type of the backing store used for new windows.
1055         * MiniBrowser/qt/main.cpp:
1056         (main):
1057
1058 2011-01-05  Eric Seidel  <eric@webkit.org>
1059
1060         Reviewed by Ojan Vafai.
1061
1062         commit-queue should report failure type when reporting flaky tests
1063         https://bugs.webkit.org/show_bug.cgi?id=51900
1064
1065         This patch was a ridiculous amount of plumbing.  In the end I like
1066         the NRWT-style TestResult class even less.  But now we're passing
1067         a list of TestResult objects from the queue to the FlakyTestReporter.
1068         Thus the FlakyTestReporter can more easily report what type of failure
1069         occurred.
1070
1071         In the process, I found that I was not alone in finding TestResult
1072         cumbersome to use.  A bunch of code was trying to create a TestResult
1073         object with default values.  However since the constructor didn't make
1074         this easy, some places were getting it wrong (including the TestResult unit test)!
1075         I've fixed the TestResult constructor to have default values for non-essential
1076         arguments.
1077
1078         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1079         * Scripts/webkitpy/common/net/layouttestresults.py:
1080         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1081         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1082         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1083         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1084         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1085         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
1086         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1087         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1088         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1089         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
1090         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
1091         * Scripts/webkitpy/tool/commands/queues.py:
1092         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1093
1094 2011-01-05  Eric Seidel  <eric@webkit.org>
1095
1096         Unreviewed.
1097
1098         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1099         https://bugs.webkit.org/show_bug.cgi?id=51802
1100
1101         Add another unit test to cover a previously missing import.
1102
1103         * Scripts/webkitpy/common/net/layouttestresults.py:
1104         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1105
1106 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
1107
1108         Reviewed by David Levin.
1109
1110         Add mihaip@chromium.org as a reviewer
1111         https://bugs.webkit.org/show_bug.cgi?id=51966
1112         
1113         Add myself as a reviewer.
1114
1115         * Scripts/webkitpy/common/config/committers.py:
1116
1117 2011-01-05  James Simonsen  <simonjam@chromium.org>
1118
1119         Unreviewed. Adding myself to the list of committers.
1120
1121         * Scripts/webkitpy/common/config/committers.py:
1122
1123 2011-01-05  Eric Seidel  <eric@webkit.org>
1124
1125         Unreviewed.
1126
1127         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1128         https://bugs.webkit.org/show_bug.cgi?id=51802
1129
1130         Fix two exceptions seen on the bots after my original commit.
1131
1132         * Scripts/webkitpy/common/net/layouttestresults.py:
1133         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1134
1135 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
1136
1137         Reviewed by Andreas Kling.
1138
1139         [Qt]Add local storage settings to QtTestBrowser command line arguments 
1140         https://bugs.webkit.org/show_bug.cgi?id=51750
1141
1142         * QtTestBrowser/main.cpp:
1143         (LauncherApplication::handleUserOptions):
1144          Local storage settings can be enable form command line arguments for
1145          QtTestBrowser.
1146
1147 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
1148
1149         Reviewed by Martin Robinson.
1150
1151         GTK: AX: DRT needs to use correct root object method.
1152         https://bugs.webkit.org/show_bug.cgi?id=51911
1153
1154         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1155         (AccessibilityController::rootElement):
1156
1157 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1158
1159         Rubber-stamped by Csaba Osztrogonác.
1160
1161         Based on idea from Péter Gál.
1162
1163         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
1164
1165 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
1166
1167         Reviewed by Adam Barth.
1168
1169         sheriff-bot should be able to do multi-revision rollouts
1170         https://bugs.webkit.org/show_bug.cgi?id=51176
1171
1172         * Scripts/webkitpy/tool/bot/irc_command.py:
1173         * Scripts/webkitpy/tool/bot/sheriff.py:
1174         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1175
1176 2011-01-05  Eric Seidel  <eric@webkit.org>
1177
1178         Reviewed by Adam Barth.
1179
1180         queues.webkit.org should have per-bot status pages
1181         https://bugs.webkit.org/show_bug.cgi?id=51906
1182
1183         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
1184         statuses from a single queue.  Now that we have many bots servicing
1185         some queues (commit-queue, win-ews, etc.) its easy to have the messages
1186         you care about scroll off the end of the 15-message limit on the main page.
1187
1188         Eventually we should probably rename /queue-status to /queue or /queues,
1189         but that's fodder for another patch.
1190
1191         * QueueStatusServer/handlers/queuestatus.py:
1192         * QueueStatusServer/index.yaml:
1193         * QueueStatusServer/main.py:
1194         * QueueStatusServer/templates/includes/singlequeuestatus.html:
1195          - This probably should use a custom filter instead of hard-coding
1196            the URL scheme here, but I couldn't figure out how to easily
1197            create such a filter.  Most filters work with "strings" so we can't
1198            pass the status object.  We could add a method to the status
1199            object and call that, but that seemed a bit strange too.
1200         * QueueStatusServer/templates/queuestatus.html:
1201
1202 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
1203
1204         Unreviewed. Adding myself to the list of committers.
1205
1206         * Scripts/webkitpy/common/config/committers.py:
1207
1208 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
1209
1210         Reviewed by David Levin.
1211
1212         check-webkit-style treated some macros with parentheses after #elif as function calls
1213         https://bugs.webkit.org/show_bug.cgi?id=51695
1214
1215         Ingore function call space checking in any preprocessor directives
1216         (things starting with #). Change search() to match() because 
1217         preprocessor directives are supposed to be in the beginning of lines.
1218
1219         * Scripts/webkitpy/style/checkers/cpp.py:
1220         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
1221
1222 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
1223
1224         Reviewed by Tony Chang.
1225
1226         Change the --multi-load test option to --stress-opt
1227         https://bugs.webkit.org/show_bug.cgi?id=50751
1228
1229         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1230         (runTest):
1231         (main):
1232         * DumpRenderTree/chromium/TestShell.cpp:
1233         (TestShell::TestShell):
1234         * DumpRenderTree/chromium/TestShell.h:
1235         (TestShell::stressOpt):
1236         (TestShell::setStressOpt):
1237         (TestShell::stressDeopt):
1238         (TestShell::setStressDeopt):
1239         (TestShell::javaScriptFlags):
1240         (TestShell::setJavaScriptFlags):
1241         * Scripts/webkitpy/layout_tests/port/chromium.py:
1242         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1243
1244 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
1245
1246         Reviewed by Sam Weinig.
1247
1248         WK2: Support Accessibility
1249         https://bugs.webkit.org/show_bug.cgi?id=51859
1250
1251         Use rootObject() method to get top of accessibility tree.
1252
1253         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1254         (AccessibilityController::focusedElement):
1255         (AccessibilityController::rootElement):
1256
1257 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
1258
1259         Reviewed by Darin Adler.
1260
1261         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
1262         https://bugs.webkit.org/show_bug.cgi?id=51846
1263
1264         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
1265         back to GRefPtr.
1266
1267 2011-01-04  Zhe Su  <suzhe@chromium.org>
1268
1269         Reviewed by Kenneth Russell.
1270
1271         Fix insertText, setMarkedText and unmarkText methods of
1272         TextInputController to call corresponding methods of WebKit::WebView
1273         rather than WebKit::WebFrame. This change matches the behavior of
1274         chromium browser.
1275         insertText corresponds to WebView::confirmComposition(text)
1276         setMarkedText corresponds to WebView::setComposition(...)
1277         unmarkText corresponds to WebView::confirmComposition()
1278         https://bugs.webkit.org/show_bug.cgi?id=51693
1279
1280         * DumpRenderTree/chromium/TextInputController.cpp:
1281         (TextInputController::insertText):
1282         (TextInputController::setMarkedText):
1283         (TextInputController::unmarkText):
1284
1285 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
1286
1287         Reviewed by Laszlo Gombos.
1288
1289         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
1290
1291         On Symbian productDir points to the source directory. Removing all the
1292         empty files from the productDir directory corrupts the svn repository.
1293
1294         * Scripts/build-webkit:
1295
1296 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
1297
1298         Reviewed by Adam Barth.
1299
1300         [Qt] Add SelectAll option to the context menu for the editor
1301         https://bugs.webkit.org/show_bug.cgi?id=50049
1302
1303         Set shortcut for the SelectAll action.
1304
1305         * QtTestBrowser/mainwindow.cpp:
1306         (MainWindow::buildUI):
1307
1308 2011-01-03  David Levin  <levin@chromium.org>
1309
1310         Reviewed by Eric Seidel.
1311
1312         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
1313         https://bugs.webkit.org/show_bug.cgi?id=51842
1314
1315         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
1316         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
1317
1318 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1319
1320         Reviewed by David Kilzer.
1321
1322         [WINCE] Adds a build slave.
1323         https://bugs.webkit.org/show_bug.cgi?id=50523
1324
1325         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
1326         entry for a release build of the WinCE port.
1327         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
1328         flag to build the WinCE port.
1329
1330 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
1331
1332         Reviewed by David Kilzer.
1333
1334         Add WinCE support to build-webkit
1335         https://bugs.webkit.org/show_bug.cgi?id=51642
1336
1337         * Scripts/build-webkit:
1338         * Scripts/webkitdirs.pm:
1339
1340 2011-01-03  Eric Seidel  <eric@webkit.org>
1341
1342         Reviewed by Adam Barth.
1343
1344         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
1345         https://bugs.webkit.org/show_bug.cgi?id=51802
1346
1347         I'm not the biggest fan of the test_failures or test_results classes,
1348         but it's better to have one shared set of classes, than separate ones
1349         for new vs. old run-webkit-test result handling.
1350
1351         This moves the ORWT results class "LayoutTestResults" over to using
1352         TestResult and TestFailure classes, making it easy for us to
1353         make all our sheriff-bot and other webkitpy code NRWT ready.
1354
1355         This also makes it a trivial patch to generate results.json information
1356         from ORWT results.html files (for flaky test analysis, etc.) as well
1357         as making it a one-liner to report test failure types when the
1358         commit-queue sees flaky tests.
1359
1360         This patch tried not to add new functionality, but only to replace
1361         the guts of LayoutTestResults, while adding unit tests and hoping
1362         not to break anything.
1363
1364         I also moved callers which assumed User.prompt* were static/class methods
1365         to using them as instance methods (since we'll eventually want to make them such).
1366
1367         In the process of re-writing things, I broke the rebaseline command, so I wrote
1368         a unit test to catch my breakage were I do do so again in the future.
1369
1370         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1371         * Scripts/webkitpy/common/net/layouttestresults.py:
1372         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1373         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
1374         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
1375         * Scripts/webkitpy/tool/commands/queries.py:
1376         * Scripts/webkitpy/tool/commands/rebaseline.py:
1377         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
1378         * Scripts/webkitpy/tool/mocktool.py:
1379
1380 2011-01-03  Adam Barth  <abarth@webkit.org>
1381
1382         Reviewed by Simon Fraser.
1383
1384         webkit-patch shouldn't waste time cleaning a working directory that's already clean
1385         https://bugs.webkit.org/show_bug.cgi?id=51840
1386
1387         * Scripts/webkitpy/common/checkout/scm.py:
1388
1389 2011-01-03  Adam Barth  <abarth@webkit.org>
1390
1391         Reviewed by Simon Fraser.
1392
1393         webkit-patch should only hide update output if --quiet
1394         https://bugs.webkit.org/show_bug.cgi?id=51838
1395
1396         As requested by smfr.
1397
1398         * Scripts/webkitpy/tool/steps/update.py:
1399
1400 2011-01-03  Adam Barth  <abarth@webkit.org>
1401
1402         Reviewed by David Levin.
1403
1404         commit-queue shouldn't reject patches twice if two bots process the same patch
1405         https://bugs.webkit.org/show_bug.cgi?id=51805
1406
1407         Before raising an error, we first check whether the patch is still in
1408         the commit-queue.  This check is still racy, of course, but the time
1409         window is much smaller.
1410
1411         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1412
1413 2011-01-03  Sam Weinig  <sam@webkit.org>
1414
1415         Reviewed by Anders Carlsson.
1416
1417         Make run-api-tests less chatty.
1418         https://bugs.webkit.org/show_bug.cgi?id=51831
1419
1420         - Make script quiet by default and add --verbose option (replacing --quiet).
1421         - When not verbose, pipe stdout and stderr to devnull.
1422
1423         * Scripts/run-api-tests:
1424
1425 2011-01-03  Pratik Solanki  <psolanki@apple.com>
1426
1427         Unreviewed. Adding myself to committers.py.
1428
1429         * Scripts/webkitpy/common/config/committers.py:
1430
1431 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
1432
1433         Reviewed by Xan Lopez.
1434
1435         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
1436         https://bugs.webkit.org/show_bug.cgi?id=51806
1437
1438         Originally, the $libraryName is 'JavaScriptCore'. When building release 
1439         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
1440         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
1441         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
1442         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
1443         so make it 'WebKitBuild/Release/.libs'
1444
1445         * Scripts/webkitdirs.pm: 
1446
1447 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
1448
1449         Reviewed by Adam Barth.
1450
1451         Make EFL a core builder
1452         https://bugs.webkit.org/show_bug.cgi?id=51804
1453
1454         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1455         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1456
1457 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1458
1459         [Qt] Unreviewed fix after r74855 and r74875.
1460
1461         * BuildSlaveSupport/built-product-archive:
1462          - Create directories explicitly.
1463          - Pass shell=True to subprocess.call().
1464
1465 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1466
1467         [Qt] Unreviewed fix after r74855.
1468
1469         Move JavaScriptCore to Source
1470         https://bugs.webkit.org/show_bug.cgi?id=51604
1471
1472         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
1473
1474 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
1475
1476         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
1477
1478         Move JavaScriptCore to Source
1479         https://bugs.webkit.org/show_bug.cgi?id=51604
1480
1481         * Scripts/webkitdirs.pm:
1482
1483 2011-01-02  Robert Hogan  <robert@webkit.org>
1484
1485         Unreviewed, build fix.
1486
1487         [Qt] Fix DRT build after 74855
1488
1489         * DumpRenderTree/qt/DumpRenderTree.pro:
1490
1491 2011-01-01  Adam Barth  <abarth@webkit.org>
1492
1493         Remove the assumption from the Qt and Gtk builds that every project is
1494         in the root directory.
1495
1496         * Scripts/build-webkit:
1497
1498 2011-01-01  Adam Barth  <abarth@webkit.org>
1499
1500         Reviewed by Eric Seidel.
1501
1502         Teach svn-apply how to apply patches even though JavaScriptCore has moved
1503         https://bugs.webkit.org/show_bug.cgi?id=51796
1504
1505         After this change, svn-apply will magically apply patches to
1506         JavaScriptCore/foo to Source/JavaScriptCore/foo.
1507
1508         * Scripts/VCSUtils.pm:
1509
1510 2011-01-01  Adam Barth  <abarth@webkit.org>
1511
1512         Reviewed by Eric Seidel.
1513
1514         Move JavaScriptCore to Source
1515         https://bugs.webkit.org/show_bug.cgi?id=51604
1516
1517         Update references to JavaScriptCore to point to the new location.
1518
1519         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1520         * DumpRenderTree/qt/DumpRenderTree.pro:
1521         * DumpRenderTree/qt/ImageDiff.pro:
1522         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1523         * DumpRenderTree/wscript:
1524         * Scripts/build-jsc:
1525         * Scripts/build-webkit:
1526         * Scripts/do-file-rename:
1527         * Scripts/do-webcore-rename:
1528         * Scripts/run-javascriptcore-tests:
1529         * Scripts/update-javascriptcore-test-results:
1530         * Scripts/webkitdirs.pm:
1531         * Scripts/webkitpy/common/config/build_unittest.py:
1532         * Scripts/webkitpy/style/checker.py:
1533         * Scripts/webkitpy/style/checker_unittest.py:
1534         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1535         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1536         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1537         * wx/build/settings.py:
1538
1539 2011-01-01  Adam Barth  <abarth@webkit.org>
1540
1541         Reviewed by Eric Seidel.
1542
1543         Move Sources to Source
1544         https://bugs.webkit.org/show_bug.cgi?id=51794
1545
1546         Update scripts to point to the new location.
1547
1548         * Scripts/build-webkit:
1549         * Scripts/do-file-rename:
1550         * Scripts/do-webcore-rename:
1551         * Scripts/webkitpy/common/config/build.py:
1552         * Scripts/webkitpy/common/config/build_unittest.py:
1553
1554 2010-12-31  Kent Tamura  <tkent@chromium.org>
1555
1556         Reviewed by Eric Seidel.
1557
1558         [DRT/Chromium] Enable mock spell checker on non-OSX
1559         https://bugs.webkit.org/show_bug.cgi?id=51401
1560
1561         * DumpRenderTree/chromium/WebViewHost.cpp:
1562         (WebViewHost::spellCheck):
1563
1564 2010-12-31  Adam Barth  <abarth@webkit.org>
1565
1566         Reviewed by Ariya Hidayat.
1567
1568         Remove Tools/Scripts/wkstyle
1569         https://bugs.webkit.org/show_bug.cgi?id=51774
1570
1571         This script appears to not have been touched in a while and seems to
1572         have been replaced by check-webkit-style.
1573
1574         * Scripts/wkstyle: Removed.
1575
1576 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1577
1578         Unreviewed. Coding style fix.
1579
1580         * DumpRenderTree/chromium/TestShell.h:
1581
1582 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
1583
1584         Reviewed by Pavel Feldman.
1585
1586         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
1587
1588         It was a problem with Chromium DRT. DevToolsAgent object instance was
1589         attached not only to the inspected page but to the DevTools window too.
1590         As result all the inspector files were interpreted as a content of inspected page
1591         and were transfered to the DevTools scripts panel for debugging etc.
1592
1593         https://bugs.webkit.org/show_bug.cgi?id=51735
1594
1595         * DumpRenderTree/chromium/TestShell.cpp:
1596         (TestShell::TestShell):
1597         (TestShell::bindJSObjectsToWindow):
1598         (TestShell::createNewWindow):
1599         * DumpRenderTree/chromium/TestShell.h:
1600
1601 2010-12-31  Adam Barth  <abarth@webkit.org>
1602
1603         Rubber-stamped by Eric Seidel.
1604
1605         Move PageLoadTests to PerformanceTests/PageLoad
1606         https://bugs.webkit.org/show_bug.cgi?id=51771
1607
1608         Update references to PageLoadTests to point to the new location.
1609
1610         * Scripts/run-pageloadtest:
1611         * Scripts/webkitpy/common/config/build.py:
1612
1613 2010-12-31  Adam Barth  <abarth@webkit.org>
1614
1615         Rubber-stamped by Eric Seidel.
1616
1617         Move SunSpider into PerformanceTests
1618         https://bugs.webkit.org/show_bug.cgi?id=51769
1619
1620         Update these scripts to point to the new location.
1621
1622         * Scripts/run-sunspider:
1623         * Scripts/sunspider-compare-results:
1624
1625 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
1626
1627         Reviewed by Kent Tamura.
1628
1629         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
1630         https://bugs.webkit.org/show_bug.cgi?id=51728
1631         
1632         Add implementation of the Mac WebThemeEngine that uses an NSScroller
1633         to render top-level scrollbars. This makes them match the Mac port's
1634         use of an NSScrollView, which means that we'll be able to share more
1635         pixel baselines.
1636         
1637         The new rendering code will not be activated until the 
1638         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
1639         ScrollbarThemeChromiumMac.
1640
1641         * DumpRenderTree/DumpRenderTree.gypi:
1642         * DumpRenderTree/chromium/TestShellMac.mm:
1643         (platformInit):
1644         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
1645         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
1646         (+[FakeActiveWindow alwaysActiveWindow]):
1647         (+[FakeActiveWindow alwaysInactiveWindow]):
1648         (-[FakeActiveWindow initWithActiveControls:]):
1649         (-[FakeActiveWindow _hasActiveControls]):
1650         (WebThemeEngineDRTMac::paintScrollbarThumb):
1651         (stateToHIEnableState):
1652         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
1653         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
1654
1655 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
1656
1657         Reviewed by David Kilzer.
1658
1659         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
1660         used
1661         https://bugs.webkit.org/show_bug.cgi?id=51672
1662
1663         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
1664         with USE_SYSTEM_MALLOC=1
1665         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
1666         with USE_SYSTEM_MALLOC=1
1667
1668 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
1669
1670         Reviewed by David Kilzer.
1671
1672         [Qt] [Symbian] Fix build-webkit script for Symbian
1673         https://bugs.webkit.org/show_bug.cgi?id=51509
1674
1675         Set the OUTPUT_DIR for Symbian to be the same as the source
1676         directory.
1677
1678         * Scripts/webkitdirs.pm:
1679
1680 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
1681
1682         Reviewed by Darin Adler.
1683
1684         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
1685         https://bugs.webkit.org/show_bug.cgi?id=51758
1686
1687         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
1688
1689         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
1690         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
1691
1692 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
1693
1694         Unreviewed WinCE buildfix.
1695
1696         * WinCELauncher/main.cpp: Add missing include.
1697
1698 2010-12-29  Daniel Bates  <dbates@rim.com>
1699
1700         Reviewed by Darin Adler.
1701
1702         svn-apply updates date of wrong change log entry for a change log diff that
1703         contains two consecutive entries with the same author and date
1704         https://bugs.webkit.org/show_bug.cgi?id=46061
1705
1706         Fixes an issue where the date of the wrong change log entry may be modified.
1707         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
1708         in a ChangeLog file to the top of the file.
1709
1710         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
1711         diff when it detects that the diff inserts a change log entry earlier in a
1712         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
1713         change. With the advent of the commit-queue this functionality of bailing out
1714         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
1715         Instead, we should always move the change log entry to the top of the ChangeLog file.
1716
1717         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
1718         the date line of the correct change log entry in a ChangeLog diff.
1719
1720         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
1721
1722         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
1723           Updated the following unit tests now that we move entries inserted earlier to the top:
1724           - "fixChangeLogPatch: New entry inserted in middle."
1725             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
1726
1727           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
1728             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
1729
1730         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
1731
1732 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
1733
1734         Reviewed by Eric Seidel.
1735
1736         [Qt] Fixed compatibility with gold linker on X11 platforms
1737         https://bugs.webkit.org/show_bug.cgi?id=51700
1738
1739         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
1740         Linked TestNetscapePlugin with libX11 on Unix platforms
1741
1742 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
1743
1744         Reviewed by Darin Adler.
1745
1746         Circular dependency in webkitpy.common.checkout.changelog module
1747         https://bugs.webkit.org/show_bug.cgi?id=50475
1748
1749         Remove automatic import of api.Checkout module when any checkout/
1750         submodule is imported (e.g.: when checkout.scm.Git is imported).
1751
1752         * Scripts/webkitpy/common/checkout/__init__.py:
1753
1754 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
1755
1756         Reviewed by Ojan Vafai.
1757
1758         prepare-ChangeLog should support the -g option for specifying the git-commit
1759         https://bugs.webkit.org/show_bug.cgi?id=51708
1760
1761         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
1762         webkit-patch, though the exact meaning of the two options remain different.
1763
1764         * Scripts/prepare-ChangeLog: Add -g.
1765
1766 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
1767
1768         Reviewed by Simon Hausmann.
1769
1770         [Qt] Fix compilation with Qt in namespace
1771         https://bugs.webkit.org/show_bug.cgi?id=51701
1772
1773         * QtTestBrowser/webview.h:
1774
1775 2010-12-28  Daniel Bates  <dbates@rim.com>
1776
1777         Reviewed by Sam Weinig.
1778
1779         Substitute // MARK: for compiler-specific #pragma mark
1780         https://bugs.webkit.org/show_bug.cgi?id=51657
1781
1782         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
1783         substituting  "// MARK:" for "#pragma mark", which provides
1784         analogous code-bookmarking functionality under Xcode.
1785
1786         Also, for consistency, we should substitute "// MARK:" for compiler-
1787         specific "#pragma mark" in the source files for the Mac port.
1788
1789         * DumpRenderTree/AccessibilityTextMarker.cpp:
1790         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
1791         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
1792         * DumpRenderTree/mac/ObjCController.m:
1793         * MiniBrowser/mac/AppDelegate.m:
1794         * MiniBrowser/mac/BrowserWindowController.m:
1795
1796 2010-12-28  Xan Lopez  <xlopez@igalia.com>
1797
1798         Reviewed by Eric Seidel.
1799
1800         Add --no-build option to run-sunspider
1801         https://bugs.webkit.org/show_bug.cgi?id=51658
1802
1803         * Scripts/run-sunspider: add --no-build flag to skip building
1804         phase.
1805
1806 2010-12-27  Daniel Bates  <dbates@rim.com>
1807
1808         Rubber-stamped by Martin Robinson.
1809
1810         Append the directory Tools/DumpRenderTree to the list of directories that
1811         do-webcore-rename should search so that it can rename DRT files and
1812         source code.
1813
1814         * Scripts/do-webcore-rename:
1815
1816 2010-12-27  Eric Seidel  <eric@webkit.org>
1817
1818         Reviewed by Adam Barth.
1819
1820         build-webkit should detect missing Java SDK and explain how to install it
1821         https://bugs.webkit.org/show_bug.cgi?id=51651
1822
1823         * Scripts/build-webkit:
1824
1825 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
1826
1827         Reviewed by Daniel Bates.
1828
1829         [GTK] Add support for build-jsc
1830         https://bugs.webkit.org/show_bug.cgi?id=51625
1831
1832         Add GTK+ support to build-jsc now that building the jsc executable as
1833         a standalone target is easy.
1834
1835         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
1836         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
1837         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
1838         and pass it along to buildAutotoolsProject.
1839
1840 2010-12-27  David Levin  <levin@chromium.org>
1841
1842         Reviewed by Eric Seidel.
1843
1844         check-webkit-style check for meaningless variable names in function declarations.
1845         https://bugs.webkit.org/show_bug.cgi?id=51523
1846
1847         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
1848         from the new check and whitespace/parens because the syntax is unusual and
1849         produced a fair number of positives for these checks.
1850         * Scripts/webkitpy/style/checkers/cpp.py:
1851         (_convert_to_lower_with_underscores): Used as a canonical form for type names
1852         and parameter names when determining if the parameter name is useless.
1853         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
1854         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
1855         format.
1856         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
1857         text or an acronym of it.
1858         (check_function_definition): Checks function definitions for meaningless variable names.
1859         (process_line): Added call to check_function_definition.
1860         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1861         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
1862         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
1863         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
1864         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
1865         because when only checking a snippet, there are a lot of bogus functions.
1866         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
1867         that I put there previously and just noticed.
1868         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
1869         check_function_definition and process_line.
1870
1871 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1872
1873         Reviewed by Martin Robinson.
1874
1875         [GTK] Disable flash plugin in GtkLauncher when using gtk3
1876         https://bugs.webkit.org/show_bug.cgi?id=51591
1877
1878         Flash plugin uses gtk2 that is incompatible with gtk3 making
1879         webkit crash when it's built with gtk3.
1880
1881         * GtkLauncher/main.c:
1882         (main):
1883
1884 2010-12-25  Adam Barth  <abarth@webkit.org>
1885
1886         Reviewed by Eric Seidel.
1887
1888         Move ANGLE to Sources/ThirdParty
1889         https://bugs.webkit.org/show_bug.cgi?id=51605
1890
1891         * Scripts/build-webkit:
1892           - Point to the new ANGLE location.
1893
1894 2010-12-26  David Levin  <levin@chromium.org>
1895
1896         Reviewed by Eric Seidel.
1897
1898         check-webkit-style should be able to parse function declaration parameters.
1899         https://bugs.webkit.org/show_bug.cgi?id=51451
1900
1901         * Scripts/webkitpy/style/checkers/cpp.py:
1902         (Position.__init__): Holds simple position information (row, column).
1903         (Parameter.__init__): Holds information about a parameter.
1904         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
1905         (SingleLineView.convert_column_to_row): Returns the original row given a column.
1906         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
1907         (find_parameter_name_index): Finds where the parameter name is.
1908         (parameter_list): Generates the list of parameters for a function.
1909         (_FunctionState.begin): Added information to allow determining the parameters
1910         on demand.
1911         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
1912         (detect_functions): Improve function detection for operator functions and
1913         determine where the parameters end and pass that to _FunctionState.begin.
1914         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1915         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
1916         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
1917         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
1918         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
1919         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
1920         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
1921         (FunctionDetectionTest.perform_function_detection): Added support for verifying
1922         the parameters found.
1923         (FunctionDetectionTest.test_function_declaration_detection): Added more function
1924         detection test to verify that we catch the operator functions.
1925         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
1926         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
1927         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
1928         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
1929         test_function_length_check_definition_severity1_for_test.
1930
1931 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
1932
1933         Unreviewed WinCE buildfix after r74334.
1934
1935         * CMakeListsWinCE.txt:
1936
1937 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
1938
1939         Unreviewed, rolling out r74632.
1940         http://trac.webkit.org/changeset/74632
1941         https://bugs.webkit.org/show_bug.cgi?id=51600
1942
1943         makes test-webkitpy hang forever on GTK (Requested by philn-tp
1944         on #webkit).
1945
1946         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1947         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1948
1949 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
1950
1951         Reviewed by Kenneth Rohde Christiansen.
1952
1953         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
1954         https://bugs.webkit.org/show_bug.cgi?id=43528
1955
1956         Remove on_resize because ewk_view_fixed_layout_size_set should not be
1957         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
1958         FrameView, rendering was ignored when _ewk_view_smart_calculate was
1959         called.
1960
1961         * EWebLauncher/main.c:
1962         (browserCreate):
1963
1964 2010-12-24  Eric Seidel  <eric@webkit.org>
1965
1966         Reviewed by Adam Barth.
1967
1968         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
1969         https://bugs.webkit.org/show_bug.cgi?id=28291
1970
1971         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
1972         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
1973         to strings with find in the diff.
1974         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
1975
1976         * Scripts/webkitpy/common/checkout/api.py:
1977         * Scripts/webkitpy/common/checkout/diff_parser.py:
1978         * Scripts/webkitpy/tool/steps/abstractstep.py:
1979         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1980         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
1981         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
1982         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1983
1984 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
1985
1986         Reviewed by Kenneth Russell.
1987
1988         Modify new-run-webkit-tests to shut up and exit when all the threads
1989         are wedged so that test runs complete faster and we don't end up
1990         w/ enormous log files.
1991
1992         https://bugs.webkit.org/show_bug.cgi?id=51572
1993
1994         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1995         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
1996
1997 2010-12-24  Eric Seidel  <eric@webkit.org>
1998
1999         Reviewed by David Levin.
2000
2001         commit-queue should better explain how it will re-open bugs and follow duplicate chains
2002         https://bugs.webkit.org/show_bug.cgi?id=51549
2003
2004         I've had multiple people ask me about the commit-queue's behavior
2005         regarding reporting flaky tests.  I figured it would be best to just
2006         have the queue explain itself in the bugs it files.
2007
2008         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2009         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2010
2011 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
2012
2013         Reviewed by Eric Seidel.
2014
2015         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
2016         https://bugs.webkit.org/show_bug.cgi?id=51467
2017
2018         * Scripts/webkitpy/style/checker.py:
2019         * Scripts/webkitpy/style/checker_unittest.py:
2020
2021 2010-12-23  Adam Barth  <abarth@webkit.org>
2022
2023         Rubber-stamped by Eric Seidel.
2024
2025         Move JavaScriptGlue into Sources
2026         https://bugs.webkit.org/show_bug.cgi?id=51583
2027
2028         These tools refer to JavaScriptGlue and need to be updated to its new
2029         location.
2030
2031         * Scripts/build-webkit:
2032         * Scripts/do-file-rename:
2033         * Scripts/do-webcore-rename:
2034         * Scripts/webkitpy/common/config/build.py:
2035         * Scripts/webkitpy/common/config/build_unittest.py:
2036
2037 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2038
2039         Reviewed by Eric Seidel.
2040
2041         Bug 51539 - update iexploder scripts to point to new location
2042
2043         * Scripts/run-iexploder-tests:
2044         * Scripts/update-iexploder-cssproperties:
2045
2046 2010-12-23  Evan Martin  <evan@chromium.org>
2047
2048         Reviewed by Ryosuke Niwa.
2049
2050         [chromium] LayoutTestController warning in float->int conversion
2051         https://bugs.webkit.org/show_bug.cgi?id=51553
2052
2053         Rather than reading an int, converting to a float, then getting a compiler
2054         warning on passing the float to something that expects an int, instead
2055         just pass around ints.
2056
2057         No tests, fixes a compiler warning.
2058
2059         * DumpRenderTree/chromium/LayoutTestController.cpp:
2060         (parsePageSizeParameters):
2061         (LayoutTestController::pageNumberForElementById):
2062         (LayoutTestController::numberOfPages):
2063
2064 2010-12-23  Lucas Forschler  <lforschler@apple.com>
2065
2066         Reviewed by Darin Adler.
2067
2068         Bug 51537 - iexploder needs cleanup
2069         
2070         * iExploder/htdocs: Removed.
2071         * iExploder/htdocs/config.rb: Removed.
2072         * iExploder/htdocs/cssproperties.in: Removed.
2073         * iExploder/htdocs/cssvalues.in: Removed.
2074         * iExploder/htdocs/htmlattrs.in: Removed.
2075         * iExploder/htdocs/htmltags.in: Removed.
2076         * iExploder/htdocs/htmlvalues.in: Removed.
2077         * iExploder/htdocs/iexploder.cgi: Removed.
2078         * iExploder/htdocs/iexploder.rb: Removed.
2079         * iExploder/htdocs/index.html: Removed.
2080         * iExploder/htdocs/webserver.rb: Removed.
2081         * iExploder/iexploder-1.7.2/output: Removed.
2082         * iExploder/tools: Removed.
2083         * iExploder/tools/lasthit.rb: Removed.
2084         * iExploder/tools/osx_last_crash.rb: Removed.
2085         * iExploder/tools/showtest.rb: Removed.
2086
2087 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2088
2089         Reviewed by Kenneth Rohde Christiansen.
2090
2091         [EFL] Make 'single' the default backing store in EWebLauncher
2092         https://bugs.webkit.org/show_bug.cgi?id=51534
2093
2094         'single' is the simplest backing store and the one intended to be the
2095         default in the test browser. By mistake the tiled backing store was
2096         left as default in r72617.
2097
2098         * EWebLauncher/main.c:
2099         (browserCreate): ditto.
2100
2101 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
2102
2103         Reviewed by Kenneth Rohde Christiansen.
2104
2105         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
2106         https://bugs.webkit.org/show_bug.cgi?id=51533
2107
2108         There's no point in concatenating env("HOME") with "blah", so remove
2109         option from EWebLauncher.
2110
2111         * EWebLauncher/main.c:
2112         (main): ditto.
2113
2114 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
2115
2116         Reviewed by Eric Seidel.
2117
2118         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
2119
2120         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
2121         I just discovered that we have two additional GC runs per each WebViewHost.
2122         Test_shell had no such calls.
2123         These gc runs eat 15% of cpu time.
2124
2125         https://bugs.webkit.org/show_bug.cgi?id=51479
2126
2127         * DumpRenderTree/chromium/WebViewHost.cpp:
2128         (WebViewHost::~WebViewHost):
2129
2130 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2131
2132         Reviewed by Ojan Vafai.
2133
2134         This change splits out the TestRunner class into its own file.
2135         When we fork the code for message passing, we will create a new
2136         TestRunner, and this change will allow that to be more modular.
2137
2138         While we're at it, split out TestInput and ResultSummary into
2139         their own files, to reduce the size of run_webkit_tests to
2140         something more managable.
2141
2142         https://bugs.webkit.org/show_bug.cgi?id=51092
2143
2144         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2145         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
2146         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2147         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
2148         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
2149         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2150         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2151
2152  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
2153
2154         Reviewed by Ojan Vafai.
2155
2156         nrwt multiprocessing - start over, prepare to fork the code
2157  
2158         This code cleans up the signatures and implementation of the
2159         TestRunner class so we can easily fork it to run either the
2160         stable implementation or the new, unstable message-passing
2161         implementation. The two variants will have different
2162         implementations of the run_tests() method. We will switch
2163         between the two based on the setting for the '--worker-model'
2164         switch. We rename the two currently valid values to 'old-inline'
2165         and 'old-threads'.
2166
2167         https://bugs.webkit.org/show_bug.cgi?id=51081
2168
2169         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2170         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2171
2172 2010-12-22  Victor Wang  <victorw@chromium.org>
2173
2174         Reviewed by Darin Fisher.
2175
2176         [Chromium] Update chromium archive test result url in rebaseline script.
2177
2178         https://bugs.webkit.org/show_bug.cgi?id=51503
2179
2180         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
2181
2182 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2183
2184         Reviewed by Alice Liu.
2185
2186         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
2187         Verified on Chrome, Safari, and IE.
2188         With this change, we will record memory from a parent browser window and all child processes.
2189
2190         * record-memory-win/main.cpp:
2191         (ProcessArgs):
2192         (PrintUsage):
2193         (getMemoryInfo):
2194         (printProcessInfo):
2195         (evalProcesses):
2196         (UseImage):
2197         (QueryContinuously):
2198         (ElapsedTime):
2199
2200 2010-12-22  Lucas Forschler  <lforschler@apple.com>
2201
2202         Unreviewed rollout r74489, because it was missing changelog.
2203
2204         * record-memory-win/main.cpp:
2205         
2206 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
2207
2208         Adding myself as a reviewer.
2209
2210         * Scripts/webkitpy/common/config/committers.py:
2211
2212 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
2213
2214         Unreviewed.  Adding myself to committers.py.
2215
2216         * Scripts/webkitpy/common/config/committers.py:
2217
2218 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
2219
2220         Reviewed by Kenneth Rohde Christiansen.
2221
2222         TestNetscapePlugIn should use #if defined
2223         https://bugs.webkit.org/show_bug.cgi?id=51471
2224
2225         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2226         (NP_Initialize):
2227         (NPP_New):
2228
2229 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
2230
2231         Reviewed by Yury Semikhatsky.
2232
2233         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
2234
2235         DevTools window should be closed explicitly because it has custom deinitialization code.
2236
2237         https://bugs.webkit.org/show_bug.cgi?id=50722
2238
2239         * DumpRenderTree/chromium/TestShell.cpp:
2240         (TestShell::closeRemainingWindows):
2241
2242 2010-12-22  David Levin  <levin@chromium.org>
2243
2244         Reviewed by Shinichiro Hamaji.
2245
2246         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
2247         https://bugs.webkit.org/show_bug.cgi?id=51452
2248
2249         * Scripts/webkitpy/style/checkers/cpp.py:
2250         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
2251         Using the file extension if possible but falling back to the file contents if we have a header file.
2252         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
2253         (_FileState.is_c_or_objective_c):
2254         (check_using_std): Changed to using _FileState to determine the file type.
2255         (check_max_min_macros): Ditto.
2256         (check_for_null): Ditto.
2257         (check_style): Changed the parameters to various calls since they now need _FileState
2258         to determine the file type.
2259         (check_language): Added the file_state parameter so it could be passed
2260         to check_identifier_name_in_declaration.
2261         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
2262         this is an Objective C file.
2263         (_process_lines): Added information for the _FileState constructor (and moved the
2264         call to a place that had the information).
2265         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2266         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
2267         its functionality.
2268         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
2269
2270 2010-12-21  Andy Estes  <aestes@apple.com>
2271
2272         Reviewed by Mark Rowe.
2273
2274         Do not build non-Intel architectures for WebKit2-related projects.
2275         https://bugs.webkit.org/show_bug.cgi?id=51440
2276
2277         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
2278         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
2279         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
2280
2281 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
2282
2283         Reviewed by Darin Fisher.
2284
2285         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
2286         https://bugs.webkit.org/show_bug.cgi?id=51406 
2287         
2288         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
2289         to WebThemeEngineDRTWin and update references everywhere.
2290
2291         * DumpRenderTree/DumpRenderTree.gypi:
2292         * DumpRenderTree/chromium/TestShellWin.cpp:
2293         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
2294         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
2295         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
2296         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
2297
2298 2010-12-21  Anders Carlsson  <andersca@apple.com>
2299
2300         Reviewed by John Sullivan.
2301
2302         Clicking missing plug-in text does not show a sheet
2303         https://bugs.webkit.org/show_bug.cgi?id=51403
2304
2305         Update for changes to the WebPageUIClient.
2306
2307         * MiniBrowser/mac/BrowserWindowController.m:
2308         (-[BrowserWindowController awakeFromNib]):
2309         * WebKitTestRunner/TestController.cpp:
2310         (WTR::createOtherPage):
2311         (WTR::TestController::initialize):
2312
2313 2010-12-21  Eric Seidel  <eric@webkit.org>
2314
2315         Reviewed by Adam Barth.
2316
2317         commit-queue will report constant failures as flaky if other tests flake
2318         https://bugs.webkit.org/show_bug.cgi?id=51272
2319
2320         This patch just removes functionality and adds testing.
2321         Previously we attempted to report flaky tests when we had
2322         two different tests fail in a row.  However, since we stop
2323         running the tests at the first failure, our code was wrong in
2324         trying to determine flakiness from the incomplete runs.
2325
2326         Originally I posted an alternate patch:
2327         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
2328         which fixed our flaky logic in this case, however it was decided
2329         that that patch would be too difficult to maintain, so now
2330         I'm just removing the broken logic.
2331
2332         This will dramatically cut-down on our flaky-test false positives
2333         at the (small) cost of the queues being unable to report
2334         any flakiness if the tree is very flaky.  (With at least one test
2335         flaking on every run, we'll never report failures anymore.)  I think
2336         this is a tradeoff worth making.
2337
2338         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2339         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2340
2341 2010-12-20  Eric Seidel  <eric@webkit.org>
2342
2343         Reviewed by Adam Barth.
2344
2345         commit-queue wrongly rejects patches when it can't update itself
2346         https://bugs.webkit.org/show_bug.cgi?id=46636
2347
2348         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2349         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2350         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2351
2352 2010-12-20  Adam Barth  <abarth@webkit.org>
2353
2354         Move web sites to Websites directory
2355         https://bugs.webkit.org/show_bug.cgi?id=51323
2356
2357         Update references to BugsSite to point to the new location.
2358
2359         This patch was never officially reviewed (because it was too large to
2360         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
2361         Rowe gave me the green light.
2362
2363         * Scripts/old-run-webkit-tests:
2364         * Scripts/webkitpy/common/config/build.py:
2365         * Scripts/webkitpy/common/config/build_unittest.py:
2366         * Scripts/webkitpy/common/prettypatch.py:
2367         * Scripts/webkitpy/layout_tests/port/base.py:
2368         * Scripts/webkitpy/style/main.py:
2369
2370 2010-12-20  Adrienne Walker  <enne@google.com>
2371
2372         Unreviewed. Adding myself to the list of committers.
2373
2374         * webkitpy/common/config/committers.py:
2375
2376 2010-12-20  Mark Rowe  <mrowe@apple.com>
2377
2378         Reviewed by Dan Bernstein.
2379
2380         <rdar://problem/8757601> Don't install header files in to the Resources directory.
2381
2382         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
2383         Resources directory.
2384
2385 2010-12-20  Eric Seidel  <eric@webkit.org>
2386
2387         Reviewed by Adam Barth.
2388
2389         commit-queue should include bot id when attaching failure diffs
2390         https://bugs.webkit.org/show_bug.cgi?id=51280
2391
2392         This is a tiny change to include the bot id in the name of the attachment.
2393         Most of this diff is just changing the unit test expectations
2394         now that I hid the comment printing when the comment is None.
2395
2396         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2397         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2398         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2399         * Scripts/webkitpy/tool/mocktool.py:
2400
2401 2010-12-20  Jeff Miller  <jeffm@apple.com>
2402
2403         Reviewed by Dan Bernstein.
2404
2405         Tools/vcbin/midl.exe needs to be rebuilt
2406         https://bugs.webkit.org/show_bug.cgi?id=51347
2407
2408         * vcbin/midl.exe: Rebuilt.
2409
2410 2010-12-20  David Levin  <levin@chromium.org>
2411
2412         Reviewed by Ariya Hidayat.
2413
2414         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
2415         https://bugs.webkit.org/show_bug.cgi?id=51343
2416
2417         Follow up from the WebKitTools -> Tools rename.
2418
2419         * Scripts/webkit-tools-completion.sh:
2420
2421 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
2422
2423         Reviewed by James Robinson.
2424
2425         new-run-webkit-tests ignores trailing EOL differences in text tests
2426         https://bugs.webkit.org/show_bug.cgi?id=36983
2427
2428         Changed the handling of new-line characters within new-run-webkit-tests
2429         to match old-run-webkit-tests.  Differences in leading and trailing empty
2430         lines in text expectation files are no longer ignored.
2431
2432         * Scripts/webkitpy/layout_tests/port/base.py:
2433         * Scripts/webkitpy/layout_tests/port/test.py:
2434         Added unit tests.  Removed old duplicate unit test entries.
2435         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2436
2437 2010-12-20  David Levin  <levin@chromium.org>
2438
2439         Reviewed by Shinichiro Hamaji.
2440
2441         check-webkit-style should detect function declarations (and trivial functions).
2442         https://bugs.webkit.org/show_bug.cgi?id=51303
2443
2444         * Scripts/webkitpy/style/checkers/cpp.py:
2445         (_FunctionState.begin): Add is_declaration and changed the line count
2446         start to begin at -1 (which will keep the results consistent, since
2447         the starting line number passed in is one less in this change).
2448         (detect_functions): changed function detection to now catch trivial
2449         functions and declarations.
2450         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
2451         of the function as this may look at return values (when processing
2452         a declaration).
2453         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2454         (FunctionDetectionTest.perform_function_detection): Basic mechanics
2455         of testing the function detection.
2456         (FunctionDetectionTest.test_basic_function_detection): Test a simple
2457         function.
2458         (FunctionDetectionTest.test_function_declaration_detection): Test a
2459         declaration.
2460         (FunctionDetectionTest.test_non_functions): A test case for a case
2461         that caused the code to fail due to the { being in quotes.
2462         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
2463         cases to help catch false alarms for return values.
2464         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
2465         we don't get false alarms for member variables either.
2466
2467 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2468
2469         Reviewed by Antonio Gomes.
2470
2471         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
2472         https://bugs.webkit.org/show_bug.cgi?id=51319
2473
2474         * CMakeListsEfl.txt:
2475
2476 2010-12-18  Adam Barth  <abarth@webkit.org>
2477
2478         Reviewed by Sam Weinig.
2479
2480         Move WebKitExamplePlugins to Examples
2481         https://bugs.webkit.org/show_bug.cgi?id=51291
2482
2483         * Scripts/webkitpy/common/config/build.py:
2484
2485 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
2486
2487         Unreviewed Qt buildfix after r74301.
2488
2489         Rename WebKitTools to Tools
2490         https://bugs.webkit.org/show_bug.cgi?id=49861
2491
2492         * MiniBrowser/DerivedSources.pro:
2493         * MiniBrowser/qt/MiniBrowser.pro:
2494
2495 2010-12-17  Dan Bernstein  <mitz@apple.com>
2496
2497         Reviewed by Simon Fraser.
2498
2499         Rename WebKitTools to Tools
2500         https://bugs.webkit.org/show_bug.cgi?id=49861
2501
2502         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2503         * CodeCoverage/README:
2504         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2505         (WebCore::DumpRenderTree::initializeFonts):
2506         * EWSTools/start-commit-queue.sh:
2507         * EWSTools/start-queue.sh:
2508         * GNUmakefile.am:
2509         * MIDLWrapper/MIDLWrapper.cpp:
2510         (wmain):
2511         * MiniBrowser/qt/MiniBrowser.pro:
2512         * Scripts/build-api-tests:
2513         * Scripts/build-dumprendertree:
2514         * Scripts/build-webkit:
2515         * Scripts/build-webkittestrunner:
2516         * Scripts/generate-coverage-data:
2517         * Scripts/old-run-webkit-tests:
2518         * Scripts/run-api-tests:
2519         * Scripts/run-iexploder-tests:
2520         * Scripts/run-javascriptcore-tests:
2521         * Scripts/run-mangleme-tests:
2522         * Scripts/run-sunspider:
2523         * Scripts/run-webkit-websocketserver:
2524         * Scripts/sunspider-compare-results:
2525         * Scripts/test-webkitperl:
2526         * Scripts/test-webkitpy:
2527         * Scripts/update-iexploder-cssproperties:
2528         * Scripts/update-webkit:
2529         * Scripts/update-webkit-localizable-strings:
2530         * Scripts/webkitdirs.pm:
2531         * Scripts/webkitpy/common/checkout/scm.py:
2532         * Scripts/webkitpy/common/checkout/scm_unittest.py:
2533         * Scripts/webkitpy/common/config/committervalidator.py:
2534         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
2535         * Scripts/webkitpy/common/config/ports.py:
2536         * Scripts/webkitpy/common/config/ports_unittest.py:
2537         * Scripts/webkitpy/common/system/logutils_unittest.py:
2538         * Scripts/webkitpy/common/system/ospath_unittest.py:
2539         * Scripts/webkitpy/layout_tests/port/chromium.py:
2540         * Scripts/webkitpy/layout_tests/port/config.py:
2541         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2542         * Scripts/webkitpy/layout_tests/port/http_server.py:
2543         * Scripts/webkitpy/layout_tests/port/test.py:
2544         * Scripts/webkitpy/style/checker.py:
2545         * Scripts/webkitpy/style/checker_unittest.py:
2546         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2547         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2548         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2549         * WebKitTestRunner/DerivedSources.pro:
2550         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2551         (WTR::activateFonts):
2552         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2553         * wx/build/build_utils.py:
2554
2555 2010-12-16  Antonio Gomes  <agomes@rim.com>
2556
2557         Reviewed by Martin Robinson.
2558
2559         Settings::editingBehaviorType() incorrectly returns mac for the gtk build when running tests
2560         https://bugs.webkit.org/show_bug.cgi?id=51163
2561
2562         Since GTK+'s default editing behavior was changed to UNIX in r70975 (see webkitwebsettings.cpp),
2563         GTK+'s DRT should also reset to UNIX after each test execution.
2564
2565         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2566         (resetDefaultsToConsistentValues):
2567
2568 2010-12-17  David Levin  <levin@chromium.org>
2569
2570         Reviewed by Eric Seidel.
2571
2572         check-webkit-style should understand WTF #include guards
2573         https://bugs.webkit.org/show_bug.cgi?id=44911
2574
2575         * Scripts/webkitpy/style/checkers/cpp.py:
2576         (get_header_guard_cpp_variable): modify to suggest the WTF style
2577         of header guard when appropriate.
2578         (check_for_header_guard): handle multiple return values from
2579         get_header_guard_cpp_variable
2580         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2581         (CppStyleTest.test_build_header_guard): Added tests for the WTF
2582         header style.
2583
2584 2010-12-16  David Levin  <levin@chromium.org>
2585
2586         Reviewed by Eric Seidel.
2587
2588         test-webkitpy: unittest for the xml.py checker displays a decprecation warning.
2589         https://bugs.webkit.org/show_bug.cgi?id=51210
2590
2591         The error only shows up when using python 2.6 or later.
2592
2593         * Scripts/webkitpy/style/checkers/xml.py: Replace the usage of
2594         the decprecated field error,message with something equivalent.
2595
2596 2010-12-16  Mihai Parparita  <mihaip@chromium.org>
2597
2598         Reviewed by Eric Seidel.
2599
2600         Add --exit-after-n-failures/crashes to NRWT
2601         https://bugs.webkit.org/show_bug.cgi?id=51160
2602         
2603         Abort test run (in a similar way to how control-C is handled) when
2604         --exit-after-n-failures/crashes-or-timeouts are passed and we've reached
2605         that number of unexpected failures/crashes/timeouts.
2606
2607         * Scripts/webkitpy/layout_tests/port/test.py:
2608         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2609         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2610
2611 2010-12-16  David Levin  <levin@chromium.org>
2612
2613         Reviewed by Shinichiro Hamaji.
2614
2615         check-webkit-style unit tests has some duplicate boilerplate code.
2616         https://bugs.webkit.org/show_bug.cgi?id=49519
2617
2618         * Scripts/webkitpy/style/checkers/cpp.py:
2619         (update_include_state): Replaced the "io" parameter with the global
2620         configuration _unit_test_config. This allowed not calling into
2621         functions at a low level and also not plumbing through the injection
2622         information through many levels of code.
2623         (check_for_include_what_you_use): Ditto.
2624         (process_file_data): Added the ability to set up the unit test config
2625         to allow for injection.
2626         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2627         (ErrorCollector.__init__): Added support for having a filter for errors.
2628         (ErrorCollector.__call__): Ditto.
2629         (CppStyleTestBase.process_file_data): Added the ability to set unit_test_config.
2630         (CppStyleTestBase.perform_lint): Consolidated logic for the perform functions.
2631         (CppStyleTestBase.perform_single_line_lint): Replace specific calls to
2632         functions in the cpp.py with generic processing and a filter that
2633         indicates what errors should be kept.
2634         (CppStyleTestBase.perform_multi_line_lint): Ditto.
2635         (CppStyleTestBase.perform_language_rules_check): Ditto.
2636         (CppStyleTestBase.perform_function_lengths_check): Ditto.
2637         (CppStyleTestBase.perform_pass_ptr_check): Ditto.
2638         (CppStyleTestBase.perform_include_what_you_use): Ditto.
2639         (CppStyleTest.test_multi_line_comments): Added another
2640         error message which applies to the test case.
2641         (CppStyleTest.test_spacing_for_binary_ops): Fixed test
2642         to not have config.h, since it is processed as a header file.
2643         (CppStyleTest.test_static_or_global_stlstrings): Fixed variable name
2644         style and indentation in checked code.
2645         (OrderOfIncludesTest.test_check_preprocessor_in_include_section):
2646         Fixed line number.
2647         (NoNonVirtualDestructorsTest.test_multi_line_declaration_with_error):
2648         Ditto.
2649
2650 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2651
2652         Unreviewed, rolling out r74136.
2653         http://trac.webkit.org/changeset/74136
2654         https://bugs.webkit.org/show_bug.cgi?id=51135
2655
2656         r74136 breaks chromium canary bots because some tests are not
2657         rebaselined correctly to resolve EOL differences (Requested by
2658         jianli on #webkit).
2659
2660         * Scripts/webkitpy/layout_tests/port/base.py:
2661         * Scripts/webkitpy/layout_tests/port/test.py:
2662         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2663
2664 2010-12-15  Adam Roben  <aroben@apple.com>
2665
2666         Teach check-webkit-style to check .vcproj and .vsprops files for XML
2667         syntax errors
2668
2669         Fixes <http://webkit.org/b/51103> check-webkit-style should check for
2670         XML syntax errors in .vcproj/.vsprops files
2671
2672         Reviewed by Dave Levin.
2673
2674         * Scripts/webkitpy/style/checker.py: Added lists of file extensions
2675         that should be treated as XML and that should be allowed to contain
2676         carriage returns. (These lists happen to be identical currently.)
2677         (FileType): Added a new XML type.
2678         (CheckerDispatcher.should_check_and_strip_carriage_returns): Added.
2679         Just does a simple file extension check.
2680         (CheckerDispatcher._file_type): Added a case for XML files.
2681         (CheckerDispatcher._create_checker): Ditto. We use XMLChecker for XML
2682         files (surprise!).
2683         (StyleProcessor.process): Ask the dispatcher whether we should pass the
2684         lines through the carriage checker.
2685
2686         * Scripts/webkitpy/style/checker_unittest.py:
2687         (CheckerDispatcherCarriageReturnTest.test_should_check_and_strip_carriage_returns):
2688         Added. Checks a few file names to see if carriage returns are allowed
2689         or not.
2690         (CheckerDispatcherDispatchTest.assert_checker_xml): Added. Similar to
2691         other assert_checker_* functions.
2692         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2693         test_*_paths functions.
2694         (CheckerDispatcherDispatchTest.test_xml_paths): Added. Similar to other
2695         test_*_paths functions.
2696         (CheckerDispatcherDispatchTest.test_none_paths): Removed the vcproj
2697         file from this test case, as vcproj files now have a type.
2698         (StyleProcessor_CodeCoverageTest.MockDispatcher.should_check_and_strip_carriage_returns):
2699         Added. Similar to the other should_* functions.
2700         (StyleProcessor_CodeCoverageTest.test_process__carriage_returns_not_stripped):
2701         Added. Checks that carriage returns aren't checked for or stripped for
2702         allowed files.
2703
2704         * Scripts/webkitpy/style/checkers/xml.py: Added.
2705         (XMLChecker.__init__): Simple init method.
2706         (XMLChecker.check): Pass each line through the expat parser, and record
2707         a style error for any errors thrown by the parser.
2708
2709         * Scripts/webkitpy/style/checkers/xml_unittest.py: Added.
2710         (XMLCheckerTest.assert_no_error): Checks that the given XML does not
2711         produce a style error.
2712         (XMLCheckerTest.assert_error): Checks that the given XML produces an
2713         error of the given category on the given line.
2714         (XMLCheckerTest.mock_handle_style_error): Does nothing. Used for
2715         checking that the XMLChecker constructor works properly.
2716         (XMLCheckerTest.test_conflict_marker): Tests that conflict markers
2717         cause a style error (see, e.g., r73887).
2718         (XMLCheckerTest.test_extra_closing_tag): Tests that extra closing tags
2719         cause a style error (see, e.g., r73773).
2720         (XMLCheckerTest.test_init): Tests that the XMLChecker constructor works
2721         properly.
2722         (XMLCheckerTest.test_missing_closing_tag): Tests that missing closing
2723         tags cause a style error (see, e.g., r72795).
2724         (XMLCheckerTest.test_no_error): Tests that valid XML does not cause a
2725         style error.
2726
2727 2010-12-15  Lucas Forschler  <lforschler@apple.com>
2728
2729         Reviewed by Stephanie Lewis.
2730
2731         https://bugs.webkit.org/show_bug.cgi?id=51117
2732         Add a new leopard test bot
2733         really really commit to trunk this time.
2734
2735         * BuildSlaveSupport/build.webkit.org-config/config.json:
2736
2737 2010-12-15  Sam Weinig  <sam@webkit.org>
2738
2739         Reviewed by Anders Carlsson.
2740
2741         WebKit2: Can't add files to an <input type=file>
2742         https://bugs.webkit.org/show_bug.cgi?id=51087
2743
2744         * MiniBrowser/mac/BrowserWindowController.m:
2745         (runOpenPanel):
2746         (-[BrowserWindowController awakeFromNib]):
2747         Add simple implementation of runOpenPanel callback.
2748
2749         * MiniBrowser/win/BrowserView.cpp:
2750         (BrowserView::create):
2751         * WebKitTestRunner/TestController.cpp:
2752         (WTR::createOtherPage):
2753         (WTR::TestController::initialize):
2754         Stub out runOpenPanel callback. 
2755
2756 2010-12-14  Eric Seidel  <eric@webkit.org>
2757
2758         Reviewed by Adam Barth.
2759
2760         commit-queue should upload failure diffs when tests flake
2761         https://bugs.webkit.org/show_bug.cgi?id=51051
2762
2763         To make this testable I needed to pipe FileSystem down onto tool.
2764         We've wanted it there for a long time anyway.
2765
2766         This patch is kinda a big hack.  But we don't have a nice
2767         way to read results.html files.  I think this will need further
2768         revision before this code actually feels clean.
2769
2770         As part of testing this change, I had to make MockBugzilla.create_bug
2771         actually return an id (like it should) which required updating
2772         a few other unit test results (for the better).
2773
2774         The results_matching_keys change in layouttestresults/rebasline
2775         was an alternate path which I decided not to use in the end, but
2776         I left the change as it seemed an improvement.
2777
2778         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2779         * Scripts/webkitpy/common/net/layouttestresults.py:
2780         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2781         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2782         * Scripts/webkitpy/tool/commands/queues.py:
2783         * Scripts/webkitpy/tool/commands/rebaseline.py:
2784         * Scripts/webkitpy/tool/main.py:
2785         * Scripts/webkitpy/tool/mocktool.py:
2786
2787 2010-12-15  Cosmin Truta  <ctruta@chromium.org>
2788
2789         Reviewed by James Robinson.
2790
2791         new-run-webkit-tests ignores trailing EOL differences in text tests
2792         https://bugs.webkit.org/show_bug.cgi?id=36983
2793
2794         Changed the handling of new-line characters within new-run-webkit-tests
2795         to match old-run-webkit-tests.  Differences in leading and trailing empty
2796         lines in text expectation files are no longer ignored.
2797
2798         * Scripts/webkitpy/layout_tests/port/base.py:
2799         * Scripts/webkitpy/layout_tests/port/test.py:
2800         Added unit tests.  Removed old duplicate unit test entries.
2801         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
2802
2803 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2804
2805         Reviewed by Adam Barth.
2806
2807         make status-bubble white-space:nowrap so we can measure it's width without wrapping
2808         https://bugs.webkit.org/show_bug.cgi?id=51149
2809
2810         * QueueStatusServer/templates/statusbubble.html:
2811
2812 2010-12-15  Ojan Vafai  <ojan@chromium.org>
2813
2814         Reviewed by Adam Barth.
2815
2816         have the statusbubble postMessage it's metrics so that embedders can properly size the iframe
2817         https://bugs.webkit.org/show_bug.cgi?id=51125
2818
2819         * QueueStatusServer/templates/statusbubble.html:
2820
2821 2010-12-15  Darin Adler  <darin@apple.com>
2822
2823         * Scripts/webkitpy/common/net/buildbot: Added property svn:ignore.
2824
2825 2010-12-15  Sheriff Bot  <webkit.review.bot@gmail.com>
2826
2827         Unreviewed, rolling out r74117.
2828         http://trac.webkit.org/changeset/74117
2829         https://bugs.webkit.org/show_bug.cgi?id=51113
2830
2831         This broke the GTK1 build. (Requested by mrobinson on
2832         #webkit).
2833
2834         * Scripts/webkitdirs.pm:
2835
2836 2010-12-15  Amruth Raj  <amruthraj@motorola.com> and Ravi Kasibhatla  <ravi.kasibhatla@motorola.com>
2837
2838         Reviewed by Martin Robinson.
2839
2840         Change generate-forwarding-headers.pl for GTK port usage 
2841         (https://bugs.webkit.org/show_bug.cgi?id=37369)
2842
2843         * Scripts/webkitdirs.pm: Added changes to build webkit2 for GTK port using build-webkit script.
2844
2845 2010-12-14  Kent Tamura  <tkent@chromium.org>
2846
2847         Reviewed by Jian Li.
2848
2849         [DRT/Chromium] Remove another unnecessary error message
2850         https://bugs.webkit.org/show_bug.cgi?id=51083
2851
2852         * DumpRenderTree/chromium/WebViewHost.cpp:
2853         (WebViewHost::didInvalidateRect):
2854
2855 2010-12-14  Lucas Forschler  <lforschler@apple.com>
2856
2857         Reviewed by Stephanie Lewis.
2858
2859         Add a new Leopard Debug Test WK2 Bot
2860
2861         * BuildSlaveSupport/build.webkit.org-config/config.json:
2862
2863 2010-12-14  Ojan Vafai  <ojan@chromium.org>
2864
2865         Fix python unittests after http://trac.webkit.org/changeset/74070.
2866
2867         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2868
2869 2010-12-14  Kent Tamura  <tkent@chromium.org>
2870
2871         Reviewed by Jian Li.
2872
2873         [DRT/Chromium] Remove a unnecessary error message
2874         https://bugs.webkit.org/show_bug.cgi?id=51069
2875
2876         * DumpRenderTree/chromium/WebViewHost.cpp:
2877         (WebViewHost::paintInvalidatedRegion):
2878
2879 2010-12-14  Benjamin Kalman  <kalman@chromium.org>
2880
2881         Reviewed by Ojan Vafai.
2882
2883         Using BUG/BUGWK in test_expectations is error prone, should use BUGCR/BUGWK
2884         https://bugs.webkit.org/show_bug.cgi?id=48926
2885
2886         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2887         Add presubmit check that BUG isn't used, either BUGCR/BUGWK/BUGV8_.
2888
2889 2010-12-14  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2890
2891         Reviewed by Eric Seidel.
2892
2893         [Qt] [Symbian] Do not use pkg-config on Symbian as it is not supported
2894         https://bugs.webkit.org/show_bug.cgi?id=50231
2895
2896         Guard CONFIG+=link_pkgconfig with !symbian.
2897
2898         * DumpRenderTree/qt/DumpRenderTree.pro:
2899         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2900         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2901
2902 2010-12-14  Philippe Normand  <pnormand@igalia.com>
2903
2904         Reviewed by Ojan Vafai.
2905
2906         [new-run-webkit-tests] expectations parsing is slow
2907         https://bugs.webkit.org/show_bug.cgi?id=50635
2908
2909         Avoid expensive iteration of all the tests when checking if a test
2910         file is to be skipped or not.
2911
2912         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2913         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2914         * Scripts/webkitpy/layout_tests/port/test.py:
2915
2916 2010-12-14  Mario Sanchez Prada  <msanchez@igalia.com>
2917
2918         Reviewed by Xan Lopez.
2919
2920         [Gtk] Implement STATE_FOCUSED, STATE_FOCUSABLE, and corresponding events for text objects
2921         https://bugs.webkit.org/show_bug.cgi?id=27048
2922
2923         Add support in DRT for checking whether an accessibility UI
2924         element is focusable and/or focused. Implemented for GTK.
2925
2926         * DumpRenderTree/AccessibilityUIElement.cpp:
2927         (getIsFocusedCallback): New.
2928         (getIsFocusableCallback): New.
2929         (AccessibilityUIElement::getJSClass): Add the new available
2930         callbacks for isFocused and isFocusable.
2931         * DumpRenderTree/AccessibilityUIElement.h:
2932         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2933         (AccessibilityUIElement::isFocused): New, implemented by checking
2934         whether the related AtkState value is in the object's state set.
2935         (AccessibilityUIElement::isFocusable): Ditto.
2936         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2937         (AccessibilityUIElement::isFocused): New, dummy implementation.
2938         (AccessibilityUIElement::isFocusable): Ditto.
2939         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2940         (AccessibilityUIElement::isFocused): Ditto.
2941         (AccessibilityUIElement::isFocusable): Ditto.
2942
2943 2010-12-14  Eric Seidel  <eric@webkit.org>
2944
2945         Reviewed by Ojan Vafai.
2946
2947         webkit-patch should warn users when they're using a 32-bit git on a 64-bit system
2948         https://bugs.webkit.org/show_bug.cgi?id=50715
2949
2950         This patch makes webkit-patch print the following:
2951
2952         Warning: This machine is 64-bit, but the git binary (/usr/local/git/bin/git) does not support 64-bit.
2953         Install a 64-bit git for better performance, see:
2954         https://lists.webkit.org/pipermail/webkit-dev/2010-December/015249.html
2955
2956         I wrote this mostly because I have approximately 8 machines that I use
2957         and making sure each one is using a good Git install seemed folly.
2958         webkit-patch makes a lot of git calls, so using a fast git can shave
2959         several seconds in every invocation.  See the webkit-dev thread for more info.
2960
2961         This message will print twice during 'webkit-patch upload',
2962         once from webkit-patch and once from check-webkit-style.
2963
2964         Unfortunately there is no good way to test this due to how machine-dependent
2965         the code is.  I considered writing a test for the log message, but it seemed not worth it.
2966
2967         * Scripts/webkitpy/common/checkout/scm.py:
2968
2969 2010-12-13  Eric Seidel  <eric@webkit.org>
2970
2971         Reviewed by Adam Barth.
2972
2973         FlakyTestReporter doesn't understand bots running from multiple email addresses
2974         https://bugs.webkit.org/show_bug.cgi?id=50960
2975
2976         This explains at least one of the dupes of:
2977         https://bugs.webkit.org/show_bug.cgi?id=50863
2978         that we saw filed by the commit-queue this morning.
2979         I think the other one was explained by my previous fix to result counting code.
2980
2981         Since this is really hard to test with a unit test, instead I
2982         create a new (possibly useful in the future) command
2983         which given a layout test path will return you
2984         the one bug which our tools would assume it the flaky test bug.
2985         If some other script wants to use bug-for-test we'll
2986         need to extend it with some options like --create-if-missing or similar.
2987
2988         * Scripts/webkitpy/common/net/bugzilla/bug.py:
2989         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2990         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2991         * Scripts/webkitpy/tool/commands/__init__.py:
2992         * Scripts/webkitpy/tool/commands/bugfortest.py: Added.
2993
2994 2010-12-13  Mihai Parparita  <mihaip@chromium.org>
2995
2996         Reviewed by James Robinson.
2997
2998         Add option to build-webkit to not build WebKit2
2999         https://bugs.webkit.org/show_bug.cgi?id=50988
3000         
3001         Add support for a --no-webkit2 option to build-webkit. It seems to save
3002         ~1 minute from clean builds and ~10 seconds from no-op builds.
3003
3004         * Scripts/build-webkit:
3005
3006 2010-12-13  Lucas Forschler  <lforschler@apple.com>
3007
3008         Reviewed by Dave Kilzer.
3009
3010         Update iexploder from 1.3.2 to 1.7.2
3011         Move 1.3.2 into its own subdir
3012         Add 1.7.2 into its own subdir
3013         update scripts to point to new 1.3.2 location (avoid breaking existing scripts)
3014
3015         * Scripts/run-iexploder-tests:
3016         * Scripts/update-iexploder-cssproperties:
3017         * iExploder/CHANGELOG.txt: Removed.
3018         * iExploder/LICENSE.txt: Removed.
3019         * iExploder/README.txt: Removed.
3020         * iExploder/htdocs: Removed.
3021         * iExploder/iexploder-1.3.2: Added.
3022         * iExploder/iexploder-1.3.2/CHANGELOG.txt: Copied from iExploder/CHANGELOG.txt.
3023         * iExploder/iexploder-1.3.2/LICENSE.txt: Copied from iExploder/LICENSE.txt.
3024         * iExploder/iexploder-1.3.2/README.txt: Copied from iExploder/README.txt.
3025         * iExploder/iexploder-1.3.2/htdocs: Added.
3026         * iExploder/iexploder-1.3.2/htdocs/config.rb: Copied from iExploder/htdocs/config.rb.
3027         * iExploder/iexploder-1.3.2/htdocs/cssproperties.in: Copied from iExploder/htdocs/cssproperties.in.
3028         * iExploder/iexploder-1.3.2/htdocs/cssvalues.in: Copied from iExploder/htdocs/cssvalues.in.
3029         * iExploder/iexploder-1.3.2/htdocs/htmlattrs.in: Copied from iExploder/htdocs/htmlattrs.in.
3030         * iExploder/iexploder-1.3.2/htdocs/htmltags.in: Copied from iExploder/htdocs/htmltags.in.
3031         * iExploder/iexploder-1.3.2/htdocs/htmlvalues.in: Copied from iExploder/htdocs/htmlvalues.in.
3032         * iExploder/iexploder-1.3.2/htdocs/iexploder.cgi: Copied from iExploder/htdocs/iexploder.cgi.
3033         * iExploder/iexploder-1.3.2/htdocs/iexploder.rb: Copied from iExploder/htdocs/iexploder.rb.
3034         * iExploder/iexploder-1.3.2/htdocs/index.html: Copied from iExploder/htdocs/index.html.
3035         * iExploder/iexploder-1.3.2/htdocs/webserver.rb: Copied from iExploder/htdocs/webserver.rb.
3036         * iExploder/iexploder-1.3.2/tools: Added.
3037         * iExploder/iexploder-1.3.2/tools/lasthit.rb: Copied from iExploder/tools/lasthit.rb.
3038         * iExploder/iexploder-1.3.2/tools/osx_last_crash.rb: Copied from iExploder/tools/osx_last_crash.rb.
3039         * iExploder/iexploder-1.3.2/tools/showtest.rb: Copied from iExploder/tools/showtest.rb.
3040         * iExploder/iexploder-1.7.2: Added.
3041         * iExploder/iexploder-1.7.2/ChangeLog.txt: Added.
3042         * iExploder/iexploder-1.7.2/LICENSE.txt: Added.
3043         * iExploder/iexploder-1.7.2/README.txt: Added.
3044         * iExploder/iexploder-1.7.2/output: Added.
3045         * iExploder/iexploder-1.7.2/src: Added.
3046         * iExploder/iexploder-1.7.2/src/browser_harness.rb: Added.
3047         * iExploder/iexploder-1.7.2/src/config.yaml: Added.
3048         * iExploder/iexploder-1.7.2/src/css-atrules: Added.
3049         * iExploder/iexploder-1.7.2/src/css-atrules/mozilla: Added.
3050         * iExploder/iexploder-1.7.2/src/css-atrules/webkit: Added.
3051         * iExploder/iexploder-1.7.2/src/css-properties: Added.
3052         * iExploder/iexploder-1.7.2/src/css-properties/dillo: Added.
3053         * iExploder/iexploder-1.7.2/src/css-properties/gtkhtml: Added.
3054         * iExploder/iexploder-1.7.2/src/css-properties/internet_explorer6: Added.
3055         * iExploder/iexploder-1.7.2/src/css-properties/mozilla: Added.
3056         * iExploder/iexploder-1.7.2/src/css-properties/webkit: Added.
3057         * iExploder/iexploder-1.7.2/src/css-pseudo: Added.
3058         * iExploder/iexploder-1.7.2/src/css-pseudo/mozilla: Added.
3059         * iExploder/iexploder-1.7.2/src/css-pseudo/webkit: Added.
3060         * iExploder/iexploder-1.7.2/src/css-values: Added.
3061         * iExploder/iexploder-1.7.2/src/css-values/dillo: Added.
3062         * iExploder/iexploder-1.7.2/src/css-values/gtkhtml: Added.
3063         * iExploder/iexploder-1.7.2/src/css-values/mozilla: Added.
3064         * iExploder/iexploder-1.7.2/src/css-values/other: Added.
3065         * iExploder/iexploder-1.7.2/src/css-values/webkit: Added.
3066         * iExploder/iexploder-1.7.2/src/headers: Added.
3067         * iExploder/iexploder-1.7.2/src/headers/dillo: Added.
3068         * iExploder/iexploder-1.7.2/src/headers/gtkhtml: Added.
3069         * iExploder/iexploder-1.7.2/src/headers/mozilla: Added.
3070         * iExploder/iexploder-1.7.2/src/headers/webkit: Added.
3071         * iExploder/iexploder-1.7.2/src/html-attrs: Added.
3072         * iExploder/iexploder-1.7.2/src/html-attrs/dillo: Added.
3073         * iExploder/iexploder-1.7.2/src/html-attrs/gtkhtml: Added.
3074         * iExploder/iexploder-1.7.2/src/html-attrs/internet_explorer6: Added.
3075         * iExploder/iexploder-1.7.2/src/html-attrs/mozilla: Added.
3076         * iExploder/iexploder-1.7.2/src/html-attrs/other: Added.
3077         * iExploder/iexploder-1.7.2/src/html-attrs/webkit: Added.
3078         * iExploder/iexploder-1.7.2/src/html-tags: Added.
3079         * iExploder/iexploder-1.7.2/src/html-tags/dillo: Added.
3080         * iExploder/iexploder-1.7.2/src/html-tags/gtkhtml: Added.
3081         * iExploder/iexploder-1.7.2/src/html-tags/mozilla: Added.
3082         * iExploder/iexploder-1.7.2/src/html-tags/other: Added.
3083         * iExploder/iexploder-1.7.2/src/html-tags/webkit: Added.
3084         * iExploder/iexploder-1.7.2/src/html-values: Added.
3085         * iExploder/iexploder-1.7.2/src/html-values/dillo: Added.
3086         * iExploder/iexploder-1.7.2/src/html-values/gtkhtml: Added.
3087         * iExploder/iexploder-1.7.2/src/html-values/mozilla: Added.
3088         * iExploder/iexploder-1.7.2/src/html-values/other: Added.
3089         * iExploder/iexploder-1.7.2/src/html-values/webkit: Added.
3090         * iExploder/iexploder-1.7.2/src/iexploder.cgi: Added.
3091         * iExploder/iexploder-1.7.2/src/iexploder.rb: Added.
3092         * iExploder/iexploder-1.7.2/src/index.html: Added.
3093         * iExploder/iexploder-1.7.2/src/media: Added.
3094         * iExploder/iexploder-1.7.2/src/media/blank.ogg: Added.
3095         * iExploder/iexploder-1.7.2/src/media/blank.snd: Added.
3096         * iExploder/iexploder-1.7.2/src/media/blank.wav: Added.
3097         * iExploder/iexploder-1.7.2/src/media/bug.bmp: Added.
3098         * iExploder/iexploder-1.7.2/src/media/bug.gif: Added.
3099         * iExploder/iexploder-1.7.2/src/media/bug.ico: Added.
3100         * iExploder/iexploder-1.7.2/src/media/bug.jng: Added.
3101         * iExploder/iexploder-1.7.2/src/media/bug.jpg: Added.
3102         * iExploder/iexploder-1.7.2/src/media/bug.png: Added.
3103         * iExploder/iexploder-1.7.2/src/media/bug.svg: Added.
3104         * iExploder/iexploder-1.7.2/src/media/bug.tiff: Added.
3105         * iExploder/iexploder-1.7.2/src/media/bug.xbm: Added.
3106         * iExploder/iexploder-1.7.2/src/media/bug.xpm: Added.
3107         * iExploder/iexploder-1.7.2/src/mime-types: Added.
3108         * iExploder/iexploder-1.7.2/src/mime-types/dillo: Added.
3109         * iExploder/iexploder-1.7.2/src/mime-types/mozilla: Added.
3110         * iExploder/iexploder-1.7.2/src/mime-types/webkit: Added.
3111         * iExploder/iexploder-1.7.2/src/protocols: Added.
3112         * iExploder/iexploder-1.7.2/src/protocols/dillo: Added.
3113         * iExploder/iexploder-1.7.2/src/protocols/gtkhtml: Added.
3114         * iExploder/iexploder-1.7.2/src/protocols/mozilla: Added.
3115         * iExploder/iexploder-1.7.2/src/protocols/webkit: Added.
3116         * iExploder/iexploder-1.7.2/src/scanner.rb: Added.
3117         * iExploder/iexploder-1.7.2/src/version.rb: Added.
3118         * iExploder/iexploder-1.7.2/src/webserver.rb: Added.
3119         * iExploder/iexploder-1.7.2/testcases: Added.
3120         * iExploder/iexploder-1.7.2/testcases/testcase-Linux_x86_64_rv2.0b6pre_Gecko-20100904_Firefox-4.0b6pre-TEST-8375-1_59.html: Added.
3121         * iExploder/iexploder-1.7.2/testcases/testcase-Opera-9.80_Linux_x86_64_en_Presto-2.6.30_Version-10.61-16704-3_108,3.html: Added.
3122         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_Chrome-7.0.529.0-TEST-611-3_36,9.html: Added.
3123         * iExploder/iexploder-1.7.2/testcases/testcase-U_Intel_Mac_OS_X_10_6_4_en-US_AppleWebKit-534.8_hrome-7.0.529.0-TEST-55313622206-3_6,0.html: Added.
3124         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-120813-8_72,56,24,8,0.html: Added.
3125         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.6_Chrome-7.0.503.1-TEST-121240-3_81,3.html: Added.
3126         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-4800-5_80,65,15.html: Added.
3127         * iExploder/iexploder-1.7.2/testcases/testcase-U_Linux_x86_64_en-US_AppleWebKit-534.7_Chrome-7.0.513.0-TEST-23583190347-3_15,12.html: Added.
3128         * iExploder/iexploder-1.7.2/tools: Added.
3129         * iExploder/iexploder-1.7.2/tools/lasthit.rb: Added.
3130         * iExploder/iexploder-1.7.2/tools/osx_last_crash.rb: Added.
3131         * iExploder/iexploder-1.7.2/tools/release_src.sh: Added.
3132         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added.
3133         * iExploder/tools: Removed.
3134
3135 2010-12-13  Sam Weinig  <sam@webkit.org>
3136
3137         Reviewed by Anders Carlsson.
3138
3139         Remove associated page concept from WKView constructor
3140         https://bugs.webkit.org/show_bug.cgi?id=50983
3141
3142         Step 1: Remove associate page constructors from WKView and make
3143         all views use the shared namespace for the context.
3144
3145         * TestWebKitAPI/PlatformWebView.h:
3146         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3147         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3148         * WebKitTestRunner/PlatformWebView.h:
3149         * WebKitTestRunner/TestController.cpp:
3150         (WTR::createOtherPage):
3151         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3152         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3153         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3154
3155 2010-12-13  Sam Weinig  <sam@webkit.org>
3156
3157         Reviewed by Anders Carlsson.
3158
3159         Change the WebKit2 public API so there is no explicit WKPageNamespace object
3160         https://bugs.webkit.org/show_bug.cgi?id=50898
3161
3162         * MiniBrowser/mac/AppDelegate.h:
3163         * MiniBrowser/mac/AppDelegate.m:
3164         * MiniBrowser/mac/BrowserWindowController.h:
3165         * MiniBrowser/mac/BrowserWindowController.m:
3166         * MiniBrowser/win/BrowserView.cpp:
3167         Convert MiniBrowser to not use PageNamespaces.
3168
3169         * TestWebKitAPI/PlatformWebView.h:
3170         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
3171         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
3172         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
3173         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
3174         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
3175         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
3176         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
3177         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
3178         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3179         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
3180         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
3181         * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
3182         * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
3183         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3184         * TestWebKitAPI/win/PlatformWebViewWin.cpp:
3185         Convert TestWebKitAPI to not use PageNamespaces.
3186
3187         * WebKitTestRunner/PlatformWebView.h:
3188         * WebKitTestRunner/TestController.cpp:
3189         * WebKitTestRunner/TestController.h:
3190         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3191         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3192         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3193         Convert WebKitTestRunner to not use PageNamespaces.
3194
3195 2010-12-13  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3196
3197         Reviewed by Eric Seidel.
3198
3199         webkit-patch rollout should be able to do multi-revision rollouts
3200         https://bugs.webkit.org/show_bug.cgi?id=33336
3201
3202         Make it possible to pass more than one revision to webkit-patch.
3203
3204         * Scripts/webkitpy/common/checkout/api.py:
3205         * Scripts/webkitpy/common/checkout/changelog.py:
3206         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
3207         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3208         * Scripts/webkitpy/tool/commands/download.py:
3209         * Scripts/webkitpy/tool/commands/download_unittest.py:
3210         * Scripts/webkitpy/tool/mocktool.py:
3211         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
3212         * Scripts/webkitpy/tool/steps/revertrevision.py:
3213
3214 2010-12-13  Eric Seidel  <eric@webkit.org>
3215
3216         Unreviewed.
3217
3218         Teach webkit-patch how to search bugzilla
3219         https://bugs.webkit.org/show_bug.cgi?id=50500
3220
3221         webkit-patch bug-search fails when there is only one result.
3222         Turns out we needed a bit more logic in our result count parsing code.
3223
3224         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3225         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3226
3227 2010-12-13  Antti Koivisto  <antti@apple.com>
3228
3229         Reviewed by Alexey Proskuryakov.
3230
3231         Add setSerializeHTTPLoads function to allow testing resource load order on OS X.
3232         https://bugs.webkit.org/show_bug.cgi?id=50758
3233
3234         * DumpRenderTree/LayoutTestController.cpp:
3235         (setSerializeHTTPLoadsCallback):
3236         (LayoutTestController::staticFunctions):
3237         * DumpRenderTree/LayoutTestController.h:
3238         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3239         (LayoutTestController::setSerializeHTTPLoads):
3240         * DumpRenderTree/mac/DumpRenderTree.mm:
3241         (resetDefaultsToConsistentValues):
3242         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3243         (LayoutTestController::setSerializeHTTPLoads):
3244         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3245         (LayoutTestController::setSerializeHTTPLoads):
3246
3247 2010-12-13  Dimitri Glazkov  <dglazkov@chromium.org>
3248
3249         Reviewed by Ojan Vafai.
3250
3251         Remove "use-drt" option from test step command line, since the option was removed in r73748.
3252         https://bugs.webkit.org/show_bug.cgi?id=50936
3253
3254         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed the option.
3255
3256 2010-12-13  Patrick Gansterer  <paroga@webkit.org>
3257
3258         Reviewed by Csaba Osztrogonác.
3259
3260         Add revlink to BuildBot status
3261         https://bugs.webkit.org/show_bug.cgi?id=50914
3262
3263         This adds a hyperlink to trac changeset on the revision numbers. 
3264
3265         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3266
3267 2010-12-13  Andras Becsi  <abecsi@webkit.org>
3268
3269         Reviewed by Csaba Osztrogonác.
3270
3271         [Qt][WK2] Fix build if WebKitTools are not available
3272         https://bugs.webkit.org/show_bug.cgi?id=50242
3273
3274         * MiniBrowser/qt/MiniBrowser.pro: Correct the comment.
3275         * Scripts/webkitdirs.pm: Added WebKitTools/MiniBrowser to $subdirs.
3276         * MiniBrowser/DerivedSources.pro: Added.
3277
3278 2010-12-13  Eric Seidel  <eric@webkit.org>
3279
3280         Reviewed by Adam Barth.
3281
3282         EWS Queues should remove orpahned pyc files before starting
3283         https://bugs.webkit.org/show_bug.cgi?id=50904
3284
3285         A previous check added a platform.py which caused
3286         EWS bots on some platforms to hit an import exception.
3287         The platform.py file was removed in a subsequent commit, but
3288         the EWS bots in question stayed stuck.  This change will
3289         fix those bots once restarted (and prevent this in the future).
3290
3291         I also went ahead and unified start-queue and start-commit-queue
3292         since they were nearly identical.  I also added bot_id support
3293         to both force all EWSes to have bot ids as well as get rid of the one
3294         remaining reason why I had my own copies of these scripts.
3295         Hopefully this will be enough to get all the other bot admins
3296         (ahem, Adam, ahem) to move to using these checked in copies as well.
3297
3298         * EWSTools/start-commit-queue.sh: Removed.
3299         * EWSTools/start-queue.sh:
3300
3301 2010-10-28  MORITA Hajime  <morrita@google.com>
3302
3303         Reviewed by Ojan Vafai.
3304
3305         spellcheck does not check pasted text
3306         https://bugs.webkit.org/show_bug.cgi?id=40092
3307
3308         Added LayoutTestController::setAsynchronousSpellCheckingEnabled()
3309         to control the setting.
3310
3311         * DumpRenderTree/LayoutTestController.cpp:
3312         (setAsynchronousSpellCheckingEnabledCallback):
3313         (LayoutTestController::staticFunctions):
3314         * DumpRenderTree/LayoutTestController.h:
3315         * DumpRenderTree/chromium/LayoutTestController.h:
3316         * DumpRenderTree/chromium/LayoutTestController.cpp:
3317         (LayoutTestController::LayoutTestController):
3318         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3319         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3320         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3321         * DumpRenderTree/mac/DumpRenderTree.mm:
3322         (resetDefaultsToConsistentValues):
3323         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3324         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3325         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3326         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3327         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3328         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3329         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3330         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3331         (LayoutTestController::setAsynchronousSpellCheckingEnabled):
3332
3333 2010-12-12  Sam Weinig  <sam@webkit.org>
3334
3335         Reviewed by Anders Carlsson.
3336
3337         Fix failing API test. It turns out that a pop-state event
3338         is sent before every fragment navigation, so we have to test
3339         for it in addition in PageLoadDidChangeLocationWithinPageForFrame.
3340
3341         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
3342         (TestWebKitAPI::didSameDocumentNavigationForFrame):
3343
3344 2010-12-12  Alejandro G. Castro  <alex@igalia.com>
3345
3346         Reviewed by Eric Seidel.
3347
3348         [GTK] Add new-run-webkit-tests support to gtk
3349         https://bugs.webkit.org/show_bug.cgi?id=50681
3350
3351         Adding the basic support to run the new-run-webkit-tests.
3352
3353         * Scripts/webkitpy/layout_tests/port/gtk.py:
3354
3355 2010-10-11  Diego Gonzalez  <diegohcg@webkit.org>
3356
3357         Reviewed by Kenneth Rohde Christiansen.
3358
3359         [Qt] Mock DeviceOrientation client for DRT
3360         https://bugs.webkit.org/show_bug.cgi?id=47490
3361
3362         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3363         (WebCore::DumpRenderTree::DumpRenderTree):
3364         (WebCore::DumpRenderTree::~DumpRenderTree):
3365         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3366         (LayoutTestController::setMockDeviceOrientation):
3367
3368 2010-12-11  Philippe Normand  <pnormand@igalia.com>
3369
3370         Reviewed by Gustavo Noronha Silva.
3371
3372         [GTK] launcher: disable the Mozilla-style fullscreen API
3373         https://bugs.webkit.org/show_bug.cgi?id=50874
3374
3375         Disabling the fullscreen API until its implementation for GTK is
3376         mature enough. The webview setting for it is already FALSE by
3377         default.
3378
3379         * GtkLauncher/main.c:
3380         (createWindow):
3381
3382 2010-12-10  Eric Seidel  <eric@webkit.org>
3383
3384         Reviewed by Adam Barth.
3385
3386         commit-queue flaky test messages show cryptic version information for mac os x
3387         https://bugs.webkit.org/show_bug.cgi?id=50864
3388
3389         Turns out platform.platform() returns kernel version information
3390         which isn't helpful, and just plain confusing on Mac
3391         (OS X 10.6.5 uses Darwin Kernel 10.5.0).
3392
3393         So I've updated PlatformInfo.display_name() to special case
3394         mac.  I also found a bad use of sys.platform in the process
3395         and fixed that.  (sys.platform always returns 'darwin' on mac).
3396
3397         * Scripts/webkitpy/common/system/platforminfo.py:
3398         * Scripts/webkitpy/common/system/user.py:
3399         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3400         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3401         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3402
3403 2010-12-10  Eric Seidel  <eric@webkit.org>
3404
3405         Unreviewed.
3406
3407         Exception seen while reporting flaky test with commit-queue.
3408         Just a missing include.
3409
3410         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3411         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3412
3413 2010-12-10  Kinuko Yasuda  <kinuko@chromium.org>
3414
3415         Reviewed by Eric Seidel.
3416
3417         [Chromium] Remove old JSONResultsGenerator script that existed for backward-compatibility
3418         https://bugs.webkit.org/show_bug.cgi?id=50796
3419
3420         Also updating the test code to use JSONResultsGeneratorBase and
3421         to improve test coverage for incremental cases.
3422
3423         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
3424         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
3425
3426 2010-12-10  Joseph Pecoraro  <joepeck@webkit.org>
3427
3428         Reviewed by Darin Adler.
3429
3430         prepare-ChangeLog --help doesn't mention --bug shorthand -b
3431         https://bugs.webkit.org/show_bug.cgi?id=50835
3432
3433         * Scripts/prepare-ChangeLog: be more explicit about -b and match file style.
3434
3435 2010-12-10  Eric Seidel  <eric@webkit.org>
3436
3437         Reviewed by Adam Barth.
3438
3439         Bugs created by the commit-queue should all block on a master bug
3440         https://bugs.webkit.org/show_bug.cgi?id=50857
3441
3442         This makes all bugs created by the commit-queue block on:
3443         https://bugs.webkit.org/show_bug.cgi?id=50856
3444
3445         In the process of testing this, I found that the existing
3446         create_bug code was wrong.  I also found that existing
3447         unit tests for create-rollout used invalid values
3448         for options.blocks.  I fixed both issues and tested.
3449
3450         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3451         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3452         * Scripts/webkitpy/tool/commands/commandtest.py:
3453         * Scripts/webkitpy/tool/commands/download_unittest.py:
3454         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3455         * Scripts/webkitpy/tool/mocktool.py:
3456         * Scripts/webkitpy/tool/steps/options.py:
3457
3458 2010-12-10  Eric Seidel  <eric@webkit.org>
3459
3460         Reviewed by Adam Barth.
3461
3462         Teach webkitpy how to follow duplicate chains when posting comments on flake bugs
3463         https://bugs.webkit.org/show_bug.cgi?id=50853
3464
3465         I also discovered when doing this that the code was posting
3466         the comment on the wrong bug, but that's fixed here too.
3467
3468         * Scripts/webkitpy/common/net/bugzilla/bug.py:
3469         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3470         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3471         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3472         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3473         * Scripts/webkitpy/tool/mocktool.py:
3474
3475 2010-12-10  Anders Carlsson  <andersca@apple.com>
3476
3477         Reviewed by John Sullivan.
3478
3479         Make WKContextGetStatistics gather global statistics
3480         https://bugs.webkit.org/show_bug.cgi?id=50850
3481
3482         Remove the code that gets the statistics and fills in the per context
3483         statistics information for now.
3484
3485         * MiniBrowser/mac/BrowserStatisticsWindowController.m:
3486         (-[BrowserStatisticsWindowController refreshStatistics:]):
3487
3488 2010-12-10  Eric Seidel  <eric@webkit.org>
3489
3490         Unreviewed.
3491
3492         commit-queue should report port/platform information when commenting on flaky test bugs
3493         https://bugs.webkit.org/show_bug.cgi?id=50839
3494
3495         Renamed platform.py to platforminfo.py.  This broke import platform in executive.py
3496         which was only used by new run webkit tests (and clearly not unit tested).
3497
3498         * Scripts/webkitpy/common/system/platforminfo.py: Renamed from WebKitTools/Scripts/webkitpy/common/system/platform.py.
3499         * Scripts/webkitpy/tool/main.py:
3500         * Scripts/webkitpy/tool/mocktool.py:
3501
3502 2010-12-10  Eric Seidel  <eric@webkit.org>
3503
3504         Reviewed by Tony Chang.
3505
3506         commit-queue should report port/platform information when commenting on flaky test bugs
3507         https://bugs.webkit.org/show_bug.cgi?id=50839
3508
3509         This was a suggestion from Tony Chang this morning.
3510         I added a platform.py class so I could easily mock the platform call,
3511         but that may not be the final solution for this mocking.
3512         We'll try it and see.
3513
3514         * Scripts/webkitpy/common/system/platform.py: Added.
3515         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3516         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3517         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3518         * Scripts/webkitpy/tool/main.py:
3519         * Scripts/webkitpy/tool/mocktool.py:
3520
3521 2010-12-10  Krithigassree Sambamurthy  <krithigassree.sambamurthy@nokia.com>
3522
3523         Reviewed by Joseph Pecoraro.
3524
3525         Bug 43455 - [Qt]: Implement Application Cache Quotas
3526         https://bugs.webkit.org/show_bug.cgi?id=43455
3527
3528         Introduce functions to allow new appcache layout test origin-quota.html
3529         to work correctly under Qt.
3530
3531         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3532         (WebCore::DumpRenderTree::DumpRenderTree):
3533         (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
3534         * DumpRenderTree/qt/DumpRenderTreeQt.h:
3535
3536         Introduce functions to allow new appcache layout test origin-quota.html
3537         to be successful under qt. Changes required because LayoutTestControllerQt
3538         does not inherit from LayoutController.
3539
3540         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3541         (LayoutTestController::reset):
3542         (LayoutTestController::clearAllApplicationCaches):
3543         (LayoutTestController::setApplicationCacheOriginQuota):
3544         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3545         (LayoutTestController::shouldDumpApplicationCacheDelegateCallbacks):
3546         (LayoutTestController::dumpApplicationCacheDelegateCallbacks):
3547
3548 2010-12-10  Eric Seidel  <eric@webkit.org>
3549
3550         Reviewed by Adam Barth.
3551
3552         Move buildbot.py into its own module so we can split it out into one-file-per-class
3553         https://bugs.webkit.org/show_bug.cgi?id=50806
3554
3555         We're adding more buildbot logic these days, so it makes sense
3556         to give buildbot its own module.
3557
3558         * Scripts/webkitpy/common/net/buildbot/__init__.py: Added.
3559         * Scripts/webkitpy/common/net/buildbot/buildbot.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot.py.
3560         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Renamed from WebKitTools/Scripts/webkitpy/common/net/buildbot_unittest.py.
3561         * Scripts/webkitpy/common/net/failuremap.py:
3562         * Scripts/webkitpy/common/net/regressionwindow.py:
3563         * Scripts/webkitpy/tool/commands/rebaseline.py:
3564
3565 2010-12-10  Tony Chang  <tony@chromium.org>
3566
3567         Reviewed by Eric Seidel.
3568
3569         Use FileSystem::remove when cleaning up http lock files
3570         https://bugs.webkit.org/show_bug.cgi?id=50830
3571
3572         * Scripts/webkitpy/layout_tests/port/http_lock.py:
3573
3574 2010-12-10  Joone Hur  <joone@kldp.org>
3575
3576         Reviewed by Martin Robinson.
3577
3578         [GTK] DRT needs layoutTestController.setCacheModel
3579         https://bugs.webkit.org/show_bug.cgi?id=50705
3580         
3581         webkit_set_cache_mode() is called to set the cache model.
3582         
3583         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3584         (LayoutTestController::setCacheModel): Set the cache model. 
3585
3586 2010-12-10  Tony Chang  <tony@chromium.org>
3587
3588         Reviewed by Ojan Vafai.
3589
3590         [chromium] remove --use-drt and add --use-test-shell
3591         https://bugs.webkit.org/show_bug.cgi?id=50701
3592
3593         * Scripts/webkitpy/common/config/ports.py:
3594         * Scripts/webkitpy/common/config/ports_unittest.py:
3595         * Scripts/webkitpy/layout_tests/port/chromium.py:
3596         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3597         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3598         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
3599         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
3600         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3601         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
3602         * Scripts/webkitpy/layout_tests/port/webkit.py:
3603         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3604         * Scripts/webkitpy/style/checkers/test_expectations.py:
3605         * Scripts/webkitpy/tool/commands/queries.py:
3606
3607 2010-12-10  John Knottenbelt  <jknotten@chromium.org>
3608
3609         Reviewed by Steve Block.
3610
3611         [Chromium] Implement mocks for client-based geolocation
3612         https://bugs.webkit.org/show_bug.cgi?id=46895
3613
3614         * DumpRenderTree/chromium/LayoutTestController.cpp:
3615         (LayoutTestController::setGeolocationPermission):
3616         (LayoutTestController::setMockGeolocationPosition):
3617         (LayoutTestController::setMockGeolocationError):
3618         * DumpRenderTree/chromium/LayoutTestController.h:
3619         * DumpRenderTree/chromium/WebViewHost.cpp:
3620         (WebViewHost::geolocationClient):
3621         (WebViewHost::geolocationClientMock):
3622         (WebViewHost::reset):
3623         * DumpRenderTree/chromium/WebViewHost.h:
3624
3625 2010-12-10  Alejandro G. Castro  <alex@igalia.com>
3626
3627         Reviewed by Martin Robinson.
3628
3629         [GTK] Add hasSpellingMarker support to the DRT
3630         https://bugs.webkit.org/show_bug.cgi?id=50739
3631
3632         Implemented the hasSpellingMarker to support spelling tests.
3633
3634         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3635         (LayoutTestController::hasSpellingMarker):
3636
3637 2010-12-10  Eric Seidel  <eric@webkit.org>
3638
3639         Reviewed by Ojan Vafai.
3640
3641         webkit-patch: not possible to use build-and-test with local commits
3642         https://bugs.webkit.org/show_bug.cgi?id=33378
3643
3644         Make --no-clean not even check if we have local commits.
3645         It's unclear to me why the code was originally written this way.
3646         I was unable to dig up a reason from svn history.
3647
3648         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3649         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3650
3651 2010-12-10  Mario Sanchez Prada  <msanchez@igalia.com>
3652
3653         Reviewed by Martin Robinson.
3654
3655         [GTK] AX: implement isEnabled in DRT
3656         https://bugs.webkit.org/show_bug.cgi?id=50814
3657
3658         Implement AccessibilityUIElement::isEnabled() for GTK.
3659
3660         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
3661         (checkElementState): New function to refactor common code.
3662         (AccessibilityUIElement::isEnabled): Implement this by checking
3663         the current state of the AtkObject.
3664         (AccessibilityUIElement::isSelected): Use the new
3665         checkElementState function.
3666
3667 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3668
3669         Reviewed by Kenneth Rohde Christiansen.
3670
3671         [Qt][WK2] Add the QWKContext API class to wrap the WebContext.
3672         https://bugs.webkit.org/show_bug.cgi?id=50750
3673
3674         * MiniBrowser/qt/BrowserView.cpp:
3675         (BrowserView::BrowserView):
3676         * MiniBrowser/qt/BrowserView.h:
3677         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
3678         (WTR::WebView::WebView):
3679
3680 2010-12-10  Joone Hur  <joone@kldp.org>
3681
3682         Reviewed by Xan Lopez.
3683
3684         [GTK] Unskipping some test cases in userscripts dependent on addUserStyleSheet
3685         https://bugs.webkit.org/show_bug.cgi?id=50808
3686
3687         Unskipping the following test cases:
3688         userscripts/mixed-case-stylesheet.html
3689         userscripts/simple-stylesheet.html
3690         userscripts/user-style-all-frames.html
3691
3692         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3693         (LayoutTestController::addUserStyleSheet):
3694
3695 2010-12-10  Joone Hur  <joone@kldp.org>
3696
3697         Reviewed by Eric Seidel.
3698
3699         [GTK] Add DRT support for pageProperty, isPageBoxVisible, pageSizeAndMarginsInPixels, and addUserStyleSheet
3700         https://bugs.webkit.org/show_bug.cgi?id=50783
3701
3702         This patch allows to unskip the following test cases:
3703         printing/page-rule-selection.html
3704         printing/page-format-data.html
3705
3706         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3707         (LayoutTestController::pageProperty): Added.
3708         (LayoutTestController::isPageBoxVisible): Ditto.
3709         (LayoutTestController::pageSizeAndMarginsInPixels): Ditto.
3710         (LayoutTestController::addUserStyleSheet): Ditto.
3711
3712 2010-12-10  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
3713
3714         Reviewed by Kenneth Rohde Christiansen.
3715
3716         [Qt] Make QtTestBrowser spawn QNAM in a secondary thread.
3717
3718         A menu allows to switch QNAM back to the same thread.
3719
3720         * QtTestBrowser/launcherwindow.cpp:
3721         (LauncherWindow::initializeView):
3722         (LauncherWindow::createChrome):
3723         (LauncherWindow::toggleThreadedQnam):
3724         * QtTestBrowser/launcherwindow.h:
3725         (WindowOptions::WindowOptions):
3726         * QtTestBrowser/webpage.cpp:
3727         (WebPage::WebPage):
3728         (WebPage::setQnamThreaded):
3729         * QtTestBrowser/webpage.h:
3730         (QnamThread::QnamThread):
3731         (QnamThread::~QnamThread):
3732         (QnamThread::networkAccessManager):
3733         (QnamThread::run):
3734
3735 2010-12-10  Martin Robinson  <mrobinson@igalia.com>
3736
3737         Reviewed by Xan Lopez.
3738
3739         [Gtk] style="font-family: courier" makes text disappear
3740         https://bugs.webkit.org/show_bug.cgi?id=47452
3741
3742         Add a test that verifies that fonts without valid charmaps are
3743         never selected.
3744
3745         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3746         (initializeFonts): Initialize DRT with our font (derived from Ahem)
3747         that has no valid charmap.
3748         * DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon: Added.
3749         * DumpRenderTree/gtk/fonts/fonts.conf: Updated settings to override users'
3750         settings which may disable selection of bitmap fonts.
3751
3752 2010-12-10  Eric Seidel  <eric@webkit.org>
3753
3754         Unreviewed.
3755
3756         The commit-queue should file bugs about flaky tests it encounters
3757         https://bugs.webkit.org/show_bug.cgi?id=50803
3758
3759         create_bug_for_flaky_test was insufficiently tested, thus buggy.
3760         Now it's tested.
3761
3762         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3763         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3764
3765 2010-12-10  Eric Seidel  <eric@webkit.org>
3766
3767         Unreviewed.  Somehow this last-minute edit didn't quite get committed.
3768
3769         The commit-queue should file bugs about flaky tests it encounters
3770         https://bugs.webkit.org/show_bug.cgi?id=50803
3771
3772         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3773
3774 2010-12-09  Eric Seidel  <eric@webkit.org>
3775
3776         Reviewed by Adam Barth.
3777
3778         The commit-queue should file bugs about flaky tests it encounters
3779         https://bugs.webkit.org/show_bug.cgi?id=50803
3780
3781         This change got a bit big.  I also added a new config.urls file
3782         because I needed to share the view_source_url code with committervalidator.py.
3783
3784         This adds a new class FlakyTestReporter which holds all the logic about
3785         reporting flaky tests to bugzilla.
3786
3787         Right now this code knows how to look up bugs for flaky tests.
3788         If it can't find a bug filed from the commit-queue, it will open a new
3789         one, ccing the relevant people and adding information about the failure.
3790
3791         It is not yet smart enough to chase down duplicate chains, or to include
3792         the actual failure diff.  But those can be added in later iterations.
3793
3794         * Scripts/webkitpy/common/checkout/api.py:
3795         * Scripts/webkitpy/common/checkout/changelog.py:
3796         * Scripts/webkitpy/common/checkout/commitinfo.py:
3797         * Scripts/webkitpy/common/config/committervalidator.py:
3798         * Scripts/webkitpy/common/config/urls.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3799         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3800         * Scripts/webkitpy/tool/bot/flakytestreporter.py: Added.
3801         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py: Copied from WebKitTools/Scripts/webkitpy/tool/comments.py.
3802         * Scripts/webkitpy/tool/bot/irc_command.py:
3803         * Scripts/webkitpy/tool/bot/sheriff.py:
3804         * Scripts/webkitpy/tool/commands/download.py:
3805         * Scripts/webkitpy/tool/commands/queues.py:
3806         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3807         * Scripts/webkitpy/tool/comments.py:
3808         * Scripts/webkitpy/tool/mocktool.py:
3809         * Scripts/webkitpy/tool/steps/commit.py:
3810
3811 2010-12-09  Eric Seidel  <eric@webkit.org>
3812
3813         Reviewed by Adam Barth.
3814
3815         Teach webkit-patch how to search bugzilla
3816         https://bugs.webkit.org/show_bug.cgi?id=50500
3817
3818         This is a step towards teaching webkitpy how to file
3819         new bugs for flaky tests and update them when new flakes occur.
3820
3821         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3822         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3823         * Scripts/webkitpy/tool/commands/__init__.py:
3824         * Scripts/webkitpy/tool/commands/bugsearch.py: Added.
3825
3826 2010-12-09  Adam Barth  <abarth@webkit.org>
3827
3828         Reviewed by Ojan Vafai.
3829
3830         commit-queue errors out due to local commits
3831         https://bugs.webkit.org/show_bug.cgi?id=50766
3832
3833         We seem to be tripping over having local commits in the working copy a
3834         lot recently.  I don't quite fully understand what the issue is, but
3835         this patch attempts to solve the problem by adding an explicit clean
3836         step before processing a patch.  Previously, we did the cleaning as
3837         part of the apply-attachment step, so this might not actually fix the
3838         problem.
3839
3840         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3841         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3842         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3843
3844 2010-12-09  Dirk Pranke  <dpranke@chromium.org>
3845
3846         Reviewed by Ojan Vafai.
3847
3848         Make new-run-webkit-tests --lint-test-files log slightly better
3849         messages and return -1 if lint fails. Remove the
3850         'suppress_errors' keyword param to the TestExpectationsFile
3851         class, and clean up logging and exception raising for error
3852         handling. Also add more unit tests and clean up the unit test code a bit.
3853
3854         https://bugs.webkit.org/show_bug.cgi?id=50205
3855
3856         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3857         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
3858         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py
3859         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py
3860         * Scripts/webkitpy/layout_tests/port/chromium.py:
3861         * Scripts/webkitpy/style/checkers/test_expectations.py:
3862         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
3863
3864 2010-12-09  Tony Chang  <tony@chromium.org>
3865
3866         Unreviewed, fix for windows code.  We were catching the wrong
3867         exception in Windows.
3868
3869         * Scripts/webkitpy/common/system/filesystem.py:
3870
3871 2010-12-09  Antonio Gomes  <agomes@rim.com>
3872
3873         Reviewed by Martin Robinson.
3874
3875         [Gtk] Populate DumpRenderTreeSupportGtk (part IV)
3876         https://bugs.webkit.org/show_bug.cgi?id=48429
3877
3878         Adjust call sites of webkit_thread_count to use the DumpRenderTreeSupportGtk version now.
3879
3880         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3881         (LayoutTestController::workerThreadCount):
3882
3883 2010-12-06  Philippe Normand  <pnormand@igalia.com>
3884
3885         Reviewed by Martin Robinson.
3886
3887         [GTK] Support the Mozilla-style Fullscreen Javascript API
3888         https://bugs.webkit.org/show_bug.cgi?id=50572
3889
3890         Enable the Javascript Fullscreen support in the GtkLauncher. Also
3891         make DRT update the Chrome when the WebView settings have been
3892         reset to consistent values.
3893
3894         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3895         (resetDefaultsToConsistentValues):
3896         * GtkLauncher/main.c:
3897         (create_window):
3898         * Scripts/build-webkit:
3899
3900 2010-12-09  Koan-Sin Tan  <koansin.tan@gmail.com>
3901
3902         Reviewed by Tor Arne Vestbø
3903
3904         [Qt] run-launcher doesn't start the browser on Mac OS X 10.6
3905         https://bugs.webkit.org/show_bug.cgi?id=50742
3906
3907         check not only QtWebKit.framework/QtWebKit but also libQtWebKit.dylib
3908
3909         * Scripts/webkitdirs.pm:
3910
3911 2010-12-09  Joone Hur  <joone@kldp.org>
3912
3913          Reviewed by Martin Robinson.
3914
3915          [GTK] Support for viewport meta tag
3916          https://bugs.webkit.org/show_bug.cgi?id=45443
3917
3918          Add support for testing the viewport properties for WebKitGtk.
3919
3920          * DumpRenderTree/LayoutTestController.cpp:
3921          (dumpConfigurationForViewportCallback): Added this JS callback to set the size of the visible viewport.
3922          (LayoutTestController::staticFunctions):
3923          * DumpRenderTree/LayoutTestController.h:
3924          * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3925          (LayoutTestController::dumpConfigurationForViewport): Added this function to test the viewport properties.
3926          * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3927          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3928          * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3929          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3930          * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3931          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3932          * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3933          (LayoutTestController::dumpConfigurationForViewport): Ditto.
3934
3935 2010-12-08  William Siegrist <wsiegrist@apple.com>
3936
3937         Reviewed by Eric Seidel.
3938
3939         Migrate buildbot.py from xmlrpc to json.
3940         https://bugs.webkit.org/show_bug.cgi?id=50647
3941
3942         * Scripts/webkitpy/common/net/buildbot.py:
3943
3944 2010-12-08  Tony Chang  <tony@chromium.org>
3945
3946         Reviewed by Eric Seidel.
3947
3948         make starting the websocket server more reliable on windows
3949         https://bugs.webkit.org/show_bug.cgi?id=50712
3950
3951         * Scripts/webkitpy/common/system/filesystem.py:
3952         (remove): Substitute method for os.remove to retry on error on Windows
3953         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3954         * Scripts/webkitpy/layout_tests/port/http_server_base.py: Use FileSystem.remove
3955
3956 2010-12-08  Jessie Berlin  <jberlin@apple.com>
3957
3958         Reviewed by Adam Roben.
3959
3960         WebKit2: Implement WebChromeClient::exceededDatabaseQuota
3961         https://bugs.webkit.org/show_bug.cgi?id=50656
3962
3963         * MiniBrowser/mac/BrowserWindowController.m:
3964         (-[BrowserWindowController awakeFromNib]):
3965         Indicate that exceededDatabaseQuota is not implemented.
3966         * MiniBrowser/win/BrowserView.cpp:
3967         (BrowserView::create):
3968         Ditto.
3969         * WebKitTestRunner/TestController.cpp:
3970         (WTR::createOtherPage):
3971         Ditto.
3972         (WTR::TestController::initialize):
3973         Ditto.
3974
3975 2010-12-08  Antonio Gomes  <agomes@rim.com>
3976
3977         Reviewed by Martin Robinson.
3978
3979         [Gtk] Populate DumpRenderTreeSupportGtk (part III)
3980         https://bugs.webkit.org/show_bug.cgi?id=48429
3981
3982         Moved the following methods from webkitprivate.h to DumpRenderTreeSupportGtk.cpp|h:
3983         * webkit_gc_collect_javascript_objects;
3984         * webkit_gc_collect_javascript_objects_on_alternate_thread;
3985         * webkit_gc_count_javascript_objects;
3986         * webkit_web_frame_layout.
3987
3988         These were all only used by GTK+ DRT.
3989
3990         * DumpRenderTree/gtk/EventSender.cpp:
3991         (dispatchEvent):
3992         * DumpRenderTree/gtk/GCControllerGtk.cpp:
3993         (GCController::collect):
3994         (GCController::collectOnAlternateThread):
3995         (GCController::getJSObjectCount):
3996
3997 2010-12-07  Tony Chang  <tony@chromium.org>
3998
3999         Reviewed by Ojan Vafai.
4000
4001         [chromium] force NRWT to use DRT
4002         https://bugs.webkit.org/show_bug.cgi?id=50359
4003
4004         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4005
4006 2010-12-06  Sam Weinig  <sam@webkit.org>
4007
4008         Reviewed by Anders Carlsson.
4009
4010         Generalize didChangeLocationWithinPageForFrame for all same document navigations
4011         https://bugs.webkit.org/show_bug.cgi?id=50584
4012
4013         * MiniBrowser/mac/BrowserWindowController.m:
4014         (didSameDocumentNavigationForFrame):
4015         (-[BrowserWindowController awakeFromNib]):
4016         (-[BrowserWindowController didSameDocumentNavigationForFrame:]):
4017         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
4018         (TestWebKitAPI::didSameDocumentNavigationForFrame):
4019         (TestWebKitAPI::TEST):
4020         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4021         (WTR::InjectedBundlePage::InjectedBundlePage):
4022         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame):
4023         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4024         * WebKitTestRunner/TestController.cpp:
4025         (WTR::TestController::initialize):
4026
4027 2010-12-06  Kinuko Yasuda  <kinuko@chromium.org>
4028
4029         Reviewed by Ojan Vafai.
4030
4031         Make TestResultsServer return 404 for non-existing results files.
4032         https://bugs.webkit.org/show_bug.cgi?id=50581
4033
4034         * TestResultServer/handlers/testfilehandler.py:
4035
4036 2010-12-06  Tony Chang  <tony@chromium.org>
4037
4038         Reviewed by Ojan Vafai.
4039
4040         [chromium] fix an assert hit in DRT
4041         https://bugs.webkit.org/show_bug.cgi?id=50575
4042
4043         This class uses WTF's RefPtr, but expects chrome's base::RefPtr
4044         semantics.
4045
4046         Otherwise, we hit ASSERTION FAILED: !m_adoptionIsRequired
4047         (third_party/WebKit/JavaScriptCore/wtf/RefCounted.h:37 void
4048         WTF::RefCountedBase::ref()).
4049
4050         * DumpRenderTree/chromium/TestWebWorker.h:
4051         (TestWebWorker::TestWebWorker):
4052
4053 2010-12-02  Ojan Vafai  <ojan@chromium.org>
4054
4055         Reviewed by Eric Seidel.
4056
4057         make webkit-patch command work when the git branch is not synced to the remote svn branch
4058         https://bugs.webkit.org/show_bug.cgi?id=50424
4059
4060         * Scripts/webkitpy/common/checkout/scm.py:
4061         * Scripts/webkitpy/common/checkout/scm_unittest.py:
4062
4063 2010-12-06  Patrick Gansterer  <paroga@webkit.org>
4064
4065         Reviewed by Andreas Kling.
4066
4067         [WINCE] Add build system
4068         https://bugs.webkit.org/show_bug.cgi?id=50522
4069
4070         * CMakeListsWinCE.txt: Added.
4071
4072 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
4073
4074         Reviewed by Tony Chang.
4075
4076         Allow the Chromium port to have Leopard-specific baselines
4077         https://bugs.webkit.org/show_bug.cgi?id=50506
4078
4079         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4080
4081 2010-12-03  Tony Chang  <tony@chromium.org>
4082
4083         Reviewed by Kent Tamura.
4084
4085         [chromium] fix 2 bugs with inspector tests in DRT
4086         https://bugs.webkit.org/show_bug.cgi?id=50492
4087
4088         Tasks can outlive the tasklist (even when canceled) so this was
4089         causing a crash when ~WebTask() ran.  Avoid this by unregistering
4090         when a task is canceled.
4091
4092         Also fix an assert when closing devtool windows by copying some
4093         logic from test_shell.
4094
4095         * DumpRenderTree/chromium/Task.cpp:
4096         (WebTask::~WebTask):
4097         (TaskList::revokeAll):
4098         * DumpRenderTree/chromium/Task.h: Canceling a task now removes it from
4099             the tasklist (since the task can outlive the tasklist).
4100         * DumpRenderTree/chromium/TestShell.h:
4101         (TestShell::devToolsWebView):
4102         * DumpRenderTree/chromium/WebViewHost.cpp:
4103         (WebViewHost::~WebViewHost): Don't load about:blank when closing
4104             a window if the window has devtools loaded.  This avoids an
4105             ASSERT and matches test_shell.
4106
4107 2010-12-06  Alejandro G. Castro  <alex@igalia.com>
4108
4109         Reviewed by Martin Robinson.
4110
4111         [GTK] Fix GtkLauncher.c style, use webkit style
4112         https://bugs.webkit.org/show_bug.cgi?id=50542
4113
4114         * GtkLauncher/main.c:
4115         (activateUriEntryCb):
4116         (updateTitle):
4117         (linkHoverCb):
4118         (notifyTitleCb):
4119         (notifyLoadStatusCb):
4120         (notifyProgressCb):
4121         (destroyCb):
4122         (goBackCb):
4123         (goForwardCb):
4124         (create_webViewCb):
4125         (webViewReadyCb):
4126         (closeWebViewCb):
4127         (createBrowser):
4128         (createStatusbar):
4129         (createToolbar):
4130         (createWindow):
4131         (main):
4132
4133 2010-12-04  Antonio Gomes  <agomes@rim.com>
4134
4135         Reviewed by Martin Robinson.
4136
4137         [Gtk] Populate DumpRenderTreeSupportGtk (Part II)
4138         https://bugs.webkit.org/show_bug.cgi?id=48429
4139
4140         Moved more private method declared with WEBKIT_API to
4141         DumpRenderTreeSupportGtk, since they were only being used by DRT.
4142
4143         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4144         (resetDefaultsToConsistentValues):
4145         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4146         (LayoutTestController::addOriginAccessWhitelistEntry):
4147         (LayoutTestController::execCommand):
4148         (LayoutTestController::isCommandEnabled):
4149
4150 2010-12-04  Antonio Gomes  <agomes@rim.com>
4151
4152         Reviewed by Andreas Kling.
4153
4154         Removed extern webkit_web_view_set_group_name from gtk/DumpRenderTree.cpp
4155
4156         Method was removed by http://trac.webkit.org/changeset/71604
4157
4158         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4159
4160 2010-12-05  Alejandro G. Castro  <alex@igalia.com>
4161
4162         Reviewed by Xan Lopez.
4163
4164         [GTK] Fix compilation warnings reported by clang
4165         https://bugs.webkit.org/show_bug.cgi?id=50252
4166
4167         * GtkLauncher/main.c:
4168         (create_window): The create_statusbar function does not have
4169         parameters.
4170
4171 2010-12-05  Robert Hogan  <robert@webkit.org>
4172
4173         Reviewed by Andreas Kling.
4174
4175         [Qt] Zero-sized font does not yet work
4176
4177         Fix fast/text/font-size-zero.html
4178
4179         Copy other ports by setting minimumFontSize to 0 for DRT runs.
4180
4181         https://bugs.webkit.org/show_bug.cgi?id=49759
4182
4183         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4184         (WebCore::WebPage::WebPage):
4185
4186 2010-12-04  Sam Weinig  <sam@webkit.org>
4187
4188         Reviewed by Jon Honeycutt.
4189
4190         WebKit2: Need client functions to notify app when the url changes due to a fragment navigation
4191         https://bugs.webkit.org/show_bug.cgi?id=50511
4192
4193         Update tools for new didChangeLocationWithinPageForFrame client function (and changed bundle
4194         signature) and added a test for the functionality (PageLoadDidChangeLocationWithinPageForFrame.cpp)
4195
4196         * MiniBrowser/mac/BrowserWindowController.m:
4197         (didChangeLocationWithinPageForFrame):
4198         (-[BrowserWindowController awakeFromNib]):
4199         (-[BrowserWindowController didChangeLocationWithinPageForFrame:]):
4200         * TestWebKitAPI/PlatformUtilities.cpp:
4201         (TestWebKitAPI::Util::toWK):
4202         * TestWebKitAPI/PlatformUtilities.h:
4203         (TestWebKitAPI::Util::adoptWK):
4204         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4205         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp: Added.
4206         (TestWebKitAPI::nullJavaScriptCallback):
4207         (TestWebKitAPI::didFinishLoadForFrame):
4208         (TestWebKitAPI::didChangeLocationWithinPageForFrame):
4209         (TestWebKitAPI::TEST):
4210         * TestWebKitAPI/Tests/WebKit2/file-with-anchor.html: Added.
4211         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
4212         * TestWebKitAPI/win/copy-resources.cmd:
4213         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4214         (WTR::InjectedBundlePage::InjectedBundlePage):
4215         (WTR::InjectedBundlePage::didChangeLocationWithinPageForFrame):
4216         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
4217         * WebKitTestRunner/TestController.cpp:
4218         (WTR::TestController::initialize):
4219
4220 2010-11-08  Antonio Gomes  <agomes@rim.com>
4221
4222         Reviewed by Martin Robinson.
4223
4224         [Gtk] Populate DumpRenderTreeSupportGtk
4225         https://bugs.webkit.org/show_bug.cgi?id=48429
4226
4227         Made the previous calls to webkit_web_frame* functions defined as private
4228         APIs in webkitprivate.h go through DRTSupportGtk.
4229
4230         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
4231         (AccessibilityController::focusedElement):
4232         * DumpRenderTree/gtk/DumpRenderTree.cpp:
4233         (dumpFramesAsText):
4234         (resetDefaultsToConsistentValues):
4235         (dump):
4236         (webViewDocumentLoadFinished):
4237         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
4238         (LayoutTestController::counterValueForElementById):
4239         (LayoutTestController::pageNumberForElementById):
4240         (LayoutTestController::numberOfPages):
4241         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
4242         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
4243         (LayoutTestController::sampleSVGAnimationForElementAtTime):
4244         (LayoutTestController::numberOfActiveAnimations):
4245         (LayoutTestController::suspendAnimations):
4246         (LayoutTestController::resumeAnimations):
4247         (LayoutTestController::markerTextForListItem):
4248
4249 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
4250
4251         Reviewed by Tony Chang.
4252
4253         Rebaseline server: use pretty text diff output
4254         https://bugs.webkit.org/show_bug.cgi?id=50484
4255         
4256         Serve *-pretty-diff.html for text diff output.
4257
4258         * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
4259         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
4260         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
4261         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4262
4263 2010-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
4264
4265         Unreviewed, rolling out r73302.
4266         http://trac.webkit.org/changeset/73302
4267         https://bugs.webkit.org/show_bug.cgi?id=50499
4268
4269         Causes crashes in debug LayoutTests (Requested by xan_ on
4270         #webkit).
4271
4272         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
4273         (AccessibilityUIElement::AccessibilityUIElement):
4274         (AccessibilityUIElement::parentElementCallback):
4275         * DumpRenderTree/chromium/AccessibilityUIElement.h:
4276         * DumpRenderTree/chromium/CppBoundClass.cpp:
4277         * DumpRenderTree/chromium/CppBoundClass.h:
4278
4279 2010-12-03  Sam Weinig  <sam@webkit.org>
4280
4281         Reviewed by Maciej Stachowiak.
4282
4283         Enable <a ping> for Mac/Windows/WebKit2 builds
4284         <rdar://problem/8504473>
4285         https://bugs.webkit.org/show_bug.cgi?id=50488
4286
4287         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
4288         (TestWebKitAPI::TEST): Test that the default value of
4289         WKPreferencesGetHyperlinkAuditingEnabled is true.
4290
4291 2010-12-03  Chris Guillory  <chris.guillory@google.com>
4292
4293         Reviewed by Chris Fleizach.
4294
4295         Include the FrameView widget of a RenderWidget in the accessibility tree.
4296         https://bugs.webkit.org/show_bug.cgi?id=49106
4297
4298         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
4299         (AccessibilityUIElement::AccessibilityUIElement):
4300         (AccessibilityUIElement::parentElementCallback):
4301         (AccessibilityUIElement::isEqualCallback):
4302         * DumpRenderTree/chromium/AccessibilityUIElement.h:
4303         * DumpRenderTree/chromium/CppBoundClass.cpp:
4304         (CppBoundClass::getFromCppVariant):
4305         * DumpRenderTree/chromium/CppBoundClass.h:
4306
4307 2010-12-03  Mihai Parparita  <mihaip@chromium.org>
4308
4309         Reviewed by Tony Chang.
4310
4311         Rebaseline server: organize tests by state, add dry run mode
4312         https://bugs.webkit.org/show_bug.cgi?id=50473
4313         
4314         Group tests in the menu by state, so that it's easier to see after
4315         processing the queue which failed.
4316         
4317         Add support for the --dry-run flag so that it's easier to test changes
4318         such as this (stubs out filesystem and SCM operations).
4319
4320         * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
4321         * Scripts/webkitpy/tool/commands/data/rebaselineserver/queue.js:
4322         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
4323
4324 2010-12-03  Brady Eidson  <beidson@apple.com>
4325