Update WebKitSystemInterface
[WebKit-https.git] / Tools / ChangeLog
1 2016-09-07  Daniel Bates  <dabates@apple.com>
2
3         Update WebKitSystemInterface
4
5         Rubber-stamped by Dean Jackson.
6
7         Copy WebKitSystemInterface for iOS 10 to the built products directory.
8
9         * Scripts/copy-webkitlibraries-to-product-directory:
10
11 2016-09-07  Youenn Fablet  <youenn@apple.com>
12
13         [Streams API] Separate compile flag for ReadableStream and WritableStream
14         https://bugs.webkit.org/show_bug.cgi?id=161044
15
16         Reviewed by Alex Christensen.
17
18         Moving from STREAMS_API to READABLE_STREAM_API and WRITABLE_STREAM_API compilation flags.
19
20         * Scripts/webkitperl/FeatureList.pm:
21         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
22
23 2016-09-07  Carlos Garcia Campos  <cgarcia@igalia.com>
24
25         [GTK] Move some GObject DOM unstable API to stable
26         https://bugs.webkit.org/show_bug.cgi?id=161681
27
28         Reviewed by Žan Doberšek.
29
30         Do not use user message handler unstable API in the tests, since we have stable convenient API for that.
31
32         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
33         (testUserContentManagerScriptMessageFromDOMBindings):
34         (serverCallback): Deleted.
35         (beforeAll): Deleted.
36         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
37         (documentLoadedCallback):
38         (emitURIChanged): Deleted.
39
40 2016-09-07  Youenn Fablet  <youenn@apple.com>
41
42         Using tests-options.json to compute whether tests are slow
43         https://bugs.webkit.org/show_bug.cgi?id=161626
44
45         Reviewed by Darin Adler.
46
47         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Updated first test to use a MockHost.
48         * Scripts/webkitpy/layout_tests/controllers/manager.py:
49         (Manager.__init__): Loading tests-options.json
50         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
51
52 2016-09-07  Hunseop Jeong  <hs85.jeong@samsung.com>
53
54         [EFL] Need the libosmesa to support the software backend drawing.
55         https://bugs.webkit.org/show_bug.cgi?id=147065
56
57         Reviewed by Gyuyoung Kim.
58
59         Added the libosmesa to support the software backend drawing.
60
61         * efl/install-dependencies:
62
63 2016-09-06  Commit Queue  <commit-queue@webkit.org>
64
65         Unreviewed, rolling out r205521, r205526, and r205532.
66         https://bugs.webkit.org/show_bug.cgi?id=161668
67
68         broke API tests (Requested by alexchristensen on #webkit).
69
70         Reverted changesets:
71
72         "Punycode encode non-ascii hosts in URLParser"
73         https://bugs.webkit.org/show_bug.cgi?id=161655
74         http://trac.webkit.org/changeset/205521
75
76         "Fix query-only and fragment-only relative URLs when using
77         URLParser"
78         https://bugs.webkit.org/show_bug.cgi?id=161657
79         http://trac.webkit.org/changeset/205526
80
81         "URLParser should parse / as a relative URL"
82         https://bugs.webkit.org/show_bug.cgi?id=161667
83         http://trac.webkit.org/changeset/205532
84
85 2016-09-06  Alex Christensen  <achristensen@webkit.org>
86
87         URLParser should parse / as a relative URL
88         https://bugs.webkit.org/show_bug.cgi?id=161667
89
90         Reviewed by Tim Horton.
91
92         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
93         (TestWebKitAPI::TEST_F):
94
95 2016-09-06  Daniel Bates  <dabates@apple.com>
96
97         [iOS] DumpRenderTree and WebKitTestRunner fail to build - "Ad Hoc code signing is not allowed with SDK 'Simulator - iOS 10.0'"
98         https://bugs.webkit.org/show_bug.cgi?id=161661
99
100         Reviewed by Darin Adler.
101
102         Allow ad-hoc code signing when building the dummy DumpRenderTree and WebKitTestRunner
103         command line tools for simulator with the iOS 10 beta SDK.
104
105         * DumpRenderTree/mac/Configurations/Base.xcconfig:
106         * WebKitTestRunner/Configurations/Base.xcconfig:
107
108 2016-09-06  Alex Christensen  <achristensen@webkit.org>
109
110         Fix query-only and fragment-only relative URLs when using URLParser
111         https://bugs.webkit.org/show_bug.cgi?id=161657
112
113         Reviewed by Tim Horton.
114
115         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
116         (TestWebKitAPI::TEST_F):
117
118 2016-09-06  Alex Christensen  <achristensen@webkit.org>
119
120         Punycode encode non-ascii hosts in URLParser
121         https://bugs.webkit.org/show_bug.cgi?id=161655
122
123         Reviewed by Tim Horton.
124
125         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
126         (TestWebKitAPI::wideString):
127         (TestWebKitAPI::TEST_F):
128
129 2016-09-05  Alex Christensen  <achristensen@webkit.org>
130
131         Implement relative file urls and begin implementing character encoding in URLParser
132         https://bugs.webkit.org/show_bug.cgi?id=161618
133
134         Reviewed by Tim Horton.
135
136         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
137         (TestWebKitAPI::TEST_F):
138
139 2016-09-06  Commit Queue  <commit-queue@webkit.org>
140
141         Unreviewed, rolling out r205480.
142         https://bugs.webkit.org/show_bug.cgi?id=161630
143
144         tests-options.json is not known from knockout filesystem
145         (Requested by youenn on #webkit).
146
147         Reverted changeset:
148
149         "Using tests-options.json to compute whether tests are slow"
150         https://bugs.webkit.org/show_bug.cgi?id=161626
151         http://trac.webkit.org/changeset/205480
152
153 2016-09-06  Michael Catanzaro  <mcatanzaro@igalia.com>
154
155         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
156         https://bugs.webkit.org/show_bug.cgi?id=161606
157
158         Reviewed by Darin Adler.
159
160         Avoid extra arguments in call to sprintf, hopefully without introducing new warnings this
161         time.
162
163         * Scripts/prepare-ChangeLog:
164         (statusDescription):
165
166 2016-09-06  Youenn Fablet  <youenn@apple.com>
167
168         Using tests-options.json to compute whether tests are slow
169         https://bugs.webkit.org/show_bug.cgi?id=161626
170
171         Reviewed by Darin Adler.
172
173         * Scripts/webkitpy/layout_tests/controllers/manager.py:
174         (Manager.__init__): Loading tests-options.json
175         (Manager._test_is_slow): Computing timeout value based on tests-options.json.
176
177 2016-09-06  Commit Queue  <commit-queue@webkit.org>
178
179         Unreviewed, rolling out r205461.
180         https://bugs.webkit.org/show_bug.cgi?id=161628
181
182         Introduced "Use of uninitialized value $original in sprintf"
183         warning (Requested by mcatanzaro on #webkit).
184
185         Reverted changeset:
186
187         ""Redundant argument in sprintf" warning spam from prepare-
188         ChangeLog"
189         https://bugs.webkit.org/show_bug.cgi?id=161606
190         http://trac.webkit.org/changeset/205461
191
192 2016-09-06  Youenn Fablet  <youenn@apple.com>
193
194         W3C test importer should be able to identify slow test
195         https://bugs.webkit.org/show_bug.cgi?id=161601
196
197         Reviewed by Darin Adler.
198
199         Test parser is now identifying slow tests based on "meta element name=timeout content=long" elements.
200         Test importer is updating test-options.json file according that information.
201
202         In case of clean import, the test-options.json is cleaned from 'slow' options for all W3C tests.
203
204         * Scripts/webkitpy/w3c/test_importer.py:
205         (TestImporter.__init__):
206         (TestImporter.find_importable_tests):
207         (TestImporter.import_tests):
208         (TestImporter.update_test_options):
209         (TestImporter):
210         (TestImporter.remove_slow_from_w3c_test_options):
211         * Scripts/webkitpy/w3c/test_parser.py:
212         (TestParser.analyze_test):
213         (TestParser.is_slow_test):
214         (TestParser.potential_ref_filename):
215
216 2016-09-06  Per Arne Vollan  <pvollan@apple.com>
217
218         [Win] Crash logs have incorrect symbols.
219         https://bugs.webkit.org/show_bug.cgi?id=161603
220
221         Reviewed by Darin Adler.
222
223         Add build path to _NT_SYMBOL_PATH environment variable.
224
225         * Scripts/webkitpy/port/win.py:
226         (WinPort.setup_crash_log_saving):
227
228 2016-08-31  Filip Pizlo  <fpizlo@apple.com>
229
230         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
231         https://bugs.webkit.org/show_bug.cgi?id=160125
232
233         Reviewed by Geoffrey Garen and Keith Miller.
234
235         * DumpRenderTree/TestRunner.cpp:
236         * DumpRenderTree/mac/DumpRenderTree.mm:
237         (DumpRenderTreeMain):
238         * Scripts/run-jsc-stress-tests:
239         * TestWebKitAPI/Tests/WTF/Vector.cpp:
240         (TestWebKitAPI::TEST):
241
242 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
243
244         "Redundant argument in sprintf" warning spam from prepare-ChangeLog
245         https://bugs.webkit.org/show_bug.cgi?id=161606
246
247         Reviewed by Darin Adler.
248
249         Avoid extra arguments in call to sprintf.
250
251         * Scripts/prepare-ChangeLog:
252         (statusDescription):
253
254 2016-09-05  Michael Catanzaro  <mcatanzaro@igalia.com>
255
256         [GTK] Skip several failing API tests
257
258         Unfortunately we don't have any form of test expectations for API tests, so we'll just skip
259         them after bugs are filed.
260
261         * Scripts/run-gtk-tests:
262         (TestRunner):
263
264 2016-09-05  Youenn Fablet  <youenn@apple.com>
265
266         Fix W3C test importer unit tests after r205447
267         https://bugs.webkit.org/show_bug.cgi?id=161604
268
269         Unreviewed.
270
271         * Scripts/webkitpy/w3c/test_importer.py:
272         (TestImporter.__init__): Skip cleaning test_resource_files files if resource-files.json cannot be read.
273
274 2016-09-05  Philippe Normand  <pnormand@igalia.com>
275
276         WebRTC: Several media stream tests crashing
277         https://bugs.webkit.org/show_bug.cgi?id=161582
278
279         Reviewed by Alejandro G. Castro.
280
281         * gtk/jhbuild.modules: Bump to latest OpenWebRTC master fixing the crash on missing
282         glvideoflip GStreamer element.
283
284 2016-09-05  Youenn Fablet  <youenn@apple.com>
285
286         W3C test importer should generate the list of resource files
287         https://bugs.webkit.org/show_bug.cgi?id=161578
288
289         Reviewed by Ryosuke Niwa.
290
291         Generating LayoutTests/imported/w3c/resources/resource-files.json when importing tests.
292
293         * Scripts/webkitpy/w3c/test_importer.py:
294         (TestImporter.__init__): Reading test resource files configuration file.
295         (TestImporter.find_importable_tests):
296         (TestImporter.import_tests): Update the test resource files based on test parsed files.
297         (TestImporter):
298         (TestImporter._already_identified_as_resource_file): Helper routine to know whether a file is already set as a resource file.
299         (TestImporter._is_in_resources_directory: Helper routine to know whether a file is in a resources directory.
300
301 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
302
303         Media controls behave strangely when videos mute from within a playing handler
304         https://bugs.webkit.org/show_bug.cgi?id=161559
305         <rdar://problem/28018438>
306
307         Reviewed by Darin Adler.
308
309         Accounts for changes when determining whether or not to show media controls for autoplaying videos that have not
310         begun playing yet. Rather than check for a controlled media element upon page load, we force tests to wait until
311         all autoplaying videos have actually begun playing. This extends to tests that involve interaction, such as
312         clicking or scrolling.
313
314         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
315         (-[VideoControlsManagerTestWebView callJavascriptFunction:]):
316         (-[VideoControlsManagerTestWebView expectControlsManager:afterReceivingMessage:]):
317         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
318         (-[VideoControlsManagerTestWebView waitForPageToLoadWithAutoplayingVideos:]):
319         (TestWebKitAPI::TEST):
320         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]): Deleted.
321         * TestWebKitAPI/Tests/WebKit2Cocoa/autoplaying-video-with-audio.html:
322         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-hides-controls-after-seek-to-end.html:
323         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html:
324         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html:
325         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html:
326         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html:
327         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html:
328         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html:
329         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-with-audio-autoplay.html:
330
331 2016-09-03  Wenson Hsieh  <wenson_hsieh@apple.com>
332
333         Refactor the heuristic for showing media controls to take all media sessions into account
334         https://bugs.webkit.org/show_bug.cgi?id=161503
335         <rdar://problem/28033783>
336
337         Reviewed by Darin Adler.
338
339         Adds new unit tests verifying the behavior of media playback controls when scrolling another video into view.
340         Please see the WebCore ChangeLog for more details about this change. Also refactors existing
341         VideoControlsManager tests by folding duplicated setup and testing logic into helper methods to make the unit
342         tests more readable.
343
344         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
345         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
346         (-[MessageHandler initWithMessage:handler:]):
347         (-[MessageHandler userContentController:didReceiveScriptMessage:]):
348         (-[VideoControlsManagerTestWebView performAfterLoading:]):
349         (-[VideoControlsManagerTestWebView loadTestPageNamed:]):
350         (-[VideoControlsManagerTestWebView loadTestPageNamed:andExpectControlsManager:afterReceivingMessage:]):
351         (-[VideoControlsManagerTestWebView performAfterReceivingMessage:action:]):
352         (-[VideoControlsManagerTestWebView controlledElementID]):
353         (-[VideoControlsManagerTestWebView _handleControlledElementIDResponse:]):
354         (TestWebKitAPI::setUpWebViewForTestingVideoControlsManager):
355         (TestWebKitAPI::TEST):
356         (-[MediaPlaybackMessageHandler initWithWKWebView:finalMessageString:]): Deleted.
357         (-[MediaPlaybackMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
358         (-[OnLoadMessageHandler initWithWKWebView:handler:]): Deleted.
359         (-[OnLoadMessageHandler userContentController:didReceiveScriptMessage:]): Deleted.
360         (-[WKWebView performAfterLoading:]): Deleted.
361         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-playing-scroll-away.html: Added.
362         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-click-to-pause.html: Added.
363         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-autoplaying-scroll-to-video.html: Added.
364         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-paused-video-hides-controls.html: Added.
365         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-muted-video-hides-controls.html: Added.
366         * TestWebKitAPI/Tests/WebKit2Cocoa/large-videos-playing-video-keeps-controls.html: Added.
367
368 2016-09-03  Youenn Fablet  <youenn@apple.com>
369
370         run-webkit-tests should detect w3c test resource files
371         https://bugs.webkit.org/show_bug.cgi?id=161307
372
373         Reviewed by Ryosuke Niwa.
374
375         * Scripts/webkitpy/port/base.py:
376         (Port.__init__): Adding self._w3c_resource_files to store the list of resource files.
377         (Port.potential_test_names_from_expected_file):
378         (Port._real_tests):
379         (Port.is_w3c_resource_file): Computing whether a file is a resource file based on imported/w3c/resources/resource-files.json.
380         (Port._is_test_file): Updated to call Port.is_w3c_resource_file. _is_test_file is no longer static.
381         (Port): Deleted.
382         * Scripts/webkitpy/port/base_unittest.py:
383         (PortTest.test_additional_platform_directory):
384         (PortTest.test_find_no_paths_specified):
385         (PortTest.test_is_test_file): Updated to use non-static version of _is_test_file.
386         (PortTest.test_is_w3c_resource_file): Adding tests.
387
388 2016-09-02  Carlos Garcia Campos  <cgarcia@igalia.com>
389
390         Unreviewed. Fix archive-built-product step in GTK+ bots after r205280.
391
392         * BuildSlaveSupport/built-product-archive:
393         (archiveBuiltProduct): Do not copy to the archive the files needed to run GObject DOM bindings API breaks tests
394         that no longer exist.
395
396 2016-09-02  Alex Christensen  <achristensen@webkit.org>
397
398         URLParser should parse file URLs
399         https://bugs.webkit.org/show_bug.cgi?id=161556
400
401         Reviewed by Tim Horton.
402
403         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
404         (TestWebKitAPI::TEST_F):
405         (TestWebKitAPI::checkURLDifferences):
406
407 2016-09-01  Michael Saboff  <msaboff@apple.com>
408
409         Import Chakra tests to JSC
410         https://bugs.webkit.org/show_bug.cgi?id=154697
411
412         Reviewed by Saam Barati.
413
414         Added "runChakra" and "chakraPassFailErrorHandler" to support the running of
415         Chakra tests.
416
417         * Scripts/run-jsc-stress-tests:
418
419 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
420
421         WebKitTestRunner needs layoutTestController.setDashboardCompatibilityMode
422         https://bugs.webkit.org/show_bug.cgi?id=42547
423  
424         Reviewed by Darin Adler.
425
426         Added JavaScript bindings and C++ implementation of setUseDashboardCompatibilityMode for the WebKit2 sTestRunner.
427         Note: this bug mistakenly called this function setDashboardCompatibilityMode, it is actually setUseDashboardCompatibilityMode.
428
429         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added dashboard compatiblity mode setter.
430         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
431         (WTR::InjectedBundle::beginTesting): Reset dashboard compatibility mode.
432         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
433         (WTR::TestRunner::setJavaScriptCanAccessClipboard): Code style changes.
434         (WTR::TestRunner::setPrivateBrowsingEnabled): Code style changes.
435         (WTR::TestRunner::setUseDashboardCompatibilityMode): Added dashboard compatiblity mode setter.
436         (WTR::TestRunner::setPopupBlockingEnabled): Code style changes.
437         (WTR::TestRunner::setAuthorAndUserStylesEnabled): Code style changes.
438         (WTR::TestRunner::addOriginAccessWhitelistEntry): Code style changes.
439         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added dashboard compatiblity mode setter.
440
441 2016-09-02  Jer Noble  <jer.noble@apple.com>
442
443         Unreviewed build fix: restore storyboard files to Xcode 7-compatability.
444
445         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
446         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard:
447
448 2016-09-02  Tim Horton  <timothy_horton@apple.com>
449
450         REGRESSION (r205329): Two API tests time out on iOS Simulator
451         https://bugs.webkit.org/show_bug.cgi?id=161542
452
453         Reviewed by Brady Eidson.
454
455         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
456         (createAnimatedResizeWebView):
457         (createFirstVisuallyNonEmptyWatchingNavigationDelegate):
458         (TEST):
459         (animatedResizeWebView): Deleted.
460         The navigation delegate was being stored in a local and went out of scope
461         before the test was over. Keep it around, instead.
462
463 2016-08-31  Jer Noble  <jer.noble@apple.com>
464
465         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
466         https://bugs.webkit.org/show_bug.cgi?id=161462
467
468         Reviewed by Eric Carlson.
469
470         XCTest targets need to be in the same project as the application which they're testing. To facilitate
471         having external projects with XCTest targets, move the application's implementation into a framework
472         that can be included with a bare-bones application shell for testing.
473
474         Simultaneously, add the ability to load files from within the new framework's bundle by using a
475         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
476         an external server for testing.
477
478         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
479         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
480         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
481         * MobileMiniBrowser/MobileMiniBrowser/main.m:
482         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
483         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
484         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
485             controller from the framework's bundle.
486         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
487         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
488         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
489         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
490         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
491         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
492         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
493         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
494         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
495         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
496         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
497             pointing to the framework's resources directory.
498         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
499         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
500         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
501
502 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
503
504         Fix --no-sample-on-timeout command line argument
505         https://bugs.webkit.org/show_bug.cgi?id=161507
506
507         Reviewed by Alexey Proskuryakov.
508
509         This patch fixes the —no-sample-on-timeout flag and correctly names spindumps as spindump.txt.
510
511         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
512         (parse_args): Fixed —-no-sample-on-timeout.
513         * Scripts/webkitpy/port/apple.py:
514         (ApplePort.sample_process): Use correct file name.
515         (ApplePort.spindump_file_path): Spindump and sample file names are different.
516         * Scripts/webkitpy/port/driver.py:
517         (Driver._check_for_driver_timeout): Check “sample_on_timeout” flag.
518         * Scripts/webkitpy/port/mac_unittest.py:
519         (MacTest.test_spindump): Modified for correct filename.
520
521 2016-09-02  Jonathan Bedard  <jbedard@apple.com>
522
523         Unreviewed: moved myself to the reviewers list.
524
525         * Scripts/webkitpy/common/config/contributors.json:
526
527 2016-09-02  Tomas Popela  <tpopela@redhat.com>
528
529         [GTK] Fix compiler warning in MiniBrowser
530         https://bugs.webkit.org/show_bug.cgi?id=161529
531
532         We were missing a return statement in decidePermissionRequest() and
533         also there was unused variable in browserWindowConstructed().
534
535         Reviewed by Carlos Garcia Campos.
536
537         * MiniBrowser/gtk/BrowserTab.c:
538         (decidePermissionRequest):
539         * MiniBrowser/gtk/BrowserWindow.c:
540         (browserWindowConstructed):
541
542 2016-09-01  Dan Bernstein  <mitz@apple.com>
543
544         Build fix.
545
546         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
547
548 2016-09-01  Tim Horton  <timothy_horton@apple.com>
549
550         Provide a TestWebKitAPI-wide WKNavigationDelegate to simplify tests
551         https://bugs.webkit.org/show_bug.cgi?id=161413
552
553         Reviewed by Simon Fraser.
554
555         Add TestNavigationDelegate, which provides block properties to make
556         writing tests feel a little more natural (the callbacks can be inline),
557         and also add WKWebView _test_waitForDidFinishNavigation, so that many
558         tests don't even need to manually allocate a navigation delegate at all.
559
560         Adopt in some of the simpler tests; there are a few navigation delegates
561         left behind, which we can move to the new model in the future.
562
563         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
564         * TestWebKitAPI/Tests/WebKit2/WKBackForwardList.mm:
565         (TEST):
566         (-[WKBackForwardListTestNavigationDelegate webView:didFinishNavigation:]): Deleted.
567         * TestWebKitAPI/Tests/WebKit2Cocoa/AlwaysRevalidatedURLSchemes.mm:
568         (TEST):
569         (-[AlwaysRevalidatedURLSchemesDelegate webView:didFinishNavigation:]): Deleted.
570         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
571         (animatedResizeWebView):
572         (-[AnimatedResizeNavigationDelegate _webView:renderingProgressDidChange:]): Deleted.
573         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
574         (-[AutoLayoutWKWebView initWithFrame:configuration:]):
575         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
576         (TEST):
577         (-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]): Deleted.
578         * TestWebKitAPI/Tests/WebKit2Cocoa/CancelFontSubresource.mm:
579         (TEST):
580         (-[CancelFontSubresourceNavigationDelegate webView:didFinishNavigation:]): Deleted.
581         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm:
582         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
583         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
584         (TEST_F):
585         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]): Deleted.
586         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm:
587         (expectLinkCount):
588         (TEST):
589         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]): Deleted.
590         * TestWebKitAPI/Tests/WebKit2Cocoa/FindInPage.mm:
591         (TEST):
592         (-[FindInPageNavigationDelegate webView:didFinishNavigation:]): Deleted.
593         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
594         (TEST):
595         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
596         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
597         (TEST):
598         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]): Deleted.
599         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
600         (-[IndexedDBNavigationDelegate webView:didFinishNavigation:]): Deleted.
601         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm:
602         (TEST):
603         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]): Deleted.
604         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]): Deleted.
605         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
606         (RequiresUserActionForPlaybackTest::createWebView):
607         (RequiresUserActionForPlaybackTest::testVideoWithAudio):
608         (RequiresUserActionForPlaybackTest::testVideoWithoutAudio):
609         (RequiresUserActionForPlaybackTest::testAudioOnly):
610         (-[RequiresUserActionForPlaybackNavigationDelegate webView:didFinishNavigation:]): Deleted.
611         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm:
612         (TEST):
613         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]): Deleted.
614         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
615         (TEST):
616         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
617         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentWorld.mm:
618         (TEST):
619         (-[SimpleDelegate webView:didFinishNavigation:]): Deleted.
620         * TestWebKitAPI/Tests/WebKit2Cocoa/WKPDFViewResizeCrash.mm:
621         (TEST):
622         (-[WKPDFViewResizeNavigationDelegate webView:didFinishNavigation:]): Deleted.
623         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
624         (TEST):
625         (-[EvaluateJavaScriptNavigationDelegate webView:didFinishNavigation:]): Deleted.
626         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm:
627         (TEST):
628         (-[DummyNavigationDelegate webView:didFinishNavigation:]): Deleted.
629         * TestWebKitAPI/cocoa/TestNavigationDelegate.h: Added.
630         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm: Added.
631         (-[TestNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
632         (-[TestNavigationDelegate webView:didFinishNavigation:]):
633         (-[TestNavigationDelegate _webView:renderingProgressDidChange:]):
634         (-[TestNavigationDelegate waitForDidFinishNavigation]):
635         (-[WKWebView _test_waitForDidFinishNavigation]):
636
637 2016-09-01  Ricky Mondello  <rmondello@apple.com>
638
639         YouTube Flash plug-in replacement facility should not insert showinfo=0 into iframe URLs
640         https://bugs.webkit.org/show_bug.cgi?id=161478
641         <rdar://problem/28050847>
642
643         Reviewed by Eric Carlson.
644
645         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
646         (TestWebKitAPI::TEST_F): Update expected results.
647
648 2016-09-01  Anders Carlsson  <andersca@apple.com>
649
650         add BlockPtr::fromCallable
651         https://bugs.webkit.org/show_bug.cgi?id=161504
652
653         Reviewed by Tim Horton.
654
655         Add a test.
656
657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
658         * TestWebKitAPI/Tests/WTF/BlockPtr.mm: Added.
659         (TestWebKitAPI::TEST):
660
661 2016-09-01  Alex Christensen  <achristensen@webkit.org>
662
663         URLParser should handle . and .. in URL paths
664         https://bugs.webkit.org/show_bug.cgi?id=161443
665
666         Reviewed by Brady Eidson.
667
668         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
669         (TestWebKitAPI::eq):
670         (TestWebKitAPI::TEST_F):
671
672 2016-09-01  Commit Queue  <commit-queue@webkit.org>
673
674         Unreviewed, rolling out r205295 and r205303.
675         https://bugs.webkit.org/show_bug.cgi?id=161505
676
677         Broke the iOS build (Requested by ryanhaddad on #webkit).
678
679         Reverted changesets:
680
681         "Refactor MobileMiniBrowser into an application framework to
682         allow external XCTesting"
683         https://bugs.webkit.org/show_bug.cgi?id=161462
684         http://trac.webkit.org/changeset/205295
685
686         "Unreviewed build-fix; don't specify an explicit deployment
687         target."
688         http://trac.webkit.org/changeset/205303
689
690 2016-09-01  Ricky Mondello  <rmondello@apple.com>
691
692         YouTube Flash plug-in replacement facility should more gracefully handle malformed queries
693         https://bugs.webkit.org/show_bug.cgi?id=161476
694         <rdar://problem/28050847>
695
696         Reviewed by Eric Carlson.
697
698         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp:
699         (TestWebKitAPI::TEST_F): New tests. The first two and second-to-last test cases cover the "malformed" query
700             logic. A few other tests are added, too.
701
702 2016-09-01  Jer Noble  <jer.noble@apple.com>
703
704         Unreviewed build-fix; don't specify an explicit deployment target.
705
706         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
707
708 2016-08-31  Jer Noble  <jer.noble@apple.com>
709
710         Refactor MobileMiniBrowser into an application framework to allow external XCTesting
711         https://bugs.webkit.org/show_bug.cgi?id=161462
712
713         Reviewed by Eric Carlson.
714
715         XCTest targets need to be in the same project as the application which they're testing. To facilitate
716         having external projects with XCTest targets, move the application's implementation into a framework
717         that can be included with a bare-bones application shell for testing.
718
719         Simultaneously, add the ability to load files from within the new framework's bundle by using a
720         'bundle:/' URL scheme. Update the tests to use this new bundle URL and remove the dependency on
721         an external server for testing.
722
723         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
724         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard:
725         * MobileMiniBrowser/MobileMiniBrowser/Info.plist:
726         * MobileMiniBrowser/MobileMiniBrowser/main.m:
727         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
728         * MobileMiniBrowser/MobileMiniBrowserFramework/AppDelegate.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m.
729         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Manually instantiate the main view
730             controller from the framework's bundle.
731         * MobileMiniBrowser/MobileMiniBrowserFramework/Assets.xcassets/AppIcon.appiconset/Contents.json: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json.
732         * MobileMiniBrowser/MobileMiniBrowserFramework/Base.lproj/Main.storyboard: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard.
733         * MobileMiniBrowser/MobileMiniBrowserFramework/Info.plist: Added.
734         * MobileMiniBrowser/MobileMiniBrowserFramework/MobileMiniBrowser.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h.
735         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.h.
736         * MobileMiniBrowser/MobileMiniBrowserFramework/TabViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/TabViewController.m.
737         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.h: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.h.
738         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m: Renamed from Tools/MobileMiniBrowser/MobileMiniBrowser/WebViewController.m.
739         (+[NSURL __bundleURLForFileURL:bundle:]): Add utility method.
740         (+[NSURL __fileURLForBundleURL:bundle:]): Ditto.
741         (-[WebViewController navigateTo:]): Support loading "bundle:/" URLs which are really just "file:" URLs
742             pointing to the framework's resources directory.
743         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]): Ditto.
744         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m:
745         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
746
747 2016-09-01  Carlos Garcia Campos  <cgarcia@igalia.com>
748
749         Unreviewed. Fix webkitpy unit tests after r205280.
750
751         * Scripts/webkitpy/style/checker_unittest.py:
752         (GlobalVariablesTest.test_path_rules_specifier):
753
754 2016-08-31  Carlos Garcia Campos  <cgarcia@igalia.com>
755
756         [GTK] Move GObject DOM bindings to WebKit2 layer and stop auto generating them
757         https://bugs.webkit.org/show_bug.cgi?id=161438
758
759         Reviewed by Michael Catanzaro.
760
761         Remove scripts related to the GObject DOM bindings auto-generation.
762
763         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
764         (RunGtkAPITests.getText2):
765         (TestFactory.__init__):
766         (RunWebKit1Tests): Deleted.
767         (RunWebKit1Tests.start): Deleted.
768         (RunWebKit1LeakTests): Deleted.
769         (RunWebKit1LeakTests.start): Deleted.
770         (RunAndUploadPerfTests): Deleted.
771         (RunAndUploadPerfTests.start): Deleted.
772         (BuildAndRemoteJSCTestsFactory.__init__): Deleted.
773         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
774         (BuildStepsTest.test_unnecessary_expected_results):
775         (RunAndUploadPerfTestsTest): Deleted.
776         (RunAndUploadPerfTestsTest.assertResults): Deleted.
777         (RunAndUploadPerfTestsTest.test_success): Deleted.
778         (RunAndUploadPerfTestsTest.test_tests_failed): Deleted.
779         (RunAndUploadPerfTestsTest.test_build_bad_build): Deleted.
780         (RunAndUploadPerfTestsTest.test_build_bad_source_json): Deleted.
781         (RunAndUploadPerfTestsTest.test_build_bad_marge): Deleted.
782         (RunAndUploadPerfTestsTest.test_build_bad_failed_uploading): Deleted.
783         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
784         (RunAndUploadPerfTestsTest.test_buildbot_timeout): Deleted.
785         (RunBenchmarkTest): Deleted.
786         (RunBenchmarkTest.assertResults): Deleted.
787         (RunBenchmarkTest.test_success): Deleted.
788         * Scripts/run-bindings-tests:
789         (main):
790         * Scripts/webkitpy/style/checker.py:
791         * gtk/check-for-webkitdom-api-breaks: Removed.
792         * gtk/generate-gtkdoc:
793         * gtk/webkitdom.py: Removed.
794
795 2016-08-31  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
796
797         [EFL] Small clean up in MiniBrowser
798         https://bugs.webkit.org/show_bug.cgi?id=161428
799
800         Reviewed by Yusuke Suzuki.
801
802         This patch resizes MiniBrowser, add *char* constants for scheme,
803         does line breaking, and remove unnecessary spaces.
804
805         * MiniBrowser/efl/main.c:
806         (on_mouse_wheel):
807         (history_list_hide):
808         (script_execute_callback):
809         (on_key_down):
810         (on_url_changed):
811         (on_error):
812         (on_color_picker_request):
813         (url_from_user_input):
814         (url_load_from_user_input):
815         (on_back_button_clicked):
816         (on_search_case_option_changed):
817         (on_search_word_start_option_changed):
818         (on_list_item_select):
819         (navigation_button_longpress_process):
820         (on_navigation_policy_decision):
821         (window_create):
822         (parse_cookies_policy):
823
824 2016-08-31  Alex Christensen  <achristensen@webkit.org>
825
826         Implement IPv6 parsing in URLParser
827         https://bugs.webkit.org/show_bug.cgi?id=161390
828
829         Reviewed by Darin Adler.
830
831         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
832         (TestWebKitAPI::TEST_F):
833         (TestWebKitAPI::checkURLDifferences):
834
835 2016-08-31  Brady Eidson  <beidson@apple.com>
836
837         WK2 Gamepad provider on iOS.
838         https://bugs.webkit.org/show_bug.cgi?id=161412
839
840         Reviewed by Tim Horton.
841
842         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
843
844 2016-08-30  Ricky Mondello  <rmondello@apple.com>
845
846         YouTubePluginReplacementTest's URL transformation logic should have tests
847         https://bugs.webkit.org/show_bug.cgi?id=161406
848         <rdar://problem/28050847>
849
850         Reviewed by Eric Carlson.
851
852         Add some very basic tests. Future patches should expand on these to find and fix bugs.
853
854         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add YouTubePluginReplacement.cpp.
855         * TestWebKitAPI/Tests/WebCore/YouTubePluginReplacement.cpp: Added.
856         (TestWebKitAPI::test): Added.
857         (TestWebKitAPI::TEST_F): Added.
858
859 2016-08-30  Brady Eidson  <beidson@apple.com>
860
861         GameController.framework backend for gamepad API.
862         https://bugs.webkit.org/show_bug.cgi?id=161086
863
864         Reviewed by Alex Christensen.
865
866         * MiniBrowser/mac/AppDelegate.m:
867         (-[BrowserAppDelegate awakeFromNib]):
868
869         * MiniBrowser/mac/SettingsController.h:
870         * MiniBrowser/mac/SettingsController.m:
871         (-[SettingsController _populateMenu]):
872         (-[SettingsController validateMenuItem:]):
873         (-[SettingsController usesGameControllerFramework]):
874         (-[SettingsController toggleUsesGameControllerFramework:]):
875
876 2016-08-30  Brent Fulgham  <bfulgham@apple.com>
877
878         Use of uninitialised memory in TransformationMatrx::blend4()
879         https://bugs.webkit.org/show_bug.cgi?id=134621
880         <rdar://problem/27337539>
881
882         Reviewed by Dean Jackson.
883
884         Change is based on the Blink change (patch by <alancutter@chromium.org>):
885         <https://src.chromium.org/viewvc/blink?revision=177453&view=revision>
886
887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
888         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp: Added.
889         (TestWebKitAPI::TEST):
890
891 2016-08-30  Alex Christensen  <achristensen@webkit.org>
892
893         URLParser should handle relative URLs that start with //
894         https://bugs.webkit.org/show_bug.cgi?id=161364
895
896         Reviewed by Darin Adler.
897
898         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
899         (TestWebKitAPI::checkRelativeURL):
900         (TestWebKitAPI::TEST_F):
901
902 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
903
904         EWS patch status page should indicate bot corresponding to each status message
905         https://bugs.webkit.org/show_bug.cgi?id=161280
906
907         Reviewed by Alexey Proskuryakov.
908
909         * QueueStatusServer/templates/patch.html: Formatting changes.
910
911 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
912
913         EWS should indicate which bot processed the patch
914         https://bugs.webkit.org/show_bug.cgi?id=161222
915
916         Reviewed by Alexey Proskuryakov.
917
918         * QueueStatusServer/handlers/statusbubble.py:
919         (StatusBubble._build_bubble): Remove the bot id from bubbles as it is confusing.
920         bot ids are now displayed in patch status page.
921
922 2016-08-29  Alex Christensen  <achristensen@webkit.org>
923
924         URLParser should parse about:blank
925         https://bugs.webkit.org/show_bug.cgi?id=161324
926
927         Reviewed by Brady Eidson.
928
929         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
930         (TestWebKitAPI::TEST_F):
931
932 2016-08-29  JF Bastien  <jfbastien@apple.com>
933
934         Bug 161165 - check-webkit-style doesn't understand macros containing `else` or labels
935         https://bugs.webkit.org/show_bug.cgi?id=161165
936
937         Reviewed by Geoffrey Garen.
938
939         Fix handling of `else` in a macro. Don't handle labels in a macro:
940         the checker is already pretty messy in that area and it should be
941         a rare thing.
942
943         * Scripts/webkitpy/style/checkers/cpp.py:
944         (check_braces):
945         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
946         (CppStyleTest.test_else_clause_not_on_same_line_as_else):
947
948 2016-08-29  Alex Christensen  <achristensen@webkit.org>
949
950         API test URLParserTest.ParserFailures failing ASSERT_NOT_REACHED
951         https://bugs.webkit.org/show_bug.cgi?id=161317
952
953         Reviewed by Brady Eidson.
954
955         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
956         (TestWebKitAPI::TEST_F):
957
958 2016-08-29  Jer Noble  <jer.noble@apple.com>
959
960         Unreviewed gardening; only build MiniBrowser against iOS SDK targets.
961
962         * Makefile:
963
964 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
965
966         Sample Process on notifyDone timed out
967         https://bugs.webkit.org/show_bug.cgi?id=161063
968
969         Reviewed by Darin Adler.
970
971         * Scripts/webkitpy/port/driver.py:
972         (Driver._check_for_driver_timeout): 
973         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Call sample_process during notifyDone timeouts.
974         (WTR::TestRunner::waitToDumpWatchdogTimerFired):
975         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Log pid and name for testing harness.
976
977 2016-08-29  Jonathan Bedard  <jbedard@apple.com>
978
979         Check-webkit-style does not work with Objective-C blocks
980         https://bugs.webkit.org/show_bug.cgi?id=161247
981
982         Reviewed by Darin Adler.
983
984         * Scripts/webkitpy/style/checkers/cpp.py:
985         (regex_for_lambda_functions): Changed to regex_for_lambdas_and_blocks.
986         (regex_for_lambdas_and_blocks): Added check for Objective-C blocks.
987         (check_spacing_for_function_call): Pass file state for lambda check.
988         (check_spacing): Pass file state for lambda check.
989         (check_braces): Pass file state for lambda check.
990         (check_style): Pass file state for lambda check.
991         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
992         (CppStyleTest.test_cpp_lambda_functions): Changed from ‘test_lambda_functions’.
993         (CppStyleTest.test_objective_c_block): Tests Objective-C blocks.
994         (CppStyleTest.test_lambda_functions): Changed to ‘test_cpp_lambda_functions’.
995
996 2016-08-29  Aakash Jain  <aakash_jain@apple.com>
997
998         EWS patch status page should indicate bot corresponding to each status message
999         https://bugs.webkit.org/show_bug.cgi?id=161280
1000
1001         Reviewed by Alexey Proskuryakov.
1002
1003         * QueueStatusServer/templates/patch.html: Added bot_id in the template so that bot id is displayed
1004         for each status message.
1005         * QueueStatusServer/stylesheets/common.css:
1006         (.status-bot): Added corresponding stylesheet class.
1007
1008 2016-08-29  Per Arne Vollan  <pvollan@apple.com>
1009
1010         Attempt to fix Windows build after r205090.
1011
1012         Unreviewed build fix.
1013
1014         * DumpRenderTree/win/DRTDataObject.cpp:
1015         (cfFileNameWFormat):
1016         (cfUrlWFormat):
1017
1018 2016-08-27  Alex Christensen  <achristensen@webkit.org>
1019
1020         URLParser should parse relative URLs
1021         https://bugs.webkit.org/show_bug.cgi?id=161282
1022
1023         Reviewed by Darin Adler.
1024
1025         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1026         (TestWebKitAPI::TEST):
1027         Added some tests for the new operator=.
1028         Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects.
1029         Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested.
1030         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1031         (TestWebKitAPI::checkURL):
1032         (TestWebKitAPI::TEST_F):
1033         (TestWebKitAPI::checkRelativeURL):
1034         (TestWebKitAPI::checkURLDifferences):
1035         (TestWebKitAPI::shouldFail):
1036         Add some relative URL tests.
1037
1038 2016-08-27  Jonathan Bedard  <jbedard@apple.com>
1039
1040         WTR needs an implementation of setAutomaticLinkDetectionEnabled
1041         https://bugs.webkit.org/show_bug.cgi?id=87162
1042
1043         Reviewed by Darin Adler.
1044
1045         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding.
1046         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1047         (WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default.
1048         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1049         (WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.
1050         * WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration.
1051
1052 2016-08-27  Joseph Pecoraro  <pecoraro@apple.com>
1053
1054         Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
1055         https://bugs.webkit.org/show_bug.cgi?id=28685
1056         <rdar://problem/16460975>
1057
1058         Reviewed by Darin Adler.
1059
1060         * Scripts/extract-localizable-js-strings:
1061         * Scripts/update-webkit-localizable-strings:
1062         WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
1063         this script still use UTF-16, so keep that the default.
1064
1065 2016-08-27  Alexey Proskuryakov  <ap@apple.com>
1066
1067         REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
1068         https://bugs.webkit.org/show_bug.cgi?id=161254
1069
1070         Reviewed by Darin Adler.
1071
1072         Simplify the CSS. My understanding that the CSS was correct, and the root cause
1073         is tracked in bug 160478.
1074
1075         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
1076
1077 2016-08-27  Simon Fraser  <simon.fraser@apple.com>
1078
1079         Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
1080         https://bugs.webkit.org/show_bug.cgi?id=161217
1081
1082         Reviewed by Ryosuke Niwa.
1083
1084         "run-webkit-tests --print-expectations" runs the same logic as running the tests, but
1085         dumps out the lists of tests that would be run and skipped, and, for each, the entry
1086         in TestExpectations that determines the expected outcome of the test.
1087
1088         This is an improved version of webkit-patch print-expectations.
1089
1090         See bug for sample output.
1091
1092         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1093         (Manager._print_expectations_for_subset): Print out the list of tests and expected
1094         outcome for some subset of tests.
1095         (Manager.print_expectations): Do the same splitting by device class that running tests
1096         does, and for each subset of tests, call _print_expectations_for_subset.
1097         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1098         (TestExpectationParser.expectation_for_skipped_test): Set the flag
1099         expectation_line.not_applicable_to_current_platform
1100         (TestExpectationLine.__init__): Init not_applicable_to_current_platform to False
1101         (TestExpectationLine.expected_behavior): line.expectation is ['PASS'] by default,
1102         even for skipped tests. This function returns a list relevant for display, taking the skipped
1103         modifier into account.
1104         (TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
1105         (TestExpectations.readable_filename_and_line_number): Return something printable for 
1106         lines with and without filenames
1107         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1108         (main): Handle options.print_expectations
1109         (parse_args): Add support for --print-expectations
1110         (_print_expectations):
1111         * Scripts/webkitpy/port/ios.py:
1112         (IOSSimulatorPort.default_child_processes): Make this a debug log.
1113
1114 2016-08-26  Dan Bernstein  <mitz@apple.com>
1115
1116         Keep trying to fix the build after r205057.
1117
1118         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1119
1120 2016-08-26  Dan Bernstein  <mitz@apple.com>
1121
1122         Keep trying to fix the build after r205057.
1123
1124         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent
1125           config.h. This file is only meant to be built with Xcode anyway.
1126         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile
1127           with Xcode 7.3 and deploy to iOS 9.0.
1128         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
1129         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
1130         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
1131
1132 2016-08-26  Dan Bernstein  <mitz@apple.com>
1133
1134         Start trying to fix the build after r205057.
1135
1136         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1137
1138 2016-08-26  Alexey Proskuryakov  <ap@apple.com>
1139
1140         Remove Yosemite Leaks from the flakiness dashboard
1141         https://bugs.webkit.org/show_bug.cgi?id=161253
1142
1143         Reviewed by Anders Carlsson.
1144
1145         * TestResultServer/static-dashboards/builders.jsonp:
1146
1147 2016-08-26  Sam Weinig  <sam@webkit.org>
1148
1149         Remove support for ENABLE_LEGACY_WEB_AUDIO
1150         https://bugs.webkit.org/show_bug.cgi?id=161262
1151
1152         Reviewed by Anders Carlsson.
1153
1154         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1155
1156 2016-08-26  Jer Noble  <jer.noble@apple.com>
1157
1158         Add a test harness for running UI tests on the iOS Simulator
1159         https://bugs.webkit.org/show_bug.cgi?id=161265
1160
1161         Reviewed by Simon Fraser.
1162
1163         Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
1164         can serve as a test harness for WebKit UI tests.
1165
1166         Also add a basic media playback test which verifies that a <video> element will begin playing in
1167         fullscreen on an iPhone device, but will play inline on an iPad device.
1168
1169         * Makefile: Add MobileMiniBrowser as a Module for iOS builds.
1170         * MobileMiniBrowser/Configurations/Base.xcconfig: Added.
1171         * MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
1172         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
1173         * MobileMiniBrowser/Makefile: Added.
1174         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
1175         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
1176         * MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.
1177         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
1178         (-[AppDelegate applicationWillResignActive:]):
1179         (-[AppDelegate applicationDidEnterBackground:]):
1180         (-[AppDelegate applicationWillEnterForeground:]):
1181         (-[AppDelegate applicationDidBecomeActive:]):
1182         (-[AppDelegate applicationWillTerminate:]):
1183         * MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
1184         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
1185         * MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
1186         * MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
1187         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
1188         * MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.
1189         (-[TabViewController dealloc]):
1190         (-[TabViewController viewDidLoad]):
1191         (-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
1192         (-[TabViewController tableView:cellForRowAtIndexPath:]):
1193         (-[TabViewController tableView:numberOfRowsInSection:]):
1194         (-[TabViewController numberOfSectionsInTableView:]):
1195         (-[TabViewController tableView:canEditRowAtIndexPath:]):
1196         (-[TabViewController tableView:canMoveRowAtIndexPath:]):
1197         (-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
1198         (-[TabViewController tableView:didSelectRowAtIndexPath:]):
1199         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
1200         * MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.
1201         (-[WebViewController viewDidLoad]):
1202         (-[WebViewController didReceiveMemoryWarning]):
1203         (-[WebViewController reload:]):
1204         (-[WebViewController goBack:]):
1205         (-[WebViewController goForward:]):
1206         (-[WebViewController urlFieldEditingBegan:]):
1207         (-[WebViewController navigateTo:]):
1208         (-[WebViewController showTabs:]):
1209         (-[WebViewController selectWebViewAtIndex:]):
1210         (-[WebViewController removeWebViewAtIndex:]):
1211         (-[WebViewController addWebView]):
1212         (-[WebViewController createWebView]):
1213         (-[WebViewController removeWebView:]):
1214         (-[WebViewController setCurrentWebView:]):
1215         (-[WebViewController webView:didFailNavigation:withError:]):
1216         (-[WebViewController observeValueForKeyPath:ofObject:change:context:]):
1217         * MobileMiniBrowser/MobileMiniBrowser/main.m: Added.
1218         (main):
1219         * MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
1220         * MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.
1221         (-[MobileMiniBrowserUITests setUp]):
1222         (-[MobileMiniBrowserUITests tearDown]):
1223         (-[MobileMiniBrowserUITests testBasicVideoPlayback]):
1224
1225 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
1226
1227         webkit-queues queue-status page should should list more recent statuses
1228         https://bugs.webkit.org/show_bug.cgi?id=161220
1229
1230         Reviewed by Daniel Bates.
1231
1232         * QueueStatusServer/handlers/queuestatus.py:
1233         (QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.
1234
1235 2016-08-26  Dan Bernstein  <mitz@apple.com>
1236
1237         [Cocoa] Infinite recursion calling -charValue on a WKNSNumber
1238         https://bugs.webkit.org/show_bug.cgi?id=161258
1239
1240         Reviewed by Anders Carlsson.
1241
1242         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:
1243         (TestWebKitAPI::TEST):
1244
1245 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
1246
1247         Fix the ENABLE(WEBASSEMBLY) build on Linux
1248         https://bugs.webkit.org/show_bug.cgi?id=161197
1249
1250         Reviewed by Mark Lam.
1251
1252         * Scripts/build-jsc:
1253
1254 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1255
1256         [GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
1257         https://bugs.webkit.org/show_bug.cgi?id=161149
1258
1259         Reviewed by Carlos Garcia Campos.
1260
1261         Add a new function for waiting for the accesibility bus. It sets
1262         the test environment variables before starting the GLib mainloop.
1263         And restores the previous environment after it has finished.
1264         It also adds a timeout (5 seconds) to abort in case it has not
1265         been able to detect the accesibility bus before the timeout expires.
1266
1267         * Scripts/run-gtk-tests:
1268         (TestRunner):
1269         (TestRunner._wait_for_accessibility_bus):
1270         (TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
1271         (TestRunner._start_accessibility_daemons):
1272         (TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.
1273
1274 2016-08-26  Per Arne Vollan  <pvollan@apple.com>
1275
1276         [Win] Warning fix.
1277         https://bugs.webkit.org/show_bug.cgi?id=161236
1278
1279         Reviewed by Brent Fulgham.
1280
1281         The & operator in the Test struct has no body.
1282
1283         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1284         (TestWebKitAPI::TEST):
1285
1286 2016-08-26  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1287
1288         [GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
1289         https://bugs.webkit.org/show_bug.cgi?id=160736
1290
1291         Reviewed by Carlos Garcia Campos.
1292
1293         This plugs run-gtk-tests into the webkitpy testing infrastructure.
1294         As a benefit of this, run-gtk-tests now can be executed over any of
1295         the existing supported gtk test display servers (xvfb, weston-over-xvfb,
1296         or native xorg). A new command line switch --wayland is added for
1297         run-gtk-tests.
1298
1299         * Scripts/run-gtk-tests:
1300         (TestRunner.__init__): Remove the --display command line switch, its not longer useful.
1301         Add a --wayland command line switch.
1302         (TestRunner._start_accessibility_daemons):
1303         (TestRunner):
1304         (TestRunner.__init__):
1305         (TestRunner._run_xvfb): Deleted.
1306         (TestRunner._create_driver):
1307         (TestRunner._setup_testing_environment): Delete the environment variable definitions that
1308         are now done by driver._setup_environ_for_test().
1309         (TestRunner._tear_down_testing_environment):
1310         * Scripts/webkitpy/port/driver.py:
1311         (Driver.__init__): Define self._server_name in the constructor of the base class.
1312         It is used by several functions, so it makes sense to store once the value here.
1313         (Driver._setup_environ_for_test): Factorize setting the environment for a given test.
1314         (Driver._start): Get the environment from self._setup_environ_for_test()
1315         * Scripts/webkitpy/port/driver_unittest.py:
1316         (DriverTest):
1317         (DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()
1318         * Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.
1319         (GtkPort.__init__):
1320         (GtkPort._driver_class):
1321         * Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()
1322         (WestonDriver._setup_environ_for_test):
1323         (WestonDriver._start):
1324         * Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()
1325         (XorgDriver._setup_environ_for_test):
1326         (XorgDriver._start):
1327         * Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()
1328         (XvfbDriver._setup_environ_for_test):
1329         (XvfbDriver._start):
1330
1331 2016-08-26  Csaba Osztrogonác  <ossy@webkit.org>
1332
1333         [EFL][GTK] REGRESSION(204877): Fix the clean build
1334         https://bugs.webkit.org/show_bug.cgi?id=161240
1335
1336         Reviewed by Carlos Garcia Campos.
1337
1338         * WebKitTestRunner/PlatformEfl.cmake:
1339         * WebKitTestRunner/PlatformGTK.cmake:
1340
1341 2016-08-26  Aakash Jain  <aakash_jain@apple.com>
1342
1343         EWS should indicate which bot processed the patch
1344         https://bugs.webkit.org/show_bug.cgi?id=161222
1345
1346         Reviewed by Daniel Bates.
1347
1348         * QueueStatusServer/handlers/statusbubble.py:
1349         (StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
1350         after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
1351         Also added "Started processing patch" message to progress_statuses.
1352         I might consider displaying bot id in other statuses as well later on.
1353
1354 2016-08-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1355
1356         [EFL] Change homepage url to www.ewebkit.org on MiniBrowser
1357         https://bugs.webkit.org/show_bug.cgi?id=161184
1358
1359         Reviewed by Carlos Garcia Campos.
1360
1361         * MiniBrowser/efl/main.c: Set www.ewebkit.org.
1362
1363 2016-08-25  Aakash Jain  <aakash_jain@apple.com>
1364
1365         ews queues should update status server when they start processing patch
1366         https://bugs.webkit.org/show_bug.cgi?id=161223
1367
1368         Reviewed by Daniel Bates.
1369
1370         * Scripts/webkitpy/tool/commands/queues.py:
1371         (AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.
1372         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1373         (EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.
1374         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1375         (StyleQueueTest.test_style_queue_with_style_exception): Same.
1376         (test_style_queue_with_watch_list_exception): Same.
1377         (test_non_valid_patch): Same.
1378
1379 2016-08-25  Alex Christensen  <achristensen@webkit.org>
1380
1381         CMake build fix.
1382
1383         * DumpRenderTree/PlatformMac.cmake:
1384
1385 2016-08-25  Alex Christensen  <achristensen@webkit.org>
1386
1387         Fix URLParserTest with GuardMalloc
1388         https://bugs.webkit.org/show_bug.cgi?id=161214
1389         rdar://problem/28014390
1390
1391         Reviewed by Tim Horton.
1392
1393         The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
1394         This just does the comparison of the CStrings instead to keep them in scope during the comparison.
1395
1396         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1397         (TestWebKitAPI::eq):
1398         (TestWebKitAPI::checkURL):
1399         (TestWebKitAPI::checkURLDifferences):
1400         (TestWebKitAPI::s): Deleted.
1401
1402 2016-08-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1403
1404         Dragging against the end of the inline media scrubber causes the media scrubber to hide
1405         https://bugs.webkit.org/show_bug.cgi?id=161207
1406
1407         Reviewed by Eric Carlson.
1408
1409         Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
1410         controls in this case, we should actually continue showing them. This is because seeking due to user gestures
1411         similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.
1412
1413         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1414         (TestWebKitAPI::TEST):
1415
1416 2016-08-25  Daniel Bates  <dabates@apple.com>
1417
1418         Watch more things.
1419
1420         * Scripts/webkitpy/common/config/watchlist:
1421
1422 2016-08-25  Daniel Bates  <dabates@apple.com>
1423
1424         Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
1425         (https://bugs.webkit.org/show_bug.cgi?id=148437)
1426
1427         Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
1428         and is not installed on the GTK Linux bots.
1429
1430         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:
1431         (writeFileWithContent): Added.
1432
1433 2016-08-25  Per Arne Vollan  <pvollan@apple.com>
1434
1435         [Win] run-api-tests is failing.
1436         https://bugs.webkit.org/show_bug.cgi?id=161140
1437
1438         Reviewed by Brent Fulgham.
1439
1440         Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.
1441
1442         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1443         (TestWebKitAPI::TEST):
1444
1445 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
1446
1447         [Win] run-api-tests is failing.
1448         https://bugs.webkit.org/show_bug.cgi?id=161140
1449
1450         Reviewed by Brent Fulgham.
1451
1452         The number of times the move constructor is called is different on Windows in this test. This seems
1453         to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.
1454
1455         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
1456         (TestWebKitAPI::TEST):
1457
1458 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1459
1460         Fix iOS DRT build.
1461
1462         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1463         (WTR::UIScriptController::zoomToScale):
1464
1465 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1466
1467         [iOS DRT] Hook up uiController.zoomToScale() for DRT
1468         https://bugs.webkit.org/show_bug.cgi?id=161173
1469
1470         Reviewed by Tim Horton.
1471         
1472         Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
1473         UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.
1474         
1475         UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
1476         the WebThread!), but queue up the callback first.
1477
1478         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1479         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
1480         (-[DumpRenderTreeWebScrollView initWithFrame:]):
1481         (-[DumpRenderTreeWebScrollView dealloc]):
1482         (-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
1483         (-[DumpRenderTreeWebScrollView completedZoomToScale]):
1484         (-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
1485         (-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
1486         (-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):
1487         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1488         (WTR::UIScriptController::zoomToScale):
1489         * DumpRenderTree/mac/DumpRenderTree.mm:
1490         (createWebViewAndOffscreenWindow):
1491         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1492         (WTR::UIScriptController::context):
1493
1494 2016-08-24  Ryan Haddad  <ryanhaddad@apple.com>
1495
1496         Attempt to fix Windows build after r204918.
1497
1498         Unreviewed build fix.
1499
1500         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1501         (ResourceLoadDelegate::willSendRequest):
1502
1503 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1504
1505         [iOS DRT] Get basic viewport tests working in DRT
1506         https://bugs.webkit.org/show_bug.cgi?id=161160
1507
1508         Reviewed by Tim Horton.
1509         
1510         Hook up enough of UIScriptController in iOS DRT to be able to read viewport
1511         scale, and get the contentVisibleRect.
1512         
1513         Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
1514         requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.
1515         
1516         One test has different results between DRT and WTR, but DRT behavior seems to differ
1517         from UIWebView here, so just give it a WK1-specific result.
1518
1519         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1520         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:
1521         (-[DumpRenderTreeBrowserView documentVisibleRect]):
1522         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1523         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1524         (WTR::UIScriptController::zoomScale):
1525         (WTR::UIScriptController::minimumZoomScale):
1526         (WTR::UIScriptController::maximumZoomScale):
1527         (WTR::UIScriptController::contentVisibleRect):
1528         * DumpRenderTree/mac/DumpRenderTree.mm:
1529         (createWebViewAndOffscreenWindow):
1530         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1531
1532 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1533
1534         Minor project rearrangement.
1535
1536         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1537
1538 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1539
1540         [iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
1541         https://bugs.webkit.org/show_bug.cgi?id=161124
1542
1543         Reviewed by Daniel Bates.
1544         
1545         Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
1546         and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.
1547         
1548         Remove some unnecessary zero initializations of static variables.
1549         
1550         Change _setVisibleSize to use the window size, which should not be a behavior change
1551         because this it just used for text autosizing, which is disabled by default,
1552         and only the width is consulted.
1553
1554         * DumpRenderTree/mac/DumpRenderTree.mm:
1555         (adjustWebDocumentForFlexibleViewport):
1556         (adjustWebDocumentForStandardViewport):
1557         (createWebViewAndOffscreenWindow):
1558
1559 2016-08-24  Jonathan Bedard  <jbedard@apple.com>
1560
1561         WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
1562         https://bugs.webkit.org/show_bug.cgi?id=42777
1563
1564         Reviewed by Darin Adler.
1565
1566         The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called.  Removed function and test.
1567
1568         * DumpRenderTree/TestRunner.cpp:
1569         (setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.
1570         * DumpRenderTree/TestRunner.h:
1571         (TestRunner::deferMainResourceDataLoad): Ditto.
1572         (TestRunner::setDeferMainResourceDataLoad): Ditto.
1573         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
1574
1575 2016-08-23  Anders Carlsson  <andersca@apple.com>
1576
1577         Add enum traits and use them in the IPC::Decoder
1578         https://bugs.webkit.org/show_bug.cgi?id=161103
1579
1580         Reviewed by Sam Weinig.
1581
1582         Add API test.
1583
1584         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1585         * TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.
1586         (TestWebKitAPI::TEST):
1587
1588 2016-08-24  Filip Pizlo  <fpizlo@apple.com>
1589
1590         Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.
1591
1592         * DumpRenderTree/TestRunner.cpp:
1593         * DumpRenderTree/mac/DumpRenderTree.mm:
1594         (DumpRenderTreeMain):
1595         * Scripts/run-jsc-stress-tests:
1596         * TestWebKitAPI/Tests/WTF/Vector.cpp:
1597         (TestWebKitAPI::TEST):
1598
1599 2016-08-24  Simon Fraser  <simon.fraser@apple.com>
1600
1601         Try to fix Production builds.
1602         
1603         PRODUCTION_FRAMEWORKS_DIR was undefined here.
1604
1605         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1606
1607 2016-08-24  Dan Bernstein  <mitz@apple.com>
1608
1609         Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
1610         https://bugs.webkit.org/show_bug.cgi?id=161152
1611
1612         Reviewed by Anders Carlsson.
1613
1614         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1615         * TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.
1616         (TestWebKitAPI::didFinishLoadForFrame):
1617         (TestWebKitAPI::TEST):
1618
1619 2016-08-24  Nan Wang  <n_wang@apple.com>
1620
1621         AX: Add test for line text marker range on iOS
1622         https://bugs.webkit.org/show_bug.cgi?id=161108
1623         <rdar://problem/27976405>
1624
1625         Reviewed by Chris Fleizach.
1626
1627         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1628         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1629         (AccessibilityUIElement::textMarkerRangeForElement):
1630         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1631         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1632         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
1633
1634 2016-08-24  Per Arne Vollan  <pvollan@apple.com>
1635
1636         [Win] Warning fixes.
1637         https://bugs.webkit.org/show_bug.cgi?id=161079
1638
1639         Reviewed by Brent Fulgham.
1640
1641         * MiniBrowser/win/WebDownloadDelegate.cpp:
1642         * MiniBrowser/win/WinMain.cpp:
1643         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1644         (TestWebKitAPI::TEST):
1645
1646 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
1647
1648         Fix Windows DRT build.
1649
1650         * DumpRenderTree/win/TestRunnerWin.cpp:
1651         (TestRunner::mainFrameJSContext):
1652
1653 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
1654
1655         Try to fix Windows build.
1656         
1657         Pass Tools/DumpRenderTree/Bindings as the working directory for the generate_bindings.pl
1658         so that perl finds CodeGeneratorDumpRenderTree.pm.
1659
1660         * DumpRenderTree/CMakeLists.txt:
1661
1662 2016-08-23  Simon Fraser  <simon.fraser@apple.com>
1663
1664         Hook up UIScriptController in DumpRenderTree
1665         https://bugs.webkit.org/show_bug.cgi?id=161064
1666
1667         Reviewed by Sam Weinig.
1668
1669         Add a skeleton implementation of UIScriptController to DumpRenderTree, building for both
1670         Mac and iOS. Currently this is sufficient to test doAsyncTask(), enabling two tests
1671         in fast/harness which test this.
1672
1673         Add a DerivedSources target to DumpRenderTree to invoke DerivedSources.make.
1674
1675         Move related code shared between WTR and DRT into Tools/TestRunnerShared, and cleanse it of
1676         WK2-isms. Fix the makefiles to refer to the new location.
1677
1678         Hook up TestRunner::runUIScript() for DumpRenderTree, which requires keeping track of callbacks
1679         by ID and firing them once they are complete.
1680
1681         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm: Added (copied from WTR).
1682         * DumpRenderTree/CMakeLists.txt:
1683         * DumpRenderTree/DerivedSources.make: Copied from Tools/WebKitTestRunner/DerivedSources.make.
1684         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1685         * DumpRenderTree/TestRunner.cpp:
1686         (runUIScriptCallback):
1687         (TestRunner::staticFunctions):
1688         (TestRunner::cacheTestRunnerCallback):
1689         (TestRunner::callTestRunnerCallback):
1690         (TestRunner::clearTestRunnerCallbacks):
1691         (nextUIScriptCallbackID):
1692         (TestRunner::runUIScript):
1693         (TestRunner::callUIScriptCallback):
1694         (TestRunner::uiScriptDidComplete):
1695         (TestRunner::cleanup):
1696         * DumpRenderTree/TestRunner.h:
1697         * DumpRenderTree/ios/UIScriptControllerIOS.mm: Added.
1698         * DumpRenderTree/mac/Configurations/Base.xcconfig: DerivedSources.make needs WEBCORE_PRIVATE_HEADERS_DIR to be defined.
1699         * DumpRenderTree/mac/DumpRenderTree.mm:
1700         (runTest):
1701         * DumpRenderTree/mac/TestRunnerMac.mm:
1702         (TestRunner::mainFrameJSContext):
1703         * DumpRenderTree/mac/UIScriptControllerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
1704         (WTR::UIScriptController::doAsyncTask):
1705         * DumpRenderTree/win/DumpRenderTree.cpp:
1706         * TestRunnerShared/Bindings/JSWrappable.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h.
1707         (WTR::JSWrappable::~JSWrappable):
1708         (WTR::JSValueMakeStringOrNull):
1709         * TestRunnerShared/Bindings/JSWrapper.cpp: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp.
1710         (WTR::JSWrapper::wrap):
1711         (WTR::JSWrapper::unwrap):
1712         (WTR::unwrapObject):
1713         (WTR::JSWrapper::initialize):
1714         (WTR::JSWrapper::finalize):
1715         * TestRunnerShared/Bindings/JSWrapper.h: Renamed from Tools/WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h.
1716         (WTR::toJS):
1717         (WTR::setProperty):
1718         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl: Renamed from Tools/WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl.
1719         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.cpp.
1720         * TestRunnerShared/UIScriptContext/UIScriptContext.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptContext.h.
1721         (WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):
1722         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.cpp.
1723         * TestRunnerShared/UIScriptContext/UIScriptController.h: Renamed from Tools/WebKitTestRunner/UIScriptContext/UIScriptController.h.
1724         * WebKitTestRunner/CMakeLists.txt:
1725         * WebKitTestRunner/DerivedSources.make:
1726         * WebKitTestRunner/InjectedBundle/Bindings/JSWrappable.h:
1727         (WTR::JSWrappable::~JSWrappable): Deleted.
1728         (WTR::JSValueMakeStringOrNull): Deleted.
1729         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
1730         (WTR::JSWrapper::wrap): Deleted.
1731         (WTR::JSWrapper::unwrap): Deleted.
1732         (WTR::unwrapObject): Deleted.
1733         (WTR::JSWrapper::initialize): Deleted.
1734         (WTR::JSWrapper::finalize): Deleted.
1735         * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.h:
1736         (WTR::toJS): Deleted.
1737         (WTR::setProperty): Deleted.
1738         * WebKitTestRunner/TestInvocation.cpp:
1739         (WTR::TestInvocation::runUISideScript):
1740         (WTR::TestInvocation::uiScriptDidComplete):
1741         * WebKitTestRunner/TestInvocation.h:
1742         * WebKitTestRunner/UIScriptContext/UIScriptContext.cpp: Moved
1743         * WebKitTestRunner/UIScriptContext/UIScriptContext.h: Moved
1744         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp: Moved
1745         * WebKitTestRunner/UIScriptContext/UIScriptController.h: Moved
1746         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1747         * WebKitTestRunner/config.h:
1748         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1749         (WTR::UIScriptController::contentVisibleRect):
1750
1751 2016-08-23  Saam Barati  <sbarati@apple.com>
1752
1753         JSC should have a "microbenchmarks" directory instead of "regress" directory
1754         https://bugs.webkit.org/show_bug.cgi?id=161096
1755
1756         Rubber stamped by Mark Lam.
1757
1758         This patch moves LayoutTests/js/regress/script-tests to the JSTests/microbenchmarks
1759         directory and removes all the related html and txt files. I did this because
1760         that directory was only there for microbenchmarks, and not for "regression"
1761         tests. I also changed the various scripts to point to it.
1762
1763         * Scripts/run-javascriptcore-tests:
1764         (runJSCStressTests):
1765         * Scripts/run-jsc-benchmarks:
1766
1767 2016-08-23  Alex Christensen  <achristensen@webkit.org>
1768
1769         Fix EFL build.
1770
1771         * TestWebKitAPI/CMakeLists.txt:
1772         Include new directory.
1773
1774 2016-08-22  Filip Pizlo  <fpizlo@apple.com>
1775
1776         Butterflies should be allocated in Auxiliary MarkedSpace instead of CopiedSpace and we should rewrite as much of the GC as needed to make this not a regression
1777         https://bugs.webkit.org/show_bug.cgi?id=160125
1778
1779         Reviewed by Geoffrey Garen.
1780
1781         * DumpRenderTree/TestRunner.cpp: Rewire some #includes.
1782         * Scripts/run-jsc-stress-tests: New test flag!
1783
1784 2016-08-23  Brady Eidson  <beidson@apple.com>
1785
1786         WK2 Gamepad layout test support.
1787         https://bugs.webkit.org/show_bug.cgi?id=134671
1788
1789         Reviewed by Alex Christensen.
1790         
1791         Have the injected bundle expose the MockGamepadProvider to the UI process, which will then 
1792         feed back into the UIGamepadProvider.
1793         
1794         Also, fool NSApplication into treating the most recently created "isKeyWindow" of the test windows
1795         as the actual keyWindow for the test runner, which will allow the view to get gamepad updates.
1796
1797         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
1798         
1799         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1800         (WTR::TestRunner::setMockGamepadDetails):
1801         (WTR::TestRunner::setMockGamepadAxisValue):
1802         (WTR::TestRunner::setMockGamepadButtonValue):
1803         
1804         * WebKitTestRunner/PlatformWebView.h:
1805         
1806         * WebKitTestRunner/TestController.cpp:
1807         (WTR::TestController::initialize):
1808         
1809         * WebKitTestRunner/TestInvocation.cpp:
1810         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1811         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Deleted.
1812         
1813         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1814         
1815         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1816         (-[WebKitTestRunnerWindow initWithFrame:]):
1817         (-[WebKitTestRunnerWindow dealloc]):
1818         (WTR::PlatformWebView::keyWindow):
1819         
1820         * WebKitTestRunner/ios/TestControllerIOS.mm:
1821         (WTR::wtr_NSApplication_keyWindow):
1822         (WTR::TestController::platformInitialize):
1823         
1824         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1825         (+[WebKitTestRunnerWindow _WTR_keyWindow]):
1826         (-[WebKitTestRunnerWindow initWithContentRect:styleMask:backing:defer:]):
1827         (-[WebKitTestRunnerWindow dealloc]):
1828         (WTR::PlatformWebView::keyWindow):
1829         
1830         * WebKitTestRunner/mac/TestControllerMac.mm:
1831         (WTR::wtr_NSApplication_keyWindow):
1832         (WTR::TestController::platformInitialize):
1833         * WebKitTestRunner/mac/main.mm:
1834
1835 2016-08-23  Alexey Proskuryakov  <ap@apple.com>
1836
1837         REGRESSION (PHP 5.6): http/tests/misc/bad-charset-alias.html fails
1838         https://bugs.webkit.org/show_bug.cgi?id=161047
1839         rdar://problem/27434307
1840
1841         Reviewed by Lucas Forschler.
1842
1843         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Specify a php.ini file.
1844
1845 2016-08-23  Chris Dumez  <cdumez@apple.com>
1846
1847         Unreviewed, rolling out r204243.
1848
1849         Caused some layout test failures
1850
1851         Reverted changeset:
1852
1853         "Write API test to cover crash fix in r204135"
1854         https://bugs.webkit.org/show_bug.cgi?id=160587
1855         http://trac.webkit.org/changeset/204243
1856
1857 2016-08-23  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
1858
1859         Order feature option list in FeatureList.pm
1860         https://bugs.webkit.org/show_bug.cgi?id=161074
1861
1862         Reviewed by Michael Catanzaro.
1863
1864         Reorder features in alphabetical order based on command line option. Also, sort variables in alphabetical order.
1865
1866         * Scripts/webkitperl/FeatureList.pm:
1867
1868 2016-08-22  Dewei Zhu  <dewei_zhu@apple.com>
1869
1870         Stop python icon bouncing in the dock while running browser benchmarks.
1871         https://bugs.webkit.org/show_bug.cgi?id=161066
1872
1873         Reviewed by Ryosuke Niwa.
1874
1875         Bouncing python icon may impact browser benchmark results.
1876         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1877         (OSXBrowserDriver.prepare_env):
1878         (OSXBrowserDriver.restore_env):
1879
1880 2016-08-22  Simon Fraser  <simon.fraser@apple.com>
1881
1882         <select> menu on iPad causes shifting of hit-testing areas
1883         https://bugs.webkit.org/show_bug.cgi?id=150079
1884
1885         Reviewed by Tim Horton.
1886
1887         -isAssistingNode (aka the poorly named isEditable) is input into WebPageProxy::computeCustomFixedPositionRect(),
1888         so when it changes we have to update visible rects. We were doing this on focus, but failing
1889         to do it on blur.
1890
1891         Added the ability to test by:
1892         1. Making it possible to initiate an animated scroll in the UI process
1893         2. Adding callbacks for starting and ending interaction with a form control. Sadly
1894         the "ending interaction" for <select> popovers on iPad isn't late enough, since we
1895         have no way currently to know when the dimming view behind the popover animates out,
1896         so for now the test keeps trying to tap a button.
1897
1898         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
1899         * WebKitTestRunner/UIScriptContext/UIScriptContext.h:
1900         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
1901         (WTR::UIScriptController::setDidStartFormControlInteractionCallback):
1902         (WTR::UIScriptController::didStartFormControlInteractionCallback):
1903         (WTR::UIScriptController::setDidEndFormControlInteractionCallback):
1904         (WTR::UIScriptController::didEndFormControlInteractionCallback):
1905         (WTR::UIScriptController::scrollToOffset):
1906         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
1907         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
1908         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
1909         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1910         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1911         (-[TestRunnerWKWebView dealloc]):
1912         (-[TestRunnerWKWebView didStartFormControlInteraction]):
1913         (-[TestRunnerWKWebView didEndFormControlInteraction]):
1914         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1915         (WTR::contentOffsetBoundedInValidRange):
1916         (WTR::UIScriptController::scrollToOffset):
1917         (WTR::UIScriptController::platformSetDidStartFormControlInteractionCallback):
1918         (WTR::UIScriptController::platformSetDidEndFormControlInteractionCallback):
1919
1920 2016-08-22  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1921
1922         [EFL][GTK] Script process-linux-coredump is not needed, switch back to use the kernel core dumper instead.
1923         https://bugs.webkit.org/show_bug.cgi?id=160927
1924
1925         Reviewed by Daniel Bates.
1926
1927         * Scripts/process-linux-coredump: Removed.
1928         * Scripts/webkitpy/port/efl.py:
1929         (EflPort._get_crash_log):
1930         * Scripts/webkitpy/port/gtk.py:
1931         (GtkPort._get_crash_log):
1932         * Scripts/webkitpy/port/linux_get_crash_log.py:
1933         (GDBCrashLogGenerator.__init__):
1934         (GDBCrashLogGenerator.generate_crash_log):
1935         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
1936         (GDBCrashLogGeneratorTest.test_generate_crash_log):
1937
1938 2016-08-22  Jonathan Bedard  <jbedard@apple.com>
1939
1940         check-webkit-style does not work with Lambda functions in C++
1941         https://bugs.webkit.org/show_bug.cgi?id=160910
1942
1943         Reviewed by Darin Adler.
1944
1945         This change eliminates false positives on correctly styled lambda functions and includes a few basic checks on capture list.
1946
1947         * Scripts/webkitpy/style/checkers/cpp.py:
1948         (regex_for_lambda_functions): Added function which checks if a string is the start of a lambda function.
1949         (check_for_non_standard_constructs): Added lambda function check.
1950         (check_spacing_for_function_call): Added lambda function check.
1951         (check_braces): Added lambda function check.
1952         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1953         (CppStyleTest.test_lambda_functions): Added test function for lambda function style checks.
1954
1955 2016-08-21  Alex Christensen  <achristensen@webkit.org>
1956
1957         URLParser should parse IPv4 addresses
1958         https://bugs.webkit.org/show_bug.cgi?id=161023
1959
1960         Reviewed by Darin Adler.
1961
1962         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1963         (TestWebKitAPI::TEST_F):
1964         (TestWebKitAPI::checkURLDifferences):
1965         We are already getting differences between the old URL::parse and the new URLParser.
1966         (TestWebKitAPI::shouldFail):
1967
1968 2016-08-21  Daniel Bates  <dabates@apple.com>
1969
1970         prepare-ChangeLog lists unmodified functions as modified and marks functions with few changes as deleted
1971         https://bugs.webkit.org/show_bug.cgi?id=148437
1972
1973         Reviewed by Dan Bernstein.
1974
1975         * Scripts/prepare-ChangeLog:
1976         (diffCommand): When using a Subversion checkout, generate a unified diff without any context lines.
1977         This matches our behavior when using a Git checkout. The function overlap logic in generateFunctionListsByRanges()
1978         assumes that its line ranges were from a unified diff without any context lines.
1979         (extractLineRangeAfterChange): A deleted line should be represented with a ("begin line number", "end line number") = ("new starting line number", "new starting line number").
1980         (extractLineRangeBeforeChange): An added line should be represented with a ("begin line number", "end line number") = ("original starting line number", "original starting line number").
1981         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Update expected results
1982         based on changes to extractLineRangeAfterChange() and extractLineRangeBeforeChange().
1983         * Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl: Added.
1984         (discardOutput): Convenience function invokes the specified function redirecting standard output and standard error
1985         to /dev/null for the duration of the function call.
1986
1987 2016-08-20  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
1988
1989         [EFL] Remove unnecessary a patch to mute ecore warnings
1990         https://bugs.webkit.org/show_bug.cgi?id=160997
1991
1992         Reviewed by Darin Adler.
1993
1994         There is no warning messages during the layout test and perf test
1995         after bumping efl version from 1.17 to 1.18. Remove it.
1996
1997         * efl/patches/ecore_remove_warnings.patch: Removed.
1998
1999 2016-08-20  Simon Fraser  <simon.fraser@apple.com>
2000
2001         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
2002         https://bugs.webkit.org/show_bug.cgi?id=160985
2003
2004         Re-land r204672, but don't check the result of 'xcrun simctl shutdown', because
2005         device shutdown seems to happen as result of killing Simulator.apps, and we're racing
2006         with that.
2007
2008         * Scripts/webkitpy/layout_tests/views/printing.py:
2009         (Printer.print_config):
2010         * Scripts/webkitpy/port/base.py:
2011         (Port.driver_cmd_line_for_logging):
2012         (Port.driver_cmd_line): Deleted.
2013         * Scripts/webkitpy/port/driver.py:
2014         (IOSSimulatorDriver.cmd_line):
2015         * Scripts/webkitpy/port/ios.py:
2016         (IOSSimulatorPort.__init__):
2017         (IOSSimulatorPort.driver_cmd_line_for_logging):
2018         (IOSSimulatorPort._create_simulators):
2019         (IOSSimulatorPort.setup_test_run):
2020         (IOSSimulatorPort._quit_ios_simulator):
2021         (IOSSimulatorPort.clean_up_test_run):
2022         (IOSSimulatorPort._create_device):
2023         (IOSSimulatorPort):
2024         (IOSSimulatorPort._remove_device):
2025         (IOSSimulatorPort._testing_device):
2026         (IOSSimulatorPort.device_id_for_worker_number):
2027         (IOSSimulatorPort._set_device_class): Deleted.
2028         (IOSSimulatorPort.testing_device): Deleted.
2029         * Scripts/webkitpy/port/port_testcase.py:
2030         (PortTestCase.test_driver_cmd_line):
2031         * Scripts/webkitpy/xcode/simulator.py:
2032         (Device.shutdown):
2033         (Device):
2034         (Device.delete):
2035         (Device.reset):
2036         (Simulator):
2037         (Simulator.create_device):
2038         (Simulator.remove_device):
2039         (Simulator.device_number):
2040         (Simulator.device_state_description):
2041         (Simulator.wait_until_device_is_in_state):
2042
2043 2016-08-19  Ryan Haddad  <ryanhaddad@apple.com>
2044
2045         Unreviewed, rolling out r204659.
2046
2047         This change appears to have caused ios-simulator LayoutTests
2048         to fail when shutting down the simulator
2049
2050         Reverted changeset:
2051
2052         "REGRESSION (r204477): Running LayoutTests on ios-simulator
2053         became ~15 minutes slower"
2054         https://bugs.webkit.org/show_bug.cgi?id=160985
2055         http://trac.webkit.org/changeset/204659
2056
2057 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2058
2059         Build fix for non-USE_SIM_SERVICE_CONTEXT builds
2060         * LayoutTestRelay/LayoutTestRelay/main.m: (main):
2061
2062 2016-08-18  Simon Fraser  <simon.fraser@apple.com>
2063
2064         REGRESSION (r204477): Running LayoutTests on ios-simulator became ~15 minutes slower
2065         https://bugs.webkit.org/show_bug.cgi?id=160985
2066
2067         Reviewed by Alexey Proskuryakov.
2068         
2069         r204477 removed @memoized on a couple of ios.py functions, causing them to instantiate
2070         a Simulator() on every call, which causes 'xcrun simctl list' to run. The functions
2071         must not be @memoized, because their return value depends on the value of simulator_device_type().
2072         
2073         Fix by adding some global state in simulator.py that tracks the created devices 
2074         in a worker number -> Device dictionary. Explicitly create devices in _create_simulators(),
2075         and delete them in clean_up_test_run().
2076         
2077         Also explicitly called 'xcrun simctl shutdown' to shut down devices, since it seems
2078         that killing the Simulator apps isn't enough.
2079         
2080         Simulator tracks the devices in a global dictionary, since state needs to persist
2081         across different instances of IOSSimulatorPort.
2082         
2083         Annoyingly, the "Command line:" dumping tried to access a device before we'd done
2084         any setup. Rather than implicitly creating a device here (which the old code did),
2085         override the more clearly named driver_cmd_line_for_logging() in IOSSimulatorPort
2086         and set flag to say that device_id_for_worker_number() doesn't need to return a real
2087         device id.
2088
2089         * Scripts/webkitpy/layout_tests/views/printing.py:
2090         (print_options):
2091         (Printer.print_config):
2092         * Scripts/webkitpy/port/base.py:
2093         (Port.driver_cmd_line_for_logging):
2094         (Port.driver_cmd_line): Deleted.
2095         * Scripts/webkitpy/port/driver.py:
2096         (IOSSimulatorDriver.cmd_line):
2097         * Scripts/webkitpy/port/ios.py:
2098         (IOSSimulatorPort.__init__):
2099         (IOSSimulatorPort.driver_cmd_line_for_logging):
2100         (IOSSimulatorPort._create_simulators):
2101         (IOSSimulatorPort.setup_test_run):
2102         (IOSSimulatorPort.clean_up_test_run):
2103         (IOSSimulatorPort._create_device):
2104         (IOSSimulatorPort):
2105         (IOSSimulatorPort._remove_device):
2106         (IOSSimulatorPort._testing_device):
2107         (IOSSimulatorPort.device_id_for_worker_number):
2108         (IOSSimulatorPort._set_device_class): Deleted.
2109         (IOSSimulatorPort.testing_device): Deleted.
2110         * Scripts/webkitpy/port/port_testcase.py:
2111         (PortTestCase.test_driver_cmd_line):
2112         * Scripts/webkitpy/xcode/simulator.py:
2113         (Device.shutdown):
2114         (Device.delete):
2115         (Device.reset):
2116         (Simulator.create_device):
2117         (Simulator.remove_device):
2118         (Simulator.device_number):
2119         (Simulator.device_state_description):
2120         (Simulator.wait_until_device_is_in_state):
2121
2122 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2123
2124         Adopt SimServiceContext in LayoutTestRelay
2125         https://bugs.webkit.org/show_bug.cgi?id=161000
2126         <rdar://problem/25765594>
2127
2128         Reviewed by Daniel Bates.
2129
2130         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
2131         * LayoutTestRelay/LayoutTestRelay/main.m:
2132
2133 2016-08-19  Lucas Forschler  <lforschler@apple.com>
2134
2135         Remove Yosemite Leaks bot after http://trac.webkit.org/projects/webkit/changeset/204629
2136
2137         Reviewed by Kocsen Chung.
2138
2139         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2140         (WebKitBuildbot):
2141
2142 2016-08-19  Alexey Proskuryakov  <ap@apple.com>
2143
2144         Partial revert of r203811 - this key is not needed.
2145
2146         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m: (-[LTRelayController installApp]):
2147
2148 2016-08-19  Daniel Bates  <dabates@apple.com>
2149
2150         Another attempt to fix the iOS 9.3 build
2151
2152         Define WK_EMPTY_, WK_NOT_, and WK_NOT_YES.
2153
2154         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2155         * WebKitTestRunner/Configurations/Base.xcconfig:
2156
2157 2016-08-19  Lucas Forschler  <lforschler@apple.com>
2158
2159         Remove Yosemite Leaks bot from config.json
2160         
2161         Reviewed by Alexey Proskuryakov.
2162
2163         * BuildSlaveSupport/build.webkit.org-config/config.json:
2164
2165 2016-08-18  Dan Bernstein  <mitz@apple.com>
2166
2167         [Cocoa] API::Number needs to be wrapped by an NSNumber
2168         https://bugs.webkit.org/show_bug.cgi?id=160977
2169         <rdar://problem/27877735>
2170
2171         Reviewed by Anders Carlsson.
2172
2173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2174         * TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm: Added.
2175         (TestWebKitAPI::TEST):
2176
2177 2016-08-17  Myles C. Maxfield  <mmaxfield@apple.com>
2178
2179         [Cocoa] Migrate off of deprecated CoreGraphics API CGContextSelectFont() and CGContextShowTextAtPoint()
2180         https://bugs.webkit.org/show_bug.cgi?id=160895
2181
2182         Reviewed by Dean Jackson.
2183
2184         Link to the existing CoreText framework.
2185
2186         * DumpRenderTree/PlatformWin.cmake:
2187         * TestWebKitAPI/PlatformWin.cmake:
2188
2189 2016-08-17  Brent Fulgham  <bfulgham@apple.com>
2190
2191         [Win] Remove old libraries from build inputs
2192         https://bugs.webkit.org/show_bug.cgi?id=160949
2193
2194         Reviewed by Dean Jackson.
2195
2196         Modify the download script to remove the old 'icuuc.lib' and
2197         'icuin.lib' files for Windows builds.
2198
2199         * Scripts/update-webkit-auxiliary-libs:
2200
2201 2016-08-17  Jonathan Bedard  <jbedard@apple.com>
2202
2203         Extra logging for crash reason
2204         https://bugs.webkit.org/show_bug.cgi?id=160943
2205
2206         Reviewed by Alexey Proskuryakov.
2207
2208         A number of tests have been erroneously marked as crashed, this should help diagnose these false crashes.
2209
2210         * Scripts/webkitpy/port/server_process.py:
2211         (ServerProcess.write): Add extra logging to determine why a process has been marked as crashed.
2212         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
2213         (ServerProcess.has_crashed): Ditto.
2214
2215 2016-08-17  Dan Bernstein  <mitz@apple.com>
2216
2217         [Cocoa] -[NSString isEqualToString:] returns NO for any WKNSString argument
2218         https://bugs.webkit.org/show_bug.cgi?id=160938
2219         <rdar://problem/27876652>
2220
2221         Reviewed by Anders Carlsson.
2222
2223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2224         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm: Added.
2225         (TestWebKitAPI::TEST):
2226
2227 2016-08-17  Chris Fleizach  <cfleizach@apple.com>
2228
2229         AX: Support abbreviations in iOS
2230         https://bugs.webkit.org/show_bug.cgi?id=160907
2231
2232         Reviewed by Joanmarie Diggs.
2233
2234         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2235         (AccessibilityUIElement::stringAttributeValue):
2236         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2237         (WTR::AccessibilityUIElement::stringAttributeValue):
2238
2239 2016-08-17  Gyuyoung Kim  <gyuyoung.kim@navercorp.com>
2240
2241         [EFL] Bump efl version from 1.17 to 1.18
2242         https://bugs.webkit.org/show_bug.cgi?id=160899
2243
2244         Reviewed by Antonio Gomes.
2245
2246         To use efl-1.18, EFL port needs to update install dependencies as well.
2247
2248         * efl/install-dependencies:
2249         * efl/jhbuild.modules:
2250
2251 2016-08-17  Per Arne Vollan  <pvollan@apple.com>
2252
2253         [Win] Add tests for linked fonts.
2254         https://bugs.webkit.org/show_bug.cgi?id=160898
2255
2256         Reviewed by Brent Fulgham.
2257
2258         Add tests for https://trac.webkit.org/changeset/204502.
2259
2260         * TestWebKitAPI/PlatformWin.cmake:
2261         * TestWebKitAPI/Tests/WebCore/win/LinkedFonts.cpp: Added.
2262         (TestWebKitAPI::TEST):
2263
2264 2016-08-16  Daniel Bates  <dabates@apple.com>
2265
2266         prepare-ChangeLog: Extract logic from generateFunctionLists() into a function that takes a delegate object
2267         https://bugs.webkit.org/show_bug.cgi?id=160924
2268
2269         Reviewed by Stephanie Lewis.
2270
2271         Towards adding unit tests for generateFunctionLists() we move its logic into actuallyGenerateFunctionLists()
2272         and have actuallyGenerateFunctionLists() take a delegate object to use to query the file system and SCM.
2273         We modify generateFunctionLists() to call actuallyGenerateFunctionLists(). This will make is possible to
2274         test the generate function list machinery without requiring a SCM checkout by substituting a delegate
2275         object that mocks out the file system and SCM operations.
2276
2277         * Scripts/VCSUtils.pm:
2278         (parseDiffStartLine): Parses an SVN or Git start line and returns the path to the target file.
2279         * Scripts/prepare-ChangeLog:
2280         (generateFunctionLists): Move functionality to actually generate the function lists to actuallyGenerateFunctionLists(),
2281         abstracting the logic to query the file system and SCM into functions on a delegate object that
2282         we pass to it.
2283         (actuallyGenerateFunctionLists): Extracted from generateFunctionLists().
2284         (diffHeaderFormat): Deleted.
2285
2286 2016-08-16  Alex Christensen  <achristensen@webkit.org>
2287
2288         URLParser should parse URLs without credentials
2289         https://bugs.webkit.org/show_bug.cgi?id=160913
2290
2291         Reviewed by Brady Eidson.
2292
2293         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2294         (TestWebKitAPI::s):
2295         (TestWebKitAPI::checkURL):
2296         (TestWebKitAPI::TEST_F):
2297
2298 2016-08-16  Anders Carlsson  <andersca@apple.com>
2299
2300         Add WTF::ScopeExit
2301         https://bugs.webkit.org/show_bug.cgi?id=160908
2302
2303         Reviewed by Geoffrey Garen.
2304
2305         * TestWebKitAPI/CMakeLists.txt:
2306         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2307         * TestWebKitAPI/Tests/WTF/Scope.cpp: Added.
2308         (TestWebKitAPI::TEST):
2309
2310 2016-08-16  Aakash Jain  <aakash_jain@apple.com>
2311
2312         EWS logs file are rotated too quickly
2313         https://bugs.webkit.org/show_bug.cgi?id=160724
2314
2315         Reviewed by Daniel Bates.
2316
2317         Currently we are rotating the log file after 10 iterations of queue. If the queue
2318         doesn't have any pending patches, these iterations result in very small amount of 
2319         logs (1 KB log file). Even if the queue process some patches, logs are few KBs.
2320         This results in a lot of log files in a day. This patch ensures that we rotate the
2321         log file when its file size is greater than or equal to 100 KB.
2322
2323         * EWSTools/start-queue-mac.sh: Added check for file size before rotating log file.
2324
2325 2016-08-16  Daniel Bates  <dabates@apple.com>
2326
2327         WKSI static library should be named by major iOS revision, not individual updates
2328         https://bugs.webkit.org/show_bug.cgi?id=160727
2329         <rdar://problem/22274848>
2330
2331         Reviewed by Alexey Proskuryakov.
2332
2333         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2334         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2335         * Scripts/copy-webkitlibraries-to-product-directory:
2336         * WebKitTestRunner/Configurations/Base.xcconfig:
2337         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2338
2339 2016-08-16  Simon Fraser  <simon.fraser@apple.com>
2340
2341         Make it possible to test iOS select elements, and add iPhone and iPad tests for them
2342         https://bugs.webkit.org/show_bug.cgi?id=160909
2343
2344         Reviewed by Enrica Casucci.
2345         
2346         Add functions to UIScriptController to dismiss the form accessory view for iOS,
2347         and to programmatically pick a row from a <select> picker.
2348
2349         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2350         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2351         (WTR::UIScriptController::dismissFormAccessoryView):
2352         (WTR::UIScriptController::selectFormAccessoryPickerRow):
2353         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2354         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2355         (WTR::UIScriptController::dismissFormAccessoryView):
2356         (WTR::UIScriptController::selectFormAccessoryPickerRow):
2357
2358 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2359
2360         [iOS] Add iPad viewport and form tests, and revert the iPad-testing part of r202132
2361         https://bugs.webkit.org/show_bug.cgi?id=160878
2362
2363         Reviewed by Tim Horton.
2364         
2365         Remove testing-specific "forceIPadStyleZoomOnInputFocus" behavior added in r202132
2366         now that we have the ability to run tests in the iPad simulator.
2367
2368         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2369         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2370         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
2371         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
2372         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2373         * WebKitTestRunner/ios/TestControllerIOS.mm:
2374         (WTR::TestController::platformResetStateToConsistentValues): Deleted.
2375         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2376         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus): Deleted.
2377         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus): Deleted.
2378
2379 2016-08-15  Anders Carlsson  <andersca@apple.com>
2380
2381         Add an address-of operator to RetainPtr
2382         https://bugs.webkit.org/show_bug.cgi?id=160879
2383
2384         Reviewed by Tim Horton.
2385
2386         Test HashMap and HashSet with an object whose operator& is deleted.
2387
2388         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2389         Sort the Xcode project.
2390
2391         * TestWebKitAPI/Tests/WTF/DeletedAddressOfOperator.h: Added.
2392         (DeletedAddressOfOperator::DeletedAddressOfOperator):
2393         (DeletedAddressOfOperator::value):
2394         (DeletedAddressOfOperator::operator==):
2395         (WTF::HashTraits<DeletedAddressOfOperator>::constructDeletedValue):
2396         (WTF::HashTraits<DeletedAddressOfOperator>::isDeletedValue):
2397         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::hash):
2398         (WTF::DefaultHash<DeletedAddressOfOperator>::Hash::equal):
2399         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2400         (TestWebKitAPI::TEST):
2401         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2402         (TestWebKitAPI::TEST):
2403
2404 2016-08-16  Jonathan Bedard  <jbedard@apple.com>
2405
2406         False crashes in fast/text/emoji-gender-* tests
2407         https://bugs.webkit.org/show_bug.cgi?id=160779
2408
2409         Reviewed by Alexey Proskuryakov.
2410
2411         Fix from <rdar://problem/27786762>, where timed out tests falsely report as crashed.
2412
2413         * Scripts/webkitpy/port/driver.py:
2414         (Driver._check_for_driver_crash_or_unresponsiveness): Change call to ‘write’ to disable crash flag.
2415         * Scripts/webkitpy/port/driver_unittest.py: Added 3 variable to test version of ‘write.’
2416         * Scripts/webkitpy/port/server_process.py:
2417         (ServerProcess.write): Allow caller to disable crash flag on exception.
2418
2419 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2420
2421         webkitpy error in TestRunResults.merge()
2422         https://bugs.webkit.org/show_bug.cgi?id=160882
2423
2424         Reviewed by Daniel Bates.
2425         
2426         The argument to TestRunResults.merge() can be None if there are no device-specifc
2427         initial results or retry results in Manager.run(), so just return early in that case.
2428
2429         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2430         (TestRunResults.merge):
2431
2432 2016-08-15  Sam Weinig  <sam@webkit.org>
2433
2434         Speed up compile times by not including wtf/Variant.h so much
2435         https://bugs.webkit.org/show_bug.cgi?id=160847
2436
2437         Reviewed by Alex Christensen and Saam Barati.
2438
2439         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2440         (TestWebKitAPI::TEST):
2441         Explicitly use std::experimental::variant.
2442
2443 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2444
2445         Allow a port to run tests with a custom device setup
2446         https://bugs.webkit.org/show_bug.cgi?id=160833
2447
2448         Reviewed by Daniel Bates.
2449
2450         These changes allow the IOSSimulator port to run tests in iPad mode.
2451
2452         This is made possible by allowing a platform to define CUSTOM_DEVICE_CLASSES,
2453         in this case 'ipad'. When specified, any test in a directory with a suffix that matches
2454         a custom device will be collected into a set, and run in that device's environment after
2455         the other tests have run.
2456
2457         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2458         (Manager._custom_device_for_test): If the test contains a directory matching a
2459         custom device suffix, return that custom device.
2460         (Manager._set_up_run): Push the custom device class, if any, into options so
2461         that the Worker can get to it.
2462         (Manager.run): Go through the list of tests, and break it down into device-generic
2463         tests, and tests for each device class. _run_test_subset is then called for
2464         each collection of tests, and the results merged.
2465         (Manager._run_test_subset): Some lines unwrapped.
2466         (Manager._end_test_run):
2467         (Manager._run_tests):
2468         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2469         (SingleTestRunner.__init__): Unwrapped a line.
2470         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2471         (TestRunResults.merge): Add this function to merge TestRunResults
2472         * Scripts/webkitpy/layout_tests/views/printing.py:
2473         (Printer.print_workers_and_shards): Print the custom device, if any.
2474         * Scripts/webkitpy/port/base.py:
2475         (Port): Base port has empty array of custom devices.
2476         (Port.setup_test_run): Add device_class argument.
2477         * Scripts/webkitpy/port/driver.py:
2478         (DriverInput.__repr__):
2479         (Driver.check_driver.implementation):
2480         * Scripts/webkitpy/port/efl.py:
2481         (EflPort.setup_test_run):
2482         * Scripts/webkitpy/port/gtk.py:
2483         (GtkPort.setup_test_run):
2484         * Scripts/webkitpy/port/ios.py:
2485         (IOSSimulatorPort): Add CUSTOM_DEVICE_CLASSES for ipad.
2486         (IOSSimulatorPort.__init__):
2487         (IOSSimulatorPort.simulator_device_type): Use a device name from the DEVICE_CLASS_MAP
2488         based on the custom device class.
2489         (IOSSimulatorPort._set_device_class):
2490         (IOSSimulatorPort._create_simulators): Factor some code into this function.
2491         (IOSSimulatorPort.setup_test_run):
2492         (IOSSimulatorPort.testing_device):
2493         (IOSSimulatorPort.reset_preferences): This used to create the simulator apps, but that
2494         seemed wrong for this function. That was moved to setup_test_run().
2495         (IOSSimulatorPort.check_sys_deps): This function used to create testing devices,
2496         but this happened too early, before we knew which kind of devices to create. Devices
2497         are now created in setup_test_run().
2498         * Scripts/webkitpy/port/win.py:
2499         (WinPort.setup_test_run):
2500
2501 2016-08-15  Daniel Bates  <dabates@apple.com>
2502
2503         Cannot build WebKit for iOS device using Xcode 7.3/iOS 9.3 public SDK due to missing
2504         private frameworks and libraries
2505         https://bugs.webkit.org/show_bug.cgi?id=155931
2506         <rdar://problem/25807989>
2507
2508         Reviewed by Dan Bernstein.
2509
2510         Add directory WebKitLibraries/WebKitPrivateFrameworkStubs/iOS/X to the framework search path
2511         where X is the major version of the active iOS SDK.
2512
2513         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2514         * WebKitTestRunner/Configurations/Base.xcconfig:
2515
2516 2016-08-15  Simon Fraser  <simon.fraser@apple.com>
2517
2518         Add a setting and preferences to enable visual viewport mode
2519         https://bugs.webkit.org/show_bug.cgi?id=160843
2520
2521         Reviewed by Sam Weinig.
2522         
2523         Pref and a menu item to toggle visualViewportEnabled for WebKits 1 and 2.
2524
2525         * MiniBrowser/mac/SettingsController.h:
2526         * MiniBrowser/mac/SettingsController.m:
2527         (-[SettingsController _populateMenu]):
2528         (-[SettingsController validateMenuItem:]):
2529         (-[SettingsController visualViewportEnabled]):
2530         (-[SettingsController toggleVisualViewportEnabled:]):
2531         * MiniBrowser/mac/WK1BrowserWindowController.m:
2532         (-[WK1BrowserWindowController didChangeSettings]):
2533         * MiniBrowser/mac/WK2BrowserWindowController.m:
2534         (-[WK2BrowserWindowController didChangeSettings]):
2535
2536 2016-08-15  Konstantin Tokarev  <annulen@yandex.ru>
2537
2538         Allow using make-dist with non-GTK ports
2539         https://bugs.webkit.org/show_bug.cgi?id=160842
2540
2541         Reviewed by Michael Catanzaro.
2542
2543         This patch adds support for setting base name of tarball and argument
2544         passed to cmake's -DPORT= via command line arguments.
2545
2546         * gtk/make-dist.py:
2547         (Distcheck.configure):
2548         (Distcheck.check):
2549         (get_tarball_root_and_output_filename_from_arguments):
2550
2551 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2552
2553         [GTK] Install script lacks gstreamer related dependencies
2554         https://bugs.webkit.org/show_bug.cgi?id=160814
2555
2556         Reviewed by Carlos Garcia Campos.
2557
2558         * gtk/install-dependencies: Fedora case had already listed this dependencies,
2559         but both Arch and Debian/Ubuntu were missing them.
2560
2561 2016-08-13  Konstantin Tokarev  <annulen@yandex.ru>
2562
2563         make-dist.py should not allow unknown rules in manifest
2564         https://bugs.webkit.org/show_bug.cgi?id=160841
2565
2566         Reviewed by Carlos Garcia Campos.
2567
2568         * gtk/make-dist.py:
2569         (Manifest.process_line):
2570
2571 2016-08-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2572
2573         [EFL][GTK] Install script not working on Debian 9 (testing) and Ubuntu 16.10
2574         https://bugs.webkit.org/show_bug.cgi?id=160809
2575
2576         Reviewed by Carlos Garcia Campos.
2577
2578         * efl/install-dependencies: Factorize the previous logic for handling the php5/7
2579         case, and use it also for the new package names of libpng and libgeoclue.
2580         * gtk/install-dependencies: Ditto.
2581
2582 2016-08-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2583
2584         Skip to check directories existence in build-webkit
2585         https://bugs.webkit.org/show_bug.cgi?id=160691
2586
2587         Reviewed by Alex Christensen.
2588
2589         CMake checks if directories are there itself. So CMake ports
2590         don't need to check it in the build-webkit script.
2591
2592         * Scripts/build-webkit:
2593         * Scripts/webkitdirs.pm:
2594         (determineSourceDir):
2595         (isCMakeBuild):
2596
2597 2016-08-12  Alex Christensen  <achristensen@webkit.org>
2598
2599         Make URLParser work with URLs missing URL parts
2600         https://bugs.webkit.org/show_bug.cgi?id=160824
2601
2602         Reviewed by Brady Eidson.
2603
2604         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2605         (TestWebKitAPI::s):
2606         (TestWebKitAPI::checkURL):
2607         (TestWebKitAPI::TEST_F):
2608         (TestWebKitAPI::eq): Deleted.
2609
2610 2016-08-12  John Wilander  <wilander@apple.com>
2611
2612         Add HashCountedSet API tests to TestWTFLibrary target
2613         https://bugs.webkit.org/show_bug.cgi?id=160815
2614
2615         Reviewed by Alex Christensen.
2616
2617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2618             Added HashCountedSet.cpp and sorted the file reference section
2619             according to UNIX sort.
2620
2621 2016-08-12  Ryosuke Niwa  <rniwa@webkit.org>
2622
2623         run-benchmark should run JetStream 1.1 instead of 1.0.1
2624         https://bugs.webkit.org/show_bug.cgi?id=160816
2625
2626         Reviewed by Filip Pizlo.
2627
2628         Use the latest JetStream 1.1 in run-benchmark.
2629
2630         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
2631         (BenchmarkBuilder.__exit__):
2632         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Updated to apply against 1.1 directory.
2633         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Updated to use r190897, which is the last
2634         change to JetStream directory.
2635
2636 2016-08-12  Alex Christensen  <achristensen@webkit.org>
2637
2638         Initial URLParser implementation
2639         https://bugs.webkit.org/show_bug.cgi?id=160811
2640
2641         Reviewed by Brady Eidson.
2642
2643         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
2644         (TestWebKitAPI::eq):
2645         (TestWebKitAPI::checkURL):
2646         (TestWebKitAPI::TEST_F):
2647
2648 2016-08-12  Brady Eidson  <beidson@apple.com>
2649
2650         Fix the 32-bit Mac build after:
2651         Add WK2 ExperimentalFeature support to MiniBrowser
2652         https://bugs.webkit.org/show_bug.cgi?id=160788
2653
2654         Unreviewed.
2655
2656         Sprinkle "#if WK_API_ENABLED"s liberally.
2657         
2658         * MiniBrowser/mac/AppDelegate.m:
2659         (defaultConfiguration):
2660         * MiniBrowser/mac/SettingsController.m:
2661         (-[SettingsController _populateMenu]):
2662         (-[SettingsController validateMenuItem:]):
2663
2664 2016-08-12  Philippe Normand  <pnormand@igalia.com>
2665
2666         [GStreamer][OWR] Video rendering fixes
2667         https://bugs.webkit.org/show_bug.cgi?id=160764
2668
2669         Reviewed by Xabier Rodriguez-Calvar.
2670
2671         * gtk/jhbuild.modules: Bump to current OpenWebRTC master.
2672
2673 2016-08-12  Per Arne Vollan  <pvollan@apple.com>
2674
2675         Add missing return statement in convertFast function added in r204376.
2676
2677         Unreviewed.
2678
2679         * Scripts/webkitpy/common/system/path.py:
2680         (_CygPath.convertFast):
2681
2682 2016-08-11  Brady Eidson  <beidson@apple.com>
2683
2684         Add WK2 ExperimentalFeature support to MiniBrowser.
2685         https://bugs.webkit.org/show_bug.cgi?id=160788
2686
2687         Reviewed by Alex Christensen.
2688
2689         * MiniBrowser/mac/AppDelegate.h:
2690         * MiniBrowser/mac/AppDelegate.m:
2691         (defaultConfiguration):
2692         (defaultPreferences):
2693         
2694         * MiniBrowser/mac/SettingsController.m:
2695         (-[SettingsController _populateMenu]):
2696         (-[SettingsController validateMenuItem:]):
2697         (-[SettingsController toggleExperimentalFeature:]):
2698
2699 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
2700
2701         Keep EWS logs for longer
2702         https://bugs.webkit.org/show_bug.cgi?id=160776
2703
2704         Reviewed by Daniel Bates.
2705
2706         * EWSTools/start-queue-mac.sh: Keep logs for 30 days instead of 14 days.
2707
2708 2016-08-11  Simon Fraser  <simon.fraser@apple.com>
2709
2710         iOS DRT/WTR project cleanup
2711         https://bugs.webkit.org/show_bug.cgi?id=160778
2712
2713         Reviewed by Tim Horton.
2714
2715         Move TARGETED_DEVICE_FAMILY from the project to an xcconfig file.
2716
2717         Remove AppDelegate.* which were unused.
2718
2719         Exclude ios/Launch.storyboard on more platforms.
2720
2721         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2722         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2723         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2724         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2725         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Removed.
2726         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Removed.
2727         (-[AppDelegate application:didFinishLaunchingWithOptions:]): Deleted.
2728
2729 2016-08-11  Alex Christensen  <achristensen@webkit.org>
2730
2731         Fix Yosemite bots' cookie accept policies after r204365.
2732         https://bugs.webkit.org/show_bug.cgi?id=160758
2733
2734         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
2735         (TEST):
2736         This makes the test fully clean up after itself.
2737
2738 2016-08-11  Alex Christensen  <achristensen@webkit.org>
2739
2740         Fix Yosemite bots' cookie accept policies after r204365.
2741         https://bugs.webkit.org/show_bug.cgi?id=160758
2742
2743         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm:
2744         (TEST):
2745         I didn't restore the cookieAcceptPolicy of the sharedHTTPCookieStorage after changing it with this API test.
2746         On Yosemite, this is changing the cookieAcceptPolicy that DumpRenderTree uses.
2747         On more recent Cocoa platforms, it is only changing the cookieAcceptPolicy that TestWebKitAPI uses, which isn't
2748         causing any problems because there are no other API tests that do anything with cookies.
2749         My solution will be to restore the original cookieAcceptPolicy after running this API test to clean up,
2750         but first I am committing this patch setting the cookieAcceptPolicy to NSHTTPCookieAcceptPolicyOnlyFromMainDocumentDomain
2751         to reset any bots that have run tests since r204365.  I will commit a followup that sets it to originalCookieAcceptPolicy.
2752
2753 2016-08-11  Aakash Jain  <aakash_jain@apple.com>
2754
2755         EWS should check if the patch is still valid before executing every major step
2756         https://bugs.webkit.org/show_bug.cgi?id=160739
2757         rdar://problem/27768813
2758
2759         Reviewed by Alexey Proskuryakov.
2760
2761         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2762         (CommitQueueTask.run): validate method is now executed in base class.
2763         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
2764         (EarlyWarningSystemTask.run): validate method is now executed in base class.
2765         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
2766         (StyleQueueTask.validate): Raise an PatchIsNotValid exception instead of returning False.
2767         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2768         (PatchAnalysisTask._run_command): validate the patch before executing any command. This is to ensure
2769         that we do not waste time on any patch which has become invalid (e.g.: obsolete, r-).
2770         * Scripts/webkitpy/tool/commands/perfalizer.py:
2771         (PerfalizerTask.validate): Added.
2772         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2773         (test_manual_reject_during_processing): Updated test case.
2774
2775 2016-08-11  Alex Christensen  <achristensen@webkit.org>
2776
2777         Add URLParser stub
2778         https://bugs.webkit.org/show_bug.cgi?id=160770
2779
2780         Reviewed by Sam Weinig.
2781
2782         * TestWebKitAPI/PlatformGTK.cmake:
2783         * TestWebKitAPI/PlatformWin.cmake:
2784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2785         * TestWebKitAPI/Tests/WebCore/URLParser.cpp: Added.
2786         (TestWebKitAPI::TEST_F):
2787
2788 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2789
2790         [iOS DRT] Allow DRT to be iPad-sized in the iPad simulator
2791         https://bugs.webkit.org/show_bug.cgi?id=160761
2792
2793         Reviewed by Tim Horton.
2794
2795         Give iOS DRT a Launch storyboard.
2796
2797         Have it use a UIViewController so future forms testing works correctly.
2798
2799         Add TARGETED_DEVICE_FAMILY = "1,2" to the build settings for the .app, so that it
2800         can run in iPad mode.
2801
2802         Remove empty InfoPlist.strings files.
2803
2804         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2805         * DumpRenderTree/ios/Info.plist:
2806         * DumpRenderTree/ios/Launch.storyboard: Added.
2807         * DumpRenderTree/mac/DumpRenderTree.mm:
2808         (createWebViewAndOffscreenWindow):
2809         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2810         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Removed.
2811         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2812         (WTR::PlatformWebView::PlatformWebView): Drive-by leak fix.
2813
2814 2016-08-11  Per Arne Vollan  <pvollan@apple.com>
2815
2816         [Win] Unable to reliably run tests in parallel
2817         https://bugs.webkit.org/show_bug.cgi?id=140914
2818
2819         Reviewed by Brent Fulgham.
2820
2821         The cygpath utility function can fail badly when running with multiple DumpRenderTree
2822         processes. We can use string replacement to convert the Cygwin path to a Windows path
2823         instead.
2824
2825         * Scripts/webkitpy/common/system/path.py:
2826         (cygpathFast):
2827         * Scripts/webkitpy/port/driver.py:
2828         (Driver._command_from_driver_input):
2829
2830 2016-08-10  Alex Christensen  <achristensen@webkit.org>
2831
2832         Fix crash when changing cookie accept policy after r204327
2833         https://bugs.webkit.org/show_bug.cgi?id=160758
2834
2835         Reviewed by Simon Fraser.
2836
2837         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2838         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieAcceptPolicy.mm: Added.
2839         (-[CookieAcceptPolicyMessageHandler userContentController:didReceiveScriptMessage:]):
2840         (TEST):
2841         * TestWebKitAPI/Tests/WebKit2Cocoa/CookieMessage.html: Added.
2842
2843 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2844
2845         [iOS WK2] Have WebKitTestRunnerApp.app use a UIViewController, and fix to avoid the status bar
2846         https://bugs.webkit.org/show_bug.cgi?id=160757
2847
2848         Reviewed by Tim Horton.
2849
2850         When programmatically creating the test UIWindow, make a root UIViewController and parent
2851         the WKWebView in its view. This makes the app more like a normal UIKit application.
2852         
2853         Move the WKWebView down 20px to avoid the status bar.
2854         
2855         Give the UIWindow a gray background so it's obvious where the window and view positioned.
2856
2857         Sorted the project file. Removed the link to UIKit which showed red, and wasn't necessary.
2858         
2859         Remove duplicate references to Launch.storyboard.
2860
2861         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2862         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Add license.
2863         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Add license.
2864         (-[AppDelegate applicationWillResignActive:]): Deleted.
2865         (-[AppDelegate applicationDidEnterBackground:]): Deleted.
2866         (-[AppDelegate applicationWillEnterForeground:]): Deleted.
2867         (-[AppDelegate applicationDidBecomeActive:]): Deleted.
2868         (-[AppDelegate applicationWillTerminate:]): Deleted.
2869         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2870         (WTR::viewRectForWindowRect):
2871         (WTR::PlatformWebView::PlatformWebView):
2872         (WTR::PlatformWebView::setWindowFrame):
2873
2874 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2875
2876         [iOS WK2] Use the simulated device's screen size, rather than a harcoded size
2877         https://bugs.webkit.org/show_bug.cgi?id=160748
2878
2879         Reviewed by Tim Horton.
2880         
2881         Use the main UIScreen's bounds for the window size if we're using a flexible viewport. This
2882         opens the door for tests using other device sizes.
2883
2884         * WebKitTestRunner/ios/TestControllerIOS.mm:
2885         (WTR::TestController::platformConfigureViewForTest):
2886
2887 2016-08-10  Simon Fraser  <simon.fraser@apple.com>
2888
2889         Sort the feature flags in the FEATURE_DEFINES lines
2890         https://bugs.webkit.org/show_bug.cgi?id=160742
2891
2892         Reviewed by Anders Carlsson.
2893         
2894         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2895
2896 2016-08-09  Simon Fraser  <simon.fraser@apple.com>
2897
2898         Logging and other minor improvements to iOS webkitpy
2899         https://bugs.webkit.org/show_bug.cgi?id=160722
2900
2901         Reviewed by Dan Bates.
2902
2903         Fix --debug-rwt-logging to log all the calls to simctl as well as device state information,
2904         to make it easier to debug launching issues.
2905
2906         Have reset_preferences() reset the device, rather than just nuking the data
2907         directory (which broke some versions of the simulator).
2908
2909         Make the Simulator.app launch in the background with open -g.
2910
2911         Wait for the simulator device to be in a known state in some more places.
2912
2913         * Scripts/webkitpy/port/ios.py:
2914         (IOSSimulatorPort.setup_test_run):
2915         (IOSSimulatorPort._quit_ios_simulator):
2916         (IOSSimulatorPort.clean_up_test_run):
2917         (IOSSimulatorPort.setup_environ_for_server):
2918         (IOSSimulatorPort.reset_preferences):
2919         * Scripts/webkitpy/xcode/simulator.py:
2920         (Device.create):
2921         (Device.delete):
2922         (Device):
2923         (Device.reset):
2924         (Simulator.wait_until_device_is_booted):
2925         (Simulator.wait_until_device_is_in_state):
2926         (Simulator):
2927         (Simulator.delete_device):
2928         (Simulator.reset_device):
2929         (Simulator.lookup_or_create_device):
2930
2931 2016-08-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2932
2933         [GTK][EFL] ALSA_CARD environment variable is not passed for layout tests.
2934         https://bugs.webkit.org/show_bug.cgi?id=160697
2935
2936         Reviewed by Antonio Gomes.
2937
2938         * Scripts/webkitpy/port/base.py:
2939         (Port.to.setup_environ_for_server): Add ALSA_CARD and sort the Linux
2940         list of environment variables to copy.
2941
2942 2016-08-09  George Ruan  <gruan@apple.com>
2943
2944         Implement functionality of media capture on iOS
2945         https://bugs.webkit.org/show_bug.cgi?id=158945
2946         <rdar://problem/26893343>
2947
2948         Reviewed by Tim Horton.
2949
2950         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Enable Media
2951         Capture feature on iOS.
2952
2953 2016-08-09  Saam Barati  <sbarati@apple.com>
2954
2955         Parser<LexerType>::parseFunctionInfo() has the wrong info about captured vars when a function is not cached.
2956         https://bugs.webkit.org/show_bug.cgi?id=160671
2957         <rdar://problem/27756112>
2958
2959         Reviewed by Mark Lam.
2960
2961         * Scripts/run-jsc-stress-tests:
2962
2963 2016-08-09  Alexey Proskuryakov  <ap@apple.com>
2964
2965         Make directory reading code in iOSSimulatorDevices() more strict
2966         https://bugs.webkit.org/show_bug.cgi?id=160702
2967
2968         Reviewed by Tim Horton.
2969
2970         * Scripts/webkitdirs.pm:
2971         (iOSSimulatorDevices):
2972
2973 2016-08-06  Sam Weinig  <sam@webkit.org>
2974
2975         Replace NodeOrString with std::variant<RefPtr<Node>, String>
2976         https://bugs.webkit.org/show_bug.cgi?id=160638
2977
2978         Reviewed by Anders Carlsson.
2979
2980         * TestWebKitAPI/CMakeLists.txt:
2981         * TestWebKitAPI/Tests/WTF/Variant.cpp:
2982         Add additional tests for the initial state of std::variant and using
2983         makeVisitor for visiting.
2984
2985 2016-08-09  Aakash Jain  <aakash_jain@apple.com>
2986
2987         EWS logging should ensure the logging to file is stopped on queue termination
2988         https://bugs.webkit.org/show_bug.cgi?id=160698
2989         rdar://problem/24464570
2990
2991         Reviewed by Daniel Bates.
2992
2993         * Scripts/webkitpy/tool/bot/queueengine.py:
2994         (QueueEngine._stopping): Stop logging to file on queue termination.
2995         (QueueEngine._begin_logging): Configure the Python logger to log to file.
2996         * Scripts/webkitpy/common/system/logutils.py:
2997         (configure_logger_to_log_to_file): Return the handler so as to enable caller to remove it later.
2998         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2999         (QueueEngineTest._run_engine): Removed extra newline character to improve log readability.
3000         * Scripts/webkitpy/tool/commands/queues.py:
3001         (AbstractQueue._log_directory): Reverting to os.path.join as we don't have host object.
3002         (AbstractQueue.queue_log_path): Same.
3003         (AbstractQueue.begin_work_queue): Removed logging initialization, it is now being done in QueueEngine.
3004         (AbstractQueue.__init__): Removed host parameter, not required anymore, it was required by logging initialization
3005         which moved to QueueEngine now.
3006         (PatchProcessingQueue.__init__): Same.
3007         (CommitQueue.__init__): Same.
3008         (AbstractReviewQueue.__init__): Same.
3009         (StyleQueue.__init__): Same.
3010         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3011         (TestCommitQueue): Removed host parameter.
3012         (TestCommitQueue.__init__): Same.
3013         (AbstractPatchQueueTest.test_next_patch): Same.
3014         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
3015         (test_commit_queue_failure): Same.
3016         (mock_run_webkit_patch):
3017         (MockCommitQueueTask.results_from_patch_test_run): Same.
3018         (test_rollout_lands): Same.
3019         (test_non_valid_patch): Same.
3020         (test_auto_retry): Same.
3021         (test_style_queue_with_watch_list_exception): Same.
3022         (TestQueue.__init__): Deleted.
3023         (TestReviewQueue.__init__): Deleted.
3024         (TestFeederQueue.__init__): Deleted.
3025
3026 2016-08-09  Konstantin Tokarev  <annulen@yandex.ru>
3027
3028         webkit-gtk tarball fails to build due to missing files
3029         https://bugs.webkit.org/show_bug.cgi?id=160684
3030
3031         Reviewed by Alex Christensen.
3032
3033         * gtk/manifest.txt.in: Added back spi directories.
3034
3035 2016-08-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3036
3037         [GTK] Build the jhbuild with -O2 optimization level by default
3038         https://bugs.webkit.org/show_bug.cgi?id=160544
3039
3040         Reviewed by Michael Catanzaro.
3041
3042         * gtk/jhbuildrc: Pass -O2 when building the JHBuild, as also -g1
3043         which don't increases the required disk space significatively and
3044         provides better debug information than no passing it.
3045
3046 2016-08-09  Csaba Osztrogonác  <ossy@webkit.org>
3047
3048         Allow more --cmakeargs option in build-jsc and build-webkit
3049         https://bugs.webkit.org/show_bug.cgi?id=160340
3050
3051         Reviewed by Michael Catanzaro.
3052
3053         * Scripts/build-jsc:
3054         * Scripts/build-webkit:
3055
3056 2016-08-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3057
3058         Do not check if WebKitLibraries folder exists on EFL and GTK
3059         https://bugs.webkit.org/show_bug.cgi?id=160659
3060
3061         Reviewed by Csaba Osztrogonác.
3062
3063         Though WebKitLibraries is only needed by mac and win ports,
3064         EFL and GTK ports have checked whether it exists.
3065
3066         * Scripts/build-webkit:
3067
3068 2016-08-08  Aakash Jain  <aakash_jain@apple.com>
3069
3070         Some EWS console logs doesn't go to log file
3071         https://bugs.webkit.org/show_bug.cgi?id=160585
3072         rdar://problem/24464570
3073
3074         Reviewed by Daniel Bates.
3075
3076         * Scripts/webkitpy/common/system/logutils.py:
3077         (FileSystemHandler._open): Ensure that we open logfile in append mode in order to avoid
3078         any possible overwriting.
3079         * Scripts/webkitpy/common/system/filesystem.py:
3080         (FileSystem.open_text_file_for_writing): Add should_append parameter to append to file.
3081         * Scripts/webkitpy/common/system/filesystem_mock.py:
3082         (MockFileSystem.open_text_file_for_writing): Same.
3083         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3084         (RealFileSystemTest.test_read_and_write_text_file): Removed unused variable 'hex_equivalent'.
3085         (RealFileSystemTest.test_append_to_text_file): Added new unit test for testing append functionality.
3086         * Scripts/webkitpy/tool/commands/queues.py:
3087         (AbstractQueue.begin_work_queue): Configure the logger for overall webkitpy to log to file.
3088         This will ensure that all the sub-modules inside webkitpy will log to file.
3089
3090 2016-08-08  Simon Fraser  <simon.fraser@apple.com>
3091
3092         Have the iOS platform interit from the Apple platform in webkitpy
3093         https://bugs.webkit.org/show_bug.cgi?id=160672
3094
3095         Reviewed by Dan Bates.
3096         
3097         The IOSSimulatorPort used to inherit from Port, rather than ApplePort.
3098         Fix this, and move duplicated code from IOSSimulatorPort and MacPort into
3099         ApplePort.
3100         
3101         Since WinPort also inherits from ApplePort, it needs to stub out some things
3102         that are unavailable on Windows (leaks, sampling).
3103         
3104         Some SnowLeopard-related code and the associated test were removed.
3105
3106         * Scripts/webkitpy/port/apple.py:
3107         (ApplePort.__init__):
3108         (ApplePort):
3109         (ApplePort._make_leak_detector):
3110         (ApplePort.default_timeout_ms):
3111         (ApplePort.supports_per_test_timeout):
3112         (ApplePort.should_retry_crashes):
3113         (ApplePort._generate_all_test_configurations):
3114         (ApplePort.check_for_leaks):
3115         (ApplePort.print_leaks_summary):
3116         (ApplePort._path_to_webcore_library):
3117         (ApplePort.show_results_html_file):
3118         (ApplePort._merge_crash_logs):
3119         (ApplePort._look_for_all_crash_logs_in_log_dir):
3120         (ApplePort._get_crash_log):
3121         (ApplePort.look_for_new_crash_logs):
3122         (ApplePort.sample_process):
3123         (ApplePort.sample_file_path):
3124         (ApplePort.look_for_new_samples):
3125         (ApplePort._path_to_helper):
3126         (ApplePort.determine_full_port_name): Deleted.
3127         * Scripts/webkitpy/port/ios.py:
3128         (IOSSimulatorPort):
3129         (IOSSimulatorPort.__init__):
3130         (IOSSimulatorPort.default_timeout_ms): Deleted.
3131         (IOSSimulatorPort.supports_per_test_timeout): Deleted.
3132         (IOSSimulatorPort.should_retry_crashes): Deleted.
3133         (IOSSimulatorPort.check_for_leaks): Deleted.
3134         (IOSSimulatorPort.print_leaks_summary): Deleted.
3135         (IOSSimulatorPort._path_to_webcore_library): Deleted.
3136         (IOSSimulatorPort.show_results_html_file): Deleted.
3137         (IOSSimulatorPort.sample_file_path): Deleted.
3138         (IOSSimulatorPort._merge_crash_logs): Deleted.
3139         (IOSSimulatorPort._look_for_all_crash_logs_in_log_dir): Deleted.
3140         (IOSSimulatorPort.look_for_new_crash_logs): Deleted.
3141         (IOSSimulatorPort.look_for_new_samples): Deleted.
3142         (IOSSimulatorPort.sample_process): Deleted.
3143         (IOSSimulatorPort._path_to_helper): Deleted.
3144         (IOSSimulatorPort.make_command): Deleted.
3145         * Scripts/webkitpy/port/mac.py:
3146         (MacPort.__init__):
3147         (MacPort.make_command):
3148         (MacPort._build_java_test_support):
3149         (MacPort): Deleted.
3150         (MacPort.default_timeout_ms): Deleted.
3151         (MacPort.supports_per_test_timeout): Deleted.
3152         (MacPort.should_retry_crashes): Deleted.
3153         (MacPort.default_child_processes): Deleted.
3154         (MacPort.check_for_leaks): Deleted.
3155         (MacPort.print_leaks_summary): Deleted.
3156         (MacPort._path_to_webcore_library): Deleted.
3157         (MacPort.show_results_html_file): Deleted.
3158         (MacPort.sample_file_path): Deleted.
3159         (MacPort._merge_crash_logs): Deleted.
3160         (MacPort._look_for_all_crash_logs_in_log_dir): Deleted.
3161         (MacPort.look_for_new_crash_logs): Deleted.
3162         (MacPort.look_for_new_samples): Deleted.
3163         (MacPort.sample_process): Deleted.
3164         (MacPort._path_to_helper): Deleted.
3165         * Scripts/webkitpy/port/mac_unittest.py:
3166         (MacTest.test_default_child_processes): Deleted.
3167         * Scripts/webkitpy/port/win.py:
3168         (WinPort.look_for_new_samples):
3169         (WinPort):
3170         (WinPort.sample_process):
3171         (WinPort._make_leak_detector):
3172         (WinPort.check_for_leaks):
3173         (WinPort.print_leaks_summary):
3174         (WinPort._path_to_webcore_library):
3175
3176 2016-08-08  Matt Baker  <mattbaker@apple.com>
3177
3178         Unreviewed: moved myself to the reviewers list.
3179
3180         * Scripts/webkitpy/common/config/contributors.json:
3181
3182 2016-08-08  Chris Dumez  <cdumez@apple.com>
3183
3184         Update API tests in mac/SetDocumentURI.mm after r204247
3185         https://bugs.webkit.org/show_bug.cgi?id=160660
3186
3187         Reviewed by Alex Christensen.
3188
3189         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
3190         (TestWebKitAPI::TEST):
3191
3192 2016-08-08  Jonathan Bedard  <jbedard@apple.com>
3193
3194         run-webkit-tests should trigger a spindump when WebContent process is unresponsive
3195         https://bugs.webkit.org/show_bug.cgi?id=159827
3196
3197         Reviewed by Daniel Bates.
3198
3199         This change was spurred by a process hang which occurred between tests and did
3200         not produce a meaningful crashlog.
3201
3202         * Scripts/webkitpy/port/driver.py:
3203         (Driver._check_for_driver_crash_or_unresponsiveness): Notify test controller when finished through stdin.
3204
3205          * Scripts/webkitpy/port/ios.py:
3206         (IOSSimulatorPort):
3207         (IOSSimulatorPort.sample_process): Attempt spindump, but use sample if spindump fails.
3208         * Scripts/webkitpy/port/mac.py:
3209         (MacPort):
3210         (MacPort.sample_process): Attempt spindump, but use sample if spindump fails.
3211
3212         * Scripts/webkitpy/port/mac_unittest.py: Changed expected values to match spindump calls, added specific spindump test.
3213         * Scripts/webkitpy/port/driver_unittest.py: Added dummy write function.
3214
3215         * WebKitTestRunner/TestController.h:
3216         (WTR::TestController::usingServerMode): Added accessor for m_usingServerMode.
3217         * WebKitTestRunner/TestInvocation.cpp:
3218         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Wait for stdin before continuing when in server mode.
3219
3220 2016-08-07  Dan Bernstein  <mitz@apple.com>
3221
3222         [Cocoa] Reply block leaks if the remote object doesn’t call it
3223         https://bugs.webkit.org/show_bug.cgi?id=160642
3224
3225         Reviewed by Sam Weinig.
3226
3227         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h: Declared a new method.
3228         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
3229         (TEST): Added a test case that checks that the reply block is released even when it’s not
3230           called.
3231         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
3232         (-[RemoteObjectRegistryPlugIn doNotCallCompletionHandler:]): Implement new method by not
3233           calling the completion handler.
3234
3235 2016-08-07  Chris Dumez  <cdumez@apple.com>
3236
3237         Write API test to cover crash fix in r204135
3238         https://bugs.webkit.org/show_bug.cgi?id=160587
3239
3240         Reviewed by Darin Adler.
3241
3242         Add API test to cover crash fix in r204135. This reproduces the crash
3243         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
3244         callback.
3245
3246         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3247         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
3248         (TEST):
3249
3250 2016-08-06  Chris Dumez  <cdumez@apple.com>
3251
3252         Unreviewed, rolling out r204226.
3253
3254         Broke some API tests
3255
3256         Reverted changeset:
3257
3258         "Write API test to cover crash fix in r204135"
3259         https://bugs.webkit.org/show_bug.cgi?id=160587
3260         http://trac.webkit.org/changeset/204226
3261
3262 2016-08-06  Aakash Jain  <aakash_jain@apple.com>
3263
3264         EWS Style Queue fails to process patches which fails validation
3265         https://bugs.webkit.org/show_bug.cgi?id=160632
3266
3267         Reviewed by Alexey Proskuryakov.
3268
3269         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3270         (StyleQueueTask.validate): Add more information about validation failure.
3271         (StyleQueueTask.run): Pass the error details in the PatchIsNotValid exception.
3272         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3273         (test_non_valid_patch): Add a unit test to test the above code path.
3274
3275 2016-08-06  Sam Weinig  <sam@webkit.org>
3276
3277         WTF needs a variant implementation
3278         https://bugs.webkit.org/show_bug.cgi?id=160618
3279
3280         Reviewed by Darin Adler.
3281
3282         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3283         * TestWebKitAPI/Tests/WTF/Variant.cpp: Added.
3284         Add tests for the variant implementation.
3285
3286 2016-08-06  Chris Dumez  <cdumez@apple.com>
3287
3288         Write API test to cover crash fix in r204135
3289         https://bugs.webkit.org/show_bug.cgi?id=160587
3290
3291         Reviewed by Darin Adler.
3292
3293         Add API test to cover crash fix in r204135. This reproduces the crash
3294         by destroying a related WKWebView in the webViewWebContentProcessDidTerminate
3295         callback.
3296
3297         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
3298         (-[NavigationDelegate webViewWebContentProcessDidTerminate:]):
3299         (TEST):
3300
3301 2016-08-05  Tim Horton  <timothy_horton@apple.com>
3302
3303         run-api-tests should use a headed simulator
3304         https://bugs.webkit.org/show_bug.cgi?id=160611
3305
3306         Reviewed by Sam Weinig.
3307
3308         CADisplayLink doesn't work in a headless simulator, but is
3309         vital for the proper functioning of WebKit2 painting on iOS.
3310         So, we should not use a headless simulator.
3311
3312         * Scripts/run-api-tests:
3313         Launch a simulator app, don't just boot the simulator.
3314
3315         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3316         Re-enable a test that works now.
3317
3318 2016-08-05  Dan Bernstein  <mitz@apple.com>
3319
3320         [Cocoa] WKRemoteObjectCoder doesn’t handle NSRange
3321         https://bugs.webkit.org/show_bug.cgi?id=160589
3322
3323         Reviewed by Tim Horton.
3324
3325         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:
3326         (remoteObjectInterface): Fixed a mistake in the set of allowed classes in one of the reply
3327           blocks, which wasn’t caught because the test wasn’t run correctly.
3328         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:
3329         (TEST): Fixed the -selectionAndClickInformationForClickAtPoint:completionHandler: test, and
3330           added a test that sends over an NSRange.
3331         * TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:
3332         (-[RemoteObjectRegistryPlugIn takeRange:completionHandler:]): Added. Calls the completion
3333           handler with the range‘s location and length.
3334
3335 2016-08-05  Enrica Casucci  <enrica@apple.com>
3336
3337         Fixing tests failing after r204175.
3338
3339         Unreviewed.
3340
3341         * TestWebKitAPI/Configurations/WebProcessPlugIn.xcconfig:
3342
3343 2016-08-05  Enrica Casucci  <enrica@apple.com>
3344
3345         Build fix after 204053.
3346
3347         Unreviewed.
3348
3349         * TestWebKitAPI/Configurations/Base.xcconfig:
3350         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
3351         (-[MockContentFilterEnabler initWithCoder:]):
3352         (-[MockContentFilterEnabler dealloc]):
3353
3354 2016-08-05  Konstantin Tokarev  <annulen@yandex.ru>
3355
3356         Print test name in "Last character read from DRT..." error message.
3357         https://bugs.webkit.org/show_bug.cgi?id=160559
3358
3359         Reviewed by Michael Catanzaro.
3360
3361         * Scripts/webkitpy/port/driver.py:
3362         (Driver.run_test):
3363         (Driver._read_first_block):
3364         (Driver._read_optional_image_block):
3365         (Driver._read_block):
3366         * Scripts/webkitpy/port/driver_unittest.py:
3367         (DriverTest.test_read_block):
3368         (DriverTest.test_read_binary_block):
3369         (DriverTest.test_read_base64_block):
3370
3371 2016-08-05  Commit Queue  <commit-queue@webkit.org>
3372
3373         Unreviewed, rolling out r204123.
3374         https://bugs.webkit.org/show_bug.cgi?id=160597
3375
3376         Caused layout test timeouts on Windows. (Requested by perarne
3377         on #webkit).
3378
3379         Reverted changeset:
3380
3381         "[Win] Unable to reliably run tests in parallel"
3382         https://bugs.webkit.org/show_bug.cgi?id=140914
3383         http://trac.webkit.org/changeset/204123
3384
3385 2016-08-04  Saam Barati  <sbarati@apple.com>
3386
3387         Restore CodeBlock jettison code to jettison when a CodeBlock has been alive for a long time
3388         https://bugs.webkit.org/show_bug.cgi?id=151241
3389
3390         Reviewed by Benjamin Poulain.
3391
3392         * Scripts/run-jsc-stress-tests:
3393
3394 2016-08-04  Dean Johnson  <dean_johnson@apple.com>
3395
3396         UI improvements to Flakiness Dashboard.
3397         https://bugs.webkit.org/show_bug.cgi?id=153295
3398
3399         Reviewed by Alexey Proskuryakov.
3400
3401         * TestResultServer/static-dashboards/flakiness_dashboard.css:
3402         (td.options-container): Center text in most fields.
3403         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3404         (createBugHTML): Text/Grammar updates.
3405         (tableHeaders): Ditto.
3406         (htmlForSingleTestRow): Ditto.
3407         (headerForTestTableHtml): Ditto.
3408         * TestResultServer/static-dashboards/ui.js: Removed the "Group: " and "Test type: " headings.
3409         (ui.html.testTypeSwitcher): Deleted. Removes the "Group:" heading.
3410
3411 2016-08-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3412
3413         [GTK] install-dependencies script misses libxslt as build-dependency and some python libs for the run-benchmark script
3414         https://bugs.webkit.org/show_bug.cgi?id=160518
3415
3416         Reviewed by Michael Catanzaro.
3417
3418         * Scripts/webkitpy/thirdparty/__init__.py:
3419         (AutoinstallImportHook._install_twisted): Twisted requires zope.interface.
3420         * gtk/install-dependencies:
3421
3422 2016-08-04  Alexey Proskuryakov  <ap@apple.com>
3423
3424         Optimize bot watcher's dashboard a little
3425         https://bugs.webkit.org/show_bug.cgi?id=160515
3426         rdar://problem/26096900
3427
3428         Reviewed by Lucas Forschler.
3429
3430         Made re-sorting after loading an iteration more efficient.
3431
3432         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3433         (BuildbotIteration.prototype._updateWithData):
3434         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3435         (BuildbotQueue.prototype.updateIterationPosition):
3436
3437 2016-08-04  Per Arne Vollan  <pvollan@apple.com>
3438
3439         [Win] Unable to reliably run tests in parallel
3440         https://bugs.webkit.org/show_bug.cgi?id=140914
3441
3442         Reviewed by Brent Fulgham.
3443
3444         The cygpath utility function can fail badly when running with multiple DumpRenderTree
3445         processes. We can use string replacement to convert the Cygwin path to a Windows path
3446         instead.
3447  
3448         * Scripts/webkitpy/common/system/path.py:
3449         (cygpathFast):
3450         * Scripts/webkitpy/port/driver.py:
3451         (Driver._command_from_driver_input):
3452
3453 2016-08-03  Aakash Jain  <aakash_jain@apple.com>
3454
3455         Document instructions for increasing process and file limits
3456         https://bugs.webkit.org/show_bug.cgi?id=160528
3457         rdar://problem/24777576
3458
3459         Reviewed by Alexey Proskuryakov.
3460
3461         * Scripts/webkitpy/port/ios.py:
3462         (IOSSimulatorPort.default_child_processes):
3463
3464 2016-08-03  Anders Carlsson  <andersca@apple.com>
3465
3466         Remove the Objective-C bindings generator
3467         https://bugs.webkit.org/show_bug.cgi?id=160526
3468
3469         Reviewed by Sam Weinig.
3470
3471         * Scripts/run-bindings-tests:
3472         Update test.
3473
3474 2016-08-03  Tim Horton  <timothy_horton@apple.com>
3475
3476         Revise a TestWebKitAPI comment to mention the actual underlying problem
3477
3478         * TestWebKitAPI/Tests/WebKit2Cocoa/AnimatedResize.mm:
3479         Note that this is because of https://bugs.webkit.org/show_bug.cgi?id=160516
3480
3481 2016-08-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3482
3483         Benchmark test content-animation timeouts always
3484         https://bugs.webkit.org/show_bug.cgi?id=160057
3485
3486         Reviewed by Simon Fraser.
3487
3488         * Scripts/webkitpy/benchmark_runner/data/plans/Skipped: Added.
3489         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
3490         (start):
3491
3492 2016-08-02  Nan Wang  <n_wang@apple.com>
3493
3494         AX: Simulated touch events are not working on iOS
3495         https://bugs.webkit.org/show_bug.cgi?id=160395
3496         <rdar://problem/27633597>
3497
3498         Reviewed by Chris Fleizach.
3499
3500         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3501         (WTR::AccessibilityUIElement::press):
3502         (WTR::AccessibilityUIElement::setSelectedChild):
3503
3504 2016-08-02  Filip Pizlo  <fpizlo@apple.com>
3505
3506         run-javascriptcore-tests should accept multiple --extra-tests
3507         https://bugs.webkit.org/show_bug.cgi?id=160486
3508
3509         Reviewed by Saam Barati.
3510         
3511         We want to be able to pass --extra-tests multiple times, to supply an arbitrary number of extra
3512         test suites. This does it by using GetOpt::Long's array support.
3513
3514         * Scripts/run-javascriptcore-tests:
3515         (runJSCStressTests):
3516
3517 2016-08-02  Enrica Casucci  <enrica@apple.com>
3518
3519         Allow building with content filtering disabled.
3520         https://bugs.webkit.org/show_bug.cgi?id=160454
3521
3522         Reviewed by Simon Fraser.
3523
3524         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3525
3526 2016-08-02  Brady Eidson  <beidson@apple.com>
3527
3528         Removing IndexedDB WebsiteData can fail for some users.
3529         https://bugs.webkit.org/show_bug.cgi?id=160463
3530
3531         Reviewed by Alex Christensen.
3532
3533         * TestWebKitAPI/Tests/WebKit2Cocoa/StoreBlobThenDelete.mm:
3534
3535 2016-08-01  Alex Christensen  <achristensen@webkit.org>
3536
3537         _WKDownloadDelegate.didReceiveResponse should be called before decideDestinationWithSuggestedFilename
3538         https://bugs.webkit.org/show_bug.cgi?id=160437
3539         <rdar://problem/27578272>
3540
3541         Reviewed by Brady Eidson.
3542
3543         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3544         (-[DownloadDelegate _download:didReceiveResponse:]):
3545         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
3546         (runTest):
3547         Add a boolean to make sure that didReceiveResponse is called before decideDestinationWithSuggestedFilename.
3548
3549 2016-08-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3550
3551         [Tools] The GDB backtrace report tool don't checks the gdb return code.
3552         https://bugs.webkit.org/show_bug.cgi?id=160414
3553
3554         Reviewed by Michael Catanzaro.
3555
3556         * Scripts/webkitpy/port/linux_get_crash_log.py:
3557         (GDBCrashLogGenerator._wait_for_corefile):
3558
3559 2016-08-01  Youenn Fablet  <youenn@apple.com>
3560
3561         Make wpt server generate its certificates in layout test results folder
3562         https://bugs.webkit.org/show_bug.cgi?id=160422
3563
3564         Reviewed by Chris Dumez.
3565
3566         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3567         (WebPlatformTestServer._copy_webkit_test_files): Setting certificate folder to layout tests results directory.
3568
3569 2016-08-01  Jonathan Bedard  <jbedard@apple.com>
3570
3571         Function Call on NULL Object
3572         https://bugs.webkit.org/show_bug.cgi?id=160325
3573
3574         Reviewed by Darin Adler.
3575
3576         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3577         (WTR::InjectedBundle::didReceiveMessageToPage): Changed removeAllWebNotificationPermissions() call to static function call.
3578         * WebKitTestRunner/InjectedBundle/TestRunner.h: Made all web-notification functions static.
3579
3580 2016-08-01  Keith Miller  <keith_miller@apple.com>
3581
3582         We should not keep the JavaScript tests inside the Source/JavaScriptCore/ directory.
3583         https://bugs.webkit.org/show_bug.cgi?id=160372
3584
3585         Rubber stamped by Geoffrey Garen.
3586
3587         This patch moves all the JavaScript tests from Source/JavaScriptCore/tests to
3588         a new top level directory, JSTests. Having the tests in the Source directory
3589         was both confusing an inconvenient for people that just want to checkout the
3590         source code of WebKit. Since there is no other obvious place to put all the
3591         JavaScript tests a new top level directory seemed the most sensible.
3592
3593         * Scripts/import-test262-tests:
3594         * Scripts/run-javascriptcore-tests:
3595         * Scripts/update-javascriptcore-test-res:
3596
3597 2016-07-31  Nan Wang  <n_wang@apple.com>
3598
3599         AX: Add a check for touch event listener on iOS accessibility object
3600         https://bugs.webkit.org/show_bug.cgi?id=160388
3601
3602         Reviewed by Chris Fleizach.
3603
3604         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3605         (AccessibilityUIElement::boolAttributeValue):
3606         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3607         (WTR::AccessibilityUIElement::boolAttributeValue):
3608
3609 2016-07-30  Manuel Rego Casasnovas  <rego@igalia.com>
3610
3611         Unreviewed: add myself to the reviewers list.
3612
3613         * Scripts/webkitpy/common/config/contributors.json:
3614
3615 2016-07-29  Alexey Proskuryakov  <ap@apple.com>
3616
3617         Undo r203939, and copy over a rule that clips the logos.
3618
3619         Sierra wasn't the only logo without transparency.
3620
3621         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png:
3622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png:
3623         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3624
3625 2016-07-29  Alan Sien Wei Hshieh  <hshieh@apple.com>