774e99ad34e4ff82b756c15f220b36be55d4f1ab
[WebKit-https.git] / Tools / ChangeLog
1 2014-10-21  Brent Fulgham  <bfulgham@apple.com>
2
3         [Win] Run DumpRenderTree using native controls, not SafariTheme.dll.
4         https://bugs.webkit.org/show_bug.cgi?id=137932
5
6         Reviewed by Simon Fraser.
7
8         This is the first step in moving over to native Windows rendering for our layout tests.
9         Once this change lands, approximately 300 tests will start failing on Windows. I will
10         rebaseline these changes against our test hardware and update this bug with the
11         commits related to that work.
12
13         * DumpRenderTree/win/DumpRenderTree.cpp:
14         (resetDefaultsToConsistentValues): Call 'setShouldPaintNativeControls(TRUE)' so that
15         we use native Windows drawing style.
16
17 2014-10-21  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
18
19         Fix FTL Native Inlining for EFL
20         https://bugs.webkit.org/show_bug.cgi?id=137774
21
22         Reviewed by Michael Saboff.
23
24         Added Clang as an optional module to jhbuild.
25
26         * efl/jhbuild.modules:
27
28 2014-10-20  Michael Catanzaro  <mcatanzaro@igalia.com>
29
30         Change the default TLS errors policy to WEBKIT_TLS_ERRORS_POLICY_FAIL
31         https://bugs.webkit.org/show_bug.cgi?id=137832
32
33         Reviewed by Carlos Garcia Campos.
34
35         Ensure each test sets the TLS errors policy that it really needs.
36         Have each test except testTLSErrorsPolicy stash and restore the original
37         TLS errors policy. Update testTLSErrorsPolicy to account for the new
38         default policy.
39
40         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
41         (testSSL):
42         (testInsecureContent):
43         (testTLSErrorsPolicy):
44         (testTLSErrorsRedirect):
45         (testTLSErrorsHTTPAuth):
46         (testLoadFailedWithTLSErrors):
47         (beforeAll):
48
49 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
50
51         Unreviewed. Unskip inspector server unit tests.
52
53         They should pass now.
54
55         * Scripts/run-gtk-tests:
56         (TestRunner):
57
58 2014-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
59
60         [GTK] Test TestWebKitAPI/WebKit2Gtk/TestInspectorServer fails
61         https://bugs.webkit.org/show_bug.cgi?id=132044
62
63         Reviewed by Brian Burg.
64
65         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
66         (openRemoteDebuggingSession): Remove trailing slash when
67         concatenating base inspector URL with the page, because the
68         inspector returns the relative paths with a leading slash.
69
70 2014-10-20  Tanay C  <tanay.c@samsung.com>
71
72         [EFL][WK2] Minibrowser : Add support for Case sensitive and word start search
73         https://bugs.webkit.org/show_bug.cgi?id=137023
74
75         Reviewed by Gyuyoung Kim.
76
77         * MiniBrowser/efl/main.c: Added functionality to support case sensitive and word start search
78         (search_box_show): Modified.
79         (search_box_hide): Modified.
80         (on_search_field_activated): Modified.
81         (on_search_backward_button_clicked): Modified.
82         (on_search_forward_button_clicked): Modified.
83         (on_search_case_option_changed): Added.
84         (on_search_word_start_option_changed): Added.
85         (window_create): Modified.
86
87 2014-10-20  Tanay C  <tanay.c@samsung.com>
88
89         [GTK][Minibrowser] Escape key does not hide the search box
90         https://bugs.webkit.org/show_bug.cgi?id=137734
91
92         Reviewed by Philippe Normand.
93
94         * MiniBrowser/gtk/BrowserWindow.c: Added the check to handle search box hide
95         (stopPageLoad): Modified.
96
97 2014-10-18  Antti Koivisto  <antti@apple.com>
98
99         REGRESSION (r173356): Safari can't install a profile, gets 'Download Failed error
100         https://bugs.webkit.org/show_bug.cgi?id=137855
101
102         Reviewed by Dan Bernstein.
103
104         Test and warn if the dumped response mime type differs from the platform response mime type.
105
106         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
107         (WTR::InjectedBundlePage::didReceiveResponseForResource):
108         (WTR::InjectedBundlePage::platformResponseMimeType):
109         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
110         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
111         (WTR::InjectedBundlePage::platformResponseMimeType):
112
113 2014-10-17  Joseph Pecoraro  <pecoraro@apple.com>
114
115         Remove run-inspector-perf-tests.py there is no PerformanceTests/inspector anymore
116         https://bugs.webkit.org/show_bug.cgi?id=137835
117
118         Reviewed by Andreas Kling.
119
120         * Scripts/run-inspector-perf-tests.py: Removed.
121         This script is stale, as PerformanceTests/inspector no longer exists.
122
123 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
124
125         Fix typo: should be ios-simulator-wk2, not ios-simulator_wk2.
126
127         * Scripts/webkitpy/port/ios.py:
128         (IOSSimulatorPort.default_baseline_search_path):
129
130 2014-10-17  Simon Fraser  <simon.fraser@apple.com>
131
132         [iOS] Simplify test fallback paths for iOS Simulator testing
133         https://bugs.webkit.org/show_bug.cgi?id=137830
134
135         Reviewed by Zalan Bujtas.
136         
137         Make the fallback paths be:
138             ios-simulator -> generic
139             ios-simulator-wk2->ios-simulator -> generic
140         
141         so don't include mac in the fallback path. Also remove the
142         version handling for simplicity.
143
144         * Scripts/webkitpy/port/ios.py:
145         (IOSSimulatorPort):
146         (IOSSimulatorPort.default_baseline_search_path):
147
148 2014-10-17  Dana Burkart  <dburkart@apple.com>
149
150         Fix typos in the dashboard config file.
151
152         Unreviewed.
153
154         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
155         (WebKitBuildbot):
156
157 2014-10-17  Brent Fulgham  <bfulgham@apple.com>
158
159         [Win] Allow WinLauncher to specify Custom User Agent strings
160         https://bugs.webkit.org/show_bug.cgi?id=137828
161
162         Reviewed by Dean Jackson.
163
164         * WinLauncher/Common.cpp: Add support for custom user agent strings.
165         * WinLauncher/WinLauncher.cpp: Add some convenience methods to get
166         and set the user agent strings.
167         * WinLauncher/WinLauncher.h:
168         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc: Add new menu
169         resources and dialog for setting custom User Agent strings.
170         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
171
172 2014-10-16  Simon Fraser  <simon.fraser@apple.com>
173
174         [iOS] Turn off font autosizing for iOS WebKitTestRunner
175         https://bugs.webkit.org/show_bug.cgi?id=137806
176
177         Reviewed by Sam Weinig.
178
179         Confusingly, WKPreferencesSetTextAutosizingEnabled() does nothing on iOS.
180         Instead, we have to add WKPreferencesSetMinimumZoomFontSize() and set it to 0
181         to disable font autosizing.
182         
183         Add platformResetPreferencesToConsistentValues() and implement it in the iOS
184         test controller to set platform-specific prefs.
185
186         * WebKitTestRunner/TestController.cpp:
187         (WTR::TestController::resetPreferencesToConsistentValues):
188         (WTR::TestController::platformResetPreferencesToConsistentValues):
189         * WebKitTestRunner/TestController.h:
190         * WebKitTestRunner/ios/TestControllerIOS.mm:
191         (WTR::TestController::platformResetPreferencesToConsistentValues):
192         * WebKitTestRunner/mac/TestControllerMac.mm:
193         (WTR::TestController::platformResetPreferencesToConsistentValues):
194
195 2014-10-16  Dan Bernstein  <mitz@apple.com>
196
197         OSObjectPtr is missing leakRef()
198         https://bugs.webkit.org/show_bug.cgi?id=137798
199
200         Reviewed by Sam Weinig.
201
202         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp:
203         (TestWebKitAPI::TEST(OSObjectPtr, LeakRef)): Added.
204
205 2014-10-16  Lucas Forschler  <lforschler@apple.com>
206
207         Update target platform to remove Leopard, Snow Leopard, Lion.
208         Add Yosemite. 
209         
210         Unreviewed.
211
212         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
213         (_should_file_trigger_build):
214
215 2014-10-16  David Kilzer  <ddkilzer@apple.com>
216
217         commit-queue: fails to replace OO-PS! with reviewer name
218         <http://webkit.org/b/137795>
219
220         Reviewed by Alexey Proskuryakov.
221
222         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
223         (Bugzilla.fetch_bug_dictionary): Bugzilla 4.2.x never gives out
224         email addresses to unauthenticated page loads, so we must always
225         authenticate before getting bug data so we get full email
226         addresses.
227
228 2014-10-16  David Kilzer  <ddkilzer@apple.com>
229
230         commit-queue: fails to close bugs after successfully landing patches
231         <http://webkit.org/b/137794>
232
233         Reviewed by Alexey Proskuryakov.
234
235         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
236         (Bugzilla.clear_attachment_flags): Change 'nr=0' to 'nr=1' to
237         tell Mechanize to use the second <textarea> on the page with
238         name="comment".
239
240 2014-10-16  Brent Fulgham  <bfulgham@apple.com>
241
242         [Win] Update DRT to match Mac Logic
243         https://bugs.webkit.org/show_bug.cgi?id=137787
244
245         Reviewed by Dean Jackson.
246
247         * DumpRenderTree/win/DumpRenderTree.cpp:
248         (initialize): 0 -> nullptr
249         (runTest): Initialize MSG structure before using.
250         (main): Add CRT debug flags if building DRT with debug malloc on Windows.
251         Also, cleanly shut down COM when exiting.
252         * DumpRenderTree/win/FrameLoadDelegate.cpp:
253         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Move from
254         header and add printf to match Mac.
255         (FrameLoadDelegate::windowScriptObjectAvailable): Ditto.
256         * DumpRenderTree/win/FrameLoadDelegate.h:
257         (FrameLoadDelegate::didChangeLocationWithinPageForFrame): Deleted.
258         (FrameLoadDelegate::windowScriptObjectAvailable): Deleted.
259         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
260         (isLocalhost): Added.
261         (hostIsUsedBySomeTestsToGenerateError): Added.
262         (ResourceLoadDelegate::willSendRequest): Add logic to mimic Mac's use
263         of certain error and redirect host names.
264         * DumpRenderTree/win/UIDelegate.cpp:
265         (UIDelegate::runJavaScriptAlertPanelWithMessage): Use 'done' flag to decide if
266         anything should be output to the console. This modifies behavior to match the Mac.
267         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
268         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
269         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
270         (UIDelegate::webViewAddMessageToConsole): Ditto.
271         * WinLauncher/PageLoadTestClient.cpp:
272         (PageLoadTestClient::pageLoadEndedAtTime): Drive-by-fix for an assertion that I
273         added last week.
274
275 2014-10-16  Commit Queue  <commit-queue@webkit.org>
276
277         Unreviewed, rolling out r174754.
278         https://bugs.webkit.org/show_bug.cgi?id=137789
279
280         Speculative fix for Windows test was ineffective. (Requested
281         by rfong on #webkit).
282
283         Reverted changeset:
284
285         "[Windows] Add some more logging to debug Windows test
286         issues."
287         http://trac.webkit.org/changeset/174754
288
289 2014-10-15  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
290
291         Unreviewed, add myself to CoordinatedGraphics watchers.
292
293         * Scripts/webkitpy/common/config/watchlist:
294
295 2014-10-15  Roger Fong  <roger_fong@apple.com>
296
297         [Windows] Speculative Windows test fix.
298
299         * DumpRenderTree/win/DumpRenderTree.cpp: Make sure that OLEAUT32.dll doesn't cache BSTRs.
300
301 2014-10-15  Rebecca Hauck  <rhauck@adobe.com>
302
303         import-w3c-test rewrites relative src paths in ref files incorrectly
304         https://bugs.webkit.org/show_bug.cgi?id=137586
305
306         This patch fixes a bug in test_converter.py where src paths were getting 
307         rewritten as ../../some-path instead of <script src="../../some-path>". 
308         It also adds support for rewriting src paths in style  elements, which was 
309         missing before and it adds tests for this case.
310
311         Reviewed by Bem Jones-Bey.
312
313         * Scripts/webkitpy/w3c/test_converter.py:
314         (_W3CTestConverter.convert_attributes_if_needed):
315         * Scripts/webkitpy/w3c/test_converter_unittest.py:
316         (test_convert_attributes_if_needed):
317         (verify_reference_relative_paths):
318
319 2014-10-15  Jake Nielsen  <jacob_nielsen@apple.com>
320
321         Add --json flag to test-webkitpy to emit JSON formatted test results
322         to stdout
323         https://bugs.webkit.org/show_bug.cgi?id=137353
324
325         Reviewed by Daniel Bates.
326
327         * Scripts/webkitpy/port/server_process_unittest.py:
328         Adds the read method to MockFile to allow the stdout of test_webkitpy
329         to be redirected without causing erroneous test failures.
330         In particular,
331         webkitpy.port.server_process_unittest.TestServerProcess.test_broken_pipe
332         and
333         webkitpy.port.server_process_unittest.TestServerProcess.test_cleanup
334         because when redirecting to a file, the
335         _wait_for_data_and_update_buffers_using_select method in 
336         server_process.py will find that there is a read file descriptor in
337         its call to select.select, which eventually leads to it calling read()
338         on the MockFile object.
339         (MockFile.read):
340         * Scripts/webkitpy/test/main.py:
341         Adds the _print_results_as_json method and the --json flag which
342         determines whether _print_results_as_json will get called.
343         (Tester._parse_args):
344         (Tester._print_results_as_json):
345         (Tester._print_results_as_json.result_dict_from_tuple):
346         (Tester._run_tests):
347
348 2014-10-13  David Farler  <dfarler@apple.com>
349
350         [iOS] LayoutTestRelay: Detect broken pipe when reading simulator app's stdout and stderr.
351         https://bugs.webkit.org/show_bug.cgi?id=137662
352
353         Reviewed by Darin Adler.
354
355         The layout test harness can close LayoutTestRelay's subprocess
356         stdout and stderr in the case of a timeout or if a run is
357         cancelled and the FIFOs are cleaned up. If LayoutTestRelay
358         finds that no one is listening to its stdout/stderr (broken
359         pipe), then just exit(1), there is nothing to report.
360
361         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
362         (-[LTRelayController didReceiveStdoutData:]):
363         Add @try/@catch for NSFileHandleOperationException.
364         (-[LTRelayController didReceiveStderrData:]):
365         Add @try/@catch for NSFileHandleOperationException.
366
367 2014-10-15  Rohit Kumar  <kumar.rohit@samsung.com>
368
369         [GTK] Minibrowser : Add keyboard support for zoom in , zoom out and default zoom in GTK Minibrowser
370         https://bugs.webkit.org/show_bug.cgi?id=137060
371
372         Reviewed by Philippe Normand.
373
374         Add keyboard support for zoom in , zoom out and default zoom using 'Ctrl' + '+', 'Ctrl' + '-' and 'Ctrl' + '0' respectively.
375
376         * MiniBrowser/gtk/BrowserWindow.c:
377         (zoomInCallback):
378         (zoomOutCallback):
379         (defaultZoomCallback): Callback for default zoom keyboard support.
380         (browser_window_init):
381
382 2014-10-14  Simon Fraser  <simon.fraser@apple.com>
383
384         [Mac] DRT stderr logging after the test completes gets attributed to the next test
385
386         Reviewed by Alexey Proskuryakov.
387         
388         DRT would send "#EOF" to stderr just after doing so to stdout, which cause any later
389         logging to stderr to get associated with the next test.
390         
391         Fix by logging #EOF to stderr later, after we've completely finished with this test.
392
393         * DumpRenderTree/mac/DumpRenderTree.mm:
394         (dumpTestResults):
395         (runTest):
396
397 2014-10-14  Brent Fulgham  <bfulgham@apple.com>
398
399         [Win] Unreviewed gardening. Ignore Visual Studio *.sdf temporary files.
400
401         * DumpRenderTree/DumpRenderTree.vcxproj: Modified property svn:ignore.
402
403 2014-10-14  Csaba Osztrogonác  <ossy@webkit.org>
404
405         [cmake] Fix the make build after r174683
406         https://bugs.webkit.org/show_bug.cgi?id=137703
407
408         Reviewed by Martin Robinson.
409
410         * Scripts/webkitdirs.pm:
411         (buildCMakeGeneratedProject):
412
413 2014-10-14  Myles C. Maxfield  <mmaxfield@apple.com>
414
415         Adding myself to the watchlist to CachedFont
416
417         Unreviewed.
418
419         * Scripts/webkitpy/common/config/watchlist:
420
421 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
422
423         [EFL][GTK] Make it possible to get verbose output with ninja
424         https://bugs.webkit.org/show_bug.cgi?id=137606
425
426         Reviewed by Csaba Osztrogonác.
427
428         * Scripts/webkitdirs.pm:
429         (buildCMakeGeneratedProject):
430
431 2014-10-14  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
432
433         [EFL] Make it possible to use ninja for EFL build too
434         https://bugs.webkit.org/show_bug.cgi?id=137605
435
436         Reviewed by Csaba Osztrogonác.
437
438         * Scripts/webkitdirs.pm:
439         (generateBuildSystemFromCMakeProject):
440         * efl/install-dependencies:
441
442 2014-10-14  Rohit Kumar  <kumar.rohit@samsung.com>
443
444         [GTK] Minibrowser : Add home buton and keyboard support for home page load
445         https://bugs.webkit.org/show_bug.cgi?id=137486
446
447         Reviewed by Philippe Normand.
448
449         * MiniBrowser/gtk/BrowserWindow.c:
450         (loadHomePage): Callback for home page load.
451         (browser_window_init):
452         * MiniBrowser/gtk/BrowserWindow.h:
453         * MiniBrowser/gtk/main.c:
454         (main):
455
456 2014-10-14  Manuel Rego Casasnovas  <rego@igalia.com>
457
458         import-w3c-tests doesn't prefix property values
459         https://bugs.webkit.org/show_bug.cgi?id=137600
460
461         Reviewed by Bem Jones-Bey.
462
463         Some property values are prefixed in WebKit. Modified the W3C import
464         script in order to prefix property values and not only properties.
465         The patch re-uses most of the already existent logic to prefix
466         properties.
467
468         * Scripts/webkitpy/w3c/test_converter.py: Read prefixed property values
469         from CSSValueKeywords.in and adapt converter to modify both properties
470         and property values.
471         (convert_for_webkit):
472         (_W3CTestConverter.__init__):
473         (_W3CTestConverter.output):
474         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
475         (_W3CTestConverter):
476         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties_and_values):
477         (_W3CTestConverter.add_webkit_prefix_following_regex):
478         (_W3CTestConverter.convert_reference_relpaths):
479         (_W3CTestConverter.convert_style_data):
480         (_W3CTestConverter.convert_attributes_if_needed):
481         (_W3CTestConverter.add_webkit_prefix_to_unprefixed_properties): Deleted.
482         * Scripts/webkitpy/w3c/test_converter_unittest.py: Updated unit test to
483         include checks for property values too.
484         (W3CTestConverterTest.test_read_prefixed_property_list):
485         (verify_no_conversion_happened):
486         (verify_prefixed_properties):
487         (verify_prefixed_property_values):
488         (generate_test_content_properties_and_values):
489         (generate_test_content):
490         * Scripts/webkitpy/w3c/test_importer.py: Modified importer to manage
491         prefixed property values and inform about them.
492         (TestImporter.import_tests):
493         (TestImporter.write_import_log):
494
495 2014-10-13  Jer Noble  <jer.noble@apple.com>
496
497         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
498         https://bugs.webkit.org/show_bug.cgi?id=137533
499
500         Reviewed by Andy Estes.
501
502         Follow up patch; bail out of the test early (without failing) if the platform does not support MSE.
503
504         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
505         (TestWebKitAPI::isMSEEnabledCallback):
506         (TestWebKitAPI::TEST):
507
508 2014-10-13  Brent Fulgham  <bfulgham@apple.com>
509
510         [Win] Implement a page load profiling tool
511         https://bugs.webkit.org/show_bug.cgi?id=137673
512
513         Reviewed by Dean Jackson.
514
515         Add a tool to capture and summarize page load statistics.
516
517         * WinLauncher/Common.cpp:
518         (parseCommandLine): Move from WinMain.cpp so that it can
519         be shared with internal tools.
520         * WinLauncher/PageLoadTestClient.cpp: Added.
521         (PageLoadTestClient::PageLoadTestClient):
522         (PageLoadTestClient::pageLoadStartedAtTime):
523         (PageLoadTestClient::didStartProvisionalLoad):
524         (PageLoadTestClient::didCommitLoad):
525         (PageLoadTestClient::didFirstLayoutForMainFrame):
526         (PageLoadTestClient::didHandleOnLoadEvents):
527         (PageLoadTestClient::didFinishLoad):
528         (PageLoadTestClient::didFailLoad):
529         (PageLoadTestClient::didInitiateResourceLoad):
530         (PageLoadTestClient::didEndResourceLoad):
531         (PageLoadTestClient::pageLoadEndedAtTime):
532         (PageLoadTestClient::endPageLoad):
533         (PageLoadTestClient::clearPageLoadState):
534         (PageLoadTestClient::shouldConsiderPageLoadEnded):
535         (PageLoadTestClient::maybeEndPageLoadSoon):
536         (PageLoadTestClient::setPageURL):
537         (PageLoadTestClient::dumpRunStatistics):
538         * WinLauncher/PrintWebUIDelegate.cpp:
539         (PrintWebUIDelegate::createWebViewWithRequest): Handle
540         nullptr URL properly.
541         * WinLauncher/ResourceLoadDelegate.cpp: Added.
542         (ResourceLoadDelegate::QueryInterface):
543         (ResourceLoadDelegate::AddRef):
544         (ResourceLoadDelegate::Release):
545         (ResourceLoadDelegate::identifierForInitialRequest):
546         (ResourceLoadDelegate::willSendRequest):
547         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
548         (ResourceLoadDelegate::didCancelAuthenticationChallenge):
549         (ResourceLoadDelegate::didReceiveResponse):
550         (ResourceLoadDelegate::didReceiveContentLength):
551         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
552         (ResourceLoadDelegate::didFailLoadingWithError):
553         (ResourceLoadDelegate::plugInFailedWithError):
554         * WinLauncher/ResourceLoadDelegate.h: Added.
555         (ResourceLoadDelegate::ResourceLoadDelegate):
556         * WinLauncher/WinLauncher.cpp:
557         (WinLauncher::WinLauncher): Accept argument to indicate we want to capture
558         page loading statistics.
559         (WinLauncher::setFrameLoadDelegatePrivate): Get rid of stub implementation
560         and set private load delegate state.
561         (WinLauncher::setResourceLoadDelegate): Replace stub with a full implementation
562         that sets the view's resource load delegate.
563         (WinLauncher::loadURL): If no URL is passed, load the test document.
564         * WinLauncher/WinLauncher.h:
565         (WinLauncher::pageLoadTestClient):
566         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Updated for new source files.
567         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters: Ditto.
568         * WinLauncher/WinLauncherWebHost.cpp:
569         (WinLauncherWebHost::updateAddressBar): Hook into page load statistics routine.
570         (WinLauncherWebHost::loadURL): Moved 'SendMessage' call to its own method so that
571         it could be used from other source files.
572         (WinLauncherWebHost::didFinishLoadForFrame): Added overload to capture statistics.
573         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Ditto.
574         (WinLauncherWebHost::didFailLoadWithError): Ditto.
575         (WinLauncherWebHost::didHandleOnloadEventsForFrame): Ditto.
576         (WinLauncherWebHost::didFirstLayoutInFrame): Ditto.
577         (WinLauncherWebHost::didFinishDocumentLoadForFrame): Ditto.
578         (WinLauncherWebHost::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
579         (WinLauncherWebHost::didStartProvisionalLoadForFrame): Deleted.
580         * WinLauncher/WinLauncherWebHost.h:
581         * WinLauncher/WinMain.cpp:
582         (wWinMain): Create and use new delegates for gathering page load data.
583         * WinLauncher/stdafx.h: Need to add <wtf/Platform> include for various macros used in build.
584
585 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
586
587         Improve the test image diffs page
588         https://bugs.webkit.org/show_bug.cgi?id=137674
589
590         Reviewed by Alexey Proskuryakov.
591         
592         Don't treat the input file as a format string, otherwise we have to escape special
593         characters. Just do a couple of replaces.
594
595         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
596         (TestResultWriter.write_image_diff_files):
597
598 2014-10-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
599
600         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 21.
601         https://bugs.webkit.org/show_bug.cgi?id=137659
602
603         Reviewed by Martin Robinson.
604
605         * Scripts/webkitpy/port/xvfbdriver.py:
606         (XvfbDriver._next_free_display): Update the regular expression to also match Xorg.bin
607
608 2014-10-13  Alexey Proskuryakov  <ap@apple.com>
609
610         Add more detailed wait time information to EWS metrics
611         https://bugs.webkit.org/show_bug.cgi?id=137649
612
613         Reviewed by Daniel Bates.
614
615         Added average and worst time (we used to only have median), and also a percentage
616         of patches that took a non-trivial time to start. Non-trivial is defined as 3 minutes.
617
618         There is always some wait due to the polling nature of the queues, which is well understood
619         and doesn't need to be measured. What needs to be measured is whether there is enough
620         bot machines to process patches as soon as they are submitted.
621
622         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
623         (Analyzer.prototype._analyzeBubblePerformance):
624         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
625         (MetricsBubbleView.prototype._update):
626
627 2014-10-11  Jer Noble  <jer.noble@apple.com>
628
629         MediaPlayer::characteristicChanged() is not called when new tracks are found in SourceBufferPrivateAVFObjC
630         https://bugs.webkit.org/show_bug.cgi?id=137533
631
632         Reviewed by Darin Adler.
633
634         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
635         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
636         (TestWebKitAPI::TEST):
637         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html: Added.
638         * TestWebKitAPI/Tests/WebKit2/test-mse.mp4: Added.
639
640 2014-10-13  Simon Fraser  <simon.fraser@apple.com>
641
642         iOS DRT snapshots are limited to the page visible area
643         https://bugs.webkit.org/show_bug.cgi?id=137650
644
645         Reviewed by Daniel Bates.
646         
647         LegacyTileCache drawing was limited to the window's visible area, found by
648         crawling up the layer hierarchy to the root layer. This caused test snapshots to
649         be missing non-composited content outside the iPhone visible area, which hinders
650         testing.
651         
652         Fix by adding a test-only mode where the window visible area is the entire window.
653         
654         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
655         (dumpWebViewAsPixelsAndCompareWithExpected): Drive-by RetainPtr fix.
656         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
657         (-[DumpRenderTreeWindow initWithLayer:]): Call setEntireWindowVisibleForTesting:YES
658         for the DRT window.
659         
660
661 2014-10-12  Simon Fraser  <simon.fraser@apple.com>
662
663         Page not fully rendered in iOS DRT snapshots
664         https://bugs.webkit.org/show_bug.cgi?id=137638
665
666         Reviewed by Tim Horton.
667         
668         In iOS DumpRenderTree, we need to wait for a cycle of the WebThread runloop
669         to ensure that the page has laid out and is rendered by the time we take
670         the snapshot.
671
672         * DumpRenderTree/mac/DumpRenderTree.mm:
673         (-[DumpRenderTree _webThreadEventLoopHasRun]): Moved.
674         (-[DumpRenderTree _webThreadInvoked]): Moved.
675         (-[DumpRenderTree _waitForWebThreadThenDump]):
676         (dump): Use a performSelectorOnMainThread:withObject:waitUntilDone:NO to wait
677         for a cycle of the WebThrewd runloop. We can't just call _waitForWebThread because
678         that blocks on a delegate callback, and we can't dispatch_async because _waitForWebThread
679         relies on dispatch_async too, and the inner block won't complete until the outer block
680         has completed.
681         (dumpTestResults): Move the guts of dump() here.
682         (runTest): Whitespace.
683
684 2014-10-12  Alexey Proskuryakov  <ap@apple.com>
685
686         Adding svn:ignore so that .pyc files don't show up as new.
687
688         * Scripts/webkitpy/xcode: Added property svn:ignore.
689
690 2014-10-12  Ryuan Choi  <ryuan.choi@gmail.com>
691
692         [EFL] Introduce EWebKit_Extension
693         https://bugs.webkit.org/show_bug.cgi?id=134921
694
695         Reviewed by Gyuyoung Kim.
696
697         * MiniBrowser/efl/main.c: Added x option to test extension path.
698         (window_create):
699         (elm_main):
700         * Scripts/webkitpy/common/config/watchlist:
701         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
702         * Scripts/webkitpy/style/checker.py:
703         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
704
705 2014-10-11  Simon Fraser  <simon.fraser@apple.com>
706
707         After r174628 we send the test process a SIGTERM before the SIGKILL.
708
709         * Scripts/webkitpy/common/system/executive_unittest.py:
710         (ExecutiveTest.serial_test_kill_process):
711
712 2014-10-11  KwangHyuk Kim  <hyuki.kim@samsung.com>
713
714         [EFL] Enable WebP support.
715         https://bugs.webkit.org/show_bug.cgi?id=136156
716
717         Reviewed by Gyuyoung Kim.
718
719         Include libwebp-dev package to support WebP for WK2 Efl.
720
721         * efl/install-dependencies:
722
723 2014-10-11  Carlos Garcia Campos  <cgarcia@igalia.com>
724
725         [GLIB] Split GMainLoopSource moving thread safe implementation to its own class GThreadSafeMainLoopSource
726         https://bugs.webkit.org/show_bug.cgi?id=137485
727
728         Reviewed by Sergio Villar Senin.
729
730         Update GMainLoopSource tests. Most of the tests are now run twice,
731         first with a GMainLoopSource and then with a
732         GThreadSafeMainLoopSource, since both should have the same
733         behaviour. The threading test uses GThreadSafeMainLoopSource and
734         the delete on destroy test uses GMainLoopSource. The tests
735         themselves haven't changed, since there's no change in behaviour.
736
737         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
738         (TestWebKitAPI::GMainLoopSourceTest::source):
739         (TestWebKitAPI::basicRescheduling):
740         (TestWebKitAPI::TEST):
741         (TestWebKitAPI::reentrantRescheduling):
742         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
743         (TestWebKitAPI::basicDestroyCallbacks):
744         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
745         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
746
747 2014-10-10  Dana Burkart  <dburkart@apple.com>
748
749         Fix fat-fingered function name in git-add-reviewer.
750
751         Unreviewed.
752
753         * Scripts/git-add-reviewer:
754         (getConfigValue):
755
756 2014-10-10  David Farler  <dfarler@apple.com>
757
758         [iOS] LayoutTestRelay should ensure its DRT/WKTR dies when receiving kill/term signals
759         https://bugs.webkit.org/show_bug.cgi?id=137528
760
761         Reviewed by Simon Fraser.
762
763         Catch SIGINT and SIGTERM signals in the LayoutTestRelay
764         and SIGKILL the paired simulator app before exiting cleanly.
765
766         webkitpy only uses SIGKILL to kill processes which you cannot
767         catch. Send SIGTERM to the process and give it chance to do
768         its thing before sending SIGKILL. Sending a SIGKILL to an already
769         dead PID is safe.
770
771         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
772         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
773         (-[LTRelayController finish]):
774         * LayoutTestRelay/LayoutTestRelay/main.m:
775         (receivedSignal):
776         (main):
777
778 2014-10-10  David Farler  <dfarler@apple.com>
779
780         [iOS] LayoutTestRelay should detect EOF and properly signal underlying DRT/WKTR
781         https://bugs.webkit.org/show_bug.cgi?id=137527
782
783         Reviewed by Simon Fraser.
784
785         NSFileHandle doesn't notify of EOF in its readability handler.
786         Use a dispatch_source_t and an event handler that is called when reading is possible.
787         In the handler block, do a run-of-the-mill read(2) from standard input and
788         detect EOF in the usual way by checking that zero bytes were read.
789
790         Once an EOF is received, the FIFOs are disconnected, the simulator app
791         is killed, and the relay exits with status 0.
792
793         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
794         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]):
795         (-[LTRelayController didDisconnect]):
796         (-[LTRelayController didConnect]):
797         (-[LTRelayController launchApp]):
798         Rename "dispatchSource" to "simulatorAppExitDispatchSource" to prevent any
799         confusion with this new dispatch source, called "standardInputDispatchSource".
800         (-[LTRelayController finish]): Added.
801         (-[LTRelayController readFileHandle:]): Deleted.
802
803 2014-10-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
804
805         [EFL] Crash on facebook.com
806         https://bugs.webkit.org/show_bug.cgi?id=137562
807
808         Reviewed by Chris Dumez.
809
810         Crash occurs on the facebook.com when the webview is resized
811         after the <select> item is clicked but no item is chosen.
812         This crash is just caused by the reference of invalidated variable.
813         From the EwkView::closePopupMenu(), ewk_menu is just invalidated.
814         Therefore ewk_menu variable is not available anymore when on_popup_menu_hide()
815         on MiniBrowser is called.
816         As a result, just set ewk_menu to NULL in order to prevent crash condition.
817
818         * MiniBrowser/efl/main.c:
819         (on_popup_menu_hide):
820
821 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
822
823         A small wording change for clarity.
824
825         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js:
826         (MetricsBubbleView.prototype._update):
827
828 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
829
830         Dashboard metrics page should have EWS statistics
831         https://bugs.webkit.org/show_bug.cgi?id=137626
832
833         Reviewed by Ryosuke Niwa.
834
835         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js:
836         (BubbleQueue): Put shortName in the object, so that it's actually useful.
837
838         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
839         (BubbleQueueServer): Re-ordered queues to match bubble order.
840         (BubbleQueueServer.prototype.jsonProcessingTimesURL): Added URL for the new handler.
841         (BubbleQueueServer.prototype.loadProcessingTimes): Load the data from webkit-queues.
842
843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
844         Added analysis for bubble queues.
845
846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsBubbleView.js: Added.
847
848         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
849         (buildBubbleQueuesTable): Build the UI.
850
851         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/metrics.html:
852         Added JS sources to load.
853
854         * QueueStatusServer/app.yaml: To update app version.
855
856         * QueueStatusServer/handlers/processingtimesjson.py: Added.
857
858         * QueueStatusServer/main.py: Added a handler for processing-times-json.
859
860 2014-10-10  Alexey Proskuryakov  <ap@apple.com>
861
862         REGRESSION: Commit queue doesn't process rollouts
863         https://bugs.webkit.org/show_bug.cgi?id=137623
864
865         Reviewed by Tim Horton.
866
867         * QueueStatusServer/app.yaml:
868         * QueueStatusServer/handlers/updateworkitems.py:
869         (UpdateWorkItems._work_items_from_request):
870
871 2014-10-10  Simon Fraser  <simon.fraser@apple.com>
872
873         Fix syntax error after r174601.
874
875         * Scripts/run-javascriptcore-tests:
876
877 2014-10-10  Michael Saboff  <msaboff@apple.com>
878
879         Add ability to select tarfile name in run-jsc-stress-tests
880         https://bugs.webkit.org/show_bug.cgi?id=137614
881
882         Reviewed by Mark Hahnenberg.
883
884         Added optional file name argument to the --tarball option.  
885
886         * Scripts/run-javascriptcore-tests: Added "--" to terminate options so the first
887         extra test given after the options wont be used for the optional tarball file name.
888         * Scripts/run-jsc-stress-tests:
889
890 2014-10-10  Chris Dumez  <cdumez@apple.com>
891
892         Unreviewed, update my information in contributors.json
893
894         Use my preferred first name and update my expertise areas.
895
896         * Scripts/webkitpy/common/config/contributors.json:
897
898 2014-10-10  Adrien Destugues  <pulkomandy@gmail.com>
899
900         Fix perl scripts to run with env on Linux
901         https://bugs.webkit.org/show_bug.cgi?id=137601
902
903         Reviewed by Csaba Osztrogonác.
904
905         Use of arguments in #! is nonstandard and does not behave the same on
906         different systems. Linux would look for an executable named "perl -w" 
907         "use warnings;" does the same things in a more portable way.
908
909         * Scripts/commit-log-editor:
910         * Scripts/num-cpus:
911         * Scripts/prepare-ChangeLog:
912         * Scripts/run-launcher:
913         * Scripts/svn-create-patch:
914
915 2014-10-10  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
916
917         [jhbuild] We should be able to disable wiping on configuration change
918         https://bugs.webkit.org/show_bug.cgi?id=137446
919
920         Reviewed by Csaba Osztrogonác.
921
922         The default behaviour isn't changed, wiping on configuration change feature can be disabled with
923         setting JHBUILD_WIPE_ON_CHANGE=0 environment variable
924         or passing --no-wipe-on-change command line option.
925
926         * Scripts/update-webkit-libs-jhbuild:
927
928 2014-10-09  Andy Estes  <aestes@apple.com>
929
930         Teach webkitpy about OS X Yosemite
931         https://bugs.webkit.org/show_bug.cgi?id=137585
932
933         Reviewed by Simon Fraser.
934
935         * Scripts/webkitpy/common/system/platforminfo.py:
936         (PlatformInfo._determine_mac_version):
937         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
938         (TestPlatformInfo.test_os_version):
939         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
940         (TestExpectationParser):
941         * Scripts/webkitpy/port/builders.py:
942         * Scripts/webkitpy/port/mac.py:
943         (MacPort):
944         * Scripts/webkitpy/port/mac_unittest.py:
945         (test_versions):
946         (test_baseline_search_path):
947         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
948         (TestRebaselineTest.test_baseline_directory):
949         (TestRebaselineExpectations.test_rebaseline_expectations):
950
951 2014-10-09  Dana Burkart  <dburkart@apple.com>
952
953         Add Mac OS Yosemite dashboard support.
954
955         Rubber-stamped by Lucas Forschler.
956
957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite.png: Added.
958         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Yosemite@2x.png: Added.
959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
960         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
962
963 2014-10-08  Ryosuke Niwa  <rniwa@webkit.org>
964
965         Add Babak to contributors.json and add historical email addresses for some contributors
966         https://bugs.webkit.org/show_bug.cgi?id=137546
967
968         Reviewed by Christophe Dumez.
969
970         contributors.json is used to analyze historical commit data and change logs.
971
972         Add back historical email addresses for some contributors and also add Babak (Shafiei).
973
974         * Scripts/webkitpy/common/config/contributors.json:
975
976 2014-10-09  Lucas Forschler  <lforschler@apple.com>
977
978         Add Mac OS Yosemite webkit build infrastructure.
979         
980         This patch adds 15 bots to our build.webkit.org configuration.
981         We are matching the current Mavericks machines 1:1.
982         
983         This patch includes some minor spacing changes to the buildslaves section to make everything similar.
984         
985         Reviewed by Matt Hanson.
986
987         * BuildSlaveSupport/build.webkit.org-config/config.json:
988
989 2014-10-09  Dana Burkart  <dburkart@apple.com>
990
991         Don't use backticks when running commands, as we run into sh-related
992         interpolation issues. Also, fix our usage of system() to properly
993         retrieve the status code.
994         https://bugs.webkit.org/show_bug.cgi?id=137541
995
996         Reviewed by Darin Adler.
997
998         * Scripts/git-add-reviewer:
999         (interactive):
1000         (nonInteractive):
1001         (requireCleanWorkTree):
1002         (cherryPick):
1003         (commit):
1004         (addReviewerToFile):
1005         (head):
1006         (isAncestor):
1007         (toCommit):
1008         (changeLogsForCommit):
1009         (resetToCommit):
1010         (getConfigValue):
1011         (runCommandWithOutput):
1012
1013 2014-10-09  Tim Horton  <timothy_horton@apple.com>
1014
1015         Add a WebKit1 preference for selection services
1016         https://bugs.webkit.org/show_bug.cgi?id=137498
1017         <rdar://problem/18572699>
1018
1019         Reviewed by Simon Fraser.
1020
1021         * MiniBrowser/mac/WK1BrowserWindowController.m:
1022         (-[WK1BrowserWindowController awakeFromNib]):
1023         Turn on image and selection services in the Legacy WebKit MiniBrowser.
1024
1025 2014-10-09  Adrien Destugues  <pulkomandy@gmail.com>
1026
1027         Get the patch scripts running on Haiku
1028         https://bugs.webkit.org/show_bug.cgi?id=137559
1029
1030         Reviewed by Benjamin Poulain.
1031
1032         Use /usr/bin/env instead of hardcoding path to perl.
1033         Declare haiku platform in platforminfo.py to avoid check-webkit-style
1034         failure.
1035
1036         * Scripts/commit-log-editor:
1037         * Scripts/num-cpus:
1038         * Scripts/prepare-ChangeLog:
1039         * Scripts/run-launcher:
1040         * Scripts/svn-create-patch:
1041         * Scripts/webkitpy/common/system/platforminfo.py:
1042         (PlatformInfo._determine_os_name):
1043
1044 2014-10-08  Jake Nielsen  <jacob_nielsen@apple.com>
1045
1046         StyleQueue should throw a PatchIsNotValid exception to achieve
1047         consistency with CommitQueue and EWS
1048         https://bugs.webkit.org/show_bug.cgi?id=137500
1049
1050         Reviewed by Alexey Proskuryakov.
1051
1052         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
1053         Adds a call to validate() in run().
1054         (StyleQueueTask.run):
1055         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1056         Adds a return False in the patch is not valid exception statement.
1057         (AbstractEarlyWarningSystem.review_patch):
1058         * Scripts/webkitpy/tool/commands/queues.py:
1059         Adds a return False in the patch is not valid exception statement in
1060         commit queue, and adds an except statement to catch PatchIsNotValid
1061         exceptions in style queue.
1062         (CommitQueue.process_work_item):
1063         (StyleQueue.review_patch):
1064
1065 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1066
1067         Race condition with WebKitWebView:is-loading after starting page load
1068         https://bugs.webkit.org/show_bug.cgi?id=136692
1069
1070         Reviewed by Gustavo Noronha Silva.
1071
1072         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
1073         (loadChangedCallback): Only check is-loading is false when load
1074         has finished if the load didn't fail due to a cancellation.
1075         (loadFailedCallback): Only check is-loading is false if the load
1076         didn't fail due to a cancellation.
1077         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1078         (WebViewTest::loadURI): Check is-loading is true and active URI is
1079         the requested one rigth after requesting the load.
1080         (WebViewTest::loadHtml): Ditto.
1081         (WebViewTest::loadPlainText): Ditto.
1082         (WebViewTest::loadBytes): Ditto.
1083         (WebViewTest::loadRequest): Ditto.
1084         (WebViewTest::loadAlternateHTML): Ditto.
1085         (WebViewTest::goBack): Ditto.
1086         (WebViewTest::goForward): Ditto.
1087         (WebViewTest::goToBackForwardListItem): Ditto.
1088
1089 2014-10-08  Brent Fulgham  <bfulgham@apple.com>
1090
1091         [Win] Resolve various static analyzer warnings in Tools.
1092         https://bugs.webkit.org/show_bug.cgi?id=137534
1093
1094         Reviewed by Dean Jackson.
1095
1096         * DumpRenderTree/cg/ImageDiffCG.cpp:
1097         (main): User proper printf specifiers.
1098         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1099         (AccessibilityUIElement::childrenCount): Handle possibility that
1100         gcc_accChildCount returns with an error.
1101         (accessibilityState): Ditto for gcc_accState.
1102         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1103         (DRTDesktopNotificationPresenter::showDesktopNotification): Use proper
1104         check for return value from 'isHTML'. HRESULT is not a boolean and cannot
1105         be treated as such.
1106         * DumpRenderTree/win/DumpRenderTree.cpp:
1107         (DumpRenderTreeWndProc): Avoid possible infinite loop on teardown caused
1108         by comparing an unsigned value as being greater-than zero.
1109         * DumpRenderTree/win/EditingDelegate.cpp:
1110         (dump): Pass proper character pointer type to printf.
1111         (EditingDelegate::shouldBeginEditingInDOMRange): Ditto.
1112         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
1113         (EditingDelegate::shouldInsertNode): Ditto.
1114         (EditingDelegate::shouldInsertText): Ditto.
1115         (EditingDelegate::shouldDeleteDOMRange): Ditto.
1116         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
1117         (EditingDelegate::shouldApplyStyle): Ditto.
1118         * DumpRenderTree/win/EventSender.cpp:
1119         (beginDragWithFilesCallback): Handle possible error case for GlobalAlloc.
1120         * DumpRenderTree/win/EventSender.h: Add proper declaration for HRESULT to match
1121         system headers.
1122         * DumpRenderTree/win/PixelDumpSupportWin.cpp: Handle possible failure
1123         from CreateDIBSection.
1124         * DumpRenderTree/win/UIDelegate.cpp: Ensure proper type is passed to printf.
1125         * TestWebKitAPI/Tests/WTF/MediaTime.cpp: Get rid of workaround for NaN under
1126         older versions of MSVC we no longer support.
1127         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Use proper types and API
1128         for 64-bit builds.
1129         * TestWebKitAPI/TestsController.cpp: Use NeverDestroyed like a good citizen.
1130         * TestWebKitAPI/TestsController.h: Ditto.
1131         * WinLauncher/Common.cpp: Handle possible failure from GetModuleFileName.
1132         * WinLauncher/WinLauncher.cpp: Make order of operations explicit to avoid
1133         performing bitwise | before the comparison is done.
1134
1135 2014-10-08  Ada Chan  <adachan@apple.com>
1136
1137         Add a test for WKPageIsPlayingAudio().
1138         https://bugs.webkit.org/show_bug.cgi?id=137048
1139
1140         Reviewed by Darin Adler.
1141
1142         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1143         Add file-with-video.html, test.mp4, and WKPageIsPlayingAudio.cpp to the project.
1144         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp: Added.
1145         (TestWebKitAPI::nullJavaScriptCallback):
1146         (TestWebKitAPI::didFinishLoadForFrame):
1147         (TestWebKitAPI::isPlayingAudioDidChangeCallback):
1148         (TestWebKitAPI::setUpClients):
1149         (TestWebKitAPI::TEST):
1150         This test loads a page with a video in it. When the page is loaded, we first check that
1151         WKPageIsPlayingAudio() returns false for the page. Then we call a method to start the video.
1152         When the WKPageUIClient::isPlayingAudioDidChange callback gets called, check that WKPageIsPlayingAudio()
1153         now returns true for the page.
1154         * TestWebKitAPI/Tests/WebKit2/file-with-video.html: Added.
1155         * TestWebKitAPI/Tests/WebKit2/test.mp4: Added.
1156         This is a video copied from LayoutTests/media/content.
1157
1158 2014-10-08  Csaba Osztrogonác  <ossy@webkit.org>
1159
1160         [webkitpy] Use python-irclib-0.4.8.tar.gz instead of zip in AutoInstaller
1161         https://bugs.webkit.org/show_bug.cgi?id=137516
1162
1163         Reviewed by Alexey Proskuryakov.
1164
1165         * Scripts/webkitpy/thirdparty/__init__.py:
1166         (AutoinstallImportHook._install_irc):
1167
1168 2014-10-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1169
1170         [GTK] install-dependencies should install libjpeg-turbo on Debian and derivatives.
1171         https://bugs.webkit.org/show_bug.cgi?id=137520
1172
1173         Reviewed by Philippe Normand.
1174
1175         Debian is switching is default JPEG library to libjpeg-turbo <https://wiki.debian.org/LJTTransition#Text>
1176         For other distributions, we are already installing libjpeg-turbo.
1177         So, do the same for Debian and derivatives.
1178
1179         * gtk/install-dependencies: Install libjpeg-dev that depends on the default implementation of libjpeg.
1180
1181 2014-10-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1182
1183         [webkitpy] Add back the workaround to replace ZipFile.extractall()
1184         https://bugs.webkit.org/show_bug.cgi?id=137519
1185
1186         Reviewed by Csaba Osztrogonác.
1187
1188         It was removed by <http://trac.webkit.org/changeset/174266>,
1189         because the comment stated it is a workaround for buggy python
1190         2.6.1 which shipped on Snow Leopard. But it turned out the bug
1191         is still valid with python 2.7 shipped on the latest Ubuntu
1192         (12.04 and 14.04) and OS X 10.9.
1193
1194         * Scripts/webkitpy/common/system/autoinstall.py:
1195         (AutoInstaller):
1196         (AutoInstaller._extract_all):
1197         (AutoInstaller._unzip):
1198
1199 2014-10-08  Commit Queue  <commit-queue@webkit.org>
1200
1201         Unreviewed, rolling out r174335.
1202         https://bugs.webkit.org/show_bug.cgi?id=137515
1203
1204         It broke EFL layout test totally (Requested by gyuyoung on
1205         #webkit).
1206
1207         Reverted changeset:
1208
1209         "[EFL] Introduce EWebKit_Extension"
1210         https://bugs.webkit.org/show_bug.cgi?id=134921
1211         http://trac.webkit.org/changeset/174335
1212
1213 2014-10-08  Carlos Garcia Campos  <cgarcia@igalia.com>
1214
1215         [GTK] Make forwarding headers generation depend on source code
1216         https://bugs.webkit.org/show_bug.cgi?id=137394
1217
1218         Reviewed by Philippe Normand.
1219
1220         * TestWebKitAPI/CMakeLists.txt: Add missing dependency rule.
1221         * TestWebKitAPI/PlatformGTK.cmake: Only run
1222         generate-forwarding-headers.pl when source code changes.
1223         * WebKitTestRunner/PlatformGTK.cmake: Ditto.
1224
1225 2014-10-07  Tanay C  <tanay.c@samsung.com>
1226
1227         Remove build warnings in Hashmap API tests
1228         https://bugs.webkit.org/show_bug.cgi?id=137484
1229
1230         Reviewed by Darin Adler.
1231
1232         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1233         (TestWebKitAPI::TEST): Changed EXPECT_EQ(false, addResult.isNewEntry) to EXPECT_FALSE(addResult.isNewEntry) 
1234
1235 2014-10-07  Jake Nielsen  <jacob_nielsen@apple.com>
1236
1237         Commit queue doesn't drop obsolete patches sometimes
1238         https://bugs.webkit.org/show_bug.cgi?id=137460
1239
1240         Reviewed by Alexey Proskuryakov.
1241
1242         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1243         Adds another test patch for use in queues_unittest.py.
1244         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1245         (MockBugzilla):
1246         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1247         Raises a PatchIsNotValid exception in the case of validate() returning
1248         false.
1249         (CommitQueueTask.run):
1250         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
1251         Raises a PatchIsNotValid exception in the case of validate() returning
1252         false.
1253         (EarlyWarningSystemTask.run):
1254         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1255         Defines PatchIsNotValid exception. 
1256         (PatchIsNotValid):
1257         (PatchIsNotValid.__init__):
1258         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1259         Remove call to validate() and instead catches the PatchIsNotValid
1260         exception.
1261         (AbstractEarlyWarningSystem.review_patch):
1262         * Scripts/webkitpy/tool/commands/queues.py:
1263         Adds logic to catch the PatchIsNotValid exception.
1264         (CommitQueue.process_work_item):
1265         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1266         Adds the test_non_valid_patch test to ensure that invalid patches are
1267         handled properly, and don't just result in indefinite spinning.
1268         courtesy of Csaba Osztrogonác <ossy@webkit.org>
1269         (test_non_valid_patch):
1270
1271 2014-10-07  Daniel Bates  <dabates@apple.com>
1272
1273         [iOS] Teach run-webkit-tests to honor TestExpectation file for iOS Simulator 64-bit builds
1274         https://bugs.webkit.org/show_bug.cgi?id=137499
1275
1276         Reviewed by Simon Fraser.
1277
1278         Fixes an issue where the TestExpectation file for the iOS Simulator platform was only
1279         honored when running run-webkit-tests with a 32-bit simulator build of iOS WebKit. We
1280         should honor the TestExpectation file for the iOS Simulator platform for both 32- and 64-
1281         bit simulator builds of iOS WebKit.
1282
1283         * Scripts/webkitpy/port/ios.py:
1284         (IOSSimulatorPort._generate_all_test_configurations):
1285
1286 2014-10-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1287
1288         [GTK] jhbuild modules should build xserver with the --without-dtrace option.
1289         https://bugs.webkit.org/show_bug.cgi?id=137482
1290
1291         Reviewed by Martin Robinson.
1292
1293         * gtk/jhbuild.modules: Added --without-dtrace option to xserver jhbuild.modules config.
1294
1295 2014-10-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1296
1297         [SOUP] TLS errors should take precedence over HTTP authentication
1298         https://bugs.webkit.org/show_bug.cgi?id=137300
1299
1300         Reviewed by Sergio Villar Senin.
1301
1302         Add a test case to check that authenticate signal is not emitted
1303         in case of TLS errors, and the load fails instead.
1304
1305         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1306         (webViewAuthenticationCallback):
1307         (testTLSErrorsHTTPAuth):
1308         (httpsServerCallback):
1309         (beforeAll):
1310
1311 2014-10-06  Ryosuke Niwa  <rniwa@webkit.org>
1312
1313         Make webkit-patch find-users useful
1314         https://bugs.webkit.org/show_bug.cgi?id=137475
1315
1316         Reviewed by Alexey Proskuryakov.
1317
1318         Make find-users use the CommitterList instead of accessing Bugzilla.
1319
1320         This essentially exposes the same functionality as webkitbot's whois command.
1321
1322         * Scripts/webkitpy/tool/commands/findusers.py:
1323         (FindUsers.execute):
1324
1325 2014-10-06  Chris Fleizach  <cfleizach@apple.com>
1326
1327         AX: iOS8: Crash at -[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]
1328         https://bugs.webkit.org/show_bug.cgi?id=137289
1329
1330         Unreviewed build fix.
1331
1332         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1333         (AccessibilityUIElement::getChildrenWithRange):
1334
1335 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1336
1337         build.webkit.org/dashboard: Add commit queue
1338         https://bugs.webkit.org/show_bug.cgi?id=137462
1339
1340         Reviewed by Tim Horton.
1341
1342         Generalizes EWS into "bubble queue", which also includes commit queue and style queue.
1343         Style queue is still invisible, as it doesn't have an associated platform, and also
1344         we never have problems with it anyway, so it's not worth watching.
1345
1346         The UI now allows for adding more bots to the Other column (such as leaks bot).
1347         To make that actually happen, we'll need to refactor QueueView, allowing for multiple
1348         sources of data in a cell.
1349
1350         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueue.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js.
1351         (BubbleQueue):
1352         (BubbleQueue.prototype.get statusPageURL):
1353         (BubbleQueue.prototype.update):
1354         (BubbleQueue.prototype.loadDetailedStatus):
1355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js.
1356         (BubbleQueueServer):
1357         (BubbleQueueServer.prototype.jsonQueueLengthURL):
1358         (BubbleQueueServer.prototype.jsonQueueStatusURL):
1359         (BubbleQueueServer.prototype.queueStatusURL):
1360         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js.
1361         (BubbleQueueView):
1362         (BubbleQueueView.prototype.update.appendQueue):
1363         (BubbleQueueView.prototype.update):
1364         (BubbleQueueView.prototype._addQueueHeadingToPopover):
1365         (BubbleQueueView.prototype._popoverContentForBubbleQueue):
1366         (BubbleQueueView.prototype._presentPopoverForBubbleQueue):
1367         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js: Removed.
1368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js: Removed.
1369         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js: Removed.
1370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1371         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1372         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1373         (.bubble-server-popover .popover-queue-heading .queue-charts-link):
1374         (.bubble-server-popover .latest-status-no-link):
1375         (.bubble-server-popover .bot-status-description):
1376         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1377
1378         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
1379         (buildAggregateTable):
1380         (buildQueuesTable):
1381         Removed dysfunctional support for EWS for now. It will be different.
1382
1383 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1384
1385         One more case of incorrect comparison in recordpatchevent.py
1386         https://bugs.webkit.org/show_bug.cgi?id=137459
1387
1388         Reviewed by Tim Horton.
1389
1390         * QueueStatusServer/app.yaml:
1391         * QueueStatusServer/loggers/recordpatchevent.py:
1392         (RecordPatchEvent.started):
1393
1394 2014-10-06  Alexey Proskuryakov  <ap@apple.com>
1395
1396         webkit-queues PatchLog is incorrect for patches that took less than a second
1397         https://bugs.webkit.org/show_bug.cgi?id=137453
1398
1399         Reviewed by Tim Horton.
1400
1401         * QueueStatusServer/app.yaml: Updated app version.
1402
1403         * QueueStatusServer/loggers/recordpatchevent.py: (RecordPatchEvent.stopped):
1404         Don't bail out for patches that took 0 seconds to process (as frequently happens
1405         when a patch is obsolete).
1406
1407 2014-10-06  Csaba Osztrogonác  <ossy@webkit.org>
1408
1409         EWS bubble hover shows wrong timestamps
1410         https://bugs.webkit.org/show_bug.cgi?id=137252
1411
1412         Reviewed by Alexey Proskuryakov.
1413
1414         Add "Z" suffix to timestamps to make sure if it is handled as UTC time.
1415
1416         * QueueStatusServer/handlers/queuestatusjson.py:
1417         (QueueStatusJSON.get):
1418         * QueueStatusServer/handlers/statusbubble.py:
1419         (StatusBubble._iso_time):
1420
1421 2014-10-06  Mario Sanchez Prada  <mario@webkit.org>
1422
1423         Unreviewed, updated list of email addresses in contributors.json
1424
1425         * Scripts/webkitpy/common/config/contributors.json: Added my former
1426         email address in Igalia, for the sake of completeness.
1427
1428 2014-10-06  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1429
1430         Unreviewed, moved myself to the list of committers.
1431
1432         * Scripts/webkitpy/common/config/contributors.json:
1433
1434 2014-10-05  Ryuan Choi  <ryuan.choi@gmail.com>
1435
1436         [EFL] Introduce EWebKit_Extension
1437         https://bugs.webkit.org/show_bug.cgi?id=134921
1438
1439         Reviewed by Gyuyoung Kim.
1440
1441         * MiniBrowser/efl/main.c: Added x option to test extension path.
1442         (window_create):
1443         (elm_main):
1444         * Scripts/webkitpy/common/config/watchlist:
1445         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFLWebKit2PublicAPI.
1446         * Scripts/webkitpy/style/checker.py:
1447         Added Source/WebKit2/WebProcess/InjectedBundle/API/efl/ into EFL exceptions.
1448
1449 2014-10-04  Csaba Osztrogonác  <ossy@webkit.org>
1450
1451         [jhbuild] Simplify platform detection in update-webkit-libs-jhbuild
1452         https://bugs.webkit.org/show_bug.cgi?id=137390
1453
1454         Reviewed by Carlos Garcia Campos.
1455
1456         * Scripts/update-webkit-libs-jhbuild:
1457
1458 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1459
1460         [GTK] Do not generate webkit2gtk-tests-resources.gresource unconditionally
1461         https://bugs.webkit.org/show_bug.cgi?id=137391
1462
1463         Reviewed by Martin Robinson.
1464
1465         Add a custom command to only re-generate
1466         webkit2gtk-tests-resources.gresource when any of its dependencies changes.
1467
1468         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1469
1470 2014-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1471
1472         [GTK] generate-gtkdoc crashes when generating HTML due to encoding issues
1473         https://bugs.webkit.org/show_bug.cgi?id=135502
1474
1475         Reviewed by Martin Robinson.
1476
1477         When writing to stdout/stderr fails due to a UnicodeDecodeError
1478         exception, try again without encoding the output.
1479
1480         * gtk/gtkdoc.py:
1481         (GTKDoc._run_command):
1482
1483 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1484
1485         Bugzilla status bubble displays an exception showing attachment 175738
1486         https://bugs.webkit.org/show_bug.cgi?id=137410
1487
1488         Reviewed by Tim Horton.
1489
1490         * QueueStatusServer/app.yaml: Update version.
1491
1492         * QueueStatusServer/handlers/statusbubble.py: (StatusBubble._build_bubble):
1493         Don't fail even if expected status message is missing.
1494
1495         * QueueStatusServer/model/patchlog.py: (PatchLog): Quick unrelated fix - define
1496         the field in the same way it's defined in QueueStatus table.
1497
1498 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1499
1500         Record latest message in PatchLog for quick access
1501         https://bugs.webkit.org/show_bug.cgi?id=137405
1502
1503         Fixing a typo.
1504
1505         * QueueStatusServer/app.yaml:
1506         * QueueStatusServer/handlers/releasepatch.py:
1507
1508 2014-10-03  Alexey Proskuryakov  <ap@apple.com>
1509
1510         Record latest message in PatchLog for quick access
1511         https://bugs.webkit.org/show_bug.cgi?id=137405
1512
1513         Reviewed by Ryosuke Niwa.
1514
1515         It's no SQL...
1516
1517         * QueueStatusServer/handlers/releasepatch.py:
1518         * QueueStatusServer/handlers/updatestatus.py:
1519         * QueueStatusServer/loggers/recordpatchevent.py:
1520         * QueueStatusServer/model/patchlog.py:
1521
1522 2014-10-02  David Farler  <dfarler@apple.com>
1523
1524         -asan-blacklist option also renamed to generic -fsanitize-blacklist
1525         https://bugs.webkit.org/show_bug.cgi?id=137377
1526
1527         Reviewed by Daniel Bates.
1528
1529         * asan/asan.xcconfig:
1530         -asan-blacklist -> -fsanitize-blacklist
1531
1532         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1533
1534 2014-10-03  Roger Fong  <roger_fong@apple.com>
1535
1536         [Windows] Include batch size argument to layout tests on Windows.
1537
1538         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1539         (RunWebKitTests.start): 
1540         This is a speculative fix for the the inconsistent crashes we are seeing on Windows.
1541         These crashes seem to happen on random tests though generally in a spread out fashion.
1542         It seems possible that the DRT instance is being clobbered somehow after running too many
1543         tests in a row so we will try to mitigate this by just forcing DRT to restart periodically.
1544
1545 2014-10-03  Roger Fong  <roger_fong@apple.com>
1546
1547         [Windows] Settle for 2 chid processes running NRWT on Windows.
1548
1549         * Scripts/webkitpy/port/win.py:
1550         (WinPort.default_child_processes): 3 child processes reintroduces the sporadic crashing, will settle for 2.
1551
1552 2014-10-03  Akos Kiss  <akiss@inf.u-szeged.hu>
1553
1554         [GTK] Bump up and patch dependencies to allow building for aarch64
1555         https://bugs.webkit.org/show_bug.cgi?id=137147
1556
1557         Reviewed by Martin Robinson.
1558
1559         The currently used versions of pixman, libffi, librsvg, glib,
1560         glib-networking, fontconfig, libxml2, gst-plugins-base fail to configure
1561         and/or build for aarch64, so they are bumped up and patched where
1562         necessary. Wherever possible, the same versions and patches were used as
1563         for the EFL port bump-up
1564         (https://bugs.webkit.org/show_bug.cgi?id=135885).
1565
1566         After the bump-up, a hitherto hidden bug in gst-plugins-good caused a
1567         regression by crashing http/tests/media/video-redirect.html . A patch
1568         already in upstream fixes that bug.
1569
1570         This change does not touch xserver, which also needs bumping up, but 
1571         will be dealt with later.
1572
1573         * gtk/jhbuild.modules:
1574         Specified versions and patches necessary to correctly build for aarch64.
1575         * gtk/patches/gst-events-arent-gstobjects.patch:
1576         Added. Patches gst-plugins-good to fix a bug in .mov file demuxing.
1577         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch:
1578         Added. Patches gst-plugins-base to configure correctly for aarch64.
1579         * gtk/patches/librsvg-2.36.1-bump-up-config.guess-to-support-aarch64.patch:
1580         Added. Bumps up config.guess and config.sub in librsvg to recognize
1581         aarch64.
1582         * gtk/patches/libxml2-2.9.0-dtd.patch:
1583         Removed. Not necessary for libxml2 v2.9.1 anymore.
1584
1585 2014-09-28  Sam Weinig  <sam@webkit.org>
1586
1587         Remove RefPtrHashMap
1588         https://bugs.webkit.org/show_bug.cgi?id=137200
1589
1590         Reviewed by Darin Adler.
1591
1592         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
1593         (TestWebKitAPI::TEST):
1594         Add tests for using a HashMap with RefPtr keys, focusing on ensuring that
1595         a minimum of refcount churn occurs.
1596
1597 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1598
1599         Remove workarounds for versions of Python before 2.7
1600         https://bugs.webkit.org/show_bug.cgi?id=137338
1601
1602         Reviewed by Csaba Osztrogonác.
1603
1604         * Scripts/webkitpy/common/system/autoinstall.py:
1605         (AutoInstaller._extract_targz):
1606         (AutoInstaller._unzip):
1607         (AutoInstaller): Deleted.
1608         (AutoInstaller._extract_all): Deleted.
1609         * Scripts/webkitpy/common/webkitunittest.py:
1610         (TestCase.setUp): Deleted.
1611         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1612         (TestConfigurationConverter.collapse_macros):
1613         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1614         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1615         (TestConfigurationConverter):
1616         (TestConfigurationConverter.combinations): Deleted.
1617         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1618         * Scripts/webkitpy/port/base.py:
1619
1620 2014-10-03  Commit Queue  <commit-queue@webkit.org>
1621
1622         Unreviewed, rolling out r174264.
1623         https://bugs.webkit.org/show_bug.cgi?id=137392
1624
1625         It broke run-webkit-tests (Requested by ebalazsfalvi on
1626         #webkit).
1627
1628         Reverted changeset:
1629
1630         "Remove workarounds for versions of Python before 2.7"
1631         https://bugs.webkit.org/show_bug.cgi?id=137338
1632         http://trac.webkit.org/changeset/174264
1633
1634 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1635
1636         Remove workarounds for versions of Python before 2.7
1637         https://bugs.webkit.org/show_bug.cgi?id=137338
1638
1639         Reviewed by Csaba Osztrogonác.
1640
1641         * Scripts/webkitpy/common/system/autoinstall.py:
1642         (AutoInstaller._extract_targz):
1643         (AutoInstaller._unzip):
1644         (AutoInstaller): Deleted.
1645         (AutoInstaller._extract_all): Deleted.
1646         * Scripts/webkitpy/common/webkitunittest.py:
1647         (TestCase.setUp): Deleted.
1648         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1649         (TestConfigurationConverter.collapse_macros):
1650         (TestConfigurationConverter.to_specifiers_list.try_collapsing):
1651         (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
1652         (TestConfigurationConverter):
1653         (TestConfigurationConverter.combinations): Deleted.
1654         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1655         * Scripts/webkitpy/port/base.py:
1656         * Scripts/webkitpy/port/driver.py:
1657         (ContentBlock.__init__):
1658         * Scripts/webkitpy/port/server_process.py:
1659         (ServerProcess._reset):
1660
1661 2014-10-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1662
1663         Remove autoinstaller workaround for python 2.6
1664         https://bugs.webkit.org/show_bug.cgi?id=137343
1665
1666         Reviewed by Daniel Bates.
1667
1668         Reverting <http://trac.webkit.org/changeset/124928>, neither Python
1669         2.6, nor Snow Leopard is supported anymore, so the workaround is not
1670         needed anymore.
1671
1672         * Scripts/webkitpy/common/system/autoinstall.py:
1673         (AutoInstaller.install):
1674         * Scripts/webkitpy/test/main.py:
1675         (Tester._run_tests):
1676         * Scripts/webkitpy/thirdparty/__init__.py:
1677         (AutoinstallImportHook._install_mechanize):
1678         (AutoinstallImportHook._install_pep8):
1679         (AutoinstallImportHook._install_pylint):
1680         (AutoinstallImportHook._install_buildbot):
1681         (AutoinstallImportHook._install_coverage):
1682         (AutoinstallImportHook._install_eliza):
1683         (AutoinstallImportHook._install_irc):
1684         (AutoinstallImportHook._install):
1685         (autoinstall_everything):
1686
1687 2014-10-02  Daniel Bates  <dabates@apple.com>
1688
1689         Use version number 101000 instead of 10100 for OS X Yosemite
1690         https://bugs.webkit.org/show_bug.cgi?id=137372
1691
1692         Reviewed by Mark Rowe.
1693
1694         The version number for OS X Yosemite is 101000.
1695
1696         * DumpRenderTree/mac/TextInputController.m:
1697
1698 2014-10-02  Alexey Proskuryakov  <ap@apple.com>
1699
1700         update-work-items should never delete items
1701         https://bugs.webkit.org/show_bug.cgi?id=137366
1702
1703         Reviewed by Ryosuke Niwa.
1704
1705         As we don't just replace the whole list any more, indicate which items are high
1706         priority, and which are not. Hight priority ones will be prepended to the queue,
1707         others will be appended.
1708
1709         This creates a bit of unfairness in that high priority item queue becomes a LIFO.
1710         But hopefully we will never have many rollouts competing like that.
1711
1712         * QueueStatusServer/app.yaml: Update version.
1713
1714         * QueueStatusServer/handlers/updateworkitems.py: Never remove items. Pass high
1715         priority and regular items separately. Removed some error handling that used to
1716         end up in returning status 500 - an uncaught exception does that automatically.
1717
1718         * QueueStatusServer/main.py: Removed unnecessary regexps from URL matching code.
1719
1720         * QueueStatusServer/model/workitems.py: Added a way to add high priority items.
1721
1722         * QueueStatusServer/templates/updateworkitems.html: Added a field for high
1723         priority items.
1724
1725         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1726         (BugzillaQueries._parse_attachment_ids_request_query): Removed an annoying log
1727         line that complicated testing.
1728
1729         * Scripts/webkitpy/common/net/statusserver.py: Pass high priority items separately.
1730
1731         * Scripts/webkitpy/tool/bot/feeders.py: For commit queue, split high and regular
1732         priority items into separate lists.
1733
1734         * Scripts/webkitpy/common/net/statusserver_mock.py:
1735         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1736         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1737         Updated tests.
1738
1739 2014-10-02  Brendan Long  <b.long@cablelabs.com>
1740
1741         Annoying build warnings in WTFString API tests
1742         https://bugs.webkit.org/show_bug.cgi?id=137360
1743
1744         Reviewed by Darin Adler.
1745
1746         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
1747         (TestWebKitAPI::TEST): Change EXPECT_EQ(false, ok) to EXPECT_FALSE(ok) and EXPECT_EQ(true, ok) to EXPECT_TRUE(ok).
1748
1749 2014-10-02  Roger Fong  <roger_fong@apple.com>
1750
1751         [Windows] The number of processes did not affect the crash inconsistency, increase number of child processes again.
1752
1753         * Scripts/webkitpy/port/win.py:
1754         (WinPort.default_child_processes): Ambitiously try 3 processes the testers are too slow now.
1755
1756 2014-10-02  David Farler  <dfarler@apple.com>
1757
1758         Move ASan arguments from LLVM (-mllvm) to the frontend
1759         https://bugs.webkit.org/show_bug.cgi?id=137365
1760
1761         Reviewed by David Kilzer.
1762
1763         * asan/asan.xcconfig:
1764         Remove the -mllvm prefix to the asan-blacklist argument, moving it
1765         to the clang frontend.
1766
1767         http://llvm.org/viewvc/llvm-project?view=revision&revision=212505
1768
1769 2014-10-02  Commit Queue  <commit-queue@webkit.org>
1770
1771         Unreviewed, rolling out r174120.
1772         https://bugs.webkit.org/show_bug.cgi?id=137350
1773
1774         While number of failures is reasonable with 2 processes, test
1775         results seem to be inconsistent between runs (Requested by
1776         rfong on #webkit).
1777
1778         Reverted changeset:
1779
1780         "[Windows] Back to 2 child processes for NRWT on Windows."
1781         http://trac.webkit.org/changeset/174120
1782
1783 2014-10-02  Jeff Miller  <jeffm@apple.com>
1784
1785         DumpRenderTree and WebKitTestRunner should use WebKitystemInterfaceYosemite when building on Yosemite
1786         https://bugs.webkit.org/show_bug.cgi?id=137347
1787
1788         Reviewed by Dan Bernstein.
1789
1790         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1791         Use WebKitSystemInterfaceYosemite on OS X 10.10.
1792
1793         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1794         Ditto.
1795
1796 2014-10-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1797
1798         [GTK] [JHBuild] Switch sourceware.org mirror to http.
1799
1800         Unreviewed.
1801
1802         The ftp access is recently failing to work as expected, and the
1803         bots fail to download the file.
1804         The same mirror is available via http and seems to work better.
1805
1806         * gtk/jhbuild.modules:
1807
1808 2014-10-01  Commit Queue  <commit-queue@webkit.org>
1809
1810         Unreviewed, rolling out r174185.
1811         https://bugs.webkit.org/show_bug.cgi?id=137334
1812
1813         Patch that adds logging causes webkitpy failures (Requested by
1814         rfong on #webkit).
1815
1816         Reverted changeset:
1817
1818         "commitqueuetasks_unittest references a non-existent member
1819         variable"
1820         https://bugs.webkit.org/show_bug.cgi?id=137303
1821         http://trac.webkit.org/changeset/174185
1822
1823 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1824
1825         EWS and Commit Queue should know better than to spew 500 failed
1826         results in the case of extremely red patches.
1827         https://bugs.webkit.org/show_bug.cgi?id=137324
1828
1829         Reviewed by Alexey Proskuryakov.
1830
1831         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1832         Adds a check for did_exceed_test_failure_limit.
1833         (AbstractEarlyWarningSystem._failing_tests_message):
1834         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
1835         Alters the task mock to respond properly to
1836         results_from_patch_test_run(patch)
1837         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
1838         * Scripts/webkitpy/tool/commands/queues.py:
1839         Adds a check for did_exceed_test_failure_limit.
1840         (CommitQueue._failing_tests_message):
1841
1842 2014-10-01  Daniel Bates  <dabates@apple.com>
1843
1844         Unreviewed, rolling out r174192.
1845
1846         Revert the unit test fix in r174192 since we reverted r174187
1847         in r174194 due to correctness issues. See
1848         <http://webkit.org/b/137329> for more details.
1849
1850         Reverted changeset:
1851
1852         "Test fix after r174187"
1853         http://trac.webkit.org/changeset/174192
1854
1855 2014-10-01  Mark Rowe  <mrowe@apple.com>
1856
1857         <https://webkit.org/b/137308> WebKit should build on OS X Yosemite for external users
1858
1859         Reviewed by Dan Bernstein.
1860
1861         * Scripts/copy-webkitlibraries-to-product-directory: Copy libWebKitSystemInterfaceYosemite.a
1862         into the build directory. Use LLVMIncludesYosemite.tar.bz2 and LLVMLibrariesYosemite.tar.bz2
1863         for the LLVM components when on Yosemite.
1864
1865 2014-10-01  Commit Queue  <commit-queue@webkit.org>
1866
1867         Unreviewed, rolling out r174187.
1868         https://bugs.webkit.org/show_bug.cgi?id=137329
1869
1870         webkitpy failures, and thorton says the patch is wrong
1871         (Requested by dethbakin on #webkit).
1872
1873         Reverted changeset:
1874
1875         "[Windows] Increase layout test timeout for Windows following
1876         r174162."
1877         http://trac.webkit.org/changeset/174187
1878
1879 2014-10-01  Brent Fulgham  <bfulgham@apple.com>
1880
1881         Test fix after r174187
1882
1883         * Scripts/webkitpy/port/win_unittest.py:
1884         (WinPortTest.test_default_timeout_ms): Expect the new 50000 ms timeout for Windows tests.
1885
1886 2014-10-01  Roger Fong  <roger_fong@apple.com>
1887
1888         [Windows] Increase layout test timeout for Windows following r174162.
1889
1890         * Scripts/webkitpy/port/win.py:
1891         (WinPort.default_timeout_ms):
1892
1893 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1894
1895         commitqueuetasks_unittest references a non-existent member variable
1896         when mock-reporting flaky tests.
1897         https://bugs.webkit.org/show_bug.cgi?id=137303
1898
1899         Reviewed by Daniel Bates.
1900
1901         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1902         (MockCommitQueue.report_flaky_tests):
1903         Makes the appropriate name change.
1904         (test_simple_flaky_test_failure):
1905         Adds a unit test to make sure that the code is excercised.
1906
1907 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1908
1909         EWS is inconclusively spinning forever on a patch that breaks 500+
1910         tests
1911         https://bugs.webkit.org/show_bug.cgi?id=137223
1912
1913         Reviewed by Tim Horton.
1914
1915         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
1916         Checks to see whether the tests have exceeded the failure limit, and
1917         only spins off another test if they have not exceeded the limit.
1918         (PatchAnalysisTask._test_patch):
1919
1920 2014-10-01  Brian J. Burg  <burg@cs.washington.edu>
1921
1922         Unreviewed, add Katie Madonna as a contributor.
1923
1924         * Scripts/webkitpy/common/config/contributors.json:
1925
1926 2014-10-01  Jake Nielsen  <jacob_nielsen@apple.com>
1927
1928         commitqueuetasks_unittest does not construct FailingTestCommitQueue
1929         objects properly in its test cases.
1930         https://bugs.webkit.org/show_bug.cgi?id=137281
1931
1932         Reviewed by Daniel Bates.
1933
1934         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1935         (FailingTestCommitQueue.test_results):
1936         Adds an assert to make FailingTestCommitQueue harder to mis-use.
1937         (test_double_flaky_test_failure):
1938         Nests the intended test failure strings into one-length lists.
1939         (test_red_test_failure):
1940         Nests the intended test failure strings into one-length lists.
1941
1942 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
1943
1944         REGRESSION (r172172): Multiple regression tests fail when primary system language is Russian
1945         https://bugs.webkit.org/show_bug.cgi?id=136987
1946
1947         Reviewed by Daniel Bates.
1948
1949         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
1950         Specify the default encoding for all WebKit developers to get consistent results.
1951
1952 2014-10-01  Alexey Proskuryakov  <ap@apple.com>
1953
1954         EWS is too eager to say that a patch does not apply to trunk of repository
1955         https://bugs.webkit.org/show_bug.cgi?id=137290
1956
1957         Reviewed by Ryosuke Niwa.
1958
1959         * QueueStatusServer/app.yaml: Updated app version.
1960
1961         * QueueStatusServer/handlers/statusbubble.py:
1962         (StatusBubble._build_bubble):
1963         (StatusBubble._build_bubbles_for_attachment):
1964         Rewrote to make more sense.
1965
1966 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1967
1968         Remove thirdparty/unittest2 from webkitpy
1969         https://bugs.webkit.org/show_bug.cgi?id=137251
1970
1971         Reviewed by Brent Fulgham.
1972
1973         Additionally ordered imports in related webkitpy files and
1974         removed unnecessary shebangs from unittest files.
1975
1976         * BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py:
1977         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1978         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1979         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1980         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1981         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
1982         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1983         * Scripts/webkitpy/common/config/committers_unittest.py:
1984         * Scripts/webkitpy/common/config/committervalidator_unittest.py:
1985         * Scripts/webkitpy/common/config/contributionareas_unittest.py:
1986         * Scripts/webkitpy/common/config/ports_unittest.py:
1987         * Scripts/webkitpy/common/config/urls_unittest.py:
1988         * Scripts/webkitpy/common/editdistance_unittest.py:
1989         * Scripts/webkitpy/common/find_files_unittest.py:
1990         * Scripts/webkitpy/common/lru_cache_unittest.py:
1991         * Scripts/webkitpy/common/memoized_unittest.py:
1992         * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py:
1993         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1994         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1995         * Scripts/webkitpy/common/net/credentials_unittest.py:
1996         * Scripts/webkitpy/common/net/failuremap_unittest.py:
1997         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
1998         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
1999         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2000         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2001         * Scripts/webkitpy/common/net/statusserver_unittest.py:
2002         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
2003         * Scripts/webkitpy/common/newstringio_unittest.py:
2004         * Scripts/webkitpy/common/prettypatch_unittest.py:
2005         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
2006         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
2007         * Scripts/webkitpy/common/system/environment_unittest.py:
2008         * Scripts/webkitpy/common/system/executive.py: Ordered imports.
2009         * Scripts/webkitpy/common/system/executive_mock.py: Ordered imports.
2010         * Scripts/webkitpy/common/system/executive_unittest.py:
2011         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2012         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2013         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2014         * Scripts/webkitpy/common/system/logtesting.py:
2015         * Scripts/webkitpy/common/system/logutils_unittest.py:
2016         * Scripts/webkitpy/common/system/outputcapture.py:
2017         * Scripts/webkitpy/common/system/outputcapture_unittest.py:
2018         * Scripts/webkitpy/common/system/outputtee_unittest.py:
2019         * Scripts/webkitpy/common/system/path_unittest.py:
2020         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2021         * Scripts/webkitpy/common/system/profiler_unittest.py:
2022         * Scripts/webkitpy/common/system/stack_utils_unittest.py:
2023         * Scripts/webkitpy/common/system/user_unittest.py:
2024         * Scripts/webkitpy/common/system/workspace_unittest.py:
2025         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2026         * Scripts/webkitpy/common/thread/messagepump_unittest.py:
2027         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
2028         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py:
2029         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py:
2030         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py:
2031         * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
2032         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py:
2033         * Scripts/webkitpy/common/webkitunittest.py:
2034         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2035         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2036         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2037         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2038         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
2039         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
2040         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2041         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
2042         * Scripts/webkitpy/layout_tests/models/test_results_unittest.py:
2043         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2044         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2045         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
2046         * Scripts/webkitpy/layout_tests/servers/http_server_base_unittest.py:
2047         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2048         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
2049         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
2050         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2051         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2052         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2053         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
2054         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2055         * Scripts/webkitpy/port/base_unittest.py:
2056         * Scripts/webkitpy/port/builders_unittest.py:
2057         * Scripts/webkitpy/port/config_unittest.py:
2058         * Scripts/webkitpy/port/driver_unittest.py:
2059         * Scripts/webkitpy/port/efl_unittest.py:
2060         * Scripts/webkitpy/port/factory_unittest.py:
2061         * Scripts/webkitpy/port/gtk_unittest.py:
2062         * Scripts/webkitpy/port/http_lock_unittest.py:
2063         * Scripts/webkitpy/port/image_diff_unittest.py:
2064         * Scripts/webkitpy/port/leakdetector_unittest.py:
2065         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py:
2066         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
2067         * Scripts/webkitpy/port/mock_drt_unittest.py:
2068         * Scripts/webkitpy/port/port_testcase.py:
2069         * Scripts/webkitpy/port/server_process_unittest.py:
2070         * Scripts/webkitpy/port/westondriver_unittest.py:
2071         * Scripts/webkitpy/port/win_unittest.py:
2072         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
2073         * Scripts/webkitpy/style/checker_unittest.py:
2074         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2075         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
2076         * Scripts/webkitpy/style/checkers/common_unittest.py:
2077         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2078         * Scripts/webkitpy/style/checkers/exportfile_unittest.py:
2079         * Scripts/webkitpy/style/checkers/js_unittest.py:
2080         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
2081         * Scripts/webkitpy/style/checkers/messagesin_unittest.py:
2082         * Scripts/webkitpy/style/checkers/png_unittest.py:
2083         * Scripts/webkitpy/style/checkers/python_unittest.py:
2084         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2085         * Scripts/webkitpy/style/checkers/text_unittest.py:
2086         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
2087         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
2088         * Scripts/webkitpy/style/checkers/xml_unittest.py:
2089         * Scripts/webkitpy/style/error_handlers_unittest.py:
2090         * Scripts/webkitpy/style/filereader_unittest.py:
2091         * Scripts/webkitpy/style/filter_unittest.py:
2092         * Scripts/webkitpy/style/main_unittest.py:
2093         * Scripts/webkitpy/style/optparser_unittest.py:
2094         * Scripts/webkitpy/style/patchreader_unittest.py:
2095         * Scripts/webkitpy/test/finder_unittest.py:
2096         * Scripts/webkitpy/test/main.py: Ordered imports.
2097         * Scripts/webkitpy/test/main_unittest.py:
2098         * Scripts/webkitpy/test/printer.py: Ordered imports.
2099         (Printer.configure):
2100         * Scripts/webkitpy/test/runner_unittest.py:
2101         * Scripts/webkitpy/test/skip_unittest.py:
2102         * Scripts/webkitpy/thirdparty/__init__.py:
2103         (AutoinstallImportHook._install_irc):
2104         (AutoinstallImportHook._install_unittest2): Deleted.
2105         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2106         * Scripts/webkitpy/thirdparty/ordered_dict.py: Removed.
2107         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2108         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2109         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2110         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2111         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2112         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2113         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2114         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2115         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2116         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2117         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
2118         * Scripts/webkitpy/tool/commands/download_unittest.py:
2119         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
2120         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
2121         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2122         * Scripts/webkitpy/tool/commands/queuestest.py:
2123         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2124         * Scripts/webkitpy/tool/grammar_unittest.py:
2125         * Scripts/webkitpy/tool/mocktool_unittest.py:
2126         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2127         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
2128         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2129         * Scripts/webkitpy/tool/servers/reflectionhandler_unittest.py:
2130         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py:
2131         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
2132         * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
2133         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
2134         * Scripts/webkitpy/tool/steps/commit_unittest.py:
2135         * Scripts/webkitpy/tool/steps/discardlocalchanges_unittest.py:
2136         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
2137         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
2138         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2139         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
2140         * Scripts/webkitpy/tool/steps/steps_unittest.py:
2141         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
2142         * Scripts/webkitpy/tool/steps/update_unittest.py:
2143         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
2144         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2145         * Scripts/webkitpy/w3c/test_converter_unittest.py:
2146         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2147         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2148
2149 2014-09-30  Jake Nielsen  <jacob_nielsen@apple.com>
2150
2151         LayoutTestResults and ExpectedFailures should know about the
2152         interrupted flag from the json results file
2153         https://bugs.webkit.org/show_bug.cgi?id=137229
2154
2155         Reviewed by Daniel Bates.
2156
2157         Changes LayoutTestResults to use the interrupted flag instead of
2158         counting failures.
2159
2160         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2161         (BuilderTest._install_fetch_build._mock_fetch_build):
2162         (BuilderTest.test_latest_layout_test_results):
2163         * Scripts/webkitpy/common/net/layouttestresults.py:
2164         Removes notion of failure_limit_count, and adds
2165         did_exceed_test_failure_limit.
2166
2167         (LayoutTestResults.results_from_string):
2168         (LayoutTestResults.__init__):
2169         (LayoutTestResults.did_exceed_test_failure_limit):
2170         (LayoutTestResults): Deleted.
2171         (LayoutTestResults.set_failure_limit_count): Deleted.
2172         (LayoutTestResults.failure_limit_count): Deleted.
2173         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2174         Removes unit test for failure_limit_count logic.
2175
2176         (LayoutTestResultsTest.test_set_failure_limit_count): Deleted.
2177         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2178         Instead of providing a class method that returns a list of
2179         TestResults objects, resultsjsonparser now provides a class
2180         ParsedJSONResults that serves as an interface between the results.json
2181         file and the rest of webkitpy.
2182
2183         (ParsedJSONResults):
2184         (ParsedJSONResults.__init__):
2185         (ParsedJSONResults.did_exceed_test_failure_limit):
2186         (ParsedJSONResults.test_results):
2187         (ResultsJSONParser): Deleted.
2188         (ResultsJSONParser.parse_results_json): Deleted.
2189         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2190         Updates the unit test so that it can test the new ResultsJSONParser
2191         class.
2192
2193         (ParsedJSONResultsTest):
2194         (test_basic):
2195         (ResultsJSONParserTest): Deleted.
2196         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2197         Updates the unit test to instantiate ResultsJSONParser objects rather
2198         than simple lists of TestResult objects.
2199
2200         (MockCommitQueue.test_results):
2201         (FailingTestCommitQueue.test_results):
2202         (test_flaky_test_failure):
2203         (test_failed_archive):
2204         * Scripts/webkitpy/tool/bot/expectedfailures.py:
2205         Updates ExpectedFailures to use the did_exceed_test_failure_limit
2206         method rather than counting the number of failed tests.
2207
2208         (ExpectedFailures._should_trust):
2209         * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
2210         Updates MockResults to more closely resemble the updated
2211         LayoutTestResults class.
2212
2213         (MockResults.__init__):
2214         (MockResults.did_exceed_test_failure_limit):
2215         (ExpectedFailuresTest.test_can_trust_results):
2216         (ExpectedFailuresTest.test_unexpected_failures_observed):
2217         (ExpectedFailuresTest.test_unexpected_failures_observed_when_tree_is_hosed):
2218         (MockResults.failure_limit_count): Deleted.
2219         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2220         Removes a FIXME regarding the use of the
2221         NON_INTERACTIVE_FAILURE_LIMIT_COUNT value.
2222
2223         (LayoutTestResultsReader.results):
2224         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2225         Updates test to not check the now-nonexistant failure_count_limit
2226         method.
2227
2228         (test_missing_unit_test_results_path):
2229         (test_layout_test_results):
2230         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
2231         Accounts for name change: ResultsJSONParserTest ->
2232         ParsedJSONParserTest.
2233
2234         (RebaselineTestTest.test_gather_baselines):
2235
2236 2014-09-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2237
2238         [EFL] Rename TEST_THEME_DIR macro
2239         https://bugs.webkit.org/show_bug.cgi?id=137244
2240
2241         Reviewed by Csaba Osztrogonác.
2242
2243         TEST_THEME_DIR is to get a path for default theme though, it has used TEST_ prefix.
2244         DEFAULT_THEME_DIR is better than it.
2245
2246         * MiniBrowser/efl/main.c:
2247         (window_create):
2248         * TestWebKitAPI/efl/PlatformWebView.cpp:
2249         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2250         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2251         (WTR::PlatformWebView::PlatformWebView):
2252
2253 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2254
2255         Windows EWS went purple when it failed to build
2256         https://bugs.webkit.org/show_bug.cgi?id=137267
2257
2258         Reviewed by Ryosuke Niwa.
2259
2260         * QueueStatusServer/app.yaml: Update the version.
2261
2262         * QueueStatusServer/model/attachment.py: (Attachment._calculate_queue_positions):
2263         Make it work for style and win-ews queues.
2264
2265 2014-09-29  Filip Pizlo  <fpizlo@apple.com>
2266
2267         It should be fun and easy to run every possible JavaScript benchmark from the command line
2268         https://bugs.webkit.org/show_bug.cgi?id=137245
2269
2270         Reviewed by Oliver Hunt.
2271         
2272         We previously had Tools/Scripts/bencher.  Then we stopped adding things to it because we
2273         weren't sure about the licensing of things like Kraken and Octane.  Various people ended up
2274         having their own private scripts for doing benchmark runs, and didn't share them in the open
2275         source community, because of fears about the shady licensing of the benchmarks suites that
2276         they were running. The dominant version of this was "run-jsc-benchmarks", which has a lot of
2277         excellent power - it can run benchmarks through either jsc, DumpRenferTree, or
2278         WebKitTestRunner; it can run tests on any number of remote machines; and it has inside
2279         knowledge about how to run *a lot* of test suites. Many of those test suites are not public,
2280         but some of them are. The non-public tests are exclusively those that were not made by any
2281         WebKit contributor, but which JSC/WebKit devs found useful for testing.
2282
2283         This fixes this weirdness by releasing run-jsc-benchmarks. The paths to the test suites
2284         whose licenses are incompatible with WebKit's (to the extent that they cannot be safely
2285         checked into WebKit svn at all) can be run by passing the path to them via a configuration
2286         file. The default configuration file is ~/.run-jsc-benchmarks. The most important benchmark
2287         suites are Octane version 2 and Kraken version 1.1. We should probably check Octane 2 into
2288         WebKit eventually because it seems that the license is fine. Kraken, on the other hand, will
2289         probably never be checked in because there is no license text anywhere in that benchmark.
2290         A valid ~/.run-jsc-benchmarks file will just be something like:
2291         
2292             {
2293                 "OctanePath": "/path/to/Octane2",
2294                 "KrakenPath": "/path/to/Kraken-1.1/tests/kraken-1.1"
2295             }
2296         
2297         If your ~/.run-jsc-benchmarks file omits the directory for any particular test suite, then
2298         run-jsc-benchmarks will just gracefully avoid running that test suite.
2299         
2300         Finally, a word about policy: it is understood that different organizations that do
2301         development on JSC may find themselves having internal benchmarks that they cannot share
2302         because of weird licensing. It happens - usually because the organization doing JSC
2303         development found some test in the wild that is owned by someone else and therefore cannot
2304         be shared. So, we should consider it acceptable to write patches against run-jsc-benchmarks
2305         that add support for some new kind of benchmark suite even if the suite is not made public
2306         as part of the same patch - so long as the patch isn't too invasive. An example of
2307         non-invasiveness is the DSPJS suite, which is implemented using some new classes (like
2308         DSPJSAmmoJSRegularBenchmark) and some calls to otherwise reusable functions (like
2309         emitSelfContainedBenchRunCode). It is obviously super helpful if a benchmark suite can be
2310         completely open-sourced and committed to the WebKit repo - but the reality is that this
2311         can't always be done safely.
2312
2313         * Scripts/bencher: Removed.
2314         * Scripts/run-jsc-benchmarks: Added.
2315
2316 2014-09-30  Roger Fong  <roger_fong@apple.com>
2317
2318         [Windows] Add some logging to webkitpy to debug timeout issues with running NRWT using multiple child processes.
2319
2320         * Scripts/webkitpy/port/drdiver.py:
2321         (Driver.stop):
2322         * Scripts/webkitpy/port/server_process.py:
2323         (ServerProcess.stop):
2324
2325 2014-09-30  Roger Fong  <roger_fong@apple.com>
2326
2327         [Windows] Back to 2 child processes for NRWT on Windows.
2328
2329         * Scripts/webkitpy/port/win.py:
2330         (WinPort.default_child_processes):
2331         Changing the number of processes to 1 did not have an effect on the layout test results. 
2332         It does introduce an issue with one of the workers hanging indefinitely and causing the 
2333         layout tests to timeout as a whole occasionally, but we should just fix that.
2334
2335 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2336
2337         Remove an accidentally committed line..
2338
2339         * QueueStatusServer/handlers/statusbubble.py:
2340         (StatusBubble._build_bubble):
2341
2342 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2343
2344         build.webkit.org/dashboard: Switch EWS view to using actual retry count
2345         https://bugs.webkit.org/show_bug.cgi?id=137240
2346
2347         Reviewed by Ryosuke Niwa.
2348
2349         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
2350         (EWSQueue.prototype.loadDetailedStatus):
2351         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
2352         (EWSQueueView.prototype._popoverContentForEWSQueue):
2353         Use the new retry_count data member from JSON.
2354
2355         * QueueStatusServer/app.yaml: Updating the version.
2356
2357         * QueueStatusServer/handlers/queuestatusjson.py: (QueueStatusJSON._rows_for_work_items):
2358         Instead of message_count, produce retry_count.
2359
2360 2014-09-30  Alexey Proskuryakov  <ap@apple.com>
2361
2362         EWS doesn't need to show all the bubbles when a patch fails to apply
2363         https://bugs.webkit.org/show_bug.cgi?id=137256
2364
2365         Reviewed by Ryosuke Niwa.
2366
2367         * QueueStatusServer/app.yaml: Updated app version.
2368
2369         * QueueStatusServer/handlers/statusbubble.py:
2370         (StatusBubble._build_bubble):
2371         (StatusBubble._build_bubbles_for_attachment):
2372         (StatusBubble.get):
2373         * QueueStatusServer/templates/statusbubble.html:
2374         When some queues fail to apply, and no queues had meaningful output (meaning that
2375         they will almost certainly fail to apply later), we can show a single bubble
2376         telling the user just that.
2377
2378 2014-09-30  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2379
2380         [EFL] Bump EFL version to 1.11.2
2381         https://bugs.webkit.org/show_bug.cgi?id=137118
2382
2383         Reviewed by Gyuyoung Kim.
2384
2385         Disable NEON for EFL build because the build system doesn't pass the necessary -mfpu=neon flag to the compiler.
2386         Tools/efl/patches/ecore.patch: Removed, because this fix is already in EFL.
2387
2388         * efl/jhbuild.modules:
2389         * efl/patches/ecore.patch: Removed.
2390
2391 2014-09-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2392
2393         REGRESSION(r173929): [GTK] TestInspector fails after r173929
2394         https://bugs.webkit.org/show_bug.cgi?id=137247
2395
2396         Reviewed by Philippe Normand.
2397
2398         Wait until can-attach property changes before trying to attach the
2399         inspector after resizing the view.
2400
2401         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
2402         (testInspectorDefault):
2403
2404 2014-09-30  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2405
2406         Require Python 2.7 version
2407         https://bugs.webkit.org/show_bug.cgi?id=137112
2408
2409         Reviewed by Csaba Osztrogonác.
2410
2411         * Scripts/ensure-valid-python:
2412         (checkPythonVersion):
2413         * Scripts/webkitpy/common/version_check.py:
2414
2415 2014-09-30  Martin Hock  <mhock@apple.com>
2416
2417         Skip a JSC test after r174036.
2418         https://bugs.webkit.org/show_bug.cgi?id=137236
2419
2420         Reviewed by Csaba Osztrogonác.
2421
2422         * Scripts/run-javascriptcore-tests:
2423
2424 2014-09-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2425
2426         [GTK] [EFL] Install TestNetscapePlugin apart from the other libs.
2427         https://bugs.webkit.org/show_bug.cgi?id=137212
2428
2429         This moves TestNetscapePlugin to a new folder (lib/plugins).
2430         We should not use the same directory for TestNetscapePlugin and
2431         the other libraries, because we end up scanning all the .so in the
2432         lib dir for every test.
2433
2434         Reviewed by Carlos Garcia Campos.
2435
2436         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set LIBRARY_OUTPUT_DIRECTORY to lib/plugins.
2437         * Scripts/webkitpy/port/efl.py:
2438         (EflPort.setup_environ_for_server): Update plugin path.
2439         * Scripts/webkitpy/port/gtk.py:
2440         (GtkPort.setup_environ_for_server): Update plugin path.
2441         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Update plugin path.
2442
2443 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2444
2445         A small change to EWS bubble text. Explain why there are messages for ineligible patches.
2446
2447         Rubber-stamped by Tim Horton.
2448
2449         * QueueStatusServer/app.yaml:
2450         * QueueStatusServer/handlers/statusbubble.py:
2451         (StatusBubble._build_bubble):
2452
2453 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2454
2455         Typo fix, suggested by Tim Horton.
2456
2457         * QueueStatusServer/handlers/statusbubble.py:
2458         (StatusBubble._build_message_for_provisional_failure):
2459
2460 2014-09-29  Alexey Proskuryakov  <ap@apple.com>
2461
2462         Improve Bugzilla status bubbles
2463         https://bugs.webkit.org/show_bug.cgi?id=137232
2464
2465         Reviewed by Ryosuke Niwa.
2466
2467         * QueueStatusServer/app.yaml: Will update again with an actual version when landing.
2468
2469         * QueueStatusServer/handlers/statusbubble.py: Eliminated yellow color, added
2470         blue and orange. Significantly extended tooltips. Made bubbles show up even for queues
2471         that are stuck, as it was only confusing that they disappeared after 99.
2472
2473         * QueueStatusServer/model/attachment.py: Removed functionality that was only used
2474         by old bubbles. We need a lot more information to determine color, so the implementation
2475         can not be here.
2476
2477         * QueueStatusServer/templates/statusbubble.html: Updated colors in CSS, made bubbles
2478         always have a link for consistency. Added code to convert timestamps in tooltips
2479         to local time zone.
2480
2481 2014-09-29  Commit Queue  <commit-queue@webkit.org>
2482
2483         Unreviewed, rolling out r174045.
2484         https://bugs.webkit.org/show_bug.cgi?id=137231
2485
2486         Introduced a crash during page loading tests on Mac (Requested
2487         by rniwa on #webkit).
2488
2489         Reverted changeset:
2490
2491         "Replace OSObjectPtr with RetainPtr/adoptOS"
2492         https://bugs.webkit.org/show_bug.cgi?id=137158
2493         http://trac.webkit.org/changeset/174045
2494
2495 2014-09-29  Tim Horton  <timothy_horton@apple.com>
2496
2497         Add Jake as a contributor.
2498
2499         * Scripts/webkitpy/common/config/contributors.json:
2500
2501 2014-09-29  Roger Fong  <roger_fong@apple.com>
2502
2503         [Windows] Skip a javascriptcore test following r174036.
2504
2505         * Scripts/run-javascriptcore-tests:
2506
2507 2014-09-29  Roger Fong  <roger_fong@apple.com>
2508
2509         [Windows] Reduce number of processes used by NRWT on Windows to 1.
2510
2511         * Scripts/webkitpy/port/win.py:
2512         (WinPort.default_child_processes):
2513         Reduce number of processes to 1 so we can get a good baseline for what failures
2514         we should be expecting to see from the Windows bots.
2515
2516 2014-09-29  Darin Adler  <darin@apple.com>
2517
2518         Tweak and tighten SVG font converter
2519         https://bugs.webkit.org/show_bug.cgi?id=136956
2520
2521         Reviewed by Myles Maxfield.
2522
2523         I was investigating behavior of String::toInt, String::toDouble, and
2524         String::toFloat for various failure cases, and decided to start some
2525         unit tests for those functions here.
2526
2527         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2528         (TestWebKitAPI::TEST): Addded a first small bit of StringToInt and
2529         StringToDouble testing.
2530
2531 2014-09-29  Philippe Normand  <pnormand@igalia.com>
2532
2533         [GTK][CMake] TestWebCore target build sometimes fail
2534         https://bugs.webkit.org/show_bug.cgi?id=137207
2535
2536         Reviewed by Csaba Osztrogon.
2537
2538         * TestWebKitAPI/PlatformGTK.cmake: Make sure the forwarding
2539         headers are generated before the TestWebCore target is built.
2540
2541 2014-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2542
2543         [GTK] Remove IntPointGtk.cpp and IntRectGtk.cpp
2544         https://bugs.webkit.org/show_bug.cgi?id=137209
2545
2546         Reviewed by Philippe Normand.
2547
2548         * TestWebKitAPI/PlatformGTK.cmake: Remove unneeded IntRectGtk.cpp
2549         from the WebCore test sources.
2550
2551 2014-09-28  Myles C. Maxfield  <mmaxfield@apple.com>
2552
2553         Allow webkit-patch upload to respect the --directory argument with git checkouts
2554         https://bugs.webkit.org/show_bug.cgi?id=137166
2555
2556         Reviewed by Darin Adler.
2557
2558         We simply hadn't plumbed it through.
2559
2560         * Scripts/webkitpy/common/checkout/scm/detection.py:
2561         (SCMDetector.detect_scm_system):
2562         * Scripts/webkitpy/common/checkout/scm/git.py:
2563         (Git.__init__):
2564         (Git.changed_files):
2565
2566 2014-09-26  Sam Weinig  <sam@webkit.org>
2567
2568         Replace OSObjectPtr with RetainPtr/adoptOS
2569         https://bugs.webkit.org/show_bug.cgi?id=137158
2570
2571         Reviewed by Dan Bernstein.
2572
2573         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2574         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
2575         * TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
2576         Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
2577
2578 2014-09-26  Filip Pizlo  <fpizlo@apple.com>
2579
2580         Disable function.arguments
2581         https://bugs.webkit.org/show_bug.cgi?id=137167
2582
2583         Rubber stamped by Geoffrey Garen
2584         
2585         Enable the feature by default during tests.
2586
2587         * Scripts/run-jsc-stress-tests:
2588
2589 2014-09-26  Beth Dakin  <bdakin@apple.com>
2590
2591         Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
2592         https://bugs.webkit.org/show_bug.cgi?id=137089
2593
2594         Reviewed by Tim Horton.
2595
2596         This is a little sneaky since updateWindowScaleForTest() should ensure that these 
2597         tests run at 1x, but that code does not seem to execute at the right time for 
2598         these tests, so if we just ensure we start out at 1x, that appears to fix these 
2599         tests and does not break the HiDPI tests either.
2600         * WebKitTestRunner/TestController.cpp:
2601         (WTR::TestController::createWebViewWithOptions):
2602
2603 2014-09-26  Roger Fong  <roger_fong@apple.com>
2604
2605         [Windows] Decrease default number of child processes used by Windows.
2606
2607         * Scripts/webkitpy/port/win.py:
2608         (WinPort.default_child_processes):
2609         Having too many seems to cause many tests to crash or timeout. 
2610         We may even need to make it have only 1 child process if we’re still seeing problems after this.
2611
2612 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2613
2614         Mac EWS bots do not keep logs as promised
2615         https://bugs.webkit.org/show_bug.cgi?id=137151
2616
2617         Reviewed by Ryosuke Niwa.
2618
2619         * EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
2620
2621 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2622
2623         Get rid of webkit-queues dashboard
2624         https://bugs.webkit.org/show_bug.cgi?id=137141
2625
2626         Reviewed by Ryosuke Niwa.
2627
2628         * QueueStatusServer/app.yaml: Updated version.
2629
2630         * QueueStatusServer/templates/dashboard.html: Removed.
2631         * QueueStatusServer/handlers/dashboard.py: Removed.
2632         * QueueStatusServer/main.py:
2633         Kill it!
2634
2635         * QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
2636         (.status-cell): Deleted.
2637         (.status-cell:hover): Deleted.
2638         (.status-cell.pass): Deleted.
2639         (.status-cell.fail): Deleted.
2640         (.status-cell.pending): Deleted.
2641         (.status-cell.error): Deleted.
2642         * QueueStatusServer/stylesheets/dashboard.css: Removed.
2643         * QueueStatusServer/templates/activebots.html:
2644         * QueueStatusServer/templates/patch.html:
2645         * QueueStatusServer/templates/queuestatus.html:
2646         * QueueStatusServer/templates/recentstatus.html:
2647         Renamed dashboard.css to common.css, and removed dashboard-only rules.
2648
2649 2014-09-26  Alexey Proskuryakov  <ap@apple.com>
2650
2651         Get rid of Retry status in webkit-queues
2652         https://bugs.webkit.org/show_bug.cgi?id=137135
2653
2654         Reviewed by Ryosuke Niwa.
2655
2656         * QueueStatusServer/config/messages.py: Removed Retry.
2657
2658         * QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
2659         no longer needs to check the latest status. It just always both unlocks the patch
2660         and removes it from WorkItems.
2661
2662         * QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
2663         I don't understand why we even needed to check for retries here, but now that there
2664         are no retries, that code can go to /dev/null.
2665
2666         * QueueStatusServer/loggers/recordpatchevent.py:
2667         (RecordPatchEvent.started):
2668         (RecordPatchEvent.retrying): Deleted.
2669         Fixed retry counting, it should work for all queues now.
2670
2671         * QueueStatusServer/model/queuestatus.py:
2672         (QueueStatus.is_retry_request): Deleted. These are no more.
2673
2674         * Scripts/webkitpy/common/net/statusserver_mock.py:
2675         (MockStatusServer.release_lock):
2676         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2677         Did whatever it took to keep passing the tests. The particular test doesn't seem
2678         quite right, but whatever.
2679
2680         * Scripts/webkitpy/tool/commands/queues.py:
2681         (CommitQueue.process_work_item): Instead of posting a retry status, just unlock
2682         and let others pick up. Also, added explicit returns for clarity.
2683         (AbstractPatchQueue._did_retry): Deleted.
2684
2685 2014-09-26  Csaba Osztrogonác  <ossy@webkit.org>
2686
2687         [EFL] Fix the gst-libav build on ARM Thumb2
2688         https://bugs.webkit.org/show_bug.cgi?id=137022
2689
2690         Reviewed by Zoltan Herczeg.
2691
2692         * efl/jhbuild.modules:
2693         * efl/patches/gst-libav.patch: Added.
2694
2695 2014-09-26  Akos Kiss  <akiss@inf.u-szeged.hu>
2696
2697         [EFL] Bump up dependencies not to conflict with the GTK port.
2698         https://bugs.webkit.org/show_bug.cgi?id=137143
2699
2700         Reviewed by Gyuyoung Kim.
2701
2702         Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
2703         installing and removing different versions of libgnutls-dev, thus
2704         hindering the development for both ports on the same machine. GTK is
2705         using the newer version of the package, now bumping up EFL to use the 
2706         same.
2707
2708         * efl/install-dependencies:
2709
2710 2014-09-25  Rohit Kumar  <kumar.rohit@samsung.com>
2711
2712         [EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
2713         https://bugs.webkit.org/show_bug.cgi?id=136854
2714
2715         Reviewed by Gyuyoung Kim.
2716
2717         'Escape' key should exit fullscreen first and then should be used to stop page load.
2718
2719         * MiniBrowser/efl/main.c:
2720         (on_key_down):
2721
2722 2014-09-25  Dean Jackson  <dino@apple.com>
2723
2724         Add Said to the contributors list so his name completes in bugzilla.
2725
2726         * Scripts/webkitpy/common/config/contributors.json:
2727
2728 2014-09-25  Alexey Proskuryakov  <ap@apple.com>
2729
2730         EWS only repeats its cycle every two hours
2731         https://bugs.webkit.org/show_bug.cgi?id=137129
2732
2733         Reviewed by Ryosuke Niwa.
2734
2735         * QueueStatusServer/app.yaml: Updated version.
2736
2737         * QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
2738
2739         * QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
2740         the patch from work items.
2741
2742         * QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
2743
2744         * QueueStatusServer/main.py: Added release-lock.
2745
2746         * QueueStatusServer/model/activeworkitems.py:
2747         (ActiveWorkItems.deactivate_expired): Use timeout from configuration.
2748
2749         * QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
2750         we don't want it to be immediately picked up again, it's better to give other patches
2751         a chance.
2752
2753         * QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
2754         these interactive versions, but OK.
2755
2756         * Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
2757         Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
2758         or svn is down).
2759
2760         * Scripts/webkitpy/tool/commands/queues.py:
2761         (AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
2762         Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
2763         meaning that these handlers could never do the right thing. We'd either get a duplicate
2764         _did_fail, or try to unlock an already unlocked patch.
2765         (StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
2766         making it eligible for retry immediately.
2767
2768         * Scripts/webkitpy/common/net/statusserver.py:
2769         (StatusServer._post_release_lock):
2770         (StatusServer.release_lock):
2771         Added a call to release-lock.
2772
2773 2014-09-25  Roger Fong  <roger_fong@apple.com>
2774
2775         [Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
2776
2777         * Scripts/webkitpy/common/system/path.py:
2778         (_CygPath.convert):
2779
2780 2014-09-25  Roger Fong  <roger_fong@apple.com>
2781
2782         [Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
2783
2784         * Scripts/webkitpy/common/system/path.py:
2785         (_CygPath.convert):
2786
2787 2014-09-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2788
2789         [Gtk] build.sh needs a -- before make options when the build command is cmake --build
2790         https://bugs.webkit.org/show_bug.cgi?id=136377
2791
2792         Reviewed by Philippe Normand.
2793
2794         * Scripts/webkitdirs.pm:
2795         (buildCMakeGeneratedProject): Only use the build.sh script if it exists.
2796
2797 2014-09-25  Akos Kiss  <akiss@inf.u-szeged.hu>
2798
2799         [EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
2800         https://bugs.webkit.org/show_bug.cgi?id=137117
2801
2802         Tools/efl/install-dependencies relies on apt-get to install packages.
2803         Unfortunately, if a package does not exist (e.g., for a given
2804         architecture) then apt-get install is not able to ignore the missing
2805         package and install the rest but fails to run entirely (and there
2806         seems to be no intent to change this behaviour).
2807
2808         On ARM64, the luajit package is missing and currently it needs manual
2809         editing of install-dependencies to get the script install as much as it
2810         can.
2811
2812         This patch separates the installation of the universally available
2813         packages from those which might not be available for all architectures.
2814
2815         Reviewed by Gyuyoung Kim.
2816
2817         * efl/install-dependencies:
2818
2819 2014-09-25  Csaba Osztrogonác  <ossy@webkit.org>
2820
2821         Remove WinCE port from trunk
2822         https://bugs.webkit.org/show_bug.cgi?id=136951
2823
2824         Reviewed by Alex Christensen.
2825
2826         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2827         (_should_file_trigger_build):
2828         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2829         (ShouldBuildTest):
2830         * CMakeLists.txt:
2831         * DumpRenderTree/win/DRTDataObject.cpp:
2832         (DRTDataObject::CopyMedium):
2833         * Scripts/build-webkit:
2834         * Scripts/webkit-build-directory:
2835         * Scripts/webkitdirs.pm:
2836         (argumentsForConfiguration):
2837         (builtDylibPathForName):
2838         (isAppleWinWebKit):
2839         (launcherPath):
2840         (launcherName):
2841         (shouldRemoveCMakeCache):
2842         (cmakeBasedPortArguments):
2843         (cmakeBasedPortName):
2844         (isCMakeBuild):
2845         (isWinCE): Deleted.
2846         (determineIsWinCE): Deleted.
2847         * Scripts/webkitperl/FeatureList.pm:
2848         * Scripts/webkitpy/port/port_testcase.py:
2849         (test_apache_config_file_name_for_platform):
2850         * TestWebKitAPI/config.h:
2851         * WinCELauncher/CMakeLists.txt: Removed.
2852         * WinCELauncher/main.cpp: Removed.
2853         * gtk/manifest.txt:
2854
2855 2014-09-23  David Farler  <dfarler@apple.com>
2856
2857         [iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
2858         https://bugs.webkit.org/show_bug.cgi?id=136895
2859
2860         Reviewed by David Kilzer.
2861
2862         Create Device, DeviceType, and Runtime data classes.
2863         Create Simulator class represent simctl output.
2864
2865         Wherever possible, use structured data classes anywhere a raw
2866         identifier or UDID string was used for a cleaner implementation
2867         and to encapsulate the inherent fragility of scraping simctl output.
2868
2869         Create a suitably named testing device if one doesn't exist.
2870
2871         Finally, accurately handle having multiple simulator runtimes (SDKs)
2872         installed in the active Xcode.app bundle.
2873
2874         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2875         (_set_up_derived_options):
2876         * Scripts/webkitpy/port/driver.py:
2877         (IOSSimulatorDriver.cmd_line):
2878         Construct DeviceType and Runtime objects from identifiers passed at the
2879         command line, still providing sensible defaults for 32- and 64-bit testing.
2880         * Scripts/webkitpy/port/ios.py:
2881         (IOSSimulatorPort.__init__):
2882         (IOSSimulatorPort.setup_test_run):
2883         (IOSSimulatorPort):
2884         (IOSSimulatorPort.testing_device):
2885         Cache the testing device once it is created or found.
2886         (IOSSimulatorPort.reset_preferences):
2887         Get the device path from the Device object instead of consructing it
2888         in the port class.
2889         (IOSSimulatorPort.simulator_udid): Deleted.
2890         Get the UDID from the testing_device :: Device object itself.
2891         * Scripts/webkitpy/xcode/simulator.py:
2892         Created Device, DeviceType, Runtime, and Simulator classes.
2893         (get_runtimes): Deleted.
2894         (get_devices): Deleted.
2895         (get_device_types): Deleted.
2896         (get_latest_runtime): Deleted.
2897
2898 2014-09-24  Roger Fong  <roger_fong@apple.com>
2899
2900         [Windows] Tentative fix for Windows test bots.
2901
2902         * Scripts/webkitpy/common/system/path.py:
2903         (_CygPath.convert):
2904
2905 2014-09-24  Alexey Proskuryakov  <ap@apple.com>
2906
2907         Change more build.webkit.org links to https
2908         https://bugs.webkit.org/show_bug.cgi?id=137049
2909
2910         Reviewed by Csaba Osztrogonác.
2911
2912         Fix appspot, svn.webkit.org and Trac links.
2913
2914         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2915         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
2916         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
2917         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
2918         (ViewController.prototype._domForBuildName):
2919         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
2920         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2921         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2922         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2923         (.):
2924         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
2925         (EWS):
2926         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
2927         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
2928         (TestHistory):
2929         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2930
2931 2014-09-24  Langó László  <llango.u-szeged@partner.samsung.com>
2932
2933         Update the list of u-szeged contributors.
2934
2935         Rubber-stamped by Csaba Osztrogonác <ossy@webkit.org>.
2936
2937         * Scripts/webkitpy/common/config/contributors.json:
2938
2939 2014-09-23  Roger Fong  <roger_fong@apple.com>
2940
2941         [Windows] More debugging for the Windows bots.
2942
2943         * Scripts/webkitpy/common/system/path.py:
2944         (_CygPath):
2945
2946 2014-09-23  Roger Fong  <roger_fong@apple.com>
2947
2948         Unreviewed. Fix for r173899, those tabs should be spaces.
2949
2950         * Scripts/webkitpy/port/driver.py:
2951         (Driver._command_from_driver_input):
2952         (Driver): Deleted.
2953
2954 2014-09-23  Roger Fong  <roger_fong@apple.com>
2955
2956         [Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.
2957
2958         * Scripts/webkitpy/port/driver.py:
2959         (Driver):
2960
2961 2014-09-23  Jer Noble  <jer.noble@apple.com>
2962
2963         [Tools] git-commit uses wrong ChangeLog when run from a subdirectory
2964         https://bugs.webkit.org/show_bug.cgi?id=137031
2965
2966         Reviewed by Joseph Pecoraro.
2967
2968         commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
2969         from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
2970         a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
2971         ChangeLog locations before passing them to createCommitMessage().
2972
2973         * Scripts/commit-log-editor:
2974
2975 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2976
2977         W3C test importer should detect manual and reference tests according their filenames
2978         https://bugs.webkit.org/show_bug.cgi?id=133852
2979
2980         Reviewed by Bem Jones-Bey.
2981
2982         * Scripts/webkitpy/w3c/test_parser.py:
2983         (TestParser.analyze_test): Adding checks based on WPT filename rules.
2984         (TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
2985         (TestParser):
2986         (TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
2987         (TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.
2988         * Scripts/webkitpy/w3c/test_parser_unittest.py:
2989         (test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it. 
2990
2991 2014-09-23  Bem Jones-Bey  <bjonesbe@adobe.com>
2992
2993         Unreviewed, add Rebecca Hauck as a contributor.
2994
2995         * Scripts/webkitpy/common/config/contributors.json:
2996
2997 2014-09-23  David Kilzer  <ddkilzer@apple.com>
2998
2999         Switch build.webkit.org URLs to https
3000
3001         Reviewed by Lucas Forschler and Alexey Proskuryakov.
3002
3003         * TestResultServer/app.yaml: Update version to this commit
3004         revision.
3005
3006         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3007         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
3008         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3009         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:
3010         (WebKitBuildbot):
3011         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3012         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
3013         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
3014         (.):
3015         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3016         (WebKitBuildbot):
3017         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
3018         * Scripts/webkitpy/common/config/urls.py:
3019         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3020         (test_builder_with_name):
3021         * Scripts/webkitpy/tool/commands/queries.py:
3022         (TreeStatus):
3023         * TestResultServer/generate_builders_json.py:
3024         (main):
3025         * TestResultServer/generate_builders_json_unittest.py:
3026         (GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
3027         (GenerateBuildersJsonTest):
3028         (GenerateBuildersJsonTest.test_generate_json_data):
3029         * TestResultServer/static-dashboards/builders.jsonp:
3030         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3031         (loadExpectationsLayoutTests):
3032         * TestResultServer/static-dashboards/timeline_explorer.js:
3033
3034 2014-09-23  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3035
3036         W3C test importer should copy .htaccess files
3037         https://bugs.webkit.org/show_bug.cgi?id=136850
3038
3039         Reviewed by Bem Jones-Bey.
3040
3041         * Scripts/webkitpy/w3c/test_importer.py:
3042         (TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
3043         (TestImporter):
3044         (TestImporter.find_importable_tests): Making use of new helper function.
3045
3046 2014-09-23  Alexey Proskuryakov  <ap@apple.com>
3047
3048         Trying to revive bot watcher's dashboard after HSTS.
3049
3050         Unreviewed.
3051
3052         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3053         (WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.
3054
3055 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3056
3057         Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
3058         https://bugs.webkit.org/show_bug.cgi?id=137026
3059
3060         Reviewed by Csaba Osztrogonác.
3061
3062         * BuildSlaveSupport/wait-for-SVN-server.py:
3063         (getLatestSVNRevision):
3064         (waitForSVNRevision):
3065
3066 2014-09-23  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3067
3068         Remove unlinkZeroFiles from build-webkit
3069         https://bugs.webkit.org/show_bug.cgi?id=137018
3070
3071         Reviewed by Csaba Osztrogonác.
3072
3073         * Scripts/build-webkit:
3074         (unlinkZeroFiles): Deleted.
3075
3076 2014-09-23  Rohit Kumar  <kumar.rohit@samsung.com>
3077
3078         [GTK] Minibrowser : Add keyboard support for stop page load
3079         https://bugs.webkit.org/show_bug.cgi?id=136857
3080
3081         Reviewed by Philippe Normand.
3082
3083         Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.
3084
3085         * MiniBrowser/gtk/BrowserWindow.c:
3086         (stopPageLoad): Callback to stop page load.
3087         (browser_window_init):
3088
3089 2014-09-22  Rohit Kumar  <kumar.rohit@samsung.com>
3090
3091         [EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
3092         https://bugs.webkit.org/show_bug.cgi?id=136813
3093
3094         Reviewed by Gyuyoung Kim.
3095
3096         Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.
3097
3098         * MiniBrowser/efl/main.c:
3099         (on_key_down):
3100
3101 2014-09-22  Daniel Bates  <dabates@apple.com>
3102
3103         [Cocoa] Add UI delegate callback when window.close() is called
3104         https://bugs.webkit.org/show_bug.cgi?id=137008
3105         <rdar://problem/17801001>
3106
3107         Reviewed by Anders Carlsson.
3108
3109         Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
3110         for window opened via JavaScript (i.e. window.open()).
3111
3112         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3113         * TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
3114         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
3115
3116 2014-09-22  Youenn Fablet  <youennf@gmail.com>
3117
3118         W3C importer should import html files within resources folders
3119         https://bugs.webkit.org/show_bug.cgi?id=127548
3120
3121         Reviewed by Ryosuke Niwa.
3122         
3123         Import HTML files in any folder named "resources" even if file is not detected as a HTML test file 
3124
3125         * Scripts/webkitpy/w3c/test_importer.py:
3126         (TestImporter.find_importable_tests):
3127
3128 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3129
3130         [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
3131         https://bugs.webkit.org/show_bug.cgi?id=136998
3132
3133         Reviewed by Philippe Normand.
3134
3135         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3136         (testWebViewCanShowMIMEType): Remove the check of PDF as
3137         unsupported MIME type.
3138
3139 2014-09-22  Carlos Garcia Campos  <cgarcia@igalia.com>
3140
3141         Unreviewed. Fix WebKitGTKTranslations rule in watchlist.
3142
3143         In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
3144         to Source/WebCore/platform/gtk/po/ but the rule was not updated.
3145
3146         * Scripts/webkitpy/common/config/watchlist: Use
3147         Source/WebCore/platform/gtk/po/ as directory to watch for
3148         WebKitGTKTranslations rule and add berto and myself to the list of
3149         watchers.
3150
3151 2014-09-22  Ryuan Choi  <ryuan.choi@gmail.com>
3152
3153         Fix syntaxError in watchlist since r173594
3154         https://bugs.webkit.org/show_bug.cgi?id=136996
3155
3156         Reviewed by Philippe Normand.
3157
3158         * Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
3159
3160 2014-09-20  Sam Weinig  <sam@webkit.org>
3161
3162         Make possible HashSet<std::unique_ptr<>>
3163         https://bugs.webkit.org/show_bug.cgi?id=136166
3164
3165         Reviewed by Darin Adler.
3166
3167         * TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
3168         * TestWebKitAPI/Counters.cpp: Added.
3169         * TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.
3170         Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
3171         helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
3172         translation unit.
3173     
3174         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3175         Add new files.
3176
3177         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3178         Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.
3179
3180         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3181         Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.
3182
3183 2014-09-21  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3184
3185         run-webkit-tests should count tests submitted as absolute paths once
3186         https://bugs.webkit.org/show_bug.cgi?id=136848
3187
3188         Reviewed by Darin Adler.
3189
3190         * Scripts/webkitpy/port/base.py:
3191         (Port._expanded_paths): In case of absolute path, do not search for platform specific tests.
3192
3193 2014-09-19  Joseph Pecoraro  <pecoraro@apple.com>
3194
3195         JSStringRef leak on the leaks bot allocation under selectTextWithCriteriaCallback
3196         https://bugs.webkit.org/show_bug.cgi?id=136974
3197
3198         Reviewed by Chris Fleizach.
3199
3200         * DumpRenderTree/AccessibilityUIElement.cpp:
3201         (selectTextWithCriteriaCallback):
3202         Be sure to release the string if it was allocated.
3203
3204 2014-09-19  Alexey Proskuryakov  <ap@apple.com>
3205
3206         build.webkit.org/dashboard: Pending builds don't show up when there is a commit with no comments
3207         https://bugs.webkit.org/show_bug.cgi?id=136966
3208
3209         Reviewed by Daniel Bates.
3210
3211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3212         (Trac.prototype._convertCommitInfoElementToObject): Tolerate these horrible commits.
3213
3214 2014-09-19  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3215
3216         [CoordinatedGraphics][EFL] window.scrollTo(x, y) doesn't work when fixed layout is enabled
3217         https://bugs.webkit.org/show_bug.cgi?id=136917
3218
3219         Reviewed by Darin Adler.
3220
3221         Added WKViewScrollTo.cpp and scrollTo.html to test this issue.
3222
3223         * TestWebKitAPI/PlatformEfl.cmake:
3224         * TestWebKitAPI/Tests/WebKit2/efl/WKViewScrollTo.cpp: Added.
3225         (TestWebKitAPI::didFinishLoadForFrame):
3226         (TestWebKitAPI::TEST):
3227         * TestWebKitAPI/Tests/WebKit2/efl/scrollTo.html: Added.
3228
3229 2014-09-19  Daniel Bates  <dabates@apple.com>
3230
3231         Always assume internal SDK when building configuration Production
3232         https://bugs.webkit.org/show_bug.cgi?id=136925
3233         <rdar://problem/18362399>
3234
3235         Reviewed by Dan Bernstein.
3236
3237         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3238         * MiniBrowser/Configurations/DebugRelease.xcconfig:
3239         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
3240         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3241
3242 2014-09-19  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3243
3244         WTR and DRT didReceiveAuthenticationChallengeInFrame should print messages consistently
3245         https://bugs.webkit.org/show_bug.cgi?id=136847
3246
3247         Added protection space host and port logging to WTR didReceiveAuthenticationChallengeInFrame.
3248
3249         Reviewed by Alexey Proskuryakov.
3250
3251         * WebKitTestRunner/TestController.cpp:
3252         (WTR::TestController::didReceiveAuthenticationChallengeInFrame):
3253
3254 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3255
3256         [GTK] Missing inspector files in the tarball
3257         https://bugs.webkit.org/show_bug.cgi?id=136952
3258
3259         Reviewed by Gustavo Noronha Silva.
3260
3261         * gtk/manifest.txt: Add
3262         Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js
3263         to the tarball.
3264
3265 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3266
3267         Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
3268         https://bugs.webkit.org/show_bug.cgi?id=136632
3269
3270         Reviewed by Gustavo Noronha Silva.
3271
3272         * gtk/generate-inspector-gresource-manifest.py: Use an alias for
3273         the gtk icons.
3274         * gtk/manifest.txt: Only include the free icons in the tarball.
3275
3276 2014-09-19  Carlos Garcia Campos  <cgarcia@igalia.com>
3277
3278         [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
3279         https://bugs.webkit.org/show_bug.cgi?id=136943
3280
3281         Reviewed by Philippe Normand.
3282
3283         Update the script to receive the list of files from the command
3284         line instead of scanning the given directories.
3285
3286         * gtk/generate-inspector-gresource-manifest.py:
3287         (get_filenames): Convert filenames to use relative paths.
3288         (find_all_files_in_directory): Deleted.
3289         (find_all_files_in_directory.select_file): Deleted.
3290
3291 2014-09-18  Tanay C  <tanay.c@samsung.com>
3292
3293         [EFL][WK2] Minibrowser : Support Zoom on Control key + scroll
3294         https://bugs.webkit.org/show_bug.cgi?id=136739
3295
3296         Reviewed by Gyuyoung Kim.
3297
3298         * MiniBrowser/efl/main.c: Add support for zoom on control key + mouse scroll
3299         (on_mouse_wheel): Modified.
3300
3301 2014-09-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3302
3303         [GTK] Dot not allow to create delete-on-destroy GMainLoopSources
3304         https://bugs.webkit.org/show_bug.cgi?id=136923
3305
3306         Reviewed by Gustavo Noronha Silva.
3307
3308         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3309         (TestWebKitAPI::TEST): Use the new API that doesn't allow to use
3310         the source.
3311
3312 2014-09-18  Csaba Osztrogonác  <ossy@webkit.org>
3313
3314         Fix countFailures of RunLLINTCLoopTests and Run32bitJSCTests (II)
3315         https://bugs.webkit.org/show_bug.cgi?id=136856
3316
3317         Reviewed by Darin Adler.
3318
3319         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3320         (RunLLINTCLoopTests.countFailures):
3321         (Run32bitJSCTests.countFailures):
3322         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
3323         (RunLLINTCLoopTestsTest.test_failures):
3324         (RunLLINTCLoopTestsTest.test_failure):
3325         (RunLLINTCLoopTestsTest.test_no_failure):
3326         (Run32bitJSCTestsTest.test_failures):
3327         (Run32bitJSCTestsTest.test_failure):
3328         (Run32bitJSCTestsTest.test_no_failure):
3329
3330 2014-09-18  Zan Dobersek  <zdobersek@igalia.com>
3331
3332         GMainLoopSource is exposed to race conditions
3333         https://bugs.webkit.org/show_bug.cgi?id=135800
3334
3335         Reviewed by Carlos Garcia Campos.
3336
3337         Add unit tests for GMainLoopSource.
3338
3339         The tests check correct behavior of GMainLoopSource in various conditions --
3340         from the most simple rescheduling to rescheduling during dispatch, cancelling
3341         or destroying the GMainLoopSource during dispatch, proper destroy callback
3342         dispatching etc.
3343
3344         Scheduling both void (one-time) and bool (repeatable) callbacks is tested.
3345         State of the GMainLoopSource object (either ready, sheduled or active) is
3346         thoroughly tested throughout the lifetime of that object.
3347
3348         Still missing are tests for socket callbacks, which are a bit trickier because
3349         they rely on a GSocket object. The delete-on-destroy GMainLoopSource objects
3350         are also not tested thoroughly, simply because it is at the moment impossible
3351         to test that the objects are actually destroyed when the corresponding source
3352         is finally deleted.
3353
3354         * TestWebKitAPI/PlatformGTK.cmake:
3355         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
3356         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
3357         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
3358         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
3359         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
3360         (TestWebKitAPI::GMainLoopSourceTest::finish):
3361         (TestWebKitAPI::GMainLoopSourceTest::source):
3362         (TestWebKitAPI::TEST):
3363
3364 2014-09-17  Ryuan Choi  <ryuan.choi@gmail.com>
3365
3366         Unreviewed, Update my email in contributors.json
3367
3368         * Scripts/webkitpy/common/config/contributors.json:
3369
3370 2014-09-17  Daniel Bates  <dabates@apple.com>
3371
3372         Unreviewed, rolling out r173695.
3373
3374         Broke building third-party Legacy WebKit apps; will
3375         investigate offline
3376
3377         Reverted changeset:
3378
3379         "[iOS] Make WebCore build with public iOS SDK"
3380         https://bugs.webkit.org/show_bug.cgi?id=136487
3381         http://trac.webkit.org/changeset/173695
3382
3383 2014-09-17  Daniel Bates  <dabates@apple.com>
3384
3385         [iOS] Make WebCore build with public iOS SDK
3386         https://bugs.webkit.org/show_bug.cgi?id=136487
3387
3388         Reviewed by David Kilzer.
3389
3390         Substitute <WebCore/MachVMSPI.h> for <mach/mach_vm.h>.
3391
3392         * DumpRenderTree/mac/CheckedMalloc.cpp:
3393
3394 2014-09-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3395
3396         [GTK] WebKitWebView::load-failed-with-tls-errors should receive the failing URI instead of a host
3397         https://bugs.webkit.org/show_bug.cgi?id=136889
3398
3399         Reviewed by Gustavo Noronha Silva.
3400
3401         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
3402         (testLoadFailedWithTLSErrors): Check that LoadFailedWithTLSErrors
3403         event was added to the events vector.
3404         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
3405         (loadFailedCallback): Do not assume the web view URI is the
3406         failing URI when the load fails before the committed state.
3407         (loadFailedWithTLSErrorsCallback): Handle the case of load failure
3408         because of TLS errors can call LoadTrackingTest::loadFailedWithTLSErrors.
3409         (LoadTrackingTest::LoadTrackingTest): Connect to WebKitWebView::load-failed-with-tls-errors.
3410         (LoadTrackingTest::loadFailedWithTLSErrors): Add
3411         LoadFailedWithTLSErrors event to the events vector.
3412         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
3413
3414 2014-09-17  Renato Nagy  <rnagy@inf.u-szeged.hu>
3415
3416         [EFL][GTK] Remove WebKit1 related codes
3417         https://bugs.webkit.org/show_bug.cgi?id=136853
3418
3419         Reviewed by Csaba Osztrogonác.
3420
3421         Gtk and EFL WebKit1 ports no longer exist. Webkit1 related codes were deleted
3422         from scripts.
3423
3424         * BuildSlaveSupport/build.webkit.org-config/config.json:
3425         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3426         (Compile32bitJSC):
3427         (BuildAndTestWebKit2Factory):
3428         (CompileWebKit1Only): Deleted.
3429         (CompileWebKit2Only): Deleted.
3430         (BuildAndTestWebKit1OnlyFactory): Deleted.
3431         (BuildAndTestWebKit2OnlyFactory): Deleted.
3432         * Scripts/build-webkit:
3433         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl:
3434         * Scripts/webkitpy/common/config/ports.py:
3435         (GtkWK2Port.build_webkit_command):
3436         (EflWK2Port.build_webkit_command):
3437         * Scripts/webkitpy/common/config/ports_unittest.py:
3438         (DeprecatedPortTest.test_gtk_wk2_port):
3439         * Scripts/webkitpy/port/efl.py:
3440         (EflPort.build_webkit_command):
3441         * Scripts/webkitpy/port/gtk.py:
3442         (GtkPort._built_libraries_path):
3443         (GtkPort._search_paths):
3444         (GtkPort.test_expectations_file_position):
3445         (GtkPort.build_webkit_command):
3446         (GtkPort.run_webkit_tests_command):
3447         (GtkPort.warn_if_bug_missing_in_test_expectations): Deleted.
3448
3449 2014-09-16  Daniel Bates  <dabates@apple.com>
3450
3451         [iOS] Add iOS SDK name and version suffix to WebKitSystemInterface debug/release product name
3452         https://bugs.webkit.org/show_bug.cgi?id=136862
3453
3454         Reviewed by David Kilzer.
3455
3456         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3457         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3458         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Remove hardcoded iOS 8.0
3459         IPHONEOS_DEPLOYMENT_TARGET to ensure we link against the latest version of WebKitSystemInterface.
3460
3461 2014-09-12  Ryosuke Niwa  <rniwa@webkit.org>
3462
3463         Mac queue slaves should reboot every so often
3464         https://bugs.webkit.org/show_bug.cgi?id=136791
3465
3466         Reviewed by Alexey Proskuryakov.
3467
3468         Reboot Mac queue slaves every night between 1 A.M. and 6 A.M.
3469
3470         * EWSTools/start-queue-mac.sh:
3471
3472 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3473
3474         Unreviewed gardening, skip one more tests on Windows.
3475
3476         * Scripts/run-javascriptcore-tests:
3477
3478 2014-09-16  Csaba Osztrogonác  <ossy@webkit.org>
3479
3480         JSC test gardening
3481         https://bugs.webkit.org/show_bug.cgi?id=136823
3482
3483         Reviewed by Geoffrey Garen.
3484
3485         * Scripts/run-javascriptcore-tests: Skip tests on only the affected platforms.
3486
3487 2014-09-16  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3488
3489         Remove shouldAbortEarly cruft from master.cfg
3490         https://bugs.webkit.org/show_bug.cgi?id=136779
3491
3492         Reviewed by Csaba Osztrogonác.
3493
3494         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3495         (ConfigureBuild.start):
3496         (RunWebKitTests.start):
3497         (RunWebKit2Tests.start): Deleted.
3498
3499 2014-09-15  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3500
3501         Remove ORWT related crufts from webkitdirs.pm
3502         https://bugs.webkit.org/show_bug.cgi?id=136821
3503
3504         Reviewed by Alexey Proskuryakov.
3505
3506         * Scripts/webkitdirs.pm:
3507         (isPerianInstalled): Deleted.
3508         (determineIPhoneSimulatorVersion): Deleted.
3509         (iPhoneSimulatorVersion): Deleted.
3510         (isSnowLeopard): Deleted.
3511         (isLion): Deleted.
3512         (quitIOSSimulator): Deleted.
3513
3514 2014-09-15  Roger Fong  <roger_fong@apple.com>
3515
3516         Unreviewed. Skip yet another ecma/Date test that fails only on Windows.
3517         https://bugs.webkit.org/show_bug.cgi?id=25160
3518
3519         * Scripts/run-javascriptcore-tests:
3520
3521 2014-09-15  Lucas Forschler  <lforschler@apple.com>
3522
3523         Add another Apple build slave to the Mountain Lion Debug WK1 queue
3524         
3525         Rubber stamped by Matt Hanson.
3526         
3527         * BuildSlaveSupport/build.webkit.org-config/config.json:
3528
3529 2014-09-15  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
3530
3531         [EFL] Ecore and Eina are initialized twice in TestWebKitAPI
3532         https://bugs.webkit.org/show_bug.cgi?id=136822
3533
3534         Reviewed by Gyuyoung Kim.
3535
3536         In TestWebKitAPI/efl/main.cpp, ecore and eina modules are unnecessarily
3537         initialized as we already does it in PlatformWebView::PlatformWebView
3538         calling ewk_init(). The reason for that was to ensure testing for example,
3539         WTF where creating the view is not mandatory.
3540
3541         Call ewk_init() and ewk_shutdown() in TestWebKitAPI/efl/main.cpp
3542         in order to properly initalize and release EWebKit.
3543
3544         * TestWebKitAPI/PlatformEfl.cmake:
3545         * TestWebKitAPI/efl/PlatformWebView.cpp:
3546         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3547         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3548         * TestWebKitAPI/efl/main.cpp:
3549         (main):
3550
3551 2014-09-15  peavo@outlook.com  <peavo@outlook.com>
3552
3553         [WinCairo] Make it easier to enable/disable GStreamer.
3554         https://bugs.webkit.org/show_bug.cgi?id=135766
3555
3556         Reviewed by Brent Fulgham.
3557
3558         Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
3559
3560         * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
3561
3562 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
3563
3564         Web Inspector: remind about rebaselining generator test results
3565         https://bugs.webkit.org/show_bug.cgi?id=136759
3566
3567         Reviewed by Joseph Pecoraro.
3568
3569         For now, we can implement this as a watchlist message. Add watchlist
3570         groups and messages for the inspector and web replay generators.
3571
3572         * Scripts/webkitpy/common/config/watchlist:
3573
3574 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3575
3576         build.webkit.org/dashboard: Overlapping text when status is long
3577         https://bugs.webkit.org/show_bug.cgi?id=136794
3578
3579         Reviewed by Timothy Hatcher.
3580
3581         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3582         (.status-line): Replaces height with min-height.
3583
3584 2014-09-12  Timothy Hatcher  <timothy@apple.com>
3585
3586         Make Brian Burg a WebKit reviewer.
3587
3588         * Scripts/webkitpy/common/config/contributors.json: Move Brian Burg's entry.
3589
3590 2014-09-12  Alexey Proskuryakov  <ap@apple.com>
3591
3592         Multiple EWS or commit bots can pick up processing of the same patch
3593         https://bugs.webkit.org/show_bug.cgi?id=136793
3594
3595         Reviewed by Ryosuke Niwa.
3596
3597         Change timeout from one hour to two hours. This will let bots finish, and in the
3598         unlikely event of a bot being frozen, will only delay patch processing restart by
3599         one hour.
3600
3601         * QueueStatusServer/app.yaml:
3602         * QueueStatusServer/model/activeworkitems.py: (ActiveWorkItems.deactivate_expired):
3603
3604 2014-09-11  Andy Estes  <aestes@apple.com>
3605
3606         [WebKit2] WKImageCreateCGImage crashes when passed a null WKImage
3607         https://bugs.webkit.org/show_bug.cgi?id=136768
3608
3609         Reviewed by Tim Horton.
3610
3611         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3612         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp: Added.
3613         (TestWebKitAPI::TEST):
3614
3615 2014-09-12  Carlos Garcia Campos  <cgarcia@igalia.com>
3616
3617         REGRESSION(r173423): CertificateInfo is never sent to the UI process when using shared secondary process model
3618         https://bugs.webkit.org/show_bug.cgi?id=136669
3619
3620         Reviewed by Antti Koivisto.
3621
3622         * Scripts/run-gtk-tests:
3623         (TestRunner): Unskip SSL test.
3624
3625 2014-09-12  Eric Carlson  <eric.carlson@apple.com>
3626
3627         Strip extraneous AVFoundation and CoreMedia logging
3628         https://bugs.webkit.org/show_bug.cgi?id=136747
3629
3630         Reviewed by Jer Noble.
3631
3632         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3633         (SingleTestRunner._run_compare_test): Allow the port to specify patterns to strip from stderr.
3634
3635         * Scripts/webkitpy/port/base.py:
3636         (Port.stderr_patterns_to_strip): Base class, empty list
3637
3638         * Scripts/webkitpy/port/driver.py:
3639         (DriverOutput.strip_stderror_patterns): Strip the specified patterns from stderr.
3640
3641         * Scripts/webkitpy/port/ios.py:
3642         (IOSSimulatorPort.stderr_patterns_to_strip): iOS patterns - there are none.
3643
3644         * Scripts/webkitpy/port/mac.py:
3645         (MacPort.stderr_patterns_to_strip): CoreMedia and AVFoundation logging we can ignore.
3646
3647
3648 2014-09-11  Michael Saboff  <msaboff@apple.com>
3649
3650         lldb_webkit.py:btjs doesn't work with release builds
3651         https://bugs.webkit.org/show_bug.cgi?id=136760
3652
3653         Reviewed by Jer Noble.
3654
3655         If we can't get a result calling JSC::ExecState::describeFrame(), try calling the
3656         mangled name _ZN3JSC9ExecState13describeFrameEv.  Also cleaned up the handling if
3657         we can't get a valid result from trying either call.  In that case, we fallback to
3658         just showing the PC.  Also added check for both entry points.  If neither is found,
3659         we issue a warning and output the stack trace without JavaScript annotations.
3660
3661         * lldb/lldb_webkit.py:
3662         (btjs):
3663
3664 2014-09-11  Rebecca Hauck  <rhauck@adobe.com>
3665
3666         webkitpy test failures from import-w3c-tests
3667         https://bugs.webkit.org/show_bug.cgi?id=136752
3668
3669         Reviewed by Bem Jones-Bey.
3670
3671         This patch fixes a bug in import-w3c-tests where we were appending
3672         the wrong set of files to the copy_list. This also updates the tests
3673         to clear the failures introduced in the patch for bug 135929.
3674
3675         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3676         (W3CTestConverterTest.test_read_prefixed_property_list):
3677         * Scripts/webkitpy/w3c/test_parser.py:
3678         (TestParser.analyze_test):
3679         (TestParser.support_files):
3680         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3681
3682 2014-09-10  Brent Fulgham  <bfulgham@apple.com>
3683
3684         Blink merge: Speculative fix for windows run-webkit-tests hangs
3685         https://bugs.webkit.org/show_bug.cgi?id=136727
3686
3687         Reviewed by Csaba Osztrogonác.
3688
3689         Merged from Blink (patch by Dirk Pranke):
3690         <https://chromium.googlesource.com/chromium/blink/+/0cdd98d44a20c3951562ccf8b08b1fefba8dac67%5E%21/#F0>
3691
3692         * Scripts/webkitpy/common/system/executive.py:
3693         (Executive.kill_process):
3694
3695 2014-09-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3696
3697         Added myself as a committer.
3698
3699         Unreviewed.
3700
3701         * Scripts/webkitpy/common/config/contributors.json:
3702
3703 2014-09-11  László Langó  <llango.u-szeged@partner.samsung.com>
3704
3705         [JavaScriptCore] Fix FTL on platform EFL.
3706         https://bugs.webkit.org/show_bug.cgi?id=133571
3707
3708         Reviewed by Filip Pizlo.
3709
3710         * efl/install-dependencies: Revert r169181.
3711         * efl/jhbuild.modules: Clone and build a custom branch.
3712         This branch contains some fix for FTL of platform EFL.
3713         The branch is a fork of llvm r206311.
3714
3715 2014-09-10  Tanay C  <tanay.c@samsung.com>
3716
3717         [EFL][WK2] Minibrowser : Shift+Scroll navigate to back or forward url's
3718         https://bugs.webkit.org/show_bug.cgi?id=136698
3719
3720         Reviewed by Gyuyoung Kim.
3721
3722         * MiniBrowser/efl/main.c: Add functionality to support shift + mouse scroll navigation
3723         (on_mouse_wheel): Added.
3724         (window_free):
3725         (window_create):
3726
3727 2014-09-10  Rohit Kumar  <kumar.rohit@samsung.com>
3728
3729         [EFL][WK2] Minibrowser : Add tooltip for toolbar buttons in Minibrowser
3730         https://bugs.webkit.org/show_bug.cgi?id=136284
3731
3732         Reviewed by Gyuyoung Kim.
3733
3734         * MiniBrowser/efl/main.c:
3735         (window_create):
3736
3737 2014-09-10  Rebecca Hauck  <rhauck@adobe.com>
3738
3739         import-w3c-tests doesn't handle relative paths to support files in ref files correctly
3740         https://bugs.webkit.org/show_bug.cgi?id=135929
3741
3742         Reviewed by Bem Jones-Bey.
3743
3744         The recent refactor of the W3C test repo falsified a bunch of assmumptions that
3745         were made when this script was originally written with respect to relative paths
3746         in ref files. This patch updates import-w3c-tests to update paths in ref files if
3747         they move relative to the test file.
3748
3749
3750         * Scripts/webkitpy/w3c/test_converter.py:
3751         (convert_for_webkit):
3752         (_W3CTestConverter.__init__):
3753         (_W3CTestConverter.convert_reference_relpaths):
3754         (_W3CTestConverter.convert_style_data):
3755         (_W3CTestConverter.convert_attributes_if_needed):
3756         * Scripts/webkitpy/w3c/test_importer.py:
3757         (TestImporter.find_importable_tests):
3758         (TestImporter.import_tests):
3759         * Scripts/webkitpy/w3c/test_parser.py:
3760         (TestParser.load_file):
3761         (TestParser.analyze_test):
3762         (TestParser.support_files):
3763
3764 2014-09-10  Michael Catanzaro  <mcatanzaro@igalia.com>
3765
3766         [GTK] allow overwriting destination of download
3767         https://bugs.webkit.org/show_bug.cgi?id=136372
3768
3769         Reviewed by Carlos Garcia Campos.
3770
3771         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3772         (downloadLocalFileSuccessfully): Split from testDownloadLocalFile
3773         (testDownloadLocalFile): Split off downloadLocalFileSuccessfully
3774         (createFileAtDestination): Added
3775         (testDownloadOverwriteDestinationAllowed): Added
3776         (testDownloadOverwriteDestinationDisallowed): Added
3777         (testDownloadLocalFileError): Use new DownloadErrorTest::ExpectedError
3778         (testDownloadRemoteFileError): Use new DownloadErrorTest::ExpectedError
3779         (beforeAll): New tests
3780
3781 2014-08-05  David Farler  <dfarler@apple.com>
3782
3783         iOS Simulator: run-webkit-tests chokes on unterminated UTF-8 when writing a test result
3784         https://bugs.webkit.org/show_bug.cgi?id=135551
3785
3786         Reviewed by Daniel Bates.
3787
3788         Prevent printing invalid Unicode strings going to stderr.
3789         Also, make filesystem.py more tolerant about receiving
3790         Unicode (encoded as UTF-8) when writing to files, in the
3791         rare case that an NSError description will make it to
3792         stderr, such as -[LTRelayController createUniqueApp].
3793
3794         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3795         (-[LTRelayController launchSimulator]): Removed.
3796         (-[LTRelayController createUniqueApp]):
3797         Don't explicitly try to uninstall the app. It is automatically handled
3798         when installing an app with the same bundle identifier.
3799         (-[LTRelayController start]):
3800         (-[LTRelayController bootDevice]): Removed.
3801         The device already boots as a part of starting the simulator. Attempting
3802         to boot a second time may cause spurious stderr output.
3803         * Scripts/webkitpy/port/driver.py:
3804         (IOSSimulatorDriver._setup_environ_for_driver):
3805         Explicitly set DEVELOPER_DIR once so xcode-select isn't called.
3806         Open the iOS Simulator once instead of the LayoutTestRelay trying
3807         to do it.
3808         * Scripts/webkitpy/port/ios.py:
3809         (IOSSimulatorPort._get_crash_log):
3810         Make sure stderr is at least an empty string.
3811         (IOSSimulatorPort):
3812         (IOSSimulatorPort.developer_dir):
3813         New property for setting up DEVELOPER_DIR in the driver environment.
3814
3815 2014-09-09  Dan Bernstein  <mitz@apple.com>
3816
3817         Clean up the MiniBrowser Xcode project
3818         https://bugs.webkit.org/show_bug.cgi?id=136684
3819
3820         Reviewed by Tim Horton.
3821
3822         * MiniBrowser/Configurations/Base.xcconfig: Enabled warnings recommended by Xcode 6.
3823         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed explicit linking against
3824         WebKit2.framework. Upgraded project file version.
3825
3826 2014-09-09  Daniel Bates  <dbates@webkit.org>
3827
3828         svn-{apply, unapply} fails to apply/unapply SVN 1.7 patch that adds new file with property change
3829         https://bugs.webkit.org/show_bug.cgi?id=136379
3830
3831         Reviewed by David Kilzer.
3832
3833         Fixes an issue where svn-{apply, unapply} fail to apply or unapply, respectively,
3834         a patch generated using Subversion 1.7.4 (r1295709) that both adds a new file F
3835         and sets a property on F (say, the executable bit).
3836
3837         * Scripts/svn-apply:
3838         (patch): Only add file if the diff has text chunks.
3839         * Scripts/svn-unapply:
3840         (patch): Only delete added file if the diff has text chunks.
3841
3842 2014-09-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3843
3844         [GTK] Unreviewed GTK gardening.
3845
3846         * Scripts/run-gtk-tests:
3847         (TestRunner): Skip TestSSL:webkit2/WebKitWebView/ssl (fails since r173423).
3848
3849 2014-09-09  Christophe Dumez  <cdumez@apple.com>
3850
3851         Update my email in contributors.json
3852         https://bugs.webkit.org/show_bug.cgi?id=136671
3853
3854         Reviewed by Andreas Kling.
3855
3856         * Scripts/webkitpy/common/config/contributors.json:
3857
3858 2014-09-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3859
3860         [EFL] Enable fixed layout by default
3861         https://bugs.webkit.org/show_bug.cgi?id=136607
3862
3863         Reviewed by Csaba Osztrogonác.
3864
3865         Fixed layout is being used by Tizen platform by default. However, the feature
3866         has still many defects now. So, we need to enable it by default, then should fix
3867         those bugs. 
3868
3869         * MiniBrowser/efl/main.c:
3870
3871 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3872
3873         Remove FILTERS flag
3874         https://bugs.webkit.org/show_bug.cgi?id=136571
3875
3876         Reviewed by Darin Adler.
3877
3878         * Scripts/webkitperl/FeatureList.pm:
3879
3880 2014-09-08  Alexey Proskuryakov  <ap@apple.com>
3881
3882         Dashboard metrics should ignore commits that didn't trigger builds
3883         https://bugs.webkit.org/show_bug.cgi?id=136618
3884
3885         Reviewed by Darin Adler.
3886
3887         Commits that didn't trigger builds are ones like ChangeLog updates, patches for
3888         other platforms etc. It does not make sense to count wait time for these, as it
3889         can be arbitrarily long.
3890
3891         The new algorithm is much slower asymptotically, but it's OK, computers are fast.
3892
3893         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3894         (BuildbotIteration.prototype._parseData): Record changes that triggered the iteration.
3895
3896         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3897         We used to walk the timeline to see which revisions are fully tested, but that's not
3898         correct. A revision that's only tested by a subset of queues finishes independently
3899         of another that's tested by another subset. Now, we just search for the answer for
3900         each revision individually.
3901
3902         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsView.js:
3903         (MetricsView.prototype._update.appendQueueResults): Added worst revision number, which
3904         the analyzer now reports. Removed best time, which is more confusing than meaningful.
3905
3906 2014-09-08  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
3907
3908         Remove EWebLauncher from webkitdirs.pm
3909         https://bugs.webkit.org/show_bug.cgi?id=136622
3910
3911         Reviewed by Gyuyoung Kim.
3912
3913         * Scripts/webkitdirs.pm:
3914         (launcherName):
3915
3916 2014-09-06  Sam Weinig  <sam@webkit.org>
3917
3918         XPCPtr should be converted into an all purpose smart pointer for os_objects
3919         https://bugs.webkit.org/show_bug.cgi?id=136602
3920
3921         Reviewed by Darin Adler.
3922
3923         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3924         * TestWebKitAPI/Tests/WTF/darwin: Added.
3925         * TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Added.
3926         Add basic unit tests for OSObjectPtr.
3927
3928 2014-09-06  Saam Barati  <saambarati1@gmail.com>
3929
3930         Unreviewed. Add myself as a committer.
3931
3932         * Scripts/webkitpy/common/config/contributors.json:
3933
3934 2014-09-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3935
3936         Unreviewed, EFL build fix when SHARED_CORE is on.
3937
3938         * TestWebKitAPI/PlatformEfl.cmake:
3939
3940 2014-09-05  Lucas Forschler  <lforschler@apple.com>
3941
3942         <https://webkit.org/b/136586> Add bots to Apple build/test queues
3943         
3944         Reviewed by Daniel Bates.
3945
3946         * BuildSlaveSupport/build.webkit.org-config/config.json:
3947
3948 2014-09-05  Alexey Proskuryakov  <ap@apple.com>
3949
3950         Buildbot metrics page gives wrong results after a new bot gets added
3951         https://bugs.webkit.org/show_bug.cgi?id=136516
3952
3953         Reviewed by Tim Horton.
3954
3955         Part 2: Fix elapsed times.
3956
3957         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3958         (Analyzer.prototype._countTimes): Made lastTestedRevisionByQueue contain undefined values
3959         until the first build in a queue. This happens to work as needed with _fullyTestedRevisionNumber().
3960
3961 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3962
3963         [SOUP] Implement ResourceResponse::platformSuggestedFilename() when USE(SOUP) is enabled.
3964         https://bugs.webkit.org/show_bug.cgi?id=136562
3965
3966         Reviewed by Martin Robinson.
3967
3968         * Scripts/run-gtk-tests:
3969         (TestRunner): Remove failure expectations for tests that now pass.
3970
3971 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
3972
3973         Dashboard metrics page wastes a lot of time sorting iterations
3974         https://bugs.webkit.org/show_bug.cgi?id=136559
3975
3976         Reviewed by Tim Horton.
3977
3978         Also fixes comments here and there, and adds a missing "var".
3979
3980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3981         (BuildbotIteration.prototype._parseData):
3982         (BuildbotIteration.prototype._updateWithData):
3983         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
3984         (BuildbotQueue.prototype.loadAll):
3985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
3986         (Analyzer.prototype._countTimes):
3987
3988 2014-09-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3989
3990         [GTK] Unreviewed GTK gardening.
3991
3992         * Scripts/run-gtk-tests:
3993         (TestRunner): Skip tests failing since r173272.
3994
3995 2014-09-04  Simon Fraser  <simon.fraser@apple.com>
3996
3997         Add some logging to help diagnose assertions in dumpWebViewAsPixelsAndCompareWithExpected() on bots
3998         https://bugs.webkit.org/show_bug.cgi?id=136561
3999
4000         Reviewed by Tim Horton.
4001         
4002         Log for calloc() and CGBitmapContextCreate() failures.
4003
4004         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
4005         (createBitmapContext):
4006         (createBitmapContextFromWebView):
4007
4008 2014-09-04  Andy Estes  <aestes@apple.com>
4009
4010         Fix the Mac Production build after r173283.
4011
4012         * WebKitTestRunner/config.h: Reverted to defining WEBCORE_EXPORT for now.
4013
4014 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
4015
4016         [Win] webkitpy test suite frequently fails to complete
4017         https://bugs.webkit.org/show_bug.cgi?id=136546
4018
4019         Reviewed by Daniel Bates.
4020
4021         Properly convert the ASCII crash log produced by ntsd into
4022         a unicode string as early as possible so that we handle it
4023         properly when generating our logs and other test support output.
4024
4025         We were mixing ASCII/unicode strings under Windows, which was
4026         causing test system failures when we processed some crash logs.
4027
4028         Also do a better job of handling garbage pid entries in the
4029         Cygwin lock files.
4030
4031         * Scripts/webkitpy/common/system/crashlogs.py:
4032         (CrashLogs._find_newest_log_win): The ntsd '.logopen' command
4033         creates an ASCII file. Decode it as ASCII, not 'utf-8', and
4034         handle the strings as unicode from that point on.
4035         * Scripts/webkitpy/port/http_lock.py:
4036         (HttpLock._current_lock_pid): Add logging and handle case of
4037         the current_pid failing to cleanly convert to 'int'.
4038         * Scripts/webkitpy/port/win.py:
4039         (WinPort): Add 64-bit architecture as a known target for the
4040         Windows build.
4041
4042 2014-09-04  Andy Estes  <aestes@apple.com>
4043
4044         Address additional review feedback after landing r173283.
4045
4046         Reviewed by Daniel Bates.
4047
4048         * DumpRenderTree/config.h: Removed redundant includes.
4049         * TestWebKitAPI/config.h: Ditto.
4050         * WebKitTestRunner/config.h: Ditto.
4051
4052 2014-09-03  Andy Estes  <aestes@apple.com>
4053
4054         [Cocoa] Some WebKitLegacy headers migrated from WebCore incorrectly contain WEBCORE_EXPORT
4055         https://bugs.webkit.org/show_bug.cgi?id=136521
4056
4057         Reviewed by Anders Carlsson.
4058
4059         * DumpRenderTree/config.h: Included <WebCore/PlatformExportMacros.h> instead of defining WEBCORE_EXPORT.
4060         * TestWebKitAPI/config.h: Ditto.
4061         * WebKitTestRunner/config.h: Ditto.
4062
4063 2014-09-04  Alexey Proskuryakov  <ap@apple.com>
4064
4065         REGRESSION: Dashboard metrics page aggregation counts performance bots
4066         https://bugs.webkit.org/show_bug.cgi?id=136539
4067
4068         Reviewed by Tim Horton.
4069
4070         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
4071
4072 2014-09-04  Brent Fulgham  <bfulgham@apple.com>
4073
4074         [Win] Perl test fix.
4075
4076         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Correct test to check for
4077         VersionStamp.exe tool, not just the driver script.
4078
4079 2014-09-04  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
4080
4081         Remove CSS_FILTERS flag
4082         https://bugs.webkit.org/show_bug.cgi?id=136529
4083
4084         Reviewed by Dirk Schulze.
4085
4086         * Scripts/webkitperl/FeatureList.pm:
4087
4088 2014-09-04  Commit Queue  <commit-queue@webkit.org>
4089
4090         Unreviewed, rolling out r173201.
4091         https://bugs.webkit.org/show_bug.cgi?id=136538
4092
4093         Improves the situation but also introduces additional crashes.
4094         (Requested by zdobersek on #webkit).
4095
4096         Reverted changeset:
4097
4098         "GMainLoopSource is exposed to race conditions"
4099         https://bugs.webkit.org/show_bug.cgi?id=135800
4100         http://trac.webkit.org/changeset/173201
4101
4102 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
4103
4104         Buildbot metrics page gives wrong results after a new bot gets added
4105         https://bugs.webkit.org/show_bug.cgi?id=136516
4106
4107         Part 1: Fix red/green counters. Dashboard is considered green at a given time
4108         if all the bots that ever had results before this time are green.
4109
4110         This doesn't (and cannot) address situations where the bot gets removed and then
4111         re-added. It also gives wrong results after a bot gets removed, because it doesn't
4112         know that it was ever displayed on the dashboard.
4113
4114         Reviewed by Darin Adler.
4115
4116         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
4117         (Analyzer.prototype._dashboardIsAllGreen):
4118         (Analyzer.prototype._updateStretchOfRedCounters):
4119         (Analyzer.prototype._countPercentageOfGreen):
4120         (Analyzer.prototype._allQueuesAreSuccessful): Deleted.
4121
4122 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
4123
4124         [Win] Unreviewed test fix.
4125
4126         * Scripts/webkitperl/auto-version_unittest/versionStampTests.pl: Don't fail
4127         test if user doesn't have the VersionStamp.exe program.
4128
4129 2014-09-03  Dana Burkart  <dburkart@apple.com>
4130
4131         Unreviewed. Add myself as a committer.
4132
4133         * Scripts/webkitpy/common/config/contributors.json:
4134
4135 2014-09-03  Alexey Proskuryakov  <ap@apple.com>
4136
4137         build.webkit.org/dashboard performance popover is unstyled
4138         https://bugs.webkit.org/show_bug.cgi?id=136499
4139
4140         Reviewed by Tim Horton.
4141
4142         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
4143         (.performance-popover):
4144         (.performance-popover .dashboard-link):
4145
4146 2014-09-03  Saam Barati  <saambarati1@gmail.com>
4147
4148         Create tests for type profiling
4149         https://bugs.webkit.org/show_bug.cgi?id=136161
4150
4151         Reviewed by Geoffrey Garen.
4152
4153         Have run-javascriptcore-tests run the newly created
4154         tests for the type profiler.
4155
4156         * Scripts/run-javascriptcore-tests:
4157         * Scripts/run-jsc-stress-tests:
4158
4159 2014-09-03  Brent Fulgham  <bfulgham@apple.com>
4160
4161         [Win] Revise test environment for Windows build.
4162         https://bugs.webkit.org/show_bug.cgi?id=136486
4163
4164         Reviewed by David Kilzer.
4165
4166         The various calls to get the Safari path really only have
4167         meaning on the Mac. Other ports get access to the build
4168         and test environment separately, so remove the various
4169         checks in the Safari-specific code to simplify things.
4170
4171         Remove some 64-bit hacks used on Windows now that the
4172         various tools know how to find the 64-bit runtime environment.
4173
4174         * Scripts/run-javascriptcore-tests: 
4175         * Scripts/webkitdirs.pm:
4176         (safariPathFromSafariBundle): Revise to expect Mac.
4177         (installedSafariPath): Ditto.
4178         (safariPath): Ditto.
4179         (appleApplicationSupportPath): Get rid of 64-bit Windows hack.
4180         (setPathForRunningWebKitApp): Get rid of unused SafariPath
4181         argument for Windows runs.
4182
4183 2014-09-03  Dana Burkart  <dburkart@apple.com>
4184
4185         Dashboard should show performance bots.
4186         https://bugs.webkit.org/show_bug.cgi?id=136386
4187
4188         Reviewed by Alexey Proskuryakov.
4189
4190         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
4191         (BuildbotIteration.prototype._parseData.collectPerfTestResults):
4192         (BuildbotIteration.prototype._parseData):
4193         Support possible performance failures.
4194
4195         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
4196         New QueueView to manage the way we present performance data.
4197
4198         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
4199         (BuildbotQueue):
4200         Support new 'performance' and 'performanceTestName' keys.
4201
4202
4203         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
4204         Add performance column to the main page.
4205
4206         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4207         (WebKitBuildbot):
4208         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4209         (body):
4210         Make sure everything fits on 13 inch screens.
4211
4212         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
4213
4214 2014-09-03  Zan Dobersek  <zdobersek@igalia.com>
4215
4216         GMainLoopSource is exposed to race conditions
4217         https://bugs.webkit.org/show_bug.cgi?id=135800
4218
4219         Reviewed by Carlos Garcia Campos.
4220
4221         Add a unit test for GMainLoopSource that tests different
4222         types of rescheduling tasks on already-active sources.
4223
4224         * TestWebKitAPI/PlatformGTK.cmake:
4225         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp: Added.
4226         (GMainLoopSourceTest::GMainLoopSourceTest):
4227         (GMainLoopSourceTest::~GMainLoopSourceTest):
4228         (GMainLoopSourceTest::runLoop):
4229         (GMainLoopSourceTest::finish):
4230         (GMainLoopSourceTest::source):
4231         (testGMainLoopSourceBasicRescheduling):
4232         (testGMainLoopSourceReentrantRescheduling):
4233         (testGMainLoopSourceDifferentThreadRescheduling):
4234         (beforeAll):
4235         (afterAll):
4236         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
4237         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
4238         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
4239         (TestWebKitAPI::GMainLoopSourceTest::finish):
4240         (TestWebKitAPI::GMainLoopSourceTest::source):
4241         (TestWebKitAPI::TEST):
4242
4243 2014-09-02  Simon Fraser  <simon.fraser@apple.com>
4244
4245         Make sure WK1 prefs are initialized in MiniBrowser
4246         https://bugs.webkit.org/show_bug.cgi?id=136465
4247
4248         Reviewed by Tim Horton.
4249         
4250         Call -didChangeSettings from -awakeFromNib for WK1 windows just as we do
4251         for WK2 windows, to make sure that WebPreferences are updated (to get
4252         layer borders to work consistently).
4253
4254         * MiniBrowser/mac/WK1BrowserWindowController.m:
4255         (-[WK1BrowserWindowController awakeFromNib]):
4256
4257 2014-09-02  Renato Nagy  <rnagy@inf.u-szeged.hu>
4258
4259         check-webkit-style should complain about C++ comments in Platform.h
4260         https://bugs.webkit.org/show_bug.cgi?id=133802
4261
4262         Reviewed by Csaba Osztrogonác.
4263
4264         * Scripts/webkitpy/style/checkers/cpp.py:
4265         (check_platformh_comments):
4266         (_process_lines):
4267         (CppChecker):
4268         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4269         (CppStyleTest.test_platformh_comment):
4270
4271 2014-09-02  Brendan Long  <self@brendanlong.com>
4272
4273         [Gtk] Make install-dependencies work on Arch Linux
4274         https://bugs.webkit.org/show_bug.cgi?id=136374
4275
4276         Reviewed by Philippe Normand.
4277
4278         * gtk/install-dependencies: Add dependencies for pacman (Arch Linux).
4279
4280 2014-09-01  Brian J. Burg  <burg@cs.washington.edu>
4281
4282         Provide column numbers to DTrace willExecute/didExecute probes
4283         https://bugs.webkit.org/show_bug.cgi?id=136434
4284
4285         Reviewed by Antti Koivisto.
4286
4287         Create a directory for DTrace scripts. Add an example script that
4288         shows how to use static probes provided by JavaScriptCore's profiler.
4289
4290         * Scripts/dtrace/jsc-trace-profiler-events.d: Added.
4291
4292 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4293
4294         [GTK] [JHBuild] Cyclic dependency between cairo and librsvg.
4295         https://bugs.webkit.org/show_bug.cgi?id=136431
4296
4297         Reviewed by Martin Robinson.
4298
4299         * gtk/jhbuild.modules: Disable cairo SVG testsuite.
4300         Add missing dependencies for librsvg (glib and cairo).
4301
4302 2014-09-01  Carlos Alberto Lopez Perez  <clopez@igalia.com>
4303
4304         [GTK] install-dependencies don't installs dbus-launch that is needed for the API tests.
4305         https://bugs.webkit.org/show_bug.cgi?id=136425
4306
4307         Reviewed by Martin Robinson.