[WPE][GTK] Unreviewed, fix a pervasive typo in the webkit-flatpak script
[WebKit-https.git] / Tools / ChangeLog
1 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         [WPE][GTK] Unreviewed, fix a pervasive typo in the webkit-flatpak script
4
5         * flatpak/flatpakutils.py:
6         (WebkitFlatpak.load_from_args):
7         (WebkitFlatpak.__init__):
8         (WebkitFlatpak.run):
9
10 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
11
12         [WPE][GTK] Unreviewed, update to latest GNOME SDK
13
14         * flatpak/org.webkit.WebKit.yaml:
15
16 2018-09-19  Michael Catanzaro  <mcatanzaro@igalia.com>
17
18         Unreviewed, rolling out r235500.
19
20         Time to switch back to master runtime
21
22         Reverted changeset:
23
24         "Unreviewed, rolling out r235114."
25         https://bugs.webkit.org/show_bug.cgi?id=188731
26         https://trac.webkit.org/changeset/235500
27
28 2018-09-19  Adrian Perez de Castro  <aperez@igalia.com>
29
30         Unreviewed. Add Pablo Saavedra to the list of contributors.
31
32         * Scripts/webkitpy/common/config/contributors.json:
33
34 2018-09-19  Philippe Normand  <pnormand@igalia.com>
35
36         [GStreamer] Add support for AV1 decoding
37         https://bugs.webkit.org/show_bug.cgi?id=189647
38
39         Reviewed by Žan Doberšek.
40
41         Add patches required for AV1 decoding support. They're all
42         upstream already and will be shipped in GStreamer 1.16. The aom
43         GStreamer plugin depends on the aom library for which there's no
44         official release yet.
45
46         * gstreamer/jhbuild.modules:
47         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Added.
48         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Added.
49         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Added. This one is unrelated but an implicit dependency of the next one.
50         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Added.
51         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Added.
52         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Added.
53
54 2018-09-18  Jonathan Bedard  <jbedard@apple.com>
55
56         webkitpy: Clobbering and building occurs multiple times for iOS Simulator ports
57         https://bugs.webkit.org/show_bug.cgi?id=189702
58         <rdar://problem/44541704>
59
60         Reviewed by Aakash Jain.
61
62         * Scripts/webkitpy/layout_tests/controllers/manager.py:
63         (Manager._set_up_run): Move build check and clobbering to run, since set up is
64         run multiple times for iOS simulator.
65         (Manager.run):
66
67 2018-09-18  Chris Dumez  <cdumez@apple.com>
68
69         "DidFirstVisuallyNonEmptyLayout" callback does not get called when restoring a page from PageCache
70         https://bugs.webkit.org/show_bug.cgi?id=189681
71         <rdar://problem/44526171>
72
73         Reviewed by Alex Christensen and Zalan Bujtas.
74
75         Add API test coverage.
76
77         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
78         (TestWebKitAPI::didFinishNavigation):
79         (TestWebKitAPI::TEST):
80
81 2018-09-18  Claudio Saavedra  <csaavedra@igalia.com>
82
83         [WPE] Implement mouse event modifiers
84         https://bugs.webkit.org/show_bug.cgi?id=189697
85
86         Reviewed by Carlos Garcia Campos.
87
88         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
89         (WTR::wkEventModifiersToWPE):
90         (WTR::EventSenderProxy::mouseDown):
91         (WTR::EventSenderProxy::mouseUp):
92
93 2018-09-17  Yusuke Suzuki  <utatane.tea@gmail.com>
94
95         [WTF] Use Semaphore and BinarySemaphore instead of dispatch_semaphore_t
96         https://bugs.webkit.org/show_bug.cgi?id=185339
97
98         Reviewed by Mark Lam.
99
100         * TestWebKitAPI/Tests/WTF/SynchronizedFixedQueue.cpp:
101         (TestWebKitAPI::ToUpperConverter::stopProducing):
102         (TestWebKitAPI::ToUpperConverter::stopConsuming):
103
104 2018-09-17  Simon Fraser  <simon.fraser@apple.com>
105
106         Many modern media control tests leak documents in testing
107         https://bugs.webkit.org/show_bug.cgi?id=189437
108
109         Reviewed by Darin Adler.
110         
111         In order to accurately detect leaks in media controls tests which use lots of
112         SVGImages, we have to:
113         - Fire a zero-delay timer after the postTask, in order for ImagesLoader's m_derefElementTimer
114           to clear references to elements.
115         - Have releaseCriticalMemory() call CachedResourceLoader's garbageCollectDocumentResources()
116           to drop the last handle to the CachedResource for an SVGImage.
117         - Call WKBundleReleaseMemory() after the GC and timer, since we need garbageCollectDocumentResources()
118           to run again after that timer has fired.
119         
120         This should fix most of the spurious leak reports involving SVGImage documents.
121
122         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
123         (WTR::InjectedBundle::reportLiveDocuments):
124         (WTR::InjectedBundle::didReceiveMessageToPage):
125
126 2018-09-17  Chris Dumez  <cdumez@apple.com>
127
128         PSON: window.open() with 'noopener' should only process-swap cross-site, not cross-origin
129         https://bugs.webkit.org/show_bug.cgi?id=189602
130         <rdar://problem/44430549>
131
132         Reviewed by Geoff Garen.
133
134         Add API test coverage.
135
136         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
137
138 2018-09-17  Philippe Normand  <pnormand@igalia.com>
139
140         [JHBuild] Update to GStreamer 1.14.3
141         https://bugs.webkit.org/show_bug.cgi?id=189450
142
143         Reviewed by Xabier Rodriguez-Calvar.
144
145         * gstreamer/jhbuild.modules: Bump GStreamer modules from 1.14.1 to 1.14.3.
146
147 2018-09-17  Philippe Normand  <pnormand@igalia.com>
148
149         [JHBuild] Doesn't check sha256 sums
150         https://bugs.webkit.org/show_bug.cgi?id=189646
151
152         Reviewed by Michael Catanzaro.
153
154         * gstreamer/jhbuild.modules: Properly set the sha256: prefix on hashes.
155
156 2018-09-17  Sihui Liu  <sihui_liu@apple.com>
157
158         Move IndexedDB to Network Process
159         https://bugs.webkit.org/show_bug.cgi?id=189415
160         <rdar://problem/44396973>
161
162         Reviewed by Chris Dumez.
163
164         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
165         (TEST):
166         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
167         (TEST):
168         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
169         (TEST):
170         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
171         (TEST):
172         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
173         (TEST):
174
175 2018-09-08  Darin Adler  <darin@apple.com>
176
177         Streamline JSRetainPtr, fix leaks of JSString and JSGlobalContext
178         https://bugs.webkit.org/show_bug.cgi?id=189455
179
180         Reviewed by Keith Miller.
181
182         There is a lot of copied and pasted code for WebKit vs. Legacy WebKit
183         testing and even for macOS vs. iOS vs. Windows platform-specific code.
184         For now, this patch just makes corresponding changes to the copied code.
185         Later we might get better results by merging more code instead of having
186         all these separate copies.
187
188         * DumpRenderTree/AccessibilityController.cpp:
189         (AccessibilityController::makeWindowObject): Use the adopt function
190         instead of the special Adopt constructor of JSRetainPtr.
191
192         * DumpRenderTree/AccessibilityTextMarker.cpp: Removed unneeded include.
193
194         * DumpRenderTree/AccessibilityUIElement.cpp: Ditto.
195         (allAttributesCallback): Don't adopt at this level; changed the
196         underlying function to return a JSRetainPtr so the adopt is right next
197         to the call to the create or copy function.
198         (attributesOfLinkedUIElementsCallback): Ditto.
199         (attributesOfDocumentLinksCallback): Ditto.
200         (attributesOfChildrenCallback): Ditto.
201         (parameterizedAttributeNamesCallback): Ditto.
202         (attributesOfColumnHeadersCallback): Ditto.
203         (attributesOfRowHeadersCallback): Ditto.
204         (attributesOfColumnsCallback): Ditto.
205         (attributesOfRowsCallback): Ditto.
206         (attributesOfVisibleCellsCallback): Ditto.
207         (attributesOfHeaderCallback): Ditto.
208         (rowIndexRangeCallback): Ditto.
209         (columnIndexRangeCallback): Ditto.
210         (rangeForLineCallback): Ditto.
211         (boundsForRangeCallback): Ditto.
212         (rangeForPositionCallback): Ditto.
213         (stringForRangeCallback): Ditto.
214         (attributedStringForRangeCallback): Ditto.
215         (uiElementCountForSearchPredicateCallback): Use the free adopt
216         function instead of the adopt member function.
217         (uiElementForSearchPredicateCallback): Ditto.
218         (selectTextWithCriteriaCallback): Don't adopt at this level.
219         (attributedStringForElementCallback): Ditto.
220         (setValueCallback): Use free adopt.
221         (stringAttributeValueCallback): Don't adopt at this level.
222         (uiElementArrayAttributeValueCallback): Ditto.
223         (uiElementAttributeValueCallback): Ditto.
224         (stringForTextMarkerRangeCallback): Ditto.
225         (attributedStringForTextMarkerRangeCallback): Ditto.
226         (attributedStringForTextMarkerRangeWithOptionsCallback): Ditto.
227         (getARIADropEffectsCallback): Ditto.
228         (getClassListCallback): Ditto.
229         (getRoleCallback): Ditto.
230         (getSubroleCallback): Ditto.
231         (getRoleDescriptionCallback): Ditto.
232         (getComputedRoleStringCallback): Ditto.
233         (getTitleCallback): Ditto.
234         (getDescriptionCallback): Ditto.
235         (getStringValueCallback): Ditto.
236         (getLanguageCallback): Ditto.
237         (getHelpTextCallback): Ditto.
238         (getOrientationCallback): Ditto.
239         (getPathDescriptionCallback): Ditto.
240         (getSelectedTextRangeCallback): Ditto.
241         (speakAsCallback): Ditto.
242         (getValueDescriptionCallback): Ditto.
243         (getAccessibilityValueCallback): Ditto.
244         (getDocumentEncodingCallback): Ditto.
245         (getDocumentURICallback): Ditto.
246         (getURLCallback): Ditto.
247         (characterAtOffsetCallback): Ditto.
248         (wordAtOffsetCallback): Ditto.
249         (lineAtOffsetCallback): Ditto.
250         (sentenceAtOffsetCallback): Ditto.
251         (stringForSelectionCallback): Ditto.
252         (getIdentifierCallback): Ditto.
253         (getTraitsCallback): Ditto.
254         (supportedActionsCallback): Ditto.
255         (mathPostscriptsDescriptionCallback): Ditto.
256         (mathPrescriptsDescriptionCallback): Ditto.
257         (AccessibilityUIElement::rangeForLine): Updated to return JSRetainPtr.
258         (AccessibilityUIElement::rangeForPosition): Ditto.
259         (AccessibilityUIElement::speakAs): Ditto.
260         (AccessibilityUIElement::pathDescription const): Ditto.
261         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
262         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
263         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
264
265         * DumpRenderTree/AccessibilityUIElement.h: Use JSRetainPtr instead of
266         raw pointers for the results of the functions that create strings.
267         The old way was difficult to get right; the functions didn't even follow
268         the create/copy naming rule.
269
270         * DumpRenderTree/Bindings/CodeGeneratorDumpRenderTree.pm:
271         (_platformTypeConstructor): Use the adopt function instead of the
272         JSRetainPtr adopt constructor. Also nullptr instead of 0.
273
274         * DumpRenderTree/GCController.cpp:
275         (GCController::makeWindowObject): Use adopt function instead of constructor.
276
277         * DumpRenderTree/TestRunner.cpp:
278         (pathToLocalResourceCallback): Use adopt function instead of constructor.
279         (addDisallowedURLCallback): Ditto.
280         (addURLToRedirectCallback): Ditto.
281         (clearApplicationCacheForOriginCallback): Ditto.
282         (applicationCacheDiskUsageForOriginCallback): Ditto.
283         (decodeHostNameCallback): Don't adopt at this level.
284         (encodeHostNameCallback): Ditto.
285         (execCommandCallback): Use adopt instead of JSRetainPtr::adopt.
286         (findStringCallback): Use adopt function instead of constructor.
287         (isCommandEnabledCallback): Ditto.
288         (overridePreferenceCallback): Ditto.
289         (queueLoadCallback): Ditto.
290         (queueLoadHTMLStringCallback): Ditto.
291         (queueLoadingScriptCallback): Ditto.
292         (queueNonLoadingScriptCallback): Ditto.
293         (setAuthenticationPasswordCallback): Ditto.
294         (setAuthenticationUsernameCallback): Ditto.
295         (setDomainRelaxationForbiddenForURLSchemeCallback): Ditto.
296         (setMockGeolocationPositionUnavailableErrorCallback): Ditto.
297         (setPOSIXLocaleCallback): Ditto.
298         (setPersistentUserStyleSheetLocationCallback): Ditto.
299         (setUserStyleSheetLocationCallback): Ditto.
300         (setValueForUserCallback): Ditto.
301         (setWillSendRequestClearHeaderCallback): Ditto.
302         (setPageVisibilityCallback): Ditto.
303         (evaluateInWebInspectorCallback): Ditto.
304         (evaluateScriptInIsolatedWorldCallback): Ditto.
305         (evaluateScriptInIsolatedWorldAndReturnValueCallback): Ditto.
306         (addOriginAccessWhitelistEntryCallback): Ditto.
307         (removeOriginAccessWhitelistEntryCallback): Ditto.
308         (setScrollbarPolicyCallback): Ditto.
309         (addUserScriptCallback): Ditto.
310         (addUserStyleSheetCallback): Ditto.
311         (apiTestNewWindowDataLoadBaseURLCallback): Ditto.
312         (authenticateSessionCallback): Ditto.
313         (getTitleTextDirectionCallback): Ditto.
314         (getInspectorTestStubURLCallback): Ditto.
315         (simulateLegacyWebNotificationClickCallback): Ditto.
316         (setTextDirectionCallback): Ditto.
317         (grantWebNotificationPermissionCallback): Ditto.
318         (denyWebNotificationPermissionCallback): Ditto.
319         (accummulateLogsForChannel): Ditto.
320         (runUIScriptCallback): Ditto.
321         (TestRunner::makeWindowObject): Ditto.
322         (TestRunner::uiScriptDidComplete): Ditto.
323         (TestRunner::setOpenPanelFiles): Ditto.
324
325         * DumpRenderTree/TestRunner.h: Use JSRetainPtr instead of
326         raw pointers for the results of the functions that create strings.
327
328         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
329         (AccessibilityController::platformName const): Use the adopt
330         function instead of the adopt constructor.
331
332         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
333         (createEmptyJSString): Added. This helper function makes reduces the
334         repetitive code to create empty strings.
335         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
336         (AccessibilityUIElement::identifier): Ditto.
337         (AccessibilityUIElement::traits): Ditto.
338         (AccessibilityUIElement::url): Ditto.
339         (AccessibilityUIElement::speakAs): Ditto.
340         (AccessibilityUIElement::stringForSelection): Ditto.
341         (AccessibilityUIElement::stringForRange): Ditto.
342         (AccessibilityUIElement::attributedStringForRange): Ditto.
343         (AccessibilityUIElement::attributedStringForElement): Ditto.
344         (AccessibilityUIElement::pathDescription const): Ditto.
345         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
346         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
347         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
348         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
349         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
350         (AccessibilityUIElement::attributesOfChildren): Ditto.
351         (AccessibilityUIElement::allAttributes): Ditto.
352         (AccessibilityUIElement::stringAttributeValue): Ditto.
353         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
354         (AccessibilityUIElement::role): Ditto.
355         (AccessibilityUIElement::subrole): Ditto.
356         (AccessibilityUIElement::roleDescription): Ditto.
357         (AccessibilityUIElement::computedRoleString): Ditto.
358         (AccessibilityUIElement::title): Ditto.
359         (AccessibilityUIElement::description): Ditto.
360         (AccessibilityUIElement::orientation const): Ditto.
361         (AccessibilityUIElement::stringValue): Ditto.
362         (AccessibilityUIElement::language): Ditto.
363         (AccessibilityUIElement::helpText const): Ditto.
364         (AccessibilityUIElement::valueDescription): Ditto.
365         (AccessibilityUIElement::ariaDropEffects const): Ditto.
366         (AccessibilityUIElement::boundsForRange): Ditto.
367         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
368         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
369         (AccessibilityUIElement::attributesOfColumns): Ditto.
370         (AccessibilityUIElement::attributesOfRows): Ditto.
371         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
372         (AccessibilityUIElement::attributesOfHeader): Ditto.
373         (AccessibilityUIElement::rowIndexRange): Ditto.
374         (AccessibilityUIElement::columnIndexRange): Ditto.
375         (AccessibilityUIElement::selectedTextRange): Ditto.
376         (AccessibilityUIElement::accessibilityValue const): Ditto.
377         (AccessibilityUIElement::documentEncoding): Ditto.
378         (AccessibilityUIElement::documentURI): Ditto.
379         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
380         (AccessibilityUIElement::classList const): Ditto.
381
382         * DumpRenderTree/mac/AccessibilityCommonMac.h: Changed the
383         createJSStringRef method to return a JSRetainPtr.
384         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
385         (-[NSString createJSStringRef]): Ditto.
386         (searchPredicateParameterizedAttributeForSearchCriteria): Use the
387         adopt function instead of the adopt constructor.
388         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
389         (AccessibilityController::platformName const): Ditto.
390
391         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
392         (-[NSString createJSStringRef]): Return a JSRetainPtr.
393         (makeValueRefForValue): Updated for the above, no adopt needed here now.
394         (makeObjectRefForDictionary): Ditto.
395         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
396
397         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
398         (createEmptyJSString): Added. This helper function makes reduces the
399         repetitive code to create empty strings.
400         (concatenateAttributeAndValue): Changed to return a JSRetainPtr.
401         (descriptionOfElements): Ditto.
402         (selectTextParameterizedAttributeForCriteria): Ditto.
403         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
404         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
405         (AccessibilityUIElement::attributesOfChildren): Ditto.
406         (AccessibilityUIElement::allAttributes): Ditto.
407         (AccessibilityUIElement::stringAttributeValue): Ditto.
408         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
409         (AccessibilityUIElement::role): Ditto.
410         (AccessibilityUIElement::subrole): Ditto.
411         (AccessibilityUIElement::roleDescription): Ditto.
412         (AccessibilityUIElement::computedRoleString): Ditto.
413         (AccessibilityUIElement::title): Ditto.
414         (AccessibilityUIElement::description): Ditto.
415         (AccessibilityUIElement::orientation const): Ditto.
416         (AccessibilityUIElement::stringValue): Ditto.
417         (AccessibilityUIElement::language): Ditto.
418         (AccessibilityUIElement::helpText const): Ditto.
419         (AccessibilityUIElement::valueDescription): Ditto.
420         (AccessibilityUIElement::speakAs): Ditto.
421         (AccessibilityUIElement::classList const): Ditto.
422         (AccessibilityUIElement::ariaDropEffects const): Ditto.
423         (AccessibilityUIElement::rangeForLine): Ditto.
424         (AccessibilityUIElement::rangeForPosition): Ditto.
425         (AccessibilityUIElement::boundsForRange): Ditto.
426         (AccessibilityUIElement::stringForRange): Ditto.
427         (AccessibilityUIElement::attributedStringForRange): Ditto.
428         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
429         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
430         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
431         (AccessibilityUIElement::attributesOfColumns): Ditto.
432         (AccessibilityUIElement::attributesOfRows): Ditto.
433         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
434         (AccessibilityUIElement::attributesOfHeader): Ditto.
435         (AccessibilityUIElement::rowIndexRange): Ditto.
436         (AccessibilityUIElement::columnIndexRange): Ditto.
437         (AccessibilityUIElement::pathDescription const): Ditto.
438         (AccessibilityUIElement::selectedTextRange): Ditto.
439         (AccessibilityUIElement::accessibilityValue const): Ditto.
440         (AccessibilityUIElement::documentEncoding): Ditto.
441         (AccessibilityUIElement::documentURI): Ditto.
442         (AccessibilityUIElement::url): Ditto.
443         (AccessibilityUIElement::stringForTextMarkerRange): Ditto.
444         (createJSStringRef): Ditto.
445         (AccessibilityUIElement::attributedStringForTextMarkerRange): Ditto.
446         (AccessibilityUIElement::attributedStringForTextMarkerRangeWithOptions): Ditto.
447         (AccessibilityUIElement::supportedActions): Ditto.
448         (AccessibilityUIElement::mathPostscriptsDescription const): Ditto.
449         (AccessibilityUIElement::mathPrescriptsDescription const): Ditto.
450
451         * DumpRenderTree/mac/FrameLoadDelegate.mm:
452         (-[FrameLoadDelegate didClearWindowObjectForFrame:inIsolatedWorld:]):
453         Use the adopt function instead of the adopt constructor.
454         * DumpRenderTree/mac/TestRunnerMac.mm:
455         (originsArrayToJS): Ditto.
456         (TestRunner::copyDecodedHostName): Return a JSRetainPtr.
457         (TestRunner::copyEncodedHostName): Ditto.
458         (TestRunner::pathToLocalResource): Ditto.
459         (TestRunner::queueLoad): Use adopt function instead of constructor.
460         (TestRunner::findString): Ditto.
461         (TestRunner::inspectorTestStubURL): Return a JSRetainPtr.
462
463         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
464         (AccessibilityController::winNotificationReceived): Use adopt function
465         instead of adopt constructor.
466         (AccessibilityController::platformName const): Ditto.
467
468         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
469         (createEmptyJSString): Added. This helper function makes reduces the
470         repetitive code to create empty strings.
471         (AccessibilityUIElement::allAttributes): Changed to return a JSRetainPtr.
472         (AccessibilityUIElement::attributesOfLinkedUIElements): Ditto.
473         (AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
474         (AccessibilityUIElement::attributesOfChildren): Ditto.
475         (AccessibilityUIElement::parameterizedAttributeNames): Ditto.
476         (AccessibilityUIElement::role): Ditto.
477         (AccessibilityUIElement::subrole): Ditto.
478         (AccessibilityUIElement::roleDescription): Ditto.
479         (AccessibilityUIElement::computedRoleString): Ditto.
480         (AccessibilityUIElement::title): Ditto.
481         (AccessibilityUIElement::description): Ditto.
482         (AccessibilityUIElement::stringValue): Ditto.
483         (AccessibilityUIElement::language): Ditto.
484         (AccessibilityUIElement::helpText const): Ditto.
485         (AccessibilityUIElement::valueDescription): Ditto.
486         (AccessibilityUIElement::ariaDropEffects const): Ditto.
487         (AccessibilityUIElement::orientation const): Ditto.
488         (AccessibilityUIElement::attributesOfColumnHeaders): Ditto.
489         (AccessibilityUIElement::attributesOfRowHeaders): Ditto.
490         (AccessibilityUIElement::attributesOfColumns): Ditto.
491         (AccessibilityUIElement::attributesOfRows): Ditto.
492         (AccessibilityUIElement::attributesOfVisibleCells): Ditto.
493         (AccessibilityUIElement::attributesOfHeader): Ditto.
494         (AccessibilityUIElement::rowIndexRange): Ditto.
495         (AccessibilityUIElement::columnIndexRange): Ditto.
496         (AccessibilityUIElement::boundsForRange): Ditto.
497         (AccessibilityUIElement::stringForRange): Ditto.
498         (AccessibilityUIElement::attributedStringForRange): Ditto.
499         (AccessibilityUIElement::selectTextWithCriteria): Ditto.
500         (AccessibilityUIElement::selectedTextRange): Ditto.
501         (AccessibilityUIElement::stringAttributeValue): Ditto.
502         (AccessibilityUIElement::accessibilityValue const): Ditto.
503         (AccessibilityUIElement::documentEncoding): Ditto.
504         (AccessibilityUIElement::documentURI): Ditto.
505         (AccessibilityUIElement::url): Ditto.
506         (AccessibilityUIElement::classList const): Ditto.
507
508         * DumpRenderTree/win/TestRunnerWin.cpp:
509         (TestRunner::copyDecodedHostName): Changed to return a JSRetainPtr.
510         (TestRunner::copyEncodedHostName): Ditto.
511         (TestRunner::pathToLocalResource): Ditto.
512         (TestRunner::queueLoad): Ditto.
513         (TestRunner::findString): Ditto.
514         (TestRunner::inspectorTestStubURL): Ditto.
515
516         * TestRunnerShared/Bindings/JSWrapper.h:
517         (WTR::setProperty): Use adopt function instead of constructor.
518         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
519         (UIScriptContext::UIScriptContext): Ditto.
520         (UIScriptContext::runUIScript): Ditto.
521         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
522         (WTR::toDeviceOrientation): Ditto.
523
524         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
525         (nsTextCheckingType): Changed this function to not take an rvalue
526         reference to a JSRetainPtr since it doesn't take ownership.
527         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]): Updated
528         for the above change.
529
530         * TestWebKitAPI/JavaScriptTest.cpp:
531         (TestWebKitAPI::javaScriptCallback): Use adopt function instead of
532         adopt member function.
533
534         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp: Removed unneeded include.
535         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm: Ditto.
536         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Use adopt function instead of
537         adopt constructor.
538         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm: Ditto.
539
540         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
541         Removed unneeded includes.
542         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Ditto.
543         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Ditto.
544         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Ditto.
545
546         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
547         (_platformTypeConstructor): Use the adopt function instead of the
548         JSRetainPtr adopt constructor. Also nullptr instead of 0.
549
550         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
551         (WTR::arrayLength): Use adopt function instead of constructor.
552         (WTR::parseModifierArray): Ditto.
553         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
554         (WTR::propertyValue): Ditto.
555         (WTR::dumpPath): Ditto.
556         (WTR::toJS): Ditto.
557         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
558         (WTR::TestRunner::findString): Ditto.
559         (WTR::TestRunner::statisticsDidRunTelemetryCallback): Ditto.
560         (WTR::TestRunner::callDidReceiveAllStorageAccessEntriesCallback): Ditto.
561         (WTR::TestRunner::setOpenPanelFiles): Ditto.
562         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
563         (WTR::AccessibilityController::platformName): Ditto.
564
565         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
566         (-[NSString createJSStringRef]): Return a JSRetainPtr.
567         This fixes storage leaks in many functions below, which were using
568         the create function and putting the value right into a JSRetainPtr
569         without adoption.
570         (WTR::createEmptyJSString): Added. This helper function reduces the
571         repetitive code to create empty strings.
572         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
573         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
574         Use createEmptyJSString, fixing a storage leak due to missing adoption.
575         (WTR::AccessibilityUIElement::attributesOfDocumentLinks): Ditto.
576         (WTR::AccessibilityUIElement::attributesOfChildren): Ditto.
577         (WTR::AccessibilityUIElement::allAttributes): Ditto.
578         (WTR::AccessibilityUIElement::stringAttributeValue): Ditto.
579         (WTR::AccessibilityUIElement::parameterizedAttributeNames): Ditto.
580         (WTR::AccessibilityUIElement::role): Ditto.
581         (WTR::AccessibilityUIElement::subrole): Ditto.
582         (WTR::AccessibilityUIElement::roleDescription): Ditto.
583         (WTR::AccessibilityUIElement::computedRoleString): Ditto.
584         (WTR::AccessibilityUIElement::title): Ditto.
585         (WTR::AccessibilityUIElement::orientation const): Ditto.
586         (WTR::AccessibilityUIElement::language): Ditto.
587         (WTR::AccessibilityUIElement::valueDescription): Ditto.
588         (WTR::AccessibilityUIElement::ariaDropEffects const): Ditto.
589         (WTR::AccessibilityUIElement::boundsForRange): Ditto.
590         (WTR::AccessibilityUIElement::stringForRange): Removed unneeded null check.
591         (WTR::AccessibilityUIElement::attributedStringForRange): Ditto.
592         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
593         Use createEmptyJSString, fixing a storage leak due to missing adoption.
594         (WTR::AccessibilityUIElement::attributesOfRowHeaders): Ditto.
595         (WTR::AccessibilityUIElement::attributesOfColumns): Ditto.
596         (WTR::AccessibilityUIElement::attributesOfRows): Ditto.
597         (WTR::AccessibilityUIElement::attributesOfVisibleCells): Ditto.
598         (WTR::AccessibilityUIElement::attributesOfHeader): Ditto.
599         (WTR::AccessibilityUIElement::selectedTextRange): Ditto.
600         (WTR::AccessibilityUIElement::accessibilityValue const): Ditto.
601         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
602         (WTR::AccessibilityUIElement::documentURI): Ditto.
603         (WTR::AccessibilityUIElement::stringForSelection): Removed unneeded
604         null check.
605         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
606         Use createEmptyJSString, fixing a storage leak due to missing adoption.
607
608         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
609         Use JSRetainPtr for the return value of createJSStringRef.
610         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
611         (-[NSString createJSStringRef]): Ditto.
612         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Use the
613         adopt function instead of the adopt constructor.
614         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
615         (WTR::AccessibilityController::platformName): Ditto
616
617         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
618         (-[NSString createJSStringRef]): Return a JSRetainPtr.
619         (makeValueRefForValue): Updated for above by removing adopt.
620         (makeObjectRefForDictionary): Ditto.
621         (-[AccessibilityNotificationHandler _notificationReceived:]): Ditto.
622
623         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
624         (WTR::createEmptyJSString): Added. This helper function makes reduces the
625         repetitive code to create empty strings.
626         (WTR::concatenateAttributeAndValue): Return a JSRetainPtr.
627         (WTR::descriptionOfElements): Ditto.
628         (WTR::selectTextParameterizedAttributeForCriteria): Ditto.
629         (WTR::AccessibilityUIElement::accessibilityValue const): Use createEmptyJSString,
630         fixing a storage leak due to missing adoption.
631         (WTR::AccessibilityUIElement::documentEncoding): Ditto.
632         (WTR::AccessibilityUIElement::documentURI): Ditto.
633         (WTR::createJSStringRef): Return a JSRetainPtr.
634
635         * WebKitTestRunner/StringFunctions.h:
636         (WTR::toWK): Take a const& to eliminate a little bit of reference count churn.
637         (WTR::toJS): Use the adopt function instead of the constructor.
638
639 2018-09-14  Dean Jackson  <dino@grorg.org>
640
641         Add Justin Michaud.
642
643         * Scripts/webkitpy/common/config/contributors.json:
644
645 2018-09-14  Ryan Haddad  <ryanhaddad@apple.com>
646
647         bots should pass --clobber-old-results to run-webkit-tests
648         https://bugs.webkit.org/show_bug.cgi?id=189623
649
650         Reviewed by Aakash Jain.
651
652         In order to ensure that bots to not produce confusing results due to transient execptions,
653         or run out of space if they continually hit an exception, old layout test results should be clobbered.
654
655         * BuildSlaveSupport/build.webkit.org-config/steps.py:
656         (RunWebKitTests):
657
658 2018-09-13  Ryan Haddad  <ryanhaddad@apple.com>
659
660         Unreviewed, rolling out r235954.
661
662         Breaks the watchOS build.
663
664         Reverted changeset:
665
666         "Move IndexedDB to Network Process"
667         https://bugs.webkit.org/show_bug.cgi?id=189415
668         https://trac.webkit.org/changeset/235954
669
670 2018-09-13  Daniel Bates  <dabates@apple.com>
671
672         Add Copy WebKit Permalink plugin for Sublime Text
673         https://bugs.webkit.org/show_bug.cgi?id=189589
674
675         Rubber-stamped by Joseph Pecoraro.
676
677         Port the Copy WebKit Permalink Automator service to a Sublime Text plugin. Once installed you can
678         use the plugin to copy to the Clipboard a trac.webkit.org hyperlink to the selected line in the
679         active document with or without blame annotations.
680
681         Once installed, you can Control-click (on Mac) or right-click (on Windows and Linux) on a line and
682         choose Copy WebKit Permalink or Copy WebKit Permalink to Blame from the context menu to copy to the
683         Clipboard a permanent hyperlink to the selected line without or with blame annotations, respectively.
684         On Mac you can also invoke the same functionality using the keyboard shortcuts Command + Shift + Control + C
685         and Command + Shift + Control + Option + C, respectively.
686
687         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Context.sublime-menu: Added.
688         * CopyPermalink/Sublime Text/CopyWebKitPermalink/CopyWebKitPermalink.py: Added.
689         * CopyPermalink/Sublime Text/CopyWebKitPermalink/Default (OSX).sublime-keymap: Added.
690         * CopyPermalink/Sublime Text/INSTALL: Added.
691         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/Info.plist: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/Info.plist.
692         * CopyPermalink/Xcode/Copy WebKit Permalink.workflow/Contents/document.wflow: Renamed from Tools/CopyPermalink/Copy WebKit Permalink.workflow/Contents/document.wflow.
693         * CopyPermalink/Xcode/INSTALL: Renamed from Tools/CopyPermalink/README.
694
695 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
696
697         Unreviewed. Fix WebDriver tests after r235225.
698
699         Use wpt serve command to run the http server.
700
701         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
702         (WebDriverW3CWebServer.__init__):
703         (WebDriverW3CWebServer.start):
704         (WebDriverW3CWebServer.stop):
705
706 2018-09-13  Carlos Garcia Campos  <cgarcia@igalia.com>
707
708         [GTK][WPE] Allow to run script dialogs asynchronously in the UI process
709         https://bugs.webkit.org/show_bug.cgi?id=189544
710
711         Reviewed by Michael Catanzaro.
712
713         Add test cases for the new API.
714
715         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
716         (testWebViewJavaScriptDialogs):
717
718 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
719
720         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
721         https://bugs.webkit.org/show_bug.cgi?id=189496
722         <rdar://problem/44370981>
723
724         Unreviewed warning fix.
725
726         r235929 has introduced a new compilation warning:
727         > Tools/ImageDiff/cairo/PlatformImageCairo.cpp:34:70: warning: unused parameter ‘imageSize’ [-Wunused-parameter]
728
729         * ImageDiff/cairo/PlatformImageCairo.cpp:
730         (ImageDiff::PlatformImage::createFromStdin): Removed the variable name.
731
732 2018-09-12  Dan Bernstein  <mitz@apple.com>
733
734         [Cocoa] Complete support for Paste as Quotation
735         https://bugs.webkit.org/show_bug.cgi?id=189504
736
737         Reviewed by Wenson Hsieh.
738
739         * MiniBrowser/mac/MainMenu.xib: Added a Paste as Quotation command in the Edit menu.
740
741 2018-09-12  Sihui Liu  <sihui_liu@apple.com>
742
743         Move IndexedDB to Network Process
744         https://bugs.webkit.org/show_bug.cgi?id=189415
745
746         Reviewed by Geoffrey Garen.
747
748         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
749         (TEST):
750         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
751         (TEST):
752         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBDatabaseProcessKill.mm:
753         (TEST):
754         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBMultiProcess.mm:
755         (TEST):
756         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBPersistence.mm:
757         (TEST):
758
759 2018-09-12  Chris Dumez  <cdumez@apple.com>
760
761         PSON: No process swap on back navigation after URL bar navigation
762         https://bugs.webkit.org/show_bug.cgi?id=189557
763         <rdar://problem/44353108>
764
765         Reviewed by Alex Christensen.
766
767         Add API test coverage.
768
769         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
770
771 2018-09-11  Dean Jackson  <dino@apple.com>
772
773         Header parsing for experimental and internal debug features
774         https://bugs.webkit.org/show_bug.cgi?id=189486
775         <rdar://problem/44320618>
776
777         Reviewed by Tim Horton.
778
779         Keep track of experimental and internal debug features in TestOptions, and
780         allow webkit-test-runner headers to toggle them by name.
781
782         * DumpRenderTree/TestOptions.cpp:
783         (TestOptions::TestOptions):
784         * WebKitTestRunner/TestController.cpp:
785         (WTR::TestController::resetPreferencesToConsistentValues):
786         (WTR::updateTestOptionsFromTestHeader):
787         * WebKitTestRunner/TestOptions.h:
788         (WTR::TestOptions::hasSameInitializationOptions const):
789
790 2018-09-12  Fujii Hironori  <Hironori.Fujii@sony.com>
791
792         [Win][Clang][DumpRenderTree] 0 and nullptr can't be implicitly converted to AccessibilityUIElement
793         https://bugs.webkit.org/show_bug.cgi?id=189492
794
795         Reviewed by Alex Christensen.
796
797         0 and nullptr can't be implicitly converted to
798         AccessibilityUIElement because only Windows port typedefs
799         PlatformUIElement as COMPtr<IAccessible> not a pointer.
800
801         Replaced "return 0" and "return nullptr" with "return { nullptr }".
802
803         * DumpRenderTree/AccessibilityUIElement.cpp:
804         (AccessibilityUIElement::horizontalScrollbar const):
805         (AccessibilityUIElement::verticalScrollbar const):
806         (AccessibilityUIElement::uiElementAttributeValue const):
807         (AccessibilityUIElement::accessibilityElementForTextMarker):
808         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
809         (AccessibilityController::elementAtPoint):
810         (AccessibilityController::accessibleElementById):
811         (AccessibilityController::focusedElement):
812         (AccessibilityController::rootElement):
813         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
814         (AccessibilityUIElement::elementAtPoint):
815         (AccessibilityUIElement::linkedUIElementAtIndex):
816         (AccessibilityUIElement::getChildAtIndex):
817         (AccessibilityUIElement::titleUIElement):
818         (AccessibilityUIElement::parentElement):
819         (AccessibilityUIElement::uiElementForSearchPredicate):
820         (AccessibilityUIElement::cellForColumnAndRow):
821         (AccessibilityUIElement::disclosedRowAtIndex):
822         (AccessibilityUIElement::ariaOwnsElementAtIndex):
823         (AccessibilityUIElement::ariaFlowToElementAtIndex):
824         (AccessibilityUIElement::ariaControlsElementAtIndex):
825         (AccessibilityUIElement::selectedRowAtIndex):
826         (AccessibilityUIElement::rowAtIndex):
827         (AccessibilityUIElement::disclosedByRow):
828         (AccessibilityUIElement::selectedChildAtIndex const):
829
830 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
831
832         FontManagerTests.ChangeFontColorWithColorPanel fails on macOS Sierra
833         https://bugs.webkit.org/show_bug.cgi?id=189382
834
835         Reviewed by Ryosuke Niwa.
836
837         Fix the test by specifying colors in RGB colorspace.
838
839         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
840         (TestWebKitAPI::TEST):
841
842 2018-09-11  Fujii Hironori  <Hironori.Fujii@sony.com>
843
844         [Win][Clang][ImageDiff] Fix compilation error and warning of PlatformImageCairo.cpp
845         https://bugs.webkit.org/show_bug.cgi?id=189496
846
847         Reviewed by Alex Christensen.
848
849         * ImageDiff/cairo/PlatformImageCairo.cpp:
850         (ImageDiff::PlatformImage::createFromStdin): Removed unnecessary ReadContext struct.
851         (ImageDiff::PlatformImage::writeAsPNGToStdout): Use '%lu' format type specifier for unsigned long.
852
853 2018-09-07  Dean Jackson  <dino@apple.com>
854
855         Add and expose Internal features from WebKit
856         https://bugs.webkit.org/show_bug.cgi?id=189442
857         <rdar://problem/44243404>
858
859         Reviewed by Simon Fraser.
860
861         Update MiniBrowser to expose an Internal feature menu.
862
863         * MiniBrowser/mac/AppDelegate.m:
864         (defaultConfiguration):
865         * MiniBrowser/mac/SettingsController.m:
866         (-[SettingsController _populateMenu]):
867         (-[SettingsController validateMenuItem:]):
868         (-[SettingsController toggleExperimentalFeature:]):
869         (-[SettingsController toggleInternalDebugFeature:]):
870
871 2018-09-11  Wenson Hsieh  <wenson_hsieh@apple.com>
872
873         [macOS] [WK2] Support changing foreground colors via color panel
874         https://bugs.webkit.org/show_bug.cgi?id=189382
875         <rdar://problem/44227311>
876
877         Reviewed by Ryosuke Niwa.
878
879         Add an API test that uses NSColorPanel to change the color of selected text, and also apply typing styles when
880         the selection is collapsed. The test also exercises switching between opaque colors (alpha = 1) and transparent
881         colors, as well as making different parts of a word different colors.
882
883         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
884         (-[TestWKWebView collapseToEnd]):
885         (webViewForFontManagerTesting):
886         (TestWebKitAPI::TEST):
887         * TestWebKitAPI/cocoa/TestWKWebView.h:
888
889 == Rolled over to ChangeLog-2018-09-11 ==