Remove some unneeded debugger code.
[WebKit-https.git] / Tools / ChangeLog
1 2014-01-28  Adrian Perez de Castro  <aperez@igalia.com>
2
3         [GTK] Add API to allow setting the process model in WebKitWebContext
4         https://bugs.webkit.org/show_bug.cgi?id=125463
5
6         Reviewed by Carlos Garcia Campos.
7
8         Implements accessors in WebKitWebContext for the process model.
9         The default behavior is unchanged, and a single web process is
10         used. Using WEBKIT_PROCESS_MODEL_ONE_SECONDARY_PROCESS_PER_WEB_VIEW
11         as the process model will make use one web process for each
12         WebKitWebView. This also enables the network process. Setting
13         the process model must be done as early as possible, before the
14         very first web process is spawned.
15
16         * MiniBrowser/gtk/main.c:
17         (main):
18         Enable multiple process mode if the MINIBROWSER_MULTIPROCESS
19         environment variable is defined and not empty.
20         * TestWebKitAPI/GNUmakefile.am:
21         Add new TestMultiprocess test case.
22         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
23         Add new TestMultiprocess test case.
24         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp: Added.
25         (loadChanged):
26         (testMultipleSecondaryProcesses):
27         (initializeWebExtensions):
28         (beforeAll):
29         (afterAll):
30         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
31         (methodCallCallback):
32         Implement the GetProcessIdentifier D-Bus method.
33         (makeBusName):
34         Choose a different bus name when the web extension is used
35         from TestMultiprocess.
36         (webkit_web_extension_initialize_with_user_data):
37         Use makeBusName() to choose the bus name.
38
39 2014-01-28  Carlos Garcia Campos  <cgarcia@igalia.com>
40
41         [SOUP] Remove soupURIToKURL
42         https://bugs.webkit.org/show_bug.cgi?id=127104
43
44         Reviewed by Martin Robinson.
45
46         * TestWebKitAPI/GNUmakefile.am: Add soup cppflags to WebCore unit
47         tests, because URL.h now includes GUniquePtrSoup.h.
48         * TestWebKitAPI/CMakeLists.txt: Ditto.
49         * WebKitTestRunner/PlatformEfl.cmake: Add soup cppflags to WTR,
50         because URL.h now includes GUniquePtrSoup.h.
51
52 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
53
54         [GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols
55         https://bugs.webkit.org/show_bug.cgi?id=127614
56
57         Reviewed by Gustavo Noronha Silva.
58
59         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Bring
60         back the custom URI scheme WebView check.
61
62 2014-01-27  Tim Horton  <timothy_horton@apple.com>
63
64         Revert yet one more tiny part of r162629 that didn't get reverted in r162883
65
66         * WebKitTestRunner/TestController.cpp:
67         (WTR::TestController::pluginLoadPolicy):
68         * WebKitTestRunner/TestController.h:
69
70 2014-01-27  Tim Horton  <timothy_horton@apple.com>
71
72         Revert one more tiny part of r162629 that didn't get reverted in r162883.
73
74         ... which was also causing test failures!
75
76         * WebKitTestRunner/TestController.cpp:
77         (WTR::TestController::createWebViewWithOptions):
78
79 2014-01-27  David Farler  <dfarler@apple.com>
80
81         iOS DumpRenderTree.app dies loading fonts
82         https://bugs.webkit.org/show_bug.cgi?id=127730
83
84         Reviewed by Daniel Bates.
85
86         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
87         - Add Ahem to the __DATA section
88         * DumpRenderTree/mac/DumpRenderTree.mm:
89         (activateFontsIOS):
90         - Load "WeightWatcher100" instead.
91
92 2014-01-27  Alexey Proskuryakov  <ap@apple.com>
93
94         [Mac] Extra logging output from run-safari --no-saved-state
95         https://bugs.webkit.org/show_bug.cgi?id=127732
96
97         Reviewed by Daniel Bates.
98
99         * Scripts/webkitdirs.pm: (argumentsForRunAndDebugMacWebKitApp): Use an option that
100         disables saved state without logging.
101
102 2014-01-27  Tim Horton  <timothy_horton@apple.com>
103
104         Revert the parts of r162629 that add a new pluginLoadPolicy and the context menu item.
105
106         We're leaving the parts that make us use PDFPlugin instead of showing the blocked
107         plugin indicator intact, though.
108
109         * WebKitTestRunner/TestController.cpp:
110         (WTR::TestController::createWebViewWithOptions):
111
112 2014-01-27  Andy Estes  <aestes@apple.com>
113
114         Scrub WebKit API headers of WTF macros
115         https://bugs.webkit.org/show_bug.cgi?id=127706
116
117         Reviewed by David Kilzer.
118
119         * Scripts/check-for-inappropriate-macros-in-external-headers: Modified
120         the regex to require a '(' after the macro name in order to be
121         considered a match. This prevents things like 'ENABLE_SOME_FEATURE'
122         from being flagged as an ENABLE() macro.
123
124 2014-01-27  Commit Queue  <commit-queue@webkit.org>
125
126         Unreviewed, rolling out r162846.
127         http://trac.webkit.org/changeset/162846
128         https://bugs.webkit.org/show_bug.cgi?id=127695
129
130         "Broke the WebKit Bot Watcher's Dashboard; will fix offline"
131         (Requested by dydz on #webkit).
132
133         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
134         (BuildbotIteration.prototype.update.):
135
136 2014-01-27  Daniel Bates  <dabates@apple.com>
137
138         Add support for displaying results from multiple Buildbots on WebKit Bot Watcher's Dashboard
139         https://bugs.webkit.org/show_bug.cgi?id=127564
140
141         Reviewed by Alexey Proskuryakov.
142
143         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
145
146 2014-01-27  Daniel Bates  <dabates@apple.com>
147
148         Teach Buildbot dashboard to parse alternative revision format
149         https://bugs.webkit.org/show_bug.cgi?id=127561
150
151         Reviewed by Alexey Proskuryakov.
152
153         Add support for extracting the OpenSource and Internal revision numbers when Buildbot
154         returns a dictionary for the value of property got_revision.
155
156         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
157         (parseRevisionProperty): Added; parses Buildbot revision property, which can either be a
158         string or a dictionary.
159         (BuildbotIteration.prototype.update.): Modified to call parseRevisionProperty() to determine
160         the OpenSource and Internal revision numbers.
161
162 2014-01-27  Carlos Garcia Campos  <cgarcia@igalia.com>
163
164         [GTK] Implement custom URI schemes with CustomProtocols
165         https://bugs.webkit.org/show_bug.cgi?id=127091
166
167         Reviewed by Gustavo Noronha Silva.
168
169         Temporarily disable the WebKitWebView check until we figure out
170         how to implement it with CustomProtocols.
171
172         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
173
174 2014-01-26  Alexey Proskuryakov  <ap@apple.com>
175
176         REGRESSION(r127412): http/tests/misc/link-rel-icon-beforeload.html is broken.
177
178         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setIconDatabaseEnabled):
179         Fixed an incorrect ifdef.
180
181 2014-01-26  Brendan Long  <b.long@cablelabs.com>
182
183         [GTK] DumpRenderTree prints out suggesting to set WEBKIT_TOP_LEVEL when fonts are missing but doesn't use it.
184         https://bugs.webkit.org/show_bug.cgi?id=110602
185
186         Reviewed by Philippe Normand.
187
188         * DumpRenderTree/gtk/DumpRenderTree.cpp:
189         (getTopLevelPath): Use WEBKIT_TOP_LEVEL environment variable if it exists.
190         (initializeFonts): Fix printing of expected font path (fontPath is guaranteed to be null here).
191
192 2014-01-24  Andy Estes  <aestes@apple.com>
193
194         [iOS] Upstream changes in Tools/DumpRenderTree
195         https://bugs.webkit.org/show_bug.cgi?id=127412
196
197         Reviewed by Simon Fraser.
198
199         Upstream all iOS changes. Added a new target called DumpRenderTree.app,
200         which builds the DumpRenderTree static library into an app bundle as
201         expected by the iOS Simulator.
202
203         * DumpRenderTree/AccessibilityTextMarker.h:
204         * DumpRenderTree/AccessibilityUIElement.h:
205         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
206         * DumpRenderTree/DumpRenderTreeFileDraggingSource.h:
207         * DumpRenderTree/DumpRenderTreePrefix.h:
208         * DumpRenderTree/PixelDumpSupport.cpp:
209         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
210         * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
211         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
212         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
213         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
214         * DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
215         * DumpRenderTree/TestNetscapePlugIn/TestObject.h:
216         * DumpRenderTree/TestNetscapePlugIn/Tests/DocumentOpenInDestroyStream.cpp:
217         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSAfterRemovingPluginElement.cpp:
218         * DumpRenderTree/TestNetscapePlugIn/Tests/GetUserAgentWithNullNPPFromNPPNew.cpp:
219         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
220         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
221         * DumpRenderTree/TestNetscapePlugIn/Tests/NullNPPGetValuePointer.cpp:
222         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
223         * DumpRenderTree/TestNetscapePlugIn/Tests/PluginScriptableNPObjectInvokeDefault.cpp:
224         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
225         * DumpRenderTree/TestRunner.cpp:
226         * DumpRenderTree/TestRunner.h:
227         * DumpRenderTree/cg/ImageDiffCG.cpp:
228         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
229         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
230         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
231         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h: Added.
232         * DumpRenderTree/ios/DumpRenderTreeBrowserView.mm: Added.
233         * DumpRenderTree/ios/Info.plist: Added.
234         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport.c: Added.
235         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupportPregenerated.pm: Added.
236         * DumpRenderTree/ios/PerlSupport/DumpRenderTreeSupport_wrapPregenerated.c: Added.
237         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Changes: Added.
238         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/IPhoneSimulatorNotification.xs: Added.
239         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/MANIFEST: Added.
240         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL: Added.
241         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/README: Added.
242         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm: Added.
243         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/ppport.h: Added.
244         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/t/IPhoneSimulatorNotification.t: Added.
245         * DumpRenderTree/ios/PerlSupport/Makefile: Added.
246         * DumpRenderTree/ios/PixelDumpSupportIOS.mm: Added.
247         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
248         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
249         * DumpRenderTree/mac/AppleScriptController.m:
250         * DumpRenderTree/mac/Configurations/Base.xcconfig:
251         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
252         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
253         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Added.
254         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
255         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
256         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig: Added.
257         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
258         * DumpRenderTree/mac/DumpRenderTree.mm:
259         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
260         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
261         * DumpRenderTree/mac/DumpRenderTreeMac.h:
262         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
263         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
264         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
265         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
266         * DumpRenderTree/mac/EditingDelegate.h:
267         * DumpRenderTree/mac/EventSendingController.h:
268         * DumpRenderTree/mac/EventSendingController.mm:
269         * DumpRenderTree/mac/FrameLoadDelegate.mm:
270         * DumpRenderTree/mac/HistoryDelegate.h:
271         * DumpRenderTree/mac/LayoutTestHelper.m:
272         * DumpRenderTree/mac/MockGeolocationProvider.mm:
273         * DumpRenderTree/mac/NavigationController.h:
274         * DumpRenderTree/mac/ObjCPlugin.h:
275         * DumpRenderTree/mac/ObjCPlugin.m:
276         * DumpRenderTree/mac/ObjCPluginFunction.h:
277         * DumpRenderTree/mac/PolicyDelegate.h:
278         * DumpRenderTree/mac/ResourceLoadDelegate.h:
279         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
280         * DumpRenderTree/mac/TestRunnerMac.mm:
281         * DumpRenderTree/mac/TextInputController.h:
282         * DumpRenderTree/mac/TextInputController.m:
283         * DumpRenderTree/mac/UIDelegate.h:
284         * DumpRenderTree/mac/UIDelegate.mm:
285
286 2014-01-25  Darin Adler  <darin@apple.com>
287
288         Call deprecatedCharacters instead of characters at more call sites
289         https://bugs.webkit.org/show_bug.cgi?id=127631
290
291         Reviewed by Sam Weinig.
292
293         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
294         (TestWebKitAPI::expectBuilderContent):
295         (TestWebKitAPI::expectEmpty):
296         (TestWebKitAPI::TEST):
297         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
298         (TestWebKitAPI::TEST):
299         Use the new name.
300
301 2014-01-25  Anders Carlsson  <andersca@apple.com>
302
303         Modernize HashTable threading code
304         https://bugs.webkit.org/show_bug.cgi?id=127621
305
306         Reviewed by Darin Adler.
307
308         Explicitly include headers that used to be brought in by HashTable.h
309
310         * DumpRenderTree/JavaScriptThreading.cpp:
311
312 2014-01-24  Eric Carlson  <eric.carlson@apple.com>
313
314         Unreviewed. Add Philip Jägenstedt to watch and contributor lists.
315
316         * Scripts/webkitpy/common/config/contributors.json:
317         * Scripts/webkitpy/common/config/watchlist:
318
319 2014-01-23  David Farler  <dfarler@apple.com>
320
321         Make WebKitTestRunner work with iOS
322         https://bugs.webkit.org/show_bug.cgi?id=127448
323
324         Reviewed by Simon Fraser.
325
326         Combined patch from Simon below with some additional xcconfig cleanups,
327         rebasing and stubbing out a couple of new functions that popped up
328         since then.
329
330         2013-12-03  Simon Fraser  <simon.fraser@apple.com>
331
332                 <rdar://problem/15515469> Get WebKitTestRunner working on iOS
333
334                 Get WebKitTestRunner limping on iOS. Main parts:
335                 - Stub out lots of accessibility-related functions.
336                 - Stub out EventSender
337                 - Create target to make a bundled app that runs in the simulator,
338                   and copy the injected bundle library into it.
339                 - Make a UIWindow and WKView to load tests in
340
341                 It runs, load tests, and dumps results to output. More work will be
342                 required once we can execute it via the webkitpy scripts.
343
344         * WebKitTestRunner/Configurations/Base.xcconfig:
345         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
346         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
347         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
348         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm: Added.
349         (WTR::AccessibilityController::addNotificationListener):
350         (WTR::AccessibilityController::removeNotificationListener):
351         (WTR::AccessibilityController::platformName):
352         (WTR::AccessibilityController::logAccessibilityEvents):
353         (WTR::AccessibilityController::resetToConsistentState):
354         (WTR::findAccessibleObjectById):
355         (WTR::AccessibilityController::accessibleElementById):
356         * WebKitTestRunner/InjectedBundle/ios/AccessibilityNotificationHandler.h: Added.
357         * WebKitTestRunner/InjectedBundle/ios/AccessibilityTextMarkerIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
358         (WTR::AccessibilityTextMarker::isEqual):
359         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm: Added.
360         (WTR::AccessibilityUIElement::AccessibilityUIElement):
361         (WTR::AccessibilityUIElement::~AccessibilityUIElement):
362         (WTR::AccessibilityUIElement::isEqual):
363         (WTR::AccessibilityUIElement::getLinkedUIElements):
364         (WTR::AccessibilityUIElement::getDocumentLinks):
365         (WTR::AccessibilityUIElement::getChildren):
366         (WTR::AccessibilityUIElement::getChildrenWithRange):
367         (WTR::AccessibilityUIElement::childrenCount):
368         (WTR::AccessibilityUIElement::elementAtPoint):
369         (WTR::AccessibilityUIElement::indexOfChild):
370         (WTR::AccessibilityUIElement::childAtIndex):
371         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
372         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
373         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
374         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
375         (WTR::AccessibilityUIElement::rowAtIndex):
376         (WTR::AccessibilityUIElement::selectedChildAtIndex):
377         (WTR::AccessibilityUIElement::selectedChildrenCount):
378         (WTR::AccessibilityUIElement::selectedRowAtIndex):
379         (WTR::AccessibilityUIElement::titleUIElement):
380         (WTR::AccessibilityUIElement::parentElement):
381         (WTR::AccessibilityUIElement::disclosedByRow):
382         (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
383         (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
384         (WTR::AccessibilityUIElement::attributesOfChildren):
385         (WTR::AccessibilityUIElement::allAttributes):
386         (WTR::AccessibilityUIElement::stringAttributeValue):
387         (WTR::AccessibilityUIElement::numberAttributeValue):
388         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue):
389         (WTR::AccessibilityUIElement::uiElementAttributeValue):
390         (WTR::AccessibilityUIElement::boolAttributeValue):
391         (WTR::AccessibilityUIElement::isAttributeSettable):
392         (WTR::AccessibilityUIElement::isAttributeSupported):
393         (WTR::AccessibilityUIElement::parameterizedAttributeNames):
394         (WTR::AccessibilityUIElement::role):
395         (WTR::AccessibilityUIElement::subrole):
396         (WTR::AccessibilityUIElement::roleDescription):
397         (WTR::AccessibilityUIElement::title):
398         (WTR::AccessibilityUIElement::description):
399         (WTR::AccessibilityUIElement::orientation):
400         (WTR::AccessibilityUIElement::stringValue):
401         (WTR::AccessibilityUIElement::language):
402         (WTR::AccessibilityUIElement::helpText):
403         (WTR::AccessibilityUIElement::x):
404         (WTR::AccessibilityUIElement::y):
405         (WTR::AccessibilityUIElement::width):
406         (WTR::AccessibilityUIElement::height):
407         (WTR::AccessibilityUIElement::clickPointX):
408         (WTR::AccessibilityUIElement::clickPointY):
409         (WTR::AccessibilityUIElement::intValue):
410         (WTR::AccessibilityUIElement::minValue):
411         (WTR::AccessibilityUIElement::maxValue):
412         (WTR::AccessibilityUIElement::valueDescription):
413         (WTR::AccessibilityUIElement::insertionPointLineNumber):
414         (WTR::AccessibilityUIElement::isPressActionSupported):
415         (WTR::AccessibilityUIElement::isIncrementActionSupported):
416         (WTR::AccessibilityUIElement::isDecrementActionSupported):
417         (WTR::AccessibilityUIElement::isEnabled):
418         (WTR::AccessibilityUIElement::isRequired):
419         (WTR::AccessibilityUIElement::isFocused):
420         (WTR::AccessibilityUIElement::isSelected):
421         (WTR::AccessibilityUIElement::isSelectedOptionActive):
422         (WTR::AccessibilityUIElement::isIndeterminate):
423         (WTR::AccessibilityUIElement::isExpanded):
424         (WTR::AccessibilityUIElement::isChecked):
425         (WTR::AccessibilityUIElement::hierarchicalLevel):
426         (WTR::AccessibilityUIElement::classList):
427         (WTR::AccessibilityUIElement::speak):
428         (WTR::AccessibilityUIElement::ariaIsGrabbed):
429         (WTR::AccessibilityUIElement::ariaDropEffects):
430         (WTR::AccessibilityUIElement::lineForIndex):
431         (WTR::AccessibilityUIElement::rangeForLine):
432         (WTR::AccessibilityUIElement::rangeForPosition):
433         (WTR::AccessibilityUIElement::boundsForRange):
434         (WTR::AccessibilityUIElement::stringForRange):
435         (WTR::AccessibilityUIElement::attributedStringForRange):
436         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
437         (WTR::uiElementCountForSearchPredicate):
438         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
439         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
440         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
441         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
442         (WTR::AccessibilityUIElement::attributesOfColumns):
443         (WTR::AccessibilityUIElement::attributesOfRows):
444         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
445         (WTR::AccessibilityUIElement::attributesOfHeader):
446         (WTR::AccessibilityUIElement::rowCount):
447         (WTR::AccessibilityUIElement::columnCount):
448         (WTR::AccessibilityUIElement::indexInTable):
449         (WTR::AccessibilityUIElement::rowIndexRange):
450         (WTR::AccessibilityUIElement::columnIndexRange):
451         (WTR::AccessibilityUIElement::cellForColumnAndRow):
452         (WTR::AccessibilityUIElement::horizontalScrollbar):
453         (WTR::AccessibilityUIElement::verticalScrollbar):
454         (WTR::AccessibilityUIElement::scrollToMakeVisible):
455         (WTR::AccessibilityUIElement::selectedTextRange):
456         (WTR::AccessibilityUIElement::setSelectedTextRange):
457         (WTR::AccessibilityUIElement::increment):
458         (WTR::AccessibilityUIElement::decrement):
459         (WTR::AccessibilityUIElement::showMenu):
460         (WTR::AccessibilityUIElement::press):
461         (WTR::AccessibilityUIElement::setSelectedChild):
462         (WTR::AccessibilityUIElement::accessibilityValue):
463         (WTR::AccessibilityUIElement::documentEncoding):
464         (WTR::AccessibilityUIElement::documentURI):
465         (WTR::AccessibilityUIElement::url):
466         (WTR::AccessibilityUIElement::addNotificationListener):
467         (WTR::AccessibilityUIElement::removeNotificationListener):
468         (WTR::AccessibilityUIElement::isFocusable):
469         (WTR::AccessibilityUIElement::isSelectable):
470         (WTR::AccessibilityUIElement::isMultiSelectable):
471         (WTR::AccessibilityUIElement::isVisible):
472         (WTR::AccessibilityUIElement::isOffScreen):
473         (WTR::AccessibilityUIElement::isCollapsed):
474         (WTR::AccessibilityUIElement::isIgnored):
475         (WTR::AccessibilityUIElement::hasPopup):
476         (WTR::AccessibilityUIElement::takeFocus):
477         (WTR::AccessibilityUIElement::takeSelection):
478         (WTR::AccessibilityUIElement::addSelection):
479         (WTR::AccessibilityUIElement::removeSelection):
480         (WTR::AccessibilityUIElement::textMarkerRangeForElement):
481         (WTR::AccessibilityUIElement::textMarkerRangeLength):
482         (WTR::AccessibilityUIElement::previousTextMarker):
483         (WTR::AccessibilityUIElement::nextTextMarker):
484         (WTR::AccessibilityUIElement::stringForTextMarkerRange):
485         (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
486         (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
487         (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
488         (WTR::AccessibilityUIElement::endTextMarkerForBounds):
489         (WTR::AccessibilityUIElement::startTextMarkerForBounds):
490         (WTR::AccessibilityUIElement::textMarkerForPoint):
491         (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
492         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
493         (WTR::AccessibilityUIElement::indexForTextMarker):
494         (WTR::AccessibilityUIElement::isTextMarkerValid):
495         (WTR::AccessibilityUIElement::textMarkerForIndex):
496         (WTR::AccessibilityUIElement::startTextMarker):
497         (WTR::AccessibilityUIElement::endTextMarker):
498         (WTR::AccessibilityUIElement::mathPostscriptsDescription):
499         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
500         (WTR::AccessibilityUIElement::pathDescription):
501         (WTR::AccessibilityUIElement::supportedActions):
502         * WebKitTestRunner/InjectedBundle/ios/ActivateFontsIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
503         (WTR::activateFonts):
504         * WebKitTestRunner/InjectedBundle/ios/EventSenderProxyIOS.mm: Added.
505         (WTR::EventSenderProxy::EventSenderProxy):
506         (WTR::EventSenderProxy::~EventSenderProxy):
507         (WTR::EventSenderProxy::updateClickCountForButton):
508         (WTR::EventSenderProxy::mouseDown):
509         (WTR::EventSenderProxy::mouseUp):
510         (WTR::EventSenderProxy::mouseMoveTo):
511         (WTR::EventSenderProxy::leapForward):
512         (WTR::EventSenderProxy::keyDown):
513         (WTR::EventSenderProxy::mouseScrollBy):
514         (WTR::EventSenderProxy::continuousMouseScrollBy):
515         (WTR::EventSenderProxy::addTouchPoint):
516         (WTR::EventSenderProxy::updateTouchPoint):
517         (WTR::EventSenderProxy::setTouchModifier):
518         (WTR::EventSenderProxy::setTouchPointRadius):
519         (WTR::EventSenderProxy::touchStart):
520         (WTR::EventSenderProxy::touchMove):
521         (WTR::EventSenderProxy::touchEnd):
522         (WTR::EventSenderProxy::touchCancel):
523         (WTR::EventSenderProxy::clearTouchPoints):
524         (WTR::EventSenderProxy::releaseTouchPoint):
525         (WTR::EventSenderProxy::cancelTouchPoint):
526         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
527         (WTR::InjectedBundle::platformInitialize):
528         * WebKitTestRunner/InjectedBundle/ios/InjectedBundlePageIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
529         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
530         * WebKitTestRunner/Makefile:
531         * WebKitTestRunner/TestController.cpp:
532         (WTR::TestController::initialize):
533         * WebKitTestRunner/TestController.h:
534         * WebKitTestRunner/TestInvocation.cpp:
535         (WTR::TestInvocation::invoke):
536         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
537         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
538         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.h: Added.
539         * WebKitTestRunner/WebKitTestRunnerApp/AppDelegate.m: Added.
540         (-[AppDelegate application:didFinishLaunchingWithOptions:]):
541         (-[AppDelegate applicationWillResignActive:]):
542         (-[AppDelegate applicationDidEnterBackground:]):
543         (-[AppDelegate applicationWillEnterForeground:]):
544         (-[AppDelegate applicationDidBecomeActive:]):
545         (-[AppDelegate applicationWillTerminate:]):
546         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/AppIcon.appiconset/Contents.json: Added.
547         * WebKitTestRunner/WebKitTestRunnerApp/Images.xcassets/LaunchImage.launchimage/Contents.json: Added.
548         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist: Added.
549         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Prefix.pch: Added.
550         * WebKitTestRunner/WebKitTestRunnerApp/en.lproj/InfoPlist.strings: Added.
551         * WebKitTestRunner/WebKitTestRunnerApp/main.m: Added.
552         (main):
553         * WebKitTestRunner/WebKitTestRunnerAppTests-Info.plist: Added.
554         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests-Info.plist: Added.
555         * WebKitTestRunner/WebKitTestRunnerAppTests/WebKitTestRunnerAppTests.m: Added.
556         (-[WebKitTestRunnerAppTests setUp]):
557         (-[WebKitTestRunnerAppTests tearDown]):
558         (-[WebKitTestRunnerAppTests testExample]):
559         * WebKitTestRunner/WebKitTestRunnerAppTests/en.lproj/InfoPlist.strings: Added.
560         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
561         * WebKitTestRunner/cg/TestInvocationCG.cpp:
562         * WebKitTestRunner/iOS.xcconfig: Added.
563         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Added.
564         (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]):
565         (-[TestRunnerWKView _shouldUseTiledDrawingArea]):
566         (-[WebKitTestRunnerWindow isKeyWindow]):
567         (-[WebKitTestRunnerWindow setFrameOrigin:]):
568         (-[WebKitTestRunnerWindow setFrame:]):
569         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
570         (-[WebKitTestRunnerWindow backingScaleFactor]):
571         (WTR::PlatformWebView::PlatformWebView):
572         (WTR::PlatformWebView::resizeTo):
573         (WTR::PlatformWebView::~PlatformWebView):
574         (WTR::PlatformWebView::page):
575         (WTR::PlatformWebView::focus):
576         (WTR::PlatformWebView::windowFrame):
577         (WTR::PlatformWebView::setWindowFrame):
578         (WTR::PlatformWebView::didInitializeClients):
579         (WTR::PlatformWebView::addChromeInputField):
580         (WTR::PlatformWebView::removeChromeInputField):
581         (WTR::PlatformWebView::makeWebViewFirstResponder):
582         (WTR::PlatformWebView::windowSnapshotImage):
583         (WTR::PlatformWebView::viewSupportsOptions):
584         * WebKitTestRunner/ios/TestControllerIOS.mm: Added.
585         (WTR::TestController::notifyDone):
586         (WTR::TestController::platformInitialize):
587         (WTR::TestController::platformDestroy):
588         (WTR::TestController::initializeInjectedBundlePath):
589         (WTR::TestController::initializeTestPluginDirectory):
590         (WTR::TestController::platformRunUntil):
591         (WTR::TestController::platformInitializeContext):
592         (WTR::TestController::runModal):
593         (WTR::TestController::platformLibraryPathForTesting):
594         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
595         (createCFURLResponseFromResponseData):
596         (supportedNonImageMIMETypes):
597         * WebKitTestRunner/ios/mainIOS.mm: Copied from Tools/WebKitTestRunner/WebKitTestRunnerPrefix.h.
598         (-[WebKitTestRunnerApp _runTestController]):
599         (-[WebKitTestRunnerApp applicationDidFinishLaunching:]):
600         (main):
601
602 2014-01-24  Enrique Ocaña González  <eocanha@igalia.com>
603
604         [GTK] Put cache files in XDG_CACHE_HOME
605         https://bugs.webkit.org/show_bug.cgi?id=123458
606
607         Reviewed by Martin Robinson.
608
609         * GtkLauncher/main.c:
610         (createBrowser):
611
612 2014-01-23  Max Vujovic  <mvujovic@adobe.com>
613
614         Remove CSS Custom Filters code and tests
615         https://bugs.webkit.org/show_bug.cgi?id=127382
616
617         Reviewed by Simon Fraser.
618
619         * DumpRenderTree/gtk/DumpRenderTree.cpp:
620         (resetDefaultsToConsistentValues):
621         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
622         (TestRunner::overridePreference):
623
624 2014-01-23  Tim Horton  <timothy_horton@apple.com>
625
626         PDFPlugin: Use PDFPlugin even if there's an external plugin installed, if it's blocked
627         https://bugs.webkit.org/show_bug.cgi?id=127415
628         <rdar://problem/12482452>
629
630         Reviewed by Sam Weinig.
631
632         Adopt the new page loader client plugin load callback.
633
634         * WebKitTestRunner/TestController.cpp:
635         (WTR::TestController::createWebViewWithOptions):
636         (WTR::TestController::pluginLoadPolicy):
637         * WebKitTestRunner/TestController.h:
638
639 2014-01-23  peavo@outlook.com  <peavo@outlook.com>
640
641         [Curl] There is no way to specify cache folder.
642         https://bugs.webkit.org/show_bug.cgi?id=125028
643
644         Reviewed by Brent Fulgham.
645
646         Enable disc cache in WinLauncher by setting cache folder location.
647
648         * WinLauncher/WinLauncher.cpp:
649         (getAppDataFolder): Added function to get app data folder.
650         (setCacheFolder): Added function to set cache folder.
651         (createCrashReport): Use new getAppDataFolder function.
652         (wWinMain): Use function setCacheFolder to set cache folder location.
653
654 2014-01-23  Daniel Bates  <dabates@apple.com>
655
656         build-webkit --sdk=iphonesimulator doesn't think it's building iOS
657         https://bugs.webkit.org/show_bug.cgi?id=127379
658
659         Reviewed by Simon Fraser.
660
661         Teach build-webkit to recognize --sdk=X.
662
663         Currently, build-webkit recognizes --sdk X to specify X as the Xcode SDK to use, which is also
664         considered when determining the WebKit port to build. But build-webkit advertises --sdk=X in its
665         help message. We should teach build-webkit to recognize both --sdk X and --sdk=X to make its handling
666         of --sdk more consistent with the handling of other build-webkit options that take a value (e.g. --prefix).
667
668         * Scripts/webkitdirs.pm:
669         (checkForArgumentAndRemoveFromArrayRefGettingValue): Added.
670         (checkForArgumentAndRemoveFromARGVGettingValue): Modified to call checkForArgumentAndRemoveFromArrayRefGettingValue().
671         * Scripts/webkitperl/webkitdirs_unittest/checkForArgumentAndRemoveFromArrayRefGettingValue.pl: Added.
672
673 2014-01-23  Commit Queue  <commit-queue@webkit.org>
674
675         Unreviewed, rolling out r162612.
676         http://trac.webkit.org/changeset/162612
677         https://bugs.webkit.org/show_bug.cgi?id=127488
678
679         broke the build (Requested by mhahnenberg on #webkit).
680
681         * Scripts/build-jsc:
682         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Removed.
683         * jsc-cli/jsc-cli/CLIInstance.h: Removed.
684         * jsc-cli/jsc-cli/CLIInstance.m: Removed.
685         * jsc-cli/jsc-cli/JSModule.h: Removed.
686         * jsc-cli/jsc-cli/JSModule.m: Removed.
687         * jsc-cli/jsc-cli/JSRunLoopThread.h: Removed.
688         * jsc-cli/jsc-cli/JSRunLoopThread.m: Removed.
689         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Removed.
690         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Removed.
691         * jsc-cli/jsc-cli/RunLoopThread.h: Removed.
692         * jsc-cli/jsc-cli/RunLoopThread.m: Removed.
693         * jsc-cli/jsc-cli/ScriptInputSource.h: Removed.
694         * jsc-cli/jsc-cli/ScriptInputSource.m: Removed.
695         * jsc-cli/jsc-cli/main.m: Removed.
696
697 2014-01-23  Mark Hahnenberg  <mhahnenberg@apple.com>
698
699         Basic framework for a modern jsc CLI
700         https://bugs.webkit.org/show_bug.cgi?id=127435
701
702         Reviewed by Geoffrey Garen.
703
704         The most basic components of a modern jsc command line interface consist of the following:
705
706         - A simple REPL to enter commands and receive results
707         - The ability to define a module (which consists of various internal methods as well as a 
708           set of externally visible methods)
709         - The ability to load other modules at runtime
710         - The ability to interact with the underlying platform to perform various "privileged" 
711           functions (e.g. opening files, printing to the stdout, etc.)
712         
713         The basic architecture will look something like the following:
714         - If the tool is run in REPL mode (i.e. no command line arguments), it will start the REPL 
715           on the main thread and start a secondary thread with a run loop to handle various inputs 
716           from the REPL thread.
717         - If the tool is given a script to run, it will evaluate that script (and any scripts that 
718           it might transitively load) within the run loop on the secondary thread while the main 
719           thread blocks until it has completed.
720
721         * Scripts/build-jsc:
722         * jsc-cli: Added.
723         * jsc-cli/jsc-cli: Added.
724         * jsc-cli/jsc-cli.xcodeproj: Added.
725         * jsc-cli/jsc-cli.xcodeproj/project.pbxproj: Added.
726         * jsc-cli/jsc-cli/CLIInstance.h: Added.
727         * jsc-cli/jsc-cli/CLIInstance.m: Added.
728         (-[CLIInstance init]):
729         (-[CLIInstance loadFile:]):
730         (-[CLIInstance run]):
731         * jsc-cli/jsc-cli/JSModule.h: Added.
732         * jsc-cli/jsc-cli/JSModule.m: Added.
733         (coreModules):
734         (isCoreModule):
735         (classForModule):
736         (coreModuleFullPath):
737         (resolveModuleAsFile):
738         (resolveModuleAsDirectory):
739         (nodeModulePaths):
740         (resolveAsNodeModule):
741         (+[JSModule resolve:atPath:]):
742         (globalModuleCache):
743         (isCached):
744         (cachedModule):
745         (cacheModule):
746         (+[JSModule require:atPath:]):
747         (+[JSModule require:atPath:inContext:]):
748         (-[JSModule platformObjectInContext:]):
749         (-[JSModule initWithId:filename:context:]):
750         (-[JSModule dealloc]):
751         (-[JSModule didStartLoading]):
752         (-[JSModule didFinishLoading]):
753         (-[JSModule require:]):
754         (-[JSModule exports]):
755         * jsc-cli/jsc-cli/JSRunLoopThread.h: Added.
756         * jsc-cli/jsc-cli/JSRunLoopThread.m: Added.
757         (jsThreadMain):
758         (+[JSRunLoopThread threadMain]):
759         (-[JSRunLoopThread initWithFiles:andContext:]):
760         (-[JSRunLoopThread startRunLoop]):
761         (-[JSRunLoopThread start]):
762         (-[JSRunLoopThread join]):
763         (-[JSRunLoopThread didReceiveInput:]):
764         (-[JSRunLoopThread performCallback:withError:]):
765         (-[JSRunLoopThread performCallback:withArguments:]):
766         (-[JSRunLoopThread didFinishRunLoopInitialization]):
767         * jsc-cli/jsc-cli/ReadEvalPrintLoop.h: Added.
768         * jsc-cli/jsc-cli/ReadEvalPrintLoop.m: Added.
769         (-[ReadEvalPrintLoop initWithJSThread:]):
770         (prompt):
771         (escapeStringForOutput):
772         (-[ReadEvalPrintLoop processNextInput]):
773         (-[ReadEvalPrintLoop run]):
774         * jsc-cli/jsc-cli/RunLoopThread.h: Added.
775         * jsc-cli/jsc-cli/RunLoopThread.m: Added.
776         (+[RunLoopThread threadMain]):
777         (-[RunLoopThread init]):
778         (-[RunLoopThread dealloc]):
779         (-[RunLoopThread didFinishRunLoopInitialization]):
780         (-[RunLoopThread start]):
781         (-[RunLoopThread join]):
782         * jsc-cli/jsc-cli/ScriptInputSource.h: Added.
783         * jsc-cli/jsc-cli/ScriptInputSource.m: Added.
784         (scriptInputSourceScheduleRoutine):
785         (scriptInputSourcePerformRoutine):
786         (scriptInputSourceCancelRoutine):
787         (-[ScriptInputSource initWithContext:]):
788         (-[ScriptInputSource dealloc]):
789         (-[ScriptInputSource addToCurrentRunLoop]):
790         (-[ScriptInputSource removeFromRemoteRunLoop]):
791         (-[ScriptInputSource didReceiveScript:]):
792         (-[ScriptInputSource didReceiveSignal]):
793         (-[ScriptInputSource runScriptRemotely:]):
794         (-[ScriptInputSource finishAsyncCallback:withResult:]):
795         * jsc-cli/jsc-cli/main.m: Added.
796         (main):
797
798 2014-01-23  László Langó  <llango.u-szeged@partner.samsung.com>
799
800         Remove a FIXME comment that is already fixed.
801         https://bugs.webkit.org/show_bug.cgi?id=127468
802
803         Reviewed by Csaba Osztrogonác.
804
805         * Scripts/webkitpy/style/filereader.py:
806         (TextFileReader.__init__):
807
808 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
809
810         [GLIB] Use GUniquePtr instead of GOwnPtr
811         https://bugs.webkit.org/show_bug.cgi?id=127431
812
813         Reviewed by Martin Robinson.
814
815         GUniquePtr is a template alias of std::unique_ptr with a custom
816         deleter that replaces GOwnPtr. GOwnPtr is still used for the cases
817         where the output pointer is needed, but it will also be replaced soon.
818
819         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
820         (printAccessibilityEvent):
821         (axObjectEventListener):
822         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
823         (indexRangeInTable):
824         (AccessibilityUIElement::role):
825         (AccessibilityUIElement::title):
826         (AccessibilityUIElement::description):
827         (AccessibilityUIElement::stringValue):
828         (AccessibilityUIElement::language):
829         (AccessibilityUIElement::lineForIndex):
830         (AccessibilityUIElement::selectedTextRange):
831         (AccessibilityUIElement::url):
832         * DumpRenderTree/efl/AccessibilityControllerEfl.cpp:
833         (AccessibilityController::accessibleElementById):
834         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
835         (AccessibilityController::accessibleElementById):
836         * DumpRenderTree/gtk/DumpRenderTree.cpp:
837         (getOutputDir):
838         (getFontsPath):
839         (initializeFonts):
840         (dumpFramesAsText):
841         (compareHistoryItems):
842         (dumpHistoryItem):
843         (soupURIToStringPreservingPassword):
844         (resetDefaultsToConsistentValues):
845         (temporaryDatabaseDirectory):
846         (webViewTitleChanged):
847         (webFrameLoadStatusNotified):
848         (pathFromSoupURI):
849         (convertWebResourceToURLPath):
850         (urlSuitableForTestResult):
851         (descriptionSuitableForTestResult):
852         (willSendRequestCallback):
853         (frameLoadEventCallback):
854         * DumpRenderTree/gtk/EditingCallbacks.cpp:
855         (dumpNodePath):
856         (dumpRange):
857         (shouldApplyStyle):
858         * DumpRenderTree/gtk/EventSender.cpp:
859         (contextClickCallback):
860         (beginDragWithFilesCallback):
861         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
862         (TestRunner::pathToLocalResource):
863         (TestRunner::queueLoad):
864         (TestRunner::removeOriginAccessWhitelistEntry):
865         (TestRunner::setMockGeolocationPositionUnavailableError):
866         (TestRunner::setIconDatabaseEnabled):
867         (TestRunner::findString):
868         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
869         (TestRunner::overridePreference):
870         (TestRunner::addUserScript):
871         (TestRunner::addUserStyleSheet):
872         (TestRunner::setTextDirection):
873         * DumpRenderTree/gtk/TextInputController.cpp:
874         (setMarkedTextCallback):
875         (insertTextCallback):
876         (doCommandCallback):
877         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
878         (LoadHTMLStringItem::invoke):
879         * TestWebKitAPI/PlatformGTK.cmake:
880         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
881         (WebKitDOMNodeTest::testTagNames):
882         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp:
883         (testBackForwardListLimitAndCache):
884         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
885         (testContextMenuSmartSeparators):
886         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
887         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
888         (testDownloadLocalFile):
889         (testDownloadLocalFileError):
890         (addContentDispositionHTTPHeaderToResponse):
891         (serverCallback):
892         (testDownloadRemoteFileError):
893         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
894         (startTestServer):
895         (testInspectorServerPageList):
896         (openRemoteDebuggingSession):
897         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
898         (testPrintOperationPrint):
899         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
900         (addCacheHTTPHeadersToResponse):
901         (serverCallback):
902         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
903         (httpsServerCallback):
904         (httpServerCallback):
905         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
906         (testWebViewJavaScriptDialogs):
907         (testWebViewWindowProperties):
908         (testWebViewFileChooserRequest):
909         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
910         (testWebExtensionWindowObjectCleared):
911         (testWebExtensionIsolatedWorld):
912         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
913         (startTestServer):
914         (checkAtspiAccessible):
915         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
916         (serverCallback):
917         (testClearDatabase):
918         (testGetFaviconURI):
919         (webkitFaviconDatabaseFinalizedCallback):
920         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
921         (testWebContextGetPlugins):
922         (testWebContextURIScheme):
923         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
924         (testWebViewRunJavaScript):
925         (testWebViewMode):
926         (testWebViewPageVisibility):
927         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp:
928         (isStyleSheetInjectedForURLAtPath):
929         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
930         (testWebViewEditorCutCopyPasteNonEditable):
931         (testWebViewEditorCutCopyPasteEditable):
932         (testWebViewEditorSelectAllNonEditable):
933         (testWebViewEditorSelectAllEditable):
934         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
935         (sendRequestCallback):
936         (methodCallCallback):
937         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
938         (TestWebKitAPI::Util::createInjectedBundlePath):
939         (TestWebKitAPI::Util::createURLForResource):
940         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
941         (TestWebKitAPI::doKeyStroke):
942         (TestWebKitAPI::doMouseButtonEvent):
943         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
944         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.cpp:
945         (loadFailedCallback):
946         (LoadTrackingTest::loadURI):
947         (LoadTrackingTest::loadHtml):
948         (LoadTrackingTest::loadPlainText):
949         (LoadTrackingTest::loadRequest):
950         (LoadTrackingTest::reload):
951         (LoadTrackingTest::goBack):
952         (LoadTrackingTest::goForward):
953         * TestWebKitAPI/gtk/WebKit2Gtk/LoadTrackingTest.h:
954         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.cpp:
955         (registerGResource):
956         (removeNonEmptyDirectory):
957         (main):
958         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
959         (Test::getWebKit1TestResoucesDir):
960         (Test::getResourcesDir):
961         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
962         (WebKitTestBus::run):
963         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
964         (WebKitTestServer::WebKitTestServer):
965         (WebKitTestServer::getURIForPath):
966         * TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp:
967         (WebProcessTestRunner::runTest):
968         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
969         (resourceGetDataCallback):
970         (WebViewTest::mainResourceData):
971         (WebViewTest::mouseMoveTo):
972         (WebViewTest::keyStroke):
973         (WebViewTest::doMouseButtonEvent):
974         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
975         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
976         (WTR::AccessibilityController::accessibleElementById):
977         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
978         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
979         (WTR::AccessibilityUIElement::role):
980         (WTR::AccessibilityUIElement::title):
981         (WTR::AccessibilityUIElement::description):
982         (WTR::AccessibilityUIElement::stringValue):
983         (WTR::AccessibilityUIElement::language):
984         (WTR::AccessibilityUIElement::lineForIndex):
985         (WTR::AccessibilityUIElement::selectedTextRange):
986         (WTR::AccessibilityUIElement::url):
987         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
988         (WTR::getOutputDir):
989         (WTR::getFontsPath):
990         (WTR::initializeFontConfigSetting):
991         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
992         (WTR::topLevelPath):
993         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
994         (WTR::TestRunner::pathToLocalResource):
995         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
996         (WTR::TestController::initializeInjectedBundlePath):
997         (WTR::TestController::initializeTestPluginDirectory):
998
999 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
1000
1001         [GTK] [CMake] run-webkit-tests should support the CMake build
1002         https://bugs.webkit.org/show_bug.cgi?id=126503
1003
1004         Reviewed by Daniel Bates.
1005
1006         Update run-launcher and gtk.py to work properly when dealing with the CMake port.
1007         run-webkit-tests does not need the --gtkcmake flag, but run-launcher does.
1008
1009         * Scripts/run-launcher: Work properly with the gtkcmake flag.
1010         * Scripts/webkitpy/port/gtk.py:
1011         (GtkPort._is_cmake_build): Added this helper which looks for the CMakeCache
1012         file to detect a CMake build.
1013         (GtkPort._built_executables_path): Added this helper to locate the built executable path.
1014         (GtkPort._built_libraries_path): Added this helper to locate the built library path.
1015         (GtkPort._port_flag_for_scripts): Use --gtkcmake when appropriate.
1016         (GtkPort.setup_environ_for_server): The way CMake builds libraries differs from GTK+.
1017         (GtkPort._path_to_driver): Use the new helper.
1018         (GtkPort._path_to_image_diff): Use the new helper.
1019         (GtkPort._path_to_webcore_library): Use the new helper.
1020         (GtkPort.build_webkit_command): Use --gtkcmake when appropriate.
1021
1022 2014-01-22  Ryuan Choi  <ryuan.choi@samsung.com>
1023
1024         [EFL] Remove unnecessary smart method since ewk_view_tiled removed
1025         https://bugs.webkit.org/show_bug.cgi?id=127417
1026
1027         Reviewed by Gyuyoung Kim.
1028
1029         * EWebLauncher/main.c:
1030         (on_key_down): Removed shortcut to test pre render.
1031
1032 2014-01-22  Myles C. Maxfield  <mmaxfield@apple.com>
1033
1034         Remove CSS3_TEXT_DECORATION define
1035         https://bugs.webkit.org/show_bug.cgi?id=127333
1036
1037         This is required for unprefixing the text-decoration-* CSS properties.
1038
1039         Reviewed by Simon Fraser.
1040
1041         * Configurations/FeatureDefines.xcconfig:
1042
1043 2014-01-22  Andy Estes  <aestes@apple.com>
1044
1045         [iOS] Prepare for upstreaming DumpRenderTree changes
1046         https://bugs.webkit.org/show_bug.cgi?id=127412
1047
1048         Reviewed by Simon Fraser.
1049
1050         Unlike on Mac where DumpRenderTree is a command-line tool, on iOS it is
1051         an application bundle. Instead of upstreaming a separate target for the
1052         app that duplicates the 'Compile Sources' phase of the tool, separate
1053         out the compilation into a static library target that both the
1054         command-line tool and the app can link against. Also, perform some
1055         unrelated cleanup.
1056
1057         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated the
1058         project file format from 2.4- to 3.2-compatible. Removed the
1059         'Copy Headers' build phase and removed all files from the
1060         'Compile Sources' build phase of DumpRenderTree. Added some files that
1061         were missing from the project. Created a 'DumpRenderTree (Library)'
1062         target for building the static library and made the 'DumpRenderTree'
1063         target depend on it. Added a 'Compile Sources' build phase to this
1064         target that builds the same files the DumpRenderTree target used to.
1065         Created DumpRenderTreeMain.mm as the only source file of the
1066         DumpRenderTree target, since targets won't link a binary without at
1067         least one source file. Made DumpRenderTree (Library) use
1068         DumpRenderTreeLibrary.xcconfig and made LayoutTestHelper use
1069         BaseTarget.xcconfig (so that it doesn't try to link libDumpRenderTree.a).
1070         * DumpRenderTree/mac/Configurations/BaseTarget.xcconfig: Moved
1071         definitions of GCC_ENABLE_OBJC_EXCEPTIONS and GCC_PREFIX_HEADER from
1072         DumpRenderTree.xcconfig to here so that LayoutTestHelper can use them.
1073         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Passed
1074         -force_load $(BUILT_PRODUCTS_DIR)libDumpRenderTree.a to OTHER_LDFLAGS.
1075         This is needed to correctly link a static library containing an Objective-C
1076         category (see <https://developer.apple.com/library/mac/qa/qa1490/_index.html>).
1077         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Added.
1078         * DumpRenderTree/mac/DumpRenderTree.mm:
1079         (DumpRenderTreeMain): Renamed from main.
1080         * DumpRenderTree/mac/DumpRenderTreeMac.h: Added declaration of DumpRenderTreeMain.
1081         * DumpRenderTree/mac/DumpRenderTreeMain.mm: Added.
1082         (main): Called DumpRenderTreeMain from main.
1083
1084 2014-01-15  Martin Robinson  <mrobinson@igalia.com>
1085
1086         [GTK][CMake] build-webkit should try harder to avoid re-running cmake
1087         https://bugs.webkit.org/show_bug.cgi?id=127073
1088
1089         Reviewed by Daniel Bates.
1090
1091         * Scripts/build-webkit: Unify all the ports that call buildCMakeProjectOrExit with
1092         the new isCMakeBuild conditional. This allows us to share more code between ports.
1093         Pass the build arguments to the removeCMakeCache function.
1094         * Scripts/webkitdirs.pm:
1095         (runAutogenForAutotoolsProjectIfNecessary): Renamed mustReRunAutogen to cachedArgumentFileOutOfDate
1096         because it's now shared with the CMake build.
1097         (cachedArgumentFileOutOfDate): Renamed.
1098         (cmakeCachePath): Added this helper which gets the CMakeCache.txt path.
1099         (shouldRemoveCMakeCache): Tries to preserve current behavior for all ports, 
1100         except GTK+ which examines the OptionsGTK.cmake and OptionsCommon.cmake file
1101         as well as checking if build-webkit has been run with different arguments.
1102         (removeCMakeCache): Call shouldRemoveCMakeCache now.
1103         (generateBuildSystemFromCMakeProject): Exit early if CMakeCache.txt exists for GTK+.
1104         (isCMakeBuild): Added.
1105
1106 2014-01-22  Thiago de Barros Lacerda  <thiago.lacerda@openbossa.org>
1107
1108         [EFL][GTK] Get EFL and GTK compiling with ACCESSIBILITY disabled
1109         https://bugs.webkit.org/show_bug.cgi?id=127119
1110
1111         Reviewed by Mario Sanchez Prada.
1112
1113         Guarding ACCESSIBILITY code in DumpRenderTree and WebKitTestRunner with HAVE(ACCESSIBILITY).
1114
1115         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1116         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
1117         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1118         (resetDefaultsToConsistentValues):
1119         (webViewWindowObjectCleared):
1120         (main):
1121         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1122         (WTR::AccessibilityController::platformName):
1123         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1124         (WTR::AccessibilityUIElement::isIndeterminate):
1125
1126 2014-01-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1127
1128
1129         [GTK] Add GUniquePtr
1130         https://bugs.webkit.org/show_bug.cgi?id=127170
1131
1132         Reviewed by Gustavo Noronha Silva.
1133
1134         Add unit tests for GUniquePtr.
1135
1136         * TestWebKitAPI/GNUmakefile.am: Add new file to compilation.
1137         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp: Added.
1138         (log):
1139         (takeLogStr):
1140         (TestWebKitAPI::TEST):
1141
1142 2014-01-22  Jinwoo Song  <jinwoo7.song@samsung.com>
1143
1144         Remove Nix files from Tools
1145         https://bugs.webkit.org/show_bug.cgi?id=127418
1146
1147         Reviewed by Csaba Osztrogonác.
1148
1149         * Scripts/build-webkit:
1150         * Scripts/update-webkit-libs-jhbuild:
1151         * Scripts/webkitdirs.pm:
1152         (determineArchitecture):
1153         (argumentsForConfiguration):
1154         (jscProductDir):
1155         (builtDylibPathForName):
1156         (isAppleWebKit):
1157         (launcherPath):
1158         (launcherName):
1159         (checkRequiredSystemConfig):
1160         (copyInspectorFrontendFiles):
1161         (jhbuildWrapperPrefixIfNeeded):
1162         (buildCMakeProjectOrExit):
1163         (cmakeBasedPortName):
1164         * Scripts/webkitpy/common/config/ports.py:
1165         (DeprecatedPort.port):
1166         (EflWK2Port.build_webkit_command):
1167         * Scripts/webkitpy/port/factory.py:
1168         (platform_options):
1169         (PortFactory):
1170         * Scripts/webkitpy/port/nix.py: Removed.
1171         * Scripts/webkitpy/port/nix_unittest.py: Removed.
1172
1173 2014-01-21  Benjamin Poulain  <benjamin@webkit.org>
1174
1175         Add Ian and Ricky to the contributor list
1176
1177         * Scripts/webkitpy/common/config/contributors.json:
1178         I am too old to remember all those email addresses :)
1179
1180 2014-01-21  David Farler  <dfarler@apple.com>
1181
1182         Upstream package-root for iOS
1183
1184         Reviewed by Daniel bates.
1185
1186         * Scripts/package-root: Added.
1187         (usage):
1188         * Scripts/webkitdirs.pm:
1189         (XcodeSDKPath): Added function.
1190
1191 2014-01-21  Daniel Bates  <dabates@apple.com>
1192
1193         [iOS] Tools/Makefile shouldn't build modules DumpRenderTree, gtest, or TestWebKitAPI
1194         https://bugs.webkit.org/show_bug.cgi?id=127368
1195
1196         Reviewed by Tim Horton.
1197
1198         Similar to the build-webkit change in <https://bugs.webkit.org/show_bug.cgi?id=127364>,
1199         we don't want to build DumpRenderTree, gtest, or TestWebKitAPI when running make in
1200         Tools.
1201
1202         * Makefile:
1203
1204 2014-01-21  Daniel Bates  <dabates@apple.com>
1205
1206         [iOS] Don't build DumpRenderTree, gtest, or TestWebKitAPI
1207         https://bugs.webkit.org/show_bug.cgi?id=127364
1208
1209         Reviewed by Simon Fraser.
1210
1211         For now, don't build DumpRenderTree and TestWebKitAPI for iOS as these
1212         projects fail to build because we need to upstream the relevant iOS changes.
1213         Also, don't build gtest, which is a dependency of TestWebKitAPI since we
1214         aren't building TestWebKitAPI.
1215
1216         * Scripts/build-webkit:
1217
1218 2014-01-21  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1219
1220         Unreviewed, remove myself from some watchlist entries.
1221
1222         * Scripts/webkitpy/common/config/watchlist:
1223
1224 2014-01-21  Zalan Bujtas  <zalan@apple.com>
1225
1226         Use 64 as the default value for the subpixel denominator.
1227
1228         Reviewed by Simon Fraser.
1229
1230         * lldb/lldb_webkit.py:
1231         (WebCoreLayoutUnitProvider.to_string):
1232
1233 2014-01-21  ChangSeok Oh  <changseok.oh@collabora.com>
1234
1235         [GTK] Fix a c++11 compliance issue for fontconfig
1236         https://bugs.webkit.org/show_bug.cgi?id=127283
1237
1238         Reviewed by Martin Robinson.
1239
1240         fontconfig-2.8.0 is not compliant with C++11. So I propose to apply a
1241         hotfix until bumping fontconfig up.
1242
1243         * gtk/jhbuild.modules:
1244         * gtk/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
1245
1246 2014-01-21  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1247
1248         run-jsc-stress-tests should accept --child-processes option and WEBKIT_TEST_CHILD_PROCESSES env.var
1249         like run_webkit_test does
1250         https://bugs.webkit.org/show_bug.cgi?id=127349
1251
1252         Reviewed by Csaba Osztrogonác.
1253
1254         * Scripts/run-jsc-stress-tests:
1255
1256 2014-01-21  Adrian Perez de Castro  <aperez@igalia.com>
1257
1258         [GTK] Allow passing extra data to web extensions
1259         https://bugs.webkit.org/show_bug.cgi?id=125990
1260
1261         Reviewed by Carlos Garcia Campos.
1262
1263         Allow passing additional information to the injected bundle. On top
1264         of the string containing the path to the web extensions directory,
1265         a GVariant can be set with additional data using
1266         webkit_web_context_set_web_extensions_initialization_user_data().
1267         Also, a new initialize-web-extensions signal is emitted before
1268         launching a new WebProcess to allow setting different user data
1269         for each process. The GVariant is serialized as a string, passed
1270         to the injected bundle, and the injected bundle deserializes back
1271         the data, which is passed to web extensions which define the
1272         webkit_web_extension_initialize_with_user_data() function (for
1273         backwards compatibility, webkit_web_extension_initialize() is
1274         used as a fallback.)
1275
1276         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1277         (initializeWebExtensions): Handles the initialize-web-extensions
1278         signal, and sets the web extensions directory and the initialization
1279         user data.
1280         (testWebExtensionInitializationUserData): New test case for checking
1281         the user data passed on initialization to web extensions.
1282         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1283         (methodCallCallback): Added implementation for the
1284         GetInitializationUserData D-Bus method, used by
1285         testWebExtensionInitializationUserData().
1286         (webkit_web_extension_initialize_with_user_data): Define the
1287         initialization function with the additional user data parameter.
1288
1289 2014-01-21  Siddharth Mathur  <s.mathur@ieee.org>
1290
1291         Change my email address in contributors.json.
1292
1293         Unreviewed.
1294
1295         * Scripts/webkitpy/common/config/contributors.json:
1296
1297 2014-01-21  Krzysztof Czech  <k.czech@samsung.com>
1298
1299         [ATK] Expose aria-flowto through ATK_RELATION_FLOWS_TO
1300         https://bugs.webkit.org/show_bug.cgi?id=127291
1301
1302         Reviewed by Mario Sanchez Prada.
1303
1304         Implemented AccessibilityUIElement::ariaFlowToElementAtIndex method.
1305
1306         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1307         (AccessibilityUIElement::ariaFlowToElementAtIndex):
1308         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1309         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1310
1311 2014-01-20  Zalan Bujtas  <zalan@apple.com>
1312
1313         Force float division when calculating CSS px value.
1314
1315         Reviewed by Simon Fraser.
1316
1317         Note that in Python 3, this is the default behavior.
1318
1319         * lldb/lldb_webkit.py:
1320         (WebCoreLayoutUnitProvider.to_string):
1321
1322 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1323
1324         build.webkit.org/dashboard should display information about patches in EWS
1325         https://bugs.webkit.org/show_bug.cgi?id=127006
1326
1327         Reviewed by Ryosuke Niwa.
1328
1329         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html:
1330         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Bugzilla.js: Added.
1331         (Bugzilla.prototype.detailsURLForAttachment):
1332         Added a class for Bugzilla. So far, the only thing it can do is build patch URLs,
1333         which is needed when one wants to do something with a patch EWS is stuck on.
1334
1335         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
1336         Create a Bugzilla instance.
1337
1338         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
1339         (EWS.prototype.jsonQueueLengthURL):
1340         (EWS.prototype.jsonQueueStatusURL):
1341         Build JSON ULRs here, not in EWSQueue, as this is how other classes are structured.
1342
1343         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueue.js:
1344         (EWSQueue.prototype.get statusPageURL): Changed to use a URL provided by EWS instead
1345         of second guessing.
1346         (EWSQueue.prototype.get chartsPageURL): Added.
1347         (EWSQueue.prototype.get loadedDetailedStatus): Tells whether we currently have
1348         additional data already loaded (it's reset with every update).
1349         (EWSQueue.prototype.get patches): Get patch queue.
1350         (EWSQueue.prototype.get bots): Get bots.
1351         (EWSQueue.prototype.update): Changed to use a specialized cheaper URL.
1352         (EWSQueue.prototype.loadDetailedStatus): Load and transform detailed status JSON.
1353
1354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWSQueueView.js:
1355         (EWSQueueView.prototype.update.appendQueue): Add a popover is there are any patches
1356         in the queue.
1357         (EWSQueueView.prototype.addLinkToRow): A helper to build the popover.
1358         (EWSQueueView.prototype.addTextToRow): Ditto.
1359         (EWSQueueView.prototype._addQueueHeadingToPopover): Ditto.
1360         (EWSQueueView.prototype._addBotsHeadingToPopover): Ditto.
1361         (EWSQueueView.prototype._addDividerToPopover): Ditto.
1362         (EWSQueueView.prototype._timeIntervalString): A helper to format a timestamp into a
1363         relative string.
1364         (EWSQueueView.prototype._popoverContentForEWSQueue): Build the popover.
1365         (EWSQueueView.prototype._presentPopoverForEWSQueue): Start loading data, and present
1366         it when done.
1367
1368         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1369         Added rules for EWS popover. Removed a duplicate rule for build-logs-popover.
1370         Changed a few difficult to read padding styles to padding-left.
1371
1372 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1373
1374         Fix webkitpy tests.
1375
1376         * Scripts/webkitpy/common/net/web_mock.py: (MockBrowser.set_handle_robots):
1377         Added a mock implementation, as we now call this function.
1378
1379 2014-01-20  Darin Adler  <darin@apple.com>
1380
1381         Update style checker and tests to deal with override instead of OVERRIDE
1382         https://bugs.webkit.org/show_bug.cgi?id=127175
1383
1384         Reviewed by Anders Carlsson.
1385
1386         * Scripts/webkitpy/style/checkers/cpp.py:
1387         (check_braces): Use override instead of OVERRIDE.
1388         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1389         (CppStyleTest.test_brace_at_begin_of_line): Ditto.
1390
1391 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1392
1393         EWS should provide better information to Dashboard via JSON
1394         https://bugs.webkit.org/show_bug.cgi?id=127265
1395
1396         Reviewed by Ryosuke Niwa.
1397
1398         * QueueStatusServer/app.yaml: Updated version.
1399
1400         * QueueStatusServer/main.py:
1401         * QueueStatusServer/handlers/queuelengthjson.py:
1402         Added a way to cheaply get only the queue length, which is all the dashboard
1403         needs unless a popover is opened.
1404
1405         * QueueStatusServer/handlers/queuestatusjson.py: Updated to return more information
1406         that we will need. Changed some field names to be more meaningful. Fixed bot listing
1407         to understand that a bot can be reprurposed and used in a different queue.
1408
1409 2014-01-20  Alexey Proskuryakov  <ap@apple.com>
1410
1411         Make uploading results to EWS work despite robots.txt
1412         https://bugs.webkit.org/show_bug.cgi?id=127296
1413
1414         Reviewed by Ryosuke Niwa.
1415
1416         * Scripts/webkitpy/common/net/statusserver.py: (StatusServer.__init__): Disable
1417         checking robots.txt.
1418
1419         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: (Bugzilla._get_browser):
1420         Removed a comment saying that we would want to stop doing this. Not checking
1421         robots.txt is more efficient than checking it.
1422
1423 2014-01-19  Ryuan Choi  <ryuan.choi@samsung.com>
1424
1425         [EFL][WK1] Remove and refactor the APIs which use single and base keyword
1426         https://bugs.webkit.org/show_bug.cgi?id=127214
1427
1428         Reviewed by Gyuyoung Kim.
1429
1430         Followed the changes of API.
1431
1432         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1433         (drtViewAdd):
1434         * EWebLauncher/main.c:
1435         (windowCreate):
1436
1437 2014-01-19  Eunmi Lee  <eunmi15.lee@samsung.com>
1438
1439         [EFL][WK2] Add touch events option to MiniBrowser.
1440         https://bugs.webkit.org/show_bug.cgi?id=127262
1441
1442         Reviewed by Gyuyoung Kim.
1443
1444         As a default, touch events are disabled and mouse events are enabled.
1445         If touch events option sets to true, touch events are enabled and mouse
1446         events are disabled.
1447
1448         * MiniBrowser/efl/main.c:
1449         (window_create):
1450         (elm_main):
1451
1452 2014-01-19  Zalan Bujtas  <zalan@apple.com>
1453
1454         Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
1455         https://bugs.webkit.org/show_bug.cgi?id=126080
1456
1457         Reviewed by Sam Weinig.
1458
1459         This changes the output of printing LayoutUnits to be in px but it also
1460         preserves the original LayoutUnit value.
1461
1462         This will lead to lldb output like: (and it works even when subpixel is disabled)
1463
1464         (const WebCore::LayoutRect) $0 = {
1465             m_location = { x = 2.25px (144), y = 1px (64)}
1466             m_size = { width = 13.75px (880), height = 20px (1280) }
1467
1468
1469         And gdb output like:
1470
1471         m_frameRect = {
1472             m_location = LayoutPoint(0px (0), 0px(0)),
1473             m_size = LayoutSize(8px (512), 5px (320))
1474         }
1475
1476         This patch is based on patch by bjonesbe@adobe.com and for Blink by cbiesinger@chromium.org.
1477
1478         * gdb/webkit.py:
1479         (WebCoreLayoutUnitPrinter):
1480         (WebCoreLayoutUnitPrinter.__init__):
1481         (WebCoreLayoutUnitPrinter.to_string):
1482         (WebCoreLayoutSizePrinter):
1483         (WebCoreLayoutSizePrinter.__init__):
1484         (WebCoreLayoutSizePrinter.to_string):
1485         (WebCoreLayoutPointPrinter):
1486         (WebCoreLayoutPointPrinter.__init__):
1487         (WebCoreLayoutPointPrinter.to_string):
1488         (add_pretty_printers):
1489         * lldb/lldb_webkit.py:
1490         (__lldb_init_module):
1491         (WebCoreLayoutUnit_SummaryProvider):
1492         (WebCoreLayoutSize_SummaryProvider):
1493         (WebCoreLayoutPoint_SummaryProvider):
1494         (WebCoreLayoutUnitProvider):
1495         (WebCoreLayoutUnitProvider.__init__):
1496         (WebCoreLayoutUnitProvider.to_string):
1497         (WebCoreLayoutSizeProvider):
1498         (WebCoreLayoutSizeProvider.__init__):
1499         (WebCoreLayoutSizeProvider.get_width):
1500         (WebCoreLayoutSizeProvider.get_height):
1501         (WebCoreLayoutPointProvider):
1502         (WebCoreLayoutPointProvider.__init__):
1503         (WebCoreLayoutPointProvider.get_x):
1504         (WebCoreLayoutPointProvider.get_y):
1505
1506 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1507
1508         Add robots.txt to http://webkit-queues.appspot.com
1509         https://bugs.webkit.org/show_bug.cgi?id=127240
1510
1511         * QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
1512
1513 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1514
1515         Add robots.txt to http://webkit-queues.appspot.com
1516         https://bugs.webkit.org/show_bug.cgi?id=127240
1517
1518         Reviewed by Ryosuke Niwa.
1519
1520         * QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
1521
1522         * QueueStatusServer/robots.txt: Added.
1523
1524 2014-01-18  Alberto Garcia  <berto@igalia.com>
1525
1526         Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
1527         https://bugs.webkit.org/show_bug.cgi?id=127217
1528
1529         Reviewed by Daniel Bates.
1530
1531         The syntax File::Temp->tempdir() was explicitly made invalid
1532         following <https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
1533         which was included in File::Temp v2.30, shipped with Perl v5.18.0.
1534
1535         Use File::Temp::tempdir() instead.
1536
1537         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
1538
1539 2014-01-18  Alexey Proskuryakov  <ap@apple.com>
1540
1541         build.webkit.org/dashboard should have image diff links in test results popovers
1542         https://bugs.webkit.org/show_bug.cgi?id=127188
1543
1544         Reviewed by Timothy Hatcher.
1545
1546         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1547         (Buildbot.prototype.layoutTestImagesURLForIteration):
1548         (Buildbot.prototype.layoutTestImageDiffURLForIteration):
1549         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1550         (BuildbotIteration.prototype.loadLayoutTestResults):
1551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1552         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
1553         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
1554         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1555
1556 2014-01-18  Anders Carlsson  <andersca@apple.com>
1557
1558         Remove ENABLE_THREADED_HTML_PARSER defines everywhere
1559         https://bugs.webkit.org/show_bug.cgi?id=127225
1560
1561         Reviewed by Andreas Kling.
1562
1563         This concludes the removal of over 8.8 million lines of threaded parser code.
1564
1565         * Scripts/webkitperl/FeatureList.pm:
1566
1567 2014-01-17  Alexey Proskuryakov  <ap@apple.com>
1568
1569         build.webkit.org/dashboard should have diff links in test results popovers
1570         https://bugs.webkit.org/show_bug.cgi?id=126986
1571
1572         Reviewed by Tim Horton.
1573
1574         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1575         (Buildbot.prototype.layoutTestCrashLogURLForIteration):
1576         (Buildbot.prototype.layoutTestStderrURLForIteration):
1577         (Buildbot.prototype.layoutTestDiffURLForIteration):
1578         (Buildbot.prototype.layoutTestPrettyDiffURLForIteration):
1579         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1580         (BuildbotIteration.prototype.loadLayoutTestResults):
1581         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1582         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1583
1584 2014-01-17  Matthew Hanson  <matthew_hanson@apple.com>
1585
1586         Add the bare minimum support for branches to the bot-watchers dashboard
1587         https://bugs.webkit.org/show_bug.cgi?id=127124
1588
1589         This patch simply introduces the notion of branches into the bot-watchers dashboard.
1590         Subsequent patches will build functionality on top of this simple bit of infrastructure.
1591
1592         Reviewed by Timothy Hatcher.
1593
1594         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1595         (BuildbotQueue): store the branch property in the BuildbotQueue constructor
1596         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1597         Initialize the Dashboard.Branch object
1598
1599 2014-01-17  Chris Fleizach  <cfleizach@apple.com>
1600
1601         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1602         https://bugs.webkit.org/show_bug.cgi?id=127141
1603
1604         Reviewed by Alexey Proskuryakov.
1605
1606         Make sure to reset the notification handler each time.
1607
1608         * DumpRenderTree/AccessibilityController.cpp:
1609         (AccessibilityController::resetToConsistentState):
1610         * DumpRenderTree/AccessibilityController.h:
1611         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
1612         (AccessibilityController::platformResetToConsistentState):
1613         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1614         (AccessibilityController::platformResetToConsistentState):
1615         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1616         (AccessibilityController::~AccessibilityController):
1617         (AccessibilityController::platformResetToConsistentState):
1618         (AccessibilityController::removeNotificationListener):
1619         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1620         (AccessibilityController::platformResetToConsistentState):
1621
1622 2014-01-17  Alberto Garcia  <berto@igalia.com>
1623
1624         [GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
1625         https://bugs.webkit.org/show_bug.cgi?id=82329
1626
1627         Reviewed by Carlos Garcia Campos.
1628
1629         Unskip, this is working fine now.
1630
1631         * Scripts/run-gtk-tests:
1632         (TestRunner):
1633
1634 2014-01-17  Alberto Garcia  <berto@igalia.com>
1635
1636         [GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
1637         https://bugs.webkit.org/show_bug.cgi?id=82328
1638
1639         Reviewed by Carlos Garcia Campos.
1640
1641         This was caused by the icon database being corrupted in the
1642         Release bot. After removing it the test works fine so it can be
1643         run again.
1644
1645         * Scripts/run-gtk-tests:
1646         (TestRunner):
1647
1648 2014-01-16  Alexey Proskuryakov  <ap@apple.com>
1649
1650         Test results popovers at http://build.webkit.org/dashboard should link to stderr
1651         https://bugs.webkit.org/show_bug.cgi?id=126929
1652
1653         Reviewed by Timothy Hatcher.
1654
1655         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1656         (Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
1657         (Buildbot.prototype.layoutTestStderrURLForIteration): Added.
1658
1659         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1660         (BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.
1661
1662         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1663         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1664         Add a link to stderr output if present.
1665
1666         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
1667         (.test-results-popover .additional-link): Style with light grey (will use the same style
1668         for diff links).
1669
1670 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1671
1672         Automate DoYouEvenBench
1673         https://bugs.webkit.org/show_bug.cgi?id=124497
1674
1675         Reviewed by Geoffrey Garen.
1676
1677         * Scripts/webkitpy/performance_tests/perftest.py:
1678         (PerfTestMetric.__init__): Added the aggregator name as an argument.
1679         (PerfTestMetric.aggregator): Added.
1680         (PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
1681         won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
1682         should be parsed as the metric and the aggregator respectively.
1683         (PerfTest._run_with_driver): Pass in the aggregator name.
1684         (PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
1685         which generates subtests of subtests within a single test file.
1686
1687         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1688         (test_parse_output_with_subtests_and_total): Added.
1689
1690         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1691         (_generate_results_dict): Add the aggregator name to the JSON when one is available.
1692
1693         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1694         (TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.
1695
1696 2014-01-16  Chris Fleizach  <cfleizach@apple.com>
1697
1698         platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
1699         https://bugs.webkit.org/show_bug.cgi?id=127141
1700
1701         Reviewed by Alexey Proskuryakov.
1702
1703         Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.
1704
1705         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
1706         (AccessibilityController::~AccessibilityController):
1707
1708 2014-01-16  Ryosuke Niwa  <rniwa@webkit.org>
1709
1710         EWS shouldn't comment on Bugzilla for failing builds or style errors
1711         https://bugs.webkit.org/show_bug.cgi?id=127079
1712
1713         Reviewed by Anders Carlsson.
1714
1715         Since patch authors and reviewers could retrieve this information from bubbles,
1716         we shouldn't spam the Bugzilla with useless comments.
1717
1718         We still post style errors but not python paths we used since it's a pure noise.
1719
1720         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1721         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
1722         * Scripts/webkitpy/tool/commands/queues.py:
1723         (StyleQueue.review_patch):
1724
1725 2014-01-15  Roger Fong  <roger_fong@apple.com>
1726
1727         Add support for handling WebGL load policies.
1728         https://bugs.webkit.org/show_bug.cgi?id=126935
1729         <rdar://problem/15790448>.
1730
1731         Reviewed by Timothy Horton.
1732
1733         * WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.
1734         (WTR::TestController::createWebViewWithOptions):
1735
1736 2014-01-16  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
1737
1738         Remove workaround for compilers not supporting explicit override control
1739         https://bugs.webkit.org/show_bug.cgi?id=127111
1740
1741         Reviewed by Anders Carlsson.
1742
1743         Now all compilers support explicit override control, this workaround can be removed.
1744
1745         * DumpRenderTree/gtk/fonts/fonts.conf:
1746         * Scripts/do-webcore-rename:
1747         Removed this rename operation from the list of contemplated future renames.
1748         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
1749         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
1750         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
1751         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
1752         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
1753
1754 2014-01-16  Oliver Hunt  <oliver@apple.com>
1755
1756         Stop run-jsc from consuming stderr output
1757         https://bugs.webkit.org/show_bug.cgi?id=127115
1758
1759         Reviewed by Mark Lam.
1760
1761         Simple patch to make run-jsc easier to deal with
1762
1763         * Scripts/run-jsc:
1764
1765 2014-01-16  Eva Balazsfalvi  <balazsfalvi.eva@stud.u-szeged.hu>
1766
1767         Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
1768         https://bugs.webkit.org/show_bug.cgi?id=126323
1769
1770         Reviewed by Csaba Osztrogonác.
1771
1772         * gtk/generate-feature-defines-files:
1773
1774 2014-01-16  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1775
1776         [EFL][WK2] Implement TestController::setHidden
1777         https://bugs.webkit.org/show_bug.cgi?id=127036
1778
1779         Reviewed by Gyuyoung Kim.
1780
1781         WebKitTestRunner needs TestController::setHidden implementation to
1782         properly handle page visibility API layout tests after r161105.
1783
1784         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1785         (WTR::TestController::setHidden):
1786
1787 2014-01-16  Zan Dobersek  <zdobersek@igalia.com>
1788
1789         [GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
1790         https://bugs.webkit.org/show_bug.cgi?id=127083
1791
1792         Reviewed by Carlos Garcia Campos.
1793
1794         When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
1795         The progress entry is then reset back to 0 in that callback and the timeout source is removed.
1796
1797         The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
1798         assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
1799         To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
1800         BrowserWindow object is being finalized, preventing the callback from firing.
1801
1802         * MiniBrowser/gtk/BrowserWindow.c:
1803         (resetEntryProgress):
1804         (webViewLoadProgressChanged):
1805         (browserWindowFinalize):
1806
1807 2014-01-15  Alexey Proskuryakov  <ap@apple.com>
1808
1809         DumpRenderTree doesn't disable web preferences autosave
1810         https://bugs.webkit.org/show_bug.cgi?id=127062
1811
1812         Reviewed by Dan Bernstein.
1813
1814         * DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):
1815         Do it.
1816
1817 2014-01-15  Dean Jackson  <dino@apple.com>
1818
1819         Improve filter-build-webkit, especially for iOS builds
1820         https://bugs.webkit.org/show_bug.cgi?id=81046
1821
1822         Reviewed by Joseph Pecoraro.
1823
1824         Lots of updates to the filtering rules, mostly from the
1825         iOS build output. Other highlights include:
1826         - ignoring escape sequences for color ouput
1827         - detecting escaped spaces in file name regexps
1828
1829         * Scripts/filter-build-webkit:
1830         (shouldIgnoreLine):
1831
1832 2014-01-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1833
1834         [GTK] Web process sometimes crashes when printing in synchronous mode
1835         https://bugs.webkit.org/show_bug.cgi?id=126979
1836
1837         Reviewed by Gustavo Noronha Silva.
1838
1839         * Scripts/run-gtk-tests:
1840         (TestRunner): Unskip
1841         /webkit2/WebKitPrintOperation/close-after-print.
1842
1843 2014-01-15  ChangSeok Oh  <changseok.oh@collabora.com>
1844
1845         [EFL] Change test font installed path to webkitgtk-font-tests
1846         https://bugs.webkit.org/show_bug.cgi?id=126723
1847
1848         Reviewed by Gyuyoung Kim.
1849
1850         I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
1851         to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
1852         hard-coded in FontManagement.cpp#105
1853
1854         * DumpRenderTree/PlatformEfl.cmake:
1855         * WebKitTestRunner/PlatformEfl.cmake:
1856         * efl/jhbuild.modules:
1857
1858 2014-01-14  Ryosuke Niwa  <rniwa@webkit.org>
1859
1860         Make DoYouEvenBench runnable by run-perf-tests
1861         https://bugs.webkit.org/show_bug.cgi?id=127030
1862
1863         Reviewed by Andreas Kling.
1864
1865         Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
1866         ":Total" to appear at the end of a test name. We don't do anything with it for now.
1867
1868         * Scripts/webkitpy/performance_tests/perftest.py:
1869         (PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
1870         to the JSON in a follow up patch for the perf dashboard.
1871         (PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.
1872
1873 2014-01-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1874
1875         [GTK] UI process crashes when the web process crashes while printing
1876         https://bugs.webkit.org/show_bug.cgi?id=126977
1877
1878         Reviewed by Gustavo Noronha Silva.
1879
1880         Add new test case to check that closing the window right after
1881         printing works. It's skipped for now, because this patch only
1882         fixes the UI process crash, but not the web process one.
1883
1884         * Scripts/run-gtk-tests:
1885         (TestRunner): Skip
1886         /webkit2/WebKitPrintOperation/close-after-print.
1887         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1888         (testPrintOperationPrintPrinter):
1889         (findPrintToFilePrinter):
1890         (testPrintOperationPrint):
1891         (testPrintOperationErrors):
1892         (testPrintOperationCloseAfterPrint):
1893         (beforeAll):
1894
1895 2014-01-14  Brent Fulgham  <bfulgham@apple.com>
1896
1897         [WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
1898         https://bugs.webkit.org/show_bug.cgi?id=127002
1899
1900         Reviewed by David Kilzer.
1901
1902         * Scripts/webkitdirs.pm:
1903         (setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.
1904
1905 2014-01-14  Commit Queue  <commit-queue@webkit.org>
1906
1907         Unreviewed, rolling out r162000.
1908         http://trac.webkit.org/changeset/162000
1909         https://bugs.webkit.org/show_bug.cgi?id=127009
1910
1911         API versioning is wrong (Requested by rfong on #webkit).
1912
1913         * MiniBrowser/mac/WK2BrowserWindowController.m:
1914         (-[WK2BrowserWindowController awakeFromNib]):
1915         * WebKitTestRunner/TestController.cpp:
1916         (WTR::TestController::createOtherPage):
1917         (WTR::TestController::createWebViewWithOptions):
1918
1919 2014-01-13  Roger Fong  <roger_fong@apple.com>
1920
1921         Add support for handling WebGL load policies.
1922         https://bugs.webkit.org/show_bug.cgi?id=126935
1923         <rdar://problem/15790448>.
1924
1925         Reviewed by Brent Fulgham.
1926
1927         * MiniBrowser/mac/WK2BrowserWindowController.m:
1928         (-[WK2BrowserWindowController awakeFromNib]):
1929         * WebKitTestRunner/TestController.cpp:
1930         (WTR::TestController::createWebViewWithOptions):
1931
1932 2014-01-14  Zan Dobersek  <zdobersek@igalia.com>
1933
1934         [GTK] Skip FontConfig initialization in WebKitTestRunner if requested
1935         https://bugs.webkit.org/show_bug.cgi?id=120110
1936
1937         Reviewed by Martin Robinson.
1938
1939         Skip the FontConfig settings initialization in WebKitTestRunner if the
1940         WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
1941         This is useful when profiling the WebKitTestRunner execution, where at the startup
1942         this step takes considerable amount of time and disturbs the profiling output.
1943
1944         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1945         (WTR::initializeFontConfigSetting):
1946
1947 2014-01-14  Brian J. Burg  <burg@cs.washington.edu>
1948
1949         Add ENABLE(WEB_REPLAY) feature flag to the build system
1950         https://bugs.webkit.org/show_bug.cgi?id=126949
1951
1952         Reviewed by Joseph Pecoraro.
1953
1954         * Scripts/webkitperl/FeatureList.pm:
1955
1956 2014-01-14  László Langó  <llango.u-szeged@partner.samsung.com>
1957
1958         REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
1959         https://bugs.webkit.org/show_bug.cgi?id=126702
1960
1961         Reviewed by Alexey Proskuryakov.
1962
1963         Resolve regression and remove a FIXME comment that is already fixed.
1964
1965         * Scripts/webkitpy/common/system/filesystem.py:
1966         (FileSystem.open_text_file_for_reading):
1967         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1968         (RealFileSystemTest.test_read_and_write_file):
1969         * Scripts/webkitpy/style/filereader.py:
1970         (TextFileReader._read_lines):
1971         * Scripts/webkitpy/style/filereader_unittest.py:
1972         (TextFileReaderTest.test_count_delete_only_file):
1973         (TextFileReaderTest):
1974         (TextFileReaderTest.test_process_malformed_file):
1975
1976 2014-01-02  Brian Holt  <brian.holt@samsung.com>
1977
1978         [GTK] Parse Valgrind xml leak files
1979         https://bugs.webkit.org/show_bug.cgi?id=119446
1980
1981         Reviewed by Alejandro G. Castro.
1982
1983         Parse the xml files generated by Valgrind to yield useful
1984         information about the memory leaks.
1985
1986         * Scripts/webkitpy/port/gtk.py:
1987         (GtkPort.__init__):
1988         (GtkPort.setup_test_run): Clear the previous output files before new
1989         run.
1990         (GtkPort.print_leaks_summary):
1991
1992         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
1993         Parse the xml files generated by Valgrind and summarise leaks
1994         into an easily understandable list.
1995         (get_text_of):
1996         (get_CDATA_of):
1997         (gather_frames):
1998         (ValgrindError):
1999         (ValgrindError.__init__):
2000         (ValgrindError.__str__):
2001         (ValgrindError.unique_string):
2002         (ValgrindError.error_hash):
2003         (ValgrindError.__hash__):
2004         (ValgrindError.__eq__):
2005         (LeakDetectorValgrind):
2006         (LeakDetectorValgrind.__init__):
2007         (LeakDetectorValgrind._parse_leaks_output):
2008         (LeakDetectorValgrind.leaks_files_in_results_directory):
2009         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2010         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2011
2012         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2013         (make_mock_valgrind_output):
2014         (make_mock_incomplete_valgrind_output):
2015         (make_mock_valgrind_results):
2016         (make_mock_valgrind_results_incomplete):
2017         (make_mock_valgrind_results_empty):
2018         (make_mock_valgrind_results_misformatted):
2019         (mock_run_cppfilt_command):
2020         (LeakDetectorValgrindTest):
2021         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2022         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2023         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2024         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2025         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2026         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2027         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2028         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2029
2030 2014-01-13  Lucas Forschler  <lforschler@apple.com>
2031
2032         Update the LLINT CLoop Bot build infrastructure
2033         https://bugs.webkit.org/show_bug.cgi?id=126604
2034         
2035         Unreviewed.
2036         
2037         * BuildSlaveSupport/build.webkit.org-config/config.json:
2038         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2039         (CompileLLINTCLoop):
2040         (RunLLINTCLoopTests):
2041         (BuildAndTestLLINTCLoopFactory):
2042         (BuildAndTestLLINTCLoopFactory.__init__):
2043
2044 2014-01-13  Jinwoo Song  <jinwoo7.song@samsung.com>
2045
2046         [EFL][WK2] Disable failing API tests
2047         https://bugs.webkit.org/show_bug.cgi?id=126960
2048
2049         Reviewed by Gyuyoung Kim.
2050
2051         Disable WKViewUserViewportToContents test until bug 126261 is resolved.
2052
2053         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
2054         (TestWebKitAPI::TEST):
2055
2056 2014-01-13  Daniel Batyai  <dbatyai.u-szeged@partner.samsung.com>
2057
2058         Remove wdiff
2059         https://bugs.webkit.org/show_bug.cgi?id=124766
2060
2061         Reviewed by Ryosuke Niwa.
2062
2063         * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
2064         (ResultsJSONParserTest):
2065         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2066         (TestResultWriter):
2067         (TestResultWriter.create_text_diff_and_write_result):
2068         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2069         (summarize_results):
2070         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2071         (RunTest.test_output_diffs):
2072         * Scripts/webkitpy/port/base.py:
2073         (Port.__init__):
2074         (Port.driver_stop_timeout):
2075         (Port.check_image_diff):
2076         (Port.repository_paths):
2077         (Port._path_to_lighttpd_php):
2078         * Scripts/webkitpy/port/base_unittest.py:
2079         (PortTest.test_default_child_processes):
2080         (PortTest.test_pretty_patch_script_error):
2081         * Scripts/webkitpy/port/port_testcase.py:
2082         (PortTestCase.test_diff_image_crashed):
2083         * Scripts/webkitpy/port/test.py:
2084         (TestPort.operating_system):
2085
2086 2014-01-13  Martin Robinson  <mrobinson@igalia.com>
2087
2088         Build fix for the GTK+ CMake port
2089
2090         * TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
2091
2092 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2093
2094         [GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
2095         https://bugs.webkit.org/show_bug.cgi?id=126881
2096
2097         Reviewed by Carlos Garcia Campos.
2098
2099         * MiniBrowser/gtk/BrowserWindow.c:
2100         (browser_window_new):
2101         Explicitly cast GtkWindow** to gpointer* in call to
2102         g_object_add_weak_pointer to avoid compiler warnings.
2103
2104 2014-01-13  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2105
2106         Remove parsing of old-run-webkit-tests output from master.cfg
2107         https://bugs.webkit.org/show_bug.cgi?id=126690
2108
2109         Reviewed by Csaba Osztrogonác.
2110
2111         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2112         Removed parsing of ORWT output, as it is not used anymore.
2113         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2114         Updated unit tests accordingly.
2115
2116 2014-01-13  Commit Queue  <commit-queue@webkit.org>
2117
2118         Unreviewed, rolling out r161808.
2119         http://trac.webkit.org/changeset/161808
2120         https://bugs.webkit.org/show_bug.cgi?id=126874
2121
2122         This patch make several files to be always regenerated on
2123         every make (Requested by KaL on #webkit).
2124
2125         * WebKitTestRunner/GNUmakefile.am:
2126
2127 2014-01-13  Adrian Perez de Castro  <aperez@igalia.com>
2128
2129         [GTK] Make MiniBrowser windows non-transient by default
2130         https://bugs.webkit.org/show_bug.cgi?id=126840
2131
2132         Reviewed by Carlos Garcia Campos.
2133
2134         Instead of making new browser windows transient as soon as they are
2135         created, save the pointer to the parent window and set the transient
2136         state later on when handling the "run-as-modal" signal. This makes
2137         it easier to use the MiniBrowser to do tests involving multiple
2138         windows, and will be useful as well when multi-web-process mode is
2139         enabled for the GTK port.
2140
2141         * MiniBrowser/gtk/BrowserWindow.c:
2142         (webViewRunAsModal): Set the parent window using
2143         gtk_window_set_transient_for() using the saved parent
2144         window.
2145         (browser_window_new): Save the parent window using
2146         g_object_set_data() instead of making the new window
2147         transient immediately.
2148
2149 2014-01-12  Sergio Correia  <sergio.correia@openbossa.org>
2150
2151         [EFL][WK2] Make API tests work again
2152         https://bugs.webkit.org/show_bug.cgi?id=126769
2153
2154         Reviewed by Gyuyoung Kim.
2155
2156         The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
2157         [E]WebKit2, respectively, and this causes problems because the logic to find
2158         where WebProcess is to look in the same directory of the running process and
2159         then proceed to use LIBEXECDIR (typically /usr/loca/bin).
2160
2161         This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
2162         Gtk port, which allows us to look for WebProcess initially in this directory,
2163         if it's defined.
2164
2165         * TestWebKitAPI/efl/main.cpp:
2166         (main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.
2167
2168 2014-01-12  Daniel Bates  <dabates@apple.com>
2169
2170         [iOS] Fix the build
2171
2172         For now, ensure we build WebKit System Interface before we build WebKit.
2173         We'll remove this constraint and the constraint to build WebKit Additions
2174         in a subsequent commit.
2175
2176         * Scripts/build-webkit:
2177
2178 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2179
2180         Unreviewed. Fix make distcheck.
2181
2182         * gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py
2183         to EXTRA_DIST.
2184
2185 2014-01-12  Tobias Mueller  <tobiasmue@gnome.org>
2186
2187         --disable-dependency-tracking causes build failure due to missing directories
2188         https://bugs.webkit.org/show_bug.cgi?id=94488
2189
2190         Reviewed by Gustavo Noronha Silva.
2191
2192         Autotools build fix: Ensure output directory existing
2193         before generating DerivedSources. This allows for
2194         --disable-dependency-tracking to be run.
2195
2196
2197         * WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
2198
2199 2014-01-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2200
2201         [GTK] Fix return value of WebKitDownload::created-destination
2202         https://bugs.webkit.org/show_bug.cgi?id=126741
2203
2204         Reviewed by Martin Robinson.
2205
2206         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return
2207         value of several callbacks.
2208
2209 2014-01-11  Sam Weinig  <sam@webkit.org>
2210
2211         Add support for null StringViews
2212         https://bugs.webkit.org/show_bug.cgi?id=126827
2213
2214         Reviewed by Anders Carlsson.
2215
2216         Add new test for StringView.
2217
2218         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2219         * TestWebKitAPI/Tests/WTF/StringView.cpp: Added.
2220         (TestWebKitAPI::TEST):
2221
2222 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2223
2224         Remove the BlackBerry port from trunk
2225         https://bugs.webkit.org/show_bug.cgi?id=126715
2226
2227         Reviewed by Anders Carlsson.
2228
2229         * DumpRenderTree/DumpRenderTree.h:
2230         * DumpRenderTree/PixelDumpSupport.cpp:
2231
2232 2014-01-10  Daniel Bates  <dabates@apple.com>
2233
2234         [iOS] Fix project build order
2235
2236         Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
2237         build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
2238         time of writing.
2239
2240         * Scripts/build-webkit:
2241
2242 2014-01-10  Mario Sanchez Prada  <mario.prada@samsung.com>
2243
2244         Move platformName property from testRunner to accessibilityController
2245         https://bugs.webkit.org/show_bug.cgi?id=126689
2246
2247         Reviewed by Chris Fleizach.
2248
2249         Move the platformName property from the testRunner into
2250         accessibilityController, since this is a concept that has only be
2251         used by accessibility tests since it got added, and also because
2252         the real intention was not to distinguish among "ports" (mac, win,
2253         gtk, efl) but between platforms (atk, mac, win).
2254
2255         This change will be very useful to merge GTK's roles-exposed.html
2256         and Mac's role-subrole-roledescription.html into one single test,
2257         since we will be specifying in the test itself which elements are
2258         supported in which accessibility "platform". In this context,
2259         being able to check accessibilityController.platformName directly
2260         against a list of supported accessibility platforms (e.g. "atk,mac")
2261         will certainly maintain the code cleaner and simpler.
2262
2263         * DumpRenderTree/TestRunner.h:
2264         (TestRunner::platformName): Removed.
2265         * DumpRenderTree/TestRunner.cpp:
2266         (getPlatformNameCallback): Removed.
2267         (TestRunner::staticValues): Removed platformName
2268         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2269         (TestRunner::platformName): Removed.
2270         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2271         (TestRunner::platformName): Removed.
2272         * DumpRenderTree/mac/TestRunnerMac.mm:
2273         (TestRunner::platformName): Removed.
2274         * DumpRenderTree/win/TestRunnerWin.cpp:
2275         (TestRunner::platformName): Removed.
2276
2277         * DumpRenderTree/AccessibilityController.h:
2278         (AccessibilityController::platformName): Added.
2279         * DumpRenderTree/AccessibilityController.cpp:
2280         (getPlatformNameCallback): Added.
2281         (AccessibilityController::getJSClass): Added platformName.
2282         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2283         (AccessibilityController::platformName): Added, returning "atk".
2284         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2285         (AccessibilityController::platformName): Ditto, returning "mac".
2286         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2287         (AccessibilityController::platformName): Ditto, returning "ios".
2288         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2289         (AccessibilityController::platformName): Ditto, returning "win".
2290
2291         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2292         (platformName): Removed.
2293         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2294         (TestRunner::platformName): Removed.
2295         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2296         (TestRunner::platformName): Removed.
2297         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2298         (TestRunner::platformName): Removed.
2299         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2300         (TestRunner::platformName): Removed.
2301         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2302         (TestRunner::platformName): Removed.
2303
2304         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2305         (WTR:AccessibilityController::platformName): Added.
2306         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2307         (platformName): Added.
2308         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
2309         (WTR::AccessibilityController::platformName): Added, returning "atk".
2310         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2311         (WTR::AccessibilityController::platformName): Added, returning "mac".
2312
2313 2014-01-10  Benjamin Poulain  <bpoulain@apple.com>
2314
2315         Remove the BlackBerry port from trunk
2316         https://bugs.webkit.org/show_bug.cgi?id=126715
2317
2318         Reviewed by Anders Carlsson.
2319
2320         * Scripts/webkitpy/common/config/watchlist:
2321
2322 2014-01-09  Benjamin Poulain  <bpoulain@apple.com>
2323
2324         Remove the BlackBerry files outside WebCore
2325         https://bugs.webkit.org/show_bug.cgi?id=126715
2326
2327         Reviewed by Anders Carlsson.
2328
2329         * DumpRenderTree/blackberry: Removed.
2330
2331 2014-01-10  Simon Fraser  <simon.fraser@apple.com>
2332
2333         Remove knowledge of Blackberry from build scripts
2334         https://bugs.webkit.org/show_bug.cgi?id=126766
2335
2336         Reviewed by Anders Carlsson.
2337         
2338         Remove isBlackBerry() and references to it, and rmeove
2339         blackberry-related stuff from the watchlist.
2340
2341         * Scripts/build-webkit:
2342         * Scripts/webkit-build-directory:
2343         * Scripts/webkitdirs.pm:
2344         (determineBaseProductDir):
2345         (argumentsForConfiguration):
2346         (builtDylibPathForName):
2347         (isAppleWebKit):
2348         (buildCMakeProjectOrExit):
2349         (cmakeBasedPortArguments):
2350         (cmakeBasedPortName):
2351         * Scripts/webkitperl/FeatureList.pm:
2352         * Scripts/webkitpy/common/config/watchlist:
2353
2354 2014-01-10  Daniel Bates  <dabates@apple.com>
2355
2356         [iOS] Fix up simulator build and enable default features
2357
2358         Rubber-stamped by Joseph Pecoraro.
2359
2360         * Scripts/webkitdirs.pm:
2361         (determineArchitecture):
2362         (determinePassedArchitecture):
2363         * Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled
2364         by default only in iOS).
2365
2366 2014-01-10  Daniel Bates  <dabates@apple.com>
2367
2368         [iOS] Upstream WebCore and Tools miscellaneous changes
2369         https://bugs.webkit.org/show_bug.cgi?id=126698
2370
2371         Reviewed by David Kilzer.
2372
2373         * Scripts/check-for-inappropriate-objc-class-names:
2374         * Scripts/check-for-webkit-framework-include-consistency:
2375
2376 2014-01-09  Dan Bernstein  <mitz@apple.com>
2377
2378         [Cocoa] Promote WKBackForwardList{,Item}.h to public
2379         https://bugs.webkit.org/show_bug.cgi?id=126707
2380
2381         Reviewed by Sam Weinig.
2382
2383         * Scripts/check-for-webkit-framework-include-consistency: Account for stale private headers
2384         left behind in the build products directory after a private header is made public.
2385
2386 2014-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2387
2388         [SOUP] Partial file left on disk after a download fails or is cancelled in WebKit2
2389         https://bugs.webkit.org/show_bug.cgi?id=126686
2390
2391         Reviewed by Martin Robinson.
2392
2393         Test that partial files are not left on disk after a download has
2394         been cancelled after the destination has been decided. To make
2395         sure the download is cancelled after the destination has been
2396         decided and before the operation finishes, we cancel the download
2397         in the destination decided callback, and we use an infinite
2398         resource that writes chunks to the response body and never
2399         completes the body.
2400
2401         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
2402         (addContentDispositionHTTPHeaderToResponse): Helper function to
2403         add the Content-Disposition to the response headers.
2404         (writeNextChunkIdle): Write next chunk to response body.
2405         (writeNextChunk): Write next chunk in an idle to avoid flooding
2406         the network with the inifnite resource.
2407         (serverCallback): Add an inifinite resource.
2408         (testDownloadRemoteFileError): Check that partial file is not
2409         present after the download has been cancelled.
2410
2411 2014-01-09  Roland Takacs  <rtakacs@inf.u-szeged.hu>
2412
2413         Move myself to the committers list.
2414
2415         Unreviewed.
2416
2417         * Scripts/webkitpy/common/config/contributors.json:
2418
2419 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2420
2421         [GTK] Unreviewed build fix after r161522.
2422
2423         * TestWebKitAPI/GNUmakefile.am: Remove WKConnection.cpp and WKConnection_Bundle.cpp.
2424
2425 2014-01-08  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2426
2427         Missleading style error when mixing system and non-system header include lines.
2428         https://bugs.webkit.org/show_bug.cgi?id=126564
2429
2430         Reviewed by Ryosuke Niwa.
2431
2432         * Scripts/webkitpy/style/checkers/cpp.py:
2433         (check_include_line):
2434         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2435         (OrderOfIncludesTest.test_check_alphabetical_include_order):
2436         (OrderOfIncludesTest.test_public_primary_header):
2437
2438 2014-01-08  Seokju Kwon  <seokju@webkit.org>
2439
2440         [EFL] Unreviewed build fix after r161522.
2441
2442         * TestWebKitAPI/CMakeLists.txt:
2443         * TestWebKitAPI/PlatformEfl.cmake:
2444
2445 2014-01-08  Anders Carlsson  <andersca@apple.com>
2446
2447         Remove WKConnectionRef tests
2448         https://bugs.webkit.org/show_bug.cgi?id=126666
2449
2450         Reviewed by Dan Bernstein.
2451
2452         The WKConnectionRef is poorly designed but thankfully not used anywhere. 
2453         Remove the API tests as a first step towards killing the entire thing.
2454
2455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2456         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Removed.
2457         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Removed.
2458
2459 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2460
2461         Unreviewed, rolling out r161512.
2462         http://trac.webkit.org/changeset/161512
2463         https://bugs.webkit.org/show_bug.cgi?id=126655
2464
2465         Broke webkitpy tests (Requested by ap on #webkit).
2466
2467         * Scripts/webkitpy/port/gtk.py:
2468         (GtkPort.__init__):
2469         (GtkPort.setup_test_run):
2470         (GtkPort._port_specific_expectations_files):
2471         * Scripts/webkitpy/port/leakdetector_valgrind.py: Removed.
2472         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Removed.
2473
2474 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2475
2476         Unreviewed, rolling out r161517.
2477         http://trac.webkit.org/changeset/161517
2478         https://bugs.webkit.org/show_bug.cgi?id=126659
2479
2480         The fix didn't completely remove the problem and is now
2481         standing in the way of the rollout of the offending patch
2482         (Requested by zdobersek on #webkit).
2483
2484         * Scripts/webkitpy/port/gtk.py:
2485         (GtkPort.__init__):
2486
2487 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2488
2489         Unreviewed. Attempting to fix webkitpy tests after r161512.
2490
2491         * Scripts/webkitpy/port/gtk.py:
2492         (GtkPort.__init__): Construct LeakDetectorValgrin only if leak detection is enabled.
2493
2494 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2495
2496         [GTK] Parse Valgrind xml leak files
2497         https://bugs.webkit.org/show_bug.cgi?id=119446
2498
2499         Reviewed by Alejandro G. Castro.
2500
2501         Parse the xml files generated by Valgrind to yield useful
2502         information about the memory leaks.
2503
2504         * Scripts/webkitpy/port/gtk.py:
2505         (GtkPort.__init__):
2506         (GtkPort.setup_test_run): Clear the previous output files before new
2507         run.
2508         (GtkPort.print_leaks_summary):
2509
2510         * Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
2511         Parse the xml files generated by Valgrind and summarise leaks
2512         into an easily understandable list.
2513         (get_text_of):
2514         (get_CDATA_of):
2515         (gather_frames):
2516         (ValgrindError):
2517         (ValgrindError.__init__):
2518         (ValgrindError.__str__):
2519         (ValgrindError.unique_string):
2520         (ValgrindError.error_hash):
2521         (ValgrindError.__hash__):
2522         (ValgrindError.__eq__):
2523         (LeakDetectorValgrind):
2524         (LeakDetectorValgrind.__init__):
2525         (LeakDetectorValgrind._parse_leaks_output):
2526         (LeakDetectorValgrind.leaks_files_in_results_directory):
2527         (LeakDetectorValgrind.clean_leaks_files_from_results_directory):
2528         (LeakDetectorValgrind.parse_and_print_leaks_detail):
2529
2530         * Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
2531         (make_mock_valgrind_output):
2532         (make_mock_incomplete_valgrind_output):
2533         (make_mock_valgrind_results):
2534         (make_mock_valgrind_results_incomplete):
2535         (make_mock_valgrind_results_empty):
2536         (make_mock_valgrind_results_misformatted):
2537         (LeakDetectorValgrindTest):
2538         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2539         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2540         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2541         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2542         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
2543         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
2544         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
2545         (LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
2546
2547 2014-01-08  Commit Queue  <commit-queue@webkit.org>
2548
2549         Unreviewed, rolling out r161427.
2550         http://trac.webkit.org/changeset/161427
2551         https://bugs.webkit.org/show_bug.cgi?id=126645
2552
2553         Emits a stye error on any newly added files (Requested by ap
2554         on #webkit).
2555
2556         * Scripts/webkitpy/style/checkers/cpp.py:
2557         (check_style):
2558         (CppChecker):
2559         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2560         (WebKitStyleTest.test_other):
2561
2562 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2563
2564         Remove run-webkit-tests wrapper script as all platform are using NRWT now.
2565         https://bugs.webkit.org/show_bug.cgi?id=126580
2566
2567         Reviewed by Csaba Osztrogonác.
2568
2569         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2570         (RunWebKitTests): Passing --debug-rwt-logging here instead of the
2571         run-webkit-tests script.
2572         * Scripts/new-run-webkit-tests: Renamed to run-webkit-tests.
2573         * Scripts/run-webkit-tests: Removed, as it was just a temporary hack.
2574
2575 2014-01-08  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2576
2577         Update the list of non-committer u-szeged contributors
2578         https://bugs.webkit.org/show_bug.cgi?id=126640
2579
2580         Reviewed by Csaba Osztrogonác.
2581
2582         * Scripts/webkitpy/common/config/contributors.json:
2583
2584 2014-01-08  Alberto Garcia  <berto@igalia.com>
2585
2586         Fix some compilation warnings
2587         https://bugs.webkit.org/show_bug.cgi?id=126635
2588
2589         Reviewed by Csaba Osztrogonác.
2590
2591         * GtkLauncher/main.c:
2592         (createWindow): This function is not supposed to receive any
2593         parameter, yet we are passing one.
2594
2595 2014-01-08  Brian Holt  <brian.holt@samsung.com>
2596
2597         [GTK][WK2] unskip passing unit tests
2598         https://bugs.webkit.org/show_bug.cgi?id=126637
2599
2600         Reviewed by Carlos Garcia Campos.
2601
2602         Unskip TestResources and TestAuthentication unit tests since they
2603         are passing both under Xvfb and X.
2604
2605         * Scripts/run-gtk-tests:
2606         (TestRunner):
2607
2608 2014-01-08  Alberto Garcia  <berto@igalia.com>
2609
2610         REGRESSION(r160304): [GTK] Disable libtool fast install
2611         https://bugs.webkit.org/show_bug.cgi?id=126381
2612
2613         Reviewed by Gustavo Noronha Silva.
2614
2615         Disable the libtool fast-install mode in developer/test builds.
2616
2617         In this mode binaries are generated ready to be used directly from
2618         the build tree. Otherwise they would need to be relinked when they
2619         are executed, which can take a lot of resources, particularly in
2620         debug builds.
2621
2622         * Scripts/webkitdirs.pm:
2623         (runAutogenForAutotoolsProjectIfNecessary):
2624
2625 2014-01-08  Zan Dobersek  <zdobersek@igalia.com>
2626
2627         Unreviewed GTK gardening.
2628
2629         * Scripts/run-gtk-tests:
2630         (TestRunner): Skipping the snapshot test case from the TestWebKitWebView test suite.
2631         The test is failing due to issues with Xvfb, with the problem being handled in bug #120404.
2632
2633 2014-01-07  Lucas Forschler  <lforschler@apple.com>
2634
2635         Add buildbot infrasctructure for building and testing JSC cloop
2636         https://bugs.webkit.org/show_bug.cgi?id=126604
2637
2638         Reviewed by Geoffrey Garen.
2639
2640         * BuildSlaveSupport/build.webkit.org-config/config.json:
2641         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2642         (CompileCLOOP):
2643         (RunCLOOPTests):
2644         (RunCLOOPTests.countFailures):
2645         (BuildAndTestCLOOP):
2646
2647 2014-01-07  Brian Burg  <bburg@apple.com>
2648
2649         Unreviewed. Add myself as a committer.
2650
2651         * Scripts/webkitpy/common/config/contributors.json:
2652
2653 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2654
2655         Popovers at build.webkit.org/dashboard could have titles
2656         https://bugs.webkit.org/show_bug.cgi?id=126495
2657
2658         Reviewed by Timothy Hatcher.
2659
2660         Added titles to all popovers except for pending revisions one, which I would like
2661         to improve more (probably add an ETA).
2662
2663         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2664         (BuildbotBuilderQueueView.prototype._presentPopoverFailureLogs): Moved code for 
2665         adding a title to base class.
2666
2667         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2668         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved code for inserting
2669         a divider to a separate function.
2670         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Added a title.
2671         (BuildbotQueueView.prototype._presentNoChangePopover): Updated the text to match
2672         title from above function.
2673         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Renamed "contentElement"
2674         variable to "content" to match all other code.
2675         (BuildbotQueueView.prototype._addIterationHeadingToPopover): Added.
2676         (BuildbotQueueView.prototype._addDividerToPopover): Added.
2677
2678         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2679         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Add a title.
2680         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Ditto.
2681         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): Ditto.
2682
2683         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2684
2685 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2686
2687         There should be a delay when quickly switching to a different popover at build.webkit.org/dashboard
2688         https://bugs.webkit.org/show_bug.cgi?id=126472
2689
2690         Reviewed by Timothy Hatcher.
2691
2692         Added a delay when quickly switching to a different popover, making it easier to
2693         move mouse pointer from active element to its popover without accidentally opening
2694         a different popover.
2695
2696         Used this code to add a delay before creating a popover. This doesn't change UI
2697         behavior, as there was alerady a delay before it became visible, but it avoids
2698         flooding buildbot server with http requests when quickly moving the mouse over
2699         dashboard page.
2700
2701         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
2702         Fixed a case where popover could get stuck. If content was updated while fade-out
2703         transition was already in place, the transition was removed for no good reason.
2704
2705         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
2706         (PopoverTracker._onblur): While at it, also taught popovers to disappear on window blur.
2707
2708         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
2709         (.popover.step-in): Now that PopoverTracker has a 200ms delay of its own, reduced
2710         popover delay from 1s to 800ms.
2711
2712 2014-01-07  Alexey Proskuryakov  <ap@apple.com>
2713
2714         Improve display of failed builds at build.webkit.org/dashboard
2715         https://bugs.webkit.org/show_bug.cgi?id=126542
2716         <rdar://problem/15753550>
2717
2718         Reviewed by Timothy Hatcher.
2719
2720         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2721         Instead of hardcoding step name, look for the first step that failed.
2722         While at it, added a popover with more links. There are multiple, and it's good
2723         to have a choice of which one to look at in each situation.
2724
2725         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2726         (BuildbotIteration.prototype.get successful): Being successful is not the opposite
2727         of having failed. Many iterations are interrupted for whatever reason internal to
2728         Buildbot, and these are suppoed to be orange, not red.
2729         (BuildbotIteration.prototype.get productive): Changed to exclude inerrupted iterations,
2730         not only WillRetry ones.
2731         (BuildbotIteration.prototype.get failed): Changed to only include iterations that
2732         actually failed, more likely indicating a problem with code base.
2733         (BuildbotIteration.prototype.get firstFailedStepName):
2734         (BuildbotIteration.prototype.failureLogURL): Expose informaiton about failure.
2735         (BuildbotIteration.prototype.get failureLogs): Ditto.
2736         (BuildbotIteration.prototype.update): Store complete results for the failed step.
2737         Not every failure stops the iteration, so we could have multiple failed steps,
2738         but let's see if seeing just the first one will be enough.
2739
2740         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2741         (BuildbotQueue.prototype.get firstRecentUnsuccessfulIteration): Updated to work in
2742         terms of successful iterations.
2743         (BuildbotQueue.prototype.get mostRecentSuccessfulIteration): Ditto.
2744
2745         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2746         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Updated to work in
2747         terms of successful iterations.
2748
2749         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2750         Removed code to create a path to build output, we now take it from results JSON.
2751
2752         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2753         Added styles for the new popover.
2754
2755 2014-01-07  Gergo Balogh  <geryxyz@inf.u-szeged.hu>
2756
2757         defined constants should use all uppercase names with words separated by underscores.
2758         https://bugs.webkit.org/show_bug.cgi?id=126055
2759
2760         Reviewed by Alexey Proskuryakov.
2761
2762         * Scripts/webkitpy/style/checkers/cpp.py:
2763         (check_style):
2764         (CppChecker):
2765         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2766         (WebKitStyleTest.test_define_constants):
2767
2768 2014-01-07  Brian Holt  <brian.holt@samsung.com>
2769
2770         Unreviewed. Add myself as a committer.
2771
2772         * Scripts/webkitpy/common/config/contributors.json:
2773
2774 2014-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2775
2776         Remove the WinCE buildbot from build.webkit.org
2777         https://bugs.webkit.org/show_bug.cgi?id=126517
2778
2779         Reviewed by Alexey Proskuryakov.
2780
2781         * BuildSlaveSupport/build.webkit.org-config/config.json:
2782         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2783         (appendCustomBuildFlags):
2784
2785 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
2786
2787         [EFL] Change ATK version to 2.11.4
2788         https://bugs.webkit.org/show_bug.cgi?id=126573
2789
2790         Reviewed by Gyuyoung Kim.
2791
2792         ATK 2.11.4 introduces some new roles, that are already being used by WebKit.
2793
2794         * efl/jhbuild.modules:
2795
2796 2014-01-07  Alberto Garcia  <berto@igalia.com>
2797
2798         [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher
2799         https://bugs.webkit.org/show_bug.cgi?id=117275
2800
2801         Reviewed by Carlos Garcia Campos.
2802
2803         If we are not using the internal jhbuild we must not use the
2804         jhbuild-wrapper script, else it will try to download and install
2805         it.
2806
2807         * Scripts/run-launcher:
2808
2809 2014-01-07  Krzysztof Czech  <k.czech@samsung.com>
2810
2811         [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
2812         https://bugs.webkit.org/show_bug.cgi?id=125855
2813
2814         Reviewed by Mario Sanchez Prada.
2815
2816         Added new function isIndeterminate for testing aria-checked mixed state.
2817         I provided respective, but empty function in mac port. Mac testing it differently.
2818
2819         * DumpRenderTree/AccessibilityUIElement.cpp:
2820         (getIsIndeterminate):
2821         (AccessibilityUIElement::getJSClass):
2822         * DumpRenderTree/AccessibilityUIElement.h:
2823         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2824         (AccessibilityUIElement::isIndeterminate):
2825         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm: Added empty function.
2826         (AccessibilityUIElement::isIndeterminate):
2827         * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added empty function.
2828         (AccessibilityUIElement::isIndeterminate):
2829         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added empty function.
2830         (AccessibilityUIElement::isIndeterminate):
2831         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2832         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2833         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2834         (WTR::AccessibilityUIElement::isIndeterminate):
2835         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2836         (WTR::AccessibilityUIElement::isIndeterminate):
2837
2838 2014-01-06  Mark Rowe  <mrowe@apple.com>
2839
2840         <https://webkit.org/b/126560> Fix incorrectness in use of some AppKit enums
2841
2842         Reviewed by Ryosuke Niwa.
2843
2844         * DumpRenderTree/mac/DumpRenderTree.mm:
2845         (-[DRTMockScroller rectForPart:]): Move to using an if with early return instead of a switch
2846         with a single case. This avoids the potential for warnings about unhandled cases.
2847         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2848         (WTR::PlatformWebView::PlatformWebView): Cast the argument to NSBackingStoreType.
2849
2850 2014-01-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2851
2852         [GTK] Move all GTK/GObject unit tests to Tools/TestWebKitAPI
2853         https://bugs.webkit.org/show_bug.cgi?id=126342
2854
2855         Reviewed by Gustavo Noronha Silva.
2856
2857         * CMakeLists.txt: Include the new unit tests subdirectories.
2858         * Scripts/run-gtk-tests: Update to refer to the new build locations.
2859         * Scripts/webkitpy/style/checker.py: Update the style checker.
2860         * Scripts/webkitpy/style/checker_unittest.py:
2861         * TestWebKitAPI/GNUmakefile.am:
2862         * TestWebKitAPI/Tests/WebKit2Gtk/AccessibilityTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/AccessibilityTestServer.cpp.
2863         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Added.
2864         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp: Added.
2865         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/DOMNodeTest.cpp.
2866         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/FrameTest.cpp.
2867         * TestWebKitAPI/Tests/WebKit2Gtk/InspectorTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/InspectorTestServer.cpp.
2868         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.cpp.
2869         * TestWebKitAPI/Tests/WebKit2Gtk/LoadTrackingTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/LoadTrackingTest.h.
2870         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestAuthentication.cpp.
2871         * TestWebKitAPI/Tests/WebKit2Gtk/TestBackForwardList.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestBackForwardList.cpp.
2872         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestContextMenu.cpp.
2873         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestCookieManager.cpp.
2874         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMDOMWindow.cpp: Added.
2875         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDOMNode.cpp.
2876         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestDownloads.cpp.
2877         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestFrame.cpp.
2878         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspector.cpp.
2879         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestInspectorServer.cpp.
2880         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestLoaderClient.cpp.
2881         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.cpp.
2882         * TestWebKitAPI/Tests/WebKit2Gtk/TestMain.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestMain.h.
2883         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestPrinting.cpp.
2884         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestResources.cpp.
2885         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestSSL.cpp.
2886         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestUIClient.cpp.
2887         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebExtensions.cpp.
2888         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp.
2889         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp.
2890         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitFindController.cpp.
2891         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitPolicyClient.cpp.
2892         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitSettings.cpp.
2893         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitVersion.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitVersion.cpp.
2894         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebContext.cpp.
2895         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebView.cpp.
2896         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebViewGroup.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp.
2897         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/TestWebViewEditor.cpp.
2898         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebExtensionTest.cpp.
2899         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.cpp.
2900         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestBus.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestBus.h.
2901         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp.
2902         * TestWebKitAPI/Tests/WebKit2Gtk/WebKitTestServer.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.h.
2903         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.cpp.
2904         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h.
2905         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.cpp.
2906         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTestRunner.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTestRunner.h.
2907         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.cpp: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.cpp.
2908         * TestWebKitAPI/Tests/WebKit2Gtk/WebViewTest.h: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/WebViewTest.h.
2909         * TestWebKitAPI/Tests/WebKit2Gtk/resources/link-title.js: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/link-title.js.
2910         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-cert.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-cert.pem.
2911         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test-key.pem: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/test-key.pem.
2912         * TestWebKitAPI/Tests/WebKit2Gtk/resources/webkit2gtk-tests.gresource.xml: Renamed from Source/WebKit2/UIProcess/API/gtk/tests/resources/webkit2gtk-tests.gresource.xml.
2913         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Added.
2914         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Renamed from Source/WebKit/gtk/tests/resources/blank.ico.
2915         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Renamed from Source/WebKit/gtk/tests/resources/test.html.
2916         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Renamed from Source/WebKit/gtk/tests/resources/test.ogg.
2917         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Renamed from Source/WebKit/gtk/tests/resources/test.pdf.
2918         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Renamed from Source/WebKit/gtk/tests/resources/test.txt.
2919         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Renamed from Source/WebKit/gtk/tests/test_utils.c.
2920         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Renamed from Source/WebKit/gtk/tests/test_utils.h.
2921         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Renamed from Source/WebKit/gtk/tests/testapplicationcache.c.
2922         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Renamed from Source/WebKit/gtk/tests/testatk.c.
2923         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Renamed from Source/WebKit/gtk/tests/testatkroles.c.
2924         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Renamed from Source/WebKit/gtk/tests/testcontextmenu.c.
2925         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Renamed from Source/WebKit/gtk/tests/testcopyandpaste.c.
2926         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Renamed from Source/WebKit/gtk/tests/testdomdocument.c.
2927         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Renamed from Source/WebKit/gtk/tests/testdomdomwindow.c.
2928         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Renamed from Source/WebKit/gtk/tests/testdomnode.c.
2929         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Renamed from Source/WebKit/gtk/tests/testdownload.c.
2930         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Renamed from Source/WebKit/gtk/tests/testfavicondatabase.c.
2931         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Renamed from Source/WebKit/gtk/tests/testglobals.c.
2932         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Renamed from Source/WebKit/gtk/tests/testhittestresult.c.
2933         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Renamed from Source/WebKit/gtk/tests/testhttpbackend.c.
2934         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Renamed from Source/WebKit/gtk/tests/testkeyevents.c.
2935         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Renamed from Source/WebKit/gtk/tests/testloading.c.
2936         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Renamed from Source/WebKit/gtk/tests/testmimehandling.c.
2937         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Renamed from Source/WebKit/gtk/tests/testnetworkrequest.c.
2938         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Renamed from Source/WebKit/gtk/tests/testnetworkresponse.c.
2939         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Renamed from Source/WebKit/gtk/tests/testwebbackforwardlist.c.
2940         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Renamed from Source/WebKit/gtk/tests/testwebdatasource.c.
2941         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Renamed from Source/WebKit/gtk/tests/testwebframe.c.
2942         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Renamed from Source/WebKit/gtk/tests/testwebhistoryitem.c.
2943         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Renamed from Source/WebKit/gtk/tests/testwebinspector.c.
2944         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Renamed from Source/WebKit/gtk/tests/testwebplugindatabase.c.
2945         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Renamed from Source/WebKit/gtk/tests/testwebresource.c.
2946         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Renamed from Source/WebKit/gtk/tests/testwebsettings.c.
2947         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Renamed from Source/WebKit/gtk/tests/testwebview.c.
2948         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Renamed from Source/WebKit/gtk/tests/testwindow.c.
2949
2950 2014-01-06  Alexey Proskuryakov  <ap@apple.com>
2951
2952         Gtk and Efl API test results confuse the dashboard
2953         https://bugs.webkit.org/show_bug.cgi?id=126535
2954
2955         Reviewed by Tim Horton.
2956
2957         Added "API tests" step as "platform api tests".
2958
2959         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
2960         (Buildbot.prototype.platformAPITestResultsURLForIteration):
2961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2962         (BuildbotIteration):
2963         (BuildbotIteration.prototype.update):
2964         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2965         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
2966         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
2967
2968 2014-01-06  Tim Horton  <timothy_horton@apple.com>
2969
2970         build.webkit.org/dashboard should still function if localStorage is disabled
2971         https://bugs.webkit.org/show_bug.cgi?id=126511
2972
2973         Reviewed by Alexey Proskuryakov.
2974
2975         If localStorage is disabled, we should carry on with a warning.
2976
2977         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2978         Don't show the gear if localStorage isn't working.
2979
2980         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2981         (QueueView.prototype._updateHiddenState):
2982         Bail if localStorage isn't working.
2983
2984         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Settings.js:
2985         (Settings.prototype.available):
2986
2987 2014-01-02  Roger Fong  <roger_fong@apple.com>
2988
2989         Set VSINSTALLDIR in win ews start script.
2990         https://bugs.webkit.org/show_bug.cgi?id=126407
2991
2992         Reviewed by Brent Fulgham.
2993
2994         * EWSTools/start-queue-win.sh:
2995
2996 2014-01-06  Bem Jones-Bey  <bjonesbe@adobe.com>
2997
2998         Adding myself as a reviewer.
2999
3000         Unreviewed.
3001
3002         * Scripts/webkitpy/common/config/contributors.json:
3003
3004 2014-01-06  Zan Dobersek  <zdobersek@igalia.com>
3005
3006         Unreviewed. Unbreaking JSC tests after r161328.
3007
3008         * Scripts/webkitdirs.pm:
3009         (cmakeBasedPortName): Only recognize the GTK port as CMake-based if actually building
3010         through the CMake build system (i.e. passing --gtkcmake to build-webkit).
3011
3012 2014-01-05  Martin Robinson  <mrobinson@igalia.com>
3013
3014         [GTK][CMake] Add support for building the GTK+ port with cmake to build-webkit
3015         https://bugs.webkit.org/show_bug.cgi?id=126212
3016
3017         Reviewed by Daniel Bates.
3018
3019         Allow building the GTK+ cmake port with --gtkcmake.
3020
3021         * Scripts/build-webkit: Use the new isGtkCMake function to head down the CMake path
3022         when appropriate. Skip the autotoos path when isGtkAutotools is false.
3023         * Scripts/webkitdirs.pm: Add an isGtkCMake path in addition to the newly renamed isGtkAutotools.
3024         Add isGtk which checks isGtkCMake || isGtkAutotools
3025         (determineArchitecture): Use the CMake path for GTK+ when appropriate.
3026         (argumentsForConfiguration): use --gtkcmake when appropriate.
3027         (jscProductDir): Look in the CMake directory when appropriate.
3028         (builtDylibPathForName): CMake builds the library into a different directory, so handle that.
3029         (determineIsGtkCMake): Added.
3030         (isGtkCMake): Added.
3031         (isGtkAutotools): Renamed from isGtk.
3032         (isGtk): New function which returns isGtkAutotools || isGtkCMake.
3033         (determineIsGtkAutotools): Renamed from determineIsGtk.
3034         (cmakeBasedPortName): Added a GTK+ path.
3035
3036 2014-01-04  Martin Robinson  <mrobinson@igalia.com>
3037
3038         [GTK] [CMake] Fix the video and audio build
3039         https://bugs.webkit.org/show_bug.cgi?id=126464
3040
3041         Reviewed by Philippe Normand.
3042
3043         * GtkLauncher/CMakeLists.txt: Add GStreamer includes and libraries, since GtkLauncher uses it.
3044
3045 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3046
3047         It's confusing to have two elements link to the same URL at build.webkit.org/dashboard
3048         https://bugs.webkit.org/show_bug.cgi?id=126467
3049
3050         Reviewed by Geoffrey Garen.
3051
3052         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3053         (StatusLineView): Don't linkify the label text, the bubble is easier to target with mouse
3054         pointer, or to tap.
3055
3056 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3057
3058         build.webkit.org/dashboard says "failed build" even if it's another step that failed
3059         https://bugs.webkit.org/show_bug.cgi?id=126461
3060
3061         Reviewed by Geoffrey Garen.
3062
3063         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3064         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus): Link to main
3065         build page if it's not the compilation that failed. Use text from buildbot for description.
3066         Show a yellow icon if it's a different kind of failure.
3067
3068         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3069         (BuildbotIteration.prototype.update): Record whether it was compile-webkit step that failed.
3070
3071 2014-01-03  Bem Jones-Bey  <bjonesbe@adobe.com>
3072
3073         setup-git-clone fails to get email address from git
3074         https://bugs.webkit.org/show_bug.cgi?id=126446
3075
3076         Reviewed by Ryosuke Niwa.
3077
3078         The setup-git-clone command fails to get an email address from git
3079         because of a bug in VCSUtils. This patch fixes that bug, and also
3080         makes it so that when VCSUtils fails for real because of a local
3081         misconfiguration, the error message is actually presented to the user
3082         of setup-git-clone.
3083
3084         * Scripts/VCSUtils.pm:
3085         (gitConfig): Call isGit() instead of accessing $isGit directly to make
3086             sure that $isGit is properly initialized.
3087         * Scripts/webkitpy/tool/commands/setupgitclone.py:
3088         (SetupGitClone.execute): Pull out username and email acquistion to
3089             it's own method.
3090         (SetupGitClone._get_username_and_email): Catch the exception thrown
3091             when VCSUtils fails and print out the error message so that the
3092             user actually knows why the command failed.
3093
3094 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3095
3096         It feels too hard to get rid of a popover at build.webkit.org/dashboard
3097         https://bugs.webkit.org/show_bug.cgi?id=126451
3098
3099         Reviewed by Simon Fraser.
3100
3101         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
3102         (.popover.fade-out): Reduced the timeout - 200 ms is enough to not have flicker
3103         when moving the mouse from an element to its popover.
3104
3105 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3106
3107         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3108         https://bugs.webkit.org/show_bug.cgi?id=122181
3109
3110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3111         (BuildbotQueueView.prototype._presentNoChangePopover): Update one more place for
3112         popover.present signature change.
3113
3114 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3115
3116         Please add a way to quick peek at failing tests at build.webkit.org/dashboard
3117         https://bugs.webkit.org/show_bug.cgi?id=122181
3118
3119         Reviewed by Timothy Hatcher and Timothy Horton.
3120
3121         Detailed results are saved by run-webkit-tests to full_results.json (which is actually
3122         JSONP). Dashboard will load them on demand.
3123
3124         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3125         (Buildbot.prototype.layoutTestResultsURLForIteration): Moved from WebKitBuildbot.js
3126         and made it use a function from WebKitBuildbot that builds results directory path.
3127         (Buildbot.prototype.layoutTestFullResultsURLForIteration): Added a function that builds
3128         a URL for full_results.json.
3129         (Buildbot.prototype.layoutTestCrashLogForIteration): Added a function that builds
3130         a URL for a crash log.
3131
3132         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3133         (BuildbotIteration.prototype.loadLayoutTestResults): Load and cache layout test results for
3134         the iteration.
3135
3136         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:        
3137         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Updated for changed
3138         popover API (see below).
3139         (BuildbotQueueView.prototype._presentPopoverForRevisionRange): Ditto.
3140
3141         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3142         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus): Added a check
3143         for iterations that were interrupted (previously, they were displayed incorrectly,
3144         often as passes). Install popover trackers for failure bubbles for which we can currently
3145         display something useful.
3146         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Build
3147         a popover for layout test regressions when we have the data loaded on demand.
3148         We have test paths, special indicators for crashes/timeouts, and links to test history
3149         at flakiness dashboard.
3150         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Show
3151         the popover for layout test regressions. Just shows "Loading..." until the data is
3152         loaded.
3153         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds): List
3154         types of failures if there are multiple. There is a lot of similarity with
3155         appendBuilderQueueStatus(), but I couldn't find a good way to share the code.
3156
3157         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
3158         Create a global test history object, which is used for links in layout test popover.
3159
3160         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Popover.js:
3161         Changed the API to be more like WebInspector again, allowing for changing content
3162         of an existing popover. As the size of a popover can change, making the mouse pointer
3163         enter it without a mousenter event, install a handler for mousewheel instead, and block
3164         document scrolling from this event handler when needed.
3165
3166         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3167         (StatusLineView.prototype.get statusBubbleElement): Added an accessor for status
3168         bubble element, making it possible to install a popover on it.
3169
3170         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3171         (JSON.load): Added the ability to load JSONP by providing an optional callback name.
3172
3173         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3174         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Switched from
3175         building a complete results URL to only building one for root results path. This is
3176         the part that depends on specific buildbot installation, everything relative to it
3177         is the same.
3178
3179         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js: Added.
3180         Build a path to test history page. In the future, we may consider adding code to
3181         load the data and display it inline.
3182
3183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3184         Added styles for this new popover.
3185
3186         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added
3187         a new file, WebKitTestHistory.js.
3188
3189 2014-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3190
3191         REGRESSION(r161214): [GTK] WebKit2 C API tests fail to run after r161214
3192         https://bugs.webkit.org/show_bug.cgi?id=126430
3193
3194         Reviewed by Martin Robinson.
3195
3196         * Scripts/run-gtk-tests:
3197         (TestRunner._setup_testing_environment):
3198         * gtk/common.py: Use common.tests_library_build_path() instead.
3199         (tests_library_build_path): Helper funtion that returns the path
3200         where the tests libraries are built.
3201
3202 2014-01-03  Martin Robinson  <mrobinson@igalia.com>
3203
3204         [CMake] Build TestWebKitAPI tests into a directory structure
3205         https://bugs.webkit.org/show_bug.cgi?id=126358
3206
3207         Reviewed by Gyuyoung Kim.
3208
3209         WebKitGTK+ builds the TestWebKitAPI tests into a "TestWebKitAPI" directory. This
3210         is useful for keeping the "bin" directory tidy during building and will make it easier
3211         to integrate the CMake build into the existing WebKitGTK+ scripts.
3212
3213         * TestWebKitAPI/CMakeLists.txt: Set the output directory of all TestWebKitAPI binaries
3214         and make the names simpler now that the directory identifies what category the test is in.
3215
3216 2014-01-03  Alexey Proskuryakov  <ap@apple.com>
3217
3218         Provide a visual clue when element has a popover at build.webkit.org/dashboard
3219         https://bugs.webkit.org/show_bug.cgi?id=126281
3220
3221         Reviewed by Timothy Hatcher.
3222
3223         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3224         (PopoverTracker): Add a class name to elements with popovers.
3225
3226         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3227         (*): We have -webkit-user-select:none, so let's also not show text selection cursor.
3228         I might have broke that recently.
3229         (*:link): Show hand cursor over links.
3230         (.popover-tracking:hover): Put a shadow on hover over element with popovers.
3231
3232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3233         (.status-line .message .revision-number): Show text selection cursor on our only
3234         selectable text element.
3235         (.status-line .bubble.popover-tracking:hover): Text in a bubble looks better with
3236         a white shadow than with a dark one on hover.
3237
3238 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3239
3240         [GTK] Add API to WebKitResponsePolicyDecision to check if the MIME type can be shown
3241         https://bugs.webkit.org/show_bug.cgi?id=124652
3242
3243         Reviewed by Martin Robinson.
3244
3245         * MiniBrowser/gtk/BrowserWindow.c:
3246         (webViewDecidePolicy): Use the new API instead of
3247         webkit_web_view_can_show_mime_type().
3248
3249 2014-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
3250
3251         REGRESSION(r160304): [GTK] Disable libtool fast install
3252         https://bugs.webkit.org/show_bug.cgi?id=126381
3253
3254         Reviewed by Martin Robinson.
3255
3256         Remove -no-fast-install ld flag since fast install is now disabled
3257         globally.
3258
3259         * GNUmakefile.am:
3260         * GtkLauncher/GNUmakefile.am:
3261         * MiniBrowser/gtk/GNUmakefile.am:
3262         * TestWebKitAPI/GNUmakefile.am:
3263         * WebKitTestRunner/GNUmakefile.am:
3264
3265 2014-01-02  Ryuan Choi  <ryuan.choi@samsung.com>
3266
3267         Unreviewed. Add myself to EFL and related watch lists.
3268
3269         * Scripts/webkitpy/common/config/watchlist:
3270
3271 2014-01-02  Danilo Cesar Lemes de Paula  <danilo.cesar@collabora.co.uk>
3272
3273         [GTK] fixing ycm_extra_conf.py file
3274         https://bugs.webkit.org/show_bug.cgi?id=126371
3275
3276         It's an attempt to fix three problems with the current ycm_extra_conf file.
3277         The current implementation assumes that it's a symlink, which is not true.
3278         Usually python creates a pyc file, and this is what you get in __file__.
3279         the .pyc is not a symlink, and the current implementation doesn't work
3280         if that's the case.
3281
3282         It also assumes that the user is in the root folder.
3283         If the user is in WebkitBuild/Debug and open a file as ../../Source/* it won't work.
3284
3285         Last but not least, "elif flag in FLAGS_PRECEDING_PATHS" emits an
3286         exception since "flag" doesn't exists.
3287
3288         All those things were fixed.
3289
3290         Reviewed by Martin Robinson.
3291
3292         * gtk/ycm_extra_conf.py:
3293         (transform_relative_paths_to_absolute_paths):
3294
3295 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3296
3297         Bindings tests results links are broken at build.webkit.org/dashboard
3298         https://bugs.webkit.org/show_bug.cgi?id=126402
3299
3300         Reviewed by Tim Horton.
3301
3302         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3303         (Buildbot.prototype.bindingsTestResultsURLForIteration): Fixed a typo that was there
3304         since the beginning.
3305
3306 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3307
3308         "+" is very confusing at http://build.webkit.org/dashboard
3309         https://bugs.webkit.org/show_bug.cgi?id=126400
3310
3311         Reviewed by Tim Horton.
3312
3313         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3314         (BuildbotQueueView.prototype._appendPendingRevisionCount): Instead of listing open
3315         source and internal counts separately, simply add them. One can always open a popover
3316         for more detail.
3317
3318 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3319
3320         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
3321         https://bugs.webkit.org/show_bug.cgi?id=126391
3322
3323         Reviewed by Dan Bernstein.
3324
3325         Make it conditional, as trac.webkit.org doesn't work when withCredentials is enabled.
3326         One can request credentials use via Initialization.js.
3327
3328         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
3329         (Trac):
3330         (Trac.prototype.update):
3331         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3332         (loadXML):
3333
3334 2014-01-02  Commit Queue  <commit-queue@webkit.org>
3335
3336         Unreviewed, rolling out r160846.
3337         http://trac.webkit.org/changeset/160846
3338         https://bugs.webkit.org/show_bug.cgi?id=126395
3339
3340         Breaks build scripts for Windows when Visual Studio is not
3341         installed in Program Files (Requested by rfong on #webkit).
3342
3343         * Scripts/webkitdirs.pm:
3344         (visualStudioInstallDir):
3345
3346 2014-01-02  Martin Robinson  <mrobinson@igalia.com>
3347
3348         [GTK] [CMake] run-gtk-tests should run with the cmake build
3349         https://bugs.webkit.org/show_bug.cgi?id=126341
3350
3351         Reviewed by Carlos Garcia Campos.
3352
3353         * Scripts/run-gtk-tests:
3354         (TestRunner.__init__): Use the new calling conventions for the common script.
3355         (TestRunner._setup_testing_environment): Ditto.
3356         * gtk/common.py:
3357         (set_build_types): Added set_build_types, to avoid having build_type arguments
3358         for all functions in common.
3359         (binary_build_path): Added this function which gets the path to the built binaries.
3360         (get_build_path): Removed the build_types argument.
3361         (build_path): Removed the build_types argument and call get_build_path directly now.
3362
3363 2014-01-02  Alexey Proskuryakov  <ap@apple.com>
3364
3365         https://bugs.webkit.org/show_bug.cgi?id=126391
3366         Accessing Trac from build.webkit.org/dashboard should enable XMLHttpRequest.withCredentials
3367
3368         Rubber-stamped by Dan Bernstein.
3369
3370         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
3371         (loadXML): Quick and dirty fix, with a FIXME.
3372
3373 2014-01-01  Martin Robinson  <mrobinson@igalia.com>
3374
3375         [GTK] Rename libtestnetscapeplugin to libTestNetscapePlugin
3376         https://bugs.webkit.org/show_bug.cgi?id=126349
3377
3378         Reviewed by Carlos Garcia Campos.
3379
3380         All CMake ports use "libTestNetscapePlugin," so choosing the same
3381         name in the autotools port will make the transition easier.
3382
3383         * GNUmakefile.am: Rename the plugin library.
3384
3385 2014-01-01  ChangSeok Oh  <changseok.oh@collabora.com>
3386
3387         [GTK][WK2] Back items are shown in reverse order in MiniBrowser
3388         https://bugs.webkit.org/show_bug.cgi?id=126354
3389
3390         Reviewed by Carlos Garcia Campos.
3391
3392         The latest visited site for backward history should be placed on the top of a history stack
3393         as a common behavior. However currently its order is reverse.
3394
3395         * MiniBrowser/gtk/BrowserWindow.c:
3396         (browserWindowUpdateNavigationActions):
3397
3398 2013-12-30  Martin Robinson  <mrobinson@igalia.com>
3399
3400         [GTK] Make the output directory of GObject unit tests binaries consistent with the CMake build
3401         https://bugs.webkit.org/show_bug.cgi?id=126297
3402
3403         Reviewed by Philippe Normand.
3404
3405         * Scripts/run-gtk-tests: Looks for the tests in the new directories.
3406         (TestRunner): Ditto.
3407         (TestRunner._run_test): Ditto.
3408
3409 2013-12-30  Alexey Proskuryakov  <ap@apple.com>
3410
3411         full_results.json should distinguish unexpected failures from expected ones
3412         https://bugs.webkit.org/show_bug.cgi?id=126300
3413
3414         Reviewed by Timothy Hatcher.
3415
3416         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3417         (summarize_results): Add "report" element to JSON, which tells the consumer how
3418         this result was counted for summary.
3419
3420         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3421         Updated results to include the new element.
3422
3423         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
3424         (print_unexpected_results): Added a comment pointing to another place that
3425         summarizes results, and should stay in sync.
3426
3427 2013-12-30  Ryuan Choi  <ryuan.choi@samsung.com>
3428
3429         Replace remaning CoreIPC namespace to IPC
3430         https://bugs.webkit.org/show_bug.cgi?id=126305
3431
3432         Reviewed by Anders Carlsson.
3433
3434         * TestWebKitAPI/CMakeLists.txt: Replaced CoreIPC includes to IPC.
3435         * TestWebKitAPI/efl/PlatformWebView.cpp: Removed temporal define for IPC.
3436         * WebKitTestRunner/CMakeLists.txt: Replaced CoreIPC includes to IPC.
3437         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp: Removed temporal define for IPC.
3438
3439 2013-12-30  Brendan Long  <self@brendanlong.com>
3440
3441         Add myself to the committers list.
3442
3443         Unreviewed.
3444
3445         * Scripts/webkitpy/common/config/contributors.json:
3446
3447 2013-12-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3448
3449         [GTK] Split WebKit2APITests/TestWebKitWebView
3450         https://bugs.webkit.org/show_bug.cgi?id=126284
3451
3452         Reviewed by Philippe Normand.
3453
3454         Skip only WebKitWebView/mouse-target and all TestAuthentication
3455         tests that are timing out when running under xvfb.
3456
3457         * Scripts/run-gtk-tests:
3458         (TestRunner):
3459
3460 2013-12-29  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3461
3462         [EFL][WK2] Disable geolocation API test
3463         https://bugs.webkit.org/show_bug.cgi?id=125851
3464
3465         Reviewed by Gyuyoung Kim.
3466
3467         Geolocation is turned off by default in EFL port, so it shouldn't be tested.
3468
3469         * TestWebKitAPI/PlatformEfl.cmake: Move Geolocation to test_webkit2_api_fail_BINARIES.
3470
3471 2013-12-29  Ryuan Choi  <ryuan.choi@samsung.com>
3472
3473         [EFL] Remove ewk_view_tiled
3474         https://bugs.webkit.org/show_bug.cgi?id=125961
3475
3476         Reviewed by Gyuyoung Kim.
3477
3478         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3479         (shouldUseTiledBackingStore):
3480         Moved from DumpRenderTreeChrome to enable WebCore's TiledBackingStore
3481         instead of switching ewk_view_tiled.
3482         (DumpRenderTreeChrome::createView):
3483         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
3484         (drtViewAdd):
3485         * EWebLauncher/main.c: Removed ewk_view_tiled option.
3486         (windowCreate):
3487         (parseUserArguments):
3488
3489 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3490
3491         Pending revision popover is slightly misplaced at build.webkit.org/dashboard
3492         https://bugs.webkit.org/show_bug.cgi?id=126278
3493
3494         Reviewed by Timothy Hatcher.
3495
3496         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3497         (BuildbotQueueView.prototype._appendPendingRevisionCount): Create a span for the text,
3498         as StatusLineView message element has extra padding, and doesn't fit the text snugly.
3499         (BuildbotQueueView.prototype._revisionPopoverContentForIteration): Added bug number to a FIXME.
3500
3501         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/StatusLineView.js:
3502         (StatusLineView.prototype.set messageElement): Removed the getter, as we no longer need it.
3503
3504         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
3505         Removed display:inline-block hack for messageElement div, as we no longer use it for measuring text bounds.
3506
3507 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3508
3509         Interrupted test runs should not count at build.webkit.org/dashboard
3510         https://bugs.webkit.org/show_bug.cgi?id=126279
3511
3512         Reviewed by Timothy Hatcher.
3513
3514         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3515         (BuildbotIteration.prototype.get productive):
3516         (BuildbotIteration.prototype.get previousProductiveIteration): Replaced previous with
3517         this accessor to skips iterations that don't have relevant data. We still want to
3518         display them, but revision ranges should not be affected.
3519         (BuildbotIteration.prototype.update): Record whether the iteration was up for retry.
3520
3521         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3522         Use latest productive iteration instead of latest iteration for pending revision
3523         count and popovers.
3524
3525 2013-12-29  Alexey Proskuryakov  <ap@apple.com>
3526
3527         Please display (and link to) revision ranges at build.webkit.org/dashboard
3528         https://bugs.webkit.org/show_bug.cgi?id=122187
3529
3530         Reviewed by Timothy Hatcher.
3531
3532         Added popovers for revision numbers. Removed direct links, because they were misleading -
3533         a test run covers a revision range, not just the latest revision. This also makes
3534         selecting a revision for copy easier.
3535
3536         All revision numbers have the popovers for consistency, although they are most useful
3537         for iterations that are not the last ones in a view, because the content is a delta
3538         from previous iteration.
3539
3540         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
3541         (BuildbotBuilderQueueView.prototype.update.appendBuilderQueueStatus):
3542         revisionLinksForIteration() is now named revisionContentForIteration().
3543
3544         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3545         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
3546         Ditto.
3547
3548         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3549         (BuildbotIteration.prototype.get previous): Added a function to go back in iteration history.
3550
3551         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3552         Refactored to support the new popover variation. Replaced revisionLinksForIteration()
3553         with a function that builds an element with popover.
3554
3555         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:
3556         Changed to take a function for popover presentation instead of delegate object.
3557         We only need one delegate function, and it's easier to have multiple popovers per view class
3558         this way.
3559
3560         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3561         Removed a rule for selectable class. It's replaced with a semantic rule in StatusLineView.css.
3562
3563         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
3564         Renamed pending-commits-popover class to commit-history-popover.
3565