7653a1ae4adf93c0b94a5b00a8b0970eb7692069
[WebKit-https.git] / Tools / ChangeLog
1 2012-04-03  Martin Robinson  <mrobinson@igalia.com>
2
3         [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
4         https://bugs.webkit.org/show_bug.cgi?id=82473
5
6         Reviewed by Philippe Normand.
7
8         Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
9         was ever run.
10
11         * gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
12         check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
13
14 2012-04-03  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
15
16         [EFL] DRT support for setInteractiveFormValidationEnabled
17         https://bugs.webkit.org/show_bug.cgi?id=82050
18
19         Enable interactive form validation and unskip tests from the
20         skip list.
21
22         Reviewed by Antonio Gomes.
23
24         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
25         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
26
27 2012-04-03  Philippe Normand  <pnormand@igalia.com>
28
29         Unreviewed, another test-webkitpy fix-up after r113037.
30
31         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
32         crash dump depending on current environment.
33
34 2012-04-03  Philippe Normand  <pnormand@igalia.com>
35
36         Unreviewed, test-webkitpy build fix after r113037.
37
38         * Scripts/webkitpy/layout_tests/port/gtk.py:
39         (GtkPort._get_crash_log):
40
41 2012-04-03  Philippe Normand  <pnormand@igalia.com>
42
43         [GTK] crash log reports support
44         https://bugs.webkit.org/show_bug.cgi?id=81659
45
46         Reviewed by Martin Robinson.
47
48         Removed the daemontools crashmon/xvfb scripts and implemented the crash
49         log reporting in the NRWT Gtk port. To get proper crash logs one
50         needs to set the core pattern like this:
51         echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
52         Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
53         environment variable.
54
55         * BuildSlaveSupport/gtk/README:
56         * BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
57         * BuildSlaveSupport/gtk/crashmon/log/run: Removed.
58         * BuildSlaveSupport/gtk/crashmon/run: Removed.
59         * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
60         * BuildSlaveSupport/gtk/xvfb/log/run: Removed.
61         * BuildSlaveSupport/gtk/xvfb/run: Removed.
62         * Scripts/new-run-webkit-tests:
63         * Scripts/webkitpy/layout_tests/port/gtk.py:
64         (GtkDriver.stop):
65         (GtkPort.show_results_html_file):
66         (GtkPort):
67         (GtkPort._get_gdb_output):
68         (GtkPort._get_crash_log):
69         (GtkPort._get_crash_log.match_filename):
70         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
71         (GtkPortTest):
72         (test_show_results_html_file):
73         (assertLinesEqual):
74         (_mock_gdb_output):
75         (test_get_crash_log):
76
77 2012-04-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
78
79         Enable and connect the WebInspectorServer with WebKit2 pages.
80         https://bugs.webkit.org/show_bug.cgi?id=73094
81
82         Reviewed by Simon Hausmann.
83
84         Enable developer extras on pages in MiniBrowser for Qt.
85
86         * MiniBrowser/qt/qml/BrowserWindow.qml:
87
88 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
89
90         [EFL] LayoutTestController needs implementation of setDefersLoading
91         https://bugs.webkit.org/show_bug.cgi?id=82890
92
93         Reviewed by Philippe Normand.
94
95         Implement setDefersLoading() in EFL's LayoutTestController so that the
96         corresponding test case can be removed from the skip list.
97
98         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
99         (LayoutTestController::setDefersLoading):
100
101 2012-04-03  Christophe Dumez  <christophe.dumez@intel.com>
102
103         [EFL] LayoutTestController needs implementation of goBack
104         https://bugs.webkit.org/show_bug.cgi?id=81914
105
106         Reviewed by Philippe Normand.
107
108         Implement goBack() in EFL's LayoutTestController by calling
109         ewk_frame_back().
110
111         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
112         (LayoutTestController::goBack):
113
114 2012-04-03  Alexander Shalamov  <alexander.shalamov@intel.com>
115
116         [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
117         https://bugs.webkit.org/show_bug.cgi?id=82589
118
119         Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
120         in order to unskip printing/page-format-data.html
121
122         Reviewed by Philippe Normand.
123
124         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
125         (LayoutTestController::pageSizeAndMarginsInPixels):
126
127 2012-04-03  Simon Pena  <spena@igalia.com>
128
129         [GTK] DRT missing didRunInsecureContent notification
130         https://bugs.webkit.org/show_bug.cgi?id=59367
131
132         Reviewed by Philippe Normand.
133
134         Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
135         the main WebFrame or any other WebFrame created later. Added
136         "didRunInsecureContent" notification in the callback in order to
137         get the LayoutTests passing.
138
139         * DumpRenderTree/gtk/DumpRenderTree.cpp: Connect
140         to WebFrame's "insecure-content-run" signal and add
141         didRunInsecureContent notification in the callback to get the
142         LayoutTests passing.
143         (didRunInsecureContent):
144         (createWebView):
145
146 2012-04-03  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
147
148         rebaseline-server: Make it possible to not launch a browser with the server.
149         https://bugs.webkit.org/show_bug.cgi?id=82999
150
151         Reviewed by Adam Barth.
152
153         Add the `--no-show-results' option, which lets one decide not to
154         launch a web browser when running the rebaseline server.  This is
155         especially useful if the default browser is not the wanted one, or
156         if the rebaseline server page is already open.
157
158         * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
159         (AbstractLocalServerCommand.__init__):
160         (AbstractLocalServerCommand.execute):
161
162 2012-04-02  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
163
164         EFL's LayoutTestController disableImageLoading implementation.
165         https://bugs.webkit.org/show_bug.cgi?id=82848
166
167         Reviewed by Hajime Morita.
168
169         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
170         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
171         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
172         (LayoutTestController::disableImageLoading):
173
174 2012-04-02  Alexander Shalamov  <alexander.shalamov@intel.com>
175
176         [EFL] LayoutTestController needs implementation of isPageBoxVisible
177         https://bugs.webkit.org/show_bug.cgi?id=82591
178
179         Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
180         in order to unskip printing/page-format-data.html
181
182         Reviewed by Hajime Morita.
183
184         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
185         (LayoutTestController::isPageBoxVisible):
186
187 2012-04-02  Simon Fraser  <simon.fraser@apple.com>
188
189         run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
190         https://bugs.webkit.org/show_bug.cgi?id=82962
191
192         Reviewed by Dirk Pranke.
193
194         Ensure that _build_path() returns an absolute path.
195
196         Eric Seidel also had to deploy MockConfig in a bunch of places
197         in order to correct previous testing errors where we were
198         pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
199         was a real path.  The real Config object calls run_command("webkit-build-directory")
200         to read the WebKit build directory from the webkitdirs.pm perl code.
201         MockConfig abstracts this away and always returns "/mock-build" during
202         testing.  This change is much larger than one would think necessary
203         because of needing to deploy this MockConfig class.
204
205         * Scripts/webkitpy/layout_tests/port/webkit.py:
206         (WebKitPort._build_path):
207
208 2012-04-02  Ojan Vafai  <ojan@chromium.org>
209
210         Fix snafu in r112971. We were never calling parseParameter for builder.
211
212         * TestResultServer/static-dashboards/dashboard_base.js:
213
214 2012-04-02  Ojan Vafai  <ojan@chromium.org>
215
216         Generate the lists of all layout test builders from the buildbot json
217         https://bugs.webkit.org/show_bug.cgi?id=82924
218
219         Reviewed by Mihai Parparita.
220
221         In order to make this work, cleaned up a lot of existing technical debt.
222         -Got rid of expectations builder. This concept is outdated and just dead code.
223         -Split hash parameter parsing into two functions. One for dashboard_base
224         (crossDashboardParameters) and one for the specific dashboard html file
225         (dashboardSpecificParameters). In the old world, parseParameters needed to
226         be called twice and depended on it's own output the first time through.
227         Now we only need to parse crossDashboardParameters first and crossDashboardParameters
228         doesn't depend on the output of crossDashboardParameters.
229         -Lots of variable/method renames due to the above.
230         -g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
231         for that dashboard.
232
233         * TestResultServer/static-dashboards/aggregate_results.html:
234         * TestResultServer/static-dashboards/builders.js:
235         (BuilderGroup):
236         (BuilderGroup.prototype.setup):
237         (jsonRequest.xhr.onload):
238         (jsonRequest.xhr.onerror):
239         (isWebkitTestRunner):
240         (isChromiumWebkitTipOfTreeTestRunner):
241         (isChromiumWebkitDepsTestRunner):
242         (generateBuildersFromBuilderList):
243         (onLayoutTestBuilderListLoad):
244         (onErrorLoadingBuilderList):
245         (loadBuildersList):
246         * TestResultServer/static-dashboards/dashboard_base.js:
247         (handleValidHashParameterWrapper):
248         (queryHashAsMap):
249         (parseParameter):
250         (parseCrossDashboardParameters):
251         (parseDashboardSpecificParameters):
252         (parseParameters):
253         (diffStates):
254         (defaultValue):
255         (isLayoutTestResults):
256         (isGPUTestResults):
257         (currentBuilderGroupCategory):
258         (currentBuilderGroup):
259         (initBuilders):
260         Now that we've split parameter parseing, these methods no longer need
261         to take an optional state. They can always just use the global cross-dashboard state.
262
263         (pathToBuilderResultsFile):
264         (appendJSONScriptElementFor):
265         (appendJSONScriptElements):
266         (handleResourceLoadError):
267         (haveJsonFilesLoaded):
268         (combinedDashboardState):
269         (setQueryParameter):
270         (permaLinkURLHash):
271         (toggleQueryParameter):
272         (queryParameterValue):
273         (selectHTML):
274         (htmlForTestTypeSwitcher):
275         (g_handleBuildersListLoaded):
276         * TestResultServer/static-dashboards/flakiness_dashboard.html:
277         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
278         (testPlatformAndBuildType):
279         (testSubstringList):
280         (testHtmlForTestTypeSwitcherGroup):
281         (testLookupVirtualTestSuite):
282         (testBaseTest):
283         (generateBuildersFromBuilderListHelper):
284         (testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
285         (testGenerateChromiumWebkitDepsBuildersFromBuilderList):
286         (assertObjectsDeepEqual):
287         (testQueryHashAsMap):
288         (testDiffStates):
289         * TestResultServer/static-dashboards/timeline_explorer.html:
290         * TestResultServer/static-dashboards/treemap.html:
291
292 2012-04-02  Tony Chang  <tony@chromium.org>
293
294         check-webkit-style errors when removing .png files
295         https://bugs.webkit.org/show_bug.cgi?id=82933
296
297         Reviewed by David Levin.
298
299         * Scripts/webkitpy/style/patchreader.py:
300         (PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).
301         * Scripts/webkitpy/style/patchreader_unittest.py:
302         (test_check_patch_with_png_deletion):
303
304 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
305
306         Unreviewed, rolling out r112948.
307         http://trac.webkit.org/changeset/112948
308         https://bugs.webkit.org/show_bug.cgi?id=82961
309
310         Someone else already checked in a similar change (Requested by
311         sundiamonde on #webkit).
312
313         * Scripts/webkitpy/layout_tests/port/webkit.py:
314         (WebKitDriver._start):
315
316 2012-04-02  Adam Barth  <abarth@webkit.org>
317
318         garden-o-matic isn't able to rebaseline audio failures
319         https://bugs.webkit.org/show_bug.cgi?id=82957
320
321         Reviewed by Chris Rogers.
322
323         This patch just adds "wav" to the list of test suffixes and updates the
324         unit tests to show that we're rebaselining audio tests results now too.
325
326         * Scripts/webkitpy/tool/commands/rebaseline.py:
327         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
328         (test_rebaseline_updates_expectations_file):
329
330 2012-04-02  Adam Barth  <abarth@webkit.org>
331
332         garden-o-matic should let you listen to audio failures
333         https://bugs.webkit.org/show_bug.cgi?id=82953
334
335         Reviewed by Chris Rogers.
336
337         Now that we've actually got an audio failure on the bots, we can clean
338         up the last stray bugs.  This patch doesn't have any tests because I'm
339         lame.
340
341         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
342         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
343         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
344         (.):
345
346 2012-04-02  Stephanie Lewis  <slewis@apple.com>
347
348         run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
349         https://bugs.webkit.org/show_bug.cgi?id=82552
350
351         Reviewed by Dirk Pranke.
352
353         Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
354
355         * Scripts/webkitpy/layout_tests/port/webkit.py:
356         (WebKitDriver._start):
357
358 2012-04-02  Dirk Pranke  <dpranke@chromium.org>
359
360         NRWT is not printing out the builder it's uploading JSON files for
361         https://bugs.webkit.org/show_bug.cgi?id=82834
362
363         Reviewed by Ojan Vafai.
364
365         Handle log messages of the form log.info("%s", arg) properly ...
366         I didn't even know you could do that :).
367
368         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
369         (_LogHandler.emit):
370         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
371         (RegularTest.test_log_args):
372         (VerboseTest.test_log_args):
373
374 2012-04-02  Tim Horton  <timothy_horton@apple.com>
375
376         [mac] LayoutTestHelper crashes if there is no main display
377         https://bugs.webkit.org/show_bug.cgi?id=82944
378         <rdar://problem/11162954>
379
380         Reviewed by Simon Fraser.
381
382         If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
383         a null dictionary, so we shouldn't go ahead and try to read from it.
384
385         * DumpRenderTree/mac/LayoutTestHelper.m:
386         (installLayoutTestColorProfile):
387
388 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
389
390         [Qt][WK2] Set up plugin process on Unix
391         https://bugs.webkit.org/show_bug.cgi?id=72121
392
393         Reviewed by Simon Hausmann.
394
395         * qmake/mkspecs/features/features.prf: Reenable plugins
396         and turn on plugin process.
397
398 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
399
400         Unreviewed, rolling out r112868, r112879, and r112881.
401         http://trac.webkit.org/changeset/112868
402         http://trac.webkit.org/changeset/112879
403         http://trac.webkit.org/changeset/112881
404         https://bugs.webkit.org/show_bug.cgi?id=82901
405
406         "Build fail on bots." (Requested by kbalazs on #webkit).
407
408         * MiniBrowser/gtk/GNUmakefile.am:
409         * qmake/mkspecs/features/features.prf:
410
411 2012-04-02  Philippe Normand  <pnormand@igalia.com>
412
413         [GTK] Enable shadow-dom in build-webkit.
414
415         Rubber-stamped by Gustavo Noronha Silva.
416
417         * Scripts/build-webkit: Enable shadow-dom build, this is need to
418         have a working build currently.
419
420 2012-04-02  Andreas Kling  <kling@webkit.org>
421
422         Adding Zalan Bujtas to committers list.
423
424         * Scripts/webkitpy/common/config/committers.py:
425
426 2012-04-02  Balazs Kelemen  <kbalazs@webkit.org>
427
428         [Qt][WK2] Set up plugin process on Unix
429         https://bugs.webkit.org/show_bug.cgi?id=72121
430
431         Reviewed by Simon Hausmann.
432
433         * qmake/mkspecs/features/features.prf: Reenable plugins
434         and turn on plugin process.
435
436 2012-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
437
438         Unreviewed, rolling out r112651.
439         http://trac.webkit.org/changeset/112651
440         https://bugs.webkit.org/show_bug.cgi?id=82887
441
442         It doesn't work with older Qt5 (Requested by Ossy on #webkit).
443
444         * MiniBrowser/qt/BrowserWindow.cpp:
445         (BrowserWindow::updateVisualMockTouchPoints):
446         * MiniBrowser/qt/main.cpp:
447         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
448         (WTR::WrapperWindow::handleStatusChanged):
449         * qmake/mkspecs/features/unix/default_post.prf:
450
451 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
452
453         [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
454         https://bugs.webkit.org/show_bug.cgi?id=82877
455
456         Reviewed by Philippe Normand.
457
458         * Scripts/run-gtk-tests:
459         (TestRunner.run_tests): Use replace instead of lstrip to remove
460         the programs_path from the full path of unit tests.
461
462 2012-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
463
464         Unreviewed. Skip flaky unit tests.
465
466         * Scripts/run-gtk-tests:
467         (TestRunner):
468
469 2012-04-02  Ryosuke Niwa  <rniwa@webkit.org>
470
471         webkitpy rebaseline.
472
473         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
474         (test_run_test_set_with_json_output):
475         (test_run_test_set_with_json_source):
476
477 2012-04-01  Ryosuke Niwa  <rniwa@webkit.org>
478
479         perf-o-matic should store test results' units
480         https://bugs.webkit.org/show_bug.cgi?id=82852
481
482         Reviewed by Kentaro Hara.
483
484         Include units in the results JSON.
485
486         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
487         (PerfTestsRunner._process_chromium_style_test_result):
488         (PerfTestsRunner._process_parser_test_result):
489
490 2012-04-01  Tony Tseung  <tseung@apple.com>
491
492         Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
493         composite fonts from existing physical fonts.
494         <rdar://problem/10717370>
495         https://bugs.webkit.org/show_bug.cgi?id=82810
496             
497         A new test font of this kind as been added to the test tools for running the webkit-tests
498
499         Reviewed by Dan Bernstein.
500
501         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
502         Added new dependency SampleFont.sfont
503         
504         * DumpRenderTree/fonts/SampleFont.sfont: Added.
505         
506         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
507         * DumpRenderTree/mac/DumpRenderTree.mm:
508         (allowedFontFamilySet):
509         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
510         
511         (activateTestingFonts):
512         Added the registration of the Composite Font Referene sample font
513         
514         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
515         (WTR::allowedFontFamilySet):
516         Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
517
518         (WTR::activateFonts):
519         Added the registration of the Composite Font Referene sample font
520
521         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
522         Added new dependency SampleFont.sfont
523
524         * WebKitTestRunner/fonts/SampleFont.sfont: Added.
525
526 2012-04-01  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
527
528         Support the Network Information API
529         https://bugs.webkit.org/show_bug.cgi?id=73528
530
531         Reviewed by Adam Barth.
532
533         Add network information API feature to build script.
534
535         * Scripts/build-webkit:
536
537 2012-03-31  Ojan Vafai  <ojan@chromium.org>
538
539         Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
540         https://bugs.webkit.org/show_bug.cgi?id=82839
541
542         Reviewed by Adam Barth.
543
544         Also, update various hard-coded lists for WIN7 and Lion ports.
545         This is necessary since the new list of builders grabbed off the
546         buildbot includes Lion.
547
548         * TestResultServer/static-dashboards/builders.js:
549         (generateWebkitBuildersFromBuilderList):
550         (xhr.onreadystatechange):
551         Don't use dashboard_base's request method to avoid layering violation.
552
553         * TestResultServer/static-dashboards/dashboard_base.js:
554         (parseParameters):
555         (initBuilders):
556         (haveJsonFilesLoaded):
557         (g_handleBuildersListLoaded):
558         Block loading the JSON files for each builder until we actually have a list of builders.
559
560         * TestResultServer/static-dashboards/flakiness_dashboard.html:
561         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
562         (testPlatformAndBuildType):
563         (testGenerateWebkitBuildersFromBuilderList):
564         * TestResultServer/static-dashboards/timeline_explorer.html:
565         * TestResultServer/static-dashboards/treemap.html:
566         Delay generating the page until the builder list has loaded.
567
568 2012-03-31  Ojan Vafai  <ojan@chromium.org>
569
570         If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
571         https://bugs.webkit.org/show_bug.cgi?id=82799
572
573         Reviewed by Eric Seidel.
574
575         If we don't run a test, mark it as skipped.
576
577         * Scripts/webkitpy/layout_tests/controllers/manager.py:
578         (Manager._mark_interrupted_tests_as_skipped):
579         (Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
580         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
581         (ManagerTest.test_interrupt_if_at_failure_limits):
582
583 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
584
585         One more build fix after r112781 for Chromium Windows.
586         Don't copy zip .idb files.
587
588         * BuildSlaveSupport/built-product-archive:
589         (copyBuildFiles):
590
591 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
592
593         Yet another build fix after r112781 for Chromium Windows.
594         Run webkit-build-directory by perl explicitly.
595
596         * BuildSlaveSupport/built-product-archive:
597         (determineWebKitBuildDirectory):
598
599 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
600
601         Fix the syntax error in master.cfg after r112734.
602
603         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
604         (unitTestsSupported):
605
606 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
607
608         Another build fix after r112781.
609
610         * BuildSlaveSupport/built-product-archive:
611         (createZip):
612
613 2012-03-31  Ryosuke Niwa  <rniwa@webkit.org>
614
615         Build fix after r112781.
616
617         * BuildSlaveSupport/built-product-archive:
618         (createZipManually):
619         (createZip):
620
621 2012-03-30  Ryosuke Niwa  <rniwa@webkit.org>
622
623         Chromium bots should upload archived built files
624         https://bugs.webkit.org/show_bug.cgi?id=82666
625
626         Reviewed by Tony Chang.
627
628         * BuildSlaveSupport/build.webkit.org-config/config.json:
629         * BuildSlaveSupport/built-product-archive:
630         (main):
631         (determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
632         call out to webkit-build-directory.
633         (removeDirectoryIfExists): Extracted.
634         (copyBuildFiles): Added to avoid archiving useless intermedinate files.
635         (createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
636         (createZipManually.addToArchive):
637         (createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
638         (archiveBuiltProduct): Add support for Chromium port.
639         * Scripts/webkit-build-directory: Add support for --platform options.
640
641 2012-03-30  Dan Bernstein  <mitz@apple.com>
642
643         Reverted r112767, because it caused many vertical text tests to fail.
644
645         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
646         * DumpRenderTree/fonts/SampleFont.sfont: Removed.
647         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
648         * DumpRenderTree/mac/DumpRenderTree.mm:
649         (allowedFontFamilySet):
650         (activateTestingFonts):
651         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
652         (WTR::allowedFontFamilySet):
653         (WTR::activateFonts):
654         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
655         * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
656
657 2012-03-30  Malcolm MacLeod  <malcolm.macleod@tshwanedje.com>
658
659         [wx] Move wxWebKit API into WebKit namespace.
660         https://bugs.webkit.org/show_bug.cgi?id=82740
661
662         Reviewed by Kevin Ollivier.
663
664         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
665         (LayoutWebViewEventHandler::LayoutWebViewEventHandler):
666         (LayoutWebViewEventHandler::bindEvents):
667         (LayoutWebViewEventHandler::OnLoadEvent):
668         (LayoutWebViewEventHandler::OnAlertEvent):
669         (LayoutWebViewEventHandler::OnConfirmEvent):
670         (LayoutWebViewEventHandler::OnPromptEvent):
671         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
672         (LayoutWebViewEventHandler::OnReceivedTitleEvent):
673         (LayoutWebViewEventHandler::OnWindowObjectClearedEvent):
674         (LayoutWebViewEventHandler):
675         (dumpFramesAsText):
676         (dump):
677         (MyApp::OnInit):
678         * wx/browser/browser.cpp:
679         (MyApp::OnInit):
680
681 2012-03-30  Eli Fidler  <efidler@rim.com>
682
683         Enable OpenType Sanitizer for BlackBerry port.
684         https://bugs.webkit.org/show_bug.cgi?id=82782
685
686         Reviewed by Eric Seidel.
687
688         * Scripts/webkitdirs.pm:
689         (blackberryCMakeArguments): add OTS to include path
690
691 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
692
693         run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
694         as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
695         is found.
696
697         <rdar://problem/11158581>
698         
699         Reviewed by Mark Rowe.
700
701         * Scripts/webkitpy/layout_tests/port/webkit.py:
702         (WebKitDriver._start):
703
704 2012-03-30  Simon Fraser  <simon.fraser@apple.com>
705
706         Disable run-api-tests on release mac builds
707         https://bugs.webkit.org/show_bug.cgi?id=82788
708
709         Reviewed by Ryosuke Niwa.
710         
711         TestWebKitAPI crashes every time in release builds currently
712         (https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
713         run-api-tests on mac release builders.
714
715         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
716         (unitTestsSupported):
717
718 2012-03-30  Chang Shu  <cshu@webkit.org>
719
720         Unreviewed. Update my email.
721
722         * Scripts/webkitpy/common/config/committers.py:
723
724 2012-03-30  Chris Fleizach  <cfleizach@apple.com>
725
726         AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
727         https://bugs.webkit.org/show_bug.cgi?id=82745
728
729         Reviewed by Simon Fraser.
730
731         * DumpRenderTree/AccessibilityUIElement.cpp:
732         (rangeForPositionCallback):
733         (AccessibilityUIElement::rangeForPosition):
734         (AccessibilityUIElement::getJSClass):
735         * DumpRenderTree/AccessibilityUIElement.h:
736         (AccessibilityUIElement):
737         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
738         (AccessibilityUIElement::rangeForPosition):
739         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
740         (WTR::AccessibilityUIElement::rangeForPosition):
741         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
742         (AccessibilityUIElement):
743         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
744         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
745         (WTR::AccessibilityUIElement::rangeForPosition):
746         (WTR):
747
748 2012-03-30  David Barr  <davidbarr@chromium.org>
749
750         Split up top-level .gitignore and .gitattributes
751         https://bugs.webkit.org/show_bug.cgi?id=82687
752
753         Reviewed by Tor Arne Vestbø.
754
755         * .gitattributes: Added.
756         * .gitignore: Added.
757         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
758         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.
759
760 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
761
762         Actually remove the ChromiumOS GTK builder, like r112673 said it would.
763
764         * TestResultServer/static-dashboards/builders.js:
765
766 2012-03-30  Mihai Parparita  <mihaip@chromium.org>
767
768         Update ChromiumOS bot names in builders.js to reflect changes made by
769         http://crrev.com/129835
770         
771         Also removes the ChromiumOS GTK builder, which was removed by
772         http://crrev.com/129835
773
774         * TestResultServer/static-dashboards/builders.js:
775
776 2012-03-30  Vineet Chaudhary  <rgf748@motorola.com>
777
778         [GTK] Disable introspection build in the at-spi2-core module.
779         https://bugs.webkit.org/show_bug.cgi?id=82729
780
781         Reviewed by Philippe Normand.
782
783         This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
784
785         * gtk/jhbuild.modules: Disable introspection.
786
787 2012-03-30  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
788
789         Add a "preview" state to Page Visibility API implementation
790         https://bugs.webkit.org/show_bug.cgi?id=81355
791
792         Reviewed by Adam Barth.
793
794         Updating the Page Visibility API implementation to the current spec version.
795
796         * DumpRenderTree/chromium/LayoutTestController.cpp:
797         (LayoutTestController::setPageVisibility):
798
799 2012-03-30  Keishi Hattori  <keishi@webkit.org>
800
801         Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
802         https://bugs.webkit.org/show_bug.cgi?id=80972
803
804         Reviewed by Kent Tamura.
805
806         * Scripts/build-webkit:
807         * qmake/mkspecs/features/features.prf:
808
809 2012-03-29  Ádám Kallai  <kadam@inf.u-szeged.hu>
810
811         [Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
812         https://bugs.webkit.org/show_bug.cgi?id=82195
813
814         Reviewed by Simon Hausmann.
815
816         * MiniBrowser/qt/BrowserWindow.cpp:
817         (BrowserWindow::updateVisualMockTouchPoints):
818         * MiniBrowser/qt/main.cpp:
819         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
820         (WTR::WrapperWindow::handleStatusChanged):
821         * qmake/mkspecs/features/unix/default_post.prf:
822
823 2012-03-30  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
824
825         [EFL] Implement LayoutTestController::setMinimumTimerInterval
826         https://bugs.webkit.org/show_bug.cgi?id=81220
827
828         Add missing implementation setMinimumTimerInterval to EFL's
829         LayoutTestController so that we can unskip related tests from the skip list.
830
831         Reviewed by Philippe Normand.
832
833         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
834         (LayoutTestController::setMinimumTimerInterval):
835
836 2012-03-29  Dan Bernstein  <mitz@apple.com>
837
838         Removed “Intel” from the Lion builders’ names.
839
840         Rubber-stamped by Mark Rowe.
841
842         * BuildSlaveSupport/build.webkit.org-config/config.json:
843         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
844         (LeaksViewer._displayURLPrompt):
845
846 2012-03-29  Mihai Parparita  <mihaip@chromium.org>
847
848         [Chromium] Add sharded ChromiumOS debug bots to builders.js
849         https://bugs.webkit.org/show_bug.cgi?id=82639
850
851         Reviewed by Eric Seidel.
852
853         The bots were sharded by http://crrev.com/129613, update builders.js
854         to reflect this.
855
856         * TestResultServer/static-dashboards/builders.js:
857
858 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
859
860         remove support for junit-style xml output from test-webkitpy
861         https://bugs.webkit.org/show_bug.cgi?id=82279
862
863         Reviewed by Eric Seidel.
864
865         This was added when we were looking into integrating w/ Jenkins
866         rather than buildbot, but I believe that project got shelved, so
867         this is unused. We can always add it back in later as necessary.
868
869         * Scripts/webkitpy/test/main.py:
870         (Tester._parse_args):
871         (Tester._run_tests):
872         * Scritps/webkitpy/thirdparty/__init__.py:
873
874 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
875
876         new-run-webkit-tests: crashes when it fails to decode a stack trace
877         https://bugs.webkit.org/show_bug.cgi?id=82673
878
879         Unreviewed, build fix.
880
881         We are assuming the stdout/stderr output from the driver is utf-8
882         encoded when we get stack traces; this may not be a valid
883         assumption generally, but if we do get strings that aren't valid
884         utf-8, we would crash. Now we will ignore any decoding errors.
885
886         * Scripts/webkitpy/layout_tests/port/base.py:
887         (Port._get_crash_log):
888         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
889         (PortTestCase.test_get_crash_log):
890
891 2012-03-29  Simon Fraser  <simon.fraser@apple.com>
892
893         Scripts fail to detect when a tool crashes
894         https://bugs.webkit.org/show_bug.cgi?id=82659
895
896         Reviewed by Mark Rowe.
897         
898         Have exitStatus() detect when the process fail to exit cleanly
899         (possibly because of a crash), and return a non-zero exit code
900         in that case.
901
902         * Scripts/VCSUtils.pm:
903         (exitStatus):
904
905 2012-03-29  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
906
907         [GTK][EFL] run-javascriptcore-tests should be run through jhbuild
908         https://bugs.webkit.org/show_bug.cgi?id=82581
909
910         Reviewed by Martin Robinson.
911
912         Running Javascriptcore tests through jhbuild
913         for consistency with run-webkit-tests and in order to
914         avoid confusing libraries when facing regressions.
915
916         * Scripts/run-javascriptcore-tests:
917
918 2012-03-29  Dirk Pranke  <dpranke@chromium.org>
919
920         test-webkitpy: add --timing
921         https://bugs.webkit.org/show_bug.cgi?id=82550
922
923         Reviewed by Eric Seidel.
924
925         This patch adds a --timing option that will display the time
926         each test takes. It also removes the --silent option, since
927         probably no one ever used it, and cleans up the logging
928         option parsing code to be easier to follow.
929
930         * Scripts/webkitpy/test/main.py:
931         (Tester._parse_args):
932         (Tester._configure):
933         * Scripts/webkitpy/test/runner.py:
934         (TestRunner.write_result):
935         * Scripts/webkitpy/test/runner_unittest.py:
936         (RunnerTest.test_regular):
937         (RunnerTest.test_verbose):
938         (RunnerTest):
939         (RunnerTest.test_timing):
940
941 2012-03-29  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
942
943         HashMap<>::add should return a more descriptive object
944         https://bugs.webkit.org/show_bug.cgi?id=71063
945
946         Reviewed by Ryosuke Niwa.
947
948         Update code to use AddResult instead of a pair.
949
950         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
951         (LayoutTestController::evaluateScriptInIsolatedWorld):
952         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
953         (LayoutTestController::evaluateScriptInIsolatedWorld):
954         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
955         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld):
956
957 2012-03-29  Ilya Tikhonovsky  <loislo@chromium.org>
958
959         Web Inspector: chromium: DRT --no-timeout option doesn't work.
960         https://bugs.webkit.org/show_bug.cgi?id=82608
961
962         Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
963         This was broken by r112354 and the sequence became opposite.
964
965         Reviewed by Yury Semikhatsky.
966
967         * DumpRenderTree/chromium/TestShell.cpp:
968         (TestShell::TestShell):
969         (TestShell::initialize):
970
971 2012-03-29  Vineet Chaudhary  <rgf748@motorola.com>
972
973         Remove custom bindings form Internals.idl of attribute type Array.
974         https://bugs.webkit.org/show_bug.cgi?id=82319
975
976         Reviewed by Kentaro Hara.
977
978         Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp as no longer required.
979
980         * GNUmakefile.am:
981
982 2012-03-28  Mark Rowe  <mrowe@apple.com>
983
984         Fix --no-saved-state.
985
986         Ignore the flag before Lion, rather than making it specific to Lion.
987
988         Rubber-stamped by Dan Bernstein.
989
990         * Scripts/webkitdirs.pm:
991         (argumentsForRunAndDebugMacWebKitApp):
992
993 2012-03-28  Dave Tharp  <dtharp@codeaurora.org>
994
995         Add dtharp to contributors list
996         https://bugs.webkit.org/show_bug.cgi?id=82545
997
998         Reviewed by Adam Barth.
999
1000         Adding dtharp as Contributor.
1001
1002         * Scripts/webkitpy/common/config/committers.py:
1003
1004 2012-03-28  Stuart Eichert  <stuart.eichert@palm.com>
1005
1006         build-webkit : the word "pass" is spelled incorrectly as "passs"
1007         https://bugs.webkit.org/show_bug.cgi?id=82532
1008
1009         Reviewed by Julien Chaffraix.
1010
1011         Corrected spelling of the word "pass" in build-webkit.
1012
1013         * Scripts/build-webkit:
1014
1015 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
1016
1017         new-run-webkit-tests doesn't log correctly after retrying failures
1018         https://bugs.webkit.org/show_bug.cgi?id=82541
1019
1020         Unreviewed, build fix.
1021
1022         r112189 introduced a regression where we would accidentally
1023         delete the log handler after we retried any failing tests - that
1024         meant that any log messages around uploading the results got
1025         dropped.
1026
1027         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1028         (Manager._run_tests):
1029
1030 2012-03-28  Kevin Ollivier  <kevino@theolliviers.com>
1031
1032         [wx] Unreviewed. Build fix, move WTF back into JSCore target
1033         until issues with JSCore not linking in all WTF symbols are resolved.
1034
1035         * waf/build/settings.py:
1036
1037 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
1038
1039         download-built-product build step should detect 404 errors
1040         https://bugs.webkit.org/show_bug.cgi?id=82491
1041
1042         Reviewed by Ryosuke Niwa.
1043         
1044         Pass --fail to curl so that it reports 404 errors.
1045
1046         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1047         (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
1048         * BuildSlaveSupport/built-product-archive:
1049         (extractBuiltProduct): Remove trailing whitespace.
1050
1051 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
1052
1053         flakiness dashboard should only keep the last 500 runs
1054         https://bugs.webkit.org/show_bug.cgi?id=82530
1055
1056         Reviewed by Ojan Vafai.
1057
1058         If a bot has an overly large amount of failing tests, then
1059         storing 750 runs' worth takes a lot of memory and CPU time to
1060         process and we end up getting killed by AppEngine; this cases
1061         data corruption and confusion down the road when we have to
1062         retry the upload of the data and the tests show up as multiple
1063         runs.
1064
1065         * TestResultServer/model/jsonresults.py:
1066         (JsonResults.update_file):
1067
1068 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1069
1070         extract-built-product build step should fail if unzipping fails
1071         https://bugs.webkit.org/show_bug.cgi?id=82493
1072
1073         Reviewed by Simon Fraser.
1074
1075         Forward non-zero exit code from subprocesses so that the master can detect any failures
1076         and bail out early.
1077
1078         * BuildSlaveSupport/built-product-archive:
1079         (main):
1080
1081 2012-03-28  Dirk Pranke  <dpranke@chromium.org>
1082
1083         test-webkitpy should support files, directories, and packages as command line args
1084         https://bugs.webkit.org/show_bug.cgi?id=76765
1085
1086         Reviewed by Adam Barth.
1087
1088         This patch adds support for specifying files, directories, and
1089         packages to test-webkitpy along with the already existing
1090         support for modules, test classes, and individual test names.
1091
1092         Also, fix a bug in filesystem_mock where we wouldn't normalize a
1093         path containing a reference to the current directory properly,
1094         for example, '/foo/./bar.py'.
1095
1096         * Scripts/webkitpy/common/system/filesystem_mock.py:
1097         (MockFileSystem.normpath):
1098         * Scripts/webkitpy/test/main.py:
1099         (Tester._configure_logging):
1100         (Tester._run_tests):
1101         * Scripts/webkitpy/test/test_finder.py:
1102         (TestDirectoryTree.find_modules):
1103         (TestDirectoryTree.subpath):
1104         (TestFinder.is_dotted_name):
1105         (TestFinder.find_names):
1106         (TestFinder):
1107         (TestFinder._find_names_for_arg):
1108         (TestFinder._find_in_trees):
1109         (TestFinder._default_names):
1110         * Scripts/webkitpy/test/test_finder_unittest.py:
1111         (TestFinderTest.setUp):
1112         (TestFinderTest.tearDown):
1113         (TestFinderTest.check_names):
1114         (TestFinderTest.test_default_names):
1115         (TestFinderTest):
1116         (TestFinderTest.test_paths):
1117
1118 2012-03-28  Simon Fraser  <simon.fraser@apple.com>
1119
1120         Fix inspector tests when running in internal builds.
1121
1122         <rdar://problem/11050694>
1123
1124         Reviewed by Tim Hatcher.
1125
1126         * DumpRenderTree/mac/DumpRenderTree.mm:
1127         (resetDefaultsToConsistentValues):
1128         * WebKitTestRunner/TestController.cpp:
1129         (WTR::TestController::resetStateToConsistentValues):
1130
1131 2012-03-28  David Kilzer  <ddkilzer@apple.com>
1132
1133         Use xcrun to find nm and ranlib on OS X builds
1134         <http://webkit.org/b/82466>
1135
1136         Reviewed by Dan Bernstein.
1137
1138         * Scripts/build-webkit: Use xcrun to find ranlib.
1139         * Scripts/webkitdirs.pm:
1140         (determineNmPath): Added.  Use xcrun to find nm on OS X.
1141         (nmPath): Added.
1142         * Scripts/webkitperl/features.pm:
1143         (libraryContainsSymbol): Use nmPath().
1144
1145 2012-03-28  Ojan Vafai  <ojan@chromium.org>
1146
1147         Add history navigation to garden-o-matic
1148         https://bugs.webkit.org/show_bug.cgi?id=82495
1149
1150         Reviewed by Dimitri Glazkov.
1151
1152         Also, maintain scroll offsets when returning to a tab. This makes addressing
1153         expected failures considerably easier when dealing with below-the-fold tests.
1154
1155         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1156         -Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
1157         switching.
1158         -Modify window.location with the tabName in the hash. Can't use pushState because this is served
1159         from a file URL and Chrome puts each different file URL in it's own origin.
1160
1161         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1162         Remove the href so that clicking on the accordion item does not modify window.location.hash.
1163
1164         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
1165         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1166
1167 2012-03-28  Philippe Normand  <pnormand@igalia.com>
1168
1169         [GTK] generate-gtk-doc doesn't cope with custom build directory
1170         https://bugs.webkit.org/show_bug.cgi?id=82448
1171
1172         Reviewed by Martin Robinson.
1173
1174         Pass the product directory in generate-gtkdoc arguments from
1175         build-webkit.
1176
1177         * Scripts/webkitdirs.pm:
1178         (buildAutotoolsProject):
1179         * gtk/common.py:
1180         (get_build_path):
1181
1182 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1183
1184         [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
1185         https://bugs.webkit.org/show_bug.cgi?id=82341
1186
1187         Reviewed by Martin Robinson.
1188
1189         Add --skipped=skip|ignore|only command line option.
1190
1191         * Scripts/run-gtk-tests:
1192         (TestRunner._test_cases_to_skip): Return the list of test cases
1193         to skip for the given test depending on the skipped action.
1194         (TestRunner._should_run_test): Decide whether to run the test or
1195         not depending on the skipped action.
1196         (TestRunner.run_tests): Only show the list of skipped tests when
1197         skipped action is 'skip'.
1198
1199 2012-03-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1200
1201         [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
1202         https://bugs.webkit.org/show_bug.cgi?id=82333
1203
1204         Reviewed by Martin Robinson.
1205
1206         * Scripts/run-gtk-tests:
1207         (TestRunner.SkippedTest): Add SkippedTest class to store more
1208         information about skipped tests.
1209         (TestRunner._setup_testing_environment): Use SkippedTest to add
1210         TestWebKitAccessibility to the skipped list.
1211         (TestRunner._find_skipped_test): Return the SkippedTest object for
1212         a given test path.
1213         (TestRunner._test_cases_to_skip): Returns the list of test cases
1214         that should be skipped for a given test path.
1215         (TestRunner._should_run_test): Helper funtion to decide whether
1216         the given test path should be run or not. Tests in the skipped
1217         list that don't have a list of failing test cases are not run at
1218         all. Tests in the skipped list that contain a list of test cases
1219         are run with gtester -s to skip the individual test cases.
1220         (TestRunner._run_test): Helper funtion to run a given test.
1221         (TestRunner.run_tests): Build the list of tests to run based on
1222         _should_run_test() and use helper function _run_test() to run
1223         every test.
1224
1225 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
1226
1227         [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
1228         https://bugs.webkit.org/show_bug.cgi?id=52810
1229
1230         Reviewed by Simon Hausmann.
1231
1232         Use SSE2 floating point math on 32 bit instead of the default
1233         387 to make layout test result same on 32 and on 64 bit builds.
1234
1235         * qmake/mkspecs/features/unix/default_post.prf:
1236
1237 2012-03-28  Sergio Villar Senin  <svillar@igalia.com>
1238
1239         [Soup] DNS prefetching spams resolver, shoots self in the foot
1240         https://bugs.webkit.org/show_bug.cgi?id=41630
1241
1242         Reviewed by Martin Robinson.
1243
1244         Bump libsoup and glib dependencies.
1245
1246         * efl/jhbuild.modules:
1247         * gtk/jhbuild.modules:
1248
1249 2012-03-28  Gustavo Noronha Silva  <gns@gnome.org>
1250
1251         [GTK] Disable introspection for jhbuild modules
1252         https://bugs.webkit.org/show_bug.cgi?id=82395
1253
1254         Reviewed by Philippe Normand.
1255
1256         * efl/jhbuild.modules: add --disable-introspection to all modules
1257         that support it
1258         * gtk/jhbuild.modules: ditto.
1259
1260 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
1261
1262         [Qt] Unreviewed, fix API tests after adding full platforms. (r111658)
1263
1264         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1265         (BuildAndTestFactory.__init__):
1266
1267 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
1268
1269         [Qt] Unreviewed typo fix after r112383.
1270
1271         * Scripts/run-qtwebkit-tests:
1272         (Main.check_crash_occurences):
1273
1274 2012-03-28  Ádám Kallai  <kadam@inf.u-szeged.hu>
1275
1276         [Qt] run-qtwebkit-tests should report crashes
1277         https://bugs.webkit.org/show_bug.cgi?id=76905
1278
1279         Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
1280         Made unit test for this modification by János Badics <jbadics@inf.u-szeged.hu>.
1281
1282         Reviewed by Csaba Osztrogonác.
1283
1284         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1285         (RunQtAPITests.commandComplete):
1286         (RunQtAPITests.evaluateCommand):
1287         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
1288         (RunQtAPITestsTest):
1289         (test_failure):
1290         (test_crash):
1291         * Scripts/run-qtwebkit-tests:
1292         (Main.announce_results_html):
1293         (Main):
1294         (Main.check_crash_occurences):
1295         (Main.convert_to_stdout):
1296         (Main.convert_to_html):
1297
1298 2012-03-28  Kwonjin Jeong  <gram@company100.net>
1299
1300         Add support for Intel compiler on Linux QT port.
1301         https://bugs.webkit.org/show_bug.cgi?id=81077
1302
1303         Reviewed by Tor Arne Vestbø.
1304
1305         * qmake/mkspecs/features/default_post.prf:
1306         Don't hide symbols when building with Intel compiler.
1307         The symbols are needed when building QtWebKit tests.
1308
1309         * qmake/mkspecs/features/unix/icc.prf:
1310         Added to ignore icc-specific warnings.
1311         This feature is used with command-line arguments for build-webkit script.
1312
1313 2012-03-28  Philippe Normand  <pnormand@igalia.com>
1314
1315         Unreviewed, trivial update-webkit-libs-jhbuild system call fix.
1316
1317         * Scripts/update-webkitgtk-libs: This script is written in
1318         Perl. Not Python. So use perl vocabulary to refer to command line arguments.
1319
1320 2012-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1321
1322         kill-old-processes doesn't do anything on linux
1323         https://bugs.webkit.org/show_bug.cgi?id=82388
1324
1325         Reviewed by Tony Chang.
1326
1327         Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
1328         This should help stabilizing Chromium linux bots.
1329
1330         * BuildSlaveSupport/kill-old-processes:
1331
1332 2012-03-28  Philippe Normand  <pnormand@igalia.com>
1333
1334         [GTK] jhbuild wrongly tricked into clean-up
1335         https://bugs.webkit.org/show_bug.cgi?id=82216
1336
1337         Reviewed by Gustavo Noronha Silva.
1338
1339         Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
1340         build tree. Also when checking if the jhbuild configuration
1341         changed use absolute md5sum paths.
1342
1343         * Scripts/webkitdirs.pm:
1344         (runAutogenForAutotoolsProjectIfNecessary):
1345         (jhbuildConfigurationChanged):
1346         (buildAutotoolsProject):
1347
1348 2012-03-28  Csaba Osztrogonác  <ossy@webkit.org>
1349
1350         kill-old-processes doesn't do anything on linux
1351         https://bugs.webkit.org/show_bug.cgi?id=82388
1352
1353         One more attempt to disable kill-old-processes on the Qt bots not to kill each others.
1354
1355         The platform in Factory comes from config.json, accordingly platform is fullplatform,
1356         for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.
1357
1358         Reviewed by Ryosuke Niwa.
1359
1360         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1361         (Factory.__init__):
1362
1363 2012-03-28  Hao Zheng  <zhenghao@chromium.org>
1364
1365         Make Chromium port for Android use hardware gpu path default.
1366         https://bugs.webkit.org/show_bug.cgi?id=82033
1367
1368         Reviewed by Dirk Pranke.
1369
1370         Skip canvas tests, which are run in virtual gpu test suites.
1371
1372         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1373         (ChromiumAndroidPort.__init__):
1374         (ChromiumAndroidPort.skipped_tests):
1375
1376 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1377
1378         kill-old-processes doesn't do anything on linux
1379         https://bugs.webkit.org/show_bug.cgi?id=82388
1380
1381         Disable kill-old-processes on the Qt bots not to kill each others.
1382
1383         Reviewed by Ryosuke Niwa.
1384
1385         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1386         (Factory.__init__):
1387
1388 2012-03-27  Hao Zheng  <zhenghao@chromium.org>
1389
1390         Handle DRT crash caused by Android OOM.
1391         https://bugs.webkit.org/show_bug.cgi?id=82310
1392
1393         Reviewed by Tony Chang.
1394
1395         When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
1396         is stopped silently and regarded as crashed. Re-run the test for
1397         such crash.
1398
1399         Add some debug log to NRWT.
1400
1401         * Scripts/webkitpy/layout_tests/port/chromium.py:
1402         (ChromiumDriver.run_test):
1403         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1404         (ChromiumAndroidPort.__init__):
1405         (ChromiumAndroidPort.get_last_stacktrace):
1406         (ChromiumAndroidDriver.__init__):
1407         (ChromiumAndroidDriver._start):
1408         (ChromiumAndroidDriver.run_test):
1409         (ChromiumAndroidDriver._get_drt_return_value):
1410
1411 2012-03-27  Ojan Vafai  <ojan@chromium.org>
1412
1413         Fix expected results for some unittest failures.
1414
1415         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
1416
1417 2012-03-27  Adrienne Walker  <enne@google.com>
1418
1419         [chromium] Fix --enabled-threaded-compositing flag in DRT
1420         https://bugs.webkit.org/show_bug.cgi?id=82405
1421
1422         Reviewed by James Robinson.
1423
1424         --enable-threaded-compositing wasn't working because there was no way
1425         to set the value before it was used in the TestShell constructor.
1426
1427         To avoid adding yet another boolean parameter to TestShell's
1428         constructor, add an explicit initialize function that can operate on
1429         any boolean settings that are set post-constructor.
1430
1431         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1432         (main):
1433         * DumpRenderTree/chromium/TestShell.cpp:
1434         (TestShell::TestShell):
1435         (TestShell::initialize):
1436         * DumpRenderTree/chromium/TestShell.h:
1437         (TestShell):
1438         (TestShell::setTestShellMode):
1439
1440 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
1441
1442         new-run-webkit-tests: suppress debug output from run-safari on results file
1443         https://bugs.webkit.org/show_bug.cgi?id=82400
1444
1445         Reviewed by Ryosuke Niwa.
1446
1447         Send the run-safari output to /dev/null rather than the console.
1448
1449         * Scripts/webkitpy/layout_tests/port/mac.py:
1450         (MacPort.show_results_html_file):
1451
1452 2012-03-27  Simon Fraser  <simon.fraser@apple.com>
1453
1454         Improve error reporting in run-javascriptcore-tests
1455         https://bugs.webkit.org/show_bug.cgi?id=82379
1456
1457         Reviewed by Jessie Berlin.
1458         
1459         When the script dies, have it print out the reason for dying.
1460
1461         * Scripts/run-javascriptcore-tests:
1462
1463 2012-03-27  Eric Seidel  <eric@webkit.org>
1464
1465         Add Dave Barton to the Contributors list so I can more easily CC him on bugs
1466         https://bugs.webkit.org/show_bug.cgi?id=82373
1467
1468         Reviewed by Ryosuke Niwa.
1469
1470         Dave's committer-status in in-progress, so until then
1471         list him as a Contributor so at least I can more easily CC him on bugs.
1472
1473         * Scripts/webkitpy/common/config/committers.py:
1474
1475 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1476
1477         [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
1478         https://bugs.webkit.org/show_bug.cgi?id=82252
1479
1480         Reviewed by Gustavo Noronha Silva.
1481
1482         Appending the directory containing common.py may be problematic if
1483         another path in sys.path also contains either a common.py or a
1484         common/ module, so prepend to select our version instead. This is
1485         the case with fail2ban, which has a common/ directory which may
1486         end up being in Python's default path.
1487
1488         * efl/jhbuildrc:
1489         * gtk/jhbuildrc:
1490
1491 2012-03-27  Dirk Pranke  <dpranke@chromium.org>
1492
1493         test-webkitpy: prepare for better test run output
1494         https://bugs.webkit.org/show_bug.cgi?id=82290
1495
1496         Reviewed by Adam Barth.
1497
1498         This code basically re-implements the output of the TextTestRunner default
1499         runner code from unittest, although the implementation is quite
1500         different, in preparation for changing the test output to be
1501         metered and possibly running in parallel.
1502
1503         The output is almost identical to before, except that instead of
1504         logging "test_regular (webkitpy.main.RunnerTest) passed" we log
1505         "webkitpy.main.RunnerTest.test_regular passed". It has always
1506         annoyed me that they invert the names to be harder to read and
1507         so that you can't copy & paste back to the input for
1508         test-webkitpy.
1509
1510         This patch is provided to add a skeleton for unit tests and for
1511         comparison to an upcoming patch that will actually add new
1512         functionality.
1513
1514         * Scripts/webkitpy/test/main.py:
1515         (Tester.__init__):
1516         (Tester._configure_logging):
1517         (Tester._run_tests):
1518         * Scripts/webkitpy/test/runner.py: Added.
1519         (TestRunner):
1520         (TestRunner.__init__):
1521         (TestRunner.test_name):
1522         (TestRunner.all_test_names):
1523         (TestRunner.run):
1524         (TestRunner.write_result):
1525         (TestRunner.write_summary):
1526         * Scripts/webkitpy/test/runner_unittest.py: Added.
1527         (FakeModuleSuite):
1528         (FakeModuleSuite.__init__):
1529         (FakeModuleSuite.__str__):
1530         (FakeModuleSuite.run):
1531         (FakeTopSuite):
1532         (FakeTopSuite.__init__):
1533         (FakeLoader):
1534         (FakeLoader.__init__):
1535         (FakeLoader.top_suite):
1536         (FakeLoader.loadTestsFromName):
1537         (RunnerTest):
1538         (RunnerTest.test_regular):
1539         (RunnerTest.test_verbose):
1540
1541 2012-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1542
1543         [GTK] Build gnutls without p11-kit support
1544         https://bugs.webkit.org/show_bug.cgi?id=82212
1545
1546         Reviewed by Martin Robinson.
1547
1548         * gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
1549         configure, to avoid requiring that dependency, which is not used
1550         by libsoup and WebKit anyway
1551
1552 2012-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1553
1554         [Qt] Make debug build work on 32 bit
1555         https://bugs.webkit.org/show_bug.cgi?id=82331
1556
1557         Use --no-keep-memory option of ld not to cache the symbol tables of input files in
1558         memory to avoid memory exhaustion during the linking phase for x86-debug builds.
1559
1560         Reviewed by Tor Arne Vestbø.
1561
1562         * qmake/mkspecs/features/unix/default_post.prf:
1563         * qmake/mkspecs/features/unix/default_pre.prf:
1564
1565 2012-03-23  Balazs Ankes  <bank@inf.u-szeged.hu>
1566
1567         Add png checking to check-webkit-style
1568         https://bugs.webkit.org/show_bug.cgi?id=75824
1569
1570         Reviewed by NOBODY Tony Chang.
1571
1572         * Scripts/webkitpy/style/checker.py:
1573         (_all_categories):
1574         (FileType):
1575         (CheckerDispatcher._should_skip_file_path):
1576         (CheckerDispatcher._file_type):
1577         (CheckerDispatcher._create_checker):
1578         * Scripts/webkitpy/style/checker_unittest.py:
1579         (CheckerDispatcherDispatchTest.test_none_paths):
1580         * Scripts/webkitpy/style/checkers/png.py: Added.
1581         (PNGChecker):
1582         (PNGChecker.__init__):
1583         (PNGChecker.check):
1584         (PNGChecker._config_file_path):
1585         * Scripts/webkitpy/style/checkers/png_unittest.py: Added.
1586         (MockSCMDetector):
1587         (MockSCMDetector.__init__):
1588         (MockSCMDetector.display_name):
1589         (MockSCMDetector.propget):
1590         (PNGCheckerTest):
1591         (PNGCheckerTest.test_init):
1592         (PNGCheckerTest.test_init.mock_handle_style_error):
1593         (PNGCheckerTest.test_check):
1594         (PNGCheckerTest.test_check.mock_handle_style_error):
1595         * Scripts/webkitpy/style/patchreader.py:
1596         (PatchReader.check):
1597
1598 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1599
1600         Unreviewed. Skip GTK+ unit tests that fail in the bots
1601
1602         * Scripts/run-gtk-tests:
1603         (TestRunner): Add failing tests to the skipped list.
1604
1605 2012-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1606
1607         Unreviewed. Unskip all GTK+ unit test.
1608
1609         Currently, skipped tests contains the list of unit tests that have
1610         failed in one or more bots. In this moment it's not possible to
1611         skip just the test cases that fail, so the complete unit test is
1612         skipped when a single test case fails. For that reason, we don't
1613         know which test cases are actually failing for every skipped
1614         test. We are planning to land a patch to allow skipping individual
1615         test cases, but first we need to know which test cases are
1616         currently failing in the bots to skip them. So, this patch simply
1617         unskips all unit tests in order to watch the bots and get the list
1618         of test cases failing. Failing tests will be skipped again as soon
1619         as we have the new list of failing test cases.
1620
1621         * Scripts/run-gtk-tests:
1622         (TestRunner): Reset the list of skipped tests.
1623
1624 2012-03-26  Scott Byer  <scottbyer@chromium.org>
1625
1626         Enable layout testing of the scroll animator.
1627         https://bugs.webkit.org/show_bug.cgi?id=81858
1628         Add a call to the InternalSettings that layout tests can use to
1629         turn on scroll animation. Enable animation updates for the
1630         Chromium platform DRT when scroll animation has been turned on in
1631         a test. This should be a no-op for all current layout tests.
1632
1633         Reviewed by James Robinson.
1634
1635         * DumpRenderTree/chromium/WebViewHost.cpp:
1636         (WebViewHost::serviceAnimation):
1637         (WebViewHost::scheduleAnimation):
1638         * DumpRenderTree/chromium/WebViewHost.h:
1639         (WebViewHost):
1640
1641 2012-03-26  Dinu Jacob  <dinu.jacob@nokia.com>
1642
1643         [Qt][WK2] Support multi-file upload
1644         https://bugs.webkit.org/show_bug.cgi?id=81589
1645
1646         Reviewed by Simon Hausmann.
1647
1648         Modified filePicker to support multi-file upload.
1649
1650         * MiniBrowser/qt/MiniBrowser.qrc:
1651         * MiniBrowser/qt/icons/checkbox_checked.png: Added.
1652         * MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
1653         * MiniBrowser/qt/js/MultiSelect.js: Added.
1654         (values):
1655         (isSelected):
1656         (removeValue):
1657         * MiniBrowser/qt/qml/CheckBox.qml: Added.
1658         * MiniBrowser/qt/qml/FilePicker.qml:
1659
1660 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1661
1662         Retry crashing tests serially at the end of NRWT on Apple Mac
1663         https://bugs.webkit.org/show_bug.cgi?id=82233
1664
1665         Reviewed by Dirk Pranke.
1666
1667         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1668         (Manager.run):
1669         * Scripts/webkitpy/layout_tests/port/base.py:
1670         (Port.should_retry_crashes):
1671         * Scripts/webkitpy/layout_tests/port/mac.py:
1672         (MacPort.should_retry_crashes):
1673
1674 2012-03-26  Mark Hahnenberg  <mhahnenberg@apple.com>
1675
1676         NRWT should retry failures serially
1677         https://bugs.webkit.org/show_bug.cgi?id=82241
1678
1679         Reviewed by Dirk Pranke.
1680
1681         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1682         (Manager._run_tests): Add another parameter to specify the number of workers to use.
1683         (Manager.run): Run the failures serially.
1684
1685 2012-03-26  Adrienne Walker  <enne@google.com>
1686
1687         Allow expectations on directories in virtual test suites
1688         https://bugs.webkit.org/show_bug.cgi?id=82250
1689
1690         Reviewed by Dirk Pranke.
1691
1692         lookup_virtual_test_base was only returning valid results for files
1693         and not directories. Fix by falling back to the virtual test suite
1694         mapping if possible.
1695
1696         * Scripts/webkitpy/layout_tests/port/base.py:
1697         (Port.lookup_virtual_test_base):
1698         * Scripts/webkitpy/layout_tests/port/test.py:
1699         (TestPort.skipped_tests):
1700         (TestPort.virtual_test_suites):
1701
1702 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1703
1704         Fix duplicated ChangeLog entry from r112171.
1705
1706         Unreviewed, build fix.
1707
1708 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1709
1710         nrwt: remove --worker-model flag
1711         https://bugs.webkit.org/show_bug.cgi?id=82112
1712
1713         Reviewed by Adam Barth.
1714
1715         The --worker-model=inline flag is basically redundant with the
1716         --child-processes=1 flag (technically, you could one run child
1717         process, but this is only useful for testing); this patch
1718         removes this flag, which simplifies things and enables more
1719         cleanup down the road.
1720
1721         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1722         (Manager._run_tests):
1723         (Manager.print_config):
1724         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1725         (get):
1726         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
1727         (make_broker):
1728         (FunctionTests.test_get__inline):
1729         (FunctionTests.test_get__processes):
1730         (_TestsMixin.setUp):
1731         (_TestsMixin.make_broker):
1732         (InlineBrokerTests.setUp):
1733         (MultiProcessBrokerTests.setUp):
1734         * Scripts/webkitpy/layout_tests/port/base.py:
1735         (Port.default_child_processes):
1736         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1737         (ChromiumAndroidPort.check_sys_deps):
1738         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
1739         (ChromiumAndroidPortTest):
1740         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1741         (MockDRTPortTest.make_port):
1742         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1743         (PortTestCase):
1744         (PortTestCase.make_port):
1745         * Scripts/webkitpy/layout_tests/port/test.py:
1746         (TestPort.default_child_processes):
1747         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1748         (_set_up_derived_options):
1749         (parse_args):
1750         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1751         (parse_args):
1752         (MainTest.test_batch_size):
1753         (MainTest.test_child_processes_2):
1754         (MainTest.test_child_processes_min):
1755         (MainTest.test_exception_raised):
1756         (MainTest.test_keyboard_interrupt):
1757         (MainTest.test_exit_after_n_crashes):
1758         (MainTest.assert_run_order):
1759         (MainTest.test_run_order__inline):
1760         (MainTest.test_virtual):
1761
1762 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1763
1764         test-webkitpy: split test-finding code into a different module
1765         https://bugs.webkit.org/show_bug.cgi?id=82253
1766
1767         Reviewed by Adam Barth.
1768
1769         Per suggestion from abarth, this change splits all the
1770         filesystem-crawling, test-finding code in test-webkitpy out into
1771         a separate module and switches to using a FileSystem object.
1772         This makes things much more testable, so we also add tests :).
1773
1774         We also add a realpath() method to the Filesystem object, since
1775         test-webkitpy needs that in order to be able to resolve symlinks
1776         properly to determine whether a file is under a particular tree
1777         or not.
1778
1779         * Scripts/webkitpy/common/system/filesystem.py:
1780         (FileSystem.realpath):
1781         * Scripts/webkitpy/common/system/filesystem_mock.py:
1782         (MockFileSystem.realpath):
1783         * Scripts/webkitpy/test/main.py:
1784         (Tester.__init__):
1785         (Tester.add_tree):
1786         (Tester.run):
1787         (Tester._run_tests):
1788         (Tester._log_exception):
1789         * Scripts/webkitpy/test/test_finder.py: Added.
1790         (TestDirectoryTree):
1791         (TestDirectoryTree.__init__):
1792         (TestDirectoryTree.find_modules):
1793         (TestDirectoryTree.find_modules.file_filter):
1794         (TestDirectoryTree.to_module):
1795         (TestDirectoryTree.clean):
1796         (TestFinder):
1797         (TestFinder.__init__):
1798         (TestFinder.add_tree):
1799         (TestFinder.additional_paths):
1800         (TestFinder.clean_trees):
1801         (TestFinder.is_module):
1802         (TestFinder.to_module):
1803         (TestFinder.find_names):
1804         (TestFinder._exclude):
1805         * Scripts/webkitpy/test/test_finder_unittest.py: Added.
1806         (TestFinderTest):
1807         (TestFinderTest.setUp):
1808         (TestFinderTest.tearDown):
1809         (TestFinderTest.test_additional_system_paths):
1810         (TestFinderTest.test_is_module):
1811         (TestFinderTest.test_to_module):
1812         (TestFinderTest.test_clean):
1813         (TestFinderTest.test_find_names):
1814
1815 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1816
1817         [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
1818         https://bugs.webkit.org/show_bug.cgi?id=82209
1819
1820         Reviewed by Martin Robinson.
1821
1822         Respecting the $MAKE environment variable when it is defined makes
1823         building jhbuild more portable, as some platforms may have GNU
1824         make as gmake, for example.
1825
1826         * jhbuild/jhbuild-wrapper:
1827         (install_jhbuild):
1828
1829 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1830
1831         add a Tree abstraction to test-webkitpy to better encapsulate things
1832         https://bugs.webkit.org/show_bug.cgi?id=82158
1833
1834         Reviewed by Adam Barth.
1835
1836         There are no functional changes in this patch, but adding a
1837         basic abstraction for the trees we are looking in for python
1838         tests will allow me to add some features later on more easily
1839         (like ignoring certain directories like webkitpy/thirdparty),
1840         and it makes things slightly less hard-coded.
1841
1842         * Scripts/test-webkitpy:
1843         * Scripts/webkitpy/test/main.py:
1844         (Tester.__init__):
1845         (Tester):
1846         (Tester.add_tree):
1847         (Tester._parse_args):
1848         (Tester._configure):
1849         (Tester.run):
1850         (Tester._find_modules):
1851         (Tester._run_tests):
1852         (Tester._is_module):
1853         (Tester._log_exception):
1854         (TestDirectoryTree):
1855         (TestDirectoryTree.__init__):
1856         (TestDirectoryTree.find_modules):
1857         (TestDirectoryTree.clean):
1858
1859 2012-03-26  Ojan Vafai  <ojan@chromium.org>
1860
1861         garden-o-matic should special case reftests
1862         https://bugs.webkit.org/show_bug.cgi?id=81812
1863
1864         Reviewed by Adam Barth.
1865
1866         On the examine page, don't show a rebaseline button for reftests.
1867         We still show it on the failure summary page because tests are grouped
1868         together. Long-term, we should make sure webkit-patch rebaseline-test
1869         never tries to rebaseline reftests.
1870
1871         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1872         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1873         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
1874
1875 2012-03-26  Dirk Pranke  <dpranke@chromium.org>
1876
1877         clean up NRWT logging/metering, be less verbose
1878         https://bugs.webkit.org/show_bug.cgi?id=73846
1879
1880         Reviewed by Ojan Vafai.
1881
1882         Re-land r112014 with a build fix for Python 2.6 compatibility.
1883
1884         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1885         (ManagerTest.test_http_locking):
1886         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1887         (AbstractWorker.run):
1888         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1889         (Worker.__init__):
1890         (Worker._set_up_logging):
1891         (Worker):
1892         (Worker._set_up_host_and_port):
1893         (Worker.run):
1894         (Worker.cleanup):
1895         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
1896         (WorkerTest.test_default_platform_in_worker):
1897         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1898         (run):
1899         (main):
1900         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
1901         (MeteredStream):
1902         (MeteredStream.implements):
1903         (MeteredStream._erasure):
1904         (MeteredStream._ensure_newline):
1905         (MeteredStream.__init__):
1906         (MeteredStream.__del__):
1907         (MeteredStream.cleanup):
1908         (MeteredStream.write_throttled_update):
1909         (MeteredStream.write_update):
1910         (MeteredStream.write):
1911         (MeteredStream.writeln):
1912         (MeteredStream._erase_last_partial_line):
1913         (_LogHandler):
1914         (_LogHandler.__init__):
1915         (_LogHandler.emit):
1916         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1917         (RegularTest):
1918         (RegularTest.setUp):
1919         (RegularTest.tearDown):
1920         (RegularTest.time_fn):
1921         (RegularTest.test_logging_not_included):
1922         (RegularTest._basic):
1923         (RegularTest.test_basic):
1924         (RegularTest._log_after_update):
1925         (RegularTest.test_log_after_update):
1926         (TtyTest):
1927         (TtyTest.test_basic):
1928         (TtyTest.test_log_after_update):
1929         (VerboseTest):
1930         (VerboseTest.test_basic):
1931         (VerboseTest.test_log_after_update):
1932         * Scripts/webkitpy/layout_tests/views/printing.py:
1933         (parse_print_options):
1934         (Printer.__init__):
1935         (Printer.cleanup):
1936         (Printer.print_progress):
1937         (Printer.print_update):
1938         (Printer._write):
1939         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1940         (Testprinter.get_printer):
1941         (Testprinter.test_print_progress):
1942         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1943         (PerfTestsRunner.__init__):
1944         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1945         (test_run_test_pause_before_testing):
1946
1947 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1948
1949         [jhbuild] Revert $MAKE environment hack introduced in r101929.
1950         https://bugs.webkit.org/show_bug.cgi?id=82234
1951
1952         Reviewed by Martin Robinson.
1953
1954         The problem it was supposedly fixing was fixed in jhbuild itself
1955         in git revision da8944d8ca987ca48c91b350257a530050406092, so we
1956         can remove the workaround added to the script.
1957
1958         * jhbuild/jhbuild-wrapper:
1959         (install_jhbuild):
1960
1961 2012-03-26  Leo Yang  <leo.yang@torchmobile.com.cn>
1962
1963         [BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
1964         https://bugs.webkit.org/show_bug.cgi?id=82157
1965
1966         Reviewed by Rob Buis.
1967
1968         * Scripts/build-webkit:
1969         Make ENABLE_FILE_SYSTEM default on for blackberry.
1970
1971 2012-03-26  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
1972
1973         [jhbuild] Explicitly disable DTrace when building glib.
1974         https://bugs.webkit.org/show_bug.cgi?id=82145
1975
1976         Reviewed by Gustavo Noronha Silva.
1977
1978         DTrace support is not really needed by WebKit, so disabling it
1979         helps avoid some build errors on more exotic platforms (such as
1980         FreeBSD).
1981
1982         * efl/jhbuild.modules:
1983         * gtk/jhbuild.modules:
1984
1985 2012-03-26  Sheriff Bot  <webkit.review.bot@gmail.com>
1986
1987         Unreviewed, rolling out r111993.
1988         http://trac.webkit.org/changeset/111993
1989         https://bugs.webkit.org/show_bug.cgi?id=82184
1990
1991         It broke layout and API tests and made WTR crash (Requested by
1992         Ossy on #webkit).
1993
1994         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1995         (WTR::PlatformWebView::PlatformWebView):
1996
1997 2012-03-25  Kevin Ollivier  <kevino@theolliviers.com>
1998
1999         [wx] Unreviewed build fix. Move WTF to its own static lib build.
2000
2001         * waf/build/settings.py:
2002         (common_configure):
2003
2004 2012-03-24  Chris Fleizach  <cfleizach@apple.com>
2005
2006         AX: Support solution to handle invalid ax text marker
2007         https://bugs.webkit.org/show_bug.cgi?id=82023
2008
2009         Reviewed by Oliver Hunt.
2010
2011         * DumpRenderTree/AccessibilityUIElement.cpp:
2012         (indexForTextMarkerCallback):
2013         (isTextMarkerValidCallback):
2014         (textMarkerForIndexCallback):
2015         (AccessibilityUIElement::indexForTextMarker):
2016         (AccessibilityUIElement::isTextMarkerValid):
2017         (AccessibilityUIElement::textMarkerForIndex):
2018         (AccessibilityUIElement::getJSClass):
2019         * DumpRenderTree/AccessibilityUIElement.h:
2020         (AccessibilityUIElement):
2021         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2022         (AccessibilityUIElement::indexForTextMarker):
2023         (AccessibilityUIElement::textMarkerForIndex):
2024         (AccessibilityUIElement::isTextMarkerValid):
2025         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2026         (WTR::AccessibilityUIElement::indexForTextMarker):
2027         (WTR::AccessibilityUIElement::isTextMarkerValid):
2028         (WTR::AccessibilityUIElement::textMarkerForIndex):
2029         (WTR):
2030         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2031         (AccessibilityUIElement):
2032         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2033         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2034         (WTR):
2035         (WTR::AccessibilityUIElement::indexForTextMarker):
2036         (WTR::AccessibilityUIElement::isTextMarkerValid):
2037         (WTR::AccessibilityUIElement::textMarkerForIndex):
2038
2039 2012-03-24  Sheriff Bot  <webkit.review.bot@gmail.com>
2040
2041         Unreviewed, rolling out r112014.
2042         http://trac.webkit.org/changeset/112014
2043         https://bugs.webkit.org/show_bug.cgi?id=82138
2044
2045         Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
2046         #webkit).
2047
2048         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2049         (ManagerTest.test_http_locking):
2050         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
2051         (AbstractWorker.run):
2052         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2053         (Worker.__init__):
2054         (Worker.safe_init):
2055         (Worker.run):
2056         (Worker.cleanup):
2057         * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
2058         (WorkerTest.test_default_platform_in_worker):
2059         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2060         (run):
2061         (main):
2062         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2063         (MeteredStream):
2064         (MeteredStream.is):
2065         (MeteredStream.__init__):
2066         (MeteredStream.write):
2067         (MeteredStream.update):
2068         (MeteredStream._overwrite):
2069         (MeteredStream._reset):
2070         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2071         (TestMeteredStream):
2072         (TestMeteredStream.test_regular):
2073         * Scripts/webkitpy/layout_tests/views/printing.py:
2074         (_configure_logging):
2075         (_restore_logging):
2076         (Printer.__init__):
2077         (Printer.cleanup):
2078         (Printer.print_progress):
2079         (Printer.print_update):
2080         (Printer._write):
2081         (Printer):
2082         (Printer._update):
2083         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2084         (TestUtilityFunctions.assertEmpty):
2085         (TestUtilityFunctions):
2086         (TestUtilityFunctions.assertNotEmpty):
2087         (TestUtilityFunctions.assertWritten):
2088         (TestUtilityFunctions.test_configure_logging):
2089         (Testprinter.get_printer):
2090         (Testprinter.test_print_progress):
2091         (Testprinter.test_print_progress.mock_time):
2092         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2093         (PerfTestsRunner.__init__):
2094         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2095         (test_run_test_pause_before_testing):
2096
2097 2012-03-24  Kevin Ollivier  <kevino@theolliviers.com>
2098
2099         [wx] Unreviewed. Fix the build after WTF move.
2100
2101         * waf/build/build_utils.py:
2102         (get_excludes):
2103         (get_excludes_in_dirs):
2104         * waf/build/settings.py:
2105         (get_port_excludes):
2106         (common_configure):
2107
2108 2012-03-24  Dirk Pranke  <dpranke@chromium.org>
2109
2110         clean up NRWT logging/metering, be less verbose
2111         https://bugs.webkit.org/show_bug.cgi?id=73846
2112
2113         Reviewed by Ojan Vafai.
2114
2115         This patch totally rewrites the metered_stream module and
2116         changes the way it and the printing module now interact with the
2117         logging subsystem.
2118
2119         The printing module becomes a dumb layout_tests-specific wrapper around
2120         the metered stream. All of the intelligence of how and when to
2121         actually write (or erase) lines and how things interact with
2122         logging moves into the metered stream.
2123
2124         As of now, anything written to the metered stream *bypasses the
2125         logging system*. If a logger is passed to the meter constructor,
2126         the metered stream will also attach a log handler so that all
2127         messages fed to the logger will also be written to the metered
2128         stream. This detangles the logic that used to exist where
2129         sometimes the meter would write to the logger and sometimes the
2130         logger would write to the meter.
2131
2132         All of this makes the logic generic and reusable for
2133         test-webkitpy (coming in another patch). It also helps clarify
2134         what the mysterious "configure_logging" parameter to the printer
2135         constructor used to do (that parameter itself is gone now, and
2136         by default the printer and metered_stream will not ever touch
2137         the logging system; this makes a bunch of tests less fragile).
2138
2139         All of the above should produce no user-visible changes.
2140
2141         However, to also fix the bug in question, we change the message
2142         format in --verbose mode to %H:%M:%S.%frac %pid %message,
2143         eliminating the date, file:lineno, and level parameters. I am
2144         making this change at the same time because it would be
2145         difficult to write things consistently between the logs and the
2146         metered stream if we were still logging the file:lineno.
2147
2148         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2149           Remove the configure_logging parameter
2150         * Scripts/webkitpy/layout_tests/controllers/worker.py:
2151           Use metered stream to configure the logging (we don't need a printer)
2152           and be careful about when and how we manipulate the log level
2153           and handlers on the root logger.
2154         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2155           Pass in the root logger so that log messages are formatted
2156           properly, and set the log level outside of any routines called
2157           by unit tests so as to not interfere.
2158         * Scripts/webkitpy/layout_tests/views/manager_worker_broker.py:
2159           remove a duplicate log message.
2160         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2161           complete rewrite :).
2162         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2163           complete rewrite :).
2164         * Scripts/webkitpy/layout_tests/views/printing.py:
2165           move the logging configuration into metered_stream, and also
2166           move the "when should I log progress messages" into metered stream.
2167         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2168           remove tests that are no longer necessary.
2169         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2170           remove the configure_logging parameter.
2171         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2172           update the test; since the printer no longer writes to the log,
2173           we need to check what is written to the regular_output instead.
2174           (test_run_test_pause_before_testing):
2175
2176 2012-03-24  Gustavo Noronha Silva  <gns@gnome.org>
2177
2178         Add myself and Martin Robinson to:
2179           * GStreamerGraphics
2180           * GtkWebKit2PublicAPI
2181           * SoupNetwork
2182         and to the newly created WebKitGTKTranslations.
2183
2184         Rubber-stamped by Martin Robinson.
2185
2186         * Scripts/webkitpy/common/config/watchlist:
2187
2188 2012-03-24  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
2189
2190         [Qt][WK2] Implement PageClient::isViewWindowActive()
2191         https://bugs.webkit.org/show_bug.cgi?id=81143
2192
2193         Reviewed by Kenneth Rohde Christiansen.
2194
2195         Fix the WrapperWindow from our PlatformWebView
2196         so it correctly creates the platform related
2197         stuff for QWindow, which is not created unless
2198         QWindow::setVisible() or QWindow::show() are called.
2199
2200         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2201         (WTR::PlatformWebView::PlatformWebView):
2202
2203 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
2204
2205         nrwt: don't wait for safari to exit before exiting after showing the results file
2206         https://bugs.webkit.org/show_bug.cgi?id=81845
2207
2208         Reviewed by Ryosuke Niwa.
2209
2210         Prior to this change, if you ran new-run-webkit-tests and
2211         displayed the HTML results file at the end, we would block
2212         waiting for the user to quit the browser. There doesn't seem to
2213         be a need for that, and the Chromium ports don't do this.
2214
2215         Also, update the mac tests to capture the output and be quiet :).
2216
2217         * Scripts/webkitpy/common/system/executive_mock.py:
2218           Make popen() testable, implement should_log for it.
2219         * Scripts/webkitpy/layout_tests/port/mac.py:
2220         (MacPort.show_results_html_file):
2221         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2222           Silence some of the tests via outputcapture.
2223
2224 2012-03-23  Gustavo Noronha Silva  <gns@gnome.org>
2225
2226         [GTK] libgcrypt and p11-kit should not be in jhbuild modules
2227         https://bugs.webkit.org/show_bug.cgi?id=82073
2228
2229         Reviewed by Martin Robinson.
2230
2231         * Scripts/webkitdirs.pm:
2232         (jhbuildConfigurationChanged): new function that isolates the
2233         jhbuild configuration change checking from the autogen logic.
2234         (mustReRunAutogen): code for the new function lived here.
2235         (buildAutotoolsProject): now calls jhbuildConfigurationChanged
2236         itself, and cleans up the jhbuild root if configuration has
2237         changed; it also forces autogen to be run in that case, to
2238         make sure the new libraries are used.
2239         * gtk/jhbuild.modules: removed libgcrypt and p11-kit.
2240         * jhbuild/jhbuild-wrapper:
2241         (ensure_jhbuild): this might be run inside a jhbuild environment,
2242         in which case aclocal fails when trying to use the now deleted
2243         aclocal directory in the jhbuild prefix, so work around that.
2244
2245 2012-03-23  Ojan Vafai  <ojan@chromium.org>
2246
2247         garden-o-matic scrolls to the top of the page when you click an accordion item
2248         https://bugs.webkit.org/show_bug.cgi?id=82088
2249
2250         Reviewed by Adam Barth.
2251
2252         Check the scroll position and make sure that the clicked accordion item is visible.
2253
2254         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
2255
2256 2012-03-23  Dirk Pranke  <dpranke@chromium.org>
2257
2258         LayoutTestHelper could get torn down earlier (mostly to reset color profile)
2259         https://bugs.webkit.org/show_bug.cgi?id=80567
2260
2261         Reviewed by Ryosuke Niwa.
2262
2263         Move clean_up_run to occur right after we finish testing and
2264         before we start processing the results. Also makes set_up_run()
2265         and clean_up_run() private since there's no real need for
2266         callers to be aware of them.
2267
2268         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2269         (Manager._set_up_run):
2270         (Manager.run):
2271         (Manager._clean_up_run):
2272         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2273         (ManagerTest.test_http_locking):
2274         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2275         (run):
2276
2277 2012-03-23  Dean Jackson  <dino@apple.com>
2278
2279         Disable CSS_SHADERS in Apple builds
2280         https://bugs.webkit.org/show_bug.cgi?id=81996
2281
2282         Reviewed by Simon Fraser.
2283
2284         Default enableCSSShaders to be 0 on all builds that use
2285         this script. Use the flag to turn it back on.
2286
2287         * Scripts/build-webkit:
2288
2289 2012-03-23  Tony Chang  <tony@chromium.org>
2290
2291         [chromium] rename newwtf target back to wtf
2292         https://bugs.webkit.org/show_bug.cgi?id=82064
2293
2294         Reviewed by Adam Barth.
2295
2296         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2297
2298 2012-03-23  Jessie Berlin  <jberlin@apple.com>
2299
2300         Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
2301         the Lion Intel WebKit2 Debug bots.
2302         https://bugs.webkit.org/show_bug.cgi?id=81012.
2303
2304         Rubber-stamped by Dan Bernstein.
2305
2306         Add a step to kill the pasteboard server while we investigate what is causing these
2307         assertion failures (to get the bots green).
2308
2309         * BuildSlaveSupport/kill-old-processes:
2310
2311 2012-03-22  Martin Robinson  <mrobinson@igalia.com>
2312
2313         [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
2314         https://bugs.webkit.org/show_bug.cgi?id=81986
2315
2316         Reviewed by David Levin.
2317
2318         Track whether or not errors are filtered in error handlers. If an
2319         alphabetical sorting error is reported for a header and filtered, try
2320         reporting it for the other potential source of the error. This ensures
2321         that the style bot can still find new sorting errors in both potential
2322         situations:
2323
2324             #include <foo.h> <-- 1. edited line
2325             #include <baz.h> <-- 2. edited line
2326
2327         * Scripts/webkitpy/style/checkers/cpp.py:
2328         (check_include_line): Potentially report the error for both lines,
2329         if the first error is filtered.
2330         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
2331         test that allows only reporting errors for certain lines. This verifies that
2332         when one line of an ordering error is filtered, the error is reported on the
2333         other line.
2334         (ErrorCollector.__init__):
2335         (ErrorCollector.__call__):
2336         (CppStyleTestBase.perform_lint):
2337         (CppStyleTestBase.perform_language_rules_check):
2338         (CppStyleTestBase.assert_language_rules_check):
2339         (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
2340         Added a new test that verifies that when one line of the two lines of an ordering
2341         error occur, the error is reported on the other line.
2342         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
2343         (MockErrorHandler.__call__): Report True because the error is handled.
2344         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2345         (ErrorCollector.__call__): Ditto.
2346         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
2347         (MockErrorHandler.__call__): Ditto.
2348         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
2349         (TestErrorHandler.__call__): Ditto.
2350         * Scripts/webkitpy/style/checkers/xml_unittest.py:
2351         (MockErrorHandler.__call__): Ditto.
2352         * Scripts/webkitpy/style/error_handlers.py:
2353         (DefaultStyleErrorHandler.__call__): Report True if the error is handled
2354         and False if it is filtered.
2355
2356 2012-03-23  Patrick Gansterer  <paroga@webkit.org>
2357
2358         Build fix for WinCE after r111778.
2359
2360         * WinCELauncher/CMakeLists.txt:
2361
2362 2012-03-23  Peter Beverloo  <peter@chromium.org>
2363
2364         Unreviewed buildfix for the Chromium Android builder.
2365
2366         Disable the ImageDiff target for now. Android needs to build this for
2367         host rather than for target (as other configurations do), but since the
2368         WTF move the dependency chain got significantly more complicated.
2369
2370         I'll work out a proper fix in the following bug, but since several
2371         things are broken due to this, this buildfix should be landed first.
2372         https://bugs.webkit.org/show_bug.cgi?id=82039
2373
2374         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2375
2376 2012-03-23  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2377
2378         [EFL][DRT] Implement LayoutTestController's methods related with editing.
2379         https://bugs.webkit.org/show_bug.cgi?id=80136
2380
2381         Reviewed by Ryosuke Niwa.
2382
2383         Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
2384         setSelectTrailingWhitespaceEnabled.
2385
2386         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2387         (LayoutTestController::setSmartInsertDeleteEnabled):
2388         (LayoutTestController::setSelectTrailingWhitespaceEnabled):
2389
2390 2012-03-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2391
2392         Convert hasGrammarMarker to use Internals interface
2393         https://bugs.webkit.org/show_bug.cgi?id=82004
2394
2395         Reviewed by Ryosuke Niwa.
2396
2397         Remove hasGrammarMarker functions, because it is able to work in the
2398         cross-port way through the Internals interface.
2399
2400         * DumpRenderTree/LayoutTestController.cpp:
2401         (LayoutTestController::staticFunctions):
2402         * DumpRenderTree/LayoutTestController.h:
2403         (LayoutTestController):
2404         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
2405         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2406         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
2407         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
2408         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
2409         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
2410
2411 2012-03-22  Adam Barth  <abarth@webkit.org>
2412
2413         sync-master-with-upstream creates non-linear git history
2414         https://bugs.webkit.org/show_bug.cgi?id=82006
2415
2416         Reviewed by Julien Chaffraix.
2417
2418         Previously this script would create a merge commit at the HEAD of
2419         origin/master, causing your fork of WebKit to diverge from upstream.
2420         The new version of this script pushes directly from upstream to origin
2421         (without round-tripping through any local branches), avoiding this
2422         problem.
2423
2424         * Scripts/sync-master-with-upstream:
2425
2426 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
2427
2428         Unreviewed build fix. Add knowledge of the WTF project to
2429         the autotools build system scripts so that build-jsc works
2430         correctly for GTK+.
2431
2432         * Scripts/webkitdirs.pm:
2433         (buildAutotoolsProject): handle the WTF project, build the
2434         libWTF.la target.
2435         (buildGtkProject): add WTF to the list of supported projects.
2436
2437 2012-03-22  Eric Seidel  <eric@webkit.org>
2438
2439         Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf
2440         https://bugs.webkit.org/show_bug.cgi?id=81984
2441
2442         Reviewed by Adam Barth.
2443
2444         * Scripts/VCSUtils.pm:
2445         (adjustPathForRecentRenamings):
2446
2447 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2448
2449         [CMake] Fix build-jsc after r111778 and r111797.
2450         https://bugs.webkit.org/show_bug.cgi?id=82001
2451
2452         Reviewed by Filip Pizlo.
2453
2454         Contrary to the comment in build-jsc, buildCMakeProjectOrExit()
2455         does return if no error occurred, and build-jsc failed with
2456         "building not defined for this platform".
2457
2458         * Scripts/build-jsc: Always exit after caling
2459         buildCMakeProjectOrExit().
2460         * Scripts/webkitdirs.pm:
2461         (buildCMakeProjectOrExit): Return 0 if no error occurred.
2462
2463 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2464
2465         [CMake] Unreviewed build fix after r111778.
2466
2467         * DumpRenderTree/efl/CMakeLists.txt: Replace
2468         ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include
2469         paths.
2470         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right
2471         wtf include.
2472         * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto.
2473         * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf
2474         with ${WTF_DIR}/wtf in the include paths.
2475
2476 2012-03-22  Filip Pizlo  <fpizlo@apple.com>
2477
2478         Tools/Scripts/build-jsc doesn't work after WTF move
2479         https://bugs.webkit.org/show_bug.cgi?id=81999
2480
2481         Reviewed by Eric Seidel.
2482         
2483         For ports that require WTF and JSC to be built as two projects and where
2484         the machinery to build both does not already exist, teach the tool to do
2485         so for us.
2486
2487         * Scripts/build-jsc:
2488         (buildMyProject):
2489
2490 2012-03-22  Ojan Vafai  <ojan@chromium.org>
2491
2492         Fix accidental missing line in r111793.
2493
2494         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2495         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2496         Remove base.values. It was unused and duplicates the builtin Object.values.
2497         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2498         Accidentally deleted this line before committing r111793.
2499
2500 2012-03-22  Ojan Vafai  <ojan@chromium.org>
2501
2502         Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
2503         https://bugs.webkit.org/show_bug.cgi?id=81983
2504
2505         Reviewed by Adam Barth.
2506
2507         The dialogs get in the way if you are doing multiple rebaselines. Also,
2508         a number of people didn't realize that you could do multiple rebaselines
2509         in parallel. A non-modal dialog is just confusing.
2510
2511         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2512         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
2513         If we're only rebaselining 1 test, show the test name in the initial message. Otherwise,
2514         show the number of tests being rebaselined.
2515
2516         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
2517         Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped
2518         by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together
2519         into a single area.
2520
2521         Once addFinalMessage has been called for all IDs, we show the close button. Clicking close
2522         also serves to clear all teh content in the StatusArea. 
2523
2524         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
2525         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
2526
2527 2012-03-22  Tony Chang  <tony@chromium.org>
2528
2529         Unreviewed, fix chromium build after wtf move.
2530
2531         Only use newwtf, remove references to wtf.
2532
2533         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2534
2535 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
2536
2537         Actually move WTF files to their new home
2538         https://bugs.webkit.org/show_bug.cgi?id=81844
2539
2540         [Qt] Unreviewed buildfix after r111778.
2541
2542         * DumpRenderTree/qt/DumpRenderTree.pro:
2543
2544 2012-03-22  Dan Bernstein  <mitz@apple.com>
2545
2546         Font fallback in WebKitTestRunner depends on user settings
2547         https://bugs.webkit.org/show_bug.cgi?id=81978
2548
2549         Reviewed by Jessie Berlin.
2550
2551         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2552         (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
2553         with a value consisting of the array ("en") to the override defaults
2554         dictionary. This is the same value used in DumpRenderTree, and it
2555         ensures that font fallback follows a consistent path that is not
2556         affected by the language preferences of the user running the test.
2557
2558 2012-03-22  Andy Estes  <aestes@apple.com>
2559
2560         check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
2561         https://bugs.webkit.org/show_bug.cgi?id=81971
2562
2563         Reviewed by Dan Bernstein.
2564
2565         Xcode will automatically link ObjC binaries against libarclite in some
2566         cases, which defines a class called __ARCLite__.
2567         check-for-inappropriate-objc-class-names shouldn't complain about this
2568         class name.
2569
2570         * Scripts/check-for-inappropriate-objc-class-names:
2571
2572 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
2573
2574         new-run-webkit-tests blames the wrong test for crashing
2575         https://bugs.webkit.org/show_bug.cgi?id=81951
2576
2577         Reviewed by Adam Barth.
2578
2579         NRWT wasn't extracting the WebProcess pid correct; should've
2580         used re.search instead of re.match :(. Add more tests!
2581
2582         * Scripts/webkitpy/layout_tests/port/mac.py:
2583         (MacPort._get_crash_log):
2584         * Scripts/webkitpy/layout_tests/port/webkit.py:
2585         (WebKitDriver.has_crashed):
2586         (WebKitDriver._check_for_driver_crash):
2587         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2588         (WebKitDriverTest.test_no_timeout):
2589         (WebKitDriverTest):
2590         (WebKitDriverTest.test_check_for_driver_crash):
2591         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
2592         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
2593         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
2594         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
2595         (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
2596         (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
2597
2598 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2599
2600         [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
2601         https://bugs.webkit.org/show_bug.cgi?id=81512
2602
2603         Adding missing implementation markerTextForListItem to EFL's
2604         LayoutTestController so that we can unskip related tests from
2605         the skip list.
2606
2607         Reviewed by Antonio Gomes.
2608
2609         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2610         (LayoutTestController::markerTextForListItem): Implemented.
2611
2612 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2613
2614         [EFL] Enable view mode media feature layout tests
2615         https://bugs.webkit.org/show_bug.cgi?id=81205
2616
2617         Adding missing implementation setViewModeMediaFeature to EFL's 
2618         LayoutTestController so that we can unskip view mode 
2619         media feature layout tests.
2620
2621         Reviewed by Antonio Gomes.
2622
2623         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2624         (LayoutTestController::setViewModeMediaFeature): Implemented.
2625
2626 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
2627
2628         nrwt: crash while stopping layout test helper on apple mac lion
2629         https://bugs.webkit.org/show_bug.cgi?id=81949
2630
2631         Reviewed by Eric Seidel.
2632
2633         stop_helper() didn't work right if the helper process wasn't
2634         still running or didn't respond properly to being shut down. Fix
2635         this and add some tests. Also add code to MockExecutive() to be
2636         able to mock executive.popen() properly.
2637
2638         * Scripts/webkitpy/common/system/executive_mock.py:
2639         (MockProcess.__init__):
2640         (MockProcess.wait):
2641         (MockExecutive.__init__):
2642         (MockExecutive.popen):
2643         * Scripts/webkitpy/common/system/systemhost_mock.py:
2644         (MockSystemHost.__init__):
2645         * Scripts/webkitpy/layout_tests/port/mac.py:
2646         (MacPort.start_helper):
2647         (MacPort.stop_helper):
2648         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2649         (test_get_crash_log):
2650         (test_helper_starts):
2651         (test_helper_fails_to_start):
2652         (test_helper_fails_to_stop):
2653         (test_helper_fails_to_stop.bad_waiter):
2654
2655 2012-03-22  Gustavo Noronha Silva  <gns@gnome.org>
2656
2657         [GTK] Add make to the jhbuild moduleset
2658         https://bugs.webkit.org/show_bug.cgi?id=81769
2659
2660         Reviewed by Martin Robinson.
2661
2662         Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
2663         Add GNU make with custom patches to fix several issues:
2664
2665         - make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
2666           fix the argument list limit of GNU make when running make
2667           distcheck.
2668         - make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
2669           and Jeremy Devenport to fix parallel build issues present in
2670           GNU make 3.82
2671
2672         * gtk/jhbuild.modules: Added make with patches.
2673         * gtk/patches/make-3.82-arg-list-length.patch: Added.
2674         * gtk/patches/make-3.82-parallel-build.patch: Added.
2675
2676 2012-03-22  Kevin Ollivier  <kevino@theolliviers.com>
2677
2678         [wx] Unreviewed. Adding Source/WTF to the build and updating
2679         waf port list.
2680
2681         * DumpRenderTree/wscript:
2682         * waf/build/settings.py:
2683
2684 2012-03-22  Dirk Pranke  <dpranke@chromium.org>
2685
2686         Re-land fix for r81603 yet again (!) with latest build fix.
2687         https://bugs.webkit.org/show_bug.cgi?id=81603
2688
2689         Unreviewed, build fix.
2690
2691         The latest problem was a bad sprintf() in
2692         BasePort._get_crash_log(). I've reworked that routine and added
2693         unit tests for coverage.
2694
2695         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2696         (SingleTestRunner._handle_error):
2697         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2698         (write_test_result):
2699         (TestResultWriter.write_crash_log):
2700         * Scripts/webkitpy/layout_tests/port/base.py:
2701         (Port.diff_text):
2702         (Port._get_crash_log):
2703         * Scripts/webkitpy/layout_tests/port/chromium.py:
2704         (ChromiumDriver.run_test):
2705         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2706         (ChromiumDriverTest.test_crash_log):
2707         * Scripts/webkitpy/layout_tests/port/driver.py:
2708         (DriverOutput.__init__):
2709         * Scripts/webkitpy/layout_tests/port/mac.py:
2710         (MacPort.is_lion):
2711         (MacPort._get_crash_log):
2712         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2713         (test_default_child_processes):
2714         (test_get_crash_log):
2715         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2716         (MockDRTPortTest.test_get_crash_log):
2717         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2718         (PortTestCase.test_get_crash_log):
2719         * Scripts/webkitpy/layout_tests/port/test.py:
2720         (TestDriver.run_test):
2721         * Scripts/webkitpy/layout_tests/port/webkit.py:
2722         (WebKitDriver.__init__):
2723         (WebKitDriver._start):
2724         (WebKitDriver.has_crashed):
2725         (WebKitDriver._check_for_driver_crash):
2726         (WebKitDriver.run_test):
2727
2728 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
2729
2730         [Qt] Enable support for handling database quota's in the MiniBrowser
2731         https://bugs.webkit.org/show_bug.cgi?id=81928
2732
2733         Reviewed by Simon Hausmann.
2734
2735         * MiniBrowser/qt/qml/BrowserWindow.qml:
2736
2737 2012-03-22  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
2738
2739         [EFL] Implement LayoutTestController::setEditingBehavior
2740         https://bugs.webkit.org/show_bug.cgi?id=81124
2741
2742         Adding missing implementation setEditingBehavior to EFL's
2743         LayoutTestController. This implementation allows us to
2744         unskip some tests from the skip list.
2745
2746         Reviewed by Martin Robinson.
2747
2748         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2749         (LayoutTestController::setEditingBehavior): Implemented.
2750
2751 2012-03-22  Carlos Garcia Campos  <cgarcia@bb-webkit-rel-64.local.igalia.com>
2752
2753         [GTK] Use the angle-bracket form to include wtf headers
2754         https://bugs.webkit.org/show_bug.cgi?id=81884
2755
2756         Reviewed by Eric Seidel.
2757
2758         Use #include <wtf/foo> instead of #include "foo".
2759
2760         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
2761         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2762         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2763         * DumpRenderTree/gtk/EditingCallbacks.cpp:
2764         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
2765         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2766
2767 2012-03-22  Alexander Færøy  <alexander.faeroy@nokia.com>
2768
2769         Unreviewed, add Michael Brüning and Allan Jensen to committers.py.
2770
2771         * Scripts/webkitpy/common/config/committers.py:
2772
2773 2012-03-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
2774
2775         [Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated.
2776         https://bugs.webkit.org/show_bug.cgi?id=81889
2777
2778         Reviewed by Kenneth Rohde Christiansen.
2779
2780         Enable FAST_MOBILE_SCROLLING feature.
2781
2782         * qmake/mkspecs/features/features.prf:
2783
2784 2012-03-22  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
2785
2786         [EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
2787         https://bugs.webkit.org/show_bug.cgi?id=81900
2788
2789         Reviewed by Gustavo Noronha Silva.
2790
2791         r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
2792         path which assumed a certain directory structure for the build
2793         directory which may noy be true.
2794
2795         Instead, hardcode the path to the downloaded fonts starting from the
2796         top-level source directory. While this solution is also far from
2797         perfect, it makes it more consistent and reliable, and easier to
2798         tackle at once with the rest of bug 81475.
2799
2800         * DumpRenderTree/efl/CMakeLists.txt:
2801
2802 2012-03-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2803
2804         [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
2805         https://bugs.webkit.org/show_bug.cgi?id=81888
2806
2807         Reviewed by Philippe Normand.
2808
2809         * Scripts/update-webkit-libs-jhbuild:
2810         (runJhbuild): Helper function to run jhbuild with a given command.
2811         Instead of running jhbuild directly, use the jhbuild-wrapper, so
2812         that we don't need to run it first to check whether jhbuild is
2813         installed or not.
2814         * efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
2815         * gtk/run-with-jhbuild: Ditto.
2816         * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
2817         not only run.
2818
2819 2012-03-22  Philippe Normand  <pnormand@igalia.com>
2820
2821         Unreviewed, test-webkitpy fix after r111661.
2822
2823         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2824         (MainTest.test_crash_log):
2825         (MainTest.test_web_process_crash_log):
2826
2827 2012-03-22  Philippe Normand  <pnormand@igalia.com>
2828
2829         Unreviewed, test-webkitpy fix after r111642.
2830
2831         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2832         (ChromiumDriverTest.setUp):
2833         (ChromiumDriverTest.test_two_drivers):
2834
2835 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
2836
2837         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
2838         https://bugs.webkit.org/show_bug.cgi?id=81603
2839
2840         Unreviewed rolling out r111609 and part of r111615,
2841         because it broke NRWT on Qt-WK2 platform.
2842
2843         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2844         (SingleTestRunner._handle_error):
2845         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2846         (write_test_result):
2847         (TestResultWriter.write_crash_report):
2848         * Scripts/webkitpy/layout_tests/port/base.py:
2849         (Port.is_crash_reporter):
2850         (Port._driver_class):
2851         * Scripts/webkitpy/layout_tests/port/chromium.py:
2852         (ChromiumDriver.run_test):
2853         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2854         (ChromiumDriverTest.test_crashed_process_name):
2855         * Scripts/webkitpy/layout_tests/port/driver.py:
2856         (DriverOutput.__init__):
2857         * Scripts/webkitpy/layout_tests/port/mac.py:
2858         (MacPort):
2859         (MacPort.is_crash_reporter):
2860         (MacPort.release_http_lock):
2861         * Scripts/webkitpy/layout_tests/port/test.py:
2862         (TestDriver.run_test):
2863         * Scripts/webkitpy/layout_tests/port/webkit.py:
2864         (WebKitDriver.__init__):
2865         (WebKitDriver._start):
2866         (WebKitDriver.has_crashed):
2867         (WebKitDriver._check_for_driver_crash):
2868         (WebKitDriver.run_test):
2869
2870 2012-03-22  Csaba Osztrogonác  <ossy@webkit.org>
2871
2872         [Qt] Add full platforms to Qt buildslaves
2873         https://bugs.webkit.org/show_bug.cgi?id=81877
2874
2875         Reviewed by Ryosuke Niwa.
2876
2877         * BuildSlaveSupport/build.webkit.org-config/config.json:
2878
2879 2012-03-21  Johnny Ding  <jnd@chromium.org>
2880
2881         Customize layout test timeout value for different ports.
2882         https://bugs.webkit.org/show_bug.cgi?id=79859
2883
2884         Reviewed by Ojan Vafai.
2885
2886         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2887         (Manager):
2888         * Scripts/webkitpy/layout_tests/port/base.py:
2889         (Port.default_test_timeout_ms):
2890         * Scripts/webkitpy/layout_tests/port/chromium.py:
2891         (ChromiumDriver.stop):
2892         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2893         (ChromiumAndroidPort.default_test_timeout_ms):
2894         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2895         (_set_up_derived_options):
2896
2897 2012-03-21  Mark Rowe  <mrowe@apple.com>
2898
2899         Fix the build.
2900
2901         Ensure that our test tools don't try and use RTTI unnecessarily.
2902
2903         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2904         * TestWebKitAPI/Configurations/Base.xcconfig:
2905         * WebKitTestRunner/Configurations/Base.xcconfig:
2906
2907 2012-03-21  Adam Barth  <abarth@webkit.org>
2908
2909         WebKit should have some scripts to smooth interactions with GitHub
2910         https://bugs.webkit.org/show_bug.cgi?id=81842
2911
2912         Reviewed by Eric Seidel.
2913
2914         These scripts support the workflow in
2915         https://trac.webkit.org/wiki/UsingGitHub by automating the
2916         configuration and syncing operations needed for a GitHub fork of WebKit
2917         to track the main WebKit repository.
2918
2919         * Scripts/configure-github-as-upstream: Added.
2920         * Scripts/sync-master-with-upstream: Added.
2921
2922 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2923
2924         WTR - log the pid of a crashing WebProcess
2925         https://bugs.webkit.org/show_bug.cgi?id=81575
2926
2927         Reviewed by Alexey Proskuryakov.
2928
2929         This allows run-webkit-tests to find the right crash log for a
2930         given crashed WebProcess in WebKit2.
2931
2932         * WebKitTestRunner/TestController.cpp:
2933         (WTR::exceededDatabaseQuota):
2934         (WTR::TestController::createOtherPage):
2935         (WTR::TestController::initialize):
2936         (WTR::TestController::resetStateToConsistentValues):
2937         (WTR::TestController::runTest):
2938         (WTR::TestController::processDidCrash):
2939
2940 2012-03-21  Enrica Casucci  <enrica@apple.com>
2941
2942         WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
2943         https://bugs.webkit.org/show_bug.cgi?id=81835
2944         <rdar://problem/11082749>
2945
2946         Reviewed by Brady Eidson.
2947
2948         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
2949         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
2950         (TestWebKitAPI::contextMenuCopyLink):
2951
2952 2012-03-21  Alexandru Chiculita  <achicu@adobe.com>
2953
2954         [CSS Shaders] Make CSS Shaders compile on Chromium
2955         https://bugs.webkit.org/show_bug.cgi?id=81435
2956
2957         Reviewed by Stephen White.
2958         
2959         I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
2960
2961         * DumpRenderTree/chromium/LayoutTestController.cpp:
2962         (LayoutTestController::overridePreference):
2963         * DumpRenderTree/chromium/WebPreferences.cpp:
2964         (WebPreferences::reset):
2965         (WebPreferences::applyTo):
2966         * DumpRenderTree/chromium/WebPreferences.h:
2967         (WebPreferences):
2968
2969 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2970
2971         fix regression on gtk port introduced by r111609
2972         https://bugs.webkit.org/show_bug.cgi?id=81839
2973
2974         Reviewed by Philippe Normand.
2975
2976         r111609 should've initialized a couple of missing fields in
2977         WebKitDriver, and also should've checked for method overrides
2978         in the other ports :(.
2979
2980         * Scripts/webkitpy/layout_tests/port/gtk.py:
2981         (GtkDriver._start):
2982         * Scripts/webkitpy/layout_tests/port/webkit.py:
2983         (WebKitDriver.__init__):
2984         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2985         (MainTest.test_crash_log):
2986         (MainTest.test_web_process_crash_log):
2987
2988 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
2989
2990         webkitpy: clean up actually getting crash logs from DRT/WTR crashes
2991         https://bugs.webkit.org/show_bug.cgi?id=81603
2992
2993         Reviewed by Adam Barth.
2994
2995         Add a new _get_crash_log() overridable method on the Port
2996         object to customize how we fetch crash logs per port.
2997         Mac will now slow-spin with a timeout waiting for the crash log, rather
2998         than waiting for the ReportCrash process to exit (it appears
2999         that the mac will manage multiple crashes with a single
3000         ReportCrash process, the process waits around longer than
3001         necessary, presumably to avoid thrashing if processes are
3002         repeatedly crashing).
3003
3004         Also, add the DriverOutput should contain the crash log and other info,
3005         which is created in a port-specific manner but can then be
3006         treated generically. Previously single_test_runner would get
3007         told that something crashed and attempt to do something to get
3008         the crash log, but it didn't have the information it needed to
3009         od the right thing; better to make the driver hand back the
3010         right info.
3011
3012         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3013         (SingleTestRunner._handle_error):
3014         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3015         (write_test_result):
3016         (TestResultWriter.write_crash_log):
3017         * Scripts/webkitpy/layout_tests/port/base.py:
3018         (Port.diff_text):
3019         (Port._get_crash_log):
3020         * Scripts/webkitpy/layout_tests/port/chromium.py:
3021         (ChromiumDriver.run_test):
3022         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3023         (ChromiumDriverTest.test_crash_log):
3024         * Scripts/webkitpy/layout_tests/port/driver.py:
3025         (DriverOutput.__init__):
3026         * Scripts/webkitpy/layout_tests/port/mac.py:
3027         (MacPort.is_lion):
3028         (MacPort._get_crash_log):
3029         * Scripts/webkitpy/layout_tests/port/test.py:
3030         (TestDriver.run_test):
3031         * Scripts/webkitpy/layout_tests/port/webkit.py:
3032         (WebKitDriver.__init__):
3033         (WebKitDriver._start):
3034         (WebKitDriver.has_crashed):
3035         (WebKitDriver._check_for_driver_crash):
3036         (WebKitDriver.run_test):
3037
3038 2012-03-21  Dominik Röttsches  <dominik.rottsches@linux.intel.com>
3039
3040         [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
3041         https://bugs.webkit.org/show_bug.cgi?id=81507
3042
3043         Now that we're only loading from one directory, no need to
3044         iterate over a list of directories anymore.
3045
3046         Reviewed by Martin Robinson.
3047
3048         * DumpRenderTree/efl/CMakeLists.txt:
3049         * DumpRenderTree/efl/FontManagement.cpp:
3050         (addFontDirectory):
3051         (addFontsToEnvironment):
3052
3053 2012-03-21  Dirk Pranke  <dpranke@chromium.org>
3054
3055         webkitpy: get ServerProcess out of the reportcrash business
3056         https://bugs.webkit.org/show_bug.cgi?id=81600
3057
3058         Unreviewed, build fix.
3059
3060         Re-land r111307 and r111293 with another fix for a crash in NRWT;
3061         we need to check if the driver has crashed before attempting to
3062         read from it.
3063
3064
3065         * Scripts/webkitpy/layout_tests/port/server_process.py:
3066         (ServerProcess._reset):
3067         (ServerProcess._handle_possible_interrupt):
3068         (ServerProcess.write):
3069         (ServerProcess.read_stdout):
3070         (ServerProcess.has_crashed):
3071         (ServerProcess._read):
3072         (ServerProcess.stop):
3073         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3074         (TrivialMockPort.check_for_leaks):
3075         (TestServerProcess.test_broken_pipe):
3076         * Scripts/webkitpy/layout_tests/port/webkit.py:
3077         (WebKitPort._read_image_diff):
3078         (WebKitDriver.has_crashed):
3079         (WebKitDriver._check_for_driver_crash):
3080         (WebKitDriver.run_test):
3081         (WebKitDriver._read_block):
3082         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3083         (MockServerProcess.__init__):
3084         (MockServerProcess):
3085         (MockServerProcess.has_crashed):
3086
3087 2012-03-21  Zeno Albisser  <zeno@webkit.org>
3088
3089         [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
3090         https://bugs.webkit.org/show_bug.cgi?id=81750
3091
3092         Building WebCore on mac currently creates an archive that is bigger than
3093         4GB. But ranlib fails to create a symbol table for such a big archive,
3094         even on 64bit machines.
3095         Therefore we start using SVGAllInOne.cpp when building debug
3096         on mac. This reduces the size of the archive by about 300MB.
3097
3098         Reviewed by Tor Arne Vestbø.
3099
3100         * qmake/mkspecs/features/mac/default_pre.prf:
3101
3102 2012-03-21  Szilard Ledan  <szledan@inf.u-szeged.hu>
3103
3104         Updated the address list of committers.py.
3105
3106         Reviewed by Csaba Osztrogonác.
3107
3108         * Scripts/webkitpy/common/config/committers.py:
3109
3110 2012-03-21  W. James MacLean  <wjmaclean@chromium.org>
3111
3112         Updating my nick in committers file.
3113
3114         Unreviewed.
3115
3116         * Scripts/webkitpy/common/config/committers.py:
3117
3118 2012-03-21  Peter Beverloo  <peter@chromium.org>
3119
3120         [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
3121         https://bugs.webkit.org/show_bug.cgi?id=80861
3122
3123         Reviewed by Tony Chang.
3124
3125         Remove most Android-specific logic from webkitdirs.pm in favor of
3126         handling this during project generation time.
3127
3128         * Scripts/webkitdirs.pm:
3129         (buildChromiumMakefile):
3130
3131 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3132
3133         [GTK] Allow running javascript from location bar in MiniBrowser
3134         https://bugs.webkit.org/show_bug.cgi?id=81331
3135
3136         Reviewed by Martin Robinson.
3137
3138         * MiniBrowser/gtk/BrowserWindow.c:
3139         (activateUriEntryCallback): Use browser_window_load_uri().
3140         (browser_window_load_uri): Check whether uri starts with
3141         javascript: and run the given script, or just call
3142         webkit_web_view_load_uri() to load the given uri.
3143         * MiniBrowser/gtk/BrowserWindow.h:
3144         * MiniBrowser/gtk/main.c:
3145         (createBrowserWindow): Use browser_window_load_uri().
3146
3147 2012-03-21  Carlos Garcia Campos  <cgarcia@igalia.com>
3148
3149         [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
3150         https://bugs.webkit.org/show_bug.cgi?id=75543
3151
3152         Reviewed by Martin Robinson.
3153
3154         * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
3155         MiniBrowser CPP flags.
3156
3157 2012-03-20  Eric Seidel  <eric@webkit.org>
3158
3159         Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
3160         https://bugs.webkit.org/show_bug.cgi?id=80911
3161
3162         Reviewed by Adam Barth.
3163
3164         Update include paths for Source/WTF.
3165
3166         * DumpRenderTree/efl/CMakeLists.txt:
3167         * DumpRenderTree/qt/DumpRenderTree.pro:
3168         * QtTestBrowser/QtTestBrowser.pro:
3169         * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
3170
3171 2012-03-20  Adam Barth  <abarth@webkit.org>
3172
3173         svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
3174         https://bugs.webkit.org/show_bug.cgi?id=81567
3175
3176         Reviewed by Eric Seidel.
3177
3178         This temporary measure should help us avoid disrupting the folks
3179         working on WebAudio when we move the webaudio directory to Modules.
3180
3181         * Scripts/VCSUtils.pm:
3182         (adjustPathForRecentRenamings):
3183         (parseGitDiffHeader):
3184         (parseSvnDiffHeader):
3185
3186 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
3187
3188         Unreviewed, rolling out r111453.
3189         http://trac.webkit.org/changeset/111453
3190         https://bugs.webkit.org/show_bug.cgi?id=81600
3191
3192         still broken
3193
3194         * Scripts/webkitpy/layout_tests/port/server_process.py:
3195         (ServerProcess._reset):
3196         (ServerProcess.handle_interrupt):
3197         (ServerProcess.write):
3198         (ServerProcess._check_for_crash):
3199         (ServerProcess._handle_timeout):
3200         (ServerProcess._check_for_abort):
3201         (ServerProcess._read):
3202         (ServerProcess.stop):
3203         (ServerProcess):
3204         (ServerProcess.set_crashed):
3205         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3206         (TrivialMockPort.is_crash_reporter):
3207         (TestServerProcess.test_broken_pipe):
3208         * Scripts/webkitpy/layout_tests/port/webkit.py:
3209         (WebKitPort._read_image_diff):
3210         (WebKitDriver.has_crashed):
3211         (WebKitDriver._check_for_driver_crash):
3212         (WebKitDriver):
3213         (WebKitDriver._detected_crash):
3214         (WebKitDriver._subprocess_crashed):
3215         (WebKitDriver._crashed_process_name):
3216         (WebKitDriver.run_test):
3217         (WebKitDriver._read_block):
3218         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3219         (MockServerProcess.__init__):
3220
3221 2012-03-20  Dirk Pranke  <dpranke@chromium.org>
3222
3223         webkitpy: get ServerProcess out of the reportcrash business
3224         https://bugs.webkit.org/show_bug.cgi?id=81600
3225
3226         Unreviewed, build fix.
3227
3228         Re-land r111307 and r111293 with fix for crash in NRWT; I
3229         was failing to set the crashing process name.
3230
3231         * Scripts/webkitpy/layout_tests/port/server_process.py:
3232         (ServerProcess._reset):
3233         (ServerProcess._handle_possible_interrupt):
3234         (ServerProcess.write):
3235         (ServerProcess.read_stdout):
3236         (ServerProcess.has_crashed):
3237         (ServerProcess._read):
3238         (ServerProcess.stop):
3239         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3240         (TrivialMockPort.check_for_leaks):
3241         (TestServerProcess.test_broken_pipe):
3242         * Scripts/webkitpy/layout_tests/port/webkit.py:
3243         (WebKitPort._read_image_diff):
3244         (WebKitDriver.has_crashed):
3245         (WebKitDriver._check_for_driver_crash):
3246         (WebKitDriver.run_test):
3247         (WebKitDriver._read_block):
3248         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3249         (MockServerProcess.__init__):
3250         (MockServerProcess):
3251         (MockServerProcess.has_crashed):
3252
3253 2012-03-20  Tim Horton  <timothy_horton@apple.com>
3254
3255         [mac] Restore color space switching code to run-webkit-tests
3256         https://bugs.webkit.org/show_bug.cgi?id=80571
3257         <rdar://problem/11008529>
3258
3259         Reviewed by Simon Fraser.
3260
3261         http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
3262         
3263         Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
3264         didn't exist until Lion.
3265
3266         * DumpRenderTree/mac/LayoutTestHelper.m:
3267         (installLayoutTestColorProfile):
3268         (restoreUserColorProfile):
3269
3270 2012-03-20  Adele Peterson  <adele@apple.com>
3271
3272         Update the last test to use EXPECT_WK_STREQ.
3273
3274         Reviewed by Dan Bernstein.
3275
3276         * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
3277
3278 2012-03-20  Adele Peterson  <adele@apple.com>
3279
3280         "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
3281         https://bugs.webkit.org/show_bug.cgi?id=81630
3282         <rdar://problem/10650660>
3283
3284         Reviewed by Alexey Proskuryakov.
3285
3286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3287         * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
3288         * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
3289         (-[AttributedStringTest webView:didFinishLoadForFrame:]):
3290         (TestWebKitAPI):
3291         (TestWebKitAPI::didFinishLoadForFrame):
3292         (TestWebKitAPI::TEST):
3293         * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
3294
3295 2012-03-20  Eric Seidel  <eric@webkit.org>
3296
3297         Add link on queues.webkit.org to kov's fancy queue-depth graph
3298         https://bugs.webkit.org/show_bug.cgi?id=81690
3299
3300         Reviewed by Adam Barth.
3301
3302         * QueueStatusServer/templates/recentstatus.html:
3303
3304 2012-03-20  Tim Horton  <timothy_horton@apple.com>
3305
3306         [mac] Restore color space switching code to run-webkit-tests
3307         https://bugs.webkit.org/show_bug.cgi?id=80571
3308         <rdar://problem/11008529>
3309
3310         Reviewed by Simon Fraser.
3311
3312         Make use of the layout test helper hooks to restore the Mac system-wide
3313         color profile switching code. This makes WkTR and DRT results match, and
3314         causes the main display's color profile to not affect results on Lion.
3315
3316         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3317         * DumpRenderTree/mac/LayoutTestHelper.m: Added.
3318         (installLayoutTestColorProfile):
3319         (restoreUserColorProfile):
3320         (simpleSignalHandler):
3321         (main):
3322         * Scripts/webkitpy/layout_tests/port/mac.py:
3323         (MacPort.release_http_lock):
3324         (MacPort):
3325         (MacPort._path_to_helper):
3326         (MacPort.start_helper):
3327         (MacPort.stop_helper):
3328         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3329         (WTR::PlatformWebView::PlatformWebView):
3330         (WTR::PlatformWebView::windowSnapshotImage):
3331
3332 2012-02-24  Darin Fisher  <darin@chromium.org>
3333
3334         Add more Chromium WebKit API reviewers
3335         https://bugs.webkit.org/show_bug.cgi?id=81576
3336
3337         Reviewed by Adam Barth and David Levin.
3338
3339         Simplify watchlist to lump all WebKit API into one.
3340
3341         * Scripts/webkitpy/common/config/watchlist:
3342
3343 2012-03-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3344
3345         Convert hasSpellingMarker to use Internals interface.
3346         https://bugs.webkit.org/show_bug.cgi?id=81300
3347
3348         Reviewed by Ryosuke Niwa.
3349
3350         Remove hasSpellingMarker functions, because it is able to work in the
3351         cross-port way through the Internals interface.
3352
3353         * DumpRenderTree/LayoutTestController.cpp:
3354         (LayoutTestController::staticFunctions):
3355         * DumpRenderTree/LayoutTestController.h:
3356         (LayoutTestController):
3357         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
3358         * DumpRenderTree/chromium/LayoutTestController.cpp:
3359         (LayoutTestController::LayoutTestController):
3360         * DumpRenderTree/chromium/LayoutTestController.h:
3361         (LayoutTestController):
3362         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3363         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3364         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3365         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
3366         * DumpRenderTree/qt/LayoutTestControllerQt.h:
3367         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3368         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3369
3370 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
3371
3372         Add new Qt-WK2 performance tester bot to build.webkit.org
3373         https://bugs.webkit.org/show_bug.cgi?id=80842
3374
3375         Reviewed by Ryosuke Niwa.
3376
3377         * BuildSlaveSupport/build.webkit.org-config/config.json:
3378         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3379         (RunAndUploadPerfTestsWebKit2):
3380         (RunAndUploadPerfTestsWebKit2.start):
3381         (BuildAndPerfTestWebKit2Factory):
3382         (BuildAndPerfTestWebKit2Factory.__init__):
3383         (DownloadAndPerfTestWebKit2Factory):
3384         (DownloadAndPerfTestWebKit2Factory.__init__):
3385
3386 2012-03-20  Peter Beverloo  <peter@chromium.org>
3387
3388         [Chromium] Update to Android NDK r7b
3389         https://bugs.webkit.org/show_bug.cgi?id=81005
3390
3391         Reviewed by Adam Barth.
3392
3393         Update to version r7b of the Android NDK, release notes of which are
3394         available on the following page:
3395         http://developer.android.com/sdk/ndk/index.html
3396
3397         * Scripts/update-webkit-chromium:
3398
3399 2012-03-20  Csaba Osztrogonác  <ossy@webkit.org>
3400
3401         x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
3402         https://bugs.webkit.org/show_bug.cgi?id=81502
3403
3404         Unreviewed.
3405
3406         * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
3407
3408 2012-03-19  Jessie Berlin  <jberlin@apple.com>
3409
3410         Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
3411         because they broke running the layout tests on mac.
3412
3413         * Scripts/webkitpy/layout_tests/port/webkit.py:
3414         (WebKitDriver._check_for_driver_crash):
3415
3416 2012-03-16  Martin Robinson  <mrobinson@igalia.com>
3417
3418         [GTK] Allow running run-gtk-tests during 'make distcheck'
3419         https://bugs.webkit.org/show_bug.cgi?id=81415
3420
3421         Reviewed by Philippe Normand.
3422
3423         Modify the build and run-gtk-tests so that it can run during 'make distcheck'
3424
3425         * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
3426         main command run during 'make check.'
3427         * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
3428         a requirement to run it. If jhbuild isn't around it will simply not start the
3429         SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
3430         main loop and simply use the main loop in a synchronous method to start SPI
3431         daemons. Did a bunch of general cleanup around these tasks.
3432
3433 2012-03-19  Raphael Kubo da Costa  <rakuco@FreeBSD.org>
3434
3435         jhbuild: Use the multiprocessing module to get the number of CPUs.
3436         https://bugs.webkit.org/show_bug.cgi?id=81585
3437
3438         Reviewed by Martin Robinson.
3439
3440         Now that support for Python 2.5 has been dropped, we can safely
3441         use multiprocessing.cpu_count() to obtain the current number of
3442         CPUs in the system instead of running a webkitperl script for
3443         that.
3444
3445         * efl/common.py:
3446         (top_level_path):
3447         * efl/jhbuildrc:
3448         * gtk/common.py:
3449         (build_path):
3450         * gtk/jhbuildrc:
3451
3452 2012-03-19  Ojan Vafai  <ojan@chromium.org>
3453
3454         We should only add a live event listener once, not once per TestSelector.
3455         Adding one per TestSelector would cause accordion('option', 'active') to
3456         incorrectly be "false" if you examine multiple sets of tests.
3457
3458         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3459
3460 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3461
3462         Fix typo introduced in r111293.
3463
3464         Unreviewed, build fix.
3465
3466         * Scripts/webkitpy/layout_tests/port/webkit.py:
3467         (WebKitDriver._check_for_driver_crash):
3468
3469 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3470
3471         webkitpy: get ServerProcess out of the reportcrash business
3472         https://bugs.webkit.org/show_bug.cgi?id=81600
3473
3474         Reviewed by Adam Barth.
3475
3476         ServerProcess was half-aware that ReportCrash might run
3477         sometimes, and that the process ServerProcess was talking to
3478         might have its own crashing subprocesses; neither of these
3479         things really worked right and it made the logic convoluted, so
3480         this change makes handling crashes completely separate from the
3481         server_process code, so that it can focus on just I/O to the
3482         subprocess.
3483
3484         There should be no functional changes resulting from this patch.
3485
3486         * Scripts/webkitpy/layout_tests/port/server_process.py:
3487         (ServerProcess._reset):
3488         (ServerProcess._handle_possible_interrupt):
3489         (ServerProcess.write):
3490         (ServerProcess.read_stdout):
3491         (ServerProcess.has_crashed):
3492         (ServerProcess._read):
3493         (ServerProcess.stop):
3494         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3495         (TrivialMockPort.check_for_leaks):
3496         (TestServerProcess.test_broken_pipe):
3497         * Scripts/webkitpy/layout_tests/port/webkit.py:
3498         (WebKitPort._read_image_diff):
3499         (WebKitDriver.has_crashed):
3500         (WebKitDriver._check_for_driver_crash):
3501         (WebKitDriver.run_test):
3502         (WebKitDriver._read_block):
3503         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3504         (MockServerProcess.__init__):
3505         (MockServerProcess):
3506         (MockServerProcess.has_crashed):
3507
3508 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3509
3510         webkitpy: crashlog parsing is broken
3511         https://bugs.webkit.org/show_bug.cgi?id=81586
3512
3513         Reviewed by Adam Barth.
3514
3515         Seeking on a file opened through codecs() appears to not work
3516         correctly (at least on SL).
3517         
3518         The code was more complicated than it needed to be, so I have
3519         revamped it to just read a full crashlog at once and then look
3520         for matches. 
3521         
3522         I have also added the ability to optionally propagate
3523         errors back (which can be helpful to debug races when ReportCrash is
3524         still running and you need to see that you couldn't open some
3525         files, rather than just ignoring them).
3526
3527         * Scripts/webkitpy/common/system/crashlogs.py:
3528         (CrashLogs.find_newest_log):
3529         (CrashLogs._find_newest_log_darwin):
3530         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3531         (CrashLogsTest.test_find_log_darwin):
3532
3533 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3534
3535         webkitpy: clean up some port._filesystem references to not reference private members
3536         https://bugs.webkit.org/show_bug.cgi?id=81595
3537
3538         Reviewed by Eric Seidel.
3539
3540         There should be no functional changes in this patch, just some
3541         refactoring. Also, fixes a minor nit in write_image_diff_files(()
3542
3543         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3544         (SingleTestRunner.__init__):
3545         (SingleTestRunner._run_compare_test):
3546         (SingleTestRunner._run_rebaseline):
3547         (SingleTestRunner._save_baseline_data):
3548         (SingleTestRunner._handle_error):
3549         (SingleTestRunner._run_reftest):
3550         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3551         (write_test_result):
3552         (TestResultWriter.__init__):
3553         (TestResultWriter._make_output_directory):
3554         (TestResultWriter.output_filename):
3555         (TestResultWriter._output_testname):
3556         (TestResultWriter.write_output_files):
3557         (TestResultWriter.write_stderr):
3558         (TestResultWriter.write_crash_report):
3559         (TestResultWriter.create_text_diff_and_write_result):
3560         (TestResultWriter.write_image_diff_files):
3561         (copy_file):
3562         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3563         (TestResultWriterTest.test_reftest_diff_image):
3564
3565 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3566
3567         webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
3568         https://bugs.webkit.org/show_bug.cgi?id=81598
3569
3570         Reviewed by Eric Seidel.
3571
3572         "DumpRenderTree" shouldn't be hard-coded here, since some other
3573         process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
3574         
3575         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3576         (TestExpectations):
3577
3578 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3579
3580         webkitpy: allow instance data in TestFailure objects
3581         https://bugs.webkit.org/show_bug.cgi?id=81580
3582
3583         Reviewed by Tony Chang.
3584
3585         Current TestFailures are basically enums, but it would be nice,
3586         especially for crashes, if they contained the name and pid of
3587         the process that crashed.
3588
3589         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3590         (TestFailure.message):
3591         (FailureTimeout.message):
3592         (FailureCrash):
3593         (FailureCrash.__init__):
3594         (FailureCrash.message):
3595         (FailureMissingResult.message):
3596         (FailureTextMismatch.message):
3597         (FailureMissingImageHash.message):
3598         (FailureMissingImage.message):
3599         (FailureImageHashMismatch.message):
3600         (FailureImageHashIncorrect.message):
3601         (FailureReftestMismatch.message):
3602         (FailureReftestMismatchDidNotOccur.message):
3603         (FailureReftestNoImagesGenerated.message):
3604         (FailureMissingAudio.message):
3605         (FailureAudioMismatch.message):
3606         * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
3607         (TestFailuresTest.test_equals):
3608         (TestFailuresTest):
3609         (TestFailuresTest.test_crashes):
3610
3611 2012-03-19  Brady Eidson  <beidson@apple.com>
3612
3613         <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
3614         Crash in 3rd party WebKit apps under XHR/Cache code
3615
3616         Reviewed by Antti Koivisto.
3617
3618         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3619         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
3620         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
3621         (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
3622         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
3623         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
3624         (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
3625         (TestWebKitAPI):
3626         (TestWebKitAPI::TEST):
3627
3628 2012-03-19  Brady Eidson  <beidson@apple.com>
3629
3630         <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
3631         REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
3632
3633         Reviewed by Enrica Casucci.
3634
3635         Bring up a context menu on a link, copy the link, then verify the pasteboard contents
3636         are in the correct format.
3637
3638         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3639         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
3640         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
3641         (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
3642         (TestWebKitAPI::contextMenuCopyLink):
3643         (TestWebKitAPI::TEST):
3644
3645 2012-03-19  Ojan Vafai  <ojan@chromium.org>
3646
3647         Make the selected item in the accordion a link to the flakiness dashboard
3648         https://bugs.webkit.org/show_bug.cgi?id=81571
3649
3650         Reviewed by Dimitri Glazkov.
3651
3652         Also, make it so that you can select the text of the link, instead of the current behavior
3653         of acting as if you had clicked on the accordion header.
3654
3655         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3656         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
3657
3658 2012-03-19  Dirk Pranke  <dpranke@chromium.org>
3659
3660         NRWT runs some tests that are skipped with -i command line option
3661         https://bugs.webkit.org/show_bug.cgi?id=81535
3662
3663         Reviewed by Ojan Vafai.
3664
3665         This change modifies the interaction of Skipped files and
3666         test_expectations files so that entries in Skipped files (and
3667         the -i command line) override *everything* in the expectations
3668         file.
3669
3670         Specifically, a directory in a Skipped file will cause all of
3671         the tests in the dir to be skipped even if individual tests in
3672         the dir are listed in the test_expectations.txt.
3673
3674         Skipped files also override anything in an overrides files.
3675
3676         This seems to make more intuitive sense, since if you list
3677         something in the Skips file (and even more specify it on the
3678         command line) you probably want it to be universally applied.
3679
3680         Theoretically we could add more precedence levels and have full
3681         paths in an expectations file override dirs in a Skipped file
3682         (but not the command line), but I don't know yet that that level
3683         of complexity is justified.
3684