[chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
[WebKit-https.git] / Tools / ChangeLog
1 2012-08-27  James Robinson  <jamesr@chromium.org>
2
3         [chromium] Fix exit code status logic in run-chromium-webkit-unit-tests
4         https://bugs.webkit.org/show_bug.cgi?id=95115
5
6         Reviewed by Adam Barth.
7
8         Use VCSUtils utility function to check if webkit_unit_tests terminates normally so we generate a non-zero exit
9         code if the unit tests crash.
10
11         * Scripts/run-chromium-webkit-unit-tests:
12
13 2012-08-27  Benjamin Poulain  <benjamin@webkit.org>
14
15         Add ECMAScript Number to String conversion to WTF::String
16         https://bugs.webkit.org/show_bug.cgi?id=95016
17
18         Reviewed by Geoffrey Garen.
19
20         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
21         (TestWebKitAPI::testNumberToStringECMAScript):
22         (TestWebKitAPI): Add tests for String's ECMAString number conversion.
23
24 2012-08-27  Philippe Normand  <pnormand@igalia.com>
25
26         [GStreamer][Qt] WebAudio support
27         https://bugs.webkit.org/show_bug.cgi?id=94806
28
29         Reviewed by Simon Hausmann.
30
31         * MiniBrowser/qt/qml/BrowserWindow.qml: Enable WebAudio support.
32
33 2012-08-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
34
35         Rename RegisterProtocolHandler API to NavigatorContentUtils
36         https://bugs.webkit.org/show_bug.cgi?id=94920
37
38         Reviewed by Adam Barth.
39
40         Renamed 'register-protocol-handler' feature to 'navigator-content-utils'.
41
42         * Scripts/webkitperl/FeatureList.pm:
43         * qmake/mkspecs/features/features.pri:
44
45 2012-08-24  Benjamin Poulain  <bpoulain@apple.com>
46
47         Unify Number to StringImpl conversion
48         https://bugs.webkit.org/show_bug.cgi?id=94879
49
50         Reviewed by Geoffrey Garen.
51
52         Add testing for the new IntegerToStringConversion.
53
54         * TestWebKitAPI/CMakeLists.txt:
55         * TestWebKitAPI/GNUmakefile.am:
56         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
57         * TestWebKitAPI/Tests/WTF/IntegerToStringConversion.cpp: Added.
58
59 2012-08-23  James Robinson  <jamesr@chromium.org>
60
61         [chromium] Convert WebLayerTreeView interface into pure virtual
62         https://bugs.webkit.org/show_bug.cgi?id=94866
63
64         Reviewed by Adrienne Walker.
65
66         Updates DumpRenderTree's WebViewHost to vend a WebCompositorOutputSurface so DumpRenderTree can run compositing
67         tests.
68
69         * DumpRenderTree/DumpRenderTree.gypi:
70         * DumpRenderTree/chromium/WebViewHost.cpp:
71         (WebViewHost::createOutputSurface):
72         * DumpRenderTree/chromium/WebViewHost.h:
73         (WebViewHost):
74         * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
75         (WebKit):
76         (WebKit::WebViewHostOutputSurface::WebViewHostOutputSurface):
77         (WebKit::WebViewHostOutputSurface::~WebViewHostOutputSurface):
78         (WebKit::WebViewHostOutputSurface::bindToClient):
79         (WebKit::WebViewHostOutputSurface::capabilities):
80         (WebKit::WebViewHostOutputSurface::context3D):
81         (WebKit::WebViewHostOutputSurface::sendFrameToParentCompositor):
82         * DumpRenderTree/chromium/WebViewHostOutputSurface.h: Copied from Source/WebKit/chromium/src/WebLayerTreeViewImpl.h.
83         (WebKit):
84         (WebViewHostOutputSurface):
85
86 2012-08-24  Xianzhu Wang  <wangxianzhu@chromium.org>
87
88         [Chromium-Android] Many 'Unexpected EOF ...' when a test crashes
89         https://bugs.webkit.org/show_bug.cgi?id=94865
90
91         Reviewed by Dirk Pranke.
92
93         Android detects crash of test by checking if the return value of read() is None.
94         Added a parameter 'treat_no_data_as_crash' to let ServerProcess know the special requirement of Android.
95         If set, ServerProcess will set _crashed unconditionaly when there is no data.
96
97         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
98         (ChromiumAndroidPort.__init__):
99         (ChromiumAndroidPort):
100         (ChromiumAndroidPort._android_server_process_constructor):
101         (ChromiumAndroidDriver._start_once):
102         * Scripts/webkitpy/layout_tests/port/server_process.py:
103         (ServerProcess.__init__):
104         (ServerProcess._wait_for_data_and_update_buffers_using_select):
105
106 2012-08-24  Arnaud Renevier  <a.renevier@sisa.samsung.com>
107
108         build-webkit --gtk fails with Can't exec ""
109         https://bugs.webkit.org/show_bug.cgi?id=94944
110
111         Reviewed by Martin Robinson.
112
113         When jhbuild wrapper is not needed, do unshift a blank string to build
114         arguments.
115
116         * Scripts/webkitdirs.pm:
117         (runAutogenForAutotoolsProjectIfNecessary):
118
119 2012-08-24  Tommy Widenflycht  <tommyw@google.com>
120
121         MediaStream API: Add readyState functionality to RTCPeerConnection
122         https://bugs.webkit.org/show_bug.cgi?id=94813
123
124         Reviewed by Adam Barth.
125
126         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
127         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
128         (MockWebRTCPeerConnectionHandler::stop):
129         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h:
130         (MockWebRTCPeerConnectionHandler):
131
132 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
133
134         Unreviewed. Adding myself to committers list.
135
136         Also updated email information.
137
138         * Scripts/webkitpy/common/config/committers.py:
139
140 2012-08-24  Michael Brüning  <michaelbruening@gmail.com>
141
142         [Qt][WK2] Make viewport related experimental.test properties encapsulated.
143         https://bugs.webkit.org/show_bug.cgi?id=88320
144
145         Reviewed by Kenneth Rohde Christiansen.
146
147         Changed the access to the viewport attributes to use the viewport object that is introduced by this change.
148
149         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
150
151 2012-08-23  Dirk Pranke  <dpranke@chromium.org>
152
153         leak detection broken after r126247 on mac
154         https://bugs.webkit.org/show_bug.cgi?id=94893
155
156         Unreviewed, build fix.
157
158         Adds is_snowleopard(), is_lion back() in for the mac port. We'll
159         probably need an is_mountainlion() or equivalent at some point,
160         I'm guessing (but I've deleted the leopard code).
161
162         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
163         (LeakDetector._callstacks_to_exclude_from_leaks):
164         * Scripts/webkitpy/layout_tests/port/mac.py:
165         (MacPort):
166         (MacPort.is_snowleopard):
167         (MacPort.is_lion):
168
169 2012-08-23  Julien Chaffraix  <jchaffraix@webkit.org>
170
171         [Chromium] Enable AtomicString && CString && WTFString && StringImpl unit tests
172         https://bugs.webkit.org/show_bug.cgi?id=94871
173
174         Reviewed by Benjamin Poulain.
175
176         * TestWebKitAPI/TestWebKitAPI.gypi:
177         Added the missing files to Chromium's build system.
178
179 2012-08-23  Raphael Kubo da Costa  <rakuco@webkit.org>
180
181         [watchlist] Unreviewed, subscribe to WebKit2-EFL bugs.
182
183         * Scripts/webkitpy/common/config/watchlist:
184
185 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
186
187         Replay tests take forever to load
188         https://bugs.webkit.org/show_bug.cgi?id=94764
189
190         Reviewed by Adam Barth.
191
192         Don't load about:blank at the beginning. This appears to clog the DRT.
193
194         * Scripts/webkitpy/performance_tests/perftest.py:
195         (ReplayPerfTest.run_single):
196         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
197         (TestReplayPerfTest.test_run_single):
198         (TestReplayPerfTest.test_run_single_fails_when_output_has_error):
199
200 2012-08-23  Kenneth Russell  <kbr@google.com>
201
202         Unreviewed, rolling out r126497.
203         http://trac.webkit.org/changeset/126497
204         https://bugs.webkit.org/show_bug.cgi?id=94764
205
206         Caused webkitpy-test step to start failing.
207
208         * Scripts/webkitpy/performance_tests/perftest.py:
209         (ReplayPerfTest.run_single):
210
211 2012-08-23  Emil A Eklund  <eae@chromium.org>
212
213         Add saturation arithmetic support to FractionalLayoutUnit
214         https://bugs.webkit.org/show_bug.cgi?id=94364
215
216         Reviewed by Benjamin Poulain.
217
218         Add test for new saturatedArithmetic functions.
219
220         * TestWebKitAPI/CMakeLists.txt:
221         * TestWebKitAPI/GNUmakefile.am:
222         * TestWebKitAPI/TestWebKitAPI.gypi:
223         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
224         * TestWebKitAPI/Tests/WTF/SaturatedArithmeticOperations.cpp: Added.
225         (TestWebKitAPI):
226         (TestWebKitAPI::TEST):
227         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
228
229 2012-08-23  Ryosuke Niwa  <rniwa@webkit.org>
230
231         Replay tests take forever to load
232         https://bugs.webkit.org/show_bug.cgi?id=94764
233
234         Reviewed by Adam Barth.
235
236         Don't load about:blank at the beginning. This appears to clog the DRT.
237
238         * Scripts/webkitpy/performance_tests/perftest.py:
239         (ReplayPerfTest.run_single):
240
241 2012-08-23  Wei Jia  <wjia@chromium.org>
242
243         create different WebKit::WebMediaPlayer based on URL
244         https://bugs.webkit.org/show_bug.cgi?id=91301
245
246         Reviewed by Adam Barth.
247
248         Pass URL to createMediaPlayer. This corresponds to change in base
249         class WebKit::WebFrameClient.
250
251         * DumpRenderTree/chromium/WebViewHost.cpp:
252         (WebViewHost::createMediaPlayer): add URL as additional argument.
253         * DumpRenderTree/chromium/WebViewHost.h:
254         (WebViewHost):
255
256 2012-08-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
257
258         Unreviewed, upgrade gyuyoung to reviewer.
259         http://lists.webkit.org/pipermail/webkit-dev/2012-August/022004.html
260
261         * Scripts/webkitpy/common/config/committers.py:
262
263 2012-08-23  Carlos Garcia Campos  <cgarcia@igalia.com>
264
265         REGRESSION(r126306): it broke the plugin process
266         https://bugs.webkit.org/show_bug.cgi?id=94797
267
268         Reviewed by Xan Lopez.
269
270         * GNUmakefile.am:
271
272 2012-08-23  Ryuan Choi  <ryuan.choi@samsung.com>
273
274         [EFL] Add url bar to EWebLauncher and MiniBrowser/Efl.
275         https://bugs.webkit.org/show_bug.cgi?id=63966
276
277         Reviewed by Kenneth Rohde Christiansen.
278
279         EWebLauncher and MiniBrowser/Efl did not have functionality that users
280         navigates the site which they want.
281         This patch adds the urlbar and functionality to load url which users want.
282
283         * CMakeLists.txt:
284         Added to share urlbar theme for both EWebLauncher and MiniBrowser/Efl.
285         * EWebLauncher/CMakeLists.txt:
286         Added urlbar.c and dependency of urlbar theme.
287         In addition, changed macro name to THEME_DIR to share the code easily.
288         * EWebLauncher/ControlTheme/CMakeLists.txt: Added for urlbar theme.
289         * EWebLauncher/ControlTheme/entry.edc: Implemented urlbar theme.
290         * EWebLauncher/main.c:
291         Implemented to use the urlbar.
292         In addition, remove unnecessary border of webview to control webview and urlbar easily.
293         (_ELauncher):
294         (on_url_changed):
295         (browserCreate):
296         (closeWindow):
297         (findThemePath):
298         * EWebLauncher/url_bar.c: Implemented functionality of the urlbar.
299         (_url_bar_url_get_with_protocol):
300         (on_urlbar_key_down):
301         (on_urlbar_mouse_down):
302         (on_urlbar_focus_out):
303         (url_bar_add):
304         (url_bar_del):
305         (url_bar_url_set):
306         * EWebLauncher/url_bar.h: Added.
307         * MiniBrowser/efl/CMakeLists.txt:
308         * MiniBrowser/efl/main.c: Implemented to use the urlbar.
309         (_MiniBrowser):
310         (on_url_changed):
311         (browserCreate):
312
313 2012-08-23  Balazs Kelemen  <kbalazs@webkit.org>
314
315         [nrwt, WTR] Remove workaround for timeout handing from r126062
316         https://bugs.webkit.org/show_bug.cgi?id=94609
317
318         Reviewed by Dirk Pranke.
319
320         Don't try to reset state if a timeout occured but inform
321         the harness that the web process is no longer reliable.
322
323         * Scripts/webkitpy/layout_tests/port/driver.py:
324         (Driver.run_test): Remove the workaround. Furthermore, handle the case when
325         the pid is unknown.
326         * WebKitTestRunner/TestController.cpp:
327         (WTR::TestController::run):
328         * WebKitTestRunner/TestInvocation.cpp:
329         (WTR::TestInvocation::invoke):
330         (WTR::TestInvocation::dumpWebProcessUnresponsiveness):
331         * WebKitTestRunner/TestInvocation.h:
332         (TestInvocation):
333
334 2012-08-23  Ádám Kallai  <kadam@inf.u-szeged.hu>
335
336         Unreviewed. Adding myself to committers list.
337
338         * Scripts/webkitpy/common/config/committers.py:
339
340 2012-08-22  Alexis Menard  <alexis@webkit.org>
341
342         Unreviewed update of my email.
343
344         * Scripts/webkitpy/common/config/committers.py:
345         * Scripts/webkitpy/common/config/watchlist:
346
347 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
348
349         Fix typos in r126374
350         https://bugs.webkit.org/show_bug.cgi?id=94665
351         Unreviewed, build fix.
352
353         Fix two issues that snuck in, one that caused a crash if there
354         were no baselines to optimize and one that occurred as a result
355         of failing to rename a variable when I changed the recursion to
356         a loop in the previous patch.
357
358         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
359         (BaselineOptimizer._optimize_by_pushing_results_up):
360
361 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
362
363         Baseline optimizer should try to optimize per-port if global optimization fails
364         https://bugs.webkit.org/show_bug.cgi?id=94665
365
366         Reviewed by Adam Barth.
367
368         Add a fallback strategy for optimizing baselines if the default
369         one fails; this one simply attempts to shift baselines up in the
370         tree and consolidates them if a parent and child in the fallback
371         path have the same result. This strategy is somewhat flawed in
372         that we will always put something in a parent dir even if we
373         "shouldn't"; for example, if chromium-mac produces a different
374         result from chromium-win and chromium-linux, then the new
375         algorithm will move the mac result into platform/chromium,
376         leaving chromium-mac empty. This result is still correct, but
377         perhaps confusing.
378
379         I haven't done much testing of this algorithm yet, so it's not
380         clear how many cases where this does a better job than the
381         default algorithm and how many it'll do a worse job.
382
383         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
384         (BaselineOptimizer._find_optimal_result_placement):
385         (BaselineOptimizer._optimize_by_most_specific_common_directory):
386         (BaselineOptimizer):
387         (BaselineOptimizer._optimize_by_pushing_results_up):
388         (BaselineOptimizer._find_in_fallbackpath):
389         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
390         (BaselineOptimizerTest.test_platform_mac_different):
391
392 2012-08-22  Dirk Pranke  <dpranke@chromium.org>
393
394         add debug info, another test to webkit-patch optimize-baselines
395         https://bugs.webkit.org/show_bug.cgi?id=94762
396
397         Reviewed by Adam Barth.
398
399         This patch adds more debug logging for optimize-baselines so
400         that you can tell the before and after states and figure out
401         what the command is actually deciding to do.
402
403         Also, this command adds a (disabled) test for the problem in bug
404         94665. It's disabled because we don't have the fix yet (that
405         will be posted in a patch to that bug).
406
407         There should be no functional changes in this patch apart from
408         the additional logging.
409
410         Note that adding the debug logging exposed a bug in
411         filesystem_mock.relpath() (that would return None if the path
412         wasn't a subpath of the start); the real relpath computes a
413         relpath with parent dirs. Fixing this revealed a bad check in
414         the style checker's change_directory() call which was checking
415         for None.
416
417         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
418         (BaselineOptimizer._find_optimal_result_placement):
419         (BaselineOptimizer):
420         (BaselineOptimizer._optimize_by_most_specific_common_directory):
421         (BaselineOptimizer._move_baselines):
422         (BaselineOptimizer.optimize):
423         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
424         (BaselineOptimizerTest.disabled_test_platform_mac_different):
425         * Scripts/webkitpy/common/system/filesystem.py:
426         (FileSystem):
427         * Scripts/webkitpy/common/system/filesystem_mock.py:
428         (MockFileSystem):
429         (MockFileSystem.__init__):
430         (MockFileSystem.relpath):
431         * Scripts/webkitpy/common/system/filesystem_unittest.py:
432         (RealFileSystemTest.test_sep):
433         * Scripts/webkitpy/style/main.py:
434         (change_directory):
435
436 2012-08-22  Alejandro Piñeiro  <apinheiro@igalia.com>
437
438         Dojo toggle buttons should expose ROLE_TOGGLE_BUTTON not ROLE_PUSH_BUTTON
439         https://bugs.webkit.org/show_bug.cgi?id=73819
440
441         Reviewed by Chris Fleizach.
442
443         Added a new role, Toggle Button, based on whether aria-pressed is present.
444         http://www.w3.org/TR/wai-aria/states_and_properties#aria-pressed
445
446         * DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:
447         (roleToString): added "ToggleButton" string for WebAccessibilityRoleToggleButton
448
449 2012-08-23  Victor Carbune  <victor@rosedu.org>
450
451         Add myself to the committer list
452         https://bugs.webkit.org/show_bug.cgi?id=94659
453
454         Reviewed by James Robinson.
455
456         Added my email and IRC handle.
457
458         * Scripts/webkitpy/common/config/committers.py:
459
460 2012-08-22  Scott Graham  <scottmg@chromium.org>
461
462         Don't unconditionally define NOMINMAX on Windows
463         https://bugs.webkit.org/show_bug.cgi?id=94742
464
465         Reviewed by Adrienne Walker.
466
467         Avoids a warning when building on Windows when NOMINMAX is defined
468         elsewhere or on the command line.
469
470         * TestWebKitAPI/config.h:
471
472 2012-08-22  Zan Dobersek  <zandobersek@gmail.com>
473
474         REGRESSION(r126189): Reftest mismatches are (again) run through ImageDiff with 0.1 tolerance
475         https://bugs.webkit.org/show_bug.cgi?id=94704
476
477         Reviewed by Dirk Pranke.
478
479         Use tolerance=0 when acquiring diff image of reftest output.
480
481         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
482         (SingleTestRunner._compare_output_with_reference):
483
484 2012-08-22  Tommy Widenflycht  <tommyw@google.com>
485
486         [chromium] MediaStream API: Add MockWebRTCPeerConnectionHandler
487         https://bugs.webkit.org/show_bug.cgi?id=93091
488
489         Reviewed by Adam Barth.
490
491         Add a skeleton MockWebRTCPeerConnectionHandler to DumpRenderTree,
492         to complete the infrastructure for RTCPeerConnection.
493
494         * DumpRenderTree/DumpRenderTree.gypi:
495         * DumpRenderTree/chromium/MockWebKitPlatformSupport.cpp:
496         (MockWebKitPlatformSupport::createRTCPeerConnectionHandler):
497         * DumpRenderTree/chromium/MockWebKitPlatformSupport.h:
498         (MockWebKitPlatformSupport):
499         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
500         * DumpRenderTree/chromium/MockWebMediaStreamCenter.h:
501         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
502         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
503         (MockWebRTCPeerConnectionHandler::initialize):
504         * DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.h: Copied from Tools/DumpRenderTree/chromium/MockWebKitPlatformSupport.h.
505         (WebKit):
506         (MockWebRTCPeerConnectionHandler):
507         (MockWebRTCPeerConnectionHandler::MockWebRTCPeerConnectionHandler):
508
509 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
510
511         Merge TestExpectationSerializer into TestExpectationLine
512         https://bugs.webkit.org/show_bug.cgi?id=94638
513
514         Reviewed by Dimitri Glazkov.
515
516         Moved all methods except, list_to_string which was moved to TestExpectations
517         from TestExpectationSerializer to TestExpectationLine and removed TestExpectationSerializer.
518
519         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
520         (TestExpectationEditorTests.assert_remove_roundtrip):
521         (TestExpectationEditorTests.assert_update_roundtrip):
522         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
523         (ParseError.__repr__):
524         (TestExpectationLine):
525         (TestExpectationLine.create_passing_expectation):
526         (TestExpectationLine.to_string): Moved from TestExpectationSerializer.
527         (TestExpectationLine.to_csv): Ditto.
528         (TestExpectationLine._serialize_parsed_expectations): Ditto.
529         (TestExpectationLine._serialize_parsed_modifiers): Ditto.
530         (TestExpectationLine._format_line):
531         (TestExpectations.remove_configuration_from_test):
532         (TestExpectations.remove_rebaselined_tests):
533         (TestExpectations.add_skipped_tests):
534         (TestExpectations):
535         (TestExpectations.list_to_string): Moved from TestExpectationSerializer.
536         (TestExpectations.list_to_string.serialize):
537         (TestExpectations.list_to_string.nones_out):
538         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
539         (TestExpectationSerializationTests): Renamed from TestExpectationSerializerTests.
540         (TestExpectationSerializationTests.__init__):
541         (TestExpectationSerializationTests.assert_round_trip):
542         (TestExpectationSerializationTests.assert_list_round_trip):
543         (TestExpectationSerializationTests.test_unparsed_to_string):
544         (TestExpectationSerializationTests.test_unparsed_list_to_string):
545         (TestExpectationSerializationTests.test_parsed_to_string):
546         (TestExpectationSerializationTests.test_serialize_parsed_expectations):
547         (TestExpectationSerializationTests.test_serialize_parsed_modifier_string):
548         (TestExpectationSerializationTests.test_format_line):
549         (TestExpectationSerializationTests.test_reconstitute_only_these):
550         * Scripts/webkitpy/tool/commands/expectations.py:
551         (OptimizeExpectations.execute):
552         * Scripts/webkitpy/tool/commands/queries.py:
553         (PrintExpectations.execute):
554         (PrintExpectations._format_lines):
555         * Scripts/webkitpy/tool/servers/gardeningserver.py:
556         (GardeningExpectationsUpdater.update_expectations):
557
558 2012-08-22  Alexandre Elias  <aelias@chromium.org>
559
560         Unreviewed, add aelias@chromium.org to committers
561
562         I (aelias@chromium.org) have been approved for commit access and Apple
563         has confirmed receipt of my committer agreement.
564
565         * Scripts/webkitpy/common/config/committers.py:
566
567 2012-08-22  Alexey Proskuryakov  <ap@apple.com>
568
569         [WK2] Support posting injected bundle messages to a page
570         https://bugs.webkit.org/show_bug.cgi?id=94630
571
572         Reviewed by Sam Weinig.
573
574         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
575         * TestWebKitAPI/InjectedBundleController.cpp:
576         (TestWebKitAPI::InjectedBundleController::initialize):
577         (TestWebKitAPI::InjectedBundleController::didReceiveMessageToPage):
578         * TestWebKitAPI/InjectedBundleController.h:
579         * TestWebKitAPI/InjectedBundleTest.h:
580         (TestWebKitAPI::InjectedBundleTest::didReceiveMessageToPage):
581         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
582         (WTR::InjectedBundle::didReceiveMessage):
583         (WTR::InjectedBundle::didReceiveMessageToPage):
584         (WTR::InjectedBundle::initialize):
585         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
586         Updated for new client API call.
587
588 2012-08-22  Dominic Mazzoni  <dmazzoni@google.com>
589
590         REGRESSION (r125710): accessibility/accessibility-node-reparent.html, accessibility/accessibility-node-memory-management.html failing on GTK Linux
591         https://bugs.webkit.org/show_bug.cgi?id=94200
592
593         Reviewed by Chris Fleizach.
594
595         Adds reference counting for AtkObjects referenced by
596         AccessibilityUIElementGtk. This prevents bogus results and
597         assertion failures on AccessibilityUIElements whose underlying
598         object has been deleted (as opposed to just made defunct).
599
600         This fixes two tests that were previously failing because of this bug.
601
602         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
603         (AccessibilityUIElement::AccessibilityUIElement):
604         (AccessibilityUIElement::~AccessibilityUIElement):
605
606 2012-08-22  Gustavo Noronha Silva  <gns@gnome.org>
607
608         [GTK] Split WebCore/platform into a separate library
609         https://bugs.webkit.org/show_bug.cgi?id=94435
610
611         Reviewed by Martin Robinson.
612
613         More people have been reporting problems when linking WebCore because
614         the command line limit is being exceeded. Splitting WebCore a bit more
615         is in order.
616
617         * GNUmakefile.am: link libWebCorePlatform into DRT
618
619 2012-08-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
620
621         Unreviewed buildfix for Qt-minimal after r126291
622
623         Disable smooth scrolling when request-animation-frame has been disabled either
624         explicitly or as part of --minimal.
625
626         * qmake/mkspecs/features/features.prf:
627
628 2012-08-22  Allan Sandfeld Jensen  <allan.jensen@nokia.com>
629
630         [Qt] Optionally support smooth-scrolling on all platforms
631         https://bugs.webkit.org/show_bug.cgi?id=74926
632
633         Reviewed by Simon Hausmann.
634
635         Enabled SMOOTH_SCROLLING on Qt, and expose the enable scroll animator
636         setting in QtTestBrowser so it can be tested.
637
638         * QtTestBrowser/launcherwindow.cpp:
639         (LauncherWindow::createChrome):
640         (LauncherWindow::toggleScrollAnimator):
641         * QtTestBrowser/launcherwindow.h:
642         (WindowOptions::WindowOptions):
643         (WindowOptions):
644         (LauncherWindow):
645         * qmake/mkspecs/features/features.pri:
646
647 2012-08-22  Dominik Röttsches  <dominik.rottsches@intel.com>
648
649         Unreviewed, adding myself to committers.py.
650
651         * Scripts/webkitpy/common/config/committers.py:
652
653 2012-08-21  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
654
655         [GTK] contextClick and getMenuItemTitle callbacks are leaky in DRT's EventSender
656         https://bugs.webkit.org/show_bug.cgi?id=94669
657
658         Reviewed by Carlos Garcia Campos.
659
660         Fix memory leaks in DRT's EventSender code.
661
662         * DumpRenderTree/gtk/EventSender.cpp:
663         (getMenuItemTitleCallback): Use JSRetainPtr and don't leak.
664         (contextClickCallback): Use GOwnPtr to manage memory of a
665         newly-allocated list automatically.
666
667 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
668
669         Add mountain lion to perf-tests, layout tests
670         https://bugs.webkit.org/show_bug.cgi?id=94553
671
672         Reviewed by Adam Barth.
673
674         This patch adds support for the 'mac-mountainlion' platform and
675         stamps out the last references to 'mac-leopard' as a supported
676         name.
677         
678         This patch does a small amount of refactoring to try and make
679         things a little clearer how we treat the "most recent version"
680         specially for baselines and skipped files, and so you only
681         should have to touch the VERSION_FALLBACK_ORDER constants on the
682         ports, but unfortunately changing this list changes a bunch of
683         the unit tests which are doing exact matches for correctness, so
684         you have to touch more than a couple files :(. There's probably
685         still more refactoring that can be done so that we don't have to
686         do all of this functional testing to feel completely correct.
687
688         * Scripts/webkitpy/common/system/platforminfo.py:
689         (PlatformInfo._determine_mac_version):
690         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
691         (TestPlatformInfo.test_os_version):
692         * Scripts/webkitpy/layout_tests/port/apple.py:
693         (ApplePort.__init__):
694         (ApplePort):
695         (ApplePort._skipped_file_search_paths):
696         (ApplePort._generate_all_test_configurations):
697         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
698         (ChromiumMacPort):
699         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
700         (FactoryTest.test_mac):
701         * Scripts/webkitpy/layout_tests/port/mac.py:
702         (MacPort):
703         (MacPort._build_driver_flags):
704         (MacPort.should_retry_crashes):
705         (MacPort.default_baseline_search_path):
706         (MacPort.operating_system):
707         (MacPort.default_child_processes):
708         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
709         (MacTest):
710         (MacTest.test_skipped_file_search_paths):
711         (test_versions):
712         (test_baseline_search_path):
713         * Scripts/webkitpy/layout_tests/port/win.py:
714         (WinPort):
715         (WinPort.default_baseline_search_path):
716
717 2012-08-21  Zan Dobersek  <zandobersek@gmail.com>
718
719         [GTK] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html is failing
720         https://bugs.webkit.org/show_bug.cgi?id=94617
721
722         Reviewed by Martin Robinson.
723
724         Set the 'enable-file-access-from-file-uris' setting to true when
725         resetting default values. The other ports do this as well, giving
726         documents with local security origin permission to load other
727         local resources.
728
729         * DumpRenderTree/gtk/DumpRenderTree.cpp:
730         (resetDefaultsToConsistentValues):
731
732 2012-08-21  Kent Tamura  <tkent@chromium.org>
733
734         [Chromium] DRT produces wrong back-forward list
735         https://bugs.webkit.org/show_bug.cgi?id=94575
736
737         Reviewed by Adam Barth.
738
739         DRT clears its history state before running every tests. However
740         HistoryController in WebCore isn't reset. So, it is possible that
741         'isNewNavigation' flag is false even though the navigation should be
742         handled as "new" for DRT.
743
744         This change might fix a problem of
745         fast/forms/select/select-state-restore.html (Bug 90207).
746
747         * DumpRenderTree/chromium/WebViewHost.cpp:
748         (WebViewHost::updateForCommittedLoad):
749         Treat the first page load (m_pageID == -1) as new navigation except for about:blank.
750         Without this change, a navigation entry for this loading won't be recorded.
751
752 2012-08-21  Thiago Marcos P. Santos  <thiago.santos@intel.com>
753
754         [EFL] Enable CSS Text Decoration by default
755         https://bugs.webkit.org/show_bug.cgi?id=94483
756
757         Reviewed by Kenneth Rohde Christiansen.
758
759         * Scripts/webkitperl/FeatureList.pm:
760
761 2012-08-21  Benjamin Poulain  <bpoulain@apple.com>
762
763         Store CString data in the CStringBuffer to avoid the double indirection
764         https://bugs.webkit.org/show_bug.cgi?id=94562
765
766         Reviewed by Darin Adler.
767
768         Add test coverage for WTF::CString.
769
770         * TestWebKitAPI/CMakeLists.txt:
771         * TestWebKitAPI/GNUmakefile.am:
772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
773         * TestWebKitAPI/Tests/WTF/CString.cpp:
774
775 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
776
777         Text Autosizing: ::first-letter pseudo-element is incorrectly sized
778         https://bugs.webkit.org/show_bug.cgi?id=94540
779
780         Reviewed by Ojan Vafai.
781
782         Revert the changes in bugs 94517 and 94396 so that we are
783         actually looking for stderr output from ImageDiff and doing
784         image compares on ref tests on the wk2 ports again.
785
786         Also, do an actual diff_image() call if the hash checks fail on
787         reftests, and only fail the test if we get real diffs (or don't,
788         for mismatches).
789
790         Lastly, clean up the log messages to be more helpful.
791
792         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
793         (SingleTestRunner._compare_image):
794         (SingleTestRunner._compare_output_with_reference):
795         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
796         (write_test_result):
797
798 2012-08-21  Dirk Pranke  <dpranke@chromium.org>
799
800         _compare_image() swaps actual and expected images by mistake
801         https://bugs.webkit.org/show_bug.cgi?id=94567
802
803         Reviewed by Ojan Vafai.
804
805         Re-work the code so that we consistently pass (expected, actual)
806         across all of the compare/diff routines.
807
808         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
809         (SingleTestRunner._run_compare_test):
810         (SingleTestRunner._compare_output):
811         (SingleTestRunner._compare_text):
812         (SingleTestRunner._compare_audio):
813         (SingleTestRunner._compare_image):
814         (SingleTestRunner._run_reftest):
815         (SingleTestRunner._compare_output_with_reference):
816         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
817         (write_test_result):
818
819 2012-08-21  Adam Barth  <abarth@webkit.org>
820
821         Unreviewed. Move the commit-queue to building release only. Previously,
822         we built debug too, but for some reason the debug build doesn't work on
823         the bots. We can re-enable debug builds once we fix the underlying
824         problem.
825
826         * Scripts/webkitpy/tool/commands/queues.py:
827         (CommitQueue.build_style):
828         * Scripts/webkitpy/tool/commands/queues_unittest.py:
829
830 2012-08-21  Ryosuke Niwa  <rniwa@webkit.org>
831
832         TestExpectationsParser doesn't warn about test files that don't exist.
833         https://bugs.webkit.org/show_bug.cgi?id=94632
834
835         Reviewed by Dirk Pranke.
836
837         Exit early and warn when the test file doesn't exist as well when a test directory doesn't exist.
838
839         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
840         (TestExpectationParser._parse_line):
841         (TestExpectationParser._check_test_exists):
842         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
843         (test_parse_warning):
844
845 2012-08-20  Ryosuke Niwa  <rniwa@webkit.org>
846
847         Move free functions in test_expectations to TestExpectations class
848         https://bugs.webkit.org/show_bug.cgi?id=94557
849
850         Reviewed by Dirk Pranke.
851
852         Moved test_result_was_expected, test_remove_pixel_failures, and test_suffixes_for_expectations into TestExpectations
853         to allow further refactoring.
854
855         * Scripts/webkitpy/common/net/resultsjsonparser.py:
856         (JSONTestResult.did_run_as_expected):
857         (JSONTestResult._tokenize):
858         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
859         (TestExpectations):
860         (TestExpectations.result_was_expected):
861         (TestExpectations.remove_pixel_failures):
862         (TestExpectations.has_pixel_failures):
863         (TestExpectations.suffixes_for_expectations):
864         (TestExpectations.matches_an_expected_result):
865         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
866         (MockBugManager.create_bug):
867         (test_result_was_expected):
868         (test_remove_pixel_failures):
869         (test_suffixes_for_expectations):
870         * Scripts/webkitpy/tool/commands/rebaseline.py:
871         (RebaselineExpectations._tests_to_rebaseline):
872
873 2012-08-21  Simon Hausmann  <simon.hausmann@nokia.com>
874
875         Unreviewed build fix for newer Qt 5: The meaning of private_includes changed to be fully
876         self-contained. The module name is not appended automatically anymore.
877
878         * qmake/qt_webkit.pri:
879
880 2012-08-20  Xianzhu Wang  <wangxianzhu@chromium.org>
881
882         [Chromium-Android] Add stop_when_done parameter to ChromiumAndroidDriver.run_test()
883         https://bugs.webkit.org/show_bug.cgi?id=94558
884
885         Reviewed by Dirk Pranke.
886
887         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
888         (ChromiumAndroidDriver.run_test):
889
890 2012-08-20  Ryosuke Niwa  <rniwa@webkit.org>
891
892         Cleanup TestExpectationParser.parse
893         https://bugs.webkit.org/show_bug.cgi?id=94545
894
895         Reviewed by Dirk Pranke.
896
897         Refactor TestExpectations to simplify the code.
898
899         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
900         (TestExpectationParser.parse): Merged _tokenize_list.
901         (TestExpectationParser._parse_line): Removed the call to _check_modifiers_against_expectations
902         since the check is now done in _parser_modifiers.
903         (TestExpectationParser._parse_modifiers): Merged _check_modifiers_against_expectations.
904         (TestExpectationParser._tokenize_line): Renamed from _tokenize.
905         (TestExpectationParser._split_space_separated): No longer calls lower() on all modifiers.
906         This is done on a local variable in _parse_modifiers, preserving the original case.
907         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier): Check the existence
908         of 'rebaseline' against parsed modifiers.
909         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
910         (TestExpectationParserTests._tokenize):
911         (TestExpectationParserTests.test_tokenize_valid_with_comment): Preserves case.
912         (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers): Ditto.
913         (TestExpectationSerializerTests._tokenize):
914         (TestExpectationSerializerTests.assert_list_round_trip): Call parse since _tokenize_list has
915         been merged into parse.
916         * Scripts/webkitpy/tool/commands/queries_unittest.py:
917         (PrintExpectationsTest.test_csv): Preserves the case.
918
919 2012-08-20  Gustavo Noronha Silva  <gns@gnome.org>
920
921         [jhbuild] EFL now runs jhbuild update for every build
922         https://bugs.webkit.org/show_bug.cgi?id=94267
923
924         Reviewed by Martin Robinson.
925
926         Try to fix WinCE build by returning the empty string instead of
927         env when no jhbuild infrastructure is found.
928
929         * Scripts/webkitdirs.pm:
930         (jhbuildWrapperPrefixIfNeeded):
931
932 2012-08-20  Benjamin Poulain  <benjamin@webkit.org>
933
934         Add a watcher for WTF changes
935
936         Unreviewed.
937
938         Add myself as a watcher for changes in WTF.
939
940         * Scripts/webkitpy/common/config/watchlist:
941
942 2012-08-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
943
944         [EFL] Move jhbuild dependencies based on SVN to tarballs
945         https://bugs.webkit.org/show_bug.cgi?id=90374
946
947         Reviewed by Kenneth Rohde Christiansen.
948
949         Moved all the dependencies based on SVN to tarballs taken from a
950         equivalent snapshot from the official git mirror. This will make
951         update-webkitefl not dependent on network connection after the first
952         run. The bots will not fail if EFL SVN server in unreachable.
953         The reason why git mirror is not used directly is to minimize the
954         total size of source code we need to download.
955
956         * efl/jhbuild.modules:
957
958 2012-08-20  Simon Fraser  <simon.fraser@apple.com>
959
960         Lots of "error, test and reference image have different properties" in pixel test output
961         https://bugs.webkit.org/show_bug.cgi?id=92578
962
963         Reviewed by Dirk Pranke.
964
965         Improve ImageDiff's error reporting when test result image and expected image
966         differ in their properties.
967
968         * DumpRenderTree/cg/ImageDiffCG.cpp:
969
970 2012-08-20  Nate Chapin  <japhet@chromium.org>
971
972         Unsafe vsprintf usage in TestNetscapePlugin
973         https://bugs.webkit.org/show_bug.cgi?id=94522
974
975         Reviewed by Adam Barth.
976
977         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
978         (pluginLogWithArguments): Using vsnprintf instead of vsprintf to ensure we don't overflow
979             the message buffer.
980         (testDocumentOpen):
981         (testWindowOpen):
982
983 2012-08-20  George Staikos  <staikos@webkit.org>
984
985         [BlackBerry] Enable XHR Response BLOB
986         https://bugs.webkit.org/show_bug.cgi?id=94525
987
988         Reviewed by Rob Buis.
989
990         Turn on the XHR response blob feature for the BlackBerry port.
991
992         * Scripts/webkitperl/FeatureList.pm: Add the feature and enable it.
993
994 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
995
996         Fix change for timeout detection to not crash if we have no output :)
997         https://bugs.webkit.org/show_bug.cgi?id=94505
998
999         Unreviewed, build fix.
1000
1001         * Scripts/webkitpy/layout_tests/port/driver.py:
1002         (Driver.run_test):
1003
1004 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
1005
1006         temporarily disable ImageDiff on WK2 ports for ref tests
1007         https://bugs.webkit.org/show_bug.cgi?id=94517
1008
1009         Reviewed by Brady Eidson.
1010
1011         ImageDiff appears to be unable to handle the pngs returned from
1012         WebKitTestRunner, so we disable checking images by default
1013         for ref tests on wk2 ports (unless pixel tests is explicitly enabled).
1014
1015         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1016         (SingleTestRunner._compare_output_with_reference):
1017
1018 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
1019
1020         Add missing FIXME: to previous change.
1021         https://bugs.webkit.org/show_bug.cgi?id=94505
1022
1023         Reviewed by Ojan Vafai.
1024
1025         * Scripts/webkitpy/layout_tests/port/driver.py:
1026         (Driver.run_test):
1027
1028 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
1029
1030         Intermittenly, many WebKit2 tests have results from the wrong test compared to the test just run, giving false failures.
1031         https://bugs.webkit.org/show_bug.cgi?id=94505
1032
1033         Reviewed by Ojan Vafai.
1034
1035         It looks like if the webprocess times out, WTR may tell NRWT
1036         that the test completed, but not properly reset its internal
1037         state, and then return stale output for subsequent tests.
1038
1039         This patch modifies NRWT temporarily to check for
1040         "Timed out waiting for final message from web process" in stdout
1041         and treat that as a timeout (and thus kill WTR); this seems
1042         to solve the cascade of failures, but of course there's probably
1043         still a bug in WTR that needs to be fixed.
1044
1045         * Scripts/webkitpy/layout_tests/port/driver.py:
1046         (Driver.run_test):
1047
1048 2012-08-20  Dirk Pranke  <dpranke@chromium.org>
1049
1050         NRWT reports unexpected EOF
1051         https://bugs.webkit.org/show_bug.cgi?id=94387
1052
1053         Reviewed by Adam Barth.
1054
1055         Stop logging "Unexpected EOF" when we are reading the last few
1056         bytes from stdout/stderr after stopping the subprocess.
1057
1058         * Scripts/webkitpy/layout_tests/port/server_process.py:
1059         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1060         (ServerProcess.stop):
1061
1062 2012-08-20  Brady Eidson  <beidson@apple.com>
1063
1064         Temporarily disable the 20+ crash and 500+ failure options on WK2 bots.
1065         https://bugs.webkit.org/show_bug.cgi?id=94506
1066
1067         Reviewed by Dirk Pranke.
1068
1069         When running WK2 tests, don't add the "abort early" command line options.
1070
1071         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1072         (ConfigureBuild.start):
1073         (RunWebKitTests):
1074         (RunWebKitTests.start):
1075         (RunWebKit2Tests.start):
1076
1077 2012-08-19  Stephanie Lewis  <slewis@apple.com>
1078
1079         Add mountain lion to build config.
1080         https://bugs.webkit.org/show_bug.cgi?id=94441
1081
1082         Reviewed by Adam Barth.
1083
1084         Add Mountain Lion to the build trigger configurations.
1085
1086         * Scripts/webkitpy/common/config/build.py:
1087         (_should_file_trigger_build):
1088         * Scripts/webkitpy/common/config/build_unittest.py:
1089         (ShouldBuildTest):
1090         (ShouldBuildTest.test_should_build):
1091
1092 2012-08-17  Kiran Muppala  <cmuppala@apple.com>
1093
1094         Add self to webkit contributors list
1095         https://bugs.webkit.org/show_bug.cgi?id=94409
1096
1097         Reviewed by Dirk Pranke.
1098
1099         Add name, email and irc handle to webkit contributors list.
1100
1101         * Scripts/webkitpy/common/config/committers.py:
1102
1103 2012-08-17  Ryosuke Niwa  <rniwa@webkit.org>
1104
1105         Perfalizer should differentiate results with and without the patch
1106         https://bugs.webkit.org/show_bug.cgi?id=94399
1107
1108         Reviewed by Dirk Pranke.
1109
1110         Add "with 12345" and "without 12345" descriptions in results JSON so that graphs in
1111         the results page are labled accordingly.
1112
1113         Also use _build_without_patch when building without a patch so that we get the right error message.
1114
1115         * Scripts/webkitpy/tool/commands/perfalizer.py:
1116         (PerfalizerTask.run):
1117         (PerfalizerTask._run_perf_test):
1118         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py:
1119         (PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
1120
1121 2012-08-17  Dirk Pranke  <dpranke@chromium.org>
1122
1123         nrwt: don't fail tests if ImageDiff fails on the wk2 ports
1124         https://bugs.webkit.org/show_bug.cgi?id=94396
1125
1126         Reviewed by Ryosuke Niwa.
1127
1128         It appears that WTR is generating PNGs that ImageDiff doesn't
1129         like, and so we're getting lots of "can not get ImageDiff"
1130         errors (see bug 81962). The change in r124581 made this a test
1131         failure, and this is causing the WK2 bots to frequently abort
1132         with 500+ failures. 
1133
1134         This change makes ImageDiff errors not be test failures just for
1135         WK2 for now until we can better triage what's going on.
1136
1137         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1138         (SingleTestRunner._compare_image):
1139
1140 2012-08-17  James Robinson  <jamesr@chromium.org>
1141
1142         [chromium] Add a style check for #include "cc/..." in chromium files
1143         https://bugs.webkit.org/show_bug.cgi?id=94382
1144
1145         Reviewed by Adam Barth.
1146
1147         Adds a style check to make sure new chromium code follows the correct convention for including cc files.
1148
1149         * Scripts/webkitpy/style/checkers/cpp.py:
1150         (check_include_line):
1151         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1152         (OrderOfIncludesTest.test_check_cc_includes):
1153
1154 2012-08-17  Ojan Vafai  <ojan@chromium.org>
1155
1156         Delete some dead code from the flakiness dashboard
1157         https://bugs.webkit.org/show_bug.cgi?id=94380
1158
1159         Reviewed by Dirk Pranke.
1160
1161         This code became dead in one of the refactors of how we handle BuilderGroups.
1162         There's no bug here, it's just dead code.
1163         * TestResultServer/static-dashboards/builders.js:
1164         (requestBuilderList):
1165         (loadBuildersList):
1166
1167 2012-08-17  Jochen Eisinger  <jochen@chromium.org>
1168
1169         [chromium] Add content shell bots to the flakiness dashboard
1170         https://bugs.webkit.org/show_bug.cgi?id=94369
1171
1172         Reviewed by Ojan Vafai.
1173
1174         The bots are named $OS (Content Shell).
1175
1176         * TestResultServer/static-dashboards/builders.js:
1177         (isChromiumWebkitTipOfTreeTestRunner):
1178         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1179
1180 2012-08-17  Shadi Khalek  <shadi@chromium.org>
1181
1182         Add AV perf layout tests to webkit flakiness dashboard
1183         https://bugs.webkit.org/show_bug.cgi?id=94255
1184
1185         Reviewed by Ojan Vafai.
1186
1187         Added missing mappings to LEGACY_BUILDER_MASTERS_TO_GROUPS.
1188         The isChromiumDepsAVTestRunner() filter does not work on current builder names. 
1189         It assumes the new names they are getting renamed to (AV Linux, AV Win7).
1190
1191         * TestResultServer/static-dashboards/builders.js:
1192         (isChromiumTipOfTreeAVTestRunner):
1193         (loadBuildersList):
1194
1195 2012-08-17  Milian Wolff  <milian.wolff@kdab.com>
1196
1197         [Qt] QtWebKit fails to build with OpenGL support on QNX
1198         https://bugs.webkit.org/show_bug.cgi?id=93278
1199
1200         Reviewed by Noam Rosenthal.
1201
1202         Change the order in which we define WTF_USE_3D_GRAPHICS and ENABLE_WEBGL.
1203         First, we now defined WTF_USE_3D_GRAPHICS=1, but only if QT_CONFIG
1204         contains opengl. Furthermore, we disable this feature on win32-* as usual,
1205         but now also disable it on QNX.
1206
1207         Then, we set ENABLE_WEBGL=1 but only if we previously set WTF_USE_3D_GRAPHICS=1.
1208
1209         * qmake/mkspecs/features/features.prf:
1210
1211 2012-08-16  Gustavo Noronha Silva  <gns@gnome.org>
1212
1213         [jhbuild] EFL now runs jhbuild update for every build
1214         https://bugs.webkit.org/show_bug.cgi?id=94267
1215
1216         Reviewed by Dirk Pranke.
1217
1218         This change makes EFL's approach to jhbuild more in line with the one
1219         used by WebKitGTK+. update-webkitefl-libs will only be called by build-
1220         webkit if --update-efl is given explicitly. The EWS bot will do that
1221         from now on.
1222
1223         * Scripts/webkitdirs.pm:
1224         (jhbuildWrapperPrefixIfNeeded): return jhbuild wrapper only if the
1225         Dependencies directory exists also for EFL
1226         (generateBuildSystemFromCMakeProject): no longer run update-webkitefl-libs
1227         (buildCMakeProjectOrExit): build update-webkitefl-libs if --update-efl is
1228         given
1229         * Scripts/webkitpy/common/config/ports.py:
1230         (EflPort.build_webkit_command): make EWS bots pass --update-efl to build-webkit
1231         * Scripts/webkitpy/common/config/ports_unittest.py:
1232         (DeprecatedPortTest.test_efl_port): add unit testing for EFL port
1233
1234 2012-08-16  Kent Tamura  <tkent@chromium.org>
1235
1236         Add forms-bugs@chromium.org as a contributor.
1237
1238         * Scripts/webkitpy/common/config/committers.py:
1239
1240 2012-08-16  Gustavo Noronha Silva  <gns@gnome.org>
1241
1242         Unreviewed warning fix, sys.argv is a python construct.
1243
1244         * Scripts/update-webkitefl-libs:
1245
1246 2012-08-16  Dirk Pranke  <dpranke@chromium.org>
1247
1248         NRWT cutting off the output from LayoutTest run under Valgrind
1249         https://bugs.webkit.org/show_bug.cgi?id=94011
1250
1251         Reviewed by Ojan Vafai.
1252
1253         Make NRWT work with valgrind again ... I needed to rework the
1254         driver infrastructure so that we could get the stderr written
1255         between a test completing and a process being stopped and
1256         associate it with the DriverOutput for the test; this meant that
1257         run_test() needed to stop the driver at the end of the test
1258         directly if/when appropriate. This also entailed reworking
1259         run_test() so that we would gather stderr and stdout
1260         consistently regardless of whether this was a normal test, or
1261         stop_when_done, or a crash or timeout.
1262
1263         Also, I had to rework the process_stop_time() (and renamed it to
1264         driver_stop_timeout) so that it would be longer if --time-out-ms
1265         was long as well (so that valgrind would get enough time to
1266         run), and I reworked driver.stop(kill_directly=True) to just
1267         driver.stop(timeout=0.0).
1268
1269         Lastly, adding the new stop_when_done parameter entailed
1270         touching a lot of test mock functions :(.
1271
1272         This change appeared to be well-covered by existing tests.
1273
1274         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1275         (Worker._run_test):
1276         (Worker._run_test_with_timeout):
1277         (Worker._run_test_in_another_thread):
1278         (Worker._run_test_in_another_thread.SingleTestThread.run):
1279         (Worker._run_test_in_this_thread):
1280         (Worker._run_single_test):
1281         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1282         (run_single_test):
1283         (SingleTestRunner.__init__):
1284         (SingleTestRunner._run_compare_test):
1285         (SingleTestRunner._run_rebaseline):
1286         (SingleTestRunner._run_reftest):
1287         * Scripts/webkitpy/layout_tests/port/base.py:
1288         (Port.driver_stop_timeout):
1289         (Port.variable.default_configuration):
1290         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1291         (ChromiumAndroidPort.driver_stop_timeout):
1292         (ChromiumAndroidDriver.stop):
1293         * Scripts/webkitpy/layout_tests/port/driver.py:
1294         (Driver.run_test):
1295         (Driver.stop):
1296         (DriverProxy.run_test):
1297         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1298         (DriverTest.test_check_for_driver_crash.FakeServerProcess.stop):
1299         * Scripts/webkitpy/layout_tests/port/server_process.py:
1300         (ServerProcess.write):
1301         (ServerProcess._wait_for_data_and_update_buffers_using_select):
1302         (ServerProcess.stop):
1303         (ServerProcess.kill):
1304         (ServerProcess):
1305         (ServerProcess._kill):
1306         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
1307         (TrivialMockPort.__init__):
1308         (MockProc.wait):
1309         (TestServerProcess.test_basic):
1310         * Scripts/webkitpy/layout_tests/port/test.py:
1311         (TestDriver.run_test):
1312         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1313         (get_tests_run.RecordingTestDriver.run_test):
1314         * Scripts/webkitpy/performance_tests/perftest.py:
1315         (PerfTest.run_single):
1316         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1317         (TestPageLoadingPerfTest.MockDriver.run_test):
1318         (TestReplayPerfTest.ReplayTestPort.__init__.ReplayTestDriver.run_test):
1319         (TestReplayPerfTest.test_run_single.run_test):
1320         (TestReplayPerfTest.test_run_single_fails_when_output_has_error.run_test):
1321         (TestReplayPerfTest.test_prepare.run_test):
1322         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1323         (MainTest.TestDriver.run_test):
1324
1325 2012-08-16  Roger Fong  <roger_fong@apple.com>
1326
1327         Typo in old-run-webkit-tests script from https://bugs.webkit.org/show_bug.cgi?id=93904.
1328         https://bugs.webkit.org/show_bug.cgi?id=94228
1329
1330         Reviewed by Tim Horton.
1331
1332         I previously made the change but made a typo that causes the script not ignore mismatch ref tests.
1333
1334         * Scripts/old-run-webkit-tests:
1335         (isUsedInReftest):
1336
1337 2012-08-16  Peter Beverloo  <peter@chromium.org>
1338
1339         [Chromium] Pass the --strip-binary argument to the apk test generator
1340         https://bugs.webkit.org/show_bug.cgi?id=94224
1341
1342         Reviewed by Adam Barth.
1343
1344         The native test generator currently relies on the $STRIP environment
1345         variable to be available, which it shouldn't do. Instead, pass it as an
1346         argument to the script. The $STRIP variable is being deprecated.
1347
1348         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1349         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1350
1351 2012-08-16  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1352
1353         [BlackBerry] Update format of JS console message to keep consistent with other ports.
1354         https://bugs.webkit.org/show_bug.cgi?id=94058
1355
1356         Reviewed by Yong Li.
1357         Reviewed internally by George Staikos.
1358
1359         1. Remove line number if it's zero.
1360         2. Print only file name for "file://" URL.
1361
1362         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1363         (BlackBerry::WebKit::DumpRenderTree::addMessageToConsole):
1364
1365 2012-08-16  Simon Hausmann  <simon.hausmann@nokia.com>
1366
1367         [Qt] Make DRT results more reliable on X11
1368
1369         Reviewed by Jocelyn Turcotte.
1370
1371         Disable desktop setting awareness, to prevent QApplication on X11 from reading palette settings from
1372         the running desktop environment.
1373
1374         * DumpRenderTree/qt/main.cpp:
1375         (main):
1376
1377 2012-08-16  Pierre Rossi  <pierre.rossi@gmail.com>
1378
1379         [Qt] Remove FontQt4, HAVE_QRAWFONT flag and the related dead code
1380         https://bugs.webkit.org/show_bug.cgi?id=93960
1381
1382         Reviewed by Simon Hausmann.
1383
1384         Following the removal of Qt 4 support from trunk in r124879.
1385
1386         * qmake/mkspecs/features/features.prf:
1387
1388 2012-08-16  Taiju Tsuiki  <tzik@chromium.org>
1389
1390         Add deleteFileSystem support to DumpRenderTree for chromium
1391         https://bugs.webkit.org/show_bug.cgi?id=94071
1392
1393         Reviewed by Kent Tamura.
1394
1395         * DumpRenderTree/chromium/WebViewHost.cpp:
1396         (WebViewHost::deleteFileSystem): Added
1397         * DumpRenderTree/chromium/WebViewHost.h:
1398         (WebViewHost):
1399
1400 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
1401
1402         Rename LayoutTestController to TestRunner in WebKitTestRunner
1403         https://bugs.webkit.org/show_bug.cgi?id=93942
1404
1405         Reviewed by Simon Fraser.
1406
1407         Renamed the class and relevant files.
1408
1409         * WebKitTestRunner/CMakeLists.txt:
1410         * WebKitTestRunner/DerivedSources.make:
1411         * WebKitTestRunner/GNUmakefile.am:
1412         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Removed.
1413         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Copied from Tools/WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl.
1414         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
1415         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1416         (WTR::InjectedBundle::didReceiveMessage):
1417         (WTR::InjectedBundle::beginTesting):
1418         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1419         (WTR::InjectedBundle::testRunner):
1420         (InjectedBundle):
1421         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1422         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: Removed.
1423         * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Removed.
1424         * WebKitTestRunner/InjectedBundle/Target.pri:
1425         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.cpp.
1426         * WebKitTestRunner/InjectedBundle/TestRunner.h: Copied from Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h.
1427         (TestRunner):
1428         * WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp: Removed.
1429         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/efl/LayoutTestControllerEfl.cpp.
1430         (WTR::waitToDumpWatchdogTimerCallback):
1431         (WTR::TestRunner::platformInitialize):
1432         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1433         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1434         (WTR::TestRunner::pathToLocalResource):
1435         (WTR::TestRunner::platformName):
1436         * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Removed.
1437         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp.
1438         (WTR::waitToDumpWatchdogTimerCallback):
1439         (WTR::TestRunner::platformInitialize):
1440         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1441         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1442         (WTR::TestRunner::pathToLocalResource):
1443         (WTR::TestRunner::platformName):
1444         * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm: Removed.
1445         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm: Copied from Tools/WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm.
1446         (WTR::TestRunner::platformInitialize):
1447         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1448         (WTR::waitUntilDoneWatchdogTimerFired):
1449         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1450         (WTR::TestRunner::pathToLocalResource):
1451         (WTR::TestRunner::platformName):
1452         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp: Removed.
1453         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp.
1454         (WTR::WatchdogTimerHelper::timerFired):
1455         (WTR::TestRunner::platformInitialize):
1456         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1457         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1458         (WTR::TestRunner::pathToLocalResource):
1459         (WTR::TestRunner::platformName):
1460         * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp: Removed.
1461         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp.
1462         (WTR::TestRunner::platformInitialize):
1463         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
1464         (WTR::waitToDumpWatchdogTimerFired):
1465         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
1466         (WTR::TestRunner::pathToLocalResource):
1467         (WTR::TestRunner::platformName):
1468         * WebKitTestRunner/PlatformEfl.cmake:
1469         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1470         * WebKitTestRunner/win/InjectedBundle.vcproj:
1471
1472 2012-08-15  Xianzhu Wang  <wangxianzhu@chromium.org>
1473
1474         [Chromium-Android] DumpRenderTree timeouts before NRWT timeouts
1475         https://bugs.webkit.org/show_bug.cgi?id=94155
1476
1477         Reviewed by Dirk Pranke.
1478
1479         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
1480         (ChromiumAndroidPort.create_driver): Force no_timeout=True
1481
1482 2012-08-15  Ryosuke Niwa  <rniwa@webkit.org>
1483
1484         Add a hyperlink to perf-o-matic from build.webkit.org/root.html
1485         https://bugs.webkit.org/show_bug.cgi?id=93749
1486
1487         Reviewed by Csaba Osztrogonác.
1488
1489         Added the hyperlink to webkit-perf.appspot.com. Also added hyperlinks to the waterfall display
1490         of performance tests.
1491
1492         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1493
1494 2012-08-15  Bruno de Oliveira Abinader  <bruno.abinader@basyskom.com>
1495
1496         [css3-text] Add CSS3 Text decoration compile flag
1497         https://bugs.webkit.org/show_bug.cgi?id=93863
1498
1499         Reviewed by Julien Chaffraix.
1500
1501         This patch handles the compile flag implementation, which will come disabled by
1502         default, thus not exposing the CSS3 text decoration features to the web, unless
1503         when explicitly enabling it with "--css3-text-decoration" build parameter.
1504
1505         * Scripts/webkitperl/FeatureList.pm:
1506         * qmake/mkspecs/features/features.pri:
1507
1508 2012-08-15  Beth Dakin  <bdakin@apple.com>
1509
1510         https://bugs.webkit.org/show_bug.cgi?id=93693
1511         [WK2] REGRESSION(125091): pixel results don't sow scrollbars 
1512         anymore
1513
1514         Reviewed by Sam Weinig.
1515
1516         Use new API WKBundlePageCreateSnapshotWithOptions().
1517         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1518         (WTR::InjectedBundlePage::dump):
1519
1520 2012-08-15  Alexey Proskuryakov  <ap@apple.com>
1521
1522         Add rfong to Bugzilla CC "contributor" list.
1523
1524         * Scripts/webkitpy/common/config/committers.py:
1525
1526 2012-08-15  Scott Graham  <scottmg@chromium.org>
1527
1528         Rename window.internals.fastMallocStatistics to mallocStatistics
1529         https://bugs.webkit.org/show_bug.cgi?id=94033
1530
1531         Reviewed by Adam Barth.
1532
1533         * GNUmakefile.am:
1534         * Scripts/webkitpy/performance_tests/perftest.py:
1535         (PerfTest):
1536         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1537         (test_run_memory_test):
1538
1539 2012-08-15  Peter Beverloo  <peter@chromium.org>
1540
1541         Fix a warning in TestWebKitAPI's MediaTime test-suite
1542         https://bugs.webkit.org/show_bug.cgi?id=94096
1543
1544         Reviewed by Adam Barth.
1545
1546         This warning is visible when building the file with certain GCC versions,
1547         including the one used by Chromium for Android. The warning is visible in
1548         the cr-android build bot output:
1549
1550         MediaTime.cpp:152: warning: this decimal constant is unsigned only in ISO C90
1551
1552         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1553         (TestWebKitAPI::TEST):
1554
1555 2012-08-15  Kevin Funk  <kevin.funk@kdab.com>
1556
1557         Fix the 'git log' call in VCSUtils.pm for Windows
1558         https://bugs.webkit.org/show_bug.cgi?id=94113
1559
1560         Reviewed by Kenneth Rohde Christiansen.
1561
1562         Failed because of invalid enquoting characters.
1563
1564         * Scripts/VCSUtils.pm:
1565
1566 2012-08-14  Gustavo Noronha Silva  <gns@gnome.org>
1567
1568         [jhbuild] move md5sum checking to update-webkit-libs-jhbuild
1569         https://bugs.webkit.org/show_bug.cgi?id=93208
1570
1571         Reviewed by Martin Robinson.
1572
1573         This change makes the md5sum check and saving be done by the script
1574         that performs the dependencies update. build-webkit no longer prefixes
1575         calls to commands with jhbuild-wrapper if jhbuild has not been
1576         bootstrapped by the developer and --update-gtk is not given.
1577
1578         * Scripts/update-webkit-libs-jhbuild:
1579         (getMD5HashForFile): moved from webkitdirs.
1580         (jhbuildConfigurationChanged): ditto.
1581         (saveJhbuildMd5): ditto.
1582         (cleanJhbuild): ditto, and changed to run jhbuild clean before removing
1583         jhbuild.
1584         * Scripts/webkitdirs.pm:
1585         (runAutogenForAutotoolsProjectIfNecessary): use jhbuildWrapperPrefixIfNeeded.
1586         (buildAutotoolsProject): ditto.
1587         (jhbuildWrapperPrefixIfNeeded): add a code branch for GTK+.
1588         (generateBuildSystemFromCMakeProject): call update-webkitefl-libs
1589         unconditionally for EFL.
1590         * jhbuild/jhbuild-wrapper:
1591         (update_webkit_libs_jhbuild): removed, jhbuild-wrapper no longer runs the
1592         update script itself
1593         (ensure_jhbuild): remove update call.
1594
1595 2012-08-15  Christophe Dumez  <christophe.dumez@intel.com>
1596
1597         [WK2] Add support for Web Intents MessagePorts
1598         https://bugs.webkit.org/show_bug.cgi?id=89072
1599
1600         Reviewed by Kenneth Rohde Christiansen.
1601
1602         Use WKBundleIntent instead of WebIntentData in
1603         WebKitTestRunner. WTR now prints the number of
1604         MessagePorts in received Web intents as
1605         expected by the following layout tests:
1606         webintents/web-intents-invoke-port.html
1607         webintents/web-intents-obj-constructor.html
1608
1609         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1610         (WTR::InjectedBundlePage::didReceiveIntentForFrame):
1611         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1612         (WTR::LayoutTestController::deliverWebIntent):
1613
1614 2012-08-14  Ryosuke Niwa  <rniwa@webkit.org>
1615
1616         Build fix after r125516. Revert the erroneous rename since we need to keep exposing
1617         layoutTestController in Chromium port as explained r124785.
1618
1619         * DumpRenderTree/chromium/TestShell.cpp:
1620         (TestShell::bindJSObjectsToWindow):
1621
1622 2012-08-14  Dan Bernstein  <mitz@apple.com>
1623
1624         fast/events/overflow-scroll-fake-mouse-move.html and fast/events/frame-scroll-fake-mouse-move.html are failing in WebKit1
1625         https://bugs.webkit.org/show_bug.cgi?id=94045
1626
1627         Reviewed by Geoff Garen.
1628
1629         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1630         (-[DumpRenderTreeWindow _hasKeyAppearance]): Added. Returns [self isKeyWindow]. This is
1631         needed now that WebView uses -_hasKeyAppearance instead of -isKeyWindow.
1632
1633 2012-08-14  Alexey Proskuryakov  <ap@apple.com>
1634
1635         [WK2] Fix some typos in MiniBrowser
1636         https://bugs.webkit.org/show_bug.cgi?id=94047
1637
1638         Reviewed by Jon Honeycutt.
1639
1640         * MiniBrowser/mac/AppDelegate.m:
1641         (didReceiveMessageFromInjectedBundle): (-[BrowserAppDelegate init]):
1642         * MiniBrowser/mac/WebBundle/WebBundleMain.m:
1643         (didReceiveMessage):
1644         (WKBundleInitialize):
1645
1646 2012-08-14  Roger Fong  <roger_fong@apple.com>
1647
1648         old-run-webkit-tests should skip all file extensions for ref tests, not just .html.
1649         https://bugs.webkit.org/show_bug.cgi?id=93904
1650
1651         Reviewed by Tim Horton.
1652
1653         old-run-webkit-tests ref test only skipped .html test.
1654         They need to skip .html, .shtml, .xml, .xhtml, .pl, .htm, .php, .svg, .mht.
1655         
1656         * Scripts/old-run-webkit-tests:
1657         (isUsedInReftest): Skip all extensions for ref tests.
1658
1659 2012-08-14  Lauro Neto  <lauro.neto@openbossa.org>
1660
1661         Convert signals/slots to Q_* macros.
1662
1663         [Qt] Use Q_SLOTS and Q_SIGNALS instead of slots and signals
1664         https://bugs.webkit.org/show_bug.cgi?id=93996
1665
1666         Reviewed by Kenneth Rohde Christiansen.
1667
1668         Change usage of keyword-conflicting 'signals' and 'slots' for
1669         Q_SIGNALS and Q_SLOTS macro.
1670
1671         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1672         (NetworkAccessManager):
1673         (WebPage):
1674         * DumpRenderTree/qt/EventSenderQt.h:
1675         (EventSender):
1676         * DumpRenderTree/qt/GCControllerQt.h:
1677         (GCController):
1678         * DumpRenderTree/qt/TestRunnerQt.h:
1679         (TestRunner):
1680         * DumpRenderTree/qt/TextInputControllerQt.h:
1681         (TextInputController):
1682         * MiniBrowser/qt/BrowserWindow.h:
1683         (BrowserWindow):
1684         * MiniBrowser/qt/MiniBrowserApplication.h:
1685         (WindowOptions):
1686         * MiniBrowser/qt/UrlLoader.h:
1687         (UrlLoader):
1688         * QtTestBrowser/cookiejar.h:
1689         (TestBrowserCookieJar):
1690         * QtTestBrowser/fpstimer.h:
1691         (FpsTimer):
1692         * QtTestBrowser/launcherwindow.h:
1693         (LauncherWindow):
1694         * QtTestBrowser/locationedit.h:
1695         (LocationEdit):
1696         * QtTestBrowser/mainwindow.h:
1697         (MainWindow):
1698         * QtTestBrowser/urlloader.h:
1699         (UrlLoader):
1700         * QtTestBrowser/webinspector.h:
1701         (WebInspector):
1702         * QtTestBrowser/webpage.h:
1703         (WebPage):
1704         * QtTestBrowser/webview.h:
1705         (WebViewGraphicsBased):
1706         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1707         (WatchdogTimerHelper):
1708         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1709         (WrapperWindow):
1710         * WebKitTestRunner/qt/main.cpp:
1711         (Launcher):
1712
1713 2012-08-14  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1714
1715         WebKitTestRunner needs layoutTestController.dumpResourceLoadCallbacks
1716         https://bugs.webkit.org/show_bug.cgi?id=42332
1717
1718         Reviewed by Kenneth Rohde Christiansen.
1719
1720         Added Resource Callbacks logging. Several aux dumping functions are added.
1721
1722         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
1723         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1724         (WTR::isFileScheme):
1725         (WTR):
1726         (WTR::pathSuitableForTestResult):
1727         (WTR::urlSuitableForTestResult):
1728         (WTR::InjectedBundlePage::resetAfterTest):
1729         (WTR::dumpRequestDescriptionSuitableForTestResult):
1730         (WTR::dumpResponseDescriptionSuitableForTestResult):
1731         (WTR::dumpErrorDescriptionSuitableForTestResult):
1732         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1733         (WTR::InjectedBundlePage::willSendRequestForFrame):
1734         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1735         (WTR::InjectedBundlePage::didFinishLoadForResource):
1736         (WTR::InjectedBundlePage::didFailLoadForResource):
1737         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1738         (WTR::LayoutTestController::LayoutTestController):
1739         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
1740         (WTR::LayoutTestController::dumpResourceLoadCallbacks):
1741         (WTR::LayoutTestController::shouldDumpResourceLoadCallbacks):
1742         (LayoutTestController):
1743
1744 2012-08-14  Alexis Menard  <alexis.menard@openbossa.org>
1745
1746         Update INdT build bot to Mountain Lion.
1747         https://bugs.webkit.org/show_bug.cgi?id=93963
1748
1749         Reviewed by Csaba Osztrogonác.
1750
1751         We updated the machine as well as the OS as the Qt port is now running
1752         on top of Qt5.
1753
1754         * BuildSlaveSupport/build.webkit.org-config/config.json:
1755
1756 2012-08-14  Peter Beverloo  <peter@chromium.org>
1757
1758         [Chromium] Remove unneeded build logic for Android
1759         https://bugs.webkit.org/show_bug.cgi?id=93962
1760
1761         Reviewed by Dimitri Glazkov.
1762
1763         The Android SDK and NDK have been checked in to the Chromium tree, which
1764         allows WebKit to leverage those as well. They will already be pulled in
1765         through a DEPS change made last week, and by not setting the ANDROID_NDK_ROOT
1766         environment variable, the envsetup.sh will set the project files up
1767         appropriately for us.
1768
1769         * Scripts/webkitdirs.pm:
1770
1771 2012-08-14  Sergio Villar Senin  <svillar@igalia.com>
1772
1773         [WK2] [GTK] Plugin tests failing in WK2 bot
1774         https://bugs.webkit.org/show_bug.cgi?id=93954
1775
1776         Reviewed by Carlos Garcia Campos.
1777
1778         Plugin tests are failing in the WK2 bot because we aren't exporting
1779         the Netscape plugin when creating the product archive.
1780
1781         * BuildSlaveSupport/built-product-archive: added TestNetscapePlugin
1782         to the list of directories to export.
1783         (archiveBuiltProduct):
1784
1785 2012-08-14  Peter Beverloo  <peter@chromium.org>
1786
1787         [Chromium] Fix apk generation for the Android platform
1788         https://bugs.webkit.org/show_bug.cgi?id=93841
1789
1790         Unreviewed build fix.
1791
1792         APK generation was broken as the configuration file assumed compilation
1793         would only occur in the Chromium tree. Pass the path to Chromium's source
1794         base directory as a property to ant.
1795
1796         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
1797         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
1798
1799 2012-08-14  Sergio Villar Senin  <svillar@igalia.com>
1800
1801         [GTK] REGRESSION (r122428) WebKit2APITests/TestWebKitFindController fails "next" test
1802         https://bugs.webkit.org/show_bug.cgi?id=91083
1803
1804         Reviewed by Carlos Garcia Campos.
1805
1806         Unskipped a couple of API tests that should work fine from now on.
1807
1808         * Scripts/run-gtk-tests:
1809         (TestRunner):
1810
1811 2012-08-14  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1812
1813         [NRWT] Compare results between different platforms
1814         https://bugs.webkit.org/show_bug.cgi?id=90555
1815
1816         Reviewed by Dirk Pranke.
1817
1818         * Scripts/webkitpy/layout_tests/port/base.py:
1819         (Port.baseline_search_path):
1820         (Port):
1821         (Port.compare_baseline):
1822         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1823         (parse_args):
1824
1825 2012-08-13  Ryosuke Niwa  <rniwa@webkit.org>
1826
1827         Rename LayoutTestController to TestRunner in DumpRenderTree
1828         https://bugs.webkit.org/show_bug.cgi?id=93758
1829
1830         Reviewed by Tony Chang.
1831
1832         Renamed LayoutTestController to TestRunner. For Chromium port, it's renamed to DRTTestRunner
1833         since it already has TestRunner class shared between DumpRenderTree and content_shell.
1834
1835         * DumpRenderTree/DumpRenderTree.h:
1836         * DumpRenderTree/PixelDumpSupport.cpp:
1837         * DumpRenderTree/StorageTrackerDelegate.h:
1838         * DumpRenderTree/StorageTrackerDelegate.mm:
1839         * DumpRenderTree/TestRunner.cpp:
1840         * DumpRenderTree/TestRunner.h:
1841         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1842         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
1843         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1844         * DumpRenderTree/chromium/DRTTestRunner.h:
1845         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1846         * DumpRenderTree/chromium/NotificationPresenter.h:
1847         * DumpRenderTree/chromium/TestShell.cpp:
1848         * DumpRenderTree/chromium/TestShell.h:
1849         * DumpRenderTree/chromium/WebPermissions.cpp:
1850         * DumpRenderTree/chromium/WebPermissions.h:
1851         * DumpRenderTree/chromium/WebViewHost.cpp:
1852         * DumpRenderTree/chromium/WebViewHost.h:
1853         * DumpRenderTree/efl/DumpRenderTree.cpp:
1854         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1855         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1856         * DumpRenderTree/efl/EditingCallbacks.cpp:
1857         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1858         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1859         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1860         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1861         * DumpRenderTree/mac/DumpRenderTree.mm:
1862         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1863         * DumpRenderTree/mac/EditingDelegate.mm:
1864         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1865         * DumpRenderTree/mac/HistoryDelegate.mm:
1866         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1867         * DumpRenderTree/mac/PolicyDelegate.h:
1868         * DumpRenderTree/mac/PolicyDelegate.mm:
1869         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1870         * DumpRenderTree/mac/TestRunnerMac.mm:
1871         * DumpRenderTree/mac/UIDelegate.mm:
1872         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1873         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1874         * DumpRenderTree/qt/TestRunnerQt.cpp:
1875         * DumpRenderTree/qt/TestRunnerQt.h:
1876         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1877         * DumpRenderTree/win/DumpRenderTree.cpp:
1878         * DumpRenderTree/win/EditingDelegate.cpp:
1879         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1880         * DumpRenderTree/win/HistoryDelegate.cpp:
1881         * DumpRenderTree/win/PolicyDelegate.h:
1882         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1883         * DumpRenderTree/win/TestRunnerWin.cpp:
1884         * DumpRenderTree/win/UIDelegate.cpp:
1885         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1886         * DumpRenderTree/wx/TestRunnerWx.cpp:
1887
1888 2012-08-14  Sudarsana Nagineni  <sudarsana.nagineni@linux.intel.com>
1889
1890         [GTK] String returned by g_path_get_dirname() must be freed
1891         https://bugs.webkit.org/show_bug.cgi?id=93885
1892
1893         Reviewed by Philippe Normand.
1894
1895         Fix a memory leak in GTK's DRT code.
1896
1897         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1898         (pathFromSoupURI): Free the string returned by g_path_get_dirname().
1899
1900 2012-08-14  Zan Dobersek  <zandobersek@gmail.com>
1901
1902         Unreviewed GTK build fix after r125508.
1903
1904         Do the renaming in GNUmakefile.am as well, LayoutTestController -> TestRunner.
1905
1906         * GNUmakefile.am:
1907
1908 2012-08-13  Ryosuke Niwa  <rniwa@webkit.org>
1909
1910         Rename files that declare and define LayoutTestController in DumpRenderTree
1911         https://bugs.webkit.org/show_bug.cgi?id=93899
1912
1913         Reviewed by Tony Chang.
1914
1915         Renamed files and fixed style errors.
1916
1917         * DumpRenderTree/DumpRenderTree.gypi:
1918         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1919         * DumpRenderTree/LayoutTestController.cpp: Removed.
1920         * DumpRenderTree/LayoutTestController.h: Removed.
1921         * DumpRenderTree/PixelDumpSupport.cpp:
1922         * DumpRenderTree/StorageTrackerDelegate.mm:
1923         * DumpRenderTree/TestRunner.cpp: Copied from Tools/DumpRenderTree/LayoutTestController.cpp.
1924         * DumpRenderTree/TestRunner.h: Copied from Tools/DumpRenderTree/LayoutTestController.h.
1925         (LayoutTestController):
1926         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1927         * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Removed.
1928         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Copied from Tools/DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp.
1929         * DumpRenderTree/chromium/DRTTestRunner.cpp: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.cpp.
1930         * DumpRenderTree/chromium/DRTTestRunner.h: Copied from Tools/DumpRenderTree/chromium/LayoutTestController.h.
1931         * DumpRenderTree/chromium/LayoutTestController.cpp: Removed.
1932         * DumpRenderTree/chromium/LayoutTestController.h: Removed.
1933         * DumpRenderTree/chromium/TestShell.cpp:
1934         * DumpRenderTree/chromium/TestShell.h:
1935         * DumpRenderTree/chromium/WebPermissions.cpp:
1936         * DumpRenderTree/chromium/WebViewHost.cpp:
1937         * DumpRenderTree/efl/CMakeLists.txt:
1938         * DumpRenderTree/efl/DumpRenderTree.cpp:
1939         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1940         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1941         * DumpRenderTree/efl/EditingCallbacks.cpp:
1942         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Removed.
1943         * DumpRenderTree/efl/TestRunnerEfl.cpp: Copied from Tools/DumpRenderTree/efl/LayoutTestControllerEfl.cpp.
1944         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1945         * DumpRenderTree/gtk/EditingCallbacks.cpp:
1946         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Removed.
1947         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Copied from Tools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp.
1948         * DumpRenderTree/mac/DumpRenderTree.mm:
1949         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
1950         * DumpRenderTree/mac/EditingDelegate.mm:
1951         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1952         * DumpRenderTree/mac/HistoryDelegate.mm:
1953         * DumpRenderTree/mac/LayoutTestControllerMac.mm: Removed.
1954         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1955         * DumpRenderTree/mac/PolicyDelegate.mm:
1956         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1957         * DumpRenderTree/mac/TestRunnerMac.mm: Copied from Tools/DumpRenderTree/mac/LayoutTestControllerMac.mm.
1958         * DumpRenderTree/mac/UIDelegate.mm:
1959         * DumpRenderTree/qt/DumpRenderTree.pro:
1960         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1961         * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Removed.
1962         * DumpRenderTree/qt/LayoutTestControllerQt.h: Removed.
1963         * DumpRenderTree/qt/TestRunnerQt.cpp: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.cpp.
1964         * DumpRenderTree/qt/TestRunnerQt.h: Copied from Tools/DumpRenderTree/qt/LayoutTestControllerQt.h.
1965         (WebCore):
1966         (LayoutTestController):
1967         (LayoutTestController::setCloseRemainingWindowsWhenComplete):
1968         (LayoutTestController::dumpSelectionRect):
1969         (LayoutTestController::setCallCloseOnWebViews):
1970         (LayoutTestController::addDisallowedURL):
1971         (LayoutTestController::abortModal):
1972         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
1973         * DumpRenderTree/win/DumpRenderTree.cpp:
1974         * DumpRenderTree/win/DumpRenderTree.vcproj:
1975         * DumpRenderTree/win/EditingDelegate.cpp:
1976         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1977         * DumpRenderTree/win/HistoryDelegate.cpp:
1978         * DumpRenderTree/win/LayoutTestControllerWin.cpp: Removed.
1979         * DumpRenderTree/win/PolicyDelegate.cpp:
1980         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1981         * DumpRenderTree/win/TestRunnerWin.cpp: Copied from Tools/DumpRenderTree/win/LayoutTestControllerWin.cpp.
1982         (LayoutTestController::setUserStyleSheetEnabled):
1983         (resolveCygwinPath):
1984         * DumpRenderTree/win/UIDelegate.cpp:
1985         * DumpRenderTree/wscript:
1986         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1987         * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Removed.
1988         * DumpRenderTree/wx/TestRunnerWx.cpp: Copied from Tools/DumpRenderTree/wx/LayoutTestControllerWx.cpp.
1989
1990 2012-08-13  Alex Christensen  <alex.christensen@flexsim.com>
1991
1992         Windows 64 bit compliance
1993         https://bugs.webkit.org/show_bug.cgi?id=93275
1994
1995         Reviewed by Brent Fulgham.
1996
1997         Fixed a few compile and link problems for Win64
1998
1999         * WinLauncher/WinLauncher.cpp:
2000         * win/DLLLauncher/DLLLauncherMain.cpp:
2001
2002 2012-08-13  MORITA Hajime  <morrita@google.com>
2003
2004         Unreviewed update for webcomponents-bugzilla address.
2005
2006         * Scripts/webkitpy/common/config/committers.py:
2007
2008 2012-08-11  Raphael Kubo da Costa  <rakuco@webkit.org>
2009
2010         [CMake] Rewrite FindLibSoup2.cmake.
2011         https://bugs.webkit.org/show_bug.cgi?id=93191
2012
2013         Reviewed by Rob Buis.
2014
2015         * DumpRenderTree/efl/CMakeLists.txt: Use LIBSOUP_FOO instead of
2016         LIBSOUP24_FOO, and do not use LIBSOUP24_LDFLAGS, as it is not
2017         needed anymore.
2018         * EWebLauncher/CMakeLists.txt: Ditto.
2019         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2020         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
2021         * WebKitTestRunner/CMakeLists.txt: Ditto.
2022         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
2023
2024 2012-08-13  Brady Eidson  <beidson@apple.com>
2025
2026         With asynchronous plug-in initialization, WebProcess and PluginProcess can deadlock
2027         <rdar://problem/12062125> and https://bugs.webkit.org/show_bug.cgi?id=93894
2028
2029         Reviewed by Alexey Proskuryakov.
2030
2031         Add a test that calls out to NPP_Evaluate for some JS inside of NPP_New.
2032
2033         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2034         * DumpRenderTree/TestNetscapePlugIn/Tests/EvaluateJSWithinNPP_New.cpp: Added.
2035         (EvaluteJSWithinNPP_New):
2036         (EvaluteJSWithinNPP_New::EvaluteJSWithinNPP_New):
2037         (EvaluteJSWithinNPP_New::NPP_New):
2038
2039 2012-08-13  Sheriff Bot  <webkit.review.bot@gmail.com>
2040
2041         Unreviewed, rolling out r125422.
2042         http://trac.webkit.org/changeset/125422
2043         https://bugs.webkit.org/show_bug.cgi?id=93902
2044
2045         Broke the Android canary build (Requested by fmalita on
2046         #webkit).
2047
2048         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2049         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2050
2051 2012-08-13  Raphael Kubo da Costa  <rakuco@webkit.org>
2052
2053         [CMake] Remove glib-related Find modules and write single new one instead.
2054         https://bugs.webkit.org/show_bug.cgi?id=93786
2055
2056         Reviewed by Rob Buis.
2057
2058         * DumpRenderTree/efl/CMakeLists.txt: Use GLIB_* instead of Glib_*.
2059         * EWebLauncher/CMakeLists.txt: Ditto.
2060         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2061         * WebKitTestRunner/PlatformEfl.cmake: Ditto.
2062
2063 2012-08-13  Peter Beverloo  <peter@chromium.org>
2064
2065         [Chromium] Fix apk generation for the Android platform
2066         https://bugs.webkit.org/show_bug.cgi?id=93841
2067
2068         Reviewed by Dimitri Glazkov.
2069
2070         APK generation was broken as the configuration file assumed compilation
2071         would only occur in the Chromium tree. Pass the path to Chromium's source
2072         base directory as a property to ant.
2073
2074         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2075         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
2076
2077 2012-08-13  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2078
2079         [WK2] [WTR] InjectedBundlePage::didFailLoadForResource invokes wrong callback
2080         https://bugs.webkit.org/show_bug.cgi?id=93825
2081
2082         Reviewed by Antonio Gomes.
2083
2084         Corrected from didFinishLoadForResource() invoke to didFailLoadForResource() invoke. 
2085
2086         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2087         (WTR::InjectedBundlePage::didFailLoadForResource):
2088
2089 2012-08-13  Kwang Yul Seo  <skyul@company100.net>
2090
2091         [Qt] Add gprof.prf to build WebKit with gprof enabled
2092         https://bugs.webkit.org/show_bug.cgi?id=90283
2093
2094         Reviewed by Eric Seidel.
2095
2096         * qmake/mkspecs/features/functions.prf:
2097         gprof does not support profiling a shared library.
2098         To profile WebKit, applications must link QtWebKit statically.
2099
2100         * qmake/mkspecs/features/gprof.prf: Added.
2101         Add -pg option to both QMAKE_CXXFLAGS and QMAKE_LFLAGS.
2102
2103 2012-08-13  KwangYong Choi  <ky0.choi@samsung.com>
2104
2105         [TestNetscapePlugin][X11] Additional key up event handler routine is required
2106         https://bugs.webkit.org/show_bug.cgi?id=91357
2107
2108         Reviewed by Eric Seidel.
2109
2110         Fixed key up event handler routine to pass http/tests/plugins/plugin-document-
2111         has-focus.html on X11 architecture. The test can not be done without this patch.
2112         All other ports implemented it already.
2113
2114         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
2115         (handleEventX11): Modified key up event handler for X11
2116
2117 2012-08-13  Christophe Dumez  <christophe.dumez@intel.com>
2118
2119         [EFL][WK2] Replace Skipped list by TestExpectations
2120         https://bugs.webkit.org/show_bug.cgi?id=93796
2121
2122         Reviewed by Kenneth Rohde Christiansen.
2123
2124         Enable cascaded TestExpectations for EFL port so
2125         that we can use TestExpectations in WK2-EFL.
2126
2127         * Scripts/webkitpy/layout_tests/port/efl.py:
2128         (EflPort._search_paths):
2129         (EflPort):
2130         (EflPort.expectations_files):
2131
2132 2012-08-13  Peter Gal  <galpeter@inf.u-szeged.hu>
2133
2134         REGRESSION(r125153): It broke the 'Unexpected no expected results' case
2135         https://bugs.webkit.org/show_bug.cgi?id=93789
2136
2137         Reviewed by Csaba Osztrogonác.
2138
2139         Fix the regex, so the text won't be a capturing group.
2140
2141         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2142         (RunWebKitTests._parseNewRunWebKitTestsOutput):
2143
2144 2012-08-12  MORITA Hajime  <morrita@google.com>
2145
2146         Unreviewed, added a proxy address to contributors_who_are_not_committers.
2147
2148         * Scripts/webkitpy/common/config/committers.py:
2149
2150 2012-08-12  Loïc Yhuel  <loic.yhuel@softathome.com>
2151
2152         [Qt] Make it possible to build without QtTest/QtPrintSupport
2153         https://bugs.webkit.org/show_bug.cgi?id=93492
2154
2155         Reviewed by Tor Arne Vestbø.
2156
2157         * DumpRenderTree/qt/DumpRenderTree.pro: Optional printsupport
2158         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2159         (WebCore):
2160         (WebCore::DumpRenderTree::dryRunPrint): Does nothing if no printsupport
2161         * QtTestBrowser/QtTestBrowser.pro: Optional printsupport
2162         * QtTestBrowser/launcherwindow.cpp:
2163         (LauncherWindow::createChrome): No print menu if no printsupport
2164         (LauncherWindow::print): Does nothing if no printsupport
2165         * QtTestBrowser/launcherwindow.h:
2166         * Tools.pro: Disable DRT/WTR if QtTest not present
2167         * qmake/mkspecs/features/default_pre.prf: printsupport no more mandatory
2168         * qmake/mkspecs/features/features.prf: Qt module availability tests
2169
2170 2012-08-12  Csaba Osztrogonác  <ossy@webkit.org>
2171
2172         master.cfg unittest cleanup: Show DeprecationWarnings with python >= 2.7 too
2173         https://bugs.webkit.org/show_bug.cgi?id=90161
2174
2175         Reviewed by Eric Seidel.
2176
2177         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2178
2179 2012-08-12  Simon Hausmann  <simon.hausmann@nokia.com>
2180
2181         [Qt] Unreviewed trivial build fix: Newer Qt versions don't implicitly include qwindowsysteminterface.h
2182         through the QTestLib headers anymore.
2183
2184         * DumpRenderTree/qt/EventSenderQt.cpp:
2185         * WebKitTestRunner/Target.pri:
2186         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2187
2188 2012-08-11  Sam Weinig  <sam@webkit.org>
2189
2190         Remove ability to run MiniBrowser in threaded mode, it hasn't worked for a long time
2191         https://bugs.webkit.org/show_bug.cgi?id=93774
2192
2193         Reviewed by Dan Bernstein.
2194
2195         Remove support for opening windows using the shared thread WKContextRef. WKContextGetSharedThreadContext()
2196         is going away, due to not working for a long time, and the first step is removing all the callers.
2197
2198         While here, remove the BrowserStatisticsWindow, which was not providing interesting information.
2199
2200         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2201         * MiniBrowser/mac/AppDelegate.h:
2202         * MiniBrowser/mac/AppDelegate.m:
2203         (-[BrowserAppDelegate init]):
2204         (-[BrowserAppDelegate newWindow:]):
2205         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
2206         * MiniBrowser/mac/BrowserStatisticsWindow.xib: Removed.
2207         * MiniBrowser/mac/BrowserStatisticsWindowController.h: Removed.
2208         * MiniBrowser/mac/BrowserStatisticsWindowController.m: Removed.
2209         * MiniBrowser/mac/MainMenu.xib:
2210         * MiniBrowser/win/BrowserView.cpp:
2211         (BrowserView::create):
2212
2213 2012-08-11  Sam Weinig  <sam@webkit.org>
2214
2215         Enable XPC Service based WebProcess with runtime flag
2216         https://bugs.webkit.org/show_bug.cgi?id=93773
2217
2218         Reviewed by Dan Bernstein.
2219
2220         Convert --use-web-process-xpc-service passed to run-safari (and similar scripts)
2221         to setting WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS=YES in the environment and setting
2222         up __XPC_DYLD_FRAMEWORK_PATH and __XPC_DYLD_INSERT_LIBRARIES variables. NOTE: using
2223         the XPC service is not the default code path.
2224
2225         * Scripts/webkitdirs.pm:
2226         (shouldUseXPCServiceForWebProcess):
2227         (determineShouldUseXPCServiceForWebProcess):
2228         Add functions to extract --use-web-process-xpc-service from ARGV and set a
2229         global variable.
2230
2231         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
2232         Add help text for --use-web-process-xpc-service.
2233
2234         (runMacWebKitApp):
2235         Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
2236         if --use-web-process-xpc-service was passed on the command line.
2237
2238         (execMacWebKitAppForDebugging):
2239         Set the WEBKIT_USE_XPC_SERVICE_FOR_WEB_PROCESS environment variable and DYLD
2240         if --use-web-process-xpc-service was passed on the command line. Also, bail
2241         if both --use-web-process-xpc-service and --target-web-process are passed on
2242         the command line, as we don't currently support using both.
2243
2244 2012-08-11  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2245
2246         [EFL] Bump harfbuzz dependency to v0.9.2
2247         https://bugs.webkit.org/show_bug.cgi?id=93762
2248
2249         Reviewed by Eric Seidel.
2250
2251         EFL port has used harfbuzz 0.9.0 ver. However, the 0.9.2 version was released on 10th Aug 2012.
2252         In addition, 0.9.0 ver. was disappeared. So, EFL port needs to use 0.9.2 ver. from now on.
2253
2254         * efl/jhbuild.modules:
2255
2256 2012-08-10  Ryosuke Niwa  <rniwa@webkit.org>
2257
2258         run-perf-tests should upload memory statistics to perf-o-matic
2259         https://bugs.webkit.org/show_bug.cgi?id=93690
2260
2261         Reviewed by Dirk Pranke.
2262
2263         Upload JS Heap and FastMalloc results for a test X/Y as: X/Y:JSHeap and X/Y:FastMalloc.
2264         Note "JS Heap" is converted to the CamelCase JSHeap.
2265
2266         Also did some refactoring in PerfTest.parse_output and PerfTestRunnerTest and updated
2267         some helps in PerfTest.parse_output per arv's comments.
2268
2269         * Scripts/webkitpy/performance_tests/perftest.py:
2270         (PerfTest):
2271         (PerfTest.parse_output): Include JSHeap and FastMalloc statistics in results as well as of Time.
2272         Also refactored it to avoid hard-coding indices in _result_classes and moved complied regular
2273         exressions out of the function to avoid re-compiling them every time the method runs.
2274         (PerfTest.output_statistics): Convert ':' to ': ' as well as '/'.
2275         (ChromiumStylePerfTest.parse_output): Removed an unused variable.
2276         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2277         (PerfTestsRunner._parse_args): Uploaded some helps per arv's feedback.
2278         (PerfTestsRunner._output_json_path): Extracted from _generate_and_show_results to be used in
2279         PerfTestRunnerTest.create_runner.
2280         (PerfTestsRunner._generate_and_show_results):
2281         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2282         (create_runner): Extracted runner.load_output_json from various tests.
2283         (test_run_memory_test): Added.
2284         (PerfTestRunner): Extracted _event_target_wrapper_and_inspector_results from various tests.
2285         (test_run_with_json_output):
2286         (test_run_with_description):
2287         (test_run_generates_json_by_default):
2288         (test_run_generates_and_show_results_page):
2289         (test_run_with_json_source):
2290         (test_run_with_multiple_repositories):
2291
2292 2012-08-10  Benjamin Poulain  <bpoulain@apple.com>
2293
2294         Add support for String initialization from literal to WTFString
2295         https://bugs.webkit.org/show_bug.cgi?id=93426
2296
2297         Reviewed by Anders Carlsson.
2298
2299         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2300         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2301         (TestWebKitAPI::TEST):
2302         * TestWebKitAPI/Tests/WTF/WTFString.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/StringImpl.cpp.
2303         (TestWebKitAPI):
2304         (TestWebKitAPI::TEST):
2305
2306 2012-08-10  Xianzhu Wang  <wangxianzhu@chromium.org>
2307
2308         NRWT crashes when DRT with --encode-binary crashes just before it dumps pixels
2309         https://bugs.webkit.org/show_bug.cgi?id=93728
2310
2311         Reviewed by Dirk Pranke.
2312
2313         * Scripts/webkitpy/layout_tests/port/driver.py:
2314         (ContentBlock.decode_content): Check self.content is not None before calling base64.b64decode().
2315
2316 2012-08-10  Xianzhu Wang  <wangxianzhu@chromium.org>
2317
2318         [Chromium-Android][NRWT] Executable might not be pushed correctly when there are multiple builds
2319         https://bugs.webkit.org/show_bug.cgi?id=93688
2320
2321         Reviewed by Dirk Pranke.
2322
2323         There might be other better methods, but this change is the smallest.
2324         I think the chance of equal timestamp can be ignored because we flock
2325         to avoid concurrent linkers.
2326
2327         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2328         (ChromiumAndroidDriver._push_executable): Changed '<' to '!=' to compare the timestamp.
2329
2330 2012-08-09  Xianzhu Wang  <wangxianzhu@chromium.org>
2331
2332         [Chromium-Android] Skip layout tests directories that are not applicable
2333         https://bugs.webkit.org/show_bug.cgi?id=93670
2334
2335         Reviewed by Dirk Pranke.
2336
2337         Added back ChromiumAndroidPort.skipped_layout_tests to skip some whole directories.
2338         The method is more convenient to skip whole directories than SKIP in TestExpectations
2339         because its higher priority. Will still use TestExpectations to skip individual tests.
2340
2341         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2342         (ChromiumAndroidPort.skipped_layout_tests):
2343
2344 2012-08-09  Elliott Sprehn  <esprehn@chromium.org>
2345
2346         Add myself to the Contributor list.
2347         https://bugs.webkit.org/show_bug.cgi?id=93653
2348
2349         Reviewed by Dirk Pranke.
2350
2351         Add my email to the contributor list.
2352
2353         * Scripts/webkitpy/common/config/committers.py:
2354
2355 2012-08-09  Dirk Pranke  <dpranke@chromium.org>
2356
2357         nrwt: should log progress like ninja does
2358         https://bugs.webkit.org/show_bug.cgi?id=93563
2359
2360         Reviewed by Ojan Vafai.
2361
2362         This change modifies the output of nrwt in the
2363         non--debug-rwt-logging modes.
2364
2365         In non-verbose mode, the output changes from:
2366           "Testing (50%): 96 ran as expected, 4 didn't, 100 left"
2367         to:
2368           "[100/200] foo.html (+4)"
2369         or:
2370           "[100/200] foo.html failed  unexpectedly (text diff)"
2371
2372         which indicates the earliest test currently running (optionally plus the
2373         count of other currently-executing tests if we're running tests in parallel)
2374         or the result of said test.
2375
2376         If the test produces unexpected results, that line is flushed
2377         rather than erased (so we no longer need the %d didn't running
2378         tally).
2379
2380         In --verbose mode, the output is similar, but every test gets a
2381         line (and tests are logged in order of them being started, not
2382         order of them being completed) (and in --details mode, the
2383         first line of each test matches --verbose but the other lines
2384         are unchanged).
2385         
2386         The overall result should be easier to read and is simpler to
2387         implement as well (apart from managing the number of tests that
2388         have started but not completed, which is slightly annoying).
2389
2390         This also matches the output style for test-webkitpy, more-or-less.
2391
2392         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2393         (LayoutTestRunner.run_tests):
2394         (LayoutTestRunner._update_summary_with_result):
2395         (LayoutTestRunner._handle_started_test):
2396         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2397         (FakePrinter):
2398         (FakePrinter.print_started_test):
2399         (FakePrinter.print_finished_test):
2400         * Scripts/webkitpy/layout_tests/views/printing.py:
2401         (Printer.__init__):
2402         (Printer.print_started_test):
2403         (Printer.print_finished_test):
2404         (Printer._print_test_trace):
2405         (Printer._print_progress):
2406         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2407         (test_details):
2408
2409 2012-08-09  Alexey Proskuryakov  <ap@apple.com>
2410
2411         [WK2] Add a process model constant for multiple processes
2412         https://bugs.webkit.org/show_bug.cgi?id=93642
2413
2414         Reviewed by Anders Carlsson.
2415
2416         * MiniBrowser/mac/AppDelegate.h: Updated process model enum to match WebKit.
2417
2418 2012-08-09  Ryosuke Niwa  <rniwa@webkit.org>
2419
2420         Build fix after r125178.
2421
2422         * Scripts/webkitpy/performance_tests/perftest.py:
2423         (PerfTest.parse_output): Don't include non-time results in the JSON output.
2424         * Scripts/webkitpy/performance_tests/perftest_unittest.py: Updated the test outputs so to match
2425         actual test outputs.
2426         (MainTest.test_parse_output):
2427         (MainTest.test_parse_output_with_failing_line):
2428         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Ditto.
2429
2430 2012-08-09  Zoltan Horvath  <zoltan@webkit.org>
2431
2432         JSHeap and FastMallocStatistics based memory measurement for performance-tests
2433         https://bugs.webkit.org/show_bug.cgi?id=90858
2434
2435         Reviewed by Ryosuke Niwa.
2436
2437         Measure the memory usage of the performancetests with the help of the windows.memory.usedJSHeapSize
2438         object and the window.internals.fastMallocStatistics() function call.
2439
2440         * Scripts/webkitpy/performance_tests/perftest.py:
2441         (PerfTest):
2442         (PerfTest.parse_output):
2443         (PerfTest.output_statistics):
2444
2445 2012-08-09  Csaba Osztrogonác  <ossy@webkit.org>
2446
2447         [Qt][Win] Build system bug revealed by r124835
2448         https://bugs.webkit.org/show_bug.cgi?id=93339
2449
2450         Reviewed by Tor Arne Vestbø.
2451
2452         Don't add "LC_ALL=c" on Windows in svnRevisionForDirectory() and in pathRelativeToSVNRepositoryRootForPath().
2453
2454         * Scripts/VCSUtils.pm:
2455         (isWindows): Copied from webkitdirs.pm.
2456         (svnRevisionForDirectory):
2457         (pathRelativeToSVNRepositoryRootForPath):
2458
2459 2012-08-08  Dirk Pranke  <dpranke@chromium.org>
2460
2461         update bot parsing of new-run-webkit-tests' output
2462         https://bugs.webkit.org/show_bug.cgi?id=93537
2463
2464         Reviewed by Ryosuke Niwa.
2465
2466         This change updates the way we parse the output from
2467         new-run-webkit-tests on the bots so that we can show a summary
2468         of the results properly after I re-land the changes that were
2469         reverted in r124994 and r124870.
2470
2471         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2472         (RunWebKitTests._parseNewRunWebKitTestsOutput):
2473
2474 2012-08-08  Shane Stephens  <shanestephens@google.com>
2475
2476         Compile flag for CSS Hierarchies
2477         https://bugs.webkit.org/show_bug.cgi?id=92433
2478
2479         Reviewed by Tony Chang.
2480
2481         * Scripts/webkitperl/FeatureList.pm:
2482         * qmake/mkspecs/features/features.pri:
2483
2484 2012-08-08  Benjamin Poulain  <bpoulain@apple.com>
2485
2486         Use char* instead of LChar* for the public interface of String construction from literals
2487         https://bugs.webkit.org/show_bug.cgi?id=93402
2488
2489         Reviewed by Michael Saboff.
2490
2491         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2492         (TestWebKitAPI::TEST):
2493
2494 2012-08-08  Dirk Pranke  <dpranke@chromium.org>
2495
2496         nrwt: rename finder.py to layout_test_finder.py
2497         https://bugs.webkit.org/show_bug.cgi?id=93557
2498
2499         Reviewed by Ryosuke Niwa.
2500
2501         One last cleanup per old review feedback from rniwa.
2502
2503         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: Renamed from Tools/Scripts/webkitpy/layout_tests/controllers/finder.py.
2504         (LayoutTestFinder):
2505         (LayoutTestFinder.__init__):
2506         (LayoutTestFinder.find_tests):
2507         (LayoutTestFinder._strip_test_dir_prefixes):
2508         (LayoutTestFinder._strip_test_dir_prefix):
2509         (LayoutTestFinder._read_test_names_from_file):
2510         (LayoutTestFinder._strip_comments):
2511         (LayoutTestFinder.skip_tests):
2512         (LayoutTestFinder.split_into_chunks):
2513         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2514
2515 2012-08-08  Ryosuke Niwa  <rniwa@webkit.org>
2516
2517         Add Perf EWS IRC bot
2518         https://bugs.webkit.org/show_bug.cgi?id=92913
2519
2520         Reviewed by Dirk Pranke.
2521
2522         Adds the preliminary implementation of perfalizer, a IRC bot that runs performance tests
2523         based on IRC requests.
2524
2525         * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
2526         (MockSCM.head_svn_revision): The actual implementation returns string, so match that.
2527         (MockSCM.svn_revision): Ditto.
2528         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2529         (Bugzilla.add_attachment_to_bug): Added mimetype.
2530         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
2531         (MockBugzilla.add_attachment_to_bug): Ditto.
2532         * Scripts/webkitpy/common/system/filesystem.py:
2533         (FileSystem.copytree): Added.
2534         * Scripts/webkitpy/common/system/filesystem_mock.py:
2535         (MockFileSystem.copytree): Added.
2536         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Rebaselined tests
2537         that had assumed revision numbers were integers.
2538         (test_run_with_json_output):
2539         (test_run_with_description):
2540         (test_run_generates_json_by_default):
2541         (test_run_generates_and_show_results_page):
2542         (test_run_with_json_source):
2543         (test_run_with_multiple_repositories):
2544         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2545         * Scripts/webkitpy/tool/commands/__init__.py:
2546         * Scripts/webkitpy/tool/commands/perfalizer.py: Added.
2547         (PerfalizerTask):
2548         (PerfalizerTask.__init__):
2549         (PerfalizerTask._copy_build_product_without_patch):
2550         (PerfalizerTask.run):
2551         (PerfalizerTask.parent_command):
2552         (PerfalizerTask.run_webkit_patch):
2553         (PerfalizerTask._json_path):
2554         (PerfalizerTask._results_page_path):
2555         (PerfalizerTask._run_perf_test):
2556         (PerfalizerTask.run_command):
2557         (PerfalizerTask.command_passed):
2558         (PerfalizerTask.command_failed):
2559         (PerfalizerTask.refetch_patch):
2560         (PerfalizerTask.expected_failures):
2561         (PerfalizerTask.build_style):
2562         (PerfTest): IRC command.
2563         (PerfTest.execute):
2564         (Perfalizer): IRC bot.
2565         (Perfalizer.begin_work_queue):
2566         (Perfalizer.work_item_log_path):
2567         (Perfalizer._is_old_failure):
2568         (Perfalizer.next_work_item):
2569         (Perfalizer.process_work_item):
2570         (Perfalizer.handle_unexpected_error):
2571         (Perfalizer.handle_script_error):
2572         * Scripts/webkitpy/tool/commands/perfalizer_unittest.py: Added.
2573         (PerfalizerTaskTest):
2574         (PerfalizerTaskTest._create_and_run_perfalizer):
2575         (PerfalizerTaskTest._create_and_run_perfalizer.logger):
2576         (PerfalizerTaskTest._create_and_run_perfalizer.run_webkit_patch):
2577         (PerfalizerTaskTest._create_and_run_perfalizer.run_perf_test):
2578         (PerfalizerTaskTest.test_run):
2579         (PerfalizerTaskTest.test_run_with_clean_fails):
2580         (PerfalizerTaskTest.test_run_with_update_fails):
2581         (PerfalizerTaskTest.test_run_with_build_fails):
2582         (PerfalizerTaskTest.test_run_with_perf_test_fails):
2583         (PerfalizerTaskTest.test_run_without_results_page):
2584         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2585         (AbstractPatchQueueTest.test_upload_results_archive_for_patch): Rebaselined.
2586         * Scripts/webkitpy/tool/commands/upload_unittest.py:
2587         (test_attach_to_bug): Ditto.
2588         (test_attach_to_bug_no_description_or_comment): Ditto.
2589
2590 2012-08-08  Dirk Pranke  <dpranke@chromium.org>
2591
2592         webkit-patch rebaseline-expectations needs to support multiple expectations files
2593         https://bugs.webkit.org/show_bug.cgi?id=89051
2594
2595         Reviewed by Adam Barth.
2596
2597         fixed the bug described above, added unit test in
2598         test_expectations_unittest, and updated the tool tests
2599         to not contain all of the "missing skia expectations" warnings.
2600
2601         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2602         (TestExpectations.remove_rebaselined_tests):
2603         (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
2604         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2605         (RebaseliningTest.assertRemove):
2606         (RebaseliningTest.test_remove):
2607         * Scripts/webkitpy/tool/commands/rebaseline.py:
2608         (RebaselineExpectations._update_expectations_files):
2609         (RebaselineExpectations.execute):
2610         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2611         (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
2612         (test_rebaseline_expectations):
2613
2614 2012-08-08  Alexey Proskuryakov  <ap@apple.com>
2615
2616         [WK2] MiniBrowser crashes on quit if any windows were previously closed
2617         https://bugs.webkit.org/show_bug.cgi?id=93529
2618
2619         Reviewed by John Sullivan.
2620
2621         * MiniBrowser/mac/AppDelegate.h:
2622         * MiniBrowser/mac/AppDelegate.m:
2623         (-[BrowserAppDelegate init]):
2624         (-[BrowserAppDelegate newWindow:]):
2625         (-[BrowserAppDelegate browserWindowWillClose:]):
2626         (-[BrowserAppDelegate applicationWillTerminate:]):
2627         (-[BrowserAppDelegate frontmostBrowserWindowController]):
2628         Track browser windows explicitly, not relying on [NSApp windows]. Closed windows
2629         are not automatically removed from the list until deallocated, so a refcounting
2630         error can result in working on a closed window.
2631
2632         * MiniBrowser/mac/BrowserWindowController.m:
2633         (-[BrowserWindowController dealloc]): Moved code from -windowWillClose: here.
2634         Releasing data members is -dealloc's job.
2635         (-[BrowserWindowController windowWillClose:]): Notify BrowserAppDelegate that
2636         the window is no longer open. Autorelease self, making sure that WKView and
2637         then WebPageProxy get released.
2638         (-[BrowserWindowController applicationTerminating]): Don't release _webView.pageRef.
2639         WKView is responsible for its lifetime.
2640         (closePage): Ditto.
2641
2642 2012-08-08  Xianzhu Wang  <wangxianzhu@chromium.org>
2643
2644         [Chromium-Android] Apply all Linux layout test expectations
2645         https://bugs.webkit.org/show_bug.cgi?id=92653
2646
2647         Reviewed by Adam Barth.
2648
2649         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2650         (ChromiumAndroidPort.skipped_layout_tests): Removed. Skip these tests in TestExpectations instead.
2651
2652 2012-08-08  Josh Hawn  <jhawn@apple.com>
2653
2654         Add MountainLion WebKit Bots.
2655         https://bugs.webkit.org/show_bug.cgi?id=93417
2656
2657         Reviewed by Stephanie Lewis.
2658
2659         Mountain Lion is now available, so we've added the appropriate Apple bots,
2660         mirroring the configuration of the Lion bots.
2661
2662         * BuildSlaveSupport/build.webkit.org-config/config.json:
2663         Added 10 "apple-mini-###" slaves.
2664         Added MountainLion Builders and Schedulers.
2665
2666 2012-08-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2667
2668         [WK2] Coding style violation was brought with r125031
2669         https://bugs.webkit.org/show_bug.cgi?id=93503
2670
2671         Reviewed by Alexey Proskuryakov.
2672
2673         WKURLResponseCopyMimeType is corrected to WKURLResponseCopyMIMEType.
2674
2675         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2676         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2677         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2678         (WTR::LayoutTestController::dumpProgressFinishedCallback): Removed trailing whitespace that was brought with the same revision.
2679
2680 2012-08-08  Peter Beverloo  <peter@chromium.org>
2681
2682         Buildmaster changes in preparation of a Chromium Android tester
2683         https://bugs.webkit.org/show_bug.cgi?id=92251
2684
2685         Reviewed by Adam Barth.
2686
2687         Slightly update the build master's configuration in preparation of adding
2688         a Chromium Android tester.
2689
2690         The change in built-product-archive is required as the out/ directory
2691         for Android has a number of unstripped .so binaries and unaligned APKs,
2692         causing the default release.zip file to be 2.7 gigabytes. By excluding
2693         these file types, the file is only 59.7 megabytes. We can't disable
2694         them for all of Chromium, as Mac and Linux do use their .so files.
2695
2696         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2697         (ArchiveBuiltProduct): Pass the full platform name instead of just the
2698             generic type, i.e. chromium-android instead of chromium.
2699         (ExtractBuiltProduct): Dito, stay consistent for this script.
2700         (RunUnitTests): Pass --chromium-android as well as --chromium. Since we
2701             now read the full platform name, stay on the safe side with 'win'
2702             even though there (as far as I know) is no win-* platform.
2703         (RunChromiumWebKitUnitTests): Dito. The platform wasn't being passed
2704             at all, but we'll be needing different handling here.
2705         (unitTestsSupported): Next to refactoring work required, as we'll be
2706             running this test on a device, there is no reason to disable this
2707             in the master's configuration.
2708         * BuildSlaveSupport/built-product-archive:
2709         (main): Determine the generic platform.
2710         (archiveBuiltProduct): Use an identical set of ignorePatterns, but
2711             extend the list with .so, .pak and -unaligned.apk for Android.
2712
2713 2012-08-08  Adam Barth  <abarth@webkit.org>
2714
2715         Unreviewed. Stop running tests on the mac-ews while we wait for more
2716         hardware. As requested by lforschler.
2717
2718         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2719
2720 2012-08-08  Peter Beverloo  <peter@chromium.org>
2721
2722         The cr-android EWS should actually be building Chromium for Android
2723         https://bugs.webkit.org/show_bug.cgi?id=93489
2724
2725         Reviewed by Adam Barth.
2726
2727         The cr-android EWS bots should be building Chromium for Android, which
2728         requires some additional flags to Chromium's default configuration.
2729
2730         * Scripts/webkitdirs.pm:
2731         (buildChromium):
2732         * Scripts/webkitpy/common/config/ports.py:
2733         (DeprecatedPort.port):
2734         (ChromiumAndroidPort):
2735         (ChromiumAndroidPort.update_webkit_command):
2736         (ChromiumAndroidPort.build_webkit_command):
2737         * Scripts/webkitpy/common/config/ports_unittest.py:
2738         (DeprecatedPortTest.test_chromium_android_port):
2739         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2740         (ChromiumAndroidEWS):
2741         * Scripts/webkitpy/tool/steps/update_unittest.py:
2742         (UpdateTest.test_update_command_non_interactive):
2743         (UpdateTest.test_update_command_interactive):
2744
2745 2012-08-08  Alexey Proskuryakov  <ap@apple.com>
2746
2747         [WK2] MiniBrowser crashes on window.open()
2748         https://bugs.webkit.org/show_bug.cgi?id=93413
2749
2750         Reviewed by Dan Bernstein.
2751
2752         * MiniBrowser/mac/BrowserWindowController.m: (createNewPage): This is a "create"
2753         API, so it needs to return a retained result.
2754
2755         * MiniBrowser/mac/WebBundle/WebBundleMain.m: (didClearWindowObjectForFrame):
2756         When this function is called, URL appears to be poorly defined. Sometimes, it's
2757         the new URL, other times it's the old one. An "old" URL is null in a new page.
2758
2759 2012-08-08  Loïc Yhuel  <loic.yhuel@softathome.com>
2760
2761         [Qt] Compile errors with OpenGLES2
2762         https://bugs.webkit.org/show_bug.cgi?id=93206
2763
2764         Reviewed by Noam Rosenthal.
2765
2766         Fix build with OpenGLES2 on Linux desktop
2767
2768         * qmake/mkspecs/features/features.prf: Don't use GLX with OpenGLES2
2769
2770 2012-08-08  Peter Beverloo  <peter@chromium.org>
2771
2772         Introduce cr-android bots in the EWS system
2773         https://bugs.webkit.org/show_bug.cgi?id=93472
2774
2775         Reviewed by Adam Barth.
2776
2777         This adds the queue to the EWS scripts. Two builders are ready to be
2778         attached to the queue. All webkitpy tests pass with this change applied.
2779
2780         * QueueStatusServer/model/queues.py:
2781         (Queue):
2782         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2783         (ChromiumAndroidEWS):
2784         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2785         (EarlyWarningSytemTest.test_builder_ewses):
2786
2787 2012-08-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2788
2789         Unreviewed. Fix GTK+ build with GTK2 after r121475.
2790
2791         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp: Add missing
2792         include required when building with GTK2.
2793
2794 2012-08-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2795
2796         [WK2] [WTR] Provide Resource Response dumping.
2797         https://bugs.webkit.org/show_bug.cgi?id=93454
2798
2799         Reviewed by Kenneth Rohde Christiansen.
2800
2801         Added missing dumpResourceResponseMIMETypes() method to testRunner. Provided resource response dumping.
2802
2803         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
2804         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2805         (WTR::InjectedBundlePage::didReceiveResponseForResource):
2806         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2807         (WTR::LayoutTestController::LayoutTestController):
2808         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2809         (WTR::LayoutTestController::dumpProgressFinishedCallback):
2810         (WTR::LayoutTestController::dumpResourceResponseMIMETypes):
2811         (WTR::LayoutTestController::shouldDumpResourceResponseMIMETypes):
2812         (LayoutTestController):
2813
2814 2012-08-08  Simon Hausmann  <simon.hausmann@nokia.com>
2815
2816         [Qt][Win] Fix compilation of DumpRenderTree
2817         https://bugs.webkit.org/show_bug.cgi?id=93461
2818
2819         Reviewed by Tor Arne Vestbø.
2820
2821         DRT includes stdint.h, for which we have wrappers in Source/JavaScriptCore/os-win32. Use these not only
2822         for libraries but any building template.
2823
2824         * qmake/mkspecs/features/default_post.prf:
2825
2826 2012-08-08  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
2827
2828         [WK2] [WTR] Refactoring: LayoutTestController::shouldDumpProgressFinishedCallback() should be const
2829         https://bugs.webkit.org/show_bug.cgi?id=93457
2830
2831         Reviewed by Csaba Osztrogonác.
2832
2833         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
2834         (WTR::LayoutTestController::shouldDumpProgressFinishedCallback): Added constness.
2835
2836 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2837
2838         Unreviewed typo fix after r124988.
2839
2840         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2841         (TestExpectations):
2842
2843 2012-08-07  YoungTaeck Song  <youngtaeck.song@samsung.com>
2844
2845         [WK2][EFL] Implement accelerated compositing on WK2 Efl port
2846         https://bugs.webkit.org/show_bug.cgi?id=89840
2847
2848         Reviewed by Noam Rosenthal.
2849
2850         Implement accelerated composition with TiledBackingStore on WK2 Efl port.
2851         Add OPENGL_LIBRARIES in CMakeList.txt.
2852
2853         * MiniBrowser/efl/CMakeLists.txt:
2854         * WebKitTestRunner/PlatformEfl.cmake:
2855
2856 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2857
2858         [NRWT] REGRESSION(r124967): New tests without expected results handled as failures
2859         https://bugs.webkit.org/show_bug.cgi?id=93434
2860
2861         Reviewed by Tony Chang.
2862
2863         Change back "missing results" to "no expected result found", because master.cfg's results parser expects it.
2864
2865         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2866         (TestExpectations):
2867
2868 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
2869
2870         buildbot: Remove the configuration of hfreyther*
2871         https://bugs.webkit.org/show_bug.cgi?id=91849
2872
2873         Unreviewed typo fix after r123757.
2874
2875         * BuildSlaveSupport/build.webkit.org-config/config.json:
2876
2877 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2878
2879         REGRESSION: PrettyPatchTest.test_pretty_diff_encodings has been failing on Chromium Windows
2880         https://bugs.webkit.org/show_bug.cgi?id=93192
2881
2882         Unreviewed, build fix.
2883
2884         Disabling the test for now as PrettyPatch is just broken on win32.
2885
2886         * Scripts/webkitpy/common/prettypatch_unittest.py:
2887         (test_pretty_diff_encodings):
2888
2889 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2890
2891         [NRWT] Would like an output mode similar to ORWT verbose one
2892         https://bugs.webkit.org/show_bug.cgi?id=88702
2893
2894         Reviewed by Ryosuke Niwa.
2895
2896         Change the --verbose logging for new-run-webkit-tests so that
2897         it matches ORWT more; we just print one line per test. Use
2898         --debug-rwt-logging to get the full debug stream (aka old ORWT
2899         --verbose).
2900
2901         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2902         (TestExpectations):
2903         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2904         (_set_up_derived_options):
2905         (parse_args):
2906         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2907         (MainTest.test_retrying_and_flaky_tests):
2908         * Scripts/webkitpy/layout_tests/views/printing.py:
2909         (print_options):
2910         (Printer._print_result_summary_entry):
2911         (Printer._print_one_line_summary):
2912         (Printer._print_test_result):
2913         (Printer._print_baseline):
2914         (Printer._print_unexpected_results):
2915
2916 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2917
2918         nrwt: handle errors from image diff better
2919         https://bugs.webkit.org/show_bug.cgi?id=92934
2920
2921         Reviewed by Ojan Vafai.
2922
2923         Re-land the change in r124801 with a fix ... in the case where
2924         the ImageDiff is passed a tolerance and passes the fuzzy check,
2925         we were returning the wrong value (missing an empty error
2926         string) and crashing; this patch fixes that and adds a test for
2927         that case (TestImageDiffer.test_image_diff_passed).
2928
2929         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2930         (SingleTestRunner._compare_image):
2931         (SingleTestRunner._compare_output_with_reference):
2932         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2933         (write_test_result):
2934         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2935         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
2936         (TestResultWriterTest):
2937         * Scripts/webkitpy/layout_tests/port/base.py:
2938         (Port.diff_image):
2939         * Scripts/webkitpy/layout_tests/port/chromium.py:
2940         (ChromiumPort.diff_image):
2941         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2942         (ChromiumPortTestCase.test_diff_image_crashed):
2943         * Scripts/webkitpy/layout_tests/port/image_diff.py:
2944         (ImageDiffer.diff_image):
2945         (ImageDiffer._read):
2946         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
2947         (TestImageDiffer.test_diff_image):
2948         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2949         (MockDRTPortTest.test_diff_image_crashed):
2950         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2951         (PortTestCase.test_diff_image):
2952         (PortTestCase.test_diff_image_crashed):
2953         (PortTestCase.test_diff_image_crashed.make_proc):
2954         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
2955         (MockServerProcess.__init__):
2956         * Scripts/webkitpy/layout_tests/port/test.py:
2957         (TestPort.diff_image):
2958         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2959         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
2960
2961 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
2962
2963         nrwt: --no-build isn't working
2964         https://bugs.webkit.org/show_bug.cgi?id=93415
2965
2966         Reviewed by Ryosuke Niwa.
2967
2968         Turns out our optimization to avoid calling
2969         webkit-build-directory N times for each worker broke --no-build.
2970
2971         Fixing, and adding a test.
2972
2973         Also, the gtk port wasn't using the default check_build() logic,
2974         but I don't know why not. Removing their custom hook and will
2975         verify that this is okay in the review ...
2976
2977         * Scripts/webkitpy/layout_tests/port/base.py:
2978         (Port.__init__):
2979         (Port.check_build):
2980         (Port._build_path):
2981         * Scripts/webkitpy/layout_tests/port/gtk.py:
2982         (GtkPort._path_to_image_diff):
2983         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2984         (MockDRTPortTest.test_check_build):
2985         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2986         (test_path_to_apache_config_file):
2987         (test_check_build):
2988         (test_check_build.build_driver_called):
2989
2990 2012-08-07  Ryosuke Niwa  <rniwa@webkit.org>
2991
2992         run-perf-tests should support --no-show-results
2993         https://bugs.webkit.org/show_bug.cgi?id=93409
2994
2995         Reviewed by Dirk Pranke.
2996
2997         Add the support for --no-show-results.
2998
2999         Also replace only local paths to jquery and flot instead of embedding them.
3000         The results page is still standalone in that it tries to load scripts
3001         from both webkit.org and local filesystem.
3002
3003         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3004         (PerfTestsRunner._parse_args):
3005         (PerfTestsRunner.run):
3006         (PerfTestsRunner._generate_and_show_results):
3007         (PerfTestsRunner._generate_output_files):
3008         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3009         (create_runner_and_setup_results_template):
3010         (test_run_generates_and_show_results_page):
3011         (test_run_respects_no_show_results):
3012
3013 2012-08-07  Dirk Pranke  <dpranke@chromium.org>
3014
3015         test-webkitpy hangs in a new checkout on snow leopard
3016         https://bugs.webkit.org/show_bug.cgi?id=93301
3017
3018         Reviewed by Ryosuke Niwa.
3019
3020         This change works around what appears to be a bug in Python
3021         2.6.1 (the version that ships on Mac Snow Leopard) that causes
3022         the multiprocessing module to hang after we use the
3023         autoinstaller; I'm guessing it's some sort of python sockets
3024         issue. I was unable to reproduce this with 2.6.5 or newer
3025         versions of Python.
3026
3027         * Scripts/webkitpy/common/system/autoinstall.py:
3028         (AutoInstaller.install):
3029         * Scripts/webkitpy/test/main.py:
3030         (Tester._run_tests):
3031         * Scripts/webkitpy/thirdparty/__init__.py:
3032         (AutoinstallImportHook._install_mechanize):
3033         (AutoinstallImportHook._install_pep8):
3034         (AutoinstallImportHook._install_pylint):
3035         (AutoinstallImportHook._install_buildbot):
3036         (AutoinstallImportHook._install_coverage):
3037         (AutoinstallImportHook._install_eliza):
3038         (AutoinstallImportHook._install_irc):
3039         (AutoinstallImportHook._install_webpagereplay):
3040         (AutoinstallImportHook._install):
3041         (autoinstall_everything):
3042
3043 2012-08-07  Xianzhu Wang  <wangxianzhu@chromium.org>
3044
3045         [Chromium-Android][NRWT] Fix 2 FIXMEs in chromium_android.py
3046         https://bugs.webkit.org/show_bug.cgi?id=93381
3047
3048         Reviewed by Adam Barth.
3049
3050         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3051         (ChromiumAndroidDriver.__init__):
3052         (ChromiumAndroidDriver._push_executable): Remove temporary lines as the chromium change has been landed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150371
3053         (ChromiumAndroidDriver._setup_performance): Update all scaling governor files.
3054         (ChromiumAndroidDriver._teardown_performance): Update all scaling governor files.
3055
3056 2012-08-07  W. James MacLean  <wjmaclean@chromium.org>
3057
3058         [chromium] Add support to DumpRenderTree [EventSender] for GestureTapDown events.
3059         https://bugs.webkit.org/show_bug.cgi?id=93286
3060
3061         Reviewed by James Robinson.
3062
3063         Adds support to generate GestureTapDown events from EventSender, to facilitate
3064         link highlighting layout tests.
3065  
3066         Added a GestureTapEvent to one existing test, more tests to follow when LinkHighlight CLs start to land.
3067
3068         * DumpRenderTree/chromium/TestRunner/EventSender.cpp:
3069         (EventSender::EventSender):
3070         (EventSender::gestureTapDown):
3071         (EventSender::gestureEvent):
3072         * DumpRenderTree/chromium/TestRunner/EventSender.h:
3073         (EventSender):
3074
3075 2012-08-07  Marcelo Lira  <marcelo.lira@openbossa.org>
3076
3077         [Qt] Add support for the Gamepad API
3078         https://bugs.webkit.org/show_bug.cgi?id=90637
3079
3080         Reviewed by Alexis Menard.
3081
3082         If the libudev library is present, the GAMEPAD flag is
3083         turned on by default for the Qt port.
3084
3085         * Scripts/webkitperl/FeatureList.pm:
3086         * qmake/mkspecs/features/features.prf:
3087
3088 2012-08-07  Rob Buis  <rbuis@rim.com>
3089
3090         [BlackBerry] Turn on CSS Variables
3091         https://bugs.webkit.org/show_bug.cgi?id=93376
3092
3093         Reviewed by Antonio Gomes.
3094
3095         Turn on CSS Variables for BlackBerry port.
3096
3097         * Scripts/webkitperl/FeatureList.pm:
3098
3099 2012-08-07  No'am Rosenthal  <noam.rosenthal@nokia.com>
3100
3101         [Qt] Make it possible to build without QtQuick
3102
3103         Reviewed by Simon Hausmann.
3104
3105         * Tools.pro:
3106         * qmake/mkspecs/features/features.prf:
3107
3108 2012-08-02  Simon Hausmann  <simon.hausmann@nokia.com>
3109
3110         [Qt] Remove Qt 4 specific code paths
3111         https://bugs.webkit.org/show_bug.cgi?id=88161
3112
3113         Reviewed by Kenneth Rohde Christiansen.
3114
3115         * DumpRenderTree/qt/DumpRenderTree.pro:
3116         * DumpRenderTree/qt/EventSenderQt.cpp:
3117         (EventSender::touchCancel):
3118         (EventSender::sendTouchEvent):
3119         * DumpRenderTree/qt/EventSenderQt.h:
3120         (EventSender):
3121         * DumpRenderTree/qt/ImageDiff.pro:
3122         * DumpRenderTree/qt/main.cpp:
3123         (main):
3124         * QtTestBrowser/QtTestBrowser.pro:
3125         * QtTestBrowser/cookiejar.cpp:
3126         (TestBrowserCookieJar::TestBrowserCookieJar):
3127         * QtTestBrowser/launcherwindow.cpp:
3128         (LauncherWindow::setDiskCache):
3129         * qmake/configure.pri:
3130         * qmake/mkspecs/features/default_post.prf:
3131         * qmake/mkspecs/features/default_pre.prf:
3132         * qmake/mkspecs/features/features.prf:
3133         * qmake/mkspecs/features/functions.prf:
3134         * qmake/mkspecs/features/qtwebkit.prf: Removed.
3135         * qmake/mkspecs/features/unix/default_pre.prf:
3136
3137 2012-08-07  Andras Becsi  <andras.becsi@nokia.com>
3138
3139         [Qt][WK2] MiniBrowser should only synthesize multiple touch points if Ctrl is pressed
3140         https://bugs.webkit.org/show_bug.cgi?id=93277
3141
3142         Reviewed by Jocelyn Turcotte.
3143
3144         MiniBrowser's multi-touch mocking does not check if Ctrl is pressed
3145         when registering multiple touch points based on pressed mouse buttons
3146         and sends inconsistent touch events to the WebView which triggers an
3147         assert in the pinch gesture recognizer.
3148         MiniBrowserApplication::updateTouchPoint should only register multiple
3149         touch points if the Ctrl button is pressed else it should ignore the
3150         update request.
3151
3152         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3153         (MiniBrowserApplication::updateTouchPoint):
3154
3155 2012-08-07  Csaba Osztrogonác  <ossy@webkit.org>
3156
3157         REGRESSION(r124800): It broke NRWT result parsing of build.webkit.org
3158         https://bugs.webkit.org/show_bug.cgi?id=93346
3159
3160         Rubber-stamped by Simon Hausmann.
3161
3162         Change back "unexpected" to "Unexpected", because master.cfg's results parser expects it.
3163
3164         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3165         (MainTest.test_retrying_and_flaky_tests):
3166         * Scripts/webkitpy/layout_tests/views/printing.py:
3167         (Printer._print_unexpected_results):
3168
3169 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
3170
3171         [NRWT] runs platform specific tests that it shouldn't with --force
3172         https://bugs.webkit.org/show_bug.cgi?id=91089
3173
3174         Reviewed by Dirk Pranke.
3175
3176         Ignore other platform's directories from platform/.
3177
3178         * Scripts/webkitpy/layout_tests/port/base.py:
3179         (Port._expanded_paths):
3180         * Scripts/webkitpy/layout_tests/port/test.py:
3181         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3182         (MainTest.test_platform_tests_are_found):
3183         Updated integration test in accordance to the new behavior.
3184
3185 2012-08-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3186
3187         [EFL] Enable link prefetch
3188         https://bugs.webkit.org/show_bug.cgi?id=93281
3189
3190         Reviewed by Kentaro Hara.
3191
3192         * Scripts/webkitperl/FeatureList.pm: Enable LINK_PREFETCH feature.
3193
3194 2012-08-06  Sheriff Bot  <webkit.review.bot@gmail.com>
3195
3196         Unreviewed, rolling out r124801.
3197         http://trac.webkit.org/changeset/124801
3198         https://bugs.webkit.org/show_bug.cgi?id=93338
3199
3200         It broke NRWT (Requested by Ossy on #webkit).
3201
3202         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3203         (SingleTestRunner._compare_image):
3204         (SingleTestRunner._compare_output_with_reference):
3205         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3206         (write_test_result):
3207         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3208         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
3209         (TestResultWriterTest):
3210         * Scripts/webkitpy/layout_tests/port/base.py:
3211         (Port.diff_image):
3212         * Scripts/webkitpy/layout_tests/port/chromium.py:
3213         (ChromiumPort.diff_image):
3214         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
3215         (ChromiumPortTestCase.test_diff_image):
3216         * Scripts/webkitpy/layout_tests/port/image_diff.py:
3217         (ImageDiffer.diff_image):
3218         (ImageDiffer._read):
3219         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
3220         (TestImageDiffer.test_diff_image):
3221         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3222         (MockDRTPortTest.test_diff_image):
3223         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3224         (PortTestCase.test_diff_image):
3225         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
3226         (MockServerProcess.__init__):
3227         * Scripts/webkitpy/layout_tests/port/test.py:
3228         (TestPort.diff_image):
3229         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3230         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3231
3232 2012-08-06  Wei James  <james.wei@intel.com>
3233
3234         [Chromium]duplicated command line options in Android LayoutTest
3235         https://bugs.webkit.org/show_bug.cgi?id=93233
3236
3237         Reviewed by Tony Chang.
3238
3239         Duplicated options found in Android layout test command line:
3240         --encode-binary and --enable-hardware-gpu.
3241
3242         If there are multiple ChromiumAndroidPort instances,
3243         these two options will be appended for multiple times.
3244
3245         * Scripts/webkitpy/layout_tests/port/base.py:
3246         (Port.additional_drt_flag):
3247         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3248         (ChromiumAndroidPort.__init__):
3249         (ChromiumAndroidPort.additional_drt_flag):
3250         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3251         (ChromiumAndroidTwoPortsTest):
3252         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
3253         * Scripts/webkitpy/layout_tests/port/driver.py:
3254         (Driver.cmd_line):
3255
3256 2012-08-03  Brady Eidson  <beidson@apple.com>
3257
3258         Out-of-process plug-ins should support asynchronous initialization
3259         <rdar://problem/10598594> and https://bugs.webkit.org/show_bug.cgi?id=92919
3260
3261         Reviewed by Anders Carlsson.
3262
3263         Add a plug-in with an NPP_New that takes 550ms (a reasonable trade-off between a solid test and a slow running test)
3264         for testing asynchronous plug-in initialization.
3265
3266         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3267         * DumpRenderTree/TestNetscapePlugIn/Tests/SlowNPPNew.cpp: Copied from Source/WebKit2/Shared/Plugins/PluginProcessCreationParameters.h.
3268         (SlowNPPNew):
3269         (SlowNPPNew::SlowNPPNew):
3270         (SlowNPPNew::NPP_New):
3271
3272 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3273
3274         [Chromium-Android] Virtual test suites fail
3275         https://bugs.webkit.org/show_bug.cgi?id=92515
3276
3277         Reviewed by Dirk Pranke.
3278
3279         The failure is because our bypassing of DriverProxy.
3280         Repeat the logic of virtual tests in DriverProxy in ChromiumAndroidDriver
3281         and restart DRT when the command line changes.
3282
3283         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3284         (ChromiumAndroidDriver.__init__):
3285         (ChromiumAndroidDriver.cmd_line): Added comments about why we override this and have _drt_cmd_line().
3286         (ChromiumAndroidDriver.run_test): Repeat the logic of virtual tests in DriverProxy.
3287         (ChromiumAndroidDriver.start): Restart DRT when the command line changes.
3288         (ChromiumAndroidDriver._start_once):
3289
3290 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3291
3292         Remove NRWT --shard-ref-tests
3293         https://bugs.webkit.org/show_bug.cgi?id=91539
3294
3295         This is basically a revert of "[Chromium-Android] Run ref tests together to avoid expensive driver restarts"
3296         (https://bugs.webkit.org/show_bug.cgi?id=91533, http://trac.webkit.org/changeset/122914),
3297         with some conflicts resolved (because of refactory of Manager/LayoutTestRunner/Sharder classes).
3298
3299         Reviewed by Dirk Pranke.
3300
3301         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3302         (LayoutTestRunner.run_tests):
3303         (Sharder.shard_tests):
3304         (Sharder._shard_in_two):
3305         (Sharder._shard_by_directory):
3306         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3307         (SharderTests):
3308         (SharderTests.get_test_input):
3309         (SharderTests.get_shards):
3310         (SharderTests.test_shard_by_dir):
3311         (SharderTests.test_shard_in_two):
3312         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3313         (Manager._test_input_for_file):
3314         (Manager._test_is_slow):
3315         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3316         (ChromiumAndroidPort.__init__):
3317         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3318         (parse_args):
3319
3320 2012-08-06  Luciano Wolf  <luciano.wolf@openbossa.org>
3321
3322         [Qt] Default sizes for input-text and text-area are different when running DRT/WTR
3323         https://bugs.webkit.org/show_bug.cgi?id=91990
3324
3325         Reviewed by Kenneth Rohde Christiansen.
3326
3327         Initializing TestFonts information into WTR binary. Doing it 
3328         later leads to wrong font names usage (Dejavu Serif instead
3329         of Liberation Serif).
3330
3331         * WebKitTestRunner/Target.pri:
3332         * WebKitTestRunner/qt/main.cpp:
3333         (main):
3334
3335 2012-08-06  Jeff Timanus  <twiz@chromium.org>
3336
3337         Add twiz@{chromium|google}.org to the set of non-committer contributors.
3338         https://bugs.webkit.org/show_bug.cgi?id=93288
3339
3340         Reviewed by Adam Barth.
3341
3342         * Scripts/webkitpy/common/config/committers.py:
3343
3344 2012-08-06  Adam Barth  <abarth@webkit.org>
3345
3346         REGRESSION(124789): EWS errors out because --print option is missing
3347         https://bugs.webkit.org/show_bug.cgi?id=93299
3348
3349         Unreviewed.
3350
3351         The --print option doesn't exist anymore.  Let's try --quiet instead.
3352
3353         * Scripts/webkitpy/tool/steps/runtests.py:
3354         (RunTests.run):
3355         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3356
3357 2012-08-06  Ryosuke Niwa  <rniwa@webkit.org>
3358
3359         run-webkit-tests should have ability to add description to its JSON output
3360         https://bugs.webkit.org/show_bug.cgi?id=93296
3361
3362         Reviewed by Dirk Pranke.
3363
3364         Add --description option.
3365
3366         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3367         (PerfTestsRunner._parse_args):
3368         (PerfTestsRunner._generate_and_show_results):
3369         (PerfTestsRunner._generate_results_dict):
3370         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3371         (test_run_with_description):
3372
3373 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
3374
3375         nrwt: handle errors from image diff better
3376         https://bugs.webkit.org/show_bug.cgi?id=92934
3377
3378         Reviewed by Ojan Vafai.
3379
3380         Currently if ImageDiff crashes, returns a weird exit code, or
3381         produces any stderr output, it's basically swallowed. This
3382         change ensures that we log errors to stderr, and also appends
3383         the error to the stderr for the test (so it'll show up in
3384         results.html).
3385
3386         Most importantly, it'll cause diff_image() to fail and we'll
3387         report ImageHashMismatch ... this may be kinda untrue, but I
3388         think it's better than ignoring the error.
3389
3390         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
3391         (SingleTestRunner._compare_image):
3392         (SingleTestRunner._compare_output_with_reference):
3393         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3394         (write_test_result):
3395         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
3396         (TestResultWriterTest.test_reftest_diff_image.ImageDiffTestPort.diff_image):
3397         (TestResultWriterTest):
3398         * Scripts/webkitpy/layout_tests/port/base.py:
3399         (Port.diff_image):
3400         * Scripts/webkitpy/layout_tests/port/chromium.py:
3401         (ChromiumPort.diff_image):
3402         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
3403         (ChromiumPortTestCase.test_diff_image_crashed):
3404         * Scripts/webkitpy/layout_tests/port/driver.py:
3405         (Driver.run_test):
3406         * Scripts/webkitpy/layout_tests/port/image_diff.py:
3407         (ImageDiffer.diff_image):
3408         (ImageDiffer._read):
3409         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
3410         (TestImageDiffer.test_diff_image):
3411         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
3412         (MockDRTPortTest.test_diff_image_crashed):
3413         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3414         (PortTestCase.test_diff_image):
3415         (PortTestCase):
3416         (PortTestCase.test_diff_image_crashed):
3417         (PortTestCase.test_diff_image_crashed.make_proc):
3418         * Scripts/webkitpy/layout_tests/port/server_process_mock.py:
3419         (MockServerProcess.__init__):
3420         * Scripts/webkitpy/layout_tests/port/test.py:
3421         (TestPort.diff_image):
3422         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3423         (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
3424
3425 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
3426
3427         nrwt: clean up printing.py
3428         https://bugs.webkit.org/show_bug.cgi?id=93026
3429
3430         Reviewed by Dirk Pranke.
3431
3432         This patch cleans up the implementation of printing.py now
3433         that we're not using all the original complexity.
3434
3435         There should be no changes in functionality and everything
3436         should be covered by the existing tests.
3437
3438         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3439         (LayoutTestRunner.run_tests):
3440         * Scripts/webkitpy/layout_tests/views/printing.py:
3441         (Printer.__init__):
3442         (Printer.__del__):
3443         (Printer.print_config):
3444         (Printer.print_found):
3445         (Printer.print_expected):
3446         (Printer.print_workers_and_shards):
3447         (Printer):
3448         (Printer._print_expected_results_of_type):
3449         (Printer.print_results):
3450         (Printer._print_timing_statistics):
3451         (Printer._print_aggregate_test_statistics):
3452         (Printer._print_individual_test_times):
3453         (Printer._print_test_list_timing):
3454         (Printer._print_directory_timings):
3455         (Printer._print_statistics_for_test_timings):
3456         (Printer._print_result_summary):
3457         (Printer._print_result_summary_entry):
3458         (Printer._print_one_line_summary):
3459         (Printer.print_finished_test):
3460         (Printer._print_test_result):
3461         (Printer._print_test_trace):
3462         (Printer._print_baseline):
3463         (Printer._print_unexpected_test_result):
3464         (Printer._print_progress):
3465         (Printer._print_unexpected_results):
3466         (Printer._print_unexpected_results.add_result):
3467         (Printer._print_quiet):
3468         (Printer._print_default):
3469         (Printer._print_debug):
3470         (Printer._print_for_bot):
3471         (Printer.write_update):
3472         (Printer.writeln):
3473         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3474         (Testprinter.get_printer):
3475         (Testprinter.test_print_config):
3476         (Testprinter.test_print_one_line_summary):
3477         (Testprinter.test_print_unexpected_results):
3478         (test_details):
3479
3480 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
3481
3482         change bots to pass --debug-rwt-logging instead of --verbose to new-run-webkit-tests
3483         https://bugs.webkit.org/show_bug.cgi?id=93043
3484
3485         Reviewed by Ryosuke Niwa.
3486
3487         in preparation for the cleanup of the logging flags in new-run-webkit-tests.
3488
3489         * Scripts/run-webkit-tests:
3490
3491 2012-08-06  Dirk Pranke  <dpranke@chromium.org>
3492
3493         nrwt: clean up logging, part 1
3494         https://bugs.webkit.org/show_bug.cgi?id=93018
3495
3496         Reviewed by Ojan Vafai.
3497
3498         remove --print, --help-printing from nrwt, add three new options:
3499         --quiet, which just logs warnings,errors, and unexpected results
3500         --debug-rwt-logging, a new name for --verbose
3501         --details, to get the old --print trace-everything behavior
3502
3503         This patch does not implement the new "one line per test"
3504         --verbose behavior specified in bug 88702, and there's a bunch
3505         of internal cleanup I can do in printing.py that I'll defer to
3506         a later patch to make things easier to review.
3507
3508         This patch deletes a lot of unit tests that are no longer
3509         necessary since there aren't so many logging combinations.
3510
3511         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3512         (run):
3513         (main):
3514         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3515         (parse_args):
3516         (passing_run):
3517         (StreamTestingMixin.assertContains):
3518         (MainTest.test_child_processes_2):
3519         (MainTest.test_child_processes_min):
3520         (MainTest.test_full_results_html):
3521         (MainTest.test_no_tests_found):
3522         (MainTest.test_no_tests_found_2):
3523         (MainTest.test_repeat_each_iterations_num_tests):
3524         (MainTest.test_additional_platform_directory):
3525         (RebaselineTest.assertBaselines):
3526         * Scripts/webkitpy/layout_tests/views/printing.py:
3527         (print_options):
3528         (Printer.__init__):
3529         (Printer.enabled):
3530         (Printer.print_unexpected_results):
3531         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
3532         (TestUtilityFunctions.test_print_options):
3533         (Testprinter.get_result_summary):
3534         (Testprinter.test_configure_and_cleanup):
3535         (Testprinter.test_print_config):
3536         (Testprinter.test_print_one_line_summary):
3537         (Testprinter.test_print_unexpected_results):
3538         (test_details):
3539         (test_default):
3540         (test_quiet):
3541         (test_verbose):
3542
3543 2012-08-06  Xianzhu Wang  <wangxianzhu@chromium.org>
3544
3545         [Chromium-Android] Store test executable, data and fonts in /data/local/tmp
3546         https://bugs.webkit.org/show_bug.cgi?id=91910
3547
3548         /data/local/tmp is a directory with permission 0777 by default.
3549         Place DumpRenderTree resources here so that both the native test app and
3550         the NRWT script can access them even if adb shell isn't running as root.
3551
3552         Reviewed by Adam Barth.
3553
3554         * DumpRenderTree/chromium/TestShellAndroid.cpp:
3555         (createFIFO): Set fifo mode to 0666 to allow unrooted adb shell to access.
3556         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3557         (ChromiumAndroidPort.driver_cmd_line):
3558         (ChromiumAndroidDriver.__init__):
3559         (ChromiumAndroidDriver._setup_test):
3560         (ChromiumAndroidDriver._push_executable):
3561         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3562         (ChromiumAndroidPortTest.make_port):
3563         (ChromiumAndroidPortTest.test_expectations_files):
3564         (ChromiumAndroidDriverTest.test_drt_cmd_line):
3565
3566 2012-08-06  Abhishek Arya  <inferno@chromium.org>
3567
3568         [Chromium] Re-expose layoutTestController as various fuzzers depend on it
3569         https://bugs.webkit.org/show_bug.cgi?id=93282
3570
3571         Reviewed by Ryosuke Niwa.
3572
3573         Unfortunately, various fuzzers used in the Chromium project still depends on
3574         window.layoutTestController. Re-expose the object while they're making the transition.
3575
3576         * DumpRenderTree/chromium/TestShell.cpp:
3577         (TestShell::bindJSObjectsToWindow):
3578
3579 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
3580
3581         WTR should be able to load external resources
3582         https://bugs.webkit.org/show_bug.cgi?id=89382
3583
3584         Reviewed by Ryosuke Niwa.
3585
3586         Allow to load an external resource as the main frame
3587         and allow all subsequent external loads for such a main
3588         frame. This behavior is necessary for being able to run
3589         performance tests (https://bugs.webkit.org/show_bug.cgi?id=84008).
3590
3591         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3592         (WTR::isLocalHost):
3593         (WTR):
3594         (WTR::isHTTPOrHTTPSScheme):
3595         (WTR::InjectedBundlePage::willSendRequestForFrame):
3596
3597 2012-08-06  Balazs Kelemen  <kbalazs@webkit.org>
3598
3599         [WK2] REGRESSION(124596) lot of web process unresponsiveness appears on Apple bots
3600         https://bugs.webkit.org/show_bug.cgi?id=93120
3601
3602         Reviewed by Csaba Osztrogonác.
3603
3604         Set the short timeout back to 15 seconds and add more time to WebKitTestRunner
3605         so it will be able to detect an unresponsive web process.
3606
3607         * Scripts/webkitpy/layout_tests/port/base.py:
3608         (Port.default_timeout_ms):
3609         * WebKitTestRunner/TestController.cpp:
3610         (WTR):
3611
3612 2012-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3613
3614         Unreviewed. Fix make distcheck.
3615
3616         * GNUmakefile.am: Add jhbuildutils.py to EXTRA_DIST.
3617
3618 2012-08-06  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3619
3620         [EFL] EFL's LayoutTestController needs removeAllVisitedLinks implementation
3621         https://bugs.webkit.org/show_bug.cgi?id=82724
3622
3623         Reviewed by Csaba Osztrogonác.
3624
3625         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3626         (LayoutTestController::removeAllVisitedLinks):
3627
3628 2012-08-06  Mario Sanchez Prada  <msanchez@igalia.com>
3629
3630         [WK2][GTK] Implement a new spell checker API for WebKit2GTK+
3631         https://bugs.webkit.org/show_bug.cgi?id=90268
3632
3633         Reviewed by Martin Robinson.
3634
3635         Ignore WebKitTextChecker.* private files for gtk-doc.
3636
3637         * gtk/generate-gtkdoc:
3638         (get_webkit2_options):
3639
3640 2012-08-06  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3641
3642         Unreviewed. Roll out r124728 because of build bot test fail.
3643
3644         * Scripts/webkitpy/common/config/watchlist:
3645
3646 2012-08-05  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3647
3648         Unreviewed. Change my email address for watch list.
3649
3650         * Scripts/webkitpy/common/config/watchlist:
3651
3652 2012-08-04  Nico Weber  <thakis@chromium.org>
3653
3654         [Chromium Mac] Tests are exiting early due to failures to load missingImage.png