75c19bc8d17cb7645fd2585382e3c27a4b86055d
[WebKit-https.git] / Tools / ChangeLog
1 2012-12-11  Martin Robinson  <mrobinson@igalia.com>
2
3         Fix a typo in my previous commit that is causing test failures.
4
5         Reviewed by Gustavo Noronha Silva.
6
7         There was an extra bit of statement appended after the end of a conditional. Somehow
8         this compiled and caused test failures.
9
10         * DumpRenderTree/gtk/EventSender.cpp:
11         (continuousMouseScrollByCallback):
12
13 2012-12-11  Martin Robinson  <mrobinson@igalia.com>
14
15         [GTK] Spurious stderr output from the event sender
16         https://bugs.webkit.org/show_bug.cgi?id=104678
17
18         Reviewed by Gustavo Noronha Silva.
19
20         Eliminate some spurious stderr output from the EventSender by using an early return
21         instead of an assertion that prints a warning to the console.
22
23         * DumpRenderTree/gtk/EventSender.cpp:
24         (continuousMouseScrollByCallback): We don't support continuous scroll events that
25         move by page, but we should just fail silently instead of printing an error.
26
27 2012-12-11  Joone Hur  <joone.hur@intel.com>
28
29         [GTK] Add GraphicsLayerActor
30         https://bugs.webkit.org/show_bug.cgi?id=91940
31
32         Reviewed by Gustavo Noronha Silva.
33
34         Add GraphicsLayerActor to the list of classes that contain GObjects
35         in the style checker script so that it does not complain about GObject
36         coding style.
37
38         * Scripts/webkitpy/style/checker.py:
39
40 2012-12-11  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
41
42         [Qt] remove hack which avoids unused .obj directories all over the place
43
44         Reviewed by Simon Hausmann.
45
46         The feature is subject to upstreaming in Qt itself in
47         https://codereview.qt-project.org/#change,42011
48
49         * qmake/mkspecs/features/default_post.prf:
50
51 2012-12-11  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
52
53         [Qt] move SQLITE3SRCDIR assignment to only use site
54
55         Reviewed by Simon Hausmann.
56
57         Target.pri includes WebCore.pri the almost first thing, so that is
58         covered as well.
59
60         * qmake/mkspecs/features/default_pre.prf:
61
62 2012-12-11  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
63
64         [Qt] delete dead include paths
65
66         Reviewed by Simon Hausmann.
67
68         followup to https://bugs.webkit.org/show_bug.cgi?id=93446
69
70         * DumpRenderTree/qt/DumpRenderTree.pro:
71
72 2012-12-11  Martin Robinson  <mrobinson@igalia.com>
73
74         [GTK] Implement some missing FrameLoaderClient message in DRT
75         https://bugs.webkit.org/show_bug.cgi?id=104444
76
77         Reviewed by Gustavo Noronha Silva.
78
79         Install a FrameLoadEvent callback that prints the necessary output for some
80         missing FrameLoader events.
81
82         * DumpRenderTree/gtk/DumpRenderTree.cpp:
83         (frameLoadEventCallback): Added.
84         (createWebView): Install the FrameLoader event callback.
85
86 2012-12-11  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
87
88         [Qt] change setup of QMAKE_MOC
89
90         Reviewed by Simon Hausmann.
91
92         don't load(moc) explicitly - turns out that this breaks
93         debug_and_release builds (the feature does not like being loaded before
94         default_post has been loaded).
95         so instead just do a minimal call to find the moc executable.
96
97         as it's in fact only two files which need it, so de-centralize this call
98         for the sake of saving some cpu cycles spent in qmake.
99
100         * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
101         * qmake/mkspecs/features/default_pre.prf:
102
103 2012-12-11  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
104
105         [Qt] Fix the linking of debug builds on Mac with force_static_libs_as_shared
106         https://bugs.webkit.org/show_bug.cgi?id=104559
107
108         Reviewed by Tor Arne Vestbø.
109
110         "contains(libraries, $$TARGET): return(true)" fails for intermediate libraries since
111         at this point TARGET may contain the "_debug" suffix.
112
113         Fix it by moving the TARGET adjustment later in the file.
114
115         * qmake/mkspecs/features/default_post.prf:
116
117 2012-12-11  Martin Robinson  <mrobinson@igalia.com>
118
119         [Coverity] [GTK] Remove some redundant null checks in DumpRenderTree
120         https://bugs.webkit.org/show_bug.cgi?id=104570
121
122         Reviewed by Daniel Bates.
123
124         * DumpRenderTree/gtk/DumpRenderTree.cpp:
125         (descriptionSuitableForTestResult): Remove a redundant null check.
126
127 2012-12-11  Alberto Garcia  <agarcia@igalia.com>
128
129         Remove unused GErrors
130         https://bugs.webkit.org/show_bug.cgi?id=104657
131
132         Reviewed by Martin Robinson.
133
134         Replace unused GErrors with null pointers.
135
136         * DumpRenderTree/gtk/DumpRenderTree.cpp:
137         (initializeFonts):
138         * DumpRenderTree/gtk/EditingCallbacks.cpp:
139         (dumpRange):
140         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
141         (WTR::inititializeFontConfigSetting):
142
143 2012-12-11  Martin Robinson  <mrobinson@igalia.com>
144
145         [GTK] Bump the jhbuild libsoup version to fix an authentication issue
146         https://bugs.webkit.org/show_bug.cgi?id=104448
147
148         Reviewed by Gustavo Noronha Silva.
149
150         Bump the libsoup version to one from the git repository. This requires updating
151         GLib as well which in turn requires adjusting the CFLAGS we pass when compiling
152         the scanobj step of the gtkdoc generation.
153
154         * gtk/generate-gtkdoc:
155         * gtk/jhbuild.modules:
156
157 2012-12-11  Zan Dobersek  <zandobersek@gmail.com>
158
159         Unreviewed functionality fix for the GTK port.
160
161         Enable the MicroData feature support for the GTK port in the FeatureList module.
162         This feature listing now again affects which features are enabled and which disabled
163         on the development builds of the GTK port.
164
165         * Scripts/webkitperl/FeatureList.pm:
166
167 2012-12-11  Jinwoo Song  <jinwoo7.song@samsung.com>
168
169         [EFL][WK2] MiniBrowser is not built
170         https://bugs.webkit.org/show_bug.cgi?id=104629
171
172         Reviewed by Gyuyoung Kim.
173
174         As we are finding an elementary package in Tools/MiniBrowser/efl/CMakeList.txt since r137203,
175         we need to check if the package is found in the same place not in the Tools/CMakeList.txt.
176
177         * CMakeLists.txt:
178         * MiniBrowser/efl/CMakeLists.txt:
179
180 2012-12-11  Xabier Rodriguez Calvar  <calvaris@igalia.com>
181
182         [GTK][jhbuild] Switch to GStreamer 1.0 build
183         https://bugs.webkit.org/show_bug.cgi?id=91727
184
185         Reviewed by Philippe Normand.
186
187         Switch build-webkit --gtk to GStreamer 1.0 support and build the
188         necessary GStreamer git modules from JHBuild.
189
190         * gtk/jhbuild.modules: Added GStreamer 1.0.3 build support.
191
192 2012-12-11  Zan Dobersek  <zandobersek@gmail.com>
193
194         [GTK] Feature enabling/disabling should be possible through build-webkit
195         https://bugs.webkit.org/show_bug.cgi?id=99271
196
197         Reviewed by Gustavo Noronha Silva.
198
199         Refactor the code in webkitdirs.pm that builds an autotools project to generate
200         autogen.sh arguments, make arguments and installation prefix from the passed-in
201         parameters rather than generating all of that in build-webkit. The autogen.sh
202         arguments now contain only enable/disable flags for options that are actually
203         configurable in configure.ac, the flag value actually reflecting whether the feature
204         is enabled or disabled in the feature list.
205
206         Other features are overridable through modifying the GNUmakefile.features.am file.
207         All these features are now stored in the build directory and upon change trigger
208         a rerun of the autogen.sh script, pretty much like the autogen.sh arguments do.
209
210         The override-feature-defines script is called by autogen.sh, before GNUmakefile.in is
211         generated when calling autoreconf. Its task is to copy the GNUmakefile.features.am.in
212         into GNUmakefile.features.am and modify it if there's a text file in the build directory
213         that contains all the feature defines the build-webkit script has written. If the build
214         is not done through build-webkit (and there's no file in build directory listing all the
215         feature defines) the script does not advance further from copying.
216
217         This approach is taken to overcome the rigidness of the automake system as it's impossible
218         to effectively generate and use GNUmakefile.features.am or even GNUmakefile.features file
219         after the autoreconf command execution in autogen.sh.
220
221         * Scripts/build-jsc:
222         (buildMyProject):
223         * Scripts/build-webkit:
224         * Scripts/webkitdirs.pm:
225         (runAutogenForAutotoolsProjectIfNecessary):
226         (mustReRunAutogen):
227         (buildAutotoolsProject):
228         (buildGtkProject):
229         * Scripts/webkitperl/FeatureList.pm: Update the features that are currently enabled in
230         Source/WebCore/GNUmakefile.features.am.in but aren't in the feature list.
231         * Scripts/webkitpy/style/checker.py: Source/WebCore/GNUmakefile.features.am.in is recognized
232         as a text file and tabulation errors are reported. Skip the file to suppress them.
233         * gtk/override-feature-defines: Added.
234         (copy_feature_defines_makefile):
235         (adjust_feature_defines_makefile):
236         (adjust_feature_defines_makefile.override_feature_define):
237         (override_feature_defines):
238
239 2012-12-10  Yury Semikhatsky  <yurys@chromium.org>
240
241         Memory instrumentation: make sure each edge is reported only once
242         https://bugs.webkit.org/show_bug.cgi?id=104630
243
244         Reviewed by Pavel Feldman.
245
246         Test that outgoing edges are reported only once if we come to the same
247         object twice: first by an address of a base class and then by a real address
248         of the object.
249
250         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
251
252 2012-12-10  Dana Jansens  <danakj@chromium.org>
253
254         [chromium] Remove WebCompositorOutputSurface implementations from DRT
255         https://bugs.webkit.org/show_bug.cgi?id=104046
256
257         Reviewed by Darin Fisher.
258
259         The classes are now provided through WebCompositorSupport.
260
261         * DumpRenderTree/DumpRenderTree.gypi:
262         * DumpRenderTree/chromium/WebViewHost.cpp:
263         (WebViewHost::createOutputSurface):
264         * DumpRenderTree/chromium/WebViewHostOutputSurface.cpp: Removed.
265         * DumpRenderTree/chromium/WebViewHostOutputSurface.h: Removed.
266         * DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.cpp: Removed.
267         * DumpRenderTree/chromium/WebViewHostSoftwareOutputDevice.h: Removed.
268
269 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
270
271         change --no-launch-safari to --no-show-results in scripts
272         https://bugs.webkit.org/show_bug.cgi?id=104298
273
274         Reviewed by Eric Seidel.
275
276         Since Safari only exists on the Apple ports, NRWT calls the
277         command line flag --[no-]show-results instead. This updates
278         the scripts to use the new flag (but not the buildbot config yet).
279
280         * Scripts/generate-coverage-data:
281         * Scripts/webkit-tools-completion.sh:
282         * Scripts/webkitpy/tool/steps/runtests.py:
283         (RunTests.run):
284         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
285
286 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
287
288         nrwt: fix mapping of AUDIO onto FAIL when printing unexpected results
289         https://bugs.webkit.org/show_bug.cgi?id=104597
290
291         Reviewed by Ojan Vafai.
292
293         This was broken in the recent printer refactoring.
294
295         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
296         (BuildBotPrinter.print_unexpected_results.add_result.is_expected):
297         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
298         (BuildBotPrinterTests.get_result):
299         (BuildBotPrinterTests.test_print_unexpected_results):
300         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
301         (BuildBotPrinterTests):
302
303 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
304
305         old-run-webkit-tests: add --show-results properly
306         https://bugs.webkit.org/show_bug.cgi?id=104608
307
308         Reviewed by Eric Seidel.
309
310         Rework r137219 / bug 104601 to use the correct perl idiom.
311
312         * Scripts/old-run-webkit-tests:
313
314 2012-12-10  Aaron Colwell  <acolwell@chromium.org>
315
316         Unreviewed. Adding Aaron Colwell to the contributor list.
317
318         * Scripts/webkitpy/common/config/committers.py:
319
320 2012-12-10  Anders Carlsson  <andersca@apple.com>
321
322         Remove WebKit2 tests on Windows
323         https://bugs.webkit.org/show_bug.cgi?id=104607
324
325         Reviewed by Tim Horton.
326
327         Stop building WebKit2 tests and remove associated files.
328
329         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Removed.
330         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Removed.
331         * TestWebKitAPI/win/PlatformWebViewWin.cpp: Removed.
332         * TestWebKitAPI/win/TestWebKitAPI.sln: Removed.
333         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
334         * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj: Removed.
335         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops: Removed.
336         * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Removed.
337         * TestWebKitAPI/win/WindowMessageObserver.h: Removed.
338         * TestWebKitAPI/win/copy-resources.cmd: Removed.
339
340 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
341
342         old-run-webkit-tests: support --no-show-results for compatibility w/ NRWT
343         https://bugs.webkit.org/show_bug.cgi?id=104601
344
345         Reviewed by Eric Siedel.
346
347         This flag is being added so we can move all of the calling scripts
348         over to using --no-show-results instead of --no-launch-safari.
349
350         * Scripts/old-run-webkit-tests:
351
352 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
353
354         nrwt: use the default logic for skipping platform-specific tests for chromium
355         https://bugs.webkit.org/show_bug.cgi?id=104403
356
357         Reviewed by Stephen White.
358
359         I thought I had fixed this a while ago, but the chromium port was
360         using custom logic to figure out which platform/* tests to run (or
361         skip) and as a result we were getting some odd behavior (like running
362         tests in chromium-linux on chromium-mac, but only when there was
363         an expectation listed for the test).
364
365         Ports are supposed to only run the tests found under their
366         baseline_search_path() by default.
367
368         Not writing a test for this; theoretically there shouldn't been a
369         test checking that the behavior for Chromium was *different* than
370         the other ports before.
371
372         * Scripts/webkitpy/layout_tests/port/chromium.py:
373         (ChromiumPort._missing_symbol_to_skipped_tests):
374
375 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
376
377         fix regression in test-webkitpy after r137189
378         https://bugs.webkit.org/show_bug.cgi?id=104589
379
380         Reviewed by Eric Seidel.
381
382         Need to specify full port names.
383
384         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
385         (MainTest.test_build_check):
386
387 2012-12-10  Laszlo Gombos  <l.gombos@samsung.com>
388
389         [EFL] Change the minimum required EFL version to 1.6
390         https://bugs.webkit.org/show_bug.cgi?id=104431
391
392         Reviewed by Kenneth Rohde Christiansen.
393
394         Change the minimum required EFL version to 1.6 from 1.7.
395         The elementary EFL package is only required to build MiniBrowser,
396         so I moved the required only to the Minibrowser CMake file.
397
398         * MiniBrowser/efl/CMakeLists.txt: In addition removed
399         ENABLE_GLIB_SUPPORT as it is obsolete and it was always set to be on.
400
401 2012-12-10  Dean Jackson  <dino@apple.com>
402
403         Unreviewed. Adding Antoine to the contributor list so his name autocompletes in bugzilla.
404
405         * Scripts/webkitpy/common/config/committers.py:
406
407 2012-12-10  Zan Dobersek  <zandobersek@gmail.com>
408
409         REGRESSION (r118735): svg/dom/complex-svgView-specification.html, svg/dom/SVGViewSpec.html, svg/dom/viewspec-parser.html failing on GTK Linux 64-bit Release
410         https://bugs.webkit.org/show_bug.cgi?id=87734
411
412         Reviewed by Martin Robinson.
413
414         When willSendRequest should return null in testing, cancel the SoupMessage
415         instead of setting the request's URI to about:blank.
416
417         * DumpRenderTree/gtk/DumpRenderTree.cpp:
418         (willSendRequestCallback):
419
420 2012-12-10  Jochen Eisinger  <jochen@chromium.org>
421
422         [chromium] Move the test implementation of WebKit::WebPlugin to the TestRunner library
423         https://bugs.webkit.org/show_bug.cgi?id=104537
424
425         Reviewed by Tony Chang.
426
427         In order to hide implementation details from the public TestRunner API,
428         I moved the plugin to WebTestPluginImpl and added a static create
429         method to WebTestPlugin. Also, I renamed the plugin from TestWebPlugin
430         to WebTestPlugin to be more in line with other classes in the
431         TestRunner API.
432
433         * DumpRenderTree/DumpRenderTree.gypi:
434         * DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h: Added.
435         (WebTestRunner):
436         (WebTestPlugin):
437         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestWebPlugin.cpp.
438         (WebTestRunner::WebTestPlugin::create):
439         (WebTestRunner):
440         (WebTestRunner::WebTestPlugin::WebTestPlugin):
441         (WebTestRunner::WebTestPlugin::~WebTestPlugin):
442         (WebTestRunner::WebTestPlugin::mimeType):
443         * DumpRenderTree/chromium/TestWebPlugin.h: Removed.
444         * DumpRenderTree/chromium/WebViewHost.cpp:
445         (WebViewHost::createPlugin):
446
447 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
448
449         run_webkit_tests throws exception when DRT is not present
450         https://bugs.webkit.org/show_bug.cgi?id=104565
451
452         Reviewed by Jochen Eisinger.
453
454         Don't actually try to print the bot results if there aren't
455         any because we exited before running any tests.
456
457         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
458         (main):
459         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
460         (MainTest.test_build_check):
461
462 2012-12-10  Benjamin Poulain  <benjamin@webkit.org>
463
464         Add convenience methods to use ListHashSet for a LRU cache
465         https://bugs.webkit.org/show_bug.cgi?id=104499
466
467         Reviewed by Sam Weinig.
468
469         Test the new methods added to ListHashSet.
470
471         * TestWebKitAPI/CMakeLists.txt:
472         * TestWebKitAPI/GNUmakefile.am:
473         * TestWebKitAPI/TestWebKitAPI.gypi:
474         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
475         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp: Added.
476         (TestWebKitAPI):
477         (TestWebKitAPI::TEST):
478
479 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
480
481         webkit-patch print-expectations doesn't work right for platforms w/ shared expectations
482         https://bugs.webkit.org/show_bug.cgi?id=104405
483
484         Reviewed by Eric Seidel.
485
486         If multiple ports shared a TestExpectations file, webkit-patch
487         print-expectations would use the expectation for the first port
488         using that file and print the result for all ports, rather than
489         re-parse and print each port separately (e.g., we might print
490         the chromium-linux expectation for a file for both chromium-linux
491         and chromium-mac). Discovered while testing/debugging the fix
492         for bug 104403.
493
494         * Scripts/webkitpy/layout_tests/port/test.py:
495         (TestPort._skipped_tests_for_unsupported_features):
496         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
497         (lint):
498         * Scripts/webkitpy/tool/commands/queries.py:
499         (PrintExpectations._model):
500         * Scripts/webkitpy/tool/commands/queries_unittest.py:
501         (PrintExpectationsTest.test_platform):
502
503 2012-12-10  Dirk Pranke  <dpranke@chromium.org>
504
505         nrwt: fix total number of tests computed in the result summary
506         https://bugs.webkit.org/show_bug.cgi?id=104061
507
508         Reviewed by Jochen Eisinger.
509
510         Good thing I left this open, because I actually broke it again
511         the same way in a merge. Fix the computation of the one_line_summary
512         again, and add tests for it (also clean up some redundant tests).
513
514         Also, add constants into the test port code so that the knowledge
515         of how many tests should fail and how is next to the list of tests,
516         rather than a totally different place.
517
518         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
519         (LayoutTestRunner.run_tests):
520         * Scripts/webkitpy/layout_tests/port/test.py:
521         (TestList.__getitem__):
522         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
523         (get_test_results):
524         (MainTest.setUp):
525         (MainTest.test_basic):
526         (MainTest.test_run_singly_actually_runs_tests):
527         (MainTest.test_test_list_with_prefix):
528         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code.CustomExitCodePort):
529         (MainTest.test_tolerance.ImageDiffTestPort):
530         (EndToEndTest.parse_full_results):
531
532 2012-12-10  Mike West  <mkwst@chromium.org>
533
534         Log to console when script is blocked by sandbox attributes.
535         https://bugs.webkit.org/show_bug.cgi?id=104365
536
537         Reviewed by Ojan Vafai.
538
539         * Scripts/webkitpy/performance_tests/perftest.py:
540         (PerfTest):
541             Ignoring the new console message in perftests, as it broke parsing
542             for the Parser/html-parser.html microbenchmark.
543
544 2012-12-10  Filip Pizlo  <fpizlo@apple.com>
545
546         JSC profiling and debug dump code should use inferred names when possible
547         https://bugs.webkit.org/show_bug.cgi?id=104519
548
549         Reviewed by Oliver Hunt.
550
551         The format I'm using for referring to a code block is now name#hash. For example,
552         v8-crypto has something called bnpSquareTo#B5QFbU. The profiler allows you to use
553         either the hash, the inferred name, or the combined hash and full name when referring
554         to blocks.
555
556         * Scripts/display-profiler-output:
557
558 2012-12-09  Filip Pizlo  <fpizlo@apple.com>
559
560         Profiler should say things about OSR exits
561         https://bugs.webkit.org/show_bug.cgi?id=104497
562
563         Reviewed by Oliver Hunt.
564
565         Adds support for displaying OSR exit information for full summary (just displays the
566         counts and the number of recompilations), bytecode display (says which bytecodes
567         exited), and DFG display (annotates disassembly with taken OSR exits and their
568         counts).
569
570         * Scripts/display-profiler-output:
571
572 2012-12-10  Alexis Menard  <alexis@webkit.org>
573
574         [CSS3 Backgrounds and Borders] Remove CSS3_BACKGROUND feature flag.
575         https://bugs.webkit.org/show_bug.cgi?id=104539
576
577         Reviewed by Antonio Gomes.
578
579         As discussed on webkit-dev it is not needed to keep this feature flag 
580         as support for <position> type is a small feature that is already 
581         implemented by three other UAs. It was useful while landing this 
582         feature as partial bits were landed one after one.
583
584         * Scripts/webkitperl/FeatureList.pm:
585         * qmake/mkspecs/features/features.pri:
586
587 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
588
589         Build fix.
590
591         Add a patchfile missing from my previous commit.
592
593         * gtk/patches/harfbuzz-icu-detection-fix.patch: Added.
594
595 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
596
597         REGRESSION(137127): Causes assertion failures on the debug bots
598         https://bugs.webkit.org/show_bug.cgi?id=104549
599
600         Reviewed by Alejandro G. Castro.
601
602         After handling the new TextOutput message we should return the method
603         handling messages received.
604
605         * WebKitTestRunner/TestInvocation.cpp:
606         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a missing early return.
607
608 2012-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
609
610         [Soup] utilize multipart/x-mixed-replace support recently added to libsoup
611         https://bugs.webkit.org/show_bug.cgi?id=94515
612
613         Reviewed by Martin Robinson.
614
615         This change requires a very recent libsoup, so update our jhbuild
616         requirements.
617
618         * gtk/jhbuild.modules: depend on soup version that adds the multipart/x-mixed-replace
619         support
620         * efl/jhbuild.modules: ditto
621
622 2012-12-10  Zoltan Nyul  <zoltan.nyul@intel.com>
623
624         Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner
625         https://bugs.webkit.org/show_bug.cgi?id=103886
626
627         Reviewed by Kenneth Rohde Christiansen.
628
629         Implement testRunner.setViewModeMediaFeature() in WebKitTestRunner.
630         This API is required by layout tests.
631
632         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
633         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
634         (WTR::TestRunner::setViewModeMediaFeature):
635         (WTR):
636         * WebKitTestRunner/InjectedBundle/TestRunner.h:
637         (TestRunner):
638
639 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
640
641         [GTK] Bring Harfbuzz-ng support to Gtk
642         https://bugs.webkit.org/show_bug.cgi?id=92098
643
644         Reviewed by Gustavo Noronha Silva.
645
646         Add HarfBuzz dependency.
647
648         * GNUmakefile.am: Add FreeType/HarfBuzz CFLAGS to the WebCore Internals library.
649         * gtk/jhbuild.modules: Add HarfBuzz to the JHbuild and remove Pango, since it
650         should no longer affect layout test results.
651
652 2012-12-10  Simon Hausmann  <simon.hausmann@digia.com>
653
654         [Qt] Use QLibraryInfo::LibraryExecutablesPath unconditionally
655         https://bugs.webkit.org/show_bug.cgi?id=104541
656
657         Reviewed by Jocelyn Turcotte.
658
659         We now depend on a Qt 5 version that is guaranteed to have this API, so we
660         can remove the configure checks for it.
661
662         * qmake/config.tests/libexecdir/libexecdir.cpp: Removed.
663         * qmake/config.tests/libexecdir/libexecdir.pro: Removed.
664         * qmake/mkspecs/features/features.prf:
665
666 2012-12-10  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
667
668         REGRESSION(r135863): GtkLauncher --help no longer displays all help options
669         https://bugs.webkit.org/show_bug.cgi?id=104382
670
671         Reviewed by Philippe Normand.
672
673         Remove gst_init() because it steals the GOptionContext.
674         gst_init_get_option_group() already does the initialization job.
675
676         * GtkLauncher/main.c:
677         (main):
678
679 2012-12-10  Zan Dobersek  <zandobersek@gmail.com>
680
681         [GTK][WTR] Implement AccessibilityUIElement::titleUIElement
682         https://bugs.webkit.org/show_bug.cgi?id=102953
683
684         Reviewed by Martin Robinson.
685
686         Implement AccessibilityUIElement::titleUIElement in the ATK backend
687         in the same manner it is implemented in DumpRenderTree. Both implementations
688         are updated to unref the relation set before the final function return
689         rather than at the end of each loop through the relations held in the said
690         relation set.
691
692         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
693         (AccessibilityUIElement::titleUIElement):
694         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
695         (WTR::AccessibilityUIElement::titleUIElement):
696
697 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
698
699         Fix the WebKit2 debug build
700
701         * WebKitTestRunner/TestInvocation.cpp:
702         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Fix a typo of WKStringGetTypeID().
703
704 2012-12-10  Martin Robinson  <mrobinson@igalia.com>
705
706         [WTR] Move text output accumulation to the UIProcess
707         https://bugs.webkit.org/show_bug.cgi?id=104214
708
709         Reviewed by Darin Adler.
710
711         Instead of accumulating text output in the InjectedBundle and then sending it to the UIProcess 
712         once a test is finished, immediately send any text output to the UIProcess. This will allow
713         WebKitTestRunner to output text from the UIProcess as well.
714
715         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Remove the handling of the text output
716         StringBuilder. Add a method to send output to the UIProcess.
717         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
718         (InjectedBundle):
719         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Change code that appends to the StringBuilder
720         to use the new outputText method.
721         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
722         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Ditto.
723         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp: Ditto.
724         * WebKitTestRunner/TestInvocation.cpp:
725         (WTR::TestInvocation::TestInvocation): Intialize the StringBuilder.
726         (WTR::TestInvocation::invoke): Clear the StringBuilder when a new tests starts.
727         (WTR::TestInvocation::dumpResults): m_textOutput is a StringBuilder now so the
728         method of printing the text is slightly different.
729         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the new TextOutput
730         message by appending the results to the StringBuilder.
731         * WebKitTestRunner/TestInvocation.h:
732         (TestInvocation): Switch the type of m_textOutput.
733
734 2012-12-10  Mihnea Ovidenie  <mihnea@adobe.com>
735
736         Unreviewed. Adding Mihai Maerean to the list of contributors, working on CSSRegions.
737
738         * Scripts/webkitpy/common/config/committers.py:
739
740 2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
741
742         [GTK] accessibility/language-attribute.html is failing
743         https://bugs.webkit.org/show_bug.cgi?id=98369
744
745         Reviewed by Chris Fleizach.
746
747         The test is failing for two reasons: Not exposing the language
748         for accessible objects and AccessibilityUIElement::language() not
749         being implemented.
750
751         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
752         (AccessibilityUIElement::language): Implemented.
753
754 2012-12-10  Joanmarie Diggs  <jdiggs@igalia.com>
755
756         [GTK] accessibility/editable-webarea-context-menu-point.html is failing
757         https://bugs.webkit.org/show_bug.cgi?id=98364
758
759         Reviewed by Chris Fleizach.
760
761         The test is failing because the clickPoint values remain unchanged. The
762         values remain unchanged because ATK lacks a means to keep track of this
763         information.
764
765         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
766         (AccessibilityUIElement::clickPointX): Added comment that ATK doesn't have clickPoint details
767         (AccessibilityUIElement::clickPointY): Added comment that ATK doesn't have clickPoint details
768
769 2012-12-09  Alejandro Piñeiro  <apinheiro@igalia.com>
770
771         [GTK] lack of implemention of AccessibilityUIElementGtk::isSelectable and AccessibilityUIElementGtk::isMultiSelectable
772         https://bugs.webkit.org/show_bug.cgi?id=104481
773
774         Reviewed by Martin Robinson.
775
776         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
777         (AccessibilityUIElement::isSelectable): Implement this by checking
778         the current state of the AtkObject.
779         (AccessibilityUIElement::isMultiSelectable): Implement this by
780         checking the current state of the AtkObject.
781
782 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
783
784         [GTK] accessibility/placeholder.html is failing
785         https://bugs.webkit.org/show_bug.cgi?id=98373
786
787         Reviewed by Martin Robinson.
788
789         The test was failing because the placeholder text was not supported and
790         AccessibilityUIElement::stringAttributeValue() was not implemented.
791
792         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
793         (coreAttributeToAtkAttribute): New convenience method to convert WebCore attribute
794         names into AtkObject attribute names
795         (AccessibilityUIElement::stringAttributeValue): implemented
796
797 2012-12-09  Dan Winship  <danw@gnome.org>
798
799         [GTK] Bump libxml2 requirement in jhbuild.modules
800         https://bugs.webkit.org/show_bug.cgi?id=104477
801
802         Reviewed by Martin Robinson.
803
804         Fedora 18's Apache depends on symbols in libxml2 2.9.0, so the
805         tests won't run if we only have libxml2 2.8.0 installed in the
806         jhbuild root.
807
808         * gtk/jhbuild.modules:
809
810 2012-12-09  Zan Dobersek  <zandobersek@gmail.com>
811
812         Remove testRunner.disableImageLoading()
813         https://bugs.webkit.org/show_bug.cgi?id=98083
814
815         Reviewed by Gustavo Noronha Silva.
816
817         Remove the disableImageLoading methods and callback.
818         No tests use the method anymore and all ports except Wx
819         now support this behavior through overriding the
820         WebKitDisplayImagesKey preference.
821
822         * DumpRenderTree/TestRunner.cpp:
823         (TestRunner::staticFunctions):
824         * DumpRenderTree/TestRunner.h:
825         (TestRunner):
826         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
827         (TestRunner::overridePreference): Add support for overriding the
828         WebKitDisplayImagesKey preference which is now the preferred way
829         of disabling image loading.
830         * DumpRenderTree/efl/TestRunnerEfl.cpp:
831         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
832         * DumpRenderTree/mac/TestRunnerMac.mm:
833         * DumpRenderTree/qt/TestRunnerQt.cpp:
834         * DumpRenderTree/qt/TestRunnerQt.h:
835         (TestRunner):
836         * DumpRenderTree/win/TestRunnerWin.cpp:
837         * DumpRenderTree/wx/TestRunnerWx.cpp:
838
839 2012-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
840
841         [GTK] accessibility/label-for-control-hittest.html is failing
842         https://bugs.webkit.org/show_bug.cgi?id=98368
843
844         Reviewed by Martin Robinson.
845
846         The test was failing because AccessibilityUIElement::elementAtPoint was
847         not implemented.
848
849         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
850         (AccessibilityUIElement::elementAtPoint): implemented
851
852 2012-12-09  Jon Lee  <jonlee@apple.com>
853
854         [WK2] Move button image to injected bundle
855         https://bugs.webkit.org/show_bug.cgi?id=104107
856         <rdar://problem/12813842>
857
858         Reviewed by Simon Fraser.
859
860         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
861         (WTR::InjectedBundlePage::InjectedBundlePage): Update the bundle page UI client.
862
863 2012-12-08  Halton Huo  <halton.huo@intel.com>
864
865         [CMake] Add CMake style checker
866         https://bugs.webkit.org/show_bug.cgi?id=104240
867
868         Reviewed by Eric Seidel.
869
870         The CMake style checker is followed by existing style checkers like cpp, python.
871         Unit test is added as well.
872
873         * Scripts/webkitpy/style/checker.py: Use CMakeChecker CMAKE type files(.cmake or CMakeLists.txt)
874         (FileType):
875         (CheckerDispatcher._file_type):
876         (CheckerDispatcher._create_checker):
877         * Scripts/webkitpy/style/checkers/cmake.py: Added.
878         (CMakeChecker):
879         (CMakeChecker.__init__): 
880         (CMakeChecker.check):
881         (CMakeChecker._process_line):
882         (CMakeChecker._check_trailing_whitespace):
883         (CMakeChecker._check_no_space_cmds):
884         (CMakeChecker._check_one_space_cmds):
885         (CMakeChecker._check_non_lowercase_cmd):
886         (CMakeChecker._check_indent):
887         * Scripts/webkitpy/style/checkers/cmake_unittest.py: Added.
888         (CMakeCheckerTest):
889         (CMakeCheckerTest.test_init):
890         (CMakeCheckerTest.test_init._mock_handle_style_error):
891         (CMakeCheckerTest.test_check):
892         (CMakeCheckerTest.test_check._mock_handle_style_error):
893
894 2012-12-08  Kondapally Kalyan  <kalyan.kondapally@intel.com>
895
896         [EFL] Enable WebGL by default.
897         https://bugs.webkit.org/show_bug.cgi?id=102991.
898
899         Reviewed by Kenneth Rohde Christiansen.
900
901         Enable WebGL by default.
902
903         * Scripts/webkitperl/FeatureList.pm:
904
905 2012-12-07  Scott Violet  <sky@chromium.org>
906
907         [chromium] Remove linux theme related files and switch to default
908         https://bugs.webkit.org/show_bug.cgi?id=103897
909
910         Reviewed by Dimitri Glazkov.
911
912         * Scripts/webkitpy/common/config/build_unittest.py:
913         (ShouldBuildTest): linux->default
914
915 2012-12-07  Mike Lattanzio  <mlattanzio@rim.com>
916
917         [BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
918         https://bugs.webkit.org/show_bug.cgi?id=104121
919
920         Reviewed by Rob Buis.
921
922         Update createBuffer call to reflect new BufferType enum.
923         Internal PR 254649
924         Internal Review: Jakob Petsovits
925
926         DRT is always backed for maximum compatibility.
927
928         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
929         (createBitmapContextFromWebView):
930
931 2012-12-07  Jochen Eisinger  <jochen@chromium.org>
932
933         Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
934         https://bugs.webkit.org/show_bug.cgi?id=104355
935
936         Reviewed by Dirk Pranke.
937
938         This enables chromium's content_shell driver to run with the full SUID
939         sandbox.
940
941         * Scripts/webkitpy/layout_tests/port/base.py:
942         (Port.to.setup_environ_for_server):
943
944 2012-12-07  KyungTae Kim  <ktf.kim@samsung.com>
945
946         [EFL] Fix tools for WebKit2-only builds
947         https://bugs.webkit.org/show_bug.cgi?id=103904
948
949         Reviewed by Laszlo Gombos.
950
951         The libewebkit2.so should be used for library path for EFL WebKit2.
952
953         * Scripts/webkitdirs.pm:
954         (builtDylibPathForName):
955
956 2012-12-07  Xiaobo Wang  <xbwang@torchmobile.com.cn>
957
958         [BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
959         https://bugs.webkit.org/show_bug.cgi?id=104243
960
961         RIM PR 259337
962
963         Reviewed by Rob Buis.
964
965         1. Implement calculation of navigation originating in
966         didDecidePolicyForNavigationAction().
967         2. Implement policy delegate for resource response.
968         3. Enable customPolicyDelegate if waitForPolicyDelegate() is called.
969         4. Minor optional updates in dump() and dumpFrameLoadCallbacks().
970
971         The patch fixed the following tests:
972         - http/tests/download
973         - fast/forms/mailto/formenctype-attribute-button-html.html
974         - fast/forms/mailto/formenctype-attribute-input-html.html
975         - fast/encoding/mailto-always-utf-8.html
976
977         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
978         (BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
979         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
980         (BlackBerry::WebKit::DumpRenderTree::dump):
981         (BlackBerry::WebKit::DumpRenderTree::didFinishLoadForFrame):
982         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForNavigationAction):
983         (BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForResponse):
984         (BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate):
985         * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
986         (DumpRenderTree):
987         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
988         (TestRunner::setCustomPolicyDelegate):
989         (TestRunner::waitForPolicyDelegate):
990         (TestRunner::overridePreference):
991
992 2012-12-07  Gwang Yoon Hwang  <ryumiel@company100.net>
993
994         [Qt] Adjust library name in layout_tests/port/qt.py after Qt5-r40
995         https://bugs.webkit.org/show_bug.cgi?id=104348
996
997         Reviewed by Csaba Osztrogonác.
998
999         After Qt-5.0.0-r40, the library was renamed from QtWebKitWidgets to
1000         Qt5WebKitWidgets. run-webkit-tests were still looking for QtWebKitWidgets
1001
1002         * Scripts/webkitpy/layout_tests/port/qt.py:
1003         (QtPort._path_to_webcore_library):
1004
1005 2012-12-07  Csaba Osztrogonác  <ossy@webkit.org>
1006
1007         Unreviewed fix, unbreak run-launcher after library renaming.
1008
1009         * Scripts/webkitdirs.pm:
1010         (builtDylibPathForName):
1011
1012 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1013
1014         Unreviewed fix after r136896, unbreak --debug-rwt to make bots result verbose again.
1015         https://bugs.webkit.org/show_bug.cgi?id=104296
1016
1017         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1018         (main):
1019
1020 2012-12-06  Rick Byers  <rbyers@chromium.org>
1021
1022         CSS cursor property should support webkit-image-set
1023         https://bugs.webkit.org/show_bug.cgi?id=99493
1024
1025         Reviewed by Beth Dakin.
1026
1027         Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default
1028
1029         * Scripts/webkitperl/FeatureList.pm:
1030         * qmake/mkspecs/features/features.pri:
1031
1032 2012-12-06  Vivek Galatage  <vivek.vg@samsung.com>
1033
1034         Unreviewed. Fixing the email address order to work correctly with bugzilla.
1035
1036         * Scripts/webkitpy/common/config/committers.py:
1037
1038 2012-12-06  Jochen Eisinger  <jochen@chromium.org>
1039
1040         [chromium] when forwarding events through the WebPluginContainer, create a UserGestureIndicator if processing a user gesture
1041         https://bugs.webkit.org/show_bug.cgi?id=104306
1042
1043         Reviewed by Dimitri Glazkov.
1044
1045         * DumpRenderTree/chromium/TestWebPlugin.cpp:
1046         (TestWebPlugin::TestWebPlugin):
1047         (TestWebPlugin::handleInputEvent): add support for printing the user gesture status
1048         * DumpRenderTree/chromium/TestWebPlugin.h:
1049         (TestWebPlugin):
1050
1051 2012-12-06  Dirk Pranke  <dpranke@chromium.org>
1052
1053         new-run-webkit-tests --lint-test-files seems to be broken
1054         https://bugs.webkit.org/show_bug.cgi?id=104296
1055
1056         Unreviewed, build fix.
1057
1058         My recent refactoring caused me to not initialize the printer
1059         before calling lint(); this patch restructures the code to make
1060         the lint routine self-contained and do all the work necessary.
1061         This will also make it easier to move this code out into a standalone
1062         file.
1063
1064         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1065         (lint):
1066         (main):
1067         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1068         (LintTest.test_all_configurations):
1069         (LintTest.test_lint_test_files):
1070         (LintTest.test_lint_test_files__errors):
1071
1072 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1073
1074         DFG profiler should be helpful about gem installation
1075         https://bugs.webkit.org/show_bug.cgi?id=104217
1076
1077         Reviewed by Oliver Hunt.
1078         
1079         'json' and 'highline' are not installed by default on the ruby distributions with
1080         which I am familiar, and the default error messages don't make me happy. This makes
1081         display-profiler-output print a helpful message if those gems are not found.
1082
1083         * Scripts/display-profiler-output:
1084
1085 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1086
1087         Profiler should print a helpful message if you pass the wrong arguments
1088         https://bugs.webkit.org/show_bug.cgi?id=104222
1089
1090         Reviewed by Oliver Hunt.
1091
1092         * Scripts/display-profiler-output:
1093
1094 2012-12-06  Ojan Vafai  <ojan@chromium.org>
1095
1096         Allow for CCing a secondary email address from watchlists
1097         https://bugs.webkit.org/show_bug.cgi?id=104286
1098
1099         Reviewed by Dirk Pranke.
1100
1101         Change my watchlist CC address so I can filter these separately from
1102         when people explicitly CC me and update the watchlist parser to allow that.
1103
1104         * Scripts/webkitpy/common/config/committers.py:
1105         * Scripts/webkitpy/common/config/watchlist:
1106         * Scripts/webkitpy/common/watchlist/watchlistparser.py:
1107         (WatchListParser._validate):
1108         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
1109         (WatchListParserTest.test_cc_rule_with_invalid_email):
1110         (WatchListParserTest.test_cc_rule_with_secondary_email):
1111
1112 2012-12-06  Max Vujovic  <mvujovic@adobe.com>
1113
1114         Unreviewed. Add myself to committers.py.
1115
1116         * Scripts/webkitpy/common/config/committers.py:
1117
1118 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
1119
1120         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
1121         https://bugs.webkit.org/show_bug.cgi?id=104139
1122
1123         Reviewed by Kenneth Rohde Christiansen.
1124
1125         Resize the window back to 800x600 between tests.
1126         This should be a no-op if the test did not resize the window.
1127
1128         * WebKitTestRunner/TestController.cpp:
1129         (WTR::TestController::resetStateToConsistentValues):
1130
1131 2012-12-06  Tommy Widenflycht  <tommyw@google.com>
1132
1133         Speech Recognition API: Change the error code to a string on SpeechRecognitionError
1134         https://bugs.webkit.org/show_bug.cgi?id=104254
1135
1136         Reviewed by Adam Barth.
1137
1138         Changes the mock error function to take a string instead of an int.
1139
1140         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1141         (DRTTestRunner::setMockSpeechRecognitionError):
1142         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
1143         (WebTestRunner::ErrorTask::ErrorTask):
1144         (MockWebSpeechRecognizer::setError):
1145         * DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
1146         (MockWebSpeechRecognizer):
1147
1148 2012-12-06  Andras Becsi  <andras.becsi@digia.com>
1149
1150         [Qt][Mac] Fix libxslt and libxml2 config tests
1151         https://bugs.webkit.org/show_bug.cgi?id=104164
1152
1153         Reviewed by Simon Hausmann.
1154
1155         We should not use pkg-config on Mac instead use direct include
1156         paths and add needed libraries to the linker options to detect
1157         libxslt and libxml2 provided by the system.
1158         Previously we would always fall back to qtxmlpatterns.
1159
1160         * qmake/config.tests/libxml2/libxml2.pro:
1161         * qmake/config.tests/libxslt/libxslt.pro:
1162
1163 2012-12-06  Csaba Osztrogonác  <ossy@webkit.org>
1164
1165         [Qt] Fix the build if the path contains "+" character
1166         https://bugs.webkit.org/show_bug.cgi?id=104120
1167
1168         Reviewed by Tor Arne Vestbø.
1169
1170         The second parameter of qmake's replace() is regular expression, so
1171         we have to escape special characters in paths passed to replace().
1172
1173         * qmake/mkspecs/features/default_post.prf:
1174         * qmake/mkspecs/features/default_pre.prf:
1175         * qmake/mkspecs/features/functions.prf:
1176
1177 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1178
1179         Unreviewed, rolling out r136825.
1180         http://trac.webkit.org/changeset/136825
1181         https://bugs.webkit.org/show_bug.cgi?id=104251
1182
1183         It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
1184         flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).
1185
1186         * WebKitTestRunner/TestController.cpp:
1187         (WTR::TestController::resetStateToConsistentValues):
1188
1189 2012-12-06  Yael Aharon  <yael.aharon@intel.com>
1190
1191         [EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
1192         https://bugs.webkit.org/show_bug.cgi?id=104139
1193
1194         Reviewed by Kenneth Rohde Christiansen.
1195
1196         Resize the window back to 800x600 between tests.
1197         This should be a no-op if the test did not resize the window.
1198
1199         * WebKitTestRunner/TestController.cpp:
1200         (WTR::TestController::resetStateToConsistentValues):
1201
1202 2012-12-06  Sheriff Bot  <webkit.review.bot@gmail.com>
1203
1204         Unreviewed, rolling out r136784 and r136802.
1205         http://trac.webkit.org/changeset/136784
1206         http://trac.webkit.org/changeset/136802
1207         https://bugs.webkit.org/show_bug.cgi?id=104231
1208
1209         breaks chromium canary (Requested by morrita on #webkit).
1210
1211         * Scripts/webkitpy/common/config/build_unittest.py:
1212         (ShouldBuildTest):
1213
1214 2012-12-05  Ryosuke Niwa  <rniwa@webkit.org>
1215
1216         Add myself to watch changes in PerformanceTests/*.
1217
1218         * Scripts/webkitpy/common/config/watchlist:
1219
1220 2012-12-05  Shinya Kawanaka  <shinyak@chromium.org>
1221
1222         [Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
1223         https://bugs.webkit.org/show_bug.cgi?id=102459
1224
1225         Reviewed by Dimitri Glazkov.
1226
1227         Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.
1228
1229         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
1230         (WebThemeControlDRTWin::markState):
1231
1232 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1233
1234         DFG profiler should be able to display where a code block was inlined into, and what it inlined
1235         https://bugs.webkit.org/show_bug.cgi?id=104216
1236
1237         Reviewed by Oliver Hunt.
1238
1239         Added an "inlines" command that shows the inline stacks that a code block participated
1240         in. Also cleaned up some of the ways we print compilation units.
1241
1242         * Scripts/display-profiler-output:
1243
1244 2012-12-05  Halton Huo  <halton.huo@intel.com>
1245
1246         [CMake] Unify coding style for CMake files
1247         https://bugs.webkit.org/show_bug.cgi?id=103605
1248
1249         Reviewed by Laszlo Gombos.
1250
1251         Update cmake files(.cmake, CMakeLists.txt) with following style rules:
1252         1. Indentation
1253         1.1 Use spaces, not tabs.
1254         1.2 Four spaces as indent.
1255         2. Spacing
1256         2.1 Place one space between control statements and their parentheses.
1257             For eg, if (), else (), elseif (), endif (), foreach (),
1258             endforeach (), while (), endwhile (), break ().
1259         2.2 Do not place spaces between function and macro statements and
1260             their parentheses. For eg, macro(), endmacro(), function(),
1261             endfunction().
1262         2.3 Do not place spaces between a command or function or macro and its
1263             parentheses, or between a parenthesis and its content. For eg,
1264             message("testing") not message( "testing") or message ("testing" )
1265         2.4 No space at line ending.
1266         3. Lowercase when call commands macros and functions. For eg,
1267            add_executable() not ADD_EXECUTABLE(), set() not SET().
1268
1269         * CMakeLists.txt:
1270         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1271         * DumpRenderTree/efl/CMakeLists.txt:
1272         * EWebLauncher/CMakeLists.txt:
1273         * EWebLauncher/ControlTheme/CMakeLists.txt:
1274         * MiniBrowser/efl/CMakeLists.txt:
1275         * TestWebKitAPI/CMakeLists.txt:
1276         * TestWebKitAPI/PlatformEfl.cmake:
1277         * WebKitTestRunner/CMakeLists.txt:
1278         * WebKitTestRunner/PlatformEfl.cmake:
1279         * WinCELauncher/CMakeLists.txt:
1280         * clang/ReportMemoryUsagePlugin/CMakeLists.txt:
1281
1282 2012-12-05  Scott Violet  <sky@chromium.org>
1283
1284         [chromium] Remove linux theme related files and switch to default
1285         https://bugs.webkit.org/show_bug.cgi?id=103897
1286
1287         Reviewed by Tony Chang.
1288
1289         * Scripts/webkitpy/common/config/build_unittest.py:
1290         (ShouldBuildTest): linux->default
1291
1292 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1293
1294         nrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w/ between master and worker
1295         https://bugs.webkit.org/show_bug.cgi?id=78168
1296
1297         Reviewed by Ojan Vafai.
1298
1299         This patch adds a single ordered list to ResultSummary that contains
1300         the results of every test run in order of result received, and
1301         modifies the TestResults class to contain the list of references used
1302         for each test as well as the pid of the driver; this allows us to stop
1303         having to override the test drivers to record the tests, and makes the
1304         integration tests that test rdering, retries, restarts, etc. black-box
1305         tests.
1306
1307         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
1308         (SingleTestRunner._run_rebaseline):
1309         (SingleTestRunner._compare_output):
1310         (SingleTestRunner._run_reftest):
1311         (SingleTestRunner._compare_output_with_reference):
1312         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1313         (ResultSummary.__init__):
1314         (ResultSummary.add):
1315         * Scripts/webkitpy/layout_tests/models/test_results.py:
1316         (TestResult.__init__):
1317         * Scripts/webkitpy/layout_tests/port/driver.py:
1318         (DriverOutput.__init__):
1319         (Driver.run_test):
1320         * Scripts/webkitpy/layout_tests/port/test.py:
1321         (TestDriver):
1322         (TestDriver.__init__):
1323         (TestDriver.run_test):
1324         (TestDriver.stop):
1325         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1326         (get_tests_run):
1327         (get_test_batches):
1328         (get_test_results):
1329         (MainTest.test_batch_size):
1330         (MainTest.test_dryrun):
1331         (MainTest.test_natural_order):
1332         (MainTest.test_natural_order_test_specified_multiple_times):
1333         (MainTest.test_random_order):
1334         (MainTest.test_random_order_test_specified_multiple_times):
1335         (MainTest.test_no_order):
1336         (MainTest.test_no_order_test_specified_multiple_times):
1337         (MainTest.test_no_order_with_directory_entries_in_natural_order):
1338         (MainTest.test_repeat_each):
1339         (MainTest.test_ignore_flag):
1340         (MainTest.test_skipped_flag):
1341         (MainTest.test_iterations):
1342         (MainTest.test_run_chunk):
1343         (MainTest.test_run_part):
1344         (MainTest.test_run_singly):
1345         (MainTest.test_skip_failing_tests):
1346         (MainTest.test_single_file):
1347         (MainTest.test_single_file_with_prefix):
1348         (MainTest.test_single_skipped_file):
1349         (MainTest.test_test_list):
1350         (MainTest.test_test_list_with_prefix):
1351         (MainTest.test_exit_after_n_failures):
1352         (MainTest.test_exit_after_n_crashes):
1353         (MainTest.test_run_order__inline):
1354         (MainTest.test_reftest_run):
1355         (MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
1356         (MainTest.test_reftest_skip_reftests_if_no_ref_tests):
1357         (MainTest.test_reftest_expected_html_should_be_ignored):
1358         (MainTest.test_reftest_driver_should_run_expected_html):
1359         (MainTest.test_reftest_driver_should_run_expected_mismatch_html):
1360         (MainTest.test_no_http_tests):
1361         (MainTest.test_platform_tests_are_found):
1362
1363 2012-12-05  Dana Jansens  <danakj@chromium.org>
1364
1365         [chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
1366         https://bugs.webkit.org/show_bug.cgi?id=103967
1367
1368         Reviewed by James Robinson.
1369
1370         Use the WebCompositorSupport methods to create an OutputSurface. If they
1371         fail, then fall back to the WebViewHost methods.
1372
1373         Once the chromium side lands, the WebCompositorSupport methods will stop
1374         failing, and will replace the WebViewHost ones.
1375
1376         * DumpRenderTree/chromium/WebViewHost.cpp:
1377         (WebViewHost::createOutputSurface):
1378
1379 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1380
1381         nrwt: split all of the buildbot-specific output into its own file
1382         https://bugs.webkit.org/show_bug.cgi?id=104165
1383
1384         Reviewed by Ojan Vafai.
1385
1386         Now that we have the RunDetails object we can move all of the
1387         buildbot-specific knowledge out of the core test-running code
1388         and into the outermost run_webkit_tests layer.
1389
1390         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1391         (run):
1392         (main):
1393         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1394         (passing_run):
1395         (logging_run):
1396         (run_and_capture):
1397         (MainTest.test_all):
1398         (MainTest.test_max_locked_shards):
1399         (MainTest.test_child_processes_2):
1400         (MainTest.test_child_processes_min):
1401         (MainTest.test_full_results_html):
1402         (MainTest.test_hung_thread):
1403         (MainTest.test_keyboard_interrupt):
1404         (MainTest.test_no_tests_found):
1405         (MainTest.test_no_tests_found_2):
1406         (MainTest.test_repeat_each_iterations_num_tests):
1407         (MainTest.test_run_singly_actually_runs_tests):
1408         (MainTest.test_test_list):
1409         (MainTest.test_unexpected_failures):
1410         (MainTest.test_missing_and_unexpected_results):
1411         (MainTest.test_pixel_test_directories):
1412         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
1413         (MainTest.test_crash_with_stderr):
1414         (MainTest.test_no_image_failure_with_image_diff):
1415         (MainTest.test_crash_log):
1416         (MainTest.test_web_process_crash_log):
1417         (MainTest.test_exit_after_n_failures_upload):
1418         (MainTest.test_results_directory_absolute):
1419         (MainTest.test_results_directory_default):
1420         (MainTest.test_results_directory_relative):
1421         (MainTest.test_retrying_and_flaky_tests):
1422         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1423         (MainTest.test_output_diffs):
1424         (MainTest.test_unsupported_platform):
1425         (MainTest.test_verbose_in_child_processes):
1426         (EndToEndTest.test_end_to_end):
1427         (EndToEndTest.test_reftest_with_two_notrefs):
1428         (RebaselineTest.test_reset_results):
1429         (RebaselineTest.test_missing_results):
1430         (RebaselineTest.test_new_baseline):
1431         * Scripts/webkitpy/layout_tests/views/buildbot_results.py: Added.
1432         (BuildBotPrinter):
1433         (BuildBotPrinter.__init__):
1434         (BuildBotPrinter.print_results):
1435         (BuildBotPrinter._print):
1436         (BuildBotPrinter.print_result_summary):
1437         (BuildBotPrinter._print_result_summary_entry):
1438         (BuildBotPrinter.print_unexpected_results):
1439         (BuildBotPrinter.print_unexpected_results.add_to_dict_of_lists):
1440         (BuildBotPrinter.print_unexpected_results.add_result):
1441         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py: Added.
1442         (BuildBotPrinterTests):
1443         (BuildBotPrinterTests.assertEmpty):
1444         (BuildBotPrinterTests.assertNotEmpty):
1445         (BuildBotPrinterTests.get_printer):
1446         (BuildBotPrinterTests.get_result):
1447         (BuildBotPrinterTests.get_result_summary):
1448         (BuildBotPrinterTests.test_print_unexpected_results):
1449         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
1450         * Scripts/webkitpy/layout_tests/views/printing.py:
1451         (Printer):
1452         (Printer.__init__):
1453         (Printer.print_results):
1454         (Printer._print_statistics_for_test_timings):
1455         (Printer._print_baseline):
1456         (Printer._print_debug):
1457         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1458         (Testprinter.get_printer):
1459         (Testprinter.get_result):
1460         (Testprinter.test_configure_and_cleanup):
1461         (Testprinter.test_print_config):
1462         (Testprinter.test_print_one_line_summary):
1463         (Testprinter.test_test_status_line):
1464         (Testprinter.test_details):
1465
1466 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1467
1468         nrwt: collect all of the information about a run into a new RunDetails class
1469         https://bugs.webkit.org/show_bug.cgi?id=104158
1470
1471         Reviewed by Ojan Vafai.
1472
1473         This patch collects the information from both test passes (the
1474         main one and the retries) as well as the summarized results and
1475         the exit code into a RunDetails class, so that the integration
1476         tests can more easily tell what happened.
1477
1478         Also, change the way the --lint-test-files works slightly so that
1479         we don't need to create a printer object (and hence we need to
1480         rework the tests that are testing logging).
1481
1482         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1483         (RunDetails):
1484         (RunDetails.__init__):
1485         (Manager.run):
1486         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1487         (run):
1488         (main):
1489         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1490         (passing_run):
1491         (run_and_capture):
1492         (LintTest.test_lint_test_files):
1493         (LintTest.test_lint_test_files__errors):
1494         (MainTest.test_verbose_in_child_processes):
1495
1496 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1497
1498         nrwt: remove --no-record-results
1499         https://bugs.webkit.org/show_bug.cgi?id=104072
1500
1501         Reviewed by Ojan Vafai.
1502
1503         The command line flag was only being used in the unit tests and
1504         wasn't really needed once we started using a mock filesystem.
1505
1506         Also, reformat a bunch of long lines ...
1507
1508         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1509         (Manager.run):
1510         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1511         (parse_args):
1512         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1513         (parse_args):
1514         (passing_run):
1515         (logging_run):
1516         (MainTest.test_repeat_each_iterations_num_tests):
1517         (MainTest.test_test_list):
1518         (MainTest.test_missing_and_unexpected_results):
1519         (MainTest.test_pixel_test_directories):
1520         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
1521         (MainTest.test_crash_with_stderr):
1522         (MainTest.test_no_image_failure_with_image_diff):
1523         (MainTest.test_crash_log):
1524         (MainTest.test_web_process_crash_log):
1525         (MainTest.test_exit_after_n_failures_upload):
1526         (MainTest.test_results_directory_absolute):
1527         (MainTest.test_results_directory_relative):
1528         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1529         (MainTest.test_additional_expectations):
1530         (MainTest.test_output_diffs):
1531         (EndToEndTest.test_end_to_end):
1532         (EndToEndTest.test_reftest_with_two_notrefs):
1533         (RebaselineTest.test_reset_results):
1534         (RebaselineTest.test_missing_results):
1535         (RebaselineTest.test_new_baseline):
1536
1537 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1538
1539         nrwt: only summarize the results one way
1540         https://bugs.webkit.org/show_bug.cgi?id=104064
1541
1542         Reviewed by Ojan Vafai.
1543
1544         Change manager.summarize_results so that we always (and only)
1545         include both expected and unexpected results. Previously we
1546         would summarize the results twice, once with expected results
1547         and once without. This made the code much more confusing than
1548         it needed to be.
1549
1550         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1551         (summarize_results):
1552         (Manager.run):
1553         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1554         (ResultSummaryTest.summarized_results):
1555         (ResultSummaryTest.test_no_svn_revision):
1556         (ResultSummaryTest.test_svn_revision):
1557         (ResultSummaryTest.test_summarized_results_wontfix):
1558         * Scripts/webkitpy/layout_tests/views/printing.py:
1559         (Printer.print_results):
1560         (Printer._print_unexpected_results):
1561         (Printer._print_unexpected_results.add_result):
1562         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1563         (Testprinter.test_print_unexpected_results.get_unexpected_results):
1564         (Testprinter):
1565
1566 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1567
1568         DFG profiler should display more information
1569         https://bugs.webkit.org/show_bug.cgi?id=104163
1570
1571         Reviewed by Gavin Barraclough.
1572
1573         Added the following:
1574         
1575         - Distinguish between source counts and bytecode counts.
1576         
1577         - Add a "full" summary view that shows both kinds of counts, plus inline counts.
1578         
1579         - Add a "source" command to see the source.
1580         
1581         - Add a "bytecode" command to see the bytecode and counts.
1582
1583         * Scripts/display-profiler-output:
1584
1585 2012-12-05  Yong Li  <yoli@rim.com>
1586
1587         [BlackBerry] Build with libjpegturbo
1588         https://bugs.webkit.org/show_bug.cgi?id=104152
1589
1590         Reviewed by Rob Buis.
1591
1592         RIM PR# 196975.
1593         Make sure the right include path for libjpeg is included.
1594
1595         * Scripts/webkitdirs.pm:
1596         (blackberryCMakeArguments):
1597
1598 2012-12-05  Joseph Pecoraro  <pecoraro@apple.com>
1599
1600         Remove stale check in check-for-webkit-framework-include-consistency
1601         https://bugs.webkit.org/show_bug.cgi?id=103775
1602
1603         Reviewed by David Kilzer.
1604
1605         The underlying issue was fixed in r81173.
1606
1607         * Scripts/check-for-webkit-framework-include-consistency:
1608
1609 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1610
1611         nrwt: simplify the finding of tests to retry
1612         https://bugs.webkit.org/show_bug.cgi?id=104067
1613
1614         Reviewed by Ryosuke Niwa.
1615
1616         I think this makes the code a little clearer; note that
1617         we were no longer using the include_missing flag.
1618
1619         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1620         (Manager.run):
1621         (Manager._failed_test_names):
1622
1623 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1624
1625         nrwt: remove two unused parameters from a function
1626         https://bugs.webkit.org/show_bug.cgi?id=104059
1627
1628         Reviewed by Ryosuke Niwa.
1629
1630         Also remove an old, stale FIXME.
1631
1632         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1633         (interpret_test_failures):
1634         (summarize_results):
1635         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1636         (ResultSummaryTest.test_interpret_test_failures):
1637
1638 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1639
1640         nrwt: return result_summaries from LayoutTestRunner.run_tests()
1641         https://bugs.webkit.org/show_bug.cgi?id=104051
1642
1643         Reviewed by Ojan Vafai.
1644
1645         This patch completes the refactoring that makes the result summary      
1646         an object returned from the layout test runner, rather than having      
1647         it passed in and modified. This makes the split of duties between       
1648         the manager and runner clearer and makes the data flow more             
1649         functionally.                                                           
1650
1651         Also clean up some minor lint issues.
1652
1653         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1654         (LayoutTestRunner.__init__):
1655         (LayoutTestRunner.run_tests):
1656         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
1657         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1658         (FakePrinter.print_expected):
1659         (LockCheckingRunner.__init__):
1660         (LayoutTestRunnerTests._runner):
1661         (LayoutTestRunnerTests._run_tests):
1662         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
1663         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1664         (Manager.__init__):
1665         (Manager.run):
1666         (Manager._run_tests):
1667
1668 2012-12-05  Dirk Pranke  <dpranke@chromium.org>
1669
1670         nrwt: move creation of the resultsummary objects into Manager._run_tests()
1671         https://bugs.webkit.org/show_bug.cgi?id=104048
1672
1673         Reviewed by Ojan Vafai.
1674
1675         This is a preparatory step to making the resultsummary just get
1676         returned from the layout_test_runner; this does most of manager-side
1677         changes.
1678
1679         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1680         (Manager._prepare_lists):
1681         (Manager.run):
1682         (Manager._run_tests):
1683
1684 2012-12-05  Leo Yang  <leoyang@rim.com>
1685
1686         [BlackBerry] Enable CSS_IMAGE_RESOLUTION
1687         https://bugs.webkit.org/show_bug.cgi?id=104132
1688
1689         Reviewed by Yong Li.
1690
1691         * Scripts/webkitperl/FeatureList.pm:
1692
1693 2012-12-05  Filip Pizlo  <fpizlo@apple.com>
1694
1695         JSC profiler should not count executions of op_call_put_result because doing so changes DFG codegen
1696         https://bugs.webkit.org/show_bug.cgi?id=104102
1697
1698         Reviewed by Oliver Hunt.
1699
1700         Modify the profiler to not output counts for op_call_put_result, since there
1701         won't be any. Also fix a few weird bugs, like providing better error reporting
1702         when you type something incorrectly and not reporting counts for slow paths
1703         in the old JIT since those counts are actually not what you think they are
1704         (we don't actually count slow path executions separately).
1705
1706         * Scripts/display-profiler-output:
1707
1708 2012-12-05  Andras Becsi  <andras.becsi@digia.com>
1709
1710         Fix compilation for Qt5.0.0 stable branch.
1711         https://bugs.webkit.org/show_bug.cgi?id=103870
1712
1713         Reviewed by Simon Hausmann.
1714
1715         Fix the use of renamed QWindow functions.
1716         Patch by Andras Becsi <andras.becsi@digia.com>
1717
1718         * MiniBrowser/qt/BrowserWindow.cpp:
1719         (BrowserWindow::BrowserWindow):
1720         (BrowserWindow::onTitleChanged):
1721         * MiniBrowser/qt/raw/View.cpp:
1722         (View::View):
1723
1724 2012-12-05  Jussi Kukkonen  <jussi.kukkonen@intel.com>
1725
1726         [WK2] InjectedBundle should check Intent url for null
1727         https://bugs.webkit.org/show_bug.cgi?id=104117
1728
1729         Reviewed by Kenneth Rohde Christiansen.
1730
1731         WKIntentServiceInfoCopyHref() can return null, we need to check
1732         for that in InjectedBundlePage::registerIntentServiceForFrame()
1733         to avoid crashing.
1734
1735         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1736         (WTR::InjectedBundlePage::registerIntentServiceForFrame):
1737
1738 2012-12-04  Jonathan Dong  <jonathan.dong@torchmobile.com.cn>
1739
1740         Change email address of Jonathan Dong
1741         https://bugs.webkit.org/show_bug.cgi?id=103976
1742
1743         Unreviewed, change my email address from jonathan.dong@torchmobile.com.cn
1744         to jonathan.dong.webkit@gmail.com in committers list.
1745
1746         * Scripts/webkitpy/common/config/committers.py:
1747
1748 2012-12-04  Xiaobo Wang  <xbwang@torchmobile.com.cn>
1749
1750         [BlackBerry] DRT - Tests under "dumpAsText" directory should be dumped as text
1751         https://bugs.webkit.org/show_bug.cgi?id=103986
1752
1753         Reviewed by Rob Buis.
1754
1755         Also move declaration of webSettingTransaction to before any WebSettings
1756         ::setXXX() calls so that it works as expected (commit only once in the
1757         function scope).
1758
1759         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
1760         (shouldDumpAsText):
1761         (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
1762
1763 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1764
1765         display-profiler-output should be able to show source code
1766         https://bugs.webkit.org/show_bug.cgi?id=104073
1767
1768         Reviewed by Oliver Hunt.
1769
1770         Display source code in the summary, using a one-line shortening.
1771
1772         * Scripts/display-profiler-output:
1773
1774 2012-12-04  Filip Pizlo  <fpizlo@apple.com>
1775
1776         display-profiler-output should not use reflective infocation to resolve command names
1777
1778         Rubber stamped by Mark Hahnenberg.
1779
1780         Reflection is amazing, but here it was just kind of a bit much.
1781
1782         * Scripts/display-profiler-output:
1783
1784 2012-12-02  Filip Pizlo  <fpizlo@apple.com>
1785
1786         JSC should be able to report profiling data associated with the IR dumps and disassembly
1787         https://bugs.webkit.org/show_bug.cgi?id=102999
1788
1789         Reviewed by Gavin Barraclough.
1790
1791         Added a tool that allows you to grok the output from JSC's new profiler. Currently,
1792         this still gets confused a bit about the execution counts of a method running
1793         standalone versus a method running inlined, but other than that, it's pretty cool.
1794         See the attached "sampling profiling session" attached to the bug to see it in
1795         action.
1796         
1797         Also had to feed EFL's build system.
1798
1799         * DumpRenderTree/efl/CMakeLists.txt:
1800         * Scripts/display-profiler-output: Added.
1801
1802 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1803
1804         nrwt: fix total number of tests computed in the result summary
1805         https://bugs.webkit.org/show_bug.cgi?id=104061
1806
1807         Unreviewed, build fix.
1808
1809         One of the recent changes to the resultsummary refactoring caused
1810         us to not include the number of skipped tests in the total number
1811         of tests, throwing off the totals printed in print_one_line_summary().
1812
1813         Unfortunately, given the current state of the code it is difficult
1814         to construct an accurate unit test for this. I have verified the
1815         fix by hand, and will write a test once the remaining refactoring
1816         patches land, at which point it will be trivial to test it.
1817
1818         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1819         (Manager._prepare_lists):
1820
1821 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1822
1823         nrwt is not returning the exit status properly
1824         https://bugs.webkit.org/show_bug.cgi?id=103830
1825
1826         Unreviewed, build fix.
1827
1828         The fix in r136474 wasn't quite right either, and would return
1829         the correct exceptional status, but not the correct failing status.
1830
1831         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1832
1833 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1834
1835         nrwt: make paths and test_names passed arguments in Manager._prepare_lists et al
1836         https://bugs.webkit.org/show_bug.cgi?id=104047
1837
1838         Reviewed by Eric Seidel.
1839
1840         The code becomes cleaner if we are just passing values around rather
1841         than hanging them off the manager object, helps move _prepare_lists()
1842         to a pure function, and is needed to eventually make the
1843         result_summary object something returned from runner.run_tests()
1844         (note that two more patches are needed for that to happen).
1845
1846         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1847         (Manager.__init__):
1848         (Manager._http_tests):
1849         (Manager._prepare_lists):
1850         (Manager.needs_servers):
1851         (Manager._set_up_run):
1852         (Manager.run):
1853         (Manager._run_tests):
1854         (Manager._upload_json_files):
1855         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1856         (ManagerTest.test_needs_servers.get_manager):
1857         (ManagerTest.test_needs_servers):
1858         (ManagerTest.integration_test_needs_servers.get_manager):
1859         (ManagerTest.integration_test_needs_servers):
1860         (ManagerTest.test_look_for_new_crash_logs.get_manager):
1861         (ManagerTest):
1862         (ManagerTest.test_look_for_new_crash_logs):
1863         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1864         (JSONLayoutResultsGenerator.__init__):
1865         (JSONLayoutResultsGenerator._get_modifier_char):
1866
1867 2012-12-04  Adam Barth  <abarth@webkit.org>
1868
1869         commit-queue can get stuck with a local commit
1870         https://bugs.webkit.org/show_bug.cgi?id=104032
1871
1872         Reviewed by Dirk Pranke.
1873
1874         Previously the commit-queue would only clean down to HEAD. If the
1875         commit-queue gets interrupted in the middle of a commit (e.g., after
1876         the local commit but before the dcommit), then it can end up with a
1877         patch locally committed. That patch will then prevent the commit-queue
1878         from functioning.
1879
1880         This patch teaches the commit-queue to clean down to the merge base,
1881         which will remove any local commits.
1882
1883         * Scripts/webkitpy/common/checkout/scm/git.py:
1884         (Git.working_directory_is_clean):
1885         (Git.clean_working_directory):
1886         * Scripts/webkitpy/tool/commands/roll_unittest.py:
1887         * Scripts/webkitpy/tool/steps/commit.py:
1888         (Commit._commit_warning):
1889         (Commit.run):
1890
1891 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1892
1893         nrwt: store only the total number of tests in the result summary
1894         https://bugs.webkit.org/show_bug.cgi?id=103963
1895
1896         Reviewed by Ryosuke Niwa.
1897
1898         The result summary only needs the total number of tests that will
1899         be run (including repetitions) in order to provide the correct stats;
1900         it doesn't actually need to know how many unique tests there are, or
1901         or how many repetitions there are.
1902
1903         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1904         (LayoutTestRunnerTests._result_summary):
1905         (LayoutTestRunnerTests.test_update_summary_with_result):
1906         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1907         (Manager._prepare_lists):
1908         (Manager.run):
1909         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1910         (ManagerTest.test_look_for_new_crash_logs):
1911         (ResultSummaryTest.get_result_summary):
1912         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1913         (ResultSummary.__init__):
1914         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1915         (Testprinter.get_result_summary):
1916
1917 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1918
1919         nrwt: do less work when ctrl-c'ed
1920         https://bugs.webkit.org/show_bug.cgi?id=103961
1921
1922         Reviewed by Ryosuke Niwa.
1923
1924         Do less work when we are ctrl-c'ed, because the statistics aren't
1925         that useful anyway. While we're at it, modify summarize_results
1926         to be aware that we don't always retry results (instead of pretending
1927         that the retry produced the same results the initial run did).
1928
1929         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1930         (summarize_results):
1931         (Manager.run):
1932
1933 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1934
1935         nrwt: result summaries should not require a list of tests to skip
1936         https://bugs.webkit.org/show_bug.cgi?id=103951
1937
1938         Reviewed by Ryosuke Niwa.
1939
1940         We shouldn't really be passing a list of tests to skip to the
1941         ResultSummary objects; they should be handled like any other
1942         test result as much as possible.
1943
1944         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
1945         (LayoutTestRunnerTests._result_summary):
1946         (LayoutTestRunnerTests.test_update_summary_with_result):
1947         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1948         (Manager._prepare_lists):
1949         (Manager.run):
1950         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1951         (ManagerTest.test_look_for_new_crash_logs):
1952         (ResultSummaryTest.get_result_summary):
1953         * Scripts/webkitpy/layout_tests/models/result_summary.py:
1954         (ResultSummary.__init__):
1955         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1956         (TestExpectations):
1957         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
1958         (Testprinter.get_result_summary):
1959
1960 2012-12-04  Dirk Pranke  <dpranke@chromium.org>
1961
1962         nrwt: derive per-thread, per-worker stats from result summaries
1963         https://bugs.webkit.org/show_bug.cgi?id=103943
1964
1965         Reviewed by Ojan Vafai.
1966
1967         This patch changes the manager and printing code to pull more           
1968         information from the ResultSummary object rather than tracking          
1969         additional statistics on the side. This allows us to consolidate        
1970         a bunch of logic and remove a bunch of free-floating lists and dicts of 
1971         of values. We add the shard_name and worker_name to each TestResult,    
1972         and then modify print_timing_statistics() and upload_json_files()       
1973         to just need the result summaries.                                      
1974
1975         Note that this patch also changes the timing statistics slightly
1976         so that the individual test times are the times to run just the
1977         tests themselves (TestResult.test_run_time) and do not include the
1978         times taken to run the ref tests, compute diffs, etc. The aggregated
1979         per-worker and per-shard statistics still use the total time to
1980         process each test (TestResult.total_run_time).
1981
1982         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1983         (LayoutTestRunner.__init__):
1984         (LayoutTestRunner.run_tests):
1985         (LayoutTestRunner._handle_finished_test_list):
1986         (LayoutTestRunner._handle_finished_test):
1987         (Worker.handle):
1988         (Worker._run_test):
1989         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1990         (summarize_results):
1991         (Manager.run):
1992         (Manager._upload_json_files):
1993         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1994         (ResultSummaryTest.summarized_results):
1995         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1996         (JSONLayoutResultsGenerator.__init__):
1997         (JSONLayoutResultsGenerator._get_test_timing):
1998         * Scripts/webkitpy/layout_tests/models/test_results.py:
1999         (TestResult.__init__):
2000         * Scripts/webkitpy/layout_tests/views/printing.py:
2001         (Printer.print_results):
2002         (Printer._print_timing_statistics):
2003         (Printer):
2004         (Printer._print_worker_statistics):
2005         (Printer._print_aggregate_test_statistics):
2006         (Printer._print_individual_test_times):
2007         (Printer._print_directory_timings):
2008         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2009         (Testprinter.test_print_unexpected_results.get_unexpected_results):
2010         (Testprinter):
2011
2012 2012-12-04  Adam Barth  <abarth@webkit.org>
2013
2014         Remove obsolete code from webkitpy
2015         https://bugs.webkit.org/show_bug.cgi?id=104029
2016
2017         Reviewed by Eric Seidel.
2018
2019         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2020         (CommitQueueTask.run):
2021         * Scripts/webkitpy/tool/steps/commit.py:
2022         (Commit.options):
2023         * Scripts/webkitpy/tool/steps/options.py:
2024         (Options):
2025
2026 2012-12-04  Jochen Eisinger  <jochen@chromium.org>
2027
2028         [chromium] move WebPreferences and methods for modifying them to the TestRunner library
2029         https://bugs.webkit.org/show_bug.cgi?id=103841
2030
2031         Reviewed by Darin Fisher.
2032
2033         * DumpRenderTree/DumpRenderTree.gypi:
2034         * DumpRenderTree/chromium/DRTTestRunner.cpp:
2035         (DRTTestRunner::DRTTestRunner):
2036         (DRTTestRunner::reset):
2037         * DumpRenderTree/chromium/DRTTestRunner.h:
2038         (DRTTestRunner):
2039         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.h.
2040         (WebKit):
2041         (WebTestRunner):
2042         (WebPreferences):
2043         (WebTestRunner::WebPreferences::WebPreferences):
2044         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
2045         (WebTestRunner):
2046         (WebTestDelegate):
2047         (WebTestRunner::WebTestDelegate::localFileToDataURL):
2048         (WebTestRunner::WebTestDelegate::rewriteLayoutTestsURL):
2049         (WebTestRunner::WebTestDelegate::preferences):
2050         (WebTestRunner::WebTestDelegate::applyPreferences):
2051         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2052         (WebTestRunner::TestRunner::TestRunner):
2053         (WebTestRunner::TestRunner::reset):
2054         (WebTestRunner::TestRunner::setUserStyleSheetEnabled):
2055         (WebTestRunner):
2056         (WebTestRunner::TestRunner::setUserStyleSheetLocation):
2057         (WebTestRunner::TestRunner::setAuthorAndUserStylesEnabled):
2058         (WebTestRunner::TestRunner::setPopupBlockingEnabled):
2059         (WebTestRunner::TestRunner::setJavaScriptCanAccessClipboard):
2060         (WebTestRunner::TestRunner::setXSSAuditorEnabled):
2061         (WebTestRunner::TestRunner::setAllowUniversalAccessFromFileURLs):
2062         (WebTestRunner::TestRunner::setAllowFileAccessFromFileURLs):
2063         (WebTestRunner::TestRunner::overridePreference):
2064         (WebTestRunner::TestRunner::setPluginsEnabled):
2065         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2066         (TestRunner):
2067         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPreferences.cpp.
2068         (WebTestRunner::WebPreferences::reset):
2069         (WebTestRunner):
2070         (WebTestRunner::WebPreferences::applyTo):
2071         * DumpRenderTree/chromium/TestShell.h:
2072         (TestShell::preferences):
2073         (TestShell):
2074         * DumpRenderTree/chromium/WebViewHost.cpp:
2075         (WebViewHost::localFileToDataURL):
2076         (WebViewHost::rewriteLayoutTestsURL):
2077         (WebViewHost::preferences):
2078         (WebViewHost::applyPreferences):
2079         * DumpRenderTree/chromium/WebViewHost.h:
2080         (WebViewHost):
2081
2082 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
2083
2084         Many webkitpy unit tests can be run standalone, are executable
2085         https://bugs.webkit.org/show_bug.cgi?id=103900
2086
2087         Reviewed by Eric Seidel.
2088
2089         There's no need anymore to run unit tests in standalone mode as they
2090         are now handled by test-webkitpy in a formidable fashion. This makes
2091         it possible for this patch to remove the following unnecessary bits:
2092         - remove shebang lines from unit test files,
2093         - remove calls to unittest.main(),
2094         - make unit test files non-executable.
2095
2096         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
2097         (DiffParserTest.test_git_mnemonicprefix):
2098         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2099         (GitTestWithMock.test_push_local_commits_to_server_without_username_and_with_password):
2100         * Scripts/webkitpy/common/config/build_unittest.py:
2101         (ShouldBuildTest.test_should_build):
2102         * Scripts/webkitpy/common/config/ports_unittest.py:
2103         (DeprecatedPortTest.test_chromium_xvfb_port):
2104         * Scripts/webkitpy/common/find_files_unittest.py:
2105         (TestWinNormalize.test_win):
2106         * Scripts/webkitpy/common/lru_cache_unittest.py:
2107         (LRUCacheTest.test_set_again):
2108         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2109         (test_results_zip_url):
2110         * Scripts/webkitpy/common/net/credentials_unittest.py:
2111         (test_keyring_without_git_repo_nor_keychain):
2112         * Scripts/webkitpy/common/net/omahaproxy_unittest.py:
2113         (OmahaProxyTest.test_get_revisions):
2114         * Scripts/webkitpy/common/net/unittestresults_unittest.py:
2115         * Scripts/webkitpy/common/newstringio_unittest.py:
2116         (NewStringIOTest.test_with):
2117         * Scripts/webkitpy/common/read_checksum_from_png_unittest.py:
2118         (ReadChecksumFromPngTest.test_read_checksum):
2119         * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
2120         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
2121         (MockFileSystemTest.test_normpath):
2122         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2123         (RealFileSystemTest.test_sep):
2124         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2125         (TestPlatformInfo.test_total_bytes_memory):
2126         * Scripts/webkitpy/common/system/zipfileset_unittest.py:
2127         (ZipFileSetTest.test_namelist):
2128         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2129         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2130         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2131         (TestResultWriterTest.test_reftest_diff_image):
2132         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
2133         (JSONGeneratorTest.test_test_timings_trie):
2134         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2135         (TestExpectationSerializationTests.test_string_whitespace_stripping):
2136         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2137         (KeyCompareTest.test_test_key):
2138         * Scripts/webkitpy/layout_tests/port/builders_unittest.py:
2139         (BuildersTest.test_path_from_name):
2140         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
2141         (ChromiumAndroidTwoPortsTest.test_options_with_two_ports):
2142         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
2143         (ChromiumLinuxPortTest.test_path_to_image_diff):
2144         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2145         (ChromiumMacPortTest.test_path_to_image_diff):
2146         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
2147         (ChromiumPortLoggingTest.test_check_sys_deps):
2148         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2149         (ChromiumPortLoggingTest.test_check_sys_deps):
2150         * Scripts/webkitpy/layout_tests/port/config_unittest.py:
2151         (ConfigTest.test_default_configuration__scripterror):
2152         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
2153         (DriverTest.test_start_actually_starts):
2154         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2155         (FactoryTest.test_get_from_builder_name):
2156         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
2157         * Scripts/webkitpy/layout_tests/port/image_diff_unittest.py:
2158         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2159         * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py:
2160         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2161         (PortTest.disabled_test_mac_lion):
2162         * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py:
2163         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
2164         (VerboseTest.test_log_args):
2165         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2166         (test_details):
2167         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2168         (TestPerfTestFactory.test_inspector_test):
2169         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2170         (test_parse_args):
2171         * Scripts/webkitpy/style/checker_unittest.py:
2172         * Scripts/webkitpy/style/checkers/changelog_unittest.py:
2173         (ChangeLogCheckerTest.test_no_error):
2174         * Scripts/webkitpy/style/checkers/common_unittest.py:
2175         (TabCheckerTest.test_tab):
2176         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2177         (CppCheckerTest.test_ne):
2178         * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
2179         * Scripts/webkitpy/style/checkers/png_unittest.py:
2180         (PNGCheckerTest.test_check):
2181         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
2182         * Scripts/webkitpy/style/checkers/text_unittest.py:
2183         (TextCheckerTest.test_init):
2184         * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
2185         * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
2186         (XcodeProjectFileCheckerTest.test_detect_development_region):
2187         * Scripts/webkitpy/style/checkers/xml_unittest.py:
2188         (XMLCheckerTest.test_no_error):
2189         * Scripts/webkitpy/style/patchreader_unittest.py:
2190         * Scripts/webkitpy/test/finder_unittest.py:
2191         (FinderTest.test_paths):
2192         * Scripts/webkitpy/test/runner_unittest.py:
2193         (RunnerTest.test_run):
2194         * Scripts/webkitpy/test/skip_unittest.py:
2195         (SkipTest.test_skip_if_true):
2196         * Scripts/webkitpy/thirdparty/__init___unittest.py:
2197         (ThirdpartyTest.test_imports):
2198         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py:
2199         (TestTranslation.test_include_rewriting):
2200         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
2201         (QueueEngineTest.tearDown):
2202         * Scripts/webkitpy/tool/grammar_unittest.py:
2203         (GrammarTest.test_join_with_separators):
2204         * Scripts/webkitpy/tool/mocktool_unittest.py:
2205         (MockOptionsTest.test_kwarg__set):
2206         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
2207         (test_command_help):
2208
2209 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
2210
2211         Many webkitpy module files are executable, have shebang line
2212         https://bugs.webkit.org/show_bug.cgi?id=103985
2213
2214         Reviewed by Dirk Pranke.
2215
2216         Remove the executable bit from webkitpy module files that are
2217         unnecessarily executable. Remove the shebang line from webkitpy
2218         module files, they are of no use. Only non-third-party files are
2219         changed.
2220
2221         * Scripts/webkitpy/bindings/main.py:
2222         * Scripts/webkitpy/common/config/watchlist:
2223         * Scripts/webkitpy/common/find_files.py:
2224         * Scripts/webkitpy/common/lru_cache.py:
2225         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
2226         * Scripts/webkitpy/common/net/file_uploader.py:
2227         * Scripts/webkitpy/common/newstringio.py:
2228         * Scripts/webkitpy/common/read_checksum_from_png.py:
2229         * Scripts/webkitpy/common/system/autoinstall.py:
2230         * Scripts/webkitpy/common/system/file_lock.py:
2231         * Scripts/webkitpy/common/system/file_lock_mock.py:
2232         * Scripts/webkitpy/common/version_check.py:
2233         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2234         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2235         * Scripts/webkitpy/layout_tests/models/test_failures.py:
2236         * Scripts/webkitpy/layout_tests/models/test_input.py:
2237         * Scripts/webkitpy/layout_tests/port/__init__.py:
2238         * Scripts/webkitpy/layout_tests/port/base.py:
2239         * Scripts/webkitpy/layout_tests/port/builders.py:
2240         * Scripts/webkitpy/layout_tests/port/chromium.py:
2241         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2242         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
2243         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2244         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
2245         * Scripts/webkitpy/layout_tests/port/config.py:
2246         * Scripts/webkitpy/layout_tests/port/factory.py:
2247         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2248         * Scripts/webkitpy/layout_tests/port/image_diff.py:
2249         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2250         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2251         * Scripts/webkitpy/layout_tests/port/server_process.py:
2252         * Scripts/webkitpy/layout_tests/port/test.py:
2253         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2254         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
2255         * Scripts/webkitpy/layout_tests/servers/http_server.py:
2256         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
2257         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2258         * Scripts/webkitpy/layout_tests/views/metered_stream.py:
2259         * Scripts/webkitpy/layout_tests/views/printing.py:
2260         * Scripts/webkitpy/performance_tests/perftest.py:
2261         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2262         * Scripts/webkitpy/style/checkers/changelog.py:
2263         * Scripts/webkitpy/style/checkers/cpp.py:
2264         * Scripts/webkitpy/style/checkers/xcodeproj.py:
2265         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2266         (main): There's no need to run this module in standalone because
2267         it's wrapped by the Tools/Scripts/update-webgl-conformance-tests script.
2268         * Scripts/webkitpy/tool/commands/upload.py:
2269         * Scripts/webkitpy/tool/comments.py:
2270         * Scripts/webkitpy/tool/main.py:
2271
2272 2012-12-04  Ryosuke Niwa  <rniwa@webkit.org>
2273
2274         Add a Chromium Android Release (Perf) to the list of perf. bots.
2275
2276         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2277
2278 2012-12-04  Zan Dobersek  <zandobersek@gmail.com>
2279
2280         [GTK] Insert the jhbuild wrapper command at the beginning of the command list
2281         https://bugs.webkit.org/show_bug.cgi?id=103991
2282
2283         Reviewed by Martin Robinson.
2284
2285         Insert the Tools/gtk/run-with-jhbuild wrapper at the beginning of the
2286         command that's being formed in multiprocessing bootstrap. The wrapper is
2287         an executable Python script while the command being wrapped perhaps isn't
2288         and therefore requires the Python interpreter to be listed at the beginning
2289         of the command sublist that is then executed by the wrapper.
2290
2291         Specifically, the webkitpy/layout_tests/run_webkit_tests.py module file
2292         is about to lose the executable bit and the Python-signaling shebang line.
2293         The Jhbuild wrapper simply executes the command that's passed, but that errs
2294         in this case unless the Python executable is executed and the module file
2295         is passed to it as an argument.
2296
2297         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
2298         (run):
2299
2300 2012-12-04  Peter Beverloo  <peter@chromium.org>
2301
2302         Add the Chromium Android Release (Perf) bot
2303         https://bugs.webkit.org/show_bug.cgi?id=103891
2304
2305         Reviewed by Eric Seidel.
2306
2307         Add configuration for the bot itself. It will be triggered by the Chromium
2308         Android Release builder. When running for Android, the DownloadAndPerfTest
2309         factory will also add the OutputAndroidDeviceStatus step.
2310
2311         * BuildSlaveSupport/build.webkit.org-config/config.json:
2312         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2313         (DownloadAndPerfTestFactory.__init__):
2314
2315 2012-12-04  Peter Beverloo  <peter@chromium.org>
2316
2317         [Chromium] The ChromiumAndroidDriver constructor should not rely on adb being available
2318         https://bugs.webkit.org/show_bug.cgi?id=103758
2319
2320         Reviewed by Eric Seidel.
2321
2322         Lazily initialize the adb command parameters rather than initializing it in the
2323         constructor now that there is an assert if adb is not available on the system and
2324         we're not in a Chromium Android checkout.
2325
2326         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2327         (ChromiumAndroidDriver.__init__):
2328         (ChromiumAndroidDriver._push_file_if_needed):
2329         (ChromiumAndroidDriver._run_adb_command):
2330         (ChromiumAndroidDriver.cmd_line):
2331         (ChromiumAndroidDriver._start_once):
2332         (ChromiumAndroidDriver._read_prompt):
2333         (ChromiumAndroidDriver):
2334         (ChromiumAndroidDriver._adb_command):
2335
2336 2012-12-03  Ryosuke Niwa  <rniwa@webkit.org>
2337
2338         Dromaeo should report individual test result
2339         https://bugs.webkit.org/show_bug.cgi?id=99800
2340
2341         Reviewed by Eric Seidel.
2342
2343         Ignore subtest results spit out by Dromaeo tests.
2344
2345         * Scripts/webkitpy/performance_tests/perftest.py:
2346         (PerfTest): Added a line to ignore.
2347         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2348         (MainTest.test_parse_output_with_subtests): Added.
2349
2350 2012-12-03  Zan Dobersek  <zandobersek@gmail.com>
2351
2352         Unreviewed, functionality fix after r136437.
2353
2354         Calling sys.exit actually raises a SystemExit exception that
2355         is then handled in the second block and causes the script to
2356         return an 'exceptional' exit code rather than the code presenting
2357         the number of failed tests.
2358
2359         This is just a temporary fix to get the faultless bots green while
2360         they are unnecessarily red at the moment. The problem and a proper
2361         fix will be properly addressed.
2362
2363         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2364
2365 2012-12-03  Sheriff Bot  <webkit.review.bot@gmail.com>
2366
2367         Unreviewed, rolling out r136460.
2368         http://trac.webkit.org/changeset/136460
2369         https://bugs.webkit.org/show_bug.cgi?id=103958
2370
2371         This patch caused compile error when building DumpRenderTree
2372         (Requested by tasak on #webkit).
2373
2374         * Scripts/webkitpy/common/config/build_unittest.py:
2375         (ShouldBuildTest):
2376
2377 2012-12-03  Scott Violet  <sky@chromium.org>
2378
2379         [chromium] Remove linux theme related files and switch to default
2380         https://bugs.webkit.org/show_bug.cgi?id=103897
2381
2382         Reviewed by Darin Fisher.
2383
2384         * Scripts/webkitpy/common/config/build_unittest.py:
2385         (ShouldBuildTest): linux->default
2386
2387 2012-12-03  Roger Fong  <roger_fong@apple.com>
2388
2389         Disable WebKit2 API tests on Apple Windows port.
2390         https://bugs.webkit.org/show_bug.cgi?id=103929.
2391
2392         Reviewed by Timothy Horton.
2393
2394         * Scripts/run-api-tests:
2395         (runTestsBySuite):
2396
2397 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
2398
2399         webkitpy's run_webkit_tests should initialize the printer earlier on
2400         https://bugs.webkit.org/show_bug.cgi?id=103661
2401
2402         Reviewed by Eric Seidel.
2403
2404         Initialize the printer before computing the derived options
2405         from the command line arguments, so that we can safely log from
2406         port methods.
2407
2408         Also clean up a few miscellaneous lint warnings.
2409
2410         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
2411         (ChromiumAndroidPort.path_to_adb):
2412         * Scripts/webkitpy/layout_tests/port/mac.py:
2413         (MacPort.default_child_processes):
2414         (MacPort.sample_process):
2415         (MacPort.start_helper):
2416         (MacPort.stop_helper):
2417         (MacPort.nm_command):
2418         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2419         (test_default_child_processes):
2420         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2421         (run):
2422         (_set_up_derived_options):
2423
2424 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
2425
2426         webkitpy: autoinstaller is failing on windows
2427         https://bugs.webkit.org/show_bug.cgi?id=103699
2428
2429         Reviewed by Tony Chang.
2430
2431         Attempt to fix the python autoinstaller to work for pylint on win32
2432         again ... it turns out one of the dependent packages contains
2433         a write-protected test file and windows will choke when it tries to move
2434         it into place. Fortunately we can just delete the file prior to
2435         installing it in the final location, but we have to jump through
2436         a couple of hoops to do so.
2437
2438         Also, make sure that we're flattening nested module names like
2439         "logilab/common" into either safe basenames (logilab_common) or
2440         host-specific subdirs (logilab\common) as needed.
2441
2442         * Scripts/webkitpy/common/system/autoinstall.py:
2443         (AutoInstaller._url_downloaded_path):
2444         (AutoInstaller._install):
2445         (AutoInstaller.install):
2446         * Scripts/webkitpy/thirdparty/__init__.py:
2447         (AutoinstallImportHook._install_pylint):
2448
2449 2012-12-03  Dirk Pranke  <dpranke@chromium.org>
2450
2451         nrwt: clean up exception propagation / handling for interrupts and early exits
2452         https://bugs.webkit.org/show_bug.cgi?id=103830
2453
2454         Reviewed by Ojan Vafai.
2455
2456         The code for propagating early exits out of the test run was
2457         convoluted and hard to follow. By adjusting the WorkerException to
2458         derive from BaseException rather than Exception (which is a fair
2459         way of representing an error that was really unexpected/unrecoverable
2460         anyway) and pushing the TestRunInterruptedException into the
2461         ResultSummary (which is also fair since it was more of a result
2462         than an exception) this allows us to consolidate and clean up
2463         a bunch of the try/catch logic and pass fewer state flags around.
2464
2465         There are no real functional changes to this patch; there's an
2466         API change in that we stop exporting TestRunInterruptedException
2467         and WorkerException out of the Manager, and the existence of the
2468         MessagePool is now completely hidden.
2469
2470         * Scripts/webkitpy/common/message_pool.py:
2471         (WorkerException):
2472         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2473         (LayoutTestRunner.run_tests):
2474         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2475         (summarize_results):
2476         (Manager.run):
2477         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
2478         (ResultSummaryTest.summarized_results):
2479         * Scripts/webkitpy/layout_tests/models/result_summary.py:
2480         (ResultSummary.__init__):
2481         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2482         (run):
2483         (main):
2484         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2485         (MainTest.test_exception_raised.of):
2486         (MainTest.test_exception_raised):
2487         (MainTest.test_run_force):
2488         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
2489         (Testprinter.test_print_unexpected_results.get_unexpected_results):
2490         (Testprinter):
2491
2492 2012-12-03  Julien BRIANCEAU   <jbrianceau@nds.com>
2493
2494         Add Qt/SH4 build slave to build.webkit.org
2495         https://bugs.webkit.org/show_bug.cgi?id=103384
2496
2497         Reviewed by Csaba Osztrogonác.
2498
2499         * BuildSlaveSupport/build.webkit.org-config/config.json:
2500
2501 2012-12-03  Alexis Menard  <alexis@webkit.org>
2502
2503         Enable CSS3 background-position offset by default
2504         https://bugs.webkit.org/show_bug.cgi?id=103917
2505
2506         Reviewed by Benjamin Poulain.
2507
2508         Even though each port may enable or not the feature we still need
2509         to pass it at configure time otherwise it will be disabled.
2510
2511         * Scripts/webkitperl/FeatureList.pm:
2512
2513 2012-12-03  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2514
2515         Unreviewed. Adding myself to committers.py.
2516
2517         * Scripts/webkitpy/common/config/committers.py:
2518
2519 2012-12-03  Laszlo Gombos  <l.gombos@samsung.com>
2520
2521         [CMake] Enable building WebKit2-only build for the EFL port
2522         https://bugs.webkit.org/show_bug.cgi?id=103820
2523
2524         Reviewed by Gyuyoung Kim.
2525
2526         Set ENABLE_WEBKIT2 to OFF if build-webkit was run with --no-webkit2.
2527         Never set ENABLE_WEBKIT in build-webkit. This will simplyfy invoking
2528         cmake directly. Initialize $cmakeArgs to avoid potential
2529         warnings when running the script.
2530
2531         * Scripts/build-webkit:
2532
2533 2012-12-03  Tommy Widenflycht  <tommyw@google.com>
2534
2535         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
2536         https://bugs.webkit.org/show_bug.cgi?id=103407
2537
2538         Reviewed by Kentaro Hara.
2539
2540         Changing the mock to use the new results delivery API.
2541
2542         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2543
2544 2012-12-03  Alexis Menard  <alexis@webkit.org>
2545
2546         [Qt] Enable CSS3 background-position offsets by default.
2547         https://bugs.webkit.org/show_bug.cgi?id=103877
2548
2549         Reviewed by Tor Arne Vestbø.
2550
2551         Enable by default CSS3 background-position offsets.
2552
2553         * qmake/mkspecs/features/features.pri:
2554
2555 2012-12-03  KyungTae Kim  <ktf.kim@samsung.com>
2556
2557         [EFL][WK2] Use float variable for zoom levels for MiniBrowser
2558         https://bugs.webkit.org/show_bug.cgi?id=103863
2559
2560         Reviewed by Gyuyoung Kim.
2561
2562         Use float instead of int for zoomLevels variables for a clearer expression
2563
2564         * MiniBrowser/efl/main.c:
2565         (on_key_down):
2566
2567 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
2568
2569         [EFL][WK2] Add support for a zoom level setting to MiniBrowser
2570         https://bugs.webkit.org/show_bug.cgi?id=99285
2571
2572         Reviewed by Gyuyoung Kim.
2573
2574          Add support for a zoom level setting to MiniBrowser.
2575          Shortcuts for setting operations are same as common browsers:
2576          Ctrl + '+' to zoom in, Ctrl + '-' to zoom out and Ctrl + '0' to zoom to default.
2577
2578         * MiniBrowser/efl/main.c:
2579         (on_key_down):
2580
2581 2012-12-02  KyungTae Kim  <ktf.kim@samsung.com>
2582
2583         [EFL][WK2] ECORE_GETOPT_VALUE_BOOL need to be used for Eina_Bool
2584         https://bugs.webkit.org/show_bug.cgi?id=103835
2585
2586         Reviewed by Kentaro Hara.
2587
2588         Because legacy_behavior_enabled is Eina_Bool, ECORE_GETOPT_VALUE_BOOL need to be used
2589
2590         * MiniBrowser/efl/main.c:
2591         (elm_main):
2592
2593 2012-12-02  Mike West  <mkwst@chromium.org>
2594
2595         Garden-o-matic shouldn't die when blank JSON results are received.
2596         https://bugs.webkit.org/show_bug.cgi?id=103838
2597
2598         Reviewed by Adam Barth.
2599
2600         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
2601             If the JSONP string doesn't contain '(' or ')', return an empty object.
2602         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
2603             Check that this behavior stays in place.
2604
2605 2012-12-02  Eric Seidel  <eric@webkit.org>
2606
2607         run-perf-tests --profile should use iprofiler instead of instruments on Mac
2608         https://bugs.webkit.org/show_bug.cgi?id=103765
2609
2610         Unreviewed.  Updating the unittests after my previous change.
2611
2612         * Scripts/webkitpy/common/system/profiler_unittest.py:
2613         (ProfilerFactoryTest.test_basic):
2614
2615 2012-12-02  Julie Parent  <jparent@chromium.org>
2616
2617         Remove dead code in flakiness dashboard for obsolete buildDir option
2618         https://bugs.webkit.org/show_bug.cgi?id=103792
2619
2620         Reviewed by Dirk Pranke.
2621
2622         * TestResultServer/static-dashboards/dashboard_base.js:
2623         (initBuilders):
2624
2625 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
2626
2627         nrwt: clean up logic for retrying failed tests a bit
2628         https://bugs.webkit.org/show_bug.cgi?id=103829
2629
2630         Reviewed by Ojan Vafai.
2631
2632         The code for determining when to retry test failures and
2633         show the results.html file was awkward and could stand some
2634         cleaning up. This patch should have no functional changes.
2635
2636         The routine called _get_failures() returned a dict of test names
2637         to failure types, but we only ever used the names, so I've converted
2638         it to return a list (and renamed it); also, the show_results_html()
2639         file was calling that routine to figure out if anything failed, when
2640         the information was already in the result_summary (as either
2641         unexpected_results or total_failures), so we were doing unnecessary work.
2642
2643         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2644         (Manager.__init__):
2645         (Manager.run):
2646         (Manager._run_tests):
2647         (Manager._failed_test_names):
2648         (Manager._copy_results_html_file):
2649
2650 2012-12-02  Dirk Pranke  <dpranke@chromium.org>
2651
2652         nrwt: remove unused methods in manager.py
2653         https://bugs.webkit.org/show_bug.cgi?id=103828
2654
2655         Reviewed by Eric Seidel.
2656
2657         These two methods weren't being called by anything and were no
2658         longer needed.
2659
2660         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2661         (Manager._get_failures):
2662         (Manager._upload_json_files):
2663
2664 2012-12-02  Laszlo Gombos  <l.gombos@samsung.com>
2665
2666         Correct the spelling of the cmakeargs argument
2667         https://bugs.webkit.org/show_bug.cgi?id=103814
2668
2669         Reviewed by Darin Adler.
2670
2671         The script expects cmakeargs (plural), so lets get the
2672         documentation of the script report the same.
2673
2674         * Scripts/build-webkit:
2675
2676 2012-12-02  Mike West  <mkwst@chromium.org>
2677
2678         [gtk] Enable the CSP_NEXT runtime flag.
2679         https://bugs.webkit.org/show_bug.cgi?id=103810
2680
2681         Reviewed by Adam Barth.
2682
2683         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2684         (resetDefaultsToConsistentValues):
2685             Turn on the CSP_NEXT runtime flag when running tests under GTK.
2686
2687 2012-12-02  Eric Seidel  <eric@webkit.org>
2688
2689         run-perf-tests --profile should use iprofiler instead of instruments on Mac
2690         https://bugs.webkit.org/show_bug.cgi?id=103765
2691
2692         Reviewed by Ryosuke Niwa.
2693
2694         Stephanie pointed out that iprofiler is the newer command-line interface
2695         to replace /usr/bin/instruments in Instruments 4 (which according to the
2696         interblags is supported on everything since 10.6.6), so I've moved --profile
2697         to use iprofiler on Mac.
2698
2699         I also made the IProfiler class wait for iprofiler to complete so that
2700         iprofiler won't continue running after run-perf-tests is complete (and
2701         spam over the top of your shell output).
2702
2703         There are a couple of "got-chas" to this approach:
2704         1.  iprofiler will ask for your password the first time you run it, which may
2705             cause your first test to fail.  /usr/bin/instruments doesn't seem to do that.
2706         2.  iprofiler has nice (but kinda awkward for our purposes) support for separate
2707             directory and basename arguments, making IProfiler a somewhat awkward
2708             baseclass of SingleFileOutputProfiler
2709
2710         I suspect we'll iterate from here.  It does seem slightly faster than
2711         /usr/bin/instruments was.
2712
2713         * Scripts/webkitpy/common/system/profiler.py:
2714         (ProfilerFactory.create_profiler):
2715         (IProfiler):
2716         (IProfiler.__init__):
2717         (IProfiler.attach_to_pid):
2718
2719 2012-12-02  Yongjun Zhang  <yongjun_zhang@apple.com>
2720
2721         Need a method to close all idle localstorage databases immediately.
2722         https://bugs.webkit.org/show_bug.cgi?id=103469
2723
2724         Reviewed by David Kilzer.
2725
2726         Add an JS method to TestRunner, to enable testing closing idle local storage databases in
2727         DumpRenderTree layout tests.
2728
2729         * DumpRenderTree/TestRunner.cpp:
2730         (closeIdleLocalStorageDatabasesCallback):
2731         (TestRunner::staticFunctions):
2732         * DumpRenderTree/TestRunner.h:
2733         (TestRunner):
2734         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
2735         (TestRunner::closeIdleLocalStorageDatabases):
2736         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2737         (TestRunner::closeIdleLocalStorageDatabases):
2738         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2739         (TestRunner::closeIdleLocalStorageDatabases):
2740         * DumpRenderTree/mac/TestRunnerMac.mm:
2741         (TestRunner::closeIdleLocalStorageDatabases):
2742         * DumpRenderTree/win/TestRunnerWin.cpp:
2743         (TestRunner::closeIdleLocalStorageDatabases):
2744         * DumpRenderTree/wx/TestRunnerWx.cpp:
2745         (TestRunner::closeIdleLocalStorageDatabases):
2746
2747 2012-12-02  Yael Aharon  <yael.aharon@intel.com>
2748
2749         [EFL][WK2] MiniBrowser should have a legacy mode
2750         https://bugs.webkit.org/show_bug.cgi?id=103679
2751
2752         Reviewed by Kenneth Rohde Christiansen.
2753
2754         Add an option to start MiniBrowser in legacy mode.
2755
2756         * MiniBrowser/efl/main.c:
2757         (window_create):
2758         (elm_main):
2759
2760 2012-12-02  Sheriff Bot  <webkit.review.bot@gmail.com>
2761
2762         Unreviewed, rolling out r136236.
2763         http://trac.webkit.org/changeset/136236
2764         https://bugs.webkit.org/show_bug.cgi?id=103833
2765
2766         [chromium] Flakey crashes in SpeechRecognitionEvent::emma
2767         during GC. (Requested by mkwst on #webkit).
2768
2769         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2770
2771 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2772
2773         [XvfbDriver] XvfbDriverTest.test_next_free_display is flaky on builders using XvfbDriver
2774         https://bugs.webkit.org/show_bug.cgi?id=103806
2775
2776         Reviewed by Dirk Pranke.
2777
2778         There are occasional mishaps on builders where XvfbDriver doesn't properly
2779         clean up the Xvfb instance it was managing so the related guard lock files
2780         are still existing when the webkitpy unit tests are run. This can cause failures
2781         in XvfbDriverTest.test_next_free_display as the test tries to acquire displays
2782         with a specific number but is unable to due to the stale locks.
2783
2784         The solution to this is to use MockFileLock when inside unit test. This is achievable
2785         by creating a file lock through the SystemHost instance connected to the Port object,
2786         the latter available to the Driver.
2787
2788         * Scripts/webkitpy/common/system/file_lock_mock.py:
2789         (MockFileLock.acquire_lock): Return True to signal lock acquiring succeeded.
2790         (MockFileLock.release_lock): Return True to signal lock releasing succeeded.
2791         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
2792         (XvfbDriver._next_free_display): Create the file lock through a mockable way.
2793         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
2794         (XvfbDriverTest.test_next_free_display): Enable back the unit test.
2795
2796 2012-12-01  Zan Dobersek  <zandobersek@gmail.com>
2797
2798         [GTK] A11y tests in WK2 report badly-formatted AX roles
2799         https://bugs.webkit.org/show_bug.cgi?id=102947
2800
2801         Reviewed by Xan Lopez.
2802
2803         As in DRT, convert the ATK accessibility roles to corresponding AXRoles.
2804         These are expected in both tests and their baselines.
2805
2806         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2807         (WTR::roleToString):
2808         (WTR):
2809         (WTR::AccessibilityUIElement::role):
2810
2811 2012-11-30  Mike West  <mkwst@chromium.org>
2812
2813         CSP 1.1: Make the CSP_NEXT flag runtime enabled.
2814         https://bugs.webkit.org/show_bug.cgi?id=103652
2815
2816         Reviewed by Adam Barth.
2817
2818         Ensures that the new SecurityPolicy runtime flag is enabled for Chromium's tests.
2819
2820         * DumpRenderTree/chromium/TestShell.cpp:
2821         (TestShell::TestShell):
2822
2823 2012-11-30  Roger Fong  <roger_fong@apple.com>
2824
2825         Unreviewed. Removed temporary debugging change from DRT (r136300).
2826
2827         * DumpRenderTree/win/DumpRenderTree.cpp:
2828         (dump):
2829
2830 2012-11-30  Roger Fong  <roger_fong@apple.com>
2831
2832         Unreviewed. Temporary change to DRT for debugging purposes.
2833
2834         * DumpRenderTree/win/DumpRenderTree.cpp:
2835         (dump):
2836
2837 2012-11-29  Tommy Widenflycht  <tommyw@google.com>
2838
2839         Speech Recognition API: Update SpeechRecognitionEvent to match the specification
2840         https://bugs.webkit.org/show_bug.cgi?id=103407
2841
2842         Reviewed by Adam Barth.
2843
2844         Changing the mock to use the new results delivery API.
2845
2846         * DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
2847
2848 2012-11-30  Simon Hausmann  <simon.hausmann@digia.com>, Pierre Rossi  <pierre.rossi@digia.com>
2849
2850         [Qt] Separate Qt WebKit into Qt WebKit and Qt WebKit Widgets
2851         https://bugs.webkit.org/show_bug.cgi?id=99314
2852
2853         Reviewed by Tor Arne Vestbø.
2854
2855         This big change separates QtWebKit into QtWebKit and QtWebKitWidgets as
2856         shared libraries.
2857
2858         It's a big refactoring that mostly involves moving WebCore dependent
2859         code into QtWebKit and accessing it through exported QWebFrameAdapter
2860         and QWebPageAdapter classes.
2861
2862         * DumpRenderTree/qt/DumpRenderTree.pro:
2863         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2864         (WebCore::DumpRenderTree::dump): Adapt to internal API changes.
2865         * MiniBrowser/qt/MiniBrowser.pro:
2866         * Scripts/webkitpy/style/checker.py: Adapt Qt exceptions to new paths.
2867         * Scripts/webkitpy/style/checker_unittest.py:
2868         (GlobalVariablesTest.test_path_rules_specifier):
2869         * WebKitTestRunner/InjectedBundle/Target.pri:
2870         * qmake/mkspecs/features/default_post.prf:
2871         * qmake/mkspecs/features/webkit_modules.prf:
2872         * qmake/mkspecs/modules/webkitwidgets.prf: Removed.
2873
2874 2012-11-30  Csaba Osztrogonác  <ossy@webkit.org>
2875
2876         [Qt] Unreviewed trivial fix.
2877
2878         Add empty.cpp back, it was removed accidentally by r129092.
2879
2880         * qmake/config.tests/gccdepends/empty.cpp: Added.
2881
2882 2012-11-30  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
2883
2884         [Qt] Add support for prepare_docs and generate_docs
2885
2886         Follow-up to changes in Qt in how documentation is built.
2887
2888         Reviewed by Simon Hausmann.
2889
2890         * qmake/mkspecs/features/default_post.prf:
2891
2892 2012-11-30  Zan Dobersek  <zandobersek@gmail.com>
2893
2894         Finally remove webkitpy.common.system.deprecated_logging
2895         https://bugs.webkit.org/show_bug.cgi?id=103624
2896
2897         Reviewed by Adam Barth.
2898
2899         Remove the deprecated logging module and its unit tests now that such logging is not
2900         used anymore in webkitpy.
2901
2902         The tee and OutputTee classes are moved into a new module, webkitpy.common.system.outputtee.
2903         The tee class is renamed to Tee to conform with the usual guidelines.
2904
2905         Only unit test for the Tee class is currently provided as the OutputTee is not currently
2906         using the webkitpy Filesystem abstraction that would make its functionality testable.
2907
2908         * Scripts/webkitpy/common/system/executive.py: tee (now Tee) is now in a new module.
2909         (Executive.run_and_throw_if_fail):
2910         * Scripts/webkitpy/common/system/outputtee.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging.py.
2911         (Tee):
2912         (Tee.__init__):
2913         (Tee.write):
2914         (OutputTee):
2915         (OutputTee.__init__):
2916         (OutputTee.add_log):
2917         (OutputTee.remove_log):
2918         (OutputTee._open_log_file):
2919         (OutputTee._tee_outputs_to_files):
2920         * Scripts/webkitpy/common/system/outputtee_unittest.py: Renamed from Tools/Scripts/webkitpy/common/system/deprecated_logging_unittest.py.
2921         (SimpleTeeTest):
2922         (SimpleTeeTest.test_simple_tee):
2923         * Scripts/webkitpy/tool/bot/queueengine.py: OutputTee is now in a new module.
2924         * Scripts/webkitpy/webkitpy.pyproj: Remove the deprecated_logging module and related unit test file.
2925
2926 2012-11-30  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2927
2928         [EFL][WK2] Add support for PlatformWebView::simulateRightClick() in TestWebKitAPI
2929         https://bugs.webkit.org/show_bug.cgi?id=103634
2930
2931         Reviewed by Gyuyoung Kim.
2932
2933         Add support for PlatformWebView::simulateRightClick() and enable
2934         WebKit2 API test HitTestResultNodeHandle.
2935
2936         * TestWebKitAPI/PlatformEfl.cmake:
2937         * TestWebKitAPI/efl/PlatformWebView.cpp:
2938         (TestWebKitAPI::PlatformWebView::simulateRightClick):
2939         (TestWebKitAPI):
2940
2941 2012-11-30  Mihai Maerean  <mmaerean@adobe.com>
2942
2943         [CSSRegions] when WebKit uses V8, there should be a single variable to store if the CSS Regions feature is enabled
2944         https://bugs.webkit.org/show_bug.cgi?id=101192
2945
2946         Reviewed by Hajime Morita.
2947
2948         Removed the CSS Regions flag in Settings and switched to using the new flag I have added in RuntimeEnabledFeatures.
2949
2950         Tests: No new tests because there is no functional change.
2951
2952         * DumpRenderTree/chromium/WebPreferences.cpp:
2953         (WebPreferences::applyTo):
2954
2955 2012-11-29  Rafael Weinstein  <rafaelw@chromium.org>
2956
2957         [HTMLTemplateElement] Add feature flag
2958         https://bugs.webkit.org/show_bug.cgi?id=103694
2959
2960         Reviewed by Adam Barth.
2961
2962         This flag will guard the implementation of the HTMLTemplateElement.
2963         http://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/templates/index.html
2964
2965         * Scripts/webkitperl/FeatureList.pm:
2966
2967 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2968
2969         Ignore errors when removing directories on win32 during autoinstall
2970         https://bugs.webkit.org/show_bug.cgi?id=103699
2971
2972         Unreviewed, build fix.
2973
2974         I think this will work on win32; if not, I'll have to actually
2975         reproduce this :). The problem is that the logilab files
2976         appear to contain a write-protected file, and deleting those
2977         is problematic on windows.
2978
2979         * Scripts/webkitpy/common/system/autoinstall.py:
2980         (AutoInstaller._install):
2981         (AutoInstaller.install):
2982
2983 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2984
2985         webkitpy: autoinstaller is failing on windows
2986         https://bugs.webkit.org/show_bug.cgi?id=103699
2987
2988         Unreviewed, build fix.
2989
2990         We're attempting to create directories with forward slashes in them;
2991         this is a no-no on windows.
2992
2993         * Scripts/webkitpy/common/system/autoinstall.py:
2994         (AutoInstaller._create_scratch_directory_inner):
2995
2996 2012-11-29  Dirk Pranke  <dpranke@chromium.org>
2997
2998         Fix python unit tests after r136158 (android port tests failing)
2999         https://bugs.webkit.org/show_bug.cgi?id=103581
3000
3001         Unreviewed, build fix.
3002
3003         The unit tests apparently weren't ran for this patch; we failed
3004         to update the mock executive calls out to adb to determine various
3005         aspects of the environment, and were failing to create drivers.
3006
3007         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
3008         (MockRunCommand.mock_run_command_fn):
3009
3010 2012-11-29  Sheriff Bot  <webkit.review.bot@gmail.com>
3011
3012         Unreviewed, rolling out r136175 and r136177.
3013         http://trac.webkit.org/changeset/136175
3014         http://trac.webkit.org/changeset/136177
3015         https://bugs.webkit.org/show_bug.cgi?id=103683
3016
3017         Changes did not correct Windows build. (Requested by bfulgham
3018         on #webkit).
3019
3020         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3021
3022 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
3023
3024         [Windows, WinCairo] Unreviewed build correction. Correct debug
3025         build case on build machine.
3026
3027         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
3028
3029 2012-11-29  Brent Fulgham  <bfulgham@webkit.org>
3030
3031         [Windows, WinCairo] Unreviewed build correction. Hide the
3032         unexported 'notSolidColor' symbol when testing against
3033         the BitmapImage class to avoid having to deal with a
3034         debug-only symbol in the Windows export definition file.
3035
3036         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: 
3037
3038 2012-11-29  Peter Beverloo  <peter@chromium.org>
3039
3040         run-perf-tests --chromium-android should not require adb in my path
3041         https://bugs.webkit.org/show_bug.cgi?id=103581
3042
3043         Reviewed by Eric Seidel.
3044
3045         Remove the need to have "adb" available in the path for Layout and Performance
3046         tests. We'll determine the versions of the "adb" version in path (if any) and
3047         the one provided in the Chromium Android checkout. Unless the "adb" available
3048         in the path is newer, the provided version will be used.
3049
3050         Some other minor nits addressed:
3051         - The path_to_forwarder/path_to_md5sum should not be in the "private overrides"
3052           section, as they're not overriding anything and are used by the driver.
3053         - Make _restart_adb_as_root slightly more robust by waiting for the device
3054           to come back online regardless of the output.
3055
3056         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3057         (ChromiumAndroidPort.__init__):
3058         (ChromiumAndroidPort.check_build):
3059         (ChromiumAndroidPort.path_to_adb):
3060         (ChromiumAndroidPort):
3061         (ChromiumAndroidPort.path_to_forwarder):
3062         (ChromiumAndroidPort.path_to_md5sum):
3063         (ChromiumAndroidPort._path_to_helper):
3064         (ChromiumAndroidPort._determine_adb_version):
3065         (ChromiumAndroidPort._get_devices):
3066         (ChromiumAndroidDriver.__init__):
3067         (ChromiumAndroidDriver._setup_md5sum_and_push_data_if_needed):
3068         (ChromiumAndroidDriver._push_executable):
3069         (ChromiumAndroidDriver._restart_adb_as_root):
3070
3071 2012-11-29  Martin Robinson  <mrobinson@igalia.com>
3072
3073         [GTK] [WebKit2] Embed the HTTP authentication dialog into the WebView
3074         https://bugs.webkit.org/show_bug.cgi?id=103277
3075
3076         Reviewed by Carlos Garcia Campos.
3077
3078         Skip the new WebKit2GtkAuthenticationDialog files so that they are not processed
3079         during gtkdoc generation.
3080
3081         * gtk/generate-gtkdoc:
3082         (get_webkit2_options):
3083
3084 2012-11-29  Eric Seidel  <eric@webkit.org>
3085
3086         run-perf-tests --chromium-android fails due to Skia INFO logging
3087         https://bugs.webkit.org/show_bug.cgi?id=103585
3088
3089         Reviewed by Adam Barth.
3090
3091         Ignore all INFO logging from Chromium code.
3092         Also added some basic testing of the ignored-stderr lines code.
3093
3094         * Scripts/webkitpy/performance_tests/perftest.py:
3095         (PerfTest):
3096         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3097         (MainTest.test_ignored_stderr_lines):
3098
3099 2012-11-29  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3100
3101         [EFL][WK2] Add support for PlatformWebView::simulateMouseMove() in TestWebKitAPI
3102         https://bugs.webkit.org/show_bug.cgi?id=103252
3103
3104         Reviewed by Kenneth Rohde Christiansen.
3105
3106         Add support for PlatformWebView::simulateMouseMove() and enable
3107         WebKit2 API test MouseMoveAfterCrash.
3108
3109         * TestWebKitAPI/PlatformEfl.cmake: Enable MouseMoveAfterCrash API
3110         test.
3111         * TestWebKitAPI/efl/PlatformWebView.cpp:
3112         (TestWebKitAPI::onWebProcessCrashed): Handle 'webprocess,crashed' signal
3113         to prevent loading an error page since the test case is reloading actual
3114         page after web process has terminated and recovered.
3115         (TestWebKitAPI):
3116         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3117         (TestWebKitAPI::PlatformWebView::simulateMouseMove): Implemented.
3118
3119 2012-11-29  Andras Becsi  <andras.becsi@digia.com>
3120
3121         [Qt] Fix installation of QtWebProcess binary
3122         https://bugs.webkit.org/show_bug.cgi?id=101735
3123
3124         Reviewed by Simon Hausmann.
3125
3126         Add config test to detect the availability of support
3127         for "program executables" in Qt (libexec).
3128
3129         This test can be removed after the Qt5 release.
3130
3131         * Tools.pro:
3132         * qmake/mkspecs/features/features.prf:
3133         * qmake/config.tests/libexecdir/libexecdir.cpp:
3134         * qmake/config.tests/libexecdir/libexecdir.pro:
3135
3136 2012-11-29  Eric Seidel  <eric@webkit.org>
3137
3138         run-perf-tests does not work when the layout test directory does not exist
3139         https://bugs.webkit.org/show_bug.cgi?id=103572
3140
3141         Reviewed by Ryosuke Niwa.
3142
3143         Make sure that Profiler() calls maybe_make_directory for the output_dir
3144         before ever using it.  It's a little awkward to create the directory
3145         from the constructor, but its simplest that way as the various subclasses
3146         all use the directory at different times.
3147
3148         Since this required having a filesystem in Profiler (and I didn't want
3149         to grab inside Workspace to get one), I just made Profiler expect a
3150         SystemHost instead of a separate filesystem, executive and workspace.
3151
3152         * Scripts/webkitpy/common/system/profiler.py:
3153         (ProfilerFactory.create_profiler):
3154         (Profiler.__init__):
3155         (SingleFileOutputProfiler.__init__):
3156         (GooglePProf.__init__):
3157         (GooglePProf.profile_after_exit):
3158         (Instruments.__init__):
3159         (Instruments.attach_to_pid):
3160         * Scripts/webkitpy/common/system/profiler_unittest.py:
3161         (ProfilerFactoryTest.test_basic):
3162
3163 2012-11-28  Vivek Galatage  <vivek.vg@samsung.com>
3164
3165         Adding secondary email id
3166         https://bugs.webkit.org/show_bug.cgi?id=103594
3167
3168         Unreviewed. Adding secondary email.
3169
3170         * Scripts/webkitpy/common/config/committers.py:
3171
3172 2012-11-28  Kent Tamura  <tkent@chromium.org>
3173
3174         garden-o-matic: Use indeterminate <progress> in the status area
3175         https://bugs.webkit.org/show_bug.cgi?id=103494
3176
3177         Reviewed by Adam Barth.
3178
3179         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3180         Wrap the "Processing..." message with an indeterminate progress bar.
3181         We keep the message as a fallback content.
3182         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
3183         Follow the above change.
3184
3185 2012-11-28  Nima Ghanavatian  <nghanavatian@rim.com>
3186
3187         Adding Nima Ghanavatian to committers.py
3188         https://bugs.webkit.org/show_bug.cgi?id=103533
3189
3190         Reviewed by Rob Buis.
3191
3192         Adding myself to committers.py as a Committer.
3193
3194         * Scripts/webkitpy/common/config/committers.py:
3195
3196 2012-11-28  peavo@outlook.com  <peavo@outlook.com>
3197
3198         [WinCairo] Crash when requesting favicon.
3199         https://bugs.webkit.org/show_bug.cgi?id=102689
3200
3201         Reviewed by Brent Fulgham.
3202
3203         * TestWebKitAPI/Tests/WebCore/win: Added.
3204         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp: Added.
3205         (TestWebKitAPI::BitmapImageTest::BitmapImageTest): Allocate frame in constructor.
3206         (TestWebKitAPI::BitmapImageTest::frameCount): Override frameCount() method.
3207         (TestWebKitAPI::TEST): Added new test.
3208         * TestWebKitAPI/config.h: Make sure defines are correct for WinCairo.
3209        * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new test.
3210
3211 2012-11-28  Eric Seidel  <eric@webkit.org>
3212
3213         run-perf-tests should have a --profile option for easy profiling
3214         https://bugs.webkit.org/show_bug.cgi?id=99517
3215
3216         Reviewed by Adam Barth.
3217
3218         This is a very basic implementation which works on Mac and Linux
3219         and makes it trivial for anyone to profile a PerformanceTest.
3220
3221         Currently it's not "hard" to profile a PerformanceTest
3222         but lowering the barriers to entry here allows all of us to focus
3223         less on the tools and more on the code.
3224
3225         This also paves the way for adding easy mobile-profiling (e.g. chromium-android)
3226         which is actually "hard", and this option will make much easier.
3227
3228         * Scripts/webkitpy/common/system/profiler.py: Added.
3229         (ProfilerFactory):
3230         (ProfilerFactory.create_profiler):
3231         (Profiler):
3232         (Profiler.__init__):
3233         (Profiler.adjusted_environment):
3234         (Profiler.attach_to_pid):
3235         (Profiler.did_stop):
3236         (SingleFileOutputProfiler):
3237         (SingleFileOutputProfiler.__init__):
3238         (GooglePProf):
3239         (GooglePProf.__init__):
3240         (GooglePProf.adjusted_environment):
3241         (GooglePProf.did_stop):
3242         (Instruments):
3243         (Instruments.__init__):
3244         (Instruments.attach_to_pid):
3245         * Scripts/webkitpy/common/system/profiler_unittest.py: Added.
3246         (ProfilerFactoryTest):
3247         (ProfilerFactoryTest.test_basic):
3248         * Scripts/webkitpy/layout_tests/port/driver.py:
3249         (Driver.__init__):
3250         (Driver._start):
3251         (Driver.stop):
3252         (Driver.cmd_line):
3253         * Scripts/webkitpy/performance_tests/perftest.py:
3254         (PerfTest.parse_output):
3255         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3256         (MainTest.test_parse_output):
3257         (MainTest.test_parse_output_with_failing_line):
3258         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3259         (PerfTestsRunner._parse_args):
3260         (PerfTestsRunner.run):
3261
3262 2012-11-28  Zan Dobersek  <zandobersek@gmail.com>
3263
3264         Remove deprecated logging usage from QueueEngine
3265         https://bugs.webkit.org/show_bug.cgi?id=103532
3266
3267         Reviewed by Dirk Pranke.
3268
3269         Replace usage of deprecated logging in webkitpy.tool.bot.queueengine with
3270         logging through the Logger object. The unit test is modified to reflect
3271         these changes.
3272
3273         After these changes the deprecated logging (i.e. logging to stderr) is not
3274         used anymore through webkitpy and can be removed.
3275
3276         * Scripts/webkitpy/tool/bot/queueengine.py:
3277         (QueueEngine.exit_after_handled_error):
3278         (QueueEngine.run):
3279         (QueueEngine._stopping):
3280         (QueueEngine._sleep):
3281         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
3282         (QueueEngineTest._run_engine):
3283
3284 2012-11-28  Nate Chapin  <japhet@chromium.org>
3285
3286         Move empty loading to DocumentLoader, simplify FrameLoader::init()
3287         https://bugs.webkit.org/show_bug.cgi?id=101512
3288
3289         Reviewed by Adam Barth.
3290
3291         * DumpRenderTree/chromium/WebViewHost.cpp:
3292         (WebViewHost::updateForCommittedLoad): This function doesn't play nicely with empty urls and incorrectly
3293             interprets them as a non-empty load. This change is required for
3294              http/tests/navigation/new-window-redirect-history.html to continue to pass in chromium.
3295         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: This test relies on a callback that no longer
3296              is sent for about:blank loads.  Hook into didFinishLoadForFrame() instead.
3297         (TestWebKitAPI::didFinishLoadForFrame):
3298         (TestWebKitAPI::TEST):
3299
3300 2012-11-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3301
3302         [chromium] Allow plugins to opt-in to receive synthetic mouse events out of touch events.
3303         https://bugs.webkit.org/show_bug.cgi?id=103092
3304
3305         Reviewed by Tony Chang.
3306
3307         Update the test web-plugin to be able to opt-in to receive synthesized mouse events created
3308         from touch events.
3309
3310         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3311         (parseTouchEventRequestType):
3312         (TestWebPlugin::TestWebPlugin):
3313         (TestWebPlugin::initialize):
3314         * DumpRenderTree/chromium/TestWebPlugin.h:
3315         (TestWebPlugin):
3316
3317 2012-11-28  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
3318
3319         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
3320         https://bugs.webkit.org/show_bug.cgi?id=103123
3321
3322         Reviewed by Laszlo Gombos.
3323
3324         Add support for PlatformWebView::simulateSpacebarKeyPress().
3325         This functionality is needed by WebKit2 API test MouseMoveAfterCrash
3326         which is going to be unskipped in bug #103252.
3327
3328         * TestWebKitAPI/efl/PlatformUtilities.cpp:
3329         (TestWebKitAPI::Util::sleep):
3330         * TestWebKitAPI/efl/PlatformWebView.cpp: Use usleep() instead of
3331         sleep().
3332         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3333         (TestWebKitAPI):
3334
3335 2012-11-28  Yael Aharon  <yael.aharon@intel.com>
3336
3337         Minor cleanup in TestInvocation
3338         https://bugs.webkit.org/show_bug.cgi?id=103512
3339
3340         Reviewed by Kenneth Rohde Christiansen.
3341
3342         Remove a function declaration that is not defined and not used.
3343         Fix spelling error in m_webProcessIsUnresponsive.
3344
3345         * WebKitTestRunner/TestInvocation.cpp:
3346         (WTR::TestInvocation::TestInvocation):
3347         (WTR::TestInvocation::invoke):
3348         * WebKitTestRunner/TestInvocation.h:
3349         (TestInvocation):
3350         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3351         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3352         * WebKitTestRunner/qt/TestInvocationQt.cpp:
3353         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3354
3355 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3356
3357         Unreviewed. Use my personal email as bugzilla email.
3358
3359         * Scripts/webkitpy/common/config/committers.py:
3360
3361 2012-11-28  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3362
3363         Unreviewed. Adding myself to committers.py.
3364
3365         * Scripts/webkitpy/common/config/committers.py:
3366
3367 2012-11-26  Andrey Adaikin  <aandrey@chromium.org>
3368
3369         Unreviewed. Adding myself to committers.py.
3370
3371         * Scripts/webkitpy/common/config/committers.py:
3372
3373 2012-11-28  Tommy Widenflycht  <tommyw@google.com>
3374
3375         Add basic implementation for MediaStreamAudioDestinationNode
3376         https://bugs.webkit.org/show_bug.cgi?id=101815
3377
3378         Reviewed by Chris Rogers.
3379
3380         Adds a bit of code that exercises the WebKit API.
3381
3382         * DumpRenderTree/chromium/MockWebMediaStreamCenter.cpp:
3383         (MockWebMediaStreamSourceConsumer):
3384         (MockWebMediaStreamSourceConsumer::~MockWebMediaStreamSourceConsumer):
3385         (MockWebMediaStreamCenter::didCreateMediaStream):
3386
3387 2012-11-28  Matt Falkenhagen  <falken@chromium.org>
3388
3389         Unreviewed. Adding myself to committers list.
3390
3391         * Scripts/webkitpy/common/config/committers.py:
3392
3393 2012-11-27  Li Yin  <li.yin@intel.com>
3394
3395         Unreviewed. Adding myself to committers list.
3396
3397         * Scripts/webkitpy/common/config/committers.py:
3398
3399 2012-11-27  Christophe Dumez  <christophe.dumez@intel.com>
3400
3401         Unreviewed. Adding myself to committers.py.
3402
3403         * Scripts/webkitpy/common/config/committers.py:
3404
3405 2012-11-27  Vivek Galatage  <vivek.vg@samsung.com>
3406
3407         Unreviewd. Adding myself to committers list.
3408
3409         * Scripts/webkitpy/common/config/committers.py:
3410
3411 2012-11-27  Tony Chang  <tony@chromium.org>
3412
3413         Bring back partytime!
3414         https://bugs.webkit.org/show_bug.cgi?id=103466
3415
3416         Reviewed by Adam Barth.
3417
3418         "code 404, message Unknown function images/partytime_gif" since we didn't
3419         allow .gif or .png files to be served.
3420
3421         * Scripts/webkitpy/tool/servers/gardeningserver.py:
3422         (GardeningHTTPRequestHandler):
3423
3424 2012-11-27  Adam Barth  <abarth@webkit.org>
3425
3426         run-perf-tests fails on Android because of stderr output
3427         https://bugs.webkit.org/show_bug.cgi?id=103462
3428
3429         Reviewed by Ryosuke Niwa.
3430
3431         The chromium-android port produces some stderr output that causes
3432         run-perf-tests to get sad and not record the results of the performance
3433         test. This patch teaches run-perf-test to ignore this output much in
3434         the same way that it currently ignores some stdout messages.
3435
3436         * Scripts/webkitpy/performance_tests/perftest.py:
3437         (PerfTest.run):
3438         (PerfTest._should_ignore_line):
3439         (PerfTest):
3440         (PerfTest._should_ignore_line_in_stderr):
3441         (PerfTest._filter_stderr):
3442         (PerfTest._should_ignore_line_in_parser_test_result):
3443
3444 2012-11-27  Tony Chang  <tony@chromium.org>
3445
3446         Fix garden-o-matic for non-chromium ports
3447         https://bugs.webkit.org/show_bug.cgi?id=103458
3448
3449         Reviewed by Adam Barth.
3450
3451         I was getting a 403 error when trying to select any non-chromium port.
3452
3453         * Scripts/webkitpy/tool/servers/reflectionhandler.py:
3454         (ReflectionHandler._handle_request): Use the path without query params.
3455
3456 2012-11-27  Yael Aharon  <yael.aharon@intel.com>
3457
3458         [EFL][WK2] 3D pixel tests are failing
3459         https://bugs.webkit.org/show_bug.cgi?id=102833
3460
3461         Reviewed by Kenneth Rohde Christiansen.
3462
3463         Generate a snapshot of the view in the UI process instead of the web process.
3464         We have to use Texture Mapper in order to correctly paint 3D transforms etc.
3465
3466         * WebKitTestRunner/TestInvocation.h:
3467         (TestInvocation):
3468         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3469         (WTR::writeFunction):
3470         (WTR::paintRepaintRectOverlay):
3471         (WTR):
3472         (WTR::TestInvocation::forceRepaintDoneCallback):
3473         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3474         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3475         (WTR::PlatformWebView::windowSnapshotImage):
3476
3477 2012-11-27  Adam Barth  <abarth@webkit.org>
3478
3479         Make it possible to run performance tests on Chromium Android
3480         https://bugs.webkit.org/show_bug.cgi?id=103268
3481
3482         Reviewed by Ryosuke Niwa.
3483
3484         Based on a patch by Peter Beverloo.
3485
3486         This patch (almost) makes it possible to run WebKit performance tests
3487         on the Chromium port for Android. There are a few things I had to do
3488         in order to make this happen:
3489
3490         1) The worker number when creating a driver for a port is zero-based
3491            for layout tests and elsewhere. Android uses this to determine
3492            which device it has to run on, so make it zero based for performance
3493            tests as well.
3494
3495         2) Tests aren't available on the Android device, so we start an HTTP
3496            server that serves the tests to the device or emulator.
3497
3498         The one shortcoming of this patch is that chromium-android produces
3499         some stderr output that confuses run-perf-tests. I'll address that
3500         issue in a subsequent CL. This patch also depends on
3501         https://codereview.chromium.org/11416182 in order to work.
3502
3503         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3504         (ChromiumAndroidPort.start_http_server):
3505         (ChromiumAndroidDriver._command_from_driver_input):
3506         * Scripts/webkitpy/performance_tests/perftest.py:
3507         (ReplayPerfTest.prepare):
3508         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3509         (PerfTestsRunner.__init__):
3510         (PerfTestsRunner._parse_args):
3511         (PerfTestsRunner._start_servers):
3512         (PerfTestsRunner):
3513         (PerfTestsRunner._stop_servers):
3514         (PerfTestsRunner.run):
3515         (PerfTestsRunner._run_tests_set):
3516
3517 2012-11-27  Zan Dobersek  <zandobersek@gmail.com>
3518
3519         Remove use of deprecated logging from webkitpy.common and webkitpy.layout_tests
3520         https://bugs.webkit.org/show_bug.cgi?id=103408
3521
3522         Reviewed by Dirk Pranke.
3523
3524         Remove the use of the deprecated log and error methods by replacing them with
3525         logging through Python's logging.Logger objects.
3526
3527         This patch covers such changes in webkitpy.common and webkitpy.layout_tests and also
3528         updates any affected unit test.
3529
3530         * Scripts/webkitpy/common/checkout/changelog.py:
3531         (ChangeLogEntry._parse_entry):
3532         * Scripts/webkitpy/common/checkout/checkout.py:
3533         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
3534         (CheckoutTest.test_apply_patch):
3535         * Scripts/webkitpy/common/checkout/deps_mock.py:
3536         (MockDEPS.write_variable):
3537         * Scripts/webkitpy/common/checkout/scm/detection.py:
3538         (SCMDetector.default_scm):
3539         * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
3540         (SCMDetectorTest.test_detect_scm_system):
3541         * Scripts/webkitpy/common/checkout/scm/git.py:
3542         (Git._check_git_architecture):
3543         (Git._commit_on_branch):
3544         * Scripts/webkitpy/common/checkout/scm/scm.py:
3545         (SCM.ensure_clean_working_directory):
3546         (SCM.ensure_no_local_commits):
3547         (SCM.will.commit_locally_with_message):
3548         * Scripts/webkitpy/common/checkout/scm/svn.py:
3549         (SVN.apply_reverse_diff):
3550         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
3551         (Attachment._validate_flag_value):
3552         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3553         (Bugzilla._fetch_bug_page):
3554         (Bugzilla.bug_id_for_attachment_id):
3555         (Bugzilla.authenticate):
3556         (Bugzilla._commit_queue_flag):
3557         (Bugzilla.add_attachment_to_bug):
3558         (Bugzilla.add_patch_to_bug):
3559         (Bugzilla.create_bug):
3560         (Bugzilla.clear_attachment_flags):
3561         (Bugzilla.set_flag_on_attachment):
3562         (Bugzilla.obsolete_attachment):
3563         (Bugzilla.add_cc_to_bug):
3564         (Bugzilla.post_comment_to_bug):
3565         (Bugzilla.close_bug_as_fixed):
3566         (Bugzilla.reassign_bug):
3567         (reopen_bug):
3568         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
3569         (MockBugzilla.create_bug):
3570         (MockBugzilla.reassign_bug):
3571         (MockBugzilla.set_flag_on_attachment):
3572         (MockBugzilla.post_comment_to_bug):
3573         (MockBugzilla.add_attachment_to_bug):
3574         (MockBugzilla.add_patch_to_bug):
3575         (MockBugzilla.reopen_bug):
3576         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
3577         (test_add_cc_to_bug):
3578         (_assert_reopen):
3579         (test_reopen_bug):
3580         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
3581         (MockBuilder.force_build):
3582         * Scripts/webkitpy/common/net/credentials.py:
3583         (Credentials._run_security_tool):
3584         * Scripts/webkitpy/common/net/credentials_unittest.py:
3585         (_assert_security_call):
3586         * Scripts/webkitpy/common/net/irc/irc_mock.py:
3587         (MockIRC.post):
3588         (MockIRC.disconnect):
3589         * Scripts/webkitpy/common/net/irc/ircproxy.py:
3590         (IRCProxy.__init__):
3591         (IRCProxy.disconnect):
3592         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
3593         (IRCProxyTest.test_trivial):
3594         * Scripts/webkitpy/common/net/layouttestresults.py:
3595         (ORWTResultsHTMLParser._failures_from_fail_row):
3596         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3597         (test_failures_from_fail_row):
3598         * Scripts/webkitpy/common/net/networktransaction.py:
3599         * Scripts/webkitpy/common/net/resultsjsonparser.py:
3600         (JSONTestResult._tokenize):
3601         (JSONTestResult._failure_types_from_actual_result):
3602         * Scripts/webkitpy/common/net/statusserver.py:
3603         (StatusServer.update_status):
3604         (StatusServer.update_svn_revision):
3605         * Scripts/webkitpy/common/net/statusserver_mock.py:
3606         (MockStatusServer.release_work_item):
3607         (MockStatusServer.update_work_items):
3608         (MockStatusServer.submit_to_ews):
3609         (MockStatusServer.update_status):
3610         * Scripts/webkitpy/common/net/unittestresults.py:
3611         (UnitTestResults.results_from_string):
3612         * Scripts/webkitpy/common/system/executive_mock.py:
3613         (MockExecutive.running_pids):
3614         (MockExecutive.run_and_throw_if_fail):
3615         (MockExecutive.run_command):
3616         (MockExecutive.popen):
3617         * Scripts/webkitpy/common/system/user_mock.py:
3618         (MockUser.confirm):
3619         (MockUser.open_url):
3620         * Scripts/webkitpy/common/system/workspace_unittest.py:
3621         (WorkspaceTest.test_create_zip):
3622         (WorkspaceTest.test_create_zip_exception):
3623         * Scripts/webkitpy/common/watchlist/watchlist_mock.py:
3624         (MockWatchList.determine_cc_and_messages):
3625         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
3626         (ChromiumWinTest.test_setup_environ_for_server_register_cygwin):
3627         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
3628         (EflPortTest.test_show_results_html_file):
3629         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3630         (GtkPortTest.test_show_results_html_file):
3631         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3632         (test_show_results_html_file):
3633         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3634         (test_build_driver):
3635         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3636         (QtPortTest.test_show_results_html_file):
3637         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3638         (WinPortTest.test_show_results_html_file):
3639         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
3640         (XvfbDriverTest.assertDriverStartSuccessful):
3641         (XvfbDriverTest.test_start_no_pixel_tests):
3642         (XvfbDriverTest.test_start_pixel_tests):
3643         (XvfbDriverTest.test_start_arbitrary_worker_number):
3644         (XvfbDriverTest.test_start_next_worker):
3645         (XvfbDriverTest.test_stop):
3646         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3647         (TestLayoutTestApacheHttpd.test_start_cmd):
3648         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3649         (test_run_test_pause_before_testing):
3650         (test_run_memory_test):
3651         (_test_run_with_json_output):
3652         (test_run_respects_no_results):
3653         (test_run_generates_and_show_results_page):
3654         (test_run_respects_no_show_results):
3655         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3656         (FeedersTest.test_commit_queue_feeder):
3657         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3658         (FlakyTestReporterTest.test_create_bug_for_flaky_test):
3659         (test_report_flaky_tests_creating_bug):
3660         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
3661         (IRCCommandTest.test_rollout_updates_working_copy):
3662         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
3663         (IRCBotTest.test_exception_during_command):
3664         (IRCBotTest.test_hi):
3665         (IRCBotTest.test_help):
3666         (IRCBotTest.test_restart):
3667         (IRCBotTest.test_rollout):
3668         (IRCBotTest.test_revert):
3669         (IRCBotTest.test_roll_chromium_deps):
3670         (IRCBotTest.test_roll_chromium_deps_to_lkgr):
3671         (IRCBotTest.test_multi_rollout):
3672         (IRCBotTest.test_rollout_with_r_in_svn_revision):
3673         (IRCBotTest.test_multi_rollout_with_r_in_svn_revision):
3674         (IRCBotTest.test_rollout_bananas):
3675         (IRCBotTest.test_rollout_invalidate_revision):
3676         (IRCBotTest.test_rollout_invalidate_reason):
3677         (test_multi_rollout_invalidate_reason):
3678         (test_rollout_no_reason):
3679         (test_multi_rollout_no_reason):
3680         * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
3681         (SheriffTest.test_post_blame_comment_on_bug):
3682         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
3683         (ApplyWatchListLocalTest.test_args_parsing):
3684         (test_args_parsing_with_bug):
3685         * Scripts/webkitpy/tool/commands/download_unittest.py:
3686         (test_land_cowboy):
3687         (test_check_style):
3688         (test_create_rollout):
3689         (test_create_rollout_resolved):
3690         (test_rollout):
3691         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3692         (AbstractEarlyWarningSystemTest.test_failing_tests_message):
3693         (EarlyWarningSytemTest._default_expected_logs):
3694         (EarlyWarningSytemTest._test_builder_ews):
3695         (EarlyWarningSytemTest._test_testing_ews):
3696         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3697         (OpenBugsTest.test_args_parsing):
3698         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3699         (QueryCommandsTest.test_bugs_to_commit):
3700         (QueryCommandsTest.test_patches_in_commit_queue):
3701         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3702         (FeederQueueTest.test_feeder_queue):
3703         (AbstractPatchQueueTest.test_next_patch):
3704         (AbstractPatchQueueTest.test_upload_results_archive_for_patch):
3705         (CommitQueueTest.test_commit_queue):
3706         (test_commit_queue_failure):
3707         (test_commit_queue_failure_with_failing_tests):
3708         (test_rollout):
3709         (test_rollout_lands):
3710         (test_auto_retry):
3711         (test_manual_reject_during_processing):
3712         (test_report_flaky_tests):
3713         (StyleQueueTest.test_style_queue_with_style_exception):
3714         (test_style_queue_with_watch_list_exception):
3715         * Scripts/webkitpy/tool/commands/queuestest.py:
3716         (QueuesTest._default_begin_work_queue_logs):
3717         * Scripts/webkitpy/tool/commands/roll_unittest.py:
3718         (RollCommandsTest.test_update_chromium_deps):
3719         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3720         (UploadCommandsTest.test_assign_to_committer):
3721         (test_post):
3722         (test_attach_to_bug):
3723         (test_attach_to_bug_no_description_or_comment):
3724         (test_land_safely):
3725         (test_prepare):
3726         (test_upload):
3727         (test_mark_bug_fixed):
3728         * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py:
3729         (ApplyWatchListTest.test_apply_watch_list_local):
3730         * Scripts/webkitpy/tool/steps/commit_unittest.py:
3731         (CommitTest._test_check_test_expectations):
3732         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3733         (RunTestsTest.test_webkit_run_unit_tests):
3734         * Scripts/webkitpy/tool/steps/steps_unittest.py:
3735         (StepsTest._assert_step_output_with_bug):
3736         (StepsTest._assert_post_diff_output_for_bug):
3737         (StepsTest.test_post_diff):
3738         (StepsTest.test_post_diff_for_commit):
3739         (StepsTest.test_ensure_bug_is_open_and_assigned):
3740         (StepsTest.test_runtests_args):
3741         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
3742         (SuggestReviewersTest.test_basic):
3743         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
3744         (ValidateChangeLogsTest._assert_start_line_produces_output):
3745
3746 2012-11-27  Pratik Solanki  <psolanki@apple.com>
3747
3748         objc/objc-runtime.h does not exist on all PLATFORM(MAC)
3749         https://bugs.webkit.org/show_bug.cgi?id=101780
3750
3751         Reviewed by Brent Fulgham.
3752
3753         Clean up header includes so we don't include objc/objc-runtime.h.
3754
3755         * DumpRenderTree/mac/DumpRenderTree.mm:
3756         * DumpRenderTree/mac/ObjCPlugin.m:
3757         * TestWebKitAPI/mac/InstanceMethodSwizzler.h:
3758         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
3759
3760 2012-11-27  Marja Hölttä  <marja@chromium.org>
3761
3762         Add callbacks to the FrameLoaderClient when a resource is requested
3763         https://bugs.webkit.org/show_bug.cgi?id=92761
3764
3765         Reviewed by Adam Barth.
3766
3767         In Chromium, when an extension script cancels a network
3768         request (which happens out of process), we'd like to
3769         notify content scripts running on the current page about
3770         which elements failed to load because the requests were
3771         cancelled (as opposed to e.g. the network request just
3772         didn't work). Since the resource request itself does not
3773         carry any information what DOM element is was made for,
3774         currently a content script has to search the DOM tree and
3775         guess which requests will be cancelled by its counter
3776         part. By adding these callbacks, the embedder can make
3777         this connection explictly.
3778
3779         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3780         (DRTTestRunner::DRTTestRunner):
3781         (DRTTestRunner::dumpResourceRequestCallbacks):
3782         (DRTTestRunner::reset):
3783         * DumpRenderTree/chromium/DRTTestRunner.h:
3784         (DRTTestRunner):
3785         (DRTTestRunner::setShouldDumpResourceRequestCallbacks):
3786         (DRTTestRunner::shouldDumpResourceRequestCallbacks):
3787         * DumpRenderTree/chromium/TestShell.h:
3788         (TestShell::shouldDumpResourceRequestCallbacks):
3789         * DumpRenderTree/chromium/WebViewHost.cpp:
3790         (WebViewHost::willRequestResource):
3791         * DumpRenderTree/chromium/WebViewHost.h:
3792         (WebViewHost):
3793
3794 2012-11-27  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3795
3796         [GStreamer] Verify if GStreamer was previously initialized
3797         https://bugs.webkit.org/show_bug.cgi?id=103151
3798
3799         Reviewed by Philippe Normand.
3800
3801         This patch adds the gst_init() in GtkLauncher, so we can add the
3802         GStreamer options in the command line through
3803         gst_init_get_option_group().
3804
3805         This approach is not valid for MiniBrowser because it uses WebKit2,
3806         where the GStreamer backend lives in the web process, which is
3807         different from the UI process.
3808
3809         * GNUmakefile.am:
3810         * GtkLauncher/main.c:
3811         (main):
3812
3813 2012-11-27  Andras Becsi  <andras.becsi@digia.com>
3814
3815         [Qt] Fix the build with new Qt5 hash
3816         https://bugs.webkit.org/show_bug.cgi?id=103406
3817
3818         Reviewed by Csaba Osztrogonác.
3819
3820         Remove references to deprecated QApplication::GuiServer which
3821         has been removed, and use QStyleFactory::create instead of
3822         instantiating a QWindowsStyle directly since it is about to
3823         become an internal class.
3824
3825         * DumpRenderTree/qt/DumpRenderTreeMain.cpp:
3826         (main):
3827         * QtTestBrowser/qttestbrowser.cpp:
3828         (LauncherApplication::LauncherApplication):
3829         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
3830         (WTR::InjectedBundle::platformInitialize):
3831
3832 2012-11-27  Sadrul Habib Chowdhury  <sadrul@chromium.org>
3833
3834         [style] Add a style-check for enum-member names
3835         https://bugs.webkit.org/show_bug.cgi?id=103157
3836
3837         Reviewed by Daniel Bates.
3838
3839         * Scripts/webkitpy/style/checkers/cpp.py:
3840         (_EnumState):
3841         (_EnumState.__init__):
3842         (_EnumState.process_clean_line):
3843         (check_enum_casing):
3844         (check_style):
3845         (process_line):
3846         (_process_lines):
3847         (CppChecker):
3848         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3849         (NoNonVirtualDestructorsTest.test_enum_casing):
3850         (NoNonVirtualDestructorsTest.test_internal_braces.Foo):
3851
3852 2012-11-26  Ryuan Choi  <ryuan.choi@gmail.com>
3853
3854         [EFL][jhbuild] Disable unnecessary options of elementary module
3855         https://bugs.webkit.org/show_bug.cgi?id=103360
3856
3857         Reviewed by Gyuyoung Kim.
3858
3859         When jhbuild configures elementary, unnecessary options may be enabled by
3860         user installed modules and it causes build break.
3861
3862         * efl/jhbuild.modules:
3863         Added --disable-emap --disable-ethumb --disable-eweather to elementary.
3864
3865 2012-11-26  Varun Jain  <varunjain@chromium.org>
3866
3867         LongPress and LongTap gestures should start drag/drop and open context menu respectively.
3868         https://bugs.webkit.org/show_bug.cgi?id=101545
3869
3870         Reviewed by Antonio Gomes.
3871
3872         For LongPress, we simulate drag by sending a mouse down and mouse drag
3873         events. If a drag is not started (because maybe there is no draggable
3874         element), then we show context menu instead (which is the current
3875         behavior for LongPress). For LongTap, we use the existing functions that
3876         LongPress uses to summon the context menu. LongPress initiated drag and
3877         drop can be enabled/disabled by the platform using the Setting
3878         touchDragDropEnabled which is disabled by default.
3879
3880         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
3881         (WebTestRunner):
3882         (WebTestRunner::EventSender::EventSender):
3883         (WebTestRunner::EventSender::gestureLongTap):
3884         (WebTestRunner::EventSender::gestureEvent):
3885         * DumpRenderTree/chromium/TestRunner/src/EventSender.h:
3886         (EventSender):
3887         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3888         (WebTestRunner::TestRunner::TestRunner):
3889         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3890         (WebTestRunner):
3891         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3892         (TestRunner):
3893
3894 2012-11-26  Christophe Dumez  <christophe.dumez@intel.com>
3895
3896         [EFL][WK2] Add setting to enable / disable HTML5 local storage functionality
3897         https://bugs.webkit.org/show_bug.cgi?id=103224
3898
3899         Reviewed by Laszlo Gombos.
3900
3901         Add --local-storage command line argument to MiniBrowser to
3902         explicitely disable HTML5 local storage functionality. This
3903         is useful for testing purposes.
3904
3905         * MiniBrowser/efl/main.c:
3906         (window_create):
3907         (elm_main):
3908
3909 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
3910
3911         Remove use of deprecated logging from most of webkitpy.tool
3912         https://bugs.webkit.org/show_bug.cgi?id=103180
3913
3914         Reviewed by Dirk Pranke.
3915
3916         Remove calls to log and error methods of the deprecated_logging module, replacing them
3917         by using Python's Logger objects. This patch covers the switch in all of webkitpy.tool
3918         except the QueueEngine.
3919
3920         Unit tests are adjusted for these changes, moving output from expected stderr to expected logs.
3921
3922         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3923         (MockCommitQueue.run_command):
3924         (MockCommitQueue.command_passed):
3925         (MockCommitQueue.command_failed):
3926         (MockCommitQueue.report_flaky_tests):
3927         (MockCommitQueue.archive_last_test_results):
3928         (CommitQueueTaskTest._run_through_task):
3929         (CommitQueueTaskTest.test_success_case):
3930         (test_fast_success_case):
3931         (test_clean_failure):
3932         (test_update_failure):
3933         (test_apply_failure):
3934         (test_validate_changelog_failure):
3935         (test_build_failure):
3936         (test_red_build_failure):
3937         (test_flaky_test_failure):
3938         (test_failed_archive):
3939         (test_double_flaky_test_failure):
3940         (test_test_failure):
3941         (test_red_test_failure):
3942         (test_very_red_tree_retry):
3943         (test_red_tree_patch_rejection):
3944         (test_land_failure):
3945         * Scripts/webkitpy/tool/bot/feeders.py:
3946         (CommitQueueFeeder._update_work_items):
3947         (EWSFeeder.feed):
3948         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
3949         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
3950         (LayoutTestResultsReader.archive):
3951         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
3952         (test_archive_last_layout_test_results):
3953         * Scripts/webkitpy/tool/bot/sheriff.py:
3954         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
3955         (AbstractSequencedCommand.execute):
3956         * Scripts/webkitpy/tool/commands/commandtest.py:
3957         (CommandsTest.assert_execute_outputs):
3958         * Scripts/webkitpy/tool/commands/download.py:
3959         (AbstractPatchProcessingCommand._process_patch.execute):
3960         (ProcessBugsMixin._fetch_list_of_patches_to_process):
3961         (ProcessURLsMixin._fetch_list_of_patches_to_process):
3962         (AbstractRolloutPrepCommand._commit_info):
3963         * Scripts/webkitpy/tool/commands/download_unittest.py:
3964         (AbstractRolloutPrepCommandTest.test_commit_info):
3965         (DownloadCommandsTest.test_build):
3966         (DownloadCommandsTest.test_build_and_test):
3967         (test_apply_attachment):
3968         (test_apply_from_bug):
3969         (test_apply_watch_list):
3970         (test_land):
3971         (test_land_red_builders):
3972         (test_check_style):
3973         (test_build_attachment):
3974         (test_land_attachment):
3975         (test_land_from_bug):
3976         (test_land_from_url):
3977         (test_prepare_rollout):
3978         (test_create_rollout):
3979         (test_create_rollout_resolved):
3980         (test_rollout):
3981         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3982         (AbstractEarlyWarningSystem.handle_script_error.does):
3983         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3984         (EarlyWarningSytemTest._default_expected_stderr):
3985         (EarlyWarningSytemTest._default_expected_logs):
3986         (EarlyWarningSytemTest._test_testing_ews):
3987         * Scripts/webkitpy/tool/commands/openbugs.py:
3988         (OpenBugs.execute):
3989         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
3990         (OpenBugsTest.test_args_parsing):
3991         * Scripts/webkitpy/tool/commands/perfalizer.py:
3992         (Perfalizer.handle_unexpected_error):
3993         * Scripts/webkitpy/tool/commands/queries.py:
3994         (PatchesInCommitQueue.execute):
3995         (PatchesToCommitQueue._needs_commit_queue):
3996         * Scripts/webkitpy/tool/commands/queries_unittest.py:
3997         (QueryCommandsTest.test_bugs_to_commit):
3998         (QueryCommandsTest.test_patches_in_commit_queue):
3999         (QueryCommandsTest.test_patches_to_commit_queue):
4000         * Scripts/webkitpy/tool/commands/queues.py:
4001         (AbstractQueue._cc_watchers):
4002         (AbstractQueue.begin_work_queue):
4003         (FeederQueue.handle_unexpected_error):
4004         (CommitQueue.handle_script_error):
4005         (AbstractReviewQueue.handle_unexpected_error):
4006         (AbstractReviewQueue.handle_script_error):
4007         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4008         (test_auto_retry):
4009         * Scripts/webkitpy/tool/commands/queuestest.py:
4010         (QueuesTest.assert_outputs):
4011         (QueuesTest._default_begin_work_queue_stderr):
4012         (QueuesTest):
4013         (QueuesTest._default_begin_work_queue_logs):
4014         (QueuesTest.assert_queue_outputs):
4015         * Scripts/webkitpy/tool/commands/roll_unittest.py:
4016         (RollCommandsTest.test_update_chromium_deps):
4017         (test_update_chromium_deps_older_revision):
4018         * Scripts/webkitpy/tool/commands/sheriffbot.py:
4019         (SheriffBot.handle_unexpected_error):
4020         * Scripts/webkitpy/tool/commands/stepsequence.py:
4021         (StepSequence.run_and_handle_errors):
4022         * Scripts/webkitpy/tool/commands/upload.py:
4023         (AssignToCommitter._assign_bug_to_last_patch_attacher):
4024         (AbstractPatchUploadingCommand._prepare_state):
4025         (PostCommits.execute):
4026         (MarkBugFixed._determine_bug_id_and_svn_revision):
4027         (MarkBugFixed.execute):
4028         (CreateBug.create_bug_from_commit):
4029         (CreateBug.execute):
4030         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4031         (test_obsolete_attachments):
4032         (test_land_safely):
4033         (test_mark_bug_fixed):
4034         * Scripts/webkitpy/tool/multicommandtool.py:
4035         (Command.check_arguments_and_execute):
4036         (MultiCommandTool.main):
4037         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
4038         (CommandTest.test_required_arguments):
4039         * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py:
4040         (AddSvnMimetypeForPng.run):
4041         * Scripts/webkitpy/tool/steps/applypatch.py:
4042         (ApplyPatch.run):
4043         * Scripts/webkitpy/tool/steps/build.py:
4044         (Build.run):
4045         * Scripts/webkitpy/tool/steps/checkstyle.py:
4046         * Scripts/webkitpy/tool/steps/closebug.py:
4047         (CloseBug.run):
4048         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
4049         (CloseBugForLandDiff.run):
4050         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
4051         (CloseBugForLandDiffTest.test_empty_state):
4052         * Scripts/webkitpy/tool/steps/commit.py:
4053         (Commit.run):
4054         * Scripts/webkitpy/tool/steps/commit_unittest.py:
4055         (CommitTest._test_check_test_expectations):
4056         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
4057         (EnsureLocalCommitIfNeeded.run):
4058         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
4059         (ObsoletePatches.run):
4060         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4061         (PrepareChangeLog.run):
4062         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
4063         (ReopenBugAfterRollout.run):
4064         * Scripts/webkitpy/tool/steps/runtests.py:
4065         (RunTests.run):
4066         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
4067         (RunTestsTest.test_webkit_run_unit_tests):
4068         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4069         (StepsTest.test_update_step):
4070         (StepsTest.test_runtests_args):
4071         * Scripts/webkitpy/tool/steps/update.py:
4072         (Update.run):
4073         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
4074         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
4075         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_multipatch_bug):
4076         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
4077         (UpdateChangeLogsWithReviewer._guess_reviewer_from_bug):
4078         (UpdateChangeLogsWithReviewer.run):
4079         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
4080         (UpdateChromiumDEPS._validate_revisions):
4081         (UpdateChromiumDEPS.run):
4082         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
4083         (ValidateChangeLogs._check_changelog_diff):
4084         (ValidateChangeLogs.run):
4085         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
4086         (ValidateChangeLogsTest._assert_start_line_produces_output):
4087         * Scripts/webkitpy/tool/steps/validatereviewer.py:
4088         (ValidateReviewer.run):
4089
4090 2012-11-26  Zan Dobersek  <zandobersek@gmail.com>
4091
4092         Coverage testing in webkitpy should omit some paths
4093         https://bugs.webkit.org/show_bug.cgi?id=103267
4094
4095         Reviewed by Dirk Pranke.
4096
4097         Omit testing coverage of any file under /usr directory and any file
4098         that is of third party origin and was autoinstalled.
4099
4100         * Scripts/webkitpy/test/main.py:
4101         (Tester._run_tests):
4102
4103 2012-11-26  Jaehun Lim  <ljaehun.lim@samsung.com>
4104
4105         Text Autosizing: Add Text Autosizing APIs for WK2
4106         https://bugs.webkit.org/show_bug.cgi?id=100633
4107
4108         Reviewed by Sam Weinig.
4109
4110         Add test cases for Text Autosizing in WKPreferences.
4111
4112         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
4113         (TestWebKitAPI::TEST):
4114
4115 2012-11-26  Pierre Rossi  <pierre.rossi@gmail.com>
4116
4117         [Qt] REGRESSION(r135575): It made all tests assert
4118         https://bugs.webkit.org/show_bug.cgi?id=103169
4119
4120         Reviewed by Simon Hausmann.
4121
4122         This fixes another regression introduced in r135515:
4123         initializeWebKitQt shouldn't implicitely call initializeWebCoreQt
4124         since it can be called from WebKit2 to initialize QStyle for testing.
4125         This would then lead to things such as PlatformStrategies being
4126         initialized twice.
4127
4128         * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Also propagate the change to DRT this time.
4129         (WebCore::DumpRenderTree::DumpRenderTree):
4130
4131 2012-11-24  Zan Dobersek  <zandobersek@gmail.com>
4132
4133         Add the --order option to NRWT
4134         https://bugs.webkit.org/show_bug.cgi?id=102229
4135
4136         Reviewed by Dirk Pranke.
4137
4138         The --order option controls in what order the gathered tests will be run.
4139         There are 3 options:
4140         - natural, the tests are sorted in natural order,
4141         - random, the tests are sorted in random order,
4142         - none, the tests are kept in the order in which they were specified through
4143         arguments or the test list.
4144
4145         The natural option is the default one and maintains the current behavior.
4146
4147         The none option is primarily intended to be used with the --test-list option,
4148         with the test list file expected to list specific test names.
4149         When a directory is specified as one of the paths from under which tests should
4150         be gathered and the none option is used, that path will expand to all the tests
4151         under it, with these tests sorted in the natural order.
4152
4153         Using --order=random duplicated the behavior of the --randomize-order option, so
4154         the latter is removed.
4155
4156         This patch also incorporates the change with which makes it is possible to specify
4157         a test via arguments or the test list multiple tests and then have the test run
4158         that many times.
4159
4160         * Scripts/webkitpy/common/find_files.py:
4161         (find): Accept an optional sorting key that is used to sort files found in the directories
4162         that the given paths specify.
4163         (_normalized_find): Both paths that are then searched for the tests and the tests that
4164         were found are now kept in lists. This makes it possible to run a test multiple times
4165         by specifying it multiple times through arguments or the test list file.
4166         (_normalized_find.sort_by_directory_key):
4167         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
4168         (LayoutTestFinder.find_tests): Keep the paths where we should search for tests in a list.
4169         (LayoutTestFinder.skip_tests): Subtracting from a set of paths is necessary.
4170         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4171         (LayoutTestRunner.__init__): The Sharder class no longer needs a test path separator.
4172         (Sharder.__init__): Ditto.
4173         (Sharder._resize_shards):
4174         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
4175         (SharderTests.get_shards): Modify the Shader initializing as required.
4176         (SharderTests.test_multiple_locked_shards): The natural sorting and test name key unit tests
4177         are now moved to the base Port unit tests.
4178         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4179         (Manager._prepare_lists): Keep the test names in a list. Order that list as specified by
4180         the new --order option.
4181         * Scripts/webkitpy/layout_tests/port/base.py:
4182         (Port.tests): This method should now return a list of all the tests found in the specified
4183         paths.
4184         (Port._real_tests): A list is required, so no conversion to a set is made.
4185         (Port):
4186         (Port.test_key): Place this method here for now, but it should really move into a separate
4187         module.
4188         (Port._natural_sort_key): Ditto.
4189         (Port._natural_sort_key.tryint):
4190         (Port._virtual_tests): A list is required, so the function now operates on that rather than
4191         on a set.
4192         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4193         (PortTest.test_find_with_skipped_directories_2): Adjust the test case to check for an empty
4194         list rather than an empty set.
4195         (PortTest.test_dont_require_http_server):
4196         (NaturalCompareTest): The natural sorting unit tests are placed here for now.
4197         (NaturalCompareTest.assert_cmp):
4198         (NaturalCompareTest.test_natural_compare):
4199         (KeyCompareTest): The test name key unit tests are placed here for now.
4200         (KeyCompareTest.assert_cmp):
4201         (KeyCompareTest.test_test_key):
4202         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4203         (parse_args): Remove the --randomize-order option, it's now possible to replicate its behavior
4204         by using --order=random.
4205         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Add unit tests covering
4206         various aspects of this change.
4207         (MainTest.test_natural_order):
4208         (MainTest):
4209         (MainTest.test_natural_order_test_specified_multiple_times):
4210         (MainTest.test_random_order):
4211         (MainTest.test_random_order_test_specified_multiple_times):
4212         (MainTest.test_no_order):
4213         (MainTest.test_no_order_test_specified_multiple_times):
4214         (MainTest.test_no_order_with_directory_entries_in_natural_order):
4215         * Scripts/webkitpy/tool/commands/queries.py:
4216         (PrintExpectations.execute): Operate on a set of tests when printing out expectations.
4217
4218 2012-11-24  Sheriff Bot  <webkit.review.bot@gmail.com>
4219
4220         Unreviewed, rolling out r135600.
4221         http://trac.webkit.org/changeset/135600
4222         https://bugs.webkit.org/show_bug.cgi?id=103173
4223
4224         It made EFL API test is failed (Requested by gyuyoung_mbp on
4225         #webkit).
4226
4227         * TestWebKitAPI/PlatformEfl.cmake:
4228         * TestWebKitAPI/efl/PlatformUtilities.cpp:
4229         (TestWebKitAPI::Util::sleep):
4230         * TestWebKitAPI/efl/PlatformWebView.cpp:
4231
4232 2012-11-23  Alexis Menard  <alexis@webkit.org>
4233
4234         [CSS3 Backgrounds and Borders] Implement new CSS3 background-position parsing.
4235         https://bugs.webkit.org/show_bug.cgi?id=102104
4236
4237         Reviewed by Julien Chaffraix.
4238
4239         Protect the new feature behind a feature flag.
4240
4241         * Scripts/webkitperl/FeatureList.pm:
4242         * qmake/mkspecs/features/features.pri:
4243
4244 2012-11-23  Mario Sanchez Prada  <mario@webkit.org>
4245
4246         Unreviewed. Update my e-mail address.
4247
4248         * Scripts/webkitpy/common/config/committers.py:
4249
4250 2012-11-23  Mateusz Leszko  <m.leszko@samsung.com>
4251
4252         [EFL][GTK] Adapt accessibility feature to WebKitTestRunner.
4253         https://bugs.webkit.org/show_bug.cgi?id=100757
4254
4255         Reviewed by Laszlo Gombos.
4256
4257         Allow to build accessibility feature in WebkitTestRunner for EFL Platform.
4258         Updating CMake files due to changes from Bug 99011.
4259
4260         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
4261         (WTR::AccessibilityController::AccessibilityController):
4262         (WTR):
4263         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
4264         (AccessibilityController):
4265         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
4266         (WTR):
4267         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
4268         (AccessibilityUIElement):
4269         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: - Removed gtk/gtk.h dependency.
4270         * WebKitTestRunner/PlatformEfl.cmake: - Adding atk includes.
4271
4272 2012-11-16  Yury Semikhatsky  <yurys@chromium.org>
4273
4274         Memory instrumentation: extract MemoryObjectInfo declaration into a separate file
4275         https://bugs.webkit.org/show_bug.cgi?id=102510
4276
4277         Reviewed by Pavel Feldman.
4278
4279         Added missing includes.
4280
4281         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
4282
4283 2012-11-23  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
4284
4285         [EFL][WK2] Add support for PlatformWebView::simulateSpacebarKeyPress() in TestWebKitAPI
4286         https://bugs.webkit.org/show_bug.cgi?id=103123
4287
4288         Reviewed by Kenneth Rohde Christiansen.
4289
4290         Add support for PlatformWebView::simulateSpacebarKeyPress() and enable
4291         WebKit2 API test ResponsivenessTimerDoesntFireEarly.
4292