75b11446984175ea3177aaf886bb77eade92876f
[WebKit-https.git] / Tools / ChangeLog
1 2013-04-10  Benjamin Poulain  <bpoulain@apple.com>
2
3         Mass remove all the empty directories
4
5         Rubberstamped by Ryosuke Niwa.
6
7         * BuildSlaveSupport/gtk/crashmon/log: Removed.
8         * BuildSlaveSupport/gtk/xvfb/log: Removed.
9         * DumpRenderTree/ForwardingHeaders/wtf: Removed.
10         * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit: Removed.
11         * MiniBrowser/gtk/WebBundle: Removed.
12         * MiniBrowser/win: Removed.
13         * QtTestPlatformPlugin/mac: Removed.
14         * Scripts/webkitpy/tool/bot/testdata: Removed.
15         * Scripts/webkitpy/tool/commands/data/rebaselineserver: Removed.
16         * efl/ImageDiff: Removed.
17         * iExploder/htdocs: Removed.
18         * iExploder/iexploder-1.7.2/output: Removed.
19         * iExploder/tools: Removed.
20         * qmake/config.tests/libexecdir: Removed.
21         * qmake/config.tests/libjpeg: Removed.
22         * qmake/config.tests/libpng: Removed.
23
24 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
25
26         Use webkit-queeus.appspot.com instead of webkit-commit-queue.appspot.com
27         https://bugs.webkit.org/show_bug.cgi?id=114397
28
29         Reviewed by Benjamin Poulain.
30
31         * Scripts/webkitpy/common/net/statusserver.py:
32         (StatusServer):
33
34 2013-04-10  Adam Barth  <abarth@webkit.org>
35
36         Remove abarth from watchlists
37         https://bugs.webkit.org/show_bug.cgi?id=114390
38
39         Reviewed by Ryosuke Niwa.
40
41         I'm trying to cut down on the amount of bugmail I get so that I'll have
42         more of a chance to notice a piece of bugmail directed at me.
43
44         * Scripts/webkitpy/common/config/watchlist:
45
46 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
47
48         webkit-test-results.appspot.com loads the dashboard for Chromium by default
49         https://bugs.webkit.org/show_bug.cgi?id=114381
50
51         Reviewed by Benjamin Poulain.
52
53         Changed the defaults.
54
55         * TestResultServer/static-dashboards/builders.js:
56         * TestResultServer/static-dashboards/dashboard_base.js:
57         (currentBuilderGroupCategory):
58
59 2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
60
61         Remove Chromium EWS bots from the queue status server
62         https://bugs.webkit.org/show_bug.cgi?id=113988
63
64         Reviewed by Benjamin Poulain.
65
66         Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
67
68         * QueueStatusServer/app.yaml:
69         * QueueStatusServer/config/queues.py:
70         * QueueStatusServer/model/queues.py:
71         (Queue.short_name):
72         (Queue.display_name):
73         * QueueStatusServer/model/queues_unittest.py:
74         (QueueTest.test_short_name):
75         (QueueTest.test_display_name):
76         (QueueTest.test_name_with_underscores):
77         * QueueStatusServer/templates/activebots.html:
78
79 2013-04-10  Ojan Vafai  <ojan@chromium.org>
80
81         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
82         https://bugs.webkit.org/show_bug.cgi?id=114370
83
84         Reviewed by Ryosuke Niwa.
85
86         Finish the transition of WebKit over to it's own instance of the flakiness dashboard.
87         Unfortunately, there's no way to test this until this is committed and there is
88         a master restart.
89
90         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
91         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
92         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
93         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
94         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
95         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
96         * TestResultServer/generate_builders_json.py:
97         * TestResultServer/static-dashboards/dashboard_base.js:
98         * TestResultServer/static-dashboards/loader.js:
99
100 2013-04-10  Glenn Adams  <glenn@skynav.com>
101
102         [Qt] Fix regression to test-webkitpy.
103         https://bugs.webkit.org/show_bug.cgi?id=114368
104
105         Reviewed by Ryosuke Niwa.
106
107         * Scripts/webkitpy/layout_tests/port/factory.py:
108         (PortFactory._default_port): Return qt-linux instead of chromium-linux as default port for linux/freebsd.
109         (PortFactory.get): Remove obsolete chromium port related code.
110         * Scripts/webkitpy/layout_tests/port/mac.py:
111         (MacPort.default_child_processes): Prevent type error if can't determine total memory.
112
113 2013-04-10  Anders Carlsson  <andersca@apple.com>
114
115         Remove unneeded headers from FrameLoader.h
116         https://bugs.webkit.org/show_bug.cgi?id=114223
117
118         Reviewed by Geoffrey Garen.
119
120         Add back headers implicitly included by other headers.
121
122         * WebKitTestRunner/WorkQueueManager.cpp:
123
124 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
125
126         [GTK] Include a crash-fixing patch for the at-spi2-atk dependency
127         https://bugs.webkit.org/show_bug.cgi?id=114365
128
129         Reviewed by Martin Robinson.
130
131         Add a patch for the at-spi2-atk 2.8.0 dependency that is applied through the Jhbuild setup.
132         The patch addresses crashes in the tally_event_reply method. It is already committed into the
133         at-spi2-atk source tree and will be available with the next stable release, after which the
134         patch should be removed and the dependency version bumped.
135
136         * gtk/jhbuild.modules:
137         * gtk/patches/at-spi2-atk-2.8.0-null-check-after-cleanup.patch: Added.
138
139 2013-04-10  Brent Fulgham  <bfulgham@webkit.org>
140
141         [WinCairo] Unreviewed build fix. Correct DropBox download link.
142
143         * Scripts/update-webkit-wincairo-libs: Revise download URL to
144         match change in DropBox server behavior.
145
146 2013-04-09  Geoffrey Garen  <ggaren@apple.com>
147
148         Removed an annoying message from svn-create-patch
149         https://bugs.webkit.org/show_bug.cgi?id=114332
150
151         Reviewed by Alexey Proskuryakov.
152
153         I see this message basically every time I write a patch, so it must not
154         be true.
155
156         * Scripts/svn-create-patch:
157         (generateDiff):
158
159 2013-04-10  Anton Obzhirov  <a.obzhirov@samsung.com>
160
161         [GTK] Add support for Page Visibility
162         https://bugs.webkit.org/show_bug.cgi?id=97324
163
164         Reviewed by Sam Weinig.
165
166         Implemented test runner API for page visibility layout tests.
167
168         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
169         (TestRunner::resetPageVisibility):
170         (TestRunner::setPageVisibility):
171         * Scripts/webkitperl/FeatureList.pm:
172
173 2013-04-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
174
175         [ATK] REGRESSION(r148033): Add a stub for AccessibilityUIElement::pathDescription().
176         https://bugs.webkit.org/show_bug.cgi?id=114342
177
178         Reviewed by Gyuyoung Kim.
179
180         Commit 148033 only added an implementation for the Mac port, which made
181         other ports fail most tests since loading the injected bundle failed
182         with a missing symbol.
183
184         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
185         (WTR::AccessibilityUIElement::pathDescription):
186
187 2013-04-10  Artur Moryc  <a.moryc@samsung.com>
188
189         [EFL] Add spell checking option to MiniBrowser
190         https://bugs.webkit.org/show_bug.cgi?id=114282
191
192         Reviewed by Ryosuke Niwa.
193
194         Spell checking is enabled by adding a flag (t/text-checking)
195         with launching MiniBrowser.
196
197         * MiniBrowser/efl/main.c:
198         (window_create):
199         (elm_main):
200
201 2013-04-10  Zan Dobersek  <zdobersek@igalia.com>
202
203         REGRESSION (r146518): WebKit2APITests/TestInspector is failing
204         https://bugs.webkit.org/show_bug.cgi?id=113281
205
206         Reviewed by Darin Adler.
207
208         * Scripts/run-gtk-tests:
209         (TestRunner): Remove the skip entry for the WebKit2APITests/TestInspector unit test.
210
211 2013-04-09  Glenn Adams  <glenn@skynav.com>
212
213         Fix trivial test-webkitpy regression introduced by http://trac.webkit.org/changeset/148075.
214
215         Unreviewed.
216
217         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
218         (RunTest.test_build_check):
219
220 2013-04-09  Glenn Adams  <glenn@skynav.com>
221
222         [webkitpy] Remove chromium ports.
223         https://bugs.webkit.org/show_bug.cgi?id=114326
224
225         Reviewed by Dirk Pranke.
226
227         As a side effect, also:
228
229         - remove chromium builders from webkitpy.layout_tests.port.builders
230         - remove chromium builders from rebaseline
231         - rewrite chromium dependent tests in rebaseline_unittest
232         - remove chromium platform from garden-o-matic
233         - select apple platform as default platform in garden-o-matic
234         - remove chromium port dependencies from a few other tests (run_webkit_tests_integrationtest, factory_unittest, style.checkers.test_expectations_unittest)
235
236         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
237         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
238         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
239         (BaselineOptimizerTest.test_move_baselines):
240         (BaselineOptimizerTest.test_efl):
241         (BaselineOptimizerTest.test_no_add_mac_future):
242         (BaselineOptimizerTest.test_win_does_not_drop_to_win_7sp0):
243         (BaselineOptimizerTest.test_common_directory_includes_root):
244         (BaselineOptimizerTest.test_complex_shadowing):
245         (BaselineOptimizerTest.test_virtual_ports_filtered):
246         * Scripts/webkitpy/layout_tests/port/builders.py:
247         * Scripts/webkitpy/layout_tests/port/chromium.py: Removed.
248         * Scripts/webkitpy/layout_tests/port/chromium_android.py: Removed.
249         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py: Removed.
250         * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Removed.
251         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Removed.
252         * Scripts/webkitpy/layout_tests/port/chromium_mac.py: Removed.
253         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py: Removed.
254         * Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py: Removed.
255         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Removed.
256         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Removed.
257         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: Removed.
258         * Scripts/webkitpy/layout_tests/port/factory.py:
259         (platform_options):
260         (PortFactory):
261         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
262         (FactoryTest.test_qt):
263         (FactoryTest.test_get_from_builder_name):
264         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
265         (RunTest.test_build_check):
266         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
267         (TestExpectationsTestCase.test_determine_port_from_expectations_path):
268         * Scripts/webkitpy/tool/commands/rebaseline.py:
269         (Rebaseline._builders_to_pull_from):
270         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
271         (_BaseTestCase):
272         (_BaseTestCase.setUp):
273         (TestRebaselineTest.setUp):
274         (TestRebaselineTest.test_baseline_directory):
275         (test_rebaseline_updates_expectations_file):
276         (test_rebaseline_does_not_include_overrides):
277         (test_rebaseline_test):
278         (test_rebaseline_test_and_print_scm_changes):
279         (test_rebaseline_and_copy_test):
280         (test_rebaseline_and_copy_test_no_existing_result):
281         (test_rebaseline_and_copy_test_with_lion_result):
282         (test_rebaseline_and_copy_no_overwrite_test):
283         (TestRebaselineExpectations.test_rebaseline_expectations):
284
285 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
286
287         newcommitbot (WKR) requires a subversion checkout
288         https://bugs.webkit.org/show_bug.cgi?id=114309
289
290         Reviewed by Benjamin Poulain.
291
292         Directly talk to the subversion server instead of relying on a local checkout.
293         This allows us to run WKR off of a git clone.
294
295         * Scripts/webkitpy/tool/commands/newcommitbot.py:
296         (NewCommitBot.next_work_item):
297         (NewCommitBot.process_work_item):
298
299 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
300
301         webkitbot refers to sheriffbot in help
302         https://bugs.webkit.org/show_bug.cgi?id=114307
303
304         Reviewed by Benjamin Poulain.
305
306         Fixed the bug by proxying the IRC nickname of "sheriffbot" via Sheriff object.
307
308         * Scripts/webkitpy/tool/bot/irc_command.py:
309         (Help):
310         (Help.execute):
311         (RollChromiumDEPS.execute):
312         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
313         (IRCBotTest.test_help):
314         * Scripts/webkitpy/tool/bot/sheriff.py:
315         (Sheriff.name):
316
317 2013-04-06  Roger Fong  <roger_fong@apple.com>
318
319         Kill old processes between runs on WinEWS bots.
320         Temporarily disable tests to let bots catch up again.
321
322         * EWSTools/start-queue-win.sh:
323         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
324         (WinEWS):
325
326 2013-04-09  Glenn Adams  <glenn@skynav.com>
327
328         [webkitpy] Remove chromium deprecated port support.
329         https://bugs.webkit.org/show_bug.cgi?id=114228
330
331         Reviewed by Ryosuke Niwa.
332
333         * Scripts/webkitpy/common/config/ports.py:
334         (DeprecatedPort.port): Removed chromium ports from port name to port class mapping.
335         (ChromiumPort): Removed.
336         (ChromiumAndroidPort): Removed.
337         (ChromiumXVFBPort): Removed.
338         * Scripts/webkitpy/common/config/ports_unittest.py:
339         (DeprecatedPortTest.test_chromium_port): Removed.
340         (DeprecatedPortTest.test_chromium_android_port): Removed.
341         (DeprecatedPortTest.test_chromium_xvfb_port): Removed.
342         * Scripts/webkitpy/tool/steps/update_unittest.py:
343         (UpdateTest.test_update_command_non_interactive): Use mac instead of chromium ports.
344         (UpdateTest.test_update_command_interactive): Use mac instead of chromium ports.
345
346 2013-04-09  Chris Fleizach  <cfleizach@apple.com>
347
348         AX: The bounding paths should be made available through accessibility
349         https://bugs.webkit.org/show_bug.cgi?id=113817
350
351         Reviewed by David Kilzer.
352
353         Add a pathDescription property for testing so that it's possible
354         to verify that a path is being returned correctly.
355
356         * DumpRenderTree/AccessibilityUIElement.cpp:
357         (getPathDescriptionCallback):
358         (AccessibilityUIElement::pathDescription):
359         (AccessibilityUIElement::getJSClass):
360         * DumpRenderTree/AccessibilityUIElement.h:
361         (AccessibilityUIElement):
362         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
363         (_CGPathEnumerationIteration):
364         (AccessibilityUIElement::pathDescription):
365         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
366         (AccessibilityUIElement::pathDescription):
367         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
368         (WTR::AccessibilityUIElement::pathDescription):
369         (WTR):
370         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
371         (AccessibilityUIElement):
372         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
373         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
374         (WTR::AccessibilityUIElement::pathDescription):
375         (WTR):
376
377 2013-04-09  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
378
379         [EFL] Declare TEST_THEME_DIR in a single place.
380         https://bugs.webkit.org/show_bug.cgi?id=114285
381
382         Reviewed by Anders Carlsson.
383
384         Adapt to the renaming of `THEME_DIR' to `TEST_THEME_DIR'.
385
386         * DumpRenderTree/efl/CMakeLists.txt:
387         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
388         (DumpRenderTreeChrome::createView):
389         (DumpRenderTreeChrome::createInspectorView):
390         (DumpRenderTreeChrome::initialize):
391         (DumpRenderTreeChrome::onDownloadRequest):
392         * EWebLauncher/CMakeLists.txt:
393         * EWebLauncher/main.c:
394         (findThemePath):
395         * EWebLauncher/url_bar.c:
396         (url_bar_add):
397         * MiniBrowser/efl/CMakeLists.txt:
398         * MiniBrowser/efl/main.c:
399         (window_create):
400         * TestWebKitAPI/PlatformEfl.cmake:
401         * TestWebKitAPI/efl/PlatformWebView.cpp:
402         (TestWebKitAPI::PlatformWebView::PlatformWebView):
403         * WebKitTestRunner/PlatformEfl.cmake:
404         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
405         (WTR::PlatformWebView::PlatformWebView):
406
407 2013-04-09  ChangSeok Oh  <changseok.oh@collabora.com>
408
409         [GTK][AC] upversion of clutter and its dependecy
410         https://bugs.webkit.org/show_bug.cgi?id=114016
411
412         Reviewed by Gustavo Noronha Silva.
413
414         Upversion of clutter to 1.14, cogl to 1.14 and clutter-gtk to 1.4.4.
415
416         * gtk/jhbuild-optional.modules:
417
418 2013-04-09  Thiago Marcos P. Santos  <thiago.santos@intel.com>
419
420         [WK2] Drop WebProcess capabilities on Linux using seccomp filters
421         https://bugs.webkit.org/show_bug.cgi?id=89875
422
423         Reviewed by Maciej Stachowiak.
424
425         Add unit tests to verify if the handling of the open, openat, creat syscall
426         is being done right. We check if the Read/Write/ReadAndWrite permissions
427         are respected, if the canonical path is being resolved and if
428         the permissions are falling back to the topmost parent directory with a
429         policy set when the directory being opened has no policy.
430
431         We also test if any attempt of blocking SIGSYS is silently ignored.
432         SIGSYS cannot be blocked because in it's handler is where we hook
433         syscalls to the broker process.
434
435         Also added libseccomp to EFL's jhbuild to make the life of developers
436         willing to help easier.
437
438         * Scripts/webkitperl/FeatureList.pm:
439         * TestWebKitAPI/PlatformEfl.cmake:
440         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Added.
441         (TestWebKitAPI):
442         (SeccompEnvironment):
443         (TestWebKitAPI::SeccompEnvironment::SetUp):
444         (TestWebKitAPI::SeccompEnvironment::TearDown):
445         (TestWebKitAPI::dummyHandler):
446         (TestWebKitAPI::TEST):
447         (TestWebKitAPI::stressTest):
448         * efl/jhbuild.modules:
449         * qmake/mkspecs/features/features.pri:
450
451 2013-04-09  Ryosuke Niwa  <rniwa@webkit.org>
452
453         REGRESSION: Autocorrection doesn't work in DumpRenderTree
454         https://bugs.webkit.org/show_bug.cgi?id=113846
455
456         Reviewed by Alexey Proskuryakov.
457
458         The problem was that we were replacing NSSpellCheck's dictionary with our own
459         in DumpRenderTree but we were not adding necessary corrections to the dictionary.
460
461         Fixed the bug by having NSSpellChecker correct "mesage" and "wouldn" to "message"
462         and "would" respectively in DumpRenderTree.
463
464         * DumpRenderTree/mac/DumpRenderTree.mm:
465         (resetDefaultsToConsistentValues):
466
467 2013-04-09  Benjamin Poulain  <benjamin@webkit.org>
468
469         Remove the gyp files for Tools
470         https://bugs.webkit.org/show_bug.cgi?id=114248
471
472         Reviewed by Ryosuke Niwa.
473
474         * DumpRenderTree/DumpRenderTree.gyp: Removed.
475         * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Removed.
476         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Removed.
477         * DumpRenderTree/DumpRenderTree.gypi: Removed.
478         * TestWebKitAPI/TestWebKitAPI.gyp: Removed.
479         * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Removed.
480         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Removed.
481         * TestWebKitAPI/TestWebKitAPI.gypi: Removed.
482
483 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
484
485         WKR (new-commit-bot) is too slow
486         https://bugs.webkit.org/show_bug.cgi?id=110087
487
488         Reviewed by Geoffrey Garen.
489
490         Running "svn up" or "git svn fetch" is way too slow (takes 2-3 minutes) on the machine I'm running the bot.
491         Just run "svn log -r <revision>" instead to cut down the delay.
492
493         Unfortunately, this work around doesn't work in a git checkout but who cares given I'm the one running the bot.
494
495         * Scripts/webkitpy/tool/commands/newcommitbot.py:
496         (NewCommitBot):
497         (NewCommitBot.next_work_item):
498         (NewCommitBot._is_empty_log):
499         (NewCommitBot._update_checkout):
500
501 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
502
503         Build fix. Can't remove appendCustomBuildFlags.
504
505         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
506         (appendCustomBuildFlags):
507
508 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
509
510         Remove Chromium builders from build.webkit.org
511         https://bugs.webkit.org/show_bug.cgi?id=113990
512
513         Reviewed by Benjamin Poulain.
514
515         Removed.
516
517         * BuildSlaveSupport/build.webkit.org-config/config.json:
518         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
519         (InstallGtkDependencies):
520         (RunUnitTests.start):
521         (RunWebKit2Tests.start):
522         (Factory.__init__):
523         (unitTestsSupported):
524         (TestFactory.__init__):
525         (BuildAndTestFactory.__init__):
526         (BuildAndPerfTestFactory.__init__):
527         (BuildAndPerfTestWebKit2Factory.__init__):
528         (DownloadAndPerfTestFactory.__init__):
529         (loadBuilderConfig):
530         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
531
532 2013-04-08  Benjamin Poulain  <benjamin@webkit.org>
533
534         Remove HTML Notification
535         https://bugs.webkit.org/show_bug.cgi?id=114231
536
537         Reviewed by Ryosuke Niwa.
538
539         * qmake/mkspecs/features/features.pri:
540
541 2013-04-08  Glenn Adams  <glenn@skynav.com>
542
543         Remove chromium EWS support, and fix broken test.
544         https://bugs.webkit.org/show_bug.cgi?id=114221
545
546         Reviewed by Ryosuke Niwa.
547
548         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
549         (AbstractChromiumEWS): Removed.
550         (ChromiumLinuxEWS): Removed.
551         (ChromiumLinuxDebugEWS): Removed.
552         (ChromiumWindowsEWS): Removed.
553         (ChromiumAndroidEWS): Removed.
554         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
555         (EarlyWarningSystemTest): Fix misspelled class name.
556         (test_ewses): Fix entry point name to ensure test is run.
557
558 2013-04-08  Patrick Gansterer  <paroga@webkit.org>
559
560         [WIN] Remove WebKit2 source code
561         https://bugs.webkit.org/show_bug.cgi?id=114096
562
563         Reviewed by Anders Carlsson.
564
565         Remove the windows specific parts of the MiniBrowser.
566
567         * MiniBrowser/MiniBrowser.vcproj: Removed.
568         * MiniBrowser/MiniBrowserLauncher.vcproj: Removed.
569         * MiniBrowser/MiniBrowserPostBuild.cmd: Removed.
570         * MiniBrowser/MiniBrowserPreBuild.cmd: Removed.
571         * MiniBrowser/win/BrowserView.cpp: Removed.
572         * MiniBrowser/win/BrowserView.h: Removed.
573         * MiniBrowser/win/BrowserWindow.cpp: Removed.
574         * MiniBrowser/win/BrowserWindow.h: Removed.
575         * MiniBrowser/win/MiniBrowser.cpp: Removed.
576         * MiniBrowser/win/MiniBrowser.h: Removed.
577         * MiniBrowser/win/MiniBrowser.rc: Removed.
578         * MiniBrowser/win/main.cpp: Removed.
579         * MiniBrowser/win/resource.h: Removed.
580         * MiniBrowser/win/stdafx.cpp: Removed.
581         * MiniBrowser/win/stdafx.h: Removed.
582
583 2013-04-08  Ryosuke Niwa  <rniwa@webkit.org>
584
585         Use port 6665 instead of 6667 since the latter doesn't seem to work well.
586
587         * Scripts/webkitpy/common/config/irc.py:
588
589 2013-04-08  Arunprasad Rajkumar  <arunprasadr@nds.com>
590
591         Call Netscape Plugin's toString() and valueOf() instead of providing default implementation
592         https://bugs.webkit.org/show_bug.cgi?id=113139
593
594         Reviewed by Anders Carlsson.
595
596         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
597         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
598         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
599         * DumpRenderTree/TestNetscapePlugIn/Tests/ToStringAndValueOfObject.cpp: Added.
600         (ToStringAndValueOfObject):
601         (ToStringAndValueOfObject::ToStringAndValueOfObject):
602         (ScriptableObject):
603         (ToStringAndValueOfObject::ScriptableObject::hasMethod):
604         (ToStringAndValueOfObject::ScriptableObject::invoke):
605         (ToStringAndValueOfObject::ScriptableObject::pluginTest):
606         (ToStringAndValueOfObject::NPP_GetValue):
607         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
608         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
609         * GNUmakefile.am:
610
611 2013-04-08  Manuel Rego Casasnovas  <rego@igalia.com>
612
613         [GTK] Bump gnome-themes-standard to 3.6.0
614         https://bugs.webkit.org/show_bug.cgi?id=114155
615
616         Reviewed by Martin Robinson.
617
618         * gtk/jhbuild.modules: As now we depend on GTK+ 3.6.0 bump the
619         dependency of gnome-themes-standard accordingly.
620
621 2013-04-08  David Levin  <levin@chromium.org>
622
623         Remove my watchlist entries.
624         https://bugs.webkit.org/show_bug.cgi?id=114180
625
626         Reviewed by Adam Barth.
627
628         * Scripts/webkitpy/common/config/committers.py:
629         * Scripts/webkitpy/common/config/watchlist:
630
631 2013-04-08  Christophe Dumez  <ch.dumez@sisa.samsung.com>
632
633         [EFL] Mark ShouldGoToBackForwardListItem API test as failing
634         https://bugs.webkit.org/show_bug.cgi?id=114161
635
636         Reviewed by Gyuyoung Kim.
637
638         Mark ShouldGoToBackForwardListItem API test as failing for EFL port
639         as it is crashing due to Bug 111074.
640
641         * TestWebKitAPI/PlatformEfl.cmake:
642
643 2013-04-07  David Kilzer  <ddkilzer@apple.com>
644
645         Remove the rest of SVG_DOM_OBJC_BINDINGS
646         <http://webkit.org/b/114112>
647
648         Reviewed by Geoffrey Garen.
649
650         * Scripts/webkitperl/FeatureList.pm:
651         - Remove --svg-dom-objc-bindings switch.
652         * qmake/mkspecs/features/features.pri:
653         - Remove reference to ENABLE_SVG_DOM_OBJC_BINDINGS.
654
655 2013-04-07  Ed Bartosh  <bartosh@gmail.com>
656
657         [EFL] -minimal build fails with error: WebCore::FrameSelection::notifyAccessibilityForSelectionChange()
658         https://bugs.webkit.org/show_bug.cgi?id=114089
659
660         Reviewed by Chris Fleizach.
661
662         Wrapped accessibility related code in #if HAVE(ACCESSIBILITY)
663         * DumpRenderTree/AccessibilityController.cpp:
664         * DumpRenderTree/AccessibilityUIElement.cpp:
665         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
666         (DumpRenderTreeChrome::DumpRenderTreeChrome):
667         * DumpRenderTree/efl/DumpRenderTreeChrome.h:
668         (DumpRenderTreeChrome):
669
670 2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>
671
672         Build fix after r147857, remove remaining USE(JSC) guards.
673
674         Unreviewed.
675
676         * DumpRenderTree/config.h:
677         * TestWebKitAPI/config.h:
678         * WebKitTestRunner/config.h:
679
680 2013-04-06  Ryosuke Niwa  <rniwa@webkit.org>
681
682         Rename sheriffbot to webkitbot
683         https://bugs.webkit.org/show_bug.cgi?id=114109
684
685         Reviewed by Benjamin Poulain.
686
687         Renamed since sheriffbot will be used in Blink.
688
689         * Scripts/webkitpy/tool/commands/sheriffbot.py:
690         (SheriffBot):
691         (SheriffBot.begin_work_queue):
692
693 2013-04-06  Oliver Hunt  <oliver@apple.com>
694
695         Unify the many and varied stack trace mechanisms, and make the result sane.
696         https://bugs.webkit.org/show_bug.cgi?id=114072
697
698         Reviewed by Filip Pizlo.
699
700         The commandline jsc executable no longer requires arguments, so
701         I've made run-jsc work without them.
702
703         * Scripts/run-jsc:
704
705 2013-04-06  Ed Bartosh  <bartosh@gmail.com>
706
707         [EFL] build fails with error: 'UINT_MAX' was not declared in this scope
708         https://bugs.webkit.org/show_bug.cgi?id=114086
709
710         Reviewed by Tim Horton.
711
712         * DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h
713
714 2013-04-06  Zan Dobersek  <zdobersek@igalia.com>
715
716         Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
717         https://bugs.webkit.org/show_bug.cgi?id=114083
718
719         Reviewed by Ryosuke Niwa.
720
721         Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
722         in TestWebKitAPI and WebKitTestRunner.
723
724         * TestWebKitAPI/config.h:
725         * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
726         (TestWebKitAPI::InjectedBundleController::platformInitialize):
727         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
728         (WTR::InjectedBundle::platformInitialize):
729
730 2013-04-06  Geoffrey Garen  <ggaren@apple.com>
731
732         Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
733         https://bugs.webkit.org/show_bug.cgi?id=114094
734
735         Reviewed by Anders Carlsson.
736
737         * Scripts/run-jsc:
738
739 2013-04-05  Ojan Vafai  <ojan@chromium.org>
740
741         Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
742         https://bugs.webkit.org/show_bug.cgi?id=114080
743
744         Reviewed by Ryosuke Niwa.
745
746         This way, the WebKit and Blink dashboard code can change as appropriate without
747         needing to consider the other project's needs. This still doesn't update the
748         buildbots to upload to the new location, or the dashboard code to pull the
749         results.json files from the new location, but it at least allows for changing the
750         UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).
751
752         * TestResultServer/app.yaml:
753
754 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
755
756         Re-enable testing on the commit queue
757         https://bugs.webkit.org/show_bug.cgi?id=114078
758
759         Reviewed by Darin Adler.
760
761         Re-enabled the feature and the associated tests.
762
763         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
764         (CommitQueueTask.run):
765         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
766         (CommitQueueTaskTest._run_through_task):
767         * Scripts/webkitpy/tool/commands/queues_unittest.py:
768         (CommitQueueTest._mock_test_result):
769
770 2013-04-05  Oliver Hunt  <oliver@apple.com>
771
772         Unify the many and varied stack trace mechanisms, and make the result sane.
773         https://bugs.webkit.org/show_bug.cgi?id=114072
774
775         Reviewed by Filip Pizlo.
776
777         The commandline jsc executable no longer requires arguments, so
778         I've made run-jsc work without them.
779
780         * Scripts/run-jsc:
781
782 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
783
784         AX: Make SVG Group containers accessible elements
785         https://bugs.webkit.org/show_bug.cgi?id=113939
786
787         Reviewed by Simon Fraser.
788
789         Implement axController.elementAtPoint for iOS.
790         Implement a correct version of clickPoint for iOS.
791
792         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
793         (AccessibilityController::elementAtPoint):
794         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
795         (AccessibilityUIElement::clickPointX):
796         (AccessibilityUIElement::clickPointY):
797
798 2013-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>
799
800         Unreviewed, rolling out r147773 and r147774.
801         http://trac.webkit.org/changeset/147773
802         http://trac.webkit.org/changeset/147774
803         https://bugs.webkit.org/show_bug.cgi?id=114056
804
805         Causing some exceptions on AppEngine I don't understand
806         (Requested by rniwa on #webkit).
807
808         * QueueStatusServer/config/queues.py:
809         * QueueStatusServer/model/queues.py:
810         (Queue.short_name):
811         (Queue.display_name):
812         * QueueStatusServer/model/queues_unittest.py:
813         (QueueTest.test_short_name):
814         (QueueTest.test_display_name):
815         (QueueTest.test_name_with_underscores):
816
817 2013-04-05  Geoffrey Garen  <ggaren@apple.com>
818
819         Fixed run-bindings-tests by removing V8
820         https://bugs.webkit.org/show_bug.cgi?id=114053
821
822         Reviewed by Benjamin Poulain.
823
824         * Scripts/run-bindings-tests:
825         (main):
826
827 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
828
829         Build fix.
830
831         * QueueStatusServer/model/queues.py:
832         (Queue.short_name):
833         (Queue.display_name):
834
835 2013-04-05  Ryosuke Niwa  <rniwa@webkit.org>
836
837         Remove Chromium EWS bots from the queue status server
838         https://bugs.webkit.org/show_bug.cgi?id=113988
839
840         Reviewed by Benjamin Poulain.
841
842         Removed Chromium EWS bots.
843
844         * QueueStatusServer/config/queues.py:
845         * QueueStatusServer/model/queues.py:
846         (Queue.short_name):
847         (Queue.display_name):
848         * QueueStatusServer/model/queues_unittest.py:
849         (QueueTest.test_short_name):
850         (QueueTest.test_display_name):
851         (QueueTest.test_name_with_underscores):
852
853 2013-04-05  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
854
855         [EFL] Enable indexed database
856         https://bugs.webkit.org/show_bug.cgi?id=107248
857
858         Reviewed by Alexis Menard.
859
860         * Scripts/webkitperl/FeatureList.pm:
861
862 2013-04-05  Dimitri Glazkov  <dglazkov@chromium.org>
863
864         Remove vestiges of Chromium bits from watchlists.
865         https://bugs.webkit.org/show_bug.cgi?id=114047
866
867         Reviewed by Ryosuke Niwa.
868
869         * Scripts/webkitpy/common/config/watchlist: Removed vestiges.
870
871 2013-04-05  Chris Fleizach  <cfleizach@apple.com>
872
873         Add James Craig to the contributors list.
874
875         * Scripts/webkitpy/common/config/committers.py:
876
877 2013-04-04  Kent Tamura  <tkent@chromium.org>
878
879         Remove ChromiumPublicApi pattern, and cc/message rules for it.
880
881         * Scripts/webkitpy/common/config/watchlist:
882
883 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
884
885         Temporarily disable the Python unittests broken by the commit queue not running layout tests
886         https://bugs.webkit.org/show_bug.cgi?id=113997
887
888         Reviewed by Ryosuke Niwa.
889
890         Disable the tests until Ryosuke gets the time and hardware to have
891         a testing commit-queue.
892
893         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
894         (CommitQueueTaskTest):
895         * Scripts/webkitpy/tool/commands/queues_unittest.py:
896         (CommitQueueTest):
897
898 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
899
900         Remove Chromium builders from build.webkit.org
901         https://bugs.webkit.org/show_bug.cgi?id=113990
902
903         Reviewed by Benjamin Poulain.
904
905         Land the part to disable triggering of Chromium builders first so that we may start
906         deleting more Chromium code that breaks the update step.
907
908         * BuildSlaveSupport/build.webkit.org-config/config.json:
909
910 2013-04-04  Benjamin Poulain  <bpoulain@apple.com>
911
912         Remove Chromium's DumpRenderTree
913         https://bugs.webkit.org/show_bug.cgi?id=113989
914
915         Reviewed by Kent Tamura.
916
917         On second thought, let's not go to Camelot. It is a silly place.
918
919         * DumpRenderTree/mac/DumpRenderTree.mm:
920         (resetDefaultsToConsistentValues):
921
922 2013-04-04  Geoffrey Garen  <ggaren@apple.com>
923
924         Nixed the defunct chromium folder from DumpRenderTree
925         https://bugs.webkit.org/show_bug.cgi?id=113993
926
927         Reviewed by Ryosuke Niwa.
928
929         * DumpRenderTree/chromium: Removed.
930         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp: Removed.
931         * DumpRenderTree/chromium/DRTDevToolsAgent.h: Removed.
932         * DumpRenderTree/chromium/DRTDevToolsClient.cpp: Removed.
933         * DumpRenderTree/chromium/DRTDevToolsClient.h: Removed.
934         * DumpRenderTree/chromium/DumpRenderTree.cpp: Removed.
935         * DumpRenderTree/chromium/ImageDiff.cpp: Removed.
936         * DumpRenderTree/chromium/LayoutTestHelper.mm: Removed.
937         * DumpRenderTree/chromium/LayoutTestHelperWin.cpp: Removed.
938         * DumpRenderTree/chromium/MockPlatform.cpp: Removed.
939         * DumpRenderTree/chromium/MockPlatform.h: Removed.
940         * DumpRenderTree/chromium/MockWebPrerenderingSupport.cpp: Removed.
941         * DumpRenderTree/chromium/MockWebPrerenderingSupport.h: Removed.
942         * DumpRenderTree/chromium/Task.cpp: Removed.
943         * DumpRenderTree/chromium/Task.h: Removed.
944         * DumpRenderTree/chromium/TestEventPrinter.cpp: Removed.
945         * DumpRenderTree/chromium/TestEventPrinter.h: Removed.
946         * DumpRenderTree/chromium/TestNavigationController.cpp: Removed.
947         * DumpRenderTree/chromium/TestNavigationController.h: Removed.
948         * DumpRenderTree/chromium/TestNetscapePlugIn: Removed.
949         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders: Removed.
950         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit: Removed.
951         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Removed.
952         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Removed.
953         * DumpRenderTree/chromium/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Removed.
954         * DumpRenderTree/chromium/TestRunner: Removed.
955         * DumpRenderTree/chromium/TestRunner/public: Removed.
956         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h: Removed.
957         * DumpRenderTree/chromium/TestRunner/public/WebTask.h: Removed.
958         * DumpRenderTree/chromium/TestRunner/public/WebTestCommon.h: Removed.
959         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h: Removed.
960         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h: Removed.
961         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h: Removed.
962         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Removed.
963         * DumpRenderTree/chromium/TestRunner/src: Removed.
964         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp: Removed.
965         * DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h: Removed.
966         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp: Removed.
967         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h: Removed.
968         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.cpp: Removed.
969         * DumpRenderTree/chromium/TestRunner/src/CppBoundClass.h: Removed.
970         * DumpRenderTree/chromium/TestRunner/src/CppVariant.cpp: Removed.
971         * DumpRenderTree/chromium/TestRunner/src/CppVariant.h: Removed.
972         * DumpRenderTree/chromium/TestRunner/src/EventSender.cpp: Removed.
973         * DumpRenderTree/chromium/TestRunner/src/EventSender.h: Removed.
974         * DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp: Removed.
975         * DumpRenderTree/chromium/TestRunner/src/GamepadController.h: Removed.
976         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.cpp: Removed.
977         * DumpRenderTree/chromium/TestRunner/src/KeyCodeMapping.h: Removed.
978         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.cpp: Removed.
979         * DumpRenderTree/chromium/TestRunner/src/MockConstraints.h: Removed.
980         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.cpp: Removed.
981         * DumpRenderTree/chromium/TestRunner/src/MockGrammarCheck.h: Removed.
982         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.cpp: Removed.
983         * DumpRenderTree/chromium/TestRunner/src/MockSpellCheck.h: Removed.
984         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp: Removed.
985         * DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.h: Removed.
986         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.cpp: Removed.
987         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDTMFSenderHandler.h: Removed.
988         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.cpp: Removed.
989         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCDataChannelHandler.h: Removed.
990         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.cpp: Removed.
991         * DumpRenderTree/chromium/TestRunner/src/MockWebRTCPeerConnectionHandler.h: Removed.
992         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.cpp: Removed.
993         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechInputController.h: Removed.
994         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.cpp: Removed.
995         * DumpRenderTree/chromium/TestRunner/src/MockWebSpeechRecognizer.h: Removed.
996         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.cpp: Removed.
997         * DumpRenderTree/chromium/TestRunner/src/NotificationPresenter.h: Removed.
998         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.cpp: Removed.
999         * DumpRenderTree/chromium/TestRunner/src/SpellCheckClient.h: Removed.
1000         * DumpRenderTree/chromium/TestRunner/src/TestCommon.cpp: Removed.
1001         * DumpRenderTree/chromium/TestRunner/src/TestCommon.h: Removed.
1002         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp: Removed.
1003         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h: Removed.
1004         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Removed.
1005         * DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Removed.
1006         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Removed.
1007         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Removed.
1008         * DumpRenderTree/chromium/TestRunner/src/TextInputController.cpp: Removed.
1009         * DumpRenderTree/chromium/TestRunner/src/TextInputController.h: Removed.
1010         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Removed.
1011         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Removed.
1012         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp: Removed.
1013         * DumpRenderTree/chromium/TestRunner/src/WebTask.cpp: Removed.
1014         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp: Removed.
1015         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp: Removed.
1016         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Removed.
1017         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Removed.
1018         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Removed.
1019         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Removed.
1020         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
1021         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Removed.
1022         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.cpp: Removed.
1023         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1024         * DumpRenderTree/chromium/TestRunner/src/config.h: Removed.
1025         * DumpRenderTree/chromium/TestShell.cpp: Removed.
1026         * DumpRenderTree/chromium/TestShell.h: Removed.
1027         * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
1028         * DumpRenderTree/chromium/TestShellMac.mm: Removed.
1029         * DumpRenderTree/chromium/TestShellPosix.cpp: Removed.
1030         * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
1031         * DumpRenderTree/chromium/TestShellWin.cpp: Removed.
1032         * DumpRenderTree/chromium/TestShellX11.cpp: Removed.
1033         * DumpRenderTree/chromium/WebViewHost.cpp: Removed.
1034         * DumpRenderTree/chromium/WebViewHost.h: Removed.
1035         * DumpRenderTree/chromium/android_fallback_fonts.xml: Removed.
1036         * DumpRenderTree/chromium/android_main_fonts.xml: Removed.
1037         * DumpRenderTree/chromium/config.h: Removed.
1038         * DumpRenderTree/chromium/fonts.conf: Removed.
1039
1040 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1041
1042         Remove the rebaseline queue server since nobody except maybe one person from Google uses it.
1043
1044         Rubber stamped by Benjamin Poulain.
1045
1046         * RebaselineQueueServer: Removed.
1047         * RebaselineQueueServer/app.yaml: Removed.
1048         * RebaselineQueueServer/handlers: Removed.
1049         * RebaselineQueueServer/handlers/__init__.py: Removed.
1050         * RebaselineQueueServer/handlers/builderqueue.py: Removed.
1051         * RebaselineQueueServer/handlers/pages.py: Removed.
1052         * RebaselineQueueServer/index.yaml: Removed.
1053         * RebaselineQueueServer/main.py: Removed.
1054         * RebaselineQueueServer/model: Removed.
1055         * RebaselineQueueServer/model/__init__.py: Removed.
1056         * RebaselineQueueServer/model/queueentry.py: Removed.
1057         * RebaselineQueueServer/static: Removed.
1058         * RebaselineQueueServer/static/builder-frame-empty.html: Removed.
1059         * RebaselineQueueServer/static/styles.css: Removed.
1060         * RebaselineQueueServer/templates: Removed.
1061         * RebaselineQueueServer/templates/builder-picker.html: Removed.
1062         * RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
1063         * RebaselineQueueServer/templates/builder-queue-list.html: Removed.
1064         * RebaselineQueueServer/templates/home.html: Removed.
1065
1066 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1067
1068         Fix setup-commit-queue and temporarily disable testing on commit-queue
1069         https://bugs.webkit.org/show_bug.cgi?id=113979
1070
1071         Reviewed by Benjamin Poulain.
1072
1073         Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
1074         and temporarily disable tests in commit-queue as we don't have enough resources at the moment.
1075
1076         * EWSTools/setup-commit-queue.sh:
1077         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1078         (CommitQueueTask.run):
1079
1080 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1081
1082         temporarily make flakiness dashboard work again webkit.org bots
1083         https://bugs.webkit.org/show_bug.cgi?id=113972
1084
1085         Reviewed by Ojan Vafai.
1086
1087         This patch disables the chromium.org layout test bots TestExpectations
1088         parsing temporarily until we can work out the right way to split into
1089         two instances for webkit.org and chromium.org and figure out which
1090         code to delete where :).
1091
1092         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1093
1094 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1095
1096         Fix webkitpy tests after r147678.
1097
1098         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1099         (CommitQueueTest.test_commit_queue):
1100         (test_manual_reject_during_processing):
1101
1102 2013-04-04  Ryosuke Niwa  <rniwa@webkit.org>
1103
1104         The commit queue should use Mac MountainLion port
1105         https://bugs.webkit.org/show_bug.cgi?id=113971
1106
1107         Reviewed by Lucas Forschler.
1108
1109         * EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
1110         * Scripts/webkitpy/tool/commands/queues.py:
1111         (CommitQueue):
1112
1113 2013-04-04  Dirk Pranke  <dpranke@chromium.org>
1114
1115         turn off running tests on chromium linux EWS bots
1116         https://bugs.webkit.org/show_bug.cgi?id=113959
1117
1118         Reviewed by Geoffrey Garen.
1119
1120         Now that the Chromium port is no longer being maintained
1121         there's little point in running the tests. Soon we should
1122         just shut this bot off altogether.
1123
1124         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1125         (ChromiumLinuxEWS):
1126
1127 2013-04-04  Andrew Scherkus  <scherkus@chromium.org>
1128
1129         Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
1130
1131         * Scripts/webkitpy/common/config/watchlist:
1132
1133 2013-04-04  Pierre Rossi  <pierre.rossi@gmail.com>
1134
1135         Indentation fix to get webkit-patch working again after r147625
1136
1137         Unreviewed.
1138
1139         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1140         (MacEWS):
1141         (MacWK2EWS):
1142
1143 2013-04-04  Lucas Forschler  <lforschler@apple.com>
1144
1145         Turn tests back on for Mac WK1/WK2 EWS.
1146         
1147         Unreviewed.
1148         
1149         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1150         (MacEWS):
1151         (MacWK2EWS):
1152
1153 2013-04-04  Manuel Rego Casasnovas  <rego@igalia.com>
1154
1155         [GTK][WK2] MiniBrowser custom URI scheme support
1156         https://bugs.webkit.org/show_bug.cgi?id=112419
1157
1158         Reviewed by Carlos Garcia Campos.
1159
1160         Add support for about URIs in MiniBrowser. An example about page is show
1161         with URI "about:minibrowser", the rest of the cases it will show a
1162         proper message explaining that the about page didn't exist.
1163
1164         Internally it uses "minibrowser-about" prefix instead of "about", but
1165         from the user point of view it works with "about" prefix.
1166
1167         * MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
1168         (getInternalURI): Method to convert URIs from "about" prefix to
1169         "minibrowser-about".
1170         (getExternalURI): Opposite method.
1171         (webViewURIChanged): Use "about" prefix to show the URI to users.
1172         (webViewEnterFullScreen): Ditto.
1173         (browser_window_load_uri): Use "minibrowser-about" prefix internally.
1174         * MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
1175         (aboutURISchemeRequestCallback): Callback to manage about calls.
1176         (main): Register the URI scheme to manage about URIs.
1177
1178 2013-04-03  Roger Fong  <roger_fong@apple.com>
1179
1180         Re-enable WinEWS tests.
1181
1182         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1183         (WinEWS):
1184
1185 2013-04-03  Zan Dobersek  <zdobersek@igalia.com>
1186
1187         [GTK][Jhbuild] Move ATK to the main moduleset, bump ATK, at-spi2-(atk|core) versions to 2.8.0
1188         https://bugs.webkit.org/show_bug.cgi?id=113883
1189
1190         Reviewed by Martin Robinson.
1191
1192         * gtk/jhbuild-optional.modules: Remove the ATK entry as it is now placed in jhbuild.modules.
1193         * gtk/jhbuild.modules: Add ATK to the list of webkitgtk-testing-dependencies metamodule, using the 2.8.0 version.
1194         The at-spi2-core and at-spi2-atk versions are also increased to 2.8.0.
1195
1196 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1197
1198         [GTK] Include Pango in jhbuild-optional.modules
1199         https://bugs.webkit.org/show_bug.cgi?id=113878
1200
1201         Reviewed by Martin Robinson.
1202
1203         Since r147547 Pango 1.32.0 is required. Including the module in the
1204         JHBuild optional moduleset.
1205
1206         * gtk/jhbuild-optional.modules: Add Pango module.
1207
1208 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1209
1210         [Qt] Add getter for JSC TestRunner to DumpRenderTreeQt.
1211         https://bugs.webkit.org/show_bug.cgi?id=113864
1212
1213         Moving setDefersLoading from TestRunnerQt to TestRunner
1214         requires access to the non-Qt TestRunner.
1215         As long as we instantiate both TestRunner and TestRunnerQt,
1216         we need a separate getter for the non-Qt TestRunner instance.
1217
1218         Reviewed by Simon Hausmann.
1219
1220         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1221         (WebPage::resetSettings):
1222         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1223         (DumpRenderTree::jscTestRunner):
1224         * DumpRenderTree/qt/TestRunnerQt.cpp:
1225         (TestRunner::setDefersLoading):
1226             Moving setDefersLoading from TestRunnerQt
1227             to TestRunner.
1228         * DumpRenderTree/qt/TestRunnerQt.h:
1229         (TestRunnerQt):
1230
1231 2013-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
1232
1233         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1234         https://bugs.webkit.org/show_bug.cgi?id=104779
1235
1236         Reviewed by Carlos Garcia Campos.
1237
1238         * Scripts/run-gtk-tests:
1239         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1240         passing in current trunk.
1241
1242 2013-04-03  Pierre Rossi  <pierre.rossi@digia.com>
1243
1244         Fix HAVE(QTTESTSUPPORT) logic
1245
1246         build_qttestsupport has not been added to WEBKIT_CONFIG in detectFeatures,
1247         resulting in HAVE(QTTESTSUPPORT) never being true.
1248         Move that logic down in sanitizeFeatures.
1249
1250         Rubber-stamped by Tor Arne Vestbø.
1251
1252         * qmake/mkspecs/features/features.prf:
1253
1254 2013-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
1255
1256         [GTK] Bump required versions of some dependencies
1257         https://bugs.webkit.org/show_bug.cgi?id=113282
1258
1259         Reviewed by Martin Robinson.
1260
1261         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1262
1263 2013-04-03  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1264
1265         [GTK] gst-plugins-good fails to build with newer Linux(v4l2)
1266         https://bugs.webkit.org/show_bug.cgi?id=113809
1267
1268         Reviewed by Philippe Normand.
1269
1270         Newer Linux kernels have removed some deprecated macros from v4l2
1271         headers, causing gst-plugins-good's build to break. We don't need it
1272         right now, so just disable it.
1273
1274         * gtk/jhbuild.modules: disable v4l2 usage in gst-plugins-good.
1275
1276 2013-03-28  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>
1277
1278         [Qt] Switch ContextMenu implementation to CROSS_PLATFORM_CONTEXT_MENU
1279         https://bugs.webkit.org/show_bug.cgi?id=113535
1280
1281         Reviewed by Simon Hausmann.
1282
1283         Adding USE_CROSS_PLATFORM_CONTEXT_MENUS to WEBKIT_CONFIG.
1284
1285         * qmake/mkspecs/features/features.prf:
1286
1287 2013-04-03  Zeno Albisser  <zeno@webkit.org>
1288
1289         [Qt] Move logic of simple forwarding functions to TestRunner.
1290         https://bugs.webkit.org/show_bug.cgi?id=113863
1291
1292         Reviewed by Simon Hausmann.
1293
1294         * DumpRenderTree/qt/TestRunnerQt.cpp:
1295         (TestRunner::setTextDirection):
1296         (TestRunner::goBack):
1297         (TestRunner::evaluateScriptInIsolatedWorld):
1298         (TestRunner::addUserStyleSheet):
1299         * DumpRenderTree/qt/TestRunnerQt.h:
1300         (TestRunnerQt):
1301
1302 2013-04-03  Tor Arne Vestbø  <tor.arne.vestbo@digia.com>
1303
1304         [Qt] Disable media support using QuickTime if deployment target != SDK
1305
1306         We link to a single libWebKitSystemInterface static lib, so unless the
1307         deployment target matches the SDK let's not pretend like we'll be able
1308         to run on anything lower than the SDK version.
1309
1310         Reviewed by Simon Hausmann.
1311
1312         * qmake/mkspecs/features/features.prf:
1313
1314 2013-04-02  James Craig  <james@cookiecrook.com>
1315
1316         AXRoleDescripton for DL is "list"; should be "description list"
1317         https://bugs.webkit.org/show_bug.cgi?id=111665
1318
1319         Reviewed by Chris Fleizach.
1320
1321         Defining the role and description strings.
1322
1323         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
1324
1325 2013-04-02  Roger Fong  <roger_fong@apple.com>
1326
1327         Unreviewed. Disable running tests on Win EWS queue.
1328
1329         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1330         (WinEWS):
1331
1332 2013-04-02  Lucas Forschler  <lforschler@apple.com>
1333
1334         Disable running tests on the MAC WK2 EWS queue.
1335         
1336         Unreviewed.
1337         
1338         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1339         (MacWK2EWS):
1340
1341 2013-04-02  Julie Parent  <jparent@chromium.org>
1342
1343         Dashboard refactor: Move dashboard specific history related features to History.
1344         https://bugs.webkit.org/show_bug.cgi?id=113717
1345
1346         Reviewed by Ojan Vafai.
1347         
1348         Each dashboard now creates its own History object, with a custom
1349         configuration. This changes from just overriding global functions
1350         to passing in callbacks for generatePage, handleValidHashParameter,
1351         and handleQueryParameterChange. Same with passing in defaultStateValues
1352         and DB_SPECIFIC_INVALIDATING_PARAMS, rather than overriding the global
1353         variables.
1354         
1355         All functions related to these features are now (mostly) private
1356         function on History. 
1357         
1358         Loader no longer needs a loadingComplete callback, since it can just
1359         initialize the history object itself.
1360
1361         * TestResultServer/static-dashboards/aggregate_results.js:
1362         (handleValidHashParameter):
1363         * TestResultServer/static-dashboards/dashboard_base.js:
1364         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1365         (generatePage):
1366         (.switch.return):
1367         (handleQueryParameterChange):
1368         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1369         (resetGlobals):
1370         * TestResultServer/static-dashboards/history.js:
1371         (.):
1372         * TestResultServer/static-dashboards/loader.js:
1373         (.):
1374         * TestResultServer/static-dashboards/loader_unittests.js:
1375         * TestResultServer/static-dashboards/timeline_explorer.js:
1376         (generatePage):
1377         (initCurrentBuilderTestResults):
1378         * TestResultServer/static-dashboards/treemap.js:
1379         (generatePage):
1380         (.switch.return):
1381         (handleQueryParameterChange):
1382
1383 2013-04-02  Sheriff Bot  <webkit.review.bot@gmail.com>
1384
1385         Unreviewed, rolling out r147401.
1386         http://trac.webkit.org/changeset/147401
1387         https://bugs.webkit.org/show_bug.cgi?id=113767
1388
1389         The patch makes it extremely hard to set up the dependencies
1390         properly on the GTK builders (Requested by zdobersek on
1391         #webkit).
1392
1393         * gtk/jhbuild.modules:
1394
1395 2013-04-02  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
1396
1397         [EFL][WK2] Empty tooltip shown when hovering over popup menu items
1398         https://bugs.webkit.org/show_bug.cgi?id=113382
1399
1400         Reviewed by Gyuyoung Kim.
1401
1402         Do not show the empty tooltip box if the text is null.
1403
1404         * MiniBrowser/efl/main.c:
1405         (popup_menu_populate):
1406
1407 2013-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1408
1409         [GTK] Bump required versions of some dependencies
1410         https://bugs.webkit.org/show_bug.cgi?id=113282
1411
1412         Reviewed by Martin Robinson.
1413
1414         * gtk/jhbuild.modules: Update libsoup, glib, at-spi2 and gtk+ versions.
1415
1416 2013-04-01  Sheriff Bot  <webkit.review.bot@gmail.com>
1417
1418         Unreviewed, rolling out r147319.
1419         http://trac.webkit.org/changeset/147319
1420         https://bugs.webkit.org/show_bug.cgi?id=113707
1421
1422         The unit test is still failing on the buildbot (Requested by
1423         zdobersek on #webkit).
1424
1425         * Scripts/run-gtk-tests:
1426         (TestRunner):
1427
1428 2013-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1429
1430         [GTK][WK2] Unskip /webkit2/WebKitWebContext/uri-scheme
1431         https://bugs.webkit.org/show_bug.cgi?id=104779
1432
1433         Reviewed by Carlos Garcia Campos.
1434
1435         * Scripts/run-gtk-tests:
1436         (TestRunner): Unskip /webkit2/WebKitWebContext/uri-scheme as it is
1437         passing in current trunk.
1438
1439 2013-03-31  Sheriff Bot  <webkit.review.bot@gmail.com>
1440
1441         Unreviewed, rolling out r147289.
1442         http://trac.webkit.org/changeset/147289
1443         https://bugs.webkit.org/show_bug.cgi?id=113678
1444
1445         broke Win7 (dbg) build (Requested by shinyak|gardener on
1446         #webkit).
1447
1448         * DumpRenderTree/DumpRenderTree.gypi:
1449         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h.
1450         (WebTestRunner):
1451         (WebUserMediaClientMock):
1452         (WebTestRunner::WebUserMediaClientMock::~WebUserMediaClientMock):
1453         (WebTestRunner::WebUserMediaClientMock::taskList):
1454         * Scripts/webkitpy/style/checkers/cpp.py:
1455         (check_function_definition):
1456
1457 2013-03-31  Adam Barth  <abarth@webkit.org>
1458
1459         configure-svn-config.sh fails
1460         https://codereview.chromium.org/13392007/
1461
1462         Reviewed by Eric Seidel.
1463
1464         This script was trying to use "svn checkout" to dowload a file from
1465         svn.webkit.org, but "svn checkout" only works with directories.
1466         Instead, we should use "svn export".
1467
1468         * EWSTools/configure-svn-config.sh:
1469
1470 2013-03-31  Wei Jia  <wjia@chromium.org>
1471
1472         Allow WebUserMediaClientMock to be used by client
1473         https://bugs.webkit.org/show_bug.cgi?id=113633
1474
1475         Reviewed by Adam Barth.
1476
1477         Export WebUserMediaClientMock.
1478         Allow files in chromium/TestRunner/public to have WEBKIT_EXPORT.
1479
1480         * DumpRenderTree/DumpRenderTree.gypi:
1481         * DumpRenderTree/chromium/TestRunner/public/WebUserMediaClientMock.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h.
1482         (WebUserMediaClientMock):
1483         * DumpRenderTree/chromium/TestRunner/src/WebUserMediaClientMock.h: Removed.
1484         * Scripts/webkitpy/style/checkers/cpp.py:
1485         (check_function_definition):
1486
1487 2013-03-29  Alexey Proskuryakov  <ap@apple.com>
1488
1489         Expose FeatureObserver data to WebKit clients
1490         https://bugs.webkit.org/show_bug.cgi?id=113613
1491
1492         Reviewed by Sam Weinig.
1493
1494         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1495         (WTR::InjectedBundlePage::InjectedBundlePage): Added an initializer for featuresUsedInPage.
1496
1497 2013-03-29  Greg Hughes  <ghughes@apple.com>
1498
1499         Allow multiple searchKeys to be passed to AXUIElementCopyParameterizedAttributeValue
1500         https://bugs.webkit.org/show_bug.cgi?id=112276
1501
1502         Reviewed by Chris Fleizach.
1503
1504         Added support to test accessibility search predicates with multiple keys.  
1505
1506         * DumpRenderTree/AccessibilityUIElement.cpp:
1507         (uiElementForSearchPredicateCallback):
1508         * DumpRenderTree/AccessibilityUIElement.h:
1509         (AccessibilityUIElement):
1510         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1511         (AccessibilityUIElement::uiElementForSearchPredicate):
1512         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
1513         (AccessibilityUIElement::uiElementForSearchPredicate):
1514         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1515         (AccessibilityUIElement::uiElementForSearchPredicate):
1516         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1517         (AccessibilityUIElement::uiElementForSearchPredicate):
1518         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
1519         (AccessibilityUIElement::uiElementForSearchPredicate):
1520         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1521         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1522         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1523         (AccessibilityUIElement):
1524         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1525         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1526         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1527         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1528         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
1529
1530 2013-03-29  Ryosuke Niwa  <rniwa@webkit.org>
1531
1532         Fix a typo in r147147 to fix Mac EWS.
1533
1534         * Scripts/webkitpy/tool/commands/queues.py:
1535         (PatchProcessingQueue._new_port_name_from_old):
1536
1537 2013-03-28  Ryuan Choi  <ryuan.choi@samsung.com>
1538
1539         [EFL] Build break with latest EFL libraries after r146265
1540         https://bugs.webkit.org/show_bug.cgi?id=113558
1541
1542         Unreviewed build fix.
1543
1544         * TestWebKitAPI/PlatformWebView.h:
1545         * WebKitTestRunner/PlatformWebView.h:
1546
1547 2013-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1548
1549         Unreviewed. Fix build break when running --update-efl in WebKit EFL.
1550
1551         * efl/jhbuild.modules: Remove to run autogen.sh in libgcrypt autogen. It causes configuration fail
1552         in libgcrypt build.
1553
1554 2013-03-28  Lucas Forschler  <lforschler@apple.com>
1555
1556         Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.
1557
1558         Unreviewed.
1559
1560         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1561         (MacEWS):
1562
1563 2013-03-28  Ryosuke Niwa  <rniwa@webkit.org>
1564
1565         Use the right OS name on Mac EWS instead of mac-future.
1566
1567         Rubber-stamped by Dirk Pranke.
1568
1569         * Scripts/webkitpy/tool/commands/queues.py:
1570         (PatchProcessingQueue._new_port_name_from_old):
1571         (PatchProcessingQueue.begin_work_queue):
1572         (PatchProcessingQueue._upload_results_archive_for_patch):
1573
1574 2013-03-28  Zan Dobersek  <zdobersek@igalia.com>
1575
1576         [GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
1577         https://bugs.webkit.org/show_bug.cgi?id=112546
1578
1579         Reviewed by Martin Robinson.
1580
1581         * GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
1582         moved back to Source/WebCore/platform. Fix an indentation issue as well.
1583
1584 2013-03-28  Ming Xie  <mxie@blackberry.com>
1585
1586         [BlackBerry] Committer Email Updates
1587         https://bugs.webkit.org/show_bug.cgi?id=113435
1588
1589         Reviewed by Rob Buis.
1590
1591         Add the @blackberry.com email address for all our BlackBerry
1592         WebKit committers. This is the first step for our email address
1593         migration.
1594
1595         * Scripts/webkitpy/common/config/committers.py:
1596
1597 2013-03-28  Philippe Normand  <pnormand@igalia.com>
1598
1599         [jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
1600         https://bugs.webkit.org/show_bug.cgi?id=113508
1601
1602         Reviewed by Martin Robinson.
1603
1604         Prevent the GStreamer plugin scanner to load system-wide
1605         plugins. Only the ones built in JHBuild should be loaded and used
1606         at runtime.
1607
1608         * efl/jhbuildrc:
1609         * gtk/jhbuildrc:
1610
1611 2013-03-27  Philippe Normand  <pnormand@igalia.com>
1612
1613         [GTK] run-launcher --gtk -2 fails on a WK2-only build
1614         https://bugs.webkit.org/show_bug.cgi?id=113386
1615
1616         Reviewed by Carlos Garcia Campos.
1617
1618         * Scripts/webkitdirs.pm:
1619         (builtDylibPathForName): The WebKit2GTK .so name change from 1.0
1620         version to 3.0. Reflect this change so the builtDylibPathForName
1621         function doesn't fail to report the library as found.
1622
1623 2013-03-28  Jaehun Lim  <ljaehun.lim@samsung.com>
1624
1625         [CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
1626         https://bugs.webkit.org/show_bug.cgi?id=113484
1627
1628         Unreviewed build fix.
1629
1630         Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.
1631
1632         * TestWebKitAPI/CMakeLists.txt:
1633         * WebKitTestRunner/CMakeLists.txt:
1634
1635 2013-03-27  Mario Sanchez Prada  <mario.prada@samsung.com>
1636
1637         Revision for the internal jhbuild is too old
1638         https://bugs.webkit.org/show_bug.cgi?id=113324
1639
1640         Reviewed by Martin Robinson.
1641
1642         Update the minimum required version to a point where jhbuild won't
1643         fail installing packages when trying to remove a symlink to a directory.
1644
1645         * jhbuild/jhbuild-wrapper: Updated revision.
1646
1647 2013-03-27  Gustavo Noronha Silva  <gns@gnome.org>
1648
1649         [GTK][jhbuild] gst-plugins-good mixes system libsoup-gnome with custom libsoup
1650         https://bugs.webkit.org/show_bug.cgi?id=113203
1651
1652         Reviewed by Philippe Normand.
1653
1654         We build our libsoup without GNOME support. gst-plugins-good does separate
1655         pkg-config checks for libsoup-gnome and libsoup, causing the build to use
1656         libsoup-gnome from the system and soup from the jhbuild prefix. This may lead to
1657         build failures as the headers of those diverge. We do not use souphttpsrc, so
1658         disable it when building gst-plugins-good.
1659
1660         * gtk/jhbuild.modules: disable soup support in gst-plugins-good.
1661
1662 2013-03-27  Ryosuke Niwa  <rniwa@webkit.org>
1663
1664         Build fix after r146852. Please another reference to the Lion leaks builder.
1665
1666         * BuildSlaveSupport/build.webkit.org-config/config.json:
1667
1668 2013-03-27  Zan Dobersek  <zdobersek@igalia.com>
1669
1670         [GTK][webkitpy] A huge list of warnings about missing bugs in expectations when running NRWT with WKTR
1671         https://bugs.webkit.org/show_bug.cgi?id=113421
1672
1673         Reviewed by Dirk Pranke.
1674
1675         When running the layout tests with WKTR through NRWT, the GTK port also uses the generic WK2 TestExpectations file.
1676         This file contains a large amount of expectations that are not listing a specific bug modifier, so this produces an
1677         equally large amount of warnings due to the GTK port preferring for every expectation to have the bug modifier present
1678         in the GTK-specific TestExpectations files.
1679
1680         To avoid this only enable the warnings only when not using WKTR.
1681
1682         * Scripts/webkitpy/layout_tests/port/gtk.py:
1683         (GtkPort.warn_if_bug_missing_in_test_expectations):
1684
1685 2013-03-27  Antti Koivisto  <antti@apple.com>
1686
1687         Fix Zalan's email.
1688
1689         * Scripts/webkitpy/common/config/committers.py:
1690
1691 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1692
1693         master.cfg cleanup
1694         https://bugs.webkit.org/show_bug.cgi?id=113195
1695
1696         Reviewed by Ryosuke Niwa.
1697
1698         * BuildSlaveSupport/build.webkit.org-config/config.json:
1699         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1700
1701 2013-03-27  Csaba Osztrogonác  <ossy@webkit.org>
1702
1703         master.cfg fine-tuning for Qt Mountain Lion Release bot
1704         https://bugs.webkit.org/show_bug.cgi?id=113191
1705
1706         Reviewed by Ryosuke Niwa.
1707
1708         * BuildSlaveSupport/build.webkit.org-config/config.json:
1709           - Rename the slave due to its location change.
1710           - Update the platform of the slave.
1711         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1712         (RunQtAPITests): Enable running WK2 API tests on Qt.
1713         (RunQtAPITests.start):
1714         (RunWebKit2Tests.start): Force pixel tests on the Qt Mountain Lion Release builder.
1715         (BuildAndTestWebKit2Factory): Added. (Build WK1 and WK2 too, but run only WK2 tests.)
1716
1717 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1718
1719         [EFL][jhbuild] Evas fails to build when Wayland is present on the system
1720         https://bugs.webkit.org/show_bug.cgi?id=113403
1721
1722         Reviewed by Kenneth Rohde Christiansen.
1723
1724         As of Evas 1.7.5, when Wayland is detected on the system, support for
1725         both Wayland SHM and Wayland EGL is automatically enabled in autoconf.
1726         The code, however, seems to depend on a few other flags which must be
1727         explicitly enabled.
1728
1729         If those additional GL-related options are passed, we end up
1730         having issues on the WebKit side, so disable Wayland support for
1731         now.
1732
1733         * efl/jhbuild.modules:
1734
1735 2013-03-27  Sheriff Bot  <webkit.review.bot@gmail.com>
1736
1737         Unreviewed, rolling out r146864.
1738         http://trac.webkit.org/changeset/146864
1739         https://bugs.webkit.org/show_bug.cgi?id=113391
1740
1741         causes crashes on Wk2 EFL release bot (Requested by drott on
1742         #webkit).
1743
1744         * Scripts/webkitperl/FeatureList.pm:
1745
1746 2013-03-27  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
1747
1748         [jhbuild] Correctly specify an alternate number of make jobs.
1749         https://bugs.webkit.org/show_bug.cgi?id=113396
1750
1751         Reviewed by Philippe Normand.
1752
1753         So far, we were using the `MAKEFLAGS' environment variable to pass the
1754         number of compilation jobs we wanted to jhbuild. jhbuild itself, on the
1755         other hand, prefers to use the `jobs' variable from jhbuildrc for that.
1756
1757         We now behave more closely to the rest of the WebKit tools by first
1758         checking the `NUMBER_OF_PROCESSORS' environment variable and, if it is
1759         not set, just letting jhbuild itself figure out how many jobs to use.
1760
1761         * efl/jhbuildrc:
1762         * gtk/jhbuildrc:
1763
1764 2013-03-27  Zeno Albisser  <zeno@webkit.org>
1765
1766         [Qt] Remove Qt specific WorkQueueItem definitions.
1767         https://bugs.webkit.org/show_bug.cgi?id=112891
1768
1769         This patch is preparation work for removing
1770         WorkQueue related code from TestRunnerQt and
1771         replacing it with generic TestRunner code.
1772
1773         Reviewed by Benjamin Poulain.
1774
1775         * DumpRenderTree/qt/TestRunnerQt.cpp:
1776         (TestRunnerQt::queueBackNavigation):
1777         (TestRunnerQt::queueForwardNavigation):
1778         (TestRunnerQt::queueLoadHTMLString):
1779         (TestRunnerQt::queueReload):
1780         (TestRunnerQt::queueLoadingScript):
1781         (TestRunnerQt::queueNonLoadingScript):
1782         (TestRunner::queueLoad):
1783         * DumpRenderTree/qt/TestRunnerQt.h:
1784         (TestRunnerQt):
1785         * DumpRenderTree/qt/WorkQueueItemQt.cpp:
1786         (LoadItem::invoke):
1787         (LoadHTMLStringItem::invoke):
1788         (LoadAlternateHTMLStringItem::invoke):
1789         (ReloadItem::invoke):
1790         (ScriptItem::invoke):
1791         (BackForwardItem::invoke):
1792         * DumpRenderTree/qt/WorkQueueItemQt.h:
1793         (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
1794         (LoadAlternateHTMLStringItem):
1795
1796 2013-03-26  Julie Parent  <jparent@chromium.org>
1797
1798         Flakiness dashboard: simplify logic around which tests to show.
1799         https://bugs.webkit.org/show_bug.cgi?id=113250
1800
1801         Reviewed by Ojan Vafai.
1802         
1803         The different filters for showing results are only used for layout
1804         tests, otherwise, we show everything.
1805         
1806         Change the defaults to false (what layout tests used), and only
1807         look at the values when viewing layout tests.
1808
1809         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1810         (htmlForTestsWithExpectationsButNoFailures):
1811         (shouldHideTest):
1812
1813 2013-03-26  Isaac Levy  <ilevy@google.com>
1814
1815         Update bots on test-results.appspot
1816         https://bugs.webkit.org/show_bug.cgi?id=113333
1817
1818         Reviewed by Ojan Vafai.
1819
1820         * TestResultServer/static-dashboards/builders.jsonp:
1821
1822 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1823
1824         Unreviewed GTK gardening.
1825
1826         * Scripts/run-gtk-tests:
1827         (TestRunner): A follow-up to 146859, skipping the complete WebKit2APITests/TestInspector unit test.
1828
1829 2013-03-26  Csaba Osztrogonác  <ossy@webkit.org>
1830
1831         [Qt] Enable release/debug/2/webkit2 options for run-qtwebkit-tests
1832         https://bugs.webkit.org/show_bug.cgi?id=113287
1833
1834         Reviewed by Jocelyn Turcotte.
1835
1836         * Scripts/run-qtwebkit-tests:
1837         (Options.__init__):
1838
1839 2013-03-26  Rijubrata Bhaumik  <rijubrata.bhaumik@intel.com>
1840
1841         [EFL] Enable IndexedDB by default
1842         https://bugs.webkit.org/show_bug.cgi?id=107248
1843
1844         Reviewed by Laszlo Gombos.
1845
1846         * Scripts/webkitperl/FeatureList.pm:
1847         Enable IndexedDB by default on EFL.
1848
1849 2013-03-26  Alan Cutter  <alancutter@chromium.org>
1850
1851         Sheriffbot should explain rollout failures in a human readable form.
1852         https://bugs.webkit.org/show_bug.cgi?id=107092
1853
1854         Reviewed by Ryosuke Niwa.
1855
1856         Improved sheriffbot's error reporting when a rollout command fails to reverse diff files (the most common failure).
1857
1858         * Scripts/webkitpy/tool/bot/irc_command.py:
1859         (Rollout._check_diff_failure):
1860         (Rollout.execute):
1861         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1862         (IRCCommandTest.test_rollout):
1863
1864 2013-03-26  Zan Dobersek  <zdobersek@igalia.com>
1865
1866         Unreviewed GTK gardening.
1867
1868         * Scripts/run-gtk-tests:
1869         (TestRunner): Skipping a failing unit test after r146518.
1870
1871 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1872
1873         Remove Lion leaks builder
1874         https://bugs.webkit.org/show_bug.cgi?id=113252
1875
1876         Reviewed by Andreas Kling.
1877
1878         Removed.
1879
1880         * BuildSlaveSupport/build.webkit.org-config/config.json:
1881
1882 2013-03-25  Kent Tamura  <tkent@chromium.org>
1883
1884         Rename ENABLE_INPUT_TYPE_DATETIME
1885         https://bugs.webkit.org/show_bug.cgi?id=113254
1886
1887         Reviewed by Kentaro Hara.
1888
1889         Rename ENABLE_INPUT_TYPE_DATETIME to ENABLE_INPUT_TYPE_DATETIME_INCOMPLETE.
1890         Actually I'd like to remove the code, but we shouldn't remove it yet
1891         because we shipped products with it on some platforms.
1892
1893         * Scripts/webkitperl/FeatureList.pm:
1894         * qmake/mkspecs/features/features.pri:
1895
1896 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1897
1898         Remove one more line that was intended to be removed in r146657.
1899
1900         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1901         (summarize_results):
1902
1903 2013-03-25  Roger Fong  <roger_fong@apple.com>
1904
1905         No longer run bindings tests on WinEWS bots which are causing hangs on the bots.
1906         Re-enable WinEWS tests.
1907
1908         * Scripts/webkitpy/common/config/ports.py:
1909         (WinPort.run_bindings_tests_command):
1910         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1911         (WinEWS):
1912
1913 2013-03-25  Sheriff Bot  <webkit.review.bot@gmail.com>
1914
1915         Unreviewed, rolling out r146793.
1916         http://trac.webkit.org/changeset/146793
1917         https://bugs.webkit.org/show_bug.cgi?id=113248
1918
1919         Fix did not work (Requested by rfong on #webkit).
1920
1921         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1922         (WinEWS):
1923
1924 2013-03-25  Ryosuke Niwa  <rniwa@webkit.org>
1925
1926         REGRESSION(r146657): Test failures reported incorrectly
1927         https://bugs.webkit.org/show_bug.cgi?id=113223
1928
1929         Reviewed by Dirk Pranke.
1930
1931         The bug was caused by BuildBotPrinter not taking the new behavior into account.
1932
1933         Fixed the bug by exposing enabled_pixel_tests_in_retry flag via ResultDetails object and have BuildBotPrinter
1934         treat ['TEXT', 'IMAGE+TEXT'] as a regular failure when the flag is set true.
1935
1936         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1937         (Manager.run):
1938
1939         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1940         (RunDetails.__init__):
1941         (summarize_results): Remove the line I intended to remove in r146657.
1942
1943         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1944         (logging_run): Return details instead of the exit code.
1945         (run_and_capture): Ditto.
1946
1947         (RunTest.test_full_results_html):
1948         (RunTest.test_hung_thread):
1949         (RunTest.test_no_tests_found):
1950         (RunTest.test_no_tests_found_2):
1951         (RunTest.test_repeat_each_iterations_num_tests):
1952         (RunTest.test_run_singly_actually_runs_tests):
1953         (RunTest.test_test_list):
1954         (RunTest.test_missing_and_unexpected_results):
1955         (RunTest.test_pixel_test_directories):
1956         (RunTest.test_missing_and_unexpected_results_with_custom_exit_code):
1957         (RunTest.test_crash_with_stderr):
1958         (RunTest.test_no_image_failure_with_image_diff):
1959         (RunTest.test_crash_log):
1960         (RunTest.test_exit_after_n_failures_upload):
1961         (RunTest.test_results_directory_absolute):
1962         (RunTest.test_results_directory_relative):
1963         (RunTest.test_retrying_and_flaky_tests):
1964         (RunTest.test_retrying_force_pixel_tests): Added a test case to ensure enabled_pixel_tests_in_retry is set.
1965         (RunTest.test_retrying_uses_retries_directory):
1966         (RunTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1967         (RunTest.test_output_diffs):
1968         (EndToEndTest.test_reftest_with_two_notrefs):
1969         (RebaselineTest.test_reset_results):
1970         (RebaselineTest.test_missing_results):
1971         (RebaselineTest.test_new_baseline):
1972
1973         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
1974         (BuildBotPrinter.print_results):
1975         (BuildBotPrinter.print_unexpected_results):
1976         (BuildBotPrinter.print_unexpected_results.add_result): Don't treat ['TEXT', 'IMAGE+TEXT'] as flaky
1977         when we forced pixel tests in retry (i.e. pixel test was initially disabled).
1978
1979 2013-03-25  Julie Parent  <jparent@chromium.org>
1980
1981         Dashboard refactor: Move cross dashboard history related code into history.js.
1982         https://bugs.webkit.org/show_bug.cgi?id=113104
1983
1984         Reviewed by Ojan Vafai.
1985
1986         All functions relating to cross dashboard behavior move from being
1987         globals to methods on the history.History object. Names stay the same,
1988         except many are made private, ones that should have been constants now
1989         are, and the long standing TODO to change "currentState" to 
1990         dashboardSpecificState is done.
1991         
1992         We now create a global history object in dashboard_base, as an 
1993         intermediate measure.  Once the dashboard specific code is
1994         added to history, each DB will need to create its own, and this
1995         global will be eliminated.
1996         
1997         * TestResultServer/static-dashboards/aggregate_results.js:
1998         (handleValidHashParameter):
1999         (htmlForBuilder):
2000         (rawValuesHTML):
2001         * TestResultServer/static-dashboards/dashboard_base.js:
2002         (parseDashboardSpecificParameters):
2003         (defaultValue):
2004         (currentBuilderGroupCategory):
2005         (currentBuilderGroupName):
2006         (handleLocationChange):
2007         (expectationsMap):
2008         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2009         (generatePage):
2010         (.switch.return):
2011         (platformAndBuildType):
2012         (individualTests):
2013         (substringList):
2014         (processMissingAndExtraExpectations):
2015         (pathToFailureLog):
2016         (showPopupForBuild):
2017         (htmlForTestsWithExpectationsButNoFailures):
2018         (shouldHideTest):
2019         (isCrossBuilderView):
2020         (tableHeaders):
2021         (htmlForSingleTestRow):
2022         (htmlForTableColumnHeader):
2023         (generatePageForExpectationsUpdate):
2024         (handleUpdate):
2025         (nextUpdate):
2026         (setUpdateIndex):
2027         (htmlForIndividualTestOnAllBuildersWithResultsLinks):
2028         (.appendExpectationsItem):
2029         (loadExpectations):
2030         (.dummyNode.onload):
2031         (loadExpectationsLayoutTests):
2032         (appendExpectations):
2033         (htmlForNavBar):
2034         (checkBoxToToggleState):
2035         (linkHTMLToToggleState):
2036         (generatePageForBuilder):
2037         (isInvalidKeyForCrossBuilderView):
2038         (handleQueryParameterChange):
2039         (showLegend):
2040         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
2041         (resetGlobals):
2042         (test):
2043         * TestResultServer/static-dashboards/history.js:
2044         (.):
2045         * TestResultServer/static-dashboards/history_unittests.js:
2046         * TestResultServer/static-dashboards/loader.js:
2047         (.):
2048         * TestResultServer/static-dashboards/loader_unittests.js:
2049         * TestResultServer/static-dashboards/timeline_explorer.js:
2050         (generatePage):
2051         (initCurrentBuilderTestResults):
2052         (selectBuild):
2053         (showResultsDelta):
2054         * TestResultServer/static-dashboards/treemap.js:
2055         (generatePage):
2056         (.switch.return):
2057         (handleFocus):
2058         * TestResultServer/static-dashboards/ui.js:
2059
2060 2013-03-25  Roger Fong  <roger_fong@apple.com>
2061
2062         Unreviewed. Enable WinEWS tests again.
2063
2064         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2065         (WinEWS):
2066
2067 2013-03-25  Dominik Röttsches  <dominik.rottsches@intel.com>
2068
2069         [HarfBuzz] ICU detection fix in HarfBuzz obsoletes our workaround
2070         https://bugs.webkit.org/show_bug.cgi?id=112166
2071
2072         HarfBuzz 0.9.14 merged my patch for icu detection without
2073         pkg-config files, as needed by for example Ubuntu 12.04.
2074         This obsoletes our local workaround. Removed it for GTK and EFL.
2075
2076         Reviewed by Martin Robinson.
2077
2078         * efl/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2079         * efl/patches/harfbuzz-icu-detection-fix.patch: Removed.
2080         * gtk/jhbuild.modules: Patch reference removed, version bumped to 0.9.14.
2081         * gtk/patches/harfbuzz-icu-detection-fix.patch: Removed.
2082
2083 2013-03-22  Kiran Muppala  <cmuppala@apple.com>
2084
2085         Unreviewed.  Move self from contributor to committer list.
2086
2087         * Scripts/webkitpy/common/config/committers.py:
2088
2089 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2090
2091         EWS should use a human readable port name when uploading layout test archives
2092         https://bugs.webkit.org/show_bug.cgi?id=113099
2093
2094         Reviewed by Dirk Pranke.
2095
2096         Use new port's object's name() method to report human readable port names.
2097         This will also help us resolving the bug to apply layout test results posted by EWS.
2098
2099         * Scripts/webkitpy/tool/bot/botinfo.py:
2100         (BotInfo.__init__): Take port's name.
2101         (BotInfo.summary_text):
2102
2103         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
2104         (BotInfoTest.test_summary_text):
2105
2106         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2107         (FlakyTestReporter.__init__): Preserve the old behavior since we don't have a real port object here.
2108
2109         * Scripts/webkitpy/tool/commands/queues.py:
2110         (PatchProcessingQueue.__init__): Initialize self._port.
2111         (PatchProcessingQueue._upload_results_archive_for_patch): Intansitate a real port object if needed,
2112         and use that for the attachment filename and the comment posted.
2113
2114         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2115         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Port name is updated to be
2116         "mac-snowleopard" as expected for TestPort.
2117
2118 2013-03-22  Roger Fong  <roger_fong@apple.com>
2119
2120         Unreviewed. Turn off EWS test on Win again.
2121         The battle continues.
2122
2123         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2124         (WinEWS):
2125
2126 2013-03-22  Ryosuke Niwa  <rniwa@webkit.org>
2127
2128         NRWT: Enable pixel tests when retrying tests
2129         https://bugs.webkit.org/show_bug.cgi?id=112898
2130
2131         Reviewed by Dirk Pranke.
2132
2133         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2134         (Manager.run): Call _force_pixel_tests_if_needed before retrying tests and set pixel_tests False
2135         if we've forced pixel tests in the retry.
2136         (Manager._run_tests):
2137         (Manager._clean_up_run): Fixed the capitalizations.
2138         (Manager._force_pixel_tests_if_needed): Added.
2139
2140         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2141         (_interpret_test_failures): Now that this function maybe called multiple times, only set
2142         'image_diff_percent' if it doesn't already exist.
2143
2144         (summarize_results): When the first attempt resulted in a text failure and the second attempt
2145         resulted in image and text failures and we've forced to run pixel tests in the retry run,
2146         treat this as a regular regression instead of a flakiness.
2147
2148         Also update test_dict with retry_result so that image_diff_percent maybe filled in if retry
2149         run had image diffs.
2150
2151         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
2152         (summarized_results):
2153
2154         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2155         (parse_full_results): Moved out of EndToEndTest to be used in test_retrying_force_pixel_tests.
2156         Also removed some dead code.
2157
2158         (RunTest.test_retrying_force_pixel_tests): Added. Assert that we generate and only generate
2159         pixel results in retries when pixel tests is turned off. Also assert that image_diff_percent
2160         is set and pixel_tests_enabled is set to false.
2161         (EndToEndTest.test_reftest_with_two_notrefs):
2162
2163 2013-03-22  Tim Horton  <timothy_horton@apple.com>
2164
2165         Make it possible to run layout tests on Retina MBP
2166         https://bugs.webkit.org/show_bug.cgi?id=93673
2167
2168         Reviewed by Ryosuke Niwa.
2169
2170         Use NSWindow SPI and override -backingScaleFactor so that WKTR and DRT
2171         windows on 2x machines still run at 1x.
2172
2173         * DumpRenderTree/mac/DumpRenderTree.mm:
2174         (createWebViewAndOffscreenWindow):
2175         Reset the window resolution to 1x on creation.
2176         * DumpRenderTree/mac/DumpRenderTreeWindow.h: Add NSWindow details.
2177         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2178         (-[DumpRenderTreeWindow backingScaleFactor]): Override, always return 1.
2179         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2180         (-[WebKitTestRunnerWindow backingScaleFactor]): Override, always return 1.
2181         (WTR::PlatformWebView::PlatformWebView):
2182         Add NSWindow details, reset the window resolution to 1x on creation.
2183
2184 2013-03-19  Ryosuke Niwa  <rniwa@webkit.org>
2185
2186         Leak bots shouldn't build
2187         https://bugs.webkit.org/show_bug.cgi?id=112774
2188
2189         Reviewed by Simon Fraser.
2190
2191         Since leak bots use regular debug builds, there is no need to build on these bots.
2192         Simply downloading builds will dramatically improve the cycle time of these bots.
2193
2194         * BuildSlaveSupport/build.webkit.org-config/config.json:
2195         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2196         (TestLeaksFactory): Renamed from BuildAndTestLeaksFactory and changed to inherit from
2197         TestFactory instead of BuildAndTestFactory.
2198
2199 2013-03-22  Jocelyn Turcotte  <jocelyn.turcotte@digia.com>
2200
2201         [Qt] Fix the TestWebKitAPI build
2202         https://bugs.webkit.org/show_bug.cgi?id=113044
2203
2204         Reviewed by Tor Arne Vestbø.
2205
2206         The generate-forwarding-headers script would only be run
2207         after the targets in InjectedBundle.pri since the second
2208         addStrictSubdirOrderBetween call in
2209         Tools/TestWebKitAPI/TestWebKitAPI.pro would overwrite
2210         the derived_sources -> injected_bundle order in SUBDIRS.
2211
2212         Fix it by only moving the dependent target at the end of
2213         SUBDIRS, don't touch its dependency.
2214
2215         * qmake/mkspecs/features/functions.prf:
2216
2217 2013-03-22  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2218
2219         [EFL][WK2] View is not focused when fullscreen mode toggled
2220         https://bugs.webkit.org/show_bug.cgi?id=113009
2221
2222         Reviewed by Laszlo Gombos.
2223
2224         Set focus on view when fullscreen mode enabled/disabled
2225         by FullScreen API.
2226
2227         * MiniBrowser/efl/main.c:
2228         (on_fullscreen_accept):
2229         (on_fullscreen_deny):
2230
2231 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2232
2233         nrwt is no longer saving retry results in the retries/ subdirectory
2234         https://bugs.webkit.org/show_bug.cgi?id=112995
2235
2236         Reviewed by Ojan Vafai.
2237
2238         I think this has been broken a long time, unfortunately. This
2239         patch should fix that.
2240
2241         In order to do so, I had to pass the directory to use from
2242         the Worker object through the SingleTestWriter to the
2243         TestResultWriter. While I was plumbing that through, I rationalized
2244         the order of the parameter arguments a bit ...
2245
2246         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2247         (Worker._run_single_test):
2248         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2249         (run_single_test):
2250         (SingleTestRunner.__init__):
2251         (SingleTestRunner._run_compare_test):
2252         (SingleTestRunner._run_rebaseline):
2253         (SingleTestRunner._run_reftest):
2254         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
2255         (write_test_result):
2256         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
2257         (TestResultWriterTest.test_reftest_diff_image):
2258         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2259         (RunTest.test_retrying_uses_retries_directory):
2260
2261 2013-03-21  Filip Pizlo  <fpizlo@apple.com>
2262
2263         JSC profiler should have an at-a-glance report of the success of DFG optimization
2264         https://bugs.webkit.org/show_bug.cgi?id=112988
2265
2266         Reviewed by Geoffrey Garen.
2267
2268         * Scripts/display-profiler-output:
2269
2270 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2271
2272         [chromium] Linux ASAN WebKit canary is running out of memory
2273         https://bugs.webkit.org/show_bug.cgi?id=112978
2274
2275         Reviewed by Tony Chang.
2276
2277         Running the AddressSanitizer on a crash takes a lot of
2278         memory, so we should serialize access to it to avoid running
2279         out of memory on a machine.
2280
2281         * Scripts/webkitpy/layout_tests/port/chromium.py:
2282         (ChromiumPort._get_crash_log):
2283         * Scripts/webkitpy/layout_tests/port/http_lock.py:
2284         (HttpLock.__init__):
2285         (HttpLock.wait_for_httpd_lock):
2286
2287 2013-03-21  Min Qin  <qinmin@chromium.org>
2288
2289         Cleanup android media layout test code
2290         https://bugs.webkit.org/show_bug.cgi?id=112944
2291
2292         Reviewed by Adam Barth.
2293
2294         Chromium change: https://codereview.chromium.org/12892010/
2295         The current android layout tests are using WebmediaPlayerInProcessAndroid class.
2296         The code path has been largely diverged from that of the WebMediaPlayerImplAndroid.
2297         It is not worth the effort to keep the code path, and the layout tests will not reflect the actual behavior on the browser.
2298         Instead, we should switch to use content shell for layout tests.
2299
2300         * DumpRenderTree/chromium/TestShell.cpp:
2301         (TestShell::resetTestController):
2302
2303 2013-03-21  Dirk Pranke  <dpranke@chromium.org>
2304
2305         [chromium] add missing project dependencies to DRT to fix Mac Valgrind
2306         https://bugs.webkit.org/show_bug.cgi?id=112953
2307
2308         Reviewed by Tony Chang.
2309
2310         When I created the DumpRenderTree_resources target in r144863 I
2311         forgot to declare the needed dependencies on the other resource
2312         targets. Due to a quirk of ordering, this appears to have been fine
2313         w/ ninja but not w/ Xcode (which is still being used on the chromium
2314         mac valgrind bots). Declaring the dependencies fixes the build
2315         failures.
2316
2317         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2318
2319 2013-03-21  Brent Fulgham  <bfulgham@webkit.org>
2320
2321         [WinCairo] Correct assert in Empty BitmapImage Test.
2322         https://bugs.webkit.org/show_bug.cgi?id=112934
2323
2324         Reviewed by Tim Horton.
2325
2326         * TestWebKitAPI/Tests/WebCore/win/BitmapImage.cpp:
2327         (TestWebKitAPI::TEST): Use proper RefPtr and adoptRef
2328         to avoid ref counting assertion when leaving test scope.
2329
2330 2013-03-21  Zan Dobersek  <zdobersek@igalia.com>
2331
2332         [GTK] generate-feature-defines-files is incompatible with Python3
2333         https://bugs.webkit.org/show_bug.cgi?id=112956
2334
2335         Reviewed by Martin Robinson.
2336
2337         Make the generate-feature-defines-files compatible with Python3 by calling the items()
2338         method on the dictionary objects when iterating through said dictionaries.
2339
2340         * gtk/generate-feature-defines-files:
2341         (write_feature_defines_header):
2342         (write_flattened_feature_defines_file):
2343
2344 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2345
2346         kill-old-processes spits out error messages on Mac
2347         https://bugs.webkit.org/show_bug.cgi?id=112878
2348
2349         Reviewed by Jessie Berlin.
2350
2351         Use grep -E instead of grep -P since grep on Mac doesn't seem to support the latter even though it's
2352         included in the list of options grep --help shows.
2353
2354         Also use double-slash in escaping ++ in clang++ since the slashes needs to escape + inside the shell.
2355
2356         * BuildSlaveSupport/kill-old-processes:
2357         (main):
2358
2359 2013-03-21  Alberto Garcia  <agarcia@igalia.com>
2360
2361         [BlackBerry] AccessibilityUIElement: add dummy implementations of scroll methods
2362         https://bugs.webkit.org/show_bug.cgi?id=112597
2363
2364         Reviewed by Xan Lopez.
2365
2366         These were introduced for the Chromium port in r105295. We need
2367         dummy implementations in order to compile the BlackBerry port.
2368
2369         * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
2370         (AccessibilityUIElement::scrollToMakeVisible):
2371         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
2372         (AccessibilityUIElement::scrollToGlobalPoint):
2373
2374 2013-03-21  Roger Fong  <roger_fong@apple.com>
2375
2376         Re-enable WinEWS tests following r146376.
2377
2378         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
2379         (WinEWS):
2380
2381 2013-03-21  Zoltan Horvath  <zoltan@webkit.org>
2382
2383         Unreviewed. Add Bem Jones-Bey to the list of contributors.
2384
2385         * Scripts/webkitpy/common/config/committers.py:
2386
2387 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2388
2389         [GTK] Missing atk in install-dependencies script
2390         https://bugs.webkit.org/show_bug.cgi?id=112272
2391
2392         Reviewed by Gustavo Noronha Silva.
2393
2394         * gtk/install-dependencies: Add missing atk dependency.
2395
2396 2013-03-21  Claudio Saavedra  <csaavedra@igalia.com>
2397
2398         [GTK] Missing backslash in install-dependencies script
2399         https://bugs.webkit.org/show_bug.cgi?id=112907
2400
2401         Reviewed by Philippe Normand.
2402
2403         * gtk/install-dependencies: Add missing backslash to dependencies
2404         list.
2405
2406 2013-03-20  Ryosuke Niwa  <rniwa@webkit.org>
2407
2408         EWS bots have stopped uploading results to bugzilla
2409         https://bugs.webkit.org/show_bug.cgi?id=101091
2410
2411         Reviewed by Adam Barth.
2412
2413         The bug was caused by LayoutTestResultsReader passing a relative file path to the archive zip
2414         to workspace.archive_zip. Because archive_zip uses the results directory as the working directory,
2415         this relative file path resoled to a file inside a non-existent directory for "zip".
2416
2417         Fixed the bug by resolving both test results directory and zip archive paths in
2418         LayoutTestResultsReader.archive.
2419
2420         Also made workspace.create_zip print the source_path so that we may debug these issues more easily
2421         in the future.
2422
2423         * Scripts/webkitpy/common/system/filesystem_mock.py:
2424         (MockFileSystem.splitext): Don't assume the entire file path is a file extension when there is no ".".
2425
2426         * Scripts/webkitpy/common/system/workspace.py:
2427         (Workspace.create_zip): Log the source path when "zip" failed.
2428
2429         * Scripts/webkitpy/common/system/workspace_mock.py:
2430         (MockWorkspace.create_zip): Record zip_path and source_path for testing.
2431
2432         * Scripts/webkitpy/common/system/workspace_unittest.py:
2433         (WorkspaceTest.test_create_zip_exception): Test that.
2434
2435         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
2436         (LayoutTestResultsReader.archive): Resolve paths before passing them to workspace.create_zip.
2437         This is the actual bug fix.
2438
2439         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2440         (test_archive_last_layout_test_results_with_relative_path): Added a test case.
2441
2442 2013-03-20  Jochen Eisinger  <jochen@chromium.org>
2443
2444         [chromium] move WebThemeEngine implementations to TestRunner library
2445         https://bugs.webkit.org/show_bug.cgi?id=112751
2446
2447         Reviewed by Adam Barth.
2448
2449         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2450         * DumpRenderTree/DumpRenderTree.gypi:
2451         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2452         (WebKit):
2453         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2454         (WebTestRunner::TestInterfaces::themeEngine):
2455         (WebTestRunner):
2456         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2457         (WebKit):
2458         (TestInterfaces):
2459         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2460         (WebTestRunner::WebTestInterfaces::themeEngine):
2461         (WebTestRunner):
2462         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2463         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2464         (WebTestRunner):
2465         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2466         (WebTestRunner::WebTestThemeControlWin::box):
2467         (WebTestRunner::WebTestThemeControlWin::line):
2468         (WebTestRunner::WebTestThemeControlWin::triangle):
2469         (WebTestRunner::WebTestThemeControlWin::roundRect):
2470         (WebTestRunner::WebTestThemeControlWin::oval):
2471         (WebTestRunner::WebTestThemeControlWin::circle):
2472         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2473         (WebTestRunner::WebTestThemeControlWin::markState):
2474         (WebTestRunner::WebTestThemeControlWin::draw):
2475         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2476         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2477         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2478         (WebTestRunner):
2479         (WebTestThemeControlWin):
2480         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2481         (WebTestRunner):
2482         (WebTestThemeEngineMac):
2483         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2484         (+[FakeActiveWindow alwaysActiveWindow]):
2485         (+[FakeActiveWindow alwaysInactiveWindow]):
2486         (-[FakeActiveWindow initWithActiveControls:]):
2487         (-[FakeActiveWindow _hasActiveControls]):
2488         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2489         (WebTestRunner):
2490         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2491         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2492         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2493         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2494         (WebTestRunner):
2495         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2496         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2497         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2498         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2499         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2500         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2501         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2502         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2503         (WebTestRunner::WebTestThemeEngineWin::getSize):
2504         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2505         (WebTestRunner):
2506         (WebTestThemeEngineWin):
2507         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2508         * DumpRenderTree/chromium/TestShell.cpp:
2509         (TestShell::initialize):
2510         * DumpRenderTree/chromium/TestShell.h:
2511         (WebKit):
2512         * DumpRenderTree/chromium/TestShellMac.mm:
2513         (platformInit):
2514         * DumpRenderTree/chromium/TestShellWin.cpp:
2515         (platformInit):
2516         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2517
2518 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2519
2520         [WinCairo] Unreviewed build fix for TestWebKitAPI under VS2010
2521
2522         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommonWinCairo.props: Added.
2523         New property sheet that does not link against CoreFoundation and
2524         CFNetwork.
2525         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props:
2526         Use new TestWebKitAPICommonWinCairo property sheet.
2527         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props:
2528         Ditto.
2529
2530 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2531
2532         [WinCairo] Unreviewed build fix for VS2010.
2533
2534         Had to add WinCairo-specific property sheets to deal with some
2535         library and path differences with the main Apple port.
2536
2537         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2538         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props:
2539         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props:
2540         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommonWinCairo.props: Added.
2541         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebugWinCairo.props: Added.
2542         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffReleaseWinCairo.props: Added.
2543
2544 2013-03-20  Benjamin Poulain  <bpoulain@apple.com>
2545
2546         [WK2] Remove VIEW_MODE_CSS_MEDIA from WebKit2
2547         https://bugs.webkit.org/show_bug.cgi?id=112849
2548
2549         Reviewed by Sam Weinig.
2550
2551         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2552         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2553         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2554
2555 2013-03-20  Brent Fulgham  <bfulgham@webkit.org>
2556
2557         [WinCairo] Build WebKit Tools under VS2010
2558         https://bugs.webkit.org/show_bug.cgi?id=112821
2559
2560         Reviewed by Tim Horton.
2561
2562         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2563         Add WinCairo-specific build target.
2564         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebugWinCairo.props: Added.
2565         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add WinCairo-specific build target.
2566         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeReleaseWinCairo.props: Added.
2567         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeWinCairo.props: Added.
2568         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2569         Add WinCairo-specific build target.
2570         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2571         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2572         Add WinCairo-specific build target.
2573         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Add
2574         WinCairo-specific build target.
2575         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIDebugWinCairo.props: Added.
2576         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPIReleaseWinCairo.props: Added.
2577         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add WinCairo-
2578         specific build target.
2579         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj: Add
2580         WinCairo-specific build target.
2581         * win/record-memory/record-memory.vcxproj: Add WinCairo target.
2582         * win/record-memory/record-memoryDebugWinCairo.props: Added.
2583         * win/record-memory/record-memoryReleaseWinCairo.props: Added.
2584
2585 2013-03-20  Roger Fong  <roger_fong@apple.com>
2586
2587         API test gardening AppleWin port.
2588
2589         The BitmapImageEmptyFrameTest should only be tested on Cairo not on AppleWin port.
2590
2591         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2592         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2593
2594 2013-03-20  Roger Fong  <roger_fong@apple.com>
2595
2596         Test fix for Win EWS bots, catch various errors and restart script if necessary.
2597
2598         * EWSTools/start-queue-win.sh:
2599
2600 2013-03-20  Sami Kyostila  <skyostil@chromium.org>
2601
2602         Unreviewed, add myself to committers.py.
2603
2604 2013-03-20  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2605
2606         Unreviewed. Adding another email for me.
2607
2608         * Scripts/webkitpy/common/config/committers.py:
2609
2610 2013-03-20  Justin Novosad  <junov@google.com>
2611
2612         [Chromium] Code cleanup: removing support for non-deferred 2d canvas rendering
2613         https://bugs.webkit.org/show_bug.cgi?id=112605
2614
2615         Reviewed by James Robinson.
2616
2617         Deleting all the code that was used for propagating and supporting
2618         the Chromium setting for disabling deferred 2d canvas rendering.
2619
2620         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2621         (main):
2622         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
2623         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2624         (WebTestRunner::WebPreferences::reset):
2625         (WebTestRunner::WebPreferences::applyTo):
2626         * DumpRenderTree/chromium/TestShell.cpp:
2627         (TestShell::TestShell):
2628         (TestShell::resetWebSettings):
2629         (TestShell::runFileTest):
2630         * DumpRenderTree/chromium/TestShell.h:
2631         (TestShell):
2632
2633 2013-03-20  Ádám Kallai  <kadam@inf.u-szeged.hu>
2634
2635         [Qt] Qt 4.8 tool related stuff removal from webkitpy.
2636         https://bugs.webkit.org/show_bug.cgi?id=112699.
2637
2638         Reviewed by Adam Barth.
2639
2640         * Scripts/webkitpy/layout_tests/port/qt.py:
2641         (QtPort._search_paths):
2642         (QtPort._port_specific_expectations_files):
2643         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2644         (QtPortTest):
2645         (QtPortTest._assert_search_path):
2646         (QtPortTest._assert_expectations_files):
2647
2648 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2649
2650         [Qt] Enable kerning by default
2651         https://bugs.webkit.org/show_bug.cgi?id=112704
2652
2653         Reviewed by Jocelyn Turcotte.
2654
2655         Disable kerning by default, since some reference test expectations
2656         expect kerning to be default off.
2657
2658         * DumpRenderTree/qt/TestRunnerQt.cpp:
2659         (TestRunnerQt::reset):
2660         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2661         (WTR::activateFonts):
2662
2663 2013-03-20  Zeno Albisser  <zeno@webkit.org>
2664
2665         [Qt] Remove empty function stubs from TestRunnerQt.
2666         https://bugs.webkit.org/show_bug.cgi?id=112799
2667
2668         We are reducing the code in TestRunnerQt step by step,
2669         in order to finally replace all of it with the generic
2670         TestRunner implementation.
2671         This patch removes several simple function stubs that
2672         currently do not implement any actual functionality.
2673
2674         Reviewed by Kenneth Rohde Christiansen.
2675
2676         * DumpRenderTree/qt/TestRunnerQt.cpp:
2677         * DumpRenderTree/qt/TestRunnerQt.h:
2678         (TestRunnerQt):
2679
2680 2013-03-20  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2681
2682         [EFL][WK2] Don't show the SearchBar by default when MiniBrowser opened
2683         https://bugs.webkit.org/show_bug.cgi?id=112687
2684
2685         Reviewed by Kenneth Rohde Christiansen.
2686
2687         Hide the SearchBar by default on window creation.
2688
2689         * MiniBrowser/efl/main.c:
2690         (window_create):
2691
2692 2013-03-20  Sheriff Bot  <webkit.review.bot@gmail.com>
2693
2694         Unreviewed, rolling out r146304.
2695         http://trac.webkit.org/changeset/146304
2696         https://bugs.webkit.org/show_bug.cgi?id=112788
2697
2698         to many expectations to update (Requested by antonm on
2699         #webkit).
2700
2701         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2702         * DumpRenderTree/DumpRenderTree.gypi:
2703         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2704         (WebKit):
2705         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2706         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2707         (TestInterfaces):
2708         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2709         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2710         * DumpRenderTree/chromium/TestShell.cpp:
2711         (TestShell::initialize):
2712         * DumpRenderTree/chromium/TestShell.h:
2713         (WebKit):
2714         * DumpRenderTree/chromium/TestShellMac.mm:
2715         (platformInit):
2716         * DumpRenderTree/chromium/TestShellWin.cpp:
2717         (platformInit):
2718         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2719         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2720         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2721         (WebThemeControlDRTWin::box):
2722         (WebThemeControlDRTWin::line):
2723         (WebThemeControlDRTWin::triangle):
2724         (WebThemeControlDRTWin::roundRect):
2725         (WebThemeControlDRTWin::oval):
2726         (WebThemeControlDRTWin::circle):
2727         (WebThemeControlDRTWin::nestedBoxes):
2728         (WebThemeControlDRTWin::markState):
2729         (WebThemeControlDRTWin::draw):
2730         (WebThemeControlDRTWin::drawTextField):
2731         (WebThemeControlDRTWin::drawProgressBar):
2732         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2733         (WebThemeControlDRTWin):
2734         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2735         (WebThemeEngineDRTMac):
2736         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2737         (+[FakeActiveWindow alwaysActiveWindow]):
2738         (+[FakeActiveWindow alwaysInactiveWindow]):
2739         (-[FakeActiveWindow initWithActiveControls:]):
2740         (-[FakeActiveWindow _hasActiveControls]):
2741         (WebThemeEngineDRTMac::paintScrollbarThumb):
2742         (stateToHIEnableState):
2743         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2744         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2745         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2746         (webRectToSkIRect):
2747         (drawControl):
2748         (drawTextField):
2749         (drawProgressBar):
2750         (WebThemeEngineDRTWin::paintButton):
2751         (WebThemeEngineDRTWin::paintMenuList):
2752         (WebThemeEngineDRTWin::paintScrollbarArrow):
2753         (WebThemeEngineDRTWin::paintScrollbarThumb):
2754         (WebThemeEngineDRTWin::paintScrollbarTrack):
2755         (WebThemeEngineDRTWin::paintSpinButton):
2756         (WebThemeEngineDRTWin::paintTextField):
2757         (WebThemeEngineDRTWin::paintTrackbar):
2758         (WebThemeEngineDRTWin::paintProgressBar):
2759         (WebThemeEngineDRTWin::getSize):
2760         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2761         (WebThemeEngineDRTWin):
2762         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2763
2764 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2765
2766         [Qt] Support -webkit-font-smoothing
2767         https://bugs.webkit.org/show_bug.cgi?id=106009
2768
2769         Reviewed by Jocelyn Turcotte.
2770
2771         Set shouldUseFontSmoothing to false to match WebKitTestRunner.
2772
2773         * DumpRenderTree/qt/TestRunnerQt.cpp:
2774         (TestRunnerQt::reset):
2775
2776 2013-03-20  Krzysztof Czech  <k.czech@samsung.com>
2777
2778         [GTK] accessibility/aria-scrollbar-role.html is failing
2779         https://bugs.webkit.org/show_bug.cgi?id=98358
2780
2781         Reviewed by Martin Robinson.
2782
2783         Adds support for checking accessibility object's orientation.
2784         Orientation is checked by retrieving proper state of accessibility object.
2785
2786         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2787         (checkElementState):
2788         (AccessibilityUIElement::orientation):
2789         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2790         (WTR::AccessibilityUIElement::orientation):
2791
2792 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2793
2794         [chromium] move WebThemeEngine implementations to TestRunner library
2795         https://bugs.webkit.org/show_bug.cgi?id=112751
2796
2797         Reviewed by Adam Barth.
2798
2799         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2800         * DumpRenderTree/DumpRenderTree.gypi:
2801         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2802         (WebKit):
2803         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2804         (WebTestRunner::TestInterfaces::themeEngine):
2805         (WebTestRunner):
2806         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2807         (WebKit):
2808         (TestInterfaces):
2809         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2810         (WebTestRunner::WebTestInterfaces::themeEngine):
2811         (WebTestRunner):
2812         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
2813         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
2814         (WebTestRunner):
2815         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
2816         (WebTestRunner::WebTestThemeControlWin::box):
2817         (WebTestRunner::WebTestThemeControlWin::line):
2818         (WebTestRunner::WebTestThemeControlWin::triangle):
2819         (WebTestRunner::WebTestThemeControlWin::roundRect):
2820         (WebTestRunner::WebTestThemeControlWin::oval):
2821         (WebTestRunner::WebTestThemeControlWin::circle):
2822         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
2823         (WebTestRunner::WebTestThemeControlWin::markState):
2824         (WebTestRunner::WebTestThemeControlWin::draw):
2825         (WebTestRunner::WebTestThemeControlWin::drawTextField):
2826         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
2827         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
2828         (WebTestRunner):
2829         (WebTestThemeControlWin):
2830         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
2831         (WebTestRunner):
2832         (WebTestThemeEngineMac):
2833         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
2834         (+[FakeActiveWindow alwaysActiveWindow]):
2835         (+[FakeActiveWindow alwaysInactiveWindow]):
2836         (-[FakeActiveWindow initWithActiveControls:]):
2837         (-[FakeActiveWindow _hasActiveControls]):
2838         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
2839         (WebTestRunner):
2840         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
2841         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
2842         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
2843         (WebTestRunner::WebTestThemeEngineWin::paintButton):
2844         (WebTestRunner):
2845         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
2846         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
2847         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
2848         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
2849         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
2850         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
2851         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
2852         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
2853         (WebTestRunner::WebTestThemeEngineWin::getSize):
2854         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
2855         (WebTestRunner):
2856         (WebTestThemeEngineWin):
2857         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
2858         * DumpRenderTree/chromium/TestShell.cpp:
2859         (TestShell::initialize):
2860         * DumpRenderTree/chromium/TestShell.h:
2861         (WebKit):
2862         * DumpRenderTree/chromium/TestShellMac.mm:
2863         (platformInit):
2864         * DumpRenderTree/chromium/TestShellWin.cpp:
2865         (platformInit):
2866         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
2867
2868 2013-03-19  Tony Chang  <tony@chromium.org>
2869
2870         Move testRunner.setTouchDragDropEnabled to internals.settings
2871         https://bugs.webkit.org/show_bug.cgi?id=112739
2872
2873         Reviewed by Adam Barth.
2874
2875         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
2876         (WebTestRunner::TestRunner::TestRunner): Remove unnecessary code.
2877         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
2878         (TestRunner): Remove unnecessary code.
2879         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
2880         (WebTestRunner::WebPreferences::reset):
2881         (WebTestRunner::WebPreferences::applyTo): Always set to false.
2882
2883 2013-03-19  Mark Pilgrim  <pilgrim@chromium.org>
2884
2885         [Chromium] Migrate to WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2886         https://bugs.webkit.org/show_bug.cgi?id=112754
2887
2888         Reviewed by Darin Fisher.
2889
2890         Remove old code behind ifndef WEBKIT_USE_NEW_WEBFILESYSTEMTYPE
2891         now that it's always defined.
2892
2893         * DumpRenderTree/chromium/WebViewHost.cpp:
2894         * DumpRenderTree/chromium/WebViewHost.h:
2895         (WebViewHost):
2896
2897 2013-03-19  Kenneth Russell  <kbr@google.com>
2898
2899         Unreviewed, rolling out r146290.
2900         http://trac.webkit.org/changeset/146290
2901         https://bugs.webkit.org/show_bug.cgi?id=112751
2902
2903         Broke Chromium Mac build.
2904
2905         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2906         * DumpRenderTree/DumpRenderTree.gypi:
2907         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2908         (WebKit):
2909         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2910         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2911         (TestInterfaces):
2912         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
2913         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Removed.
2914         * DumpRenderTree/chromium/TestShell.cpp:
2915         (TestShell::initialize):
2916         * DumpRenderTree/chromium/TestShell.h:
2917         (WebKit):
2918         * DumpRenderTree/chromium/TestShellMac.mm:
2919         (platformInit):
2920         * DumpRenderTree/chromium/TestShellWin.cpp:
2921         (platformInit):
2922         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp.
2923         (WebThemeControlDRTWin::WebThemeControlDRTWin):
2924         (WebThemeControlDRTWin::~WebThemeControlDRTWin):
2925         (WebThemeControlDRTWin::box):
2926         (WebThemeControlDRTWin::line):
2927         (WebThemeControlDRTWin::triangle):
2928         (WebThemeControlDRTWin::roundRect):
2929         (WebThemeControlDRTWin::oval):
2930         (WebThemeControlDRTWin::circle):
2931         (WebThemeControlDRTWin::nestedBoxes):
2932         (WebThemeControlDRTWin::markState):
2933         (WebThemeControlDRTWin::draw):
2934         (WebThemeControlDRTWin::drawTextField):
2935         (WebThemeControlDRTWin::drawProgressBar):
2936         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h.
2937         (WebThemeControlDRTWin):
2938         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h.
2939         (WebThemeEngineDRTMac):
2940         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm.
2941         (+[FakeActiveWindow alwaysActiveWindow]):
2942         (+[FakeActiveWindow alwaysInactiveWindow]):
2943         (-[FakeActiveWindow initWithActiveControls:]):
2944         (-[FakeActiveWindow _hasActiveControls]):
2945         (WebThemeEngineDRTMac::paintScrollbarThumb):
2946         (stateToHIEnableState):
2947         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
2948         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
2949         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Added.
2950         (webRectToSkIRect):
2951         (drawControl):
2952         (drawTextField):
2953         (drawProgressBar):
2954         (WebThemeEngineDRTWin::paintButton):
2955         (WebThemeEngineDRTWin::paintMenuList):
2956         (WebThemeEngineDRTWin::paintScrollbarArrow):
2957         (WebThemeEngineDRTWin::paintScrollbarThumb):
2958         (WebThemeEngineDRTWin::paintScrollbarTrack):
2959         (WebThemeEngineDRTWin::paintSpinButton):
2960         (WebThemeEngineDRTWin::paintTextField):
2961         (WebThemeEngineDRTWin::paintTrackbar):
2962         (WebThemeEngineDRTWin::paintProgressBar):
2963         (WebThemeEngineDRTWin::getSize):
2964         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h.
2965         (WebThemeEngineDRTWin):
2966         (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
2967
2968 2013-03-19  Krzysztof Czech  <k.czech@samsung.com>
2969
2970         [EFL] canvas-fallback-content.html is failing
2971         https://bugs.webkit.org/show_bug.cgi?id=111998
2972
2973         Reviewed by Chris Fleizach.
2974
2975         Adds support for getting platform name.
2976
2977         * DumpRenderTree/TestRunner.cpp:
2978         (TestRunner::staticValues):
2979         * DumpRenderTree/TestRunner.h:
2980         (TestRunner):
2981         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2982         (TestRunner::platformName):
2983
2984 2013-03-19  Jochen Eisinger  <jochen@chromium.org>
2985
2986         [chromium] move WebThemeEngine implementations to TestRunner library
2987         https://bugs.webkit.org/show_bug.cgi?id=112751
2988
2989         Reviewed by Adam Barth.
2990
2991         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
2992         * DumpRenderTree/DumpRenderTree.gypi:
2993         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
2994         (WebKit):
2995         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
2996         (WebTestRunner::TestInterfaces::themeEngine):
2997         (WebTestRunner):
2998         * DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
2999         (WebKit):
3000         (TestInterfaces):
3001         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3002         (WebTestRunner::WebTestInterfaces::themeEngine):
3003         (WebTestRunner):
3004         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.cpp.
3005         (WebTestRunner::WebTestThemeControlWin::WebTestThemeControlWin):
3006         (WebTestRunner):
3007         (WebTestRunner::WebTestThemeControlWin::~WebTestThemeControlWin):
3008         (WebTestRunner::WebTestThemeControlWin::box):
3009         (WebTestRunner::WebTestThemeControlWin::line):
3010         (WebTestRunner::WebTestThemeControlWin::triangle):
3011         (WebTestRunner::WebTestThemeControlWin::roundRect):
3012         (WebTestRunner::WebTestThemeControlWin::oval):
3013         (WebTestRunner::WebTestThemeControlWin::circle):
3014         (WebTestRunner::WebTestThemeControlWin::nestedBoxes):
3015         (WebTestRunner::WebTestThemeControlWin::markState):
3016         (WebTestRunner::WebTestThemeControlWin::draw):
3017         (WebTestRunner::WebTestThemeControlWin::drawTextField):
3018         (WebTestRunner::WebTestThemeControlWin::drawProgressBar):
3019         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeControlWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRTWin.h.
3020         (WebTestRunner):
3021         (WebTestThemeControlWin):
3022         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.h.
3023         (WebTestRunner):
3024         (WebTestThemeEngineMac):
3025         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineMac.mm: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTMac.mm.
3026         (+[FakeActiveWindow alwaysActiveWindow]):
3027         (+[FakeActiveWindow alwaysInactiveWindow]):
3028         (-[FakeActiveWindow initWithActiveControls:]):
3029         (-[FakeActiveWindow _hasActiveControls]):
3030         (WebTestRunner::WebTestThemeEngineMac::paintScrollbarThumb):
3031         (WebTestRunner):
3032         (WebTestRunner::WebTestThemeEngineMac::paintHIThemeScrollbarThumb):
3033         (WebTestRunner::WebTestThemeEngineMac::paintNSScrollerScrollbarThumb):
3034         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.cpp: Added.
3035         (WebTestRunner::WebTestThemeEngineWin::paintButton):
3036         (WebTestRunner):
3037         (WebTestRunner::WebTestThemeEngineWin::paintMenuList):
3038         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarArrow):
3039         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarThumb):
3040         (WebTestRunner::WebTestThemeEngineWin::paintScrollbarTrack):
3041         (WebTestRunner::WebTestThemeEngineWin::paintSpinButton):
3042         (WebTestRunner::WebTestThemeEngineWin::paintTextField):
3043         (WebTestRunner::WebTestThemeEngineWin::paintTrackbar):
3044         (WebTestRunner::WebTestThemeEngineWin::paintProgressBar):
3045         (WebTestRunner::WebTestThemeEngineWin::getSize):
3046         * DumpRenderTree/chromium/TestRunner/src/WebTestThemeEngineWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRTWin.h.
3047         (WebTestRunner):
3048         (WebTestThemeEngineWin):
3049         (WebTestRunner::WebTestThemeEngineWin::WebTestThemeEngineWin):
3050         * DumpRenderTree/chromium/TestShell.cpp:
3051         (TestShell::initialize):
3052         * DumpRenderTree/chromium/TestShell.h:
3053         (WebKit):
3054         * DumpRenderTree/chromium/TestShellMac.mm:
3055         (platformInit):
3056         * DumpRenderTree/chromium/TestShellWin.cpp:
3057         (platformInit):
3058         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Removed.
3059
3060 2013-03-19  Kenneth Rohde Christiansen  <kenneth@webkit.org> and Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3061
3062         [EFL][WK2] Separate WebView further from EwkView
3063         https://bugs.webkit.org/show_bug.cgi?id=111591
3064
3065         Reviewed by Caio Marcelo de Oliveira Filho.
3066
3067         Updated EFL PlatformWebView to meet the new WKView API and ewk view private API.
3068         PlatformWKView is pointer to Evas_Object for EFL, as this is more natural and
3069         since we can afford it having EWKViewGetWKView() private API to access WKView.
3070
3071         * TestWebKitAPI/PlatformWebView.h:
3072         * TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:
3073         (TestWebKitAPI::TEST):
3074         * TestWebKitAPI/efl/PlatformWebView.cpp:
3075         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3076         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3077         (TestWebKitAPI::PlatformWebView::resizeTo):
3078         (TestWebKitAPI::PlatformWebView::page):
3079         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3080         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3081         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3082         * WebKitTestRunner/PlatformWebView.h:
3083         * WebKitTestRunner/efl/EventSenderProxyEfl.cpp:
3084         (WTR::EventSenderProxy::dispatchEvent):
3085         (WTR::EventSenderProxy::keyDown):
3086         (WTR::EventSenderProxy::sendTouchEvent):
3087         (WTR::EventSenderProxy::setTouchModifier):
3088         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3089         (WTR::PlatformWebView::PlatformWebView):
3090         (WTR::PlatformWebView::~PlatformWebView):
3091         (WTR::PlatformWebView::resizeTo):
3092         (WTR::PlatformWebView::page):
3093         (WTR::PlatformWebView::focus):
3094         (WTR::PlatformWebView::windowSnapshotImage):
3095
3096 2013-03-19  Roger Fong  <roger_fong@apple.com>
3097
3098         Changes to VS2010 project files should only trigger builds on Windows bots.
3099         https://bugs.webkit.org/show_bug.cgi?id=112731
3100
3101         Reviewed by Timothy Horton.
3102
3103         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3104         (_should_file_trigger_build):
3105
3106 2013-03-19  Roger Fong  <roger_fong@apple.com>
3107
3108         Unreviewed. webkitpy tests fix for Windows, runtests.py run-webkit-tests arguments changed.
3109
3110         * Scripts/webkitpy/tool/steps/runtests.py:
3111         (RunTests.run):
3112         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
3113         (RunTestsTest.test_webkit_run_unit_tests):
3114
3115 2013-03-19  Julie Parent  <jparent@chromium.org>
3116
3117         Dashboards: Introduce history namespace and unit tests.
3118         https://bugs.webkit.org/show_bug.cgi?id=112645
3119
3120         Reviewed by Ojan Vafai.
3121         
3122         Laying the framework for introducing the new history object and
3123         namespace.  This moves only static functions into the history
3124         namespace, and moves corresponding unit tests into seperate
3125         unit test file.
3126
3127         * TestResultServer/static-dashboards/aggregate_results.html:
3128         * TestResultServer/static-dashboards/dashboard_base.js:
3129         (parseCrossDashboardParameters):
3130         (parseDashboardSpecificParameters):
3131         (parseParameters):
3132         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3133         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3134         (.switch.return):
3135         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3136         * TestResultServer/static-dashboards/history.js: Added.
3137         * TestResultServer/static-dashboards/history_unittests.js: Added.
3138         * TestResultServer/static-dashboards/loader.js:
3139         (.):
3140         * TestResultServer/static-dashboards/run-embedded-unittests.html:
3141         * TestResultServer/static-dashboards/run-unittests.html:
3142         * TestResultServer/static-dashboards/timeline_explorer.html:
3143         * TestResultServer/static-dashboards/timeline_explorer.js:
3144         * TestResultServer/static-dashboards/treemap.html:
3145         * TestResultServer/static-dashboards/treemap.js:
3146         (.switch.return):
3147         * TestResultServer/static-dashboards/ui.js:
3148
3149 2013-03-19  Daniel Bates  <dbates@webkit.org>
3150
3151         svn-apply has trouble applying a patch that adds a Windows newline to EOF
3152         https://bugs.webkit.org/show_bug.cgi?id=112732
3153
3154         Reviewed by Eric Seidel.
3155
3156         Fixes an issues where a diff that adds a Windows line ending (CRLF) to the end
3157         of an existing file cannot be applied.
3158
3159         In particular, svn-{apply, unapply} compensate for differences in line endings
3160         by converting the line endings in a diff to match the line endings in the target
3161         file. The diff(1) command precedes the last line of a diff that adds a newline
3162         character to the end of a file with the special character sequence "\n \\ No newline at end of file\n"
3163         Svn-{apply, unapply} converts the newline characters (\n) in this character sequence
3164         to \r\n (CRLF) when the target file has Windows line endings and patch(1) complains
3165         when applying this modified diff. Instead, svn-{apply, unapply} should not modify
3166         the newline characters in this special character sequence to match the line endings
3167         in the target file.
3168
3169         * Scripts/VCSUtils.pm:
3170         (parseDiff):
3171         * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3172         Added tests:
3173             - "SVN: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3174             - "SVN: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3175             - "Git: Patch adds Windows newline to EOF and IndexPath has Windows line endings"
3176             - "Git: Patch adds Mac newline to EOF and IndexPath has Mac line endings"
3177         (escapeNewLineCharacters): Added.
3178         (toMacLineEndings): Added.
3179
3180 2013-03-19  James Robinson  <jamesr@chromium.org>
3181
3182         [chromium] Remove compositor settings that don't go through WebKit
3183         https://bugs.webkit.org/show_bug.cgi?id=112718
3184
3185         Reviewed by Adam Barth.
3186
3187         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3188         (main):
3189         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3190         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3191         (WebTestRunner::WebPreferences::reset):
3192         (WebTestRunner::WebPreferences::applyTo):
3193         * DumpRenderTree/chromium/TestShell.cpp:
3194         (TestShell::TestShell):
3195         (TestShell::resetWebSettings):
3196         * DumpRenderTree/chromium/TestShell.h:
3197         (TestShell):
3198
3199 2013-03-19  Dirk Pranke  <dpranke@chromium.org>
3200
3201         Unreviewed, rolling out r146101.
3202         https://bugs.webkit.org/show_bug.cgi?id=111884
3203
3204         re-enable custom freetype on asan; this needs to be on
3205         now that the bot is running lucid.
3206
3207         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3208
3209 2013-03-19  Alberto Garcia  <agarcia@igalia.com>
3210
3211         [BlackBerry] Enable USE_SYSTEM_MALLOC by default
3212         https://bugs.webkit.org/show_bug.cgi?id=112365
3213
3214         Reviewed by Benjamin Poulain.
3215
3216         Enable USE_SYSTEM_MALLOC by default via FeatureList.pm instead of
3217         harcoding it in wtf/Platform.h
3218
3219         * Scripts/webkitperl/FeatureList.pm:
3220
3221 2013-03-19  Allan Sandfeld Jensen  <allan.jensen@digia.com>
3222
3223         [Qt] Make ImageDiff similar to Chromium's ImageDiff
3224         https://bugs.webkit.org/show_bug.cgi?id=94782
3225
3226         Based on patch by Csaba Osztrogonác.
3227         Reviewed by Jocelyn Turcotte.
3228
3229         The diff image is generated with bright red indicating errors, but letting the base image
3230         shine through so the context of the error-pixel can be identified.
3231
3232         * DumpRenderTree/qt/ImageDiff.cpp:
3233         (main):
3234
3235 2013-03-18  Andras Becsi  <andras.becsi@digia.com>
3236
3237         [Qt] Fix the build of QtTestBrowser if the print preview dialog is disabled in Qt
3238
3239         Rubber-stamped by Csaba Osztrogonác.
3240
3241         Check for QT_NO_PRINTPREVIEWDIALOG instead of QT_NO_PRINTER
3242         since the latter might not cover the former.
3243
3244         * QtTestBrowser/launcherwindow.cpp:
3245         (LauncherWindow::print):
3246
3247 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3248
3249         Style tweeks to default.css.
3250         
3251         Rubber-stamped by David Kilzer.
3252         
3253         Give visited links a different color to other links, so you can
3254         see which builds you've viewed.
3255         
3256         Make the <small> text less tiny.
3257
3258         * BuildSlaveSupport/build.webkit.org-config/public_html/default.css:
3259         (small):
3260         (a:link,a:visited,a:active):
3261         (a:visited):
3262
3263 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3264
3265         Remove the temporary hack for webkit-perf.appspot.com and cleanup the code
3266         https://bugs.webkit.org/show_bug.cgi?id=112494
3267
3268         Reviewed by Dirk Pranke.
3269
3270         Removed the code to override webkit-perf.appspot.com by perf.webkit.org.
3271         Also merged two pairs of methods to cleanup the code.
3272
3273         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3274         (PerfTestsRunner.run): Merged _upload_and_show_results.
3275         (PerfTestsRunner._generate_results): Merged _generate_output_files.
3276
3277 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3278
3279         [chromium] build xdisplaycheck when building DRT
3280         https://bugs.webkit.org/show_bug.cgi?id=112636
3281
3282         Reviewed by Tony Chang.
3283
3284         It appears that we need xdisplaycheck to be built in order for
3285         Xvfb to be started correctly on the bots, and DRT was missing
3286         a dependency on it. This may be the cause of the ASAN bot not
3287         starting up properly (it only builds DRT).
3288
3289         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3290
3291 2013-03-18  David Levin  <levin@chromium.org>
3292
3293         Implement icon change notification dump for Chromium's test shell.
3294         https://bugs.webkit.org/show_bug.cgi?id=112614
3295
3296         This was previously implemented for some other platforms in r58111
3297         and r116547.
3298
3299         In r122806, fast/dom/icon-url-property.html stopped using it, but
3300         it is useful for tests, so I plan to re-add it to that test again.
3301
3302         Reviewed by Jochen Eisinger.
3303
3304         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3305         (WebTestRunner::WebTestProxy::didChangeIcon): Add handler so that
3306          icon change notifications from WebKit may be logged in test output.
3307         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3308         (WebTestRunner::TestRunner::TestRunner): Expose dumpIconChanges.
3309         (WebTestRunner::TestRunner::reset): Clear the new dump variable.
3310         (WebTestRunner::TestRunner::shouldDumpIconChanges): Expose the dump vairable.
3311         (WebTestRunner):
3312         (WebTestRunner::TestRunner::dumpIconChanges): Implement the test method.
3313         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3314         (TestRunner):
3315         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3316         (WebTestRunner::WebTestProxyBase::didChangeIcon):
3317         (WebTestRunner):
3318         * DumpRenderTree/chromium/WebViewHost.cpp:
3319         (WebViewHost::didChangeIcon): Add the output about changing the icon.
3320         * DumpRenderTree/chromium/WebViewHost.h:
3321         (WebViewHost):
3322
3323 2013-03-18  Julie Parent  <jparent@chromium.org>
3324
3325         Cleanup: Move js for treemap and aggregate_results into own js files.
3326         https://bugs.webkit.org/show_bug.cgi?id=112618
3327
3328         Reviewed by Dirk Pranke.
3329         
3330         No functional changes, just moving the code into separate js file
3331         rather than inlined in the html, so we can test it, make it more
3332         modular, etc.  Other dashboard types are already done this way.
3333
3334         * TestResultServer/static-dashboards/aggregate_results.html:
3335         * TestResultServer/static-dashboards/aggregate_results.js: Copied from Tools/TestResultServer/static-dashboards/aggregate_results.html.
3336         (generatePage):
3337         (handleValidHashParameter):
3338         (htmlForBuilder):
3339         (rawValuesHTML):
3340         (chartHTML):
3341         (filteredValues):
3342         (chart):
3343         (htmlForRevisionRows):
3344         (wrapHTMLInTable):
3345         (htmlForSummaryTable):
3346         (valuesPerExpectation):
3347         (htmlForTestType):
3348         (htmlForTableRow):
3349         (extendedEncode):
3350         * TestResultServer/static-dashboards/treemap.html:
3351         * TestResultServer/static-dashboards/treemap.js: Copied from Tools/TestResultServer/static-dashboards/treemap.html.
3352         (humanReadableTime):
3353         (convertToWebTreemapFormat):
3354         (reverseSortByAverage):
3355         (generatePage):
3356         (focusPath):
3357         (.switch.return):
3358         (handleQueryParameterChange):
3359         (extractName):
3360         (fullName):
3361         (handleFocus.):
3362         (handleFocus):
3363
3364 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3365
3366         [webkitpy] '/usr/bin/interdiff' output while running test-webkitpy
3367         https://bugs.webkit.org/show_bug.cgi?id=112622
3368
3369         Reviewed by Dirk Pranke.
3370
3371         * Scripts/webkitpy/tool/steps/haslanded_unittest.py:
3372         (HasLandedTest): Pipe the stdout and stderr output of the subprocess call to subprocess.PIPE, eliminating unnecessary output.
3373
3374 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3375
3376         [NRWT][GTK] Add gtk-wk1 directory to the list of baseline search paths when using DumpRenderTree
3377         https://bugs.webkit.org/show_bug.cgi?id=112619
3378
3379         Reviewed by Dirk Pranke.
3380
3381         When using DumpRenderTree on the Gtk port, NRWT should look for baselines first in the LayoutTests/platform/gtk-wk1
3382         directory and then fall back to the generic LayoutTests/platform/gtk directory.
3383
3384         * Scripts/webkitpy/layout_tests/port/gtk.py:
3385         (GtkPort.default_baseline_search_path): Implement the method on the GtkPort class, mapping every search path to the
3386         Port._webkit_baseline_path method.
3387         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
3388         (GtkPortTest.test_default_baseline_search_path): Add a test for the changes that are being introduced.
3389         (GtkPortTest.test_port_specific_expectations_files): Wrap a couple of long lines.
3390         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3391         (TestRebaselineTest.test_baseline_directory): Enhance one and add an additional test case for baseline directories
3392         that are expected based on the builder name.
3393
3394 2013-03-18  Mark Pilgrim  <pilgrim@chromium.org>
3395
3396         [Chromium] Create WebFileSystemType enum to allow easier filesystem refactoring
3397         https://bugs.webkit.org/show_bug.cgi?id=112571
3398
3399         Reviewed by Adam Barth.
3400
3401         Update function declarations for new WebFileSystemType enum. (All
3402         changes are behind an #ifdef so we can sync required changes in embedders.)
3403
3404         * DumpRenderTree/chromium/WebViewHost.cpp:
3405         (WebViewHost::openFileSystem):
3406         (WebViewHost::deleteFileSystem):
3407         * DumpRenderTree/chromium/WebViewHost.h:
3408         (WebViewHost):
3409
3410 2013-03-18  Julie Parent  <jparent@chromium.org>
3411
3412         Cleanup: Move timeline_exporer js out of html file into js.
3413         https://bugs.webkit.org/show_bug.cgi?id=112188
3414
3415         Reviewed by Dirk Pranke.
3416         
3417         Moves the javascript out of the html file and into a new js file.
3418         This follows the format of flakiness_dashboard.{html|js}.
3419         
3420         Also moves code from dashboard_base that is used only by this one
3421         dashboard, and makes it private to the dashboard.
3422
3423         * TestResultServer/static-dashboards/dashboard_base.js:
3424         * TestResultServer/static-dashboards/timeline_explorer.html:
3425         * TestResultServer/static-dashboards/timeline_explorer.js: Copied from Tools/TestResultServer/static-dashboards/timeline_explorer.html.
3426         (generatePage):
3427         (initCurrentBuilderTestResults):
3428         (shouldShowWebKitRevisionsOnly):
3429         (updateTimelineForBuilder.):
3430         (updateTimelineForBuilder):
3431         (selectBuild):
3432         (updateBuildIndicator):
3433         (.addRow):
3434         (.addNumberRow):
3435         (.inspectorNode.getElementsByTagName.0.onclick):
3436         (.inspectorNode.getElementsByTagName.1.onclick):
3437         (.inspectorNode.getElementsByTagName.2.onclick):
3438         (updateBuildInspector):
3439         (showResultsDelta):
3440         (decompressResults.addFlakyDelta):
3441         (decompressResults):
3442
3443 2013-03-18  Dirk Pranke  <dpranke@chromium.org>
3444
3445         Unreviewed, rolling out r145272.
3446         http://trac.webkit.org/changeset/145272
3447         https://bugs.webkit.org/show_bug.cgi?id=111884
3448
3449         Turns out the ASAN build is still broken; possibly there's
3450         something still setting LD_LIBRARY_PATH, or possibly there's
3451         something else wrong. In the meantime, we need it to work again.
3452
3453         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3454
3455 2013-03-18  Ryosuke Niwa  <rniwa@webkit.org>
3456
3457         delete-stale-build-files is too aggressive
3458         https://bugs.webkit.org/show_bug.cgi?id=112595
3459
3460         Reviewed by Tim Horton.
3461
3462         It appears that whitelisting file extensions to keep is not a good idea.
3463         Blacklist files to delete instead, and only delete .o files for now.
3464         We can add more file extensions as needed.
3465
3466         * BuildSlaveSupport/delete-stale-build-files:
3467
3468 2013-03-18  Simon Fraser  <simon.fraser@apple.com>
3469
3470         Disable accessibility notifications after each test
3471         https://bugs.webkit.org/show_bug.cgi?id=112579
3472
3473         Reviewed by Tim Horton.
3474         
3475         In WebKitTestRunner, if any tests triggered accessibility notifications,
3476         the global notification handler would thereafter be active, and fire
3477         notifications for all subsequent tests.
3478         
3479         Fix by implementing AccessibilityController::resetToConsistentState() for
3480         Mac, and using it to clear the global notification handler.
3481
3482         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3483         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
3484         (WTR::AccessibilityController::addNotificationListener): Remove stupid comment.
3485         (WTR::AccessibilityController::removeNotificationListener): Explicitly call
3486         -stopObserving so that unregistering the observer doesn't rely on object lifetimes
3487         (e.g. because of -autorelease).
3488         (WTR::AccessibilityController::logAccessibilityEvents): Stub.
3489         (WTR::AccessibilityController::resetToConsistentState): Remove the notification listener
3490         if there is one.
3491         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h:
3492         Add -stopObserving
3493         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3494         (-[AccessibilityNotificationHandler dealloc]): Call -stopObserving
3495         (-[AccessibilityNotificationHandler stopObserving]): Unregister from the notification
3496         center.
3497
3498 2013-03-18  Dana Jansens  <danakj@chromium.org>
3499
3500         [chromium] Remove WebGraphicsContext3DInProcessImpl support from DRT.
3501         https://bugs.webkit.org/show_bug.cgi?id=112392
3502
3503         Reviewed by James Robinson.
3504
3505         Removes the command line flag option from DRT.
3506
3507         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3508         (main):
3509
3510 2013-03-18  Zan Dobersek  <zdobersek@igalia.com>
3511
3512         [GTK] plugins/plugin-clip-subframe.html is failing
3513         https://bugs.webkit.org/show_bug.cgi?id=112570
3514
3515         Reviewed by Martin Robinson.
3516
3517         * GNUmakefile.am: Add the LogNPPSetWindow.cpp file to the build.
3518
3519 2013-03-17  Morten Stenshorne  <mstensho@opera.com>
3520
3521         Add reload button (and F5 accelerator) to the GtkLauncher toolbar
3522         https://bugs.webkit.org/show_bug.cgi?id=112442
3523
3524         Reviewed by Gustavo Noronha Silva.
3525
3526         * GtkLauncher/main.c:
3527         (reloadCb):
3528         (createToolbar):
3529         (createWindow):
3530
3531 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3532
3533         REGRESSION (r144884?): WebKit2.DOMWindowExtensionBasic API test is asserting
3534         https://bugs.webkit.org/show_bug.cgi?id=112205
3535
3536         Disable this API test until Geoff can fix it.
3537
3538         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
3539         (TestWebKitAPI::TEST):
3540
3541 2013-03-15  Jochen Eisinger  <jochen@chromium.org>
3542
3543         plugins/netscape-plugin-setwindow-size*.html and plugins/pass-different-npp-struct.html should be async
3544         https://bugs.webkit.org/show_bug.cgi?id=112478
3545
3546         Reviewed by Tony Chang.
3547
3548         There is nothing that ensures that the log messages from the plugin
3549         come in before the layout test finished loading.
3550
3551         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
3552         (PassDifferentNPPStruct::NPP_SetWindow):
3553         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
3554         (NPP_SetWindow):
3555
3556 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3557
3558         Have the mac port support per_test_timeout in webkitpy
3559         https://bugs.webkit.org/show_bug.cgi?id=112466
3560
3561         Reviewed by Dirk Pranke.
3562         
3563         Both WTR and DRT handle --timeout arguments, so we can
3564         have the scripts pass the timeout values down to the tools.
3565
3566         * Scripts/webkitpy/layout_tests/port/mac.py:
3567         (MacPort.supports_per_test_timeout):
3568
3569 2013-03-15  Rouslan Solomakhin  <rouslan@chromium.org>
3570
3571         Remove setAsynchronousSpellCheckingEnabled from test runners
3572         https://bugs.webkit.org/show_bug.cgi?id=112362
3573
3574         Reviewed by Tony Chang.
3575
3576         Remove setAsynchronousSpellCheckingEnabled from test runners. The setting is now
3577         in internals.settings, so all ports can share it.
3578
3579         * DumpRenderTree/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3580         * DumpRenderTree/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3581         * DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3582         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3583         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h: Remove setAsynchronousSpellCheckingEnabled() method.
3584         * DumpRenderTree/efl/TestRunnerEfl.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3585         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3586         * DumpRenderTree/mac/TestRunnerMac.mm: Remove setAsynchronousSpellCheckingEnabled() method.
3587         * DumpRenderTree/qt/TestRunnerQt.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3588         * DumpRenderTree/qt/TestRunnerQt.h: Remove setAsynchronousSpellCheckingEnabled() method.
3589         * DumpRenderTree/win/TestRunnerWin.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3590         * DumpRenderTree/wx/TestRunnerWx.cpp: Remove setAsynchronousSpellCheckingEnabled() method.
3591
3592 2013-03-15  Simon Fraser  <simon.fraser@apple.com>
3593
3594         Fix the stupid unit tests.
3595
3596         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3597         (test_sample_process):
3598
3599 2013-03-14  Simon Fraser  <simon.fraser@apple.com>
3600
3601         Collect samples for unresponsive web processes
3602         https://bugs.webkit.org/show_bug.cgi?id=112409
3603
3604         Reviewed by Tim Horton.
3605         
3606         When we detect that a subprocess was unresponsive, run the 'sample'
3607         tool on that process, for the Mac port.
3608         
3609         The sample will be linked to from the results.html page, next
3610         to the crash log link.
3611
3612         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3613         (Manager._look_for_new_crash_logs): Before looking for crash logs,
3614         look for samples on disk.
3615         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3616         (TestResultWriter):
3617         (TestResultWriter.copy_sample_file): Teach TestResultWriter about
3618         -sample.txt files, and have it copy their contents to a new file
3619         next to the test that spawned them (as we do for crash logs).
3620         * Scripts/webkitpy/layout_tests/port/base.py:
3621         (Port.look_for_new_samples): Base class does nothing for sampling.
3622         * Scripts/webkitpy/layout_tests/port/driver.py:
3623         (Driver._check_for_driver_crash): Kick off a sample if we detected
3624         that the subprocess was unresponsive.
3625         * Scripts/webkitpy/layout_tests/port/mac.py:
3626         (MacPort.sample_file_path): Utility to generate the file path
3627         to the generated sample files at the top level of layout-test-results.
3628         (MacPort.look_for_new_crash_logs): Fix typo
3629         (MacPort.look_for_new_samples): New function to find sample files.
3630         (MacPort.sample_process): Use the utility function to get the file path.
3631
3632 2013-03-15  Zeno Albisser  <zeno@webkit.org>
3633
3634         [Qt] Remove simple getters and setters from TestRunnerQt
3635         https://bugs.webkit.org/show_bug.cgi?id=112343
3636
3637         Reviewed by Benjamin Poulain.
3638
3639         The removed functions and boolean members
3640         are being replaced by the implementations in the
3641         generic TestRunner.h.
3642
3643         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3644         (DumpRenderTree::dumpFrameScrollPosition):
3645         (DumpRenderTree::dumpFramesAsText):
3646         (DumpRenderTree::dump):
3647         (DumpRenderTree::titleChanged):
3648         (DumpRenderTree::dumpDatabaseQuota):