Unreviewed build fix. Wrong variable being used as the cwd for git
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
2
3         Unreviewed build fix. Wrong variable being used as the cwd for git
4         remote update command.
5
6         * gtk/run-with-jhbuild:
7         (update_jhbuild):
8
9 2012-01-19  Gustavo Noronha Silva  <gns@gnome.org>
10
11         [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
12         https://bugs.webkit.org/show_bug.cgi?id=76585
13
14         Reviewed by Martin Robinson.
15
16         This allows us to specify a minimum version of jhbuild required,
17         while also providing stability against changes done to the master
18         branch, by letting us choose what is the exact version that will
19         be used.
20
21         * gtk/run-with-jhbuild: refactored for more hackability and easier
22         reading
23         (jhbuild_installed): checks whether jhbuild is installed
24         (jhbuild_cloned): checks whether jhbuild has been cloned
25         (jhbuild_at_expected_revision): checks whether jhbuild is at the
26         expected revision
27         (update_jhbuild): brings jhbuild to the expected revision
28         (clone_jhbuild): clones jhbuild
29         (install_jhbuild): build and installs jhbuild
30         (update_webkitgtk_libs): runs update-webkitgtk-libs
31         (ensure_jhbuild): high-level logic to decide whether and which of
32         the steps above are executed
33
34 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
35
36         [WK2] DumpRenderTree converts "file:///" to a path differently
37         https://bugs.webkit.org/show_bug.cgi?id=76653
38
39         Reviewed by John Sullivan.
40
41         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
42         Do print a slash if there are no path components.
43
44 2012-01-19  Eric Seidel  <eric@webkit.org>
45
46         webkit-patch cannot rollout patches without changelog/bug number
47         https://bugs.webkit.org/show_bug.cgi?id=75962
48
49         Reviewed by Adam Barth.
50
51         * Scripts/webkitpy/tool/commands/download.py:
52         (AbstractRolloutPrepCommand._prepare_state):
53         * Scripts/webkitpy/tool/commands/download_unittest.py:
54         (AbstractRolloutPrepCommandTest.test_prepare_state):
55
56 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
57
58         [WK2] fast/url/degenerate-file-base.html fails
59         https://bugs.webkit.org/show_bug.cgi?id=76619
60
61         Reviewed by Adam Roben.
62
63         A URL generated form local path for loading had an extra slash, making document.URL
64         incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
65
66         * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
67
68 2012-01-18  Ojan Vafai  <ojan@chromium.org>
69
70         check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
71         https://bugs.webkit.org/show_bug.cgi?id=76510
72
73         Reviewed by Adam Barth.
74
75         Unlike other style rules, if you get the syntax of the test_expectations.txt
76         file wrong, the layout tests won't run. Also, this check is simple and only
77         slows down committing if you actually modify one of the test_expectations.txt files.
78
79         * Scripts/webkitpy/style/checkers/test_expectations.py:
80         (TestExpectationsChecker.check_test_expectations):
81         (TestExpectationsChecker.check):
82         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
83         (TestExpectationsTestCase.test_check_covers_all_configurations):
84         (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
85         (TestExpectationsTestCase):
86         (assert_lines_lint):
87
88 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
89
90         Build fix. Revert an unintentional change to WebKitDriver in r105443.
91
92         * Scripts/webkitpy/layout_tests/port/driver.py:
93         (DriverProxy.__init__):
94
95 2012-01-19  Dirk Pranke  <dpranke@chromium.org>
96
97         remove the duplicated build rules from WebKit.gyp, Tools.gyp
98         https://bugs.webkit.org/show_bug.cgi?id=73384
99
100         Reviewed by Tony Chang.
101
102         This patch removes the no-longer-necessary conditional logic for
103         build_webkit_exes_from_webkit_gyp; we now always build the exes
104         from their own dedicated gyp files.
105
106         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
107
108 2012-01-19  Alexey Proskuryakov  <ap@apple.com>
109
110         make-new-script-test should work with HTTP tests
111         https://bugs.webkit.org/show_bug.cgi?id=76603
112
113         Reviewed by Adam Roben.
114
115         * Scripts/make-new-script-test:
116         (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
117         now also creates absolute paths for HTTP.
118
119 2012-01-19  Ryosuke Niwa  <rniwa@webkit.org>
120
121         Some perf tests time out when ran by run-perf-tests
122         https://bugs.webkit.org/show_bug.cgi?id=76612
123
124         Reviewed by Dirk Pranke and Eric Seidel.
125
126         Always pass --no-timeout to DumpRenderTree from run-perf-tests.
127         Otherwise some tests such as Parser/xml-parser.html will timeout.
128
129         --no-timeout option is currently supported by Chromium and Mac ports.
130
131         * Scripts/webkitpy/layout_tests/port/base.py:
132         (Port.to.create_driver):
133         * Scripts/webkitpy/layout_tests/port/chromium.py:
134         (ChromiumDriver.__init__):
135         (ChromiumDriver._wrapper_options):
136         * Scripts/webkitpy/layout_tests/port/driver.py:
137         (Driver.__init__):
138         (DriverProxy.__init__):
139         * Scripts/webkitpy/layout_tests/port/webkit.py:
140         (WebKitDriver.__init__):
141         (WebKitDriver.cmd_line):
142         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
143         (WebKitDriverTest.test_read_binary_block):
144         (WebKitDriverTest):
145         (WebKitDriverTest.test_no_timeout):
146         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
147         (get_tests_run.RecordingTestDriver.__init__):
148         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
149         (PerfTestsRunner._parse_args):
150         (PerfTestsRunner._run_tests_set):
151         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
152         (create_runner):
153
154 2012-01-19  Ben Wells  <benwells@chromium.org>
155
156         Add support for window.print to chromium DRT
157         https://bugs.webkit.org/show_bug.cgi?id=76479
158
159         When used in a test window.print goes into print mode and then
160         straight out again. This will allow the afterprint event to be
161         tested by having the afterprint event happen before the dump
162         happens.
163
164         Reviewed by Mihai Parparita.
165
166         * DumpRenderTree/chromium/WebViewHost.cpp:
167         (WebViewHost::printPage):
168         * DumpRenderTree/chromium/WebViewHost.h:
169
170 2012-01-18  Enrica Casucci  <enrica@apple.com>
171
172         editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
173         https://bugs.webkit.org/show_bug.cgi?id=76588
174         <rdar://problem/9325183>
175
176         Added test.
177         
178         Reviewed by Dan Bernstein.
179
180         * TestWebKitAPI/Tests/mac/InspectorBar.mm:
181         (TestWebKitAPI::TEST):
182
183 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
184
185         [Qt] Do full incremental builds until bots use update-webkit
186
187         Rubber-stamped by Simon Hausmann.
188
189         * Scripts/webkitdirs.pm:
190         (buildQMakeProjects):
191
192 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
193
194         Fix the Qt build
195
196         Unreviewed build fix.
197
198         * Scripts/webkitdirs.pm:
199         (buildQMakeProjects):
200
201 2012-01-19  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
202
203         [Qt] Make build-webkit always do safe incremental builds after update-webkit
204
205         When building against Qt5 with GCC we would just run 'make' in the build dir,
206         and rely on the dependency files output by GCC (-MD) to handle dependency
207         tracking, but that fails for special-cases like adding a Q_OBJECT macro
208         to a header.
209
210         To guarantee that an incrmental build will work, we have to run 'make qmake',
211         which we now do on every build-webkit that's followed by a successful run
212         of update-webkit. The reasoning is that update-webkit can result in such
213         potential corner-cases being applied, and since we can't know for sure
214         unless we inspect the diff and account for all the corner cases we assume
215         the worst and always run 'make qmake'.
216
217         After a succesful run of build-webkit we proceed to do just 'make' for any
218         subsequent runs, since we assume that the developer knows what kind of
219         changes he/she is doing, and when a 'make qmake' is needed.
220
221         Reviewed by Simon Hausmann.
222
223         * Scripts/update-webkit:
224         * Scripts/webkitdirs.pm:
225         (determineCurrentSVNRevision):
226         (currentSVNRevision):
227         (buildQMakeProjects):
228         * qmake/mkspecs/features/default_post.prf:
229
230 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
231
232         run-perf-tests should support Skipped list
233         https://bugs.webkit.org/show_bug.cgi?id=76594
234
235         Reviewed by Adam Barth.
236
237         Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
238
239         * Scripts/webkitpy/layout_tests/port/base.py:
240         (Port.perf_tests_dir):
241         (Port.skipped_perf_tests):
242         (Port.skips_perf_test):
243         (Port.relative_perf_test_filename):
244         * Scripts/webkitpy/layout_tests/port/test.py:
245         (TestPort.perf_tests_dir):
246         * Scripts/webkitpy/layout_tests/port/webkit.py:
247         (WebKitPort._expectations_from_skipped_files):
248         (WebKitPort):
249         (WebKitPort.skipped_layout_tests):
250         (WebKitPort.skipped_perf_tests):
251         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
252         (PerfTestsRunner._collect_tests):
253         (PerfTestsRunner.run):
254         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
255         (test_run_test_set_with_json_output):
256         (test_run_test_set_with_json_source):
257         (test_collect_tests_with_skipped_list):
258         (test_collect_tests_with_skipped_list.add_file):
259
260 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
261
262         Fix path to chromium_src_dir introduced in previous change.
263
264         Unreviewed, build fix.
265
266         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
267
268 2012-01-18  Alexey Proskuryakov  <ap@apple.com>
269
270         Need infrastructure to test Content-Disposition filename encoding support
271         https://bugs.webkit.org/show_bug.cgi?id=76572
272         <rdar://problem/6421825>
273
274         Reviewed by Sam Weinig.
275
276         Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
277
278         WebKitTestRunner does not have a policy delegate yet, bug 42546.
279
280         * DumpRenderTree/mac/PolicyDelegate.mm:
281         (dispositionTypeFromContentDispositionHeader):
282         (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
283
284 2012-01-18  Ojan Vafai  <ojan@chromium.org>
285
286         Fix tests from http://trac.webkit.org/changeset/105332.
287
288         The code assumed that if you passed an options object with a configuration
289         attribute that it would have a valid value. A bunch of the testing mocks
290         do things like having a configuration value of None.
291
292         * Scripts/webkitpy/layout_tests/port/base.py:
293         (Port.__init__):
294
295 2012-01-18  Ojan Vafai  <ojan@chromium.org>
296
297         Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
298         https://bugs.webkit.org/show_bug.cgi?id=76576
299
300         Reviewed by Adam Barth.
301
302         Avoid calling default_configuration in base.py. We don't need it for
303         checking test_expectations.txt style. It takes ~0.5 seconds to run on my
304         Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
305         from common.executive.
306
307         At some point someone should probably look into why that call is so slow
308         since it's on the critical path for run-webkit-tests and build-webkit startup.
309
310         * Scripts/webkitpy/layout_tests/port/base.py:
311         (Port.__init__):
312         * Scripts/webkitpy/style/checkers/test_expectations.py:
313         (TestExpectationsChecker._determine_port_from_exepectations_path):
314
315 2012-01-18  Dirk Pranke  <dpranke@chromium.org>
316
317         [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
318         https://bugs.webkit.org/show_bug.cgi?id=76505
319
320         Reviewed by Tony Chang.
321
322         Update chromium build script to use All.gyp instead of WebKit.gyp
323
324         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
325         * Scripts/webkitdirs.pm:
326
327 2012-01-18  Sam Weinig  <sam@webkit.org>
328
329         Don’t hardcode the path to ‘make‘.
330
331         Reviewed by Dan Bernstein.
332
333         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
334
335 2012-01-18  Joshua Bell  <jsbell@chromium.org>
336
337         Adding myself to committers.py
338         https://bugs.webkit.org/show_bug.cgi?id=76569
339
340         Unreviewed.
341
342         * Scripts/webkitpy/common/config/committers.py:
343
344 2012-01-18  Adam Barth  <abarth@webkit.org>
345
346         Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
347         https://bugs.webkit.org/show_bug.cgi?id=76567
348
349         Reviewed by Eric Seidel.
350
351         Current the AppleMac port has slightly more failures than we allow on
352         the EWS, causing the mac-ews to spin.  This patch ups the limit a bit,
353         which should hopefully let the mac-ews run to completion.  Once
354         AppleMac has fewer failures, we can lower the cap again.
355
356         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
357         (LayoutTestResultsReaderTest.test_layout_test_results):
358         * Scripts/webkitpy/tool/steps/runtests.py:
359         (RunTests):
360         * Scripts/webkitpy/tool/steps/steps_unittest.py:
361
362 2012-01-18  Eric Carlson  <eric.carlson@apple.com>
363
364         Provide access to user's list of preferred languages
365         https://bugs.webkit.org/show_bug.cgi?id=76138
366
367         Reviewed by Alexey Proskuryakov.
368
369         * GNUmakefile.am: Add JSInternalsCustom.cpp.
370
371 2012-01-18  Adam Barth  <abarth@webkit.org>
372
373         Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
374         configurations.
375
376         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
377         (ChromiumLinuxPort.__init__):
378
379 2012-01-18  Dominic Mazzoni  <dmazzoni@google.com>
380
381         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
382         https://bugs.webkit.org/show_bug.cgi?id=73460
383
384         Reviewed by Chris Fleizach.
385
386         * DumpRenderTree/AccessibilityUIElement.h:
387         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
388         (AccessibilityUIElement::AccessibilityUIElement):
389         (AccessibilityUIElement::scrollToMakeVisibleCallback):
390         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
391         (AccessibilityUIElement::scrollToGlobalPointCallback):
392         * DumpRenderTree/chromium/AccessibilityUIElement.h:
393         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
394         (AccessibilityUIElement::scrollToMakeVisible):
395         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
396         (AccessibilityUIElement::scrollToGlobalPoint):
397         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
398         (AccessibilityUIElement::scrollToMakeVisible):
399         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
400         (AccessibilityUIElement::scrollToGlobalPoint):
401         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
402         (AccessibilityUIElement::scrollToMakeVisible):
403         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
404         (AccessibilityUIElement::scrollToGlobalPoint):
405
406 2012-01-17  Enrica Casucci  <enrica@apple.com>
407
408         Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
409         https://bugs.webkit.org/show_bug.cgi?id=76490
410         <rdar://problem/9460733>
411
412         Added TestWebKitAPI test.
413         
414         Reviewed by Dan Bernstein.
415
416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
417         * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
418         changeAttributes to the WebView.
419         
420 2012-01-18  Balazs Kelemen  <kbalazs@webkit.org>
421
422         [Qt] Consolidate layout test crash logging
423         https://bugs.webkit.org/show_bug.cgi?id=75088
424
425         Reviewed by Simon Hausmann.
426
427         Move backtrace generating logic into WTFReportBacktrace
428         and add a way to deinstall signal handlers if we know
429         that we have already printed the backtrace.
430
431         * DumpRenderTree/qt/main.cpp:
432         (crashHandler):
433         (setupSignalHandlers):
434         (WTFCrashHook):
435         (main):
436         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
437         (WTR::crashHandler):
438         (WTR::setupSignalHandlers):
439         (WTR::crashHook):
440         (WTR::InjectedBundle::platformInitialize):
441
442 2012-01-18  Ilya Tikhonovsky  <loislo@chromium.org>
443
444         Unreviewed build fix after r105256.
445
446         There was a cyclic dependency between self._port and self._host assigments.
447
448         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
449         (PerfTestsRunner.__init__):
450
451 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
452
453         Add new watchlist rule for the Qt build system
454
455         Reviewed by Simon Hausmann.
456
457         * Scripts/webkitpy/common/config/watchlist:
458
459 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
460
461         [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
462
463         Reviewed by Simon Hausmann.
464
465         * Tools.pro:
466
467 2012-01-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
468
469         [Qt] Allow building only a subset of the WebKit sub-projects
470
471         Fixes build-jsc, broken in r104825.
472
473         We no longer need the intermediate buildQMakeQtProject(), as we're the
474         only port using qmake, and buildQMakeProject is now highly Qt specific.
475
476         <http://webkit.org/b/76179>
477
478         Reviewed by Simon Hausmann.
479
480         * Scripts/build-jsc:
481         * Scripts/build-webkit:
482         * Scripts/webkitdirs.pm:
483         (buildQMakeProjects):
484
485 2012-01-18  Ryosuke Niwa  <rniwa@webkit.org>
486
487         run-perf-tests should generate a json file that summaries the result
488         https://bugs.webkit.org/show_bug.cgi?id=76504
489
490         Reviewed by Adam Barth.
491
492         Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
493         New option --outout-json-path specifies the json file's path, and --source-json-path specifies
494         another json file to be merged into the generated json file.
495
496         Also fixed a bug that --build wasn't set by default.
497
498         * Scripts/webkitpy/layout_tests/port/test.py:
499         (TestPort.webkit_base):
500         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
501         (PerfTestsRunner.__init__):
502         (PerfTestsRunner):
503         (PerfTestsRunner._parse_args):
504         (PerfTestsRunner.run):
505         (PerfTestsRunner._generate_json_if_specified):
506         (PerfTestsRunner._process_chromium_style_test_result):
507         (PerfTestsRunner._process_parser_test_result):
508         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
509         (MainTest):
510         (create_runner):
511         (test_run_test_set):
512         (test_run_test_set_for_parser_tests):
513         (test_run_test_set_with_summary_json):
514         (test_collect_tests):
515         (test_parse_args):
516
517 2012-01-17  Sheriff Bot  <webkit.review.bot@gmail.com>
518
519         Unreviewed, rolling out r105244.
520         http://trac.webkit.org/changeset/105244
521         https://bugs.webkit.org/show_bug.cgi?id=76518
522
523         broke Chromium Mac (Requested by rolandsteiner on #webkit).
524
525         * DumpRenderTree/AccessibilityUIElement.h:
526         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
527         (AccessibilityUIElement::AccessibilityUIElement):
528         * DumpRenderTree/chromium/AccessibilityUIElement.h:
529         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
530         (AccessibilityUIElement::removeSelection):
531         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
532         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
533         (AccessibilityUIElement::removeSelection):
534
535 2012-01-17  Dominic Mazzoni  <dmazzoni@google.com>
536
537         Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
538         https://bugs.webkit.org/show_bug.cgi?id=73460
539
540         Reviewed by Chris Fleizach.
541
542         * DumpRenderTree/AccessibilityUIElement.h:
543         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
544         (AccessibilityUIElement::AccessibilityUIElement):
545         (AccessibilityUIElement::scrollToMakeVisibleCallback):
546         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
547         (AccessibilityUIElement::scrollToGlobalPointCallback):
548         * DumpRenderTree/chromium/AccessibilityUIElement.h:
549         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
550         (AccessibilityUIElement::scrollToMakeVisible):
551         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
552         (AccessibilityUIElement::scrollToGlobalPoint):
553         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
554         (AccessibilityUIElement::scrollToMakeVisible):
555         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
556         (AccessibilityUIElement::scrollToGlobalPoint):
557         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
558         (AccessibilityUIElement::scrollToMakeVisible):
559         (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
560         (AccessibilityUIElement::scrollToGlobalPoint):
561
562 2012-01-17  Adam Barth  <abarth@webkit.org>
563
564         Enable tests on the mac-ews
565         https://bugs.webkit.org/show_bug.cgi?id=76502
566
567         Reviewed by Simon Fraser.
568
569         Apple now has five machines running the mac-ews.  Lucas Forschler has
570         asked that we try enabling tests to see if we have enough bandwidth.
571
572         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
573         (MacEWS):
574
575 2012-01-17  Sanjoy Das  <sanjoy@playingwithpointers.com>
576
577         Add a check-webkit-style exception for GDBInterface.cpp
578         https://bugs.webkit.org/show_bug.cgi?id=76187
579
580         Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
581         that it does not fail the style check.
582
583         Reviewed by Martin Robinson.
584
585         * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
586         readability/naming tests on
587         Source/JavaScriptCore/jit/GDBInterface.cpp.
588         * Scripts/webkitpy/style/checker_unittest.py:
589         (GlobalVariablesTest.test_path_rules_specifier): Add a test for
590         the above exception.
591
592 2012-01-17  Hajime Morrita  <morrita@chromium.org>
593
594         https://bugs.webkit.org/show_bug.cgi?id=76245
595         [Mac][DRT] should allow query string for the file URL.
596
597         Reviewed by Tony Chang.
598
599         Taught DRT about file:// as a url instead of a file path.
600         We are now able to use a path file:///foo/bar.html?baz as a url
601         with which DRT opens "/foo/bar.html" with "baz" as a query string.
602
603         * DumpRenderTree/mac/DumpRenderTree.mm:
604         (runTest):
605
606 2012-01-17  Ojan Vafai  <ojan@chromium.org>
607
608         Check style on test_expectations.txt files before commit
609         https://bugs.webkit.org/show_bug.cgi?id=76484
610
611         Reviewed by Adam Barth.
612
613         Unlike other style rules, if you get the syntax of the test_expectations.txt
614         file wrong, the layout tests won't run. Also, this check is simple and only
615         slows down committing if you actually modify one of the test_expectations.txt files.
616
617         * Scripts/webkitpy/tool/steps/commit.py:
618         (Commit._check_test_expectations):
619         (Commit.run):
620         * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
621         (CommitTest):
622         (CommitTest.test_check_test_expectations):
623
624 2012-01-17  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
625
626         [Qt] Debug build fails with debug qt5
627         https://bugs.webkit.org/show_bug.cgi?id=76463
628
629         Reviewed by Simon Hausmann.
630
631         Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
632
633         * QtTestBrowser/cookiejar.h:
634
635 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
636
637         webkitpy: fix json import on linux
638         https://bugs.webkit.org/show_bug.cgi?id=76481
639
640         Reviewed by Adam Barth.
641
642         For some reason, the version of simplejson autoinstalled on my linux
643         box seems to be broken. We should really only be using
644         simplejson if json isn't available anyway, so this change looks
645         for json first.
646
647         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
648         (JSONGeneratorTest.test_test_timings_trie):
649
650 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
651
652         Fix failures in test-webkitpy caused by r105177.
653
654         Unreviewed, build fix.
655
656         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
657         (ChromiumLinuxPort._determine_driver_path_statically):
658         (ChromiumLinuxPort._static_build_path):
659
660 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
661
662         webkitpy: make PortFactory.get() be fully data-driven
663         https://bugs.webkit.org/show_bug.cgi?id=76360
664
665         Reviewed by Eric Seidel.
666
667         Refactor PortFactory.get() to be fully data-driven.
668
669         * Scripts/webkitpy/layout_tests/port/factory.py:
670         (PortFactory):
671         (PortFactory._default_port):
672         (PortFactory.get):
673         (PortFactory.get.in):
674         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
675         (FactoryTest.assert_port):
676
677 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
678
679         webkitpy: add determine_full_port_name(), clean up port.__init__()
680         https://bugs.webkit.org/show_bug.cgi?id=76357
681
682         Reviewed by Adam Barth.
683
684         Each Port class is now required to implement a 'port_name' field
685         that will match the start of all ports constructed by this class and
686         a 'determine_full_port_name' field that will make the port
687         fully-qualified.
688
689         * Scripts/webkitpy/layout_tests/port/apple.py:
690         (ApplePort.__init__):
691         * Scripts/webkitpy/layout_tests/port/base.py:
692         (Port):
693         (Port.determine_port_name):
694         (Port.__init__):
695         * Scripts/webkitpy/layout_tests/port/chromium.py:
696         (ChromiumPort.for):
697         (ChromiumPort.__init__):
698         (ChromiumPort):
699         (ChromiumPort._chromium_base_dir):
700         (ChromiumPort.path_from_chromium_base):
701         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
702         (ChromiumGpuLinuxPort):
703         (ChromiumGpuLinuxPort.__init__):
704         (ChromiumGpuMacPort):
705         (ChromiumGpuMacPort.__init__):
706         (ChromiumGpuWinPort):
707         (ChromiumGpuWinPort.__init__):
708         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
709         (ChromiumLinuxPort):
710         (ChromiumLinuxPort.determine_port_name):
711         (ChromiumLinuxPort.__init__):
712         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
713         (ChromiumMacPort):
714         (ChromiumMacPort.determine_port_name):
715         (ChromiumMacPort.__init__):
716         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
717         (ChromiumWinPort):
718         (ChromiumWinPort.determine_port_name):
719         (ChromiumWinPort.__init__):
720         * Scripts/webkitpy/layout_tests/port/dryrun.py:
721         (DryRunPort):
722         (DryRunPort.determine_port_name):
723         (DryRunPort.__init__):
724         * Scripts/webkitpy/layout_tests/port/efl.py:
725         (EflPort):
726         * Scripts/webkitpy/layout_tests/port/factory.py:
727         (PortFactory):
728         (PortFactory._default_port):
729         (PortFactory.get):
730         (PortFactory.get.in):
731         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
732         (FactoryTest.assert_port):
733         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
734         (GoogleChromeLinux32Port):
735         (GoogleChromeLinux32Port.determine_port_name):
736         (GoogleChromeLinux64Port):
737         (GoogleChromeLinux64Port.determine_port_name):
738         (GoogleChromeMacPort):
739         (GoogleChromeMacPort.determine_port_name):
740         (GoogleChromeWinPort):
741         (GoogleChromeWinPort.determine_port_name):
742         * Scripts/webkitpy/layout_tests/port/gtk.py:
743         (GtkPort):
744         * Scripts/webkitpy/layout_tests/port/mac.py:
745         (MacPort):
746         (MacPort.determine_port_name):
747         (MacPort.__init__):
748         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
749         (test_versions):
750         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
751         (MockDRTPort):
752         (MockDRTPort.determine_port_name):
753         (MockDRTPort.__init__):
754         (MockDRT):
755         (MockDRT.determine_port_name):
756         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
757         (PortTestCase.make_port):
758         * Scripts/webkitpy/layout_tests/port/qt.py:
759         (QtPort):
760         (QtPort.determine_port_name):
761         (QtPort.__init__):
762         * Scripts/webkitpy/layout_tests/port/test.py:
763         (TestPort):
764         (TestPort.determine_port_name):
765         (TestPort.__init__):
766         * Scripts/webkitpy/layout_tests/port/webkit.py:
767         (WebKitPort.__init__):
768         * Scripts/webkitpy/layout_tests/port/win.py:
769         (WinPort):
770         (WinPort.determine_port_name):
771         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
772         (get_test_baselines.AllPlatformsPort.__init__):
773         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
774         (get_test_config.TestMacPort):
775         (get_test_config):
776
777 2012-01-17  Dirk Pranke  <dpranke@chromium.org>
778
779         webkitpy: clean up port code in preparation for static port names
780         https://bugs.webkit.org/show_bug.cgi?id=76356
781
782         Reviewed by Adam Barth.
783
784         To fix bug 76215 and be able to determine appropriate port names
785         in webkitpy without actually constructing Port objects, we need
786         to shuffle some logic in the chromium ports to be able to figure
787         out whether we built DRT in 32 or 64-bit mode.
788
789         * Scripts/webkitpy/layout_tests/port/chromium.py:
790         (ChromiumPort):
791         (ChromiumPort._chromium_base_dir):
792         (ChromiumPort.__init__):
793         (ChromiumPort.path_from_chromium_base):
794         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
795         (ChromiumLinuxPort):
796         (ChromiumLinuxPort._determine_driver_path_statically):
797         (ChromiumLinuxPort._static_build_path):
798         (ChromiumLinuxPort._determine_architecture):
799         (ChromiumLinuxPort.__init__):
800         (ChromiumLinuxPort._build_path):
801
802 2012-01-17  Hao Zheng  <zhenghao@chromium.org>
803
804         Do not remove pixel failures for ref tests.
805         https://bugs.webkit.org/show_bug.cgi?id=76243
806
807         Reviewed by Tony Chang.
808
809         'NRWT --no-pixel-tests' complains when reftests are expected to
810         be image mismatch.
811
812         * Scripts/webkitpy/layout_tests/controllers/manager.py:
813         (Manager._update_summary_with_result):
814         * Scripts/webkitpy/layout_tests/models/test_failures.py:
815         (is_reftest_failure):
816         (determine_result_type):
817
818 2012-01-17  Balazs Ankes  <Ankes.Balazs@stud.u-szeged.hu>
819
820         REGRESSION(r81225): ORWT should ignore reftests
821         https://bugs.webkit.org/show_bug.cgi?id=67936
822
823         Reviewed by Csaba Osztrogonác.
824
825         * Scripts/old-run-webkit-tests:
826         (isUsedInReftest): $filename should be the first parameter
827         (findTestsToRun): run test if it isn't reftest
828
829 2012-01-17  Gustavo Noronha Silva  <gns@gnome.org>
830
831         Unreviewed. Fix python unit test I broke with r105142
832
833         * Scripts/webkitpy/common/config/ports_unittest.py:
834         (WebKitPortTest.test_gtk_port):
835
836 2012-01-17  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
837
838         [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
839
840         Qt 5 no longer has that flag.
841
842         Reviewed by Simon Hausmann.
843
844         * MiniBrowser/qt/MiniBrowserApplication.cpp:
845         (MiniBrowserApplication::notify):
846
847 2012-01-16  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
848
849         GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
850         https://bugs.webkit.org/show_bug.cgi?id=75857
851
852         Reviewed by Adam Barth.
853
854         * Scripts/webkitdirs.pm:
855         (buildAutotoolsProject): move cleaning the build to happen early,
856         and handle --update-gtk right after that
857         * Scripts/webkitpy/common/config/ports.py:
858         (GtkPort.build_webkit_command): pass --update-gtk as an option to
859         build-webkit, so that it is used in the EWS
860
861 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
862
863         [Qt] Don't add _debug postfix to targets when building debug only
864
865         Reviewed by Simon Hausmann.
866
867         * qmake/mkspecs/features/default_post.prf:
868         * qmake/mkspecs/features/functions.prf:
869
870 2012-01-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
871
872         [Qt] Add more files to project-files for easier navigation in Qt Creator
873
874         Reviewed by Simon Hausmann.
875
876         * Tools.pro:
877         * qmake/config.tests/README: Added.
878
879 2012-01-17  Philippe Normand  <pnormand@igalia.com>
880
881         [GTK] fast/dom/constructed-objects-prototypes.html fails
882         https://bugs.webkit.org/show_bug.cgi?id=75432
883
884         Reviewed by Martin Robinson.
885
886         * Scripts/build-webkit: Enable video-track in GTK.
887
888 2012-01-16  Takashi Toyoshima  <toyoshim@chromium.org>
889
890         Add toyoshim as a committer.
891         https://bugs.webkit.org/show_bug.cgi?id=76390
892
893         Reviewed by Hajime Morita.
894
895         * Scripts/webkitpy/common/config/committers.py:
896
897 2012-01-16  Brent Fulgham  <bfulgham@webkit.org>
898
899         [WinCairo] Build fix after r104155. Several debug targets were not
900         properly including the '*Common' property sheets.
901
902         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
903         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
904         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
905         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
906         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
907
908 2012-01-16  Csaba Osztrogonác  <ossy@webkit.org>
909
910         REGRESSION(r105072): It broke committers_unittest.py
911         https://bugs.webkit.org/show_bug.cgi?id=76396
912
913         Reviewed by Adam Barth.
914
915         * Scripts/webkitpy/common/config/committers_unittest.py:
916         (CommittersTest._assert_fuzz_match): It should handle more names.
917         (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
918
919 2012-01-16  Mario Sanchez Prada  <msanchez@igalia.com>
920
921         [GTK] Include gtk+3 in the jhbuild modules
922         https://bugs.webkit.org/show_bug.cgi?id=76284
923
924         Reviewed by Philippe Normand.
925
926         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
927
928 2012-01-16  Dan Winship  <danw@gnome.org>
929
930         Add myself as a committer
931
932         Unreviewed
933
934         * Scripts/webkitpy/common/config/committers.py:
935
936 2012-01-16  Raphael Kubo da Costa  <kubo@profusion.mobi>
937
938         Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
939
940         Some recent versions of a few Linux distributions have started passing
941         --as-needed and --no-copy-dt-needed-entries by default to the linker,
942         which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
943         needed a few symbols from libjavascriptcore_efl.so.
944
945         * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
946         before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
947         libraries are searched in the right order by the linker.
948
949 2012-01-16  Philippe Normand  <pnormand@igalia.com>
950
951         [GTK] set audio resources path in NRTW
952         https://bugs.webkit.org/show_bug.cgi?id=76380
953
954         Reviewed by Martin Robinson.
955
956         * Scripts/webkitpy/layout_tests/port/gtk.py:
957         (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
958         the uninstalled audio resources are used during webaudio tests.
959
960 2012-01-16  Carlos Garcia Campos  <cgarcia@igalia.com>
961
962         [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
963         https://bugs.webkit.org/show_bug.cgi?id=76369
964
965         Reviewed by Xan Lopez.
966
967         If there's an installed version of webkit and there are new
968         symbols in the build tree, gtkdoc-scanobj fails due to undefined
969         references, because the env ldflags are given before the local
970         ones.
971
972         * gtk/gtkdoc.py:
973         (GTKDoc._run_gtkdoc_scangobj):
974
975 2012-01-15  Pablo Flouret  <pablof@motorola.com>
976
977         Fix compilation errors on build-webkit --debug --no-video on mac.
978         https://bugs.webkit.org/show_bug.cgi?id=75867
979
980         Reviewed by Philippe Normand.
981
982         Add --[no-]video-track to build-webkit, since video track feature
983         depends on video.
984
985         * Scripts/build-webkit:
986
987 2012-01-14  James Robinson  <jamesr@chromium.org>
988
989         [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
990         https://bugs.webkit.org/show_bug.cgi?id=76313
991
992         Reviewed by Adam Barth.
993
994         The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
995
996         * Scripts/run-chromium-webkit-unit-tests:
997
998 2012-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
999
1000         Unreviewed, rolling out r105017.
1001         http://trac.webkit.org/changeset/105017
1002         https://bugs.webkit.org/show_bug.cgi?id=76333
1003
1004         broke the build (Requested by philn-tp on #webkit).
1005
1006         * gtk/jhbuild.modules:
1007
1008 2012-01-14  Mario Sanchez Prada  <msanchez@igalia.com>
1009
1010         [GTK] Include gtk+3 in the jhbuild modules
1011         https://bugs.webkit.org/show_bug.cgi?id=76284
1012
1013         Reviewed by Philippe Normand.
1014
1015         * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
1016
1017 2012-01-13  Adam Barth  <abarth@webkit.org>
1018
1019         Remove --dry-run support from webkit-patch
1020         https://bugs.webkit.org/show_bug.cgi?id=76300
1021
1022         Reviewed by Dirk Pranke.
1023
1024         This is the rest of the patch from Bug 76300.  I landed it separtely
1025         because main.py had some stray conflict markers that I needed to clean
1026         up first.
1027
1028         * Scripts/webkitpy/test/main.py:
1029         (Tester.parse_args):
1030         (Tester._run_tests):
1031
1032 2012-01-13  Adam Barth  <abarth@webkit.org>
1033
1034         test-webkitpy does not run
1035         https://bugs.webkit.org/show_bug.cgi?id=76318
1036
1037         Unreviewed.
1038
1039         Looks like some conflict markers got left in the file.
1040
1041         * Scripts/webkitpy/test/main.py:
1042         (Tester.run):
1043
1044 2012-01-13  Adam Barth  <abarth@webkit.org>
1045
1046         Remove --dry-run support from webkit-patch
1047         https://bugs.webkit.org/show_bug.cgi?id=76300
1048
1049         Reviewed by Dirk Pranke.
1050
1051         We don't use this functionality for anything, and it doesn't really
1052         work.  Someone in #webkit tried using it and and got sad/confused.  We
1053         should just remove it.
1054
1055         * Scripts/webkitpy/common/checkout/scm/git.py:
1056         (Git.push_local_commits_to_server):
1057         * Scripts/webkitpy/common/checkout/scm/scm.py:
1058         (SCM.__init__):
1059         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1060         (_shared_test_commit_with_message):
1061         (GitSVNTest.test_commit_text_parsing):
1062         * Scripts/webkitpy/common/checkout/scm/svn.py:
1063         (SVN.commit_with_message):
1064         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1065         (Bugzilla.__init__):
1066         (Bugzilla.quips):
1067         (Bugzilla.authenticate):
1068         (Bugzilla.add_attachment_to_bug):
1069         (Bugzilla.add_patch_to_bug):
1070         (Bugzilla.create_bug):
1071         (Bugzilla.clear_attachment_flags):
1072         (Bugzilla.set_flag_on_attachment):
1073         (Bugzilla.obsolete_attachment):
1074         (Bugzilla.add_cc_to_bug):
1075         (Bugzilla.post_comment_to_bug):
1076         (Bugzilla.close_bug_as_fixed):
1077         (Bugzilla.reassign_bug):
1078         (reopen_bug):
1079         * Scripts/webkitpy/test/main.py:
1080         (Tester.parse_args):
1081         (Tester.run_tests):
1082
1083 2012-01-13  David Levin  <levin@chromium.org>
1084
1085         check-webkit-style: should encourage the use of Own* classes for Windows DC.
1086         https://bugs.webkit.org/show_bug.cgi?id=76227
1087
1088         Reviewed by Dirk Pranke.
1089
1090         * Scripts/webkitpy/style/checkers/cpp.py:
1091         (check_for_leaky_patterns): The new check.
1092         (process_line): Added a call to the new check.
1093         (CppChecker): Added the new error type.
1094         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1095         (CppStyleTestBase):
1096         (CppStyleTestBase.perform_leaky_pattern_check):
1097         The check for only leaky pattern errors.
1098         (LeakyPatternTest): Test cases.
1099
1100 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1101
1102         test-webkitpy: clean up handling of test directories, QueueStatusServer
1103         https://bugs.webkit.org/show_bug.cgi?id=76238
1104
1105         Reviewed by Adam Barth.
1106
1107         This patch cleans up a bunch of hacks related to how we find all
1108         of the python unit tests and set up the sys.path variable in
1109         test-webkitpy.
1110
1111         This patch changes how test-webkitpy works slightly in that we
1112         will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
1113         rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
1114         This greatly simplifies the mapping of paths to module names and
1115         appears to have no significant performance impact or other drawbacks.
1116
1117         There are other ways that we could remove all of the hacks and
1118         still have a more flexible mapping of paths to module names, but
1119         the ones I've thought of so far add a decent amount of complexity to
1120         the implementation and don't seem to buy us much.
1121         
1122         * QueueStatusServer/__init__.py:
1123         * Scripts/test-webkitpy:
1124         * Scripts/webkitpy/test/main.py:
1125         (Tester._modules_from_paths):
1126         (Tester._is_module):
1127
1128 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1129
1130         test-webkitpy: should support classes and individual test names as well as modules
1131         https://bugs.webkit.org/show_bug.cgi?id=76233
1132
1133         Reviewed by Adam Barth.
1134
1135         The default unittest.main() supports a list of individual
1136         TestCase classes or individual tests as well as modules. This
1137         change adds support for the same to test-webkitpy, so now you
1138         can say
1139
1140           % test-wekbitpy webkitpy.test.cat_unittest.CatTest
1141
1142         and
1143
1144           % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
1145
1146         in addition to
1147
1148           % test-wekbitpy webkitpy.test.cat_unittest
1149
1150         * Scripts/test-webkitpy:
1151         * Scripts/webkitpy/test/cat_unittest.py:
1152         * Scripts/webkitpy/test/main.py:
1153         (Tester.parse_args):
1154         (Tester.run):
1155         (Tester):
1156         (Tester._find_modules):
1157         (Tester._exclude):
1158         (Tester._run_tests):
1159         (Tester._is_module):
1160         (Tester._log_exception):
1161
1162 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1163
1164         test-webkitpy: add basic code coverage support
1165         https://bugs.webkit.org/show_bug.cgi?id=76201
1166
1167         Reviewed by Adam Barth.
1168
1169         This test adds basic code coverage support to test-webkitpy; if
1170         you pass the -c flag, we will generate a new coverage file. We
1171         can start simply with this and add more features as necessary.
1172
1173         This patch requires coverage to be already installed on the
1174         machine. I am not auto-installing this for now.
1175
1176         * Scripts/webkitpy/test/main.py:
1177         (Tester.parse_args):
1178         (Tester.run_tests):
1179
1180 2012-01-13  Dirk Pranke  <dpranke@chromium.org>
1181
1182         StatusBubbleTest.test_build_bubble is failing
1183         https://bugs.webkit.org/show_bug.cgi?id=76222
1184
1185         Reviewed by Adam Barth.
1186
1187         * QueueStatusServer/handlers/statusbubble_unittest.py:
1188         (StatusBubbleTest.test_build_bubble):
1189
1190 2012-01-13  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
1191
1192         nrwt should use multiple http shards
1193         https://bugs.webkit.org/show_bug.cgi?id=75958
1194
1195         Add --max-locked-shards option to the nrwt for manual set
1196         the maximum number of the locked shards
1197
1198         Reviewed by Dirk Pranke.
1199
1200         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1201         (Manager._max_locked_shards):
1202         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1203         (ShardingTests.get_shards):
1204         (ShardingTests.test_multiple_locked_shards):
1205         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1206         (parse_args):
1207
1208 2012-01-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
1209
1210         prepare-ChangeLog: Look for a text editor in a few more variables.
1211         https://bugs.webkit.org/show_bug.cgi?id=76289
1212
1213         Reviewed by Ryosuke Niwa.
1214
1215         A text editor was looked for only in the CHANGE_LOG_EDITOR and
1216         CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
1217         to the OS X-specific open(1) command.
1218
1219         As there does not seem to be a common way of looking for a text editor
1220         among the scripts in Tools/Scripts right now, just look at $VISUAL and
1221         $EDITOR (set much more often than the other variables in Unix systems)
1222         before falling back to open(1).
1223
1224         * Scripts/prepare-ChangeLog:
1225         (openChangeLogs):
1226
1227 2012-01-13  Gabor Rapcsanyi  <rgabor@webkit.org>
1228
1229         [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
1230         https://bugs.webkit.org/show_bug.cgi?id=76269
1231
1232         Reviewed by Martin Robinson.
1233
1234         * gtk/gtkdoc.py:
1235         (GTKDoc._run_gtkdoc_scangobj):
1236
1237 2012-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1238
1239         [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
1240         https://bugs.webkit.org/show_bug.cgi?id=76247
1241
1242         Reviewed by Kenneth Rohde Christiansen.
1243
1244         * WebKitTestRunner/TestController.cpp:
1245         (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
1246
1247 2012-01-13  Hajime Morrita  <morrita@chromium.org>
1248
1249         [Mac][DRT] Should support --no-timeout
1250         https://bugs.webkit.org/show_bug.cgi?id=76242
1251
1252         Reviewed by Darin Adler.
1253
1254         * DumpRenderTree/mac/DumpRenderTree.mm:
1255         (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
1256         (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
1257         (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
1258         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1259         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1260         (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
1261
1262 2012-01-12  Simon Fraser  <simon.fraser@apple.com>
1263
1264         Mitigate scrollbar differences when running pixel tests
1265         https://bugs.webkit.org/show_bug.cgi?id=67217
1266
1267         Reviewed by Dan Bernstein.
1268         
1269         Enable mock scrollbars by default for tests.
1270
1271         * DumpRenderTree/mac/DumpRenderTree.mm:
1272         (resetDefaultsToConsistentValues):
1273         * WebKitTestRunner/TestController.cpp:
1274         (WTR::TestController::resetStateToConsistentValues):
1275
1276 2012-01-12  Ryosuke Niwa  <rniwa@webkit.org>
1277
1278         Need a script to run tests in PerformanceTests
1279         https://bugs.webkit.org/show_bug.cgi?id=76132
1280
1281         Reviewed by Adam Barth.
1282
1283         Add run-perf-tests to run performance tests using parser/resources/runner.js.
1284         Unfortunately, there isn't an easy way of telling which test uses which format
1285         so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
1286
1287         All test outputs are re-formatted to match Chromium perf-bot style.
1288
1289         * Scripts/run-inspector-perf-tests.py:
1290         * Scripts/run-perf-tests: Added.
1291         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1292         (PerfTestsRunner):
1293         (PerfTestsRunner.__init__):
1294         (PerfTestsRunner._collect_tests):
1295         (PerfTestsRunner.run):
1296         (PerfTestsRunner._print_status):
1297         (PerfTestsRunner._run_tests_set):
1298         (PerfTestsRunner._process_chromium_style_test_result):
1299         (PerfTestsRunner._should_ignore_line_in_parser_test_result):
1300         (PerfTestsRunner._process_parser_test_result):
1301         (PerfTestsRunner._run_single_test):
1302         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1303         (MainTest.TestDriver.run_test):
1304         (create_runner):
1305         (run_test):
1306         (test_run_test_set):
1307         (test_run_test_set_for_parser_tests):
1308         (test_collect_tests):
1309
1310 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1311
1312         webkitpy: clean up port unit tests in preparation for making port_name mandatory
1313         https://bugs.webkit.org/show_bug.cgi?id=76123
1314
1315         Reviewed by Adam Barth.
1316
1317         This change updates the unit tests to be more consistent in how
1318         ports are created, in preparation for making port_name a
1319         mandatory parameter to the constructor and removing any version
1320         interpretation from it.
1321
1322         There should be no functional changes in this patch, but some
1323         tests that are no longer relevant have been removed or reworked.
1324
1325         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1326         (PortTest.test_get_option__default):
1327         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1328         (ChromiumLinuxPortTest):
1329         (ChromiumLinuxPortTest.assert_architecture):
1330         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1331         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1332         (ChromiumMacPortTest):
1333         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1334         (ChromiumPortTest):
1335         (ChromiumPortTest.test_all_test_configurations):
1336         (ChromiumPortTest.TestMacPort.__init__):
1337         (ChromiumPortTest.TestLinuxPort.__init__):
1338         (ChromiumPortTest.TestWinPort.__init__):
1339         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1340         (ChromiumWinTest):
1341         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1342         (EflPortTest):
1343         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1344         (GtkPortTest):
1345         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1346         (MacTest):
1347         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1348         (MockDRTPortTest):
1349         (MockDRTPortTest.make_port):
1350         * Scripts/webkitpy/layout_tests/port/qt.py:
1351         (QtPort._port_flag_for_scripts):
1352         (QtPort.__init__):
1353         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1354         (QtPortTest):
1355         (QtPortTest._assert_search_path):
1356         (QtPortTest.test_baseline_search_path):
1357         (QtPortTest.test_operating_system):
1358         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1359         (WebKitPortTest):
1360         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1361         (WinPortTest):
1362         (WinPortTest._assert_search_path):
1363         (WinPortTest.test_baseline_search_path):
1364         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1365         (get_test_config.TestMacPort.__init__):
1366
1367 2012-01-12  Dirk Pranke  <dpranke@chromium.org>
1368
1369         test-webkitpy: clean up logging and provide a real --help message
1370         https://bugs.webkit.org/show_bug.cgi?id=76142
1371
1372         Reviewed by Adam Barth.
1373
1374         This test is mostly more refactoring - it calls objects in
1375         unittest directly instead of routing through unittest.main() --
1376         in order to gain more control over the logging and to provide a
1377         correct --help message. This will also give us a better
1378         foundation for adding more feautures down the road.
1379
1380         This patch adds different levels of logging controlled by the
1381         '-s', '-q', and '-v' options (see --help for details), and
1382         removes the --verbose-logging option.
1383
1384         * Scripts/test-webkitpy:
1385         * Scripts/webkitpy/test/main.py:
1386         (Tester):
1387         (Tester.clean_packages):
1388         (Tester.__init__):
1389         (Tester.parse_args):
1390         (Tester.configure):
1391         (Tester._configure_logging):
1392         (Tester.find_modules):
1393         (Tester._exclude):
1394         (Tester._modules_from_paths):
1395         (Tester.run_tests):
1396
1397 2012-01-12  Simon Hausmann  <simon.hausmann@nokia.com>
1398
1399         Make the new WTF module build on Qt
1400         https://bugs.webkit.org/show_bug.cgi?id=76163
1401
1402         Reviewed by Tor Arne Vestbø.
1403
1404         * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
1405
1406 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1407
1408         Unreviewed, mac DumpRenderTree fix.
1409
1410         * DumpRenderTree/mac/UIDelegate.mm:
1411         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1412
1413 2012-01-12  Vsevolod Vlasov  <vsevik@chromium.org>
1414
1415         WebKitTestRunner should not print console message line number when it is equal to zero.
1416         https://bugs.webkit.org/show_bug.cgi?id=76167
1417
1418         Reviewed by Csaba Osztrogonác.
1419
1420         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1421         (WTR::InjectedBundlePage::willAddMessageToConsole):
1422
1423 2012-01-11  Vsevolod Vlasov  <vsevik@chromium.org>
1424
1425         Make default console messages line numbers consistent.
1426         https://bugs.webkit.org/show_bug.cgi?id=74075
1427
1428         Reviewed by Pavel Feldman.
1429
1430         Unset line numbers are not printed to console now.
1431         Added Source/WebCore/inspector to efl DumpRenderTree include path.
1432
1433         * DumpRenderTree/chromium/WebViewHost.cpp:
1434         (WebViewHost::didAddMessageToConsole):
1435         * DumpRenderTree/efl/CMakeLists.txt:
1436         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
1437         (onConsoleMessage):
1438         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1439         (webViewConsoleMessage):
1440         * DumpRenderTree/mac/UIDelegate.mm:
1441         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1442         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1443         (WebCore::WebPage::javaScriptConsoleMessage):
1444         * DumpRenderTree/win/UIDelegate.cpp:
1445         (UIDelegate::webViewAddMessageToConsole):
1446         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
1447         (LayoutWebViewEventHandler::OnConsoleMessageEvent):
1448
1449 2012-01-10  Dirk Pranke  <dpranke@chromium.org>
1450
1451         test-webkitpy: push more logic into webkitpy.test.main, clean up code
1452         https://bugs.webkit.org/show_bug.cgi?id=76021
1453
1454         Reviewed by Eric Seidel.
1455
1456         I plan to add more functionality to test-webkitpy, but it is
1457         difficult to hack on now; this patch is the first of two that
1458         brings test-webkitpy more inline with current coding style by
1459         pushing more logic into the webkitpy.test.main.Tester class (so
1460         that it will be testable itself).
1461         
1462         There should be no functional changes in this patch.
1463
1464         * Scripts/test-webkitpy:
1465         (_path_from_webkit_root):
1466         * Scripts/webkitpy/test/main.py:
1467         (Tester):
1468         (Tester.init):
1469         (Tester.configure_logging):
1470         (Tester.configure_logging.filter):
1471         (Tester.clean_packages):
1472         (Tester.run_tests):
1473
1474 2012-01-11  Wei Jia  <wjia@chromium.org>
1475
1476         implement layout tests for <video> with media stream
1477         https://bugs.webkit.org/show_bug.cgi?id=74882
1478
1479         Reviewed by Kent Tamura.
1480
1481         * DumpRenderTree/DumpRenderTree.gypi:
1482         * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
1483         (WebKit::WebUserMediaClientMock::create):
1484         (WebKit::WebUserMediaClientMock::IsMockStream):
1485         (WebKit::WebUserMediaClientMock::requestUserMedia):
1486         (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
1487         * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
1488         (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
1489         (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
1490         * DumpRenderTree/chromium/WebViewHost.cpp:
1491         (WebViewHost::userMediaClient):
1492         (WebViewHost::userMediaClientMock):
1493         (WebViewHost::createMediaPlayer):
1494         (WebViewHost::mediaStreamUtil):
1495         (WebViewHost::testMediaStreamClient):
1496         * DumpRenderTree/chromium/WebViewHost.h:
1497
1498 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1499
1500         Unreviewed, build fix.
1501
1502         Fix chromium-win's version remapping to work correctly on Win 7 SP1.
1503
1504         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1505         (ChromiumWinPort.__init__):
1506
1507 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1508
1509         Sheriffbot build fix. Don't emit empty lines on IRC.
1510
1511         * Scripts/webkitpy/tool/bot/irc_command.py:
1512         (LastGreenRevision.execute):
1513
1514 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1515
1516         last-green-revision should report the revision that succeeded on all bots
1517         https://bugs.webkit.org/show_bug.cgi?id=76109
1518
1519         Reviewed by Adam Barth.
1520
1521         Add an algorithm to find the last known good revision among the specified bots. For a revision to be
1522         considered green by this algorithm, all matching builders must have a successful run at the revision
1523         or two consecutive successful runs before and after the revision.
1524
1525         Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
1526         that resulted in an exception when the user didn't pass BUILDER_NAME argument.
1527
1528         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1529         (BuildBot._revisions_for_builder):
1530         (BuildBot):
1531         (BuildBot._find_green_revision):
1532         (BuildBot.last_green_revision):
1533         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1534         (MockBuildBot.last_green_revision):
1535         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1536         (test_revisions_for_builder):
1537         (test_find_green_revision):
1538         (test_last_green_revision):
1539         * Scripts/webkitpy/tool/bot/irc_command.py:
1540         (LastGreenRevision.execute):
1541         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
1542         (SheriffIRCBotTest.test_lgr):
1543         * Scripts/webkitpy/tool/commands/queries.py:
1544         (LastGreenRevision):
1545
1546 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1547
1548         Unreviewed, fix build bustage on win32 introduced by r104725.
1549
1550         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1551         (MockDRTPortTest.make_port):
1552         (MockChromiumDRTTest.test_pixeltest__fails):
1553
1554 2012-01-11  Jochen Eisinger  <jochen@chromium.org>
1555
1556         [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
1557         https://bugs.webkit.org/show_bug.cgi?id=75618
1558
1559         Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
1560
1561         Reviewed by Tony Chang.
1562
1563         * DumpRenderTree/chromium/LayoutTestHelper.mm:
1564         (installLayoutTestColorProfile):
1565         (restoreUserColorProfile):
1566         (main):
1567
1568 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1569
1570         test-webkitpy: fix -v and eliminate some spurious warnings
1571         https://bugs.webkit.org/show_bug.cgi?id=76099
1572
1573         Reviewed by Adam Barth.
1574
1575         when we added support for --xml output, we broke the -v flag.
1576
1577         Also, fix the code to swallow a harmless warning from
1578         VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
1579
1580         test-webkitpy is now silent again except for the one known
1581         logging issue.
1582
1583         * Scripts/webkitpy/common/checkout/checkout.py:
1584         (Checkout.commit_message_for_this_commit):
1585         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1586         (test_commit_message_for_this_commit):
1587         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1588         (JSONChecker.check):
1589         (JSONChecker.line_number_from_json_exception):
1590         * Scripts/webkitpy/test/main.py:
1591         (Tester.run_tests):
1592
1593 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1594
1595         webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
1596         https://bugs.webkit.org/show_bug.cgi?id=76084
1597
1598         Reviewed by Adam Barth.
1599
1600         This will help make it easier to catch layering violations. This
1601         change just refactors test code; there are no changes to
1602         production code.
1603
1604         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1605         (PortTest.make_port):
1606         (PortTest.test_find_no_paths_specified):
1607         (PortTest.test_find_one_test):
1608         (PortTest.test_find_glob):
1609         (PortTest.test_find_with_skipped_directories):
1610         (PortTest.test_find_with_skipped_directories_2):
1611         (PortTest.test_parse_reftest_list):
1612         (PortTest.test_httpd_returns_error_code):
1613         (PortTest.test_virtual_methods):
1614         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
1615         (ChromiumGpuTest.assert_port_works):
1616         (ChromiumGpuTest._assert_baseline_path):
1617         (ChromiumGpuTest.test_graphics_type):
1618         (ChromiumGpuTest.test_default_tests_paths.test_paths):
1619         (ChromiumGpuTest.test_test_files):
1620         (ChromiumGpuTest.test_test_files.test_paths):
1621         (ChromiumGpuTest):
1622         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
1623         (ChromiumLinuxPortTest.assert_architecture):
1624         (ChromiumLinuxPortTest.test_check_illegal_port_names):
1625         (ChromiumLinuxPortTest.test_determine_architecture_fails):
1626         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
1627         (DriverTest.make_port):
1628         (DriverTest):
1629         (DriverTest.assertVirtual):
1630         (DriverTest._assert_wrapper):
1631         (DriverTest.test_virtual_driver_methods):
1632         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1633         (MockDRTPortTest.make_port):
1634         (MockDRTPortTest.test_port_name_in_constructor):
1635         (MockDRTTest.assertTest):
1636         (MockDRTTest.test_main):
1637         (MockChromiumDRTTest.test_pixeltest__fails):
1638         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1639         (QtPortTest._assert_search_path):
1640         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1641         (TestWebKitPort.__init__):
1642         (WebKitPortUnitTests.test_default_options):
1643         (test_runtime_feature_list):
1644         (test_test_expectations):
1645
1646 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1647
1648         Style skipped tests in the flakiness dashboard
1649         https://bugs.webkit.org/show_bug.cgi?id=76091
1650
1651         Reviewed by Tony Chang.
1652
1653         * TestResultServer/static-dashboards/dashboard_base.js:
1654         Removed "FLAKY" from this list since we don't ever mark individual runs
1655         as flaky. Also deleted an outdated line.
1656         * TestResultServer/static-dashboards/flakiness_dashboard.html:
1657
1658 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1659
1660         Remove gtest normalization code from the test results server
1661         https://bugs.webkit.org/show_bug.cgi?id=76089
1662
1663         Reviewed by Tony Chang.
1664
1665         The normalization now happens on the gtest side.
1666
1667         * TestResultServer/model/jsonresults.py:
1668         (JsonResults.merge):
1669         * TestResultServer/model/jsonresults_unittest.py:
1670         (JsonResultsTest.test_gtest):
1671
1672 2012-01-11  Ojan Vafai  <ojan@chromium.org>
1673
1674         Be more aggressive about deleting unnecessary results from the test-results-server json files
1675         https://bugs.webkit.org/show_bug.cgi?id=76086
1676
1677         Reviewed by Tony Chang.
1678
1679         Remove any tests that only contain skip/pass/nodata values whose runtime
1680         is less than 5 seconds.
1681
1682         * TestResultServer/model/jsonresults.py:
1683         (JsonResults._normalize_results_json):
1684         * TestResultServer/model/jsonresults_unittest.py:
1685         (JsonResultsTest.test_merge_remove_test):
1686         (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
1687
1688 2012-01-11  Ryosuke Niwa  <rniwa@webkit.org>
1689
1690         last-green-revision should give us per-bot information
1691         https://bugs.webkit.org/show_bug.cgi?id=76011
1692
1693         Reviewed by Adam Barth.
1694
1695         Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
1696         we report the latest green run on each bot from the last 100 runs.
1697
1698         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1699         (BuildBot._fetch_builder_page):
1700         (BuildBot):
1701         (BuildBot._green_revision_for_builder):
1702         (BuildBot.last_green_revision):
1703         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1704         (test_green_revision_for_builder):
1705         (test_last_green_revision):
1706         * Scripts/webkitpy/tool/bot/irc_command.py:
1707         (LastGreenRevision.execute):
1708         * Scripts/webkitpy/tool/commands/queries.py:
1709         (LastGreenRevision.execute):
1710
1711 2012-01-11  Dirk Pranke  <dpranke@chromium.org>
1712
1713         webkitpy: clean up version detection in webkitpy.layout_tests.port
1714         https://bugs.webkit.org/show_bug.cgi?id=76016
1715
1716         Reviewed by Adam Barth.
1717
1718         This change updates the code in webkitpy.layout_tests.port to
1719         use the new os_name and os_version fields on host.platform. This
1720         gets layout_tests.port out of the version parsing business. Most
1721         of the diffs are just cleaning up test code to accomodate the
1722         changes.
1723
1724         * Scripts/webkitpy/common/system/executive_mock.py:
1725         (MockExecutive):
1726         (MockExecutive.ignore_error):
1727         (MockExecutive2):
1728         (MockExecutive2.ignore_error):
1729         * Scripts/webkitpy/common/system/platforminfo_mock.py:
1730         (MockPlatformInfo.is_mac):
1731         (MockPlatformInfo.is_linux):
1732         (MockPlatformInfo.is_win):
1733         * Scripts/webkitpy/common/system/systemhost_mock.py:
1734         (MockSystemHost.__init__):
1735         * Scripts/webkitpy/layout_tests/port/apple.py:
1736         (ApplePort.__init__):
1737         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1738         (ChromiumMacPort.__init__):
1739         (ChromiumMacPort.check_wdiff):
1740         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
1741         (ChromiumMacPortTest):
1742         (ChromiumMacPortTest.assert_name):
1743         (ChromiumMacPortTest.test_versions):
1744         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1745         (ChromiumPortTest.test_all_test_configurations):
1746         (ChromiumPortTest.TestMacPort.__init__):
1747         (ChromiumPortTest.TestLinuxPort.__init__):
1748         (ChromiumPortTest.TestWinPort.__init__):
1749         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1750         (ChromiumWinPort.__init__):
1751         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1752         (ChromiumWinTest):
1753         (ChromiumWinTest.assert_name):
1754         (ChromiumWinTest.test_versions):
1755         (ChromiumWinTest.test_baseline_path):
1756         (ChromiumWinTest.test_build_path):
1757         * Scripts/webkitpy/layout_tests/port/factory.py:
1758         (PortFactory._port_name_from_arguments_and_options):
1759         (PortFactory.get):
1760         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1761         (FactoryTest):
1762         (FactoryTest.setUp):
1763         (FactoryTest.assert_port):
1764         (FactoryTest.test_mac):
1765         (FactoryTest.test_win):
1766         (FactoryTest.test_google_chrome):
1767         (FactoryTest.test_gtk):
1768         (FactoryTest.test_qt):
1769         (FactoryTest.test_chromium_gpu):
1770         (FactoryTest.test_chromium_gpu_linux):
1771         (FactoryTest.test_chromium_gpu_mac):
1772         (FactoryTest.test_chromium_gpu_win):
1773         (FactoryTest.test_chromium_mac):
1774         (FactoryTest.test_chromium_linux):
1775         (FactoryTest.test_chromium_win):
1776         (FactoryTest.test_unknown_specified):
1777         (FactoryTest.test_unknown_default):
1778         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1779         (TestGoogleChromePort):
1780         (TestGoogleChromePort._verify_baseline_path):
1781         (TestGoogleChromePort._verify_expectations_overrides):
1782         (TestGoogleChromePort.test_get_google_chrome_port):
1783         * Scripts/webkitpy/layout_tests/port/mac.py:
1784         (MacPort):
1785         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
1786         (MacTest):
1787         (assert_name):
1788         (test_tests_for_other_platforms):
1789         (test_version):
1790         (test_versions):
1791         (test_is_version_methods):
1792         (test_setup_environ_for_server):
1793         (_assert_search_path):
1794         (test_show_results_html_file):
1795         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1796         (PortTestCase):
1797         (PortTestCase.make_port):
1798         * Scripts/webkitpy/layout_tests/port/win.py:
1799         (WinPort):
1800         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1801         (WinPortTest):
1802         (WinPortTest.test_show_results_html_file):
1803         (WinPortTest._assert_search_path):
1804         (WinPortTest._assert_version):
1805
1806 2012-01-11  Hugo Parente Lima  <hugo.lima@openbossa.org>
1807
1808         [Qt][WK2] Remove workaround introduced into bug 75470
1809         https://bugs.webkit.org/show_bug.cgi?id=75889
1810
1811         Reviewed by Tor Arne Vestbø.
1812
1813         * MiniBrowser/qt/qml/BrowserWindow.qml:
1814
1815 2012-01-10  Dmitry Lomov  <dslomov@google.com>
1816
1817         [Chromium] Remove obsolete references to WebWorker class.
1818         https://bugs.webkit.org/show_bug.cgi?id=76020
1819
1820         Reviewed by David Levin.
1821
1822         * DumpRenderTree/chromium/TestWebWorker.h: Removed.
1823         * DumpRenderTree/chromium/WebViewHost.cpp:
1824         * DumpRenderTree/chromium/WebViewHost.h:
1825
1826 2012-01-11  Csaba Osztrogonác  <ossy@webkit.org>
1827
1828         [Qt] Some css3 filter tests are failing after r104698
1829         https://bugs.webkit.org/show_bug.cgi?id=76055
1830
1831         Reviewed by Simon Hausmann.
1832
1833         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1834         (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
1835
1836 2012-01-11  Tony Chang  <tony@chromium.org>
1837
1838         Don't remove 0 byte files when running build-webkit --chromium
1839         https://bugs.webkit.org/show_bug.cgi?id=75997
1840
1841         Reviewed by Csaba Osztrogonác.
1842
1843         If QTDIR is set, isQt() is true even when running build-webkit --chromium.
1844
1845         * Scripts/webkitdirs.pm:
1846         (determineIsQt):
1847
1848 2012-01-10  David Kilzer  <ddkilzer@apple.com>
1849
1850         Add TestWebKitAPI tests for KURL
1851         <http://webkit.org/b/75774>
1852
1853         Reviewed by Adam Barth.
1854
1855         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
1856         WebCore folder and KURL.cpp source file to the project.
1857         * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
1858         (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
1859         during setup since this test doesn't go through WebKit or
1860         WebKit2.
1861         (TestWebKitAPI::TEST_F): Add two basic tests.
1862
1863 2012-01-10  David Kilzer  <ddkilzer@apple.com>
1864
1865         Extract common code for comparing WTF::String objects into WTFStringUtilities.h
1866
1867         Reviewed by Adam Barth.
1868
1869         Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
1870
1871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
1872         WTFStringUtilities.h to the project.
1873         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
1874         WTFStringUtilities.h.
1875         * TestWebKitAPI/WTFStringUtilities.h: Added.
1876         (WTF::operator<<):
1877
1878 2012-01-10  Vincent Scheib  <scheib@chromium.org>
1879
1880         Clarify run-webkit-tests options reset-results and new-baseline
1881         https://bugs.webkit.org/show_bug.cgi?id=75993
1882
1883         Reviewed by Dirk Pranke.
1884
1885         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1886         (parse_args):
1887
1888 2012-01-10  Simon Fraser  <simon.fraser@apple.com>
1889
1890         Disabled mock scrollbars should draw differently
1891         https://bugs.webkit.org/show_bug.cgi?id=75995
1892
1893         Reviewed by James Robinson.
1894
1895         When the scrollbar is disabled, paint the entire track of
1896         mock scrollbars with a lighter gray, and hide the thumb.
1897
1898         * DumpRenderTree/mac/DumpRenderTree.mm:
1899         (-[DRTMockScroller drawKnob]):
1900         (-[DRTMockScroller drawRect:]):
1901
1902 2012-01-10  James Robinson  <jamesr@chromium.org>
1903
1904         [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
1905         https://bugs.webkit.org/show_bug.cgi?id=75988
1906
1907         Reviewed by Adam Barth.
1908
1909         * Scripts/webkitpy/common/config/ports.py:
1910         (WebKitPort.run_webkit_unit_tests_command):
1911         (WebKitPort):
1912         (ChromiumPort.run_webkit_unit_tests_command):
1913         (ChromiumPort):
1914         * Scripts/webkitpy/common/config/ports_mock.py:
1915         (MockPort.run_webkit_unit_tests_command):
1916         * Scripts/webkitpy/tool/commands/download_unittest.py:
1917         (DownloadCommandsTest.test_build_and_test):
1918         (test_land):
1919         (test_land_red_builders):
1920         * Scripts/webkitpy/tool/steps/runtests.py:
1921         (RunTests.run):
1922         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1923
1924 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
1925
1926         webkitpy: add os_name, os_version to platforminfo
1927         https://bugs.webkit.org/show_bug.cgi?id=75931
1928
1929         Reviewed by Eric Siedel.
1930
1931         As a first step in cleaning up the version parsing logic in
1932         webkitpy.layout_tests.port, this adds common routines for
1933         getting the os_name and os_version fields to the PlatformInfo
1934         class. Nothing uses them yet but I've added FIXME's to some of
1935         the code that needs to be deleted in the port files.
1936
1937         * Scripts/webkitpy/common/system/platforminfo.py:
1938         (PlatformInfo.__init__):
1939         (PlatformInfo):
1940         (PlatformInfo._determine_os_name):
1941         (PlatformInfo._determine_mac_version):
1942         (PlatformInfo._determine_linux_version):
1943         (PlatformInfo._determine_win_version):
1944         (PlatformInfo.display_name):
1945         (PlatformInfo.total_bytes_memory):
1946         (PlatformInfo._compute_bytes_from_vm_stat_output):
1947         (PlatformInfo.free_bytes_memory):
1948         * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
1949         (TestPlatformInfo):
1950         (TestPlatformInfo.make_info):
1951         (TestPlatformInfo.make_info.mock_run_command):
1952         (TestPlatformInfo.setUp):
1953         (TestPlatformInfo.tearDown):
1954         (TestPlatformInfo.test_basic):
1955         (TestPlatformInfo.integration_test_basic):
1956         (TestPlatformInfo.test_display_name_mac):
1957         (TestPlatformInfo.test_display_name_win32):
1958         (TestPlatformInfo.test_memory_mac):
1959         (TestPlatformInfo.test_memory_win32):
1960         (TestPlatformInfo.test_determine_os_name):
1961         (TestPlatformInfo.test_determine_mac_version):
1962         (TestPlatformInfo.test_determine_linux_version):
1963         (TestPlatformInfo.test_determine_win_version_from_tuple):
1964         (TestPlatformInfo.test_determine_win_version_from_cmd):
1965         * Scripts/webkitpy/layout_tests/port/apple.py:
1966         (ApplePort.__init__):
1967         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1968         (ChromiumMacPort.__init__):
1969         * Scripts/webkitpy/layout_tests/port/mac.py:
1970         (MacPort):
1971         * Scripts/webkitpy/layout_tests/port/win.py:
1972         (WinPort):
1973
1974 2012-01-10  Adam Roben  <aroben@apple.com>
1975
1976         Make it possible to type data: URLs into MiniBrowser on Windows
1977
1978         Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
1979         MiniBrowser on Windows
1980
1981         Reviewed by Darin Adler.
1982
1983         * MiniBrowser/win/BrowserWindow.cpp:
1984         (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
1985         whether to prepend "http://", just look for whether the typed URL contains a colon. If it
1986         does, we assume it already has a scheme and don't modify it.
1987
1988 2012-01-10  Adam Roben  <aroben@apple.com>
1989
1990         Make MiniBrowser automatically escape invalid URL characters typed in its URL field
1991
1992         Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
1993         MiniBrowser on Windows
1994
1995         Reviewed by Darin Adler.
1996
1997         * MiniBrowser/win/BrowserView.cpp:
1998         (BrowserView::goToURL): Pass the typed string through
1999         CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
2000
2001 2012-01-10  Ben Wells  <benwells@chromium.org>
2002
2003         Adding myself (benwells) to committers.py
2004         https://bugs.webkit.org/show_bug.cgi?id=75971
2005
2006         Reviewed by Ojan Vafai.
2007
2008         * Scripts/webkitpy/common/config/committers.py:
2009
2010 2012-01-10  Mario Sanchez Prada  <msanchez@igalia.com>
2011
2012         AX: support helpText() in DumpRenderTree
2013         https://bugs.webkit.org/show_bug.cgi?id=40193
2014
2015         Reviewed by Chris Fleizach.
2016
2017         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
2018         (AccessibilityUIElement::helpText): Implemented.
2019
2020 2012-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2021
2022         Unreviewed, rolling out r104572.
2023         http://trac.webkit.org/changeset/104572
2024         https://bugs.webkit.org/show_bug.cgi?id=75967
2025
2026         It broke zillion tests (Requested by Ossy on #webkit).
2027
2028         * DumpRenderTree/qt/EventSenderQt.cpp:
2029         (EventSender::EventSender):
2030         (EventSender::sendOrQueueEvent):
2031         (EventSender::replaySavedEvents):
2032         (EventSender::eventFilter):
2033         * DumpRenderTree/qt/EventSenderQt.h:
2034
2035 2012-01-10  Hugo Parente Lima  <hugo.lima@openbossa.org>
2036
2037         [Qt] fast/events/dont-loose-last-event test fails on WK1
2038         https://bugs.webkit.org/show_bug.cgi?id=73894
2039
2040         Reviewed by Simon Hausmann.
2041
2042         Empty the entire event queue when requested besides using
2043         sendEvent instead of postEvent to make sure all events were
2044         delivered.
2045         This commit also removes not working DRT code to handle drag and drop,
2046         for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
2047
2048         * DumpRenderTree/qt/EventSenderQt.cpp:
2049         (EventSender::EventSender):
2050         (EventSender::sendOrQueueEvent):
2051         (EventSender::replaySavedEvents):
2052         * DumpRenderTree/qt/EventSenderQt.h:
2053
2054 2012-01-10  No'am Rosenthal  <noam.rosenthal@nokia.com>
2055
2056         [Qt] Enable CSS_FILTERS in Qt build
2057         https://bugs.webkit.org/show_bug.cgi?id=75777
2058
2059         Add the CSS_FILTERS feature flag to Qt.
2060
2061         Reviewed by Kenneth Rohde Christiansen.
2062
2063         * qmake/mkspecs/features/features.prf:
2064
2065 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2066
2067         [Qt] Unreviewed -Werror build fix.
2068
2069         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2070         (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
2071         declaration.
2072
2073 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2074
2075         [Qt] Remove dependency to uitools
2076         https://bugs.webkit.org/show_bug.cgi?id=75952
2077
2078         Reviewed by Tor Arne Vestbø.
2079
2080         QUiLoader is used for creating QLabel/QProgressBar widgets for
2081         a layout test, to verify some widget embedding feature. Unfortunately
2082         in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
2083         depends on qttools. Since we don't really _need_ QUiLoader for our tests,
2084         let's break the circular dependency.
2085
2086         * DumpRenderTree/qt/DumpRenderTree.pro:
2087         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2088         (WebCore::WebPage::createPlugin):
2089         * QtTestBrowser/QtTestBrowser.pro:
2090         * QtTestBrowser/launcherwindow.h:
2091         * QtTestBrowser/webpage.cpp:
2092         (WebPage::createPlugin):
2093         * qmake/mkspecs/features/minimal_qt.prf:
2094         * qmake/mkspecs/features/uitools.prf: Removed.
2095
2096 2012-01-10  Alexander Færøy  <alexander.faeroy@nokia.com>
2097
2098         [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
2099         https://bugs.webkit.org/show_bug.cgi?id=75894
2100
2101         Reviewed by Tor Arne Vestbø.
2102
2103         * MiniBrowser/qt/MiniBrowserApplication.h:
2104         (MiniBrowserApplication::windowOptions):
2105         * MiniBrowser/qt/main.cpp:
2106         (main):
2107
2108 2012-01-10  Simon Hausmann  <simon.hausmann@nokia.com>
2109
2110         [Qt] DRT crashes with Qt 5
2111         https://bugs.webkit.org/show_bug.cgi?id=75951
2112
2113         Reviewed by Ossy.
2114
2115         * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
2116         Qt relies on font-config to define the default font family.
2117
2118 2012-01-10  Csaba Osztrogonác  <ossy@webkit.org>
2119
2120         [Qt] REGRESSION(r100130): Clean build feature is broken.
2121         https://bugs.webkit.org/show_bug.cgi?id=75863
2122
2123         Reviewed by Tor Arne Vestbø.
2124
2125         * Scripts/webkitdirs.pm:
2126         (buildQMakeProject):
2127
2128 2012-01-10  Zeno Albisser  <zeno@webkit.org>
2129
2130         [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
2131         https://bugs.webkit.org/show_bug.cgi?id=75885
2132
2133         In QML events are propagated through parents. But since the
2134         WebView may consume key events, a shortcut might never reach
2135         the top QtQuickItem.
2136         Therefore an application wide event handling function in C++
2137         needs to take care of shortcuts for MiniBrowser.
2138
2139         Reviewed by Kenneth Rohde Christiansen.
2140
2141         * MiniBrowser/qt/BrowserWindow.cpp:
2142         (BrowserWindow::reload):
2143         (BrowserWindow::focusAddressBar):
2144         * MiniBrowser/qt/BrowserWindow.h:
2145         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2146         (MiniBrowserApplication::notify):
2147         * MiniBrowser/qt/qml/BrowserWindow.qml:
2148
2149 2012-01-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2150
2151         Add --efl alias for --platform=efl to run-webkit-test
2152         https://bugs.webkit.org/show_bug.cgi?id=75937
2153
2154         Reviewed by Andreas Kling.
2155         
2156         * Scripts/run-webkit-tests: Add --efl alias.
2157         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
2158         (parse_args):
2159
2160 2012-01-09  Dan Bernstein  <mitz@apple.com>
2161
2162         -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
2163         https://bugs.webkit.org/show_bug.cgi?id=75920
2164
2165         Reviewed by Darin Adler.
2166
2167         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
2168         (TestWebKitAPI::TEST): Added a test for a range in a
2169         -webkit-user-select: none; block.
2170
2171 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2172
2173         webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
2174         https://bugs.webkit.org/show_bug.cgi?id=75884
2175
2176         Reviewed by Ryosuke Niwa.
2177
2178         Fix regression introduced (revealed?) in r104340. Chromium file         
2179         url syntax is different on win32 and the test results weren't           
2180         expecting that.                                                         
2181
2182         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2183         (TestExpectations._report_errors):
2184         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
2185         (test_parse_error_nonfatal):
2186         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2187         (MockDRTTest.input_line):
2188         (MockChromiumDRTTest.test_pixeltest__fails):
2189         * Scripts/webkitpy/layout_tests/port/test.py:
2190         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2191         (TestRebaseliner.make_rebaseliner):
2192         (TestRebaseliner.test_one_platform):
2193         (TestRebaseliner.test_all_platforms):
2194         (TestRebaseliner.test_png_file_with_comment):
2195         (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
2196         (TestRebaseliner.test_png_file_with_comment_as_duplicate):
2197         (TestRealMain.test_all_platforms):
2198
2199 2012-01-09  Dirk Pranke  <dpranke@chromium.org>
2200
2201         Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
2202
2203         Unreviewed, build fix.
2204
2205         test-webkitpy had a built-in self-test routine to verify that
2206         deleting the .pyc files worked correctly. When I removed the
2207         python24 directory in r104482, I broke the self-test.
2208
2209         I have deleted the self-test for now. Since I am reworking
2210         test-webkitpy I will make sure the new version is adequately
2211         tested.
2212
2213         * Scripts/test-webkitpy:
2214         (configure_logging):
2215         (_clean_pyc_files):
2216         (_clean_packages):
2217         (init):
2218
2219 2012-01-09  Justin Novosad  <junov@chromium.org>
2220
2221         [Chromium] remove all references to the legacy accelerated 2d Canvas
2222         implementation
2223         https://bugs.webkit.org/show_bug.cgi?id=75108
2224
2225         Purging an old settings flag that is no longer referenced
2226
2227         Reviewed by Darin Fisher.
2228
2229         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2230         (main):
2231         * DumpRenderTree/chromium/TestShell.cpp:
2232         (TestShell::TestShell):
2233         (TestShell::resetWebSettings):
2234         * DumpRenderTree/chromium/TestShell.h:
2235         (TestShell::setAccelerated2dCanvasEnabled):
2236         * DumpRenderTree/chromium/WebPreferences.cpp:
2237         (WebPreferences::reset):
2238         (WebPreferences::applyTo):
2239         * DumpRenderTree/chromium/WebPreferences.h:
2240
2241 2012-01-09  Adam Roben  <aroben@apple.com>
2242
2243         Convert Cygwin paths to Windows paths before passing them to DRT
2244
2245         Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
2246         NRWT
2247
2248         I couldn't find a way to test this because I couldn't figure out how to override the
2249         cygpath function as it is used by WebKitDriver.
2250
2251         Reviewed by Dirk Pranke.
2252
2253         * Scripts/webkitpy/layout_tests/port/webkit.py:
2254         (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
2255         Windows-style path before passing it to DRT.
2256
2257 2012-01-06  Dirk Pranke  <dpranke@chromium.org>
2258
2259         webkitpy: revamp version checking
2260         https://bugs.webkit.org/show_bug.cgi?id=75765
2261
2262         Reviewed by Adam Barth.
2263
2264         The version-checking code in webkitpy/python24/versioning seems really
2265         awkward and overdesigned, especially since we don't support python 2.4
2266         any more.
2267
2268         In addition, I am tired of getting warnings about Python 2.6 being "a
2269         newer release than what is supported" :).
2270
2271         I'm taking a page from the depot_tools python code and just creating a
2272         new webkitpy.common.version_check module that will print a message on
2273         stderr and call sys.exit() if we're running an unsupported version.
2274
2275         * Scripts/check-webkit-style:
2276         * Scripts/new-run-webkit-httpd:
2277         * Scripts/new-run-webkit-tests:
2278         * Scripts/rebaseline-chromium-webkit-tests:
2279         * Scripts/test-webkitpy:
2280         (configure_logging):
2281         (init):
2282         * Scripts/webkit-patch:
2283         (main):
2284         * Scripts/webkitpy/common/system/executive.py:
2285         (Executive._child_process_encoding):
2286         (Executive._should_encode_child_process_arguments):
2287         * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
2288         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2289         * Scripts/webkitpy/python24/__init__.py: Removed.
2290         * Scripts/webkitpy/python24/versioning.py: Removed.
2291         * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
2292
2293 2012-01-09  Adam Barth  <abarth@webkit.org>
2294
2295         Remove Chromium Mac CG from the flakiness dashboard
2296         https://bugs.webkit.org/show_bug.cgi?id=75873
2297
2298         Reviewed by Ojan Vafai.
2299
2300         This configuration no longer exists.
2301
2302         * TestResultServer/static-dashboards/builders.js:
2303         * TestResultServer/static-dashboards/flakiness_dashboard.html:
2304         * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
2305         (testOverrideJustBuildType):
2306         (testPlatformAndBuildType):
2307
2308 2012-01-06  Adam Roben  <aroben@apple.com>
2309
2310         Print an error message when NRWT can't run Apache
2311
2312         Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
2313
2314         Reviewed by Dirk Pranke.
2315
2316         * Scripts/webkitpy/layout_tests/port/base.py:
2317         (Port.check_httpd): Print an error message when Apache returns an error code instead of
2318         failing silently.
2319
2320         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2321         (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
2322         run Apache.
2323         (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
2324         fails.
2325
2326 2012-01-09  Gabor Rapcsanyi  <rgabor@webkit.org>
2327
2328         [Gtk][ARM] Cross compiler buildbot is failing after r103040
2329         https://bugs.webkit.org/show_bug.cgi?id=75846
2330
2331         Reviewed by Philippe Normand.
2332
2333         * Scripts/webkitdirs.pm:
2334         (runAutogenForAutotoolsProjectIfNecessary):
2335
2336 2012-01-09  Alexander Færøy  <ahf@0x90.dk>
2337
2338         [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
2339         https://bugs.webkit.org/show_bug.cgi?id=75807
2340
2341         This patch adds a new icon to navigationbar of the Qt MiniBrowser
2342         which allows you to dynamically toggle whether touch mocking is
2343         enabled or disabled.
2344
2345         Reviewed by Tor Arne Vestbø.
2346
2347         * MiniBrowser/qt/MiniBrowser.qrc:
2348         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2349         (MiniBrowserApplication::notify):
2350         * MiniBrowser/qt/MiniBrowserApplication.h:
2351         (WindowOptions::WindowOptions):
2352         (WindowOptions::touchMockingEnabled):
2353         (WindowOptions::setTouchMockingEnabled):
2354         * MiniBrowser/qt/icons/touch.png: Added.
2355         * MiniBrowser/qt/qml/BrowserWindow.qml:
2356
2357 2012-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2358
2359         Unreviewed. Fix make distcheck issues.
2360
2361         * MiniBrowser/gtk/GNUmakefile.am:
2362
2363 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2364
2365         Unreviewed, rolling out r104421.
2366         http://trac.webkit.org/changeset/104421
2367         https://bugs.webkit.org/show_bug.cgi?id=75816
2368
2369         Need to rebaseline some tests on Linux (Requested by noamr on
2370         #webkit).
2371
2372         * qmake/mkspecs/features/features.prf:
2373
2374 2012-01-08  Adam Barth  <abarth@webkit.org>
2375
2376         Remove support for Chromium Mac CG from garden-o-matic
2377         https://bugs.webkit.org/show_bug.cgi?id=75814
2378
2379         Reviewed by Eric Seidel.
2380
2381         This configuration no longer exists.  This patch is mostly a matter of
2382         updating config.js and removing the examples from the unit tests.
2383
2384         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
2385         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
2386         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
2387         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
2388         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
2389
2390 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2391
2392         [Qt] Enable CSS_FILTERS in Qt build
2393         https://bugs.webkit.org/show_bug.cgi?id=75777
2394
2395         Add the CSS_FILTERS feature flag to Qt.
2396
2397         Reviewed by Kenneth Rohde Christiansen.
2398
2399         * qmake/mkspecs/features/features.prf:
2400
2401 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2402
2403         Categorize bots by ports instead of core/non-core separation
2404         https://bugs.webkit.org/show_bug.cgi?id=75766
2405
2406         Reviewed by Eric Seidel.
2407
2408         Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
2409         (Chromium still comes before GTK and Qt).
2410
2411         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2412         (loadBuilderConfig):
2413         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2414
2415 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2416
2417         Remove the concept of core builders from webkitpy
2418         https://bugs.webkit.org/show_bug.cgi?id=75809
2419
2420         Reviewed by Ryosuke Niwa.
2421
2422         Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
2423         and remove the relevant code.
2424
2425         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2426         (BuildBot.__init__):
2427         (BuildBot._matches_regexps):
2428         (BuildBot._builder_statuses_with_names_matching_regexps):
2429         (BuildBot.builder_statuses):
2430         (BuildBot.failure_map):
2431         (BuildBot._latest_builds_from_builders):
2432         (BuildBot.last_green_revision):
2433         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
2434         (MockBuildBot.builder_statuses):
2435         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2436         (test_status_parsing):
2437         (test_last_green_revision):
2438         (test_last_green_revision.mock_builds_from_builders):
2439
2440 2012-01-08  Adam Barth  <abarth@webkit.org>
2441
2442         Remove Chromium Mac CG concept from webkitpy
2443         https://bugs.webkit.org/show_bug.cgi?id=75810
2444
2445         Reviewed by Ryosuke Niwa.
2446
2447         This configuration no longer exists.  We can remove all the supporting
2448         code from webkitpy.
2449
2450         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
2451         (BaselineOptimizerTest.test_move_baselines):
2452         (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
2453         (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
2454         (BaselineOptimizerTest.test_common_directory_includes_root):
2455         (BaselineOptimizerTest.test_complex_shadowing):
2456         * Scripts/webkitpy/common/config/build.py:
2457         (_should_file_trigger_build):
2458         * Scripts/webkitpy/common/config/build_unittest.py:
2459         (ShouldBuildTest):
2460         * Scripts/webkitpy/layout_tests/port/builders.py:
2461         * Scripts/webkitpy/layout_tests/port/chromium.py:
2462         (ChromiumPort):
2463         (ChromiumPort._generate_all_test_configurations):
2464         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2465         (_default_tests_paths):
2466         (ChromiumGpuLinuxPort.tests):
2467         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2468         (ChromiumGpuTest.integration_test_chromium_gpu_mac):
2469         (ChromiumGpuTest.assert_port_works):
2470         (ChromiumGpuTest.test_baseline_paths):
2471         (ChromiumGpuTest.test_graphics_type):
2472         (ChromiumGpuTest.test_default_tests_paths):
2473         (ChromiumGpuTest.test_test_files):
2474         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2475         (ChromiumMacPort):
2476         (ChromiumMacPort.__init__):
2477         (ChromiumMacPort.baseline_search_path):
2478         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2479         (ChromiumMacPortTest.test_graphics_type):
2480         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2481         (ChromiumPortTest.test_all_test_configurations):
2482         * Scripts/webkitpy/layout_tests/port/dryrun.py:
2483         * Scripts/webkitpy/layout_tests/port/factory.py:
2484         (PortFactory._port_name_from_arguments_and_options):
2485         (PortFactory.get):
2486         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2487         (FactoryTest.test_chromium_gpu_mac):
2488         (FactoryTest.test_chromium_mac):
2489         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2490         (GetGoogleChromePortTest._verify_expectations_overrides):
2491         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2492         (MockChromiumDRTTest.test_chromium_parse_options):
2493         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
2494         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
2495         (test_url_fetcher):
2496         (test_zip_factory):
2497         (test_archive):
2498         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
2499         (TestRebaseline.test_rebaseline_expectations):
2500
2501 2012-01-08  Ryosuke Niwa  <rniwa@webkit.org>
2502
2503         Categorize bots by ports instead of core/non-core separation
2504         https://bugs.webkit.org/show_bug.cgi?id=75766
2505
2506         Reviewed by Adam Barth.
2507
2508         Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
2509
2510         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2511         (loadBuilderConfig):
2512         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2513
2514 2012-01-08  Sheriff Bot  <webkit.review.bot@gmail.com>
2515
2516         Unreviewed, rolling out r104403.
2517         http://trac.webkit.org/changeset/104403
2518         https://bugs.webkit.org/show_bug.cgi?id=75803
2519
2520         It broke all tests on Qt5 (Requested by Ossy_weekend on
2521         #webkit).
2522
2523         * qmake/mkspecs/features/features.prf:
2524
2525 2012-01-08  No'am Rosenthal  <noam.rosenthal@nokia.com>
2526
2527         [Qt] Enable CSS_FILTERS in Qt build
2528         https://bugs.webkit.org/show_bug.cgi?id=75777
2529
2530         Add the CSS_FILTERS feature flag to Qt.
2531
2532         Reviewed by Kenneth Rohde Christiansen.
2533
2534         * qmake/mkspecs/features/features.prf:
2535
2536 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2537
2538         Rewrite the CSS parser of prepare-ChangeLog with unittests.
2539         https://bugs.webkit.org/show_bug.cgi?id=75202
2540
2541         Reviewed by David Kilzer.
2542
2543         The current CSS parser can just parse simple CSSes like
2544
2545             foo bar baz {
2546                 property1: value;
2547                 property2: value;
2548             }
2549
2550         , and cannot parse comments nor a CSS in which a selector and {
2551         appears in different lines. This patch rewrites the CSS parser
2552         (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
2553         shown in css_unittests.css.
2554
2555         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
2556
2557         * Scripts/prepare-ChangeLog:
2558         (get_selector_line_ranges_for_css):
2559         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2560         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
2561         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
2562         (element1):
2563         (element2):
2564         (element3):
2565         (element4.p):
2566         (element5.p.q.r.s):
2567         (element6#p):
2568         (element7 element8):
2569         (element9.p element10.q):
2570         (element11#p element12#q):
2571         (element13, element14):
2572         (.p):
2573         (#p):
2574         (.p element15 #q element16.r element17#s):
2575         (element18:target):
2576         (element19):
2577         (element20):
2578         (element21):
2579         (element22):
2580
2581 2012-01-04  Kentaro Hara  <haraken@chromium.org>
2582
2583         The Perl parser of prepare-ChangeLog can parse here-documents
2584         https://bugs.webkit.org/show_bug.cgi?id=73208
2585
2586         Reviewed by David Kilzer.
2587
2588         Currently prepare-ChangeLog cannot recognize here-documents in Perl,
2589         which results in wrong subroutine names in ChangeLogs.
2590         With this patch, prepare-ChangeLog can judge whether the line of "}"
2591         is the end of a subroutine or a line inside a here-document.
2592
2593         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
2594
2595         * Scripts/prepare-ChangeLog:
2596         (get_function_line_ranges_for_perl):
2597         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
2598         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
2599         Added test cases for here-documents.
2600         (func7):
2601         (func8):
2602         (func9):
2603         (func10):
2604         (func11):
2605         (func12):
2606         (func13):
2607         (func14):
2608         (func15):
2609         (func16):
2610
2611 2012-01-08  Kentaro Hara  <haraken@chromium.org>
2612
2613         Add unittests for the JavaScript parser of prepare-ChangeLog
2614         https://bugs.webkit.org/show_bug.cgi?id=75201
2615
2616         Reviewed by David Kilzer.
2617
2618         javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
2619         of prepare-ChangeLog.
2620
2621         * Scripts/prepare-ChangeLog:
2622         (get_function_line_ranges_for_javascript): Before this patch, a string found was just
2623         omitted from parsing. Thus,
2624
2625             str = "foo"
2626             function func() {
2627             }
2628
2629         was recognized as equivalent to
2630
2631             str = function func() {
2632             }
2633
2634         This patch replaces a string with a dummy identifier 'string_appeared_here'
2635         to tell the parser that a string appeared there.
2636
2637         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
2638         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
2639         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
2640         (func1):
2641         (func2):
2642         (func3):
2643         (func4):
2644         (func5):
2645         (func6):
2646         (func7):
2647         (func8):
2648         (func9):
2649         (func10):
2650         (func11):
2651         (func12):
2652         (funcOverloaded):
2653         (Func1.prototype.get x1):
2654         (Func1.prototype.get x2):
2655         (Func1.prototype.set x1):
2656         (Func1.prototype.set x3):
2657         (Func2.prototype.func13):
2658         (Func2.prototype.func14):
2659         (Func2.prototype.func15):
2660         (func16.func17):
2661         (func16.func18):
2662         (func16.func19):
2663         (func16):
2664
2665 2012-01-08  David Levin  <levin@chromium.org>
2666
2667         [chromium] Add layout test support for autosize code in FrameView.
2668         https://bugs.webkit.org/show_bug.cgi?id=73631
2669
2670         Reviewed by Dmitry Titov.
2671
2672         * DumpRenderTree/chromium/LayoutTestController.cpp:
2673         (LayoutTestController::LayoutTestController): Expose the new autoresize method.
2674         (LayoutTestController::reset): Set the autoresize mode back to false.
2675         (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
2676         * DumpRenderTree/chromium/LayoutTestController.h:
2677         * DumpRenderTree/chromium/WebViewHost.cpp:
2678         (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
2679         * DumpRenderTree/chromium/WebViewHost.h:
2680
2681 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
2682
2683         [WK2][GTK] Each test takes roughly half a second to load
2684         https://bugs.webkit.org/show_bug.cgi?id=70699
2685
2686         Reviewed by Martin Robinson.
2687
2688         Set the XDG_CACHE_HOME environment variable when testing with
2689         WebKitTestRunner. This way the testing is started with a non-existing
2690         application cache. If the cache exists and is not empty, the emptying
2691         and vacuuming that is performed before every test can consume a lot of
2692         time.
2693
2694         This is just a temporary workaround until it becomes possible to set
2695         a desired directory to be used as the application cache location through
2696         WebKitWebContext.
2697
2698         * Scripts/webkitpy/layout_tests/port/gtk.py:
2699         (GtkPort.setup_environ_for_server):
2700
2701 2012-01-07  Zan Dobersek  <zandobersek@gmail.com>
2702
2703         [GTK] Enable requestAnimationFrame in build-webkit
2704         https://bugs.webkit.org/show_bug.cgi?id=75773
2705
2706         Reviewed by Martin Robinson.
2707
2708         Enable requestAnimationFrame for the Gtk port.
2709
2710         * Scripts/build-webkit:
2711
2712 2012-01-06  Jarred Nicholls  <jarred@sencha.com>
2713
2714         Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
2715
2716         * Scripts/webkitdirs.pm:
2717         (buildChromium):
2718         Missing parentheses.
2719
2720 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2721
2722         Fix DRT build on case-sensitive file systems.
2723
2724         Fix case of include of WebDynamicScrollBarsView.h
2725         
2726         * DumpRenderTree/mac/DumpRenderTree.mm:
2727
2728 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2729
2730         Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
2731         https://bugs.webkit.org/show_bug.cgi?id=75662
2732
2733         Reviewed by Dan Bernstein.
2734         
2735         The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
2736         of color profile issues. Fix by keeping everything in device RGB and ensuring that the
2737         test window uses the main display's color space, so that the pixel values in the bitmap
2738         that gets checksummed are identical to the CSS colors.
2739         
2740         Removed the code that switches the display profile in DRT, since that is no longer required.
2741
2742         * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
2743         * DumpRenderTree/mac/DumpRenderTree.mm:
2744         (crashHandler): Remove code that switches display profiles.
2745         (prepareConsistentTestingEnvironment): Ditto.
2746         (dumpRenderTree): Ditto.
2747         * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
2748         (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
2749         (createBitmapContextFromWebView): Add comment about the colorspace handling.
2750         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2751         (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
2752         (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
2753         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2754         (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
2755         (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
2756
2757 2012-01-06  David Kilzer  <ddkilzer@apple.com>
2758
2759         run-api-tests: specify individual suites and tests on the command-line
2760
2761         Reviewed by Adam Roben.
2762
2763         Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2764
2765         The run-api-tests script will now accept a list of arguments on
2766         the command-line that are used as prefix filters.  To run all
2767         tests in a suite that starts with "WTF" (WTF and WTF_Vector)
2768         use:
2769
2770             $ run-api-tests WTF
2771
2772         To run only the tests in the "WTF" suite, not the "WTF_Vector"
2773         suite, use:
2774
2775             $ run-api-tests WTF.
2776
2777         * Scripts/run-api-tests: Filter tests if any prefix arguments
2778         are passed on the command-line.
2779
2780 2012-01-06  David Kilzer  <ddkilzer@apple.com>
2781
2782         run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
2783
2784         Reviewed by Adam Roben.
2785
2786         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
2787
2788         * Scripts/run-api-tests:
2789         (dumpTestsBySuite): Update to accept array of tests instead of
2790         hash data structure.
2791         (runTestsBySuite): Ditto.
2792         (listAllTests): Rename from populateTests().  Update to return
2793         an array of tests instad of the hash data structure.
2794
2795 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2796
2797         webkitpy: clean up test/uri conversion routines
2798         https://bugs.webkit.org/show_bug.cgi?id=75648
2799
2800         Reviewed by Eric Seidel.
2801
2802         This change moves test_to_uri and uri_to_test from the Port
2803         class to the Driver class (the routines were only being
2804         called by the drivers), and removes a bunch of stale and/or
2805         busted logic.
2806
2807         * Scripts/webkitpy/layout_tests/port/base.py:
2808         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2809         * Scripts/webkitpy/layout_tests/port/chromium.py:
2810         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
2811         * Scripts/webkitpy/layout_tests/port/driver.py:
2812         (is_http_test):
2813         (test_to_uri):
2814         (uri_to_test):
2815         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
2816         (run_one_test):
2817         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
2818         (MockDRTTest.input_line):
2819         (input_line):
2820         (expected_output):
2821         * Scripts/webkitpy/layout_tests/port/test.py:
2822         * Scripts/webkitpy/layout_tests/port/webkit.py:
2823         (_command_from_driver_input):
2824
2825 2012-01-06  Simon Fraser  <simon.fraser@apple.com>
2826
2827         Mitigate scrollbar differences when running pixel tests
2828         https://bugs.webkit.org/show_bug.cgi?id=67217
2829
2830         Reviewed by Dan Bernstein.
2831         
2832         Add an NSScroller subclass that draws mock scrollbars identically
2833         to the WebCore mock scrollbar theme, and register it with the
2834         WebDynamicScrollbarsView.
2835
2836         * DumpRenderTree/mac/DumpRenderTree.mm:
2837         (-[DRTMockScroller rectForPart:]):
2838         (-[DRTMockScroller drawKnob]):
2839         (-[DRTMockScroller drawRect:]):
2840         (registerMockScrollbars):
2841         (prepareConsistentTestingEnvironment):
2842
2843 2012-01-05  Jon Lee  <jonlee@apple.com>
2844
2845         Update DRT on Mac to draw resize handles on text areas.
2846
2847         Reviewed by John Sullivan.
2848
2849         Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
2850         between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
2851
2852         * DumpRenderTree/mac/DumpRenderTree.mm:
2853         (resetDefaultsToConsistentValues):
2854
2855 2012-01-06  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2856
2857         [Qt] Move listing of include paths and libs to pri files in sources
2858
2859         Includepaths are sometimes modified by non-Qt contributors so keeping
2860         them in files inside Sources makes it more likely that they are updated
2861         along with project files for the other ports.
2862
2863         Using pri files instead of prf files for this also has the benefit that
2864         the include() from the main target file can be parsed and followed by
2865         Qt Creator -- something that does not work with load().
2866
2867         Dependency from a target to a library through the WEBKIT variable are
2868         handled through forwarding-files in Tools/qmake/mkspecs/modules, which
2869         set the source root of the module and include the right pri file.
2870
2871         Ideally we'd use the variant of include() that takes an optional
2872         namespace to read the variables into, or the fromfile() function,
2873         but both of these add an overhead of about 40% on the total qmake
2874         runtime, due to making a deep copy of all the variables in the
2875         project or re-reading all the prf files from scratch.
2876
2877         Reviewed by Simon Hausmann.
2878         Reviewed by Ossy.
2879
2880         * qmake/mkspecs/features/default_post.prf:
2881         * qmake/mkspecs/modules/javascriptcore.prf: Added.
2882         * qmake/mkspecs/modules/webcore.prf: Added.
2883         * qmake/mkspecs/modules/webkit2.prf: Added.
2884         * qmake/mkspecs/modules/wtf.prf: Added.
2885
2886 2012-01-06  JungJik Lee  <jungjik.lee@samsung.com>
2887
2888         [EFL] Add pre-render handling code in EWebLauncher.
2889         https://bugs.webkit.org/show_bug.cgi?id=73430
2890
2891         Reviewed by Zoltan Herczeg.
2892
2893         Add pre-render handling code by pressing Insert key.
2894
2895         * EWebLauncher/main.c:
2896         (on_key_down):
2897
2898 2012-01-06  Csaba Osztrogonác  <ossy@webkit.org>
2899
2900         NRWT should use test_expectation.txt on wk2 platforms
2901         https://bugs.webkit.org/show_bug.cgi?id=75417
2902
2903         Reviewed by Dirk Pranke.
2904
2905         * Scripts/webkitpy/layout_tests/port/webkit.py:
2906         (path_to_test_expectations_file):
2907         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2908         (test_path_to_test_expectations_file):
2909
2910 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
2911
2912         Don't hardcode expected file URIs in as they depend on the platform
2913         https://bugs.webkit.org/show_bug.cgi?id=75666
2914
2915         Reviewed by Dirk Pranke.
2916
2917         * Scripts/webkitpy/layout_tests/port/win.py:
2918         (WinPort.show_results_html_file):
2919         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2920         (MainTest.test_unexpected_failures):
2921         (MainTest.test_results_directory_default):
2922         (MainTest.test_results_directory_relative):
2923
2924 2012-01-05  Anders Carlsson  <andersca@apple.com>
2925
2926         Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
2927         https://bugs.webkit.org/show_bug.cgi?id=75667
2928         <rdar://problem/10389454>
2929
2930         Reviewed by Kevin Decker.
2931
2932         Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
2933
2934         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
2935         (PluginTest::executeScript):
2936         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
2937         * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
2938         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
2939         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
2940         (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
2941
2942 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
2943
2944         webkitpy: clean up port factory methods
2945         https://bugs.webkit.org/show_bug.cgi?id=75590
2946
2947         Reviewed by Eric Seidel.
2948
2949         This change consolidates much of the "factory method" logic
2950         of determining which port objects to create for a given set
2951         of configurations by merging the separate factory methods in
2952         chromium_gpu and google_chrome into PortFactory so that at least
2953         all of the logic is in one place.
2954
2955         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2956         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
2957         * Scripts/webkitpy/layout_tests/port/factory.py:
2958         (_port_name_from_arguments_and_options):
2959         (get):
2960         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
2961         (test_google_chrome):
2962         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
2963         (GoogleChromeLinux32Port):
2964         (GoogleChromeLinux32Port.baseline_search_path):
2965         (test_expectations_overrides):
2966         (architecture):
2967         (GoogleChromeLinux64Port):
2968         (GoogleChromeLinux64Port.baseline_search_path):
2969         (GoogleChromeMacPort):
2970         (GoogleChromeMacPort.baseline_search_path):
2971         (GoogleChromeWinPort):
2972         (GoogleChromeWinPort.baseline_search_path):
2973         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
2974         (_verify_baseline_path):
2975
2976 2012-01-05  Jochen Eisinger  <jochen@chromium.org>
2977
2978         Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
2979         https://bugs.webkit.org/show_bug.cgi?id=75617
2980
2981         Reviewed by Dirk Pranke.
2982
2983         * Scripts/webkitpy/common/system/filesystem.py:
2984         (FileSystem.exists):
2985         * Scripts/webkitpy/common/system/filesystem_mock.py:
2986         (MockFileSystem.exists):
2987         * Scripts/webkitpy/common/system/filesystem_unittest.py:
2988         (GenericFileSystemTests.teardown_generic_test_dir):
2989         * Scripts/webkitpy/layout_tests/port/base.py:
2990         (Port.to.show_results_html_file):
2991         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2992         (MainTest.test_results_directory_absolute):
2993
2994 2012-01-05  Adam Roben  <aroben@apple.com>
2995
2996         Remove some unnecessary code from old-run-webkit-tests
2997
2998         Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
2999         WebKitTestRunner.
3000
3001         Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
3002         Windows
3003
3004         Reviewed by Eric Seidel.
3005
3006         * Scripts/old-run-webkit-tests:
3007         (top level):
3008         (openDumpTool):
3009         Removed calls to setPathForRunningWebKitApp.
3010
3011 2012-01-05  Adam Roben  <aroben@apple.com>
3012
3013         Teach NRWT to use run-safari to open results.html on Apple's Windows port
3014
3015         NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
3016         better, since we always want to open results.html using the user's build of WebKit, not
3017         whatever their default browser is.
3018
3019         Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
3020         for Apple's Windows port
3021
3022         Reviewed by Eric Seidel.
3023
3024         * Scripts/webkitpy/layout_tests/port/win.py:
3025         (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
3026         an obsolete comment.
3027
3028         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3029         (WinPortTest.test_show_results_html_file): Updated expected results.
3030
3031 2012-01-05  Adam Roben  <aroben@apple.com>
3032
3033         Prepend Safari.exe's path to the command-line passed to CreateProcess
3034
3035         Safari expects the first argument in the command-line to be the path to Safari.exe itself.
3036         This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
3037         thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
3038         was not including the path to Safari.exe in the command-line, so Safari was ignoring the
3039         first argument that WebKitLauncherWin was trying to pass to it.
3040
3041         Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
3042
3043         Reviewed by Steve Falkenburg.
3044
3045         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3046         (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
3047         path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
3048
3049 2012-01-05  Adam Roben  <aroben@apple.com>
3050
3051         Stop using explicit memory management in WebKitLauncherWin
3052
3053         We now use stack-allocated STL objects instead.
3054
3055         Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
3056         Safari
3057
3058         Reviewed by Steve Falkenburg.
3059
3060         * WebKitLauncherWin/WebKitLauncherWin.cpp:
3061         (getStringValue):
3062         (applePathFromRegistry):
3063         (safariInstallDir):
3064         (safariBrowserExe):
3065         (_tWinMain):
3066         Changed to use stack-allocated STL objects instead of malloc/free.
3067
3068 2012-01-05  Adam Roben  <aroben@apple.com>
3069
3070         Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
3071
3072         This allows us to add the Safari and Apple Application Support directories to PATH before
3073         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3074
3075         Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3076         Windows port of DumpRenderTree/WebKitTestRunner
3077
3078         Reviewed by Steve Falkenburg.
3079
3080         * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
3081         ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
3082
3083         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
3084         * WebKitTestRunner/win/WebKitTestRunner.vcproj:
3085         Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
3086
3087         * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
3088         Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
3089         the stub launcher.
3090
3091         * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
3092         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
3093         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
3094         * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
3095         * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
3096         * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
3097         * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
3098
3099         * WebKitTestRunner/win/main.cpp:
3100         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3101
3102 2012-01-05  Adam Roben  <aroben@apple.com>
3103
3104         Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
3105
3106         This allows us to add the Safari and Apple Application Support directories to PATH before
3107         trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
3108
3109         Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
3110         Windows port of DumpRenderTree/WebKitTestRunner
3111
3112         Reviewed by Steve Falkenburg.
3113
3114         * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
3115         which I forgot to add to this .sln when that project was created.
3116
3117         * DumpRenderTree/win/DumpRenderTree.cpp:
3118         (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
3119
3120         * DumpRenderTree/win/DumpRenderTree.vcproj:
3121         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
3122         Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
3123
3124         * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
3125         * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
3126         * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
3127         * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
3128         * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
3129         * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
3130         * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
3131         * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
3132
3133         * win/DLLLauncher/DLLLauncherMain.cpp:
3134         (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
3135         Safari's directory to PATH so that SafariTheme.dll can be found.
3136
3137         (main):
3138         (wWinMain):
3139         Changed to use the new modifyPath function.
3140
3141 2012-01-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3142
3143         [Qt] Never enable FontConfig on Mac OS X
3144         https://bugs.webkit.org/show_bug.cgi?id=75616
3145
3146         Reviewed by Tor Arne Vestbø.
3147
3148         * qmake/mkspecs/features/features.prf:
3149
3150 2012-01-05  Alpha Lam  <hclam@chromium.org>
3151
3152         Unreviewed, rolling out r104159.
3153         http://trac.webkit.org/changeset/104159
3154         https://bugs.webkit.org/show_bug.cgi?id=75590
3155
3156         Chromium port GPU tests cannot be executed.
3157
3158         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3159         (get):
3160         (_default_tests_paths):
3161         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3162         (ChromiumGpuTest.assert_port_works):
3163         * Scripts/webkitpy/layout_tests/port/factory.py:
3164         (PortFactory._port_name_from_arguments_and_options):
3165         (PortFactory):
3166         (PortFactory._get_kwargs):
3167         (PortFactory.get):
3168         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3169         (FactoryTest.test_google_chrome.names):
3170         (FactoryTest.test_google_chrome):
3171         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3172         (GetGoogleChromePort):
3173         (GetGoogleChromePort.GoogleChromeLinux32Port):
3174         (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
3175         (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
3176         (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
3177         (GetGoogleChromePort.GoogleChromeLinux64Port):
3178         (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
3179         (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
3180         (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
3181         (GetGoogleChromePort.GoogleChromeMacPort):
3182         (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
3183         (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
3184         (GetGoogleChromePort.GoogleChromeWinPort):
3185         (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
3186         (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
3187         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3188         (GetGoogleChromePortTest._verify_baseline_path):
3189         (GetGoogleChromePortTest._verify_expectations_overrides):
3190
3191 2012-01-05  Dirk Pranke  <dpranke@chromium.org>
3192
3193         webkitpy: clean up port factory methods
3194         https://bugs.webkit.org/show_bug.cgi?id=75590
3195
3196         Reviewed by Eric Seidel.
3197
3198         This change consolidates much of the "factory method" logic
3199         of determining which port objects to create for a given set
3200         of configurations by merging the separate factory methods in
3201         chromium_gpu and google_chrome into PortFactory so that at least
3202         all of the logic is in one place.
3203
3204         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
3205         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
3206         * Scripts/webkitpy/layout_tests/port/factory.py:
3207         (_port_name_from_arguments_and_options):
3208         (get):
3209         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
3210         (test_google_chrome):
3211         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
3212         (GoogleChromeLinux32Port):
3213         (GoogleChromeLinux32Port.baseline_search_path):
3214         (test_expectations_overrides):
3215         (architecture):
3216         (GoogleChromeLinux64Port):
3217         (GoogleChromeLinux64Port.baseline_search_path):
3218         (GoogleChromeMacPort):
3219         (GoogleChromeMacPort.baseline_search_path):
3220         (GoogleChromeWinPort):
3221         (GoogleChromeWinPort.baseline_search_path):
3222         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
3223         (_verify_baseline_path):
3224
3225 2012-01-04  Adam Roben  <aroben@apple.com>
3226
3227         Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
3228
3229         This allows us to add the Apple Application Support directory to PATH before trying to load
3230         WebKit so that CoreGraphics.dll and friends can be found.
3231
3232         Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
3233
3234         Reviewed by Anders Carlsson.
3235
3236         * DumpRenderTree/win/ImageDiff.vcproj:
3237         * DumpRenderTree/win/ImageDiffCommon.vsprops:
3238         Changed to build ImageDiff.dll instead of ImageDiff.exe.
3239
3240         * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
3241         Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
3242
3243         * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
3244         * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
3245         * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
3246         * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
3247         * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
3248         * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
3249         * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
3250
3251         * DumpRenderTree/win/ImageDiffWin.cpp: Added.
3252         (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
3253         to main.
3254
3255         * win/DLLLauncher/DLLLauncherMain.cpp:
3256         (main):
3257         (wWinMain):
3258         Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
3259         stub launcher acts as a console program and calls a console version of
3260         dllLauncherEntryPoint.
3261
3262 2012-01-04  Adam Roben  <aroben@apple.com>
3263
3264         Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
3265
3266         This allows us to add the Apple Application Support directory to PATH before trying to load
3267         WebKit so that CoreGraphics.dll and friends can be found.
3268
3269         Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
3270         double-clicked
3271
3272         Reviewed by Anders Carlsson.
3273
3274         * MiniBrowser/MiniBrowser.vcproj:
3275         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
3276         Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
3277
3278         * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
3279         * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
3280         * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
3281         * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
3282         * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
3283         * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
3284         * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
3285
3286         * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
3287         but changed to build the stub launcher.
3288
3289         * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
3290         it needs to be compiled into the .exe instead of the .dll.
3291         (DllMain): Added. We use this to store the DLL's HINSTANCE.
3292         (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
3293         DLLLauncherMain code.
3294
3295         * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
3296         to here.
3297
3298 2012-01-04  Adam Roben  <aroben@apple.com>
3299
3300         Make WinLauncher's window frame respond to clicks/drags again
3301
3302         Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
3303         bar when Aero is disabled
3304
3305         Reviewed by Brent Fulgham.
3306
3307         * WinLauncher/WinLauncher.cpp:
3308         (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
3309         Also removed an unnecessary "break" keyword.
3310
3311 2012-01-04  Adam Roben  <aroben@apple.com>
3312
3313         Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
3314
3315         This allows us to add the Apple Application Support directory to PATH before trying to load
3316         WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
3317         should use this mechanism.
3318
3319         Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
3320         double-clicked
3321
3322         Reviewed by Anders Carlsson.
3323
3324         * WinLauncher/WinLauncher.cpp: Removed InitInstance.
3325         (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
3326         done by the now-removed InitInstance function.
3327         (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
3328         calls. Merged code from InitInstance into this function, and change to use the global hInst
3329         variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
3330         function, which corresponds to WinLauncher.exe.
3331
3332         * WinLauncher/WinLauncher.vcproj:
3333         * WinLauncher/WinLauncherCommon.vsprops:
3334         Changed to build WinLauncher.dll instead of WinLauncher.exe.
3335
3336         * WinLauncher/WinLauncherLauncher.rc: Added.
3337         * WinLauncher/WinLauncherLauncherResource.h: Added.
3338         This just references the WinLauncher.ico file to set the application icon (though it looks
3339         like that's a default icon).
3340
3341         * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
3342         but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
3343
3344         * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
3345         * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
3346         * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
3347         * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
3348         * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
3349         * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
3350         * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
3351
3352         * win/DLLLauncher/DLLLauncherMain.cpp: Added.
3353         (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
3354         program if it detects heap corruption.
3355         (getStringValue): Helper function to read a string value from the registry.
3356         (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
3357         application from the registry.
3358         (appleApplicationSupportDirectory): Helper function to return the path to the Apple
3359         Application Support directory.
3360         (copyEnvironmentVariable): Helper function to copy an environment variable's value.
3361         (prependPath): Helper function to prepend a directory to the PATH.
3362         (fatalError): Helper function to display an error to the user.
3363         (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
3364         dllLauncherEntryPoint function.
3365
3366 2012-01-05  Kentaro Hara  <haraken@chromium.org>
3367
3368         prepare-ChangeLog cannot parse python code that nests classes and defs
3369         https://bugs.webkit.org/show_bug.cgi?id=75524
3370
3371         Reviewed by Ryosuke Niwa.
3372
3373         This patch fixes the python parser of prepare-ChangeLog so that it can parse
3374         python code that nests classes and defs, like this:
3375
3376         class C:
3377             pass
3378             def f():
3379                 pass
3380             pass
3381
3382         Also, this patch fixes the python parser so that it inserts a dummy line
3383         at the end of the file to pop out all popped scopes.
3384
3385         * Scripts/prepare-ChangeLog:
3386         (get_function_line_ranges_for_python):
3387
3388         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
3389         Added test cases that nest classes and defs.
3390         (func7):
3391         (func7.func8):
3392         (func7.func8.func9):
3393         (Class2):
3394         (Class2.Class3):
3395         (Class2.Class3.Class4):
3396         (Class5):
3397         (Class5.func10):
3398         (Class5.func11):
3399         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
3400
3401 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3402
3403         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
3404         https://bugs.webkit.org/show_bug.cgi?id=75433
3405
3406         Reviewed by Martin Robinson.
3407
3408         * MiniBrowser/gtk/BrowserWindow.c:
3409         (webViewLoadFailed): Reset the progress bar when load fails.
3410         (browserWindowConstructed): Connect to load-failed signal.
3411
3412 2012-01-04  Dan Bernstein  <mitz@apple.com>
3413
3414         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
3415         start WebProcess under gdb and WebProcess will then run the client executable.
3416
3417         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
3418
3419         Reviewed by Anders Carlsson.
3420
3421         * Scripts/webkitdirs.pm:
3422         (shouldTargetWebProcess): Added.
3423         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
3424         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
3425         app using the -client-executable option if targeting the web process.
3426
3427 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
3428
3429         Adding myself to committers list.
3430
3431         Unreviewed.
3432
3433         * Scripts/webkitpy/common/config/committers.py:
3434
3435 2012-01-04  David Kilzer  <ddkilzer@apple.com>
3436
3437         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
3438
3439         This reverts commit r103546.
3440
3441         * TestWebKitAPI/TestsController.cpp:
3442         (TestWebKitAPI::TestsController::TestsController):
3443
3444 2012-01-04  James Robinson  <jamesr@chromium.org>
3445
3446         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
3447         https://bugs.webkit.org/show_bug.cgi?id=74583
3448
3449         Reviewed by Darin Fisher.
3450
3451         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
3452
3453         * Scripts/webkitpy/style/checkers/cpp.py:
3454         (check_function_definition):
3455
3456 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3457
3458         [Qt] Fix link order of static libraries and unbreak QtWin32
3459
3460         We were keeping the correct static link order between the intermediate
3461         WebKit libraries, but not the internal dependencies for each of those
3462         libraries. The load() will in some instances mess with LIBS, so we need
3463         to ensure that the dependent libraries are added after the library we
3464         are linking against.
3465
3466         Reviewed by Simon Hausmann.
3467
3468         * qmake/mkspecs/features/default_post.prf:
3469
3470 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3471
3472         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
3473
3474         The custom qmake variable 'WEBKIT' is used for signaling that a
3475         target depends in some way on other subproject of the WebKit
3476         project. For now this is limited to the set of intermediate
3477         libraries: wtf, javascriptcore, webcore, and webkit2.
3478
3479         This replaces the previous convension of using load(foo) for
3480         just include paths, and CONFIG += foo to also link against foo.
3481
3482         Adding a dependency results in additional include paths being
3483         available, and potentially linking to the library. This is
3484         decided by the build system based on conditions such as what
3485         kind of target is being built and the general build config.
3486
3487         An advantage to his approach is that it simplifies the individual
3488         foo.prf files, for example by allowing us to use INCLUDEPATH +=
3489         and LIBS += as normal instead of prepending.
3490
3491         Reviewed by Simon Hausmann.
3492
3493         * DumpRenderTree/qt/DumpRenderTree.pro:
3494         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3495         * QtTestBrowser/QtTestBrowser.pro:
3496         * WebKitTestRunner/InjectedBundle/Target.pri:
3497         * WebKitTestRunner/Target.pri:
3498         * qmake/README:
3499         * qmake/mkspecs/features/default_post.prf:
3500         * qmake/mkspecs/features/functions.prf:
3501         * qmake/mkspecs/features/javascriptcore.prf:
3502         * qmake/mkspecs/features/qtwebkit.prf:
3503         * qmake/mkspecs/features/webcore.prf:
3504         * qmake/mkspecs/features/webkit2.prf:
3505         * qmake/mkspecs/features/wtf.prf:
3506
3507 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
3508
3509         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
3510         https://bugs.webkit.org/show_bug.cgi?id=75488
3511
3512         Reviewed by Tor Arne Vestbø.
3513
3514         * MiniBrowser/qt/MiniBrowser.qrc:
3515         * MiniBrowser/qt/qml/BrowserWindow.qml:
3516         * MiniBrowser/qt/qml/Dialog.qml:
3517         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3518         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
3519
3520 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3521
3522         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
3523
3524         It wasn't really a problem at runtime since the right QtWebKit was
3525         already loaded as a dependency of the web process, but the ldd output
3526         would still be busted.
3527
3528         Reviewed by Simon Hausmann.
3529
3530         * WebKitTestRunner/InjectedBundle/Target.pri:
3531
3532 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3533
3534         [Qt] Move use of $$qtLibraryTarget() to a single place
3535
3536         Reviewed by Kenneth Rohde Christiansen.
3537
3538         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3539         * WebKitTestRunner/InjectedBundle/Target.pri:
3540         * qmake/mkspecs/features/default_post.prf:
3541         * qmake/mkspecs/features/webcore.prf:
3542
3543 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
3544
3545         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
3546         https://bugs.webkit.org/show_bug.cgi?id=75238
3547
3548         Reviewed by Antonio Gomes.
3549
3550         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
3551         it could initiate download directly if it has the download attribute in the link 
3552         and doesn't need to open new blank page for the target="_blank". Enabling this 
3553         feature in the BlackBerry porting also prepares for later blob feature implementation.
3554
3555         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
3556         for the BlackBerry porting.
3557
3558 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3559
3560         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
3561         https://bugs.webkit.org/show_bug.cgi?id=75475
3562
3563         Reviewed by Martin Robinson.
3564
3565         The problem is that the property blurb contains <a ping> and tree
3566         view uses gtk_tooltip_set_markup() internally, so we need to
3567         escape the text.
3568
3569         * MiniBrowser/gtk/BrowserSettingsDialog.c:
3570         (browserSettingsDialogConstructed): Escape property blurb before
3571         storing it in the GtkTreeModel.
3572
3573 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
3574
3575         When showing results.html pass a correct URL to webbrowser.open
3576         https://bugs.webkit.org/show_bug.cgi?id=75438
3577
3578         Reviewed by Adam Barth.
3579
3580         * Scripts/webkitpy/common/system/filesystem.py:
3581         (file_path_as_url):
3582         * Scripts/webkitpy/common/system/filesystem_mock.py:
3583         (file_path_as_url):
3584         * Scripts/webkitpy/common/system/filesystem_unittest.py:
3585         (test_file_path_as_url):
3586         * Scripts/webkitpy/layout_tests/port/base.py:
3587         (show_results_html_file):
3588         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
3589         (test_show_results_html_file):
3590         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3591         (test_results_directory_relative):
3592
3593 2012-01-03  Ojan Vafai  <ojan@chromium.org>
3594
3595         shrink the header on the flakiness dashboard
3596         https://bugs.webkit.org/show_bug.cgi?id=65153
3597
3598         Reviewed by Adam Roben.
3599
3600         Move some of the "show" links to be to the right of the header
3601         instead of below the header when they content they're showing
3602         is hidden. That way we don't waste vertical space on them.
3603
3604         No new tests. This code is covered by existing tests.
3605
3606         * TestResultServer/static-dashboards/flakiness_dashboard.html:
3607
3608 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3609
3610         Add a tool to analyze change logs
3611         https://bugs.webkit.org/show_bug.cgi?id=72243
3612
3613         Reviewed by Eric Seidel.
3614
3615         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3616         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3617         for visualizing json files.
3618
3619         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3620         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3621         generates json files, and N is the number of changelogs to parse.
3622
3623         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3624         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3625         * Scripts/webkitpy/tool/commands/__init__.py:
3626         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3627         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3628         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3629         * Scripts/webkitpy/tool/steps/options.py:
3630
3631 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
3632
3633         Add a tool to analyze change logs
3634         https://bugs.webkit.org/show_bug.cgi?id=72243
3635
3636         Reviewed by Eric Seidel.
3637
3638         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
3639         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
3640         for visualizing json files.
3641
3642         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
3643         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
3644         generates json files, and N is the number of changelogs to parse.
3645
3646         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
3647         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
3648         * Scripts/webkitpy/tool/commands/__init__.py:
3649         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
3650         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
3651         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
3652         * Scripts/webkitpy/tool/steps/options.py:
3653
3654 2012-01-03  Adam Roben  <aroben@apple.com>
3655
3656         Make Port subclasses override the operating_system method rather than setting an attribute
3657
3658         Without this patch, any use of Port.operating_system() within a port's __init__ method would
3659         return the default value ("mac"). This was confusing the version-checking logic inside
3660         ApplePort.__init__ on Windows.