74975bdd156800cb292dcddb4076f94873888401
[WebKit-https.git] / Tools / ChangeLog
1 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
2
3         Remove dead code from TestInvocationCairo.cpp
4         https://bugs.webkit.org/show_bug.cgi?id=144564
5
6         Reviewed by Gyuyoung Kim.
7
8         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
9
10         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
11         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
12
13 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
14
15         [GTK] Add libnotify in gtk install-dependencies
16         https://bugs.webkit.org/show_bug.cgi?id=144379
17
18         Reviewed by Csaba Osztrogonác.
19
20         * gtk/install-dependencies:
21
22 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
23
24         check-webkit-style fails due to system pylint
25         https://bugs.webkit.org/show_bug.cgi?id=144360
26
27         Reviewed by Darin Adler.
28
29         Make sure that the directory containing third party autoinstalled modules
30         is at the beginning of the search path, to avoid conflicts with other
31         versions of the same modules installed in the system (e.g. pylint).
32
33         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
34         modules directory to sys.path, instead of appending it.
35
36 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
37
38         Unreviewed, updated my list of email addresses.
39
40         * Scripts/webkitpy/common/config/contributors.json: Updated.
41
42 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
43
44         USE(...) macro should expect unprefixed variables
45         https://bugs.webkit.org/show_bug.cgi?id=144454
46
47         Reviewed by Daniel Bates.
48
49         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
50         * DumpRenderTree/config.h: Ditto.
51         * TestWebKitAPI/config.h: Ditto.
52
53 2015-05-01  Basile Clement  <basile_clement@apple.com>
54
55         Unreviewed. Add myself as a commiter in contributors.json.
56
57         * Scripts/webkitpy/common/config/contributors.json:
58
59 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
60
61         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
62         https://bugs.webkit.org/show_bug.cgi?id=144487
63
64         Reviewed by Ryosuke Niwa.
65
66         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
67         (BenchmarkRunner.merge): Fix bug.
68         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
69
70 2015-05-01  Brady Eidson  <beidson@apple.com>
71
72         Add API to disable meta refreshes.
73         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
74
75         Reviewed by Alexey Proskuryakov.
76
77         * DumpRenderTree/mac/DumpRenderTree.mm:
78         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
79
80 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
81
82         Provide a runtime flag to run-webkit-tests that shows the test view
83         https://bugs.webkit.org/show_bug.cgi?id=144079.
84
85         Unreviewed correction to r183651.
86
87         * WebKitTestRunner/TestController.cpp:
88         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
89         flag is included in the options dictionary passed to the PlatformWebView.
90
91 2015-05-01  Antti Koivisto  <antti@apple.com>
92
93         Remove network process load serialization code
94         https://bugs.webkit.org/show_bug.cgi?id=144448
95
96         Reviewed by Alexey Proskuryakov.
97
98         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
99         (WTR::InjectedBundle::beginTesting):
100         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
101         (WTR::TestRunner::setSerializeHTTPLoads):
102         (WTR::TestRunner::dispatchPendingLoadRequests):
103
104 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
105
106         [GTK] Add libhyphen-dev to the build dependencies
107         https://bugs.webkit.org/show_bug.cgi?id=144452
108
109         Reviewed by Martin Robinson.
110
111         * gtk/install-dependencies: Added hyphen as Fedora and Arch
112         dependencies.
113
114 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
115
116         Provide a runtime flag to run-webkit-tests that shows the test view
117         https://bugs.webkit.org/show_bug.cgi?id=144079.
118
119         Reviewed by Dean Jackson.
120
121         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
122         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
123         option:
124         
125         --additional-drt-flag="--show-webview"
126
127         * DumpRenderTree/mac/DumpRenderTree.mm:
128         (createWebViewAndOffscreenWindow): Use an on-screen window rect if the user passed the
129         '--show-webview' flag.
130         (initializeGlobalsFromCommandLineOptions): Recognize the "--show-webview" option.
131         * WebKitTestRunner/Options.cpp:
132         (WTR::Options::Options):
133         (WTR::handleOptionShowWebView):
134         (WTR::OptionsHandler::OptionsHandler): Recognize the new "--show-webview" option.
135         * WebKitTestRunner/Options.h:
136         * WebKitTestRunner/TestController.cpp:
137         (WTR::TestController::TestController):
138         (WTR::TestController::initialize): Use value of 'shouldShowWebView' from the Options bundle.
139         * WebKitTestRunner/TestController.h:
140         (WTR::TestController::shouldShowWebView):
141         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
142         (WTR::PlatformWebView::PlatformWebView): Retrieve the value of the 'ShouldShowWebView' key from the
143         options dictionary. If it is true, display the web view while running the test.
144
145 2015-04-30  Alexey Proskuryakov  <ap@apple.com>
146
147         r183355 didn't trigger Mac tests
148         https://bugs.webkit.org/show_bug.cgi?id=144464
149
150         Reviewed by Simon Fraser.
151
152         Update badly neglected filters and unit tests.
153
154         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
155         (_should_file_trigger_build):
156         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
157         (ShouldBuildTest):
158         (ShouldBuildTest.test_should_build):
159
160 2015-04-30  Xabier Rodriguez Calvar  <calvaris@igalia.com>
161
162         [GTK] Add libhyphen-dev to the build dependencies
163         https://bugs.webkit.org/show_bug.cgi?id=144452
164
165         Reviewed by Martin Robinson.
166
167         * gtk/install-dependencies: Added libhyphen-dev to the WebKitGTK+
168         build dependencies.
169
170 2015-04-30  Martin Robinson  <mrobinson@igalia.com>
171
172         [GTK] Testing dictionaries are not installed automatically
173         https://bugs.webkit.org/show_bug.cgi?id=144460
174
175         Reviewed by Carlos Garcia Campos.
176
177         * gtk/jhbuild.modules: Add the testing dictionaries to the main moduleset.
178
179 2015-04-30  Dewei Zhu  <dewei_zhu@apple.com>
180
181         Fix return code issue, check return code of safari process and dump results to log
182         https://bugs.webkit.org/show_bug.cgi?id=144436
183
184         Reviewed by Ryosuke Niwa.
185
186         * Scripts/run-benchmark:
187         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
188         (BenchmarkRunner.dump): Correct typo.
189         (BenchmarkRunner.wrap): Add results to console.
190         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Check return code to detect Safari crashes.
191         (OSXSafariDriver.prepareEnv):
192         (OSXSafariDriver.launchUrl):
193         (OSXSafariDriver.closeBrowsers):
194
195 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
196
197         Should no longer need to worry about very old versions of Xcode
198         https://bugs.webkit.org/show_bug.cgi?id=144437
199
200         Reviewed by Dan Bernstein.
201
202         * Scripts/check-for-exit-time-destructors:
203         * Scripts/check-for-global-initializers:
204         * Scripts/check-for-weak-vtables-and-externals:
205
206 2015-04-29  Joseph Pecoraro  <pecoraro@apple.com>
207
208         REGRESSION(183583): [Mac] make without SDKROOT has issues
209         https://bugs.webkit.org/show_bug.cgi?id=144431
210
211         Reviewed by Dan Bernstein.
212
213         * Makefile:
214         * WebKitTestRunner/Makefile:
215         Assume an empty SDKROOT means an macosx variant, so only
216         enable settings if the SDKROOT is not empty and does not
217         contain "macosx".
218
219 2015-04-29  Brent Fulgham  <bfulgham@apple.com>
220
221         Expand test infrastructure to support scrolling tests
222         https://bugs.webkit.org/show_bug.cgi?id=143684
223         <rdar://problem/20375516>
224
225         Reviewed by Simon Fraser.
226
227         * DumpRenderTree/mac/DumpRenderTree.mm:
228         (resetWebViewToConsistentStateBeforeTesting): Make sure the WheelEventTestTrigger state is
229         reset before the next test run.
230         * WebKitTestRunner/TestController.cpp:
231         (WTR::TestController::resetStateToConsistentValues): Ditto."
232
233 2015-04-29  Alex Christensen  <achristensen@webkit.org>
234
235         Run javascriptcore tests on Windows without cygwin
236         https://bugs.webkit.org/show_bug.cgi?id=144419
237
238         Reviewed by Brent Fulgham.
239
240         * Scripts/run-javascriptcore-tests:
241         (runJSCStressTests):
242         Just call ruby, not /usr/bin/env ruby.
243
244 2015-04-29  Yusuke Suzuki  <utatane.tea@gmail.com>
245
246         [GTK] Add --enable-shared option to LLVM to build mesa
247         https://bugs.webkit.org/show_bug.cgi?id=144393
248
249         Reviewed by Martin Robinson.
250
251         The updated mesa requires the shared LLVM libraries.
252         To build mesa with LLVM in FTL build, this patch added `--enable-shared` option
253         to LLVM configure script. It will provide shared libraries in addition to static libraries.
254
255         * gtk/jhbuild-optional.modules:
256
257 2015-04-29  Martin Robinson  <mrobinson@igalia.com>
258
259         [GTK] Add support for automatic hyphenation
260         https://bugs.webkit.org/show_bug.cgi?id=44478
261
262         Reviewed by Carlos Garcia Campos.
263
264         * gtk/jhbuild.modules: Add a module for testing dictionaries, so that
265         all systems will use the same dictionaries for testing purposes.
266
267 2015-04-29  Jake Nielsen  <jacob_nielsen@apple.com>
268
269         Failure when building WebKit for appletvsimulator.
270         https://bugs.webkit.org/show_bug.cgi?id=144356
271
272         Reviewed by Alexey Proskuryakov.
273
274         Changes Makefile logic to check for "not OS X" rather than "is iOS" to
275         make TVOS and WatchOS behave correctly.
276
277         * Makefile:
278         * WebKitTestRunner/Makefile:
279
280 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
281
282         Use-after-free when invalidating WKPageForceRepaint callback
283         https://bugs.webkit.org/show_bug.cgi?id=144401
284         rdar://problem/20741111
285
286         Reviewed by Tim Horton.
287
288         * WebKitTestRunner/TestController.h: (WTR::TestController::isCurrentInvocation): Added.
289
290         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::forceRepaintDoneCallback):
291         Don't do anything on error, because the context may be a stale pointer now.
292
293 2015-04-29  David Kilzer  <ddkilzer@apple.com>
294
295         check-webkit-style: Don't complain about returning value from Objective-C method call in header
296         <http://webkit.org/b/144395>
297
298         Reviewed by Andy Estes.
299
300         * Scripts/webkitpy/style/checkers/cpp.py:
301         (check_spacing): Update regex so 'return' is ignored if it
302         precedes the whitespace and bracket.  Change category name to
303         'whitespace/brackets'.  Add period to error message.
304         (CppChecker): Add 'whitespace/brackets' as a category.
305         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
306         (ErrorCollector.__call__): Replace 'STYLE_CATEGORIES' with
307         'CppChecker.categories' since that's where the list lives now.
308         (CppStyleTest.test_spacing_before_brackets): Add tests for
309         'whitespace/brackets' issues and non-issues.
310
311 2015-04-29  Alex Christensen  <achristensen@webkit.org>
312
313         Fix WinCairo bot.
314
315         * Scripts/webkitdirs.pm:
316         (determinePassedConfiguration):
317         WinCairo bot doesn't use cygwin, but it needs Release_WinCairo for its configuration.
318
319 2015-04-29  Myles C. Maxfield  <mmaxfield@apple.com>
320
321         [OS X] Use CTFontCreateForCSS instead of doing font search ourselves
322         https://bugs.webkit.org/show_bug.cgi?id=132159
323
324         Reviewed by Darin Adler.
325
326         Make DumpRenderTree and WebKitTestRunner use the new font whitelist instead of
327         swizzling NSFontManager methods. This is predicated on ENABLE(PLATFORM_FONT_LOOKUP).
328
329         * DumpRenderTree/mac/DumpRenderTree.mm:
330         (fontWhitelist):
331         (adjustFonts):
332         (createWebViewAndOffscreenWindow):
333         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
334         (WTR::activateFonts):
335         * WebKitTestRunner/mac/TestControllerMac.mm:
336         (WTR::allowedFontFamilySet):
337         (WTR::systemHiddenFontFamilySet):
338         (WTR::generateWhitelist):
339         (WTR::TestController::platformInitializeContext):
340
341 2015-04-29  Alexey Proskuryakov  <ap@apple.com>
342
343         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
344         https://bugs.webkit.org/show_bug.cgi?id=144155
345
346         Reviewed by Andreas Kling.
347
348         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetStateToConsistentValues):
349         Make sure that test window is "visible" before each test. While there is no concrete
350         evidence that this is the problem indeed, the behavior is consistent with what would
351         happen for an invisible window. Also, WKTR obviously needs to do this to protect
352         against potential buggy tests that hide the window and don't show it.
353
354 2015-04-29  Carlos Garcia Campos  <cgarcia@igalia.com>
355
356         Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
357
358         Latest changes in the inspector UI made this test fail. We were
359         relying that the sidebar was always visible and the first 'li'
360         element of the inspector was the one containing the title. This is
361         no longer true, so better use document title that is not likely
362         to change.
363
364         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
365         (openRemoteDebuggingSession):
366
367 2015-04-29  Andres Gomez  <agomez@igalia.com>
368
369         Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
370
371         * Scripts/webkitpy/common/config/contributors.json:
372
373 2015-04-29  Andres Gomez  <agomez@igalia.com>
374
375         Unreviewed. Created a new watchlist for changes in WebInspectorUI images and added myself to it.
376
377         * Scripts/webkitpy/common/config/watchlist:
378
379 2015-04-29  Hunseop Jeong  <hs85.jeong@samsung.com>
380
381         [EFL] Allow to run the tests on the native X display
382         https://bugs.webkit.org/show_bug.cgi?id=144247
383
384         Reviewed by Gyuyoung Kim.
385
386         Added the USE_NATIVE_XDISPLAY option for the WTR.
387         We can select the Xorg driver if environment variable is set up before running the tests.
388
389         * Scripts/webkitpy/port/efl.py:
390         (EflPort._driver_class):
391
392 2015-04-29  Joonghun Park  <jh718.park@samsung.com>
393
394         [GTK] Add libnotify-dev in gtk install-dependencies
395         https://bugs.webkit.org/show_bug.cgi?id=144379
396
397         Reviewed by Žan Doberšek.
398
399         * gtk/install-dependencies:
400
401 2015-04-28  Ryuan Choi  <ryuan.choi@navercorp.com>
402
403         [CoordinatedGraphics] Merge TILED_BACKING_STORE guard with COORDINATED_GRAPHICS
404         https://bugs.webkit.org/show_bug.cgi?id=143001
405
406         Reviewed by Gyuyoung Kim.
407
408         * WebKitTestRunner/TestController.cpp:
409         (WTR::shouldUseFixedLayout):
410
411 2015-04-28  Dewei Zhu  <dewei_zhu@apple.com>
412
413         Increase stablility of run-benchmark script
414         https://bugs.webkit.org/show_bug.cgi?id=144361
415
416         Reviewed by Ryosuke Niwa.
417
418         * Scripts/run-benchmark:
419         (main):
420         * Scripts/webkitpy/benchmark_runner/README.md: Update readme due to changes.
421         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
422         (GenericBenchmarkBuilder.clean):
423         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Improve error handling and remove an unnecessary loop.
424         (BenchmarkRunner.__init__):
425         (BenchmarkRunner.execute):
426         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
427         (OSXSafariDriver.prepareEnv): Remove saved sessions of Safari.
428         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Upload 'results' rather than 'time'.
429         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Update formate.
430         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Update formate.
431         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: 
432         (ServerControl.render_POST): Flush the buffer to make sure we can pass the result to stdout.
433         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
434         (HTTPServerDriver.fetchResult):
435         (HTTPServerDriver):
436         (HTTPServerDriver.killServer): Add kill server interface.
437         (HTTPServerDriver.getReturnCode): Add get return code interface.
438         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Adjust to support new interfaces.
439         (SimpleHTTPServerDriver.serve):
440         (SimpleHTTPServerDriver.fetchResult):
441         (SimpleHTTPServerDriver):
442         (SimpleHTTPServerDriver.killServer):
443         (SimpleHTTPServerDriver.getReturnCode):
444         * Scripts/webkitpy/benchmark_runner/utils.py:
445         (forceRemove): Provide python version of 'rm -rf'.
446
447 2015-04-28  Sam Weinig  <sam@webkit.org>
448
449         [Content Extensions] Process NFAs individually to avoid having all NFAs live at the same time
450         https://bugs.webkit.org/show_bug.cgi?id=144363
451
452         Reviewed by Alex Christensen.
453
454         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
455         (TestWebKitAPI::createNFAs):
456         (TestWebKitAPI::TEST_F):
457         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
458         (TestWebKitAPI::countLiveNodes):
459         (TestWebKitAPI::createNFAs):
460         (TestWebKitAPI::buildDFAFromPatterns):
461         Update tests to use a hand rolled createNFAs function on top of CombinedURLFilters::processNFAs.
462
463 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
464
465         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
466         https://bugs.webkit.org/show_bug.cgi?id=144304
467
468         Reviewed by Geoffrey Garen.
469
470         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Always explicitly
471         set the value of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
472         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
473
474 2015-04-28  Commit Queue  <commit-queue@webkit.org>
475
476         Unreviewed, rolling out r183514.
477         https://bugs.webkit.org/show_bug.cgi?id=144359
478
479         It broke cloop test bots (Requested by mcatanzaro on #webkit).
480
481         Reverted changeset:
482
483         "Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT"
484         https://bugs.webkit.org/show_bug.cgi?id=144304
485         http://trac.webkit.org/changeset/183514
486
487 2015-04-28  Michael Catanzaro  <mcatanzaro@igalia.com>
488
489         Fully replace ENABLE_LLINT_C_LOOP with ENABLE_JIT
490         https://bugs.webkit.org/show_bug.cgi?id=144304
491
492         Reviewed by Geoffrey Garen.
493
494         * Scripts/build-jsc: Use ENABLE_JIT instead of ENABLE_LLINT_C_LOOP on Mac. Perform sanity-
495         checking to ensure --cloop and --ftl-jit cannot be combined. Always explicitly set the value
496         of ENABLE_JIT and ENABLE_FTL_JIT to avoid assumptions about the default value.
497         * Scripts/webkitperl/FeatureList.pm: Add --jit option to build-webkit.
498
499 2015-04-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
500
501         [CMake] Remove unnecessary include paths in TestWebKitAPI cmake files
502         https://bugs.webkit.org/show_bug.cgi?id=144319
503
504         Reviewed by Csaba Osztrogonác.
505
506         * TestWebKitAPI/CMakeLists.txt:
507         * TestWebKitAPI/PlatformEfl.cmake:
508
509 2015-04-28  Joseph Pecoraro  <pecoraro@apple.com>
510
511         Fix common typo "targetting" => "targeting"
512         https://bugs.webkit.org/show_bug.cgi?id=144349
513
514         Reviewed by Daniel Bates.
515
516         * Scripts/webkitdirs.pm:
517         (execMacWebKitAppForDebugging):
518
519 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
520
521         [GTK][jhbuild] Mesa build failure with llvm 3.6
522         https://bugs.webkit.org/show_bug.cgi?id=144250
523
524         Reviewed by Žan Doberšek.
525
526         Bump the version of Mesa to 10.5.4
527
528         * gtk/jhbuild.modules:
529
530 2015-04-28  Alexey Proskuryakov  <ap@apple.com>
531
532         Disable App Nap in WebKitTestRunner UI process
533         https://bugs.webkit.org/show_bug.cgi?id=144308
534
535         Reviewed by Daniel Bates.
536
537         * WebKitTestRunner/mac/main.mm:
538         (disableAppNapInUIProcess):
539         (main):
540
541 2015-04-28  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
542
543         [GTK] Update JHBuild Mesa download directory
544         https://bugs.webkit.org/show_bug.cgi?id=144318
545
546         Update the download directory of Mesa module since the previous one
547         doesn't exist any more.
548
549         Reviewed by Žan Doberšek.
550
551         * gtk/jhbuild.modules:
552
553 2015-04-28  Commit Queue  <commit-queue@webkit.org>
554
555         Unreviewed, rolling out r183477.
556         https://bugs.webkit.org/show_bug.cgi?id=144334
557
558         Roll back the Mesa dependency bump in fear of uncaught
559         regressions while the testing bots are no-op. (Requested by
560         zdobersek on #webkit).
561
562         Reverted changeset:
563
564         "[GTK][jhbuild] Mesa build failure with llvm 3.6"
565         https://bugs.webkit.org/show_bug.cgi?id=144250
566         http://trac.webkit.org/changeset/183477
567
568 2015-04-28  Joanmarie Diggs  <jdiggs@igalia.com>
569
570         [GTK][jhbuild] Mesa build failure with llvm 3.6
571         https://bugs.webkit.org/show_bug.cgi?id=144250
572
573         Reviewed by Žan Doberšek.
574
575         Bump the version of Mesa to 10.5.4
576
577         * gtk/jhbuild.modules:
578
579 2015-04-27  Dewei Zhu  <dewei_zhu@apple.com>
580
581         Add '__init__.py' and fix known bug in benchmark runner.
582         https://bugs.webkit.org/show_bug.cgi?id=144296
583
584         Reviewed by Ryosuke Niwa
585
586         * Scripts/webkitpy/benchmark_runner/__init__.py: Make python to recognize this module.
587         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Make python to recognize this module.
588         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
589         (BenchmarkRunner.__init__):
590         (BenchmarkRunner.execute): Fix logic bug that '--output-file' option doesn't work, and empty output file bug.
591         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Make python to recognize this module.
592         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Make python to recognize this module.
593
594 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
595
596         More build fix.
597
598         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
599         (-[AccessibilityNotificationHandler _notificationReceived:]):
600         Use -objectForKey:, not array subscript.
601
602 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
603
604         Catch unexpected exits in DumpRenderTree
605         https://bugs.webkit.org/show_bug.cgi?id=144288
606
607         Reviewed by Tim Horton.
608
609         * DumpRenderTree/mac/DumpRenderTree.mm:
610         (atexitFunction):
611         (DumpRenderTreeMain):
612
613 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
614
615         Build fix
616
617         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
618         (-[AccessibilityNotificationHandler _notificationReceived:]):
619         Use -objectForKey:, not array subscript.
620
621 2015-04-27  Alexey Proskuryakov  <ap@apple.com>
622
623         fast/frames/flattening/iframe-flattening-resize-event-count.html times out on Yosemite WK2
624         https://bugs.webkit.org/show_bug.cgi?id=144155
625
626         Reviewed by Tim Horton.
627
628         * WebKitTestRunner/TestController.cpp: (WTR::TestController::resetPreferencesToConsistentValues):
629         Disable App Nap. I don't have positive evidence that it's the culprit, but it could be,
630         and we clearly don't want App Nap while testing.
631
632 2015-04-22  Martin Robinson  <mrobinson@igalia.com>
633
634         [CMake] Autogenerate cmakeconfig.h.cmake
635         https://bugs.webkit.org/show_bug.cgi?id=143997
636
637         Reviewed by Csaba Osztrogonác.
638
639         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Add XP_UNIX to the command-line
640         definitions since TestNetscapePlugIn does not use cmakeconfig.h.
641
642 2015-04-27  Brent Fulgham  <bfulgham@apple.com>
643
644         REGRESSION(r182879): Images and video can no longer be downloaded
645         https://bugs.webkit.org/show_bug.cgi?id=144267
646         <rdar://problem/20702844>
647
648         Reviewed by Simon Fraser.
649
650         Revise tests to check for proper download menu state.
651         1. Downloading a loal image should be disabled.
652         2. Downloading a local media file should be disabled.
653         3. Downloading non-downloadable media should be disabled.
654
655         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
656         (TestWebKitAPI::TEST):
657
658 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
659
660         Merge run-launcher into run-minibrowser
661         https://bugs.webkit.org/show_bug.cgi?id=141928
662
663         Reviewed by Darin Adler.
664
665         * Scripts/run-iexploder-tests:
666         (runSafariWithIExploder):
667         * Scripts/run-launcher: Removed.
668         * Scripts/run-minibrowser:
669         * Scripts/webkitdirs.pm:
670         (launcherPath):
671         * Scripts/webkitpy/port/efl.py:
672         (EflPort.show_results_html_file):
673         * Scripts/webkitpy/port/efl_unittest.py:
674         (EflPortTest.test_show_results_html_file):
675         * Scripts/webkitpy/port/gtk.py:
676         (GtkPort.print_leaks_summary):
677         (GtkPort.show_results_html_file):
678         (GtkPort): Deleted.
679         * Scripts/webkitpy/port/gtk_unittest.py:
680         (GtkPortTest.test_show_results_html_file):
681
682 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
683
684         [buildbot] Fix the output of perf-test buildstep on timeout
685         https://bugs.webkit.org/show_bug.cgi?id=144097
686
687         Reviewed by Ryosuke Niwa.
688
689         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
690         (RunAndUploadPerfTests.getText2):
691         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
692         (RunAndUploadPerfTestsTest.test_buildbot_timeout):
693         (RunAndUploadPerfTestsTest.test_build_bad_preparation): Deleted.
694
695 2015-04-27  Csaba Osztrogonác  <ossy@webkit.org>
696
697         [EFL] TestWebKitAPI's forwarding header generator should depend on WebKit2's generator
698         https://bugs.webkit.org/show_bug.cgi?id=143874
699
700         Reviewed by Gyuyoung Kim.
701
702         * TestWebKitAPI/PlatformEfl.cmake: Add the new dependency.
703
704 2015-04-24  Philippe Normand  <pnormand@igalia.com>
705
706         [JHBuild] Move to upstream OpenWebRTC
707         https://bugs.webkit.org/show_bug.cgi?id=144145
708
709         Reviewed by Carlos Garcia Campos.
710
711         * efl/jhbuild.modules: Switch to upstream OpenWebRTC repository
712         and add a new simple patch to gst-plugins-base, required for
713         OpenWebRTC build.
714         * efl/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
715         * gtk/jhbuild.modules: Ditto.
716         * gtk/patches/gst-plugins-base-rtp-rtcpbuffer-fix-typo-in-enum.patch: Added.
717
718 2015-04-26  Yusuke Suzuki  <utatane.tea@gmail.com>
719
720         [ES6] Implement ES6 template literals
721         https://bugs.webkit.org/show_bug.cgi?id=142691
722
723         Reviewed by Darin Adler.
724
725         Add ENABLE_ES6_TEMPLATE_LITERAL_SYNTAX compile time flag.
726
727         * Scripts/webkitperl/FeatureList.pm:
728
729 2015-04-26  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
730
731         [CMake][EFL] Remove unnecessary include, library path in WebKitTestRunner/PlatformEfl.cmake 
732         https://bugs.webkit.org/show_bug.cgi?id=144217
733
734         Reviewed by Darin Adler.
735
736         * WebKitTestRunner/PlatformEfl.cmake:
737
738 2015-04-26  Doug Russell  <d_russell@apple.com>
739
740         AX: richer text change notifications (142719)
741         https://bugs.webkit.org/show_bug.cgi?id=142719
742
743         Reviewed by Darin Adler.
744
745         Richer accessibility value change notifications. Introduce AXTextEditType,
746         postTextStateChangeNotification and postTextReplacementNotification to give assistive
747         tech apps more reliable context for responding to changes in web content. Also implement
748         a mechanism to post value changes in password form fields in coalesced ticks to thwart
749         analyzing the cadence of changes.
750
751         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent,
752         and an overload of postTextReplacementNotification to give assistive tech apps more
753         reliable context for responding to changes in web content selection. Also block posting
754         selection changes on password fields.
755
756         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
757         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
758         (-[AccessibilityNotificationHandler stopObserving]):
759         (-[AccessibilityNotificationHandler _notificationReceived:]):
760         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
761         (AccessibilityUIElement::removeNotificationListener):
762         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
763         (-[AccessibilityNotificationHandler _notificationReceived:]):
764         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
765         (WTR::AccessibilityUIElement::removeNotificationListener):
766
767 2015-04-25  Sungmann Cho  <sungmann.cho@navercorp.com>
768
769         Add myself to contributors.json
770         https://bugs.webkit.org/show_bug.cgi?id=144204
771
772         Reviewed by Darin Adler.
773
774         * Scripts/webkitpy/common/config/contributors.json:
775
776 2015-04-25  Martin Robinson  <mrobinson@igalia.com>
777
778         Rename ENABLE_3D_RENDERING to ENABLE_3D_TRANSFORMS
779         https://bugs.webkit.org/show_bug.cgi?id=144182
780
781         Reviewed by Simon Fraser.
782
783         * DumpRenderTree/win/DumpRenderTree.cpp: Replace all instances of 3D_RENDERING with 3D_TRANSFORMS.
784
785 2015-04-25  Dewei Zhu  <dewei_zhu@apple.com>
786
787         https://bugs.webkit.org/show_bug.cgi?id=144038
788
789         Reviewed by Ryosuke Niwa
790
791         Add a script to run Speedometer and JetStream on a browser.
792
793         * Scripts/run-benchmark: Wrapper script to run benchmark.
794         (main):
795         * Scripts/webkitpy/benchmark_runner/README.md: Introduction of this script.
796         * Scripts/webkitpy/benchmark_runner/__init__.py: Added.
797         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Added.
798         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Added.
799         (BenchmarkBuilderFactory):
800         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added.
801         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Added.
802         (GenericBenchmarkBuilder):
803         (GenericBenchmarkBuilder.prepare):
804         (GenericBenchmarkBuilder._copyBenchmarkToTempDir):
805         (GenericBenchmarkBuilder._applyPatch):
806         (GenericBenchmarkBuilder.clean):
807         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Added.
808         (JetStreamBenchmarkBuilder):
809         (JetStreamBenchmarkBuilder.prepare):
810         (JetStreamBenchmarkBuilder._runCreateScript):
811         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py: Main module that masters all the processes of benchmark running.
812         (BenchmarkRunner):
813         (BenchmarkRunner.__init__):
814         (BenchmarkRunner.execute):
815         (BenchmarkRunner.dump):
816         (BenchmarkRunner.wrap):
817         (BenchmarkRunner.merge):
818         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py: Added.
819         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py: Added.
820         (BrowserDriver):
821         (BrowserDriver.prepareEnv):
822         (BrowserDriver.launchUrl):
823         (BrowserDriver.closeBrowser):
824         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py: Added.
825         (BrowserDriverFactory):
826         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Added.
827         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: Added.
828         (OSXChromeDriver):
829         (OSXChromeDriver.prepareEnv):
830         (OSXChromeDriver.launchUrl):
831         (OSXChromeDriver.closeBrowsers):
832         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: Added.
833         (OSXSafariDriver):
834         (OSXSafariDriver.prepareEnv):
835         (OSXSafariDriver.launchUrl):
836         (OSXSafariDriver.closeBrowsers):
837         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Patch that makes JetStream compatible with this script.
838         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Patch that makes Speedometer compatible with this scritp.
839         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Added.
840         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Added.
841         * Scripts/webkitpy/benchmark_runner/generic_factory.py: Factory for generic purpose.
842         (GenericFactory):
843         (GenericFactory.iterateGetItem):
844         (GenericFactory.create):
845         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py: Added.
846         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py: Added.
847         (ServerControl):
848         (ServerControl.render_GET):
849         (ServerControl.render_POST):
850         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py: Added.
851         (HTTPServerDriver):
852         (HTTPServerDriver.serve):
853         (HTTPServerDriver.fetchResult):
854         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py: Added.
855         (HTTPServerDriverFactory):
856         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Added.
857         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py: Added.
858         (SimpleHTTPServerDriver):
859         (SimpleHTTPServerDriver.depends):
860         (SimpleHTTPServerDriver.__init__):
861         (SimpleHTTPServerDriver.serve):
862         (SimpleHTTPServerDriver.baseUrl):
863         (SimpleHTTPServerDriver.fetchResult):
864         * Scripts/webkitpy/benchmark_runner/utils.py: Utility module.
865         (ModuleNotFoundError):
866         (loadModule):
867         (getPathFromProjectRoot):
868         (loadJSONFromFile):
869         (TimeoutError):
870         (timeout):
871         (timeout.__init__):
872         (timeout.handle_timeout):
873         (timeout.__enter__):
874         (timeout.__exit__):
875
876 2015-04-24  Commit Queue  <commit-queue@webkit.org>
877
878         Unreviewed, rolling out r183303.
879         https://bugs.webkit.org/show_bug.cgi?id=144181
880
881         Change was incorrect, broke builds (Requested by smfr on
882         #webkit).
883
884         Reverted changeset:
885
886         "Fix the build."
887         http://trac.webkit.org/changeset/183303
888
889 2015-04-24  Simon Fraser  <simon.fraser@apple.com>
890
891         Fix the build.
892
893         * MiniBrowser/mac/WK2BrowserWindowController.m:
894         (-[WK2BrowserWindowController initWithConfiguration:]):
895
896 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
897
898         Disable ActionMenusPDFTest due to timeout on test bot
899
900         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
901         (TestWebKitAPI::TEST):
902
903 2015-04-24  Commit Queue  <commit-queue@webkit.org>
904
905         Unreviewed, rolling out r183266.
906         https://bugs.webkit.org/show_bug.cgi?id=144164
907
908         Broke 32-bit build and a test. (Requested by ap on #webkit).
909
910         Reverted changeset:
911
912         "AX: richer text change notifications (142719)"
913         https://bugs.webkit.org/show_bug.cgi?id=142719
914         http://trac.webkit.org/changeset/183266
915
916 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
917
918         REGRESSION: WebKit2.ActionMenusTest API test fails
919         https://bugs.webkit.org/show_bug.cgi?id=144149
920         <rdar://problem/20677770>
921
922         Reviewed by Tim Horton.
923
924         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Revise to use the same test PDF
925         as the 'ActionMenusPDFTest'.
926         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
927         (TestWebKitAPI::TEST): Unskip the PDF portion of ActionMenusTest, and revise its expected output
928         to match the hit test on the 'action-menu-target.pdf' test file.
929
930 2015-04-24  Daniel Bates  <dabates@apple.com>
931
932         Cleanup: Use @memoized for property IOSSimulator.testing_device
933         https://bugs.webkit.org/show_bug.cgi?id=141715
934
935         Reviewed by Darin Adler.
936
937         Simplify the caching of the result of IOSSimulator.testing_device
938         and make the code more readable by making use of the @memoized declarator
939         instead of explicitly managing a private instance variable,
940         IOSSimulator._testing_device, for the cached result.
941
942         * Scripts/webkitpy/port/ios.py:
943         (IOSPort.determine_full_port_name):
944         (IOSSimulatorPort.__init__): Delete instance variable IOSSimulatorPort._testing_device.
945         (IOSSimulatorPort):
946         (IOSSimulatorPort.testing_device): No need to cache the created device object in
947         IOSSimulatorPort._testing_device since we are marking this function @memoized.
948         (IOSSimulatorPort.reset_preferences): Code style fix; inline self.testing_device.path instead
949         of caching in local variable since we only make use of this value exactly once in this function.
950         (IOSPort.__init__): Deleted; The instance variable IOSPort._testing_device has never
951         been used since being added in r178622. So, we can remove this constructor since
952         it's the trivial constructor once we remove the instance variable IOSPort._testing_device.
953
954 2015-04-24  Anders Carlsson  <andersca@apple.com>
955
956         Rename -[WKWebsiteDataStore isNonPersistent] to -[WKWebsiteDataStore isPersistent]
957         https://bugs.webkit.org/show_bug.cgi?id=144158
958
959         Reviewed by Beth Dakin.
960
961         * MiniBrowser/mac/WK2BrowserWindowController.m:
962         (-[WK2BrowserWindowController initWithConfiguration:]):
963
964 2015-04-24  Doug Russell  <d_russell@apple.com>
965
966         AX: richer text change notifications (142719)
967         https://bugs.webkit.org/show_bug.cgi?id=142719
968
969         Reviewed by Darin Adler.
970
971         Richer accessibility value change notifications. Introduce AXTextEditType, postTextStateChangeNotification and postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content. Also implement a mechanism to post value changes in password form fields in coalesced ticks to thwart analyzing the cadence of changes.
972
973         Richer accessibility selection change notifications. Introduce AXTextStateChangeIntent, and an overload of postTextReplacementNotification to give assistive tech apps more reliable context for responding to changes in web content selection. Also block posting selection changes on password fields.
974
975         * DumpRenderTree/mac/AccessibilityNotificationHandler.h:
976         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
977         (-[AccessibilityNotificationHandler stopObserving]):
978         (-[AccessibilityNotificationHandler _notificationReceived:]):
979         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
980         (AccessibilityUIElement::removeNotificationListener):
981         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
982         (-[AccessibilityNotificationHandler _notificationReceived:]):
983         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
984         (WTR::AccessibilityUIElement::removeNotificationListener):
985
986 2015-04-24  Darin Adler  <darin@apple.com>
987
988         Convert OwnPtr and PassOwnPtr uses to std::unique_ptr
989         https://bugs.webkit.org/show_bug.cgi?id=128007
990
991         Reviewed by Anders Carlsson.
992
993         * DumpRenderTree/win/HistoryDelegate.h: Removed unneeded include.
994         * DumpRenderTree/win/UIDelegate.h: Ditto.
995
996         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Removed OwnPtr-specific test cases.
997         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Ditto.
998
999         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Removed unneeded include.
1000
1001         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Use unique_ptr.
1002         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp): Use make_unique.
1003         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp: Ditto.
1004         (TestWebKitAPI::WebKit2WillLoadTest::SetUp): Ditto.
1005         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
1006         (WebKitDOMDOMWindowTest::create): Ditto.
1007         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1008         (documentLoadedCallback): Use a queue of DelayedSignal objects instead
1009         of smart pointers to DelayedSIgnal objects.
1010         (uriChangedCallback): Ditto.
1011
1012 2015-04-24  Brent Fulgham  <bfulgham@apple.com>
1013
1014         [Mac] Unreviewed test fix.
1015         https://bugs.webkit.org/show_bug.cgi?id=144149
1016
1017         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1018         (TestWebKitAPI::TEST): Temporarily skip the PDF <embed>
1019         test.
1020
1021 2015-04-23  Darin Adler  <darin@apple.com>
1022
1023         Another round of removing use of OwnPtr, PassOwnPtr, and deleteOwnedPtr
1024         https://bugs.webkit.org/show_bug.cgi?id=144090
1025
1026         Reviewed by Anders Carlsson.
1027
1028         * DumpRenderTree/mac/DumpRenderTree.mm: Removed unneeded include.
1029
1030 2015-04-23  Michael Saboff  <msaboff@apple.com>
1031
1032         lldb macro btjs sometimes can't get a frame description
1033         https://bugs.webkit.org/show_bug.cgi?id=144130
1034
1035         Reviewed by Filip Pizlo.
1036
1037         We look to execute ExecState::describeFrame().  It appears that in some contexts the
1038         debugger can't find ExecState.  In those cases, CallFrame works as it is a typedef of
1039         ExecState.  Therefore we can fallback to using CallFrame::describeFrame().
1040
1041         * lldb/lldb_webkit.py:
1042         (btjs):
1043
1044 2015-04-23  Alex Christensen  <achristensen@webkit.org>
1045
1046         Use less memory when compiling content extensions.
1047         https://bugs.webkit.org/show_bug.cgi?id=144051
1048
1049         Reviewed by Darin Adler and Benjamin Poulain.
1050
1051         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1052         (TestWebKitAPI::TEST_F):
1053         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1054         (TestWebKitAPI::countLiveNodes):
1055
1056 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1057
1058         [CMake] Clean up JSC JIT options
1059         https://bugs.webkit.org/show_bug.cgi?id=143998
1060
1061         Reviewed by Filip Pizlo.
1062
1063         * Scripts/build-jsc: Do not use -ENABLE_LLINT_C_LOOP on CMake ports.
1064         * Scripts/webkitperl/FeatureList.pm: Remove ENABLE_LLINT_C_LOOP.
1065
1066 2015-04-21  Brent Fulgham  <bfulgham@apple.com>
1067
1068         [Mac] Extend action menus to support PDF
1069         https://bugs.webkit.org/show_bug.cgi?id=143895
1070         <rdar://problem/19003333>
1071
1072         Reviewed by Tim Horton.
1073
1074         Reactivate the action menu tests, and add a new PDF-based test to make sure that selection
1075         of PDF content works.
1076
1077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new 'test.pdf' resource to bundle.
1078         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Update with a new PDF pane.
1079         * TestWebKitAPI/Tests/WebKit2/test.pdf: Added.
1080         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
1081         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
1082         Update to support PDF tests.
1083         (TestWebKitAPI::windowPointForTarget): Add new target for PDF test.
1084         (TestWebKitAPI::waitForPDFToLoad): New helper function to avoid starting test before the PDF is available.
1085
1086 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1087
1088         Unreviewed. Do not run GTK+ user media unit tests when ENABLE_MEDIA_STREAM is disabled.
1089
1090         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1091         (beforeAll):
1092         (testWebViewAudioOnlyUserMediaPermissionRequests):
1093
1094 2015-04-22  Michael Catanzaro  <mcatanzaro@igalia.com>
1095
1096         Add myself to watchlist
1097         https://bugs.webkit.org/show_bug.cgi?id=144041
1098
1099         Reviewed by Alex Christensen.
1100
1101         Add myself watching CMake, GtkWebKit2PublicAPI, SoupNetwork, and WebKitGTKTranslations.
1102
1103         * Scripts/webkitpy/common/config/watchlist:
1104
1105 2015-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1106
1107         [GTK] MiniBrowser should use NetworkProcess by default
1108         https://bugs.webkit.org/show_bug.cgi?id=143948
1109
1110         Reviewed by Sergio Villar Senin.
1111
1112         Use WEBKIT_PROCESS_MODEL_MULTIPLE_SECONDARY_PROCESSES by default
1113         unless MINIBROWSER_SINGLEPROCESS environment variable is present.
1114
1115         * MiniBrowser/gtk/main.c:
1116         (main):
1117
1118 2015-04-21  Matthew Hanson  <matthew_hanson@apple.com>
1119
1120         Use grep instead of any in prepare-ChangeLog, to avoid Windows compatibility issues.
1121
1122         Unreviewed build fix.
1123
1124         * Scripts/prepare-ChangeLog:
1125         (get_function_line_ranges_for_cpp):
1126         Use grep instead of any to determine if a string is an element of an array.
1127
1128 2015-04-21  Anders Carlsson  <andersca@apple.com>
1129
1130         Fix block signatures
1131         https://bugs.webkit.org/show_bug.cgi?id=144002
1132
1133         Reviewed by Andreas Kling.
1134
1135         * MiniBrowser/mac/WK2BrowserWindowController.m:
1136         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1137
1138 2015-04-21  Philippe Normand  <pnormand@igalia.com>
1139
1140         [GTK] jhbuild should not use a branch for openwebrtc
1141         https://bugs.webkit.org/show_bug.cgi?id=143981
1142
1143         Reviewed by Carlos Garcia Campos.
1144
1145         * gtk/jhbuild.modules:
1146
1147 2015-04-20  Matthew Hanson  <matthew_hanson@apple.com>
1148
1149         Fix compilation error for prepare-ChangeLog running with Perl version < v5.18.2.
1150
1151         Unreviewed build fix.
1152
1153         The any function was added to List::Utils between Perl v5.16.2 and Perl v5.18.2.
1154         However, it has been exposed by List::MoreUtils since its inception. This patch uses
1155         the any function exposed by List::MoreUtils for greater compatibility.
1156
1157         * Scripts/prepare-ChangeLog:
1158         Use any from List::MoreUtils instead of List::Utils, as List::MoreUtils exposes
1159         the any function in all of versions of Perl used by our infrastructure.
1160
1161 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1162
1163         Remove unnecessary logs when resetting tests.
1164
1165         * WebKitTestRunner/mac/TestControllerMac.mm:
1166         (WTR::TestController::platformResetPreferencesToConsistentValues):
1167         In r183020 I added some logs when compiling or removing content extensions fails.
1168         We often try to remove a content extension that does not exist, and that is not a problem.
1169
1170 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1171
1172         prepare-ChangeLog should ignore the preceeding function when processing the removal of a function.
1173         https://bugs.webkit.org/show_bug.cgi?id=143897
1174
1175         Reviewed by David Kilzer.
1176
1177         This is a speculative fix that addresses two issues:
1178
1179         1. An off-by-one error which allowed ending lines to be less than starting lines when a hunk was a pure delete.
1180         We were determining ending lines from combined diffs using the logic: End = Start + Offset - 1.
1181
1182         So for a hunk like "@@ -723,10 +721,0 @@ bool foobar", we were generating the following starting/ending line pairs:
1183         Before: (723, 729)
1184         After: (721, 720)
1185
1186         Before is correct, but After should be (721, 721), since it represents the beginning and ending lines for the hunk.
1187         Whether there are zero lines or one line in the hunk, the starting and ending line are the same.
1188
1189         This error was causing bad behavior on purely additive and purely subtractive hunks, but since we only refer
1190         to After when generating ChangeLog output, the extractLineRangeBeforeChange had no visible effect on program output.
1191
1192         The fix is to set End to the max of Start + Offset - 1 and Start, rather than always using the former.
1193
1194         2. Creating git diffs from HEAD and not origin/master by default.
1195
1196         Hard-coding origin/master into the originalFile command has the disadvantage of causing the diff to fail entirely
1197         when origin/master does not exist, and to do the wrong thing when determining deleted functions/methods.
1198
1199         * Scripts/prepare-ChangeLog:
1200         (originalFile):
1201         Use HEAD instead of origin/master in default Git case.
1202
1203         (generateFunctionLists):
1204         Ensure that the end line is not less than the start line.
1205
1206         (extractLineRangeAfterChange):
1207         Set the end line to the start line if the end line is less than the start line.
1208
1209         (extractLineRangeBeforeChange):
1210         Ditto.
1211
1212 2015-04-17  Matthew Hanson  <matthew_hanson@apple.com>
1213
1214         Suppress warning in prepare-ChangeLog.
1215         https://bugs.webkit.org/show_bug.cgi?id=143882
1216
1217         Reviewed by David Kilzer.
1218
1219         Prune noisy prepare-ChangeLog output by using the List::Util::any function
1220         instead of the deprecated smartmatch operator.
1221
1222         * Scripts/prepare-ChangeLog:
1223         Import the List::Util::any function.
1224
1225         (get_function_line_ranges_for_cpp):
1226         Use the any function instead of smartmatch.
1227
1228 2015-04-20  Anders Carlsson  <andersca@apple.com>
1229
1230         Modify the WKWebsiteDataStore API to take a NSSet of types instead of a bitmask
1231         https://bugs.webkit.org/show_bug.cgi?id=143966
1232
1233         Reviewed by Dan Bernstein.
1234
1235         * MiniBrowser/mac/WK2BrowserWindowController.m:
1236         (dataTypes):
1237         (-[WK2BrowserWindowController fetchWebsiteData:]):
1238         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1239         (-[WK2BrowserWindowController clearWebsiteData:]):
1240
1241 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1242
1243         Fix content extension test flakiness.
1244         https://bugs.webkit.org/show_bug.cgi?id=143950
1245
1246         Reviewed by Brady Eidson.
1247
1248         * WebKitTestRunner/mac/TestControllerMac.mm:
1249         (WTR::TestController::platformResetPreferencesToConsistentValues):
1250         Remove the TestContentExtensions if it exists.
1251         (WTR::TestController::platformConfigureViewForTest):
1252         Log errors in case there are any.
1253
1254 2015-04-20  Alex Christensen  <achristensen@webkit.org>
1255
1256         Properly report errors from _WKUserContentExtensionStore.
1257         https://bugs.webkit.org/show_bug.cgi?id=143808
1258
1259         Reviewed by Darin Adler.
1260
1261         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1262         (TEST_F):
1263
1264 2015-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1265
1266         Add a rule for NetworkCache to watchlist file
1267         https://bugs.webkit.org/show_bug.cgi?id=143945
1268
1269         Reviewed by Sergio Villar Senin.
1270
1271         And add myself to the list of watchers.
1272
1273         * Scripts/webkitpy/common/config/watchlist:
1274
1275 2015-04-19  Darin Adler  <darin@apple.com>
1276
1277         Update RefPtr documentation and deprecation
1278         https://bugs.webkit.org/show_bug.cgi?id=143936
1279
1280         Reviewed by Andreas Kling.
1281
1282         * Scripts/do-webcore-rename: Put in some DeprecatedPassRefPtr renames.
1283
1284 2015-04-19  Yusuke Suzuki  <utatane.tea@gmail.com>
1285
1286         Introduce bytecode intrinsics
1287         https://bugs.webkit.org/show_bug.cgi?id=143926
1288
1289         Reviewed by Filip Pizlo.
1290
1291         Change cpplint to accept emit_intrinsic_XXX.
1292
1293         * Scripts/webkitpy/style/checkers/cpp.py:
1294         (check_identifier_name_in_declaration):
1295
1296 2015-04-18  Simon Fraser  <simon.fraser@apple.com>
1297
1298         Fix lldb_webkit.py to show StringImpls correctly
1299         https://bugs.webkit.org/show_bug.cgi?id=143920
1300
1301         Reviewed by Andreas Kling.
1302         
1303         Update WTFStringImplProvider's is_8bit to use the correct bitmask.
1304
1305         * lldb/lldb_webkit.py:
1306         (WTFStringImplProvider.is_8bit):
1307
1308 2015-04-17  Daniel Bates  <dabates@apple.com>
1309
1310         Not able to build WebKit against iOS Simulator 8.3 SDK
1311         https://bugs.webkit.org/show_bug.cgi?id=143883
1312
1313         Reviewed by David Kilzer.
1314
1315         Copy libraries libWebKitSystemInterfaceIOS{Device, Simulator}8.3.a to the built product directory
1316         so that Xcode uses them.
1317
1318         * Scripts/copy-webkitlibraries-to-product-directory:
1319
1320 2015-04-17  Beth Dakin  <bdakin@apple.com>
1321
1322         Force mouse events should go through normal mouse event handling code paths
1323         https://bugs.webkit.org/show_bug.cgi?id=143749
1324         -and corresponding-
1325         rdar://problem/20472895
1326
1327         Reviewed by Dean Jackson.
1328
1329         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
1330         Since there is not a way to create an NSEventTypePressure from scratch, we 
1331         subclass NSEvent and override all of the critical methods.
1332
1333         * WebKitTestRunner/EventSenderProxy.h:
1334         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1335         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1336         (WTR::EventSendingController::mouseForceDown):
1337         (WTR::EventSendingController::mouseForceUp):
1338         (WTR::EventSendingController::mouseForceChanged):
1339         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1340         * WebKitTestRunner/TestController.cpp:
1341         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1342         * WebKitTestRunner/mac/EventSenderProxy.mm:
1343         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1344         (-[EventSenderPressureEvent timestamp]):
1345         (-[EventSenderPressureEvent type]):
1346         (-[EventSenderPressureEvent locationInWindow]):
1347         (-[EventSenderPressureEvent location]):
1348         (-[EventSenderPressureEvent stage]):
1349         (-[EventSenderPressureEvent pressure]):
1350         (-[EventSenderPressureEvent phase]):
1351         (-[EventSenderPressureEvent eventNumber]):
1352         (WTR::EventSenderProxy::mouseForceDown):
1353         (WTR::EventSenderProxy::mouseForceUp):
1354         (WTR::EventSenderProxy::mouseForceChanged):
1355
1356 2015-04-17  Alexey Proskuryakov  <ap@apple.com>
1357
1358         build.webkit.org/dashboard still shows obsolete results for out of order builds sometimes
1359         https://bugs.webkit.org/show_bug.cgi?id=143885
1360
1361         Reviewed by Tim Horton.
1362
1363         Fixed a case where we have two builds with the same revision(s). An in order build
1364         is one for which the revision is strictly higher.
1365
1366         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1367         (BuildbotQueue.prototype._checkForInOrderResult):
1368         (BuildbotQueue.prototype.compareIterationsByRevisions):
1369
1370 2015-04-17  Commit Queue  <commit-queue@webkit.org>
1371
1372         Unreviewed, rolling out r182912 and r182920.
1373         https://bugs.webkit.org/show_bug.cgi?id=143881
1374
1375         Build breakage in some configurations (Requested by ap on
1376         #webkit).
1377
1378         Reverted changesets:
1379
1380         "Force mouse events should go through normal mouse event
1381         handling code paths"
1382         https://bugs.webkit.org/show_bug.cgi?id=143749
1383         http://trac.webkit.org/changeset/182912
1384
1385         http://trac.webkit.org/changeset/182920
1386
1387 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
1388
1389         [GTK] One more unreviewed fix after r182882.
1390
1391         * TestWebKitAPI/PlatformGTK.cmake: Added back the WebKit2's forwarding header generator dependency.
1392
1393 2015-04-17  Csaba Osztrogonác  <ossy@webkit.org>
1394
1395         [GTK] Unreviewed speculative clean build fix after r182882.
1396
1397         TestWebKitAPI's forwarding header generator depended on WeKit2's
1398         which generated SOUP related forwarding headers too.
1399
1400         This dependency isn't necessary and was removed by r182882 to make
1401         forwarding header generators parallelizable. But in this case
1402         TestWebKitAPI's and WebKitTestRunner's forwarding header generator
1403         should generate SOUP related forwarding headers too similar to EFL.
1404
1405         * TestWebKitAPI/PlatformGTK.cmake:
1406         * WebKitTestRunner/PlatformGTK.cmake:
1407
1408 2015-04-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1409
1410         [SOUP] Redirect to non HTTP destination is broken
1411         https://bugs.webkit.org/show_bug.cgi?id=143866
1412
1413         Reviewed by Sergio Villar Senin.
1414
1415         Add a unit test to check that redirect to a data URI works.
1416
1417         * TestWebKitAPI/Tests/WebKit2Gtk/TestLoaderClient.cpp:
1418         (testRedirectToDataURI):
1419         (serverCallback):
1420         (beforeAll):
1421
1422 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
1423
1424         Changes method of quitting iOS Simulator to be more correct.
1425         https://bugs.webkit.org/show_bug.cgi?id=143847
1426         <rdar://problem/20530344>
1427
1428         Reviewed by Darin Adler.
1429
1430         Fixes by addressing the app by ID rather than by name.
1431
1432         * Scripts/webkitdirs.pm:
1433         (quitIOSSimulator):
1434         * Scripts/webkitpy/port/ios.py:
1435         (IOSSimulatorPort.check_sys_deps):
1436
1437 2015-04-16  Anders Carlsson  <andersca@apple.com>
1438
1439         Deprecate _WKWebsiteDataStore in favor of WKWebsiteDataStore
1440         https://bugs.webkit.org/show_bug.cgi?id=143844
1441
1442         Reviewed by Dan Bernstein.
1443
1444         * MiniBrowser/mac/AppDelegate.m:
1445         (-[BrowserAppDelegate newPrivateWindow:]):
1446         * MiniBrowser/mac/WK2BrowserWindowController.m:
1447         (-[WK2BrowserWindowController initWithConfiguration:]):
1448         (-[WK2BrowserWindowController fetchWebsiteData:]):
1449         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
1450         (-[WK2BrowserWindowController clearWebsiteData:]):
1451
1452 2015-04-16  Alex Christensen  <achristensen@webkit.org>
1453
1454         32-bit build fix.
1455
1456         * WebKitTestRunner/mac/TestControllerMac.mm:
1457         (WTR::TestController::platformResetPreferencesToConsistentValues):
1458         (WTR::TestController::platformConfigureViewForTest):
1459         Added WK_API_ENABLED.
1460
1461 2015-04-16  Alex Christensen  <achristensen@webkit.org>
1462
1463         Removed unused WKUserContentFilterRef.
1464         https://bugs.webkit.org/show_bug.cgi?id=143852
1465
1466         Reviewed by Sam Weinig.
1467
1468         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1469         * WebKitTestRunner/mac/TestControllerMac.mm:
1470         (WTR::TestController::platformResetPreferencesToConsistentValues):
1471         (WTR::TestController::platformConfigureViewForTest):
1472
1473 2015-04-16  Jake Nielsen  <jacob_nielsen@apple.com>
1474
1475         Unreviewed. Adding myself as a commiter in contributers.json.
1476
1477         * Scripts/webkitpy/common/config/contributors.json:
1478
1479 2015-04-16  Alexey Proskuryakov  <ap@apple.com>
1480
1481         It is very hard to attach a debugger to WebProcess to debug tests
1482         https://bugs.webkit.org/show_bug.cgi?id=143837
1483
1484         Reviewed by Chris Dumez.
1485
1486         --no-timeout used to only affect waitUntilDone timeout, but not IPC timeout in
1487         WebKitTestRunner, and not pipe reading timeout in run-webkit-tests.
1488
1489         Now it disables all timeouts in tools, as is best for debugging tests.
1490
1491         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Respect --no-timeout, so
1492         that the script doesn't terminate DRT/WKTR when there is no output for a long time.
1493
1494         * WebKitTestRunner/Options.cpp: Removed --no-timeout-at-all, as --no-timeout
1495         now has the same functionality.
1496
1497 2015-04-16  Beth Dakin  <bdakin@apple.com>
1498
1499         Force mouse events should go through normal mouse event handling code paths
1500         https://bugs.webkit.org/show_bug.cgi?id=143749
1501         -and corresponding-
1502         rdar://problem/20472895
1503
1504         Reviewed by Dean Jackson.
1505
1506         Add mouseForceDown/mouseForceUp/mouseForceChanged support to WebKitTestRunner. 
1507         Since there is not a way to create an NSEventTypePressure from scratch, we 
1508         subclass NSEvent and override all of the critical methods.
1509
1510         * WebKitTestRunner/EventSenderProxy.h:
1511         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
1512         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1513         (WTR::EventSendingController::mouseForceDown):
1514         (WTR::EventSendingController::mouseForceUp):
1515         (WTR::EventSendingController::mouseForceChanged):
1516         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1517         * WebKitTestRunner/TestController.cpp:
1518         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1519         * WebKitTestRunner/mac/EventSenderProxy.mm:
1520         (-[EventSenderPressureEvent initAtLocation:globalLocation:stage:pressure:phase:time:eventNumber:]):
1521         (-[EventSenderPressureEvent timestamp]):
1522         (-[EventSenderPressureEvent type]):
1523         (-[EventSenderPressureEvent locationInWindow]):
1524         (-[EventSenderPressureEvent location]):
1525         (-[EventSenderPressureEvent stage]):
1526         (-[EventSenderPressureEvent pressure]):
1527         (-[EventSenderPressureEvent phase]):
1528         (-[EventSenderPressureEvent eventNumber]):
1529         (WTR::EventSenderProxy::mouseForceDown):
1530         (WTR::EventSenderProxy::mouseForceUp):
1531         (WTR::EventSenderProxy::mouseForceChanged):
1532
1533 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
1534
1535         [EFL] Bump LLVM to version 3.6.0 on X86_64
1536         https://bugs.webkit.org/show_bug.cgi?id=143604
1537
1538         Reviewed by Gyuyoung Kim.
1539
1540         * efl/jhbuild.modules:
1541         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added the necessary part of llvm-elf-add-stackmaps.patch.
1542         * efl/patches/llvm-elf-add-stackmaps.patch: Removed, it is included in LLVM 3.6.0 release.
1543         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Removed, it is included in LLVM 3.6.0 release.
1544         * efl/patches/llvm-version-arm64.patch: Added. Set PACKAGE_VERSION to "3.5.0ftl" to be able to ensure we use patched LLVM on AArch64.
1545
1546 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
1547
1548         [EFL] Remove an unnecessary workaround from jhbuildrc
1549         https://bugs.webkit.org/show_bug.cgi?id=143823
1550
1551         Reviewed by Gyuyoung Kim.
1552
1553         * efl/jhbuildrc:
1554
1555 2015-04-16  Csaba Osztrogonác  <ossy@webkit.org>
1556
1557         [GTK] Run forwarding headers generator unconditionally
1558         https://bugs.webkit.org/show_bug.cgi?id=143819
1559
1560         Reviewed by Carlos Garcia Campos.
1561
1562         * TestWebKitAPI/PlatformGTK.cmake:
1563         * WebKitTestRunner/PlatformGTK.cmake:
1564
1565 2015-04-15  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1566
1567         [EFL] Add gnutls to jhbuild.module
1568         https://bugs.webkit.org/show_bug.cgi?id=143777
1569
1570         Reviewed by Csaba Osztrogonác.
1571
1572         EFL port has required at least 3.0.0 version of gnutls since r176712.
1573         However some old linux distributions don't support 3.0.0 version. Besides
1574         other projects sometimes need to use lower version of gnutls.
1575
1576         This patch supports to download gnutls through jhbuild, and use it.
1577
1578         * efl/install-dependencies: Add nettle-dev dependency and remove libgnutls28-dev. 
1579         * efl/jhbuild.modules: Download 3.3 version because 3.3 version is stable version.
1580
1581 2015-04-15  Mark Lam  <mark.lam@apple.com>
1582
1583         Remove obsolete VMInspector debugging tool.
1584         https://bugs.webkit.org/show_bug.cgi?id=143798
1585
1586         Reviewed by Michael Saboff.
1587
1588         * TestWebKitAPI/CMakeLists.txt:
1589         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
1590         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
1591         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1592         * TestWebKitAPI/Tests/JavaScriptCore/VMInspector.cpp: Removed.
1593
1594 2015-04-15  Jer Noble  <jer.noble@apple.com>
1595
1596         Unreviewed gardening; Make the previous commit apply only _post_ Yosemite.
1597
1598         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1599
1600 2015-04-15  Jer Noble  <jer.noble@apple.com>
1601
1602         Unreviewed gardening; disable FullscreenZoomInitialFrame.WebKit2 API test post-Yosemite.
1603
1604         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1605         (TestWebKitAPI::TEST_F):
1606
1607 2015-04-15  Chris Dumez  <cdumez@apple.com>
1608
1609         [Win] DRT does not seem to reset the 'UsesPageCache' setting between tests
1610         https://bugs.webkit.org/show_bug.cgi?id=143779
1611
1612         Reviewed by Brent Fulgham.
1613
1614         Reset the 'UsesPageCache' setting to FALSE between tests on Windows,
1615         similarly to what is done on Mac / WK1. Without this, PageCache could
1616         stay enabled after page cache tests and cause weird behaviors.
1617
1618         * DumpRenderTree/win/DumpRenderTree.cpp:
1619         (resetWebPreferencesToConsistentValues):
1620
1621 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
1622
1623         Re-enable custom dilation for antialiased fonts
1624         https://bugs.webkit.org/show_bug.cgi?id=143738
1625
1626         Reviewed by Tim Horton.
1627         
1628         Enabling custom dilation for antialised fonts broke layout tests, so re-land it,
1629         but disable in WebKitTestRunner and DumpRenderTree. The latter requires adding
1630         a private WebKit pref. This pref defaults to YES, enabling the feature by default
1631         in WK1 as we do for WK2.
1632
1633         * DumpRenderTree/mac/DumpRenderTree.mm:
1634         (resetWebPreferencesToConsistentValues):
1635         * WebKitTestRunner/TestController.cpp:
1636         (WTR::TestController::resetPreferencesToConsistentValues):
1637
1638 2015-04-14  Brent Fulgham  <bfulgham@apple.com>
1639
1640         Correct layering violation in DumpRenderTree Build
1641         https://bugs.webkit.org/show_bug.cgi?id=143732
1642
1643         Reviewed by Simon Fraser.
1644
1645         Correct a layering violation in DumpRenderTree by calling functions on the
1646         WebCoreTestSupport library, rather than attempting to work with WebCore
1647         types directly.
1648
1649         * DumpRenderTree/mac/EventSendingController.mm:
1650         (-[EventSendingController monitorWheelEvents]): Call methods on WebCoreTestSupport, rather
1651         than WebCore itself.,
1652         (-[EventSendingController callAfterScrollingCompletes:]): Ditto.
1653
1654 2015-04-14  Benjamin Poulain  <benjamin@webkit.org>
1655
1656         Add a conservative DFA minimizer for the content extension matcher
1657         https://bugs.webkit.org/show_bug.cgi?id=143501
1658
1659         Reviewed by Alex Christensen.
1660
1661         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1662         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1663
1664 2015-04-14  Daniel Bates  <dabates@apple.com>
1665
1666         Skip failing test Tests/WebKit2Cocoa/FixedLayoutSize.mm on iOS
1667         https://bugs.webkit.org/show_bug.cgi?id=143693
1668         <rdar://problem/20530316>
1669
1670         Reviewed by Tim Horton.
1671
1672         Skip the test Tests/WebKit2Cocoa/FixedLayoutSize.mm as we do not plan
1673         to use the fixed layout code on iOS at this time.
1674
1675         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Add !PLATFORM(IOS)-guard.
1676
1677 2015-04-14  Dominik Röttsches  <dominik.rottsches@intel.com>
1678
1679         Remove myself from watchlist, remove empty Cairo and HarfBuzz watchlists
1680         https://bugs.webkit.org/show_bug.cgi?id=143705
1681
1682         Unreviewed change to watchlist file.
1683
1684         * Scripts/webkitpy/common/config/watchlist:
1685
1686 2015-04-14  KwangHyuk Kim  <hyuki.kim@samsung.com>
1687
1688         [EFL] favicon wasn't updated for google.com sometimes.
1689         https://bugs.webkit.org/show_bug.cgi?id=141940
1690
1691         Reviewed by Gyuyoung Kim.
1692
1693         As elm_entry_utf8_to_markup can include additional characters, parameter for the
1694         on_icon_changed_cb was just set by using url string retrieved by ewk_view_url_get().
1695
1696         * MiniBrowser/efl/main.c:
1697         (on_url_changed):
1698
1699 2015-04-13  Tim Horton  <timothy_horton@apple.com>
1700
1701         Add a persistent, fixed scale factor to make it easy to scale down WK(Web)Views
1702         https://bugs.webkit.org/show_bug.cgi?id=143560
1703         <rdar://problem/16302047>
1704
1705         Reviewed by Darin Adler.
1706
1707         * MiniBrowser/mac/BrowserWindowController.h:
1708         * MiniBrowser/mac/MainMenu.xib:
1709         * MiniBrowser/mac/WK1BrowserWindowController.m:
1710         (-[WK1BrowserWindowController setScale:]):
1711         * MiniBrowser/mac/WK2BrowserWindowController.m:
1712         (viewScaleForMenuItemTag):
1713         (-[WK2BrowserWindowController setScale:]):
1714         (-[WK2BrowserWindowController validateMenuItem:]):
1715         Add a submenu with four view scale options: 100%, 75%, 50%, and 25%.
1716         When in use, we resize the window so that the view fits correctly, and
1717         use automaticallyComputesFixedlayoutSizeFromViewScale so that the page's
1718         layout size will not change when scaling down (but will update appropriately
1719         when the view is resized).
1720
1721 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
1722
1723         build.webkit.org/dashboard shows obsolete results when builds are substantially out of order
1724         https://bugs.webkit.org/show_bug.cgi?id=138630
1725
1726         Reviewed by Tim Horton.
1727
1728         Make sure that we always load at least one in order productive iteration.
1729
1730         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
1731         (BuildbotQueue): Added _hasLoadedIterationForInOrderResult to track whether the queue
1732         is done loading at least one iteration that wasn't an out of order build.
1733         (BuildbotQueue.prototype.loadMoreHistoricalIterations): Listen for iteration load
1734         when that's needed to check for out of order builds.
1735         (BuildbotQueue.prototype.update): Ditto.
1736         (BuildbotQueue.prototype._checkForInOrderResult): Check if the queue has an in order
1737         result, and if it does not, load more iterations.
1738         (BuildbotQueue.prototype.loadAll): We have everything loaded, so we certainly have
1739         an in order iteration loaded too.
1740         (BuildbotQueue.prototype.compareIterations): Extracted from sortIterations(), and
1741         corrected to always sort loaded iterations before unloaded ones.
1742
1743 2015-04-10  Brent Fulgham  <bfulgham@apple.com>
1744
1745         Expand test infrastructure to support scrolling tests
1746         https://bugs.webkit.org/show_bug.cgi?id=143286
1747         <rdar://problem/20375516>
1748
1749         Reviewed by Simon Fraser.
1750
1751         Extend the WK1 and WK2 test programs to support two new EventSender commands:
1752         (1) monitorWheelEvents: Tells DRT and WKTR to track the wheel event and animation state, so that we can
1753         block executing tests until WebKit has completed any rubberband, scroll, or scroll-snap animations.
1754         (2) callAfterScrollingCompletes: Provide a callback method to be executed when WebKit determines that
1755         relevant rubberband, scroll, and scroll-snap animations are finished.
1756
1757         * DumpRenderTree/mac/EventSendingController.mm:
1758         (+[EventSendingController isSelectorExcludedFromWebScript:]): Update to recognize 'callAfterScrollingCompletes:'
1759         and 'monitorWheelEvents'.
1760         (+[EventSendingController webScriptNameForSelector:]): Ditto.
1761         (-[EventSendingController mouseScrollByX:andY:continuously:]): Add some stderr logging to help when
1762         debugging test failures.
1763         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Ditto.
1764         (-[EventSendingController callAfterScrollingCompletes:]): Added. Protects the JSObject representing the callback
1765         function, then passes it to WebCore to be called once the test deferrals have been cleared.
1766         (-[EventSendingController monitorWheelEvents:]): Added. Activates the wheel event tracking used by the
1767         'callAfterScrollingCompletes' method.
1768         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Added signatures for 'callAfterScrollingCompletes'
1769         and 'monitorWheelEvents'.
1770         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1771         (WTR::EventSendingController::callAfterScrollingCompletes): Added. Protects the JSObject representing the
1772         callback function, then passes it to WebCore to be called once the test deferrals have been cleared
1773         (WTR::EventSendingController::monitorWheelEvents): Added. Activates the wheel event tracking used by the
1774         'callAfterScrollingComplates' method.
1775         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1776
1777 2015-04-13  Alexey Proskuryakov  <ap@apple.com>
1778
1779         build.webkit.org/dashboard: Crash-only queues should show failure when testing fails to start
1780         https://bugs.webkit.org/show_bug.cgi?id=143656
1781
1782         Reviewed by Darin Adler.
1783
1784         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1785         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1786
1787 2015-04-13  Sergio Villar Senin  <svillar@igalia.com>
1788
1789         REGRESSION(r181134): [GTK] Test /webkit2/WebKitWebView/insecure-content is failing after r181134
1790         https://bugs.webkit.org/show_bug.cgi?id=142387
1791
1792         Reviewed by Carlos Garcia Campos.
1793
1794         Running mixed content is blocked by default since r181134. Updated
1795         the test case to reflect the new default settings.
1796
1797         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
1798         (testInsecureContent):
1799
1800 2015-04-13  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1801
1802         Fix wrong value variable in ENABLE_NAVIGATOR_HWCONCURRENCY
1803         https://bugs.webkit.org/show_bug.cgi?id=143667
1804
1805         Reviewed by Csaba Osztrogonác.
1806
1807         ENABLE_NAVIGATOR_HWCONCURRENCY has used $registerProtocolHandlerSupport value variable
1808         since r169017. Added $hardwareConcurrencySupport for it.
1809
1810         Additionally networkInfoSupport is removed because this feature was removed due to spec out.
1811
1812         * Scripts/webkitperl/FeatureList.pm:
1813
1814 2015-04-13  Csaba Osztrogonác  <ossy@webkit.org>
1815
1816         [cmake] Add ENABLE(ATTACHMENT_ELEMENT) to the build system
1817         https://bugs.webkit.org/show_bug.cgi?id=143664
1818
1819         Reviewed by Gyuyoung Kim.
1820
1821         * Scripts/webkitperl/FeatureList.pm:
1822
1823 2015-04-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1824
1825         [EFL] Enable Media Source
1826         https://bugs.webkit.org/show_bug.cgi?id=143635
1827
1828         Reviewed by Csaba Osztrogonác.
1829
1830         * Scripts/webkitperl/FeatureList.pm: Enable media source on efl port.
1831
1832 2015-04-12  Alexey Proskuryakov  <ap@apple.com>
1833
1834         build.webkit.org/dashboard: Crash-only queues should show failure when failure limit is exceeded
1835         https://bugs.webkit.org/show_bug.cgi?id=143646
1836
1837         Reviewed by David Kilzer.
1838
1839         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1840         (BuildbotTesterQueueView.prototype.update.appendBuilderQueueStatus):
1841
1842 2015-04-11  Alexey Proskuryakov  <ap@apple.com>
1843
1844         Use en_US spell checker for tests on Mac instead of Multilingual
1845         https://bugs.webkit.org/show_bug.cgi?id=143641
1846
1847         Reviewed by Dan Bernstein.
1848
1849         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
1850         While at it, override NSUserDictionaryReplacementItems, so that user replacements
1851         cannot affect tests.
1852
1853         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: (WTR::InjectedBundle::platformInitialize):
1854         Made this more like WebKit1 version.
1855
1856 2015-04-10  Tim Horton  <timothy_horton@apple.com>
1857
1858         Replace setFixedLayoutSizeEnabled: with an enum of layout modes
1859         https://bugs.webkit.org/show_bug.cgi?id=143576
1860
1861         Reviewed by Simon Fraser.
1862
1863         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm:
1864         (TEST):
1865         Adopt.
1866
1867 2015-04-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1868
1869         Update my email address and expertise.
1870         https://bugs.webkit.org/show_bug.cgi?id=143586
1871
1872         Unreviewed, just update my info.
1873
1874         * Scripts/webkitpy/common/config/contributors.json:
1875
1876 2015-04-09  Joseph Pecoraro  <pecoraro@apple.com>
1877
1878         Flakiness Dashboard not loading insecure content if loaded with https URL
1879         https://bugs.webkit.org/show_bug.cgi?id=143570
1880
1881         Reviewed by Alexey Proskuryakov.
1882
1883         * TestResultServer/app.yaml:
1884         * TestResultServer/static-dashboards/loader.js:
1885         Switch to https scheme.
1886
1887 2015-04-09  Csaba Osztrogonác  <ossy@webkit.org>
1888
1889         [EFL][GTK] WebKit2's generate-forwarding-headers.pl runs too many times
1890         https://bugs.webkit.org/show_bug.cgi?id=142907
1891
1892         Reviewed by Carlos Garcia Campos.
1893
1894         * TestWebKitAPI/PlatformEfl.cmake:
1895         * TestWebKitAPI/PlatformGTK.cmake:
1896         * WebKitTestRunner/PlatformEfl.cmake:
1897         * WebKitTestRunner/PlatformGTK.cmake:
1898
1899 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1900
1901         [Mac] Unreviewed test fix after r182584
1902         https://bugs.webkit.org/show_bug.cgi?id=143452
1903
1904         Put both of these tests back to their original state now that the underlying
1905         problem is fixed.
1906
1907         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1908         (TestWebKitAPI::TEST):
1909         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1910         (TestWebKitAPI::TEST):
1911
1912 2015-04-08  Filip Pizlo  <fpizlo@apple.com>
1913
1914         run-jsc-benchmarks geomean of preferred means shouldn't print the VMs header twice
1915         https://bugs.webkit.org/show_bug.cgi?id=143553
1916
1917         Reviewed by Ryosuke Niwa.
1918         
1919         Remove the spurious printVMs left over from an earlier change.
1920
1921         * Scripts/run-jsc-benchmarks:
1922
1923 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1924
1925         [Mac] Unreviewed test fix after r182581
1926
1927         The behavior of control-left-click is controlled by a system preference.
1928         Our test bots have this turned off.
1929
1930         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp:
1931         (TestWebKitAPI::TEST):
1932         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
1933         (TestWebKitAPI::TEST):
1934
1935 2015-04-08  Brent Fulgham  <bfulgham@apple.com>
1936
1937         [Mac] WebKit is not honoring OS preferences for secondary click behaviors
1938         https://bugs.webkit.org/show_bug.cgi?id=143452
1939         <rdar://problem/20437483>
1940
1941         Reviewed by Tim Horton.
1942
1943         Add a new API test to confirm that Cocoa mouse button press events are properly
1944         tagged with the desired menu behavior (i.e., 'None', 'Context', or 'Action'.)
1945
1946         The WK2 test dispatches mouse down events to a PlatformWebView, and checks with
1947         some registered event handlers that the expected button press and context menu
1948         events are received.
1949
1950         The WK1 unit test creates an NSEvent with the desired button press state, and then
1951         uses WebCore::PlatformEventFactory::createPlatformMouseEvent to create a WebCore event.
1952         We check the resulting PlatformMouseEvent for proper state.
1953
1954         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new test files.
1955         * TestWebKitAPI/Tests/WebKit2/MenuTypesForMouseEvents.cpp: Added.
1956         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1957         * TestWebKitAPI/Tests/WebKit2/mouse-button-listener.html: Added.
1958         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm: Added.
1959         (TestWebKitAPI::canCallMenuTypeForEvent): Helper function.
1960         (TestWebKitAPI::buildAndPerformTest): Helper function to build/run an individual test.
1961         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
1962         (TestWebKitAPI::PlatformWebView::simulateButtonClick): Added method to support firing
1963         mouse down events.
1964         * TestWebKitAPI/mac/PlatformWebViewMac.h:
1965
1966 2015-04-08  Michael Catanzaro  <mcatanzaro@igalia.com>
1967
1968         [GTK] Add pango to jhbuild-optional.modules
1969         https://bugs.webkit.org/show_bug.cgi?id=143537
1970
1971         Reviewed by Martin Robinson.
1972
1973         * gtk/jhbuild-optional.modules: Add pango.
1974
1975 2015-04-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1976
1977         [XvfbDriver] Regular expression used to match running X servers fails on Fedora 22.
1978         https://bugs.webkit.org/show_bug.cgi?id=143530
1979
1980         Reviewed by Žan Doberšek.
1981
1982         Assume that the default value for display (:0) is reserved and start checking on :1
1983         Adjust webkitpy test and include two new test cases for this bug (display number not specified)
1984         and for X server named Xorg.bin (previous bug 1376599)
1985
1986         * Scripts/webkitpy/port/xvfbdriver.py:
1987         (XvfbDriver._next_free_display)
1988         * Scripts/webkitpy/port/xvfbdriver_unittest.py:
1989         (XvfbDriverTest.test_start_no_pixel_tests):
1990         (XvfbDriverTest.test_start_pixel_tests):
1991         (XvfbDriverTest.test_start_arbitrary_worker_number):
1992         (XvfbDriverTest.test_next_free_display):
1993         (XvfbDriverTest.test_start_next_worker):
1994 2015-04-08  Alex Christensen  <achristensen@webkit.org>
1995
1996         Block popups from content extensions.
1997         https://bugs.webkit.org/show_bug.cgi?id=143497
1998
1999         Reviewed by Brady Eidson.
2000
2001         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2002         (TestWebKitAPI::TEST_F):
2003         Added popup test.
2004
2005 2015-04-08  Alex Christensen  <achristensen@webkit.org> and Patrick Gansterer  <paroga@webkit.org>
2006
2007         Add CMake build system for WinCairo port.
2008         https://bugs.webkit.org/show_bug.cgi?id=115944
2009
2010         Reviewed by Chris Dumez.
2011
2012         * CMakeLists.txt:
2013         * WinLauncher/CMakeLists.txt: Added.
2014
2015 2015-04-08  Carlos Garcia Campos  <cgarcia@igalia.com>
2016
2017         [GTK] Crash in DOMObjectCache when a wrapped object owned by the cache is unreffed by the user
2018         https://bugs.webkit.org/show_bug.cgi?id=143521
2019
2020         Reviewed by Martin Robinson.
2021
2022         Add a way to detect unexpected web process crashes to WebViewTest,
2023         and a test case to testDOMCache to trigger the crash.
2024
2025         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2026         (WebKitDOMNodeTest::testDOMCache):
2027         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
2028         (testWebKitWebViewProcessCrashed):
2029         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2030         (WebViewTest::WebViewTest):
2031         (WebViewTest::webProcessCrashed):
2032         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2033
2034 2015-04-07  Alexey Proskuryakov  <ap@apple.com>
2035
2036         PageVisibilityStateWithWindowChanges should only be enabled on Yosemite
2037         rdar://problem/20461342
2038
2039         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2040
2041 2015-04-07  Commit Queue  <commit-queue@webkit.org>
2042
2043         Unreviewed, rolling out r182511.
2044         https://bugs.webkit.org/show_bug.cgi?id=143507
2045
2046         caused debug test failures (Requested by alexchristensen on
2047         #webkit).
2048
2049         Reverted changeset:
2050
2051         "Block popups from content extensions."
2052         https://bugs.webkit.org/show_bug.cgi?id=143497
2053         http://trac.webkit.org/changeset/182511
2054
2055 2015-04-07  Alex Christensen  <achristensen@webkit.org>
2056
2057         Block popups from content extensions.
2058         https://bugs.webkit.org/show_bug.cgi?id=143497
2059
2060         Reviewed by Brady Eidson.
2061
2062         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2063         (TestWebKitAPI::TEST_F):
2064         Added popup test.
2065
2066 2015-04-07  Benjamin Poulain  <benjamin@webkit.org>
2067
2068         Get the features.json files ready for open contributions
2069         https://bugs.webkit.org/show_bug.cgi?id=143436
2070
2071         Reviewed by Darin Adler.
2072
2073         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2074         (JSONFeaturesChecker.check):
2075         Extend the syntax checking a bit, but leave everything non-mandatory
2076         very loose until we figure what fields are important.
2077
2078 2015-04-07  Tim Horton  <timothy_horton@apple.com>
2079
2080         Expose and test fixedLayoutSize via modern WebKit SPI
2081         https://bugs.webkit.org/show_bug.cgi?id=143500
2082
2083         Reviewed by Simon Fraser.
2084
2085         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2086         * TestWebKitAPI/Tests/WebKit2Cocoa/FixedLayoutSize.mm: Added.
2087         (-[FixedLayoutSizeNavigationDelegate webView:didFinishNavigation:]):
2088         (TEST):
2089         Add a test that verifies that fixedLayoutSize works at all, that
2090         it persists through a navigation, and that turning it back off reverts to
2091         laying out at the size of the view.
2092
2093 2015-04-07  Michael Catanzaro  <mcatanzaro@igalia.com>
2094
2095         Unreviewed. Add myself as a committer.
2096
2097         * Scripts/webkitpy/common/config/contributors.json:
2098
2099 2015-04-07  Brent Fulgham  <bfulgham@apple.com>
2100
2101         [Win] Bots complain about missing /etc/catalog
2102         https://bugs.webkit.org/show_bug.cgi?id=143484
2103
2104         Reviewed by Chris Dumez.
2105
2106         The libxml2 build on Mac, iOS, and Windows does not provide the set
2107         of default catalog files. We do not actually need these for our
2108         purposes, but we get warnings and some bot flakiness because they
2109         are not present.
2110
2111         We can avoid both problems the same way the Mac and iOS ports do,
2112         by setting the XML_CATALOG_FILES environment variable to 'empty string',
2113         which avoid the warnings and bot problems.
2114
2115         * Scripts/webkitpy/port/win.py:
2116         (WinPort.setup_environ_for_server): Added.
2117
2118 2015-04-06  Sam Weinig  <sam@webkit.org>
2119
2120         Use content extensions in MiniBrowser.
2121         https://bugs.webkit.org/show_bug.cgi?id=143446
2122
2123         Reviewed by Alex Christensen.
2124
2125         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2126         * MiniBrowser/mac/AppDelegate.h:
2127         * MiniBrowser/mac/AppDelegate.m:
2128         (-[BrowserAppDelegate init]):
2129         (-[BrowserAppDelegate showExtensionsManager:]):
2130         (-[BrowserAppDelegate userContentContoller]):
2131         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2132         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2133         (-[ExtensionManagerWindowController init]):
2134         (-[ExtensionManagerWindowController windowDidLoad]):
2135         (-[ExtensionManagerWindowController add:]):
2136         (-[ExtensionManagerWindowController remove:]):
2137         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2138         * MiniBrowser/mac/MainMenu.xib:
2139
2140 2015-04-07  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2141
2142         web-platform-tests server should retrieve the modules file relatively to its docroot path
2143         https://bugs.webkit.org/show_bug.cgi?id=142742
2144
2145         Reviewed by Darin Adler.
2146
2147         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2148         (WebPlatformTestServer._install_modules): Compute the modules description file path according wpt server doc root path.
2149
2150 2015-04-06  Commit Queue  <commit-queue@webkit.org>
2151
2152         Unreviewed, rolling out r182445.
2153         https://bugs.webkit.org/show_bug.cgi?id=143459
2154
2155         broke 32 bit build (Requested by alexchristensen on #webkit).
2156
2157         Reverted changeset:
2158
2159         "Use content extensions in MiniBrowser."
2160         https://bugs.webkit.org/show_bug.cgi?id=143446
2161         http://trac.webkit.org/changeset/182445
2162
2163 2015-04-06  Sam Weinig  <sam@webkit.org>
2164
2165         Use content extensions in MiniBrowser.
2166         https://bugs.webkit.org/show_bug.cgi?id=143446
2167
2168         Reviewed by Alex Christensen.
2169
2170         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
2171         * MiniBrowser/mac/AppDelegate.h:
2172         * MiniBrowser/mac/AppDelegate.m:
2173         (-[BrowserAppDelegate init]):
2174         (-[BrowserAppDelegate showExtensionsManager:]):
2175         (-[BrowserAppDelegate userContentContoller]):
2176         * MiniBrowser/mac/ExtensionManagerWindowController.h: Added.
2177         * MiniBrowser/mac/ExtensionManagerWindowController.m: Added.
2178         (-[ExtensionManagerWindowController init]):
2179         (-[ExtensionManagerWindowController windowDidLoad]):
2180         (-[ExtensionManagerWindowController add:]):
2181         (-[ExtensionManagerWindowController remove:]):
2182         * MiniBrowser/mac/ExtensionManagerWindowController.xib: Added.
2183         * MiniBrowser/mac/MainMenu.xib:
2184
2185 2015-04-06  Michael Catanzaro  <mcatanzaro@gnome.org>
2186
2187         [GTK] install-dependencies should prefer dnf to yum
2188         https://bugs.webkit.org/show_bug.cgi?id=143441
2189
2190         Reviewed by Martin Robinson.
2191
2192         Test for the existance of dnf before yum, and only try to use yum if dnf does not exist.
2193
2194         * gtk/install-dependencies:
2195
2196 2015-04-06  Andy Estes  <aestes@apple.com>
2197
2198         [iOS] 'make clean' fails in Tools/WebKitTestRunner
2199         https://bugs.webkit.org/show_bug.cgi?id=143455
2200
2201         Reviewed by Dan Bernstein.
2202
2203         This Makefile adds '-target WebKitTestRunnerApp' to OTHER_OPTIONS during iOS builds, but the top-level
2204         Makefile.shared adds '-alltargets' for clean builds, and xcodebuild does not allow both -target and -alltargets.
2205
2206         * WebKitTestRunner/Makefile: Don't add '-target WebKitTestRunerApp' to OTHER_OPTIONS on clean builds.
2207
2208 2015-04-06  Alexey Proskuryakov  <ap@apple.com>
2209
2210         WebKit1.SetAndUpdateCacheModelPreferencesChangeMix fails on some machines
2211         https://bugs.webkit.org/show_bug.cgi?id=143450
2212
2213         Reviewed by Anders Carlsson.
2214
2215         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm: (TestWebKitAPI::TEST):
2216         Make sure that the view is actually closed, regardless of anything else that happens beneath.
2217         Also, removed unnecessary get() calls.
2218
2219 2015-04-03  Alexey Proskuryakov  <ap@apple.com>
2220
2221         Reduce the dependency on Flash in regression tests
2222         https://bugs.webkit.org/show_bug.cgi?id=143391
2223
2224         Reviewed by Anders Carlsson.
2225
2226         * WebKitTestRunner/TestController.cpp: (WTR::TestController::decidePolicyForPluginLoad):
2227         Only allow QuickTime and the test plug-in.
2228
2229 2015-04-06  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2230
2231         W3C test importer should generate the modules installed dynamically to run wpt tests
2232         https://bugs.webkit.org/show_bug.cgi?id=142738
2233
2234         Reviewed by Ryosuke Niwa.
2235
2236         The test importer can now generate the submodules description file based on information extracted from the corresponding git repository.
2237         The implementation is done within TestDownloader and it is activated for the WPT repository.
2238         LayoutTests/imported/w3c/resources/WPTModules is renamed as LayoutTests/imported/w3c/resources/web-platform-tests-modules.json for that reason.
2239
2240         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
2241         (WebPlatformTestServer._install_modules): Updated to cope with path as array.
2242         * Scripts/webkitpy/w3c/test_downloader.py:
2243         (TestDownloader._git_submodules_status): Added so that it can be overriden for unit tests.
2244         (TestDownloader):
2245         (TestDownloader._git_submodules_description): Computes submodule description.
2246         (TestDownloader.generate_git_submodules_description): Write submodule description in a file.
2247         * Scripts/webkitpy/w3c/test_importer.py:
2248         (TestImporter.do_import): Added the possibility to post process the tests.
2249         (TestImporter):
2250         (TestImporter.generate_git_submodules_description_for_all_repositories): Enable generating module description file.
2251         (TestImporter.should_convert_test_harness_links): Updated according new options format.
2252         * Scripts/webkitpy/w3c/test_importer_unittest.py:
2253         (TestImporterTest.import_downloaded_tests): Making use of TestDownloaderMock. 
2254         (TestImporterTest.import_downloaded_tests.TestDownloaderMock): Added to override submodule status gathering.
2255         (TestImporterTest.import_downloaded_tests.TestDownloaderMock.__init__):
2256         (TestImporterTest.import_downloaded_tests.TestDownloaderMock._git_submodules_status):
2257         (TestImporterTest.test_submodules_generation): Added to check that modules description files works.
2258
2259 2015-04-05  Antti Koivisto  <antti@apple.com>
2260
2261         Bloom filter should support longer hashes
2262         https://bugs.webkit.org/show_bug.cgi?id=143419
2263
2264         Reviewed by Dan Bernstein.
2265
2266         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp:
2267         (TestWebKitAPI::generateRandomDigests):
2268         (TestWebKitAPI::TEST):
2269
2270 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2271
2272         run-jsc-stress-tests --remote should add libllvmForJSC.so to the bundle on Linux
2273         https://bugs.webkit.org/show_bug.cgi?id=143372
2274
2275         Reviewed by Darin Adler.
2276
2277         * Scripts/run-jsc-stress-tests:
2278
2279 2015-04-03  Antti Koivisto  <antti@apple.com>
2280
2281         Add non-counting bloom filter class
2282         https://bugs.webkit.org/show_bug.cgi?id=143366
2283
2284         Reviewed by Sam Weinig.
2285
2286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2287         * TestWebKitAPI/Tests/WTF/BloomFilter.cpp: Added.
2288         (TestWebKitAPI::generateRandomHashes):
2289         (TestWebKitAPI::TEST):
2290
2291 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2292
2293         FTL JIT tests should fail if LLVM library isn't available
2294         https://bugs.webkit.org/show_bug.cgi?id=143374
2295
2296         Reviewed by Mark Lam.
2297
2298         * Scripts/run-jsc-stress-tests:
2299
2300 2015-04-03  Csaba Osztrogonác  <ossy@webkit.org>
2301
2302         [EFL] Speedup jhbuild with disable running autogen.sh
2303         https://bugs.webkit.org/show_bug.cgi?id=143369
2304
2305         Reviewed by Gyuyoung Kim.
2306
2307         * efl/jhbuild.modules:
2308
2309 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
2310
2311         filter-webkit-build should filter out "created by an unsupported XCDependencyGraph build" lines
2312         https://bugs.webkit.org/show_bug.cgi?id=143282
2313
2314         Reviewed by Daniel Bates.
2315
2316         * Scripts/filter-build-webkit: (shouldIgnoreLine): Do it.
2317
2318 2015-04-01  Alexey Proskuryakov  <ap@apple.com>
2319
2320         When LayoutTestHelper fails to start, we continue to run the tests, ending up with mysterious failures
2321         https://bugs.webkit.org/show_bug.cgi?id=143240
2322         rdar://problem/19990425
2323
2324         Reviewed by Tim Horton.
2325
2326         * DumpRenderTree/mac/LayoutTestHelper.m:
2327         (colorProfileURLForDisplay):
2328         (saveDisplayColorProfiles):
2329         Gracefully handle it when the current profile cannot be retrieved, fixing at
2330         least one case when LayoutTestHelper couldn't start.
2331
2332         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2333         (Manager._set_up_run):
2334         (Manager._force_pixel_tests_if_needed):
2335         * Scripts/webkitpy/port/base.py: (Port.to.start_helper):
2336         * Scripts/webkitpy/port/mac.py: (MacPort.start_helper):
2337         Return and check an error from start_helper().
2338
2339 2015-04-01  Brent Fulgham  <bfulgham@apple.com>
2340
2341         [Win] Run test-webkitpy as part of EWS (just like we do on other platforms)
2342         https://bugs.webkit.org/show_bug.cgi?id=143321
2343
2344         Reviewed by Alexey Proskuryakov.
2345
2346         * EWSTools/start-queue-win.sh: Add commands to run 'test-webkitpy' during processing loop.
2347
2348 2015-04-01  Enrica Casucci  <enrica@apple.com>
2349
2350         Injected bundle messages should be at the page level.
2351         https://bugs.webkit.org/show_bug.cgi?id=143283
2352
2353         Reviewed by Alexey Proskuryakov.
2354
2355         Updating WebKitTestRunner to use the new page level messaging.
2356         The author of this patch is Tim Horton, I just finished it.
2357
2358         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
2359         (WTR::EventSendingController::mouseDown):
2360         (WTR::EventSendingController::mouseUp):
2361         (WTR::EventSendingController::mouseMoveTo):
2362         (WTR::EventSendingController::leapForward):
2363         (WTR::EventSendingController::scheduleAsynchronousClick):
2364         (WTR::EventSendingController::keyDown):
2365         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
2366         (WTR::EventSendingController::mouseScrollBy):
2367         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
2368         (WTR::EventSendingController::continuousMouseScrollBy):
2369         (WTR::EventSendingController::addTouchPoint):
2370         (WTR::EventSendingController::updateTouchPoint):
2371         (WTR::EventSendingController::setTouchModifier):
2372         (WTR::EventSendingController::setTouchPointRadius):
2373         (WTR::EventSendingController::touchStart):
2374         (WTR::EventSendingController::touchMove):
2375         (WTR::EventSendingController::touchEnd):
2376         (WTR::EventSendingController::touchCancel):
2377         (WTR::EventSendingController::clearTouchPoints):
2378         (WTR::EventSendingController::releaseTouchPoint):
2379         (WTR::EventSendingController::cancelTouchPoint):
2380         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2381         (WTR::InjectedBundle::didReceiveMessage):
2382         (WTR::InjectedBundle::didReceiveMessageToPage):
2383         (WTR::InjectedBundle::done):
2384         (WTR::InjectedBundle::outputText):
2385         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
2386         (WTR::InjectedBundle::postAddChromeInputField):
2387         (WTR::InjectedBundle::postRemoveChromeInputField):
2388         (WTR::InjectedBundle::postFocusWebView):
2389         (WTR::InjectedBundle::postSetBackingScaleFactor):
2390         (WTR::InjectedBundle::postSetWindowIsKey):
2391         (WTR::InjectedBundle::postSimulateWebNotificationClick):
2392         (WTR::InjectedBundle::postSetAddsVisitedLinks):
2393         (WTR::InjectedBundle::setGeolocationPermission):
2394         (WTR::InjectedBundle::setMockGeolocationPosition):
2395         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
2396         (WTR::InjectedBundle::setUserMediaPermission):
2397         (WTR::InjectedBundle::setCustomPolicyDelegate):
2398         (WTR::InjectedBundle::setHidden):
2399         (WTR::InjectedBundle::setCacheModel):
2400         (WTR::InjectedBundle::shouldProcessWorkQueue):
2401         (WTR::InjectedBundle::processWorkQueue):
2402         (WTR::InjectedBundle::queueBackNavigation):
2403         (WTR::InjectedBundle::queueForwardNavigation):
2404         (WTR::InjectedBundle::queueLoad):
2405         (WTR::InjectedBundle::queueLoadHTMLString):
2406         (WTR::InjectedBundle::queueReload):
2407         (WTR::InjectedBundle::queueLoadingScript):
2408         (WTR::InjectedBundle::queueNonLoadingScript):
2409         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2410         (WTR::TestRunner::setHandlesAuthenticationChallenges):
2411         (WTR::TestRunner::setAuthenticationUsername):
2412         (WTR::TestRunner::setAuthenticationPassword):
2413         (WTR::TestRunner::secureEventInputIsEnabled):
2414         (WTR::TestRunner::setBlockAllPlugins):
2415         * WebKitTestRunner/TestController.cpp:
2416         (WTR::TestController::createWebViewWithOptions):
2417         (WTR::TestController::resetStateToConsistentValues):
2418         (WTR::TestController::didReceivePageMessageFromInjectedBundle):
2419         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle):
2420         * WebKitTestRunner/TestController.h:
2421         * WebKitTestRunner/TestInvocation.cpp:
2422         (WTR::TestInvocation::invoke):
2423         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2424
2425 2015-04-01  Commit Queue  <commit-queue@webkit.org>
2426
2427         Unreviewed, rolling out r182174 and r182177.
2428         https://bugs.webkit.org/show_bug.cgi?id=143314
2429
2430         Try to correct EWS failures (Requested by bfulgham on
2431         #webkit).
2432
2433         Reverted changesets:
2434
2435         "Python SCM should be able to retrieve untracked files"
2436         https://bugs.webkit.org/show_bug.cgi?id=143135
2437         http://trac.webkit.org/changeset/182174
2438
2439         "[buildbot] clean-build script should remove untracked files
2440         and revert local changes too"
2441         https://bugs.webkit.org/show_bug.cgi?id=142400
2442         http://trac.webkit.org/changeset/182177
2443
2444 2015-04-01  Alex Christensen  <achristensen@webkit.org>
2445
2446         [Content Extensions] Properly handle regexes that match everything.
2447         https://bugs.webkit.org/show_bug.cgi?id=143281
2448
2449         Reviewed by Benjamin Poulain.
2450
2451         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2452         (TestWebKitAPI::testRequest):
2453         (TestWebKitAPI::makeBackend):
2454         (TestWebKitAPI::TEST_F):
2455         Removed duplicate code and added test.
2456
2457 2015-03-31  Benjamin Poulain  <bpoulain@apple.com>
2458
2459         Content Extensions: split the state machines to minimize prefix states
2460         https://bugs.webkit.org/show_bug.cgi?id=143253
2461
2462         Reviewed by Alex Christensen.
2463
2464         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2465         (TestWebKitAPI::TEST_F):
2466         (TestWebKitAPI::testPatternStatus):
2467
2468 2015-03-31  Yusuke Suzuki  <utatane.tea@gmail.com>
2469
2470         Clean up Identifier factories to clarify the meaning of StringImpl*
2471         https://bugs.webkit.org/show_bug.cgi?id=143146
2472
2473         Reviewed by Filip Pizlo.
2474
2475         Simple API tests for StringImpl are added.
2476
2477         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2478         (TestWebKitAPI::TEST):
2479
2480 2015-03-31  Csaba Osztrogonác  <ossy@webkit.org>
2481
2482         [EFL] Add AArch64 builder and tester bot to build.webkit.org
2483         https://bugs.webkit.org/show_bug.cgi?id=143092
2484
2485         Reviewed by Gyuyoung Kim.
2486
2487         * BuildSlaveSupport/build.webkit.org-config/config.json:
2488         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2489         (Factory.__init__):
2490         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2491
2492 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2493
2494         [buildbot] clean-build script should remove untracked files and revert local changes too
2495         https://bugs.webkit.org/show_bug.cgi?id=142400
2496
2497         Reviewed by Ryosuke Niwa.
2498
2499         This patch cleans the WebKit folder by reverting tracked files changes and deleting SCM untracked files, including SCM ignored files.
2500         A helper routine SCM.discard_untracked_files is added for that purpose.
2501
2502         * BuildSlaveSupport/clean-build:
2503         (main): Making call to Scripts/clean-webkit
2504         * Scripts/clean-webkit: Added.
2505         (main): Revert changes and delete untracked files.
2506         * Scripts/webkitpy/common/checkout/scm/scm.py:
2507         (SCM.discard_untracked_files): Helper function to discard untracked files or folders found by SCM.
2508         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2509         (SCMTest._shared_test_discard_untracked_files):
2510         (test_discard_untracked_files): Tests that untracked file and untracked folder get discarded correctly.
2511
2512 2015-03-31  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2513
2514         Python SCM should be able to retrieve untracked files
2515         https://bugs.webkit.org/show_bug.cgi?id=143135
2516
2517         Reviewed by Ryosuke Niwa.
2518
2519         This patch introduces SCM.untracked_files to retrieve a list of untracked files.
2520         Ignored files may be included or not in this list according boolean passed to the function.
2521
2522         * Scripts/webkitpy/common/checkout/scm/git.py:
2523         (Git.untracked_files):
2524         * Scripts/webkitpy/common/checkout/scm/scm.py:
2525         (SCM.untracked_files):
2526         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2527         (SCMTest._shared_test_untracked_files):
2528         (test_untracked_files):
2529         (GitSVNTest.test_untracked_files):
2530         * Scripts/webkitpy/common/checkout/scm/svn.py:
2531         (SVN.untracked_files):
2532
2533 2015-03-30  Alex Christensen  <achristensen@webkit.org>
2534
2535         [Content Extensions] Correctly handle regular expressions matching everything
2536         https://bugs.webkit.org/show_bug.cgi?id=143235
2537
2538         Reviewed by Benjamin Poulain.
2539
2540         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2541         (TestWebKitAPI::checkCompilerError):
2542         (TestWebKitAPI::TEST_F):
2543         Test ContentExtensionErrors.
2544
2545 2015-03-30  Alexey Proskuryakov  <ap@apple.com>
2546
2547         DumpRenderTree should set NSWindowDisplayWithRunLoopObserver
2548         https://bugs.webkit.org/show_bug.cgi?id=143241
2549         rdar://problem/20351297
2550
2551         Reviewed by Mark Lam.
2552
2553         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2554
2555 2015-03-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2556
2557         [CMake][EFL] Remove redundant library link and include path
2558         https://bugs.webkit.org/show_bug.cgi?id=143221
2559
2560         Reviewed by Csaba Osztrogonác.
2561
2562         * ImageDiff/PlatformEfl.cmake: Remove unnecessary library link and include path.
2563
2564 2015-03-30  Sam Weinig  <sam@webkit.org>
2565
2566         [Content Extensions] Flesh out the UserContentExtensionStore
2567         https://bugs.webkit.org/show_bug.cgi?id=143123
2568
2569         Reviewed by Benjamin Poulain.
2570
2571         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2572         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm: Added.
2573         Add tests for _WKUserContentExtensionStore.
2574
2575 2015-03-30  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
2576
2577         Update install-dependencies Fedora packages after r181624
2578         https://bugs.webkit.org/show_bug.cgi?id=143215
2579
2580         Add json-glib, libv4l, openssl and pulseaudio development packages to
2581         the Fedora list providing we need them to build WebKit dependencies
2582         for this distribution.
2583
2584         Reviewed by Philippe Normand.
2585
2586         * gtk/install-dependencies:
2587
2588 2015-03-30  Commit Queue  <commit-queue@webkit.org>
2589
2590         Unreviewed, rolling out r182119.
2591         https://bugs.webkit.org/show_bug.cgi?id=143196
2592
2593         problem with syntax (Requested by youenn on #webkit).
2594
2595         Reverted changeset:
2596
2597         "[buildbot] clean-build script should remove untracked files
2598         and revert local changes too"
2599         https://bugs.webkit.org/show_bug.cgi?id=142400
2600         http://trac.webkit.org/changeset/182119
2601
2602 2015-03-30  Benjamin Poulain  <benjamin@webkit.org>
2603
2604         Start the features.json files
2605         https://bugs.webkit.org/show_bug.cgi?id=143207
2606
2607         Reviewed by Darin Adler.
2608
2609         I kept the style checking light. We'll have to figure
2610         what is the best format for each field.
2611
2612         * Scripts/webkitpy/style/checker.py:
2613         (CheckerDispatcher._create_checker):
2614         * Scripts/webkitpy/style/checkers/jsonchecker.py:
2615         (JSONContributorsChecker.check):
2616         (JSONFeaturesChecker):
2617         (JSONFeaturesChecker.check):
2618
2619 2015-03-29  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2620
2621         [buildbot] clean-build script should remove untracked files and revert local changes too
2622         https://bugs.webkit.org/show_bug.cgi?id=142400
2623
2624         Reviewed by Ryosuke Niwa.
2625
2626         This patch cleans the WebKit folder by deleting SCM untracked files and reverting changes for tracked files.
2627
2628         * BuildSlaveSupport/clean-build:
2629         (main): Adding call to Tools/Scripts/clean-webkit.
2630         * Scripts/clean-webkit: Added.
2631         (main): Removes untracked and changed files.
2632         * Scripts/webkitpy/common/checkout/scm/git.py:
2633         (Git.untracked_files): Retrieves GIT untracked files.
2634         * Scripts/webkitpy/common/checkout/scm/scm.py:
2635         (SCM.untracked_files): Retrieves SVN untracked files.
2636         (SCM):
2637         (SCM.discard_untracked_files): Deletes untracked files/folders.
2638         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
2639         (SCMTest._shared_test_untracked_files): Unit testing for untracked files.
2640         (test_untracked_files):
2641         (GitSVNTest.test_untracked_files):
2642         * Scripts/webkitpy/common/checkout/scm/svn.py:
2643         (SVN.untracked_files):
2644
2645 2015-03-27  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2646
2647         [CMake] Remove unnecessary INCLUDE_IF_EXISTS macro 
2648         https://bugs.webkit.org/show_bug.cgi?id=143138
2649
2650         Reviewed by Csaba Osztrogonác.
2651
2652         INCLUDE_IF_EXISTS isn't used except for 2 places. However those uses can
2653         be replaced with WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS.
2654
2655         * ImageDiff/CMakeLists.txt:
2656         Use WEBKIT_INCLUDE_CONFIG_FILES_IF_EXISTS() instead of INCLUDE_IF_EXISTS.
2657         * WebKitTestRunner/CMakeLists.txt: ditto.
2658
2659 2015-03-27  Myles C. Maxfield  <mmaxfield@apple.com>
2660
2661         Support building WTF on Windows without Cygwin
2662         https://bugs.webkit.org/show_bug.cgi?id=143084
2663
2664         Reviewed by Brent Fulgham.
2665
2666         Windows without Cygwin doesn't have curl, unzip, or grep. Luckily, Perl does all of these things.
2667         This patch also migrates to using File::Spec->catfile() for directory separators.
2668
2669         * Scripts/update-webkit-dependency:
2670         (wanted):
2671         * Scripts/update-webkit-support-libs:
2672         (wanted):
2673         (downloadExpectedVersionNumber):
2674         (zipFileVersion):
2675         (toUnixPath): Deleted.
2676         * Scripts/webkitdirs.pm:
2677         (determineSourceDir):
2678         (windowsSourceSourceDir):
2679         (windowsLibrariesDir):
2680         (windowsOutputDir):
2681         (checkInstalledTools):
2682         (buildVisualStudioProject):
2683
2684 2015-03-27  Alex Christensen  <achristensen@webkit.org>
2685
2686         Fix WinCairo bot.
2687         https://bugs.webkit.org/show_bug.cgi?id=143086
2688
2689         Reviewed by Brent Fulgham.
2690
2691         * Scripts/webkitdirs.pm:
2692         (buildVisualStudioProject):
2693         (runSvnUpdateAndResolveChangeLogs):
2694         Use ActivePerl-friendly perl.
2695
2696 2015-03-27  Csaba Osztrogonác  <ossy@webkit.org>
2697
2698         URTBF after r182059 to fix the EFL build.
2699
2700         * TestWebKitAPI/CMakeLists.txt:
2701
2702 2015-03-26  Alexey Proskuryakov  <ap@apple.com>
2703
2704         Layout test results URL loads in WK1 but not WK2 minibrowser
2705         https://bugs.webkit.org/show_bug.cgi?id=143117
2706
2707         Reviewed by Tim Horton.
2708
2709         * MiniBrowser/mac/WK2BrowserWindowController.m:
2710         (-[WK2BrowserWindowController fetch:]): Fix this, international domain names, and
2711         everything.
2712         (-[WK2BrowserWindowController updateTextFieldFromURL:]): Ditto.
2713
2714 2015-03-26  Jer Noble  <jer.noble@apple.com>
2715
2716         Add --allowed-host support to run-webkit-tests
2717         https://bugs.webkit.org/show_bug.cgi?id=142938
2718
2719         Reviewed by Brent Fulgham.
2720
2721         Accept --allowed-host arguments from run-webkit-tests and pass them through to
2722         DumpRenderTree and WebKitTestRunner.
2723
2724         Drive-by fix: Depending on the value of the --layout-test-dir parameter, layout test results
2725         are placed in the wrong location. The argument is compared with each tests's path, and if a
2726         relative path or a path with '..' was used, results are placed alongside the test. Take the
2727         absolute path of the --layout-test-dir argument, collapsing path components like '..'.
2728
2729         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2730         (parse_args):
2731         * Scripts/webkitpy/port/base.py:
2732         (Port.__init__):
2733         (Port.allowed_hosts):
2734         * Scripts/webkitpy/port/driver.py:
2735         (Driver.cmd_line):
2736
2737 2015-03-26  Jer Noble  <jer.noble@apple.com>
2738
2739         [Mac] Add an --allowed-host argument to DRT and WKTR to allow tests to connect to non-localhost servers
2740         https://bugs.webkit.org/show_bug.cgi?id=142931
2741
2742         Reviewed by Brent Fulgham.
2743
2744         Currently, both DRT and WKTR will refuse to allow network connections to non-localhost servers
2745         over HTTP/HTTPS. For certain testing scenarios, however, it would be useful if both DRT and
2746         WKTR could be allowed to make HTTP/HTTPS connections to certain, specific servers defined at
2747         runtime.
2748
2749         To allow this, add an optional argument to DRT and WKTR, --allowed-host, which will add the specified
2750         hostname to a whitelist; requests to these hosts will allowed to proceed normally.
2751
2752         Drive-by fix: in InjectedBundlePage::willSendRequestForFrame, we get the top loading frame from the
2753         injected bundle. But after the main resource load completes, the bundle nulls out it's pointer to the
2754         top loading frame, which causes a subsequent crash when further resources are requested. Instead, get
2755         the top loading frame from the page, as we do elsewhere in this class.
2756
2757         * DumpRenderTree/TestRunner.h:
2758         (TestRunner::allowedHosts):
2759         (TestRunner::setAllowedHosts):
2760         * DumpRenderTree/mac/DumpRenderTree.mm:
2761         (initializeGlobalsFromCommandLineOptions):
2762         (runTest):
2763         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2764         (isAllowedHost):
2765         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
2766         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2767         (WTR::InjectedBundle::didReceiveMessage):
2768         (WTR::InjectedBundle::isAllowedHost):
2769         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
2770         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2771         (WTR::isAllowedHost):
2772         (WTR::InjectedBundlePage::willSendRequestForFrame):
2773         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2774         * WebKitTestRunner/Options.cpp:
2775         (WTR::handleOptionAllowedHost):
2776         (WTR::OptionsHandler::OptionsHandler):
2777         * WebKitTestRunner/Options.h:
2778         * WebKitTestRunner/TestController.cpp:
2779         (WTR::TestController::initialize):
2780         (WTR::TestController::resetStateToConsistentValues):
2781         * WebKitTestRunner/TestController.h:
2782
2783 2015-03-26  Brady Eidson  <beidson@apple.com>
2784
2785         Apply ContentExtension actions after redirects.
2786         <rdar://problem/20062613> and https://bugs.webkit.org/show_bug.cgi?id=143055
2787
2788         Reviewed by Alex Christensen.
2789
2790         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2791         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Dump the fact that the load error is kWKErrorCodeCannotShowURL
2792           which is specifically interesting to a new test.
2793
2794 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2795
2796         [EFL] Disable building libseccomp on AArch64
2797         https://bugs.webkit.org/show_bug.cgi?id=143094
2798
2799         Reviewed by Gyuyoung Kim.
2800
2801         * efl/jhbuildrc:
2802
2803 2015-03-26  Csaba Osztrogonác  <ossy@webkit.org>
2804
2805         [jhbuild] git should use only 1 thread for cloning jhbuild
2806         https://bugs.webkit.org/show_bug.cgi?id=143095
2807
2808         Reviewed by Gyuyoung Kim.
2809
2810         * jhbuild/jhbuild-wrapper:
2811         (clone_jhbuild):
2812
2813 2015-03-25  Joseph Pecoraro  <pecoraro@apple.com>
2814
2815         Update prepare-ChangeLog to work with ES6 Class syntax
2816         https://bugs.webkit.org/show_bug.cgi?id=143069
2817
2818         Reviewed by Timothy Hatcher.
2819
2820         * Scripts/prepare-ChangeLog:
2821         (get_function_line_ranges_for_javascript):
2822         Better handle ES6 Class syntax.
2823
2824         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt:
2825         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js:
2826         (BaseClass):
2827         (DerivedClass):
2828         (DerivedClass.staticMethod):
2829         (DerivedClass.prototype.method.nestedFunctionInsideMethod):
2830         (DerivedClass.prototype.method):
2831         (DerivedClass.prototype.get getter):
2832         (namespace.MyClass):
2833         (namespace.MyClass.staticMethod):
2834         (namespace.MyClass.prototype.method.nestedFunctionInsideMethod):
2835         (namespace.MyClass.prototype.method):
2836         (namespace.MyClass.prototype.get getter):
2837         Proof!
2838
2839 2015-03-25  Filip Pizlo  <fpizlo@apple.com>
2840
2841         Use JITCompilationCanFail in more places, and make the fail path of JITCompilationMustSucceed a crash instead of attempting GC
2842         https://bugs.webkit.org/show_bug.cgi?id=142993
2843
2844         Reviewed by Mark Lam.
2845         
2846         Bunch of support for testing executable allocation failure.
2847
2848         * Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz: Added.
2849         (fail):
2850         * Scripts/run-javascriptcore-tests:
2851         (runJSCStressTests):
2852         * Scripts/run-jsc-stress-tests:
2853
2854 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
2855
2856         Fix Windows build from r181977.
2857
2858         Unreviewed.
2859
2860         * Scripts/update-webkit-dependency:
2861
2862 2015-03-25  Sam Weinig  <sam@webkit.org>
2863
2864         Address additional review feedback from https://bugs.webkit.org/show_bug.cgi?id=143059.
2865
2866         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2867         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2868
2869 2015-03-25  Myles C. Maxfield  <mmaxfield@apple.com>
2870
2871         Migrate update-webkit for Windows to not require Cygwin
2872         https://bugs.webkit.org/show_bug.cgi?id=143040
2873
2874         Reviewed by Brent Fulgham.
2875
2876         * Scripts/update-webkit-dependency:
2877         (wanted):
2878         (toUnixPath): Deleted.
2879         * Scripts/webkitdirs.pm:
2880         (fontExists):
2881         (checkInstalledTools):
2882         (setupAppleWinEnv):
2883
2884 2015-03-25  Sam Weinig  <sam@webkit.org>
2885
2886         [Content Extensions] Convert content extension compiling to return error codes and write its output using a client
2887         https://bugs.webkit.org/show_bug.cgi?id=143059
2888
2889         Reviewed by Alex Christensen.
2890
2891         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2892         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2893         Update for new interface of compileRuleList().
2894
2895 2015-03-25  Alex Christensen  <achristensen@webkit.org>
2896
2897         [Content Extensions] Add multi-DFA compiling and interpreting.
2898         https://bugs.webkit.org/show_bug.cgi?id=143010
2899
2900         Reviewed by Benjamin Poulain.
2901
2902         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2903         (TestWebKitAPI::testRequest):
2904         (TestWebKitAPI::TEST_F):
2905         Add some tests for ignore-previous-rules and large rulesets.
2906
2907 2015-03-25  Alexey Proskuryakov  <ap@apple.com>
2908
2909         Mavericks WK1 still runs JSC tests
2910         https://bugs.webkit.org/show_bug.cgi?id=143035
2911
2912         Reviewed by Csaba Osztrogonác.
2913
2914         * BuildSlaveSupport/build.webkit.org-config/config.json: Bring Mavericks WK1 in line
2915         with other bots.
2916
2917         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Updated the tests
2918         accordingly.
2919
2920 2015-03-25  Commit Queue  <commit-queue@webkit.org>
2921
2922         Unreviewed, rolling out r181932.
2923         https://bugs.webkit.org/show_bug.cgi?id=143041
2924
2925         The test fails most of the time on bots (Requested by ap on
2926         #webkit).
2927
2928         Reverted changeset:
2929
2930         "[Content Extensions] Add multi-DFA compiling and
2931         interpreting."
2932         https://bugs.webkit.org/show_bug.cgi?id=143010
2933         http://trac.webkit.org/changeset/181932
2934
2935 2015-03-24  Alex Christensen  <achristensen@webkit.org>
2936
2937         [Content Extensions] Add multi-DFA compiling and interpreting.
2938         https://bugs.webkit.org/show_bug.cgi?id=143010
2939
2940         Reviewed by Benjamin Poulain.
2941
2942         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2943         (TestWebKitAPI::testRequest):
2944         (TestWebKitAPI::TEST_F):
2945         Add some tests for ignore-previous-rules and large rulesets.
2946
2947 2015-03-24  Benjamin Poulain  <bpoulain@apple.com>
2948
2949         Make URL filter patterns matching consistent and add a simple canonicalization step
2950         https://bugs.webkit.org/show_bug.cgi?id=142998
2951
2952         Reviewed by Alex Christensen.
2953
2954         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2955
2956 2015-03-24  Csaba Osztrogonác  <ossy@webkit.org>
2957
2958         [EFL] Add OpenWebRTC in jhbuild
2959         https://bugs.webkit.org/show_bug.cgi?id=142778
2960
2961         Reviewed by Gyuyoung Kim.
2962
2963         Original patch by Philippe Normand <pnormand@igalia.com>
2964
2965         * efl/install-dependencies: Dependencies for OpenWebRTC.
2966         * efl/jhbuild.modules: build OpenWebRTC, libusrsctp, libnice and
2967         the openwebrtc gst plugins.
2968
2969 2015-03-23  Brent Fulgham  <bfulgham@apple.com>
2970
2971         Regression(r181257): WTF_WorkQueue.Simple is flaky
2972         https://bugs.webkit.org/show_bug.cgi?id=142560
2973
2974         Remove the check that the refCount has returned to one after the
2975         individual tasks have completed. It's too nondeterministic when
2976         the reference count will be reduced.
2977
2978         Reviewed by Alexey Proskuryakov
2979
2980         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2981         (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
2982
2983 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2984
2985         [CMake][EFL] Put failure API test excutables into failure directory
2986         https://bugs.webkit.org/show_bug.cgi?id=142965
2987
2988         Reviewed by Csaba Osztrogonác.
2989
2990         Move failing WK2 API test executables to *bin/TestWebKitAPI/WebKit2/failure* directory.
2991
2992         * TestWebKitAPI/CMakeLists.txt: Fix a typo. Change *testBaseName* with *testName*.
2993         * TestWebKitAPI/PlatformEfl.cmake: Additionally remove unnecessary SHARED_CORE and comment for SeccompFilters test.
2994
2995 2015-03-22  Benjamin Poulain  <benjamin@webkit.org>
2996
2997         CSS Selectors: fix attribute case-insensitive matching of Contain and List
2998         https://bugs.webkit.org/show_bug.cgi?id=142932
2999
3000         Reviewed by Darin Adler.
3001
3002         Add tests for the new features and fix some existing tests using the 
3003         stringFromUTF8() utility recently added by Dhi.
3004
3005         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3006         (TestWebKitAPI::stringFromUTF8):
3007         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3008
3009 2015-03-22  Michael Catanzaro  <mcatanzaro@igalia.com>
3010
3011         [GTK] install-dependencies should install orc
3012         https://bugs.webkit.org/show_bug.cgi?id=142955
3013
3014         Reviewed by Martin Robinson.
3015
3016         Install orc, needed by openwebrtc
3017
3018         * gtk/install-dependencies:
3019
3020 2015-03-22  Benjamin Poulain  <bpoulain@apple.com>
3021
3022         Detect when url filter pattern with groups match the empty string
3023         https://bugs.webkit.org/show_bug.cgi?id=142930
3024
3025         Reviewed by Sam Weinig.
3026
3027         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3028
3029 2015-03-22  Anders Carlsson  <andersca@apple.com>
3030
3031         _WKWebsiteDataStore should clear WebSQL databases
3032         https://bugs.webkit.org/show_bug.cgi?id=142947
3033
3034         Reviewed by Sam Weinig.
3035
3036         Add a variable that keeps track of the types of data we want to operate on, for easier debugging.
3037
3038         * MiniBrowser/mac/WK2BrowserWindowController.m:
3039         (-[WK2BrowserWindowController fetchWebsiteData:]):
3040         (-[WK2BrowserWindowController fetchAndClearWebsiteData:]):
3041         (-[WK2BrowserWindowController clearWebsiteData:]):
3042
3043 2015-03-20  Mark Hahnenberg  <mhahnenb@gmail.com>
3044
3045         GCTimer should know keep track of nested GC phases
3046         https://bugs.webkit.org/show_bug.cgi?id=142675
3047
3048         Reviewed by Darin Adler.
3049
3050         Adds a tool to aid in parsing the GC phase timing output into a
3051         tree-like structure based on the parent-child relationships
3052         of nested GC phases.
3053
3054         * Scripts/parse-gc-phase-timings: Added.
3055         (Timing):
3056         (Timing.__init__):
3057         (Timing.__unicode__):
3058         (Timing.__str__):
3059         (Timing.__repr__):
3060         (parse_input):
3061         (print_timing_node):
3062         (print_timing_tree):
3063         (link_parents):
3064         (main):
3065
3066 2015-03-20  Brent Fulgham  <bfulgham@apple.com>
3067
3068         [Win] Temporarily turn of EWS Windows tests while I debug the test failure.
3069
3070         * Scripts/webkitpy/common/config/ews.json:
3071
3072 2015-03-20  Philippe Normand  <pnormand@igalia.com>
3073
3074         [GTK][jhbuild] Fix flakey failures due to unstable googlecode repository
3075         https://bugs.webkit.org/show_bug.cgi?id=142867
3076
3077         Rubber-stamped by Csaba Osztrogon.
3078
3079         * gtk/jhbuild.modules: Use Ossy's libusrsctp Github fork. Also use
3080         a fixed revision for the openwebrtc-gst-plugins.
3081
3082 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3083
3084         Unreviewed build fix. Don't try to report stats for all benchmarks.
3085         Just report the geometric mean of preferred means.
3086
3087         * Scripts/run-jsc-benchmarks:
3088
3089 2015-03-19  Ryosuke Niwa  <rniwa@webkit.org>
3090
3091         run-jsc-benchmarks should only report preferred mean
3092         https://bugs.webkit.org/show_bug.cgi?id=142874
3093
3094         Reviewed by Geoffrey Garen.
3095
3096         Just collect statistics for the preferred mean.
3097
3098         * Scripts/run-jsc-benchmarks:
3099
3100 2015-03-19  Alex Christensen  <achristensen@webkit.org>
3101
3102         [Content Extensions] Test regular expression parse failures.
3103         https://bugs.webkit.org/show_bug.cgi?id=142872
3104
3105         Reviewed by Benjamin Poulain.
3106
3107         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3108         (TestWebKitAPI::testPatternStatus):
3109         (TestWebKitAPI::TEST_F):
3110         Added tests for each parsing status.
3111
3112 2015-03-19  Alex Christensen  <achristensen@webkit.org>
3113
3114         Fix API tests after r181754.
3115
3116         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3117         (TestWebKitAPI::testRequest):
3118
3119 2015-03-19  Brady Eidson  <beidson@apple.com>
3120
3121         Part of content extensions should apply css selectors
3122         https://bugs.webkit.org/show_bug.cgi?id=142604
3123
3124         Reviewed by Alex Christensen.
3125
3126         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3127         (WebCore::ContentExtensions::operator<<):
3128
3129 2015-03-19  Brent Fulgham  <bfulgham@apple.com>
3130
3131         [Win] Activate tests on EWS
3132         https://bugs.webkit.org/show_bug.cgi?id=142850
3133
3134         Reviewed by Alexey Proskuryakov.
3135
3136         * Scripts/webkitpy/common/config/ews.json: Add me as
3137         the EWS bot watcher, and activate tests.
3138
3139 2015-03-19  Csaba Osztrogonác  <ossy@webkit.org>
3140
3141         [GTK] Fix inspector userinterface related incremental build issue
3142         https://bugs.webkit.org/show_bug.cgi?id=142849
3143
3144         Reviewed by Carlos Garcia Campos.
3145
3146         * Scripts/webkitdirs.pm:
3147         (shouldRemoveCMakeCache):
3148
3149 2015-03-18  Alex Christensen  <achristensen@webkit.org>
3150
3151         [ContentExtensions] Prepare for compiling stylesheets of selectors to be used on every page.
3152         https://bugs.webkit.org/show_bug.cgi?id=142799
3153
3154         Reviewed by Brady Eidson.
3155
3156         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3157         (TestWebKitAPI::testPattern):
3158         (TestWebKitAPI::TEST_F):
3159         Start testing regex failures.
3160
3161 2015-03-18  Dhi Aurrahman  <diorahman@rockybars.com>
3162
3163         Fix StringView typos after r181525 and r181558
3164         https://bugs.webkit.org/show_bug.cgi?id=142772
3165
3166         Reviewed by Darin Adler.
3167
3168         Add some tests in [1] to cover the StringView::startsWith, 
3169         StringView::startsWithIgnoringASCIICase, StringView::endsWith and 
3170         StringView::endsWithIgnoringASCIICase implementations.
3171
3172         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3173         (TestWebKitAPI::TEST):
3174
3175 2015-03-18  Dana Burkart  <dburkart@apple.com>
3176
3177         Remove extraneous import to fix the build.
3178
3179         Unreviewed.
3180
3181         * Scripts/webkitpy/port/driver.py:
3182
3183 2015-03-18  Dana Burkart  <dburkart@apple.com>
3184
3185         ASAN_OPTIONS=allocator_may_return_null=1 needs to be set 
3186         https://bugs.webkit.org/show_bug.cgi?id=142547
3187
3188         Reviewed by Alexey Proskuryakov.
3189
3190         * Scripts/webkitpy/port/driver.py:
3191         (Driver._setup_environ_for_driver):
3192
3193 2015-03-18  Alexey Proskuryakov  <ap@apple.com>
3194
3195         Tweak how AppleSystemFontOSSubversion default is added
3196         https://bugs.webkit.org/show_bug.cgi?id=142835
3197
3198         Reviewed by Dan Bernstein.
3199
3200         * DumpRenderTree/mac/DumpRenderTree.mm:
3201         (setDefaultsToConsistentValuesForTesting):
3202
3203 2015-03-18  Dan Bernstein  <mitz@apple.com>
3204
3205         prepare-ChangeLog doesn't understand C string literals split across multiple lines with \
3206         https://bugs.webkit.org/show_bug.cgi?id=142815
3207
3208         Reviewed by Darin Adler.
3209
3210         * Scripts/prepare-ChangeLog:
3211         (get_function_line_ranges_for_cpp): If the line ends with a backslash instead of a matching
3212         quotation mark, use new variable $quotation_mark to remember what we are looking for, and
3213         keep consuming the quoted text until the matching quotation mark is reached. Emit the
3214         warning only if a line ends without a backslash before the matching quotation mark was found.
3215
3216 2015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
3217
3218         Remove unused "preprocessor" parameter to sub-CodeGenerators
3219         https://bugs.webkit.org/show_bug.cgi?id=142793
3220
3221         Reviewed by Darin Adler.
3222
3223         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3224         (new):
3225
3226 2015-03-18  Csaba Osztrogonác  <ossy@webkit.org>
3227
3228         [EFL] Bump gstreamer version to 1.4.4
3229         https://bugs.webkit.org/show_bug.cgi?id=142782
3230
3231         Reviewed by Philippe Normand.
3232
3233         * efl/jhbuild.modules:
3234         * efl/patches/gst-libav.patch:
3235         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
3236         * efl/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3237
3238 2015-03-17  Tim Horton  <timothy_horton@apple.com>
3239
3240         Fix the iOS build.
3241
3242         * WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:
3243         (WTR::InjectedBundle::platformInitialize):
3244
3245 2015-03-17  Dean Jackson  <dino@apple.com>
3246
3247         check-webkit-style should allow "bool a : 1"
3248         https://bugs.webkit.org/show_bug.cgi?id=142794
3249
3250         Reviewed by Brent Fulgham.
3251
3252         We should allow member bitfields of the form:
3253
3254         bool m_var : 1;
3255
3256         It seems that Visual Studio 8 was the last compiler that
3257         wasn't happy about not using unsigned here. We already have
3258         about 500 cases (in WebCore) where people were ignoring this rule.
3259
3260         * Scripts/webkitpy/style/checkers/cpp.py:
3261         (check_language): Allow "bool".
3262         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add tests.
3263         (CppStyleTest.test_enum_bitfields):
3264         (CppStyleTest.test_plain_integral_bitfields):
3265
3266 2015-03-17  Benjamin Poulain  <bpoulain@apple.com>
3267
3268         Compile character ranges targeting the same state as range check in the bytecode
3269         https://bugs.webkit.org/show_bug.cgi?id=142759
3270
3271         Reviewed by Alex Christensen.
3272
3273         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3274         (TestWebKitAPI::TEST_F):
3275
3276 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3277
3278         W3C test parser and converter should use test importer host
3279         https://bugs.webkit.org/show_bug.cgi?id=142729
3280
3281         Reviewed by Bem Jones-Bey.
3282
3283         When instantiated by TestImporter, TestParser and TestConverter are now using the same host.
3284         This enables adding more TestImporter unit testing.
3285         This patch also ensures that the git object instantiated by TestDownloader is using the
3286         same Executive and FileSystem object as TestDownloader, again to enable TestImporter/TestDownloader unit testing.
3287
3288         * Scripts/webkitpy/common/system/filesystem_mock.py:
3289         (MockFileSystem.copytree): Fixes implementation as it creates a runtime error.
3290         * Scripts/webkitpy/w3c/test_downloader.py:
3291         (TestDownloader.git): Set the executive of the git object to the one of TestDownloader. Refactoring in a new git function for future reuse.
3292         (TestDownloader.checkout_test_repository): Making use of the new git function.
3293         * Scripts/webkitpy/w3c/test_importer.py:
3294         (TestImporter.find_importable_tests): Adding host as parameter to the parser.
3295         (TestImporter.import_tests): Adding host as parameter to the converter.
3296         * Scripts/webkitpy/w3c/test_importer_unittest.py:
3297         (TestImporterTest.create_test_download_importer): Creating a test downloader mock, to be reused by other tests.
3298         (TestImporterTest):
3299         (TestImporterTest.test_harnesslinks_conversion): Adding test to check that test harness links are converted for CSS tests but not WPT tests. 
3300         * Scripts/webkitpy/w3c/test_parser.py:
3301         (TestParser.__init__): Adding host as parameter constructor.
3302
3303 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
3304
3305         [GTK] WebKitDOM objects leaking
3306         https://bugs.webkit.org/show_bug.cgi?id=118788
3307
3308         Reviewed by Darin Adler and Sergio Villar Senin.
3309
3310         Update DOMObjectCache unit test to check that DOM objects are also
3311         released when new contents are loaded in the web view, and the old
3312         document is detached from the frame.
3313
3314         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3315         (testWebKitDOMObjectCache):
3316         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3317         (runTest):
3318
3319 2015-03-17  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3320
3321         W3C test importer default import folder should be LayoutTests/imported/w3c
3322         https://bugs.webkit.org/show_bug.cgi?id=142728
3323
3324         Reviewed by Bem Jones-Bey.
3325
3326         * Scripts/webkitpy/w3c/test_importer.py:
3327         (parse_args): Updating the default destination option value to 'imported/w3c'.
3328
3329 2015-03-17  Philippe Normand  <pnormand@igalia.com>
3330
3331         [GTK] basic OpenWebRTC build support
3332         https://bugs.webkit.org/show_bug.cgi?id=142393
3333
3334         Reviewed by Carlos Garcia Campos.
3335
3336         * gtk/jhbuild.modules: Add OpenWebRTC and its dependencies. This
3337         is not the upstream OpenWebRTC repository. This temporary fork
3338         contains a few patches needed by WebKit for audio/video rendering.
3339
3340 2015-03-17  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3341
3342         [CMake][EFL] Build test tools only for developer mode
3343         https://bugs.webkit.org/show_bug.cgi?id=142761
3344
3345         Reviewed by Csaba Osztrogonác.
3346
3347         Do not build EFL MiniBrowser, WebKitTestRunner, and ImageDiff on production mode.
3348
3349         * CMakeLists.txt:
3350
3351 2015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
3352
3353         Remove never used "useLayerOnTop" bindings generator argument
3354         https://bugs.webkit.org/show_bug.cgi?id=142773
3355
3356         Reviewed by Darin Adler.
3357
3358         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
3359         (new):
3360
3361 2015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
3362
3363         Enable ES6 classes by default
3364         https://bugs.webkit.org/show_bug.cgi?id=142774
3365
3366         Reviewed by Gavin Barraclough.
3367
3368         * Scripts/webkitperl/FeatureList.pm:
3369
3370 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3371
3372         Fix webkitpy tests after r181585.
3373
3374         Looks like "me" cannot be anyone's email, it's a special case.
3375
3376         * Scripts/webkitpy/common/config/contributors.json:
3377
3378 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3379
3380         Add tolerance to WebAudio tests
3381         https://bugs.webkit.org/show_bug.cgi?id=142676
3382
3383         Reviewed by Tim Horton.
3384
3385         * Scripts/webkitpy/common/wavediff.py: Added. Based on Jer Noble's work.
3386
3387         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
3388         (TestResultWriter.create_audio_diff_and_write_result):
3389         * Scripts/webkitpy/layout_tests/models/test_failures.py:
3390         (FailureAudio.write_failure):
3391         * Scripts/webkitpy/port/base.py:
3392         (Port.do_audio_results_differ):
3393         Diff audio failures.
3394
3395         * Scripts/webkitpy/port/test.py: Added a test for the tolerance, fixed existing
3396         tests to use real parseable WAV data, and got rid of base64, which there didn't
3397         seem to have been any reason for.
3398
3399 2015-03-16  Alexey Proskuryakov  <ap@apple.com>
3400
3401         [Mac] fast/forms/text-control-intrinsic-widths.html fails when MS Office is installed
3402         https://bugs.webkit.org/show_bug.cgi?id=142720
3403
3404         Reviewed by Myles C. Maxfield.
3405
3406         Activate system copies of Microsoft fonts for the current process, thus overriding
3407         any other ones that could be preferred by the system otherwise.
3408
3409         * DumpRenderTree/mac/DumpRenderTree.mm:
3410         (activateSystemCoreWebFonts):
3411         (adjustFonts):
3412         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
3413         (WTR::activateSystemCoreWebFonts):
3414         (WTR::activateFonts):
3415
3416 2015-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3417
3418         Created Streams API watchlist
3419         https://bugs.webkit.org/show_bug.cgi?id=142684
3420
3421         Reviewed by Benjamin Poulain.
3422
3423         * Scripts/webkitpy/common/config/watchlist: Created StreamsAPI
3424         watchlist and added Benjamin, Youenn and me to it.
3425
3426 2015-03-15  Benjamin Poulain  <benjamin@webkit.org>
3427
3428         CSS: fix the case-insensitive matching of the attribute selectors Begin, End and Hyphen
3429         https://bugs.webkit.org/show_bug.cgi?id=142715
3430
3431         Reviewed by Brent Fulgham.
3432
3433         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3434         (TestWebKitAPI::TEST):
3435
3436 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
3437
3438         Change the exact attribute matching to be ASCII case-insensitive
3439         https://bugs.webkit.org/show_bug.cgi?id=142609
3440
3441         Reviewed by Darin Adler.
3442
3443         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3444         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3445
3446 2015-03-13  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3447
3448         WebKit test infrastructure should automate the process of cloning W3C test suite and importing tests from it
3449         https://bugs.webkit.org/show_bug.cgi?id=134764
3450
3451         Reviewed by Ryosuke Niwa.
3452
3453         TestDownloader is introduced to download W3C tests from the official
3454         W3C tests repositories (https://github.com/w3c/web-platform-tests.git
3455         and https://github.com/w3c/csswg-test.git).
3456         TestDownloader clones the repositories and checkouts revisions of the tests
3457         defined in LayoutTests/imported/w3c/resources/TestRepositories.
3458
3459         Similarly to https://codereview.chromium.org/148173016,
3460         TestDownloader copies part of the files based on the rules
3461         defined in LayoutTests/imported/w3c/resources/ImportExpectations.
3462
3463         TestDownloader is used by TestImporter when no source directory is provided.
3464
3465         * Scripts/webkitpy/w3c/test_downloader.py: Added.
3466         (TestDownloader):
3467         (TestDownloader.default_options):
3468         (TestDownloader.load_test_repositories):
3469         (TestDownloader.__init__):
3470         (TestDownloader.checkout_test_repository):
3471         (TestDownloader._init_paths_from_expectations):
3472         (TestDownloader._add_test_suite_paths):
3473         (TestDownloader._empty_directory):
3474         (TestDownloader.copy_tests):
3475         (TestDownloader.download_tests):
3476         * Scripts/webkitpy/w3c/test_importer.py:
3477         (main):
3478         (parse_args):
3479         (TestImporter.__init__):
3480         (TestImporter.do_import):
3481         (TestImporter.test_downloader):
3482         (TestImporter.find_importable_tests.should_keep_subdir):
3483         (TestImporter.should_convert_test_harness_links):
3484         (TestImporter.import_tests):
3485         (TestImporter.write_import_log):
3486
3487 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
3488
3489         [Mavericks] Test snapshots are 1600x1200 on Retina devices
3490         https://bugs.webkit.org/show_bug.cgi?id=142630
3491
3492         Reviewed by Tim Horton.
3493
3494         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
3495         Removed an ifdef that disabled the fix on Mavericks.
3496
3497 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
3498
3499         Remove isWK2 cruft from webkitdirs.pm after r170426
3500         https://bugs.webkit.org/show_bug.cgi?id=142618
3501
3502         Reviewed by Daniel Bates.
3503
3504         * Scripts/webkitdirs.pm:
3505         (isWK2): Deleted.
3506
3507 2015-03-12  Alexey Proskuryakov  <ap@apple.com>
3508
3509         testRunner.setAlwaysAcceptCookies does not work with NetworkProcess
3510         https://bugs.webkit.org/show_bug.cgi?id=138687
3511
3512         Reviewed by Carlos Garcia Campos.
3513
3514         Always change cookie policy from UI process, as changing it from WebProcess doesn't
3515         affect other processes.
3516
3517         The implementation is imperfect, because the change happens asynchronously, but I
3518         don't expect it to be a problem in practice.
3519
3520         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3521         (WTR::InjectedBundle::beginTesting):
3522         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3523         (WTR::TestRunner::setAlwaysAcceptCookies):
3524         * WebKitTestRunner/TestInvocation.cpp:
3525         (WTR::TestInvocation::invoke):
3526         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3527
3528 2015-03-12  Csaba Osztrogonác  <ossy@webkit.org>
3529
3530         [EFL] Enable building EFL 1.13 with NEON support
3531         https://bugs.webkit.org/show_bug.cgi?id=142619
3532
3533         Reviewed by Gyuyoung Kim.
3534
3535         * efl/jhbuild.modules:
3536
3537 2015-03-11  Alex Christensen  <achristensen@webkit.org>
3538
3539         [Content Extensions] Add resource type and load type triggers.
3540         https://bugs.webkit.org/show_bug.cgi?id=142422
3541
3542         Reviewed by Benjamin Poulain.
3543
3544         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3545         (TestWebKitAPI::testRequest):
3546         (TestWebKitAPI::mainDocumentRequest):
3547         (TestWebKitAPI::TEST_F):
3548         (TestWebKitAPI::testURL): Deleted.
3549
3550 2015-03-10  Sam Weinig  <sam@webkit.org>
3551
3552         Allow adding a button in input elements for auto fill related functionality
3553         <rdar://problem/19782066>
3554         https://bugs.webkit.org/show_bug.cgi?id=142564
3555
3556         Reviewed by Anders Carlsson.
3557
3558         * WebKitTestRunner/TestController.cpp:
3559         (WTR::TestController::createOtherPage):
3560         (WTR::TestController::createWebViewWithOptions):
3561         Update for new callback.
3562
3563 2015-03-11  Benjamin Poulain  <bpoulain@apple.com>
3564
3565         Add basic support for BOL and EOL assertions to the URL Filter parser
3566         https://bugs.webkit.org/show_bug.cgi?id=142568
3567
3568         Reviewed by Alex Christensen.
3569
3570         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3571         (TestWebKitAPI::TEST_F):
3572
3573 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3574
3575         [GTK] Add support for handling TLS errors to MiniBrowser
3576         https://bugs.webkit.org/show_bug.cgi?id=142576
3577
3578         Reviewed by Sergio Villar Senin.
3579
3580         It's useful for testing TLS errors handling itself, but also to
3581         allow ignoring TLS errors when testing.
3582
3583         * MiniBrowser/gtk/BrowserWindow.c:
3584         (webViewLoadFailedWithTLSerrors):
3585         (browserWindowConstructed):
3586
3587 2015-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
3588
3589         Use out-of-band messaging for RenderBox::firstLineBaseline() and RenderBox::inlineBlockBaseline()
3590         https://bugs.webkit.org/show_bug.cgi?id=142569
3591
3592         Reviewed by David Hyatt.
3593
3594         Test Optional::valueOrCompute().
3595
3596         * TestWebKitAPI/Tests/WTF/Optional.cpp:
3597         (TestWebKitAPI::TEST):
3598
3599 2015-03-11  Carlos Garcia Campos  <cgarcia@igalia.com>
3600
3601         [GTK] Add an option to enable MiniBrowser for non developer builds and always install it
3602         https://bugs.webkit.org/show_bug.cgi?id=126688
3603
3604         Reviewed by Gustavo Noronha Silva.
3605
3606         * CMakeLists.txt: Build testing tools only for developer builds,
3607         but MiniBrowser when ENABLE_MINIBROWSER option is ON.
3608         * MiniBrowser/gtk/CMakeLists.txt: Only add
3609         -DWEBKIT_INJECTED_BUNDLE_PATH to the build for developer builds,
3610         and add a rule to install the MiniBrowser.
3611         * MiniBrowser/gtk/main.c:
3612         (main): Only set WEBKIT_INJECTED_BUNDLE_PATH env var for developer
3613         builds.
3614
3615 2015-03-11  Brent Fulgham  <bfulgham@apple.com>
3616
3617         Add some DateMath tests to TestWebKitAPI
3618         https://bugs.webkit.org/show_bug.cgi?id=142565
3619
3620         Reviewed by Alexey Proskuryakov.
3621
3622         * TestWebKitAPI/CMakeLists.txt: Add new DateMath.cpp file.
3623         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj: Ditto.
3624         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters: Ditto.
3625         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto."
3626         * TestWebKitAPI/Tests/WTF/DateMath.cpp: Added.
3627
3628 2015-03-10  Brent Fulgham  <bfulgham@apple.com>
3629
3630         Regression(r181257): WTF_WorkQueue.Simple is flaky
3631         https://bugs.webkit.org/show_bug.cgi?id=142560
3632
3633         Unreviewed attempt to improve test stability.
3634
3635         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Check the reference count for
3636         the WorkQueue a little later to redue flakiness.
3637
3638 2015-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
3639
3640         Migrate from SystemUIFontSelect to AppleSystemFontOSSubversion
3641         https://bugs.webkit.org/show_bug.cgi?id=142555
3642
3643         Reviewed by Simon Fraser.
3644
3645         * DumpRenderTree/mac/DumpRenderTree.mm:
3646         (setDefaultsToConsistentValuesForTesting):
3647         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3648         (WTR::InjectedBundle::platformInitialize):
3649
3650 2015-03-10  Alex Christensen  <achristensen@webkit.org>
3651
3652         Use unsigned for HashSet size.
3653         https://bugs.webkit.org/show_bug.cgi?id=142518
3654
3655         Reviewed by Benjamin Poulain.
3656
3657         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3658         (TestWebKitAPI::TEST):
3659         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3660         (TestWebKitAPI::testInitialCapacity):
3661         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
3662         (TestWebKitAPI::TEST):
3663
3664 2015-03-10  Daniel Bates  <dabates@apple.com>
3665
3666         [iOS] Add WebKitSystemInterface for iOS 8.2
3667         https://bugs.webkit.org/show_bug.cgi?id=142505
3668
3669         Rubber-stamped by Anders Carlsson.
3670
3671         Make copy-webkitlibraries-to-product-directory install libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a.
3672         I inadvertently forgot to add libWebKitSystemInterfaceIOS{Device, Simulator}8.2.a to script
3673         copy-webkitlibraries-to-product-directory in r181286.
3674
3675         * Scripts/copy-webkitlibraries-to-product-directory:
3676
3677 2015-03-10  Benjamin Poulain  <bpoulain@apple.com>
3678
3679         Extend URL filter's Term definition to support groups/subpatterns
3680         https://bugs.webkit.org/show_bug.cgi?id=142519
3681
3682         Reviewed by Alex Christensen.
3683
3684         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3685         (TestWebKitAPI::testURL):
3686
3687 2015-03-06  Jer Noble  <jer.noble@apple.com>
3688
3689         Add an option to run-webkit-tests to override the LayoutTests/ directory
3690         https://bugs.webkit.org/show_bug.cgi?id=142418
3691
3692         Reviewed by David Kilzer.
3693
3694         Add an arugment to run-webkit-tests which, when set, overrides the port's default LayoutTests
3695         directory. The base port will parse the options during initialization and store the override
3696         location if present. layout_tests_dir() will return this overridden location if set.
3697
3698         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3699         (parse_args):
3700         * Scripts/webkitpy/port/base.py:
3701         (Port.__init__):
3702         (Port.layout_tests_dir):
3703
3704 2015-03-09  Martin Robinson  <mrobinson@igalia.com>
3705
3706         [CMake] Enable WorkQueue tests for CMake ports
3707         https://bugs.webkit.org/show_bug.cgi?id=142473
3708
3709         Reviewed by Darin Adler.
3710
3711         * TestWebKitAPI/CMakeLists.txt: Add the WorkQueue tests source file to
3712         the list of source files.
3713         * Tools/TestWebKitAPI/PlatformEfl.cmake: Add the DispatchQueueEfl directory
3714         to the list of include directories for EFL.
3715
3716 2015-03-09  David Kilzer  <ddkilzer@apple.com>
3717
3718         Attempt to fix timeouts on iOS Simulator layout tests
3719
3720         * Scripts/webkitpy/port/ios.py:
3721         (IOSSimulatorPort.setup_test_run): Most layout test runs on iOS
3722         Simulator end after the first 50 tests time out.  Some analysis
3723         this past weekend shows that the 'Booted' status in the output
3724         of `xcrun simctl list` is not sufficient (and watching the test
3725         run shows that SpringBoard hasn't fully started to the point
3726         where it's displaying icons on the home screen).  The workaround
3727         until we have a better fix is to add an arbitrary timeout to let
3728         SpringBoard finish launching.  In practice, 15 seconds is
3729         probably enough, but 30 seconds should nearly always work.
3730
3731 2015-03-09  Per Arne Vollan  <peavo@outlook.com>
3732
3733         Unreviewed. Add myself as a committer.
3734
3735         * Scripts/webkitpy/common/config/contributors.json:
3736
3737 2015-03-09  David Kilzer  <ddkilzer@apple.com>
3738
3739         Attempt to fix WTF_WorkQueue.TwoQueues timeout test failure
3740
3741         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3742         (TestWebKitAPI::TEST): Change delay from 50ns to 50ms, and add
3743         an expectation that will fail if we hit the race condition.
3744         This test is inherently racy and will deadlock if the first job
3745         for queue2 takes the mutex lock before the second job for
3746         queue1.
3747
3748 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3749
3750         [Win] WTF::WorkQueue does not balance ref/deref properly
3751         https://bugs.webkit.org/show_bug.cgi?id=142471
3752
3753         Reviewed by Antti Koivisto.
3754
3755         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3756         (TestWebKitAPI::TEST): Check that the refcount is correct.
3757
3758 2015-03-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
3759
3760         Do not show passing test result on output of EFL layout test
3761         https://bugs.webkit.org/show_bug.cgi?id=142380
3762
3763         Reviewed by Darin Adler.
3764
3765         To show passing tests has caused inconvenience when we detect problem tests
3766         in output of layout test. So this patch applies '--debug-rwt-logging' except for EFL port
3767         in order not to show passing tests in the output of EFL layout test.
3768
3769         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3770         (RunWebKitTests.start):
3771
3772 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3773
3774         Unreviewed build fix.
3775
3776         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
3777         (TestWebKitAPI::TEST): Remove two unused variables.
3778
3779 2015-03-08  Brent Fulgham  <bfulgham@apple.com>
3780
3781         Add some WorkQueue tests to TestWebKitAPI
3782         https://bugs.webkit.org/show_bug.cgi?id=142447
3783
3784         Reviewed by Sam Weinig.
3785
3786         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3787         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3788         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3789         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp: Added.
3790         (TestWebKitAPI::simpleTest):
3791         (TestWebKitAPI::longTest):
3792         (TestWebKitAPI::thirdTest):
3793         (TestWebKitAPI::finishedTests):
3794         (TestWebKitAPI::TEST):
3795         (TestWebKitAPI::longTest2):
3796
3797 2015-03-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3798
3799         Remove willDestroyFrame in WKBundlePageLoaderClient
3800         https://bugs.webkit.org/show_bug.cgi?id=142389
3801
3802         Reviewed by Anders Carlsson.
3803
3804         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3805         (WTR::InjectedBundlePage::InjectedBundlePage):
3806
3807 2015-03-07  Brent Fulgham  <bfulgham@apple.com>
3808
3809         [Win] Increase TestWebKitAPI Test Coverage[Win] Increase TestWebKitAPI Test Coverage
3810         https://bugs.webkit.org/show_bug.cgi?id=142433
3811
3812         Reviewed by Darin Adler.
3813
3814         Include more TestWebKitAPI tests when building for Windows. Also
3815         fix a build error in MetaAllocator.cpp caused by one of the
3816         Microsoft headers #defining 'small'.
3817
3818         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3819         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3820         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3821
3822 2015-03-06  Sam Weinig  <sam@webkit.org>
3823
3824         [Content Extensions] Move compiling of content extensions to the UIProcess
3825         https://bugs.webkit.org/show_bug.cgi?id=142402
3826
3827         Reviewed by Benjamin Poulain.
3828
3829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3830         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp: Copied from Tools/TestWebKitAPI/Tests/WebCore/ContentFilter.cpp.
3831         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
3832         (TestWebKitAPI::InMemoryCompiledContentExtension::~InMemoryCompiledContentExtension):
3833         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
3834         (TestWebKitAPI::TEST_F):
3835         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Removed.
3836         Update test for new name (ContentFilter -> ContentExtensions) and API (CompiledContentExtension
3837         is now abstract).
3838
3839 2015-03-06  Brent Fulgham  <bfulgham@apple.com>
3840
3841         [Win] Correct Windows build.
3842
3843         Rubberstamped by Michael Saboff
3844
3845         * win/AssembleBuildLogs/AssembleLogs.cmd: Correct cut/paste error
3846         in the GOTO labels.
3847
3848 2015-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3849
3850         [GTK] Test /webkit2/WebKitWebView/sync-request-on-max-conns might fail after finished
3851         https://bugs.webkit.org/show_bug.cgi?id=142385
3852
3853         Reviewed by Sergio Villar Senin.
3854
3855         Use stack allocated GMainLoopSources to make sure they are
3856         cancelled automatically if the test finishes before they have
3857         been processed.
3858
3859         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3860         (testWebViewSyncRequestOnMaxConns):
3861
3862 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3863
3864         Remove Mountain Lion libraries since ML isn't supported
3865         https://bugs.webkit.org/show_bug.cgi?id=142332
3866
3867         Reviewed by Darin Adler.
3868
3869         * Scripts/copy-webkitlibraries-to-product-directory:
3870
3871 2015-03-06  Carlos Alberto Lopez Perez <clopez@igalia.com> and Youenn Fablet  <youenn.fablet@crf.canon.fr>
3872
3873         Layout tests imported/w3c/web-platform-tests certificates should not be tracked on WebKit VCS
3874         https://bugs.webkit.org/show_bug.cgi?id=142083
3875
3876         Reviewed by Simon Fraser.
3877
3878         Modifying on the fly wpt config.json to set the directory where to generate/read certificates as a subfolder of the layout test results folder.
3879
3880         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
3881         (WebPlatformTestServer._copy_webkit_test_files):
3882
3883 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3884
3885         setup-git-clone fails due to the failure to download python-irclib-0.4.8
3886         https://bugs.webkit.org/show_bug.cgi?id=141946
3887
3888         Reviewed by Ryosuke Niwa.
3889
3890         Check in ircbot.py and irclib.py to avoid network problems in the future.
3891
3892         * Scripts/webkitpy/common/net/irc/ircbot.py:
3893         * Scripts/webkitpy/thirdparty/__init__.py:
3894         (AutoinstallImportHook.find_module):
3895         (AutoinstallImportHook._install_irc): Deleted.
3896         * Scripts/webkitpy/thirdparty/__init___unittest.py:
3897         (ThirdpartyTest.test_imports):
3898         * Scripts/webkitpy/thirdparty/irc/__init__.py: Added.
3899         * Scripts/webkitpy/thirdparty/irc/ircbot.py: Added.
3900         * Scripts/webkitpy/thirdparty/irc/irclib.py: Added.
3901
3902 2015-03-06  David Kilzer  <ddkilzer@apple.com>
3903
3904         Dashboard: Perf bot status is missing for Apple {Mavericks,Yosemite} Release builds
3905
3906         See also fix to config.json in r181097.
3907
3908         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3909         (WebKitBuildbot): Add missing "WK2" to the names of the perf
3910         bots.
3911
3912 2015-03-06  Csaba Osztrogonác  <ossy@webkit.org>
3913
3914         run-jsc-stress-tests should determine the architecture from ELF binaries
3915         https://bugs.webkit.org/show_bug.cgi?id=142335
3916
3917         Reviewed by Darin Adler.
3918
3919         * Scripts/run-jsc-stress-tests:
3920
3921 2015-03-05  David Kilzer  <ddkilzer@apple.com>
3922
3923         [iOS] TestExpectations for ios-simulator-wk2 should fall back to 'wk2' after 'ios-simulator'
3924         <http://webkit.org/b/142226>
3925
3926         Reviewed by Darin Adler.
3927
3928         * Scripts/webkitpy/port/ios.py:
3929         (IOSSimulatorPort.default_baseline_search_path): Switch the
3930         TestExpectations order of ios-simulator-wk2 from this:
3931           ios-simulator-wk2, wk2, ios-simulator
3932         To this:
3933           ios-simulator-wk2, ios-simualtor, wk2
3934
3935 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3936
3937         [Win] Provide tiered logging from MSBuild -- Errors on top, Warnings after
3938         https://bugs.webkit.org/show_bug.cgi?id=142370
3939
3940         Reviewed by Dean Jackson.
3941
3942         * Scripts/webkitdirs.pm:
3943         (buildVisualStudioProject): Tell MSBuild to output log files to two separate
3944         logs, one for warnings, the other for errors.
3945         * win/AssembleBuildLogs/AssembleLogs.cmd: Combine the error and warning logs
3946         into the standard BuildOutput.htm document.
3947
3948 2015-03-05  David Kilzer  <ddkilzer@apple.com>
3949
3950         Dashboard has trouble parsing iOS test output
3951         <http://webkit.org/b/142364>
3952
3953         Reviewed by Alex Christensen.
3954
3955         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3956         (BuildbotTestResults.prototype._parseResults.resultSummarizer):
3957         Add fallback path to build a regex using 'matchString' so that
3958         it matches anywhere in the line.  In practice, 'matchString' is
3959         a prefix for the label following the number.
3960
3961 2015-03-05  Alex Christensen  <achristensen@webkit.org>
3962
3963         Fix linker warnings in TestWebKitAPI.
3964         https://bugs.webkit.org/show_bug.cgi?id=141912
3965
3966         Reviewed by David Kilzer.
3967
3968         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3969         Do not export TearDownTestCase or SetUpTestCase symbols.
3970
3971 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3972
3973         [Win] Unreviewed EWS fix.
3974
3975         * Scripts/webkitdirs.pm:
3976         (buildVisualStudioProject): Dial logging back to 'ErrorsOnly' to see if that makes
3977         the EWS output more usable.
3978
3979 2015-03-05  Chris Dumez  <cdumez@apple.com>
3980
3981         Regression(r173761): ASSERTION FAILED: !is8Bit() in StringImpl::characters16()
3982         https://bugs.webkit.org/show_bug.cgi?id=142350
3983
3984         Reviewed by Michael Saboff and Benjamin Poulain.
3985
3986         Add API test for WTFString::hasInfixStartingAt() to make sure it doesn't
3987         crash if the string is 8-bit but the pattern is 16-bit (and vice-versa).
3988
3989         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
3990         (TestWebKitAPI::TEST):
3991
3992 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
3993
3994         [Win] Ensure build target directory exists when launching MSBuild
3995         https://bugs.webkit.org/show_bug.cgi?id=142360
3996
3997         Reviewed by Dean Jackson.
3998
3999         Create the build output directory (if it doesn't exist) before
4000         launching MSBuild so that it can immediately begin writing logs.
4001
4002         * Scripts/webkitdirs.pm:
4003         (buildVisualStudioProject):
4004
4005 2015-03-05  Chris Dumez  <cdumez@apple.com>
4006
4007         run-webkit-tests and run-perf-tests should use WebKitTestRunner by default
4008         https://bugs.webkit.org/show_bug.cgi?id=142325
4009
4010         Reviewed by Csaba Osztrogonác.
4011
4012         run-webkit-tests and run-perf-tests now use WebKitTestRunner by default.
4013         As a result, "--webkit-test-runner / -2" parameters are replaced by
4014         "--dump-render-tree / -1" so developers can run DumpRenderTree rather
4015         than WebKitTestRunner.
4016
4017         * BuildSlaveSupport/build.webkit.org-config/config.json:
4018         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4019         (RunWebKit1Tests):
4020         (RunWebKit1Tests.start):
4021         (RunWebKit1LeakTests):
4022         (RunWebKit1LeakTests.start):
4023         (RunAndUploadPerfTestsWebKit1):
4024         (RunAndUploadPerfTestsWebKit1.start):
4025         (TestFactory):
4026         (TestWebKit1LeaksFactory):
4027         (TestWebKit1LeaksFactory.__init__):
4028         (TestWebKit1Factory):
4029         (TestWebKit1AllButJSCFactory):
4030         (TestAllButJSCFactory):
4031         (BuildAndPerfTestWebKit1Factory):
4032         (BuildAndPerfTestWebKit1Factory.__init__):
4033         (BuildAndPerfTestFactory):
4034         (BuildAndPerfTestFactory.__init__):
4035         (DownloadAndPerfTestWebKit1Factory):
4036         (DownloadAndPerfTestWebKit1Factory.__init__):
4037         (DownloadAndPerfTestFactory):
4038         (DownloadAndPerfTestFactory.__init__):
4039         (RunWebKitLeakTests): Deleted.
4040         (RunWebKitLeakTests.start): Deleted.
4041         (RunWebKit2Tests): Deleted.
4042         (RunWebKit2Tests.start): Deleted.
4043         (RunAndUploadPerfTestsWebKit2): Deleted.
4044         (RunAndUploadPerfTestsWebKit2.start): Deleted.
4045         (TestLeaksFactory): Deleted.
4046         (TestLeaksFactory.__init__): Deleted.
4047         (TestWebKit2Factory): Deleted.
4048         (TestWebKit2AndJSCFactory): Deleted.
4049         (BuildAndPerfTestWebKit2Factory): Deleted.
4050         (BuildAndPerfTestWebKit2Factory.__init__): Deleted.
4051         (DownloadAndPerfTestWebKit2Factory): Deleted.
4052         (DownloadAndPerfTestWebKit2Factory.__init__): Deleted.
4053         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4054         (parse_args):
4055         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4056         (PerfTestsRunner._parse_args):
4057         * Scripts/webkitpy/port/port_testcase.py:
4058         (PortTestCase.test_build_driver):
4059
4060 2015-03-05  Brent Fulgham  <bfulgham@apple.com>
4061
4062         [Win] Switch to MSBuild so we get more useful stdout logging in buildbot
4063         https://bugs.webkit.org/show_bug.cgi?id=140845
4064
4065         Reviewed by David Kilzer.
4066
4067         Update 'webkitdirs.pm' to locate the MSBuild used with Visual Studio 2013
4068         and generate suitable build commands to drive a full build from our
4069         existing solution files.
4070
4071         * Scripts/webkitdirs.pm:
4072         (msBuildInstallDir): Added.
4073         (determineConfigurationForVisualStudio): Revise to use MSBuild command
4074         line arguments to drive the build.
4075         (setupCygwinEnv): Warn user if MSBuild cannot be located.
4076         (buildVisualStudioProject): Revise to use MSBuild command line arguments
4077         to specify build architecture.
4078         * win/AssembleBuildLogs/AssembleLogs.cmd: MSBuild doesn't produce individual
4079         output logs, so don't attempt to consolidate them. Also: Drive-by fix: Don't
4080         bother looking for CoreUI or SafariTheme build logs.
4081
4082 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
4083
4084         [buildbot] mastercfg_unittest.py should be runnable easily
4085         https://bugs.webkit.org/show_bug.cgi?id=142219
4086
4087         Reviewed by Chris Dumez.
4088
4089         Buildbot 0.8.6p1 runs on build.webkit org with Twisted 12.1.0, which is
4090         the last Twisted version works together with this buildbot version.
4091
4092         * Scripts/webkitpy/common/system/autoinstall.py:
4093         (AutoInstaller): Added prepend_to_search_path argument to be able
4094         to prefer autoinstalled package to system package.
4095         (AutoInstaller.__init__):
4096         (AutoInstaller._set_up_target_dir):
4097         (AutoInstaller._extract_tar): Renamed from _extract_targz, now it works with tar.bz2 too.
4098         (AutoInstaller._prepare_package):
4099         (AutoInstaller._extract_targz): Renamed to _extract_tar.
4100         * Scripts/webkitpy/thirdparty/__init__.py:
4101         (AutoinstallImportHook._install_buildbot): Autoinstall Twisted 12.1.0.
4102
4103 2015-03-05  Lukasz Bialek  <l.bialek@samsung.com>
4104
4105         [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked
4106         https://bugs.webkit.org/show_bug.cgi?id=131162
4107
4108         Reviewed by Gyuyoung Kim.
4109
4110         * MiniBrowser/efl/main.c:
4111         (on_download_request):
4112         (on_download_finished):
4113         (on_download_failed):
4114         (window_create):
4115         Adapt download callbacks to new callback mechanism
4116
4117 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4118
4119         Unreviewed. Fix /webkit2/WebKitWebResource/mime-type after r180927.
4120
4121         In r180927 we updated the libsoup version used by the jhbuild. In
4122         this new version the sniffer uses image/x-icon instead of
4123         image/vnd.microsoft.icon for blank.ico resource.
4124
4125         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
4126         (testWebResourceMimeType):
4127
4128 2015-03-05  Carlos Garcia Campos  <cgarcia@igalia.com>
4129
4130         [SOUP] Check TLS errors as soon as they are set in the SoupMessage
4131         https://bugs.webkit.org/show_bug.cgi?id=142244
4132
4133         Reviewed by Sergio Villar Senin.
4134
4135         Check that the SSL server doesn't process any request in case of
4136         TLS errors when the policy is set to FAIL.
4137
4138         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
4139         (testTLSErrorsPolicy):
4140         (testTLSErrorsRedirect):
4141         (testTLSErrorsHTTPAuth):
4142         (testLoadFailedWithTLSErrors):
4143         (testSubresourceLoadFailedWithTLSErrors):
4144         (httpsServerCallback):
4145
4146 2015-03-05  Pawel Forysiuk  <p.forysiuk@samsung.com>
4147
4148         [EFL] REGRESSION (r178685): ASSERTION FAILED: !parameters.mediaKeyStorageDirectory.isEmpty()
4149         https://bugs.webkit.org/show_bug.cgi?id=141154
4150
4151         Reviewed by Jer Noble.
4152
4153         Unlike GTK, EFL port enables ENABLE_ENCRYPTED_MEDIA_V2 build option by default.
4154
4155         For the sake of completeness WebKitTestRunner should specify temporary
4156         folder for MediaKeysStorageDirecory as well as IndexedDB, LocalStorage, etc.
4157
4158         Default non legacy paths are set up in ProcessPoolConfiguration constructor.
4159         They use WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
4160         to get data storage paths. Only Mac port has an actual implementation of it.
4161         However, WebKitTestRunner overrides them in favour of unique temporary dir
4162         which is taken from libraryPathForTesting().
4163
4164         Since WebsiteDataStore::websiteDataDirectoryFileSystemRepresentation
4165         is not implemented for EFL and GTK ports it returns an empty string.
4166         All default data folders besides MediaKeys are overridden in TestRunner
4167         code with unique temporary folders derived from DUMPRENDERTREE_TEMP
4168         env variable.
4169
4170         GTK port does not enable encrypted keys by default so
4171         WebMediaKeyStorageManager::initialize() code path is never triggered.
4172
4173         * WebKitTestRunner/TestController.cpp:
4174         (WTR::TestController::initialize): Set MediaKeysStorageDirectory for all
4175         WebKit ports.
4176
4177 2015-03-05  Csaba Osztrogonác  <ossy@webkit.org>
4178
4179         [buildbot] Add regression test to check which builder runs which tests
4180         https://bugs.webkit.org/show_bug.cgi?id=142166
4181
4182         Reviewed by Alexey Proskuryakov.
4183
4184         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4185         (BuildStepsConstructorTest.createTest):
4186         (BuildStepsTest):
4187         (BuildStepsTest.generateTests):
4188         (BuildStepsTest.createTest):
4189         (BuildStepsTest.createTest.doTest):
4190         (BuildStepsTest.test_unnecessary_expected_results):
4191
4192 2015-03-04  Commit Queue  <commit-queue@webkit.org>
4193
4194         Unreviewed, rolling out r181054.
4195         https://bugs.webkit.org/show_bug.cgi?id=142320
4196
4197         Broke the api tests (Requested by sundiamonde on #webkit).
4198
4199         Reverted changeset:
4200
4201         "Fix linker warnings in TestWebKitAPI."
4202         https://bugs.webkit.org/show_bug.cgi?id=141912
4203         http://trac.webkit.org/changeset/181054
4204
4205 2015-03-04  Alex Christensen  <achristensen@webkit.org>
4206
4207         Fix linker warnings in TestWebKitAPI.
4208         https://bugs.webkit.org/show_bug.cgi?id=141912
4209
4210         Reviewed by David Kilzer.
4211
4212         * TestWebKitAPI/Configurations/Base.xcconfig:
4213         Use GCC_SYMBOLS_PRIVATE_EXTERN like we do in WebCore.
4214
4215 2015-03-04  Alexey Proskuryakov  <ap@apple.com>
4216
4217         [Mac] Set SystemUIFontSelect in DRT and WKTR
4218         https://bugs.webkit.org/show_bug.cgi?id=142303
4219
4220         Reviewed by Myles C. Maxfield.
4221
4222         * DumpRenderTree/mac/DumpRenderTree.mm:
4223         (setDefaultsToConsistentValuesForTesting):
4224         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
4225         (WTR::InjectedBundle::platformInitialize):
4226
4227 2015-03-04  Chris Dumez  <cdumez@apple.com>
4228
4229         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
4230         https://bugs.webkit.org/show_bug.cgi?id=142314
4231         <rdar://problem/20046835>
4232
4233         Reviewed by Ryosuke Niwa.
4234
4235         Mac Perf bots should use WebKitTestRunner instead of DumpRenderTree
4236         to get WK2 code coverage.
4237
4238         * BuildSlaveSupport/build.webkit.org-config/config.json:
4239
4240 2015-03-04  Alex Christensen  <achristensen@webkit.org>
4241
4242         Move content extensions test to properly named directory.
4243         https://bugs.webkit.org/show_bug.cgi?id=142299
4244
4245         Reviewed by Tim Horton.
4246
4247         * WebKitTestRunner/mac/TestControllerMac.mm:
4248         (WTR::TestController::platformConfigureViewForTest):
4249
4250 2015-03-04  Youenn Fablet  <youenn.fablet@crf.canon.fr>
4251
4252         W3C test importer should use filesystem instead of os.walk
4253         https://bugs.webkit.org/show_bug.cgi?id=142085
4254
4255         Reviewed by Bem Jones-Bey.
4256
4257         Added FileSystem.dirs_under to remove the use of os.walk in test importer.
4258         Added MockFileSystem.dirs_under and MockFileSystem.getsize to enable unit testing of test importer.
4259         Added unit test for FileSystem.dirs_under and MockFileSystem.dirs_under.
4260
4261         Made use of FileSystem.dirs_under within TestImporter.find_importable_tests.
4262         Added a unit test to check that test importer is now black-box testable using a Mock system.
4263
4264         * Scripts/webkitpy/common/system/filesystem.py:
4265         (FileSystem.dirs_under): Returns a list of filtered sub-directories.
4266         (FileSystem.dirs_under.filter_all):
4267         * Scripts/webkitpy/common/system/filesystem_mock.py:
4268         (MockFileSystem.dirs_under):
4269         (MockFileSystem.dirs_under.filter_all):
4270         (MockFileSystem.getsize):
4271         * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
4272         (MockFileSystemTest.test_dirs_under):
4273         (MockFileSystemTest.test_dirs_under.filter_dir):
4274         * Scripts/webkitpy/common/system/filesystem_unittest.py:
4275         (RealFileSystemTest.test_sep):
4276         (RealFileSystemTest):
4277         (RealFileSystemTest.test_dirs_under):
4278         (RealFileSystemTest.test_dirs_under.filter_this_dir):
4279         * Scripts/webkitpy/w3c/test_importer.py:
4280         (TestImporter.do_import):
4281         (TestImporter.find_importable_tests.should_keep_subdir):
4282         (TestImporter.find_importable_tests):
4283         (TestImporter.should_keep_subdir): Deleted.
4284         (TestImporter.should_skip_file): Deleted.
4285         * Scripts/webkitpy/w3c/test_importer_unittest.py:
4286         (TestImporterTest.test_import_dir_with_empty_init_py): Added test to ensure empty __init__.py are no longer empty once imported.
4287
4288 2015-03-04  Timothy Horton  <timothy_horton@apple.com>
4289
4290         [WebEditingTester] Add support for the find and replace bar
4291         https://bugs.webkit.org/show_bug.cgi?id=142247
4292
4293         Reviewed by Enrica Casucci.
4294
4295         While it's not hooked up yet in WKWebView, adding support for the
4296         find bar to WebEditingTester will help us implement that functionality.
4297
4298         * WebEditingTester/AppDelegate.h:
4299         * WebEditingTester/AppDelegate.m:
4300         (-[WebEditingAppDelegate performTextFinderAction:]):
4301         * WebEditingTester/MainMenu.xib:
4302         Receive performTextFinderAction: and forward it to the frontmost WebDocumentController.
4303
4304         * WebEditingTester/WK2WebDocumentController.m:
4305         (-[WK2WebDocumentController awakeFromNib]):
4306         (-[WK2WebDocumentController performTextFinderAction:]):
4307         (-[WK2WebDocumentController findBarView]):
4308         (-[WK2WebDocumentController setFindBarView:]):
4309         (-[WK2WebDocumentController isFindBarVisible]):
4310         (-[WK2WebDocumentController setFindBarVisible:]):
4311         (-[WK2WebDocumentController findBarViewDidChangeHeight]):
4312         (-[WK2WebDocumentController layout]):
4313         Implement performTextFinderAction: for WebKit2, and have a NSTextFinder
4314         pointing at the WKWebView (currently nothing will work, but the bar will
4315         show up). Install and uninstall the bar as needed.
4316
4317         * WebEditingTester/WebDocument.xib:
4318         Don't use a full-size content view. There's no need, and it makes find
4319         bar layout harder.
4320
4321         * WebEditingTester/WebDocumentController.h:
4322         * WebEditingTester/WebDocumentController.m:
4323         (-[WebDocumentController performTextFinderAction:]):
4324
4325 2015-03-03  Sam Weinig  <sam@webkit.org>
4326
4327         [Content Extensions] Split parsing and compiling of content extensions into their own files
4328         https://bugs.webkit.org/show_bug.cgi?id=142259
4329
4330         Reviewed by Anders Carlsson.
4331
4332         Add basic unit test for the content filter compiler.
4333
4334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4335         * TestWebKitAPI/Tests/WebCore/ContentFilter.cpp: Added.
4336         (WebCore::ContentExtensions::operator<<):
4337         (TestWebKitAPI::ContentFilterTest::SetUp):
4338         (TestWebKitAPI::TEST_F):
4339
4340 2015-03-04  Matthew Mirman  <mmirman@apple.com>
4341
4342         Cleaned up BuildAndTestFactory to not be a near duplicate of TestFactory
4343         https://bugs.webkit.org/show_bug.cgi?id=142230
4344
4345         Reviewed by Csaba Osztrogonác.
4346
4347         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4348         (TestFactory):
4349         (TestFactory.getProduct): Added
4350         (TestFactory.__init__): moved downloader to getProduct
4351         (BuildAndTestFactory):        
4352         (BuildAndTestFactory.getProduct): Added
4353         (BuildAndTestFactory.__init__): made to call TestFactory.__init__ and append steps to the end.
4354         (BuildAndTestWebKit2Factory): Deleted.  Wasn't used anywhere.
4355
4356 2015-03-04  Debarshi Ray  <debarshir@gnome.org>
4357
4358         [GTK] WebView should hold a reference on WebContext because non-default contexts are a reality
4359         https://bugs.webkit.org/show_bug.cgi?id=142225
4360
4361         Reviewed by Carlos Garcia Campos.
4362
4363         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
4364         (testWebViewWebContextLifetime):
4365         (beforeAll):
4366
4367 2015-03-03  David Kilzer  <ddkilzer@apple.com>
4368
4369         [iOS] Crash logs can't be found on ios-simulator because WebKitTestRunner returns the wrong process name
4370         <http://webkit.org/b/142243>
4371
4372         Reviewed by Alexey Proskuryakov.