743e9ae55ca97bdbc23bc4a4468600b72783ff31
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-24  Philippe Normand  <pnormand@igalia.com>
2
3         [Build][GStreamer] Update to 1.16.0
4         https://bugs.webkit.org/show_bug.cgi?id=197157
5
6         Reviewed by Xabier Rodriguez-Calvar.
7
8         The upstreamed patches were removed and a new one was added for a
9         regression detected in the scaletempo GStreamer element. The GNOME
10         Flatpak was migrated to 3.32 and I switched a few modules to Meson
11         on the way, as it is the preferred build system now in GStreamer
12         1.16.
13
14         * flatpak/files/httpd-autogen.sh:
15         * flatpak/flatpakutils.py:
16         (FlatpakPackage.install):
17         (WebkitFlatpak.run_in_sandbox):
18         * flatpak/org.webkit.CommonModules.yaml:
19         * flatpak/org.webkit.WebKit.yaml:
20         * gstreamer/jhbuild.modules:
21         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
22         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
23         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
24         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
25         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
26         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
27         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
28         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
29         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
30         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
31         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
32         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
33         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
34         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
35         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
36         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
37         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
38         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
39         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
40         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
41         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
42         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
43
44 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
45
46         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
47         https://bugs.webkit.org/show_bug.cgi?id=197156
48
49         Reviewed by Michael Catanzaro.
50
51         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
52         support was added.
53
54         * MiniBrowser/gtk/BrowserTab.c:
55         (browser_tab_set_background_color): Set the passed in color as web view background color.
56         * MiniBrowser/gtk/BrowserTab.h:
57         * MiniBrowser/gtk/BrowserWindow.c:
58         (browser_window_init): Initialize backgroundColor.
59         (browser_window_append_view): Call browser_tab_set_background_color().
60         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
61         are added.
62         * MiniBrowser/gtk/main.c:
63         (main): Call browser_window_set_background_color() before creating the tabs.
64
65 2019-04-23  John Wilander  <wilander@apple.com>
66
67         Move Ad Click Attribution from internal feature to experimental feature
68         https://bugs.webkit.org/show_bug.cgi?id=197218
69         <rdar://problem/47651691>
70
71         Reviewed by Brent Fulgham.
72
73         * DumpRenderTree/TestOptions.cpp:
74         (TestOptions::TestOptions):
75
76 2019-04-23  Andy Estes  <aestes@apple.com>
77
78         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
79         https://bugs.webkit.org/show_bug.cgi?id=196749
80         <rdar://problem/35773454>
81
82         Reviewed by Daniel Bates.
83
84         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
85
86         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
87         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
88         (-[QuickLookDelegate webView:didFinishNavigation:]):
89         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
90         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
91         (runTest):
92         (runTestDecideBeforeLoading):
93         (runTestDecideAfterLoading):
94         (TEST):
95
96 2019-04-23  John Wilander  <wilander@apple.com>
97
98         Remove Ad Click Attribution data when removing website data
99         https://bugs.webkit.org/show_bug.cgi?id=197215
100         <rdar://problem/47668988>
101
102         Reviewed by Chris Dumez.
103
104         This patch adds test infrastructure to delete Ad Click Attribution data
105         through WebsiteDataStore::removeData().
106
107         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
108         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
109         (WTR::TestRunner::clearAdClickAttribution):
110         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
111         * WebKitTestRunner/InjectedBundle/TestRunner.h:
112         * WebKitTestRunner/TestController.cpp:
113         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
114         * WebKitTestRunner/TestController.h:
115         * WebKitTestRunner/TestInvocation.cpp:
116         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
117
118 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
119
120         webkitpy: Kill unresponsive worker processes
121         https://bugs.webkit.org/show_bug.cgi?id=197205
122         <rdar://problem/50104388>
123
124         Reviewed by Lucas Forschler.
125
126         * Scripts/webkitpy/common/message_pool.py:
127         (_MessagePool.__init__): Add close timeout.
128         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
129
130 2019-04-23  Alex Christensen  <achristensen@webkit.org>
131
132         Add unit tests for WKWebView.serverTrust
133         https://bugs.webkit.org/show_bug.cgi?id=197202
134
135         Reviewed by Youenn Fablet
136
137         * TestWebKitAPI/TCPServer.cpp:
138         (TestWebKitAPI::deleter<BIO>::operator()):
139         (TestWebKitAPI::deleter<SSL>::operator()):
140         (TestWebKitAPI::deleter<X509>::operator()):
141         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
142         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
143         (TestWebKitAPI::TCPServer::TCPServer):
144         (TestWebKitAPI::TCPServer::listenForConnections):
145         * TestWebKitAPI/TCPServer.h:
146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
147         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
148         (TestWebKitAPI::TEST):
149         (verifyCertificateAndPublicKey):
150         (-[ServerTrustDelegate webView:didFinishNavigation:]):
151         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
152         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
153         (TestWebKitAPI::downloadAtRate):
154         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
155         (TEST):
156         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
157         (TEST):
158
159 2019-04-23  Commit Queue  <commit-queue@webkit.org>
160
161         Unreviewed, rolling out r244556.
162         https://bugs.webkit.org/show_bug.cgi?id=197212
163
164         Causing build failures on multiple builders (Requested by
165         ShawnRoberts on #webkit).
166
167         Reverted changeset:
168
169         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
170         https://bugs.webkit.org/show_bug.cgi?id=197171
171         https://trac.webkit.org/changeset/244556
172
173 2019-04-23  Alex Christensen  <achristensen@webkit.org>
174
175         Fix iOS build.
176         https://bugs.webkit.org/show_bug.cgi?id=195537
177
178         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
179         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
180         AdoptWK constructor is private now.  Use adoptWK instead.
181
182 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
183
184         Accessibility text search and selection API enhancements.
185         https://bugs.webkit.org/show_bug.cgi?id=197095
186         <rdar://problem/48181791>
187
188         Reviewed by Chris Fleizach.
189
190         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
191
192         * DumpRenderTree/AccessibilityTextMarker.h:
193         * DumpRenderTree/AccessibilityUIElement.cpp:
194         (searchTextWithCriteriaCallback):
195         (AccessibilityUIElement::getJSClass):
196         * DumpRenderTree/AccessibilityUIElement.h:
197         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
198         (convertVectorToObjectArray):
199         (convertNSArrayToVector):
200         (searchTextParameterizedAttributeForCriteria):
201         (AccessibilityUIElement::getLinkedUIElements):
202         (AccessibilityUIElement::getDocumentLinks):
203         (AccessibilityUIElement::getChildren):
204         (AccessibilityUIElement::getChildrenWithRange):
205         (AccessibilityUIElement::rowHeaders const):
206         (AccessibilityUIElement::columnHeaders const):
207         (AccessibilityUIElement::uiElementArrayAttributeValue const):
208         (AccessibilityUIElement::searchTextWithCriteria):
209         (AccessibilityUIElement::attributesOfColumnHeaders):
210         (AccessibilityUIElement::attributesOfRowHeaders):
211         (AccessibilityUIElement::attributesOfColumns):
212         (AccessibilityUIElement::attributesOfRows):
213         (AccessibilityUIElement::attributesOfVisibleCells):
214         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
215         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
216         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
217         (WTR::convertVectorToObjectArray):
218         (WTR::convertNSArrayToVector):
219         (WTR::searchTextParameterizedAttributeForCriteria):
220         (WTR::AccessibilityUIElement::getLinkedUIElements):
221         (WTR::AccessibilityUIElement::getDocumentLinks):
222         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
223         (WTR::AccessibilityUIElement::getChildren):
224         (WTR::AccessibilityUIElement::getChildrenWithRange):
225         (WTR::AccessibilityUIElement::rowHeaders const):
226         (WTR::AccessibilityUIElement::columnHeaders const):
227         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
228         (WTR::AccessibilityUIElement::searchTextWithCriteria):
229         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
230         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
231         (WTR::AccessibilityUIElement::attributesOfColumns):
232         (WTR::AccessibilityUIElement::attributesOfRows):
233         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
234         (WTR::convertElementsToObjectArray): Deleted.
235
236 2019-04-23  Guy Lewin  <guy@lewin.co.il>
237
238         Multiple File Input Icon Set Regardless of File List
239         https://bugs.webkit.org/show_bug.cgi?id=195537
240
241         Reviewed by Alexey Proskuryakov.
242
243         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
244         display string in iOS file inputs
245
246         * DumpRenderTree/TestRunner.cpp:
247         (SetOpenPanelFilesMediaIconCallback):
248         (TestRunner::staticFunctions):
249         (TestRunner::setOpenPanelFilesMediaIcon):
250         * DumpRenderTree/TestRunner.h:
251         (TestRunner::openPanelFilesMediaIcon const):
252         * DumpRenderTree/mac/UIDelegate.mm:
253         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
254         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
255         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
256         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
257         * WebKitTestRunner/InjectedBundle/TestRunner.h:
258         * WebKitTestRunner/TestController.cpp:
259         (WTR::runOpenPanel):
260         (WTR::TestController::resetStateToConsistentValues):
261         * WebKitTestRunner/TestController.h:
262         (WTR::TestController::openPanelFileURLsMediaIcon const):
263         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
264         * WebKitTestRunner/TestInvocation.cpp:
265         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
266
267 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
268
269         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
270         https://bugs.webkit.org/show_bug.cgi?id=197171
271         <rdar://problem/47454979>
272
273         Reviewed by Youenn Fablet.
274
275         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
276         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
277         (TestWebKitAPI::TEST):
278
279 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
280
281         [ews-build] Add unit tests for UnApplyPatchIfRequired
282         https://bugs.webkit.org/show_bug.cgi?id=197197
283
284         Reviewed by Lucas Forschler.
285
286         * BuildSlaveSupport/ews-build/steps_unittest.py:
287         (TestUnApplyPatchIfRequired):
288         (TestUnApplyPatchIfRequired.test_success):
289         (TestUnApplyPatchIfRequired.test_failure):
290         (TestUnApplyPatchIfRequired.test_skip):
291
292 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
293
294         [ews-build] Add unit tests for CleanWorkingDirectory
295         https://bugs.webkit.org/show_bug.cgi?id=197195
296
297         Reviewed by Lucas Forschler.
298
299         * BuildSlaveSupport/ews-build/steps_unittest.py:
300         (TestCleanWorkingDirectory):
301         (TestCleanWorkingDirectory.test_success):
302         (TestCleanWorkingDirectory.test_failure):
303
304 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
305
306         [ews-build] Use explicit imports instead of wildcard imports
307         https://bugs.webkit.org/show_bug.cgi?id=197194
308
309         Reviewed by Lucas Forschler.
310
311         * BuildSlaveSupport/ews-build/factories.py:
312         * BuildSlaveSupport/ews-build/loadConfig.py:
313         * BuildSlaveSupport/ews-build/steps_unittest.py:
314
315 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
316
317         [ews-build] Add unit tests for DownloadBuiltProduct
318         https://bugs.webkit.org/show_bug.cgi?id=197193
319
320         Reviewed by Lucas Forschler.
321
322         * BuildSlaveSupport/ews-build/steps_unittest.py:
323         (TestDownloadBuiltProduct):
324         (TestDownloadBuiltProduct.setUp):
325         (TestDownloadBuiltProduct.tearDown):
326         (TestDownloadBuiltProduct.test_success):
327         (TestDownloadBuiltProduct.test_failure):
328
329 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
330
331         [ews-app] Exception while loading status-bubble when no build step has started
332         https://bugs.webkit.org/show_bug.cgi?id=196676
333
334         Reviewed by Lucas Forschler.
335
336         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
337         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
338
339 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
340
341         [PlayStation] Support running of JSC tests on remote playstation devices
342         https://bugs.webkit.org/show_bug.cgi?id=197170
343
344         Reviewed by Ross Kirsling.
345
346         Script changes
347
348         * Scripts/run-javascriptcore-tests:
349         (runJSCStressTests): Pass arguments for playstation to
350         run-jsc-stress-tests
351         * Scripts/run-jsc-stress-tests:
352         Handle $hostOS=="playstation" for determineArchitecture, turning
353         off $isFTLPlatform and runProfiler and defaulting test writer.
354         * Scripts/webkitdirs.pm:
355         (jscPath): PlayStation WebKit executables have .elf extension
356         (executableProductDir): PlayStation builds on Windows hosts but
357         uses bin directory rather than bin64/bin32 for executable output
358         location.
359         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
360
361 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
362
363         [CMake][Win] Use target oriented design for WebKit
364         https://bugs.webkit.org/show_bug.cgi?id=197173
365
366         Reviewed by Alex Christensen.
367
368         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
369         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
370
371 2019-04-23  Chris Dumez  <cdumez@apple.com>
372
373         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
374         https://bugs.webkit.org/show_bug.cgi?id=197097
375         <rdar://problem/50048318>
376
377         Reviewed by Alex Christensen.
378
379         Add API test coverage.
380
381         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
382         (-[PSONScheme webView:startURLSchemeTask:]):
383
384 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
385
386         [ATK] Implement AtkComponentIface scroll_to methods
387         https://bugs.webkit.org/show_bug.cgi?id=196856
388
389         Reviewed by Michael Catanzaro.
390
391         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
392         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
393         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
394         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
395
396 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
397
398         [ews-build] Improve summary for UploadBuiltProduct step
399         https://bugs.webkit.org/show_bug.cgi?id=197182
400
401         Reviewed by Lucas Forschler.
402
403         * BuildSlaveSupport/ews-build/steps.py:
404         (UploadBuiltProduct): Added descriptionDone.
405         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
406         * BuildSlaveSupport/ews-build/steps_unittest.py:
407         (TestUploadBuiltProduct.test_success): Updated unit-test.
408         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
409
410 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
411
412         [ews-build] Trigger queues only after uploading the archive
413         https://bugs.webkit.org/show_bug.cgi?id=197180
414
415         Reviewed by Lucas Forschler.
416
417         * BuildSlaveSupport/ews-build/factories.py:
418         (Factory.__init__):
419         (BuildFactory.__init__): Remove trigger step from factories.
420         (BuildFactory.propertiesToPassToTriggers): Deleted.
421         * BuildSlaveSupport/ews-build/steps.py:
422         (ConfigureBuild.__init__): Confiure triggers property.
423         (Trigger): Step to trigger other queues.
424         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
425         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
426
427 2019-04-22  Alex Christensen  <achristensen@webkit.org>
428
429         Deprecate WKContextCreateWithInjectedBundlePath
430         https://bugs.webkit.org/show_bug.cgi?id=197169
431
432         Reviewed by Youenn Fablet.
433
434         * TestWebKitAPI/PlatformUtilities.cpp:
435         (TestWebKitAPI::Util::createContextWithInjectedBundle):
436         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
437
438 2019-04-22  Alex Christensen  <achristensen@webkit.org>
439
440         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
441         https://bugs.webkit.org/show_bug.cgi?id=197093
442         <rdar://problem/49708268>
443
444         Reviewed by Chris Dumez.
445
446         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
447         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
448         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
449         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
450         and one for loads without credentials, so there are two TCP connections to the same server in this test.
451
452         * TestWebKitAPI/TCPServer.cpp:
453         (TestWebKitAPI::TCPServer::TCPServer):
454         (TestWebKitAPI::TCPServer::~TCPServer):
455         (TestWebKitAPI::TCPServer::socketBindListen):
456         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
457         * TestWebKitAPI/TCPServer.h:
458         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
459         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
460         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
461         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
462         (respondWithChallengeThenOK):
463         (TestWebKitAPI::TEST):
464         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
465         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
466         (TEST):
467
468 2019-04-22  Chris Dumez  <cdumez@apple.com>
469
470         Delayed WebProcessLaunch may break the _relatedWebView SPI
471         https://bugs.webkit.org/show_bug.cgi?id=197160
472
473         Reviewed by Alex Christensen.
474
475         Add API test coverage.
476
477         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
478
479 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
480
481         Use curl to download packages for webkitpy autoinstaller
482         https://bugs.webkit.org/show_bug.cgi?id=197164
483
484         Reviewed by Darin Adler.
485
486         * Scripts/webkitpy/common/system/autoinstall.py:
487         (AutoInstaller._download): Use curl(1) to download packages necessary for
488         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
489         errors which are not present when using curl(1).
490
491 2019-04-22  Chris Dumez  <cdumez@apple.com>
492
493         Unreviewed, rolling out r244502.
494
495         Caused crashes on the bots
496
497         Reverted changeset:
498
499         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
500         https://bugs.webkit.org/show_bug.cgi?id=197160
501         https://trac.webkit.org/changeset/244502
502
503 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
504
505         Unreviewed, rolling out r244437.
506
507         Still breaks internal tests.
508
509         Reverted changeset:
510
511         "InjectedBundle parameters often need initialization function
512         called before unarchiving"
513         https://bugs.webkit.org/show_bug.cgi?id=189709
514         https://trac.webkit.org/changeset/244437
515
516 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
517
518         [ews-build] Use singular verb in failure description in case of single api test failure
519         https://bugs.webkit.org/show_bug.cgi?id=197013
520
521         Reviewed by Lucas Forschler.
522
523         * BuildSlaveSupport/ews-build/steps.py:
524         (AnalyzeAPITestsResults.analyzeResults):
525
526 2019-04-22  Chris Dumez  <cdumez@apple.com>
527
528         Delayed WebProcessLaunch may break the _relatedWebView SPI
529         https://bugs.webkit.org/show_bug.cgi?id=197160
530
531         Reviewed by Alex Christensen.
532
533         Add API test coverage.
534
535         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
536
537 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
538
539         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
540         https://bugs.webkit.org/show_bug.cgi?id=194630
541
542         Reviewed by Michael Catanzaro.
543
544         Return early from getAttributeSet() is passed in accessible is nullptr.
545
546         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
547
548 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
549
550         Defer EditorState updates until the next layer tree flush in a few additional circumstances
551         https://bugs.webkit.org/show_bug.cgi?id=197145
552         <rdar://problem/50078170>
553
554         Reviewed by Darin Adler.
555
556         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
557         focus, or showing the font manager.
558
559         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
560         (TestWebKitAPI::TEST):
561         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
562         (TEST):
563         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
564         (TestWebKitAPI::TEST):
565
566 2019-04-21  Brian Burg  <bburg@apple.com>
567
568         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
569         https://bugs.webkit.org/show_bug.cgi?id=197125
570         <rdar://problem/50061468>
571
572         Reviewed by Darin Adler.
573
574         Sometimes I want to run wptserve independently of tests. Make it easier to script that
575         using this class rather than making our own ./wpt serve invocation.
576
577         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
578         (WebDriverW3CWebServer):
579         (WebDriverW3CWebServer.document_root): Expose this to clients.
580         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
581
582         (WebDriverW3CWebServer.__enter__):
583         (WebDriverW3CWebServer.__exit__):
584         Make it possible to use the web server with a 'with' statement.
585
586 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
587
588         [CMake][Win] Use target oriented design for WebKitLegacy
589         https://bugs.webkit.org/show_bug.cgi?id=197112
590
591         Reviewed by Konstantin Tokarev.
592
593         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
594
595         * DumpRenderTree/CMakeLists.txt:
596         * DumpRenderTree/PlatformWin.cmake:
597         * DumpRenderTree/win/EventSender.cpp:
598
599 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
600
601         Update text for old EWS submit button
602         https://bugs.webkit.org/show_bug.cgi?id=197140
603
604         Reviewed by Alexey Proskuryakov.
605
606         * QueueStatusServer/templates/statusbubble.html:
607
608 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
609
610         [ews-app] New EWS should poll bugzilla more frequently
611         https://bugs.webkit.org/show_bug.cgi?id=197138
612
613         Reviewed by Alexey Proskuryakov.
614
615         * BuildSlaveSupport/ews-app/ews/fetcher.py:
616         (FetchLoop.__init__):
617
618 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
619
620         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
621         https://bugs.webkit.org/show_bug.cgi?id=197139
622
623         Reviewed by Alexey Proskuryakov.
624
625         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
626         * QueueStatusServer/templates/statusbubble.html:
627
628 2019-04-20  Chris Dumez  <cdumez@apple.com>
629
630         Unreviewed, fix iOS build with recent SDKs.
631
632         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
633
634 2019-04-19  Keith Miller  <keith_miller@apple.com>
635
636         Add script to merge run_benchmark jsons
637         https://bugs.webkit.org/show_bug.cgi?id=197107
638
639         Reviewed by Michael Saboff.
640
641         The script basically recursively decends through all json objects until it gets
642         to an array or JSON primitive and concats or takes the first value, respectively.
643
644         This patch also adds +x bits to the compare-results script so it
645         can be run directly from the command line. I had to add a new line so that svn
646         will accept the change... yay svn!
647
648         * Scripts/compare-results:
649         * Scripts/merge-result-jsons: Added.
650         (readJSONFile):
651         (deepAppend):
652         (mergeJSONs):
653         (main):
654
655 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
656
657         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
658         https://bugs.webkit.org/show_bug.cgi?id=197079
659
660         Reviewed by Darin Adler.
661
662         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
663
664         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
665         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
666
667 2019-04-18  Commit Queue  <commit-queue@webkit.org>
668
669         Unreviewed, rolling out r244434.
670         https://bugs.webkit.org/show_bug.cgi?id=197089
671
672         caused 1 API test failure (Requested by zalan on #webkit).
673
674         Reverted changeset:
675
676         "Regression (r244291): Broken API Test
677         AutoLayoutRenderingProgressRelativeOrdering"
678         https://bugs.webkit.org/show_bug.cgi?id=196948
679         https://trac.webkit.org/changeset/244434
680
681 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
682
683         Add new compatibility mode API on WKNavigation
684         https://bugs.webkit.org/show_bug.cgi?id=197069
685         <rdar://problem/50025800>
686
687         Reviewed by Tim Horton.
688
689         Add a block property for -didCommitNavigation to TestNavigationDelegate.
690
691         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
692         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
693         (-[TestNavigationDelegate webView:didCommitNavigation:]):
694
695 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
696
697         [CMake] Make WebCore headers copies
698         https://bugs.webkit.org/show_bug.cgi?id=182512
699         <rdar://problem/37510435>
700
701         Reviewed by Alex Christensen.
702
703         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
704         ports.
705
706         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
707         of WebCore headers using "*.h" were modified to <WebCore/*.h>
708
709         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
710         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
711         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
712         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
713         * TestWebKitAPI/CMakeLists.txt:
714         * TestWebKitAPI/PlatformWin.cmake:
715         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
716         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
717         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
718
719 2019-04-18  Jer Noble  <jer.noble@apple.com>
720
721         Add support for parsing FairPlayStreaming PSSH boxes.
722         https://bugs.webkit.org/show_bug.cgi?id=197064
723
724         Reviewed by Eric Carlson.
725
726         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
727         (TestWebKitAPI::TEST):
728
729 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
730
731         InjectedBundle parameters often need initialization function called before unarchiving
732         https://bugs.webkit.org/show_bug.cgi?id=189709
733         <rdar://problem/44573653>
734
735         Reviewed by Ryosuke Niwa.
736
737         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
738         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
739
740 2019-04-18  Zalan Bujtas  <zalan@apple.com>
741
742         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
743         https://bugs.webkit.org/show_bug.cgi?id=196948
744         <rdar://problem/49927131>
745
746         Reviewed by Tim Horton.
747
748         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
749         (TEST): 
750         The expected order of incoming events is
751         1. didInvalidateIntrinsicContentSize
752         2. didFirstLayout
753         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
754         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
755         (and remember, all we care about is ordering).
756
757 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
758
759         Unreviewed, rolling out r244299.
760
761         Breaks internal tests.
762
763         Reverted changeset:
764
765         "InjectedBundle parameters often need initialization function
766         called before unarchiving"
767         https://bugs.webkit.org/show_bug.cgi?id=189709
768         https://trac.webkit.org/changeset/244299
769
770 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
771
772         [WTF] StringBuilder should set correct m_is8Bit flag when merging
773         https://bugs.webkit.org/show_bug.cgi?id=197053
774
775         Reviewed by Saam Barati.
776
777         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
778         (TestWebKitAPI::TEST):
779
780 2019-04-17  Tim Horton  <timothy_horton@apple.com>
781
782         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
783         https://bugs.webkit.org/show_bug.cgi?id=197028
784         <rdar://problem/49985290>
785
786         Reviewed by Wenson Hsieh.
787
788         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
789         (TEST):
790         Liberal application of waitForNextPresentationUpdate works around a race
791         where if the page rapidly changes its viewport arguments (or an API client
792         rapidly changes its viewport arguments), we'd get stuck thinking that the
793         user had intentionally zoomed the page, and stop resetting the initial scale.
794         This deserves a separate bug, but no need to keep the test failing while
795         we think about it.
796
797 2019-04-17  Tim Horton  <timothy_horton@apple.com>
798
799         REGRESSION (r241988): Switching tabs is slow
800         https://bugs.webkit.org/show_bug.cgi?id=197037
801         <rdar://problem/49951473>
802
803         Reviewed by Simon Fraser.
804
805         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
806         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
807         (TEST):
808         * TestWebKitAPI/cocoa/TestWKWebView.h:
809         * TestWebKitAPI/cocoa/TestWKWebView.mm:
810         (-[TestWKWebView addToTestWindow]):
811         Add a test that hangs without this fix.
812
813 2019-04-17  Truitt Savell  <tsavell@apple.com>
814
815         Unreviewed, rolling out r244400.
816
817         Caused testing to exit early with assertionon Debug WK2
818
819         Reverted changeset:
820
821         "UI↔Web deadlock when printing with a JavaScript alert
822         visible"
823         https://bugs.webkit.org/show_bug.cgi?id=196839
824         https://trac.webkit.org/changeset/244400
825
826 2019-04-17  Brady Eidson  <beidson@apple.com>
827
828         Link clicks in PDFs shouldn't send referrer headers.
829         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
830
831         Reviewed by Tim Horton.
832
833         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
834         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
835         (putPDFBytesCallback):
836         (emptyReleaseInfoCallback):
837         (createPDFWithLinkToURL):
838         (TEST):
839
840 2019-04-17  Tim Horton  <timothy_horton@apple.com>
841
842         UI↔Web deadlock when printing with a JavaScript alert visible
843         https://bugs.webkit.org/show_bug.cgi?id=196839
844         <rdar://problem/49157642>
845
846         Reviewed by Andy Estes.
847
848         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
849         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
850         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
851         (TEST):
852
853 2019-04-17  Alex Christensen  <achristensen@webkit.org>
854
855         WKRetainPtr's adoption constructor should be private
856         https://bugs.webkit.org/show_bug.cgi?id=197019
857
858         Reviewed by Tim Horton.
859
860         * DumpRenderTree/mac/DumpRenderTree.mm:
861         (dumpFramesAsText):
862         * TestWebKitAPI/InjectedBundleController.cpp:
863         (TestWebKitAPI::InjectedBundleController::initialize):
864         * TestWebKitAPI/PlatformUtilities.cpp:
865         (TestWebKitAPI::Util::createContextWithInjectedBundle):
866         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
867         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
868         (TestWebKitAPI::Util::toWK):
869         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
870         (TestWebKitAPI::TEST):
871         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
872         (TestWebKitAPI::TEST):
873         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
874         (TestWebKitAPI::TEST):
875         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
876         (TestWebKitAPI::TEST):
877         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
878         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
879         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
880         (TestWebKitAPI::TEST):
881         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
882         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
883         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
884         (TestWebKitAPI::TEST):
885         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
886         (TestWebKitAPI::TEST):
887         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
888         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
889         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
890         (TestWebKitAPI::TEST):
891         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
892         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
893         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
894         (TestWebKitAPI::TEST):
895         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
896         (TestWebKitAPI::TEST):
897         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
898         (TestWebKitAPI::TEST):
899         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
900         (TestWebKitAPI::TEST):
901         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
902         (TestWebKitAPI::TEST):
903         * TestWebKitAPI/Tests/WebKit/Find.cpp:
904         (TestWebKitAPI::TEST):
905         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
906         (TestWebKitAPI::TEST):
907         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
908         (TestWebKitAPI::TEST):
909         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
910         (TestWebKitAPI::TEST):
911         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
912         (TestWebKitAPI::TEST):
913         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
914         (TestWebKitAPI::TEST):
915         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
916         (TestWebKitAPI::TEST):
917         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
918         (TestWebKitAPI::TEST):
919         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
920         (TestWebKitAPI::TEST):
921         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
922         (TestWebKitAPI::TEST):
923         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
924         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
925         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
926         (TestWebKitAPI::TEST):
927         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
928         (TestWebKitAPI::TEST):
929         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
930         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
931         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
932         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
933         (TestWebKitAPI::TEST):
934         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
935         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
936         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
937         (TestWebKitAPI::TEST):
938         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
939         (TestWebKitAPI::TEST):
940         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
941         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
942         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
943         (TestWebKitAPI::TEST):
944         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
945         (TestWebKitAPI::loadAlternateHTMLString):
946         (TestWebKitAPI::TEST):
947         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
948         (TestWebKitAPI::TEST):
949         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
950         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
951         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
952         (TestWebKitAPI::buildAndPerformTest):
953         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
954         (TestWebKitAPI::TEST):
955         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
956         (TestWebKitAPI::TEST):
957         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
958         (TestWebKitAPI::TEST):
959         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
960         (TestWebKitAPI::TEST):
961         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
962         (TestWebKitAPI::TEST):
963         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
964         (TestWebKitAPI::TEST):
965         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
966         (TestWebKitAPI::TEST):
967         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
968         (TestWebKitAPI::TEST):
969         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
970         (TestWebKitAPI::TEST):
971         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
972         (TestWebKitAPI::TEST):
973         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
974         (TestWebKitAPI::TEST):
975         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
976         (TestWebKitAPI::TEST):
977         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
978         (TestWebKitAPI::TEST):
979         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
980         (TestWebKitAPI::TEST):
981         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
982         (TestWebKitAPI::TEST):
983         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
984         (TestWebKitAPI::TEST):
985         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
986         (TestWebKitAPI::TEST):
987         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
988         (TestWebKitAPI::TEST):
989         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
990         (TestWebKitAPI::TEST):
991         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
992         (TestWebKitAPI::TEST):
993         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
994         (TestWebKitAPI::TEST):
995         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
996         (TestWebKitAPI::TEST):
997         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
998         (TestWebKitAPI::TEST):
999         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1000         (TestWebKitAPI::TEST):
1001         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1002         (TestWebKitAPI::TEST):
1003         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1004         (TestWebKitAPI::TEST):
1005         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1006         (TestWebKitAPI::TEST):
1007         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1008         (TestWebKitAPI::TEST):
1009         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1010         (TestWebKitAPI::TEST):
1011         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1012         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1013         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1014         (TestWebKitAPI::TEST):
1015         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1016         (TestWebKitAPI::TEST):
1017         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1018         (TestWebKitAPI::TEST):
1019         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1020         (TestWebKitAPI::TEST):
1021         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1022         (TestWebKitAPI::TEST):
1023         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1024         (TestWebKitAPI::TEST):
1025         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1026         (TestWebKitAPI::TEST):
1027         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1028         (TestWebKitAPI::TEST):
1029         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1030         (TestWebKitAPI::TEST):
1031         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1032         (TestWebKitAPI::TEST):
1033         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1034         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1035         (TEST):
1036         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1037         (TEST):
1038         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1039         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1040         (TEST):
1041         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1042         (TestWebKitAPI::TEST):
1043         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1044         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1045         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1046         (WTR::getMenuItemTitleCallback):
1047         (WTR::createMouseMessageBody):
1048         (WTR::EventSendingController::mouseDown):
1049         (WTR::EventSendingController::mouseUp):
1050         (WTR::EventSendingController::mouseMoveTo):
1051         (WTR::EventSendingController::mouseForceClick):
1052         (WTR::EventSendingController::startAndCancelMouseForceClick):
1053         (WTR::EventSendingController::mouseForceDown):
1054         (WTR::EventSendingController::mouseForceUp):
1055         (WTR::EventSendingController::mouseForceChanged):
1056         (WTR::EventSendingController::leapForward):
1057         (WTR::EventSendingController::scheduleAsynchronousClick):
1058         (WTR::createKeyDownMessageBody):
1059         (WTR::EventSendingController::keyDown):
1060         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1061         (WTR::EventSendingController::mouseScrollBy):
1062         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1063         (WTR::EventSendingController::continuousMouseScrollBy):
1064         (WTR::EventSendingController::addTouchPoint):
1065         (WTR::EventSendingController::updateTouchPoint):
1066         (WTR::EventSendingController::setTouchModifier):
1067         (WTR::EventSendingController::setTouchPointRadius):
1068         (WTR::EventSendingController::touchStart):
1069         (WTR::EventSendingController::touchMove):
1070         (WTR::EventSendingController::touchEnd):
1071         (WTR::EventSendingController::touchCancel):
1072         (WTR::EventSendingController::clearTouchPoints):
1073         (WTR::EventSendingController::releaseTouchPoint):
1074         (WTR::EventSendingController::cancelTouchPoint):
1075         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1076         (WTR::InjectedBundle::didCreatePage):
1077         (WTR::InjectedBundle::didReceiveMessage):
1078         (WTR::InjectedBundle::didReceiveMessageToPage):
1079         (WTR::InjectedBundle::booleanForKey):
1080         (WTR::InjectedBundle::done):
1081         (WTR::InjectedBundle::dumpToStdErr):
1082         (WTR::InjectedBundle::outputText):
1083         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1084         (WTR::InjectedBundle::postAddChromeInputField):
1085         (WTR::InjectedBundle::postRemoveChromeInputField):
1086         (WTR::InjectedBundle::postFocusWebView):
1087         (WTR::InjectedBundle::postSetBackingScaleFactor):
1088         (WTR::InjectedBundle::postSetWindowIsKey):
1089         (WTR::InjectedBundle::postSetViewSize):
1090         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1091         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1092         (WTR::InjectedBundle::setGeolocationPermission):
1093         (WTR::InjectedBundle::setMockGeolocationPosition):
1094         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1095         (WTR::InjectedBundle::isGeolocationProviderActive const):
1096         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1097         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1098         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1099         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1100         (WTR::InjectedBundle::setCustomPolicyDelegate):
1101         (WTR::InjectedBundle::setHidden):
1102         (WTR::InjectedBundle::setCacheModel):
1103         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1104         (WTR::InjectedBundle::processWorkQueue):
1105         (WTR::InjectedBundle::queueBackNavigation):
1106         (WTR::InjectedBundle::queueForwardNavigation):
1107         (WTR::InjectedBundle::queueLoad):
1108         (WTR::InjectedBundle::queueLoadHTMLString):
1109         (WTR::InjectedBundle::queueReload):
1110         (WTR::InjectedBundle::queueLoadingScript):
1111         (WTR::InjectedBundle::queueNonLoadingScript):
1112         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1113         (WTR::frameToStr):
1114         (WTR::InjectedBundlePage::InjectedBundlePage):
1115         (WTR::dumpFrameDescriptionSuitableForTestResult):
1116         (WTR::dumpFrameScrollPosition):
1117         (WTR::dumpDescendantFrameScrollPositions):
1118         (WTR::dumpFrameText):
1119         (WTR::dumpDescendantFramesText):
1120         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1121         (WTR::TestRunner::shouldDumpPixels const):
1122         (WTR::TestRunner::setDumpPixels):
1123         (WTR::TestRunner::whatToDump const):
1124         (WTR::TestRunner::setWhatToDump):
1125         (WTR::TestRunner::setWaitUntilDone):
1126         (WTR::TestRunner::shouldWaitUntilDone const):
1127         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1128         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1129         (WTR::TestRunner::clearAllDatabases):
1130         (WTR::TestRunner::setIDBPerOriginQuota):
1131         (WTR::TestRunner::originsWithApplicationCache):
1132         (WTR::TestRunner::setCanOpenWindows):
1133         (WTR::TestRunner::setXSSAuditorEnabled):
1134         (WTR::TestRunner::setMediaDevicesEnabled):
1135         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1136         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1137         (WTR::TestRunner::setCustomUserAgent):
1138         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1139         (WTR::TestRunner::setModernMediaControlsEnabled):
1140         (WTR::TestRunner::setWebGL2Enabled):
1141         (WTR::TestRunner::setWritableStreamAPIEnabled):
1142         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1143         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1144         (WTR::TestRunner::setAllowsAnySSLCertificate):
1145         (WTR::TestRunner::setPluginsEnabled):
1146         (WTR::TestRunner::setValueForUser):
1147         (WTR::TestRunner::setAudioResult):
1148         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1149         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1150         (WTR::TestRunner::setAlwaysAcceptCookies):
1151         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1152         (WTR::TestRunner::isDoingMediaCapture const):
1153         (WTR::TestRunner::queueLoad):
1154         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1155         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1156         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1157         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1158         (WTR::TestRunner::setAuthenticationUsername):
1159         (WTR::TestRunner::setAuthenticationPassword):
1160         (WTR::TestRunner::secureEventInputIsEnabled const):
1161         (WTR::TestRunner::setBlockAllPlugins):
1162         (WTR::TestRunner::setPluginSupportedMode):
1163         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1164         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1165         (WTR::TestRunner::setNavigationGesturesEnabled):
1166         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1167         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1168         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1169         (WTR::TestRunner::terminateNetworkProcess):
1170         (WTR::TestRunner::terminateServiceWorkerProcess):
1171         (WTR::TestRunner::runUIScript):
1172         (WTR::TestRunner::setStatisticsDebugMode):
1173         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1174         (WTR::TestRunner::setStatisticsLastSeen):
1175         (WTR::TestRunner::setStatisticsPrevalentResource):
1176         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1177         (WTR::TestRunner::dumpResourceLoadStatistics):
1178         (WTR::TestRunner::isStatisticsPrevalentResource):
1179         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1180         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1181         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1182         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1183         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1184         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1185         (WTR::TestRunner::setStatisticsGrandfathered):
1186         (WTR::TestRunner::isStatisticsGrandfathered):
1187         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1188         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1189         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1190         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1191         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1192         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1193         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1194         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1195         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1196         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1197         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1198         (WTR::TestRunner::statisticsSubmitTelemetry):
1199         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1200         (WTR::TestRunner::setStatisticsIsRunningTest):
1201         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1202         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1203         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1204         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1205         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1206         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1207         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1208         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1209         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1210         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1211         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1212         (WTR::TestRunner::statisticsResetToConsistentState):
1213         (WTR::TestRunner::setStorageAccessAPIEnabled):
1214         (WTR::TestRunner::getAllStorageAccessEntries):
1215         (WTR::TestRunner::addMockMediaDevice):
1216         (WTR::TestRunner::clearMockMediaDevices):
1217         (WTR::TestRunner::removeMockMediaDevice):
1218         (WTR::TestRunner::resetMockMediaDevices):
1219         (WTR::TestRunner::connectMockGamepad):
1220         (WTR::TestRunner::disconnectMockGamepad):
1221         (WTR::TestRunner::setMockGamepadDetails):
1222         (WTR::TestRunner::setMockGamepadAxisValue):
1223         (WTR::TestRunner::setMockGamepadButtonValue):
1224         (WTR::TestRunner::removeAllSessionCredentials):
1225         (WTR::TestRunner::clearDOMCache):
1226         (WTR::TestRunner::clearDOMCaches):
1227         (WTR::TestRunner::hasDOMCache):
1228         (WTR::TestRunner::domCacheSize):
1229         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1230         (WTR::TestRunner::getApplicationManifestThen):
1231         (WTR::TestRunner::injectUserScript):
1232         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1233         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1234         (WTR::TestRunner::addTestKeyToKeychain):
1235         (WTR::TestRunner::cleanUpKeychain):
1236         (WTR::TestRunner::keyExistsInKeychain):
1237         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1238         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1239         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1240         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1241         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1242         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1243         * WebKitTestRunner/TestController.cpp:
1244         (WTR::TestController::initialize):
1245         (WTR::parseStringTestHeaderValueAsRelativePath):
1246         (WTR::updateTestOptionsFromTestHeader):
1247         (WTR::TestController::runTest):
1248         (WTR::TestController::didReceiveLiveDocumentsList):
1249         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1250         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1251         (WTR::TestController::didFinishNavigation):
1252         (WTR::TestController::didReceiveAuthenticationChallenge):
1253         * WebKitTestRunner/TestInvocation.cpp:
1254         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1255         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1256         (WTR::TestInvocation::uiScriptDidComplete):
1257         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1258         * WebKitTestRunner/WebNotificationProvider.cpp:
1259         (WTR::WebNotificationProvider::closeWebNotification):
1260         * WebKitTestRunner/WorkQueueManager.cpp:
1261         (WTR::ScriptItem::ScriptItem):
1262         (WTR::WorkQueueManager::queueLoad):
1263         (WTR::WorkQueueManager::queueLoadHTMLString):
1264
1265 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1266
1267         Add a comment to make my test from r244139 less mysterious.
1268         https://bugs.webkit.org/show_bug.cgi?id=196744
1269
1270         As suggested by Darin Adler.
1271
1272         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1273         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1274
1275 2019-04-17  Chris Dumez  <cdumez@apple.com>
1276
1277         Remember device orientation permission for the duration of the browsing session
1278         https://bugs.webkit.org/show_bug.cgi?id=196992
1279         <rdar://problem/49946067>
1280
1281         Reviewed by Alex Christensen.
1282
1283         Add API test coverage.
1284
1285         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1286         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1287         (TEST):
1288
1289 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1290
1291         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1292         https://bugs.webkit.org/show_bug.cgi?id=196675
1293
1294         Reviewed by Lucas Forschler.
1295
1296         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1297         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1298
1299 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1300
1301         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1302         https://bugs.webkit.org/show_bug.cgi?id=196919
1303         <rdar://problem/41630459>
1304
1305         Reviewed by Tim Horton.
1306
1307         Add iOS support for several new testing hooks. See below for more detail.
1308
1309         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1310         (WTR::UIScriptController::isDismissingMenu const):
1311
1312         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1313         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1314         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1315
1316         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1317         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1318         (WTR::UIScriptController::isDismissingMenu const):
1319         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1320         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1321         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1322         (WTR::InjectedBundle::didReceiveMessageToPage):
1323         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1324         (WTR::TestRunner::setAllowedMenuActions):
1325
1326         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
1327         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
1328         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
1329         against the name of the custom action.
1330
1331         (WTR::TestRunner::installCustomMenuAction):
1332
1333         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
1334         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
1335         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
1336         triggered.
1337
1338         (WTR::TestRunner::performCustomMenuAction):
1339
1340         Invoked when the custom menu action is triggered.
1341
1342         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1343         * WebKitTestRunner/TestController.cpp:
1344         (WTR::TestController::installCustomMenuAction):
1345         (WTR::TestController::setAllowedMenuActions):
1346         * WebKitTestRunner/TestController.h:
1347         * WebKitTestRunner/TestInvocation.cpp:
1348         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1349         (WTR::TestInvocation::performCustomMenuAction):
1350
1351         Add plumbing to call back into the injected bundle when performing the custom action.
1352
1353         * WebKitTestRunner/TestInvocation.h:
1354         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1355         (WTR::TestController::installCustomMenuAction):
1356         (WTR::TestController::setAllowedMenuActions):
1357         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1358         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1359         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1360         (-[TestRunnerWKWebView becomeFirstResponder]):
1361         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
1362
1363         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
1364         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
1365         in the Mail app on iOS.
1366
1367         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
1368         (-[TestRunnerWKWebView setAllowedMenuActions:]):
1369         (-[TestRunnerWKWebView resetCustomMenuAction]):
1370         (-[TestRunnerWKWebView performCustomAction:]):
1371         (-[TestRunnerWKWebView canPerformAction:withSender:]):
1372         (-[TestRunnerWKWebView _willHideMenu]):
1373         (-[TestRunnerWKWebView _didHideMenu]):
1374         * WebKitTestRunner/ios/TestControllerIOS.mm:
1375         (WTR::TestController::platformResetStateToConsistentValues):
1376
1377         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
1378         if specified.
1379
1380         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1381         (WTR::UIScriptController::isDismissingMenu const):
1382
1383 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
1384
1385         Allow sharing from imageSheet on an image document
1386         https://bugs.webkit.org/show_bug.cgi?id=196891
1387         <rdar://problem/25377386>
1388
1389         Reviewed by Tim Horton.
1390
1391         Test to make sure that the correct imageURL is extracted from an image element.
1392
1393         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
1394         (TestWebKitAPI::TEST):
1395
1396 2019-04-16  Alex Christensen  <achristensen@webkit.org>
1397
1398         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
1399         https://bugs.webkit.org/show_bug.cgi?id=196995
1400
1401         Reviewed by Brady Eidson.
1402
1403         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1404         (TEST):
1405
1406 2019-04-16  Chris Dumez  <cdumez@apple.com>
1407
1408         URL set by document.open() is not communicated to the UIProcess
1409         https://bugs.webkit.org/show_bug.cgi?id=196941
1410         <rdar://problem/49237544>
1411
1412         Reviewed by Geoff Garen.
1413
1414         Add API test coverage.
1415
1416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1417         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1418         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1419         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1420         (TEST):
1421
1422 2019-04-16  Commit Queue  <commit-queue@webkit.org>
1423
1424         Unreviewed, rolling out r244321.
1425         https://bugs.webkit.org/show_bug.cgi?id=196968
1426
1427         Causing all WK2 Debug builds to exit early after Assertion
1428         failures. (Requested by ShawnRoberts on #webkit).
1429
1430         Reverted changeset:
1431
1432         "URL set by document.open() is not communicated to the
1433         UIProcess"
1434         https://bugs.webkit.org/show_bug.cgi?id=196941
1435         https://trac.webkit.org/changeset/244321
1436
1437 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1438
1439         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1440         https://bugs.webkit.org/show_bug.cgi?id=196948
1441
1442         Reviewed by Zalan Bujtas.
1443
1444         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1445         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
1446
1447 2019-04-15  Chris Dumez  <cdumez@apple.com>
1448
1449         URL set by document.open() is not communicated to the UIProcess
1450         https://bugs.webkit.org/show_bug.cgi?id=196941
1451         <rdar://problem/49237544>
1452
1453         Reviewed by Geoffrey Garen.
1454
1455         Add API test coverage.
1456
1457         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1458         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
1459         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
1460         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1461         (TEST):
1462
1463 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
1464
1465         Using Tools/Scripts/clean-webkit should not install requests
1466         https://bugs.webkit.org/show_bug.cgi?id=196940
1467
1468         Reviewed by Lucas Forschler.
1469
1470         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
1471         existing, depending on the path autoinstalled is run through.
1472         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
1473         needed.
1474         (Port.configuration_for_upload):
1475         (Port.commits_for_upload):
1476
1477 2019-04-15  Alex Christensen  <achristensen@webkit.org>
1478
1479         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
1480         https://bugs.webkit.org/show_bug.cgi?id=196773
1481
1482         Reviewed by Jer Noble.
1483
1484         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
1485         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
1486         (TEST):
1487
1488 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1489
1490         ews-build should clearly indicate flaky test failures
1491         https://bugs.webkit.org/show_bug.cgi?id=196947
1492
1493         Reviewed by Lucas Forschler.
1494
1495         * BuildSlaveSupport/ews-build/steps.py:
1496         (AnalyzeAPITestsResults.analyzeResults):
1497
1498 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
1499
1500         InjectedBundle parameters often need initialization function called before unarchiving
1501         https://bugs.webkit.org/show_bug.cgi?id=189709
1502         <rdar://problem/44573653>
1503
1504         Reviewed by Ryosuke Niwa.
1505
1506         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1507         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1508
1509 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
1510
1511         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
1512         https://bugs.webkit.org/show_bug.cgi?id=196681
1513
1514         Reviewed by Darin Adler.
1515
1516         Added tests.
1517
1518         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1519         (WTF_HashSet.RemoveIf):
1520         (WTF_HashSet.RemoveIfShrinkToBestSize):
1521
1522 2019-04-15  John Wilander  <wilander@apple.com>
1523
1524         Send delayed Ad Click Attribution conversion requests to the click source
1525         https://bugs.webkit.org/show_bug.cgi?id=196838
1526         <rdar://problem/47650157>
1527
1528         Reviewed by Chris Dumez and Youenn Fablet.
1529
1530         This patch adds test infrastructure to override the default behavior in
1531         WebKit::NetworkAdClickAttribution.
1532
1533         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
1534         (TestWebKitAPI::TEST):
1535         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1536         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1537         (WTR::TestRunner::dumpAdClickAttribution):
1538         (WTR::TestRunner::clearAdClickAttribution):
1539         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1540         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1541         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1542         * WebKitTestRunner/TestController.cpp:
1543         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
1544         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
1545         * WebKitTestRunner/TestController.h:
1546         * WebKitTestRunner/TestInvocation.cpp:
1547         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1548
1549 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1550
1551         [ews-app] status-bubble should display position in queue
1552         https://bugs.webkit.org/show_bug.cgi?id=196607
1553
1554         Reviewed by Lucas Forschler.
1555
1556         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1557         (StatusBubble._build_bubble):
1558         (StatusBubble._queue_position): Method to calculate patch's position in queue.
1559
1560 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
1561
1562         [ews-build] Do not run clean build by default on EWS builders
1563         https://bugs.webkit.org/show_bug.cgi?id=196897
1564
1565         Reviewed by Lucas Forschler.
1566
1567         * BuildSlaveSupport/ews-build/steps.py:
1568         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
1569         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
1570         untracked directories like WebKitBuild).
1571         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
1572         untracked files/directories (like WebKitBuild).
1573
1574 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
1575
1576         TestRunner::notifyDone() should be safely reentrant
1577         https://bugs.webkit.org/show_bug.cgi?id=196898
1578
1579         Reviewed by Darin Adler.
1580
1581         It is currently possible that TestRunner::notifyDone() will call itself, since
1582         notifyDone() will force a repaint, which can start executing JavaScript, which
1583         may call notifyDone() again. This can lead to test failures and flakiness.
1584         Fix this by setting the m_waitToDump flag before calling the dump() method.
1585
1586         * DumpRenderTree/mac/TestRunnerMac.mm:
1587         (TestRunner::notifyDone):
1588         (TestRunner::forceImmediateCompletion):
1589         * DumpRenderTree/win/TestRunnerWin.cpp:
1590         (TestRunner::notifyDone):
1591         (TestRunner::forceImmediateCompletion):
1592
1593 2019-04-15  Philippe Normand  <pnormand@igalia.com>
1594
1595         [GTK][WPE] Add enable-media websetting
1596         https://bugs.webkit.org/show_bug.cgi?id=196863
1597
1598         Reviewed by Michael Catanzaro.
1599
1600         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1601         (testWebKitSettings): Add test for the enable-media web-setting.
1602
1603 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
1604
1605         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
1606         https://bugs.webkit.org/show_bug.cgi?id=196905
1607         <rdar://problem/49886096>
1608
1609         Reviewed by Tim Horton.
1610
1611         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
1612         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
1613         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
1614         delay timer, we end up with this sequence of events in the problematic (failure) case:
1615
1616         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
1617             ...IPC from UI to web process...
1618         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
1619             ...IPC from web to UI process...
1620         (c) [UI]    Invoke completion handler for script #1
1621         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
1622             ...IPC from UI to web process...
1623         (e) [Web]   Evaluate script #2 in the web process
1624         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
1625
1626         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
1627         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
1628         #2 is run in step (e).
1629
1630         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
1631         the UI process by waiting on a script message posted by the web process, after attachment updates are
1632         dispatched.
1633
1634         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1635         (TestWebKitAPI::TEST):
1636
1637 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
1638
1639         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
1640         https://bugs.webkit.org/show_bug.cgi?id=196909
1641
1642         Reviewed by Wenson Hsieh.
1643
1644         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1645         (TestWebKitAPI::TEST):
1646
1647 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
1648
1649         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
1650         https://bugs.webkit.org/show_bug.cgi?id=196880
1651
1652         Reviewed by Yusuke Suzuki.
1653
1654         Add a new function for bytecode cache tests that does not forceDiskCache
1655         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
1656         test added in this patch, since the code is invalid and therefore won't be
1657         cached. It should also be useful for tests that evaluate dynamically
1658         generated code.
1659
1660         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1661         * Scripts/run-jsc-stress-tests:
1662
1663 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
1664
1665         Update AudioSession route sharing policy
1666         https://bugs.webkit.org/show_bug.cgi?id=196776
1667         <rdar://problem/46501611>
1668
1669         Reviewed by Jer Noble.
1670
1671         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
1672         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
1673         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
1674         (TestWebKitAPI::TEST):
1675
1676 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1677
1678         [iOS] Software keyboard is shown too frequently on some websites
1679         https://bugs.webkit.org/show_bug.cgi?id=195856
1680         <rdar://problem/49191395>
1681
1682         Reviewed by Darin Adler.
1683
1684         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
1685
1686         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1687         (WTR::UIScriptController::setHardwareKeyboardAttached):
1688         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1689         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1690         (WTR::UIScriptController::setHardwareKeyboardAttached):
1691         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1692         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
1693
1694         Additionally link against GraphicsServices in WebKitTestRunner.
1695
1696         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1697         (WTR::TestController::platformResetStateToConsistentValues):
1698         (WTR::UIScriptController::setHardwareKeyboardAttached):
1699
1700 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
1701
1702         [GTK][WPE] Fix pacman install-dependencies packages
1703         https://bugs.webkit.org/show_bug.cgi?id=196817
1704
1705         Reviewed by Žan Doberšek.
1706         
1707         python3-setuptools is called python-setuptools
1708         ruby-highline is only available on AUR
1709         libv4l-devel is incorporated in v4l-utils
1710
1711         * gtk/install-dependencies:
1712         * wpe/install-dependencies:
1713
1714 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1715
1716         [GTK] REGRESSION(r243860): Many tests failing
1717         https://bugs.webkit.org/show_bug.cgi?id=196791
1718
1719         Reviewed by Joanmarie Diggs.
1720
1721         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
1722         multiple documents and check that accessibility hierarchy is updated after a navigation.
1723
1724         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
1725         (loadChangedCallback):
1726         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
1727         (AccessibilityTest::AccessibilityTest):
1728         (AccessibilityTest::~AccessibilityTest):
1729         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
1730         (AccessibilityTest::findTestServerApplication):
1731         (AccessibilityTest::findDocumentWeb):
1732         (AccessibilityTest::findRootObject):
1733         (AccessibilityTest::waitUntilChildrenRemoved):
1734         (AccessibilityTest::ensureProxy):
1735         (testAtspiBasicHierarchy):
1736         (beforeAll):
1737         (afterAll):
1738
1739 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
1740
1741         [ews-build] Handle bug titles with unicode characters
1742         https://bugs.webkit.org/show_bug.cgi?id=196802
1743
1744         Reviewed by Dewei Zhu.
1745
1746         * BuildSlaveSupport/ews-build/steps.py:
1747         (ValidatePatch._is_bug_closed):
1748
1749 2019-04-11  Michael Saboff  <msaboff@apple.com>
1750
1751         Improve the Inline Cache Stats code
1752         https://bugs.webkit.org/show_bug.cgi?id=196836
1753
1754         Reviewed by Saam Barati.
1755
1756         Added a new script to consolidate and arrange the output of --useICStats option.
1757
1758         This script merges the output from every group into one large table and sorts it from most common to
1759         least common.  It also counts the slow path GetById and PutById variants and then calculates the
1760         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
1761         Put together, this is useful to see what property accesses are not getting cached.
1762
1763         * Scripts/ic-stats.py: Added.
1764         (ICStats):
1765         (ICStats.__init__):
1766         (ICStats.parse):
1767         (ICStats.dumpStats):
1768         (usage):
1769
1770 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1771
1772         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
1773         https://bugs.webkit.org/show_bug.cgi?id=196809
1774         <rdar://49800762>
1775
1776         Reviewed by Brady Eidson.
1777
1778         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1779         (TEST):
1780
1781 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
1782
1783         requestAnimationFrame should execute before the next frame
1784         https://bugs.webkit.org/show_bug.cgi?id=177484
1785
1786         Reviewed by Simon Fraser.
1787
1788         Add trace points for the page RenderingUpdate.
1789
1790         * Tracing/SystemTracePoints.plist:
1791
1792 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1793
1794         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
1795         https://bugs.webkit.org/show_bug.cgi?id=196760
1796
1797         Reviewed by Don Olmstead.
1798
1799         vswhere.exe has been bundled since Visual Studio 2017 version
1800         15.2. We shouldn't download vswhere.exe.
1801
1802         * Scripts/build-jsc: Do not call update-vswhere.py.
1803         * Scripts/build-webkit: Ditto.
1804         * Scripts/update-vswhere.py: Removed.
1805         * Scripts/webkitdirs.pm:
1806         (requireModulesForVSWhere): Deleted.
1807         (pickCurrentVisualStudioInstallation): Deleted.
1808         (visualStudioInstallDirVSWhere): Return the latest installed VS
1809         installation path by using the bundled vswhere.exe.
1810         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
1811         (visualStudioInstallDirFallback): Removed.
1812
1813 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
1814
1815         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
1816         https://bugs.webkit.org/show_bug.cgi?id=196780
1817
1818         Reviewed by Alexey Proskuryakov.
1819
1820         * BuildSlaveSupport/ews-build/steps.py:
1821         * BuildSlaveSupport/ews-build/steps_unittest.py:
1822
1823 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1824
1825         Add SPI WKNavigationResponse._downloadAttribute
1826         https://bugs.webkit.org/show_bug.cgi?id=196755
1827         <rdar://49587365>
1828
1829         Reviewed by Brady Eidson.
1830
1831         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1832         (-[NavigationResponseTestDelegate navigationResponse]):
1833         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
1834         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
1835         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1836         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
1837         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1838         (readRequest):
1839         (writeResponse):
1840         (TEST):
1841
1842 2019-04-10  Tim Horton  <timothy_horton@apple.com>
1843
1844         Add modern API for overriding the page's specified viewport configuration
1845         https://bugs.webkit.org/show_bug.cgi?id=167734
1846         <rdar://problem/30331795>
1847
1848         Reviewed by Simon Fraser.
1849
1850         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1851         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
1852
1853 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
1854
1855         Add support for incremental bytecode cache updates
1856         https://bugs.webkit.org/show_bug.cgi?id=195000
1857
1858         Reviewed by Filip Pizlo.
1859
1860         Exit when the initial run to generate bytecode fails.
1861
1862         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
1863
1864 2019-04-10  Alex Christensen  <achristensen@webkit.org>
1865
1866         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
1867         https://bugs.webkit.org/show_bug.cgi?id=196744
1868         <rdar://49415309>
1869
1870         Reviewed by Chris Dumez.
1871
1872         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1873         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1874
1875 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
1876
1877         Add a way to opt into modern compatibility mode in layout tests
1878         https://bugs.webkit.org/show_bug.cgi?id=196770
1879         <rdar://problem/49777550>
1880
1881         Reviewed by Antoine Quint.
1882
1883         Add a new test option to enable modern compatibility mode in layout tests.
1884
1885         * WebKitTestRunner/TestController.cpp:
1886         (WTR::updateTestOptionsFromTestHeader):
1887         * WebKitTestRunner/TestController.h:
1888         * WebKitTestRunner/TestOptions.h:
1889         (WTR::TestOptions::hasSameInitializationOptions const):
1890         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1891         (WTR::TestController::platformCreateWebView):
1892         (WTR::TestController::enableModernCompatibilityMode):
1893
1894 2019-04-10  Andy Estes  <aestes@apple.com>
1895
1896         Try to fix the 32-bit watchOS build.
1897
1898         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1899         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
1900
1901 2019-04-10  Antoine Quint  <graouts@apple.com>
1902
1903         Enable Pointer Events on watchOS
1904         https://bugs.webkit.org/show_bug.cgi?id=196771
1905         <rdar://problem/49040909>
1906
1907         Reviewed by Dean Jackson.
1908
1909         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1910
1911 2019-04-10  Philippe Normand  <pnormand@igalia.com>
1912
1913         Unreviewed. Fix WPE accessibility tests after r244059.
1914
1915         We are failing to load the injected bundle due to undefined symbol
1916         AccessibilityUIElement::replaceTextInRange().
1917
1918         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
1919         (WTR::AccessibilityUIElement::replaceTextInRange):
1920
1921 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
1922
1923         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
1924         https://bugs.webkit.org/show_bug.cgi?id=196727
1925
1926         Reviewed by Fujii Hironori.
1927
1928         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1929         (WebKitBrowserWindow::create):
1930
1931 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
1932
1933         [ews-build] Add unit tests for PrintConfiguration
1934         https://bugs.webkit.org/show_bug.cgi?id=196752
1935
1936         Reviewed by Dewei Zhu.
1937
1938         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1939
1940 2019-04-09  Keith Rollin  <krollin@apple.com>
1941
1942         Unreviewed build maintenance -- update .xcfilelists.
1943
1944         * DumpRenderTree/DerivedSources-input.xcfilelist:
1945         * DumpRenderTree/DerivedSources-output.xcfilelist:
1946
1947 2019-04-09  Zalan Bujtas  <zalan@apple.com>
1948
1949         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
1950         https://bugs.webkit.org/show_bug.cgi?id=196743
1951         <rdar://problem/43897551>
1952
1953         Reviewed by Tim Horton.
1954
1955         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
1956         (TEST):
1957
1958 2019-04-09  Youenn Fablet  <youenn@apple.com>
1959
1960         Close service worker database on network process suspension
1961         https://bugs.webkit.org/show_bug.cgi?id=196623
1962         <rdar://problem/48930869>
1963
1964         Reviewed by Alex Christensen.
1965
1966         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1967
1968 2019-04-09  Daniel Bates  <dabates@apple.com>
1969
1970         [iPad] Should open popover when the spacebar is pressed
1971         https://bugs.webkit.org/show_bug.cgi?id=196360
1972         <rdar://problem/49389129>
1973
1974         Reviewed by Brent Fulgham.
1975
1976         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
1977
1978         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1979         (WTR::UIScriptController::isShowingPopover const): Added.
1980         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1981         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1982         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1983         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1984         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1985         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
1986         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
1987         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
1988         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
1989         (WTR::UIScriptController::isShowingPopover const): Added.
1990         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
1991         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
1992         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1993         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1994         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1995         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
1996         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
1997         (-[TestRunnerWKWebView _willPresentPopover]): Added.
1998         (-[TestRunnerWKWebView _didDismissPopover]): Added.
1999         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2000         (WTR::UIScriptController::isShowingPopover const): Added.
2001         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2002         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2003
2004 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2005
2006         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2007         https://bugs.webkit.org/show_bug.cgi?id=196665
2008         <rdar://45115669>
2009
2010         Reviewed by Geoff Garen.
2011
2012         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2013         (goBack):
2014         (+[SimpleLookupContext sharedLookupContext]):
2015         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2016         (TEST):
2017         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2018         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2019
2020 2019-04-09  John Wilander  <wilander@apple.com>
2021
2022         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2023         https://bugs.webkit.org/show_bug.cgi?id=196558
2024         <rdar://problem/47650245>
2025
2026         Reviewed by Youenn Fablet.
2027
2028         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2029         (TestWebKitAPI::TEST):
2030             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2031
2032 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2033
2034         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2035         https://bugs.webkit.org/show_bug.cgi?id=196720
2036
2037         Reviewed by Konstantin Tokarev.
2038
2039         * TestWebKitAPI/PlatformMac.cmake:
2040
2041 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2042
2043         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2044         https://bugs.webkit.org/show_bug.cgi?id=196694
2045         <rdar://problem/48388734>
2046
2047         Rubber-stamped by Aakash Jain.
2048
2049         * Scripts/webkitpy/port/image_diff.py:
2050         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2051         * Scripts/webkitpy/port/server_process.py:
2052         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2053         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2054         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2055         * Scripts/webkitpy/port/server_process_mock.py:
2056         (MockServerProcess.has_available_stdout):
2057         * Scripts/webkitpy/port/server_process_unittest.py:
2058         (TestServerProcess.serial_test_basic):
2059
2060 2019-04-09  Jer Noble  <jer.noble@apple.com>
2061
2062         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2063         https://bugs.webkit.org/show_bug.cgi?id=196097
2064
2065         Reviewed by Eric Carlson.
2066
2067         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2068
2069         * DumpRenderTree/mac/DumpRenderTree.mm:
2070         (resetWebPreferencesToConsistentValues):
2071         * WebKitTestRunner/TestController.cpp:
2072         (WTR::TestController::resetPreferencesToConsistentValues):
2073
2074 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2075
2076         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2077         https://bugs.webkit.org/show_bug.cgi?id=196690
2078
2079         Reviewed by Michael Catanzaro.
2080
2081         * QueueStatusServer/config/queues.py:
2082         * Scripts/webkitpy/common/config/ews.json:
2083         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2084         (test_ews_name):
2085
2086 2019-04-09  Chris Dumez  <cdumez@apple.com>
2087
2088         Loads using loadHTMLString() cause flashing when process-swapping
2089         https://bugs.webkit.org/show_bug.cgi?id=196714
2090         <rdar://problem/49637354>
2091
2092         Reviewed by Antti Koivisto.
2093
2094         Add API test coverage.
2095
2096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2097
2098 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2099
2100         Unreviewed. Fix ATK accessibility tests after r244059.
2101
2102         We are failing to load the injected bundle due to undefined symbol
2103         AccessibilityUIElement::replaceTextInRange().
2104
2105         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2106         (WTR::AccessibilityUIElement::replaceTextInRange):
2107
2108 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2109
2110         AX: Support API: accessibilityReplaceRange:withText
2111         https://bugs.webkit.org/show_bug.cgi?id=196636
2112
2113         Unreviewed build fix for Windows port.
2114
2115         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2116         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2117
2118 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2119
2120         [CMake][WinCairo] Separate copied headers into different directories
2121         https://bugs.webkit.org/show_bug.cgi?id=196655
2122
2123         Reviewed by Michael Catanzaro.
2124
2125         * DumpRenderTree/CMakeLists.txt:
2126         * MiniBrowser/win/CMakeLists.txt:
2127         * TestWebKitAPI/CMakeLists.txt:
2128         * TestWebKitAPI/PlatformWin.cmake:
2129
2130 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2131
2132         Log stack-trace for run-webkit-tests when interrupted
2133         https://bugs.webkit.org/show_bug.cgi?id=176393
2134         <rdar://problem/34262310>
2135
2136         Reviewed by Lucas Forschler.
2137
2138         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2139         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2140         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2141         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2142         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2143         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2144         (main): Set handlers to log stack trace on interruption.
2145
2146 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2147
2148         AX: Support API: accessibilityReplaceRange:withText
2149         https://bugs.webkit.org/show_bug.cgi?id=196636
2150
2151         Unreviewed build fix for Windows port.
2152
2153         * DumpRenderTree/AccessibilityUIElement.cpp:
2154         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2155
2156 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2157
2158         [ews-build] Scripts using Buildbot API have CORS error
2159         https://bugs.webkit.org/show_bug.cgi?id=196709
2160
2161         Reviewed by Alexey Proskuryakov.
2162
2163         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2164
2165 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2166
2167         AX: Support API: accessibilityReplaceRange:withText
2168         https://bugs.webkit.org/show_bug.cgi?id=196636
2169
2170         Reviewed by Daniel Bates.
2171
2172         * DumpRenderTree/AccessibilityUIElement.cpp:
2173         (replaceTextInRangeCallback):
2174         (AccessibilityUIElement::replaceTextInRange):
2175         (AccessibilityUIElement::getJSClass):
2176         * DumpRenderTree/AccessibilityUIElement.h:
2177         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2178         (AccessibilityUIElement::replaceTextInRange):
2179         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2180         (AccessibilityUIElement::replaceTextInRange):
2181         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2182         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2183         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2184         (WTR::AccessibilityUIElement::replaceTextInRange):
2185         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2186         (WTR::AccessibilityUIElement::replaceTextInRange):
2187
2188 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2189
2190         [iOS] Do not allow starting selection drags when selection views are not visible
2191         https://bugs.webkit.org/show_bug.cgi?id=196686
2192         <rdar://problem/49399192>
2193
2194         Reviewed by Tim Horton.
2195
2196         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2197         also add some new API tests to cover scenarios where the web view is not first responder.
2198
2199         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2200         (TestWebKitAPI::TEST):
2201         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2202
2203         Add a switch to optionally make the web view first responder when starting the simulated drag.
2204
2205         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2206         (-[DragAndDropSimulator initWithWebView:]):
2207         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2208
2209 2019-04-08  Justin Fan  <justin_fan@apple.com>
2210
2211         [Web GPU] Fix Web GPU experimental feature on iOS
2212         https://bugs.webkit.org/show_bug.cgi?id=196632
2213
2214         Reviewed by Myles C. Maxfield.
2215
2216         Properly make Web GPU available on iOS 11+.
2217
2218         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2219
2220 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2221
2222         [ews-build] Do not upload archive when Compile Fails
2223         https://bugs.webkit.org/show_bug.cgi?id=196674
2224
2225         Reviewed by Alexey Proskuryakov.
2226
2227         * BuildSlaveSupport/ews-build/factories.py:
2228         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2229         * BuildSlaveSupport/ews-build/steps.py:
2230         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2231         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2232         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2233
2234 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2235
2236         Enable DFG on MIPS
2237         https://bugs.webkit.org/show_bug.cgi?id=196689
2238
2239         Reviewed by Žan Doberšek.
2240
2241         Since the bytecode change, we enabled the baseline JIT on mips in
2242         r240432, but DFG is still missing. With this change, all tests are
2243         passing on a ci20 board.
2244
2245         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2246
2247 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2248
2249         [Flatpak] Second run update-webkitwpe-flatpak fails
2250         https://bugs.webkit.org/show_bug.cgi?id=192702
2251
2252         Reviewed by Carlos Garcia Campos.
2253
2254         * flatpak/flatpakutils.py:
2255         (FlatpakObject.flatpak): Fix typo.
2256         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2257         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2258
2259 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2260
2261         [GTK][WPE] outlook.live.com displays old-fashioned UI
2262         https://bugs.webkit.org/show_bug.cgi?id=196642
2263
2264         Reviewed by Carlos Garcia Campos.
2265
2266         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2267         (TestWebKitAPI::TEST): New Mac platform quirk test.
2268
2269 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2270
2271         Unreviewed, rolling out r243956.
2272         https://bugs.webkit.org/show_bug.cgi?id=196688
2273
2274         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2275         by aakashjain on #webkit).
2276
2277         Reverted changeset:
2278
2279         "Clicking "Go Back" from a safe browsing warning from an
2280         iframe should navigate the WKWebView back to the previous
2281         page"
2282         https://bugs.webkit.org/show_bug.cgi?id=196665
2283         https://trac.webkit.org/changeset/243956
2284
2285 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2286
2287         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2288         https://bugs.webkit.org/show_bug.cgi?id=196669
2289
2290         Reviewed by Geoffrey Garen.
2291
2292         Added three new unit tests for WeakHashSet.
2293
2294         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2295         (WTF_WeakPtr.WeakHashSetConstObjects):
2296         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2297         (WTF_WeakPtr.WeakHashSetComputeSize):
2298
2299 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2300
2301         Hide next and previous form control buttons when WKWebView is editable
2302         https://bugs.webkit.org/show_bug.cgi?id=196672
2303         <rdar://problem/35625321>
2304
2305         Reviewed by Tim Horton.
2306
2307         Add a new API test.
2308
2309         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2310         (-[TestWKWebView lastTrailingBarButtonGroup]):
2311         (TestWebKitAPI::TEST):
2312         * TestWebKitAPI/ios/UIKitSPI.h:
2313
2314 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2315
2316         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2317         https://bugs.webkit.org/show_bug.cgi?id=196077
2318         <rdar://problem/49108202>
2319
2320         Reviewed by Chris Dumez.
2321
2322         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2323         on new web view.
2324
2325         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2326
2327 2019-04-05  Saam Barati  <sbarati@apple.com>
2328
2329         Make compare-results understand MotionMark
2330         https://bugs.webkit.org/show_bug.cgi?id=196666
2331
2332         Reviewed by Yusuke Suzuki.
2333
2334         * Scripts/compare-results:
2335         (PLT5Results):
2336         (detectMotionMark):
2337         (detectMotionMark1_1):
2338         (motionMarkResults):
2339         (motionMark1_1Results):
2340         (detectBenchmark):
2341         (biggerIsBetter):
2342         (main):
2343
2344 2019-04-05  Alex Christensen  <achristensen@webkit.org>
2345
2346         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2347         https://bugs.webkit.org/show_bug.cgi?id=196665
2348         <rdar://45115669>
2349
2350         Reviewed by Geoff Garen.
2351
2352         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2353         (goBack):
2354         (+[SimpleLookupContext sharedLookupContext]):
2355         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2356         (TEST):
2357         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2358         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2359
2360 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
2361
2362         [ews-build] Add configuration and architecture for windows builders
2363         https://bugs.webkit.org/show_bug.cgi?id=196660
2364
2365         Reviewed by Lucas Forschler.
2366
2367         * BuildSlaveSupport/ews-build/config.json:
2368
2369 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
2370
2371         webkitpy: Don't run subsequent rounds if interrupted
2372         https://bugs.webkit.org/show_bug.cgi?id=196646
2373
2374         Reviewed by Aakash Jain.
2375
2376         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2377         (Manager.run): Bail out if interrupted.
2378
2379 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
2380
2381         Test sessionStorage in PSON private browsing mode
2382         https://bugs.webkit.org/show_bug.cgi?id=196561
2383
2384         Reviewed by Alex Christensen.
2385
2386         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2387
2388 2019-04-05  Commit Queue  <commit-queue@webkit.org>
2389
2390         Unreviewed, rolling out r243833.
2391         https://bugs.webkit.org/show_bug.cgi?id=196645
2392
2393         This change breaks build of WPE and GTK ports (Requested by
2394         annulen on #webkit).
2395
2396         Reverted changeset:
2397
2398         "[CMake][WTF] Mirror XCode header directories"
2399         https://bugs.webkit.org/show_bug.cgi?id=191662
2400         https://trac.webkit.org/changeset/243833
2401
2402 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
2403
2404         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
2405         https://bugs.webkit.org/show_bug.cgi?id=196635
2406
2407         Reviewed by Antti Koivisto.
2408         
2409         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
2410         for a test to enable async frame scrolling via:
2411             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
2412         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
2413         
2414         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
2415
2416         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2417         (WTR::InjectedBundle::beginTesting):
2418         * WebKitTestRunner/TestController.cpp:
2419         (WTR::TestController::resetPreferencesToConsistentValues):
2420
2421 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
2422
2423         Use a correct LC_RPATH when building with ASan
2424         https://bugs.webkit.org/show_bug.cgi?id=196576
2425
2426         Reviewed by David Kilzer.
2427
2428         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
2429         so that ../Frameworks is checked. This is simpler and more reliable than updating
2430         each SPC service xcconfig.
2431
2432 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2433
2434         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
2435         https://bugs.webkit.org/show_bug.cgi?id=196629
2436
2437         Reviewed by Lucas Forschler.
2438
2439         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2440
2441 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2442
2443         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
2444         https://bugs.webkit.org/show_bug.cgi?id=196618
2445
2446         Reviewed by Lucas Forschler.
2447
2448         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2449         (StatusBubble): Added QUEUE_TRIGGERS.
2450         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
2451         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
2452         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
2453         its parent(builder).
2454
2455 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2456
2457         [ews-app] Status-bubble steps are sometimes displayed in reverse order
2458         https://bugs.webkit.org/show_bug.cgi?id=196625
2459
2460         Reviewed by Lucas Forschler.
2461
2462         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2463         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
2464
2465 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2466
2467         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
2468         https://bugs.webkit.org/show_bug.cgi?id=196630
2469
2470         Reviewed by Wenson Hsieh.
2471
2472         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2473
2474 2019-04-04  Youenn Fablet  <youenn@apple.com>
2475
2476         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
2477         https://bugs.webkit.org/show_bug.cgi?id=196543
2478
2479         Reviewed by Alex Christensen.
2480
2481         * WebKitTestRunner/TestController.cpp:
2482         (WTR::TestController::generatePageConfiguration):
2483
2484 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2485
2486         [ews-app] Status bubble should not display skipped buildbot steps
2487         https://bugs.webkit.org/show_bug.cgi?id=196584
2488
2489         Reviewed by Lucas Forschler.
2490
2491         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2492
2493 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
2494
2495         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
2496         https://bugs.webkit.org/show_bug.cgi?id=196620
2497
2498         Reviewed by Lucas Forschler.
2499
2500         * BuildSlaveSupport/ews-app/ews/config.py:
2501
2502 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
2503
2504         [Win] DumpRenderTreeWatchDog.py is not checked into source
2505         https://bugs.webkit.org/show_bug.cgi?id=196567
2506         <rdar://problem/49525901>
2507
2508         Reviewed by Lucas Forschler.
2509
2510         This script is used on Win EWS bots to terminate hanging DRT processes.
2511
2512         * EWSTools/dumprendertreewatchdog.py: Added.
2513
2514 2019-04-04  Chris Dumez  <cdumez@apple.com>
2515
2516         Unreviewed, roll out r243858 which made tests time out.
2517
2518         Disable new API tests on Windows instead.
2519
2520         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2521         (TestWebKitAPI::TEST):
2522
2523 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2524
2525         [ATK] Cleanup WebPageAccessibilityObjectAtk
2526         https://bugs.webkit.org/show_bug.cgi?id=196537
2527
2528         Reviewed by Michael Catanzaro.
2529
2530         Also consider files under atk directories as exceptions for GObject conventions.
2531
2532         * Scripts/webkitpy/style/checkers/cpp.py:
2533         (check_identifier_name_in_declaration):
2534
2535 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2536
2537         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2538         https://bugs.webkit.org/show_bug.cgi?id=196588
2539         <rdar://problem/49365787>
2540
2541         Unreviewed build fix for Windows port.
2542
2543         error C3861: 'kill': identifier not found
2544
2545         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2546         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
2547
2548 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2549
2550         [ews-build] Cancel build and similar operations should have authentication
2551         https://bugs.webkit.org/show_bug.cgi?id=196520
2552
2553         Reviewed by Dewei Zhu.
2554
2555         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
2556         environment variables.
2557
2558 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2559
2560         [ews-build] Do not trigger queues which are not in production yet
2561         https://bugs.webkit.org/show_bug.cgi?id=196581
2562
2563         Reviewed by Dewei Zhu.
2564
2565         * BuildSlaveSupport/ews-build/config.json:
2566
2567 2019-04-03  Chris Dumez  <cdumez@apple.com>
2568
2569         Unreviewed, fix typo in the name of API test added in r243848.
2570
2571         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2572         (TestWebKitAPI::TEST):
2573
2574 2019-04-03  Chris Dumez  <cdumez@apple.com>
2575
2576         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
2577         https://bugs.webkit.org/show_bug.cgi?id=196588
2578         <rdar://problem/49365787>
2579
2580         Reviewed by Ryosuke Niwa.
2581
2582         Add API test coverage.
2583
2584         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
2585         (TestWebKitAPI::nullJavaScriptCallback):
2586         (TestWebKitAPI::didCrashCheckFrames):
2587         (TestWebKitAPI::TEST):
2588
2589 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2590
2591         run-webkit-tests: Upload test results (new results database)
2592         https://bugs.webkit.org/show_bug.cgi?id=196577
2593         <rdar://problem/34841155>
2594
2595         Reviewed by Lucas Forschler.
2596
2597         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2598         (Manager.run): Upload results after each device shard, since the configuration will be
2599         different for each device.
2600         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
2601         uploaded to a results database.
2602         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2603         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
2604
2605 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2606
2607         -apple-trailing-word is needed for browser detection
2608         https://bugs.webkit.org/show_bug.cgi?id=196575
2609
2610         Unreviewed.
2611
2612         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2613
2614 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
2615
2616         [CMake][WTF] Mirror XCode header directories
2617         https://bugs.webkit.org/show_bug.cgi?id=191662
2618
2619         Reviewed by Konstantin Tokarev.
2620
2621         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
2622         builds.
2623
2624         * CMakeLists.txt:
2625         * DumpRenderTree/CMakeLists.txt:
2626         * DumpRenderTree/PlatformWin.cmake:
2627         * MiniBrowser/win/CMakeLists.txt:
2628         * TestWebKitAPI/CMakeLists.txt:
2629         * TestWebKitAPI/PlatformWin.cmake:
2630         * WebKitTestRunner/PlatformGTK.cmake:
2631         * WebKitTestRunner/PlatformWin.cmake:
2632
2633 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2634
2635         [ews-app] Status bubble should not display certain infrastructure status messages
2636         https://bugs.webkit.org/show_bug.cgi?id=196550
2637
2638         Reviewed by Lucas Forschler.
2639
2640         Do not display the steps which are un-needed for end-user. This information is still avaiable
2641         if the user click on the bubble and look at the Buildbot build.
2642         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2643         (StatusBubble._steps_messages):
2644         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
2645
2646 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
2647
2648         [ews-build] Use https for sending data to ews-app
2649         https://bugs.webkit.org/show_bug.cgi?id=196492
2650
2651         Reviewed by Lucas Forschler.
2652
2653         * BuildSlaveSupport/ews-build/events.py:
2654
2655 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
2656
2657         Remove support for -apple-trailing-word
2658         https://bugs.webkit.org/show_bug.cgi?id=196525
2659
2660         Reviewed by Zalan Bujtas.
2661
2662         This CSS property is nonstandard and not used.
2663
2664         * Scripts/webkitperl/FeatureList.pm:
2665         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2666
2667 2019-04-03  Youenn Fablet  <youenn@apple.com>
2668
2669         Add a test for DOMCache on multiple browsing in case of private browsing
2670         https://bugs.webkit.org/show_bug.cgi?id=196524
2671
2672         Reviewed by Alex Christensen.
2673
2674         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2675         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
2676
2677 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
2678
2679         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
2680         https://bugs.webkit.org/show_bug.cgi?id=196540
2681
2682         Reviewed by Aakash Jain.
2683
2684         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
2685
2686 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
2687
2688         Add plumbing for a compatibility mode preference in WebKit
2689         https://bugs.webkit.org/show_bug.cgi?id=196005
2690
2691         Reviewed by Tim Horton.
2692
2693         Add new API tests.
2694
2695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2696         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
2697
2698 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
2699
2700         [WPE][GTK] Update libsrtp dependency package for Debian
2701         https://bugs.webkit.org/show_bug.cgi?id=196528
2702
2703         Reviewed by Frédéric Wang.
2704
2705         * gtk/install-dependencies:
2706         * wpe/install-dependencies:
2707
2708 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2709
2710         [WK2] Add support for Window's beforeprint / afterprint events
2711         https://bugs.webkit.org/show_bug.cgi?id=196478
2712         <rdar://problem/49535124>
2713
2714         Unreviewed build fix for MSVC.
2715
2716         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
2717
2718         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
2719
2720         * WebKitTestRunner/TestController.cpp:
2721         (WTR::printFrame): Use int and float literals.
2722
2723 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2724
2725         [ews-build] Reassign bots to queues
2726
2727         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
2728
2729 2019-04-02  Chris Dumez  <cdumez@apple.com>
2730
2731         [WK2] Add support for Window's beforeprint / afterprint events
2732         https://bugs.webkit.org/show_bug.cgi?id=196478
2733
2734         Reviewed by Alex Christensen.
2735
2736         Add minimal implementation for printFrame in WebKitTestRunner.
2737
2738         * WebKitTestRunner/TestController.cpp:
2739         (WTR::printFrame):
2740         (WTR::TestController::createOtherPage):
2741         (WTR::TestController::createWebViewWithOptions):
2742
2743 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2744
2745         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
2746         https://bugs.webkit.org/show_bug.cgi?id=196491
2747
2748         Reviewed by Lucas Forschler.
2749
2750         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2751
2752 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
2753
2754         [ews-build] Configure buildbot try credentials in environment variables
2755         https://bugs.webkit.org/show_bug.cgi?id=196501
2756
2757         Reviewed by Lucas Forschler.
2758
2759         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
2760         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
2761         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
2762
2763 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2764
2765         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
2766         https://bugs.webkit.org/show_bug.cgi?id=196496
2767         <rdar://problem/49521634>
2768
2769         Reviewed by Chris Dumez.
2770
2771         Add new API tests (see WebKit ChangeLog for more detail).
2772
2773         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2774         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2775         (TEST):
2776
2777 2019-04-02  David Kilzer  <ddkilzer@apple.com>
2778
2779         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
2780         <https://webkit.org/b/196499>
2781
2782         Reviewed by Alexey Proskuryakov.
2783
2784         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
2785         ENABLE_ADDRESS_SANITIZER.
2786
2787 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
2788
2789         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
2790         https://bugs.webkit.org/show_bug.cgi?id=182757
2791
2792         Reviewed by Don Olmstead.
2793
2794         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
2795         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
2796
2797 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
2798
2799         run-api-tests: Upload test results
2800         https://bugs.webkit.org/show_bug.cgi?id=196323
2801         <rdar://problem/49356714>
2802
2803         Reviewed by Lucas Forschler.
2804
2805         * Scripts/webkitpy/api_tests/manager.py:
2806         (Manager):
2807         (Manager.run): Upload results to a results database.
2808         * Scripts/webkitpy/api_tests/run_api_tests.py:
2809         (parse_args): Add upload arguments.
2810         * Scripts/webkitpy/port/base.py:
2811         (Port):
2812         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
2813         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
2814         with commits from any other associated repositories.
2815         * Scripts/webkitpy/port/device.py:
2816         (Device):
2817         (Device.build_version): Access build_versoin of underlying platform device.
2818         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2819         (IOSSimulatorTest):
2820         (IOSSimulatorTest.test_configuration_for_upload):
2821         * Scripts/webkitpy/port/device_port.py:
2822         (DevicePort):
2823         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
2824         the same as the machine uploading results.
2825         * Scripts/webkitpy/port/mac.py:
2826         (MacPort):
2827         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
2828         * Scripts/webkitpy/port/mac_unittest.py:
2829         (MacTest):
2830         (MacTest.test_configuration_for_upload):
2831         * Scripts/webkitpy/xcode/simulated_device.py:
2832         (SimulatedDeviceManager._create_device_with_runtime):
2833         (SimulatedDevice.__init__): Create simulated device with a build_version.
2834         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
2835         (test_existing_simulator):
2836
2837 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2838
2839         Remove extra newline characters (Follow-up fix to r243707)
2840
2841         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2842
2843 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2844
2845         [ews-app] Use API_KEY to accept results data
2846         https://bugs.webkit.org/show_bug.cgi?id=196461
2847
2848         Reviewed by Dewei Zhu.
2849
2850         * BuildSlaveSupport/ews-app/ews/views/results.py:
2851         (Results.post): Validate EWS_API_KEY before accepting any data.
2852         * BuildSlaveSupport/ews-build/events.py:
2853         (Events.sendData): Send EWS_API_KEY if available along with event data.
2854
2855 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2856
2857         Unable to copy and paste a PDF from Notes into Mail compose body
2858         https://bugs.webkit.org/show_bug.cgi?id=196442
2859         <rdar://problem/48573098>
2860
2861         Reviewed by Tim Horton.
2862
2863         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
2864         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
2865         to be specified on the item providers.
2866
2867         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2868         (TestWebKitAPI::mapItemForTesting):
2869         (TestWebKitAPI::contactItemForTesting):
2870
2871 2019-04-01  Tim Horton  <timothy_horton@apple.com>
2872
2873         Make UIWKDocumentContext rects per-character instead of per-word
2874         https://bugs.webkit.org/show_bug.cgi?id=196459
2875
2876         Reviewed by Wenson Hsieh.
2877
2878         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
2879         (TEST):
2880         Adjust test results due to switching to per-character rects.
2881
2882 2019-04-01  Chris Dumez  <cdumez@apple.com>
2883
2884         UIProcess crash when a prewarmed process is terminated
2885         https://bugs.webkit.org/show_bug.cgi?id=196451
2886         <rdar://problem/49245471>
2887
2888         Reviewed by Geoffrey Garen.
2889
2890         Add API test coverage.
2891
2892         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
2893         (TEST):
2894
2895 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2896
2897         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
2898         https://bugs.webkit.org/show_bug.cgi?id=196449
2899
2900         Reviewed by Lucas Forschler.
2901
2902         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2903         (StatusBubble.get_os_details): Method to get OS and Xcode details.
2904         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
2905         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
2906
2907 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
2908
2909         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
2910         https://bugs.webkit.org/show_bug.cgi?id=196444
2911
2912         Reviewed by Lucas Forschler.
2913
2914         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
2915
2916 2019-04-01  Alex Christensen  <achristensen@webkit.org>
2917
2918         Add SPI to canonicalize NSURLs with WTF::URL
2919         https://bugs.webkit.org/show_bug.cgi?id=196415
2920         <rdar://problem/44980271>
2921
2922         Reviewed by Darin Adler.
2923
2924         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2925         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
2926         (TestWebKitAPI::TEST):
2927
2928 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
2929
2930         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
2931         https://bugs.webkit.org/show_bug.cgi?id=196441
2932
2933         Reviewed by Carlos Garcia Campos.
2934
2935         Don't cache the wpe_view_backend object that might not exist yet at the
2936         time of EventSenderProxy constructor invocation, but instead retrieve
2937         that object whenever it's required for event dispatching. This should
2938         avoid crashes in this constructor now that it's invoked before any
2939         PlatformWindow has been set up (as changed in r243496).
2940
2941         * WebKitTestRunner/EventSenderProxy.h:
2942         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
2943         (WTR::viewBackend):
2944         (WTR::EventSenderProxy::EventSenderProxy):
2945         (WTR::EventSenderProxy::mouseDown):
2946         (WTR::EventSenderProxy::mouseUp):
2947         (WTR::EventSenderProxy::mouseMoveTo):
2948         (WTR::EventSenderProxy::mouseScrollBy):
2949         (WTR::EventSenderProxy::keyDown):
2950         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
2951
2952 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2953
2954         [Win][WebKit] MiniBrowser should support high DPI display
2955         https://bugs.webkit.org/show_bug.cgi?id=196391
2956
2957         Reviewed by Alex Christensen.
2958
2959         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2960         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
2961         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
2962         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
2963
2964 2019-03-31  Sam Weinig  <weinig@apple.com>
2965
2966         Remove more i386 specific configurations
2967         https://bugs.webkit.org/show_bug.cgi?id=196430
2968
2969         Reviewed by Alexey Proskuryakov.
2970
2971         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2972         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
2973
2974 2019-03-31  Andy Estes  <aestes@apple.com>
2975
2976         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
2977         https://bugs.webkit.org/show_bug.cgi?id=196433
2978         <rdar://problem/49293305>
2979
2980         Reviewed by Tim Horton.
2981
2982         Enhanced API test coverage to include all navigation response policy decisions in both
2983         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
2984
2985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2986         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
2987         (TestWebKitAPI::TEST):
2988         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
2989         (readFile):
2990         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
2991         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
2992         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2993         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
2994         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
2995         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
2996         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
2997         (-[QuickLookDelegate _downloadDidStart:]):
2998         (-[QuickLookDelegate _download:didReceiveResponse:]):
2999         (-[QuickLookDelegate _download:didReceiveData:]):
3000         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3001         (-[QuickLookDelegate _downloadDidFinish:]):
3002         (-[QuickLookDelegate _download:didFailWithError:]):
3003         (-[QuickLookDelegate _downloadDidCancel:]):
3004         (-[QuickLookDelegate verifyDownload]):
3005         (runTest):
3006         (runTestDecideBeforeLoading):
3007         (runTestDecideAfterLoading):
3008         (TEST):
3009         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3010         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3011         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3012         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3013         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3014         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3015         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3016         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3017         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3018         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3019         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3020         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3021         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3022         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3023
3024 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3025
3026         [CMake] add testdfg as target with build-jsc
3027         https://bugs.webkit.org/show_bug.cgi?id=196393
3028
3029         Reviewed by Saam Barati.
3030
3031         Added testdfg as one of the targets to build when
3032         using CMake.
3033
3034         * Scripts/build-jsc:
3035
3036 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3037
3038         Delete WebMetal implementation in favor of WebGPU
3039         https://bugs.webkit.org/show_bug.cgi?id=195418
3040
3041         Reviewed by Dean Jackson.
3042
3043         * DumpRenderTree/mac/DumpRenderTree.mm:
3044         (enableExperimentalFeatures):
3045         (resetWebPreferencesToConsistentValues):
3046         * Scripts/webkitperl/FeatureList.pm:
3047         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3049         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3050         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3051         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3052         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3053         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3054         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3055         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3056         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3057         (WTR::InjectedBundle::beginTesting):
3058         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3059         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3060         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3061
3062 2019-03-29  Chris Dumez  <cdumez@apple.com>
3063
3064         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3065         https://bugs.webkit.org/show_bug.cgi?id=196405
3066         <rdar://problem/49428130>
3067
3068         Reviewed by Wenson Hsieh.
3069
3070         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3071         the popover presentation methods to be no-ops. Use this in the new test added in
3072         r243523 so that we do not swizzle those methods for all tests. This is needed because
3073         those WatchOS tests rely on the popover getting presented and interactive.
3074
3075         * WebKitTestRunner/TestController.cpp:
3076         (WTR::updateTestOptionsFromTestHeader):
3077         * WebKitTestRunner/TestController.h:
3078         * WebKitTestRunner/TestOptions.h:
3079         (WTR::TestOptions::hasSameInitializationOptions const):
3080         * WebKitTestRunner/ios/TestControllerIOS.mm:
3081         (WTR::TestController::platformInitialize):
3082         (WTR::TestController::platformResetStateToConsistentValues):
3083
3084 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3085
3086         [Curl] Add Server Trust Evaluation Support.
3087         https://bugs.webkit.org/show_bug.cgi?id=191646
3088
3089         Reviewed by Fujii Hironori.
3090
3091         Implemented MiniBrowser UI for asking if user trusts the server.
3092
3093         * MiniBrowser/win/Common.cpp:
3094         (askServerTrustEvaluation):
3095         (replaceString):
3096         * MiniBrowser/win/Common.h:
3097         * MiniBrowser/win/MiniBrowserLib.rc:
3098         * MiniBrowser/win/MiniBrowserLibResource.h:
3099         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3100         (createPEMString):
3101         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3102         (WebKitBrowserWindow::canTrustServerCertificate):
3103         * MiniBrowser/win/WebKitBrowserWindow.h:
3104
3105 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3106
3107         Implement ResizeObserver.
3108         https://bugs.webkit.org/show_bug.cgi?id=157743
3109
3110         Reviewed by Simon Fraser.
3111
3112         Support resizeObserverEnabled webPreferences.
3113
3114         * DumpRenderTree/TestOptions.cpp:
3115         (TestOptions::TestOptions):
3116         * DumpRenderTree/TestOptions.h:
3117         * DumpRenderTree/mac/DumpRenderTree.mm:
3118         (setWebPreferencesForTestOptions):
3119         * DumpRenderTree/win/DumpRenderTree.cpp:
3120         (enableExperimentalFeatures):
3121         * Scripts/webkitperl/FeatureList.pm:
3122         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3123
3124 2019-03-28  John Wilander  <wilander@apple.com>
3125
3126         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3127         https://bugs.webkit.org/show_bug.cgi?id=196281
3128         <rdar://problem/48938748>
3129
3130         Reviewed by Alex Christensen.
3131
3132         This patch adds the function isStatisticsHasLocalStorage() to the
3133         TestRunner. With it, the page can query the WebsiteDataStore in the
3134         UI process to make sure that it sees LocalStorage.
3135
3136         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3137         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3138         (WTR::TestRunner::isStatisticsHasLocalStorage):
3139         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3140         * WebKitTestRunner/TestController.cpp:
3141         (WTR::TestController::isStatisticsHasLocalStorage):
3142         * WebKitTestRunner/TestController.h:
3143         * WebKitTestRunner/TestInvocation.cpp:
3144         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3145
3146 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3147
3148         API::Data::createWithoutCopying should do a null check before calling CFRelease
3149         https://bugs.webkit.org/show_bug.cgi?id=196276
3150         <rdar://problem/48059859>
3151
3152         Reviewed by Alex Christensen.
3153
3154         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3155
3156         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3157         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3158         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3159         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3160         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3161         (TestWebKitAPI::TEST):
3162
3163 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3164
3165         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3166         https://bugs.webkit.org/show_bug.cgi?id=186276
3167
3168         Reviewed by Carlos Garcia Campos.
3169
3170         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3171         (webViewLoadChanged):
3172         (testWebResourceGetDataError):
3173         (testWebResourceGetDataEmpty):
3174         (beforeAll):
3175         (webViewloadChanged): Deleted.
3176
3177 2019-03-27  Andy Estes  <aestes@apple.com>
3178
3179         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3180         https://bugs.webkit.org/show_bug.cgi?id=196317
3181
3182         Reviewed by Dan Bernstein.
3183
3184         package-root copies built products into a staging directory using ditto(1), which does not
3185         follow symbolic links as it traverses a directory. Now that the files in
3186         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3187         itself, these become broken links when ditto'd into the staging directory.
3188
3189         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3190
3191         * Scripts/package-root:
3192
3193 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3194
3195         [ews-app] Update display text of Submit for ews analysis
3196         https://bugs.webkit.org/show_bug.cgi?id=196309
3197
3198         Reviewed by Dewei Zhu.
3199
3200         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3201
3202 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3203
3204         run-webkit-tests should check for leaks in WebKit processes
3205         <https://webkit.org/b/193772>
3206         <rdar://problem/46526680>
3207
3208         Reviewed by Ryosuke Niwa.
3209
3210         This works by doing the following:
3211         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3212           The list of child processes are returned one per line:
3213           process.name: pid
3214         - Run the "#LIST CHILD PROCESSES" command just before the
3215           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3216           processes on the ServerProcess object.
3217         - When the `--leaks` switch is handled, run check_for_leaks() on
3218           each child process after the main test harness.
3219
3220         * DumpRenderTree/mac/DumpRenderTree.mm:
3221         (handleControlCommand):
3222         - Use strncmp() instead of strcmp().
3223         - Add support for handling "#LIST CHILD PROCESSES" command.
3224
3225         * Scripts/webkitpy/port/base.py:
3226         (Port.check_for_leaks):
3227         * Scripts/webkitpy/port/darwin.py:
3228         (DarwinPort.check_for_leaks):
3229         - Rename redundant 'process_pid' argument to 'process_id'.
3230
3231         * Scripts/webkitpy/port/driver.py:
3232         (Driver.do_post_tests_work):
3233         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3234           longer the only command this sends to WebKitTestRunner.
3235         - If the `--leaks` switch is present, send the
3236           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3237           result using Port.set_webkit_processes().
3238         (Driver._parse_child_processes_output):
3239         - Add helper method to parse list of child process names and
3240           process IDs returned from WebKitTestRunner.
3241
3242         * Scripts/webkitpy/port/ios_device.py:
3243         (IOSDevicePort.check_for_leaks):
3244         - Rename redundant 'process_pid' argument to 'process_id'.
3245
3246         * Scripts/webkitpy/port/leakdetector.py:
3247         (LeakDetector._parse_leaks_output):
3248         - Return early if there is no leaks_output.
3249         (LeakDetector.check_for_leaks):
3250         - Rename redundant 'process_pid' argument to 'process_id'.
3251
3252         * Scripts/webkitpy/port/server_process.py:
3253         (ServerProcess.__init__):
3254         (ServerProcess.child_processes):
3255         (ServerProcess.set_child_processes):
3256         - Add instance variable to Port to store list of child process
3257           names and process IDs returned from WebKitTestRunner.
3258         (ServerProcess._start):
3259         - Clear self._child_processes.
3260         (ServerProcess.stop):
3261         - If self._child_processes is set, call
3262           self._port.check_for_leaks() for each child process.
3263
3264         * Scripts/webkitpy/port/server_process_unittest.py:
3265         (TrivialMockPort.check_for_leaks):
3266         - Rename redundant 'process_pid' argument to 'process_id'.
3267
3268         * Scripts/webkitpy/port/simulator_process.py:
3269         (SimulatorProcess.stop):
3270         - If self._child_processes is set, call
3271           self._port.check_for_leaks() for each child process.
3272
3273         * Scripts/webkitpy/port/watch_device.py:
3274         (WatchDevicePort.check_for_leaks):
3275         - Rename redundant 'process_pid' argument to 'process_id'.
3276
3277         * WebKitTestRunner/TestController.cpp:
3278         (WTR::TestController::dumpResponse):
3279         - Extract method from findAndDumpWorldLeaks() so that it may be
3280           reused by findAndDumpWebKitProcessIdentifiers().
3281         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3282         - Add method to output process name and process ID of both the
3283           WebContent and Networking processes.
3284         (WTR::TestController::findAndDumpWorldLeaks):
3285         - Fix missing newline in output when there were no abandoned
3286           documents.
3287         - Call dumpResponse() for extracted code.
3288         (WTR::TestController::handleControlCommand):
3289         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3290         - Use strncmp() instead of strcmp().
3291         - Call findAndDumpWebKitProcessIdentifiers() when
3292           "#LIST CHILD PROCESSES" command is sent.
3293         * WebKitTestRunner/TestController.h:
3294         (WTR::TestController::dumpResponse):
3295         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3296         - Declare methods.
3297
3298 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3299
3300         Unreviewed. Add GLib API test cases after r243434.
3301
3302         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3303         (testWebViewActiveURI):
3304         (serverCallback):
3305         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3306         (sendRequestCallback):
3307
3308 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3309
3310         Geolocation request not complete when watch request was started in a different web process
3311         https://bugs.webkit.org/show_bug.cgi?id=195996
3312
3313         Reviewed by Alex Christensen.
3314
3315         Add a test case.
3316
3317         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3318         (TestWebKitAPI::runJavaScriptAlert):
3319         (TestWebKitAPI::TEST):
3320
3321 2019-03-26  Keith Rollin  <krollin@apple.com>
3322
3323         Update the way generate-xcfilelists returns strings from functions
3324         https://bugs.webkit.org/show_bug.cgi?id=195975
3325         <rdar://problem/49040807>
3326
3327         Reviewed by Dean Jackson.
3328
3329         There are places where generate-xcfilelists executes assignments with
3330         statements like:
3331
3332             FOO=$(some_function)
3333
3334         where "some_function" return a string by echoing it. E.g.
3335
3336             some_function()
3337             {
3338                 echo "Hello, World"
3339             }
3340
3341         This is a common idiom, but it has a problem if "some_function" needs
3342         to call "exit" in an attempt to halt the entire script right then and
3343         there. Since "some_function" is called inside of $(), it's being
3344         executed in a sub-shell. Calling exit in that sub-shell simply exits
3345         that shell; it doesn't not exit the outer shell in which the main part
3346         of the script is still running. As such, the main script keeps
3347         executing when the intent was for the script to halt.
3348
3349         The solution to this is to use a different idiom for returning
3350         strings. The one we now is to pass in the name of the variable to
3351         receive the string result:
3352
3353             some_function()
3354             {
3355                 variable_name=$1
3356                 eval $variable_name ="Hello, World"
3357             }
3358
3359         The call site now looks like
3360
3361             some_function FOO
3362
3363         Because there's no invocation of a sub-shell, some_function can now
3364         call "exit" if it wants to, and the entire script will exit at that
3365         point.
3366
3367         * Scripts/generate-xcfilelists:
3368
3369 2019-03-26  Chris Dumez  <cdumez@apple.com>
3370
3371         Add basic layout test coverage for File Picker on iOS
3372         https://bugs.webkit.org/show_bug.cgi?id=196265
3373
3374         Reviewed by Wenson Hsieh.
3375
3376         Add layout test infrastructure to test the file picker on iOS.
3377
3378         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3379         (WTR::UIScriptController::dismissFilePicker):
3380         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3381         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3382         (WTR::UIScriptController::dismissFilePicker):
3383         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3384         * WebKitTestRunner/TestController.cpp:
3385         (WTR::TestController::createWebViewWithOptions):
3386         (WTR::updateTestOptionsFromTestHeader):
3387         * WebKitTestRunner/TestOptions.h:
3388         (WTR::TestOptions::hasSameInitializationOptions const):
3389         * WebKitTestRunner/ios/TestControllerIOS.mm:
3390         (overridePresentViewController):
3391         (WTR::TestController::platformInitialize):
3392         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3393         (WTR::UIScriptController::dismissFilePicker):
3394
3395 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
3396
3397         Implement async paste method on UIWKInteractionViewProtocol
3398         https://bugs.webkit.org/show_bug.cgi?id=196267
3399         <rdar://problem/49236346>
3400
3401         Reviewed by Tim Horton.
3402
3403         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
3404         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
3405         are now a part of all iOS 12 internal SDKs.
3406
3407         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
3408
3409         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
3410         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
3411
3412         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
3413         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
3414         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
3415         * TestWebKitAPI/ios/UIKitSPI.h:
3416
3417 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3418
3419         [ews-build] Use PostgreSQL for ews.webkit.org database
3420         https://bugs.webkit.org/show_bug.cgi?id=196270
3421
3422         Reviewed by Lucas Forschler.
3423
3424         * BuildSlaveSupport/ews-app/ews-app/settings.py:
3425
3426 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
3427
3428         [ews] Reset simctl states on reboot
3429         https://bugs.webkit.org/show_bug.cgi?id=196260
3430
3431         Rubber-stamped by Aakash Jain.
3432
3433         * EWSTools/start-queue-mac.sh:
3434
3435 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3436
3437         [ews-build] Use PostgreSQL for ews-build database
3438         https://bugs.webkit.org/show_bug.cgi?id=196229
3439
3440         Reviewed by Lucas Forschler.
3441
3442         * BuildSlaveSupport/ews-build/master.cfg:
3443
3444 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3445
3446         [ews-build] Get master_hostname dynamically in master.cfg
3447         https://bugs.webkit.org/show_bug.cgi?id=196255
3448
3449         Reviewed by Lucas Forschler.
3450
3451         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
3452         send events data in test mode.
3453
3454 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3455
3456         [ews-app] Set db_constraint to False for Foreign Keys
3457         https://bugs.webkit.org/show_bug.cgi?id=196252
3458
3459         Reviewed by Lucas Forschler.
3460
3461         * BuildSlaveSupport/ews-app/ews/models/build.py:
3462         * BuildSlaveSupport/ews-app/ews/models/step.py:
3463
3464 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3465
3466         [ews-build] is_test_mode_enabled should default to True
3467         https://bugs.webkit.org/show_bug.cgi?id=196248
3468
3469         Reviewed by Lucas Forschler.
3470
3471         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
3472
3473 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
3474
3475         [ews-app] Add webkitperl to ENABLED_QUEUES
3476         https://bugs.webkit.org/show_bug.cgi?id=196253
3477
3478         Reviewed by Lucas Forschler.
3479
3480         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3481
3482 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
3483
3484         Address NSWindow sometimes using WebKitTestRunnerEvent too early
3485         https://bugs.webkit.org/show_bug.cgi?id=196211
3486         rdar://problem/49110552
3487
3488         Reviewed by Tim Horton.
3489
3490         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
3491         Make sure that EventSenderProxy always exists when running tests. We used to create
3492         it when resetting before the first test, which is a bit too late.
3493
3494         * WebKitTestRunner/TestController.h:
3495         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3496         (WTR::TestController::platformCreateWebView):
3497         (WTR::TestController::platformCreateOtherPage):
3498         (WTR::TestController::finishCreatingPlatformWebView):
3499         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3500         (WTR::PlatformWebView::PlatformWebView):
3501         Moved some code that made NSWindow use NSEvent during web view creation. We may
3502         need to move more if some other case us found, but this is enough for now.
3503
3504 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
3505
3506         Unreviewed. Fix typo in GLib geolocation API after r243285.
3507
3508         gelocation -> geolocation.
3509
3510         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
3511         (testGeolocationManagerWatchPosition):
3512
3513 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3514
3515         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3516         https://bugs.webkit.org/show_bug.cgi?id=196213
3517
3518         Reviewed by Geoff Garen.
3519
3520         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3521         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3522         (credentialWithIdentityAndKeychainPath):
3523         (-[ChallengeDelegate webView:didFinishNavigation:]):
3524         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3525         (TestWebKitAPI::TEST):
3526
3527 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3528
3529         Expected shouldn't assume its contained types are copyable
3530         https://bugs.webkit.org/show_bug.cgi?id=195986
3531
3532         Reviewed by JF Bastien.
3533
3534         * TestWebKitAPI/Tests/WTF/Expected.cpp:
3535         (TestWebKitAPI::NonCopyable::operator== const):
3536         (TestWebKitAPI::NonCopyable::operator!= const):
3537         (TestWebKitAPI::TEST):
3538
3539 2019-03-25  Tim Horton  <timothy_horton@apple.com>
3540
3541         Remove some now-unnecessary dynamic class lookup
3542         https://bugs.webkit.org/show_bug.cgi?id=196237
3543
3544         Reviewed by Simon Fraser.
3545
3546         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3547         (makeRequest):
3548         (TEST):
3549
3550 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
3551
3552         Unreviewed, rolling out r243450.
3553
3554         AppleWin and WinCairo port builds get broken.
3555
3556         Reverted changeset:
3557
3558         "Add test for fix of #196095"
3559         https://bugs.webkit.org/show_bug.cgi?id=196097
3560         https://trac.webkit.org/changeset/243450
3561
3562 2019-03-25  Commit Queue  <commit-queue@webkit.org>
3563
3564         Unreviewed, rolling out r243465.
3565         https://bugs.webkit.org/show_bug.cgi?id=196226
3566
3567         the test doesn't build (Requested by thorton on #webkit).
3568
3569         Reverted changeset:
3570
3571         "Do not terminate the NetworkProcess if a third party
3572         application sends a NSCredential with a SecIdentityRef"
3573         https://bugs.webkit.org/show_bug.cgi?id=196213
3574         https://trac.webkit.org/changeset/243465
3575
3576 2019-03-25  Alex Christensen  <achristensen@webkit.org>
3577
3578         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
3579         https://bugs.webkit.org/show_bug.cgi?id=196213
3580
3581         Reviewed by Geoff Garen.
3582
3583         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3584         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
3585         (credentialWithIdentityAndKeychainPath):
3586         (-[ChallengeDelegate webView:didFinishNavigation:]):
3587         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3588         (TestWebKitAPI::TEST):
3589
3590 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3591
3592         [ews-build] Gracefully handle missing patch_id in events
3593         https://bugs.webkit.org/show_bug.cgi?id=196216
3594
3595         Reviewed by Lucas Forschler.
3596
3597         * BuildSlaveSupport/ews-build/events.py:
3598
3599 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
3600
3601         [ews-build] use lz4 compression for improving buildbot performance
3602         https://bugs.webkit.org/show_bug.cgi?id=196155
3603
3604         Reviewed by Lucas Forschler.
3605
3606         * BuildSlaveSupport/ews-build/master.cfg:
3607
3608 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3609
3610         Pull some API testing helper methods out of TestWKWebView
3611         https://bugs.webkit.org/show_bug.cgi?id=196212
3612
3613         Reviewed by Tim Horton.
3614
3615         Refactor some more API testing utility methods, so that they can be used in
3616         tests that do not use TestWKWebView.
3617
3618         * TestWebKitAPI/cocoa/TestWKWebView.h:
3619         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3620         (-[WKWebView loadTestPageNamed:]):
3621         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
3622         (-[WKWebView synchronouslyLoadHTMLString:]):
3623         (-[WKWebView synchronouslyLoadTestPageNamed:]):
3624         (-[TestWKWebView loadTestPageNamed:]): Deleted.
3625         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
3626         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
3627         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
3628
3629 2019-03-25  Jer Noble  <jer.noble@apple.com>
3630
3631         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
3632         https://bugs.webkit.org/show_bug.cgi?id=196097
3633
3634         Reviewed by Eric Carlson.
3635
3636         Drive-by bug fix: allow tests to play audio without a user gesture by default.
3637
3638         * DumpRenderTree/mac/DumpRenderTree.mm:
3639         (resetWebPreferencesToConsistentValues):
3640         * WebKitTestRunner/TestController.cpp:
3641         (WTR::TestController::resetPreferencesToConsistentValues):
3642
3643 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3644
3645         Pull IPadUserInterfaceSwizzler out into a separate header file
3646         https://bugs.webkit.org/show_bug.cgi?id=196193
3647
3648         Reviewed by Anders Carlsson.
3649
3650         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
3651         be used in other API tests.
3652
3653         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3654         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
3655         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.