73d640b470e5e9f429eb156d31956171d4bde17e
[WebKit-https.git] / Tools / ChangeLog
1 2015-08-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2
3         Unreviewed. run-gtk-tests: Use a longer timeout for slow tests.
4
5         In r188125 I added a way to mark tests as slow to use a longer
6         timeout. But it seems it was not enough for
7         WTF_Lock.ContendedShortSection, so let's try again with a longer
8         timeout now.
9
10         * Scripts/run-gtk-tests:
11         (TestRunner._run_google_test):
12
13 2015-08-12  Yusuke Suzuki  <utatane.tea@gmail.com>
14
15         Allow --debug option in run-jsc
16         https://bugs.webkit.org/show_bug.cgi?id=147923
17
18         Reviewed by Csaba Osztrogonác.
19
20         When `--debug` option is specified in run-jsc, it runs the JSC shell built in the debug mode.
21
22         * Scripts/run-jsc:
23
24 2015-08-11  Alex Christensen  <achristensen@webkit.org>
25
26         Fix test after build fix in r188286.
27         https://bugs.webkit.org/show_bug.cgi?id=147907
28
29         Reviewed by Anders Carlsson.
30
31         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
32         sleep_for can now be used, but we need to include <thread>
33
34 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
35
36         Always use a byte-sized lock implementation
37         https://bugs.webkit.org/show_bug.cgi?id=147908
38
39         Reviewed by Geoffrey Garen.
40
41         All previous tests of Lock are now tests of WordLock. All previous tests of ByteLock are
42         now tests of Lock.
43
44         * TestWebKitAPI/Tests/WTF/Lock.cpp:
45         (TestWebKitAPI::runLockTest):
46         (TestWebKitAPI::TEST):
47
48 2015-08-11  Alexey Proskuryakov  <ap@apple.com>
49
50         Make ASan build not depend on asan.xcconfig
51         https://bugs.webkit.org/show_bug.cgi?id=147840
52         rdar://problem/21093702
53
54         Reviewed by Daniel Bates.
55
56         * asan/asan.xcconfig:
57         * asan/webkit-asan-ignore.txt: Removed. It's no longer needed, as unsafe functions
58         are now marked in source code.
59
60 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
61
62         Unreviewed, shorten another test since it timed out.
63
64         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
65         (TestWebKitAPI::TEST):
66
67 2015-08-11  Mark Lam  <mark.lam@apple.com>
68
69         Fix names of Lock tests: should be "Contended", not "Contented".
70         https://bugs.webkit.org/show_bug.cgi?id=147905
71
72         Reviewed by Saam Barati.
73
74         We're testing the behavior of lock contention (i.e. when threads contend), not
75         whether the locks are happy (contented).
76
77         * Scripts/run-gtk-tests:
78         (TestRunner):
79         (TestRunner.__init__): Deleted.
80         * TestWebKitAPI/Tests/WTF/Lock.cpp:
81         (TestWebKitAPI::runLockTest):
82         (TestWebKitAPI::TEST):
83
84 2015-08-11  Alex Christensen  <achristensen@webkit.org>
85
86         Update WinCairoRequirements to VS2015.
87
88         * Scripts/update-webkit-wincairo-libs:
89         Update WinCairoRequirements location.
90
91 2015-08-11  Jason Marcell  <jmarcell@apple.com>
92
93         Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac
94         for internalTrac.
95         https://bugs.webkit.org/show_bug.cgi?id=147805
96
97         Reviewed by Daniel Bates.
98
99         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
100         (BuildbotQueueView): Substituted Dashboard.Repository.OpenSource.trac for webkitTrac and
101         Dashboard.Repository.Internal.trac for internalTrac.
102         (BuildbotQueueView.prototype._appendPendingRevisionCount): Added local variables webkitTrac
103         and internalTrac for Dashboard.Repository.OpenSource.trac and Dashboard.Repository.Internal.trac,
104         respectively.
105         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
106         (BuildbotQueueView.prototype.revisionContentForIteration): Substituted
107         Dashboard.Repository.OpenSource.trac for webkitTrac and Dashboard.Repository.Internal.trac for
108         internalTrac.
109         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js: Ditto.
110         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Ditto.
111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
112         (Analyzer): Ditto.
113         (Analyzer.prototype.analyze): Ditto.
114
115 2015-08-11  Filip Pizlo  <fpizlo@apple.com>
116
117         Unreviewed, gardening these tests to run faster so that they don't timeout on slower OSes.
118
119         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
120         (TestWebKitAPI::TEST):
121
122 2015-08-11  Brent Fulgham  <bfulgham@apple.com>
123
124         [Win] Switch Windows build to Visual Studio 2015
125         https://bugs.webkit.org/show_bug.cgi?id=147887
126         <rdar://problem/22235098>
127
128         Reviewed by Alex Christensen.
129
130         Update Visual Studio project file settings to use the current Visual
131         Studio and compiler. Continue targeting binaries to run on our minimum
132         supported configuration of Windows 7.
133
134         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
135         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
136         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
137         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
138         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
139         * Scripts/webkitdirs.pm: Modify our Visual Studio search routines to
140         prefer the newer MSBuild included in Visual Studio 2015.
141         (visualStudioInstallDir):
142         (msBuildInstallDir):
143         (visualStudioVersion):
144         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
145         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
146         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
147         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
148         * win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
149         * win/record-memory/record-memory.vcxproj:
150
151 2015-08-11  Alex Christensen  <achristensen@webkit.org>
152
153         Another speculative build fix after r188280.
154
155         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
156         std::this_thread is too modern c++ for VS2013 and supported GCC versions, 
157         so let's go back to usleep and I made something close to usleep, but with much lower resolution.
158
159 2015-08-11  Alex Christensen  <achristensen@webkit.org>
160
161         Unreviewed build fix after r188280.
162
163         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
164         Include DataLog.h, and usleep is not available on Windows, so I used what I think is the c++11 equivalent.
165
166 2015-08-10  Filip Pizlo  <fpizlo@apple.com>
167
168         WTF should have a ParkingLot for parking sleeping threads, so that locks can fit in 1.6 bits
169         https://bugs.webkit.org/show_bug.cgi?id=147665
170
171         Reviewed by Mark Lam.
172
173         * TestWebKitAPI/CMakeLists.txt:
174         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
175         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
176         * TestWebKitAPI/Tests/WTF/Lock.cpp:
177         (TestWebKitAPI::TEST):
178         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp: Added.
179         (TestWebKitAPI::TEST):
180
181 2015-08-11  Brian Burg  <bburg@apple.com>
182
183         webkit-patch should not explode when $EDITOR is set incorrectly
184         https://bugs.webkit.org/show_bug.cgi?id=147884
185
186         Reviewed by Darin Adler.
187
188         If $EDITOR doesn't exist, log a warning and continue.
189
190         * Scripts/webkitpy/common/system/user.py: 
191         (User.edit):
192         (User.edit_changelog):
193
194 2015-08-11  Dan Bernstein  <mitz@apple.com>
195
196         Reverted r188255, because it turned out that delegates do nonot need this information.
197
198         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
199         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Removed.
200
201 2015-08-11  Dan Bernstein  <mitz@apple.com>
202
203         [Cocoa] The UI delegate can't tell if printing was user-initiated
204         https://bugs.webkit.org/show_bug.cgi?id=147869
205
206         Reviewed by Sam Weinig.
207
208         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
209         * TestWebKitAPI/Tests/WebKit2Cocoa/PrintFrame.mm: Added.
210         (-[PrintFrameController webView:didFinishNavigation:]):
211         (-[PrintFrameController _webView:printFrame:userInitiated:]):
212         (TEST):
213
214 2015-08-10  Alex Christensen  <achristensen@webkit.org>
215
216         Another build fix after r188239.
217
218         * TestWebKitAPI/PlatformWin.cmake:
219         Link with more libraries.
220         * WinLauncher/CMakeLists.txt:
221         /NODEFAULTLIB:MSVCRT is not just needed for AppleWin.
222
223 2015-08-10  Ryosuke Niwa  <rniwa@webkit.org>
224
225         Build fix after r188237.
226
227         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
228         (BenchmarkBuilder.__enter__):
229
230 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
231
232         Update ReadMe and correct the way to use abstract abstract class.
233         https://bugs.webkit.org/show_bug.cgi?id=147860
234
235         Reviewed by Ryosuke Niwa.
236
237         Update ReadMe according to recent changes. And set ABCMeta to be the __metaclass__ of BrowserDriver and HTTPServerDriver,
238         so that all methods annotated by 'abstractmethod' will check whether they are implememnt by subclasses.
239
240         * Scripts/webkitpy/benchmark_runner/README.md:
241         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
242         (BrowserDriver):
243         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
244         (OSXBrowserDriver.restore_env):
245         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
246         (HTTPServerDriver):
247         (HTTPServerDriver.set_device_id):
248         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
249         (SimpleHTTPServerDriver.get_return_code):
250         (SimpleHTTPServerDriver):
251         (SimpleHTTPServerDriver.set_device_id):
252
253 2015-08-10  Alex Christensen  <achristensen@webkit.org>
254
255         Build TestWebKitAPI with CMake on Windows
256         https://bugs.webkit.org/show_bug.cgi?id=147851
257
258         Reviewed by Chris Dumez.
259
260         * CMakeLists.txt:
261         * TestWebKitAPI/CMakeLists.txt:
262         Removed TestJavaScriptCore because JavaScriptCore's API tests are elsewhere and this was just making an empty binary.
263         Surrounded WebKit2-specific features with ENABLE_WEBKIT2 checks.
264         Include directories after the Platform*.cmake is included because HostWindow.h needs to be found in Tools/TestWebKitAPI/win 
265         before we look in Source/WebCore/platform, where another file named HostWindow.h exists.
266         * TestWebKitAPI/PlatformEfl.cmake:
267         * TestWebKitAPI/PlatformGTK.cmake:
268         Windows needs all the binaries to be in the same directory to find gtest.dll and the other dlls.
269         I did this without changing the directory structure of the existing EFL and GTK builds.
270         * TestWebKitAPI/PlatformWin.cmake: Added.
271         * TestWebKitAPI/win/main.cpp:
272         (main):
273         (dllLauncherEntryPoint):
274         Added so we can launch TestWebKitAPI executables after finding the AAS directory.
275         * WinLauncher/CMakeLists.txt:
276         AppleWin port needs /NODEFAULTLIB:MSVCRT.
277
278 2015-08-10  Dewei Zhu  <dewei_zhu@apple.com>
279
280         Make cleanup more robust and minor code cleaning in run benchmark script.
281         https://bugs.webkit.org/show_bug.cgi?id=147800
282
283         Reviewed by Ryosuke Niwa.
284
285         Use 'finnaly' block to make sure cleanup code is always executed.
286
287         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
288         (built_benchmark):
289         (built_benchmark.__init__):
290         (built_benchmark.__enter__):
291         (built_benchmark.__exit__):
292         (test_environment):
293         (test_environment.__init__):
294         (test_environment.__enter__):
295         (test_environment.__exit__):
296         (BenchmarkRunner.__init__):
297         (BenchmarkRunner.execute):
298         (BenchmarkRunner._dump):
299         (BenchmarkRunner._wrap):
300         (BenchmarkRunner): Deleted.
301         (BenchmarkRunner._cleanup): Deleted.
302         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
303         (BrowserDriver.close_browsers):
304         (BrowserDriver):
305         (BrowserDriver.restore_env):
306         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
307         (SimpleHTTPServerDriver.__init__): We do not actually need to know external ip address for now.
308
309 2015-08-10  Youenn Fablet  <youenn.fablet@crf.canon.fr>
310
311         Compile warning (-Wsign-compare) on 32-bits at WebCore/platform/FileSystem.cpp
312         https://bugs.webkit.org/show_bug.cgi?id=146414
313
314         Reviewed by Darin Adler.
315
316         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
317         (TestWebKitAPI::TEST): Improving testing of WTF::isInBounds.
318
319 2015-08-10  Carlos Garcia Campos  <cgarcia@igalia.com>
320
321         [GTK] Test  /webkit2/WebKitWebView/submit-form is flaky
322         https://bugs.webkit.org/show_bug.cgi?id=147727
323
324         Reviewed by Sergio Villar Senin.
325
326         I think it was not this test in particular, but
327         /webkit2/WebKitWebView/custom-charset that is affecting the
328         others. This is because changing the encoding reloads the page,
329         but we don't wait for the page to be reloaded, so when the test
330         finishes and other test starts the web process is still reloading
331         the page.
332
333         * Scripts/run-gtk-tests:
334         (TestRunner): Unskip /webkit2/WebKitWebView/submit-form.
335         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
336         (testWebViewCustomCharset): Wait until page is reloaded after
337         changing the charset.
338
339 2015-08-09  Carlos Garcia Campos  <cgarcia@igalia.com>
340
341         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/install-missing-plugins-permission-request.
342
343         It's timing out in the bots. My guess is that there's no installer
344         installed in the bots and gst_install_plugins_supported() returns
345         false, so we don't even get a permission request because no
346         installer will be launched.
347
348         * Scripts/run-gtk-tests:
349         (TestRunner):
350
351 2015-08-07  Alex Christensen  <achristensen@webkit.org>
352
353         [GTK] Another build fix after r188157.
354
355         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
356         (WTR::PlatformWebView::viewSupportsOptions):
357         Name all the things correctly!
358
359 2015-08-07  Alex Christensen  <achristensen@webkit.org>
360
361         [EFL, GTK] Build fix after r188176.
362
363         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
364         I moved forwarding headers out of a unix subdirectory because I am using them on Windows now.
365
366 2015-08-07  Alex Christensen  <achristensen@webkit.org>
367
368         [GTK] Speculative build fix after r188157.
369
370         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
371         (WTR::PlatformWebView::PlatformWebView):
372         Update parameter list.
373
374 2015-08-07  Alex Christensen  <achristensen@webkit.org>
375
376         Build more testing binaries with CMake on Windows
377         https://bugs.webkit.org/show_bug.cgi?id=147799
378
379         Reviewed by Brent Fulgham.
380
381         * DumpRenderTree/CMakeLists.txt:
382         Build TestNetscapePlugin.
383         * DumpRenderTree/PlatformWin.cmake:
384         Build ImageDiff and add files necessary for TestNetscapePlugin on Windows.
385         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders: Added.
386         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit: Added.
387         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h.
388         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h.
389         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h: Copied from DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h.
390         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Removed.
391         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Removed.
392         * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Removed.
393
394 2015-08-07  Jason Marcell  <jmarcell@apple.com>
395
396         Refactor BuildbotQueue.compareIterations and BuildbotQueue.compareIterationsByRevisions to be more generic
397         https://bugs.webkit.org/show_bug.cgi?id=147667
398
399         Reviewed by Daniel Bates.
400
401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
402         (BuildbotQueue.prototype.compareIterations): Refactored to work more generically with repositories
403         other than "openSource" and "internal".
404         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
405         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
406         (Dashboard.get sortedPlatforms): Added. Returns a sorted array of platforms.
407         (Dashboard.get sortedRepositories): Added. Returns a sorted array of repositories.
408         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
409         (documentReady): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
410         (sortedPlatforms): Deleted.
411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsMain.js:
412         (buildQueuesTable): Using Dashboard.sortedPlatforms instead of sortedPlatforms.
413         (sortedPlatforms): Deleted.
414         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Utilities.js:
415         (sortDictionariesByOrder): Added. Takes an array of dictionaries that have an "order" property
416         and sorts them by this property returning the new sorted array.
417
418 2015-08-07  Filip Pizlo  <fpizlo@apple.com>
419
420         Lightweight locks should be adaptive
421         https://bugs.webkit.org/show_bug.cgi?id=147545
422
423         Reviewed by Geoffrey Garen.
424
425         * TestWebKitAPI/CMakeLists.txt:
426         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
427         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
428         * TestWebKitAPI/Tests/WTF/Lock.cpp: Added.
429         (TestWebKitAPI::runLockTest):
430         (TestWebKitAPI::TEST):
431
432 2015-08-07  Anders Carlsson  <andersca@apple.com>
433
434         Fix a tyop.
435
436         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
437         (WTR::PlatformWebView::viewSupportsOptions):
438
439 2015-08-07  Alexey Proskuryakov  <ap@apple.com>
440
441         Update AppEngine app version numbers to the latest commit.
442
443         * QueueStatusServer/app.yaml:
444         * TestResultServer/app.yaml:
445
446 2015-08-07  Anders Carlsson  <andersca@apple.com>
447
448         Simplify WKTR's view options
449         https://bugs.webkit.org/show_bug.cgi?id=147791
450
451         Reviewed by Sam Weinig.
452
453         Instead of using a WKDictionaryRef, just use a struct for the options.
454
455         * WebKitTestRunner/PlatformWebView.h:
456         (WTR::PlatformWebView::options):
457         (WTR::PlatformWebView::viewSupportsOptions): Deleted.
458         * WebKitTestRunner/TestController.cpp:
459         (WTR::TestController::initialize):
460         (WTR::TestController::createWebViewWithOptions):
461         (WTR::TestController::ensureViewSupportsOptions):
462         (WTR::TestController::updateLayoutTypeForTest):
463         * WebKitTestRunner/TestController.h:
464         * WebKitTestRunner/ViewOptions.h: Added.
465         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
466         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
467         (WTR::PlatformWebView::PlatformWebView):
468         (WTR::PlatformWebView::viewSupportsOptions):
469         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
470         (WTR::PlatformWebView::viewSupportsOptions):
471         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
472         (WTR::PlatformWebView::viewSupportsOptions):
473         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
474         (WTR::PlatformWebView::PlatformWebView):
475         (WTR::PlatformWebView::viewSupportsOptions):
476         * WebKitTestRunner/mac/TestControllerMac.mm:
477         (WTR::TestController::platformConfigureViewForTest):
478
479 2015-08-07  Joseph Pecoraro  <pecoraro@apple.com>
480
481         Running tests for a long time results in some tests running very slowly (throttling)
482         https://bugs.webkit.org/show_bug.cgi?id=147718
483
484         Reviewed by Chris Dumez.
485
486         Follow-up, make DumpRenderTree consistent with WebKitTestRunner.
487         Although COCOA ports default this setting to be disabled in WebKit1,
488         we should make both test harnesses disable the setting for consistency.
489
490         * DumpRenderTree/mac/DumpRenderTree.mm:
491         (resetWebPreferencesToConsistentValues):
492
493 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
494
495         Use a specific version of Speedometer in run-benchmark
496         https://bugs.webkit.org/show_bug.cgi?id=147769
497
498         Reviewed by Chris Dumez.
499
500         Use the current latest revision as we work towards the bug 147768 (Update frameworks in Speedometer).
501
502         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
503
504 2015-08-07  Ryosuke Niwa  <rniwa@webkit.org>
505
506         twisted_http_server.py should support --port
507         https://bugs.webkit.org/show_bug.cgi?id=147771
508
509         Reviewed by Chris Dumez.
510
511         Added the option. This makes the script more useful on its own.
512
513         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
514
515 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
516
517         [GTK] WTF unit tests are timing out in the bots
518         https://bugs.webkit.org/show_bug.cgi?id=147777
519
520         Reviewed by Filip Pizlo.
521
522         Add a way to mark google unit tests as slow and add
523         WTF_Lock.ContentedShortSection to the list. In case of slow test
524         we use the double of the given timeout for that particular test.
525
526         * Scripts/run-gtk-tests:
527         (TestRunner):
528         (TestRunner._run_google_test):
529
530 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
531
532         [GTK] run-gtk-tests should not stop when a google test case fails
533         https://bugs.webkit.org/show_bug.cgi?id=147778
534
535         Reviewed by Philippe Normand.
536
537         For glib based tests we run the test runner with the -k option,
538         but for google tests we are aborting as soon as we find a failure.
539
540         * Scripts/run-gtk-tests:
541         (TestRunner._run_google_test_suite): Use a global return code that
542         is set to 1 when any test has failed.
543
544 2015-08-07  Carlos Garcia Campos  <cgarcia@igalia.com>
545
546         [GStreamer] Do not automatically show PackageKit codec installation notifications
547         https://bugs.webkit.org/show_bug.cgi?id=135973
548
549         Reviewed by Philippe Normand.
550
551         Handle the missing media plugins installation permission request
552         in MiniBrowser and add a test case for the new API.
553
554         * MiniBrowser/gtk/BrowserWindow.c:
555         (webViewDecidePermissionRequest):
556         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
557         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
558         (permissionRequestCallback):
559         (testInstallMissingPluginsPermissionRequest):
560         (beforeAll):
561         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
562         (methodCallCallback):
563
564 2015-08-06  Joseph Pecoraro  <pecoraro@apple.com>
565
566         Running tests for a long time results in some tests running very slowly (throttling)
567         https://bugs.webkit.org/show_bug.cgi?id=147718
568
569         Reviewed by Alexey Proskuryakov.
570
571         * WebKitTestRunner/TestController.cpp:
572         (WTR::TestController::resetPreferencesToConsistentValues):
573         Ensure throttling settings are disabled for tests for all ports, as
574         COCOA ports default to having these setting enabled. Note, there is
575         still other timer throttling not covered by these setting.
576
577 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
578
579         http_server_driver and benchmark_builder should not be in run-benchmark's plan files
580         https://bugs.webkit.org/show_bug.cgi?id=147752
581
582         Reviewed by Chris Dumez.
583
584         Removed BenchmarkBuilderFactory since we have exactly one subclass of BenchmarkBuilder.
585
586         Also made HTTPServerDriverFactory instantiate the appropriate HTTP server based on the platform name instead of HTTP server name.
587         This allows us to remove --http-server-driver option from run-benchmark, which was added to support the HTTP server for iOS.
588
589         * Scripts/webkitpy/benchmark_runner/benchmark_builder: Removed.
590         * Scripts/webkitpy/benchmark_runner/benchmark_builder.py: Moved from benchmark_runner/benchmark_builder/generic_benchmark_builder.py.
591         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py: Removed.
592         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py: Removed.
593         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py: Moved to benchmark_runner/benchmark_builder.py.
594         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
595         (BenchmarkRunner.__init__): No longer takes http_server_driver_override as an argument since this is not handled by
596         HTTPServerDriverFactory taking the platform name as an argument.
597         (BenchmarkRunner.execute): Directly instantiate BenchmarkBuilder.
598         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Removed http_server_driver and benchmark_builder.
599         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Ditto.
600         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
601         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Ditto.
602         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Ditto.
603         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Ditto.
604         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
605         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: Ditto.
606         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Ditto.
607         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
608         (http_server_driver_loader): Register http server drivers via supported platform names instead of http server names.
609         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
610         (HTTPServerDriver): Replaced name by platforms.
611         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
612         (SimpleHTTPServerDriver): Ditto.
613         * Scripts/webkitpy/benchmark_runner/run_benchmark.py:
614         (parse_args): Removed --http-server-driver option.
615         (start): Ditto.
616
617 2015-08-06  Chris Dumez  <cdumez@apple.com>
618
619         Toggle GPS state based on page visibility to save battery
620         https://bugs.webkit.org/show_bug.cgi?id=147685
621
622         Reviewed by Benjamin Poulain.
623
624         Add testRunner.isGeolocationProviderActive() test support function.
625
626         * DumpRenderTree/TestRunner.cpp:
627         (isGeolocationProviderActiveCallback):
628         (TestRunner::staticFunctions):
629         * DumpRenderTree/TestRunner.h:
630         * DumpRenderTree/mac/MockGeolocationProvider.h:
631         * DumpRenderTree/mac/MockGeolocationProvider.mm:
632         (-[MockGeolocationProvider isActive]):
633         * DumpRenderTree/mac/TestRunnerMac.mm:
634         (TestRunner::isGeolocationProviderActive):
635         * DumpRenderTree/win/TestRunnerWin.cpp:
636         (TestRunner::isGeolocationProviderActive):
637         * WebKitTestRunner/GeolocationProviderMock.h:
638         (WTR::GeolocationProviderMock::isActive):
639         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
640         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
641         (WTR::InjectedBundle::isGeolocationProviderActive):
642         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
643         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
644         (WTR::TestRunner::isGeolocationProviderActive):
645         * WebKitTestRunner/InjectedBundle/TestRunner.h:
646         * WebKitTestRunner/TestController.cpp:
647         (WTR::TestController::isGeolocationProviderActive):
648         * WebKitTestRunner/TestController.h:
649         * WebKitTestRunner/TestInvocation.cpp:
650         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
651
652 2015-08-06  Ryosuke Niwa  <rniwa@webkit.org>
653
654         Automate JSBench with run-benchmark
655         https://bugs.webkit.org/show_bug.cgi?id=147716
656
657         Reviewed by Chris Dumez.
658
659         Added JSBench plan to run-benchmark.
660
661         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
662         (GenericBenchmarkBuilder.prepare): Pass in the archive type to _fetch_remote_archive.
663         (GenericBenchmarkBuilder._fetch_remote_archive): Added the support for extracting files from tar.gz in addition to zip.
664         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Fixed the coding style.
665         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch: Added.
666         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Fixed the coding style.
667         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Ditto.
668         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Ditto.
669         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Ditto.
670         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Specified the archive type.
671         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Specified the archive type.
672         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Ditto.
673         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Fixed the coding style.
674         * Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan: Added.
675         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Specified the archive type.
676         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Ditto.
677
678 2015-08-06  Yusuke Suzuki  <utatane.tea@gmail.com>
679
680         Pass-through the undefined options in run-jsc
681         https://bugs.webkit.org/show_bug.cgi?id=147717
682
683         Undefined options in run-jsc is just passed to the actual jsc shell.
684         We can execute `Tools/Scripts/run-jsc -d`.
685
686         Reviewed by Csaba Osztrogonác.
687
688         * Scripts/run-jsc:
689
690 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
691
692         Unreviewed. Skip GTK+ test /webkit2/WebKitWebView/submit-form.
693
694         It's flaky.
695
696         * Scripts/run-gtk-tests:
697         (TestRunner):
698
699 2015-08-06  Csaba Osztrogonác  <ossy@webkit.org>
700
701         [EFL] Bump EFL version to 1.15.0
702         https://bugs.webkit.org/show_bug.cgi?id=147450
703
704         Reviewed by Gyuyoung Kim.
705
706         * efl/jhbuild.modules:
707
708 2015-08-06  Carlos Garcia Campos  <cgarcia@igalia.com>
709
710         Unreviewed. Unksip TestContextMenu GTK+ API test.
711
712         This has been skipped for a long time, and it's very
713         unconvenient. It has never failed for me locally, so let's try
714         again to see if it works in the bots. I'll skip it again if it
715         keeps failing.
716
717         * Scripts/run-gtk-tests:
718         (TestRunner):
719
720 2015-08-05  Filip Pizlo  <fpizlo@apple.com>
721
722         Unreviewed, roll out http://trac.webkit.org/changeset/187972.
723
724         * DumpRenderTree/JavaScriptThreading.cpp:
725         (javaScriptThreadsMutex):
726         (runJavaScriptThread):
727         (startJavaScriptThreads):
728         (stopJavaScriptThreads):
729         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
730         (TestWebKitAPI::TEST):
731         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
732         (TestWebKitAPI::TEST):
733
734 2015-08-05  Alex Christensen  <achristensen@webkit.org>
735
736         Build DumpRenderTree with CMake.
737         https://bugs.webkit.org/show_bug.cgi?id=147519
738
739         Reviewed by Brent Fulgham.
740
741         * CMakeLists.txt:
742         Build the DumpRenderTree directory now that it builds successfully.
743         * DumpRenderTree/CMakeLists.txt:
744         Added missing source file and don't link with WebCore.lib.
745         * DumpRenderTree/PlatformWin.cmake:
746         Added sources to DumpRenderTreeLib and made DumpRenderTree only build DLLLauncherMain.cpp. 
747         * WinLauncher/CMakeLists.txt:
748         We need libcmt now that we are not linking with WebCore.lib.
749
750 2015-08-05  Alexey Proskuryakov  <ap@apple.com>
751
752         AppScale: Use https URLs for subresources and links
753         https://bugs.webkit.org/show_bug.cgi?id=147686
754
755         Reviewed by Ryosuke Niwa.
756
757         * QueueStatusServer/filters/webkit_extras.py:
758         * TestResultServer/static-dashboards/dashboard_base.js:
759         * TestResultServer/static-dashboards/flakiness_dashboard.js:
760         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
761         * TestResultServer/static-dashboards/treemap.js:
762         * TestResultServer/static-dashboards/ui.js:
763
764 2015-08-04  Filip Pizlo  <fpizlo@apple.com>
765
766         Rename Mutex to DeprecatedMutex
767         https://bugs.webkit.org/show_bug.cgi?id=147675
768
769         Reviewed by Geoffrey Garen.
770
771         * DumpRenderTree/JavaScriptThreading.cpp:
772         (javaScriptThreadsMutex):
773         (runJavaScriptThread):
774         (startJavaScriptThreads):
775         (stopJavaScriptThreads):
776         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
777         (TestWebKitAPI::TEST):
778         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
779         (TestWebKitAPI::TEST):
780
781 2015-08-05  Timothy Hatcher  <timothy@apple.com>
782
783         Update the WebKit nightly icon
784         https://bugs.webkit.org/show_bug.cgi?id=147684
785
786         Reviewed by Sam Weinig.
787
788         * WebKitLauncher/webkit.icns: Replaced.
789
790 2015-08-05  Daniel Bates  <dabates@apple.com>
791
792         REGRESSION (r185111): Clicking phone numbers doesn't prompt to call sometimes
793         https://bugs.webkit.org/show_bug.cgi?id=147678
794         <rdar://problem/21827815>
795
796         Reviewed by Brady Eidson.
797
798         Add a test to ensure that we restore the "should open external URLs" policy on
799         page reload after the web content process crashes.
800
801         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
802         * TestWebKitAPI/Tests/WebKit2/should-open-external-schemes.html: Added.
803         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
804         (TEST):
805
806 2015-08-04  Hunseop Jeong  <hs85.jeong@samsung.com>
807
808         [EFL] Editing tests have been broken since r186694
809         https://bugs.webkit.org/show_bug.cgi?id=146888
810
811         Reviewed by Brent Fulgham.
812
813         Restored some codes for the context click on GTK+ and EFL port.
814
815         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
816         (WTR::EventSendingController::contextClick): Seperated the codes using the PLATFORM guard.
817
818 2015-08-04  Dewei Zhu  <dewei_zhu@apple.com>
819
820         Install twisted package for http server when necessary.
821         https://bugs.webkit.org/show_bug.cgi?id=147082
822
823         Reviewed by Ryosuke Niwa.
824
825         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
826         * Scripts/webkitpy/thirdparty/__init__.py:
827         (AutoinstallImportHook.find_module):
828         (AutoinstallImportHook._install_twisted):
829
830 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
831
832         [Win] Update Apple Windows build for VS2015
833         https://bugs.webkit.org/show_bug.cgi?id=147653
834
835         Reviewed by Dean Jackson.
836
837         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/PluginTest.h: If building with
838         something older than VS2015, define snprintf as _snprintf.
839         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props:
840         Remove unneeded macro definition for snprintf.
841         * Scripts/webkitpy/common/system/platforminfo.py:
842         (PlatformInfo._determine_win_version): Recognize Windows 10.
843         * Scripts/webkitpy/port/win.py:
844         (WinPort): Ditto.
845         * Scripts/webkitpy/port/win_unittest.py:
846         (WinPortTest.test_baseline_search_path): Include Windows 10 in tests.
847         (WinPortTest._assert_version): Ditto.
848
849 2015-08-04  Brian Burg  <bburg@apple.com>
850
851         Unreviewed, update email addresses in contributors.json and watchlist.
852
853         * Scripts/webkitpy/common/config/contributors.json:
854         * Scripts/webkitpy/common/config/watchlist:
855
856 2015-08-04  Alexey Proskuryakov  <ap@apple.com>
857
858         Implement NPAPI redirect handling
859         https://bugs.webkit.org/show_bug.cgi?id=138675
860         rdar://problem/15779101
861
862         Patch by Jeffrey Pfau, updated and tweaked by me.
863
864         Reviewed by Anders Carlsson.
865
866         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
867         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
868         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
869         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
870         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
871         (PluginTest::NPP_URLNotify):
872         (PluginTest::NPP_URLRedirectNotify):
873         (PluginTest::NPP_GetValue):
874         (PluginTest::NPN_GetURLNotify):
875         (PluginTest::NPN_PostURLNotify):
876         (PluginTest::NPN_GetValue):
877         (PluginTest::NPN_ReleaseVariantValue):
878         (PluginTest::NPN_URLRedirectResponse):
879         (PluginTest::NPN_ConvertPoint):
880         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
881         * DumpRenderTree/TestNetscapePlugIn/Tests/URLRedirect.cpp: Added.
882         (URLRedirect::URLRedirect):
883         (URLRedirect::ScriptableObject::hasMethod):
884         (URLRedirect::ScriptableObject::get):
885         (URLRedirect::ScriptableObject::serviceAsync):
886         (URLRedirect::ScriptableObject::invoke):
887         (URLRedirect::NPP_GetValue):
888         (URLRedirect::NPP_URLNotify):
889         (URLRedirect::NPP_URLRedirectNotify):
890         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
891         (NP_GetEntryPoints):
892         (NPP_URLNotify):
893         (NPP_URLRedirectNotify):
894         (NPP_GetValue):
895
896 2015-08-04  Tim Horton  <timothy_horton@apple.com>
897
898         Move Matt Daiter to committers.
899
900         * Scripts/webkitpy/common/config/contributors.json:
901
902 2015-08-04  Brent Fulgham  <bfulgham@apple.com>
903
904         [Win] build-webkit and MSBuild fight over BuildOutput.htm, causing build failures.
905         https://bugs.webkit.org/show_bug.cgi?id=147636
906
907         Reviewed by Alex Christensen.
908         
909         We no longer need build-webkit to manually troll the log data and pipe it to stdout; MSBuild is already doing this properly.
910         Stop the build-webkit script from interacting with BuildOutput.htm, thereby preventing a potential build failure (especially
911         on EWS machines)
912
913         * Scripts/build-webkit:
914
915 2015-08-04  Jason Marcell  <jmarcell@apple.com>
916
917         Refactor to convert openSourceRevision and internalRevision properties on BuildbotIteration into a more generic collection of revisions.
918         https://bugs.webkit.org/show_bug.cgi?id=147280
919
920         Reviewed by Daniel Bates.
921
922         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
923         (BuildbotIteration): Removed opensourceRevision, internalRevision. Added revision.
924         Refactored _parseData to handle repositories more generically.
925         (parseRevisionProperty): Moved a comment up to parseRevisionProperty where it seems more relevant.
926         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
927         (BuildbotQueue.prototype.compareIterations): Using "revision" property instead of
928         "opensourceRevision" and "internalRevision".
929         (BuildbotQueue.prototype.compareIterationsByRevisions): Ditto.
930         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
931         (BuildbotQueueView.prototype._appendPendingRevisionCount): Ditto.
932         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Ditto.
933         (BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Changing "internal" boolean
934         parameter to more generic "repository" string parameter. Added "trac" parameter in order to
935         specify the trac instance to use. Using "revision" property instead of "opensourceRevision"
936         and "internalRevision".
937         (BuildbotQueueView.prototype.revisionContentForIteration): Passing the repository name and trac
938         instance to _revisionContentWithPopoverForIteration(). Using "revision" property instead of
939         "opensourceRevision" and "internalRevision".
940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js: Adding
941         constants for internal and opensource repositories.
942         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
943         (Analyzer.prototype._findIndexOfLargestIterationAtOrBeforeStart): Using "revision" property
944         instead of "opensourceRevision" and "internalRevision".
945         (Analyzer.prototype._countPercentageOfGreen): Ditto.
946         (Analyzer.prototype.webkitTrac.recordedCommits.forEach): Ditto.
947         (Analyzer.prototype._countTimes): Ditto.
948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
949         (WebKitBuildbot.prototype.layoutTestResultsDirectoryURLForIteration): Ditto.
950
951 2015-08-04  Mark Lam  <mark.lam@apple.com>
952
953         Removed a local debugging line I accidentally left in from a previous commit.
954
955         Not Reviewed.
956
957         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
958
959 2015-08-04  Mark Lam  <mark.lam@apple.com>
960
961         Unreviewed. Make Saam Barati a WebKit reviewer.
962
963         * Scripts/webkitpy/common/config/contributors.json:
964
965 2015-08-04  Xabier Rodriguez Calvar  <calvaris@igalia.com>
966
967         Unreviewed, updated Streams API watchlist.
968
969         * Scripts/webkitpy/common/config/watchlist: Matched .*Readable.*Stream.* and .*QueuingStrategy.* in bindings/js.
970
971 2015-08-03  Csaba Osztrogonác  <ossy@webkit.org>
972
973         [CMake] Add an option to build AllInOne files
974         https://bugs.webkit.org/show_bug.cgi?id=102647
975
976         Reviewed by Alex Christensen.
977
978         * Scripts/webkitperl/FeatureList.pm:
979
980 2015-08-03  Alexey Proskuryakov  <ap@apple.com>
981
982         AppScale: Add required indices
983         https://bugs.webkit.org/show_bug.cgi?id=147593
984
985         Reviewed by Tim Horton.
986
987         * QueueStatusServer/index.yaml:
988
989 2015-08-03  Filip Pizlo  <fpizlo@apple.com>
990
991         Check in LLVM 3.6.2 binary drops for El Capitan
992         https://bugs.webkit.org/show_bug.cgi?id=147582
993
994         Reviewed by Alexey Proskuryakov.
995         
996         Recognize 10.11 and use the right drops.
997
998         * Scripts/copy-webkitlibraries-to-product-directory:
999
1000 2015-08-03  Alex Christensen  <achristensen@webkit.org>
1001
1002         [Win] Build fix after r187733.
1003
1004         * WinLauncher/PageLoadTestClient.cpp:
1005         (PageLoadTestClient::dumpRunStatistics):
1006         wtf/MathExtras.h is now included in HashTable.h, which #defines pow to wtf_pow.
1007
1008 2015-08-02  Benjamin Poulain  <bpoulain@apple.com>
1009
1010         Investigate HashTable::HashTable(const HashTable&) and HashTable::operator=(const HashTable&) performance for hash-based static analyses
1011         https://bugs.webkit.org/show_bug.cgi?id=118455
1012
1013         Reviewed by Filip Pizlo.
1014
1015         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
1016         (TestWebKitAPI::TEST):
1017
1018 2015-07-31  Alex Christensen  <achristensen@webkit.org>
1019
1020         Prepare for VS2015
1021         https://bugs.webkit.org/show_bug.cgi?id=146579
1022
1023         Reviewed by Jon Honeycutt.
1024
1025         * WinLauncher/stdafx.h:
1026         Define __STDC_LIMIT_MACROS to have access to INTMAX_MAX.
1027
1028 2015-07-31  Csaba Osztrogonác  <ossy@webkit.org>
1029
1030         [EFL] Fix pixman build on ARM with GCC 4.9.3
1031         https://bugs.webkit.org/show_bug.cgi?id=147224
1032
1033         Reviewed by Gyuyoung Kim.
1034
1035         * efl/jhbuild.modules: Disable ARM IWMMXT fast paths as workarounding a GCC bug.
1036
1037 2015-07-30  Anders Carlsson  <andersca@apple.com>
1038
1039         Add support for window.open to WK1BrowserWindowController
1040         https://bugs.webkit.org/show_bug.cgi?id=147474
1041
1042         Reviewed by Dan Bernstein.
1043
1044         * MiniBrowser/mac/WK1BrowserWindowController.m:
1045         (-[WK1BrowserWindowController awakeFromNib]):
1046         Set javaScriptCanOpenWindowsAutomatically to YES. 
1047         If this becomes a nuisance, we can always add a menu item to toggle this.
1048
1049         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
1050         Implement this UI delegate method.
1051
1052 2015-07-30  Anders Carlsson  <andersca@apple.com>
1053
1054         Undo stray commit.
1055
1056         * MiniBrowser/mac/WK1BrowserWindowController.m:
1057         (-[WK1BrowserWindowController awakeFromNib]):
1058         (-[WK1BrowserWindowController webView:createWebViewWithRequest:]):
1059
1060 2015-07-29  Dean Jackson  <dino@apple.com>
1061
1062         Don't use (Details) when exposing SPI
1063         https://bugs.webkit.org/show_bug.cgi?id=147426
1064         <rdar://problem/22062407>
1065
1066         Reviewed by Dan Bernstein.
1067
1068         If we are declaring the interface without any implementation,
1069         we should use class extensions.
1070
1071         * DumpRenderTree/mac/DumpRenderTree.mm:
1072         * DumpRenderTree/mac/EventSendingController.mm:
1073         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1074         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
1075         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1076         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1077         * WebKitTestRunner/mac/TestControllerMac.mm:
1078
1079 2015-07-30  Aakash Jain  <aakash_jain@apple.com>
1080
1081         Replace Google App Engine with AppScale
1082         https://bugs.webkit.org/show_bug.cgi?id=147178
1083
1084         Reviewed by Daniel Bates.
1085
1086         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1087         (RunWebKitTests):
1088         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
1089         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
1090         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1091         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
1092         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
1093         (.):
1094         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1095         (BubbleQueueServer):
1096         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
1097         (TestHistory):
1098         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
1099         * QueueStatusServer/app.yaml: We must explicitly define threadsafe property when using the Python 2.7 runtime. We set threadsafe to be false because the status server code was written to be run in AppEngine's CGI environment and AppEngine's CGI programming model handles requests serially per section "Concurrent Requests and WSGI" of <https://cloud.google.com/appengine/docs/python/python25/migrate27>.
1100         * TestResultServer/app.yaml: Ditto
1101         * Scripts/webkitpy/common/config/urls.py:
1102         * TestResultServer/main.py:
1103         * TestResultServer/static-dashboards/dashboard_base.js:
1104         * TestResultServer/static-dashboards/loader.js:
1105
1106 2015-07-30  Joonghun Park  <jh718.park@samsung.com>
1107
1108         [EFL] Enable IndexedDB based on DatabaseProcess
1109         https://bugs.webkit.org/show_bug.cgi?id=147221
1110
1111         Reviewed by Csaba Osztrogonác.
1112
1113         * Scripts/webkitperl/FeatureList.pm:
1114
1115 2015-07-30  Alex Christensen  <achristensen@webkit.org>
1116
1117         Build AppleWin port with CMake
1118         https://bugs.webkit.org/show_bug.cgi?id=147385
1119
1120         Reviewed by Martin Robinson.
1121
1122         * WinLauncher/CMakeLists.txt:
1123         Link to CoreFoundation.lib and added /NODEFAULTLIB:LIBCMT to get it to link successfully.
1124
1125 2015-07-29  Andy VanWagoner  <thetalecrafter@gmail.com>
1126
1127         Implement basic types for ECMAScript Internationalization API
1128         https://bugs.webkit.org/show_bug.cgi?id=146926
1129
1130         Reviewed by Benjamin Poulain.
1131
1132         Enable flag now that the basic objects are in place.
1133
1134         * Scripts/webkitperl/FeatureList.pm: Enabled INTL
1135
1136 2015-07-28  Carlos Garcia Campos  <cgarcia@igalia.com>
1137
1138         [GTK] Add API to set the maximum number of web processes per WebKitWebContext
1139         https://bugs.webkit.org/show_bug.cgi?id=147108
1140
1141         Reviewed by Gustavo Noronha Silva.
1142
1143         Add test case to check the web process limit.
1144
1145         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1146         (testWebProcessLimit):
1147         (beforeAll):
1148
1149 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1150
1151         [GTK] Missing casts in BrowserWindow.c
1152         https://bugs.webkit.org/show_bug.cgi?id=147395
1153
1154         Reviewed by Carlos Garcia Campos.
1155
1156         * MiniBrowser/gtk/BrowserWindow.c:
1157         (browserWindowSetupEditorToolbar):
1158
1159 2015-07-28  Yusuke Suzuki  <utatane.tea@gmail.com>
1160
1161         [ES6] Add ENABLE_ES6_MODULES compile time flag with the default value "false"
1162         https://bugs.webkit.org/show_bug.cgi?id=147350
1163
1164         Reviewed by Sam Weinig.
1165
1166         * Scripts/webkitperl/FeatureList.pm:
1167
1168 2015-07-28  Michael Catanzaro  <mcatanzaro@igalia.com>
1169
1170         [Freetype] Always allow font matching for strong aliases
1171         https://bugs.webkit.org/show_bug.cgi?id=147057
1172
1173         Reviewed by Martin Robinson.
1174
1175         Create family aliases needed for the new layout tests.
1176
1177         * WebKitTestRunner/gtk/fonts/fonts.conf:
1178
1179 2015-07-28  Alexey Proskuryakov  <ap@apple.com>
1180
1181         webkitbot and WKR unnecessarily rely on webkit-queues.appspot.com
1182         https://bugs.webkit.org/show_bug.cgi?id=147359
1183
1184         Reviewed by Ryosuke Niwa.
1185
1186         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1187         (NewCommitBot.begin_work_queue):
1188         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1189         (SheriffBot.begin_work_queue):
1190
1191 2015-07-27  Alex Christensen  <achristensen@webkit.org>
1192
1193         Use Ninja on Windows.
1194         https://bugs.webkit.org/show_bug.cgi?id=147228
1195
1196         Reviewed by Martin Robinson.
1197
1198         * WinLauncher/CMakeLists.txt:
1199         WinLauncherLib must make WinLauncher.dll, not WinLauncherLib.dll.
1200         * Scripts/build-webkit:
1201         Use Ninja to build WinCairo by default, but fall back to Visual Studio if Ninja is not on the system.
1202
1203 2015-07-24  Jon Honeycutt  <jhoneycutt@apple.com>
1204
1205         Test for bug #147164 "[iOS] Keyboard bold/italic/underline keys don't
1206         highlight after being tapped to style a selection"
1207         https://bugs.webkit.org/show_bug.cgi?id=147278
1208
1209         Reviewed by Ryosuke Niwa.
1210
1211         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1212
1213         * TestWebKitAPI/Tests/mac/WordBoundaryTypingAttributes.mm: Added.
1214         (-[WordBoundaryTypingAttributesController webView:didFinishLoadForFrame:]):
1215         (TestWebKitAPI::TEST):
1216         Load a page with the string "Hello, world!", then select "world" and
1217         underline it. Test that the typing attributes for the current selection
1218         include the underline attribute.
1219
1220 2015-07-24  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1221
1222         Unreviewed, updated my nick name in contributors.json
1223
1224         * Scripts/webkitpy/common/config/contributors.json:
1225
1226 2015-07-24  Chris Fleizach  <cfleizach@apple.com>
1227
1228         AX: scrollable elements do not allow 3-finger swipe
1229         https://bugs.webkit.org/show_bug.cgi?id=141893
1230
1231         Reviewed by Mario Sanchez Prada.
1232
1233         Support global notification listeners for iOS code.
1234         Fix an issue in DRT where the dictionary of data was not being passed back to the layout test for the notication callback.
1235         Implement scrollUp/Down/Left/Right.
1236
1237         * DumpRenderTree/AccessibilityController.h:
1238         * DumpRenderTree/AccessibilityUIElement.cpp:
1239         (increaseTextSelectionCallback):
1240         (scrollPageUpCallback):
1241         (scrollPageDownCallback):
1242         (scrollPageLeftCallback):
1243         (scrollPageRightCallback):
1244         (decreaseTextSelectionCallback):
1245         (getElementTextLengthCallback):
1246         (AccessibilityUIElement::getJSClass):
1247         * DumpRenderTree/AccessibilityUIElement.h:
1248         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
1249         (AccessibilityController::~AccessibilityController):
1250         (AccessibilityController::elementAtPoint):
1251         (AccessibilityController::addNotificationListener):
1252         (AccessibilityController::platformResetToConsistentState):
1253         (AccessibilityController::removeNotificationListener):
1254         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1255         (AccessibilityUIElement::AccessibilityUIElement):
1256         (AccessibilityUIElement::subrole):
1257         (AccessibilityUIElement::scrollPageUp):
1258         (AccessibilityUIElement::scrollPageDown):
1259         (AccessibilityUIElement::scrollPageLeft):
1260         (AccessibilityUIElement::scrollPageRight):
1261         (AccessibilityUIElement::roleDescription):
1262         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
1263         (-[AccessibilityNotificationHandler _notificationReceived:]):
1264         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1265         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1266         (WTR::AccessibilityUIElement::linkedElement):
1267         (WTR::AccessibilityUIElement::headerElementAtIndex):
1268         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1269         (WTR::AccessibilityUIElement::scrollPageUp):
1270         (WTR::AccessibilityUIElement::scrollPageDown):
1271         (WTR::AccessibilityUIElement::scrollPageLeft):
1272         (WTR::AccessibilityUIElement::scrollPageRight):
1273         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1274         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1275         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
1276         (WTR::AccessibilityController::addNotificationListener):
1277         (WTR::AccessibilityController::removeNotificationListener):
1278         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1279         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1280         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
1281         (WTR::AccessibilityUIElement::scrollPageUp):
1282         (WTR::AccessibilityUIElement::scrollPageDown):
1283         (WTR::AccessibilityUIElement::scrollPageLeft):
1284         (WTR::AccessibilityUIElement::scrollPageRight):
1285         (WTR::AccessibilityUIElement::increaseTextSelection):
1286
1287 2015-07-24  Brent Fulgham  <bfulgham@apple.com>
1288
1289         [Win] Activate CSP_NEXT and Connect UserScript and UserStyleSheet through WebView.
1290         https://bugs.webkit.org/show_bug.cgi?id=147279
1291         <rdar://problem/21990767>
1292
1293         Reviewed by Dean Jackson.
1294
1295         * DumpRenderTree/win/TestRunnerWin.cpp:
1296         (TestRunner::addUserScript):
1297         (TestRunner::addUserStyleSheet):
1298         (TestRunner::setDeveloperExtrasEnabled):
1299
1300 2015-07-24  Basile Clement  <basile_clement@apple.com>
1301
1302         Call fixChangeLogPatch when generating patches from webkit-patch
1303         https://bugs.webkit.org/show_bug.cgi?id=147248
1304
1305         Reviewed by Geoffrey Garen.
1306
1307         When two consecutive patches are from the same author, diff tools
1308         create wrong-looking diffs for ChangeLog files where the apparent added
1309         author is actually the previous patch's author line, making it awkward
1310         to read - and things only get worse when committing a patch and a
1311         followup fix for the same bug shortly after.
1312
1313         We have a perl function in VCSUtils.pm, fixChangeLogPatch, to corrects
1314         this, which we use in perl scripts (svn-create-patch et al). But it is
1315         not used by webkit-patch, which is a python script, and thus creates
1316         "bad" diffs.
1317
1318         In the long term, we should probably port fixChangeLogPatch to python -
1319         but in the short term, let's make webkit-patch call perl to run
1320         fixChangeLogPatch. We are already making various external calls there
1321         anyway.
1322
1323         * Scripts/webkitpy/common/checkout/scm/git.py:
1324         (Git.create_patch):
1325         * Scripts/webkitpy/common/checkout/scm/scm.py:
1326         (SCM.fix_changelog_patch):
1327         * Scripts/webkitpy/common/checkout/scm/svn.py:
1328         (SVN.create_patch):
1329
1330 2015-07-24  Dean Johnson  <dean_johnson@apple.com>
1331
1332         commit-queue flags in webkit-patch are confusing
1333         https://bugs.webkit.org/show_bug.cgi?id=88694
1334
1335         Reviewed by Csaba Osztrogonác.
1336
1337         * Scripts/webkitpy/tool/steps/options.py:
1338         (Options): Updated help string to be more descriptive.
1339
1340 2015-07-23  Brent Fulgham  <bfulgham@apple.com>
1341
1342         [Win] Implement proper High DPI support features
1343         https://bugs.webkit.org/show_bug.cgi?id=146335
1344         <rdar://problem/21558269>
1345
1346         Reviewed by Alex Christensen.
1347
1348         Update WinLauncher to take device scaling factor into account.
1349
1350         * WinLauncher/Common.cpp:
1351         (resizeSubViews): Make sure toolbars and URL bar are properly sized and using
1352         a valid font.
1353         (computeFullDesktopFrame): Handle high DPI desktops.
1354         (WndProc): Make comments more precise.
1355         * WinLauncher/WinLauncher.cpp:
1356         (WinLauncher::init): Determine device scale factor at launch.
1357         (WinLauncher::updateDeviceScaleFactor): Added.
1358         * WinLauncher/WinLauncher.h:
1359         * WinLauncher/WinLauncherWebHost.h: Use C++11 initialization.
1360         * WinLauncher/WinMain.cpp: Size interface based on scaling factor.
1361         (wWinMain): Ditto.
1362         * win/DLLLauncher/DLLLauncherMain.cpp:
1363         (wWinMain): Tell Windows we understand high DPI.
1364
1365 2015-07-23  Alex Christensen  <achristensen@webkit.org>
1366
1367         [Win] Unreviewed build fix after r187169.
1368
1369         * Scripts/build-webkit:
1370         Correctly find WebKit.sln.
1371
1372 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1373
1374         [GTK] Add API to allow executing editing commands that require an argument
1375         https://bugs.webkit.org/show_bug.cgi?id=146781
1376
1377         Reviewed by Gustavo Noronha Silva.
1378
1379         Add buttons to insert image/link to the MiniBrowser edit toolbar,
1380         and test cases for insert image/link commands too.
1381
1382         * MiniBrowser/gtk/BrowserWindow.c:
1383         (insertImageCommandCallback):
1384         (insertLinkCommandCallback):
1385         (browserWindowSetupEditorToolbar):
1386         (browserWindowConstructed):
1387         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1388         (testWebViewEditorInsertImage):
1389         (testWebViewEditorCreateLink):
1390         (beforeAll):
1391
1392 2015-07-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1393
1394         Unregistering and re-registering a user message handler does not work
1395         https://bugs.webkit.org/show_bug.cgi?id=138142
1396
1397         Reviewed by Martin Robinson.
1398
1399         This has probably been fixed in r184846, enable the test case
1400         blocked on it.
1401
1402         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1403         (testUserContentManagerScriptMessageReceived):
1404
1405 2015-07-22  Sukolsak Sakshuwong  <sukolsak@gmail.com>
1406
1407         Add ENABLE_WEBASSEMBLY feature flag for WebAssembly
1408         https://bugs.webkit.org/show_bug.cgi?id=147212
1409
1410         Reviewed by Filip Pizlo.
1411
1412         * Scripts/webkitperl/FeatureList.pm:
1413
1414 2015-07-22  Jon Honeycutt  <jhoneycutt@apple.com>
1415
1416         Add --ios-simulator to run-api-tests --help.
1417
1418         Rubber-stamped by Dan Bates.
1419
1420         * Scripts/run-api-tests:
1421
1422 2015-07-22  Jason Marcell  <jmarcell@apple.com>
1423
1424         Remove hardcoded "internal" from Buildbot.prototype._normalizeQueueInfo.
1425         https://bugs.webkit.org/show_bug.cgi?id=147043
1426
1427         Reviewed by Daniel Bates and Alexey Proskuryakov.
1428
1429         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1430         (Buildbot.prototype._normalizeQueueInfo):
1431         The _normalizeQueueInfo method now calls the defaultBranches getter instead of using hardcoded values
1432         in cases where the queue.branch property is not set and the queue is not a combined queue.
1433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1434         (BuildbotCombinedQueueView):
1435         Ensuring uniformity of repository branches within a combined queue.
1436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1437         (WebKitBuildbot.prototype.get defaultBranches):
1438         Added; provides a WebKit-specific implementation that sets the queue.branches dictionary to have a
1439         single entry for "openSource" as the default set of branches. Note that we intentionally omitted a
1440         base class implementation of the defaultBranches getter so as to cause a JavaScript TypeError when a
1441         sub-queue of a combined queue does not specify property branch and the derived Buildbot class does not
1442         implement defaultBranches so that a person can either update the definition of the sub-queue or
1443         implement defaultBranches in the derived Buildbot class they are using.
1444
1445 2015-07-22  Alex Christensen  <achristensen@webkit.org>
1446
1447         Switch WinCairo build to use CMake.
1448         https://bugs.webkit.org/show_bug.cgi?id=147169
1449
1450         Reviewed by Brent Fulgham.
1451
1452         * Scripts/build-webkit:
1453         * Scripts/webkitdirs.pm:
1454         (determineConfiguration):
1455         (determineArchitecture):
1456         (determinePassedConfiguration):
1457         (passedConfiguration):
1458         (jhbuildWrapperPrefixIfNeeded):
1459         (generateBuildSystemFromCMakeProject):
1460         It's CMake time!  We now use the CMake files to generate a solution in WebKitBuild/Release/WebKit.sln and build that.
1461
1462 2015-07-22  Alex Christensen  <achristensen@webkit.org>
1463
1464         Fix quirks in CMake build on Mac and Windows
1465         https://bugs.webkit.org/show_bug.cgi?id=147174
1466
1467         Reviewed by Gyuyoung Kim.
1468
1469         * CMakeLists.txt:
1470         Don't build DumpRenderTree with CMake for now (until we get that working).
1471         * WinLauncher/CMakeLists.txt:
1472         Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.
1473
1474 2015-07-22  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1475
1476         [check-webkit-style] .lut.h files shouldn't raise a sorting issue
1477         https://bugs.webkit.org/show_bug.cgi?id=147146
1478
1479         Reviewed by Darin Adler.
1480
1481         * Scripts/webkitpy/style/checkers/cpp.py:
1482         (check_include_line): Avoid checking previous lines if it it is a lut.h include.
1483         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1484         (OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.
1485
1486 2015-07-21  Filip Pizlo  <fpizlo@apple.com>
1487
1488         Fixed VM pool allocation should have a reserve for allocations that cannot fail
1489         https://bugs.webkit.org/show_bug.cgi?id=147154
1490         rdar://problem/21847618
1491
1492         Reviewed by Geoffrey Garen.
1493         
1494         Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
1495         mitigations work, these should all pass. Prior to this patch there were >20 failures.
1496
1497         * Scripts/run-jsc-stress-tests:
1498
1499 2015-07-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1500
1501         [GTK] Add API to be notified about editor state changes
1502         https://bugs.webkit.org/show_bug.cgi?id=145875
1503
1504         Reviewed by Gustavo Noronha Silva.
1505
1506         Update the typing attributes toggle buttons state according to the
1507         editor state in MiniBrowser, and add a test case to the
1508         WebViewEditor unit tests.
1509
1510         * MiniBrowser/gtk/BrowserWindow.c:
1511         (browserWindowEditingCommandToggleButtonSetActive):
1512         (typingAttributesChanged):
1513         (browserWindowSetupEditorToolbar):
1514         (browserWindowConstructed):
1515         (browser_window_init):
1516         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1517         (testWebViewEditorEditorStateTypingAttributes):
1518         (beforeAll):
1519
1520 2015-07-20  Tomas Popela  <tpopela@redhat.com>
1521
1522         [GTK] Add selection-changed signal to the WebKit2 API
1523         https://bugs.webkit.org/show_bug.cgi?id=137116
1524
1525         Reviewed by Carlos Garcia Campos.
1526
1527         Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
1528         (namely the selection-changed signal).
1529
1530         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1531         * TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
1532         (WebKitWebEditorTest::create):
1533         (WebKitWebEditorTest::selectionChangedCallback):
1534         (WebKitWebEditorTest::testSelectionSelectAll):
1535         (WebKitWebEditorTest::testSelectionCollapse):
1536         (WebKitWebEditorTest::testSelectionModifyMove):
1537         (WebKitWebEditorTest::testSelectionModifyExtend):
1538         (WebKitWebEditorTest::testSelectionUnselect):
1539         (registerTests):
1540         * TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
1541         (testWebKitWebEditorSelectionChanged):
1542         (beforeAll):
1543         (afterAll):
1544
1545 2015-07-20  Alex Christensen  <achristensen@webkit.org>
1546
1547         Resurrect CMake build on Windows.
1548         https://bugs.webkit.org/show_bug.cgi?id=147083
1549
1550         Reviewed by Gyuyoung Kim.
1551
1552         * DumpRenderTree/CMakeLists.txt:
1553         * DumpRenderTree/PlatformWin.cmake: Added.
1554         * WinLauncher/CMakeLists.txt:
1555
1556 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1557
1558         [GTK] Enable seccomp filter API tests
1559         https://bugs.webkit.org/show_bug.cgi?id=140071
1560
1561         Reviewed by Žan Doberšek.
1562
1563         These tests will now be run by the run-gtk-tests script.
1564
1565         * TestWebKitAPI/PlatformGTK.cmake:
1566
1567 2015-07-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1568
1569         [GTK] Add seccomp filters support
1570         https://bugs.webkit.org/show_bug.cgi?id=110014
1571
1572         Reviewed by Žan Doberšek.
1573
1574         Add libseccomp to jhbuild modulesets.
1575
1576         * gtk/jhbuild.modules:
1577
1578 2015-07-18  Simon Fraser  <simon.fraser@apple.com>
1579
1580         MiniBrowser window title is just "Window" when page has no <title>
1581         https://bugs.webkit.org/show_bug.cgi?id=147076
1582
1583         Reviewed by Tim Horton.
1584         
1585         Make MiniBrowser windows show the filename from the URL if we never get a title changed
1586         notification.
1587
1588         * MiniBrowser/mac/WK1BrowserWindowController.m:
1589         (-[WK1BrowserWindowController updateTitle:]):
1590         (-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
1591         (-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
1592         * MiniBrowser/mac/WK2BrowserWindowController.m:
1593         (-[WK2BrowserWindowController updateTitle:]):
1594         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1595         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
1596
1597 2015-07-17  Andy Estes  <aestes@apple.com>
1598
1599         [iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
1600         https://bugs.webkit.org/show_bug.cgi?id=147044
1601         rdar://problem/21567820
1602
1603         Reviewed by Brady Eidson.
1604
1605         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1606         (WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
1607         This matches the behavior of DumpRenderTree.
1608
1609 2015-07-17  Benjamin Poulain  <bpoulain@apple.com>
1610
1611         [Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
1612         https://bugs.webkit.org/show_bug.cgi?id=147032
1613
1614         Reviewed by Alex Christensen.
1615
1616         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1617         Test that the useless terms are eliminated by counting
1618         the number of NFA nodes generated.
1619
1620 2015-07-17  Dan Bernstein  <mitz@apple.com>
1621
1622         Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
1623         https://bugs.webkit.org/show_bug.cgi?id=147040
1624
1625         Reviewed by Dean Jackson.
1626
1627         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1628         * TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
1629         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
1630         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
1631         (-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1632         (TEST):
1633
1634 2015-07-16  Dean Johnson  <dean_johnson@apple.com>
1635
1636         webkit-patch uses incorrect credentials from keychain to login until account lockout
1637         https://bugs.webkit.org/show_bug.cgi?id=146923
1638
1639         Reviewed by Daniel Bates.
1640
1641         When `webkit-patch upload` asks for login credentials for bugs.webkit.org, if you
1642         provide incorrect credentials then ask for them to be saved to the keychain
1643         webkit-patch will then use those incorrect credentials until 5 total attempts
1644         have been made to log in. This will lock the user out of Bugzilla for a
1645         half hour.
1646
1647         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1648         (Bugzilla.authenticate): Added argument to read_credentials() that
1649         passes in whether or not to use stored credentials.
1650         * Scripts/webkitpy/common/net/credentials.py:
1651         (Credentials.read_credentials): Added optional argument 'use_stored_credentials'
1652         that specifies whether or not to use credentials stored on the system. If it
1653         does, we do not auto-fill credentials since either the credentials caused
1654         the failure, or they weren't used in the first place so there is no reason
1655         to try and use them again if a failure happened.
1656         * Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
1657         use_stored_credentials argument.
1658         (test_do_not_use_stored_credentials): Added unit test to make sure functions that
1659         retrieve username/password information from the local system (environment, Git, keychain,
1660         keyring) are never called. It also tests that we get back our mocked username and password.
1661         (test_do_not_use_stored_credentials.MockKeyring): Mock keyring
1662         (test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
1663         (test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
1664         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
1665         is never called.
1666         (test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
1667         (test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
1668         (test_do_not_use_stored_credentials.FakeUser): Mock the User class
1669         (test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
1670         (test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
1671         against.
1672
1673 2015-07-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1674
1675         Unreviewed, remove my redundant email information.
1676
1677         * Scripts/webkitpy/common/config/contributors.json:
1678
1679 2015-07-16  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1680
1681         Unreviewed. Add Hyungwook Lee as a committer.
1682
1683         * Scripts/webkitpy/common/config/contributors.json:
1684
1685 2015-07-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1686
1687         Added myself to the list of contributors.
1688
1689         Reviewed by Brent Fulgham.
1690
1691         * Scripts/webkitpy/common/config/contributors.json:
1692
1693 2015-07-16  Alex Christensen  <achristensen@webkit.org>
1694
1695         [Content Extensions] Cache domain actions
1696         https://bugs.webkit.org/show_bug.cgi?id=146817
1697
1698         Reviewed by Benjamin Poulain.
1699
1700         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1701         (TestWebKitAPI::TEST_F):
1702         Test if-domain and unless-domain with multiple load types.
1703
1704 2015-07-16  Benjamin Poulain  <bpoulain@apple.com>
1705
1706         [Content extensions] Combine suffixes when generating NFAs
1707         https://bugs.webkit.org/show_bug.cgi?id=146961
1708
1709         Reviewed by Alex Christensen.
1710
1711         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1712         (TestWebKitAPI::compareContents):
1713         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1714
1715 2015-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1716
1717         [GTK] Input method filter is always enabled when the view is focused
1718         https://bugs.webkit.org/show_bug.cgi?id=146965
1719
1720         Reviewed by Martin Robinson.
1721
1722         Use setEnabled() instead of notifyFocusedIn() to enable input methods.
1723
1724         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
1725         (TestWebKitAPI::TestInputMethodFilter::TestInputMethodFilter):
1726
1727 2015-07-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1728
1729         [EFL] Bump libseccomp version to 2.2.3
1730         https://bugs.webkit.org/show_bug.cgi?id=146980
1731
1732         Reviewed by Gyuyoung Kim.
1733
1734         * efl/jhbuild.modules:
1735
1736 2015-07-15  Brent Fulgham  <bfulgham@apple.com>
1737
1738         [Win] Maintain consistent COM Interfaces
1739         https://bugs.webkit.org/show_bug.cgi?id=146983
1740         <rdar://problem/21822278>
1741
1742         Reviewed by Dean Jackson.
1743
1744         Update DumpRenderTree and WinLauncher to use the properly
1745         versioned COM interface objects.
1746
1747         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1748         (AccessibilityController::rootElement):
1749         * DumpRenderTree/win/DumpRenderTree.cpp:
1750         (resetWebPreferencesToConsistentValues):
1751         (resetWebViewToConsistentStateBeforeTesting):
1752         (runTest):
1753         (createWebViewAndOffscreenWindow):
1754         * DumpRenderTree/win/EditingDelegate.cpp:
1755         (EditingDelegate::QueryInterface):
1756         (EditingDelegate::shouldEndEditingInDOMRange):
1757         (EditingDelegate::shouldInsertNode):
1758         * DumpRenderTree/win/EditingDelegate.h:
1759         * DumpRenderTree/win/EventSender.cpp:
1760         (scalePageByCallback):
1761         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1762         (FrameLoadDelegate::didCommitLoadForFrame):
1763         * DumpRenderTree/win/TestRunnerWin.cpp:
1764         (TestRunner::callShouldCloseOnWebView):
1765         (TestRunner::applicationCacheDiskUsageForOrigin):
1766         (TestRunner::clearApplicationCacheForOrigin):
1767         (TestRunner::setDefersLoading):
1768         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1769         (TestRunner::setTabKeyCyclesThroughElements):
1770         (TestRunner::setValueForUser):
1771         (TestRunner::dispatchPendingLoadRequests):
1772         (TestRunner::setWindowIsKey):
1773         (TestRunner::execCommand):
1774         (TestRunner::addOriginAccessWhitelistEntry):
1775         (TestRunner::removeOriginAccessWhitelistEntry):
1776         (TestRunner::addUserScript):
1777         (TestRunner::addUserStyleSheet):
1778         (TestRunner::showWebInspector):
1779         (TestRunner::closeWebInspector):
1780         (TestRunner::evaluateInWebInspector):
1781         (TestRunner::setSerializeHTTPLoads):
1782         * DumpRenderTree/win/TextInputControllerWin.cpp:
1783         (TextInputController::setMarkedText):
1784         (TextInputController::hasMarkedText):
1785         (TextInputController::unmarkText):
1786         (TextInputController::markedRange):
1787         (TextInputController::insertText):
1788         (TextInputController::firstRectForCharacterRange):
1789         (TextInputController::selectedRange):
1790         * DumpRenderTree/win/UIDelegate.h:
1791         (UIDelegate::unused2):
1792         (UIDelegate::unused3):
1793         (UIDelegate::webViewScrolled):
1794         (UIDelegate::webViewShouldInterruptJavaScript):
1795         (UIDelegate::webViewReceivedFocus):
1796         (UIDelegate::unused4): Deleted.
1797         * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp:
1798         (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
1799         * WinLauncher/PageLoadTestClient.cpp:
1800         (PageLoadTestClient::didStartProvisionalLoad):
1801         * WinLauncher/WinLauncher.cpp:
1802         (WinLauncher::init):
1803         * WinLauncher/WinLauncher.h:
1804         * WinLauncher/WinLauncherWebHost.cpp:
1805         (WinLauncherWebHost::didFinishLoadForFrame):
1806         (WinLauncherWebHost::didFirstLayoutInFrame):
1807         * WinLauncher/WinLauncherWebHost.h:
1808
1809 2015-07-15  Dean Johnson  <dean_johnson@apple.com>
1810
1811         Many test failures in scm_unittest.py
1812         https://bugs.webkit.org/show_bug.cgi?id=143967
1813
1814         Reviewed by Daniel Bates. 
1815
1816         * Scripts/webkitpy/common/checkout/scm/detection.py:
1817         (SCMDetector.detect_scm_system): Paths with symlinks are now resolved to
1818         absolute canonical file paths. Two mutually exclusive issues cause this
1819         to be a problem.
1820             1) Python's os.path.relpath() function does not return correct relative
1821             paths between two filepaths that point to the same file, if symlinks are
1822             involved.
1823                 On Mac, /tmp points to /private/tmp
1824                 ex. os.path.relpath('/tmp', '/private/tmp')
1825                     returns '../../tmp'
1826             What we want is actually just '.'
1827             2) Git does not allow file paths to trace outside of
1828             the Git repository. This means that if you have a repository in
1829             /tmp and you refer to that repository when invoking a git command as
1830             ../tmp, Git will produce errors about working outside of the repository.
1831         * Scripts/webkitpy/common/checkout/scm/git.py: Over time Git has changed
1832         its default behavior and such, needed to be updated.
1833         (Git.changed_files): '--' was added into the command so that patch_directories
1834         were taken as positional arguments.
1835         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Changed tests and setup 
1836         in the GitSVNTest class to more closely emulate the version of Git that the tests
1837         assumed a system had. Also fixed a small side-effect from the absolute canonical
1838         path fix in SCMDetector.detect_scm_system
1839         (SVNTestRepository.setup): A relative filepath was previously passed as the
1840         checkout root to SCMDetector.detect_scm_system, but is now cleaned to
1841         an absolute canonical path before being passed in. The failing test
1842         was a "sanity check" that the svn.checkout_root and scm.checkout_root
1843         were the same.
1844         (GitSVNTest._setup_git_checkout):
1845             1) Added "--prefix ''" option to `git clone` since Git changed its default
1846             behavior in version 2.0.
1847             2) The branch master was renamed to trunk to more closely emulate what
1848             tests expected when they were written. 
1849         (GitSVNTest.test_changed_files_local_plus_working_copy): Two of the three
1850         original tests failed because the tests expected the trunk branch
1851         to produce its parent's commit, whereas Git merely provides the HEAD commit
1852         for a given branch (trunk in this case). Based on other tests written
1853         in the same commit, it appears these tests were failing from the point they
1854         were written.
1855
1856 2015-07-14  Anders Carlsson  <andersca@apple.com>
1857
1858         Assertions.h should include ExportMacros.h
1859         https://bugs.webkit.org/show_bug.cgi?id=146948
1860
1861         Reviewed by Tim Horton.
1862
1863         Remove now unneeded WTF_EXPORT_PRIVATE define.
1864
1865         * DumpRenderTree/cg/ImageDiffCG.cpp:
1866
1867 2015-07-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1868
1869         [GTK] [Wayland] Build by default the X11 and Wayland targets.
1870         https://bugs.webkit.org/show_bug.cgi?id=146057
1871
1872         Reviewed by Carlos Garcia Campos.
1873
1874         * gtk/install-dependencies:
1875
1876 2015-07-10  Brent Fulgham  <bfulgham@apple.com>
1877
1878         [Mac] Unable to dismiss context menu during test runs
1879         https://bugs.webkit.org/show_bug.cgi?id=146836
1880
1881         Reviewed by Tim Horton.
1882
1883         Since Context Menus are modal, the test system would block on the displayed context menu,
1884         causing tests to fail. Instead, we should do what WK1 was doing, which is to perform the
1885         mouse click and generate the menu contents, but not ask AppKit to display it.
1886
1887         Drive-by fix: We did not handle 'escape' key presses. This is also fixed.
1888
1889         * DumpRenderTree/mac/EventSendingController.mm:
1890         (-[EventSendingController keyDown:withModifiers:withLocation:]): Handle the 'escape' character.
1891         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1892         (WTR::EventSendingController::mouseMoveTo): Keep track of the current mouse position.
1893         (WTR::EventSendingController::contextClick): Don't emit an actual context menu invocation and then
1894         copy the menu items. Instead, use WKBundlePageCopyContentMenuAtPointInWindow to do all the same
1895         work without actually calling on AppKit to display the menu.
1896         ask WebCore to do all the work EXCEPT displaying the menu.
1897         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
1898         * WebKitTestRunner/mac/EventSenderProxy.mm:
1899         (WTR::EventSenderProxy::keyDown): Handle the 'escape' character.
1900
1901 2015-07-09  Filip Pizlo  <fpizlo@apple.com>
1902
1903         It should be possible to run the OSR exit fuzzer
1904         https://bugs.webkit.org/show_bug.cgi?id=146814
1905
1906         Reviewed by Mark Lam.
1907         
1908         This runs a test command to detect how many static OSR exit sites it had, and then for
1909         each exit site, it triggers three exits (earliest opportunity, last opportunity, some
1910         middle opportunity), plus a mode where the check always exits. This is an exhaustive
1911         search, so in the future it'll be very appropriate for cases where we have a simple test
1912         and we want to see what happens when you eventually exit in this test.
1913         
1914         Right now this isn't hooked into any specific tests, but I've done some spot checks on it
1915         and it seems to do the right thing.
1916
1917         * Scripts/jsc-stress-test-helpers/js-osr-exit-fuzz: Added.
1918         (fail):
1919
1920 2015-07-10  Alex Christensen  <achristensen@webkit.org>
1921
1922         Add tests for r186649
1923         https://bugs.webkit.org/show_bug.cgi?id=146821
1924
1925         Reviewed by Darin Adler.
1926
1927         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1928         (TestWebKitAPI::TEST_F):
1929         (TestWebKitAPI::compareContents):
1930         (TestWebKitAPI::expectedIndex):
1931         Add some larger tests to test large jumps.
1932
1933 2015-07-09  Dewei Zhu  <dewei_zhu@apple.com>
1934
1935         Quick fix for run_benchmark script that AppKit.NSRunningApplication does not work properly
1936         https://bugs.webkit.org/show_bug.cgi?id=146820
1937
1938         Reviewed by Ryosuke Niwa.
1939
1940         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1941         (OSXBrowserDriver):
1942         (OSXBrowserDriver.close_browsers):
1943         (OSXBrowserDriver._terminiate_processes):
1944         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1945         (OSXChromeDriver):
1946         (OSXChromeCanaryDriver):
1947         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1948         (OSXFirefoxDriver):
1949         (OSXFirefoxNightlyDriver):
1950         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1951         (OSXSafariDriver):
1952
1953 2015-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
1954
1955         [GTK] pango should be included in the default jhbuild moduleset
1956         https://bugs.webkit.org/show_bug.cgi?id=146683
1957
1958         Reviewed by Martin Robinson.
1959
1960         Recent releases of pango 1.36 use functions that are only provided by fontconfig 2.12 when
1961         compiled against sufficiently-new versions of fontconfig. Since we depend on both pango and
1962         fontconfig, and pango depends on fontconfig, we must either add pango to our jhbuild
1963         moduleset or else upgrade fontconfig to a recent unstable release (knowing that we will have
1964         the same problem again the next time pango wants to use a new fontconfig feature), or remove
1965         fontconfig (which would make it hard to keep tests working). On the balance, adding pango is
1966         best.
1967
1968         * gtk/jhbuild-optional.modules: Remove pango
1969         * gtk/jhbuild.modules: Add pango and update to latest 1.36.8
1970
1971 2015-07-09  Devin Rousso  <drousso@apple.com>
1972
1973         Unreviewed.  Added myself as a committer.
1974
1975         * Scripts/webkitpy/common/config/contributors.json:
1976
1977 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
1978
1979         Add a way to set the default URL from Minibrowser UI
1980         https://bugs.webkit.org/show_bug.cgi?id=146780
1981
1982         Reviewed by Simon Fraser.
1983
1984         * MiniBrowser/mac/AppDelegate.m:
1985         (-[BrowserAppDelegate didChangeSettings]):
1986         * MiniBrowser/mac/BrowserWindowController.h:
1987         * MiniBrowser/mac/BrowserWindowController.m:
1988         (-[BrowserWindowController fetch:]):
1989         (-[BrowserWindowController reload:]):
1990         (-[BrowserWindowController forceRepaint:]):
1991         (-[BrowserWindowController goBack:]):
1992         (-[BrowserWindowController goForward:]):
1993         (-[BrowserWindowController showHideWebView:]):
1994         (-[BrowserWindowController removeReinsertWebView:]):
1995         (-[BrowserWindowController zoomIn:]):
1996         (-[BrowserWindowController zoomOut:]):
1997         (-[BrowserWindowController resetZoom:]):
1998         (-[BrowserWindowController canZoomIn]):
1999         (-[BrowserWindowController canZoomOut]):
2000         (-[BrowserWindowController canResetZoom]):
2001         (-[BrowserWindowController toggleZoomMode:]):
2002         (-[BrowserWindowController setScale:]):
2003         (-[BrowserWindowController toggleShrinkToFit:]):
2004         (-[BrowserWindowController dumpSourceToConsole:]):
2005         (-[BrowserWindowController find:]):
2006         (-[BrowserWindowController didChangeSettings]):
2007         (-[BrowserWindowController currentURL]):
2008         Get rid of the BrowserController protocol. It was a bad idea and confused
2009         Interface Builder more than I thought possible.
2010
2011         * MiniBrowser/mac/SettingsController.m:
2012         (-[SettingsController _populateMenu]):
2013         (-[SettingsController setDefaultURLToCurrentURL:]):
2014         If we have a BrowserWindowController, grab its URL and set the relevant default.
2015
2016         * MiniBrowser/mac/WK1BrowserWindowController.h:
2017         * MiniBrowser/mac/WK1BrowserWindowController.m:
2018         (-[WK1BrowserWindowController currentURL]):
2019         * MiniBrowser/mac/WK2BrowserWindowController.h:
2020         * MiniBrowser/mac/WK2BrowserWindowController.m:
2021         (-[WK2BrowserWindowController currentURL]):
2022         Retrieve the current URL from the WKView/WebView.
2023
2024 2015-07-09  Timothy Horton  <timothy_horton@apple.com>
2025
2026         Increase MiniBrowser location bar maximum width
2027         https://bugs.webkit.org/show_bug.cgi?id=146779
2028
2029         Reviewed by Simon Fraser.
2030
2031         * MiniBrowser/mac/BrowserWindow.xib:
2032         Have an enormous maximum width on the location bar, so that it doesn't
2033         stop expanding with the window at 800px.
2034
2035 2015-07-08  Brady Eidson  <beidson@apple.com>
2036
2037         Crash calling [WebView close] in didFinishLoadForFrame callback.
2038         <rdar://problem/21690765> and https://bugs.webkit.org/show_bug.cgi?id=146773
2039
2040         Reviewed by David Kilzer.
2041
2042         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2043         
2044         * TestWebKitAPI/Tests/mac/WebViewCloseInsideDidFinishLoadForFrame.mm: Added.
2045         (-[WebViewCloseFrameLoadDelegate webView:didFinishLoadForFrame:]):
2046         (TestWebKitAPI::TEST):
2047
2048 2015-07-08  Hyungwook Lee  <hyungwook.lee@navercorp.com>
2049
2050         Fix ASSERTION FAILED: !m_pendingNavigationID in WebPage::reload().
2051         https://bugs.webkit.org/show_bug.cgi?id=146546
2052
2053         Reviewed by Darin Adler.
2054
2055         We did't reset pendingNavigationID value when request url is empty.
2056         Hence we need to ignore ASSERT check in this case.
2057
2058         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2059         (TestWebKitAPI::TEST):
2060
2061 2015-07-08  Benjamin Poulain  <bpoulain@apple.com>
2062
2063         [Content Extensions] Fuse undistinguishable actions as much as possible
2064         https://bugs.webkit.org/show_bug.cgi?id=146762
2065
2066         Reviewed by Alex Christensen.
2067
2068         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2069         Test that combinations and flags still work as expected.
2070
2071 2015-07-08  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2072
2073         [GTK] [Wayland] Allow building and testing the Wayland target with the default JHBuild moduleset.
2074         https://bugs.webkit.org/show_bug.cgi?id=146056
2075
2076         Reviewed by Martin Robinson.
2077
2078         * gtk/install-dependencies: libepoxy is now required for building GTK+.
2079         * gtk/jhbuild-wayland.modules: Removed. Not longer needed.
2080         * gtk/jhbuild.modules: Upgrade GTK+ (3.16.4) and required dependencies for building:
2081         Cairo (1.14.2), Gdk-Pixbuf (2.30.8) and GLib (2.44.1).
2082         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Removed. Not longer needed.
2083         Cairo removed support for LTO on (1.14). Upstream commit: c7ff9bb.
2084         * gtk/patches/gtk-3.6-do-not-shutdown-accessibility.patch: Removed. Not longer needed.
2085         GTK+ merged this patch on GTK+-3.10. Upstream commit: 8d83d98.
2086
2087 2015-07-06  Matt Rajca  <mrajca@apple.com>
2088
2089         Media Session: propagate metadata changes to UI clients
2090         https://bugs.webkit.org/show_bug.cgi?id=146660
2091
2092         Reviewed by Tim Horton.
2093
2094         * WebKitTestRunner/TestController.cpp: Build fixes for updated PageUIClient.
2095         (WTR::TestController::createOtherPage):
2096         (WTR::TestController::createWebViewWithOptions):
2097
2098 2015-07-07  Brady Eidson  <beidson@apple.com>
2099
2100         HTTP Auth cached after disabling private browsing/reset.
2101         <rdar://problem/8293055> and https://bugs.webkit.org/show_bug.cgi?id=146654
2102
2103         Reviewed by Tim Horton.
2104
2105         * DumpRenderTree/mac/DumpRenderTree.mm:
2106         (resetWebViewToConsistentStateBeforeTesting): Clear in-memory credentials in between test runs.
2107
2108 2015-07-06  Alex Christensen  <achristensen@webkit.org>
2109
2110         [Content Extensions] Remove memory page reporting
2111         https://bugs.webkit.org/show_bug.cgi?id=146659
2112
2113         Reviewed by Benjamin Poulain.
2114
2115         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2116         (TestWebKitAPI::TEST_F):
2117
2118 2015-07-06  Benjamin Poulain  <benjamin@webkit.org>
2119
2120         [Content Extensions] Make the DFA transitions ranges instead of characters
2121         https://bugs.webkit.org/show_bug.cgi?id=146575
2122
2123         Reviewed by Alex Christensen.
2124
2125         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2126         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
2127         Since the minimizer is perfect, we get the minimal solution now,
2128         which is really cool!
2129
2130 2015-07-06  Brady Eidson  <beidson@apple.com>
2131
2132         ShouldOpenExternalURLsPolicy should default to "Allow" for WK2 API loads.
2133         <rdar://problem/21640050> and https://bugs.webkit.org/show_bug.cgi?id=146563
2134
2135         Reviewed by Geoff Garen.
2136
2137         * WebKitTestRunner/TestInvocation.cpp:
2138         (WTR::TestInvocation::invoke): For testing purposes, all pages should start with the 
2139           ShouldOpenExternalURLsPolicy set to "ShouldNotAllow"
2140
2141 2015-07-06  Daniel Bates  <dabates@apple.com>
2142
2143         Unreviewed, rolling out r170639.
2144
2145         Broke using webkit-patch apply-attachment to apply an
2146         attachment from a security bug. The patch incorrectly assumed
2147         that Bugzilla returns a non-HTTP 200 status code in its HTTP
2148         response when authentication is required.
2149
2150         Reverted changeset:
2151
2152         "webkit-patch apply-from-bug / apply-attachment should not ask
2153         for credentials if none are required"
2154         https://bugs.webkit.org/show_bug.cgi?id=40095
2155         http://trac.webkit.org/changeset/170639
2156
2157 2015-07-04  Chris Dumez  <cdumez@apple.com>
2158
2159         Drop RefPtr::clear() method
2160         https://bugs.webkit.org/show_bug.cgi?id=146556
2161
2162         Reviewed by Brady Eidson.
2163
2164         Drop RefPtr::clear() method in favor of "= nullptr;" pattern.
2165
2166 2015-07-03  Dan Bernstein  <mitz@apple.com>
2167
2168         Fixed the iOS build.
2169
2170         * DumpRenderTree/mac/EventSendingController.mm:
2171         (+[EventSendingController isSelectorExcludedFromWebScript:]):
2172         (+[EventSendingController webScriptNameForSelector:]):
2173
2174 2015-07-03  Dan Bernstein  <mitz@apple.com>
2175
2176         [Xcode] Update some build settings as recommended by Xcode 7
2177         https://bugs.webkit.org/show_bug.cgi?id=146597
2178
2179         Reviewed by Sam Weinig.
2180
2181         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
2182
2183         * DumpRenderTree/mac/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
2184         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
2185         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
2186         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
2187         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
2188
2189         * DumpRenderTree/mac/EventSendingController.mm:
2190         (+[EventSendingController webScriptNameForSelector:]): Removed check for setDragMode:,
2191         which was removed in r19101.
2192
2193         * DumpRenderTree/mac/TextInputController.m:
2194         (-[TextInputController interpretKeyEvents:withSender:]): Suppressed -Wundeclared-selector
2195         around used of a selector not that is not declared anywhere.
2196
2197         * MiniBrowser/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS.
2198
2199         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
2200
2201         * TestWebKitAPI/Configurations/Base.xcconfig: Enabled GCC_NO_COMMON_BLOCKS,
2202         ENABLE_STRICT_OBJC_MSGSEND, CLANG_WARN_BOOL_CONVERSION, CLANG_WARN_CONSTANT_CONVERSION,
2203         CLANG_WARN_EMPTY_BODY, CLANG_WARN_ENUM_CONVERSION, CLANG_WARN_INT_CONVERSION,
2204         CLANG_WARN_UNREACHABLE_CODE, GCC_WARN_ABOUT_RETURN_TYPE,
2205         GCC_WARN_UNINITIALIZED_AUTOS, and GCC_WARN_UNDECLARED_SELECTOR.
2206
2207         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Updated LastUpgradeCheck.
2208
2209 2015-07-02  Daniel Bates  <dabates@apple.com>
2210
2211         [iOS] Add WebKitSystemInterface for iOS 8.4
2212         https://bugs.webkit.org/show_bug.cgi?id=146548
2213
2214         Rubber-stamped by Zalan Bujtas.
2215
2216         * Scripts/copy-webkitlibraries-to-product-directory:
2217
2218 2015-07-02  Carlos Garcia Campos  <cgarcia@igalia.com>
2219
2220         [GTK] WebSQL doesn't work because openDatabase always fails with DOM Exception 18
2221         https://bugs.webkit.org/show_bug.cgi?id=146234
2222
2223         Reviewed by Sergio Villar Senin.
2224
2225         Enable the WebSQL directory test that was disabled because of this bug.
2226
2227         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2228         (testWebContextConfiguration):
2229
2230 2015-07-01  Matthew Daiter  <mdaiter@apple.com>
2231
2232         Enabled MEDIA_STREAM flag
2233         https://bugs.webkit.org/show_bug.cgi?id=145947
2234         <rdar://problem/21365829>
2235         
2236         Reviewed by Eric Carlson.
2237
2238         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2239
2240 2015-06-30  Martin Robinson  <mrobinson@igalia.com>
2241
2242         [GTK] REGRESSION(r183936): Test /webkit2/WebKitWebContext/spell-checker fails since r183936
2243         https://bugs.webkit.org/show_bug.cgi?id=144828
2244
2245         Reviewed by Carlos Garcia Campos.
2246
2247         * WebKitTestRunner/gtk/main.cpp:
2248         (main): Use the new WKTextChecker API to set the spell checking languages
2249         when the process is starting up.
2250
2251 2015-06-30  Andy VanWagoner  <thetalecrafter@gmail.com>
2252
2253         Implement ECMAScript Internationalization API
2254         https://bugs.webkit.org/show_bug.cgi?id=90906
2255
2256         Reviewed by Benjamin Poulain.
2257
2258         * Scripts/webkitperl/FeatureList.pm: add ENABLE_INTL flag
2259
2260 2015-06-30  Jonathan Davis  <jond@apple.com>
2261
2262         Unreviewed. Added myself as a committer.
2263
2264         * Scripts/webkitpy/common/config/contributors.json:
2265
2266 2015-06-30  Brent Fulgham  <bfulgham@apple.com>
2267
2268         Unreviewed build fix.
2269
2270         * Scripts/update-webkit-dependency: Try to build even if we cannot connect
2271         to developer.apple.com to get update libraries.
2272
2273 2015-06-29  Jake Nielsen  <jacob_nielsen@apple.com>
2274
2275         Add timeout in run-webkit-tests for launching the simulator
2276         https://bugs.webkit.org/show_bug.cgi?id=146371
2277
2278         Reviewed by Darin Adler.
2279
2280         Adds a default 5-minute timeout using the timeout class in webkitpy.benchmark_runner.utils
2281         for the otherwise infinitely patient wait_until_device_is_in_state method.
2282
2283         * Scripts/webkitpy/xcode/simulator.py:
2284         (Simulator.DeviceState):
2285         (Simulator):
2286         (Simulator.wait_until_device_is_in_state):
2287         (Simulator.device_state):
2288
2289 2015-06-29  Benjamin Poulain  <benjamin@webkit.org>
2290
2291         Make the NFA transitions range-based
2292         https://bugs.webkit.org/show_bug.cgi?id=146338
2293
2294         Reviewed by Alex Christensen.
2295
2296         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2297         Test some new interesting cases.
2298
2299 2015-06-28  Dan Bernstein  <mitz@apple.com>
2300
2301         [Xcode] Use the same environment for command-line and IDE builds
2302         https://bugs.webkit.org/show_bug.cgi?id=146401
2303
2304         Reviewed by Anders Carlsson.
2305
2306         * Scripts/webkitdirs.pm:
2307         (XcodeOptions): Set the UseSanitizedBuildSystemEnvironment user default to YES, which makes
2308         xcodebuild use the same environment Xcode uses.
2309
2310 2015-06-28  Dan Bernstein  <mitz@apple.com>
2311
2312         REGRESSION (r185915): Source-incompatible change in WKPageUIClient
2313         https://bugs.webkit.org/show_bug.cgi?id=146396
2314
2315         Reviewed by Anders Carlsson.
2316
2317         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2318         (TestWebKitAPI::runJavaScriptAlert): Removed _deprecatedForUseWithV0 suffix from the name.
2319         (TestWebKitAPI::TEST): Updated for renames.
2320         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2321         (runJavaScriptAlert): Removed suffix.
2322         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView): Updated.
2323         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2324         (runJavaScriptAlert): Removed suffix.
2325         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView): Updated.
2326
2327 2015-06-27  Carlos Garcia Campos  <cgarcia@igalia.com>
2328
2329         [GTK][SOUP] Implement WebCore::PublicSuffix for soup and enable PUBLIC_SUFFIX_LIST for GTK+
2330         https://bugs.webkit.org/show_bug.cgi?id=146318
2331
2332         Reviewed by Sergio Villar Senin.
2333
2334         Copy mac PublicSuffix test to the common directory and add it to
2335         the GTK+ build.
2336
2337         * TestWebKitAPI/PlatformGTK.cmake:
2338         * TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp: Added.
2339         (TestWebKitAPI::TEST_F):
2340
2341 2015-06-26  Per Arne Vollan  <peavo@outlook.com>
2342
2343         WinLauncher fails to download files.
2344         https://bugs.webkit.org/show_bug.cgi?id=146242
2345
2346         Reviewed by Alex Christensen.
2347
2348         Added WinLauncher download delegate.
2349
2350         * WinLauncher/Common.cpp:
2351         * WinLauncher/WebDownloadDelegate.cpp: Added.
2352         (WebDownloadDelegate::WebDownloadDelegate):
2353         (WebDownloadDelegate::~WebDownloadDelegate):
2354         (WebDownloadDelegate::QueryInterface):
2355         (WebDownloadDelegate::AddRef):
2356         (WebDownloadDelegate::Release):
2357         (WebDownloadDelegate::decideDestinationWithSuggestedFilename):
2358         (WebDownloadDelegate::didCancelAuthenticationChallenge):
2359         (WebDownloadDelegate::didCreateDestination):
2360         (WebDownloadDelegate::didFailWithError):
2361         (WebDownloadDelegate::didReceiveAuthenticationChallenge):
2362         (WebDownloadDelegate::didReceiveDataOfLength):
2363         (WebDownloadDelegate::didReceiveResponse):
2364         (WebDownloadDelegate::shouldDecodeSourceDataOfMIMEType):
2365         (WebDownloadDelegate::willResumeWithResponse):
2366         (WebDownloadDelegate::willSendRequest):
2367         (WebDownloadDelegate::didBegin):
2368         (WebDownloadDelegate::didFinish):
2369         * WinLauncher/WebDownloadDelegate.h: Added.
2370         * WinLauncher/WinLauncher.cpp:
2371         (WinLauncher::setAccessibilityDelegate):
2372         (WinLauncher::setResourceLoadDelegate):
2373         (WinLauncher::setDownloadDelegate):
2374         (WinLauncher::mainFrame):
2375         * WinLauncher/WinLauncher.h:
2376         (WinLauncher::standardPreferences):
2377         (WinLauncher::privatePreferences):
2378         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2379         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.filters:
2380         * WinLauncher/WinMain.cpp:
2381         (wWinMain):
2382
2383 2015-06-26  Csaba Osztrogonác  <ossy@webkit.org>
2384
2385         [EFL] Bump libseccomp version to 2.2.1
2386         https://bugs.webkit.org/show_bug.cgi?id=146341
2387
2388         Reviewed by Gyuyoung Kim.
2389
2390         * efl/jhbuild.modules:
2391         * efl/jhbuildrc: Enabled libseccomp build on AArch64.
2392         * efl/patches/libseccomp-pick-up-CC.patch: Removed, we don't need it anymore.
2393
2394 2015-06-25  Alex Christensen  <achristensen@webkit.org>
2395
2396         [Content Extensions] Add a way to match a domain but not subdomains
2397         https://bugs.webkit.org/show_bug.cgi?id=146241
2398         rdar://problem/21557754
2399
2400         Reviewed by Darin Adler.
2401
2402         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2403         (TestWebKitAPI::TEST_F):
2404         Update subdomain test because of changed behavior and add test for new '*' functionality.
2405
2406 2015-06-25  Jaehun Lim  <ljaehun.lim@samsung.com>
2407
2408         Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes.
2409         https://bugs.webkit.org/show_bug.cgi?id=146308
2410
2411         Reviewed by Csaba Osztrogonác.
2412
2413         ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
2414
2415         * Scripts/webkitperl/FeatureList.pm:
2416
2417 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2418
2419         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
2420         https://bugs.webkit.org/show_bug.cgi?id=146149
2421
2422         Reviewed by Sergio Villar Senin.
2423
2424         Update unit tests to use WebKitWebsiteDataManager.
2425
2426         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2427         (testWebContextConfiguration):
2428         (serverCallback):
2429         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2430         (Test::Test): Use WebKitWebsiteDataManager and set all possible
2431         values to ensure unit tests don't write outside the temporary directory.
2432         (Test::~Test): Explicitly reset the web context to ensure its
2433         objects are released before the leaks check.
2434         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2435         (WebViewTest::wait): Fix the GSource used, since we are receiving
2436         a double in seconds, but using g_timeout_add_seconds() that
2437         expects an unsigned in seconds. Use GMainLoopSource to correctly
2438         handle the value and simplify the code.
2439
2440 2015-06-24  Jason Marcell  <jmarcell@apple.com>
2441
2442         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
2443         https://bugs.webkit.org/show_bug.cgi?id=146126
2444         <rdar://problem/18226291>
2445
2446         Reviewed by Alexey Proskuryakov.
2447
2448         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2449         (documentReady): Using combined queues to display iOS projects
2450
2451 2015-06-24  Doug Russell  <d_russell@apple.com>
2452
2453         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject 
2454         when posting a selection notification when on the border between two accessibilityObjects
2455         https://bugs.webkit.org/show_bug.cgi?id=146177
2456
2457         Reviewed by Darin Adler.
2458
2459         Add support for mapping WebCore Accessibility types into JSValueRef types
2460         so they can be used in tests.
2461
2462         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
2463         (webAccessibilityObjectWrapperClass):
2464         (-[AccessibilityNotificationHandler startObserving]):
2465         (makeValueRefForValue):
2466         (makeArrayRefForArray):
2467         (makeObjectRefForDictionary):
2468         (-[AccessibilityNotificationHandler _notificationReceived:]):
2469         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
2470         (webAccessibilityObjectWrapperClass):
2471         (-[AccessibilityNotificationHandler startObserving]):
2472         (makeValueRefForValue):
2473         (makeArrayRefForArray):
2474         (makeObjectRefForDictionary):
2475         (-[AccessibilityNotificationHandler _notificationReceived:]):
2476
2477 2015-06-24  Zalan Bujtas  <zalan@apple.com>
2478
2479         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
2480         https://bugs.webkit.org/show_bug.cgi?id=146273
2481         rdar://problem/18509840
2482
2483         Reviewed by Simon Fraser.
2484
2485         Due to the floating point approximate representation, we can't always produce
2486         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
2487         and by changing the rounding in roundToDevicePixel() from float to double.
2488
2489         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2490         (TestWebKitAPI::TEST):
2491
2492 2015-06-24  Brady Eidson  <beidson@apple.com>
2493
2494         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
2495         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
2496
2497         Reviewed by Alex Christensen.
2498
2499         - Update WKTR to the new client structure.
2500         - Update existing TestWebKitAPI tests to either use the new client structure or
2501           assign the old function signature to the updated variable name.
2502         - Include a new test.
2503
2504         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2505
2506         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
2507         (TestWebKitAPI::runJavaScriptAlert):
2508
2509         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2510         (TestWebKitAPI::TEST):
2511
2512         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
2513         (TestWebKitAPI::analyzeDialogArguments):
2514         (TestWebKitAPI::runJavaScriptAlert):
2515         (TestWebKitAPI::runJavaScriptConfirm):
2516         (TestWebKitAPI::runJavaScriptPrompt):
2517         (TestWebKitAPI::createNewPage):
2518         (TestWebKitAPI::TEST):
2519
2520         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
2521         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
2522
2523         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2524         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
2525
2526         * WebKitTestRunner/TestController.cpp:
2527         (WTR::TestController::createOtherPage):
2528         (WTR::TestController::createWebViewWithOptions):
2529
2530 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
2531
2532         Refactoring benchmark runner script to follow pep8 code style.
2533         https://bugs.webkit.org/show_bug.cgi?id=146264
2534
2535         Reviewed by Ryosuke Niwa.
2536
2537         Refactor benchmark runner script to follow pep8 code style.
2538
2539         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2540         (GenericBenchmarkBuilder.prepare):
2541         (GenericBenchmarkBuilder._run_create_script):
2542         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
2543         (GenericBenchmarkBuilder._fetch_remote_archive):
2544         (GenericBenchmarkBuilder):
2545         (GenericBenchmarkBuilder._checkout_with_subversion):
2546         (GenericBenchmarkBuilder._apply_patch):
2547         (GenericBenchmarkBuilder.clean):
2548         (GenericBenchmarkBuilder._runCreateScript): Deleted.
2549         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
2550         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
2551         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
2552         (GenericBenchmarkBuilder._applyPatch): Deleted.
2553         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2554         (BenchmarkRunner.__init__):
2555         (BenchmarkRunner._find_plan_file):
2556         (BenchmarkRunner.execute):
2557         (BenchmarkRunner._cleanup):
2558         (BenchmarkRunner._dump):
2559         (BenchmarkRunner._wrap):
2560         (BenchmarkRunner._merge):
2561         (BenchmarkRunner._show_results):
2562         (BenchmarkRunner._findPlanFile): Deleted.
2563         (BenchmarkRunner.cleanup): Deleted.
2564         (BenchmarkRunner.dump): Deleted.
2565         (BenchmarkRunner.wrap): Deleted.
2566         (BenchmarkRunner.merge): Deleted.
2567         (BenchmarkRunner.show_results): Deleted.
2568         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2569         (BrowserDriver.prepare_env):
2570         (BrowserDriver.launch_url):
2571         (BrowserDriver.close_browsers):
2572         (BrowserDriver.prepareEnv): Deleted.
2573         (BrowserDriver.launchUrl): Deleted.
2574         (BrowserDriver.closeBrowser): Deleted.
2575         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2576         (OSXBrowserDriver):
2577         (OSXBrowserDriver.prepare_env):
2578         (OSXBrowserDriver.close_browsers):
2579         (OSXBrowserDriver._launch_process):
2580         (OSXBrowserDriver._terminiate_processes):
2581         (OSXBrowserDriver._launch_process_with_caffinate):
2582         (OSXBrowserDriver._screen_size):
2583         (OSXBrowserDriver.prepareEnv): Deleted.
2584         (OSXBrowserDriver.closeBrowsers): Deleted.
2585         (OSXBrowserDriver.launchProcess): Deleted.
2586         (OSXBrowserDriver.terminateProcesses): Deleted.
2587         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
2588         (OSXBrowserDriver.screenSize): Deleted.
2589         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2590         (OSXChromeDriver):
2591         (OSXChromeDriver.launch_url):
2592         (OSXChromeCanaryDriver):
2593         (OSXChromeCanaryDriver.launch_url):
2594         (OSXChromeDriver.launchUrl): Deleted.
2595         (OSXChromeCanaryDriver.launchUrl): Deleted.
2596         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2597         (OSXFirefoxDriver):
2598         (OSXFirefoxDriver.launch_url):
2599         (OSXFirefoxNightlyDriver):
2600         (OSXFirefoxNightlyDriver.launch_url):
2601         (OSXFirefoxDriver.launchUrl): Deleted.
2602         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
2603         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2604         (OSXSafariDriver):
2605         (OSXSafariDriver.prepare_env):
2606         (OSXSafariDriver.launch_url):
2607         (OSXSafariDriver.close_browsers):
2608         (OSXSafariDriver._maximize_window):
2609         (OSXSafariDriver.prepareEnv): Deleted.
2610         (OSXSafariDriver.launchUrl): Deleted.
2611         (OSXSafariDriver.closeBrowsers): Deleted.
2612         (OSXSafariDriver.maximizeWindow): Deleted.
2613         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2614         (HTTPServerDriver.fetch_result):
2615         (HTTPServerDriver.kill_server):
2616         (HTTPServerDriver.get_return_code):
2617         (HTTPServerDriver.set_device_id):
2618         (HTTPServerDriver.fetchResult): Deleted.
2619         (HTTPServerDriver.killServer): Deleted.
2620         (HTTPServerDriver.getReturnCode): Deleted.
2621         (HTTPServerDriver.setDeviceID): Deleted.
2622         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2623         (SimpleHTTPServerDriver.serve):
2624         (SimpleHTTPServerDriver.base_url):
2625         (SimpleHTTPServerDriver.fetch_result):
2626         (SimpleHTTPServerDriver.kill_server):
2627         (SimpleHTTPServerDriver.get_return_code):
2628         (SimpleHTTPServerDriver): Deleted.
2629         (SimpleHTTPServerDriver.baseUrl): Deleted.
2630         (SimpleHTTPServerDriver.fetchResult): Deleted.
2631         (SimpleHTTPServerDriver.killServer): Deleted.
2632         (SimpleHTTPServerDriver.getReturnCode): Deleted.
2633         * Scripts/webkitpy/benchmark_runner/utils.py:
2634         (get_path_from_project_root):
2635         (force_remove):
2636         (getPathFromProjectRoot): Deleted.
2637         (forceRemove): Deleted.
2638
2639 2015-06-23  Anders Carlsson  <andersca@apple.com>
2640
2641         Add operator! and copy/move constructors to WeakObjCPtr
2642         https://bugs.webkit.org/show_bug.cgi?id=146255
2643
2644         Reviewed by Andreas Kling.
2645
2646         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
2647         (TEST):
2648
2649 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
2650
2651         Expose some more rendering progress events, and have MiniBrowser log for each of them
2652         https://bugs.webkit.org/show_bug.cgi?id=146227
2653
2654         Reviewed by Darin Adler.
2655
2656         Register for layout milestones/rendering progress events in the WK1 and WK2
2657         browser window controllers, and, if logging is turned on, log when they are
2658         reached.
2659
2660         * MiniBrowser/mac/WK1BrowserWindowController.m:
2661         (-[WK1BrowserWindowController awakeFromNib]):
2662         (-[WK1BrowserWindowController webView:didLayout:]):
2663         * MiniBrowser/mac/WK2BrowserWindowController.m:
2664         (-[WK2BrowserWindowController awakeFromNib]):
2665         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
2666
2667 2015-06-23  Brady Eidson  <beidson@apple.com>
2668
2669         WKFrameInfo should have an accessor for the Frame's current security origin.
2670         https://bugs.webkit.org/show_bug.cgi?id=146162
2671
2672         Reviewed by Dan Bernstein.
2673
2674         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2675         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
2676         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
2677         (sawDialog):
2678         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2679         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2680         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2681         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2682         (TEST):
2683
2684 2015-06-23  Tanay C  <tanay.c@samsung.com>
2685
2686         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
2687         https://bugs.webkit.org/show_bug.cgi?id=146007
2688
2689         Reviewed by Darin Adler.
2690
2691         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2692         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
2693         (pluginLogWithWindowObject):
2694         (pluginLogWithArguments):
2695         (pluginLog):
2696         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
2697         (PluginTest::executeScript):
2698         (PluginTest::log):
2699
2700 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
2701
2702         [EFL] Add libhyphen-dev as dependency after r185862
2703         https://bugs.webkit.org/show_bug.cgi?id=146230
2704
2705         Reviewed by Gyuyoung Kim.
2706
2707         * efl/install-dependencies:
2708
2709 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
2710
2711         [EFL] Hyphenation is not supported
2712         https://bugs.webkit.org/show_bug.cgi?id=89830
2713
2714         Reviewed by Gyuyoung Kim.
2715
2716         * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
2717
2718 2015-06-22  Dewei Zhu  <dewei_zhu@apple.com>
2719
2720         Get rid of factory json files in benchmark_runner
2721         https://bugs.webkit.org/show_bug.cgi?id=146175
2722
2723         Reviewed by Ryosuke Niwa.
2724
2725         Get rid of factory json files in benchmark_runner and refactoring the code.
2726
2727         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:
2728         (benchmark_builder_loader):
2729         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
2730         (BenchmarkBuilderFactory):
2731         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
2732         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2733         (GenericBenchmarkBuilder):
2734         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2735         (BenchmarkRunner.__init__):
2736         (BenchmarkRunner.execute):
2737         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:
2738         (browser_driver_loader):
2739         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2740         (BrowserDriver):
2741         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2742         (BrowserDriverFactory):
2743         (BrowserDriverFactory.available_platforms):
2744         (BrowserDriverFactory.available_browsers):
2745         (BrowserDriverFactory.add_browser_driver):
2746         (BrowserDriverFactory.create):
2747         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
2748         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2749         (OSXBrowserDriver):
2750         (OSXBrowserDriver.prepareEnv):
2751         (OSXBrowserDriver.terminateProcesses):
2752         (OSXBrowserDriver.screenSize):
2753         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2754         (OSXChromeDriver):
2755         (OSXChromeCanaryDriver):
2756         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2757         (OSXFirefoxDriver):
2758         (OSXFirefoxNightlyDriver):
2759         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2760         (OSXSafariDriver):
2761         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
2762         (GenericFactory.create):
2763         (GenericFactory.add):
2764         (GenericFactory.iterateGetItem): Deleted.
2765         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
2766         (http_server_driver_loader):
2767         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
2768         (HTTPServerDriver):
2769         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
2770         (HTTPServerDriverFactory):
2771         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
2772         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
2773         (SimpleHTTPServerDriver):
2774         * Scripts/webkitpy/benchmark_runner/utils.py:
2775         (is_subclass):
2776         (load_subclasses):
2777         (ModuleNotFoundError): Deleted.
2778         (loadModule): Deleted.
2779         (loadJSONFromFile): Deleted.
2780
2781 2015-06-22  Simon Fraser  <simon.fraser@apple.com>
2782
2783         Make it possible to enable incremental rendering suppression in MiniBrowser
2784         https://bugs.webkit.org/show_bug.cgi?id=146223
2785         
2786         Reviewed by Tim Horton.
2787
2788         Add a menu item to enable incremental rendering suppression to MiniBrowser.
2789         
2790         For WK1, this just toggles a pref, and takes effect immediately.
2791         
2792         For WK2, this is a WKConfiguration property, so only affects new web views.
2793         
2794         Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
2795         logging on launch.
2796
2797         * MiniBrowser/mac/AppDelegate.m:
2798         (defaultConfiguration):
2799         * MiniBrowser/mac/BrowserWindow.xib:
2800         * MiniBrowser/mac/SettingsController.h:
2801         * MiniBrowser/mac/SettingsController.m:
2802         (-[SettingsController _populateMenu]):
2803         (-[SettingsController validateMenuItem:]):
2804         (-[SettingsController toggleIncrementalRenderingSuppressed:]):
2805         (-[SettingsController incrementalRenderingSuppressed]):
2806         * MiniBrowser/mac/WK1BrowserWindowController.m:
2807         (-[WK1BrowserWindowController didChangeSettings]):
2808
2809 2015-06-19  Filip Pizlo  <fpizlo@apple.com>
2810
2811         Run CDjs as part of JSC stress testing
2812         https://bugs.webkit.org/show_bug.cgi?id=146174
2813
2814         Reviewed by Geoffrey Garen.
2815
2816         * Scripts/run-javascriptcore-tests:
2817         (runJSCStressTests): Make this aware of the cdjs-tests.yaml.
2818         * Scripts/run-jsc-stress-tests:
2819         - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
2820         - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
2821         - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
2822
2823 2015-06-21  Alexey Proskuryakov  <ap@apple.com>
2824
2825         REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
2826         https://bugs.webkit.org/show_bug.cgi?id=146121
2827         rdar://problem/21395180
2828
2829         Reviewed by Darin Adler.
2830
2831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2832         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
2833         (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
2834         (TestWebKitAPI::overrideAppleLanguages):
2835         (TestWebKitAPI::languageForSystemLanguage):
2836         (TestWebKitAPI::TEST):
2837
2838 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
2839
2840         [CMake] Ignore warnings from system headers when compiling Tools
2841         https://bugs.webkit.org/show_bug.cgi?id=146185
2842
2843         Reviewed by Martin Robinson.
2844
2845         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
2846         from system headers that we don't control.
2847
2848         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
2849         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
2850         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
2851         * ImageDiff/PlatformGTK.cmake:
2852         * MiniBrowser/efl/CMakeLists.txt:
2853         * MiniBrowser/gtk/CMakeLists.txt:
2854         * TestWebKitAPI/PlatformEfl.cmake:
2855         * TestWebKitAPI/PlatformGTK.cmake:
2856         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2857         * WebKitTestRunner/CMakeLists.txt:
2858         * WebKitTestRunner/PlatformEfl.cmake:
2859         * WebKitTestRunner/PlatformGTK.cmake:
2860
2861 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
2862
2863         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
2864         https://bugs.webkit.org/show_bug.cgi?id=146186
2865
2866         Reviewed by Martin Robinson.
2867
2868         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
2869         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
2870
2871         * MiniBrowser/gtk/CMakeLists.txt:
2872
2873 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
2874
2875         Build fix after r146125.
2876
2877         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2878         (OSXSafariDriver):
2879         (OSXSafariDriver.prepareEnv):
2880
2881 2015-06-19  Brady Eidson  <beidson@apple.com>
2882
2883         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
2884         https://bugs.webkit.org/show_bug.cgi?id=146152
2885
2886         Reviewed by Dan Bernstein.
2887
2888         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2889         * WebKitTestRunner/WebNotificationProvider.cpp:
2890
2891 2015-06-19  Mark Lam  <mark.lam@apple.com>
2892
2893         CheckedArithmetic's operator bool() and operator==() is broken.
2894         https://bugs.webkit.org/show_bug.cgi?id=146129
2895
2896         Reviewed by Geoffrey Garen and Oliver Hunt.
2897
2898         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
2899         and overflow scenarios in usage of the Checked arithmetic class.
2900
2901         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
2902         (TestWebKitAPI::OverflowCrashLogger::overflowed):
2903         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
2904         (TestWebKitAPI::OverflowCrashLogger::crash):
2905         (TestWebKitAPI::OverflowCrashLogger::reset):
2906         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
2907         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
2908         (TestWebKitAPI::OverflowCrashLogger::didCrash):
2909         - crash logger for verifying that a crash occurs when expected. 
2910
2911         (TestWebKitAPI::resetOverflow):
2912         - convenience function for resetting a test value to an initial overflowed state
2913           before a crash.  We will use this value in the overflow testing.
2914
2915         (TestWebKitAPI::CheckedArithmeticTester::run):
2916         - Added new tests for all the comparison operators.
2917
2918 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
2919
2920         Fix the Windows build after r185721
2921         https://bugs.webkit.org/show_bug.cgi?id=146146
2922
2923         Reviewed by Csaba Osztrogonác.
2924
2925         Speculative buildfix.
2926
2927         * DumpRenderTree/win/UIDelegate.h:
2928         (UIDelegate::unused4): Added.
2929         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
2930
2931 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
2932
2933         Unreviewed. Add myself as a committer.
2934
2935         * Scripts/webkitpy/common/config/contributors.json:
2936
2937 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
2938
2939         Remove unnecessary svn:executable flags
2940         https://bugs.webkit.org/show_bug.cgi?id=146107
2941
2942         Reviewed by Alexey Proskuryakov.
2943
2944         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
2945         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
2946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
2947         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
2948         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
2949         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
2950         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
2951         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
2952         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
2953         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
2954         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
2955         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
2956         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
2957         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
2958
2959 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
2960
2961         Disable tests on the WinCairo buildbot
2962         https://bugs.webkit.org/show_bug.cgi?id=146106
2963
2964         Reviewed by Alexey Proskuryakov.
2965
2966         * BuildSlaveSupport/build.webkit.org-config/config.json:
2967         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2968
2969 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
2970
2971         [EFL] Fix the minibrowser after r185725
2972         https://bugs.webkit.org/show_bug.cgi?id=146135
2973
2974         Reviewed by Gyuyoung Kim.
2975
2976         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
2977         for the elm_config_accel_preference_set() to set the config of acceleration preference.
2978
2979         * MiniBrowser/efl/main.c:
2980         (elm_main): Deleted the HAVE_ECORE_X guard.
2981
2982 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
2983
2984         Extend capability of run-benchmark script to support mobile device
2985         https://bugs.webkit.org/show_bug.cgi?id=146125
2986
2987         Reviewed by Ryosuke Niwa.
2988
2989         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
2990         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
2991
2992         * Scripts/run-benchmark:
2993         (main): Deleted.
2994         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2995         (BenchmarkRunner.__init__):
2996         (BenchmarkRunner.execute):
2997         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2998         (BrowserDriver.prepareEnv):
2999         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3000         (OSXBrowserDriver.prepareEnv):
3001         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3002         (OSXSafariDriver.prepareEnv):
3003         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
3004         (HTTPServerDriver.getReturnCode):
3005         (HTTPServerDriver):
3006         (HTTPServerDriver.setDeviceID):
3007         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
3008         (parse_args):
3009         (start):
3010         (main):
3011         * Scripts/webkitpy/benchmark_runner/utils.py:
3012         (getPathFromProjectRoot):
3013
3014 2015-06-18  Jon Lee  <jonlee@apple.com>
3015
3016         Unreviewed. Add Matt Daiter as a contributor.
3017
3018         * Scripts/webkitpy/common/config/contributors.json:
3019
3020 2015-06-18  Mark Lam  <mark.lam@apple.com>
3021
3022         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
3023         https://bugs.webkit.org/show_bug.cgi?id=146103
3024
3025         Not reviewed.
3026
3027         Follow up to fix some typos not caught before original patch was landed.
3028
3029         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3030         (TestWebKitAPI::CheckedArithmeticTester::run):
3031         (TestWebKitAPI::AllowMixedSignednessTest::run):
3032         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
3033
3034 2015-06-18  Daniel Bates  <dabates@apple.com>
3035
3036         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
3037         https://bugs.webkit.org/show_bug.cgi?id=146082
3038
3039         Reviewed by Darin Adler.
3040
3041         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
3042         working directory after being invoked in a different Git checkout. In particular,
3043         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
3044         a pure Git checkout g will fail to update g.
3045
3046         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
3047         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
3048         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
3049         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
3050         different than the current working directory). Instead runGitUpdate() should check
3051         whether the current working directory is a Git SVN checkout on each invocation.
3052
3053         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
3054         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
3055         SVN directory from isGitSVN().
3056         (isGitSVN): Implemented in terms of isGitSVNDirectory().
3057         * Scripts/webkitdirs.pm:
3058         (runGitUpdate): Modified to use isGitSVNDirectory().
3059
3060 2015-06-18  Mark Lam  <mark.lam@apple.com>
3061
3062         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
3063         https://bugs.webkit.org/show_bug.cgi?id=146103
3064
3065         Reviewed by Anders Carlsson.
3066
3067         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
3068         part of a large macro.  This makes them harder to:
3069
3070         1. write: no editor help with indentations, have to add trailing '\'s,
3071            inconvenient to add line breaks and comments.
3072
3073         2. read: no chroma coding / syntax highlighting.
3074
3075         3. debug: compile time errors are reported as being on the single line where
3076            the macro is used.
3077
3078         Refactoring the tests to use C++ templates solves all these issues.
3079
3080         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
3081         (TestWebKitAPI::CheckedArithmeticTester::run):
3082         (TestWebKitAPI::AllowMixedSignednessTest::run):
3083         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
3084         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
3085         (TestWebKitAPI::CoerceLiteralNop::coerce):
3086
3087 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
3088
3089         [EFL][WK2] Use Web Browser cache model in MiniBrowser
3090         https://bugs.webkit.org/show_bug.cgi?id=112273
3091
3092         Reviewed by Laszlo Gombos.
3093
3094         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
3095         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
3096         This way we have a decent cache capacity and the page cache actually works.
3097
3098         * MiniBrowser/efl/main.c:
3099         (elm_main):
3100
3101 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3102
3103         Remove redundant Chromium bug keyword
3104         https://bugs.webkit.org/show_bug.cgi?id=146097
3105
3106         Reviewed by Csaba Osztrogonác.
3107
3108         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3109         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
3110         (TestExpectationLine._format_line): Deleted.
3111
3112 2015-06-17  Daniel Bates  <dabates@apple.com>
3113
3114         Client may receive began editing callback for already focused text field
3115         https://bugs.webkit.org/show_bug.cgi?id=146074
3116         <rdar://problem/21293562>
3117
3118         Reviewed by Darin Adler.
3119
3120         Add a unit test to ensure that a client receives exactly one began editing
3121         callback when a text field is newly focused. In particular, dispatching
3122         a DOM focus event at an already focused text field does not dispatch a
3123         began editing callback to the client.
3124
3125         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
3126         (TestWebKitAPI::TEST_F):
3127
3128 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3129
3130         [Win]Implement layoutTestController.dispatchPendingLoadRequests. 
3131         https://bugs.webkit.org/show_bug.cgi?id=26481
3132
3133         Reviewed by Darin Adler.
3134
3135         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
3136
3137         * DumpRenderTree/win/TestRunnerWin.cpp:
3138         (TestRunner::dispatchPendingLoadRequests):
3139         (TestRunner::overridePreference):
3140
3141 2015-06-17  Alex Christensen  <achristensen@webkit.org>
3142
3143         [Content Extensions] Fail to parse invalid arrays
3144         https://bugs.webkit.org/show_bug.cgi?id=146079
3145         rdar://problem/21422649
3146
3147         Reviewed by Benjamin Poulain.
3148
3149         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3150         (TestWebKitAPI::TEST_F):
3151         Correct and add parsing tests with invalid arrays.
3152
3153 2015-06-17  Matt Rajca  <mrajca@apple.com>
3154
3155         Unreviewed. Added myself as a committer.
3156
3157         * Scripts/webkitpy/common/config/contributors.json:
3158
3159 2015-06-17  Daniel Bates  <dabates@apple.com>
3160
3161         Export VCSUtils::gitTreeDirectory()
3162         <rdar://problem/21248901>
3163
3164         Rubber-stamped by Alexey Proskuryakov.
3165
3166         * Scripts/VCSUtils.pm:
3167
3168 2015-06-17  Tim Horton  <timothy_horton@apple.com>
3169
3170         Safari tabs still have shrunken content after coming out of fullscreen
3171         https://bugs.webkit.org/show_bug.cgi?id=146037
3172         <rdar://problem/21105960>
3173
3174         Reviewed by Simon Fraser and Darin Adler.
3175
3176         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3177         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
3178         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
3179         (TEST):
3180         Add a test that ensures that disabling scale-to-fit mode correctly updates
3181         the page's layout.
3182
3183 2015-06-17  Dan Bernstein  <mitz@apple.com>
3184
3185         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
3186         https://bugs.webkit.org/show_bug.cgi?id=145957
3187
3188         Reviewed by Darin Adler.
3189
3190         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
3191         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
3192
3193 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
3194
3195         AX:  iOS accessibility tests are not running because we need WKTR support
3196         https://bugs.webkit.org/show_bug.cgi?id=145991
3197
3198         Reviewed by Daniel Bates.
3199
3200         Add support for WKTR iOS accessibility.
3201         Utilize the notification handling mechanisms that Mac already uses.
3202         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
3203
3204         * DumpRenderTree/AccessibilityUIElement.cpp:
3205         (stringForSelectionCallback):
3206         (getIdentifierCallback):
3207         (getTraitsCallback):
3208         (getElementTextPositionCallback):
3209         (getElementTextLengthCallback):
3210         (AccessibilityUIElement::getJSClass):
3211         (getIPhoneLabelCallback): Deleted.
3212         (getIPhoneHintCallback): Deleted.
3213         (getIPhoneValueCallback): Deleted.
3214         (getIPhoneIdentifierCallback): Deleted.
3215         (getIPhoneTraitsCallback): Deleted.
3216         (getIPhoneIsElementCallback): Deleted.
3217         (getIPhoneElementTextPositionCallback): Deleted.
3218         (getIPhoneElementTextLengthCallback): Deleted.
3219         * DumpRenderTree/AccessibilityUIElement.h:
3220         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3221         (AccessibilityUIElement::identifier):
3222         (AccessibilityUIElement::traits):
3223         (AccessibilityUIElement::elementTextPosition):
3224         (AccessibilityUIElement::elementTextLength):
3225         (AccessibilityUIElement::description):
3226         (AccessibilityUIElement::orientation):
3227         (AccessibilityUIElement::stringValue):
3228         (AccessibilityUIElement::language):
3229         (AccessibilityUIElement::helpText):
3230         (AccessibilityUIElement::intValue):
3231         (AccessibilityUIElement::isSelected):
3232         (AccessibilityUIElement::isExpanded):
3233         (AccessibilityUIElement::documentURI):
3234         (AccessibilityUIElement::addNotificationListener):
3235         (AccessibilityUIElement::removeNotificationListener):
3236         (AccessibilityUIElement::isFocusable):
3237         (AccessibilityUIElement::isIgnored):
3238         (AccessibilityUIElement::hasPopup):
3239         (AccessibilityUIElement::iphoneLabel): Deleted.
3240         (AccessibilityUIElement::iphoneHint): Deleted.
3241         (AccessibilityUIElement::iphoneValue): Deleted.
3242         (AccessibilityUIElement::iphoneIdentifier): Deleted.
3243         (AccessibilityUIElement::iphoneTraits): Deleted.
3244         (AccessibilityUIElement::iphoneIsElement): Deleted.
3245         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
3246         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
3247         (_accessibilityNotificationCallback): Deleted.
3248         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3249         (WTR::AccessibilityUIElement::isValid):
3250         (WTR::AccessibilityUIElement::identifier):
3251         (WTR::AccessibilityUIElement::traits):
3252         (WTR::AccessibilityUIElement::elementTextPosition):
3253         (WTR::AccessibilityUIElement::elementTextLength):
3254         (WTR::AccessibilityUIElement::stringForSelection):
3255         (WTR::AccessibilityUIElement::elementsForRange):
3256         (WTR::AccessibilityUIElement::increaseTextSelection):
3257         (WTR::AccessibilityUIElement::decreaseTextSelection):
3258         (WTR::AccessibilityUIElement::linkedElement):
3259         (WTR::AccessibilityUIElement::headerElementAtIndex):
3260         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
3261         (WTR::AccessibilityUIElement::characterAtOffset):
3262         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3263         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3264         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
3265         (WTR::findAccessibleObjectById):
3266         (WTR::AccessibilityController::accessibleElementById):
3267         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3268         (+[NSString stringWithJSStringRef:]):
3269         (-[NSString createJSStringRef]):
3270         (WTR::convertNSArrayToVector):
3271         (WTR::concatenateAttributeAndValue):
3272         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3273         (WTR::AccessibilityUIElement::isEqual):
3274         (WTR::AccessibilityUIElement::headerElementAtIndex):
3275         (WTR::AccessibilityUIElement::linkedElement):
3276         (WTR::AccessibilityUIElement::getLinkedUIElements):
3277         (WTR::AccessibilityUIElement::elementAtPoint):
3278         (WTR::convertElementsToObjectArray):
3279         (WTR::AccessibilityUIElement::elementsForRange):
3280         (WTR::AccessibilityUIElement::indexOfChild):
3281         (WTR::AccessibilityUIElement::stringAttributeValue):
3282         (WTR::AccessibilityUIElement::description):
3283         (WTR::AccessibilityUIElement::orientation):
3284         (WTR::AccessibilityUIElement::stringValue):
3285         (WTR::AccessibilityUIElement::language):
3286         (WTR::AccessibilityUIElement::helpText):
3287         (WTR::AccessibilityUIElement::x):
3288         (WTR::AccessibilityUIElement::clickPointX):
3289         (WTR::AccessibilityUIElement::clickPointY):
3290         (WTR::AccessibilityUIElement::intValue):
3291         (WTR::AccessibilityUIElement::minValue):
3292         (WTR::AccessibilityUIElement::maxValue):
3293         (WTR::AccessibilityUIElement::valueDescription):
3294         (WTR::AccessibilityUIElement::isSelected):
3295         (WTR::AccessibilityUIElement::isSelectedOptionActive):
3296         (WTR::AccessibilityUIElement::stringForRange):
3297         (WTR::AccessibilityUIElement::attributedStringForRange):
3298         (WTR::AccessibilityUIElement::attributesOfHeader):
3299         (WTR::AccessibilityUIElement::traits):
3300         (WTR::AccessibilityUIElement::identifier):
3301         (WTR::AccessibilityUIElement::rowCount):
3302         (WTR::AccessibilityUIElement::rowIndexRange):
3303         (WTR::AccessibilityUIElement::columnIndexRange):
3304         (WTR::AccessibilityUIElement::cellForColumnAndRow):
3305         (WTR::AccessibilityUIElement::horizontalScrollbar):
3306         (WTR::AccessibilityUIElement::documentURI):
3307         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
3308         (WTR::AccessibilityUIElement::increaseTextSelection):
3309         (WTR::AccessibilityUIElement::decreaseTextSelection):
3310         (WTR::AccessibilityUIElement::stringForSelection):
3311         (WTR::AccessibilityUIElement::elementTextPosition):
3312         (WTR::AccessibilityUIElement::elementTextLength):
3313         (WTR::AccessibilityUIElement::url):
3314         (WTR::AccessibilityUIElement::addNotificationListener):
3315         (WTR::AccessibilityUIElement::removeNotificationListener):
3316         (WTR::AccessibilityUIElement::isFocusable):
3317         (WTR::AccessibilityUIElement::isIgnored):
3318         (WTR::AccessibilityUIElement::hasPopup):
3319         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
3320         (WTR::_CGPathEnumerationIteration):
3321         (WTR::AccessibilityUIElement::pathDescription):
3322         (WTR::AccessibilityUIElement::supportedActions):
3323
3324 2015-06-16  Mark Lam  <mark.lam@apple.com>
3325
3326         Use NakedPtr<Exception>& to return exception results.
3327         https://bugs.webkit.org/show_bug.cgi?id=145870
3328
3329         Reviewed by Anders Carlsson and Filip Pizlo.
3330
3331         * TestWebKitAPI/CMakeLists.txt:
3332         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
3333         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
3334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3335         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
3336         (TestWebKitAPI::TEST):
3337         (TestWebKitAPI::nakedPtrFoo):
3338
3339 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
3340
3341         Unreviewed. Adding myself as a committer.
3342
3343         * Scripts/webkitpy/common/config/contributors.json:
3344
3345 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
3346
3347         Add test expectations for El Capitan
3348         https://bugs.webkit.org/show_bug.cgi?id=146005
3349
3350         Rubber-stamped by Dan Bernstein.
3351
3352         Add appropriate tools code.
3353
3354         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
3355         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
3356         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3357         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3358         Added dashboard support.
3359
3360         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
3361         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
3362         Trigger the right build queues on check-in.
3363
3364         * Scripts/webkitpy/common/system/platforminfo.py:
3365         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
3366         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3367         * Scripts/webkitpy/port/mac.py:
3368         * Scripts/webkitpy/port/mac_unittest.py:
3369         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3370         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3371         Added cases for El Capitan, and updated tests for new baseline search paths.
3372
3373 2015-06-15  Alex Christensen  <achristensen@webkit.org>
3374
3375         [Content Extensions] Make max NFA size and max rule count user defaults.
3376         https://bugs.webkit.org/show_bug.cgi?id=145663
3377
3378         Reviewed by Benjamin Poulain.
3379
3380         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3381         (TestWebKitAPI::TEST_F):
3382
3383 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
3384
3385         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
3386         https://bugs.webkit.org/show_bug.cgi?id=145900
3387
3388         Reviewed by Sam Weinig.
3389
3390         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3391         (TEST): Added tests.
3392
3393 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
3394
3395         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
3396         https://bugs.webkit.org/show_bug.cgi?id=145969
3397
3398         Reviewed by Sergio Villar Senin.
3399
3400         Add a test case to the custom URI schemes unit test.
3401
3402         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3403         (testWebContextURIScheme):
3404
3405 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
3406
3407         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
3408         https://bugs.webkit.org/show_bug.cgi?id=145922
3409
3410         Reviewed by Carlos Garcia Campos.
3411
3412         * gtk/jhbuild.modules:
3413         * gtk/patches/glib-warning-fix.patch: Added.
3414
3415 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
3416
3417         Update springLoadingHighlight type
3418         https://bugs.webkit.org/show_bug.cgi?id=145939
3419         rdar://problem/20880213
3420
3421         Reviewed by Darin Adler.
3422
3423         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3424         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3425         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3426         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3427
3428 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
3429
3430         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
3431         https://bugs.webkit.org/show_bug.cgi?id=145945
3432
3433         Reviewed by Stephanie Lewis.
3434
3435         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3436         (OSXBrowserDriver.prepareEnv):
3437         (OSXBrowserDriver.moveCursor): Deleted.
3438         (OSXBrowserDriver): Deleted.
3439         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3440         (OSXSafariDriver.prepareEnv):
3441
3442 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
3443
3444         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
3445         https://bugs.webkit.org/show_bug.cgi?id=145938
3446
3447         Reviewed by Alexey Proskuryakov.
3448
3449         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
3450         LWP::UserAgent to get access to more robust HTTPS support.
3451
3452 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3453
3454         [GTK] Fix return type warning in WebViewTest.cpp
3455         https://bugs.webkit.org/show_bug.cgi?id=145914
3456
3457         Reviewed by Darin Adler.
3458
3459         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
3460         (WebViewTest::isEditable):
3461
3462 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
3463
3464         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
3465         https://bugs.webkit.org/show_bug.cgi?id=145799
3466
3467         Reviewed by Carlos Garcia Campos.
3468
3469         Update header inclusions for headers that have been moved
3470         to Source/WTF/wtf/glib/.
3471
3472         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
3473         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
3474
3475         * TestWebKitAPI/PlatformGTK.cmake:
3476         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
3477         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
3478         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
3479         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
3480         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
3481         (TestWebKitAPI::GMainLoopSourceTest::finish):
3482         (TestWebKitAPI::GMainLoopSourceTest::source):
3483         (TestWebKitAPI::basicRescheduling):
3484         (TestWebKitAPI::TEST):
3485         (TestWebKitAPI::reentrantRescheduling):
3486         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
3487         (TestWebKitAPI::basicDestroyCallbacks):
3488         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
3489         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
3490         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
3491         (log):
3492         (takeLogStr):
3493         (TestWebKitAPI::TEST):
3494         (TestWebKitAPI::returnOutChar):
3495         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
3496         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
3497         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
3498         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
3499         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
3500         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
3501         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
3502         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
3503         (TestWebKitAPI::basicRescheduling): Deleted.
3504         (TestWebKitAPI::TEST): Deleted.
3505         (TestWebKitAPI::reentrantRescheduling): Deleted.
3506         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
3507         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
3508         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
3509         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
3510         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
3511         (log): Deleted.
3512         (takeLogStr): Deleted.
3513         (TestWebKitAPI::TEST): Deleted.
3514         (TestWebKitAPI::returnOutChar): Deleted.
3515         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
3516         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3517         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3518         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3519         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
3520         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
3521         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
3522         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
3523         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
3524         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
3525         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
3526         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3527         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
3528         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
3529         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
3530         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
3531         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
3532         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3533         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
3534         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3535         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3536         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
3537         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
3538         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3539         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
3540         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
3541         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
3542         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
3543         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
3544         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
3545         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
3546         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
3547         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3548         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3549         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
3550         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3551         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
3552         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3553         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3554         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
3555         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3556         * WebKitTestRunner/PlatformGTK.cmake:
3557         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3558         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3559
3560 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3561
3562         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
3563         https://bugs.webkit.org/show_bug.cgi?id=145913
3564
3565         Reviewed by Gyuyoung Kim.
3566
3567         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
3568         (TestWebKitAPI::setupGeolocationProvider):
3569         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
3570         (TestWebKitAPI::setPageLoaderClient):
3571         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
3572         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
3573         * WebKitTestRunner/GeolocationProviderMock.cpp:
3574         (WTR::GeolocationProviderMock::GeolocationProviderMock):
3575         * WebKitTestRunner/WebNotificationProvider.cpp:
3576         (WTR::WebNotificationProvider::provider):
3577
3578 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
3579
3580         Fix the libusrsctp build with clang
3581         https://bugs.webkit.org/show_bug.cgi?id=145128
3582
3583         Reviewed by Gyuyoung Kim.
3584
3585         * efl/jhbuild.modules:
3586         * gtk/jhbuild.modules:
3587
3588 2015-06-11  Mark Lam  <mark.lam@apple.com>
3589
3590         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
3591         https://bugs.webkit.org/show_bug.cgi?id=145872
3592
3593         Reviewed by Michael Saboff.
3594
3595         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
3596         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
3597         - Exercises the JSC ObjC API to call a function which throws an exception.  That
3598           exception will be returned as a JSValue instead of an Exception object.  We
3599           will use this JSValue to test WebCore::reportException() to confirm that it is
3600           able to handle an exception value which is not an Exception object.
3601
3602 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
3603
3604         Move cursor to corner and fix safari window size before running benchmark
3605         https://bugs.webkit.org/show_bug.cgi?id=145858
3606
3607         Reviewed by Ryosuke Niwa
3608
3609         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3610         (OSXBrowserDriver.prepareEnv):
3611         (OSXBrowserDriver):
3612         (OSXBrowserDriver.moveCursor):
3613         (OSXBrowserDriver.getScreenSize):
3614         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
3615         (OSXChromeDriver.launchUrl):
3616         (OSXChromeCanaryDriver.launchUrl):
3617         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
3618         (OSXFirefoxDriver.launchUrl):
3619         (OSXFirefoxNightlyDriver.launchUrl):
3620         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3621         (OSXSafariDriver.prepareEnv):
3622         (OSXSafariDriver):
3623         (OSXSafariDriver.maximizeWindow):
3624
3625 2015-06-11  Daniel Bates  <dabates@apple.com>
3626
3627         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
3628         https://bugs.webkit.org/show_bug.cgi?id=145319
3629
3630         Reviewed by David Kilzer.
3631
3632         Add SPI wrapper header for CoreSimulator and update the source files to reference
3633         it instead of directly referencing the CoreSimulator header.
3634
3635         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
3636         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
3637         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3638         * LayoutTestRelay/LayoutTestRelay/main.m:
3639
3640 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
3641
3642         [EFL] dimmed area for popup does not cover the fullscreen mode.
3643         https://bugs.webkit.org/show_bug.cgi?id=145133
3644
3645         Reviewed by Gyuyoung Kim.
3646
3647         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
3648         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
3649
3650         * MiniBrowser/efl/main.c:
3651         (on_fullscreen_accept):
3652         (on_fullscreen_deny):
3653         (on_fullscreen_enter):
3654
3655 2015-06-10  Commit Queue  <commit-queue@webkit.org>
3656
3657         Unreviewed, rolling out r185442.
3658         https://bugs.webkit.org/show_bug.cgi?id=145871
3659
3660         seems to have broken WTF.StringOperators test (Requested by
3661         alexchristensen on #webkit).
3662
3663         Reverted changeset:
3664
3665         "[Content Extensions] Limit number of rules."
3666         https://bugs.webkit.org/show_bug.cgi?id=145663
3667         http://trac.webkit.org/changeset/185442
3668
3669 2015-06-10  Alex Christensen  <achristensen@webkit.org>
3670
3671         [Content Extensions] Make max NFA size and max rule count user defaults.
3672         https://bugs.webkit.org/show_bug.cgi?id=145663
3673         rdar://problem/21242407
3674
3675         Reviewed by Benjamin Poulain.
3676
3677         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3678         (TestWebKitAPI::TEST_F):
3679
3680 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3681
3682         [EFL] Execute Javascript method in mini browser address bar.
3683         https://bugs.webkit.org/show_bug.cgi?id=145725
3684
3685         Reviewed by Gyuyoung Kim.
3686
3687         Support 'javascript:' scheme in WebKit EFL Mini Browser.
3688
3689         * MiniBrowser/efl/main.c:
3690         (url_from_user_input):
3691         (url_load_from_user_input):
3692         (on_url_bar_activated):
3693         (elm_main):
3694
3695 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
3696
3697         Implement dumpProgressFinishedCallback() for Win layoutTestController.
3698         https://bugs.webkit.org/show_bug.cgi?id=66773
3699
3700         Reviewed by Darin Adler.
3701
3702         * DumpRenderTree/win/FrameLoadDelegate.cpp:
3703         * DumpRenderTree/win/FrameLoadDelegate.h:
3704
3705 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
3706
3707         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
3708         https://bugs.webkit.org/show_bug.cgi?id=145764
3709
3710         Reviewed by Darin Adler.
3711
3712         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
3713         JetStream and SunSpider.
3714
3715         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
3716         (GenericBenchmarkBuilder):
3717         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
3718         the whole JSON as the input.
3719         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
3720         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
3721         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3722         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
3723         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
3724         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
3725         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
3726
3727 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3728
3729         Remove ewstool scripts used by chromium port
3730         https://bugs.webkit.org/show_bug.cgi?id=145789
3731
3732         Reviewed by Csaba Osztrogonác.
3733
3734         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
3735         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
3736         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
3737         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
3738         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
3739
3740 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
3741
3742         Unreviewed, updated my list of email addresses.
3743
3744         * Scripts/webkitpy/common/config/contributors.json:
3745
3746 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
3747
3748         [cmake] Fix the style issues in cmake project files
3749         https://bugs.webkit.org/show_bug.cgi?id=145755
3750
3751         Reviewed by Darin Adler.
3752
3753         * TestWebKitAPI/CMakeLists.txt:
3754         * TestWebKitAPI/PlatformEfl.cmake:
3755
3756 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3757
3758         Fix a typo in r185345.
3759
3760         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3761         (OSXSafariDriver.closeBrowsers):
3762
3763 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3764
3765         Yet another unreviewed build fix :(
3766
3767         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3768         (OSXSafariDriver):
3769         (OSXSafariDriver.launchUrl):
3770         (OSXSafariDriver.closeBrowsers):
3771
3772 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3773
3774         Unreviewed build fix. Initialize result in the case things blow up below.
3775
3776         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3777         (BenchmarkRunner.execute):
3778
3779 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
3780
3781         Partially revert and fix after r185243.
3782
3783         * Scripts/benchmark_runner/benchmark_runner.py:
3784         * Scripts/run-benchmark:
3785
3786 2015-06-08  Daniel Bates  <dabates@apple.com>
3787
3788         Many LayoutTests/http tests time out in DumpRenderTree
3789         https://bugs.webkit.org/show_bug.cgi?id=145770
3790         <rdar://problem/19593910>
3791
3792         Reviewed by Alexey Proskuryakov.
3793
3794         * DumpRenderTree/ios/Info.plist: Add ATS key.
3795         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3796         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
3797         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
3798         that make use of testRunner.pathToLocalResource().
3799
3800 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
3801
3802         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
3803         https://bugs.webkit.org/show_bug.cgi?id=145759
3804
3805         Reviewed by Carlos Garcia Campos.
3806
3807         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
3808         (testWebViewSave):
3809
3810 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3811
3812         [GTK] Add editor mode to MiniBrowser
3813         https://bugs.webkit.org/show_bug.cgi?id=145595
3814
3815         Reviewed by Sergio Villar Senin.
3816
3817         It loads an empty editable web view with an edit toolbar. It makes
3818         easier to test the editor, editing commands and input methods.
3819
3820         * MiniBrowser/gtk/BrowserWindow.c:
3821         (editingCommandCallback):
3822         (browserWindowSetupEditorToolbar):
3823         (browserWindowConstructed):
3824         * MiniBrowser/gtk/main.c:
3825         (createBrowserWindow):
3826
3827 2015-06-05  Zalan Bujtas  <zalan@apple.com>
3828
3829         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
3830
3831         Reviewed by Dan Bernstein.
3832
3833         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
3834         (TestWebKitAPI::TEST):
3835
3836 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3837
3838         [EFL] API test has been broken since r184357
3839         https://bugs.webkit.org/show_bug.cgi?id=145635
3840
3841         Reviewed by Darin Adler.
3842
3843         r184357 suppress cmake build warning using TARGET_FILE property. However
3844         many EFL API test cases have been broken after applying it.
3845
3846         * TestWebKitAPI/CMakeLists.txt:
3847
3848 2015-06-05  Anders Carlsson  <andersca@apple.com>
3849
3850         Make the network cache directory part of WKContextConfigurationRef
3851         https://bugs.webkit.org/show_bug.cgi?id=145711
3852
3853         Reviewed by Antti Koivisto.
3854
3855         * WebKitTestRunner/TestController.cpp:
3856         (WTR::TestController::initialize):
3857
3858 2015-06-05  Anders Carlsson  <andersca@apple.com>
3859
3860         Make the application cache directory part of WKContextConfigurationRef
3861         https://bugs.webkit.org/show_bug.cgi?id=145704
3862
3863         Reviewed by Geoffrey Garen.
3864
3865         * WebKitTestRunner/TestController.cpp:
3866         (WTR::TestController::initialize):
3867
3868 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3869
3870         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
3871         https://bugs.webkit.org/show_bug.cgi?id=145680
3872
3873         Reviewed by Brent Fulgham.
3874
3875         * Scripts/webkitpy/style/checkers/cpp.py:
3876         (check_for_null):
3877         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3878         (WebKitStyleTest.test_null_false_zero):
3879
3880 2015-06-05  Stephanie Lewis  <slewis@apple.com>
3881
3882         Make the web server more robust to timing issues..
3883
3884         Reviewed by Ryosuke Niwa.
3885
3886         Cleaned up exception handling.
3887         Test server is actually serving pages before returning.
3888         Clean up some style issues.
3889
3890         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
3891         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
3892         (SimpleHTTPServerDriver.__init__):
3893         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
3894         (SimpleHTTPServerDriver.baseUrl): 
3895         (SimpleHTTPServerDriver.fetchResult):
3896         (SimpleHTTPServerDriver.killServer):
3897         (SimpleHTTPServerDriver.getReturnCode):
3898
3899 2015-06-05  Stephanie Lewis  <slewis@apple.com>
3900
3901
3902         Add errors to run-benchmark exception handling.
3903
3904         Reviewed by Ryosuke Niwa.
3905
3906         * Scripts/run-benchmark:
3907         (main):
3908         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
3909         (GenericBenchmarkBuilder.prepare):
3910         (GenericBenchmarkBuilder._runCreateScript):
3911         (GenericBenchmarkBuilder._applyPatch):
3912         (GenericBenchmarkBuilder.clean):
3913         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3914         (BenchmarkRunner.__init__):
3915         (BenchmarkRunner.execute):
3916         (BenchmarkRunner):
3917         (BenchmarkRunner.cleanup):
3918         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
3919         (GenericFactory.iterateGetItem):
3920         (GenericFactory.create):
3921         * Scripts/webkitpy/benchmark_runner/utils.py:
3922         (loadModule):
3923         (loadJSONFromFile):
3924         (forceRemove):
3925
3926 2015-06-05  Stephanie Lewis  <slewis@apple.com>
3927
3928         Streamline run-benchmark browser
3929
3930         Reviewed by Ryosuke Niwa.
3931
3932         Add Caffeinate so computer won't sleep while running.
3933         Remove calls to collect output since we were just dumping to stdout anyway.
3934         Add xpc dyld_path.
3935         Default to system safari.
3936
3937         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
3938         (OSXBrowserDriver.launchProcess):
3939         (OSXBrowserDriver.terminateProcesses):
3940         (OSXBrowserDriver):
3941         (OSXBrowserDriver.launchCaffeinateForProcess):
3942         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
3943         (OSXSafariDriver.launchUrl):
3944         (OSXSafariDriver.closeBrowsers):
3945
3946 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
3947
3948         Combine tiny DFAs into slightly larger ones
3949         https://bugs.webkit.org/show_bug.cgi?id=145572
3950
3951         Reviewed by Alex Christensen.
3952
3953         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3954         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
3955         (TestWebKitAPI::DFACombinerTest::SetUp):
3956         (TestWebKitAPI::combine):
3957         (TestWebKitAPI::TEST_F):
3958         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
3959         (TestWebKitAPI::countLiveNodes):
3960         (TestWebKitAPI::createNFAs):
3961         (TestWebKitAPI::buildDFAFromPatterns):
3962         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3963         (TestWebKitAPI::countLiveNodes): Deleted.
3964         (TestWebKitAPI::createNFAs): Deleted.
3965         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
3966
3967 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
3968
3969         WebKitTestRunner leaks strings in generateWhitelist()
3970         https://bugs.webkit.org/show_bug.cgi?id=145665
3971
3972         Reviewed by Myles C. Maxfield.
3973
3974         * WebKitTestRunner/mac/TestControllerMac.mm:
3975         (WTR::generateWhitelist):
3976
3977 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
3978
3979         Fix options in build-jsc for CMake builds
3980         https://bugs.webkit.org/show_bug.cgi?id=145636
3981
3982         Reviewed by Gyuyoung Kim.
3983
3984         CMake only accepts -DXXX=YYY style options.
3985         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
3986
3987         * Scripts/build-jsc:
3988
3989 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
3990
3991         Added a patch so that the colors displayed on the page could be toggled
3992         in case people need accessibility colors displayed in their browser.
3993         https://bugs.webkit.org/show_bug.cgi?id=145570
3994         <rdar://problem/20994468>
3995
3996         Added in CSS colors and toggle buttons for checkmarks in the page, so that
3997         the page could be rendered in a specific way for accessibility needs if needed.
3998
3999         Reviewed by Alexey Proskuryakov.
4000
4001         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
4002         (updateHiddenPlatforms):
4003         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
4004         (toggleAccessibilityColors): Toggle colors on and off
4005         (documentReady): Needed to make changes to the initialization
4006         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
4007         (a:hover):
4008         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
4009         (div.cellButton.hide, div.accessibilityButton.hide):
4010         (div.cellButton.unhide, div.accessibilityButton.unhide):
4011         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
4012         (.popover-tracking:hover):
4013         (.accessibilityButton):
4014         (div.cellButton): Deleted.
4015         (div.cellButton.hide): Deleted.
4016         (div.cellButton.unhide): Deleted.
4017         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
4018         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
4019         (.status-line.neutral .bubble):
4020         (.status-line.unauthorized .bubble):
4021         (.status-line.danger .bubble.pictogram):
4022         (.status-line.bad .bubble.pictogram):
4023         (.status-line.no-bubble .message):
4024         (.status-line.bad .bubble):
4025         (.status-line.good .bubble):
4026         (.status-line.good .message):
4027         (.status-line.bad .message):
4028         (body.accessibility-colors .status-line.good .bubble):
4029         (body.accessibility-colors .status-line.bad .bubble):
4030         (body.accessibility-colors .status-line.good .message):
4031         (body.accessibility-colors .status-line.bad .message):
4032         (.status-line.danger .message):
4033         (.status-line.unauthorized .message):
4034
4035 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
4036
4037         Unreviewed build fix for Dromaeo.
4038
4039         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
4040         (BenchmarkResults._aggregate_results_for_test):
4041
4042 2015-06-03  Anders Carlsson  <andersca@apple.com>
4043
4044         Fix build.
4045
4046         * DumpRenderTree/mac/TestRunnerMac.mm:
4047
4048 2015-06-03  Daniel Bates  <dabates@apple.com>
4049
4050         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
4051         https://bugs.webkit.org/show_bug.cgi?id=145616
4052
4053         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
4054         of the test. Further investigation is needed.
4055
4056         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
4057         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
4058
4059 2015-06-03  Brady Eidson  <beidson@apple.com>
4060
4061         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
4062         https://bugs.webkit.org/show_bug.cgi?id=145580
4063
4064         Reviewed by Mark Lam.
4065
4066         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4067         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
4068
4069 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
4070
4071         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
4072
4073         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
4074         (TestWebKitAPI::TEST): Update the syntax.
4075
4076 2015-06-02  Mark Lam  <mark.lam@apple.com>
4077
4078         build-jsc's --cloop option is broken.
4079         https://bugs.webkit.org/show_bug.cgi?id=145516
4080
4081         Reviewed by Darin Adler.
4082
4083         * Scripts/build-jsc:
4084         - Make sure to disable the JIT when --cloop is specified.
4085           Did analogous fix for --ftljit.
4086
4087 2015-06-02  Daniel Bates  <dabates@apple.com>
4088
4089         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
4090
4091         Rubber-stamped by Alexey Proskuryakov.
4092
4093         * MiniBrowser/mac/Info.plist:
4094         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
4095
4096 2015-06-01  Commit Queue  <commit-queue@webkit.org>
4097
4098         Unreviewed, rolling out r185066.
4099         https://bugs.webkit.org/show_bug.cgi?id=145543
4100
4101         it breaks the FTL JIT builds with a local checkout of llvm
4102         (Requested by pizlo on #webkit).
4103
4104         Reverted changeset:
4105
4106         "build-jsc's --cloop option is broken."
4107         https://bugs.webkit.org/show_bug.cgi?id=145516
4108         http://trac.webkit.org/changeset/185066
4109
4110 2015-06-01  Daniel Bates  <dabates@apple.com>
4111
4112         Notify client that we began editing when text field is focused
4113         https://bugs.webkit.org/show_bug.cgi?id=145439
4114         <rdar://problem/21142108>
4115
4116         Reviewed by Anders Carlsson.
4117
4118         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
4119         a text field is focused and defocused.
4120
4121         * TestWebKitAPI/CMakeLists.txt:
4122         * TestWebKitAPI/PlatformEfl.cmake:
4123         * TestWebKitAPI/PlatformGTK.cmake:
4124         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4125         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
4126         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
4127         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
4128         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
4129         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
4130         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
4131         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
4132         (TestWebKitAPI::TEST_F):
4133         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
4134         (TestWebKitAPI::textFieldDidBeginEditing):
4135         (TestWebKitAPI::textFieldDidEndEditing):
4136         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
4137         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
4138         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
4139
4140 2015-06-01  Alex Christensen  <achristensen@webkit.org>
4141
4142         [Content Extensions] resource-type and load-type should be independent.
4143         https://bugs.webkit.org/show_bug.cgi?id=145528
4144         rdar://problem/21190765
4145
4146         Reviewed by Benjamin Poulain.
4147
4148         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
4149         (TestWebKitAPI::TEST_F):
4150
4151 2015-06-01  Daniel Bates  <dabates@apple.com>
4152
4153         Add ATS keys to WebKitTestRunnerApp
4154         https://bugs.webkit.org/show_bug.cgi?id=145519
4155
4156         Reviewed by Alexey Proskuryakov.
4157
4158         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
4159
4160         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
4161
4162 2015-06-01  Brady Eidson  <beidson@apple.com>
4163
4164         Add WKTR support for "should open external URLs".
4165         https://bugs.webkit.org/show_bug.cgi?id=145505
4166
4167         Reviewed by Darin Adler.
4168
4169         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
4170           "should open external URLs" bit set.
4171         
4172         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
4173           the policy delegate, including whether or not the bit was set.
4174         
4175         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
4176         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4177         (WTR::TestRunner::queueLoad):
4178         * WebKitTestRunner/InjectedBundle/TestRunner.h:
4179         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
4180         (WTR::TestRunner::shouldDumpPolicyCallbacks):
4181         
4182         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4183         (WTR::InjectedBundle::queueLoad):
4184         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4185
4186         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
4187         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
4188
4189         * WebKitTestRunner/TestInvocation.cpp:
4190         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
4191
4192         * WebKitTestRunner/WorkQueueManager.cpp:
4193         (WTR::WorkQueueManager::queueLoad):
4194         * WebKitTestRunner/WorkQueueManager.h:
4195
4196 2015-06-01  Mark Lam  <mark.lam@apple.com>
4197
4198         build-jsc's --cloop option is broken.
4199         https://bugs.webkit.org/show_bug.cgi?id=145516
4200
4201         Reviewed by Darin Adler.
4202
4203         * Scripts/build-jsc:
4204         - Make sure to disable the JIT when --cloop is specified.
4205           Did analogous fix for --ftljit.
4206
4207 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
4208
4209         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
4210         https://bugs.webkit.org/show_bug.cgi?id=144959
4211
4212         Reviewed by Darin Adler.
4213
4214         * Scripts/webkitpy/style/checkers/cmake.py:
4215         (CMakeChecker.check): Use enumerate instead of xrange.
4216         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
4217         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
4218         (CMakeCheckerTest.test_check): Update the expected results.
4219
4220 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
4221
4222         Fix the webkitpy scm unittests after r174051
4223         https://bugs.webkit.org/show_bug.cgi?id=145511
4224
4225         Reviewed by Darin Adler.
4226
4227         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
4228         (GitTestWithMock.make_scm):
4229
4230 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
4231
4232         EWS provides misleading information for not applyable patches
4233         https://bugs.webkit.org/show_bug.cgi?id=145307
4234
4235         Reviewed by Alexey Proskuryakov.
4236
4237         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
4238
4239 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
4240
4241         Further tweak results of WebKit1.StringTruncator after r184965.
4242
4243         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
4244
4245 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
4246
4247         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
4248         https://bugs.webkit.org/show_bug.cgi?id=145264
4249
4250         Reviewed by Carlos Garcia Campos.
4251
4252         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
4253
4254 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
4255
4256         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
4257
4258         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
4259         (BenchmarkResults._lint_subtest_results):
4260         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
4261         (test_aggregate_nested_results):
4262         (test_lint_results):
4263         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
4264
4265 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
4266
4267         run-benchmark should print out the results
4268         https://bugs.webkit.org/show_bug.cgi?id=145398
4269
4270         Reviewed by Antti Koivisto.
4271
4272         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
4273         of the output to catch early errors.
4274
4275         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
4276         (BenchmarkResults): Added.
4277         (BenchmarkResults.__init__): Added.
4278         (BenchmarkResults.format): Added.
4279         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
4280         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
4281         Uses the sample standard deviation to compute the significant figures for the value.
4282         (BenchmarkResults._unit_from_metric): Added.
4283         (BenchmarkResults._aggregate_results): Added.
4284         (BenchmarkResults._aggregate_results_for_test): Added.
4285         (BenchmarkResults._flatten_list): Added.
4286         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
4287         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
4288         (BenchmarkResults._aggregate_values): Added.
4289         (BenchmarkResults._lint_results): Added.
4290         (BenchmarkResults._lint_subtest_results): Added.
4291         (BenchmarkResults._lint_aggregator_list): Added.
4292         (BenchmarkResults._lint_configuration): Added.
4293         (BenchmarkResults._lint_values): Added.
4294         (BenchmarkResults._is_numeric): Added.
4295         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
4296         (BenchmarkResultsTest):