Tools/ChangeLog

   1 2011-11-04  Raphael Kubo da Costa  <kubo@profusion.mobi>
   2
   3         [EFL] DRT: Fix the order of the items in the dumped history list.
   4         https://bugs.webkit.org/show_bug.cgi?id=71562
   5
   6         It did not make much sense to hold the history list in a map, as we do not need
   7         the keys. And the printed items must be sorted by target, which is more easily
   8         done with a vector.
   9
  10         Should make tests such as http/tests/navigation/error404-frames.html pass.
  11
  12         Reviewed by Antonio Gomes.
  13
  14         * DumpRenderTree/efl/DumpHistoryItem.cpp:
  15         (compareHistoryItemsByTarget):
  16         (dumpHistoryItem):
  17
  18 2011-11-04  Patrick Gansterer  <paroga@webkit.org>
  19
  20         [Qt] Remove ENABLE_SQLITE from qmake files
  21         https://bugs.webkit.org/show_bug.cgi?id=71546
  22
  23         Reviewed by Simon Hausmann.
  24
  25         * qmake/mkspecs/features/features.prf:
  26         * qmake/mkspecs/features/webcore.prf:
  27
  28 2011-11-04  Adam Barth  <abarth@webkit.org>
  29
  30         watchlist for WebIDL shouldn't trigger on Internals.idl
  31         https://bugs.webkit.org/show_bug.cgi?id=70657
  32
  33         Reviewed by David Levin.
  34
  35         Internals.idl isn't part of the Web-facing IDL in the project.
  36
  37         * Scripts/webkitpy/common/config/watchlist:
  38
  39 2011-11-04  Anders Carlsson  <andersca@apple.com>
  40
  41         Fix WKTR crash when running NPN_ConvertPoint test.
  42
  43         Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
  44
  45         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
  46         (ConvertPoint::NPP_SetWindow):
  47
  48 2011-11-04  Anders Carlsson  <andersca@apple.com>
  49
  50         NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
  51         https://bugs.webkit.org/show_bug.cgi?id=71570
  52
  53         Reviewed by Simon Fraser.
  54
  55         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  56         (PluginTest::NPP_SetWindow):
  57         * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  58         Remove the NPP parameter from NPP_SetWindow.
  59
  60         * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
  61         (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
  62         Remove the NPP parameter from NPP_SetWindow.
  63
  64         * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
  65         (PassDifferentNPPStruct::NPP_SetWindow):
  66         Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
  67
  68         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
  69         (ConvertPoint::NPP_SetWindow):
  70         Run the test from NPP_SetWindow and call notifyDone() when done.
  71
  72         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  73         (NPP_SetWindow):
  74         Remove unnecessary parameter.
  75
  76 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
  77
  78         [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
  79
  80         Rubber-stamped by Tor Arne Vestbø.
  81
  82         * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
  83         changed slightly after the refactoring.
  84
  85 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
  86
  87         [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
  88
  89         Reviewed by Simon Hausmann.
  90
  91         * qmake/mkspecs/features/default_pre.prf:
  92
  93 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
  94
  95         [Qt] Don't error out on wrong Qt version when qmake does recursive includes
  96
  97         Reviewed by Simmon Hausmann.
  98
  99         * qmake/mkspecs/features/default_pre.prf:
 100
 101 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 102
 103         [Qt] Disable STDIN check before cleaning build dir
 104
 105         It didn't work on the bots.
 106
 107         Reviewed by Ossy.
 108
 109         * Scripts/webkitdirs.pm:
 110
 111 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 112
 113         [Qt] Don't build all of webkit when running build-jsc
 114
 115         In case the whole webkit project was built, but we then subsequently
 116         want to build only JSC, we need to run make in the proper subdirectory.
 117
 118         This also means the incremental target needs to be added to all
 119         makefiles.
 120
 121         Reviewed by Simmon Hausmann.
 122
 123         * Scripts/webkitdirs.pm:
 124         (buildQMakeProject):
 125         * qmake/mkspecs/features/default_post.prf:
 126
 127 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
 128
 129         Fix run-javascriptcore-tests for Qt when it's executed by the bot.
 130
 131         Reviewed by Tor Arne Vestbø.
 132
 133         * Scripts/webkitdirs.pm:
 134         (jscProductDir): jsc path changed.
 135
 136 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 137
 138         [Qt] Error out early if trying to build against Qt < 4.8
 139
 140         Reviewed by Simon Hausmann.
 141
 142         * qmake/mkspecs/features/default_pre.prf:
 143
 144 2011-11-04  Simon Hausmann  <simon.hausmann@nokia.com>
 145
 146         Fix run-launcher for Qt and Gtk.
 147
 148         Rubber-stamped by Tor Arne Vestbø.
 149
 150         * Scripts/webkitdirs.pm:
 151         (isWK2): Re-add isWK2(), as it's used in run-launcher.
 152
 153 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 154
 155         [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
 156
 157         Reviewed by Simon Hausmann.
 158
 159         * Scripts/build-webkit:
 160
 161 2011-11-04  Carlos Garcia Campos  <cgarcia@igalia.com>
 162
 163         [GTK] Use web view title as window title in MiniBrowser
 164         https://bugs.webkit.org/show_bug.cgi?id=71544
 165
 166         Reviewed by Philippe Normand.
 167
 168         * MiniBrowser/gtk/BrowserWindow.c:
 169         (webViewURIChanged): Removed extra space.
 170         (webViewTitleChanged): Set window title using
 171         webkit_web_view_get_title().
 172         (browser_window_init): Set initial default window title.
 173         (browserWindowConstructed): Connect to WebView notify::title
 174         signal.
 175
 176 2011-11-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
 177
 178         [Qt] Refactor and clean up the qmake build system
 179
 180         The qmake build system has accumulated a bit of cruft and redundancy
 181         over time. There's also a fairly tight coupling between how to build
 182         the various targets, and _what_ to build, making it harder to add new
 183         rules or sources. This patch aims to elevate these issues somewhat.
 184
 185         This is a short-list of the changes:
 186
 187           * The rules for how to build targets are now mostly contained as
 188             prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
 189             allows us to do pre- and post-processing of each project file,
 190             which helps to clean up the actual project files.
 191
 192           * Derived sources are no longer generated as a separate make-step
 193             but is part of each target's project file as a subdir. Makefile
 194             rules are used to ensure that we run make on the derived sources
 195             before running qmake on the actual target makefile. This makes
 196             it easier to keep a proper dependency between derived sources
 197             and the target.
 198
 199           * We use GNU make and the compiler to generate dependencies on
 200             UNIX-based systems running Qt 5. This allows us to lessen the
 201             need to run qmake, which should reduce compile time.
 202
 203           * WebKit2 is now build by default if building with Qt 5. It can
 204             be disabled by passing --no-webkit2 to build-webkit.
 205
 206         The result of these changes are hopefully a cleaner and easier
 207         build system to modify, and faster build times due to no longer
 208         running qmake on every single build. It's also a first step
 209         towards possibly generating the list of sources using another
 210         build system.
 211
 212         https://bugs.webkit.org/show_bug.cgi?id=71222
 213
 214         Reviewed by Simon Hausmann.
 215
 216         * DerivedSources.pro: Removed.
 217         * DumpRenderTree/qt/DumpRenderTree.pro:
 218         * DumpRenderTree/qt/ImageDiff.pro:
 219         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
 220         * MiniBrowser/qt/MiniBrowser.pro:
 221         * QtTestBrowser/QtTestBrowser.pro:
 222         * QtTestBrowser/launcherwindow.cpp:
 223         (LauncherWindow::initializeView):
 224         (LauncherWindow::createChrome):
 225         (LauncherWindow::screenshot):
 226         * QtTestBrowser/launcherwindow.h:
 227         (WindowOptions::WindowOptions):
 228         * Scripts/build-webkit:
 229         (unlinkZeroFiles):
 230         * Scripts/webkitdirs.pm:
 231         (qtFeatureDefaults):
 232         (promptUser):
 233         (buildQMakeProject):
 234         * Tools.pro:
 235         * WebKitTestRunner/DerivedSources.pri: Added.
 236         * WebKitTestRunner/DerivedSources.pro: Removed.
 237         * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
 238         * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
 239         * WebKitTestRunner/InjectedBundle/Target.pri: Added.
 240         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
 241         * WebKitTestRunner/Target.pri: Added.
 242         * WebKitTestRunner/WebKitTestRunner.pro:
 243         * WebKitTestRunner/qt/TestInvocationQt.cpp:
 244         * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
 245         * qmake/README: Added.
 246         * qmake/mkspecs/features/default_post.prf: Added.
 247         * qmake/mkspecs/features/default_pre.prf: Added.
 248         * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
 249         * qmake/mkspecs/features/functions.prf: Added.
 250         * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
 251         * qmake/mkspecs/features/mac/default_post.prf: Added.
 252         * qmake/mkspecs/features/mac/default_pre.prf: Added.
 253         * qmake/mkspecs/features/minimal_qt.prf: Added.
 254         * qmake/mkspecs/features/qtwebkit.prf: Added.
 255         * qmake/mkspecs/features/rpath.prf: Added.
 256         * qmake/mkspecs/features/unix/default_post.prf: Added.
 257         * qmake/mkspecs/features/unix/default_pre.prf: Added.
 258         * qmake/mkspecs/features/valgrind.prf: Added.
 259         * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
 260         * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
 261         * qmake/mkspecs/features/win32/default_post.prf: Added.
 262         * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
 263         * qmake/syncqt-4.8: Added.
 264         (showUsage):
 265         ():
 266         (copyFile):
 267         (symlinkFile):
 268
 269 2011-11-04  Eric Seidel  <eric@webkit.org>
 270
 271         Remove deprecated free functions in port.factory
 272         https://bugs.webkit.org/show_bug.cgi?id=71494
 273
 274         Unreviewed.  Fixing exception seen when running test-webkitpy.
 275
 276         Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
 277         unittest, since that script is nearly ready to be deleted.  But I added
 278         it back at the last second and failed to run the tests. :(
 279         This fixes the exception the bots were seeing.
 280
 281         * Scripts/webkitpy/style/checkers/test_expectations.py:
 282         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
 283         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
 284
 285 2011-11-02  Xiaomei Ji  <xji@chromium.org>
 286
 287         Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
 288         https://bugs.webkit.org/show_bug.cgi?id=71163
 289
 290         Reviewed by Ryosuke Niwa.
 291
 292         * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
 293         (WebPreferences::applyTo):
 294
 295 2011-11-03  Eric Seidel  <eric@webkit.org>
 296
 297         Remove deprecated free functions in port.factory
 298         https://bugs.webkit.org/show_bug.cgi?id=71494
 299
 300         Reviewed by Adam Barth.
 301
 302         I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
 303         free functions in factory.py.  To remove these required fixing all callsites
 304         to use MockHost, Host, or PortFactory where appropriate.  After this change
 305         we're only left with a handfull of places where we inappropraitely use a
 306         real Executive, FileSystem or User object during unittesting.
 307
 308         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
 309          - These PortFactory overrides were from an earlier edition of my previous patch
 310            in the end, I removed MockPortFactory so all tests ended up with this same
 311            real PortFactory() with a MockHost.  This was simply redundent code.
 312         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
 313          - Use MockHost to get a mocked-out PortFactory.
 314         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
 315          - This code has no access to a Host object, so we just use a default PortFactory
 316            for now.  This will still incorrectly create real Executive/FileSystem objects
 317            durring unittesting, which is wrong. :(
 318         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
 319          - Use a MockHost to get a mocked PortFactory.
 320         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
 321          - Use a MockHost to get a mocked PortFactory.
 322         * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
 323          - ditto.
 324         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
 325          - ditto.
 326         * Scripts/webkitpy/layout_tests/port/__init__.py:
 327          - factory.get no longer exists.  Yay!
 328         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
 329          - Use a MockHost to get a mocked PortFactory.
 330            To do this efficiently, I created a helper function
 331            and combined all these (mostly redundant) tests into one test
 332            with several calls to the helper function.
 333         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 334          - Pass MockUser and MockExecutive in these port testing subclasses.
 335          - I also removed a bunch of unecessary uses of mocktool. namespacing.
 336         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
 337          - Awesome windows hacks should only happen on win32.  Once we started
 338            using MockExecutives these 'svn help' commands started printing in
 339            other tests, which is how I found this bug.
 340         * Scripts/webkitpy/layout_tests/port/dryrun.py:
 341          - DryRunPort has no Host, so just use a PortFactory() directly.
 342            This will do the wrong thing if we're unittesting the DryRun port
 343            but it's no worse than the existing code.
 344         * Scripts/webkitpy/layout_tests/port/factory.py:
 345          - Remove the free functions.
 346          - Fix argument overriding to be able to override None.
 347         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
 348          - Use a mocked-out PortFactory during testing.
 349         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
 350          - Pass MockExecutive and MockUser to these manual Port instantiations.
 351         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
 352          - No access to a Host object here, so just using PortFactory directly.
 353            This is wrong, but no more wrong than the existing code was.
 354         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
 355          - Use a MockHost to get a mocked out PortFactory.
 356         * Scripts/webkitpy/layout_tests/port/test.py:
 357          - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
 358         * Scripts/webkitpy/layout_tests/port/win.py:
 359          - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
 360            now that we're actually passing MockExecutive to most Port instantiations during testing.
 361         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
 362          - Pass our new "unittesting" bool to _detect_version when actually unittesting.
 363         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 364          - Host is the future.
 365         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
 366          - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
 367            we don't need to pass MockUser explicitly, it does that automatically for us.
 368         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
 369          - Use a MockHost to get a mocked out PortFactory.
 370         * Scripts/webkitpy/style/checkers/test_expectations.py:
 371          - We don't have access to a Host object, so using PortFactory() directly.
 372         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
 373          - Remove unused variable.
 374         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
 375          - Host isn't accessible here, so using PortFactory() directly, which
 376            although unfortunate is no worse than before.
 377         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
 378          - Testing is much easier when you don't need to hack global state...
 379         * Scripts/webkitpy/tool/commands/expectations.py:
 380          - Use the port_factory on the tool.
 381         * Scripts/webkitpy/tool/commands/rebaseline.py:
 382          - ditto.
 383         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 384          - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
 385            the arguments in the right order.  Fixing that made it use a MockFileSystem
 386            (like it had been trying to), which then required us to actually populate
 387            that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
 388         * Scripts/webkitpy/tool/commands/rebaselineserver.py:
 389          - Get the port_factory from the tool.
 390         * Scripts/webkitpy/tool/servers/gardeningserver.py:
 391          - Ditto.
 392         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
 393          - Use a MockHost to get a mocked out Port object.
 394
 395 2011-11-03  Raphael Kubo da Costa  <kubo@profusion.mobi>
 396
 397         [EFL] DRT: Allow choosing which backing store to use.
 398         https://bugs.webkit.org/show_bug.cgi?id=70532
 399
 400         Reviewed by Antonio Gomes.
 401
 402         This change makes it possible to change the backing store used by DRT
 403         from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
 404         setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
 405
 406         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
 407         (DumpRenderTreeChrome::createView):
 408         * DumpRenderTree/efl/DumpRenderTreeView.cpp:
 409         (shouldUseSingleBackingStore):
 410         (chooseAndInitializeAppropriateSmartClass):
 411         (drtViewAdd):
 412         * DumpRenderTree/efl/DumpRenderTreeView.h:
 413
 414 2011-11-02  Erik Arvidsson  <arv@chromium.org>
 415
 416         JS Test Harness: Remove more link tags
 417         https://bugs.webkit.org/show_bug.cgi?id=71339
 418
 419         Reviewed by Ojan Vafai.
 420
 421         * Scripts/make-new-script-test:
 422         (writeTestFile): Don't output <link>
 423
 424 2011-11-03  Thouraya ANDOLSI  <thouraya.andolsi@st.com>
 425
 426         Reviewed by Martin Robinson.
 427
 428         [GTK] arguments passed to build-jsc are not taken into account
 429         https://bugs.webkit.org/show_bug.cgi?id=58333
 430
 431         * Scripts/build-jsc:
 432
 433 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 434
 435         [GTK] Show url of history items in a status bar in MiniBrowser
 436         https://bugs.webkit.org/show_bug.cgi?id=71474
 437
 438         Reviewed by Martin Robinson.
 439
 440         * MiniBrowser/gtk/BrowserWindow.c:
 441         (browserWindowSetStatusText): Set status text and show/hide the
 442         status label.
 443         (resetStatusText): Reset status text when history menu is hidden.
 444         (browserWindowHistoryItemSelected): Show url of currently selected
 445         history item.
 446         (browserWindowCreateBackForwardMenu): Connect to hide signal of
 447         menu to reset the status text.
 448         (browserWindowConstructed): Use GtkOverlay if available to show
 449         status text.
 450
 451 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 452
 453         [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
 454         https://bugs.webkit.org/show_bug.cgi?id=71466
 455
 456         Reviewed by Martin Robinson.
 457
 458         * MiniBrowser/gtk/BrowserWindow.c:
 459         (browserWindowHistoryItemActivated): Go to selected back formard
 460         list item using webkit_web_view_go_to_back_forward_list_item()
 461         (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
 462         given GList of WebKitBackForwardListItems.
 463         (browserWindowUpdateNavigationActions): Enable/disable back and
 464         forward buttons depending on whether it's possible to go
 465         back/forward. Create a menu for back and forward toolbar buttons.
 466         (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
 467         (browserWindowConstructed): Connect to WebKitBackForwardList
 468         changed signal.
 469
 470 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
 471
 472         [Qt] Remove Maemo specific code paths
 473         https://bugs.webkit.org/show_bug.cgi?id=71476
 474
 475         Reviewed by Kenneth Rohde Christiansen.
 476
 477         * QtTestBrowser/launcherwindow.cpp:
 478         (LauncherWindow::~LauncherWindow):
 479         (LauncherWindow::init):
 480         (LauncherWindow::showLinkHover):
 481         (LauncherWindow::selectElements):
 482         (LauncherWindow::showFPS):
 483         (LauncherWindow::updateFPS):
 484         * QtTestBrowser/launcherwindow.h:
 485         (WindowOptions::WindowOptions):
 486         * QtTestBrowser/locationedit.cpp:
 487         * QtTestBrowser/locationedit.h:
 488
 489 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 490
 491         [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
 492         https://bugs.webkit.org/show_bug.cgi?id=71461
 493
 494         Reviewed by Martin Robinson.
 495
 496         * MiniBrowser/gtk/BrowserWindow.c:
 497         (resetEntryProgress): Reset the entry progress after a while when
 498         load has been completed.
 499         (webViewLoadProgressChanged): Update location entry progress.
 500         (browserWindowConstructed): Connect to WebView
 501         notify::estimated-load-progress signal.
 502
 503 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 504
 505         [GTK] Remove WebKit2 C API from MiniBrowser
 506         https://bugs.webkit.org/show_bug.cgi?id=71459
 507
 508         Reviewed by Martin Robinson.
 509
 510         Use the GTK+ API instead to add minimum functionality. The other
 511         features will be ported to GTK+ API in following patches.
 512
 513         * MiniBrowser/gtk/BrowserWindow.c:
 514         (activateUriEntryCallback): Use webkit_web_view_load_uri().
 515         (goBackCallback): Use webkit_web_view_go_back().
 516         (goForwardCallback): Use webkit_web_view_go_forward().
 517         (webViewURIChanged): Update location entry with current uri using
 518         webkit_web_view_get_uri().
 519         (browserWindowFinalize):
 520         (browserWindowGetProperty):
 521         (browserWindowSetProperty):
 522         (browser_window_init):
 523         (browserWindowConstructed): Connect to notify::uri signal of
 524         WebView to be notified when the URI changes.
 525         (browser_window_class_init):
 526         (browser_window_new): Use WebKitWebView.
 527         (browser_window_get_view): Use WebKitWebView
 528         * MiniBrowser/gtk/BrowserWindow.h:
 529         * MiniBrowser/gtk/GNUmakefile.am:
 530         * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
 531         * MiniBrowser/gtk/main.c:
 532         (loadURI): Use webkit_web_view_new().
 533         (main):
 534
 535 2011-11-03  Simon Hausmann  <simon.hausmann@nokia.com>
 536
 537         [Qt] Unable to start MiniBrowser after run-webkit-tests
 538         https://bugs.webkit.org/show_bug.cgi?id=71469
 539
 540         Reviewed by Csaba Osztrogonác.
 541
 542         * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
 543         from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
 544         line arguments.
 545
 546 2011-11-03  Philippe Normand  <pnormand@igalia.com>
 547
 548         [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
 549         https://bugs.webkit.org/show_bug.cgi?id=71445
 550
 551         Reviewed by Martin Robinson.
 552
 553         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 554         (initializeFonts): set directoriesDescription only when needed.
 555         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
 556         (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
 557         refactored the font files loading code to avoid copy/pastes, ease
 558         maintenance and future font directories additions.
 559
 560 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 561
 562         [GTK] Remove GtkLauncher2
 563         https://bugs.webkit.org/show_bug.cgi?id=71449
 564
 565         Reviewed by Martin Robinson.
 566
 567         GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
 568         made sense when we wanted to implement the exactly same wk1 API
 569         for wk2. Now the code would require an ifdef for most the api, so
 570         it's better to remove GtkLauncher2 and port MiniBrowser to the new
 571         GTK+ API.
 572
 573         * GNUmakefile.am:
 574         * GtkLauncher/main.c:
 575         (notifyProgressCb):
 576         (closeWebViewCb):
 577         (createBrowser):
 578         (addWebSettingsGroupToContext):
 579         (main):
 580
 581 2011-11-02  Philippe Normand  <pnormand@igalia.com>
 582
 583         [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
 584         https://bugs.webkit.org/show_bug.cgi?id=71359
 585
 586         Reviewed by Martin Robinson.
 587
 588         * DumpRenderTree/gtk/DumpRenderTree.cpp:
 589         (initializeFonts): Add the new font path for Debian fonts and
 590         refactored the font files loading code to avoid copy/pastes, ease
 591         maintenance and future font directories additions.
 592
 593 2011-11-02  Eric Seidel  <eric@webkit.org>
 594
 595         Move Mocks into _mock files near their implementations
 596         https://bugs.webkit.org/show_bug.cgi?id=71425
 597
 598         Reviewed by Adam Barth.
 599
 600         This entire change is splitting mocktool.py into separate _mock.py files
 601         and placing them next to their real implementations.
 602
 603         I also deleted MockPortFactory (since it was wrong) and was just hiding
 604         the fact that the "skipped-ports" command was broken (and has been for a long time).
 605         So I made MockHost use a real PortFactory (passed a MockHost) and changed
 606         the skipped-ports implementation to use modern PortFactory methods.
 607
 608         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
 609         * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
 610         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
 611         * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
 612         * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
 613         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 614         * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
 615         * Scripts/webkitpy/common/host.py:
 616         * Scripts/webkitpy/common/host_mock.py: Added.
 617         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
 618         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
 619         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
 620         * Scripts/webkitpy/common/net/credentials_unittest.py:
 621         * Scripts/webkitpy/common/net/failuremap_unittest.py:
 622         * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
 623         * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
 624         * Scripts/webkitpy/common/net/statusserver_unittest.py:
 625         * Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
 626         * Scripts/webkitpy/common/system/executive.py:
 627         * Scripts/webkitpy/common/system/executive_mock.py:
 628         * Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
 629         * Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
 630         * Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
 631         * Scripts/webkitpy/common/system/workspace_unittest.py:
 632         * Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
 633         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
 634         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
 635         * Scripts/webkitpy/layout_tests/port/__init__.py:
 636         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
 637         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
 638         * Scripts/webkitpy/layout_tests/port/factory.py:
 639         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
 640         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
 641         * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
 642         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
 643         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
 644         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
 645         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
 646         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
 647         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
 648         * Scripts/webkitpy/test/main.py:
 649         * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
 650         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
 651         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
 652         * Scripts/webkitpy/tool/commands/queries_unittest.py:
 653         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 654         * Scripts/webkitpy/tool/mocktool.py:
 655         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
 656
 657 2011-11-02  Dan Bernstein  <mitz@apple.com>
 658
 659         Fixed the build and removed another copy to ColorBits.ttf.
 660
 661         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
 662         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
 663         * WebKitTestRunner/fonts/ColorBits.ttf: Removed.
 664
 665 2011-11-02  Dan Bernstein  <mitz@apple.com>
 666
 667         REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
 668         https://bugs.webkit.org/show_bug.cgi?id=71424
 669
 670         Reviewed by Sam Weinig.
 671
 672         Removed the ColorBits font and the code to register it in the process
 673         running the tests. The font was only used by the aforementioned test,
 674         which is now being removed.
 675
 676         * DumpRenderTree/fonts/ColorBits-A.png: Removed.
 677         * DumpRenderTree/fonts/ColorBits.ttf: Removed.
 678         * DumpRenderTree/mac/DumpRenderTree.mm:
 679         (allowedFontFamilySet):
 680         (activateTestingFonts):
 681         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
 682         (WTR::inititializeFontConfigSetting):
 683         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
 684         (WTR::allowedFontFamilySet):
 685         (WTR::activateFonts):
 686
 687 2011-11-02  Dan Bernstein  <mitz@apple.com>
 688
 689         Fix an intermittent hang in RenderedImageFromDOMRange.
 690
 691         Reviewed by Anders Carlsson.
 692
 693         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
 694         (TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
 695         immediately if there are no sources by passing a date in the distant past.
 696
 697 2011-11-02  Adam Roben  <aroben@apple.com>
 698
 699         Add git-add-reviewer
 700
 701         I've been using this script for a while to add reviewers to git commits in my local
 702         repository before pushing them to the Subversion repository. Basic usage is:
 703
 704         git-add-reviewer HEAD^ "Joe Schmoe"
 705         or
 706         git-add-reviewer -i trunk
 707
 708         Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
 709         git commits
 710
 711         Reviewed by Sam Weinig.
 712
 713         * Scripts/git-add-reviewer: Added.
 714         (top level): Parse options, check that the working tree is clean, then run in either
 715         interactive or non-interactive mode as appropriate.
 716         (interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
 717         open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
 718         editor exits, we check out the commit just before the earliest one we're modifying. Then
 719         for each commit, we check it out, update the reviewer, and amend the commit to contain the
 720         new reviewer. Finally, we update the branch that was originally checked out to point to the
 721         last amended commit.
 722         (nonInteractive): Check out the commit to modify, write the current commit message to the
 723         MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
 724         the commit, and rebase the original branch on top of the amended commit. (usage): Print out
 725         a usage message and exit.
 726         (requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
 727         and index are clean.
 728         (fail): Print out the specified error message, if any, and return false. This function is
 729         used as a return value in various error cases throughout the script.
 730         (cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
 731         (addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
 732         to .git/MERGE_MSG, which will be used as the commit message for the next commit.
 733         (commit): Call git-commit and use .git/MERGE_MSG as the commit message.
 734
 735         (addReviewerToChangeLog):
 736         (addReviewerToCommitMessage):
 737         These just call through to addReviewerToFile.
 738
 739         (addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
 740         and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
 741         temp file, then move the temp file over the original file and stage it for the next commit.
 742         (head): Returns the name of the currently-checked-out branch.
 743         (isAncestor): Returns true if the first commit is an ancestor of the second.
 744         (toCommit): Converts a commitish to a commit ID using git-rev-parse.
 745         (changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
 746         (resetToCommit): Checks out the given commit, throwing away any local changes.
 747         (writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
 748         the specified file.
 749         (rebaseOntoHead): Rebases the specified branch onto HEAD.
 750         (checkout): Checks out the given commit.
 751         (getConfigValue): Reads the specified config variable from git-config.
 752
 753 2011-11-02  Dean Jackson  <dino@apple.com>
 754
 755         Add ENABLE_CSS_SHADERS flag
 756         https://bugs.webkit.org/show_bug.cgi?id=71394
 757
 758         Reviewed by Sam Weinig.
 759
 760         * Scripts/build-webkit:
 761
 762 2011-10-31  Eric Seidel  <eric@webkit.org>
 763
 764         BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
 765         https://bugs.webkit.org/show_bug.cgi?id=71237
 766
 767         Reviewed by Adam Barth.
 768
 769         Calling the static version of factory.get() with proper mocking
 770         requires passsing an explict filesystem, executive, etc.
 771         So instead, we use a PortFactory instance and pass it a Host pointer.
 772         I had to add a MockHost since we'd not needed a non-host tool before now.
 773
 774         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
 775         * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
 776         * Scripts/webkitpy/tool/commands/rebaseline.py:
 777         * Scripts/webkitpy/tool/mocktool.py:
 778
 779 2011-11-02  Anders Carlsson  <andersca@apple.com>
 780
 781         Update for the WebKit2 API fixage.
 782
 783         * MiniBrowser/mac/BrowserWindowController.m:
 784         (-[BrowserWindowController awakeFromNib]):
 785         * WebKitTestRunner/TestController.cpp:
 786         (WTR::TestController::initialize):
 787
 788 2011-11-02  Anders Carlsson  <andersca@apple.com>
 789
 790         Fix build.
 791
 792         Add new functions to the page loader client.
 793
 794         * MiniBrowser/mac/BrowserWindowController.m:
 795         (-[BrowserWindowController awakeFromNib]):
 796         * WebKitTestRunner/TestController.cpp:
 797         (WTR::TestController::initialize):
 798
 799 2011-11-02  Dan Bernstein  <mitz@apple.com>
 800
 801         <rdar://problem/10336700> Add API to get rendered text image without having to select it
 802         https://bugs.webkit.org/show_bug.cgi?id=71407
 803
 804         Reviewed by Simon Fraser.
 805
 806         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 807         * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.
 808         (-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
 809         (TestWebKitAPI::TEST):
 810
 811 2011-11-02  Benjamin Poulain  <benjamin@webkit.org>
 812
 813         Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
 814         https://bugs.webkit.org/show_bug.cgi?id=71351
 815
 816         Reviewed by Darin Adler.
 817
 818         Add the delimiter "/" at the end of the path instead of adding +1 when using
 819         the path.
 820
 821         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
 822         (-[NSURL _drt_descriptionSuitableForTestResult]):
 823
 824 2011-11-02  Tom Sepez  <tsepez@chromium.org>
 825
 826         XSSAuditor is silent
 827         https://bugs.webkit.org/show_bug.cgi?id=70973
 828
 829         Reviewed by Adam Barth.
 830
 831         * DumpRenderTree/chromium/WebViewHost.cpp:
 832         (WebViewHost::didDetectXSS):
 833         * DumpRenderTree/chromium/WebViewHost.h:
 834         * DumpRenderTree/mac/FrameLoadDelegate.mm:
 835         (-[FrameLoadDelegate webView:didDetectXSS:]):
 836         * MiniBrowser/mac/BrowserWindowController.m:
 837         (didDetectXSSForFrame):
 838         (-[BrowserWindowController awakeFromNib]):
 839         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 840         (WTR::InjectedBundlePage::InjectedBundlePage):
 841         (WTR::InjectedBundlePage::didDetectXSSForFrame):
 842         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
 843
 844 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
 845
 846         [Qt] REGRESSION: 5 editing tests fail
 847         https://bugs.webkit.org/show_bug.cgi?id=71117
 848
 849         Reviewed by Andreas Kling.
 850
 851         Make sure that the view is properly focused, in order to get the
 852         didBeginEditing DRT calls.
 853
 854         This requires activating the window (the call will result in a FocusIn
 855         event to the window as well as setting QGuiApplication::focusWindow())
 856         as well as enabling the focus on the view item. The signature of
 857         setFocus has changed to take a boolean.
 858
 859         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
 860         (WTR::WrapperWindow::handleStatusChanged):
 861
 862 2011-11-02  Matt Falkenhagen  <falken@chromium.org>
 863
 864         [chromium] Add per-script font preferences support in overridePreference
 865         https://bugs.webkit.org/show_bug.cgi?id=71110
 866
 867         This allows a layout test to do something like:
 868
 869         // Set standard font for Arabic to Ahem.
 870         overridePreference("WebKitStandardFontMap", [ "Arab", "Ahem" ]);
 871
 872         This should make writing a layout test for per-script fonts easier.
 873
 874         This change only affects the Chromium DumpRenderTree, but the other
 875         platforms should probably also have a similar change eventually.
 876
 877         Reviewed by Tony Chang.
 878
 879         * DumpRenderTree/chromium/LayoutTestController.cpp: add per-script
 880         font preferences to overridePreference
 881         (LayoutTestController::cppVariantToWebStringArray):
 882         (setFontMap):
 883         (LayoutTestController::overridePreference):
 884         * DumpRenderTree/chromium/LayoutTestController.h:
 885         * DumpRenderTree/chromium/WebPreferences.cpp:
 886         (setStandardFontFamilyWrapper):
 887         (setFixedFontFamilyWrapper):
 888         (setSerifFontFamilyWrapper):
 889         (setSansSerifFontFamilyWrapper):
 890         (setCursiveFontFamilyWrapper):
 891         (setFantasyFontFamilyWrapper):
 892         (applyFontMap):
 893         (WebPreferences::applyTo):
 894         * DumpRenderTree/chromium/WebPreferences.h: add per-script font
 895         preference members
 896         (WebPreferences::UScriptCodeHashTraits::emptyValue):
 897         (WebPreferences::UScriptCodeHashTraits::constructDeletedValue):
 898         (WebPreferences::UScriptCodeHashTraits::isDeletedValue):
 899
 900 2011-11-02  Elliot Poger  <epoger@google.com>
 901
 902         until use_skia=1 by default on mac, default port should be chromium-cg-mac
 903         https://bugs.webkit.org/show_bug.cgi?id=71312
 904
 905         Reviewed by Adam Barth.
 906
 907         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
 908         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
 909         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
 910
 911 2011-11-02  Stephen Chenney  <schenney@chromium.org>
 912
 913         printing layout test failures after r98634
 914         https://bugs.webkit.org/show_bug.cgi?id=71080
 915
 916         Reviewed by Kent Tamura
 917
 918         * DumpRenderTree/chromium/WebViewHost.cpp:
 919         (WebViewHost::paintPagesWithBoundaries): Added transforms invert the CG Bitmap so the coord system
 920         matches that for Skia.
 921
 922 2011-11-01  Sam Weinig  <sam@webkit.org>
 923
 924         Can't complete ChangeLog when using resolve-Changelogs and webkit-tools-completion.sh
 925         https://bugs.webkit.org/show_bug.cgi?id=71346
 926
 927         Reviewed by Dan Bernstein.
 928
 929         * Scripts/webkit-tools-completion.sh:
 930         Add "-o default" which allows for completing files in addition to the word list.
 931
 932 2011-11-02  Simon Hausmann  <simon.hausmann@nokia.com>
 933
 934         [Qt][WK2] Add support for touch event testing to WebKitTestRunner
 935         https://bugs.webkit.org/show_bug.cgi?id=71310
 936
 937         Reviewed by Kenneth Rohde Christiansen.
 938
 939         * WebKitTestRunner/DerivedSources.pro: Build system foo to ensure the ENABLE_TOUCH_EVENTS
 940         define works in EventSendingController.idl
 941         * WebKitTestRunner/EventSenderProxy.h: Add declarations for Qt implementations of touch
 942         handlers.
 943         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add touch functions
 944         required by tests.
 945         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Forward touch messages to the
 946         ui process.
 947         (WTR::EventSendingController::addTouchPoint):
 948         (WTR::EventSendingController::updateTouchPoint):
 949         (WTR::EventSendingController::setTouchModifier):
 950         (WTR::EventSendingController::touchStart):
 951         (WTR::EventSendingController::touchMove):
 952         (WTR::EventSendingController::touchEnd):
 953         (WTR::EventSendingController::clearTouchPoints):
 954         (WTR::EventSendingController::releaseTouchPoint):
 955         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
 956         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Include features.pri for feature
 957         defines.
 958         * WebKitTestRunner/TestController.cpp:
 959         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Forward incoming
 960         touch messages to the EventSenderProxy.
 961         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Implement touch test harness functions.
 962         (WTR::EventSenderProxy::EventSenderProxy):
 963         (WTR::EventSenderProxy::addTouchPoint):
 964         (WTR::EventSenderProxy::updateTouchPoint):
 965         (WTR::EventSenderProxy::setTouchModifier):
 966         (WTR::EventSenderProxy::touchStart):
 967         (WTR::EventSenderProxy::touchMove):
 968         (WTR::EventSenderProxy::touchEnd):
 969         (WTR::EventSenderProxy::clearTouchPoints):
 970         (WTR::EventSenderProxy::releaseTouchPoint):
 971         (WTR::EventSenderProxy::sendTouchEvent):
 972         * WebKitTestRunner/qt/WebKitTestRunner.pro: Include features.pri for feature defines.
 973
 974 2011-11-01  Sam Weinig  <sam@webkit.org>
 975
 976         resolve-ChangeLogs --help should be faster.
 977
 978         Reviewed by Adam Roben.
 979
 980         * Scripts/resolve-ChangeLogs:
 981         (usageAndExit):
 982         Add a call to usageAndExit() before doing work to find unmerged changelogs
 983         if --help or something illegal is provided on the command line.
 984
 985 2011-11-01  Benjamin Poulain  <bpoulain@apple.com>
 986
 987         [Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
 988         https://bugs.webkit.org/show_bug.cgi?id=71342
 989
 990         Reviewed by Darin Adler.
 991
 992         [NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
 993         [NSString substringFromIndex:] with an index out of the string range.
 994
 995         The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
 996         from the root of the disk.
 997         The problem was hidden because the exception are catched when calling the delegate.
 998
 999         This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
1000         in a subdirectory of the main frame.
1001
1002         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1003         (-[NSURL _drt_descriptionSuitableForTestResult]):
1004
1005 2011-11-01  Alok Priyadarshi  <alokp@chromium.org>
1006
1007         [chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
1008         https://bugs.webkit.org/show_bug.cgi?id=71318
1009
1010         Reviewed by James Robinson.
1011
1012         Fixed a typo for --enable-hardware-gpu flag.
1013
1014         * Scripts/webkitpy/layout_tests/port/chromium.py:
1015
1016 2011-11-01  Elliot Poger  <epoger@google.com>
1017
1018         chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
1019         https://bugs.webkit.org/show_bug.cgi?id=71286
1020
1021         Reviewed by Stephen White.
1022
1023         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
1024
1025 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
1026
1027         [Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
1028         https://bugs.webkit.org/show_bug.cgi?id=71299
1029
1030         Reviewed by Andreas Kling.
1031
1032         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
1033         build to enable WebCoreTestSupport::injectInternalsObject.
1034         (WTR::InjectedBundlePage::didClearWindowForFrame):
1035         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
1036
1037 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1038
1039         [Qt] Merge common desktop and touch view APIs under a base class.
1040         https://bugs.webkit.org/show_bug.cgi?id=71280
1041
1042         Reviewed by Andreas Kling.
1043
1044         Remove unneded forwarding logic for TouchWebView since those properties are
1045         now in the view just as the desktop web view.
1046
1047         * MiniBrowser/qt/qml/TouchView.qml:
1048
1049 2011-11-01  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1050
1051         check-webkit-style: Allow names starting with "_q_".
1052         https://bugs.webkit.org/show_bug.cgi?id=70625
1053
1054         Reviewed by Tor Arne Vestbø.
1055
1056         Used by the Qt port as the standard prefix for private slots.
1057
1058         * Scripts/webkitpy/style/checkers/cpp.py:
1059         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1060
1061 2011-11-01  Simon Hausmann  <simon.hausmann@nokia.com>
1062
1063         [Qt][WK2] Fix valgrind error about uninitialized variable
1064         https://bugs.webkit.org/show_bug.cgi?id=71273
1065
1066         Reviewed by Kenneth Christiansen.
1067
1068         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1069         (MiniBrowserApplication::notify): Initialize isPrimary.
1070
1071 2011-10-31  Adam Roben  <aroben@apple.com>
1072
1073         Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
1074
1075         Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
1076         leaky builds
1077
1078         Reviewed by Anders Carlsson.
1079
1080         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
1081         (RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
1082         NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
1083         total of N bytes!").
1084
1085 2011-10-31  Raphael Kubo da Costa  <kubo@profusion.mobi>
1086
1087         [EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
1088         https://bugs.webkit.org/show_bug.cgi?id=71228
1089
1090         Reviewed by Antonio Gomes.
1091
1092         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1093         (DumpRenderTreeChrome::createNewWindow):
1094         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1095
1096 2011-10-31  Eric Seidel  <eric@webkit.org>
1097
1098         webkitpy tests depend too much on the user's environment
1099         https://bugs.webkit.org/show_bug.cgi?id=71234
1100
1101         Reviewed by Dirk Pranke.
1102
1103         This change just makes a bunch of our older tests use
1104         more modern mocking to avoid trying to launch processes
1105         or read from the user's filesystem during unittesting.
1106
1107         I found many of these by adding an assert in Executive.run_command
1108         that we were not unittesting.  I can't add that assert always
1109         as there are some valid uses of Executive during unittesting.
1110         Once I fix more of these, I may find a way to add such an assert conditionally.
1111
1112         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
1113         * Scripts/webkitpy/common/net/credentials_unittest.py:
1114         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1115         * Scripts/webkitpy/layout_tests/port/base.py:
1116         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1117
1118 2011-10-31  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1119
1120         [Qt] MiniBrowser doesn't resize as the size is always overridden
1121         https://bugs.webkit.org/show_bug.cgi?id=71212
1122
1123         Reviewed by Simon Hausmann.
1124
1125         Remove call overriden the size.
1126
1127         * MiniBrowser/qt/main.cpp:
1128         (main):
1129
1130 2011-10-30  Sheriff Bot  <webkit.review.bot@gmail.com>
1131
1132         Unreviewed, rolling out r98819, r98823, r98825, and r98830.
1133         http://trac.webkit.org/changeset/98819
1134         http://trac.webkit.org/changeset/98823
1135         http://trac.webkit.org/changeset/98825
1136         http://trac.webkit.org/changeset/98830
1137         https://bugs.webkit.org/show_bug.cgi?id=71199
1138
1139         Broke Chromium Windows bot (Requested by rniwa on #webkit).
1140
1141         * Scripts/webkitpy/layout_tests/port/base.py:
1142         * Scripts/webkitpy/layout_tests/port/chromium.py:
1143         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1144         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1145         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1146         * Scripts/webkitpy/layout_tests/port/efl.py:
1147         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1148         * Scripts/webkitpy/layout_tests/port/mac.py:
1149         * Scripts/webkitpy/layout_tests/port/qt.py:
1150         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1151         * Scripts/webkitpy/layout_tests/port/webkit.py:
1152         * Scripts/webkitpy/layout_tests/port/win.py:
1153
1154 2011-10-30  Eric Seidel  <eric@webkit.org>
1155
1156         new-run-webkit-tests is locale dependent
1157         https://bugs.webkit.org/show_bug.cgi?id=68691
1158
1159         Unreviewed.
1160
1161         This is a temporary hack until someone from the cr-win port
1162         can take a look and determine which environment variable
1163         lighttpd is missing.
1164
1165         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1166
1167 2011-10-30  Eric Seidel  <eric@webkit.org>
1168
1169         new-run-webkit-tests is locale dependent
1170         https://bugs.webkit.org/show_bug.cgi?id=68691
1171
1172         Unreviewed.  I would have preferred to have this reviewed,
1173         but relevant reviewers are asleep and bots are broken.
1174
1175         This was a regression from moving to a clean environment.
1176         ChromiumWin (and possibly other ports), need the "PATH"
1177         environment copied over.  This wasn't caught in my testing
1178         because although we had unittests to cover this, they
1179         weren't being run on anything but windows.  The vast majority
1180         of this change is just fixing the unittests to use our
1181         modern MockFileSystem/MockUser/MockExecutive so they can
1182         be run on any system (and removing the platform checks from
1183         the unittests so they are run everywhere).
1184
1185         The actual fix is the single line "PATH" string added to base.py.
1186         The rest of this change is just fixing the Chromium port unittests
1187         to run on all systems (including changing the Chromium port to
1188         use FileSystem.path_to_module instead of __file__).
1189
1190         * Scripts/webkitpy/layout_tests/port/base.py:
1191         * Scripts/webkitpy/layout_tests/port/chromium.py:
1192         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1193         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1194         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
1195         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1196
1197 2011-10-29  Eric Seidel  <eric@webkit.org>
1198
1199         new-run-webkit-tests is locale dependent
1200         https://bugs.webkit.org/show_bug.cgi?id=68691
1201
1202         Unreviewed.
1203
1204         Fix the Qt port and unittest the function so we don't break it again.
1205
1206         * Scripts/webkitpy/layout_tests/port/qt.py:
1207         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1208
1209 2011-10-29  Eric Seidel  <eric@webkit.org>
1210
1211         new-run-webkit-tests is locale dependent
1212         https://bugs.webkit.org/show_bug.cgi?id=68691
1213
1214         Reviewed by Adam Barth.
1215
1216         Make NRWT use a clean environment just like ORWT did.
1217         I've manually validated that NRWT now copies over
1218         the same environment variables that ORWT did.
1219         This new code is exercised by existing setup_environ_for_server tests.
1220
1221         * Scripts/webkitpy/layout_tests/port/base.py:
1222         * Scripts/webkitpy/layout_tests/port/efl.py:
1223         * Scripts/webkitpy/layout_tests/port/mac.py:
1224         * Scripts/webkitpy/layout_tests/port/qt.py:
1225         * Scripts/webkitpy/layout_tests/port/webkit.py:
1226         * Scripts/webkitpy/layout_tests/port/win.py:
1227
1228 2011-10-29  Eric Seidel  <eric@webkit.org>
1229
1230         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
1231         https://bugs.webkit.org/show_bug.cgi?id=34984
1232
1233         Reviewed by Adam Barth.
1234
1235         Move run-webkit-tests from using a white-list of supported NRWT ports
1236         to a blacklist of ports requiring ORWT.
1237
1238         I've also added the ability to opt-in to parallel testing on a per-port basis.
1239
1240         With these changes I'm going to officially declare this bug dead and
1241         work on remaining polish issues and individual developer complaints.
1242
1243         * Scripts/run-webkit-tests:
1244         (useNewRunWebKitTests):
1245         (platformIsReadyForParallelTesting):
1246
1247 2011-10-29  Sheriff Bot  <webkit.review.bot@gmail.com>
1248
1249         Unreviewed, rolling out r98780.
1250         http://trac.webkit.org/changeset/98780
1251         https://bugs.webkit.org/show_bug.cgi?id=71173
1252
1253         Broke Qt bots (Requested by rniwa on #webkit).
1254
1255         * Scripts/run-webkit-tests:
1256         (useNewRunWebKitTests):
1257
1258 2011-10-28  Rafael Weinstein  <rafaelw@chromium.org>
1259
1260         webkit.py gdb visualizer is broken after change to StringImpl
1261         https://bugs.webkit.org/show_bug.cgi?id=71154
1262
1263         Reviewed by Tony Chang.
1264
1265         r98624 changed StringImpl m_data to m_data32. This changes updates
1266         webkit.py to match.
1267
1268         * gdb/webkit.py:
1269
1270 2011-10-28  Joseph Pecoraro  <pecoraro@apple.com>
1271
1272         Fix typo in check-for-inappropriate-objc-class-names
1273         https://bugs.webkit.org/show_bug.cgi?id=71144
1274
1275         Reviewed by Dan Bernstein.
1276
1277         * Scripts/check-for-inappropriate-objc-class-names:
1278
1279 2011-10-28  Sadrul Habib Chowdhury  <sadrul@chromium.org>
1280
1281         Add support for sending scroll-update events from EventSender.
1282         https://bugs.webkit.org/show_bug.cgi?id=66272
1283
1284         Reviewed by Adam Barth.
1285
1286         * DumpRenderTree/chromium/EventSender.cpp:
1287         (EventSender::EventSender):
1288         (EventSender::reset):
1289         (EventSender::gestureScrollUpdate):
1290         (EventSender::gestureEvent):
1291         * DumpRenderTree/chromium/EventSender.h:
1292
1293 2011-10-28  Eric Seidel  <eric@webkit.org>
1294
1295         new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
1296         https://bugs.webkit.org/show_bug.cgi?id=34984
1297
1298         Reviewed by Adam Barth.
1299
1300         Move run-webkit-tests from using a white-list of supported NRWT ports
1301         to a blacklist of ports requiring ORWT.
1302
1303         I've also added the ability to opt-in to parallel testing on a per-port basis.
1304
1305         With these changes I'm going to officially declare this bug dead and
1306         work on remaining polish issues and individual developer complaints.
1307
1308         * Scripts/run-webkit-tests:
1309         (useNewRunWebKitTests):
1310         (platformIsReadyForParallelTesting):
1311
1312 2011-10-28  Eric Seidel  <eric@webkit.org>
1313
1314         NRWT crashes when parsing leaks output due to UTF-8 decoding error
1315         https://bugs.webkit.org/show_bug.cgi?id=71112
1316
1317         Reviewed by Adam Barth.
1318
1319         Use read_binary_file instead of read_text_file and add a test
1320         case with some non-utf8 data to make sure we don't break this in the future.
1321
1322         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1323         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1324
1325 2011-10-28  David Levin  <levin@chromium.org>
1326
1327         watchlist should not CC the bug reporter
1328         https://bugs.webkit.org/show_bug.cgi?id=71079
1329
1330         Reviewed by Adam Barth.
1331
1332         Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)
1333         which remains upchanged and thus verifies that the reporter doesn't get added to the cc line.
1334
1335         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Add the new email in the output.
1336         * Scripts/webkitpy/tool/mocktool.py: Change the reporter and make them one of the people to cc.
1337         * Scripts/webkitpy/tool/steps/applywatchlist.py: Remove the reporter from the cc list.
1338
1339 2011-10-28  Zoltan Horvath  <zoltan@webkit.org>
1340
1341         Add watchlist for QtWebKit2 API and for WK2's Qt specific files.
1342         https://bugs.webkit.org/show_bug.cgi?id=71116
1343
1344         Reviewed by David Levin.
1345
1346         * Scripts/webkitpy/common/config/watchlist:
1347
1348 2011-10-28  Simon Hausmann  <simon.hausmann@nokia.com>
1349
1350         [Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
1351         https://bugs.webkit.org/show_bug.cgi?id=70494
1352
1353         Reviewed by Kenneth Christiansen.
1354
1355         Use QQuick* instead of QSG* as well as QStandardPaths
1356         instead of QDesktopLocation.
1357
1358         * MiniBrowser/qt/BrowserWindow.cpp:
1359         (BrowserWindow::BrowserWindow):
1360         * MiniBrowser/qt/BrowserWindow.h:
1361         * QtTestBrowser/cookiejar.cpp:
1362         (TestBrowserCookieJar::TestBrowserCookieJar):
1363         * QtTestBrowser/launcherwindow.cpp:
1364         (LauncherWindow::setDiskCache):
1365         * WebKitTestRunner/PlatformWebView.h:
1366         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1367         (WTR::WrapperWindow::WrapperWindow):
1368         (WTR::WrapperWindow::handleStatusChanged):
1369
1370 2011-10-28  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1371
1372         [Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser.
1373         https://bugs.webkit.org/show_bug.cgi?id=71106
1374
1375         Reviewed by Simon Hausmann.
1376
1377         Holding Ctrl allows multiple touch points to be held on the screen using
1378         mouse buttons. It would previously only prevent TouchReleased to be sent
1379         and would require another MouseButtonRelease to be sent without holding Ctrl.
1380
1381         This patch makes sure that all held touch points are released when Ctrl
1382         is released if MouseButtonRelease was received.
1383         It also removes the touch QEvent::Type logic since it's currently handled
1384         by QtGui by observing the modified touch points.
1385
1386         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1387         (MiniBrowserApplication::notify):
1388         (MiniBrowserApplication::sendTouchEvent):
1389         * MiniBrowser/qt/MiniBrowserApplication.h:
1390
1391 2011-10-28  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1392
1393         [Qt] MiniBrowser needs a -window-size option
1394         https://bugs.webkit.org/show_bug.cgi?id=70999
1395
1396         Reviewed by Simon Hausmann.
1397
1398         Add an -window-size option useful for testing the viewport handling.
1399         Also clean up the option handling.
1400
1401         * MiniBrowser/qt/BrowserWindow.cpp:
1402         (BrowserWindow::BrowserWindow):
1403         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1404         (MiniBrowserApplication::handleUserOptions):
1405         * MiniBrowser/qt/MiniBrowserApplication.h:
1406         (WindowOptions::WindowOptions):
1407         (WindowOptions::setRequestedWindowSize):
1408         (WindowOptions::requestedWindowSize):
1409         * MiniBrowser/qt/utils.cpp:
1410         (takeOptionValue):
1411         * MiniBrowser/qt/utils.h:
1412
1413 2011-10-28  Jochen Eisinger  <jochen@chromium.org>
1414
1415         Add allowScriptFromSource callback to FrameLoaderClient
1416         https://bugs.webkit.org/show_bug.cgi?id=71013
1417
1418         Reviewed by Darin Fisher.
1419
1420         * DumpRenderTree/chromium/LayoutTestController.cpp:
1421         (LayoutTestController::LayoutTestController):
1422         (LayoutTestController::setScriptsAllowed):
1423         * DumpRenderTree/chromium/LayoutTestController.h:
1424         * DumpRenderTree/chromium/WebPermissions.cpp:
1425         (WebPermissions::allowScriptFromSource):
1426         (WebPermissions::setScriptsAllowed):
1427         (WebPermissions::reset):
1428         * DumpRenderTree/chromium/WebPermissions.h:
1429
1430 2011-10-28  Alexandru Chiculita  <achicu@adobe.com>
1431
1432         Added myself as a committer.
1433
1434         * Scripts/webkitpy/common/config/committers.py:
1435
1436 2011-10-27  Adam Barth  <abarth@webkit.org>
1437
1438         Remove WinCairo from the set of core builders.  WinCairo rarely builds
1439         and is never green.
1440
1441         Rubber-stamped by Eric Seidel.
1442
1443         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1444         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1445
1446 2011-10-27  Yuta Kitamura  <yutak@chromium.org>
1447
1448         WebSocket: Connecting to localhost:8880 takes one second on Windows
1449         https://bugs.webkit.org/show_bug.cgi?id=64788
1450
1451         Reviewed by Dirk Pranke.
1452
1453         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1454         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
1455         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
1456         from timing out on Windows, because this test tries to open a lot of
1457         connections to localhost and each attempt takes one second to fall back from
1458         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
1459
1460 2011-10-27  Adam Barth  <abarth@webkit.org>
1461
1462         Dis-integrate run-bindings-tests with webkitpy
1463         https://bugs.webkit.org/show_bug.cgi?id=71092
1464
1465         Reviewed by Ryosuke Niwa.
1466
1467         These tests aren't really adding any value.
1468
1469         * Scripts/webkitpy/common/config/ports.py:
1470         * Scripts/webkitpy/tool/commands/download_unittest.py:
1471         * Scripts/webkitpy/tool/mocktool.py:
1472         * Scripts/webkitpy/tool/steps/runtests.py:
1473         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1474         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1475
1476 2011-10-27  Eric Seidel  <eric@webkit.org>
1477
1478         REGRESSION (r98639): NRWT crashes when parsing leaks output
1479         https://bugs.webkit.org/show_bug.cgi?id=71087
1480
1481         Unreviewed.  Sadly we have no good way to test logging.
1482
1483         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1484
1485 2011-10-27  David Levin  <levin@chromium.org>
1486
1487         Test expectation errors should include the file name and platform in both the log and exception info.
1488         https://bugs.webkit.org/show_bug.cgi?id=71067
1489
1490         Reviewed by Ojan Vafai.
1491
1492         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1493         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1494
1495 2011-10-27  Eric Seidel  <eric@webkit.org>
1496
1497         new-run-webkit-tests doesn't understand --qt or --gtk
1498         https://bugs.webkit.org/show_bug.cgi?id=63970
1499
1500         Reviewed by Ojan Vafai.
1501
1502         Add support for --qt and --gtk to NRWT.
1503         I also removed some incorrect comments in the option parsing
1504         code (options which we already implement, but said we didn't)
1505         as well as moved --platform parsing out of the "results_options"
1506         section into the top configuration section.
1507
1508         Now run-webkit-tests no longer needs NRWT-specific code for passing
1509         --platform=qt, etc.
1510
1511         * Scripts/run-webkit-tests:
1512         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1513
1514 2011-10-27  Eric Seidel  <eric@webkit.org>
1515
1516         REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
1517         https://bugs.webkit.org/show_bug.cgi?id=66227
1518
1519         Reviewed by Adam Roben.
1520
1521         I believe this should fix the bug.
1522
1523         * Scripts/run-webkit-tests: make NRWT default for --leaks
1524         * Scripts/webkitpy/layout_tests/port/leakdetector.py:
1525         (LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
1526         (LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
1527         (LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.
1528         * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
1529         Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.
1530         * Scripts/webkitpy/layout_tests/port/mac.py:
1531         Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.
1532
1533 2011-10-27  Stephen Chenney  <schenney@chromium.org>
1534
1535         [Chromium] Need setPrinting
1536         https://bugs.webkit.org/show_bug.cgi?id=46152
1537
1538         Reviewed by Hajime Morita.
1539
1540         * DumpRenderTree/chromium/LayoutTestController.cpp:
1541         (LayoutTestController::LayoutTestController): Added logic for handling setPrinting.
1542         (LayoutTestController::reset): Clearing flags for setPrinting.
1543         (LayoutTestController::setPrinting): Set flags for setPrinting.
1544         * DumpRenderTree/chromium/LayoutTestController.h:
1545         (LayoutTestController::setIsPrinting): Added the setPrinting methods and flags.
1546         (LayoutTestController::isPrinting): Method to return the setPrinting status.
1547         * DumpRenderTree/chromium/TestShell.cpp:
1548         (dumpFramesAsPrintedText): A method for creating a text dump in printed layout.
1549         (TestShell::dump): Modified to dump setPrinting-specific output.
1550         * DumpRenderTree/chromium/WebViewHost.cpp:
1551         (WebViewHost::paintPagesWithBoundaries): Handling for pixel tests when setPrinting is
1552         active.
1553         * DumpRenderTree/chromium/WebViewHost.h: Prototype for paintPagesWithBoundaries.
1554
1555 2011-10-27  Sam Weinig  <sam@webkit.org>
1556
1557         Add allowsPlugIns property to WKBrowsingContextGroup
1558         https://bugs.webkit.org/show_bug.cgi?id=70987
1559
1560         Reviewed by Anders Carlsson.
1561
1562         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
1563         Add basic test for WKBrowsingContextGroup.allowsPlugIns.
1564
1565 2011-10-27  Adam Roben  <aroben@apple.com>
1566
1567         Test WKBundlePageGetBackingScaleFactor
1568
1569         Test for <http://webkit.org/b/71025> <rdar://problem/10355037> REGRESSION (r97191): Clients
1570         can't reliably determine the scale factor of snapshots returned via
1571         WKBundlePageCreateSnapshot* API
1572
1573         Reviewed by Sam Weinig.
1574
1575         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
1576
1577         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.
1578         (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
1579         (TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
1580         (TestWebKitAPI::createWindow): Conjure up a window.
1581         (TestWebKitAPI::TEST): Ask the injected bundle code to call the new
1582         WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
1583         factors and when using a custom scale factor, and check that we get those same scale factors
1584         back.
1585
1586         * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.
1587         (TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
1588         members.
1589         (TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
1590         (TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
1591         from the page using the new API and send it back.
1592
1593 2011-10-27  Balazs Kelemen  <kbalazs@webkit.org>
1594
1595         [Qt][WK2] MiniBrowser crashes when started with 0 arguments
1596
1597         Rubber-stamped by Simon Hausmann.
1598
1599         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1600         (MiniBrowserApplication::handleUserOptions):
1601         Fix typo error.
1602
1603 2011-10-27  Takashi Toyoshima  <toyoshim@chromium.org>
1604
1605         [WebSocket] update pywebsocket to 0.7.
1606         https://bugs.webkit.org/show_bug.cgi?id=70992
1607
1608         Reviewed by Kent Tamura.
1609
1610         pywebsocket 0.7 fixed the bug on dual stack support on OS X.
1611
1612         * Scripts/webkitpy/thirdparty/__init__.py:
1613
1614 2011-10-27  Elliot Poger  <epoger@google.com>
1615
1616         make lion observe MAC lines in test_expectations.txt
1617         https://bugs.webkit.org/show_bug.cgi?id=70941
1618
1619         Reviewed by Ojan Vafai.
1620
1621         * Scripts/webkitpy/layout_tests/port/chromium.py:
1622         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1623
1624 2011-10-27  John Knottenbelt  <jknotten@chromium.org>
1625
1626         [Chromium] Allow DRT to be built without notifications enabled.
1627         https://bugs.webkit.org/show_bug.cgi?id=70919
1628
1629         Reviewed by Tony Gentilcore.
1630
1631         * DumpRenderTree/chromium/LayoutTestController.cpp:
1632         (LayoutTestController::grantDesktopNotificationPermission):
1633         (LayoutTestController::simulateDesktopNotificationClick):
1634         * DumpRenderTree/chromium/NotificationPresenter.cpp:
1635         * DumpRenderTree/chromium/TestShell.cpp:
1636         (TestShell::TestShell):
1637         (TestShell::resetTestController):
1638
1639 2011-10-21  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
1640
1641         [Qt] Improve command line arguments handling for MiniBrowser.
1642         https://bugs.webkit.org/show_bug.cgi?id=70616
1643
1644         Reviewed by Kenneth Rohde Christiansen.
1645
1646         - Use two dashes for word arguments.
1647         - Return with an error when an unsupported argument is given.
1648         - Allow the URL to be placed before option arguments.
1649
1650         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1651         (printHelp):
1652         (MiniBrowserApplication::handleUserOptions):
1653         * MiniBrowser/qt/utils.cpp:
1654         (takeOptionFlag):
1655         (takeOptionValue):
1656         * MiniBrowser/qt/utils.h:
1657
1658 2011-10-27  Csaba Osztrogonác  <ossy@webkit.org>
1659
1660         [Qt] NRWT doesn't work on qt-mac platform
1661         https://bugs.webkit.org/show_bug.cgi?id=64445
1662
1663         Reviewed by Adam Barth.
1664
1665         * Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.
1666         (useNewRunWebKitTests):
1667         * Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.
1668
1669 2011-10-26  Sam Weinig  <sam@webkit.org>
1670
1671         Add initial setting to WKBrowsingContextGroup
1672         https://bugs.webkit.org/show_bug.cgi?id=70942
1673
1674         Reviewed by Anders Carlsson.
1675
1676         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1677         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.
1678         Add basic test that setting the javaScriptEnabled setting takes. It is not
1679         possible to test its effect quite yet.
1680
1681 2011-10-26  Alejandro G. Castro  <alex@igalia.com>
1682
1683         [GTK] [WK2] Add WebKit2 distcheck support
1684         https://bugs.webkit.org/show_bug.cgi?id=70933
1685
1686         Reviewed by Martin Robinson.
1687
1688         * WebKitTestRunner/GNUmakefile.am: Add missing files to the
1689         sources and EXTRA_DIST.
1690
1691 2011-10-26  Simon Hausmann  <simon.hausmann@nokia.com>
1692
1693         [Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.
1694
1695         Reviewed by Tor Arne Vestbø.
1696
1697         We're using QScroller since r98460, which requires QWidget/QApplication. So
1698         use QApplication and QtWidgets for the time being.
1699
1700         * MiniBrowser/qt/MiniBrowser.pro:
1701         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1702         (MiniBrowserApplication::MiniBrowserApplication):
1703         (MiniBrowserApplication::notify):
1704         * MiniBrowser/qt/MiniBrowserApplication.h:
1705
1706 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
1707
1708         [Qt][WK2] Rewrite MiniBrowser in QML
1709         https://bugs.webkit.org/show_bug.cgi?id=70315
1710
1711         Add the first QML based implementation of MiniBrowser.
1712
1713         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
1714                  Zeno Albisser <zeno.albisser@nokia.com>
1715
1716         Reviewed by Tor Arne Vestbø.
1717
1718         * MiniBrowser/qt/BrowserWindow.cpp:
1719         (BrowserWindow::BrowserWindow):
1720         (BrowserWindow::webView):
1721         (BrowserWindow::load):
1722         (BrowserWindow::keyPressEvent):
1723         (BrowserWindow::~BrowserWindow):
1724         * MiniBrowser/qt/BrowserWindow.h:
1725         * MiniBrowser/qt/MiniBrowser.pro:
1726         * MiniBrowser/qt/MiniBrowser.qrc:
1727         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1728         (MiniBrowserApplication::MiniBrowserApplication):
1729         (MiniBrowserApplication::handleUserOptions):
1730         * MiniBrowser/qt/MiniBrowserApplication.h:
1731         (WindowOptions::WindowOptions):
1732         * MiniBrowser/qt/UrlLoader.cpp:
1733         (UrlLoader::UrlLoader):
1734         * MiniBrowser/qt/icons/next.png: Added.
1735         * MiniBrowser/qt/icons/previous.png: Added.
1736         * MiniBrowser/qt/icons/refresh.png: Added.
1737         * MiniBrowser/qt/icons/stop.png: Added.
1738         * MiniBrowser/qt/main.cpp:
1739         (main):
1740         * MiniBrowser/qt/qml/BrowserWindow.qml: Added.
1741
1742 2011-10-26  Zeno Albisser  <zeno.albisser@nokia.com>
1743
1744         [Qt][WK2] Remove QtWidgets dependency in MiniBrowser
1745         https://bugs.webkit.org/show_bug.cgi?id=70529
1746
1747         Remove obsolete code for a new QML based implementation
1748         of MiniBrowser.
1749         Change BrowserWindow to derive from QSGView instead of
1750         QMainWindow. QSGView is used as a top level window that
1751         provides the container for placing QML content.
1752         Make MiniBrowserApplication derive from QGuiApplication
1753         instead of QApplication.
1754
1755         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
1756                  Zeno Albisser <zeno.albisser@nokia.com>
1757
1758         Reviewed by Simon Hausmann.
1759
1760         * MiniBrowser/qt/BrowserView.cpp: Removed.
1761         * MiniBrowser/qt/BrowserView.h: Removed.
1762         * MiniBrowser/qt/BrowserWindow.cpp:
1763         (BrowserWindow::BrowserWindow):
1764         (BrowserWindow::load):
1765         (BrowserWindow::screenshot):
1766         (BrowserWindow::loadURLListFromFile):
1767         (BrowserWindow::updateUserAgentList):
1768         (BrowserWindow::~BrowserWindow):
1769         * MiniBrowser/qt/BrowserWindow.h:
1770         * MiniBrowser/qt/MiniBrowser.pro:
1771         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1772         (MiniBrowserApplication::MiniBrowserApplication):
1773         (MiniBrowserApplication::notify):
1774         * MiniBrowser/qt/MiniBrowserApplication.h:
1775         * MiniBrowser/qt/UrlLoader.cpp:
1776         (UrlLoader::UrlLoader):
1777         * MiniBrowser/qt/main.cpp:
1778
1779 2011-10-25  Zeno Albisser  <zeno.albisser@nokia.com>
1780
1781         [Qt][WK2] Remove QAction from MiniBrowser
1782         https://bugs.webkit.org/show_bug.cgi?id=70525
1783
1784         In order to rewrite MiniBrowser in QML we need a suitable
1785         mechanism for triggering navigation actions.
1786         Due to the QtWidgets dependency of QAction the current
1787         solution is not suitable anymore. Therefore we introduce
1788         invokable methods and export properties in QWebNavigationController.
1789
1790         Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
1791                  Zeno Albisser <zeno.albisser@nokia.com>
1792
1793         Reviewed by Simon Hausmann.
1794
1795         * MiniBrowser/qt/BrowserView.cpp:
1796         * MiniBrowser/qt/BrowserView.h:
1797         * MiniBrowser/qt/BrowserWindow.cpp:
1798         (BrowserWindow::BrowserWindow):
1799
1800 2011-10-26  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1801
1802         [EFL] Unregister viewport,changed signal in EWebLauncher.
1803         https://bugs.webkit.org/show_bug.cgi?id=70478
1804
1805         Reviewed by Eric Seidel.
1806
1807         'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
1808         However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
1809         doesn't support proper DPI value though viewport is using DPI value to compute layout values.
1810         This signal is for mobile device.
1811
1812         * EWebLauncher/main.c:
1813         (browserCreate):
1814
1815 2011-10-25  Anders Carlsson  <andersca@apple.com>
1816
1817         Plug-ins have no way to find out when the device scale factor changes
1818         https://bugs.webkit.org/show_bug.cgi?id=67226
1819         <rdar://problem/10048276>
1820
1821         Reviewed by Sam Weinig.
1822
1823         Keep a cached copy of the contents scale and update it when it changes.
1824
1825         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:
1826         (ContentsScaleFactor::ContentsScaleFactor):
1827         (ContentsScaleFactor::cachedContentsScaleFactor):
1828         (ContentsScaleFactor::ScriptableObject::hasProperty):
1829         (ContentsScaleFactor::ScriptableObject::getProperty):
1830         (ContentsScaleFactor::NPP_New):
1831         (ContentsScaleFactor::NPP_SetValue):
1832
1833 2011-10-25  Sam Weinig  <sam@webkit.org>
1834
1835         Add WKBrowsingContextLoadDelegateTest test for a failed load
1836         https://bugs.webkit.org/show_bug.cgi?id=70859
1837
1838         Reviewed by Anders Carlsson.
1839
1840         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
1841         (TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).
1842
1843         (-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
1844         Test that we are getting the correct NSError code and domain.
1845
1846 2011-10-25  Erik Arvidsson  <arv@chromium.org>
1847
1848         JS Test Harness: Make successfullyParsed optional
1849         https://bugs.webkit.org/show_bug.cgi?id=70784
1850
1851         Reviewed by Ojan Vafai.
1852
1853         * Scripts/make-new-script-test:
1854         (writeTestFile): Update the template for script tests.
1855
1856 2011-10-25  Anders Carlsson  <andersca@apple.com>
1857
1858         Plug-ins have to use JavaScript to find out the current device scale factor
1859         https://bugs.webkit.org/show_bug.cgi?id=67225
1860         <rdar://problem/10048258>
1861
1862         Reviewed by Darin Adler.
1863
1864         Add a plug-in test for getting the contents scale factor.
1865
1866         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1867         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.
1868         (ContentsScaleFactor::ContentsScaleFactor):
1869         (ContentsScaleFactor::contentsScaleFactor):
1870         (ContentsScaleFactor::ScriptableObject::hasProperty):
1871         (ContentsScaleFactor::ScriptableObject::getProperty):
1872         (ContentsScaleFactor::ScriptableObject::pluginTest):
1873         (ContentsScaleFactor::NPP_GetValue):
1874
1875 2011-10-25  Sam Weinig  <sam@webkit.org>
1876
1877         Flesh out WKBrowsingContextLoadDelegate a bit
1878         https://bugs.webkit.org/show_bug.cgi?id=70846
1879
1880         Reviewed by Anders Carlsson.
1881
1882         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1883         * TestWebKitAPI/Tests/WebKit2ObjC: Added.
1884         * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.
1885         (WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
1886         (WKBrowsingContextLoadDelegateTest::SetUp):
1887         (WKBrowsingContextLoadDelegateTest::TearDown):
1888         (-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
1889         (TEST_F):
1890         Add basic testing for WKBrowsingContextLoadDelegate.
1891
1892 2011-10-25  Alexey Proskuryakov  <ap@apple.com>
1893
1894         make-script-test-wrappers should not look outside fast/js
1895         https://bugs.webkit.org/show_bug.cgi?id=66357
1896
1897         Reviewed by Maciej Stachowiak.
1898
1899         * Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support
1900         fast/js.
1901
1902 2011-10-25  Adam Barth  <abarth@webkit.org>
1903
1904         Add a --make option to update-webkit to engage the Makefile-based build system
1905         https://bugs.webkit.org/show_bug.cgi?id=70847
1906
1907         Reviewed by Dimitri Glazkov.
1908
1909         I can never remember what crazy environment variables I'm supposed to
1910         set to tell GYP what to do.
1911
1912         * Scripts/update-webkit:
1913
1914 2011-10-25  Raphael Kubo da Costa  <kubo@profusion.mobi>
1915
1916         [EFL] DRT: Force layout when sending events.
1917         https://bugs.webkit.org/show_bug.cgi?id=70357
1918
1919         Reviewed by Antonio Gomes.
1920
1921         Some tests such as editing/input/page-up-down-scrolls.html rely on the
1922         scrollbars being properly set up during the onload events.
1923         Document::implicitClose(), however, dispatches the onload events before
1924         calling FrameView::layout(), so these tests usually fail.
1925
1926         We now do the same as the GTK+ and Chromium ports and manually force the
1927         layout when dispatching events.
1928
1929         * DumpRenderTree/efl/EventSender.cpp:
1930         (sendMouseEvent):
1931         (keyDownCallback):
1932
1933 2011-10-25  Daniel Bates  <dbates@rim.com>
1934
1935         build-webkit --clean should only clean build directory for CMake-based ports
1936         https://bugs.webkit.org/show_bug.cgi?id=70834
1937
1938         Reviewed by Antonio Gomes.
1939
1940         Currently build-webkit --clean both cleans the build directory and builds WebKit for
1941         CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
1942         as per its description in the usage message of build-webkit.
1943
1944         * Scripts/webkitdirs.pm:
1945         (buildCMakeProjectOrExit):
1946
1947 2011-10-25  Anna Cavender  <annacc@chromium.org>
1948
1949         Enable running of track layout tests for Chromium
1950         https://bugs.webkit.org/show_bug.cgi?id=70803
1951
1952         Reviewed by Adam Barth.
1953
1954         Make DumpRenderTree/TestShell always run with track enabled
1955         (equivalent of --enable-video-track).
1956
1957         * DumpRenderTree/chromium/TestShell.cpp:
1958         (TestShell::TestShell):
1959
1960 2011-10-25  Vamshikrishna Yellenki  <vamshi@motorola.com>
1961
1962         [WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
1963         https://bugs.webkit.org/show_bug.cgi?id=70603
1964
1965         Reviewed by Gustavo Noronha Silva.
1966
1967         * MiniBrowser/gtk/BrowserWindow.c:
1968         (focus):
1969         (unFocus):
1970         (browserWindowUIClientInit):
1971
1972 2011-10-25  Dan Bernstein  <mitz@apple.com>
1973
1974         <rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none
1975
1976         Reviewed by Adam Roben.
1977
1978         * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
1979         (TestWebKitAPI::TEST):
1980
1981 2011-10-25  Eric Seidel  <eric@webkit.org>
1982
1983         WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
1984         https://bugs.webkit.org/show_bug.cgi?id=64471
1985
1986         Reviewed by Adam Roben.
1987
1988         Speculative fix.
1989
1990         * Scripts/webkitpy/layout_tests/port/win.py:
1991         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
1992
1993 2011-10-24  Mikhail Naganov  <mnaganov@chromium.org>
1994
1995         Fix bug summary when rolling Chromium DEPS to LKGR.
1996         https://bugs.webkit.org/show_bug.cgi?id=69917
1997
1998         Reviewed by Adam Barth.
1999
2000         * Scripts/webkitpy/tool/bot/irc_command.py:
2001         * Scripts/webkitpy/tool/bot/sheriff.py:
2002         * Scripts/webkitpy/tool/commands/roll.py:
2003         * Scripts/webkitpy/tool/commands/roll_unittest.py:
2004
2005 2011-10-24  Ivan Briano  <ivan@profusion.mobi>
2006
2007         [EFL] Build fix. Add include path to find npapi.h
2008         https://bugs.webkit.org/show_bug.cgi?id=70730
2009
2010         Unreviewed build fix.
2011
2012         * DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h
2013
2014 2011-10-24  Eric Seidel  <eric@webkit.org>
2015
2016         Plugin tests are failing after switching WK2 to NRWT
2017         https://bugs.webkit.org/show_bug.cgi?id=70760
2018
2019         Reviewed by Simon Fraser.
2020
2021         Perpetuate this horrible hack.
2022
2023         * Scripts/webkitpy/layout_tests/port/webkit.py:
2024
2025 2011-10-24  Eric Seidel  <eric@webkit.org>
2026
2027         NRWT doesn't support ORWT's --root option, but should
2028         https://bugs.webkit.org/show_bug.cgi?id=70416
2029
2030         Reviewed by Dirk Pranke.
2031
2032         Add support for ORWT's --root option which is used for
2033         running tests with a nightly build of WebKit.
2034
2035         * Scripts/old-run-webkit-tests:
2036         * Scripts/webkitpy/layout_tests/port/base.py:
2037          - webkit_build_path was never called by any code, removed.
2038         * Scripts/webkitpy/layout_tests/port/webkit.py:
2039         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2040
2041 2011-10-24  David Levin  <levin@chromium.org>
2042
2043         check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
2044         https://bugs.webkit.org/show_bug.cgi?id=70747
2045
2046         Reviewed by Tony Chang.
2047
2048         * Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
2049         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.
2050
2051 2011-10-24  Balazs Kelemen  <kbalazs@webkit.org>
2052
2053         [Qt][WK2] Crash when running pixel tests
2054         https://bugs.webkit.org/show_bug.cgi?id=70725
2055
2056         Reviewed by Chang Shu.
2057
2058         * WebKitTestRunner/qt/TestInvocationQt.cpp:
2059         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2060
2061 2011-10-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2062
2063         [GTK] Remove g_thread_init() calls
2064         https://bugs.webkit.org/show_bug.cgi?id=70717
2065
2066         Reviewed by Xan Lopez.
2067
2068         With newer glib it's not needed anymore and with previous versions
2069         it was already called by g_type_init().
2070
2071         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2072         (main):
2073         * GtkLauncher/main.c:
2074         (main):
2075         * MiniBrowser/gtk/main.c:
2076         (main):
2077
2078 2011-10-24  Alejandro G. Castro  <alex@igalia.com>
2079
2080         [WK2] [GTK] WebKitTestRunner crashes with heap corruption
2081         https://bugs.webkit.org/show_bug.cgi?id=69403
2082
2083         We did not added autotoolsconfig.h to the config.h file and we
2084         were adding Platform.h without the config.h in the
2085         WebKitTestRunnerPrefix.h. Added the autotoolsconfig.h include in
2086         the Prefix file.
2087
2088         Reviewed by Martin Robinson.
2089
2090         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2091
2092 2011-10-23  Tomasz Morawski  <t.morawski@samsung.com>
2093
2094         [EFL] Remove unused code from EWebLauncher
2095         https://bugs.webkit.org/show_bug.cgi?id=70590
2096
2097         Reviewed by Andreas Kling.
2098
2099         Removed unused function on_closeWindow from EWebLauncher
2100
2101         * EWebLauncher/main.c:
2102
2103 2011-10-23  Luke Macpherson   <macpherson@chromium.org>
2104
2105         Add watchlist for WebCore/css and put myself on it.
2106         https://bugs.webkit.org/show_bug.cgi?id=70701
2107
2108         Reviewed by Adam Barth.
2109
2110         * Scripts/webkitpy/common/config/watchlist:
2111         Add watchlist for WebCore/css and put myself on it.
2112
2113 2011-10-23  Kaustubh Atrawalkar  <kaustubh@motorola.com>
2114
2115         [GTK] Implement KeyDown function for WebKit2 EventSender.
2116         https://bugs.webkit.org/show_bug.cgi?id=69410
2117
2118         Reviewed by Martin Robinson.
2119
2120         Implement the KeyDown function on Gtk platform.
2121
2122         * WebKitTestRunner/GNUmakefile.am:
2123         * WebKitTestRunner/TestController.cpp:
2124         (WTR::TestController::TestController):
2125         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2126         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.
2127         (WTR::EventSenderProxy::EventSenderProxy):
2128         (WTR::dispatchEvent):
2129         (WTR::getModifiers):
2130         (WTR::getGDKKeySymForKeyRef):
2131         (WTR::EventSenderProxy::keyDown):
2132
2133 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
2134
2135         [WK2][GTK] run-launcher script fails after testing WK2 tests
2136         https://bugs.webkit.org/show_bug.cgi?id=70676
2137
2138         Reviewed by Andreas Kling.
2139
2140         Pass the '-2' flag instead of '--webkit-test-runner' when executing
2141         run-launcher script after testing with WebKitTestRunner.
2142
2143         * Scripts/webkitpy/layout_tests/port/gtk.py:
2144
2145 2011-10-22  Zan Dobersek  <zandobersek@gmail.com>
2146
2147         [WK2][GTK] Missing env variables cause WKTR to crash
2148         https://bugs.webkit.org/show_bug.cgi?id=70674
2149
2150         Reviewed by Martin Robinson.
2151
2152         Set two environment variables that the Gtk's port of WebKitTestRunner
2153         depends on and crashes if they're not explicitly set by the user.
2154         Also modify the setting of the WEBKIT_INSPECTOR_PATH variable so it
2155         properly uses the _build_path method.
2156
2157         * Scripts/webkitpy/layout_tests/port/gtk.py: Set
2158         TEST_RUNNER_INJECTED_BUNDLE_FILENAME and TEST_RUNNER_TEST_PLUGIN_PATH
2159         environment variables.
2160
2161 2011-10-21  Filip Pizlo  <fpizlo@apple.com>
2162
2163         Bencher script doesn't measure GC times accurately
2164         https://bugs.webkit.org/show_bug.cgi?id=70588
2165
2166         Reviewed by Geoff Garen.
2167
2168         Added two new options which allow different ways of measuring GC times:
2169
2170         --measure-gc, which omits calls to gc() between benchmark invocations.
2171         This option takes an optional argument, which is the name of the
2172         VM in which to enable this feature. This allows comparing a single VM
2173         against itself, with and without GC.
2174
2175         --rerun <N>, which causes each sample measurement to include N invocations
2176         which do not have gc() calls between them. The default is N = 1, which
2177         results in the same behavior as before.
2178
2179         You can use either --measure-gc or --rerun <N> for N > 1 (preferably
2180         N >= 3) to get more of a contribution from GC to the measured times.
2181         --rerun results in tighter confidence intervals than --measure-gc, since
2182         it amortizes GC effects in each sample, while with --measure-gc some
2183         samples will see GC and some won't leading to a higher standard devation
2184         and thus requiring more samples to reduce confidence intervals to
2185         managable levels.
2186
2187         * Scripts/bencher:
2188
2189 2011-10-21  Sam Weinig  <sam@webkit.org>
2190
2191         Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
2192         https://bugs.webkit.org/show_bug.cgi?id=70653
2193
2194         Reviewed by Simon Fraser.
2195
2196         * MiniBrowser/mac/AppDelegate.h:
2197         * MiniBrowser/mac/AppDelegate.m:
2198         (-[BrowserAppDelegate init]):
2199         (-[BrowserAppDelegate newWindow:]):
2200         (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
2201         * MiniBrowser/mac/BrowserWindowController.h:
2202         * MiniBrowser/mac/BrowserWindowController.m:
2203         (-[BrowserWindowController initWithContext:pageGroup:]):
2204         (-[BrowserWindowController windowWillClose:]):
2205         (createNewPage):
2206         (-[BrowserWindowController awakeFromNib]):
2207         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2208         (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
2209         Update testing code to pass a PageGroup as necessary.
2210
2211 2011-10-21  Leandro Pereira  <leandro@profusion.mobi>
2212
2213         webkitpy: Teach NRWT about the EFL port
2214         https://bugs.webkit.org/show_bug.cgi?id=70637
2215
2216         Allows using ``efl'' as a platform when executing NRWT.
2217
2218         Reviewed by Eric Seidel.
2219
2220         * Scripts/webkitpy/layout_tests/port/efl.py: Added.
2221         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Added.
2222         * Scripts/webkitpy/layout_tests/port/factory.py: Adjust factory to make EflPort objects
2223         when using PortFactory.get(port_name='efl').
2224
2225 2011-10-21  Devdatta Deshpande  <pwjd73@motorola.com>
2226
2227         [Gtk] mousemove event always has metaKey == true
2228         https://bugs.webkit.org/show_bug.cgi?id=35299
2229
2230         Reviewed by Martin Robinson.
2231
2232         * DumpRenderTree/gtk/EventSender.cpp:
2233         (gdkModifierFromJSValue): GDK_META_MASK is used to represent metaKey for platform GTK mouse and
2234         keyboard events. So making it in sync with WebCore files.
2235         (mouseMoveToCallback): Sending modifier keys state for mouse move event.
2236
2237 2011-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2238
2239         watchlist: Add a new entry for WebKit2 GTK+ public API
2240         https://bugs.webkit.org/show_bug.cgi?id=70601
2241
2242         Reviewed by Philippe Normand.
2243
2244         Subscribe myself to WebKit2 GTK+ API patches. Also add a message
2245         for patches that might include new API that points to the WebKit2
2246         GTK+ API guidelines.
2247
2248         * Scripts/webkitpy/common/config/watchlist:
2249
2250 2011-10-21  Simon Hausmann  <simon.hausmann@nokia.com>
2251
2252         Remove QtScript source code from WebKit.
2253         https://bugs.webkit.org/show_bug.cgi?id=64088
2254
2255         Reviewed by Tor Arne Vestbø.
2256
2257         Removed dead code that isn't developed anymore.
2258
2259         * Scripts/webkitpy/style/checker_unittest.py:
2260
2261 2011-10-20  Eric Seidel  <eric@webkit.org>
2262
2263         Switch webkit2 bot to NRWT
2264         https://bugs.webkit.org/show_bug.cgi?id=56729
2265
2266         Reviewed by Adam Barth.
2267
2268         Move the WK2 bot to using NRWT instead of ORWT, as announced on webkit-dev:
2269         https://lists.webkit.org/pipermail/webkit-dev/2011-October/018337.html
2270
2271         * Scripts/run-webkit-tests:
2272         (runningOnBuildBot):
2273         (useNewRunWebKitTests):
2274
2275 2011-10-20  Eric Seidel  <eric@webkit.org>
2276
2277         NRWT is asserting on DRT due to lack of newline when processing line from DumpRenderTree
2278         https://bugs.webkit.org/show_bug.cgi?id=70585
2279
2280         Reviewed by Adam Barth.
2281
2282         This really should be an assert, as this inidicates a programming error in either DRT or NRWT.
2283         However since DRT was functioning fine before in Qt, we'll make this an error log for now
2284         and once we find the root cause flip this back to an assert.
2285
2286         * Scripts/webkitpy/layout_tests/port/webkit.py:
2287
2288 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
2289
2290         Unreviewed, rolling out r98064.
2291         http://trac.webkit.org/changeset/98064
2292         https://bugs.webkit.org/show_bug.cgi?id=64788
2293
2294         Broke Mac bots.
2295
2296         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2297
2298 2011-10-20  Yuta Kitamura  <yutak@chromium.org>
2299
2300         WebSocket: Connecting to localhost:8880 takes one second on Windows
2301         https://bugs.webkit.org/show_bug.cgi?id=64788
2302
2303         Reviewed by Dirk Pranke.
2304
2305         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
2306         Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
2307         IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
2308         from timing out on Windows, because this test tries to open a lot of
2309         connections to localhost and each attempt takes one second to fall back from
2310         IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
2311
2312 2011-10-20  Ryosuke Niwa  <rniwa@webkit.org>
2313
2314         nrwt: newly generated results are put in cross-platform directory
2315         https://bugs.webkit.org/show_bug.cgi?id=68931
2316
2317         Reviewed by Dirk Pranke.
2318
2319         The bug was caused by SingleTestRunner._add_missing_baselines's always calling _save_baseline_data
2320         with generate_new_baseline set to False. Fixed the bug by always passing True when .png file is missing
2321         (because png images are typically different on each platform), and passing True when .txt file is missing
2322         and the actual result's first line matches the regular expression "layer at \(\d+,\d+\) size \d+x\d+".
2323
2324         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2325         * Scripts/webkitpy/layout_tests/port/test.py:
2326         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Changed the expectation
2327         and added a test case.
2328
2329 2011-10-20  Kent Tamura  <tkent@chromium.org>
2330
2331         Unreviewed. Adding myself to watchlist.
2332
2333         * Scripts/webkitpy/common/config/watchlist:
2334         Add "ChromiumDumpRenderTree" and "Forms" definitions, and cc them to me.
2335
2336 2011-10-20  Nico Weber  <thakis@chromium.org>
2337
2338         [chromium/mac] Add support for building with make
2339         https://bugs.webkit.org/show_bug.cgi?id=70455
2340
2341         Reviewed by Adam Barth.
2342
2343         Depends on http://codereview.chromium.org/8352029/
2344         `GYP_GENERATORS=make Tools/Scripts/update-webkit --chromium` will
2345         create a toplevel Makefile.chromium.
2346
2347         If that file exists and is newer than Source/WebKit/chromium/WebKit.xcodeproj,
2348         `Tools/Scripts/build-webkit --chromium` will build with make instead of
2349         xcodebuild.
2350
2351         Also let nrwt use a binary from out/ if it exists.
2352
2353         * Scripts/webkitdirs.pm:
2354         (determineBaseProductDir):
2355         (isChromiumMacMake):
2356         (determineIsChromiumMacMake):
2357         (buildChromium):
2358
2359 2011-10-20  Eric Seidel  <eric@webkit.org>
2360
2361         Possible REGRESSION(97879): NRWT fails when DumpRenderTree crashes
2362         https://bugs.webkit.org/show_bug.cgi?id=70524
2363
2364         Reviewed by Adam Barth.
2365
2366         This is a speculative fix, since I do not use a platform
2367         which outputs crashlogs over stderr.
2368
2369         * Scripts/webkitpy/layout_tests/port/server_process.py:
2370         * Scripts/webkitpy/layout_tests/port/webkit.py:
2371
2372 2011-10-20  Eric Seidel  <eric@webkit.org>
2373
2374         REGRESSION(97879): Pixel tests no longer work with NRWT on Mac
2375         https://bugs.webkit.org/show_bug.cgi?id=70492
2376
2377         Reviewed by Adam Barth.
2378
2379         The bug turned out to be that I was assuming the block.content
2380         would be empty before the binary content following Content-Length
2381         was read inside _read_block.  Turns out its not, due to extra newlines
2382         and "ExpectedHash" header.
2383
2384         In the process of trying to figure out what was going wrong I ended up
2385         cleaning up our newline usage in DumpRenderTree a little.  Moved
2386         two error messages from stdout to stderr, and fixed a little code indent/whitespace.
2387
2388         I also fixed ServerProcess to use "deadline" everywhere instead of timeout
2389         per Adam's request in the original bug.
2390
2391         * DumpRenderTree/PixelDumpSupport.cpp:
2392         (dumpWebViewAsPixelsAndCompareWithExpected):
2393         * DumpRenderTree/cg/ImageDiffCG.cpp:
2394         (main):
2395         * DumpRenderTree/mac/DumpRenderTree.mm:
2396         (dump):
2397         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2398         (restoreMainDisplayColorProfile):
2399         (setupMainDisplayColorProfile):
2400         * Scripts/webkitpy/layout_tests/port/server_process.py:
2401         * Scripts/webkitpy/layout_tests/port/webkit.py:
2402         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
2403
2404 2011-10-20  Tony Chang  <tony@chromium.org>
2405
2406         [chromium] Remove <stdint.h> from ImageDiff and use
2407         unsigned int instead of uint32_t.
2408
2409         Unreviewed, fixing the chromium win build.
2410
2411         * DumpRenderTree/chromium/ImageDiff.cpp:
2412         (Image::pixelAt):
2413         (Image::setPixelAt):
2414         (maxOf3):
2415         (getRedComponent):
2416         (getGreenComponent):
2417         (getBlueComponent):
2418         (weightedPercentageDifferent):
2419         (createImageDiff):
2420
2421 2011-10-20  Hao Zheng  <zhenghao@chromium.org>
2422
2423         [Chromium] Reduce dependencies of ImageDiff to compile it for Android.
2424         https://bugs.webkit.org/show_bug.cgi?id=69997
2425
2426         Reviewed by Tony Chang.
2427
2428         This change is required to make ImageDiff for Android, and can benefit
2429         other platforms, too. On Android, most targets are built as
2430         toolsets:target. while ImageDiff needs to be built as toolsets:host.
2431         Currently, building the standalone target of ImageDiff depends on about
2432         85 other targets (try  make ImageDiff'), which is inefficient. After the
2433         change, ImageDiff only depends on webkit_support_gfx, which in turn
2434         depends on libpng and zlib.
2435
2436         * DumpRenderTree/chromium/ImageDiff.cpp:
2437         (main):
2438
2439 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
2440
2441         [EFL] Unreviewed DumpRenderTree build fix.
2442
2443         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
2444         (LayoutTestController::addChromeInputField): Add stub.
2445         (LayoutTestController::removeChromeInputField): Ditto.
2446         (LayoutTestController::focusWebView): Ditto.
2447         (LayoutTestController::setBackingScaleFactor): Ditto.
2448
2449 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
2450
2451         [EFL] Plug ImageDiff/DumpRenderTree on CMake build system
2452         https://bugs.webkit.org/show_bug.cgi?id=70142
2453
2454         Reviewed by Gustavo Noronha Silva.
2455
2456         * CMakeListsEfl.txt: Include DRT CMakeLists.
2457         * DumpRenderTree/efl/CMakeLists.txt: Added.
2458
2459 2011-10-20  Philippe Normand  <pnormand@igalia.com>
2460
2461         [style] Allow usage of NULL in gst_*
2462         https://bugs.webkit.org/show_bug.cgi?id=70498
2463
2464         Reviewed by David Levin.
2465
2466         * Scripts/webkitpy/style/checkers/cpp.py: Simplified the detection
2467         of gst_ calls. Now just ignore NULL in all of them.
2468         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Test for above change.
2469
2470 2011-10-20  Leandro Pereira  <leandro@profusion.mobi>
2471
2472         [EFL] Unreviewed. Build fix after r97043.
2473
2474         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2475         (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Use ewk_view_scale_set() instead of ewk_view_page_scale().
2476         * DumpRenderTree/efl/EventSender.cpp:
2477         (scalePageByCallback): Ditto.
2478
2479 2011-10-20  Philippe Normand  <pnormand@igalia.com>
2480
2481         Unreviewed. Adding myself to watchlists.
2482         * Scripts/webkitpy/common/config/watchlist:
2483
2484 2011-10-19  Eric Seidel  <eric@webkit.org>
2485
2486         Reviewed by Adam Barth.
2487
2488         Teach new-run-webkit-tests about #CRASHED and #CRASHED - WebProcess
2489         https://bugs.webkit.org/show_bug.cgi?id=63683
2490
2491         * Scripts/webkitpy/common/net/layouttestresults.py:
2492         * Scripts/webkitpy/common/net/resultsjsonparser.py:
2493         * Scripts/webkitpy/layout_tests/layout_package/manager.py:
2494         * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
2495         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2496         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
2497         * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
2498         * Scripts/webkitpy/layout_tests/layout_package/worker.py:
2499         * Scripts/webkitpy/layout_tests/port/base.py:
2500         * Scripts/webkitpy/layout_tests/port/server_process.py:
2501         * Scripts/webkitpy/layout_tests/port/webkit.py:
2502         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2503
2504 2011-10-19  Jochen Eisinger  <jochen@chromium.org>
2505
2506         Chromium doesn't support git branch builds, so don't add the branch to the product dir
2507         https://bugs.webkit.org/show_bug.cgi?id=70449
2508
2509         Reviewed by Eric Seidel.
2510
2511         * Scripts/webkitdirs.pm:
2512         (determineBaseProductDir):
2513
2514 2011-10-19  Ojan Vafai  <ojan@chromium.org>
2515
2516         Unreviewed. Adding myself to watchlists.
2517         * Scripts/webkitpy/common/config/watchlist:
2518
2519 2011-10-19  Tom Zakrajsek  <tomz@codeaurora.org>
2520
2521         Add a suggest-nominations command to webkit-patch for computing potential committer/reviewer nominations
2522         https://bugs.webkit.org/show_bug.cgi?id=62166
2523
2524         Reviewed by Eric Seidel.
2525
2526         Included options to control committer/reviewer patch count requirements,
2527         an age-limit on patches, and verbose output for more in-depth analysis.
2528
2529         * Scripts/webkitpy/common/checkout/changelog.py:
2530         * Scripts/webkitpy/tool/commands/__init__.py:
2531         * Scripts/webkitpy/tool/commands/suggestnominations.py: Added.
2532         * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py: Added.
2533
2534 2011-10-19  Eric Seidel  <eric@webkit.org>
2535
2536         new-run-webkit-tests -2 was crashing due to both "java" and "java/" being listed in Skipped files.
2537         Make NRWT normalize directory names in Skipped files during parsing.
2538
2539         Unreviewed.  Very simple (tested) change.
2540
2541         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
2542         * Scripts/webkitpy/layout_tests/port/webkit.py:
2543
2544 2011-10-19  David Levin  <levin@chromium.org>
2545
2546         watchlist: Should be more robust to bad regex.
2547         https://bugs.webkit.org/show_bug.cgi?id=69486
2548
2549         Reviewed by Adam Barth.
2550
2551         * Scripts/webkitpy/common/config/watchlist: Change the instructions due to
2552           watchlist being checked by check-webkit-style (bug 69487) and remove the .* from file
2553           patterns since they are no longer anchored on the right hand side.
2554         * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Change *pattern to take a compiled regex directly.
2555         * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Ditto.
2556         * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Ditto.
2557         * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Ditto.
2558         * Scripts/webkitpy/common/watchlist/filenamepattern.py: Ditto.
2559         * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Ditto and change a test now that
2560         filenames are no longer anchored on the right hand side.
2561         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Catch regex errors and log them as errors.
2562         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add some tests to verify that bad regexes
2563         don't kill everything.
2564
2565 2011-10-19  David Levin  <levin@chromium.org>
2566
2567         watchlist: Add a stylecheck to do validity checks for the watchlist config.
2568         https://bugs.webkit.org/show_bug.cgi?id=69487
2569
2570         Reviewed by Adam Barth.
2571
2572         * Scripts/webkitpy/style/checker.py: Add the watchlist file type.
2573         * Scripts/webkitpy/style/checkers/watchlist.py: Added.
2574         * Scripts/webkitpy/style/checkers/watchlist_unittest.py: Added.
2575
2576 2011-10-19  Eric Seidel  <eric@webkit.org>
2577
2578         NRWT ServerProcess can't read lines from stderr and stdio separately
2579         https://bugs.webkit.org/show_bug.cgi?id=70435
2580
2581         Reviewed by Adam Barth.
2582
2583         This is the underlying bug behind our lack of WK2 support, and timeout detection on Windows.
2584         DRT expects RWT to read one line at a time from stderr and stdout independently.
2585         This allows DRT to communicate errors over stderr and have them responded to immediately
2586         regardless of what state the stdio stream may be in.  Previously NRWT's ServerProcess
2587         class only exposed a read_line function which would read a line from stdout
2588         and batch all output from stderr into an error buffer.  Callers would only be able
2589         to respond to commands over stderr if they happened to correspond with a stdout line boundary.
2590
2591         * Scripts/webkitpy/layout_tests/port/server_process.py:
2592         * Scripts/webkitpy/layout_tests/port/webkit.py:
2593
2594 2011-10-19  Chang Shu  <cshu@webkit.org>
2595
2596         [Qt] Support WK1-only Skipped list
2597         https://bugs.webkit.org/show_bug.cgi?id=70254
2598
2599         Reviewed by Csaba Osztrogonác.
2600
2601         Added a new search path qt-wk1 for skipping WK1-only tests.
2602
2603         * Scripts/webkitpy/layout_tests/port/qt.py: NRWT
2604         * Scripts/old-run-webkit-tests: ORWT
2605
2606 2011-10-19  Gabor Rapcsanyi  <rgabor@webkit.org>
2607
2608         [GTK] Enable to use built-product-archive on GTK platform
2609         https://bugs.webkit.org/show_bug.cgi?id=70319
2610
2611         Reviewed by Csaba Osztrogonác.
2612
2613         * BuildSlaveSupport/built-product-archive:
2614
2615 2011-10-18  David Levin  <levin@chromium.org>
2616
2617         watchlist: Should try to run if it can and not throw on mistakes.
2618         https://bugs.webkit.org/show_bug.cgi?id=70358
2619
2620         Reviewed by Adam Barth.
2621
2622         * Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
2623         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
2624         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
2625         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
2626         * Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
2627         * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.
2628
2629 2011-10-18  Sam Weinig  <sam@webkit.org>
2630
2631         Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
2632         https://bugs.webkit.org/show_bug.cgi?id=70387
2633
2634         Reviewed by Dan Bernstein.
2635
2636         * MiniBrowser/mac/BrowserWindowController.m:
2637         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
2638         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2639         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2640         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
2641         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2642         Update to include WKViewPrivate.h where necessary.
2643
2644 2011-10-18  Joseph Pecoraro  <joepeck@webkit.org>
2645
2646         Web Inspector: Some localizedStrings.js Updates
2647         https://bugs.webkit.org/show_bug.cgi?id=70365
2648
2649         Reviewed by Darin Adler.
2650
2651         * Scripts/check-inspector-strings:
2652         Updated to the new webkitpy way to determine checkout root.
2653
2654         * Scripts/webkitdirs.pm:
2655         (copyInspectorFrontendFiles):
2656         Made it so build-webkit --inspector-frontend copies over
2657         the localizedStrings.js file as well as the frontend files.
2658
2659 2011-10-18  Raphael Kubo da Costa  <kubo@profusion.mobi>
2660
2661         [EFL] DRT: Clear list of visited pages before each test.
2662         https://bugs.webkit.org/show_bug.cgi?id=70355
2663
2664         Reviewed by Antonio Gomes.
2665
2666         r97596 uncovered a bug in the implementation: the list of visited
2667         links was not cleared between tests, which caused tests such as
2668         fast/repaint/outline-repaint-glitch.html to be flaky (the link color
2669         changed depending on whether fast/repaint/border-repaint-glitch.html
2670         was visited before or not).
2671
2672         Call ewk_history_clear to make sure the visited links list does not
2673         persist between tests.
2674
2675         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
2676         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
2677
2678 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2679
2680         Split TestExpectationsEditor into its own file.
2681         https://bugs.webkit.org/show_bug.cgi?id=70348
2682
2683         Reviewed by Adam Barth.
2684
2685         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
2686         * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
2687         * Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
2688         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
2689         * Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.
2690
2691 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
2692
2693         [Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
2694         https://bugs.webkit.org/show_bug.cgi?id=70313
2695
2696         Reviewed by Adam Barth.
2697
2698         Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
2699         this parameter because build-webkit and other scripts don't accept it.
2700
2701         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2702
2703 2011-10-18  Adam Barth  <abarth@webkit.org>
2704
2705         Subscribe myself to WebIDL changes
2706         https://bugs.webkit.org/show_bug.cgi?id=70341
2707
2708         Reviewed by David Levin.
2709
2710         I've also added some documentation and refactored my previous
2711         subscriptions to make it eaiser for others to subscribe as well.
2712
2713         * Scripts/webkitpy/common/config/watchlist:
2714
2715 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2716
2717         Add myself to the newfangled watchlist plumbing.
2718         https://bugs.webkit.org/show_bug.cgi?id=70338
2719
2720         Reviewed by David Levin.
2721
2722         * Scripts/webkitpy/common/config/watchlist: Added sheepishly.
2723
2724 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2725
2726         Fix a unit test in TestFailures.
2727         https://bugs.webkit.org/show_bug.cgi?id=70337
2728
2729         Reviewed by Adam Barth.
2730
2731         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,
2732             the value of a method property should always be lowercase.
2733
2734 2011-10-18  Adam Barth  <abarth@webkit.org>
2735
2736         Always enable ENABLE(XPATH)
2737         https://bugs.webkit.org/show_bug.cgi?id=70217
2738
2739         Reviewed by Eric Seidel.
2740
2741         * Scripts/build-webkit:
2742
2743 2011-10-18  Dimitri Glazkov  <dglazkov@chromium.org>
2744
2745         garden-o-matic should not report flaking in expected failures as failures.
2746         https://bugs.webkit.org/show_bug.cgi?id=70279
2747
2748         Reviewed by Adam Barth.
2749
2750         On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
2751         For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
2752         same for garden-o-matic.
2753
2754         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,
2755             rewrote the logic for determining expected or unexpected failures as a central analysis tool.
2756         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
2757
2758 2011-10-18  Zan Dobersek  <zandobersek@gmail.com>
2759
2760         [Gtk] Support for client-based geolocation
2761         https://bugs.webkit.org/show_bug.cgi?id=64970
2762
2763         Reviewed by Martin Robinson.
2764
2765         Add support for testing client-based geolocation tests in DumpRenderTree.
2766
2767         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2768         (resetDefaultsToConsistentValues): Reset GeolocationClientMock.
2769         (createWebView): Create web view after declaring DumpRenderTree mode.
2770         That way a mock client for geolocation is used instead of a GeoClue
2771         client if a web view is created when testing.
2772         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for
2773         geolocation layout tests.
2774         (LayoutTestController::setMockGeolocationPosition):
2775         (LayoutTestController::setMockGeolocationError):
2776         (LayoutTestController::setGeolocationPermission):
2777         (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
2778         * Scripts/build-webkit: Note that the Gtk port is using client-based
2779         geolocation, even though changing this flag has no effect on compilation.
2780
2781 2011-10-07  Andrey Kosyakov  <caseq@chromium.org>
2782
2783         [Chromium] suppress console output from DevTools window
2784         https://bugs.webkit.org/show_bug.cgi?id=69632
2785
2786         Reviewed by Pavel Feldman.
2787
2788         * DumpRenderTree/chromium/TestShell.cpp:
2789         (TestShell::showDevTools):
2790         * DumpRenderTree/chromium/WebViewHost.cpp:
2791         (WebViewHost::didAddMessageToConsole):
2792         (WebViewHost::reset):
2793         (WebViewHost::setLogConsoleOutput):
2794         * DumpRenderTree/chromium/WebViewHost.h:
2795
2796 2011-10-18  Sheriff Bot  <webkit.review.bot@gmail.com>
2797
2798         Unreviewed, rolling out r97735.
2799         http://trac.webkit.org/changeset/97735
2800         https://bugs.webkit.org/show_bug.cgi?id=70317
2801
2802         some people apparently use build-jsc with the qt port without
2803         building webkit first (Requested by torarne on #webkit).
2804
2805         * Scripts/build-webkit:
2806         * Scripts/webkitdirs.pm:
2807         (buildQMakeProject):
2808         (buildQMakeQtProject):
2809
2810 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2811
2812         [Qt] Remove dead code in build-webkit
2813
2814         build-webkit will iterate over a list of subdirectories to build,
2815         but this feature is only used by the Apple ports. For QtWebKit we
2816         always pass an empty directory to buildQMakeProject, which makes
2817         the logic for dealing with sub-projects in buildQMakeProject just
2818         added noise.
2819
2820         If we do want this feature at some point, we should redo it in
2821         the context of the upcoming build system changes for Qt.
2822
2823         Reviewed by Simon Hausmann.
2824
2825         * Scripts/build-webkit:
2826         * Scripts/webkitdirs.pm:
2827         (buildQt):
2828
2829 2011-10-18  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2830
2831         Remove traces of Symbian support from the build scripts
2832
2833         Reviewed by Simon Hausmann.
2834
2835         * Scripts/build-webkit:
2836         * Scripts/webkitdirs.pm:
2837         (determineBaseProductDir):
2838         (argumentsForConfiguration):
2839         (usesPerConfigurationBuildDirectory):
2840         (buildQMakeProject):
2841
2842 2011-10-18  Ryosuke Niwa  <rniwa@webkit.org>
2843
2844         Build fix after r97672.
2845
2846         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2847
2848 2011-10-17  Kent Tamura  <tkent@chromium.org>
2849
2850         A follow-up of r97716.
2851         https://bugs.webkit.org/show_bug.cgi?id=68803
2852
2853         * DumpRenderTree/chromium/LayoutTestController.cpp:
2854         (LayoutTestController::reset): Initialize m_dumpCreateView.
2855
2856 2011-10-17  Jochen Eisinger  <jochen@chromium.org>
2857
2858         [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
2859         https://bugs.webkit.org/show_bug.cgi?id=68803
2860
2861         Reviewed by Nate Chapin.
2862
2863         * DumpRenderTree/chromium/LayoutTestController.cpp:
2864         (LayoutTestController::LayoutTestController):
2865         (LayoutTestController::dumpCreateView):
2866         * DumpRenderTree/chromium/LayoutTestController.h:
2867         (LayoutTestController::shouldDumpCreateView):
2868         * DumpRenderTree/chromium/WebViewHost.cpp:
2869         (WebViewHost::createView):
2870
2871 2011-10-17  Nate Chapin  <japhet@chromium.org>
2872
2873         Add myself to watchlists, and add a watch
2874         for Source/WebCore/loader/.
2875         https://bugs.webkit.org/show_bug.cgi?id=70263
2876
2877         Reviewed by David Levin.
2878
2879         * Scripts/webkitpy/common/config/watchlist:
2880
2881 2011-10-17  Raphael Kubo da Costa  <kubo@profusion.mobi>
2882
2883         [EFL] DRT: Make non-recognized keys work in events as well.
2884         https://bugs.webkit.org/show_bug.cgi?id=69860
2885
2886         Reviewed by Antonio Gomes.
2887
2888         fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
2889         here: it has a select box with a few non-latin options, and one of them
2890         is selected via the keyboard.
2891
2892         In this specific case, we need to make EventHandler::keyEvent send a
2893         keyPressEvent to SelectElement, so that
2894         SelectElement::defaultEventHandler calls typeAheadFind(). This happens
2895         only when PlatformKeyEvent::text() is not empty, which was not the case
2896         so far.
2897
2898         * DumpRenderTree/efl/EventSender.cpp:
2899         (keyDownCallback):
2900
2901 2011-10-17  Alok Priyadarshi  <alokp@chromium.org>
2902
2903         Add layout tests for WebPlugin compositor path
2904         https://bugs.webkit.org/show_bug.cgi?id=69027
2905
2906         Reviewed by James Robinson.
2907
2908         * DumpRenderTree/DumpRenderTree.gypi:
2909         * DumpRenderTree/chromium/TestWebPlugin.cpp: Added.
2910         (premultiplyAlpha):
2911         (TestWebPlugin::TestWebPlugin):
2912         (TestWebPlugin::~TestWebPlugin):
2913         (TestWebPlugin::mimeType):
2914         (TestWebPlugin::initialize):
2915         (TestWebPlugin::destroy):
2916         (TestWebPlugin::updateGeometry):
2917         (TestWebPlugin::parsePrimitive):
2918         (TestWebPlugin::parseColor):
2919         (TestWebPlugin::parseOpacity):
2920         (TestWebPlugin::initScene):
2921         (TestWebPlugin::drawScene):
2922         (TestWebPlugin::destroyScene):
2923         (TestWebPlugin::initProgram):
2924         (TestWebPlugin::initPrimitive):
2925         (TestWebPlugin::drawPrimitive):
2926         (TestWebPlugin::loadShader):
2927         (TestWebPlugin::loadProgram):
2928         * DumpRenderTree/chromium/TestWebPlugin.h: Added.
2929         (TestWebPlugin::scriptableObject):
2930         (TestWebPlugin::paint):
2931         (TestWebPlugin::updateFocus):
2932         (TestWebPlugin::updateVisibility):
2933         (TestWebPlugin::acceptsInputEvents):
2934         (TestWebPlugin::handleInputEvent):
2935         (TestWebPlugin::didReceiveResponse):
2936         (TestWebPlugin::didReceiveData):
2937         (TestWebPlugin::didFinishLoading):
2938         (TestWebPlugin::didFailLoading):
2939         (TestWebPlugin::didFinishLoadingFrameRequest):
2940         (TestWebPlugin::didFailLoadingFrameRequest):
2941         (TestWebPlugin::Scene::Scene):
2942         * DumpRenderTree/chromium/WebViewHost.cpp:
2943         (WebViewHost::createPlugin):
2944
2945 2011-10-17  Ryosuke Niwa  <rniwa@webkit.org>
2946
2947         [nrwt] Add new category for MISSING
2948         https://bugs.webkit.org/show_bug.cgi?id=69990
2949
2950         Reviewed by Dirk Pranke.
2951
2952         Treat missing results as a new category in summerize_results.
2953
2954         Because Chromium port wants to turn bots red when there are tests with missing results,
2955         extracted the logic to compute the exit code as exit_code_from_summarized_results in
2956         base and chromium ports.
2957
2958         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2959         * Scripts/webkitpy/layout_tests/port/base.py:
2960         * Scripts/webkitpy/layout_tests/port/chromium.py:
2961         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2962
2963 2011-10-17  Dimitri Glazkov  <dglazkov@chromium.org>
2964
2965         garden-o-matic operations fail because of CSP.
2966         https://bugs.webkit.org/show_bug.cgi?id=70249
2967
2968         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
2969
2970 2011-10-17  Ada Chan  <adachan@apple.com>
2971
2972         Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
2973         https://bugs.webkit.org/show_bug.cgi?id=70168
2974
2975         Reviewed by Alexey Proskuryakov.
2976
2977         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.
2978         (TestWebKitAPI::didFinishLoadForFrame):
2979         (TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.
2980
2981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2982         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2983         Add the new file.
2984
2985 2011-10-17  Darin Adler  <darin@apple.com>
2986
2987         Add some more *.pyc ignores in directories with Python scripts.
2988
2989         * QueueStatusServer: Added property svn:ignore.
2990         * Scripts/webkitpy/common/watchlist: Added property svn:ignore.
2991         * Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
2992         * Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
2993
2994 2011-10-17  Alexis Menard  <alexis.menard@openbossa.org>
2995
2996         [Qt][WK2][meta] Fix failing API tests
2997         https://bugs.webkit.org/show_bug.cgi?id=70236
2998
2999         Reviewed by Csaba Osztrogonác.
3000
3001         In order to run WebKit2 API tests we need the WebProcess to be in
3002         the path so let's add the bin directory when running the API tests of Qt.
3003
3004         * Scripts/run-qtwebkit-tests:
3005
3006 2011-10-17  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3007
3008         [Qt][WK2] Build dependency problems
3009         https://bugs.webkit.org/show_bug.cgi?id=68456
3010
3011         Reviewed by Csaba Osztrogonác.
3012
3013         * Scripts/webkitdirs.pm:
3014         (buildQMakeProject):
3015
3016 2011-10-17  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
3017
3018         [build] Introduce Qt/SH4 buildbot
3019         https://bugs.webkit.org/show_bug.cgi?id=70227
3020
3021         Reviewed by Adam Roben.
3022
3023         Add buildslave for Linux/Qt/SH4.
3024
3025         * BuildSlaveSupport/build.webkit.org-config/config.json:
3026
3027 2011-10-16  Adam Barth  <abarth@webkit.org>
3028
3029         Always enable ENABLE(DOM_STORAGE)
3030         https://bugs.webkit.org/show_bug.cgi?id=70189
3031
3032         Reviewed by Eric Seidel.
3033
3034         * Scripts/build-webkit:
3035         * waf/build/settings.py:
3036
3037 2011-10-15  Adam Barth  <abarth@webkit.org>
3038
3039         Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
3040         https://bugs.webkit.org/show_bug.cgi?id=70194
3041
3042         Reviewed by Daniel Bates.
3043
3044         * Scripts/build-webkit:
3045
3046 2011-10-15  Ojan Vafai  <ojan@chromium.org>
3047
3048         run-webkit-tests should accept --child-processes
3049         https://bugs.webkit.org/show_bug.cgi?id=69713
3050
3051         Reviewed by Adam Barth.
3052
3053         Only set --child-processes=1 if --child-processes it not
3054         passed on the commandline.
3055
3056         * Scripts/run-webkit-tests:
3057
3058 2011-10-15  Daniel Bates  <dbates@webkit.org>
3059
3060         Extract common gdb code into its own function; Remove script gdb-safari
3061         https://bugs.webkit.org/show_bug.cgi?id=68499
3062
3063         Reviewed by David Kilzer.
3064
3065         Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
3066         runSafari}() and in the script gdb-safari to launch gdb to debug an application.
3067         We should extract the common parts into a function that can be shared by all callers
3068         so as to remove duplicate code.
3069
3070         As a side effect of removing duplicate code we can remove the script gdb-safari since
3071         its code has been incorporated into webkitdirs::debugSafari() which is called by the
3072         script debug-safari.
3073
3074         * Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
3075         * Scripts/gdb-safari: Removed.
3076         * Scripts/webkitdirs.pm:
3077         (execMacWebKitAppForDebugging): Added; Extracted common debugging code from
3078         debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
3079         script gdb-safari to here.
3080         (debugSafari): Added.
3081         (runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
3082         Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
3083         runSafari() always returns 1 on Windows and the script run-safari exits using this
3084         value as its exit status. Hence, the script run-safari always exits with a nonzero
3085         exit status (i.e. abnormal termination) on Windows. Instead, we should return the
3086         exit status of the WebKit launcher application.
3087         (debugMiniBrowser): Modified to call debugMacWebKitApp().
3088         (debugWebKitTestRunner): Ditto.
3089
3090 2011-10-15  Robert Hogan  <robert@webkit.org>
3091
3092         [webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
3093         https://bugs.webkit.org/show_bug.cgi?id=70056
3094
3095         Reviewed by Adam Barth.
3096
3097         The preferred file-order for patches is LayoutTests at the end and
3098         ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use
3099         it when creating patches for review and landing.
3100
3101         * Scripts/webkitpy/common/checkout/scm/git.py:
3102         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
3103         * Scripts/webkitpy/common/config/orderfile: Added.
3104
3105 2011-10-15  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3106
3107         [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
3108         https://bugs.webkit.org/show_bug.cgi?id=69920
3109
3110         Reviewed by Kenneth Rohde Christiansen.
3111
3112         * DumpRenderTree/qt/DumpRenderTree.pro:
3113         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
3114         (WebCore::DumpRenderTree::open):
3115         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3116         * QtTestBrowser/QtTestBrowser.pro:
3117         * QtTestBrowser/launcherwindow.cpp:
3118         (LauncherWindow::screenshot):
3119         (LauncherWindow::showFPS):
3120         (LauncherWindow::updateFPS):
3121         * QtTestBrowser/launcherwindow.h:
3122         (WindowOptions::WindowOptions):
3123         * QtTestBrowser/mainwindow.cpp:
3124         (MainWindow::buildUI):
3125         * Scripts/webkitpy/style/checker.py: Remove rules for the
3126         WebKit/qt/symbian/platformplugin directory.
3127         * Scripts/webkitpy/style/checker_unittest.py:
3128         * Tools.pro:
3129         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3130         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
3131         (WTR::LayoutTestController::platformInitialize):
3132         * WebKitTestRunner/qt/TestControllerQt.cpp:
3133         (WTR::isExistingLibrary):
3134         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3135
3136 2011-10-15  Adam Barth  <abarth@webkit.org>
3137
3138         Fix typo in webkitpy help
3139         https://bugs.webkit.org/show_bug.cgi?id=70169
3140
3141         Reviewed by Eric Seidel.
3142
3143         * Scripts/webkitpy/tool/commands/upload.py:
3144
3145 2011-10-15  Tony Chang  <tony@chromium.org>
3146
3147         fix another typo in treemap.html
3148         https://bugs.webkit.org/show_bug.cgi?id=70149
3149
3150         Reviewed by Ojan Vafai.
3151
3152         Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.
3153
3154         * TestResultServer/static-dashboards/treemap.html:
3155
3156 2011-10-14  Adam Barth  <abarth@webkit.org>
3157
3158         Hide status bubbles from queues which are very far behind
3159         https://bugs.webkit.org/show_bug.cgi?id=70133
3160
3161         Reviewed by Eric Seidel.
3162
3163         The mac-ews is so far behind that we shouldn't show its status bubble.
3164         The status bubble just makes contributors sad.
3165
3166         * QueueStatusServer/handlers/statusbubble.py:
3167
3168 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
3169
3170         Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
3171         https://bugs.webkit.org/show_bug.cgi?id=70143
3172
3173         Reviewed by Adam Barth.
3174
3175         * Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
3176         * Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.
3177
3178 2011-10-14  David Levin  <levin@chromium.org>
3179
3180         watchlist: Add a validation check for the email names in the list.
3181         https://bugs.webkit.org/show_bug.cgi?id=70154
3182
3183         Reviewed by Adam Barth.
3184
3185         If an email is listed which doesn't have a bugzilla log in, then any emails
3186         added to the bug along with that email will fail to happen, so try to prevent this
3187         from happening by validating that emails added to the watchlist are known to be
3188         contributors.
3189
3190         * Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
3191         * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
3192         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.
3193
3194 2011-10-14  David Levin  <levin@chromium.org>
3195
3196         watchlist: If the style check fails, then the watchlist will not be run.
3197         https://bugs.webkit.org/show_bug.cgi?id=69484
3198
3199         Reviewed by Adam Barth.
3200
3201         * Scripts/webkitpy/tool/commands/queues.py: Run the watch list even
3202         if the style part fails and don't allow watch list failures turn the
3203         bot run red.
3204         * Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
3205         * Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.
3206
3207 2011-10-14  Dimitri Glazkov  <dglazkov@chromium.org>
3208
3209         Plumb style-checker filter up to command options and make land-cowboy use it.
3210         https://bugs.webkit.org/show_bug.cgi?id=70119
3211
3212         Reviewed by Adam Barth.
3213
3214         * Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
3215         * Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
3216         * Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
3217         * Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
3218         * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
3219         * Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
3220         * Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.
3221
3222 2011-10-14  Sam Weinig  <sam@webkit.org>
3223
3224         Remove the Leopard slaves.
3225
3226         Reviewed by Adam Roben.
3227
3228         * BuildSlaveSupport/build.webkit.org-config/config.json:
3229
3230 2011-10-14  Peter Beverloo  <peter@chromium.org>
3231
3232         [Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
3233         https://bugs.webkit.org/show_bug.cgi?id=70028
3234
3235         Reviewed by Adam Barth.
3236
3237         * Scripts/update-webkit-chromium:
3238         * Scripts/webkitdirs.pm:
3239         (buildChromiumMakefile):
3240         (buildChromium):
3241
3242 2011-10-14  Leandro Pereira  <leandro@profusion.mobi>
3243
3244         Unreviewed; add missing #includes.
3245
3246         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3247         * DumpRenderTree/efl/EventSender.cpp:
3248
3249 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
3250
3251         [EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
3252         https://bugs.webkit.org/show_bug.cgi?id=69770
3253
3254         Reviewed by Antonio Gomes.
3255
3256         We were just appending the given URL to the absolute URI of the main
3257         frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
3258         instead of "file:///foo/bar/theother/url.html".
3259
3260         This should make fast/dom/navigation-type-navigate.html behave
3261         better (it still fails, but later).
3262
3263         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3264         (LayoutTestController::queueLoad):
3265
3266 2011-10-13  Arko Saha  <arko@motorola.com>
3267
3268         Microdata: Basic implementation of document.getItems() method.
3269         https://bugs.webkit.org/show_bug.cgi?id=68610
3270
3271         Reviewed by Ryosuke Niwa.
3272
3273         Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
3274         Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
3275
3276         * Scripts/build-webkit:
3277
3278 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
3279
3280         new-run-webkit-tests does not support qt-4.8 results
3281         https://bugs.webkit.org/show_bug.cgi?id=64071
3282
3283         Roll-back second part of r97252. :)
3284
3285         * Scripts/webkitpy/layout_tests/port/qt.py:
3286
3287 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
3288
3289         [EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
3290         https://bugs.webkit.org/show_bug.cgi?id=70106
3291
3292         Reviewed by Antonio Gomes.
3293
3294         OwnFastMallocPtr was being used as a smart pointer that automatically called
3295         free() on the strings returned by the EFL or by ewk.
3296
3297         However, when WTF is built in release mode, it uses its own memory management
3298         code instead of using the system malloc(), free() and friends. This means bad
3299         things will happen when one uses WTF's free() on memory allocated with system
3300         malloc() by the EFL or ewk.
3301
3302         The easiest way to solve this is to call free() ourselves.
3303
3304         * DumpRenderTree/efl/DumpRenderTree.cpp:
3305         (dumpFramesAsText):
3306         (getFinalTestURL):
3307
3308 2011-10-14  Raphael Kubo da Costa  <kubo@profusion.mobi>
3309
3310         [EFL] Add DumpRenderTreeSupportEfl
3311         https://bugs.webkit.org/show_bug.cgi?id=68458
3312
3313         Reviewed by Kenneth Rohde Christiansen.
3314
3315         Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.
3316
3317         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
3318         (DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
3319         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
3320         (DumpRenderTreeChrome::onWindowObjectCleared):
3321         (DumpRenderTreeChrome::onDocumentLoadFinished):
3322         * DumpRenderTree/efl/GCControllerEfl.cpp:
3323         (GCController::collect):
3324         (GCController::collectOnAlternateThread):
3325         (GCController::getJSObjectCount):
3326         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3327         (LayoutTestController::counterValueForElementById):
3328         (LayoutTestController::pageNumberForElementById):
3329         (LayoutTestController::numberOfPages):
3330         (LayoutTestController::workerThreadCount):
3331         (LayoutTestController::findString):
3332         (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
3333         (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
3334         (LayoutTestController::sampleSVGAnimationForElementAtTime):
3335         (LayoutTestController::numberOfActiveAnimations):
3336         (LayoutTestController::suspendAnimations):
3337         (LayoutTestController::resumeAnimations):
3338         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
3339         (createBitmapContextFromWebView):
3340
3341 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
3342
3343         [Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.
3344
3345         Unreviewed.
3346
3347         * Scripts/run-webkit-tests:
3348         (useNewRunWebKitTests):
3349
3350 2011-10-14  Csaba Osztrogonác  <ossy@webkit.org>
3351
3352         new-run-webkit-tests does not support qt-4.8 results
3353         https://bugs.webkit.org/show_bug.cgi?id=64071
3354
3355         Roll-back r97252 with unit test fix.
3356
3357         Reviewed by Csaba Osztrogonác.
3358
3359         * Scripts/webkitpy/layout_tests/port/qt.py:
3360         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3361
3362 2011-10-13  Ojan Vafai  <ojan@chromium.org>
3363
3364         Make filter-build-webkit exit 1 if the build fails.
3365         https://bugs.webkit.org/show_bug.cgi?id=70080
3366
3367         Reviewed by Eric Seidel.
3368
3369         This only works if you redirect stderr to stdout, but it at least makes it possible.
3370         This is useful if you want to run a followup command (e.g. run-webkit-tests) but
3371         only if the build succeeds.
3372
3373         * Scripts/filter-build-webkit:
3374
3375 2011-10-13  Dimitri Glazkov  <dglazkov@chromium.org>
3376
3377         land-cowboy should at least check style.
3378         https://bugs.webkit.org/show_bug.cgi?id=70073
3379
3380         Reviewed by Adam Barth.
3381
3382         * Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command.
3383
3384 2011-10-13  Tony Chang  <tony@chromium.org>
3385
3386         fix regex in layout test times dashboard
3387         https://bugs.webkit.org/show_bug.cgi?id=70059
3388
3389         This fixes the treemapfocus query param.
3390
3391         Reviewed by Ojan Vafai.
3392
3393         * TestResultServer/static-dashboards/treemap.html:
3394
3395 2011-10-13  Beth Dakin  <bdakin@apple.com>
3396
3397         https://bugs.webkit.org/show_bug.cgi?id=70050
3398         DRT and WRT should have HiDPI testing capabilities
3399
3400         Reviewed by Darin Adler.
3401
3402         New layoutTestController function setBackingScaleFactor takes a double for a scale
3403         factor and a callback function to call once the backing scale factor has
3404         successfully been set for the view.
3405         * DumpRenderTree/LayoutTestController.cpp:
3406         (setBackingScaleFactorCallback):
3407         (LayoutTestController::staticFunctions):
3408
3409         On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other
3410         platforms do nothing.
3411         * DumpRenderTree/LayoutTestController.h:
3412         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3413         (LayoutTestController::setBackingScaleFactor):
3414         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3415         (LayoutTestController::setBackingScaleFactor):
3416         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3417         (LayoutTestController::setBackingScaleFactor):
3418
3419         Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a
3420         value of 0, which resets to the system default.
3421         * DumpRenderTree/mac/DumpRenderTree.mm:
3422         (resetWebViewToConsistentStateBeforeTesting):
3423
3424         When generating the pixel dump, create a Bitmap of the appropriate size based on
3425         the backing scale factor. If it is a HiDPI view, paint into the context using
3426         displayRectIgnoringOpacity.
3427         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
3428         (createBitmapContextFromWebView):
3429
3430         And now the same stuff for WK2. Again, new layoutTestController function
3431         setBackingScaleFactor takes a double for a scale factor and a callback function.
3432         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
3433         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
3434         (WTR::LayoutTestController::setBackingScaleFactor):
3435         (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
3436         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
3437
3438         The InjectedBundle sends a message to the UI process to set the backing scale
3439         factor. It also processes a message the UI process will send back once it
3440         completes this task, and at that time, the InjectedBundle calls the callback.
3441         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3442         (WTR::InjectedBundle::didReceiveMessage):
3443         (WTR::InjectedBundle::postSetBackingScaleFactor):
3444         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3445
3446         Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor
3447         with a value of 0, which resets to the system default.
3448         * WebKitTestRunner/TestController.cpp:
3449         (WTR::TestController::resetStateToConsistentValues):
3450
3451         Upon receiving the SetBackingScaleFactor message, call
3452         WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message
3453         back to InjectedBundle to say it has been done.
3454         * WebKitTestRunner/TestInvocation.cpp:
3455         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3456
3457         Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a
3458         window's scale factor so we have to avoid that.
3459         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3460         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3461
3462 2011-10-13  John Knottenbelt  <jknotten@chromium.org>
3463
3464         [Chromium] Allow building without speech input enabled.
3465         https://bugs.webkit.org/show_bug.cgi?id=69867
3466
3467         Reviewed by Darin Fisher.
3468
3469         * DumpRenderTree/chromium/LayoutTestController.cpp:
3470         (LayoutTestController::addMockSpeechInputResult):
3471
3472 2011-10-13  Kent Tamura  <tkent@chromium.org>
3473
3474         [Chromium] A DRT fix for r97348.
3475
3476         * DumpRenderTree/chromium/LayoutTestController.cpp:
3477         (LayoutTestController::overridePreference):
3478         Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
3479         print an error message.
3480
3481 2011-10-12  Lucas Forschler  <lforschler@apple.com>
3482
3483         Update kill-old-processes logic.
3484         https://bugs.webkit.org/show_bug.cgi?id=63651
3485
3486         Reviewed by Ryosuke Niwa.
3487
3488         Remove unused mac platform specific folder.
3489         Update master.config to use new kill-old-processes.
3490
3491         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3492         * BuildSlaveSupport/kill-old-processes:
3493         * BuildSlaveSupport/mac: Removed.
3494
3495 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
3496
3497         [NRWT] New tests without expected files are reported as flakey tests
3498         https://bugs.webkit.org/show_bug.cgi?id=67268
3499
3500         Reviewed by Dirk Pranke.
3501
3502         The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
3503         and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
3504         for missing results in retry_summary.
3505
3506         Fixed the bug by treating missing results separately.
3507
3508         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3509         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3510
3511 2011-10-12  Adam Barth  <abarth@webkit.org>
3512
3513         Remove ENABLE(XHTMLMP) and associated code
3514         https://bugs.webkit.org/show_bug.cgi?id=69729
3515
3516         Reviewed by David Levin.
3517
3518         * Scripts/build-webkit:
3519         * Scripts/old-run-webkit-tests:
3520         * Scripts/webkitperl/features.pm:
3521         * Scripts/webkitpy/layout_tests/port/webkit.py:
3522         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3523
3524 2011-10-12  Ryosuke Niwa  <rniwa@webkit.org>
3525
3526         Kill old run-webkit-tests processes in kill-process on Mac
3527         https://bugs.webkit.org/show_bug.cgi?id=69976
3528
3529         Reviewed by Dirk Pranke.
3530
3531         Add a system call to remove all python processes running run-webkit-tests.
3532
3533         * BuildSlaveSupport/kill-old-processes:
3534         * BuildSlaveSupport/mac: Removed.
3535
3536 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
3537
3538         Many WK2 snapshots are blank
3539         https://bugs.webkit.org/show_bug.cgi?id=69953
3540
3541         Reviewed by Beth Dakin.
3542
3543         Two fixes:
3544         1. negating a size_t in CGContextTranslateCTM() fails, because
3545         size_t is unsigned. Fix by casing to CGFloat before negation.
3546
3547         2. Turn on window autodisplay, so that compositing tests snapshot correctly.
3548         Autodisplay is necessary to kick off Core Animation rendering.
3549
3550         * WebKitTestRunner/cg/TestInvocationCG.cpp:
3551         (WTR::createCGContextFromImage):
3552         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3553         (WTR::PlatformWebView::PlatformWebView):
3554
3555 2011-10-12  Adam Barth  <abarth@webkit.org>
3556
3557         commit-queue doesn't have a friendly error message when the reviewer line is messed up
3558         https://bugs.webkit.org/show_bug.cgi?id=69979
3559
3560         Reviewed by Eric Seidel.
3561
3562         Rather than combining the ChangeLog validation with a more complicated
3563         command, this patch has the commit-queue run it as a separate command,
3564         which will give us more control over the error message.
3565
3566         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3567         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
3568         * Scripts/webkitpy/tool/commands/download.py:
3569         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3570         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
3571         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3572
3573 2011-10-12  Eric Seidel  <eric@webkit.org>
3574
3575         Layout tests asserting in LayoutTestController::pathToLocalResource()
3576         https://bugs.webkit.org/show_bug.cgi?id=69898
3577
3578         Reviewed by Simon Fraser.
3579
3580         old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.
3581
3582         * Scripts/old-run-webkit-tests:
3583         (openDumpTool):
3584
3585 2011-10-12  Adam Barth  <abarth@webkit.org>
3586
3587         The commit-queue doesn't tell me which tests my patch broke
3588         https://bugs.webkit.org/show_bug.cgi?id=69975
3589
3590         Reviewed by Eric Seidel.
3591
3592         We now print the list of newly failing tests, like we do for the EWS.
3593
3594         * Scripts/webkitpy/tool/commands/queues.py:
3595         * Scripts/webkitpy/tool/commands/queues_unittest.py:
3596
3597 2011-10-10  Alice Boxhall  <aboxhall@chromium.org>
3598
3599         Added myself as a committer.
3600
3601         * Scripts/webkitpy/common/config/committers.py:
3602
3603 2011-10-12  Adam Barth  <abarth@webkit.org>
3604
3605         _run_tests is a confusing variable name in webkitpy
3606         https://bugs.webkit.org/show_bug.cgi?id=69971
3607
3608         Reviewed by Eric Seidel.
3609
3610         Eric and I thought this was a function.
3611
3612         * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
3613
3614 2011-10-12  Tony Chang  <tony@chromium.org>
3615
3616         Fix test-webkitpy after r97307 and r97293.
3617
3618         * Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms
3619           is None during tests so add back the check.
3620         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The
3621           output directory is now build/Debug.
3622
3623 2011-10-12  Tony Chang  <tony@chromium.org>
3624
3625         [chromium] remove old build dirs on chromium-win
3626         https://bugs.webkit.org/show_bug.cgi?id=69961
3627
3628         Reviewed by Adam Barth.
3629
3630         * Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now
3631           always in build and never in chrome or webkit.
3632
3633 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
3634
3635         garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
3636         https://bugs.webkit.org/show_bug.cgi?id=69954
3637
3638         Also renamed the action and associated event name to address an FIXME.
3639
3640         Reviewed by Adam Barth.
3641
3642         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
3643         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
3644         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
3645
3646 2011-10-12  Tony Chang  <tony@chromium.org>
3647
3648         stop spamming 'stopping test driver timed out, killing it' when running rwt
3649         https://bugs.webkit.org/show_bug.cgi?id=69938
3650
3651         Reviewed by Adam Barth.
3652
3653         In http://trac.webkit.org/changeset/95875 , we made the timeout for
3654         stopping the driver based on time_out_ms, but we based it on the wrong
3655         default times.
3656
3657         * Scripts/webkitpy/layout_tests/port/chromium.py:
3658
3659 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
3660
3661         3D transforms are flattened in WebKit2 snapshots
3662         https://bugs.webkit.org/show_bug.cgi?id=68276
3663
3664         Reviewed by Adam Roben.
3665
3666         Fix WKImage leak noticed by Adam.
3667
3668         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3669         (WTR::PlatformWebView::windowSnapshotImage):
3670
3671 2011-10-12  Dimitri Glazkov  <dglazkov@chromium.org>
3672
3673         garden-o-matic should color-code test failure types.
3674         https://bugs.webkit.org/show_bug.cgi?id=69945
3675
3676         Reviewed by Adam Barth.
3677
3678         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
3679         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
3680         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
3681         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
3682
3683 2011-10-12  Adam Barth  <abarth@webkit.org>
3684
3685         webkitpy tests are failing on Mac bots
3686         https://bugs.webkit.org/show_bug.cgi?id=69929
3687
3688         Reviewed by Simon Fraser.
3689
3690         Admit that Lion exists.
3691
3692         * Scripts/webkitpy/layout_tests/port/chromium.py:
3693         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
3694
3695 2011-10-12  Simon Fraser  <simon.fraser@apple.com>
3696
3697         Improve output of run-api-tests to make time-outs more obvious
3698         https://bugs.webkit.org/show_bug.cgi?id=69788
3699
3700         Reviewed by Adam Roben.
3701
3702         List the tests that failed and timed out at the bottom of the output,
3703         if run with --verbose.
3704
3705         * Scripts/run-api-tests:
3706         (runAllTests):
3707         (runTest):
3708
3709 2011-10-12  Sheriff Bot  <webkit.review.bot@gmail.com>
3710
3711         Unreviewed, rolling out r97252.
3712         http://trac.webkit.org/changeset/97252
3713         https://bugs.webkit.org/show_bug.cgi?id=69944
3714
3715         Broke test-webkpy (Requested by abarth on #webkit).
3716
3717         * Scripts/webkitpy/layout_tests/port/qt.py:
3718         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3719
3720 2011-10-12  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3721
3722         new-run-webkit-tests does not support qt-4.8 results
3723         https://bugs.webkit.org/show_bug.cgi?id=64071
3724
3725         Reviewed by Csaba Osztrogonác.
3726
3727         * Scripts/webkitpy/layout_tests/port/qt.py:
3728         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
3729
3730 2011-10-10  Martin Robinson  <mrobinson@igalia.com>
3731
3732         [GTK] [WebKit2] Make adding another unit test easier
3733         https://bugs.webkit.org/show_bug.cgi?id=69409
3734
3735         Reviewed by Gustavo Noronha Silva.
3736
3737         * Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute
3738         new WebKit2 tests.
3739
3740 2011-10-11  Takashi Toyoshima  <toyoshim@chromium.org>
3741
3742         [WebSocket] update pywebsocket to 0.6b6.
3743         https://bugs.webkit.org/show_bug.cgi?id=69824
3744
3745         Reviewed by Kent Tamura.
3746
3747         WebKit supports WebSocket with version 8 based protocol for now.
3748         We should update its protocol to version 13 based one like hybi-17.
3749         pywebsocket 0.6b6 supports both of version 8 and 13.
3750
3751         * Scripts/webkitpy/thirdparty/__init__.py:
3752
3753 2011-10-11  Simon Fraser  <simon.fraser@apple.com>
3754
3755         WebKitTestRunner needs to link with WebKit for NSURL category methods
3756         https://bugs.webkit.org/show_bug.cgi?id=69892
3757
3758         Reviewed by Sam Weinig.
3759
3760         WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
3761         the +_web_originalDataAsString selector on NSURL was not recognized. Link with
3762         WebKit.framework to fix this.
3763
3764         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3765
3766 2011-10-11  Adam Barth  <abarth@webkit.org>
3767
3768         sheriffbot takes too long to acknowledge rollout commands
3769         https://bugs.webkit.org/show_bug.cgi?id=69871
3770
3771         Reviewed by Eric Seidel.
3772
3773         We used to update the working copy before acknowledging the command
3774         because we wanted to ping all the relevant IRC nicks.  That's caused a
3775         bunch of frustration because folks don't know whether the bot has heard
3776         their commands.
3777
3778         This patch makes the bot reply immediately before updating the working
3779         copy.  All the relevenat folks are still pinged when the bot finishes
3780         preparing the rollout.
3781
3782         * Scripts/webkitpy/tool/bot/irc_command.py:
3783         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3784
3785 2011-10-11  Adam Barth  <abarth@webkit.org>
3786
3787         test-webkitpy fails on Lion
3788         https://bugs.webkit.org/show_bug.cgi?id=69873
3789
3790         Reviewed by Eric Seidel.
3791
3792         This patch fixes one of the two failures.  I'll need to track down the
3793         other failure another time.
3794
3795         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
3796
3797 2011-10-11  Adam Barth  <abarth@webkit.org>
3798
3799         garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
3800         https://bugs.webkit.org/show_bug.cgi?id=65230
3801
3802         Reviewed by Dimitri Glazkov.
3803
3804         This patch causes us to treat crashed or hung run-webkit-tests runs
3805         similarly to how we treat compile failures.  In some sense, they're
3806         similar because they prevent us from getting test coverage.
3807
3808         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
3809         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
3810
3811 2011-10-11  Adam Barth  <abarth@webkit.org>
3812
3813         Failing builder display in garden-o-matic should have the same visual style as the failure grid
3814         https://bugs.webkit.org/show_bug.cgi?id=69876
3815
3816         Reviewed by Dimitri Glazkov.
3817
3818         This patch generalizes the view we use for failing builders in the
3819         FailureGrid so that we can use it for the list of builders that aren't
3820         compiling.
3821
3822         One downside of this patch is that it makes it harder to tell when
3823         debug builders are failing (as opposed to release builders) because
3824         that information isn't presented in this view.  A future patch will
3825         improve this aspect.
3826
3827         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
3828         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
3829         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3830         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3831         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
3832         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
3833
3834 2011-10-11  Filip Pizlo  <fpizlo@apple.com>
3835
3836         Some API tests are timing out in Release
3837         https://bugs.webkit.org/show_bug.cgi?id=69787
3838
3839         Reviewed by Mark Rowe.
3840
3841         NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
3842         magic to ensure that GTest builds in release mode in clang with NDEBUG set.
3843
3844         * TestWebKitAPI/Configurations/Base.xcconfig:
3845         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3846         * TestWebKitAPI/config.h:
3847
3848 2011-10-11  Adam Barth  <abarth@webkit.org>
3849
3850         garden-o-matic links to flakiness dashboard should open in a new tab
3851         https://bugs.webkit.org/show_bug.cgi?id=69864
3852
3853         Reviewed by Dimitri Glazkov.
3854
3855         This bug was obvious in the first five minutes of using this new
3856         feature.  :)
3857
3858         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3859         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3860
3861 2011-10-11  Adam Barth  <abarth@webkit.org>
3862
3863         Tweak the Content-Security-Policy for garden-o-matic.  It turns out
3864         that * doesn't really mean "all".  I've emailed the W3C working group
3865         about changing the spec.
3866
3867         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
3868
3869 2011-10-11  Adam Barth  <abarth@webkit.org>
3870
3871         garden-o-matic should link to the flakiness dashboard
3872         https://bugs.webkit.org/show_bug.cgi?id=69862
3873
3874         Reviewed by Dimitri Glazkov.
3875
3876         The flakiness dashboard has lots of great information about the failure
3877         history of each test.  This patch adds a link from garden-o-matic to
3878         the flakiness dashboard so the gardener can look at this information.
3879
3880         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
3881         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
3882         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
3883
3884 2011-10-11  David Levin  <levin@chromium.org>
3885
3886         watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
3887         https://bugs.webkit.org/show_bug.cgi?id=69789
3888
3889         Reviewed by Eric Seidel.
3890
3891         Made the signature of _assertRaisesRegexp match that of Python 2.7.
3892
3893         * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
3894         * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
3895         * Scripts/webkitpy/common/webkitunittest.py: Ditto.
3896         * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
3897
3898 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
3899
3900         [EFL] DRT: Do not abort() when an unknown key is pressed.
3901         https://bugs.webkit.org/show_bug.cgi?id=69856
3902
3903         Reviewed by Antonio Gomes.
3904
3905         A lot of tests crash due to the previous behaviour. Just using the
3906         received name of the pressed key works most of the time, and when it
3907         does not the failing tests should tell us.
3908
3909         * DumpRenderTree/efl/EventSender.cpp:
3910         (keyPadNameFromJSValue):
3911         (keyNameFromJSValue):
3912         (keyDownCallback):
3913
3914 2011-10-11  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3915
3916         [Qt] [WK2] NRWT failed to launch MiniBrowser after test run
3917         https://bugs.webkit.org/show_bug.cgi?id=68016
3918
3919         Reviewed by Chang Shu.
3920
3921         * Scripts/webkitpy/layout_tests/port/qt.py:
3922
3923 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
3924
3925         [EFL] DRT: Return the right window count in LayoutTestController.
3926         https://bugs.webkit.org/show_bug.cgi?id=69764
3927
3928         Reviewed by Antonio Gomes.
3929
3930         Follow-up to r96943: now that we have DumpRenderTreeChrome and
3931         DumpRenderTreeView in the tree, we can correctly count the number of
3932         open windows in DRT.
3933
3934         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3935         (LayoutTestController::windowCount):
3936
3937 2011-10-11  Jer Noble  <jer.noble@apple.com>
3938
3939         REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
3940         https://bugs.webkit.org/show_bug.cgi?id=69800
3941
3942         Reviewed by Csaba Osztrogonác.
3943
3944         Enable WEB_AUDIO at runtime.
3945
3946         * DumpRenderTree/mac/DumpRenderTree.mm:
3947         (resetDefaultsToConsistentValues):
3948
3949 2011-10-11  Raphael Kubo da Costa  <kubo@profusion.mobi>
3950
3951         [EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
3952         https://bugs.webkit.org/show_bug.cgi?id=69769
3953
3954         Reviewed by Antonio Gomes.
3955
3956         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3957         (LayoutTestController::setIconDatabaseEnabled):
3958
3959 2011-10-11  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
3960
3961         [Qt] Remove all references to QTDIR_build and standalone_package
3962
3963         Qt is now modularized, which means we no longer import WebKit into
3964         the Qt source tree. Instead we use git submodules, and building
3965         QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
3966
3967         To decrease the number of buildsystem configurations we also remove
3968         the standalone_package code-path used when we were providing tarballs
3969         with the derived sources pre-generated.
3970
3971         Reviewed by Simon Hausmann.
3972
3973         * MiniBrowser/qt/MiniBrowser.pro:
3974         * QtTestBrowser/QtTestBrowser.pro:
3975         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3976
3977 2011-10-11  Dominic Mazzoni  <dmazzoni@google.com>
3978
3979         Update Chromium accessibility support in DRT.
3980         https://bugs.webkit.org/show_bug.cgi?id=69676
3981
3982         Reviewed by Chris Fleizach.
3983
3984         Adds several missing properties and methods to enable more
3985         tests to pass, and in particular adds support for notification
3986         callbacks.
3987
3988         * DumpRenderTree/chromium/AccessibilityController.cpp:
3989         (AccessibilityController::AccessibilityController):
3990         (AccessibilityController::reset):
3991         (AccessibilityController::getFocusedElement):
3992         (AccessibilityController::shouldLogAccessibilityEvents):
3993         (AccessibilityController::notificationReceived):
3994         (AccessibilityController::logAccessibilityEventsCallback):
3995         * DumpRenderTree/chromium/AccessibilityController.h:
3996         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3997         (getHelpText):
3998         (getStringValue):
3999         (getOrientation):
4000         (AccessibilityUIElement::AccessibilityUIElement):
4001         (AccessibilityUIElement::getChildAtIndex):
4002         (AccessibilityUIElement::isEqual):
4003         (AccessibilityUIElement::notificationReceived):
4004         (AccessibilityUIElement::roleGetterCallback):
4005         (AccessibilityUIElement::titleGetterCallback):
4006         (AccessibilityUIElement::descriptionGetterCallback):
4007         (AccessibilityUIElement::helpTextGetterCallback):
4008         (AccessibilityUIElement::stringValueGetterCallback):
4009         (AccessibilityUIElement::xGetterCallback):
4010         (AccessibilityUIElement::yGetterCallback):
4011         (AccessibilityUIElement::widthGetterCallback):
4012         (AccessibilityUIElement::heightGetterCallback):
4013         (AccessibilityUIElement::intValueGetterCallback):
4014         (AccessibilityUIElement::minValueGetterCallback):
4015         (AccessibilityUIElement::maxValueGetterCallback):
4016         (AccessibilityUIElement::childrenCountGetterCallback):
4017         (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
4018         (AccessibilityUIElement::selectedTextRangeGetterCallback):
4019         (AccessibilityUIElement::isEnabledGetterCallback):
4020         (AccessibilityUIElement::isRequiredGetterCallback):
4021         (AccessibilityUIElement::isFocusedGetterCallback):
4022         (AccessibilityUIElement::isFocusableGetterCallback):
4023         (AccessibilityUIElement::isSelectedGetterCallback):
4024         (AccessibilityUIElement::isSelectableGetterCallback):
4025         (AccessibilityUIElement::isMultiSelectableGetterCallback):
4026         (AccessibilityUIElement::isExpandedGetterCallback):
4027         (AccessibilityUIElement::isCheckedGetterCallback):
4028         (AccessibilityUIElement::isVisibleGetterCallback):
4029         (AccessibilityUIElement::isOffScreenGetterCallback):
4030         (AccessibilityUIElement::isCollapsedGetterCallback):
4031         (AccessibilityUIElement::hasPopupGetterCallback):
4032         (AccessibilityUIElement::isValidGetterCallback):
4033         (AccessibilityUIElement::orientationGetterCallback):
4034         (AccessibilityUIElement::showMenuCallback):
4035         (AccessibilityUIElement::pressCallback):
4036         (AccessibilityUIElement::isEqualCallback):
4037         (AccessibilityUIElement::addNotificationListenerCallback):
4038         (AccessibilityUIElement::removeNotificationListenerCallback):
4039         (AccessibilityUIElement::takeFocusCallback):
4040         (AccessibilityUIElement::fallbackCallback):
4041         (RootAccessibilityUIElement::getChildAtIndex):
4042         (AccessibilityUIElementList::getOrCreate):
4043         * DumpRenderTree/chromium/AccessibilityUIElement.h:
4044         * DumpRenderTree/chromium/CppVariant.cpp:
4045         (CppVariant::invokeDefault):
4046         * DumpRenderTree/chromium/CppVariant.h:
4047         * DumpRenderTree/chromium/LayoutTestController.cpp:
4048         (LayoutTestController::LayoutTestController):
4049         (LayoutTestController::reset):
4050         * DumpRenderTree/chromium/LayoutTestController.h:
4051         * DumpRenderTree/chromium/WebViewHost.cpp:
4052         (WebViewHost::postAccessibilityNotification):
4053
4054 2011-10-10  Adam Klein  <adamk@chromium.org>
4055
4056         Support Distributed-CompileC as an action name in filter-build-webkit
4057         https://bugs.webkit.org/show_bug.cgi?id=69783
4058
4059         Reviewed by Ojan Vafai.
4060
4061         * Scripts/filter-build-webkit:
4062
4063 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
4064
4065         3D transforms are flattened in WebKit2 snapshots
4066         https://bugs.webkit.org/show_bug.cgi?id=68276
4067
4068         Reviewed by Anders Carlsson.
4069
4070         Use a snapshot of the window, rather than an image from the web process
4071         for pixel testing in WebKitTestRunner. This correctly captures compositing
4072         layers, so works for 3D transform tests.
4073
4074         * WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
4075         * WebKitTestRunner/cg/TestInvocationCG.cpp:
4076         (WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
4077         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
4078         use that instead of the image we get from the web process.
4079         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4080         (WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
4081         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4082         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
4083         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4084         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
4085         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4086         (WTR::PlatformWebView::windowSnapshotImage): Ditto.
4087
4088 2011-10-10  David Levin  <levin@chromium.org>
4089
4090         Quick fix for watchlist unit test failures when using Python 2.7+
4091         Reviewed by Adam Barth.
4092
4093         Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a
4094         better fix.
4095
4096         * Scripts/webkitpy/common/webkitunittest.py: Always use our
4097         version of assertRaisesRegexp.
4098
4099 2011-10-10  Sheriff Bot  <webkit.review.bot@gmail.com>
4100
4101         Unreviewed, rolling out r97082.
4102         http://trac.webkit.org/changeset/97082
4103         https://bugs.webkit.org/show_bug.cgi?id=69784
4104
4105         broke Windows build (Requested by smfr on #webkit).
4106
4107         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
4108         * WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
4109         (WTR::createCGContextFromImage):
4110         (WTR::computeMD5HashStringForContext):
4111         (WTR::dumpBitmap):
4112         (WTR::paintRepaintRectOverlay):
4113         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
4114         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4115         (WTR::PlatformWebView::PlatformWebView):
4116
4117 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
4118
4119         3D transforms are flattened in WebKit2 snapshots
4120         https://bugs.webkit.org/show_bug.cgi?id=68276
4121
4122         Reviewed by Anders Carlsson.
4123
4124         The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
4125         flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
4126         the window when doing pixel tests.
4127
4128         Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
4129
4130         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
4131         * WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
4132         (WTR::createBitmapCGContext): Utility function to create a bitmap context.
4133         (WTR::computeMD5HashStringForContext):
4134         (WTR::dumpBitmap):
4135         (WTR::paintRepaintRectOverlay):
4136         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
4137         grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
4138         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4139         (WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
4140         We need the window to autodisplay for Core Animation to render layers and start animations.
4141
4142 2011-10-10  Simon Fraser  <simon.fraser@apple.com>
4143
4144         WebKitTestRunner needs layoutTestController.setWindowIsKey
4145         https://bugs.webkit.org/show_bug.cgi?id=42688
4146
4147         Reviewed by Anders Carlsson.
4148
4149         Implement layoutTestController.setWindowIsKey() in WebKitTestRunner.
4150         This sets a flag that the platform layer uses to indicate that
4151         the window is the key window, which fixes focus ring drawing
4152         in pixel results.
4153
4154         Also focus the web view when we get a 'didCommitLoad' for the main
4155         frame, as DumpRenderTree does.
4156
4157         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
4158         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
4159         (WTR::InjectedBundle::postSetWindowIsKey):
4160         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
4161         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
4162         (WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum.
4163         (WTR::LayoutTestController::addChromeInputField):
4164         (WTR::LayoutTestController::removeChromeInputField):
4165         (WTR::LayoutTestController::focusWebView):
4166         (WTR::LayoutTestController::setWindowIsKey):
4167         (WTR::LayoutTestController::callAddChromeInputFieldCallback):
4168         (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
4169         (WTR::LayoutTestController::callFocusWebViewCallback):
4170         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
4171         * WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass
4172         so that we can override -isKeyWindow. Use a boolean member variable
4173         to track window key status.
4174         (WTR::PlatformWebView::setWindowIsKey):
4175         (WTR::PlatformWebView::windowIsKey):
4176         * WebKitTestRunner/TestController.cpp:
4177         (WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does.
4178         (WTR::closeOtherPage): Use the same cast as other functions.
4179         (WTR::focus): Implement to call setWindowIsKey(true)
4180         (WTR::unfocus): Implement to call setWindowIsKey(false)
4181         (WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus.
4182         (WTR::TestController::initialize):
4183         (WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does.
4184         * WebKitTestRunner/TestController.h:
4185         * WebKitTestRunner/TestInvocation.cpp:
4186         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
4187         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
4188         (WTR::PlatformWebView::PlatformWebView):
4189         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4190         (-[WebKitTestRunnerWindow isKeyWindow]):
4191         (WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow.
4192         (WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us.
4193         (WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does.
4194         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
4195         (WTR::PlatformWebView::PlatformWebView):
4196         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
4197         (WTR::PlatformWebView::PlatformWebView):
4198
4199 2011-10-10  Raphael Kubo da Costa  <kubo@profusion.mobi>
4200
4201         check-webkit-style: Add readability exception for Ewk_* data types.
4202         https://bugs.webkit.org/show_bug.cgi?id=69763
4203
4204         Reviewed by David Levin.
4205
4206         Many EFL-related files (such as EditorClientEfl.h or
4207         DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
4208         struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
4209         check-webkit-style.
4210
4211         Add an exception for them, just like there are exceptions for
4212         Evas_*, Ecore_* and others.
4213
4214         * Scripts/webkitpy/style/checkers/cpp.py:
4215         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4216
4217 2011-10-10  Dominic Mazzoni  <dmazzoni@google.com>
4218
4219         [Chromium] Get rid of WebAccessibilityCache.
4220         https://bugs.webkit.org/show_bug.cgi?id=68224
4221
4222         Reviewed by Dimitri Glazkov.
4223
4224         * DumpRenderTree/chromium/AccessibilityController.cpp:
4225         (AccessibilityController::bindToJavascript):
4226
4227 2011-10-09  Adam Barth  <abarth@webkit.org>
4228
4229         Remove "near miss" XSS vulnerabilities in garden-o-matic
4230         https://bugs.webkit.org/show_bug.cgi?id=69708
4231
4232         Reviewed by David Levin.
4233
4234         Collin Jackson did a security audit of garden-o-matic.  He hasn't found
4235         any actual vulnerabilities yet, but he did identify a couple "near
4236         misses" where a slight change in garden-o-matic could lead to a
4237         vulnerability.  This patch removes those potential issues.
4238
4239         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
4240         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
4241
4242 2011-10-07  Adam Barth  <abarth@webkit.org>
4243
4244         Add a Content-Security-Policy to garden-o-matic
4245         https://bugs.webkit.org/show_bug.cgi?id=69668
4246
4247         Reviewed by David Levin.
4248
4249         This will help mitigate cross-site script and will also help us dogfood CSP.
4250
4251         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
4252
4253 2011-10-07  Raphael Kubo da Costa  <kubo@profusion.mobi>
4254
4255         [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
4256         https://bugs.webkit.org/show_bug.cgi?id=66380
4257
4258         Reviewed by Antonio Gomes.
4259
4260         This encapsulates EWebKit into an object that manages multiple windows
4261         and provides a cleaner interface to EFL's DumpRenderTree.
4262
4263         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
4264         (DumpRenderTreeChrome::create):
4265         (DumpRenderTreeChrome::DumpRenderTreeChrome):
4266         (DumpRenderTreeChrome::~DumpRenderTreeChrome):
4267         (DumpRenderTreeChrome::createNewWindow):
4268         (DumpRenderTreeChrome::createView):
4269         (DumpRenderTreeChrome::removeWindow):
4270         (DumpRenderTreeChrome::initialize):
4271         (DumpRenderTreeChrome::extraViews):
4272         (DumpRenderTreeChrome::mainFrame):
4273         (DumpRenderTreeChrome::mainView):
4274         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
4275         (DumpRenderTreeChrome::onWindowObjectCleared):
4276         (DumpRenderTreeChrome::onLoadStarted):
4277         (DumpRenderTreeChrome::processWork):
4278         (DumpRenderTreeChrome::onLoadFinished):
4279         (DumpRenderTreeChrome::onStatusbarTextSet):
4280         (DumpRenderTreeChrome::onTitleChanged):
4281         (DumpRenderTreeChrome::onDocumentLoadFinished):
4282         * DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
4283         * DumpRenderTree/efl/EventSender.cpp:
4284         (sendClick): Use browser->mainFrame() instead of mainFrame.
4285         (mouseDownCallback): Ditto.
4286         (mouseUpCallback): Ditto.
4287         (mouseMoveToCallback): Ditto.
4288         (mouseScrollByCallback): Ditto.
4289         (keyDownCallback):