7319fb1b3fcfc7d02f1a4d0c1cbc13726f3f1fdd
[WebKit-https.git] / Tools / ChangeLog
1 2011-01-28  David Kilzer  <ddkilzer@apple.com>
2
3         <rdar://problem/8930699> build-webkit gives a bogus warning with newer versions of Xcode 
4
5         Reviewed by Mark Rowe.
6
7         * Scripts/webkitdirs.pm:
8         (checkRequiredSystemConfig): Check the Xcode marketing version
9         in addition to the DevCoreTools build version before complaining
10         about an old version of Xcode.  Also make the Mac OS X version
11         check use Perl's built-in version string comparitor.
12
13 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
14
15         Unreviewed, build fix.
16
17         Work around breakage on Win 7 Release bot caused by r76982
18         and the fact that windows ports use "file:////" instead of
19         "file:///". Ideally the test code should be isolated from
20         this, but it isn't yet. Will fix properly in a bit.
21
22         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
23
24 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
25
26         Reviewed by Tony Chang.
27
28         new-run-webkit-tests: change worker model values to
29         "old-inline", "old-threads" in preparation for test_runner2 /
30         multiprocessing changes.
31
32         https://bugs.webkit.org/show_bug.cgi?id=53156
33
34         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
35         * Scripts/webkitpy/layout_tests/port/base.py:
36         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
37         * Scripts/webkitpy/layout_tests/port/mac.py:
38         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
39
40 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
41
42         Reviewed by Tony Chang.
43
44         committers.py - add an IRC nickname for dpranke
45         https://bugs.webkit.org/show_bug.cgi?id=53335
46
47         * Scripts/webkitpy/common/config/committers.py:
48
49 2011-01-28  Dirk Pranke  <dpranke@chromium.org>
50
51         Reviewed by Tony Chang.
52
53         new-run-webkit-tests: add a "mock DRT" port implementation
54         and a separate class that emulates what we expect the
55         DumpRenderTree behavior to be.
56
57         This will eventually replace port/dryrun.py and allow us to get
58         better test coverage of the new-run-webkit-tests code as well as
59         a reference for what new-run-webkit-tests expects from DRT.
60
61         This is the first attempt at this, and it is pretty bare-boned. It
62         really only has been tested on the 'mac' port (and a little on
63         the 'chromium-mac' port.
64
65         https://bugs.webkit.org/show_bug.cgi?id=53126
66
67         * Scripts/webkitpy/common/system/filesystem_mock.py:
68         * Scripts/webkitpy/layout_tests/port/dryrun.py:
69         * Scripts/webkitpy/layout_tests/port/factory.py:
70         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
71         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
72         * Scripts/webkitpy/layout_tests/port/test.py:
73
74 2011-01-28  Pratik Solanki  <psolanki@apple.com>
75
76         Unreviewed. Removing .swp file checked in by mistake.
77
78         * Scripts/.webkitdirs.pm.swp: Removed.
79
80 2011-01-28  Pratik Solanki  <psolanki@apple.com>
81
82         Reviewed by David Kilzer.
83
84         Space not necessary for undefined feature
85         https://bugs.webkit.org/show_bug.cgi?id=53317
86
87         * Scripts/build-webkit:
88
89 2011-01-28  Chang Shu  <chang.shu@nokia.com>
90
91         Reviewed by Andreas Kling.
92
93         Reset NetworkAccessManager to clean up credentials from previous tests.
94         This change causes no performance overhead either.
95         https://bugs.webkit.org/show_bug.cgi?id=36688
96
97         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
98         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
99         (WebCore::DumpRenderTree::open):
100         * DumpRenderTree/qt/DumpRenderTreeQt.h:
101
102 2011-01-28  Zoltan Horvath  <zoltan@webkit.org>
103
104         Reviewed by Andreas Kling.
105
106         [Qt] Add Zoom Text Only action to MiniBrowser
107         https://bugs.webkit.org/show_bug.cgi?id=53297
108
109         Add Zoom Text Only action to MiniBrowser's view menu, change zoom levels to avoid unnecessary divides.
110
111         * MiniBrowser/qt/BrowserWindow.cpp:
112         (BrowserWindow::BrowserWindow):
113         (BrowserWindow::zoomIn):
114         (BrowserWindow::zoomOut):
115         (BrowserWindow::resetZoom):
116         (BrowserWindow::toggleZoomTextOnly):
117         (BrowserWindow::applyZoom):
118         * MiniBrowser/qt/BrowserWindow.h:
119
120 2011-01-28  Adam Barth  <abarth@webkit.org>
121
122         Reviewed by Eric Seidel.
123
124         Add webkit-patch roll-chromium-deps
125         https://bugs.webkit.org/show_bug.cgi?id=53288
126
127         This command updates the Source/WebKit/chromium/DEPS file with the
128         last-known good revision of Chromium (or a revision specified on the
129         command line).  I'd eventually like to turn this into a SheriffBot
130         command, but this is the first step.
131
132         This patch somewhat sprawled because I needed to move a bunch of code
133         out of ChangeLog that should never have been there in the first place.
134         Also, I had to fix a bug in MockUser in order to test the new command.
135
136         * Scripts/webkitpy/common/checkout/api.py:
137         * Scripts/webkitpy/common/checkout/changelog.py:
138         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
139         * Scripts/webkitpy/common/checkout/deps.py: Added.
140         * Scripts/webkitpy/common/config/urls.py:
141         * Scripts/webkitpy/tool/commands/__init__.py:
142         * Scripts/webkitpy/tool/commands/download_unittest.py:
143         * Scripts/webkitpy/tool/commands/roll.py: Added.
144         * Scripts/webkitpy/tool/commands/roll_unittest.py: Added.
145         * Scripts/webkitpy/tool/commands/upload_unittest.py:
146         * Scripts/webkitpy/tool/mocktool.py:
147         * Scripts/webkitpy/tool/steps/__init__.py:
148         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py: Added.
149         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
150         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py: Added.
151         * Scripts/webkitpy/tool/steps/suggestreviewers_unittest.py:
152         * Scripts/webkitpy/tool/steps/updatechromiumdeps.py: Added.
153         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
154
155 2011-01-27  Greg Coletta  <greg.coletta@nokia.com>
156
157         Reviewed by Laszlo Gombos.
158
159         Get rid of prefix header dependency for WebKit2 build system
160         https://bugs.webkit.org/show_bug.cgi?id=50174
161
162         Change the style checker so that it enforces config.h include for
163         WebKit2.
164
165         * Scripts/webkitpy/style/checker.py:
166
167 2011-01-27  Maciej Stachowiak  <mjs@apple.com>
168
169         Reviewed by Darin Adler.
170
171         execCommand("Paste") doesn't work in WebKitTestRunner
172         https://bugs.webkit.org/show_bug.cgi?id=52785
173
174         Enable both of the settings needed to allow paste.
175         
176         * WebKitTestRunner/TestController.cpp:
177         (WTR::TestController::resetStateToConsistentValues):
178
179 2011-01-27  Jacob Dinu  <dinu.jacob@nokia.com>
180
181         Reviewed by Andreas Kling.
182
183         [Qt] QtTestBrowser: User input lost when toggling use of QGraphicsView
184         https://bugs.webkit.org/show_bug.cgi?id=48440
185
186         Preserve user input when toggling use of QGraphicsView
187
188         * QtTestBrowser/launcherwindow.cpp:
189         (LauncherWindow::initializeView):
190         (LauncherWindow::loadFinished):
191         * QtTestBrowser/launcherwindow.h:
192         * QtTestBrowser/mainwindow.cpp:
193         (MainWindow::addressUrl):
194         * QtTestBrowser/mainwindow.h:
195
196 2011-01-27  Dirk Pranke  <dpranke@chromium.org>
197
198         Reviewed by Mihai Parparita.
199
200         new-run-webkit-tests: turn off pixel tests correctly by default
201         for webkit-based ports. r70013 (bug 47510) used
202         port.set_option_default() to attempt to set default values, but
203         that didn't work correctly. I have removed set_option_default
204         for now since it was only being used in two places and in three
205         useless unit tests. There is a separate bug open to fix the
206         option parsing (48095), so this workaround is fine for now.
207
208         https://bugs.webkit.org/show_bug.cgi?id=53217
209
210         * Scripts/webkitpy/layout_tests/port/webkit.py:
211         * Scripts/webkitpy/layout_tests/port/base.py:
212         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
213
214 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
215
216         Rubber-stamped by Ariya Hidayat.
217
218         Trivial crash fix in WTR.
219
220         * WebKitTestRunner/TestController.cpp:
221         (WTR::TestController::initialize): Increase the size
222         of the vector by one to be able to store the null character.
223
224 2011-01-27  Balazs Kelemen  <kbalazs@webkit.org>
225
226         Reviewed by Csaba Osztrogonác.
227
228         [Qt][WK2] WTR should be initialized in the same way as DRT
229         https://bugs.webkit.org/show_bug.cgi?id=53240
230
231         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
232         (WTR::activateFonts): Added missing initialization steps.
233
234 2011-01-27  Joone Hur <joone.hur@collabora.co.uk>
235
236         Unreviewed. 
237
238         Adding myself to committers.py.
239
240         * Scripts/webkitpy/common/config/committers.py:
241
242 2011-01-27  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
243
244         Reviewed by Csaba Osztrogonác.
245
246         [Qt] [Symbian] Move project files into Source
247         https://bugs.webkit.org/show_bug.cgi?id=52891
248
249         Fix the Symbian build after the project files
250         are moved to Source directory. On Symbian qmake
251         needs to run in the same directory where the main
252         pro files (WebKit.pro, Tools.pro) are located.
253
254         * Scripts/webkitdirs.pm: Change to the directory where the pro file
255         is located before running qmake for Symbian. Qmake on Symbian
256         does not properly honor the "-o" option, work it around by setting
257         the name of the Makefile to bld.inf.
258
259 2011-01-27  Zoltan Horvath  <zoltan@webkit.org>
260
261         Reviewed by Andreas Kling.
262
263         [Qt] Add simple zooming features to MiniBrowser
264         https://bugs.webkit.org/show_bug.cgi?id=53231
265
266         Add View menu and Zoom In, Zoom Out, Zoom Reset actions to MiniBrowser.
267
268         * MiniBrowser/qt/BrowserWindow.cpp:
269         (BrowserWindow::BrowserWindow):
270         (BrowserWindow::zoomIn):
271         (BrowserWindow::zoomOut):
272         (BrowserWindow::resetZoom):
273         (BrowserWindow::updateUserAgentList):
274         (BrowserWindow::applyZoom):
275         * MiniBrowser/qt/BrowserWindow.h:
276
277 2011-01-26  Maciej Stachowiak  <mjs@apple.com>
278
279         Reviewed by Dan Bernstein.
280
281         WebKitTestRunner needs to support layoutTestController.evaluateInWebInspector
282         https://bugs.webkit.org/show_bug.cgi?id=42319
283         
284         Add evaluateInWebInspector and other APIs needed for inspector tests to run.
285
286         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
287         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
288         (WTR::LayoutTestController::showWebInspector):
289         (WTR::LayoutTestController::closeWebInspector):
290         (WTR::LayoutTestController::evaluateInWebInspector):
291         (WTR::LayoutTestController::setTimelineProfilingEnabled):
292         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
293         * WebKitTestRunner/TestInvocation.cpp:
294         (WTR::shouldOpenWebInspector):
295         (WTR::TestInvocation::invoke):
296         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
297
298 2011-01-26  Martin Robinson  <mrobinson@igalia.com>
299
300         Reviewed by Xan Lopez.
301
302         [GTK] Pixel dumps do not include scrollbars in output images
303         https://bugs.webkit.org/show_bug.cgi?id=53216
304
305         Show scrollbars in pixel dumps. This will fix pixel dumps for tests
306         that have scrollbars.
307
308         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
309         (createBitmapContextFromWebView): Take the snapshot of the containing GtkScrolledWindow
310         instead of the web view itself.
311
312 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
313
314         Reviewed by Mihai Parparita.
315
316         Fix regression introduced in r76322 ... new-run-webkit-tests
317         was attempting to save the image diff output as a UTF-8-encoded
318         file.
319
320         https://bugs.webkit.org/show_bug.cgi?id=53210
321
322         * Scripts/webkitpy/layout_tests/port/webkit.py:
323
324 2011-01-26  Sheriff Bot  <webkit.review.bot@gmail.com>
325
326         Unreviewed, rolling out r76709.
327         http://trac.webkit.org/changeset/76709
328         https://bugs.webkit.org/show_bug.cgi?id=53194
329
330         "broke python tests on non-snowleopard platforms" (Requested
331         by dpranke on #webkit).
332
333         * Scripts/webkitpy/layout_tests/port/factory.py:
334         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Removed.
335         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Removed.
336
337 2011-01-26  Dirk Pranke  <dpranke@chromium.org>
338
339         Reviewed by Tony Chang.
340
341         new-run-webkit-tests: add a "mock DRT" port implementation
342         and a separate class that emulates what we expect the
343         DumpRenderTree behavior to be.
344
345         This will eventually replace port/dryrun.py and allow us to get
346         better test coverage of the new-run-webkit-tests code as well as
347         a reference for what new-run-webkit-tests expects from DRT.
348
349         This is the first attempt at this, and it is pretty bare-boned. It
350         really only has been tested on the 'mac' port (and a little on
351         the 'chromium-mac' port.
352
353         https://bugs.webkit.org/show_bug.cgi?id=53126
354
355         * Scripts/webkitpy/layout_tests/port/mock_drt.py: Added.
356         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py: Added.
357         * Scripts/webkitpy/layout_tests/port/factory.py:
358
359 2011-01-26  Xianzhu Wang  <wangxianzhu@google.com>
360
361         Reviewed by Tony Chang.
362
363         Add '--no-timeout' option to Chromium DRT to ease debugging.
364         https://bugs.webkit.org/show_bug.cgi?id=52873
365
366         * DumpRenderTree/chromium/DumpRenderTree.cpp:
367         (main):
368
369 2011-01-26  Csaba Osztrogonác  <ossy@webkit.org>
370
371         Reviewed by Andreas Kling.
372
373         [Qt] Fix qt_minimal build
374         https://bugs.webkit.org/show_bug.cgi?id=53172
375
376         * QtTestBrowser/locationedit.h:
377
378 2011-01-26  Mansi Mithal  <mansi.mithal@nokia.com>
379
380         Reviewed by Antonio Gomes.
381
382         QtTestBrowser should have a UI Setting to disable plugins
383         https://bugs.webkit.org/show_bug.cgi?id=52408
384         
385         Added a new action item named "Disable Plugins"
386         under the "Settings" menu. 
387
388         * QtTestBrowser/launcherwindow.cpp:
389         (LauncherWindow::createChrome):
390         (LauncherWindow::togglePlugins):
391         * QtTestBrowser/launcherwindow.h:
392
393 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
394
395         Reviewed by Adam Barth.
396
397         Move main CMakeLists.txt into Source directory
398         https://bugs.webkit.org/show_bug.cgi?id=52888
399
400         * Scripts/webkitdirs.pm:
401
402 2011-01-25  Patrick Gansterer  <paroga@webkit.org>
403
404         Reviewed by Eric Seidel.
405
406         Improve label text in submit-to-ews
407         https://bugs.webkit.org/show_bug.cgi?id=53130
408
409         * QueueStatusServer/templates/submittoews.html:
410
411 2011-01-25  Mansi Mithal  <mansi.mithal@nokia.com>
412
413         Reviewed by Antonio Gomes.
414
415         QtTestBrowser should have a UI Settings to prevent loading images
416         https://bugs.webkit.org/show_bug.cgi?id=52409
417         
418         Added a new action item named "DisableAutoLoadImages"
419         under the "Settings" menu 
420
421         * QtTestBrowser/launcherwindow.cpp:
422         (LauncherWindow::createChrome):
423         (LauncherWindow::toggleAutoLoadImages):
424         * QtTestBrowser/launcherwindow.h:
425
426 2011-01-25  Dirk Pranke  <dpranke@chromium.org>
427
428         Reviewed by Tony Chang.
429
430         Minor bug fixes and cleanup for filesystem wrappers, port/* test
431         classes, test_expectations.py. This change adds "test-win" and
432         "test-mac" variants to the test port so that we can better test
433         rebaselining, and adds a MockUser() object for reuse in testing.
434
435         https://bugs.webkit.org/show_bug.cgi?id=53036
436
437         * Scripts/webkitpy/common/system/filesystem.py:
438         * Scripts/webkitpy/common/system/filesystem_mock.py:
439         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
440         * Scripts/webkitpy/layout_tests/port/factory.py:
441         * Scripts/webkitpy/layout_tests/port/base.py:
442         * Scripts/webkitpy/layout_tests/port/test.py:
443         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
444         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
445         * Scripts/webkitpy/tool/mocktool.py:
446
447 2011-01-25  Tony Chang  <tony@chromium.org>
448
449         Reviewed by Dimitri Glazkov.
450
451         [chromium] remove unused layoutTestController callback
452         https://bugs.webkit.org/show_bug.cgi?id=53103
453
454         This method is used by a test_shell_test, but not needed by DRT.
455
456         * DumpRenderTree/chromium/LayoutTestController.cpp:
457         (LayoutTestController::LayoutTestController):
458         * DumpRenderTree/chromium/LayoutTestController.h:
459
460 2011-01-25  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
461
462         Reviewed by Andreas Kling.
463
464         [GTK] Remove 64 bits release bot from the buildbot master
465         https://bugs.webkit.org/show_bug.cgi?id=52899
466
467         Removes the 64 bits release slave from the buildbot configuration,
468         so that we can use it as an EWS.
469
470         * BuildSlaveSupport/build.webkit.org-config/config.json:
471
472 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
473
474         Reviewed by Dan Bernstein.
475
476         Implement database quota callback to fix storage tests on WebKit2 bot
477         https://bugs.webkit.org/show_bug.cgi?id=53064
478
479         * WebKitTestRunner/TestController.cpp:
480         (WTR::exceededDatabaseQuota):
481         (WTR::TestController::createOtherPage):
482         (WTR::TestController::initialize):
483
484 2011-01-24  Maciej Stachowiak  <mjs@apple.com>
485
486         Reviewed by Anders Carlsson.
487
488         Use designated temp directory for the database for WebKit2
489         https://bugs.webkit.org/show_bug.cgi?id=53052
490         
491         Adopt the new WK2 API for this.
492
493         * WebKitTestRunner/TestController.cpp:
494         (WTR::TestController::libraryPathForTesting):
495         (WTR::TestController::initialize):
496         * WebKitTestRunner/TestController.h:
497         * WebKitTestRunner/mac/TestControllerMac.mm:
498         (WTR::TestController::platformLibraryPathForTesting):
499         * WebKitTestRunner/qt/TestControllerQt.cpp:
500         (WTR::TestController::platformLibraryPathForTesting):
501         * WebKitTestRunner/win/TestControllerWin.cpp:
502         (WTR::TestController::platformLibraryPathForTesting):
503
504 2011-01-24  Lucas Forschler  <lforschler@apple.com>
505
506         Reviewed by Stephanie Lewis.
507
508         Add a new Leopard test bot.
509
510         * BuildSlaveSupport/build.webkit.org-config/config.json:
511
512 2011-01-24  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
513
514         Reviewed by Adam Barth.
515
516         Add EFL Builder to core waterfall
517         https://bugs.webkit.org/show_bug.cgi?id=52704
518
519         Add EFL Builder to the core waterfall again.
520
521         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
522         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
523
524 2011-01-24  Xianzhu Wang  <wangxianzhu@google.com>
525
526         Reviewed by Tony Chang.
527
528         new-run-webkit-tests fails to start HTTP server if there are proxy settings
529         https://bugs.webkit.org/show_bug.cgi?id=52872
530
531         Force disabling proxy to resolve the problem.
532
533         * Scripts/webkitpy/layout_tests/port/http_server_base.py:
534         * Scripts/webkitpy/layout_tests/port/websocket_server.py:
535
536 2011-01-24  Andreas Kling  <kling@webkit.org>
537
538         Reviewed by Darin Adler.
539
540         check-webkit-style: Update exemptions following Source/ move.
541         https://bugs.webkit.org/show_bug.cgi?id=53017
542
543         * Scripts/webkitpy/style/checker.py:
544         * Scripts/webkitpy/style/checker_unittest.py:
545
546 2011-01-24  Andras Becsi  <abecsi@webkit.org>
547
548         Rubber-stamped by Csaba Osztrogonác.
549
550         [Qt] Move project files into Source
551         https://bugs.webkit.org/show_bug.cgi?id=52891
552
553         * DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
554
555 2011-01-24  Mikhail Naganov  <mnaganov@chromium.org>
556
557         Reviewed by Yury Semikhatsky.
558
559         Web Inspector: Find duplicate strings in localizedStrings.js
560
561         https://bugs.webkit.org/show_bug.cgi?id=53005
562
563         * Scripts/check-inspector-strings:
564
565 2011-01-24  Zoltan Horvath  <zoltan@webkit.org>
566
567         Reviewed by Andreas Kling.
568
569         [Qt] Regroup MiniBrowser's menubar and add open file action
570         https://bugs.webkit.org/show_bug.cgi?id=53000
571
572         Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
573
574         * MiniBrowser/qt/BrowserWindow.cpp:
575         (BrowserWindow::BrowserWindow):
576         (BrowserWindow::openFile):
577         (BrowserWindow::~BrowserWindow):
578         * MiniBrowser/qt/BrowserWindow.h:
579
580 2011-01-24  Csaba Osztrogonác  <ossy@webkit.org>
581
582         Unreviewed fix after r76496
583
584         [Qt] Move project files into Source
585         https://bugs.webkit.org/show_bug.cgi?id=52891
586
587         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
588         * BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
589         * Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
590
591 2011-01-24  Andras Becsi  <abecsi@webkit.org>
592
593         Reviewed by Csaba Osztrogonác.
594
595         [Qt] Move project files into Source
596         https://bugs.webkit.org/show_bug.cgi?id=52891
597
598         * DerivedSources.pro: Renamed from DerivedSources.pro.
599         * DumpRenderTree/qt/DumpRenderTree.pro:
600         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
601         * MiniBrowser/DerivedSources.pro:
602         * MiniBrowser/qt/MiniBrowser.pro:
603         * QtTestBrowser/QtTestBrowser.pro:
604         * Scripts/webkitdirs.pm:
605         * Tools.pro: Added.
606         * WebKitTestRunner/DerivedSources.pro:
607         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
608         * WebKitTestRunner/qt/WebKitTestRunner.pro:
609
610 2011-01-22  Geoffrey Garen  <ggaren@apple.com>
611
612         Reviewed by Dan Bernstein.
613
614         Beefed up --threaded mode to catch even more kinds of errors.
615         https://bugs.webkit.org/show_bug.cgi?id=52971
616
617         * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Use a shared
618         context group to force JSC to mark multiple threads. (This used to be
619         the default, but it changed in SnowLeopard.)
620         (runJavaScriptThread): Do more locking and unlocking, and more allocation,
621         to give threading mistakes more chances to show themselves.
622         (startJavaScriptThreads):
623         (stopJavaScriptThreads):
624
625 2011-01-22  Robert Hogan  <robert@webkit.org>
626
627         Reviewed by Andreas Kling.
628
629         [Qt] Support layoutTestController.addURLToRedirect()
630         https://bugs.webkit.org/show_bug.cgi?id=52956
631
632         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
633         (LayoutTestController::addURLToRedirect):
634         * DumpRenderTree/qt/LayoutTestControllerQt.h:
635
636 2011-01-22  Robert Hogan  <robert@webkit.org>
637
638         Reviewed by Kenneth Rohde Christiansen.
639
640         [Qt] REGRESSION (r72360): http/tests/security/aboutBlank/xss-DENIED-* tests fail
641         https://bugs.webkit.org/show_bug.cgi?id=49802
642
643         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
644         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
645         (WebCore::DumpRenderTree::open):
646
647 2011-01-21  Adam Barth  <abarth@webkit.org>
648
649         Reviewed by Maciej Stachowiak.
650
651         Disable mac_unittest.py that fails on some of the Mac bots
652         https://bugs.webkit.org/show_bug.cgi?id=52947
653
654         As noted in the comment, this test does not appear to be correct
655         because the function this test is testing returns different results
656         depending on which flavor of Mac the test is run on.  This patch
657         disable the test.  Hopefully we can re-enable the test once we've
658         probably insulated the test from its environment.
659
660         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
661
662 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
663
664         Reviewed by Mihai Parparita.
665
666         Fix bug introduced in r76322 that caused NRWT to not actually
667         read the Skipped files properly.
668
669         https://bugs.webkit.org/show_bug.cgi?id=52771
670
671         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
672         * Scripts/webkitpy/layout_tests/port/webkit.py:
673         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
674
675 2011-01-21  Sam Weinig  <sam@webkit.org>
676
677         Reviewed by Geoffrey Sean Garen and Mark Rowe.
678
679         WebKitTestRunner needs the HOME environment variable to be set.
680         <rdar://problem/8896573>
681
682         * Scripts/old-run-webkit-tests: Set the HOME environment variable if
683         it exists.
684
685 2011-01-21  Dirk Pranke  <dpranke@chromium.org>
686
687         Reviewed by Eric Seidel.
688
689         Suppress a few remaining integration tests so that none of the
690         layout_test unit tests ever read from the filesystem or launch
691         subprocesses that aren't part of the unit tests.
692
693         Also fix a minor bug in the printing unit tests that was
694         incorrectly relying on sys.argv.
695
696         https://bugs.webkit.org/show_bug.cgi?id=52863
697
698         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
699         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
700         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
701
702 2011-01-21  Darin Adler  <darin@apple.com>
703
704        Fix Mac build.
705
706         * MiniBrowser/mac/BrowserWindowController.m:
707         (-[BrowserWindowController awakeFromNib]): Pass 0 for runModal function.
708
709 2011-01-20  Darin Adler  <darin@apple.com>
710
711         Reviewed by Dan Bernstein.
712
713         WebKit2: Implement showModalDialog
714         https://bugs.webkit.org/show_bug.cgi?id=52855
715
716         This fixes WebKitTestRunner to compile, but more work is probably
717         needed to get it to pass the tests.
718
719         * WebKitTestRunner/TestController.cpp:
720         (WTR::TestController::runModal): Added. Calls through to the
721         platform-specific version of runModal.
722         (WTR::TestController::createOtherPage): Changed to be a private
723         static member function so it can refer to runModal, which is
724         a private static member function.
725         (WTR::TestController::initialize): Pass 0 for the runModal
726         function since we don't need to run the main window modal.
727         I suspect this is wrong and will need to change.
728         * WebKitTestRunner/TestController.h: Added declarations for
729         the functions added above.
730         * WebKitTestRunner/mac/TestControllerMac.mm:
731         (WTR::TestController::runModal): Added. Untested implementation.
732         * WebKitTestRunner/qt/TestControllerQt.cpp:
733         (WTR::TestController::runModal): Added.
734         * WebKitTestRunner/win/TestControllerWin.cpp:
735         (WTR::TestController::runModal): Added.
736
737 2011-01-21  Eric Seidel  <eric@webkit.org>
738
739         Reviewed by Adam Barth.
740
741         Split Host object off from WebKitPatch for easier re-use
742         https://bugs.webkit.org/show_bug.cgi?id=52284
743
744         new-run-webkit-tests and other tools are eventually going to want one of these.
745         Basically you need to inherit from this class if you want to pretend to be a
746         self.tool object for Steps/Commands.
747
748         * Scripts/webkitpy/common/host.py: Added.
749         * Scripts/webkitpy/tool/main.py:
750
751 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
752
753         Reviewed by Adam Barth.
754
755         Disable the tests that start and stop the http server and web
756         server, so that we don't have to worry about port collisions on
757         the bots.
758
759         https://bugs.webkit.org/show_bug.cgi?id=52861
760
761         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
762
763 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
764
765         Reviewed by Eric Seidel.
766
767         nrwt: rewrite google_chrome_unittest to use mock filesystem.
768         
769         https://bugs.webkit.org/show_bug.cgi?id=52772
770         
771         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
772
773 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
774
775         Reviewed by Eric Siedel.
776
777         nrwt: clean up almost all remaining port references, remove
778         unnecessary import clauses. The only remaining references are
779         in places where a mock filesystem makes no sense or can't be
780         used, and in one routine in port/google_chrome_unittest that
781         I'll rewrite in a separate patch.
782
783         https://bugs.webkit.org/show_bug.cgi?id=52771
784
785         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
786         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
787         * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
788         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
789         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
790         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
791         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
792         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
793         * Scripts/webkitpy/layout_tests/port/google_chrome.py:
794         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
795         * Scripts/webkitpy/layout_tests/port/gtk.py:
796         * Scripts/webkitpy/layout_tests/port/mac.py:
797         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
798         * Scripts/webkitpy/layout_tests/port/qt.py:
799         * Scripts/webkitpy/layout_tests/port/webkit.py:
800         * Scripts/webkitpy/layout_tests/port/win.py:
801         * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
802
803 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
804
805         Reviewed by Mihai Parparita.
806
807         remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests
808
809         https://bugs.webkit.org/show_bug.cgi?id=52762
810
811         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
812         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
813
814 2011-01-20  Tony Chang  <tony@chromium.org>
815
816         Reviewed by Ojan Vafai.
817
818         [chromium] fix the paths used for the rebaseline tool
819         https://bugs.webkit.org/show_bug.cgi?id=52857
820
821         Some of the bots were renamed so the path to grab the results zip
822         file has changed.
823
824         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
825
826 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
827
828         Reviewed by Tony Chang.
829
830         Fix bug introduced in r72688 / bug 52768 that broke the
831         generation of the output filename links in the results.html
832         output. Apparently none of the unit tests actually checked to
833         make sure the generated links were correct :(
834
835         https://bugs.webkit.org/show_bug.cgi?id=52854
836
837         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
838         * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
839
840 2011-01-20  Alexey Proskuryakov  <ap@apple.com>
841
842         Reviewed by Darin Adler.
843
844         https://bugs.webkit.org/show_bug.cgi?id=52849
845         Make window.print work with WebKit2
846
847         * MiniBrowser/mac/BrowserWindowController.m:
848         (-[BrowserWindowController awakeFromNib]):
849         * WebKitTestRunner/TestController.cpp:
850         (WTR::createOtherPage):
851         (WTR::TestController::initialize):
852         Added zeroes to WKPageUIClient structures to avoid build failures.
853
854 2011-01-20  Dirk Pranke  <dpranke@chromium.org>
855
856         Reviewed by Eric Seidel.
857
858         nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff
859
860         https://bugs.webkit.org/show_bug.cgi?id=52756
861
862         * Scripts/webkitpy/layout_tests/layout_package/printing.py:
863         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
864         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
865         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
866         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
867         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
868
869 2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>
870
871         Reviewed by Antonio Gomes.
872
873         QtTestBrowser should have a seperate menu for Settings
874         https://bugs.webkit.org/show_bug.cgi?id=52817
875         
876         Added a new menu item named "Settings"
877         and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu 
878
879         * QtTestBrowser/launcherwindow.cpp:
880         (LauncherWindow::createChrome):
881
882 2011-01-20  Sam Weinig  <sam@webkit.org>
883
884         Reviewed by John Sullivan.
885
886         Update update-webkit-localizable-strings with new path to WebKit.
887
888         * Scripts/update-webkit-localizable-strings:
889
890 2011-01-20  James Robinson  <jamesr@chromium.org>
891
892         Reviewed by Darin Fisher.
893
894         Implement mozilla's requestAnimationFrame API
895         https://bugs.webkit.org/show_bug.cgi?id=51218
896
897         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
898
899         * DumpRenderTree/chromium/WebViewHost.cpp:
900         (invokeScheduleComposite):
901         (WebViewHost::scheduleAnimation):
902         (WebViewHost::paintInvalidatedRegion):
903         * DumpRenderTree/chromium/WebViewHost.h:
904
905 2011-01-20  Maciej Stachowiak  <mjs@apple.com>
906
907         Reviewed by Adam Roben.
908
909         WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
910         https://bugs.webkit.org/show_bug.cgi?id=42327
911
912         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
913         for methods that take their normal arguments but also a JSContextRef.
914         * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
915         for evaluateScriptInIsolatedWorld.
916         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
917         (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
918         this call is for an isolated world.
919         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
920         (WTR::worldMap): Helper to create a world map.
921         (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
922         (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
923         added LayoutTestController API.
924         * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
925
926 2011-01-19  Adam Roben  <aroben@apple.com>
927
928         Convert paths in environment variables back to msys-style inside commit-log-editor
929
930         When this script gets run from inside git commit, msys-style paths in the environment will
931         have been turned into Windows-style paths with forward slashes. This screws up functions
932         like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
933         the paths back to msys-style before doing anything else.
934
935         Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
936         using msysgit's Perl and multiple ChangeLogs have been edited
937
938         Reviewed by David Kilzer.
939
940         * Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
941         (fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
942         inside git commit), convert Windows-style paths in the environment back to msys-style paths.
943
944 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
945
946         [Win] Unreviewed build fix after r76248.
947
948         * DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.
949
950 2011-01-20  Zoltan Horvath  <zoltan@webkit.org>
951
952         Reviewed by Csaba Osztrogonác.
953
954         Refactoring of the custom allocation framework
955         https://bugs.webkit.org/show_bug.cgi?id=49897
956
957         Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
958         The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
959         equivalent macro implementation at the necessary places.
960 2011-01-20  Yi Shen  <yi.4.shen@nokia.com>
961
962         Unreviewed. 
963
964         Adding myself to committers.py.
965
966         * Scripts/webkitpy/common/config/committers.py:
967
968 2011-01-20  Adam Barth  <abarth@webkit.org>
969
970         Reviewed by Tony Chang.
971
972         Chromium builders don't delete unversioned directories when DEPS change
973         https://bugs.webkit.org/show_bug.cgi?id=52745
974
975         If we pass this option to gclient sync, gclient will delete directories
976         that are no longer part of DEPS instead of leaving them around to
977         confuse us later.  Apparently, the downstream buildbots use this option
978         already.
979
980         * Scripts/update-webkit-chromium:
981
982 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
983
984         Unreviewed, build fix - I pulled this patch in to fix an issue
985         revealed by r76195 running on some new bots). Also fix a couple
986         of other issues revealed in testing.
987
988         nrwt: remove fs refs from layout_package/json*
989
990         https://bugs.webkit.org/show_bug.cgi?id=52754
991
992         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
993         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
994         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
995         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
996         * Scripts/webkitpy/layout_tests/port/base.py:
997
998 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
999
1000         Unreviewed, build fix.
1001
1002         Fix a couple of minor bugs discovered while bringing up new bots
1003         for testing.
1004
1005         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1006         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1007
1008 2011-01-19  James Robinson  <jamesr@chromium.org>
1009
1010         Unreviewed, rolling out r76194.
1011         http://trac.webkit.org/changeset/76194
1012         https://bugs.webkit.org/show_bug.cgi?id=51218
1013
1014         Caused mysterious compile failure on the chromium win
1015         build.webkit.org bots
1016
1017         * DumpRenderTree/chromium/WebViewHost.cpp:
1018         (WebViewHost::paintInvalidatedRegion):
1019         * DumpRenderTree/chromium/WebViewHost.h:
1020
1021 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1022
1023         Reviewed by Mihai Parparita.
1024
1025         remove fs refs from test_runner, dump_render_tree_thread
1026
1027         https://bugs.webkit.org/show_bug.cgi?id=52753
1028
1029         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1030         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1031         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
1032         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1033
1034 2011-01-19  James Robinson  <jamesr@chromium.org>
1035
1036         Reviewed by Darin Fisher.
1037
1038         Implement mozilla's requestAnimationFrame API
1039         https://bugs.webkit.org/show_bug.cgi?id=51218
1040
1041         Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.
1042
1043         * DumpRenderTree/chromium/WebViewHost.cpp:
1044         (invokeScheduleComposite):
1045         (WebViewHost::scheduleAnimation):
1046         (WebViewHost::paintInvalidatedRegion):
1047         * DumpRenderTree/chromium/WebViewHost.h:
1048
1049 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1050
1051         Unreviewed, build fix.
1052
1053         Fix a few incorrect "self._filesystem" references introduced in
1054         r76184.
1055
1056         * Scripts/webkitpy/layout_tests/port/chromium.py:
1057         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1058
1059 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1060
1061         Reviewed by Mihai Parparita.
1062
1063         add a .sep property, abspath(), isabs(), mtime(), and
1064         open_text_file_for_writing() to filesystem modules. Some of
1065         these properties are not needed in this patch but will be needed
1066         in subsequent patches (I'm doing this to avoid having to track
1067         multiple versions of a single file).
1068
1069         Also, change most of the port/* modules to use the filesystem
1070         objects instead of referencing the filesystem directly.
1071
1072         https://bugs.webkit.org/show_bug.cgi?id=52748
1073
1074         * Scripts/webkitpy/common/system/filesystem.py:
1075         * Scripts/webkitpy/common/system/filesystem_mock.py:
1076         * Scripts/webkitpy/layout_tests/port/__init__.py:
1077         * Scripts/webkitpy/layout_tests/port/base.py:
1078         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1079         * Scripts/webkitpy/layout_tests/port/chromium.py:
1080         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1081         * Scripts/webkitpy/layout_tests/port/config.py:
1082         * Scripts/webkitpy/layout_tests/port/test.py:
1083         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1084
1085 2011-01-19  Maciej Stachowiak  <mjs@apple.com>
1086
1087         Reviewed by Anders Carlsson.
1088
1089         If resetting between tests times out, treat it as a WebProcess crash
1090         https://bugs.webkit.org/show_bug.cgi?id=52757
1091
1092         * WebKitTestRunner/TestController.cpp:
1093         (WTR::TestController::runTest):
1094
1095 2011-01-19  Alexey Proskuryakov  <ap@apple.com>
1096
1097         Reviewed by Darin Adler.
1098
1099         https://bugs.webkit.org/show_bug.cgi?id=52739
1100         Make it possible for a WebKit2 client to print headers and footers
1101
1102         Added dummy implementations for new printing UIClient calls.
1103
1104         * MiniBrowser/mac/BrowserWindowController.m:
1105         (-[BrowserWindowController awakeFromNib]):
1106         * WebKitTestRunner/TestController.cpp:
1107         (WTR::createOtherPage):
1108         (WTR::TestController::initialize):
1109
1110 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1111
1112         Reviewed by Ojan Vafai.
1113
1114         Change webkitpy/layout_tests/port/test.py to use the
1115         in-memory filesystem for cleaner unit testing. This
1116         change allows us to kill a lot of code that was
1117         specific to the test port, at the cost of being a
1118         little less clear about how things would work if
1119         you didn't have a filesystem.
1120
1121         https://bugs.webkit.org/show_bug.cgi?id=52605
1122
1123         * Scripts/webkitpy/layout_tests/port/test.py:
1124
1125 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1126
1127         Unreviewed, build fix.
1128
1129         Fix test failure caused by committing attachment 79368 instead
1130         of attachment 79461 on bug 52604.
1131
1132         * Scripts/webkitpy/common/system/filesystem_mock.py:
1133
1134 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1135
1136         Reviewed by Mihai Parparita.
1137
1138         new-run-webkit-tests: remove use of os.walk, use mock filesystem for better
1139         unit testing. os.walk() is too much of a hassle to implement on
1140         top of the in-memory mock filesystem and adding the necessary
1141         interface to files_under() gives clients a cleaner API anyway
1142         (for this particular usage model).
1143
1144         https://bugs.webkit.org/show_bug.cgi?id=52691
1145
1146         * Scripts/webkitpy/common/system/filesystem.py:
1147         * Scripts/webkitpy/common/system/filesystem_mock.py:
1148         * Scripts/webkitpy/layout_tests/port/test_files.py:
1149         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1150
1151 2011-01-19  Dirk Pranke  <dpranke@chromium.org>
1152
1153         Reviewed by Tony Chang.
1154
1155         Change more modules in the layout-tests code to use the
1156         filesystem wrapper for cleaner unit testing.
1157
1158         This patch also adds the glob() wrapper to the filesystem
1159         abstraction.
1160         
1161         https://bugs.webkit.org/show_bug.cgi?id=52604
1162
1163         * Scripts/webkitpy/layout_tests/port/test_files.py:
1164         * Scripts/webkitpy/layout_tests/port/test_files_unittest.py:
1165         * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
1166         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
1167         * Scripts/webkitpy/common/system/filesystem.py:
1168         * Scripts/webkitpy/common/system/filesystem_mock.py:
1169
1170 2011-01-19  Levi Weintraub  <leviw@chromium.org>
1171
1172         Unreviewed.
1173
1174         Updating my email addresses and irc nick.
1175
1176         * Scripts/webkitpy/common/config/committers.py:
1177
1178 2011-01-19  Tony Chang  <tony@chromium.org>
1179
1180         Reviewed by Mihai Parparita.
1181
1182         [chromium] [linux] if check-sys-deps fails, output the failure reason
1183         https://bugs.webkit.org/show_bug.cgi?id=52671
1184
1185         * Scripts/webkitpy/common/system/executive_mock.py: Add support for
1186             error handler functions.
1187         * Scripts/webkitpy/layout_tests/port/chromium.py:
1188             output the error text from --check-sys-deps
1189         * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
1190
1191 2011-01-19  Aparna Nandyal  <aparna.nand@wipro.com>
1192
1193         Reviewed by Andreas Kling.
1194
1195         [Qt] QtTestBrowser crashes when closing if Facebook is opened
1196         https://bugs.webkit.org/show_bug.cgi?id=52554
1197         
1198         QtNetworkAccessManager is created in a thread and set as
1199         member variable in QWebPage. When the thread is destroyed
1200         the object is still used. So fix will set the object to
1201         NULL once the thread is destroyed.
1202
1203         * QtTestBrowser/launcherwindow.cpp:
1204         (LauncherWindow::~LauncherWindow):
1205
1206 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1207
1208         Rubber stamped by Csaba Osztrogonac
1209
1210         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Removed unncessary inculde of WKStringCF.h
1211
1212 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1213
1214         Reviewed by Tony Chang.
1215
1216         new-run-webkit-tests: add a --build-directory command line argument
1217
1218         Official Google Chrome builds use a non-standard build directory
1219         location. This patch adds a --build-directory argument that
1220         allows that location to be specified on the command line. Only
1221         Chromium-based builds will use this flag for now, but anyone can
1222         in the future.
1223
1224         There are no unit tests for this since it's difficult to test
1225         until mock filesystems are fully supported in the code. This was
1226         tested by hand for now.
1227
1228         https://bugs.webkit.org/show_bug.cgi?id=52694
1229
1230         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
1231         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1232         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
1233         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1234
1235 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1236
1237         Not reviewed. Bot fix.
1238
1239         Remove an inadvertently committed debugging print.
1240
1241         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
1242         (LayoutTestController::notifyDone):
1243
1244 2011-01-18  Maciej Stachowiak  <mjs@apple.com>
1245
1246         Reviewed by Sam Weinig.
1247
1248         WebKitTestRunner should track loading more like DumpRenderTree
1249         https://bugs.webkit.org/show_bug.cgi?id=52692
1250
1251         Change load tracking to track the current top loading frame, in the manner of DumpRenderTree.
1252         This makes some tests that call notifyDone multiple times pass.
1253         
1254         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1255         (WTR::InjectedBundle::InjectedBundle):
1256         (WTR::InjectedBundle::done):
1257         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1258         (WTR::InjectedBundle::topLoadingFrame):
1259         (WTR::InjectedBundle::setTopLoadingFrame):
1260         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1261         (WTR::InjectedBundlePage::InjectedBundlePage):
1262         (WTR::InjectedBundlePage::stopLoading):
1263         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame):
1264         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
1265         (WTR::InjectedBundlePage::didFinishLoadForFrame):
1266         (WTR::InjectedBundlePage::didFailLoadWithErrorForFrame):
1267         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1268         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
1269         (WTR::LayoutTestController::notifyDone):
1270         * WebKitTestRunner/TestController.cpp:
1271         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1272
1273 2011-01-18  Mihai Parparita  <mihaip@chromium.org>
1274
1275         Reviewed by Kent Tamura.
1276
1277         [Chromium] NRWT looking for DRT binary in the wrong path on Mac
1278         https://bugs.webkit.org/show_bug.cgi?id=52678
1279         
1280         Update path now that WebKit is inside Source.
1281
1282         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
1283
1284 2011-01-18  Robert Hogan  <robert@webkit.org>
1285
1286         Reviewed by Simon Hausmann.
1287
1288         [Qt] http/tests/incremental/slow-utf8-text.pl fails
1289         https://bugs.webkit.org/show_bug.cgi?id=44282
1290
1291         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1292         (WebCore::DumpRenderTree::dump):
1293
1294 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1295
1296         Reviewed by Mihai Parparita.
1297
1298         Fix a small race condition that could cause the unit tests for
1299         new-run-webkit-tests to fail in a multithreaded environment.
1300         There was a small window in the code where one thread would
1301         check to see if a thread had raised an exception, do something,
1302         and then check to see if the thread was alive. If the other
1303         thread raised an exception and exited in between these two
1304         steps, the exception would be lost. Flipping the order of the
1305         two checks fixes the race, since we will now always check for an
1306         exception on the thread before exiting.
1307
1308         https://bugs.webkit.org/show_bug.cgi?id=51579
1309
1310         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
1311
1312 2011-01-18  Eric Seidel  <eric@webkit.org>
1313
1314         Reviewed by Adam Barth.
1315
1316         commit-queue dies when test archiving fails
1317         https://bugs.webkit.org/show_bug.cgi?id=52617
1318
1319         I looked at the machine and it had 10 archives already
1320         thus find_unused_name was returning None.  I've upped
1321         the limit to 100 (per bug) and tested the case where
1322         find_unused_name returns None (making archive return None).
1323
1324         * Scripts/webkitpy/common/system/workspace.py:
1325         * Scripts/webkitpy/common/system/workspace_unittest.py:
1326         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1327         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
1328         * Scripts/webkitpy/tool/commands/queues.py:
1329
1330 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1331
1332         Reviewed by Ojan Vafai.
1333
1334         Update rebaseline-chromium-webkit-tests unit tests to use a mock
1335         filesystem. Also fix a couple of "with" statements missed by
1336         r76050.
1337
1338         https://bugs.webkit.org/show_bug.cgi?id=52487
1339
1340         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1341
1342 2011-01-18  Sergio Villar Senin  <svillar@igalia.com>
1343
1344         Reviewed by Martin Robinson.
1345
1346         [Gtk] Build fixes for gtk3 build
1347         https://bugs.webkit.org/show_bug.cgi?id=52648
1348
1349         * DumpRenderTree/gtk/EventSender.cpp:
1350         (beginDragWithFilesCallback):
1351
1352 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1353
1354         Reviewed by Mihai Parparita.
1355
1356         Update rebaseline-chromium-webkit-tests to use filesystem objects
1357         instead of direct references to os.path, shutil, tempfile, etc.
1358
1359         This patch doesn't change anything, but will allow subsequent
1360         patches to change the unit tests to no longer use the real
1361         filesystem.
1362
1363         This patch adds a bunch more methods to the filesystem object as
1364         well.
1365
1366         https://bugs.webkit.org/show_bug.cgi?id=52482
1367
1368         * Scripts/webkitpy/common/system/filesystem.py:
1369         * Scripts/webkitpy/common/system/filesystem_mock.py:
1370         * Scripts/webkitpy/tool/commands/queues.py:
1371         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1372         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
1373
1374 2011-01-18  Dirk Pranke  <dpranke@chromium.org>
1375
1376         Reviewed by Mihai Parparita.
1377
1378         new-run-webkit-tests shouldn't crash when you try to run a
1379         directory containing only skipped files.
1380
1381         https://bugs.webkit.org/show_bug.cgi?id=52478
1382         
1383         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1384         * Scripts/webkitpy/layout_tests/port/test.py:
1385         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
1386
1387 2011-01-18  Adam Bergkvist  <adam.bergkvist@ericsson.com> and Martin Robinson  <mrobinson@igalia.com>
1388
1389         Reviewed by Gustavo Noronha Silva.
1390
1391         [GTK] The GTK+ EventSender needs support for beginDragWithFiles
1392         https://bugs.webkit.org/show_bug.cgi?id=40833
1393
1394         * DumpRenderTree/gtk/EventSender.cpp: Add a beginDragWithFiles implementation for the
1395         GTK+ event sender.
1396         (dragWithFilesDragDataGetCallback): Added.
1397         (dragWithFilesDragEndCallback): Added.
1398         (beginDragWithFilesCallback): Added.
1399
1400 2011-01-18  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1401
1402         Reviewed by Adam Barth.
1403
1404         ews: Add additional watcher to efl ews
1405         https://bugs.webkit.org/show_bug.cgi?id=52613
1406
1407         Add gyuyoung.kim@samsung.com to watcher list of efl-ews.
1408
1409         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1410
1411 2011-01-17  Tony Gentilcore  <tonyg@chromium.org>
1412
1413         Reviewed by Alexey Proskuryakov.
1414
1415         Fix some headers with missing or misspelled #ifndef guards
1416         https://bugs.webkit.org/show_bug.cgi?id=52545
1417
1418         * DumpRenderTree/chromium/TestEventPrinter.h:
1419         * DumpRenderTree/chromium/WebPreferences.h:
1420
1421 2011-01-17  Jessie Berlin  <jberlin@apple.com>
1422
1423         Reviewed by Anders Carlsson.
1424
1425         REGRESSION: Assertion failure in FrameLoader::continueLoadAfterWillSubmitForm() when
1426         navigating back to an unreachable URL
1427         https://bugs.webkit.org/show_bug.cgi?id=52388
1428
1429         Add a third parameter (unreachableURL) to queueLoadHTMLString.
1430
1431         * DumpRenderTree/LayoutTestController.cpp:
1432         (queueLoadHTMLStringCallback):
1433         (LayoutTestController::queueLoadHTMLString):
1434         (LayoutTestController::queueLoadAlternateHTMLString):
1435         * DumpRenderTree/LayoutTestController.h:
1436
1437         * DumpRenderTree/WorkQueueItem.h:
1438         (LoadHTMLStringItem::LoadHTMLStringItem):
1439
1440         * DumpRenderTree/chromium/LayoutTestController.cpp:
1441         (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
1442         (WorkItemLoadHTMLString::run):
1443         (LayoutTestController::queueLoadHTMLString):
1444
1445         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
1446         (LoadHTMLStringItem::invoke):
1447         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1448         (LoadHTMLStringItem::invoke):
1449         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1450         (LoadHTMLStringItem::invoke):
1451
1452 2011-01-17  Dan Bernstein  <mitz@apple.com>
1453
1454         Rubber-stamped by Mark Rowe.
1455
1456         Update xcodeproj svn:ignore to include xcuserdata.
1457
1458         * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
1459         * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
1460         * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
1461         * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
1462         * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
1463
1464 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1465
1466         Unreviewed fix after r75908.
1467
1468         Move WebKit into Source
1469         https://bugs.webkit.org/show_bug.cgi?id=52530
1470
1471         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add Source to the path for Qt API tests.
1472
1473 2011-01-17  Csaba Osztrogonác  <ossy@webkit.org>
1474
1475         Unreviewed.
1476
1477         Remove accidentally committed debug printing after r75908.
1478
1479         * Scripts/webkitdirs.pm:
1480
1481 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1482
1483         Unreviewed.
1484
1485         Add myself to committers list
1486         https://bugs.webkit.org/show_bug.cgi?id=52566
1487
1488         * Scripts/webkitpy/common/config/committers.py:
1489
1490 2011-01-17  John Knottenbelt  <jknotten@chromium.org>
1491
1492         Reviewed by Jeremy Orlow.
1493
1494         GeolocationController should call stopUpdating on destruction
1495         https://bugs.webkit.org/show_bug.cgi?id=52216
1496
1497         fast/dom/Geolocation/window-close-crash.html requires that a
1498         Geolocation watch be started in a secondary window. Consequently,
1499         we need to allow geolocation permission and provide a mock
1500         geolocation position for the secondary window's
1501         GeolocationClientMock.
1502
1503         * DumpRenderTree/chromium/LayoutTestController.cpp:
1504         (LayoutTestController::setGeolocationPermission):
1505         (LayoutTestController::setMockGeolocationPosition):
1506         (LayoutTestController::setMockGeolocationError):
1507         * DumpRenderTree/chromium/TestShell.h:
1508         (TestShell::windowList):
1509
1510 2011-01-16  Adam Barth  <abarth@webkit.org>
1511
1512         Update more include paths to reflect WebKit move.
1513
1514         * DumpRenderTree/chromium/EventSender.cpp:
1515         (EventSender::keyDown):
1516         (EventSender::needsShiftModifier):
1517         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
1518         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
1519
1520 2011-01-16  Kent Tamura  <tkent@chromium.org>
1521
1522         Unreviewed, Chromium build fix.
1523
1524         * Scripts/update-webkit-chromium: Webkit/chromium -> Source/WebKit/chromium
1525
1526 2011-01-16  Martin Robinson  <mrobinson@igalia.com>
1527
1528         Build fix for GTK+ after source directory movement.
1529
1530         * GNUmakefile.am: Correct include paths.
1531
1532 2011-01-16  Adam Barth  <abarth@webkit.org>
1533
1534         Teach svn-apply about WebKit move.
1535
1536         * Scripts/VCSUtils.pm:
1537
1538 2011-01-16  Adam Barth  <abarth@webkit.org>
1539
1540         Rubber-stamped by Eric Seidel.
1541
1542         Move WebKit into Source
1543         https://bugs.webkit.org/show_bug.cgi?id=52530
1544
1545         * DumpRenderTree/mac/InternalHeaders/WebKit/WebTypesInternal.h:
1546         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1547         * DumpRenderTree/qt/DumpRenderTreeQt.h:
1548         * DumpRenderTree/qt/GCControllerQt.cpp:
1549         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
1550         * DumpRenderTree/qt/PlainTextControllerQt.cpp:
1551         * DumpRenderTree/qt/TextInputControllerQt.cpp:
1552         * DumpRenderTree/wscript:
1553         * QtTestBrowser/launcherwindow.h:
1554         * Scripts/build-webkit:
1555         * Scripts/webkitdirs.pm:
1556
1557 2011-01-15  Adam Barth  <abarth@webkit.org>
1558
1559         Teach svn-apply about WebKit2 move.
1560
1561         * Scripts/VCSUtils.pm:
1562
1563 2011-01-15  Adam Barth  <abarth@webkit.org>
1564
1565         Rubber-stamped by Eric Seidel.
1566
1567         Move WebKit2 into Source
1568         https://bugs.webkit.org/show_bug.cgi?id=52438
1569
1570         * MiniBrowser/qt/MiniBrowser.pro:
1571         * Scripts/build-webkit:
1572         * Scripts/do-file-rename:
1573         * Scripts/do-webcore-rename:
1574         * Scripts/test-webkitpy:
1575         * Scripts/webkitdirs.pm:
1576         * Scripts/webkitpy/style/checker.py:
1577         * WebKitTestRunner/DerivedSources.pro:
1578         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
1579         * WebKitTestRunner/qt/WebKitTestRunner.pro:
1580
1581 2011-01-15  Jochen Eisinger  <jochen@chromium.org>
1582
1583         Reviewed by David Levin.
1584
1585         [chromium] remove obsolete createView method
1586         https://bugs.webkit.org/show_bug.cgi?id=52437
1587
1588         * DumpRenderTree/chromium/WebViewHost.cpp:
1589         (WebViewHost::createView):
1590         * DumpRenderTree/chromium/WebViewHost.h:
1591
1592 2011-01-14  Brian Weinstein  <bweinstein@apple.com>
1593
1594         Reviewed by Geoff Garen.
1595
1596         ShouldLoadResourceForFrame should use strings, not URLs.
1597         https://bugs.webkit.org/show_bug.cgi?id=52476
1598
1599         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1600         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Update to use a WKStringRef.
1601         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1602
1603 2011-01-14  Tony Gentilcore  <tonyg@chromium.org>
1604
1605         Reviewed by David Levin.
1606
1607         Add Tony Gentilcore as a reviewer
1608         https://bugs.webkit.org/show_bug.cgi?id=52480
1609
1610         * Scripts/webkitpy/common/config/committers.py:
1611
1612 2011-01-14  David Levin  <levin@chromium.org>
1613
1614         Reviewed by Eric Seidel.
1615
1616         check-webkit-style: _FunctionState should keep track of where the function name starts.
1617         https://bugs.webkit.org/show_bug.cgi?id=52454
1618
1619         * Scripts/webkitpy/style/checkers/cpp.py: Added function_name_start_position to
1620         _FunctionState and logic for setting it correctly.
1621         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
1622
1623 2011-01-14  Vincent Scheib  <scheib@chromium.org>
1624
1625         Reviewed by David Levin.
1626
1627         Add support to DumpRenderTree to use the GPU rather than software renderer
1628         https://bugs.webkit.org/show_bug.cgi?id=52333
1629
1630         * DumpRenderTree/chromium/DumpRenderTree.cpp:
1631         (main):
1632         * Scripts/webkitpy/layout_tests/port/chromium.py:
1633         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1634
1635 2011-01-14  Tony Chang  <tony@chromium.org>
1636
1637         Reviewed by Kent Tamura.
1638
1639         [chromium] update fonts.conf to fix 6 linux tests in drt
1640         https://bugs.webkit.org/show_bug.cgi?id=52411
1641
1642         * DumpRenderTree/chromium/fonts.conf: Update to match the copy in
1643             chromium's src/webkit/tools/test_shell/resources/fonts.conf
1644
1645 2011-01-14  Eric Seidel  <eric@webkit.org>
1646
1647         Original patch from Peter Gal  <galpater@inf.u-szeged.hu>
1648
1649         Reviewed by Adam Barth.
1650
1651         Fix when running Tools/Scripts/check-webkit-style without arguments.
1652         https://bugs.webkit.org/show_bug.cgi?id=52261#c16
1653
1654         * Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
1655         * Scripts/webkitpy/common/checkout/scm_unittest.py:
1656
1657 2011-01-04  Jochen Eisinger  <jochen@chromium.org>
1658
1659         Reviewed by David Levin.
1660
1661         Store the tempdir object in a variable so it doesn't get deleted too early.
1662         https://bugs.webkit.org/show_bug.cgi?id=51875
1663
1664         * Scripts/update-webkit-auxiliary-libs:
1665         * Scripts/update-webkit-support-libs:
1666
1667 2011-01-14  Eric Seidel  <eric@webkit.org>
1668
1669         Unreviewed.  Make it work in python 2.5.
1670
1671         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1672         https://bugs.webkit.org/show_bug.cgi?id=49158
1673
1674         * Scripts/webkitpy/common/checkout/api_unittest.py:
1675
1676 2011-01-14  Sheriff Bot  <webkit.review.bot@gmail.com>
1677
1678         Unreviewed, rolling out r75774.
1679         http://trac.webkit.org/changeset/75774
1680         https://bugs.webkit.org/show_bug.cgi?id=52431
1681
1682         gtk builds were broken (Requested by loislo2 on #webkit).
1683
1684         * Scripts/webkitpy/common/checkout/scm.py:
1685
1686 2011-01-14  David Levin  <levin@chromium.org>
1687
1688         Reviewed by Shinichiro Hamaji.
1689
1690         check-webkit-style: _FunctionState should detect pure functions.
1691         https://bugs.webkit.org/show_bug.cgi?id=52428
1692
1693         * Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
1694         is a pure virtual function.
1695         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
1696         virtual functions are correctly detected.
1697
1698 2011-01-13  Ilya Tikhonovsky  <loislo@chromium.org>
1699
1700         Reviewed by Yury Semikhatsky.
1701
1702         Just small fix for problem with check-webkit-style.
1703         It just didn't work for this patch.
1704         Old code can't concatenate a list of strings with None.
1705
1706         * Scripts/webkitpy/common/checkout/scm.py:
1707
1708 2011-01-13  David Levin  <levin@chromium.org>
1709
1710         Reviewed by Shinichiro Hamaji.
1711
1712         check-webkit-style: _FunctionState should use Position to know where items are.
1713         https://bugs.webkit.org/show_bug.cgi?id=52424
1714
1715         * Scripts/webkitpy/style/checkers/cpp.py:
1716         (_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
1717         (detect_functions): Changed to pass Position's to _FunctionState.begin and
1718         did some minor clean-up.
1719         (*): Other changes are simply about converting to use the Position's in_FunctionState
1720         instead of line numbers.
1721         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
1722         to verify the positions stored in _FunctionState.
1723
1724 2011-01-13  Eric Seidel  <eric@webkit.org>
1725
1726         Reviewed by David Levin.
1727
1728         webkit-patch suggest-reviewers dies when ChangeLogs are missing
1729         https://bugs.webkit.org/show_bug.cgi?id=49158
1730
1731         This is not the most elegant, but it is a very safe fix to this bug.
1732         One advantage of catching ScriptError like this instead of adding a
1733         new added_or_modified_files or fixing all changed_files callers
1734         to use a more specific change_files variant, is that we catch
1735         all kinds of ScriptErrors which might cause our (non-essential)
1736         suggest-reviewers code to fail out.  This should make passing
1737         --suggest-reviewers to webkit-patch upload much more robust
1738         and may even make it possible for us to make it default.
1739
1740         The root of the problem here is that SCM.changed_files includes
1741         deleted ChangeLog paths (from moves, etc) which then when we ask
1742         SVN/Git for the contents of the file at that revision, the command
1743         errors out and Executive.run_command raises a ScriptError.
1744
1745         In the future we might fix this differently by making all current
1746         callers of chagned_files use a more specific method for requesting
1747         what types of changes they're interested in (adds, modifies, deletes, etc.)
1748
1749         * Scripts/webkitpy/common/checkout/api.py:
1750         * Scripts/webkitpy/common/checkout/api_unittest.py:
1751
1752 2011-01-13  Dan Bernstein  <mitz@apple.com>
1753
1754         Reviewed by Alexey Proskuryakov.
1755
1756         <rdar://problem/8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
1757         https://bugs.webkit.org/show_bug.cgi?id=52419
1758
1759         Allow to further control the behavior of the willSendRequest delegate callback by making it
1760         set a different URL in the new request.
1761
1762         * DumpRenderTree/LayoutTestController.cpp:
1763         (addURLToRedirectCallback): Added.
1764         (LayoutTestController::staticFunctions): Added addURLToRedirect.
1765         (LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
1766         (LayoutTestController::redirectionDestinationForURL): Added this getter.
1767         * DumpRenderTree/LayoutTestController.h:
1768         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1769         (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
1770         if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
1771         change the URL in the new request to the redirect destination.
1772
1773 2011-01-13  Eric Seidel  <eric@webkit.org>
1774
1775         Reviewed by Mihai Parparita.
1776
1777         webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
1778         https://bugs.webkit.org/show_bug.cgi?id=52416
1779
1780         Example: webkit-patch suggest-reviewers -g ca3890fe74d94d85d6bfa48f9ea497b094d8e717 
1781         UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
1782
1783         I also added FIXMEs about the changed_files returning deleted files problem
1784         which is causing the other most common exception for suggest-reviewers
1785         (and is probably breaking sheriff-bots blame detection).
1786
1787         * Scripts/webkitpy/common/checkout/api.py:
1788         * Scripts/webkitpy/common/checkout/api_unittest.py:
1789         * Scripts/webkitpy/common/checkout/scm.py:
1790
1791 2011-01-13  Eric Seidel  <eric@webkit.org>
1792
1793         Reviewed by Adam Barth.
1794
1795         results archives from commit-queue are too large to upload
1796         https://bugs.webkit.org/show_bug.cgi?id=52405
1797
1798         * Scripts/webkitpy/common/system/filesystem.py:
1799         * Scripts/webkitpy/common/system/filesystem_mock.py:
1800         * Scripts/webkitpy/tool/commands/queues.py:
1801
1802 2011-01-13  Alejandro G. Castro  <alex@igalia.com>
1803
1804         Reviewed by Martin Robinson.
1805
1806         [gtk] Zero-sized font does not yet work
1807         https://bugs.webkit.org/show_bug.cgi?id=49793
1808
1809         Set minimum-font-size to 0 for the DRT.
1810
1811         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1812         (resetDefaultsToConsistentValues):
1813
1814 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1815
1816         Reviewed by Darin Adler.
1817
1818         Make old-run-webkit-tests more robust on buildbots
1819         https://bugs.webkit.org/show_bug.cgi?id=52364
1820
1821         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
1822
1823 2011-01-13  Csaba Osztrogonác  <ossy@webkit.org>
1824
1825         Reviewed by Darin Adler.
1826
1827         Make old-run-webkit-tests more robust on buildbots
1828         https://bugs.webkit.org/show_bug.cgi?id=52364
1829
1830         * Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
1831
1832 2011-01-13  Tony Chang  <tony@chromium.org>
1833
1834         Reviewed by Kent Tamura.
1835
1836         [chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
1837         https://bugs.webkit.org/show_bug.cgi?id=52332
1838
1839         Forked Info.plist is not longer needed.
1840
1841         * DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
1842
1843 2011-01-13  Mikhail Naganov  <mnaganov@chromium.org>
1844
1845         Reviewed by Timothy Hatcher.
1846
1847         Web Inspector: Cleanup after r75613 -- make all UI-facing strings
1848         to be passed directly to WebInspector.UIString
1849
1850         https://bugs.webkit.org/show_bug.cgi?id=52365
1851
1852         * Scripts/check-inspector-strings:
1853
1854 2011-01-13  Sheriff Bot  <webkit.review.bot@gmail.com>
1855
1856         Unreviewed, rolling out r74881.
1857         http://trac.webkit.org/changeset/74881
1858         https://bugs.webkit.org/show_bug.cgi?id=52357
1859
1860         The EFL builder has been red for days (Requested by abarth on
1861         #webkit).
1862
1863         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1864         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1865
1866 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1867
1868         Reviewed by David Levin.
1869
1870         Add beforeunload support to WebKitTestRunner
1871         https://bugs.webkit.org/show_bug.cgi?id=52353
1872         
1873         This makes a number of currently failing tests pass.
1874
1875         * WebKitTestRunner/TestController.cpp:
1876         (WTR::runBeforeUnloadConfirmPanel):
1877         (WTR::createOtherPage):
1878         (WTR::TestController::initialize):
1879
1880 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1881
1882         Reviewed by Sam Weinig.
1883
1884         Detect, identify and recover from WebProcess crashes in run-webkit-tests
1885         https://bugs.webkit.org/show_bug.cgi?id=52330
1886
1887         * Scripts/old-run-webkit-tests: Detect when the regression test tool reports
1888         a web process crash.
1889         * WebKitTestRunner/TestController.cpp:
1890         (WTR::TestController::initialize): Set up a processDidCrash
1891         callback.
1892         (WTR::TestController::processDidCrash): Report that the Web process
1893         crashed.
1894         * WebKitTestRunner/TestController.h:
1895
1896 2011-01-12  David Levin  <levin@chromium.org>
1897
1898         Reviewed by Shinichiro Hamaji.
1899
1900         check-webkit-style -- close_expression function doesn't work correctly.
1901         https://bugs.webkit.org/show_bug.cgi?id=52272
1902
1903         * Scripts/webkitpy/style/checkers/cpp.py:
1904         (Position.__str__): Added a way to convert it to a string which is useful in tests.
1905         (Position.__cmp__): Added a way to compare Position which is useful in tests and
1906         generally useful (for upcoming code changes).
1907         (close_expression): Changed to use Position for input and output.
1908         Also, fixed many bugs such as only working correctly for parenthesis,
1909         not working correctly if given an offset in a line and not finding
1910         the real closing element if there were multiple closing elements in
1911         the same line.
1912         (detect_functions): Adjusted due to the change in arguments for
1913         close_expression.
1914         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1915         (CppStyleTestBase.assert_positions_equal): Added a way to verify that
1916         two positions are the same.
1917         (CppStyleTest.test_position): Added tests for the __str_ and __cmp__ methods.
1918         (CppStyleTest.test_close_expression): Added tests to catch the issues
1919         that were fixed.
1920
1921 2011-01-12  Sheriff Bot  <webkit.review.bot@gmail.com>
1922
1923         Unreviewed, rolling out r75576.
1924         http://trac.webkit.org/changeset/75576
1925         https://bugs.webkit.org/show_bug.cgi?id=52304
1926
1927         broke rebaseline-chromium-webkit-test (Requested by thakis on
1928         #webkit).
1929
1930         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
1931         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
1932         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
1933         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
1934         * Scripts/webkitpy/layout_tests/port/base.py:
1935         * Scripts/webkitpy/layout_tests/port/chromium.py:
1936         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1937         * Scripts/webkitpy/layout_tests/port/test.py:
1938         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
1939         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1940         * Scripts/webkitpy/style/checkers/test_expectations.py:
1941         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1942
1943 2011-01-12  Maciej Stachowiak  <mjs@apple.com>
1944
1945         Reviewed by Darin Adler.
1946
1947         Add a no-build option to run-webkit-tests, to avoid building DRT/WKTR
1948         https://bugs.webkit.org/show_bug.cgi?id=52307
1949
1950         * Scripts/old-run-webkit-tests:
1951
1952 2011-01-12  Koan-Sin Tan  <koansin.tan@gmail.com>
1953
1954         Reviewed by Martin Robinson.
1955
1956         [Gtk] WebKitGtk+ doesn't build on Mac OS X 10.6
1957         https://bugs.webkit.org/show_bug.cgi?id=50867
1958
1959         Fixed library extention for Mac in webkitdirs.pm and type conflict in
1960         TestNetscapePlugin.cpp 
1961
1962         * GNUmakefile.am: Don't use AppKit when compiling TestNetscapePlugin for GTK+
1963         * Scripts/webkitdirs.pm:
1964
1965 2011-01-12  Mikhail Naganov  <mnaganov@chromium.org>
1966
1967         Reviewed by Pavel Feldman.
1968
1969         Add check-inspector-strings script.
1970
1971         https://bugs.webkit.org/show_bug.cgi?id=52295
1972
1973         * Scripts/check-inspector-strings: Added.
1974
1975 2011-01-12  Adam Roben  <aroben@apple.com>
1976
1977         Advertise the .testnetscape file extension on Windows
1978
1979         Fixes <http://webkit.org/b/52298>
1980         plugins/no-mime-with-valid-extension.html fails on Windows
1981
1982         Reviewed by Dan Bernstein.
1983
1984         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Added a
1985         FileExtents field to map the .testnetscape file extension to the
1986         application/x-webkit-test-netscape MIME type, just as we do on Mac.
1987
1988 2011-01-12  Adam Barth  <abarth@webkit.org>
1989
1990         Reviewed by Eric Seidel.
1991
1992         Make webkit-patch support subdirectories for SVN checkouts
1993         https://bugs.webkit.org/show_bug.cgi?id=52261
1994
1995         os.relpath does not exist on Python 2.5, so we need to call our version
1996         of the API.
1997
1998         * Scripts/webkitpy/common/checkout/scm.py:
1999
2000 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2001
2002         Reviewed by Eric Seidel.
2003
2004         Close additional pages opened during a test once the test completes.
2005         https://bugs.webkit.org/show_bug.cgi?id=52276
2006
2007         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2008         (WTR::InjectedBundle::done):
2009
2010 2011-01-11  David Levin  <levin@chromium.org>
2011
2012         Reviewed by Eric Seidel.
2013
2014         Errors should be separated from the command line in bot messages.
2015         https://bugs.webkit.org/show_bug.cgi?id=52275
2016
2017         * Scripts/webkitpy/common/system/executive.py:
2018         (ScriptError.message_with_output): Added a newline to separate the command
2019         line from the errors.
2020         * Scripts/webkitpy/common/system/executive_unittest.py:
2021         (ScriptErrorTest.test_message_with_output): Added tests for the various code
2022         paths in message_with_output.
2023
2024 2011-01-11  Eric Seidel  <eric@webkit.org>
2025
2026         Unreviewed.
2027
2028         commit-queue should know how to upload archived results (for test flakes or general failures)
2029         https://bugs.webkit.org/show_bug.cgi?id=52048
2030
2031         The zips are mostly empty due to forgetting -r.
2032         Expected diffs were not being pulled from the archive due
2033         to the archive having longer paths than I realized.
2034
2035         * Scripts/webkitpy/common/system/workspace.py:
2036         * Scripts/webkitpy/common/system/workspace_unittest.py:
2037         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2038         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2039
2040 2011-01-11  Dirk Pranke  <dpranke@chromium.org>
2041
2042         Reviewed by Ojan Vafai.
2043
2044         The current modifier parsing code in test_expectations is
2045         fragile and hard-coded, so it's not easy to understand the logic
2046         or easily add new types of modifiers (like GPU vs. CPU testing
2047         for graphics tests, or 32-bit vs. 64-bit differences).
2048
2049         This is the first of two patches that will add in more generic
2050         support and then eliminate the GPU-specific test expectations
2051         files for Chromium.
2052
2053         This patch adds two standalone objects for handling modifiers. The
2054         rules for interpreting modifiers, precedence, and conflicts are
2055         given in the docstring to the ModifierMatcher class, which
2056         returns ModifierMatchResult objects.
2057         
2058         This patch also adds routines to the Port interface and a
2059         default set of values in the base object, in order to obtain the
2060         values needed on a given test run. These values are then passed
2061         to the expectation parser. This also allows us to clean up the
2062         logic used to lint all of the different configurations in a
2063         single test_expectations.txt file.
2064
2065         The next patch will merge in the separate GPU expectations file.
2066
2067         https://bugs.webkit.org/show_bug.cgi?id=51222
2068
2069         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2070         * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
2071         * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
2072         * Scripts/webkitpy/layout_tests/port/base.py:
2073         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
2074         * Scripts/webkitpy/layout_tests/port/chromium.py:
2075         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2076         * Scripts/webkitpy/layout_tests/port/test.py:
2077         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2078         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
2079
2080 2011-01-11  Maciej Stachowiak  <mjs@apple.com>
2081
2082         Reviewed by Adam Barth.
2083
2084         Make webkit-patch support subdirectories for SVN checkouts
2085         https://bugs.webkit.org/show_bug.cgi?id=52261
2086
2087         * Scripts/webkitpy/common/checkout/scm.py:
2088         * Scripts/webkitpy/style_references.py:
2089         * Scripts/webkitpy/tool/main.py:
2090         * Scripts/webkitpy/tool/steps/preparechangelog.py:
2091
2092 2011-01-11  Eric Seidel  <eric@webkit.org>
2093
2094         Unreviewed.
2095
2096         commit-queue should know how to upload archived results (for test flakes or general failures)
2097         https://bugs.webkit.org/show_bug.cgi?id=52048
2098
2099         I changed the API for archive_last_layout_test_results w/o updating the implementation.  Oops.
2100         This fixes an exception seen on the commit-queue when attempting to report flaky tests.
2101
2102         * Scripts/webkitpy/common/system/workspace.py:
2103         * Scripts/webkitpy/common/system/workspace_unittest.py:
2104         * Scripts/webkitpy/tool/commands/queues.py:
2105
2106 2011-01-11  Sam Weinig  <sam@webkit.org>
2107
2108         Roll r75474 back in.
2109
2110 2011-01-11  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2111
2112         Reviewed by Kenneth Rohde Christiansen.
2113
2114         [Qt] Remove uses of QFuture since it isn't supported on all platforms.
2115         https://bugs.webkit.org/show_bug.cgi?id=51204
2116
2117         * QtTestBrowser/webpage.h:
2118         (QtNAMThread::QtNAMThread):
2119         (QtNAMThread::networkAccessManager):
2120         (QtNAMThread::run):
2121
2122 2011-01-11  Peter Varga  <pvarga@webkit.org>
2123
2124         Unreviewed.
2125
2126         Add myself to committers' list.
2127
2128         * Scripts/webkitpy/common/config/committers.py:
2129
2130 2011-01-11  Eric Seidel  <eric@webkit.org>
2131
2132         Reviewed by Adam Barth.
2133
2134         commit-queue should know how to upload archived results (for test flakes or general failures)
2135         https://bugs.webkit.org/show_bug.cgi?id=52048
2136
2137         Now the queue will always upload results.  Either the entire zip, or just
2138         the diffs.txt in the case of text failures.
2139
2140         This should make understanding flakes much easier, and paves the way
2141         for having the EWS run layout tests (and upload failures).
2142
2143         In order to upload .zip files I had to teach bugzilla.py to autodetect
2144         mime types from the filename.  Since mimetypes.py doesn't include a mapping
2145         for .patch files, I have it add one before calling guess_type.
2146
2147         We may find that always uploading the whole zip instead of just the -diffs.txt
2148         file is preferable, but for now I'm keeping the old behavior because it makes
2149         quickly understanding text failures easy.
2150
2151         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
2152         * Scripts/webkitpy/common/system/workspace.py: Added.
2153         * Scripts/webkitpy/common/system/workspace_unittest.py: Added.
2154         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2155         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2156         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2157         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2158         * Scripts/webkitpy/tool/commands/queues.py:
2159         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2160
2161 2011-01-10  Sheriff Bot  <webkit.review.bot@gmail.com>
2162
2163         Unreviewed, rolling out r75464.
2164         http://trac.webkit.org/changeset/75464
2165         https://bugs.webkit.org/show_bug.cgi?id=52193
2166
2167         Followup rollout for 75474 (Requested by Ossy on #webkit).
2168
2169         * MiniBrowser/mac/BrowserWindowController.m:
2170         (-[BrowserWindowController awakeFromNib]):
2171         * MiniBrowser/win/BrowserView.cpp:
2172         (BrowserView::create):
2173         * WebKitTestRunner/TestController.cpp:
2174         (WTR::createOtherPage):
2175         (WTR::TestController::initialize):
2176
2177 2011-01-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2178
2179         Reviewed by Csaba Osztrogonác.
2180
2181         [Qt] Baseline qt_minimal configuration
2182         https://bugs.webkit.org/show_bug.cgi?id=51313
2183
2184         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2185         (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting): Add
2186         QT_NO_UNDOSTACK guard.
2187
2188         * QtTestBrowser/launcherwindow.cpp:
2189         (LauncherWindow::createChrome): Add QT_NO_SHORTCUT and QT_NO_PRINTER
2190         guards.
2191         (LauncherWindow::applyZoom): Add QT_NO_ANIMATION guard.
2192         (LauncherWindow::screenshot): Add QT_NO_FILEDIALOG guard.
2193         (LauncherWindow::selectElements): Add QT_NO_INPUTDIALOG guard.
2194         (LauncherWindow::showUserAgentDialog): Add QT_NO_COMBOBOX guard.
2195
2196         * QtTestBrowser/launcherwindow.h:
2197         * QtTestBrowser/locationedit.cpp: Add QT_NO_INPUTDIALOG guard.
2198         * QtTestBrowser/locationedit.h: Ditto.
2199
2200         * QtTestBrowser/mainwindow.cpp:
2201         (MainWindow::buildUI): Add QT_NO_INPUTDIALOG, QT_NO_SHORTCUT and
2202         QT_NO_UNDOSTACK guards.
2203         (MainWindow::setAddressUrl): Add QT_NO_INPUTDIALOG guard.
2204         (MainWindow::changeLocation): Ditto.
2205         (MainWindow::openFile): Add QT_NO_FILEDIALOG guard.
2206         (MainWindow::openLocation): Add QT_NO_INPUTDIALOG guard.
2207
2208         * QtTestBrowser/webpage.cpp:
2209         (WebPage::openUrlInDefaultBrowser): Add QT_NO_DESKTOPSERVICES guard.
2210         (WebPage::authenticationRequired): Add QT_NO_LINEEDIT guard.
2211
2212         * QtTestBrowser/webview.cpp:
2213         (WebViewGraphicsBased::animatedFlip): Add QT_NO_ANIMATION guard.
2214         (WebViewGraphicsBased::animatedYFlip): Ditto.
2215
2216 2011-01-10  Sam Weinig  <sam@webkit.org>
2217
2218         Fix build.
2219
2220         * MiniBrowser/mac/BrowserWindowController.m:
2221         (-[BrowserWindowController awakeFromNib]):
2222         * MiniBrowser/win/BrowserView.cpp:
2223         (BrowserView::create):
2224         * WebKitTestRunner/TestController.cpp:
2225         (WTR::createOtherPage):
2226         (WTR::TestController::initialize):
2227
2228 2011-01-10  Eric Seidel  <eric@webkit.org>
2229
2230         Reviewed by Ojan Vafai.
2231
2232         style-queue messages are way too long for big patches
2233         https://bugs.webkit.org/show_bug.cgi?id=52161
2234
2235         We definitely could build much fancier list-to-string-with-limit functions
2236         but this should be sufficient for our needs at the moment.
2237
2238         * Scripts/webkitpy/common/system/executive.py:
2239         * Scripts/webkitpy/common/system/executive_unittest.py:
2240
2241 2011-01-10  Tony Chang  <tony@chromium.org>
2242
2243         Unreviewed, rolling out r75398.
2244         http://trac.webkit.org/changeset/75398
2245         https://bugs.webkit.org/show_bug.cgi?id=52008
2246
2247         Some layout tests are crashing on Chromium Win.
2248
2249         * DumpRenderTree/chromium/WebViewHost.cpp:
2250         (WebViewHost::updatePaintRect):
2251         * DumpRenderTree/chromium/WebViewHost.h:
2252
2253 2011-01-10  Adam Roben  <aroben@apple.com>
2254
2255         Roll out r75392
2256
2257         It isn't needed now that r75289 has been rolled out.
2258
2259         * Scripts/run-javascriptcore-tests:
2260
2261 2011-01-10  Maciej Stachowiak  <mjs@apple.com>
2262
2263         Reviewed by Anders Carlsson.
2264
2265         WebKitTestRunner uses crazy amounts of CPU, making layout tests slow and flaky
2266         https://bugs.webkit.org/show_bug.cgi?id=52160
2267
2268         * WebKitTestRunner/mac/TestControllerMac.mm:
2269         (WTR::TestController::platformRunUntil): Instead of busy-looping, wait for the timeout.
2270         Anything that can make runUntil() conditions turn true will happen on a run loop cycle
2271         anyway.
2272
2273 2011-01-10  Tony Chang  <tony@chromium.org>
2274
2275         Reviewed by Mihai Parparita.
2276
2277         [chromium] fix for animated gif layout tests
2278         https://bugs.webkit.org/show_bug.cgi?id=52008
2279
2280         * DumpRenderTree/chromium/WebViewHost.cpp: Schedule a paint when we update the paint rect
2281             to trigger gif animations.
2282         (WebViewHostPaintTask::WebViewHostPaintTask):
2283         (WebViewHostPaintTask::runIfValid):
2284         (WebViewHost::updatePaintRect):
2285         * DumpRenderTree/chromium/WebViewHost.h:
2286         (WebViewHost::taskList):
2287
2288 2011-01-10  Alejandro G. Castro  <alex@igalia.com>
2289
2290         Reviewed by Xan Lopez.
2291
2292         [GTK] Fix gtk2 compilation for master
2293         https://bugs.webkit.org/show_bug.cgi?id=51885
2294
2295         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2296         (createBitmapContextFromWebView): Replaced the old
2297         gdk_drawable_get_size with gdk_pixmap_get_size.
2298
2299 2011-01-10  Patrick Gansterer  <paroga@webkit.org>
2300
2301         Reviewed by Laszlo Gombos.
2302
2303         [WINCE] Reenable NPAPI after r75203
2304         https://bugs.webkit.org/show_bug.cgi?id=52109
2305
2306         Remove the !isWinCE() check for ENABLE_NETSCAPE_PLUGIN_API and replace
2307         it with !isEfl(), because EFL port does not support NPAPI (yet).
2308
2309         * Scripts/build-webkit:
2310
2311 2011-01-10  Adam Roben  <aroben@apple.com>
2312
2313         Skip some asserting JS tests
2314
2315         See <http://webkit.org/b/52156>.
2316
2317         * Scripts/run-javascriptcore-tests:
2318
2319 2011-01-10  Martin Robinson  <mrobinson@igalia.com>
2320
2321         Reviewed by Xan Lopez.
2322
2323         [GTK] build-webkit disable Blob support via arguments passed to automake
2324         https://bugs.webkit.org/show_bug.cgi?id=52097
2325
2326         * Scripts/build-webkit: Enable Blob support when building WebKitGTK+ via
2327         build-webkit.
2328
2329 2011-01-10  Adam Roben  <aroben@apple.com>
2330
2331         Use the same name and description for TestNetscapePlugin on Windows and
2332         Mac
2333
2334         Fixes <http://webkit.org/b/52151>
2335         fast/frames/iframe-reparenting-plugins.html fails on Windows
2336
2337         Reviewed by Steve Falkenburg.
2338
2339         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Copied
2340         the name and description from Mac's Info.plist.
2341
2342 2011-01-10  Siddharth Mathur <siddharth.mathur@nokia.com>
2343
2344         Reviewed by Laszlo Gombos.
2345
2346         [Qt][WK2] Guard gcc-specific syntax
2347
2348         Non-gcc based compliers choke on the "-include"
2349         syntax for preinclude, place guard around it.
2350
2351         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2352         * WebKitTestRunner/qt/WebKitTestRunner.pro:
2353
2354 2011-01-10  Andreas Kling  <kling@webkit.org>
2355
2356         Reviewed by Simon Hausmann.
2357
2358         [Qt] [WK2] MiniBrowser does not load pages opened in new windows
2359         https://bugs.webkit.org/show_bug.cgi?id=52111
2360
2361         When getting a createNewPage() callback from QWKPage, create the
2362         new page with the same QWKContext as the page that is passed to
2363         the callback.
2364
2365         * MiniBrowser/qt/BrowserView.h:
2366         * MiniBrowser/qt/BrowserWindow.cpp:
2367         (newPageFunction):
2368         (BrowserWindow::BrowserWindow):
2369         * MiniBrowser/qt/BrowserWindow.h:
2370
2371 2011-01-10  Andreas Kling  <kling@webkit.org>
2372
2373         Reviewed by Kenneth Rohde Christiansen.
2374
2375         [Qt] MiniBrowser: Remove superfluous createNewPage() callback
2376
2377         BrowserView set its own useless createNewPage() callback on QWKPage.
2378         This was immediately overridden by BrowserWindow anyway, so remove
2379         the BrowserView one.
2380
2381         * MiniBrowser/qt/BrowserView.cpp:
2382         (BrowserView::BrowserView):
2383
2384 2011-01-10  John Knottenbelt  <jknotten@chromium.org>
2385
2386         Reviewed by Jeremy Orlow.
2387
2388         [Chromium] Remove non-client-based Geolocation code
2389         https://bugs.webkit.org/show_bug.cgi?id=50921
2390
2391         * DumpRenderTree/chromium/LayoutTestController.cpp:
2392         (LayoutTestController::setGeolocationPermission):
2393         (LayoutTestController::setMockGeolocationPosition):
2394         (LayoutTestController::setMockGeolocationError):
2395         * DumpRenderTree/chromium/WebViewHost.cpp:
2396         (WebViewHost::geolocationClientMock):
2397         (WebViewHost::reset):
2398         * DumpRenderTree/chromium/WebViewHost.h:
2399
2400 2011-01-10  Eric Seidel  <eric@webkit.org>
2401
2402         Reviewed by Adam Barth.
2403
2404         Commit bot tried to land r? cq+ patch
2405         https://bugs.webkit.org/show_bug.cgi?id=36638
2406
2407         It should now be possible to post a patch with r? and cq+ and the
2408         commit-queue will correctly wait for the r+ before attempting to land the patch.
2409         (This was a feature requested by several users.)
2410
2411         One caveat: We don't actually reject r-, cq+ patches from the queue
2412         (we just ignore them), but I think that's OK for now.
2413
2414         I also noticed that setting r- once a commit-queue node had grabbed
2415         a patch would not properly cancel the landing.  That's fixed and
2416         tested in this patch.
2417
2418         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2419         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2420         * Scripts/webkitpy/tool/bot/feeders.py:
2421         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
2422
2423 2011-01-08  Benjamin Poulain  <benjamin.poulain@nokia.com>
2424
2425         Reviewed by Kenneth Rohde Christiansen.
2426
2427         [Qt] QtWebKit crashes when using XMLHttpRequest from the unload event
2428         https://bugs.webkit.org/show_bug.cgi?id=51934
2429
2430         When accessing the network from the destructor of QWebPage, the network access manager
2431         was already deleted because the object WebPage was already destructed.
2432
2433         This solve the problem by linking the lifetime of the network access manager to WebPage's QObject.
2434         The object is now destructed in the destructor of QObject.
2435
2436         * QtTestBrowser/webpage.cpp:
2437         (WebPage::WebPage):
2438         (WebPage::setQnamThreaded):
2439         * QtTestBrowser/webpage.h:
2440         (QtNAMThread::QtNAMThread):
2441
2442 2011-01-08  Eric Seidel  <eric@webkit.org>
2443
2444         Reviewed by Ojan Vafai.
2445
2446         test_failures.py should not mention TestShell (long live DumpRenderTree!)
2447         https://bugs.webkit.org/show_bug.cgi?id=52067
2448
2449         I ran test-webkitpy, but didn't bother adding a unit test for this string change.
2450         https://bugs.webkit.org/show_bug.cgi?id=51138#c3 is an example of why this is needed.
2451
2452         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2453
2454 2011-01-08  Eric Seidel  <eric@webkit.org>
2455
2456         Reviewed by Mihai Parparita.
2457
2458         commit-queue hangs when the ChangeLog diff is bad
2459         https://bugs.webkit.org/show_bug.cgi?id=52072
2460
2461         * Scripts/webkitpy/tool/steps/validatechangelogs.py:
2462         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py:
2463
2464 2011-01-08  Adam Barth  <abarth@webkit.org>
2465
2466         Teach svn-apply how to re-write WebCore to Source/WebCore.
2467
2468         * Scripts/VCSUtils.pm:
2469
2470 2011-01-07  Adam Barth  <abarth@webkit.org>
2471
2472         Rubber-stamped by Eric Seidel.
2473
2474         Move WebCore to Source
2475         https://bugs.webkit.org/show_bug.cgi?id=52050
2476
2477         Update the tools to understand WebCore's new location.
2478
2479         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2480         * DumpRenderTree/wscript:
2481         * GNUmakefile.am:
2482         * Scripts/build-webkit:
2483         * Scripts/do-file-rename:
2484         * Scripts/do-webcore-rename:
2485         * Scripts/generate-qt-inspector-resource:
2486         * Scripts/prepare-ChangeLog:
2487         * Scripts/run-bindings-tests:
2488         * Scripts/update-iexploder-cssproperties:
2489         * Scripts/update-sources-list.py:
2490         * Scripts/update-webkit-localizable-strings:
2491         * Scripts/webkitdirs.pm:
2492         * Scripts/webkitpy/common/config/build.py:
2493         * Scripts/webkitpy/common/config/build_unittest.py:
2494         * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
2495         * Scripts/webkitpy/style/checker.py:
2496         * Scripts/webkitpy/style/checker_unittest.py:
2497         * WebKitTestRunner/DerivedSources.pro:
2498         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
2499         * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh:
2500         * wx/browser/wscript:
2501         * wx/build/settings.py:
2502
2503 2011-01-07  Maciej Stachowiak  <mjs@apple.com>
2504
2505         Reviewed by Sam Weinig.
2506
2507         Make WebKitTestRunner rest between loads more robust to avoid test crashes
2508         https://bugs.webkit.org/show_bug.cgi?id=52086
2509
2510         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2511         (WTR::InjectedBundle::didReceiveMessage):
2512         * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
2513         (WTR::LayoutTestController::notifyDone):
2514         * WebKitTestRunner/TestController.cpp:
2515         (WTR::TestController::resetStateToConsistentValues):
2516         (WTR::TestController::run):
2517
2518 2011-01-07  James Robinson  <jamesr@chromium.org>
2519
2520         Revert "Implement mozilla's animationTime property"
2521         https://bugs.webkit.org/show_bug.cgi?id=51952
2522
2523         This approach isn't quite right.
2524
2525         * DumpRenderTree/chromium/WebViewHost.cpp:
2526         (WebViewHost::paintInvalidatedRegion):
2527
2528 2011-01-07  Adam Roben  <aroben@apple.com>
2529
2530         Build master fix
2531
2532         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2533         (RunWebKitTests.start): Don't try to concatenate a list and a string.
2534
2535 2011-01-07  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>
2536
2537         Reviewed by Csaba Osztrogonác.
2538
2539         run-qtwebkit-tests should be able to kill a testsuite.
2540
2541         Add new option in the script that can setup a timeout for a test.
2542         If the test execution takes more then specified time then the test
2543         would be terminated.
2544
2545         [Qt] run-qtwebkit-tests needs timeout
2546         https://bugs.webkit.org/show_bug.cgi?id=51894
2547
2548         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2549         * Scripts/run-qtwebkit-tests:
2550
2551 2011-01-07  Csaba Osztrogonác  <ossy@webkit.org>
2552
2553         Unreviewed fix after r75233.
2554
2555         Based on idea from Eric Seidel.
2556
2557         Add remote zip file handling to webkitpy.
2558         https://bugs.webkit.org/show_bug.cgi?id=50901
2559
2560         * Scripts/webkitpy/common/system/fileset.py: Make python 2.5 happy.
2561
2562 2011-01-07  Shane Stephens  <shanestephens@google.com>
2563
2564         Reviewed by Eric Seidel.
2565
2566         svn-apply: should support git binary delta diffs
2567         https://bugs.webkit.org/show_bug.cgi?id=38864
2568
2569         * Scripts/VCSUtils.pm:
2570         * Scripts/svn-apply:
2571
2572 2011-01-06  Julie Parent  <jparent@chromium.org>
2573
2574         Reviewed by Eric Seidel.
2575
2576         Test Result Server not removing old results.
2577         https://bugs.webkit.org/show_bug.cgi?id=52012
2578
2579         * TestResultServer/model/jsonresults.py:
2580         Fix off-by-one: Truncate if >= num_runs, not just >.
2581         * TestResultServer/model/jsonresults_unittest.py:
2582         Add unit test to test that merging in a new result with the same value
2583         as the last result causes previous result to fall off.
2584
2585 2011-01-06  James Kozianski  <koz@chromium.org>
2586
2587         Reviewed by Mihai Parparita.
2588
2589         Add classes to provide a consistent interface to a set of files.
2590         https://bugs.webkit.org/show_bug.cgi?id=50901
2591
2592         These classes allow us to write code that is agnostic to whether a
2593         particular set of files resides in a local directory or in a zip file
2594         on a remote machine.
2595
2596         * Scripts/webkitpy/common/system/directoryfileset.py: Added.
2597         * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Added.
2598         * Scripts/webkitpy/common/system/fileset.py: Added.
2599         * Scripts/webkitpy/common/system/filesystem.py:
2600         * Scripts/webkitpy/common/system/filesystem_mock.py:
2601         * Scripts/webkitpy/common/system/zipfileset.py: Added.
2602         * Scripts/webkitpy/common/system/zipfileset_unittest.py: Added.
2603
2604 2011-01-06  Eric Seidel  <eric@webkit.org>
2605
2606         Reviewed by Adam Barth.
2607
2608         NetworkTransaction should log the url it is retrying
2609         https://bugs.webkit.org/show_bug.cgi?id=52043
2610
2611         * Scripts/webkitpy/common/net/networktransaction.py:
2612         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
2613
2614 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2615
2616         Windows build fix.
2617         Import os before using it.
2618
2619         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2620
2621 2011-01-06  Eric Seidel  <eric@webkit.org>
2622
2623         Reviewed by Adam Barth.
2624
2625         StyleQueue fails to report errors when patches have many files
2626         https://bugs.webkit.org/show_bug.cgi?id=52042
2627
2628         This is one of at least two errors preventing style error reporting at the moment.
2629         When we moved to passing the list of files to check explicitly,
2630         we started to exceed the 500 character TEXT field limit for our AppEngine model object.
2631         We could change the type of the QueueStatus.message type, or we could
2632         just teach statusserver.py how to clamp values (and warn when it does).
2633         I chose the latter path.
2634
2635         * Scripts/webkitpy/common/net/statusserver.py:
2636
2637 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2638
2639         Reviewed by Stephanie Lewis.
2640         
2641         Fix syntax error in script.
2642
2643         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2644         https://bugs.webkit.org/show_bug.cgi?id=51996
2645
2646         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2647
2648 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2649
2650         Unreviewed, fixing WinCE build after r75196.
2651
2652         WinCE port does not (yet) support NPAPI.
2653
2654         * Scripts/build-webkit:
2655
2656 2011-01-06  Xan Lopez  <xlopez@igalia.com>
2657
2658         Reviewed by Darin Adler.
2659
2660         File::Spec->rel2abs in sunspider-compare-results mangles parameters
2661         https://bugs.webkit.org/show_bug.cgi?id=52015
2662
2663         * Scripts/sunspider-compare-results: call rel2abs on our arguments
2664         after the platform has been detected, otherwise the script will
2665         mangle things like '--gtk' into '/a/path/--gtk', breaking the
2666         detection.
2667
2668 2011-01-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
2669
2670         Reviewed by Eric Seidel.
2671
2672         Add ENABLE_NETSCAPE_PLUGIN_API, ENABLE_ORIENTATION_EVENTS and ENABLE_TOUCH_EVENTS flags to build-webkit
2673         https://bugs.webkit.org/show_bug.cgi?id=51346
2674
2675         * Scripts/build-webkit:
2676
2677 2011-01-06  Steve Falkenburg  <sfalken@apple.com>
2678
2679         Reviewed by Adam Roben.
2680
2681         Windows bots need to archive/unarchive builds to/from configuration-specific directories
2682         https://bugs.webkit.org/show_bug.cgi?id=51996
2683         
2684         After the configuration directory change, we were archiving the incorrect directory for
2685         build product, so we were running tests on the wrong binaries.
2686         
2687         This change archives the correct directory, and also unarchives it into a configuration-
2688         specific directory.
2689
2690         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Use a configuration-specific directory on Windows.
2691         * BuildSlaveSupport/built-product-archive: Unarchive/archive to/from proper directory.
2692
2693 2011-01-06  Eric Seidel  <eric@webkit.org>
2694
2695         Reviewed by Mihai Parparita.
2696
2697         commit-queue mentions "Text diff mismatch" 4 times instead of once per failure
2698         https://bugs.webkit.org/show_bug.cgi?id=52002
2699
2700         See an example of this here:
2701         https://bugs.webkit.org/show_bug.cgi?id=51314#c2
2702
2703         It's due to the fact that we pass around TestFailure() instance
2704         objects and yet expect them to all compare to be the same.
2705
2706         This is bad.  We should either have shared instances of these values
2707         or we should just pass around the class names.  There are already hacks
2708         in place to make TestFailure objects pass equality tests, I just added
2709         a __hash__ implementation so they can be used in sets as expected.
2710
2711         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2712         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
2713
2714 2011-01-06  Evan Martin  <evan@chromium.org>
2715
2716         Reviewed by Tony Chang.
2717
2718         [gdb] handle inaccessible memory and UChar*
2719         https://bugs.webkit.org/show_bug.cgi?id=52003
2720
2721         To pretty-print a UChar*, we just grope around in the memory
2722         looking for a terminating NUL.  We need to handle the exception
2723         that can occur when we poke into an invalid location.
2724
2725         Additionally, the logic for choosing which pretty-printer would
2726         early return before hitting the point where we'd use the UChar*
2727         printer.  (Did this ever work?  How did it regress?)
2728
2729         * gdb/webkit.py:
2730
2731 2011-01-05  Brian Weinstein  <bweinstein@apple.com>
2732
2733         Reviewed by Ada Chan.
2734
2735         WebKit2: Should be able to call into injected bundle to ask if we should allow resource loads
2736         https://bugs.webkit.org/show_bug.cgi?id=51969
2737         
2738         Add shouldLoadResourceForFrame to WTR::InjectedBundlePage.
2739
2740         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2741         (WTR::InjectedBundlePage::InjectedBundlePage):
2742         (WTR::InjectedBundlePage::shouldLoadResourceForFrame): Stub implementation.
2743         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
2744
2745 2011-01-06  James Robinson  <jamesr@chromium.org>
2746
2747         Reviewed by Simon Fraser.
2748
2749         Implement mozilla's animationTime property
2750         https://bugs.webkit.org/show_bug.cgi?id=51952
2751
2752         Chromium DRT support for webkitAnimationTime.
2753
2754         * DumpRenderTree/chromium/WebViewHost.cpp:
2755         (WebViewHost::paintInvalidatedRegion):
2756
2757 2011-01-06  Julie Parent  <jparent@chromium.org>
2758
2759         Reviewed by Tony Chang.
2760
2761         Test Result Server always truncates number of results to JSON_RESULTS_MAX_BUILDS
2762         https://bugs.webkit.org/show_bug.cgi?id=51217
2763
2764         * TestResultServer/model/jsonresults.py:
2765         Pass num_runs through to _remove_items_over_max_number_of_builds, and use the value.
2766         Adds missing documentation.
2767         * TestResultServer/model/jsonresults_unittest.py:
2768         Add unit test to test that truncation happens at smaller value than JSON_RESULTS_MAX_BUILDS.
2769         Update test_merge to take a number of builds to truncate at.
2770
2771 2011-01-06  Adam Barth  <abarth@webkit.org>
2772
2773         Reviewed by Eric Seidel.
2774
2775         The EWS should log outside of the working directory
2776         https://bugs.webkit.org/show_bug.cgi?id=51986
2777
2778         This patch prepare us for using git clean -x -d -f in the EWS wrapper
2779         script, which will actually clean the working copy back to a pristine
2780         state instead of leaving untracked directories and ignored files.
2781
2782         * Scripts/webkitpy/tool/commands/queues.py:
2783         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2784
2785 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2786
2787         Windows build fix.
2788         Back out attempted change to built-product-archive.
2789
2790         * BuildSlaveSupport/built-product-archive:
2791
2792 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2793
2794         Windows build fix.
2795         Include configuration name when unpacking a build archive.
2796
2797         Needed, since we split Windows build results into configuration-specific directories
2798         under WebKitOutputDir.
2799
2800         * BuildSlaveSupport/built-product-archive:
2801
2802 2011-01-05  Steve Falkenburg  <sfalken@apple.com>
2803
2804         Reviewed by Darin Adler.
2805
2806         Debug and Release builds on Windows clobber each other
2807         https://bugs.webkit.org/show_bug.cgi?id=49185
2808
2809         Changes the structure of WebKitBuild build products directory so we
2810         completely separate each build configuration into independent directories.
2811         
2812         Although we previously had per-configuration directories for obj, this change adds
2813         per-configuration directories for bin, lib, obj, and include. Each configuration's
2814         build products are stored within a directory inside of WebKitBuild.
2815         
2816         Most use of $(WebKitOutputDir) in the build files has been replaced by $(ConfigurationBuildDir),
2817         defined in common.vsprops to be $(WebKitOutputDir)\$(ConfigurationName).
2818
2819         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops:
2820         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPostBuild.cmd:
2821         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginPreBuild.cmd:
2822         * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
2823         * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
2824         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd:
2825         * DumpRenderTree/win/ImageDiffCommon.vsprops:
2826         * DumpRenderTree/win/ImageDiffPostBuild.cmd:
2827         * DumpRenderTree/win/ImageDiffPreBuild.cmd:
2828         * FindSafari/FindSafari.vcproj:
2829         * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
2830         * MiniBrowser/MiniBrowserPostBuild.cmd:
2831         * MiniBrowser/MiniBrowserPreBuild.cmd:
2832         * Scripts/webkitdirs.pm:
2833         * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
2834         * TestWebKitAPI/win/TestWebKitAPIGeneratedCommon.vsprops:
2835         * TestWebKitAPI/win/TestWebKitAPIPostBuild.cmd:
2836         * TestWebKitAPI/win/TestWebKitAPIPreBuild.cmd:
2837         * TestWebKitAPI/win/copy-resources.cmd:
2838         * WebKitAPITest/WebKitAPITestCommon.vsprops:
2839         * WebKitAPITest/WebKitAPITestPostBuild.cmd:
2840         * WebKitAPITest/WebKitAPITestPreBuild.cmd:
2841         * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
2842         * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
2843         * WebKitTestRunner/win/InjectedBundle.vcproj:
2844         * WebKitTestRunner/win/InjectedBundleGeneratedCommon.vsprops:
2845         * WebKitTestRunner/win/InjectedBundlePostBuild.cmd:
2846         * WebKitTestRunner/win/InjectedBundlePreBuild.cmd:
2847         * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
2848         * WebKitTestRunner/win/WebKitTestRunnerPreBuild.cmd:
2849         * WinLauncher/WinLauncherCommon.vsprops:
2850         * WinLauncher/WinLauncherPostBuild.cmd:
2851         * WinLauncher/WinLauncherPreBuild.cmd:
2852
2853 2011-01-05  Jan Erik Hanssen  <jhanssen@sencha.com>
2854
2855         Reviewed by Ariya Hidayat.
2856
2857         [Qt] TestNetscapePlugin doesn't link on OS X
2858         https://bugs.webkit.org/show_bug.cgi?id=51948
2859
2860         Only add a dependency on libX11 on X11 systems
2861
2862         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
2863
2864 2011-01-05  Jeff Miller  <jeffm@apple.com>
2865
2866         Reviewed by Adam Roben.
2867
2868         check-webkit-style should allow unnecessary parameter names in WebKit2 APIs because we're matching CF's header style
2869         https://bugs.webkit.org/show_bug.cgi?id=51970
2870
2871         * Scripts/webkitpy/style/checker.py:
2872         Add -readability/naming for WebKit2 C API directories.
2873
2874 2011-01-05  Eric Seidel  <eric@webkit.org>
2875
2876         Unreviewed, just fixing one more log error from my previous python patch.
2877
2878         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2879         https://bugs.webkit.org/show_bug.cgi?id=51802
2880
2881         webkit-patch failure-reason was logging about parsing errors
2882         due to my misunderstanding of how BeautifulSoup.findAll worked.
2883
2884         Fixed, and added a unit test.
2885
2886         * Scripts/webkitpy/common/net/layouttestresults.py:
2887         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2888
2889 2011-01-05  Benjamin Poulain  <benjamin.poulain@nokia.com>
2890
2891         Reviewed by Kenneth Rohde Christiansen.
2892
2893         [Qt] [WK2] Add the possibility to open window from the WebProcess in Minibrowser
2894         https://bugs.webkit.org/show_bug.cgi?id=51951
2895
2896         Set a function to QWKPage::setCreateNewPageFunction() in Minibrowser so there is a way
2897         to create new window from WebKit.
2898
2899         * MiniBrowser/qt/BrowserWindow.cpp:
2900         (newPageFunction):
2901         (BrowserWindow::BrowserWindow):
2902         (BrowserWindow::page): Added to avoid the indirect access to QWKPage spread in the class
2903         (BrowserWindow::newWindow):
2904         (BrowserWindow::updateUserAgentList):
2905         (BrowserWindow::showUserAgentDialog):
2906         * MiniBrowser/qt/BrowserWindow.h: Add the global variable backingStoreTypeForNewWindow to
2907         define the type of the backing store used for new windows.
2908         * MiniBrowser/qt/main.cpp:
2909         (main):
2910
2911 2011-01-05  Eric Seidel  <eric@webkit.org>
2912
2913         Reviewed by Ojan Vafai.
2914
2915         commit-queue should report failure type when reporting flaky tests
2916         https://bugs.webkit.org/show_bug.cgi?id=51900
2917
2918         This patch was a ridiculous amount of plumbing.  In the end I like
2919         the NRWT-style TestResult class even less.  But now we're passing
2920         a list of TestResult objects from the queue to the FlakyTestReporter.
2921         Thus the FlakyTestReporter can more easily report what type of failure
2922         occurred.
2923
2924         In the process, I found that I was not alone in finding TestResult
2925         cumbersome to use.  A bunch of code was trying to create a TestResult
2926         object with default values.  However since the constructor didn't make
2927         this easy, some places were getting it wrong (including the TestResult unit test)!
2928         I've fixed the TestResult constructor to have default values for non-essential
2929         arguments.
2930
2931         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
2932         * Scripts/webkitpy/common/net/layouttestresults.py:
2933         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2934         * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
2935         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
2936         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
2937         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
2938         * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
2939         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
2940         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
2941         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2942         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
2943         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
2944         * Scripts/webkitpy/tool/commands/queues.py:
2945         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2946
2947 2011-01-05  Eric Seidel  <eric@webkit.org>
2948
2949         Unreviewed.
2950
2951         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2952         https://bugs.webkit.org/show_bug.cgi?id=51802
2953
2954         Add another unit test to cover a previously missing import.
2955
2956         * Scripts/webkitpy/common/net/layouttestresults.py:
2957         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2958
2959 2011-01-05  Mihai Parparita  <mihaip@chromium.org>
2960
2961         Reviewed by David Levin.
2962
2963         Add mihaip@chromium.org as a reviewer
2964         https://bugs.webkit.org/show_bug.cgi?id=51966
2965         
2966         Add myself as a reviewer.
2967
2968         * Scripts/webkitpy/common/config/committers.py:
2969
2970 2011-01-05  James Simonsen  <simonjam@chromium.org>
2971
2972         Unreviewed. Adding myself to the list of committers.
2973
2974         * Scripts/webkitpy/common/config/committers.py:
2975
2976 2011-01-05  Eric Seidel  <eric@webkit.org>
2977
2978         Unreviewed.
2979
2980         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
2981         https://bugs.webkit.org/show_bug.cgi?id=51802
2982
2983         Fix two exceptions seen on the bots after my original commit.
2984
2985         * Scripts/webkitpy/common/net/layouttestresults.py:
2986         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2987
2988 2011-01-05  Kundu Suchismita  <suchi.kundu@nokia.com>
2989
2990         Reviewed by Andreas Kling.
2991
2992         [Qt]Add local storage settings to QtTestBrowser command line arguments 
2993         https://bugs.webkit.org/show_bug.cgi?id=51750
2994
2995         * QtTestBrowser/main.cpp:
2996         (LauncherApplication::handleUserOptions):
2997          Local storage settings can be enable form command line arguments for
2998          QtTestBrowser.
2999
3000 2011-01-05  Chris Fleizach  <cfleizach@apple.com>
3001
3002         Reviewed by Martin Robinson.
3003
3004         GTK: AX: DRT needs to use correct root object method.
3005         https://bugs.webkit.org/show_bug.cgi?id=51911
3006
3007         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3008         (AccessibilityController::rootElement):
3009
3010 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3011
3012         Rubber-stamped by Csaba Osztrogonác.
3013
3014         Based on idea from Péter Gál.
3015
3016         * Scripts/webkitpy/tool/bot/sheriff.py: Remove unnecessary apostrophes around revision numbers.
3017
3018 2011-01-05  Gabor Rapcsanyi  <rgabor@inf.u-szeged.hu>
3019
3020         Reviewed by Adam Barth.
3021
3022         sheriff-bot should be able to do multi-revision rollouts
3023         https://bugs.webkit.org/show_bug.cgi?id=51176
3024
3025         * Scripts/webkitpy/tool/bot/irc_command.py:
3026         * Scripts/webkitpy/tool/bot/sheriff.py:
3027         * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
3028
3029 2011-01-05  Eric Seidel  <eric@webkit.org>
3030
3031         Reviewed by Adam Barth.
3032
3033         queues.webkit.org should have per-bot status pages
3034         https://bugs.webkit.org/show_bug.cgi?id=51906
3035
3036         Just adds a /queue-status/QUEUE_NAME/bots/BOT_ID page to show
3037         statuses from a single queue.  Now that we have many bots servicing
3038         some queues (commit-queue, win-ews, etc.) its easy to have the messages
3039         you care about scroll off the end of the 15-message limit on the main page.
3040
3041         Eventually we should probably rename /queue-status to /queue or /queues,
3042         but that's fodder for another patch.
3043
3044         * QueueStatusServer/handlers/queuestatus.py:
3045         * QueueStatusServer/index.yaml:
3046         * QueueStatusServer/main.py:
3047         * QueueStatusServer/templates/includes/singlequeuestatus.html:
3048          - This probably should use a custom filter instead of hard-coding
3049            the URL scheme here, but I couldn't figure out how to easily
3050            create such a filter.  Most filters work with "strings" so we can't
3051            pass the status object.  We could add a method to the status
3052            object and call that, but that seemed a bit strange too.
3053         * QueueStatusServer/templates/queuestatus.html:
3054
3055 2011-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3056
3057         Unreviewed. Adding myself to the list of committers.
3058
3059         * Scripts/webkitpy/common/config/committers.py:
3060
3061 2011-01-04  Koan-Sin Tan  <koansin.tan@gmail.com>
3062
3063         Reviewed by David Levin.
3064
3065         check-webkit-style treated some macros with parentheses after #elif as function calls
3066         https://bugs.webkit.org/show_bug.cgi?id=51695
3067
3068         Ingore function call space checking in any preprocessor directives
3069         (things starting with #). Change search() to match() because 
3070         preprocessor directives are supposed to be in the beginning of lines.
3071
3072         * Scripts/webkitpy/style/checkers/cpp.py:
3073         * Scripts/webkitpy/style/checkers/cpp_unittest.py: make sure there is no false positives for #elif cases
3074
3075 2011-01-04  Søren Gjesse  <sgjesse@chromium.org>
3076
3077         Reviewed by Tony Chang.
3078
3079         Change the --multi-load test option to --stress-opt
3080         https://bugs.webkit.org/show_bug.cgi?id=50751
3081
3082         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3083         (runTest):
3084         (main):
3085         * DumpRenderTree/chromium/TestShell.cpp:
3086         (TestShell::TestShell):
3087         * DumpRenderTree/chromium/TestShell.h:
3088         (TestShell::stressOpt):
3089         (TestShell::setStressOpt):
3090         (TestShell::stressDeopt):
3091         (TestShell::setStressDeopt):
3092         (TestShell::javaScriptFlags):
3093         (TestShell::setJavaScriptFlags):
3094         * Scripts/webkitpy/layout_tests/port/chromium.py:
3095         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3096
3097 2011-01-04  Chris Fleizach  <cfleizach@apple.com>
3098
3099         Reviewed by Sam Weinig.
3100
3101         WK2: Support Accessibility
3102         https://bugs.webkit.org/show_bug.cgi?id=51859
3103
3104         Use rootObject() method to get top of accessibility tree.
3105
3106         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3107         (AccessibilityController::focusedElement):
3108         (AccessibilityController::rootElement):
3109
3110 2011-01-03  Martin Robinson  <mrobinson@igalia.com>
3111
3112         Reviewed by Darin Adler.
3113
3114         Remove the last non-GObject usage of PlatformRefPtr and move the code to GRefPtr
3115         https://bugs.webkit.org/show_bug.cgi?id=51846
3116
3117         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp: Change usage of PlatformRefPtr
3118         back to GRefPtr.
3119
3120 2011-01-04  Zhe Su  <suzhe@chromium.org>
3121
3122         Reviewed by Kenneth Russell.
3123
3124         Fix insertText, setMarkedText and unmarkText methods of
3125         TextInputController to call corresponding methods of WebKit::WebView
3126         rather than WebKit::WebFrame. This change matches the behavior of
3127         chromium browser.
3128         insertText corresponds to WebView::confirmComposition(text)
3129         setMarkedText corresponds to WebView::setComposition(...)
3130         unmarkText corresponds to WebView::confirmComposition()
3131         https://bugs.webkit.org/show_bug.cgi?id=51693
3132
3133         * DumpRenderTree/chromium/TextInputController.cpp:
3134         (TextInputController::insertText):
3135         (TextInputController::setMarkedText):
3136         (TextInputController::unmarkText):
3137
3138 2011-01-04  Dihan Wickremasuriya  <dihan.wickremasuriya@nokia.com>
3139
3140         Reviewed by Laszlo Gombos.
3141
3142         [Qt] [Symbian] Do not remove 0 byte sized files from productDir
3143
3144         On Symbian productDir points to the source directory. Removing all the
3145         empty files from the productDir directory corrupts the svn repository.
3146
3147         * Scripts/build-webkit:
3148
3149 2011-01-03  Yi Shen  <yi.4.shen@nokia.com>
3150
3151         Reviewed by Adam Barth.
3152
3153         [Qt] Add SelectAll option to the context menu for the editor
3154         https://bugs.webkit.org/show_bug.cgi?id=50049
3155
3156         Set shortcut for the SelectAll action.
3157
3158         * QtTestBrowser/mainwindow.cpp:
3159         (MainWindow::buildUI):
3160
3161 2011-01-03  David Levin  <levin@chromium.org>
3162
3163         Reviewed by Eric Seidel.
3164
3165         check-webkit-style shouldn't consider "value" automatically to be a meaningless name.
3166         https://bugs.webkit.org/show_bug.cgi?id=51842
3167
3168         * Scripts/webkitpy/style/checkers/cpp.py: Remove the check for value.
3169         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Remove the test for value.
3170
3171 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3172
3173         Reviewed by David Kilzer.
3174
3175         [WINCE] Adds a build slave.
3176         https://bugs.webkit.org/show_bug.cgi?id=50523
3177
3178         * BuildSlaveSupport/build.webkit.org-config/config.json: Add an
3179         entry for a release build of the WinCE port.
3180         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add platform
3181         flag to build the WinCE port.
3182
3183 2011-01-03  Patrick Gansterer  <paroga@webkit.org>
3184
3185         Reviewed by David Kilzer.
3186
3187         Add WinCE support to build-webkit
3188         https://bugs.webkit.org/show_bug.cgi?id=51642
3189
3190         * Scripts/build-webkit:
3191         * Scripts/webkitdirs.pm:
3192
3193 2011-01-03  Eric Seidel  <eric@webkit.org>
3194
3195         Reviewed by Adam Barth.
3196
3197         Move LayoutTestResults over to new-run-webkit-tests TestResult architecture
3198         https://bugs.webkit.org/show_bug.cgi?id=51802
3199
3200         I'm not the biggest fan of the test_failures or test_results classes,
3201         but it's better to have one shared set of classes, than separate ones
3202         for new vs. old run-webkit-test result handling.
3203
3204         This moves the ORWT results class "LayoutTestResults" over to using
3205         TestResult and TestFailure classes, making it easy for us to
3206         make all our sheriff-bot and other webkitpy code NRWT ready.
3207
3208         This also makes it a trivial patch to generate results.json information
3209         from ORWT results.html files (for flaky test analysis, etc.) as well
3210         as making it a one-liner to report test failure types when the
3211         commit-queue sees flaky tests.
3212
3213         This patch tried not to add new functionality, but only to replace
3214         the guts of LayoutTestResults, while adding unit tests and hoping
3215         not to break anything.
3216
3217         I also moved callers which assumed User.prompt* were static/class methods
3218         to using them as instance methods (since we'll eventually want to make them such).
3219
3220         In the process of re-writing things, I broke the rebaseline command, so I wrote
3221         a unit test to catch my breakage were I do do so again in the future.
3222
3223         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3224         * Scripts/webkitpy/common/net/layouttestresults.py:
3225         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
3226         * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
3227         * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
3228         * Scripts/webkitpy/tool/commands/queries.py:
3229         * Scripts/webkitpy/tool/commands/rebaseline.py:
3230         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
3231         * Scripts/webkitpy/tool/mocktool.py:
3232
3233 2011-01-03  Adam Barth  <abarth@webkit.org>
3234
3235         Reviewed by Simon Fraser.
3236
3237         webkit-patch shouldn't waste time cleaning a working directory that's already clean
3238         https://bugs.webkit.org/show_bug.cgi?id=51840
3239
3240         * Scripts/webkitpy/common/checkout/scm.py:
3241
3242 2011-01-03  Adam Barth  <abarth@webkit.org>
3243
3244         Reviewed by Simon Fraser.
3245
3246         webkit-patch should only hide update output if --quiet
3247         https://bugs.webkit.org/show_bug.cgi?id=51838
3248
3249         As requested by smfr.
3250
3251         * Scripts/webkitpy/tool/steps/update.py:
3252
3253 2011-01-03  Adam Barth  <abarth@webkit.org>
3254
3255         Reviewed by David Levin.
3256
3257         commit-queue shouldn't reject patches twice if two bots process the same patch
3258         https://bugs.webkit.org/show_bug.cgi?id=51805
3259
3260         Before raising an error, we first check whether the patch is still in
3261         the commit-queue.  This check is still racy, of course, but the time
3262         window is much smaller.
3263
3264         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
3265
3266 2011-01-03  Sam Weinig  <sam@webkit.org>
3267
3268         Reviewed by Anders Carlsson.
3269
3270         Make run-api-tests less chatty.
3271         https://bugs.webkit.org/show_bug.cgi?id=51831
3272
3273         - Make script quiet by default and add --verbose option (replacing --quiet).
3274         - When not verbose, pipe stdout and stderr to devnull.
3275
3276         * Scripts/run-api-tests:
3277
3278 2011-01-03  Pratik Solanki  <psolanki@apple.com>
3279
3280         Unreviewed. Adding myself to committers.py.
3281
3282         * Scripts/webkitpy/common/config/committers.py:
3283
3284 2011-01-03  Koan-Sin Tan  <koansin.tan@gmail.com>
3285
3286         Reviewed by Xan Lopez.
3287
3288         "Tool/Scripts/run-launcher --gtk" stopped working after 74855
3289         https://bugs.webkit.org/show_bug.cgi?id=51806
3290
3291         Originally, the $libraryName is 'JavaScriptCore'. When building release 
3292         one, the $libraryDir was 'WebKitBuild/Release/JavaScriptCore/../.libs/'
3293         which doesn't exist anymore ('WebKitBuild/Release/JavaScriptCore'
3294         is 'WebKitBuild/Release/Source/JavaScriptCore' now), and 
3295         'WebKitBuild/Release/Source/JavaScriptCore/../../.libs' looks weird,
3296         so make it 'WebKitBuild/Release/.libs'
3297
3298         * Scripts/webkitdirs.pm: 
3299
3300 2011-01-02  Patrick Gansterer  <paroga@webkit.org>
3301
3302         Reviewed by Adam Barth.
3303
3304         Make EFL a core builder
3305         https://bugs.webkit.org/show_bug.cgi?id=51804
3306
3307         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
3308         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
3309
3310 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3311
3312         [Qt] Unreviewed fix after r74855 and r74875.
3313
3314         * BuildSlaveSupport/built-product-archive:
3315          - Create directories explicitly.
3316          - Pass shell=True to subprocess.call().
3317
3318 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3319
3320         [Qt] Unreviewed fix after r74855.
3321
3322         Move JavaScriptCore to Source
3323         https://bugs.webkit.org/show_bug.cgi?id=51604
3324
3325         * BuildSlaveSupport/built-product-archive: JavaScriptCore -> Source/JavaScriptCore
3326
3327 2011-01-02  Csaba Osztrogonác  <ossy@webkit.org>
3328
3329         [Qt] Unreviewed run-javasriptcore-tests fix after r74855.
3330
3331         Move JavaScriptCore to Source
3332         https://bugs.webkit.org/show_bug.cgi?id=51604
3333
3334         * Scripts/webkitdirs.pm:
3335
3336 2011-01-02  Robert Hogan  <robert@webkit.org>
3337
3338         Unreviewed, build fix.
3339
3340         [Qt] Fix DRT build after 74855
3341
3342         * DumpRenderTree/qt/DumpRenderTree.pro:
3343
3344 2011-01-01  Adam Barth  <abarth@webkit.org>
3345
3346         Remove the assumption from the Qt and Gtk builds that every project is
3347         in the root directory.
3348
3349         * Scripts/build-webkit:
3350
3351 2011-01-01  Adam Barth  <abarth@webkit.org>
3352
3353         Reviewed by Eric Seidel.
3354
3355         Teach svn-apply how to apply patches even though JavaScriptCore has moved
3356         https://bugs.webkit.org/show_bug.cgi?id=51796
3357
3358         After this change, svn-apply will magically apply patches to
3359         JavaScriptCore/foo to Source/JavaScriptCore/foo.
3360
3361         * Scripts/VCSUtils.pm:
3362
3363 2011-01-01  Adam Barth  <abarth@webkit.org>
3364
3365         Reviewed by Eric Seidel.
3366
3367         Move JavaScriptCore to Source
3368         https://bugs.webkit.org/show_bug.cgi?id=51604
3369
3370         Update references to JavaScriptCore to point to the new location.
3371
3372         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3373         * DumpRenderTree/qt/DumpRenderTree.pro:
3374         * DumpRenderTree/qt/ImageDiff.pro:
3375         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3376         * DumpRenderTree/wscript:
3377         * Scripts/build-jsc:
3378         * Scripts/build-webkit:
3379         * Scripts/do-file-rename:
3380         * Scripts/do-webcore-rename:
3381         * Scripts/run-javascriptcore-tests:
3382         * Scripts/update-javascriptcore-test-results:
3383         * Scripts/webkitdirs.pm:
3384         * Scripts/webkitpy/common/config/build_unittest.py:
3385         * Scripts/webkitpy/style/checker.py:
3386         * Scripts/webkitpy/style/checker_unittest.py:
3387         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3388         * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
3389         * WebKitTestRunner/qt/WebKitTestRunner.pro:
3390         * wx/build/settings.py:
3391
3392 2011-01-01  Adam Barth  <abarth@webkit.org>
3393
3394         Reviewed by Eric Seidel.
3395
3396         Move Sources to Source
3397         https://bugs.webkit.org/show_bug.cgi?id=51794
3398
3399         Update scripts to point to the new location.
3400
3401         * Scripts/build-webkit:
3402         * Scripts/do-file-rename:
3403         * Scripts/do-webcore-rename:
3404         * Scripts/webkitpy/common/config/build.py:
3405         * Scripts/webkitpy/common/config/build_unittest.py:
3406
3407 2010-12-31  Kent Tamura  <tkent@chromium.org>
3408
3409         Reviewed by Eric Seidel.
3410
3411         [DRT/Chromium] Enable mock spell checker on non-OSX
3412         https://bugs.webkit.org/show_bug.cgi?id=51401
3413
3414         * DumpRenderTree/chromium/WebViewHost.cpp:
3415         (WebViewHost::spellCheck):
3416
3417 2010-12-31  Adam Barth  <abarth@webkit.org>
3418
3419         Reviewed by Ariya Hidayat.
3420
3421         Remove Tools/Scripts/wkstyle
3422         https://bugs.webkit.org/show_bug.cgi?id=51774
3423
3424         This script appears to not have been touched in a while and seems to
3425         have been replaced by check-webkit-style.
3426
3427         * Scripts/wkstyle: Removed.
3428
3429 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3430
3431         Unreviewed. Coding style fix.
3432
3433         * DumpRenderTree/chromium/TestShell.h:
3434
3435 2010-12-31  Ilya Tikhonovsky  <loislo@chromium.org>
3436
3437         Reviewed by Pavel Feldman.
3438
3439         Web Inspector: [Chromium] Inspector's tests are very slow on Win(Dbg).
3440
3441         It was a problem with Chromium DRT. DevToolsAgent object instance was
3442         attached not only to the inspected page but to the DevTools window too.
3443         As result all the inspector files were interpreted as a content of inspected page
3444         and were transfered to the DevTools scripts panel for debugging etc.
3445
3446         https://bugs.webkit.org/show_bug.cgi?id=51735
3447
3448         * DumpRenderTree/chromium/TestShell.cpp:
3449         (TestShell::TestShell):
3450         (TestShell::bindJSObjectsToWindow):
3451         (TestShell::createNewWindow):
3452         * DumpRenderTree/chromium/TestShell.h:
3453
3454 2010-12-31  Adam Barth  <abarth@webkit.org>
3455
3456         Rubber-stamped by Eric Seidel.
3457
3458         Move PageLoadTests to PerformanceTests/PageLoad
3459         https://bugs.webkit.org/show_bug.cgi?id=51771
3460
3461         Update references to PageLoadTests to point to the new location.
3462
3463         * Scripts/run-pageloadtest:
3464         * Scripts/webkitpy/common/config/build.py:
3465
3466 2010-12-31  Adam Barth  <abarth@webkit.org>
3467
3468         Rubber-stamped by Eric Seidel.
3469
3470         Move SunSpider into PerformanceTests
3471         https://bugs.webkit.org/show_bug.cgi?id=51769
3472
3473         Update these scripts to point to the new location.
3474
3475         * Scripts/run-sunspider:
3476         * Scripts/sunspider-compare-results:
3477
3478 2010-12-30  Mihai Parparita  <mihaip@chromium.org>
3479
3480         Reviewed by Kent Tamura.
3481
3482         [Chromium] Add WebThemeEngineDRTMac so that Chromium DRT scrollbar rendering can match the Mac port's
3483         https://bugs.webkit.org/show_bug.cgi?id=51728
3484         
3485         Add implementation of the Mac WebThemeEngine that uses an NSScroller
3486         to render top-level scrollbars. This makes them match the Mac port's
3487         use of an NSScrollView, which means that we'll be able to share more
3488         pixel baselines.
3489         
3490         The new rendering code will not be activated until the 
3491         USE_WEB_THEME_ENGINE_TO_PAINT_THUMB #define is fliped in
3492         ScrollbarThemeChromiumMac.
3493
3494         * DumpRenderTree/DumpRenderTree.gypi:
3495         * DumpRenderTree/chromium/TestShellMac.mm:
3496         (platformInit):
3497         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h: Added.
3498         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm: Added.
3499         (+[FakeActiveWindow alwaysActiveWindow]):
3500         (+[FakeActiveWindow alwaysInactiveWindow]):
3501         (-[FakeActiveWindow initWithActiveControls:]):
3502         (-[FakeActiveWindow _hasActiveControls]):
3503         (WebThemeEngineDRTMac::paintScrollbarThumb):
3504         (stateToHIEnableState):
3505         (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
3506         (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
3507
3508 2010-12-30  Konstantin Tokarev  <annulen@yandex.ru>
3509
3510         Reviewed by David Kilzer.
3511
3512         [Qt] Don't build wtf/TCSystemAlloc.cpp if --system-malloc option is
3513         used
3514         https://bugs.webkit.org/show_bug.cgi?id=51672
3515
3516         * DumpRenderTree/qt/DumpRenderTree.pro: Replaced USE_SYSTEM_MALLOC
3517         with USE_SYSTEM_MALLOC=1
3518         * WebKitTestRunner/qt/WebKitTestRunner.pro: Replaced USE_SYSTEM_MALLOC
3519         with USE_SYSTEM_MALLOC=1
3520
3521 2010-12-30  Laszlo Gombos  <laszlo.1.gombos@nokia.com>
3522
3523         Reviewed by David Kilzer.
3524
3525         [Qt] [Symbian] Fix build-webkit script for Symbian
3526         https://bugs.webkit.org/show_bug.cgi?id=51509
3527
3528         Set the OUTPUT_DIR for Symbian to be the same as the source
3529         directory.
3530
3531         * Scripts/webkitdirs.pm:
3532
3533 2010-12-30  Martin Robinson  <mrobinson@igalia.com>
3534
3535         Reviewed by Darin Adler.
3536
3537         check-webkit-style should ignore NULL usage in calls to gtk_widget_style_get
3538         https://bugs.webkit.org/show_bug.cgi?id=51758
3539
3540         Add a check-webkit-style exception for gtk_widget_style_get and NULL usage.
3541
3542         * Scripts/webkitpy/style/checkers/cpp.py: Add the exception.
3543         * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.
3544
3545 2010-12-29  Patrick Gansterer  <paroga@webkit.org>
3546
3547         Unreviewed WinCE buildfix.
3548
3549         * WinCELauncher/main.cpp: Add missing include.
3550
3551 2010-12-29  Daniel Bates  <dbates@rim.com>
3552
3553         Reviewed by Darin Adler.
3554
3555         svn-apply updates date of wrong change log entry for a change log diff that
3556         contains two consecutive entries with the same author and date
3557         https://bugs.webkit.org/show_bug.cgi?id=46061
3558
3559         Fixes an issue where the date of the wrong change log entry may be modified.
3560         Moreover, changes fixChangeLogPatch() to move entries inserted earlier
3561         in a ChangeLog file to the top of the file.
3562
3563         Currently, fixChangeLogPatch() explicitly bails out and returns an unchanged
3564         diff when it detects that the diff inserts a change log entry earlier in a
3565         ChangeLog. It is unusual to land a patch that has such a deliberate ChangeLog
3566         change. With the advent of the commit-queue this functionality of bailing out
3567         and hence landing the patch as-is is harmful to the accuracy of the ChangeLog.
3568         Instead, we should always move the change log entry to the top of the ChangeLog file.
3569
3570         A side-effect of this change is that setChangeLogDateAndReviewer() now updates
3571         the date line of the correct change log entry in a ChangeLog diff.
3572
3573         * Scripts/VCSUtils.pm: Modified fixChangeLogPatch() to move entries inserted earlier to the top.
3574
3575         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:
3576           Updated the following unit tests now that we move entries inserted earlier to the top:
3577           - "fixChangeLogPatch: New entry inserted in middle."
3578             (formerly named "fixChangeLogPatch: [no change] New entry inserted in middle.")
3579
3580           - "fixChangeLogPatch: New entry inserted earlier in the file, but after an entry with the same author and date."
3581             (formerly named "fixChangeLogPatch: [no change] New entry inserted earlier in the file, but after an entry with the same author and date.")
3582
3583         * Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatchThenSetChangeLogDateAndReviewer.pl: Added.
3584
3585 2010-12-29  Konstantin Tokarev  <annulen@yandex.ru>
3586
3587         Reviewed by Eric Seidel.
3588
3589         [Qt] Fixed compatibility with gold linker on X11 platforms
3590         https://bugs.webkit.org/show_bug.cgi?id=51700
3591
3592         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
3593         Linked TestNetscapePlugin with libX11 on Unix platforms
3594
3595 2010-12-29  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>
3596
3597         Reviewed by Darin Adler.
3598
3599         Circular dependency in webkitpy.common.checkout.changelog module
3600         https://bugs.webkit.org/show_bug.cgi?id=50475
3601
3602         Remove automatic import of api.Checkout module when any checkout/
3603         submodule is imported (e.g.: when checkout.scm.Git is imported).
3604
3605         * Scripts/webkitpy/common/checkout/__init__.py:
3606
3607 2010-12-29  Martin Robinson  <mrobinson@igalia.com>
3608
3609         Reviewed by Ojan Vafai.
3610
3611         prepare-ChangeLog should support the -g option for specifying the git-commit
3612         https://bugs.webkit.org/show_bug.cgi?id=51708
3613
3614         Add a -g shortcut for the --git-commit prepare-ChangeLog option. This matches
3615         webkit-patch, though the exact meaning of the two options remain different.
3616
3617         * Scripts/prepare-ChangeLog: Add -g.
3618
3619 2010-12-29  Kent Hansen  <kent.hansen@nokia.com>
3620
3621         Reviewed by Simon Hausmann.
3622
3623         [Qt] Fix compilation with Qt in namespace
3624         https://bugs.webkit.org/show_bug.cgi?id=51701
3625
3626         * QtTestBrowser/webview.h:
3627
3628 2010-12-28  Daniel Bates  <dbates@rim.com>
3629
3630         Reviewed by Sam Weinig.
3631
3632         Substitute // MARK: for compiler-specific #pragma mark
3633         https://bugs.webkit.org/show_bug.cgi?id=51657
3634
3635         Fix future compilation warnings about "#pragma mark" on GTK+ bots by
3636         substituting  "// MARK:" for "#pragma mark", which provides
3637         analogous code-bookmarking functionality under Xcode.
3638
3639         Also, for consistency, we should substitute "// MARK:" for compiler-
3640         specific "#pragma mark" in the source files for the Mac port.
3641
3642         * DumpRenderTree/AccessibilityTextMarker.cpp:
3643         * DumpRenderTree/cf/WebArchiveDumpSupport.h:
3644         * DumpRenderTree/mac/AccessibilityTextMarkerMac.mm:
3645         * DumpRenderTree/mac/ObjCController.m:
3646         * MiniBrowser/mac/AppDelegate.m:
3647         * MiniBrowser/mac/BrowserWindowController.m:
3648
3649 2010-12-28  Xan Lopez  <xlopez@igalia.com>
3650
3651         Reviewed by Eric Seidel.
3652
3653         Add --no-build option to run-sunspider
3654         https://bugs.webkit.org/show_bug.cgi?id=51658
3655
3656         * Scripts/run-sunspider: add --no-build flag to skip building
3657         phase.
3658
3659 2010-12-27  Daniel Bates  <dbates@rim.com>
3660
3661         Rubber-stamped by Martin Robinson.
3662
3663         Append the directory Tools/DumpRenderTree to the list of directories that
3664         do-webcore-rename should search so that it can rename DRT files and
3665         source code.
3666
3667         * Scripts/do-webcore-rename:
3668
3669 2010-12-27  Eric Seidel  <eric@webkit.org>
3670
3671         Reviewed by Adam Barth.
3672
3673         build-webkit should detect missing Java SDK and explain how to install it
3674         https://bugs.webkit.org/show_bug.cgi?id=51651
3675
3676         * Scripts/build-webkit:
3677
3678 2010-12-26  Martin Robinson  <mrobinson@igalia.com>
3679
3680         Reviewed by Daniel Bates.
3681
3682         [GTK] Add support for build-jsc
3683         https://bugs.webkit.org/show_bug.cgi?id=51625
3684
3685         Add GTK+ support to build-jsc now that building the jsc executable as
3686         a standalone target is easy.
3687
3688         * Scripts/build-jsc: Call buildGtkProject for the GTK+ case now.
3689         * Scripts/build-webkit: Pass in the proper target name to buildGtkProject.
3690         * Scripts/webkitdirs.pm: Actually process the project parameter in buildGtkProject
3691         and pass it along to buildAutotoolsProject.
3692
3693 2010-12-27  David Levin  <levin@chromium.org>
3694
3695         Reviewed by Eric Seidel.
3696
3697         check-webkit-style check for meaningless variable names in function declarations.
3698         https://bugs.webkit.org/show_bug.cgi?id=51523
3699
3700         * Scripts/webkitpy/style/checker.py: Exempted JavaScriptCore/jit/JITStubs.cpp
3701         from the new check and whitespace/parens because the syntax is unusual and
3702         produced a fair number of positives for these checks.
3703         * Scripts/webkitpy/style/checkers/cpp.py:
3704         (_convert_to_lower_with_underscores): Used as a canonical form for type names
3705         and parameter names when determining if the parameter name is useless.
3706         (_create_acronym): Used to check for redundant variable names in cases like "ExceptionCode ec"
3707         (Parameter.lower_with_underscores_name): Gives back the parameter name in a lower_with_underscore
3708         format.
3709         (_check_parameter_name_against_text):  Checks to see if the parameter name is in the
3710         text or an acronym of it.
3711         (check_function_definition): Checks function definitions for meaningless variable names.
3712         (process_line): Added call to check_function_definition.
3713         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3714         (CppFunctionsTest.test_convert_to_lower_with_underscores): Test for _convert_to_lower_with_underscores.
3715         (CppFunctionsTest.test_create_acronym): Test for _create_acronym.
3716         (CppFunctionsTest.test_check_parameter_against_text): Test for _check_parameter_against_text.
3717         (CppStyleTestBase.perform_single_line_lint): Removed the parameter name check
3718         because when only checking a snippet, there are a lot of bogus functions.
3719         (CppStyleTestBase.perform_multi_line_lint): Ditto and removed a bogus filter
3720         that I put there previously and just noticed.
3721         (WebKitStyleTest.test_parameter_names): Tests for the functionality -- both
3722         check_function_definition and process_line.
3723
3724 2010-12-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3725
3726         Reviewed by Martin Robinson.
3727
3728         [GTK] Disable flash plugin in GtkLauncher when using gtk3
3729         https://bugs.webkit.org/show_bug.cgi?id=51591
3730
3731         Flash plugin uses gtk2 that is incompatible with gtk3 making
3732         webkit crash when it's built with gtk3.
3733
3734         * GtkLauncher/main.c:
3735         (main):
3736
3737 2010-12-25  Adam Barth  <abarth@webkit.org>
3738
3739         Reviewed by Eric Seidel.
3740
3741         Move ANGLE to Sources/ThirdParty
3742         https://bugs.webkit.org/show_bug.cgi?id=51605
3743
3744         * Scripts/build-webkit:
3745           - Point to the new ANGLE location.
3746
3747 2010-12-26  David Levin  <levin@chromium.org>
3748
3749         Reviewed by Eric Seidel.
3750
3751         check-webkit-style should be able to parse function declaration parameters.
3752         https://bugs.webkit.org/show_bug.cgi?id=51451
3753
3754         * Scripts/webkitpy/style/checkers/cpp.py:
3755         (Position.__init__): Holds simple position information (row, column).
3756         (Parameter.__init__): Holds information about a parameter.
3757         (SingleLineView.__init): Converts multiple lines into a single line for simpler searches.
3758         (SingleLineView.convert_column_to_row): Returns the original row given a column.
3759         (create_skeleton_parameters): Simplifies a parameter list for easier searching.
3760         (find_parameter_name_index): Finds where the parameter name is.
3761         (parameter_list): Generates the list of parameters for a function.
3762         (_FunctionState.begin): Added information to allow determining the parameters
3763         on demand.
3764         (_FunctionState.get_parameter_list): Returns a tuple of function parameters.
3765         (detect_functions): Improve function detection for operator functions and
3766         determine where the parameters end and pass that to _FunctionState.begin.
3767         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3768         (CppFunctionsTest.test_parameter): Verifies Parameter functionality.
3769         (CppFunctionsTest.test_single_line_view): Verifies SingleLineView functionality.
3770         (CppFunctionsTest.test_create_skeleton_parameters): Verifies create_skeleton_parameters.
3771         (CppFunctionsTest.test_find_parameter_name_index): Verifies find_parameter_name_index.
3772         (CppFunctionsTest.test_parameter_list): Does some minimal verification for parameter list.
3773         Much more thorough verification is done as part of FunctionDetectionTest.test_parameter_list.
3774         (FunctionDetectionTest.perform_function_detection): Added support for verifying
3775         the parameters found.
3776         (FunctionDetectionTest.test_function_declaration_detection): Added more function
3777         detection test to verify that we catch the operator functions.
3778         (FunctionDetectionTest.test_ignore_macros): Verify that function detection ignores macros.
3779         (FunctionDetectionTest.test_parameter_list): Added tests to verify the parameter parsing.
3780         (CheckForFunctionLengthsTest.test_function_length_check_definition_severity1_for_bad_test_doesnt_break): Removed
3781         because the error. The test is about the bad function name. Fixing the name makes the test exactly like
3782         test_function_length_check_definition_severity1_for_test.
3783
3784 2010-12-25  Patrick Gansterer  <paroga@webkit.org>
3785
3786         Unreviewed WinCE buildfix after r74334.
3787
3788         * CMakeListsWinCE.txt:
3789
3790 2010-12-24  Sheriff Bot  <webkit.review.bot@gmail.com>
3791
3792         Unreviewed, rolling out r74632.
3793         http://trac.webkit.org/changeset/74632
3794         https://bugs.webkit.org/show_bug.cgi?id=51600
3795
3796         makes test-webkitpy hang forever on GTK (Requested by philn-tp
3797         on #webkit).
3798
3799         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3800         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3801
3802 2010-12-24  Ryuan Choi  <ryuan.choi@samsung.com>
3803
3804         Reviewed by Kenneth Rohde Christiansen.
3805
3806         [EFL] Screen doesn't be rendered when changing size of EWebLauncher
3807         https://bugs.webkit.org/show_bug.cgi?id=43528
3808
3809         Remove on_resize because ewk_view_fixed_layout_size_set should not be
3810         called on callback of EVAS_CALLBACK_RESIZE. As it change size of
3811         FrameView, rendering was ignored when _ewk_view_smart_calculate was
3812         called.
3813
3814         * EWebLauncher/main.c:
3815         (browserCreate):
3816
3817 2010-12-24  Eric Seidel  <eric@webkit.org>
3818
3819         Reviewed by Adam Barth.
3820
3821         webkit-patch (or a pre-commit hook) needs to prevent bad ChangeLog changes
3822         https://bugs.webkit.org/show_bug.cgi?id=28291
3823
3824         This is a start.  At least now webkit-patch will prompt when your ChangeLog looks questionable.
3825         We could do more advanced things, like parsing the ChangeLog (with changelog.py) and comparing that
3826         to strings with find in the diff.
3827         Since non-interactive always returns the default, this should cause patches with bad changelogs to fail on the commit-queue.
3828
3829         * Scripts/webkitpy/common/checkout/api.py:
3830         * Scripts/webkitpy/common/checkout/diff_parser.py:
3831         * Scripts/webkitpy/tool/steps/abstractstep.py:
3832         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
3833         * Scripts/webkitpy/tool/steps/validatechangelogs.py: Copied from Tools/Scripts/webkitpy/tool/steps/validatereviewer.py.
3834         * Scripts/webkitpy/tool/steps/validatechangelogs_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/cleanworkingdirectory.py.
3835         * Scripts/webkitpy/tool/steps/validatereviewer.py:
3836
3837 2010-12-24  Dirk Pranke  <dpranke@chromium.org>
3838
3839         Reviewed by Kenneth Russell.
3840
3841         Modify new-run-webkit-tests to shut up and exit when all the threads
3842         are wedged so that test runs complete faster and we don't end up
3843         w/ enormous log files.
3844
3845         https://bugs.webkit.org/show_bug.cgi?id=51572
3846
3847         * Scripts/webkitpy/layout_tests/layout_package/message_broker.py:
3848         * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py:
3849
3850 2010-12-24  Eric Seidel  <eric@webkit.org>
3851
3852         Reviewed by David Levin.
3853
3854         commit-queue should better explain how it will re-open bugs and follow duplicate chains
3855         https://bugs.webkit.org/show_bug.cgi?id=51549
3856
3857         I've had multiple people ask me about the commit-queue's behavior
3858         regarding reporting flaky tests.  I figured it would be best to just
3859         have the queue explain itself in the bugs it files.
3860
3861         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
3862         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
3863
3864 2010-12-24  Shinichiro Hamaji  <hamaji@chromium.org>
3865
3866         Reviewed by Eric Seidel.
3867
3868         check-webkit-style: should ignore "wrong" namings in JavaScriptCore/qt
3869         https://bugs.webkit.org/show_bug.cgi?id=51467
3870
3871         * Scripts/webkitpy/style/checker.py:
3872         * Scripts/webkitpy/style/checker_unittest.py:
3873
3874 2010-12-23  Adam Barth  <abarth@webkit.org>
3875
3876         Rubber-stamped by Eric Seidel.
3877
3878         Move JavaScriptGlue into Sources
3879         https://bugs.webkit.org/show_bug.cgi?id=51583
3880
3881         These tools refer to JavaScriptGlue and need to be updated to its new
3882         location.
3883
3884         * Scripts/build-webkit:
3885         * Scripts/do-file-rename:
3886         * Scripts/do-webcore-rename:
3887         * Scripts/webkitpy/common/config/build.py:
3888         * Scripts/webkitpy/common/config/build_unittest.py:
3889
3890 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3891
3892         Reviewed by Eric Seidel.
3893
3894         Bug 51539 - update iexploder scripts to point to new location
3895
3896         * Scripts/run-iexploder-tests:
3897         * Scripts/update-iexploder-cssproperties:
3898
3899 2010-12-23  Evan Martin  <evan@chromium.org>
3900
3901         Reviewed by Ryosuke Niwa.
3902
3903         [chromium] LayoutTestController warning in float->int conversion
3904         https://bugs.webkit.org/show_bug.cgi?id=51553
3905
3906         Rather than reading an int, converting to a float, then getting a compiler
3907         warning on passing the float to something that expects an int, instead
3908         just pass around ints.
3909
3910         No tests, fixes a compiler warning.
3911
3912         * DumpRenderTree/chromium/LayoutTestController.cpp:
3913         (parsePageSizeParameters):
3914         (LayoutTestController::pageNumberForElementById):
3915         (LayoutTestController::numberOfPages):
3916
3917 2010-12-23  Lucas Forschler  <lforschler@apple.com>
3918
3919         Reviewed by Darin Adler.
3920
3921         Bug 51537 - iexploder needs cleanup
3922         
3923         * iExploder/htdocs: Removed.
3924         * iExploder/htdocs/config.rb: Removed.
3925         * iExploder/htdocs/cssproperties.in: Removed.
3926         * iExploder/htdocs/cssvalues.in: Removed.
3927         * iExploder/htdocs/htmlattrs.in: Removed.
3928         * iExploder/htdocs/htmltags.in: Removed.
3929         * iExploder/htdocs/htmlvalues.in: Removed.
3930         * iExploder/htdocs/iexploder.cgi: Removed.
3931         * iExploder/htdocs/iexploder.rb: Removed.
3932         * iExploder/htdocs/index.html: Removed.
3933         * iExploder/htdocs/webserver.rb: Removed.
3934         * iExploder/iexploder-1.7.2/output: Removed.
3935         * iExploder/tools: Removed.
3936         * iExploder/tools/lasthit.rb: Removed.
3937         * iExploder/tools/osx_last_crash.rb: Removed.
3938         * iExploder/tools/showtest.rb: Removed.
3939
3940 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3941
3942         Reviewed by Kenneth Rohde Christiansen.
3943
3944         [EFL] Make 'single' the default backing store in EWebLauncher
3945         https://bugs.webkit.org/show_bug.cgi?id=51534
3946
3947         'single' is the simplest backing store and the one intended to be the
3948         default in the test browser. By mistake the tiled backing store was
3949         left as default in r72617.
3950
3951         * EWebLauncher/main.c:
3952         (browserCreate): ditto.
3953
3954 2010-12-23  Lucas De Marchi  <lucas.demarchi@profusion.mobi>
3955
3956         Reviewed by Kenneth Rohde Christiansen.
3957
3958         [EFL] Subject: [webkit 4/4] [EFL] Remove non-sense workaround
3959         https://bugs.webkit.org/show_bug.cgi?id=51533
3960
3961         There's no point in concatenating env("HOME") with "blah", so remove
3962         option from EWebLauncher.
3963
3964         * EWebLauncher/main.c:
3965         (main): ditto.
3966
3967 2010-12-23  Ilya Tikhonovsky  <loislo@chromium.org>
3968
3969         Reviewed by Eric Seidel.
3970
3971         Web Inspector: chromium: inspector's tests are quite slow especially at windows(Debug).
3972
3973         Almost all inspector's tests become flaky on chromium Win(dbg) after switching to DRT.
3974         I just discovered that we have two additional GC runs per each WebViewHost.
3975         Test_shell had no such calls.
3976         These gc runs eat 15% of cpu time.
3977
3978         https://bugs.webkit.org/show_bug.cgi?id=51479
3979
3980         * DumpRenderTree/chromium/WebViewHost.cpp:
3981         (WebViewHost::~WebViewHost):
3982
3983 2010-12-22  Dirk Pranke  <dpranke@chromium.org>
3984
3985         Reviewed by Ojan Vafai.
3986
3987         This change splits out the TestRunner class into its own file.
3988         When we fork the code for message passing, we will create a new
3989         TestRunner, and this change will allow that to be more modular.
3990
3991         While we're at it, split out TestInput and ResultSummary into
3992         their own files, to reduce the size of run_webkit_tests to
3993         something more managable.
3994
3995         https://bugs.webkit.org/show_bug.cgi?id=51092
3996
3997         * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
3998         * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
3999         * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
4000         * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
4001         * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
4002         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4003         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4004
4005  2010-12-22  Dirk Pranke  <dpranke@chromium.org>
4006
4007         Reviewed by Ojan Vafai.
4008
4009         nrwt multiprocessing - start over, prepare to fork the code
4010  
4011         This code cleans up the signatures and implementation of the
4012         TestRunner class so we can easily fork it to run either the
4013         stable implementation or the new, unstable message-passing
4014         implementation. The two variants will have different
4015         implementations of the run_tests() method. We will switch
4016         between the two based on the setting for the '--worker-model'
4017         switch. We rename the two currently valid values to 'old-inline'
4018         and 'old-threads'.
4019
4020         https://bugs.webkit.org/show_bug.cgi?id=51081
4021
4022         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4023         * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
4024
4025 2010-12-22  Victor Wang  <victorw@chromium.org>
4026
4027         Reviewed by Darin Fisher.
4028
4029         [Chromium] Update chromium archive test result url in rebaseline script.
4030
4031         https://bugs.webkit.org/show_bug.cgi?id=51503
4032
4033         * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
4034
4035 2010-12-22  Lucas Forschler  <lforschler@apple.com>
4036
4037         Reviewed by Alice Liu.
4038
4039         <rdar://problem/8633222> record-memory-win needs to record memory used by the webprocess.
4040         Verified on Chrome, Safari, and IE.
4041         With this change, we will record memory from a parent browser window and all child processes.
4042
4043         * record-memory-win/main.cpp:
4044         (ProcessArgs):
4045         (PrintUsage):
4046         (getMemoryInfo):
4047         (printProcessInfo):
4048         (evalProcesses):
4049         (UseImage):
4050         (QueryContinuously):
4051         (ElapsedTime):
4052
4053 2010-12-22  Lucas Forschler  <lforschler@apple.com>
4054
4055         Unreviewed rollout r74489, because it was missing changelog.
4056
4057         * record-memory-win/main.cpp:
4058         
4059 2010-12-22  Ryosuke Niwa  <rniwa@webkit.org>
4060
4061         Adding myself as a reviewer.
4062
4063         * Scripts/webkitpy/common/config/committers.py:
4064
4065 2010-12-22  Andrew Scherkus  <scherkus@chromium.org>
4066
4067         Unreviewed.  Adding myself to committers.py.
4068
4069         * Scripts/webkitpy/common/config/committers.py:
4070
4071 2010-12-22  Ariya Hidayat  <ariya@sencha.com>
4072
4073         Reviewed by Kenneth Rohde Christiansen.
4074
4075         TestNetscapePlugIn should use #if defined
4076         https://bugs.webkit.org/show_bug.cgi?id=51471
4077
4078         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
4079         (NP_Initialize):
4080         (NPP_New):
4081
4082 2010-12-22  Ilya Tikhonovsky  <loislo@chromium.org>
4083
4084         Reviewed by Yury Semikhatsky.
4085
4086         Web Inspector: [chromium] DRT inspector layout tests are flaky in debug.
4087
4088         DevTools window should be closed explicitly because it has custom deinitialization code.
4089
4090         https://bugs.webkit.org/show_bug.cgi?id=50722
4091
4092         * DumpRenderTree/chromium/TestShell.cpp:
4093         (TestShell::closeRemainingWindows):
4094
4095 2010-12-22  David Levin  <levin@chromium.org>
4096
4097         Reviewed by Shinichiro Hamaji.
4098
4099         check-webkit-style shouldn't complaint about underscores in variables in objective C files.
4100         https://bugs.webkit.org/show_bug.cgi?id=51452
4101
4102         * Scripts/webkitpy/style/checkers/cpp.py:
4103         (_FileState.__init__): Added the information to determine if a file is C or Objective C.
4104         Using the file extension if possible but falling back to the file contents if we have a header file.
4105         (_FileState.is_objective_c): Determine if we have an Objective C by examining the file contents if needed.
4106         (_FileState.is_c_or_objective_c):
4107         (check_using_std): Changed to using _FileState to determine the file type.
4108         (check_max_min_macros): Ditto.
4109         (check_for_null): Ditto.
4110         (check_style): Changed the parameters to various calls since they now need _FileState
4111         to determine the file type.
4112         (check_language): Added the file_state parameter so it could be passed
4113         to check_identifier_name_in_declaration.
4114         (check_identifier_name_in_declaration): Don't warn about underscores in variables if
4115         this is an Objective C file.
4116         (_process_lines): Added information for the _FileState constructor (and moved the
4117         call to a place that had the information).
4118         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4119         (CppFunctionsTest.test_is_c_or_objective_c): Changed the tests to use FileState and exercise
4120         its functionality.
4121         (WebKitStyleTest.test_names): Add tests for underscores in Objective C files.
4122
4123 2010-12-21  Andy Estes  <aestes@apple.com>
4124
4125         Reviewed by Mark Rowe.
4126
4127         Do not build non-Intel architectures for WebKit2-related projects.
4128         https://bugs.webkit.org/show_bug.cgi?id=51440
4129
4130         * MiniBrowser/Configurations/Base.xcconfig: Only build for i386 and x86_64.
4131         * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
4132         * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
4133
4134 2010-12-21  Mihai Parparita  <mihaip@chromium.org>
4135
4136         Reviewed by Darin Fisher.
4137
4138         [Chromium] Rename WebThemeEngine/ControlDRT to WebThemeEngine/ControlDRTWin
4139         https://bugs.webkit.org/show_bug.cgi?id=51406 
4140         
4141         Rename WebThemeControlDRT to WebThemeControlDRTWin and WebThemeEngineDRT
4142         to WebThemeEngineDRTWin and update references everywhere.
4143
4144         * DumpRenderTree/DumpRenderTree.gypi:
4145         * DumpRenderTree/chromium/TestShellWin.cpp:
4146         * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.cpp.
4147         * DumpRenderTree/chromium/WebThemeControlDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeControlDRT.h.
4148         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.cpp.
4149         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h: Renamed from Tools/DumpRenderTree/chromium/WebThemeEngineDRT.h.
4150
4151 2010-12-21  Anders Carlsson  <andersca@apple.com>
4152
4153         Reviewed by John Sullivan.
4154
4155         Clicking missing plug-in text does not show a sheet
4156         https://bugs.webkit.org/show_bug.cgi?id=51403
4157
4158         Update for changes to the WebPageUIClient.
4159
4160         * MiniBrowser/mac/BrowserWindowController.m:
4161         (-[BrowserWindowController awakeFromNib]):
4162         * WebKitTestRunner/TestController.cpp:
4163         (WTR::createOtherPage):
4164         (WTR::TestController::initialize):
4165
4166 2010-12-21  Eric Seidel  <eric@webkit.org>
4167
4168         Reviewed by Adam Barth.
4169
4170         commit-queue will report constant failures as flaky if other tests flake
4171         https://bugs.webkit.org/show_bug.cgi?id=51272
4172
4173         This patch just removes functionality and adds testing.
4174         Previously we attempted to report flaky tests when we had
4175         two different tests fail in a row.  However, since we stop
4176         running the tests at the first failure, our code was wrong in
4177         trying to determine flakiness from the incomplete runs.
4178
4179         Originally I posted an alternate patch:
4180         https://bug-51272-attachments.webkit.org/attachment.cgi?id=77078
4181         which fixed our flaky logic in this case, however it was decided
4182         that that patch would be too difficult to maintain, so now
4183         I'm just removing the broken logic.
4184
4185         This will dramatically cut-down on our flaky-test false positives
4186         at the (small) cost of the queues being unable to report
4187         any flakiness if the tree is very flaky.  (With at least one test
4188         flaking on every run, we'll never report failures anymore.)  I think
4189         this is a tradeoff worth making.
4190
4191         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4192         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4193
4194 2010-12-20  Eric Seidel  <eric@webkit.org>
4195
4196         Reviewed by Adam Barth.
4197
4198         commit-queue wrongly rejects patches when it can't update itself
4199         https://bugs.webkit.org/show_bug.cgi?id=46636
4200
4201         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
4202         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
4203         * Scripts/webkitpy/tool/commands/queues_unittest.py:
4204
4205 2010-12-20  Adam Barth  <abarth@webkit.org>
4206
4207         Move web sites to Websites directory
4208         https://bugs.webkit.org/show_bug.cgi?id=51323
4209
4210         Update references to BugsSite to point to the new location.
4211
4212         This patch was never officially reviewed (because it was too large to
4213         upload to bugs.webkit.org), but it was discussed on webkit-dev and Mark
4214         Rowe gave me the green light.
4215
4216         * Scripts/old-run-webkit-tests:
4217         * Scripts/webkitpy/common/config/build.py:
4218         * Scripts/webkitpy/common/config/build_unittest.py:
4219         * Scripts/webkitpy/common/prettypatch.py:
4220         * Scripts/webkitpy/layout_tests/port/base.py:
4221         * Scripts/webkitpy/style/main.py:
4222
4223 2010-12-20  Adrienne Walker  <enne@google.com>
4224
4225         Unreviewed. Adding myself to the list of committers.
4226
4227         * webkitpy/common/config/committers.py:
4228
4229 2010-12-20  Mark Rowe  <mrowe@apple.com>
4230
4231         Reviewed by Dan Bernstein.
4232
4233         <rdar://problem/8757601> Don't install header files in to the Resources directory.
4234
4235         * Scripts/check-for-inappropriate-files-in-framework: Don't allow .h files in the
4236         Resources directory.
4237
4238 2010-12-20  Eric Seidel  <eric@webkit.org>
4239
4240         Reviewed by Adam Barth.
4241
4242         commit-queue should include bot id when attaching failure diffs
4243         https://bugs.webkit.org/show_bug.cgi?id=51280
4244
4245         This is a tiny change to include the bot id in the name of the attachment.
4246         Most of this diff is just changing the unit test expectations
4247         now that I hid the comment printing when the comment is None.
4248
4249         * Scripts/webkitpy/tool/bot/flakytestreporter.py:
4250         * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
4251         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4252         * Scripts/webkitpy/tool/mocktool.py:
4253
4254 2010-12-20  Jeff Miller  <jeffm@apple.com>
4255
4256         Reviewed by Dan Bernstein.
4257
4258         Tools/vcbin/midl.exe needs to be rebuilt
4259         https://bugs.webkit.org/show_bug.cgi?id=51347
4260
4261         * vcbin/midl.exe: Rebuilt.
4262
4263 2010-12-20  David Levin  <levin@chromium.org>
4264
4265         Reviewed by Ariya Hidayat.
4266
4267         .gitignore and webkit-tools-completion.sh have references to WebKitTools that should be Tools.
4268         https://bugs.webkit.org/show_bug.cgi?id=51343
4269
4270         Follow up from the WebKitTools -> Tools rename.
4271
4272         * Scripts/webkit-tools-completion.sh:
4273
4274 2010-12-20  Cosmin Truta  <ctruta@chromium.org>
4275
4276         Reviewed by James Robinson.
4277
4278         new-run-webkit-tests ignores trailing EOL differences in text tests
4279         https://bugs.webkit.org/show_bug.cgi?id=36983
4280
4281         Changed the handling of new-line characters within new-run-webkit-tests
4282         to match old-run-webkit-tests.  Differences in leading and trailing empty
4283         lines in text expectation files are no longer ignored.
4284
4285         * Scripts/webkitpy/layout_tests/port/base.py:
4286         * Scripts/webkitpy/layout_tests/port/test.py:
4287         Added unit tests.  Removed old duplicate unit test entries.
4288         * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
4289
4290 2010-12-20  David Levin  <levin@chromium.org>
4291
4292         Reviewed by Shinichiro Hamaji.
4293
4294         check-webkit-style should detect function declarations (and trivial functions).
4295         https://bugs.webkit.org/show_bug.cgi?id=51303
4296
4297         * Scripts/webkitpy/style/checkers/cpp.py:
4298         (_FunctionState.begin): Add is_declaration and changed the line count
4299         start to begin at -1 (which will keep the results consistent, since
4300         the starting line number passed in is one less in this change).
4301         (detect_functions): changed function detection to now catch trivial
4302         functions and declarations.
4303         (check_pass_ptr_usage): Don't check for Pass*Ptr on the first line
4304         of the function as this may look at return values (when processing
4305         a declaration).
4306         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
4307         (FunctionDetectionTest.perform_function_detection): Basic mechanics
4308         of testing the function detection.
4309         (FunctionDetectionTest.test_basic_function_detection): Test a simple
4310         function.
4311         (FunctionDetectionTest.test_function_declaration_detection): Test a
4312         declaration.
4313         (FunctionDetectionTest.test_non_functions): A test case for a case
4314         that caused the code to fail due to the { being in quotes.
4315         (PassPtrTest.test_pass_ref_ptr_return_value): Added some more test
4316         cases to help catch false alarms for return values.
4317         (PassPtrTest.test_pass_ref_ptr_member_variable): Ensure that
4318         we don't get false alarms for member variables either.
4319
4320 2010-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
4321
4322         Reviewed by Antonio Gomes.
4323
4324         [CMAKE] Rename WEBKITTOOLS_DIR to TOOLS_DIR
4325         https://bugs.webkit.org/show_bug.cgi?id=51319
4326
4327         * CMakeListsEfl.txt:
4328
4329 2010-12-18  Adam Barth  <abarth@webkit.org>
4330
4331         Reviewed by Sam Weinig.
4332
4333         Move WebKitExamplePlugins to Examples
4334         https://bugs.webkit.org/show_bug.cgi?id=51291
4335
4336         * Scripts/webkitpy/common/config/build.py:
4337
4338 2010-12-17  Csaba Osztrogonác  <ossy@webkit.org>
4339
4340         Unreviewed Qt buildfix after r74301.
4341
4342         Rename WebKitTools to Tools
4343         https://bugs.webkit.org/show_bug.cgi?id=49861
4344
4345         * MiniBrowser/DerivedSources.pro:
4346         * MiniBrowser/qt/MiniBrowser.pro:
4347
4348 2010-12-17  Dan Bernstein  <mitz@apple.com>
4349
4350         Reviewed by Simon Fraser.
4351
4352         Rename WebKitTools to Tools
4353         https://bugs.webkit.org/show_bug.cgi?id=49861
4354
4355         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4356         * CodeCoverage/README:
4357         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
4358         (WebCore::DumpRenderTree::initializeFonts):
4359         * EWSTools/start-commit-queue.sh:
4360         * EWSTools/start-queue.sh:
4361         * GNUmakefile.am:
4362         * MIDLWrapper/MIDLWrapper.cpp:
4363         (wmain):
4364         * MiniBrowser/qt/MiniBrowser.pro:
4365         * Scripts/build-api-tests:
4366         * Scripts/build-dumprendertree:
4367         * Scripts/build-webkit:
4368         * Scripts/build-webkittestrunner:
4369         * Scripts/generate-coverage-data:
4370         * Scripts/old-run-webkit-tests:
4371         * Scripts/run-api-tests:
4372         * Scripts/run-iexploder-tests:
4373         * Scripts/run-javascriptcore-tests:
4374         * Scripts/run-mangleme-tests:
4375         * Scripts/run-sunspider:
4376         * Scripts/run-webkit-websocketserver:
4377         * Scripts/sunspider-compare-results:
4378         * Scripts/test-webkitperl:
4379         * Scripts/test-webkitpy:
4380         * Scripts/update-iexploder-cssproperties:
4381         * Scripts/update-webkit:
4382         * Scripts/update-webkit-localizable-strings:
4383         * Scripts/webkitdirs.pm:
4384         * Scripts/webkitpy/common/checkout/scm.py:
4385         * Scripts/web