72f9b10527505ac2f60fa25b17aa2e6d64d59ed8
[WebKit-https.git] / Tools / ChangeLog
1 2019-04-30  Tim Horton  <timothy_horton@apple.com>
2
3         Fix the WebKitTestRunner build
4         https://bugs.webkit.org/show_bug.cgi?id=197449
5         <rdar://problem/50334169>
6
7         Reviewed by Alexey Proskuryakov.
8
9         * WebKitTestRunner/mac/EventSenderProxy.mm:
10         (-[EventSenderSyntheticEvent initPressureEventAtLocation:globalLocation:stage:pressure:stageTransition:phase:time:eventNumber:window:]):
11         (WTR::EventSenderProxy::mouseForceChanged):
12         Use some SPI instead of IPI.
13
14 2019-04-30  Chris Dumez  <cdumez@apple.com>
15
16         Regression(PSON) URL scheme handlers can no longer respond asynchronously
17         https://bugs.webkit.org/show_bug.cgi?id=197426
18         <rdar://problem/50256169>
19
20         Reviewed by Brady Eidson.
21
22         Add API test coverage.
23
24         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
25         (-[PSONScheme setShouldRespondAsynchronously:]):
26         (-[PSONScheme webView:startURLSchemeTask:]):
27         (-[PSONScheme webView:stopURLSchemeTask:]):
28
29 2019-04-30  Chris Dumez  <cdumez@apple.com>
30
31         Unreviewed, rolling out r244802.
32
33         Caused an API test failure
34
35         Reverted changeset:
36
37         "Regression(PSON) URL scheme handlers can no longer respond
38         asynchronously"
39         https://bugs.webkit.org/show_bug.cgi?id=197426
40         https://trac.webkit.org/changeset/244802
41
42 2019-04-30  Chris Dumez  <cdumez@apple.com>
43
44         Regression(PSON) URL scheme handlers can no longer respond asynchronously
45         https://bugs.webkit.org/show_bug.cgi?id=197426
46         <rdar://problem/50256169>
47
48         Reviewed by Brady Eidson.
49
50         Add API test coverage.
51
52         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
53         (-[PSONScheme setShouldRespondAsynchronously:]):
54         (-[PSONScheme webView:startURLSchemeTask:]):
55         (-[PSONScheme webView:stopURLSchemeTask:]):
56
57 2019-04-30  Chris Dumez  <cdumez@apple.com>
58
59         Only use a related page's process if that page has not been closed yet
60         https://bugs.webkit.org/show_bug.cgi?id=197393
61         <rdar://problem/50302423>
62
63         Reviewed by Tim Horton.
64
65         Add API test coverage.
66
67         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
68
69 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
70
71         [ews-build] Enable Bindings tests queue on new EWS
72         https://bugs.webkit.org/show_bug.cgi?id=197424
73
74         Reviewed by Lucas Forschler.
75
76         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
77         (StatusBubble):
78         * BuildSlaveSupport/ews-build/config.json:
79
80 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
81
82         [ews-build] Configure ews151 for running various tests
83         https://bugs.webkit.org/show_bug.cgi?id=197419
84
85         Reviewed by Lucas Forschler.
86
87         * BuildSlaveSupport/ews-build/config.json:
88
89 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
90
91         [ews-build] Parse and display bindings test failures
92         https://bugs.webkit.org/show_bug.cgi?id=197423
93
94         Reviewed by Lucas Forschler.
95
96         * BuildSlaveSupport/ews-build/steps.py:
97         (RunBindingsTests.__init__): Set timeout of 5 minutes.
98         (RunBindingsTests.start): Initialize log_observer for json output.
99         (RunBindingsTests.getResultSummary): Update step and build summary based on bindings test results.
100         (RunBindingsTests._addToLog): Method to add message to log.
101         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
102
103 2019-04-30  Pablo Saavedra  <psaavedra@igalia.com>
104
105         Unreviewed. Add myself as a committer.
106
107         * Scripts/webkitpy/common/config/contributors.json:
108
109 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
110
111         [ews-build] Enable webkitpy queue on new EWS
112         https://bugs.webkit.org/show_bug.cgi?id=197396
113
114         Reviewed by Lucas Forschler.
115
116         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
117         (StatusBubble):
118         * BuildSlaveSupport/ews-build/config.json:
119
120 2019-04-30  Aakash Jain  <aakash_jain@apple.com>
121
122         [ews-build] Parse and display webkitpy failures
123         https://bugs.webkit.org/show_bug.cgi?id=197395
124
125         Reviewed by Lucas Forschler.
126
127         * BuildSlaveSupport/ews-build/steps.py:
128         (RunWebKitPyTests.start): Initialize log_observer for json output.
129         (RunWebKitPyTests.getResultSummary): Update step and build summary based on webkitpy results.
130         (RunWebKitPyTests._addToLog): Method to add message to log.
131         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-test accordingly.
132
133 2019-04-29  Alex Christensen  <achristensen@webkit.org>
134
135         <rdar://problem/50299396> Fix internal High Sierra build
136         https://bugs.webkit.org/show_bug.cgi?id=197388
137
138         * DumpRenderTree/mac/Configurations/Base.xcconfig:
139         * MiniBrowser/Configurations/Base.xcconfig:
140         * MobileMiniBrowser/Configurations/Base.xcconfig:
141         * TestWebKitAPI/Configurations/Base.xcconfig:
142         * WebKitTestRunner/Configurations/Base.xcconfig:
143
144 2019-04-29  Youenn Fablet  <youenn@apple.com>
145
146         Remove spurious GVA printf logging
147         https://bugs.webkit.org/show_bug.cgi?id=197368
148         <rdar://problem/35975256>
149
150         Reviewed by Alexey Proskuryakov.
151
152         * Scripts/webkitpy/port/mac.py:
153         (MacPort.logging_patterns_to_strip):
154
155 2019-04-29  Youenn Fablet  <youenn@apple.com>
156
157         getDisplayMedia should be called on user gesture
158         https://bugs.webkit.org/show_bug.cgi?id=197356
159         <rdar://problem/50296074>
160
161         Reviewed by Eric Carlson.
162
163         Update test configuration to inject internals
164         so that we can use it to simulate a user click to call getDisplayMedia.
165
166         * TestWebKitAPI/Tests/WebKit/getDisplayMedia.html:
167         * TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
168         (TestWebKitAPI::GetDisplayMediaTest::SetUp):
169
170 2019-04-26  Stephanie Lewis  <slewis@apple.com>
171
172         run-benchmarks should have an intial prep and restore env call for tasks that are too expensive to do for every iteration
173         https://bugs.webkit.org/show_bug.cgi?id=197339
174
175         Reviewed by Dewei Zhu.
176
177         Add two new functions prepare_inital_env and restore_env_after_all_testing around the entire
178         test run for setup steps that are too expensive to do every iteration.
179
180         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
181         (BenchmarkRunner._run_benchmark):
182         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
183         (BrowserDriver):
184         (BrowserDriver.prepare_initial_env):
185         (BrowserDriver.restore_env_after_all_testing):
186         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
187         (LinuxBrowserDriver.prepare_initial_env):
188         (LinuxBrowserDriver.restore_env_after_all_testing):
189         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
190         (OSXBrowserDriver.prepare_initial_env):
191         (OSXBrowserDriver.restore_env_after_all_testing):
192
193 2019-04-28  Andy Estes  <aestes@apple.com>
194
195         Fix the watchOS engineering build.
196
197         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
198         (TestWebKitAPI::TEST): AVVideoPerformanceMetrics does not exist on watchOS.
199
200 2019-04-27  Chris Dumez  <cdumez@apple.com>
201
202         [WKTR] Move test timeout handling to the UIProcess
203         https://bugs.webkit.org/show_bug.cgi?id=197333
204
205         Reviewed by Darin Adler.
206
207         Move test timeout handling in WebKitTestRunner to the UIProcess to play nicely with PSON. Previously,
208         we'd start the timeout timer in the InjectedBundle, which would fail to account of the time spent in
209         every WebContent process in the case of swapping.
210
211         Also, because of process caching, the timeout timer would sometime fire in a cached process and it
212         would lead to crashes when firing the timer.
213
214         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
215         (WTR::InjectedBundle::didReceiveMessageToPage):
216         (WTR::InjectedBundle::done):
217         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
218         (WTR::InjectedBundle::shouldDumpPixels const):
219         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
220         (WTR::TestRunner::TestRunner):
221         (WTR::TestRunner::waitUntilDone):
222         (WTR::TestRunner::setWaitUntilDone):
223         * WebKitTestRunner/InjectedBundle/TestRunner.h:
224         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
225         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
226         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
227         * WebKitTestRunner/InjectedBundle/wpe/TestRunnerWPE.cpp:
228         * WebKitTestRunner/TestInvocation.cpp:
229         (WTR::TestInvocation::TestInvocation):
230         (WTR::TestInvocation::createTestSettingsDictionary):
231         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
232         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
233         (WTR::TestInvocation::initializeWaitToDumpWatchdogTimerIfNeeded):
234         (WTR::TestInvocation::invalidateWaitToDumpWatchdogTimer):
235         (WTR::TestInvocation::waitToDumpWatchdogTimerFired):
236         (WTR::TestInvocation::setWaitUntilDone):
237         (WTR::TestInvocation::done):
238         * WebKitTestRunner/TestInvocation.h:
239
240 2019-04-25  Yusuke Suzuki  <ysuzuki@apple.com>
241
242         [JSC] linkPolymorphicCall now does GC
243         https://bugs.webkit.org/show_bug.cgi?id=197306
244
245         Reviewed by Saam Barati.
246
247         The test is sensitive to allocations and even adding $vm makes it non-reproducible.
248         To add this test, we add `runWithoutBaseOption`.
249
250         * Scripts/run-jsc-stress-tests:
251
252 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
253
254         Update inactive reviewers' status to 'contributor'.
255
256         Accidentally skipped one at first.
257
258         * Scripts/webkitpy/common/config/contributors.json:
259
260 2019-04-26  Alexey Proskuryakov  <ap@apple.com>
261
262         Update inactive reviewers' status to 'contributor'.
263
264         * Scripts/webkitpy/common/config/contributors.json: The change.
265
266         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
267         * Scripts/webkitpy/common/checkout/checkout_mock.py:
268         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
269         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
270         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
271         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
272         * Scripts/webkitpy/tool/commands/queries_unittest.py:
273         * Scripts/webkitpy/tool/commands/upload_unittest.py:
274         Sadly, regression tests operate on a crazy mix of mock and live data for
275         contributors.json. It would be a substantial project to mock all code paths,
276         so changing the tests instead.
277
278 2019-04-26  Eric Carlson  <eric.carlson@apple.com>
279
280         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
281         https://bugs.webkit.org/show_bug.cgi?id=197171
282         <rdar://problem/47454979>
283
284         Reviewed by Youenn Fablet.
285
286         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
287         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
288         (TestWebKitAPI::TEST):
289
290 2019-04-26  David Kilzer  <ddkilzer@apple.com>
291
292         WebKitTestRunner leaks an NSDictionary and multiple JSStringRef objects
293         <https://webkit.org/b/197314>
294         <rdar://problem/50245252>
295
296         Reviewed by Simon Fraser.
297
298         * WebKitTestRunner/UIScriptControllerCocoa.mm:
299         (WTR::UIScriptController::lastUndoLabel const):
300         (WTR::UIScriptController::firstRedoLabel const):
301         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
302
303         * WebKitTestRunner/ios/HIDEventGenerator.mm:
304         (-[HIDEventGenerator sendEventStream:completionBlock:]):
305         - Call -autorelease to fix leak of NSDictionary.
306
307         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
308         (WTR::UIScriptController::accessibilitySpeakSelectionContent const):
309         (WTR::UIScriptController::selectFormPopoverTitle const):
310         (WTR::UIScriptController::textContentType const):
311         (WTR::UIScriptController::formInputLabel const):
312         (WTR::UIScriptController::scrollingTreeAsText const):
313         - Use adopt(JSStringCreateWithCFString(...)) to fix leaks.
314
315 2019-04-26  Jonathan Bedard  <jbedard@apple.com>
316
317         webkitpy: Running a single test will always use the default device
318         https://bugs.webkit.org/show_bug.cgi?id=195472
319         <rdar://problem/48724825>
320
321         Reviewed by Lucas Forschler.
322
323         It makes more sense to have the Manager class handle the case where a user specifically requests a test which is
324         skipped on the current configuration. This changes the behavior when running part of a test shard, now tests explicitly
325         requested will be run regardless of what shard they are in.
326
327         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
328         (LayoutTestFinder.skip_tests): Caller should manage running skipped tests which were explicitly requested.
329         * Scripts/webkitpy/layout_tests/controllers/manager.py:
330         (Manager.run): If a test is marked as skipped for the configuration, but was specifically requested, run it anyways
331         on the default device type.
332         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
333         (RunTest.test_run_chunk): Explicitly requesting a test will override sharing behavior.
334         (RunTest.test_run_part): Ditto.
335
336 2019-04-26  Alex Christensen  <achristensen@webkit.org>
337
338         Add ENABLE(CONTENT_EXTENSIONS) and namespace ContentExtensions to ResourceLoadInfo.h
339         https://bugs.webkit.org/show_bug.cgi?id=197165
340
341         Reviewed by Youenn Fablet.
342
343         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
344
345 2019-04-26  Ryan Haddad  <ryanhaddad@apple.com>
346
347         Replace iOS build queue hardware
348         https://bugs.webkit.org/show_bug.cgi?id=197312
349
350         Reviewed by Aakash Jain.
351
352         * BuildSlaveSupport/build.webkit.org-config/config.json:
353         Use newer hardware that supports macOS Mojave.
354
355 2019-04-26  Yoshiaki Jitsukawa  <yoshiaki.jitsukawa@sony.com>
356
357         check-webkit-style complains the first block in while loop.
358         https://bugs.webkit.org/show_bug.cgi?id=197307
359
360         The style checker shouldn't complain about an open brace on
361         its own line if the last non-whitespace character on the previous
362         non-blank line is another open brace, because it's likely to
363         indicate the begining of a nested code block.
364
365         Reviewed by Alex Christensen.
366
367         * Scripts/webkitpy/style/checkers/cpp.py:
368         (check_braces):
369         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
370         (WebKitStyleTest.test_braces):
371
372 2019-04-26  Sihui Liu  <sihui_liu@apple.com>
373
374         Stop IDB transactions to release locked database files when network process is ready to suspend
375         https://bugs.webkit.org/show_bug.cgi?id=196372
376         <rdar://problem/48930116>
377
378         Reviewed by Brady Eidson.
379
380         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
381         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.html: Added.
382         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBSuspendImminently.mm: Added.
383         (-[IndexedDBSuspendImminentlyMessageHandler userContentController:didReceiveScriptMessage:]):
384         (runTestAndCheckResult):
385         (keepNetworkProcessActive):
386         (TEST):
387
388 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
389
390         REGRESSION (r234330): 3 legacy-animation-engine/compositing tests are flaky failures
391         https://bugs.webkit.org/show_bug.cgi?id=188357
392         <rdar://problem/42986633>
393
394         Reviewed by Dean Jackson.
395
396         DumpRenderTree had no code that set page.setCompositingPolicyOverride() to Normal, so some
397         tests would fall into low memory mode and have different behavior.
398         
399         Fix by moving the code that calls setCompositingPolicyOverride(Normal) from the WK2 layer
400         to Internals, so it's shared by DRT and WTR.
401         
402         We no longer need the WK2 C SPI glue.
403
404         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
405         (WTR::InjectedBundlePage::prepare):
406
407 2019-04-25  Jonathan Bedard  <jbedard@apple.com>
408
409         webkitpy: Including skipped tests in the final count
410         https://bugs.webkit.org/show_bug.cgi?id=197298
411         <rdar://problem/49705424>
412
413         Reviewed by Lucas Forschler.
414
415         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
416         (BuildBotPrinter.print_run_results): The total number of tests run should exclude delibrately skipped tests.
417
418 2019-04-25  Timothy Hatcher  <timothy@apple.com>
419
420         Disable date and time inputs on iOSMac.
421         https://bugs.webkit.org/show_bug.cgi?id=197287
422         rdar://problem/46794376
423
424         Reviewed by Wenson Hsieh.
425
426         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
427
428 2019-04-25  Alex Christensen  <achristensen@webkit.org>
429
430         Fix test-webkitpy after r244653
431         https://bugs.webkit.org/show_bug.cgi?id=197131
432
433         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
434         Also use C++17.
435
436 2019-04-25  Per Arne Vollan  <pvollan@apple.com>
437
438         -[WKWebsiteDataStore fetchDataRecordsOfTypes:completionHandler:] never returns _WKWebsiteDataTypeCredentials
439         https://bugs.webkit.org/show_bug.cgi?id=196991
440         <rdar://problem/45507423>
441
442         Reviewed by Alex Christensen.
443
444         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
445         (-[NavigationTestDelegate init]):
446         (-[NavigationTestDelegate waitForDidFinishNavigation]):
447         (-[NavigationTestDelegate webView:didFinishNavigation:]):
448         (-[NavigationTestDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
449         (TestWebKitAPI::TEST):
450         (TEST): Deleted.
451
452 2019-04-25  Alex Christensen  <achristensen@webkit.org>
453
454         Revert some code accidentally committed with r244653
455         https://bugs.webkit.org/show_bug.cgi?id=197131
456
457         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
458         (TestWebKitAPI::TEST):
459
460 2019-04-25  Alex Christensen  <achristensen@webkit.org>
461
462         Start using C++17
463         https://bugs.webkit.org/show_bug.cgi?id=197131
464
465         Reviewed by Darin Adler.
466
467         * DumpRenderTree/mac/Configurations/Base.xcconfig:
468         * MiniBrowser/Configurations/Base.xcconfig:
469         * MobileMiniBrowser/Configurations/Base.xcconfig:
470         * TestWebKitAPI/Configurations/Base.xcconfig:
471         * WebKitTestRunner/Configurations/Base.xcconfig:
472
473 2019-04-25  Commit Queue  <commit-queue@webkit.org>
474
475         Unreviewed, rolling out r244627.
476         https://bugs.webkit.org/show_bug.cgi?id=197282
477
478         Causing internal build failures (Requested by ShawnRoberts on
479         #webkit).
480
481         Reverted changeset:
482
483         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
484         https://bugs.webkit.org/show_bug.cgi?id=197171
485         https://trac.webkit.org/changeset/244627
486
487 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
488
489         [GTK] Hardcoded text color in input fields
490         https://bugs.webkit.org/show_bug.cgi?id=126907
491
492         Reviewed by Michael Catanzaro.
493
494         Add dark-mode command line option to MiniBrowser.
495
496         * MiniBrowser/gtk/main.c:
497         (main):
498
499 2019-04-24  Zalan Bujtas  <zalan@apple.com>
500
501         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
502         https://bugs.webkit.org/show_bug.cgi?id=196948
503         <rdar://problem/49927131>
504
505         Reviewed by Tim Horton.
506
507         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
508         (TEST):
509         The expected order of incoming events is
510         1. didInvalidateIntrinsicContentSize
511         2. didFirstLayout
512         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
513         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
514         (and remember, all we care about is ordering).
515
516 2019-04-24  Eric Carlson  <eric.carlson@apple.com>
517
518         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
519         https://bugs.webkit.org/show_bug.cgi?id=197171
520         <rdar://problem/47454979>
521
522         Reviewed by Youenn Fablet.
523
524         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
525         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
526         (TestWebKitAPI::TEST):
527
528 2019-04-24  Brady Eidson  <beidson@apple.com>
529
530         XMLHTTPRequest POSTs to a custom WKURLSchemeHandler protocol are missing the HTTP body.
531         https://bugs.webkit.org/show_bug.cgi?id=191362
532
533         Reviewed by Alex Christensen.
534
535         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm: Add a test that POSTs all sorts of things
536           from an XHR to a custom protocol.
537
538 2019-04-25  Simon Fraser  <simon.fraser@apple.com>
539
540         DumpRenderTree doesn't call Internals::resetToConsistentState() before the first test
541         https://bugs.webkit.org/show_bug.cgi?id=197273
542
543         Reviewed by Dean Jackson.
544
545         Reorder code so that we create gTestRunner before calling resetWebViewToConsistentStateBeforeTesting(),
546         so that WebCoreTestSupport::resetInternalsObject() is always run.
547
548         * DumpRenderTree/mac/DumpRenderTree.mm:
549         (resetWebViewToConsistentStateBeforeTesting):
550         (runTest):
551
552 2019-04-24  John Wilander  <wilander@apple.com>
553
554         Age out unconverted Ad Click Attributions after one week.
555         https://bugs.webkit.org/show_bug.cgi?id=197238
556         <rdar://problem/50177349>
557
558         Reviewed by Chris Dumez.
559
560         This patch adds infrastructure to allow tests to expire all unconverted
561         attributions early.
562
563         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
564         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
565         (WTR::TestRunner::markAdClickAttributionsAsExpiredForTesting):
566         * WebKitTestRunner/InjectedBundle/TestRunner.h:
567         * WebKitTestRunner/TestController.cpp:
568         (WTR::TestController::markAdClickAttributionsAsExpiredForTesting):
569         * WebKitTestRunner/TestController.h:
570         * WebKitTestRunner/TestInvocation.cpp:
571         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
572
573 2019-04-24  Chris Dumez  <cdumez@apple.com>
574
575         Fix flaky crashes in a couple of PSON API tests
576         https://bugs.webkit.org/show_bug.cgi?id=197239
577
578         Reviewed by Tim Horton.
579
580         Do not adopt the NSURLRequest returned by [NSURLRequest requestWithURL:].
581
582         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
583
584 2019-04-24  Simon Fraser  <simon.fraser@apple.com>
585
586         Make it possible to control the renderTreeAsText output by setting options on testRunner
587         https://bugs.webkit.org/show_bug.cgi?id=197133
588
589         Reviewed by Sam Weinig.
590
591         Add testRunner.setRenderTreeDumpOptions() and expose the subset of RenderAsTextFlag flags
592         that make sense in testing (those that don't dump unstable data like addresses), and plumb
593         these flags through the various framework layers.
594
595         Convert RenderAsTextBehavior to an OptionSet<RenderAsTextFlag>.
596
597         Fix code generation in WebKitTestRunner to generate bindings for IDL const values,
598         and hand-code DumpRenderTree bindings.
599
600         Some cleanup of the TestRunners, using member initializers.
601
602         * DumpRenderTree/TestRunner.cpp:
603         (TestRunner::TestRunner):
604         (setRenderTreeDumpOptionsCallback):
605         (TestRunner::staticFunctions):
606         (TestRunner::setRenderTreeDumpOptions):
607         * DumpRenderTree/TestRunner.h:
608         (TestRunner::renderTreeDumpOptions const):
609         * DumpRenderTree/mac/DumpRenderTree.mm:
610         (dump):
611         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
612         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
613         (WTR::InjectedBundlePage::dump):
614         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
615         (WTR::TestRunner::TestRunner):
616         (WTR::TestRunner::setRenderTreeDumpOptions):
617         * WebKitTestRunner/InjectedBundle/TestRunner.h:
618         (WTR::TestRunner::renderTreeDumpOptions const):
619
620 2019-04-24  Alex Christensen  <achristensen@webkit.org>
621
622         WKContentRuleLists should have a maximum FileProtection of CompleteUnlessOpen
623         https://bugs.webkit.org/show_bug.cgi?id=197078
624         <rdar://problem/49564348>
625
626         Reviewed by Geoff Garen.
627
628         * TestWebKitAPI/Tests/WebKitCocoa/WKContentExtensionStore.mm:
629         (TEST_F):
630         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:startURLSchemeTask:]): Deleted.
631         (-[TestSchemeHandlerSubresourceShouldBeBlocked webView:stopURLSchemeTask:]): Deleted.
632         Unfortunately, setting the NSFileProtectionKey attribute is only supported on iOS devices.
633
634 2019-04-24  Alex Christensen  <achristensen@webkit.org>
635
636         Add unit test for r239322
637         https://bugs.webkit.org/show_bug.cgi?id=197236
638
639         Reviewed by Chris Dumez.
640
641         I initially developed this as a unit test for rdar://problem/48797895 but it seems that isn't quite ready.
642         May as well add the test infrastructure which was needed before and will be needed in the future.
643
644         * TestWebKitAPI/TCPServer.cpp:
645         (TestWebKitAPI::TCPServer::TCPServer):
646         * TestWebKitAPI/TCPServer.h:
647         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
648         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
649         (TestWebKitAPI::TEST):
650         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
651         (TestWebKitAPI::downloadAtRate):
652         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
653         (TEST):
654         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm: Added.
655         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
656         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
657         (TestWebKitAPI::TEST):
658         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
659         (TEST):
660
661 2019-04-24  Chris Dumez  <cdumez@apple.com>
662
663         URL set by document.open() is communicated with the WebPageProxy but not the WebFrameProxy
664         https://bugs.webkit.org/show_bug.cgi?id=197214
665         <rdar://problem/49237544>
666
667         Reviewed by Alex Christensen.
668
669         Extend API test coverage.
670
671         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
672         (TEST):
673
674 2019-04-24  Philippe Normand  <pnormand@igalia.com>
675
676         [Build][GStreamer] Update to 1.16.0
677         https://bugs.webkit.org/show_bug.cgi?id=197157
678
679         Reviewed by Xabier Rodriguez-Calvar.
680
681         The upstreamed patches were removed and a new one was added for a
682         regression detected in the scaletempo GStreamer element. The GNOME
683         Flatpak was migrated to 3.32 and I switched a few modules to Meson
684         on the way, as it is the preferred build system now in GStreamer
685         1.16.
686
687         * flatpak/files/httpd-autogen.sh:
688         * flatpak/flatpakutils.py:
689         (FlatpakPackage.install):
690         (WebkitFlatpak.run_in_sandbox):
691         * flatpak/org.webkit.CommonModules.yaml:
692         * flatpak/org.webkit.WebKit.yaml:
693         * gstreamer/jhbuild.modules:
694         * gstreamer/patches/gst-plugins-bad-0001-aomenc-Add-support-for-10-12bit-decoding.patch: Removed.
695         * gstreamer/patches/gst-plugins-bad-0002-aomenc-Handle-8-bit_depth-images-with-AOM_IMG_FMT_HI.patch: Removed.
696         * gstreamer/patches/gst-plugins-bad-0003-fdkaacenc-Remove-MODE_2_1.patch: Removed.
697         * gstreamer/patches/gst-plugins-bad-0004-fdkaacdec-Use-WAV-channel-mapping-instead-of-interleave-setting.patch: Removed.
698         * gstreamer/patches/gst-plugins-bad-0005-mssdemux-fix-protection-data-double-free.patch: Removed.
699         * gstreamer/patches/gst-plugins-base-0001-parsebin-Post-STREAM_COLLECTION-on-EVENT_STREAM_COLL.patch: Removed.
700         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Detect-and-expose-CEA-608-708-Closed-Caption.patch: Removed.
701         * gstreamer/patches/gst-plugins-good-0001-qtdemux-Do-not-run-the-preferred-decryptor-context-q.patch: Removed.
702         * gstreamer/patches/gst-plugins-good-0002-qtdemux-Do-not-unref-a-NULL-stream_tags.patch: Removed.
703         * gstreamer/patches/gst-plugins-good-0002-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
704         * gstreamer/patches/gst-plugins-good-0003-qtdemux-Clarify-field-name-about-stream-encryption-s.patch: Removed.
705         * gstreamer/patches/gst-plugins-good-0003-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
706         * gstreamer/patches/gst-plugins-good-0004-qtdemux-Add-initial-support-for-AV1-demuxing.patch: Removed.
707         * gstreamer/patches/gst-plugins-good-0005-qtdemux-Extract-AV1-codec_data-and-put-it-in-the-cap.patch: Removed.
708         * gstreamer/patches/gst-plugins-good-0006-qtdemux-Recognize-more-AV1-atoms.patch: Removed.
709         * gstreamer/patches/gst-plugins-good-0011-matroska-Add-the-WebM-encrypted-content-support-in-m.patch: Removed.
710         * gstreamer/patches/gst-plugins-good-0012-matroskdemux-do-not-use-MapInfo.data-after-unmapping.patch: Removed.
711         * gstreamer/patches/gst-plugins-good-0013-Avoid-warning-when-reporting-about-decryptors.patch: Removed.
712         * gstreamer/patches/gst-plugins-good-0014-pulse-Mark-default-devices-as-default.patch: Removed.
713         * gstreamer/patches/gst-plugins-good-scaletempo-Advertise-interleaved-layout-in-caps-temp.patch: Added.
714         * gstreamer/patches/gstreamer-0001-protection-Add-a-new-definition-for-unspecified-syst.patch: Removed.
715         * gstreamer/patches/gstreamer-0002-protection-Fix-the-string-to-define-unspecified-syst.patch: Removed.
716
717 2019-04-24  Carlos Garcia Campos  <cgarcia@igalia.com>
718
719         [GTK] MiniBrowser: also set the passed bg-color when receiving arguments
720         https://bugs.webkit.org/show_bug.cgi?id=197156
721
722         Reviewed by Michael Catanzaro.
723
724         The background color is only set when MiniBrowser is launched without arguments. This regressed when tabs
725         support was added.
726
727         * MiniBrowser/gtk/BrowserTab.c:
728         (browser_tab_set_background_color): Set the passed in color as web view background color.
729         * MiniBrowser/gtk/BrowserTab.h:
730         * MiniBrowser/gtk/BrowserWindow.c:
731         (browser_window_init): Initialize backgroundColor.
732         (browser_window_append_view): Call browser_tab_set_background_color().
733         (browser_window_set_background_color): Save the passed in color. This function should now be called before tabs
734         are added.
735         * MiniBrowser/gtk/main.c:
736         (main): Call browser_window_set_background_color() before creating the tabs.
737
738 2019-04-23  John Wilander  <wilander@apple.com>
739
740         Move Ad Click Attribution from internal feature to experimental feature
741         https://bugs.webkit.org/show_bug.cgi?id=197218
742         <rdar://problem/47651691>
743
744         Reviewed by Brent Fulgham.
745
746         * DumpRenderTree/TestOptions.cpp:
747         (TestOptions::TestOptions):
748
749 2019-04-23  Andy Estes  <aestes@apple.com>
750
751         [iOS] QuickLook documents loaded from file: URLs should be allowed to perform same-document navigations
752         https://bugs.webkit.org/show_bug.cgi?id=196749
753         <rdar://problem/35773454>
754
755         Reviewed by Daniel Bates.
756
757         Added a new QuickLook API test and added new expectations to existing QuickLook tests.
758
759         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
760         (-[QuickLookDelegate webView:didStartProvisionalNavigation:]):
761         (-[QuickLookDelegate webView:didFinishNavigation:]):
762         (-[QuickLookDelegate _webView:didFailNavigation:withError:userInfo:]):
763         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
764         (runTest):
765         (runTestDecideBeforeLoading):
766         (runTestDecideAfterLoading):
767         (TEST):
768
769 2019-04-23  John Wilander  <wilander@apple.com>
770
771         Remove Ad Click Attribution data when removing website data
772         https://bugs.webkit.org/show_bug.cgi?id=197215
773         <rdar://problem/47668988>
774
775         Reviewed by Chris Dumez.
776
777         This patch adds test infrastructure to delete Ad Click Attribution data
778         through WebsiteDataStore::removeData().
779
780         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
781         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
782         (WTR::TestRunner::clearAdClickAttribution):
783         (WTR::TestRunner::clearAdClickAttributionsThroughWebsiteDataRemoval):
784         * WebKitTestRunner/InjectedBundle/TestRunner.h:
785         * WebKitTestRunner/TestController.cpp:
786         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
787         * WebKitTestRunner/TestController.h:
788         * WebKitTestRunner/TestInvocation.cpp:
789         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
790
791 2019-04-23  Jonathan Bedard  <jbedard@apple.com>
792
793         webkitpy: Kill unresponsive worker processes
794         https://bugs.webkit.org/show_bug.cgi?id=197205
795         <rdar://problem/50104388>
796
797         Reviewed by Lucas Forschler.
798
799         * Scripts/webkitpy/common/message_pool.py:
800         (_MessagePool.__init__): Add close timeout.
801         (_MessagePool._close): Send termination before joining workers, kill unresponsive workers.
802
803 2019-04-23  Alex Christensen  <achristensen@webkit.org>
804
805         Add unit tests for WKWebView.serverTrust
806         https://bugs.webkit.org/show_bug.cgi?id=197202
807
808         Reviewed by Youenn Fablet
809
810         * TestWebKitAPI/TCPServer.cpp:
811         (TestWebKitAPI::deleter<BIO>::operator()):
812         (TestWebKitAPI::deleter<SSL>::operator()):
813         (TestWebKitAPI::deleter<X509>::operator()):
814         (TestWebKitAPI::deleter<SSL_CTX>::operator()):
815         (TestWebKitAPI::deleter<EVP_PKEY>::operator()):
816         (TestWebKitAPI::TCPServer::TCPServer):
817         (TestWebKitAPI::TCPServer::listenForConnections):
818         * TestWebKitAPI/TCPServer.h:
819         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
820         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
821         (TestWebKitAPI::TEST):
822         (verifyCertificateAndPublicKey):
823         (-[ServerTrustDelegate webView:didFinishNavigation:]):
824         (-[ServerTrustDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
825         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
826         (TestWebKitAPI::downloadAtRate):
827         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
828         (TEST):
829         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
830         (TEST):
831
832 2019-04-23  Commit Queue  <commit-queue@webkit.org>
833
834         Unreviewed, rolling out r244556.
835         https://bugs.webkit.org/show_bug.cgi?id=197212
836
837         Causing build failures on multiple builders (Requested by
838         ShawnRoberts on #webkit).
839
840         Reverted changeset:
841
842         "Create AVFoundationSoftLink.{h,mm} to reduce duplicate code"
843         https://bugs.webkit.org/show_bug.cgi?id=197171
844         https://trac.webkit.org/changeset/244556
845
846 2019-04-23  Alex Christensen  <achristensen@webkit.org>
847
848         Fix iOS build.
849         https://bugs.webkit.org/show_bug.cgi?id=195537
850
851         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
852         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
853         AdoptWK constructor is private now.  Use adoptWK instead.
854
855 2019-04-23  Andres Gonzalez  <andresg_22@apple.com>
856
857         Accessibility text search and selection API enhancements.
858         https://bugs.webkit.org/show_bug.cgi?id=197095
859         <rdar://problem/48181791>
860
861         Reviewed by Chris Fleizach.
862
863         Added new API JS binding code for searchTextWithCriteria to both WTR and DRT.
864
865         * DumpRenderTree/AccessibilityTextMarker.h:
866         * DumpRenderTree/AccessibilityUIElement.cpp:
867         (searchTextWithCriteriaCallback):
868         (AccessibilityUIElement::getJSClass):
869         * DumpRenderTree/AccessibilityUIElement.h:
870         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
871         (convertVectorToObjectArray):
872         (convertNSArrayToVector):
873         (searchTextParameterizedAttributeForCriteria):
874         (AccessibilityUIElement::getLinkedUIElements):
875         (AccessibilityUIElement::getDocumentLinks):
876         (AccessibilityUIElement::getChildren):
877         (AccessibilityUIElement::getChildrenWithRange):
878         (AccessibilityUIElement::rowHeaders const):
879         (AccessibilityUIElement::columnHeaders const):
880         (AccessibilityUIElement::uiElementArrayAttributeValue const):
881         (AccessibilityUIElement::searchTextWithCriteria):
882         (AccessibilityUIElement::attributesOfColumnHeaders):
883         (AccessibilityUIElement::attributesOfRowHeaders):
884         (AccessibilityUIElement::attributesOfColumns):
885         (AccessibilityUIElement::attributesOfRows):
886         (AccessibilityUIElement::attributesOfVisibleCells):
887         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
888         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
889         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
890         (WTR::convertVectorToObjectArray):
891         (WTR::convertNSArrayToVector):
892         (WTR::searchTextParameterizedAttributeForCriteria):
893         (WTR::AccessibilityUIElement::getLinkedUIElements):
894         (WTR::AccessibilityUIElement::getDocumentLinks):
895         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
896         (WTR::AccessibilityUIElement::getChildren):
897         (WTR::AccessibilityUIElement::getChildrenWithRange):
898         (WTR::AccessibilityUIElement::rowHeaders const):
899         (WTR::AccessibilityUIElement::columnHeaders const):
900         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
901         (WTR::AccessibilityUIElement::searchTextWithCriteria):
902         (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
903         (WTR::AccessibilityUIElement::attributesOfRowHeaders):
904         (WTR::AccessibilityUIElement::attributesOfColumns):
905         (WTR::AccessibilityUIElement::attributesOfRows):
906         (WTR::AccessibilityUIElement::attributesOfVisibleCells):
907         (WTR::convertElementsToObjectArray): Deleted.
908
909 2019-04-23  Guy Lewin  <guy@lewin.co.il>
910
911         Multiple File Input Icon Set Regardless of File List
912         https://bugs.webkit.org/show_bug.cgi?id=195537
913
914         Reviewed by Alexey Proskuryakov.
915
916         Add setOpenPanelFilesMediaIcon to TestRunner in order to test icon and
917         display string in iOS file inputs
918
919         * DumpRenderTree/TestRunner.cpp:
920         (SetOpenPanelFilesMediaIconCallback):
921         (TestRunner::staticFunctions):
922         (TestRunner::setOpenPanelFilesMediaIcon):
923         * DumpRenderTree/TestRunner.h:
924         (TestRunner::openPanelFilesMediaIcon const):
925         * DumpRenderTree/mac/UIDelegate.mm:
926         (-[UIDelegate webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
927         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
928         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
929         (WTR::TestRunner::setOpenPanelFilesMediaIcon):
930         * WebKitTestRunner/InjectedBundle/TestRunner.h:
931         * WebKitTestRunner/TestController.cpp:
932         (WTR::runOpenPanel):
933         (WTR::TestController::resetStateToConsistentValues):
934         * WebKitTestRunner/TestController.h:
935         (WTR::TestController::openPanelFileURLsMediaIcon const):
936         (WTR::TestController::setOpenPanelFileURLsMediaIcon):
937         * WebKitTestRunner/TestInvocation.cpp:
938         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
939
940 2019-04-23  Eric Carlson  <eric.carlson@apple.com>
941
942         Create AVFoundationSoftLink.{h,mm} to reduce duplicate code
943         https://bugs.webkit.org/show_bug.cgi?id=197171
944         <rdar://problem/47454979>
945
946         Reviewed by Youenn Fablet.
947
948         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
949         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm: Added.
950         (TestWebKitAPI::TEST):
951
952 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
953
954         [ews-build] Add unit tests for UnApplyPatchIfRequired
955         https://bugs.webkit.org/show_bug.cgi?id=197197
956
957         Reviewed by Lucas Forschler.
958
959         * BuildSlaveSupport/ews-build/steps_unittest.py:
960         (TestUnApplyPatchIfRequired):
961         (TestUnApplyPatchIfRequired.test_success):
962         (TestUnApplyPatchIfRequired.test_failure):
963         (TestUnApplyPatchIfRequired.test_skip):
964
965 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
966
967         [ews-build] Add unit tests for CleanWorkingDirectory
968         https://bugs.webkit.org/show_bug.cgi?id=197195
969
970         Reviewed by Lucas Forschler.
971
972         * BuildSlaveSupport/ews-build/steps_unittest.py:
973         (TestCleanWorkingDirectory):
974         (TestCleanWorkingDirectory.test_success):
975         (TestCleanWorkingDirectory.test_failure):
976
977 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
978
979         [ews-build] Use explicit imports instead of wildcard imports
980         https://bugs.webkit.org/show_bug.cgi?id=197194
981
982         Reviewed by Lucas Forschler.
983
984         * BuildSlaveSupport/ews-build/factories.py:
985         * BuildSlaveSupport/ews-build/loadConfig.py:
986         * BuildSlaveSupport/ews-build/steps_unittest.py:
987
988 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
989
990         [ews-build] Add unit tests for DownloadBuiltProduct
991         https://bugs.webkit.org/show_bug.cgi?id=197193
992
993         Reviewed by Lucas Forschler.
994
995         * BuildSlaveSupport/ews-build/steps_unittest.py:
996         (TestDownloadBuiltProduct):
997         (TestDownloadBuiltProduct.setUp):
998         (TestDownloadBuiltProduct.tearDown):
999         (TestDownloadBuiltProduct.test_success):
1000         (TestDownloadBuiltProduct.test_failure):
1001
1002 2019-04-23  Aakash Jain  <aakash_jain@apple.com>
1003
1004         [ews-app] Exception while loading status-bubble when no build step has started
1005         https://bugs.webkit.org/show_bug.cgi?id=196676
1006
1007         Reviewed by Lucas Forschler.
1008
1009         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1010         (StatusBubble.get_build_timestamp): Check if build step is present before accessing its timestamp.
1011
1012 2019-04-23  Stephan Szabo  <stephan.szabo@sony.com>
1013
1014         [PlayStation] Support running of JSC tests on remote playstation devices
1015         https://bugs.webkit.org/show_bug.cgi?id=197170
1016
1017         Reviewed by Ross Kirsling.
1018
1019         Script changes
1020
1021         * Scripts/run-javascriptcore-tests:
1022         (runJSCStressTests): Pass arguments for playstation to
1023         run-jsc-stress-tests
1024         * Scripts/run-jsc-stress-tests:
1025         Handle $hostOS=="playstation" for determineArchitecture, turning
1026         off $isFTLPlatform and runProfiler and defaulting test writer.
1027         * Scripts/webkitdirs.pm:
1028         (jscPath): PlayStation WebKit executables have .elf extension
1029         (executableProductDir): PlayStation builds on Windows hosts but
1030         uses bin directory rather than bin64/bin32 for executable output
1031         location.
1032         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb: Added.
1033
1034 2019-04-23  Don Olmstead  <don.olmstead@sony.com>
1035
1036         [CMake][Win] Use target oriented design for WebKit
1037         https://bugs.webkit.org/show_bug.cgi?id=197173
1038
1039         Reviewed by Alex Christensen.
1040
1041         * TestWebKitAPI/PlatformWin.cmake: Add WebKitFrameworkHeaders as a dependency.
1042         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp: Remove unused header.
1043
1044 2019-04-23  Chris Dumez  <cdumez@apple.com>
1045
1046         [Process-Swap-On-Navigation] WebKit hangs when going back to a form submission's page due to Process-Swap-On-Navigation on iOS 12.2 and higher
1047         https://bugs.webkit.org/show_bug.cgi?id=197097
1048         <rdar://problem/50048318>
1049
1050         Reviewed by Alex Christensen.
1051
1052         Add API test coverage.
1053
1054         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1055         (-[PSONScheme webView:startURLSchemeTask:]):
1056
1057 2019-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1058
1059         [ATK] Implement AtkComponentIface scroll_to methods
1060         https://bugs.webkit.org/show_bug.cgi?id=196856
1061
1062         Reviewed by Michael Catanzaro.
1063
1064         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1065         (WTR::AccessibilityUIElement::scrollToMakeVisible): Call atk_component_scroll_to().
1066         (WTR::AccessibilityUIElement::scrollToGlobalPoint): Call atk_component_scroll_to_point().
1067         * gtk/jhbuild.modules: Bump atk, at-spi2-core and at-spi2-atk to their latest stable version.
1068
1069 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1070
1071         [ews-build] Improve summary for UploadBuiltProduct step
1072         https://bugs.webkit.org/show_bug.cgi?id=197182
1073
1074         Reviewed by Lucas Forschler.
1075
1076         * BuildSlaveSupport/ews-build/steps.py:
1077         (UploadBuiltProduct): Added descriptionDone.
1078         (UploadBuiltProduct.getResultSummary): Overrided getResultSummary.
1079         * BuildSlaveSupport/ews-build/steps_unittest.py:
1080         (TestUploadBuiltProduct.test_success): Updated unit-test.
1081         (TestUploadBuiltProduct.test_failure): Added unit-test for failure case.
1082
1083 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1084
1085         [ews-build] Trigger queues only after uploading the archive
1086         https://bugs.webkit.org/show_bug.cgi?id=197180
1087
1088         Reviewed by Lucas Forschler.
1089
1090         * BuildSlaveSupport/ews-build/factories.py:
1091         (Factory.__init__):
1092         (BuildFactory.__init__): Remove trigger step from factories.
1093         (BuildFactory.propertiesToPassToTriggers): Deleted.
1094         * BuildSlaveSupport/ews-build/steps.py:
1095         (ConfigureBuild.__init__): Confiure triggers property.
1096         (Trigger): Step to trigger other queues.
1097         (Trigger.propertiesToPassToTriggers): Method to construct properties to pass to triggerred builds.
1098         (UploadBuiltProduct.finished): Trigger builds after upload is successful.
1099
1100 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1101
1102         Deprecate WKContextCreateWithInjectedBundlePath
1103         https://bugs.webkit.org/show_bug.cgi?id=197169
1104
1105         Reviewed by Youenn Fablet.
1106
1107         * TestWebKitAPI/PlatformUtilities.cpp:
1108         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1109         Use WKContextCreateWithConfiguration instead of WKContextCreateWithInjectedBundlePath after having set its injected bundle path.
1110
1111 2019-04-22  Alex Christensen  <achristensen@webkit.org>
1112
1113         REGRESSION(r230681) Do not use stored credentials if WKBundlePageResourceLoadClient.shouldUseCredentialStorage returns false
1114         https://bugs.webkit.org/show_bug.cgi?id=197093
1115         <rdar://problem/49708268>
1116
1117         Reviewed by Chris Dumez.
1118
1119         Add a test that does two loads.  The first load shouldUseCredentialStorage returns true and we provide a persistent credential.
1120         The second load shouldUseCredentialStorage returns false and we verify that a challenge is received with no suggested credential.
1121         We also need to make the TCPServer able to handle more than one connection because we need these two loads to come from the same protection space,
1122         and our current Cocoa implementation of NetworkSession uses two NSURLSessions that don't share a connection cache, one for loads with credentials
1123         and one for loads without credentials, so there are two TCP connections to the same server in this test.
1124
1125         * TestWebKitAPI/TCPServer.cpp:
1126         (TestWebKitAPI::TCPServer::TCPServer):
1127         (TestWebKitAPI::TCPServer::~TCPServer):
1128         (TestWebKitAPI::TCPServer::socketBindListen):
1129         (TestWebKitAPI::TCPServer::waitForAndReplyToRequests): Deleted.
1130         * TestWebKitAPI/TCPServer.h:
1131         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1132         * TestWebKitAPI/Tests/WebKitCocoa/BasicProposedCredentialPlugIn.mm: Added.
1133         (-[BasicProposedCredentialPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1134         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1135         (respondWithChallengeThenOK):
1136         (TestWebKitAPI::TEST):
1137         (-[ProposedCredentialDelegate webView:didFinishNavigation:]):
1138         (-[ProposedCredentialDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1139         (TEST):
1140
1141 2019-04-22  Chris Dumez  <cdumez@apple.com>
1142
1143         Delayed WebProcessLaunch may break the _relatedWebView SPI
1144         https://bugs.webkit.org/show_bug.cgi?id=197160
1145
1146         Reviewed by Alex Christensen.
1147
1148         Add API test coverage.
1149
1150         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1151
1152 2019-04-22  Dean Johnson  <dean_johnson@apple.com>
1153
1154         Use curl to download packages for webkitpy autoinstaller
1155         https://bugs.webkit.org/show_bug.cgi?id=197164
1156
1157         Reviewed by Darin Adler.
1158
1159         * Scripts/webkitpy/common/system/autoinstall.py:
1160         (AutoInstaller._download): Use curl(1) to download packages necessary for
1161         webkitpy/thirdparty/autoinstalled since Python2's urllib2 module can result in unnecessary
1162         errors which are not present when using curl(1).
1163
1164 2019-04-22  Chris Dumez  <cdumez@apple.com>
1165
1166         Unreviewed, rolling out r244502.
1167
1168         Caused crashes on the bots
1169
1170         Reverted changeset:
1171
1172         "Delayed WebProcessLaunch may break the _relatedWebView SPI"
1173         https://bugs.webkit.org/show_bug.cgi?id=197160
1174         https://trac.webkit.org/changeset/244502
1175
1176 2019-04-22  Ryan Haddad  <ryanhaddad@apple.com>
1177
1178         Unreviewed, rolling out r244437.
1179
1180         Still breaks internal tests.
1181
1182         Reverted changeset:
1183
1184         "InjectedBundle parameters often need initialization function
1185         called before unarchiving"
1186         https://bugs.webkit.org/show_bug.cgi?id=189709
1187         https://trac.webkit.org/changeset/244437
1188
1189 2019-04-22  Aakash Jain  <aakash_jain@apple.com>
1190
1191         [ews-build] Use singular verb in failure description in case of single api test failure
1192         https://bugs.webkit.org/show_bug.cgi?id=197013
1193
1194         Reviewed by Lucas Forschler.
1195
1196         * BuildSlaveSupport/ews-build/steps.py:
1197         (AnalyzeAPITestsResults.analyzeResults):
1198
1199 2019-04-22  Chris Dumez  <cdumez@apple.com>
1200
1201         Delayed WebProcessLaunch may break the _relatedWebView SPI
1202         https://bugs.webkit.org/show_bug.cgi?id=197160
1203
1204         Reviewed by Alex Christensen.
1205
1206         Add API test coverage.
1207
1208         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1209
1210 2019-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
1211
1212         REGRESSION(r241289): [GTK] accessibility/removed-continuation-element-causes-crash.html and accessibility/removed-anonymous-block-child-causes-crash.html crashes
1213         https://bugs.webkit.org/show_bug.cgi?id=194630
1214
1215         Reviewed by Michael Catanzaro.
1216
1217         Return early from getAttributeSet() is passed in accessible is nullptr.
1218
1219         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1220
1221 2019-04-21  Wenson Hsieh  <wenson_hsieh@apple.com>
1222
1223         Defer EditorState updates until the next layer tree flush in a few additional circumstances
1224         https://bugs.webkit.org/show_bug.cgi?id=197145
1225         <rdar://problem/50078170>
1226
1227         Reviewed by Darin Adler.
1228
1229         Adjusts several editing API tests to wait for a presentation update following a selection change, programmatic
1230         focus, or showing the font manager.
1231
1232         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
1233         (TestWebKitAPI::TEST):
1234         * TestWebKitAPI/Tests/WebKitCocoa/WKContentViewTargetForAction.mm:
1235         (TEST):
1236         * TestWebKitAPI/Tests/mac/FontManagerTests.mm:
1237         (TestWebKitAPI::TEST):
1238
1239 2019-04-21  Brian Burg  <bburg@apple.com>
1240
1241         WebDriver: add hooks to make it possible to easily run WPT WebDriver web server by itself
1242         https://bugs.webkit.org/show_bug.cgi?id=197125
1243         <rdar://problem/50061468>
1244
1245         Reviewed by Darin Adler.
1246
1247         Sometimes I want to run wptserve independently of tests. Make it easier to script that
1248         using this class rather than making our own ./wpt serve invocation.
1249
1250         * Scripts/webkitpy/webdriver_tests/webdriver_w3c_web_server.py:
1251         (WebDriverW3CWebServer):
1252         (WebDriverW3CWebServer.document_root): Expose this to clients.
1253         (WebDriverW3CWebServer.wait): Add a method that blocks until the server dies.
1254
1255         (WebDriverW3CWebServer.__enter__):
1256         (WebDriverW3CWebServer.__exit__):
1257         Make it possible to use the web server with a 'with' statement.
1258
1259 2019-04-20  Don Olmstead  <don.olmstead@sony.com>
1260
1261         [CMake][Win] Use target oriented design for WebKitLegacy
1262         https://bugs.webkit.org/show_bug.cgi?id=197112
1263
1264         Reviewed by Konstantin Tokarev.
1265
1266         Fix includes and libraries for DumpRenderTree after changes to WebKitLegacy targets.
1267
1268         * DumpRenderTree/CMakeLists.txt:
1269         * DumpRenderTree/PlatformWin.cmake:
1270         * DumpRenderTree/win/EventSender.cpp:
1271
1272 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1273
1274         Update text for old EWS submit button
1275         https://bugs.webkit.org/show_bug.cgi?id=197140
1276
1277         Reviewed by Alexey Proskuryakov.
1278
1279         * QueueStatusServer/templates/statusbubble.html:
1280
1281 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1282
1283         [ews-app] New EWS should poll bugzilla more frequently
1284         https://bugs.webkit.org/show_bug.cgi?id=197138
1285
1286         Reviewed by Alexey Proskuryakov.
1287
1288         * BuildSlaveSupport/ews-app/ews/fetcher.py:
1289         (FetchLoop.__init__):
1290
1291 2019-04-20  Aakash Jain  <aakash_jain@apple.com>
1292
1293         [ews-app] Submit to EWS buttons are not aligned properly with status-bubbles
1294         https://bugs.webkit.org/show_bug.cgi?id=197139
1295
1296         Reviewed by Alexey Proskuryakov.
1297
1298         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
1299         * QueueStatusServer/templates/statusbubble.html:
1300
1301 2019-04-20  Chris Dumez  <cdumez@apple.com>
1302
1303         Unreviewed, fix iOS build with recent SDKs.
1304
1305         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1306
1307 2019-04-19  Keith Miller  <keith_miller@apple.com>
1308
1309         Add script to merge run_benchmark jsons
1310         https://bugs.webkit.org/show_bug.cgi?id=197107
1311
1312         Reviewed by Michael Saboff.
1313
1314         The script basically recursively decends through all json objects until it gets
1315         to an array or JSON primitive and concats or takes the first value, respectively.
1316
1317         This patch also adds +x bits to the compare-results script so it
1318         can be run directly from the command line. I had to add a new line so that svn
1319         will accept the change... yay svn!
1320
1321         * Scripts/compare-results:
1322         * Scripts/merge-result-jsons: Added.
1323         (readJSONFile):
1324         (deepAppend):
1325         (mergeJSONs):
1326         (main):
1327
1328 2019-04-18  Ryosuke Niwa  <rniwa@webkit.org>
1329
1330         Crash in FrameLoader::stopAllLoaders via [WebView dealloc] inside ~ObjCEventListener
1331         https://bugs.webkit.org/show_bug.cgi?id=197079
1332
1333         Reviewed by Darin Adler.
1334
1335         Added a regression test. It hits a slightly different backtrace but of the same class of issues.
1336
1337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1338         * TestWebKitAPI/Tests/WebKitLegacy/mac/DeallocWebViewInEventListener.mm: Added.
1339
1340 2019-04-18  Commit Queue  <commit-queue@webkit.org>
1341
1342         Unreviewed, rolling out r244434.
1343         https://bugs.webkit.org/show_bug.cgi?id=197089
1344
1345         caused 1 API test failure (Requested by zalan on #webkit).
1346
1347         Reverted changeset:
1348
1349         "Regression (r244291): Broken API Test
1350         AutoLayoutRenderingProgressRelativeOrdering"
1351         https://bugs.webkit.org/show_bug.cgi?id=196948
1352         https://trac.webkit.org/changeset/244434
1353
1354 2019-04-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1355
1356         Add new compatibility mode API on WKNavigation
1357         https://bugs.webkit.org/show_bug.cgi?id=197069
1358         <rdar://problem/50025800>
1359
1360         Reviewed by Tim Horton.
1361
1362         Add a block property for -didCommitNavigation to TestNavigationDelegate.
1363
1364         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1365         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1366         (-[TestNavigationDelegate webView:didCommitNavigation:]):
1367
1368 2019-04-18  Don Olmstead  <don.olmstead@sony.com>
1369
1370         [CMake] Make WebCore headers copies
1371         https://bugs.webkit.org/show_bug.cgi?id=182512
1372         <rdar://problem/37510435>
1373
1374         Reviewed by Alex Christensen.
1375
1376         Added WebCorePrivateFrameworkHeaders as a dependency of TestWebKitAPI for all
1377         ports.
1378
1379         WebCore now uses WebCore_PRIVATE_INCLUDE_DIRECTORIES for all ports. Any includes
1380         of WebCore headers using "*.h" were modified to <WebCore/*.h>
1381
1382         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
1383         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npapi.h:
1384         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npfunctions.h:
1385         * DumpRenderTree/TestNetscapePlugIn/ForwardingHeaders/WebKit/npruntime.h:
1386         * TestWebKitAPI/CMakeLists.txt:
1387         * TestWebKitAPI/PlatformWin.cmake:
1388         * TestWebKitAPI/Tests/WebCore/AbortableTaskQueue.cpp:
1389         * TestWebKitAPI/Tests/WebCore/gstreamer/GstMappedBuffer.cpp:
1390         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1391
1392 2019-04-18  Jer Noble  <jer.noble@apple.com>
1393
1394         Add support for parsing FairPlayStreaming PSSH boxes.
1395         https://bugs.webkit.org/show_bug.cgi?id=197064
1396
1397         Reviewed by Eric Carlson.
1398
1399         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
1400         (TestWebKitAPI::TEST):
1401
1402 2019-04-18  Brent Fulgham  <bfulgham@apple.com>
1403
1404         InjectedBundle parameters often need initialization function called before unarchiving
1405         https://bugs.webkit.org/show_bug.cgi?id=189709
1406         <rdar://problem/44573653>
1407
1408         Reviewed by Ryosuke Niwa.
1409
1410         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1411         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1412
1413 2019-04-18  Zalan Bujtas  <zalan@apple.com>
1414
1415         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
1416         https://bugs.webkit.org/show_bug.cgi?id=196948
1417         <rdar://problem/49927131>
1418
1419         Reviewed by Tim Horton.
1420
1421         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
1422         (TEST): 
1423         The expected order of incoming events is
1424         1. didInvalidateIntrinsicContentSize
1425         2. didFirstLayout
1426         At setRenderingProgressDidChange, we already check if didInvalidateIntrinsicContentSize comes in first.
1427         However it's not guaranteed that the milestone event is delayed until after TestWebKitAPI::Util::run() is finished
1428         (and remember, all we care about is ordering).
1429
1430 2019-04-18  Ryan Haddad  <ryanhaddad@apple.com>
1431
1432         Unreviewed, rolling out r244299.
1433
1434         Breaks internal tests.
1435
1436         Reverted changeset:
1437
1438         "InjectedBundle parameters often need initialization function
1439         called before unarchiving"
1440         https://bugs.webkit.org/show_bug.cgi?id=189709
1441         https://trac.webkit.org/changeset/244299
1442
1443 2019-04-18  Yusuke Suzuki  <ysuzuki@apple.com>
1444
1445         [WTF] StringBuilder should set correct m_is8Bit flag when merging
1446         https://bugs.webkit.org/show_bug.cgi?id=197053
1447
1448         Reviewed by Saam Barati.
1449
1450         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1451         (TestWebKitAPI::TEST):
1452
1453 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1454
1455         [iOS Sim Debug] REGRESSION (r244151) TestWebKitAPI.WebKit.OverrideViewportArguments is failing (197028)
1456         https://bugs.webkit.org/show_bug.cgi?id=197028
1457         <rdar://problem/49985290>
1458
1459         Reviewed by Wenson Hsieh.
1460
1461         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
1462         (TEST):
1463         Liberal application of waitForNextPresentationUpdate works around a race
1464         where if the page rapidly changes its viewport arguments (or an API client
1465         rapidly changes its viewport arguments), we'd get stuck thinking that the
1466         user had intentionally zoomed the page, and stop resetting the initial scale.
1467         This deserves a separate bug, but no need to keep the test failing while
1468         we think about it.
1469
1470 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1471
1472         REGRESSION (r241988): Switching tabs is slow
1473         https://bugs.webkit.org/show_bug.cgi?id=197037
1474         <rdar://problem/49951473>
1475
1476         Reviewed by Simon Fraser.
1477
1478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1479         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm: Added.
1480         (TEST):
1481         * TestWebKitAPI/cocoa/TestWKWebView.h:
1482         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1483         (-[TestWKWebView addToTestWindow]):
1484         Add a test that hangs without this fix.
1485
1486 2019-04-17  Truitt Savell  <tsavell@apple.com>
1487
1488         Unreviewed, rolling out r244400.
1489
1490         Caused testing to exit early with assertionon Debug WK2
1491
1492         Reverted changeset:
1493
1494         "UI↔Web deadlock when printing with a JavaScript alert
1495         visible"
1496         https://bugs.webkit.org/show_bug.cgi?id=196839
1497         https://trac.webkit.org/changeset/244400
1498
1499 2019-04-17  Brady Eidson  <beidson@apple.com>
1500
1501         Link clicks in PDFs shouldn't send referrer headers.
1502         <rdar://problem/21142581> and https://bugs.webkit.org/show_bug.cgi?id=196980
1503
1504         Reviewed by Tim Horton.
1505
1506         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1507         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm: Added.
1508         (putPDFBytesCallback):
1509         (emptyReleaseInfoCallback):
1510         (createPDFWithLinkToURL):
1511         (TEST):
1512
1513 2019-04-17  Tim Horton  <timothy_horton@apple.com>
1514
1515         UI↔Web deadlock when printing with a JavaScript alert visible
1516         https://bugs.webkit.org/show_bug.cgi?id=196839
1517         <rdar://problem/49157642>
1518
1519         Reviewed by Andy Estes.
1520
1521         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1522         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewPrintFormatter.mm: Added.
1523         (-[PrintOnAlertUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1524         (TEST):
1525
1526 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1527
1528         WKRetainPtr's adoption constructor should be private
1529         https://bugs.webkit.org/show_bug.cgi?id=197019
1530
1531         Reviewed by Tim Horton.
1532
1533         * DumpRenderTree/mac/DumpRenderTree.mm:
1534         (dumpFramesAsText):
1535         * TestWebKitAPI/InjectedBundleController.cpp:
1536         (TestWebKitAPI::InjectedBundleController::initialize):
1537         * TestWebKitAPI/PlatformUtilities.cpp:
1538         (TestWebKitAPI::Util::createContextWithInjectedBundle):
1539         (TestWebKitAPI::Util::createInitializationDictionaryForInjectedBundleTest):
1540         (TestWebKitAPI::Util::createContextForInjectedBundleTest):
1541         (TestWebKitAPI::Util::toWK):
1542         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
1543         (TestWebKitAPI::TEST):
1544         * TestWebKitAPI/Tests/WebKit/CloseFromWithinCreatePage.cpp:
1545         (TestWebKitAPI::TEST):
1546         * TestWebKitAPI/Tests/WebKit/CloseThenTerminate.cpp:
1547         (TestWebKitAPI::TEST):
1548         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic.cpp:
1549         (TestWebKitAPI::TEST):
1550         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionBasic_Bundle.cpp:
1551         (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
1552         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache.cpp:
1553         (TestWebKitAPI::TEST):
1554         * TestWebKitAPI/Tests/WebKit/DOMWindowExtensionNoCache_Bundle.cpp:
1555         (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
1556         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
1557         (TestWebKitAPI::TEST):
1558         * TestWebKitAPI/Tests/WebKit/DidNotHandleKeyDown.cpp:
1559         (TestWebKitAPI::TEST):
1560         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1561         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1562         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash.cpp:
1563         (TestWebKitAPI::TEST):
1564         * TestWebKitAPI/Tests/WebKit/DocumentStartUserScriptAlertCrash_Bundle.cpp:
1565         (TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
1566         * TestWebKitAPI/Tests/WebKit/EnumerateMediaDevices.cpp:
1567         (TestWebKitAPI::TEST):
1568         * TestWebKitAPI/Tests/WebKit/EphemeralSessionPushStateNoHistoryCallback.cpp:
1569         (TestWebKitAPI::TEST):
1570         * TestWebKitAPI/Tests/WebKit/EvaluateJavaScript.cpp:
1571         (TestWebKitAPI::TEST):
1572         * TestWebKitAPI/Tests/WebKit/EventModifiers.cpp:
1573         (TestWebKitAPI::TEST):
1574         * TestWebKitAPI/Tests/WebKit/FailedLoad.cpp:
1575         (TestWebKitAPI::TEST):
1576         * TestWebKitAPI/Tests/WebKit/Find.cpp:
1577         (TestWebKitAPI::TEST):
1578         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
1579         (TestWebKitAPI::TEST):
1580         * TestWebKitAPI/Tests/WebKit/FirstMeaningfulPaintMilestone.cpp:
1581         (TestWebKitAPI::TEST):
1582         * TestWebKitAPI/Tests/WebKit/ForceRepaint.cpp:
1583         (TestWebKitAPI::TEST):
1584         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp:
1585         (TestWebKitAPI::TEST):
1586         * TestWebKitAPI/Tests/WebKit/FrameMIMETypeHTML.cpp:
1587         (TestWebKitAPI::TEST):
1588         * TestWebKitAPI/Tests/WebKit/FrameMIMETypePNG.cpp:
1589         (TestWebKitAPI::TEST):
1590         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
1591         (TestWebKitAPI::TEST):
1592         * TestWebKitAPI/Tests/WebKit/GetInjectedBundleInitializationUserDataCallback.cpp:
1593         (TestWebKitAPI::TEST):
1594         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle.cpp:
1595         (TestWebKitAPI::TEST):
1596         * TestWebKitAPI/Tests/WebKit/HitTestResultNodeHandle_Bundle.cpp:
1597         (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
1598         * TestWebKitAPI/Tests/WebKit/InjectedBundleBasic.cpp:
1599         (TestWebKitAPI::TEST):
1600         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior.cpp:
1601         (TestWebKitAPI::TEST):
1602         * TestWebKitAPI/Tests/WebKit/InjectedBundleDisableOverrideBuiltinsBehavior_Bundle.cpp:
1603         (TestWebKitAPI::InjectedBundleNoDisableOverrideBuiltinsBehaviorTest::initialize):
1604         (TestWebKitAPI::InjectedBundleDisableOverrideBuiltinsBehaviorTest::initialize):
1605         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest.cpp:
1606         (TestWebKitAPI::TEST):
1607         * TestWebKitAPI/Tests/WebKit/InjectedBundleFrameHitTest_Bundle.cpp:
1608         (TestWebKitAPI::InjectedBundleFrameHitTestTest::frameLoadFinished):
1609         * TestWebKitAPI/Tests/WebKit/InjectedBundleInitializationUserDataCallbackWins.cpp:
1610         (TestWebKitAPI::TEST):
1611         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen.cpp:
1612         (TestWebKitAPI::TEST):
1613         * TestWebKitAPI/Tests/WebKit/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1614         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1615         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
1616         (TestWebKitAPI::TEST):
1617         * TestWebKitAPI/Tests/WebKit/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
1618         (TestWebKitAPI::loadAlternateHTMLString):
1619         (TestWebKitAPI::TEST):
1620         * TestWebKitAPI/Tests/WebKit/LoadCanceledNoServerRedirectCallback.cpp:
1621         (TestWebKitAPI::TEST):
1622         * TestWebKitAPI/Tests/WebKit/LoadPageOnCrash.cpp:
1623         (TestWebKitAPI::WebKit2CrashLoader::WebKit2CrashLoader):
1624         * TestWebKitAPI/Tests/WebKit/MenuTypesForMouseEvents.cpp:
1625         (TestWebKitAPI::buildAndPerformTest):
1626         * TestWebKitAPI/Tests/WebKit/ModalAlertsSPI.cpp:
1627         (TestWebKitAPI::TEST):
1628         * TestWebKitAPI/Tests/WebKit/MouseMoveAfterCrash.cpp:
1629         (TestWebKitAPI::TEST):
1630         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayout.cpp:
1631         (TestWebKitAPI::TEST):
1632         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFails.cpp:
1633         (TestWebKitAPI::TEST):
1634         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
1635         (TestWebKitAPI::TEST):
1636         * TestWebKitAPI/Tests/WebKit/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1637         (TestWebKitAPI::TEST):
1638         * TestWebKitAPI/Tests/WebKit/PageLoadBasic.cpp:
1639         (TestWebKitAPI::TEST):
1640         * TestWebKitAPI/Tests/WebKit/PageLoadDidChangeLocationWithinPageForFrame.cpp:
1641         (TestWebKitAPI::TEST):
1642         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
1643         (TestWebKitAPI::TEST):
1644         * TestWebKitAPI/Tests/WebKit/PendingAPIRequestURL.cpp:
1645         (TestWebKitAPI::TEST):
1646         * TestWebKitAPI/Tests/WebKit/PreventEmptyUserAgent.cpp:
1647         (TestWebKitAPI::TEST):
1648         * TestWebKitAPI/Tests/WebKit/PrivateBrowsingPushStateNoHistoryCallback.cpp:
1649         (TestWebKitAPI::TEST):
1650         * TestWebKitAPI/Tests/WebKit/ProcessDidTerminate.cpp:
1651         (TestWebKitAPI::TEST):
1652         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
1653         (TestWebKitAPI::TEST):
1654         * TestWebKitAPI/Tests/WebKit/ResizeReversePaginatedWebView.cpp:
1655         (TestWebKitAPI::TEST):
1656         * TestWebKitAPI/Tests/WebKit/ResizeWindowAfterCrash.cpp:
1657         (TestWebKitAPI::TEST):
1658         * TestWebKitAPI/Tests/WebKit/RestoreSessionState.cpp:
1659         (TestWebKitAPI::TEST):
1660         * TestWebKitAPI/Tests/WebKit/RestoreSessionStateContainingFormData.cpp:
1661         (TestWebKitAPI::TEST):
1662         * TestWebKitAPI/Tests/WebKit/ScrollPinningBehaviors.cpp:
1663         (TestWebKitAPI::TEST):
1664         * TestWebKitAPI/Tests/WebKit/ShouldKeepCurrentBackForwardListItemInList.cpp:
1665         (TestWebKitAPI::TEST):
1666         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp:
1667         (TestWebKitAPI::TEST):
1668         * TestWebKitAPI/Tests/WebKit/StopLoadingDuringDidFailProvisionalLoad.cpp:
1669         (TestWebKitAPI::TEST):
1670         * TestWebKitAPI/Tests/WebKit/TerminateTwice.cpp:
1671         (TestWebKitAPI::TEST):
1672         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
1673         (TestWebKitAPI::TEST):
1674         * TestWebKitAPI/Tests/WebKit/WKPageCopySessionStateWithFiltering.cpp:
1675         (TestWebKitAPI::TEST):
1676         * TestWebKitAPI/Tests/WebKit/WKPageGetScaleFactorNotZero.cpp:
1677         (TestWebKitAPI::TEST):
1678         * TestWebKitAPI/Tests/WebKit/WKPageIsPlayingAudio.cpp:
1679         (TestWebKitAPI::TEST):
1680         * TestWebKitAPI/Tests/WebKit/WKPreferences.cpp:
1681         (TestWebKitAPI::TEST):
1682         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
1683         (TestWebKitAPI::TEST):
1684         * TestWebKitAPI/Tests/WebKit/WillSendSubmitEvent.cpp:
1685         (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
1686         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
1687         (TestWebKitAPI::TEST):
1688         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
1689         (TestWebKitAPI::TEST):
1690         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
1691         (TestWebKitAPI::TEST):
1692         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
1693         (TestWebKitAPI::TEST):
1694         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
1695         (TestWebKitAPI::TEST):
1696         * TestWebKitAPI/Tests/WebKit/mac/GetPIDAfterAbortedProcessLaunch.cpp:
1697         (TestWebKitAPI::TEST):
1698         * TestWebKitAPI/Tests/WebKit/mac/InjectedBundleAppleEvent.cpp:
1699         (TestWebKitAPI::TEST):
1700         * TestWebKitAPI/Tests/WebKit/mac/RestoreStateAfterTermination.mm:
1701         (TestWebKitAPI::TEST):
1702         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1703         (TestWebKitAPI::TEST):
1704         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1705         (TestWebKitAPI::TEST):
1706         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
1707         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
1708         (TEST):
1709         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1710         (TEST):
1711         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
1712         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1713         (TEST):
1714         * TestWebKitAPI/Tests/mac/FirstResponderScrollingPosition.mm:
1715         (TestWebKitAPI::TEST):
1716         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
1717         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
1718         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
1719         (WTR::getMenuItemTitleCallback):
1720         (WTR::createMouseMessageBody):
1721         (WTR::EventSendingController::mouseDown):
1722         (WTR::EventSendingController::mouseUp):
1723         (WTR::EventSendingController::mouseMoveTo):
1724         (WTR::EventSendingController::mouseForceClick):
1725         (WTR::EventSendingController::startAndCancelMouseForceClick):
1726         (WTR::EventSendingController::mouseForceDown):
1727         (WTR::EventSendingController::mouseForceUp):
1728         (WTR::EventSendingController::mouseForceChanged):
1729         (WTR::EventSendingController::leapForward):
1730         (WTR::EventSendingController::scheduleAsynchronousClick):
1731         (WTR::createKeyDownMessageBody):
1732         (WTR::EventSendingController::keyDown):
1733         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
1734         (WTR::EventSendingController::mouseScrollBy):
1735         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
1736         (WTR::EventSendingController::continuousMouseScrollBy):
1737         (WTR::EventSendingController::addTouchPoint):
1738         (WTR::EventSendingController::updateTouchPoint):
1739         (WTR::EventSendingController::setTouchModifier):
1740         (WTR::EventSendingController::setTouchPointRadius):
1741         (WTR::EventSendingController::touchStart):
1742         (WTR::EventSendingController::touchMove):
1743         (WTR::EventSendingController::touchEnd):
1744         (WTR::EventSendingController::touchCancel):
1745         (WTR::EventSendingController::clearTouchPoints):
1746         (WTR::EventSendingController::releaseTouchPoint):
1747         (WTR::EventSendingController::cancelTouchPoint):
1748         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1749         (WTR::InjectedBundle::didCreatePage):
1750         (WTR::InjectedBundle::didReceiveMessage):
1751         (WTR::InjectedBundle::didReceiveMessageToPage):
1752         (WTR::InjectedBundle::booleanForKey):
1753         (WTR::InjectedBundle::done):
1754         (WTR::InjectedBundle::dumpToStdErr):
1755         (WTR::InjectedBundle::outputText):
1756         (WTR::InjectedBundle::postNewBeforeUnloadReturnValue):
1757         (WTR::InjectedBundle::postAddChromeInputField):
1758         (WTR::InjectedBundle::postRemoveChromeInputField):
1759         (WTR::InjectedBundle::postFocusWebView):
1760         (WTR::InjectedBundle::postSetBackingScaleFactor):
1761         (WTR::InjectedBundle::postSetWindowIsKey):
1762         (WTR::InjectedBundle::postSetViewSize):
1763         (WTR::InjectedBundle::postSimulateWebNotificationClick):
1764         (WTR::InjectedBundle::postSetAddsVisitedLinks):
1765         (WTR::InjectedBundle::setGeolocationPermission):
1766         (WTR::InjectedBundle::setMockGeolocationPosition):
1767         (WTR::InjectedBundle::setMockGeolocationPositionUnavailableError):
1768         (WTR::InjectedBundle::isGeolocationProviderActive const):
1769         (WTR::InjectedBundle::imageCountInGeneralPasteboard const):
1770         (WTR::InjectedBundle::setUserMediaPersistentPermissionForOrigin):
1771         (WTR::InjectedBundle::userMediaPermissionRequestCountForOrigin const):
1772         (WTR::InjectedBundle::resetUserMediaPermissionRequestCountForOrigin):
1773         (WTR::InjectedBundle::setCustomPolicyDelegate):
1774         (WTR::InjectedBundle::setHidden):
1775         (WTR::InjectedBundle::setCacheModel):
1776         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1777         (WTR::InjectedBundle::processWorkQueue):
1778         (WTR::InjectedBundle::queueBackNavigation):
1779         (WTR::InjectedBundle::queueForwardNavigation):
1780         (WTR::InjectedBundle::queueLoad):
1781         (WTR::InjectedBundle::queueLoadHTMLString):
1782         (WTR::InjectedBundle::queueReload):
1783         (WTR::InjectedBundle::queueLoadingScript):
1784         (WTR::InjectedBundle::queueNonLoadingScript):
1785         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1786         (WTR::frameToStr):
1787         (WTR::InjectedBundlePage::InjectedBundlePage):
1788         (WTR::dumpFrameDescriptionSuitableForTestResult):
1789         (WTR::dumpFrameScrollPosition):
1790         (WTR::dumpDescendantFrameScrollPositions):
1791         (WTR::dumpFrameText):
1792         (WTR::dumpDescendantFramesText):
1793         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1794         (WTR::TestRunner::shouldDumpPixels const):
1795         (WTR::TestRunner::setDumpPixels):
1796         (WTR::TestRunner::whatToDump const):
1797         (WTR::TestRunner::setWhatToDump):
1798         (WTR::TestRunner::setWaitUntilDone):
1799         (WTR::TestRunner::shouldWaitUntilDone const):
1800         (WTR::TestRunner::setShouldDumpFrameLoadCallbacks):
1801         (WTR::TestRunner::shouldDumpFrameLoadCallbacks):
1802         (WTR::TestRunner::clearAllDatabases):
1803         (WTR::TestRunner::setIDBPerOriginQuota):
1804         (WTR::TestRunner::originsWithApplicationCache):
1805         (WTR::TestRunner::setCanOpenWindows):
1806         (WTR::TestRunner::setXSSAuditorEnabled):
1807         (WTR::TestRunner::setMediaDevicesEnabled):
1808         (WTR::TestRunner::setWebRTCMDNSICECandidatesEnabled):
1809         (WTR::TestRunner::setWebRTCUnifiedPlanEnabled):
1810         (WTR::TestRunner::setCustomUserAgent):
1811         (WTR::TestRunner::setWebAPIStatisticsEnabled):
1812         (WTR::TestRunner::setModernMediaControlsEnabled):
1813         (WTR::TestRunner::setWebGL2Enabled):
1814         (WTR::TestRunner::setWritableStreamAPIEnabled):
1815         (WTR::TestRunner::setReadableByteStreamAPIEnabled):
1816         (WTR::TestRunner::setEncryptedMediaAPIEnabled):
1817         (WTR::TestRunner::setAllowsAnySSLCertificate):
1818         (WTR::TestRunner::setPluginsEnabled):
1819         (WTR::TestRunner::setValueForUser):
1820         (WTR::TestRunner::setAudioResult):
1821         (WTR::TestRunner::didReceiveServerRedirectForProvisionalNavigation const):
1822         (WTR::TestRunner::clearDidReceiveServerRedirectForProvisionalNavigation):
1823         (WTR::TestRunner::setAlwaysAcceptCookies):
1824         (WTR::TestRunner::setOnlyAcceptFirstPartyCookies):
1825         (WTR::TestRunner::isDoingMediaCapture const):
1826         (WTR::TestRunner::queueLoad):
1827         (WTR::TestRunner::setRejectsProtectionSpaceAndContinueForAuthenticationChallenges):
1828         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1829         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1830         (WTR::TestRunner::setShouldLogDownloadCallbacks):
1831         (WTR::TestRunner::setAuthenticationUsername):
1832         (WTR::TestRunner::setAuthenticationPassword):
1833         (WTR::TestRunner::secureEventInputIsEnabled const):
1834         (WTR::TestRunner::setBlockAllPlugins):
1835         (WTR::TestRunner::setPluginSupportedMode):
1836         (WTR::TestRunner::setShouldDecideNavigationPolicyAfterDelay):
1837         (WTR::TestRunner::setShouldDecideResponsePolicyAfterDelay):
1838         (WTR::TestRunner::setNavigationGesturesEnabled):
1839         (WTR::TestRunner::setIgnoresViewportScaleLimits):
1840         (WTR::TestRunner::setShouldDownloadUndisplayableMIMETypes):
1841         (WTR::TestRunner::setShouldAllowDeviceOrientationAndMotionAccess):
1842         (WTR::TestRunner::terminateNetworkProcess):
1843         (WTR::TestRunner::terminateServiceWorkerProcess):
1844         (WTR::TestRunner::runUIScript):
1845         (WTR::TestRunner::setStatisticsDebugMode):
1846         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
1847         (WTR::TestRunner::setStatisticsLastSeen):
1848         (WTR::TestRunner::setStatisticsPrevalentResource):
1849         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1850         (WTR::TestRunner::dumpResourceLoadStatistics):
1851         (WTR::TestRunner::isStatisticsPrevalentResource):
1852         (WTR::TestRunner::isStatisticsVeryPrevalentResource):
1853         (WTR::TestRunner::isStatisticsRegisteredAsSubresourceUnder):
1854         (WTR::TestRunner::isStatisticsRegisteredAsSubFrameUnder):
1855         (WTR::TestRunner::isStatisticsRegisteredAsRedirectingTo):
1856         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1857         (WTR::TestRunner::isStatisticsHasHadUserInteraction):
1858         (WTR::TestRunner::setStatisticsGrandfathered):
1859         (WTR::TestRunner::isStatisticsGrandfathered):
1860         (WTR::TestRunner::setStatisticsSubframeUnderTopFrameOrigin):
1861         (WTR::TestRunner::setStatisticsSubresourceUnderTopFrameOrigin):
1862         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectTo):
1863         (WTR::TestRunner::setStatisticsSubresourceUniqueRedirectFrom):
1864         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectTo):
1865         (WTR::TestRunner::setStatisticsTopFrameUniqueRedirectFrom):
1866         (WTR::TestRunner::setStatisticsCrossSiteLoadWithLinkDecoration):
1867         (WTR::TestRunner::setStatisticsTimeToLiveUserInteraction):
1868         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
1869         (WTR::TestRunner::statisticsProcessStatisticsAndDataRecords):
1870         (WTR::TestRunner::statisticsUpdateCookieBlocking):
1871         (WTR::TestRunner::statisticsSubmitTelemetry):
1872         (WTR::TestRunner::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
1873         (WTR::TestRunner::setStatisticsIsRunningTest):
1874         (WTR::TestRunner::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
1875         (WTR::TestRunner::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
1876         (WTR::TestRunner::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
1877         (WTR::TestRunner::setStatisticsGrandfatheringTime):
1878         (WTR::TestRunner::setStatisticsMaxStatisticsEntries):
1879         (WTR::TestRunner::setStatisticsPruneEntriesDownTo):
1880         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
1881         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
1882         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
1883         (WTR::TestRunner::statisticsDeleteCookiesForHost):
1884         (WTR::TestRunner::setStatisticsCacheMaxAgeCap):
1885         (WTR::TestRunner::statisticsResetToConsistentState):
1886         (WTR::TestRunner::setStorageAccessAPIEnabled):
1887         (WTR::TestRunner::getAllStorageAccessEntries):
1888         (WTR::TestRunner::addMockMediaDevice):
1889         (WTR::TestRunner::clearMockMediaDevices):
1890         (WTR::TestRunner::removeMockMediaDevice):
1891         (WTR::TestRunner::resetMockMediaDevices):
1892         (WTR::TestRunner::connectMockGamepad):
1893         (WTR::TestRunner::disconnectMockGamepad):
1894         (WTR::TestRunner::setMockGamepadDetails):
1895         (WTR::TestRunner::setMockGamepadAxisValue):
1896         (WTR::TestRunner::setMockGamepadButtonValue):
1897         (WTR::TestRunner::removeAllSessionCredentials):
1898         (WTR::TestRunner::clearDOMCache):
1899         (WTR::TestRunner::clearDOMCaches):
1900         (WTR::TestRunner::hasDOMCache):
1901         (WTR::TestRunner::domCacheSize):
1902         (WTR::TestRunner::setAllowStorageQuotaIncrease):
1903         (WTR::TestRunner::getApplicationManifestThen):
1904         (WTR::TestRunner::injectUserScript):
1905         (WTR::TestRunner::sendDisplayConfigurationChangedMessageForTesting):
1906         (WTR::TestRunner::setWebAuthenticationMockConfiguration):
1907         (WTR::TestRunner::addTestKeyToKeychain):
1908         (WTR::TestRunner::cleanUpKeychain):
1909         (WTR::TestRunner::keyExistsInKeychain):
1910         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
1911         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
1912         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
1913         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
1914         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
1915         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
1916         * WebKitTestRunner/TestController.cpp:
1917         (WTR::TestController::initialize):
1918         (WTR::parseStringTestHeaderValueAsRelativePath):
1919         (WTR::updateTestOptionsFromTestHeader):
1920         (WTR::TestController::runTest):
1921         (WTR::TestController::didReceiveLiveDocumentsList):
1922         (WTR::TestController::didReceiveMessageFromInjectedBundle):
1923         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1924         (WTR::TestController::didFinishNavigation):
1925         (WTR::TestController::didReceiveAuthenticationChallenge):
1926         * WebKitTestRunner/TestInvocation.cpp:
1927         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1928         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1929         (WTR::TestInvocation::uiScriptDidComplete):
1930         (WTR::TestInvocation::didReceiveAllStorageAccessEntries):
1931         * WebKitTestRunner/WebNotificationProvider.cpp:
1932         (WTR::WebNotificationProvider::closeWebNotification):
1933         * WebKitTestRunner/WorkQueueManager.cpp:
1934         (WTR::ScriptItem::ScriptItem):
1935         (WTR::WorkQueueManager::queueLoad):
1936         (WTR::WorkQueueManager::queueLoadHTMLString):
1937
1938 2019-04-17  Alex Christensen  <achristensen@webkit.org>
1939
1940         Add a comment to make my test from r244139 less mysterious.
1941         https://bugs.webkit.org/show_bug.cgi?id=196744
1942
1943         As suggested by Darin Adler.
1944
1945         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
1946         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1947
1948 2019-04-17  Chris Dumez  <cdumez@apple.com>
1949
1950         Remember device orientation permission for the duration of the browsing session
1951         https://bugs.webkit.org/show_bug.cgi?id=196992
1952         <rdar://problem/49946067>
1953
1954         Reviewed by Alex Christensen.
1955
1956         Add API test coverage.
1957
1958         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
1959         (-[DeviceOrientationPermissionUIDelegate _webView:shouldAllowDeviceOrientationAndMotionAccessRequestedByFrame:decisionHandler:]):
1960         (TEST):
1961
1962 2019-04-17  Aakash Jain  <aakash_jain@apple.com>
1963
1964         [ews-app] Clicking 'submit to new ews' doesn't reload status-bubble
1965         https://bugs.webkit.org/show_bug.cgi?id=196675
1966
1967         Reviewed by Lucas Forschler.
1968
1969         * BuildSlaveSupport/ews-app/ews/views/submittoews.py:
1970         (SubmitToEWS): Added @xframe_options_exempt similar to statusbubble.py
1971
1972 2019-04-16  Wenson Hsieh  <wenson_hsieh@apple.com>
1973
1974         [iOS] [WebKit2] Add support for honoring -[UIMenuItem dontDismiss]
1975         https://bugs.webkit.org/show_bug.cgi?id=196919
1976         <rdar://problem/41630459>
1977
1978         Reviewed by Tim Horton.
1979
1980         Add iOS support for several new testing hooks. See below for more detail.
1981
1982         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1983         (WTR::UIScriptController::isDismissingMenu const):
1984
1985         Add a new script controller method to query whether the platform menu (on iOS, the callout bar) is done
1986         dismissing. We consider the menu to be dismissing in between the `-WillHide` and `-DidHide` notifications sent
1987         by UIKit when dismissing the callout bar (i.e. UIMenuController).
1988
1989         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1990         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1991         (WTR::UIScriptController::isDismissingMenu const):
1992         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1993         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1994         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1995         (WTR::InjectedBundle::didReceiveMessageToPage):
1996         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1997         (WTR::TestRunner::setAllowedMenuActions):
1998
1999         Add a new helper method to specify a list of allowed actions when bringing up the menu. On iOS, in the case of
2000         actions supported by the platform, this matches against method selector names (for instance, "SelectAll", or
2001         "Copy", or "Paste"). In the case of the custom actions installed via `installCustomMenuAction`, we instead match
2002         against the name of the custom action.
2003
2004         (WTR::TestRunner::installCustomMenuAction):
2005
2006         Add a new helper method to install a custom action for the context menu (on iOS, this is the callout bar). This
2007         takes the name of the action (which appears in a button in the callout bar), whether the action should cause
2008         the callout bar to automatically dismiss, and finally, a JavaScript callback that is invoked when the action is
2009         triggered.
2010
2011         (WTR::TestRunner::performCustomMenuAction):
2012
2013         Invoked when the custom menu action is triggered.
2014
2015         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2016         * WebKitTestRunner/TestController.cpp:
2017         (WTR::TestController::installCustomMenuAction):
2018         (WTR::TestController::setAllowedMenuActions):
2019         * WebKitTestRunner/TestController.h:
2020         * WebKitTestRunner/TestInvocation.cpp:
2021         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
2022         (WTR::TestInvocation::performCustomMenuAction):
2023
2024         Add plumbing to call back into the injected bundle when performing the custom action.
2025
2026         * WebKitTestRunner/TestInvocation.h:
2027         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2028         (WTR::TestController::installCustomMenuAction):
2029         (WTR::TestController::setAllowedMenuActions):
2030         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2031         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2032         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2033         (-[TestRunnerWKWebView becomeFirstResponder]):
2034         (-[TestRunnerWKWebView _addCustomItemToMenuControllerIfNecessary]):
2035
2036         Helper method that converts web view's current custom menu action info into a UIMenuItem, and adds it to the
2037         shared menu controller. This is also invoked when the web view becomes first responder, which matches behavior
2038         in the Mail app on iOS.
2039
2040         (-[TestRunnerWKWebView installCustomMenuAction:dismissesAutomatically:callback:]):
2041         (-[TestRunnerWKWebView setAllowedMenuActions:]):
2042         (-[TestRunnerWKWebView resetCustomMenuAction]):
2043         (-[TestRunnerWKWebView performCustomAction:]):
2044         (-[TestRunnerWKWebView canPerformAction:withSender:]):
2045         (-[TestRunnerWKWebView _willHideMenu]):
2046         (-[TestRunnerWKWebView _didHideMenu]):
2047         * WebKitTestRunner/ios/TestControllerIOS.mm:
2048         (WTR::TestController::platformResetStateToConsistentValues):
2049
2050         Reset both any custom installed actions on the shared menu controller, as well as the list of allowed actions,
2051         if specified.
2052
2053         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2054         (WTR::UIScriptController::isDismissingMenu const):
2055
2056 2019-04-16  Megan Gardner  <megan_gardner@apple.com>
2057
2058         Allow sharing from imageSheet on an image document
2059         https://bugs.webkit.org/show_bug.cgi?id=196891
2060         <rdar://problem/25377386>
2061
2062         Reviewed by Tim Horton.
2063
2064         Test to make sure that the correct imageURL is extracted from an image element.
2065
2066         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
2067         (TestWebKitAPI::TEST):
2068
2069 2019-04-16  Alex Christensen  <achristensen@webkit.org>
2070
2071         REGRESSION(r244162) Clearing website data from ephemeral WKWebsiteDataStore should finish instead of asserting or hanging
2072         https://bugs.webkit.org/show_bug.cgi?id=196995
2073
2074         Reviewed by Brady Eidson.
2075
2076         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
2077         (TEST):
2078
2079 2019-04-16  Chris Dumez  <cdumez@apple.com>
2080
2081         URL set by document.open() is not communicated to the UIProcess
2082         https://bugs.webkit.org/show_bug.cgi?id=196941
2083         <rdar://problem/49237544>
2084
2085         Reviewed by Geoff Garen.
2086
2087         Add API test coverage.
2088
2089         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2090         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2091         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2092         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2093         (TEST):
2094
2095 2019-04-16  Commit Queue  <commit-queue@webkit.org>
2096
2097         Unreviewed, rolling out r244321.
2098         https://bugs.webkit.org/show_bug.cgi?id=196968
2099
2100         Causing all WK2 Debug builds to exit early after Assertion
2101         failures. (Requested by ShawnRoberts on #webkit).
2102
2103         Reverted changeset:
2104
2105         "URL set by document.open() is not communicated to the
2106         UIProcess"
2107         https://bugs.webkit.org/show_bug.cgi?id=196941
2108         https://trac.webkit.org/changeset/244321
2109
2110 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2111
2112         Regression (r244291): Broken API Test AutoLayoutRenderingProgressRelativeOrdering
2113         https://bugs.webkit.org/show_bug.cgi?id=196948
2114
2115         Reviewed by Zalan Bujtas.
2116
2117         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
2118         (TEST): Disabling the test for now to keep infrastructure happy, while the root-cause is being investigated.
2119
2120 2019-04-15  Chris Dumez  <cdumez@apple.com>
2121
2122         URL set by document.open() is not communicated to the UIProcess
2123         https://bugs.webkit.org/show_bug.cgi?id=196941
2124         <rdar://problem/49237544>
2125
2126         Reviewed by Geoffrey Garen.
2127
2128         Add API test coverage.
2129
2130         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2131         * TestWebKitAPI/Tests/WebKit/open-window-then-write-to-it.html: Added.
2132         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
2133         (-[OpenWindowThenDocumentOpenUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
2134         (TEST):
2135
2136 2019-04-15  Dean Johnson  <dean_johnson@apple.com>
2137
2138         Using Tools/Scripts/clean-webkit should not install requests
2139         https://bugs.webkit.org/show_bug.cgi?id=196940
2140
2141         Reviewed by Lucas Forschler.
2142
2143         * Scripts/webkitpy/common/system/autoinstall.py: Drive-by fix for no logging handlers
2144         existing, depending on the path autoinstalled is run through.
2145         * Scripts/webkitpy/port/base.py: Import webkitpy.results.upload.Upload only where it's
2146         needed.
2147         (Port.configuration_for_upload):
2148         (Port.commits_for_upload):
2149
2150 2019-04-15  Alex Christensen  <achristensen@webkit.org>
2151
2152         Add a DiagnosticLogging method taking an arbitrary dictionary of values.
2153         https://bugs.webkit.org/show_bug.cgi?id=196773
2154
2155         Reviewed by Jer Noble.
2156
2157         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewDiagnosticLogging.mm:
2158         (-[TestLoggingDelegate _webView:logDiagnosticMessage:description:valueDictionary:]):
2159         (TEST):
2160
2161 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2162
2163         ews-build should clearly indicate flaky test failures
2164         https://bugs.webkit.org/show_bug.cgi?id=196947
2165
2166         Reviewed by Lucas Forschler.
2167
2168         * BuildSlaveSupport/ews-build/steps.py:
2169         (AnalyzeAPITestsResults.analyzeResults):
2170
2171 2019-04-15  Brent Fulgham  <bfulgham@apple.com>
2172
2173         InjectedBundle parameters often need initialization function called before unarchiving
2174         https://bugs.webkit.org/show_bug.cgi?id=189709
2175         <rdar://problem/44573653>
2176
2177         Reviewed by Ryosuke Niwa.
2178
2179         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
2180         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
2181
2182 2019-04-12  Ryosuke Niwa  <rniwa@webkit.org>
2183
2184         HashTable::removeIf always shrinks the hash table by half even if there is nothing left
2185         https://bugs.webkit.org/show_bug.cgi?id=196681
2186
2187         Reviewed by Darin Adler.
2188
2189         Added tests.
2190
2191         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2192         (WTF_HashSet.RemoveIf):
2193         (WTF_HashSet.RemoveIfShrinkToBestSize):
2194
2195 2019-04-15  John Wilander  <wilander@apple.com>
2196
2197         Send delayed Ad Click Attribution conversion requests to the click source
2198         https://bugs.webkit.org/show_bug.cgi?id=196838
2199         <rdar://problem/47650157>
2200
2201         Reviewed by Chris Dumez and Youenn Fablet.
2202
2203         This patch adds test infrastructure to override the default behavior in
2204         WebKit::NetworkAdClickAttribution.
2205
2206         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2207         (TestWebKitAPI::TEST):
2208         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2209         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2210         (WTR::TestRunner::dumpAdClickAttribution):
2211         (WTR::TestRunner::clearAdClickAttribution):
2212         (WTR::TestRunner::setAdClickAttributionOverrideTimerForTesting):
2213         (WTR::TestRunner::setAdClickAttributionConversionURLForTesting):
2214         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2215         * WebKitTestRunner/TestController.cpp:
2216         (WTR::TestController::setAdClickAttributionOverrideTimerForTesting):
2217         (WTR::TestController::setAdClickAttributionConversionURLForTesting):
2218         * WebKitTestRunner/TestController.h:
2219         * WebKitTestRunner/TestInvocation.cpp:
2220         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2221
2222 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2223
2224         [ews-app] status-bubble should display position in queue
2225         https://bugs.webkit.org/show_bug.cgi?id=196607
2226
2227         Reviewed by Lucas Forschler.
2228
2229         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
2230         (StatusBubble._build_bubble):
2231         (StatusBubble._queue_position): Method to calculate patch's position in queue.
2232
2233 2019-04-15  Aakash Jain  <aakash_jain@apple.com>
2234
2235         [ews-build] Do not run clean build by default on EWS builders
2236         https://bugs.webkit.org/show_bug.cgi?id=196897
2237
2238         Reviewed by Lucas Forschler.
2239
2240         * BuildSlaveSupport/ews-build/steps.py:
2241         (ApplyPatch.start): Do not create .buildbot-patched file. This is a special file for Buildbot and if this
2242         file is present, during the Source checkout, Buildbot cleans the working directory completely (including removing 
2243         untracked directories like WebKitBuild).
2244         (CheckOutSource.__init__): Pass method=clean so that Buildbot clean the working directory. This does not remove
2245         untracked files/directories (like WebKitBuild).
2246
2247 2019-04-15  Per Arne Vollan  <pvollan@apple.com>
2248
2249         TestRunner::notifyDone() should be safely reentrant
2250         https://bugs.webkit.org/show_bug.cgi?id=196898
2251
2252         Reviewed by Darin Adler.
2253
2254         It is currently possible that TestRunner::notifyDone() will call itself, since
2255         notifyDone() will force a repaint, which can start executing JavaScript, which
2256         may call notifyDone() again. This can lead to test failures and flakiness.
2257         Fix this by setting the m_waitToDump flag before calling the dump() method.
2258
2259         * DumpRenderTree/mac/TestRunnerMac.mm:
2260         (TestRunner::notifyDone):
2261         (TestRunner::forceImmediateCompletion):
2262         * DumpRenderTree/win/TestRunnerWin.cpp:
2263         (TestRunner::notifyDone):
2264         (TestRunner::forceImmediateCompletion):
2265
2266 2019-04-15  Philippe Normand  <pnormand@igalia.com>
2267
2268         [GTK][WPE] Add enable-media websetting
2269         https://bugs.webkit.org/show_bug.cgi?id=196863
2270
2271         Reviewed by Michael Catanzaro.
2272
2273         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2274         (testWebKitSettings): Add test for the enable-media web-setting.
2275
2276 2019-04-14  Wenson Hsieh  <wenson_hsieh@apple.com>
2277
2278         API test WKAttachmentTests.AddAttachmentToConnectedImageElement is a flaky failure on Mac Release builds
2279         https://bugs.webkit.org/show_bug.cgi?id=196905
2280         <rdar://problem/49886096>
2281
2282         Reviewed by Tim Horton.
2283
2284         This flaky test exercises a race condition between when attachment insertion updates are dispatched from the web
2285         process to the UI process, and when script is executed via -[WKWebView evaluateJavaScript:completionHandler:].
2286         Since attachment insertion and removal updates from the web process to the UI process are scheduled on a zero-
2287         delay timer, we end up with this sequence of events in the problematic (failure) case:
2288
2289         (a) [UI]    Run script #1 (which calls `HTMLAttachmentElement.getAttachmentIdentifier`)
2290             ...IPC from UI to web process...
2291         (b) [Web]   Evaluate script #1 in the web process, which schedules attachment updates on a zero-delay timer
2292             ...IPC from web to UI process...
2293         (c) [UI]    Invoke completion handler for script #1
2294         (d) [UI]    Run script #2 (which calls `document.querySelector('img').attachmentIdentifier`)
2295             ...IPC from UI to web process...
2296         (e) [Web]   Evaluate script #2 in the web process
2297         (f) [Web]   Zero-delay timer fires and dispatches attachment updates to the UI process
2298
2299         ...which means that script #2 will complete before the UI process has received the attachment updates sent in
2300         step (f). However, in the case where the flaky test succeeds, the zero-delay timer in (f) fires *before* script
2301         #2 is run in step (e).
2302
2303         This patch fixes the flaky test by waiting until attachment insertion updates are guaranteed to be received in
2304         the UI process by waiting on a script message posted by the web process, after attachment updates are
2305         dispatched.
2306
2307         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2308         (TestWebKitAPI::TEST):
2309
2310 2019-04-14  Aakash Jain  <aakash_jain@apple.com>
2311
2312         Disable Flaky API Test WKAttachmentTests.AddAttachmentToConnectedImageElement
2313         https://bugs.webkit.org/show_bug.cgi?id=196909
2314
2315         Reviewed by Wenson Hsieh.
2316
2317         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2318         (TestWebKitAPI::TEST):
2319
2320 2019-04-13  Tadeu Zagallo  <tzagallo@apple.com>
2321
2322         CodeCache should check that the UnlinkedCodeBlock was successfully created before caching it
2323         https://bugs.webkit.org/show_bug.cgi?id=196880
2324
2325         Reviewed by Yusuke Suzuki.
2326
2327         Add a new function for bytecode cache tests that does not forceDiskCache
2328         for the second run: runBytecodeCacheNoAssetion. This is necessary for the
2329         test added in this patch, since the code is invalid and therefore won't be
2330         cached. It should also be useful for tests that evaluate dynamically
2331         generated code.
2332
2333         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2334         * Scripts/run-jsc-stress-tests:
2335
2336 2019-04-12  Eric Carlson  <eric.carlson@apple.com>
2337
2338         Update AudioSession route sharing policy
2339         https://bugs.webkit.org/show_bug.cgi?id=196776
2340         <rdar://problem/46501611>
2341
2342         Reviewed by Jer Noble.
2343
2344         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2345         (TestWebKitAPI::routeSharingPolicyLongFormVideo):
2346         (TestWebKitAPI::routeSharingPolicyLongFormAudio):
2347         (TestWebKitAPI::TEST):
2348
2349 2019-04-12  Wenson Hsieh  <wenson_hsieh@apple.com>
2350
2351         [iOS] Software keyboard is shown too frequently on some websites
2352         https://bugs.webkit.org/show_bug.cgi?id=195856
2353         <rdar://problem/49191395>
2354
2355         Reviewed by Darin Adler.
2356
2357         Add support for attaching or detaching the hardware keyboard on iOS in layout tests.
2358
2359         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2360         (WTR::UIScriptController::setHardwareKeyboardAttached):
2361         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2362         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2363         (WTR::UIScriptController::setHardwareKeyboardAttached):
2364         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2365         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2366
2367         Additionally link against GraphicsServices in WebKitTestRunner.
2368
2369         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2370         (WTR::TestController::platformResetStateToConsistentValues):
2371         (WTR::UIScriptController::setHardwareKeyboardAttached):
2372
2373 2019-04-12  Ludovico de Nittis  <ludovico.denittis@collabora.com>
2374
2375         [GTK][WPE] Fix pacman install-dependencies packages
2376         https://bugs.webkit.org/show_bug.cgi?id=196817
2377
2378         Reviewed by Žan Doberšek.
2379         
2380         python3-setuptools is called python-setuptools
2381         ruby-highline is only available on AUR
2382         libv4l-devel is incorporated in v4l-utils
2383
2384         * gtk/install-dependencies:
2385         * wpe/install-dependencies:
2386
2387 2019-04-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2388
2389         [GTK] REGRESSION(r243860): Many tests failing
2390         https://bugs.webkit.org/show_bug.cgi?id=196791
2391
2392         Reviewed by Joanmarie Diggs.
2393
2394         Rework the accessibility unit test to use DBus for the communication with the server. This way we can load
2395         multiple documents and check that accessibility hierarchy is updated after a navigation.
2396
2397         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
2398         (loadChangedCallback):
2399         * TestWebKitAPI/Tests/WebKitGtk/TestWebKitAccessibility.cpp:
2400         (AccessibilityTest::AccessibilityTest):
2401         (AccessibilityTest::~AccessibilityTest):
2402         (AccessibilityTest::loadHTMLAndWaitUntilFinished):
2403         (AccessibilityTest::findTestServerApplication):
2404         (AccessibilityTest::findDocumentWeb):
2405         (AccessibilityTest::findRootObject):
2406         (AccessibilityTest::waitUntilChildrenRemoved):
2407         (AccessibilityTest::ensureProxy):
2408         (testAtspiBasicHierarchy):
2409         (beforeAll):
2410         (afterAll):
2411
2412 2019-04-11  Aakash Jain  <aakash_jain@apple.com>
2413
2414         [ews-build] Handle bug titles with unicode characters
2415         https://bugs.webkit.org/show_bug.cgi?id=196802
2416
2417         Reviewed by Dewei Zhu.
2418
2419         * BuildSlaveSupport/ews-build/steps.py:
2420         (ValidatePatch._is_bug_closed):
2421
2422 2019-04-11  Michael Saboff  <msaboff@apple.com>
2423
2424         Improve the Inline Cache Stats code
2425         https://bugs.webkit.org/show_bug.cgi?id=196836
2426
2427         Reviewed by Saam Barati.
2428
2429         Added a new script to consolidate and arrange the output of --useICStats option.
2430
2431         This script merges the output from every group into one large table and sorts it from most common to
2432         least common.  It also counts the slow path GetById and PutById variants and then calculates the
2433         percentage of gets or puts for each unique base,property pair compared to all the gets and puts.
2434         Put together, this is useful to see what property accesses are not getting cached.
2435
2436         * Scripts/ic-stats.py: Added.
2437         (ICStats):
2438         (ICStats.__init__):
2439         (ICStats.parse):
2440         (ICStats.dumpStats):
2441         (usage):
2442
2443 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2444
2445         WKNavigationResponse._downloadAttribute should be nil when no download attribute is present
2446         https://bugs.webkit.org/show_bug.cgi?id=196809
2447         <rdar://49800762>
2448
2449         Reviewed by Brady Eidson.
2450
2451         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2452         (TEST):
2453
2454 2019-04-10  Said Abou-Hallawa  <sabouhallawa@apple.com>
2455
2456         requestAnimationFrame should execute before the next frame
2457         https://bugs.webkit.org/show_bug.cgi?id=177484
2458
2459         Reviewed by Simon Fraser.
2460
2461         Add trace points for the page RenderingUpdate.
2462
2463         * Tracing/SystemTracePoints.plist:
2464
2465 2019-04-10  Fujii Hironori  <Hironori.Fujii@sony.com>
2466
2467         [Win] Use a bundled vswhere.exe instead of downloading by update-vswhere.py
2468         https://bugs.webkit.org/show_bug.cgi?id=196760
2469
2470         Reviewed by Don Olmstead.
2471
2472         vswhere.exe has been bundled since Visual Studio 2017 version
2473         15.2. We shouldn't download vswhere.exe.
2474
2475         * Scripts/build-jsc: Do not call update-vswhere.py.
2476         * Scripts/build-webkit: Ditto.
2477         * Scripts/update-vswhere.py: Removed.
2478         * Scripts/webkitdirs.pm:
2479         (requireModulesForVSWhere): Deleted.
2480         (pickCurrentVisualStudioInstallation): Deleted.
2481         (visualStudioInstallDirVSWhere): Return the latest installed VS
2482         installation path by using the bundled vswhere.exe.
2483         (setupCygwinEnv): Removed a unused variable $visualStudioPath.
2484         (visualStudioInstallDirFallback): Removed.
2485
2486 2019-04-10  Aakash Jain  <aakash_jain@apple.com>
2487
2488         [ews-build] PrintConfiguration should display Xcode version instead of SDKVersion
2489         https://bugs.webkit.org/show_bug.cgi?id=196780
2490
2491         Reviewed by Alexey Proskuryakov.
2492
2493         * BuildSlaveSupport/ews-build/steps.py:
2494         * BuildSlaveSupport/ews-build/steps_unittest.py:
2495
2496 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2497
2498         Add SPI WKNavigationResponse._downloadAttribute
2499         https://bugs.webkit.org/show_bug.cgi?id=196755
2500         <rdar://49587365>
2501
2502         Reviewed by Brady Eidson.
2503
2504         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
2505         (-[NavigationResponseTestDelegate navigationResponse]):
2506         (-[NavigationResponseTestDelegate waitForNavigationResponseCallback]):
2507         (-[NavigationResponseTestDelegate waitForNavigationFinishedCallback]):
2508         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
2509         (-[NavigationResponseTestDelegate webView:didFinishNavigation:]):
2510         (-[NavigationResponseTestDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2511         (readRequest):
2512         (writeResponse):
2513         (TEST):
2514
2515 2019-04-10  Tim Horton  <timothy_horton@apple.com>
2516
2517         Add modern API for overriding the page's specified viewport configuration
2518         https://bugs.webkit.org/show_bug.cgi?id=167734
2519         <rdar://problem/30331795>
2520
2521         Reviewed by Simon Fraser.
2522
2523         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2524         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm: Added.
2525
2526 2019-04-10  Tadeu Zagallo  <tzagallo@apple.com>
2527
2528         Add support for incremental bytecode cache updates
2529         https://bugs.webkit.org/show_bug.cgi?id=195000
2530
2531         Reviewed by Filip Pizlo.
2532
2533         Exit when the initial run to generate bytecode fails.
2534
2535         * Scripts/jsc-stress-test-helpers/bytecode-cache-test-helper.sh:
2536
2537 2019-04-10  Alex Christensen  <achristensen@webkit.org>
2538
2539         RemoteObjectRegistry message receiver should be removed when WebPage::close is called instead of waiting until dealloc
2540         https://bugs.webkit.org/show_bug.cgi?id=196744
2541         <rdar://49415309>
2542
2543         Reviewed by Chris Dumez.
2544
2545         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm:
2546         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2547
2548 2019-04-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2549
2550         Add a way to opt into modern compatibility mode in layout tests
2551         https://bugs.webkit.org/show_bug.cgi?id=196770
2552         <rdar://problem/49777550>
2553
2554         Reviewed by Antoine Quint.
2555
2556         Add a new test option to enable modern compatibility mode in layout tests.
2557
2558         * WebKitTestRunner/TestController.cpp:
2559         (WTR::updateTestOptionsFromTestHeader):
2560         * WebKitTestRunner/TestController.h:
2561         * WebKitTestRunner/TestOptions.h:
2562         (WTR::TestOptions::hasSameInitializationOptions const):
2563         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2564         (WTR::TestController::platformCreateWebView):
2565         (WTR::TestController::enableModernCompatibilityMode):
2566
2567 2019-04-10  Andy Estes  <aestes@apple.com>
2568
2569         Try to fix the 32-bit watchOS build.
2570
2571         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2572         (-[TestWKWebView evaluateJavaScriptAndWaitForInputSessionToChange:]):
2573
2574 2019-04-10  Antoine Quint  <graouts@apple.com>
2575
2576         Enable Pointer Events on watchOS
2577         https://bugs.webkit.org/show_bug.cgi?id=196771
2578         <rdar://problem/49040909>
2579
2580         Reviewed by Dean Jackson.
2581
2582         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2583
2584 2019-04-10  Philippe Normand  <pnormand@igalia.com>
2585
2586         Unreviewed. Fix WPE accessibility tests after r244059.
2587
2588         We are failing to load the injected bundle due to undefined symbol
2589         AccessibilityUIElement::replaceTextInRange().
2590
2591         * WebKitTestRunner/InjectedBundle/wpe/AccessibilityUIElementWPE.cpp:
2592         (WTR::AccessibilityUIElement::replaceTextInRange):
2593
2594 2019-04-10  Takashi Komori  <Takashi.Komori@sony.com>
2595
2596         [WinCairo][MiniBrowser] Pull down menu "Disable JavaScript" doesn't work.
2597         https://bugs.webkit.org/show_bug.cgi?id=196727
2598
2599         Reviewed by Fujii Hironori.
2600
2601         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2602         (WebKitBrowserWindow::create):
2603
2604 2019-04-09  Aakash Jain  <aakash_jain@apple.com>
2605
2606         [ews-build] Add unit tests for PrintConfiguration
2607         https://bugs.webkit.org/show_bug.cgi?id=196752
2608
2609         Reviewed by Dewei Zhu.
2610
2611         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2612
2613 2019-04-09  Keith Rollin  <krollin@apple.com>
2614
2615         Unreviewed build maintenance -- update .xcfilelists.
2616
2617         * DumpRenderTree/DerivedSources-input.xcfilelist:
2618         * DumpRenderTree/DerivedSources-output.xcfilelist:
2619
2620 2019-04-09  Zalan Bujtas  <zalan@apple.com>
2621
2622         [AutoSizing] Avoid making text paragraphs scroll horizontally when there is a wide table
2623         https://bugs.webkit.org/show_bug.cgi?id=196743
2624         <rdar://problem/43897551>
2625
2626         Reviewed by Tim Horton.
2627
2628         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm: expected behavior change.
2629         (TEST):
2630
2631 2019-04-09  Youenn Fablet  <youenn@apple.com>
2632
2633         Close service worker database on network process suspension
2634         https://bugs.webkit.org/show_bug.cgi?id=196623
2635         <rdar://problem/48930869>
2636
2637         Reviewed by Alex Christensen.
2638
2639         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2640
2641 2019-04-09  Daniel Bates  <dabates@apple.com>
2642
2643         [iPad] Should open popover when the spacebar is pressed
2644         https://bugs.webkit.org/show_bug.cgi?id=196360
2645         <rdar://problem/49389129>
2646
2647         Reviewed by Brent Fulgham.
2648
2649         Add testing infrastructure to support waiting for a popover to be presented or dismissed.
2650
2651         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2652         (WTR::UIScriptController::isShowingPopover const): Added.
2653         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2654         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2655         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2656         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2657         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2658         (WTR::UIScriptController::setWillPresentPopoverCallback): Added.
2659         (WTR::UIScriptController::willPresentPopoverCallback const): Added.
2660         (WTR::UIScriptController::setDidDismissPopoverCallback): Added.
2661         (WTR::UIScriptController::didDismissPopoverCallback const): Added.
2662         (WTR::UIScriptController::isShowingPopover const): Added.
2663         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2664         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2665         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2666         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2667         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2668         (-[TestRunnerWKWebView initWithFrame:configuration:]): Update some state.
2669         (-[TestRunnerWKWebView resetInteractionCallbacks]): Ditto.
2670         (-[TestRunnerWKWebView _willPresentPopover]): Added.
2671         (-[TestRunnerWKWebView _didDismissPopover]): Added.
2672         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2673         (WTR::UIScriptController::isShowingPopover const): Added.
2674         (WTR::UIScriptController::platformSetWillPresentPopoverCallback): Added.
2675         (WTR::UIScriptController::platformSetDidDismissPopoverCallback): Added.
2676
2677 2019-04-09  Alex Christensen  <achristensen@webkit.org>
2678
2679         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
2680         https://bugs.webkit.org/show_bug.cgi?id=196665
2681         <rdar://45115669>
2682
2683         Reviewed by Geoff Garen.
2684
2685         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2686         (goBack):
2687         (+[SimpleLookupContext sharedLookupContext]):
2688         (-[SimpleLookupContext lookUpURL:completionHandler:]):
2689         (TEST):
2690         (+[Simple3LookupContext sharedLookupContext]): Deleted.
2691         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
2692
2693 2019-04-09  John Wilander  <wilander@apple.com>
2694
2695         Pick up Ad Click Attribution conversions in NetworkResourceLoader::willSendRedirectedRequest()
2696         https://bugs.webkit.org/show_bug.cgi?id=196558
2697         <rdar://problem/47650245>
2698
2699         Reviewed by Youenn Fablet.
2700
2701         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2702         (TestWebKitAPI::TEST):
2703             Added tests of WebCore::AdClickAttribution::parseConversionRequest().
2704
2705 2019-04-09  Don Olmstead  <don.olmstead@sony.com>
2706
2707         [CMake] Apple builds should use ICU_INCLUDE_DIRS
2708         https://bugs.webkit.org/show_bug.cgi?id=196720
2709
2710         Reviewed by Konstantin Tokarev.
2711
2712         * TestWebKitAPI/PlatformMac.cmake:
2713
2714 2019-04-09  Jonathan Bedard  <jbedard@apple.com>
2715
2716         iOS 12 Simulator Release WK2 frequently timing out while running layout tests
2717         https://bugs.webkit.org/show_bug.cgi?id=196694
2718         <rdar://problem/48388734>
2719
2720         Rubber-stamped by Aakash Jain.
2721
2722         * Scripts/webkitpy/port/image_diff.py:
2723         (ImageDiffer.diff_image): If the ImageDiff process has data, kill it before running again.
2724         * Scripts/webkitpy/port/server_process.py:
2725         (ServerProcess.has_available_stdout): Check if stdout has data in it.
2726         (ServerProcess._wait_for_data_and_update_buffers_using_select):
2727         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
2728         * Scripts/webkitpy/port/server_process_mock.py:
2729         (MockServerProcess.has_available_stdout):
2730         * Scripts/webkitpy/port/server_process_unittest.py:
2731         (TestServerProcess.serial_test_basic):
2732
2733 2019-04-09  Jer Noble  <jer.noble@apple.com>
2734
2735         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
2736         https://bugs.webkit.org/show_bug.cgi?id=196097
2737
2738         Reviewed by Eric Carlson.
2739
2740         Drive-by bug fix: allow tests to play audio without a user gesture by default.
2741
2742         * DumpRenderTree/mac/DumpRenderTree.mm:
2743         (resetWebPreferencesToConsistentValues):
2744         * WebKitTestRunner/TestController.cpp:
2745         (WTR::TestController::resetPreferencesToConsistentValues):
2746
2747 2019-04-09  Pablo Saavedra  <psaavedra@igalia.com>
2748
2749         [JSCOnly] Add an i386 JSCOnly EWS that runs tests
2750         https://bugs.webkit.org/show_bug.cgi?id=196690
2751
2752         Reviewed by Michael Catanzaro.
2753
2754         * QueueStatusServer/config/queues.py:
2755         * Scripts/webkitpy/common/config/ews.json:
2756         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2757         (test_ews_name):
2758
2759 2019-04-09  Chris Dumez  <cdumez@apple.com>
2760
2761         Loads using loadHTMLString() cause flashing when process-swapping
2762         https://bugs.webkit.org/show_bug.cgi?id=196714
2763         <rdar://problem/49637354>
2764
2765         Reviewed by Antti Koivisto.
2766
2767         Add API test coverage.
2768
2769         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2770
2771 2019-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
2772
2773         Unreviewed. Fix ATK accessibility tests after r244059.
2774
2775         We are failing to load the injected bundle due to undefined symbol
2776         AccessibilityUIElement::replaceTextInRange().
2777
2778         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2779         (WTR::AccessibilityUIElement::replaceTextInRange):
2780
2781 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2782
2783         AX: Support API: accessibilityReplaceRange:withText
2784         https://bugs.webkit.org/show_bug.cgi?id=196636
2785
2786         Unreviewed build fix for Windows port.
2787
2788         * WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
2789         (WTR::AccessibilityUIElement::replaceTextInRange): Added.
2790
2791 2019-04-08  Don Olmstead  <don.olmstead@sony.com>
2792
2793         [CMake][WinCairo] Separate copied headers into different directories
2794         https://bugs.webkit.org/show_bug.cgi?id=196655
2795
2796         Reviewed by Michael Catanzaro.
2797
2798         * DumpRenderTree/CMakeLists.txt:
2799         * MiniBrowser/win/CMakeLists.txt:
2800         * TestWebKitAPI/CMakeLists.txt:
2801         * TestWebKitAPI/PlatformWin.cmake:
2802
2803 2019-04-08  Jonathan Bedard  <jbedard@apple.com>
2804
2805         Log stack-trace for run-webkit-tests when interrupted
2806         https://bugs.webkit.org/show_bug.cgi?id=176393
2807         <rdar://problem/34262310>
2808
2809         Reviewed by Lucas Forschler.
2810
2811         * Scripts/webkitpy/common/interrupt_debugging.py: Added.
2812         (log_stack_trace): Given a Python frame object, log a stack trace to the provided file.
2813         (StackTraceFileContext): Context which allows stack-traces to be printed to stderr or to a file. 
2814         (log_stack_trace_on_term): Attach a listener to SIGTERM so that a stack-trace can be logged when a program is terminated.
2815         (log_stack_trace_on_ctrl_c): Attach a listener to SIGINT so that a stack-trace can be logged when a program is CTRL+Ced. 
2816         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2817         (main): Set handlers to log stack trace on interruption.
2818
2819 2019-04-08  Fujii Hironori  <Hironori.Fujii@sony.com>
2820
2821         AX: Support API: accessibilityReplaceRange:withText
2822         https://bugs.webkit.org/show_bug.cgi?id=196636
2823
2824         Unreviewed build fix for Windows port.
2825
2826         * DumpRenderTree/AccessibilityUIElement.cpp:
2827         (AccessibilityUIElement::replaceTextInRange): Changed the return value type from void to bool.
2828
2829 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2830
2831         [ews-build] Scripts using Buildbot API have CORS error
2832         https://bugs.webkit.org/show_bug.cgi?id=196709
2833
2834         Reviewed by Alexey Proskuryakov.
2835
2836         * BuildSlaveSupport/ews-build/master.cfg: Set allowed_origins appropriately.
2837
2838 2019-04-08  Chris Fleizach  <cfleizach@apple.com>
2839
2840         AX: Support API: accessibilityReplaceRange:withText
2841         https://bugs.webkit.org/show_bug.cgi?id=196636
2842
2843         Reviewed by Daniel Bates.
2844
2845         * DumpRenderTree/AccessibilityUIElement.cpp:
2846         (replaceTextInRangeCallback):
2847         (AccessibilityUIElement::replaceTextInRange):
2848         (AccessibilityUIElement::getJSClass):
2849         * DumpRenderTree/AccessibilityUIElement.h:
2850         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2851         (AccessibilityUIElement::replaceTextInRange):
2852         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
2853         (AccessibilityUIElement::replaceTextInRange):
2854         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2855         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2856         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2857         (WTR::AccessibilityUIElement::replaceTextInRange):
2858         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
2859         (WTR::AccessibilityUIElement::replaceTextInRange):
2860
2861 2019-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2862
2863         [iOS] Do not allow starting selection drags when selection views are not visible
2864         https://bugs.webkit.org/show_bug.cgi?id=196686
2865         <rdar://problem/49399192>
2866
2867         Reviewed by Tim Horton.
2868
2869         Adjust some existing API tests to make the web view become first responder before trying to begin dragging, and
2870         also add some new API tests to cover scenarios where the web view is not first responder.
2871
2872         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
2873         (TestWebKitAPI::TEST):
2874         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
2875
2876         Add a switch to optionally make the web view first responder when starting the simulated drag.
2877
2878         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2879         (-[DragAndDropSimulator initWithWebView:]):
2880         (-[DragAndDropSimulator runFrom:to:additionalItemRequestLocations:]):
2881
2882 2019-04-08  Justin Fan  <justin_fan@apple.com>
2883
2884         [Web GPU] Fix Web GPU experimental feature on iOS
2885         https://bugs.webkit.org/show_bug.cgi?id=196632
2886
2887         Reviewed by Myles C. Maxfield.
2888
2889         Properly make Web GPU available on iOS 11+.
2890
2891         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2892
2893 2019-04-08  Aakash Jain  <aakash_jain@apple.com>
2894
2895         [ews-build] Do not upload archive when Compile Fails
2896         https://bugs.webkit.org/show_bug.cgi?id=196674
2897
2898         Reviewed by Alexey Proskuryakov.
2899
2900         * BuildSlaveSupport/ews-build/factories.py:
2901         (BuildFactory.__init__): Remove steps which require dynamic decision about whether to run or not.
2902         * BuildSlaveSupport/ews-build/steps.py:
2903         (CompileWebKit.evaluateCommand): Dynamically decide which steps to run based on compile status.
2904         (CompileWebKitToT.evaluateCommand): Explicitly override Compile.evaluateCommand so that it 
2905         doesn't inherit CompileWebKit.evaluateCommand which dynamically adds more steps.
2906
2907 2019-04-08  Guillaume Emont  <guijemont@igalia.com>
2908
2909         Enable DFG on MIPS
2910         https://bugs.webkit.org/show_bug.cgi?id=196689
2911
2912         Reviewed by Žan Doberšek.
2913
2914         Since the bytecode change, we enabled the baseline JIT on mips in
2915         r240432, but DFG is still missing. With this change, all tests are
2916         passing on a ci20 board.
2917
2918         * Scripts/run-jsc-stress-tests: Enable DFG tests on MIPS.
2919
2920 2019-04-08  Philippe Normand  <pnormand@igalia.com>
2921
2922         [Flatpak] Second run update-webkitwpe-flatpak fails
2923         https://bugs.webkit.org/show_bug.cgi?id=192702
2924
2925         Reviewed by Carlos Garcia Campos.
2926
2927         * flatpak/flatpakutils.py:
2928         (FlatpakObject.flatpak): Fix typo.
2929         (FlatpakPackage.install): When installing, also update to the configured remote commit.
2930         * flatpak/org.webkit.WebKit.yaml: Update GNOME 3.28 SDK/runtime hashes.
2931
2932 2019-04-05  Sergio Villar Senin  <svillar@igalia.com>
2933
2934         [GTK][WPE] outlook.live.com displays old-fashioned UI
2935         https://bugs.webkit.org/show_bug.cgi?id=196642
2936
2937         Reviewed by Carlos Garcia Campos.
2938
2939         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2940         (TestWebKitAPI::TEST): New Mac platform quirk test.
2941
2942 2019-04-07  Commit Queue  <commit-queue@webkit.org>
2943
2944         Unreviewed, rolling out r243956.
2945         https://bugs.webkit.org/show_bug.cgi?id=196688
2946
2947         Broke API Test SafeBrowsing.WKWebViewGoBackIFrame (Requested
2948         by aakashjain on #webkit).
2949
2950         Reverted changeset:
2951
2952         "Clicking "Go Back" from a safe browsing warning from an
2953         iframe should navigate the WKWebView back to the previous
2954         page"
2955         https://bugs.webkit.org/show_bug.cgi?id=196665
2956         https://trac.webkit.org/changeset/243956
2957
2958 2019-04-06  Ryosuke Niwa  <rniwa@webkit.org>
2959
2960         Added tests for WeakHashSet::computesEmpty and WeakHashSet::computeSize
2961         https://bugs.webkit.org/show_bug.cgi?id=196669
2962
2963         Reviewed by Geoffrey Garen.
2964
2965         Added three new unit tests for WeakHashSet.
2966
2967         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
2968         (WTF_WeakPtr.WeakHashSetConstObjects):
2969         (WTF_WeakPtr.WeakHashSetComputesEmpty):
2970         (WTF_WeakPtr.WeakHashSetComputeSize):
2971
2972 2019-04-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2973
2974         Hide next and previous form control buttons when WKWebView is editable
2975         https://bugs.webkit.org/show_bug.cgi?id=196672
2976         <rdar://problem/35625321>
2977
2978         Reviewed by Tim Horton.
2979
2980         Add a new API test.
2981
2982         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2983         (-[TestWKWebView lastTrailingBarButtonGroup]):
2984         (TestWebKitAPI::TEST):
2985         * TestWebKitAPI/ios/UIKitSPI.h:
2986
2987 2019-04-05  Yongjun Zhang  <yongjun_zhang@apple.com>
2988
2989         We should pass minimumEffectiveDeviceWidth to web process on new page creation.
2990         https://bugs.webkit.org/show_bug.cgi?id=196077
2991         <rdar://problem/49108202>
2992
2993         Reviewed by Chris Dumez.
2994
2995         Add an API test to verify the minimumEffectDeviceWidth is passed to web content process
2996         on new web view.
2997
2998         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2999
3000 2019-04-05  Saam Barati  <sbarati@apple.com>
3001
3002         Make compare-results understand MotionMark
3003         https://bugs.webkit.org/show_bug.cgi?id=196666
3004
3005         Reviewed by Yusuke Suzuki.
3006
3007         * Scripts/compare-results:
3008         (PLT5Results):
3009         (detectMotionMark):
3010         (detectMotionMark1_1):
3011         (motionMarkResults):
3012         (motionMark1_1Results):
3013         (detectBenchmark):
3014         (biggerIsBetter):
3015         (main):
3016
3017 2019-04-05  Alex Christensen  <achristensen@webkit.org>
3018
3019         Clicking "Go Back" from a safe browsing warning from an iframe should navigate the WKWebView back to the previous page
3020         https://bugs.webkit.org/show_bug.cgi?id=196665
3021         <rdar://45115669>
3022
3023         Reviewed by Geoff Garen.
3024
3025         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3026         (goBack):
3027         (+[SimpleLookupContext sharedLookupContext]):
3028         (-[SimpleLookupContext lookUpURL:completionHandler:]):
3029         (TEST):
3030         (+[Simple3LookupContext sharedLookupContext]): Deleted.
3031         (-[Simple3LookupContext lookUpURL:completionHandler:]): Deleted.
3032
3033 2019-04-05  Aakash Jain  <aakash_jain@apple.com>
3034
3035         [ews-build] Add configuration and architecture for windows builders
3036         https://bugs.webkit.org/show_bug.cgi?id=196660
3037
3038         Reviewed by Lucas Forschler.
3039
3040         * BuildSlaveSupport/ews-build/config.json:
3041
3042 2019-04-05  Jonathan Bedard  <jbedard@apple.com>
3043
3044         webkitpy: Don't run subsequent rounds if interrupted
3045         https://bugs.webkit.org/show_bug.cgi?id=196646
3046
3047         Reviewed by Aakash Jain.
3048
3049         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3050         (Manager.run): Bail out if interrupted.
3051
3052 2019-04-05  Sihui Liu  <sihui_liu@apple.com>
3053
3054         Test sessionStorage in PSON private browsing mode
3055         https://bugs.webkit.org/show_bug.cgi?id=196561
3056
3057         Reviewed by Alex Christensen.
3058
3059         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3060
3061 2019-04-05  Commit Queue  <commit-queue@webkit.org>
3062
3063         Unreviewed, rolling out r243833.
3064         https://bugs.webkit.org/show_bug.cgi?id=196645
3065
3066         This change breaks build of WPE and GTK ports (Requested by
3067         annulen on #webkit).
3068
3069         Reverted changeset:
3070
3071         "[CMake][WTF] Mirror XCode header directories"
3072         https://bugs.webkit.org/show_bug.cgi?id=191662
3073         https://trac.webkit.org/changeset/243833
3074
3075 2019-04-04  Simon Fraser  <simon.fraser@apple.com>
3076
3077         Simple iframe scrolling test fails to get a composited scrolling frame in WebKitTestRunnerApp
3078         https://bugs.webkit.org/show_bug.cgi?id=196635
3079
3080         Reviewed by Antti Koivisto.
3081         
3082         InjectedBundle::beginTesting() calling WKBundleSetAsyncFrameScrollingEnabled() makes it impossible
3083         for a test to enable async frame scrolling via:
3084             <!-- webkit-test-runner [ internal:AsyncFrameScrollingEnabled=true ] -->
3085         so remove it and have TestController::resetPreferencesToConsistentValues() set the default value.
3086         
3087         Test: scrollingcoordinator/ios/programmatic-frame-scroll.html
3088
3089         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3090         (WTR::InjectedBundle::beginTesting):
3091         * WebKitTestRunner/TestController.cpp:
3092         (WTR::TestController::resetPreferencesToConsistentValues):
3093
3094 2019-04-04  Alexey Proskuryakov  <ap@apple.com>
3095
3096         Use a correct LC_RPATH when building with ASan
3097         https://bugs.webkit.org/show_bug.cgi?id=196576
3098
3099         Reviewed by David Kilzer.
3100
3101         * asan/asan.xcconfig: As a temporary hack, just force LC_RPATH on all binaries,
3102         so that ../Frameworks is checked. This is simpler and more reliable than updating
3103         each SPC service xcconfig.
3104
3105 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3106
3107         Disable Flaky API Test TestWebKitAPI.WebKit.FocusTextInputContext
3108         https://bugs.webkit.org/show_bug.cgi?id=196629
3109
3110         Reviewed by Lucas Forschler.
3111
3112         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
3113
3114 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3115
3116         [ews-app] while waiting in queue status-bubble for testers queues should display build information from builder queue
3117         https://bugs.webkit.org/show_bug.cgi?id=196618
3118
3119         Reviewed by Lucas Forschler.
3120
3121         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3122         (StatusBubble): Added QUEUE_TRIGGERS.
3123         (StatusBubble._build_bubble): Get the build from builder if tester has not started the build yet.
3124         (StatusBubble._get_parent_queue): Get the name of the parent (builder) queue.
3125         (StatusBubble.get_latest_build_for_queue): If the queue doesn't have any build yet, return build information from
3126         its parent(builder).
3127
3128 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3129
3130         [ews-app] Status-bubble steps are sometimes displayed in reverse order
3131         https://bugs.webkit.org/show_bug.cgi?id=196625
3132
3133         Reviewed by Lucas Forschler.
3134
3135         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3136         (StatusBubble._steps_messages): Explicitly specify order_by('uid').
3137
3138 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3139
3140         Disable Flaky API Test TestWebKitAPI.KeyboardInputTests.KeyboardTypeForInput
3141         https://bugs.webkit.org/show_bug.cgi?id=196630
3142
3143         Reviewed by Wenson Hsieh.
3144
3145         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
3146
3147 2019-04-04  Youenn Fablet  <youenn@apple.com>
3148
3149         Pass storage quota parameters from UIProcess to NetworkProcess as part of WebsiteDataStore parameters
3150         https://bugs.webkit.org/show_bug.cgi?id=196543
3151
3152         Reviewed by Alex Christensen.
3153
3154         * WebKitTestRunner/TestController.cpp:
3155         (WTR::TestController::generatePageConfiguration):
3156
3157 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3158
3159         [ews-app] Status bubble should not display skipped buildbot steps
3160         https://bugs.webkit.org/show_bug.cgi?id=196584
3161
3162         Reviewed by Lucas Forschler.
3163
3164         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3165
3166 2019-04-04  Aakash Jain  <aakash_jain@apple.com>
3167
3168         [ews-app] configure localhost as BUILDBOT_SERVER_HOST in testing mode
3169         https://bugs.webkit.org/show_bug.cgi?id=196620
3170
3171         Reviewed by Lucas Forschler.
3172
3173         * BuildSlaveSupport/ews-app/ews/config.py:
3174
3175 2019-04-04  Per Arne Vollan  <pvollan@apple.com>
3176
3177         [Win] DumpRenderTreeWatchDog.py is not checked into source
3178         https://bugs.webkit.org/show_bug.cgi?id=196567
3179         <rdar://problem/49525901>
3180
3181         Reviewed by Lucas Forschler.
3182
3183         This script is used on Win EWS bots to terminate hanging DRT processes.
3184
3185         * EWSTools/dumprendertreewatchdog.py: Added.
3186
3187 2019-04-04  Chris Dumez  <cdumez@apple.com>
3188
3189         Unreviewed, roll out r243858 which made tests time out.
3190
3191         Disable new API tests on Windows instead.
3192
3193         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3194         (TestWebKitAPI::TEST):
3195
3196 2019-04-03  Carlos Garcia Campos  <cgarcia@igalia.com>
3197
3198         [ATK] Cleanup WebPageAccessibilityObjectAtk
3199         https://bugs.webkit.org/show_bug.cgi?id=196537
3200
3201         Reviewed by Michael Catanzaro.
3202
3203         Also consider files under atk directories as exceptions for GObject conventions.
3204
3205         * Scripts/webkitpy/style/checkers/cpp.py:
3206         (check_identifier_name_in_declaration):
3207
3208 2019-04-03  Fujii Hironori  <Hironori.Fujii@sony.com>
3209
3210         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3211         https://bugs.webkit.org/show_bug.cgi?id=196588
3212         <rdar://problem/49365787>
3213
3214         Unreviewed build fix for Windows port.
3215
3216         error C3861: 'kill': identifier not found
3217
3218         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3219         (TestWebKitAPI::TEST): Replaced kill with WKPageTerminate.
3220
3221 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3222
3223         [ews-build] Cancel build and similar operations should have authentication
3224         https://bugs.webkit.org/show_bug.cgi?id=196520
3225
3226         Reviewed by Dewei Zhu.
3227
3228         * BuildSlaveSupport/ews-build/master.cfg: Configure authentication using admin's username and password from
3229         environment variables.
3230
3231 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3232
3233         [ews-build] Do not trigger queues which are not in production yet
3234         https://bugs.webkit.org/show_bug.cgi?id=196581
3235
3236         Reviewed by Dewei Zhu.
3237
3238         * BuildSlaveSupport/ews-build/config.json:
3239
3240 2019-04-03  Chris Dumez  <cdumez@apple.com>
3241
3242         Unreviewed, fix typo in the name of API test added in r243848.
3243
3244         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3245         (TestWebKitAPI::TEST):
3246
3247 2019-04-03  Chris Dumez  <cdumez@apple.com>
3248
3249         The page's focusedFrame / frameSetLargestFrame do not get cleared on process swap or crash
3250         https://bugs.webkit.org/show_bug.cgi?id=196588
3251         <rdar://problem/49365787>
3252
3253         Reviewed by Ryosuke Niwa.
3254
3255         Add API test coverage.
3256
3257         * TestWebKitAPI/Tests/WebKit/ReloadPageAfterCrash.cpp:
3258         (TestWebKitAPI::nullJavaScriptCallback):
3259         (TestWebKitAPI::didCrashCheckFrames):
3260         (TestWebKitAPI::TEST):
3261
3262 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3263
3264         run-webkit-tests: Upload test results (new results database)
3265         https://bugs.webkit.org/show_bug.cgi?id=196577
3266         <rdar://problem/34841155>
3267
3268         Reviewed by Lucas Forschler.
3269
3270         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3271         (Manager.run): Upload results after each device shard, since the configuration will be
3272         different for each device.
3273         (Manager._results_to_upload_json_trie): Convert a TestRunResults object to a trie to be
3274         uploaded to a results database.
3275         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3276         (parse_args): Add new 'Upload Options' and prepare 'Results JSON Options' for deprecation.
3277
3278 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3279
3280         -apple-trailing-word is needed for browser detection
3281         https://bugs.webkit.org/show_bug.cgi?id=196575
3282
3283         Unreviewed.
3284
3285         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3286
3287 2019-04-03  Don Olmstead  <don.olmstead@sony.com>
3288
3289         [CMake][WTF] Mirror XCode header directories
3290         https://bugs.webkit.org/show_bug.cgi?id=191662
3291
3292         Reviewed by Konstantin Tokarev.
3293
3294         Use WTFFramework as a dependency and include frameworks/WTF.cmake for AppleWin internal
3295         builds.
3296
3297         * CMakeLists.txt:
3298         * DumpRenderTree/CMakeLists.txt:
3299         * DumpRenderTree/PlatformWin.cmake:
3300         * MiniBrowser/win/CMakeLists.txt:
3301         * TestWebKitAPI/CMakeLists.txt:
3302         * TestWebKitAPI/PlatformWin.cmake:
3303         * WebKitTestRunner/PlatformGTK.cmake:
3304         * WebKitTestRunner/PlatformWin.cmake:
3305
3306 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3307
3308         [ews-app] Status bubble should not display certain infrastructure status messages
3309         https://bugs.webkit.org/show_bug.cgi?id=196550
3310
3311         Reviewed by Lucas Forschler.
3312
3313         Do not display the steps which are un-needed for end-user. This information is still avaiable
3314         if the user click on the bubble and look at the Buildbot build.
3315         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3316         (StatusBubble._steps_messages):
3317         (StatusBubble._should_display_step): Method to decide whether to display the step or not.
3318
3319 2019-04-03  Aakash Jain  <aakash_jain@apple.com>
3320
3321         [ews-build] Use https for sending data to ews-app
3322         https://bugs.webkit.org/show_bug.cgi?id=196492
3323
3324         Reviewed by Lucas Forschler.
3325
3326         * BuildSlaveSupport/ews-build/events.py:
3327
3328 2019-04-03  Myles C. Maxfield  <mmaxfield@apple.com>
3329
3330         Remove support for -apple-trailing-word
3331         https://bugs.webkit.org/show_bug.cgi?id=196525
3332
3333         Reviewed by Zalan Bujtas.
3334
3335         This CSS property is nonstandard and not used.
3336
3337         * Scripts/webkitperl/FeatureList.pm:
3338         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3339
3340 2019-04-03  Youenn Fablet  <youenn@apple.com>
3341
3342         Add a test for DOMCache on multiple browsing in case of private browsing
3343         https://bugs.webkit.org/show_bug.cgi?id=196524
3344
3345         Reviewed by Alex Christensen.
3346
3347         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3348         (-[SWMessageHandlerForCacheStorage userContentController:didReceiveScriptMessage:]):
3349
3350 2019-04-03  Jonathan Bedard  <jbedard@apple.com>
3351
3352         [ews] Clean out ~/Library/Logs/CoreSimulator/ on reboot
3353         https://bugs.webkit.org/show_bug.cgi?id=196540
3354
3355         Reviewed by Aakash Jain.
3356
3357         * EWSTools/start-queue-mac.sh: Remove CoreSimulator logs.
3358
3359 2019-04-03  Wenson Hsieh  <wenson_hsieh@apple.com>
3360
3361         Add plumbing for a compatibility mode preference in WebKit
3362         https://bugs.webkit.org/show_bug.cgi?id=196005
3363
3364         Reviewed by Tim Horton.
3365
3366         Add new API tests.
3367
3368         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3369         * TestWebKitAPI/ios/PreferredCompatibilityMode.mm: Added.
3370
3371 2019-04-03  Claudio Saavedra  <csaavedra@igalia.com>
3372
3373         [WPE][GTK] Update libsrtp dependency package for Debian
3374         https://bugs.webkit.org/show_bug.cgi?id=196528
3375
3376         Reviewed by Frédéric Wang.
3377
3378         * gtk/install-dependencies:
3379         * wpe/install-dependencies:
3380
3381 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3382
3383         [WK2] Add support for Window's beforeprint / afterprint events
3384         https://bugs.webkit.org/show_bug.cgi?id=196478
3385         <rdar://problem/49535124>
3386
3387         Unreviewed build fix for MSVC.
3388
3389         > WebKitTestRunner\TestController.cpp(267): error C2397: conversion from 'double' to 'float' requires a narrowing conversion
3390
3391         And, there is a style guideline. <https://webkit.org/code-style-guidelines/#floating-point-literals>
3392
3393         * WebKitTestRunner/TestController.cpp:
3394         (WTR::printFrame): Use int and float literals.
3395
3396 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3397
3398         [ews-build] Reassign bots to queues
3399
3400         * BuildSlaveSupport/ews-build/config.json: Reassigned ews150 and ews152.
3401
3402 2019-04-02  Chris Dumez  <cdumez@apple.com>
3403
3404         [WK2] Add support for Window's beforeprint / afterprint events
3405         https://bugs.webkit.org/show_bug.cgi?id=196478
3406
3407         Reviewed by Alex Christensen.
3408
3409         Add minimal implementation for printFrame in WebKitTestRunner.
3410
3411         * WebKitTestRunner/TestController.cpp:
3412         (WTR::printFrame):
3413         (WTR::TestController::createOtherPage):
3414         (WTR::TestController::createWebViewWithOptions):
3415
3416 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3417
3418         [ews-app] Status bubble hover over message should clearly indicate that build is in-progress
3419         https://bugs.webkit.org/show_bug.cgi?id=196491
3420
3421         Reviewed by Lucas Forschler.
3422
3423         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3424
3425 2019-04-02  Aakash Jain  <aakash_jain@apple.com>
3426
3427         [ews-build] Configure buildbot try credentials in environment variables
3428         https://bugs.webkit.org/show_bug.cgi?id=196501
3429
3430         Reviewed by Lucas Forschler.
3431
3432         * BuildSlaveSupport/ews-build/loadConfig.py: Read credentials from environment variables.
3433         * BuildSlaveSupport/ews-app/ews/common/buildbot.py: Rename BUILDBOT_PB_USERNAME to BUILDBOT_TRY_USERNAME.
3434         * BuildSlaveSupport/ews-app/ews/config.py: Ditto.
3435
3436 2019-04-02  Wenson Hsieh  <wenson_hsieh@apple.com>
3437
3438         REGRESSION (r243726): Crash at unrecognized selector: -[WKWebpagePreferences webpagePreferences]
3439         https://bugs.webkit.org/show_bug.cgi?id=196496
3440         <rdar://problem/49521634>
3441
3442         Reviewed by Chris Dumez.
3443
3444         Add new API tests (see WebKit ChangeLog for more detail).
3445
3446         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3447         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3448         (TEST):
3449
3450 2019-04-02  David Kilzer  <ddkilzer@apple.com>
3451
3452         Rename CLANG_ADDRESS_SANITIZER Xcode variable to ENABLE_ADDRESS_SANITIZER
3453         <https://webkit.org/b/196499>
3454
3455         Reviewed by Alexey Proskuryakov.
3456
3457         * asan/asan.xcconfig: Change CLANG_ADDRESS_SANITIZER to
3458         ENABLE_ADDRESS_SANITIZER.
3459
3460 2019-04-02  Fujii Hironori  <Hironori.Fujii@sony.com>
3461
3462         [CMake] WEBKIT_MAKE_FORWARDING_HEADERS shouldn't use POST_BUILD to copy generated headers
3463         https://bugs.webkit.org/show_bug.cgi?id=182757
3464
3465         Reviewed by Don Olmstead.
3466
3467         * TestWebKitAPI/PlatformGTK.cmake: Removed the workaround of using an intermediate target.
3468         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
3469
3470 2019-04-01  Jonathan Bedard  <jbedard@apple.com>
3471
3472         run-api-tests: Upload test results
3473         https://bugs.webkit.org/show_bug.cgi?id=196323
3474         <rdar://problem/49356714>
3475
3476         Reviewed by Lucas Forschler.
3477
3478         * Scripts/webkitpy/api_tests/manager.py:
3479         (Manager):
3480         (Manager.run): Upload results to a results database.
3481         * Scripts/webkitpy/api_tests/run_api_tests.py:
3482         (parse_args): Add upload arguments.
3483         * Scripts/webkitpy/port/base.py:
3484         (Port):
3485         (Port.configuration_for_upload): Creates a configuration dictionary for uploading results.
3486         (Port.commits_for_upload): Create a list of commits from the WebKit repository tests are run from along
3487         with commits from any other associated repositories.
3488         * Scripts/webkitpy/port/device.py:
3489         (Device):
3490         (Device.build_version): Access build_versoin of underlying platform device.
3491         * Scripts/webkitpy/port/ios_simulator_unittest.py:
3492         (IOSSimulatorTest):
3493         (IOSSimulatorTest.test_configuration_for_upload):
3494         * Scripts/webkitpy/port/device_port.py:
3495         (DevicePort):
3496         (DevicePort.configuration_for_upload): Devices are unique because their configuration is not
3497         the same as the machine uploading results.
3498         * Scripts/webkitpy/port/mac.py:
3499         (MacPort):
3500         (MacPort.configuration_for_upload): Define SDK in upload configuration for Mac.
3501         * Scripts/webkitpy/port/mac_unittest.py:
3502         (MacTest):
3503         (MacTest.test_configuration_for_upload):
3504         * Scripts/webkitpy/xcode/simulated_device.py:
3505         (SimulatedDeviceManager._create_device_with_runtime):
3506         (SimulatedDevice.__init__): Create simulated device with a build_version.
3507         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3508         (test_existing_simulator):
3509
3510 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3511
3512         Remove extra newline characters (Follow-up fix to r243707)
3513
3514         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3515
3516 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3517
3518         [ews-app] Use API_KEY to accept results data
3519         https://bugs.webkit.org/show_bug.cgi?id=196461
3520
3521         Reviewed by Dewei Zhu.
3522
3523         * BuildSlaveSupport/ews-app/ews/views/results.py:
3524         (Results.post): Validate EWS_API_KEY before accepting any data.
3525         * BuildSlaveSupport/ews-build/events.py:
3526         (Events.sendData): Send EWS_API_KEY if available along with event data.
3527
3528 2019-04-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3529
3530         Unable to copy and paste a PDF from Notes into Mail compose body
3531         https://bugs.webkit.org/show_bug.cgi?id=196442
3532         <rdar://problem/48573098>
3533
3534         Reviewed by Tim Horton.
3535
3536         Add new API tests to exercise pasting CNContact and MKMapItem-backed item providers. Additionally, adjust an
3537         existing test that pastes a PDF file as an attachment to not require UIPreferredPresentationStyleAttachment
3538         to be specified on the item providers.
3539
3540         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
3541         (TestWebKitAPI::mapItemForTesting):
3542         (TestWebKitAPI::contactItemForTesting):
3543
3544 2019-04-01  Tim Horton  <timothy_horton@apple.com>
3545
3546         Make UIWKDocumentContext rects per-character instead of per-word
3547         https://bugs.webkit.org/show_bug.cgi?id=196459
3548
3549         Reviewed by Wenson Hsieh.
3550
3551         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
3552         (TEST):
3553         Adjust test results due to switching to per-character rects.
3554
3555 2019-04-01  Chris Dumez  <cdumez@apple.com>
3556
3557         UIProcess crash when a prewarmed process is terminated
3558         https://bugs.webkit.org/show_bug.cgi?id=196451
3559         <rdar://problem/49245471>
3560
3561         Reviewed by Geoffrey Garen.
3562
3563         Add API test coverage.
3564
3565         * TestWebKitAPI/Tests/WebKitCocoa/ProcessPreWarming.mm:
3566         (TEST):
3567
3568 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3569
3570         [ews-app] Display OS and Xcode configuration in status-bubble's hover-over message
3571         https://bugs.webkit.org/show_bug.cgi?id=196449
3572
3573         Reviewed by Lucas Forschler.
3574
3575         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3576         (StatusBubble.get_os_details): Method to get OS and Xcode details.
3577         (StatusBubble._build_bubble): Moved the timestamp logic to common method.
3578         (StatusBubble.get_build_timestamp): Method to get the timestamp to display for the build.
3579
3580 2019-04-01  Aakash Jain  <aakash_jain@apple.com>
3581
3582         [ews-build] Remove force schedulers from OpenSource EWS Buildbot
3583         https://bugs.webkit.org/show_bug.cgi?id=196444
3584
3585         Reviewed by Lucas Forschler.
3586
3587         * BuildSlaveSupport/ews-build/loadConfig.py: Remove ForceSchedulers.
3588
3589 2019-04-01  Alex Christensen  <achristensen@webkit.org>
3590
3591         Add SPI to canonicalize NSURLs with WTF::URL
3592         https://bugs.webkit.org/show_bug.cgi?id=196415
3593         <rdar://problem/44980271>
3594
3595         Reviewed by Darin Adler.
3596
3597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3598         * TestWebKitAPI/Tests/WebKitLegacy/mac/URLCanonicalization.mm: Added.
3599         (TestWebKitAPI::TEST):
3600
3601 2019-04-01  Zan Dobersek  <zdobersek@igalia.com>
3602
3603         [WPE] EventSenderProxy constructor is called before a PlatformWindow is usable
3604         https://bugs.webkit.org/show_bug.cgi?id=196441
3605
3606         Reviewed by Carlos Garcia Campos.
3607
3608         Don't cache the wpe_view_backend object that might not exist yet at the
3609         time of EventSenderProxy constructor invocation, but instead retrieve
3610         that object whenever it's required for event dispatching. This should
3611         avoid crashes in this constructor now that it's invoked before any
3612         PlatformWindow has been set up (as changed in r243496).
3613
3614         * WebKitTestRunner/EventSenderProxy.h:
3615         * WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
3616         (WTR::viewBackend):
3617         (WTR::EventSenderProxy::EventSenderProxy):
3618         (WTR::EventSenderProxy::mouseDown):
3619         (WTR::EventSenderProxy::mouseUp):
3620         (WTR::EventSenderProxy::mouseMoveTo):
3621         (WTR::EventSenderProxy::mouseScrollBy):
3622         (WTR::EventSenderProxy::keyDown):
3623         (WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
3624
3625 2019-03-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3626
3627         [Win][WebKit] MiniBrowser should support high DPI display
3628         https://bugs.webkit.org/show_bug.cgi?id=196391
3629
3630         Reviewed by Alex Christensen.
3631
3632         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3633         (WebKitBrowserWindow::WebKitBrowserWindow): Call resetZoom to set the page zoom factor.
3634         (WebKitBrowserWindow::resetZoom): Changed the default page zoom factor from 1 to the device scale factor.
3635         * MiniBrowser/win/stdafx.h: Define WEBCORE_EXPORT.
3636
3637 2019-03-31  Sam Weinig  <weinig@apple.com>
3638
3639         Remove more i386 specific configurations
3640         https://bugs.webkit.org/show_bug.cgi?id=196430
3641
3642         Reviewed by Alexey Proskuryakov.
3643
3644         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3645         ENABLE_WEB_AUTHN_macosx and ENABLE_WEB_RTC_macosx can now be enabled unconditionally on macOS.
3646
3647 2019-03-31  Andy Estes  <aestes@apple.com>
3648
3649         [iOS] WebKit should consult the navigation response policy delegate before previewing a QuickLook document
3650         https://bugs.webkit.org/show_bug.cgi?id=196433
3651         <rdar://problem/49293305>
3652
3653         Reviewed by Tim Horton.
3654
3655         Enhanced API test coverage to include all navigation response policy decisions in both
3656         linked-before and linked-on-or-after modes. Also added new expectations for all tests.
3657
3658         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3659         * TestWebKitAPI/Tests/WebCore/ios/PreviewConverter.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp.
3660         (TestWebKitAPI::TEST):
3661         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm:
3662         (readFile):
3663         (-[QuickLookDelegate initWithExpectedFileURL:responsePolicy:]):
3664         (-[QuickLookDelegate initWithExpectedFileURL:previewMIMEType:responsePolicy:]):
3665         (-[QuickLookDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3666         (-[QuickLookDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
3667         (-[QuickLookDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
3668         (-[QuickLookDelegate webView:didFailProvisionalNavigation:withError:]):
3669         (-[QuickLookDelegate _webViewWebProcessDidCrash:]):
3670         (-[QuickLookDelegate _downloadDidStart:]):
3671         (-[QuickLookDelegate _download:didReceiveResponse:]):
3672         (-[QuickLookDelegate _download:didReceiveData:]):
3673         (-[QuickLookDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3674         (-[QuickLookDelegate _downloadDidFinish:]):
3675         (-[QuickLookDelegate _download:didFailWithError:]):
3676         (-[QuickLookDelegate _downloadDidCancel:]):
3677         (-[QuickLookDelegate verifyDownload]):
3678         (runTest):
3679         (runTestDecideBeforeLoading):
3680         (runTestDecideAfterLoading):
3681         (TEST):
3682         (-[QuickLookAsyncDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3683         (-[QuickLookPasswordDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
3684         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
3685         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3686         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3687         (-[QuickLookNavigationDelegate webView:didFinishNavigation:]): Deleted.
3688         (-[QuickLookAsyncNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3689         (-[QuickLookAsyncNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]): Deleted.
3690         (-[QuickLookAsyncNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]): Deleted.
3691         (-[QuickLookAsyncNavigationDelegate webView:didFinishNavigation:]): Deleted.
3692         (-[QuickLookDecidePolicyDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]): Deleted.
3693         (-[QuickLookDecidePolicyDelegate webView:didFailProvisionalNavigation:withError:]): Deleted.
3694         (-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]): Deleted.
3695         (-[QuickLookPasswordNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]): Deleted.
3696
3697 2019-03-30  Dominik Infuehr  <dinfuehr@igalia.com>
3698
3699         [CMake] add testdfg as target with build-jsc
3700         https://bugs.webkit.org/show_bug.cgi?id=196393
3701
3702         Reviewed by Saam Barati.
3703
3704         Added testdfg as one of the targets to build when
3705         using CMake.
3706
3707         * Scripts/build-jsc:
3708
3709 2019-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
3710
3711         Delete WebMetal implementation in favor of WebGPU
3712         https://bugs.webkit.org/show_bug.cgi?id=195418
3713
3714         Reviewed by Dean Jackson.
3715
3716         * DumpRenderTree/mac/DumpRenderTree.mm:
3717         (enableExperimentalFeatures):
3718         (resetWebPreferencesToConsistentValues):
3719         * Scripts/webkitperl/FeatureList.pm:
3720         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3721         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3722         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Removed.
3723         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyBuffer.mm: Removed.
3724         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyCommandQueue.mm: Removed.
3725         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyDevice.mm: Removed.
3726         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyFunction.mm: Removed.
3727         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyLibrary.mm: Removed.
3728         * TestWebKitAPI/Tests/WebCore/mac/GPULegacyTest.h: Removed.
3729         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3730         (WTR::InjectedBundle::beginTesting):
3731         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3732         (WTR::TestRunner::setWebMetalEnabled): Deleted.
3733         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3734
3735 2019-03-29  Chris Dumez  <cdumez@apple.com>
3736
3737         REGRESSION (r243523): Six form-related watchOS layout tests are timing out
3738         https://bugs.webkit.org/show_bug.cgi?id=196405
3739         <rdar://problem/49428130>
3740
3741         Reviewed by Wenson Hsieh.
3742
3743         Add a shouldPresentPopovers=false WebKitTestRunner option to cause WKTR to swizzle
3744         the popover presentation methods to be no-ops. Use this in the new test added in
3745         r243523 so that we do not swizzle those methods for all tests. This is needed because
3746         those WatchOS tests rely on the popover getting presented and interactive.
3747
3748         * WebKitTestRunner/TestController.cpp:
3749         (WTR::updateTestOptionsFromTestHeader):
3750         * WebKitTestRunner/TestController.h:
3751         * WebKitTestRunner/TestOptions.h:
3752         (WTR::TestOptions::hasSameInitializationOptions const):
3753         * WebKitTestRunner/ios/TestControllerIOS.mm:
3754         (WTR::TestController::platformInitialize):
3755         (WTR::TestController::platformResetStateToConsistentValues):
3756
3757 2019-03-29  Takashi Komori  <Takashi.Komori@sony.com>
3758
3759         [Curl] Add Server Trust Evaluation Support.
3760         https://bugs.webkit.org/show_bug.cgi?id=191646
3761
3762         Reviewed by Fujii Hironori.
3763
3764         Implemented MiniBrowser UI for asking if user trusts the server.
3765
3766         * MiniBrowser/win/Common.cpp:
3767         (askServerTrustEvaluation):
3768         (replaceString):
3769         * MiniBrowser/win/Common.h:
3770         * MiniBrowser/win/MiniBrowserLib.rc:
3771         * MiniBrowser/win/MiniBrowserLibResource.h:
3772         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3773         (createPEMString):
3774         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
3775         (WebKitBrowserWindow::canTrustServerCertificate):
3776         * MiniBrowser/win/WebKitBrowserWindow.h:
3777
3778 2019-03-29  Cathie Chen  <cathiechen@igalia.com>
3779
3780         Implement ResizeObserver.
3781         https://bugs.webkit.org/show_bug.cgi?id=157743
3782
3783         Reviewed by Simon Fraser.
3784
3785         Support resizeObserverEnabled webPreferences.
3786
3787         * DumpRenderTree/TestOptions.cpp:
3788         (TestOptions::TestOptions):
3789         * DumpRenderTree/TestOptions.h:
3790         * DumpRenderTree/mac/DumpRenderTree.mm:
3791         (setWebPreferencesForTestOptions):
3792         * DumpRenderTree/win/DumpRenderTree.cpp:
3793         (enableExperimentalFeatures):
3794         * Scripts/webkitperl/FeatureList.pm:
3795         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3796
3797 2019-03-28  John Wilander  <wilander@apple.com>
3798
3799         Resource Load Statistics: IPC to the WebsiteDataStore in the UI process from NetworkProcess::deleteWebsiteDataForRegistrableDomains()
3800         https://bugs.webkit.org/show_bug.cgi?id=196281
3801         <rdar://problem/48938748>
3802
3803         Reviewed by Alex Christensen.
3804
3805         This patch adds the function isStatisticsHasLocalStorage() to the
3806         TestRunner. With it, the page can query the WebsiteDataStore in the
3807         UI process to make sure that it sees LocalStorage.
3808
3809         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3810         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3811         (WTR::TestRunner::isStatisticsHasLocalStorage):
3812         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3813         * WebKitTestRunner/TestController.cpp:
3814         (WTR::TestController::isStatisticsHasLocalStorage):
3815         * WebKitTestRunner/TestController.h:
3816         * WebKitTestRunner/TestInvocation.cpp:
3817         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3818
3819 2019-03-28  Jiewen Tan  <jiewen_tan@apple.com>
3820
3821         API::Data::createWithoutCopying should do a null check before calling CFRelease
3822         https://bugs.webkit.org/show_bug.cgi?id=196276
3823         <rdar://problem/48059859>
3824
3825         Reviewed by Alex Christensen.
3826
3827         Add an API test that will pass a nil to API::Data::createWithoutCopying via NavigationState::NavigationClient::webCryptoMasterKey.
3828
3829         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3830         * TestWebKitAPI/Tests/WebKit/navigation-client-default-crypto.html:
3831         * TestWebKitAPI/Tests/WebKitCocoa/WebCryptoMasterKey.mm: Added.
3832         (-[WebCryptoMasterKeyNavigationDelegate _webCryptoMasterKeyForWebView:]):
3833         (-[WebCryptoMasterKeyNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3834         (TestWebKitAPI::TEST):
3835
3836 2019-03-28  Michael Catanzaro  <mcatanzaro@igalia.com>
3837
3838         [WPE][GTK] webkit_web_resource_get_data_finish can return NULL without setting error
3839         https://bugs.webkit.org/show_bug.cgi?id=186276
3840
3841         Reviewed by Carlos Garcia Campos.
3842
3843         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
3844         (webViewLoadChanged):
3845         (testWebResourceGetDataError):
3846         (testWebResourceGetDataEmpty):
3847         (beforeAll):
3848         (webViewloadChanged): Deleted.
3849
3850 2019-03-27  Andy Estes  <aestes@apple.com>
3851
3852         REGRESSION (r242686): package-root creates roots with broken symlinks in WebKit.framework/XPCServices/
3853         https://bugs.webkit.org/show_bug.cgi?id=196317
3854
3855         Reviewed by Dan Bernstein.
3856
3857         package-root copies built products into a staging directory using ditto(1), which does not
3858         follow symbolic links as it traverses a directory. Now that the files in
3859         WebKit.framework/XPCServices/ are symbolic links to a location outside of the framework
3860         itself, these become broken links when ditto'd into the staging directory.
3861
3862         To account for this, change package-root to copy using cp(1) in a mode that follows symlinks.
3863
3864         * Scripts/package-root:
3865
3866 2019-03-27  Aakash Jain  <aakash_jain@apple.com>
3867
3868         [ews-app] Update display text of Submit for ews analysis
3869         https://bugs.webkit.org/show_bug.cgi?id=196309
3870
3871         Reviewed by Dewei Zhu.
3872
3873         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html:
3874
3875 2019-03-27  David Kilzer  <ddkilzer@apple.com>
3876
3877         run-webkit-tests should check for leaks in WebKit processes
3878         <https://webkit.org/b/193772>
3879         <rdar://problem/46526680>
3880
3881         Reviewed by Ryosuke Niwa.
3882
3883         This works by doing the following:
3884         - Add a "#LIST CHILD PROCESSES" command to WebKitTestRunnner.
3885           The list of child processes are returned one per line:
3886           process.name: pid
3887         - Run the "#LIST CHILD PROCESSES" command just before the
3888           "#CHECK FOR WORLD LEAKS" command, and store the list of child
3889           processes on the ServerProcess object.
3890         - When the `--leaks` switch is handled, run check_for_leaks() on
3891           each child process after the main test harness.
3892
3893         * DumpRenderTree/mac/DumpRenderTree.mm:
3894         (handleControlCommand):
3895         - Use strncmp() instead of strcmp().
3896         - Add support for handling "#LIST CHILD PROCESSES" command.
3897
3898         * Scripts/webkitpy/port/base.py:
3899         (Port.check_for_leaks):
3900         * Scripts/webkitpy/port/darwin.py:
3901         (DarwinPort.check_for_leaks):
3902         - Rename redundant 'process_pid' argument to 'process_id'.
3903
3904         * Scripts/webkitpy/port/driver.py:
3905         (Driver.do_post_tests_work):
3906         - Restructure the logic since "#CHECK FOR WORLD LEAKS" is no
3907           longer the only command this sends to WebKitTestRunner.
3908         - If the `--leaks` switch is present, send the
3909           "#LIST CHILD PROCESSES" to WebKitTestRunner and store the
3910           result using Port.set_webkit_processes().
3911         (Driver._parse_child_processes_output):
3912         - Add helper method to parse list of child process names and
3913           process IDs returned from WebKitTestRunner.
3914
3915         * Scripts/webkitpy/port/ios_device.py:
3916         (IOSDevicePort.check_for_leaks):
3917         - Rename redundant 'process_pid' argument to 'process_id'.
3918
3919         * Scripts/webkitpy/port/leakdetector.py:
3920         (LeakDetector._parse_leaks_output):
3921         - Return early if there is no leaks_output.
3922         (LeakDetector.check_for_leaks):
3923         - Rename redundant 'process_pid' argument to 'process_id'.
3924
3925         * Scripts/webkitpy/port/server_process.py:
3926         (ServerProcess.__init__):
3927         (ServerProcess.child_processes):
3928         (ServerProcess.set_child_processes):
3929         - Add instance variable to Port to store list of child process
3930           names and process IDs returned from WebKitTestRunner.
3931         (ServerProcess._start):
3932         - Clear self._child_processes.
3933         (ServerProcess.stop):
3934         - If self._child_processes is set, call
3935           self._port.check_for_leaks() for each child process.
3936
3937         * Scripts/webkitpy/port/server_process_unittest.py:
3938         (TrivialMockPort.check_for_leaks):
3939         - Rename redundant 'process_pid' argument to 'process_id'.
3940
3941         * Scripts/webkitpy/port/simulator_process.py:
3942         (SimulatorProcess.stop):
3943         - If self._child_processes is set, call
3944           self._port.check_for_leaks() for each child process.
3945
3946         * Scripts/webkitpy/port/watch_device.py:
3947         (WatchDevicePort.check_for_leaks):
3948         - Rename redundant 'process_pid' argument to 'process_id'.
3949
3950         * WebKitTestRunner/TestController.cpp:
3951         (WTR::TestController::dumpResponse):
3952         - Extract method from findAndDumpWorldLeaks() so that it may be
3953           reused by findAndDumpWebKitProcessIdentifiers().
3954         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3955         - Add method to output process name and process ID of both the
3956           WebContent and Networking processes.
3957         (WTR::TestController::findAndDumpWorldLeaks):
3958         - Fix missing newline in output when there were no abandoned
3959           documents.
3960         - Call dumpResponse() for extracted code.
3961         (WTR::TestController::handleControlCommand):
3962         - Restructure the logic for "#CHECK FOR WORLD LEAKS".
3963         - Use strncmp() instead of strcmp().
3964         - Call findAndDumpWebKitProcessIdentifiers() when
3965           "#LIST CHILD PROCESSES" command is sent.
3966         * WebKitTestRunner/TestController.h:
3967         (WTR::TestController::dumpResponse):
3968         (WTR::TestController::findAndDumpWebKitProcessIdentifiers):
3969         - Declare methods.
3970
3971 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3972
3973         Unreviewed. Add GLib API test cases after r243434.
3974
3975         * TestWebKitAPI/Tests/WebKitGLib/TestLoaderClient.cpp:
3976         (testWebViewActiveURI):
3977         (serverCallback):
3978         * TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
3979         (sendRequestCallback):
3980
3981 2019-03-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3982
3983         Geolocation request not complete when watch request was started in a different web process
3984         https://bugs.webkit.org/show_bug.cgi?id=195996
3985
3986         Reviewed by Alex Christensen.
3987
3988         Add a test case.
3989
3990         * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
3991         (TestWebKitAPI::runJavaScriptAlert):
3992         (TestWebKitAPI::TEST):
3993
3994 2019-03-26  Keith Rollin  <krollin@apple.com>
3995
3996         Update the way generate-xcfilelists returns strings from functions
3997         https://bugs.webkit.org/show_bug.cgi?id=195975
3998         <rdar://problem/49040807>
3999
4000         Reviewed by Dean Jackson.
4001
4002         There are places where generate-xcfilelists executes assignments with
4003         statements like:
4004
4005             FOO=$(some_function)
4006
4007         where "some_function" return a string by echoing it. E.g.
4008
4009             some_function()
4010             {
4011                 echo "Hello, World"
4012             }
4013
4014         This is a common idiom, but it has a problem if "some_function" needs
4015         to call "exit" in an attempt to halt the entire script right then and
4016         there. Since "some_function" is called inside of $(), it's being
4017         executed in a sub-shell. Calling exit in that sub-shell simply exits
4018         that shell; it doesn't not exit the outer shell in which the main part
4019         of the script is still running. As such, the main script keeps
4020         executing when the intent was for the script to halt.
4021
4022         The solution to this is to use a different idiom for returning
4023         strings. The one we now is to pass in the name of the variable to
4024         receive the string result:
4025
4026             some_function()
4027             {
4028                 variable_name=$1
4029                 eval $variable_name ="Hello, World"
4030             }
4031
4032         The call site now looks like
4033
4034             some_function FOO
4035
4036         Because there's no invocation of a sub-shell, some_function can now
4037         call "exit" if it wants to, and the entire script will exit at that
4038         point.
4039
4040         * Scripts/generate-xcfilelists:
4041
4042 2019-03-26  Chris Dumez  <cdumez@apple.com>
4043
4044         Add basic layout test coverage for File Picker on iOS
4045         https://bugs.webkit.org/show_bug.cgi?id=196265
4046
4047         Reviewed by Wenson Hsieh.
4048
4049         Add layout test infrastructure to test the file picker on iOS.
4050
4051         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4052         (WTR::UIScriptController::dismissFilePicker):
4053         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4054         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4055         (WTR::UIScriptController::dismissFilePicker):
4056         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4057         * WebKitTestRunner/TestController.cpp:
4058         (WTR::TestController::createWebViewWithOptions):
4059         (WTR::updateTestOptionsFromTestHeader):
4060         * WebKitTestRunner/TestOptions.h:
4061         (WTR::TestOptions::hasSameInitializationOptions const):
4062         * WebKitTestRunner/ios/TestControllerIOS.mm:
4063         (overridePresentViewController):
4064         (WTR::TestController::platformInitialize):
4065         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4066         (WTR::UIScriptController::dismissFilePicker):
4067
4068 2019-03-26  Wenson Hsieh  <wenson_hsieh@apple.com>
4069
4070         Implement async paste method on UIWKInteractionViewProtocol
4071         https://bugs.webkit.org/show_bug.cgi?id=196267
4072         <rdar://problem/49236346>
4073
4074         Reviewed by Tim Horton.
4075
4076         Add a new test to exercise the new SPI. Additionally, add staging forward declarations for
4077         -pasteWithCompletionHandler:, and remove some old existing staging declarations for other bits of UIKit SPI that
4078         are now a part of all iOS 12 internal SDKs.
4079
4080         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
4081
4082         While we're here, also change a few iOS 11.3 checks to just be about PLATFORM(IOS) (since we don't build for iOS
4083         prior to 12, these version checks are effectively only about iOS vs. tvOS or watchOS).
4084
4085         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
4086         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
4087         (-[DragAndDropSimulator _sendQueuedAdditionalItemRequest]):
4088         * TestWebKitAPI/ios/UIKitSPI.h:
4089
4090 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4091
4092         [ews-build] Use PostgreSQL for ews.webkit.org database
4093         https://bugs.webkit.org/show_bug.cgi?id=196270
4094
4095         Reviewed by Lucas Forschler.
4096
4097         * BuildSlaveSupport/ews-app/ews-app/settings.py:
4098
4099 2019-03-26  Jonathan Bedard  <jbedard@apple.com>
4100
4101         [ews] Reset simctl states on reboot
4102         https://bugs.webkit.org/show_bug.cgi?id=196260
4103
4104         Rubber-stamped by Aakash Jain.
4105
4106         * EWSTools/start-queue-mac.sh:
4107
4108 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4109
4110         [ews-build] Use PostgreSQL for ews-build database
4111         https://bugs.webkit.org/show_bug.cgi?id=196229
4112
4113         Reviewed by Lucas Forschler.
4114
4115         * BuildSlaveSupport/ews-build/master.cfg:
4116
4117 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4118
4119         [ews-build] Get master_hostname dynamically in master.cfg
4120         https://bugs.webkit.org/show_bug.cgi?id=196255
4121
4122         Reviewed by Lucas Forschler.
4123
4124         * BuildSlaveSupport/ews-build/master.cfg: Get hostname dynamically. Also do not
4125         send events data in test mode.
4126
4127 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4128
4129         [ews-app] Set db_constraint to False for Foreign Keys
4130         https://bugs.webkit.org/show_bug.cgi?id=196252
4131
4132         Reviewed by Lucas Forschler.
4133
4134         * BuildSlaveSupport/ews-app/ews/models/build.py:
4135         * BuildSlaveSupport/ews-app/ews/models/step.py:
4136
4137 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4138
4139         [ews-build] is_test_mode_enabled should default to True
4140         https://bugs.webkit.org/show_bug.cgi?id=196248
4141
4142         Reviewed by Lucas Forschler.
4143
4144         * BuildSlaveSupport/ews-build/master.cfg: Reverse the environment variable used to decide is_test_mode_enabled.
4145
4146 2019-03-26  Aakash Jain  <aakash_jain@apple.com>
4147
4148         [ews-app] Add webkitperl to ENABLED_QUEUES
4149         https://bugs.webkit.org/show_bug.cgi?id=196253
4150
4151         Reviewed by Lucas Forschler.
4152
4153         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
4154
4155 2019-03-25  Alexey Proskuryakov  <ap@apple.com>
4156
4157         Address NSWindow sometimes using WebKitTestRunnerEvent too early
4158         https://bugs.webkit.org/show_bug.cgi?id=196211
4159         rdar://problem/49110552
4160
4161         Reviewed by Tim Horton.
4162
4163         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
4164         Make sure that EventSenderProxy always exists when running tests. We used to create
4165         it when resetting before the first test, which is a bit too late.
4166
4167         * WebKitTestRunner/TestController.h:
4168         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
4169         (WTR::TestController::platformCreateWebView):
4170         (WTR::TestController::platformCreateOtherPage):
4171         (WTR::TestController::finishCreatingPlatformWebView):
4172         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
4173         (WTR::PlatformWebView::PlatformWebView):
4174         Moved some code that made NSWindow use NSEvent during web view creation. We may
4175         need to move more if some other case us found, but this is enough for now.
4176
4177 2019-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
4178
4179         Unreviewed. Fix typo in GLib geolocation API after r243285.
4180
4181         gelocation -> geolocation.
4182
4183         * TestWebKitAPI/Tests/WebKitGLib/TestGeolocationManager.cpp:
4184         (testGeolocationManagerWatchPosition):
4185
4186 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4187
4188         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4189         https://bugs.webkit.org/show_bug.cgi?id=196213
4190
4191         Reviewed by Geoff Garen.
4192
4193         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4194         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4195         (credentialWithIdentityAndKeychainPath):
4196         (-[ChallengeDelegate webView:didFinishNavigation:]):
4197         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4198         (TestWebKitAPI::TEST):
4199
4200 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4201
4202         Expected shouldn't assume its contained types are copyable
4203         https://bugs.webkit.org/show_bug.cgi?id=195986
4204
4205         Reviewed by JF Bastien.
4206
4207         * TestWebKitAPI/Tests/WTF/Expected.cpp:
4208         (TestWebKitAPI::NonCopyable::operator== const):
4209         (TestWebKitAPI::NonCopyable::operator!= const):
4210         (TestWebKitAPI::TEST):
4211
4212 2019-03-25  Tim Horton  <timothy_horton@apple.com>
4213
4214         Remove some now-unnecessary dynamic class lookup
4215         https://bugs.webkit.org/show_bug.cgi?id=196237
4216
4217         Reviewed by Simon Fraser.
4218
4219         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4220         (makeRequest):
4221         (TEST):
4222
4223 2019-03-25  Fujii Hironori  <Hironori.Fujii@sony.com>
4224
4225         Unreviewed, rolling out r243450.
4226
4227         AppleWin and WinCairo port builds get broken.
4228
4229         Reverted changeset:
4230
4231         "Add test for fix of #196095"
4232         https://bugs.webkit.org/show_bug.cgi?id=196097
4233         https://trac.webkit.org/changeset/243450
4234
4235 2019-03-25  Commit Queue  <commit-queue@webkit.org>
4236
4237         Unreviewed, rolling out r243465.
4238         https://bugs.webkit.org/show_bug.cgi?id=196226
4239
4240         the test doesn't build (Requested by thorton on #webkit).
4241
4242         Reverted changeset:
4243
4244         "Do not terminate the NetworkProcess if a third party
4245         application sends a NSCredential with a SecIdentityRef"
4246         https://bugs.webkit.org/show_bug.cgi?id=196213
4247         https://trac.webkit.org/changeset/243465
4248
4249 2019-03-25  Alex Christensen  <achristensen@webkit.org>
4250
4251         Do not terminate the NetworkProcess if a third party application sends a NSCredential with a SecIdentityRef
4252         https://bugs.webkit.org/show_bug.cgi?id=196213
4253
4254         Reviewed by Geoff Garen.
4255
4256         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4257         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm: Added.
4258         (credentialWithIdentityAndKeychainPath):
4259         (-[ChallengeDelegate webView:didFinishNavigation:]):
4260         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
4261         (TestWebKitAPI::TEST):
4262
4263 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4264
4265         [ews-build] Gracefully handle missing patch_id in events
4266         https://bugs.webkit.org/show_bug.cgi?id=196216
4267
4268         Reviewed by Lucas Forschler.
4269
4270         * BuildSlaveSupport/ews-build/events.py:
4271
4272 2019-03-25  Aakash Jain  <aakash_jain@apple.com>
4273
4274         [ews-build] use lz4 compression for improving buildbot performance
4275         https://bugs.webkit.org/show_bug.cgi?id=196155
4276
4277         Reviewed by Lucas Forschler.
4278
4279         * BuildSlaveSupport/ews-build/master.cfg:
4280
4281 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4282
4283         Pull some API testing helper methods out of TestWKWebView
4284         https://bugs.webkit.org/show_bug.cgi?id=196212
4285
4286         Reviewed by Tim Horton.
4287
4288         Refactor some more API testing utility methods, so that they can be used in
4289         tests that do not use TestWKWebView.
4290
4291         * TestWebKitAPI/cocoa/TestWKWebView.h:
4292         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4293         (-[WKWebView loadTestPageNamed:]):
4294         (-[WKWebView synchronouslyLoadHTMLString:baseURL:]):
4295         (-[WKWebView synchronouslyLoadHTMLString:]):
4296         (-[WKWebView synchronouslyLoadTestPageNamed:]):
4297         (-[TestWKWebView loadTestPageNamed:]): Deleted.
4298         (-[TestWKWebView synchronouslyLoadHTMLString:baseURL:]): Deleted.
4299         (-[TestWKWebView synchronouslyLoadHTMLString:]): Deleted.
4300         (-[TestWKWebView synchronouslyLoadTestPageNamed:]): Deleted.
4301
4302 2019-03-25  Jer Noble  <jer.noble@apple.com>
4303
4304         Test for: 196095 Inband Text Track cues interspersed with Data cues can display out of order.
4305         https://bugs.webkit.org/show_bug.cgi?id=196097
4306
4307         Reviewed by Eric Carlson.
4308
4309         Drive-by bug fix: allow tests to play audio without a user gesture by default.
4310
4311         * DumpRenderTree/mac/DumpRenderTree.mm:
4312         (resetWebPreferencesToConsistentValues):
4313         * WebKitTestRunner/TestController.cpp:
4314         (WTR::TestController::resetPreferencesToConsistentValues):
4315
4316 2019-03-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4317
4318         Pull IPadUserInterfaceSwizzler out into a separate header file
4319         https://bugs.webkit.org/show_bug.cgi?id=196193
4320
4321         Reviewed by Anders Carlsson.
4322
4323         Pull the IPadUserInterfaceSwizzler helper class out into a separate file, so that it may
4324         be used in other API tests.
4325
4326         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4327         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
4328         (TestWebKitAPI::IPadUserInterfaceSwizzler::IPadUserInterfaceSwizzler): Deleted.
4329         (TestWebKitAPI::IPadUserInterfaceSwizzler::padUserInterfaceIdiom): Deleted.