72eb8d5beb7e927cab32b54d4cd39bdc567ec401
[WebKit-https.git] / Tools / ChangeLog
1 2019-07-12  Alex Christensen  <achristensen@webkit.org>
2
3         Begin unifying TestWebKitAPI build
4         https://bugs.webkit.org/show_bug.cgi?id=199728
5
6         Reviewed by Keith Miller.
7
8         * TestWebKitAPI/Configurations/Base.xcconfig:
9         * TestWebKitAPI/Scripts/generate-unified-sources.sh: Added.
10         * TestWebKitAPI/Sources.txt: Added.
11         * TestWebKitAPI/SourcesCocoa.txt: Added.
12         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13
14 2019-07-12  Zhifei Fang  <zhifei_fang@apple.com>
15
16         run-javascriptcore-tests won't report test results for testmasm, testair, testb3, testdfg and test api
17         https://bugs.webkit.org/show_bug.cgi?id=199489
18         <rdar://problem/47891081>
19
20         Reviewed by Aakash Jain.
21
22         * BuildSlaveSupport/build.webkit.org-config/steps.py:
23         (RunJavaScriptCoreTests.countFailures):
24         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
25         * Scripts/run-javascriptcore-tests:
26         (runTest):
27         (reportTestFailures):
28         (runJSCStressTests):
29
30 2019-07-12  Aakash Jain  <aakash_jain@apple.com>
31
32         [ews-build] Make layout-tests' full_results.json accessible in Buildbot
33         https://bugs.webkit.org/show_bug.cgi?id=199743
34
35         Reviewed by Jonathan Bedard.
36
37         * BuildSlaveSupport/ews-build/steps.py:
38         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
39
40 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
41
42         Unreviewed follow-up fix to r247364.
43         [ews-build] Add build step to clean up .git/index.lock file
44         https://bugs.webkit.org/show_bug.cgi?id=199722
45
46         * BuildSlaveSupport/ews-build/steps.py:
47         (CheckOutSource): CheckOutSource should not haltOnFailure since CleanUpGitIndexLock step needs
48         to be run after this step.
49
50 2019-07-11  Yusuke Suzuki  <ysuzuki@apple.com>
51
52         Flaky API Test TestWTF.bmalloc.ScavengedMemoryShouldBeReused
53         https://bugs.webkit.org/show_bug.cgi?id=199524
54         <rdar://problem/52783816>
55
56         Reviewed by Saam Barati.
57
58         This test is white-box one and it has strong assumption how IsoHeap allocates pages.
59         But this test has several problems.
60
61         1. IsoPage::numObjects is not the exact number of how many we allocate objects. This
62            number is calculated by pageSize / sizeof(T), and this does not account the header
63            size of IsoPage. So, # of objects per IsoPage is less than numObjects. Since sizeof(double)
64            is very small, we can have many objects in one IsoPage. As a result, we need a large
65            bitmap in IsoPage. This reduces # of objects in IsoPage largely. So, `ptrs.size()` becomes
66            less than numObjects.
67
68         2. We now have lower tier of allocation in IsoHeap. It means that we allocate 8 objects in
69            shared page (page is shared, but memory is pinned for a specific type) before using IsoHeap's
70            page. This also makes the intention of this test wrong.
71
72         Due to (1), we access OoB of ptrs vector, passing a garbage to IsoHeap::deallocate, and crashing.
73
74         We make this test robust while we still keep this test white-box one to test the critical feature
75         of IsoHeap. We first exhaust lower tier of IsoHeap, and after that, start testing the memory. We
76         allocate many pointers, deallocate them, allocate one pointer while keeping pointers in the lower
77         tier live, and check whether the deallocated memory is reused.
78
79         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
80         (TEST):
81
82 2019-07-11  Pablo Saavedra  <psaavedra@igalia.com>
83
84         [WPE][GTK] Build failure with ENABLE_ACCESSIBILITY=OFF
85         https://bugs.webkit.org/show_bug.cgi?id=199625
86
87         Added ENABLE(ACCESSIBILITY) and replaced HAVE(ACCESSIBILITY)
88         with ENABLE(ACCESSIBILITY) in the code.
89
90         Additionally, the TestRunner code generator now honors the
91         Conditional IDL format.
92
93         Reviewed by Konstantin Tokarev.
94
95         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
96         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
97         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
98         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
99         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
100         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl:
101         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl:
102         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
103         * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
104         (_generateImplementationFile):
105
106 2019-07-11  Aakash Jain  <aakash_jain@apple.com>
107
108         [ews-build] Add build step to clean up .git/index.lock file
109         https://bugs.webkit.org/show_bug.cgi?id=199722
110
111         Reviewed by Jonathan Bedard.
112
113         * BuildSlaveSupport/ews-build/steps.py:
114         (CheckOutSource.getResultSummary): Run CleanUpGitIndexLock step when CheckOutSource fails.
115         (CleanUpGitIndexLock.__init__): Configure timeout and logEnviron.
116         (CleanUpGitIndexLock.evaluateCommand): Always RETRY the build after this step is run.
117         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
118
119 2019-07-11  Jonathan Bedard  <jbedard@apple.com>
120
121         [iOS 13] Enable WebKit build
122         https://bugs.webkit.org/show_bug.cgi?id=199481
123         <rdar://problem/52619048>
124
125         Reviewed by Tim Horton.
126
127         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add iOS framework stubs.
128
129 2019-07-11  Ryan Haddad  <ryanhaddad@apple.com>
130
131         Add test expectations and baselines for iOS 13
132         https://bugs.webkit.org/show_bug.cgi?id=199329
133
134         Reviewed by Jonathan Bedard.
135
136         * Scripts/webkitpy/port/ios.py:
137         (IOSPort): Increment current version to 13.
138         * Scripts/webkitpy/port/ios_device_unittest.py: Update unit tests.
139         (IOSDeviceTest.test_layout_test_searchpath_with_apple_additions):
140         (IOSDeviceTest.test_layout_test_searchpath_without_apple_additions):
141         (IOSDeviceTest.test_layout_searchpath_wih_device_type):
142         * Scripts/webkitpy/port/ios_simulator_unittest.py: Ditto.
143         (IOSSimulatorTest.make_port):
144         (IOSSimulatorTest.test_layout_test_searchpath_with_apple_additions):
145         (IOSSimulatorTest.test_layout_test_searchpath_without_apple_additions):
146         (IOSSimulatorTest.test_layout_searchpath_wih_device_type):
147         * Scripts/webkitpy/port/ios_testcase.py: Ditto.
148         (IOSTest.make_port):
149
150 2019-07-11  Joanmarie Diggs  <jdiggs@igalia.com>
151
152         AX: Implement support for ARIA roles insertion, deletion, subscript, superscript, and time
153         https://bugs.webkit.org/show_bug.cgi?id=199692
154
155         Reviewed by Chris Fleizach.
156
157         Add support for output of AXDeletion and AXInsertion roles for tests.
158         Update GTK and WPE jhbuild modules to use version of ATK and AT-SPI2
159         which include ROLE_CONTENT_DELETION and ROLE_CONTENT_INSERTION.
160
161         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
162         * gtk/jhbuild.modules:
163         * wpe/jhbuild.modules:
164
165 2019-07-11  Adrian Perez de Castro  <aperez@igalia.com>
166
167         [ews-build] Remove workers {ltilve,tanty}-gtk-wk2-ews from configuration
168         https://bugs.webkit.org/show_bug.cgi?id=199707
169
170         Reviewed by Aakash Jain.
171
172         * BuildSlaveSupport/ews-build/config.json: Remove old unused workers.
173
174 2019-07-10  Simon Fraser  <simon.fraser@apple.com>
175
176         [iOS WK2] With modal overlay and body overflow:hidden, can't access all the content
177         https://bugs.webkit.org/show_bug.cgi?id=199693
178         rdar://problem/51930364
179
180         Reviewed by Tim Horton.
181         
182         New API tests that test scrollability with various combinations of content, insets,
183         input accessory bars etc.
184
185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
186         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm: Added.
187         (TestWebKitAPI::webViewWithAutofocusedInput):
188         (TestWebKitAPI::TEST):
189
190 2019-07-10  Tim Horton  <timothy_horton@apple.com>
191
192         Long pressing on attachments will crash the WebContent process
193         https://bugs.webkit.org/show_bug.cgi?id=199696
194         <rdar://problem/52920241>
195
196         Reviewed by Dean Jackson.
197
198         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
199         (TestWebKitAPI::TEST):
200         Add a test that previously crashed.
201
202 2019-07-10  Dean Jackson  <dino@apple.com>
203
204         Support MacCatalyst in run-webkit-app
205         https://bugs.webkit.org/show_bug.cgi?id=199690
206
207         Reviewed by Tim Horton.
208
209         Add a --maccatalyst option to run-webkit-app that
210         can launch MacCatalyst applications with a built WebKit.
211
212         * Scripts/webkitdirs.pm:
213         (argumentsForConfiguration):
214         (determineXcodeSDK):
215         (xcodeSDKPlatformName):
216         (determineConfigurationProductDir):
217         (determinePortName):
218         (isCatalystWebKit):
219         (isAppleCocoaWebKit):
220         (willUseCatalystSDK):
221
222 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
223
224         [MacOS] Filter VPA info logged to stdout
225         https://bugs.webkit.org/show_bug.cgi?id=199673
226
227         Reviewed by Eric Carlson.
228
229         * Scripts/webkitpy/port/mac.py:
230         (MacPort.logging_patterns_to_strip):
231
232 2019-07-10  Ryan Haddad  <ryanhaddad@apple.com>
233
234         Unreviewed, rolling out r247286.
235
236         Caused TestWTF.WTF.StringOperators to fail on debug bots
237
238         Reverted changeset:
239
240         "Add StringBuilder member function which allows makeString()
241         style variadic argument construction"
242         https://bugs.webkit.org/show_bug.cgi?id=198997
243         https://trac.webkit.org/changeset/247286
244
245 2019-07-10  Aakash Jain  <aakash_jain@apple.com>
246
247         [ews-build] Explicitly use perl or python while invoking scripts
248         https://bugs.webkit.org/show_bug.cgi?id=199669
249
250         Reviewed by Jonathan Bedard.
251
252         * BuildSlaveSupport/ews-build/steps.py: Explicitly added perl or python while invoking scripts.
253         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
254
255 2019-07-10  Guillaume Emont  <guijemont@igalia.com>
256
257         Run tests on mips EWS
258         https://bugs.webkit.org/show_bug.cgi?id=196854
259
260         Reviewed by Carlos Garcia Campos.
261
262         * Scripts/webkitpy/common/config/ews.json:
263
264 2019-07-09  Michael Catanzaro  <mcatanzaro@igalia.com>
265
266         [WPE][GTK] GUniqueOutPtr::release should return a raw pointer
267         https://bugs.webkit.org/show_bug.cgi?id=199579
268
269         Reviewed by Carlos Garcia Campos.
270
271         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp:
272         (TestWebKitAPI::TEST):
273
274 2019-07-09  Chris Dumez  <cdumez@apple.com>
275
276         Fix integer type encoding / decoding in WKRemoteObjectCoder
277         https://bugs.webkit.org/show_bug.cgi?id=199643
278         <rdar://problem/52732342>
279
280         Reviewed by Anders Carlsson.
281
282         Update API test coverage.
283
284         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
285         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
286         (TEST):
287         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
288         (-[RemoteObjectRegistryPlugIn takeUnsignedLongLong:completionHandler:]):
289         (-[RemoteObjectRegistryPlugIn takeLongLong:completionHandler:]):
290         (-[RemoteObjectRegistryPlugIn takeUnsignedLong:completionHandler:]):
291         (-[RemoteObjectRegistryPlugIn takeLong:completionHandler:]):
292
293 2019-07-09  Sam Weinig  <weinig@apple.com>
294
295         Add StringBuilder member function which allows makeString() style variadic argument construction
296         https://bugs.webkit.org/show_bug.cgi?id=198997
297
298         Reviewed by Darin Adler.
299
300         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
301         Add basic test showing that StringBuilder::flexibleAppend can be used to 
302         append one or more string adaptable types. 
303
304 2019-07-09  Sihui Liu  <sihui_liu@apple.com>
305
306         Only allow fetching and removing session credentials from WebsiteDataStore
307         https://bugs.webkit.org/show_bug.cgi?id=199385
308         <rdar://problem/52622080>
309
310         Reviewed by Alex Christensen.
311
312         removeDataOfTypes will no longer remove persistent credentials. We should clear persistent credentials using
313         the new SPI after each test that creates persistent credentials, otherwise the later tests may use credentials
314         left by previous tests and didReceiveAuthenticationChallenge will not be invoked.
315
316         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
317         (TEST):
318         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
319         (TestWebKitAPI::TEST):
320
321 2019-07-09  Alex Christensen  <achristensen@webkit.org>
322
323         When parsing an IPv4 address, wait until after deciding it is indeed an IPv4 address before reporting syntax violations
324         https://bugs.webkit.org/show_bug.cgi?id=199628
325
326         Reviewed by Brady Eidson.
327
328         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
329         (TestWebKitAPI::TEST_F):
330
331 2019-07-09  Alex Christensen  <achristensen@webkit.org>
332
333         Remove invalid assertion in URLParser::domainToASCII
334         https://bugs.webkit.org/show_bug.cgi?id=199624
335
336         Reviewed by Brady Eidson.
337
338         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
339         (TestWebKitAPI::TEST_F):
340
341 2019-07-09  Alex Christensen  <achristensen@webkit.org>
342
343         URLParser should reserialize IPv6 addresses that end with a colon
344         https://bugs.webkit.org/show_bug.cgi?id=199627
345
346         Reviewed by Brady Eidson.
347
348         * TestWebKitAPI/Tests/WTF/URLParser.cpp:
349         (TestWebKitAPI::TEST_F):
350
351 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
352
353         [ews-build] Do not run unix commands for windows in PrintConfiguration
354         https://bugs.webkit.org/show_bug.cgi?id=199605
355
356         Reviewed by Jonathan Bedard.
357
358         * BuildSlaveSupport/ews-build/steps.py:
359
360 2019-07-08  Fujii Hironori  <Hironori.Fujii@sony.com>
361
362         JSTestGlobalObject.cpp of bindings-generation-tests is failing for Windows Python
363         https://bugs.webkit.org/show_bug.cgi?id=199487
364
365         Reviewed by Ross Kirsling.
366
367         In Windows Python, preprocessor.pm is using cl.exe. cl.exe was
368         failing to open testglobalscope_constructors_file which was
369         created by using tempfile.mkstemp() because it keeps the file
370         open. Use tempfile.mkdtemp() to create temporary files in the
371         temporary directory instead of tempfile.mkstemp().
372
373         * Scripts/webkitpy/bindings/main.py:
374         (BindingsTests.run_tests):
375         (BindingsTests.main):
376         (BindingsTests.close_and_remove): Deleted.
377
378 2019-07-08  Aakash Jain  <aakash_jain@apple.com>
379
380         [ews-build] Add KillOldProcesses step before running API or Layout tests
381         https://bugs.webkit.org/show_bug.cgi?id=199592
382
383         Reviewed by Jonathan Bedard.
384
385         * BuildSlaveSupport/ews-build/factories.py:
386
387 2019-07-08  Jonathan Bedard  <jbedard@apple.com>
388
389         test-webkitpy: Explicitly use Python 2.7 lldb library
390         https://bugs.webkit.org/show_bug.cgi?id=199578
391         <rdar://problem/51853557>
392
393         Reviewed by Aakash Jain.
394
395         * Scripts/webkitpy/common/system/systemhost.py:
396         (SystemHost.path_to_lldb_python_directory): Explicitly use Python 2.7 lldb libary.
397         * Scripts/webkitpy/test/main.py:
398         (_supports_building_and_running_lldb_tests): Run lldb tests on Catalina again.
399
400 2019-07-08  Ryan Haddad  <ryanhaddad@apple.com>
401
402         Add test expectations and baselines for Catalina
403         https://bugs.webkit.org/show_bug.cgi?id=199328
404
405         Reviewed by Jonathan Bedard.
406
407         * Scripts/webkitpy/port/mac.py:
408         (MacPort): Increment current version to 10.15 so that baseline search paths are correctly constructed for High Sierra.
409
410 2019-07-08  Christopher Reid  <chris.reid@sony.com>
411
412         Implement MappedFileData for Windows
413         https://bugs.webkit.org/show_bug.cgi?id=198269
414
415         Reviewed by Darin Adler.
416
417         * TestWebKitAPI/PlatformWin.cmake:
418
419 2019-07-08  Charlie Turner  <cturner@igalia.com>
420
421         REGRESSION(r243197): [GStreamer] Web process hangs when scrolling twitter timeline which contains HLS videos
422         https://bugs.webkit.org/show_bug.cgi?id=197558
423
424         Reviewed by Xabier Rodriguez-Calvar.
425
426         On shutdown we can easily deadlock the web process if we don't
427         ensure all network operations are completed before comitting state
428         changes. In HLS, make sure the network operations are cancelled,
429         and also prevent hlsdemux's retry logic from scuppering our
430         efforts.
431
432         * gstreamer/jhbuild.modules: Include the patch.
433         * gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch: Added.
434
435 2019-07-08  Antoine Quint  <graouts@apple.com>
436
437         [Pointer Events] Enable only on the most recent version of the supported iOS family
438         https://bugs.webkit.org/show_bug.cgi?id=199562
439         <rdar://problem/52766511>
440
441         Reviewed by Dean Jackson.
442
443         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
444
445 2019-07-06  Simon Fraser  <simon.fraser@apple.com>
446
447         Long hang when loading a cnn.com page on iOS
448         https://bugs.webkit.org/show_bug.cgi?id=199556
449
450         Reviewed by Zalan Bujtas.
451
452         Add code to load a page by default in MobileMiniBrowser so it's easy to hack it
453         to load a test page of your choice.
454
455         * MobileMiniBrowser/MobileMiniBrowserFramework/WebViewController.m:
456         (-[WebViewController viewDidLoad]):
457
458 2019-07-05  Ryosuke Niwa  <rniwa@webkit.org>
459
460         [iOS] Crash in WebKit::WebPage::positionInformation via Range::startPosition
461         https://bugs.webkit.org/show_bug.cgi?id=199503
462
463         Reviewed by Wenson Hsieh.
464
465         Added UIScriptController.ensurePositionInformationIsUpToDateAt using the existing WKWebView SPI:
466         _requestActivatedElementAtPosition
467
468         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
469         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
470         * DumpRenderTree/mac/UIScriptControllerMac.mm:
471         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
472         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
473         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
474         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
475         * TestRunnerShared/UIScriptContext/UIScriptController.h:
476         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
477         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
478         * WebKitTestRunner/ios/UIScriptControllerMac.mm:
479         (WTR::UIScriptController::ensurePositionInformationIsUpToDateAt):
480
481 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
482
483         Unreviewed, rolling out r247115.
484
485         Breaks lldbWebKitTester (and by extension, test-webkitpy)
486
487         Reverted changeset:
488
489         "[WHLSL] Standard library is too big to directly include in
490         WebCore"
491         https://bugs.webkit.org/show_bug.cgi?id=198186
492         https://trac.webkit.org/changeset/247115
493
494 2019-07-05  Ryan Haddad  <ryanhaddad@apple.com>
495
496         Unreviewed, rolling out r247123.
497
498         Caused TestWebKitAPI.Challenge.BasicProposedCredential to
499         fail.
500
501         Reverted changeset:
502
503         "Only allow fetching and removing session credentials from
504         WebsiteDataStore"
505         https://bugs.webkit.org/show_bug.cgi?id=199385
506         https://trac.webkit.org/changeset/247123
507
508 2019-07-05  Wenson Hsieh  <wenson_hsieh@apple.com>
509
510         Touching media controls sometimes shows software keyboard
511         https://bugs.webkit.org/show_bug.cgi?id=199490
512         <rdar://problem/52076270>
513
514         Reviewed by Eric Carlson.
515
516         Adds plumbing for a new testing hook to check whether or not there is an active input session. See other
517         ChangeLog entries for more detail.
518
519         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
520         (WTR::UIScriptController::hasInputSession const):
521         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
522         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
523         (WTR::UIScriptController::hasInputSession const):
524         * TestRunnerShared/UIScriptContext/UIScriptController.h:
525         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
526         (WTR::UIScriptController::hasInputSession const):
527
528 2019-07-04  Aakash Jain  <aakash_jain@apple.com>
529
530         [ews-build] Remove GTK and WPE queue from old EWS and dashboard
531         https://bugs.webkit.org/show_bug.cgi?id=199458
532
533         Reviewed by Michael Catanzaro.
534
535         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
536         * QueueStatusServer/config/queues.py:
537
538 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
539
540         [GTK] Fix browserperfdash script after r239522
541         https://bugs.webkit.org/show_bug.cgi?id=199496
542
543         Reviewed by Michael Catanzaro.
544
545         * Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
546         (BrowserPerfDashRunner.run): Pass None for the new required BenchmarkRunner constructor.
547
548 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
549
550         [webkitpy] test-webkitpy is broken on Linux since r246662
551         https://bugs.webkit.org/show_bug.cgi?id=199493
552
553         Reviewed by Michael Catanzaro.
554
555         * Scripts/webkitpy/test/main.py:
556         (_supports_building_and_running_lldb_tests): Add a check for None before calling startswith().
557
558 2019-07-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
559
560         [GTK][WPE] Not longer needed to build woff2 on the JHBuild
561         https://bugs.webkit.org/show_bug.cgi?id=199406
562
563         Reviewed by Michael Catanzaro.
564
565         Install the Woff2 libraries and headers from the system package
566         and stop building them on the JHBuild.
567
568         * gtk/install-dependencies:
569         * gtk/jhbuild.modules:
570         * wpe/install-dependencies:
571         * wpe/jhbuild.modules:
572
573 2019-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
574
575         [GTK][WPE][CMake] The CMake cache should be clean when the JHBuild is rebuilt
576         https://bugs.webkit.org/show_bug.cgi?id=199449
577
578         Reviewed by Michael Catanzaro.
579
580         * Scripts/webkitdirs.pm:
581         (shouldRemoveCMakeCache): Clean the CMake cache if we detect that the JHBuild has been rebuilt.
582
583 2019-07-01  Philippe Normand  <pnormand@igalia.com>
584
585         Unreviewed, GTK a11y tests fix after r247071
586
587         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
588         (WTR::AccessibilityUIElement::popupValue const):
589
590 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
591
592         [ews-build] Enable WPE and GTK queues on new EWS
593         https://bugs.webkit.org/show_bug.cgi?id=199234
594
595         Reviewed by Jonathan Bedard.
596
597         * BuildSlaveSupport/ews-build/config.json: Enabled the triggers for GTK and WPE builders.
598         * BuildSlaveSupport/ews-build/factories.py: Added required build steps for GTKFactory and WPEFactory.
599         * BuildSlaveSupport/ews-build/steps.py:
600         (CompileWebKit.evaluateCommand): Added InstallGtkDependencies/InstallWpeDependencies step before Compiling WebKit without patch.
601         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
602         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
603         (StatusBubble): Enable gtk and wpe status-bubbles.
604
605 2019-07-03  Sihui Liu  <sihui_liu@apple.com>
606
607         Only allow fetching and removing session credentials from WebsiteDataStore
608         https://bugs.webkit.org/show_bug.cgi?id=199385
609
610         Reviewed by Alex Christensen.
611
612         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
613         (TestWebKitAPI::TEST):
614
615 2019-07-03  Tim Horton  <timothy_horton@apple.com>
616
617         UI process exception when dragging an <attachment> with no content type
618         https://bugs.webkit.org/show_bug.cgi?id=199480
619         <rdar://problem/44351353>
620
621         Reviewed by Wenson Hsieh.
622
623         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
624         (TestWebKitAPI::TEST):
625         Add a test; before the change, it crashes.
626
627 2019-07-03  Jonathan Bedard  <jbedard@apple.com>
628
629         [Catalina] Enable WebKit build
630         https://bugs.webkit.org/show_bug.cgi?id=199209
631
632         Reviewed by Darin Adler.
633
634         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig: Add Mac framework stubs.
635
636 2019-07-03  Sam Weinig  <weinig@apple.com>
637
638         Adopt simple structured bindings in more places
639         https://bugs.webkit.org/show_bug.cgi?id=199247
640
641         Reviewed by Alex Christensen.
642
643         Replaces simple uses of std::tie() with structured bindings. Does not touch
644         uses of std::tie() that are not initial declarations, use std::ignore or in
645         case where the binding is captured by a lambda, as structured bindings don't
646         work for those cases yet.
647
648         * TestWebKitAPI/ios/PreferredContentMode.mm:
649         (TestWebKitAPI::TEST):
650
651 2019-07-03  Aakash Jain  <aakash_jain@apple.com>
652
653         Unreviewed follow-up fix to r247049, default the platform to '*' when platform property is not set.
654
655         * BuildSlaveSupport/ews-build/steps.py:
656         (PrintConfiguration.run):
657
658 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
659
660         [ews-build] Add build steps to Install Wpe and Gtk dependencies
661         https://bugs.webkit.org/show_bug.cgi?id=199408
662
663         Reviewed by Michael Catanzaro.
664
665         * BuildSlaveSupport/ews-build/steps.py:
666         (InstallGtkDependencies): Build step to install dependencies for GTK. Set haltOnFailure=False so that in case of failure, build isn't
667         marked as failed (which would indicated patch failed EWS), instead subsequent steps would be run and the build would be marked as RETRY.
668         (InstallWpeDependencies): Ditto for WPE.
669         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
670
671 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
672
673         [ews-build] Allow skipping uploading built product for few builders
674         https://bugs.webkit.org/show_bug.cgi?id=199422
675
676         Reviewed by Michael Catanzaro.
677
678         * BuildSlaveSupport/ews-build/steps.py:
679         (CompileWebKit.__init__): Added optional skipUpload parameter.
680         (CompileWebKit.evaluateCommand): Allow to skip upload if there are no triggers and skipUpload is True.
681
682 2019-07-02  Tim Horton  <timothy_horton@apple.com>
683
684         REGRESSION (r243240): Unable to swipe back in Safari
685         https://bugs.webkit.org/show_bug.cgi?id=199394
686         <rdar://problem/51137447>
687
688         Reviewed by Wenson Hsieh.
689
690         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
691         Make sure that we actually end up with swipe gesture recognizers installed
692         after process swap and crash.
693
694 2019-07-02  Andres Gonzalez  <andresg_22@apple.com>
695
696         Enhance support of aria-haspopup per ARIA 1.1 specification.
697         https://bugs.webkit.org/show_bug.cgi?id=199216
698         <rdar://problem/46221342>
699
700         Reviewed by Chris Fleizach.
701
702         * DumpRenderTree/AccessibilityUIElement.cpp:
703         (getPopupValueCallback):
704         (AccessibilityUIElement::getJSClass):
705         * DumpRenderTree/AccessibilityUIElement.h:
706         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
707         (AccessibilityUIElement::popupValue const):
708         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
709         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
710         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
711         (WTR::AccessibilityUIElement::popupValue const):
712         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
713         (WTR::AccessibilityUIElement::popupValue const):
714
715 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
716
717         [ews-build] Do not print worker environment variables in each build step [part 2]
718         https://bugs.webkit.org/show_bug.cgi?id=199405
719
720         Reviewed by Jonathan Bedard.
721
722         * BuildSlaveSupport/ews-build/steps.py:
723         (CheckOutSpecificRevision.__init__): Disabled logging of environment variables.
724         (CleanWorkingDirectory.__init__): Ditto.
725         (RunBindingsTests.__init__): Ditto.
726         (RunWebKitPerlTests.__init__): Ditto.
727         (RunWebKitPyTests.__init__): Ditto.
728         (CompileWebKit.__init__): Ditto.
729         (ArchiveTestResults.__init__): Ditto.
730         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
731
732 2019-07-02  Jer Noble  <jer.noble@apple.com>
733
734         Pipe suport for 'cenc' init data type into CDMFairPlayStreaming
735         https://bugs.webkit.org/show_bug.cgi?id=199381
736         <rdar://problem/52483103>
737
738         Reviewed by Eric Carlson.
739
740         * TestWebKitAPI/Tests/WebCore/ISOBox.cpp:
741
742 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
743
744         [ews-build] Update bot configuration for WPE and GTK
745         https://bugs.webkit.org/show_bug.cgi?id=199238
746
747         Reviewed by Michael Catanzaro.
748
749         * BuildSlaveSupport/ews-build/config.json:
750
751 2019-07-02  Aakash Jain  <aakash_jain@apple.com>
752
753         [ews-build] Make PrintConfiguration platform aware
754         https://bugs.webkit.org/show_bug.cgi?id=196657
755
756         Reviewed by Lucas Forschler.
757
758         * BuildSlaveSupport/ews-build/steps.py:
759         (PrintConfiguration): Specified platform-specific command lists.
760         (PrintConfiguration.run): Override run method and specify platform specific commands.
761         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
762
763 2019-07-01  Justin Michaud  <justin_michaud@apple.com>
764
765         [Wasm-References] Disable references by default
766         https://bugs.webkit.org/show_bug.cgi?id=199390
767
768         Reviewed by Saam Barati.
769
770         * Scripts/run-jsc-stress-tests:
771
772 2019-07-01  Joonghun Park  <pjh0718@gmail.com>
773
774         Unreviewed. Revert r246965 to fix build break
775         since r247019 reverted its related changes.
776
777         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
778         (WTR::AccessibilityUIElement::popupValue const): Deleted.
779
780 2019-07-01  Alex Christensen  <achristensen@webkit.org>
781
782         Add new decidePolicyForNavigationAction SPI with preferences and userInfo
783         https://bugs.webkit.org/show_bug.cgi?id=199371
784         <rdar://problem/52352905>
785
786         Reviewed by Tim Horton.
787
788         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
789         (-[NavigationActionSPIDelegate webView:didFinishNavigation:]):
790         (-[NavigationActionSPIDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]):
791         (-[NavigationActionSPIDelegate spiCalled]):
792         (TEST):
793
794 2019-07-01  Alex Christensen  <achristensen@webkit.org>
795
796         Deprecate _webView:showCustomSheetForElement: after transition to UIContextMenuInteraction
797         https://bugs.webkit.org/show_bug.cgi?id=199296
798         <rdar://problem/51041960>
799
800         Reviewed by Darin Adler.
801
802         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
803         (-[DragAndDropSimulator _webView:showCustomSheetForElement:]):
804
805 2019-07-01  Truitt Savell  <tsavell@apple.com>
806
807         Unreviewed, rolling out r246958.
808
809         Broke inspector/dom/getAccessibilityPropertiesForNode.html
810
811         Reverted changeset:
812
813         "Enhance support of aria-haspopup per ARIA 1.1 specification."
814         https://bugs.webkit.org/show_bug.cgi?id=199216
815         https://trac.webkit.org/changeset/246958
816
817 2019-07-01  Philippe Normand  <pnormand@igalia.com>
818
819         Unreviewed, GTK a11y tests fix after r246958
820
821         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
822         (WTR::AccessibilityUIElement::popupValue const):
823
824 2019-06-30  Andres Gonzalez  <andresg_22@apple.com>
825
826         Enhance support of aria-haspopup per ARIA 1.1 specification.
827         https://bugs.webkit.org/show_bug.cgi?id=199216
828         <rdar://problem/46221342>
829
830         Reviewed by Chris Fleizach.
831
832         * DumpRenderTree/AccessibilityUIElement.cpp:
833         (getPopupValueCallback):
834         (AccessibilityUIElement::getJSClass):
835         * DumpRenderTree/AccessibilityUIElement.h:
836         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
837         (AccessibilityUIElement::popupValue const):
838         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
839         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
840         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
841         (WTR::AccessibilityUIElement::popupValue const):
842         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
843         (WTR::AccessibilityUIElement::popupValue const):
844
845 2019-06-28  Robin Morisset  <rmorisset@apple.com>
846
847         Adding myself as a reviewer to contributors.json.
848
849         Unreviewed.
850
851         * Scripts/webkitpy/common/config/contributors.json:
852
853 2019-06-28  Jer Noble  <jer.noble@apple.com>
854
855         Add new -[WKWebView _closeAllMediaPresentations] SPI
856         https://bugs.webkit.org/show_bug.cgi?id=199294
857         <rdar://problem/51965958>
858
859         Reviewed by Alex Christensen.
860
861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
862         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm: Added.
863         (TEST):
864
865 2019-06-28  Sihui Liu  <sihui_liu@apple.com>
866
867         Add a regression test for change r246901
868         https://bugs.webkit.org/show_bug.cgi?id=199290
869
870         Reviewed by Geoffrey Garen.
871
872         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
873         * TestWebKitAPI/Tests/WebKitCocoa/LocalStoragePersistence.mm:
874         (-[LocalStorageNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
875         (TEST):
876         * TestWebKitAPI/Tests/WebKitCocoa/localstorage-open-window-private.html: Added.
877
878 2019-06-28  Konstantin Tokarev  <annulen@yandex.ru>
879
880         Remove traces of ENABLE_ICONDATABASE remaining after its removal in 219733
881         https://bugs.webkit.org/show_bug.cgi?id=199317
882
883         Reviewed by Michael Catanzaro.
884
885         While IconDatabase and all code using it was removed,
886         ENABLE_ICONDATABASE still exists as build option and C++ macro.
887
888         * Scripts/webkitperl/FeatureList.pm:
889         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
890         * gtk/manifest.txt.in: Remove reference to unused urlIcon.png file.
891         * wpe/manifest.txt.in: Remove reference to unused urlIcon.png file.
892
893 2019-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
894
895         -[WKContentView _selectionClipRects] returns a bogus value in -reloadInputViews when focusing an element
896         https://bugs.webkit.org/show_bug.cgi?id=199310
897         <rdar://problem/52292137>
898
899         Reviewed by Megan Gardner.
900
901         Add a new API test to verify that _selectionClipRects returns the correct value when invoked under the scope of
902         _elementDidFocus.
903
904         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
905         (TestWebKitAPI::TEST):
906         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
907         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
908         (-[TestInputDelegate setDidStartInputSessionHandler:]):
909         (-[TestInputDelegate didStartInputSessionHandler]):
910
911         Add plumbing for a handler block in TestInputDelegate.
912
913         (-[TestInputDelegate setWillStartInputSessionHandler:]):
914
915         Drive-by style fixes to add a space between id and < for Objective-C protocols.
916
917         (-[TestInputDelegate willStartInputSessionHandler]):
918         (-[TestInputDelegate _webView:willStartInputSession:]):
919         (-[TestInputDelegate _webView:didStartInputSession:]):
920         * TestWebKitAPI/cocoa/TestWKWebView.h:
921         * TestWebKitAPI/ios/UIKitSPI.h:
922
923         Add a declaration for _selectionClipRects.
924
925 2019-06-27  Zalan Bujtas  <zalan@apple.com>
926
927         REGRESSION(r244633): e-mail with "height: 100%" causes unstable layout.
928         https://bugs.webkit.org/show_bug.cgi?id=199303
929         <rdar://problem/51340927>
930
931         Reviewed by Tim Horton.
932
933         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
934         (TEST):
935
936 2019-06-27  Beth Dakin  <bdakin@apple.com>
937
938         Upstream use of MACCATALYST
939         https://bugs.webkit.org/show_bug.cgi?id=199245
940         rdar://problem/51687723
941
942         Reviewed by Tim Horton.
943
944         * ContentExtensionTester/Configurations/SDKVariant.xcconfig:
945         * DumpRenderTree/mac/Configurations/SDKVariant.xcconfig:
946         * ImageDiff/cg/Configurations/SDKVariant.xcconfig:
947         * MiniBrowser/Configurations/SDKVariant.xcconfig:
948         * MobileMiniBrowser/Configurations/SDKVariant.xcconfig:
949         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
950         (JavaScriptCoreGenerator):
951         (WebCoreGenerator):
952         (WebKitGenerator):
953         * TestWebKitAPI/Configurations/Base.xcconfig:
954         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
955         * TestWebKitAPI/Configurations/SDKVariant.xcconfig:
956         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
957         * WebEditingTester/Configurations/SDKVariant.xcconfig:
958         * WebKitLauncher/Configurations/SDKVariant.xcconfig:
959         * WebKitTestRunner/Configurations/SDKVariant.xcconfig:
960         * lldb/lldbWebKitTester/Configurations/SDKVariant.xcconfig:
961
962 2019-06-27  Saam Barati  <sbarati@apple.com>
963
964         Make WEBGPU enabled only on Mojave and later.
965
966         Rubber-stamped by Myles C. Maxfield.
967
968         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
969
970 2019-06-27  Aakash Jain  <aakash_jain@apple.com>
971
972         [ews-build] Do not print worker environment variables in each build step
973         https://bugs.webkit.org/show_bug.cgi?id=197319
974
975         Reviewed by Lucas Forschler.
976
977         * BuildSlaveSupport/ews-build/steps.py:
978         (CheckOutSource.__init__): Disabled logging of environment variables.
979         (ApplyPatch.__init__): Ditto.
980         (KillOldProcesses.__init__): Ditto.
981         (ArchiveBuiltProduct.__init__): Ditto.
982         (DownloadBuiltProduct.__init__): Ditto.
983         (ExtractBuiltProduct.__init__): Ditto.
984         (RunAPITests.__init__): Ditto.
985         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests accordingly.
986
987 2019-06-26  Jiewen Tan  <jiewen_tan@apple.com>
988
989         SubFrameSOAuthorizationSession should preserve the referrer header when fall back to web path
990         https://bugs.webkit.org/show_bug.cgi?id=199232
991         <rdar://problem/51718328>
992
993         Reviewed by Youenn Fablet.
994
995         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
996         (TestWebKitAPI::TEST):
997         Add a test that utilizes TCPServer as local files always omit referrer.
998
999 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
1000
1001         [ews-build] Add configuration and architecture for WPE and GTK builders
1002         https://bugs.webkit.org/show_bug.cgi?id=199249
1003
1004         Reviewed by Jonathan Bedard.
1005
1006         * BuildSlaveSupport/ews-build/config.json:
1007
1008 2019-06-26  Aakash Jain  <aakash_jain@apple.com>
1009
1010         [ews-build] Add check for duplicate workers in config.json
1011         https://bugs.webkit.org/show_bug.cgi?id=199240
1012
1013         Reviewed by Jonathan Bedard.
1014
1015         * BuildSlaveSupport/ews-build/loadConfig.py:
1016         (checkWorkersAndBuildersForConsistency._find_worker_with_name): Check for duplicate worker entry.
1017         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1018         (TestcheckWorkersAndBuildersForConsistency.test_duplicate_worker): Added unit-test.
1019
1020 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
1021
1022         [Win] MiniBrowser should make better font choices
1023         https://bugs.webkit.org/show_bug.cgi?id=199244
1024
1025         Reviewed by Brent Fulgham.
1026
1027         * MiniBrowser/win/MainWindow.cpp:
1028         (MainWindow::updateDeviceScaleFactor):
1029         * MiniBrowser/win/MiniBrowserLib.rc:
1030
1031 2019-06-26  Alex Christensen  <achristensen@webkit.org>
1032
1033         testRunner.setAlwaysAcceptCookies should wait for cookie accept policy to be set
1034         https://bugs.webkit.org/show_bug.cgi?id=199230
1035         <rdar://51757107>
1036
1037         Reviewed by Andy Estes.
1038
1039         * TestWebKitAPI/Tests/WebKit/CookieManager.cpp:
1040         (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
1041         (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
1042         * WebKitTestRunner/TestController.cpp:
1043         (WTR::TestController::generatePageConfiguration):
1044         (WTR::TestController::createWebViewWithOptions):
1045         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundleWithListener):
1046         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundleWithListener):
1047         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
1048         (WTR::TestController::didReceiveSynchronousPageMessageFromInjectedBundle): Deleted.
1049         * WebKitTestRunner/TestController.h:
1050         * WebKitTestRunner/TestInvocation.cpp:
1051         (WTR::TestInvocation::invoke):
1052         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1053
1054 2019-06-26  Ross Kirsling  <ross.kirsling@sony.com>
1055
1056         [Win][MiniBrowser] Remove obsolete code after r246814.
1057         https://bugs.webkit.org/show_bug.cgi?id=199233
1058
1059         Reviewed by Fujii Hironori.
1060
1061         * MiniBrowser/win/MiniBrowserWebHost.cpp:
1062         (MiniBrowserWebHost::didFinishLoadForFrame):
1063         (SimpleEventListener::SimpleEventListener): Deleted.
1064         (SimpleEventListener::handleEvent): Deleted.
1065
1066 2019-06-25  Jiewen Tan  <jiewen_tan@apple.com>
1067
1068         Implement a new SPI to inform clients about AppSSO
1069         https://bugs.webkit.org/show_bug.cgi?id=199085
1070         <rdar://problem/50028246>
1071
1072         Reviewed by Geoffrey Garen.
1073
1074         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1075         (-[TestSOAuthorizationBasicDelegate webView:didFinishNavigation:]):
1076         (-[TestSOAuthorizationNavigationDelegate init]):
1077         (-[TestSOAuthorizationNavigationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
1078         (TestWebKitAPI::TEST):
1079
1080 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
1081
1082         [ews-build] Retry Layout test in case of failures
1083         https://bugs.webkit.org/show_bug.cgi?id=199194
1084
1085         Reviewed by Jonathan Bedard.
1086
1087         * BuildSlaveSupport/ews-build/steps.py:
1088         (RunWebKitTests.evaluateCommand): Check if tests failed and retry them if required.
1089         (ReRunWebKitTests): Build step to re-run layout tests.
1090         (ReRunWebKitTests.evaluateCommand): Check if tests failed and retry on clean build if required.
1091         (RunWebKitTestsWithoutPatch): Build step to run tests without patch.
1092         (RunWebKitTestsWithoutPatch.evaluateCommand):
1093
1094 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
1095
1096         [ews-build] Combine various patchFailed*Tests properties
1097         https://bugs.webkit.org/show_bug.cgi?id=199193
1098
1099         Reviewed by Jonathan Bedard.
1100
1101         * BuildSlaveSupport/ews-build/steps.py: Renamed patchFailedJSCTests and patchFailedAPITests to patchFailedTests. This property 
1102         can also be used for layout-tests later on.
1103         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
1104
1105 2019-06-25  Ross Kirsling  <ross.kirsling@sony.com>
1106
1107         [Win] MiniBrowser should default to webkit.org
1108         https://bugs.webkit.org/show_bug.cgi?id=199201
1109
1110         Reviewed by Don Olmstead.
1111
1112         * MiniBrowser/win/BrowserWindow.h:
1113         * MiniBrowser/win/MiniBrowserReplace.h:
1114         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1115         (WebKitBrowserWindow::loadHTMLString): Deleted.
1116         * MiniBrowser/win/WebKitBrowserWindow.h:
1117         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1118         (WebKitLegacyBrowserWindow::loadHTMLString): Deleted.
1119         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1120         * MiniBrowser/win/WinMain.cpp:
1121         (wWinMain):
1122
1123 2019-06-25  Wenson Hsieh  <wenson_hsieh@apple.com>
1124
1125         [iOS] Occasional crash under -[UIPreviewTarget initWithContainer:center:transform:] when generating a drag preview
1126         https://bugs.webkit.org/show_bug.cgi?id=199192
1127         <rdar://problem/51554509>
1128
1129         Reviewed by Tim Horton.
1130
1131         Tweak the drag and drop simulator to ask for drag cancellation previews, and use this to write a couple tests to
1132         verify that we gracefully handle web process termination and web view unparenting mid-drag.
1133
1134         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
1135         (TestWebKitAPI::TEST):
1136         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1137         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1138         (-[DragAndDropSimulator _resetSimulatedState]):
1139         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
1140         (-[DragAndDropSimulator _advanceProgress]):
1141         (-[DragAndDropSimulator liftPreviews]):
1142         (-[DragAndDropSimulator cancellationPreviews]):
1143         (-[DragAndDropSimulator setSessionWillBeginBlock:]):
1144         (-[DragAndDropSimulator sessionWillBeginBlock]):
1145         (-[DragAndDropSimulator _webView:dataInteraction:sessionWillBegin:]):
1146
1147 2019-06-25  Aakash Jain  <aakash_jain@apple.com>
1148
1149         [ews-build] UploadTestResults and ExtractTestResults clobber results in case of multiple layout test runs in a build
1150         https://bugs.webkit.org/show_bug.cgi?id=199178
1151
1152         Reviewed by Jonathan Bedard.
1153
1154         * BuildSlaveSupport/ews-build/steps.py:
1155         (UploadTestResults.__init__): Add an optional identifier and append the identifier to the file name.
1156         (ExtractTestResults.__init__): Ditto.
1157         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit tests.
1158
1159 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1160
1161         Add user agent quirk for bankofamerica.com
1162         https://bugs.webkit.org/show_bug.cgi?id=199154
1163
1164         Reviewed by Carlos Garcia Campos.
1165
1166         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1167         (TestWebKitAPI::TEST):
1168
1169 2019-06-25  Michael Catanzaro  <mcatanzaro@igalia.com>
1170
1171         Fully rename WebKitGTK+ -> WebKitGTK everywhere
1172         https://bugs.webkit.org/show_bug.cgi?id=199159
1173
1174         Reviewed by Carlos Garcia Campos.
1175
1176         * BuildSlaveSupport/gtk/README:
1177         * MiniBrowser/gtk/BrowserWindow.c:
1178         * MiniBrowser/gtk/main.c:
1179         (aboutURISchemeRequestCallback):
1180         * Scripts/webkitpy/common/config/contributionareas.py:
1181         * Scripts/webkitpy/common/config/contributors.json:
1182         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py:
1183         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1184         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1185         (testWebViewResources):
1186         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
1187         (testWebViewMouseTarget):
1188         * TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
1189         (testWebExtensionGetTitle):
1190         (testDocumentLoadedSignal):
1191         (testWebExtensionFormControlsAssociated):
1192         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1193         (testWebKitSettingsUserAgent):
1194         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
1195         (testWebViewRunJavaScript):
1196         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
1197         (main):
1198         * TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:
1199         (prepareContextMenuTestView):
1200         (testContextMenuPopulateMenu):
1201         (testContextMenuCustomMenu):
1202         (testContextMenuDisableMenu):
1203         (testContextMenuSubMenu):
1204         (testContextMenuDismissed):
1205         (testContextMenuWebExtensionMenu):
1206         (testContextMenuWebExtensionNode):
1207         * TestWebKitAPI/Tests/WebKitGtk/TestInspector.cpp:
1208         (testInspectorDefault):
1209         (testInspectorManualAttachDetach):
1210         (testInspectorCustomContainerDestroyed):
1211         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
1212         (testWebViewPrint):
1213         (testPrintOperationPrint):
1214         (testPrintOperationErrors):
1215         * gtk/install-dependencies:
1216         * gtk/jhbuild.modules:
1217         * gtkdoc/generate-gtkdoc:
1218         * wpe/install-dependencies:
1219
1220 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1221
1222         contributors.json not canonicalized since r243297
1223         https://bugs.webkit.org/show_bug.cgi?id=199161
1224
1225         Reviewed by Alexey Proskuryakov.
1226
1227         Canonicalize it using 'validate-committer-lists --canonicalize'
1228
1229         * Scripts/webkitpy/common/config/contributors.json:
1230
1231 2019-06-24  Jonathan Bedard  <jbedard@apple.com>
1232
1233         webkitpy: Build style should be lower-case
1234         https://bugs.webkit.org/show_bug.cgi?id=199158
1235
1236         Reviewed by Aakash Jain.
1237
1238         * Scripts/webkitpy/test/main.py:
1239         (Tester._run_tests): Make all styles lower-case.
1240
1241 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
1242
1243         [ews-build] Remove iOS queue from old EWS and dashboard
1244         https://bugs.webkit.org/show_bug.cgi?id=199150
1245
1246         Reviewed by Jonathan Bedard.
1247
1248         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
1249         * QueueStatusServer/config/queues.py:
1250
1251 2019-06-21  Ryan Haddad  <ryanhaddad@apple.com>
1252
1253         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash
1254         https://bugs.webkit.org/show_bug.cgi?id=198795
1255
1256         Unreviewed test gardening.
1257
1258         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1259         (TestWebKitAPI::TEST): Disable flaky test.
1260
1261 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
1262
1263         [ews-build] Enable iOS-12-Build queue on new EWS
1264         https://bugs.webkit.org/show_bug.cgi?id=199149
1265
1266         Reviewed by Jonathan Bedard.
1267
1268         * BuildSlaveSupport/ews-build/config.json: Enable iOS-12-Build-EWS trigger. Also temporarily share ews152 and ews154 with
1269         this queue.
1270         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1271         (StatusBubble): Enable ios status-bubble. Also display the ios bubble first (left). Going forward
1272         will keep the builders to the left and testers to the right.
1273
1274 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
1275
1276         [ews-build] Upload test results after running layout-tests
1277         https://bugs.webkit.org/show_bug.cgi?id=199120
1278
1279         Reviewed by Jonathan Bedard.
1280
1281         * BuildSlaveSupport/ews-build/steps.py:
1282         (RunWebKitTests.evaluateCommand):
1283         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1284
1285 2019-06-24  Aakash Jain  <aakash_jain@apple.com>
1286
1287         [ews-build] EWS should provide option to download layout test results zip file
1288         https://bugs.webkit.org/show_bug.cgi?id=199121
1289
1290         Reviewed by Jonathan Bedard.
1291
1292         * BuildSlaveSupport/ews-build/steps.py:
1293         (ExtractTestResults.resultsDownloadURL): Method to return layout test result zip file url. 
1294         (ExtractTestResults.addCustomURLs): Add url to download layout test results zip file.
1295
1296 2019-06-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1297
1298         Add user agent quirk for Google Drive
1299         https://bugs.webkit.org/show_bug.cgi?id=199153
1300
1301         Reviewed by Carlos Garcia Campos.
1302
1303         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1304         (TestWebKitAPI::TEST):
1305
1306 2019-06-22  Zalan Bujtas  <zalan@apple.com>
1307
1308         [LFC] Expand tests coverage (328 new tests -> 2652).
1309
1310         * LayoutReloaded/misc/LFC-passing-tests.txt:
1311
1312 2019-06-22  Andres Gonzalez  <andresg_22@apple.com>
1313
1314         Accessibility objects contained in links should honor the aria-haspopup attribute in the ancestor link.
1315         https://bugs.webkit.org/show_bug.cgi?id=199107
1316         <rdar://problem/43663611>
1317
1318         Reviewed by Chris Fleizach.
1319
1320         iOS implementation for AccessibilityUIElement::hasPopup.
1321         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1322         (WTR::AccessibilityUIElement::hasPopup const):
1323
1324 2019-06-22  Konstantin Tokarev  <annulen@yandex.ru>
1325
1326         Unreviewed, add myself to CMake watchlist
1327
1328         * Scripts/webkitpy/common/config/watchlist:
1329
1330 2019-06-21  Sihui Liu  <sihui_liu@apple.com>
1331
1332         openDatabase should return an empty object when WebSQL is disabled
1333         https://bugs.webkit.org/show_bug.cgi?id=198805
1334
1335         Reviewed by Geoffrey Garen.
1336
1337         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1338         * TestWebKitAPI/Tests/WebKitCocoa/WebSQLBasics.mm: Added.
1339         (-[WebSQLBasicsMessageHandler userContentController:didReceiveScriptMessage:]):
1340         (TEST):
1341         * TestWebKitAPI/Tests/WebKitCocoa/opendatabase-always-exists.html: Added.
1342
1343 2019-06-21  Jiewen Tan  <jiewen_tan@apple.com>
1344
1345         WebPageProxy::loadData should accept ShouldOpenExternalURLsPolicy
1346         https://bugs.webkit.org/show_bug.cgi?id=199114
1347         <rdar://problem/51671674>
1348
1349         Reviewed by Youenn Fablet.
1350
1351         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
1352         (-[TestSOAuthorizationNavigationDelegate init]):
1353         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1354         (configureSOAuthorizationWebView):
1355         (TestWebKitAPI::TEST):
1356
1357 2019-06-21  Youenn Fablet  <youenn@apple.com>
1358
1359         WebPageProxy should use the right path for sandbox extension
1360         https://bugs.webkit.org/show_bug.cgi?id=198902
1361         <rdar://problem/50772810>
1362
1363         Reviewed by Geoffrey Garen.
1364
1365         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
1366         (TEST):
1367         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1368
1369 2019-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
1370
1371         [WPE][GTK] Bump minimum versions of GLib, GTK, libsoup, ATK, GStreamer, and Cairo
1372         https://bugs.webkit.org/show_bug.cgi?id=199094
1373
1374         Reviewed by Carlos Garcia Campos.
1375
1376         * MiniBrowser/gtk/BrowserTab.c:
1377         (runColorChooserCallback):
1378         (browserTabConstructed):
1379         * TestWebKitAPI/Tests/WebKitGLib/TestResources.cpp:
1380         (testWebViewSyncRequestOnMaxConns):
1381         (beforeAll):
1382         * TestWebKitAPI/Tests/WebKitGLib/TestSSL.cpp:
1383         (testWebSocketTLSErrors):
1384         (beforeAll):
1385         * TestWebKitAPI/glib/WebKitGLib/WebKitTestServer.cpp:
1386         (WebKitTestServer::~WebKitTestServer):
1387         (WebKitTestServer::getWebSocketURIForPath const):
1388         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1389         (WTR::AccessibilityUIElement::rowHeaders const):
1390         (WTR::AccessibilityUIElement::columnHeaders const):
1391         (WTR::AccessibilityUIElement::isAttributeSettable):
1392         (WTR::AccessibilityUIElement::x):
1393         (WTR::AccessibilityUIElement::y):
1394         (WTR::AccessibilityUIElement::width):
1395         (WTR::AccessibilityUIElement::height):
1396         (WTR::AccessibilityUIElement::clickPointX):
1397         (WTR::AccessibilityUIElement::clickPointY):
1398         (WTR::AccessibilityUIElement::intValue const):
1399         (WTR::AccessibilityUIElement::minValue):
1400         (WTR::AccessibilityUIElement::maxValue):
1401         (WTR::stringAtOffset):
1402
1403 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
1404
1405         test-webkitpy is broken on macOS Catalina
1406         https://bugs.webkit.org/show_bug.cgi?id=199078
1407
1408         Reviewed by Jonathan Bedard.
1409
1410         * Scripts/webkitpy/test/main.py: Check if lldb tests are supported before adding them
1411         to the runner.
1412         (main): 
1413         (_supports_building_and_running_lldb_tests): Check if you are running macOS Catalina.
1414
1415 2019-06-20  Dean Johnson  <dean_johnson@apple.com>
1416
1417         Change status to "committer" in contributors.json
1418
1419         Unreviewed.
1420
1421         * Scripts/webkitpy/common/config/contributors.json:
1422
1423 2019-06-20  Alex Christensen  <achristensen@webkit.org>
1424
1425         Add unit test for UIContextMenuConfiguration API
1426         https://bugs.webkit.org/show_bug.cgi?id=199043
1427
1428         Reviewed by Wenson Hsieh.
1429
1430         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1431         * TestWebKitAPI/Tests/WebKitCocoa/ContextMenus.mm: Added.
1432         (-[TestContextMenuUIDelegate webView:contextMenuConfigurationForElement:completionHandler:]):
1433         (-[TestContextMenuUIDelegate webView:contextMenuWillPresentForElement:]):
1434         (-[TestContextMenuUIDelegate webView:contextMenuForElement:willCommitWithAnimator:]):
1435         (-[TestContextMenuUIDelegate webView:contextMenuDidEndForElement:]):
1436         (TEST):
1437         * TestWebKitAPI/cocoa/TestContextMenuDriver.h: Added.
1438         * TestWebKitAPI/cocoa/TestContextMenuDriver.mm: Added.
1439         (-[TestContextMenuDriver delegate]):
1440         (-[TestContextMenuDriver setDelegate:]):
1441         (-[TestContextMenuDriver view]):
1442         (-[TestContextMenuDriver setView:]):
1443         (-[TestContextMenuDriver allowableMovement]):
1444         (-[TestContextMenuDriver setAllowableMovement:]):
1445         (-[TestContextMenuDriver primaryGestureRecognizer]):
1446         (-[TestContextMenuDriver setPrimaryGestureRecognizer:]):
1447         (-[TestContextMenuDriver touchDuration]):
1448         (-[TestContextMenuDriver setTouchDuration:]):
1449         (-[TestContextMenuDriver locationInCoordinateSpace:]):
1450         (-[TestContextMenuDriver cancelInteraction]):
1451         (-[TestContextMenuDriver begin:]):
1452         (-[TestContextMenuDriver clickDown]):
1453         (-[TestContextMenuDriver clickUp]):
1454         (-[TestContextMenuDriver end]):
1455         * TestWebKitAPI/ios/UIKitSPI.h:
1456
1457 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
1458
1459         [ews-app] Status bubble should not turn orange when any build step is skipped
1460         https://bugs.webkit.org/show_bug.cgi?id=199079
1461
1462         Reviewed by Jonathan Bedard.
1463
1464         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1465
1466 2019-06-20  Alex Christensen  <achristensen@webkit.org>
1467
1468         Fix an internal engineering build after r246605
1469        ​https://bugs.webkit.org/show_bug.cgi?id=197800
1470
1471         * TestWebKitAPI/TCPServer.cpp:
1472
1473 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
1474
1475         [ews-build] Triggered builds should use same revision as parent build
1476         https://bugs.webkit.org/show_bug.cgi?id=198289
1477
1478         Reviewed by Jonathan Bedard.
1479
1480         * BuildSlaveSupport/ews-build/steps.py:
1481         (CheckOutSpecificRevision): Build step to checkout specific revision.
1482         (CheckOutSpecificRevision.doStepIf): Run this step only if ews_revision property is set.
1483         (CheckOutSpecificRevision.hideStepIf): Hide this step when it is skipped.
1484         (CheckOutSpecificRevision.start): Run appropriate git command.
1485         (Trigger.propertiesToPassToTriggers): Pass ews_revision property to triggered builds, so that triggered
1486         builds use same revision as parent build.
1487         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1488         * BuildSlaveSupport/ews-build/factories.py:
1489         (Factory.__init__): Added CheckOutSpecificRevision step.
1490
1491 2019-06-20  Aakash Jain  <aakash_jain@apple.com>
1492
1493         [ews-build] Add unit tests for AnalyzeCompileWebKitResults
1494         https://bugs.webkit.org/show_bug.cgi?id=199073
1495
1496         Reviewed by Jonathan Bedard.
1497
1498         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for AnalyzeCompileWebKitResults.
1499
1500 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
1501
1502         [GTK] Enable navigation swipe layout tests
1503         https://bugs.webkit.org/show_bug.cgi?id=198995
1504
1505         Reviewed by Michael Catanzaro.
1506
1507         Add a way for tests to enable and then control swipe gesture on GTK.
1508
1509         * TestRunnerShared/UIScriptContext/UIScriptController.cpp: Hide
1510         empty implementations of beginBackSwipe() and completeBackSwipe() for GTK.
1511         * WebKitTestRunner/PlatformGTK.cmake:
1512         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
1513         (WTR::PlatformWebView::setNavigationGesturesEnabled): Implemented.
1514         * WebKitTestRunner/gtk/UIScriptControllerGtk.cpp: Added.
1515         (WTR::UIScriptController::beginBackSwipe):
1516         (WTR::UIScriptController::completeBackSwipe):
1517
1518 2019-06-20  Alexander Mikhaylenko  <exalm7659@gmail.com>
1519
1520         [GTK] HTTP layout tests don't run in flatpak
1521         https://bugs.webkit.org/show_bug.cgi?id=199067
1522
1523         Reviewed by Michael Catanzaro.
1524
1525         Stop bind mounting /app/lib/perl to /etc/perl because Perl doesn't actually
1526         check that path. Instead, add /app/lib/perl to Apache config directly.
1527
1528         /usr/manifest.json file is not guaranteed to exist in sandbox, check for
1529         /.flatpak-info instead.
1530
1531         * Scripts/webkitpy/port/base.py:
1532         (Port._is_flatpak):
1533         (Port._in_flatpak_sandbox):
1534         * flatpak/flatpakutils.py:
1535         (WebkitFlatpak.run_in_sandbox):
1536         (is_sandboxed):
1537
1538 2019-06-18  Darin Adler  <darin@apple.com>
1539
1540         Tidy up the remaining bits of the AtomicString to AtomString rename
1541         https://bugs.webkit.org/show_bug.cgi?id=198990
1542
1543         Reviewed by Michael Catanzaro.
1544
1545         * Scripts/do-webcore-rename: Removed already-done renames.
1546         * TestWebKitAPI/Tests/WTF/StringImpl.cpp: Rename one use of "atomic".
1547
1548 2019-06-20  Carlos Garcia Campos  <cgarcia@igalia.com>
1549
1550         [GTK] Remove support for GTK2 plugins
1551         https://bugs.webkit.org/show_bug.cgi?id=199065
1552
1553         Reviewed by Sergio Villar Senin.
1554
1555         * EWSTools/ubuntu-ews-packages:
1556         * TestWebKitAPI/PlatformGTK.cmake:
1557         * WebKitTestRunner/PlatformGTK.cmake:
1558         * flatpak/org.webkit.GTK.yaml:
1559         * gtk/install-dependencies:
1560
1561 2019-06-19  Yusuke Suzuki  <ysuzuki@apple.com>
1562
1563         [bmalloc] IsoHeap's initialization is racy with IsoHeap::isInitialized
1564         https://bugs.webkit.org/show_bug.cgi?id=199053
1565
1566         Reviewed by Saam Barati.
1567
1568         Added a test stressing IsoHeap with multiple threads.
1569
1570         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
1571         (assertHasObjects):
1572         (assertHasOnlyObjects):
1573         (assertClean):
1574         (TEST):
1575
1576 2019-06-19  Zalan Bujtas  <zalan@apple.com>
1577
1578         [LFC] Expand tests coverage (1126 new tests -> 2324).
1579
1580         * LayoutReloaded/misc/LFC-passing-tests.txt:
1581
1582 2019-06-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1583
1584         Add WTF::crossThreadCopy(T&&) to utilize String::isolatedCopy() &&
1585         https://bugs.webkit.org/show_bug.cgi?id=198957
1586
1587         Reviewed by Alex Christensen.
1588
1589         * TestWebKitAPI/CMakeLists.txt:
1590         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1591         * TestWebKitAPI/Tests/WTF/CrossThreadCopier.cpp: Added.
1592
1593 2019-06-19  Keith Rollin  <krollin@apple.com>
1594
1595         Relocate some test tools in non-mac builds
1596         https://bugs.webkit.org/show_bug.cgi?id=198984
1597         <rdar://problem/51873261>
1598
1599         Reviewed by Andy Estes.
1600
1601         The tools DumpRenderTree, WebKitTestRunner, LayoutTestHelper, and
1602         TestNetscapePlugin get created in
1603         WebKit.framework/Versions/A/Resources on non-mac builds. This is
1604         incorrect, as those bundles are shallow bundles that don't use the
1605         Versions hierarchy. Instead, store these files directly in
1606         WebKit.framework.
1607
1608         Note that getting rid of just the "Versions/A" path components and
1609         putting the files in WebKit.framework/Resources doesn't work as
1610         `codesign` treats the result as an invalid layout.
1611
1612         The work in this patch involves changing the definition of the custom
1613         build variable WEBKIT_FRAMEWORK_RESOURCES_PATH. The standard build
1614         variable INSTALL_PATH is defined in terms of this variable. In order
1615         to increase visiblity into this relationship, move both of these
1616         variables into .xcconfig files if they weren't already. This
1617         refactoring was done in a way to be the least disruptive and most
1618         compatible with the previous definitions, even at the cost of being
1619         repetitive.
1620
1621         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1622         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1623         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
1624         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
1625         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
1626         * WebKitTestRunner/Configurations/BaseTarget.xcconfig:
1627
1628 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
1629
1630         [ews-build] Patch link should open the pretty patch
1631         https://bugs.webkit.org/show_bug.cgi?id=199031
1632
1633         Reviewed by Jonathan Bedard.
1634
1635         * BuildSlaveSupport/ews-build/steps.py:
1636         (ConfigureBuild.getPatchURL): Use the prettypatch url for patch.
1637
1638 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
1639
1640         [ews-build] Add step to analyze Compile WebKit failures
1641         https://bugs.webkit.org/show_bug.cgi?id=199025
1642
1643         Reviewed by Jonathan Bedard.
1644
1645         * BuildSlaveSupport/ews-build/steps.py:
1646         (CompileWebKit.evaluateCommand): Add AnalyzeCompileWebKitResults step.
1647         (CompileWebKitToT): set haltOnFailure to False since we need to run AnalyzeCompileWebKitResults step.
1648         (AnalyzeCompileWebKitResults): Class to analyze compile webkit steps results.
1649         (AnalyzeCompileWebKitResults.start): If ToT fails to build, retry the build, else marked the build as failed. Note that
1650         this step is run only when compile-webkit failed.
1651
1652 2019-06-19  Aakash Jain  <aakash_jain@apple.com>
1653
1654         [ews-build] Send email notifications for failures
1655         https://bugs.webkit.org/show_bug.cgi?id=198919
1656
1657         Reviewed by Jonathan Bedard.
1658
1659         * BuildSlaveSupport/ews-build/master.cfg:
1660
1661 2019-06-19  Alex Christensen  <achristensen@webkit.org>
1662
1663         Add a unit test for client certificate authentication
1664         https://bugs.webkit.org/show_bug.cgi?id=197800
1665
1666         Reviewed by Youenn Fablet.
1667
1668         Make better abstractions for reading and writing from/to TCPServer.
1669         Add a unit test that causes a client certificate authentication challenge to happen.
1670
1671         * TestWebKitAPI/TCPServer.cpp:
1672         (TestWebKitAPI::TCPServer::TCPServer):
1673         (TestWebKitAPI::TCPServer::read):
1674         (TestWebKitAPI::TCPServer::write):
1675         (TestWebKitAPI::TCPServer::respondWithChallengeThenOK):
1676         (TestWebKitAPI::TCPServer::respondWithOK):
1677         * TestWebKitAPI/TCPServer.h:
1678         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
1679         (credentialWithIdentity):
1680         (-[ChallengeDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1681         (TEST):
1682         (-[ClientCertificateDelegate webView:didFinishNavigation:]):
1683         (-[ClientCertificateDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1684         (-[ClientCertificateDelegate challengeCount]):
1685         (TestWebKitAPI::TEST):
1686         (respondWithChallengeThenOK): Deleted.
1687         (credentialWithIdentityAndKeychainPath): Deleted.
1688         * TestWebKitAPI/Tests/WebKitCocoa/PDFLinkReferrer.mm:
1689         (TEST):
1690         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1691         (TestWebKitAPI::TEST):
1692         * TestWebKitAPI/Tests/WebKitCocoa/WKNavigationResponse.mm:
1693         (TEST):
1694         (readRequest): Deleted.
1695         (writeResponse): Deleted.
1696         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1697         (TestWebKitAPI::TEST):
1698         (TestWebKitAPI::respondWithChallengeThenOK): Deleted.
1699
1700 2019-06-19  Michael Catanzaro  <mcatanzaro@igalia.com>
1701
1702         Unreviewed, fix build warnings in TestWebKitAPIInjectedBundle
1703
1704         System headers are being included without SYSTEM again here.
1705
1706         * TestWebKitAPI/PlatformGTK.cmake:
1707
1708 2019-06-18  Yusuke Suzuki  <ysuzuki@apple.com>
1709
1710         [JSC] JSLock should be WebThread aware
1711         https://bugs.webkit.org/show_bug.cgi?id=198911
1712
1713         Reviewed by Geoffrey Garen.
1714
1715         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1716         * TestWebKitAPI/Tests/WebKitLegacy/ios/JSLockTakesWebThreadLock.mm: Added.
1717         (TestWebKitAPI::TEST):
1718
1719 2019-06-18  Keith Miller  <keith_miller@apple.com>
1720
1721         webkit-patch should allow for a bugzilla url not just bugzilla id
1722         https://bugs.webkit.org/show_bug.cgi?id=198972
1723
1724         Reviewed by Dewei Zhu.
1725
1726         When prompting for a bugzilla id or a new title we should also
1727         allow for a bugzilla url.
1728
1729         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
1730         (PromptForBugOrTitle.run):
1731
1732 2019-06-18  David Quesada  <david_quesada@apple.com>
1733
1734         REGRESSION: _WKDownload.OriginatingWebView and _WKDownload.CrashAfterDownloadDidFinishWhenDownloadProxyHoldsTheLastRefOnWebProcessPool failing
1735         https://bugs.webkit.org/show_bug.cgi?id=198954
1736         rdar://problem/51711556
1737
1738         Reviewed by Alex Christensen.
1739
1740         For these tests, kill the web process after the download starts. This makes the deallocation
1741         of the download-originating web views, which these tests depend on, more reliable.
1742
1743         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
1744         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
1745         (-[WaitUntilDownloadCanceledDelegate _downloadDidStart:]):
1746
1747 2019-06-18  Dan Bernstein  <mitz@apple.com>
1748
1749         Revert workaround for bug 198904 from run-webkit-archive
1750         https://bugs.webkit.org/show_bug.cgi?id=198931
1751
1752         Reviewed by Alexey Proskuryakov.
1753
1754         Reverted r245965, now that the load commands in the XPC service binaries make them correctly
1755         pick up the built frameworks.
1756
1757         * WebKitArchiveSupport/run-webkit-archive:
1758         (set_dyld_framework_path):
1759
1760 2019-06-17  Sihui Liu  <sihui_liu@apple.com>
1761
1762         -[WKWebsiteDataStore removeDataOfTypes:modifiedSince:completionHandler:] doesn't delete _WKWebsiteDataTypeCredentials
1763         https://bugs.webkit.org/show_bug.cgi?id=198854
1764         <rdar://problem/51386058>
1765
1766         Reviewed by Geoffrey Garen.
1767
1768         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm:
1769         (TestWebKitAPI::TEST):
1770
1771 2019-06-17  Adrian Perez de Castro  <aperez@igalia.com>
1772
1773         [Flatpak][JHBuild] Update build environments to use WPEBackend-fdo 1.3.1
1774         https://bugs.webkit.org/show_bug.cgi?id=198831
1775
1776         Reviewed by Žan Doberšek.
1777
1778         * flatpak/org.webkit.WPEModules.yaml: Bump versions of libwpe and WPEBackend-fdo to 1.3.1
1779         * wpe/jhbuild.modules: Ditto.
1780         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
1781         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
1782
1783 2019-06-17  Jiewen Tan  <jiewen_tan@apple.com>
1784
1785         Move SOAuthorization from WebKitAdditions to WebKit
1786         https://bugs.webkit.org/show_bug.cgi?id=198874
1787         <rdar://problem/47573431>
1788
1789         Reviewed by Brent Fulgham.
1790
1791         This patch moves all SOAuthorization tests from WebKitAdditions to WebKit.
1792
1793         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1794         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1795         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm: Added.
1796         (-[TestSOAuthorizationNavigationDelegate init]):
1797         (-[TestSOAuthorizationNavigationDelegate webView:didFinishNavigation:]):
1798         (-[TestSOAuthorizationNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1799         (-[TestSOAuthorizationNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1800         (-[TestSOAuthorizationViewController viewDidAppear]):
1801         (-[TestSOAuthorizationViewController viewDidDisappear]):
1802         (overrideCanPerformAuthorizationWithURL):
1803         (overrideSetDelegate):
1804         (overrideBeginAuthorizationWithURL):
1805         (overrideCancelAuthorization):
1806         (overrideAddObserverForName):
1807         (overrideIsURLFromAppleOwnedDomain):
1808         (resetState):
1809         (configureSOAuthorizationWebView):
1810         (generateHtml):
1811         (checkAuthorizationOptions):
1812         (TestWebKitAPI::TEST):
1813
1814 2019-06-17  Brent Fulgham  <bfulgham@apple.com>
1815
1816         Ensure ITP state is relayed to Network Process on restart
1817         https://bugs.webkit.org/show_bug.cgi?id=198797
1818         <rdar://problem/51646944>
1819
1820         Reviewed by Youenn Fablet.
1821
1822         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1823         (cleanupITPDatabase): Added.
1824         (TEST:EnableDisableITP): Update to use cleanup method.
1825         (TEST:NetworkProcessRestart): Added.
1826
1827 2019-06-17  Aakash Jain  <aakash_jain@apple.com>
1828
1829         New EWS can't process patches larger than 640kb
1830         https://bugs.webkit.org/show_bug.cgi?id=198851
1831
1832         Reviewed by Jonathan Bedard.
1833
1834         * BuildSlaveSupport/ews-build/master.cfg: Increase the patch size limit to 100 MB.
1835
1836 2019-06-17  Jonathan Bedard  <jbedard@apple.com>
1837
1838         webkitpy: Add macOS Catalina, iOS 13
1839         https://bugs.webkit.org/show_bug.cgi?id=198492
1840
1841         Reviewed by Alexey Proskuryakov.
1842
1843         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina.png: Added.
1844         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Catalina@2x.png: Added.
1845         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13.png: Added.
1846         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13@2x.png: Added.
1847         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator.png: Added.
1848         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS13Simulator@2x.png: Added.
1849         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
1850         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1851         * BuildSlaveSupport/ews-build/steps.py:
1852         * Scripts/webkitpy/common/version_name_map.py:
1853         * Scripts/webkitpy/common/version_name_map_unittest.py:
1854         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1855         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1856
1857 2019-06-17  Carlos Garcia Campos  <cgarcia@igalia.com>
1858
1859         Unreviewed. [GTK] Bump WPEBackend-fdo requirement to 1.3.1
1860
1861         * gtk/jhbuild.modules:
1862         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Removed.
1863         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Removed.
1864
1865 2019-06-16  Zalan Bujtas  <zalan@apple.com>
1866
1867         [LFC] Expand tests coverage (325 new tests -> 1198).
1868
1869         * LayoutReloaded/misc/LFC-passing-tests.txt:
1870
1871 2019-06-16  Darin Adler  <darin@apple.com>
1872
1873         Rename AtomicString to AtomString
1874         https://bugs.webkit.org/show_bug.cgi?id=195276
1875
1876         Reviewed by Michael Catanzaro.
1877
1878         * many files: Let do-webcore-rename do the renaming.
1879
1880         * Scripts/do-webcore-rename: Updated with a list of all the identifiers
1881         that mention "atomic string" and changed them to instead say "atom string".
1882
1883 2019-06-16  Zalan Bujtas  <zalan@apple.com>
1884
1885         [LFC] Unreviewed test gardening.
1886
1887         Unsupported alignments.
1888
1889         fast/inline/absolute-positioned-inline-in-centred-block.html -align: center
1890         fast/borders/empty-outline-border-assert.html -vertical-align: super
1891         css2.1/20110323/vertical-align-boxes-001.htm - vertical-align: middle
1892
1893         * LayoutReloaded/misc/LFC-passing-tests.txt:
1894
1895 2019-06-15  Youenn Fablet  <youenn@apple.com>
1896
1897         WPT test importer WTR option reader should not throw if the file is not proper UTF-8
1898         https://bugs.webkit.org/show_bug.cgi?id=198780
1899
1900         Reviewed by Jonathan Bedard.
1901
1902         * Scripts/webkitpy/w3c/test_importer.py:
1903         (TestImporter._webkit_test_runner_options):
1904         In case the test file cannot be read as text, consider that there is no WTR option.
1905
1906 2019-06-14  Youenn Fablet  <youenn@apple.com>
1907
1908         WebResourceLoadStatisticsStore should not use its network session if invalidated
1909         https://bugs.webkit.org/show_bug.cgi?id=198814
1910
1911         Reviewed by Geoffrey Garen.
1912
1913         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1914         (TEST):
1915
1916 2019-06-14  Youenn Fablet  <youenn@apple.com>
1917
1918         import-w3c-tests should respect WEBKIT_OUTPUTDIR
1919         https://bugs.webkit.org/show_bug.cgi?id=198682
1920         <rdar://problem/51536931>
1921
1922         Reviewed by Jonathan Bedard.
1923
1924         Check for WEBKIT_OUTPUTDIR environment variable to compute the w3c-tests folder.
1925         Made some refactoring to also teach WPTPaths users about WEBKIT_OUTPUTDIR.
1926
1927         * Scripts/webkitpy/common/webkit_finder.py:
1928         (WebKitFinder.path_from_webkit_outputdir):
1929         * Scripts/webkitpy/w3c/common.py:
1930         (WPTPaths):
1931         (WPTPaths.checkout_directory):
1932         (WPTPaths.wpt_checkout_path):
1933         * Scripts/webkitpy/w3c/test_importer.py:
1934         (TestImporter.__init__):
1935         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1936         (test_checkout_directory):
1937
1938 2019-06-13  Antoine Quint  <graouts@apple.com>
1939
1940         REGRESSION (r246103) [ Mojave+ WK1 ] Layout Test scrollbars/scrollbar-iframe-click-does-not-blur-content.html is timing out
1941         https://bugs.webkit.org/show_bug.cgi?id=198800
1942         <rdar://problem/51679634>
1943
1944         Reviewed by Tim Horton.
1945
1946         We didn't detect an NSScroller in a sub-frame due to WebHTMLView's implementation of -[NSView hitTest:]. We now use a private method
1947         which lets us use the default implementation and correctly returns an NSScroller in a sub-frame.
1948
1949         * DumpRenderTree/mac/EventSendingController.mm:
1950         (eventPressedMouseButtonsSwizzlerForViewAndEvent):
1951         (-[EventSendingController mouseDown:withModifiers:]):
1952         (-[EventSendingController mouseUp:withModifiers:]):
1953         (-[EventSendingController mouseMoveToX:Y:]):
1954
1955 2019-06-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1956
1957         [WinCairo][WebKitTestRunner] pixel image dump outputs blank images
1958         https://bugs.webkit.org/show_bug.cgi?id=198820
1959
1960         Reviewed by Ross Kirsling.
1961
1962         WebView window paints nothing because it is moved out of the
1963         screen. Send WM_PRINT with memory DC instead of WM_PAINT as well
1964         as DumpRenderTree does.
1965
1966         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
1967         (WTR::PlatformWebView::windowSnapshotImage): Send WM_PRINT instead of BitBlt.
1968
1969 2019-06-13  Tim Horton  <timothy_horton@apple.com>
1970
1971         Make it possible for validate-committer-lists to dump a mailmap file
1972         https://bugs.webkit.org/show_bug.cgi?id=198517
1973
1974         Reviewed by Simon Fraser.
1975
1976         Mailmaps wildly improve the output of various Git tools, including
1977         `git shortlog -sne`, mapping committers to our canonical name/email pair.
1978
1979         * Scripts/validate-committer-lists:
1980         (CommitterListFromGit):
1981         (CommitterListBugzillaChecker.print_committers_with_invalid_bugzilla_emails):
1982         Add some missing legacy username mappings.
1983
1984         (dump_mailmap):
1985         (dump_mailmap.format_email):
1986         (dump_mailmap.format_email_with_gitsvn_uuid):
1987         (dump_mailmap.map_emails_to_legacy_username):
1988         (main):
1989         Add `validate-committer-lists --dump-mailmap`, which generates
1990         one given committers.json and the existing mapping of legacy username
1991         to email addresses that exists in validate-committer-lists.
1992
1993 2019-06-12  Aakash Jain  <aakash_jain@apple.com>
1994
1995         Replace double-quotes with single quotes in loadConfig.py
1996         https://bugs.webkit.org/show_bug.cgi?id=198792
1997
1998         Reviewed by Jonathan Bedard.
1999
2000         * BuildSlaveSupport/ews-build/loadConfig.py:
2001         * BuildSlaveSupport/ews-build/steps_unittest.py:
2002
2003 22019-06-11  Brent Fulgham  <bfulgham@apple.com>
2004
2005         Add mechanism and test case to check if ITP is active
2006         https://bugs.webkit.org/show_bug.cgi?id=198694
2007         <rdar://problem/51557704>
2008
2009         Reviewed by Youenn Fablet.
2010
2011         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2012         (TEST):
2013
2014 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2015
2016         [WPE][GTK] Deprecate WebSQL APIs
2017         https://bugs.webkit.org/show_bug.cgi?id=195011
2018
2019         Reviewed by Carlos Garcia Campos.
2020
2021         * MiniBrowser/gtk/main.c:
2022         (gotWebsiteDataCallback):
2023         * TestWebKitAPI/Tests/WebKitGLib/TestWebsiteData.cpp:
2024         (testWebsiteDataConfiguration):
2025         (testWebsiteDataEphemeral):
2026         (testWebsiteDataDatabases):
2027
2028 2019-06-12  Michael Catanzaro  <mcatanzaro@igalia.com>
2029
2030         [WPE][GTK] Enable hyperlink auditing
2031         https://bugs.webkit.org/show_bug.cgi?id=197845
2032
2033         Reviewed by Carlos Garcia Campos.
2034
2035         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2036         (testWebKitSettings):
2037
2038 2019-06-11  Keith Rollin  <krollin@apple.com>
2039
2040         Open up xcfilelist processing to more platforms
2041         https://bugs.webkit.org/show_bug.cgi?id=198675
2042         <rdar://problem/51533238>
2043
2044         Reviewed by Jonathan Bedard.
2045
2046         Now that it's been tested, add AppleTV{OS,Simulator} to the set of
2047         platforms on which to perform xcfilelist generation/updating.
2048
2049         * Scripts/webkitpy/generate_xcfilelists_lib/generators.py:
2050         (JavaScriptCoreGenerator):
2051         (WebCoreGenerator):
2052         (WebKitGenerator):
2053
2054 2019-06-11  Jonathan Bedard  <jbedard@apple.com>
2055
2056         webkitpy: Fix device ASan reporting, add testing for report configurations
2057         https://bugs.webkit.org/show_bug.cgi?id=198756
2058
2059         Reviewed by Aakash Jain.
2060
2061         ASan results were reporting an incorrect style. This indicates we need to be testing this upload
2062         configuration thoroughly in webkitpy.
2063
2064         * Scripts/webkitpy/port/config.py:
2065         (clear_cached_configuration): Clearing configurations should clear the ASan cache as well.
2066         * Scripts/webkitpy/port/device_port.py:
2067         (DevicePort.configuration_for_upload): Add ASan as style.
2068         * Scripts/webkitpy/port/ios_device_unittest.py:
2069         (IOSDeviceTest):
2070         (IOSDeviceTest.test_default_upload_configuration):
2071         * Scripts/webkitpy/port/ios_simulator_unittest.py:
2072         (IOSSimulatorTest.test_default_upload_configuration):
2073         * Scripts/webkitpy/port/mock_drt_unittest.py:
2074         (MockDRTPortTest.test_asan_upload_configuration):
2075         * Scripts/webkitpy/port/port_testcase.py:
2076         (test_default_upload_configuration):
2077         (test_debug_upload_configuration):
2078         (test_asan_upload_configuration):
2079         (test_guard_malloc_configuration):
2080         * Scripts/webkitpy/port/watch_simulator_unittest.py:
2081         (WatchSimulatorTest):
2082         (WatchSimulatorTest.test_default_upload_configuration):
2083
2084 2019-06-11  Michael Catanzaro  <mcatanzaro@igalia.com>
2085
2086         tu-berlin university email web interface (Outlook Web App) goes directly to the light version instead of the normal web app
2087         https://bugs.webkit.org/show_bug.cgi?id=198749
2088
2089         Reviewed by Carlos Garcia Campos.
2090
2091         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2092         (TestWebKitAPI::TEST):
2093
2094 2019-06-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2095
2096         Quotes are always inserted as smart quotes on stackblitz.com, causing compilation errors
2097         https://bugs.webkit.org/show_bug.cgi?id=198735
2098         <rdar://problem/51557159>
2099
2100         Reviewed by Megan Gardner.
2101
2102         Add a test to verify that spellcheck="false" disables smart quotes and dashes, but any other value defers to the
2103         user's preferences by using UITextSmartQuotesTypeDefault and UITextSmartDashesTypeDefault.
2104
2105         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2106         (TestWebKitAPI::TEST):
2107
2108 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
2109
2110         Unreviewed, add myself to the JavaScriptCore watchlist.
2111
2112         * Scripts/webkitpy/common/config/watchlist:
2113
2114 2019-06-11  Tadeu Zagallo  <tzagallo@apple.com>
2115
2116         Unreviewed, change my status to be a WebKit reviewer
2117
2118         * Scripts/webkitpy/common/config/contributors.json:
2119
2120 2019-06-11  Carlos Garcia Campos  <cgarcia@igalia.com>
2121
2122         [WPE] Use new exported image API from fdo backend
2123         https://bugs.webkit.org/show_bug.cgi?id=198558
2124
2125         Reviewed by Philippe Normand.
2126
2127         * WebKitTestRunner/PlatformWPE.cmake: Do not find fdo backend and libxkb again here, since WKTR depends on
2128         WPEToolingBackends that already depends on fdo backend and libxkb
2129         * wpe/backends/CMakeLists.txt: Bump fdo requirements to 1.3.0 version.
2130         * wpe/backends/HeadlessViewBackend.cpp:
2131         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
2132         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
2133         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
2134         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
2135         * wpe/backends/HeadlessViewBackend.h:
2136         * wpe/backends/ViewBackend.cpp:
2137         (WPEToolingBackends::ViewBackend::initialize):
2138         * wpe/backends/ViewBackend.h:
2139         * wpe/backends/WindowViewBackend.cpp:
2140         (WPEToolingBackends::WindowViewBackend::displayBuffer):
2141         * wpe/backends/WindowViewBackend.h:
2142
2143 2019-06-10  Dewei Zhu  <dewei_zhu@apple.com>
2144
2145         Extend run-benchmark to allow diagnosing before closing browser on test failure.
2146         https://bugs.webkit.org/show_bug.cgi?id=198729
2147
2148         Reviewed by Ryosuke Niwa.
2149
2150         Add '--diagnose-directory' option to store diagnose information when test failed.
2151
2152         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2153         (BenchmarkRunner.__init__):
2154         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2155         (BrowserDriver.diagnose_test_failure): Add default no-op function to base class.
2156         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Added '--diagnose-directory' option.
2157         (parse_args):
2158         (run_benchmark_plan):
2159         * Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
2160         (WebDriverBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
2161         * Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
2162         (WebServerBenchmarkRunner.__init__):
2163         (WebServerBenchmarkRunner._run_one_test): Added 'diagnose_test_failure' invocation on test failure.
2164
2165 2019-06-10  Sam Weinig  <weinig@apple.com>
2166
2167         Remove Dashboard support
2168         https://bugs.webkit.org/show_bug.cgi?id=198615
2169
2170         Reviewed by Ryosuke Niwa.
2171
2172         * DumpRenderTree/TestRunner.cpp:
2173         (TestRunner::staticFunctions):
2174         (setUseDashboardCompatibilityModeCallback): Deleted.
2175         * DumpRenderTree/TestRunner.h:
2176         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2177         * DumpRenderTree/mac/DumpRenderTree.mm:
2178         (resetWebViewToConsistentStateBeforeTesting):
2179         * DumpRenderTree/mac/TestRunnerMac.mm:
2180         (TestRunner::setUseDashboardCompatibilityMode): Deleted.
2181         * ImageDiff/cg/Configurations/Base.xcconfig:
2182         * Scripts/webkitperl/FeatureList.pm:
2183         * TestWebKitAPI/Configurations/Base.xcconfig:
2184         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2185         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2186         * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Removed.
2187         * WebKitTestRunner/Configurations/Base.xcconfig:
2188         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2189         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2190         (WTR::InjectedBundle::beginTesting):
2191         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2192         (WTR::TestRunner::setUseDashboardCompatibilityMode): Deleted.
2193         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2194
2195 2019-06-10  Alexey Proskuryakov  <ap@apple.com>
2196
2197         Tool binaries like WebKitTestRunner have too aggressive stripping, resulting in non-symbolicated crash logs
2198         https://bugs.webkit.org/show_bug.cgi?id=198616
2199         rdar://problem/36386573
2200
2201         Reviewed by David Kilzer.
2202
2203         Adding an explicit STRIP_STYLE to appropriate xcconfigs.
2204
2205         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2206         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2207         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2208         * ImageDiff/cg/Configurations/ImageDiff.xcconfig:
2209         * MiniBrowser/Configurations/MiniBrowser.xcconfig:
2210         * MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig:
2211         * TestWebKitAPI/Configurations/TestWTF.xcconfig:
2212         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2213         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2214         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig:
2215
2216 2019-06-10  Wenson Hsieh  <wenson_hsieh@apple.com>
2217
2218         [iOS] fast/xsl tests are flaky when run after certain viewport shrink-to-fit tests
2219         https://bugs.webkit.org/show_bug.cgi?id=198699
2220         <rdar://problem/50501718>
2221
2222         Reviewed by Simon Fraser.
2223
2224         Add logic to platformResetPreferencesToConsistentValues, to reset the "ShouldIgnoreMetaViewport" preference.
2225         While this is already being adjusted in platformConfigureViewForTest using the correct, TestOptions, this might
2226         happen too late, allowing the shrink-to-fit-content heuristic to unexpectedly kick in on tests where testing
2227         viewport parameters are used.
2228
2229         * WebKitTestRunner/ios/TestControllerIOS.mm:
2230         (WTR::TestController::platformResetPreferencesToConsistentValues):
2231         (WTR::TestController::platformConfigureViewForTest):
2232
2233 2019-06-10  Yusuke Suzuki  <ysuzuki@apple.com>
2234
2235         [JSC] UnlinkedCodeBlock should be eventually jettisoned in VM mini mode
2236         https://bugs.webkit.org/show_bug.cgi?id=198023
2237
2238         Reviewed by Saam Barati.
2239
2240         * Scripts/run-jsc-stress-tests:
2241
2242 2019-06-10  Timothy Hatcher  <timothy@apple.com>
2243
2244         Integrate dark mode support for iOS.
2245         https://bugs.webkit.org/show_bug.cgi?id=198687
2246         rdar://problem/51545643
2247
2248         Reviewed by Tim Horton.
2249
2250         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2251
2252 2019-06-10  Jonathan Bedard  <jbedard@apple.com>
2253
2254         webkitpy: xcrun simctl spawn *** launchctl print system output is not utf-8
2255         https://bugs.webkit.org/show_bug.cgi?id=198723
2256
2257         Reviewed by Aakash Jain.
2258
2259         * Scripts/webkitpy/xcode/simulated_device.py:
2260         (SimulatedDevice.is_usable): Do not decode 'print system' output, it's already ASCII.
2261
2262 2019-06-10  Sihui Liu  <sihui_liu@apple.com>
2263
2264         [WKHTTPCookieStore getAllCookies:] may return duplicate cookies
2265         https://bugs.webkit.org/show_bug.cgi?id=198635
2266         <rdar://problem/46010232>
2267
2268         Reviewed by Ryosuke Niwa.
2269
2270         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2271         (areCookiesEqual):
2272         (TEST):
2273
2274 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
2275
2276         [JHBuild] Bump shared-mime-info to version ≥ 1.6
2277         https://bugs.webkit.org/show_bug.cgi?id=198714
2278
2279         Reviewed by Carlos Garcia Campos.
2280
2281         * gtk/jhbuild.modules: Bump shared-mime-info version to 1.10.
2282         * gtk/patches/shared-mime-info-xht-glob.patch: Removed.
2283         * gtk/patches/shared-mime-info-xhtml-magic.patch: Removed.
2284
2285 2019-06-10  Philippe Normand  <pnormand@igalia.com>
2286
2287         [WPE][Qt] Port to new wpe_fdo_egl_exported_image API
2288         https://bugs.webkit.org/show_bug.cgi?id=198713
2289
2290         Reviewed by Carlos Garcia Campos.
2291
2292         * flatpak/org.webkit.WPEModules.yaml: Include wpebackend-fdo
2293         patches currently used in JHBuild.
2294
2295 2019-06-10  Adrian Perez de Castro  <aperez@igalia.com>
2296
2297         [GTK][Flatpak] webkit-build fails due to missing libwpe in Flatpak environment
2298         https://bugs.webkit.org/show_bug.cgi?id=198711
2299
2300         Reviewed by Philippe Normand.
2301
2302         * flatpak/org.webkit.GTK.yaml: Also include modules from
2303         org.webkit.WPEModules.yaml, which brings in libwpe and WPEBackend-fdo
2304
2305 2019-06-10  Zan Dobersek  <zdobersek@igalia.com>
2306
2307         Unreviewed follow-up to r246148. Add another WPEBackend-fdo patch that
2308         avoids double-free condition that's causing bots to exit early.
2309
2310         * gtk/jhbuild.modules:
2311         * gtk/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
2312         * wpe/jhbuild.modules:
2313         * wpe/wpebackend-fdo-view-backend-exportable-private-don-t-double-free-ca.patch: Added.
2314
2315 2019-06-09  Fujii Hironori  <Hironori.Fujii@sony.com>
2316
2317         [WinCairo][MiniBrowser] Disable MediaCapabilities until it's ready
2318         https://bugs.webkit.org/show_bug.cgi?id=198655
2319
2320         Reviewed by Ross Kirsling.
2321
2322         MediaCapabilities is enabled by default for WK2, but WinCairo
2323         doesn't implemented yet. Disable it in MiniBrowser.
2324
2325         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2326         (WebKitBrowserWindow::create):
2327
2328 2019-06-08  Wenson Hsieh  <wenson_hsieh@apple.com>
2329
2330         [iOS] The default application name for user agent when requesting desktop content is still "Mobile/15E148"
2331         https://bugs.webkit.org/show_bug.cgi?id=198693
2332         <rdar://problem/51555371>
2333
2334         Reviewed by Tim Horton.
2335
2336         Augment an existing API test to exercise three additional scenarios:
2337             -   The web view configuration's application name is never set; the default should not include
2338                 "Mobile/15E148" in desktop mode.
2339             -   The application name is explicitly set to nil; the default application name should still not include
2340                 "Mobile/15E148".
2341             -   The application name is explicitly set to the default value, "Mobile/15E148". WKWebView should honor
2342                 this when generating the user agent, even in desktop mode.
2343
2344         * TestWebKitAPI/ios/PreferredContentMode.mm:
2345         (TestWebKitAPI::setUpWebViewForPreferredContentModeTestingWithoutNavigationDelegate):
2346         (TestWebKitAPI::setUpWebViewForPreferredContentModeTesting):
2347         (TestWebKitAPI::TEST):
2348
2349 2019-06-08  Zalan Bujtas  <zalan@apple.com>
2350
2351         [LFC] Unreviewed test gardening.
2352
2353         Remove rtl tests. They were mistakenly marked as pass.
2354
2355         * LayoutReloaded/misc/LFC-passing-tests.txt:
2356
2357 2019-06-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
2358
2359         REGRESSION (r244182) [WK1]: Page updates should always scheduleCompositingLayerFlush() immediately
2360         https://bugs.webkit.org/show_bug.cgi?id=198664
2361
2362         Reviewed by Simon Fraser.
2363
2364         Delete repeated entries which were submitted by mistake.
2365
2366         * Tracing/SystemTracePoints.plist:
2367
2368 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2369
2370         Allow clients to vend custom -inputView and -inputAccessoryView by overriding WKWebView methods
2371         https://bugs.webkit.org/show_bug.cgi?id=198631
2372         <rdar://problem/51505431>
2373
2374         Reviewed by Tim Horton.
2375
2376         Add an API test that overrides -[WKWebView inputView] and -[WKWebView inputAccessoryView].
2377
2378         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2379         (-[CustomInputWebView initWithFrame:configuration:inputView:inputAccessoryView:]):
2380         (-[CustomInputWebView inputView]):
2381         (-[CustomInputWebView inputAccessoryView]):
2382         (TestWebKitAPI::TEST):
2383
2384 2019-06-07  Daniel Bates  <dabates@apple.com>
2385
2386         [lldb-webkit] Pretty-print all kinds of Documents
2387         https://bugs.webkit.org/show_bug.cgi?id=198620
2388
2389         Reviewed by Simon Fraser.
2390
2391         Register formatters for all classes derived from WebCore::Document so we get nice summaries
2392         without having to drill down in Xcode- or casting- to the base class, Document.
2393
2394         Older LLDB versions use to do this automatically, but this functionality was removed in newer
2395         versions:
2396             [[
2397                 Warning: previous versions of LLDB defined cascading to mean not only going through typedef
2398                 chains, but also through inheritance chains. This feature has been removed since it
2399                 significantly degrades performance. You need to set up your formatters for every type in
2400                 inheritance chains to which you want the formatter to apply.
2401             ]]
2402             <https://lldb.llvm.org/use/variable.html> (as of 06/06/2019)
2403
2404         * lldb/lldb_webkit.py:
2405         (__lldb_init_module):
2406
2407 2019-06-07  Jonathan Bedard  <jbedard@apple.com>
2408
2409         webkitpy: Support reporting results for uncommon test configurations
2410         https://bugs.webkit.org/show_bug.cgi?id=198662
2411         <rdar://problem/51524128>
2412
2413         Reviewed by Aakash Jain.
2414
2415         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2416         (Manager.run): Override wk1 and wk2 flavors with specified flavor.
2417         * Scripts/webkitpy/port/base.py:
2418         (Port.configuration_for_upload): Set flavor based on options.
2419         * Scripts/webkitpy/results/options.py:
2420         (upload_options): Add result-report-flavor option.
2421         * Scripts/webkitpy/test/main.py:
2422         (Tester._run_tests): Set flavor based on options.
2423
2424 2019-06-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2425
2426         [iOS] At least 6 API tests are failing due to an exception when writing NSAttributedString to the pasteboard
2427         https://bugs.webkit.org/show_bug.cgi?id=198641
2428         <rdar://problem/51266310>
2429
2430         Reviewed by Tim Horton.
2431
2432         Work around a bug in a lower-level framework, which currently prevents NSAttributedStrings from being written to
2433         UIPasteboard by way of -[NSItemProvider registerObject:visibility:]. This is because, when saving a
2434         representation of "public.rtfd" to disk, the default suggested filename (determined using CoreServices APIs
2435         _UTTypeCreateSuggestedFilename and UTTypeCopyDescription) ends up being nil; UIKit then subsequently tries to
2436         append nil as a path component using -URLByAppendingPathComponent:, which throws an exception. This only
2437         reproduces on iOS simulator.
2438
2439         To work around this for the time being, simply avoid writing a representation of "public.rtfd" to disk. This
2440         representation is actually ignored by most clients anyways (including WebKit), in favor of using
2441         "com.apple.flat-rtfd".
2442
2443         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2444         (TestWebKitAPI::TEST):
2445         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2446         (applyWorkaroundToAllowWritingAttributedStringsToItemProviders):
2447         (-[TestWKWebView initWithFrame:configuration:addToWindow:]):
2448
2449 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2450
2451         REGRESSION(r244857): [GTK][WPE] Many tests are no longer run in the bots after r244857
2452         https://bugs.webkit.org/show_bug.cgi?id=198607
2453
2454         Reviewed by Michael Catanzaro.
2455
2456         Since r244857 several test executables are compiled in the base tests directory instead of using their own sub
2457         directory. Our scripts to run the tests rely on the tests location to decide whether to run them or not, or
2458         determine the type of the tests.
2459
2460         * Scripts/run-gtk-tests:
2461         (GtkTestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
2462         (GtkTestRunner._setup_testing_environment): Fix TestWebKitAccessibility directory name.
2463         (GtkTestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
2464         (GtkTestRunner.is_google_test): Ditto.
2465         * Scripts/run-wpe-tests:
2466         (WPETestRunner): Rename TEST_DIRS as TEST_TARGETS and use the executable names for tests not in a subdirectory.
2467         (WPETestRunner.is_glib_test): Use the test name for the ones not using a subdirectory.
2468         (WPETestRunner.is_google_test): Ditto.
2469         * glib/api_test_runner.py:
2470         (TestRunner): Rename TEST_DIRS as TEST_TARGETS.
2471         (TestRunner._get_tests): Handle test targets which can now contain directories and executables.
2472
2473 2019-06-06  Keith Rollin  <krollin@apple.com>
2474
2475         Remove SSL-based tests from TestWebKitAPI on some configurations
2476         https://bugs.webkit.org/show_bug.cgi?id=198551
2477         <rdar://problem/51424996>
2478
2479         Reviewed by Jonathan Bedard.
2480
2481         Not all platforms have SSL handy, so don't include SSL-based tests on
2482         those platforms.
2483
2484         * TestWebKitAPI/TCPServer.cpp:
2485         * TestWebKitAPI/TCPServer.h:
2486         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2487         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
2488         * TestWebKitAPI/config.h:
2489
2490 2019-06-06  Daniel Bates  <dabates@apple.com>
2491
2492         [lldb-webkit] TypeError: cannot concatenate 'str' and 'int' objects when prettify SecurityOrigin with
2493         non-default port number
2494         https://bugs.webkit.org/show_bug.cgi?id=198618
2495
2496         Reviewed by Brent Fulgham.
2497
2498         WebCoreSecurityOriginProvider.port() returns an int data type. We need to explicitly convert this to
2499         a string before we concatenate it with another string when building the string representation
2500         for the WebCore::SecurityOrigin object. Otherwise, Python complains that we are concatenating a str
2501         with an int and we don't get a pretty-printed representation for WebCore::SecurityOrigin.
2502
2503         * lldb/lldb_webkit.py:
2504         (WebCoreSecurityOriginProvider.to_string): Call str() on the port before concatenting it.
2505
2506 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
2507
2508         Remove obsolete TOOLCHAINS overrides from as asan.xcconfig
2509         https://bugs.webkit.org/show_bug.cgi?id=198613
2510
2511         Reviewed by Alexey Proskuryakov.
2512
2513         * asan/asan.xcconfig: XCBuild doesn't support overriding toolchains.
2514
2515 2019-06-06  Jonathan Bedard  <jbedard@apple.com>
2516
2517         webkitpluginhost: Support ASan as a style
2518         https://bugs.webkit.org/show_bug.cgi?id=198586
2519         <rdar://problem/51459088>
2520
2521         Reviewed by Alexey Proskuryakov.
2522
2523         * Scripts/webkitpy/port/base.py:
2524         (Port.configuration_for_upload): Add ASan as a style.
2525         * Scripts/webkitpy/port/config.py:
2526         (Config._read_configuration):
2527         (Config):
2528         (Config.asan): Add property to check if the ASan configuration is active.
2529         * Scripts/webkitpy/port/config_unittest.py:
2530         (ConfigTest.test_default_configuration__scripterror):
2531         (ConfigTest):
2532         (ConfigTest.test_asan):
2533         * Scripts/webkitpy/test/main.py:
2534         (Tester._run_tests): Add Asan as a style.
2535
2536 2019-06-06  Alexey Proskuryakov  <ap@apple.com>
2537
2538         block-spammers tool doesn't block e-mail
2539         https://bugs.webkit.org/show_bug.cgi?id=198570
2540
2541         Reviewed by Jonathan Bedard.
2542
2543         * Scripts/block-spammers: (disable_user): Corrected the parameters, Bugzilla doesn't
2544         recognize "false" here. Also, request body is unnecessary.
2545
2546 2019-06-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2547
2548         [GTK][WPE] Enable PSON
2549         https://bugs.webkit.org/show_bug.cgi?id=194979
2550
2551         Reviewed by Žan Doberšek.
2552
2553         Add WPEBackend-fdo patch required for PSON to work. It can be removed once we have a new version to depend on.
2554
2555         * gtk/jhbuild.modules:
2556         * gtk/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
2557         * wpe/jhbuild.modules:
2558         * wpe/patches/wpebackend-fdo-Handle-the-case-of-new-target-created-for-the-same-v.patch: Added.
2559
2560 2019-06-05  Andy Estes  <aestes@apple.com>
2561
2562         [macOS] Stop calling -[NSDraggingItem setItem:]
2563         https://bugs.webkit.org/show_bug.cgi?id=198588
2564         <rdar://problem/48297453>
2565
2566         On macOS Catalina, use -[NSDraggingItem _initWithItem:] instead.
2567
2568         Reviewed by Wenson Hsieh.
2569
2570         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Fixed up file paths in the
2571         TestRunnerShared group.
2572
2573         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2574         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2575         Changed to call -[NSDraggingItem _initWithItem:] when available.
2576
2577         * TestRunnerShared/spi/AppKitTestSPI.h: Renamed from
2578         Tools/DumpRenderTree/mac/AppKitTestSPI.h and moved NSDraggingItem internal interface
2579         declarations here from DumpRenderTree.
2580
2581         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2582         Added TestRunnerShared/spi/AppKitTestSPI.h.
2583
2584         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2585         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2586         Changed to call -[NSDraggingItem _initWithItem:] when available.
2587
2588 2019-06-05  Jer Noble  <jer.noble@apple.com>
2589
2590         -[WKWebView _suspendAllMediaPlayback] does not persist across navigation.
2591         https://bugs.webkit.org/show_bug.cgi?id=198585
2592
2593         Reviewed by Chris Dumez.
2594
2595         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2596         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2597         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSuspendAllMediaPlayback.mm: Added.
2598         (TEST):
2599         * TestWebKitAPI/Tests/WebKitLegacy/ios/video-with-audio.html:
2600
2601 2019-06-05  Alex Christensen  <achristensen@webkit.org>
2602
2603         Re-enable safe browsing in WKWebView
2604         https://bugs.webkit.org/show_bug.cgi?id=196161
2605         <rdar://problem/49171413>
2606
2607         Reviewed by Ryosuke Niwa.
2608
2609         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2610         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
2611         (TEST):
2612         (safeBrowsingView):
2613
2614 == Rolled over to ChangeLog-2019-06-05 ==