72d35640e4849907a9b6d904a4b62924e79cb8f8
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2
3         Add SPI _WKResourceLoadInfo.loadedFromCache
4         https://bugs.webkit.org/show_bug.cgi?id=208554
5
6         Reviewed by Wenson Hsieh.
7
8         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
9         (TEST):
10
11 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
12
13         Batch observations and completions of text manipulations
14         https://bugs.webkit.org/show_bug.cgi?id=208406
15
16         Reviewed by Wenson Hsieh.
17
18         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
19         multiple paragraphs at once.
20
21         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
22         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
23         (-[TextManipulationDelegate items]):
24         (-[LegacyTextManipulationDelegate init]):
25         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
26         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
27         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
28         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
29         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
30         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
31         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
32
33 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
34
35         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
36         https://bugs.webkit.org/show_bug.cgi?id=208415
37
38         Reviewed by Brent Fulgham.
39
40         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
41         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
42         (TEST):
43
44 2020-03-03  Alex Christensen  <achristensen@webkit.org>
45
46         Add response to _WKResourceLoadDelegate didCompleteWithError callback
47         https://bugs.webkit.org/show_bug.cgi?id=208553
48
49         Reviewed by Simon Fraser.
50
51         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
52         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
53         (TEST):
54         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
55
56 2020-03-03  Brady Eidson  <beidson@apple.com>
57
58         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
59         https://bugs.webkit.org/show_bug.cgi?id=198795
60
61         Reviewed by Chris Dumez.
62
63         This test appears to no longer be flaky.
64         
65         Let's re-enable it.
66         
67         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
68         (TestWebKitAPI::TEST):
69
70 2020-03-03  Alex Christensen  <achristensen@webkit.org>
71
72         Requests sent to _WKResourceLoadDelegate should include HTTPBody
73         https://bugs.webkit.org/show_bug.cgi?id=208550
74
75         Reviewed by Tim Hatcher.
76
77         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
78         (TEST):
79         * TestWebKitAPI/cocoa/HTTPServer.mm:
80         (TestWebKitAPI::HTTPServer::respondToRequests):
81         HTTPServer now looks for Content-Length in its request.
82         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
83
84 2020-03-03  Alex Christensen  <achristensen@webkit.org>
85
86         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
87         https://bugs.webkit.org/show_bug.cgi?id=208522
88
89         Reviewed by Brian Weinstein.
90
91         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
92         (TEST):
93
94 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
95
96         commit-queue should update working directory and reapply patch just before commiting
97         https://bugs.webkit.org/show_bug.cgi?id=208521
98
99         Reviewed by Jonathan Bedard.
100
101         * BuildSlaveSupport/ews-build/factories.py:
102
103 2020-03-03  Matt Lewis  <jlewis3@apple.com>
104
105         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
106         https://bugs.webkit.org/show_bug.cgi?id=208485
107
108         Reviewed by Jonathan Bedard.
109
110         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
111         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
112         that we don't have to recreate the variables that are already created.
113         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
114         from each module, rather than making extra imports that we don't need.
115         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
116         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
117         and not part of the host.
118         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
119         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
120         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
121         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
122         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
123         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
124         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
125         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
126         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
127         if we were geting any value at all
128         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
129         sure we aren't gabking the wrong key:value pair
130         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
131         come with the MockHosts and MockHost inherits from MockSystemHost.
132         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
133         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
134         to the various upload steps.
135
136 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
137
138         [ews] Add build step to find list of modified changelogs
139         https://bugs.webkit.org/show_bug.cgi?id=208514
140
141         Reviewed by Jonathan Bedard.
142
143         * BuildSlaveSupport/ews-build/factories.py:
144         * BuildSlaveSupport/ews-build/steps.py:
145         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
146         (FindModifiedChangeLogs.start): Initialize log observer.
147         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
148         (FindModifiedChangeLogs.evaluateCommand):
149         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
150         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
151         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
152         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
153
154 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
155
156         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
157         https://bugs.webkit.org/show_bug.cgi?id=208451
158
159         Unreviewed test gardening.
160
161         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
162
163 2020-03-03  Jiten Mehta  <jmehta@apple.com>
164
165         Adopt HTTP Alternative Services Storage
166         https://bugs.webkit.org/show_bug.cgi?id=208387
167
168         Reviewed by Alex Christensen.
169
170         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
171         (checkUntilEntryFound):
172         (TEST):
173
174 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
175
176         Check for navigation to app-bound domain during script evaluation
177         https://bugs.webkit.org/show_bug.cgi?id=208319
178         <rdar://problem/57569321>
179
180         Reviewed by Brent Fulgham.
181
182         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
183         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
184         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
185         (TEST):
186         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
187         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
188
189 2020-03-03  Commit Queue  <commit-queue@webkit.org>
190
191         Unreviewed, rolling out r257754.
192         https://bugs.webkit.org/show_bug.cgi?id=208513
193
194         Introduced API test failure (Requested by perarne on #webkit).
195
196         Reverted changeset:
197
198         "[Cocoa] Mapping from MIME type to UTI type should be done in
199         the UI process"
200         https://bugs.webkit.org/show_bug.cgi?id=208415
201         https://trac.webkit.org/changeset/257754
202
203 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
204
205         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
206         https://bugs.webkit.org/show_bug.cgi?id=208506
207
208         Reviewed by Carlos Garcia Campos.
209
210         * WebKitTestRunner/TestController.cpp:
211         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
212
213 2020-03-02  Ben Nham  <nham@apple.com>
214
215         Add performance probes for HTML parsing
216         https://bugs.webkit.org/show_bug.cgi?id=208271
217
218         Reviewed by Daniel Bates.
219
220         This adds probes that show which lines of HTML are have been parsed.
221
222         * Tracing/SystemTracePoints.plist:
223
224 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
225
226         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
227         https://bugs.webkit.org/show_bug.cgi?id=208415
228
229         Reviewed by Brent Fulgham.
230
231         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
232         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
233         (TEST):
234
235 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
236
237         Unreviewed, rolling out r257725.
238
239         This commit caused 10 API tests to fail
240
241         Reverted changeset:
242
243         "[Cocoa] Mapping from MIME type to UTI type should be done in
244         the UI process"
245         https://bugs.webkit.org/show_bug.cgi?id=208415
246         https://trac.webkit.org/changeset/257725
247
248 2020-03-02  Saam Barati  <sbarati@apple.com>
249
250         Don't skip tests unnecessarily on arm64
251         https://bugs.webkit.org/show_bug.cgi?id=208470
252         <rdar://problem/59968869>
253
254         Reviewed by Tadeu Zagallo.
255
256         * Scripts/run-jsc-stress-tests:
257
258 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
259
260         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
261         https://bugs.webkit.org/show_bug.cgi?id=208434
262
263         Reviewed by Chris Fleizach.
264
265         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
266         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
267         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
268         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
269         (WTR::AccessibilityController::accessibleElementById): Same as above.
270
271 2020-03-02  John Wilander  <wilander@apple.com>
272
273         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
274         https://bugs.webkit.org/show_bug.cgi?id=208399
275         <rdar://problem/24731650>
276
277         Reviewed by Brent Fulgham.
278
279         The majority of the changes in WTR::TestController is (partially) fixing a bug
280         where the TestRunner would statically use the default website datastore instead
281         of the website data store configure for the page. This worked for persistent
282         storage testing but not for ephemeral sessions which is what this patch is all
283         about. The previous TestController::websiteDataStore() is now called
284         TestController::defaultWebsiteDataStore() and the new
285         TestController::websiteDataStore() returns the configured website data store.
286         Most of the use of the default website data store should probably change but
287         that's not really for this patch to deal with. I did however move all of
288         resource load statistics' use to the new TestController::websiteDataStore().
289
290         A new TestRunner function was added: isStatisticsEphemeral()
291         It allows test cases to query the ephemeral status of resource load statistics.
292
293         One problem that is mitigated in this patch but not fully fixed is that for
294         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
295         TestController::generatePageConfiguration() via C API 
296         WKPageConfigurationSetWebsiteDataStore(), and then again in 
297         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
298         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
299         I tried removing the latter since one session for all platforms should be
300         Enough but got broken behavior as a result. So now both are still there
301         and both enable resource load statistics.
302
303         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
304         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
305         (WTR::TestRunner::isStatisticsEphemeral):
306         * WebKitTestRunner/InjectedBundle/TestRunner.h:
307         * WebKitTestRunner/TestController.cpp:
308         (WTR::TestController::defaultWebsiteDataStore):
309         (WTR::TestController::websiteDataStore):
310         (WTR::TestController::generatePageConfiguration):
311         (WTR::TestController::resetPreferencesToConsistentValues):
312         (WTR::TestController::resetStateToConsistentValues):
313         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
314         (WTR::TestController::decidePolicyForNavigationAction):
315         (WTR::TestController::platformAdjustContext):
316         (WTR::TestController::clearServiceWorkerRegistrations):
317         (WTR::TestController::clearDOMCache):
318         (WTR::TestController::clearDOMCaches):
319         (WTR::TestController::clearIndexedDatabases):
320         (WTR::TestController::clearLocalStorage):
321         (WTR::TestController::hasDOMCache):
322         (WTR::TestController::domCacheSize):
323         (WTR::TestController::setStatisticsEnabled):
324         (WTR::TestController::isStatisticsEphemeral):
325         (WTR::TestController::setStatisticsDebugMode):
326         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
327         (WTR::TestController::setStatisticsLastSeen):
328         (WTR::TestController::setStatisticsMergeStatistic):
329         (WTR::TestController::setStatisticsPrevalentResource):
330         (WTR::TestController::setStatisticsVeryPrevalentResource):
331         (WTR::TestController::dumpResourceLoadStatistics):
332         (WTR::TestController::isStatisticsPrevalentResource):
333         (WTR::TestController::isStatisticsVeryPrevalentResource):
334         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
335         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
336         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
337         (WTR::TestController::setStatisticsHasHadUserInteraction):
338         (WTR::TestController::isStatisticsHasHadUserInteraction):
339         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
340         (WTR::TestController::setStatisticsGrandfathered):
341         (WTR::TestController::isStatisticsGrandfathered):
342         (WTR::TestController::setUseITPDatabase):
343         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
344         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
345         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
346         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
347         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
348         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
349         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
350         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
351         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
352         (WTR::TestController::statisticsUpdateCookieBlocking):
353         (WTR::TestController::statisticsSubmitTelemetry):
354         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
355         (WTR::TestController::setStatisticsIsRunningTest):
356         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
357         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
358         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
359         (WTR::TestController::setStatisticsGrandfatheringTime):
360         (WTR::TestController::setStatisticsMaxStatisticsEntries):
361         (WTR::TestController::setStatisticsPruneEntriesDownTo):
362         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
363         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
364         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
365         (WTR::TestController::statisticsDeleteCookiesForHost):
366         (WTR::TestController::isStatisticsHasLocalStorage):
367         (WTR::TestController::setStatisticsCacheMaxAgeCap):
368         (WTR::TestController::hasStatisticsIsolatedSession):
369         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
370         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
371         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
372         (WTR::TestController::statisticsResetToConsistentState):
373         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
374         * WebKitTestRunner/TestController.h:
375         * WebKitTestRunner/TestInvocation.cpp:
376         (WTR::TestInvocation::invoke):
377         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
378         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
379         (WTR::initializeWebViewConfiguration):
380         (WTR::TestController::platformCreateWebView):
381
382 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
383
384         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
385         https://bugs.webkit.org/show_bug.cgi?id=208415
386
387         Reviewed by Brent Fulgham.
388
389         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
390         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
391         (TEST):
392
393 2020-03-02  Daniel Bates  <dabates@apple.com>
394
395         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
396         https://bugs.webkit.org/show_bug.cgi?id=208352
397         <rdar://problem/59867815>
398
399         Reviewed by Wenson Hsieh.
400
401         Update test results to reflect the new behavior. To do this I also need to fix up the test code
402         to actually scroll the web content. This also means we now execute the same code on both Mac and
403         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
404         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
405         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
406
407         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
408         (TEST):
409
410 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
411
412         Unreviewed, rolling out r257687.
413
414         This commit caused debug tests to crash for macOS & iOS
415
416         Reverted changeset:
417
418         "[Cocoa] Mapping from MIME type to UTI type should be done in
419         the UI process"
420         https://bugs.webkit.org/show_bug.cgi?id=208415
421         https://trac.webkit.org/changeset/257687
422
423 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
424
425         Unreviewed, rolling out r257618.
426
427         This allegedly causes Safari to crash when closing a window
428         (see rdar://problem/59922725).
429
430         Reverted changeset:
431
432         "UIProcess crash after using _prepareForMoveToWindow, then
433         deallocating the WKWebView before moving to the window"
434         https://bugs.webkit.org/show_bug.cgi?id=208365
435         https://trac.webkit.org/changeset/257618
436
437 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
438
439         Remove std::lock_guard
440         https://bugs.webkit.org/show_bug.cgi?id=206451
441
442         Reviewed by Anders Carlsson.
443
444         Add std::lock_guard lint rule to prevent from using it.
445
446         * Scripts/webkitpy/style/checkers/cpp.py:
447         (check_lock_guard):
448         (check_style):
449         (CppChecker):
450         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
451         (WebKitStyleTest.test_lock_guard):
452         * TestWebKitAPI/Tests/WTF/Condition.cpp:
453         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
454         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
455         (assertHasObjects):
456         (assertHasOnlyObjects):
457         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
458         (WTR::AXThread::dispatch):
459         (WTR::AXThread::dispatchFunctionsFromAXThread):
460         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
461         (WTR::AXThread::initializeRunLoop):
462
463 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
464
465         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
466         https://bugs.webkit.org/show_bug.cgi?id=208415
467
468         Reviewed by Brent Fulgham.
469
470         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
471         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
472         (TEST):
473
474 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
475
476         Unreviewed, rolling out r257565.
477
478         It broke WinCairo MiniBrowser
479
480         Reverted changeset:
481
482         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
483         https://bugs.webkit.org/show_bug.cgi?id=206894
484         https://trac.webkit.org/changeset/257565
485
486 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
487
488         EWS fails to retry build in case of kill-old-processes exception
489         https://bugs.webkit.org/show_bug.cgi?id=208003
490
491         Reviewed by Jonathan Bedard.
492
493         * BuildSlaveSupport/ews-build/steps.py:
494         (KillOldProcesses.evaluateCommand):
495         (KillOldProcesses.getResultSummary):
496
497 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
498
499         [ews] commit-queue should update the ChangeLog with Reviewer name
500         https://bugs.webkit.org/show_bug.cgi?id=206535
501
502         Reviewed by Jonathan Bedard.
503
504         * BuildSlaveSupport/ews-build/steps.py:
505         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
506
507 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
508
509         run-javascriptcore-tests: Make upload format valid
510         https://bugs.webkit.org/show_bug.cgi?id=208341
511
512         Rubber-stamped by Aakash Jain.
513
514         * Scripts/run-javascriptcore-tests:
515         (uploadResults): Remove. FIXME.
516         * Scripts/webkitdirs.pm:
517         (splitVersionString): Handle case where the subminor version number has a - in it.
518         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
519
520 2020-02-28  youenn fablet  <youenn@apple.com>
521
522         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
523         https://bugs.webkit.org/show_bug.cgi?id=208130
524
525         Reviewed by Eric Carlson.
526
527         * WebKitTestRunner/TestOptions.h:
528         Use GPU process to capture by default.
529         We will remove this option once done verifying that every test works smoothly.
530
531 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
532
533         [ews] commit queue should skip building and testing for rollout patches
534         https://bugs.webkit.org/show_bug.cgi?id=208329
535
536         Reviewed by Jonathan Bedard.
537
538         * BuildSlaveSupport/ews-build/steps.py:
539         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
540         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
541         (RunWebKit1Tests.doStepIf): Ditto.
542         * BuildSlaveSupport/ews-build/steps_unittest.py:
543         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
544         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
545
546 2020-02-28  Daniel Bates  <dabates@apple.com>
547
548         Update my watch list preferences and contributor's entry.
549
550         * Scripts/webkitpy/common/config/contributors.json:
551         * Scripts/webkitpy/common/config/watchlist:
552
553 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
554
555         Fix WebCore export macros for declspec
556         https://bugs.webkit.org/show_bug.cgi?id=208363
557
558         Reviewed by Konstantin Tokarev.
559
560         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
561         files. Removed precompiled headers that were empty.
562
563         * DumpRenderTree/DumpRenderTreePrefix.h:
564         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
565         * MiniBrowser/win/stdafx.h:
566         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
567         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
568         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
569         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
570         * WebKitTestRunner/PlatformFTW.cmake:
571         * WebKitTestRunner/PlatformWin.cmake:
572         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
573
574 2020-02-27  Tim Horton  <timothy_horton@apple.com>
575
576         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
577         https://bugs.webkit.org/show_bug.cgi?id=208365
578
579         Reviewed by Alex Christensen.
580
581         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
582         (TEST):
583         Add a test! It was a 100% repro crash before this change.
584
585 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
586
587         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
588         https://bugs.webkit.org/show_bug.cgi?id=208260
589         <rdar://problem/59820107>
590
591         Reviewed by Tim Horton.
592
593         Followed instructions for adding an Info.plist for Single-File Tools
594         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
595
596         The default WebsiteDataStore file path will change with this test to
597         reflect the new bundleID so we must change expectations for any api
598         tests which rely on knowing the path.
599
600         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
601         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
602         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
603         (TEST):
604         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
605         (TEST):
606         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
607         (TEST):
608         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
609         (TEST):
610         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
611         (TEST):
612         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
613         (TEST):
614         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
615         (TEST):
616         (defaultWebsiteCacheDirectory):
617         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
618         (TEST):
619         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
620         (TEST):
621         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
622         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
623         (TEST):
624         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
625         (TEST):
626         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
627         (runWebsiteDataStoreCustomPaths):
628         (TEST):
629         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
630         (TestWebKitAPI::resetTestState):
631         Now that we set a bundleID, we have to reset the cache model between
632         tests, otherwise it gets stored between tests.
633
634         (TestWebKitAPI::TEST):
635         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
636         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
637
638 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
639
640         TextManipulationController should not generate a new item for content in manipulated paragraphs
641         https://bugs.webkit.org/show_bug.cgi?id=208286
642
643         Reviewed by Wenson Hsieh.
644
645         Added a regression test.
646
647         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
648         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
649
650 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
651
652         run-javascriptcore-tests: Make upload format valid
653         https://bugs.webkit.org/show_bug.cgi?id=208341
654
655         Reviewed by Aakash Jain.
656
657         * Scripts/run-javascriptcore-tests:
658         (uploadResults): Print json blob for upload after failure for debugging.
659
660 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
661
662         [CMake] Add WebKit::PAL target
663         https://bugs.webkit.org/show_bug.cgi?id=198493
664
665         Reviewed by Michael Catanzaro.
666
667         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
668
669         * DumpRenderTree/PlatformWin.cmake:
670
671 2020-02-27  Alex Christensen  <achristensen@webkit.org>
672
673         Add SPI to query WKFrameInfos in a WKWebView
674         https://bugs.webkit.org/show_bug.cgi?id=208212
675
676         Reviewed by Brady Eidson.
677
678         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
679         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
680         * WebKitTestRunner/TestController.cpp:
681         (WTR::TestController::saltForOrigin):
682
683 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
684
685         Unreviewed, rolling out r257530.
686
687         This commit seems to have broke the build internally for
688         watchOS
689
690         Reverted changeset:
691
692         "Add SPI to query WKFrameInfos in a WKWebView"
693         https://bugs.webkit.org/show_bug.cgi?id=208212
694         https://trac.webkit.org/changeset/257530
695
696 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
697
698         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
699         https://bugs.webkit.org/show_bug.cgi?id=206894
700
701         Reviewed by Adrian Perez de Castro.
702
703         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
704         MiniBrowsers.
705
706         * MiniBrowser/gtk/CMakeLists.txt:
707         * MiniBrowser/win/CMakeLists.txt:
708         * MiniBrowser/wpe/CMakeLists.txt:
709
710 2020-02-26  Alex Christensen  <achristensen@webkit.org>
711
712         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
713         https://bugs.webkit.org/show_bug.cgi?id=206456
714
715         Reviewed by Brady Eidson.
716
717         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
718         (TEST):
719
720 2020-02-26  Alex Christensen  <achristensen@webkit.org>
721
722         _WKUserContentWorld should be a wrapper around WKContentWorld
723         https://bugs.webkit.org/show_bug.cgi?id=208274
724
725         Reviewed by Brady Eidson.
726
727         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
728         (TEST):
729         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
730         (TEST):
731
732 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
733
734         Unreviewed, rolling out r257522.
735
736         Caused 16 API test failures on the bots
737
738         Reverted changeset:
739
740         "TestWebKitAPI and WebKitTestRunner should have bundle
741         identifiers"
742         https://bugs.webkit.org/show_bug.cgi?id=208260
743         https://trac.webkit.org/changeset/257522
744
745 2020-02-26  Alex Christensen  <achristensen@webkit.org>
746
747         Add SPI to query WKFrameInfos in a WKWebView
748         https://bugs.webkit.org/show_bug.cgi?id=208212
749
750         Reviewed by Brady Eidson.
751
752         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
753         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
754         * WebKitTestRunner/TestController.cpp:
755         (WTR::TestController::saltForOrigin):
756
757 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
758
759         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
760         https://bugs.webkit.org/show_bug.cgi?id=208260
761         <rdar://problem/59820107>
762
763         Reviewed by Tim Horton.
764
765         Followed instructions for adding an Info.plist for Single-File Tools
766         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
767
768         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
769         * TestWebKitAPI/Info.plist: Added.
770         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
771         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
772         * WebKitTestRunner/Info.plist: Added.
773         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
774
775 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
776
777         Tests should each use a unique ResourceLoadStatistics file path for its database store
778         https://bugs.webkit.org/show_bug.cgi?id=208206
779         <rdar://problem/59690272>
780
781         Reviewed by Brady Eidson.
782
783         Initialize a default website data store before checking for the ITP
784         store to ensure the directory exists after the file has been deleted.
785
786         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
787         (TEST):
788
789 2020-02-26  Christopher Reid  <chris.reid@sony.com>
790
791         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
792         https://bugs.webkit.org/show_bug.cgi?id=197684
793         <rdar://problem/59467397>
794
795         Reviewed by Yusuke Suzuki.
796
797         Add test for FileSystem::createFile
798
799         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
800
801 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
802
803         [ews] commit-queue should verify patch committer and reviewer
804         https://bugs.webkit.org/show_bug.cgi?id=206532
805
806         Reviewed by Jonathan Bedard.
807
808         * BuildSlaveSupport/ews-build/steps.py:
809         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
810         (ValidateCommiterAndReviewer._addToLog):
811         (ValidateCommiterAndReviewer.getResultSummary):
812         (ValidateCommiterAndReviewer.fail_build):
813         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
814         (ValidateCommiterAndReviewer.is_reviewer):
815         (ValidateCommiterAndReviewer.is_committer):
816         (ValidateCommiterAndReviewer.full_name_from_email):
817         (ValidateCommiterAndReviewer.start):
818
819 2020-02-26  Daniel Bates  <dabates@apple.com>
820
821         [iOS] Send focus update immediately on becoming or resigning first responder
822         https://bugs.webkit.org/show_bug.cgi?id=208082
823         <rdar://problem/59688413>
824
825         Rubber-stamped by Jer Noble.
826
827         Add a test to ensure that selecting a position at a point after the web view
828         becomes first responder is allowed. Such an operation is only allowed if the
829         web view is focused.
830
831         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
832         (-[TestWKWebView selectPositionAtPoint:]):
833         (TEST):
834         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
835
836 2020-02-26  Chris Dumez  <cdumez@apple.com>
837
838         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
839
840         The test was added for macOS and times out on iOS.
841
842         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
843         (TEST):
844
845 2020-02-26  Youenn Fablet  <youenn@apple.com>
846
847         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
848         https://bugs.webkit.org/show_bug.cgi?id=208238
849
850         Reviewed by Eric Carlson.
851
852         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
853         (TEST):
854         Remove use of deleted parameter.
855
856 2020-02-25  Devin Rousso  <drousso@apple.com>
857
858         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
859         https://bugs.webkit.org/show_bug.cgi?id=206911
860         <rdar://problem/58026635>
861
862         Reviewed by Brian Burg.
863
864         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
865         (TestWebKitAPI::TEST):
866         Add test for `WTF::HashSet::reserveInitialCapacity`.
867
868         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
869         (TestWebKitAPI::TEST):
870         Actually check the value of `WTF::HashMap::capacity`.
871
872         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
873         (-[InspectorDelegate _webView:didAttachInspector:])
874         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
875         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
876         (TestWebKitAPI::TEST):
877         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
878         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
879         (TestWebKitAPI::TEST): Deleted.
880
881 2020-02-25  Matt Lewis  <jlewis3@apple.com>
882
883         Add checkout_root to stubrepository.py
884         https://bugs.webkit.org/show_bug.cgi?id=208213
885
886         Reviewed by Jonathan Bedard.
887
888         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
889         (StubRepository.__init__):
890
891         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
892         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
893
894 2020-02-25  Daniel Bates  <dabates@apple.com>
895
896         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
897         https://bugs.webkit.org/show_bug.cgi?id=208214
898
899         Reviewed by Wenson Hsieh.
900
901         Wait until the copy operation completes before loading the second web view and testing paste
902         to ensure that something was actually copied to the clipboard.
903
904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
905         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
906         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
907         so that we wait until the command completes.
908
909 2020-02-25  Chris Dumez  <cdumez@apple.com>
910
911         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
912         https://bugs.webkit.org/show_bug.cgi?id=208199
913         <rdar://problem/59746887>
914
915         Reviewed by Alex Christensen.
916
917         Add API test coverage.
918
919         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
920         (TEST):
921
922 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
923
924         spinRunLoop should take a non-zero integer as parameter
925         https://bugs.webkit.org/show_bug.cgi?id=208148
926         <rdar://problem/59766682>
927
928         Unreviewed iOS build fix.
929
930         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
931         (TestWebKitAPI::Util::spinRunLoop):
932
933 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
934
935         spinRunLoop should take a non-zero integer as parameter
936         https://bugs.webkit.org/show_bug.cgi?id=208148
937
938         Reviewed by Darin Adler.
939
940         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
941         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
942         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
943         (TestWebKitAPI::Util::spinRunLoop):
944
945 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
946
947         [WTF] Add tests for CompactRefPtrTuple
948         https://bugs.webkit.org/show_bug.cgi?id=208172
949
950         Reviewed by Darin Adler.
951
952         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
953         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
954
955         * TestWebKitAPI/CMakeLists.txt:
956         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
957         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
958         (TestWebKitAPI::TEST):
959
960 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
961
962         [ews] commit-queue should check that patch have appropriate review flag
963         https://bugs.webkit.org/show_bug.cgi?id=208138
964
965         Reviewed by Jonathan Bedard.
966
967         * BuildSlaveSupport/ews-build/steps.py:
968         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
969         (BugzillaMixin._is_patch_cq_plus):
970         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
971         (ValidatePatch.start):
972
973 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
974
975         [WebAuthn] Implement SPI for the platform authenticator
976         https://bugs.webkit.org/show_bug.cgi?id=208087
977         <rdar://problem/59369305>
978
979         Reviewed by Brent Fulgham.
980
981         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
982
983         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
984         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
985         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
986         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
987         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
988         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
989         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
990         (TestWebKitAPI::TEST):
991         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
992         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
993         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
994         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
995
996 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
997
998         Unreviewed, updating LLDB test for CompactPointerTuple.
999         https://bugs.webkit.org/show_bug.cgi?id=207827
1000
1001         * lldb/lldb_webkit.py:
1002         (WTFCompactPointerTupleProvider):
1003         (WTFCompactPointerTupleProvider.update):
1004
1005 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
1006
1007         Provide alternate way to name Web Content process
1008         https://bugs.webkit.org/show_bug.cgi?id=205224
1009         rdar://57038084
1010
1011         Reviewed by Alex Christensen.
1012
1013         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1014         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
1015         (TestWebKitAPI::TEST):
1016
1017 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
1018
1019         results.webkit.org: Link to result archives
1020         https://bugs.webkit.org/show_bug.cgi?id=207646
1021         <rdar://problem/59395807>
1022
1023         Rubber-stamped by Aakash Jain.
1024
1025         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
1026         (_ArchiveRouter): Retrieve json from archive-router endpoint.
1027         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
1028         return the most specific value.
1029         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
1030         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
1031         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
1032         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
1033         (parametersForInstance): Extract from lambda function.
1034         (testRunLink): Use parametersForInstance instead of a lambda function.
1035         (archiveLink): Return an archive link for data. 
1036         (contentForData): Add archive link to view.
1037         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
1038         (TimelineFromEndpoint): Accept both suite and test.
1039         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
1040         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
1041         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
1042         * resultsdbpy/resultsdbpy/view/view_routes.py:
1043         (ViewRoutes.__init__): Add archive_route dictionary.
1044
1045 2020-02-24  Alex Christensen  <achristensen@webkit.org>
1046
1047         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
1048         https://bugs.webkit.org/show_bug.cgi?id=208035
1049         <rdar://problem/58011337>
1050
1051         Reviewed by Tim Hatcher.
1052
1053         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1054
1055 2020-02-22  Darin Adler  <darin@apple.com>
1056
1057         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
1058         https://bugs.webkit.org/show_bug.cgi?id=208099
1059
1060         Reviewed by Antti Koivisto.
1061
1062         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
1063         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
1064         so we can use the -[NSString createJSStringRef] method.
1065         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
1066         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
1067
1068 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
1069
1070         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
1071         https://bugs.webkit.org/show_bug.cgi?id=208096
1072         <rdar://problem/59632008>
1073
1074         Reviewed by Alexey Proskuryakov.
1075
1076         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
1077         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
1078         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
1079
1080         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
1081         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
1082         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
1083         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
1084         in the credit card expiry field.
1085
1086         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
1087
1088         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1089         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1090         (WTR::UIScriptController::setDefaultCalendarType):
1091         * WebKitTestRunner/TestController.h:
1092
1093         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
1094         identifier and calendar locale identifier.
1095
1096         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1097         (WTR::swizzledCalendar):
1098         (WTR::TestController::overriddenCalendarIdentifier const):
1099         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
1100
1101         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
1102
1103         (WTR::TestController::setDefaultCalendarType):
1104
1105         Plumb the new calendar's locale identifier through this method.
1106
1107         (WTR::TestController::cocoaResetStateToConsistentValues):
1108         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
1109         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
1110         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
1111         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
1112
1113 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
1114
1115         App-bound domains should have separate Network Sessions
1116         https://bugs.webkit.org/show_bug.cgi?id=208026
1117         <rdar://problem/59434006>
1118
1119         Reviewed by Brent Fulgham.
1120
1121         This patch is mostly test infrastructure involving 3 functions.
1122         One sets in-app browser privacy as enabled in the network process
1123         manually for the test. One ensures that setting the WebView category
1124         works properly, and the last one checks for an app-bound session for
1125         an app-bound navigation.
1126
1127         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1128         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1129         (WTR::InjectedBundle::didReceiveMessageToPage):
1130         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1131         (WTR::TestRunner::getWebViewCategory):
1132         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
1133         (WTR::TestRunner::hasAppBoundSession):
1134         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
1135         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
1136         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1137         * WebKitTestRunner/TestController.cpp:
1138         (WTR::TestController::ensureViewSupportsOptionsForTest):
1139         Clearing the bundleID should happen right before setting a new one, 
1140         otherwise it clears the ID after it is set and returns a null ID.
1141
1142         (WTR::TestController::resetStateToConsistentValues):
1143         (WTR::TestController::getWebViewCategory):
1144         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
1145         (WTR::inAppBrowserPrivacyBooleanResultCallback):
1146         (WTR::inAppBrowserPrivacyVoidResultCallback):
1147         (WTR::TestController::hasAppBoundSession):
1148         (WTR::TestController::setInAppBrowserPrivacyEnabled):
1149         * WebKitTestRunner/TestController.h:
1150         * WebKitTestRunner/TestInvocation.cpp:
1151         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1152         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1153         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
1154         (WTR::TestInvocation::didReceivePrevalentDomains):
1155         (WTR::TestInvocation::didReceiveWebViewCategory):
1156         * WebKitTestRunner/TestInvocation.h:
1157         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1158         (WTR::TestController::getWebViewCategory):
1159
1160 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
1161
1162         Build DumpRenderTree and WebKitTestRunner for macCatalyst
1163         https://bugs.webkit.org/show_bug.cgi?id=208068
1164         <rdar://problem/59676596>
1165
1166         Reviewed by Tim Horton.
1167
1168         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
1169         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
1170         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
1171         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
1172         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
1173         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
1174         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
1175         * DumpRenderTree/mac/EventSendingController.h: Ditto.
1176         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
1177         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
1178         * Makefile: Add DumpRenderTree and WebKitTestRunner.
1179         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
1180         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
1181         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
1182
1183 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
1184
1185         [ews] Add build step to Validate ChangeLog for commit-queue
1186         https://bugs.webkit.org/show_bug.cgi?id=208064
1187
1188         Reviewed by Jonathan Bedard.
1189
1190         * BuildSlaveSupport/ews-build/steps.py:
1191         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
1192         (ValidateChangeLogAndReviewer.start):
1193         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
1194         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
1195
1196 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
1197
1198         [ews] Add build step to set cq- flag on bugzilla patch
1199         https://bugs.webkit.org/show_bug.cgi?id=208021
1200
1201         Reviewed by Jonathan Bedard.
1202
1203         * BuildSlaveSupport/ews-build/steps.py:
1204         (BugzillaMixin.set_cq_minus_flag_on_patch):
1205         (SetCommitQueueMinusFlagOnPatch):
1206         (SetCommitQueueMinusFlagOnPatch.start):
1207         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
1208
1209 2020-02-20  Matt Lewis  <jlewis3@apple.com>
1210
1211         Stub repositories fail to upload some results due to missing head svn revision
1212         https://bugs.webkit.org/show_bug.cgi?id=207684
1213
1214         Reviewed by Jonathan Bedard.
1215
1216         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
1217         (MockHost.__init__):
1218         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1219         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
1220         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
1221         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
1222         * Scripts/webkitpy/port/base.py:
1223         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
1224         from using mock SCMs and more
1225         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
1226
1227 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
1228
1229         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
1230         https://bugs.webkit.org/show_bug.cgi?id=208051
1231
1232         Reviewed by Carlos Alberto Lopez Perez.
1233
1234         Verbose flag prints out each test name executed. Without this flag
1235         stdout prints out one or two periods.
1236
1237         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1238         (RunJavaScriptCoreTests.start):
1239
1240 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
1241
1242         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
1243         https://bugs.webkit.org/show_bug.cgi?id=207984
1244
1245         Reviewed by Daniel Bates.
1246
1247         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1248         (TestWebKitAPI::TEST):
1249
1250 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
1251
1252         [GTK] Improve user agent quirk for Google Docs and Google Drive
1253         https://bugs.webkit.org/show_bug.cgi?id=206506
1254
1255         Reviewed by Carlos Garcia Campos.
1256
1257         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1258         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
1259         (TestWebKitAPI::TEST):
1260
1261 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
1262
1263         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
1264         https://bugs.webkit.org/show_bug.cgi?id=207380
1265
1266         Reviewed by Jonathan Bedard.
1267
1268         Added a new rule 'build/export_macro'.
1269
1270         Removed a obsolete rule 'readability/webkit_export' which was used
1271         only by Chromium port (r148185).
1272
1273         * Scripts/webkitpy/style/checkers/cpp.py:
1274         (_FunctionState.export_macro):
1275         (check_function_definition):
1276         (_unix_path): Added.
1277         (is_generated_file): Use _unix_path.
1278         (check_has_config_header): Ditto.
1279         (CppChecker):
1280         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1281         (WebKitStyleTest.test_export_macro_check):
1282         (WebKitStyleTest.test_webkit_export_check): Deleted.
1283
1284 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
1285
1286         [Win][MiniBrowser] Add prettier toolbar button icons
1287         https://bugs.webkit.org/show_bug.cgi?id=207999
1288
1289         Reviewed by Ross Kirsling.
1290
1291         Use a custom toolbar button icons instead of system stock icons.
1292
1293         Fixed a bug toolbar button dropdown arrows always looked being
1294         hovered. TBSTYLE_FLAT should be given.
1295
1296         Removed the window border line of Progress Indicator.
1297
1298         * MiniBrowser/win/MainWindow.cpp:
1299         (MainWindow::createToolbar):
1300         * MiniBrowser/win/MiniBrowserLib.rc:
1301         * MiniBrowser/win/MiniBrowserLibResource.h:
1302         * MiniBrowser/win/toolbar.bmp: Added.
1303
1304 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
1305
1306         Update run-webkit-tests help description for skip-failing-tests
1307         https://bugs.webkit.org/show_bug.cgi?id=208031
1308
1309         Reviewed by Alexey Proskuryakov.
1310
1311         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1312
1313 2020-02-20  Chris Dumez  <cdumez@apple.com>
1314
1315         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
1316         https://bugs.webkit.org/show_bug.cgi?id=208015
1317         <rdar://problem/59591630>
1318
1319         Reviewed by Geoffrey Garen.
1320
1321         Add API test coverage.
1322
1323         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
1324         (TEST):
1325
1326 2020-02-20  Tim Horton  <timothy_horton@apple.com>
1327
1328         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
1329         https://bugs.webkit.org/show_bug.cgi?id=207998
1330         <rdar://problem/40942425>
1331
1332         Reviewed by Sam Weinig.
1333
1334         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1335         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
1336         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1337         (TestWebKitAPI::TEST):
1338         Add some tests for top content insets.
1339
1340 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
1341
1342         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
1343         https://bugs.webkit.org/show_bug.cgi?id=207910
1344
1345         Unreviewed infrastructure fix.
1346
1347         * Scripts/run-javascriptcore-tests:
1348         (configurationForUpload): Use the major version instead of the sub-minor version
1349         for version name.
1350
1351 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
1352
1353         [CMake] Add WPE::libwpe target
1354         https://bugs.webkit.org/show_bug.cgi?id=207970
1355
1356         Reviewed by Adrian Perez de Castro.
1357
1358         Use the WPE::libwpe target.
1359
1360         * MiniBrowser/wpe/CMakeLists.txt:
1361         * TestWebKitAPI/PlatformWPE.cmake:
1362         * TestWebKitAPI/glib/PlatformWPE.cmake:
1363         * wpe/backends/CMakeLists.txt:
1364
1365 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
1366
1367         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
1368         https://bugs.webkit.org/show_bug.cgi?id=207749
1369
1370         Reviewed by Ross Kirsling.
1371
1372         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
1373
1374         * MiniBrowser/win/MainWindow.cpp:
1375         (MainWindow::createToolbar):
1376         (MainWindow::WndProc):
1377         (MainWindow::setDefaultURLToCurrentURL):
1378         (MainWindow::goHome): Added.
1379         (MainWindow::onURLBarEnter):
1380         * MiniBrowser/win/MainWindow.h:
1381         * MiniBrowser/win/MiniBrowserLib.rc:
1382         * MiniBrowser/win/MiniBrowserLibResource.h:
1383         * MiniBrowser/win/MiniBrowserReplace.h:
1384         * MiniBrowser/win/WinMain.cpp:
1385         (wWinMain):
1386
1387 2020-02-19  Peng Liu  <peng.liu6@apple.com>
1388
1389         Fix check-webkit-style errors related to AVFoundationSPI.h
1390         https://bugs.webkit.org/show_bug.cgi?id=207834
1391
1392         Reviewed by Daniel Bates.
1393
1394         Revert the change in r256770 regarding the headers ordering.
1395         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
1396
1397         * Scripts/webkitpy/style/checkers/cpp.py:
1398         (check_include_line):
1399
1400 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
1401
1402         results.webkit.org: Correctly report JSC tests for windows
1403         https://bugs.webkit.org/show_bug.cgi?id=207910
1404
1405         Rubber-stamped by Aakash Jain.
1406
1407         * Scripts/run-javascriptcore-tests:
1408         (configurationForUpload): Give Windows a version name.
1409         * Scripts/webkitdirs.pm:
1410         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
1411         Version dictionary.
1412
1413 2020-02-19  Chris Dumez  <cdumez@apple.com>
1414
1415         Unreviewed, fix assertions in storage access API layout tests after r256882.
1416
1417         Drop dead testRunner code to toggle storage access API feature.
1418
1419         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1420         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1421         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
1422         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1423         * WebKitTestRunner/TestInvocation.cpp:
1424         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1425
1426 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
1427
1428         [WPE] Support 2D axis, smooth-motion events
1429         https://bugs.webkit.org/show_bug.cgi?id=207881
1430
1431         Reviewed by Carlos Garcia Campos.
1432
1433         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
1434
1435 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
1436
1437         Unreviewed, rolling out r256851.
1438
1439         Broke internal bots
1440
1441         Reverted changeset:
1442
1443         "Stub repositories fail to upload some results due to missing
1444         head svn revision"
1445         https://bugs.webkit.org/show_bug.cgi?id=207684
1446         https://trac.webkit.org/changeset/256851
1447
1448 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
1449
1450         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
1451         https://bugs.webkit.org/show_bug.cgi?id=207883
1452
1453         Reviewed by Ross Kirsling.
1454
1455         Unlike other mouse buttons, 4th and 5th mouse buttons are
1456         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
1457         WM_XBUTTONUP events to the window under the mouse cursor.
1458         Unhandled WM_XBUTTONUP events are automatically converted to
1459         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
1460         parent window.
1461         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
1462
1463         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
1464         handled.
1465
1466         * MiniBrowser/win/BrowserWindow.h:
1467         * MiniBrowser/win/MainWindow.cpp:
1468         (MainWindow::WndProc):
1469         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1470         (WebKitBrowserWindow::navigateForwardOrBackward):
1471         * MiniBrowser/win/WebKitBrowserWindow.h:
1472         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
1473         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
1474         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
1475
1476 2020-02-18  Alex Christensen  <achristensen@webkit.org>
1477
1478         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
1479         https://bugs.webkit.org/show_bug.cgi?id=207912
1480         <rdar://problem/59556922>
1481
1482         Reviewed by Brian Weinstein.
1483
1484         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1485         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1486         (TEST):
1487         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1488         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
1489
1490 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1491
1492         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
1493         https://bugs.webkit.org/show_bug.cgi?id=207899
1494         <rdar://problem/55658207>
1495
1496         Reviewed by Tim Horton and Simon Fraser.
1497
1498         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
1499
1500         * WebKitTestRunner/TestController.cpp:
1501         (WTR::updateTestOptionsFromTestHeader):
1502         * WebKitTestRunner/TestOptions.h:
1503         (WTR::TestOptions::hasSameInitializationOptions const):
1504         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1505         (WTR::TestController::platformCreateWebView):
1506
1507 2020-02-18  Matt Lewis  <jlewis3@apple.com>
1508
1509         Stub repositories fail to upload some results due to missing head svn revision
1510         https://bugs.webkit.org/show_bug.cgi?id=207684
1511
1512         Reviewed by Jonathan Bedard.
1513
1514         * Scripts/webkitpy/api_tests/run_api_tests.py:
1515         (main): Added initializing the scm to the host object.
1516         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1517         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
1518         it in line with modern code.
1519         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1520         (main): Added inializing the scm to the host object.
1521         * Scripts/webkitpy/port/base.py:
1522         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
1523         from using mock SCMs and more
1524         * Scripts/webkitpy/test/main.py:
1525         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
1526         and converted the webkit_root variable to the SCM checkout root.
1527         (Tester._run_tests):
1528
1529 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
1530
1531         Move [UIDevice currentDevice] calls to UI process
1532         https://bugs.webkit.org/show_bug.cgi?id=204320
1533
1534         Reviewed by Darin Adler.
1535
1536         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1537         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
1538         (TEST):
1539
1540 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
1541
1542         Move from "layer flush" terminology to "rendering update"
1543         https://bugs.webkit.org/show_bug.cgi?id=207870
1544
1545         Reviewed by Tim Horton.
1546
1547         Rename various functions and member variables to move away from the legacy "layer flush"
1548         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
1549         that we have layers is an implementation detail.
1550         
1551         Change LayerFlushThrottlingState to be an OptionSet<>.
1552
1553         * Tracing/SystemTracePoints.plist:
1554
1555 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
1556
1557         [Webkit.css] Adding popover style element
1558         This help to prevent us reinventing the wheel ever again
1559         https://bugs.webkit.org/show_bug.cgi?id=207787
1560
1561         Reviewed by Dean Jackson.
1562
1563         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
1564         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
1565         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
1566         (.popover):
1567         (.popover>.content):
1568         (.popover.display):
1569         (.popover .arrow):
1570         (.popover .arrow.point-top):
1571         (.popover .arrow.point-bottom):
1572         (.popover .arrow.point-left):
1573         (.popover .arrow.point-right):
1574         (@media (prefers-color-scheme: dark) .popover>.content):
1575         (@media (prefers-color-scheme: dark) .popover.display):
1576         (@media (prefers-color-scheme: dark) .popover .arrow):
1577         (.popover>.content>.section): Deleted.
1578         (.popover:focus>.content, .popover:hover>.content): Deleted.
1579         (.popover.right>.content): Deleted.
1580         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
1581         (.popover.left>.content): Deleted.
1582         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
1583         (.popover.bottom>.content): Deleted.
1584         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
1585
1586 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
1587
1588         Update WebKit Tools to issue mach extensions as needed
1589         https://bugs.webkit.org/show_bug.cgi?id=207850
1590         <rdar://problem/59521019>
1591
1592         Reviewed by Per Arne Vollan.
1593
1594         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
1595         to its child processes (WebContent, GPU, Network, etc.) as needed.
1596
1597         * MiniBrowser/MiniBrowser.entitlements:
1598         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
1599         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
1600         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1601         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
1602
1603 2020-02-17  Peng Liu  <peng.liu6@apple.com>
1604
1605         Fix check-webkit-style errors related to AVFoundationSPI.h
1606         https://bugs.webkit.org/show_bug.cgi?id=207834
1607
1608         Reviewed by Eric Carlson.
1609
1610         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
1611         Soft-link headers can be included as either "file.h" or <file.h>.
1612
1613         * Scripts/webkitpy/style/checkers/cpp.py:
1614         (_classify_include):
1615         (check_include_line):
1616
1617 2020-02-17  Keith Rollin  <krollin@apple.com>
1618
1619         Unreviewed build fix after r256715.
1620
1621         Fix tvOS and watchOS builds.
1622
1623         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1624
1625 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
1626
1627         Use CF prefs direct mode in the WebContent process
1628         https://bugs.webkit.org/show_bug.cgi?id=203420
1629
1630         Reviewed by Brent Fulgham.
1631
1632         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1633         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
1634         (TEST):
1635
1636 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1637
1638         EWS should be able to file Bugzilla bugs
1639         https://bugs.webkit.org/show_bug.cgi?id=207845
1640
1641         Reviewed by Alexey Proskuryakov.
1642
1643         * BuildSlaveSupport/ews-build/steps.py:
1644         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
1645
1646 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1647
1648         EWS should be able to comment on Bugzilla
1649         https://bugs.webkit.org/show_bug.cgi?id=201927
1650
1651         Reviewed by Jonathan Bedard.
1652
1653         * BuildSlaveSupport/ews-build/steps.py:
1654         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
1655         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
1656         (BugzillaMixin.close_bug): Ditto.
1657         (CommentOnBug): Build step to comment on bugzilla bug.
1658
1659 2020-02-17  Antti Koivisto  <antti@apple.com>
1660
1661         [macOS] Add trace points for layer flush runloop observer
1662         https://bugs.webkit.org/show_bug.cgi?id=207837
1663
1664         Reviewed by Sam Weinig.
1665
1666         * Tracing/SystemTracePoints.plist:
1667
1668 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
1669
1670         [CMake] Use builtin targets
1671         https://bugs.webkit.org/show_bug.cgi?id=205166
1672
1673         Reviewed by Darin Adler.
1674
1675         * TestWebKitAPI/PlatformWin.cmake:
1676
1677 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
1678
1679         [ews] add SetBuildSummary step for Windows EWS
1680         https://bugs.webkit.org/show_bug.cgi?id=207556
1681
1682         Reviewed by Jonathan Bedard.
1683
1684         * BuildSlaveSupport/ews-build/factories.py:
1685         (WindowsFactory.__init__):
1686         (GTKBuildAndTestFactory.__init__):
1687         * BuildSlaveSupport/ews-build/factories_unittest.py:
1688         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
1689
1690 2020-02-17  Alberto Garcia  <berto@igalia.com>
1691
1692         [WPE] Change the QML plugin install path
1693         https://bugs.webkit.org/show_bug.cgi?id=207761
1694
1695         Reviewed by Philippe Normand.
1696
1697         * Scripts/run-qt-wpe-minibrowser:
1698         * glib/api_test_runner.py:
1699         (TestRunner._run_test_qt):
1700
1701 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
1702
1703         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
1704         https://bugs.webkit.org/show_bug.cgi?id=207746
1705
1706         Reviewed by Don Olmstead.
1707
1708         * MiniBrowser/win/stdafx.h:
1709
1710 2020-02-16  Brady Eidson  <beidson@apple.com>
1711
1712         Expose "allowsContentJavaScript" on WKWebpagePreferences
1713         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
1714
1715         Reviewed by Darin Adler.
1716
1717         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1718         (TEST):
1719         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
1720         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1721         (TEST):
1722         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
1723         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
1724         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1725         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
1726         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
1727         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
1728         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
1729         * TestWebKitAPI/cocoa/TestWKWebView.h:
1730         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1731         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
1732
1733 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
1734
1735         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
1736         https://bugs.webkit.org/show_bug.cgi?id=207747
1737
1738         Reviewed by Keith Miller.
1739
1740         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
1741         (TestWebKitAPI::TEST):
1742
1743 2020-02-14  Alex Christensen  <achristensen@webkit.org>
1744
1745         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
1746         https://bugs.webkit.org/show_bug.cgi?id=207360
1747         <rdar://problem/57825317>
1748
1749         Reviewed by Ryosuke Niwa.
1750
1751         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
1752         (TestWebKitAPI::TEST):
1753
1754 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
1755
1756         [CMake] Add Fontconfig::Fontconfig target
1757         https://bugs.webkit.org/show_bug.cgi?id=207730
1758
1759         Reviewed by Adrian Perez de Castro.
1760
1761         Use the Fontconfig::Fontconfig target.
1762
1763         * WebKitTestRunner/PlatformGTK.cmake:
1764
1765 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
1766
1767          Expose prevalent domains on a per-page basis
1768          https://bugs.webkit.org/show_bug.cgi?id=207523
1769          <rdar://problem/59270758>
1770
1771         Reviewed by Chris Dumez.
1772
1773         Added WebKitTestRunner functions so this functionality can be tested.
1774         clearPrevalentDomains should be called between tests to reset the
1775         state.
1776
1777         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1778         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1779         (WTR::InjectedBundle::didReceiveMessageToPage):
1780         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1781         (WTR::TestRunner::getPrevalentDomains):
1782         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
1783         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1784         * WebKitTestRunner/TestController.cpp:
1785         (WTR::TestController::resetStateToConsistentValues):
1786         (WTR::TestController::getPrevalentDomains):
1787         (WTR::TestController::clearPrevalentDomains):
1788         * WebKitTestRunner/TestController.h:
1789         * WebKitTestRunner/TestInvocation.cpp:
1790         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1791         (WTR::TestInvocation::didReceivePrevalentDomains):
1792         * WebKitTestRunner/TestInvocation.h:
1793         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1794         (WTR::TestController::getPrevalentDomains):
1795         (WTR::TestController::clearPrevalentDomains):
1796
1797 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
1798
1799         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
1800         https://bugs.webkit.org/show_bug.cgi?id=207682
1801
1802         Reviewed by Ross Kirsling.
1803
1804         The toolbar placed button common controls as the toolbar buttons.
1805         However, because these buttons are focusable, shortcut keys don't
1806         work after clicking them.
1807
1808         Added Home button, Add to Bookmarks button, dropdown buttons of
1809         back and forward buttons, but they aren't implemented yet. Just
1810         placeholders at the moment.
1811
1812         * MiniBrowser/win/MainWindow.cpp:
1813         (MainWindow::createToolbar): Added.
1814         (MainWindow::resizeToolbar): Added.
1815         (MainWindow::rescaleToolbar): Added.
1816         (MainWindow::init):
1817         (MainWindow::resizeSubViews):
1818         (MainWindow::updateDeviceScaleFactor):
1819         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
1820
1821 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1822
1823         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
1824         https://bugs.webkit.org/show_bug.cgi?id=207676
1825
1826         Reviewed by Wenson Hsieh and Timothy Hatcher.
1827
1828         Added regression tests for pasting content with -apple-system-label and outdenting content.
1829
1830         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
1831         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
1832         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
1833
1834 2020-02-13  Alex Christensen  <achristensen@webkit.org>
1835
1836         _WKResourceLoadInfo should conform to NSSecureCoding
1837         https://bugs.webkit.org/show_bug.cgi?id=207667
1838
1839         Reviewed by Brady Eidson.
1840
1841         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1842         (TEST):
1843
1844 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
1845
1846         [PlayStation] Add Buildbots for Debug/Release builds
1847         https://bugs.webkit.org/show_bug.cgi?id=199454
1848
1849         Reviewed by Aakash Jain.
1850
1851         * BuildSlaveSupport/build.webkit.org-config/config.json:
1852         Add PlayStation slaves, builders
1853         * BuildSlaveSupport/build.webkit.org-config/factories.py:
1854         Use higher timeout for playstation as with win bot
1855         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
1856         Set PlayStation category for playstation platform
1857         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1858         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
1859         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1860         Add PlayStation expectations
1861
1862 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
1863
1864         [iOS] Check if PIP is supported in the UI process
1865         https://bugs.webkit.org/show_bug.cgi?id=207406
1866
1867         Reviewed by Brent Fulgham.
1868
1869         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1870         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
1871         (TEST):
1872
1873 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
1874
1875         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
1876         https://bugs.webkit.org/show_bug.cgi?id=207397
1877         <rdar://problem/59268128>
1878
1879         Reviewed by Jer Noble.
1880
1881         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
1882         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
1883
1884 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
1885
1886         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
1887         https://bugs.webkit.org/show_bug.cgi?id=207696
1888
1889         Reviewed by Tim Horton.
1890
1891         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
1892
1893 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
1894
1895         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
1896         https://bugs.webkit.org/show_bug.cgi?id=207680
1897         <rdar://problem/59340940>
1898
1899         Reviewed by Tim Horton.
1900
1901         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
1902         the current selection works.
1903
1904         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1905         (-[TestWKWebView updateSelectionWithExtentPoint:]):
1906         * TestWebKitAPI/ios/UIKitSPI.h:
1907
1908 2020-02-13  Said Abou-Hallawa  <said@apple.com>
1909
1910         Unreviewed, rolling out r255158, 255405 and r255486
1911
1912         Caused test flakiness and PLT regression.
1913
1914         * DumpRenderTree/mac/DumpRenderTree.mm:
1915         (resetWebPreferencesToConsistentValues):
1916         * DumpRenderTree/win/DumpRenderTree.cpp:
1917         (enableExperimentalFeatures):
1918         * WebKitTestRunner/TestController.cpp:
1919         (WTR::TestController::resetPreferencesToConsistentValues):
1920
1921 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
1922
1923         run-javascriptcore-tests: Allow insecure requests on upload
1924         https://bugs.webkit.org/show_bug.cgi?id=207662
1925
1926         Rubber-stamped by Aakash Jain.
1927
1928         * Scripts/run-javascriptcore-tests:
1929         (uploadResults): Allow insecure curl request when posting results.
1930
1931 2020-02-12  Truitt Savell  <tsavell@apple.com>
1932
1933         Unreviewed, rolling out r256463.
1934
1935         Caused major flakiness on Mac wk2
1936
1937         Reverted changeset:
1938
1939         "REGRESSION (r255158): http/tests/frame-throttling/raf-
1940         throttle-in-cross-origin-subframe.html is a flaky failure"
1941         https://bugs.webkit.org/show_bug.cgi?id=206839
1942         https://trac.webkit.org/changeset/256463
1943
1944 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
1945
1946         results.webkit.org: Remove debug JS logging
1947         https://bugs.webkit.org/show_bug.cgi?id=207663
1948
1949         Reviewed by Aakash Jain.
1950
1951         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
1952         (elapsed):
1953         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
1954         (_ToolTip.prototype.toString):
1955         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
1956         (prototype.addWithDelay):
1957         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
1958
1959 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
1960
1961         Remove CSS_DEVICE_ADAPTATION
1962         https://bugs.webkit.org/show_bug.cgi?id=203479
1963
1964         Reviewed by Tim Horton.
1965         
1966         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
1967         so remove the code.
1968
1969         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1970
1971 2020-02-12  Said Abou-Hallawa  <said@apple.com>
1972
1973         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
1974         https://bugs.webkit.org/show_bug.cgi?id=206839
1975
1976         Reviewed by Simon Fraser.
1977
1978         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
1979
1980         * DumpRenderTree/mac/DumpRenderTree.mm:
1981         (resetWebPreferencesToConsistentValues):
1982         * DumpRenderTree/win/DumpRenderTree.cpp:
1983         (enableExperimentalFeatures):
1984         * WebKitTestRunner/TestController.cpp:
1985         (WTR::TestController::resetPreferencesToConsistentValues):
1986
1987 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
1988
1989         results.webkit.org: Cache archive content
1990         https://bugs.webkit.org/show_bug.cgi?id=207589
1991
1992         Reviewed by Aakash Jain.
1993
1994         * resultsdbpy/resultsdbpy/flask_support/util.py:
1995         (cache_for): Add decorator function which sets the cache values on the returned response.
1996         * resultsdbpy/resultsdbpy/view/archive_view.py:
1997         (ArchiveView): Cache archive content client-side for 12 hours.
1998         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
1999         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
2000
2001 2020-02-12  Youenn Fablet  <youenn@apple.com>
2002
2003         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
2004         https://bugs.webkit.org/show_bug.cgi?id=207537
2005
2006         Reviewed by Chris Dumez.
2007
2008         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2009
2010 2020-02-11  Rob Buis  <rbuis@igalia.com>
2011
2012         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
2013         <https://webkit.org/b/207424>
2014         <rdar://problem/59250384>
2015
2016         Reviewed by Rob Buis.
2017
2018         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2019         (TestWebKitAPI::TEST): Add more tests.
2020
2021 2020-02-11  Commit Queue  <commit-queue@webkit.org>
2022
2023         Unreviewed, rolling out r256314.
2024         https://bugs.webkit.org/show_bug.cgi?id=207594
2025
2026         It is breaking an API test (Requested by youenn on #webkit).
2027
2028         Reverted changeset:
2029
2030         "WebSWServerConnection::registerServiceWorkerClient is not
2031         sending IPC message to UIProcess when it should"
2032         https://bugs.webkit.org/show_bug.cgi?id=207537
2033         https://trac.webkit.org/changeset/256314
2034
2035 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
2036
2037         results.webkit.org: Configuration documentation should include architecture
2038         https://bugs.webkit.org/show_bug.cgi?id=207584
2039
2040         Reviewed by Aakash Jain.
2041
2042         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
2043
2044 2020-02-11  Youenn Fablet  <youenn@apple.com>
2045
2046         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
2047         https://bugs.webkit.org/show_bug.cgi?id=207325
2048         <rdar://problem/59224810>
2049
2050         Reviewed by Eric Carlson.
2051
2052         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
2053         (TestWebKitAPI::TEST):
2054         Add a test validating that RTCRtpSender.getCapabilities does not return null.
2055         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2056
2057 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2058
2059         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
2060         https://bugs.webkit.org/show_bug.cgi?id=207557
2061
2062         Reviewed by Jonathan Bedard.
2063
2064         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
2065         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
2066         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
2067         around this by focusing an empty select element instead (for which we won't attempt to create and select any
2068         table view cells).
2069
2070         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2071
2072 2020-02-11  Alex Christensen  <achristensen@webkit.org>
2073
2074         Add WKHTTPCookieStore._getCookiesForURL SPI
2075         https://bugs.webkit.org/show_bug.cgi?id=207527
2076
2077         Reviewed by Brady Eidson.
2078
2079         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2080         (TEST):
2081
2082 2020-02-11  Youenn Fablet  <youenn@apple.com>
2083
2084         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
2085         https://bugs.webkit.org/show_bug.cgi?id=207537
2086
2087         Reviewed by Chris Dumez.
2088
2089         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2090
2091 2020-02-11  Lauro Moura  <lmoura@igalia.com>
2092
2093         [WPE][WebDriver] MiniBrowser should react to close session commands
2094         https://bugs.webkit.org/show_bug.cgi?id=207529
2095
2096         Reviewed by Carlos Garcia Campos.
2097
2098         WebDriver delete session command asks to close the WebView associated to the
2099         current automation session. We must react to it to avoid lots of
2100         timeouts and errors.
2101
2102         * MiniBrowser/wpe/main.cpp:
2103         (main): Listen to "close" signal on the main WebView.
2104
2105 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2106
2107         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
2108         https://bugs.webkit.org/show_bug.cgi?id=207525
2109         <rdar://problem/59110543>
2110
2111         Reviewed by Tim Horton.
2112
2113         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
2114         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
2115         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
2116         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
2117         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
2118         causing us to crash upon trying to create the dictionary.
2119
2120         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
2121         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
2122         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
2123         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
2124         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
2125         beginning of each API test.
2126
2127         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2128         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2129         (overrideBundleIdentifier):
2130
2131         Move this to the top of the file, so it can be shared.
2132
2133         (+[WKWebView initialize]):
2134
2135         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
2136         internal class method that calls into the internal helper function, with no other side effects.
2137
2138         * TestWebKitAPI/ios/UIKitSPI.h:
2139
2140 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
2141
2142         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
2143         https://bugs.webkit.org/show_bug.cgi?id=207501
2144         <rdar://problem/59323414>
2145
2146         Reviewed by Alex Christensen.
2147
2148         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
2149         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
2150         The same behavior.
2151
2152 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
2153
2154         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
2155         https://bugs.webkit.org/show_bug.cgi?id=207352
2156         <rdar://problem/59115798>
2157
2158         Reviewed by Alex Christensen.
2159
2160         Add a test to exercise the new SPI.
2161
2162         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
2163         a webpage that contains text in subframes.
2164
2165
2166 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
2167
2168         [iOS] Crash when granting access to asset services
2169         https://bugs.webkit.org/show_bug.cgi?id=207520
2170
2171         Reviewed by Brent Fulgham.
2172
2173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2174         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
2175         (TEST):
2176
2177 2020-02-10  Chris Dumez  <cdumez@apple.com>
2178
2179         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
2180         https://bugs.webkit.org/show_bug.cgi?id=207481
2181
2182         Reviewed by Alexey Proskuryakov.
2183
2184         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
2185         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
2186         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
2187
2188         * DumpRenderTree/mac/DumpRenderTree.mm:
2189         (resetWebViewToConsistentStateBeforeTesting):
2190         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
2191         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
2192         over internal settings.
2193
2194 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
2195
2196         [watchOS] Notification listener is never unregistered
2197         https://bugs.webkit.org/show_bug.cgi?id=207459
2198
2199         Reviewed by Maciej Stachowiak.
2200
2201         Add a test which tests that posting a backlight level change notification will not cause a crash.
2202
2203         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2204         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm: Added.
2205         (TEST):
2206
2207 2020-02-10  James Howard  <jameshoward@mac.com>
2208
2209         Standard gamepad mapping for GameControllerGamepads
2210         https://bugs.webkit.org/show_bug.cgi?id=206033
2211
2212         Reviewed by Dean Jackson.
2213
2214         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2215         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2216         (WTR::TestRunner::setMockGamepadDetails):
2217         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2218         * WebKitTestRunner/TestInvocation.cpp:
2219         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2220
2221 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
2222
2223         [ews] Display flaky layout test names in build summary
2224         https://bugs.webkit.org/show_bug.cgi?id=207504
2225
2226         Reviewed by Jonathan Bedard.
2227
2228         * BuildSlaveSupport/ews-build/steps.py:
2229         (ReRunWebKitTests.evaluateCommand): Drive-by fix to correct the pluralization.
2230         (AnalyzeLayoutTestsResults.report_pre_existing_failures): Append the flaky failure information.
2231         (AnalyzeLayoutTestsResults.start):
2232
2233 2020-02-10  Aakash Jain  <aakash_jain@apple.com>
2234
2235         [ews] Use SetBuildSummary instead of buildFinished in Layout tests
2236         https://bugs.webkit.org/show_bug.cgi?id=207492
2237
2238         Reviewed by Jonathan Bedard.
2239
2240         * BuildSlaveSupport/ews-build/steps.py:
2241         (RunWebKitTests.evaluateCommand):
2242         (ReRunWebKitTests.evaluateCommand):
2243         (AnalyzeLayoutTestsResults.report_pre_existing_failures):
2244         * BuildSlaveSupport/ews-build/factories.py:
2245         (TestFactory.__init__):
2246
2247 2020-02-10  Truitt Savell  <tsavell@apple.com>
2248
2249         Unreviewed, rolling out r256091.
2250
2251         Broke internal builds
2252
2253         Reverted changeset:
2254
2255         "Move trivial definitions from FeatureDefines.xcconfig to
2256         PlatformEnableCocoa.h"
2257         https://bugs.webkit.org/show_bug.cgi?id=207155
2258         https://trac.webkit.org/changeset/256091
2259
2260 2020-02-10  Truitt Savell  <tsavell@apple.com>
2261
2262         Unreviewed, rolling out r256103.
2263
2264         This patch is blocking the rollout of r256091
2265
2266         Reverted changeset:
2267
2268         "Move JavaScriptCore related feature defines from
2269         FeatureDefines.xcconfig to PlatformEnableCocoa.h"
2270         https://bugs.webkit.org/show_bug.cgi?id=207436
2271         https://trac.webkit.org/changeset/256103
2272
2273 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
2274
2275         results.webkit.org: Abstract archive storage solutions
2276         https://bugs.webkit.org/show_bug.cgi?id=207277
2277
2278         Rubber-stamped by Aakash Jain.
2279
2280         * resultsdbpy/resultsdbpy/model/archive_context.py:
2281         (ArchiveContext):
2282         (ArchiveContext.ArchiveMetaDataByCommit.unpack):
2283         (ArchiveContext.__init__): Add archiver member.
2284         (ArchiveContext.__enter__): archiver is a context manager.
2285         (ArchiveContext.__exit__): Ditto.
2286         (ArchiveContext.register): The archiver member owns saving an archive.
2287         (ArchiveContext.find_archive): The archiver member owns retrieving an archive.
2288         (ArchiveContext.ArchiveChunks): Move to CassandraArchiver.
2289         * resultsdbpy/resultsdbpy/model/archiver.py: Added.
2290         (Archiver): Base class for all Archiving systems.
2291         (Archiver.archive_digest): Given a file-like archive, calculate it's digest.
2292         (Archiver.archive_size): Given a file-like archive, calculate it's size.
2293         (Archiver.save):
2294         (Archiver.retrieve):
2295         * resultsdbpy/resultsdbpy/model/cassandra_archiver.py: Added.
2296         (CassandraArchiver):
2297         (CassandraArchiver.ArchiveChunks): Moved from ArchiveContext.
2298         (CassandraArchiver.__init__):
2299         (CassandraArchiver.__enter__):
2300         (CassandraArchiver.__exit__):
2301         (CassandraArchiver.save): Split the provided archive into chunks for saving, moved
2302         from ArchiveContext.
2303         (CassandraArchiver.retrieve): Retrieve an archive with the provided hash, moved
2304         from ArchiveContext.
2305
2306 2020-02-09  Lauro Moura  <lmoura@igalia.com>
2307
2308         [GTK][WPE] Expose allowTopNavigationToDataURL
2309         https://bugs.webkit.org/show_bug.cgi?id=207384
2310
2311         Reviewed by Adrian Perez de Castro.
2312
2313         Updates with new "allow-top-navigation-to-data-urls" property.
2314
2315         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
2316         (testWebViewAllowModalDialogs): This test requires this property to be
2317         set.
2318         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2319         (testWebKitSettings): Added tests for getter/setter.
2320
2321 2020-02-08  Sam Weinig  <weinig@apple.com>
2322
2323         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2324         https://bugs.webkit.org/show_bug.cgi?id=207436
2325
2326         Reviewed by Tim Horton.
2327
2328         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2329         Remove ENABLE_FAST_JIT_PERMISSIONS and ENABLE_FTL_JIT.
2330
2331 2020-02-08  Yusuke Suzuki  <ysuzuki@apple.com>
2332
2333         [WTF] Try using 75% load factor for HashTable
2334         https://bugs.webkit.org/show_bug.cgi?id=207183
2335
2336         Reviewed by Mark Lam.
2337
2338         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2339         (TestWebKitAPI::testInitialCapacity):
2340
2341 2020-02-08  Sam Weinig  <weinig@apple.com>
2342
2343         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2344         https://bugs.webkit.org/show_bug.cgi?id=207155
2345
2346         Reviewed by Tim Horton.
2347
2348         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
2349         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
2350         also has a default value in PlatformEnable.h
2351
2352         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2353
2354 2020-02-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2355
2356         Several iOS API tests that call -makeKeyWindow assert after r255907
2357         https://bugs.webkit.org/show_bug.cgi?id=207411
2358
2359         Reviewed by Tim Horton.
2360
2361         r255907 asserted in -makeKeyWindow that the shared UIApplication exists. While this was guaranteed for all call
2362         sites of -makeKeyWindow from API tests, -makeKeyWindow may also be invoked from within UIKit code; in this case,
2363         nothing guarantees that the application has been initialized, and we end up hitting this assertion. To fix this,
2364         replace the assertion with logic to bootstrap the shared UIApplication (if it didn't already exist).
2365
2366         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2367         (TestWebKitAPI::TEST):
2368         (TestWebKitAPI::overrideBundleIdentifier): Deleted.
2369         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2370         (overrideBundleIdentifier):
2371         (setOverriddenApplicationKeyWindow):
2372
2373 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2374
2375         TestWebKitAPI: Disable legacy ActionSheet tests on Catalyst
2376         https://bugs.webkit.org/show_bug.cgi?id=207405
2377
2378         Reviewed by Wenson Hsieh.
2379
2380         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2381
2382 2020-02-07  Alex Christensen  <achristensen@apple.com>
2383
2384         Remember if we used legacy TLS in the back/forward cache like we remember if we have only secure content
2385         https://bugs.webkit.org/show_bug.cgi?id=207409
2386         rdar://problem/59275641
2387
2388         Reviewed by Chris Dumez.
2389
2390         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2391         (TestWebKitAPI::TEST):
2392
2393 2020-02-07  Ryan Haddad  <ryanhaddad@apple.com>
2394
2395         Unreviewed, rolling out r256051.
2396
2397         Broke internal builds.
2398
2399         Reverted changeset:
2400
2401         "Move trivial definitions from FeatureDefines.xcconfig to
2402         PlatformEnableCocoa.h"
2403         https://bugs.webkit.org/show_bug.cgi?id=207155
2404         https://trac.webkit.org/changeset/256051
2405
2406 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2407
2408         iPad testers failing to launch processes
2409         https://bugs.webkit.org/show_bug.cgi?id=207401
2410         <rdar://problem/58184777>
2411
2412         Unreviewed infrastructure fix.
2413
2414         This is a speculative fix because I've had problems reproducing this error.
2415         The only time I managed to reproduce the problem was immediately after killing the 
2416         SimulatorTrampoline and CoreSimulator.xpc processes.
2417
2418         * BuildSlaveSupport/kill-old-processes:
2419         (main): Only kill Simulator.app, not all associated simulator processes.
2420
2421 2020-02-07  Jiewen Tan  <jiewen_tan@apple.com>
2422
2423         [WebAuthn] Report CTAP Client Pin Error to clients
2424         https://bugs.webkit.org/show_bug.cgi?id=205837
2425         <rdar://problem/58356872>
2426
2427         Reviewed by Brent Fulgham.
2428
2429         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2430         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
2431         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
2432         (TestWebKitAPI::TEST):
2433         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2434         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-pin-invalid-error-retry.html: Added.
2435         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2436         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-blocked-error.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2437         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-auth-invalid-error-retry.html: Added.
2438         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-blocked-error.html: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-error.html.
2439         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-get-pin-token-pin-invalid-error-retry.html: Added.
2440         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-hid-pin-invalid-error-retry.html: Added.
2441
2442 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2443
2444         run-safari Doesn't work with the latest Xcode version and iOS
2445         https://bugs.webkit.org/show_bug.cgi?id=207394
2446
2447         Reviewed by Ryosuke Niwa.
2448
2449         * Scripts/webkitdirs.pm:
2450         (iosSimulatorRuntime): Determine the runtime from valid runtimes.
2451         (findOrCreateSimulatorForIOSDevice): iPhone 5 is unsupported, remove code.
2452
2453 2020-02-07  Daniel Bates  <dabates@apple.com>
2454
2455         Legacy WebKit: Have linkedOnOrAfter() respect the NSDefault WebKitLinkedOnOrAfterEverything and opt DumpRenderTree in
2456         https://bugs.webkit.org/show_bug.cgi?id=207366
2457
2458         Reviewed by Brent Fulgham.
2459
2460         Enable default WebKitLinkedOnOrAfterEverything in DumpRenderTree just as we do in WebKitTestRunner.
2461         This lets me put test results for Mac and iOS Legacy WebKit in the same cross-platform directory
2462         as the actual test instead of under a platform-specific directory even when the tests' behavior
2463         depends on the link-time version of WebKit.
2464
2465         Note that testing of pre-linked behavior can still be accomplished by test writers by exposing settings
2466         and toggling them in a test.
2467
2468         * DumpRenderTree/mac/DumpRenderTree.mm:
2469         (setDefaultsToConsistentValuesForTesting):
2470
2471 2020-02-03  Sam Weinig  <weinig@apple.com>
2472
2473         Move trivial definitions from FeatureDefines.xcconfig to PlatformEnableCocoa.h
2474         https://bugs.webkit.org/show_bug.cgi?id=207155
2475
2476         Reviewed by Tim Horton.
2477
2478         Move all trivial definitions (just ENABLE_FOO = ENABLE_FOO; or ENABLE_BAR = ;)
2479         from the FeatureDefines.xcconfigs to PlatformEnableCocoa.h, ensuring each one
2480         also has a default value in PlatformEnable.h
2481
2482         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2483
2484 2020-02-07  Kate Cheney  <katherine_cheney@apple.com>
2485
2486         Update WebView category name to be more accurate
2487         https://bugs.webkit.org/show_bug.cgi?id=207334
2488         <rdar://problem/59224855>
2489
2490         Reviewed by Brent Fulgham.
2491
2492         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
2493         (TEST):
2494
2495 2020-02-07  Aakash Jain  <aakash_jain@apple.com>
2496
2497         [ews] add commit-queue build step to close the bug
2498         https://bugs.webkit.org/show_bug.cgi?id=207387
2499
2500         Reviewed by Jonathan Bedard.
2501
2502         * BuildSlaveSupport/ews-build/steps.py:
2503         (BugzillaMixin.close_bug): Method to close the bugzilla bug.
2504         (CloseBug): Build step to close bugzilla bug.
2505
2506 2020-02-05  Aakash Jain  <aakash_jain@apple.com>
2507
2508         [ews] add commit-queue build step to clear flags on patch
2509         https://bugs.webkit.org/show_bug.cgi?id=206536
2510
2511         Reviewed by Jonathan Bedard.
2512
2513         * BuildSlaveSupport/ews-build/steps.py:
2514         (BugzillaMixin): Class for common bugzilla related methods.
2515         (BugzillaMixin.get_bugzilla_api_key): Method to read bugzilla api key from file.
2516         (BugzillaMixin.remove_flags_on_patch): Method to remove flags on patch.
2517         (ValidatePatch):
2518         (RemoveFlagsOnPatch): Class to remove flags on patch.
2519         (RemoveFlagsOnPatch.start):
2520         (ValidatePatch._addToLog): Moved.
2521         (ValidatePatch.fetch_data_from_url): Moved.
2522         (ValidatePatch.get_patch_json): Moved.
2523         (ValidatePatch.get_bug_json): Moved.
2524         (ValidatePatch.get_bug_id_from_patch): Moved.
2525         (ValidatePatch._is_patch_obsolete): Moved.
2526         (ValidatePatch._is_patch_review_denied): Moved.
2527         (ValidatePatch._is_patch_cq_plus): Moved.
2528         (ValidatePatch._is_bug_closed): Moved.
2529
2530 2020-02-07  Jonathan Bedard  <jbedard@apple.com>
2531
2532         EWS should run resultsdbpy tests
2533         https://bugs.webkit.org/show_bug.cgi?id=201928
2534
2535         Reviewed by Aakash Jain.
2536
2537         * BuildSlaveSupport/ews-build/factories.py:
2538         (ServicesFactory.__init__): Add RunResultsdbpyTests.
2539         * BuildSlaveSupport/ews-build/factories_unittest.py:
2540         (TestTestsFactory.test_services_factory): Add RunResultsdbpyTests.
2541         * BuildSlaveSupport/ews-build/steps.py:
2542         (CheckPatchRelevance): resultsdbpy changes should trigger service tests.
2543         (RunResultsdbpyTests): Add step which runs resultsdbpy tests.
2544         * BuildSlaveSupport/ews-build/steps_unittest.py:
2545         (TestRunResultsdbpyTests):
2546         (TestRunResultsdbpyTests.setUp):
2547         (TestRunResultsdbpyTests.tearDown):
2548         (TestRunResultsdbpyTests.test_success):
2549         (TestRunResultsdbpyTests.test_failure):
2550
2551 2020-02-07  Jacob Uphoff  <jacob_uphoff@apple.com>
2552
2553         Adding myself to contributors.json
2554         
2555         Unreviewed
2556
2557         * Scripts/webkitpy/common/config/contributors.json:
2558
2559 2020-02-07  Jason Lawrence  <lawrence.j@apple.com>
2560
2561         Adding myself to contributors.json
2562         
2563         Unreviewed
2564
2565         * Scripts/webkitpy/common/config/contributors.json:
2566
2567 2020-02-07  Patrick Griffis  <pgriffis@igalia.com>
2568
2569         [GTK][WPE] Add same-site cookie support
2570         https://bugs.webkit.org/show_bug.cgi?id=204137
2571
2572         Reviewed by Carlos Garcia Campos.
2573
2574         Update libsoup to 2.69.90 in JHBuild.
2575
2576         * gtk/jhbuild.modules:
2577         * wpe/jhbuild.modules:
2578
2579 2020-02-07  Yusuke Suzuki  <ysuzuki@apple.com>
2580
2581         Unreviewed, revert 75% load-factor because of JetStream2/string-unpack-code-SP regression
2582         https://bugs.webkit.org/show_bug.cgi?id=207183
2583
2584         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2585         (TestWebKitAPI::testInitialCapacity):
2586
2587 2020-02-06  Wenson Hsieh  <wenson_hsieh@apple.com>
2588
2589         WebPage::rangeForGranularityAtPoint always returns null in the case of CharacterGranularity
2590         https://bugs.webkit.org/show_bug.cgi?id=207350
2591         <rdar://problem/59239914>
2592
2593         Reviewed by Tim Horton.
2594
2595         Add a test to exercise the corner case in the SPI.
2596
2597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2598         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm: Added.
2599
2600 2020-02-06  Jiewen Tan  <jiewen_tan@apple.com>
2601
2602         Adopt new SOAuthorizationOption constants
2603         https://bugs.webkit.org/show_bug.cgi?id=207186
2604         <rdar://problem/48909336>
2605
2606         Reviewed by Brent Fulgham.
2607
2608         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2609         (checkAuthorizationOptions):
2610
2611 2020-02-06  Brady Eidson  <beidson@apple.com>
2612
2613         Cleanup and promote WKContentWorld and its clients in WKWebView.
2614         https://bugs.webkit.org/show_bug.cgi?id=207351
2615
2616         Reviewed by Alex Christensen.
2617
2618         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
2619         (TestWebKitAPI::TEST):
2620         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2621         (TEST):
2622         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2623         (-[WKWebView objectByCallingAsyncFunction:withArguments:error:]):
2624
2625 2020-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
2626
2627         [Win][MiniBrowser] Accelerator keys don't work unless the main window is focused
2628         https://bugs.webkit.org/show_bug.cgi?id=207250
2629
2630         Reviewed by Alex Christensen.
2631
2632         MiniBrowser has shortcut keys, Ctrl-W to close window, Ctrl-R to
2633         reload. However, they don't work unless the main window is
2634         focused.
2635
2636         Ctrl-W should be processed differently. Ctrl-W should be handled
2637         without dispatching to WebKit, others should be handled only when
2638         WebKit didn't consume. So, this change split the accelerator table
2639         into two, one is for Ctrl-W, another is for other shortcut keys.
2640
2641         For Ctrl-W, key events are processed before dispatching to
2642         WebView. It is converted to IDM_CLOSE_WINDOW of WM_COMMAND, and
2643         dispatched to WebView. WebKit2 WebView bubbles up unhandled
2644         WM_COMMAND to the parent window. Then, IDM_CLOSE_WINDOW is handled
2645         in the main window's WndProc. However, it doesn't work for WebKit1
2646         because this change doesn't add the bubbling up code to WebKit1
2647         WebView.
2648
2649         For other shortcut keys, for example Ctrl-R, key events are
2650         dispatched to WebView without accelerator key translations. Then,
2651         WebKitBrowserWindow::didNotHandleKeyEvent is called back if they
2652         aren't consumed. didNotHandleKeyEvent posts the messasge to the
2653         main window. The message loop processed key events dispatched to
2654         the main window with another accelerator table. However, it
2655         doesn't work for WebKit1, because WebKit1 doesn't have a API
2656         equivalent to didNotHandleKeyEvent.
2657
2658         After switching the active window by pressing Alt-Tab and
2659         reactivating the main window, the main window got the focus. This
2660         was the reason shortcut keys worked only after reactivating the
2661         main window. But, this is not the desired behavior after this
2662         change because other shortcut keys don't work if the main window
2663         is focused. So. set the focus to the brower window when
2664         WM_ACTIVATE of the main window.
2665
2666         Shortcut keys Ctrl++ (zoom in) and Ctrl+- (zoom out) were
2667         effective only for keyboard numpad. Add VK_OEM_MINUS and
2668         VK_OEM_PLUS for them.
2669
2670         Add a shortcut key Ctrl-0 to reset page zoom scale to actual.
2671
2672         * MiniBrowser/win/MainWindow.cpp:
2673         (MainWindow::isInstance):
2674         (MainWindow::WndProc):
2675         * MiniBrowser/win/MainWindow.h:
2676         * MiniBrowser/win/MiniBrowserLib.rc: Add a new accelerator table
2677         IDR_ACCELERATORS_PRE for Ctrl-W.
2678         * MiniBrowser/win/MiniBrowserLibResource.h:
2679         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2680         (WebKitBrowserWindow::didNotHandleKeyEvent):
2681         * MiniBrowser/win/WinMain.cpp:
2682         (wWinMain):
2683
2684 2020-02-06  Jonathan Bedard  <jbedard@apple.com>
2685
2686         results.webkitorg: Dead CI links
2687         https://bugs.webkit.org/show_bug.cgi?id=207340
2688
2689         Reviewed by Alexey Proskuryakov.
2690
2691         * resultsdbpy/resultsdbpy/view/static/js/configuration.js:
2692         (Configuration.prototype.toParams): Version name and version number often duplicate the
2693         same information, exception version number is often more specific than is useful.
2694
2695 2020-02-06  Brent Fulgham  <bfulgham@apple.com>
2696
2697         Prevent navigating top level frames to Data URLs
2698         https://bugs.webkit.org/show_bug.cgi?id=206962
2699         <rdar://problem/56770676>
2700
2701         Reviewed by Youenn Fablet.
2702
2703         Revise test running code to allow data URL navigations by default, since they are so frequently
2704         used in testing. However, provide a flag to turn this off in tests so we can confirm proper
2705         function.
2706
2707         * DumpRenderTree/TestOptions.cpp:
2708         (TestOptions::TestOptions):
2709         * DumpRenderTree/TestOptions.h:
2710         * DumpRenderTree/mac/DumpRenderTree.mm:
2711         (setWebPreferencesForTestOptions):
2712         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2713         (DownloadAttributeDoesNotStartDownloads): Revise configuration to allow script navigation of the main frame to a Data URL.
2714         (StartDownloadWithDownloadAttribute): Ditto.
2715         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
2716         (WebViewWillPerformClientRedirect): Ditto.
2717         (WebViewDidCancelClientRedirect): Ditto.
2718         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2719         (NavigateToDataURLThenBack): Ditto.
2720         (ContentExtensionBlocksMainLoadThenReloadWithoutExtensions): Ditto.
2721         * WebKitTestRunner/TestController.cpp:
2722         (WTR::TestController::resetPreferencesToConsistentValues):
2723         (WTR::updateTestOptionsFromTestHeader):
2724         * WebKitTestRunner/TestOptions.h:
2725         (WTR::TestOptions::hasSameInitializationOptions const):
2726         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2727         (WTR::initializeWebViewConfiguration):
2728         (WTR::TestController::platformCreateWebView):
2729
2730 2020-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2731
2732         [iOS] Provide a way to suppress software keyboards on WKWebView's WKContentView
2733         https://bugs.webkit.org/show_bug.cgi?id=207272
2734         <rdar://problem/59190828>
2735
2736         Reviewed by Tim Horton.
2737
2738         Add an API test to verify (through UIKeyboardImpl) that the software keyboard should be suppressed when setting
2739         -_setSuppressSoftwareKeyboard: on the web view. This involves making `-makeKeyWindow` "work" in the API testing
2740         environment on iOS, by swizzling out both `-[NSBundle bundleIdentifier]` and `-[UIApplication keyWindow]`.
2741
2742         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
2743         (TestWebKitAPI::overrideBundleIdentifier):
2744         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2745         (setOverriddenApplicationKeyWindow):
2746         (applicationKeyWindowOverride):
2747         (-[TestWKWebViewHostWindow makeKeyWindow]):
2748         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
2749         * TestWebKitAPI/ios/UIKitSPI.h:
2750
2751         Also move the `UIResponder (UIKitSPI)` category from the internal section to the SPI section; this is redundant
2752         when using the internal SDK to build, since these methods are already declared in UIResponder_Private.h.
2753
2754 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
2755
2756         [PlayStation] Build a shared JavaScriptCore
2757         https://bugs.webkit.org/show_bug.cgi?id=198446
2758
2759         Reviewed by Fujii Hironori.
2760
2761         Add TARGET_OBJECTS for bmalloc and WTF so TestWTF links.
2762
2763         * TestWebKitAPI/PlatformPlayStation.cmake:
2764
2765 2020-02-05  Stephan Szabo  <stephan.szabo@sony.com>
2766
2767         [WinCairo] Set up fonts for layout tests for test bot image
2768         https://bugs.webkit.org/show_bug.cgi?id=207223
2769
2770         Reviewed by Fujii Hironori.
2771
2772         * WebKitTestRunner/InjectedBundle/win/ActivateFontsWin.cpp:
2773           Implement activateFonts to load fonts for test
2774
2775 2020-02-05  Don Olmstead  <don.olmstead@sony.com>
2776
2777         [PlayStation] Miscellaneous build fixes February 2020 edition
2778         https://bugs.webkit.org/show_bug.cgi?id=207312
2779
2780         Unreviewed build fix.
2781
2782         * TestWebKitAPI/PlatformWebView.h: Remove #elif guard and just use #else
2783
2784 2020-02-05  Yusuke Suzuki  <ysuzuki@apple.com>
2785
2786         [WTF] Try using 75% load factor for HashTable
2787         https://bugs.webkit.org/show_bug.cgi?id=207183
2788
2789         Reviewed by Mark Lam.
2790
2791         Fix load-factor assumption in existing tests.
2792
2793         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2794         (TestWebKitAPI::testInitialCapacity):
2795
2796 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
2797
2798         resulsdbpy: Fix unit tests
2799         https://bugs.webkit.org/show_bug.cgi?id=207304
2800
2801         Reviewed by Aakash Jain.
2802
2803         * resultsdbpy/resultsdbpy/model/configuration_context_unittest.py:
2804         (ConfigurationContextTest.test_partition_by_configuration): Add branch to testing table.
2805         (ConfigurationContextTest.test_partition_by_partial_configuration): Ditto.
2806         * resultsdbpy/resultsdbpy/model/failure_context_unittest.py:
2807         (FailureContextTest.test_failures): Sort test failures by uuid for a predictable order in testing.
2808         (FailureContextTest.test_unexpected_failures): Ditto.
2809         * resultsdbpy/resultsdbpy/model/mock_model_factory.py:
2810         (MockModelFactory.iterate_all_commits): Do not batch requests since this function has no way
2811         of knowing how expensive the callback may be.
2812
2813 2020-02-05  Chris Dumez  <cdumez@apple.com>
2814
2815         Unreviewed, another build fix after r255846
2816
2817         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2818
2819 2020-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2820
2821         Unreviewed infrastructure fix.
2822
2823         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2824         (WebKitBuildbot): Delete entries for queues that have been removed from buildbot.
2825
2826 2020-02-05  Chris Dumez  <cdumez@apple.com>
2827
2828         Unreviewed build fix after r255846.
2829
2830         * TestWebKitAPI/cocoa/HTTPServer.h:
2831
2832 2020-02-05  Jiewen Tan  <jiewen_tan@apple.com>
2833
2834         Defer ending AppSSO sheets til NSWindowDidDeminiaturize or NSApplicationDidUnhide
2835         https://bugs.webkit.org/show_bug.cgi?id=207173
2836         <rdar://problem/55669065>
2837
2838         Reviewed by Brent Fulgham.
2839
2840         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
2841         (TestWebKitAPI::TEST):
2842         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2843         (-[TestWKWebView _setUpTestWindow:]):
2844         Make the TestWKWebViewHostWindow miniaturizable to enable the test.
2845
2846 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
2847
2848         results.webkit.org: Apply ttl to archive shards
2849         https://bugs.webkit.org/show_bug.cgi?id=207295
2850
2851         Rubber-stamped by Aakash Jain.
2852
2853         * resultsdbpy/resultsdbpy/model/archive_context.py:
2854         (ArchiveContext.ArchiveMetaDataByCommit): Use new table.
2855         (ArchiveContext.ArchiveChunks): Use new table.
2856         (ArchiveContext.register): Add ttl to archive shards.
2857
2858 2020-02-05  Alex Christensen  <achristensen@webkit.org>
2859
2860         Make WKWebView._negotiatedLegacyTLS accurate when loading main resouorce from network or cache
2861         https://bugs.webkit.org/show_bug.cgi?id=207207
2862
2863         Reviewed by Chris Dumez.
2864
2865         HTTPServer now supports HTTPS. Tell your friends!
2866
2867         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
2868         (testCertificate):
2869         (testIdentity):
2870         (credentialWithIdentity):
2871         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
2872         (TestWebKitAPI::webViewWithNavigationDelegate):
2873         (TestWebKitAPI::TEST):
2874         * TestWebKitAPI/cocoa/HTTPServer.h:
2875         * TestWebKitAPI/cocoa/HTTPServer.mm:
2876         (TestWebKitAPI::HTTPServer::HTTPServer):
2877         (TestWebKitAPI::HTTPServer::request const):
2878
2879 2020-02-05  Brady Eidson  <beidson@apple.com>
2880
2881         _WKDownload should expose the originating FrameInfo.
2882         <rdar://problem/58022576> and https://bugs.webkit.org/show_bug.cgi?id=207185
2883
2884         Reviewed by Geoff Garen.
2885
2886         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
2887         (-[DownloadTestSchemeDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
2888         (-[DownloadSecurityOriginDelegate _downloadDidStart:]):
2889         (loaded):
2890         * TestWebKitAPI/cocoa/HTTPServer.mm:
2891
2892 2020-02-05  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2893
2894         [GTK] Fix dependencies build
2895         https://bugs.webkit.org/show_bug.cgi?id=207273
2896
2897         Reviewed by Carlos Garcia Campos.
2898
2899         * gtk/jhbuild.modules: Bumped wpebackend-fdo version to 1.4.1 and
2900         added mesa as one of its deps. Added the xserver patch as well.
2901         * gtk/patches/xserver-gl-version.patch: Added.
2902
2903 2020-02-05  Chris Dumez  <cdumez@apple.com>
2904
2905         REGRESSION(r255595): page not closed after beforeunload handler returns true
2906         https://bugs.webkit.org/show_bug.cgi?id=207189
2907         <rdar://problem/59149593>
2908
2909         Reviewed by Youenn Fablet.
2910
2911         Add API test coverage for fix landed in r255677.
2912
2913         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
2914         (-[SlowBeforeUnloadPromptUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2915         (TEST):
2916
2917 2020-02-05  Jonathan Bedard  <jbedard@apple.com>
2918
2919         results.webkit.org should disable auto-capitalize over the search field
2920         https://bugs.webkit.org/show_bug.cgi?id=207240
2921         <rdar://problem/59053042>
2922
2923         Rubber-stamped by Aakash Jain.
2924
2925         * resultsdbpy/resultsdbpy/view/static/js/search.js:
2926
2927 2020-02-01  Darin Adler  <darin@apple.com>
2928
2929         Replace RGBA32 typedef with a class to improve type safety
2930         https://bugs.webkit.org/show_bug.cgi?id=206862
2931
2932         Reviewed by Sam Weinig.
2933
2934         * TestWebKitAPI/Tests/WebKitCocoa/PDFSnapshot.mm:
2935         (TestWebKitAPI::TEST): Use the Color constructor instead of Color::createUnchecked.
2936
2937 2020-02-04  Darin Adler  <darin@apple.com>
2938
2939         Remove NSKeyedArchiverSPI.h now that WebKit only uses API
2940         https://bugs.webkit.org/show_bug.cgi?id=207203
2941
2942         Reviewed by Anders Carlsson.
2943
2944         * TestWebKitAPI/Tests/WebKitCocoa/ApplicationManifest.mm: Removed
2945         include of NSKeyedArchiverSPI.h and call methods of NSKeyedArchiver directly.
2946         * TestWebKitAPI/Tests/WebKitCocoa/Coding.mm: Ditto.
2947         * TestWebKitAPI/Tests/ios/WKWebViewOpaque.mm: Ditto.
2948         * TestWebKitAPI/Tests/mac/EarlyKVOCrash.mm: Ditto.
2949
2950 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
2951
2952         results.webkit.org: Support Internal in run-javascriptcore-tests
2953         https://bugs.webkit.org/show_bug.cgi?id=204095
2954
2955         Rubber-stamped by Aakash Jain.
2956
2957         * Scripts/VCSUtils.pm:
2958         (gitBisectStartBranchForDirectory): Renamed from gitBisectStartBranch.
2959         (gitBranchForDirectory): Compute branch for directory.
2960         (gitBranch): Compute branch for the current git directory.
2961         (commitForDirectory): Add git support.
2962         (gitBisectStartBranch): Renamed to gitBisectStartBranchForDirectory.
2963         * Scripts/run-javascriptcore-tests:
2964         (uploadResults): Check for Internal repository.
2965
2966 2020-02-04  Alex Christensen  <achristensen@webkit.org>
2967
2968         REGRESSION: (r255611) [ Mac ] 3 lldb tests failing related to HashMap
2969         https://bugs.webkit.org/show_bug.cgi?id=207204
2970
2971         Reviewed by Simon Fraser.
2972
2973         Remove support for HashSet and HashMap until we are able to do the equivalent of reinterpret_cast<unsigned*>(pointer)[-1]
2974         in LLDB's python API.
2975
2976         * lldb/lldb_webkit_unittest.py:
2977         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
2978         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
2979         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
2980
2981 2020-02-04  Lauro Moura  <lmoura@igalia.com>
2982
2983         [EWS] Stop GTK/WPE build if jhbuild fails.
2984         https://bugs.webkit.org/show_bug.cgi?id=207220
2985
2986         Reviewed by Adrian Perez de Castro.
2987
2988         * BuildSlaveSupport/ews-build/steps.py:
2989         (InstallGtkDependencies): Halt on failure
2990         (InstallWpeDependencies): Ditto
2991
2992 2020-02-04  Alex Christensen  <achristensen@webkit.org>
2993
2994         Fix Mac CMake build
2995         https://bugs.webkit.org/show_bug.cgi?id=207231
2996
2997         * DumpRenderTree/PlatformMac.cmake:
2998         * MiniBrowser/mac/CMakeLists.txt:
2999         * MiniBrowser/mac/WK2BrowserWindowController.m:
3000         (-[WK2BrowserWindowController awakeFromNib]):
3001         * WebKitTestRunner/PlatformMac.cmake:
3002
3003 2020-02-04  Don Olmstead  <don.olmstead@sony.com>
3004
3005         [PlayStation] Enable TestWebKit
3006         https://bugs.webkit.org/show_bug.cgi?id=207211
3007
3008         Reviewed by Ross Kirsling.
3009
3010         Stub out PlayStation implementation of TestWebKit so it builds.
3011
3012         * TestWebKitAPI/PlatformPlayStation.cmake:
3013         * TestWebKitAPI/PlatformWebView.h: Simplify platform define
3014         * TestWebKitAPI/playstation/PlatformUtilitiesPlayStation.cpp: Added.
3015         (TestWebKitAPI::Util::createInjectedBundlePath):
3016         (TestWebKitAPI::Util::createURLForResource):
3017         (TestWebKitAPI::Util::URLForNonExistentResource):
3018         (TestWebKitAPI::Util::isKeyDown):
3019         * TestWebKitAPI/playstation/PlatformWebViewPlayStation.cpp: Added.
3020         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3021         (TestWebKitAPI::PlatformWebView::~PlatformWebView):
3022         (TestWebKitAPI::PlatformWebView::initialize):
3023         (TestWebKitAPI::PlatformWebView::page const):
3024         (TestWebKitAPI::PlatformWebView::resizeTo):
3025         (TestWebKitAPI::PlatformWebView::focus):
3026         (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
3027         (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
3028         (TestWebKitAPI::PlatformWebView::simulateMouseMove):
3029         (TestWebKitAPI::PlatformWebView::simulateRightClick):
3030
3031 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3032
3033         results.webkit.org: Support branches in run-javascriptcore-tests
3034         https://bugs.webkit.org/show_bug.cgi?id=204094
3035
3036         Rubber-stamped by Aakash Jain.
3037
3038         * Scripts/run-javascriptcore-tests:
3039         (uploadResults): Use webkitdirs function to generate commit information.
3040         * Scripts/VCSUtils.pm:
3041         (commitForDirectory): Generate commit information for SVN repository, including
3042         branch name.
3043
3044 2020-02-04  Matt Lewis  <jlewis3@apple.com>
3045
3046         Replace bot677 due to hardware failure
3047         https://bugs.webkit.org/show_bug.cgi?id=207224
3048
3049         Reviewed by Aakash Jain.
3050
3051         * BuildSlaveSupport/build.webkit.org-config/config.json:
3052
3053 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3054
3055         TestWebKitAPI: Handle case where test result does not contain path
3056         https://bugs.webkit.org/show_bug.cgi?id=207216
3057
3058         Reviewed by Tim Horton.
3059
3060         * TestWebKitAPI/TestsController.cpp:
3061         (TestWebKitAPI::Printer::OnTestPartResult): It's possible that the TestPartResult
3062         will not contain a file name. We should handle this case.
3063
3064 2020-02-04  Jonathan Bedard  <jbedard@apple.com>
3065
3066         results.webkit.org: Better order upload callbacks
3067         https://bugs.webkit.org/show_bug.cgi?id=207219
3068
3069         Reviewed by Aakash Jain.
3070
3071         Order upload callbacks more deliberately so that the quickest callbacks
3072         that are least likely to link to information from unfinished callbacks are
3073         executed first.
3074
3075         * resultsdbpy/resultsdbpy/model/model.py:
3076         (Model.__init__): Generate buildbot links first, then generate a failure
3077         list, then generate the collective suite results and finally, individual
3078         test results.
3079
3080 2020-02-04  Aakash Jain  <aakash_jain@apple.com>
3081
3082         [EWS] Do not remove TestWebKitAPI prefix from api test failures
3083         https://bugs.webkit.org/show_bug.cgi?id=207210
3084
3085         Reviewed by Jonathan Bedard.
3086
3087         * BuildSlaveSupport/ews-build/steps.py:
3088         (AnalyzeAPITestsResults.analyzeResults):
3089
3090 2020-02-04  Aakash Jain  <aakash_jain@apple.com>
3091
3092         [EWS] Do not remove webkitpy prefix from test failures
3093         https://bugs.webkit.org/show_bug.cgi?id=207206
3094
3095         Reviewed by Jonathan Bedard.
3096
3097         * BuildSlaveSupport/ews-build/steps.py:
3098         (WebKitPyTest.getResultSummary): Do not remove 'webkitpy' from test name. Also handled the
3099         case when json output doesn't have failures/errors key.
3100         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3101
3102 2020-02-04  Ross Kirsling  <ross.kirsling@sony.com>
3103
3104         [CMake] Add Cairo::Cairo target
3105         https://bugs.webkit.org/show_bug.cgi?id=207159
3106
3107         Reviewed by Konstantin Tokarev.
3108
3109         * DumpRenderTree/PlatformWin.cmake:
3110         * ImageDiff/Cairo.cmake:
3111         * TestWebKitAPI/PlatformWPE.cmake:
3112         * TestWebKitAPI/PlatformWin.cmake:
3113         * TestWebKitAPI/glib/CMakeLists.txt:
3114         * WebKitTestRunner/PlatformGTK.cmake:
3115         * WebKitTestRunner/PlatformWPE.cmake:
3116         * WebKitTestRunner/PlatformWin.cmake:
3117         * wpe/backends/CMakeLists.txt:
3118
3119 2020-02-03  Jiewen Tan  <jiewen_tan@apple.com>
3120
3121         Pass a hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy
3122         https://bugs.webkit.org/show_bug.cgi?id=207079
3123         <rdar://problem/48290464>
3124
3125         Reviewed by Brent Fulgham.
3126
3127         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
3128         (-[TestSOAuthorizationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
3129         (overrideGetAuthorizationHintsWithURL):
3130         (TestWebKitAPI::TEST):
3131
3132 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
3133
3134         results.webkit.org: Support jsc stress tests
3135         https://bugs.webkit.org/show_bug.cgi?id=204096
3136
3137         Rubber-stamped by Aakash Jain.
3138
3139         * Scripts/run-javascriptcore-tests:
3140         (runJSCStressTests): Add pass and failures to reported results.
3141
3142 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
3143
3144         Make Bugzilla._find_select_element_for_flag more robust
3145         https://bugs.webkit.org/show_bug.cgi?id=207148
3146
3147         Reviewed by Jonathan Bedard.
3148
3149         This patch resolves two FIXMEs:
3150         1. _find_select_element_for_flag() is now used in _fill_attachment_form() method.
3151         2. _find_select_element_for_flag() now does not rely on order of <select> elements.
3152
3153         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3154         (Bugzilla._fill_attachment_form):
3155         (Bugzilla._find_select_element_for_flag):
3156
3157 2020-02-03  Alex Christensen  <achristensen@webkit.org>
3158
3159         Reduce size of HashMap and HashSet
3160         https://bugs.webkit.org/show_bug.cgi?id=207138
3161
3162         Reviewed by Yusuke Suzuki.
3163
3164         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
3165         (TestWebKitAPI::TEST):
3166         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
3167         (TestWebKitAPI::TEST):
3168
3169 2020-02-03  Alexey Shvayka  <shvaikalesh@gmail.com>
3170
3171         obsolete_attachment should not fail when flags do not exist
3172         https://bugs.webkit.org/show_bug.cgi?id=171121
3173
3174         Reviewed by Jonathan Bedard.
3175
3176         Before this change, an error occured if a contributor without EditBugs privileges tried
3177         to obsolete not their own attachment. With this patch, uploading routine continues with
3178         friendly console warning like we have in reassign_bug() method.
3179
3180         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
3181         (Bugzilla):
3182         (Bugzilla.obsolete_attachment):
3183         (Bugzilla.reassign_bug): Use NO_EDIT_BUGS_MESSAGE constant.
3184
3185 2020-02-03  Chris Dumez  <cdumez@apple.com>
3186
3187         Regression(r253224) WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView
3188         https://bugs.webkit.org/show_bug.cgi?id=207121
3189         <rdar://problem/58880177>
3190
3191         Reviewed by Alex Christensen.
3192
3193         Add API test coverage.
3194
3195         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3196         * TestWebKitAPI/Tests/WebKit/beforeunload-slow.html: Added.
3197         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3198         (-[SlowBeforeUnloadHandlerUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3199         (-[SlowBeforeUnloadHandlerUIDelegate webViewDidClose:]):
3200         (TEST):
3201
3202 2020-02-03  Lauro Moura  <lmoura@igalia.com>
3203
3204         [WebKitTestRunner] setOpenPanelFiles support in non-local tests
3205         https://bugs.webkit.org/show_bug.cgi?id=206517
3206
3207         Reviewed by Carlos Alberto Lopez Perez.
3208
3209         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3210         (WTR::TestRunner::setOpenPanelFiles): Use file:// if the passed path
3211         starts with a leading slash instead of using the test URL, which could
3212         cause input forms with invalid file data.
3213
3214 2020-02-03  Aakash Jain  <aakash_jain@apple.com>
3215
3216         [ews] Set custom build summary for webkitpy tests
3217         https://bugs.webkit.org/show_bug.cgi?id=207027
3218
3219         Reviewed by Jonathan Bedard.
3220
3221         * BuildSlaveSupport/ews-build/factories.py:
3222         * BuildSlaveSupport/ews-build/steps.py:
3223         (WebKitPyTest.setBuildSummary):
3224         (WebKitPyTest.getResultSummary):
3225         * BuildSlaveSupport/ews-build/factories_unittest.py:
3226
3227 2020-02-03  Jonathan Bedard  <jbedard@apple.com>
3228
3229         run-javascriptcore-tests: Don't split binary results
3230         https://bugs.webkit.org/show_bug.cgi?id=207118
3231
3232         Rubber-stamped by Aakash Jain.
3233
3234         * Scripts/run-javascriptcore-tests:
3235         (runTest): Only report aggregated binary results.
3236
3237 2020-02-03  Chris Dumez  <cdumez@apple.com>
3238
3239         Unreviewed, disable ResponsivenessTimer test in Debug / ASAN
3240
3241         The ResponsivenessTimer is disabled for those configurations as of r255518.
3242
3243         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
3244
3245 2020-02-03  Zan Dobersek  <zdobersek@igalia.com>
3246
3247         Use std::hypot() where possible
3248         https://bugs.webkit.org/show_bug.cgi?id=198483
3249
3250         Reviewed by Carlos Garcia Campos.
3251
3252         Use std::hypot() where possible, allowing for a possibly more precise
3253         calculation of square roots of sums of two or three square values.
3254
3255         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
3256         (-[DragAndDropSimulator initialProgressForMouseDrag]):
3257
3258 2020-02-03  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
3259
3260         [JHBuild] remove libvpx
3261         https://bugs.webkit.org/show_bug.cgi?id=207103
3262
3263         Reviewed by Xabier Rodriguez-Calvar.
3264
3265         libvpx were added in jhbuild in times of OpenWebRTC. Nowadays, LibWebRTC is used and libvpx is
3266         installed through Tools/gtk/install-dependencies, thus it should be removed from jhbuild.modules
3267
3268         * gstreamer/jhbuild.modules: remove libvpx.
3269
3270 2020-02-02  Sam Weinig  <weinig@apple.com>
3271
3272         Update style checker with new locations OS version checks are allowed
3273         https://bugs.webkit.org/show_bug.cgi?id=207106
3274
3275         Reviewed by Alexey Proskuryakov.
3276
3277         * Scripts/webkitpy/style/checkers/cpp.py:
3278         (check_os_version_checks):
3279         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3280         (WebKitStyleTest.test_os_version_checks):
3281         Update path check to allow anything with the pattern "Source/WTF/wtf/Platform[a-zA-Z]+\.h"
3282
3283 2020-02-01  Simon Fraser  <simon.fraser@apple.com>
3284
3285         Closing a MiniBrowser WK2 window does not release the WKWebView
3286         https://bugs.webkit.org/show_bug.cgi?id=203185
3287
3288         Reviewed by Wenson Hsieh.
3289         
3290         Use a weak WKWebView reference in the _textFinder.hideInterfaceCallback() block
3291         to avoid a retain cycle that keeps the window controller and WKWebView alive.
3292
3293         * MiniBrowser/mac/WK2BrowserWindowController.m:
3294         (-[WK2BrowserWindowController awakeFromNib]):
3295
3296 2020-01-31  David Quesada  <david_quesada@apple.com>
3297
3298         REGRESSION(r252185): NetworkSessionCocoa cancels downloads that receive authentication challenges
3299         https://bugs.webkit.org/show_bug.cgi?id=206984
3300         rdar://problem/58999654
3301
3302         Reviewed by Brady Eidson.
3303
3304         Add an API test for a resumed download that receives an authentication challenge. The download
3305         delegate should be asked to handle the challenge, and the download should be able to finish.
3306
3307         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3308         (-[DownloadCancelingDelegate _download:decideDestinationWithSuggestedFilename:completionHandler:]):
3309         (-[DownloadCancelingDelegate _download:didReceiveData:]):
3310         (-[DownloadCancelingDelegate _downloadDidCancel:]):
3311         (-[AuthenticationChallengeHandlingDelegate _download:didReceiveAuthenticationChallenge:completionHandler:]):
3312         (-[AuthenticationChallengeHandlingDelegate _downloadDidFinish:]):
3313         (TEST):
3314
3315 2020-01-31  Wenson Hsieh  <wenson_hsieh@apple.com>
3316
3317         Add support for specifying background colors when setting marked text
3318         https://bugs.webkit.org/show_bug.cgi?id=207065
3319         <rdar://problem/57876140>
3320
3321         Reviewed by Tim Horton.
3322
3323         Add support in WebKitTestRunner for specifying a list of highlight ranges when setting marked text. This comes
3324         in the form of an additional argument to TextInputController::setMarkedText, which contains an array of objects,
3325         each describing one range (in the composition) to highlight.
3326
3327         * DumpRenderTree/ios/TextInputControllerIOS.m:
3328         (+[TextInputController isSelectorExcludedFromWebScript:]):
3329         (+[TextInputController webScriptNameForSelector:]):
3330         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
3331         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
3332         * DumpRenderTree/mac/TextInputControllerMac.m:
3333         (+[TextInputController isSelectorExcludedFromWebScript:]):
3334         (+[TextInputController webScriptNameForSelector:]):
3335         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:highlights:]):
3336         (-[TextInputController setMarkedText:selectedFrom:length:suppressUnderline:]): Deleted.
3337         * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl:
3338         * WebKitTestRunner/InjectedBundle/TextInputController.cpp:
3339         (WTR::arrayLength):
3340         (WTR::createCompositionHighlightData):
3341
3342         Add logic to convert a given JSObject containing the composition highlight information into a WKArrayRef, which
3343         is then passed into WebKit via WKBundlePageSetComposition.
3344
3345         (WTR::TextInputController::setMarkedText):
3346         * WebKitTestRunner/InjectedBundle/TextInputController.h:
3347
3348 2020-01-31  Alex Christensen  <achristensen@webkit.org>
3349
3350         Add KVO SPI WKWebView._negotiatedLegacyTLS
3351         https://bugs.webkit.org/show_bug.cgi?id=207067
3352
3353         Reviewed by Andy Estes.
3354
3355         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3356         (-[TLSObserver observeValueForKeyPath:ofObject:change:context:]):
3357         (-[TLSObserver waitUntilNegotiatedLegacyTLSChanged]):
3358         (TestWebKitAPI::TEST):
3359         * TestWebKitAPI/config.h:
3360
3361 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
3362
3363         [ews] Display flaky test names in build summary when ReRunWebKitTests passes
3364         https://bugs.webkit.org/show_bug.cgi?id=207050
3365
3366         Reviewed by Jonathan Bedard.
3367
3368         * BuildSlaveSupport/ews-build/steps.py:
3369         (ReRunWebKitTests.evaluateCommand):
3370
3371 2020-01-31  David Kilzer  <ddkilzer@apple.com>
3372
3373         REGRESSION: [ iPadOS ] imported/w3c/web-platform-tests/dom/events/Event-dispatch-on-disabled-elements.html always fails
3374         <https://webkit.org/b/206759>
3375         <rdar://problem/58872607>
3376
3377         Reviewed by Brent Fulgham.
3378
3379         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
3380         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
3381         - Add declaration.
3382         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3383         (WTR::UIScriptControllerIOS::waitForModalTransitionToFinish const):
3384         - Implement by waiting for
3385           -[UIViewController isPerformingModalTransition] to return NO
3386           while spinning the runloop.
3387         (WTR::UIScriptControllerIOS::singleTapAtPointWithModifiers):
3388         - Call waitForModalTransitionToFinish() to fix the test.
3389
3390 2020-01-31  Aakash Jain  <aakash_jain@apple.com>
3391
3392         [ews] add build step to set custom build summary
3393         https://bugs.webkit.org/show_bug.cgi?id=207026
3394
3395         Reviewed by Jonathan Bedard.
3396
3397         * BuildSlaveSupport/ews-build/steps.py:
3398         (SetBuildSummary.doStepIf): Run this step only if build_summary property is set.
3399         (SetBuildSummary.hideStepIf): Hide this step if it is not executed.
3400         (SetBuildSummary.start):
3401
3402 2020-01-31  Jonathan Bedard  <jbedard@apple.com>
3403
3404         results.webkit.org: Handle modified firewall rules
3405         https://bugs.webkit.org/show_bug.cgi?id=207047
3406
3407         Reviewed by Aakash Jain.
3408
3409         * Scripts/webkitpy/results/upload.py:
3410         (Upload.upload_archive): Return true for 403 and 413 errors, but print a message
3411         indicating the upload failed.
3412         * Scripts/webkitpy/results/upload_unittest.py:
3413         (UploadTest.test_archive_upload):
3414
3415 2020-01-30  Jiewen Tan  <jiewen_tan@apple.com>
3416
3417         Unreviewed, another speculative test fix after r255041
3418
3419         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3420         (WTR::TestController::addTestKeyToKeychain):
3421         Adds kSecAttrAccessible: kSecAttrAccessibleAfterFirstUnlock to secItem to bypass
3422         potential error due to screen locks.
3423
3424 2020-01-30  Alex Christensen  <achristensen@webkit.org>
3425
3426         Add WKNavigationDelegate SPI to disable TLS 1.0 and 1.1
3427         https://bugs.webkit.org/show_bug.cgi?id=206979
3428
3429         Reviewed by Brady Eidson.
3430
3431         * MiniBrowser/mac/SettingsController.m:
3432         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
3433         (-[TLSNavigationDelegate waitForDidFinishNavigation]):
3434         (-[TLSNavigationDelegate waitForDidFailProvisionalNavigation]):
3435         (-[TLSNavigationDelegate receivedShouldAllowLegacyTLS]):
3436         (-[TLSNavigationDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
3437         (-[TLSNavigationDelegate webView:didFinishNavigation:]):
3438         (-[TLSNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
3439         (-[TLSNavigationDelegate _webView:authenticationChallenge:shouldAllowLegacyTLS:]):
3440         (TestWebKitAPI::TEST):
3441
3442 2020-01-30  Jonathan Bedard  <jbedard@apple.com>
3443
3444         PAL: Remove old iOS version macros
3445         https://bugs.webkit.org/show_bug.cgi?id=206905
3446
3447         Reviewed by Darin Adler.
3448
3449         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm: Remove USE(NSPROGRESS_PUBLISHING_SPI)
3450         with HAVE(NSPROGRESS_PUBLISHING_SPI)
3451
3452 2020-01-30  Jonathan Bedard  <jbedard@apple.com>
3453
3454         TestWebKitAPI: Re-baseline AccessibilityTests for Catalyst
3455         https://bugs.webkit.org/show_bug.cgi?id=206997
3456
3457         Reviewed by Wenson Hsieh.
3458
3459         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
3460         (TestWebKitAPI::TEST):
3461
3462 2020-01-29  Jonathan Bedard  <jbedard@apple.com>
3463
3464         run-safari / run-webkit-tests --ios-simulator not working with XCode 13.3.1 (11C504)
3465         https://bugs.webkit.org/show_bug.cgi?id=206932
3466
3467         Reviewed by Alexey Proskuryakov.
3468
3469         * Scripts/webkitpy/xcode/simulated_device.py:
3470         (SimulatedDeviceManager.get_runtime_for_device_type): Request for a device running
3471         some version will return a runtime of the same major version with a minor version
3472         that is equal to or greater than the specified minor version.
3473         * Scripts/webkitpy/xcode/simulated_device_unittest.py:
3474         (test_matching_up_success):
3475         (test_matching_up_failure):
3476
3477 2020-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3478
3479         [JSC] Give up IC when unknown structure transition happens
3480         https://bugs.webkit.org/show_bug.cgi?id=206846
3481
3482         Reviewed by Mark Lam.
3483
3484         Add `crash!` annotation, which allows us to write a crashing JS test.
3485
3486         * Scripts/run-jsc-stress-tests:
3487         * Scripts/webkitruby/jsc-stress-test-writer-default.rb:
3488         * Scripts/webkitruby/jsc-stress-test-writer-playstation.rb:
3489         * Scripts/webkitruby/jsc-stress-test-writer-ruby.rb:
3490
3491 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3492
3493         [GTK] Add api-gtk to EWS bubbles.
3494         https://bugs.webkit.org/show_bug.cgi?id=206930
3495
3496         Reviewed by Aakash Jain.
3497
3498         A new queue has been added to the EWS to run GTK API tests in r255238.
3499         The queue is now running fine with no pre-existent failures.
3500         Let's add it to the EWS bubbles.
3501
3502         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3503         (StatusBubble):
3504
3505 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3506
3507         [GTK] Fix TestWebKitAPI/TestJSC:/jsc/options API test after r255314
3508         https://bugs.webkit.org/show_bug.cgi?id=206927
3509
3510         Reviewed by Carlos Garcia Campos.
3511
3512         Update the default value tested from 4MB to 5MB.
3513
3514         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3515         (testsJSCOptions):
3516
3517 2020-01-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3518
3519         [GTK] Extra packages needed to successfully run API tests (cups-daemon and fonts-liberation)
3520         https://bugs.webkit.org/show_bug.cgi?id=206925
3521
3522         Reviewed by Carlos Garcia Campos.
3523
3524         Add cups-daemon to the list of packages to be installed, which is necessary to sucessfully
3525         run the printing related GTK API tests. Add also the liberation fonts, which are needed to
3526         run the complex text controller API tests.
3527
3528         * gtk/install-dependencies:
3529         * wpe/install-dependencies: Don't add cups packages, because WPE currently doesn't run print-related API test.
3530
3531 2020-01-28  Tim Horton  <timothy_horton@apple.com>
3532
3533         macCatalyst: Right clicking on a link follows it immediately
3534         https://bugs.webkit.org/show_bug.cgi?id=206919
3535         <rdar://problem/58936679>
3536
3537         Reviewed by Wenson Hsieh.
3538
3539         * TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm:
3540         (TEST):
3541         Add a test ensuring that mouseup is still called with the secondary button,
3542         even if the event's buttonmask is 0.
3543
3544 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
3545
3546         TestWebKitAPI: Conditionalize device orientation tests on ENABLE(DEVICE_ORIENTATION)
3547         https://bugs.webkit.org/show_bug.cgi?id=206913
3548         <rdar://problem/58973357>
3549
3550         Reviewed by Chris Dumez.
3551
3552         * TestWebKitAPI/Tests/WebKitCocoa/DeviceOrientation.mm:
3553
3554 2020-01-28  Tim Horton  <timothy_horton@apple.com>
3555
3556         macCatalyst: Triple clicking to select a sentence results in an empty selection
3557         https://bugs.webkit.org/show_bug.cgi?id=206863
3558         <rdar://problem/58776993>
3559
3560         Reviewed by Wenson Hsieh.
3561
3562         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3563         * TestWebKitAPI/Tests/WebKitCocoa/MacCatalystMouseSupport.mm: Added.
3564         (-[WKTestingEvent locationInView:]):
3565         (-[WKTestingEvent _setButtonMask:]):
3566         (-[WKTestingEvent _buttonMask]):
3567         (-[WKTestingTouch locationInView:]):
3568         (-[WKTestingTouch setTapCount:]):
3569         (-[WKTestingTouch tapCount]):
3570         (mouseGesture):
3571         (TEST):
3572         Add a test ensuring that simply plumbing mouse events to WebCore
3573         does not result in a selection change in macCatalyst (because UIKit
3574         will handle the selection change itself, instead).
3575
3576 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
3577
3578         TestWebKitAPI: Conditionalize QuickLook tests on USE(QUICK_LOOK)
3579         https://bugs.webkit.org/show_bug.cgi?id=206907
3580         <rdar://problem/58969924>
3581
3582         Rubber-stamped by Alexey Proskuryakov.
3583
3584         * TestWebKitAPI/Tests/WebKitCocoa/QuickLook.mm: Conditionalize on USE(QUICK_LOOK).
3585
3586 2020-01-28  Sihui Liu  <sihui_liu@apple.com>
3587
3588         IndexedDB: speed up index records deletion
3589         https://bugs.webkit.org/show_bug.cgi?id=206196
3590
3591         Reviewed by Brady Eidson.
3592
3593         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3594         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgrade.sqlite3: Added.
3595         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.html: Added.
3596         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm: Added.
3597         (-[IDBObjectStoreInfoUpgradeToV2MessageHandler userContentController:didReceiveScriptMessage:]):
3598         (TEST):
3599
3600 2020-01-28  James Darpinian  <jdarpinian@chromium.org>
3601
3602         Quote file argument to git check-attr
3603         https://bugs.webkit.org/show_bug.cgi?id=206322
3604
3605         Reviewed by Jonathan Bedard.
3606
3607         * Scripts/prepare-ChangeLog:
3608         (attributeCommand):
3609         * Scripts/webkitperl/prepare-ChangeLog_unittest/filenameWithParentheses.pl: Added.
3610         (writeFileWithContent):
3611
3612 2020-01-28  Brent Fulgham  <bfulgham@apple.com>
3613
3614         Reset the application bundle identifier between test runs
3615         https://bugs.webkit.org/show_bug.cgi?id=206858
3616         <rdar://problem/58844002>
3617
3618         Reviewed by Per Arne Vollan.
3619
3620         Clear the application bundle identifier set during testing when resetting the test system
3621         to a known state in preparation for the next run.
3622
3623         * WebKitTestRunner/TestController.cpp:
3624         (WTR::TestController::resetStateToConsistentValues): Clear any override for the application
3625         bundle identifier before the next test invocation.
3626         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3627         (WTR::TestController::setApplicationBundleIdentifier): Correct an over-release caused by assigning
3628         an autorelease return value to an NSRetainPtr.
3629         (WTR::TestController::clearApplicationBundleIdentifierTestingOverride): Added.
3630
3631 2020-01-28  Aakash Jain  <aakash_jain@apple.com>
3632
3633         EWS django app should send cq+ patches to commit-queue
3634         https://bugs.webkit.org/show_bug.cgi?id=206534
3635
3636         Reviewed by Jonathan Bedard.
3637
3638         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
3639         (Buildbot.send_patch_to_buildbot): Added support to send to commit queue.
3640         * BuildSlaveSupport/ews-app/ews/config.py: Added COMMIT_QUEUE_PORT.
3641         * BuildSlaveSupport/ews-app/ews/fetcher.py: Added support for sending patches to commit queue.
3642         * BuildSlaveSupport/ews-app/ews/migrations/0003_patch_sent_to_commit_queue.py: Added.
3643         * BuildSlaveSupport/ews-app/ews/models/patch.py:
3644         (Patch): Added sent_to_commit_queue field in patch table.
3645         (Patch.is_patch_sent_to_commit_queue): Method to check if patch is sent to commit queue.
3646         (Patch.set_sent_to_commit_queue): Set sent_to_commit_queue field.
3647
3648 2020-01-28  Stephan Szabo  <stephan.szabo@sony.com>
3649
3650         Python 3: Update windows scripts and uses of is constant
3651         https://bugs.webkit.org/show_bug.cgi?id=206856
3652
3653         Reviewed by Jonathan Bedard.
3654
3655         * Scripts/download-github-release.py: Update for python 3
3656         * Scripts/webkitpy/common/system/profiler.py: Change is constant usage
3657         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py: Change is constant usage
3658         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py: Change is constant usage
3659         * Scripts/webkitpy/port/westondriver.py: Change is constant usage
3660         * Scripts/webkitpy/port/win.py: Update for python 3
3661         * Scripts/webkitpy/port/xvfbdriver.py: Change is constant usage
3662         * Scripts/webkitpy/xcode/device_type.py: Change is constant usage
3663
3664 2020-01-28  Jonathan Bedard  <jbedard@apple.com>
3665
3666         run-webkit-tests: clobber-old-results should remove the entire results folder
3667         https://bugs.webkit.org/show_bug.cgi?id=205875
3668         <rdar://problem/58236117>
3669
3670         Reviewed by Alexey Proskuryakov.
3671
3672         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3673         (Manager.run): Boot http servers after the build check and after clobbering
3674         old results.
3675         (Manager._clobber_old_results): Remove entire results folder.
3676         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3677         (RunTest.test_retrying_and_flaky_tests): clobber-old-results now removes the
3678         entire results directory.
3679
3680 2020-01-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3681
3682         [GTK] Add EWS testers to run GTK unit tests.
3683         https://bugs.webkit.org/show_bug.cgi?id=202361
3684
3685         Reviewed by Aakash Jain.
3686
3687         This switches two of the GTK BuildOnly EWS bots to be BuildAndRunAPITests bots.
3688         It doesn't make it a test-only bot because of concerns related with having to
3689         upload and download much data constantly over the network. It reuses the same
3690         logic for running Mac API tests, but simply using a different command at startup.
3691
3692         * BuildSlaveSupport/ews-build/config.json:
3693         * BuildSlaveSupport/ews-build/factories.py:
3694         (GTKBuildFactory):
3695         (GTKBuildAndTestFactory):
3696         (GTKBuildAndTestFactory.__init__):
3697         (GTKAPIBuildAndTestFactory):
3698         * BuildSlaveSupport/ews-build/loadConfig.py:
3699         * BuildSlaveSupport/ews-build/steps.py:
3700         (RunAPITests.start):
3701         (ReRunAPITests.evaluateCommand):
3702         * BuildSlaveSupport/ews-build/steps_unittest.py:
3703
3704 2020-01-28  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3705
3706         WPT test importer only rewrites the first URL on <style> tags.
3707         https://bugs.webkit.org/show_bug.cgi?id=206842
3708
3709         Reviewed by Jonathan Bedard.
3710
3711         There was an issue, when a <style> tag had several URL() paths
3712         to local references, only the first one was converted.
3713         This was caused because the test parser was only seeing the
3714         first one (re.search() only finds the first regex), instead use
3715         re.findall() to find all the ocurrences.
3716         Then in the test converter for relative paths, when there are
3717         several paths to be converted, convert from the last conversion
3718         instead of the original text.
3719
3720         * Scripts/webkitpy/w3c/test_converter.py:
3721         (_W3CTestConverter.convert_reference_relpaths):
3722         * Scripts/webkitpy/w3c/test_converter_unittest.py:
3723         (test_convert_style_multiple_url):
3724         * Scripts/webkitpy/w3c/test_parser.py:
3725         (TestParser.support_files):
3726         * Scripts/webkitpy/w3c/test_parser_unittest.py:
3727
3728 2020-01-28  Antoine Quint  <graouts@apple.com>
3729
3730         [Web Animations] Make Animation.timeline read-write only if a runtime flag is enabled
3731         https://bugs.webkit.org/show_bug.cgi?id=206173
3732         <rdar://problem/58527432>
3733
3734         Reviewed by Dean Jackson.
3735
3736         Manually enable the new WebAnimationsMutableTimelines runtime flag in DumpRenderTree.
3737
3738         * DumpRenderTree/mac/DumpRenderTree.mm:
3739         (enableExperimentalFeatures):
3740         * DumpRenderTree/win/DumpRenderTree.cpp:
3741         (enableExperimentalFeatures):
3742
3743 2020-01-27  Aakash Jain  <aakash_jain@apple.com>
3744
3745         [ews] Add method to fetch cq+ patches from Bugzilla
3746         https://bugs.webkit.org/show_bug.cgi?id=206774
3747
3748         Reviewed by Jonathan Bedard.
3749
3750         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
3751         (Bugzilla._get_commit_queue_patches_from_bug): Method to get cq+ patches for a given bug.
3752         (Bugzilla._is_patch_cq_plus): Method to check if patch has cq+ flag set.
3753         (Bugzilla.get_list_of_patches_for_commit_queue): Method to fetch list of cq+ patches from Bugzilla.
3754         (BugzillaBeautifulSoup.fetch_bug_ids_for_commit_queue):
3755
3756 2020-01-27  Noam Rosenthal  <noam@webkit.org>
3757
3758         Unreviewed. Adding myself back as a reviewer.
3759
3760         * Scripts/webkitpy/common/config/contributors.json:
3761
3762 2020-01-27  Keith Rollin  <krollin@apple.com>
3763
3764         Fix internal builds
3765         https://bugs.webkit.org/show_bug.cgi?id=206790
3766         <rdar://problem/58888951>
3767
3768         Reviewed by Maciej Stachowiak.
3769
3770         TestRunner.cpp in DumpRenderTree includes ExecutableAllocator.h. In
3771         some circumstances, this file can include <os/thread_self_restrict.h>,
3772         which in turn includes <machine/cpu_capabilities.h>. This latter file
3773         does not exist at a standard location, and the build fails due to not
3774         being able to find the file. Fix this by adding a path to it to the
3775         build command line.
3776
3777         * DumpRenderTree/mac/Configurations/Base.xcconfig:
3778
3779 2020-01-27  Robin Morisset  <rmorisset@apple.com>
3780
3781         Tools/Scripts/set-webkit-configuration should accept --coverage/--no-coverage
3782         https://bugs.webkit.org/show_bug.cgi?id=206833
3783
3784         Reviewed by Jonathan Bedard.
3785
3786         Just a trivial fix to the arguments validation code of the script.
3787
3788         * Scripts/set-webkit-configuration:
3789
3790 2020-01-27  Said Abou-Hallawa  <sabouhallawa@apple.com>
3791
3792         Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler
3793         https://bugs.webkit.org/show_bug.cgi?id=204713
3794
3795         Reviewed by Simon Fraser.
3796
3797         RenderingUpdateThrottling is enabled by default. Turn it off for DRT and
3798         WTR. In some cases, the page may not get visually active while it's
3799         waiting for rAF. Throttling tests will have to explicitly turn it on.
3800
3801         * DumpRenderTree/mac/DumpRenderTree.mm:
3802         (resetWebPreferencesToConsistentValues):
3803         * DumpRenderTree/win/DumpRenderTree.cpp:
3804         (resetWebPreferencesToConsistentValues):
3805         * WebKitTestRunner/TestController.cpp:
3806         (WTR::TestController::resetPreferencesToConsistentValues):
3807
3808 2020-01-26  Aakash Jain  <aakash_jain@apple.com>
3809
3810         [ews] Status bubble hover over message in case of success should indicate whether it built the patch or run tests
3811         https://bugs.webkit.org/show_bug.cgi?id=206807
3812
3813         Reviewed by Jonathan Bedard.
3814
3815         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3816
3817 2020-01-27  Kate Cheney  <katherine_cheney@apple.com>
3818
3819         Delete the ITP storage file that is not being used (plist or database file) when switching to a new storage type
3820         https://bugs.webkit.org/show_bug.cgi?id=206601
3821         <rdar://problem/58696521>
3822
3823         Reviewed by Alex Christensen.
3824
3825         This patch caused some API tests to fail which relied on the ITP files
3826         always existing. Now the tests ensure the respective file exists when 
3827         switching between in-memory and database storage before running the tests.
3828
3829         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3830         (ensureITPFileIsCreated):
3831         (TEST):
3832
3833 2020-01-27  Ryan Haddad  <ryanhaddad@apple.com>
3834
3835         Unreviewed, rolling out r255131.
3836
3837         Caused assertion failures on iOS debug bots.
3838
3839         Reverted changeset:
3840
3841         "Throttling requestAnimationFrame should be controlled by
3842         RenderingUpdateScheduler"
3843         https://bugs.webkit.org/show_bug.cgi?id=204713
3844         https://trac.webkit.org/changeset/255131
3845
3846 2020-01-27  Jonathan Bedard  <jbedard@apple.com>
3847
3848         webkitpy: Replace StringIO.StringIO in statusserver.py
3849         https://bugs.webkit.org/show_bug.cgi?id=206825
3850
3851         Reviewed by Aakash Jain.
3852
3853         * Scripts/webkitpy/common/net/statusserver.py:
3854         (StatusServer._upload_attachment_to_server): The Python 3 compatible StringIO
3855         object cannot be referenced as StringIO.StringIO
3856
3857 2020-01-26  Said Abou-Hallawa  <said@apple.com>
3858
3859         Throttling requestAnimationFrame should be controlled by RenderingUpdateScheduler
3860         https://bugs.webkit.org/show_bug.cgi?id=204713
3861
3862         Reviewed by Simon Fraser.
3863
3864         RenderingUpdateThrottling is enabled by default. Turn it off for DRT and
3865         WTR. In some cases, the page may not get visually active while it's
3866         waiting for rAF. Throttling tests will have to explicitly turn it on.
3867
3868         * DumpRenderTree/mac/DumpRenderTree.mm:
3869         (resetWebPreferencesToConsistentValues):
3870         * DumpRenderTree/win/DumpRenderTree.cpp:
3871         (resetWebPreferencesToConsistentValues):
3872         * WebKitTestRunner/TestController.cpp:
3873         (WTR::TestController::resetPreferencesToConsistentValues):
3874
3875 2020-01-25  Mark Lam  <mark.lam@apple.com>
3876
3877         Add some tests for dynamically allocated StaticStringImpls.
3878         https://bugs.webkit.org/show_bug.cgi?id=206802
3879
3880         Reviewed by Darin Adler.
3881
3882         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3883         (TestWebKitAPI::doStaticStringImplTests):
3884         (TestWebKitAPI::TEST):
3885
3886 2020-01-25  Aakash Jain  <aakash_jain@apple.com>
3887
3888         webkit-patch upload should not submit automatically to old EWS
3889         https://bugs.webkit.org/show_bug.cgi?id=206801
3890
3891         Reviewed by Alexey Proskuryakov.
3892
3893         * Scripts/webkitpy/tool/commands/upload_unittest.py:
3894         * Scripts/webkitpy/tool/steps/submittoews.py:
3895
3896 2020-01-25  Per Arne Vollan  <pvollan@apple.com>
3897
3898         [Cocoa] Media mime types map should be created in the UI process
3899         https://bugs.webkit.org/show_bug.cgi?id=206478
3900
3901         Reviewed by Darin Adler.
3902
3903         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3904         * TestWebKitAPI/Tests/WebKit/MimeTypes.mm: Added.
3905         (TEST):
3906
3907 2020-01-25  Antti Koivisto  <antti@apple.com>
3908
3909         [LFC][Integration] Re-enable line layout integration
3910         https://bugs.webkit.org/show_bug.cgi?id=206795
3911         <rdar://problem/58853907>
3912
3913         Reviewed by Zalan Bujtas.
3914
3915         * DumpRenderTree/TestOptions.h:
3916
3917 2020-01-25  Youenn Fablet  <youenn@apple.com>
3918
3919         HTMLMediaElement should not remove the media session at DOM suspension time
3920         https://bugs.webkit.org/show_bug.cgi?id=206661
3921         <rdar://problem/58800787>
3922
3923         Reviewed by Eric Carlson.
3924
3925         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
3926         (TestWebKitAPI::TEST):
3927         Suspend/resume Active DOM Objects from time to time as would do scrolling.
3928         This allows pending tasks to be executed asynchronously when not scrolling.
3929
3930 2020-01-23  Matt Lewis  <jlewis3@apple.com>
3931
3932         Remove Apple windows 7 queues.
3933         https://bugs.webkit.org/show_bug.cgi?id=206702
3934
3935         Reviewed by Jonathan Bedard.
3936
3937         * BuildSlaveSupport/build.webkit.org-config/config.json:
3938         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3939         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3940         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3941         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3942         Removed Windows 7 queues from config and from dashboard.
3943
3944 2020-01-24  Per Arne Vollan  <pvollan@apple.com>
3945
3946         Unreviewed, rolling out r255050.
3947
3948         Introduced crashes on bots
3949
3950         Reverted changeset:
3951
3952         "[Cocoa] Media mime types map should be created in the UI
3953         process"
3954         https://bugs.webkit.org/show_bug.cgi?id=206478
3955         https://trac.webkit.org/changeset/255050
3956
3957 2020-01-24  Jonathan Bedard  <jbedard@apple.com>
3958
3959         run-webkit-tests: Handle case where device socket make handle invalid
3960         https://bugs.webkit.org/show_bug.cgi?id=206707
3961
3962         Reviewed by Stephanie Lewis.
3963
3964         * Scripts/webkitpy/port/simulator_process.py:
3965         (SimulatorProcess.NonBlockingFileFromSocket.close): Catch IOError when closing file.
3966
3967 2020-01-24  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3968
3969         [GTK] API test runner fails with error: too many open files.
3970         https://bugs.webkit.org/show_bug.cgi?id=206743
3971
3972         Reviewed by Carlos Garcia Campos.
3973
3974         The API test runner for google tests was leaking file descriptors because
3975         it was not closing the file descriptor of the pseudo-terminal of the child,
3976         which was referred in the parent because of the forkpty() call.
3977         This was causing a small but constant increase of open file descriptors,
3978         until the point it reached the limit of maximum open files (1024 usually)
3979         causing this error.
3980
3981         Fix that by closing the reference to the fd of the child's pseudo-terminal.
3982
3983         * glib/api_test_runner.py:
3984         (TestRunner._run_google_test):
3985
3986 2020-01-24  Zan Dobersek  <zdobersek@igalia.com>
3987
3988         Unreviewed WPE dependency bump.
3989
3990         * wpe/jhbuild.modules: Bump the libwpe checkout commit to include fixes
3991         for configuration errors that can occur with older (but still supported)
3992         CMake versions.
3993
3994 2020-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3995
3996         Unreviewed GTK gardening. Mark /webkit/WebKitWebPage/get-uri as flaky
3997
3998         * TestWebKitAPI/glib/TestExpectations.json:
3999
4000 2020-01-23  Wenson Hsieh  <wenson_hsieh@apple.com>
4001
4002         [iOS] Support setting minimum effective device width during dynamic viewport size updates
4003         https://bugs.webkit.org/show_bug.cgi?id=206709
4004         <rdar://problem/58713872>
4005
4006         Reviewed by Tim Horton.
4007
4008         Adds a new API test that changes both the effective minimum device width and view size during animated resize.
4009
4010         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
4011
4012 2020-01-23  Per Arne Vollan  <pvollan@apple.com>
4013
4014         [Cocoa] Media mime types map should be created in the UI process
4015         https://bugs.webkit.org/show_bug.cgi?id=206478
4016
4017         Reviewed by Darin Adler.
4018
4019         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4020         * TestWebKitAPI/Tests/WebKit/MimeTypes.mm: Added.
4021         (TEST):
4022
4023 2020-01-22  Jiewen Tan  <jiewen_tan@apple.com>
4024
4025         WebKitTestRunner: use ad hoc signing for internal Production builds
4026         https://bugs.webkit.org/show_bug.cgi?id=206607
4027         <rdar://problem/56087327>
4028
4029         Reviewed by Jonathan Bedard.
4030
4031         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
4032
4033 2020-01-23  Tuomas Karkkainen  <tuomas.webkit@apple.com>
4034
4035         Add missing coverage.xcconfig
4036         https://bugs.webkit.org/show_bug.cgi?id=206686
4037
4038         Reviewed by Mark Lam.
4039
4040         * coverage/coverage.xcconfig: Added.
4041
4042 2020-01-23  Per Arne Vollan  <pvollan@apple.com>
4043
4044         [Cocoa] Broker access to the PowerManagement API
4045         https://bugs.webkit.org/show_bug.cgi?id=206373
4046
4047         Reviewed by Darin Adler.
4048
4049         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4050         * TestWebKitAPI/Tests/WebKit/Battery.mm: Added.
4051         (TEST):
4052
4053 2020-01-23  Jonathan Bedard  <jbedard@apple.com>
4054
4055         Fix iOS 13.2 iphoneos build
4056         https://bugs.webkit.org/show_bug.cgi?id=206618
4057
4058         Reviewed by Alexey Proskuryakov.
4059
4060         * Scripts/webkitdirs.pm:
4061         (XcodeOptions): Relax provisioning profile rules on embedded SDKs.
4062
4063 2020-01-23  Takashi Komori  <Takashi.Komori@sony.com>
4064
4065         KeyedDecoderGeneric crashes when it accesses a data with empty string key.
4066         https://bugs.webkit.org/show_bug.cgi?id=206572
4067
4068         Reviewed by Fujii Hironori.
4069
4070         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
4071         (TestWebKitAPI::TEST):
4072
4073 2020-01-23  Tuomas Karkkainen  <tuomas.webkit@apple.com>
4074
4075         It should be possible to build JavaScriptCore with LLVM Source-based Code Coverage, run the tests and see the coverage data
4076         https://bugs.webkit.org/show_bug.cgi?id=206389
4077
4078         Reviewed by Alexey Proskuryakov.
4079
4080         * Scripts/run-javascriptcore-tests:
4081         * Scripts/set-webkit-configuration:
4082         * Scripts/webkitdirs.pm:
4083         * coverage/coverage.xcconfig: Added.
4084
4085 2020-01-22  Jiewen Tan  <jiewen_tan@apple.com>
4086
4087         Unreviewed, rolling out r254955.
4088
4089         Broke internal builds
4090
4091         Reverted changeset:
4092
4093         "WebKitTestRunner: move code sign configurations from
4094         WebKitTestRunner.xcconfig to DebugRelease.xcconfig"
4095         https://bugs.webkit.org/show_bug.cgi?id=206607
4096         https://trac.webkit.org/changeset/254955
4097
4098 2020-01-22  Jiewen Tan  <jiewen_tan@apple.com>
4099
4100         WebKitTestRunner: move code sign configurations from WebKitTestRunner.xcconfig to DebugRelease.xcconfig
4101         https://bugs.webkit.org/show_bug.cgi?id=206607
4102         <rdar://problem/56087327>
4103
4104         Reviewed by Alexey Proskuryakov.
4105
4106         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
4107
4108 2020-01-22  Brady Eidson  <beidson@apple.com>
4109
4110         REGRESSION (r253519): [WKWebView evaluateJavaScript:completionHandler:] gives a non-nil, non-Error result even when JavaScript cannot be evaluated
4111         <rdar://problem/58544942> and https://bugs.webkit.org/show_bug.cgi?id=206608
4112
4113         Reviewed by Alex Christensen.
4114
4115         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
4116         (TEST):
4117
4118 2020-01-22  Jonathan Bedard  <jbedard@apple.com>
4119
4120         webkitpy: WebSocket server doesn't support Python 3 (Workaround)
4121         https://bugs.webkit.org/show_bug.cgi?id=206546
4122
4123         Reviewed by Alexey Proskuryakov.
4124
4125         websocket_server.py doesn't support Python 3, and needs to be run with
4126         Python 2.
4127
4128         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
4129         (PyWebSocket._prepare_config): Use Python 2 explicitly.
4130
4131 2020-01-22  Basuke Suzuki  <basuke.suzuki@sony.com>
4132
4133         [build-webkit] Add option for toggling unified build
4134         https://bugs.webkit.org/show_bug.cgi?id=206597
4135
4136         Reviewed by Adrian Perez de Castro.
4137
4138         Added command line option for build-webkit script to toggle unified build.
4139
4140         * Scripts/webkitperl/FeatureList.pm:
4141
4142 2020-01-22  Don Olmstead  <don.olmstead@sony.com>
4143
4144         Share InjectedBundleController::platformInitialize
4145         https://bugs.webkit.org/show_bug.cgi?id=206598
4146
4147         Reviewed by Konstantin Tokarev.
4148
4149         Add a stub for platformInitialize in InjectedBundleController.cpp which is
4150         used for non-Cocoa ports. Remove the platform specific stubs.
4151
4152         * TestWebKitAPI/InjectedBundleController.cpp:
4153         (TestWebKitAPI::InjectedBundleController::platformInitialize):
4154         * TestWebKitAPI/PlatformGTK.cmake:
4155         * TestWebKitAPI/PlatformWPE.cmake:
4156         * TestWebKitAPI/PlatformWin.cmake:
4157         * TestWebKitAPI/gtk/InjectedBundleControllerGtk.cpp: Removed.
4158         * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Removed.
4159         * TestWebKitAPI/wpe/InjectedBundleControllerWPE.cpp: Removed.
4160
4161 2020-01-22  Jonathan Bedard  <jbedard@apple.com>
4162
4163         webkitpy: Make logging during ImageDiff crashes accurate
4164         https://bugs.webkit.org/show_bug.cgi?id=206542
4165
4166         Reviewed by Aakash Jain.
4167
4168         When ImageDiff crashes, the generated logs are not accurate, they
4169         reference a crash in test output when the test will actually fail
4170         with an Image failure. The owner of a ServerProcess should be able
4171         to customize this error message.
4172
4173         * Scripts/webkitpy/port/image_diff.py:
4174         (ImageDiffer._start): Pass ImageDiff specific crash message.
4175         * Scripts/webkitpy/port/port_testcase.py:
4176         (PortTestCase.test_diff_image.make_proc): Match ImageDiff calcite.
4177         (PortTestCase.test_diff_image_passed): Ditto.
4178         (PortTestCase.test_diff_image_failed): Ditto.
4179         (PortTestCase.test_diff_image_crashed.make_proc): Ditto.
4180         * Scripts/webkitpy/port/server_process.py:
4181         (ServerProcess.__init__): Support a custom message when the process crashes.
4182         (ServerProcess.write): Ditto.
4183         (ServerProcess._wait_for_data_and_update_buffers_using_select): Ditto.
4184         (ServerProcess.has_crashed): Ditto.
4185         * Scripts/webkitpy/port/server_process_mock.py:
4186         (MockServerProcess.__init__): Match the ServerProcess constructor.
4187         * Scripts/webkitpy/port/simulator_process.py:
4188         (SimulatorProcess.__init__): Support a custom message when the process crashes.
4189
4190 2020-01-21  Matt Lewis  <jlewis3@apple.com>
4191
4192         Test history links on the dashboard should go to the new results database
4193         https://bugs.webkit.org/show_bug.cgi?id=205821
4194
4195         Reviewed by Jonathan Bedard.
4196
4197         Made changes to the various locations that we use the old database in the main dashboard
4198         and test results pages.
4199         
4200         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
4201         (ui.urlForFlakinessDashboard):
4202         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
4203         (ui.results.FlakinessData.base._handleMessage):
4204         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
4205         (TestHistory):
4206         (TestHistory.prototype.historyPageURLForTest):
4207         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
4208
4209 2020-01-22  Antti Koivisto  <antti@apple.com>
4210
4211         [LFC][Integration] Disable integration to see performance impact
4212         https://bugs.webkit.org/show_bug.cgi?id=206576
4213         <rdar://problem/58562185>
4214
4215         Reviewed by Zalan Bujtas.
4216
4217         * DumpRenderTree/TestOptions.h:
4218
4219 2020-01-21  Fujii Hironori  <Hironori.Fujii@sony.com>
4220
4221         A partially selected RTL text is placed at a wrong vertical position if it has a vertical initial advance
4222         https://bugs.webkit.org/show_bug.cgi?id=205990
4223
4224         Reviewed by Darin Adler.
4225
4226         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
4227         Replaced all "controller.totalWidth()" with "controller.totalAdvance().width()".
4228
4229 2020-01-21  Sihui Liu  <sihui_liu@apple.com>
4230
4231         REGRESSION (r254856?): [Win] http/tests/security/same-origin-websql-blocked.html and 2 fast/dom/Window/window-function-* tests failing
4232         https://bugs.webkit.org/show_bug.cgi?id=206552
4233
4234         Unreviewed fix after r254856. r254856 wanted to enable WebSQL on layout tests but enableWebSQL was set to false.
4235
4236         * DumpRenderTree/TestOptions.h:
4237
4238 2020-01-21  Jiewen Tan  <jiewen_tan@apple.com>
4239
4240         ProvisionalPageProxy::loadData should pass last navigation's shouldOpenExternalURLsPolicy flag to WebPageProxy
4241         https://bugs.webkit.org/show_bug.cgi?id=206462
4242         <rdar://problem/57468718>
4243
4244         Reviewed by Chris Dumez.
4245
4246         * TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
4247         (TestWebKitAPI::TEST):
4248
4249 2020-01-21  Rob Buis  <rbuis@igalia.com>
4250
4251         Add build flag for stale-while-revalidate
4252         https://bugs.webkit.org/show_bug.cgi?id=204169
4253
4254         Reviewed by Youenn Fablet.
4255
4256         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4257
4258 2020-01-21  Yusuke Suzuki  <ysuzuki@apple.com>
4259
4260         [WTF] AtomStringTable should be small
4261         https://bugs.webkit.org/show_bug.cgi?id=206400
4262
4263         Reviewed by Sam Weinig.
4264
4265         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
4266         (TestWebKitAPI::TEST):
4267         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
4268         (TestWebKitAPI::TEST):
4269         * TestWebKitAPI/Tests/WTF/Packed.cpp:
4270         (TestWebKitAPI::TEST):
4271
4272 2020-01-21  Alex Christensen  <achristensen@webkit.org>
4273
4274         Add SPI on WKURLSchemeTask to access WKFrameInfo of originating frame
4275         https://bugs.webkit.org/show_bug.cgi?id=204265
4276         <rdar://57193883>
4277
4278         Reviewed by Brady Eidson.
4279
4280         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
4281         (-[FrameSchemeHandler waitForAllRequests]):
4282         (-[FrameSchemeHandler setExpectedWebView:]):
4283         (-[FrameSchemeHandler webView:startURLSchemeTask:]):
4284         (-[FrameSchemeHandler webView:stopURLSchemeTask:]):
4285
4286 2020-01-21  Aakash Jain  <aakash_jain@apple.com>
4287
4288         [ews] commit-queue should check cq+ flag
4289         https://bugs.webkit.org/show_bug.cgi?id=206530
4290
4291         Reviewed by Jonathan Bedard.
4292
4293         * BuildSlaveSupport/ews-build/steps.py:
4294         ValidatePatch._is_patch_cq_plus): Method to check cq+ flag on patch.
4295         (ValidatePatch.start):
4296         * BuildSlaveSupport/ews-build/factories.py:
4297         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-tests.
4298
4299 2020-01-21  Keith Rollin  <krollin@apple.com>
4300
4301         Fix tvOS values in SUPPORTED_PLATFORMS
4302         https://bugs.webkit.org/show_bug.cgi?id=206435
4303         <rdar://problem/58674587>
4304
4305         Reviewed by Alexey Proskuryakov.
4306
4307         A number of targets in WebKit have 'tvos' and 'tvsimulator' in
4308         SUPPORTED_PLATFORMS. The correct values are 'appletvos' and
4309         'appletvsimulator'. These should be updated to the correct ones as the
4310         wrong values prevent the tvOS run destination from being usable in the
4311         UI to build for tvOS.
4312
4313         * DumpRenderTree/mac/Configurations/Base.xcconfig:
4314         * ImageDiff/cg/Configurations/Base.xcconfig:
4315         * MiniBrowser/Configurations/Base.xcconfig:
4316         * WebKitTestRunner/Configurations/Base.xcconfig:
4317
4318 2020-01-21  Sihui Liu  <sihui_liu@apple.com>
4319
4320         Disable WebSQL everywhere by default except in tests
4321         https://bugs.webkit.org/show_bug.cgi?id=204907
4322
4323         Reviewed by Ryosuke Niwa.
4324
4325         * DumpRenderTree/TestOptions.h:
4326         * DumpRenderTree/mac/DumpRenderTree.mm:
4327         (resetWebPreferencesToConsistentValues):
4328         * DumpRenderTree/win/DumpRenderTree.cpp:
4329         (setWebPreferencesForTestOptions):
4330
4331 2020-01-20  Aakash Jain  <aakash_jain@apple.com>
4332
4333         [ews] Add build and layout-test steps for commit-queue in new ews
4334         https://bugs.webkit.org/show_bug.cgi?id=206510
4335
4336         Reviewed by Jonathan Bedard.
4337
4338         * BuildSlaveSupport/ews-build/factories.py:
4339
4340 2020-01-21  C