Introduce and adopt new class RegistrableDomain for eTLD+1
[WebKit-https.git] / Tools / ChangeLog
1 2019-02-25  John Wilander  <wilander@apple.com>
2
3         Introduce and adopt new class RegistrableDomain for eTLD+1
4         https://bugs.webkit.org/show_bug.cgi?id=194791
5         <rdar://problem/48179240>
6
7         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
8
9         This patch adds an API test and replaces two instances of
10         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
11
12         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
13         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
14         (TestWebKitAPI::TEST):
15             Changed two strings to make sure the registrable domains are still considered
16             invalid and pass the test.
17         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
18         (TestWebKitAPI::TEST):
19         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
20         (WTR::InjectedBundle::didReceiveMessageToPage):
21
22 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
23
24         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
25         https://bugs.webkit.org/show_bug.cgi?id=195001
26
27         Reviewed by Carlos Garcia Campos.
28
29         API version 1.0 always includes the functionality previously guarded with
30         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
31         unconditionally.
32
33         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
34         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
35         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
36         (WebViewTest::showInWindow): Ditto.
37         (WebViewTest::hideView): Ditto.
38         * wpe/backends/HeadlessViewBackend.cpp:
39         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
40         * wpe/backends/ViewBackend.cpp:
41         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
42         * wpe/backends/WindowViewBackend.cpp:
43         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
44         WPE_BACKEND_CHECK_VERSION().
45         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
46
47 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
48
49         [Flatpak] Add support for flatpak > 1.1.2
50         https://bugs.webkit.org/show_bug.cgi?id=194088
51
52         Flatpak 1.2 is now out so we need to support that
53         version now.
54
55         Reviewed by Michael Catanzaro.
56
57         * flatpak/flatpakutils.py:
58         (check_flatpak):
59         (FlatpakPackages.__init__):
60         (FlatpakPackages.__detect_packages):
61         (FlatpakPackages.__detect_packages.in):
62         (FlatpakRepos.update):
63
64 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
65
66         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
67         https://bugs.webkit.org/show_bug.cgi?id=194998
68
69         Reviewed by Carlos Garcia Campos.
70
71         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
72         to a Git checkout and using the latest commit containing various fixes
73         and improvements.
74
75 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
76
77         [WPE][GTK] Remove user agent quirk for washingtonpost.com
78         https://bugs.webkit.org/show_bug.cgi?id=194981
79
80         Reviewed by Žan Doberšek.
81
82         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
83         (TestWebKitAPI::TEST):
84
85 2019-02-23  Keith Miller  <keith_miller@apple.com>
86
87         Add new mac target numbers
88         https://bugs.webkit.org/show_bug.cgi?id=194955
89
90         Reviewed by Tim Horton.
91
92         * DumpRenderTree/mac/Configurations/Base.xcconfig:
93         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
94         * MiniBrowser/Configurations/Base.xcconfig:
95         * TestWebKitAPI/Configurations/Base.xcconfig:
96         * WebKitTestRunner/Configurations/Base.xcconfig:
97
98 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
99
100         [WinCairo] Enable wk1/wk2 suffix for platform search path.
101         https://bugs.webkit.org/show_bug.cgi?id=194846
102
103         Reviewed by Don Olmstead.
104
105         Added _search_paths() and _port_specific_expectations_files() for
106         WinCairoPort.
107
108         * Scripts/webkitpy/port/win.py:
109         (WinCairoPort.default_baseline_search_path):
110         (WinCairoPort):
111         (WinCairoPort._port_specific_expectations_files):
112         (WinCairoPort._search_paths):
113
114 2019-02-22  Tim Horton  <timothy_horton@apple.com>
115
116         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
117         https://bugs.webkit.org/show_bug.cgi?id=194963
118
119         Reviewed by Dean Jackson.
120
121         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
122         Do a `contains` check instead of `equals`, because in debug builds we
123         put the GraphicsLayer pointer in a prefix.
124
125 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
126
127         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
128         https://bugs.webkit.org/show_bug.cgi?id=194873
129         <rdar://problem/46701974>
130
131         Reviewed by Tim Horton.
132
133         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
134
135         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
136         (WTR::UIScriptController::menuRect const):
137         (WTR::UIScriptController::isShowingMenu const):
138         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
139         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
140         (WTR::UIScriptController::menuRect const):
141
142         Add a function to query the bounds of the callout menu in content coordinates.
143
144         (WTR::UIScriptController::isShowingMenu const):
145
146         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
147
148         * TestRunnerShared/UIScriptContext/UIScriptController.h:
149         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
150         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
151         (WTR::UIScriptController::rectForMenuAction const):
152         (WTR::UIScriptController::menuRect const):
153         (WTR::UIScriptController::isShowingMenu const):
154         (WTR::findViewInHierarchyOfType): Deleted.
155
156 2019-02-22  Chris Dumez  <cdumez@apple.com>
157
158         Regression(PSON) Unable to preview password-protected documents on iCloud.com
159         https://bugs.webkit.org/show_bug.cgi?id=194954
160         <rdar://problem/48127957>
161
162         Reviewed by Alex Christensen.
163
164         Add API test coverage.
165
166         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
167         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
168         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
169         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
170
171 2019-02-22  Chris Dumez  <cdumez@apple.com>
172
173         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
174         https://bugs.webkit.org/show_bug.cgi?id=194924
175         <rdar://problem/48216125>
176
177         Reviewed by Geoffrey Garen.
178
179         Add API test coverage.
180
181         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
182
183 2019-02-22  Chris Dumez  <cdumez@apple.com>
184
185         Unreviewed, disable API test added in r241928 on iOS.
186
187         The cache is not enabled on devices with less than 3GB of RAM.
188
189         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
190
191 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
192
193         Hardcode Visual Viewports on everywhere except iOS WK1
194         https://bugs.webkit.org/show_bug.cgi?id=194928
195
196         Reviewed by Zalan Bujtas.
197
198         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
199         change the default value of the Setting to 'true', and hardcode WebView on iOS to
200         set it to false. The setting has shipped for several years and there's no need to turn
201         it off now.
202
203         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
204         Visual Viewports are not enabled.
205         
206         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
207         that only runs in WK2
208
209         * MiniBrowser/mac/SettingsController.h:
210         * MiniBrowser/mac/SettingsController.m:
211         (-[SettingsController init]):
212         (-[SettingsController _populateMenu]):
213         (-[SettingsController validateMenuItem:]):
214         (-[SettingsController visualViewportEnabled]): Deleted.
215         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
216         * MiniBrowser/mac/WK1BrowserWindowController.m:
217         (-[WK1BrowserWindowController didChangeSettings]):
218         * MiniBrowser/mac/WK2BrowserWindowController.m:
219         (-[WK2BrowserWindowController didChangeSettings]):
220
221 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
222
223         Discard cached processes when clearing website data store
224         https://bugs.webkit.org/show_bug.cgi?id=194894
225
226         Reviewed by Chris Dumez.
227
228         Added a test case.
229
230         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
231         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
232
233 2019-02-21  Alex Christensen  <achristensen@webkit.org>
234
235         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
236         https://bugs.webkit.org/show_bug.cgi?id=194914
237         <rdar://problem/47586889>
238
239         Reviewed by Geoffrey Garen.
240
241         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
242         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
243         (TEST):
244         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
245
246 2019-02-21  David Kilzer  <ddkilzer@apple.com>
247
248         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
249         <https://webkit.org/b/194761>
250
251         Reviewed by Myles Maxfield.
252
253         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
254         (WTR::activateSystemCoreWebFonts): Log `error` to console if
255         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
256         to use ARC-compliant cast.
257         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
258         ARC-compliant cast.
259         (WTR::installFakeHelvetica): Log `error` to console if
260         CTFontManagerRegisterFontsForURL() fails, but only on supported
261         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
262         Call CFRelease() on `error` to fix the leak.  Update to use
263         ARC-compliant cast.
264         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
265         cast.
266
267 2019-02-21  Chris Dumez  <cdumez@apple.com>
268
269         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
270         https://bugs.webkit.org/show_bug.cgi?id=194481
271
272         Reviewed by Alex Christensen.
273
274         Give the processes a chance to shutdown and wait until we reached the expected number
275         of processes.
276
277         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
278
279 2019-02-21  Tim Horton  <timothy_horton@apple.com>
280
281         Fix the macOS build
282
283         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
284
285 2019-02-21  Tim Horton  <timothy_horton@apple.com>
286
287         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
288
289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
290         I am a backwards.
291
292 2019-02-21  Tim Horton  <timothy_horton@apple.com>
293
294         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
295
296         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
297         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
298         We could force on UI-side compositing, but I feel like the test might be more
299         valuable exercising the normal path on each platform (though the original
300         bug was also UI-side specific). Though we can't validate that the overlay
301         layer was installed successfully, there are layout tests that do that.
302
303 2019-02-21  Tim Horton  <timothy_horton@apple.com>
304
305         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
306         https://bugs.webkit.org/show_bug.cgi?id=194845
307         <rdar://problem/47944579>
308
309         Reviewed by Antti Koivisto.
310
311         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
312         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
313
314 2019-02-21  Zalan Bujtas  <zalan@apple.com>
315
316         [LFC][Floats] Add support for placing formatting roots in-between floats.
317         https://bugs.webkit.org/show_bug.cgi?id=194902
318
319         Reviewed by Antti Koivisto.
320
321         * LayoutReloaded/misc/LFC-passing-tests.txt:
322
323 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
324
325         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
326         https://bugs.webkit.org/show_bug.cgi?id=194901
327
328         Unreviewed build fix.
329
330         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
331         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
332         WPEBackend-fdo-0.1 as library name.
333
334 2019-02-21  Rob Buis  <rbuis@igalia.com>
335
336         Update MIME type parser
337         https://bugs.webkit.org/show_bug.cgi?id=180526
338
339         Reviewed by Darin Adler.
340
341         Add tests involving leading and trailing whitespace, non-token
342         characters and quoted strings.
343
344         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
345         (TestWebKitAPI::TEST):
346
347 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
348
349         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
350         https://bugs.webkit.org/show_bug.cgi?id=194884
351
352         Reviewed by Michael Catanzaro.
353
354         * PlatformWin.cmake:
355
356 2019-02-20  Chris Dumez  <cdumez@apple.com>
357
358         Add API test for <rdar://problem/47471222>
359         https://bugs.webkit.org/show_bug.cgi?id=194847
360
361         Reviewed by Alex Christensen.
362
363         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
364
365 2019-02-20  Chris Dumez  <cdumez@apple.com>
366
367         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
368         https://bugs.webkit.org/show_bug.cgi?id=194872
369         <rdar://problem/47924500>
370
371         Reviewed by Alex Christensen.
372
373         Add API test coverage.
374
375         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
376
377 2019-02-20  Jer Noble  <jer.noble@apple.com>
378
379         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
380         https://bugs.webkit.org/show_bug.cgi?id=191332
381
382         Reviewed by Dean Jackson.
383
384         * Scripts/git-is-in-range: Added.
385
386 2019-02-20  Andy Estes  <aestes@apple.com>
387
388         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
389         https://bugs.webkit.org/show_bug.cgi?id=194869
390
391         Rubber-stamped by Jer Noble.
392
393         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
394         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
395         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
396         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
398         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
399
400 2019-02-20  Chris Dumez  <cdumez@apple.com>
401
402         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
403         https://bugs.webkit.org/show_bug.cgi?id=194857
404         <rdar://problem/47759323>
405
406         Reviewed by Alex Christensen.
407
408         Add API test coverage.
409
410         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
411
412 2019-02-20  Chris Dumez  <cdumez@apple.com>
413
414         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
415         https://bugs.webkit.org/show_bug.cgi?id=194829
416         <rdar://problem/47889906>
417
418         Reviewed by Alexey Proskuryakov.
419
420         Every time the TestOptions were changing we were creating both a new Web view and
421         a new WKContext, which would start a new Network process. In most cases, we only
422         need to contruct a new Web view and we do can keep reusing the same WKContext.
423         This patch implements this optimization and thus avoids spinning a lot of new
424         Network processes while running the layout tests.
425
426         * WebKitTestRunner/TestController.cpp:
427         (WTR::TestController::generateContextConfiguration const):
428         (WTR::TestController::generatePageConfiguration):
429         (WTR::TestController::createWebViewWithOptions):
430         (WTR::TestController::resetPreferencesToConsistentValues):
431         (WTR::updateTestOptionsFromTestHeader):
432         * WebKitTestRunner/TestController.h:
433         * WebKitTestRunner/TestOptions.h:
434         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
435         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
436         (WTR::TestOptions::hasSameInitializationOptions const):
437         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
438         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
439         (WTR::TestController::platformAddTestOptions const):
440
441 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
442
443         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
444         https://bugs.webkit.org/show_bug.cgi?id=167941
445
446         Reviewed by Carlos Garcia Campos.
447
448         * MiniBrowser/gtk/main.c:
449         (filterSavedCallback): Added.
450         (main): Support loading a JSON rule set file for content filtering.
451         * MiniBrowser/wpe/main.cpp:
452         (filterSavedCallback): Added.
453         (main): Support loading a JSON rule set file for content filtering.
454         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
455         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
456         (WTF::derefGPtr): Ditto.
457         (testEmptyStore):
458         (testSaveInvalidFilter):
459         (testSaveLoadFilter):
460         (testSavedFilterIdentifierMatch):
461         (testRemoveFilter):
462         (testSaveMultipleFilters):
463         (testSaveFilterFromFile):
464         (testFilterPersistence):
465         (beforeAll):
466         (afterAll):
467         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
468         (removeOldInjectedContentAndResetLists): Also reset content filters.
469         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
470         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
471         the element affected by the style sheet.
472         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
473         and returns it to be used by tests.
474         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
475         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
476         (serverCallback): Add support for serving a CSS style sheet for testing.
477         (beforeAll): Add call to testUserContentManagerContentFilter().
478         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
479
480 2019-02-19  Keith Rollin  <krollin@apple.com>
481
482         Add timing information to build output
483         https://bugs.webkit.org/show_bug.cgi?id=194839
484         <rdar://problem/48219609>
485
486         Reviewed by Alexey Proskuryakov.
487
488         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
489         emit each project's build time to its output. E.g.,
490
491             ** BUILD SUCCEEDED ** [0.132 sec]
492
493         * Scripts/webkitdirs.pm:
494         (XcodeOptions):
495
496 2019-02-19  Truitt Savell  <tsavell@apple.com>
497
498         Unreviewed, rolling out r241784.
499
500         Broke all OpenSource builds.
501
502         Reverted changeset:
503
504         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
505         instances view"
506         https://bugs.webkit.org/show_bug.cgi?id=172848
507         https://trac.webkit.org/changeset/241784
508
509 2019-02-19  Zalan Bujtas  <zalan@apple.com>
510
511         [LFC][Floats] Remove redundant intersecting logic
512         https://bugs.webkit.org/show_bug.cgi?id=194804
513
514         Reviewed by Antti Koivisto.
515
516         * LayoutReloaded/misc/LFC-passing-tests.txt:
517
518 2019-02-19  Dean Jackson  <dino@apple.com>
519
520         Clean-up output from generate-xcfilelists so it can be filtered
521         https://bugs.webkit.org/show_bug.cgi?id=194795
522
523         Reviewed by Joseph Pecoraro (and Keith Rollin).
524
525         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
526         make a slight tweak to filter-build-webkit so such lines are marked
527         as plain.
528
529         * Scripts/filter-build-webkit:
530         * Scripts/generate-xcfilelists:
531
532 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
533
534         pytest is not correctly auto-installed
535         https://bugs.webkit.org/show_bug.cgi?id=194707
536
537         Reviewed by Carlos Garcia Campos.
538
539         * Scripts/webkitpy/thirdparty/__init__.py:
540         (AutoinstallImportHook._install_pytest):
541
542 2019-02-18  Chris Dumez  <cdumez@apple.com>
543
544         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
545         https://bugs.webkit.org/show_bug.cgi?id=194797
546         <rdar://problem/48055151>
547
548         Reviewed by Geoffrey Garen.
549
550         Add API test coverage.
551
552         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
553
554 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
555
556         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
557         https://bugs.webkit.org/show_bug.cgi?id=194670
558         <rdar://problem/39066529>
559
560         Reviewed by Tim Horton.
561
562         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
563         pasted in an editable area as attachment elements.
564
565         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
566         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
567         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
568         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
569         (TestWebKitAPI::TEST):
570         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
571         (WTR::InjectedBundlePage::InjectedBundlePage):
572
573 2019-02-18  Alex Christensen  <achristensen@webkit.org>
574
575         Fix API test after r241728
576        ​https://bugs.webkit.org/show_bug.cgi?id=194723
577
578         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
579         (TEST):
580         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
581
582 2019-02-18  Daniel Bates  <dabates@apple.com>
583
584         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
585         https://bugs.webkit.org/show_bug.cgi?id=192824
586         <rdar://problem/47100332>
587
588         Reviewed by Wenson Hsieh.
589
590         Fix a bug where the wrong usage code was used for F13 thru F24.
591
592         * WebKitTestRunner/ios/HIDEventGenerator.mm:
593         (keyCodeForDOMFunctionKey):
594
595 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
596
597         Bytecode cache should a have a boot-specific validation
598         https://bugs.webkit.org/show_bug.cgi?id=194769
599         <rdar://problem/48149509>
600
601         Reviewed by Keith Miller.
602
603         Add test for WTF::bootSessionUUIDString()
604
605         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
606         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
607         (TEST):
608
609 2019-02-18  Alex Christensen  <achristensen@webkit.org>
610
611         Disable safe browsing in WKWebView and remove its WKPreferences API
612         https://bugs.webkit.org/show_bug.cgi?id=194723
613         <rdar://problem/48122993>
614
615         Reviewed by Geoffrey Garen.
616
617         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
618         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
619         (TEST):
620         (safeBrowsingView):
621         Make tests use SPI instead of API.
622
623 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
624
625         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
626         https://bugs.webkit.org/show_bug.cgi?id=194586
627
628         Reviewed by Ross Kirsling.
629
630         * DumpRenderTree/win/DumpRenderTree.cpp:
631         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
632         * Scripts/webkitpy/port/driver.py:
633         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
634
635 2019-02-17  David Kilzer  <ddkilzer@apple.com>
636
637         Unreviewed, rolling out r241620.
638
639         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
640         (Requested by ddkilzer on #webkit.)
641
642         Reverted changeset:
643
644         "[WTF] Add environment variable helpers"
645         https://bugs.webkit.org/show_bug.cgi?id=192405
646         https://trac.webkit.org/changeset/241620
647
648 2019-02-16  Zalan Bujtas  <zalan@apple.com>
649
650         [LFC] RenderImage's default intrinsic size is 0.
651         https://bugs.webkit.org/show_bug.cgi?id=194745
652
653         Reviewed by Antti Koivisto.
654
655         * LayoutReloaded/misc/LFC-passing-tests.txt:
656
657 2019-02-16  Zalan Bujtas  <zalan@apple.com>
658
659         [LFC][BFC] Add support for block replaced intrinsic width.
660         https://bugs.webkit.org/show_bug.cgi?id=194705
661
662         Reviewed by Simon Fraser.
663
664         * LayoutReloaded/misc/LFC-passing-tests.txt:
665
666 2019-02-16  Zalan Bujtas  <zalan@apple.com>
667
668         [LFC] Apply min/max width constraints to preferred width computation
669         https://bugs.webkit.org/show_bug.cgi?id=194739
670
671         Reviewed by Simon Fraser.
672
673         * LayoutReloaded/misc/LFC-passing-tests.txt:
674
675 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
676
677         [WTF] Add environment variable helpers
678         https://bugs.webkit.org/show_bug.cgi?id=192405
679
680         Reviewed by Michael Catanzaro.
681
682         * DumpRenderTree/mac/DumpRenderTree.mm:
683         (libraryPathForDumpRenderTree):
684         * DumpRenderTree/win/DumpRenderTree.cpp:
685         (libraryPathForDumpRenderTree):
686         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
687         (setUpIOSLayoutTestCommunication):
688         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
689         (beforeAll):
690         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
691         (main):
692         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
693         (WebKitTestBus::run):
694         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
695         (WTR::getOutputDir):
696         (WTR::initializeFontConfigSetting):
697         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
698         (WTR::InjectedBundle::platformInitialize):
699         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
700         (WTR::topLevelPath):
701         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
702         (WTR::topLevelPath):
703         (WTR::getOutputDir):
704         (WTR::activateFonts):
705         * WebKitTestRunner/TestController.cpp:
706         (WTR::TestController::libraryPathForTesting):
707         (WTR::TestController::generateContextConfiguration const):
708         (WTR::TestController::generatePageConfiguration):
709         (WTR::TestController::decideDestinationWithSuggestedFilename):
710         (WTR::TestController::platformAdjustContext):
711         * WebKitTestRunner/TestController.h:
712         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
713         (WTR::TestController::cocoaPlatformInitialize):
714         (WTR::TestController::platformAdjustContext):
715         * WebKitTestRunner/gtk/main.cpp:
716         (main):
717         * WebKitTestRunner/mac/TestControllerMac.mm:
718         (WTR::TestController::configureContentExtensionForTest):
719         * WebKitTestRunner/wpe/main.cpp:
720         (main):
721         Utilize WTF::Environment where possible.
722
723 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
724
725         [iOS] WKWebView callout bar is missing Change Writing Direction item
726         https://bugs.webkit.org/show_bug.cgi?id=190015
727         <rdar://problem/44810366>
728
729         Reviewed by Tim Horton.
730
731         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
732         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
733
734         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
735         (TestWebKitAPI::TEST):
736
737 2019-02-15  Chris Dumez  <cdumez@apple.com>
738
739         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
740         https://bugs.webkit.org/show_bug.cgi?id=194717
741         <rdar://problem/47884404>
742
743         Reviewed by Brady Eidson.
744
745         Add API test coverage.
746
747         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
748
749 2019-02-15  Youenn Fablet  <youenn@apple.com>
750
751         Make navigator.mediaDevices SecureContext
752         https://bugs.webkit.org/show_bug.cgi?id=194666
753
754         Reviewed by Eric Carlson.
755
756         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
757         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
758         (TEST_F):
759
760 2019-02-15  Brian Burg  <bburg@apple.com>
761
762         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
763         https://bugs.webkit.org/show_bug.cgi?id=194411
764         <rdar://problem/47787614>
765
766         Reviewed by Joseph Pecoraro.
767
768         Remove unnecessary soft linking macro usage.
769
770         * DumpRenderTree/mac/TestRunnerMac.mm:
771         (TestRunner::inspectorTestStubURL):
772         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
773         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
774         (WTR::TestRunner::inspectorTestStubURL):
775
776 2019-02-15  Commit Queue  <commit-queue@webkit.org>
777
778         Unreviewed, rolling out r241559 and r241566.
779         https://bugs.webkit.org/show_bug.cgi?id=194710
780
781         Causes layout test crashes under GuardMalloc (Requested by
782         ryanhaddad on #webkit).
783
784         Reverted changesets:
785
786         "[WTF] Add environment variable helpers"
787         https://bugs.webkit.org/show_bug.cgi?id=192405
788         https://trac.webkit.org/changeset/241559
789
790         "Unreviewed build fix for WinCairo Debug after r241559."
791         https://trac.webkit.org/changeset/241566
792
793 2019-02-15  Zalan Bujtas  <zalan@apple.com>
794
795         [LFC] Out-of-flow box is never a float box
796         https://bugs.webkit.org/show_bug.cgi?id=194704
797
798         Reviewed by Antti Koivisto.
799
800         * LayoutReloaded/misc/LFC-passing-tests.txt:
801
802 2019-02-10  Darin Adler  <darin@apple.com>
803
804         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
805         https://bugs.webkit.org/show_bug.cgi?id=194487
806
807         Reviewed by Daniel Bates.
808
809         * DumpRenderTree/win/DumpRenderTree.cpp:
810         (applicationId): Use makeString instead of String::format.
811         (main): Ditto.
812         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
813         (TestWebKitAPI::Util::createURLForResource): Ditto.
814         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
815         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
816
817         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
818         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
819         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
820         (WTR::createStringWithAttributes): Use appendLiteral.
821         (WTR::AccessibilityUIElement::helpText const): Ditto.
822         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
823         directly instead of using String::format.
824         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
825         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
826
827 2019-02-15  Truitt Savell  <tsavell@apple.com>
828
829         Unreviewed, rolling out r241564.
830
831         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
832
833         Reverted changeset:
834
835         "[Mac] WebInspectorUI.framework does not need to be soft-
836         linked anymore"
837         https://bugs.webkit.org/show_bug.cgi?id=194411
838         https://trac.webkit.org/changeset/241564
839
840 2019-02-15  Saam barati  <sbarati@apple.com>
841
842         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
843         https://bugs.webkit.org/show_bug.cgi?id=194036
844
845         Reviewed by Yusuke Suzuki.
846
847         * Scripts/run-jsc-stress-tests:
848
849 2019-02-14  Tim Horton  <timothy_horton@apple.com>
850
851         Fix the build.
852
853         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
854         (WTR::UIScriptController::drawSquareInEditableImage):
855         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
856         (TestWebKitAPI::drawSquareInEditableImage):
857
858 2019-02-14  Tim Horton  <timothy_horton@apple.com>
859
860         Fix the build.
861
862         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
863         (WTR::UIScriptController::drawSquareInEditableImage):
864         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
865         (TestWebKitAPI::drawSquareInEditableImage):
866
867 2019-02-14  Brian Burg  <bburg@apple.com>
868
869         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
870         https://bugs.webkit.org/show_bug.cgi?id=194411
871         <rdar://problem/47787614>
872
873         Reviewed by Joseph Pecoraro.
874
875         Remove unnecessary soft linking macro usage.
876
877         * DumpRenderTree/mac/TestRunnerMac.mm:
878         (TestRunner::inspectorTestStubURL):
879         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
880         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
881         (WTR::TestRunner::inspectorTestStubURL):
882
883 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
884
885         [ews-app] status bubble should fetch builder name info from BuilderMapping table
886         https://bugs.webkit.org/show_bug.cgi?id=194599
887
888         Reviewed by Lucas Forschler.
889
890         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
891         (StatusBubble._build_bubble):
892
893 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
894
895         [ews-app] Set Foreign Key in Django build model
896         https://bugs.webkit.org/show_bug.cgi?id=194667
897
898         Reviewed by Lucas Forschler.
899
900         * BuildSlaveSupport/ews-app/ews/models/build.py:
901         (Build):
902
903 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
904
905         [WTF] Add environment variable helpers
906         https://bugs.webkit.org/show_bug.cgi?id=192405
907
908         Reviewed by Michael Catanzaro.
909
910         * DumpRenderTree/mac/DumpRenderTree.mm:
911         (libraryPathForDumpRenderTree):
912         * DumpRenderTree/win/DumpRenderTree.cpp:
913         (libraryPathForDumpRenderTree):
914         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
915         (setUpIOSLayoutTestCommunication):
916         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
917         (TestWebKitAPI::strip):
918         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
919         (beforeAll):
920         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
921         (main):
922         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
923         (WebKitTestBus::run):
924         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
925         (WTR::getOutputDir):
926         (WTR::initializeFontConfigSetting):
927         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
928         (WTR::InjectedBundle::platformInitialize):
929         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
930         (WTR::topLevelPath):
931         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
932         (WTR::topLevelPath):
933         (WTR::getOutputDir):
934         (WTR::activateFonts):
935         * WebKitTestRunner/TestController.cpp:
936         (WTR::TestController::libraryPathForTesting):
937         (WTR::TestController::generateContextConfiguration const):
938         (WTR::TestController::generatePageConfiguration):
939         (WTR::TestController::decideDestinationWithSuggestedFilename):
940         (WTR::TestController::platformAdjustContext):
941         * WebKitTestRunner/TestController.h:
942         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
943         (WTR::TestController::cocoaPlatformInitialize):
944         (WTR::TestController::platformAdjustContext):
945         * WebKitTestRunner/gtk/main.cpp:
946         (main):
947         * WebKitTestRunner/mac/TestControllerMac.mm:
948         (WTR::TestController::configureContentExtensionForTest):
949         * WebKitTestRunner/wpe/main.cpp:
950         (main):
951         Utilize WTF::Environment where possible.
952
953 2019-02-14  Chris Dumez  <cdumez@apple.com>
954
955         [PSON] Introduce a WebContent Process cache
956         https://bugs.webkit.org/show_bug.cgi?id=194594
957         <rdar://problem/46793397>
958
959         Reviewed by Geoff Garen.
960
961         Update API tests to turn on the WebContent Process cache.
962
963         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
964
965 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
966
967         Unreviewed, build fix after r241480
968
969         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
970         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
971         (-[DragAndDropSimulator initWithWebView:]):
972
973 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
974
975         AX: ARIA Reflection was disabled in error
976         https://bugs.webkit.org/show_bug.cgi?id=194647
977         <rdar://problem/48068336>
978
979         Reviewed by Ryosuke Niwa.
980
981         Remove test override now that this feature should be enabled by default.
982
983         * WebKitTestRunner/TestController.cpp:
984         (WTR::TestController::resetPreferencesToConsistentValues):
985
986 2019-02-14  Commit Queue  <commit-queue@webkit.org>
987
988         Unreviewed, rolling out r241486.
989         https://bugs.webkit.org/show_bug.cgi?id=194655
990
991         causing API failures in builds (Requested by ShawnRoberts on
992         #webkit).
993
994         Reverted changeset:
995
996         "[Cocoa] Media elements will restart network buffering just
997         before suspending"
998         https://bugs.webkit.org/show_bug.cgi?id=193691
999         https://trac.webkit.org/changeset/241486
1000
1001 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1002
1003         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1004         https://bugs.webkit.org/show_bug.cgi?id=194622
1005
1006         Reviewed by Antti Koivisto.
1007
1008         * LayoutReloaded/misc/LFC-passing-tests.txt:
1009
1010 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1011
1012         [LFC] Shrink-to-fit-width should be constrained by min/max width
1013         https://bugs.webkit.org/show_bug.cgi?id=194653
1014
1015         Reviewed by Antti Koivisto.
1016
1017         * LayoutReloaded/misc/LFC-passing-tests.txt:
1018
1019 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1020
1021         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1022         https://bugs.webkit.org/show_bug.cgi?id=194641
1023
1024         Reviewed by Geoffrey Garen.
1025
1026         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1027         so that the test would fail without this fix.
1028
1029         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1030         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1031
1032 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1033
1034         [ews-app] Change log level for a log statement
1035
1036         Unreviewed minor fix.
1037
1038         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1039         (Patch.save_patch):
1040
1041 2019-02-13  Jer Noble  <jer.noble@apple.com>
1042
1043         [Cocoa] Media elements will restart network buffering just before suspending
1044         https://bugs.webkit.org/show_bug.cgi?id=193691
1045
1046         Reviewed by Eric Carlson.
1047
1048         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1049         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1050         (TEST):
1051
1052 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1053
1054         [ews-app] Fetch builder id to name mapping
1055         https://bugs.webkit.org/show_bug.cgi?id=194355
1056
1057         Reviewed by Lucas Forschler.
1058
1059         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1060         (Buildbot.get_builder_id_to_name_mapping):
1061         (Buildbot._get_display_name_from_builder_name):
1062
1063 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1064
1065         Further restricting webarchive loads
1066         https://bugs.webkit.org/show_bug.cgi?id=194567
1067         <rdar://problem/47610130>
1068
1069         Reviewed by Youenn Fablet.
1070
1071         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1072         navigations on drop.
1073
1074         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1075         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1076         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1077         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1078         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1079         (TestWebKitAPI::TEST):
1080         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1081         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1082         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1083         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1084         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1085         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1086         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1087
1088 2019-02-13  John Wilander  <wilander@apple.com>
1089
1090         Store Ad Click Attribution requests in the network process
1091         https://bugs.webkit.org/show_bug.cgi?id=194510
1092         <rdar://problem/47650118>
1093
1094         Reviewed by Alex Christensen and Daniel Bates.
1095
1096         This patch adds two TestRunner functions:
1097         - dumpAdClickAttribution()
1098         - clearAdClickAttribution()
1099
1100         They call into the network process to dump and clear Ad Click
1101         Attribution state, respectively.
1102
1103         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1104         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1105         (WTR::TestRunner::dumpAdClickAttribution):
1106         (WTR::TestRunner::clearAdClickAttribution):
1107         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1108         * WebKitTestRunner/TestController.cpp:
1109         (WTR::TestController::resetStateToConsistentValues):
1110         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1111         (WTR::adClickAttributionStringResultCallback):
1112         (WTR::TestController::dumpAdClickAttribution):
1113         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1114         (WTR::adClickAttributionVoidCallback):
1115         (WTR::TestController::clearAdClickAttribution):
1116         * WebKitTestRunner/TestController.h:
1117         * WebKitTestRunner/TestInvocation.cpp:
1118         (WTR::TestInvocation::dumpResults):
1119         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1120         (WTR::TestInvocation::dumpAdClickAttribution):
1121         * WebKitTestRunner/TestInvocation.h:
1122
1123 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1124
1125         [ews-app] Generate status-bubble
1126         https://bugs.webkit.org/show_bug.cgi?id=194572
1127
1128         Reviewed by Lucas Forschler.
1129
1130         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1131         (StatusBubble._build_bubble):
1132         (StatusBubble._should_show_bubble_for):
1133         (StatusBubble._build_bubbles_for_patch):
1134
1135 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1136
1137         [ews-app] Add status bubble html template
1138         https://bugs.webkit.org/show_bug.cgi?id=194571
1139
1140         Reviewed by Lucas Forschler.
1141
1142         * BuildSlaveSupport/ews-app/ews/templates: Added.
1143         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1144
1145 2019-02-12  Chris Dumez  <cdumez@apple.com>
1146
1147         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1148         https://bugs.webkit.org/show_bug.cgi?id=194568
1149         <rdar://problem/47944490>
1150
1151         Reviewed by Ryosuke Niwa.
1152
1153         Add API test coverage.
1154
1155         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1156         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1157
1158 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1159
1160         webkitpy: Remove bug_dummy from parsed test expectations
1161         https://bugs.webkit.org/show_bug.cgi?id=194562
1162         <rdar://problem/47853999>
1163
1164         Reviewed by Lucas Forschler.
1165
1166         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1167         (TestExpectationParser):
1168         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1169         skipped tests.
1170         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1171
1172 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1173
1174         [ews-app] Add method to fetch patch
1175         https://bugs.webkit.org/show_bug.cgi?id=194518
1176
1177         Reviewed by Lucas Forschler.
1178
1179         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1180         (Patch.get_patch):
1181
1182 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1183
1184         [LFC] Expand tests coverage (60 new tests -> 860)
1185
1186         Unreviewed test gardening (run-singly, --child-processes=1).
1187
1188         * LayoutReloaded/misc/LFC-passing-tests.txt:
1189
1190 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1191
1192         Allow pages to trigger programmatic paste from script on iOS
1193         https://bugs.webkit.org/show_bug.cgi?id=194271
1194         <rdar://problem/47808810>
1195
1196         Reviewed by Tim Horton.
1197
1198         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1199
1200         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1201         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1202         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1203         (WTR::UIScriptController::rectForMenuAction const):
1204
1205         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
1206         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
1207         for when the menu is shown or hidden.
1208
1209         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1210         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
1211         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1212         (WTR::UIScriptController::setDidShowMenuCallback):
1213         (WTR::UIScriptController::didShowMenuCallback const):
1214         (WTR::UIScriptController::setDidHideMenuCallback):
1215         (WTR::UIScriptController::didHideMenuCallback const):
1216         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1217         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1218         (WTR::UIScriptController::rectForMenuAction const):
1219         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1220         * WebKitTestRunner/TestController.cpp:
1221         (WTR::TestController::resetPreferencesToConsistentValues):
1222         (WTR::updateTestOptionsFromTestHeader):
1223         * WebKitTestRunner/TestOptions.h:
1224
1225         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
1226         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
1227
1228         (WTR::TestOptions::hasSameInitializationOptions const):
1229         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1230         (WTR::UIScriptController::calendarType const):
1231         (WTR::UIScriptController::platformUndoManager const):
1232         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1233         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1234         (-[TestRunnerWKWebView initWithFrame:configuration:]):
1235         (-[TestRunnerWKWebView dealloc]):
1236         (-[TestRunnerWKWebView _didShowMenu]):
1237         (-[TestRunnerWKWebView _didHideMenu]):
1238
1239         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
1240
1241         * WebKitTestRunner/ios/TestControllerIOS.mm:
1242         (WTR::handleMenuWillHideNotification):
1243         (WTR::handleMenuDidHideNotification):
1244         (WTR::TestController::platformInitialize):
1245         (WTR::TestController::platformDestroy):
1246         (WTR::TestController::platformResetStateToConsistentValues):
1247
1248         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
1249         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
1250
1251         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1252         (WTR::forEachViewInHierarchy):
1253         (WTR::findViewInHierarchyOfType):
1254
1255         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
1256         functions that dig through a given view's hierarchy in search of a view of a given class.
1257
1258         (WTR::UIScriptController::selectionStartGrabberViewRect const):
1259         (WTR::UIScriptController::selectionEndGrabberViewRect const):
1260         (WTR::UIScriptController::selectionCaretViewRect const):
1261         (WTR::UIScriptController::selectionRangeViewRects const):
1262         (WTR::UIScriptController::platformSetDidShowMenuCallback):
1263         (WTR::UIScriptController::platformSetDidHideMenuCallback):
1264
1265         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
1266
1267         (WTR::UIScriptController::rectForMenuAction const):
1268
1269         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
1270         callout bar) whose label matches the given string.
1271
1272         (WTR::UIScriptController::platformContentView const):
1273
1274         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
1275         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
1276         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
1277
1278         (WTR::UIScriptController::platformUndoManager const): Deleted.
1279         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1280         (WTR::UIScriptController::platformContentView const):
1281         (WTR::UIScriptController::platformUndoManager const): Deleted.
1282
1283 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1284
1285         webkitpy: No option to only show unexpected failures in results.html for iPad
1286         https://bugs.webkit.org/show_bug.cgi?id=194554
1287         <rdar://problem/47922442>
1288
1289         Rubber-stamped by Aakash Jain.
1290
1291         Just because a TestExpecations file does not exist for a specific platform does not mean that
1292         TestExpecations are not being used, given that platforms inherit test expectations.
1293
1294         * Scripts/webkitpy/port/base.py:
1295         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
1296         * Scripts/webkitpy/port/base_unittest.py:
1297         (PortTest.test_uses_test_expectations_file):
1298
1299 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1300
1301         Remove setDefersLoading infrastructure from WebKit2
1302         https://bugs.webkit.org/show_bug.cgi?id=194506
1303
1304         Reviewed by Brady Eidson.
1305
1306         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1307         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1308         (WTR::TestRunner::setDefersLoading): Deleted.
1309         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1310
1311 2019-02-12  Alex Christensen  <achristensen@webkit.org>
1312
1313         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
1314         https://bugs.webkit.org/show_bug.cgi?id=194522
1315         <rdar://problem/47789393>
1316
1317         Reviewed by Chris Dumez.
1318
1319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1320         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
1321         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1322         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1323
1324 2019-02-12  Andy Estes  <aestes@apple.com>
1325
1326         [iOSMac] Enable Parental Controls Content Filtering
1327         https://bugs.webkit.org/show_bug.cgi?id=194521
1328         <rdar://39732376>
1329
1330         Reviewed by Tim Horton.
1331
1332         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1333
1334 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1335
1336         [LFC][IFC] Add intrinsic width support for float boxes.
1337         https://bugs.webkit.org/show_bug.cgi?id=194528
1338
1339         Reviewed by Antti Koivisto.
1340
1341         Expand tests coverage (2 new tests -> 800).
1342         (This is the correct test ordering --runs-singly --child-processes=1)
1343
1344         * LayoutReloaded/misc/LFC-passing-tests.txt:
1345
1346 2019-02-12  Rob Buis  <rbuis@igalia.com>
1347
1348         Implement serializing in MIME type parser
1349         https://bugs.webkit.org/show_bug.cgi?id=193909
1350
1351         Reviewed by Darin Adler.
1352
1353         Add various tests involving upper case, non-ASCII, control/null characters,
1354         various HTTP whitespace, single quotes and an unpaired surrogate.
1355
1356         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1357         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
1358         (TestWebKitAPI::serializeIfValid):
1359         (TestWebKitAPI::TEST):
1360
1361 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
1362
1363         [Cocoa] Ask platform for generic font family mappings
1364         https://bugs.webkit.org/show_bug.cgi?id=187723
1365         <rdar://problem/41892438>
1366
1367         Reviewed by Brent Fulgham.
1368
1369         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1370
1371         * DumpRenderTree/mac/DumpRenderTree.mm:
1372         (allowedFontFamilySet):
1373         * WebKitTestRunner/mac/TestControllerMac.mm:
1374         (WTR::allowedFontFamilySet):
1375
1376 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
1377
1378         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
1379         https://bugs.webkit.org/show_bug.cgi?id=193622
1380
1381         Reviewed by Michael Catanzaro.
1382
1383         This adds support for loading content extension rule sets from the JSON files which
1384         accompany the corresponding layout test, using the C API. The Cocoa specific parts
1385         of WKTR for this could be removed, but that is left for a follow-up patch with
1386         cleanups.
1387
1388         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
1389         * WebKitTestRunner/TestController.cpp:
1390         (WTR::testPath): Subtract one from the length when constructing the result std::string to
1391         avoid having the null-terminator copied into the result.
1392         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
1393         part of the preparations to run a test.
1394         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
1395         (WTR::contentExtensionStoreCallback): Added.
1396         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
1397         used for content extensions test.
1398         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
1399         extensions and compiling the JSON rule set for tests involving content extensions.
1400         (WTR::TestController::resetContentExtensions): Removes the content extension built for
1401         testing and disables content extensions.
1402         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
1403         resetContentExtensions().
1404         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
1405         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
1406         configureContentExtensionForTest(), and userContentController().
1407
1408 2019-02-11  Daniel Bates  <dabates@apple.com>
1409
1410         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1411         https://bugs.webkit.org/show_bug.cgi?id=191446
1412         <rdar://problem/45929460>
1413
1414         Reviewed by Tim Horton.
1415
1416         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1417
1418         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1419         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1420         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1421         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1422         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1423         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1424         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1425         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1426         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1427         (WTR::arrayLength):
1428         (WTR::parseModifierArray):
1429         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1430         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1431         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1432         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1433
1434 2019-02-11  Commit Queue  <commit-queue@webkit.org>
1435
1436         Unreviewed, rolling out r241272 and r241276.
1437         https://bugs.webkit.org/show_bug.cgi?id=194514
1438
1439         Broke the Apple Internal build and the fix requires human
1440         intervention :( (Requested by dydz on #webkit).
1441
1442         Reverted changesets:
1443
1444         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
1445         https://bugs.webkit.org/show_bug.cgi?id=191446
1446         https://trac.webkit.org/changeset/241272
1447
1448         "Fix internal iOS build after r241272"
1449         https://bugs.webkit.org/show_bug.cgi?id=191446
1450         https://trac.webkit.org/changeset/241276
1451
1452 2019-02-11  Truitt Savell  <tsavell@apple.com>
1453
1454         Unreviewed, rolling out r241269.
1455
1456         Caused 5 layout tests crashes on Mac WK1
1457
1458         Reverted changeset:
1459
1460         "DumpRenderTree should report unknown options"
1461         https://bugs.webkit.org/show_bug.cgi?id=191303
1462         https://trac.webkit.org/changeset/241269
1463
1464 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1465
1466         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
1467         https://bugs.webkit.org/show_bug.cgi?id=194313
1468
1469         Reviewed by Tim Horton.
1470
1471         Add a helper to determine whether the web view is presenting modal UI.
1472
1473         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1474         (WTR::UIScriptController::isPresentingModally const):
1475         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1476         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1477         (WTR::UIScriptController::isPresentingModally const):
1478         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1479         * WebKitTestRunner/UIScriptControllerCocoa.mm:
1480         (WTR::UIScriptController::calendarType const): Deleted.
1481         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1482         (WTR::UIScriptController::isPresentingModally const):
1483         (WTR::UIScriptController::calendarType const):
1484         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1485         (WTR::UIScriptController::calendarType const):
1486
1487 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
1488
1489         GCHeapInspector: Show the retained sizes in more places
1490         https://bugs.webkit.org/show_bug.cgi?id=194464
1491
1492         Reviewed by Simon Fraser.
1493
1494         * GCHeapInspector/gc-heap-inspector.html:
1495         * GCHeapInspector/script/interface.js:
1496         (HeapInspectorUtils.humanReadableSize):
1497         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
1498         (HeapInspectorUtils.spanForNode.span.span):
1499         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
1500         (HeapSnapshotInspector.prototype.buildRoots):
1501
1502 2019-02-11  Daniel Bates  <dabates@apple.com>
1503
1504         [iOS] Mouse/Touch/Pointer events are missing modifier keys
1505         https://bugs.webkit.org/show_bug.cgi?id=191446
1506         <rdar://problem/45929460>
1507
1508         Reviewed by Tim Horton.
1509
1510         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
1511
1512         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1513         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1514         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1515         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1516         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1517         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1518         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1519         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1520         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1521         (WTR::arrayLength):
1522         (WTR::parseModifierArray):
1523         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
1524         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
1525         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
1526         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
1527
1528 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
1529
1530         DumpRenderTree should report unknown options
1531         https://bugs.webkit.org/show_bug.cgi?id=191303
1532
1533         Reviewed by Frédéric Wang.
1534
1535         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
1536         to report unknown options.
1537         Added and assigned test options which are currently used in tests.
1538
1539         * DumpRenderTree/TestOptions.cpp:
1540         (TestOptions::TestOptions):
1541
1542 2019-02-11  Truitt Savell  <tsavell@apple.com>
1543
1544         Unreviewed, rolling out r241229.
1545
1546         Revision broke internal builds for watchOS.
1547
1548         Reverted changeset:
1549
1550         "[Cocoa] Ask platform for generic font family mappings"
1551         https://bugs.webkit.org/show_bug.cgi?id=187723
1552         https://trac.webkit.org/changeset/241229
1553
1554 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
1555
1556         [WinCairo][MiniBrowser] Basic authentication always fails.
1557         https://bugs.webkit.org/show_bug.cgi?id=194496
1558
1559         Reviewed by Don Olmstead.
1560
1561         * MiniBrowser/win/DialogHelper.h:
1562         (Dialog::getText):
1563
1564 2019-02-11  Philippe Normand  <pnormand@igalia.com>
1565
1566         [GStreamer] GstMappedBuffer testsuite build fails
1567         https://bugs.webkit.org/show_bug.cgi?id=194495
1568
1569         Reviewed by Carlos Garcia Campos.
1570
1571         Fix the build by explicitely adding the gstreamer1.0-audio include
1572         directories to the include path.
1573
1574         * TestWebKitAPI/PlatformGTK.cmake:
1575         * TestWebKitAPI/PlatformWPE.cmake:
1576
1577 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
1578
1579         [GTK][WPE] Add enable-javascript-markup setting
1580         https://bugs.webkit.org/show_bug.cgi?id=193439
1581
1582         Reviewed by Michael Catanzaro.
1583
1584         Add test cases to check the new setting.
1585
1586         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1587         (testWebKitSettings):
1588         (testWebKitSettingsJavaScriptMarkup):
1589         (beforeAll):
1590
1591 2019-02-10  Darin Adler  <darin@apple.com>
1592
1593         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
1594         https://bugs.webkit.org/show_bug.cgi?id=194485
1595
1596         Reviewed by Daniel Bates.
1597
1598         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
1599
1600 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1601
1602         Add more tests for clampTo<>()
1603         https://bugs.webkit.org/show_bug.cgi?id=194462
1604
1605         Reviewed by Geoffrey Garen.
1606
1607         Darin suggested to test the very last floating point number
1608         at the boundaries when truncating to integer.
1609         I added test for max/min and max-1/min-1.
1610
1611         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1612         (TestWebKitAPI::TEST):
1613
1614 2019-02-09  Darin Adler  <darin@apple.com>
1615
1616         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
1617         https://bugs.webkit.org/show_bug.cgi?id=194021
1618
1619         Reviewed by Geoffrey Garen.
1620
1621         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
1622         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
1623         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
1624
1625 2019-02-09  Zalan Bujtas  <zalan@apple.com>
1626
1627         [LFC][IFC] Add intrinsic width support for basic inline containers
1628         https://bugs.webkit.org/show_bug.cgi?id=194473
1629
1630         Reviewed by Antti Koivisto.
1631
1632         Expand tests coverage (11 new tests -> 798)
1633
1634         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
1635
1636 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
1637
1638         Fix MiniBrowser's entitlements
1639         https://bugs.webkit.org/show_bug.cgi?id=192431
1640
1641         Reviewed by Joseph Pecoraro.
1642
1643         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
1644         files, making it impossible to load any extension.
1645
1646         * MiniBrowser/MiniBrowser.entitlements:
1647
1648 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
1649
1650         [Cocoa] Ask platform for generic font family mappings
1651         https://bugs.webkit.org/show_bug.cgi?id=187723
1652         <rdar://problem/41892438>
1653
1654         Reviewed by Brent Fulgham.
1655
1656         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
1657
1658         * DumpRenderTree/mac/DumpRenderTree.mm:
1659         (allowedFontFamilySet):
1660         * WebKitTestRunner/mac/TestControllerMac.mm:
1661         (WTR::allowedFontFamilySet):
1662
1663 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
1664
1665         [GTK] Implement back/forward touchpad gesture
1666         https://bugs.webkit.org/show_bug.cgi?id=193919
1667
1668         Reviewed by Michael Catanzaro.
1669
1670         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
1671         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
1672
1673 2019-02-08  Alex Christensen  <achristensen@webkit.org>
1674
1675         Add SPI to use networking daemon instead of XPC service
1676         https://bugs.webkit.org/show_bug.cgi?id=194427
1677
1678         Reviewed by Geoffrey Garen
1679
1680         * MiniBrowser/MiniBrowser.entitlements:
1681
1682 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1683
1684         [ews-build] Ensure that every builder in config.json has short name
1685         https://bugs.webkit.org/show_bug.cgi?id=194461
1686
1687         Reviewed by Lucas Forschler.
1688
1689         * BuildSlaveSupport/ews-build/loadConfig.py:
1690         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
1691
1692 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
1693
1694         [ews-build] Add short name to config.json
1695         https://bugs.webkit.org/show_bug.cgi?id=194456
1696
1697         Reviewed by Lucas Forschler.
1698
1699         * BuildSlaveSupport/ews-build/config.json: Added short name.
1700         * BuildSlaveSupport/ews-build/loadConfig.py:
1701         (loadBuilderConfig): Set the short name as the builder description.
1702
1703 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
1704
1705         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
1706         https://bugs.webkit.org/show_bug.cgi?id=194418
1707
1708         Reviewed by Lucas Forschler.
1709
1710         Do not include errors trying when finding crashlogs at the end of
1711         a run-webkit-tests run since we don't process those errors.
1712
1713         * Scripts/webkitpy/port/darwin.py:
1714         (DarwinPort._look_for_all_crash_logs_in_log_dir):
1715         * Scripts/webkitpy/port/ios_device.py:
1716         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
1717         * Scripts/webkitpy/port/watch_device.py:
1718         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
1719
1720 2019-02-08  Beth Dakin  <bdakin@apple.com>
1721
1722         Add afterScreenUpdates to WKSnapshotConfiguration
1723         https://bugs.webkit.org/show_bug.cgi?id=194362
1724         -and corresponding-
1725         <rdar://problem/40655528> Please add an "after screen updates" property to 
1726         WKSnapshotConfiguration (to solve blank snapshots)
1727
1728         Reviewed by Tim Horton.
1729
1730         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
1731         (TEST):
1732
1733 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
1734
1735         clampTo(): do not convert the input to double when dealing with integers
1736         https://bugs.webkit.org/show_bug.cgi?id=194263
1737         <rdar://problem/47692312>
1738
1739         Reviewed by Darin Adler.
1740
1741         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
1742         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
1743         (TestWebKitAPI::testClampFloatingPointToInteger):
1744         (TestWebKitAPI::testClampSameSignIntegers):
1745         (TestWebKitAPI::testClampUnsignedToSigned):
1746         (TestWebKitAPI::testClampSignedToUnsigned):
1747
1748 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
1749
1750         webkitpy: Respect --dedicated-simulators flag
1751         https://bugs.webkit.org/show_bug.cgi?id=194416
1752         <rdar://problem/47894722>
1753
1754         Reviewed by Lucas Forschler.
1755
1756         * Scripts/webkitpy/port/device_port.py:
1757         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
1758         available devices can be safely ignored.
1759
1760 2019-02-07  Keith Rollin  <krollin@apple.com>
1761
1762         Remove extra copy of 100x100-red.tga
1763         https://bugs.webkit.org/show_bug.cgi?id=194371
1764         <rdar://problem/47873465>
1765
1766         Reviewed by Said Abou-Hallawa.
1767
1768         In order to help it pass its tests, Bug 194190 added a second copy of
1769         the file 100x100-red.tga. However, it turns out that this additional
1770         file wasn't actually needed, and that that sole previous copy was
1771         sufficient. At the same time, this second copy -- which was copied to
1772         the same location in the build output as the first copy -- now caused
1773         XCBuild to complain because there were two production rules for the
1774         same output file. Address this by removing the newly-added extra copy.
1775
1776         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1777         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
1778
1779 2019-02-07  Alex Christensen  <achristensen@webkit.org>
1780
1781         Deprecate WKBundlePageSetDefersLoading
1782         https://bugs.webkit.org/show_bug.cgi?id=191394
1783
1784         Reviewed by Dean Jackson.
1785
1786         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1787         (WTR::TestRunner::setDefersLoading):
1788
1789 2019-02-07  Zalan Bujtas  <zalan@apple.com>
1790
1791         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
1792         https://bugs.webkit.org/show_bug.cgi?id=194391
1793
1794         Reviewed by Antti Koivisto.
1795
1796         * LayoutReloaded/misc/LFC-passing-tests.txt:
1797
1798 2019-02-06  Keith Rollin  <krollin@apple.com>
1799
1800         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
1801         https://bugs.webkit.org/show_bug.cgi?id=193975
1802         <rdar://problem/47643306>
1803
1804         Reviewed by Tim Horton.
1805
1806         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
1807         the Info.plist file into the bundle. This step is not necessary as the
1808         implicit "bundle up all the build products into a framework" build
1809         phase does this already. Having the Copy Bundle Resources phase do
1810         this causes a conflict under XCBuild, which objects to two build
1811         phases producing the same file (Info.plist). Address this by removing
1812         Info.plist from the Copy Bundle Resources phase.
1813
1814         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1815
1816 2019-02-06  Keith Rollin  <krollin@apple.com>
1817
1818         Really enable the automatic checking and regenerations of .xcfilelists during builds
1819         https://bugs.webkit.org/show_bug.cgi?id=194357
1820         <rdar://problem/47861231>
1821
1822         Reviewed by Chris Dumez.
1823
1824         Bug 194124 was supposed to enable the automatic checking and
1825         regenerating of .xcfilelist files during the build. While related
1826         changes were included in that patch, the change to actually enable the
1827         operation somehow was omitted. This patch actually enables the
1828         operation. The check-xcfilelist.sh scripts now check
1829         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
1830         from the checking.
1831
1832         * DumpRenderTree/Scripts/check-xcfilelists.sh:
1833         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
1834
1835 2019-02-06  David Kilzer  <ddkilzer@apple.com>
1836
1837         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
1838         <https://webkit.org/b/194286>
1839         <rdar://problem/47815558>
1840
1841         Reviewed by Alexey Proskuryakov.
1842
1843         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1844         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
1845         WKRetainPtr<> to avoid leaking the WKDataRef.
1846
1847 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1848
1849         Unreviewed, fix a typo
1850
1851         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1852
1853 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
1854
1855         [GTK][WPE] force libpsl build to use ICU in jhbuild
1856         https://bugs.webkit.org/show_bug.cgi?id=194288
1857
1858         Reviewed by Carlos Garcia Campos.
1859
1860         * gtk/jhbuild.modules:
1861         Require ICU for libpsl build in jhbuild, like done in WPE.
1862
1863 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
1864
1865         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
1866         https://bugs.webkit.org/show_bug.cgi?id=194209
1867
1868         Reviewed by Carlos Garcia Campos.
1869
1870         Enhance TestCookieManager to ensure this doesn't happen again.
1871
1872         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
1873         (testCookieManagerPersistentStorage):
1874         (beforeAll):
1875
1876 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
1877
1878         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
1879         https://bugs.webkit.org/show_bug.cgi?id=194324
1880
1881         Reviewed by Andy Estes.
1882
1883         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
1884         part of the name is already implicit, since this is in testing code in TestOptions.
1885
1886         * WebKitTestRunner/TestController.cpp:
1887         (WTR::TestController::generateContextConfiguration const):
1888         (WTR::updateTestOptionsFromTestHeader):
1889         * WebKitTestRunner/TestOptions.h:
1890         (WTR::TestOptions::hasSameInitializationOptions const):
1891
1892 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1893
1894         [ews-build] Allow * as platform for builders and workers
1895         https://bugs.webkit.org/show_bug.cgi?id=188533
1896
1897         Reviewed by Lucas Forschler.
1898
1899         * BuildSlaveSupport/ews-build/loadConfig.py:
1900         (checkWorkersAndBuildersForConsistency):
1901
1902 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1903
1904         [ews-build] Add few bots to config.json
1905         https://bugs.webkit.org/show_bug.cgi?id=194304
1906
1907         Reviewed by Lucas Forschler.
1908
1909         * BuildSlaveSupport/ews-build/config.json:
1910
1911 2019-02-05  Keith Rollin  <krollin@apple.com>
1912
1913         Enable the automatic checking and regenerations of .xcfilelists during builds
1914         https://bugs.webkit.org/show_bug.cgi?id=194124
1915         <rdar://problem/47721277>
1916
1917         Reviewed by Tim Horton.
1918
1919         Bug 193790 add a facility for checking -- during build time -- that
1920         any needed .xcfilelist files are up-to-date and for updating them if
1921         they are not. This facility was initially opt-in by setting
1922         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
1923         the process seemed robust. Its now time to enable this facility and
1924         make it opt-out. If there is a need to disable this facility, set and
1925         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
1926         running `make` or `build-webkit`, or before running Xcode from the
1927         command line.
1928
1929         Additionally, remove the step that generates a list of source files
1930         going into the UnifiedSources build step. It's only necessarily to
1931         specify Sources.txt and SourcesCocoa.txt as inputs.
1932
1933         * Scripts/generate-xcfilelists:
1934
1935 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1936
1937         [GTK][WPE] force libpsl build to use ICU in jhbuild
1938         https://bugs.webkit.org/show_bug.cgi?id=194288
1939
1940         Reviewed by Philippe Normand.
1941
1942         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
1943         This can cause build failures if libidn is detected but libunistring is not available.
1944
1945         Make sure that ICU is used for runtime and builtin PSL data.
1946
1947         * gtk/jhbuild.modules:
1948         * wpe/jhbuild.modules:
1949
1950 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
1951
1952         [ews-app] Modified timestamp should be updated on updating data
1953         https://bugs.webkit.org/show_bug.cgi?id=194295
1954
1955         Reviewed by Lucas Forschler.
1956
1957         * BuildSlaveSupport/ews-app/ews/models/build.py:
1958         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
1959         * BuildSlaveSupport/ews-app/ews/models/step.py:
1960
1961 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
1962
1963         Unreviewed, rolling out r240742.
1964
1965         Causes crashes on iOS simulator.
1966
1967         Reverted changeset:
1968
1969         "[iOS] Keyups for non-modifier keys identified as "Dead" when
1970         not focused in a content-editable element"
1971         https://bugs.webkit.org/show_bug.cgi?id=192824
1972         https://trac.webkit.org/changeset/240742
1973
1974 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
1975
1976         run-webkit-tests emits message "...running None" when running tests
1977         https://bugs.webkit.org/show_bug.cgi?id=194133
1978         <rdar://problem/47724738>
1979
1980         Reviewed by Lucas Forschler.
1981
1982         * Scripts/webkitpy/xcode/device_type.py:
1983         (DeviceType.__str__): Use both version mapping tables and use just the variant
1984         name if no version name is available.
1985         * Scripts/webkitpy/xcode/device_type_unittest.py:
1986         (DeviceTypeTest):
1987         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
1988         an associated named.
1989
1990 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
1991
1992         [WPE] require python3-setuptools for meson build in jhbuild
1993         https://bugs.webkit.org/show_bug.cgi?id=194287
1994
1995         Reviewed by Philippe Normand.
1996
1997         python3-setuptools is needed to build meson in jhbuild.
1998         It is already required by the GTK port.
1999
2000         * wpe/install-dependencies:
2001
2002 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2003
2004         [ews-app] Add method to save BuilderMapping to database
2005         https://bugs.webkit.org/show_bug.cgi?id=194264
2006
2007         Reviewed by Lucas Forschler.
2008
2009         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2010         (BuilderMapping.__str__):
2011         (BuilderMapping):
2012         (BuilderMapping.save_mapping):
2013         (BuilderMapping.update_mapping):
2014         (BuilderMapping.get_existing_mapping):
2015         (BuilderMapping.is_valid_mapping):
2016
2017 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2018
2019         [ews-app] Add timestamp fields for BuilderMappings
2020         https://bugs.webkit.org/show_bug.cgi?id=194266
2021
2022         Reviewed by Lucas Forschler.
2023
2024         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2025         (BuilderMapping):
2026
2027 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2028
2029         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2030         https://bugs.webkit.org/show_bug.cgi?id=174816
2031
2032         Reviewed by Michael Catanzaro.
2033
2034         Add tests for webkit_uri_for_display().
2035
2036         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2037         (testURIForDisplayUnaffected):
2038         (testURIForDisplayAffected):
2039         (beforeAll):
2040         (afterAll):
2041         * TestWebKitAPI/glib/CMakeLists.txt:
2042
2043 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2044
2045         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2046         https://bugs.webkit.org/show_bug.cgi?id=194158
2047         <rdar://problem/47737268>
2048
2049         Rubber-stamped by Aakash Jain.
2050
2051         * Scripts/webkitpy/port/device_port.py:
2052         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2053
2054 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2055
2056         [CG] Enable setAdditionalSupportedImageTypes for WK1
2057         https://bugs.webkit.org/show_bug.cgi?id=194190
2058
2059         Reviewed by Tim Horton.
2060
2061         Add a test similar to the one under WebKit Cocoa but make it create a
2062         WebView instead of a WKWebView.
2063
2064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2065         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2066         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2067         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2068         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2069         (TestWebKitAPI::runTest):
2070         (TestWebKitAPI::TEST):
2071
2072 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2073
2074         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2075         https://bugs.webkit.org/show_bug.cgi?id=194168
2076
2077         Reviewed by Simon Fraser.
2078
2079         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2080
2081         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2082         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2083         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2084         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2085         (TEST):
2086         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2087         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2088
2089 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2090
2091         REGRESSION (r237269): webkit-patch what-broke is broken 
2092         https://bugs.webkit.org/show_bug.cgi?id=193025
2093
2094         Reviewed by Aakash Jain.
2095
2096         * Scripts/webkitpy/common/host.py:
2097         (Host.buildbot):
2098         (Host.bugzilla): Renamed to 'buildbot'.
2099
2100 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2101
2102         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2103         https://bugs.webkit.org/show_bug.cgi?id=194207
2104
2105         Reviewed by Tim Horton.
2106
2107         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2108         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2109         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2110         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2111         start and delete forwards to remove the original attachment.
2112
2113         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2114         (TestWebKitAPI::TEST):
2115
2116 2019-02-04  Youenn Fablet  <youenn@apple.com>
2117
2118         Capture state should be managed consistently when doing process swapping
2119         https://bugs.webkit.org/show_bug.cgi?id=194122
2120         <rdar://problem/47609293>
2121
2122         Reviewed by Eric Carlson.
2123
2124         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2125         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2126         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2127         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2128         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2129         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2130         (WTR::TestRunner::isDoingMediaCapture const):
2131         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2132         * WebKitTestRunner/TestController.cpp:
2133         (WTR::TestController::isDoingMediaCapture const):
2134         * WebKitTestRunner/TestController.h:
2135         * WebKitTestRunner/TestInvocation.cpp:
2136         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2137         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2138         (WTR::TestController::isDoingMediaCapture const):
2139
2140 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2141
2142         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2143         https://bugs.webkit.org/show_bug.cgi?id=194142
2144
2145         Reviewed by Ross Kirsling.
2146
2147         There three 'separator' variables in TestController.cpp. Renamed
2148         it 'pathSeparator', and unified them.
2149
2150         * WebKitTestRunner/TestController.cpp:
2151         (WTR::TestController::generateContextConfiguration const):
2152         (WTR::createTestURL):
2153         (WTR::TestController::platformAdjustContext):
2154
2155 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2156
2157         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2158         https://bugs.webkit.org/show_bug.cgi?id=194198
2159
2160         Reviewed by Antti Koivisto.
2161
2162         No need to set the banner heights on navigation now, since Page stores them.
2163
2164         * MiniBrowser/mac/WK2BrowserWindowController.m:
2165         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2166
2167 2019-02-03  John Wilander  <wilander@apple.com>
2168
2169         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2170         https://bugs.webkit.org/show_bug.cgi?id=194104
2171         <rdar://problem/47649991>
2172
2173         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2174
2175         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2176         (TestWebKitAPI::TEST):
2177             Changed numeric types from unsigned short to uint32_t.
2178
2179 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2180
2181         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2182         <https://webkit.org/b/194178>
2183         <rdar://problem/47753473>
2184
2185         Reviewed by Alexey Proskuryakov.
2186
2187         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2188         (WTR::uninstallFakeHelvetica): Pass nullptr into
2189         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2190
2191 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2192
2193         [LFC] Initialize ICB's style with fixed width/height.
2194         https://bugs.webkit.org/show_bug.cgi?id=194188
2195
2196         Reviewed by Antti Koivisto.
2197
2198         * LayoutReloaded/misc/LFC-passing-tests.txt:
2199
2200 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2201
2202         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
2203         https://bugs.webkit.org/show_bug.cgi?id=194185
2204
2205         Reviewed by Antti Koivisto.
2206
2207         * LayoutReloaded/misc/LFC-passing-tests.txt:
2208
2209 2018-12-16  Darin Adler  <darin@apple.com>
2210
2211         Convert additional String::format clients to alternative approaches
2212         https://bugs.webkit.org/show_bug.cgi?id=192746
2213
2214         Reviewed by Alexey Proskuryakov.
2215
2216         * WebKitTestRunner/TestController.cpp:
2217         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
2218         as an intermediate in code that ultimately constructs a WTF::String.
2219         (WTR::userMediaOriginHash): Use makeString.
2220         (WTR::TestController::didNavigateWithNavigationData): More of the same.
2221         (WTR::TestController::didPerformClientRedirect): Ditto.
2222         (WTR::TestController::didPerformServerRedirect): Ditto.
2223         (WTR::TestController::didUpdateHistoryTitle): Ditto.
2224
2225 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2226
2227         [ews-build] Add unit test to verify builder keys
2228         https://bugs.webkit.org/show_bug.cgi?id=194152
2229
2230         Reviewed by Lucas Forschler.
2231
2232         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
2233         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
2234
2235 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2236
2237         [LFC] Expand tests coverage (12 new tests -> 787)
2238
2239         Unreviewed test gardening.
2240
2241         * LayoutReloaded/misc/LFC-passing-tests.txt:
2242
2243 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2244
2245         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
2246         https://bugs.webkit.org/show_bug.cgi?id=194163
2247
2248         Reviewed by Simon Fraser.
2249
2250         775
2251
2252         * LayoutReloaded/misc/LFC-passing-tests.txt:
2253
2254 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2255
2256         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
2257         https://bugs.webkit.org/show_bug.cgi?id=194140
2258         <rdar://problem/47728098>
2259
2260         Reviewed by Tim Horton.
2261
2262         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2263         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2264         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
2265
2266         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
2267         test to induce an IPC deadlock when presenting a modal alert during touch start.
2268
2269         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2270         * WebKitTestRunner/TestController.cpp:
2271         (WTR::runJavaScriptAlert):
2272
2273         Add a client callback function for running JavaScript alerts.
2274
2275         (WTR::TestController::createOtherPage):
2276         (WTR::TestController::generateContextConfiguration const):
2277
2278         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
2279         the fix in this patch.
2280
2281         (WTR::TestController::createWebViewWithOptions):
2282
2283         Plumb TestOptions to generateContextConfiguration.
2284
2285         (WTR::TestController::resetPreferencesToConsistentValues):
2286         (WTR::TestController::resetStateToConsistentValues):
2287         (WTR::updateTestOptionsFromTestHeader):
2288         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
2289         (WTR::TestController::handleJavaScriptAlert):
2290         * WebKitTestRunner/TestController.h:
2291         * WebKitTestRunner/TestInvocation.cpp:
2292         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2293         * WebKitTestRunner/TestOptions.h:
2294         (WTR::TestOptions::hasSameInitializationOptions const):
2295
2296 2019-02-01  Chris Dumez  <cdumez@apple.com>
2297
2298         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
2299         https://bugs.webkit.org/show_bug.cgi?id=193740
2300         <rdar://problem/47527267>
2301
2302         Reviewed by Alex Christensen.
2303
2304         Add API test coverage.
2305
2306         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2307
2308 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
2309
2310         [ews-app] Add display name field to BuilderMapping model
2311         https://bugs.webkit.org/show_bug.cgi?id=194153
2312
2313         Reviewed by Lucas Forschler.
2314
2315         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2316         (BuilderMapping):
2317
2318 2019-02-01  Youenn Fablet  <youenn@apple.com>
2319
2320         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
2321         https://bugs.webkit.org/show_bug.cgi?id=194155
2322
2323         Reviewed by Eric Carlson.
2324
2325         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2326         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
2327         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
2328
2329 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2330
2331         [LFC] Adjust replaced element's intrinsic ratio
2332         https://bugs.webkit.org/show_bug.cgi?id=194154
2333
2334         Reviewed by Antti Koivisto.
2335
2336         761
2337
2338         * LayoutReloaded/misc/LFC-passing-tests.txt:
2339
2340 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2341
2342         [WPE] Show test results in minibrowser
2343         https://bugs.webkit.org/show_bug.cgi?id=194150
2344
2345         Reviewed by Žan Doberšek.
2346
2347         * Scripts/webkitpy/port/wpe.py:
2348         (WPEPort.show_results_html_file):
2349
2350 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2351
2352         [WPE] MiniBrowser: add ky bindings for back/forward navigation
2353         https://bugs.webkit.org/show_bug.cgi?id=194151
2354
2355         Reviewed by Žan Doberšek.
2356
2357         ALT + <- go back
2358         ALT + -> go forward
2359
2360         * MiniBrowser/wpe/main.cpp:
2361         (main):
2362
2363 2019-02-01  Zalan Bujtas  <zalan@apple.com>
2364
2365         [LFC] Set intrinsic size on Layout::Replaced
2366         https://bugs.webkit.org/show_bug.cgi?id=194139
2367
2368         Reviewed by Antti Koivisto.
2369
2370         744
2371
2372         * LayoutReloaded/misc/LFC-passing-tests.txt:
2373
2374 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
2375
2376         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
2377         https://bugs.webkit.org/show_bug.cgi?id=194146
2378
2379         Reviewed by Xabier Rodriguez-Calvar.
2380
2381         It allows to open relative paths.
2382
2383         * MiniBrowser/wpe/main.cpp:
2384         (main):
2385
2386 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
2387
2388         Update flakiness dashboard configuration after recent queue changes
2389         https://bugs.webkit.org/show_bug.cgi?id=194127
2390
2391         Rubber-stamped by Aakash Jain.
2392
2393         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
2394
2395         * TestResultServer/static-dashboards/builders.jsonp:
2396
2397 2019-01-31  Youenn Fablet  <youenn@apple.com>
2398
2399         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
2400         https://bugs.webkit.org/show_bug.cgi?id=194106
2401         <rdar://problem/47676333>
2402
2403         Reviewed by Ryosuke Niwa.
2404
2405         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
2406         (TestWebKitAPI::didFinishNavigation):
2407         (TestWebKitAPI::TEST):
2408         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
2409
2410 2019-01-31  Chris Dumez  <cdumez@apple.com>
2411
2412         Page zoom level is lost after a process swap or a crash
2413         https://bugs.webkit.org/show_bug.cgi?id=194105
2414         <rdar://problem/47610781>
2415
2416         Reviewed by Alex Christensen.
2417
2418         Add API test coverage.
2419
2420         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2421         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
2422
2423 2019-01-31  Alex Christensen  <achristensen@webkit.org>
2424
2425         Revert r238819 which is unneeded and caused a performance regression.
2426         https://bugs.webkit.org/show_bug.cgi?id=192272
2427         <rdar://problem/46664625>
2428
2429         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
2430         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
2431         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
2432
2433 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
2434
2435         Formalize WebKitAdditions mechanism of LoadOptimizer
2436         https://bugs.webkit.org/show_bug.cgi?id=193886
2437         <rdar://problem/47696809>
2438
2439         Reviewed by Brent Fulgham.
2440
2441         * MiniBrowser/MiniBrowser.entitlements:
2442         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
2443
2444 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2445
2446         [LFC] Margin before/after/start/end initial value is 0 and not auto.
2447         https://bugs.webkit.org/show_bug.cgi?id=194090
2448
2449         Reviewed by Antti Koivisto.
2450
2451         * LayoutReloaded/misc/LFC-passing-tests.txt:
2452
2453 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2454
2455         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
2456         https://bugs.webkit.org/show_bug.cgi?id=194074
2457
2458         Reviewed by Antti Koivisto.
2459
2460         * LayoutReloaded/misc/LFC-passing-tests.txt:
2461
2462 2019-01-31  Zalan Bujtas  <zalan@apple.com>
2463
2464         [LFC][BFC] Add support for block level replaced box.
2465         https://bugs.webkit.org/show_bug.cgi?id=194071
2466
2467         Reviewed by Antti Koivisto.
2468
2469         * LayoutReloaded/misc/LFC-passing-tests.txt:
2470
2471 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
2472
2473         Fix WebKitTestRunner's testPath with Windows full paths
2474         https://bugs.webkit.org/show_bug.cgi?id=194012
2475
2476         Reviewed by Alex Christensen.
2477
2478         updateTestOptionsFromTestHeader failed to open test files because
2479         testPath returned wrong file paths. It returned a path "/C:/..."
2480         if a URL "file:///C:/..." was given.
2481
2482         * WebKitTestRunner/TestController.cpp:
2483         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
2484
2485 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2486
2487         [WPE] Bump font related dependencies to match the GTK+ port
2488         https://bugs.webkit.org/show_bug.cgi?id=194017
2489
2490         Reviewed by Žan Doberšek.
2491
2492         * wpe/jhbuild.modules:
2493         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2494         * wpe/patches/icudata-stdlibs.patch: Added.
2495
2496 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2497
2498         Enable swipe tests on iOS
2499         https://bugs.webkit.org/show_bug.cgi?id=194076
2500
2501         Reviewed by Geoffrey Garen.
2502
2503         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
2504         it causes a debug assertion failure in runUIScript.
2505
2506         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2507         (WTR::UIScriptController::beginBackSwipe):
2508         (WTR::UIScriptController::completeBackSwipe):
2509
2510 2019-01-30  Keith Rollin  <krollin@apple.com>
2511
2512         Use correct printf format specifier
2513         https://bugs.webkit.org/show_bug.cgi?id=194062
2514         <rdar://problem/47686167>
2515
2516         Reviewed by Alexey Proskuryakov.
2517
2518         LayoutTestSpellChecker.mm is trying to format a variable of type
2519         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
2520         actually an unsigned long long. Fix this by formatting with %llu.
2521
2522         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2523         (-[LayoutTestTextCheckingResult description]):
2524
2525 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
2526
2527         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
2528         https://bugs.webkit.org/show_bug.cgi?id=193979
2529
2530         Reviewed by Wenson Hsieh.
2531
2532         Fix the test for iOS. Make the test work with iOS UA string.
2533
2534         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2535
2536 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
2537
2538         Replace High Sierra LLINT CLoop bot due to hardware failure
2539         https://bugs.webkit.org/show_bug.cgi?id=194066
2540
2541         Reviewed by Aakash Jain.
2542
2543         * BuildSlaveSupport/build.webkit.org-config/config.json:
2544
2545 2019-01-30  Keith Rollin  <krollin@apple.com>
2546
2547         [NSDragItem init] is unavailable
2548         https://bugs.webkit.org/show_bug.cgi?id=194059
2549         <rdar://problem/47685715>
2550
2551         Reviewed by Wenson Hsieh.
2552
2553         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
2554         DumpRenderTree and TestWebKitAPI, which both try to create an
2555         NSDragItem in a manner that invokes this method. Address this by using
2556         -initWithPasteboardWriter instead.
2557
2558         Note that the parameter passed to initWithPasteboardWriter is likely
2559         incorrect. In both cases, the object passed does not conform to
2560         NSPasteboardWriting. However, with this fix, we're no worse off than
2561         before, and can now perform builds with newer compilers and SDKs until
2562         a real fix can be crafted. That work is tracked in
2563         https://bugs.webkit.org/show_bug.cgi?id=194060
2564
2565         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2566         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2567         * TestWebKitAPI/mac/TestDraggingInfo.mm:
2568         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
2569
2570 2019-01-30  Daniel Bates  <dabates@apple.com>
2571
2572         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
2573         https://bugs.webkit.org/show_bug.cgi?id=192824
2574         <rdar://problem/47100332>
2575
2576         Reviewed by Wenson Hsieh.
2577
2578         Fix a bug where the wrong usage code was used for F13 thru F24.
2579
2580         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2581         (keyCodeForDOMFunctionKey):
2582
2583 2019-01-30  Chris Dumez  <cdumez@apple.com>
2584
2585         Regression(PSON) Load hang can occur on history navigation
2586         https://bugs.webkit.org/show_bug.cgi?id=194030
2587         <rdar://problem/47656939>
2588
2589         Reviewed by Antti Koivisto.
2590
2591         Add API test coverage.
2592
2593         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2594
2595 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2596
2597         [LFC] Expand tests coverage.
2598
2599         Unreviewed test gardening.
2600
2601         * LayoutReloaded/misc/LFC-passing-tests.txt:
2602
2603 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
2604
2605         [Flatpak] Add openjpeg support
2606         https://bugs.webkit.org/show_bug.cgi?id=194019
2607
2608         Reviewed by Michael Catanzaro.
2609
2610         * flatpak/org.webkit.CommonModules.yaml:
2611
2612 2019-01-30  Commit Queue  <commit-queue@webkit.org>
2613
2614         Unreviewed, rolling out r240708.
2615         https://bugs.webkit.org/show_bug.cgi?id=194022
2616
2617         It broke WPE build (Requested by KaL on #webkit).
2618
2619         Reverted changeset:
2620
2621         "[WPE] Bump font related dependencies to match the GTK+ port"
2622         https://bugs.webkit.org/show_bug.cgi?id=194017
2623         https://trac.webkit.org/changeset/240708
2624
2625 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2626
2627         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
2628         https://bugs.webkit.org/show_bug.cgi?id=194001
2629
2630         Reviewed by Antti Koivisto.
2631
2632         * LayoutReloaded/misc/LFC-passing-tests.txt:
2633
2634 2019-01-30  Zalan Bujtas  <zalan@apple.com>
2635
2636         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
2637         https://bugs.webkit.org/show_bug.cgi?id=194020
2638
2639         Reviewed by Antti Koivisto.
2640
2641         * LayoutReloaded/misc/LFC-passing-tests.txt:
2642
2643 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
2644
2645         AX: Support color well on iOS
2646         https://bugs.webkit.org/show_bug.cgi?id=194010
2647
2648         Reviewed by Joanmarie Diggs.
2649
2650         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2651         (WTR::AccessibilityUIElement::stringAttributeValue):
2652
2653 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
2654
2655         [WPE] Bump font related dependencies to match the GTK+ port
2656         https://bugs.webkit.org/show_bug.cgi?id=194017
2657
2658         Reviewed by Žan Doberšek.
2659
2660         * wpe/jhbuild.modules:
2661         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
2662         * wpe/patches/icudata-stdlibs.patch: Added.
2663
2664 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
2665
2666         [Mac] Update window scale API usage
2667         https://bugs.webkit.org/show_bug.cgi?id=193991
2668         rdar://problem/47614795
2669
2670         Reviewed by Tim Horton.
2671
2672         * DumpRenderTree/mac/DumpRenderTree.mm:
2673         (changeWindowScaleIfNeeded):
2674         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2675         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2676         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2677
2678 2019-01-29  Chris Dumez  <cdumez@apple.com>
2679
2680         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
2681         https://bugs.webkit.org/show_bug.cgi?id=193977
2682         <rdar://problem/47643716>
2683
2684         Reviewed by Geoff Garen.
2685
2686         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
2687         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
2688         to the previous provisional committing *before* we make the last load. 
2689
2690         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2691
2692 2019-01-29  Youenn Fablet  <youenn@apple.com>
2693
2694         Adopt new SPI to evaluate server certificate trust
2695         https://bugs.webkit.org/show_bug.cgi?id=193355
2696
2697         Reviewed by Alex Christensen.
2698
2699         Add infrastructure to handle HTTPS server trust evaluation testing.
2700
2701         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2702         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2703         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
2704         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
2705         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
2706         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2707         * WebKitTestRunner/TestController.cpp:
2708         (WTR::TestController::resetPreferencesToConsistentValues):
2709         (WTR::TestController::didReceiveAuthenticationChallenge):
2710         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2711         * WebKitTestRunner/TestController.h:
2712         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
2713         * WebKitTestRunner/TestInvocation.cpp:
2714         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2715         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2716         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
2717
2718 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2719
2720         [ews-build] Add build step to print bot Configuration
2721         https://bugs.webkit.org/show_bug.cgi?id=193887
2722
2723         Reviewed by Lucas Forschler.
2724
2725         * BuildSlaveSupport/ews-build/steps.py:
2726         (PrintConfiguration): Build step to print configuration.
2727         * BuildSlaveSupport/ews-build/factories.py:
2728
2729 2019-01-29  Chris Dumez  <cdumez@apple.com>
2730
2731         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
2732         https://bugs.webkit.org/show_bug.cgi?id=193967
2733         <rdar://problem/47635348>
2734
2735         Reviewed by Alex Christensen.
2736
2737         Add API test coverage.
2738
2739         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2740         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
2741
2742 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2743
2744         [ews-app] Handle incoming results data
2745         https://bugs.webkit.org/show_bug.cgi?id=193973
2746
2747         Reviewed by Lucas Forschler.
2748
2749         * BuildSlaveSupport/ews-app/ews/views/results.py:
2750
2751 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2752
2753         [ews-app] Make the results url generic
2754         https://bugs.webkit.org/show_bug.cgi?id=193928
2755
2756         Reviewed by Lucas Forschler.
2757
2758         * BuildSlaveSupport/ews-app/ews/urls.py:
2759
2760 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
2761
2762         [ews-build] Configure buildbot to send events to ews-app
2763         https://bugs.webkit.org/show_bug.cgi?id=193968
2764
2765         Reviewed by Lucas Forschler.
2766
2767         * BuildSlaveSupport/ews-build/events.py: Added.
2768         * BuildSlaveSupport/ews-build/master.cfg:
2769
2770 2019-01-29  Keith Rollin  <krollin@apple.com>
2771
2772         Add .xcfilelists to Run Script build phases
2773         https://bugs.webkit.org/show_bug.cgi?id=193792
2774         <rdar://problem/47201785>
2775
2776         Reviewed by Alex Christensen.
2777
2778         As part of supporting XCBuild, update the necessary Run Script build
2779         phases in their Xcode projects to refer to their associated
2780         .xcfilelist files.
2781
2782         Note that the addition of these files bumps the Xcode project version
2783         number to something that's Xcode 10 compatible. This change means that
2784         older versions of the Xcode IDE can't read these projects. Nor can it
2785         fully load workspaces that refer to these projects (the updated
2786         projects are shown as non-expandable placeholders). `xcodebuild` can
2787         still build these projects; it's just that the IDE can't open them.
2788
2789         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2790         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2791
2792 2019-01-29  John Wilander  <wilander@apple.com>
2793
2794         Add data abstraction and validation for Ad Click Attribution
2795         https://bugs.webkit.org/show_bug.cgi?id=193916
2796         <rdar://problem/47603481>
2797
2798         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
2799
2800         Ad click attribution has two steps. First, the storage of an ad
2801         campaign ID for a click that takes the user to a destination
2802         site. Second, a conversion on the destination site that can be
2803         attributed to the ad click.
2804
2805         This patch adds a class that represents a request for ad click
2806         attribution. Validation makes sure that the bits of entropy
2807         reported through this mechanism is limited.
2808
2809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2810         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
2811         (TestWebKitAPI::TEST):
2812
2813 2019-01-29  Chris Dumez  <cdumez@apple.com>
2814
2815         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
2816         https://bugs.webkit.org/show_bug.cgi?id=193932
2817         <rdar://problem/47598947>
2818
2819         Reviewed by Brady Eidson.
2820
2821         Add API test coverage.
2822
2823         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2824
2825 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2826
2827         Adding new passing LFC tests.
2828
2829         Unreviewed test gardening.
2830
2831         * LayoutReloaded/misc/LFC-passing-tests.txt:
2832
2833 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2834
2835         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
2836         https://bugs.webkit.org/show_bug.cgi?id=193964
2837
2838         Reviewed by Antti Koivisto.
2839
2840         * LayoutReloaded/misc/LFC-passing-tests.txt:
2841
2842 2019-01-29  Zalan Bujtas  <zalan@apple.com>
2843
2844         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
2845         https://bugs.webkit.org/show_bug.cgi?id=193954
2846
2847         Reviewed by Antti Koivisto.
2848
2849         * LayoutReloaded/misc/LFC-passing-tests.txt:
2850
2851 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
2852
2853         WebDriver: add support for running subtests
2854         https://bugs.webkit.org/show_bug.cgi?id=193904
2855
2856         Reviewed by Michael Catanzaro.
2857
2858         pytest already supports it by passing test.py::subtest, so we can do the same.
2859
2860         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
2861         (get_item_name): Made this global.
2862         (CollectRecorder.__init__): Receive the parameter to ignore.
2863         (CollectRecorder.pytest_collectreport): Collect also the subtests.
2864         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
2865         (collect): Add parameter to ignore.
2866         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
2867         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
2868         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
2869         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
2870         (WebDriverTestRunnerSelenium.run): Ditto.
2871         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
2872         (WebDriverTestRunnerW3C.collect_tests): Ditto.
2873         (WebDriverTestRunnerW3C.run): Ditto.
2874
2875 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
2876
2877         User agent string override for navigator.userAgent should be site specific quirks
2878         https://bugs.webkit.org/show_bug.cgi?id=193950
2879
2880         Reviewed by Brent Fulgham.
2881
2882         Updated per the _WKWebsitePolicies rename.
2883
2884         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
2885         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
2886
2887 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
2888
2889         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
2890         https://bugs.webkit.org/show_bug.cgi?id=193941
2891
2892         Reviewed by Alex Christensen.
2893
2894         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
2895         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2896         * TestWebKitAPI/Tests/WTF/Lock.cpp:
2897         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2898         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2899         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2900         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
2901         * TestWebKitAPI/Tests/WTF/Time.cpp:
2902         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
2903         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
2904         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
2905         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2906
2907 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
2908
2909         Unreviewed, reorder my emails to fix autocomplete in bugzilla
2910
2911         * Scripts/webkitpy/common/config/contributors.json:
2912
2913 2019-01-28  Andy Estes  <aestes@apple.com>
2914
2915         [watchOS] Enable Parental Controls content filtering
2916         https://bugs.webkit.org/show_bug.cgi?id=193939
2917         <rdar://problem/46641912>
2918
2919         Reviewed by Ryosuke Niwa.
2920
2921         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2922
2923 2019-01-28  David Kilzer  <ddkilzer@apple.com>
2924
2925         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
2926         <https://webkit.org/b/193884>
2927
2928         Reviewed by Jiewen Tan.
2929
2930         * Scripts/webkitpy/style/checkers/cpp.py:
2931         (check_language): Add LocalAuthentication to
2932         `frameworks_with_soft_links`.
2933
2934 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2935
2936         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
2937         https://bugs.webkit.org/show_bug.cgi?id=193891
2938
2939         Reviewed by Ross Kirsling.
2940
2941         There were three problems in window sizes of WebView and the host window.
2942         1. The sizes of pixel image output were incorrect.
2943         2. The host window is going to appear after window.resize was invoked.
2944         3. window.resize resized only the host window, not WebView.
2945
2946         This change solves them with a following approach.
2947         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
2948         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
2949            as well as DumpRenderTree in order to match the client area and the window area.
2950         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
2951         d. PlatformWebView::setWindowFrame changes both window sizes.
2952         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
2953
2954         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
2955         (WTR::PlatformWebView::PlatformWebView): Create the host window
2956         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
2957         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
2958         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
2959
2960 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2961
2962         [ews-app] Add method to save Step data to database
2963         https://bugs.webkit.org/show_bug.cgi?id=193890
2964
2965         Reviewed by Lucas Forschler.
2966
2967         * BuildSlaveSupport/ews-app/ews/models/step.py:
2968         (Step.save_step): Method to save step data.
2969         (Step.update_step): Method to update step data.
2970         (Step.get_existing_step): Method to fetch existing step from database.
2971         (Step.is_valid_result): Method to validate valid step result.
2972
2973 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
2974
2975         [ews-app] Add method to save Build data to database
2976         https://bugs.webkit.org/show_bug.cgi?id=193735
2977
2978         Reviewed by Lucas Forschler.
2979
2980         * BuildSlaveSupport/ews-app/ews/models/build.py:
2981         (Build.save_build): Method to save build information to database.
2982         (Build.get_existing_build): Method to fetch existing build from database.
2983         (Build.is_valid_result): Method to validate build result.
2984         * BuildSlaveSupport/ews-app/ews/common/util.py:
2985         (is_valid_int_id): Method to validate valid id.
2986
2987 2019-01-28  Chris Dumez  <cdumez@apple.com>
2988
2989         Regression(PSON) Crash under WebPageProxy::didStartProgress()
2990         https://bugs.webkit.org/show_bug.cgi?id=193915
2991         <rdar://problem/47560907>
2992
2993         Reviewed by Alex Christensen.
2994
2995         Add API test coverage.
2996
2997         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2998
2999 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3000
3001         [ews-app] Rename id variables
3002         https://bugs.webkit.org/show_bug.cgi?id=193883
3003
3004         Reviewed by Lucas Forschler.
3005
3006         * BuildSlaveSupport/ews-app/ews/models/build.py:
3007         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3008         * BuildSlaveSupport/ews-app/ews/models/step.py:
3009         * BuildSlaveSupport/ews-app/ews/urls.py:
3010         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3011         * BuildSlaveSupport/ews-app/ews/views/results.py:
3012         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3013
3014 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3015
3016         [ews-app] Allow certain fields to be empty
3017         https://bugs.webkit.org/show_bug.cgi?id=193892
3018
3019         Reviewed by Lucas Forschler.
3020
3021         * BuildSlaveSupport/ews-app/ews/models/build.py:
3022         * BuildSlaveSupport/ews-app/ews/models/step.py:
3023
3024 2019-01-28  Rob Buis  <rbuis@igalia.com>
3025
3026         Update MIME type parser
3027         https://bugs.webkit.org/show_bug.cgi?id=180526
3028
3029         Reviewed by Frédéric Wang.
3030
3031         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3032         (TestWebKitAPI::TEST):
3033
3034 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3035
3036         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3037         https://bugs.webkit.org/show_bug.cgi?id=193896
3038
3039         Reviewed by Antti Koivisto.
3040
3041         * LayoutReloaded/misc/LFC-passing-tests.txt:
3042
3043 2018-12-15  Darin Adler  <darin@apple.com>
3044
3045         Replace many uses of String::format with more type-safe alternatives
3046         https://bugs.webkit.org/show_bug.cgi?id=192742
3047
3048         Reviewed by Mark Lam.
3049
3050         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3051         (WTR::cacheTestRunnerCallback): Use makeString.
3052         * WebKitTestRunner/TestController.cpp:
3053         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3054         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3055
3056 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3057
3058         Use a load optimizer for some sites
3059         https://bugs.webkit.org/show_bug.cgi?id=193881
3060         <rdar://problem/46325455>
3061
3062         Reviewed by Brent Fulgham.
3063
3064         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3065         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3066
3067 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3068
3069         AX: Introduce a static accessibility tree
3070         https://bugs.webkit.org/show_bug.cgi?id=193348
3071         <rdar://problem/47203295>
3072
3073         Reviewed by Ryosuke Niwa.
3074
3075         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3076
3077 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3078
3079         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3080         https://bugs.webkit.org/show_bug.cgi?id=193867
3081
3082         Reviewed by Antti Koivisto.
3083
3084         * LayoutReloaded/misc/LFC-passing-tests.txt:
3085
3086 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3087
3088         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3089         https://bugs.webkit.org/show_bug.cgi?id=193865
3090
3091         Reviewed by Antti Koivisto.
3092
3093         * LayoutReloaded/misc/LFC-passing-tests.txt:
3094
3095 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3096
3097         Need a mechanism to override navigator.userAgent
3098         https://bugs.webkit.org/show_bug.cgi?id=193762
3099         <rdar://problem/47504939>
3100
3101         Reviewed by Brent Fulgham.
3102
3103         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3104
3105         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3106         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3107         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3108
3109 2019-01-25  Dean Jackson  <dino@apple.com>
3110
3111         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3112         https://bugs.webkit.org/show_bug.cgi?id=193831
3113         <rdar://problem/47399263>
3114
3115         Reviewed by Chris Dumez.
3116
3117         Two new tests that exercise cross-origin and same-origin System
3118         Previews.
3119
3120         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3121
3122 2019-01-25  Keith Rollin  <krollin@apple.com>
3123
3124         Update Xcode projects with "Check .xcfilelists" build phase
3125         https://bugs.webkit.org/show_bug.cgi?id=193790
3126         <rdar://problem/47201374>
3127
3128         Reviewed by Alex Christensen.
3129
3130         Support for XCBuild includes specifying inputs and outputs to various
3131         Run Script build phases. These inputs and outputs are specified as
3132         .xcfilelist files. Once created, these .xcfilelist files need to be
3133         kept up-to-date. In order to check that they are up-to-date or not,
3134         add an Xcode build step that invokes an external script that performs
3135         the checking. If the .xcfilelists are found to be out-of-date, update
3136         them, halt the build, and instruct the developer to restart the build
3137         with up-to-date files.
3138
3139         At this time, the checking and regenerating is performed only if the
3140         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3141         who want to use this facility can set this variable and test out the
3142         checking/regenerating. Once it seems like there are no egregious
3143         issues that upset a developer's workflow, we'll unconditionally enable
3144         this facility.
3145
3146         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3147         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3148         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3149         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3150
3151 2019-01-25  Keith Rollin  <krollin@apple.com>
3152
3153         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3154         https://bugs.webkit.org/show_bug.cgi?id=193781
3155         <rdar://problem/47201153>
3156
3157         Reviewed by Alex Christensen.
3158
3159         Part of generating the .xcfilelists used as part of adopting XCBuild
3160         includes running `make DerivedSources.make` from a standalone script.
3161         It’s important for this invocation to have the same environment as
3162         when the actual build invokes `make DerivedSources.make`. If the
3163         environments are different, then the two invocations will provide
3164         different results. In order to get the same environment in the
3165         standalone script, have the script launch xcodebuild targeting the
3166         "Apply Configuration to XCFileLists" build target, which will then
3167         re-invoke our standalone script. The script is now running again, this
3168         time in an environment with all workspace, project, target, xcconfig
3169         and other environment variables established.
3170
3171         The "Apply Configuration to XCFileLists" build target accomplishes
3172         this task via a small embedded shell script that consists only of:
3173
3174             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3175
3176         The process that invokes "Apply Configuration to XCFileLists" first
3177         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3178         evaluated and exports it into the shell environment. When xcodebuild
3179         is invoked, it inherits the value of this variable and can `eval` the
3180         contents of that variable. Our external standalone script can then set
3181         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3182         of command-line parameters needed to restart itself in the appropriate
3183         state.
3184
3185         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3186         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3187
3188 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3189
3190         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3191         https://bugs.webkit.org/show_bug.cgi?id=193802
3192         <rdar://problem/46010580>
3193
3194         Reviewed by Andy Estes.
3195
3196         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3197         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3198         (TEST):
3199
3200 2019-01-25  Daniel Bates  <dabates@apple.com>
3201
3202         [iOS] uiController.keyDown() does not translate Control modified key
3203         https://bugs.webkit.org/show_bug.cgi?id=192898
3204
3205         Reviewed by Wenson Hsieh.
3206
3207         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
3208         key translation, as applicable. Among other cases, key translation occurs when performing
3209         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
3210         also makes the behavior of uiController.keyDown() more closely match the behavior of a
3211         human pressing down and releasing key(s) using a hardware keyboard.
3212
3213         * WebKitTestRunner/ios/HIDEventGenerator.h:
3214         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3215         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
3216
3217         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
3218         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
3219         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3220         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3221         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
3222         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
3223         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
3224         (-[HIDEventGenerator longPress:completionBlock:]):
3225         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
3226         Update code for above renaming.
3227
3228         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
3229         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
3230
3231         (-[HIDEventGenerator keyDown:]): Added.
3232         (-[HIDEventGenerator keyUp:]): Added.
3233         (-[HIDEventGenerator keyPress:completionBlock:]):
3234         (-[HIDEventGenerator eventDispatchThreadEntry:]):
3235         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
3236         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3237         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
3238         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
3239         (WTR::parseModifier): Deleted.
3240
3241 2019-01-25  Keith Rollin  <krollin@apple.com>
3242
3243         Complete the implementation of generate-xcfilelists
3244         https://bugs.webkit.org/show_bug.cgi?id=193782
3245
3246         Reviewed by Alex Christensen.
3247
3248         A preliminary version of generate-xcfilelists was added in r238008.
3249         This patch updates that script in order to:
3250
3251         - Support checking of .xcfilelists
3252         - Perform better execution of `make DerivedSources.make` by
3253           relaunching generate-xcfilelists under xcodebuild
3254         - Support incremental generation and checking of .xcfilelists
3255         - Support supplementary .xcfilelists files from WebKitAdditions
3256         - Support being wrapped by parallel version of generate-xcfilelists in
3257           Internal that adds support for (re)generating WebKit projects in
3258           that repo.
3259         - Support builds that have been performed in WebKitBuild as well as
3260           ~/Library/Developer/code/DerivedData
3261         - Increase robustness and debugging facilities.
3262
3263         * Scripts/generate-xcfilelists:
3264
3265 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3266
3267         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3268         https://bugs.webkit.org/show_bug.cgi?id=193297
3269         <rdar://problem/47158841>
3270
3271         Unreviewed test case fix.
3272
3273         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
3274         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
3275
3276         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
3277         (TEST):
3278
3279 2019-01-25  Keith Rollin  <krollin@apple.com>
3280
3281         Update existing .xcfilelists
3282         https://bugs.webkit.org/show_bug.cgi?id=193791
3283         <rdar://problem/47201706>
3284
3285         Reviewed by Alex Christensen.
3286
3287         Many .xcfilelist files were added in r238824 in order to support
3288         XCBuild. Update these with recent changes to the set of build files
3289         and with the current generate-xcfilelist script.
3290
3291         * DumpRenderTree/DerivedSources-input.xcfilelist:
3292         * DumpRenderTree/DerivedSources-output.xcfilelist:
3293         * WebKitTestRunner/DerivedSources-input.xcfilelist:
3294         * WebKitTestRunner/DerivedSources-output.xcfilelist:
3295
3296 2019-01-25  Keith Rollin  <krollin@apple.com>
3297
3298         Fix missing dependencies in extract-dependencies-from-makefile
3299         https://bugs.webkit.org/show_bug.cgi?id=193783
3300         <rdar://problem/47201571>
3301
3302         Reviewed by Alex Christensen.
3303
3304         The extract-dependencies-from-makefile script generates .xcfilelists
3305         for XCBuild by invoking a makefile in --debug mode, parsing the
3306         dependency information in the output, and extracting information
3307         regarding targets and dependents. However, the way `make` emits this
3308         dependency information is not rigorous, and so we need to determine
3309         what lines to look for and parse by trial and error. This approach
3310         didn't coriginally atch all the information we needed to collect, so
3311         update the script to look for the additional lines we now know to look
3312         for.
3313
3314         * Scripts/extract-dependencies-from-makefile:
3315         (Parser):
3316         (Parser.addTarget):
3317         (Parser.addPrereq):
3318         (Parser.doParse):
3319
3320 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
3321
3322         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3323         https://bugs.webkit.org/show_bug.cgi?id=193297
3324         <rdar://problem/47158841>
3325
3326         Reviewed by Alex Christensen.
3327
3328         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
3329             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
3330         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3331         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3332         activating the message used to trigger the callback when it is set.
3333
3334 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3335
3336         WKWebView.goBack should reload if there is a safe browsing warning
3337         https://bugs.webkit.org/show_bug.cgi?id=193805
3338         <rdar://problem/46908216>
3339
3340         Reviewed by Geoff Garen.
3341
3342         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3343         (+[Simple3LookupContext sharedLookupContext]):
3344         (-[Simple3LookupContext lookUpURL:completionHandler:]):
3345         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
3346         (TEST):
3347
3348 2019-01-25  Chris Dumez  <cdumez@apple.com>
3349
3350         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
3351         https://bugs.webkit.org/show_bug.cgi?id=193788
3352         <rdar://problem/47531231>
3353
3354         Reviewed by Alex Christensen.
3355
3356         Add API test coverage.
3357
3358         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3359         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
3360
3361 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
3362
3363         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
3364         https://bugs.webkit.org/show_bug.cgi?id=193771
3365
3366         Unreviewed infrastructure fix.
3367
3368         * Scripts/webkitpy/port/darwin.py:
3369         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
3370
3371 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3372
3373         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
3374
3375 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
3376
3377         Add contributors.json entries for Ling Ho and for a new bot watchers group.
3378
3379         * Scripts/webkitpy/common/config/contributors.json:
3380
3381 2019-01-25  Chris Dumez  <cdumez@apple.com>
3382
3383         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
3384         https://bugs.webkit.org/show_bug.cgi?id=193779
3385         <rdar://problem/46170903>
3386
3387         Reviewed by Antti Koivisto.
3388
3389         Add API test that quickly navigates forward to a previous process without waiting for it to
3390         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
3391         the process' previous page when reconnecting the it for the forward navigation.
3392
3393         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3394
3395 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
3396
3397         Need a way for JavaScript (or bundle) code to participate in undo
3398         https://bugs.webkit.org/show_bug.cgi?id=190009
3399         <rdar://problem/44807048>
3400
3401         Reviewed by Ryosuke Niwa.
3402
3403         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
3404         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
3405
3406         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3407         (WTR::UIScriptController::lastUndoLabel const):
3408         (WTR::UIScriptController::firstRedoLabel const):
3409         (WTR::UIScriptController::platformUndoManager const):
3410         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3411         (WTR::UIScriptController::lastUndoLabel const):
3412         (WTR::UIScriptController::firstRedoLabel const):
3413         (WTR::UIScriptController::platformUndoManager const):
3414         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3415         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3416         (WTR::UIScriptController::lastUndoLabel const):
3417         (WTR::UIScriptController::firstRedoLabel const):
3418         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3419         * WebKitTestRunner/UIScriptControllerCocoa.mm:
3420         (WTR::UIScriptController::lastUndoLabel const):
3421         (WTR::UIScriptController::firstRedoLabel const):
3422         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3423         (WTR::UIScriptController::platformUndoManager const):
3424         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3425         (WTR::UIScriptController::platformUndoManager const):
3426
3427 2019-01-25  Zalan Bujtas  <zalan@apple.com>
3428
3429         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
3430         https://bugs.webkit.org/show_bug.cgi?id=193824
3431
3432         Reviewed by Antti Koivisto.
3433
3434         * LayoutReloaded/misc/LFC-passing-tests.txt:
3435
3436 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
3437
3438         Update macOS JSC bot configurations
3439         https://bugs.webkit.org/show_bug.cgi?id=193739
3440
3441         Reviewed by Alexey Proskuryakov.
3442
3443         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
3444         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3445         (BubbleQueueServer): Move JSC EWS to Mojave section.
3446         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3447         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
3448         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
3449
3450 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
3451
3452         [Win][WebKitTestRunner] Implement EventSenderProxy
3453         https://bugs.webkit.org/show_bug.cgi?id=193755
3454
3455         Reviewed by Don Olmstead.
3456
3457         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
3458         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
3459         (WTR::EventSenderProxy::dispatchMessage):
3460         (WTR::EventSenderProxy::EventSenderProxy):
3461         (WTR::EventSenderProxy::mouseDown):
3462         (WTR::EventSenderProxy::mouseUp):
3463         (WTR::EventSenderProxy::mouseMoveTo):
3464         (WTR::EventSenderProxy::mouseScrollBy):
3465         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
3466
3467 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3468
3469         Unreviewed fix for API test failure after r240437.
3470
3471         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
3472
3473         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
3474
3475 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3476
3477         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
3478         https://bugs.webkit.org/show_bug.cgi?id=193787
3479         <rdar://problem/47497634>
3480
3481         Reviewed by Alexey Proskuryakov.
3482
3483         * Scripts/webkitdirs.pm:
3484         (iosSimulatorApplicationsPath): Pick from available runtime directories.
3485
3486 2019-01-24  Truitt Savell  <tsavell@apple.com>
3487
3488         Unreviewed, rolling out r240446.
3489
3490         Casued 5 API failures
3491
3492         Reverted changeset:
3493
3494         "Activate the WebResourceLoadStatisticsStore in the
3495         NetworkProcess and deactivate it in the UIProcess."
3496         https://bugs.webkit.org/show_bug.cgi?id=193297
3497         https://trac.webkit.org/changeset/240446
3498
3499 2019-01-24  Zalan Bujtas  <zalan@apple.com>
3500
3501         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
3502         https://bugs.webkit.org/show_bug.cgi?id=193741
3503         <rdar://problem/47135030>
3504
3505         Reviewed by Antti Koivisto and Simon Fraser.
3506
3507         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3508         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
3509         (TestWebKitAPI::TEST):
3510
3511 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
3512
3513         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
3514         https://bugs.webkit.org/show_bug.cgi?id=193297
3515         <rdar://problem/47158841>
3516
3517         Reviewed by Alex Christensen.
3518
3519         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3520         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
3521         activating the message used to trigger the callback when it is set.
3522
3523 2019-01-24  John Wilander  <wilander@apple.com>
3524
3525         Add Ad Click Attribution as an internal/experimental feature
3526         https://bugs.webkit.org/show_bug.cgi?id=193685
3527         <rdar://problem/47450399>
3528
3529         Reviewed by Brent Fulgham.
3530
3531         Added test option adClickAttributionEnabled.
3532
3533         * DumpRenderTree/TestOptions.cpp:
3534         (TestOptions::TestOptions):
3535         * DumpRenderTree/TestOptions.h:
3536         * DumpRenderTree/mac/DumpRenderTree.mm:
3537         (setWebPreferencesForTestOptions):
3538
3539 2019-01-24  Antti Koivisto  <antti@apple.com>
3540
3541         [PSON] Flash on back navigation on Mac
3542         https://bugs.webkit.org/show_bug.cgi?id=193716
3543         <rdar://problem/47148458>
3544
3545         Reviewed by Chris Dumez.
3546
3547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3548
3549         Closing of the previous page is delayed so waiting for didFinishNavigation is
3550         not sufficient to guarantee we have received all the messages. Wait for them.
3551
3552 2019-01-24  Chris Dumez  <cdumez@apple.com>
3553
3554         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
3555         https://bugs.webkit.org/show_bug.cgi?id=193761
3556         <rdar://problem/47456405>
3557
3558         Reviewed by Alex Christensen.
3559
3560         Add API test coverage.
3561
3562         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3563
3564 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
3565
3566         webkitpy: Missing PID in crashlog name should not be fatal
3567         https://bugs.webkit.org/show_bug.cgi?id=193771
3568
3569         If we can't determine the PID of a crashlog, just ignore the crashlog instead
3570         of raising an exception.
3571
3572         Reviewed by Lucas Forschler.
3573
3574         * Scripts/webkitpy/port/darwin.py:
3575         (DarwinPort._merge_crash_logs):
3576
3577 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
3578
3579         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
3580         https://bugs.webkit.org/show_bug.cgi?id=193746
3581
3582         Reviewed by Youenn Fablet.
3583
3584         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
3585         so we'd best just not call it.
3586
3587         * Scripts/webkitpy/w3c/test_exporter.py:
3588         (WebPlatformTestExporter.create_branch_with_patch):
3589
3590 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
3591
3592         Move FileSystem to WTF
3593         https://bugs.webkit.org/show_bug.cgi?id=193602
3594
3595         Reviewed by Yusuke Suzuki.
3596
3597         * DumpRenderTree/win/DumpRenderTree.cpp:
3598         * TestWebKitAPI/CMakeLists.txt:
3599         * TestWebKitAPI/PlatformGTK.cmake:
3600         * TestWebKitAPI/PlatformJSCOnly.cmake:
3601         * TestWebKitAPI/PlatformPlayStation.cmake:
3602         * TestWebKitAPI/PlatformWPE.cmake:
3603         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3604         * TestWebKitAPI/Tests/WTF/FileSystem.cpp: Renamed from Tools/TestWebKitAPI/Tests/WebCore/FileSystem.cpp.
3605         * TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
3606         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
3607         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp:
3608         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
3609         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
3610         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
3611         * TestWebKitAPI/Tests/WebKitCocoa/DownloadProgress.mm:
3612         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
3613
3614 2019-01-24  Philippe Normand  <pnormand@igalia.com>
3615
3616         [WPE] Remove hard dependency on subprocess32 for the API tests
3617
3618         Rubber-stamped by Carlos Garcia Campos.
3619
3620         * glib/api_test_runner.py:
3621         (TestRunner._run_test_qt): Lazily import subprocess32 and check
3622         its presence only when running WPEQt tests.
3623
3624 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3625
3626         [GLIB] Expose JavaScriptCore options in GLib public API
3627         https://bugs.webkit.org/show_bug.cgi?id=188742
3628
3629         Reviewed by Michael Catanzaro.
3630
3631         Add a test for the new API.
3632
3633         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
3634         (testsJSCOptions):
3635         (main):
3636
3637 2019-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
3638
3639         [GTK][WPE] Support JPEG 2000 images
3640         https://bugs.webkit.org/show_bug.cgi?id=186272
3641
3642         Reviewed by Žan Doberšek.
3643
3644         Add OpenJPEG to jhbuild since 2.2.0 version is required and it's not available in debian stable.
3645
3646         * gtk/jhbuild.modules:
3647         * wpe/jhbuild.modules:
3648
3649 2019-01-23  David Kilzer  <ddkilzer@apple.com>
3650
3651         check-webkit-style should warn when using soft-linking macros in a header
3652         <https://webkit.org/b/193750>
3653
3654         Reviewed by Darin Adler.
3655
3656         * Scripts/webkitpy/style/checkers/cpp.py:
3657         (check_language): Add softlink/header check by refactoring the
3658         softlink/framework check.
3659         (CppChecker): Enable softlink/header check by default.
3660         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3661         (CppStyleTest.test_softlink_framework): Rename from
3662         CppStyleTest.test_softlink() and change test framework name in
3663         case AVFoundation gets its own AVFoundationSoftLink.{h,mm}
3664         files. Set file_name for macros that only appear in headers.
3665         (CppStyleTest.test_softlink_header): Add tests for using
3666         soft-link macros in headers.
3667
3668 2019-01-23  Chris Dumez  <cdumez@apple.com>
3669
3670         Deprecate API to limit the maximum number of WebProcesses
3671         https://bugs.webkit.org/show_bug.cgi?id=193725
3672         <rdar://problem/47464879>
3673
3674         Reviewed by Geoff Garen.
3675
3676         Update existing API tests to stop using deprecated API.
3677
3678         * MiniBrowser/mac/AppDelegate.m:
3679         (defaultConfiguration):
3680         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3681         (TestWebKitAPI::TEST):
3682         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
3683         (TestWebKitAPI::TEST):
3684         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3685         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
3686         (TEST):
3687         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
3688         (TEST):
3689
3690 2019-01-23  Aakash Jain  <aakash_jain@apple.com>
3691
3692         [ews-app] Rename ews model buildermappings to buildermapping
3693         https://bugs.webkit.org/show_bug.cgi?id=193729
3694
3695         Reviewed by Lucas Forschler.
3696
3697         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Renamed from Tools/BuildSlaveSupport/ews-app/ews/models/buildermappings.py.
3698         (BuilderMapping): Renamed BuildMappings to BuilderMapping.
3699         * BuildSlaveSupport/e