Temporary workaround for iOS EWS failing after the fix for bug 159539.
[WebKit-https.git] / Tools / ChangeLog
1 2016-07-19  Alexey Proskuryakov  <ap@apple.com>
2
3         Temporary workaround for iOS EWS failing after the fix for bug 159539.
4         To be deleted once the root cause is found and addressed.
5
6         * EWSTools/start-queue-mac.sh:
7
8 2016-07-19  Frederic Wang  <fwang@igalia.com>
9
10         [win] Fixup the register name for STIX Math and Latin Modern Math
11
12         Unreviewed follow-up of r203406
13
14         * Scripts/webkitdirs.pm:
15         (checkInstalledTools):
16
17 2016-07-19  Frederic Wang  <fwang@igalia.com>
18
19         [win] Update the list of MathML fonts
20         https://bugs.webkit.org/show_bug.cgi?id=156838
21
22         The set of recommended math fonts is now described at
23         https://trac.webkit.org/wiki/MathML/Fonts
24         We update the Perl script to use the latest list of fonts.
25
26         Reviewed by Brent Fulgham.
27
28         * Scripts/webkitdirs.pm:
29         (checkInstalledTools):
30
31 2016-07-19  Per Arne Vollan  <pvollan@apple.com>
32
33         [Win] The test fast/scrolling/overflow-scroll-past-max.html is timing out.
34         https://bugs.webkit.org/show_bug.cgi?id=159342
35
36         Reviewed by Darin Adler.
37
38         Implement required functions in event sender.
39
40         * DumpRenderTree/PlatformWin.cmake:
41         * DumpRenderTree/win/EventSender.cpp:
42         (monitorWheelEvents): Added.
43         (callAfterScrollingCompletes): Added.
44
45 2016-07-19  Youenn Fablet  <youenn@apple.com>
46
47         Add new aliases to http test server
48         https://bugs.webkit.org/show_bug.cgi?id=159878
49
50         Reviewed by Darin Adler.
51
52         Adding testharness.css, testharness.js and testharnessreport.js new aliases to http test servers.
53         Adding explicitly these links to perl script.
54         Extracting default alias in an aliases.json file.
55         Reading that file from python scripts to initialize aliases from that file.
56
57         Python script changes covered by unit tests and changed layout test.
58
59         * Scripts/webkitperl/httpd.pm:
60         (getDefaultConfigForTestDirectory): Adding 3 new aliases
61         * Scripts/webkitpy/layout_tests/servers/aliases.json: Added.
62         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
63         (LayoutTestApacheHttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
64         Adding -c directives for each alias.
65         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
66         (TestLayoutTestApacheHttpd.test_start_cmd): Adding aliases.json mock-up file.
67         * Scripts/webkitpy/layout_tests/servers/http_server.py:
68         (Lighttpd.__init__): Setting upper class tests_dir member if needed and according constructor parameter.
69         Adding alias directive for each alias.
70         (Lighttpd._prepare_config):
71         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
72         (HttpServerBase.__init__): Adding tests_dir member with a default value being layout tests directory.
73         (HttpServerBase.aliases): Computing of alias from the json file, paths to the real files being relative to
74         layout tests directory.
75         * Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
76         (TestHttpServer.test_start_cmd): Adding aliases.json mock-up file and updating test expectation.
77         (TestHttpServer.test_win32_start_and_stop): Adding aliases.json mock-up file.
78
79 2016-07-18  Aakash Jain  <aakash_jain@apple.com>
80
81         EWS console logs doesn't go to log file
82         https://bugs.webkit.org/show_bug.cgi?id=159539
83         <rdar://problem/24464570>
84
85         Reviewed by David Kilzer.
86
87         * Scripts/webkitpy/common/system/logutils.py:
88         (configure_logger_to_log_to_file): Added method to configure the logger to log to file.
89         (FileSystemHandler): Added class which uses logging.FileHandler as base class and supports writing
90         to filesystem. It also supports passing MockFilesystem.
91         (FileSystemHandler.__init__): Initialize the class and calls base class __init__.
92         (FileSystemHandler._open): Overrides the base class _open method to use filesystem object.
93         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
94         (AbstractEarlyWarningSystemTest.test_failing_tests_message): Added MockHost() parameter.
95         (_test_ews): Same.
96         * Scripts/webkitpy/tool/commands/queues.py:
97         (AbstractQueue.begin_work_queue): Configure the logger to log to file.
98         (AbstractQueue._log_directory): Using filesystem object instead of os.
99         (AbstractQueue.queue_log_path): Same.
100         (AbstractQueue.__init__): Passed host parameter.
101         (PatchProcessingQueue.__init__): Same.
102         (CommitQueue.__init__): Same.
103         (AbstractReviewQueue.__init__): Same.
104         (StyleQueue.__init__): Same.
105         * Scripts/webkitpy/tool/commands/queues_unittest.py:
106         (TestCommitQueue): Passed MockHost() as host.
107         (TestCommitQueue.__init__): Same.
108         (TestQueue.__init__): Same.
109         (TestReviewQueue.__init__): Same.
110         (TestFeederQueue.__init__): Same.
111         (AbstractPatchQueueTest.test_next_patch): Same.
112         (PatchProcessingQueueTest.test_upload_results_archive_for_patch): Same.
113         (test_commit_queue_failure): Same.
114         (MockCommitQueueTask.results_from_patch_test_run): Same.
115         (test_rollout_lands): Same.
116         (test_non_valid_patch): Same.
117         (test_auto_retry): Same.
118         (test_style_queue_with_watch_list_exception): Same.
119
120 2016-07-02  Filip Pizlo  <fpizlo@apple.com>
121
122         WTF::Lock should be fair eventually
123         https://bugs.webkit.org/show_bug.cgi?id=159384
124
125         Reviewed by Geoffrey Garen.
126
127         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
128
129 2016-07-17  Sam Weinig  <sam@webkit.org>
130
131         [WebKit API] Add SPI to track multiple navigations caused by a single user gesture
132         <rdar://problem/26554137>
133         https://bugs.webkit.org/show_bug.cgi?id=159856
134
135         Reviewed by Dan Bernstein.
136
137         * MiniBrowser/mac/WK2BrowserWindowController.m:
138         (-[WK2BrowserWindowController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
139         Add basic window.open implementation.
140
141         (-[WK2BrowserWindowController webView:decidePolicyForNavigationAction:decisionHandler:]):
142         Add basic navigation policy implementation which implements a rule where a user gesture is only allowed
143         to open a single non-web URL, all others are dropped.
144
145         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
146         * TestWebKitAPI/Tests/WebKit2Cocoa/UserInitiatedActionInNavigationAction.mm: Added.
147         * TestWebKitAPI/Tests/WebKit2Cocoa/open-multiple-external-url.html: Added.
148         Add API for the new SPI.
149
150 2016-07-17  Yusuke Suzuki  <utatane.tea@gmail.com>
151
152         [JSC] Enable test262 module tests
153         https://bugs.webkit.org/show_bug.cgi?id=159854
154
155         Reviewed by Saam Barati.
156
157         Use --module-file instead.
158
159         * Scripts/run-jsc-stress-tests:
160
161 2016-07-16  Chris Dumez  <cdumez@apple.com>
162
163         Unreviewed, rolling out r203318.
164
165         Regressed most JS Benchmarks on MacBook Air by ~2% (7% on
166         SunSpider)
167
168         Reverted changeset:
169
170         "[JSC] Change some parameters based on a random search"
171         https://bugs.webkit.org/show_bug.cgi?id=158514
172         http://trac.webkit.org/changeset/203318
173
174 2016-07-16  Chris Dumez  <cdumez@apple.com>
175
176         Add move constructor / assignment operator to ListHashSet
177         https://bugs.webkit.org/show_bug.cgi?id=159837
178
179         Reviewed by Darin Adler.
180
181         Add API tests.
182
183         * TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
184         (TestWebKitAPI::TEST):
185
186 2016-07-15  Benjamin Poulain  <bpoulain@apple.com>
187
188         [JSC] Change some parameters based on a random search
189         https://bugs.webkit.org/show_bug.cgi?id=158514
190
191         Reviewed by Saam Barati.
192
193         * Scripts/run-jsc-stress-tests:
194
195 2016-07-15  Jon Davis  <jond@apple.com>
196
197         Changed the start page URL for WebKit Nightly builds.
198         https://bugs.webkit.org/show_bug.cgi?id=159816
199
200         Reviewed by Timothy Hatcher.
201
202         * WebKitLauncher/start.html:
203
204 2016-07-15  Per Arne Vollan  <pvollan@apple.com>
205
206         Uninitialized variable in DIBPixelData can cause a dangerous memory write
207         https://bugs.webkit.org/show_bug.cgi?id=159414
208
209         Reviewed by Brent Fulgham.
210
211         Add test to check that DIBPixelData::setRGBABitmapAlpha does not cause a crash
212         when the HDC parameter is invalid.
213
214         * TestWebKitAPI/PlatformWin.cmake:
215         * TestWebKitAPI/Tests/WebCore/win/DIBPixelData.cpp: Added.
216         (TestWebKitAPI::TEST):
217
218 2016-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
219
220         [GTK] Add basic tabs support to MiniBrowser
221         https://bugs.webkit.org/show_bug.cgi?id=159803
222
223         Reviewed by Sergio Villar Senin.
224
225         It's quite common to have issues with web views loaded in secondary tabs, and we need to use an external browser
226         like epiphany to debug those issues. It would be a lot easier to work on those bugs if we could use the MiniBrowser.
227
228         * MiniBrowser/gtk/BrowserTab.c: Added.
229         (titleChanged):
230         (isLoadingChanged):
231         (decidePolicy):
232         (removeChildIfInfoBar):
233         (loadChanged):
234         (createInfoBarQuestionMessage):
235         (tlsErrorsDialogResponse):
236         (loadFailedWithTLSerrors):
237         (permissionRequestDialogResponse):
238         (decidePermissionRequest):
239         (colorChooserRGBAChanged):
240         (popoverColorClosed):
241         (colorChooserRequestFinished):
242         (runColorChooserCallback):
243         (inspectorOpenedInWindow):
244         (inspectorClosed):
245         (browserTabSetProperty):
246         (browserTabFinalize):
247         (browser_tab_init):
248         (browserTabConstructed):
249         (browser_tab_class_init):
250         (getInternalURI):
251         (browser_tab_new):
252         (browser_tab_get_web_view):
253         (browser_tab_load_uri):
254         (browser_tab_get_title_widget):
255         (browser_tab_set_status_text):
256         (browser_tab_toggle_inspector):
257         (browser_tab_start_search):
258         (browser_tab_stop_search):
259         (browser_tab_add_accelerators):
260         (fullScreenMessageTimeoutCallback):
261         (browser_tab_enter_fullscreen):
262         (browser_tab_leave_fullscreen):
263         * MiniBrowser/gtk/BrowserTab.h: Added.
264         * MiniBrowser/gtk/BrowserWindow.c:
265         (getExternalURI):
266         (browserWindowSetStatusText):
267         (reloadOrStopCallback):
268         (goBackCallback):
269         (goForwardCallback):
270         (settingsCallback):
271         (webViewURIChanged):
272         (browserWindowHistoryItemActivated):
273         (browserWindowUpdateNavigationActions):
274         (webViewCreate):
275         (webViewEnterFullScreen):
276         (webViewLeaveFullScreen):
277         (webViewDecidePolicy):
278         (browserWindowCanZoomIn):
279         (browserWindowCanZoomOut):
280         (browserWindowZoomIn):
281         (browserWindowZoomOut):
282         (scrollEventCallback):
283         (faviconChanged):
284         (webViewIsLoadingChanged):
285         (defaultZoomCallback):
286         (searchCallback):
287         (newTabCallback):
288         (toggleWebInspector):
289         (reloadPage):
290         (reloadPageIgnoringCache):
291         (stopPageLoad):
292         (loadHomePage):
293         (editingCommandCallback):
294         (insertImageCommandCallback):
295         (insertLinkCommandCallback):
296         (browserWindowSetupEditorToolbar):
297         (browserWindowSwitchTab):
298         (browserWindowTabAddedOrRemoved):
299         (browser_window_init):
300         (browserWindowConstructed):
301         (browserWindowSaveSession):
302         (browserWindowDeleteEvent):
303         (browser_window_new):
304         (browser_window_append_view):
305         (browser_window_load_uri):
306         (browser_window_load_session):
307         (browser_window_set_background_color):
308         (resetStatusText): Deleted.
309         (activateUriEntryCallback): Deleted.
310         (webViewTitleChanged): Deleted.
311         (resetEntryProgress): Deleted.
312         (browserWindowCreateBackForwardMenu): Deleted.
313         (webViewReadyToShow): Deleted.
314         (webViewLoadFailed): Deleted.
315         (webViewMouseTargetChanged): Deleted.
316         (browserWindowUpdateZoomActions): Deleted.
317         (webViewZoomLevelChanged): Deleted.
318         (updateUriEntryIcon): Deleted.
319         (zoomInCallback): Deleted.
320         (zoomOutCallback): Deleted.
321         (toggleFullScreen): Deleted.
322         (browserWindowEditingCommandToggleButtonSetActive): Deleted.
323         (browserWindowFinalize): Deleted.
324         (browser_window_class_init): Deleted.
325         * MiniBrowser/gtk/BrowserWindow.h:
326         * MiniBrowser/gtk/CMakeLists.txt:
327         * MiniBrowser/gtk/main.c:
328         (createBrowserTab):
329         (aboutURISchemeRequestCallback):
330         (main):
331         (parseBackgroundColor): Deleted.
332
333 2016-07-14  Alex Christensen  <achristensen@webkit.org>
334
335         Allow RefPtrs of const RefCounted types
336         https://bugs.webkit.org/show_bug.cgi?id=158269
337
338         Reviewed by Anders Carlsson.
339
340         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
341         (TestWebKitAPI::TEST):
342         (TestWebKitAPI::ConstRefCounted::create):
343         (TestWebKitAPI::returnConstRefCountedRef):
344         (TestWebKitAPI::returnRefCountedRef):
345
346 2016-07-13  Carlos Garcia Campos  <cgarcia@igalia.com>
347
348         Test WTF.StringViewIterators is crashing since r203119
349         https://bugs.webkit.org/show_bug.cgi?id=159710
350
351         Reviewed by Darin Adler.
352
353         There are two problems in the test case added in r203119. First is that it's testing
354         StringView::CodeUnits::Iterator instead of StringView::CodePoints::Iterator, and second is that
355         StringView::codePoints() returns a temporary, so the iterator created from the temporary ends up pointing to a
356         const reference to the string view member of the deleted CodePoints object.
357
358         * TestWebKitAPI/Tests/WTF/StringView.cpp:
359         (TestWebKitAPI::TEST):
360
361 2016-07-13  Daniel Bates  <dabates@apple.com>
362
363         [iOS] Copy WebKitTestRunnerInjectedBundle.bundle into PlugIns subdirectory and code sign it
364         https://bugs.webkit.org/show_bug.cgi?id=159738
365         <rdar://problem/27304649>
366
367         Reviewed by Dan Bernstein.
368
369         The bundle WebKitTestRunnerInjectedBundle.bundle contains executable code and should be
370         code signed if applicable. We should also copy this bundle into the PlugIns subdirectory
371         of the WebKitTestRunnerApp.app bundle instead of the top-level bundle directory as the
372         PlugIns subdirectory is the directory where loadable bundles of an app are expected to live.
373
374         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
375         * WebKitTestRunner/ios/TestControllerIOS.mm:
376         (WTR::TestController::initializeInjectedBundlePath): Modified code to look for the
377         bundle WebKitTestRunnerInjectedBundle.bundle in the plugin directory of the main bundle.
378
379 2016-07-13  Beth Dakin  <bdakin@apple.com>
380
381         Attempted build fix.
382
383         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
384
385 2016-07-12  Ryosuke Niwa  <rniwa@webkit.org>
386
387         REGRESSION(r202953): Clicking on input[type=file] doesn't open a file picker
388         https://bugs.webkit.org/show_bug.cgi?id=159686
389
390         Reviewed by Chris Dumez.
391
392         Added a code to print "OPEN FILE PANEL" in the text when runOpenPanel is called in the UI delegate.
393
394         * WebKitTestRunner/TestController.cpp:
395         (WTR::runOpenPanel):
396         (WTR::TestController::createOtherPage):
397         (WTR::TestController::createWebViewWithOptions):
398
399 2016-07-13  Beth Dakin  <bdakin@apple.com>
400
401         Add more candidate tests
402         https://bugs.webkit.org/show_bug.cgi?id=159730
403
404         Reviewed by Tim Horton.
405
406         This patch re-names ViewWithEditableAreaLeak.mm to CandidateTests.mm and adds 
407         two new tests to that file.
408         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
409         * TestWebKitAPI/Tests/WebKit2Cocoa/focus-inputs.html: Added.
410         * TestWebKitAPI/Tests/mac/CandidateTests.mm: Copied from TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm.
411         (-[CandidateRequestFrameLoadDelegate webView:didFinishLoadForFrame:]):
412         (TestWebKitAPI::TEST):
413         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Removed.
414
415 2016-07-13  Joanmarie Diggs  <jdiggs@igalia.com>
416
417         AX: [ATK] spinbutton-crash.html fails
418         https://bugs.webkit.org/show_bug.cgi?id=159723
419
420         Reviewed by Chris Fleizach.
421
422         Implement support for AXDecrementButton and AXIncrementButton in
423         ATK's AccessibilityUIElement::uiElementAttributeValue().
424
425         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
426         (WTR::AccessibilityUIElement::uiElementAttributeValue):
427
428 2016-07-13  Carlos Alberto Lopez Perez  <clopez@igalia.com>
429
430         [EFL] [GTK] Enable back crypto subtle on development builds.
431         https://bugs.webkit.org/show_bug.cgi?id=159260
432
433         Reviewed by Carlos Garcia Campos.
434
435         * Scripts/webkitperl/FeatureList.pm:
436
437 2016-07-12  Mark Lam  <mark.lam@apple.com>
438
439         We should use different stack limits for stack checks from JS and host code.
440         https://bugs.webkit.org/show_bug.cgi?id=159442
441         <rdar://problem/26889188>
442
443         Reviewed by Geoffrey Garen.
444
445         In http://trac.webkit.org/r203067, we limited the amount of stack that tests will
446         run with to keep stack overflow tests sane.  Turns out, we also need to teach the
447         LayoutTestRelay to pass env vars over to the iOS simulator.  This is needed in
448         order to keep the js/regress-139548.html test happy with this patch.
449
450         Also fixed up run_webkit_tests.py to explicitly pass an int size value for the
451         JSC_maxPerThreadStackUsage option.  Otherwise, it will pass a float value.
452
453         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
454         (-[LTRelayController _environmentVariables]):
455         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
456         (main):
457
458 2016-07-12  Filip Pizlo  <fpizlo@apple.com>
459
460         platformUserPreferredLanguages on Mac should not try to put the region into the language
461         https://bugs.webkit.org/show_bug.cgi?id=159693
462
463         Rubber stamped by Alexey Proskuryakov.
464         
465         Revert the test change in r200105.
466
467         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
468         (TestWebKitAPI::languageForSystemLanguage):
469
470 2016-07-12  Chris Dumez  <cdumez@apple.com>
471
472         [WK2] Protect against bad database data in LocalStorageDatabase::importItems()
473         https://bugs.webkit.org/show_bug.cgi?id=159663
474         <rdar://problem/18995873>
475
476         Reviewed by Benjamin Poulain.
477
478         Add API test coverage.
479
480         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
481         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.html: Added.
482         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage: Added.
483         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.localstorage-shm: Added.
484         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageNullEntries.mm: Added.
485         (-[LocalStorageNullEntriesMessageHandler userContentController:didReceiveScriptMessage:]):
486         (TEST):
487
488 2016-07-12  Myles C. Maxfield  <mmaxfield@apple.com>
489
490         Relax ordering requirements on StringView::CodePoints iterator
491         https://bugs.webkit.org/show_bug.cgi?id=159609
492
493         Reviewed by Darin Adler.
494
495         * TestWebKitAPI/Tests/WTF/StringView.cpp:
496         (TestWebKitAPI::TEST):
497
498 2016-07-12  Youenn Fablet  <youenn@apple.com>
499
500         Fixing Tools/Scripts/run-builtins-generator-tests after https://trac.webkit.org/changeset/202975
501         https://bugs.webkit.org/show_bug.cgi?id=159564
502
503         Reviewed by Brian Burg.
504
505         * Scripts/webkitpy/codegen/main.py:
506         (BuiltinsGeneratorTests.generate_from_js_builtins): Changing --with-wrapper-files option to --wrappers.
507
508 2016-07-12  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
509
510         Remove ENABLE_CSS3_TEXT_LINE_BREAK flag
511         https://bugs.webkit.org/show_bug.cgi?id=159671
512
513         Reviewed by Csaba Osztrogonác.
514
515         ENABLE_CSS3_TEXT_LINE_BREAK feature was implemented without guards.
516         https://bugs.webkit.org/show_bug.cgi?id=89235
517
518         So this guard can be removed in build scripts.
519
520         * Scripts/webkitperl/FeatureList.pm:
521         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
522
523 2016-07-11  Jason Marcell  <jmarcell@apple.com>
524
525         SVN.create_patch should find svn-create-patch relative to the WebKit root.
526         https://bugs.webkit.org/show_bug.cgi?id=159652
527
528         Reviewed by Daniel Bates.
529
530         * Scripts/webkitpy/common/checkout/scm/svn.py:
531         (SVN.create_patch): Use WebKitFinder to find the WebKit checkout so that we can find svn-create-patch relative to it.
532
533 2016-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
534
535         Implement grapheme cluster iterator on StringView
536         https://bugs.webkit.org/show_bug.cgi?id=159598
537
538         Reviewed by Anders Carlsson.
539
540         This is in preparation for honoring the second argument to FontFaceSet.load().
541
542         * TestWebKitAPI/Tests/WTF/StringView.cpp:
543         (TestWebKitAPI::compareLoopIterations):
544         (TestWebKitAPI::TEST):
545
546 2016-07-11  Nan Wang  <n_wang@apple.com>
547
548         AX: WKWebView should have API to prevent pinch-to-zoom always being allowed
549         https://bugs.webkit.org/show_bug.cgi?id=158364
550
551         Reviewed by Anders Carlsson.
552
553         Added a function in TestRunner so that we can toggle the ignoring viewport
554         scale limits setting. Also added a test option for that in order to change the 
555         configuration of the webview in test.
556
557         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
558         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
559         (WTR::TestRunner::setNavigationGesturesEnabled):
560         (WTR::TestRunner::setIgnoresViewportScaleLimits):
561         (WTR::nextUIScriptCallbackID):
562         * WebKitTestRunner/InjectedBundle/TestRunner.h:
563         (WTR::TestRunner::shouldDecideNavigationPolicyAfterDelay):
564         * WebKitTestRunner/TestController.cpp:
565         (WTR::TestController::resetStateToConsistentValues):
566         (WTR::updateTestOptionsFromTestHeader):
567         (WTR::TestController::setNavigationGesturesEnabled):
568         (WTR::TestController::setIgnoresViewportScaleLimits):
569         (WTR::TestController::platformWillRunTest):
570         * WebKitTestRunner/TestController.h:
571         (WTR::TestController::setShouldDecideNavigationPolicyAfterDelay):
572         * WebKitTestRunner/TestInvocation.cpp:
573         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
574         * WebKitTestRunner/TestOptions.h:
575         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
576         (WTR::TestController::platformCreateWebView):
577
578 2016-07-11  Konstantin Tokarev  <annulen@yandex.ru>
579
580         [GTK] install-dependencies should not install packages built by jhbuild.
581         https://bugs.webkit.org/show_bug.cgi?id=159628
582
583         Reviewed by Michael Catanzaro.
584
585         * gtk/install-dependencies:
586         Don't install icu, harfbuzz, orc, llvm, freetype, fontconfig.
587
588 2016-07-11  Olivier Blin  <olivier.blin@softathome.com>
589
590         System proxy settings not used when building deps with jhbuild
591         https://bugs.webkit.org/show_bug.cgi?id=159567
592
593         Reviewed by Michael Catanzaro.
594
595         This adds the gsettings-desktop-schemas-devel build dep to enable
596         the libgiognomeproxy.so gio module in glib-networking, which uses
597         GSettings on org.gnome.system.proxy.
598         This is needed to query system proxy settings for Gnome desktops.
599
600         dconf can be manually added to jhbuild to build the
601         libdconfsettings.so gio module for GSettings, so that
602         libgiognomeproxy.so can access system settings.
603           https://trac.webkit.org/wiki/WebKitGTK/StartHacking#Workingbehindaproxy
604
605         As an alternative to dconf settings, this commit also adds the
606         libproxy-devel build dep to enable the libgiolibproxy.so module in
607         glib-networking (suggested by Fujii Hironori).
608
609         It is useful to read proxy settings from environment variables.
610         From a Gnome desktop, one may unset the GNOME_DESKTOP_SESSION_ID
611         environment variable to force using the envvar module in libproxy.
612
613         * gtk/install-dependencies:
614
615 2016-07-11  Mark Lam  <mark.lam@apple.com>
616
617         Change run-webkit-tests.py and run-jsc-stress-tests to use a smaller JS stack size for testing.
618         https://bugs.webkit.org/show_bug.cgi?id=159524
619
620         Reviewed by Michael Saboff.
621
622         Forced tests to run with only a 1.5M JS stack size instead of the default 4M.
623         Also fixed up some tests to behave better to work with this new limit.  This
624         should make stack overflow tests complete sooner.
625
626         * Scripts/run-jsc-stress-tests:
627         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
628         (main):
629
630 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
631
632         [GTK] Whitespace fixes in install-dependencies script
633
634         Unreviewed.
635
636         * gtk/install-dependencies:
637
638 2016-07-11  Michael Catanzaro  <mcatanzaro@igalia.com>
639
640         [GTK] Install missing Fedora dependencies
641
642         Unreviewed.
643
644         * gtk/install-dependencies:
645
646 2016-07-09  Dan Bernstein  <mitz@apple.com>
647
648         Give git-add-reviewer an option to say “Rubber-stamped by” in non-interactive mode
649         https://bugs.webkit.org/show_bug.cgi?id=159600
650
651         Reviewed by Daniel Bates.
652
653         * Scripts/git-add-reviewer:
654         Added the -s|--rubber-stamp option.
655         (nonInteractive): Set the rubberstamp key in the item passed to addReviewer() based on the
656           new option.
657
658 2016-07-08  Andy Estes  <aestes@apple.com>
659
660         [Content Filtering] Load blocked pages more like other error pages are loaded
661         https://bugs.webkit.org/show_bug.cgi?id=159485
662         <rdar://problem/26014076>
663
664         Reviewed by Brady Eidson.
665
666         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
667         to a content filtering provisional navigation failure is ignored in preference of
668         ContentFilter's own error page.
669
670         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
671         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
672         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
673         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
674         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
675         (loadAlternateTest):
676         (TEST):
677         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
678         (-[MockContentFilterEnabler initWithCoder:]):
679         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
680         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
681         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
682         (TestWebKitAPI::loadAlternateTest):
683         (TestWebKitAPI::TEST):
684
685 2016-07-08  Commit Queue  <commit-queue@webkit.org>
686
687         Unreviewed, rolling out r202944.
688         https://bugs.webkit.org/show_bug.cgi?id=159570
689
690         caused some tests to crash under GuardMalloc (Requested by
691         estes on #webkit).
692
693         Reverted changeset:
694
695         "[Content Filtering] Load blocked pages more like other error
696         pages are loaded"
697         https://bugs.webkit.org/show_bug.cgi?id=159485
698         http://trac.webkit.org/changeset/202944
699
700 2016-07-08  Martin Robinson  <mrobinson@igalia.com>
701
702         Remove mrobinson from the MathML watchlist
703         https://bugs.webkit.org/show_bug.cgi?id=159559
704
705         Reviewed by Philippe Normand.
706
707         * Scripts/webkitpy/common/config/watchlist: Remove my email from the watchlist.
708
709 2016-07-08  Brady Eidson  <beidson@apple.com>
710
711         Clearing LocalStorage doesn't also delete -wal and -shm files.
712         <rdar://problem/27206772> and https://bugs.webkit.org/show_bug.cgi?id=159566
713
714         Reviewed by Brent Fulgham.
715         Also helpfully picked over by Andy "Never Forgets" Estes.
716
717         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
718         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.html: Added.
719         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm: Added.
720
721 2016-07-08  Konstantin Tokarev  <annulen@yandex.ru>
722
723         Removed Qt leftovers from Tools.
724         https://bugs.webkit.org/show_bug.cgi?id=159557
725
726         Reviewed by Csaba Osztrogonác.
727
728         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
729         Removed 'qt' platform config.
730         * Scripts/webkitpy/common/net/bugzilla/bug.py:
731         Deleted non-functional e-mail address.
732
733 2016-07-08  Commit Queue  <commit-queue@webkit.org>
734
735         Unreviewed, rolling out r202967.
736         https://bugs.webkit.org/show_bug.cgi?id=159556
737
738         This patch caused crashes in https tests on Windows (Requested
739         by perarne on #webkit).
740
741         Reverted changeset:
742
743         "[Win] The test http/tests/security/contentSecurityPolicy
744         /upgrade-insecure-requests/basic-upgrade.https.html is
745         failing."
746         https://bugs.webkit.org/show_bug.cgi?id=159510
747         http://trac.webkit.org/changeset/202967
748
749 2016-07-08  Youenn Fablet  <youenn@apple.com>
750
751         Generate WebCore builtin wrapper files
752         https://bugs.webkit.org/show_bug.cgi?id=159461
753
754         Reviewed by Brian Burg.
755
756         * Scripts/webkitpy/codegen/main.py:
757         (BuiltinsGeneratorTests.generate_from_js_builtins): Adding generate_wrapper option.
758         (BuiltinsGeneratorTests.run_tests): Using this option in WebCore test cases.
759
760 2016-07-08  Hunseop Jeong  <hs85.jeong@samsung.com>
761
762         [EFL] Fix build when media-stream is enabled.
763         https://bugs.webkit.org/show_bug.cgi?id=159206
764
765         Bump up the openwebrtc to find the correct package.
766
767         Reviewed by Gyuyoung Kim.
768
769         * efl/jhbuild.modules:
770         * efl/patches/openwebrtc-clang-warning-fix.patch: Removed.
771
772 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
773
774         [Win] The test http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/basic-upgrade.https.html is failing.
775         https://bugs.webkit.org/show_bug.cgi?id=159510
776
777         Reviewed by Brent Fulgham.
778
779         Allow any https certificate when running tests.
780
781         * DumpRenderTree/win/DumpRenderTree.cpp:
782         (runTest):
783
784 2016-07-07  Beth Dakin  <bdakin@apple.com>
785
786         API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
787         https://bugs.webkit.org/show_bug.cgi?id=159532
788         -and corresponding-
789         rdar://problem/27177179
790
791         Reviewed by Tim Horton.
792
793         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
794         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
795
796 2016-07-07  Andy Estes  <aestes@apple.com>
797
798         [Content Filtering] Load blocked pages more like other error pages are loaded
799         https://bugs.webkit.org/show_bug.cgi?id=159485
800         <rdar://problem/26014076>
801
802         Reviewed by Brady Eidson.
803
804         Added API tests for WebView and WKWebView to verify that alternate HTML loaded in response
805         to a content filtering provisional navigation failure is ignored in preference of
806         ContentFilter's own error page.
807
808         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
809         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
810         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFiltering.mm:
811         (-[LoadAlternateNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
812         (-[LoadAlternateNavigationDelegate webView:didFinishNavigation:]):
813         (loadAlternateTest):
814         (TEST):
815         * TestWebKitAPI/Tests/WebKit2Cocoa/ContentFilteringPlugIn.mm:
816         (-[MockContentFilterEnabler initWithCoder:]):
817         * TestWebKitAPI/Tests/mac/ContentFiltering.mm: Added.
818         (-[LoadAlternateFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
819         (-[LoadAlternateFrameLoadDelegate webView:didFinishLoadForFrame:]):
820         (TestWebKitAPI::loadAlternateTest):
821         (TestWebKitAPI::TEST):
822
823 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
824
825         Unreviewed: add myself to the reviewers list.
826
827         * Scripts/webkitpy/common/config/contributors.json:
828
829 2016-07-07  Per Arne Vollan  <pvollan@apple.com>
830
831         [Win] The test http/tests/loading/main-resource-delegates-on-back-navigation.html is failing.
832         https://bugs.webkit.org/show_bug.cgi?id=159509
833
834         Reviewed by Alex Christensen.
835
836         We should always insert the url in the url map when identifierForInitialRequest
837         is called. Otherwise we can end up with identifiers not having an entry in the
838         url map when urls are written to the test output file. 
839
840         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
841         (ResourceLoadDelegate::identifierForInitialRequest):
842
843 2016-07-06  Tim Horton  <timothy_horton@apple.com>
844
845         Email from June 1st containing text 'Today @ 7:10PM' is linkified, but shouldn't be
846         https://bugs.webkit.org/show_bug.cgi?id=159498
847         <rdar://problem/26719903>
848
849         Reviewed by Sam Weinig.
850
851         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
852         * TestWebKitAPI/Tests/WebKit2Cocoa/DataDetection.mm: Added.
853         (-[DataDetectionNavigationDelegate webView:didFinishNavigation:]):
854         (-[DataDetectionUIDelegate _dataDetectionContextForWebView:]):
855         (expectLinkCount):
856         (TEST):
857         Add a test ensuring that ReferenceDate in the DataDetectors context is respected
858         when deciding what to linkify.
859
860 2016-07-06  Alexey Proskuryakov  <ap@apple.com>
861
862         Build fix - work around rdar://problem/27196668.
863
864         * LayoutTestRelay/Configurations/Base.xcconfig:
865
866 2016-07-05  Per Arne Vollan  <pvollan@apple.com>
867
868         Enhance Windows DRT implementation to support platform scroll wheel events.
869         https://bugs.webkit.org/show_bug.cgi?id=36002
870
871         Reviewed by Brent Fulgham.
872
873         Implement function continuousMouseScrollBy in Windows event sender.
874
875         * DumpRenderTree/win/EventSender.cpp:
876         (mouseScrollBy):
877         (continuousMouseScrollBy):
878
879 2016-07-05  Myles C. Maxfield  <mmaxfield@apple.com>
880
881         [Sierra] Rebaseline tests to use un-mocked system font metrics
882         https://bugs.webkit.org/show_bug.cgi?id=159311
883         <rdar://problem/24138411>
884
885         Reviewed in person by Alexey Proskuryakov.
886
887         Stop mocking the system font on Sierra.
888
889         * DumpRenderTree/mac/DumpRenderTree.mm:
890         (setDefaultsToConsistentValuesForTesting):
891         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
892         (WTR::InjectedBundle::platformInitialize):
893
894 2016-07-05  Brady Eidson  <beidson@apple.com>
895
896         Database process crashes deleting a corrupt SQLite database file (null deref).
897         https://bugs.webkit.org/show_bug.cgi?id=155506.
898
899         Reviewed by Alex Christensen.
900
901         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
902         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.html: Added.
903         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm: Added.
904         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3: Added.
905         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-shm: Added.
906         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.sqlite3-wal: Added.
907
908 2016-07-05  Alexey Proskuryakov  <ap@apple.com>
909
910         run-webkit-tests should print more complete baseline search paths
911         https://bugs.webkit.org/show_bug.cgi?id=159354
912
913         Reviewed by Daniel Bates.
914
915         run-webkit-tests used to only print directory names in baseline search paths.
916         This was ok in basic usage, but quickly got confusing when using
917         --additional-platform-directory flags.
918
919         * Scripts/webkitpy/layout_tests/views/printing.py:
920         (Printer.print_config):
921         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
922         (Testprinter.test_print_config):
923         (Testprinter.test_print_one_line_summary):
924
925 2016-07-04  Brady Eidson  <beidson@apple.com>
926
927         WebProcesses don't handle DatabaseProcess going away uncleanly..
928         https://bugs.webkit.org/show_bug.cgi?id=159371
929
930         Reviewed by Alex Christensen.
931
932         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
933         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill-1.html: Added.
934         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm: Added.
935         (-[DatabaseProcessKillNavigationDelegate webView:didFinishNavigation:]):
936         (-[DatabaseProcessKillMessageHandler userContentController:didReceiveScriptMessage:]):
937
938 2016-07-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
939
940         [EFL][GTK] Layout Test doesn't run on Ubuntu 16.04
941         https://bugs.webkit.org/show_bug.cgi?id=158141
942
943         Rubber-stamped by Michael Catanzaro.
944
945         Instead of checking for an specific Ubuntu version, query the apt
946         database to see which version of PHP is available.
947
948         * efl/install-dependencies:
949         * gtk/install-dependencies:
950
951 2016-07-04  Fujii Hironori  <Hironori.Fujii@sony.com>
952
953         webkit-patch failure-reason always raises TypeError
954         https://bugs.webkit.org/show_bug.cgi?id=159394
955
956         Reviewed by Benjamin Poulain.
957
958         In r170637 (Bug 133067), the first and second arguments of
959         pluralize were swapped.
960
961         * Scripts/webkitpy/tool/commands/queries.py:
962         (FailureReason._builder_to_explain): Swap the first and second
963         arguments of pluralize.
964
965 2016-07-02  Youenn Fablet  <youennf@gmail.com>
966
967         Make it straightforward to start the Web Platform Tests HTTP server using run-webkit-httpd
968         https://bugs.webkit.org/show_bug.cgi?id=152486
969
970         Reviewed by Daniel Bates.
971
972         Add launch of web-platform-tests server by run-webkit-httpd.
973         Add two options to disable starting httpd and web-platform-tests servers.
974
975         * Scripts/run-webkit-httpd:
976         (parse_args):
977         (main):
978
979 2016-07-01  Myles C. Maxfield  <mmaxfield@apple.com>
980
981         REGRESSION(r189668): Notification tests are flakey
982         https://bugs.webkit.org/show_bug.cgi?id=159375
983         <rdar://problem/22760990>
984
985         Reviewed by Alexey Proskuryakov.
986
987         Notifications are objects which must exist in both the UI Process and the Web Process. Each process
988         identifies a notification object by a unique ID. When the Web Process sends a message regarding a
989         notification to the UI Process, the UI Process's WebNotificationManagerProxy holds a map from
990         (Page ID, Web Process notification ID) -> UI Process notification ID. This works as intended.
991
992         Our tests, however, include an additional method, simulateWebNotificationClick(), which is implemented
993         by WebKitTestRunner in the Web Process via the Injected Bundle. This method involves sending a message
994         to the UI process, to handle the simulated click. However, that RPC didn't perform the same local ->
995         global notification ID mapping, causing the wrong notification to be investigated.
996
997         The solution is for WebNotificationProvider, implemented in WebKitTestRunner in the UI Process, to
998         manually perform this same mapping. Luckily, this object already receives callbacks every time a
999         notification is created or destroyed. However, because this object is implemented outside WebKit,
1000         it isn't privy to the internal Web Process ID used inside WebNotificationmanagerProxy. Therefore,
1001         this patch adds a private testing function which returns this internal ID. Once given this intenal ID,
1002         WebNotificationProvider can properly map between the different IDs.
1003
1004         * WebKitTestRunner/TestController.cpp:
1005         (WTR::TestController::runTestingServerLoop):
1006         (WTR::TestController::simulateWebNotificationClick):
1007         * WebKitTestRunner/WebNotificationProvider.cpp:
1008         (WTR::WebNotificationProvider::showWebNotification):
1009         (WTR::removeGlobalIDFromIDMap):
1010         (WTR::WebNotificationProvider::closeWebNotification):
1011         (WTR::WebNotificationProvider::removeNotificationManager):
1012         (WTR::WebNotificationProvider::simulateWebNotificationClick):
1013         (WTR::WebNotificationProvider::reset):
1014         * WebKitTestRunner/WebNotificationProvider.h:
1015
1016 2016-07-01  Alexey Proskuryakov  <ap@apple.com>
1017
1018         Simplify LayoutTestRelay
1019         https://bugs.webkit.org/show_bug.cgi?id=159353
1020
1021         Reviewed by Daniel Bates.
1022
1023         1. Use UDID to pass the device from webkitpy to LayoutTestRelay, searching for it
1024         by name and runtime makes no sense.
1025         2. Removed code to create devices, webkitpy always does this in advance.
1026         3. Don't create copies of testing apps - we can install the same one into
1027         each simulator, now that we don't run multiple tester processes in a single simulator.
1028         4. Pass information on how to find I/O pipes via environment, not via Info.plist.
1029         5. Removed code that kept testing apps alive in the background.
1030         6. Slightly updated coding style in functions that I touched.
1031
1032         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
1033         Updated for what we acually use at this point.
1034
1035         * LayoutTestRelay/LayoutTestRelay/LTRelayController.h:
1036         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1037         (-[LTRelayController initWithDevice:productDir:appPath:deviceUDID:dumpToolArguments:]):
1038         (-[LTRelayController ipcIdentifier]):
1039         (-[LTRelayController processName]):
1040         (-[LTRelayController didReceiveStdoutData:]):
1041         (-[LTRelayController didCrashWithMessage:]):
1042         (-[LTRelayController installApp]):
1043         (-[LTRelayController _environmentVariables]):
1044         (-[LTRelayController launchApp]):
1045         (-[LTRelayController start]):
1046         (-[LTRelayController initWithDevice:productDir:appPath:identifierSuffix:dumpToolArguments:]): Deleted.
1047         (-[LTRelayController uniqueAppPath]): Deleted.
1048         (-[LTRelayController uniqueAppURL]): Deleted.
1049         (-[LTRelayController uniqueAppIdentifier]): Deleted.
1050         (-[LTRelayController createUniqueApp]): Deleted.
1051         * LayoutTestRelay/LayoutTestRelay/main.m:
1052         (usage):
1053         (getRequiredStringArgument):
1054         (main):
1055         (getTestingSimDevice): Deleted.
1056         * Scripts/webkitpy/port/driver.py:
1057         (IOSSimulatorDriver.cmd_line):
1058         * WebKitTestRunner/ios/TestControllerIOS.mm:
1059         (WTR::TestController::platformInitialize):
1060         * WebKitTestRunner/ios/mainIOS.mm:
1061         (-[WebKitTestRunnerApp applicationDidEnterBackground:]):
1062         * DumpRenderTree/mac/DumpRenderTree.mm:
1063         (dumpRenderTree):
1064         (-[DumpRenderTree applicationDidEnterBackground:]):
1065
1066 2016-07-01  Konstantin Tokarev  <annulen@yandex.ru>
1067
1068         [cmake] Build TestNetscapePlugin only if NPAPI is enabled.
1069         https://bugs.webkit.org/show_bug.cgi?id=159344
1070
1071         Reviewed by Alex Christensen.
1072
1073         * DumpRenderTree/CMakeLists.txt:
1074
1075 2016-07-01  Youenn Fablet  <youennf@gmail.com>
1076
1077         Add a runtime flag for DOM iterators
1078         https://bugs.webkit.org/show_bug.cgi?id=159300
1079
1080         Reviewed by Alex Christensen.
1081
1082         * DumpRenderTree/mac/DumpRenderTree.mm:
1083         (resetWebPreferencesToConsistentValues):
1084         * DumpRenderTree/win/DumpRenderTree.cpp:
1085         (resetWebPreferencesToConsistentValues):
1086         * Scripts/webkitperl/FeatureList.pm:
1087         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1088         (WTR::InjectedBundle::beginTesting):
1089         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1090         (WTR::TestRunner::setDOMIteratorEnabled):
1091         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1092
1093 2016-06-30  Tina Liu  <iting_liu@apple.com>
1094
1095         Add an API test for WKPageRestoreFromSessionStateWithoutNavigation.
1096         https://bugs.webkit.org/show_bug.cgi?id=159326
1097
1098         Reviewed by Brady Eidson.
1099
1100         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1101         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateWithoutNavigation.cpp: Added.
1102         (TestWebKitAPI::didFinishLoadForFrame):
1103         (TestWebKitAPI::didChangeBackForwardListForPage):
1104         (TestWebKitAPI::setPageLoaderClient):
1105         Set the page loader client and register for didFinishLoadForFrame and
1106         didChangeBackForwardList callbacks.
1107         (TestWebKitAPI::createSessionStateData):
1108         Load a webpage ("simple.html") and return the session state for this page.
1109         (TestWebKitAPI::TEST):
1110         Restore the page session state with that of "simple.html" without navigation.
1111         Verify that the committed URL is NULL since there's no navigation involved.
1112         Verify that the current item in the back forward list, which should be what
1113         we restored from the session state, has the expected URL.
1114
1115 2016-06-29  Filip Pizlo  <fpizlo@apple.com>
1116
1117         Generators violate bytecode liveness validation
1118         https://bugs.webkit.org/show_bug.cgi?id=159279
1119
1120         Reviewed by Yusuke Suzuki.
1121         
1122         Add Basic to our test harness.
1123
1124         * Scripts/run-javascriptcore-tests:
1125         (runJSCStressTests):
1126
1127 2016-06-30  Per Arne Vollan  <pvollan@apple.com>
1128
1129         [Win][Debug] Assertion fails in TestWTF.
1130         https://bugs.webkit.org/show_bug.cgi?id=159299
1131
1132         Reviewed by Alex Christensen.
1133
1134         The assert in the & operator in the UniqueRef class fails, because the instance has been moved.
1135         The Windows version of the UNUSED_PARAM macro is getting the address of the parameter, causing
1136         the assertion failure. Since the variable is actually used, there is no need to use the
1137         UNUSED_PARAM macro.
1138
1139         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp:
1140         (TestWebKitAPI::TEST):
1141
1142 2016-06-30  Youenn Fablet  <youennf@gmail.com>
1143
1144         LayoutTests intermittently failing to run due to issues starting Web Platform Test server
1145         https://bugs.webkit.org/show_bug.cgi?id=159166
1146         <rdar://problem/27051759>
1147
1148         Reviewed by Alexey Proskuryakov.
1149
1150         Setting the certificate directory to the copied config.json.
1151
1152         * Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:
1153         (WebPlatformTestServer._copy_webkit_test_files):
1154
1155 2016-06-29  Mark Lam  <mark.lam@apple.com>
1156
1157         Add support for collecting cumulative LLINT stats via a JSC_llintStatsFile option.
1158         https://bugs.webkit.org/show_bug.cgi?id=159274
1159
1160         Reviewed by Keith Miller.
1161
1162         * DumpRenderTree/mac/DumpRenderTree.mm:
1163         (DumpRenderTreeMain):
1164
1165 2016-06-29  Alex Christensen  <achristensen@webkit.org>
1166
1167         WKWebView should ask WKNavigationDelegate about bad ssl certificates
1168         https://bugs.webkit.org/show_bug.cgi?id=159176
1169
1170         Reviewed by Sam Weinig.
1171
1172         * MiniBrowser/mac/WK2BrowserWindowController.m:
1173         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
1174         (-[WK2BrowserWindowController webView:didReceiveAuthenticationChallenge:completionHandler:]):
1175         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
1176
1177 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1178
1179         [GTK] Add missing install dependency after r202619
1180         https://bugs.webkit.org/show_bug.cgi?id=156716
1181
1182         Unreviewed.
1183
1184         * gtk/install-dependencies: Missed to add the GLES headers that are needed for building mesa on Debian.
1185
1186 2016-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1187
1188         [GTK][Wayland] Implement support for running the layout tests under a (virtualized) Wayland environment.
1189         https://bugs.webkit.org/show_bug.cgi?id=156716
1190
1191         Reviewed by Carlos Garcia Campos and Michael Catanzaro.
1192
1193         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Allow to run the layout tests on Wayland by passing --wayland
1194         (parse_args):
1195         * Scripts/webkitpy/port/gtk.py:
1196         (GtkPort.__init__):
1197         (GtkPort._driver_class):
1198         (GtkPort.setup_environ_for_server): Set the softgl renderer (now with EGL support) for the wayland tests.
1199         (GtkPort._search_paths): When running inside the wayland environment, use ${port}-wayland as an additional
1200         platform directory for storing the wayland specific layout test results and expectations for ${port}.
1201         For example, the file LayoutTests/platform/gtk-wayland/TestExpectations will be used as the most specific
1202         test expectations file on the GTK port when running the tests with the --wayland command line switch.
1203         Baseline search path: gtk-wayland -> gtk -> wk2 -> generic.
1204         * Scripts/webkitpy/port/westondriver.py: Run the weston display server inside Xvfb.
1205         (WestonDriver.check_driver):
1206         (WestonDriver.__init__):
1207         (WestonDriver._start):
1208         * Scripts/webkitpy/port/westondriver_unittest.py: Fix unittests for the new Weston inside Xvfb driver.
1209         (WestonXvfbDriverDisplayTest):
1210         (WestonXvfbDriverDisplayTest.__init__):
1211         (WestonXvfbDriverDisplayTest._xvfb_run):
1212         (WestonDriverTest.make_driver):
1213         (WestonDriverTest.test_start):
1214         * gtk/install-dependencies: Add the new dependencies that are required for either building weston,
1215         or to satisfy the pkg-config check of the new added modules in JHBuild.
1216         * gtk/jhbuild.modules: For building weston new enough on Debian Jessie we also need to build wayland
1217         and libinput. Declare a pkg-config entry on all this modules to avoid building them if the ones
1218         provided by the system are already new enough.
1219         Switch the Mesa software rasterizer from a Xlib based GLX renderer to a DRI based EGL/GLX one.
1220         It was the only way to get the software EGL rasterizer working without depending on user drivers.
1221         Due to this the Mesa build now depends on a modern enough libdrm, so we also use JHBuild pkg-config
1222         feature to avoid building libdrm when the one provided by the system is new enough.
1223         * gtk/jhbuildrc:
1224         * gtk/patches/xserver-search-for-DRI-drivers-at-LIBGL_DRIVERS_PATH-environ.patch: Added.
1225         Xorg had no support for searching the DRI drivers on a custom path at runtime.
1226         This patch implements support for that reusing the same variable that we use with Mesa to set the
1227         custom path for the DRI drivers path.
1228
1229 2016-06-29  Alejandro G. Castro  <alex@igalia.com>
1230
1231         [WebRTC][OWR] Bump gst-plugins-openwebrtc jhbuild version to get scream fixes
1232         https://bugs.webkit.org/show_bug.cgi?id=159256
1233
1234         Reviewed by Philippe Normand.
1235
1236         We need the last fixes in the repository to make the scream queue
1237         work with apprtc.
1238
1239         * gtk/jhbuild.modules:
1240
1241 2016-06-28  Commit Queue  <commit-queue@webkit.org>
1242
1243         Unreviewed, rolling out r202580.
1244         https://bugs.webkit.org/show_bug.cgi?id=159245
1245
1246         Caused all WKTR tests to fail on GuardMalloc and Production
1247         only for unknown reasons, investigating offline. (Requested by
1248         brrian on #webkit).
1249
1250         Reverted changeset:
1251
1252         "RunLoop::Timer should use constructor templates instead of
1253         class templates"
1254         https://bugs.webkit.org/show_bug.cgi?id=159153
1255         http://trac.webkit.org/changeset/202580
1256
1257 2016-06-28  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1258
1259         Use a regex to check if a test step is for JavaScriptCore
1260         https://bugs.webkit.org/show_bug.cgi?id=159224
1261
1262         Reviewed by Geoffrey Garen.
1263
1264         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1265         (BuildbotCombinedQueueView.prototype.update): Replace array membership test with regex test.
1266         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1267         (BuildbotIteration.prototype._parseData): Replace array membership test with regex test.
1268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1269         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Replace array membership test with regex test.
1270
1271 2016-06-28  Michael Saboff  <msaboff@apple.com>
1272
1273         btjs no longer accepts optional frame count argument
1274         https://bugs.webkit.org/show_bug.cgi?id=159235
1275
1276         Reviewed by Saam Barati.
1277
1278         Fix the detection of optional backtrace-depth parameter to use the length
1279         of the command.
1280
1281         * lldb/lldb_webkit.py:
1282         (btjs):
1283
1284 2016-06-28  Jon Lee  <jonlee@apple.com>
1285
1286         Update animometer.plan
1287
1288         Rubber-stamped by Said Abou-Hallawa.
1289
1290         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202601.
1291
1292 2016-06-28  Filip Pizlo  <fpizlo@apple.com>
1293
1294         Unreviewed, fix JSC tests. Air.js moved, and the harness needs to know.
1295
1296         * Scripts/run-javascriptcore-tests:
1297         (runJSCStressTests):
1298
1299 2016-06-28  Brian Burg  <bburg@apple.com>
1300
1301         RunLoop::Timer should use constructor templates instead of class templates
1302         https://bugs.webkit.org/show_bug.cgi?id=159153
1303
1304         Reviewed by Alex Christensen.
1305
1306         Remove the RunLoop::Timer class template argument, and pass its constructor
1307         a reference to `this` instead of a pointer to `this`.
1308
1309         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1310         (WTR::TestRunner::TestRunner):
1311         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1312         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
1313         (TestWebKitAPI::TEST):
1314
1315 2016-06-28  Ryosuke Niwa  <rniwa@webkit.org>
1316
1317         REGRESSION(r201471): FormClient.textFieldDidEndEditing is no longer called when a text field is removed
1318         https://bugs.webkit.org/show_bug.cgi?id=159199
1319
1320         Reviewed by Alexey Proskuryakov.
1321
1322         Added a test case for removing a text field. Also fixed the flakiness and re-enabled it on Mac.
1323
1324         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1325         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
1326         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Focus a div upfront to avoid the flakiness from
1327         an input element getting automatically focused on Mac.
1328
1329 2016-06-28  Per Arne Vollan  <pvollan@apple.com>
1330
1331         [Win] Custom elements tests are failing.
1332         https://bugs.webkit.org/show_bug.cgi?id=159139
1333
1334         Reviewed by Alex Christensen.
1335
1336         Enable custom element API when running tests.
1337
1338         * DumpRenderTree/win/DumpRenderTree.cpp:
1339         (resetWebPreferencesToConsistentValues):
1340
1341 2016-06-27  Lucas Forschler  <lforschler@apple.com>
1342
1343         Test commit. Please ignore.
1344         
1345 2016-06-27  Michael Catanzaro  <mcatanzaro@igalia.com>
1346
1347         [GTK][EFL] Disable subtle-crypto in FeatureList.pm
1348         https://bugs.webkit.org/show_bug.cgi?id=155073
1349
1350         Reviewed by Daniel Bates.
1351
1352         * Scripts/webkitperl/FeatureList.pm:
1353
1354 2016-06-27  Simon Fraser  <simon.fraser@apple.com>
1355
1356         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
1357         https://bugs.webkit.org/show_bug.cgi?id=159077
1358
1359         Reviewed by Tim Horton.
1360
1361         Re-enable render server snapshotting for iOS WTR via the change in InjectedBundlePage.cpp.
1362
1363         Fix WebPageProxy::forceRepaint() to correctly wait for the next commit from the web process,
1364         which is necessary for UI-side compositing.
1365
1366         Add some null checks to fix issues when the WKWebView gets resized to be empty, which
1367         seems to happen for some tests that call window.resizeTo().
1368
1369         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1370         (WTR::InjectedBundlePage::dump): Deleted.
1371         * WebKitTestRunner/TestInvocation.cpp:
1372         (WTR::TestInvocation::dumpResults):
1373         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1374         (WTR::createCGContextFromImage):
1375         (WTR::computeMD5HashStringForContext):
1376         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1377         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1378         (WTR::PlatformWebView::windowSnapshotImage):
1379
1380 2016-06-27  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1381
1382         [EFL] Support to build on Debian linux
1383         https://bugs.webkit.org/show_bug.cgi?id=159123
1384
1385         Reviewed by Antonio Gomes.
1386
1387         * efl/install-dependencies: Install libgnutls28-dev.
1388
1389 2016-06-27  Alex Christensen  <achristensen@webkit.org>
1390
1391         Send canAuthenticateAgainstProtectionSpace calls from NetworkProcess directly to UIProcess
1392         https://bugs.webkit.org/show_bug.cgi?id=159071
1393
1394         Reviewed by Brady Eidson.
1395
1396         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1397         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1398         (WTR::TestRunner::setHandlesAuthenticationChallenges):
1399         (WTR::TestRunner::setShouldLogCanAuthenticateAgainstProtectionSpace):
1400         (WTR::TestRunner::setAuthenticationUsername):
1401         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1402         * WebKitTestRunner/TestController.cpp:
1403         (WTR::TestController::TestController):
1404         (WTR::TestController::resetStateToConsistentValues):
1405         (WTR::TestController::didFinishNavigation):
1406         (WTR::TestController::canAuthenticateAgainstProtectionSpace):
1407         (WTR::TestController::didReceiveAuthenticationChallenge):
1408         (WTR::TestController::didCommitNavigation):
1409         * WebKitTestRunner/TestController.h:
1410         (WTR::TestController::setBlockAllPlugins):
1411         (WTR::TestController::setShouldLogHistoryClientCallbacks):
1412         (WTR::TestController::setShouldLogCanAuthenticateAgainstProtectionSpace):
1413         (WTR::TestController::isCurrentInvocation):
1414         * WebKitTestRunner/TestInvocation.cpp:
1415         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1416         Added output so we can see when canAuthenticateAgainstProtectionSpace is called from the test expectations.
1417
1418 2016-06-27  Per Arne Vollan  <pvollan@apple.com>
1419
1420         [Win] The test fast/events/wheel-event-outside-body.html is timing out.
1421         https://bugs.webkit.org/show_bug.cgi?id=159129
1422
1423         Reviewed by Alex Christensen.
1424
1425         Implement the function mouseScrollBy in the Windows event sender.
1426
1427         * DumpRenderTree/win/EventSender.cpp:
1428         (mouseScrollBy):
1429         (mouseScrollByWithWheelAndMomentumPhasesCallback):
1430
1431 2016-06-25  Filip Pizlo  <fpizlo@apple.com>
1432
1433         REGRESSION: Weak symbol warning when linking TestWebKitAPI
1434         https://bugs.webkit.org/show_bug.cgi?id=159104
1435
1436         Reviewed by Dan Bernstein.
1437         
1438         This uses a better approach to turn on -fvisility=hidden. All of the other projects set
1439         this flag in xcconfig, using "GCC_SYMBOLS_PRIVATE_EXTERN = YES;".
1440
1441         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
1442         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Use GCC_SYMBOLS_PRIVATE_EXTERN here.
1443         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Revert r202461.
1444
1445 2016-06-25  Per Arne Vollan  <pvollan@apple.com>
1446
1447         [Win] The test fast/events/wheel-event-destroys-frame.html is timing out.
1448         https://bugs.webkit.org/show_bug.cgi?id=159086
1449
1450         Reviewed by Alex Christensen.
1451
1452         Implement required wheel event function in event sender.
1453  
1454         * DumpRenderTree/win/EventSender.cpp:
1455         (mouseScrollByWithWheelAndMomentumPhasesCallback):
1456
1457 2016-06-24  Filip Pizlo  <fpizlo@apple.com>
1458
1459         REGRESSION: Weak symbol warning when linking TestWebKitAPI
1460         https://bugs.webkit.org/show_bug.cgi?id=159104
1461
1462         Reviewed by Mark Lam.
1463         
1464         The problem is that the tests were not compiled with -fvisibility=hidden like the rest of
1465         WK.
1466
1467         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1468
1469 2016-06-24  David Kilzer  <ddkilzer@apple.com>
1470
1471         parser_unittests.pl should not hardcode list of tests
1472         <https://webkit.org/b/159074>
1473
1474         Reviewed by Daniel Bates.
1475
1476         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
1477         Update to read the list of tests from the 'resources' directory,
1478         and instead map file extensions to subroutine names.  Switch to
1479         use File::Basename::fileparse() to get basename and file
1480         extension for each test.
1481         (readTestFiles): Added.  Reads files from the directory passed
1482         in and ignores: hidden files, anything that isn't a plain file,
1483         and expected test results files.
1484
1485 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
1486
1487         Fix Windows build.
1488
1489         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1490         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1491
1492 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1493
1494         [EFL] Change download path of libxslt
1495
1496         Unreviewed EFL build fix.
1497
1498         In Korea current download path can't be accessed. Change it.
1499
1500         * efl/jhbuild.modules:
1501
1502 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
1503
1504         https://bugs.webkit.org/show_bug.cgi?id=159077
1505
1506         Turn off CARenderServer snapshotting in WTR for now, because it doesn't reliably
1507         snapshot the final state of the test in release builds. 
1508
1509         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1510         (WTR::InjectedBundlePage::dump):
1511
1512 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
1513
1514         Fix hardware builds, where USE(IOSURFACE) is true by #ifdeffing.
1515
1516         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1517         (createBitmapContextFromWebView):
1518         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1519         (WTR::PlatformWebView::windowSnapshotImage):
1520
1521 2016-06-23  Simon Fraser  <simon.fraser@apple.com>
1522
1523         [iOS] Make DumpRenderTree and WebKitTestRunner in the simulator use render server snapshotting
1524         https://bugs.webkit.org/show_bug.cgi?id=159077
1525
1526         Reviewed by Tim Horton.
1527
1528         Fix both DRT and WTR for iOS to use CARenderServerRenderLayerWithTransform() on the view's layer.
1529         This allows them to capture compositing layers in snapshots, rather than doing a software paint,
1530         thus enabling testing of more things.
1531
1532         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
1533         (createBitmapContext): Moved to this file to share it.
1534         * DumpRenderTree/cg/PixelDumpSupportCG.h:
1535         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1536         (createBitmapContextFromWebView):
1537         (BitmapContext::createFromUIImage): Deleted.
1538         (BitmapContext::pixelData): Deleted.
1539         (BitmapContext::BitmapContext): Deleted.
1540         (computeMD5HashStringForBitmapContext): Deleted.
1541         (dumpBitmap): Deleted.
1542         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Don't exclude PixelDumpSupportCG.cpp.
1543         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1544         (createPagedBitmapContext):
1545         (createBitmapContext): Deleted.
1546         * WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: link with QuartzCore.
1547         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1548         (WTR::InjectedBundlePage::dump): Deleted.
1549         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
1550         (WTR::PlatformWebView::windowSnapshotImage):
1551
1552 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
1553
1554         [jhbuild] Added libxslt module.
1555         https://bugs.webkit.org/show_bug.cgi?id=159034
1556
1557         Unreviewed, followup for r202373.
1558
1559         * efl/install-dependencies: Removed libxslt 
1560         * gtk/install-dependencies: Ditto.
1561
1562 2016-06-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1563
1564         [EFL] Bump gstreamer version from 1.6.3 to 1.8.0
1565         https://bugs.webkit.org/show_bug.cgi?id=159050
1566
1567         Reviewed by Antonio Gomes.
1568
1569         To be sync with GTK port, this patch bumps gstreamer version for EFL port.
1570
1571         * efl/jhbuild.modules:
1572         * efl/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
1573         * efl/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
1574
1575 2016-06-23  Konstantin Tokarev  <annulen@yandex.ru>
1576
1577         [jhbuild] Added libxslt module.
1578         https://bugs.webkit.org/show_bug.cgi?id=159034
1579
1580         Reviewed by Michael Catanzaro.
1581
1582         * efl/jhbuild.modules:
1583         * gtk/jhbuild.modules:
1584
1585 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
1586
1587         [Win] Use Windows api function to find top level parent.
1588         https://bugs.webkit.org/show_bug.cgi?id=159021
1589
1590         Reviewed by Brent Fulgham.
1591
1592         Delete findTopLevelParent function, and use Win32 function GetAncestor instead.
1593  
1594         * DumpRenderTree/win/UIDelegate.cpp:
1595         (UIDelegate::runModal):
1596         (findTopLevelParent): Deleted.
1597         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1598         (PrintWebUIDelegate::runModal):
1599         (findTopLevelParent): Deleted.
1600
1601 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
1602
1603         [Win] The test storage/indexeddb/modern/handle-user-delete.html is timing out.
1604         https://bugs.webkit.org/show_bug.cgi?id=158934
1605
1606         Reviewed by Brent Fulgham.
1607
1608         DumpRenderTree should also delete indexed databases when clearAllDatabases() is called.
1609
1610         * DumpRenderTree/win/TestRunnerWin.cpp:
1611         (TestRunner::clearAllDatabases):
1612
1613 2016-06-22  Saam Barati  <sbarati@apple.com>
1614
1615         run-javascriptcore-tests should have some environment variables for commonly used settings
1616         https://bugs.webkit.org/show_bug.cgi?id=159047
1617
1618         Reviewed by Keith Miller.
1619
1620         This patch adds three environment variables that run-javascriptcore-tests
1621         consults:
1622         - RUN_JAVASCRIPTCORE_TESTS_TESTAPI can be set to 'true' or 'false'. It
1623           determines if we should run the api tests or not.
1624         - RUN_JAVASCRIPTCORE_TESTS_BUILD can be set to 'true' or 'false'. It
1625           determines if we will perform a build or not before running the tests.
1626           to set the default should-build setting.
1627         - RUN_JAVASCRIPTCORE_TESTS_EXTRA_TESTS can be set to a directory or to
1628           a yaml file. If set, we will run the extra tests it refers to.
1629
1630         All the values in these environment variables will be overridden if an
1631         option is explicitly passed in. For example, the following will run
1632         the api tests:
1633         `RUN_JAVASCRIPTCORE_TESTS_TESTAPI=false run-javascriptcore-tests --testapi`
1634
1635         * Scripts/run-javascriptcore-tests:
1636
1637 2016-06-22  Saam barati  <sbarati@apple.com>
1638
1639         TypeProfiler and TypeProfilerLog don't play nicely with the concurrent JIT
1640         https://bugs.webkit.org/show_bug.cgi?id=159037
1641         <rdar://problem/26935349>
1642
1643         Reviewed by Benjamin Poulain.
1644
1645         Run typeProfiler.yaml tests under an additional CJIT enabled mode.
1646
1647         * Scripts/run-jsc-stress-tests:
1648
1649 2016-06-22  Aakash Jain  <aakash_jain@apple.com>
1650
1651         Fix style issues in webkitpy
1652         https://bugs.webkit.org/show_bug.cgi?id=159019
1653
1654         Reviewed by Daniel Bates.
1655
1656         Fixed the formatting issues as reported by check-webkit-style in webkitpy.
1657         There is no functionality change.
1658         Only affected file names retained below for brevity.
1659
1660         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
1661         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
1662         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1663         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1664         * Scripts/webkitpy/benchmark_runner/utils.py:
1665         * Scripts/webkitpy/common/checkout/changelog.py:
1666         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1667         * Scripts/webkitpy/common/checkout/checkout.py:
1668         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1669         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1670         * Scripts/webkitpy/common/checkout/commitinfo.py:
1671         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1672         * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
1673         * Scripts/webkitpy/common/checkout/scm/scm.py:
1674         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1675         * Scripts/webkitpy/common/config/committers_unittest.py:
1676         * Scripts/webkitpy/common/config/irc.py:
1677         * Scripts/webkitpy/common/config/ports.py:
1678         * Scripts/webkitpy/common/config/ports_unittest.py:
1679         * Scripts/webkitpy/common/config/urls.py:
1680         * Scripts/webkitpy/common/host_mock.py:
1681         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
1682         * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
1683         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
1684         * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
1685         * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
1686         * Scripts/webkitpy/common/net/credentials_unittest.py:
1687         * Scripts/webkitpy/common/net/irc/ircproxy_unittest.py:
1688         * Scripts/webkitpy/common/net/networktransaction_unittest.py:
1689         * Scripts/webkitpy/common/net/statusserver.py:
1690         * Scripts/webkitpy/common/system/autoinstall.py:
1691         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
1692         * Scripts/webkitpy/common/system/executive.py:
1693         * Scripts/webkitpy/common/system/executive_mock.py:
1694         * Scripts/webkitpy/common/system/executive_unittest.py:
1695         * Scripts/webkitpy/common/system/filesystem_mock.py:
1696         * Scripts/webkitpy/common/system/filesystem_unittest.py:
1697         * Scripts/webkitpy/common/system/logutils_unittest.py:
1698         * Scripts/webkitpy/common/system/path.py:
1699         * Scripts/webkitpy/common/system/path_unittest.py:
1700         * Scripts/webkitpy/common/system/platforminfo.py:
1701         * Scripts/webkitpy/common/system/user.py:
1702         * Scripts/webkitpy/common/system/user_unittest.py:
1703         * Scripts/webkitpy/common/system/workspace_unittest.py:
1704         * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
1705         * Scripts/webkitpy/common/thread/threadedmessagequeue_unittest.py:
1706         * Scripts/webkitpy/layout_tests/controllers/layout_test_finder.py:
1707         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1708         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
1709         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1710         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py:
1711         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1712         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1713         * Scripts/webkitpy/layout_tests/models/test_failures.py:
1714         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
1715         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1716         * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
1717         * Scripts/webkitpy/layout_tests/views/printing.py:
1718         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1719         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1720         * Scripts/webkitpy/port/base_unittest.py:
1721         * Scripts/webkitpy/port/driver.py:
1722         * Scripts/webkitpy/port/driver_unittest.py:
1723         * Scripts/webkitpy/port/factory.py:
1724         * Scripts/webkitpy/port/gtk.py:
1725         * Scripts/webkitpy/port/server_process_unittest.py:
1726         * Scripts/webkitpy/port/test.py:
1727         * Scripts/webkitpy/port/win.py:
1728         * Scripts/webkitpy/style/checker.py:
1729         * Scripts/webkitpy/style/checkers/common_unittest.py:
1730         * Scripts/webkitpy/style/checkers/cpp.py:
1731         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1732         * Scripts/webkitpy/style/checkers/js.py:
1733         * Scripts/webkitpy/style/checkers/jsonchecker.py:
1734         * Scripts/webkitpy/style/checkers/png.py:
1735         * Scripts/webkitpy/style/checkers/text.py:
1736         * Scripts/webkitpy/style/checkers/text_unittest.py:
1737         * Scripts/webkitpy/style/error_handlers.py:
1738         * Scripts/webkitpy/style/filter.py:
1739         * Scripts/webkitpy/style/filter_unittest.py:
1740         * Scripts/webkitpy/style/optparser.py:
1741         * Scripts/webkitpy/style/optparser_unittest.py:
1742         * Scripts/webkitpy/test/main.py:
1743         * Scripts/webkitpy/w3c/test_converter.py:
1744         * Scripts/webkitpy/w3c/test_converter_unittest.py:
1745         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1746         * Scripts/webkitpy/xcode/simulator.py:
1747
1748 2016-06-22  Brady Eidson  <beidson@apple.com>
1749
1750         DatabaseProcess doesn't handle WebProcesses going away uncleanly.
1751         https://bugs.webkit.org/show_bug.cgi?id=158894
1752
1753         Reviewed by Alex Christensen.
1754
1755         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1756         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-2.html:
1757         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess-3.html: Added.
1758         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
1759
1760 2016-06-22  Jon Lee  <jonlee@apple.com>
1761
1762         Update animometer.plan
1763         https://bugs.webkit.org/show_bug.cgi?id=159012
1764
1765         Reviewed by Ryosuke Niwa.
1766
1767         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r202318.
1768
1769 2016-06-22  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1770
1771         W3C test importer should generate files to ignore by WebKit SCM
1772         https://bugs.webkit.org/show_bug.cgi?id=142743
1773
1774         Reviewed by Darin Adler.
1775
1776         TestDownloader generates the .gitignore file according submodules git repository information.
1777         TestImporter requests the generation of .gitignore and the main __init__.py according LayoutTests/imported/w3c/resources/TestRepositories options.
1778
1779         * Scripts/webkitpy/w3c/test_downloader.py:
1780         (TestDownloader.generate_gitignore): Generating .gitignore according submodules description.
1781         * Scripts/webkitpy/w3c/test_importer.py:
1782         (TestImporter.process_test_repositories_import_options): Added the generation of .gitignore/__init__.py if the repo has the right option.
1783         (TestImporter):
1784         (TestImporter.write_init_py): Writing not empty __init__.py files.
1785         (TestImporter.import_tests): Using  of write_init_py. 
1786         * Scripts/webkitpy/w3c/test_importer_unittest.py:
1787         (TestImporterTest.test_git_ignore_generation): Added .gitignore test.
1788         (TestImporterTest):
1789         (TestImporterTest.test_initpy_generation): Added __init__.py test.
1790
1791 2016-06-21  Sam Weinig  <sam@webkit.org>
1792
1793         WKWebView with no WKNavigationDelegate does not follow universal links
1794         <rdar://problem/24374110>
1795         https://bugs.webkit.org/show_bug.cgi?id=158997
1796
1797         Reviewed by Dan Bernstein.
1798
1799         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1800         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
1801         Add a new test that shows that we have a default navigation delegate by swizzling
1802         -[NSWorkspace openURL:]. This will only be called if there is a default client.
1803
1804 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
1805
1806         [Win] Implement modal dialog support in MiniBrowser.
1807         https://bugs.webkit.org/show_bug.cgi?id=158976
1808
1809         Reviewed by Brent Fulgham.
1810
1811         * MiniBrowser/win/PrintWebUIDelegate.cpp:
1812         (PrintWebUIDelegate::createWebViewWithRequest):
1813         (getHandleFromWebView):
1814         (PrintWebUIDelegate::webViewClose):
1815         (PrintWebUIDelegate::setFrame):
1816         (PrintWebUIDelegate::webViewFrame):
1817         (PrintWebUIDelegate::canRunModal):
1818         (findTopLevelParent):
1819         (PrintWebUIDelegate::runModal):
1820         (PrintWebUIDelegate::createModalDialog):
1821         * MiniBrowser/win/PrintWebUIDelegate.h:
1822         (PrintWebUIDelegate::webViewClose):
1823         (PrintWebUIDelegate::setFrame):
1824         (PrintWebUIDelegate::webViewFrame):
1825         (PrintWebUIDelegate::canRunModal):
1826         (PrintWebUIDelegate::runModal):
1827
1828 2016-06-22  Per Arne Vollan  <pvollan@apple.com>
1829
1830         window.showModalDialog doesn't work in DumpRenderTree on Windows
1831         https://bugs.webkit.org/show_bug.cgi?id=53675
1832
1833         Reviewed by Brent Fulgham.
1834
1835         Implement modal dialog support in DumpRenderTree.
1836
1837         * DumpRenderTree/win/UIDelegate.cpp:
1838         (UIDelegate::canRunModal):
1839         (getHandleFromWebView):
1840         (UIDelegate::createModalDialog):
1841         (findTopLevelParent):
1842         (UIDelegate::runModal):
1843         (UIDelegate::webViewClose):
1844         * DumpRenderTree/win/UIDelegate.h:
1845
1846 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
1847
1848         Fix formatting issues reported by check-webkit-style
1849         https://bugs.webkit.org/show_bug.cgi?id=159008
1850
1851         Reviewed by Alexey Proskuryakov.
1852
1853         Fixed the formatting issues as reported by check-webkit-style in webkitpy/tool folder.
1854         There is no functionality change.
1855
1856         * Scripts/webkitpy/tool/bot/irc_command.py:
1857         (Restart.execute):
1858         (Rollout):
1859         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1860         (IRCBotTest.test_exception_during_command):
1861         (IRCBotTest.test_exception_during_command.CommandWithException):
1862         (IRCBotTest.test_exception_during_command.CommandWithException.execute):
1863         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1864         (test_missing_unit_test_results_path):
1865         (test_layout_test_results):
1866         * Scripts/webkitpy/tool/bot/queueengine.py:
1867         * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
1868         * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
1869         (AbstractSequencedCommand):
1870         (AbstractSequencedCommand.__init__):
1871         * Scripts/webkitpy/tool/commands/download.py:
1872         (Land):
1873         * Scripts/webkitpy/tool/commands/openbugs.py:
1874         * Scripts/webkitpy/tool/commands/openbugs_unittest.py:
1875         (OpenBugsTest):
1876         * Scripts/webkitpy/tool/commands/queries.py:
1877         (PatchesToCommitQueue):
1878         (PatchesToCommitQueue.__init__):
1879         (PatchesToCommitQueue._needs_commit_queue):
1880         * Scripts/webkitpy/tool/commands/queries_unittest.py:
1881         (PrintExpectationsTest.test_platform):
1882         (PrintBaselinesTest):
1883         (PrintBaselinesTest.setUp):
1884         * Scripts/webkitpy/tool/commands/queues.py:
1885         (AbstractQueue):
1886         (AbstractQueue.__init__):
1887         (AbstractQueue.execute):
1888         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1889         (test_auto_retry):
1890         * Scripts/webkitpy/tool/commands/rebaseline.py:
1891         (AbstractParallelRebaselineCommand._files_to_add):
1892         (AbstractParallelRebaselineCommand):
1893         (AbstractParallelRebaselineCommand._rebaseline):
1894         * Scripts/webkitpy/tool/commands/setupgitclone.py:
1895         (SetupGitClone):
1896         * Scripts/webkitpy/tool/commands/sheriffbot.py:
1897         * Scripts/webkitpy/tool/commands/stepsequence.py:
1898         * Scripts/webkitpy/tool/commands/upload.py:
1899         (PostCommits._comment_text_for_commit):
1900         (PostCommits):
1901         (PostCommits.execute):
1902         (MarkBugFixed):
1903         (MarkBugFixed.__init__):
1904         * Scripts/webkitpy/tool/commands/upload_unittest.py:
1905         (UploadCommandsTest):
1906         (UploadCommandsTest.test_commit_message_for_current_diff):
1907         * Scripts/webkitpy/tool/grammar_unittest.py:
1908         (GrammarTest):
1909         (GrammarTest.test_join_with_separators):
1910         * Scripts/webkitpy/tool/multicommandtool.py:
1911         (HelpCommand.__init__):
1912         (HelpCommand):
1913         (HelpCommand._help_epilog):
1914         (HelpCommand._remove_help_options):
1915         (MultiCommandTool):
1916         (MultiCommandTool.__init__):
1917         (MultiCommandTool.main):
1918         * Scripts/webkitpy/tool/multicommandtool_unittest.py:
1919         (TrivialCommand):
1920         (TrivialCommand.__init__):
1921         (MultiCommandToolTest):
1922         (MultiCommandToolTest._assert_tool_main_outputs):
1923         (MultiCommandToolTest.test_retry):
1924         (test_command_help):
1925         * Scripts/webkitpy/tool/steps/__init__.py:
1926         * Scripts/webkitpy/tool/steps/abstractstep.py:
1927         * Scripts/webkitpy/tool/steps/applypatch.py:
1928         * Scripts/webkitpy/tool/steps/applypatchwithlocalcommit.py:
1929         (ApplyPatchWithLocalCommit):
1930         (ApplyPatchWithLocalCommit.options):
1931         * Scripts/webkitpy/tool/steps/build.py:
1932         * Scripts/webkitpy/tool/steps/checkstyle.py:
1933         (CheckStyle):
1934         (CheckStyle.options):
1935         * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
1936         * Scripts/webkitpy/tool/steps/closebug.py:
1937         * Scripts/webkitpy/tool/steps/closebugforlanddiff.py:
1938         * Scripts/webkitpy/tool/steps/closebugforlanddiff_unittest.py:
1939         (CloseBugForLandDiffTest):
1940         (CloseBugForLandDiffTest.test_empty_state):
1941         * Scripts/webkitpy/tool/steps/closepatch.py:
1942         * Scripts/webkitpy/tool/steps/commit.py:
1943         (Commit.run):
1944         * Scripts/webkitpy/tool/steps/confirmdiff.py:
1945         * Scripts/webkitpy/tool/steps/editchangelog.py:
1946         * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
1947         * Scripts/webkitpy/tool/steps/metastep.py:
1948         (MetaStep):
1949         (MetaStep.__init__):
1950         (MetaStep.run):
1951         * Scripts/webkitpy/tool/steps/obsoletepatches.py:
1952         * Scripts/webkitpy/tool/steps/options.py:
1953         (Options):
1954         * Scripts/webkitpy/tool/steps/postdiff.py:
1955         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
1956         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1957         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1958         * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
1959         (PrepareChangeLogTest):
1960         (PrepareChangeLogTest.test_resolve_existing_entry):
1961         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1962         * Scripts/webkitpy/tool/steps/promptforbugortitle.py:
1963         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1964         * Scripts/webkitpy/tool/steps/revertrevision.py:
1965         * Scripts/webkitpy/tool/steps/runtests.py:
1966         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1967         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1968         (StepsTest):
1969         (StepsTest._step_options):
1970         * Scripts/webkitpy/tool/steps/update.py:
1971         * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
1972         (UpdateChangeLogsWithReviewerTest):
1973         (UpdateChangeLogsWithReviewerTest.test_guess_reviewer_from_bug):
1974         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
1975         * Scripts/webkitpy/tool/steps/validatereviewer.py:
1976
1977 2016-06-21  Chris Dumez  <cdumez@apple.com>
1978
1979         Unreviewed, rolling out r202296.
1980
1981         Broke basic browsing in Safari
1982
1983         Reverted changeset:
1984
1985         "WKWebView with no WKNavigationDelegate does not follow
1986         universal links"
1987         https://bugs.webkit.org/show_bug.cgi?id=158997
1988         http://trac.webkit.org/changeset/202296
1989
1990 2016-06-21  Anders Carlsson  <andersca@apple.com>
1991
1992         Fix build.
1993
1994         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1995
1996 2016-06-21  Anders Carlsson  <andersca@apple.com>
1997
1998         Begin moving the Apple Pay code to the open source repository
1999         https://bugs.webkit.org/show_bug.cgi?id=158998
2000
2001         Reviewed by Tim Horton.
2002
2003         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2004         Add ENABLE_APPLE_PAY.
2005
2006 2016-06-21  Said Abou-Hallawa  <sabouhallawa@apple,com>
2007
2008         Add system tracing points for requestAnimationFrame() workflow
2009         https://bugs.webkit.org/show_bug.cgi?id=158723
2010
2011         Reviewed by Simon Fraser.
2012
2013         Add new plist entries to be used by kdebug_trace() viewing tools.
2014
2015         * Tracing/SystemTracePoints.plist:
2016
2017 2016-06-21  Sam Weinig  <sam@webkit.org>
2018
2019         WKWebView with no WKNavigationDelegate does not follow universal links
2020         <rdar://problem/24374110>
2021         https://bugs.webkit.org/show_bug.cgi?id=158997
2022
2023         Reviewed by Dan Bernstein.
2024
2025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2026         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewDefaultNavigationDelegate.mm: Added.
2027         Add a new test that shows that we have a default navigation delegate by swizzling
2028         -[NSWorkspace openURL:]. This will only be called if there is a default client.
2029
2030 2016-06-21  Aakash Jain  <aakash_jain@apple.com>
2031
2032         run-javascriptcore-tests should have flag to skip mozilla tests
2033         https://bugs.webkit.org/show_bug.cgi?id=158963
2034         rdar://problem/25838924
2035
2036         Reviewed by Alexey Proskuryakov.
2037
2038         * Scripts/run-javascriptcore-tests:
2039         (runJSCStressTests): Added flag to skip mozilla tests.
2040
2041 2016-06-20  Commit Queue  <commit-queue@webkit.org>
2042
2043         Unreviewed, rolling out r202136.
2044         https://bugs.webkit.org/show_bug.cgi?id=158932
2045
2046         JSBench wasn't regressed by r202002 and r202111 on iOS after
2047         all (Requested by rniwa_ on #webkit).
2048
2049         Reverted changeset:
2050
2051         "Unreviewed, rolling out r202002 and r202111."
2052         https://bugs.webkit.org/show_bug.cgi?id=158638
2053         http://trac.webkit.org/changeset/202136
2054
2055 2016-06-20  Keith Rollin  <krollin@apple.com>
2056
2057         Remove RefPtr::release() and change calls sites to use WTFMove()
2058         https://bugs.webkit.org/show_bug.cgi?id=158369
2059
2060         Reviewed by Chris Dumez.
2061
2062         RefPtr::release() releases its managed pointer awkwardly. It's more
2063         direct and clearer to use WTFMove to transfer ownership of the managed
2064         pointer.
2065
2066         As part of this cleanup, also change a lot of explicit data types to
2067         'auto'.
2068
2069         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2070         (createBitmapContextFromWebView):
2071         (createPagedBitmapContext):
2072         * DumpRenderTree/mac/TestRunnerMac.mm:
2073         (TestRunner::setMockGeolocationPosition):
2074         * TestWebKitAPI/Tests/WTF/HashCountedSet.cpp:
2075         (TestWebKitAPI::TEST):
2076         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2077         (TestWebKitAPI::TEST):
2078
2079 2016-06-20  Tim Horton  <timothy_horton@apple.com>
2080
2081         Add a API test for *DeferringViewInWindowChanges as fixed in r202230
2082         https://bugs.webkit.org/show_bug.cgi?id=158947
2083
2084         Reviewed by Simon Fraser.
2085
2086         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2087         * TestWebKitAPI/Tests/WebKit2/DeferredViewInWindowStateChange.mm: Added.
2088         (TestWebKitAPI::didFinishLoadForFrame):
2089         (TestWebKitAPI::setPageLoaderClient):
2090         (TestWebKitAPI::TEST):
2091         Add a test ensuring that in-window state changes are deferred when using
2092         the SPI for deferring them, as fixed in r202230.
2093
2094 2016-06-20  Fujii Hironori  <Hironori.Fujii@sony.com>
2095
2096         WebKitTestRunner: Missing \n at the line of "#PROCESS UNRESPONSIVE"
2097         https://bugs.webkit.org/show_bug.cgi?id=158931
2098
2099         Reviewed by Alexey Proskuryakov.
2100
2101         * WebKitTestRunner/TestInvocation.cpp:
2102         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Appended missing \n at the end of line.
2103
2104 2016-06-17  Alexey Proskuryakov  <ap@apple.com>
2105
2106         Add test expectations for macOS Sierra
2107         https://bugs.webkit.org/show_bug.cgi?id=158903
2108
2109         Reviewed by Alex Christensen.
2110
2111         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra.png: Added.
2112         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Sierra@2x.png: Added.
2113         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
2114         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2115         Added dashboard support.
2116
2117         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
2118         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
2119         Trigger the right build queues on check-in.
2120
2121         * Scripts/webkitpy/common/system/platforminfo.py:
2122         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
2123         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
2124         * Scripts/webkitpy/port/mac.py:
2125         * Scripts/webkitpy/port/mac_unittest.py:
2126         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2127         Added cases for Sierra, and updated tests for new baseline search paths.
2128
2129 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
2130
2131         Another buid fix for master.cfg.
2132
2133         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2134         (CompileWebKit.start):
2135
2136 2016-06-19  Alexey Proskuryakov  <ap@apple.com>
2137
2138         Another buid fix for master.cfg.
2139
2140         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2141         (CompileWebKit.start):
2142
2143 2016-06-19  Lucas Forschler  <lforschler@apple.com>
2144
2145         Fix master.cfg
2146         
2147         Unreviewed build fix.
2148
2149         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2150         (CompileWebKit.start):
2151
2152 2016-06-19  Lucas Forschler  <lforschler@apple.com>
2153
2154         Test another commit.
2155         
2156         Unreviewed.
2157
2158 2016-06-19  Lucas Forschler  <lforschler@apple.com>
2159
2160         Testing fix for trac-mirror.
2161         
2162         Unreviewed.
2163
2164 2016-06-19  Lucas Forschler  <lforschler@apple.com>
2165
2166         Test a commit against the SVN 1.9 server upgrade.
2167         
2168         Unreviewed.
2169         
2170 2016-06-17  Daniel Bates  <dabates@apple.com>
2171
2172         Unreviewed, rolling out r202186.
2173
2174         Broke the Apple Windows, Apple Yosemite, GTK, and WinCairo
2175         builds.
2176
2177         Reverted changeset:
2178
2179         "File scheme should not allow access of a resource on a
2180         different volume."
2181         https://bugs.webkit.org/show_bug.cgi?id=158552
2182         http://trac.webkit.org/changeset/202186
2183
2184 2016-06-17  Pranjal Jumde  <pjumde@apple.com>
2185
2186         File scheme should not allow access of a resource on a different volume.
2187         https://bugs.webkit.org/show_bug.cgi?id=158552
2188         <rdar://problem/15307582>
2189
2190         Reviewed by Brent Fulgham.
2191
2192         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2193         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2194         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2195         (-[CrossPartitionFileSchemeAccessNavigationDelegate webView:didFinishNavigation:]):
2196         When the main page load is complete fetch the contents of the document to check if iframe was loaded
2197         (createPartition):
2198         Create a disk image and load the contents of the file.
2199         (cleanUp):
2200         (TestWebKitAPI::TEST):
2201
2202 2016-06-17  Enrique Ocaña González  <eocanha@igalia.com>
2203
2204         Unreviewed. Added myself to the list of committers.
2205
2206         * Scripts/webkitpy/common/config/contributors.json:
2207
2208 2016-06-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
2209
2210         [EFL][GTK] LayoutTest doesn't run on Ubuntu 16.04
2211         https://bugs.webkit.org/show_bug.cgi?id=158141
2212
2213         Reviewed by Michael Catanzaro.
2214
2215         * Scripts/webkitpy/port/base.py: Detect php version in system, then use it.
2216         (Port._is_debian_php_version_7):
2217         (Port._debian_php_version):
2218         (Port._apache_config_file_name_for_platform):
2219         * efl/install-dependencies:
2220         * gtk/install-dependencies:
2221
2222 2016-06-16  Filip Pizlo  <fpizlo@apple.com>
2223
2224         Baseline JIT should be concurrent
2225         https://bugs.webkit.org/show_bug.cgi?id=158755
2226
2227         Reviewed by Geoffrey Garen.
2228         
2229         Need to disable concurrent JIT when running profiler tests. We should have been doing this
2230         all along.
2231
2232         * Scripts/run-jsc-stress-tests:
2233
2234 2016-06-16  Per Arne Vollan  <pvollan@apple.com>
2235
2236         [Win] Accessibility implementation unable to recurse through document (sometimes) to find named elements
2237         https://bugs.webkit.org/show_bug.cgi?id=140798
2238
2239         Reviewed by Brent Fulgham.
2240        
2241         Make sure layout is up-to-date before trying to find named elements. 
2242
2243         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2244         (AccessibilityController::rootElement):
2245
2246 2016-06-16  Chris Dumez  <cdumez@apple.com>
2247
2248         Unreviewed, rolling out r202002 and r202111.
2249
2250         Ryosuke says this was a JSBench regression on iOS
2251
2252         Reverted changesets:
2253
2254         "Make HashMap and HashSet work with Refs"
2255         https://bugs.webkit.org/show_bug.cgi?id=158638
2256         http://trac.webkit.org/changeset/202002
2257
2258         "Improve HashMap and HashSet support for Ref"
2259         https://bugs.webkit.org/show_bug.cgi?id=158789
2260         http://trac.webkit.org/changeset/202111
2261
2262 2016-06-15  Simon Fraser  <simon.fraser@apple.com>
2263
2264         [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location
2265         https://bugs.webkit.org/show_bug.cgi?id=158828
2266
2267         Reviewed by Enrica Casucci.
2268         
2269         Expose "forceIPadStyleZoomOnInputFocus" on UIScriptController, which allows iPad-style
2270         zooming behavior on <input> focus in the iPhone simulator, which is used for testing.
2271
2272         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2273         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2274         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
2275         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
2276         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2277         * WebKitTestRunner/ios/TestControllerIOS.mm:
2278         (WTR::TestController::platformResetStateToConsistentValues):
2279         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2280         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
2281         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
2282
2283 2016-06-15  Sam Weinig  <sam@webkit.org>
2284
2285         Forward/Back keyboard shortcuts need to flip for RTL
2286         https://bugs.webkit.org/show_bug.cgi?id=158823
2287         <rdar://problem/25975359>
2288
2289         Reviewed by Darin Adler.
2290
2291         Add tests for flipping the behavior of command-left and command-right
2292         under RTL mode.
2293
2294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2295         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Added.
2296         (-[CommandBackForwardOffscreenWindow isKeyWindow]):
2297         (-[CommandBackForwardOffscreenWindow isVisible]):
2298         (simulateCommandArrow):
2299         (WebKit2_CommandBackForwardTest::SetUp):
2300         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame):
2301         (WebKit2_CommandBackForwardTestWKView::SetUp):
2302         (WebKit2_CommandBackForwardTestWKView::loadFiles):
2303         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]):
2304         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
2305         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
2306
2307 2016-06-15  Tim Horton  <timothy_horton@apple.com>
2308
2309         Expose _shouldExpandContentToViewHeightForAutoLayout SPI on WKWebView
2310         https://bugs.webkit.org/show_bug.cgi?id=158824
2311         <rdar://problem/23713857>
2312
2313         Reviewed by Simon Fraser.
2314
2315         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
2316         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
2317         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
2318         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
2319         (TEST):
2320         Add a test for _shouldExpandContentToViewHeightForAutoLayout.
2321
2322 2016-06-13  Simon Fraser  <simon.fraser@apple.com>
2323
2324         [iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
2325         https://bugs.webkit.org/show_bug.cgi?id=158714
2326
2327         Reviewed by Enrica Casucci.
2328
2329         Add UIScriptController.keyboardAccessoryBar{Next,Previous} and hook it up to the WKContentView
2330         method that gets called from UIKit.
2331
2332         Add a test that exercises it.
2333
2334         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2335         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2336         (WTR::UIScriptController::keyboardAccessoryBarNext):
2337         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
2338         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2339         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2340         (WTR::UIScriptController::keyboardAccessoryBarNext):
2341         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
2342
2343 2016-06-15  Sam Weinig  <sam@webkit.org>
2344
2345         Improve HashMap and HashSet support for Ref
2346         https://bugs.webkit.org/show_bug.cgi?id=158789
2347
2348         Reviewed by Chris Dumez.
2349
2350         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2351         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2352         Add more cases to WTF_HashMap.Ref_Key, WTF_HashMap.Ref_Value and WTF_HashSet.Ref
2353
2354 2016-06-15  Aakash Jain  <aakash_jain@apple.com>
2355
2356         Too much log data generated during layout-tests on iOS Simulator
2357         https://bugs.webkit.org/show_bug.cgi?id=158751
2358
2359         Reviewed by Alexey Proskuryakov.
2360
2361         * Scripts/webkitpy/port/ios.py:
2362         (IOSSimulatorPort.developer_dir): memoized the property so that it is not called
2363         repeatedly.
2364
2365 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
2366
2367         [Win][CMake] Changes in WebKit options are not reflected in incremental builds.
2368         https://bugs.webkit.org/show_bug.cgi?id=158727
2369
2370         Reviewed by Alex Christensen.
2371
2372         Delete CMake cache file if WebKit options have been modified.
2373
2374         * Scripts/build-webkit:
2375         * Scripts/webkitdirs.pm:
2376         (shouldRemoveCMakeCache):
2377
2378 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2379
2380         Enabling Shadow DOM for all platforms
2381         https://bugs.webkit.org/show_bug.cgi?id=158738
2382
2383         Reviewed by Ryosuke Niwa.
2384
2385         Removed Shadow DOM from options (enabled by default)
2386
2387         * Scripts/webkitperl/FeatureList.pm:
2388         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2389
2390 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
2391
2392         [Win] The test accessibility/selected-text-range-aria-elements.html is failing.
2393         https://bugs.webkit.org/show_bug.cgi?id=158732
2394
2395         Reviewed by Brent Fulgham.
2396
2397         Implement selectedTextRange() method.
2398
2399         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2400         (AccessibilityUIElement::selectedTextRange):
2401
2402 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
2403
2404         [Win] MiniBrowser is not DPI aware.
2405         https://bugs.webkit.org/show_bug.cgi?id=158733
2406
2407         Reviewed by Brent Fulgham.
2408
2409         Call Win32 api function to let Windows know that we will scale the contents ourselves.
2410
2411         * MiniBrowser/win/WinMain.cpp:
2412         (wWinMain):
2413
2414 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
2415
2416         Unreviewed: add new email address to contributors.json.
2417
2418         * Scripts/webkitpy/common/config/contributors.json:
2419
2420 2016-06-14  Keith Miller  <keith_miller@apple.com>
2421
2422         JSBench should use geometric mean
2423         https://bugs.webkit.org/show_bug.cgi?id=158775
2424
2425         Reviewed by Mark Lam.
2426
2427         For some reason JSBench was using algebraic mean. Since each test
2428         is pretty substantially different it should use geometric mean
2429         instead.
2430
2431         * Scripts/run-jsc-benchmarks:
2432
2433 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
2434
2435         Debug crash logs are not fully symbolicated on Yosemite
2436         https://bugs.webkit.org/show_bug.cgi?id=158760
2437
2438         Reviewed by Darin Adler.
2439
2440         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
2441         for debug builds on Yosemite.
2442
2443 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
2444
2445         Tests don't work in iOS Simulator when ASan is enabled
2446         https://bugs.webkit.org/show_bug.cgi?id=158726
2447
2448         Reviewed by David Kilzer.
2449
2450         * Scripts/webkitpy/port/driver.py:
2451         (Driver._setup_environ_for_driver): Added a FIXME.
2452         * Scripts/webkitpy/port/ios.py:
2453         (IOSSimulatorPort.setup_environ_for_server): Don't try to insert a dylib built for
2454         simulator into LayoutTestRelay, which is a macOS tool.
2455
2456 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
2457
2458         Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
2459         https://bugs.webkit.org/show_bug.cgi?id=158756
2460
2461         Reviewed by Alexey Proskuryakov.
2462
2463         * Scripts/webkitpy/xcode/simulator.py:
2464         (Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
2465         the "simulator device" is still in booted state. Since we ensured that simulator device 
2466         was in booted state earlier in this method, this indicates that simulator device has shut down
2467         unexpectedly.
2468
2469 2016-06-14  David Kilzer  <ddkilzer@apple.com>
2470
2471         Follow-up fix #2: REGRESSION (r202020): El Capitan CMake Debug build broken
2472         <https://webkit.org/b/158743>
2473
2474         Unreviewed build fix.
2475
2476         * DumpRenderTree/PlatformMac.cmake: Fix silly typo.
2477
2478 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
2479
2480         Too much log data generated during layout-tests on iOS Simulator
2481         https://bugs.webkit.org/show_bug.cgi?id=158751
2482
2483         Reviewed by Alexey Proskuryakov.
2484
2485         * Scripts/webkitpy/port/ios.py:
2486         (IOSSimulatorPort._quit_ios_simulator): Do not use -v flag.
2487         (IOSSimulatorPort.clean_up_test_run): Ditto.
2488         (IOSSimulatorPort._createSimulatorApp): Ditto.
2489
2490 2016-06-14  David Kilzer  <ddkilzer@apple.com>
2491
2492         Follow-up fix: REGRESSION (r202020): El Capitan CMake Debug build broken
2493         <https://webkit.org/b/158743>
2494
2495         Unreviewed build fix.
2496
2497         The fix in r202056 clobbered DumpRenderTree_SOURCES and
2498         TestNetscapePlugin_SOURCES from DumpRenderTree/CMakeLists.txt,
2499         so the build failure is now that we're not building the common
2500         sources.
2501
2502         Fix that by saving the common sources (which are all C++ source
2503         files) into *_Cpp_SOURCES lists first, then setting the compiler
2504         flags, then creating the final *_SOURCES lists.
2505
2506         * DumpRenderTree/PlatformMac.cmake: Add
2507         ${TestNetscapePlugin_Cpp_SOURCES} to list that needs
2508         "-std=c++14" compiler switch.
2509         (TestNetscapePlugin_Cpp_SOURCES): Add new list for C++ source
2510         files for TestNetscapePlugin.  Seeded with
2511         ${TestNetscapePlugin_SOURCES} from CMakeLists.txt.
2512         (TestNetscapePlugin_SOURCES): Add
2513         ${TestNetscapePlugin_Cpp_SOURCES} to the list of files.
2514         (DumpRenderTree_Cpp_SOURCES): Seed list for C++ source files
2515         with ${DumpRenderTree_SOURCES} from CMakeLists.txt.
2516         (DumpRenderTree_SOURCES): Reformat and sort source lists.
2517
2518 2016-06-14  David Kilzer  <ddkilzer@apple.com>
2519
2520         REGRESSION (r202020): El Capitan CMake Debug build broken
2521         <https://webkit.org/b/158743>
2522
2523         Reviewed by Alex Christensen.
2524
2525         The bug was that pure C++ source files (and Objective-C source
2526         files) were being compiled as Objective-C++ source files.  This
2527         is obviously incorrect, so the fix was to split out the list of
2528         source files by language, then define compiler switches based on
2529         each file type.
2530
2531         * DumpRenderTree/PlatformMac.cmake: Replace add_definitions()
2532         with separate foreach loops that set compiler flags based on
2533         each source file's type.
2534         (TestNetscapePlugin_ObjCpp_SOURCES): Rename from
2535         TestNetscapePlugin_SOURCES.
2536         (TestNetscapePlugin_SOURCES): Create based on
2537         ${TestNetscapePlugin_ObjCpp_SOURCES}.
2538         (DumpRenderTree_ObjC_SOURCES): Split from DumpRenderTree_SOURCES.
2539         (DumpRenderTree_Cpp_SOURCES): Ditto.
2540         (DumpRenderTree_ObjCpp_SOURCES): Ditto.
2541         (DumpRenderTree_SOURCES): Create from above three lists.
2542
2543 2016-06-14  Lucas Forschler  <lforschler@apple.com>
2544
2545         <rdar://problem/26685782>
2546         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
2547
2548         Rubber-stamped by Jessie Berlin.
2549
2550         * Scripts/copy-webkitlibraries-to-product-directory:
2551
2552 2016-06-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2553
2554         Activate CMake export compile commands option
2555         https://bugs.webkit.org/show_bug.cgi?id=158734
2556
2557         Reviewed by Alex Christensen.
2558
2559         * Scripts/webkitdirs.pm:
2560         (generateBuildSystemFromCMakeProject): Activating this option for all CMake builds.
2561         This allows using ymcd for WebKit hacking.
2562
2563 2016-06-14  David Kilzer  <ddkilzer@apple.com>
2564
2565         Modernize DumpRenderTreeMac.h
2566         <https://webkit.org/b/158721>
2567
2568         Reviewed by Andy Estes.
2569
2570         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2571         - Update copyright.
2572         - Update license.
2573         - Use #pragma once.
2574         - Use OBJC_CLASS macro.
2575
2576 2016-06-13  David Kilzer  <ddkilzer@apple.com>
2577
2578         False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm
2579         <https://webkit.org/b/158716>
2580
2581         Reviewed by Andy Estes.
2582
2583         * DumpRenderTree/mac/DumpRenderTree.mm:
2584         (destroyWebViewAndOffscreenWindow): Change this function to take
2585         a WebView, and assert that it's the same as [mainFrame webView].
2586         (dumpRenderTree): Pass 'webView' into
2587         destroyWebViewAndOffscreenWindow().
2588         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2589         (createWebViewAndOffscreenWindow): Add NS_RETURNS_RETAINED since
2590         this function returns a +1 WebView.  Declare this method only for
2591         Objective-C[++] source.
2592
2593 2016-06-13  Sam Weinig  <sam@webkit.org>
2594
2595         Make HashMap and HashSet work with Refs
2596         https://bugs.webkit.org/show_bug.cgi?id=158638
2597
2598         Reviewed by Darin Adler.
2599
2600         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2601         (TestWebKitAPI::TEST):
2602         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2603         (TestWebKitAPI::TEST):
2604         Add tests for using Refs in HashMaps (both as key and value) and HashSets.
2605
2606 2016-06-13  Mark Lam  <mark.lam@apple.com>
2607
2608         Add a mechanism for collecting LLINT stats.
2609         https://bugs.webkit.org/show_bug.cgi?id=158668
2610
2611         Reviewed by Filip Pizlo.
2612
2613         * DumpRenderTree/mac/DumpRenderTree.mm:
2614         (DumpRenderTreeMain):
2615
2616 2016-06-13  Romain Bellessort  <romain.bellessort@crf.canon.fr>
2617
2618         [GTK] Enabling Shadow DOM by default
2619         https://bugs.webkit.org/show_bug.cgi?id=158686
2620
2621         Reviewed by Carlos Garcia Campos.
2622
2623         Added support for enabling Shadow DOM by default for GTK.
2624         Changed GTK test expectations for fast/shadow-dom tests (most tests
2625         pass).
2626
2627         * Scripts/webkitperl/FeatureList.pm:
2628
2629 2016-06-12  Aakash Jain  <aakash_jain@apple.com>
2630
2631         run-safari/run-webkit-app fail to quit iOS simulator after Xcode installation
2632         https://bugs.webkit.org/show_bug.cgi?id=158651
2633         rdar://problem/26499824
2634
2635         Reviewed by Daniel Bates.
2636
2637         This change is to make our tools more robust. Sometimes run-safari/run-webkit-app fails 
2638         to start the tests as one of the first thing these scripts do is to relaunch iOS Simulators,
2639         and in process call quitIOSSimulator. In case the Simulator is not registered in LaunchServices
2640         for some reason, quitIOSSimulator fails and the script stops. This change will make the scripts
2641         still continue when they fail to quit iOS Simuator, and modify the way Simulator is opened, 
2642         so that Simulator is implicitly registered with LaunchServices while opening it.
2643
2644         * Scripts/webkitdirs.pm:
2645         (relaunchIOSSimulator):
2646         Launch iOS Simulator using complete path. Partially reverting http://trac.webkit.org/changeset/184202.
2647         (quitIOSSimulator):
2648         Do not die if quitting ios Simulator fails, so that relaunchIOSSimulator can still 
2649         attempt to launch the simulator.
2650         (waitUntilIOSSimulatorDeviceIsInState):
2651         Added a FIXME.
2652
2653 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
2654
2655         Addressing post-review comments after r201978.
2656         https://bugs.webkit.org/show_bug.cgi?id=158649
2657         <rdar://problem/13258122>
2658
2659         Unreviewed.
2660
2661         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2662         (TestWebKitAPI::TEST):
2663
2664 2016-06-11  Alexey Proskuryakov  <ap@apple.com>
2665
2666         Unreviewed leak fix after r201863.
2667
2668         * DumpRenderTree/mac/DumpRenderTree.mm:
2669         (dumpFramesAsText):
2670
2671 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
2672
2673         [Cocoa] Map commonly used Chinese Windows font names to names present on Cocoa operating systems
2674         https://bugs.webkit.org/show_bug.cgi?id=158649
2675         <rdar://problem/13258122>
2676
2677         Reviewed by Darin Adler.
2678
2679         * TestWebKitAPI/Tests/WTF/WTFString.h:
2680         (TestWebKitAPI::TEST):
2681
2682 2016-06-10  Alex Christensen  <achristensen@webkit.org>
2683
2684         Fix CMake build.
2685
2686         * TestWebKitAPI/PlatformMac.cmake:
2687
2688 2016-06-10  Filip Pizlo  <fpizlo@apple.com>
2689
2690         Rename JSAir to Air.js
2691
2692         Rubber stamped by Mark Lam.
2693
2694         * Scripts/run-javascriptcore-tests:
2695
2696 2016-06-10  Filip Pizlo  <fpizlo@apple.com>
2697
2698         JSC Stress Test failing: jsair-tests.yaml/test.js.ftl-eager-no-cjit
2699         https://bugs.webkit.org/show_bug.cgi?id=158571
2700
2701         Reviewed by Keith Miller.
2702         
2703         Unskip the JSAir test.
2704
2705         * Scripts/run-javascriptcore-tests:
2706         (runJSCStressTests):
2707
2708 2016-06-10  Sam Weinig  <sam@webkit.org>
2709
2710         Re-disable the UserMedia tests which are timing out.
2711
2712         They used to be accidentally disabled, due to not including
2713         the FeatureDefines correctly, but not we explicitly disable it.
2714
2715         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
2716         (TestWebKitAPI::TEST):
2717
2718 2016-06-10  Alex Christensen  <achristensen@webkit.org>
2719
2720         Introduce WTF::UniqueRef
2721         https://bugs.webkit.org/show_bug.cgi?id=158596
2722
2723         Reviewed by Brady Eidson.
2724
2725         * TestWebKitAPI/CMakeLists.txt:
2726         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2727         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp: Added.
2728         (TestWebKitAPI::B::B):
2729         (TestWebKitAPI::C::C):
2730         (TestWebKitAPI::function):
2731         (TestWebKitAPI::TEST):
2732
2733 2016-06-10  Sam Weinig  <sam@webkit.org>
2734
2735         Refactor TestWebKitAPI to allow just testing WTF
2736         https://bugs.webkit.org/show_bug.cgi?id=158625
2737
2738         Reviewed by Tim Horton.
2739
2740         Extract all the WTF tests into a new target to allow a faster build / test / fix
2741         cycle when working on WTF bugs and features.
2742         
2743         By calling `run-api-tests --wtf-only`, you don't need to have a build of JavaScriptCore/WebCore/etc
2744         to test WTF only changes.
2745
2746         * Scripts/build-api-tests:
2747         * Scripts/run-api-tests:
2748         (buildTestTool):
2749         (testToolPaths):
2750         Add new options to build-api-tests and run-api-tests to only build/run the WTF test runner.
2751
2752         * TestWebKitAPI/CMakeLists.txt:
2753         * TestWebKitAPI/Configurations/TestWTF.xcconfig: Added.
2754         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Added.
2755         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2756         Add two new targets, TestWTFLibrary which contains all the WTF tests, and TestWTF,
2757         the test runner that runs the WTF tests.
2758     
2759         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2760         Use Utilities.h rather than PlatformUtilities.h.
2761
2762         * TestWebKitAPI/Utilities.h: Added.
2763         * TestWebKitAPI/PlatformUtilities.h:
2764         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
2765         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm: Added.
2766         Move the sleep and run functions into a new Utilities.h/cpp file. This file contains utilities
2767         that don't depend on anything in the WebKit project. 
2768
2769 2016-06-10  Brady Eidson  <beidson@apple.com>
2770
2771         REGRESSION(r201928?) API test WTF.StringOperators failing
2772         https://bugs.webkit.org/show_bug.cgi?id=158623
2773
2774         Unreviewed, but buddy coded with Alex Christensen.
2775
2776         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
2777         (TestWebKitAPI::LifetimeLogger::fullName): Only one file in all of TestWebKitAPI is allowed
2778           to use string concatenation, otherwise the linker will mess up on the symbol related to
2779           this bizarre WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING macro expansion.
2780
2781 2016-06-10  Brady Eidson  <beidson@apple.com>
2782
2783         WTF_CrossThreadTask.Basic fails in all non mac ports.
2784         https://bugs.webkit.org/show_bug.cgi?id=158612
2785
2786         Reviewed by Alex Christensen.
2787
2788         The test is very sensitive to argument evaluation order which is explicitly undefined in C++.
2789         
2790         Instead, we should just count the appropriate events to forget their order.
2791         
2792         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
2793         (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
2794         (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
2795         (TestWebKitAPI::LifetimeLogger::isolatedCopy):
2796         (TestWebKitAPI::LifetimeLogger::fullName):
2797         (TestWebKitAPI::testFunction):
2798         (TestWebKitAPI::TEST):
2799         (TestWebKitAPI::LifetimeLogger::log): Deleted.
2800         (TestWebKitAPI::LifetimeLogger::takeLogStr): Deleted.
2801
2802 2016-06-09  Alex Christensen  <achristensen@webkit.org>
2803
2804         Clean up Tools *.vcxproj after switching to CMake.
2805
2806         * DumpRenderTree/DumpRenderTree.sln: Removed.
2807         * DumpRenderTree/DumpRenderTree.vcxproj: Removed.
2808         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Removed.
2809         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
2810         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
2811         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Removed.
2812         * DumpRenderTree/PlatformWin.cmake:
2813         * DumpRenderTree/win/TestNetscapePlugin.def: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def.
2814         * DumpRenderTree/win/TestNetscapePlugin.rc: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc.
2815         * DumpRenderTree/win/resource.h: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h.
2816         * MiniBrowser/MiniBrowser.vcxproj: Removed.
2817         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Removed.
2818         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Removed.
2819         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Removed.
2820         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Removed.
2821         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Removed.
2822         * MiniBrowser/MiniBrowser.vcxproj/small.ico: Removed.
2823         * MiniBrowser/win/CMakeLists.txt:
2824         * MiniBrowser/win/MiniBrowser.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico.
2825         * MiniBrowser/win/MiniBrowser.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc.
2826         * MiniBrowser/win/MiniBrowserLib.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc.
2827         * MiniBrowser/win/MiniBrowserLibResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h.
2828         * MiniBrowser/win/MiniBrowserResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h.
2829         * MiniBrowser/win/small.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/small.ico.
2830         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
2831         * win/DLLLauncher/DLLLauncherWinCairo.props: Removed.
2832
2833 2016-06-09  Zalan Bujtas  <zalan@apple.com>
2834
2835         Add testing support for 3x device scale factor.
2836         https://bugs.webkit.org/show_bug.cgi?id=158597
2837
2838         Reviewed by Simon Fraser.
2839
2840         Set 3x device scale factor on the test canvas when the test url is prefixed with hidpi-3x-. 
2841
2842         * DumpRenderTree/mac/DumpRenderTree.mm:
2843         (changeWindowScaleIfNeeded):
2844         * WebKitTestRunner/TestController.cpp:
2845         (WTR::TestController::updateWindowScaleForTest):
2846         * WebKitTestRunner/TestOptions.cpp:
2847         (WTR::deviceScaleFactorForTest):
2848         (WTR::TestOptions::TestOptions):
2849         (WTR::isHiDPITestPath): Deleted.
2850         * WebKitTestRunner/TestOptions.h:
2851
2852 2016-06-09  Michael Catanzaro  <mcatanzaro@igalia.com>
2853
2854         Add comments to clarify feature enablement
2855         https://bugs.webkit.org/show_bug.cgi?id=158567
2856
2857         Reviewed by Alex Christensen.
2858
2859         * Scripts/webkitperl/FeatureList.pm:
2860
2861 2016-06-09  Filip Pizlo  <fpizlo@apple.com>
2862
2863         Unreviewed, skip jsair tests while we figure out the debug timeouts.
2864
2865         * Scripts/run-javascriptcore-tests:
2866         (runJSCStressTests):
2867
2868 2016-06-09  Commit Queue  <commit-queue@webkit.org>
2869
2870         Unreviewed, rolling out r201815.
2871         https://bugs.webkit.org/show_bug.cgi?id=158570
2872
2873         This broke the cmake build. (Requested by lforschler on
2874         #webkit).
2875
2876         Reverted changeset:
2877
2878         "Teach cmake about libWebKitSystemInterfaceOSX10.12"
2879         http://trac.webkit.org/changeset/201815
2880
2881 2016-06-09  Brady Eidson  <beidson@apple.com>
2882
2883         Greatly simplify CrossThreadTask.h.
2884         https://bugs.webkit.org/show_bug.cgi?id=158542
2885
2886         Reviewed by Darin Adler.
2887
2888         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
2889         (TestWebKitAPI::TEST):
2890
2891 2016-06-09  Chris Dumez  <cdumez@apple.com>
2892
2893         Unreviewed, rolling out r201836, r201845, and r201848.
2894
2895         Looks like a 1-2% PLT regression on iOS
2896
2897         Reverted changesets:
2898
2899         "[JSC] Change some parameters based on a random search"
2900         https://bugs.webkit.org/show_bug.cgi?id=158514
2901         http://trac.webkit.org/changeset/201836
2902
2903         "Tempory fix for the debug bots"
2904         http://trac.webkit.org/changeset/201845
2905
2906         "Change thresholdForOptimizeSoon to match
2907         thresholdForOptimizeAfterWarmUp"
2908         http://trac.webkit.org/changeset/201848
2909
2910 2016-06-09  Michael Saboff  <msaboff@apple.com>
2911
2912         WebKitTestRunner and DumpRenderTree do not handle dangling surrogate characters
2913         https://bugs.webkit.org/show_bug.cgi?id=154863
2914
2915         Reviewed by Alexey Proskuryakov.
2916
2917         Added a non-strict verions of WKStringGetUTF8CString() that will handle dangling
2918         surrogates.  Changed the extraction of inner text from frames in DumpRenderTree
2919         to use the new WKStringGetUTF8CStringNonStrict() function instead of NSString
2920         conversion since NSString doesn't have a way to handle dangling surrogates.
2921         The code added in DumpRenderTree matches what was changed in WebKitTestRunner.
2922
2923         * DumpRenderTree/mac/DumpRenderTree.mm:
2924         (dumpFramesAsText):
2925         * WebKitTestRunner/StringFunctions.h:
2926         (WTR::toWTFString):
2927
2928 2016-06-08  Hunseop Jeong  <hs85.jeong@samsung.com>
2929
2930         Try to fix the EFL build. 
2931
2932         Unreviewed. 
2933
2934         * TestWebKitAPI/CMakeLists.txt:
2935
2936 2016-06-08  Alex Christensen  <achristensen@webkit.org>
2937
2938        Fix WinCairo build
2939
2940         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2941
2942 2016-06-08  Alex Christensen  <achristensen@webkit.org>
2943
2944         Fix WinCairo build
2945
2946         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2947         (BitmapContext::createByAdoptingBitmapAndContext):
2948         (BitmapContext::~BitmapContext):
2949
2950 2016-06-08  Benjamin Poulain  <benjamin@webkit.org>
2951
2952         [JSC] Change some parameters based on a random search
2953         https://bugs.webkit.org/show_bug.cgi?id=158514
2954
2955         Reviewed by Filip Pizlo.
2956
2957         * Scripts/run-jsc-stress-tests:
2958
2959 2016-06-08  Aakash Jain  <aakash_jain@apple.com>
2960
2961         tests fail if display sleeps while run-webkit-tests is running
2962         https://bugs.webkit.org/show_bug.cgi?id=153919
2963
2964         Reviewed by Alexey Proskuryakov.
2965
2966         * DumpRenderTree/mac/LayoutTestHelper.m:
2967         (releaseSleepAssertions): Release both Display sleep and System sleep assertions.
2968         (addSleepAssertions): Add sleep assertion for both Display sleep and System sleep.
2969
2970 2016-06-08  Lucas Forschler  <lforschler@apple.com>
2971
2972         Reverted changeset 201814.
2973
2974         * Scripts/copy-webkitlibraries-to-product-directory:
2975
2976 2016-06-08  Per Arne Vollan  <pvollan@apple.com>
2977
2978         [Win] Shadow DOM tests are failing.
2979         https://bugs.webkit.org/show_bug.cgi?id=158524
2980
2981         Reviewed by Brent Fulgham.
2982
2983         Enable Shadow DOM when running tests.
2984
2985         * DumpRenderTree/win/DumpRenderTree.cpp:
2986         (resetWebPreferencesToConsistentValues):
2987
2988 2016-06-08  Lucas Forschler  <lforschler@apple.com>
2989
2990         Teach cmake about libWebKitSystemInterfaceOSX10.12
2991         This patch also removes duplicated logic inside DumpRenderTree/PlatformMac.cmake
2992
2993         Rubber-stamped by Alex Christensen.
2994  
2995         * DumpRenderTree/PlatformMac.cmake:
2996         * WebKitTestRunner/PlatformMac.cmake:
2997
2998 2016-06-07  Lucas Forschler  <lforschler@apple.com>
2999
3000         <rdar://problem/26685782>
3001         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
3002
3003         Rubber-stamped by Jessie Berlin.
3004
3005         * Scripts/copy-webkitlibraries-to-product-directory:
3006
3007 2016-06-08  Aakash Jain  <aakash_jain@apple.com>
3008
3009         Don't try to cleanup non-existing ios Simulators
3010         https://bugs.webkit.org/show_bug.cgi?id=158510
3011
3012         Reviewed by Alexey Proskuryakov.
3013
3014         * Scripts/webkitpy/port/ios.py:
3015         (IOSSimulatorPort.clean_up_test_run): 
3016         Check if simulator exists before trying to clean it up.
3017
3018 2016-06-08  Brady Eidson  <beidson@apple.com>
3019
3020         Try to fix the Windows build.
3021
3022         Unreviewed.
3023
3024         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
3025         (TestWebKitAPI::LifetimeLogger::log):
3026         (TestWebKitAPI::LifetimeLogger::takeLogStr):
3027         (TestWebKitAPI::testFunction):
3028         (TestWebKitAPI::TEST):
3029         (TestWebKitAPI::log): Deleted. (VS was seeing it as a dupe symbol)
3030         (TestWebKitAPI::takeLogStr): Deleted. (VS was seeing it as a dupe symbol)
3031
3032 2016-06-08  Brady Eidson  <beidson@apple.com>
3033
3034         Make CrossThreadCopier more efficient (fewer copies!).
3035         https://bugs.webkit.org/show_bug.cgi?id=158456
3036
3037         Reviewed by Alex Christensen.
3038
3039         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
3040         (TestWebKitAPI::TEST):
3041
3042 2016-06-07  Filip Pizlo  <fpizlo@apple.com>
3043
3044         Add result validation to JSAir
3045         https://bugs.webkit.org/show_bug.cgi?id=158493
3046
3047         Reviewed by Saam Barati.
3048         
3049         Run JSAir.
3050
3051         * Scripts/run-javascriptcore-tests:
3052         (runJSCStressTests):
3053
3054 2016-06-08  Brady Eidson  <beidson@apple.com>
3055
3056         Add an API test that confirms object constructor/destructor calls during creation of a CrossThreadTask.
3057         https://bugs.webkit.org/show_bug.cgi?id=158528
3058
3059         Reviewed by Alex Christensen.
3060
3061         * TestWebKitAPI/CMakeLists.txt:
3062         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3063         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: Added.
3064         (TestWebKitAPI::log):
3065         (TestWebKitAPI::takeLogStr):
3066         (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
3067         (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
3068         (TestWebKitAPI::LifetimeLogger::isolatedCopy):
3069         (TestWebKitAPI::testFunction):
3070         (TestWebKitAPI::TEST):
3071
3072 2016-06-08  Konstantin Tokarev  <annulen@yandex.ru>
3073
3074         TestWebKitAPI: Removed redunandant check PLATFORM(GTK) && !defined(BUILDING_WEBKIT2__)
3075         https://bugs.webkit.org/show_bug.cgi?id=158521
3076
3077         Reviewed by Carlos Garcia Campos.
3078
3079         * TestWebKitAPI/config.h:
3080
3081 2016-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
3082
3083         [GTK] Use a longer timeout for glib unit tests
3084         https://bugs.webkit.org/show_bug.cgi?id=158476
3085
3086         Reviewed by Darin Adler.
3087
3088         The timeout is supposed to be per test case, but in the case of GLib tests it affects all the tests cases of the
3089         same test program. Some test programs like TestLoaderClient, that have a lot of test cases, often time out in
3090         the bots because the timeout is not enough to run all the tests cases. So, we should use a longer timeout for
3091         GLib tests.
3092
3093         * Scripts/run-gtk-tests:
3094         (TestRunner._run_test_glib):
3095
3096 2016-06-07  Keith Rollin  <krollin@apple.com>
3097
3098         Remove all uses of PassRefPtr in WTF
3099         https://bugs.webkit.org/show_bug.cgi?id=157596
3100         <rdar://problem/26234391>
3101
3102         Reviewed by Chris Dumez.
3103
3104         Update calls to interfaces that no longer take or return PassRefPtrs.
3105
3106         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
3107         (TestWebKitAPI::stringFromUTF8):
3108         (TestWebKitAPI::TEST):
3109
3110 2016-06-07  Per Arne Vollan  <pvollan@apple.com>
3111
3112         [Win] Imported markup insertion test is failing.
3113         https://bugs.webkit.org/show_bug.cgi?id=158477
3114
3115         Reviewed by Darin Adler.
3116
3117         Make sure the empty synchronous request is loaded after each test.
3118
3119         * DumpRenderTree/win/DumpRenderTree.cpp:
3120         (runTest):
3121
3122 2016-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3123
3124         REGRESSION(r201449) [GTK] ARMv7 build fails with libicudata.so.55: cannot open shared object file on gtkdoc-scangobj step.
3125         https://bugs.webkit.org/show_bug.cgi?id=158417
3126
3127         Reviewed by Michael Catanzaro.
3128
3129         The toolchain on armhf (ARMv7) seems unable to properly handle
3130         a shared library that doesn't link with anything.
3131
3132         And libicudata is built by default in this way because it only
3133         contains static data.
3134
3135         That makes icu unusable on armhf because the linker will be
3136         unable to resolve the libicudata dependencies.
3137
3138         Most (if not all) distributions workaround this by linking
3139         libicudata with libc6, which is already a needed dependency for
3140         any of the other icu shared libraries.
3141
3142         So import here the Debian patch fixing this issue. For further
3143         details check https://bugs.debian.org/653457
3144
3145         * gtk/jhbuild.modules:
3146         * gtk/patches/icudata-stdlibs.patch: Added.
3147
3148 2016-06-06  Per Arne Vollan  <pvollan@apple.com>
3149
3150         REGRESSION (r104174): 500+ tests failing on Windows
3151         https://bugs.webkit.org/show_bug.cgi?id=75965
3152
3153         Reviewed by Michael Catanzaro.
3154
3155         Reset WebView scale factors before running next test.
3156
3157         * DumpRenderTree/win/DumpRenderTree.cpp:
3158         (resetWebViewToConsistentStateBeforeTesting):
3159
3160 2016-06-04  Alexey Proskuryakov  <ap@apple.com>
3161
3162         REGRESSION (r201263): Some tests have become flaky timeouts.
3163         https://bugs.webkit.org/show_bug.cgi?id=157990
3164
3165         Reviewed by Darin Adler.
3166
3167         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
3168         It is somewhat legitimate for WebContent to not respond to messages after the test
3169         is done; it can be e.g. re-doing a costly repaint. So, we should restart is silently,
3170         without making the current test fail.
3171
3172 2016-06-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3173
3174         [GTK] Update YouCompleteMe script to make all include paths absolute
3175         https://bugs.webkit.org/show_bug.cgi?id=158301
3176
3177         Reviewed by Michael Catanzaro.
3178
3179         Before this patch, some include paths were not made absolute.
3180         This could make YouCompleteMe plugin to fail extracting information or validating cpp files.
3181
3182         * gtk/ycm_extra_conf.py:
3183
3184 2016-06-03  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
3185
3186         Unreviewed: add myself to the committers list.
3187
3188         * Scripts/webkitpy/common/config/contributors.json:
3189
3190 2016-06-02  Per Arne Vollan  <pvollan@apple.com>
3191
3192         [Win] Fetch API tests are failing.
3193         https://bugs.webkit.org/show_bug.cgi?id=158296
3194
3195         Reviewed by Alex Christensen.
3196
3197         Enable Fetch API when running tests.
3198
3199         * DumpRenderTree/win/DumpRenderTree.cpp:
3200         (resetWebPreferencesToConsistentValues):
3201
3202 2016-06-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3203
3204         Really display failing JSC stress tests in buildbot dashboard
3205         https://bugs.webkit.org/show_bug.cgi?id=158324
3206
3207         Reviewed by Alexey Proskuryakov.
3208
3209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3210         (BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.
3211         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3212         (BuildbotIteration.prototype._parseData): Correctly check for string membership in array.
3213         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3214         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
3215         membership in array.
3216         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
3217         generated after the first time.
3218         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3219         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.
3220
3221 2016-06-02  Michael Saboff  <msaboff@apple.com>
3222
3223         [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled
3224         https://bugs.webkit.org/show_bug.cgi?id=158317
3225
3226         Reviewed by Saam Barati.
3227
3228         Added defaultNoNoLLIntRun variant to run the default tests with the exception of the no-llint
3229         variant.
3230
3231         * Scripts/run-jsc-stress-tests:
3232
3233 2016-06-02  Aakash Jain  <aakash_jain@apple.com>
3234
3235         LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
3236         https://bugs.webkit.org/show_bug.cgi?id=158305
3237
3238         Reviewed by Alexey Proskuryakov.
3239
3240         * Scripts/webkitpy/port/ios.py:
3241         (IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.
3242
3243 2016-06-01  Brian Burg  <bburg@apple.com>
3244
3245         REGRESSION(r191907): Can't enter combining diacritic marks in Web Inspector fields
3246         https://bugs.webkit.org/show_bug.cgi?id=158227
3247         <rdar://problem/26232464>
3248
3249         Reviewed by Alexey Proskuryakov.
3250
3251         Add a regression test that runs on Mac only.
3252
3253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3254         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Added.
3255         (-[DummyNavigationDelegate webView:didFinishNavigation:]):
3256         (TEST):
3257         * TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Added.
3258
3259 2016-06-01  Chris Fleizach  <cfleizach@apple.com>
3260
3261         AX: iOS: VoiceOver can't access attachments in mail messages
3262         https://bugs.webkit.org/show_bug.cgi?id=158198
3263
3264         Reviewed by Joanmarie Diggs.
3265
3266         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3267         (AccessibilityUIElement::stringForRange):
3268         (AccessibilityUIElement::attributedStringForRange):
3269         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
3270         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3271         (WTR::AccessibilityUIElement::attributedStringForRange):
3272         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
3273
3274 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3275
3276         Unreviewed. Mark GTK+ test /webkit2/WebKitWebInspectorServer/test-open-debugging-session as slow.
3277
3278         It's timing out in the bots, but it seems to pass when running run-gtk-tests with no timeout. For GLib tests the
3279         timeout is applied per tester program not per test case, so we need to mark the whole test
3280         WebKit2Gtk/TestInspectorServer as slow.
3281
3282         * Scripts/run-gtk-tests:
3283         (TestRunner):
3284         (TestRunner._run_test_glib):
3285
3286 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3287
3288         Unreviewed. Skip media permission request GTK+ unit tests.
3289
3290         They are timing out in the bots.
3291
3292         * Scripts/run-gtk-tests:
3293         (TestRunner):
3294
3295 2016-05-31  Jer Noble  <jer.noble@apple.com>
3296
3297         Yet another unreviewed build fix; move the closing brace of the namespace declaration inside
3298         the #if check.
3299
3300         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3301
3302 2016-05-31  Jer Noble  <jer.noble@apple.com>
3303
3304         Further unreviewed build fix; only run FullscreenTopContentInset test on Mac.
3305
3306         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3307
3308 2016-05-31  Jer Noble  <jer.noble@apple.com>
3309
3310         Unreviewed build fix; only run FullscreetTopContentInset test on platforms
3311         where WK_API_ENABLED is set.
3312
3313         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3314
3315 2016-05-31  Jer Noble  <jer.noble@apple.com>
3316
3317         REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
3318         https://bugs.webkit.org/show_bug.cgi?id=158156
3319         <rdar://problem/26519589>
3320
3321         Reviewed by Darin Adler.
3322
3323         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3324         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added.
3325         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added.
3326         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3327         (TestWebKitAPI::TEST):
3328
3329 2016-05-31  Jon Lee  <jonlee@apple.com>
3330
3331         Unreviewed: add myself to the reviewers list.
3332
3333         * Scripts/webkitpy/common/config/contributors.json:
3334
3335 2016-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3336
3337         [GTK] Provide alternative mirror for the ICU tarball.
3338         https://bugs.webkit.org/show_bug.cgi?id=154530
3339
3340         Unreviewed.
3341
3342         * gtk/jhbuild.modules: After r201449 the GTK+ ARM buildbot is having
3343         a hard time trying to download the ICU tarball from download.icu-project.org
3344         (which redirects to sourceforge and gives problems with something related to
3345         SSL). Provide this alternative mirror to make things working back.
3346
3347 2016-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3348
3349         [GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing since r201423
3350         https://bugs.webkit.org/show_bug.cgi?id=158200
3351
3352         Reviewed by Philippe Normand.
3353
3354         This is because geolocation is no longer allowed for non secure sites, like HTTP. In that case
3355         POSITION_UNAVAILABLE is returned without asking the API layer.
3356
3357         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3358         (testWebViewGeolocationPermissionRequests): Keep the HTTP case to check that it indeed returns
3359         POSITION_UNAVAILABLE and use HTTPS URLs to check permission requests are allowed or denied. Also stop using the
3360         document title, and use user script messages that are more reliable instead.
3361
3362 2016-05-28  Aakash Jain  <aakash_jain@apple.com>
3363
3364         tests fail if display sleeps while run-webkit-tests is running
3365         https://bugs.webkit.org/show_bug.cgi?id=153919
3366
3367         Reviewed by Darin Adler.
3368
3369         * DumpRenderTree/mac/LayoutTestHelper.m:
3370         (addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool.
3371
3372 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3373
3374         Display failing JSC stress tests in buildbot dashboard
3375         https://bugs.webkit.org/show_bug.cgi?id=156595
3376
3377         Reviewed by Alexey Proskuryakov.
3378
3379         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3380         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
3381         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
3382         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3383         (BuildbotCombinedQueueView.prototype.update):
3384         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3385         (BuildbotIteration):
3386         (BuildbotIteration.prototype._parseData):
3387         (BuildbotIteration.prototype.loadLayoutTestResults):
3388         (BuildbotIteration.prototype.):
3389         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults):
3390         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3391         (BuildbotQueueView.prototype._createLoadingIndicator):
3392         (BuildbotQueueView.prototype.):
3393         (BuildbotQueueView.prototype._onPopoverCopy):
3394         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions):
3395         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions):
3396         (BuildbotQueueView.prototype._addIterationHeadingToPopover):
3397         (BuildbotQueueView.prototype._testStepFailureDescription):
3398         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount):
3399         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3400         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
3401         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3402         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
3403         (BuildbotTesterQueueView.prototype.update):
3404         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
3405         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions):
3406         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted.
3407         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted.
3408         (BuildbotTesterQueueView.prototype.): Deleted.
3409         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted.
3410         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:
3411         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
3412         (MockBuildbot):
3413         (MockBuildbot.prototype.buildPageURLForIteration):
3414         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
3415         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
3416         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
3417         (MockBuildbotQueue):
3418         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
3419         (MockBuildbotTestResults):
3420         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
3421         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
3422         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
3423
3424 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
3425
3426         Display failing JSC stress tests in buildbot dashboard
3427         https://bugs.webkit.org/show_bug.cgi?id=156595
3428
3429         Reviewed by Alexey Proskuryakov.
3430
3431         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
3432         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Generate the URL for raw JSON output of
3433         JSC tests.
3434         (Buildbot.prototype.javaScriptCoreTestStdioURLForIteration): Generate the URL for human-readable stdio output
3435         of JSC tests.
3436         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
3437         (BuildbotCombinedQueueView.prototype.update): Display JSC test results in popover.
3438         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
3439         (BuildbotIteration): Add javaScriptCoreTestResults variable.
3440         (BuildbotIteration.prototype.): Check for javascriptcore tests step.
3441         (BuildbotIteration.prototype.loadLayoutTestResults): Add comma at closing brace.
3442         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults): Fetch JSON from Buildbot server.
3443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
3444         (BuildbotQueueView.prototype._createLoadingIndicator): Reusable function.
3445         (BuildbotQueueView.prototype._onPopoverCopy): Reusable copy event handler to allow accurate copying of text
3446         from popovers.
3447         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Generates the popover bubble's
3448         inner HTML from the JSC failure data.
3449         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Generate the popover bubble
3450         for JSC results and handle request failures.
3451         (BuildbotQueueView.prototype._testStepFailureDescription): Moved from subclass.
3452         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount): Moved from subclass.
3453         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
3454         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Parse JSON into a list of failing tests.
3455         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
3456         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Instantiate PopoverTrackers for builds whose 
3457         only failures are JSC tests.
3458         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Use _onPopoverCopy.
3459         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Use _createLoadingIndicator.
3460         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted. Moved to superclass.
3461         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted. Moved to superclass.
3462         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted. Using superclass's reusable function as copy handler instead.
3463         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Add new script files.
3464         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Added.
3465         (MockBuildbot): Mocked version of Buildbot, only containing URL methods.
3466         (MockBuildbot.prototype.buildPageURLForIteration): Same as real Buildbot.js
3467         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Points to local file containing JSON for test.
3468         (MockBuildbot.prototype.javaScriptCoreTestStdioURLForIteration): Same as real Buildbot.js
3469         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
3470         (MockBuildbotQueue): Use a MockBuildbot() instead of a string.
3471         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Added.
3472         (MockBuildbotTestResults): Mocked version of BuildbotTestResults.
3473         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Sets the 'regressions' variable.
3474         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
3475         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Add four groups of tests.
3476
3477 2016-05-27  Chris Dumez  <cdumez@apple.com>
3478
3479         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables
3480         https://bugs.webkit.org/show_bug.cgi?id=158111
3481
3482         Reviewed by Darin Adler.
3483
3484         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables.
3485         These are often used cross-thread and copying the captured lambda variables can be
3486         dangerous (e.g. we do not want to copy a String after calling isolatedCopy() upon
3487         capture).
3488
3489         * WebKitTestRunner/TestController.cpp:
3490         (WTR::TestController::decidePolicyForNavigationAction):
3491
3492 2016-05-27  Brady Eidson  <beidson@apple.com>
3493
3494         Modern IDB: After closing a Netflix video, trying to watch it again fails.
3495         <rdar://problem/25092473> and https://bugs.webkit.org/show_bug.cgi?id=158160
3496
3497         Reviewed by Alex Christensen.
3498
3499         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3500         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Added.
3501         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Added.
3502         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Added.
3503
3504 2016-05-27  Joanmarie Diggs  <jdiggs@igalia.com>
3505
3506         AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416
3507         https://bugs.webkit.org/show_bug.cgi?id=158152
3508
3509         Reviewed by Chris Fleizach.
3510
3511         The failure is actually a bug fix because only one child is being added, but two
3512         notifications were being emitted. Now there is only one notification. To verify
3513         this was the case, we really should examine the child reportedly being added. That
3514         child is the ATK event's any_data, so pass along that child to the listener.
3515
3516         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3517
3518 2016-05-26  Alex Christensen  <achristensen@webkit.org>
3519
3520         Expose content extension failure error codes in SPI
3521         https://bugs.webkit.org/show_bug.cgi?id=158095
3522         rdar://problem/26475651
3523
3524         Reviewed by Anders Carlsson.
3525
3526         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
3527         (checkDomain):
3528         (TEST_F):
3529         Add tests that use the new enum.
3530
3531 2016-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
3532
3533         New intl-numberformat.js test fails on many Linux platforms
3534         https://bugs.webkit.org/show_bug.cgi?id=154530
3535
3536         Reviewed by Darin Adler.
3537
3538         The test is actually failing because of a bug in the icu version installed in the bots, using a newer version of
3539         icu makes the tests pass and explains why it worked for some people. So, let's add icu 55.1 to the internal
3540         jhbuild to ensure JSC tests pass in the bots no matter what the icu version installed is.
3541
3542         * gtk/jhbuild.modules:
3543
3544 2016-05-26  Yusuke Suzuki  <utatane.tea@gmail.com>
3545
3546         [JSC] Allow JSBench to use precise time
3547         https://bugs.webkit.org/show_bug.cgi?id=158050
3548
3549         Reviewed by Geoffrey Garen.
3550
3551         JSBench use `new Date().getTime()` without options and there is no way to use precise time.
3552         This patch modifies the JSBench code to inject the code taking the precise time.
3553         `currentTimeInMS` is given by the benchmerk harness and JSBench uses it.
3554         run-jsc-benchmark switches this function's implementation between `Date.now()` and
3555         testRunner's precise time one.
3556
3557         While this patch modifies the code of JSBench, the last release of JSBench is Jan 2013 and
3558         the contents are not changed for a long time. As described in the original paper[1], the
3559         tests can be generated by using JSBench's record & replay system, but in that case, we can
3560         adopt this modification by changing the tool side.
3561
3562         We also add currentTimeInMS implementation in harness.js and u?rem.js directly.
3563         u?rem.js implementation is required when it is executed in u?rem.html without harness.
3564         And harness.js implementation is required when it is executed in the JSBench's harness.
3565         In these implementation, we follow the JetStream's time measuring function: performance.now(),
3566         preciseTime(), or Date.now().
3567
3568         [1]: http://dl.acm.org/citation.cfm?id=2048119
3569
3570         * Scripts/run-jsc-benchmarks:
3571
3572 2016-05-26  Brent Fulgham  <bfulgham@apple.com>
3573
3574         Unreviewed test fix after r201427.
3575         https://bugs.webkit.org/show_bug.cgi?id=157423
3576         <rdar://problem/23751632>
3577
3578         A debug assertion was firing during some test runs due to the Geolocation permission
3579         being turned off during the test. The timer logic was originally written to assert
3580         if the timer fired when permissions were disabled. But this is no longer valid,
3581         because we expect the Geolocation system to be active and become deactivated if the
3582         browsing context violates one of the security criteria.
3583
3584         * DumpRenderTree/mac/UIDelegate.mm:
3585         (-[UIDelegate timerFired]): Remove invalid assertion.
3586
3587 2016-05-26  Filip Pizlo  <fpizlo@apple.com>
3588
3589         ScopedLambda should have a lifetime story that makes sense to the compiler
3590         https://bugs.webkit.org/show_bug.cgi?id=158118
3591
3592         Reviewed by Mark Lam.
3593         
3594         Added a test case. This test crashes before the fix and now it passes.
3595
3596         * TestWebKitAPI/CMakeLists.txt:
3597         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3598         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp: Added.
3599         (TestWebKitAPI::TEST):
3600
3601 2016-05-26  Myles C. Maxfield  <mmaxfield@apple.com>
3602
3603         Build fix
3604
3605         Rubber stamped by Lucas Forschler.
3606
3607         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
3608         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
3609
3610 2016-05-25  Anders Carlsson  <andersca@apple.com>
3611
3612         Get rid of WTF/Functional.h
3613         https://bugs.webkit.org/show_bug.cgi?id=158081
3614
3615         Reviewed by Chris Dumez.
3616
3617         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3618         * TestWebKitAPI/Tests/WTF/Functional.cpp: Removed.
3619         (TestWebKitAPI::returnFortyTwo): Deleted.
3620         (TestWebKitAPI::TEST): Deleted.
3621         (TestWebKitAPI::multiplyByTwo): Deleted.
3622         (TestWebKitAPI::multiplyByOneAndAHalf): Deleted.
3623         (TestWebKitAPI::multiply): Deleted.
3624         (TestWebKitAPI::subtract): Deleted.
3625         (TestWebKitAPI::A::A): Deleted.
3626         (TestWebKitAPI::A::f): Deleted.
3627         (TestWebKitAPI::A::addF): Deleted.
3628         (TestWebKitAPI::B::B): Deleted.
3629         (TestWebKitAPI::B::~B): Deleted.
3630         (TestWebKitAPI::B::ref): Deleted.
3631         (TestWebKitAPI::B::deref): Deleted.
3632         (TestWebKitAPI::B::f): Deleted.
3633         (TestWebKitAPI::B::g): Deleted.
3634         (TestWebKitAPI::Number::create): Deleted.
3635         (TestWebKitAPI::Number::~Number): Deleted.
3636         (TestWebKitAPI::Number::value): Deleted.
3637         (TestWebKitAPI::Number::Number): Deleted.
3638         (TestWebKitAPI::multiplyNumberByTwo): Deleted.
3639
3640 2016-05-25  Daniel Bates  <dabates@apple.com> and Brent Fulgham  <bfulgham@apple.com>
3641
3642         [WebSockets] No infrastructure for testing secure web sockets (wss)
3643         https://bugs.webkit.org/show_bug.cgi?id=157884
3644         <rdar://problem/26477197>
3645
3646         Reviewed by Andy Estes.
3647
3648         Add support to webkitpy to start and stop a secure Web Socket server running on port 9323
3649         using the certificate, private-key from file LayoutTests/http/conf/webki