Attempt to fix the tests.
[WebKit-https.git] / Tools / ChangeLog
1 2014-04-21  Sam Weinig  <sam@webkit.org>
2
3         Attempt to fix the tests.
4
5         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
6         (-[DidFailProvisionalNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
7         Add policy handler to override the new default of denying loads that NSURLConnection cannot handle.
8
9 2014-04-21  Filip Pizlo  <fpizlo@apple.com>
10
11         Unreviewed test gardening, make no-eager runs run everything except eager (as opposed to
12         being the same as a "quick run", which is meant for genuinely slow tests).
13
14         * Scripts/run-jsc-stress-tests:
15
16 2014-04-21  Darin Adler  <darin@apple.com>
17
18         Add HashSet::takeAny
19         https://bugs.webkit.org/show_bug.cgi?id=131928
20
21         Reviewed by Benjamin Poulain.
22
23         * TestWebKitAPI/Tests/WTF/HashSet.cpp: Added a test for takeAny.
24
25 2014-04-20  Dan Bernstein  <mitz@apple.com>
26
27         Fixed a test timing out after r167572.
28
29         * TestWebKitAPI/Tests/WebKit2Cocoa/Navigation.mm:
30         (-[NavigationDelegate webView:didFinishNavigation:]): Renamed from
31         -webView:didFinishLoadingNavigation:.
32
33 2014-04-20  Commit Queue  <commit-queue@webkit.org>
34
35         Unreviewed, rolling out r167510.
36         https://bugs.webkit.org/show_bug.cgi?id=131915
37
38         broke GTK Debug bot (Requested by philn on #webkit).
39
40         Reverted changeset:
41
42         "[GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force
43         it when running layout tests"
44         https://bugs.webkit.org/show_bug.cgi?id=131472
45         http://trac.webkit.org/changeset/167510
46
47 2014-04-18  Martin Robinson  <mrobinson@igalia.com>
48
49         [GTK] Add llvmpipe (Mesa) to the JHBuild moduleset and force it when running layout tests
50         https://bugs.webkit.org/show_bug.cgi?id=131472
51
52         Reviewed by Philippe Normand.
53
54         * Scripts/webkitpy/port/gtk.py:
55         (GtkPort.setup_environ_for_server): Use the LLVMPIPE_LIBGL_PATH to set the LD_LIBRARY_PATH
56         when running WebKitTestRunner with run-webkit-tests.
57         * gtk/jhbuild.modules: Add Mesa to the modulelist so that the llvmpipe libGL is build, but not
58         installed.
59         * gtk/jhbuildrc: Set the LLVMPIPE_LIBGL_PATH environment variable so that the test driver knows
60         how to properly set the LD_LIBRARY_PATH variable. We do this because it is much easier to
61         calculate the path in the jhbuildrc than in the test driver code. This simplifies things a great
62         deal.
63
64 2014-04-18  Alexey Proskuryakov  <ap@apple.com>
65
66         DownloadDecideDestinationCrash API test uses an incorrect value for path
67         https://bugs.webkit.org/show_bug.cgi?id=131845
68         <rdar://problem/15925560>
69
70         Reviewed by Enrica Casucci.
71
72         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
73         (TestWebKitAPI::decideDestinationWithSuggestedFilename):
74
75 2014-04-17  Alexey Proskuryakov  <ap@apple.com>
76
77         [Mac] AttributedStringTest API tests fail with async text input
78         https://bugs.webkit.org/show_bug.cgi?id=131833
79
80         Reviewed by Enrica Casucci.
81
82         Don't run sync NSTextInputClient tests where we don't implement these calls.
83
84         * TestWebKitAPI/Tests/mac/AttributedString.mm:
85         (TestWebKitAPI::AttributedStringTest_CustomFont::didLoadURL):
86         (TestWebKitAPI::AttributedStringTest_CustomFont::runSyncTest):
87         (TestWebKitAPI::AttributedStringTest_Strikethrough::didLoadURL):
88         (TestWebKitAPI::AttributedStringTest_Strikethrough::runSyncTest):
89         (TestWebKitAPI::AttributedStringTest_CustomFont::runTest): Deleted.
90         (TestWebKitAPI::AttributedStringTest_Strikethrough::runTest): Deleted.
91
92 2014-04-18  Philippe Normand  <pnormand@igalia.com>
93
94         Remove NETWORK_INFO support
95         https://bugs.webkit.org/show_bug.cgi?id=131841
96
97         Reviewed by Gyuyoung Kim.
98
99         * Scripts/webkitperl/FeatureList.pm:
100
101 2014-04-17  ChangSeok Oh  <changseok.oh@collabora.com>
102
103         [GTK] YouCompleteMe doesn't work for cmake build system.
104         https://bugs.webkit.org/show_bug.cgi?id=131591
105
106         Reviewed by Martin Robinson.
107
108         Add cmake build system support for YouCompleteMe. It should work regardless of
109         using make or ninja. In addition, autotools related code is removed since it's
110         not used anymore in WebKit.
111
112         * Scripts/webkitdirs.pm:
113         (generateBuildSystemFromCMakeProject):
114         * gtk/ycm_extra_conf.py:
115         (transform_relative_paths_to_absolute_paths):
116         (FlagsForFile):
117
118 2014-04-17  Anders Carlsson  <andersca@apple.com>
119
120         Fix build.
121
122         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
123         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
124         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
125
126 2014-04-17  Anders Carlsson  <andersca@apple.com>
127
128         Remove unused API enums
129         https://bugs.webkit.org/show_bug.cgi?id=131836
130
131         Reviewed by Tim Horton.
132
133         * MiniBrowser/mac/WK2BrowserWindowController.m:
134         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
135
136 2014-04-16  Brent Fulgham  <bfulgham@apple.com>
137
138         [Win] A few final cleanups to the DataObject classes.
139         https://bugs.webkit.org/show_bug.cgi?id=131784
140
141         Reviewed by Anders Carlsson.
142
143         * DumpRenderTree/win/DRTDataObject.cpp:
144         (DRTDataObject::clearData): Use 'last()' method.
145         * DumpRenderTree/win/UIDelegate.cpp:
146         (DRTUndoStack::pop): Use 'takeLast()' method.
147
148 2014-04-17  Andres Gomez  <agomez@igalia.com>
149
150         [Win] cygwin to keep installing curl 7.33.0-1 and subversion 1.7.14-1
151         https://bugs.webkit.org/show_bug.cgi?id=131365
152
153         Reviewed by Brent Fulgham.
154
155         The cygwin installer is now downloading the wanted versions for
156         the local installation given to the setup wizard.
157
158         * CygwinDownloader/cygwin-downloader.py:
159         * CygwinDownloader/cygwin-downloader.zip:
160
161 2014-04-17  Adrian Perez de Castro  <aperez@igalia.com>
162
163         [GTK] Make run-webkit-tests always use WKTR
164         https://bugs.webkit.org/show_bug.cgi?id=131737
165
166         Reviewed by Darin Adler.
167
168         Now that the GTK+ port only has support for WebKit2, instruct
169         run-webkit-tests to always use WKTR. This avoids needing to pass
170         flag "-2" every time.
171
172         * Scripts/webkitpy/layout_tests/run_webkit_tests.py: 
173         (_set_up_derived_options): Always set webkit_test_runner when
174         the platform is GTK+.
175
176 2014-04-17  Brendan Long  <b.long@cablelabs.com>
177
178         [Gtk] Install ninja-build in Tools/gtk/install-dependencies
179         https://bugs.webkit.org/show_bug.cgi?id=131760
180
181         Reviewed by Philippe Normand.
182
183         * gtk/install-dependencies: Install ninja-build when it's available.
184
185 2014-04-16  peavo@outlook.com  <peavo@outlook.com>
186
187         [Win] run-javascriptcore-tests fails to run.
188         https://bugs.webkit.org/show_bug.cgi?id=131761
189
190         Reviewed by Brent Fulgham.
191
192         * Scripts/build-jsc: For now, don't try to build bmalloc on Windows.
193
194 2014-04-16  Andres Gomez  <agomez@igalia.com>
195
196         [Win] Pass default parameters to cygwin setup wizard
197         https://bugs.webkit.org/show_bug.cgi?id=131361
198
199         Reviewed by Brent Fulgham.
200
201         Added some parameters to the cygwin setup wizard so the user
202         doesn't really have to do any interaction.
203
204         * CygwinDownloader/cygwin-downloader.py:
205         * CygwinDownloader/cygwin-downloader.zip:
206
207 2014-04-15  Brent Fulgham  <bfulgham@apple.com>
208
209         [Win] Eliminate use of deleteAllValues in Windows Files
210         https://bugs.webkit.org/show_bug.cgi?id=131631
211
212         Reviewed by Darin Adler.
213
214         Switch to std::unique_ptr for memory lifetime. Get rid of
215         deleteAllValues now that it is no longer needed. Use ranged
216         for loops where possible.
217
218         * DumpRenderTree/win/DRTDataObject.cpp:
219         (WCEnumFormatEtc::WCEnumFormatEtc):
220         (DRTDataObject::~DRTDataObject):
221         (DRTDataObject::GetData):
222         (DRTDataObject::QueryGetData):
223         (DRTDataObject::SetData):
224         (DRTDataObject::clearData):
225         * DumpRenderTree/win/DRTDataObject.h:
226         * DumpRenderTree/win/UIDelegate.cpp:
227         (DRTUndoObject::DRTUndoObject):
228         (DRTUndoObject::~DRTUndoObject):
229         (DRTUndoStack::~DRTUndoStack):
230         (DRTUndoStack::clear):
231         (DRTUndoStack::pop):
232         (DRTUndoManager::DRTUndoManager):
233         (DRTUndoManager::redo):
234         (DRTUndoManager::undo):
235         (UIDelegate::UIDelegate):
236         (UIDelegate::resetUndoManager):
237         * DumpRenderTree/win/UIDelegate.h:
238
239 2014-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
240
241         [GTK] Unreviewed GTK gardening.
242
243         Update list of skipped unit tests:
244
245           Skip test: WebKit2Gtk/TestWebKitWebView:/webkit2/WebKitWebView/page-visibility
246
247           Unskip tests: WebKit2/TestWebKit2:WebKit2.ResizeReversePaginatedWebView
248           and WebKit2/TestWebKit2:WebKit2.ScrollPinningBehaviors
249
250         * Scripts/run-gtk-tests:
251         (TestRunner):
252
253 2014-04-16  Tim Horton  <timothy_horton@apple.com>
254
255         check-webkit-style doesn't check code style in .mm or .m files
256         https://bugs.webkit.org/show_bug.cgi?id=131708
257
258         Reviewed by Darin Adler.
259
260         * Scripts/webkitpy/style/checker.py:
261         * Scripts/webkitpy/style/checker_unittest.py:
262         (CheckerDispatcherDispatchTest.test_cpp_paths):
263         (CheckerDispatcherDispatchTest.test_text_paths):
264         Check .mm and .m files as C++.
265
266         * Scripts/webkitpy/style/checkers/cpp.py:
267         (check_spacing):
268         Add an override for our ordinary "missing spaces around =" for @synthesize,
269         which should look like "@synthesize propertyName=_varName;"
270
271         Add an override for "missing space before {" for blocks' "^{".
272
273         Don't follow the "extra space before [" rule for Objective-C, because
274         it breaks this rule in a multitude of ways because of method calls.
275
276         (check_braces):
277         Don't complain about { not being on the end of the previous line if
278         the previous line starts with "- (" or "+ (", which would indicate a
279         Objective-C method definition.
280
281 2014-04-16  Darin Adler  <darin@apple.com>
282
283         Make Vector::takeLast work with move-only types (and optimize for types where move is faster)
284         https://bugs.webkit.org/show_bug.cgi?id=131735
285
286         Reviewed by Alexey Proskuryakov.
287
288         * TestWebKitAPI/Tests/WTF/Vector.cpp: Added a test for Vector::takeLast with move only types.
289         Fixed invocations of EXPECT macros so the expected value is on the left, and the test result
290         is on the right. This can be confusing since our JavaScript test framework does it the opposite
291         way, but gtest works better this way.
292
293 2014-04-15  Hyowon Kim  <hw1008.kim@samsung.com>
294
295         [EFL] Fix problems with the pixel dump.
296         https://bugs.webkit.org/show_bug.cgi?id=131265
297
298         Reviewed by Gyuyoung Kim.
299
300         Painting and compositing paths of WebKit-EFL were totally modified from r166768.
301         However pixel dump codes still call deprecated functions like ewk_view_paint(),
302         which causes that nothing is drawn.
303
304         This patch adds new member functions to AcceleratedCompositingContext to support pixel dump.
305         One of new functions is AcceleratedCompositingContext::extractImageData(),
306         which replaces deprecated function calls. Besides the extractImageData() is invoked by
307         ewk_view_screenshot_contents_get() in order to take the visible content displayed on the EFL webview.
308
309         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
310         (createBitmapContextFromWebView): Add to call DumpRenderTreeSupportEfl::forcePaint().
311
312 2014-04-15  Filip Pizlo  <fpizlo@apple.com>
313
314         Update LLVM export scrpt to handle the build directory being different from the
315         source directory.
316
317         Rubber stamped by Geoffrey Garen.
318
319         * Scripts/export-llvm-build:
320
321 2014-04-15  Ryosuke Niwa  <rniwa@webkit.org>
322
323         Update the hyperlink to waterfall views of perf bots on build.webkit.org
324         https://bugs.webkit.org/show_bug.cgi?id=131695
325
326         Reviewed by Antti Koivisto.
327
328         Updated.
329
330         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
331
332 2014-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
333
334         [GTK] Reduce the binary size by compressing the text based web inspector resources
335         https://bugs.webkit.org/show_bug.cgi?id=121545
336
337         Reviewed by Gustavo Noronha Silva.
338
339         Compress text based files when compiling inspector resources. It
340         reduces the binary size in 3MB.
341
342         * gtk/generate-inspector-gresource-manifest.py:
343         (find_all_files_in_directory):
344         (is_compressible):
345
346 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
347
348         Remove Gtk WebKit1 tester.
349
350         Gtk WebKit1 port no longer exists, and dashboard was trying to load its tester
351         results over and over as fast as it could.
352
353         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
354         (WebKitBuildbot):
355
356 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
357
358         Wrong link for webkitpy tests results in dashboard popover
359         https://bugs.webkit.org/show_bug.cgi?id=131664
360
361         Reviewed by Timothy Hatcher.
362
363         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
364         (BuildbotTesterQueueView.prototype._presentPopoverForMultipleFailureKinds):
365         Use a correct link.
366
367 2014-04-14  Alexey Proskuryakov  <ap@apple.com>
368
369         Update webkitpy regression test result that started to fail after http://trac.webkit.org/r167243
370
371         I'm not sure whether the changes are desirable, but am not suspicious enough to roll out.
372
373         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
374         (CommitMessageForThisCommitTest):
375
376 2014-04-14  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
377
378         Fix commit-log-editor bug revealed by r165447
379         https://bugs.webkit.org/show_bug.cgi?id=130676
380
381         Reviewed by Csaba Osztrogonác.
382
383         * Scripts/commit-log-editor:
384         (createCommitMessage): Omitting empty Source/JavaScriptCore:... blocks.
385         Add \n before the first block too, because the longest common prefix now ends with only one newline.
386         (removeLongestCommonPrefixEndingInNewline): The longest common prefix ends with only one newline,
387         now the last block of the common prefix isn't duplicated below. Changing the function name accordingly.
388
389 2014-04-13  Darin Adler  <darin@apple.com>
390
391         userVisibleString should not try to "encode" host names
392         https://bugs.webkit.org/show_bug.cgi?id=131587
393         rdar://problem/14686849
394
395         Reviewed by Alexey Proskuryakov.
396
397         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added URLExtras.mm.
398
399         * TestWebKitAPI/Tests/mac/URLExtras.mm: Added. A few tests for WebCoreNSURLExtras.
400         Coverage is tiny at this point; we could add a lot more cases!
401
402 2014-04-13  Jaehun Lim  <ljaehun.lim@samsung.com>
403
404         Use #include instead of #import
405         https://bugs.webkit.org/show_bug.cgi?id=131604
406
407         Reviewed by Darin Adler.
408
409         Fix "warning: #import is a deprecated GCC extension [-Wdeprecated]".
410
411         * TestWebKitAPI/Tests/WTF/StringView.cpp:
412
413 2014-04-12  Filip Pizlo  <fpizlo@apple.com>
414
415         Make slow-stress tests run faster by running fewer VM variants.
416
417         Rubber stamped by Geoffrey Garen.
418
419         * Scripts/run-javascriptcore-tests:
420         * Scripts/run-jsc-stress-tests:
421
422 2014-04-10  Zan Dobersek  <zdobersek@igalia.com>
423
424         [CMake] Add missing WTF unit tests
425         https://bugs.webkit.org/show_bug.cgi?id=131459
426
427         Reviewed by Martin Robinson.
428
429         * TestWebKitAPI/CMakeLists.txt: Add a few missing source files
430         that should be compiled into the TestWTF binary.
431
432 2014-04-10  Brendan Long  <b.long@cablelabs.com>
433
434         [Gtk] run-launcher doesn't work by default
435         https://bugs.webkit.org/show_bug.cgi?id=131494
436
437         Reviewed by Philippe Normand.
438
439         * Scripts/run-launcher: Always use MiniBrowser for WebKitGTK.
440         * Scripts/webkitdirs.pm:
441         (launcherName): Same.
442         * Scripts/webkitpy/style/checker.py: Remove reference to GtkLauncher.
443         * gtk/common.py:
444         (get_build_path.is_valid_build_directory): Same.
445         * gtk/manifest.txt: Same.
446
447 2014-04-09  Commit Queue  <commit-queue@webkit.org>
448
449         Unreviewed, rolling out r167046.
450         https://bugs.webkit.org/show_bug.cgi?id=131479
451
452         Caused 300+ failures on Mavericks WK1 tester (Requested by ap
453         on #webkit).
454
455         Reverted changeset:
456
457         "Remove "System Font" from whitelisted DRT fonts and char
458         width calculations"
459         https://bugs.webkit.org/show_bug.cgi?id=131411
460         http://trac.webkit.org/changeset/167046
461
462 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
463
464         Remove "System Font" from whitelisted DRT fonts and char width calculations
465         https://bugs.webkit.org/show_bug.cgi?id=131411
466
467         Reviewed by Tim Horton.
468
469         Covered by existing tests.
470
471         * DumpRenderTree/mac/DumpRenderTree.mm:
472         (allowedFontFamilySet):
473
474 2014-04-09  Myles C. Maxfield  <mmaxfield@apple.com>
475
476         systemHiddenFontFamilySet in DRT is unnecessary
477         https://bugs.webkit.org/show_bug.cgi?id=131414
478
479         Reviewed by Tim Horton.
480
481         It doesn't seem to affect test results on my machine.
482
483         * DumpRenderTree/mac/DumpRenderTree.mm:
484         (drt_NSFontManager_availableFonts):
485         (systemHiddenFontFamilySet): Deleted.
486
487 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
488
489         [Win] Unreviewed test fix: Don't double-release BSTR.
490
491         * DumpRenderTree/win/DumpRenderTree.cpp:
492         (dump): Remove unneeded call to SysFreeString now that we are
493         using _bstr_t for this variable.
494
495 2014-04-09  Brent Fulgham  <bfulgham@apple.com>
496
497         [Win] Various DumpRenderTree Fixes.
498         https://bugs.webkit.org/show_bug.cgi?id=131446.
499
500         Reviewed by Tim Horton.
501
502         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
503         (AccessibilityUIElement::title): Switch to _bstr_t. Use JSStringCreateWithBSTR.
504         (AccessibilityUIElement::description): Ditto.
505         (AccessibilityUIElement::helpText): Ditto.
506         (AccessibilityUIElement::intValue): Ditto.
507         (AccessibilityUIElement::isPressActionSupported): Ditto.
508         (AccessibilityUIElement::accessibilityValue): Ditto.
509         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
510         (DRTDesktopNotificationPresenter::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
511         (DRTDesktopNotificationPresenter::AddRef): Ditto.
512         (DRTDesktopNotificationPresenter::Release): Ditto.
513         (DRTDesktopNotificationPresenter::showDesktopNotification): Switch to _bstr_t. Use JSStringCreateWithBSTR.
514         (DRTDesktopNotificationPresenter::cancelDesktopNotification): Ditto.
515         (DRTDesktopNotificationPresenter::notificationDestroyed): Ditto.
516         (DRTDesktopNotificationPresenter::checkNotificationPermission): Ditto.
517         (DRTDesktopNotificationPresenter::requestNotificationPermission): Ditto.
518         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
519         * DumpRenderTree/win/DumpRenderTree.cpp:
520         (dumpFrameScrollPosition): Ditto.
521         (dumpFramesAsText): Ditto.
522         (compareHistoryItems): Ditto.
523         (dumpHistoryItem): Ditto.
524         (dump): Ditto.
525         (resetDefaultsToConsistentValues): Ditto.
526         (resetWebViewToConsistentStateBeforeTesting): Ditto.
527         (runTest): Ditto.
528         (createWebViewAndOffscreenWindow): Ditto.
529         * DumpRenderTree/win/EditingDelegate.cpp:
530         (EditingDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
531         (EditingDelegate::AddRef): Ditto.
532         (EditingDelegate::Release): Ditto.
533         (dumpPath): Switch to _bstr_t. Use JSStringCreateWithBSTR
534         (EditingDelegate::shouldBeginEditingInDOMRange): Get rid of uneeded STDMETHODCALLTYPE declaration.
535         (EditingDelegate::shouldEndEditingInDOMRange): Ditto.
536         (EditingDelegate::shouldInsertNode): Ditto.
537         (EditingDelegate::shouldInsertText): Ditto.
538         (EditingDelegate::shouldDeleteDOMRange): Ditto.
539         (EditingDelegate::shouldChangeSelectedDOMRange): Ditto.
540         (EditingDelegate::shouldApplyStyle): Ditto.
541         (EditingDelegate::shouldChangeTypingStyle): Ditto.
542         (EditingDelegate::doPlatformCommand): Ditto.
543         (EditingDelegate::webViewDidBeginEditing): Switch to _bstr_t. Use JSStringCreateWithBSTR.
544         (EditingDelegate::webViewDidChange): Ditto.
545         (EditingDelegate::webViewDidEndEditing): Ditto.
546         (EditingDelegate::webViewDidChangeTypingStyle): Ditto.
547         (EditingDelegate::webViewDidChangeSelection): Ditto.
548         (EditingDelegate::checkSpellingOfString): Ditto.
549         * DumpRenderTree/win/FrameLoadDelegate.cpp:
550         (descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
551         (FrameLoadDelegate::FrameLoadDelegate): Ditto.
552         (FrameLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
553         (FrameLoadDelegate::AddRef): Ditto.
554         (FrameLoadDelegate::Release): Ditto.
555         (FrameLoadDelegate::didStartProvisionalLoadForFrame): Switch to _bstr_t. Use JSStringCreateWithBSTR.
556         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame): Ditto.
557         (FrameLoadDelegate::didFailProvisionalLoadWithError): Ditto.
558         (FrameLoadDelegate::didCommitLoadForFrame): Ditto.
559         (FrameLoadDelegate::didReceiveTitle): Ditto.
560         (FrameLoadDelegate::didChangeIcons): Ditto.
561         (delegatesWithDelayedWork): Ditto.
562         (FrameLoadDelegate::didFinishLoadForFrame): Ditto.
563         (FrameLoadDelegate::didFailLoadWithError): Ditto.
564         (FrameLoadDelegate::willPerformClientRedirectToURL): Ditto.
565         (FrameLoadDelegate::didCancelClientRedirectForFrame): Ditto.
566         (FrameLoadDelegate::willCloseFrame): Ditto.
567         (FrameLoadDelegate::didFinishDocumentLoadForFrame): Ditto.
568         (FrameLoadDelegate::didHandleOnloadEventsForFrame): Ditto.
569         (FrameLoadDelegate::didFirstVisuallyNonEmptyLayoutInFrame): Ditto.
570         (FrameLoadDelegate::didDisplayInsecureContent): Ditto.
571         (FrameLoadDelegate::didRunInsecureContent): Ditto.
572         * DumpRenderTree/win/FrameLoadDelegate.h:
573         * DumpRenderTree/win/HistoryDelegate.cpp:
574         (HistoryDelegate::didNavigateWithNavigationData): Switch to _bstr_t. Use JSStringCreateWithBSTR.
575         (HistoryDelegate::updateHistoryTitle): Ditto.
576         (HistoryDelegate::populateVisitedLinksForWebView): Ditto.
577         * DumpRenderTree/win/PolicyDelegate.cpp:
578         (dumpPath):
579         (PolicyDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
580         (PolicyDelegate::AddRef): Ditto.
581         (PolicyDelegate::Release): Ditto.
582         (PolicyDelegate::decidePolicyForNavigationAction): Switch to _bstr_t. Use JSStringCreateWithBSTR.
583         (PolicyDelegate::unableToImplementPolicyWithError): Ditto.
584         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
585         (ResourceLoadDelegate::descriptionSuitableForTestResult): Switch to _bstr_t. Use JSStringCreateWithBSTR.
586         (ResourceLoadDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
587         (ResourceLoadDelegate::AddRef): Ditto.
588         (ResourceLoadDelegate::Release): Ditto.
589         (ResourceLoadDelegate::identifierForInitialRequest): Switch to _bstr_t. Use JSStringCreateWithBSTR.
590         (ResourceLoadDelegate::removeIdentifierForRequest): Ditto.
591         (ResourceLoadDelegate::willSendRequest): Ditto.
592         (ResourceLoadDelegate::didReceiveAuthenticationChallenge): Ditto.
593         (ResourceLoadDelegate::didReceiveResponse): Ditto.
594         (ResourceLoadDelegate::didFinishLoadingFromDataSource): Ditto.
595         (ResourceLoadDelegate::didFailLoadingWithError): Ditto.
596         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
597         (TestRunner::queueLoad): Switch to _bstr_t. Use JSStringCreateWithBSTR.
598         (TestRunner::setUserStyleSheetLocation): Ditto.
599         (TestRunner::execCommand): Ditto.
600         (TestRunner::overridePreference): Ditto.
601         (TestRunner::evaluateScriptInIsolatedWorld): Ditto.
602         * DumpRenderTree/win/TextInputControllerWin.cpp: Ditto.
603         (TextInputController::setMarkedText): Switch to _bstr_t. Use JSStringCreateWithBSTR.
604         (TextInputController::insertText): Ditto.
605         * DumpRenderTree/win/UIDelegate.cpp:
606         (UIDelegate::QueryInterface): Get rid of uneeded STDMETHODCALLTYPE declaration.
607         (UIDelegate::AddRef): Ditto.
608         (UIDelegate::Release): Ditto.
609         (UIDelegate::hasCustomMenuImplementation): Switch to _bstr_t. Use JSStringCreateWithBSTR.
610         (UIDelegate::trackCustomPopupMenu): Ditto.
611         (UIDelegate::registerUndoWithTarget): Ditto.
612         (UIDelegate::removeAllActionsWithTarget): Ditto.
613         (UIDelegate::setActionTitle): Ditto.
614         (UIDelegate::undo): Ditto.
615         (UIDelegate::redo): Ditto.
616         (UIDelegate::canUndo): Ditto.
617         (UIDelegate::canRedo): Ditto.
618         (UIDelegate::printFrame): Ditto.
619         (UIDelegate::ftpDirectoryTemplatePath): Ditto.
620         (UIDelegate::webViewHeaderHeight): Ditto.
621         (UIDelegate::webViewFooterHeight): Ditto.
622         (UIDelegate::drawHeaderInRect): Ditto.
623         (UIDelegate::drawFooterInRect): Ditto.
624         (UIDelegate::webViewPrintingMarginRect): Ditto.
625         (UIDelegate::canRunModal): Ditto.
626         (UIDelegate::createModalDialog): Ditto.
627         (UIDelegate::runModal): Ditto.
628         (UIDelegate::isMenuBarVisible): Ditto.
629         (UIDelegate::setMenuBarVisible): Ditto.
630         (UIDelegate::runDatabaseSizeLimitPrompt): Ditto.
631         (UIDelegate::paintCustomScrollbar): Ditto.
632         (UIDelegate::paintCustomScrollCorner): Ditto.
633         (UIDelegate::setFrame): Ditto.
634         (UIDelegate::webViewFrame): Ditto.
635         (UIDelegate::runJavaScriptAlertPanelWithMessage): Ditto.
636         (UIDelegate::runJavaScriptConfirmPanelWithMessage): Ditto.
637         (UIDelegate::runJavaScriptTextInputPanelWithPrompt): Ditto.
638         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
639         (UIDelegate::webViewAddMessageToConsole): Ditto.
640         (UIDelegate::doDragDrop): Ditto.
641         (UIDelegate::webViewGetDlgCode): Ditto.
642         (UIDelegate::createWebViewWithRequest): Ditto.
643         (UIDelegate::webViewClose): Ditto.
644         (UIDelegate::webViewFocus): Ditto.
645         (UIDelegate::webViewUnfocus): Ditto.
646         (UIDelegate::webViewPainted): Ditto.
647         (UIDelegate::exceededDatabaseQuota): Ditto.
648         (UIDelegate::embeddedViewWithArguments): Ditto.
649         (UIDelegate::webViewClosing): Ditto.
650         (UIDelegate::webViewSetCursor): Ditto.
651         (UIDelegate::webViewDidInvalidate): Ditto.
652         (UIDelegate::setStatusText): Ditto.
653         (UIDelegate::desktopNotificationsDelegate): Ditto.
654         (UIDelegate::drawBackground): Ditto.
655         (UIDelegate::decidePolicyForGeolocationRequest): Ditto.
656         (UIDelegate::didPressMissingPluginButton): Ditto.
657         * DumpRenderTree/win/WorkQueueItemWin.cpp: Ditto.
658         (LoadItem::invoke):  Switch to _bstr_t. Use JSStringCreateWithBSTR.
659         (LoadHTMLStringItem::invoke): Ditto.
660         (ScriptItem::invoke): Ditto.
661
662 2014-04-09  Gergo Balogh  <gbalogh.u-szeged@partner.samsung.com>
663
664         Stylechecker: False positive on inline asm code.
665         https://bugs.webkit.org/show_bug.cgi?id=130570
666
667         Reviewed by Csaba Osztrogonác.
668
669         Disable stylechecking in asm blocks.
670
671         * Scripts/webkitpy/style/checkers/cpp.py:
672         (process_line):
673         (_InlineASMState):
674         (_InlineASMState.__init__):
675         (_InlineASMState.process_line):
676         (_InlineASMState.isInside):
677         (_process_lines):
678         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
679         (WebKitStyleTest.test_member_initialization_list):
680
681 2014-04-09  Carlos Garcia Campos  <cgarcia@igalia.com>
682
683         [GTK] Move WebKit1 unit tests resources used by WebKit2 unit tests to WebKit2 resources dir
684         https://bugs.webkit.org/show_bug.cgi?id=131029
685
686         Reviewed by Philippe Normand.
687
688         Add blank.ico and test.pdf to resources dir of WebKit2Gtk unit
689         tests and remove the getWebKit1TestResoucesDir() method.
690
691         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
692         (testDownloadLocalFile): Use Test::getResourcesDir().
693         (testDownloadLocalFileError): Ditto.
694         (serverCallback): Ditto.
695         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
696         (serverCallback): Ditto.
697         * TestWebKitAPI/Tests/WebKit2Gtk/TestSSL.cpp:
698         (httpServerCallback): Ditto.
699         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
700         (serverCallback): Ditto.
701         * TestWebKitAPI/Tests/WebKit2Gtk/resources/blank.ico: Added.
702         * TestWebKitAPI/Tests/WebKit2Gtk/resources/test.pdf: Added.
703         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
704         (Test::getWebKit1TestResoucesDir): Deleted.
705
706 2014-04-09  Alexey Proskuryakov  <ap@apple.com>
707
708         [WK2] HTTP authentication regression tests fail
709         https://bugs.webkit.org/show_bug.cgi?id=81627
710         <rdar://problem/11079296>
711
712         Reviewed by Anders Carlsson.
713
714         * WebKitTestRunner/TestController.h:
715         * WebKitTestRunner/TestController.cpp:
716         (WTR::TestController::createWebViewWithOptions): Added canAuthenticateAgainstProtectionSpaceInFrame
717         to pageLoaderClient structure.
718         (WTR::TestController::canAuthenticateAgainstProtectionSpaceInFrame): Return true
719         for password based authentication (we do get server trust challenges on some tests,
720         which WKTR can't handle).
721         When this client call is not implemented or returns false, didReceiveAuthenticationChallengeInFrame
722         calls won't be made, at least on CFNetwork based platforms.
723         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Changed the output
724         to omit <unknown>. The resource is always unknown with WK2, and it doesn't really
725         make sense to associate auth requests with individual resources - there can be
726         multiple resources loading at once from the same protection space, so WebKit1 API
727         that had a resource identifier was inherently racy.
728
729 2014-04-09  Ryuan Choi  <ryuan.choi@samsung.com>
730
731         [EFL] Change font path for DumpRenderTree and WebKitTestRunner
732         https://bugs.webkit.org/show_bug.cgi?id=131427
733
734         Reviewed by Gyuyoung Kim.
735
736         Since r166973, font path was changed.
737
738         * DumpRenderTree/PlatformEfl.cmake:
739         * WebKitTestRunner/PlatformEfl.cmake:
740
741 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
742
743         Fix the build-jsc build
744         https://bugs.webkit.org/show_bug.cgi?id=131410
745
746         Reviewed by Michael Saboff.
747
748         * Scripts/build-jsc: Make sure to build bmalloc before WTF, since
749         WTF depends on it.
750
751 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
752
753         [GTK] Remove WebKit1 unit tests
754         https://bugs.webkit.org/show_bug.cgi?id=131359
755
756         Reviewed by Anders Carlsson.
757
758         Remove all WebKit1 GTK+ unit tests, in preparation for removing the WebKit1 port
759         entirely. We also remove the list of skipped WebKi1 tests from run-gtk-tests, as
760         they were inadvertently left in http://trac.webkit.org/changeset/166504.
761
762         * CMakeLists.txt: No longer load the WebKit1 unit test CMakeLists.txt file.
763         * Scripts/run-gtk-tests: Remove skipped WebKit1 unit tests.
764         * TestWebKitAPI/Tests/WebKitGtk/CMakeLists.txt: Removed.
765         * TestWebKitAPI/Tests/WebKitGtk/resources/blank.ico: Removed.
766         * TestWebKitAPI/Tests/WebKitGtk/resources/test.html: Removed.
767         * TestWebKitAPI/Tests/WebKitGtk/resources/test.ogg: Removed.
768         * TestWebKitAPI/Tests/WebKitGtk/resources/test.pdf: Removed.
769         * TestWebKitAPI/Tests/WebKitGtk/resources/test.txt: Removed.
770         * TestWebKitAPI/Tests/WebKitGtk/test_utils.c: Removed.
771         * TestWebKitAPI/Tests/WebKitGtk/test_utils.h: Removed.
772         * TestWebKitAPI/Tests/WebKitGtk/testapplicationcache.c: Removed.
773         * TestWebKitAPI/Tests/WebKitGtk/testatk.c: Removed.
774         * TestWebKitAPI/Tests/WebKitGtk/testatkroles.c: Removed.
775         * TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c: Removed.
776         * TestWebKitAPI/Tests/WebKitGtk/testcopyandpaste.c: Removed.
777         * TestWebKitAPI/Tests/WebKitGtk/testdomdocument.c: Removed.
778         * TestWebKitAPI/Tests/WebKitGtk/testdomdomwindow.c: Removed.
779         * TestWebKitAPI/Tests/WebKitGtk/testdomnode.c: Removed.
780         * TestWebKitAPI/Tests/WebKitGtk/testdownload.c: Removed.
781         * TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c: Removed.
782         * TestWebKitAPI/Tests/WebKitGtk/testglobals.c: Removed.
783         * TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c: Removed.
784         * TestWebKitAPI/Tests/WebKitGtk/testhttpbackend.c: Removed.
785         * TestWebKitAPI/Tests/WebKitGtk/testkeyevents.c: Removed.
786         * TestWebKitAPI/Tests/WebKitGtk/testloading.c: Removed.
787         * TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c: Removed.
788         * TestWebKitAPI/Tests/WebKitGtk/testnetworkrequest.c: Removed.
789         * TestWebKitAPI/Tests/WebKitGtk/testnetworkresponse.c: Removed.
790         * TestWebKitAPI/Tests/WebKitGtk/testwebbackforwardlist.c: Removed.
791         * TestWebKitAPI/Tests/WebKitGtk/testwebdatasource.c: Removed.
792         * TestWebKitAPI/Tests/WebKitGtk/testwebframe.c: Removed.
793         * TestWebKitAPI/Tests/WebKitGtk/testwebhistoryitem.c: Removed.
794         * TestWebKitAPI/Tests/WebKitGtk/testwebinspector.c: Removed.
795         * TestWebKitAPI/Tests/WebKitGtk/testwebplugindatabase.c: Removed.
796         * TestWebKitAPI/Tests/WebKitGtk/testwebresource.c: Removed.
797         * TestWebKitAPI/Tests/WebKitGtk/testwebsettings.c: Removed.
798         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Removed.
799         * TestWebKitAPI/Tests/WebKitGtk/testwindow.c: Removed.
800
801 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
802
803         Unreviewed gardening (Take 2): Prevent users from attempting
804         to build with known invalid cURL. 
805
806         * Scripts/webkitdirs.pm:
807         (checkInstalledTools): Check for 7.34.0 (the broken version), not
808         7.33.0 (the known good version).
809
810 2014-04-08  Martin Robinson  <mrobinson@igalia.com>
811
812         [GTK] Remove DumpRenderTree and GtkLauncher
813         https://bugs.webkit.org/show_bug.cgi?id=131373
814
815         Reviewed by Andreas Kling.
816
817         Remove the GTK+ port of DumpRenderTree and GtkLauncher. These tools are
818         no longer necessary now that WebKit1 GTK+ will be removed.
819
820         * CMakeLists.txt:
821         * DumpRenderTree/PlatformGTK.cmake: Removed.
822         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp: Removed.
823         * DumpRenderTree/gtk/DumpRenderTree.cpp: Removed.
824         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Removed.
825         * DumpRenderTree/gtk/EditingCallbacks.cpp: Removed.
826         * DumpRenderTree/gtk/EditingCallbacks.h: Removed.
827         * DumpRenderTree/gtk/EventSender.cpp: Removed.
828         * DumpRenderTree/gtk/EventSender.h: Removed.
829         * DumpRenderTree/gtk/GCControllerGtk.cpp: Removed.
830         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Removed.
831         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Removed.
832         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Removed.
833         * DumpRenderTree/gtk/TestRunnerGtk.cpp: Removed.
834         * DumpRenderTree/gtk/TextInputController.cpp: Removed.
835         * DumpRenderTree/gtk/TextInputController.h: Removed.
836         * DumpRenderTree/gtk/WorkQueueItemGtk.cpp: Removed.
837         * GtkLauncher/CMakeLists.txt: Removed.
838         * GtkLauncher/LauncherInspectorWindow.c: Removed.
839         * GtkLauncher/LauncherInspectorWindow.h: Removed.
840         * GtkLauncher/main.c: Removed.
841         * GtkLauncher/simple.svg: Removed.
842         * GtkLauncher/text.html: Removed.
843         * WebKitTestRunner/PlatformGTK.cmake:
844         * WebKitTestRunner/gtk/fonts/AHEM____.TTF: Renamed from Tools/DumpRenderTree/gtk/fonts/AHEM____.TTF.
845         * WebKitTestRunner/gtk/fonts/FontWithNoValidEncoding.fon: Renamed from Tools/DumpRenderTree/gtk/fonts/FontWithNoValidEncoding.fon.
846         * WebKitTestRunner/gtk/fonts/fonts.conf: Renamed from Tools/DumpRenderTree/gtk/fonts/fonts.conf.
847
848 2014-04-08  Mark Rowe  <mrowe@apple.com>
849
850         XPC services launched by Safari have wrong DYLD_FRAMEWORK_PATH set when launched via run-safari / debug-safari
851         <https://webkit.org/b/131388> / <rdar://problem/16291687>
852
853         Reviewed by Alexey Proskuryakov.
854
855         * Scripts/webkitdirs.pm:
856         (runMacWebKitApp): Set __XPC_DYLD_FRAMEWORK_PATH to the absolute path to the built products directory.
857         (execMacWebKitAppForDebugging): Ditto.
858
859 2014-04-08  Geoffrey Garen  <ggaren@apple.com>
860
861         Build bmalloc on iOS too
862         https://bugs.webkit.org/show_bug.cgi?id=131381
863
864         Reviewed by Andreas Kling.
865
866         * Scripts/build-webkit:
867
868 2014-04-08  Brent Fulgham  <bfulgham@apple.com>
869
870         Unreviewed gardening: Prevent users from attempting
871         to build with known invalid cURL.
872
873         * Scripts/webkitdirs.pm:
874         (checkInstalledTools): Block build attempts with bad
875         Cygwin tool set.
876
877 2014-04-07  Geoffrey Garen  <ggaren@apple.com>
878
879         Build bmalloc on Mac
880         https://bugs.webkit.org/show_bug.cgi?id=131333
881
882         Reviewed by Mark Rowe.
883
884         * Scripts/build-webkit: Add the bmalloc target if we're on Mac.
885         (Note: Just testing Mac is not good enough because in this
886         script 'Mac' means 'Mac or iOS'.)
887
888 2014-03-30  Filip Pizlo  <fpizlo@apple.com>
889
890         Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
891         https://bugs.webkit.org/show_bug.cgi?id=130951
892
893         Reviewed by Geoffrey Garen.
894
895         * Scripts/run-javascriptcore-tests:
896
897 2014-04-06  Darin Adler  <darin@apple.com>
898
899         Rework CSS calc logic, fixing some reference count mistakes in Length
900         https://bugs.webkit.org/show_bug.cgi?id=131280
901
902         Reviewed by Andreas Kling.
903
904         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added CalculationValue.cpp.
905         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp: Added.
906
907 2014-04-04  Brian J. Burg  <burg@cs.washington.edu>
908
909         Enable WEB_REPLAY for PLATFORM(MAC)
910         https://bugs.webkit.org/show_bug.cgi?id=130700
911
912         Reviewed by Timothy Hatcher.
913
914         * Scripts/webkitperl/FeatureList.pm: Set the default for WEB_REPLAY for OS X engineering builds.
915
916 2014-04-05  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
917
918         [CMake] Include X11's include dirs in TestNetscapePlugin
919         https://bugs.webkit.org/show_bug.cgi?id=131270
920
921         Reviewed by Martin Robinson.
922
923         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Include X11_INCLUDE_DIR since
924         TestNetscapePlugin includes WebCore code that includes X headers.
925
926 2014-04-05  David Kilzer  <ddkilzer@apple.com>
927
928         REGRESSION (r166529): Fix build after renaming TileCache to LegacyTileCache
929         <http://webkit.org/b/130986>
930
931         * Scripts/check-for-inappropriate-objc-class-names: Add 'Legacy'
932         prefix to TileCache class names in exception list.
933
934 2014-04-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
935
936         [GTK] kill-old-processes should kill dbus-daemon processes
937         https://bugs.webkit.org/show_bug.cgi?id=127352
938
939         Reviewed by Martin Robinson.
940
941         * BuildSlaveSupport/kill-old-processes:
942         (main):
943
944 2014-04-04  Andres Gomez  <agomez@igalia.com>
945
946         [Win] Update obsolete packages in cygwin
947         https://bugs.webkit.org/show_bug.cgi?id=126264
948
949         Reviewed by Brent Fulgham.
950
951         Removed "apache" and "minires" as the first has been replaced by
952         "lighttpd" and the second is now integrated into
953         "cygwin". Replaced the transitional and now obsolete "gcc" package
954         with "gcc-g++" and ensure that "python" stays at version "2.6.8"
955         since the newer version available is "2.7.3" which breaks the
956         build due to some funniness with environment variable handling.
957
958         * CygwinDownloader/cygwin-downloader.py:
959         * CygwinDownloader/cygwin-downloader.zip:
960
961 2014-04-03  Joseph Pecoraro  <pecoraro@apple.com>
962
963         check-webkit-style: Improve warnings on Objective-C @property syntax
964         https://bugs.webkit.org/show_bug.cgi?id=131200
965
966         Reviewed by Dan Bernstein.
967
968         * Scripts/webkitpy/style/checkers/cpp.py:
969         (check_spacing):
970         (CppChecker):
971         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
972         (CppStyleTest.test_spacing_in_objective_c_properties):
973
974 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
975
976         Unreviewed. Moving my name to commiter section
977
978         * Scripts/webkitpy/common/config/contributors.json:
979
980 2014-04-03  Santosh Mahto  <santoshbit2007@gmail.com>
981
982         Unreviewed. Add myself as a committer.
983
984         * Scripts/webkitpy/common/config/contributors.json:
985
986 2014-04-03  Andrzej Badowski  <a.badowski@samsung.com>
987
988         [EFL][WK2] Replacing zoom functionality of MiniBrowser from scale_set to page_zoom_set.
989         https://bugs.webkit.org/show_bug.cgi?id=130391
990
991         Reviewed by Gyuyoung Kim.
992
993         Change the implementation of the zoom functionality from ewk_view_scale_set
994         to ewk_view_page_zoom_set.
995
996         * MiniBrowser/efl/main.c:
997
998 2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
999
1000         [webkitpy] perf profiler does not understand --call-graph argument
1001         https://bugs.webkit.org/show_bug.cgi?id=131132
1002
1003         Reviewed by Ryosuke Niwa.
1004
1005         New versions of perf profiler have changed the argument from --call-graph to -g.
1006
1007         * Scripts/webkitpy/common/system/profiler.py:
1008         (Perf.wrapper_arguments): Use -g instead of --call-graph.
1009         * Scripts/webkitpy/port/driver_unittest.py:
1010         (DriverTest.test_profiler_as_wrapper): Update test accordingly.
1011
1012 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1013
1014         Add EFL WK2 performance bot to build.webkit.org
1015         https://bugs.webkit.org/show_bug.cgi?id=131034
1016
1017         Fix after r166707, use "Perf" instead of "perf" for consistency.
1018
1019         Reviewed by Csaba Osztrogonác.
1020
1021         * BuildSlaveSupport/build.webkit.org-config/config.json:
1022
1023 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
1024
1025         Add EFL WK2 performance bot to build.webkit.org
1026         https://bugs.webkit.org/show_bug.cgi?id=131034
1027
1028         Reviewed by Csaba Osztrogonác.
1029
1030         * BuildSlaveSupport/build.webkit.org-config/config.json:
1031
1032 2014-04-02  Ryuan Choi  <ryuan.choi@samsung.com>
1033
1034         [EFL][WK1] Use Evas_Touch_Point_State instead of Ewk_Touch_Point_Type
1035         https://bugs.webkit.org/show_bug.cgi?id=131151
1036
1037         Reviewed by Gyuyoung Kim.
1038
1039         * DumpRenderTree/efl/EventSender.cpp: Replace Ewk_Touch_Point_Type to Evas_Touch_Point_State.
1040         (TouchEventInfo::TouchEventInfo):
1041         (sendTouchEvent):
1042         (addTouchPointCallback):
1043         (updateTouchPointCallback):
1044         (cancelTouchPointCallback):
1045         (releaseTouchPointCallback):
1046
1047 2014-04-02  David Kilzer  <ddkilzer@apple.com>
1048
1049         filter-build-webkit: Ignore xcodebuild warnings when compiling with newer builds of clang
1050         <http://webkit.org/b/131045>
1051
1052         Reviewed by Daniel Bates.
1053
1054         * Scripts/filter-build-webkit:
1055         (shouldIgnoreLine): Ignore DVTAssertions related to new builds
1056         of clang, plus debug data for all DVTAssertions.
1057
1058 2014-04-01  Dean Jackson  <dino@apple.com>
1059
1060         Load Media Controls js/css from bundle
1061         https://bugs.webkit.org/show_bug.cgi?id=131086
1062
1063         Reviewed by Eric Carlson.
1064
1065         We're now putting CSS files into the bundle, so remove the test for them.
1066
1067         * Scripts/check-for-inappropriate-files-in-framework:
1068
1069 2014-04-02  Martin Hock  <mhock@apple.com>
1070
1071         Unify private browsing with sessions.
1072         https://bugs.webkit.org/show_bug.cgi?id=130099
1073
1074         Reviewed by Alexey Proskuryakov.
1075
1076         Add an API test for ephemeral sessions similar to PrivateBrowsingPushStateNoHistoryCallback.
1077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1078         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
1079         (TestWebKitAPI::didNavigateWithNavigationData):
1080         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1081         (TestWebKitAPI::TEST):
1082
1083         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Also test to make sure private browsing can be disabled.
1084         (TestWebKitAPI::didNavigateWithoutNavigationData):
1085         (TestWebKitAPI::didNavigateWithNavigationData):
1086         (TestWebKitAPI::didSameDocumentNavigationForFrame):
1087         (TestWebKitAPI::TEST):
1088
1089 2014-04-02  Martin Robinson  <mrobinson@igalia.com>
1090
1091         REGRESSION(r165704): [GTK] Inspector resources not correctly generated
1092         https://bugs.webkit.org/show_bug.cgi?id=130343
1093
1094         Reviewed by Gustavo Noronha Silva.
1095
1096         * gtk/generate-inspector-gresource-manifest.py: Instead of hard-coding the file list, accept a list
1097         of directories on the command line and look for all appropriate files in those directories for the
1098         GResource archive. Also make archive paths relative to those directories.
1099         (find_all_files_in_directory): This helper looks for all the appropriate files in a given directory.
1100         (find_all_files_in_directory.select_file): Whether or not to add the file to the archive.
1101
1102 2014-04-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1103
1104         [webkitpy] Avoid multiple "Preparing rollout for bug" log messages
1105         https://bugs.webkit.org/show_bug.cgi?id=131106
1106
1107         Reviewed by Csaba Osztrogonác.
1108
1109         * Scripts/webkitpy/tool/commands/download.py:
1110         (AbstractRolloutPrepCommand._prepare_state):
1111         * Scripts/webkitpy/tool/commands/download_unittest.py:
1112         (test_prepare_rollout):
1113         (test_create_rollout):
1114         (test_create_rollout_resolved):
1115         (test_rollout):
1116
1117 2014-04-02  Krzysztof Wolanski  <k.wolanski@samsung.com>
1118
1119         [EFL] Add option to use separate web process for new window in MiniBrowser
1120         https://bugs.webkit.org/show_bug.cgi?id=130190
1121
1122         Reviewed by Gyuyoung Kim.
1123
1124         New created window (CTRL + n) will be open in separated web process.
1125         This option is enabled by adding a flag (S/separate-process) with launching
1126         MiniBrowser.
1127
1128         * MiniBrowser/efl/main.c:
1129         (elm_main):
1130
1131 2014-04-02  Carlos Garcia Campos  <cgarcia@igalia.com>
1132
1133         [GTK] Move NEWS file to a new location
1134         https://bugs.webkit.org/show_bug.cgi?id=130901
1135
1136         Reviewed by Brent Fulgham.
1137
1138         * gtk/manifest.txt: Update the NEWS file path.
1139
1140 2014-04-01  Anders Carlsson  <andersca@apple.com>
1141
1142         Fix build.
1143
1144         * MiniBrowser/mac/WK2BrowserWindowController.m:
1145         (-[WK2BrowserWindowController awakeFromNib]):
1146         (-[WK2BrowserWindowController dealloc]):
1147         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
1148
1149 2014-04-01  Brent Fulgham  <bfulgham@apple.com>
1150
1151         Unreviewed test gardening.
1152
1153         * Scripts/webkitpy/port/base_unittest.py:
1154         (PortTest.test_build_path): Handle the Debug case so we don't get webkitpy-test failures on our test bots.
1155
1156 2014-04-01  Zoltan Horvath  <zoltan@webkit.org>
1157
1158         [CSS Exclusions] Remove exclusions parsing support
1159         https://bugs.webkit.org/show_bug.cgi?id=131046
1160
1161         Reviewed by David Hyatt.
1162
1163         * Scripts/webkitperl/FeatureList.pm:
1164
1165 2014-04-01  Manuel Rego Casasnovas  <rego@igalia.com>
1166
1167         [GTK] Remove last reference to GTK+ WK1 EWS
1168         https://bugs.webkit.org/show_bug.cgi?id=131058
1169
1170         Reviewed by Martin Robinson.
1171
1172         In r166427 WK1 GTK+ bots and EWS where removed, but this file was missing.
1173
1174         * QueueStatusServer/config/queues.py: Remove reference to GTK+ WK1 EWS.
1175
1176 2014-04-01  Lucas Forschler  <lforschler@apple.com>
1177
1178         Add a 32bit JSC builder/tester.
1179         https://bugs.webkit.org/show_bug.cgi?id=131054
1180         
1181         Reviewed by Michael Saboff.
1182
1183         * BuildSlaveSupport/build.webkit.org-config/config.json:
1184         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1185         (Compile32bitJSC):
1186         (Run32bitJSCTests):
1187         (Run32bitJSCTests.countFailures):
1188         (BuildAndTest32bitJSCFactory):
1189         (BuildAndTest32bitJSCFactory.__init__):
1190
1191 2014-04-01  Martin Robinson  <mrobinson@igalia.com>
1192
1193         [GTK] No longer build WebKit1 gtkdoc
1194         https://bugs.webkit.org/show_bug.cgi?id=130970
1195
1196         Reviewed by Anders Carlsson.
1197
1198         * gtk/common.py:
1199         (gtk_version_of_pkg_config_file): Deleted.
1200         * gtk/generate-gtkdoc:
1201         (get_gtkdoc_module_paths): We no longer need to worry about GTK+ 2, since it
1202         was only applicable for WebKit1.
1203         (get_generator_for_config): No longer look for the WebKit1 configuration file.
1204
1205 2014-04-01  Mario Sanchez Prada  <mario.prada@samsung.com>
1206
1207         [GTK] Running minibrowser with url crashes in debug build
1208         https://bugs.webkit.org/show_bug.cgi?id=130492
1209
1210         Reviewed by Martin Robinson.
1211
1212         Update "uri-scheme" test not to use invalid URIs in it, so we
1213         don't get a mistmatch when comparing the original URI stored in
1214         the test class with the one returned by the WebKitWebView.
1215
1216         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1217         (testWebContextURIScheme): Update the test.
1218
1219 2014-04-01  Mihai Tica  <mitica@adobe.com>
1220
1221         Unreviewed: Add myself as a commiter to the contributors list.
1222
1223         * Scripts/webkitpy/common/config/contributors.json:
1224
1225 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1226
1227         [EFL][WK2] Extract the control of page background out of color_set
1228         https://bugs.webkit.org/show_bug.cgi?id=127539
1229
1230         Reviewed by Gyuyoung Kim.
1231
1232         Added an option(C) to change background color.
1233
1234         * MiniBrowser/efl/main.c:
1235         (window_create):
1236         (elm_main):
1237
1238 2014-03-31  Ryuan Choi  <ryuan.choi@samsung.com>
1239
1240         Unreviewed build fix on the EFL port with latest EFL libraries since r166149
1241
1242         * ImageDiff/PlatformEfl.cmake: Added ECORE_IMF_INCLUDE_DIRS to include dirs
1243
1244 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1245
1246         Unreviewed test correction after r166530.
1247
1248         * DumpRenderTree/mac/DumpRenderTree.mm:
1249         (setDefaultsToConsistentValuesForTesting): No need to change preference for all tests. We set the proper
1250         fine-grained setting for swipe tests. This prevents existing tests from breaking.
1251
1252 2014-03-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1253
1254         Remove the trigger for webkit1 tests on the gtk-linux-64-release bot
1255         https://bugs.webkit.org/show_bug.cgi?id=130987
1256
1257         r166427 removed the WebKit1 GTK+ bots, so we don't longer need to
1258         trigger the webkit1 bot tests on the gtk-linux-64-release bot.
1259
1260         Reviewed by Martin Robinson.
1261
1262         * BuildSlaveSupport/build.webkit.org-config/config.json:
1263
1264 2014-03-31  Dean Jackson  <dino@apple.com>
1265
1266         Remove WEB_ANIMATIONS
1267         https://bugs.webkit.org/show_bug.cgi?id=130989
1268
1269         Reviewed by Simon Fraser.
1270
1271         Remove this feature flag until we plan to implement.
1272
1273         * Scripts/webkitperl/FeatureList.pm:
1274
1275 2014-03-31  Brent Fulgham  <bfulgham@apple.com>
1276
1277         Reduced Latched Scroll Test Flakiness
1278         https://bugs.webkit.org/show_bug.cgi?id=130983
1279
1280         Reviewed by Darin Adler.
1281
1282         * DumpRenderTree/mac/DumpRenderTree.mm:
1283         (setDefaultsToConsistentValuesForTesting): Test user should have 'high resolution' scrolling.
1284         * DumpRenderTree/mac/EventSendingController.mm:
1285         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]): Generate mouse wheel events
1286         with high resolution flags turned on.
1287         * WebKitTestRunner/mac/EventSenderProxy.mm:
1288         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases): Ditto.
1289
1290 2014-03-31  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1291
1292         run-webkit-tests should have a --no-timeout option
1293         https://bugs.webkit.org/show_bug.cgi?id=128286
1294
1295         Reviewed by Joseph Pecoraro.
1296
1297         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
1298         (Worker._run_test): Renaming _run_test_with_timeout()
1299         (Worker._run_test_with_or_without_timeout): Renaming _run_test_with_timeout(), because tests can now run without timeout.
1300         (Worker._run_test_in_another_thread): Passing the --no-timeout option to the driver
1301         (Worker._run_test_in_this_thread):
1302         (Worker._run_test_with_timeout): Deleted.
1303         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1304         (parse_args): Added the --no-timeout option
1305
1306 2014-03-31  Samuel White  <samuel_white@apple.com>
1307
1308         AX: Need ability to get line range for text marker.
1309         https://bugs.webkit.org/show_bug.cgi?id=130906
1310
1311         Reviewed by Chris Fleizach.
1312
1313         Added a new function in DRT and TestRunner to test that AXLineTextMarkerRangeForTextMarker works as expected.
1314
1315         * DumpRenderTree/AccessibilityUIElement.cpp:
1316         (lineTextMarkerRangeForTextMarkerCallback):
1317         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1318         (AccessibilityUIElement::getJSClass):
1319         * DumpRenderTree/AccessibilityUIElement.h:
1320         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
1321         (AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1322         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
1323         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1324         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1325         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1326         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1327         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1328         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1329         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1330         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1331         (WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
1332
1333 2014-03-31  Filip Pizlo  <fpizlo@apple.com>
1334
1335         More validation for FTL inline caches
1336         https://bugs.webkit.org/show_bug.cgi?id=130948
1337
1338         Reviewed by Geoffrey Garen.
1339
1340         * Scripts/run-jsc-stress-tests:
1341
1342 2014-03-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1343
1344         [GTK] Do not run WebKit1 unit tests by default
1345         https://bugs.webkit.org/show_bug.cgi?id=130968
1346
1347         Reviewed by Martin Robinson.
1348
1349         * Scripts/run-gtk-tests:
1350         (TestRunner):
1351
1352 2014-03-31  Martin Robinson  <mrobinson@igalia.com>
1353
1354         [GTK] Remove scripts code only applicable to autotools
1355         https://bugs.webkit.org/show_bug.cgi?id=130841
1356
1357         Reviewed by Anders Carlsson.
1358
1359         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
1360         (_should_file_trigger_build): Update file list to reflect GTK+ CMake port.
1361         * Scripts/webkitpy/common/config/watchlist: Remove the GTK+ build watchlist.
1362         * Scripts/webkitpy/style/checker.py: The GNUmakefile doesn't exist any longer.
1363         * gtk/find-make-dist-errors: Removed.
1364         * gtk/generate-feature-defines-files: Removed.
1365         * gtk/manifest.txt: No longer need to consider autotools files.
1366
1367 2014-03-30  Andy Estes  <aestes@apple.com>
1368
1369         Fix two failing layout tests on Mountain Lion after r166466.
1370
1371         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1372         (-[DownloadDelegate _downloadDidStart:]):
1373
1374 2014-03-30  Andy Estes  <aestes@apple.com>
1375
1376         [Cocoa] Add an originatingWebView property to _WKDownload
1377         https://bugs.webkit.org/show_bug.cgi?id=130945
1378
1379         Reviewed by Anders Carlsson.
1380
1381         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1382         (-[DownloadDelegate _downloadDidStart:]):
1383         (-[OriginatingWebViewDownloadDelegate initWithWebView:]):
1384         (-[OriginatingWebViewDownloadDelegate _downloadDidStart:]):
1385         (TEST):
1386
1387 2014-03-28  Filip Pizlo  <fpizlo@apple.com>
1388
1389         Land the stackmap register liveness glue with the uses of the liveness disabled
1390         https://bugs.webkit.org/show_bug.cgi?id=130924
1391
1392         Reviewed by Oliver Hunt.
1393
1394         * Scripts/run-jsc-stress-tests:
1395
1396 2014-03-29  Alexey Proskuryakov  <ap@apple.com>
1397
1398         Update WebKit1.StringTruncator for Mountain Lion.
1399
1400         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Looks like one subtest was failing
1401         due to different font metrics on 10.8.
1402
1403 2014-03-28  Darin Adler  <darin@apple.com>
1404
1405         Fix recently-introduced off-by-one error in centerTruncateToBuffer
1406         https://bugs.webkit.org/show_bug.cgi?id=130889
1407
1408         Reviewed by Alexey Proskuryakov.
1409
1410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringTruncator.mm.
1411         * TestWebKitAPI/Tests/mac/StringTruncator.mm: Added. One test for each of the
1412         WebStringTruncator methods; should be good for a start. These are dependent on the
1413         metrics of Helvetica 12, but I am hoping that will be consistent across OS X machines.
1414
1415 2014-03-28  Martin Hock  <mhock@apple.com>
1416
1417         Unreviewed. Add myself as a committer.
1418
1419         * Scripts/webkitpy/common/config/contributors.json:
1420
1421 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
1422
1423         Remove WebKit1 GTK+ bots
1424         https://bugs.webkit.org/show_bug.cgi?id=130904
1425
1426         Reviewed by Anders Carlsson.
1427
1428         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
1429         all bots are testing WebKit2 only.
1430         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
1431         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
1432         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
1433         * Scripts/webkitpy/port/builders.py: Ditto.
1434         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
1435         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
1436
1437 2014-03-28  Timothy Hatcher  <timothy@apple.com>
1438
1439         Remove Brian Burg's apple.com email address.
1440
1441         * Scripts/webkitpy/common/config/contributors.json:
1442
1443 2014-03-28  David Kilzer  <ddkilzer@apple.com>
1444
1445         bisect-builds should print Trac 'changeset' URL if only one build is detected
1446         <http://webkit.org/b/130903>
1447
1448         Reviewed by Dan Bernstein.
1449
1450         * Scripts/bisect-builds:
1451         (printTracLink): Print a direct link to the Trac 'changeset'
1452         URL if there is only one revision in the range.
1453
1454 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
1455
1456         [EFL] Bump glib version from 2.36 to 2.38 
1457         https://bugs.webkit.org/show_bug.cgi?id=130886
1458
1459         Reviewed by Csaba Osztrogonác.
1460
1461         There is a build break on EFL port when using glib 2.36 ver. To fix it,
1462         we need to bump glib version up to 2.38 as gtk port.
1463
1464         * efl/jhbuild.modules:
1465
1466 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
1467
1468         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
1469
1470         Provide an implementation of WKContextHistoryClient that logs when called for tests in
1471         the globalhistory directory.
1472
1473         Reviewed by Sam Weinig.
1474
1475         * WebKitTestRunner/TestController.cpp:
1476         (WTR::TestController::TestController):
1477         (WTR::TestController::initialize): Set the history client.
1478         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
1479         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
1480         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
1481         and we don't yet have API to access the data in question.
1482         (WTR::TestController::didPerformClientRedirect):
1483         (WTR::TestController::didPerformServerRedirect):
1484         (WTR::TestController::didUpdateHistoryTitle):
1485         * WebKitTestRunner/TestController.h:
1486         (WTR::TestController::setShouldLogHistoryClientCallbacks):
1487         * WebKitTestRunner/TestInvocation.cpp:
1488         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
1489         (WTR::TestInvocation::invoke):
1490
1491 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
1492
1493         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
1494
1495         * Scripts/build-webkit:
1496         * Scripts/copy-webkitlibraries-to-product-directory:
1497
1498 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
1499
1500         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
1501         https://bugs.webkit.org/show_bug.cgi?id=130867
1502         <rdar://problem/16432456> 
1503
1504         Reviewed by Mark Hahnenberg.
1505
1506         * Scripts/build-webkit:
1507         * Scripts/copy-webkitlibraries-to-product-directory:
1508
1509 2014-03-26  Andy Estes  <aestes@apple.com>
1510
1511         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
1512         https://bugs.webkit.org/show_bug.cgi?id=130805
1513
1514         Reviewed by Dan Bernstein.
1515
1516         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1517         (-[DownloadDelegate _download:didReceiveResponse:]):
1518         (-[DownloadDelegate _downloadDidFinish:]):
1519         (runTest):
1520         (TEST):
1521         (-[FailingDownloadDelegate _downloadDidFinish:]):
1522         (-[FailingDownloadDelegate _download:didFailWithError:]):
1523         (-[FailingDownloadDelegate _downloadDidCancel:]):
1524         (-[CancelledDownloadDelegate _downloadDidStart:]):
1525         (-[CancelledDownloadDelegate _downloadDidFinish:]):
1526         (-[CancelledDownloadDelegate _download:didFailWithError:]):
1527         (-[CancelledDownloadDelegate _downloadDidCancel:]):
1528         (-[DownloadDelegate initWithSourceURL:]): Deleted.
1529         (-[DownloadDelegate sourceURL]): Deleted.
1530         (runTestWithNavigationDelegate): Deleted.
1531
1532 2014-03-26  Anders Carlsson  <andersca@apple.com>
1533
1534         Change MiniBrowser to hold on to window controllers instead of windows
1535         https://bugs.webkit.org/show_bug.cgi?id=130797
1536
1537         Reviewed by Oliver Hunt.
1538
1539         * MiniBrowser/mac/AppDelegate.h:
1540         * MiniBrowser/mac/AppDelegate.m:
1541         (-[BrowserAppDelegate init]):
1542         (-[BrowserAppDelegate newWindow:]):
1543         (-[BrowserAppDelegate browserWindowWillClose:]):
1544         (-[BrowserAppDelegate applicationWillTerminate:]):
1545         (-[BrowserAppDelegate frontmostBrowserWindowController]):
1546
1547 2014-03-26  Commit Queue  <commit-queue@webkit.org>
1548
1549         Unreviewed, rolling out r166264.
1550         https://bugs.webkit.org/show_bug.cgi?id=130785
1551
1552         Broke some window.opener tests for WK2 Mavericks (Requested by
1553         brrian__ on #webkit).
1554
1555         Reverted changeset:
1556
1557         "Web Replay: resource unique identifiers should be unique-per-
1558         frame, not globally"
1559         https://bugs.webkit.org/show_bug.cgi?id=130632
1560         http://trac.webkit.org/changeset/166264
1561
1562 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
1563
1564         [CSS Shapes] Remove shape-inside support
1565         https://bugs.webkit.org/show_bug.cgi?id=130698
1566
1567         Reviewed by David Hyatt.
1568
1569         * Scripts/webkitperl/FeatureList.pm:
1570
1571 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
1572
1573         Unreviewed. Add myself as a committer.
1574
1575         * Scripts/webkitpy/common/config/contributors.json:
1576
1577 2014-03-26  Tomas Popela  <tpopela@redhat.com>
1578
1579         run-launcher is Perl script so use elsif and not elif
1580         https://bugs.webkit.org/show_bug.cgi?id=130771
1581
1582         Reviewed by Carlos Garcia Campos.
1583
1584         * Scripts/run-launcher:
1585
1586 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
1587
1588         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
1589         https://bugs.webkit.org/show_bug.cgi?id=130575
1590
1591         Reviewed by Mario Sanchez Prada.
1592
1593         Change ATK version to 2.11.92. Adjust current implementation.
1594
1595         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1596         (AccessibilityUIElement::intValue):
1597         (AccessibilityUIElement::minValue):
1598         (AccessibilityUIElement::maxValue):
1599         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1600         (WTR::AccessibilityUIElement::intValue):
1601         (WTR::AccessibilityUIElement::minValue):
1602         (WTR::AccessibilityUIElement::maxValue):
1603         * efl/jhbuild.modules:
1604         * gtk/jhbuild.modules:
1605
1606 2014-03-12  Philippe Normand  <pnormand@igalia.com>
1607
1608         [GTK] The gnumake package is no longer needed in jhbuild
1609         https://bugs.webkit.org/show_bug.cgi?id=130121
1610
1611         Reviewed by Martin Robinson.
1612
1613         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
1614         for a debug build cmake/system-gnumake worked just fine for me.
1615
1616         * gtk/jhbuild.modules: Removed gnumake.
1617         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
1618         * gtk/patches/make-3.82-parallel-build.patch: Removed.
1619
1620 2014-03-25  Andy Estes  <aestes@apple.com>
1621
1622         Fix a failing API test on Mountain Lion and remove temporary debug logging.
1623
1624         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1625         (-[DownloadDelegate _download:didReceiveData:]):
1626         (-[DownloadDelegate _downloadDidFinish:]):
1627
1628 2014-03-25  Brian Burg  <bburg@apple.com>
1629
1630         Web Replay: resource unique identifiers should be unique-per-frame, not globally
1631         https://bugs.webkit.org/show_bug.cgi?id=130623
1632
1633         Reviewed by Timothy Hatcher.
1634
1635         The resource loader callback dumping routines assumed that resource identifiers
1636         were globally unique. Its map of resource identifiers to URLs must also track the
1637         frame associated with the resource.
1638
1639         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1640         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
1641         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
1642         stable as long as the frame is valid.
1643         (WTR::InjectedBundlePage::didInitiateLoadForResource):
1644         (WTR::InjectedBundlePage::willSendRequestForFrame):
1645         (WTR::InjectedBundlePage::didReceiveResponseForResource):
1646         (WTR::InjectedBundlePage::didFinishLoadForResource):
1647         (WTR::InjectedBundlePage::didFailLoadForResource):
1648
1649 2014-03-25  Andy Estes  <aestes@apple.com>
1650
1651         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
1652
1653         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1654         (-[DownloadDelegate _download:didReceiveResponse:]):
1655         (-[DownloadDelegate _download:didReceiveData:]):
1656
1657 2014-03-25  Andy Estes  <aestes@apple.com>
1658
1659         Add some debug logging to an API test that's failing on Mountain Lion.
1660
1661         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
1662         (-[DownloadDelegate _download:didReceiveResponse:]):
1663         (-[DownloadDelegate _downloadDidFinish:]):
1664
1665 2014-03-25  Anders Carlsson  <andersca@apple.com>
1666
1667         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
1668         https://bugs.webkit.org/show_bug.cgi?id=130732
1669
1670         Reviewed by Tim Horton.
1671
1672         * MiniBrowser/mac/WK2BrowserWindowController.m:
1673         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
1674
1675 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
1676
1677         [GTK] Remove the autotools build
1678         https://bugs.webkit.org/show_bug.cgi?id=130717
1679
1680         Reviewed by Anders Carlsson.
1681
1682         * DumpRenderTree/config.h: Remove references to the autotools configure file.
1683         * GNUmakefile.am: Removed.
1684         * GtkLauncher/GNUmakefile.am: Removed.
1685         * GtkLauncher/main.c: Remove references to the autotools configure file.
1686         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
1687         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
1688         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
1689         * MiniBrowser/gtk/GNUmakefile.am: Removed.
1690         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
1691         * Scripts/build-webkit: No longer handle autotools.
1692         * Scripts/run-gtk-tests: Ditto.
1693         (TestRunner._setup_testing_environment):
1694         * Scripts/run-launcher: Ditto.
1695         * Scripts/webkitdirs.pm: Ditto.
1696         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
1697         * Scripts/webkitpy/common/config/contributors.json: Ditto.
1698         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
1699         * Scripts/webkitpy/style/checker.py:
1700         * TestWebKitAPI/GNUmakefile.am: Removed.
1701         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
1702         * WebKitTestRunner/GNUmakefile.am: Removed.
1703         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
1704         * gtk/GNUmakefile.am: Removed.
1705         * gtk/common.py: Remove checks for the autotools build.
1706         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
1707
1708 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
1709
1710         prepare-ChangeLog throws false positive warnings for modified files.
1711         https://bugs.webkit.org/show_bug.cgi?id=130687
1712
1713         Reviewed by Darin Adler.
1714
1715         * Scripts/prepare-ChangeLog:
1716         (originalFile): Ignore git commit paremeter.
1717         We don't need this to get the unmodified file.
1718         (extractLineRangeBeforeChange):
1719         Simplify the if statement. Follow-up after r166189.
1720
1721 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
1722
1723         [EFL] Add ARM64 build support
1724         https://bugs.webkit.org/show_bug.cgi?id=130506
1725
1726         Rubber stamped by Gyuyoung Kim.
1727
1728         * Scripts/webkitdirs.pm:
1729         (isARM): Detect aarch64 as ARM.
1730
1731 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1732
1733         [webkitpy] Improve _parse_bug_description to recognize more descriptions
1734         https://bugs.webkit.org/show_bug.cgi?id=130137
1735
1736         Reviewed by Csaba Osztrogonác.
1737
1738         * Scripts/webkitpy/common/checkout/changelog.py:
1739         (ChangeLogEntry._parse_bug_description):
1740         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1741         (test_parse_log_entries_from_changelog):
1742         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1743         (CheckoutTest.test_commit_info_for_revision):
1744
1745 2014-03-24  Andy Estes  <aestes@apple.com>
1746
1747         Fix the iOS build of TestWebKitAPI.
1748
1749         * TestWebKitAPI/Configurations/Base.xcconfig:
1750         * TestWebKitAPI/PlatformUtilities.h:
1751
1752 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
1753
1754         Fix prepare-ChangeLog after r166156.
1755         https://bugs.webkit.org/show_bug.cgi?id=130674
1756
1757         Reviewed by Darin Adler.
1758
1759         * Scripts/prepare-ChangeLog:
1760         (generateFunctionLists):
1761         (extractLineRangeBeforeChange):
1762
1763 2014-03-24  Andy Estes  <aestes@apple.com>
1764
1765         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
1766         https://bugs.webkit.org/show_bug.cgi?id=129322
1767
1768         Reviewed by Anders Carlsson.
1769
1770         Add an API test suite for _WKDownload.
1771
1772         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1773         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
1774         (-[DownloadDelegate initWithSourceURL:]):
1775         (-[DownloadDelegate sourceURL]):
1776         (-[DownloadDelegate _downloadDidStart:]):
1777         (-[DownloadDelegate _download:didReceiveResponse:]):
1778         (-[DownloadDelegate _download:didReceiveData:]):
1779         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
1780         (-[DownloadDelegate _downloadDidFinish:]):
1781         (TEST):
1782         (runTestWithNavigationDelegate):
1783         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
1784         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
1785
1786 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
1787
1788         filter-build-webkit: reduce unfiltered output
1789         https://bugs.webkit.org/show_bug.cgi?id=130485
1790
1791         Reviewed by Brent Fulgham.
1792
1793         * Scripts/filter-build-webkit:
1794         (shouldIgnoreLine):
1795
1796 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
1797
1798         prepare-ChangeLog should list functions that have been removed too.
1799         https://bugs.webkit.org/show_bug.cgi?id=130508
1800
1801         Reviewed by Darin Adler.
1802
1803         The prepare-ChangeLog does not list the deleted functions in the Changelog.
1804         We have to read the functions and the line ranges of them from the source
1805         before the change, then search for overlaps between them and the changed
1806         line ranges from diff.
1807
1808         * Scripts/prepare-ChangeLog:
1809         (originalFile): Get original source command.
1810         (generateFunctionLists): Collect deleted functions too.
1811         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
1812         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
1813         deleted functions ranges too.
1814         (extractLineRange): Renamed to extractLineRangeAfterChange.
1815
1816 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
1817
1818         Move all EFL typedefs into EflTypedefs.h.
1819         https://bugs.webkit.org/show_bug.cgi?id=130511
1820
1821         Reviewed by Gyuyoung Kim.
1822
1823         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
1824         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
1825         * WebKitTestRunner/PlatformWebView.h: Ditto.
1826
1827 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
1828
1829         Don't flush compositing layers within FrameView::willPaintContents()
1830         https://bugs.webkit.org/show_bug.cgi?id=130627
1831         <rdar://problem/16368869>
1832
1833         Reviewed by Sam Weinig.
1834         
1835         Fix DRT to correctly render tests with layers now that FrameView::paintContents
1836         does not flush.
1837         
1838         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
1839         into an explicit function called before dumping. 
1840         
1841         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
1842         are flushed to CA. They will be pushed to the window by snapshotting.
1843
1844         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1845         Fix weird path to IOKit.framework.
1846         * DumpRenderTree/mac/DumpRenderTree.mm:
1847         (updateDisplay):
1848         (dump):
1849         * DumpRenderTree/mac/FrameLoadDelegate.mm:
1850         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
1851         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
1852
1853 2014-03-21  David Kilzer  <ddkilzer@apple.com>
1854
1855         fix-blink-patch: tool to fix up renamed directory paths in Blink
1856         <http://webkit.org/b/130609>
1857
1858         Reviewed by Ryosuke Niwa.
1859
1860         Usage: cat blink.patch | fix-blink-patch | svn-apply
1861
1862         * Scripts/fix-blink-patch: Added.
1863
1864 2014-03-21  Darin Adler  <darin@apple.com>
1865
1866         Remove use of deprecatedCharacters in WebKit API tests
1867         https://bugs.webkit.org/show_bug.cgi?id=130602
1868
1869         Reviewed by Antti Koivisto.
1870
1871         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
1872         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
1873         (TestWebKitAPI::expectEmpty): Use characters8.
1874         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
1875
1876         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
1877         Removed the test that is entirely about 16-bit conversion since that's basically a test of
1878         the deprecatedCharacters function itself, which we are about to delete.
1879
1880 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1881
1882         [webkitpy] Fix has_valid_reviewer()
1883         https://bugs.webkit.org/show_bug.cgi?id=130589
1884
1885         Reviewed by Csaba Osztrogonác.
1886
1887         * Scripts/webkitpy/common/checkout/changelog.py:
1888         (ChangeLogEntry.has_valid_reviewer):
1889         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1890         (test_has_valid_reviewer):
1891         * Scripts/webkitpy/common/config/committers.py:
1892         (CommitterList._reviewer_only):
1893         (CommitterList.committer_by_name):
1894         (CommitterList.reviewer_by_email):
1895         (CommitterList):
1896         (CommitterList.reviewer_by_name):
1897
1898 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1899
1900         Add cache support for jhbuild
1901         https://bugs.webkit.org/show_bug.cgi?id=130588
1902
1903         Reviewed by Csaba Osztrogonác.
1904
1905         * jhbuild/jhbuildrc_common.py:
1906         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
1907
1908 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
1909
1910         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
1911         https://bugs.webkit.org/show_bug.cgi?id=130504
1912
1913         Reviewed by Martin Robinson.
1914
1915         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
1916         CMake if not specified.
1917         * Scripts/webkitdirs.pm:
1918         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
1919         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
1920
1921 2014-03-21  Andreas Kling  <akling@apple.com>
1922
1923         RetainPtr API test should use CFArray instead of CFString for testing.
1924         <rdar://problem/16384899>
1925
1926         Unreviewed bot fix.
1927
1928         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1929         (TestWebKitAPI::TEST):
1930         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1931         (TestWebKitAPI::TEST):
1932
1933 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
1934
1935         Move to using std::unique_ptr for EFL objects.
1936         https://bugs.webkit.org/show_bug.cgi?id=129853
1937
1938         Reviewed by Gyuyoung Kim.
1939
1940         EflUniquePtr is a template alias of std::unique_ptr
1941         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
1942         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
1943
1944         * DumpRenderTree/efl/DumpRenderTree.cpp:
1945         (main):
1946         * ImageDiff/efl/ImageDiff.cpp:
1947         (initEfl):
1948         (main):
1949
1950 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
1951
1952         Unreviewed buildfix after r165983 for non Cocoa platforms
1953
1954         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
1955
1956         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
1957         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1958         * WebKitTestRunner/TestController.cpp:
1959
1960 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
1961
1962         [GTK][CMake] Add support for building with Clang
1963         https://bugs.webkit.org/show_bug.cgi?id=130260
1964
1965         Reviewed by Martin Robinson.
1966
1967         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
1968         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
1969         included GTest framework headers.
1970         * gtk/generate-gtkdoc:
1971         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
1972         in case of using Clang since that is now set by the CMake rule.
1973
1974 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
1975
1976         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
1977         https://bugs.webkit.org/show_bug.cgi?id=130476
1978
1979         Reviewed by Anders Carlsson.
1980         
1981         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
1982
1983         * MiniBrowser/mac/WK1BrowserWindowController.m:
1984         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
1985         Remove log.
1986         * MiniBrowser/mac/WK2BrowserWindowController.m:
1987         (-[WK2BrowserWindowController awakeFromNib]):
1988         (-[WK2BrowserWindowController validateMenuItem:]):
1989         (-[WK2BrowserWindowController reload:]):
1990         Hook up reload.
1991         (-[WK2BrowserWindowController toggleZoomMode:]):
1992         (-[WK2BrowserWindowController resetZoom:]):
1993         (-[WK2BrowserWindowController canResetZoom]):
1994         (-[WK2BrowserWindowController currentZoomFactor]):
1995         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
1996         (-[WK2BrowserWindowController canZoomIn]):
1997         (-[WK2BrowserWindowController canZoomOut]):
1998
1999 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
2000
2001         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2002         https://bugs.webkit.org/show_bug.cgi?id=130463
2003
2004         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
2005
2006 2014-03-18  Samuel White  <samuel_white@apple.com>
2007
2008         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
2009         https://bugs.webkit.org/show_bug.cgi?id=130250
2010
2011         Reviewed by Chris Fleizach.
2012
2013         Added ability to toggle enhanced accessibility on and off to support tests that require it.
2014
2015         * DumpRenderTree/AccessibilityController.cpp:
2016         (enableEnhancedAccessibilityCallback):
2017         (getEnhancedAccessibilityEnabledCallback):
2018         (AccessibilityController::getJSClass):
2019         * DumpRenderTree/AccessibilityController.h:
2020         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
2021         (AccessibilityController::enableEnhancedAccessibility):
2022         (AccessibilityController::enhancedAccessibilityEnabled):
2023         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
2024         (AccessibilityController::enableEnhancedAccessibility):
2025         (AccessibilityController::enhancedAccessibilityEnabled):
2026         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
2027         (AccessibilityController::enableEnhancedAccessibility):
2028         (AccessibilityController::enhancedAccessibilityEnabled):
2029         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2030         (AccessibilityController::enableEnhancedAccessibility):
2031         (AccessibilityController::enhancedAccessibilityEnabled):
2032         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2033         (WTR::AccessibilityController::enableEnhancedAccessibility):
2034         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
2035         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
2036         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2037
2038 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
2039
2040         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
2041         yet).
2042
2043         * Scripts/webkitpy/common/config/contributors.json:
2044
2045 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
2046
2047         Web Inspector: Remove stale ReportMemoryUsagePlugin
2048         https://bugs.webkit.org/show_bug.cgi?id=130405
2049
2050         Reviewed by Andreas Kling.
2051
2052         This clang plugin looks like it was used for the old Inspector memory
2053         instrumentation that was removed. So the tool can be removed.
2054
2055         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
2056         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
2057         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
2058         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
2059
2060 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2061
2062         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
2063         https://bugs.webkit.org/show_bug.cgi?id=130220
2064
2065         Reviewed by Csaba Osztrogonác.
2066
2067         * Scripts/webkitpy/common/checkout/changelog.py:
2068         (ChangeLog.set_reviewer):
2069         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
2070         (test_set_reviewer):
2071
2072 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
2073
2074         More FTL enabling.
2075
2076         Rubber stamped by Dan Bernstein.
2077
2078         * Tools/Scripts/build-webkit:
2079
2080 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2081
2082         Renable pagination mode in WK2 MiniBrowser
2083         https://bugs.webkit.org/show_bug.cgi?id=130374
2084
2085         Reviewed by Anders Carlsson.
2086         
2087         Put the implementation of togglePaginationMode: back, and correctly
2088         enable the menu item.
2089
2090         * MiniBrowser/mac/WK2BrowserWindowController.m:
2091         (-[WK2BrowserWindowController validateMenuItem:]):
2092         (-[WK2BrowserWindowController isPaginated]):
2093         (-[WK2BrowserWindowController togglePaginationMode:]):
2094
2095 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2096
2097         Add --reset option to Tools/Scripts/set-webkit-configuration script
2098         https://bugs.webkit.org/show_bug.cgi?id=130401
2099
2100         Reviewed by Csaba Osztrogonác.
2101
2102         * Scripts/set-webkit-configuration:
2103
2104 2014-03-18  Alberto Garcia  <berto@igalia.com>
2105
2106         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
2107         https://bugs.webkit.org/show_bug.cgi?id=130388
2108
2109         Reviewed by Sergio Villar Senin.
2110
2111         * Scripts/webkitdirs.pm:
2112         (shouldRemoveCMakeCache): make sure that the build directory
2113         exists before attempting to create a file in it.
2114
2115 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
2116
2117         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
2118         https://bugs.webkit.org/show_bug.cgi?id=130336
2119
2120         Reviewed by Gyuyoung Kim.
2121
2122         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
2123         requires a space between literal and string macro [-Wliteral-suffix]'
2124         warning treated as error.
2125
2126         This patch applies a solution from r162448 to the EFL port.
2127
2128         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
2129         * efl/jhbuild.modules: Added appropriate patch section.
2130
2131 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2132
2133         webkitpy test rebaseline.
2134
2135         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2136         (MainTest.test_default_args):
2137
2138 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
2139
2140         --profile should imply --test-runner-count=1 in run-perf-tests
2141         https://bugs.webkit.org/show_bug.cgi?id=130375
2142
2143         Reviewed by Benjamin Poulain.
2144
2145         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
2146
2147         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2148         (PerfTestsRunner._parse_args): Use -1 as the default value.
2149         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
2150         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
2151         should be 1.
2152
2153 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2154
2155         Address some style nits.
2156
2157         * MiniBrowser/mac/WK2BrowserWindowController.m:
2158
2159 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2160
2161         Add transparent window support back into MiniBrowser
2162         https://bugs.webkit.org/show_bug.cgi?id=130363
2163
2164         Reviewed by Anders Carlsson.
2165         
2166         Re-enable transparent window support for WK2.
2167
2168         * MiniBrowser/mac/WK2BrowserWindowController.m:
2169         (-[WK2BrowserWindowController validateMenuItem:]):
2170         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2171
2172 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2173
2174         Fix the 32-bit build; make the open panel make a WK1 window.
2175
2176         * MiniBrowser/mac/AppDelegate.m:
2177         (-[BrowserAppDelegate openDocument:]):
2178
2179 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
2180
2181         Convert MiniBrowser to use WKWebView API
2182         https://bugs.webkit.org/show_bug.cgi?id=130061
2183
2184         Reviewed by Anders Carlsson.
2185         
2186         Convert the MiniBrowser WK2 window to use WebKit2 API as much
2187         as possible.
2188         
2189         Some functionality was removed temporarily:
2190             - text zoom, page zoom
2191             - reload
2192             - pagination mode
2193             - transparent window
2194             - dumping source
2195             - window.open support
2196             - beforeUnload panel
2197             - find in page
2198
2199         * MiniBrowser/mac/AppDelegate.h:
2200         * MiniBrowser/mac/AppDelegate.m:
2201         (-[BrowserAppDelegate init]):
2202         (-[BrowserAppDelegate newWindow:]):
2203         (-[BrowserAppDelegate applicationWillTerminate:]):
2204         (-[BrowserAppDelegate openDocument:]):
2205         * MiniBrowser/mac/WK2BrowserWindowController.h:
2206         * MiniBrowser/mac/WK2BrowserWindowController.m:
2207         (-[WK2BrowserWindowController awakeFromNib]):
2208         (-[WK2BrowserWindowController dealloc]):
2209         (-[WK2BrowserWindowController fetch:]):
2210         (-[WK2BrowserWindowController validateMenuItem:]):
2211         (-[WK2BrowserWindowController reload:]):
2212         (-[WK2BrowserWindowController goBack:]):
2213         (-[WK2BrowserWindowController goForward:]):
2214         (-[WK2BrowserWindowController toggleZoomMode:]):
2215         (-[WK2BrowserWindowController resetZoom:]):
2216         (-[WK2BrowserWindowController canResetZoom]):
2217         (-[WK2BrowserWindowController dumpSourceToConsole:]):
2218         (-[WK2BrowserWindowController togglePaginationMode:]):
2219         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
2220         (-[WK2BrowserWindowController windowShouldClose:]):
2221         (-[WK2BrowserWindowController applicationTerminating]):
2222         (-[WK2BrowserWindowController currentZoomFactor]):
2223         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
2224         (-[WK2BrowserWindowController toggleTransparentWindow:]):
2225         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
2226         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
2227         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
2228         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
2229         (-[WK2BrowserWindowController find:]):
2230         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
2231         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
2232         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
2233         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
2234         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
2235         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
2236         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
2237         * WebKitTestRunner/PlatformWebView.h:
2238         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2239         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2240
2241 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
2242
2243         Use RunLoop objects through references instead of pointers
2244         https://bugs.webkit.org/show_bug.cgi?id=130313
2245
2246         Reviewed by Andreas Kling.
2247
2248         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
2249         return RunLoop reference instead of a pointer.
2250
2251         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
2252         (loadedCallback):
2253         (clickedCallback):
2254
2255 2014-03-17  Tim Horton  <timothy_horton@apple.com>
2256
2257         sort-export-file --help doesn't work (missing 'use')
2258         https://bugs.webkit.org/show_bug.cgi?id=130338
2259
2260         Reviewed by Anders Carlsson.
2261
2262         * Scripts/sort-export-file:
2263         Add a missing 'use', and fix a typo in an error message.
2264
2265 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
2266
2267         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
2268         https://bugs.webkit.org/show_bug.cgi?id=130155
2269
2270         Reviewed by Philippe Normand.
2271
2272         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
2273
2274 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2275
2276         [GTK] MiniBrowser fails to load injected bundle lib
2277         https://bugs.webkit.org/show_bug.cgi?id=130332
2278
2279         Reviewed by Anders Carlsson.
2280
2281         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
2282
2283         * MiniBrowser/gtk/main.c:
2284         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
2285         process is spawn.
2286
2287 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
2288
2289         [EFL] Enable TOUCH_SLIDER macro
2290         https://bugs.webkit.org/show_bug.cgi?id=130185
2291
2292         Reviewed by Gyuyoung Kim.
2293
2294         * Scripts/webkitperl/FeatureList.pm:
2295
2296 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
2297
2298         [GTK][CMake] Build with -fno-rtti
2299         https://bugs.webkit.org/show_bug.cgi?id=130261
2300
2301         Reviewed by Martin Robinson.
2302
2303         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
2304         defined to 0 to prevent typeid use in included GTest headers.
2305
2306 2014-03-16  Brian Burg  <bburg@apple.com>
2307
2308         Web Inspector: vended backend commands file should be generated as part of the build
2309         https://bugs.webkit.org/show_bug.cgi?id=130110
2310
2311         Reviewed by Timothy Hatcher.
2312
2313         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
2314
2315 2014-03-16  Diego Pino García  <dpino@igalia.com>
2316
2317         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
2318         https://bugs.webkit.org/show_bug.cgi?id=128999
2319
2320         Reviewed by Philippe Normand.
2321
2322         * MiniBrowser/gtk/BrowserWindow.c:
2323         (reloadPage):
2324         (reloadPageIgnoringCache):
2325         (browser_window_init):
2326
2327 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
2328
2329         [GTK] Improve ninja detection in webkitdirs.pm
2330         https://bugs.webkit.org/show_bug.cgi?id=129902
2331
2332         Reviewed by Daniel Bates.
2333
2334         * Scripts/webkitdirs.pm:
2335         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
2336         us to look for ninja-build as well.
2337
2338 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
2339
2340         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
2341         https://bugs.webkit.org/show_bug.cgi?id=130276
2342         <rdar://problem/16266927>
2343         
2344         Reviewed by Simon Fraser.
2345
2346         * BuildSlaveSupport/build-launcher-app:
2347         * BuildSlaveSupport/build-launcher-dmg:
2348         * DumpRenderTree/DumpRenderTree.h:
2349         * DumpRenderTree/DumpRenderTreePrefix.h:
2350         * DumpRenderTree/GCController.cpp:
2351         * DumpRenderTree/GCController.h:
2352         * DumpRenderTree/JavaScriptThreading.cpp:
2353         * DumpRenderTree/JavaScriptThreading.h:
2354         * DumpRenderTree/PixelDumpSupport.cpp:
2355         * DumpRenderTree/PixelDumpSupport.h:
2356         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
2357         * DumpRenderTree/TestRunner.cpp:
2358         * DumpRenderTree/TestRunner.h:
2359         * DumpRenderTree/WorkQueue.cpp:
2360         * DumpRenderTree/WorkQueue.h:
2361         * DumpRenderTree/WorkQueueItem.h:
2362         * DumpRenderTree/atk/AccessibilityCallbacks.h:
2363         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
2364         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
2365         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
2366         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
2367         * DumpRenderTree/cg/PixelDumpSupportCG.h:
2368         * DumpRenderTree/efl/EditingCallbacks.cpp:
2369         * DumpRenderTree/efl/EditingCallbacks.h:
2370         * DumpRenderTree/efl/EventSender.cpp:
2371         * DumpRenderTree/efl/EventSender.h:
2372         * DumpRenderTree/efl/GCControllerEfl.cpp:
2373         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
2374         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2375         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2376         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
2377         * DumpRenderTree/gtk/EditingCallbacks.cpp:
2378         * DumpRenderTree/gtk/EditingCallbacks.h:
2379         * DumpRenderTree/gtk/EventSender.cpp:
2380         * DumpRenderTree/gtk/EventSender.h:
2381         * DumpRenderTree/gtk/GCControllerGtk.cpp:
2382         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
2383         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
2384         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
2385         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2386         * DumpRenderTree/gtk/TextInputController.cpp:
2387         * DumpRenderTree/gtk/TextInputController.h:
2388         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
2389         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
2390         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
2391         * DumpRenderTree/mac/AppleScriptController.h:
2392         * DumpRenderTree/mac/AppleScriptController.m:
2393         * DumpRenderTree/mac/CheckedMalloc.cpp:
2394         * DumpRenderTree/mac/CheckedMalloc.h:
2395         * DumpRenderTree/mac/DumpRenderTree.mm:
2396         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
2397         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
2398         * DumpRenderTree/mac/DumpRenderTreeMac.h:
2399         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
2400         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
2401         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2402         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2403         * DumpRenderTree/mac/EditingDelegate.h:
2404         * DumpRenderTree/mac/EditingDelegate.mm:
2405         * DumpRenderTree/mac/EventSendingController.h:
2406         * DumpRenderTree/mac/EventSendingController.mm:
2407         * DumpRenderTree/mac/FrameLoadDelegate.h:
2408         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2409         * DumpRenderTree/mac/GCControllerMac.mm:
2410         * DumpRenderTree/mac/MockWebNotificationProvider.h:
2411         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
2412         * DumpRenderTree/mac/NavigationController.h:
2413         * DumpRenderTree/mac/NavigationController.m:
2414         * DumpRenderTree/mac/ObjCController.h:
2415         * DumpRenderTree/mac/ObjCController.m:
2416         * DumpRenderTree/mac/ObjCPlugin.h:
2417         * DumpRenderTree/mac/ObjCPlugin.m:
2418         * DumpRenderTree/mac/ObjCPluginFunction.h:
2419         * DumpRenderTree/mac/ObjCPluginFunction.m:
2420         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2421         * DumpRenderTree/mac/PolicyDelegate.h:
2422         * DumpRenderTree/mac/PolicyDelegate.mm:
2423         * DumpRenderTree/mac/ResourceLoadDelegate.h:
2424         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
2425         * DumpRenderTree/mac/TestRunnerMac.mm:
2426         * DumpRenderTree/mac/TextInputController.h:
2427         * DumpRenderTree/mac/TextInputController.m:
2428         * DumpRenderTree/mac/UIDelegate.h:
2429         * DumpRenderTree/mac/UIDelegate.mm:
2430         * DumpRenderTree/mac/WorkQueueItemMac.mm:
2431         * DumpRenderTree/win/DRTDataObject.cpp:
2432         * DumpRenderTree/win/DRTDataObject.h:
2433         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
2434         * DumpRenderTree/win/DRTDropSource.cpp:
2435         * DumpRenderTree/win/DRTDropSource.h:
2436         * DumpRenderTree/win/DraggingInfo.h:
2437         * DumpRenderTree/win/DumpRenderTree.cpp:
2438         * DumpRenderTree/win/DumpRenderTreeWin.h:
2439         * DumpRenderTree/win/EditingDelegate.cpp:
2440         * DumpRenderTree/win/EditingDelegate.h:
2441         * DumpRenderTree/win/EventSender.cpp:
2442         * DumpRenderTree/win/EventSender.h:
2443         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2444         * DumpRenderTree/win/FrameLoadDelegate.h:
2445         * DumpRenderTree/win/GCControllerWin.cpp:
2446         * DumpRenderTree/win/HistoryDelegate.cpp:
2447         * DumpRenderTree/win/HistoryDelegate.h:
2448         * DumpRenderTree/win/MD5.cpp:
2449         * DumpRenderTree/win/MD5.h:
2450         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
2451         * DumpRenderTree/win/PolicyDelegate.cpp:
2452         * DumpRenderTree/win/PolicyDelegate.h:
2453         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2454         * DumpRenderTree/win/ResourceLoadDelegate.h:
2455         * DumpRenderTree/win/TestRunnerWin.cpp:
2456         * DumpRenderTree/win/TextInputController.cpp:
2457         * DumpRenderTree/win/TextInputController.h:
2458         * DumpRenderTree/win/TextInputControllerWin.cpp:
2459         * DumpRenderTree/win/UIDelegate.cpp:
2460         * DumpRenderTree/win/UIDelegate.h:
2461         * DumpRenderTree/win/WorkQueueItemWin.cpp:
2462         * EWebLauncher/main.c:
2463         * GtkLauncher/main.c:
2464         * ImageDiff/efl/ImageDiff.cpp:
2465         * ImageDiff/gtk/ImageDiff.cpp:
2466         * MiniBrowser/gtk/main.c:
2467         * Scripts/SpacingHeuristics.pm:
2468         * Scripts/VCSUtils.pm:
2469         * Scripts/bisect-builds:
2470         * Scripts/build-dumprendertree:
2471         * Scripts/build-jsc:
2472         * Scripts/build-webkit:
2473         * Scripts/check-dom-results:
2474         * Scripts/check-for-exit-time-destructors:
2475         * Scripts/check-for-global-initializers:
2476         * Scripts/commit-log-editor:
2477         * Scripts/compare-timing-files:
2478         * Scripts/debug-minibrowser:
2479         * Scripts/debug-safari:
2480         * Scripts/do-file-rename:
2481         * Scripts/find-extra-includes:
2482         * Scripts/generate-coverage-data:
2483         * Scripts/make-script-test-wrappers:
2484         * Scripts/malloc-tree:
2485         * Scripts/old-run-webkit-tests:
2486         * Scripts/parse-malloc-history:
2487         * Scripts/report-include-statistics:
2488         * Scripts/resolve-ChangeLogs:
2489         * Scripts/run-bindings-tests:
2490         * Scripts/run-iexploder-tests:
2491         * Scripts/run-javascriptcore-tests:
2492         * Scripts/run-jsc:
2493         * Scripts/run-launcher:
2494         * Scripts/run-leaks:
2495         * Scripts/run-mangleme-tests:
2496         * Scripts/run-minibrowser:
2497         * Scripts/run-pageloadtest:
2498         * Scripts/run-regexp-tests:
2499         * Scripts/run-safari:
2500         * Scripts/run-sunspider:
2501         * Scripts/run-webkit-app:
2502         * Scripts/sampstat:
2503         * Scripts/set-webkit-configuration:
2504         * Scripts/sort-Xcode-project-file:
2505         * Scripts/sort-export-file:
2506         * Scripts/split-file-by-class:
2507         * Scripts/sunspider-compare-results:
2508         * Scripts/svn-apply:
2509         * Scripts/svn-create-patch:
2510         * Scripts/svn-unapply:
2511         * Scripts/test-webkit-scripts:
2512         * Scripts/update-javascriptcore-test-results:
2513         * Scripts/update-webkit:
2514         * Scripts/update-webkit-auxiliary-libs:
2515         * Scripts/update-webkit-dependency:
2516         * Scripts/update-webkit-localizable-strings:
2517         * Scripts/update-webkit-support-libs:
2518         * Scripts/update-webkit-wincairo-libs:
2519         * Scripts/webkit-build-directory:
2520         * Scripts/webkitdirs.pm:
2521         (installedSafariPath):
2522         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
2523         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
2524         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
2525         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
2526         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
2527         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
2528         * Scripts/webkitperl/features.pm:
2529         * Scripts/webkitperl/httpd.pm:
2530         * Scripts/webkitpy/bindings/main.py:
2531         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
2532         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
2533         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
2534         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
2535         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
2536         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
2537         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
2538         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2539         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
2540         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
2541         * WebKitTestRunner/PixelDumpSupport.cpp:
2542         * WebKitTestRunner/PixelDumpSupport.h:
2543         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2544         * WinLauncher/WinLauncher.cpp:
2545         * WinLauncher/WinLauncher.h:
2546         * WinLauncher/stdafx.cpp:
2547         * WinLauncher/stdafx.h:
2548
2549 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
2550
2551         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
2552         https://bugs.webkit.org/show_bug.cgi?id=130265
2553
2554         Reviewed by Michael Saboff.
2555
2556         * Scripts/build-webkit:
2557         * Scripts/copy-webkitlibraries-to-product-directory:
2558
2559 2014-03-14  Landry Breuil  <landry@openbsd.org>
2560
2561         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
2562         Also allow to set MAKE in the environment.
2563         https://bugs.webkit.org/show_bug.cgi?id=129991
2564
2565         Reviewed by Andreas Kling.
2566
2567         * Scripts/webkitdirs.pm:
2568         (determineArchitecture):
2569         (determineNumberOfCPUs):
2570         (isBSD):
2571         (buildAutotoolsProject):
2572         * Scripts/webkitpy/common/system/platforminfo.py:
2573         (PlatformInfo.__init__):
2574         (PlatformInfo.is_openbsd):
2575         (PlatformInfo):
2576         (PlatformInfo.is_netbsd):
2577         (PlatformInfo._determine_os_name):
2578
2579 2014-03-14  Dean Jackson  <dino@apple.com>
2580
2581         Remove libWebKitSystemInterfaceLion.a
2582         https://bugs.webkit.org/show_bug.cgi?id=130254
2583
2584         Reviewed by Geoffrey Garen and Andreas Kling.
2585
2586         No need to copy the Lion libraries into the build.
2587
2588         * Scripts/copy-webkitlibraries-to-product-directory:
2589
2590 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
2591
2592         [EFL][MiniBrowser] Revise help messages of command line parameters
2593         https://bugs.webkit.org/show_bug.cgi?id=130222
2594
2595         Reviewed by Csaba Osztrogonác.
2596
2597         Correct the default value description and make help messages to be consistent.
2598
2599         * MiniBrowser/efl/main.c:
2600
2601 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
2602
2603         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
2604         https://bugs.webkit.org/show_bug.cgi?id=129612
2605
2606         Reviewed by Darin Adler.
2607
2608         For new code use static NeverDestroyed<T> instead.
2609
2610         * DumpRenderTree/JavaScriptThreading.cpp:
2611         (javaScriptThreadsMutex):
2612         (javaScriptThreads):
2613         * DumpRenderTree/efl/EventSender.cpp:
2614         (touchPointList):
2615         (delayedEventQueue):
2616         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2617         (delegatesWithDelayedWork):
2618         * Scripts/check-for-exit-time-destructors:
2619         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
2620         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
2621         (testsMap):
2622
2623 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
2624
2625         [EFL][WK2] Fix compilation warning in Minibrowser
2626         https://bugs.webkit.org/show_bug.cgi?id=130132
2627
2628         Reviewed by Csaba Osztrogonác.
2629
2630         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
2631
2632         * MiniBrowser/efl/main.c:
2633         (on_download_request):
2634
2635 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
2636
2637         FTL should support IsBlah
2638         https://bugs.webkit.org/show_bug.cgi?id=130202
2639
2640         Reviewed by Geoffrey Garen.
2641         
2642         Running existing JSRegress tests with noInline gives us coverage for these
2643         changes. Chances are, this will also give coverage for other interesting things
2644         as well.
2645
2646         * Scripts/run-jsc-stress-tests:
2647
2648 2014-03-12  Brian Burg  <bburg@apple.com>
2649
2650         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
2651         https://bugs.webkit.org/show_bug.cgi?id=129744
2652
2653         Reviewed by Timothy Hatcher.
2654
2655         * DumpRenderTree/TestRunner.cpp:
2656         (evaluateInWebInspectorCallback):
2657         * DumpRenderTree/TestRunner.h:
2658         * DumpRenderTree/efl/TestRunnerEfl.cpp:
2659         (TestRunner::evaluateInWebInspector):
2660         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
2661         (TestRunner::evaluateInWebInspector):
2662         * DumpRenderTree/mac/TestRunnerMac.mm:
2663         (TestRunner::evaluateInWebInspector):
2664         * DumpRenderTree/win/TestRunnerWin.cpp:
2665         (TestRunner::evaluateInWebInspector):
2666         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2667         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2668         (WTR::TestRunner::evaluateInWebInspector):
2669         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2670
2671 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
2672
2673         [GTK] build-webkit shouldn't show error message when ninja isn't installed
2674         https://bugs.webkit.org/show_bug.cgi?id=130129
2675
2676         Reviewed by Csaba Osztrogonác.
2677
2678         * Scripts/webkitdirs.pm:
2679         (canUseNinja): Redirecting stderr to /dev/null
2680
2681 2014-03-13  Andres Gomez  <agomez@igalia.com>
2682
2683         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
2684         https://bugs.webkit.org/show_bug.cgi?id=130092
2685
2686         Reviewed by Csaba Osztrogonác.
2687
2688         Added "python-dev" as dependency for deb based distros. It is
2689         already present for rpm based distros. This dependency will allow
2690         libxml2 to generate its python bindings, needed by gtk-doc.
2691
2692         * gtk/install-dependencies:
2693
2694 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2695
2696         Unreviewed. Fix GTK+ cmake build after r165488.
2697
2698         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
2699
2700 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
2701
2702         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
2703         https://bugs.webkit.org/show_bug.cgi?id=130014
2704
2705         Reviewed by Martin Robinson.
2706
2707         Include cmake or autotools config header.
2708
2709         * MiniBrowser/gtk/BrowserDownloadsBar.c:
2710         * MiniBrowser/gtk/BrowserSearchBar.c:
2711         * MiniBrowser/gtk/BrowserWindow.c:
2712         * MiniBrowser/gtk/main.c:
2713
2714 2014-03-12  Commit Queue  <commit-queue@webkit.org>
2715
2716         Unreviewed, rolling out r165471.
2717         https://bugs.webkit.org/show_bug.cgi?id=130139
2718
2719         Didn't really fix the issue and broke another bot (Requested
2720         by mrobinson on #webkit).
2721
2722         Reverted changeset:
2723
2724         "[CMake] Newer versions of CMake cannot find older versions of
2725         Freetype"
2726         https://bugs.webkit.org/show_bug.cgi?id=130107
2727         http://trac.webkit.org/changeset/165471
2728
2729 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
2730
2731         It should be possible to build WebKit with FTL on iOS
2732         https://bugs.webkit.org/show_bug.cgi?id=130116
2733
2734         Reviewed by Dan Bernstein.
2735
2736         * Scripts/build-webkit:
2737         * Scripts/copy-webkitlibraries-to-product-directory:
2738
2739 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
2740
2741         [Win] Remove use of QTSDK
2742         https://bugs.webkit.org/show_bug.cgi?id=130049
2743
2744         Reviewed by Darin Adler.
2745
2746         * DumpRenderTree/win/DumpRenderTree.cpp:
2747         (initialize): Remove QuickTime code.
2748         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
2749         building QTMovieWin.
2750
2751 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
2752
2753         [GTK][CMAKE] Too verbose build output
2754         https://bugs.webkit.org/show_bug.cgi?id=130076
2755
2756         Reviewed by Carlos Garcia Campos.
2757
2758         Instead of building with cmake --build which isn't smart about pretty printing and
2759         colors, we build with a script which calls the proper build command.
2760
2761         * Scripts/webkitdirs.pm:
2762         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
2763         the CMake configuration pass.
2764
2765 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
2766
2767         [CMake] Newer versions of CMake cannot find older versions of Freetype
2768         https://bugs.webkit.org/show_bug.cgi?id=130107
2769
2770         Reviewed by Gustavo Noronha Silva.
2771
2772         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
2773         to CMake during jhbuild initialization.
2774
2775 2014-03-12  Zalan Bujtas  <zalan@apple.com>
2776
2777         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
2778         https://bugs.webkit.org/show_bug.cgi?id=129961
2779
2780         Reviewed by Simon Fraser.
2781
2782         Now scaled content can go through the window capturing mechanism too for compositing content.
2783         AppleMagnifiedMode is redundant.
2784
2785         * DumpRenderTree/mac/DumpRenderTree.mm:
2786         (setDefaultsToConsistentValuesForTesting):
2787         (runTest):
2788         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
2789         (createBitmapContextFromWebView):
2790         * WebKitTestRunner/PlatformWebView.h:
2791         * WebKitTestRunner/cg/TestInvocationCG.cpp:
2792         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
2793         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2794         (WTR::PlatformWebView::didInitializeClients):
2795         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2796         (WTR::PlatformWebView::forceWindowFramesChanged):
2797         * WebKitTestRunner/mac/main.mm:
2798         (setDefaultsToConsistentValuesForTesting):
2799
2800 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
2801
2802         Unreviewed. Add myself as a committer.
2803
2804         * Scripts/webkitpy/common/config/contributors.json:
2805
2806 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
2807
2808         Unreviewed build fix on the EFL port when used lower version of ATK
2809
2810         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2811         (WTR::AccessibilityUIElement::y): Fixed typo.
2812
2813 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
2814
2815         Some images are blank in the rebaseline server UI
2816         https://bugs.webkit.org/show_bug.cgi?id=130104
2817
2818         Reviewed by Tim Horton.
2819
2820         Let the server check for images in the 'retries' directory
2821         if it can't find an image otherwise.
2822
2823         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
2824         (RebaselineHTTPRequestHandler.test_result):
2825
2826 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2827
2828         [GTK][CMake] --update-gtk has no effect
2829         https://bugs.webkit.org/show_bug.cgi?id=130088
2830
2831         Reviewed by Philippe Normand.
2832
2833         * Scripts/webkitdirs.pm:
2834         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
2835         as an argument.
2836
2837 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
2838
2839         Add "System Font" to the list of whitelisted DRT fonts
2840         https://bugs.webkit.org/show_bug.cgi?id=130046
2841
2842         Reviewed by Darin Adler.
2843
2844         * DumpRenderTree/mac/DumpRenderTree.mm:
2845         (allowedFontFamilySet):
2846         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
2847
2848 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
2849
2850         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
2851         https://bugs.webkit.org/show_bug.cgi?id=130064
2852
2853         Reviewed by Philippe Normand.
2854
2855         * efl/jhbuildrc: Remove duplicated code.
2856         * gtk/jhbuildrc: Remove duplicated code.
2857         * jhbuild/jhbuildrc_common.py:
2858         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
2859         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
2860         and is apparently necessary for GTK+.
2861
2862 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
2863
2864         check-webkit-style failed to complain about missing braces
2865         https://bugs.webkit.org/show_bug.cgi?id=34189
2866
2867         Reviewed by Ryosuke Niwa.
2868
2869         * Scripts/webkitpy/style/checkers/cpp.py:
2870         (check_braces):
2871         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2872         (WebKitStyleTest.test_braces):
2873
2874 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
2875
2876         Remove Qt cruft from style checker.
2877         https://bugs.webkit.org/show_bug.cgi?id=130085
2878
2879         Reviewed by Csaba Osztrogonác.
2880
2881         There is no 'foreach' keyword in c++. That was a Qt feature
2882         added in: http://trac.webkit.org/changeset/46113
2883         Qt was removed from WebKit, so we should remove the checks
2884         of this keyword from check-webkit-style scripts.
2885
2886         * Scripts/webkitpy/style/checkers/cpp.py:
2887         (check_spacing_for_function_call):
2888         (check_spacing):
2889         (check_braces):
2890         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2891         (CppStyleTest.test_mismatching_spaces_in_parens):
2892         (CppStyleTest.test_spacing_for_fncall):
2893         (WebKitStyleTest.test_braces):
2894
2895 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
2896
2897         [GTK] update-webkitgtk-libs needs itstool
2898         https://bugs.webkit.org/show_bug.cgi?id=130082
2899
2900         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
2901         itstool is a dependency of building gtk-doc from version 1.19, so it should
2902         be added to Tools/gtk/install-dependencies script, too.
2903
2904         Reviewed by Philippe Normand.
2905
2906         * gtk/install-dependencies:
2907
2908 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
2909
2910         webkitbot rollout ChangeLogs should be nicer
2911         https://bugs.webkit.org/show_bug.cgi?id=122654
2912
2913         Reviewed by Csaba Osztrogonác.
2914
2915         Added bug urls and descriptions of rolled out patches to the rollout changelog
2916         if they are present in the original changelog. Additionally removed the list of
2917         changed files and functions.
2918
2919         * Scripts/webkitpy/common/checkout/changelog.py:
2920         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
2921         * Scripts/webkitpy/common/checkout/checkout.py:
2922         (Checkout._changelog_data_for_revision): Store bug description.
2923         * Scripts/webkitpy/common/checkout/checkout_mock.py:
2924         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
2925         (CheckoutTest.test_commit_info_for_revision):
2926         * Scripts/webkitpy/common/checkout/commitinfo.py:
2927         (CommitInfo.bug_description): Added.
2928         (CommitInfo.to_json):
2929         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
2930         (CommitInfoTest.test_commit_info_creation):
2931         * Scripts/webkitpy/tool/commands/download.py:
2932         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
2933         out patches for creating rollout changelog.
2934         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
2935         caused the regression is stored in state["bug_blocked"] now.
2936         * Scripts/webkitpy/tool/commands/download_unittest.py:
2937         (test_prepare_rollout):
2938         (test_create_rollout_multiple_revision):
2939         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
2940         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
2941         rolled out patches to the changelog.
2942         (PrepareChangeLogForRevert.run):
2943         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
2944         (UpdateChangeLogsForRevertTest):
2945         (test_message_for_revert):
2946         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
2947         (ReopenBugAfterRollout.run):
2948
2949 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
2950
2951         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
2952         https://bugs.webkit.org/show_bug.cgi?id=130021
2953
2954         Reviewed by Mario Sanchez Prada.
2955
2956         Replace deprecated functions to use new API from ATK 2.11.90.
2957
2958         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2959         (AccessibilityUIElement::x):
2960         (AccessibilityUIElement::y):
2961         (AccessibilityUIElement::width):
2962         (AccessibilityUIElement::height):
2963         (AccessibilityUIElement::clickPointX):
2964         (AccessibilityUIElement::clickPointY):
2965         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2966         (WTR::AccessibilityUIElement::x):
2967         (WTR::AccessibilityUIElement::y):
2968         (WTR::AccessibilityUIElement::width):
2969         (WTR::AccessibilityUIElement::height):
2970         (WTR::AccessibilityUIElement::clickPointX):
2971         (WTR::AccessibilityUIElement::clickPointY):
2972
2973 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
2974
2975         [ATK] Expose aria-posinset and aria-setsize through object attributes
2976         https://bugs.webkit.org/show_bug.cgi?id=130011
2977
2978         Reviewed by Chris Fleizach.
2979
2980         Added missing implementation of numberAttributeValue both to WKTR and DRT.
2981
2982         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2983         (AccessibilityUIElement::numberAttributeValue):
2984         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2985         (WTR::AccessibilityUIElement::numberAttributeValue):
2986
2987 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
2988
2989         [Win] Unreviewed build fix.
2990
2991         Some bad Windows code was committed at some point that prevents the Apple Windows port
2992         from finding its runtime dependencies reliably.
2993
2994         * win/DLLLauncher/DLLLauncherMain.cpp:
2995         (appleApplicationSupportDirectory): Restored this function.
2996         (modifyPath): Update to use appleApplicationSupportDirectory function.
2997
2998 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
2999
3000         Let the user define the full address of the performance-site-server for uploading results
3001         https://bugs.webkit.org/show_bug.cgi?id=129819
3002
3003         Reviewed by Ryosuke Niwa.
3004
3005         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
3006         can be confusing. It's more straightforward, if you need to define explicitly the server's full
3007         address along with the protocol, when you're using this parameter. I added HTTPS as the default
3008         protocol for now, in order to avoid breaking the perf bots.
3009
3010         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3011         (_upload_json):
3012         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3013         (MainTest.test_upload_json):
3014
3015 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
3016
3017         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
3018         https://bugs.webkit.org/show_bug.cgi?id=130023
3019
3020         Reviewed by Dean Jackson.
3021
3022         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
3023         /SAFESEH flag to DLL launcher process.
3024
3025 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3026
3027         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
3028         https://bugs.webkit.org/show_bug.cgi?id=129980
3029
3030         Reviewed by Carlos Garcia Campos.
3031
3032         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
3033
3034 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
3035
3036         [GTK] Remove the WebView source-mode WebKit1 test
3037         https://bugs.webkit.org/show_bug.cgi?id=129976
3038
3039         Reviewed by Carlos Garcia Campos.
3040
3041         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
3042
3043 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
3044
3045         Unreviewed build fix for GTKbuild after the switch to CMake
3046
3047         * gtk/common.py:
3048         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
3049         test-only bot doesn't have any build files.
3050
3051 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3052
3053         [GTK] built-product-archive does not handle GTK+ CMake build
3054         https://bugs.webkit.org/show_bug.cgi?id=129941
3055
3056         * BuildSlaveSupport/built-product-archive:
3057         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
3058         the CMake build.
3059
3060 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
3061
3062         [GTK] Include CMake into install-dependencies script
3063         https://bugs.webkit.org/show_bug.cgi?id=129909
3064
3065         Reviewed by Martin Robinson.
3066
3067         As since r165267 buid-webkit uses CMake by default, the dependency
3068         with 'cmake' package should be introduced.
3069
3070         * gtk/install-dependencies: Ditto.
3071
3072 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3073
3074         REGRESSION(165267): Broke a webkitpy unit tests
3075         https://bugs.webkit.org/show_bug.cgi?id=129904
3076
3077         Reviewed by Jon Honeycutt.
3078
3079         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
3080         (GtkPort._is_cmake_build):
3081
3082 2014-03-07  Andres Gomez  <agomez@igalia.com>
3083
3084         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
3085         https://bugs.webkit.org/show_bug.cgi?id=129893
3086
3087         Reviewed by Martin Robinson.
3088
3089         Added "git-svn" as dependency for deb based distros and,
3090         additionally, "subversion" for rpm based distros.
3091
3092         * gtk/install-dependencies:
3093
3094 2014-03-07  Roger Fong  <roger_fong@apple.com>
3095
3096         Remove dummy setSystemWebGLLoadPolicy client method.
3097         https://bugs.webkit.org/show_bug.cgi?id=129873.
3098
3099         Reviewed by Dean Jackson.
3100
3101         * WebKitTestRunner/TestController.cpp:
3102         (WTR::TestController::createWebViewWithOptions):
3103
3104 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
3105
3106         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
3107         https://bugs.webkit.org/show_bug.cgi?id=129886
3108
3109         Reviewed by Mark Lam.
3110
3111         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
3112         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
3113         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
3114         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
3115         make it through when in non-verbose mode.
3116
3117 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
3118
3119         [GTK] buid-webkit should use CMake by default
3120         https://bugs.webkit.org/show_bug.cgi?id=129855
3121
3122         Reviewed by Carlos Garcia Campos.
3123
3124         Make the CMake build the default GTK+ build when using build-webkit. This will
3125         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
3126         so that we have --gtk and --gtkautotools.
3127
3128         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
3129         * Scripts/webkitpy/port/gtk.py: Ditto.
3130
3131 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
3132
3133         [CMake] [GTK] Build with ninja when it is available
3134         https://bugs.webkit.org/show_bug.cgi?id=129805
3135
3136         Reviewed by Philippe Normand.
3137
3138         * Scripts/webkitdirs.pm:
3139         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
3140         if it's available on the system.
3141         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
3142         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
3143
3144 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
3145
3146         If the FTL is build-time enabled then it should be run-time enabled.
3147
3148         Rubber stamped by Geoffrey Garen.
3149
3150         * Scripts/run-jsc-stress-tests:
3151
3152 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
3153
3154         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
3155         https://bugs.webkit.org/show_bug.cgi?id=129837
3156
3157         Reviewed by Michael Saboff.
3158
3159         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
3160         The fix is to use find instead of ls like we do in shell-runner.sh.
3161
3162         * Scripts/run-jsc-stress-tests:
3163
3164 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
3165
3166         filter-build-webkit should not strip .o
3167         https://bugs.webkit.org/show_bug.cgi?id=129614
3168
3169         Reviewed by Dean Jackson.
3170
3171         This makes it much easier to jump from the failing output at
3172         the end back up to the compile errors earlier in the output.
3173
3174         * Scripts/filter-build-webkit:
3175
3176 2014-03-06  Anders Carlsson  <andersca@apple.com>
3177
3178         Build WebKit2 before building WebKit
3179         https://bugs.webkit.org/show_bug.cgi?id=129831
3180         <rdar://problem/15920020>
3181
3182         Reviewed by Dan Bernstein.
3183
3184         * Scripts/build-webkit:
3185         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
3186
3187 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
3188
3189         make-3.82 fails to build on ARM/Linux
3190         https://bugs.webkit.org/show_bug.cgi?id=107926
3191
3192         Reviewed by Martin Robinson.
3193
3194         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
3195         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
3196         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
3197         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
3198
3199         * gtk/patches/make-3.82-arg-list-length.patch:
3200
3201 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3202
3203         [GTK] Close the page when the view is disposed instead of when finalized
3204         https://bugs.webkit.org/show_bug.cgi?id=129783
3205
3206         Reviewed by Sergio Villar Senin.
3207
3208         Add test case but disabled for now because it's affetected by bug #129684.
3209
3210         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
3211         (testProcessPerWebView):
3212
3213 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
3214
3215         [GTK] MiniBrowser crashes when opening several urls passed as command line options
3216         https://bugs.webkit.org/show_bug.cgi?id=129738
3217
3218         Reviewed by Sergio Villar Senin.
3219
3220         The problem is that we are calling g_object_unref() for the
3221         WebKitWebSettings everytime we set it to a WebKitWebView, but the
3222         view only increases the reference counter when the settings is not
3223         the same it currently has. We should release our reference once.
3224
3225         * MiniBrowser/gtk/main.c:
3226         (createBrowserWindow):
3227         (main):
3228
3229 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3230
3231         [GTK][CMake] Tarball is created with wrong tarball paths
3232         https://bugs.webkit.org/show_bug.cgi?id=129496
3233
3234         Reviewed by Daniel Bates.
3235
3236         * gtk/make-dist.py:
3237         (Manifest.__init__): I inadvertently inverted the logic of these checks when
3238         landing the original patch with some suggestions from the reviewer. With the
3239         checks corrected, the tarball path is constructed properly.
3240
3241 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
3242
3243         Unreviewed. Update my email in contributors.json
3244
3245         * Scripts/webkitpy/common/config/contributors.json:
3246
3247 2014-03-05  Dean Jackson  <dino@apple.com>
3248
3249         [WebGL] Use WKSI to see what the system policy for WebGL is
3250         https://bugs.webkit.org/show_bug.cgi?id=129722
3251         <rdar://problem/15790542>
3252
3253         Reviewed by Tim Horton.
3254
3255         Dummy entry for setSystemWebGLLoadPolicy.
3256
3257         * WebKitTestRunner/TestController.cpp:
3258         (WTR::TestController::createWebViewWithOptions):
3259
3260 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
3261
3262         [GTK][CMake] Generate documentation for the DOM bindings
3263         https://bugs.webkit.org/show_bug.cgi?id=126211
3264
3265         Reviewed by Carlos Garcia Campos.
3266
3267         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
3268         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
3269         * gtk/generate-webkitdom-doc-files: Removed.
3270         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
3271         that it can be called by generate-gtkdoc.
3272
3273 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3274
3275         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
3276         https://bugs.webkit.org/show_bug.cgi?id=129380
3277
3278         Reviewed by Philippe Normand.
3279
3280         * Scripts/webkitdirs.pm:
3281         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
3282         skipping CMake execution.
3283
3284 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3285
3286         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
3287         https://bugs.webkit.org/show_bug.cgi?id=129651
3288
3289         Reviewed by Philippe Normand.
3290
3291         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
3292
3293 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
3294
3295         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
3296         https://bugs.webkit.org/show_bug.cgi?id=129637
3297
3298         Reviewed by Carlos Garcia Campos.
3299
3300         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3301         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
3302         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
3303         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
3304         New API typically just requires a rebaseline and isn't necessarily a faiulre.
3305         (TestFactory.__init__): Add the test for GTK+.
3306         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
3307
3308 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
3309
3310         [ATK] Expose missing functionalities of AtkTableCell to AT
3311         https://bugs.webkit.org/show_bug.cgi?id=129492
3312
3313         Reviewed by Mario Sanchez Prada.
3314
3315         Reducing some code by using new API of AtkTableCell.
3316
3317         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3318         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3319
3320 2014-03-04  Alex Christensen  <achristensen@webkit.org>
3321
3322         Preparing to run layout tests on Wincairo.
3323         https://bugs.webkit.org/show_bug.cgi?id=129709
3324
3325         Reviewed by Brent Fulgham.
3326
3327         * Scripts/webkitdirs.pm:
3328         (setPathForRunningWebKitApp):
3329         Add GStreamer directory for WinCairo running layout tests.
3330         * win/DLLLauncher/DLLLauncherMain.cpp:
3331         (modifyPath):
3332         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
3333
3334 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
3335
3336         [GTK] Simplify the GObject DOM bindings API break check into one step
3337         https://bugs.webkit.org/show_bug.cgi?id=129571
3338
3339         Reviewed by Carlos Garcia Campos.
3340
3341         * GNUmakefile.am: Add the API break check to 'make check.'
3342         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
3343         * gtk/check-gdom-symbols: Removed.
3344         * gtk/webkitdom.py: Added.
3345         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
3346         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
3347
3348 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
3349
3350         Add Jeremy Jones to the contributors list as a contributor.
3351
3352         * Scripts/webkitpy/common/config/contributors.json:
3353
3354 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
3355
3356         Unreviewed. Update contact email.
3357         https://bugs.webkit.org/show_bug.cgi?id=129610
3358
3359         * Scripts/webkitpy/common/config/contributors.json:
3360
3361 2014-03-02  Brian Burg  <bburg@apple.com>
3362
3363         Web Inspector model tests load wrong inspector page under WebKitTestRunner
3364         https://bugs.webkit.org/show_bug.cgi?id=129460
3365
3366         Reviewed by Dan Bernstein.
3367
3368         Don't unconditionally open the inspector before running an inspector test.
3369         Instead, the test should request that the inspector open when it's ready.
3370
3371         This change was lost during a rebase, but is the same change made to
3372         DumpRenderTree.
3373
3374         * WebKitTestRunner/TestInvocation.cpp:
3375         (WTR::TestInvocation::invoke): 
3376
3377 2014-03-02  Darin Adler  <darin@apple.com>
3378
3379         Split TextIteratorBehavior into a separate header
3380         https://bugs.webkit.org/show_bug.cgi?id=129578
3381
3382         Reviewed by Sam Weinig.
3383
3384         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
3385         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
3386         task easy, but the remove is still a bit of a pain.
3387
3388 2014-03-02  Darin Adler  <darin@apple.com>
3389
3390         Sort Mac platform export files so they merge better
3391         https://bugs.webkit.org/show_bug.cgi?id=129581
3392
3393         Reviewed by Sam Weinig.
3394
3395         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
3396         Mac export files in a "canonical" order for this project.
3397
3398 2014-02-28  Zalan Bujtas  <zalan@apple.com>
3399
3400         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
3401         https://bugs.webkit.org/show_bug.cgi?id=129438
3402
3403         Reviewed by Simon Fraser.
3404
3405         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
3406         offscreen window. It makes testing subpixel rendering and positioning possible.
3407
3408         Both the offscreen window's and WebKit's scaling are set accordingly.
3409
3410         * DumpRenderTree/mac/DumpRenderTree.mm:
3411         (createWebViewAndOffscreenWindow): cleanup
3412         (destroyWebViewAndOffscreenWindow): cleanup
3413         (dumpRenderTree):
3414         (changeWindowScaleIfNeeded):
3415         (runTest):
3416         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3417         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3418         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
3419         * WebKitTestRunner/PlatformWebView.h:
3420         * WebKitTestRunner/TestInvocation.cpp:
3421         (WTR::changeWindowScaleIfNeeded):
3422         (WTR::TestInvocation::invoke):
3423         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3424         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3425         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3426         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3427         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3428         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3429         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3430         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3431
3432 2014-02-28  Anders Carlsson  <andersca@apple.com>
3433
3434         Remove logging.
3435
3436         Reviewed by Dan Bernstein.
3437
3438         * MiniBrowser/mac/WK2BrowserWindowController.m:
3439         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
3440
3441 2014-02-28  Daniel Bates  <dabates@apple.com>
3442
3443         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
3444         https://bugs.webkit.org/show_bug.cgi?id=129163
3445
3446         Reviewed by David Kilzer.
3447
3448         Fixes an issue where DumpRenderTree Perl Support may build with the specified
3449         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
3450         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
3451         bundle.
3452
3453         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
3454         which is specified either explicitly when building with MAKE(1) or implicitly by
3455         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
3456         the OS X SDK and toolchain since the built products are only applicable to OS X.
3457
3458         * DumpRenderTree/ios/PerlSupport/Makefile:
3459
3460 2014-02-28  Commit Queue  <commit-queue@webkit.org>
3461
3462         Unreviewed, rolling out r164859.
3463         http://trac.webkit.org/changeset/164859
3464         https://bugs.webkit.org/show_bug.cgi?id=129483
3465
3466         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
3467         #webkit).
3468
3469         * DumpRenderTree/mac/DumpRenderTree.mm:
3470         (createWebViewAndOffscreenWindow):
3471         (dumpRenderTree):
3472         (runTest):
3473         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3474         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3475         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
3476         * WebKitTestRunner/PlatformWebView.h:
3477         * WebKitTestRunner/TestInvocation.cpp:
3478         (WTR::TestInvocation::invoke):
3479         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3480         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3481         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3482         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3483         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
3484
3485 2014-02-28  Zalan Bujtas  <zalan@apple.com>
3486
3487         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
3488         https://bugs.webkit.org/show_bug.cgi?id=129438
3489
3490         Reviewed by Simon Fraser.
3491
3492         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
3493         offscreen window. It makes testing subpixel rendering and positioning possible.
3494
3495         Both the offscreen window's and WebKit's scaling are set accordingly.
3496
3497         * DumpRenderTree/mac/DumpRenderTree.mm:
3498         (createWebViewAndOffscreenWindow): unrelated cleanup.
3499         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
3500         (dumpRenderTree):
3501         (changeOffscreenWindowScaleIfNeeded):
3502         (runTest):
3503         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3504         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
3505         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
3506         * WebKitTestRunner/PlatformWebView.h:
3507         * WebKitTestRunner/TestInvocation.cpp:
3508         (WTR::changeOffscreenWindowScaleIfNeeded):
3509         (WTR::TestInvocation::invoke):
3510         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3511         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
3512
3513 2014-02-27  Brian Burg  <bburg@apple.com>
3514
3515         Web Inspector: model tests should use a special Test.html inspector page
3516         https://bugs.webkit.org/show_bug.cgi?id=129190
3517
3518         Reviewed by Timothy Hatcher.
3519
3520         Remove code that immediately opens the Web Inspector based on the file path of the test.
3521         Instead, the test page should request that the inspector open inside its `test()` method.
3522
3523         This change is necessary because otherwise, the inspector would be opened too early for
3524         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
3525         will get loaded instead of the minimal test page.
3526
3527         * DumpRenderTree/efl/DumpRenderTree.cpp:
3528         (createTestRunner):
3529         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3530         (runTest):
3531         * DumpRenderTree/mac/DumpRenderTree.mm:
3532         (runTest):
3533         * DumpRenderTree/win/DumpRenderTree.cpp:
3534         (runTest):
3535
3536 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
3537
3538         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
3539         https://bugs.webkit.org/show_bug.cgi?id=127076
3540
3541         Reviewed by Anders Carlsson.
3542
3543         Avoid match for :: as start of a member initialization list. Modify expression to match
3544         after a colon either non-colon character or end of line.
3545
3546         * Scripts/webkitpy/style/checkers/cpp.py:
3547         (check_member_initialization_list):
3548         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3549         (WebKitStyleTest.test_member_initialization_list):
3550
3551 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
3552
3553         Unreviewed. Update my email addresses in contributors.json.
3554
3555         * Scripts/webkitpy/common/config/contributors.json:
3556
3557 2014-02-27  Alberto Garcia  <berto@igalia.com>
3558
3559         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
3560         https://bugs.webkit.org/show_bug.cgi?id=128927
3561
3562         Reviewed by Philippe Normand.
3563
3564         Encode manually the data for sys.{stdout,stderr}.write.
3565
3566         * gtk/gtkdoc.py:
3567         (GTKDoc._run_command):
3568
3569 2014-02-27  Andres Gomez  <agomez@igalia.com>
3570
3571         Unreviewed. Add myself to watchlists
3572
3573         * Scripts/webkitpy/common/config/watchlist: Add myself to
3574         watchlists.
3575
3576 2014-02-27  Andres Gomez  <agomez@igalia.com>
3577
3578         Unreviewed, rolling out r164790.
3579         http://trac.webkit.org/changeset/164790
3580
3581         Revert r164790 because of erroneous commit log
3582
3583         * Scripts/webkitpy/common/config/watchlist:
3584
3585 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
3586
3587         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
3588         https://bugs.webkit.org/show_bug.cgi?id=129250
3589
3590         Reviewed by Mario Sanchez Prada.
3591
3592         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
3593         Implementing methods so that we could test column/row headers represented as an array of cells.
3594
3595         * DumpRenderTree/AccessibilityUIElement.cpp:
3596         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
3597         (AccessibilityUIElement::columnHeaders):
3598         (AccessibilityUIElement::rowHeaders):
3599         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
3600         (AccessibilityUIElement::columnHeaders):
3601         (AccessibilityUIElement::rowHeaders):
3602         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3603         (WTR::AccessibilityUIElement::rowHeaders):
3604         (WTR::AccessibilityUIElement::columnHeaders):
3605         * efl/jhbuild.modules:
3606         * gtk/jhbuild.modules:
3607
3608 2014-02-27  Andres Gomez  <agomez@igalia.com>
3609
3610         Unreviewed. Add myself to watchlists
3611
3612         * Scripts/webkitpy/common/config/watchlist: Add myself to
3613         watchlists.
3614
3615 2014-02-27  Andres Gomez  <agomez@igalia.com>
3616
3617         Unreviewed. Add myself as a committer.
3618
3619         * Scripts/webkitpy/common/config/contributors.json:
3620
3621 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3622
3623         Unreviewed. Add Víctor Jáquez and myself to watchlists
3624
3625         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
3626         myself to watchlists.
3627
3628 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
3629
3630         Unreviewed. Add myself as a committer.
3631
3632         * Scripts/webkitpy/common/config/contributors.json:
3633
3634 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
3635
3636         Unreviewed. Moved myself to the list of committers.
3637
3638         * Scripts/webkitpy/common/config/contributors.json:
3639
3640 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
3641
3642         [GTK] Reduplicate common.top_level_path in scripts
3643         https://bugs.webkit.org/show_bug.cgi?id=129291
3644
3645         Reviewed by Philippe Normand.
3646
3647         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
3648         path manipulation and weird dependencies on the jhbuild infrastructure.
3649
3650         * Scripts/run-gtk-tests: Use common again.
3651         (TestRunner._setup_testing_environment): Ditto.
3652         * gtk/check-gdom-symbols: Ditto.
3653         * gtk/common.py:
3654         (top_level_path): Re-add top_level_path..
3655         (get_build_path): Use the builtin top_level_path again.
3656         * gtk/find-make-dist-errors: Use common again.
3657         (get_missing_headers): Ditto.
3658         * gtk/generate-inspector-gresource-manifest.py: Ditto.
3659
3660 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
3661
3662         runscript: line 42: /bin/ls: Argument list too long
3663         https://bugs.webkit.org/show_bug.cgi?id=129376
3664
3665         Reviewed by Michael Saboff.
3666
3667         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
3668         We should use find instead, which generates the list of files rather than expanding them all on 
3669         the command line and spitting them back out.
3670