More unreviewed GTK test gardening
[WebKit-https.git] / Tools / ChangeLog
1 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2
3         More unreviewed GTK test gardening
4
5         * TestWebKitAPI/glib/TestExpectations.json:
6
7 2018-07-27  Simon Fraser  <simon.fraser@apple.com>
8
9         Be more conservative with compositing layer creation when memory is low
10         https://bugs.webkit.org/show_bug.cgi?id=187866
11         rdar://problem/42366345
12
13         Reviewed by Zalan Bujtas.
14         
15         When process physical footprint is above a fraction of the jetsam limit, be more conservative in making
16         compositing layers. We avoid compositing for these situations:
17         1. Layers with 3D transforms which are affine (like translateZ(0)).
18         2. Layers with will-change
19         3. Layers for canvases (other than WebGL/WebGPU)
20         
21         We reuse some macOS code in MemoryPressureHandler() but choose different thresholds for iOS,
22         falling into "conservative mode" at 50% of jetsam limit, and "strict mode" at 65%.
23         Compositing chooses to be more conservative in either "conservative" or "strict" memory modes.
24         
25         Plumb through a "compositingPolicyOverride" both so that on-device testing isn't
26         flakily falling into a different mode, and so that we can impose the conservative
27         mode for testing.
28
29         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
30         (WTR::InjectedBundlePage::prepare):
31
32 2018-07-27  Michael Catanzaro  <mcatanzaro@igalia.com>
33
34         Unreviewed GTK test gardening
35
36         * TestWebKitAPI/glib/TestExpectations.json:
37
38 2018-07-27  Alex Christensen  <achristensen@webkit.org>
39
40         Fix API tests after r234314
41         https://bugs.webkit.org/show_bug.cgi?id=188077
42
43         Make API tests use new delegate method.
44
45         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
46         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
47         (-[WebsitePoliciesWebsiteDataStoreDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
48
49 2018-07-27  Alex Christensen  <achristensen@webkit.org>
50
51         Fix API tests after r234314
52         https://bugs.webkit.org/show_bug.cgi?id=188077
53
54         Make API tests use new delegate method.
55
56         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
57         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
58         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
59         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
60         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
61         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
62         (-[ContentBlockingWebsitePoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
63         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
64         (-[AsyncAutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
65         (-[CustomHeaderFieldsDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
66         (-[PopUpPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
67
68 2018-07-26  Andy VanWagoner  <andy@vanwagoner.family>
69
70         [INTL] Remove INTL sub-feature compile flags
71         https://bugs.webkit.org/show_bug.cgi?id=188081
72
73         Reviewed by Michael Catanzaro.
74
75         * Scripts/webkitperl/FeatureList.pm:
76         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
77
78 2018-07-26  Chris Dumez  <cdumez@apple.com>
79
80         Loading a file URL and then issuing a reload right away causes the load to fail due to sandboxing
81         https://bugs.webkit.org/show_bug.cgi?id=188078
82         <rdar://problem/42562493>
83
84         Reviewed by Geoff Garen.
85
86         Add API test coverage. It exercises the right code path but unfortunately is not yet a regression
87         test because TestWebKitAPI does not appear to be sandboxed (rdar://problem/42638129).
88
89         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
90         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm: Added.
91         (-[LoadFileThenReloadDelegate webView:didFinishNavigation:]):
92         (-[LoadFileThenReloadDelegate webView:didFailProvisionalNavigation:withError:]):
93         (-[LoadFileThenReloadDelegate webView:didFailNavigation:withError:]):
94         (TEST):
95
96 2018-07-26  Aaron Chu  <aaron_chu@apple.com>
97
98         Add Aaron Chu as a committer to contributors.json
99         https://bugs.webkit.org/show_bug.cgi?id=188066
100
101         Unreviwed. Added myself as committer.
102
103         * Scripts/webkitpy/common/config/contributors.json:
104
105 2018-07-26  Aakash Jain  <aakash_jain@apple.com>
106
107         [ews-build] Add build step to run API Tests
108         https://bugs.webkit.org/show_bug.cgi?id=188079
109
110         Reviewed by Lucas Forschler.
111
112         * BuildSlaveSupport/ews-build/steps.py:
113         (TestWithFailureCount): Common class for various tests with failure count.
114         (TestWithFailureCount.start): Configure Buildbot's logobserver.
115         (TestWithFailureCount.commandComplete): Updates the failure count.
116         (TestWithFailureCount.evaluateCommand): Set the step status appropriately.
117         (TestWithFailureCount.getResultSummary): Set the step summary appropriately.
118         (RunAPITests): Build step to run API tests.
119         (RunAPITests.countFailures): Count the failures by parsing the output.
120         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
121
122 2018-07-26  Ross Kirsling  <ross.kirsling@sony.com>
123
124         String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
125         https://bugs.webkit.org/show_bug.cgi?id=187963
126
127         Reviewed by Alex Christensen.
128
129         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
130         Add tests for String::split and String::splitAllowingEmptyEntries.
131
132         * TestWebKitAPI/Tests/WTF/StringView.cpp:
133         * WebKitTestRunner/TestController.cpp:
134         (WTR::updateTestOptionsFromTestHeader):
135         Update split/splitAllowingEmptyEntries usage.
136
137 2018-07-26  Commit Queue  <commit-queue@webkit.org>
138
139         Unreviewed, rolling out r234181 and r234189.
140         https://bugs.webkit.org/show_bug.cgi?id=188075
141
142         These are not needed right now (Requested by thorton on
143         #webkit).
144
145         Reverted changesets:
146
147         "Enable Web Content Filtering on watchOS"
148         https://bugs.webkit.org/show_bug.cgi?id=187979
149         https://trac.webkit.org/changeset/234181
150
151         "HAVE(PARENTAL_CONTROLS) should be true on watchOS"
152         https://bugs.webkit.org/show_bug.cgi?id=187985
153         https://trac.webkit.org/changeset/234189
154
155 2018-07-04  Darin Adler  <darin@apple.com>
156
157         Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly
158         https://bugs.webkit.org/show_bug.cgi?id=187333
159
160         Reviewed by Sam Weinig.
161
162         * TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Updated.
163         * TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Updated.
164         * TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Updated.
165         * TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Updated.
166         * TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Updated.
167
168 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
169
170         [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
171         https://bugs.webkit.org/show_bug.cgi?id=188031
172
173         Reviewed by Lucas Forschler.
174
175         * BuildSlaveSupport/ews-build/steps.py:
176         (DownloadBuiltProduct): Added build step DownloadBuiltProduct.
177         (ExtractBuiltProduct): Added build step ExtractBuiltProduct.
178         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
179
180 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
181
182         [ews-build] Add build step UploadBuiltProduct
183         https://bugs.webkit.org/show_bug.cgi?id=188016
184
185         Reviewed by Lucas Forschler.
186
187         * BuildSlaveSupport/ews-build/steps.py:
188         (UploadBuiltProduct): Added build step UploadBuiltProduct.
189         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
190
191 2018-07-25  Aakash Jain  <aakash_jain@apple.com>
192
193         [ews-build] Add build step ArchiveBuiltProduct
194         https://bugs.webkit.org/show_bug.cgi?id=188014
195
196         Reviewed by Lucas Forschler.
197
198         * BuildSlaveSupport/ews-build/steps.py:
199         (ArchiveBuiltProduct): Added build step ArchiveBuiltProduct.
200         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
201
202 2018-07-25  Chris Dumez  <cdumez@apple.com>
203
204         navigator.userAgent may return outdated value after webView.customUserAgent is set
205         https://bugs.webkit.org/show_bug.cgi?id=188009
206         <rdar://problem/42566456>
207
208         Reviewed by Alex Christensen.
209
210         Add API test coverage.
211
212         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
213         * TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm: Added.
214         (TEST):
215
216 2018-07-25  Charlie Turner  <cturner@igalia.com>
217
218         [Flatpak] Pass more environment variables to sandbox
219         https://bugs.webkit.org/show_bug.cgi?id=188002
220
221         Reviewed by Michael Catanzaro.
222
223         * flatpak/flatpakutils.py:
224         (WebkitFlatpak.run_in_sandbox):
225
226 2018-07-25  Zan Dobersek  <zdobersek@igalia.com>
227
228         [WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
229         https://bugs.webkit.org/show_bug.cgi?id=187997
230
231         Reviewed by Carlos Garcia Campos.
232
233         Instead of the raw wpe_view_backend_exportable_fdo API, switch to using
234         the EGL-oriented API that simply serves EGLImageKHR objects instead of
235         raw buffer resources. This allows us not to wrangle with creating and
236         managing lifetime of the same EGLImageKHR by ourselves.
237
238         ViewBackend now defines a wpe_view_backend_exportable_fdo_egl_client
239         struct and uses wpe_view_backend_exportable_fdo_egl_create() to create
240         the exportable object. This means that for each frame we're served an
241         EGLImageKHR object that is passed on to the displayBuffer()
242         implementation.
243
244         HeadlessViewBackend now just manages the pending and committed image
245         objects. Width and height values used during pixel data retrieval are
246         gathered from the ViewBackend's size that was specified when
247         constructed.
248
249         WindowViewBackend similarly only manages the committed image object,
250         not having to create an equivalent EGLImageKHR object from the raw
251         buffer resource anymore.
252
253         Unused EGL entrypoints in both HeadlessViewBackend and WindowViewBackend
254         classes are removed, and destructors for both classes are made virtual.
255
256         The WPEBackend-fdo version is bumped in order to have the EGL-specific
257         export API available.
258
259         * flatpak/org.webkit.WPE.yaml:
260         * wpe/backends/HeadlessViewBackend.cpp:
261         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
262         (WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
263         (WPEToolingBackends::HeadlessViewBackend::createSnapshot):
264         (WPEToolingBackends::HeadlessViewBackend::performUpdate):
265         (WPEToolingBackends::HeadlessViewBackend::displayBuffer):
266         * wpe/backends/HeadlessViewBackend.h:
267         * wpe/backends/ViewBackend.cpp:
268         (WPEToolingBackends::ViewBackend::initialize):
269         * wpe/backends/ViewBackend.h:
270         * wpe/backends/WindowViewBackend.cpp:
271         (WPEToolingBackends::WindowViewBackend::WindowViewBackend):
272         (WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
273         (WPEToolingBackends::WindowViewBackend::displayBuffer):
274         * wpe/backends/WindowViewBackend.h:
275         * wpe/jhbuild.modules:
276
277 2018-07-24  Thomas Denney  <tdenney@apple.com>
278
279         Remove support for the double type from WHLSL
280         https://bugs.webkit.org/show_bug.cgi?id=187977
281
282         Reviewed by Myles C. Maxfield.
283
284         * WebGPUShadingLanguageRI/All.js: Removed DoubleLiteral.js and DoubleLiteralType.js include.
285         * WebGPUShadingLanguageRI/DoubleLiteral.js: Removed.
286         * WebGPUShadingLanguageRI/DoubleLiteralType.js: Removed.
287         * WebGPUShadingLanguageRI/Intrinsics.js: Removed double arithmetic functions.
288         * WebGPUShadingLanguageRI/Parse.js:
289         (parseTerm): Removed parsing of double literals.
290         * WebGPUShadingLanguageRI/SPIRV.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
291         * WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed double type logic.
292         * WebGPUShadingLanguageRI/StandardLibrary.js: Removed double type declarations.
293         * WebGPUShadingLanguageRI/Test.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
294         * WebGPUShadingLanguageRI/Test.js: Removed tests that test doubles or ported them to use floats.
295         * WebGPUShadingLanguageRI/index.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
296
297 2018-07-24  Tim Horton  <timothy_horton@apple.com>
298
299         Enable Web Content Filtering on watchOS
300         https://bugs.webkit.org/show_bug.cgi?id=187979
301         <rdar://problem/42559346>
302
303         Reviewed by Wenson Hsieh.
304
305         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
306
307 2018-07-24  Daniel Bates  <dabates@apple.com>
308
309         Move-constructing NeverDestroyed should move construct underlying object instead of copy constructing it
310         https://bugs.webkit.org/show_bug.cgi?id=187971
311
312         Reviewed by Saam Barati.
313
314         Add unit tests to cover move constructing a NeverDestroyed with a non-const and const data type
315         as well as invoking makeNeverDestroyed() with the result of a function that returns a move-only
316         data type.
317
318         * TestWebKitAPI/CMakeLists.txt:
319         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
320         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.cpp: Added.
321         (TestWebKitAPI::MoveOnlyLifecycleLogger::MoveOnlyLifecycleLogger):
322         (TestWebKitAPI::MoveOnlyLifecycleLogger::~MoveOnlyLifecycleLogger):
323         (TestWebKitAPI::MoveOnlyLifecycleLogger::operator=):
324         (TestWebKitAPI::MoveOnlyLifecycleLogger::setName):
325         (TestWebKitAPI::TEST):
326         * TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.h: Added.
327         * TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
328         (TestWebKitAPI::TEST):
329
330 2018-07-24  Thomas Denney  <tdenney@apple.com>
331         Minor changes to the WHLSL interpreter to support the new compiler
332         https://bugs.webkit.org/show_bug.cgi?id=187728
333
334         Reviewed by Myles C. Maxfield.
335
336         This bug contains small changes that are make minor changes to the
337         behaviour of the existing interpreter (the tests are unaffected and all
338         still pass).
339
340         * WebGPUShadingLanguageRI/EnumType.js:
341         (EnumType.prototype.get isEnum): Property added to EnumType and Type
342         * WebGPUShadingLanguageRI/Evaluator.js: Correct typo
343         * WebGPUShadingLanguageRI/Func.js:
344         (Func.prototype.get isEntryPoint): Add boolean property
345         * WebGPUShadingLanguageRI/FuncInstantiator.js:
346         (FuncInstantiator.prototype.get instances): Public accessor for existing
347         private field
348         * WebGPUShadingLanguageRI/FunctionLikeBlock.js: Refactored the class so
349         that it directly wraps a Func instance (therefore the only interface
350         change is to the constructor and the addition of the func accessor).
351         This change allows the de-inlining of functions.
352         (FunctionLikeBlock):
353         (FunctionLikeBlock.prototype.get func):
354         (FunctionLikeBlock.prototype.get returnType):
355         (FunctionLikeBlock.prototype.get parameters):
356         (FunctionLikeBlock.prototype.get body):
357         * WebGPUShadingLanguageRI/Inliner.js: Use the new FunctionLikeBlock
358         constructor
359         (Inliner.prototype.visitCallExpression):
360         (Inliner):
361         * WebGPUShadingLanguageRI/Intrinsics.js: Migrate the swizzle operators
362         to native functions (with additional support in StandardLibrary.js).
363         This reduces first-time compile-time from around 4s to around 0.1s.
364         (Intrinsics):
365         * WebGPUShadingLanguageRI/Lexer.js: Ensure that the parsing of multiline
366         comments completes correctly
367         (Lexer.prototype.next):
368         (Lexer):
369         * WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Addition of type
370         property, which is based on the type of the lValue and the semantics of
371         the language (the @ operator yields an array reference with the thread
372         scope).
373         (MakeArrayRefExpression):
374         (MakeArrayRefExpression.prototype.get type):
375         * WebGPUShadingLanguageRI/NativeFunc.js: Add setter/getter for
376         implementationData to support swizzle operator change
377         (NativeFunc.prototype.get implementationData):
378         (NativeFunc.prototype.set implementationData):
379         * WebGPUShadingLanguageRI/Rewriter.js: Use new FunctionLikeBlock
380         constructor
381         (Rewriter.prototype.visitFunctionLikeBlock):
382         * WebGPUShadingLanguageRI/StandardLibrary.js:
383         (_generateSwizzle): Deleted.
384         * WebGPUShadingLanguageRI/SwizzleOp.js: Introduces a new class for
385         carrying metadata about swizzle operators so that they are implemented
386         as native functions rather than generated at compile time.
387         (SwizzleOp):
388         (SwizzleOp.prototype.get outSize):
389         (SwizzleOp.prototype.get components):
390         (SwizzleOp.prototype.get inSize):
391         (SwizzleOp.prototype.toString):
392         (SwizzleOp.allSwizzleOperators.):
393         (SwizzleOp.allSwizzleOperators):
394         * WebGPUShadingLanguageRI/StandardLibrary.js: +        (SwizzleOp):
395         (SwizzleOp.prototype.get outSize):
396         (SwizzleOp.prototype.get components):
397         (SwizzleOp.prototype.get inSize):
398         (SwizzleOp.prototype.toString):
399         (generateSwizzles):
400         (_generateSwizzle): Deleted.
401         * WebGPUShadingLanguageRI/Type.js: Addition of isEnum property, as
402         above.
403         (Type.prototype.get isEnum):
404
405 2018-07-24  Ryan Haddad  <ryanhaddad@apple.com>
406
407         Unreviewed, rolling out r234121.
408
409         Caused perf test failures.
410
411         Reverted changeset:
412
413         "We should cache the compiled sandbox profile in a data vault"
414         https://bugs.webkit.org/show_bug.cgi?id=184991
415         https://trac.webkit.org/changeset/234121
416
417 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
418
419         [Flatpak] Add openh264 as needed by WebRTC
420         https://bugs.webkit.org/show_bug.cgi?id=187956
421
422         Reviewed by Philippe Normand.
423
424         * flatpak/org.webkit.WebKit.yaml:
425
426 2018-07-24  Ross Kirsling  <ross.kirsling@sony.com>
427
428         WebCore::URL::hostIsIPAddress needs a Windows implementation
429         https://bugs.webkit.org/show_bug.cgi?id=187859
430
431         Reviewed by Fujii Hironori.
432
433         * TestWebKitAPI/Tests/WebCore/URL.cpp:
434         Check for a few other ways an IP address could be invalid.
435
436 2018-07-24  Charlie Turner  <cturner@igalia.com>
437
438         [Flatpak] Avoid consuming unknown arguments in flatpak wrapper
439         https://bugs.webkit.org/show_bug.cgi?id=187951
440
441         When running run-webkit-tests --wpe --debug, it was observed that
442         both self.platform != 'wpe' and self.debug != True. This turned
443         out to be because of the "args" argument consuming the remainder
444         of future arguments that came after it. Since the first argument
445         to load_from_args was the test script to run, it would end up
446         never processing the other arguments supplied to the wrapper
447         script.
448
449         Tested this by rebuilding GTK in debug mode, running the
450         minibrowser with various extra options, and running some tests
451         with various extra options.
452
453         Reviewed by Michael Catanzaro.
454
455         * flatpak/flatpakutils.py:
456         (WebkitFlatpak.load_from_args):
457
458 2018-07-24  Thibault Saunier  <tsaunier@igalia.com>
459
460         [Flatpak] Remove now unnecessary 'hacks' for running tests
461         https://bugs.webkit.org/show_bug.cgi?id=187608
462
463         Reviewed by Philippe Normand.
464
465         We used to need to not share X11 with the sandbox when running tests
466         but it is not needed anymore as we do not mount `/tmp` on `/tmp` in the
467         sandbox (we mount it on `/run/host/tmp` now).
468
469         This has the advantage of making running the MiniBrowser to display test
470         results working again.
471
472         * flatpak/flatpakutils.py:
473         (WebkitFlatpak.clean_args):
474         (WebkitFlatpak.run_in_sandbox):
475         (WebkitFlatpak._cleanup_faltpak_args_for_tests_if_needed): Deleted.
476
477 2018-07-23  Fujii Hironori  <Hironori.Fujii@sony.com>
478
479         webkitpy.port.server_process_unittest.TestServerProcess.test_basic failed on Windows Python
480         https://bugs.webkit.org/show_bug.cgi?id=187581
481
482         Reviewed by Daniel Bates.
483
484         There are two failures in this test case:
485         1. proc.poll() doesn't return 0.
486         2. stderr is not output.
487
488         For failure #1, this is expected. the process should not exit at
489         the time. proc.poll() should return None because the process is
490         still alive.
491
492         This change added a new test to check proc.poll() becomes 0 after
493         the process successfully exits.
494
495         For failure #2, stderr is not flushed even though stdout is
496         flushed. This change uses '-u' command switch to force stdin,
497         stdout and stderr to be totally unbuffered.
498
499         * Scripts/webkitpy/port/server_process_unittest.py:
500         (TestServerProcess.test_basic): Added -u command switch. Do not
501         flush stdout. Removed the special condition for Windows. Add a new
502         test to check proc.poll() returns 0.
503         (TestServerProcess.test_process_crashing): Added -u command
504         switch. Do not flush stdout.
505
506 2018-07-23  Ross Kirsling  <ross.kirsling@sony.com>
507
508         WTF::StringView::split should have an allowEmptyEntries flag
509         https://bugs.webkit.org/show_bug.cgi?id=187864
510
511         Reviewed by Konstantin Tokarev.
512
513         * TestWebKitAPI/Tests/WTF/StringView.cpp: Add test.
514
515 2018-07-23  Ben Richards  <benton_richards@apple.com>
516
517         We should cache the compiled sandbox profile in a data vault
518         https://bugs.webkit.org/show_bug.cgi?id=184991
519
520         Reviewed by Ryosuke Niwa.
521
522         Added trace points for sandbox initialization
523
524         * Tracing/SystemTracePoints.plist:
525
526 2018-07-23  Zalan Bujtas  <zalan@apple.com>
527
528         DRT relies on [webView display] to call -viewWillDraw on the WebHTMLView
529         https://bugs.webkit.org/show_bug.cgi?id=187924
530         <rdar://problem/41745884>
531
532         Reviewed by Simon Fraser.
533
534         WebKit relies on -viewWillDraw getting called on WebHTMLView, even though that view has not been marked as needing display.
535
536         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
537         (createBitmapContextFromWebView):
538
539 2018-07-23  Chris Dumez  <cdumez@apple.com>
540
541         WebResourceLoadStatisticsStore fails to unregister itself as a MessageReceiver in its destructor
542         https://bugs.webkit.org/show_bug.cgi?id=187910
543         <rdar://problem/42356526>
544
545         Reviewed by Brent Fulgham.
546
547         Add API test coverage.
548
549         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
550         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
551         (-[DisableITPDuringNavigationDelegate webView:didCommitNavigation:]):
552         (-[DisableITPDuringNavigationDelegate webView:didFinishNavigation:]):
553         (TEST):
554         * TestWebKitAPI/Tests/WebKitCocoa/notify-resourceLoadObserver.html: Added.
555
556 2018-07-23  Daniel Bates  <dabates@apple.com>
557
558         test-webkitpy should take configuration command line options
559         https://bugs.webkit.org/show_bug.cgi?id=187872
560
561         Reviewed by David Kilzer.
562
563         Add --debug and --release optional command line options and teach the test bots to invoke test-webkitpy
564         with the appropriate configuration. At the moment these options are only meaningful on Mac since they
565         effect the configuration lldbWebKitTester is built with and we only build lldbWebKitTester on Mac.
566
567         * BuildSlaveSupport/build.webkit.org-config/steps.py:
568         (RunPythonTests): Pass the configuration to test-webkitpy. On Mac this will effect
569         how lldbWebKitTester is built. All other ports do not make use of the specified configuration.
570         * Scripts/webkitpy/test/main.py:
571         (_build_lldb_webkit_tester): Modified to take the configuration to build lldbWebKitTester. If
572         the specified configuration is None then we fall back to using the default configuration (as set
573         by script set-webkit-configuration).
574         (Tester._parse_args): Add command line options --debug and --release to build lldbWebKitTester
575         with a Debug configuration and a Release configuration, respectively
576         (Tester._run_tests): Pass the configuration to build lldbWebKitTester that we parsed from
577         the command line options. It may be None if neither --debug nor --release were passed.
578
579 2018-07-23  Commit Queue  <commit-queue@webkit.org>
580
581         Unreviewed, rolling out r233030.
582         https://bugs.webkit.org/show_bug.cgi?id=187904
583
584         Broke tarball builds (Requested by mcatanzaro on #webkit).
585
586         Reverted changeset:
587
588         "run-gtk-tests (glib/common.py) cannot determine build
589         directory when webKitBranchBuild=true"
590         https://bugs.webkit.org/show_bug.cgi?id=185643
591         https://trac.webkit.org/changeset/233030
592
593 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
594
595         Fix lldb summarizers for HashMaps and HashSets
596         https://bugs.webkit.org/show_bug.cgi?id=187883
597
598         Reviewed by Dan Bates.
599         
600         HashMap and HashSet summarizers were broken in various ways.
601         
602         The 'type summary add -x' regexp needs to match at the start and end of the string
603         to avoid finding types nested inside other templates.
604         
605         The HashTable synthetic child code incorrectly used the type of the key, rather than
606         the value when synthesizing children.
607         
608         Add HashMap and HashSet summarizers.
609
610         I tried to get synthetic children working directly for HashMap and HashSet, but was unable.
611
612         * lldb/lldbWebKitTester/main.cpp:
613         (testSummaryProviders):
614         * lldb/lldb_webkit.py:
615         (__lldb_init_module):
616         (__lldb_init_module.lldb_webkit):
617         (WTFHashMap_SummaryProvider):
618         (WTFHashSet_SummaryProvider):
619         (WebCoreColorProvider._to_string_extended):
620         (WebCoreURLProvider.to_string):
621         (WTFHashMapProvider):
622         (WTFHashMapProvider.__init__):
623         (WTFHashMapProvider.tableSize):
624         (WTFHashMapProvider.keyCount):
625         (WTFHashSetProvider):
626         (WTFHashSetProvider.__init__):
627         (WTFHashSetProvider.tableSize):
628         (WTFHashSetProvider.keyCount):
629         (WTFHashTableProvider.tableSize):
630         (WTFHashTableProvider):
631         (WTFHashTableProvider.keyCount):
632         (WTFHashTableProvider.get_child_at_index):
633         (WTFHashTableProvider.update):
634         * lldb/lldb_webkit_unittest.py:
635         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
636         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
637         (TestSummaryProviders):
638         (TestSummaryProviders.serial_test_WTFHashMap_tablesize_and_size):
639         (TestSummaryProviders.serial_test_WTFHashMap_of_vectors_tablesize_and_size):
640         (TestSummaryProviders.serial_test_WTFHashSet_tablesize_and_size):
641
642 2018-07-21  Simon Fraser  <simon.fraser@apple.com>
643
644         Add lldb formatters for WebCore geometry types
645         https://bugs.webkit.org/show_bug.cgi?id=187884
646
647         Reviewed by Daniel Bates.
648         
649         Add lldb formatters for IntPoint, IntSize, IntRect, FloatPoint, FloatSize, FloatRect
650         and LayoutRect.
651         
652         Testing is blocked by webkit.org/b/187872.
653
654         * lldb/lldbWebKitTester/main.cpp:
655         (testSummaryProviders):
656         * lldb/lldb_webkit.py:
657         (__lldb_init_module.lldb_webkit):
658         (__lldb_init_module):
659         (WebCoreLayoutRect_SummaryProvider):
660         (WebCoreIntSize_SummaryProvider):
661         (WebCoreIntPoint_SummaryProvider):
662         (WebCoreFloatSize_SummaryProvider):
663         (WebCoreFloatPoint_SummaryProvider):
664         (WebCoreIntRect_SummaryProvider):
665         (WebCoreFloatRect_SummaryProvider):
666         (WebCoreLayoutRectProvider):
667         (WebCoreLayoutRectProvider.__init__):
668         (WebCoreLayoutRectProvider.get_x):
669         (WebCoreLayoutRectProvider.get_y):
670         (WebCoreLayoutRectProvider.get_width):
671         (WebCoreLayoutRectProvider.get_height):
672         (WebCoreIntPointProvider):
673         (WebCoreIntPointProvider.__init__):
674         (WebCoreIntPointProvider.get_x):
675         (WebCoreIntPointProvider.get_y):
676         (WebCoreIntSizeProvider):
677         (WebCoreIntSizeProvider.__init__):
678         (WebCoreIntSizeProvider.get_width):
679         (WebCoreIntSizeProvider.get_height):
680         (WebCoreIntRectProvider):
681         (WebCoreIntRectProvider.__init__):
682         (WebCoreIntRectProvider.get_x):
683         (WebCoreIntRectProvider.get_y):
684         (WebCoreIntRectProvider.get_width):
685         (WebCoreIntRectProvider.get_height):
686         (WebCoreFloatPointProvider):
687         (WebCoreFloatPointProvider.__init__):
688         (WebCoreFloatPointProvider.get_x):
689         (WebCoreFloatPointProvider.get_y):
690         (WebCoreFloatSizeProvider):
691         (WebCoreFloatSizeProvider.__init__):
692         (WebCoreFloatSizeProvider.get_width):
693         (WebCoreFloatSizeProvider.get_height):
694         (WebCoreFloatRectProvider):
695         (WebCoreFloatRectProvider.__init__):
696         (WebCoreFloatRectProvider.get_x):
697         (WebCoreFloatRectProvider.get_y):
698         (WebCoreFloatRectProvider.get_width):
699         (WebCoreFloatRectProvider.get_height):
700
701 2018-07-20  John Wilander  <wilander@apple.com>
702
703         Resource Load Statistics: Enable basic functionality in experimental debug mode
704         https://bugs.webkit.org/show_bug.cgi?id=187835
705         <rdar://problem/42408590>
706
707         Reviewed by Chris Dumez.
708
709         This patch makes the experimental ITP Debug Mode feature work, at least
710         to a basic level. All of the changes to TestRunner are to support the
711         layout tests for the functionality.
712
713         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
714         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
715         (WTR::InjectedBundle::didReceiveMessageToPage):
716         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
717         (WTR::TestRunner::setStatisticsDebugMode):
718         (WTR::TestRunner::statisticsCallDidSetDebugModeCallback):
719         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
720         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceForDebugModeCallback):
721         * WebKitTestRunner/InjectedBundle/TestRunner.h:
722         * WebKitTestRunner/TestController.cpp:
723         (WTR::TestController::setStatisticsDebugMode):
724         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
725         * WebKitTestRunner/TestController.h:
726         * WebKitTestRunner/TestInvocation.cpp:
727         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
728         (WTR::TestInvocation::didSetStatisticsDebugMode):
729         (WTR::TestInvocation::didSetPrevalentResourceForDebugMode):
730         * WebKitTestRunner/TestInvocation.h:
731
732 2018-07-20  Ryosuke Niwa  <rniwa@apple.com>
733
734         Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
735         https://bugs.webkit.org/show_bug.cgi?id=187846
736
737         Reviewed by Simon Fraser.
738
739         Fixed the bug that testRunner.execCommand was using the second argument as the value.
740
741         The second argument, aShowDefaultUI, should always be ignored in testRunner.execCommand,
742         and the third argument should be used as the value. DumpRenderTree's implementation does this already.
743
744         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
745         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
746         (WTR::TestRunner::execCommand):
747         * WebKitTestRunner/InjectedBundle/TestRunner.h:
748
749 2018-07-20  Dean Jackson  <dino@apple.com>
750
751         Accidentally checked in the wrong version of these files.
752
753         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
754         * lldb/lldbWebKitTester/main.cpp:
755         (testSummaryProviders):
756         * lldb/lldb_webkit_unittest.py:
757         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
758         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color): Deleted.
759         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color): Deleted.
760         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color): Deleted.
761         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color): Deleted.
762         (TestSummaryProviders.serial_test_WebCoreColorProvider_semantic_color): Deleted.
763
764 2018-07-20  Dean Jackson  <dino@apple.com>
765
766         Provide an lldb type summary for WebCore::Color
767         https://bugs.webkit.org/show_bug.cgi?id=187776
768
769         Reviewed by Dan Bates.
770
771         This time without the tests because we don't want to build
772         all of WebKit just for python tests.
773
774         * lldb/lldb_webkit.py: Add a Color summary provider.
775         (__lldb_init_module):
776         (WebCoreColor_SummaryProvider):
777         (WebCoreColorProvider):
778         (WebCoreColorProvider.__init__):
779         (WebCoreColorProvider._is_extended):
780         (WebCoreColorProvider._is_valid):
781         (WebCoreColorProvider._is_semantic):
782         (WebCoreColorProvider._to_string_extended):
783         (WebCoreColorProvider.to_string):
784
785 2018-07-20  Brady Eidson  <beidson@apple.com>
786
787         Add WKNavigation/WKNavigationAction related SPI.
788         https://bugs.webkit.org/show_bug.cgi?id=187826
789
790         Reviewed by Chris Dumez.
791
792         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
793         (-[NavigationActionHasNavigationDelegate webView:didFinishNavigation:]):
794         (-[NavigationActionHasNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
795         (TEST):
796
797 2018-07-20  Commit Queue  <commit-queue@webkit.org>
798
799         Unreviewed, rolling out r233943, r233988, r234004, and
800         r234012.
801         https://bugs.webkit.org/show_bug.cgi?id=187856
802
803         webkitpy tests are failing to build lldbWebKitTester
804         (Requested by ryanhaddad on #webkit).
805
806         Reverted changesets:
807
808         "Provide an lldb type summary for WebCore::Color"
809         https://bugs.webkit.org/show_bug.cgi?id=187776
810         https://trac.webkit.org/changeset/233943
811
812         "Provide an lldb type summary for WebCore::Color"
813         https://bugs.webkit.org/show_bug.cgi?id=187776
814         https://trac.webkit.org/changeset/233988
815
816         "Provide an lldb type summary for WebCore::Color"
817         https://bugs.webkit.org/show_bug.cgi?id=187776
818         https://trac.webkit.org/changeset/234004
819
820         "Provide an lldb type summary for WebCore::Color"
821         https://bugs.webkit.org/show_bug.cgi?id=187776
822         https://trac.webkit.org/changeset/234012
823
824 2018-07-20  Philippe Normand  <pnormand@igalia.com>
825
826         [GTK][WPE] enable-media-capabilities websetting
827         https://bugs.webkit.org/show_bug.cgi?id=187847
828
829         Reviewed by Carlos Garcia Campos.
830
831         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
832         (testWebKitSettings): Unit test for the new enable-media-capabilities setting.
833
834 2018-07-19  Carlos Garcia Campos  <cgarcia@igalia.com>
835
836         [GLIB] jsc_context_evaluate_in_object() should receive an instance when a JSCClass is given
837         https://bugs.webkit.org/show_bug.cgi?id=187798
838
839         Reviewed by Michael Catanzaro.
840
841         Update test cases to the new API and use a destroy function and vtable in the test case of calling
842         jsc_context_evaluate_in_object() with a JSCClass.
843
844         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
845         (testJSCEvaluateInObject):
846
847 2018-07-19  Ross Kirsling  <ross.kirsling@sony.com>
848
849         TestWTF.WTF.StringConcatenate_Unsigned fails for unsigned short on Windows
850         https://bugs.webkit.org/show_bug.cgi?id=187712
851
852         Reviewed by Fujii Hironori.
853
854         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
855         Mark result of unsigned short test case as platform-specific,
856         since Windows' behavior is actually *less* surprising here.
857
858 2018-07-19  Lucas Forschler  <lforschler@apple.com>
859
860         Teach the AWS Lambda to use the [minified]-platforms database
861         https://bugs.webkit.org/show_bug.cgi?id=187817
862         
863         Reviewed by David Kilzer.
864
865         * WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:
866         (lambda_handler): Add support for the platforms.webkit.org database
867         * WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:
868         (lambda_handler): Add support for the minified-platforms.webkit.org database
869
870 2018-07-19  Dean Jackson  <dino@apple.com>
871
872         Provide an lldb type summary for WebCore::Color
873         https://bugs.webkit.org/show_bug.cgi?id=187776
874
875         Dan Bates helped me with this attempted fix. Fingers crossed!
876
877         * Scripts/build-lldbwebkittester:
878
879 2018-07-19  Stephan Szabo  <stephan.szabo@sony.com>
880
881         [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector
882         https://bugs.webkit.org/show_bug.cgi?id=187786
883
884         Reviewed by Fujii Hironori.
885
886         * Scripts/webkitdirs.pm:
887         (generateBuildSystemFromCMakeProject): Turn on DEVELOPER_MODE
888         for WinCairo builds.
889
890 2018-07-19  Dean Jackson  <dino@apple.com>
891
892         Provide an lldb type summary for WebCore::Color
893         https://bugs.webkit.org/show_bug.cgi?id=187776
894
895         Another attempted build fix for Debug.
896
897         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
898         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj:
899
900 2018-07-19  Thomas Denney  <tdenney@apple.com>
901
902         [WHLSL] The interpreter doesn't support boolean short-circuiting
903         https://bugs.webkit.org/show_bug.cgi?id=187779
904
905         Reviewed by Alex Christensen.
906
907         * WebGPUShadingLanguageRI/Evaluator.js:
908         (Evaluator.prototype.visitLogicalExpression): RHS is only evaluated when necessary
909         * WebGPUShadingLanguageRI/Test.js:
910         (tests.booleanShortcircuiting): Adds 4 tests for the evaluation of logical expresions
911
912 2018-07-19  Dean Jackson  <dino@apple.com>
913
914         Provide an lldb type summary for WebCore::Color
915         https://bugs.webkit.org/show_bug.cgi?id=187776
916
917         Attempted build fix.
918
919         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
920
921 2018-07-19  Brady Eidson  <beidson@apple.com>
922
923         Add an SPI policy action to allow clients to explicitly ask for a new process on a navigation.
924         https://bugs.webkit.org/show_bug.cgi?id=187789
925
926         Reviewed by Andy Estes.
927
928         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
929         (-[PSONNavigationDelegate init]):
930         (-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
931
932 2018-07-19  Thibault Saunier  <tsaunier@igalia.com>
933
934         [Flatpak] Let flatpak process handle SIGINT
935         https://bugs.webkit.org/show_bug.cgi?id=187521
936
937         Reviewed by Philippe Normand.
938
939         Ensuring that flatpak process ends properly and that the sandbox is teard down.
940         It also avoids showing usless backtrace to the end user and makes gdb
941         much more usable.
942
943         Also make flatpakutils not verbose by default
944
945         * flatpak/flatpakutils.py:
946         (disable_signals):
947         (WebkitFlatpak.run_in_sandbox):
948         (WebkitFlatpak.run_gdb):
949
950 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
951
952         Unreviewed. Fix contributors entry.
953
954         * Scripts/webkitpy/common/config/contributors.json:
955
956 2018-07-18  Dean Jackson  <dino@apple.com>
957
958         Provide an lldb type summary for WebCore::Color
959         https://bugs.webkit.org/show_bug.cgi?id=187776
960
961         Reviewed by Dan Bates.
962
963         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
964             to get to WebCore.
965         * lldb/lldbWebKitTester/main.cpp:
966         (testSummaryProviders): Create some Color objects for testing.
967
968         * lldb/lldb_webkit.py: Add a Color summary provider.
969         (__lldb_init_module):
970         (WebCoreColor_SummaryProvider):
971         (WebCoreColorProvider):
972         (WebCoreColorProvider.__init__):
973         (WebCoreColorProvider._is_extended):
974         (WebCoreColorProvider._is_valid):
975         (WebCoreColorProvider._is_semantic):
976         (WebCoreColorProvider._to_string_extended):
977         (WebCoreColorProvider.to_string):
978
979         * lldb/lldb_webkit_unittest.py: Tests.
980         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
981         (TestSummaryProviders):
982         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
983         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
984         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
985         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
986
987 2018-07-18  Truitt Savell  <tsavell@apple.com>
988
989         Unreviewed, rolling out r233934.
990
991         Revision caused 5 webkitpy failures on Mac and broke webkitpy
992         testing on iOS simulator
993
994         Reverted changeset:
995
996         "Provide an lldb type summary for WebCore::Color"
997         https://bugs.webkit.org/show_bug.cgi?id=187776
998         https://trac.webkit.org/changeset/233934
999
1000 2018-07-18  Chris Dumez  <cdumez@apple.com>
1001
1002         REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebKit: WKBooleanGetValue + 9
1003         https://bugs.webkit.org/show_bug.cgi?id=187784
1004         <rdar://problem/42329230>
1005
1006         Reviewed by Brady Eidson.
1007
1008         When process swapping on navigation, WebPageProxy::reattachToWebProcess() unregisters the page as a MessageReceiver
1009         from the old WebProcessProxy and registers itself as a MessageReceiver for the new WebProcessProxy instead. This
1010         means that after this point, IPC sent by the previous WebProcess to its WebPageProxy will fail.
1011
1012         When we process swap, we also navigate the page in the old WebProcess to about:blank, when the navigation to
1013         about:blank would complete, the WebKitTestRunner's injected bundle would try and send IPC to the WebPageProxy
1014         which would fail and would cause WKBundlePagePostSynchronousMessageForTesting() to return a null result. WKTR
1015         would crash when dereferencing this null result. This patch addresses this by dealing with the potential null
1016         result.
1017
1018         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1019         (WTR::InjectedBundle::shouldProcessWorkQueue const):
1020
1021 2018-07-18  Dean Jackson  <dino@apple.com>
1022
1023         Provide an lldb type summary for WebCore::Color
1024         https://bugs.webkit.org/show_bug.cgi?id=187776
1025
1026         Reviewed by Dan Bates.
1027
1028         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Link against WebKit
1029             to get to WebCore.
1030         * lldb/lldbWebKitTester/main.cpp:
1031         (testSummaryProviders): Create some Color objects for testing.
1032
1033         * lldb/lldb_webkit.py: Add a Color summary provider.
1034         (__lldb_init_module):
1035         (WebCoreColor_SummaryProvider):
1036         (WebCoreColorProvider):
1037         (WebCoreColorProvider.__init__):
1038         (WebCoreColorProvider._is_extended):
1039         (WebCoreColorProvider._is_valid):
1040         (WebCoreColorProvider._is_semantic):
1041         (WebCoreColorProvider._to_string_extended):
1042         (WebCoreColorProvider.to_string):
1043
1044         * lldb/lldb_webkit_unittest.py: Tests.
1045         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
1046         (TestSummaryProviders):
1047         (TestSummaryProviders.serial_test_WebCoreColorProvider_invalid_color):
1048         (TestSummaryProviders.serial_test_WebCoreColorProvider_extended_color):
1049         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgb_color):
1050         (TestSummaryProviders.serial_test_WebCoreColorProvider_rgba_color):
1051
1052 2018-07-18  Stephan Szabo  <stephan.szabo@sony.com>
1053
1054         Adding myself to contributors.json
1055
1056         Unreviewed contributors.json change.
1057
1058         * Scripts/webkitpy/common/config/contributors.json:
1059
1060 2018-07-18  Jer Noble  <jer.noble@apple.com>
1061
1062         -_beginAnimatedResizeWithUpdates: can leave view in bad state if called during an existing animation
1063         https://bugs.webkit.org/show_bug.cgi?id=187739
1064         <rdar://problem/42304518>
1065
1066         Reviewed by Tim Horton.
1067
1068         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1069         (TEST):
1070
1071 2018-07-18  Jer Noble  <jer.noble@apple.com>
1072
1073         PiP from Element Fullscreen should match AVKit's behavior
1074         https://bugs.webkit.org/show_bug.cgi?id=187623
1075         <rdar://problem/41212379>
1076
1077         Reviewed by Jon Lee.
1078
1079         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1080         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html: Added.
1081         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm: Added.
1082         (-[ExitFullscreenOnEnterPiPUIDelegate _webView:hasVideoInPictureInPictureDidChange:]):
1083         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidEnterFullscreen:]):
1084         (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidExitFullscreen:]):
1085         (TestWebKitAPI::TEST):
1086
1087 2018-07-18  Aakash Jain  <aakash_jain@apple.com>
1088
1089         [ews-build] Add build step to run layout-test
1090         https://bugs.webkit.org/show_bug.cgi?id=187674
1091
1092         Reviewed by Lucas Forschler.
1093
1094         * BuildSlaveSupport/ews-build/steps.py:
1095         (RunWebKitTests): Added build step to run layout-tests. This is similar to current EWS.
1096         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1097         * BuildSlaveSupport/ews-build/factories.py: Added build-step to run layout-test in iOSSimulatorFactory.
1098
1099 2018-07-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1100
1101         Add SPI to defer running async script until after document load
1102         https://bugs.webkit.org/show_bug.cgi?id=187748
1103         <rdar://problem/42317378>
1104
1105         Reviewed by Ryosuke Niwa and Tim Horton.
1106
1107         Add an API test to verify that when the deferred async script configuration is set, async scripts will be
1108         executed after the DOMContentLoaded event.
1109
1110         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1111         * TestWebKitAPI/Tests/WebKitCocoa/RunScriptAfterDocumentLoad.mm: Added.
1112         (TEST):
1113
1114 2018-07-18  Charlie Turner  <cturner@igalia.com>
1115
1116         [WPE] Update WPEBackend in flatpak
1117         https://bugs.webkit.org/show_bug.cgi?id=187753
1118
1119         r233763 updated WPEBackend for the jhbuild, but not the flatpak. This
1120         caused WPE_BACKEND_CHECK_VERSION to not be defined, triggering a bug
1121         in the version guard,
1122
1123         #if defined(WPE_BACKEND_CHECK_VERSION) && WPE_BACKEND_CHECK_VERSION(0, 2, 0)
1124
1125         This doesn't work as intended, since the C preprocessor first expands
1126         all macro arguments in the #if expression before evaluating the
1127         expression. When WPE_BACKEND_CHECK_VERSION is not defined, this will
1128         lead to a syntax error and some head scratching.
1129
1130         A future patch should address the buggy macro check, when it is
1131         decided whether the assume the macro is always defined and bump
1132         the API requirements on WPEBackend, or to move the check into two
1133         conditionals to avoid the expansion problem.
1134
1135         Unreviewed build fix.
1136         
1137         * flatpak/org.webkit.WPE.yaml:
1138
1139 2018-07-18  Simon Fraser  <simon.fraser@apple.com>
1140
1141         Fix the parsing of colors in attributed string tests, and make it possible to dump the typing attributes
1142         https://bugs.webkit.org/show_bug.cgi?id=187747
1143
1144         Reviewed by Ryosuke Niwa.
1145         
1146         Add textInputController.attributedStringForTyping(), which returns a one-character
1147         attributed string whose attributes are the typing attributes, making it possible to
1148         test -[WebView typingAttributes].
1149         
1150         Sadly WebCore's convertObjcValueToValue() doesn't know how to convert NSDictionary,
1151         so we can't return -typingAttributes directly.
1152
1153         * DumpRenderTree/mac/TextInputControllerMac.m:
1154         (+[TextInputController isSelectorExcludedFromWebScript:]):
1155         (-[TextInputController attributedStringForTyping]):
1156
1157 2018-07-18  Carlos Garcia Campos  <cgarcia@igalia.com>
1158
1159         [GLIB] Add jsc_context_check_syntax() to GLib API
1160         https://bugs.webkit.org/show_bug.cgi?id=187694
1161
1162         Reviewed by Yusuke Suzuki.
1163
1164         Add a new test case.
1165
1166         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1167         (testJSCCheckSyntax):
1168         (main):
1169
1170 2018-07-17  Sihui Liu  <sihui_liu@apple.com>
1171
1172         REGRESSION: [macOS Sierra] TestWebKitAPI.WebKit.WebsiteDataStoreCustomPaths is a flaky failure
1173         https://bugs.webkit.org/show_bug.cgi?id=187066
1174         <rdar://problem/41609065>
1175
1176         Reviewed by Chris Dumez.
1177
1178         In r232668 we started to do reload if web process crashes by default. As we killed the web 
1179         process explicitly in this test, if web page got reloaded, messages would be sent again, 
1180         and flag set in message handler could keep the test continue to evaluate the expectation 
1181         without waiting for removeDataOfTypes to finish.
1182
1183         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1184         (-[WebsiteDataStoreCustomPathsMessageHandler webViewWebContentProcessDidTerminate:]):
1185         (TEST):
1186
1187 2018-07-17  Chris Dumez  <cdumez@apple.com>
1188
1189         Turn on PSON in WebKitTestRunner
1190         https://bugs.webkit.org/show_bug.cgi?id=186542
1191
1192         Reviewed by Brady Eidson.
1193
1194         Turn on PSON by default in WebKitTestRunner.
1195
1196         * WebKitTestRunner/TestOptions.h:
1197
1198 2018-07-17  Wenson Hsieh  <wenson_hsieh@apple.com>
1199
1200         Add an SPI hook to allow clients to yield document parsing and script execution
1201         https://bugs.webkit.org/show_bug.cgi?id=187682
1202         <rdar://problem/42207453>
1203
1204         Reviewed by Ryosuke Niwa.
1205
1206         Add a few tests to exercise the new document yield token SPI, verifying that clients can use the SPI to defer
1207         document load, and that doing so doesn't cause deferred `script` to execute in the wrong order (i.e. before
1208         synchronous script, or after "DOMContentLoaded").
1209
1210         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1211         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm: Added.
1212         (-[ParserYieldTokenPlugIn takeDocumentParserTokenAfterCommittingLoad]):
1213         (-[ParserYieldTokenPlugIn releaseDocumentParserToken]):
1214         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
1215         (-[ParserYieldTokenPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1216         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
1217         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didFinishLoadForFrame:]):
1218
1219         Add an injected bundle object that knows how to take and release multiple document parser yield tokens.
1220
1221         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.h: Added.
1222         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.mm: Added.
1223         (+[ParserYieldTokenTestWebView webView]):
1224         (-[ParserYieldTokenTestWebView bundle]):
1225         (-[ParserYieldTokenTestWebView schemeHandler]):
1226         (-[ParserYieldTokenTestWebView didFinishDocumentLoad]):
1227         (-[ParserYieldTokenTestWebView didFinishLoad]):
1228         (waitForDelay):
1229         (TEST):
1230         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h: Added.
1231         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.mm: Added.
1232         (-[TestURLSchemeHandler webView:startURLSchemeTask:]):
1233         (-[TestURLSchemeHandler webView:stopURLSchemeTask:]):
1234         (-[TestURLSchemeHandler setStartURLSchemeTaskHandler:]):
1235         (-[TestURLSchemeHandler startURLSchemeTaskHandler]):
1236         (-[TestURLSchemeHandler setStopURLSchemeTaskHandler:]):
1237         (-[TestURLSchemeHandler stopURLSchemeTaskHandler]):
1238
1239         Add a new test helper class to handle custom schemes via a block-based API.
1240
1241         * TestWebKitAPI/Tests/WebKitCocoa/text-with-async-script.html: Added.
1242
1243         New test HTML page that contains a deferred script element, a synchronous script element, another deferred
1244         script element, and then some text, images, and links.
1245
1246         * TestWebKitAPI/Tests/WebKitCocoa/text-with-deferred-script.html: Added.
1247
1248 2018-07-17  Truitt Savell  <tsavell@apple.com>
1249
1250         Adding myself to Contributors.json
1251
1252         Unreviewed
1253
1254         * Scripts/webkitpy/common/config/contributors.json:
1255
1256 2018-07-17  Aditya Keerthi  <akeerthi@apple.com>
1257
1258         [macOS] TestWebKitAPI.PictureInPicture.WKUIDelegate is timing out
1259         https://bugs.webkit.org/show_bug.cgi?id=187730
1260
1261         Reviewed by Jer Noble.
1262
1263         This regression was introduced by r233865. PIP can now only be initiated from a
1264         window that is on screen.
1265
1266         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
1267         (TestWebKitAPI::TEST):
1268
1269 2018-07-17  John Wilander  <wilander@apple.com>
1270
1271         Add completion handlers to TestRunner functions setStatisticsLastSeen(), setStatisticsPrevalentResource(), setStatisticsVeryPrevalentResource(), setStatisticsHasHadUserInteraction(), and setStatisticsHasHadNonRecentUserInteraction()
1272         https://bugs.webkit.org/show_bug.cgi?id=187710
1273         <rdar://problem/42252757>
1274
1275         Reviewed by Chris Dumez.
1276
1277         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1278         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1279         (WTR::InjectedBundle::didReceiveMessageToPage):
1280         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1281         (WTR::TestRunner::setStatisticsLastSeen):
1282         (WTR::TestRunner::statisticsCallDidSetLastSeenCallback):
1283         (WTR::TestRunner::setStatisticsPrevalentResource):
1284         (WTR::TestRunner::statisticsCallDidSetPrevalentResourceCallback):
1285         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
1286         (WTR::TestRunner::statisticsCallDidSetVeryPrevalentResourceCallback):
1287         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
1288         (WTR::TestRunner::setStatisticsHasHadNonRecentUserInteraction):
1289         (WTR::TestRunner::statisticsCallDidSetHasHadUserInteractionCallback):
1290         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1291         * WebKitTestRunner/TestController.cpp:
1292         (WTR::TestController::setStatisticsLastSeen):
1293         (WTR::TestController::setStatisticsPrevalentResource):
1294         (WTR::TestController::setStatisticsVeryPrevalentResource):
1295         (WTR::TestController::setStatisticsHasHadUserInteraction):
1296         (WTR::TestController::setStatisticsHasHadNonRecentUserInteraction):
1297         * WebKitTestRunner/TestInvocation.cpp:
1298         (WTR::TestInvocation::didSetLastSeen):
1299         (WTR::TestInvocation::didSetPrevalentResource):
1300         (WTR::TestInvocation::didSetVeryPrevalentResource):
1301         (WTR::TestInvocation::didSetHasHadUserInteraction):
1302         (WTR::TestInvocation::didSetHasHadNonRecentUserInteraction):
1303         * WebKitTestRunner/TestInvocation.h:
1304
1305 2018-07-16  Jeremy Jones  <jeremyj@apple.com>
1306
1307         Fix API Test failures introduced by r233865
1308         https://bugs.webkit.org/show_bug.cgi?id=187720
1309
1310         Unreviewed APITest fix after r233865.
1311
1312         Fullscreen can now only be initiated from a window that is on screen.
1313
1314         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
1315         (TestWebKitAPI::TEST):
1316         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm:
1317         (TestWebKitAPI::TEST):
1318
1319 2018-07-11  Dean Jackson  <dino@apple.com>
1320
1321         Allow removal of white backgrounds
1322         https://bugs.webkit.org/show_bug.cgi?id=187574
1323         <rdar://problem/41146792>
1324
1325         Reviewed by Simon Fraser.
1326
1327         Add a new menu item for punching out white backgrounds in MiniBrowser.
1328         In WebKitTestRunner, expose the new setting and hook that up to
1329         drawing a background in the WebView.
1330
1331         * MiniBrowser/mac/AppDelegate.m:
1332         (defaultConfiguration): Add _punchOutWhiteBackgroundsInDarkMode.
1333
1334         * MiniBrowser/mac/SettingsController.h: Ditto.
1335         * MiniBrowser/mac/SettingsController.m:
1336         (-[SettingsController _populateMenu]):
1337         (-[SettingsController validateMenuItem:]):
1338         (-[SettingsController togglePunchOutWhiteBackgroundsInDarkMode:]):
1339         (-[SettingsController punchOutWhiteBackgroundsInDarkMode]):
1340
1341         * MiniBrowser/mac/WK1BrowserWindowController.m:
1342         (-[WK1BrowserWindowController didChangeSettings]): Set the new preference.
1343
1344         * WebKitTestRunner/PlatformWebView.h: Expose a drawsBackground property.
1345         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Null implementation.
1346         (WTR::PlatformWebView::drawsBackground const):
1347         (WTR::PlatformWebView::setDrawsBackground):
1348         * WebKitTestRunner/wpe/PlatformWebViewWPE.cpp: Ditto.
1349         (WTR::PlatformWebView::drawsBackground const):
1350         (WTR::PlatformWebView::setDrawsBackground):
1351         * WebKitTestRunner/ios/PlatformWebViewIOS.mm: Call into the WKWebView and
1352         set its SPI.
1353         (WTR::PlatformWebView::drawsBackground const):
1354         (WTR::PlatformWebView::setDrawsBackground):
1355         * WebKitTestRunner/mac/PlatformWebViewMac.mm: Ditto.
1356         (WTR::PlatformWebView::drawsBackground const):
1357         (WTR::PlatformWebView::setDrawsBackground):
1358
1359         * WebKitTestRunner/TestController.cpp: Reset and copy the new preference.
1360         (WTR::TestController::resetPreferencesToConsistentValues):
1361         (WTR::updateTestOptionsFromTestHeader):
1362         * WebKitTestRunner/TestOptions.h:
1363         (WTR::TestOptions::hasSameInitializationOptions const):
1364
1365         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1366         (WTR::TestController::platformCreateWebView): If the option for punching
1367         out the background was set, tell the WebView to not draw its background.
1368
1369 2018-07-16  Aditya Keerthi  <akeerthi@apple.com>
1370
1371         [Datalist][macOS] Add suggestions UI for TextFieldInputTypes
1372         https://bugs.webkit.org/show_bug.cgi?id=186531
1373
1374         Reviewed by Tim Horton.
1375
1376         Added isShowingDatalistSuggestions testing hook in order to enable testing of the
1377         visibility of the suggestions view.
1378
1379         * DumpRenderTree/mac/UIScriptControllerMac.mm:
1380         (WTR::UIScriptController::isShowingDataListSuggestions const):
1381         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1382         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1383         (WTR::UIScriptController::isShowingDataListSuggestions const):
1384         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1385         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
1386         (WTR::UIScriptController::isShowingDataListSuggestions const):
1387
1388 2018-07-16  Yusuke Suzuki  <utatane.tea@gmail.com>
1389
1390         Add --target-path option to dump-class-layout
1391         https://bugs.webkit.org/show_bug.cgi?id=187687
1392
1393         Reviewed by Simon Fraser.
1394
1395         We add an escape hatch to dump-class-layout for specifying target path directly.
1396         This `--target-path` allows us to use dump-class-layout in the other ports
1397         like JSCOnly.
1398
1399         We can dump class layout if we build the target with clang by using the following command.
1400
1401         Tools/Scripts/dump-class-layout \
1402             --architecture=x86_64 \
1403             --target-path=path/to/libJavaScriptCore.so \
1404             JavaScriptCore \
1405             ScopeNode
1406
1407         * Scripts/dump-class-layout:
1408         (main):
1409
1410 2018-07-16  Sihui Liu  <sihui_liu@apple.com>
1411
1412         IndexedDB: closeAndDeleteDatabasesForOrigins should remove all databases for those origins
1413         https://bugs.webkit.org/show_bug.cgi?id=187631
1414         <rdar://problem/42164227>
1415
1416         Reviewed by Brady Eidson.
1417
1418         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1419         (TEST):
1420
1421 2018-07-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1422
1423         [GLIB] Add API to evaluate code using a given object to store global symbols
1424         https://bugs.webkit.org/show_bug.cgi?id=187639
1425
1426         Reviewed by Michael Catanzaro.
1427
1428         Add a new test case.
1429
1430         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1431         (testJSCEvaluateInObject):
1432         (testJSCExceptions):
1433         (main):
1434
1435 2018-07-15  Zan Dobersek  <zdobersek@igalia.com>
1436
1437         [webkitpy] run-web-platform-tests should allow specifying custom WPT metadata directories
1438         https://bugs.webkit.org/show_bug.cgi?id=187353
1439
1440         Reviewed by Youenn Fablet.
1441
1442         When using run-web-platform-tests, allow specifying custom WPT metadata
1443         directory. This will avoid generating such metadata-filled directory
1444         from the port-specific JSON expectations file, and instead will search
1445         for the metadata files and the include manifest inside the specified
1446         directory. The MANIFEST.json file will also be generated under there.
1447
1448         Rationale for this change is prototyping using custom metadata
1449         directories and avoiding generating all this content from a JSON file.
1450         Using this by default in the future would avoid sporradic changes in how
1451         WPT handles metadata .ini files and releases us from the obligation of
1452         adjusting the generator for every such change. This would also allow
1453         managing this metadata content in a separate repository, avoiding
1454         polluting the main webkit.org repository with thousands of .ini files.
1455
1456         If this turns out to be the preferable way of managing the metadata
1457         content, the JSON files under WebPlatformTests/ and the related code in
1458         wpt_runner.py would be removed.
1459
1460         * Scripts/webkitpy/w3c/wpt_runner.py:
1461         (parse_args):
1462         (WPTRunner._wpt_run_paths):
1463         (WPTRunner.run):
1464         * Scripts/webkitpy/w3c/wpt_runner_unittest.py:
1465         (WPTRunnerTest.test_run_with_specified_options):
1466
1467 2018-07-13  Ross Kirsling  <ross.kirsling@sony.com>
1468
1469         [WinCairo] run-api-tests is timing out for almost all test cases
1470         https://bugs.webkit.org/show_bug.cgi?id=187547
1471
1472         Reviewed by Fujii Hironori.
1473
1474         * Scripts/webkitpy/port/server_process.py:
1475         (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
1476         Still attempt to read from stdout/stderr even if the process has exited, as long as it's before the deadline.
1477
1478         * Scripts/webkitpy/port/server_process_unittest.py:
1479         (TestServerProcess.test_read_after_process_exits):
1480         Add test case.
1481
1482 2018-07-13  Ryan Haddad  <ryanhaddad@apple.com>
1483
1484         Add TestExpectations and baselines for iOS 12
1485         https://bugs.webkit.org/show_bug.cgi?id=187628
1486
1487         Reviewed by Alexey Proskuryakov.
1488
1489         * Scripts/webkitpy/port/ios.py:
1490         (IOSPort): Bump current version to 12.
1491
1492 2018-07-13  Ryan Haddad  <ryanhaddad@apple.com>
1493
1494         Add TestExpectations and baselines for Mojave.
1495         https://bugs.webkit.org/show_bug.cgi?id=187620
1496
1497         Reviewed by Alexey Proskuryakov.
1498
1499         * Scripts/webkitpy/port/mac.py:
1500         (MacPort): Bump current version to 10.14.
1501
1502 2018-07-13  Timothy Hatcher  <timothy@apple.com>
1503
1504         Add _drawsBackground to WKWebViewConfiguration.
1505         https://bugs.webkit.org/show_bug.cgi?id=187665
1506         rdar://problem/42182268
1507
1508         Reviewed by Tim Horton.
1509
1510         * TestWebKitAPI/Tests/WebKitCocoa/Configuration.mm:
1511         (TestWebKitAPI.WebKit.ConfigurationDrawsBackground): Added.
1512
1513 2018-07-13  Chris Dumez  <cdumez@apple.com>
1514
1515         Add a FrameLoaderClient willInjectUserScriptForFrame callback
1516         https://bugs.webkit.org/show_bug.cgi?id=187565
1517         <rdar://problem/42095701>
1518
1519         Unreviewed WKTR fix after r233782.
1520
1521         * WebKitTestRunner/TestInvocation.cpp:
1522         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1523
1524 2018-07-13  Chris Dumez  <cdumez@apple.com>
1525
1526         Reduce size of WebCore::URL
1527         https://bugs.webkit.org/show_bug.cgi?id=186820
1528         <rdar://problem/42087508>
1529
1530         Unreviewed, re-generates Service worker registrations database used by API tests after r233789.
1531
1532         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1533         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3: Removed.
1534         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-shm: Removed.
1535         * TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-3.sqlite3: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/SimpleServiceWorkerRegistrations-2.sqlite3-wal.
1536         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1537         (TEST):
1538
1539 2018-07-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1540
1541         Make it easier to hit the significant rendered text layout milestone on pages with main article elements
1542         https://bugs.webkit.org/show_bug.cgi?id=187578
1543         <rdar://problem/42104637>
1544
1545         Reviewed by Ryosuke Niwa.
1546
1547         Tweak an existing layout test to additionally check that the significant text layout milestone is fired on a
1548         page with an article element that is clearly the "main" content on the page (i.e. much taller than all other
1549         articles).
1550
1551         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1552         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone-article.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html.
1553         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html:
1554         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
1555         (TEST):
1556
1557 2018-07-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1558
1559         Change my status to be a WebKit reviewer.
1560
1561         Unreviewed status update.
1562
1563         * Scripts/webkitpy/common/config/contributors.json:
1564
1565 2018-07-12  Fujii Hironori  <Hironori.Fujii@sony.com>
1566
1567         Unreviewed contributors.json update
1568
1569         Just run "validate-committer-lists -c" to canonicalize the style.
1570
1571         * Scripts/webkitpy/common/config/contributors.json:
1572
1573 2018-07-12  Alex Christensen  <achristensen@webkit.org>
1574
1575         Reduce size of WebCore::URL
1576         https://bugs.webkit.org/show_bug.cgi?id=186820
1577
1578         Reviewed by Yusuke Suzuki and Youenn Fablet.
1579
1580         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1581         (TestWebKitAPI::TEST_F):
1582
1583 2018-07-12  Brady Eidson  <beidson@apple.com>
1584
1585         Make process-swap-on-navigation an experimental feature.
1586         <rdar://problem/41995053> and https://bugs.webkit.org/show_bug.cgi?id=187558
1587
1588         Reviewed by Chris Dumez.
1589
1590         Make sure WKTR doesn't enable ProcessSwapOnNavigation by default simply because it's an experimental feature.
1591
1592         * WebKitTestRunner/TestController.cpp:
1593         (WTR::TestController::createWebViewWithOptions):
1594         (WTR::TestController::resetPreferencesToConsistentValues):
1595
1596         * WebKitTestRunner/TestOptions.h:
1597         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const):
1598
1599 2018-07-12  Youenn Fablet  <youenn@apple.com>
1600
1601         Add a FrameLoaderClient willInjectUserScriptForFrame callback
1602         https://bugs.webkit.org/show_bug.cgi?id=187565
1603
1604         Reviewed by Alex Christensen.
1605
1606         Added new test runner API to check for willInjectUserScriptForFrame callback.
1607
1608         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1609         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1610         (WTR::InjectedBundle::resetUserScriptInjectedCount):
1611         (WTR::InjectedBundle::increaseUserScriptInjectedCount):
1612         (WTR::InjectedBundle::userScriptInjectedCount const):
1613         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1614         (WTR::InjectedBundlePage::InjectedBundlePage):
1615         (WTR::InjectedBundlePage::resetAfterTest):
1616         (WTR::InjectedBundlePage::willInjectUserScriptForFrame):
1617         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1618         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1619         (WTR::TestRunner::userScriptInjectedCount const):
1620         (WTR::TestRunner::injectUserScript):
1621         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1622         * WebKitTestRunner/TestController.cpp:
1623         (WTR::TestController::injectUserScript):
1624         * WebKitTestRunner/TestController.h:
1625         * WebKitTestRunner/TestInvocation.cpp:
1626         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1627         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1628         (WTR::TestController::injectUserScript):
1629
1630 2018-07-12  Sihui Liu  <sihui_liu@apple.com>
1631
1632         IndexedDB: database file of subframe cannot be removed
1633         https://bugs.webkit.org/show_bug.cgi?id=187564
1634
1635         Reviewed by Youenn Fablet.
1636
1637         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1638         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
1639         (TEST):
1640
1641 2018-07-12  Timothy Hatcher  <timothy@apple.com>
1642
1643         Make WebKit.LinkColorWithSystemAppearance work across system versions.
1644         https://bugs.webkit.org/show_bug.cgi?id=187573
1645
1646         Reviewed by Wenson Hsieh.
1647
1648         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
1649         (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Dynamically generate the expected string.
1650
1651 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1652
1653         [WPE] Pass the backend library name as command line parameter to the web process
1654         https://bugs.webkit.org/show_bug.cgi?id=186841
1655
1656         Reviewed by Žan Doberšek.
1657
1658         * MiniBrowser/wpe/main.cpp:
1659         (main): Stop using WPE_BACKEND_LIBRARY env var.
1660         * Scripts/run-wpe-tests:
1661         (WPETestRunner.__init__): Ditto.
1662         * Scripts/webkitpy/port/wpe.py:
1663         (WPEPort.setup_environ_for_server): Ditto.
1664         * wpe/backends/ViewBackend.cpp:
1665         (WPEToolingBackends::ViewBackend::ViewBackend): Call wpe_loader_init() to ensure WPEBackend-fdo is used.
1666         * wpe/jhbuild.modules: Upgrade WPEBackend to version 0.2.0.
1667
1668 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1669
1670         [GLIB] Add API to allow creating variadic functions
1671         https://bugs.webkit.org/show_bug.cgi?id=187517
1672
1673         Reviewed by Michael Catanzaro.
1674
1675         Add test cases.
1676
1677         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1678         (testJSCFunction):
1679         (fooCreateWithFooV):
1680         (multiplyFooV):
1681
1682 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1683
1684         [GLIB] Add jsc_context_get_global_object() to GLib API
1685         https://bugs.webkit.org/show_bug.cgi?id=187515
1686
1687         Reviewed by Michael Catanzaro.
1688
1689         Add test cases.
1690
1691         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1692         (testJSCGlobalObject):
1693         (main):
1694
1695 2018-07-11  Carlos Garcia Campos  <cgarcia@igalia.com>
1696
1697         [GLIB] Handle G_TYPE_STRV in glib API
1698         https://bugs.webkit.org/show_bug.cgi?id=187512
1699
1700         Reviewed by Michael Catanzaro.
1701
1702         Add test cases.
1703
1704         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
1705         (testJSCTypes):
1706         (joinFunction):
1707         (testJSCFunction):
1708
1709 2018-07-11  Aakash Jain  <aakash_jain@apple.com>
1710
1711         [ews-build] EWS should unapply patch and re-run jsc tests when patch fails jsc tests
1712         https://bugs.webkit.org/show_bug.cgi?id=187549
1713
1714         Reviewed by Alexey Proskuryakov.
1715
1716         * BuildSlaveSupport/ews-build/factories.py:
1717         (JSCTestsFactory.__init__):
1718         * BuildSlaveSupport/ews-build/steps.py:
1719         (CompileJSCOnlyToT): Build ToT without patch.
1720         (CompileJSCOnlyToT.doStepIf): Run this step only if patch failed to build.
1721         (RunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
1722         (ReRunJavaScriptCoreTests): Re-runs JSC tests.
1723         (ReRunJavaScriptCoreTests.doStepIf): Run this step only if patch failed JSC tests.
1724         (ReRunJavaScriptCoreTests.evaluateCommand): Set patchFailedJSCTests property appropriately.
1725         (RunJavaScriptCoreTestsToT): Run JSC tests on ToT without patch.
1726         (RunJavaScriptCoreTestsToT.doStepIf): Run this step only if patch failed JSC tests.
1727         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1728
1729 2018-07-11  Commit Queue  <commit-queue@webkit.org>
1730
1731         Unreviewed, rolling out r233742.
1732         https://bugs.webkit.org/show_bug.cgi?id=187577
1733
1734         Binary incompatible change with respect to Service Worker
1735         registration map (Requested by dydz on #webkit).
1736
1737         Reverted changeset:
1738
1739         "Reduce size of WebCore::URL"
1740         https://bugs.webkit.org/show_bug.cgi?id=186820
1741         https://trac.webkit.org/changeset/233742
1742
1743 2018-07-11  Aditya Keerthi  <akeerthi@apple.com>
1744
1745         REGRESSION (231276): Attempting to copy an image fails
1746         https://bugs.webkit.org/show_bug.cgi?id=187212
1747
1748         Reviewed by Ryosuke Niwa.
1749         <rdar://problem/41540074>
1750
1751         Augmented test to include a URL where the lastPathComponent looks similar to a
1752         file URL.
1753
1754         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
1755         * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
1756         (TestWebKitAPI::TEST):
1757
1758 2018-07-11  Alex Christensen  <achristensen@webkit.org>
1759
1760         Add SPI for immediate injection of user scripts
1761         https://bugs.webkit.org/show_bug.cgi?id=173342
1762         <rdar://problem/29202285>
1763
1764         Reviewed by Brady Eidson, Youenn Fablet, and Geoff Garen.
1765
1766         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
1767         (waitForMessage):
1768         (TEST):
1769
1770 2018-07-11  Myles C. Maxfield  <mmaxfield@apple.com>
1771
1772         Move WHLSL spec work to the W3C GPUWeb GitHub repository
1773
1774         See https://github.com/gpuweb/WHLSL
1775
1776         * WebGPUShadingLanguageRI/SpecWork/Makefile: Removed.
1777         * WebGPUShadingLanguageRI/SpecWork/WSL.g4: Removed.
1778         * WebGPUShadingLanguageRI/SpecWork/WSL.ott: Removed.
1779         * WebGPUShadingLanguageRI/SpecWork/source/conf.py: Removed.
1780         * WebGPUShadingLanguageRI/SpecWork/source/index.rst: Removed.
1781
1782 2018-07-11  Dean Jackson  <dino@apple.com>
1783
1784         Force WKTR to use the light appearance
1785         https://bugs.webkit.org/show_bug.cgi?id=187572
1786         <rdar://problem/42097805>
1787
1788         Reviewed by Simon Fraser.
1789
1790         Set the NSAppearance on the NSWindow to light mode.
1791
1792         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1793         (WTR::PlatformWebView::PlatformWebView): Use the Aqua appearance.
1794
1795 2018-07-11  Alex Christensen  <achristensen@webkit.org>
1796
1797         Reduce size of WebCore::URL
1798         https://bugs.webkit.org/show_bug.cgi?id=186820
1799
1800         Reviewed by Yusuke Suzuki.
1801
1802         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1803         (TestWebKitAPI::TEST_F):
1804
1805 2018-07-11  Youenn Fablet  <youenn@apple.com>
1806
1807         Fix remaining Cross-Origin-Resource-Policy failures, if any
1808         https://bugs.webkit.org/show_bug.cgi?id=186761
1809         <rdar://problem/41209829>
1810
1811         Reviewed by Alex Christensen.
1812
1813         * TestWebKitAPI/Tests/WebCore/HTTPParsers.cpp:
1814         (TestWebKitAPI::TEST):
1815
1816  2018-07-11  Aakash Jain  <aakash_jain@apple.com>
1817  
1818         [ews-build] EWS should unapply the patch and build ToT when patch fails to build
1819         https://bugs.webkit.org/show_bug.cgi?id=187358
1820  
1821         Reviewed by Alexey Proskuryakov.
1822  
1823         * BuildSlaveSupport/ews-build/factories.py:
1824         (BuildFactory.__init__):
1825         * BuildSlaveSupport/ews-build/steps.py:
1826         (CompileWebKit): Set haltOnFailure to false so as to run next steps (e.g.: un-apply patch, compile ToT).
1827         (CompileWebKit.evaluateCommand): Set patchFailedToBuild property.
1828         (CompileWebKitToT): Build ToT without patch.
1829         (CompileWebKitToT.doStepIf): Run this step only if patch failed to build.
1830         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests. Also lower-cased Release and Debug.
1831
1832 2018-07-11  Robin Morisset  <rmorisset@apple.com>
1833
1834         [WSL] WIP, more of the spec
1835         https://bugs.webkit.org/show_bug.cgi?id=186310
1836
1837         Rubberstamped by Filip Pizlo.
1838
1839         Fixed a few issues with the formal rules (such as adding the restrictions on pointers for compilation to SpirV),
1840         and started writing some of the english in the spec.
1841
1842         * WebGPUShadingLanguageRI/SpecWork/WSL.ott:
1843         * WebGPUShadingLanguageRI/SpecWork/source/index.rst:
1844
1845 2018-07-10  Aakash Jain  <aakash_jain@apple.com>
1846
1847         [ews-build] Add build step to UnApply patch
1848         https://bugs.webkit.org/show_bug.cgi?id=187357
1849
1850         Reviewed by Alexey Proskuryakov.
1851
1852         * BuildSlaveSupport/ews-build/steps.py:
1853         (UnApplyPatchIfRequired.__init__): Pass alwaysUseLatest parameter in order to unapply the patch.
1854         (UnApplyPatchIfRequired.doStepIf): Run this step only if patch failed to build or failed test. These
1855         properties will be set by build-steps for build and test.
1856         (UnApplyPatchIfRequired.hideStepIf): Hide this step if it is not run.
1857
1858 2018-07-10  Dewei Zhu  <dewei_zhu@apple.com>
1859
1860         Update ARES-6.patch file accordingly for r233631.
1861         https://bugs.webkit.org/show_bug.cgi?id=187534
1862
1863         Reviewed by Saam Barati.
1864
1865         Update ARES-6.patch file acoordingly after ARES-6 plan file change to
1866         avoid warning while applying the patch.
1867
1868         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
1869
1870 2018-07-10  Tim Horton  <timothy_horton@apple.com>
1871
1872         doAfterNextPresentationUpdate should not be called while content is hidden due to animated resize
1873         https://bugs.webkit.org/show_bug.cgi?id=187500
1874         <rdar://problem/41294139>
1875
1876         Reviewed by Simon Fraser.
1877
1878         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
1879         (-[AnimatedResizeWebView _endAnimatedResize]):
1880         Set didEndAnimatedResize before calling super, because it makes the
1881         new test easier and doesn't affect any of the existing ones.
1882
1883         (AnimatedResizeBlocksViewportFitChanges):
1884         This doAfterNextPresentationUpdate is always called during animated resize,
1885         and then synchronously waited for, so it /must/ use
1886         _doAfterNextPresentationUpdateWithoutWaitingForAnimatedResizeWithTesting.
1887         
1888         (AnimatedResizeBlocksDoAfterNextPresentationUpdate):
1889         Add a test ensuring that doAfterNextPresentationUpdate is deferred
1890         until endAnimatedResize is called.
1891
1892         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
1893         (-[WKWebView _test_waitForDidFinishNavigation]):
1894         _test_waitForDidFinishNavigation is sometimes called during animated resize,
1895         and synchronously waits for a doAfterNextPresentationUpdate, so
1896         it cannot wait for the animated resize to complete.
1897
1898 2018-07-10  Fujii Hironori  <Hironori.Fujii@sony.com>
1899
1900         [GTK][WPE] TestWTF and TestJSC fail to compile due to missing forwarding headers
1901         https://bugs.webkit.org/show_bug.cgi?id=184441
1902
1903         Reviewed by Michael Catanzaro.
1904
1905         All executables of TestWebKitAPI need the forwarding headers of
1906         WebCore and PAL because config.h includes
1907         <WebCore/PlatformExportMacros.h> and <pal/ExportMacros.h>.
1908
1909         The forwarding headers of WebCore are generated by
1910         generate-forwarding-headers.pl in GTK and WPE ports. The
1911         forwarding headers of PAL are generated by
1912         WEBKIT_MAKE_FORWARDING_HEADERS in all CMake ports.
1913
1914         * TestWebKitAPI/PlatformGTK.cmake: Added PALForwardingHeaders to
1915         ForwardingHeadersForTestWebKitAPI_NAME. Added dependencies of
1916         ${ForwardingHeadersForTestWebKitAPI_NAME} to TestJSC.
1917         * TestWebKitAPI/PlatformWPE.cmake: Ditto.
1918
1919 2018-07-10  Stephan Szabo  <stephan.szabo@sony.com>
1920
1921         [WinCairo] Support display of webinspector ui on non-legacy minibrowser
1922         https://bugs.webkit.org/show_bug.cgi?id=187415
1923
1924         Reviewed by Brian Burg.
1925
1926         * MiniBrowser/win/WebKitBrowserWindow.cpp:
1927         (WebKitBrowserWindow::WebKitBrowserWindow):
1928
1929 2018-07-10  John Wilander  <wilander@apple.com>
1930
1931         Resource Load Statistics: Make testRunner.statisticsResetToConsistentState() take a completion handler
1932         https://bugs.webkit.org/show_bug.cgi?id=187499
1933         <rdar://problem/41999431>
1934
1935         Reviewed by Chris Dumez.
1936
1937         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1938         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1939         (WTR::InjectedBundle::didReceiveMessageToPage):
1940         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1941         (WTR::TestRunner::statisticsResetToConsistentState):
1942         (WTR::TestRunner::statisticsCallDidResetToConsistentStateCallback):
1943         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1944         * WebKitTestRunner/TestController.cpp:
1945         (WTR::TestController::statisticsResetToConsistentState):
1946         * WebKitTestRunner/TestInvocation.cpp:
1947         (WTR::TestInvocation::didResetStatisticsToConsistentState):
1948         * WebKitTestRunner/TestInvocation.h:
1949
1950 2018-07-10  Ryosuke Niwa  <rniwa@webkit.org>
1951
1952         Disable cross-origin-window-policy by default
1953         https://bugs.webkit.org/show_bug.cgi?id=187509
1954
1955         Reviewed by Chris Dumez.
1956
1957         Enable the feature for testing purposes. DumpRenderTree does this already in enableExperimentalFeatures.
1958
1959         * WebKitTestRunner/TestController.cpp:
1960         (WTR::TestController::resetPreferencesToConsistentValues):
1961
1962 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
1963
1964         [Flatpak] Feature options to build-webkit and --makeargs are not passed inside the sandbox
1965         https://bugs.webkit.org/show_bug.cgi?id=187470
1966
1967         Reviewed by Philippe Normand.
1968
1969         Never force building, the user is responsible to make that decision and the workflow is
1970         now based on external scripts so it doesn't make sense anymore. Doing that leads
1971         to ignoring the options the user passed in.
1972
1973         * flatpak/flatpakutils.py:
1974         (WebkitFlatpak.setup_dev_env):
1975
1976 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
1977
1978         [Flatpak] Fix running wpt tests inside flatpak
1979         https://bugs.webkit.org/show_bug.cgi?id=187490
1980
1981         Reviewed by Philippe Normand.
1982
1983         Still not *all* passing but a big majority do.
1984
1985         * Scripts/webkitpy/w3c/wpt_runner.py:
1986         (main): Generate the /etc/hosts and mount it in flatpak as required.
1987         (WPTRunner.prepare_wpt_checkout): Renamed as we need to first checkout WPT code before generating /etc/hosts.
1988         (WPTRunner._prepare_wpt_checkout): Deleted.
1989         * flatpak/flatpakutils.py: Added a stdout= argument to run_in_sandbox() and
1990         added a way to pass extra env to flatpak itself (so we can mount /etc/hosts).
1991         Stopped passing `--device=all` as it is not required since r233638 (Bug 187400).
1992         * flatpak/org.webkit.WebKit.yaml: Added virtualenv for python2 as required by wpt.
1993
1994 2018-07-10  Thibault Saunier  <tsaunier@igalia.com>
1995
1996         [Flatpak] Use logging to print debug information
1997         https://bugs.webkit.org/show_bug.cgi?id=187496
1998
1999         Reviewed by Philippe Normand.
2000
2001         * flatpak/flatpakutils.py:
2002         (WebkitFlatpak.load_from_args):
2003         (WebkitFlatpak.clean_args):
2004         (WebkitFlatpak.run_in_sandbox):
2005
2006 2018-07-09  Timothy Hatcher  <timothy@apple.com>
2007
2008         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
2009         https://bugs.webkit.org/show_bug.cgi?id=187425
2010         rdar://problem/39948240
2011         rdar://problem/41796865
2012
2013         Reviewed by Tim Horton.
2014
2015         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
2016         (TestWebKitAPI.WebKit.LinkColorWithSystemAppearance): Use new color value.
2017
2018 2018-07-09  Simon Fraser  <simon.fraser@apple.com>
2019
2020         Fix dump-class-layout to show bit padding, and fix issues with padding offsets
2021         https://bugs.webkit.org/show_bug.cgi?id=187442
2022
2023         Reviewed by Daniel Bates.
2024         
2025         Synthetic padding members were shown with the wrong offset because they used the
2026         absolute offset rather than the class-relative offset. This didn't change the padding
2027         math, but made the output confusing.
2028         
2029         Also add support for showing empty bits in bitfields, and fix computation of padding
2030         after bitfields. Empty bits are computed by inserting a bit padding member after
2031         a bitfield that is not followed by another bitfield (making the assumption that bit
2032         padding will fill to the next byte boundary).
2033         
2034         The computation of padding after bitfields was also wrong, since lldb's member_type.GetByteSize()
2035         just reports the size of the type without the bitfield modifier (e.g. for "unsigned : 2" it returned 4).
2036         Fix by setting the byte size for bitfield fields to the number of bits rounded up to the next byte;
2037         this allows byte padding following the bitfield to be computed correctly.
2038         
2039         Add or modify test to cover these issues.
2040
2041         * lldb/dump_class_layout_unittest.py:
2042         (serial_test_ClassWithPaddedBitfields):
2043         (serial_test_MemberHasBitfieldPadding):
2044         (serial_test_InheritsFromClassWithPaddedBitfields):
2045         * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
2046         (avoidClassDeadStripping):
2047         * lldb/lldb_dump_class_layout.py:
2048         (ClassLayoutBase):
2049         (ClassLayoutBase._to_string_recursive):
2050         (ClassLayout._parse):
2051         (ClassLayout._compute_padding_recursive):
2052
2053 2018-07-09  Youenn Fablet  <youenn@apple.com>
2054
2055         StringView operator==(char*) should check the length of the string
2056         https://bugs.webkit.org/show_bug.cgi?id=187422
2057
2058         Reviewed by Chris Dumez.
2059
2060         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2061         (TestWebKitAPI::equal2):
2062         (TestWebKitAPI::TEST):
2063
2064 2018-07-09  Ross Kirsling  <rkirsling@gmail.com>
2065
2066         [WinCairo] httpd service install needs to precede server start
2067         https://bugs.webkit.org/show_bug.cgi?id=187283
2068
2069         Reviewed by Daniel Bates.
2070
2071         * Scripts/webkitpy/port/base.py:
2072         (Port.check_build):
2073         Remove unused parameter `needs_http`.
2074         
2075         (Port.check_sys_deps):
2076         (Port.start_http_server):
2077         Move `check_httpd` call.
2078
2079         * Scripts/webkitpy/port/win.py:
2080         (WinPort.check_httpd): Added.
2081         (WinCairoPort.check_httpd): Deleted.
2082         Move `httpd -k install` logic to common Windows location.
2083
2084         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2085         (Manager._set_up_run):
2086         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2087         * Scripts/webkitpy/port/gtk.py:
2088         (GtkPort.check_sys_deps):
2089         * Scripts/webkitpy/port/ios_simulator.py:
2090         (IOSSimulatorPort.check_sys_deps):
2091         * Scripts/webkitpy/port/mock_drt.py:
2092         (MockDRTPort.check_build):
2093         (MockDRTPort.check_sys_deps):
2094         * Scripts/webkitpy/port/port_testcase.py:
2095         (PortTestCase.integration_test_check_sys_deps):
2096         (test_check_build):
2097         * Scripts/webkitpy/port/test.py:
2098         * Scripts/webkitpy/port/wpe.py:
2099         (WPEPort.check_sys_deps):
2100         * Scripts/webkitpy/tool/commands/perfalizer.py:
2101         (PerfalizerTask.run):
2102         Remove `needs_http` arguments.
2103
2104 2018-07-09  Philippe Normand  <pnormand@igalia.com>
2105
2106         [Flatpak] Unreviewed, switch to https for the gst-libav tarball.
2107         
2108         * flatpak/org.webkit.WebKit.yaml:
2109
2110 2018-07-09  Thibault Saunier  <tsaunier@igalia.com>
2111
2112         [Flatpak] HTTP layout tests broken due to missing CGI.pm in the sandbox
2113         https://bugs.webkit.org/show_bug.cgi?id=187384
2114
2115         Reviewed by Philippe Normand.
2116
2117         And make it usable inside the sandbox even when
2118         perl is launched "tainted" (as the PERL5LIB won't
2119         work otherwise).
2120
2121         * flatpak/flatpakutils.py:
2122         (WebkitFlatpak.run_in_sandbox):
2123         * flatpak/org.webkit.WebKit.yaml:
2124
2125 2018-07-09  Thibault Saunier  <tsaunier@igalia.com>
2126
2127         [WPE][GTK] Mount /dev/shm on /run/shm in sandbox
2128         https://bugs.webkit.org/show_bug.cgi?id=187400
2129
2130         Reviewed by Philippe Normand.
2131
2132         This is where it is expected to be when it is a symlink,
2133         without mounting it the websocket python server can't work
2134         inside the sandbox.
2135
2136         * flatpak/flatpakutils.py:
2137         (WebkitFlatpak.run_in_sandbox):
2138
2139 2018-07-08  Filip Pizlo  <fpizlo@apple.com>
2140
2141         run-benchmark should run ARES-6 1.0.1
2142         https://bugs.webkit.org/show_bug.cgi?id=187452
2143
2144         Reviewed by Sam Weinig.
2145         
2146         We forgot to update this when we released 1.0.1!
2147
2148         * Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
2149
2150 2018-07-07  Youenn Fablet  <youenn@apple.com>
2151
2152         WPT importer should create dummy HTML files for *.window.js script files
2153         https://bugs.webkit.org/show_bug.cgi?id=187426
2154
2155         Reviewed by Ryosuke Niwa.
2156
2157         Some WPT tests use *.window.js tests, which should be accessed as *.window.html.
2158         Do the same strategy as done for worker.js/any.js files.
2159
2160         * Scripts/webkitpy/w3c/test_importer.py:
2161         (TestImporter.write_html_files_for_templated_js_tests):
2162
2163 2018-07-07  Wenson Hsieh  <wenson_hsieh@apple.com>
2164
2165         Introduce a layout milestone to track when the document contains a large number of rendered characters
2166         https://bugs.webkit.org/show_bug.cgi?id=187412
2167         <rdar://problem/41744338>
2168
2169         Reviewed by Ryosuke Niwa.
2170
2171         Add a new API test to check that we observe the new rendering milestone in an article-like document.
2172
2173         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2174         * TestWebKitAPI/Tests/WebKitCocoa/significant-text-milestone.html: Added.
2175         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
2176         (TEST):
2177
2178 2018-06-30  Simon Fraser  <simon.fraser@apple.com>
2179
2180         dump-class-layout reports wrong padding in many cases
2181         https://bugs.webkit.org/show_bug.cgi?id=185801
2182
2183         Reviewed by Dan Bates.
2184         
2185         Enhance dump-class-layout, fixing bugs and adding unit tests. This also includes
2186         the patch from bug 187141.
2187         
2188         Move the code that uses lldb to fetch the class layout to its own module,
2189         lldb_dump_class_layout.py, so it can be unit tested. Change this code
2190         to build up a data structure for the class. This is necessary since correct
2191         padding computation is easier with second traversal over the data structure.
2192         
2193         Try to deal with the empty base class optimization, which is necessary to report
2194         correct padding in classes using std::unique_ptr, and correctly handle virtual base classes.
2195         
2196         The ClassLayoutBase class knows how to test for equality and generate a string
2197         or string list representation of itself. The derived ClassLayout class knows
2198         how to build up the class layout using the lldb Python bindings.
2199         
2200         Finally we wrap the lldb debugger instance in LLDBDebuggerInstance so that we don't
2201         have to make a new one for each unit test. The tests have to run serially.
2202         
2203         Add to lldbWebKitTester a .cpp file that contains a set of C++ classes to unit-test
2204         dump-class-layout.
2205
2206         * Scripts/dump-class-layout:
2207         (main):
2208         * lldb/dump_class_layout_unittest.py:
2209         (destroy_cached_debug_session):
2210         (TestDumpClassLayout):
2211         (TestDumpClassLayout.setUpClass):
2212         (TestDumpClassLayout.setUp):
2213         (TestDumpClassLayout.serial_test_BasicClassLayout):
2214         (serial_test_PaddingBetweenClassMembers):
2215         (serial_test_BoolPaddingClass):
2216         (serial_test_ClassWithEmptyClassMembers):
2217         (serial_test_SimpleVirtualClass):
2218         (serial_test_SimpleVirtualClassWithNonVirtualBase):
2219         (serial_test_InterleavedVirtualNonVirtual):
2220         (serial_test_ClassWithTwoVirtualBaseClasses):
2221         (serial_test_ClassWithClassMembers):
2222         (serial_test_ClassWithBitfields):
2223         (serial_test_ClassWithUniquePtrs):
2224         (serial_test_ClassWithOptionals):
2225         (TestDumpClassLayout.test_BasicClassLayout): Deleted.
2226         * lldb/lldbWebKitTester/DumpClassLayoutTesting.cpp:
2227         (EmptyClass::doStuff):
2228         (VirtualBaseClass::~VirtualBaseClass):
2229         (VirtualBaseClass2::~VirtualBaseClass2):
2230         (SimpleVirtualClass::~SimpleVirtualClass):
2231         (SimpleVirtualClass::doStuff):
2232         (SimpleVirtualClassWithNonVirtualBase::~SimpleVirtualClassWithNonVirtualBase):
2233         (SimpleVirtualClassWithNonVirtualBase::doStuff):
2234         (avoidClassDeadStripping):
2235         * lldb/lldb_dump_class_layout.py:
2236         (ansi_colors):
2237         (ClassLayoutBase):
2238         (ClassLayoutBase.__init__):
2239         (ClassLayoutBase.__ne__):
2240         (ClassLayoutBase.__eq__):
2241         (ClassLayoutBase._to_string_recursive):
2242         (ClassLayoutBase.as_string_list):
2243         (ClassLayoutBase.as_string):
2244         (ClassLayoutBase.dump):
2245         (ClassLayoutExpected):
2246         (ClassLayoutExpected.__init__):
2247         (ClassLayout):
2248         (ClassLayout.__init__):
2249         (ClassLayout._has_polymorphic_base_class):
2250         (ClassLayout._parse):
2251         (ClassLayout._probably_has_empty_base_class_optimization):
2252         (ClassLayout._compute_padding_recursive):
2253         (ClassLayout._compute_padding):
2254         (LLDBDebuggerInstance):
2255         (LLDBDebuggerInstance.__init__):
2256         (LLDBDebuggerInstance.__del__):
2257         (LLDBDebuggerInstance._get_first_file_architecture):
2258         (LLDBDebuggerInstance.layout_for_classname):
2259         (ClassLayoutDumper): Deleted.
2260         (ClassLayoutDumper.__init__): Deleted.
2261         (ClassLayoutDumper._get_first_file_architecture): Deleted.
2262         (ClassLayoutDumper.verify_type): Deleted.
2263         (ClassLayoutDumper.verify_type_recursive): Deleted.
2264         (ClassLayoutDumper._class_layout_as_string): Deleted.
2265         (ClassLayoutDumper.dump_to_string): Deleted.
2266         (ClassLayoutDumper.dump): Deleted.
2267
2268 2018-07-06  Christopher Reid  <chris.reid@sony.com>
2269
2270         [WinCairo] WebKit MiniBrowser crashes when attempting to navigate to certain URLs
2271         https://bugs.webkit.org/show_bug.cgi?id=187167
2272
2273         Reviewed by Alex Christensen.
2274
2275         A null byte was written past the end of the buffer causing the crash.
2276         Some of the heap allocated buffers were also not getting deleted.
2277
2278         * MiniBrowser/win/WebKitBrowserWindow.cpp:
2279
2280 2018-07-06  Thibault Saunier  <tsaunier@igalia.com>
2281
2282         [WPE][GTK] Build php zlib plugin and enable sockets in flatpak
2283         https://bugs.webkit.org/show_bug.cgi?id=187401
2284
2285         Reviewed by Philippe Normand.
2286
2287         * flatpak/org.webkit.WebKit.yaml:
2288
2289 2018-07-06  Aakash Jain  <aakash_jain@apple.com>
2290
2291         [ews-build] EWS should run javascriptcore tests
2292         https://bugs.webkit.org/show_bug.cgi?id=187365
2293
2294         Reviewed by David Kilzer.
2295
2296         * BuildSlaveSupport/ews-build/steps.py: Added step to run JavaScriptCoreTests.
2297         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2298         * BuildSlaveSupport/ews-build/factories.py:
2299
2300 2018-07-06  Carlos Garcia Campos  <cgarcia@igalia.com>
2301
2302         [GTK][WPE] REGRESSION(r233111): Test /webkit/WebKitUserContentManager/script-message-received fails
2303         https://bugs.webkit.org/show_bug.cgi?id=187383
2304
2305         Reviewed by Žan Doberšek.
2306
2307         This is actually a problem in the test itself. The problem is that we run js, connect to message-received and
2308         quite the main loop when the message is received, which happens before the run js operation has been
2309         completed. The test finishes early and since r233111 an IPC message is still pending (I guess the run js
2310         callback) and the web page is still protected. Just adding a run loop operation before finishing the test would
2311         fix it. We should wait for the js run to complete, instead of the message.
2312
2313         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
2314         (UserScriptMessageTest::scriptMessageReceived):
2315         (UserScriptMessageTest::waitUntilMessageReceived):
2316         (UserScriptMessageTest::runJavaScriptFinished):
2317         (UserScriptMessageTest::postMessageAndWaitUntilReceived):
2318
2319 2018-07-05  Youenn Fablet  <youenn@apple.com>
2320
2321         REGRESSION (r230843): Flash doesn't work; Produces blue box on page
2322         https://bugs.webkit.org/show_bug.cgi?id=187346
2323         <rdar://problem/41773974>
2324
2325         Reviewed by Ryosuke Niwa.
2326
2327         * WebKitTestRunner/TestController.cpp:
2328         (WTR::TestController::resetStateToConsistentValues):
2329         (WTR::TestController::setBlockAllPlugins):
2330         When not blocked, set the load policy to allow once.
2331         * WebKitTestRunner/TestController.h:
2332
2333 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
2334
2335         [ews-build] Bindings-tests-EWS should output result in json
2336         https://bugs.webkit.org/show_bug.cgi?id=187330
2337
2338         Reviewed by David Kilzer.
2339
2340         * BuildSlaveSupport/ews-build/steps.py:
2341         (RunBindingsTests):  Passed --json-output parameter to run-bindings-tests.
2342         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2343
2344 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
2345
2346         [ews-build] WebKitPy-Tests-EWS should output result in json
2347         https://bugs.webkit.org/show_bug.cgi?id=187331
2348
2349         Follow-up fix to r233527. Extracting jsonFileName as a variable and re-using it.
2350
2351 2018-07-05  Aakash Jain  <aakash_jain@apple.com>
2352
2353         [ews-build] WebKitPy-Tests-EWS should output result in json
2354         https://bugs.webkit.org/show_bug.cgi?id=187331
2355
2356         Reviewed by David Kilzer.
2357
2358         * BuildSlaveSupport/ews-build/steps.py:
2359         (RunWebKitPyTests): Passed --json-output parameter to test-webkitpy.
2360         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2361
2362 2018-07-05  Philippe Normand  <pnormand@igalia.com>
2363
2364         [Flatpak] Add gst-libav to dependencies
2365         https://bugs.webkit.org/show_bug.cgi?id=187340
2366
2367         Reviewed by Žan Doberšek.
2368
2369         * flatpak/org.webkit.WebKit.yaml: Use tarballs instead of git
2370         clones because the FFMPeg git server doesn't support shallow
2371         clones.
2372
2373 2018-07-05  Thibault Saunier  <tsaunier@igalia.com>
2374
2375         [WPE][GTK]: Call gtk platform 'gtk' by default as this is what PortFactory expects
2376         https://bugs.webkit.org/show_bug.cgi?id=187322
2377
2378         Reviewed by Žan Doberšek.
2379
2380         * flatpak/flatpakutils.py:
2381         (WebkitFlatpak.__init__):
2382
2383 2018-07-05  Zan Dobersek  <zdobersek@igalia.com>
2384
2385         Unreviewed, rolling out r233511.
2386
2387         Proper fix provided in bug #187322
2388
2389         Reverted changeset:
2390
2391         "Unreviewed. Fixing a call in flatpakutils.py to
2392         PortFactory.get(),"
2393         https://trac.webkit.org/changeset/233511
2394
2395 2018-07-04  Zan Dobersek  <zdobersek@igalia.com>
2396
2397         Unreviewed. Fixing a call in flatpakutils.py to PortFactory.get(),
2398         enforcing the passed platform argument to always be lowercase, as is
2399         expected from the PortFactory code.
2400
2401         * flatpak/flatpakutils.py:
2402         (WebkitFlatpak.clean_args):
2403
2404 2018-07-04  Tim Horton  <timothy_horton@apple.com>
2405
2406         Introduce PLATFORM(IOSMAC)
2407         https://bugs.webkit.org/show_bug.cgi?id=187315
2408
2409         Reviewed by Dan Bernstein.
2410
2411         * TestWebKitAPI/Configurations/Base.xcconfig:
2412         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2413
2414 2018-07-03  Brady Eidson  <beidson@apple.com>
2415
2416         WebKit.ResponsivenessTimerCrash sometimes fails.
2417         https://bugs.webkit.org/show_bug.cgi?id=187314
2418
2419         Reviewed by Tim Horton.
2420
2421         Actually unregister observers from objects we're about to destroy before destroying them.
2422
2423         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm:
2424         (-[ResponsivenessTimerObserver observeValueForKeyPath:ofObject:change:context:]): 
2425
2426 2018-07-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2427
2428         update-webkitgtk-flatpak fails if running with python2
2429         https://bugs.webkit.org/show_bug.cgi?id=187240
2430
2431         Reviewed by Michael Catanzaro.
2432
2433         urllib.urlretrieve of Python2 sends invalid requests. Use
2434         urllib2.urlopen instead.
2435
2436         * flatpak/flatpakutils.py: Import urllib2.urlopen for Python2,
2437         urllib.request.urlopen for Python3.
2438         (FlatpakRepo.repo_file): Copy the content of urlopen result to the
2439         temporary file.
2440
2441 2018-07-03  Chris Dumez  <cdumez@apple.com>
2442
2443         Make CallbackMap::invalidate() safe to re-enter
2444         https://bugs.webkit.org/show_bug.cgi?id=187298
2445         <rdar://problem/41057167>
2446
2447         Reviewed by Geoffrey Garen.
2448
2449         Add API test coverage.
2450
2451         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
2452         (TEST):
2453
2454 2018-07-03  Chris Dumez  <cdumez@apple.com>
2455
2456         [Cocoa] Disable vnode guard related simulated crashes for WKTR / DRT and WebSQL
2457         https://bugs.webkit.org/show_bug.cgi?id=187270
2458         <rdar://problem/40674034>
2459
2460         Reviewed by Geoffrey Garen.
2461
2462         Disable vnode guard related simulated crashes for WKTR / DRT by setting the
2463         expected environment variable in the test driver.
2464
2465         * Scripts/webkitpy/port/driver.py:
2466         (Driver._setup_environ_for_driver):
2467
2468 2018-07-03  Eric Carlson  <eric.carlson@apple.com>
2469
2470         Video sometimes flickers when playing to AppleTV
2471         https://bugs.webkit.org/show_bug.cgi?id=187193
2472         <rdar://problem/40153865>
2473
2474         Unreviewed, fix test broken by r233435.
2475
2476         * TestWebKitAPI/Tests/WebKitLegacy/ios/AudioSessionCategoryIOS.mm:
2477         (TestWebKitAPI::waitUntilAudioSessionCategoryIsEqualTo): Poll for a change in audio session 
2478         category because it doesn't necessarily happen synchronously.
2479         (TestWebKitAPI::TEST):
2480
2481 2018-07-03  Thibault Saunier  <tsaunier@igalia.com>
2482
2483         Unreviewed, add myself as a WebKit committer.
2484
2485         And canonicalize the file as suggested by `check-webkit-style`
2486
2487         * Scripts/webkitpy/common/config/contributors.json:
2488
2489 2018-07-03  Basuke Suzuki  <Basuke.Suzuki@sony.com>
2490
2491         check-webkit-style: Run the tool without SVN client.
2492         https://bugs.webkit.org/show_bug.cgi?id=187294
2493
2494         Reviewed by Daniel Bates.
2495
2496         When invoking check-webkit-style without SVN client, the exception was raised and terminated.
2497         Using Git repository is acceptable workflow according to the wording on:
2498         <https://webkit.org/getting-the-code/#checking-out-with-git>
2499         and using Subversion is considered optional by following link:
2500         <https://webkit.org/webkit-on-windows/#installing-developer-tools>.
2501         This patch makes it so that people with only a Git checkout of WebKit that commit using
2502         the commit-queue (or another machine with an SVN checkout) can run check-webkit-style.
2503
2504         * Scripts/webkitpy/common/checkout/scm/svn.py:
2505         (SVN.in_working_directory):
2506
2507 2018-07-03  Aakash Jain  <aakash_jain@apple.com>
2508
2509         Remove old JSCTestsFactory
2510
2511         Follow-up fix to r233471.
2512
2513 2018-07-03  Aakash Jain  <aakash_jain@apple.com>
2514
2515         [ews-build] Add support for JSC-Tests-EWS
2516         https://bugs.webkit.org/show_bug.cgi?id=187201
2517
2518         Reviewed by Lucas Forschler.
2519
2520         * BuildSlaveSupport/ews-build/factories.py:
2521         (JSCTestsFactory): Added JSCTestsFactory.
2522         * BuildSlaveSupport/ews-build/steps.py:
2523         (CompileJSCOnly): Command to compile JSC.
2524         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
2525         * BuildSlaveSupport/ews-build/config.json: Changed platform to jsc-only. This matches with build.webkit.org configuration.
2526
2527 2018-07-03  Zalan Bujtas  <zalan@apple.com>
2528
2529         [LFC] Add test-list file for regression testing
2530         https://bugs.webkit.org/show_bug.cgi?id=187296
2531
2532         Reviewed by Antti Koivisto.
2533
2534         run-webkit-tests --test-list=./Tools/LayoutReloaded/misc/LFC-passing-tests.txt
2535
2536         * LayoutReloaded/misc/LFC-passing-tests.txt: Added.
2537
2538 2018-07-03  John Wilander  <wilander@apple.com>
2539
2540         Resource Load Statistics: Make WebsiteDataStore::getAllStorageAccessEntries() call the right network process instead of iterating over the process pools
2541         https://bugs.webkit.org/show_bug.cgi?id=187277
2542         <rdar://problem/41745510>
2543
2544         Reviewed by Chris Dumez.
2545
2546         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2547         (WTR::TestController::getAllStorageAccessEntries):
2548
2549 2018-07-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2550
2551         Fix a leak in ActionSheetTests.DismissingActionSheetShouldNotDismissPresentingViewController
2552         https://bugs.webkit.org/show_bug.cgi?id=187280
2553
2554         Reviewed by Tim Horton.
2555
2556         Add a missing `adoptNS()`.
2557
2558         * TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
2559         (TestWebKitAPI::TEST):
2560
2561 2018-07-02  Myles C. Maxfield  <mmaxfield@apple.com>
2562
2563         [Cocoa] Google Fonts doesn't work if the user has the requested font locally-installed
2564         https://bugs.webkit.org/show_bug.cgi?id=187228
2565         <rdar://problem/40967280>
2566
2567         Reviewed by Brent Fulgham.
2568
2569         The test only fails before the patch if the lookup for Helvetica2 is allowed to occur.
2570
2571         * WebKitTestRunner/mac/TestControllerMac.mm:
2572         (WTR::allowedFontFamilySet):
2573
2574 2018-07-02  Ryosuke Niwa  <rniwa@webkit.org>
2575
2576         run-benchmark should include the version number of MotionMark's results
2577         https://bugs.webkit.org/show_bug.cgi?id=187274
2578
2579         Reviewed by Jon Lee.
2580
2581         Append the version number as a part of the suite name.
2582
2583         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
2584
2585 2018-07-02  Wenson Hsieh  <wenson_hsieh@apple.com>
2586
2587         [WK1] editing/spelling/markers.html is failing on recent builds of macOS Mojave
2588         https://bugs.webkit.org/show_bug.cgi?id=187253
2589
2590         Reviewed by Tim Horton.
2591
2592         Enhances and refactors LayoutTestSpellChecker, which was introduced in r233412.
2593
2594         * DumpRenderTree/TestRunner.cpp:
2595         (setSpellCheckerResultsCallback):
2596
2597         Rename setSpellCheckerTextReplacements to setSpellCheckerResults.
2598
2599         (TestRunner::staticFunctions):
2600         (setSpellCheckerTextReplacementsCallback): Deleted.
2601         * DumpRenderTree/TestRunner.h:
2602         * DumpRenderTree/mac/TestRunnerMac.mm:
2603         (TestRunner::setSpellCheckerResults):
2604         (TestRunner::setSpellCheckerTextReplacements): Deleted.
2605         * DumpRenderTree/win/TestRunnerWin.cpp:
2606         (TestRunner::setSpellCheckerResults):
2607         (TestRunner::setSpellCheckerTextReplacements): Deleted.
2608         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h:
2609         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
2610         (-[LayoutTestTextCheckingResult initWithType:range:replacement:details:]):
2611         (-[LayoutTestTextCheckingResult grammarDetails]):
2612         (-[LayoutTestSpellChecker reset]):
2613         (-[LayoutTestSpellChecker results]):
2614         (-[LayoutTestSpellChecker setResults:]):
2615         (-[LayoutTestSpellChecker setResultsFromJSObject:inContext:]):
2616
2617         Add support for passing in a list of grammar correction detail ranges. Necessary for simulating grammar errors.
2618
2619         (-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):
2620
2621         Tweaked to always call the superclass method. This ensures that we set the `orthography` and `wordCount`
2622         outpointers if applicable.
2623
2624         (-[LayoutTestSpellChecker requestCheckingOfString:range:types:options:inSpellDocumentWithTag:completionHandler:]):
2625
2626         Added support for simulating asynchronous spell checking.
2627
2628         (-[LayoutTestTextCheckingResult initWithType:range:replacement:]): Deleted.
2629         (-[LayoutTestSpellChecker replacements]): Deleted.
2630         (-[LayoutTestSpellChecker setReplacements:]): Deleted.
2631         (-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]): Deleted.
2632
2633 2018-07-02  Brady Eidson  <beidson@apple.com>
2634
2635         Another unreviewed followup to:
2636         Crash notifying observers of responsiveness state change
2637
2638         * TestWebKitAPI/cocoa/TestWKWebView.h:
2639         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2640         (-[TestWKWebView typeCharacter:]): Move this back to the Mac-only category, as we won't be running this
2641           test on iOS for other reasons.
2642
2643 2018-07-02  Brady Eidson  <beidson@apple.com>
2644
2645         Unreviewed followup to:
2646         Crash notifying observers of responsiveness state change
2647
2648         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm: Need the C-SPI for this test.
2649
2650 2018-07-02  Brady Eidson  <beidson@apple.com>
2651
2652         Crash notifying observers of responsiveness state change
2653         <rdar://problem/41267796> and https://bugs.webkit.org/show_bug.cgi?id=187262
2654
2655         Reviewed by Tim Horton.
2656
2657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2658         * TestWebKitAPI/Tests/WebKit/ResponsivenessTimerCrash.mm: Added.
2659         (-[RTObserver observeValueForKeyPath:ofObject:change:context:]):
2660         (TestWebKitAPI::TEST):
2661         * TestWebKitAPI/cocoa/TestWKWebView.h:
2662         * TestWebKitAPI/cocoa/TestWKWebView.mm:
2663         (-[TestWKWebView typeCharacter:]):
2664         (-[TestWKWebView hostWindow]):
2665
2666 2018-07-02  Michael Catanzaro  <mcatanzaro@igalia.com>
2667
2668         [WPE][GTK] flatpakutils.py should respect set-webkit-configuration build type
2669         https://bugs.webkit.org/show_bug.cgi?id=187218
2670
2671         Reviewed by Philippe Normand.
2672
2673         Using the webkitpy Config module, if the build type is not passed on the command line, we
2674         read it from WebKitBuild/Configuration and respect it.
2675
2676         * flatpak/flatpakutils.py:
2677         (WebkitFlatpak.__init__):
2678         (WebkitFlatpak.clean_args):
2679
2680 2018-07-02  Zan Dobersek  <zdobersek@igalia.com>
2681
2682         [WPE] Add touch support to WindowViewBackend
2683         https://bugs.webkit.org/show_bug.cgi?id=187245
2684
2685         Reviewed by Carlos Garcia Campos.
2686
2687         Add touch input support to the WindowViewBackend implementation,
2688         plugging into the Wayland protocol in order to get properly notified
2689         about these events, and then dispatching them against the appropriate
2690         wpe_view_backend object so that WebKit can process them.
2691
2692         * wpe/backends/ViewBackend.cpp:
2693         (WPEToolingBackends::ViewBackend::dispatchInputTouchEvent):
2694         * wpe/backends/ViewBackend.h:
2695         * wpe/backends/WindowViewBackend.cpp:
2696         * wpe/backends/WindowViewBackend.h:
2697
2698 2018-07-02  Rob Buis  <rbuis@igalia.com>
2699
2700         [GTK] ASSERTION FAILED: url == m_string in UserAgentQuirks test
2701         https://bugs.webkit.org/show_bug.cgi?id=186838
2702
2703         This URL constructor expects canonicalized input, so fix the passed URL. I missed
2704         this one some weeks ago since I had an older checkout.
2705
2706         Reviewed by Michael Catanzaro.
2707
2708         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2709         (TestWebKitAPI::TEST):
2710
2711 2018-07-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2712
2713         [macOS] Text replacements that end with symbols are expanded immediately
2714         https://bugs.webkit.org/show_bug.cgi?id=187225
2715         <rdar://problem/41112433>
2716
2717         Reviewed by Darin Adler.
2718
2719         Adds testing support for mocking NSSpellChecker's text checking results. See below for more details, and the new
2720         layout test for an example of its usage.
2721
2722         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2723         * DumpRenderTree/TestRunner.cpp:
2724         (setSpellCheckerTextReplacementsCallback):
2725
2726         Add bindings support in TestRunner to specify a set of text replacement mappings. Each entry in the dictionary
2727         maps a string representing an input to the NSSpellChecker to some information describing the spell checking
2728         result that LayoutTestSpellChecker will return.
2729
2730         (TestRunner::staticFunctions):
2731         * DumpRenderTree/TestRunner.h:
2732         * DumpRenderTree/mac/DumpRenderTree.mm:
2733         (resetWebViewToConsistentStateBeforeTesting):
2734
2735         Restore the original shared NSSpellchecker before transitioning to the next layout test, if needed.
2736
2737         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Removed.
2738         * DumpRenderTree/mac/TestRunnerMac.mm:
2739         (TestRunner::setSpellCheckerLoggingEnabled):
2740         (TestRunner::setSpellCheckerTextReplacements):
2741
2742         These testRunner methods ensure that `-[NSSpellChecker sharedSpellChecker]` is swizzled to return our mock
2743         LayoutTestSpellChecker instance before calling into it.
2744
2745         * DumpRenderTree/win/TestRunnerWin.cpp:
2746         (TestRunner::setSpellCheckerTextReplacements):
2747         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h: Renamed from Tools/DumpRenderTree/mac/DumpRenderTreeSpellChecker.h.
2748         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm: Added.
2749
2750         Moved DumpRenderTreeSpellChecker to LayoutTestSpellChecker, and made it compile for both WebKitTestRunner
2751         (modern WebKit) and DumpRenderTree (legacy WebKit) by putting it in TestRunnerShared.
2752
2753         (existingGlobalLayoutTestSpellChecker):
2754         (ensureGlobalLayoutTestSpellChecker):
2755         (stringForCorrectionResponse):
2756         (nsTextCheckingType):
2757         (-[LayoutTestTextCheckingResult initWithType:range:replacement:]):
2758         (-[LayoutTestTextCheckingResult range]):
2759         (-[LayoutTestTextCheckingResult resultType]):
2760         (-[LayoutTestTextCheckingResult replacementString]):
2761         (-[LayoutTestTextCheckingResult description]):
2762
2763         LayoutTestTextCheckingResult represents a fake NSTextCheckingResult containing spell checking results supplied
2764         by the layout test.
2765
2766         (+[LayoutTestSpellChecker installIfNecessary]):
2767         (+[LayoutTestSpellChecker uninstallAndReset]):
2768
2769         Helper methods to begin and end swizzling the shared NSSpellChecker.
2770
2771         (-[LayoutTestSpellChecker reset]):
2772
2773         Resets the state of the LayoutTestSpellChecker (this entails clearing the fake replacements dictionary and
2774         turning off logging for recorded spellchecking responses).
2775
2776         (-[LayoutTestSpellChecker replacements]):
2777         (-[LayoutTestSpellChecker setReplacements:]):
2778         (-[LayoutTestSpellChecker setReplacementsFromJSObject:inContext:]):
2779
2780         Helper method to take a `JSObjectRef` supplied by the test runner and transform it into a map of spell checking
2781         string inputs to LayoutTestTextCheckingResults.
2782
2783         (-[LayoutTestSpellChecker checkString:range:types:options:inSpellDocumentWithTag:orthography:wordCount:]):
2784
2785         Consult the text replacement map and bail early if a match is found, before calling into real NSSpellChecker
2786         logic to perform spellchecking.
2787
2788         (-[LayoutTestSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:]):
2789
2790         Reimplement the original functionality in DumpRenderTreeSpellChecker to make `-recordResponse:…` print to stdout
2791         by overriding the method and printing if the `-spellCheckerLoggingEnabled` property has been set to YES.
2792
2793         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2794
2795 2018-07-01  Thibault Saunier  <tsaunier@igalia.com>
2796
2797         [WPE][GTK] Fix retrieving backtrace from within flatpak sandbox in test runner
2798         https://bugs.webkit.org/show_bug.cgi?id=187232
2799
2800         Reviewed by Michael Catanzaro.
2801
2802         The place where host tmp folder is mounted changed to /run/host/ we
2803         need to take that into account.
2804
2805         Also explicitely close temporary files as relying on garbage collection to
2806         remove them is a bad idea.
2807
2808         Also minor optimization avoiding to compile regex for each backtrace
2809         retrieval.
2810
2811         * Scripts/webkitpy/port/linux_get_crash_log.py:
2812         (GDBCrashLogGenerator):
2813         (GDBCrashLogGenerator._get_tmp_file_name):
2814         (GDBCrashLogGenerator._get_trace_from_systemd):
2815
2816 2018-06-30  Daniel Bates  <dabates@apple.com>
2817
2818         test-webkitpy never rebuilds lldbWebKitTester
2819         https://bugs.webkit.org/show_bug.cgi?id=187229
2820
2821         Reviewed by David Kilzer.
2822
2823         Have test-webkitpy always call script build-lldbwebkittester to build lldbWebKitTester, if needed.
2824
2825         Currently test-webkitpy only calls script build-lldbwebkittester if lldbWebKitTester does not
2826         exist in the build products directory for the active configuration (e.g. Debug); => we do not
2827         build lldbWebKitTester again if its source changes (say, as a result of hacking on lldbWebKitTester).
2828         Instead we should have test-webkitpy unconditionally call build-lldbwebkittester to ensure
2829         that we have an up-to-date build of lldbWebKitTester.
2830
2831         * Scripts/webkitpy/test/main.py:
2832         (Tester._run_tests):
2833         (_find_lldb_webkit_tester): Deleted.
2834
2835 2018-06-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2836
2837         [CMake] build-webkit should be able to enable address sanitizer
2838         https://bugs.webkit.org/show_bug.cgi?id=187222
2839
2840         Reviewed by Daniel Bates.
2841
2842         If 'set-webkit-configuration --asan' has been run, then build-webkit should pass
2843         -DENABLE_ADDRESS_SANITIZER=ON to CMake, so that it actually does something.
2844
2845         This also works for build-jsc.
2846
2847         * Scripts/webkitdirs.pm:
2848         (generateBuildSystemFromCMakeProject):
2849
2850 2018-06-30  Thibault Saunier  <tsaunier@igalia.com>
2851
2852         Make check_flatpak() not verbose when only trying to run command inside flatpak
2853         https://bugs.webkit.org/show_bug.cgi?id=187187
2854
2855         Reviewed by Michael Catanzaro.
2856
2857         * flatpak/flatpakutils.py:
2858         (run_in_sandbox_if_available):
2859
2860 2018-06-29  Daniel Bates  <dabates@apple.com>
2861
2862         build-webkit: Perl "use of uninitialized value $previousContents"
2863         https://bugs.webkit.org/show_bug.cgi?id=185776
2864
2865         Reviewed by Michael Catanzaro.
2866
2867         Fixes an issue where reading an empty cached argument file would cause
2868         Perl "uninitialized value" warnings of the form:
2869             Use of uninitialized value $previousContents in chomp at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1969.
2870             Use of uninitialized value $previousContents in string ne at C:/WebKit-BuildWorker/wincairo-wkl-debug/build/Tools/Scripts/webkitdirs.pm line 1972.
2871
2872         * Scripts/webkitdirs.pm:
2873         (isCachedArgumentfileOutOfDate):
2874
2875 2018-06-29  Daniel Bates  <dabates@apple.com>
2876
2877         Perl uninitialized value $isEnabled when running build-jsc using a CMake build
2878         https://bugs.webkit.org/show_bug.cgi?id=187208
2879
2880         Reviewed by Tim Horton.
2881
2882         Share logic for computing the feature flags to enable in CMake with both script
2883         build-webkit and script build-jsc instead of duplicating it. This also fixes a
2884         bug in the version of this logic in build-jsc that was inadvertently not updated
2885         in r222394. In r222394 we removed the notion of a default value for a feature flag
2886         listed in webkitperl::FeatureList.
2887
2888         We keep the current behavior of build-jsc and leave it up to the build system
2889         to determine whether to enable or disable ENABLE_EXPERIMENTAL_FEATURES.
2890
2891         * Scripts/build-jsc:
2892         (buildMyProject):
2893         (cMakeArgsFromFeatures): Deleted.
2894         * Scripts/build-webkit:
2895         (cMakeArgsFromFeatures): Deleted; moved to webkitdirs.pm.
2896         * Scripts/webkitdirs.pm:
2897         (cmakeArgsFromFeatures): Moved code from script build-webkit so that it can be shared
2898         with build-jsc.
2899
2900 2018-06-29  Tim Horton  <timothy_horton@apple.com>
2901
2902         Add -apple-color-filter and system appearance toggles to MiniBrowser
2903         https://bugs.webkit.org/show_bug.cgi?id=187210
2904
2905         Reviewed by Simon Fraser.
2906
2907         * MiniBrowser/mac/AppDelegate.m:
2908         (defaultConfiguration):
2909         * MiniBrowser/mac/SettingsController.h:
2910         * MiniBrowser/mac/SettingsController.m:
2911         (-[SettingsController _populateMenu]):
2912         (-[SettingsController validateMenuItem:]):
2913         (-[SettingsController toggleAppleColorFilterEnabled:]):
2914         (-[SettingsController appleColorFilterEnabled]):
2915         (-[SettingsController toggleUseSystemAppearance:]):
2916         (-[SettingsController useSystemAppearance]):
2917         * MiniBrowser/mac/WK1BrowserWindowController.m:
2918         (-[WK1BrowserWindowController didChangeSettings]):
2919         * MiniBrowser/mac/WK2BrowserWindowController.m:
2920         (-[WK2BrowserWindowController didChangeSettings]):
2921
2922 2018-06-29  Aditya Keerthi  <akeerthi@apple.com>
2923
2924         [macOS] Do not crash if there is an attempt to copy a file URL to the clipboard
2925         https://bugs.webkit.org/show_bug.cgi?id=187183
2926
2927         Reviewed by Wenson Hsieh.
2928
2929         Added a 'runSingly' option to the TestOptions struct. Setting this option to true
2930         will force a new PlatformWebView to be created before running a test. This ensures
2931         that any state set by previous tests are not preserved.
2932
2933         One example of the importance of having this ability is in the case where we want
2934         to test functionality that deals with read access to files. If a test were to
2935         load a valid file URL, universal read access will be granted in WebProcessProxy.
2936         This prevents us from testing cases that rely on us not have universal read
2937         access. Now, if we write the test using the 'runSingly' option, any state set
2938         by previous tests is cleared. Consequently, our test will behave as expected.
2939
2940         * WebKitTestRunner/PlatformWebView.h:
2941         (WTR::PlatformWebView::viewSupportsOptions const):
2942         * WebKitTestRunner/TestController.cpp:
2943         (WTR::updateTestOptionsFromTestHeader):
2944         * WebKitTestRunner/TestOptions.h:
2945         (WTR::TestOptions::hasSameInitializationOptions const):
2946
2947 2018-06-29  Daniel Bates  <dabates@apple.com>
2948
2949         [lldb-webkit] Non-empty strings may be pretty-printed as empty
2950         https://bugs.webkit.org/show_bug.cgi?id=187185
2951
2952         Reviewed by Simon Fraser.
2953
2954         For some reason lldb(1) sometimes has an issue accessing members of WTF::StringImplShape
2955         via a WTF::StringImpl pointer (why?). Explicitly casting a WTF::StringImpl* to a
2956         WTF::StringImplShape* before accessing such members makes LLDB happy.
2957
2958         I tried writing a test for this both for the LLVM project and to add to our lldb_webkit unit
2959         tests to no avail. I have only been able to reproduce this bug sporadically during my WebCore/WebKit
2960         debugging sessions so far.
2961
2962         * lldb/lldb_webkit.py:
2963         (WTFStringImplProvider.__init__): Explicitly cast the WTF::StringImpl* to WTF::StringImplShape*.
2964         (WTFStringImplProvider.get_data8): Update code now that we are directly accessing WTF::StringImplShape*.
2965         (WTFStringImplProvider.get_data16): Ditto.
2966
2967 2018-06-29  Chris Dumez  <cdumez@apple.com>
2968
2969         WebKitLegacy: Can trigger recursive loads triggering debug assertions
2970         https://bugs.webkit.org/show_bug.cgi?id=187121
2971         <rdar://problem/41259430>
2972
2973         Reviewed by Brent Fulgham.
2974
2975         Add API test coverage.
2976
2977         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2978         * TestWebKitAPI/Tests/mac/StartLoadInDidFailProvisionalLoad.mm: Added.
2979         (-[StartLoadInDidFailProvisionalLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
2980         (-[StartLoadInDidFailProvisionalLoadDelegate webView:didFinishLoadForFrame:]):
2981         (TestWebKitAPI::TEST):
2982
2983 2018-06-29  Lucas Forschler  <lforschler@apple.com>
2984
2985         Teach bisect-builds to retrieve supported platforms from the rest api.
2986         https://bugs.webkit.org/show_bug.cgi?id=187195
2987         
2988         This patch updates bisect-builds to use v2_2 of the API. v2_2 adds two api endpoints: /platforms, and /minified-platforms.
2989         These endpoints scan a dynamoDB database, returning the identifier key for all available platforms.
2990         The identifier keys are in the format: platform-architecture-configuration.
2991
2992         Reviewed by Aakash Jain.
2993
2994         * Scripts/bisect-builds:
2995         (get_api_archive_url): refactored from get_api_url.
2996         (get_platforms): helper function to retrieve from the platforms api.
2997         (minified_platforms): returns a list of minified platforms currently in the database
2998         (unminified_platforms): returns a list of unminified platforms currently in the database
2999         (is_supported_platform): checks if the platform-architecture-configuration combo is supported
3000         (fetch_revision_list): refactored to use get_api_archive_url
3001         (get_api_url): Deleted/refactored to get_api_archive_url.
3002
3003 2018-06-29  Keith Miller  <keith_miller@apple.com>
3004
3005         run-jsc should print when jsc exits with non-zero status
3006         https://bugs.webkit.org/show_bug.cgi?id=187192
3007
3008         Reviewed by Saam Barati.
3009
3010         * Scripts/run-jsc:
3011
3012 2018-06-29  Aakash Jain  <aakash_jain@apple.com>
3013
3014         [ews-build] Add timeout to webkitpy and webkitperl tests
3015         https://bugs.webkit.org/show_bug.cgi?id=187191
3016
3017         Reviewed by Lucas Forschler.
3018
3019         * BuildSlaveSupport/ews-build/steps.py:
3020         (RunWebKitPerlTests.__init__): Set timeout of 2 minutes.
3021         (RunWebKitPyTests.__init__): Ditto.
3022         * BuildSlaveSupport/ews-build/steps_unittest.py: Updated unit-tests.
3023
3024 2018-06-29  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3025
3026         [WPE]: Fix exception handling when flatpak is not installed
3027         https://bugs.webkit.org/show_bug.cgi?id=186771
3028
3029         Unreviewed followup-fix after r233362
3030
3031         This was causing failures when flatpak is not installed.
3032
3033         * flatpak/flatpakutils.py:
3034         (check_flatpak):
3035
3036 2018-06-29  Ross Kirsling  <ross.kirsling@sony.com>
3037
3038         [JSCOnly] Restore Windows build.
3039         https://bugs.webkit.org/show_bug.cgi?id=187127
3040
3041         Reviewed by Michael Catanzaro.
3042
3043         * Scripts/build-jsc:
3044         Fix condition for disabling FTL JIT on Windows.
3045
3046         * Scripts/webkitdirs.pm:
3047         (executableProductDir):
3048         JSCOnly should still use bin64 on Windows (for consistency with full WebKit build).
3049         (determineIsWin64):
3050         JSCOnly already defaults to 64-bit on Windows with Ninja -- ensure that this is true even with MSBuild.
3051
3052 2018-06-29  Thibault Saunier  <tsaunier@igalia.com>
3053
3054         [GTK][WPE]: Add a way to setup our development environment inside flatpak
3055         https://bugs.webkit.org/show_bug.cgi?id=186771
3056
3057         Reviewed by Carlos Alberto Lopez Perez.
3058
3059         This patch introduce a way to setup the development environment inside flatpak[0]
3060         removing the need for jhbuild when doing so. Anything needed to build/run minibrowser/ run
3061         layout tests is provided either but the org.gnome.Sdk runtime or built with flatpak-builder.
3062
3063         The workflow is very similar to the "jhbuild based" one except that you should use update-webkit$PORTNAME-flatpak instead
3064         of update-webkit$PORTNAME-libs and that script requires to specify a build configuration (--release is default).
3065
3066         Our scripts have been updated to be able to run inside that new build environment.
3067
3068         Since everything runs inside a flatpak sandbox, gdb needs to be run from within the sandbox, the script exposes a way to do it
3069         easily with the `--gdb` option:
3070
3071           $ webkit-flatpak --gdb [-m COREDUMPCTL MATCHES]
3072
3073         The Layout test `GDBCrashLogGenerator` has been taugth how to use that and is able to retrieve stacktrace as with the jhbuild based workflow.
3074
3075         [0] http://flatpak.org
3076
3077         * Scripts/build-webkit:
3078         * Scripts/generate-jsc-bundle:
3079         (main):
3080         * Scripts/run-gtk-tests:
3081         * Scripts/run-minibrowser:
3082         * Scripts/run-webdriver-tests:
3083         * Scripts/run-webkit-tests:
3084         * Scripts/run-wpe-tests:
3085         * Scripts/update-webkitgtk-libs:
3086         * Scripts/update-webkitwpe-libs:
3087         * Scripts/webkit-flatpak: Added.
3088         * Scripts/webkitdirs.pm:
3089         (getJhbuildPath):
3090         (getFlatpakPath):
3091         (inFlatpakSandbox):
3092         (runInFlatpak):
3093         (runInFlatpakIfAvalaible):
3094         (wrapperPrefixIfNeeded):
3095         (shouldUseFlatpak):
3096         * Scripts/webkitpy/port/base.py:
3097         (Port._path_to_apache):
3098         (Port._is_flatpak):
3099         (Port._apache_config_file_name_for_platform):
3100         (Port._should_use_flatpak):
3101         (Port):
3102         (Port._in_flatpak_sandbox):
3103         (Port._should_use_jhbuild):
3104         * Scripts/webkitpy/port/gtk.py:
3105         (GtkPort.setup_environ_for_server):
3106         * Scripts/webkitpy/port/linux_get_crash_log.py:
3107         (GDBCrashLogGenerator._get_trace_from_systemd):
3108         (GDBCrashLogGenerator.generate_crash_log):
3109         * Scripts/webkitpy/port/wpe.py:
3110         (WPEPort.setup_environ_for_server):
3111         * Scripts/webkitpy/w3c/wpt_runner.py:
3112         (main):
3113         * flatpak/files/default.xkm: Added.
3114         * flatpak/files/httpd-autogen.sh: Added.
3115         * flatpak/flatpakutils.py: Added.
3116         (Colors):
3117         (Console):
3118         (Console.message):
3119         (remove_extension_points):
3120         (remove_comments):
3121         (remove_comments._replacer):
3122         (load_manifest):
3123         (expand_manifest):
3124         (FlatpakObject):
3125         (FlatpakObject.__init__):
3126         (FlatpakObject.flatpak):
3127         (FlatpakPackages):
3128         (FlatpakPackages.__init__):
3129         (FlatpakPackages.__detect_packages):
3130         (FlatpakPackages.__detect_packages.in):
3131         (FlatpakPackages.__detect_runtimes):
3132         (FlatpakPackages.__detect_apps):
3133         (FlatpakPackages.__iter__):
3134         (FlatpakRepos):
3135         (FlatpakRepos.__init__):
3136         (FlatpakRepos.update):
3137         (FlatpakRepos.add):
3138         (FlatpakRepo):
3139         (FlatpakRepo.__init__):
3140         (FlatpakRepo.repo_file):
3141         (FlatpakPackage):
3142         (FlatpakPackage.__init__):
3143         (FlatpakPackage.__str__):
3144         (FlatpakPackage.is_installed):
3145         (FlatpakPackage.install):
3146         (FlatpakPackage.update):
3147         (WebkitFlatpak):
3148         (WebkitFlatpak.load_from_args):
3149         (WebkitFlatpak.__init__):
3150         (WebkitFlatpak.check_flatpak):
3151         (WebkitFlatpak.check_flatpak.comparable_version):
3152         (WebkitFlatpak.clean_args):
3153         (WebkitFlatpak.run_in_sandbox):
3154         (WebkitFlatpak.run):
3155         (WebkitFlatpak.has_environment):
3156         (WebkitFlatpak.setup_dev_env):
3157         (WebkitFlatpak.install_all):
3158         (WebkitFlatpak.run_gdb):
3159         (WebkitFlatpak.update_all):
3160         (is_sandboxed):
3161         (run_in_sandbox_if_available):
3162         * flatpak/org.webkit.GTK.yaml: Added.
3163         * flatpak/org.webkit.WPE.yaml: Added.
3164         * flatpak/org.webkit.WebKit.yaml: Added.
3165         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Added.
3166         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Added.
3167
3168 2018-06-28  Wenson Hsieh  <wenson_hsieh@apple.com>
3169
3170         [iOS] DataTransfer.getData always returns the empty string when dropping text
3171         https://bugs.webkit.org/show_bug.cgi?id=187130
3172         <rdar://problem/41014117>
3173
3174         Reviewed by Ryosuke Niwa.
3175
3176         Add 2 new API tests to verify that:
3177         -   When dropping an item with text, markup, and URL representations, the page is allowed to get "text/html",
3178             "text/plain" and "text/uri-list" data.
3179         -   Adding a suggested name to a plain text item causes WebKit to treat it as a file, and suppress access to
3180             DataTransfer.getData().
3181
3182         Additionally tweaks a couple of existing API tests. Namely, in two API tests
3183         (ExternalSourceOverrideDropFileUpload and ExternalSourceHTMLToUploadArea) only a markup string is dropped, and
3184         we previously expected to handle the drop as a file. To allow this test to continue serving its purpose, tweak
3185         them such that the registered items appear to be file-backed (i.e. by adding a suggested filename in one of the
3186         tests, and specifying UIPreferredPresentationStyleAttachment in the other).
3187
3188         * TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
3189         (TestWebKitAPI::TEST):
3190
3191 2018-06-28  Basuke Suzuki  <Basuke.Suzuki@sony.com>
3192
3193         Unreviewed, rolling out r226652.
3194         https://bugs.webkit.org/show_bug.cgi?id=180827
3195
3196         "PlatformInfo should never be instantiated in isolation. So, PlatformInfo should
3197         not have default argument values. The preferred way to get a PlatformInfo object
3198         is to instantiate a Host object." (Requested by dbates).
3199
3200         Reverted changeset:
3201
3202         "[webkitpy] PlatformInfo should have default argument for casual use"
3203         https://bugs.webkit.org/show_bug.cgi?id=180827
3204
3205 2018-06-28  Simon Fraser  <simon.fraser@apple.com>
3206
3207         Try to address test failures on the bots.
3208
3209         Allow the test to distinguish between a failure to find the variable, and an error
3210         reporting vector capacity.
3211
3212         * lldb/lldb_webkit_unittest.py:
3213         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
3214         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3215
3216 2018-06-28  Lucas Forschler  <lforschler@apple.com>
3217
3218         Add Windows support for WEBKIT_API_KEY.
3219         https://bugs.webkit.org/show_bug.cgi?id=187155
3220
3221         Reviewed by Daniel Bates.
3222
3223         * EWSTools/start-queue-win.sh:
3224
3225 2018-06-28  Aakash Jain  <aakash_jain@apple.com>
3226
3227         [ews-build] Add support for WebKitPy-Tests-EWS
3228         https://bugs.webkit.org/show_bug.cgi?id=187148
3229
3230         Reviewed by Lucas Forschler.
3231
3232         * BuildSlaveSupport/ews-build/factories.py: Added WebKitPyFactory.
3233         * BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPyTests.
3234         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3235         * BuildSlaveSupport/ews-build/config.json: Updated to use CamelCase. 
3236
3237 2018-06-28  Daniel Bates  <dabates@apple.com>
3238
3239         Fix the iOS build following r233299
3240         (https://bugs.webkit.org/show_bug.cgi?id=183744)
3241
3242         Only build lldbWebKitTester on Mac as that is the only supported platform at the time of writing.
3243
3244         * Makefile:
3245
3246 2018-06-28  Sihui Liu  <sihui_liu@apple.com>
3247
3248         Cookie API: cookie creation time is wrong
3249         https://bugs.webkit.org/show_bug.cgi?id=187101
3250
3251         Reviewed by Geoffrey Garen.
3252
3253         Add test coverage: make sure the cookie creation time returned is the same as set.
3254
3255         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
3256         (TEST):
3257
3258 2018-06-28  Simon Fraser  <simon.fraser@apple.com>
3259
3260         The lldb vector summary provider always shows zero capacity
3261         https://bugs.webkit.org/show_bug.cgi?id=187132
3262
3263         Reviewed by Daniel Bates.
3264         
3265         WTFVectorProvider in lldb_webkit.py was calling GetChildMemberWithName('m_capacity')
3266         on the buffer instead of the valobj.
3267
3268         * lldb/lldbWebKitTester/main.cpp:
3269         (testSummaryProviders):
3270         * lldb/lldb_webkit.py:
3271         (WTFVectorProvider.update):
3272         * lldb/lldb_webkit_unittest.py:
3273         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
3274         (TestSummaryProviders):
3275         (TestSummaryProviders.serial_test_WTFVectorProvider_empty_vector):
3276         (TestSummaryProviders.serial_test_WTFVectorProvider_vector_size_and_capacity):
3277
3278 2018-06-28  Adam Barth  <abarth@webkit.org>
3279
3280         Switch OS(FUCHSIA) to using JSCOnly
3281         https://bugs.webkit.org/show_bug.cgi?id=187133
3282
3283         Reviewed by Yusuke Suzuki.
3284
3285         Switch Fuchsia from being a port to just being an OS. We now use a
3286         CMAKE_TOOLCHAIN_FILE to configure the toolchain and the target triple.
3287
3288         * Scripts/webkitdirs.pm: Remove isFuchsia() and clients. Turns out we
3289         can do everything we need using a CMAKE_TOOLCHAIN_FILE via the
3290         --cmakeargs flag.
3291
3292 2018-06-27  Ryosuke Niwa  <rniwa@webkit.org>
3293
3294         Make MotionMark's plan file more robust against code changes
3295         https://bugs.webkit.org/show_bug.cgi?id=187116
3296         <rdar://problem/41533956>
3297
3298         Reviewed by Saam Barati.
3299
3300         Moved the code to auto-start the test to the load event listener.
3301
3302         * Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
3303
3304 2018-06-27  Daniel Bates  <dabates@apple.com>
3305
3306         Add some tests for lldb_webkit.py
3307         https://bugs.webkit.org/show_bug.cgi?id=183744
3308
3309         Reviewed by Alexey Proskuryakov.
3310
3311         Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
3312         and WTF::String objects.
3313
3314         The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
3315         program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
3316         on Mac.
3317
3318         * Makefile: Build the simple test tool lldbWebKitTester on Mac.
3319         * Scripts/build-lldbwebkittester: Added.
3320         (buildProjectOrDie):
3321         * Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module
3322         from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
3323         this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
3324         the file and take advantage of Python's default error semantics to throw an exception
3325         if the import fails instead of handling it ourself. This has the side effect that we
3326         now always import the LLDB Python module even if this script is invoked with --help.
3327         If this turns out to be a significant annoyance then we can look to dynamically import
3328         the module as we did before this change.
3329         (webkit_build_dir):
3330         (main):
3331         (developer_dir): Deleted.
3332         (import_lldb): Deleted.
3333         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect
3334         that fact that test-webkitpy does not support class and module fixtures. This is because
3335         test-webkitpy currently implements parallelism by breaking down existing test classes
3336         into individual test methods itself and having each worker run exactly one test method (via
3337         unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
3338         setUpModule()/setUpClass() are called for each test method as opposed to once per test
3339         class/test module.
3340         (remove_dir): Ditto.
3341         * Scripts/webkitpy/common/system/systemhost.py:
3342         (SystemHost):
3343         (SystemHost.path_to_lldb_python_directory): Added.
3344         * Scripts/webkitpy/test/main.py:
3345         (_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
3346         (_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
3347         lldbWebKitTester on Mac.
3348         (main): Add Tools/lldb to the test search path if the platform has lldb.py.
3349         (Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
3350         (Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
3351         If we will run these tests then build lldbWebKitTester if it has not already been built as the
3352         unit tests depend on this program.
3353         * lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
3354         * lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
3355         * lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
3356         * lldb/lldbWebKitTester/Makefile: Added.
3357         * lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
3358         * lldb/lldbWebKitTester/main.cpp: Added.
3359         (breakForTestingSummaryProviders):
3360         (utf16String):
3361         (testSummaryProviders):
3362         (main):
3363         * lldb/lldb_webkit_unittest.py: Added.
3364         (destroy_cached_debug_session):
3365         (LLDBDebugSession):
3366         (LLDBDebugSession.setup):
3367         (LLDBDebugSession.tearDown):
3368         (TestSummaryProviders):
3369         (TestSummaryProviders.setUpClass):
3370         (TestSummaryProviders._sbFrame):
3371         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
3372         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
3373         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
3374         (TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
3375         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
3376         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
3377         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
3378         (TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):
3379
3380 2018-06-27  Adam Barth  <abarth@webkit.org>
3381
3382         Add Fuchsia support to build-jsc
3383         https://bugs.webkit.org/show_bug.cgi?id=187086
3384
3385         Reviewed by Yusuke Suzuki.
3386
3387         Add Fuchsia port to webkitdirs.pm. This patch is sufficient to make
3388         build-jsc kick off a cmake for Fuchsia.
3389
3390         * Scripts/webkitdirs.pm:
3391         (determineSourceDir):
3392         (argumentsForConfiguration):
3393         (determineXcodeSDK):
3394         (findMatchingArguments):
3395         (determinePortName):
3396         (isFuchsia):
3397         (setupAppleWinEnv):
3398         (wrapperPrefixIfNeeded):
3399         (relaunchIOSSimulator):
3400         (debugMiniBrowser):
3401
3402 2018-06-27  Daniel Bates  <dabates@apple.com>
3403
3404         style-queue "AttributeError: 'NoneType' object has no attribute 'is_obsolete'" when processing security patch
3405         https://bugs.webkit.org/show_bug.cgi?id=187120
3406
3407         Reviewed by David Kilzer.
3408
3409         Teach the style queue how to refetch a patch from the status server as we did for non-Style
3410         EWS queues.
3411
3412         * Scripts/webkitpy/tool/bot/stylequeuetask.py:
3413         (StyleQueueTask.validate): Similar to change made to EarlyWarningSystemTask.validate() in r233107,
3414         only check if the bug associated with the patch we are processing is closed if the attachment has a
3415         non-None Bug object.
3416         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
3417         (AbstractEarlyWarningSystem.refetch_patch): Extract logic to refetch a patch from here...
3418         * Scripts/webkitpy/tool/commands/queues.py:
3419         (PatchProcessingQueue._refetch_patch): ... to here.
3420         (StyleQueue.refetch_patch): Turn around and call PatchProcessingQueue._refetch_patch().
3421
3422 2018-06-27  Tadeu Zagallo  <tzagallo@apple.com>
3423
3424         Unreviewed, add myself as a WebKit committer.
3425
3426         * Scripts/webkitpy/common/config/contributors.json:
3427
3428 2018-06-27  Daniel Bates  <dabates@apple.com>
3429
3430         webkit-patch should ignore non-ASCII characters in the status server API key
3431         https://bugs.webkit.org/show_bug.cgi?id=187107
3432
3433         Reviewed by Lucas Forschler.
3434
3435         The API key should only consists of ASCII characters. If it contains any
3436         non-ASCII characters then log a warning and ignore them.
3437
3438         * Scripts/webkitpy/common/net/statusserver.py:
3439         (StatusServer.set_api_key): Force conversion to ASCII.
3440         * Scripts/webkitpy/tool/main.py:
3441         (WebKitPatch._status_server_api_key): Convert to ASCII, ignoring non-ASCII
3442         characters and logging a warning.
3443
3444 2018-06-27  Jonathan Bedard  <jbedard@apple.com>
3445
3446         Enable WebKit iOS 12 build
3447         https://bugs.webkit.org/show_bug.cgi?id=187024
3448         <rdar://problem/39759057>
3449
3450         Reviewed by David Kilzer.
3451
3452         * Scripts/configure-xcode-for-ios-development:
3453         (copyMissingHeadersFromSDKToSDKIfNeeded): Copy launch.h into embedded SDKs.
3454
3455 2018-06-27  Robin Morisset  <rmorisset@apple.com>
3456
3457         [WSL] Add a control-flow stack to the execution rules in WSL.ott
3458         https://bugs.webkit.org/show_bug.cgi?id=186310
3459
3460         Rubberstamped by Filip Pizlo.
3461
3462         The goal of this is to enable (future) rules about uniform control flow for barriers.
3463         It required adding two new special construct: Join(s) and JoinExpr(e) whose only role is to pop the last element of the stack.
3464
3465         * WebGPUShadingLanguageRI/SpecWork/WSL.ott:
3466
3467 2018-06-27  Robin Morisset  <rmorisset@apple.com>
3468
3469         [WSL] Fix minor formatting issues in the grammar section
3470         https://bugs.webkit.org/show_bug.cgi?id=186310
3471
3472         Rubberstamped by Filip Pizlo.
3473
3474         * WebGPUShadingLanguageRI/SpecWork/source/index.rst:
3475
3476 2018-06-27  Robin Morisset  <rmorisset@apple.com>
3477
3478         [WSL] Put the full grammar in the Sphinx document
3479         https://bugs.webkit.org/show_bug.cgi?id=186310
3480
3481         Rubberstamped by Filip Pizlo.
3482
3483         Put the grammar's production rules in the Sphinx document, along with a few comments and the rules for desugaring.
3484         Also includes a bit of clean-up of the antlr rules.
3485
3486         * WebGPUShadingLanguageRI/SpecWork/WSL.g4:
3487         * WebGPUShadingLanguageRI/SpecWork/source/index.rst:
3488
3489 2018-06-26  Chris Dumez  <cdumez@apple.com>
3490
3491         Deal better with the network process crashing on startup
3492         https://bugs.webkit.org/show_bug.cgi?id=187065
3493         <rdar://problem/41451622>
3494
3495         Reviewed by Geoffrey Garen.
3496
3497         Add layout test coverage.
3498
3499         * TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:
3500         (-[MonitorWebContentCrashNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
3501         (-[MonitorWebContentCrashNavigationDelegate webView:didFinishNavigation:]):
3502         (TestWebKitAPI::TEST):
3503
3504 2018-06-25  Yusuke Suzuki  <utatane.tea@gmail.com>
3505
3506         Remove static initializers more
3507         https://bugs.webkit.org/show_bug.cgi?id=186969
3508
3509         Reviewed by Michael Catanzaro.
3510
3511         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3512         (WTR::assignedUrlsCache):
3513         (WTR::dumpResourceURL):
3514         (WTR::InjectedBundlePage::resetAfterTest):
3515         (WTR::InjectedBundlePage::didInitiateLoadForResource):
3516         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
3517         (WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
3518         (WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
3519         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
3520         (WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):
3521         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3522         (WTR::AccessibilityUIElement::stringAttributeValue):
3523         Use NeverDestroyed<> and static functions.
3524
3525 2018-06-26  Aakash Jain  <aakash_jain@apple.com>
3526
3527         [ews-build] Add support for compiling WebKit
3528         https://bugs.webkit.org/show_bug.cgi?id=187019
3529
3530         Reviewed by Lucas Forschler.
3531
3532         * BuildSlaveSupport/ews-build/steps.py:
3533         (CompileWebKit): Added, class to compile WebKit.
3534         (CleanBuild): Added, class to clean up the build.
3535         (KillOldProcesses): Added, class to kill old processes.
3536         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
3537         * BuildSlaveSupport/ews-build/config.json: Renamed ios-11-simulator to ios-simulator-11, to match with build.webkit.org code.
3538         Added configuration, architecture which is required for compiling. Renamed Release to release as the tools expect lower-case release.
3539         * BuildSlaveSupport/ews-build/factories.py: Added BuildFactory.
3540         * BuildSlaveSupport/ews-build/loadConfig.py: Renamed configuraton value to lower-case as tools expect lower-case values.
3541         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Ditto.
3542
3543 2018-06-26  Aakash Jain  <aakash_jain@apple.com>
3544
3545         [ews-build] Add support for WebKitPerl-Tests-EWS
3546         https://bugs.webkit.org/show_bug.cgi?id=187023
3547
3548         Reviewed by Lucas Forschler.
3549
3550         * BuildSlaveSupport/ews-build/config.json: Added WebKitPerl-tests-EWS.
3551         * BuildSlaveSupport/ews-build/factories.py: Added WebKitPerlFactory.
3552         * BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPerlTests.
3553         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
3554
3555 2018-06-26  Aakash Jain  <aakash_jain@apple.com>
3556
3557         [build.webkit.org] Rename badly named variable kls to schedulerType
3558         https://bugs.webkit.org/show_bug.cgi?id=186926
3559
3560         Reviewed by Lucas Forschler.
3561
3562         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3563         (loadBuilderConfig): Renamed kls to schedulerType.
3564
3565 2018-06-26  Daniel Bates  <dabates@apple.com>
3566
3567         EWS should pass --status-host-uses-http when invoking webkit-patch, if needed
3568         https://bugs.webkit.org/show_bug.cgi?id=187061
3569
3570         Reviewed by Per Arne Vollan.
3571
3572         When EWS invokes webkit-patch to perform an operation (e.g. apply an attachment)
3573         it should pass the command line option --status-host-uses-http, if EWS was
3574         started with this command line option, so that we query the status server over
3575         HTTP in child "webkit-patch" processes as we do in the main EWS process.
3576
3577         * Scripts/webkitpy/common/net/statusserver_mock.py:
3578         (MockStatusServer.__init__):
3579         * Scripts/webkitpy/tool/commands/queues.py:
3580         (AbstractQueue.run_webkit_patch):
3581
3582 2018-06-26  Daniel Bates  <dabates@apple.com>
3583
3584         webkit-patch: Make attachment commands work with status-server hosted attachments
3585         https://bugs.webkit.org/show_bug.cgi?id=187056
3586
3587         Reviewed by Per Arne Vollan.
3588
3589         Allow the EWS bots to apply, build, test, check-style, and (in the future) land
3590         attachments hosted on the status server. We only download an attachment from the
3591         status server if we do not have sufficient permission to download it from Bugzilla
3592         (e.g. security-sensitive patches).
3593
3594         A valid status server API key is required to run these commands by hand. Otherwise,
3595         the status server will not provide attachment data.
3596
3597         * Scripts/webkitpy/common/net/statusserver_mock.py:
3598         (MockStatusServer.fetch_attachment): Log a message for testing purposes.
3599         * Scripts/webkitpy/tool/commands/download.py:
3600         (ProcessAttachmentsMixin._fetch_list_of_patches_to_process): Fetch the attachment
3601         from the status server if we do not have permission to fetch it from Bugzilla.
3602         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
3603         (EarlyWarningSystemTest._default_expected_logs): Update expected result when
3604         using a custom work item and when fetching an attachment from the status server.
3605         (_test_ews): Modified to take use_security_sensitive_patch (defaults to False) as
3606         to whether to use a security-sensitive patch when testing.
3607         (test_ewses_with_security_sensitive_patch): Added.
3608
3609 2018-06-26  Daniel Bates  <dabates@apple.com>
3610
3611         contributors.json fails to parse after r233209
3612
3613         Removing trailing ',' that caused this file to be malformed. Also ran
3614         "validate-committer-lists -c" to canonicalize the style of this file.
3615
3616         * Scripts/webkitpy/common/config/contributors.json:
3617
3618 2018-06-26  Timothy Horton  <timothy_horton@apple.com>
3619
3620         Add Aditya to contributors.json as a contributor
3621
3622         * Scripts/webkitpy/common/config/contributors.json:
3623
3624 2018-06-26  Brent Fulgham  <bfulgham@apple.com>