Tools/ChangeLog

   1 2013-01-11  Carlos Garcia Campos  <cgarcia@igalia.com>
   2
   3         [GTK] Disable the unit tests timeout when running from make check
   4         https://bugs.webkit.org/show_bug.cgi?id=106670
   5
   6         Reviewed by Philippe Normand.
   7
   8         * GNUmakefile.am: Pass --timeout=-1 to run-gtk-test.
   9
  10 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
  11
  12         Yet another unreviewed fix after r139431.
  13
  14         * Scripts/run-launcher: Pass the arguments to `jhbuild-wrapper' in
  15         the correct order.
  16
  17 2013-01-11  Dan Carney  <dcarney@google.com>
  18
  19         [chromium] move some whitespace and resize related methods to TestRunner library
  20         https://bugs.webkit.org/show_bug.cgi?id=106655
  21
  22         Reviewed by Jochen Eisinger.
  23
  24         * DumpRenderTree/chromium/DRTTestRunner.cpp:
  25         (DRTTestRunner::DRTTestRunner):
  26         * DumpRenderTree/chromium/DRTTestRunner.h:
  27         (DRTTestRunner):
  28         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
  29         (WebKit):
  30         (WebTestRunner::WebTestDelegate::setClientWindowRect):
  31         (WebTestRunner::WebTestDelegate::setSelectTrailingWhitespaceEnabled):
  32         (WebTestRunner::WebTestDelegate::setSmartInsertDeleteEnabled):
  33         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
  34         (WebTestRunner::TestRunner::TestRunner):
  35         (WebTestRunner::TestRunner::setSmartInsertDeleteEnabled):
  36         (WebTestRunner):
  37         (WebTestRunner::TestRunner::setSelectTrailingWhitespaceEnabled):
  38         (WebTestRunner::TestRunner::enableAutoResizeMode):
  39         (WebTestRunner::TestRunner::disableAutoResizeMode):
  40         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
  41         (TestRunner):
  42         * DumpRenderTree/chromium/WebViewHost.cpp:
  43         (WebViewHost::setClientWindowRect):
  44         * DumpRenderTree/chromium/WebViewHost.h:
  45         (WebViewHost):
  46
  47 2013-01-11  Mario Sanchez Prada  <mario.prada@samsung.com>
  48
  49         Unreviewed. Update my e-mail addresses.
  50
  51         * Scripts/webkitpy/common/config/committers.py:
  52
  53 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
  54
  55         Another unreviewed fix after r139431.
  56
  57         In a way, this is also a generic bug fix, since previously isEfl()
  58         would fail when called from run-efl-tests and we thus did not use
  59         jhbuild to run our tests. This now resulted in us calling
  60         "jhbuild-wrapper run" without specifying a platform.
  61
  62         * Scripts/run-efl-tests: Pass "--efl" to ARGV manually for isEfl()
  63         to work.
  64
  65 2013-01-11  Allan Sandfeld Jensen  <allan.jensen@digia.com>
  66
  67         [Qt][WK1] Web Audio support
  68         https://bugs.webkit.org/show_bug.cgi?id=106651
  69
  70         Reviewed by Jocelyn Turcotte.
  71
  72         Implements support for dumping audio data in DumpRenderTree.
  73
  74         Adds WebAudio to toggleable features in QtTestBrowser.
  75
  76         Enables LEGACY_WEB_AUDIO. This feature is required for 2/3 of the web audio regression tests. It is enabled by default
  77         because it has no effect when WEB_AUDIO is not enabled. This combination matches the settings in FeatureList.pm.
  78
  79         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  80         (WebCore::DumpRenderTree::dump):
  81         * DumpRenderTree/qt/TestRunnerQt.cpp:
  82         (TestRunner::reset):
  83         (TestRunner::overridePreference):
  84         (TestRunner::setAudioData):
  85         * DumpRenderTree/qt/TestRunnerQt.h:
  86         (TestRunner::shouldDumpAsAudio):
  87         (TestRunner::audioData):
  88         (TestRunner):
  89         * QtTestBrowser/launcherwindow.cpp:
  90         (LauncherWindow::applyPrefs):
  91         (LauncherWindow::createChrome):
  92         (LauncherWindow::toggleWebAudio):
  93         * QtTestBrowser/launcherwindow.h:
  94         (WindowOptions::WindowOptions):
  95         (WindowOptions):
  96         (LauncherWindow):
  97         * qmake/mkspecs/features/features.prf:
  98         * qmake/mkspecs/features/features.pri:
  99
 100 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
 101
 102         Unreviewed jhbuild-related fix after r139431.
 103
 104         * Scripts/webkitpy/layout_tests/port/efl.py:
 105         (EflPort.__init__): Pass a string to set_option_default(), since
 106         shlex.split() will be called on it later.
 107
 108 2013-01-11  Csaba Osztrogonác  <ossy@webkit.org>
 109
 110         Unreviewed typo fixes after r139431.
 111
 112         * Scripts/run-javascriptcore-tests:
 113
 114 2013-01-11  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
 115
 116         [jhbuild] Remove the "run-with-jhbuild" scripts.
 117         https://bugs.webkit.org/show_bug.cgi?id=106572
 118
 119         Reviewed by Martin Robinson.
 120
 121         Both ports which use jhbuild were mostly duplicating the
 122         `run-with-jhbuild' script in their own directories for no clear reason.
 123
 124         The script itself was just a thin wrapper around the `jhbuild-wrapper',
 125         so just start using that directly and get rid of a useless middle man.
 126
 127         Adjust scripts which called run-with-jhbuild to call jhbuild-wrapper
 128         instead.
 129
 130         * Scripts/run-javascriptcore-tests:
 131         * Scripts/run-launcher:
 132         * Scripts/webkitdirs.pm:
 133         (runAutogenForAutotoolsProjectIfNecessary):
 134         (buildAutotoolsProject):
 135         (jhbuildWrapperPrefixIfNeeded):
 136         (generateBuildSystemFromCMakeProject):
 137         (buildCMakeGeneratedProject):
 138         * Scripts/webkitpy/common/multiprocessing_bootstrap.py:
 139         (run):
 140         * Scripts/webkitpy/layout_tests/port/efl.py:
 141         (EflPort.__init__):
 142         (EflPort._image_diff_command):
 143         * efl/run-with-jhbuild: Removed.
 144         * gtk/run-with-jhbuild: Removed.
 145
 146 2013-01-11  Alan Cutter  <alancutter@chromium.org>
 147
 148         Allow arbitrary queue launch parameters in EWSTools/start-queue.sh
 149         https://bugs.webkit.org/show_bug.cgi?id=106636
 150
 151         Reviewed by Adam Barth.
 152
 153         This parameter will allow the bot boot script to use start-queue.sh and provide an IRC password for sheriffbot.
 154
 155         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
 156         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
 157         * EWSTools/screen-config:
 158         * EWSTools/start-queue.sh:
 159
 160 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
 161
 162         kill-old-processes and delete-stale-build-files use CRLF linebreaks
 163         https://bugs.webkit.org/show_bug.cgi?id=106622
 164
 165         Reviewed by Simon Fraser.
 166
 167         Use LF instead of CRLF in kill-old-processes and delete-stale-build-files.
 168         Also escape clang\+\+ correctly in kill-old-processes.
 169
 170         * BuildSlaveSupport/delete-stale-build-files:
 171         * BuildSlaveSupport/kill-old-processes:
 172
 173 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
 174
 175         Build fix after r139357. It was missing a comma.
 176
 177         * QueueStatusServer/model/queues.py:
 178         (Queue):
 179
 180 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
 181
 182         Fixing AuthenticationError when running test-webkitpy as a non-committer.
 183         https://bugs.webkit.org/show_bug.cgi?id=106420
 184
 185         Reviewed by Eric Seidel.
 186
 187         * Scripts/webkitpy/common/checkout/scm/git.py:
 188         (Git.push_local_commits_to_server):
 189         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 190         * Scripts/webkitpy/common/checkout/scm/svn.py:
 191         (SVNRepository):
 192         (SVNRepository.has_authorization_for_realm):
 193
 194 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
 195
 196         [EFL][jhbuild] Use tarballs for gstreamer instead of git
 197         https://bugs.webkit.org/show_bug.cgi?id=106552
 198
 199         Reviewed by Laszlo Gombos.
 200
 201         Use tarballs for gstreamer instead of git in EFL's jhbuild
 202         to work around intermittent network issues on our build
 203         bots. Tarballs are fully cached and require no network
 204         operation if their checksum matches.
 205
 206         * efl/jhbuild.modules:
 207
 208 2013-01-10  Ryosuke Niwa  <rniwa@webkit.org>
 209
 210         Add Mac WK2 EWS bots
 211         https://bugs.webkit.org/show_bug.cgi?id=106590
 212
 213         Reviewed by Adam Barth.
 214
 215         Added MacWK2EWS, and made myself a watcher for MacEWS and MacWK2EWS.
 216         Also add a deprecated MacWK2Port class.
 217
 218         * QueueStatusServer/model/queues.py:
 219         (Queue):
 220         * Scripts/webkitpy/common/config/ports.py:
 221         (DeprecatedPort.port):
 222         (MacWK2Port):
 223         (MacWK2Port.run_webkit_tests_command):
 224         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 225         (MacEWS):
 226         (MacWK2EWS):
 227         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
 228         (_test_ewses):
 229
 230 2013-01-10  Dan Carney  <dcarney@google.com>
 231
 232         [chromium] move webpermissionclient related methods to TestRunner library
 233         https://bugs.webkit.org/show_bug.cgi?id=106548
 234
 235         Reviewed by Jochen Eisinger.
 236
 237         * DumpRenderTree/DumpRenderTree.gypi:
 238         * DumpRenderTree/chromium/DRTTestRunner.cpp:
 239         (DRTTestRunner::DRTTestRunner):
 240         (DRTTestRunner::reset):
 241         * DumpRenderTree/chromium/DRTTestRunner.h:
 242         (DRTTestRunner):
 243         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
 244         (WebTestRunner::WebTestDelegate::normalizeLayoutTestURL):
 245         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
 246         (WebKit):
 247         (WebTestRunner::WebTestRunner::webPermissions):
 248         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
 249         (WebTestRunner::TestRunner::TestRunner):
 250         (WebTestRunner::TestRunner::setDelegate):
 251         (WebTestRunner):
 252         (WebTestRunner::TestRunner::reset):
 253         (WebTestRunner::TestRunner::webPermissions):
 254         (WebTestRunner::TestRunner::dumpPermissionClientCallbacks):
 255         (WebTestRunner::TestRunner::setImagesAllowed):
 256         (WebTestRunner::TestRunner::setScriptsAllowed):
 257         (WebTestRunner::TestRunner::setStorageAllowed):
 258         (WebTestRunner::TestRunner::setPluginsAllowed):
 259         (WebTestRunner::TestRunner::setAllowDisplayOfInsecureContent):
 260         (WebTestRunner::TestRunner::setAllowRunningOfInsecureContent):
 261         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
 262         (WebTestRunner):
 263         (TestRunner):
 264         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.cpp: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.cpp.
 265         (WebTestRunner):
 266         (WebTestRunner::WebPermissions::WebPermissions):
 267         (WebTestRunner::WebPermissions::~WebPermissions):
 268         (WebTestRunner::WebPermissions::allowImage):
 269         (WebTestRunner::WebPermissions::allowScriptFromSource):
 270         (WebTestRunner::WebPermissions::allowStorage):
 271         (WebTestRunner::WebPermissions::allowPlugins):
 272         (WebTestRunner::WebPermissions::allowDisplayingInsecureContent):
 273         (WebTestRunner::WebPermissions::allowRunningInsecureContent):
 274         (WebTestRunner::WebPermissions::setImagesAllowed):
 275         (WebTestRunner::WebPermissions::setScriptsAllowed):
 276         (WebTestRunner::WebPermissions::setStorageAllowed):
 277         (WebTestRunner::WebPermissions::setPluginsAllowed):
 278         (WebTestRunner::WebPermissions::setDisplayingInsecureContentAllowed):
 279         (WebTestRunner::WebPermissions::setRunningInsecureContentAllowed):
 280         (WebTestRunner::WebPermissions::setDelegate):
 281         (WebTestRunner::WebPermissions::setDumpCallbacks):
 282         (WebTestRunner::WebPermissions::reset):
 283         * DumpRenderTree/chromium/TestRunner/src/WebPermissions.h: Renamed from Tools/DumpRenderTree/chromium/WebPermissions.h.
 284         (WebTestRunner):
 285         (WebPermissions):
 286         * DumpRenderTree/chromium/TestShell.cpp:
 287         (TestShell::initialize):
 288         (TestShell::resetTestController):
 289         (TestShell::createNewWindow):
 290         * DumpRenderTree/chromium/TestShell.h:
 291         (TestShell):
 292         * DumpRenderTree/chromium/WebViewHost.cpp:
 293         (WebViewHost::normalizeLayoutTestURL):
 294         * DumpRenderTree/chromium/WebViewHost.h:
 295         (WebViewHost):
 296
 297 2013-01-10  Alan Cutter  <alancutter@chromium.org>
 298
 299         Split EWS tool cold-boot.sh into modular components
 300         https://bugs.webkit.org/show_bug.cgi?id=106527
 301
 302         Reviewed by Adam Barth.
 303
 304         Split cold-boot.sh script up into build-vm.sh, build-repo.sh and build-boot-cmd.sh.
 305         Updated GCE bot build scripts to match.
 306         Unable to test scripts directly as they depend on being in the repository to work!
 307
 308         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
 309         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
 310         * EWSTools/build-boot-cmd.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-chromium-ews.sh.
 311         * EWSTools/build-repo.sh: Copied from Tools/EWSTools/cold-boot.sh.
 312         * EWSTools/build-vm.sh: Renamed from Tools/EWSTools/cold-boot.sh.
 313
 314 2013-01-10  Julie Parent  <jparent@chromium.org>
 315
 316         Dashboard Cleanup: Do not generate the page if we are about to reload.
 317         https://bugs.webkit.org/show_bug.cgi?id=106584
 318
 319         Reviewed by Dirk Pranke.
 320
 321         Move the logic to determine if we should generate the page into
 322         parseParameters() since that is where we have the knowledge to
 323         determine it, and return that value to handleLocationChange,
 324         rather than passing the changed parameters back to handleLocationChange
 325         and having it make the decision.
 326
 327         This is logically equivalent, save one case: when we are about to do
 328         a reload, we know that there is no reason to generate the page.  Old
 329         code was causing an extra page generation in this case.
 330
 331         * TestResultServer/static-dashboards/dashboard_base.js:
 332         (parseParameters):
 333         (handleLocationChange):
 334
 335 2013-01-10  Raphael Kubo da Costa  <raphael.kubo.da.costa@intel.com>
 336
 337         [jhbuild] Use the "configure" script to build glib
 338         https://bugs.webkit.org/show_bug.cgi?id=106569
 339
 340         Reviewed by Martin Robinson.
 341
 342         So far both EFL and GTK have been using autogen.sh to build glib.
 343         While that does work most of the time, it's not really needed since
 344         we are downloading and building stable releases from tarballs.
 345         Additionally, autogen.sh fails to work with automake 1.13 due to the
 346         usage of some macros that have been removed (this has already been
 347         fixed in glib master).
 348
 349         * efl/jhbuild.modules:
 350         * gtk/jhbuild.modules:
 351
 352 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
 353
 354         Changing tests to be consistent and use self.scm rather then recreating the scm object.
 355         (Missed a couple)
 356         https://bugs.webkit.org/show_bug.cgi?id=106536
 357
 358         Reviewed by Eric Seidel.
 359
 360         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 361
 362 2013-01-10  Tony Chang  <tony@chromium.org>
 363
 364         Speed up supplemental dependency computation
 365         https://bugs.webkit.org/show_bug.cgi?id=106503
 366
 367         Reviewed by Adam Barth.
 368
 369         Pass the IDL attributes file for generating the bindings in WebKitTestRunner.
 370
 371         * WebKitTestRunner/CMakeLists.txt:
 372
 373 2013-01-10  Zan Dobersek  <zandobersek@gmail.com>
 374
 375         Remove the ENABLE_ANIMATION_API feature define occurences
 376         https://bugs.webkit.org/show_bug.cgi?id=106544
 377
 378         Reviewed by Simon Fraser.
 379
 380         The Animation API code was removed in r137243. The ENABLE_ANIMATION_API
 381         feature define handling still lingers in various build systems and configurations
 382         but is of no use, so it should be removed.
 383
 384         * Scripts/webkitperl/FeatureList.pm:
 385         * qmake/mkspecs/features/features.pri:
 386
 387 2013-01-10  Carlos Garcia Campos  <cgarcia@igalia.com>
 388
 389         [GTK] Add support for loading web process extensions
 390         https://bugs.webkit.org/show_bug.cgi?id=105631
 391
 392         Reviewed by Gustavo Noronha Silva.
 393
 394         * MiniBrowser/gtk/GNUmakefile.am:
 395         * MiniBrowser/gtk/main.c:
 396         (main): Set WEBKIT_INJECTED_BUNDLE env var to use the injected
 397         bundle lib from build dir.
 398         * Scripts/webkitpy/style/checker.py: Add exceptions for GTK+ API
 399         located in WebProcess/InjectedBundle/API/gtk.
 400         * gtk/generate-gtkdoc:
 401         (get_webkit2_options): Scan also files in
 402         WebProcess/InjectedBundle/API/gtk to generate API docs.
 403         (get_webkit2_options.injected_bundle_src_path): Helper function to
 404         build paths in WebProcess/InjectedBundle/API/gtk.
 405
 406 2013-01-10  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
 407
 408         [EFL][WK2] Writing immediately to created windows (open) fails
 409         https://bugs.webkit.org/show_bug.cgi?id=105276
 410
 411         Reviewed by Kenneth Rohde Christiansen.
 412
 413         Do not reset 'about:blank' url for the new pages in mini browser.
 414
 415         * MiniBrowser/efl/main.c:
 416         (window_create):
 417
 418 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
 419
 420         Changing tests to be consistent and use self.scm rather then recreating the scm object.
 421         https://bugs.webkit.org/show_bug.cgi?id=106536
 422
 423         Reviewed by Eric Seidel.
 424
 425         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 426
 427 2013-01-10  Tim 'mithro' Ansell  <mithro@mithis.com>
 428
 429         Converting to unittest2 so we can use assertItemsEqual, making tests
 430         not dependent on order of items.
 431         https://bugs.webkit.org/show_bug.cgi?id=106532
 432
 433         Before:
 434         Ran 1733 tests in 38.385s
 435         FAILED (failures=1, errors=22)
 436
 437         After:
 438         Ran 1733 tests in 32.298s
 439         FAILED (failures=0, errors=22)
 440
 441         Reviewed by Eric Seidel.
 442
 443         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
 444         * Scripts/webkitpy/thirdparty/__init__.py:
 445         (AutoinstallImportHook._install_unittest2):
 446
 447 2013-01-10  Christophe Dumez  <christophe.dumez@intel.com>
 448
 449         [EFL] Add gstreamer 1.0.5 to jhbuild
 450         https://bugs.webkit.org/show_bug.cgi?id=106178
 451
 452         Reviewed by Laszlo Gombos.
 453
 454         Add gstreamer 1.0.5 to EFL's jhbuild configuration.
 455
 456         * efl/jhbuild.modules:
 457
 458 2013-01-09  Alan Cutter  <alancutter@chromium.org>
 459
 460         Updated parameters in GCE build scripts so they now work.
 461         https://bugs.webkit.org/show_bug.cgi?id=106523
 462
 463         Reviewed by Adam Barth.
 464
 465         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh:
 466         * EWSTools/GoogleComputeEngine/build-commit-queue.sh:
 467         * EWSTools/cold-boot.sh:
 468
 469 2013-01-09  Mark Pilgrim  <pilgrim@chromium.org>
 470
 471         [Chromium] Remove some stray references to WebKitPlatformSupport.h in DumpRenderTree
 472         https://bugs.webkit.org/show_bug.cgi?id=106520
 473
 474         Reviewed by James Robinson.
 475
 476         Part of a larger refactoring series. See tracking bug 82948.
 477
 478         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
 479         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
 480
 481 2013-01-09  Julie Parent  <jparent@chromium.org>
 482
 483         Dashboard cleanup: Remove code for currentState and window.location.hash getting out of state
 484         https://bugs.webkit.org/show_bug.cgi?id=106514
 485
 486         This is old code, as these can no longer get out of sync.
 487         permmaLinkURLHash is generated from currentState, which is set only
 488         from the location.  The commment about how these can get out of sync
 489         refers to a function that no longer exists.
 490
 491         Reviewed by Dirk Pranke.
 492
 493         * TestResultServer/static-dashboards/dashboard_base.js:
 494         (handleLocationChange):
 495
 496 2013-01-09  Julie Parent  <jparent@chromium.org>
 497
 498         Dashboard Cleanup: Reload the page as soon as we know we need to.
 499         https://bugs.webkit.org/show_bug.cgi?id=106515
 500
 501         No need to continue parsing all of the data once we know that
 502         we need to do a reload.
 503
 504         Reviewed by Dirk Pranke.
 505
 506         * TestResultServer/static-dashboards/dashboard_base.js:
 507         (parseParameters):
 508
 509 2013-01-09  Eric Seidel  <eric@webkit.org>
 510
 511         run-perf-tests --chromium-android --profile should show symbols for the kernel
 512         https://bugs.webkit.org/show_bug.cgi?id=106498
 513
 514         Reviewed by Adam Barth.
 515
 516         Turns out this was easy, once I finally read the output from "perf report".
 517         It appears there may be a bug in "perf record" on android, as it complains
 518         about not being able to read from /proc/kallsyms even when
 519         /proc/sys/kernel/kptr_restrict is 0.  For now I've not bothered
 520         to keep /proc/sys/kernel/kptr_restrict as 0 during the actual record
 521         but rather just flip it to 0 long enough to grab the /proc/kallsyms
 522         and then flip it back to whatever the device had.
 523
 524         /proc/sys/kernel/kptr_restrict controls what /proc/kallsyms returns
 525         on Linux.  /proc/kallsyms contains a mapping of kernel addresses
 526         to symbol names.  Its world-readable, but will return all 0s if you
 527         don't have permission to see the kernel symbols.  kptr_restrict
 528         supports values 0, 1, 2.  Where 0 means "everyone can see the real symbols"
 529         1 is only a specific group, and 2 is "no one, not even root".
 530         By default kptr_restrict is 2 on Android it seems.
 531         More kptr_restrict docs: http://lwn.net/Articles/420403/
 532
 533         I also took this opportunity to clean up how the perf record command
 534         was built for use/display in AndroidPerf.profile_after_exit and
 535         change to always using long-form names for the arguments (to hopefully help readability).
 536
 537         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
 538         (AndroidPerf.__init__):
 539         (profile_after_exit):
 540         (ChromiumAndroidDriver.__init__):
 541         (ChromiumAndroidDriver._update_kallsyms_cache):
 542         * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
 543
 544 2013-01-09  Julie Parent  <jparent@chromium.org>
 545
 546         Dashboard cleanup: remove dead code.
 547         https://bugs.webkit.org/show_bug.cgi?id=106509
 548
 549         Reviewed by Dirk Pranke.
 550
 551         * TestResultServer/static-dashboards/dashboard_base.js:
 552         (parseParameters):
 553
 554 2013-01-09  Joanmarie Diggs  <jdiggs@igalia.com>
 555
 556         [GTK] accessibility/aria-labelledby-overrides-label.html requires a proper baseline
 557         https://bugs.webkit.org/show_bug.cgi?id=105638
 558
 559         Reviewed by Martin Robinson.
 560
 561         The test was failing for two reasons:
 562         - AccessibilityRenderObject::correspondingLabelForControlElement() was
 563           not ignoring the ARIA labelled-by property
 564         - AccessibilityController::accessibleElementById() was not implemented
 565
 566         Because getting an element by ID cannot be done in the UIProcess, the
 567         decision was made to expose the element's ID as an accessible attribute
 568         of the object.
 569
 570         In addition, fixing the bug in AccessibilityRenderObject made it possible
 571         to eliminate the Gtk platform-specific expectations for another test.
 572
 573         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
 574         (childElementById): Added. Walks the tree looking for the AtkObject
 575         Attribute which exposes the HTML element's ID.
 576         (AccessibilityController::accessibleElementById): Implemented.
 577         * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
 578         (AccessibilityUIElement::title): Modified to print out "AXTitle: " even
 579         when there is no title, as is done with the Mac port.
 580         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
 581         (WTR):
 582         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
 583         (WTR::childElementById): Added. Walks the tree looking for the AtkObject
 584         Attribute which exposes the HTML element's ID.
 585         (WTR):
 586         (WTR::AccessibilityController::accessibleElementById): Implemented.
 587         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 588         (WTR::AccessibilityUIElement::title): Modified to print out "AXTitle: "
 589         even when there is no title, as is done with the Mac port.
 590
 591 2013-01-09  Gregg Tavares  <gman@google.com>
 592
 593         Add Gregg Tavares as a committer
 594         https://bugs.webkit.org/show_bug.cgi?id=106492
 595
 596         Unreviewed.
 597
 598         * Scripts/webkitpy/common/config/committers.py:
 599
 600 2013-01-09  Roger Fong  <roger_fong@apple.com>
 601
 602         Enable seamless iFrames for Windows DRT.
 603         https://bugs.webkit.org/show_bug.cgi?id=106468.
 604
 605         Rubberstamped by Timothy Horton.
 606
 607         * DumpRenderTree/win/DumpRenderTree.cpp:
 608         (resetDefaultsToConsistentValues):
 609
 610 2013-01-09  Christophe Dumez  <christophe.dumez@intel.com>
 611
 612         [WK2] Implement eventSender.scheduleAsynchronousKeyDown
 613         https://bugs.webkit.org/show_bug.cgi?id=93979
 614
 615         Reviewed by Benjamin Poulain.
 616
 617         Implement eventSender.scheduleAsynchronousKeyDown() in
 618         WebKitTestRunner.
 619
 620         * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
 621         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
 622         (WTR::createKeyDownMessageBody):
 623         (WTR::EventSendingController::keyDown):
 624         (WTR::EventSendingController::scheduleAsynchronousKeyDown):
 625         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
 626         (EventSendingController):
 627         * WebKitTestRunner/TestController.cpp:
 628         (WTR::TestController::didReceiveKeyDownMessageFromInjectedBundle):
 629         (WTR::TestController::didReceiveMessageFromInjectedBundle):
 630         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
 631         * WebKitTestRunner/TestController.h:
 632         (TestController):
 633
 634 2013-01-09  Jochen Eisinger  <jochen@chromium.org>
 635
 636         [chromium] move resource load callback dumping to TestRunner library
 637         https://bugs.webkit.org/show_bug.cgi?id=106449
 638
 639         Reviewed by Adam Barth.
 640
 641         * DumpRenderTree/chromium/DRTTestRunner.cpp:
 642         (DRTTestRunner::DRTTestRunner):
 643         (DRTTestRunner::reset):
 644         * DumpRenderTree/chromium/DRTTestRunner.h:
 645         (DRTTestRunner):
 646         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
 647         (WebKit):
 648         (WebTestRunner::WebTestDelegate::makeURLErrorDescription):
 649         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
 650         (WebKit):
 651         (WebTestProxyBase):
 652         (WebTestRunner::WebTestProxy::assignIdentifierToRequest):
 653         (WebTestRunner::WebTestProxy::willRequestResource):
 654         (WebTestRunner::WebTestProxy::willSendRequest):
 655         (WebTestRunner::WebTestProxy::didReceiveResponse):
 656         (WebTestRunner::WebTestProxy::didFinishResourceLoad):
 657         (WebTestRunner::WebTestProxy::didFailResourceLoad):
 658         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
 659         (WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
 660         (WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
 661         (WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
 662         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
 663         (WebTestRunner::TestRunner::TestRunner):
 664         (WebTestRunner::TestRunner::reset):
 665         (WebTestRunner::TestRunner::shouldDumpResourceLoadCallbacks):
 666         (WebTestRunner::TestRunner::shouldDumpResourceRequestCallbacks):
 667         (WebTestRunner::TestRunner::shouldDumpResourceResponseMIMETypes):
 668         (WebTestRunner):
 669         (WebTestRunner::TestRunner::dumpResourceLoadCallbacks):
 670         (WebTestRunner::TestRunner::dumpResourceRequestCallbacks):
 671         (WebTestRunner::TestRunner::dumpResourceResponseMIMETypes):
 672         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
 673         (TestRunner):
 674         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
 675         (WebTestRunner::WebTestProxyBase::reset):
 676         (WebTestRunner):
 677         (WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
 678         (WebTestRunner::WebTestProxyBase::willRequestResource):
 679         (WebTestRunner::WebTestProxyBase::willSendRequest):
 680         (WebTestRunner::WebTestProxyBase::didReceiveResponse):
 681         (WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
 682         (WebTestRunner::WebTestProxyBase::didFailResourceLoad):
 683         * DumpRenderTree/chromium/WebViewHost.cpp:
 684         (WebViewHost::willSendRequest):
 685         (WebViewHost::makeURLErrorDescription):
 686         (WebViewHost::reset):
 687         * DumpRenderTree/chromium/WebViewHost.h:
 688         (WebViewHost):
 689
 690 2013-01-09  Dan Carney  <dcarney@google.com>
 691
 692         [chromium] move dumpcreateview methods to testrunner library
 693         https://bugs.webkit.org/show_bug.cgi?id=106434
 694
 695         Reviewed by Adam Barth.
 696
 697         * DumpRenderTree/chromium/DRTTestRunner.cpp:
 698         (DRTTestRunner::DRTTestRunner):
 699         (DRTTestRunner::reset):
 700         * DumpRenderTree/chromium/DRTTestRunner.h:
 701         (DRTTestRunner):
 702         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
 703         (WebTestRunner::WebTestRunner::shouldDumpCreateView):
 704         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
 705         (WebTestRunner::TestRunner::TestRunner):
 706         (WebTestRunner::TestRunner::reset):
 707         (WebTestRunner::TestRunner::shouldDumpCreateView):
 708         (WebTestRunner):
 709         (WebTestRunner::TestRunner::dumpCreateView):
 710         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
 711         (TestRunner):
 712
 713 2013-01-09  Csaba Osztrogonác  <ossy@webkit.org>
 714
 715         webkitpy cleanup: Merge additional_comment_text into comment_text
 716         https://bugs.webkit.org/show_bug.cgi?id=106421
 717
 718         Reviewed by Adam Barth.
 719
 720         * Scripts/webkitpy/common/config/committervalidator.py:
 721         (CommitterValidator.reject_patch_from_commit_queue):
 722         (CommitterValidator.reject_patch_from_review_queue):
 723         * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
 724         (Bugzilla.set_flag_on_attachment):
 725         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
 726         (MockBugzilla.set_flag_on_attachment):
 727         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
 728         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
 729         (AbstractEarlyWarningSystem._post_reject_message_on_bug):
 730         * Scripts/webkitpy/tool/commands/queues_unittest.py:
 731
 732 2013-01-09  Mario Sanchez Prada  <mario.prada@samsung.com>
 733
 734         [GTK] Raise version of gdk-pixbuf in jhbuild up to 2.26.5
 735         https://bugs.webkit.org/show_bug.cgi?id=106464
 736
 737         Reviewed by Martin Robinson.
 738
 739         Current version in jhbuild.modules (2.26.0) is giving trouble to
 740         when trying to build WebKitGTK from scratch, due to a segmentation
 741         fault error in gdk-pixbuf-query-loader during the 'make'
 742         phase. Raising the version to 2.26.5 fixes this issue.
 743
 744         * gtk/jhbuild.modules: Version raised, checksums updated.
 745
 746 2013-01-09  János Badics  <jbadics@inf.u-szeged.hu>
 747
 748         [Qt][NRWT] Pass --timeout to DRT/WTR if a test is marked as SLOW.
 749         https://bugs.webkit.org/show_bug.cgi?id=90968.
 750
 751         Reviewed by Csaba Osztrogonác.
 752
 753         Added functionality in DRT and WTR to use any timeout value while running
 754         slow tests (eventually, any test). Now NRWT --time-out-ms determines the
 755         timeout value for the test. Added a flag in NRWT (supports_per_test_timeout)
 756         to indicate whether the current port supports setting timeout value
 757         per test (it's False by default; I enabled it only on Qt).
 758         Also corrected a typo in driver.py
 759
 760         * DumpRenderTree/DumpRenderTree.h:
 761         (TestCommand::TestCommand):
 762         (TestCommand):
 763         * DumpRenderTree/DumpRenderTreeCommon.cpp:
 764         (parseInputLine):
 765         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
 766         (WebCore::DumpRenderTree::processLine):
 767         * Scripts/webkitpy/layout_tests/port/base.py:
 768         (Port.supports_per_test_timeout):
 769         * Scripts/webkitpy/layout_tests/port/driver.py:
 770         (Driver.run_test):
 771         (Driver._command_from_driver_input):
 772         * Scripts/webkitpy/layout_tests/port/qt.py:
 773         (QtPort.supports_per_test_timeout):
 774         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
 775         (WTR::InjectedBundle::InjectedBundle):
 776         (WTR::InjectedBundle::didReceiveMessage):
 777         (WTR::InjectedBundle::beginTesting):
 778         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
 779         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 780         (WTR::TestRunner::setCustomTimeout):
 781         (WTR):
 782         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 783         (TestRunner):
 784         * WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
 785         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
 786         * WebKitTestRunner/TestController.cpp:
 787         (WTR::TestController::TestController):
 788         (WTR::TestController::getCustomTimeout):
 789         (WTR):
 790         (WTR::TestCommand::TestCommand):
 791         (TestCommand):
 792         (WTR::parseInputLine):
 793         (WTR::TestController::runTest):
 794         (WTR::TestController::runUntil):
 795         * WebKitTestRunner/TestController.h:
 796         (TestController):
 797         * WebKitTestRunner/TestInvocation.cpp:
 798         (WTR::TestInvocation::TestInvocation):
 799         (WTR::TestInvocation::setCustomTimeout):
 800         (WTR):
 801         (WTR::TestInvocation::invoke):
 802         * WebKitTestRunner/TestInvocation.h:
 803         (TestInvocation):
 804
 805 2013-01-08  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 806
 807         Regression(r138681): Add HAVE(ACCESSIBILITY) guard to atk files
 808         https://bugs.webkit.org/show_bug.cgi?id=106290
 809
 810         Reviewed by Martin Robinson.
 811
 812         Some atk files don't use HAVE(ACCESSIBILITY). It might make build errors when
 813         the macro isn't enabled.
 814
 815         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
 816
 817 2013-01-08  Martin Robinson  <mrobinson@igalia.com>
 818
 819         WebKitTestRunner needs support for setHandlesAuthenticationChallenges
 820         https://bugs.webkit.org/show_bug.cgi?id=103653
 821
 822         Reviewed by Anders Carlsson.
 823
 824         Implement setHandlesAuthenticationChallenges in the UIProcess by sending credentials
 825         and the enabled boolean to the UIProcess and then implementing the didReceiveAuthenticationChallengeInFrame
 826         client callback.
 827
 828         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Exposed the new TestRunner
 829         methods to the JavaScript API.
 830         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
 831         (WTR::TestRunner::setHandlesAuthenticationChallenges): Added this callback for the JavaScript API.
 832         (WTR::TestRunner::setAuthenticationUsername): Ditto.
 833         (WTR::TestRunner::setAuthenticationPassword): Ditto.
 834         * WebKitTestRunner/InjectedBundle/TestRunner.h:
 835         (TestRunner): Added new declarations for the above.
 836         * WebKitTestRunner/TestController.cpp:
 837         (WTR::TestController::createWebViewWithOptions): Hook up the new didReceiveSynchronousMessageFromInjectedBundle
 838         callback.
 839         (WTR::TestController::resetStateToConsistentValues): Reset the credentials and enabled boolean between tests.
 840         (WTR::TestController::didReceiveAuthenticationChallengeInFrame): Handle the callback by using
 841         the authentication information passed from the InjectedBundle.
 842         * WebKitTestRunner/TestController.h:
 843         (WTR::TestController::setHandlesAuthenticationChallenges): Added setter to allow TestInvocation
 844         to communicate with the TestController.
 845         (WTR::TestController::setAuthenticationUsername): Ditto.
 846         (WTR::TestController::setAuthenticationPassword): Ditto.
 847         (TestController):
 848         * WebKitTestRunner/TestInvocation.cpp:
 849         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the messages sending authentication
 850         information from the InjectedBundle.
 851         (WTR::TestInvocation::outputText): Added this method so that the TestController can output
 852         text to the TestInvocation text output.
 853         * WebKitTestRunner/TestInvocation.h:
 854         (TestInvocation): Added declaration for new method.
 855
 856 2013-01-08  Benjamin Poulain  <benjamin@webkit.org>
 857
 858         Add myself as a watcher for Web Geolocation
 859
 860         Unreviewed.
 861
 862         * Scripts/webkitpy/common/config/watchlist:
 863
 864 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
 865
 866         [webkitpy] Call setup_test_run method of the parent Port interface when method is called on subclasses
 867         https://bugs.webkit.org/show_bug.cgi?id=106364
 868
 869         Reviewed by Eric Seidel.
 870
 871         When the setup_test_run method is called on the subclasses of the base Port
 872         interface, the parent method should also be called via super(), despite the
 873         parent method not doing anything at the moment.
 874
 875         The according calls to super() are required in the ChromiumPort, EflPort
 876         and GtkPort implementations.
 877
 878         * Scripts/webkitpy/layout_tests/port/chromium.py:
 879         (ChromiumPort.setup_test_run):
 880         * Scripts/webkitpy/layout_tests/port/efl.py:
 881         (EflPort.setup_test_run):
 882         * Scripts/webkitpy/layout_tests/port/gtk.py:
 883         (GtkPort.setup_test_run):
 884
 885 2013-01-08  Julie Parent  <jparent@chromium.org>
 886
 887         Dashboard cleanup: Remove globals g_buildersThatFailedToLoad and g_staleBuilders
 888         https://bugs.webkit.org/show_bug.cgi?id=106356
 889
 890         g_buildersThatFailedToLoad and g_staleBuilders were globals defined in
 891         dashboard_base, assigned by Loader, and used only by dashboard_base to
 892         create error messages.  Moved the variables to be privates on the Loader
 893         object, moved error message creation to _getLoadingErrorMessages on the
 894         Loader object, and now pass the errors back to dashboard base via the
 895         resourceLoadingComplete callback.
 896
 897         Also removed the now unused clearError function, it was only being used
 898         by unit tests to clean up global state.
 899
 900         Reviewed by Dirk Pranke.
 901
 902         * TestResultServer/static-dashboards/dashboard_base.js:
 903         (resourceLoadingComplete):
 904         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
 905         * TestResultServer/static-dashboards/loader.js:
 906         (.):
 907         * TestResultServer/static-dashboards/loader_unittests.js:
 908
 909 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
 910
 911         [EFL][GTK] Make the PulseAudioSanitizer an object on the EflPort, GtkPort
 912         https://bugs.webkit.org/show_bug.cgi?id=106354
 913
 914         Reviewed by Eric Seidel.
 915
 916         Put the PulseAudioSanitizer object on the EflPort and GtkPort interfaces
 917         instead of those two inheriting from it. Also add a mock object of the
 918         sanitizer that's used in unit tests.
 919
 920         * Scripts/webkitpy/layout_tests/port/efl.py:
 921         (EflPort):
 922         (EflPort.__init__):
 923         (EflPort.setup_test_run):
 924         (EflPort.clean_up_test_run):
 925         * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Also correct the
 926         importing order.
 927         (EflPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
 928         * Scripts/webkitpy/layout_tests/port/gtk.py:
 929         (GtkPort):
 930         (GtkPort.__init__):
 931         (GtkPort.setup_test_run):
 932         (GtkPort.clean_up_test_run):
 933         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Also correct the
 934         importing order.
 935         (GtkPortTest.make_port): Put a mock PulseAudioSanitizer on the instance.
 936         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py:
 937         (PulseAudioSanitizer.unload_pulseaudio_module): Stylize the method as public.
 938         (PulseAudioSanitizer.restore_pulseaudio_module): Ditto.
 939         * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer_mock.py: Added.
 940         (PulseAudioSanitizerMock): A simple mock interface for PulseAudioSanitizer.
 941         (PulseAudioSanitizerMock.unload_pulseaudio_module):
 942         (PulseAudioSanitizerMock.restore_pulseaudio_module):
 943
 944 2013-01-08  Jochen Eisinger  <jochen@chromium.org>
 945
 946         [chromium] move dumpFrameLoadCallbacks and friends to the TestRunner library
 947         https://bugs.webkit.org/show_bug.cgi?id=106324
 948
 949         Reviewed by Adam Barth.
 950
 951         Since the frame load callbacks are part of the WebFrameClient, the
 952         WebTestProxy is now intercepting both WebViewClient and WebFrameClient
 953         methods.
 954
 955         * DumpRenderTree/chromium/DRTTestRunner.cpp:
 956         (DRTTestRunner::DRTTestRunner):
 957         (DRTTestRunner::reset):
 958         * DumpRenderTree/chromium/DRTTestRunner.h:
 959         (DRTTestRunner):
 960         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
 961         (WebTestInterfaces):
 962         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
 963         (WebKit):
 964         (WebTestProxyBase):
 965         (WebTestRunner):
 966         (WebTestRunner::WebTestProxy::WebTestProxy):
 967         (WebTestProxy):
 968         (WebTestRunner::WebTestProxy::didInvalidateRect):
 969         (WebTestRunner::WebTestProxy::didScrollRect):
 970         (WebTestRunner::WebTestProxy::scheduleComposite):
 971         (WebTestRunner::WebTestProxy::scheduleAnimation):
 972         (WebTestRunner::WebTestProxy::setWindowRect):
 973         (WebTestRunner::WebTestProxy::show):
 974         (WebTestRunner::WebTestProxy::didAutoResize):
 975         (WebTestRunner::WebTestProxy::postAccessibilityNotification):
 976         (WebTestRunner::WebTestProxy::startDragging):
 977         (WebTestRunner::WebTestProxy::shouldBeginEditing):
 978         (WebTestRunner::WebTestProxy::shouldEndEditing):
 979         (WebTestRunner::WebTestProxy::shouldInsertNode):
 980         (WebTestRunner::WebTestProxy::shouldInsertText):
 981         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
 982         (WebTestRunner::WebTestProxy::shouldDeleteRange):
 983         (WebTestRunner::WebTestProxy::shouldApplyStyle):
 984         (WebTestRunner::WebTestProxy::didBeginEditing):
 985         (WebTestRunner::WebTestProxy::didChangeSelection):
 986         (WebTestRunner::WebTestProxy::didChangeContents):
 987         (WebTestRunner::WebTestProxy::didEndEditing):
 988         (WebTestRunner::WebTestProxy::registerIntentService):
 989         (WebTestRunner::WebTestProxy::dispatchIntent):
 990         (WebTestRunner::WebTestProxy::willPerformClientRedirect):
 991         (WebTestRunner::WebTestProxy::didCancelClientRedirect):
 992         (WebTestRunner::WebTestProxy::didStartProvisionalLoad):
 993         (WebTestRunner::WebTestProxy::didReceiveServerRedirectForProvisionalLoad):
 994         (WebTestRunner::WebTestProxy::didFailProvisionalLoad):
 995         (WebTestRunner::WebTestProxy::didCommitProvisionalLoad):
 996         (WebTestRunner::WebTestProxy::didReceiveTitle):
 997         (WebTestRunner::WebTestProxy::didFinishDocumentLoad):
 998         (WebTestRunner::WebTestProxy::didHandleOnloadEvents):
 999         (WebTestRunner::WebTestProxy::didFailLoad):
1000         (WebTestRunner::WebTestProxy::didFinishLoad):
1001         (WebTestRunner::WebTestProxy::didChangeLocationWithinPage):
1002         (WebTestRunner::WebTestProxy::didDisplayInsecureContent):
1003         (WebTestRunner::WebTestProxy::didRunInsecureContent):
1004         (WebTestRunner::WebTestProxy::didDetectXSS):
1005         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1006         (WebTestRunner::WebTestRunner::setTestIsRunning):
1007         (WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
1008         (WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
1009         (WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
1010         (WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
1011         (WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
1012         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1013         (WebTestRunner::TestRunner::TestRunner):
1014         (WebTestRunner::TestRunner::reset):
1015         (WebTestRunner::TestRunner::setTestIsRunning):
1016         (WebTestRunner):
1017         (WebTestRunner::TestRunner::shouldDumpFrameLoadCallbacks):
1018         (WebTestRunner::TestRunner::setShouldDumpFrameLoadCallbacks):
1019         (WebTestRunner::TestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
1020         (WebTestRunner::TestRunner::stopProvisionalFrameLoads):
1021         (WebTestRunner::TestRunner::shouldDumpTitleChanges):
1022         (WebTestRunner::TestRunner::dumpFrameLoadCallbacks):
1023         (WebTestRunner::TestRunner::dumpUserGestureInFrameLoadCallbacks):
1024         (WebTestRunner::TestRunner::setStopProvisionalFrameLoads):
1025         (WebTestRunner::TestRunner::dumpTitleChanges):
1026         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1027         (TestRunner):
1028         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
1029         (WebTestInterfaces::Internal):
1030         (WebTestRunner::WebTestInterfaces::Internal::webView):
1031         (WebTestRunner::WebTestInterfaces::Internal::Internal):
1032         (WebTestRunner::WebTestInterfaces::Internal::setWebView):
1033         (WebTestRunner):
1034         (WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
1035         (WebTestRunner::WebTestInterfaces::setWebView):
1036         (WebTestRunner::WebTestInterfaces::setTestIsRunning):
1037         (WebTestRunner::WebTestInterfaces::webView):
1038         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
1039         (WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
1040         (WebTestRunner):
1041         (WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
1042         (WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
1043         (WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
1044         (WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
1045         (WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
1046         (WebTestRunner::WebTestProxyBase::didReceiveTitle):
1047         (WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
1048         (WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
1049         (WebTestRunner::WebTestProxyBase::didFailLoad):
1050         (WebTestRunner::WebTestProxyBase::didFinishLoad):
1051         (WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
1052         (WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
1053         (WebTestRunner::WebTestProxyBase::didRunInsecureContent):
1054         (WebTestRunner::WebTestProxyBase::didDetectXSS):
1055         * DumpRenderTree/chromium/TestShell.cpp:
1056         (TestShell::runFileTest):
1057         (TestShell::testFinished):
1058         * DumpRenderTree/chromium/TestShell.h:
1059         (TestShell):
1060         * DumpRenderTree/chromium/WebViewHost.cpp:
1061         (WebViewHost::didStartProvisionalLoad):
1062         (WebViewHost::didReceiveServerRedirectForProvisionalLoad):
1063         (WebViewHost::didFailProvisionalLoad):
1064         (WebViewHost::didCommitProvisionalLoad):
1065         (WebViewHost::didReceiveTitle):
1066         (WebViewHost::didFailLoad):
1067         (WebViewHost::didFinishLoad):
1068         * DumpRenderTree/chromium/WebViewHost.h:
1069         (WebViewHost):
1070
1071 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1072
1073         [GTK] Lower the default timeout value for WebKitTestRunner
1074         https://bugs.webkit.org/show_bug.cgi?id=106353
1075
1076         Reviewed by Dirk Pranke.
1077
1078         The default timeout value for WebKitTestRunner should be lowered.
1079         The current value (80 seconds) is irrational and just leads to producing
1080         text failures for layout tests that genuinely time out. This just leads
1081         to more deviation from the GTK WK1 port in terms of test expectations.
1082
1083         The value used is the same as when running the DumpRenderTree, that's
1084         6 seconds in release builds and 12 seconds in debug builds.
1085
1086         * Scripts/webkitpy/layout_tests/port/gtk.py:
1087         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1088         (GtkPortTest.test_default_timeout_ms):
1089
1090 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1091
1092         test-webkitpy shows failure output on my linux box
1093         https://bugs.webkit.org/show_bug.cgi?id=101261
1094
1095         Reviewed by Eric Seidel.
1096
1097         Mock out the PulseAudioSanitizer methods when creating testing instances
1098         of EflPort and GtkPort interfaces in unit tests. This stops throwing up
1099         PulseAudio output when the sanitizer was trying to unload modules which
1100         were already unloaded by another unit test that was being run in parallel.
1101
1102         * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
1103         (EflPortTest):
1104         (EflPortTest.make_port):
1105         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
1106         (GtkPortTest):
1107         (GtkPortTest.make_port):
1108
1109 2013-01-08  Julie Parent  <jparent@chromium.org>
1110
1111         Dashboard Cleanup: Remove g_hasDoneInitialPageGeneration
1112         https://bugs.webkit.org/show_bug.cgi?id=106254
1113
1114         Remove the global variable g_hasDoneInitialPageGeneration.  It was used
1115         only to figure out if we should call addBuilderLoadErrors during
1116         handleLocationChange, which was called when the loader completed and on
1117         any hash change, but we only ever wanted to call addBuilderLoadErrors
1118         on the initial loader load.  Moved the call of addBuilderLoadErrors to
1119         resourceLoadingComplete rather than handleLocationChange, so now we
1120         only call it when we want to, and the check can go away completely.
1121
1122         Reviewed by Dirk Pranke.
1123
1124         * TestResultServer/static-dashboards/dashboard_base.js:
1125         (addBuilderLoadErrors):
1126         (resourceLoadingComplete):
1127         (handleLocationChange):
1128         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
1129
1130 2013-01-08  Dominic Mazzoni  <dmazzoni@google.com>
1131
1132         Add aboxhall@chromium.org to accessibility watchlist.
1133
1134         Unreviewed.
1135
1136         * Scripts/webkitpy/common/config/watchlist:
1137
1138 2013-01-08  Dan Winship  <danw@gnome.org>
1139
1140         Add Apache 2.4 support for Fedora 18
1141         https://bugs.webkit.org/show_bug.cgi?id=104478
1142
1143         Reviewed by Martin Robinson.
1144
1145         Apache 2.4's httpd.conf is slightly incompatible with 2.2's, so we
1146         need a separate config.
1147
1148         * Scripts/webkitpy/layout_tests/port/base.py:
1149         (Port._apache_version):
1150         (Port._apache_config_file_name_for_platform):
1151         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
1152         * Scripts/run-webkit-httpd:
1153         * Scripts/webkitperl/httpd.pm:
1154         (getApacheVersion):
1155         (getDefaultConfigForTestDirectory):
1156         (getHTTPDConfigPathForTestDirectory):
1157
1158 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1159
1160         Make the override-feature-defines script compatible with Python v3
1161         https://bugs.webkit.org/show_bug.cgi?id=105742
1162
1163         Reviewed by Martin Robinson.
1164
1165         Instead of printing output through a statement, use the print function and format
1166         the output using the str.format method. This makes the script runnable with Python v3.
1167
1168         * gtk/override-feature-defines:
1169         (adjust_feature_defines_makefile):
1170
1171 2013-01-08  Heikki Paajanen  <heikki.paajanen@palm.com>
1172
1173         [Qt] Fix libxml2 config test
1174         https://bugs.webkit.org/show_bug.cgi?id=106317
1175
1176         Reviewed by Simon Hausmann.
1177
1178         Don't assume standard include/libxml2, libxml-2.0.pc should know
1179         where it's headers are.
1180
1181         * qmake/config.tests/libxml2/libxml2.cpp: Fix include
1182
1183 2013-01-08  Zan Dobersek  <zandobersek@gmail.com>
1184
1185         [GTK] Make Tools/gtk/generate-gtkdoc compatible with Python 3
1186         https://bugs.webkit.org/show_bug.cgi?id=106195
1187
1188         Reviewed by Philippe Normand.
1189
1190         Perform changes in the generate-gtkdoc script and common and gtkdoc modules
1191         to make the Python code compatible with Python 3. This includes modifying
1192         print statements, exception handling, dictionary iteration and
1193         byte-sequence-to-string conversion.
1194
1195         * gtk/common.py:
1196         (get_build_path):
1197         (pkg_config_file_variable):
1198         (gtk_version_of_pkg_config_file):
1199         * gtk/generate-gtkdoc:
1200         (print_missing_api):
1201         * gtk/gtkdoc.py:
1202         (GTKDoc.__init__):
1203         (GTKDoc._run_command):
1204
1205 2013-01-02  Steve Block  <steveblock@chromium.org>
1206
1207         Add chromium.org email address for Steve Block.
1208
1209         Unreviewed.
1210
1211         * Scripts/webkitpy/common/config/committers.py:
1212
1213 2013-01-07  Filip Pizlo  <fpizlo@apple.com>
1214
1215         Rationalize closure call heuristics and profiling
1216         https://bugs.webkit.org/show_bug.cgi?id=106270
1217
1218         Reviewed by Oliver Hunt.
1219
1220         Add ability to use display-profiler-output via a pipe, and add the ability to dump
1221         all generated code ('display *' or 'd *').
1222
1223         * Scripts/display-profiler-output:
1224
1225 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1226
1227         Sorted more xcodeproj files.
1228
1229         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1230         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1231         * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
1232
1233 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1234
1235         Sorted xcodeproj files.
1236
1237         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1238         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1239
1240 2013-01-07  Dan Bernstein  <mitz@apple.com>
1241
1242         [mac] WebKit1 clients can’t tell when a frame has been removed from the hierarchy
1243         https://bugs.webkit.org/show_bug.cgi?id=106261
1244
1245         Reviewed by Simon Fraser.
1246
1247         Added a test for -[WebFrameLoadDelegate webView:didRemoveFrameFromHierarchy:].
1248
1249         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1250         * TestWebKitAPI/Tests/mac/WebViewDidRemoveFrameFromHierarchy.mm: Added.
1251         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didFinishLoadForFrame:]):
1252         (-[DidRemoveFrameFromHierarchyFrameLoadDelegate webView:didRemoveFrameFromHierarchy:]):
1253         (TestWebKitAPI):
1254         (TestWebKitAPI::TEST):
1255
1256 2013-01-07  Ojan Vafai  <ojan@chromium.org>
1257
1258         Add the Apple MountainLion bots to garden-o-matic.
1259         Eventually, we really should move away from hardcoding
1260         the list of bots.
1261
1262         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
1263
1264 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1265
1266         [chromium] move web audio related methods to testrunner library
1267         https://bugs.webkit.org/show_bug.cgi?id=106211
1268
1269         Reviewed by Adam Barth.
1270
1271         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1272         (DRTTestRunner::DRTTestRunner):
1273         (DRTTestRunner::reset):
1274         * DumpRenderTree/chromium/DRTTestRunner.h:
1275         (DRTTestRunner):
1276         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1277         (WebKit):
1278         (WebTestRunner::WebTestRunner::shouldDumpAsAudio):
1279         (WebTestRunner::WebTestRunner::audioData):
1280         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1281         (WebTestRunner::TestRunner::TestRunner):
1282         (WebTestRunner::TestRunner::reset):
1283         (WebTestRunner::TestRunner::shouldDumpAsAudio):
1284         (WebTestRunner):
1285         (WebTestRunner::TestRunner::audioData):
1286         (WebTestRunner::TestRunner::setAudioData):
1287         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1288         (TestRunner):
1289         * DumpRenderTree/chromium/TestShell.cpp:
1290         (TestShell::dump):
1291
1292 2013-01-07  Mike West  <mkwst@chromium.org>
1293
1294         Make the IFRAME_SEAMLESS flag runtime-enabled.
1295         https://bugs.webkit.org/show_bug.cgi?id=106213
1296
1297         Reviewed by Ojan Vafai.
1298
1299         * DumpRenderTree/chromium/TestShell.cpp:
1300         (TestShell::TestShell):
1301         * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
1302         (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
1303         * DumpRenderTree/gtk/DumpRenderTree.cpp:
1304         (resetDefaultsToConsistentValues):
1305         * DumpRenderTree/mac/DumpRenderTree.mm:
1306         (resetDefaultsToConsistentValues):
1307         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
1308         (WebCore::WebPage::resetSettings):
1309         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1310         (WTR::InjectedBundle::beginTesting):
1311             Ensure that seamless IFrames are enabled for layout tests in each of
1312             the ports that support seamless IFrames.
1313
1314 2013-01-07  Jochen Eisinger  <jochen@chromium.org>
1315
1316         [chromium] move dumpAsText and friends to the TestRunner library
1317         https://bugs.webkit.org/show_bug.cgi?id=106222
1318
1319         Reviewed by Adam Barth.
1320
1321         This moves dumpAsText, dumpChildFramesAsText, and dumpChildFrameScrollPositions to the TestRunner library.
1322
1323         * DumpRenderTree/chromium/DRTTestRunner.cpp:
1324         (DRTTestRunner::DRTTestRunner):
1325         (DRTTestRunner::reset):
1326         * DumpRenderTree/chromium/DRTTestRunner.h:
1327         (DRTTestRunner):
1328         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
1329         (WebTestRunner::WebTestRunner::shouldDumpAsText):
1330         (WebTestRunner::WebTestRunner::setShouldDumpAsText):
1331         (WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
1332         (WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
1333         (WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
1334         (WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
1335         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1336         (WebTestRunner::TestRunner::TestRunner):
1337         (WebTestRunner::TestRunner::reset):
1338         (WebTestRunner::TestRunner::shouldDumpAsText):
1339         (WebTestRunner):
1340         (WebTestRunner::TestRunner::setShouldDumpAsText):
1341         (WebTestRunner::TestRunner::shouldGeneratePixelResults):
1342         (WebTestRunner::TestRunner::setShouldGeneratePixelResults):
1343         (WebTestRunner::TestRunner::shouldDumpChildFrameScrollPositions):
1344         (WebTestRunner::TestRunner::shouldDumpChildFramesAsText):
1345         (WebTestRunner::TestRunner::dumpAsText):
1346         (WebTestRunner::TestRunner::dumpChildFrameScrollPositions):
1347         (WebTestRunner::TestRunner::dumpChildFramesAsText):
1348         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1349         (TestRunner):
1350
1351 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1352
1353         Build fix attempt after r138810.
1354
1355         Apparently python 2.6 is really bad at floating point computation.
1356
1357         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1358         (MainTest.test_run_memory_test):
1359
1360 2013-01-07  Ryosuke Niwa  <rniwa@webkit.org>
1361
1362         Extract a class to represent a test result to simplify PerfTest.parse_output and PageLoadPerfTest._run_with_driver
1363         https://bugs.webkit.org/show_bug.cgi?id=106172
1364
1365         Reviewed by Tony Chang.
1366
1367         Extracted PerfTestMetric, which represents a test result and knows how to compute statistics and convert itself
1368         to a dictionary. A metric is a type of measurement each test makes such as "Time", "Malloc", and "JSHeap".
1369         A single test (e.g. html5-full-render.html) may have multiple metrics, each of which is reported as a separate
1370         test on perf-o-matic and perf. test's results page.
1371
1372         Also, use python's compute_statistics instead of reading statistics off of DriverOutput to simplify the code.
1373
1374         * Scripts/webkitpy/performance_tests/perftest.py:
1375         (PerfTestMetric): Added.
1376         (PerfTestMetric.__init__): Added.
1377         (PerfTestMetric.metric): Added.
1378         (PerfTestMetric.has_values): Added.
1379         (PerfTestMetric.legacy_chromium_bot_compatible_test_name): Added. Following the legacy convention, "Malloc" and
1380         "JSHeap" will use "test_name:Malloc" whereas "Time" uses "test_name" itself. We should eventually move these
1381         conversions to be done on the client side (perf-o-matic and results page).
1382         (PerfTestMetric.append): Added.
1383         (PerfTestMetric.to_dict): Added. Computes the statistics and generates the dictionary object that represents
1384         a result for this metric.
1385         (PerfTestMetric.metric_to_unit): Added. Each metric maps to exactly one unit (it's not one-to-one).
1386         (PerfTestMetric.compute_statistics): Moved from PerfTest.
1387
1388         (PerfTest._create_driver): Extracted from PerfTest.run.
1389         (PerfTest.run): Given an array of PerfTestMetric, generate the results dictionary. Also print out results
1390         as needed.
1391         (PerfTest._run_with_driver):
1392         (PerfTest): Removed _result_classes and _result_class_regex. "result class" is the old name for "metric".
1393         (PerfTest.parse_output): Dramatically simplified. We now just return an array of PerfTestMetric's. Also ignore
1394         all keys except "values". We rely on PerfTestMetric to compute the statistics for us.
1395
1396         (ChromiumStylePerfTest.run): Added and merged _run_with_driver. Since chromium style perf tests are so different
1397         from other perf tests, there isn't much point in sharing the code here.
1398
1399         (PageLoadingPerfTest._run_with_driver): Simplified. Just create an array of PerfTestMetric's without computing
1400         statistics for the measured values.
1401
1402         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1403         (TestPerfTestMetric): Added.
1404         (TestPerfTestMetric.test_init_set_missing_unit): Added.
1405         (TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name): Added.
1406         (TestPerfTestMetric.test_has_values): Added.
1407         (TestPerfTestMetric.test_append): Added.
1408         (TestPerfTestMetric.test_compute_statistics.compute_statistics):
1409         (TestPerfTestMetric.test_compute_statistics): Added a trivial test case.
1410
1411         (TestPerfTest._assert_results_are_correct): Updated as needed.
1412         (TestPageLoadingPerfTest.test_run): Ditto. Notice that we no longer log anything in _run_with_driver. It's done
1413         in PerfTest.run now after generating the results dictionary.
1414         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto.
1415
1416 2013-01-07  Julien Chaffraix  <jchaffraix@webkit.org>
1417
1418         Support size_t multiplication and division operators on LayoutUnit
1419         https://bugs.webkit.org/show_bug.cgi?id=83848
1420
1421         Reviewed by Emil A Eklund.
1422
1423         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1424         Added some simple tests for the new operators using size_t.
1425
1426 2013-01-07  Csaba Osztrogonác  <ossy@webkit.org>
1427
1428         [Qt] run-webkit-tests cleanup for parallel NRWT
1429         https://bugs.webkit.org/show_bug.cgi?id=106220
1430
1431         Reviewed by Dirk Pranke.
1432
1433         * Scripts/run-webkit-tests:
1434         (useNewRunWebKitTests):
1435         * Scripts/webkitpy/layout_tests/port/qt.py:
1436         (QtPort):
1437         (QtPort.default_child_processes):
1438
1439 2013-01-07  Philippe Normand  <pnormand@igalia.com>
1440
1441         Create a GStreamerAudio watchlist and add myself to it.
1442
1443         Unreviewed.
1444
1445         * Scripts/webkitpy/common/config/watchlist:
1446
1447 2013-01-05  Ryosuke Niwa  <rniwa@webkit.org>
1448
1449         Add svn:executable to a bunch of scripts in BuildSlaveSupport.
1450         Also removed the empty mac directory.
1451
1452         * BuildSlaveSupport/built-product-archive: Added property svn:executable.
1453         * BuildSlaveSupport/download-built-product: Added property svn:executable.
1454         * BuildSlaveSupport/mac: Removed.
1455         * BuildSlaveSupport/test-result-archive: Added property svn:executable.
1456
1457 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1458
1459         Add a script to delete stale zero-byte build files
1460         https://bugs.webkit.org/show_bug.cgi?id=106131
1461
1462         Reviewed by Tony Chang.
1463
1464         Delete zero-byte build files on Mac port for now. It doesn't do anything on other ports.
1465
1466         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1467         (DeleteStaleBuildFiles): Added.
1468         (Factory.__init__): Add DeleteStaleBuildFiles step.
1469         * BuildSlaveSupport/delete-stale-build-files: Added.
1470         (main): Delete zero-byte files except ones intentionally generated by our build process.
1471         (webkitBuildDirectory): Copied from build-product-archive.
1472
1473 2013-01-04  Michael Pruett  <michael@68k.org>
1474
1475         [GTK] Fix build error on GTK due to r138836
1476         https://bugs.webkit.org/show_bug.cgi?id=106154
1477
1478         Reviewed by Kentaro Hara.
1479
1480         * GNUmakefile.am:
1481
1482 2013-01-04  Dan Bernstein  <mitz@apple.com>
1483
1484         [mac] WebKit1 has no equivalent of WKBundleNodeHandleCopyHTMLTableCellElementCellAbove
1485         https://bugs.webkit.org/show_bug.cgi?id=106121
1486
1487         Reviewed by Adele Peterson.
1488
1489         Added test for -[DOMTHMLTableCellElement _cellAbove].
1490
1491         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1492         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm: Added.
1493         (-[HTMLTableCellElementCellAboveTest webView:didFinishLoadForFrame:]):
1494         (TestWebKitAPI):
1495         (TestWebKitAPI::expectCellAboveCell):
1496         (TestWebKitAPI::TEST):
1497         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellElementCellAbove.html: Added.
1498
1499 2013-01-04  Eric Seidel  <eric@webkit.org>
1500
1501         FlakyTestReporter should be re-enabled and taught how to post patches
1502         https://bugs.webkit.org/show_bug.cgi?id=103839
1503
1504         Reviewed by Adam Barth.
1505
1506         This moves LayoutTestResultsReader off of the DeprecatedPort object.
1507         It also adds a real Port object to the EWS and CommitQueue objects
1508         using a new PatchProcessingQueue superclass.
1509         PatchProcessingQueue doesn't seem to be the cleanest insertion point
1510         but works for this purpose.
1511         I also moved _upload_results_archive_for_patch into PatchProcessingQueue
1512         to resolve a FIXME.
1513
1514         This required some hacks/shiming between the non-specific "old"
1515         port names which the EWS system is currently using, and the new
1516         port objects.  This shimming is done in PatchProcessingQueue._new_port_name_from_old.
1517
1518         Hopefully this will fix the flaky test reporter and results uploading.
1519         Certainly it's another small step towards getting rid of the old ports.py
1520         infrastructure and making the NRWT Port class common webkitpy infrastructure.
1521
1522         Now that DeprecatedPort is no longer used for the results directory
1523         I removed all the explicit results-dir code which webkit-patch was using
1524         in --non-interactive mode to tell NRWT to use a results-dir it understood. :)
1525
1526         * Scripts/webkitpy/common/config/ports.py:
1527         (DeprecatedPort.run_perl_unittests_command):
1528         * Scripts/webkitpy/common/config/ports_mock.py:
1529         (MockPort.name):
1530         * Scripts/webkitpy/common/system/outputcapture.py:
1531         (OutputCapture.assert_outputs):
1532         * Scripts/webkitpy/layout_tests/port/apple.py:
1533         (ApplePort.determine_full_port_name):
1534         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1535         (LayoutTestResultsReader.__init__):
1536         (LayoutTestResultsReader):
1537         (LayoutTestResultsReader._read_file_contents):
1538         (LayoutTestResultsReader._create_layout_test_results):
1539         (LayoutTestResultsReader._create_unit_test_results):
1540         (LayoutTestResultsReader.results):
1541         (LayoutTestResultsReader.archive):
1542         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1543         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
1544         (LayoutTestResultsReaderTest.test_create_unit_test_results):
1545         (test_missing_unit_test_results_path):
1546         (test_layout_test_results):
1547         (test_archive_last_layout_test_results):
1548         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
1549         (AbstractEarlyWarningSystem):
1550         (AbstractEarlyWarningSystem.__init__):
1551         (AbstractEarlyWarningSystem.begin_work_queue):
1552         (AbstractEarlyWarningSystem.run_command):
1553         * Scripts/webkitpy/tool/commands/queues.py:
1554         (AbstractPatchQueue.work_item_log_path):
1555         (PatchProcessingQueue):
1556         (PatchProcessingQueue._new_port_name_from_old):
1557         (PatchProcessingQueue.begin_work_queue):
1558         (PatchProcessingQueue._upload_results_archive_for_patch):
1559         (CommitQueue):
1560         (CommitQueue.begin_work_queue):
1561         (CommitQueue.run_command):
1562         (AbstractReviewQueue):
1563         (AbstractReviewQueue.__init__):
1564         (AbstractReviewQueue.begin_work_queue):
1565         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1566         (AbstractPatchQueueTest.test_next_patch):
1567         (PatchProcessingQueueTest):
1568         (PatchProcessingQueueTest.test_upload_results_archive_for_patch):
1569         * Scripts/webkitpy/tool/steps/runtests.py:
1570         (RunTests.run):
1571         * Scripts/webkitpy/tool/steps/runtests_unittest.py:
1572
1573 2013-01-04  Dana Jansens  <danakj@chromium.org>
1574
1575         [chromium] Remove lost-compositor-context layout tests
1576         https://bugs.webkit.org/show_bug.cgi?id=106089
1577
1578         Reviewed by James Robinson.
1579
1580         Remove the loseCompositorContext() test function.
1581
1582         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
1583         (WebTestRunner::TestRunner::TestRunner):
1584         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
1585         (TestRunner):
1586
1587 2013-01-04  Adam Klein  <adamk@chromium.org>
1588
1589         Remove ENABLE_MUTATION_OBSERVERS #define
1590         https://bugs.webkit.org/show_bug.cgi?id=105459
1591
1592         Reviewed by Ryosuke Niwa.
1593
1594         * Scripts/webkitperl/FeatureList.pm:
1595         * qmake/mkspecs/features/features.pri:
1596
1597 2013-01-04  Ryosuke Niwa  <rniwa@webkit.org>
1598
1599         Statistics used in perftest_unittest.py and perftest_integrationtest.py are bogus
1600         https://bugs.webkit.org/show_bug.cgi?id=106078
1601
1602         Reviewed by Tony Chang.
1603
1604         This patch updates values for individual iterations in dummy performance tests used in
1605         perftest_unittest.py and perftest_integrationtest.py so that they match up with
1606         statistics such as stdev and median reported in those tests. This change is required
1607         to resolve the bug 97510.
1608
1609         This patch also refactors integration tests by extracting *TestData classes that
1610         centralizes the definitions of each dummy performance test's text (DRT output),
1611         runner output, and parsed results (JSON) so that we may share more data between
1612         python tests.
1613
1614         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1615         (MainTest._assert_results_are_correct): Extracted from test_parse_output.
1616         Use self.assertAlmostEqual when comparing the standard deviation.
1617         (MainTest.test_parse_output):
1618         (test_parse_output_with_failing_line):
1619         (test_parse_output_with_description): Use _assert_results_are_correct.
1620         (test_parse_output_with_subtests): Ditto.
1621
1622         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
1623         (InspectorPassTestData): Extracted from tests below.
1624         (EventTargetWrapperTestData): Ditto.
1625         (SomeParserTestData): Ditto.
1626         (MemoryTestData): Ditto.
1627         (TestDriver.run_test): Moved test definitions out of the method.
1628         (MainTest._normalize_output): Truncate standard deviations at 5th decimal point.
1629         (MainTest._load_output_json): Extracted from create_runner.
1630         (MainTest.create_runner):
1631         (MainTest.test_run_test_set_for_parser_tests):
1632         (MainTest.test_run_memory_test):
1633         (MainTest._test_run_with_json_output):
1634         (MainTest.test_run_with_json_output):
1635         (MainTest.test_run_with_description):
1636         (MainTest.test_run_generates_json_by_default):
1637         (MainTest.test_run_merges_output_by_default):
1638         (MainTest.test_run_respects_reset_results):
1639         (MainTest.test_run_generates_and_show_results_page):
1640         (MainTest.test_run_with_slave_config_json):
1641         (MainTest.test_run_with_multiple_repositories):
1642
1643 2013-01-04  Martin Robinson  <mrobinson@igalia.com>
1644
1645         [GTK] [WebKit2] Clicking on a word that is selected in an editable area deletes it
1646         https://bugs.webkit.org/show_bug.cgi?id=106045
1647
1648         Reviewed by Carlos Garcia Campos.
1649
1650         Update test results to confirm that compositions without preedits do not trigger
1651         a composition confirmation.
1652
1653         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
1654         (TestWebKitAPI::verifyCanceledComposition):
1655
1656 2013-01-04  Sailesh Agrawal  <sail@chromium.org>
1657
1658         [Mac] [WK2] platform/mac/fast/events/numpad-keycode-mapping.html fails
1659         https://bugs.webkit.org/show_bug.cgi?id=105958
1660
1661         Reviewed by Alexey Proskuryakov.
1662
1663         Ported code from DumpRenderTree to WebKitTestRunner to map all numpad keys.
1664
1665         * WebKitTestRunner/mac/EventSenderProxy.mm:
1666         (KeyMappingEntry):
1667         (WTR):
1668         (WTR::EventSenderProxy::keyDown): Added all numpad keys.
1669
1670 2013-01-03  Chris Fleizach  <cfleizach@apple.com>
1671
1672         REGRESSION: [Mac] Intermittent crash in WTR::AccessibilityUIElement::isEqual
1673         https://bugs.webkit.org/show_bug.cgi?id=106073
1674
1675         Reviewed by Ryosuke Niwa.
1676
1677         Check that the element being compared to is not nil.
1678         This crash is happening because one of the accessibility tests does an isEqual comparison within a callback function.
1679         It looks like occasionally, one of the elements passed in to the isEqual is nil because the notification handler is on the accessibility
1680         controller, and the notification is being delivered after the document objects are cleared. This shouldn't happen but I've seen it
1681         sometimes before on parallel WebKitTestRunner runs.
1682
1683         * DumpRenderTree/AccessibilityUIElement.cpp:
1684         (AccessibilityUIElement::isEqual):
1685         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1686         (WTR::AccessibilityUIElement::isEqual):
1687
1688 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1689
1690         Downloads can be flaky, so try downloading multiple times.
1691         https://bugs.webkit.org/show_bug.cgi?id=105976
1692
1693         Reviewed by Eric Seidel.
1694
1695         * Scripts/webkitpy/common/system/autoinstall.py:
1696         (AutoInstaller._download_to_stream):
1697
1698 2013-01-03  Eric Seidel  <eric@webkit.org>
1699
1700         Rename Tool.port to deprecated_port in preparation for removing more callers
1701         https://bugs.webkit.org/show_bug.cgi?id=106076
1702
1703         Reviewed by Ryosuke Niwa.
1704
1705         This resolves a long-standing FIXME to rename this method. :)
1706
1707         * Scripts/webkitpy/tool/bot/botinfo.py:
1708         (BotInfo.summary_text):
1709         * Scripts/webkitpy/tool/bot/irc_command.py:
1710         (Rollout._update_working_copy):
1711         * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
1712         (LayoutTestResultsReader._create_layout_test_results):
1713         (LayoutTestResultsReader._create_unit_test_results):
1714         (LayoutTestResultsReader._results_directory):
1715         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
1716         (test_missing_unit_test_results_path):
1717         * Scripts/webkitpy/tool/main.py:
1718         (WebKitPatch.deprecated_port):
1719         * Scripts/webkitpy/tool/mocktool.py:
1720         (MockTool.deprecated_port):
1721         * Scripts/webkitpy/tool/steps/build.py:
1722         (Build.build):
1723         * Scripts/webkitpy/tool/steps/checkstyle.py:
1724         (CheckStyle.run):
1725         * Scripts/webkitpy/tool/steps/commit.py:
1726         (Commit._check_test_expectations):
1727         * Scripts/webkitpy/tool/steps/preparechangelog.py:
1728         (PrepareChangeLog.run):
1729         * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
1730         (PrepareChangeLogForDEPSRoll.run):
1731         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1732         (PrepareChangeLogForRevert.run):
1733         * Scripts/webkitpy/tool/steps/runtests.py:
1734         (RunTests.run):
1735         * Scripts/webkitpy/tool/steps/steps_unittest.py:
1736         (StepsTest.test_runtests_args):
1737         * Scripts/webkitpy/tool/steps/update.py:
1738         (Update._update_command):
1739
1740 2013-01-03  Eric Seidel  <eric@webkit.org>
1741
1742         Add myself to the webkitpy watchlist.
1743
1744         Unreviewed.
1745
1746         * Scripts/webkitpy/common/config/watchlist:
1747
1748 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1749
1750         Cleanup perftest* tests and add a test for computing statistics
1751         https://bugs.webkit.org/show_bug.cgi?id=105685
1752
1753         Reviewed by Eric Seidel.
1754
1755         Add a test for PerfTest.compute_statistics (moved and renamed from PageLoadingPerfTest.calculate_statistics) and
1756         extracted perftestsrunner_itegrationtests.py from perftestsrunner_unittests.py.
1757
1758         Also fixed a bug in compute_statistics that the mean ('avg') value can have a large rounding errors in some cases.
1759
1760         * Scripts/webkitpy/performance_tests/perftest.py:
1761         (PerfTest.compute_statistics): Moved from PageLoadingPerfTest to prepare for the bug 97510. Also compute the mean
1762         directly from sorted_values instead of using the one from Knuth's online algorithm. This approach gives more
1763         accurate result for the mean.
1764         (PageLoadingPerfTest.run_single):
1765         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
1766         (MainTest.test_compute_statistics):
1767         (MainTest.test_compute_statistics.compute_statistics): Added.
1768         (TestPageLoadingPerfTest.test_run): floatify values.
1769         (TestPageLoadingPerfTest.test_run_with_memory_output): Ditto. Also got rid of ".0" from mean values now that Python
1770         correctly recognizes them as integers.
1771
1772         * Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py: Copied from
1773         Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py.
1774         (TestDriver): Moved out of MainTest.
1775         (MainTest): Got rid of assertWritten and all unit tests.
1776         (MainTest._normalize_output): Renamed from normalizeFinishedTime to match the PEP8 naming convention.
1777         (MainTest.test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
1778         (MainTest.test_run_test_set_for_parser_tests):
1779         (MainTest.test_run_memory_test):
1780         (MainTest._test_run_with_json_output):
1781         (MainTest.test_run_generates_json_by_default):
1782         (MainTest.test_run_merges_output_by_default):
1783         (MainTest.test_run_respects_reset_results):
1784         (MainTest.test_run_generates_and_show_results_page): Use runner.load_output_json() instead of manually loading and
1785         parsing output JSON files. Just verify that the output path is correct instead.
1786         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1787         (MainTest): Removed all integration tests.
1788         (MainTest.create_runner): Simplified.
1789
1790 2013-01-03  Julie Parent  <jparent@chromium.org>
1791
1792         Dashboard cleanup: remove usage of global g_defaultBuilderName
1793         https://bugs.webkit.org/show_bug.cgi?id=106043
1794
1795         Use now public defaultBuilder() from the BuilderGroup, rather
1796         than global variable.
1797
1798         Also eliminates the setup() and initBuilders() functions since we
1799         no longer need to track the global.
1800
1801         Reviewed by Adam Barth.
1802
1803         * TestResultServer/static-dashboards/builders.js:
1804         (BuilderGroup.prototype.defaultBuilder):
1805         (BuilderGroup.prototype.master):
1806         * TestResultServer/static-dashboards/dashboard_base.js:
1807         (parseParameters):
1808         * TestResultServer/static-dashboards/flakiness_dashboard.js:
1809         (updateDefaultBuilderState):
1810         * TestResultServer/static-dashboards/loader.js:
1811         (.):
1812         * TestResultServer/static-dashboards/loader_unittests.js:
1813
1814 2013-01-03  Ryosuke Niwa  <rniwa@webkit.org>
1815
1816         Disable an intermittently failing unit test for now.
1817         The failure is tracked by the bug 106051.
1818
1819         * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
1820         (TestWebKitAPI::TEST):
1821
1822 2013-01-03  Dan Bernstein  <mitz@apple.com>
1823
1824         No way to obtain a DOMNode given a JS wrapper for a Node
1825         https://bugs.webkit.org/show_bug.cgi?id=106033
1826
1827         Added a test for +[DOMNode _nodeFromJSWrapper:].
1828
1829         Reviewed by Sam Weinig.
1830
1831         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1832         * TestWebKitAPI/Tests/mac/DOMNodeFromJSObject.mm: Added.
1833         (TestWebKitAPI):
1834         (TestWebKitAPI::TEST):
1835
1836 2013-01-03  Emil A Eklund  <eae@chromium.org>
1837
1838         Fix overflow in LayoutUnit::ceil and floor for SATURATED_LAYOUT_ARITHMETIC
1839         https://bugs.webkit.org/show_bug.cgi?id=105961
1840
1841         Reviewed by Levi Weintraub.
1842
1843         Add tests for LayoutUnit::ceil and floor.
1844
1845         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1846         (TestWebKitAPI::TEST):
1847         (TestWebKitAPI):
1848
1849 2013-01-03  Julie Parent  <jparent@chromium.org>
1850
1851         Add unit test for default builder for the dashboards.
1852         https://bugs.webkit.org/show_bug.cgi?id=105972
1853
1854         Reviewed by Dirk Pranke.
1855
1856         * TestResultServer/static-dashboards/loader_unittests.js:
1857
1858 2013-01-03  Tony Chang  <tony@chromium.org>
1859
1860         Generate internal.settings from Settings.in
1861         https://bugs.webkit.org/show_bug.cgi?id=104740
1862
1863         Reviewed by Adam Barth.
1864
1865         * GNUmakefile.am: Compile new generated files on GTK+.
1866         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1867         with both extra_sources and add_output_to_sources=false will still
1868         compile the files in extra_sources. This makes it possible to compile
1869         InternalSettingsGenerated.cpp and not be confused by
1870         InternalSettingsGenerated.idl.
1871
1872 2013-01-03  Zan Dobersek  <zandobersek@gmail.com>
1873
1874         [style] WebIDL-reflecting uppercase enums reported as style violation
1875         https://bugs.webkit.org/show_bug.cgi?id=105832
1876
1877         Reviewed by Tony Chang.
1878
1879         Recognize the enum as WebIDL-reflecting one if there's a comment present that
1880         indicates this. In enums spanning over multiple lines, the comment is expected
1881         on the first line. In enums placed in one line, the comment is expected at the
1882         end of that line.
1883
1884         WebIDL-reflecting enum values are required to be written in uppercase and as such
1885         violate the common rule of these values being written in InterCaps. Annotating
1886         enums this way makes it possible to avoid false style violation reports.
1887
1888         The comment is of form '// Web(?:Kit)?IDL enum'.
1889
1890         * Scripts/webkitpy/style/checkers/cpp.py:
1891         (_EnumState.__init__):
1892         (_EnumState.process_clean_line):
1893         (check_enum_casing):
1894         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1895         (NoNonVirtualDestructorsTest.test_enum_casing):
1896
1897 2013-01-03  Tim 'mithro' Ansell  <mithro@mithis.com>
1898
1899         Adding favicon.ico to the garden-o-matic.
1900         https://bugs.webkit.org/show_bug.cgi?id=105982
1901
1902         Reviewed by Adam Barth.
1903
1904         * Scripts/webkitpy/tool/servers/gardeningserver.py:
1905         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon.ico:
1906
1907 2013-01-03  Jonathan Liu  <net147@gmail.com>
1908
1909         [Qt] Fix library linking order
1910         https://bugs.webkit.org/show_bug.cgi?id=105818
1911
1912         Some Qt libraries are linked before the private static libraries
1913         that depend on them which results in QtWebKit failing to link.
1914
1915         Copy Qt module dependencies from QT to QT_PRIVATE when creating
1916         module to ensure the Qt libraries are linked after the private
1917         static libraries that depend on them.
1918
1919         Reviewed by Tor Arne Vestbø.
1920
1921         * qmake/mkspecs/features/default_post.prf:
1922
1923 2013-01-02  Byungwoo Lee  <bw80.lee@samsung.com>
1924
1925         [EFL][WK2] Fix tooltip bugs in MiniBrowser.
1926         https://bugs.webkit.org/show_bug.cgi?id=102209
1927
1928         Reviewed by Gyuyoung Kim.
1929
1930         Set tooltip on the elm_window instead of ewk_view, and add delay to
1931         show the tooltip window.
1932
1933         Setting tooltip on the ewk_view makes elementary error message because
1934         ewk_view is not an elementary widget. To remove the error message,
1935         tooltip should be set on the elm_window.
1936
1937         Most browsers show the tooltip after a mouse pointer stays on an
1938         element object that has tooltip text.
1939         But elm_tooltip widget itself doesn't have delay or handle mouse
1940         events to show/hide.
1941
1942         So additional codes are added to show/hide tooltip widget along with
1943         mouse events.
1944           1) When a mouse pointer stays for a second on an element which has
1945              tooltip text, then tooltip widget is displayed.
1946           2) When a mouse pointer is moved or out of ewk_view, hide the tooltip
1947              widget.
1948
1949         * MiniBrowser/efl/main.c:
1950         (_Tooltip_Information):
1951         (_Browser_Window):
1952         (on_tooltip_show):
1953         (window_tooltip_hide):
1954         (window_tooltip_update):
1955         (on_mouse_in):
1956         (on_mouse_move):
1957         (on_mouse_out):
1958         (window_free):
1959         (on_tooltip_text_set):
1960         (on_tooltip_text_unset):
1961         (window_create):
1962
1963 2013-01-02  Tony Chang  <tony@chromium.org>
1964
1965         Unreviewed, rolling out r138661.
1966         http://trac.webkit.org/changeset/138661
1967         https://bugs.webkit.org/show_bug.cgi?id=104740
1968
1969         Compile problems on EFL
1970
1971         * GNUmakefile.am:
1972         * qmake/mkspecs/features/default_post.prf:
1973
1974 2013-01-02  Tony Chang  <tony@chromium.org>
1975
1976         Generate internal.settings from Settings.in
1977         https://bugs.webkit.org/show_bug.cgi?id=104740
1978
1979         Reviewed by Adam Barth.
1980
1981         * GNUmakefile.am: Compile new generated files on GTK+.
1982         * qmake/mkspecs/features/default_post.prf: Qt: Make it so an action
1983         with both extra_sources and add_output_to_sources=false will still
1984         compile the files in extra_sources. This makes it possible to compile
1985         InternalSettingsGenerated.cpp and not be confused by
1986         InternalSettingsGenerated.idl.
1987
1988 2013-01-02  Adam Barth  <abarth@webkit.org>
1989
1990         Remove old-run-webkit-tests support from webkitpy
1991         https://bugs.webkit.org/show_bug.cgi?id=105619
1992
1993         Reviewed by Eric Seidel.
1994
1995         This patch removes support for webkitpy parsing the
1996         old-run-webkit-tests results format. There doesn't seem to be any
1997         reason to keep this code around anymore now that most bots have
1998         switched to new-run-webkit-tests.
1999
2000         * Scripts/webkitpy/common/net/buildbot/buildbot.py:
2001         (Builder.fetch_layout_test_results):
2002         * Scripts/webkitpy/common/net/layouttestresults.py:
2003         (path_for_layout_test):
2004         (LayoutTestResults.results_from_string):
2005         (LayoutTestResults):
2006         * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
2007         (LayoutTestResultsTest.test_results_from_string):
2008         * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
2009         (test_flaky_test_failure):
2010         * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
2011         (LayoutTestResultsReaderTest.test_missing_layout_test_results):
2012         * Scripts/webkitpy/tool/bot/patchanalysistask.py:
2013         (PatchAnalysisTask._test_patch):
2014         * Scripts/webkitpy/tool/commands/queuestest.py:
2015         (QueuesTest.assert_queue_outputs):
2016
2017 2013-01-02  Heikki Paajanen  <heikki.paajanen@palm.com>
2018
2019         [Qt][WK2] Add simple UI to find text from page
2020         https://bugs.webkit.org/show_bug.cgi?id=96481
2021
2022         Reviewed by Jocelyn Turcotte.
2023
2024         Find bar that slides between navigation bar and WebView.
2025
2026         * MiniBrowser/qt/BrowserWindow.cpp:
2027         (BrowserWindow::toggleFind):
2028         * MiniBrowser/qt/BrowserWindow.h:
2029         (BrowserWindow):
2030         * MiniBrowser/qt/MiniBrowser.qrc:
2031         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2032         (MiniBrowserApplication::notify):
2033         * MiniBrowser/qt/icons/find.png: Added.
2034         * MiniBrowser/qt/qml/BrowserWindow.qml:
2035
2036 2013-01-02  Christophe Dumez  <christophe.dumez@intel.com>
2037
2038         Regression(r138603): Caused 2 webkitpy tests to fail
2039         https://bugs.webkit.org/show_bug.cgi?id=105913
2040
2041         Reviewed by Kentaro Hara.
2042
2043         Fix 2 webkitpy tests that started to fail after
2044         r138603.
2045
2046         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2047         (IRCCommandTest._sheriff_test_data_url): Make sure the
2048         returned test file URL is valid no matter what the
2049         current working directory is.
2050         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
2051         (IRCBotTest.test_help): Add "sheriffs" command to the
2052         list of available commands.
2053
2054 2013-01-01  Christophe Dumez  <christophe.dumez@intel.com>
2055
2056         [WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
2057         https://bugs.webkit.org/show_bug.cgi?id=105897
2058
2059         Reviewed by Alexey Proskuryakov.
2060
2061         Dump in WebKitTestRunner the message that is expected by layout tests
2062         when the missing plugin button is clicked.
2063
2064         * WebKitTestRunner/TestController.cpp:
2065         (WTR::TestController::createWebViewWithOptions):
2066         (WTR::TestController::unavailablePluginButtonClicked):
2067         (WTR):
2068         * WebKitTestRunner/TestController.h:
2069         (TestController):
2070
2071 2013-01-01  KwangYong Choi  <ky0.choi@samsung.com>
2072
2073         [EFL] Enable MHTML feature
2074         https://bugs.webkit.org/show_bug.cgi?id=105815
2075
2076         Reviewed by Laszlo Gombos.
2077
2078         Enable MHTML feature for EFL port by default.
2079
2080         * Scripts/webkitperl/FeatureList.pm:
2081
2082 2013-01-01  Alan Cutter  <alancutter@chromium.org>
2083
2084         sheriff-bot should know who the gardeners/sheriffs are
2085         https://bugs.webkit.org/show_bug.cgi?id=105698
2086
2087         Reviewed by Eric Seidel.
2088
2089         Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.
2090
2091         * Scripts/webkitpy/tool/bot/irc_command.py:
2092         (Current):
2093         (Current._retrieve_webkit_sheriffs):
2094         (Current.execute):
2095         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2096         (IRCCommandTest.test_current):
2097         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
2098         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
2099         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
2100         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
2101         * Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
2102
2103 2012-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
2104
2105         [GTK] Move ImageDiff to the Tools directory root
2106         https://bugs.webkit.org/show_bug.cgi?id=105421
2107
2108         Reviewed by Kenneth Rohde Christiansen.
2109
2110         * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
2111         * GNUmakefile.am:
2112         * ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
2113
2114 2012-12-30  Mike West  <mkwst@chromium.org>
2115
2116         Add myself to watchlists for CSP and console logs.
2117         https://bugs.webkit.org/show_bug.cgi?id=105874
2118
2119         Reviewed by Dirk Pranke.
2120
2121         Because I really, really, really need more email.
2122
2123         * Scripts/webkitpy/common/config/committers.py:
2124             Add mkwst+watchlist@chromium.org as a contributor.
2125         * Scripts/webkitpy/common/config/watchlist:
2126             Create watchlist categories for 1) the various mechanisms used to
2127             generate console messages, and 2) CSP usage and files.
2128
2129 2012-12-30  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
2130
2131         [EFL] Enable TEMPLATE_ELEMENT feature
2132         https://bugs.webkit.org/show_bug.cgi?id=105865
2133
2134         Reviewed by Laszlo Gombos.
2135
2136         * Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.
2137
2138 2012-12-30  Zan Dobersek  <zandobersek@gmail.com>
2139
2140         Unreviewed GTK gardening of the unit tests.
2141
2142         Skip the TestInspectorServer unit test that's timing out completely.
2143
2144         * Scripts/run-gtk-tests:
2145         (TestRunner):
2146
2147 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
2148
2149         Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
2150         https://bugs.webkit.org/show_bug.cgi?id=105855
2151
2152         Reviewed by Vsevolod Vlasov.
2153
2154         Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
2155         addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.
2156
2157         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2158         (ReportMemoryUsageVisitor):
2159         (clang::AddMemberCallVisitor::VisitCallExpr):
2160         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2161         (clang::ReportMemoryUsageVisitor::checkMembersCoverage):
2162
2163 2012-12-29  Ilya Tikhonovsky  <loislo@chromium.org>
2164
2165         Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
2166         https://bugs.webkit.org/show_bug.cgi?id=105852
2167
2168         Reviewed by Alexander Pavlov.
2169
2170         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2171         (clang):
2172         (AddMemberCallVisitor):
2173         (ReportMemoryUsageVisitor):
2174         (clang::ReportMemoryUsageAction::ParseArgs):
2175         (clang::AddMemberCallVisitor::VisitCallExpr):
2176         (clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
2177         (clang::ReportMemoryUsageVisitor::emitWarning):
2178         (clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
2179         (clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
2180         (clang::ReportMemoryUsageVisitor::CheckMembersCoverage):
2181
2182 2012-12-29  Zan Dobersek  <zandobersek@gmail.com>
2183
2184         [webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
2185         https://bugs.webkit.org/show_bug.cgi?id=105835
2186
2187         Reviewed by Dirk Pranke.
2188
2189         The BeautifulSoup module is a third-party import and as such we don't have much control
2190         over its testing. Because of that it should be omitted from code coverage checking.
2191
2192         * Scripts/webkitpy/test/main.py:
2193         (Tester._run_tests):
2194
2195 2012-12-28  Martin Robinson  <mrobinson@igalia.com>
2196
2197         [GTK][WK2] Add support for IME Composition
2198         https://bugs.webkit.org/show_bug.cgi?id=65093
2199
2200         Reviewed by Carlos Garcia Campos.
2201
2202         Update unit tests for GtkInputMethodFilter to note whether or not an event
2203         was a fake event synthesized for composition purposes. This is now used
2204         for WebKit2.
2205
2206         * TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:
2207         (TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
2208         (TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
2209         (TestWebKitAPI::TEST):
2210         * gtk/generate-gtkdoc:
2211         (get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
2212         generation.
2213
2214 2012-12-27  Ilya Tikhonovsky  <loislo@chromium.org>
2215
2216         Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
2217         https://bugs.webkit.org/show_bug.cgi?id=105800
2218
2219         Reviewed by Yury Semikhatsky.
2220
2221         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:
2222         (clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
2223         (clang):
2224
2225 2012-12-27  Zan Dobersek  <zandobersek@gmail.com>
2226
2227         Create a GTK build system watchlist and add myself to it
2228         https://bugs.webkit.org/show_bug.cgi?id=105769
2229
2230         Reviewed by Dirk Pranke.
2231
2232         Add a GTK build system watchlist, watching the configure.ac, GNUmakefile.am files
2233         and the input GNUmakefile.features.am.in file. The GNUmakefile.list.am files are
2234         omitted on purpose due to relatively high change rate they are exposed to.
2235
2236         The new watchlist would be of use to me as the GTK build system recently went
2237         through a series of changes that included a changed policy on adding configuration
2238         flags to configure.ac and subsequent additions to GNUmakefile.am files. A PSA on the
2239         mailing list about this change will be published later, but I'd also like to be
2240         notified of any pending changes to these files just so I can check the changes are
2241         in compliance with the new policy.
2242
2243         * Scripts/webkitpy/common/config/watchlist:
2244
2245 2012-12-26  Ilya Tikhonovsky  <loislo@chromium.org>
2246
2247         Unreviewed. Replace find("Tools") with rfind("Tools") because base dir of WebKit may have Tools word.
2248         As example ..../DevTools/src/third_party/WebKit
2249
2250         * Scripts/webkitpy/common/webkit_finder.py:
2251         (WebKitFinder.webkit_base):
2252
2253 2012-12-25  Christophe Dumez  <christophe.dumez@intel.com>
2254
2255         [EFL][WK2] Refactor snapshot taking code
2256         https://bugs.webkit.org/show_bug.cgi?id=105687
2257
2258         Reviewed by Kenneth Rohde Christiansen.
2259
2260         Call WKViewCreateSnapshot() instead of WKViewGetSnapshot()
2261         since the function was renamed to follow naming style.
2262
2263         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2264         (WTR::PlatformWebView::windowSnapshotImage):
2265
2266 2012-12-24  Ilya Tikhonovsky  <loislo@chromium.org>
2267
2268         Web Inspector: Native Memory Instrumentation: propagate member type as edge type to the serialized heap graph.
2269         https://bugs.webkit.org/show_bug.cgi?id=105725
2270
2271         Reviewed by Yury Semikhatsky.
2272
2273         MemberType value names were adjusted according to Style Guide.
2274         Existing tests were extended with link type validation.
2275
2276         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
2277
2278 2012-12-24  Xiaobo Wang  <xbwang@torchmobile.com.cn>
2279
2280         [BlackBerry] DRT - Crashed when running pixels tests
2281         https://bugs.webkit.org/show_bug.cgi?id=105711
2282
2283         RIM PR 270003
2284
2285         Reviewed by George Staikos.
2286
2287         Calling window->post() here will result in buffer swapping which is
2288         only allowed in UI thread now, and I found we don't need to call it
2289         for GL renderer.
2290
2291         * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
2292         (createBitmapContextFromWebView):
2293
2294 2012-12-22  Dan Winship  <danw@gnome.org>
2295
2296         Add a patch to fix libxml2 2.9.0 regression
2297         https://bugs.webkit.org/show_bug.cgi?id=104494
2298
2299         Reviewed by Martin Robinson.
2300
2301         * gtk/jhbuild.modules:
2302         * gtk/patches/libxml2-2.9.0-dtd.patch: patch from upstream
2303
2304 2012-12-23  Allan Sandfeld Jensen  <allan.jensen@digia.com>
2305
2306         Unreviewed update of status to reviewer.
2307
2308         * Scripts/webkitpy/common/config/committers.py:
2309
2310 2012-12-23  Philippe Normand  <pnormand@igalia.com>
2311
2312         [GTK][jhbuild] Bump GStreamer to 1.0.4
2313         https://bugs.webkit.org/show_bug.cgi?id=105640
2314
2315         Reviewed by Martin Robinson.
2316
2317         * gtk/jhbuild.modules: Update GStreamer modules to 1.0.4.
2318
2319 2012-12-21  Nico Weber  <thakis@chromium.org>
2320
2321         chromium: webkit-build-directory doesn't handle ninja output dirs
2322         https://bugs.webkit.org/show_bug.cgi?id=105671
2323
2324         Reviewed by Daniel Bates.
2325
2326         Teach webkit-build-directory to detect the ninja build directory.
2327
2328         * Scripts/webkitdirs.pm:
2329         (determineBaseProductDir):
2330         (determineIsChromiumNinja):
2331
2332 2012-12-21  Ryosuke Niwa  <rniwa@webkit.org>
2333
2334         [Mountain Lion] platform/mac/editing/spelling/removing-underline-after-accepting-autocorrection-using-punctuation.html failing
2335         https://bugs.webkit.org/show_bug.cgi?id=95477
2336
2337         Reviewed by Sam Weinig.
2338
2339         Co-authored by Jia Pu.
2340
2341         Specify a fixed autocorrection dictionary in resetDefaultsToConsistentValues() so that
2342         we can have consistent autocorrection behavior when running tests.
2343
2344         * DumpRenderTree/mac/DumpRenderTree.mm:
2345         (resetDefaultsToConsistentValues):
2346         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
2347         (WTR::InjectedBundle::platformInitialize):
2348
2349 2012-12-21  Zan Dobersek  <zandobersek@gmail.com>
2350
2351         [GTK] Add WebKit1-specific TestExpectations file
2352         https://bugs.webkit.org/show_bug.cgi?id=97562
2353
2354         Reviewed by Dirk Pranke.
2355
2356         Implement the expectations_files method inside the GtkPort class that
2357         returns the list of the TestExpectations files the current test configuration
2358         requires. The method is implemented in a similar way as on the EFL port.
2359         A unit test is also added.
2360
2361         * Scripts/webkitpy/layout_tests/port/gtk.py:
2362         (GtkPort._search_paths):
2363         (GtkPort):
2364         (GtkPort.expectations_files):
2365         * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
2366         (GtkPortTest.test_expectations_files):
2367
2368 2012-12-21  Sudarsana Nagineni  <sudarsana.nagineni@intel.com>
2369
2370         [EFL] Enable feature option for the CSS sticky position
2371         https://bugs.webkit.org/show_bug.cgi?id=105630
2372
2373         Reviewed by Kenneth Rohde Christiansen.
2374
2375         Enable CSS sticky position feature by default for the
2376         EFL port. This feature option was added in r138252.
2377
2378         No new tests. Existing layout tests pass.
2379
2380         * Scripts/webkitperl/FeatureList.pm:
2381
2382 2012-12-21  Jussi Kukkonen  <jussi.kukkonen@intel.com>
2383
2384         [WK2] REGRESSION(r138232): It made 4 tests timeout
2385         https://bugs.webkit.org/show_bug.cgi?id=105623
2386
2387         Reviewed by Kenneth Rohde Christiansen.
2388
2389         r138232 changed functionality so that empty text output
2390         no longer leads to a dump() call, which leads to a timeout.
2391         Instead do a text dump if there is text output or if there
2392         is no audio output.
2393
2394         * WebKitTestRunner/TestInvocation.cpp:
2395         (WTR::TestInvocation::dumpResults):
2396
2397 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2398
2399         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2400         https://bugs.webkit.org/show_bug.cgi?id=105309
2401
2402         On Windows the library name is Qt5WebKitWidgets as well.
2403         So r138136 should not have adjusted the library name for Windows.
2404
2405         Reviewed by Simon Hausmann.
2406
2407         * Scripts/webkitdirs.pm:
2408         (builtDylibPathForName):
2409
2410 2012-12-21  Zeno Albisser  <zeno@webkit.org>
2411
2412         [Qt] Add new TestExpectations for qt-5.0-mac-wk2.
2413         https://bugs.webkit.org/show_bug.cgi?id=105424
2414
2415         This change will allow us to run a very specific
2416         subset of the available LayoutTests on a mac buildbot.
2417         The new baseline search path for mac will look as follows:
2418         qt-5.0-mac-wk2 -> qt-5.0-wk2 -> qt-5.0 -> qt-mac -> qt
2419
2420         Reviewed by Dirk Pranke.
2421
2422         * Scripts/webkitpy/layout_tests/port/qt.py:
2423         (QtPort._search_paths):
2424         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2425         (QtPortTest):
2426
2427 2012-12-20  Ryuan Choi  <ryuan.choi@samsung.com>
2428
2429         [EFL] Build break with latest EFL libraries.
2430         https://bugs.webkit.org/show_bug.cgi?id=104827
2431
2432         Reviewed by Laszlo Gombos.
2433
2434         The eo EFL package is introduced and evas and ecore use it since 1.8.
2435         While introducing Eo, EFL changed several structures of Evas and Ecore
2436         from own specific class to Eo.
2437
2438         So, this patch adds FindEo and changes declaration of Evas, Evas_Object,
2439         Ecore_Timer to build with latest EFL libraries.
2440
2441         * DumpRenderTree/efl/CMakeLists.txt: Includes eo EFL library.
2442         * EWebLauncher/CMakeLists.txt: Ditto.
2443         * MiniBrowser/efl/CMakeLists.txt: Ditto.
2444         * ImageDiff/PlatformEfl.cmake: Ditto.
2445         * TestWebKitAPI/PlatformEfl.cmake: Ditto.
2446         * TestWebKitAPI/PlatformWebView.h: Modified declaration of Evas_Object.
2447         * WebKitTestRunner/InjectedBundle/TestRunner.h: Modified declaration of Ecore_Timer.
2448         * WebKitTestRunner/PlatformEfl.cmake: Includes eo EFL library.
2449         * WebKitTestRunner/PlatformWebView.h: Modified declaration of Evas_Object.
2450
2451 2012-12-20  Dirk Pranke  <dpranke@chromium.org>
2452
2453         TestExpectation fallback is broken
2454         https://bugs.webkit.org/show_bug.cgi?id=105583
2455
2456         Reviewed by Ryosuke Niwa.
2457
2458         When I added support for the -wk2 in port names, it looks
2459         like I broke the way we computed the list of TestExpectations
2460         files so that the implementation-version directory was left out :(.
2461         Fixed and cleaned up the tests.
2462
2463         * Scripts/webkitpy/layout_tests/port/base.py:
2464         (Port.expectations_files):
2465         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
2466         (TestWebKitPort.__init__):
2467         (PortTestCase.test_skipped_directories_for_symbols):
2468         (test_skipped_directories_for_features):
2469         (test_skipped_directories_for_features_no_matching_tests_in_test_list):
2470         (test_skipped_tests_for_unsupported_features_empty_test_list):
2471         (test_skipped_layout_tests):
2472         (test_expectations_files):
2473
2474 2012-12-20  Anders Carlsson  <andersca@apple.com>
2475
2476         Don't include WebKit2 headers when building TestWebKitAPI on windows
2477         https://bugs.webkit.org/show_bug.cgi?id=105582
2478
2479         Reviewed by Tim Horton.
2480
2481         * TestWebKitAPI/config.h:
2482         * TestWebKitAPI/win/main.cpp:
2483
2484 2012-12-20  Ryosuke Niwa  <rniwa@webkit.org>
2485
2486         REGRESSION(r133820?): SimplifyMarkupTest API test asserts
2487         https://bugs.webkit.org/show_bug.cgi?id=105370
2488
2489         Reviewed by Simon Fraser.
2490
2491         Re-enable the test.
2492
2493         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2494         (TestWebKitAPI::TEST):
2495
2496 2012-12-20  Nico Weber  <thakis@chromium.org>
2497
2498         chromium nrwt: Pick the newest binary found in DEFAULT_BUILD_DIRECTORIES, not the first
2499         https://bugs.webkit.org/show_bug.cgi?id=105498
2500
2501         Reviewed by Dirk Pranke.
2502
2503         Use the newest binary available rather than an than always picking one
2504         build directory over another based on iteration order.
2505
2506         * Scripts/webkitpy/layout_tests/port/chromium.py:
2507         (ChromiumPort._static_build_path):
2508         Check for timestamps.
2509         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2510         (ChromiumMacPortTest.test_build_path_timestamps):
2511         Test that out / xcodebuild selection happens based on timestamps
2512         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
2513         (ChromiumWinPortTest.test_build_path_timestamps):
2514         Test that out / build selection happens based on timestamps
2515
2516 2012-12-19  Simon Fraser  <simon.fraser@apple.com>
2517
2518         Lots of sticky tests failing in WK2
2519         https://bugs.webkit.org/show_bug.cgi?id=105464
2520
2521         Reviewed by Beth Dakin.
2522
2523         WebKitTestRunner had a race between snapshotting in the UI process,
2524         and resettting after the test in the web process. InjectedBundle::done()
2525         was a bad place to call page()->resetAfterTest(), because of this race;
2526         it could reset the scroll position before the UI snapshot had been obtained.
2527
2528         Fix by moving the call to page()->resetAfterTest() into didReceiveMessage(),
2529         for the "Reset" message which will come in before the next test.
2530
2531         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
2532         (WTR::InjectedBundle::didReceiveMessage):
2533         (WTR::InjectedBundle::done):
2534
2535 2012-12-19  Filip Pizlo  <fpizlo@apple.com>
2536
2537         DFG speculation checks that take JumpList should consolidate OSRExits
2538         https://bugs.webkit.org/show_bug.cgi?id=105401
2539
2540         Reviewed by Oliver Hunt.
2541
2542         Update the profiler to understand that an OSR exit may have multiple
2543         candidate exit sites.
2544
2545         * Scripts/display-profiler-output:
2546
2547 2012-12-20  Eric Seidel  <eric@webkit.org>
2548
2549         EWSes do not need to dump build/test logs when things pass
2550         https://bugs.webkit.org/show_bug.cgi?id=105402
2551
2552         Reviewed by Dirk Pranke.
2553
2554         When we were first writing the commit-queue and EWS system
2555         and running them locally, we thought it was important to see the
2556         build/test output as it happened.  Now these queues have been running
2557         for years, and we don't use this feature anymore.  So this patch
2558         makes us stop tee-ing the output directly to stdout, and instead
2559         only print any output from commands when they fail.
2560
2561         I also added some logging when we execute each command
2562         since we are no longer printing the command output itself.
2563         This should make it much easier to see errors with the EWS
2564         system itself, now that all the passing-build output is removed.
2565
2566         This required updating a zillion unittests, since we have a bunch of
2567         "integration" style testing of the queue-bots.  Many of the unittests for the bots were
2568         already approximating this behavior by using a "logging" Executive.
2569         I disabled logging in those cases to avoid redundant logging in those tests.
2570
2571         * Scripts/webkitpy/common/system/executive.py:
2572         (Executive.command_for_printing):
2573         (Executive.run_command):
2574         * Scripts/webkitpy/common/system/executive_mock.py:
2575         (MockExecutive.command_for_printing):
2576         (MockExecutive.run_command):
2577         * Scripts/webkitpy/common/system/executive_unittest.py:
2578         (ExecutiveTest.test_auto_stringify_args):
2579         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
2580         (EarlyWarningSytemTest._default_expected_logs):
2581         (_test_ews):
2582         (_test_ewses):
2583         * Scripts/webkitpy/tool/commands/queues.py:
2584         (AbstractQueue.run_webkit_patch):
2585         * Scripts/webkitpy/tool/commands/queues_unittest.py:
2586         (AbstractQueueTest._assert_run_webkit_patch):
2587         (CommitQueueTest.test_commit_queue):
2588         (test_rollout):
2589         (test_rollout_lands):
2590         (test_manual_reject_during_processing):
2591         (StyleQueueTest.test_style_queue_with_style_exception):
2592         (test_style_queue_with_watch_list_exception):
2593
2594 2012-12-20  Dominic Mazzoni  <dmazzoni@google.com>
2595
2596         AX: support clickPoint in DRT for chromium
2597         https://bugs.webkit.org/show_bug.cgi?id=97359
2598
2599         Reviewed by Chris Fleizach.
2600
2601         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2602         several more tests can pass.
2603
2604         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2605         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2606         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2607         (WebTestRunner):
2608         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2609         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2610         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2611         (AccessibilityUIElement):
2612
2613 2012-12-20  Dan Bernstein  <mitz@apple.com>
2614
2615         prepare-ChangeLog adds "Additional information of the change such as approach, rationale" where it doesn't make sense
2616         https://bugs.webkit.org/show_bug.cgi?id=99268
2617
2618         Reviewed by Alexey Proskuryakov.
2619
2620         * Scripts/prepare-ChangeLog:
2621         (generateNewChangeLogs): Removed the "Additional information of the change" line.
2622
2623 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2624
2625         Unreviewed. Skip unit test /webkit/atk/getTextInParagraphAndBodyModerate
2626
2627         * Scripts/run-gtk-tests:
2628         (TestRunner):
2629
2630 2012-12-20  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2631
2632         [Qt] Move ImageDiff to the Tools directory root
2633         https://bugs.webkit.org/show_bug.cgi?id=105420
2634
2635         Reviewed by Tor Arne Vestbø.
2636
2637         Moved ImageDiff from outside DumpRenderTree because it is also a
2638         dependency when running pixel tests for WebKit2.
2639
2640         * ImageDiff/ImageDiff.pro: Renamed from Tools/DumpRenderTree/qt/ImageDiff.pro.
2641         * ImageDiff/qt/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/qt/ImageDiff.cpp.
2642         * Tools.pro:
2643
2644 2012-12-20  Zan Dobersek  <zandobersek@gmail.com>
2645
2646         [GTK] Remove the --enable-unstable-features configuration option
2647         https://bugs.webkit.org/show_bug.cgi?id=105327
2648
2649         Reviewed by Martin Robinson.
2650
2651         Add a missing feature option for the CSS sticky position feature.
2652
2653         * Scripts/webkitperl/FeatureList.pm:
2654
2655 2012-12-20  Carlos Garcia Campos  <cgarcia@igalia.com>
2656
2657         Unreviewed. Skip unit test WebKit2.ForceRepaint that times out
2658
2659         * Scripts/run-gtk-tests:
2660         (TestRunner):
2661
2662 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2663
2664         [EFL] MiniBrowser does not play Infinite Gangnam Style
2665         https://bugs.webkit.org/show_bug.cgi?id=103531
2666
2667         Reviewed by Kenneth Rohde Christiansen.
2668
2669         For EFL we would like this feature to be built by default.
2670
2671         * Scripts/webkitperl/FeatureList.pm:
2672
2673 2012-12-20  Csaba Osztrogonác  <ossy@webkit.org>
2674
2675         [Qt] EWS bots should call qmake always
2676         https://bugs.webkit.org/show_bug.cgi?id=90049
2677
2678         Reviewed by Simon Hausmann.
2679
2680         * Scripts/webkitdirs.pm:
2681         (buildQMakeProjects):
2682
2683 2012-12-20  Jochen Eisinger  <jochen@chromium.org>
2684
2685         [chromium] fix stray printf in TestRunner's WebTestProxy
2686         https://bugs.webkit.org/show_bug.cgi?id=105515
2687
2688         Reviewed by Ryosuke Niwa.
2689
2690         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
2691         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
2692
2693 2012-12-20  Dominik Röttsches  <dominik.rottsches@intel.com>
2694
2695         [WK2] WebAudio WKTR support
2696         https://bugs.webkit.org/show_bug.cgi?id=95084
2697
2698         Reviewed by Kenneth Rohde Christiansen.
2699
2700         Implementing audio data dump support for WebKitTestRunner,
2701         by adding the API to the IDL, enabling IPC for transferring
2702         the audio data as bytebuffer and dumping it according
2703         to run-webkit-tests script's expectations.
2704         This enables audio testing on WebKit2 ports.
2705         Based on initial wip-patch from Philippe Normand - thanks.
2706
2707         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding setAudioData API.
2708         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: Assign audio buffer data to a local WKDataRef after extracting it from WK2 using WKBundleDataFromUint8Array bundle API.
2709         (WTR::TestRunner::setAudioData):
2710         (WTR):
2711         * WebKitTestRunner/InjectedBundle/TestRunner.h: Add a whatToDump state for dumping Audio.
2712         (TestRunner):
2713         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: Add audio to the message that's transferred to the WKTR process.
2714         (WTR::InjectedBundle::done):
2715         * WebKitTestRunner/InjectedBundle/InjectedBundle.h: Allow setting and audio result handle to be transferred.
2716         (WTR::InjectedBundle::setAudioResult):
2717         (InjectedBundle):
2718         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2719         (WTR::InjectedBundlePage::dump): Dummy handling the Audio case in the switch, build fix for Mac.
2720         * WebKitTestRunner/TestInvocation.cpp: Audio dump support, dump audio if we haven't received a text dump from the web process.
2721         (WTR::TestInvocation::dumpResults):
2722         (WTR):
2723         (WTR::TestInvocation::dumpAudio):
2724         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Storing received audio data before dumping.
2725         * WebKitTestRunner/TestInvocation.h:
2726         (TestInvocation):
2727
2728 2012-12-20  Alberto Garcia  <agarcia@igalia.com>
2729
2730         [GTK] Count failed and timed out tests separately
2731         https://bugs.webkit.org/show_bug.cgi?id=105448
2732
2733         Reviewed by Carlos Garcia Campos.
2734
2735         Display the number of tests that fail, time out and are skipped
2736         separately in the buildbot page.
2737
2738         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2739         (RunGtkAPITests.commandComplete):
2740         (RunGtkAPITests.evaluateCommand):
2741         (RunGtkAPITests.getText2):
2742         * Scripts/run-gtk-tests:
2743         (TestRunner.run_tests):
2744
2745 2012-12-19  Ryosuke Niwa  <rniwa@webkit.org>
2746
2747         PerfTest.parse_output does too much
2748         https://bugs.webkit.org/show_bug.cgi?id=105391
2749
2750         Reviewed by Tony Chang.
2751
2752         Moved the code to filter lines into PerfTest._filter_output, which has been renamed from _filter_stderr.
2753         Also moved the code to output test results into PerfTest._run_with_driver.
2754
2755         * Scripts/webkitpy/performance_tests/perftest.py:
2756         (PerfTest.__init__): Added _description.
2757         (PerfTest.description): Added.
2758         (PerfTest._run_with_driver): Moved the code to output test description and test results.
2759         (PerfTest._filter_output): Moved and renamed from PerfTest._filter_stderr.
2760         (PerfTest.parse_output): Removed the code to output test results. Return test results and description
2761         respectively. Also removed the code that allowed some tests to omit values since all tests report each
2762         iteration now since r136492.
2763         (PerfTest.output_statistics): Removed the code to print test description, now done in _run_with_driver.
2764         (ChromiumStylePerfTest._run_with_driver): Added. Chromium style tests are sufficiently different from
2765         regular PerfTest that it doesn't make much sense to share _run_with_driver. But really, we should just
2766         get rid of this type of test altogether in favor of regular performance tests that uses runner.js.
2767         (ChromiumStylePerfTest.parse_and_log_output): Renamed from parse_output.
2768         (PageLoadingPerfTest._run_with_driver): Removed the explicit '' for the test description.
2769         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
2770         (MainTest.test_parse_output): Removed the expected logs since parse_output no longer prints out results.
2771         Also added a call to _filter_output since parse_output doesn't filter the output text anymore.
2772         (MainTest.test_parse_output_with_failing_line): Added a call to _filter_output. Also added ',' after 'Time:'
2773         so that it's not string-concatenated with the next line.
2774         (MainTest.test_parse_output_with_description): Added; a test for PerfTest.description().
2775         (MainTest.test_parse_output_with_subtests): Removed the expected logs, and added a call to _filter_output.
2776
2777 2012-12-19  Alexis Menard  <alexis@webkit.org>
2778
2779         Implement CSS parsing for CSS transitions unprefixed.
2780         https://bugs.webkit.org/show_bug.cgi?id=104804
2781
2782         Reviewed by Dean Jackson.
2783
2784         Add a new flag ENABLE_CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
2785         to cover the work of unprefixing Transforms, Animations and
2786         Transitions. It will let the possibility of each ports to turn it off
2787         in their release branches until we're confident that these CSS
2788         properties are ready to be unprefixed.
2789
2790         * Scripts/webkitperl/FeatureList.pm:
2791         * qmake/mkspecs/features/features.pri:
2792
2793 2012-12-19  Julien Chaffraix  <jchaffraix@webkit.org>
2794
2795         2 clampTo unit tests are failing
2796         https://bugs.webkit.org/show_bug.cgi?id=105253
2797
2798         Reviewed by Emil A Eklund.
2799
2800         Removed clampToUnsigned as it was actually testing exactly what
2801         clampToUnsignedLong was doing. Also made clampToIntFloat more robust
2802         to precision loss (fix suggested by Emil).
2803
2804         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2805
2806 2012-12-19  Thiago Marcos P. Santos  <thiago.santos@intel.com>
2807
2808         [EFL] Move ImageDiff to the Tools directory root
2809         https://bugs.webkit.org/show_bug.cgi?id=105305
2810
2811         Reviewed by Laszlo Gombos.
2812
2813         We previously moved this directory from the DRT directory to
2814         efl/ImageDiff. The major reason for doing so was because ImageDiff does
2815         not depend on DumpRenderTree but for legacy reasons was living inside the
2816         DRT folder, even though it is needed when running pixel tests for WK2.
2817
2818         Now we are moving to Tool directory root as other ports agreed to do the same.
2819
2820         * CMakeLists.txt:
2821         * ImageDiff/CMakeLists.txt: Added.
2822         * ImageDiff/PlatformEfl.cmake: Added.
2823         * ImageDiff/efl/ImageDiff.cpp: Renamed from Tools/efl/ImageDiff/ImageDiff.cpp.
2824         * efl/ImageDiff/CMakeLists.txt: Removed.
2825
2826 2012-12-19  Zeno Albisser  <zeno@webkit.org>
2827
2828         [Qt][Mac] run-launcher cannot find Qt5WebKitWidgets.
2829         https://bugs.webkit.org/show_bug.cgi?id=105309
2830
2831         The version number is only used as a part
2832         of the library name on Linux.
2833
2834         Reviewed by Kenneth Rohde Christiansen.
2835
2836         * Scripts/webkitdirs.pm:
2837         (builtDylibPathForName):
2838
2839 2012-12-19  Alberto Garcia  <agarcia@igalia.com>
2840
2841         [GTK] Tests that time out are not considered as failures.
2842         https://bugs.webkit.org/show_bug.cgi?id=105318
2843
2844         Reviewed by Martin Robinson.
2845
2846         Fix parsing of the GTK API tests log files.
2847
2848         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2849         (RunGtkAPITests.commandComplete):
2850
2851 2012-12-18  Ilya Tikhonovsky  <loislo@chromium.org>
2852
2853         Unreviewed, rolling out r138061.
2854         https://bugs.webkit.org/show_bug.cgi?id=105396
2855
2856         Original patch:
2857         http://trac.webkit.org/changeset/138061
2858         https://bugs.webkit.org/show_bug.cgi?id=97359
2859
2860         It is crashing on Debug bots
2861
2862         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2863         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2864         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2865         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2866         (AccessibilityUIElement):
2867
2868 2012-12-18  Alice Liu  <alice.liu@apple.com>
2869
2870         Test for https://bugs.webkit.org/show_bug.cgi?id=105106
2871         Add SPI to WebKit1 WebFrame for hit testing
2872
2873         Reviewed by Dan Bernstein.
2874
2875         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/ElementAtPointInWebFrame.mm
2876         * TestWebKitAPI/Tests/mac/ElementAtPointInWebFrame.mm: Added.
2877         (TestWebKitAPI::TEST): Loads html with two divs positioned in the 2nd and 4th quadrants of the webview.
2878         Then hit-tests at three points, expecting to hit the two divs and body element.
2879
2880 2012-12-18  Alice Liu  <alice.liu@apple.com>
2881
2882         Test for https://bugs.webkit.org/show_bug.cgi?id=105262
2883         Add SPI to WebKit1 WebFrame for node conversion to JSValueRef
2884
2885         Reviewed by Anders Carlsson.
2886
2887         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added file Tests/mac/JSWrapperForNodeInWebFrame.mm.mm
2888         * TestWebKitAPI/Tests/mac/JSWrapperForNodeInWebFrame.mm.mm: Added.
2889         (TestWebKitAPI::TEST): Tests for the correct JS wrapper for a DOMNode, provided a WebScriptWorld.
2890         Loads html with a single div element. In an isolated world, creates a property on that node.
2891         Also, in the standard world, creates a different property on that node.  Then tests for 4 things:
2892             - Existence of the isolated property in the isolated world.
2893             - Existence of the standard property in the standard world.
2894             - Non-existence of the isolated property in the standard world.
2895             - Non-existence of the standard property in the isolated world.
2896
2897 2012-12-18  Simon Fraser  <simon.fraser@apple.com>
2898
2899         Disable the SimplifyMarkup API test, wich asserts in debug builds.
2900         Tracked by https://bugs.webkit.org/show_bug.cgi?id=105370.
2901
2902         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
2903         (TestWebKitAPI::TEST):
2904
2905 2012-12-18  Joseph Pecoraro  <pecoraro@apple.com>
2906
2907         [Mac] Add Build Phase to Check Headers for Inappropriate Macros (Platform.h macros)
2908         https://bugs.webkit.org/show_bug.cgi?id=104279
2909
2910         Reviewed by David Kilzer.
2911
2912         Add a build phase script that checks a framework's header files for
2913         Platform.h and Compiler.h macros. Also add some tests for the script.
2914
2915         * Scripts/check-for-inappropriate-macros-in-external-headers: Added.
2916         Script to be used in build phases to check for inappropriate macros in headers.
2917
2918         * Scripts/test-webkitruby: Added.
2919         Script that can be used to run all webkitruby tests.
2920
2921         * Scripts/test-webkit-scripts:
2922         Also run the ruby tests.
2923
2924         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/fake-data-failing-expected.txt: Added.
2925         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/pass-expected.txt: Added.
2926         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Fail.h: Added.
2927         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/resources/Fake.framework/Headers/Pass.h: Added.
2928         * Scripts/webkitruby/check-for-inappropriate-macros-in-external-headers-tests/run-test.rb: Added.
2929         Tests for the new script.
2930
2931 2012-12-18  Dominic Mazzoni  <dmazzoni@google.com>
2932
2933         AX: support clickPoint in DRT for chromium
2934         https://bugs.webkit.org/show_bug.cgi?id=97359
2935
2936         Reviewed by Chris Fleizach.
2937
2938         Implement clickPointX, clickPointY, and elementAtPoint for Chromium, so that
2939         several more tests can pass.
2940
2941         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.cpp:
2942         (WebTestRunner::AccessibilityUIElement::AccessibilityUIElement):
2943         (WebTestRunner::AccessibilityUIElement::clickPointXGetterCallback):
2944         (WebTestRunner):
2945         (WebTestRunner::AccessibilityUIElement::clickPointYGetterCallback):
2946         (WebTestRunner::AccessibilityUIElement::elementAtPointCallback):
2947         * DumpRenderTree/chromium/TestRunner/src/AccessibilityUIElementChromium.h:
2948         (AccessibilityUIElement):
2949
2950 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2951
2952         Build fix after r138045.
2953
2954         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2955         (PerfTestsRunner._collect_tests): Use relative_path. We skip only when this path
2956         is not explicitly specified. The condition was backwards but never matched so we
2957         always ran the test regardless of whether it's listed in the skipped list or not.
2958         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2959         (test_collect_tests_with_ignored_skipped_list): Renamed so that it actually runs.
2960
2961 2012-12-18  Emil A Eklund  <eae@chromium.org>
2962
2963         TestWebKitAPI/Tests/WebCore/LayoutUnit fails on mac
2964         https://bugs.webkit.org/show_bug.cgi?id=105332
2965
2966         Reviewed by Levi Weintraub.
2967
2968         Create new test suite for LayoutUnit tests as the KURL tests are
2969         of the incompatible TEST_F type.
2970
2971         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
2972         (TestWebKitAPI):
2973         (TestWebKitAPI::TEST_F):
2974
2975 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
2976
2977         Running a skipped test with run-perf-tests could alert the user
2978         https://bugs.webkit.org/show_bug.cgi?id=105219
2979
2980         Reviewed by Eric Seidel.
2981
2982         Force run skipped performance tests explicitly specified in the command line.
2983         Also warn the user when the specified paths don't exist.
2984
2985         * Scripts/webkitpy/layout_tests/port/base.py:
2986         (Port.relative_test_filename):
2987         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2988         (PerfTestsRunner._parse_args):
2989         (PerfTestsRunner._collect_tests):
2990         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
2991         (test_collect_tests_with_skipped_list_and_files):
2992
2993 2012-12-18  Yaron Friedman  <yfriedman@chromium.org>
2994
2995         Chrome Android java output is too verbose
2996         https://bugs.webkit.org/show_bug.cgi?id=105247
2997
2998         Reviewed by Tony Chang.
2999
3000         Pass -quiet to ant to suppress extraneous output.
3001
3002         * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
3003         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3004
3005 2012-12-18  Ryosuke Niwa  <rniwa@webkit.org>
3006
3007         Consider removing --pause-before-testing option
3008         https://bugs.webkit.org/show_bug.cgi?id=105248
3009
3010         Reviewed by Eric Seidel.
3011
3012         Remove --pause-before-testing option.
3013
3014         * Tools/Scripts/webkitpy/layout_tests/port/driver.py:
3015         (DriverProxy.start): Removed.
3016         * Scripts/webkitpy/performance_tests/perftest.py:
3017         (PerfTest.__init__):
3018         (PerfTest.test_path): Renamed from path_or_url.
3019         (PerfTest.run):
3020         (PerfTest): Removed "driver" argument.
3021         (PerfTest._run_with_driver):
3022         (PerfTest.run_single):
3023         (ChromiumStylePerfTest.__init__):
3024         (PageLoadingPerfTest.__init__):
3025         (PageLoadingPerfTest.run_single):
3026         (PageLoadingPerfTest._run_with_driver): Renamed from run so that PerfTest.run can create a driver for us.
3027         (ReplayPerfTest.__init__):
3028         (ReplayPerfTest.prepare):
3029         * Scripts/webkitpy/performance_tests/perftest_unittest.py:
3030         (TestPageLoadingPerfTest.test_run):
3031         (TestPageLoadingPerfTest.test_run_with_memory_output):
3032         (TestPageLoadingPerfTest.test_run_with_bad_output):
3033         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3034         (PerfTestsRunner._parse_args):
3035         (PerfTestsRunner._run_tests_set): Removed the code to create a driver and pause before running the test.
3036         (PerfTestsRunner._run_single_test): Removed "driver" argument.
3037         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
3038         (run_test):
3039         (test_run_test_pause_before_testing): Removed.
3040
3041 2012-12-18  Alberto Garcia  <agarcia@igalia.com>
3042
3043         [GTK] Tests that time out are not considered as failures.
3044         https://bugs.webkit.org/show_bug.cgi?id=105318
3045
3046         Reviewed by Martin Robinson.
3047
3048         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
3049         (RunGtkAPITests.commandComplete):
3050         Consider log lines that end with TIMEOUT as errors.
3051
3052         * Scripts/run-gtk-tests:
3053         (TestRunner.run_tests):
3054         Consider timeouts as failures when returning the number of failed
3055         tests.
3056
3057 2012-12-18  Pravin D  <pravin.d@samsung.com>
3058
3059         Unreviewed, adding secondary email.
3060
3061         * Scripts/webkitpy/common/config/committers.py:
3062
3063 2012-12-18  Pravin D  <pravin.d@samsung.com>
3064
3065         Unreviewed, promoting myself to committer's list.
3066
3067         * Scripts/webkitpy/common/config/committers.py:
3068
3069 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3070
3071         [EFL] ImageDiff does not build on WebKit2 only builds
3072         https://bugs.webkit.org/show_bug.cgi?id=105288
3073
3074         Reviewed by Kenneth Rohde Christiansen.
3075
3076         Moved ImageDiff to the efl/ folder inside Tools/ (so we don't pollute
3077         the folder with things which are EFL-specific.
3078
3079         ImageDiff will be built by default now regardless of WebKit API flavor
3080         you choose.
3081
3082         * CMakeLists.txt:
3083         * DumpRenderTree/efl/CMakeLists.txt:
3084         * efl/ImageDiff/CMakeLists.txt: Added.
3085         * efl/ImageDiff/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/efl/ImageDiff.cpp.
3086
3087 2012-12-18  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3088
3089         [EFL][WK2] When creating new windows, use the opener's context
3090         https://bugs.webkit.org/show_bug.cgi?id=105283
3091
3092         Reviewed by Laszlo Gombos.
3093
3094         Use the context of the opener if exists.
3095
3096         * MiniBrowser/efl/main.c:
3097         (on_key_down):
3098         (on_window_create):
3099         (window_create):
3100         (elm_main):
3101
3102 2012-12-18  Thiago Marcos P. Santos  <thiago.santos@intel.com>
3103
3104         [EFL][WK2] Gardening of TestWebKitAPI tests
3105         https://bugs.webkit.org/show_bug.cgi?id=105268
3106
3107         Reviewed by Kenneth Rohde Christiansen.
3108
3109         Some tests were marked as failing but are passing and the newly added
3110         LayoutUnit should have it's own binary because it conflicts with the
3111         fixture used by KURL and is failing on the bots because of that.
3112
3113         * TestWebKitAPI/CMakeLists.txt:
3114         * TestWebKitAPI/PlatformEfl.cmake:
3115
3116 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
3117
3118         [chromium] move webintent related methods to TestRunner library
3119         https://bugs.webkit.org/show_bug.cgi?id=105164
3120
3121         Reviewed by Darin Fisher.
3122
3123         Also deleted the unused deliveredIntentFailure and
3124         deliveredIntentResult methods.
3125
3126         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3127         (DRTTestRunner::DRTTestRunner):
3128         * DumpRenderTree/chromium/DRTTestRunner.h:
3129         (DRTTestRunner):
3130         * DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
3131         (WebKit):
3132         (WebTestRunner::WebTestDelegate::setCurrentWebIntentRequest):
3133         (WebTestRunner::WebTestDelegate::currentWebIntentRequest):
3134         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3135         (WebKit):
3136         (WebTestProxyBase):
3137         (WebTestRunner::WebTestProxy::registerIntentService):
3138         (WebTestRunner::WebTestProxy::dispatchIntent):
3139         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3140         (WebTestRunner::TestRunner::TestRunner):
3141         (WebTestRunner::TestRunner::sendWebIntentResponse):
3142         (WebTestRunner):
3143         (WebTestRunner::TestRunner::deliverWebIntent):
3144         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3145         (TestRunner):
3146         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3147         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3148         (WebTestRunner::WebTestProxyBase::registerIntentService):
3149         (WebTestRunner):
3150         (WebTestRunner::WebTestProxyBase::dispatchIntent):
3151         * DumpRenderTree/chromium/WebViewHost.cpp:
3152         (WebViewHost::setCurrentWebIntentRequest):
3153         (WebViewHost::currentWebIntentRequest):
3154         * DumpRenderTree/chromium/WebViewHost.h:
3155         (WebKit):
3156         (WebViewHost):
3157
3158 2012-12-18  Jochen Eisinger  <jochen@chromium.org>
3159
3160         [chromium] move editing callback dumping to the WebTestProxy
3161         https://bugs.webkit.org/show_bug.cgi?id=105013
3162
3163         Reviewed by Darin Fisher.
3164
3165         To decide whether or not to dump the editing callbacks, the WebTestProxy
3166         needs to query the TestRunner. For this purpose, I introduce a
3167         WebTestRunner class that just exposes the shouldDumpEditingCallbacks
3168         method. In contrast to e.g. WebEventSender, the WebTestRunner is just
3169         an interface, and it is not owned by the WebTestInterfaces, but the
3170         embedder of the TestRunner library must provide it. This will change
3171         once all TestRunner methods are in the library.
3172
3173         * DumpRenderTree/DumpRenderTree.gypi:
3174         * DumpRenderTree/chromium/DRTTestRunner.cpp:
3175         (DRTTestRunner::DRTTestRunner):
3176         (DRTTestRunner::reset):
3177         * DumpRenderTree/chromium/DRTTestRunner.h:
3178         (DRTTestRunner):
3179         (DRTTestRunner::taskList):
3180         (DRTTestRunner::WorkQueue::taskList):
3181         * DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
3182         (WebTestRunner):
3183         (WebTestInterfaces):
3184         * DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
3185         (WebKit):
3186         (WebTestRunner):
3187         (WebTestProxyBase):
3188         (WebTestRunner::WebTestProxy::shouldBeginEditing):
3189         (WebTestRunner::WebTestProxy::shouldEndEditing):
3190         (WebTestRunner::WebTestProxy::shouldInsertNode):
3191         (WebTestRunner::WebTestProxy::shouldInsertText):
3192         (WebTestRunner::WebTestProxy::shouldChangeSelectedRange):
3193         (WebTestRunner::WebTestProxy::shouldDeleteRange):
3194         (WebTestRunner::WebTestProxy::shouldApplyStyle):
3195         (WebTestRunner::WebTestProxy::didBeginEditing):
3196         (WebTestRunner::WebTestProxy::didChangeSelection):
3197         (WebTestRunner::WebTestProxy::didChangeContents):
3198         (WebTestRunner::WebTestProxy::didEndEditing):
3199         * DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h: Copied from Tools/DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h.
3200         (WebTestRunner):
3201         (WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
3202         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3203         (WebTestRunner::TestRunner::TestRunner):
3204         (WebTestRunner::TestRunner::~TestRunner):
3205         (WebTestRunner):
3206         (WebTestRunner::TestRunner::reset):
3207         (WebTestRunner::TestRunner::shouldDumpEditingCallbacks):
3208         (WebTestRunner::TestRunner::dumpEditingCallbacks):
3209         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3210         (TestRunner):
3211         * DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
3212         (WebTestRunner::WebTestInterfaces::Internal::testRunner):
3213         (WebTestRunner::WebTestInterfaces::Internal::setTestRunner):
3214         (WebTestInterfaces::Internal):
3215         (WebTestRunner::WebTestInterfaces::Internal::Internal):
3216         (WebTestRunner::WebTestInterfaces::testRunner):
3217         (WebTestRunner):
3218         (WebTestRunner::WebTestInterfaces::setTestRunner):
3219         * DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
3220         (WebTestRunner::WebTestProxyBase::postAccessibilityNotification):
3221         (WebTestRunner):
3222         (WebTestRunner::WebTestProxyBase::shouldBeginEditing):
3223         (WebTestRunner::WebTestProxyBase::shouldEndEditing):
3224         (WebTestRunner::WebTestProxyBase::shouldInsertNode):
3225         (WebTestRunner::WebTestProxyBase::shouldInsertText):
3226         (WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
3227         (WebTestRunner::WebTestProxyBase::shouldDeleteRange):
3228         (WebTestRunner::WebTestProxyBase::shouldApplyStyle):
3229         (WebTestRunner::WebTestProxyBase::didBeginEditing):
3230         (WebTestRunner::WebTestProxyBase::didChangeSelection):
3231         (WebTestRunner::WebTestProxyBase::didChangeContents):
3232         (WebTestRunner::WebTestProxyBase::didEndEditing):
3233         * DumpRenderTree/chromium/TestShell.cpp:
3234         (TestShell::initialize):
3235         (TestShell::createNewWindow):
3236         * DumpRenderTree/chromium/WebViewHost.cpp:
3237         (WebViewHost::shouldBeginEditing):
3238         (WebViewHost::shouldEndEditing):
3239         (WebViewHost::shouldInsertNode):
3240         (WebViewHost::shouldInsertText):
3241         (WebViewHost::shouldChangeSelectedRange):
3242         (WebViewHost::shouldDeleteRange):
3243         (WebViewHost::shouldApplyStyle):
3244         * DumpRenderTree/chromium/WebViewHost.h:
3245         (WebViewHost):
3246
3247 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3248
3249         [chromium] Fix methods in TestRunner that directly modify the settings instead of going through WebPreferences
3250         https://bugs.webkit.org/show_bug.cgi?id=105154
3251
3252         Reviewed by Tony Chang.
3253
3254         If the settings are modified directly, the embedder can't keep track of
3255         them and might accidentially override the changed settings.
3256
3257         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3258         (WebPreferences):
3259         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3260         (WebTestRunner::TestRunner::TestRunner):
3261         (WebTestRunner::TestRunner::setAsynchronousSpellCheckingEnabled):
3262         (WebTestRunner):
3263         (WebTestRunner::TestRunner::setMinimumTimerInterval):
3264         (WebTestRunner::TestRunner::setTouchDragDropEnabled):
3265         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3266         (TestRunner):
3267         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3268         (WebTestRunner::WebPreferences::reset):
3269         (WebTestRunner::WebPreferences::applyTo):
3270
3271 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3272
3273         Unreviewed unit test skipping.
3274
3275         Filed https://bugs.webkit.org/show_bug.cgi?id=105253 to re-enable them.
3276
3277         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3278         (TestWebKitAPI):
3279         (TestWebKitAPI::TEST):
3280
3281 2012-12-17  Dean Jackson  <dino@apple.com>
3282
3283         Unreviewed. Add Silvia Pfeiffer to contributor list.
3284
3285         * Scripts/webkitpy/common/config/committers.py:
3286
3287 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3288
3289         build.webkit.org - add more google windows bots
3290         https://bugs.webkit.org/show_bug.cgi?id=105225
3291
3292         Reviewed by Eric Seidel.
3293
3294         Adds two more windows bots (google-windows-3, a builder, and
3295         google-windows-4, a tester) for the Chromium configs.
3296
3297         * BuildSlaveSupport/build.webkit.org-config/config.json:
3298
3299 2012-12-17  Eric Seidel  <eric@webkit.org>
3300
3301         Cleanup --profiler=perf code a little and allow up to 1000 report files (instead of 100)
3302         https://bugs.webkit.org/show_bug.cgi?id=105217
3303
3304         Reviewed by Dirk Pranke.
3305
3306         Previously --profile would fail strangely if find_unused_filename returned None
3307         (which would happen as soon as we had 100 report files).
3308         Now we'll search through 1000 filenames before giving up (and assert if we failed to find one).
3309         I also made some minor cleanups to the output of perf, and tried to make the
3310         commands more self-documenting by using long-names for args.
3311
3312         * Scripts/webkitpy/common/system/profiler.py:
3313         (SingleFileOutputProfiler.__init__):
3314         (Perf.attach_to_pid):
3315         (Perf.profile_after_exit):
3316
3317 2012-12-17  Sheriff Bot  <webkit.review.bot@gmail.com>
3318
3319         Unreviewed, rolling out r137198.
3320         http://trac.webkit.org/changeset/137198
3321         https://bugs.webkit.org/show_bug.cgi?id=105212
3322
3323         This patch is causing API behavior compatibility problems
3324         (Requested by zdobersek on #webkit).
3325
3326         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3327         (willSendRequestCallback):
3328
3329 2012-12-17  Elliott Sprehn  <esprehn@chromium.org>
3330
3331         Unreviewed. Adding myself to committers list.
3332
3333         * Scripts/webkitpy/common/config/committers.py:
3334
3335 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3336
3337         nrwt: shuffle code around for cleanup in run_webkit_tests.py
3338         https://bugs.webkit.org/show_bug.cgi?id=105078
3339
3340         Reviewed by Ojan Vafai.
3341
3342         This patch reorders functions so that run_webkit_tests can be
3343         understood in a top-down matter better, and to make things slightly
3344         more sensible when I merge manager.py into it.
3345
3346         Also, this adds tests for the actual main() routine, which had several
3347         bugs get through testing a week or two ago.
3348
3349         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3350         (main):
3351         (parse_args):
3352         (_set_up_derived_options):
3353         (run):
3354         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3355         (RunTest):
3356         (RunTest.test_no_http_tests):
3357         (PortTest.disabled_test_mac_lion):
3358         (MainTest):
3359         (MainTest.test_exception_handling):
3360         (MainTest.test_exception_handling.interrupting_run):
3361         (MainTest.test_exception_handling.successful_run):
3362         (MainTest.test_exception_handling.successful_run.FakeRunDetails):
3363         (MainTest.test_exception_handling.exception_raising_run):
3364
3365 2012-12-17  Dirk Pranke  <dpranke@chromium.org>
3366
3367         webkitpy: move --lint-test-files code into its own module
3368         https://bugs.webkit.org/show_bug.cgi?id=105077
3369
3370         Reviewed by Eric Seidel.
3371
3372         It really didn't need to be in run_webkit_tests.py anymore.
3373         This patch adds a new lint-test-expectations scripts to Tools/Scripts;
3374         rwt --lint-test-files is still supported for backwards compatibility
3375         for now.
3376
3377         * Scripts/lint-test-expectations: Added.
3378         * Scripts/webkitpy/layout_tests/lint_test_expectations.py: Added.
3379         (lint):
3380         (main):
3381         * Scripts/webkitpy/layout_tests/lint_test_expectations_unittest.py: Added.
3382         (FakePort):
3383         (FakePort.__init__):
3384         (FakePort.test_configuration):
3385         (FakePort.expectations_dict):
3386         (FakePort.skipped_layout_tests):
3387         (FakePort.all_test_configurations):
3388         (FakePort.configuration_specifier_macros):
3389         (FakePort.get_option):
3390         (FakeFactory):
3391         (FakeFactory.__init__):
3392         (FakeFactory.get):
3393         (FakeFactory.all_port_names):
3394         (LintTest):
3395         (LintTest.test_all_configurations):
3396         (LintTest.test_lint_test_files):
3397         (LintTest.test_lint_test_files__errors):
3398         (MainTest):
3399         (MainTest.test_success):
3400         (MainTest.test_success.interrupting_lint):
3401         (MainTest.test_success.successful_lint):
3402         (MainTest.test_success.exception_raising_lint):
3403         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3404         (main):
3405         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3406         (StreamTestingMixin.assertNotEmpty):
3407
3408 2012-12-17  Adam Klein  <adamk@chromium.org>
3409
3410         build-webkit: rename --template-tag to --template-element to match ENABLE #define name
3411         https://bugs.webkit.org/show_bug.cgi?id=105072
3412
3413         Reviewed by Laszlo Gombos.
3414
3415         * Scripts/webkitperl/FeatureList.pm:
3416
3417 2012-12-17  Julien Chaffraix  <jchaffraix@webkit.org>
3418
3419         Add some unit testing for WTF::clampTo* functions
3420         https://bugs.webkit.org/show_bug.cgi?id=105060
3421
3422         Reviewed by Emil A Eklund.
3423
3424         The new tests are targeted at clamping to int / unsigned and float as those are
3425         the one explicitely exposed through more dedicated functions (like clampToInteger,
3426         clampToPositiveInteger and clampToFloat).
3427
3428         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
3429
3430 2012-12-17  Eric Seidel  <eric@webkit.org>
3431
3432         rpt --profile --chromium-android throws exception
3433         https://bugs.webkit.org/show_bug.cgi?id=105061
3434
3435         Reviewed by Daniel Bates.
3436
3437         Somehow popen(args) got turned into popen(*args) at some point,
3438         which caused my new stringify code to fail when args was passed by name.
3439         Fixed and tested.
3440
3441         * Scripts/webkitpy/common/system/executive.py:
3442         (Executive._stringify_args):
3443         (Executive):
3444         (Executive.popen):
3445         * Scripts/webkitpy/common/system/executive_unittest.py:
3446         (ExecutiveTest.test_popen_args):
3447
3448 2012-12-17  Mark Pilgrim  <pilgrim@chromium.org>
3449
3450         Use Platform::current() instead of webKitPlatformSupport() in DumpRenderTree
3451         https://bugs.webkit.org/show_bug.cgi?id=105054
3452
3453         Reviewed by Jochen Eisinger.
3454
3455         Part of a refactoring series; see tracking bug 82948.
3456
3457         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3458         (NotificationPresenter::show):
3459         * DumpRenderTree/chromium/Task.cpp:
3460         (postTask):
3461         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp:
3462
3463 2012-12-17  Emil A Eklund  <eae@chromium.org>
3464
3465         Clamp values in LayoutUnit::operator/ when SATURATED_LAYOUT_ARITHMETIC is enabled
3466         https://bugs.webkit.org/show_bug.cgi?id=104955
3467
3468         Reviewed by Julien Chaffraix.
3469
3470         Add tests for LayoutUnit.
3471
3472         * TestWebKitAPI/CMakeLists.txt:
3473         * TestWebKitAPI/ForwardingHeaders: Added.
3474         * TestWebKitAPI/ForwardingHeaders/WebCore: Added.
3475         * TestWebKitAPI/ForwardingHeaders/WebCore/LayoutUnit.h: Added.
3476         * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
3477         * TestWebKitAPI/TestWebKitAPI.gypi:
3478         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3479         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp: Added.
3480         (TestWebKitAPI):
3481         (TestWebKitAPI::TEST):
3482         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3483
3484 2012-12-17  Jochen Eisinger  <jochen@chromium.org>
3485
3486         [chromium] removed unused preferences from testRunner.overridePreference
3487         https://bugs.webkit.org/show_bug.cgi?id=105169
3488
3489         Reviewed by Tony Chang.
3490
3491         Most notably this removes the code related to font family maps which is
3492         now handled via window.internals.settings
3493
3494         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3495         (WebPreferences):
3496         * DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
3497         (WebTestRunner::TestRunner::overridePreference):
3498         * DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
3499         (TestRunner):
3500         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3501         (WebTestRunner::WebPreferences::applyTo):
3502
3503 2012-12-17  James Robinson  <jamesr@chromium.org>
3504
3505         [chromium] Move creation of WebLayerTreeView to WebWidgetClient
3506         https://bugs.webkit.org/show_bug.cgi?id=105071
3507
3508         Reviewed by Adrienne Walker.
3509
3510         Update WebViewHost for the new WebWidgetClient interface.
3511
3512         * DumpRenderTree/chromium/WebViewHost.cpp:
3513         (WebViewHost::initializeLayerTreeView):
3514         (WebViewHost::layerTreeView):
3515         (WebViewHost::~WebViewHost):
3516         * DumpRenderTree/chromium/WebViewHost.h:
3517         (WebViewHost):
3518
3519 2012-12-17  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3520
3521         [EFL][WK2] window_create doesn't receive the url
3522         https://bugs.webkit.org/show_bug.cgi?id=105184
3523
3524         Reviewed by Alexis Menard.
3525
3526         * MiniBrowser/efl/main.c: Use the url supplied to window_create
3527         (on_window_create):
3528
3529 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3530
3531         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3532         https://bugs.webkit.org/show_bug.cgi?id=105026
3533
3534         Reviewed by Yury Semikhatsky.
3535
3536         Old SFINAE test was replaced with new one based on this article:
3537         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3538
3539         New test which covers this problem was added.
3540
3541         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3542
3543 2012-12-17  Anthony Scian  <ascian@rim.com>
3544
3545         [Blackberry] Static code analysis warning fixes
3546         https://bugs.webkit.org/show_bug.cgi?id=105129
3547
3548         Reviewed by Rob Buis.
3549
3550         Added null checks for fopen calls, no recovery attempted; access fault prevention only.
3551
3552         * DumpRenderTree/blackberry/DumpRenderTree.cpp:
3553         (BlackBerry::WebKit::createFile):
3554         (BlackBerry::WebKit::DumpRenderTree::runTest):
3555
3556 2012-12-17  John Mellor  <johnme@chromium.org>
3557
3558         Add Anton Vayvod and Tim Volodine as contributors in committers.py
3559         https://bugs.webkit.org/show_bug.cgi?id=105025
3560
3561         Unreviewed. Adds two contributors to committers.py.
3562         They are initially contributing to the Text Autosizing feature (master bug: 84186).
3563
3564         * Scripts/webkitpy/common/config/committers.py:
3565
3566 2012-12-17  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
3567
3568         Unreviewed, add myself to committers.py.
3569
3570         * Scripts/webkitpy/common/config/committers.py:
3571
3572 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3573
3574         [Qt] remove some unnecessary CONFIG additions
3575
3576         Reviewed by Simon Hausmann.
3577
3578         qt is already added by spec_pre.prf, warn_on and depend_includepath by
3579         default_pre.prf.
3580
3581         * qmake/mkspecs/features/default_post.prf:
3582
3583 2012-12-17  Ilya Tikhonovsky  <loislo@chromium.org>
3584
3585         Unreviewed, rolling out r137892.
3586         http://trac.webkit.org/changeset/137892
3587         https://bugs.webkit.org/show_bug.cgi?id=105026
3588
3589         it broke compilation on windows
3590
3591         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3592
3593 2012-12-14  Ilya Tikhonovsky  <loislo@chromium.org>
3594
3595         Web Inspector: Native Memory Instrumentation: MemoryInstrumentation doesn't detect reportMemoryUsage method defined in a base class.
3596         https://bugs.webkit.org/show_bug.cgi?id=105026
3597
3598         Reviewed by Yury Semikhatsky.
3599
3600         Old SFINAE test was replaced with new one based on this article:
3601         http://stackoverflow.com/questions/1966362/sfinae-to-check-for-inherited-member-functions
3602
3603         New test which covers this problem was added.
3604
3605         * TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp:
3606
3607 2012-12-17  Oswald Buddenhagen  <oswald.buddenhagen@digia.com>
3608
3609         [Qt] rely on automatic output directory setup
3610
3611         Reviewed by Simon Hausmann.
3612
3613         Now being a proper qt module (by virtue of having load(qt_build_config)
3614         in .qmake.conf), webkit gets the path setup goodies for free.
3615
3616         This also fixes Makefile.api.Debug/Release trying to generate qrc_WebKit.cpp
3617         at the same time, instead of the debug and release version ending up in different
3618         directories as they should.
3619
3620         * qmake/mkspecs/features/default_pre.prf:
3621
3622 2012-12-17  Charles Wei  <charles.wei@torchmobile.com.cn>
3623
3624         [BlackBerry] Need to re-enable video track
3625         https://bugs.webkit.org/show_bug.cgi?id=105155
3626
3627         Reviewed by George Staikos.
3628
3629         Just enable Video Track for BlackBerry.
3630
3631         * Scripts/webkitperl/FeatureList.pm:
3632
3633 2012-12-17  János Badics  <jbadics@inf.u-szeged.hu>
3634
3635         Unreviewed. Added myself to committers.py
3636
3637         * Scripts/webkitpy/common/config/committers.py:
3638
3639 2012-12-17  Jonathan Liu  <net147@gmail.com>
3640
3641         Fix linking of libraries with -Wl,-whole-archive
3642         https://bugs.webkit.org/show_bug.cgi?id=104436
3643
3644         Reviewed by Simon Hausmann.
3645
3646         If there is more than one library in LIBS linked with
3647         -Wl,-whole-archive -l... -Wl,-no-whole-archive, qmake tries to
3648         merge the duplicate flags in LIBS which causes linking to fail.
3649
3650         Add no_smart_library_merge to CONFIG to prevent the duplicate
3651         flags from being removed when using -Wl,-whole-archive.
3652
3653         * qmake/mkspecs/features/functions.prf:
3654
3655 2012-12-16  Arvid Nilsson  <anilsson@rim.com>
3656
3657         [BlackBerry] Adapt to new BlackBerry::Platform::TouchPoint API
3658         https://bugs.webkit.org/show_bug.cgi?id=105143
3659         RIM PR 171941
3660
3661         Reviewed by Rob Buis.
3662         Internally reviewed by George Staikos.
3663
3664         Adapt to new method names and encapsulation of TouchPoint data members.
3665
3666         * DumpRenderTree/blackberry/EventSender.cpp:
3667         (addTouchPointCallback):
3668         (updateTouchPointCallback):
3669         (touchEndCallback):
3670         (releaseTouchPointCallback):
3671         (sendTouchEvent):
3672
3673 2012-12-16  Maciej Stachowiak  <mjs@apple.com>
3674
3675         Add a script to compute the mean and 95% confidence interval (using two-sided t-test) of a sample set
3676         https://bugs.webkit.org/show_bug.cgi?id=105148
3677
3678         Reviewed by Filip Pizlo.
3679
3680         Usage examples:
3681
3682         $ sampstat --help
3683         Usage: sampstat [options] [FILES]
3684           Compute the mean and 95% confidence interval of a sample set.
3685           Standard input or files must contain two or more decimal numbers, one per line.
3686
3687         Options:
3688           -h, --help            show this help message and exit
3689           -u UNIT, --unit=UNIT  assume values are in units of UNIT
3690           -v, --verbose         print all values (with units)
3691
3692         $ sampstat -u MB memresults.txt
3693         2356.90 MB +/- 101.34 MB (4.3%)
3694
3695         $ sampstat -v -u MB memresults.txt
3696               2318.21 MB
3697               2399.56 MB
3698               2352.93 MB
3699         ----------------
3700         Mean: 2356.90 MB +/- 101.34 MB (4.3%)
3701
3702
3703         * Scripts/sampstat: Added.
3704         (sum): Helper function to compute the sum of a list.
3705         (arithmeticMean): Compute the meam of a list.
3706         (standardDeviation): Compute the sample standard deviation (unbiased estimator).
3707         (standardError): Compute the sample standard error.
3708         (tDist): Compute t(.025, n-1), the t-value for atwo-sided 95% confidence interval.
3709         (twoSidedConfidenceInterval): Compute the two-sided confidence interval range about the mean.
3710
3711 2012-12-15  Nima Ghanavatian  <nghanavatian@rim.com>
3712
3713         [BlackBerry] Pass key modifiers with touch and mouse events
3714         https://bugs.webkit.org/show_bug.cgi?id=105108
3715
3716         Reviewed by Rob Buis.
3717
3718         Update DRT to new api.
3719
3720         Internally reviewed by Gen Mak.
3721
3722         * DumpRenderTree/blackberry/EventSender.cpp:
3723         (mouseDownCallback):
3724         (mouseUpCallback):
3725         (mouseMoveToCallback):
3726
3727 2012-12-15  Zan Dobersek  <zandobersek@gmail.com>
3728
3729         Stop the XvfbDriver before proceeding with its starting setup
3730         https://bugs.webkit.org/show_bug.cgi?id=105006
3731
3732         Reviewed by Philippe Normand.
3733
3734         Just as with the base Driver implementation, stop the XvfbDriver
3735         before proceeding with setting up lock files and a new Xvfb instance.
3736         This forces any driver or Xvfb instances that are currently under
3737         the driver's control to be closed/killed and cleaned up after.
3738
3739         * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
3740         (XvfbDriver._start):
3741
3742 2012-12-14  Dirk Pranke  <dpranke@chromium.org>
3743
3744         webkitpy: make port_name a required parameter to the non-test ports
3745         https://bugs.webkit.org/show_bug.cgi?id=105057
3746
3747         Reviewed by Eric Seidel.
3748
3749         This is just minor code cleanup along the path to making Port
3750         constructors simpler and pushing more logic into the port factory.
3751
3752         * Scripts/webkitpy/layout_tests/port/base.py:
3753         (Port.__init__):
3754         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3755         (PortTest.make_port):
3756         * Scripts/webkitpy/layout_tests/port/port_testcase.py:
3757         (TestWebKitPort.__init__):
3758         * Scripts/webkitpy/layout_tests/port/test.py:
3759         (TestPort):
3760         (TestPort.determine_full_port_name):
3761         (TestPort.__init__):
3762         * Scripts/webkitpy/layout_tests/port/xvfbdriver_unittest.py:
3763         (XvfbDriverTest.make_driver):
3764         (XvfbDriverTest.test_stop):
3765
3766 2012-12-14  Dirk Pranke  <dpranke@chromium.org>
3767
3768         garden-o-matic doesn't know about reftests
3769         https://bugs.webkit.org/show_bug.cgi?id=101976
3770
3771         Reviewed by Eric Seidel.
3772
3773         Attempt to make garden-o-matic properly aware of reftests again.
3774
3775         This is re-landing r137407 with a change to
3776         rebaselineWithStatusUpdates() to actually pass the filtered
3777         failureInofLost to checkout.rebaseline().
3778
3779         Unfortunately, the testing coverage for this whole module is almost
3780         non-existent, and it's not obvious that there's a good way to
3781         stub out checkout.rebaseline() to test that the right thing
3782         happens. I verified the change manually.
3783
3784         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
3785         (.):
3786         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
3787         (.):
3788         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
3789
3790 2012-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3791
3792         "Running 1 DumpRenderTree over X shards" is not a helpful output
3793         https://bugs.webkit.org/show_bug.cgi?id=104858
3794
3795         Reviewed by Dirk Pranke.
3796
3797         The word "shard" is not typically used in test frameworks. This word is confusing for many WebKit
3798         contributors who typically don't have much experience on distributed computations and databases.
3799         So only print this message out in the debug mode.
3800
3801         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3802         * Scripts/webkitpy/layout_tests/views/printing.py:
3803         (Printer.print_workers_and_shards):
3804
3805 2012-12-13  Eric Seidel  <eric@webkit.org>
3806
3807         Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
3808         https://bugs.webkit.org/show_bug.cgi?id=104891
3809
3810         Reviewed by Ryosuke Niwa.
3811
3812         I also implemented a very simple "Sample" Profiler using
3813         Mac OS X's /usr/bin/sample command line tool.
3814
3815         The real reason for this abstraction is to make it easy
3816         to support both perf and pprof on linux which seem to
3817         be about equally popular among those I ask in the Chrome team.
3818
3819         * Scripts/webkitpy/common/system/profiler.py:
3820         (ProfilerFactory.create_profiler):
3821         (ProfilerFactory):
3822         (ProfilerFactory.available_profilers_by_name):
3823         (ProfilerFactory.default_profiler_name):
3824         (Sample):
3825         (Sample.__init__):
3826         (Sample.attach_to_pid):
3827         (Sample.profile_after_exit):
3828         (IProfiler.attach_to_pid):
3829         * Scripts/webkitpy/layout_tests/port/driver.py:
3830         (Driver.__init__):
3831         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
3832         (PerfTestsRunner._parse_args):
3833
3834 2012-12-13  Eric Seidel  <eric@webkit.org>
3835
3836         Unreviewed, fixing typo in python unittest.
3837
3838         I changed the default profiler on linux from pprof to perf in
3839         bug 104971.  I failed to update the unittest results at that time.
3840
3841         * Scripts/webkitpy/common/system/profiler_unittest.py:
3842         (ProfilerFactoryTest.test_basic):
3843
3844 2012-12-13  Ian Vollick  <vollick@chromium.org>
3845
3846         [chromium] Add a virtual test suite for enabling opt-in to composited scrolling
3847         https://bugs.webkit.org/show_bug.cgi?id=104911
3848
3849         Reviewed by Dirk Pranke.
3850
3851         Adds two virtual tests suites to run the tests in
3852         compositing/overflow/ and scrollbars/ with the flag
3853         --enable-accelerated-overflow-scroll, which I've also plumbed through
3854         in the usual way.
3855
3856         * DumpRenderTree/chromium/DumpRenderTree.cpp:
3857         (main):
3858         * DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:
3859         (WebPreferences):
3860         * DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:
3861         (WebTestRunner::WebPreferences::reset):
3862         (WebTestRunner::WebPreferences::applyTo):
3863         * DumpRenderTree/chromium/TestShell.cpp:
3864         (TestShell::TestShell):
3865         (TestShell::resetWebSettings):
3866         * DumpRenderTree/chromium/TestShell.h:
3867         (TestShell::setAcceleratedCompositingForOverflowScrollEnabled):
3868         (TestShell):
3869         * Scripts/webkitpy/layout_tests/port/chromium.py:
3870         (ChromiumPort.virtual_test_suites):
3871
3872 2012-12-13  Eric Seidel  <eric@webkit.org>
3873
3874         Use 'perf' to profile on linux instead of google-pprof by default
3875         https://bugs.webkit.org/show_bug.cgi?id=104971
3876
3877         Reviewed by Dirk Pranke.
3878
3879         This makes Chromium Linux match Chromium Android and use the perf
3880         tool by default.  Once https://bugs.webkit.org/show_bug.cgi?id=104891
3881         lands it will be possible to use pprof again on Linux.
3882
3883         This is slightly more advanced than the AndroidPerf profiler as
3884         instead of using a timeout on "perf record" I instead watch
3885         for the termination of the target process and then control-C
3886         the 'perf record' process.  This required me to add two new
3887         methods to Executive, one to have a limited-time wait() and
3888         the second to be able to send a control-C.  I chose to add
3889         these to Executive to make them easier to mock/fix-for-win32
3890         at a later time if needed.
3891
3892         * Scripts/webkitpy/common/system/executive.py:
3893         (Executive.wait_limited):
3894         (Executive.interrupt):
3895         * Scripts/webkitpy/common/system/profiler.py:
3896         (ProfilerFactory.create_profiler):
3897         (Perf):
3898         (Perf.__init__):
3899         (Perf._perf_path):
3900         (Perf.attach_to_pid):
3901         (Perf._first_ten_lines_of_profile):
3902         (Perf.profile_after_exit):
3903
3904 2012-12-13  Julie Parent  <jparent@chromium.org>
3905
3906         Dashboard cleanup: remove usage of global g_builders.
3907         https://bugs.webkit.org/show_bug.cgi?id=104941
3908
3909         Reviewed by Dirk Pranke.
3910
3911         The dashboards use a lot of global state, which makes hacking on them
3912         complicated. This change removes the use of one such global: g_builders.
3913         In most cases, we can just use currentBuilderGroup().builders instead,
3914         which is now currentBuilders().
3915         Surprisingly, the most changes were required to the unit tests, since
3916         they were even bigger offenders of bad hygiene, relying on global state
3917         set by other tests, randomly clobbering global variables in ways the
3918         real code doesn't, etc.
3919
3920         * TestResultServer/static-dashboards/builders.js:
3921         (BuilderGroup.prototype.setup):
3922         * TestResultServer/static-dashboards/dashboard_base.js:
3923         (.switch.return):
3924         (htmlForTestTypeSwitcher):
3925         * TestResultServer/static-dashboards/flakiness_dashboard.js:
3926         (generatePage):
3927         (getAllTestsTrie):
3928         (processTestRunsForAllBuilders):
3929         (showPopupForBuild):
3930         (generatePageForExpectationsUpdate):
3931         (loadExpectationsLayoutTests):
3932         * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
3933         (resetGlobals):
3934         (stubResultsByBuilder):
3935         (test):
3936         * TestResultServer/static-dashboards/loader.js:
3937         (.):
3938         * TestResultServer/static-dashboards/loader_unittests.js:
3939
3940 2012-12-13  Eric Seidel  <eric@webkit.org>
3941
3942         Callers should not have to stringify args before calling Executive run_command/popen
3943         https://bugs.webkit.org/show_bug.cgi?id=104975
3944
3945         Reviewed by Dirk Pranke.
3946
3947         One could argue that we should match the python call syntax here,
3948         but I think it's a more friendly API if we automagically handle
3949         stringification of args in run_command, etc.
3950         This removes map(unicode, args) from several callsites.
3951
3952         When I first tried to land this change, I didn't realize that
3953         Executive._command_for_printing depended on this behavior
3954         having been applied to args in run_command.  The fix is to
3955         call _stringify_args in both run_command and popen.
3956         This is slightly redundant, but given how short args have to be
3957         (due to shell limits), I don't think the double-encode check
3958         matters in practice.
3959
3960         This is slightly complicated by the fact that apache_http_server.py
3961         is the one caller in our codebase which uses shell=True.
3962         shell=True is a well-documented trail-of-tears:
3963         http://stackoverflow.com/questions/3172470/actual-meaning-of-shell-true-in-subprocess
3964         but to support this legacy (windows-only) code (which I can't easily test)
3965         I've added an if-hack to avoid stringifying the the popen(shell=True) case.
3966
3967         * Scripts/webkitpy/common/system/executive.py:
3968         (Executive.run_command):
3969         (Executive._stringify_args):
3970         (Executive.popen):
3971         * Scripts/webkitpy/common/system/executive_unittest.py:
3972         (ExecutiveTest.test_auto_stringify_args):
3973         * Scripts/webkitpy/layout_tests/port/chromium_android.py:
3974         (attach_to_pid):
3975
3976 2012-12-13  Adrienne Walker  <enne@chromium.org>
3977
3978         Unreviewed, rolling out r137645, r137646, and r137667.
3979         http://trac.webkit.org/changeset/137645
3980         http://trac.webkit.org/changeset/137646
3981         http://trac.webkit.org/changeset/137667
3982         https://bugs.webkit.org/show_bug.cgi?id=104911
3983
3984         Breaks some overflow layout tests
3985
3986         * Scripts/webkitpy/layout_tests/port/chromium.py:
3987         (ChromiumPort.virtual_test_suites):
3988
3989 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
3990
3991         Unreviewed, rolling out r137661.
3992         http://trac.webkit.org/changeset/137661
3993         https://bugs.webkit.org/show_bug.cgi?id=104891
3994
3995         broke unit tests, run-webkit-tests
3996
3997         * Scripts/webkitpy/common/system/executive.py:
3998         (Executive._run_command_with_teed_output):
3999         (Executive.run_command):
4000         (Executive.popen):
4001         * Scripts/webkitpy/common/system/profiler.py:
4002         (ProfilerFactory.create_profiler):
4003         (GooglePProf.profile_after_exit):
4004         (IProfiler.attach_to_pid):
4005         * Scripts/webkitpy/layout_tests/port/driver.py:
4006         (Driver.__init__):
4007         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4008         (PerfTestsRunner._parse_args):
4009
4010 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
4011
4012         nrwt: move rundetails, summarize_results into test_run_results
4013         https://bugs.webkit.org/show_bug.cgi?id=104963
4014
4015         Reviewed by Eric Seidel.
4016
4017         More cleanup; this the plain-old-data functions out of manager.py
4018         and into test_run_results next to the other aggregate data structures.
4019
4020         Also this cleans up a bunch of test code and reduces duplication.
4021
4022         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4023         (Manager.run):
4024         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4025         (ManagerTest.test_look_for_new_crash_logs):
4026         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
4027         (TestRunResults.__init__):
4028         (TestRunResults.add):
4029         (RunDetails):
4030         (RunDetails.__init__):
4031         (_interpret_test_failures):
4032         (summarize_results):
4033         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: Added.
4034         (get_result):
4035         (run_results):
4036         (summarized_results):
4037         (InterpretTestFailuresTest):
4038         (InterpretTestFailuresTest.setUp):
4039         (InterpretTestFailuresTest.test_interpret_test_failures):
4040         (SummarizedResultsTest):
4041         (SummarizedResultsTest.setUp):
4042         (SummarizedResultsTest.test_no_svn_revision):
4043         (SummarizedResultsTest.test_svn_revision):
4044         (SummarizedResultsTest.test_summarized_results_wontfix):
4045         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
4046         (BuildBotPrinterTests.get_printer):
4047         (BuildBotPrinterTests.test_print_unexpected_results):
4048         (BuildBotPrinterTests.test_print_results):
4049
4050 2012-12-13  Eric Seidel  <eric@webkit.org>
4051
4052         Make --profile output easier to understand for pprof on linux
4053         https://bugs.webkit.org/show_bug.cgi?id=104957
4054
4055         Reviewed by Dirk Pranke.
4056
4057         pprof is kinda mysterious, so we print some information
4058         on how to use it, and how to learn how to read the sample dump.
4059         This is similar to what we've done for perf output for Chromium Android.
4060
4061         * Scripts/webkitpy/common/system/profiler.py:
4062         (GooglePProf._pprof_path):
4063         (GooglePProf.profile_after_exit):
4064
4065 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
4066
4067         Revert r137407 - it didn't actually work right.
4068         https://bugs.webkit.org/show_bug.cgi?id=101976
4069
4070         Unreviewed, build fix.
4071
4072         Turns out that rebaselining was completely broken with this change :(
4073         We're passing in a list of test names rather than the list of
4074         failureInfo objects.
4075
4076         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
4077         (.):
4078         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
4079         (.):
4080         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
4081
4082 2012-12-13  Antoine Labour  <piman@chromium.org>
4083
4084         [chromium] Small fixes for WebPluginContainer::setWebLayer
4085         https://bugs.webkit.org/show_bug.cgi?id=104953
4086
4087         Reviewed by James Robinson.
4088
4089         * DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Clean up
4090         dangling pointers, force correct invalidation of the layer.
4091
4092 2012-12-13  Eric Seidel  <eric@webkit.org>
4093
4094         Add --profiler=PROFILER option to run-perf-tests to allow specifying which profiler to use on platforms with many
4095         https://bugs.webkit.org/show_bug.cgi?id=104891
4096
4097         Reviewed by Dirk Pranke.
4098
4099         I also implemented a very simple "Sample" Profiler using
4100         Mac OS X's /usr/bin/sample command line tool.
4101
4102         I also moved the map(unicode, args) call into Executive.popen
4103         so that all callers don't have to do it themselves.
4104
4105         The real reason for this abstraction is to make it easy
4106         to support both perf and pprof on linux which seem to
4107         be about equally popular among those I ask in the Chrome team.
4108
4109         * Scripts/webkitpy/common/system/executive.py:
4110         (Executive.popen):
4111         * Scripts/webkitpy/common/system/profiler.py:
4112         (ProfilerFactory.create_profiler):
4113         (ProfilerFactory):
4114         (ProfilerFactory.available_profilers_by_name):
4115         (ProfilerFactory.default_profiler_name):
4116         (Sample):
4117         (Sample.__init__):
4118         (Sample.attach_to_pid):
4119         (Sample.profile_after_exit):
4120         (IProfiler.attach_to_pid):
4121         * Scripts/webkitpy/layout_tests/port/driver.py:
4122         (Driver.__init__):
4123         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
4124         (PerfTestsRunner._parse_args):
4125
4126 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
4127
4128         support -wk2 port names properly in webkitpy.layout_tests.port
4129         https://bugs.webkit.org/show_bug.cgi?id=104761
4130
4131         Reviewed by Eric Seidel.
4132
4133         Our support for WK2 port names was inconsistent at best; this patch
4134         modifies the code so that <port_name>-wk2 is supported for all ports that
4135         have WK2 implementations and is equivalent to specifying <port_name>
4136         and -2/--webkit-test-runner. In addition, this modifies
4137         builders.all_port_names() to include the wk2 variants.
4138
4139         * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
4140         * Scripts/webkitpy/layout_tests/port/apple.py:
4141         (ApplePort.determine_full_port_name):
4142         * Scripts/webkitpy/layout_tests/port/base.py:
4143         (Port.determine_full_port_name):
4144         (Port.__init__):
4145         * Scripts/webkitpy/layout_tests/port/builders.py:
4146         * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
4147         (DriverTest.make_port):
4148         * Scripts/webkitpy/layout_tests/port/mac.py:
4149         (MacPort.default_baseline_search_path):
4150         * Scripts/webkitpy/layout_tests/port/win.py:
4151         (WinPort.default_baseline_search_path):
4152         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
4153         (TestRebaselineExpectations.test_rebaseline_expectations):
4154
4155 2012-12-13  Ian Vollick  <vollick@chromium.org>
4156
4157         [chromium] Add a virtual test suite for enabling opt-in to composited scrolling
4158         https://bugs.webkit.org/show_bug.cgi?id=104911
4159
4160         Reviewed by Adrienne Walker.
4161
4162         Adds two virtual tests suites to run the tests in
4163         compositing/overflow/ and scrollbars/ with the flag
4164         --enable-accelerated-compositing-for-overflow-scroll
4165
4166         * Scripts/webkitpy/layout_tests/port/chromium.py:
4167         (ChromiumPort.virtual_test_suites):
4168
4169 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
4170
4171         delete extraneous self.fail in mastercfg_unittest.py
4172         https://bugs.webkit.org/show_bug.cgi?id=104940
4173
4174         Reviewed by Eric Seidel.
4175
4176         This was accidentally introduced in r137404.
4177
4178         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4179
4180 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
4181
4182         Fix a mis-named variable after r137621.
4183         https://bugs.webkit.org/show_bug.cgi?id=104871
4184
4185         Unreviewed, build fix.
4186
4187         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
4188         (BuildBotPrinter.print_results):
4189         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
4190
4191 2012-12-13  Dirk Pranke  <dpranke@chromium.org>
4192
4193         webkitpy: rename ResultSummary
4194         https://bugs.webkit.org/show_bug.cgi?id=104871
4195
4196         Reviewed by Eric Seidel.
4197
4198         This patch changes the names of ResultSummary and related modules,
4199         classes, and variables as a part of the larger clean up in bug 103824.
4200
4201         This change is basically a bunch of search and replaces:
4202         - result_summary.py -> test_run_results.py
4203         - class ResultSummary -> class TestRunResults
4204         - "result_summary" or "rs" as a generic variable name -> "run_results",
4205           when it doesn't matter (or we don't know) if this refers to the
4206           initial pass over the tests or the retry pass.
4207         - "result_summary" as a variable containing the results of the initial,
4208           complete test run -> "initial_results"
4209         - "retry_summary" as a variable containing the results of retried
4210           results -> "retry_results"
4211         - ResultSummary.results (the property) -> TestRunResults.results_by_name
4212         - ResultSummary.failures (the property) -> TestRunResults.failures_by_name
4213         - RunDetails.result_summary -> RunDetails.initial_results
4214         - RunDetails.retry_summary -> RunDetails.retry_results
4215
4216         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
4217         (LayoutTestRunner.__init__):
4218         (LayoutTestRunner.run_tests):
4219         (LayoutTestRunner._mark_interrupted_tests_as_skipped):
4220         (LayoutTestRunner._interrupt_if_at_failure_limits):
4221         (LayoutTestRunner._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
4222         (LayoutTestRunner._update_summary_with_result):
4223         (LayoutTestRunner._handle_finished_test):
4224         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
4225         (FakePrinter.print_expected):
4226         (LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):
4227         (LayoutTestRunnerTests.test_update_summary_with_result):
4228         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4229         (RunDetails.__init__):
4230         (summarize_results):
4231         (Manager.run):
4232         (Manager._look_for_new_crash_logs):
4233         (Manager._tests_to_retry):
4234         (Manager._upload_json_files):
4235         (Manager._stats_trie):
4236         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4237         (ManagerTest.test_look_for_new_crash_logs):
4238         (SummarizeResultsTest):
4239         (SummarizeResultsTest.get_run_results):
4240         (SummarizeResultsTest.summarized_results):
4241         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
4242         (JSONLayoutResultsGenerator.__init__):
4243         (JSONLayoutResultsGenerator._get_modifier_char):
4244         (JSONLayoutResultsGenerator._insert_failure_summaries):
4245         (JSONLayoutResultsGenerator._get_failure_summary_entry):
4246         * Scripts/webkitpy/layout_tests/models/test_run_results.py: Renamed from Tools/Scripts/webkitpy/layout_tests/models/result_summary.py.
4247         (TestRunResults):
4248         (TestRunResults.__init__):
4249         (TestRunResults.add):
4250         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4251         (get_test_results):
4252         (MainTest.test_basic):
4253         * Scripts/webkitpy/layout_tests/views/buildbot_results.py:
4254         (BuildBotPrinter.print_results):
4255         (BuildBotPrinter.print_run_results):
4256         (BuildBotPrinter._print_run_results_entry):
4257         * Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py:
4258         (BuildBotPrinterTests.get_run_results):
4259         (BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):
4260         (BuildBotPrinterTests):
4261         * Scripts/webkitpy/layout_tests/views/printing.py:
4262         (Printer.print_expected):
4263         (Printer._print_expected_results_of_type):
4264         (Printer.print_results):
4265         (Printer._print_timing_statistics):
4266         (Printer._print_worker_statistics):
4267         (Printer._print_aggregate_test_statistics):
4268         (Printer._print_individual_test_times):
4269         (Printer._print_directory_timings):
4270         * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
4271
4272 2012-12-13  Thiago Marcos P. Santos  <thiago.santos@intel.com>
4273
4274         [EFL] The WebKit2 bots are building and executing WebKit1 tests
4275         https://bugs.webkit.org/show_bug.cgi?id=104690
4276
4277         Reviewed by Csaba Osztrogonác.
4278
4279         Pass --no-webkit1 option to the EFL WK2 bots when building. This
4280         will disable WK1 API and thus, the WK1 API tests.
4281
4282         * BuildSlaveSupport/build.webkit.org-config/config.json:
4283         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4284         (CompileWebKit2Only):
4285         (BuildAndTestFactory):