711dc2de75f3e9884d5ade74b2ac8e8ac25d3a2b
[WebKit-https.git] / Tools / ChangeLog
1 2020-03-20  Alex Christensen  <achristensen@webkit.org>
2
3         CORS-disabling SPI introduced in r253978 should make responses non-opaque
4         https://bugs.webkit.org/show_bug.cgi?id=209351
5         <rdar://problem/60024850>
6
7         Reviewed by Chris Dumez.
8
9         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
10
11 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
12
13         commit-queue should skip building and testing if patch already passed tests on mac-wk2 queue
14         https://bugs.webkit.org/show_bug.cgi?id=208938
15
16         Reviewed by Jonathan Bedard.
17
18         * BuildSlaveSupport/ews-build/steps.py:
19         (RunWebKitTests.doStepIf): Skip testing if patch already passed mac-wk2 tests.
20         (CheckPatchStatusOnEWSQueues): Build-step to check patch status on other queues.
21         (CheckPatchStatusOnEWSQueues.get_patch_status):
22         (CheckPatchStatusOnEWSQueues.start):
23         * BuildSlaveSupport/ews-build/steps_unittest.py:
24         (test_skip_for_mac_wk2_passed_patch_on_commit_queue): Added unit-tests.
25         * BuildSlaveSupport/ews-build/factories.py: Added build-step to check the patch status on other queues.
26         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
27         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py: Added the new step status to STEPS_TO_HIDE.
28
29 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
30
31         [ews] Better organize patch status api data
32         https://bugs.webkit.org/show_bug.cgi?id=209342
33
34         Reviewed by Jonathan Bedard.
35
36         * BuildSlaveSupport/ews-app/ews/views/status.py:
37         (Status._build_status):
38         (Status._build_statuses_for_patch): Updated to return dictionary instead of list.
39         (Status.get): Remove safe=false now that we are returning a dictionary.
40
41 2020-03-20  Tim Horton  <timothy_horton@apple.com>
42
43         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
44         https://bugs.webkit.org/show_bug.cgi?id=209307
45
46         Reviewed by Andy Estes.
47
48         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
49
50 2020-03-20  Jacob Uphoff  <jacob_uphoff@apple.com>
51
52         Unreviewed, reverting r258748.
53
54         This commit broke the Catalina build
55
56         Reverted changeset:
57
58         "Upstream a variety of Cocoa-platform HAVE and ENABLE macros"
59         https://bugs.webkit.org/show_bug.cgi?id=209307
60         https://trac.webkit.org/changeset/258748
61
62 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
63
64         [ews] commit-queue should comment on bug if patch fails to apply
65         https://bugs.webkit.org/show_bug.cgi?id=209334
66
67         Reviewed by Jonathan Bedard.
68
69         * BuildSlaveSupport/ews-build/steps.py:
70         (ApplyPatch):
71         (ApplyPatch.evaluateCommand): Overridden to check build status and queue name and comment on bug accordingly.
72         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
73         (TestApplyPatch):
74         (TestApplyPatch.setUp):
75         (TestApplyPatch.setUp.mock_start):
76         (TestApplyPatch.tearDown):
77         (TestApplyPatch.test_success):
78         (TestApplyPatch.test_failure):
79         (TestApplyPatch.test_failure_on_commit_queue):
80
81 2020-03-20  Aakash Jain  <aakash_jain@apple.com>
82
83         [EWS] Limit number of builds to display in status-bubble hover over message in case of lot of retried builds
84         https://bugs.webkit.org/show_bug.cgi?id=209122
85
86         Reviewed by Jonathan Bedard.
87
88         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
89         (StatusBubble._build_bubble):
90
91 2020-03-19  Tim Horton  <timothy_horton@apple.com>
92
93         Upstream a variety of Cocoa-platform HAVE and ENABLE macros
94         https://bugs.webkit.org/show_bug.cgi?id=209307
95
96         Reviewed by Andy Estes.
97
98         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
99
100 2020-03-19  Alex Christensen  <achristensen@webkit.org>
101
102         Remove test failing after r258734
103         https://bugs.webkit.org/show_bug.cgi?id=209303
104
105         We removed the functionality it was testing because it did nothing useful except call the callback.
106         I'm about to remove the only user of WKContextGetStatistics.
107
108         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
109         * TestWebKitAPI/Tests/WebKit/WebCoreStatisticsWithNoWebProcess.cpp: Removed.
110
111 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
112
113         commit-queue status-bubble shows incorrect position in queue
114         https://bugs.webkit.org/show_bug.cgi?id=209313
115
116         Reviewed by Jonathan Bedard.
117
118         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
119         (StatusBubble._queue_position):
120
121 2020-03-19  Takashi Komori  <Takashi.Komori@sony.com>
122
123         [Curl] Add an API returns description of verification errors.
124         https://bugs.webkit.org/show_bug.cgi?id=208913
125
126         Reviewed by Fujii Hironori.
127
128         WKCertificateInfoCopyVerificationErrorDescription returns the description of SSL verification error as human readable string.
129         Browser can display more precise error information with this API.
130
131         API Test: Curl.CertificateAPI
132
133         * MiniBrowser/win/Common.cpp:
134         (askServerTrustEvaluation):
135         * MiniBrowser/win/Common.h:
136         * MiniBrowser/win/WebKitBrowserWindow.cpp:
137         (createPEMString):
138         (WebKitBrowserWindow::canTrustServerCertificate):
139         * TestWebKitAPI/Tests/WebKit/curl/Certificates.cpp:
140         (TestWebKitAPI::Curl::TEST):
141
142 2020-03-19  Aakash Jain  <aakash_jain@apple.com>
143
144         Update build.webkit.org link for EWS
145         https://bugs.webkit.org/show_bug.cgi?id=209280
146
147         Reviewed by Alexey Proskuryakov.
148
149         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
150
151 2020-03-19  Stephan Szabo  <stephan.szabo@sony.com>
152
153         [WinCairo] extract-built-product fails after r258612
154         https://bugs.webkit.org/show_bug.cgi?id=209285
155
156         extractBuiltProduct also references the old name for the
157         requirements on wincairo.
158
159         Reviewed by Ross Kirsling.
160
161         * BuildSlaveSupport/built-product-archive:
162
163 2020-03-19  Philippe Normand  <pnormand@igalia.com>
164
165         [Flatpak SDK] Release logs not sent to journald when running within the SDK runtime
166         https://bugs.webkit.org/show_bug.cgi?id=209223
167
168         Reviewed by Carlos Alberto Lopez Perez.
169
170         flatpak build doesn't expose a --socket option for white-listing
171         the systemd journal socket. So white-list everything in /run. 🤷
172
173         * flatpak/flatpakutils.py:
174         (WebkitFlatpak.run_in_sandbox):
175
176 2020-03-19  Charlie Turner  <cturner@igalia.com>
177
178         Fix many warnings with Clang 7.0 on GTK x86-64 in Debug.
179         https://bugs.webkit.org/show_bug.cgi?id=209146
180
181         Reviewed by Darin Adler.
182
183         * TestWebKitAPI/Tests/WebCore/TransformationMatrix.cpp:
184         (TestWebKitAPI::TEST):
185         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
186         * TestWebKitAPI/Tests/WebKitGLib/TestDownloads.cpp:
187         (testDownloadMIMEType):
188         (testContextMenuDownloadActions):
189         * TestWebKitAPI/Tests/WebKitGtk/TestPrinting.cpp:
190
191 2020-03-19  Carlos Garcia Campos  <cgarcia@igalia.com>
192
193         [GTK][WPE] REGRESSION(r258626): flatpak is used even when WEBKIT_JHBUILD is set
194         https://bugs.webkit.org/show_bug.cgi?id=209278
195
196         Reviewed by Philippe Normand.
197
198         This happens when using an external jhbuild, because shouldUseFlatpak() assumes that no command prefix always
199         means flatpak.
200
201         * Scripts/webkitdirs.pm:
202         (shouldUseFlatpak): Return early if WEBKIT_JHBUILD is set.
203
204 2020-03-19  Philippe Normand  <pnormand@igalia.com>
205
206         [CMake] cache not cleared when build-webkit options change
207         https://bugs.webkit.org/show_bug.cgi?id=209277
208
209         Reviewed by Adrian Perez de Castro.
210
211         * Scripts/webkitdirs.pm:
212         (shouldRemoveCMakeCache): The expected function signature never
213         included the cache file path. Remove it.
214
215 2020-03-18  Philippe Normand  <pnormand@igalia.com>
216
217         REGRESSION(r258626): webkit-dirs warning
218         https://bugs.webkit.org/show_bug.cgi?id=209221
219
220         Reviewed by Adrian Perez de Castro.
221
222         * Scripts/webkitdirs.pm:
223         (buildCMakeProjectOrExit): Fix Perl Warning. 😎
224
225 2020-03-19  Chris Lord  <clord@igalia.com>
226
227         Add Chris Lord (clord@igalia.com) to the list of contributors
228         https://bugs.webkit.org/show_bug.cgi?id=209274
229
230         Unreviewed
231
232         * Scripts/webkitpy/common/config/contributors.json:
233
234 2020-03-19  Ryan Haddad  <ryanhaddad@apple.com>
235
236         Remove commit queue bubble from bot watchers dashboard
237         https://bugs.webkit.org/show_bug.cgi?id=209271
238
239         Reviewed by Alexey Proskuryakov.
240
241         Remove commit queue bubble from bot watchers dashboard now that it has moved to the new EWS.
242
243         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
244         (BubbleQueueServer): 
245
246 2020-03-18  Simon Fraser  <simon.fraser@apple.com>
247
248         eventSender.monitorWheelEvents() is very fragile
249         https://bugs.webkit.org/show_bug.cgi?id=197819
250         <rdar://problem/51319456>
251
252         Reviewed by Tim Horton.
253
254         Deflake tests using eventSender.monitorWheelEvents() by fixing several causes of flakiness,
255         adding back changes from r257844 that were reverted in r258558.
256         
257         First, have EventSendingController keep track of whether it's seen then "end" event
258         for the scrolling and momentum phases, and pass this down to WheelEventTestMonitor, which
259         now waits until it sees these, which prevents premature triggering which was a common cause of
260         failure before.
261         
262         Second, remove WheelEventTestMonitor's 1/60s timer and instead have WheelEventTestMonitor test
263         for completion in a callout from the end of Page::updateRendering(), which makes it test
264         and fire at a more consistent time.
265         
266         Third, push WheelEventTestMonitor to the ScrollingTree, so that reasons for deferral
267         can be added on the scrolling thread. This fixes an issue where the RunLoop::main().dispatch()
268         used to send the "ScrollingThreadSyncNeeded" reason to the main thread would get delayed,
269         also resulting in a premature trigger.
270
271         * DumpRenderTree/mac/EventSendingController.h:
272         * DumpRenderTree/mac/EventSendingController.mm:
273         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
274         (-[EventSendingController monitorWheelEvents]):
275         (-[EventSendingController callAfterScrollingCompletes:]):
276         * DumpRenderTree/win/EventSender.cpp:
277         (mouseScrollBy):
278         * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
279         (WTR::EventSendingController::mouseScrollByWithWheelAndMomentumPhases):
280         (WTR::EventSendingController::monitorWheelEvents):
281         (WTR::EventSendingController::callAfterScrollingCompletes):
282         * WebKitTestRunner/InjectedBundle/EventSendingController.h:
283
284 2020-03-18  John Wilander  <wilander@apple.com>
285
286         WebResourceLoadStatisticsStore::requestStorageAccessUnderOpener() should call its ephemeral counterpart when appropriate
287         https://bugs.webkit.org/show_bug.cgi?id=209245
288         <rdar://problem/60511121>
289
290         Reviewed by Chris Dumez.
291
292         These changes to the TestRunner makes sure that
293         - statisticsClearInMemoryAndPersistentStore()
294         - statisticsClearInMemoryAndPersistentStoreModifiedSinceHours()
295         ... use their own StatisticsDidClearInMemoryAndPersistentStoreCallbackID
296         and adds the infrastructure for that.
297
298         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
299         (WTR::InjectedBundle::didReceiveMessageToPage):
300         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
301         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
302         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
303         (WTR::TestRunner::statisticsCallClearInMemoryAndPersistentStoreCallback):
304         * WebKitTestRunner/InjectedBundle/TestRunner.h:
305         * WebKitTestRunner/TestController.cpp:
306         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
307         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
308         * WebKitTestRunner/TestInvocation.cpp:
309         (WTR::TestInvocation::didClearStatisticsInMemoryAndPersistentStore):
310         * WebKitTestRunner/TestInvocation.h:
311
312 2020-03-18  Wenson Hsieh  <wenson_hsieh@apple.com>
313
314         REGRESSION (r257214): Targeted preview animates to the wrong place when dropping in editable content
315         https://bugs.webkit.org/show_bug.cgi?id=209218
316         <rdar://problem/60560831>
317
318         Reviewed by Tim Horton.
319
320         Augment the drag and drop test harness to verify that for all targeted previews, if they have container views,
321         those views must be parented (i.e. they must be connected to a UIWindow).
322
323         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
324         (-[DragAndDropSimulator _concludeDropAndPerformOperationIfNecessary]):
325         (-[DragAndDropSimulator _expectNoDropPreviewsWithUnparentedContainerViews]):
326         (-[DragAndDropSimulator _invokeDropAnimationCompletionBlocksAndConcludeDrop]):
327
328 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
329
330         [ews] commit-queue should comment on bug in case of test failures
331         https://bugs.webkit.org/show_bug.cgi?id=209226
332
333         Reviewed by Jonathan Bedard.
334
335         * BuildSlaveSupport/ews-build/steps.py:
336         (AnalyzeLayoutTestsResults.report_failure): Comment on bug and set cq- in case of test failure on commit-queue.
337         (BuildLogLineObserver.outLineReceived): Drive-by fix to use single quotes instead of double quotes.
338         (SetBuildSummary): Ditto.
339         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
340
341 2020-03-18  Philippe Normand  <pnormand@igalia.com>
342
343         REGRESSION (r258626): test262 tests failing to run on macOS with error 'Undefined subroutine &Test262::Runner::setConfiguration'
344         https://bugs.webkit.org/show_bug.cgi?id=209238
345
346         Reviewed by Jonathan Bedard.
347
348         * Scripts/test262-runner: Perform the flatpak check on Linux only.
349
350 2020-03-18  Stephan Szabo  <stephan.szabo@sony.com>
351
352         [WinCairo] archive-built-product fails after r258612
353         https://bugs.webkit.org/show_bug.cgi?id=209237
354
355         Reviewed by Alex Christensen.
356
357         * BuildSlaveSupport/built-product-archive:
358         Update name of version file for requirements version
359         file for wincairo.
360
361 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
362
363         commit-queue should allow patches which are reviewed by patch author
364         https://bugs.webkit.org/show_bug.cgi?id=209231
365
366         Reviewed by Jonathan Bedard.
367
368         * BuildSlaveSupport/ews-build/steps.py:
369         (BugzillaMixin._does_patch_have_acceptable_review_flag):
370
371 2020-03-18  Philippe Normand  <pnormand@igalia.com>
372
373         [JHBuild] Flatpak used for run-minibrowser even when forcing jhbuild
374         https://bugs.webkit.org/show_bug.cgi?id=209222
375
376         Reviewed by Carlos Alberto Lopez Perez.
377
378         * Scripts/webkitdirs.pm:
379         (runInFlatpakIfAvailable): If a command wrapper is required it
380         means Flatpak shouldn't be used.
381
382 2020-03-18  Aakash Jain  <aakash_jain@apple.com>
383
384         [ews] commit-queue should comment on bug in case patch fails to build
385         https://bugs.webkit.org/show_bug.cgi?id=209227
386
387         Reviewed by Jonathan Bedard.
388
389         * BuildSlaveSupport/ews-build/steps.py:
390         (AnalyzeCompileWebKitResults.start):
391         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
392
393 2020-03-18  Philippe Normand  <pnormand@igalia.com>
394
395         [GTK][WPE] Migrate to Flatpak-based dev SDK
396         https://bugs.webkit.org/show_bug.cgi?id=205658
397
398         Reviewed by Carlos Alberto Lopez Perez.
399
400         JHBuild will now be used only if the WEBKIT_JHBUILD environment
401         variable is set to 1, which is the case for the time being on the
402         GTK and WPE EWS/build bots.
403
404         By default the build dependencies are now locally installed from a
405         Flatpak repository hosted at https://software.igalia.com. The
406         repository can be regenerated with the scripts from the
407         webkit-flatpak-sdk Github project
408         (https://github.com/Igalia/webkit-flatpak-sdk). This is done
409         transparently with the update-webkit{gtk,wpe}-libs scripts. As
410         there is no need to rebuild the dependencies from scratch, the
411         developer user-experience should now be much more friendly and
412         overall build times reduced.
413
414         As an additional commodity, the new environment supports the
415         GStreamer gst-build-based workflow. Just set the GST_BUILD_PATH
416         environment variable to your gst-build path. This feature was
417         contributed by Thibault Saunier.
418
419         The JHBuild infrastructure will be removed once all the bots have
420         been switched over to Flatpak.
421
422         * BuildSlaveSupport/ews-build/steps.py:
423         (InstallGtkDependencies):
424         (InstallWpeDependencies):
425         (CompileWebKit.start):
426         * BuildSlaveSupport/gtk/buildbot/run:
427         * Scripts/build-webkit:
428         * Scripts/run-bindings-tests:
429         * Scripts/run-builtins-generator-tests:
430         * Scripts/run-gtk-tests:
431         * Scripts/run-javascriptcore-tests:
432         * Scripts/run-minibrowser:
433         * Scripts/run-qt-wpe-minibrowser:
434         * Scripts/run-webdriver-tests:
435         * Scripts/run-wpe-tests:
436         * Scripts/test-webkitperl:
437         * Scripts/test-webkitpy:
438         * Scripts/test262-runner:
439         * Scripts/update-webkit-flatpak: Renamed from Tools/Scripts/update-webkitgtk-flatpak.
440         * Scripts/update-webkitgtk-libs:
441         * Scripts/update-webkitwpe-flatpak: Removed.
442         * Scripts/update-webkitwpe-libs:
443         * Scripts/webkitdirs.pm:
444         (getUserFlatpakPath):
445         (inFlatpakSandbox):
446         (runInFlatpakIfAvailable):
447         (wrapperPrefixIfNeeded):
448         (shouldUseJhbuild):
449         (shouldUseFlatpak):
450         (shouldRemoveCMakeCache):
451         * Scripts/webkitpy/common/system/executive.py:
452         (Executive.kill_all):
453         * Scripts/webkitpy/port/base.py:
454         (Port._path_to_apache):
455         (Port._should_run_as_pixel_test):
456         (Port._in_flatpak_sandbox):
457         * Scripts/webkitpy/port/gtk.py:
458         (GtkPort.setup_environ_for_server):
459         (GtkPort._get_crash_log):
460         * Scripts/webkitpy/port/linux_get_crash_log.py:
461         (GDBCrashLogGenerator):
462         (GDBCrashLogGenerator.__init__):
463         (GDBCrashLogGenerator.generate_crash_log):
464         * Scripts/webkitpy/port/linux_get_crash_log_unittest.py:
465         (GDBCrashLogGeneratorTest.test_generate_crash_log):
466         * Scripts/webkitpy/port/wpe.py:
467         (WPEPort.setup_environ_for_server):
468         (WPEPort._get_crash_log):
469         * Scripts/webkitpy/port/xvfbdriver.py:
470         (XvfbDriver._setup_environ_for_test):
471         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
472         (WTR::getFontsPath):
473         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
474         (WTR::getFontsPath):
475         * flatpak/files/default.xkm: Removed.
476         * flatpak/files/httpd-autogen.sh: Removed.
477         * flatpak/flatpakutils.py:
478         (check_flatpak):
479         (FlatpakRepos.update):
480         (FlatpakPackage.__repr__):
481         (FlatpakPackage.__str__):
482         (WebkitFlatpak.load_from_args):
483         (WebkitFlatpak.__init__):
484         (WebkitFlatpak.clean_args):
485         (WebkitFlatpak.setup_builddir):
486         (WebkitFlatpak):
487         (WebkitFlatpak.setup_gstbuild):
488         (WebkitFlatpak.run_in_sandbox):
489         (WebkitFlatpak.run):
490         (WebkitFlatpak.has_environment):
491         (WebkitFlatpak.save_config):
492         (WebkitFlatpak.setup_dev_env):
493         (WebkitFlatpak.install_all):
494         (WebkitFlatpak.run_gdb):
495         * flatpak/org.webkit.CommonModules.yaml: Removed.
496         * flatpak/org.webkit.GTK.yaml: Removed.
497         * flatpak/org.webkit.WPE.yaml: Removed.
498         * flatpak/org.webkit.WPEModules.yaml: Removed.
499         * flatpak/org.webkit.WPEQT.yaml: Removed.
500         * flatpak/org.webkit.WebKit.yaml: Removed.
501         * flatpak/patches/httpd-0001-configure-use-pkg-config-for-PCRE-detection.patch: Removed.
502         * flatpak/patches/libgcrypt-0001-Use-pkg-config-to-detect-gpg-error.patch: Removed.
503         * flatpak/patches/xvfb-0001-HACK-Avoid-compiling-a-kbm-file.patch: Removed.
504
505 2020-03-17  Kate Cheney  <katherine_cheney@apple.com>
506
507         Expand In-App-Browser-Privacy testing
508         https://bugs.webkit.org/show_bug.cgi?id=209142
509         <rdar://problem/60496618>
510
511         Reviewed by Darin Adler.
512
513         Expanded test coverage by adding new tests and creating a custom url
514         scheme handler to get around the fact that local file loads are
515         always classified as app-bound.
516
517         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
518         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
519         (-[InAppBrowserSchemeHandler webView:startURLSchemeTask:]):
520         If the path indicates testing user scripts on load, notify the script message
521         handler that the navigation has finished. If the path indicates
522         testing user-agent scripts, set the window.wkUserScriptInjected
523         variable to true. A user agent script will attempt to read this
524         variable and should fail.
525
526         (-[InAppBrowserSchemeHandler webView:stopURLSchemeTask:]):
527         (initializeInAppBrowserPrivacyTestSettings):
528         Basic test setup. Initialize the main run loop and make sure we are
529         starting with a clean state.
530
531         (TEST):
532         Add tests for all protocols checked in shouldBeTreatedAsAppBound,
533         except for blob files which must be generated within the web content.
534
535         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-local-file.html: Added.
536         Basic html document to test local file loads are classified as
537         app-bound.
538
539         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Removed.
540         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Removed.
541         These files are no longer needed as their content is directly copied
542         into the URL scheme handler.
543
544 2020-03-17  Chris Dumez  <cdumez@apple.com>
545
546         REGRESSION: [ macOS wk1 ] ASSERTION FAILED: _notifications.contains(notificationID) imported/w3c/web-platform-tests/notifications/constructor-basic.html is flaky crashing
547         https://bugs.webkit.org/show_bug.cgi?id=207307
548         <rdar://problem/59206964>
549
550         Reviewed by Alex Christensen.
551
552         When [MockWebNotificationProvider reset] was called at the end of the test, it would remove all
553         notifications from the map but not tell WebCore that the notification were discarded. As a result,
554         WebCore would later tell the MockWebNotificationProvider to cancel the notification but this
555         notification would no longer be in the map, causing us to hit an assertion in debug.
556
557         To address the issue, we now call Notification::finalize() in [MockWebNotificationProvider reset]
558         to let WebCore know the notification was discarded. This is similar to what is already done for
559         WebKit2 in WebNotificationManager::clearNotifications().
560
561         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
562         (-[MockWebNotificationProvider reset]):
563
564 2020-03-17  Don Olmstead  <don.olmstead@sony.com>
565
566         [WinCairo][FTW] Update path to requirements download
567         https://bugs.webkit.org/show_bug.cgi?id=209202
568
569         Reviewed by Ross Kirsling.
570
571         Repository was renamed from WinCairoRequirements to WebKitRequirements in the
572         WebKitForWindows org on GitHub. Additionally the .zip file was renamed to
573         WebKitRequirementsWin64.zip.
574
575         * Scripts/update-webkit-wincairo-libs.py:
576
577 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
578
579         [ews] Resubmit patches to commit-queue which were cq- by commit-queue and later cq+
580         https://bugs.webkit.org/show_bug.cgi?id=208920
581
582         Reviewed by Jonathan Bedard.
583
584         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
585         (Buildbot.update_builder_name_to_id_mapping): Method to generate builder name to id mapping.
586         (Buildbot.fetch_pending_and_inprogress_builds): Method to fetch pendign and in-progress builds from buildbot.
587         (Buildbot.get_patches_in_queue): Method to fetch list of patches which are pending or are in-progress on buildbot.
588         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
589         (Bugzilla.get_cq_plus_timestamp): Get UTC timestamp when cq+ flag was set.
590         * BuildSlaveSupport/ews-app/ews/fetcher.py:
591         (FetchLoop.run): Update builder name to id mapping. We just need to update it one-time, since we need the id only
592         for commit-queue which isn't expected to change.
593         (BugzillaPatchFetcher.fetch_commit_queue_patches):
594         (BugzillaPatchFetcher.send_patches_to_buildbot): Allow sending the patch again to commit-queue.
595         (BugzillaPatchFetcher.patches_to_send_to_commit_queue): Find patches which needs to be sent to commit-queue. Filter
596         out patches which are already waiting or in-progress on commit-queue, or whose recent build was completed after
597         setting cq+ flag on bugzilla.
598
599 2020-03-17  Chris Dumez  <cdumez@apple.com>
600
601         [WKTR] testRunner API that takes in a completion handler should use async IPC
602         https://bugs.webkit.org/show_bug.cgi?id=209187
603
604         Reviewed by John Wilander.
605
606         testRunner API that takes in a completion handler should use async IPC. This hangs
607         the WebProcess for no reason and can cause deadlocks if the UIProcess then tries
608         to IPC the WebProcess as a result of this testRunner call.
609
610         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
611         (WTR::TestRunner::setStatisticsHasHadUserInteraction):
612         (WTR::TestRunner::statisticsUpdateCookieBlocking):
613         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStore):
614         (WTR::TestRunner::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
615         (WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
616         (WTR::TestRunner::setStatisticsShouldDowngradeReferrer):
617         (WTR::TestRunner::setStatisticsFirstPartyWebsiteDataRemovalMode):
618         (WTR::TestRunner::statisticsResetToConsistentState):
619         (WTR::TestRunner::getAllStorageAccessEntries):
620         (WTR::TestRunner::removeAllSessionCredentials):
621         (WTR::TestRunner::getApplicationManifestThen):
622         * WebKitTestRunner/TestInvocation.cpp:
623         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
624         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
625
626 2020-03-17  Aakash Jain  <aakash_jain@apple.com>
627
628         [ews-app] Timestamp shown in status-bubble hover-over message is in future
629         https://bugs.webkit.org/show_bug.cgi?id=196628
630
631         Reviewed by Jonathan Bedard.
632
633         * BuildSlaveSupport/ews-build/events.py:
634         (JSONProducer.json_serialize_datetime): Keep the timestamp in UTC, instead of converting it to local time zone.
635         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
636         (StatusBubble.get_all_builds_for_queue): Sort the queues based on build number instead of start time, since the 
637         timestamps for new builds might be less than timestamps for old builds which completed immediately prior to this change.
638
639 2020-03-17  Alex Christensen  <achristensen@webkit.org>
640
641         Add WKUIDelegatePrivate SPI _webView:printFrame:completionHandler:
642         https://bugs.webkit.org/show_bug.cgi?id=209192
643         <rdar://problem/51313336>
644
645         Reviewed by Geoff Garen.
646
647         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
648         (-[PrintDelegateWithCompletionHandler _webView:printFrame:completionHandler:]):
649         (-[PrintDelegateWithCompletionHandler waitForPrintFrameCall]):
650         (TEST):
651
652 2020-03-17  Chris Dumez  <cdumez@apple.com>
653
654         Use less sync IPC for ITP testRunner methods
655         https://bugs.webkit.org/show_bug.cgi?id=209184
656
657         Reviewed by Alex Christensen.
658
659         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
660         (WTR::TestRunner::setStatisticsDebugMode):
661         (WTR::TestRunner::setStatisticsPrevalentResourceForDebugMode):
662         (WTR::TestRunner::setStatisticsLastSeen):
663         (WTR::TestRunner::setStatisticsMergeStatistic):
664         (WTR::TestRunner::setStatisticsPrevalentResource):
665         (WTR::TestRunner::setStatisticsVeryPrevalentResource):
666         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback):
667         * WebKitTestRunner/TestInvocation.cpp:
668         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
669         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
670
671 2020-03-17  Chris Dumez  <cdumez@apple.com>
672
673         [WKTR] Crash when trying to open a new window in an ephemeral session test
674         https://bugs.webkit.org/show_bug.cgi?id=209181
675
676         Reviewed by Geoffrey Garen.
677
678         Make sure that the new WKWebView is using the same data store as its related WKWebView.
679
680         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
681         (WTR::TestController::platformCreateOtherPage):
682
683 2020-03-17  Jacob Uphoff  <jacob_uphoff@apple.com>
684
685         Unreviewed, reverting r257844.
686
687         this revision caused a test to start timing out
688
689         Reverted changeset:
690
691         "(r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-
692         zero.html is a flaky failure"
693         https://bugs.webkit.org/show_bug.cgi?id=207948
694         https://trac.webkit.org/changeset/257844
695
696 2020-03-16  Justin Michaud  <justin_michaud@apple.com>
697
698         Add personal email to Tools/Scripts/webkitpy/common/config/contributors.json
699         https://bugs.webkit.org/show_bug.cgi?id=209151
700
701         Reviewed by Yusuke Suzuki.
702
703         * Scripts/webkitpy/common/config/contributors.json:
704
705 2020-03-16  Chris Dumez  <cdumez@apple.com>
706
707         Crash under WebCookieCache::clearForHost()
708         https://bugs.webkit.org/show_bug.cgi?id=209149
709         <rdar://problem/60453086>
710
711         Reviewed by Alex Christensen.
712
713         Add API test coverage.
714
715         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
716         (TEST):
717
718 2020-03-16  Keith Rollin  <krollin@apple.com>
719
720         Remove support for WebKitSystemInterface
721         https://bugs.webkit.org/show_bug.cgi?id=208894
722         <rdar://problem/60297590>
723
724         Reviewed by Brent Fulgham.
725
726         This project provided support for facilities that are now handled
727         elsewhere and is no longer needed.
728
729         * Scripts/copy-webkitlibraries-to-product-directory:
730
731 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
732
733         [macOS] Accessibility sandbox regressions
734         https://bugs.webkit.org/show_bug.cgi?id=209065
735
736         Reviewed by Brent Fulgham.
737
738         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
739         (TEST):
740         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
741         (TEST):
742
743 2020-03-16  Ryan Haddad  <ryanhaddad@apple.com>
744
745         Unreviewed infrastructure fix.
746
747         * BuildSlaveSupport/ews-build/config.json: Temporarily remove ews114
748         while the hardware is out for repair.
749
750 2020-03-13  Sergio Villar Senin  <svillar@igalia.com>
751
752         [WebXR] IDLs, stubs and build configuration for WPE
753         https://bugs.webkit.org/show_bug.cgi?id=208702
754
755         Reviewed by Dean Jackson.
756
757         * Scripts/webkitperl/FeatureList.pm: Added WebXR.
758         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added ENABLE_WEBXR, off by default.
759
760 2020-03-16  Per Arne Vollan  <pvollan@apple.com>
761
762         [Cocoa] Limit set of classes that can be decoded when a preference has changed
763         https://bugs.webkit.org/show_bug.cgi?id=208012
764
765         Reviewed by Brent Fulgham.
766
767         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
768         (TEST):
769
770 2020-03-16  youenn fablet  <youenn@apple.com>
771
772         Unique origins should not be Potentially Trustworthy
773         https://bugs.webkit.org/show_bug.cgi?id=209049
774
775         Reviewed by Darin Adler.
776
777         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
778         (TestWebKitAPI::TEST_F):
779
780 2020-03-15  Fujii Hironori  <Hironori.Fujii@sony.com>
781
782         KeyedDecoderGeneric fails to allocate Vector while decoding broken data
783         https://bugs.webkit.org/show_bug.cgi?id=207324
784
785         Reviewed by Darin Adler.
786
787         * TestWebKitAPI/Tests/WebCore/KeyedCoding.cpp:
788         (TestWebKitAPI::generateRandomData): Added.
789         (TestWebKitAPI::KeyedCoding.DecodeRandomData): Added a new test decoding random data.
790
791 2020-03-15  Yusuke Suzuki  <ysuzuki@apple.com>
792
793         Should not use variable-length-array (VLA)
794         https://bugs.webkit.org/show_bug.cgi?id=209043
795
796         Reviewed by Mark Lam.
797
798         * ContentExtensionTester/Configurations/Base.xcconfig:
799         * lldb/lldbWebKitTester/Configurations/Base.xcconfig:
800
801 2020-03-13  Alex Christensen  <achristensen@webkit.org>
802
803         WKWebView._negotiatedLegacyTLS should be correct after back/forward navigations
804         https://bugs.webkit.org/show_bug.cgi?id=209011
805         <rdar://problem/59370588>
806
807         Reviewed by Youenn Fablet.
808
809         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
810         (TestWebKitAPI::TEST):
811
812 2020-03-13  Wenson Hsieh  <wenson_hsieh@apple.com>
813
814         [watchOS] Don’t display empty text suggestions in Quickboard when editing input fields
815         https://bugs.webkit.org/show_bug.cgi?id=209089
816
817         Reviewed by Tim Horton.
818
819         Add an API test for watchOS. Also rename a few occurrences of "Autofill" to "AutoFill", to reflect the official
820         marketing name for the feature.
821
822         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
823         (runUntilReceivesAutoplayEvent):
824
825         Additionally fix the watchOS engineering build for arm64_32, which was failing due to comparisons between 64-bit
826         and 32-bit integers. This is because this function took a `WKAutoplayEvent` (a 32-bit integer), but compared
827         against the `_WKAutoplayEvent` type (an NSInteger that is 64 bits on this architecture). There didn't seem to
828         be any compelling reason to compare against different types here (especially since we only set
829         `receivedAutoplayEvent` under the Objective-C delegate method that provides a `_WKAutoplayEvent`), so I changed
830         these all to be `_WKAutoplayEvent`.
831
832         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
833         (-[AutoFillTestView _autofillInputView]):
834         (-[AutoFillTestView textInputHasAutoFillContext]):
835         (TestWebKitAPI::TEST):
836         (-[AutofillTestView initWithFrame:]): Deleted.
837         (-[AutofillTestView _autofillInputView]): Deleted.
838         (-[AutofillTestView textInputHasAutofillContext]): Deleted.
839         * TestWebKitAPI/ios/UIKitSPI.h:
840
841 2020-03-13  Chris Dumez  <cdumez@apple.com>
842
843         Unreviewed, reverting r256232.
844
845         Caused ResizeObserver tests to become flaky
846
847         Reverted changeset:
848
849         "[DRT] InternalSettingsGenerated::resetToConsistentState() may
850         override TestOptions"
851         https://bugs.webkit.org/show_bug.cgi?id=207481
852         https://trac.webkit.org/changeset/256232
853
854 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
855
856         [ iOS and Mac wk2 ] http/tests/in-app-browser-privacy/ tests failing
857         https://bugs.webkit.org/show_bug.cgi?id=209016
858         <rdar://problem/60329530> 
859
860         Reviewed by Chris Dumez.
861
862         Re-initialize the app-bound domains when the correct
863         TestOptions parameter is set.
864
865         * WebKitTestRunner/TestController.cpp:
866         (WTR::TestController::createWebViewWithOptions):
867         (WTR::TestController::reinitializeAppBoundDomains):
868         * WebKitTestRunner/TestController.h:
869
870 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
871
872         Report all third party loads on a per-page basis
873         https://bugs.webkit.org/show_bug.cgi?id=209032
874         <rdar://problem/60397323>
875
876         Reviewed by Chris Dumez.
877
878         Mostly naming updates to reflect the change in use for this SPI call.
879         It now returns all loaded third party domains, not just prevalent ones.
880
881         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
882         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
883         (WTR::InjectedBundle::didReceiveMessageToPage):
884         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
885         (WTR::TestRunner::getLoadedThirdPartyDomains):
886         (WTR::TestRunner::callDidReceiveLoadedThirdPartyDomainsCallback):
887         (WTR::TestRunner::getPrevalentDomains): Deleted.
888         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback): Deleted.
889         * WebKitTestRunner/InjectedBundle/TestRunner.h:
890         * WebKitTestRunner/TestController.cpp:
891         (WTR::TestController::resetStateToConsistentValues):
892         (WTR::TestController::getLoadedThirdPartyDomains):
893         (WTR::TestController::clearLoadedThirdPartyDomains):
894         (WTR::TestController::getPrevalentDomains): Deleted.
895         (WTR::TestController::clearPrevalentDomains): Deleted.
896         * WebKitTestRunner/TestController.h:
897         * WebKitTestRunner/TestInvocation.cpp:
898         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
899         (WTR::TestInvocation::didReceiveLoadedThirdPartyDomains):
900         (WTR::TestInvocation::didReceivePrevalentDomains): Deleted.
901         * WebKitTestRunner/TestInvocation.h:
902         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
903         (WTR::TestController::getLoadedThirdPartyDomains):
904         (WTR::TestController::clearLoadedThirdPartyDomains):
905         (WTR::TestController::getPrevalentDomains): Deleted.
906         (WTR::TestController::clearPrevalentDomains): Deleted.
907
908 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
909
910         [ews] run FindModifiedChangeLogs early in the build
911         https://bugs.webkit.org/show_bug.cgi?id=209060
912
913         Reviewed by Jonathan Bedard.
914
915         * BuildSlaveSupport/ews-build/factories.py:
916         * BuildSlaveSupport/ews-build/factories_unittest.py: Updated unit-test.
917
918 2020-03-13  Diego Pino Garcia  <dpino@igalia.com>
919
920         [GTK] Add EWS testers to run GTK layout tests
921         https://bugs.webkit.org/show_bug.cgi?id=207648
922
923         Reviewed by Carlos Alberto Lopez Perez and Aakash Jain.
924
925         Queue 'GTK-Webkit2-EWS' was renamed to 'GTK-Build-EWS'.
926         A new queue, named 'GTK-WK2-Tests-EWS', was added for WK2
927         tests (layout tests).
928
929         * BuildSlaveSupport/ews-build/config.json: Added new queue for
930         WK2 tests.
931         * BuildSlaveSupport/ews-build/factories.py:
932         (GTKTestsFactory):
933         * BuildSlaveSupport/ews-build/factories_unittest.py:
934         (TestCommitQueueFactory.test_commit_queue_factory):
935         (TestGTKFactory): Added unit-test.
936         (TestGTKFactory.test_gtk_factory):
937         * BuildSlaveSupport/ews-build/loadConfig.py:
938         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
939         (TagsForBuilderTest.test_getTagsForBuilder):
940
941 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
942
943         Add API endpoint in EWS django app to provide patch status in json format
944         https://bugs.webkit.org/show_bug.cgi?id=208940
945
946         Reviewed by Jonathan Bedard.
947
948         * BuildSlaveSupport/ews-app/ews/urls.py: Added url for new api endpoint.
949         * BuildSlaveSupport/ews-app/ews/views/status.py: Added.
950
951 2020-03-13  Kate Cheney  <katherine_cheney@apple.com>
952
953         WebKit2UseRemoteLayerTreeDrawingArea should be reset to NO between layout tests
954         https://bugs.webkit.org/show_bug.cgi?id=209055
955         <rdar://problem/60272692>
956
957         Reviewed by Simon Fraser.
958
959         Now that WebKitTestRunner has a bundleID, its' user default values
960         persist between tests. This patch resets WebKit2UseRemoteLayerTreeDrawingArea
961         to NO before running tests. It will be set to YES in PlatformWebView
962         if specified by the test.
963
964         * WebKitTestRunner/mac/main.mm:
965         (setDefaultsToConsistentValuesForTesting):
966
967 2020-03-13  Konstantin Tokarev  <annulen@yandex.ru>
968
969         [CMake] Eleminate mismatches between Find* module names and variables they set
970         https://bugs.webkit.org/show_bug.cgi?id=208948
971
972         Reviewed by Michael Catanzaro.
973
974         * wpe/backends/CMakeLists.txt:
975
976 2020-03-13  Aakash Jain  <aakash_jain@apple.com>
977
978         [ews-app] reduce logging
979         https://bugs.webkit.org/show_bug.cgi?id=209062
980
981         Reviewed by Jonathan Bedard.
982
983         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
984         (BugzillaBeautifulSoup.authenticate):
985         (BugzillaBeautifulSoup._load_query):
986
987 2020-03-13  Ryosuke Niwa  <rniwa@webkit.org>
988
989         Crash in TextIterator::node via TextManipulationController::replace
990         https://bugs.webkit.org/show_bug.cgi?id=209048
991
992         Reviewed by Wenson Hsieh.
993
994         Added a regression test.
995
996         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
997         (TextManipulation.CompleteTextManipulationShouldReplaceContentsAroundParagraphWithJustImage):
998
999 2020-03-13  Saam Barati  <sbarati@apple.com>
1000
1001         Pull in JS tests from "Internal" when there are "Internal" tests in an adjacent directory
1002         https://bugs.webkit.org/show_bug.cgi?id=209038
1003
1004         Reviewed by Keith Miller.
1005
1006         This allows us to automatically pull in some tests that are in non open sourced Apple
1007         checkouts.
1008
1009         * Scripts/run-javascriptcore-tests:
1010         (runJSCStressTests):
1011
1012 2020-03-12  Ryosuke Niwa  <rniwa@webkit.org>
1013
1014         Crash in TextManipulationController::replace
1015         https://bugs.webkit.org/show_bug.cgi?id=209021
1016
1017         Reviewed by Wenson Hsieh.
1018
1019         Added a regression test.
1020
1021         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1022         (TextManipulation.CompleteTextManipulationShouldReplaceContentFollowedAfterImageInCSSTable):
1023
1024 2020-03-12  Per Arne Vollan  <pvollan@apple.com>
1025
1026         [macOS] _AXSApplicationAccessibilityEnabled should not be called
1027         https://bugs.webkit.org/show_bug.cgi?id=208953
1028
1029         Reviewed by Brent Fulgham.
1030
1031         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1032
1033 2020-03-12  Kate Cheney  <katherine_cheney@apple.com>
1034
1035         Resource load statistics data summary should return all third party data
1036         https://bugs.webkit.org/show_bug.cgi?id=209000
1037         <rdar://problem/60348306>
1038
1039         Reviewed by John Wilander.
1040
1041         Marked only 2 of 3 domains prevalent in data summary tests to ensure
1042         the call returns all third parties, not just prevalent ones.
1043         Added a more aggressive check for the size of the array at the
1044         beginning of the test to ensure the array is still returning 3 values. 
1045         Also removed the ASSERT statements as they seem to cause timeouts (not
1046         clear crashes) when they are not true, which is hard to debug.
1047         If these values are nil, the test will fail in the EXPECT_WK_STREQ
1048         checks, we don't need ASSERT statements.
1049
1050         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
1051         (TEST):
1052
1053 2020-03-12  Jonathan Bedard  <jbedard@apple.com>
1054
1055         resultsdpy: Add script to run local instance
1056         https://bugs.webkit.org/show_bug.cgi?id=208746
1057
1058         Rubber-stamped by Aakash Jain.
1059
1060         * resultsdbpy/resultsdbpy/example: Added.
1061         * resultsdbpy/resultsdbpy/example/__init__.py: Added.
1062         * resultsdbpy/resultsdbpy/example/environment.py: Added.
1063         (Environment): Organize environment variables used by results database.
1064         (ModelFromEnvironment): Construct the database model from the environment.
1065         (main): Create and drop tables, if required.
1066         * resultsdbpy/resultsdbpy/example/main.py: Added.
1067         (health): Web-server health check.
1068         (handle_errors):
1069         (main): Run results database web-server.
1070         * resultsdbpy/resultsdbpy/example/worker.py: Added.
1071         (main): Asynchronously process uploaded results.
1072         * resultsdbpy/resultsdbpy/run: Added.
1073
1074 2020-03-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1075
1076         run-webkit-tests --use-gpu-process should enable GPU Process for canvas
1077         https://bugs.webkit.org/show_bug.cgi?id=209004
1078
1079         Reviewed by Tim Horton.
1080
1081         Add "RenderCanvasInGPUProcessEnabled" to the list of internal features that should be enabled when
1082         `use_gpu_process` is specified.
1083
1084         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1085         (parse_args):
1086
1087 2020-03-12  Matt Lewis  <jlewis3@apple.com>
1088
1089         Make flatpack import for run-webkit-tests only happen on linux systems
1090         https://bugs.webkit.org/show_bug.cgi?id=208954
1091
1092         Reviewed by Philippe Normand.
1093
1094         * Scripts/run-webkit-tests: Added an if statement to find the system platform
1095         to determine if we need the flatpackutils import. 
1096
1097 2020-03-12  Alex Christensen  <achristensen@webkit.org>
1098
1099         WKWebView.hasOnlySecureContent should be correct after back/forward navigations
1100         https://bugs.webkit.org/show_bug.cgi?id=207609
1101
1102         Reviewed by Ryosuke Niwa.
1103
1104         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1105         (TestWebKitAPI::TEST):
1106
1107 2020-03-12  Daniel Bates  <dabates@apple.com>
1108
1109         FocusController::setFocusedElement() should tell client of refocused element
1110         https://bugs.webkit.org/show_bug.cgi?id=208880
1111
1112         Reviewed by Wenson Hsieh.
1113
1114         Adds a test to ensure that calling -selectPositionAtPoint on an already focused element tries
1115         to start an input session. Currently, it does not even try.
1116
1117         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
1118         (TEST):
1119
1120 2020-03-12  Michael Catanzaro  <mcatanzaro@gnome.org>
1121
1122         [GTK] Use #!/usr/bin/python3 shebang to run generate-gtkdoc
1123         https://bugs.webkit.org/show_bug.cgi?id=208970
1124
1125         Reviewed by Daniel Bates.
1126
1127         Fedora and Ubuntu are both patching generate-gtkdoc to use #!/usr/bin/python3 rather than
1128         #!/usr/bin/env python.
1129
1130         #!/usr/bin/env and /usr/bin/python are both banned in Fedora packages. I guess Ubuntu
1131         probably has similar rules.
1132
1133         Note this is the only script that attempts to use /usr/bin/python in tarball builds.
1134         Everything else that does so is probably only used by webkit-build.
1135
1136         https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_multiple_python_runtimes
1137
1138         * gtkdoc/generate-gtkdoc:
1139
1140 2020-03-11  Jiewen Tan  <jiewen_tan@apple.com>
1141
1142         [WebAuthn] Formalize the Keychain schema
1143         https://bugs.webkit.org/show_bug.cgi?id=183533
1144         <rdar://problem/43347926>
1145
1146         Reviewed by Brent Fulgham.
1147
1148         Modifies the test infra to use Credential ID as the unique identifier for a credential instead of
1149         the original combination of RP ID and user handle.
1150
1151         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1152         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1153         (WTR::TestRunner::cleanUpKeychain):
1154         (WTR::TestRunner::keyExistsInKeychain):
1155         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1156         * WebKitTestRunner/TestController.h:
1157         * WebKitTestRunner/TestInvocation.cpp:
1158         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1159         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1160         (WTR::TestController::cleanUpKeychain):
1161         (WTR::TestController::keyExistsInKeychain):
1162
1163 2020-03-11  Keith Miller  <keith_miller@apple.com>
1164
1165         Test262-runner should always consider crashes as new failures
1166         https://bugs.webkit.org/show_bug.cgi?id=208943
1167
1168         Reviewed by Yusuke Suzuki.
1169
1170         Right now the runner will consider crashes with no output as passes, which is obviously bad.
1171         Since we should never crash on a conformance test we should consider a crash as a new failure
1172         100% of the time.
1173
1174         * Scripts/test262/Runner.pm:
1175         (processFile):
1176         (runTest):
1177         (processResult):
1178
1179 2020-03-11  Chris Dumez  <cdumez@apple.com>
1180
1181         Assertion hit under WebPageProxy::suspendCurrentPageIfPossible() when bypassing certificate warning page
1182         https://bugs.webkit.org/show_bug.cgi?id=208927
1183         <rdar://problem/55448331>
1184
1185         Reviewed by Alex Christensen.
1186
1187         Add API test coverage.
1188
1189         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1190
1191 2020-03-11  Diego Pino Garcia  <dpino@igalia.com>
1192
1193         [GTK] Switch EWS api-gtk bot from buildAndTest to testOnly
1194         https://bugs.webkit.org/show_bug.cgi?id=208860
1195
1196         Reviewed by Carlos Alberto Lopez Perez.
1197
1198         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1199         (StatusBubble): Added 'api-gtk'.
1200         * BuildSlaveSupport/ews-build/config.json:
1201         * BuildSlaveSupport/ews-build/factories.py:
1202         (BuildFactory.__init__): Call InstallGTKDependencies() if platform is
1203         GTK.
1204         (TestFactory.__init__): Call InstallGTKDependencies() if platform is
1205         GTK.
1206         (GTKBuildFactory):
1207         (GTKBuildFactory.__init__): Deleted.
1208         (GTKBuildAndTestFactory): Deleted.
1209         (GTKBuildAndTestFactory.__init__): Deleted.
1210         (GTKAPIBuildAndTestFactory): Deleted.
1211         * BuildSlaveSupport/ews-build/loadConfig.py:
1212
1213 2020-03-11  Aakash Jain  <aakash_jain@apple.com>
1214
1215         [ews] Add unit test to prevent multiple schedulers for a builder.
1216         https://bugs.webkit.org/show_bug.cgi?id=208917
1217
1218         Reviewed by Carlos Alberto Lopez Perez.
1219
1220         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
1221         (ConfigDotJSONTest.test_multiple_scheduers_for_builder): Added unit test.
1222         (TagsForBuilderTest): Fixed a typo.
1223
1224 2020-03-11 Philippe Normand  <pnormand@igalia.com>
1225
1226         [GTK] Failing API tests under the Flatpak SDK environment
1227         https://bugs.webkit.org/show_bug.cgi?id=208871
1228
1229         Reviewed by Michael Catanzaro.
1230
1231         The load-failed signal callback should return a boolean result,
1232         otherwise we enter in unknown territory depending on how the
1233         toolchain compiles this, possibly triggering bad behavior (with
1234         GCC 9.2 from the Flatpak SDK) or not caring at all (with current
1235         GCC toolchain on buildbots).
1236
1237         Patch suggested by Michael Catanzaro.
1238
1239         * TestWebKitAPI/glib/WebKitGLib/LoadTrackingTest.cpp:
1240         (loadFailedCallback):
1241
1242 2020-03-10  Don Olmstead  <don.olmstead@sony.com>
1243
1244         Sync FeatureList.pm with CMake definitions
1245         https://bugs.webkit.org/show_bug.cgi?id=208866
1246
1247         Reviewed by Michael Catanzaro.
1248
1249         * Scripts/webkitperl/FeatureList.pm:
1250
1251 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1252
1253         [ews] Add unit tests for commit queue factory
1254         https://bugs.webkit.org/show_bug.cgi?id=208862
1255
1256         Reviewed by Jonathan Bedard.
1257
1258         * BuildSlaveSupport/ews-build/factories_unittest.py:
1259         (TestCommitQueueFactory):
1260         (TestCommitQueueFactory.test_commit_queue_factory): Added unit-test for commit-queue factory.
1261
1262 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1263
1264         [ews-app] Status bubble should only display important messages in pop-over - part 3
1265         https://bugs.webkit.org/show_bug.cgi?id=208865
1266
1267         Reviewed by Jonathan Bedard.
1268
1269         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1270         (StatusBubble): Added more strings to STEPS_TO_HIDE.
1271
1272 2020-03-10  Lauro Moura  <lmoura@igalia.com>
1273
1274         [WPE] MiniBrowser: Close child WebViews when exiting
1275         https://bugs.webkit.org/show_bug.cgi?id=208689
1276
1277         Reviewed by Carlos Garcia Campos.
1278
1279         Store created views so we can release them before exiting.
1280
1281         * MiniBrowser/wpe/main.cpp:
1282         (webViewClose):
1283         (createWebView):
1284         (main):
1285
1286 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1287
1288         Add ValidateCommiterAndReviewer and ValidateChangeLogAndReviewer build steps in commit-queue
1289         https://bugs.webkit.org/show_bug.cgi?id=208861
1290
1291         Reviewed by Jonathan Bedard.
1292
1293         * BuildSlaveSupport/ews-build/factories.py:
1294         (Factory.__init__): Remove verifycqplus parameter.
1295         (CommitQueueFactory): Inherit from factory.BuildFactory base class instead of custom Factory class.
1296         (CommitQueueFactory.__init__): Add required build steps, especially ValidateCommiterAndReviewer, 
1297         UpdateWorkingDirectory and ValidateChangeLogAndReviewer.
1298
1299 2020-03-10  Philippe Normand  <pnormand@igalia.com>
1300
1301         [GTK] API favicon test flaky timeouts
1302         https://bugs.webkit.org/show_bug.cgi?id=208189
1303
1304         Reviewed by Carlos Garcia Campos.
1305
1306         Sometimes the favicon changes already during the load. Keeping
1307         track of it in the WebView favicon property notification handler
1308         gets us rid of the race.
1309
1310         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitFaviconDatabase.cpp:
1311         (testFaviconDatabaseGetFavicon):
1312
1313 2020-03-10  Aakash Jain  <aakash_jain@apple.com>
1314
1315         Generate commit-queue status bubble from new EWS
1316         https://bugs.webkit.org/show_bug.cgi?id=208811
1317
1318         Reviewed by Jonathan Bedard.
1319
1320         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1321         (StatusBubble._build_bubbles_for_patch):
1322
1323 2020-03-09  Don Olmstead  <don.olmstead@sony.com>
1324
1325         Remove obsolete feature flags
1326         https://bugs.webkit.org/show_bug.cgi?id=208830
1327
1328         Reviewed by Alex Christensen.
1329
1330         Remove ENABLE_CUSTOM_SCHEME_HANDLER and ENABLE_MAC_VIDEO_TOOLBOX since they
1331         are no longer used.
1332
1333         Also remove ENABLE_POINTER_EVENTS since the FeaturesDefines.xcconfig was not modified
1334         when the compilation flag was removed in r258148.
1335
1336         Remove ENABLE_ACCELERATED_OVERFLOW_SCROLLING, ENABLE_CSS_IMAGE_ORIENTATION,
1337         ENABLE_CUSTOM_SCHEME_HANDLER, and ENABLE_FETCH_API from FeatureList.pm.
1338
1339         * Scripts/webkitperl/FeatureList.pm:
1340         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1341
1342 2020-03-09  Kate Cheney  <katherine_cheney@apple.com>
1343
1344         WebKitTestRunner bundleID should not be cleared before every test
1345         https://bugs.webkit.org/show_bug.cgi?id=208823
1346         <rdar://problem/60204539>
1347
1348         Reviewed by Per Arne Vollan.
1349
1350         This is causing test failures for layout tests which rely on the Info.plist 
1351         bundle identifier (not the one set via the override method).
1352
1353         * WebKitTestRunner/TestController.cpp:
1354         (WTR::TestController::createWebViewWithOptions):
1355         (WTR::TestController::ensureViewSupportsOptionsForTest):
1356         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1357
1358 2020-03-09  Per Arne Vollan  <pvollan@apple.com>
1359
1360         [macOS] Notification observer is not removed
1361         https://bugs.webkit.org/show_bug.cgi?id=208834
1362
1363         Reviewed by Tim Horton.
1364
1365         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1366         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm: Added.
1367         (TEST):
1368
1369 2020-03-06  Brian Burg  <bburg@apple.com>
1370
1371         upload.py gets confused by git-svn checkouts, unable to upload test results from my desk build
1372         https://bugs.webkit.org/show_bug.cgi?id=208729
1373         <rdar://problem/60105447>
1374
1375         Reviewed by Jonathan Bedard.
1376
1377         Improve upload.py to look for the svn branch and revision for the 'webkit'
1378         project and prefer those to the git equivalents (eg, prefer trunk/rNNNNN to master/<hash>).
1379
1380         * Scripts/webkitpy/common/checkout/scm/git.py:
1381         (Git):
1382         (Git.git_svn_id_regexp):
1383         (Git._field_from_git_svn_id):
1384         (Git.svn_revision):
1385         (Git.svn_branch):
1386         (Git.svn_url):
1387         (Git.native_branch):
1388         Refactor svn revision, branch, url to use the same regexp and helper code.
1389
1390         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
1391         (StubRepository.svn_branch):
1392         Expose a stub since this is used unconditionally by Port.commits_for_upload.
1393
1394         * Scripts/webkitpy/common/checkout/scm/svn.py:
1395         (SVN.svn_branch):
1396         (SVN.native_revision):
1397         (SVN):
1398         (SVN.native_branch):
1399         Refactor so the actual implementation is contained in svn_revision / svn_branch.
1400         The native_* methods call out to the SVN equivalents since this is an SVN repository.
1401
1402         * Scripts/webkitpy/port/base.py:
1403         (Port.commits_for_upload):
1404         Add special git-svn handling for the WebKit repository so that SVN branch and revision
1405         is preferred over the git equivalents.
1406
1407 2020-03-09  Antoine Quint  <graouts@apple.com>
1408
1409         TestWebKitAPI fails to build on watchOS
1410         https://bugs.webkit.org/show_bug.cgi?id=208820
1411
1412         Reviewed by Tim Horton.
1413
1414         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
1415
1416 2020-03-09  Jonathan Bedard  <jbedard@apple.com>
1417
1418         resultsdbpy: Add tool to manage resultsdbpy container
1419         https://bugs.webkit.org/show_bug.cgi?id=208743
1420
1421         Rubber-stamped by Aakash Jain.
1422
1423         Add tool to start, stop and restart the resultsdbpy Docker container.
1424
1425         * resultsdbpy/resultsdbpy/container: Added.
1426
1427 2020-03-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1428
1429         [GTK][WPE] Surrounding text for input methods should not be limited to the current paragraph
1430         https://bugs.webkit.org/show_bug.cgi?id=208706
1431
1432         Reviewed by Žan Doberšek.
1433
1434         Add test case to check surrounding text in multiline context.
1435
1436         * TestWebKitAPI/Tests/WebKitGLib/TestInputMethodContext.cpp:
1437         (testWebKitInputMethodContextSurrounding):
1438
1439 2020-03-08  Per Arne Vollan  <pvollan@apple.com>
1440
1441         [iOS] Mapping to UTI from tag and tag class should be performed in the UI process
1442         https://bugs.webkit.org/show_bug.cgi?id=208783
1443
1444         Reviewed by Brent Fulgham.
1445
1446         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1447
1448 2020-03-07  Ross Kirsling  <ross.kirsling@sony.com>
1449
1450         Replace the use of term "rollout" to "revert" in various tools
1451         https://bugs.webkit.org/show_bug.cgi?id=208775
1452
1453         Reviewed by Ryosuke Niwa.
1454
1455         See this webkit-dev thread for the originating discussion:
1456         https://lists.webkit.org/pipermail/webkit-dev/2020-March/031132.html
1457
1458         'rollout' is a confusing term to anyone unacquainted with WebKit;
1459         consensus seems to be that 'revert' would be the best replacement (as opposed to 'rollback').
1460
1461         Given the long legacy of this term within WebKit, it's important to deprecate and not remove 'rollout' commands.
1462         As such, this patch aims to make 'revert' the preferred term everywhere without making 'rollout' fail.
1463
1464         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js:
1465         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
1466         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
1467         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
1468         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js:
1469         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
1470         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
1471         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
1472         * BuildSlaveSupport/ews-build/steps.py:
1473         * BuildSlaveSupport/ews-build/steps_unittest.py:
1474         * Scripts/webkit-tools-completion.sh:
1475         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
1476         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1477         * Scripts/webkitpy/common/checkout/scm/svn.py:
1478         * Scripts/webkitpy/common/net/bugzilla/attachment.py:
1479         * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
1480         * Scripts/webkitpy/tool/bot/commitqueuetask.py:
1481         * Scripts/webkitpy/tool/bot/feeders.py:
1482         * Scripts/webkitpy/tool/bot/feeders_unittest.py:
1483         * Scripts/webkitpy/tool/bot/irc_command.py:
1484         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
1485         * Scripts/webkitpy/tool/bot/ircbot_unittest.py:
1486         * Scripts/webkitpy/tool/bot/sheriff.py:
1487         * Scripts/webkitpy/tool/commands/download.py:
1488         * Scripts/webkitpy/tool/commands/download_unittest.py:
1489         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1490         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1491         * Scripts/webkitpy/tool/commands/queues_unittest.py:
1492         * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
1493         * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
1494         * Scripts/webkitpy/tool/steps/__init__.py:
1495         * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
1496         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1497         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1498         * Scripts/webkitpy/tool/steps/reopenbugafterrevert.py: Renamed from Tools/Scripts/webkitpy/tool/steps/reopenbugafterrollout.py.
1499
1500 2020-03-07  David Quesada  <david_quesada@apple.com>
1501
1502         Crash in -[_WKRemoteObjectRegistry _invokeMethod:] block when calling a reply block after the web view has deallocated
1503         https://bugs.webkit.org/show_bug.cgi?id=208781
1504         rdar://problem/60061016
1505
1506         Reviewed by Alex Christensen.
1507
1508         Add a test that recreates the conditions of this crash:
1509         - Send a message from the injected bundle to the UI process that contains a reply block.
1510         - Hold a reference to the reply block.
1511         - Let the web view deallocate.
1512         - Call the block, and expect not to crash.
1513
1514         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
1515         (localObjectInterface):
1516         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
1517         (-[LocalObject doSomethingWithCompletionHandler:]):
1518         (TEST):
1519         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
1520         (-[RemoteObjectRegistryPlugIn callUIProcessMethodWithReplyBlock]):
1521
1522 2020-03-07  Ryosuke Niwa  <rniwa@webkit.org>
1523
1524         TextManipulationController should work with ARIA labels
1525         https://bugs.webkit.org/show_bug.cgi?id=208759
1526
1527         Reviewed by Wenson Hsieh.
1528
1529         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1530         (TextManipulation.StartTextManipulationFindAttributeContent): Added.
1531         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage): Updated
1532         the expected number of tokens for the first item as the very first image is correctly
1533         detected per the code change. 
1534         (TextManipulation.CompleteTextManipulationShouldReplaceAttributeContent): Added.
1535
1536 2020-03-07  Alex Christensen  <achristensen@webkit.org>
1537
1538         Regression r258042: Failing API test TestWebKitAPI.URLSchemeHandler.Frames
1539         https://bugs.webkit.org/show_bug.cgi?id=208767
1540
1541         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1542         The frameID of the main frame before loading is only 0 on Mac right now.
1543         The test is still good because it validates that execution works in the main frame before loading.
1544
1545 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1546
1547         [ews] commit queue is not skipping layout tests for rollout patches
1548         https://bugs.webkit.org/show_bug.cgi?id=208716
1549
1550         Unreviewed minor fix.
1551
1552         * BuildSlaveSupport/ews-build/steps.py:
1553         (RunWebKitTests.doStepIf):
1554         (RunWebKit1Tests.doStepIf): Moved to base class RunWebKitTests.
1555         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
1556
1557 2020-03-05  Sam Weinig  <weinig@apple.com>
1558
1559         Move JavaScriptCore related feature defines from FeatureDefines.xcconfig to PlatformEnableCocoa.h
1560         https://bugs.webkit.org/show_bug.cgi?id=207436
1561         <rdar://problem/59296762>
1562
1563         Reviewed by Darin Adler.
1564
1565         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1566         Remove JSC related defines.
1567
1568 2020-03-07  Chris Fleizach  <cfleizach@apple.com>
1569
1570         AX: Provide a way to run tests in isolated tree mode
1571         https://bugs.webkit.org/show_bug.cgi?id=208629
1572         <rdar://problem/60075583>
1573
1574         Reviewed by Ryosuke Niwa.
1575
1576         Provide the ability to run tests for accessibility in the isolated tree mode.
1577         This sends a flag over to the injected bundle which calls the right HIServices override so that
1578         the system thinks it is in isolated mode.
1579
1580         * Scripts/compare-webkit-configurations:
1581         (flag_for_comparison):
1582         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1583         (parse_args):
1584         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1585         (parse_args):
1586         * Scripts/webkitpy/port/driver.py:
1587         (Driver.cmd_line):
1588         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
1589         (WTR::AccessibilityController::AccessibilityController):
1590         (WTR::AccessibilityController::setAccessibilityIsolatedTreeMode):
1591         (WTR::AccessibilityController::updateIsolatedTreeMode):
1592         (WTR::AccessibilityController::executeOnAXThreadIfPossible):
1593         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
1594         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1595         (WTR::InjectedBundle::didReceiveMessageToPage):
1596         (WTR::InjectedBundle::beginTesting):
1597         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1598         * WebKitTestRunner/Options.cpp:
1599         (WTR::handleOptionAccessibilityIsolatedTreeMode):
1600         (WTR::OptionsHandler::OptionsHandler):
1601         * WebKitTestRunner/Options.h:
1602         * WebKitTestRunner/TestController.cpp:
1603         (WTR::TestController::initialize):
1604         (WTR::TestController::resetPreferencesToConsistentValues):
1605         (WTR::TestController::resetStateToConsistentValues):
1606         * WebKitTestRunner/TestController.h:
1607         (WTR::TestController::accessibilityIsolatedTreeMode const):
1608
1609 2020-03-06  Per Arne Vollan  <pvollan@apple.com>
1610
1611         [Cocoa] Re-enable CFPrefs direct mode
1612         https://bugs.webkit.org/show_bug.cgi?id=208690
1613
1614         Reviewed by Brent Fulgham.
1615
1616         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1617         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm: Added.
1618         (TEST):
1619         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
1620         (TestWebKitAPI::TEST):
1621
1622 2020-03-06  Kate Cheney  <katherine_cheney@apple.com>
1623
1624         UIProcess needs mechanism to specify AppBound domains
1625         https://bugs.webkit.org/show_bug.cgi?id=208528
1626         <rdar://problem/59980340>
1627
1628         Reviewed by Brent Fulgham.
1629
1630         Added test app-bound domains to the plist and tested that the domains
1631         are properly stored in the website data store after a navigation.
1632
1633         * TestWebKitAPI/Info.plist:
1634         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
1635         (TEST):
1636
1637 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1638
1639         Add SPI to disable cross origin access control checks
1640         https://bugs.webkit.org/show_bug.cgi?id=208748
1641
1642         Reviewed by Tim Hatcher.
1643
1644         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1645         Add a test that verifies this SPI allows Access-Control-Allow-Origin: * with credentials.
1646
1647 2020-03-06  Basuke Suzuki  <basuke.suzuki@sony.com>
1648
1649         [webkitpy] Fix executive on Windows to run wpt server correctly
1650         https://bugs.webkit.org/show_bug.cgi?id=208693
1651
1652         Reviewed by Jonathan Bedard.
1653
1654         Bug fix for Windows environment a) fixing a typo. b) fixing path
1655         c) fix how to kill subprocesses.
1656
1657         * Scripts/webkitpy/common/system/executive.py:
1658         (Executive._windows_kill_command):
1659         (Executive.interrupt):
1660         (Executive.kill_all):
1661         * Scripts/webkitpy/port/base.py:
1662         (Port.web_platform_test_server_doc_root):
1663
1664 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1665
1666         Evaluating JavaScript in main frame before loading should succeed
1667         https://bugs.webkit.org/show_bug.cgi?id=208733
1668
1669         Reviewed by Tim Horton.
1670
1671         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1672
1673 2020-03-06  Ryosuke Niwa  <rniwa@webkit.org>
1674
1675         TextManipulationController should preserve images
1676         https://bugs.webkit.org/show_bug.cgi?id=208692
1677
1678         Reviewed by Wenson Hsieh.
1679
1680         Added tests for preserving images and their ordering.
1681
1682         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
1683         (TextManipulation.CompleteTextManipulationShouldPreserveImagesAsExcludedTokens):
1684         (TextManipulation.CompleteTextManipulationShouldPreserveSVGAsExcludedTokens):
1685         (TextManipulation.CompleteTextManipulationShouldPreserveOrderOfBlockImage):
1686
1687 2020-03-06  David Quesada  <david_quesada@apple.com>
1688
1689         Add _WKResourceLoadInfo.resourceType SPI
1690         https://bugs.webkit.org/show_bug.cgi?id=208723
1691
1692         Reviewed by Alex Christensen.
1693
1694         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
1695         (TEST):
1696
1697 2020-03-06  Jonathan Bedard  <jbedard@apple.com>
1698
1699         Stop reporting to webkit-test-results.webkit.org
1700         https://bugs.webkit.org/show_bug.cgi?id=207218
1701
1702         Reviewed by Alexey Proskuryakov.
1703
1704         * BuildSlaveSupport/build.webkit.org-config/steps.py:
1705         (RunWebKitTests):
1706
1707 2020-03-06  Sihui Liu  <sihui_liu@apple.com>
1708
1709         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
1710         https://bugs.webkit.org/show_bug.cgi?id=208365
1711         <rdar://problem/59877296>
1712
1713         Reviewed by Geoffrey Garen.
1714
1715         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
1716         (TEST):
1717
1718 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1719
1720         EWS should be able to fetch patch status for security bugs while processing them
1721         https://bugs.webkit.org/show_bug.cgi?id=206511
1722
1723         Reviewed by Alexey Proskuryakov.
1724
1725         * BuildSlaveSupport/ews-build/steps.py:
1726         (BugzillaMixin.fetch_data_from_url_with_authentication): Method to fetch data from bugzilla using api key.
1727         (BugzillaMixin.get_patch_json): 
1728         (BugzillaMixin.get_bug_json):
1729         (BugzillaMixin._is_bug_closed):
1730         (ApplyPatch.hideStepIf): Use 'sensitive' build property instead of 'validated'.
1731         (TransferToS3.hideStepIf): Ditto.
1732
1733 2020-03-06  Aakash Jain  <aakash_jain@apple.com>
1734
1735         [ews] commit-queue should show the trac url for the commit on the build page
1736         https://bugs.webkit.org/show_bug.cgi?id=208715
1737
1738         Reviewed by Jonathan Bedard.
1739
1740         * BuildSlaveSupport/ews-build/steps.py:
1741         (PushCommitToWebKitRepo.evaluateCommand):
1742
1743 2020-03-06  Alex Christensen  <achristensen@webkit.org>
1744
1745         Fix ResourceLoadDelegate.LoadInfo API test after r257816
1746         https://bugs.webkit.org/show_bug.cgi?id=208550
1747
1748         * TestWebKitAPI/cocoa/HTTPServer.mm:
1749         (TestWebKitAPI::HTTPServer::respondToRequests):
1750         Sometimes we need a separate read to read the HTTP body after a request header, sometimes it comes in the same read.
1751         If it comes in the same read, send the response immediately.  Otherwise read the HTTP body then send the response.
1752
1753 2020-03-06  Lauro Moura <lmoura@igalia.com>
1754
1755         [WPE][WebDriver] MiniBrowser should react to close session commands
1756         https://bugs.webkit.org/show_bug.cgi?id=207529
1757
1758         Reviewed by Carlos Garcia Campos.
1759
1760         Do not call g_object_unref on the first created view if it has already
1761         been disposed in the "close" signal handler.
1762
1763         Based on original patch by Yury Semikhatsky.
1764
1765         * MiniBrowser/wpe/main.cpp:
1766         (main):
1767
1768 2020-03-06  Michael Catanzaro  <mcatanzaro@gnome.org>
1769
1770         [WPE][GTK] Use Firefox user agent quirk more aggressively on Google Docs
1771         https://bugs.webkit.org/show_bug.cgi?id=208647
1772
1773         Reviewed by Carlos Garcia Campos.
1774
1775         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
1776         (TestWebKitAPI::TEST):
1777
1778 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1779
1780         Add WKNavigationDelegatePrivate SPI to inform application of subframe navigations
1781         https://bugs.webkit.org/show_bug.cgi?id=208670
1782
1783         Reviewed by Brady Eidson.
1784
1785         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
1786         (-[FrameNavigationDelegate waitForNavigations:]):
1787         (-[FrameNavigationDelegate requests]):
1788         (-[FrameNavigationDelegate frames]):
1789         (-[FrameNavigationDelegate callbacks]):
1790         (-[FrameNavigationDelegate _webView:didStartProvisionalLoadWithRequest:inFrame:]):
1791         (-[FrameNavigationDelegate _webView:didFailProvisionalLoadWithRequest:inFrame:withError:]):
1792         (-[FrameNavigationDelegate _webView:didCommitLoadWithRequest:inFrame:]):
1793         (-[FrameNavigationDelegate _webView:didFailLoadWithRequest:inFrame:withError:]):
1794         (-[FrameNavigationDelegate _webView:didFinishLoadWithRequest:inFrame:]):
1795         (TEST):
1796
1797 2020-03-05  Alex Christensen  <achristensen@webkit.org>
1798
1799         Add WKFrameInfo._parentFrameHandle SPI
1800         https://bugs.webkit.org/show_bug.cgi?id=208674
1801
1802         Reviewed by Brady Eidson.
1803
1804         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1805
1806 2020-03-05  Jiewen Tan  <jiewen_tan@apple.com>
1807
1808         [WebAuthn] Implement SPI -[_WKWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]
1809         https://bugs.webkit.org/show_bug.cgi?id=208626
1810         <rdar://problem/60074148>
1811
1812         Reviewed by Brent Fulgham.
1813
1814         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1815         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1816         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:source:completionHandler:]):
1817         (TestWebKitAPI::TEST):
1818         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]): Deleted.
1819         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-hid-multiple-accounts.html:
1820         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Added.
1821
1822 2020-03-05  Antoine Quint  <graouts@apple.com>
1823
1824         Page-specific UserStyleSheets should wait until the initial empty document has been removed to be injected
1825         https://bugs.webkit.org/show_bug.cgi?id=208644
1826         <rdar://problem/60042429>
1827
1828         Reviewed by Brady Eidson.
1829
1830         Add new tests for -[_WKUserStyleSheet initWithSource:forWKWebView:forMainFrameOnly:userContentWorld:]) that check:
1831         
1832         1. that a _WKUserStyleSheet can be added immediately after a WKWebView's creation and will be injected once the initial
1833            empty document has been removed in favor of the document for the requested URL,
1834         2. that removing a _WKUserStyleSheet immediately after it was added but before the initial empty document was removed
1835            correctly does not injected the style sheet.
1836
1837         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
1838
1839 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1840
1841         [ews] Add build step to push commit to WebKit repository
1842         https://bugs.webkit.org/show_bug.cgi?id=208589
1843
1844         Reviewed by Jonathan Bedard.
1845
1846         * BuildSlaveSupport/ews-build/steps.py:
1847         (PushCommitToWebKitRepo): Build step to push the local commit to WebKit repository.
1848         (PushCommitToWebKitRepo.start): Initialize log observer.
1849         (PushCommitToWebKitRepo.evaluateCommand): Check command return status and comment on bug accordingly.
1850         (PushCommitToWebKitRepo.comment_text_for_bug): Generate comment text for commenting on bug.
1851         (PushCommitToWebKitRepo.svn_revision_from_commit_text): Extract the svn revision from commit text.
1852         (PushCommitToWebKitRepo.getResultSummary): Set custom failure message.
1853         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
1854         * BuildSlaveSupport/ews-build/factories.py:
1855
1856 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1857
1858         [ews] Add unit tests for ValidateCommiterAndReviewer build step
1859         https://bugs.webkit.org/show_bug.cgi?id=208262
1860
1861         Reviewed by Jonathan Bedard.
1862
1863         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests for ValidateCommiterAndReviewer.
1864
1865 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1866
1867         commit-queue should run WK2 tests instead of WK1 tests
1868         https://bugs.webkit.org/show_bug.cgi?id=208544
1869
1870         Reviewed by Jonathan Bedard.
1871
1872         * BuildSlaveSupport/ews-build/factories.py:
1873
1874 2020-03-05  Aakash Jain  <aakash_jain@apple.com>
1875
1876         [ews] ValidateCommiterAndReviewer should validate emails in case insensitive manner
1877         https://bugs.webkit.org/show_bug.cgi?id=208645
1878
1879         Reviewed by Alexey Proskuryakov.
1880
1881         * BuildSlaveSupport/ews-build/steps.py:
1882         (ValidateCommiterAndReviewer.load_contributors):
1883         (ValidateCommiterAndReviewer.start):
1884
1885 2020-03-05  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1886
1887         style-checker: Add UAF to the list of security words to warn about.
1888         https://bugs.webkit.org/show_bug.cgi?id=208643
1889
1890         Reviewed by Jonathan Bedard.
1891
1892         UAF is a common acronym used for use after free.
1893
1894         * Scripts/webkitpy/style/checkers/changelog.py:
1895         (ChangeLogChecker.check_for_unwanted_security_phrases):
1896
1897 2020-03-04  Basuke Suzuki  <basuke.suzuki@sony.com>
1898
1899         [MSVC] Add .natvis support of WebKit types
1900         https://bugs.webkit.org/show_bug.cgi?id=193119
1901
1902         Reviewed by Don Olmstead.
1903
1904         To help the WebKit developer while debugging, this file defines how
1905         WebKit types are displayed in debugger of Visual Studio.
1906         Very limited set of WebKit types, but it changes the world.
1907
1908         * VisualStudio/WebKit.natvis: Added.
1909
1910 2020-03-04  Wenson Hsieh  <wenson_hsieh@apple.com>
1911
1912         Add system trace points around display list replay
1913         https://bugs.webkit.org/show_bug.cgi?id=208616
1914
1915         Reviewed by Simon Fraser.
1916
1917         Add a new "Display list replay" trace point.
1918
1919         * Tracing/SystemTracePoints.plist:
1920
1921 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1922
1923         Call globalObjectIsAvailableForFrame before evaluating JavaScript in newly created worlds
1924         https://bugs.webkit.org/show_bug.cgi?id=208615
1925         <rdar://problem/59406743>
1926
1927         Reviewed by Alex Christensen.
1928
1929         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1930         * TestWebKitAPI/Tests/WebKitCocoa/ContentWorldPlugIn.mm: Added.
1931         (-[ContentWorldPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1932         (-[ContentWorldPlugIn webProcessPlugInBrowserContextController:globalObjectIsAvailableForFrame:inScriptWorld:]):
1933         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
1934         (TEST):
1935         Also make a test written in bug 206310 actually run code.
1936
1937 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
1938
1939         [build.webkit.org] Remove leaks queue
1940         https://bugs.webkit.org/show_bug.cgi?id=208580
1941
1942         Reviewed by Jonathan Bedard.
1943
1944         * BuildSlaveSupport/build.webkit.org-config/config.json:
1945         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
1946         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
1947
1948 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1949
1950         Add SPI to evaluate JavaScript in an iframe
1951         https://bugs.webkit.org/show_bug.cgi?id=208605
1952
1953         Reviewed by Brady Eidson.
1954
1955         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1956
1957 2020-03-03  Jiewen Tan  <jiewen_tan@apple.com>
1958
1959         [WebAuthn] Implement -[_WKWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:] SPI
1960         https://bugs.webkit.org/show_bug.cgi?id=208533
1961         <rdar://problem/60010184>
1962
1963         Reviewed by Alex Christensen.
1964
1965         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1966         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
1967         (-[TestWebAuthenticationPanelDelegate panel:decidePolicyForLocalAuthenticatorWithCompletionHandler:]):
1968         (TestWebKitAPI::TEST):
1969         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]): Deleted.
1970         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Removed.
1971
1972 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1973
1974         callAsyncJavaScript with an invalid parameter and no completionHandler should not crash
1975         https://bugs.webkit.org/show_bug.cgi?id=208593
1976
1977         Reviewed by Brady Eidson.
1978
1979         * TestWebKitAPI/Tests/WebKitCocoa/AsyncFunction.mm:
1980         (TestWebKitAPI::TEST):
1981
1982 2020-03-04  Alex Christensen  <achristensen@webkit.org>
1983
1984         WKWebView's frames accessor should return a traversable type
1985         https://bugs.webkit.org/show_bug.cgi?id=208591
1986
1987         Reviewed by Brady Eidson.
1988
1989         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
1990
1991 2020-03-04  Antoine Quint  <graouts@apple.com>
1992
1993         Add an SPI to allow UserStyleSheet injection to target a specific WKWebView
1994         https://bugs.webkit.org/show_bug.cgi?id=208575
1995         <rdar://problem/59773690>
1996
1997         Reviewed by Brady Eidson.
1998
1999         Add new tests for the new SPI which check:
2000         
2001         1. that specifying forWKWebView: when initializing a _WKUserStyleSheet will inject the provided CSS source in the
2002            specified WKWebView alone,
2003         2. that the same test works with two WKWebViews with a shared WKWebKitConfiguration,
2004         3. that a WKWebView-specific _WKUserStyleSheet can be removed,
2005         4. that a WKWebView-specific _WKUserStyleSheet can be added twice and removed once and be removed as expected,
2006         5. and that a WKWebView-specific _WKUserStyleSheet is automatically removed when navigating to a new page,
2007         6. and that the same test also works with PSON enabled.
2008
2009         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
2010
2011 2020-03-04  Ryan Haddad  <ryanhaddad@apple.com>
2012
2013         [macOS] test-lldb-webkit failing on debug bots
2014         https://bugs.webkit.org/show_bug.cgi?id=208545
2015
2016         Reviewed by Jonathan Bedard.
2017
2018         The lldb-webkit-test step must pass in the build configuration as an
2019         argument to the test-lldb-webkit script so that it uses the lldbWebKitTester
2020         binary that is downloaded with the rest of the build products. Without this
2021         argument, the bots expect to find the binary in the 'WebKitBuild/Release' directory
2022         regardless of their actual build configuration.
2023
2024         * BuildSlaveSupport/build.webkit.org-config/steps.py:
2025         (RunLLDBWebKitTests): Pass in the build configuration to the test-lldb-webkit script.
2026         * Scripts/test-lldb-webkit:
2027         (LldbTester.parse_args): Capitalize the constants for Debug / Release since that is what webkitpy expects.
2028
2029 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2030
2031         [ews] Add build step to create local git commit for commit-queue (follow-up fix)
2032         https://bugs.webkit.org/show_bug.cgi?id=208539
2033
2034         Unreviewed follow-up fix.
2035
2036         * BuildSlaveSupport/ews-build/steps.py:
2037
2038 2020-03-04  Daniel Bates  <dabates@apple.com>
2039
2040         Should use -bounds instead of -frame in RequestTextInputContext.mm tests
2041         https://bugs.webkit.org/show_bug.cgi?id=208565
2042
2043         Reviewed by Wenson Hsieh.
2044
2045         Pass the bounds of the web view to -synchronouslyRequestTextInputContextsInRect: instead
2046         of its frame as a means to find all the editable elements in the visible content area
2047         of the web view.
2048
2049         Coincidentally this makes no difference to the test results right now because the web view
2050         happens to be located at the origin (0, 0) in the window. However if in the future the
2051         web view would be located at some other point then the tests may fail because the rectangle
2052         passed to -synchronouslyRequestTextInputContextsInRect: would no longer represent the
2053         rectangle for the visible content area.
2054
2055         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2056         (TEST):
2057
2058 2020-03-04  Daniel Bates  <dabates@apple.com>
2059
2060         Organize tests in RequestTextInputContext.mm tests under test name RequestTextInputContext
2061         https://bugs.webkit.org/show_bug.cgi?id=208564
2062
2063         Reviewed by Alex Christensen.
2064
2065         Group the tests in RequestTextInputContext.mm under the test case name RequestTextInputContext
2066         to make it easy to run just these tests.
2067
2068         Currently, the tests are organized under the test case name WebKit. This means you need to
2069         pass run-api-tests the name of each sub-test as there is no easy way to run them all without
2070         also running all the TestWebKitAPI.WebKit sub-tests. Instead organize them under RequestTextInputContext
2071         so that a person can run just these test using:
2072         
2073                 run-api-tests --debug TestWebKitAPI.RequestTextInputContext
2074
2075         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2076         (TEST):
2077
2078 2020-03-04  Aakash Jain  <aakash_jain@apple.com>
2079
2080         [ews] Add build step to create local git commit for commit-queue
2081         https://bugs.webkit.org/show_bug.cgi?id=208539
2082
2083         Reviewed by Jonathan Bedard.
2084
2085         * BuildSlaveSupport/ews-build/steps.py:
2086         (CreateLocalGITCommit): Build step to create local git commit.
2087         (CreateLocalGITCommit.start):
2088         (CreateLocalGITCommit.getResultSummary): Set custom failure message.
2089         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests and restructured imports.
2090         * BuildSlaveSupport/ews-build/factories.py:
2091
2092 2020-03-04  Simon Fraser  <simon.fraser@apple.com>
2093
2094         (r256513) [ Mac ] fast/scrolling/programmatic-scroll-to-zero-zero.html is a flaky failure
2095         https://bugs.webkit.org/show_bug.cgi?id=207948
2096
2097         Reviewed by Zalan Bujtas.
2098
2099         EventSendingController needs to trigger layout so that the WebHTMLView is not 0x0,
2100         so that it receives the wheel events.
2101
2102         * DumpRenderTree/mac/EventSendingController.mm:
2103         (-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
2104         * DumpRenderTree/win/EventSender.cpp:
2105         (mouseScrollBy):
2106
2107 2020-03-04  Andres Gonzalez  <andresg_22@apple.com>
2108
2109         REGRESSION (r257739): two fast/events/autoscroll test have started to fail
2110         https://bugs.webkit.org/show_bug.cgi?id=208520
2111         <rdar://problem/60000214>
2112
2113         Reviewed by Chris Fleizach.
2114
2115         Calling InjectedBundle::singleton().page()->page() in the constructor
2116         of the AccessibilityController is having this side effect on iOS.
2117         So #if to MAC where it's actually being used.
2118
2119         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2120         (WTR::AccessibilityController::AccessibilityController):
2121
2122 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2123
2124         Add SPI _WKResourceLoadInfo.loadedFromCache
2125         https://bugs.webkit.org/show_bug.cgi?id=208554
2126
2127         Reviewed by Wenson Hsieh.
2128
2129         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2130         (TEST):
2131
2132 2020-03-03  Ryosuke Niwa  <rniwa@webkit.org>
2133
2134         Batch observations and completions of text manipulations
2135         https://bugs.webkit.org/show_bug.cgi?id=208406
2136
2137         Reviewed by Wenson Hsieh.
2138
2139         Updated the existing tests to use new APIs, and added new tests for batching finding & replacing
2140         multiple paragraphs at once.
2141
2142         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2143         (-[TextManipulationDelegate _webView:didFindTextManipulationItems:]):
2144         (-[TextManipulationDelegate items]):
2145         (-[LegacyTextManipulationDelegate init]):
2146         (-[LegacyTextManipulationDelegate _webView:didFindTextManipulationItem:]):
2147         (TextManipulation.StartTextManipulationSupportsLegacyDelegateCallback): Added.
2148         (TextManipulation.LegacyCompleteTextManipulationReplaceSimpleSingleParagraph): Added.
2149         (TextManipulation.CompleteTextManipulationReplaceMultipleSimpleParagraphsAtOnce): Added.
2150         (TextManipulation.CompleteTextManipulationShouldBatchItemCallback): Added.
2151         (TextManipulation.CompleteTextManipulationFailWhenItemIdentifierIsDuplicated): Added.
2152         (TextManipulation.CompleteTextManipulationCanHandleSubsetOfItemsToFail): Added.
2153
2154 2020-03-03  Per Arne Vollan  <pvollan@apple.com>
2155
2156         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2157         https://bugs.webkit.org/show_bug.cgi?id=208415
2158
2159         Reviewed by Brent Fulgham.
2160
2161         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2162         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2163         (TEST):
2164
2165 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2166
2167         Add response to _WKResourceLoadDelegate didCompleteWithError callback
2168         https://bugs.webkit.org/show_bug.cgi?id=208553
2169
2170         Reviewed by Simon Fraser.
2171
2172         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2173         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:response:]):
2174         (TEST):
2175         (-[TestResourceLoadDelegate webView:resourceLoad:didCompleteWithError:]): Deleted.
2176
2177 2020-03-03  Brady Eidson  <beidson@apple.com>
2178
2179         API Test [Mojave+ WK2 Debug ] TestWebKitAPI.WKAttachmentTestsMac.InsertDroppedFilePromisesAsAttachments is a flaky crash.
2180         https://bugs.webkit.org/show_bug.cgi?id=198795
2181
2182         Reviewed by Chris Dumez.
2183
2184         This test appears to no longer be flaky.
2185         
2186         Let's re-enable it.
2187         
2188         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2189         (TestWebKitAPI::TEST):
2190
2191 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2192
2193         Requests sent to _WKResourceLoadDelegate should include HTTPBody
2194         https://bugs.webkit.org/show_bug.cgi?id=208550
2195
2196         Reviewed by Tim Hatcher.
2197
2198         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2199         (TEST):
2200         * TestWebKitAPI/cocoa/HTTPServer.mm:
2201         (TestWebKitAPI::HTTPServer::respondToRequests):
2202         HTTPServer now looks for Content-Length in its request.
2203         If it finds this header, that means that the HTTP body is going to be received in another read, then the response should be sent after receiving that.
2204
2205 2020-03-03  Alex Christensen  <achristensen@webkit.org>
2206
2207         Expose originalURL and originalHTTPMethod on _WKResourceLoadInfo
2208         https://bugs.webkit.org/show_bug.cgi?id=208522
2209
2210         Reviewed by Brian Weinstein.
2211
2212         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
2213         (TEST):
2214
2215 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2216
2217         commit-queue should update working directory and reapply patch just before commiting
2218         https://bugs.webkit.org/show_bug.cgi?id=208521
2219
2220         Reviewed by Jonathan Bedard.
2221
2222         * BuildSlaveSupport/ews-build/factories.py:
2223
2224 2020-03-03  Matt Lewis  <jlewis3@apple.com>
2225
2226         Add Unittest to commits_for_upload() and fix multiple unittests for several test suites.
2227         https://bugs.webkit.org/show_bug.cgi?id=208485
2228
2229         Reviewed by Jonathan Bedard.
2230
2231         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
2232         (StubRepository.__init__): Fixing the constructor to call upon the parent class as we were not doing this before. It also means
2233         that we don't have to recreate the variables that are already created.
2234         * Scripts/webkitpy/common/checkout/scm/stub_repository_unittest.py: High level changed the imports to better reflect what we are using
2235         from each module, rather than making extra imports that we don't need.
2236         (StubRepositoryTest.mock_host_for_stub_repository): Since we are calling both an executive and a filesystem mock for most of the
2237         tests. it makes more sense to create a mock host with the files needed, than it does to instantiate each of these as separate objects
2238         and not part of the host.
2239         (StubRepositoryTest.test_in_working_directory): Changed the filesystem call to the host call.
2240         (StubRepositoryTest.test_native_revision): Changed the filesystem call to the host call.
2241         (StubRepositoryTest.test_native_branch): Changed the filesystem call to the host call.
2242         (StubRepositoryTest.test_svn_revision): Changed the filesystem call to the host call.
2243         (StubRepositoryTest.test_find_checkout_root): Changed the filesystem call to the host call.
2244         (StubRepositoryTest.test_find_checkout_root_failure): Changed the filesystem call to the host call.
2245         (StubRepositoryTest.test_find_parent_path_matching_callback_condition_with_file_system): Changed the filesystem call to the host call.
2246         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py: 
2247         (SummarizedResultsTest.test_svn_revision_exists): Changed the name to original test to better reflect that it was just looking to see
2248         if we were geting any value at all
2249         (SummarizedResultsTest.test_svn_revision): Added a test to make sure that the revision we are getting is what we expect to get and make
2250         sure we aren't gabking the wrong key:value pair
2251         * Scripts/webkitpy/port/base_unittest.py: Changed from MockSystemHost to MockHost as we want the extras that
2252         come with the MockHosts and MockHost inherits from MockSystemHost.
2253         (PortTest.make_port): Changed the port to call MockHost that will creat the required stub_repository files.
2254         (test_commits_for_upload): Added amissing test for commits_for_upload as this has been an issue when trying to make changes
2255         to the various upload steps.
2256
2257 2020-03-03  Aakash Jain  <aakash_jain@apple.com>
2258
2259         [ews] Add build step to find list of modified changelogs
2260         https://bugs.webkit.org/show_bug.cgi?id=208514
2261
2262         Reviewed by Jonathan Bedard.
2263
2264         * BuildSlaveSupport/ews-build/factories.py:
2265         * BuildSlaveSupport/ews-build/steps.py:
2266         (FindModifiedChangeLogs): Build step to find modified ChangeLogs.
2267         (FindModifiedChangeLogs.start): Initialize log observer.
2268         (FindModifiedChangeLogs.getResultSummary): Set custom failure message.
2269         (FindModifiedChangeLogs.evaluateCommand):
2270         (FindModifiedChangeLogs.is_path_to_changelog): Check if the file is a ChangeLog.
2271         (FindModifiedChangeLogs._status_regexp): Regex to match files from git output.
2272         (FindModifiedChangeLogs.extract_changelogs): Method to get list of ChangeLogs from git output.
2273         * BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2274
2275 2020-03-03  Ryan Haddad  <ryanhaddad@apple.com>
2276
2277         [iOS EWS] TestWebKitAPI.WKWebsiteDataStore.RemoveAndFetchData is failing
2278         https://bugs.webkit.org/show_bug.cgi?id=208451
2279
2280         Unreviewed test gardening.
2281
2282         * TestWebKitAPI/Tests/WebKitCocoa/WKWebsiteDatastore.mm: Disable the test for iOS since it is slowing down EWS.
2283
2284 2020-03-03  Jiten Mehta  <jmehta@apple.com>
2285
2286         Adopt HTTP Alternative Services Storage
2287         https://bugs.webkit.org/show_bug.cgi?id=208387
2288
2289         Reviewed by Alex Christensen.
2290
2291         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2292         (checkUntilEntryFound):
2293         (TEST):
2294
2295 2020-03-03  Kate Cheney  <katherine_cheney@apple.com>
2296
2297         Check for navigation to app-bound domain during script evaluation
2298         https://bugs.webkit.org/show_bug.cgi?id=208319
2299         <rdar://problem/57569321>
2300
2301         Reviewed by Brent Fulgham.
2302
2303         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2304         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm: Added.
2305         (-[TestInAppBrowserScriptMessageHandler userContentController:didReceiveScriptMessage:]):
2306         (TEST):
2307         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-agent-script.html: Added.
2308         * TestWebKitAPI/Tests/WebKitCocoa/in-app-browser-privacy-test-user-script.html: Added.
2309
2310 2020-03-03  Commit Queue  <commit-queue@webkit.org>
2311
2312         Unreviewed, rolling out r257754.
2313         https://bugs.webkit.org/show_bug.cgi?id=208513
2314
2315         Introduced API test failure (Requested by perarne on #webkit).
2316
2317         Reverted changeset:
2318
2319         "[Cocoa] Mapping from MIME type to UTI type should be done in
2320         the UI process"
2321         https://bugs.webkit.org/show_bug.cgi?id=208415
2322         https://trac.webkit.org/changeset/257754
2323
2324 2020-03-03  Diego Pino Garcia  <dpino@igalia.com>
2325
2326         REGRESSION(r257726): [GTK] LayoutTests crashing after r257726
2327         https://bugs.webkit.org/show_bug.cgi?id=208506
2328
2329         Reviewed by Carlos Garcia Campos.
2330
2331         * WebKitTestRunner/TestController.cpp:
2332         (WTR::TestController::platformAdjustContext): Remove unnecessary code.
2333
2334 2020-03-02  Ben Nham  <nham@apple.com>
2335
2336         Add performance probes for HTML parsing
2337         https://bugs.webkit.org/show_bug.cgi?id=208271
2338
2339         Reviewed by Daniel Bates.
2340
2341         This adds probes that show which lines of HTML are have been parsed.
2342
2343         * Tracing/SystemTracePoints.plist:
2344
2345 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2346
2347         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2348         https://bugs.webkit.org/show_bug.cgi?id=208415
2349
2350         Reviewed by Brent Fulgham.
2351
2352         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2353         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2354         (TEST):
2355
2356 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2357
2358         Unreviewed, rolling out r257725.
2359
2360         This commit caused 10 API tests to fail
2361
2362         Reverted changeset:
2363
2364         "[Cocoa] Mapping from MIME type to UTI type should be done in
2365         the UI process"
2366         https://bugs.webkit.org/show_bug.cgi?id=208415
2367         https://trac.webkit.org/changeset/257725
2368
2369 2020-03-02  Saam Barati  <sbarati@apple.com>
2370
2371         Don't skip tests unnecessarily on arm64
2372         https://bugs.webkit.org/show_bug.cgi?id=208470
2373         <rdar://problem/59968869>
2374
2375         Reviewed by Tadeu Zagallo.
2376
2377         * Scripts/run-jsc-stress-tests:
2378
2379 2020-03-02  Andres Gonzalez  <andresg_22@apple.com>
2380
2381         Fix for LayoutTests/accessibility/mac/search-text/search-text.html in IsolatedTree mode.
2382         https://bugs.webkit.org/show_bug.cgi?id=208434
2383
2384         Reviewed by Chris Fleizach.
2385
2386         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2387         (WTR::AccessibilityController::AccessibilityController): Initializes m_useAXThread.
2388         (WTR::AccessibilityController::rootElement): No need to set m_useAXThread here since it is initialize in the constructor.
2389         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2390         (WTR::AccessibilityController::accessibleElementById): Same as above.
2391
2392 2020-03-02  John Wilander  <wilander@apple.com>
2393
2394         ResourceLoadStatistics: Enable cookie blocking and the Storage Access API in ephemeral sessions
2395         https://bugs.webkit.org/show_bug.cgi?id=208399
2396         <rdar://problem/24731650>
2397
2398         Reviewed by Brent Fulgham.
2399
2400         The majority of the changes in WTR::TestController is (partially) fixing a bug
2401         where the TestRunner would statically use the default website datastore instead
2402         of the website data store configure for the page. This worked for persistent
2403         storage testing but not for ephemeral sessions which is what this patch is all
2404         about. The previous TestController::websiteDataStore() is now called
2405         TestController::defaultWebsiteDataStore() and the new
2406         TestController::websiteDataStore() returns the configured website data store.
2407         Most of the use of the default website data store should probably change but
2408         that's not really for this patch to deal with. I did however move all of
2409         resource load statistics' use to the new TestController::websiteDataStore().
2410
2411         A new TestRunner function was added: isStatisticsEphemeral()
2412         It allows test cases to query the ephemeral status of resource load statistics.
2413
2414         One problem that is mitigated in this patch but not fully fixed is that for
2415         Cocoa platforms, the TestRunner sets up two ephemeral sessions, once in
2416         TestController::generatePageConfiguration() via C API 
2417         WKPageConfigurationSetWebsiteDataStore(), and then again in 
2418         TestControllerCocoa's initializeWebViewConfiguration() via Cocoa API
2419         [copiedConfiguration setWebsiteDataStore:ephemeralWebsiteDataStore].
2420         I tried removing the latter since one session for all platforms should be
2421         Enough but got broken behavior as a result. So now both are still there
2422         and both enable resource load statistics.
2423
2424         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2425         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2426         (WTR::TestRunner::isStatisticsEphemeral):
2427         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2428         * WebKitTestRunner/TestController.cpp:
2429         (WTR::TestController::defaultWebsiteDataStore):
2430         (WTR::TestController::websiteDataStore):
2431         (WTR::TestController::generatePageConfiguration):
2432         (WTR::TestController::resetPreferencesToConsistentValues):
2433         (WTR::TestController::resetStateToConsistentValues):
2434         (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
2435         (WTR::TestController::decidePolicyForNavigationAction):
2436         (WTR::TestController::platformAdjustContext):
2437         (WTR::TestController::clearServiceWorkerRegistrations):
2438         (WTR::TestController::clearDOMCache):
2439         (WTR::TestController::clearDOMCaches):
2440         (WTR::TestController::clearIndexedDatabases):
2441         (WTR::TestController::clearLocalStorage):
2442         (WTR::TestController::hasDOMCache):
2443         (WTR::TestController::domCacheSize):
2444         (WTR::TestController::setStatisticsEnabled):
2445         (WTR::TestController::isStatisticsEphemeral):
2446         (WTR::TestController::setStatisticsDebugMode):
2447         (WTR::TestController::setStatisticsPrevalentResourceForDebugMode):
2448         (WTR::TestController::setStatisticsLastSeen):
2449         (WTR::TestController::setStatisticsMergeStatistic):
2450         (WTR::TestController::setStatisticsPrevalentResource):
2451         (WTR::TestController::setStatisticsVeryPrevalentResource):
2452         (WTR::TestController::dumpResourceLoadStatistics):
2453         (WTR::TestController::isStatisticsPrevalentResource):
2454         (WTR::TestController::isStatisticsVeryPrevalentResource):
2455         (WTR::TestController::isStatisticsRegisteredAsSubresourceUnder):
2456         (WTR::TestController::isStatisticsRegisteredAsSubFrameUnder):
2457         (WTR::TestController::isStatisticsRegisteredAsRedirectingTo):
2458         (WTR::TestController::setStatisticsHasHadUserInteraction):
2459         (WTR::TestController::isStatisticsHasHadUserInteraction):
2460         (WTR::TestController::isStatisticsOnlyInDatabaseOnce):
2461         (WTR::TestController::setStatisticsGrandfathered):
2462         (WTR::TestController::isStatisticsGrandfathered):
2463         (WTR::TestController::setUseITPDatabase):
2464         (WTR::TestController::setStatisticsSubframeUnderTopFrameOrigin):
2465         (WTR::TestController::setStatisticsSubresourceUnderTopFrameOrigin):
2466         (WTR::TestController::setStatisticsSubresourceUniqueRedirectTo):
2467         (WTR::TestController::setStatisticsSubresourceUniqueRedirectFrom):
2468         (WTR::TestController::setStatisticsTopFrameUniqueRedirectTo):
2469         (WTR::TestController::setStatisticsTopFrameUniqueRedirectFrom):
2470         (WTR::TestController::setStatisticsCrossSiteLoadWithLinkDecoration):
2471         (WTR::TestController::setStatisticsTimeToLiveUserInteraction):
2472         (WTR::TestController::statisticsProcessStatisticsAndDataRecords):
2473         (WTR::TestController::statisticsUpdateCookieBlocking):
2474         (WTR::TestController::statisticsSubmitTelemetry):
2475         (WTR::TestController::setStatisticsNotifyPagesWhenDataRecordsWereScanned):
2476         (WTR::TestController::setStatisticsIsRunningTest):
2477         (WTR::TestController::setStatisticsShouldClassifyResourcesBeforeDataRecordsRemoval):
2478         (WTR::TestController::setStatisticsNotifyPagesWhenTelemetryWasCaptured):
2479         (WTR::TestController::setStatisticsMinimumTimeBetweenDataRecordsRemoval):
2480         (WTR::TestController::setStatisticsGrandfatheringTime):
2481         (WTR::TestController::setStatisticsMaxStatisticsEntries):
2482         (WTR::TestController::setStatisticsPruneEntriesDownTo):
2483         (WTR::TestController::statisticsClearInMemoryAndPersistentStore):
2484         (WTR::TestController::statisticsClearInMemoryAndPersistentStoreModifiedSinceHours):
2485         (WTR::TestController::statisticsClearThroughWebsiteDataRemoval):
2486         (WTR::TestController::statisticsDeleteCookiesForHost):
2487         (WTR::TestController::isStatisticsHasLocalStorage):
2488         (WTR::TestController::setStatisticsCacheMaxAgeCap):
2489         (WTR::TestController::hasStatisticsIsolatedSession):
2490         (WTR::TestController::setStatisticsShouldDowngradeReferrer):
2491         (WTR::TestController::setStatisticsShouldBlockThirdPartyCookies):
2492         (WTR::TestController::setStatisticsFirstPartyWebsiteDataRemovalMode):
2493         (WTR::TestController::statisticsResetToConsistentState):
2494         (WTR::TestController::clearAdClickAttributionsThroughWebsiteDataRemoval):
2495         * WebKitTestRunner/TestController.h:
2496         * WebKitTestRunner/TestInvocation.cpp:
2497         (WTR::TestInvocation::invoke):
2498         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2499         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2500         (WTR::initializeWebViewConfiguration):
2501         (WTR::TestController::platformCreateWebView):
2502
2503 2020-03-02  Per Arne Vollan  <pvollan@apple.com>
2504
2505         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2506         https://bugs.webkit.org/show_bug.cgi?id=208415
2507
2508         Reviewed by Brent Fulgham.
2509
2510         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2511         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2512         (TEST):
2513
2514 2020-03-02  Daniel Bates  <dabates@apple.com>
2515
2516         Page::editableElementsInRect() should find nested editable elements and return found elements in paint order
2517         https://bugs.webkit.org/show_bug.cgi?id=208352
2518         <rdar://problem/59867815>
2519
2520         Reviewed by Wenson Hsieh.
2521
2522         Update test results to reflect the new behavior. To do this I also need to fix up the test code
2523         to actually scroll the web content. This also means we now execute the same code on both Mac and
2524         iOS to do the scrolling: window.scrollTo(0, 5000). Also fixed up sub-test "Inputs scrolled outside
2525         the requested rect; should not be included." to use a 10000px height <div> so that you can scroll
2526         to a y position of 5000. Otherwise, it's impossible to do because the page height is < 5000px.
2527
2528         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
2529         (TEST):
2530
2531 2020-03-02  Jacob Uphoff  <jacob_uphoff@apple.com>
2532
2533         Unreviewed, rolling out r257687.
2534
2535         This commit caused debug tests to crash for macOS & iOS
2536
2537         Reverted changeset:
2538
2539         "[Cocoa] Mapping from MIME type to UTI type should be done in
2540         the UI process"
2541         https://bugs.webkit.org/show_bug.cgi?id=208415
2542         https://trac.webkit.org/changeset/257687
2543
2544 2020-03-01  Wenson Hsieh  <wenson_hsieh@apple.com>
2545
2546         Unreviewed, rolling out r257618.
2547
2548         This allegedly causes Safari to crash when closing a window
2549         (see rdar://problem/59922725).
2550
2551         Reverted changeset:
2552
2553         "UIProcess crash after using _prepareForMoveToWindow, then
2554         deallocating the WKWebView before moving to the window"
2555         https://bugs.webkit.org/show_bug.cgi?id=208365
2556         https://trac.webkit.org/changeset/257618
2557
2558 2020-02-29  Yusuke Suzuki  <ysuzuki@apple.com>
2559
2560         Remove std::lock_guard
2561         https://bugs.webkit.org/show_bug.cgi?id=206451
2562
2563         Reviewed by Anders Carlsson.
2564
2565         Add std::lock_guard lint rule to prevent from using it.
2566
2567         * Scripts/webkitpy/style/checkers/cpp.py:
2568         (check_lock_guard):
2569         (check_style):
2570         (CppChecker):
2571         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2572         (WebKitStyleTest.test_lock_guard):
2573         * TestWebKitAPI/Tests/WTF/Condition.cpp:
2574         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
2575         * TestWebKitAPI/Tests/WTF/bmalloc/IsoHeap.cpp:
2576         (assertHasObjects):
2577         (assertHasOnlyObjects):
2578         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
2579         (WTR::AXThread::dispatch):
2580         (WTR::AXThread::dispatchFunctionsFromAXThread):
2581         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:
2582         (WTR::AXThread::initializeRunLoop):
2583
2584 2020-02-29  Per Arne Vollan  <pvollan@apple.com>
2585
2586         [Cocoa] Mapping from MIME type to UTI type should be done in the UI process
2587         https://bugs.webkit.org/show_bug.cgi?id=208415
2588
2589         Reviewed by Brent Fulgham.
2590
2591         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2592         * TestWebKitAPI/Tests/WebKit/UTIFromMIMEType.mm: Added.
2593         (TEST):
2594
2595 2020-02-28  Fujii Hironori  <Hironori.Fujii@sony.com>
2596
2597         Unreviewed, rolling out r257565.
2598
2599         It broke WinCairo MiniBrowser
2600
2601         Reverted changeset:
2602
2603         "[CMake] Use WEBKIT_EXECUTABLE in MiniBrowser"
2604         https://bugs.webkit.org/show_bug.cgi?id=206894
2605         https://trac.webkit.org/changeset/257565
2606
2607 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2608
2609         EWS fails to retry build in case of kill-old-processes exception
2610         https://bugs.webkit.org/show_bug.cgi?id=208003
2611
2612         Reviewed by Jonathan Bedard.
2613
2614         * BuildSlaveSupport/ews-build/steps.py:
2615         (KillOldProcesses.evaluateCommand):
2616         (KillOldProcesses.getResultSummary):
2617
2618 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2619
2620         [ews] commit-queue should update the ChangeLog with Reviewer name
2621         https://bugs.webkit.org/show_bug.cgi?id=206535
2622
2623         Reviewed by Jonathan Bedard.
2624
2625         * BuildSlaveSupport/ews-build/steps.py:
2626         (ApplyPatch.start): Update the patch with the patch reviewer name if available.
2627
2628 2020-02-28  Jonathan Bedard  <jbedard@apple.com>
2629
2630         run-javascriptcore-tests: Make upload format valid
2631         https://bugs.webkit.org/show_bug.cgi?id=208341
2632
2633         Rubber-stamped by Aakash Jain.
2634
2635         * Scripts/run-javascriptcore-tests:
2636         (uploadResults): Remove. FIXME.
2637         * Scripts/webkitdirs.pm:
2638         (splitVersionString): Handle case where the subminor version number has a - in it.
2639         * Scripts/webkitperl/webkitdirs_unittest/splitVersion.pl: Add unit tests.
2640
2641 2020-02-28  youenn fablet  <youenn@apple.com>
2642
2643         [MacOS/iOS] Enable audio/video capture in GPUProcess by default
2644         https://bugs.webkit.org/show_bug.cgi?id=208130
2645
2646         Reviewed by Eric Carlson.
2647
2648         * WebKitTestRunner/TestOptions.h:
2649         Use GPU process to capture by default.
2650         We will remove this option once done verifying that every test works smoothly.
2651
2652 2020-02-28  Aakash Jain  <aakash_jain@apple.com>
2653
2654         [ews] commit queue should skip building and testing for rollout patches
2655         https://bugs.webkit.org/show_bug.cgi?id=208329
2656
2657         Reviewed by Jonathan Bedard.
2658
2659         * BuildSlaveSupport/ews-build/steps.py:
2660         (BugzillaMixin._is_patch_obsolete): Set rollout property appropriately.
2661         (CompileWebKit.doStepIf): Skip tests for rollout patches on commit-queue.
2662         (RunWebKit1Tests.doStepIf): Ditto.
2663         * BuildSlaveSupport/ews-build/steps_unittest.py:
2664         (TestCompileWebKit.test_skip_for_rollout_patches_on_commit_queue): Added unit-test.
2665         (TestRunWebKit1Tests.test_skip_for_rollout_patches_on_commit_queue): Ditto.
2666
2667 2020-02-28  Daniel Bates  <dabates@apple.com>
2668
2669         Update my watch list preferences and contributor's entry.
2670
2671         * Scripts/webkitpy/common/config/contributors.json:
2672         * Scripts/webkitpy/common/config/watchlist:
2673
2674 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2675
2676         Fix WebCore export macros for declspec
2677         https://bugs.webkit.org/show_bug.cgi?id=208363
2678
2679         Reviewed by Konstantin Tokarev.
2680
2681         Remove setting of WEBCORE_EXPORT and WEBCORE_TESTSUPPORT_EXPORT from the header
2682         files. Removed precompiled headers that were empty.
2683
2684         * DumpRenderTree/DumpRenderTreePrefix.h:
2685         * DumpRenderTree/win/DefaultPolicyDelegate.cpp: Added a missing config.h.
2686         * MiniBrowser/win/stdafx.h:
2687         * TestWebKitAPI/win/TestWebKitAPIPrefix.cpp: Removed.
2688         * TestWebKitAPI/win/TestWebKitAPIPrefix.h: Removed.
2689         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.cpp: Removed.
2690         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h: Removed.
2691         * WebKitTestRunner/PlatformFTW.cmake:
2692         * WebKitTestRunner/PlatformWin.cmake:
2693         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
2694
2695 2020-02-27  Tim Horton  <timothy_horton@apple.com>
2696
2697         UIProcess crash after using _prepareForMoveToWindow, then deallocating the WKWebView before moving to the window
2698         https://bugs.webkit.org/show_bug.cgi?id=208365
2699
2700         Reviewed by Alex Christensen.
2701
2702         * TestWebKitAPI/Tests/WebKitCocoa/PrepareForMoveToWindow.mm:
2703         (TEST):
2704         Add a test! It was a 100% repro crash before this change.
2705
2706 2020-02-27  Kate Cheney  <katherine_cheney@apple.com>
2707
2708         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2709         https://bugs.webkit.org/show_bug.cgi?id=208260
2710         <rdar://problem/59820107>
2711
2712         Reviewed by Tim Horton.
2713
2714         Followed instructions for adding an Info.plist for Single-File Tools
2715         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2716
2717         The default WebsiteDataStore file path will change with this test to
2718         reflect the new bundleID so we must change expectations for any api
2719         tests which rely on knowing the path.
2720
2721         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2722         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2723         * TestWebKitAPI/Tests/WebKitCocoa/IDBDeleteRecovery.mm:
2724         (TEST):
2725         * TestWebKitAPI/Tests/WebKitCocoa/IDBIndexUpgradeToV2.mm:
2726         (TEST):
2727         * TestWebKitAPI/Tests/WebKitCocoa/IDBObjectStoreInfoUpgradeToV2.mm:
2728         (TEST):
2729         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBStructuredCloneBackwardCompatibility.mm:
2730         (TEST):
2731         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBTempFileSize.mm:
2732         (TEST):
2733         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
2734         (TEST):
2735         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageClear.mm:
2736         (TEST):
2737         (defaultWebsiteCacheDirectory):
2738         * TestWebKitAPI/Tests/WebKitCocoa/LocalStorageNullEntries.mm:
2739         (TEST):
2740         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
2741         (TEST):
2742         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
2743         * TestWebKitAPI/Tests/WebKitCocoa/StoreBlobThenDelete.mm:
2744         (TEST):
2745         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
2746         (TEST):
2747         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2748         (runWebsiteDataStoreCustomPaths):
2749         (TEST):
2750         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
2751         (TestWebKitAPI::resetTestState):
2752         Now that we set a bundleID, we have to reset the cache model between
2753         tests, otherwise it gets stored between tests.
2754
2755         (TestWebKitAPI::TEST):
2756         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2757         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2758
2759 2020-02-27  Ryosuke Niwa  <rniwa@webkit.org>
2760
2761         TextManipulationController should not generate a new item for content in manipulated paragraphs
2762         https://bugs.webkit.org/show_bug.cgi?id=208286
2763
2764         Reviewed by Wenson Hsieh.
2765
2766         Added a regression test.
2767
2768         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
2769         (TextManipulation.InsertingContentIntoAlreadyManipulatedContentDoesNotCreateTextManipulationItem):
2770
2771 2020-02-27  Jonathan Bedard  <jbedard@apple.com>
2772
2773         run-javascriptcore-tests: Make upload format valid
2774         https://bugs.webkit.org/show_bug.cgi?id=208341
2775
2776         Reviewed by Aakash Jain.
2777
2778         * Scripts/run-javascriptcore-tests:
2779         (uploadResults): Print json blob for upload after failure for debugging.
2780
2781 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2782
2783         [CMake] Add WebKit::PAL target
2784         https://bugs.webkit.org/show_bug.cgi?id=198493
2785
2786         Reviewed by Michael Catanzaro.
2787
2788         Add workaround for Windows where PAL_FRAMEWORK_HEADERS_DIR is not propagating.
2789
2790         * DumpRenderTree/PlatformWin.cmake:
2791
2792 2020-02-27  Alex Christensen  <achristensen@webkit.org>
2793
2794         Add SPI to query WKFrameInfos in a WKWebView
2795         https://bugs.webkit.org/show_bug.cgi?id=208212
2796
2797         Reviewed by Brady Eidson.
2798
2799         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2800         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2801         * WebKitTestRunner/TestController.cpp:
2802         (WTR::TestController::saltForOrigin):
2803
2804 2020-02-27  Jacob Uphoff  <jacob_uphoff@apple.com>
2805
2806         Unreviewed, rolling out r257530.
2807
2808         This commit seems to have broke the build internally for
2809         watchOS
2810
2811         Reverted changeset:
2812
2813         "Add SPI to query WKFrameInfos in a WKWebView"
2814         https://bugs.webkit.org/show_bug.cgi?id=208212
2815         https://trac.webkit.org/changeset/257530
2816
2817 2020-02-27  Don Olmstead  <don.olmstead@sony.com>
2818
2819         [CMake] Use WEBKIT_EXECUTABLE in MiniBrowser
2820         https://bugs.webkit.org/show_bug.cgi?id=206894
2821
2822         Reviewed by Adrian Perez de Castro.
2823
2824         Modify CMake ports to use WEBKIT_EXECUTABLE when creating their respective
2825         MiniBrowsers.
2826
2827         * MiniBrowser/gtk/CMakeLists.txt:
2828         * MiniBrowser/win/CMakeLists.txt:
2829         * MiniBrowser/wpe/CMakeLists.txt:
2830
2831 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2832
2833         Remove unused WebsiteDataStore::setSourceApplicationBundleIdentifier
2834         https://bugs.webkit.org/show_bug.cgi?id=206456
2835
2836         Reviewed by Brady Eidson.
2837
2838         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2839         (TEST):
2840
2841 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2842
2843         _WKUserContentWorld should be a wrapper around WKContentWorld
2844         https://bugs.webkit.org/show_bug.cgi?id=208274
2845
2846         Reviewed by Brady Eidson.
2847
2848         * TestWebKitAPI/Tests/WebKitCocoa/UserContentWorld.mm:
2849         (TEST):
2850         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
2851         (TEST):
2852
2853 2020-02-26  Ryan Haddad  <ryanhaddad@apple.com>
2854
2855         Unreviewed, rolling out r257522.
2856
2857         Caused 16 API test failures on the bots
2858
2859         Reverted changeset:
2860
2861         "TestWebKitAPI and WebKitTestRunner should have bundle
2862         identifiers"
2863         https://bugs.webkit.org/show_bug.cgi?id=208260
2864         https://trac.webkit.org/changeset/257522
2865
2866 2020-02-26  Alex Christensen  <achristensen@webkit.org>
2867
2868         Add SPI to query WKFrameInfos in a WKWebView
2869         https://bugs.webkit.org/show_bug.cgi?id=208212
2870
2871         Reviewed by Brady Eidson.
2872
2873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2874         * TestWebKitAPI/Tests/WebKit/FrameHandle.cpp: Removed.
2875         * WebKitTestRunner/TestController.cpp:
2876         (WTR::TestController::saltForOrigin):
2877
2878 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2879
2880         TestWebKitAPI and WebKitTestRunner should have bundle identifiers
2881         https://bugs.webkit.org/show_bug.cgi?id=208260
2882         <rdar://problem/59820107>
2883
2884         Reviewed by Tim Horton.
2885
2886         Followed instructions for adding an Info.plist for Single-File Tools
2887         found on https://developer.apple.com/library/archive/documentation/Security/Conceptual/CodeSigningGuide/Procedures/Procedures.html
2888
2889         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2890         * TestWebKitAPI/Info.plist: Added.
2891         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2892         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2893         * WebKitTestRunner/Info.plist: Added.
2894         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2895
2896 2020-02-26  Kate Cheney  <katherine_cheney@apple.com>
2897
2898         Tests should each use a unique ResourceLoadStatistics file path for its database store
2899         https://bugs.webkit.org/show_bug.cgi?id=208206
2900         <rdar://problem/59690272>
2901
2902         Reviewed by Brady Eidson.
2903
2904         Initialize a default website data store before checking for the ITP
2905         store to ensure the directory exists after the file has been deleted.
2906
2907         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
2908         (TEST):
2909
2910 2020-02-26  Christopher Reid  <chris.reid@sony.com>
2911
2912         [Win] Implement NetworkCache::Data by using FileSystem::MappedFileData
2913         https://bugs.webkit.org/show_bug.cgi?id=197684
2914         <rdar://problem/59467397>
2915
2916         Reviewed by Yusuke Suzuki.
2917
2918         Add test for FileSystem::createFile
2919
2920         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
2921
2922 2020-02-26  Aakash Jain  <aakash_jain@apple.com>
2923
2924         [ews] commit-queue should verify patch committer and reviewer
2925         https://bugs.webkit.org/show_bug.cgi?id=206532
2926
2927         Reviewed by Jonathan Bedard.
2928
2929         * BuildSlaveSupport/ews-build/steps.py:
2930         (ValidateCommiterAndReviewer): Build step to validate patch commiter and reviewer.
2931         (ValidateCommiterAndReviewer._addToLog):
2932         (ValidateCommiterAndReviewer.getResultSummary):
2933         (ValidateCommiterAndReviewer.fail_build):
2934         (ValidateCommiterAndReviewer.load_contributors): Load contributors information.
2935         (ValidateCommiterAndReviewer.is_reviewer):
2936         (ValidateCommiterAndReviewer.is_committer):
2937         (ValidateCommiterAndReviewer.full_name_from_email):
2938         (ValidateCommiterAndReviewer.start):
2939
2940 2020-02-26  Daniel Bates  <dabates@apple.com>
2941
2942         [iOS] Send focus update immediately on becoming or resigning first responder
2943         https://bugs.webkit.org/show_bug.cgi?id=208082
2944         <rdar://problem/59688413>
2945
2946         Rubber-stamped by Jer Noble.
2947
2948         Add a test to ensure that selecting a position at a point after the web view
2949         becomes first responder is allowed. Such an operation is only allowed if the
2950         web view is focused.
2951
2952         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
2953         (-[TestWKWebView selectPositionAtPoint:]):
2954         (TEST):
2955         * TestWebKitAPI/ios/UIKitSPI.h: Forward declare SPI.
2956
2957 2020-02-26  Chris Dumez  <cdumez@apple.com>
2958
2959         Unreviewed, disable new DragAndDropTests.DragAndDropOnEmptyView API test on iOS.
2960
2961         The test was added for macOS and times out on iOS.
2962
2963         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
2964         (TEST):
2965
2966 2020-02-26  Youenn Fablet  <youenn@apple.com>
2967
2968         Use WebPageProxy preferences for capture instead of WebProcessPool configuration parameters
2969         https://bugs.webkit.org/show_bug.cgi?id=208238
2970
2971         Reviewed by Eric Carlson.
2972
2973         * TestWebKitAPI/Tests/WebKitCocoa/WKProcessPoolConfiguration.mm:
2974         (TEST):
2975         Remove use of deleted parameter.
2976
2977 2020-02-25  Devin Rousso  <drousso@apple.com>
2978
2979         Web Inspector: safari app extension isolated worlds and injected files use the extension's identifier instead of its name
2980         https://bugs.webkit.org/show_bug.cgi?id=206911
2981         <rdar://problem/58026635>
2982
2983         Reviewed by Brian Burg.
2984
2985         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
2986         (TestWebKitAPI::TEST):
2987         Add test for `WTF::HashSet::reserveInitialCapacity`.
2988
2989         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
2990         (TestWebKitAPI::TEST):
2991         Actually check the value of `WTF::HashMap::capacity`.
2992
2993         * TestWebKitAPI/Tests/WebKitCocoa/_WKInspectorDelegate.mm: Added.
2994         (-[InspectorDelegate _webView:didAttachInspector:])
2995         (-[InspectorDelegate _webView:browserDomainEnabledForInspector:])
2996         (-[InspectorDelegate _webView:browserDomainDisabledForInspector:])
2997         (TestWebKitAPI::TEST):
2998         * TestWebKitAPI/Tests/WebKitCocoa/UIDelegate.mm:
2999         (-[InspectorDelegate _webView:didAttachInspector:]): Deleted.
3000         (TestWebKitAPI::TEST): Deleted.
3001
3002 2020-02-25  Matt Lewis  <jlewis3@apple.com>
3003
3004         Add checkout_root to stubrepository.py
3005         https://bugs.webkit.org/show_bug.cgi?id=208213
3006
3007         Reviewed by Jonathan Bedard.
3008
3009         * Scripts/webkitpy/common/checkout/scm/stub_repository.py:
3010         (StubRepository.__init__):
3011
3012         We are creating our own class variable for checkout_root rather than calling the parent SCM variable
3013         because when initially we left out the parent constructor due to trying to override the fact that we don't actually have a SCM.
3014
3015 2020-02-25  Daniel Bates  <dabates@apple.com>
3016
3017         TestWebKitAPI.PasteMixedContent.CopyAndPasteWithCustomPasteboardDataOnly should wait until copy operation completes
3018         https://bugs.webkit.org/show_bug.cgi?id=208214
3019
3020         Reviewed by Wenson Hsieh.
3021
3022         Wait until the copy operation completes before loading the second web view and testing paste
3023         to ensure that something was actually copied to the clipboard.
3024
3025         * TestWebKitAPI/TestWebKitAPI.xcodeproj/xcshareddata/xcschemes/TestWebKitAPI.xcscheme:
3026         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
3027         (TestWebKitAPI::TEST): Substitute -_synchronouslyExecuteEditCommand for -_executeEditCommand
3028         so that we wait until the command completes.
3029
3030 2020-02-25  Chris Dumez  <cdumez@apple.com>
3031
3032         REGRESSION (r256882): Can't drag an HTML file into a new (empty) Safari tab
3033         https://bugs.webkit.org/show_bug.cgi?id=208199
3034         <rdar://problem/59746887>
3035
3036         Reviewed by Alex Christensen.
3037
3038         Add API test coverage.
3039
3040         * TestWebKitAPI/Tests/WebKitCocoa/DragAndDropTests.mm:
3041         (TEST):
3042
3043 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3044
3045         spinRunLoop should take a non-zero integer as parameter
3046         https://bugs.webkit.org/show_bug.cgi?id=208148
3047         <rdar://problem/59766682>
3048
3049         Unreviewed iOS build fix.
3050
3051         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3052         (TestWebKitAPI::Util::spinRunLoop):
3053
3054 2020-02-25  Sihui Liu  <sihui_liu@apple.com>
3055
3056         spinRunLoop should take a non-zero integer as parameter
3057         https://bugs.webkit.org/show_bug.cgi?id=208148
3058
3059         Reviewed by Darin Adler.
3060
3061         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3062         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
3063         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
3064         (TestWebKitAPI::Util::spinRunLoop):
3065
3066 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3067
3068         [WTF] Add tests for CompactRefPtrTuple
3069         https://bugs.webkit.org/show_bug.cgi?id=208172
3070
3071         Reviewed by Darin Adler.
3072
3073         We copy tests from RefPtr for CompactRefPtrTuple to ensure that it is working correctly.
3074         Many of tests are not necessary since currently CompactRefPtrTuple is non-copyable / non-movable.
3075
3076         * TestWebKitAPI/CMakeLists.txt:
3077         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3078         * TestWebKitAPI/Tests/WTF/CompactRefPtrTuple.cpp: Added.
3079         (TestWebKitAPI::TEST):
3080
3081 2020-02-24  Aakash Jain  <aakash_jain@apple.com>
3082
3083         [ews] commit-queue should check that patch have appropriate review flag
3084         https://bugs.webkit.org/show_bug.cgi?id=208138
3085
3086         Reviewed by Jonathan Bedard.
3087
3088         * BuildSlaveSupport/ews-build/steps.py:
3089         (BugzillaMixin._is_patch_obsolete): Drive-by fix to set build properties for patch author, commiter and reviewer.
3090         (BugzillaMixin._is_patch_cq_plus):
3091         (BugzillaMixin._does_patch_have_acceptable_review_flag): Method to check if patch have r? or r- flag.
3092         (ValidatePatch.start):
3093
3094 2020-02-24  Jiewen Tan  <jiewen_tan@apple.com>
3095
3096         [WebAuthn] Implement SPI for the platform authenticator
3097         https://bugs.webkit.org/show_bug.cgi?id=208087
3098         <rdar://problem/59369305>
3099
3100         Reviewed by Brent Fulgham.
3101
3102         Besides adding API tests, this patch also teaches TestWebKitAPI to use restricted entitlements.
3103
3104         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements:
3105         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3106         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3107         * TestWebKitAPI/Tests/WebKitCocoa/_WKWebAuthenticationPanel.mm:
3108         (-[TestWebAuthenticationPanelDelegate panel:updateWebAuthenticationPanel:]):
3109         (-[TestWebAuthenticationPanelDelegate panel:selectAssertionResponse:completionHandler:]):
3110         (-[TestWebAuthenticationPanelDelegate panel:verifyUserWithAccessControl:completionHandler:]):
3111         (TestWebKitAPI::TEST):
3112         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion-la.html: Copied from Tools/TestWebKitAPI/Tests/WebKitCocoa/web-authentication-get-assertion.html.
3113         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-duplicate-credential.html: Added.
3114         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la-error.html: Added.
3115         * TestWebKitAPI/Tests/WebKitCocoa/web-authentication-make-credential-la.html: Added.
3116
3117 2020-02-24  Yusuke Suzuki  <ysuzuki@apple.com>
3118
3119         Unreviewed, updating LLDB test for CompactPointerTuple.
3120         https://bugs.webkit.org/show_bug.cgi?id=207827
3121
3122         * lldb/lldb_webkit.py:
3123         (WTFCompactPointerTupleProvider):
3124         (WTFCompactPointerTupleProvider.update):
3125
3126 2020-02-24  Ellie Epskamp-Hunt  <eepskamphunt@apple.com>
3127
3128         Provide alternate way to name Web Content process
3129         https://bugs.webkit.org/show_bug.cgi?id=205224
3130         rdar://57038084
3131
3132         Reviewed by Alex Christensen.
3133
3134         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3135         * TestWebKitAPI/Tests/WebKitCocoa/DisplayName.mm: Added.
3136         (TestWebKitAPI::TEST):
3137
3138 2020-02-24  Jonathan Bedard  <jbedard@apple.com>
3139
3140         results.webkit.org: Link to result archives
3141         https://bugs.webkit.org/show_bug.cgi?id=207646
3142         <rdar://problem/59395807>
3143
3144         Rubber-stamped by Aakash Jain.
3145
3146         * resultsdbpy/resultsdbpy/view/static/js/archiveRouter.js: Added.
3147         (_ArchiveRouter): Retrieve json from archive-router endpoint.
3148         (_ArchiveRouter.prototype._determineArgumentFromAncestry): Given an argument, default and ancestry values,
3149         return the most specific value.
3150         (_ArchiveRouter.prototype.hasArchive): Check if a suite and mode have an archive link.
3151         (_ArchiveRouter.prototype.pathFor): Construct the path for archive access.
3152         (_ArchiveRouter.prototype.labelFor): Return a label for an archive link.
3153         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
3154         (parametersForInstance): Extract from lambda function.
3155         (testRunLink): Use parametersForInstance instead of a lambda function.
3156         (archiveLink): Return an archive link for data. 
3157         (contentForData): Add archive link to view.
3158         * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
3159         (TimelineFromEndpoint): Accept both suite and test.
3160         (TimelineFromEndpoint.prototype.render.onDotEnterFactory): Add archive link to pop-over.
3161         * resultsdbpy/resultsdbpy/view/templates/search.html: Pass suite and test to TimelineEndpoint.
3162         * resultsdbpy/resultsdbpy/view/templates/suite_results.html: Pass suite to TimelineEndpoint.
3163         * resultsdbpy/resultsdbpy/view/view_routes.py:
3164         (ViewRoutes.__init__): Add archive_route dictionary.
3165
3166 2020-02-24  Alex Christensen  <achristensen@webkit.org>
3167
3168         WKWebViewConfiguration._corsDisablingPatterns should also disable CORS for non-DocumentThreadableLoader loading
3169         https://bugs.webkit.org/show_bug.cgi?id=208035
3170         <rdar://problem/58011337>
3171
3172         Reviewed by Tim Hatcher.
3173
3174         * TestWebKitAPI/Tests/WebKitCocoa/WKURLSchemeHandler-1.mm:
3175
3176 2020-02-22  Darin Adler  <darin@apple.com>
3177
3178         Fix some include mistakes and make some coding style tweaks to WebKit and WebKitTestRunner
3179         https://bugs.webkit.org/show_bug.cgi?id=208099
3180
3181         Reviewed by Antti Koivisto.
3182
3183         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
3184         Sorted includes the traditional way. Added an include of AccessibilityCommonMac.h
3185         so we can use the -[NSString createJSStringRef] method.
3186         (-[NSString createJSStringRef]): Deleted. This is a duplicate of the method
3187         defined in AccessibilityCommonMac.mm, and was causing a linker warning.
3188
3189 2020-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3190
3191         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html is failing in iOS 13.4 beta
3192         https://bugs.webkit.org/show_bug.cgi?id=208096
3193         <rdar://problem/59632008>
3194
3195         Reviewed by Alexey Proskuryakov.
3196
3197         In the iOS 13.4 beta, the fix for <rdar://problem/56422337> changed -[UIDatePicker setCalendar:], such that
3198         if the new calendar locale matches that of the current calendar's locale (and several other properties of the
3199         new NSCalendar are also unchanged), then the UIDatePicker's calendar will also avoid changing.
3200
3201         In our layout tests, the mechanism we use to simulate the user changing their preferred calendar is no longer
3202         compatible with the above change since the swizzled NSCalendar instance does not have a locale set, so it will
3203         default to the same locale as the one used in the original NSCalendar. This means the call to -setCalendar: ends
3204         up being a no-op, so the test fails to override the simulated Japanese calendar type with a Gregorian calendar
3205         in the credit card expiry field.
3206
3207         To fix this, additionally specify a calendar locale identifier when generating the mock NSCalendar.
3208
3209         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3210         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3211         (WTR::UIScriptController::setDefaultCalendarType):
3212         * WebKitTestRunner/TestController.h:
3213
3214         Change m_overriddenCalendarIdentifier to m_overriddenCalendarAndLocaleIdentifiers, a pair of calendar
3215         identifier and calendar locale identifier.
3216
3217         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3218         (WTR::swizzledCalendar):
3219         (WTR::TestController::overriddenCalendarIdentifier const):
3220         (WTR::TestController::overriddenCalendarLocaleIdentifier const):
3221
3222         Clean these up by returning the `NSString *` instead of making another `RetainPtr`.
3223
3224         (WTR::TestController::setDefaultCalendarType):
3225
3226         Plumb the new calendar's locale identifier through this method.
3227
3228         (WTR::TestController::cocoaResetStateToConsistentValues):
3229         (WTR::TestController::getOverriddenCalendarIdentifier const): Deleted.
3230         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.h:
3231         * WebKitTestRunner/cocoa/UIScriptControllerCocoa.mm:
3232         (WTR::UIScriptControllerCocoa::setDefaultCalendarType):
3233
3234 2020-02-21  Kate Cheney  <katherine_cheney@apple.com>
3235
3236         App-bound domains should have separate Network Sessions
3237         https://bugs.webkit.org/show_bug.cgi?id=208026
3238         <rdar://problem/59434006>
3239
3240         Reviewed by Brent Fulgham.
3241
3242         This patch is mostly test infrastructure involving 3 functions.
3243         One sets in-app browser privacy as enabled in the network process
3244         manually for the test. One ensures that setting the WebView category
3245         works properly, and the last one checks for an app-bound session for
3246         an app-bound navigation.
3247
3248         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3249         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3250         (WTR::InjectedBundle::didReceiveMessageToPage):
3251         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3252         (WTR::TestRunner::getWebViewCategory):
3253         (WTR::TestRunner::callDidReceiveWebViewCategoryCallback):
3254         (WTR::TestRunner::hasAppBoundSession):
3255         (WTR::TestRunner::setInAppBrowserPrivacyEnabled):
3256         (WTR::TestRunner::callDidSetInAppBrowserPrivacyEnabledCallback):
3257         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3258         * WebKitTestRunner/TestController.cpp:
3259         (WTR::TestController::ensureViewSupportsOptionsForTest):
3260         Clearing the bundleID should happen right before setting a new one, 
3261         otherwise it clears the ID after it is set and returns a null ID.
3262
3263         (WTR::TestController::resetStateToConsistentValues):
3264         (WTR::TestController::getWebViewCategory):
3265         (WTR::InAppBrowserPrivacyCallbackContext::InAppBrowserPrivacyCallbackContext):
3266         (WTR::inAppBrowserPrivacyBooleanResultCallback):
3267         (WTR::inAppBrowserPrivacyVoidResultCallback):
3268         (WTR::TestController::hasAppBoundSession):
3269         (WTR::TestController::setInAppBrowserPrivacyEnabled):
3270         * WebKitTestRunner/TestController.h:
3271         * WebKitTestRunner/TestInvocation.cpp:
3272         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3273         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3274         (WTR::TestInvocation::didSetInAppBrowserPrivacyEnabled):
3275         (WTR::TestInvocation::didReceivePrevalentDomains):
3276         (WTR::TestInvocation::didReceiveWebViewCategory):
3277         * WebKitTestRunner/TestInvocation.h:
3278         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3279         (WTR::TestController::getWebViewCategory):
3280
3281 2020-02-21  Jonathan Bedard  <jbedard@apple.com>
3282
3283         Build DumpRenderTree and WebKitTestRunner for macCatalyst
3284         https://bugs.webkit.org/show_bug.cgi?id=208068
3285         <rdar://problem/59676596>
3286
3287         Reviewed by Tim Horton.
3288
3289         * DumpRenderTree/ios/TextInputControllerIOS.m: Import WebKitLegacy explicitly.
3290         * DumpRenderTree/mac/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3291         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: Ditto.
3292         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig: Ditto.
3293         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig: Ditto.
3294         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig: Ditto.
3295         * DumpRenderTree/mac/EditingDelegate.mm: Import WebKitLegacy explicitly.
3296         * DumpRenderTree/mac/EventSendingController.h: Ditto.
3297         * DumpRenderTree/mac/ObjCPlugin.m: Ditto.
3298         * DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.
3299         * Makefile: Add DumpRenderTree and WebKitTestRunner.
3300         * WebKitTestRunner/Configurations/Base.xcconfig: Use cocoatouch instead of SDK.
3301         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Ditto.
3302         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
3303
3304 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3305
3306         [ews] Add build step to Validate ChangeLog for commit-queue
3307         https://bugs.webkit.org/show_bug.cgi?id=208064
3308
3309         Reviewed by Jonathan Bedard.
3310
3311         * BuildSlaveSupport/ews-build/steps.py:
3312         (ValidateChangeLogAndReviewer): Build step to validate ChangeLog.
3313         (ValidateChangeLogAndReviewer.start):
3314         (ValidateChangeLogAndReviewer.evaluateCommand): If the validation fails, comment on bug and mark patch as cq-.
3315         (SetCommitQueueMinusFlagOnPatch.start): End the build (after marking the patch cq-) if build_finish_summary property is set.
3316
3317 2020-02-21  Aakash Jain  <aakash_jain@apple.com>
3318
3319         [ews] Add build step to set cq- flag on bugzilla patch
3320         https://bugs.webkit.org/show_bug.cgi?id=208021
3321
3322         Reviewed by Jonathan Bedard.
3323
3324         * BuildSlaveSupport/ews-build/steps.py:
3325         (BugzillaMixin.set_cq_minus_flag_on_patch):
3326         (SetCommitQueueMinusFlagOnPatch):
3327         (SetCommitQueueMinusFlagOnPatch.start):
3328         (SetCommitQueueMinusFlagOnPatch.getResultSummary):
3329
3330 2020-02-20  Matt Lewis  <jlewis3@apple.com>
3331
3332         Stub repositories fail to upload some results due to missing head svn revision
3333         https://bugs.webkit.org/show_bug.cgi?id=207684
3334
3335         Reviewed by Jonathan Bedard.
3336
3337         * Scripts/webkitpy/common/host_mock.py: Added in call for creating stub repo checkout information for upload tests.
3338         (MockHost.__init__):
3339         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3340         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
3341         * Scripts/webkitpy/layout_tests/models/test_run_results_unittest.py:
3342         (SummarizedResultsTest.setUp): Added in new required parameter for testing.
3343         * Scripts/webkitpy/port/base.py:
3344         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us 
3345         from using mock SCMs and more
3346         * Scripts/webkitpy/port/test.py: Added function to make the checkout_information.json for upload testing.
3347
3348 2020-02-21  Diego Pino Garcia  <dpino@igalia.com>
3349
3350         [JSCOnly] Add --verbose flag when running JavaScriptCore tests
3351         https://bugs.webkit.org/show_bug.cgi?id=208051
3352
3353         Reviewed by Carlos Alberto Lopez Perez.
3354
3355         Verbose flag prints out each test name executed. Without this flag
3356         stdout prints out one or two periods.
3357
3358         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3359         (RunJavaScriptCoreTests.start):
3360
3361 2020-02-21  Michael Catanzaro  <mcatanzaro@gnome.org>
3362
3363         [WPE][GTK] googleapis.com is a public suffix, defeating isGoogle() check in UserAgentQuirks.cpp
3364         https://bugs.webkit.org/show_bug.cgi?id=207984
3365
3366         Reviewed by Daniel Bates.
3367
3368         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3369         (TestWebKitAPI::TEST):
3370
3371 2020-02-20  Michael Catanzaro  <mcatanzaro@gnome.org>
3372
3373         [GTK] Improve user agent quirk for Google Docs and Google Drive
3374         https://bugs.webkit.org/show_bug.cgi?id=206506
3375
3376         Reviewed by Carlos Garcia Campos.
3377
3378         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
3379         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
3380         (TestWebKitAPI::TEST):
3381
3382 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3383
3384         check-webkit-style: Check if *_EXPORT and *_EXPORT_PRIVATE macros are used under corresponding directories
3385         https://bugs.webkit.org/show_bug.cgi?id=207380
3386
3387         Reviewed by Jonathan Bedard.
3388
3389         Added a new rule 'build/export_macro'.
3390
3391         Removed a obsolete rule 'readability/webkit_export' which was used
3392         only by Chromium port (r148185).
3393
3394         * Scripts/webkitpy/style/checkers/cpp.py:
3395         (_FunctionState.export_macro):
3396         (check_function_definition):
3397         (_unix_path): Added.
3398         (is_generated_file): Use _unix_path.
3399         (check_has_config_header): Ditto.
3400         (CppChecker):
3401         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3402         (WebKitStyleTest.test_export_macro_check):
3403         (WebKitStyleTest.test_webkit_export_check): Deleted.
3404
3405 2020-02-20  Fujii Hironori  <Hironori.Fujii@sony.com>
3406
3407         [Win][MiniBrowser] Add prettier toolbar button icons
3408         https://bugs.webkit.org/show_bug.cgi?id=207999
3409
3410         Reviewed by Ross Kirsling.
3411
3412         Use a custom toolbar button icons instead of system stock icons.
3413
3414         Fixed a bug toolbar button dropdown arrows always looked being
3415         hovered. TBSTYLE_FLAT should be given.
3416
3417         Removed the window border line of Progress Indicator.
3418
3419         * MiniBrowser/win/MainWindow.cpp:
3420         (MainWindow::createToolbar):
3421         * MiniBrowser/win/MiniBrowserLib.rc:
3422         * MiniBrowser/win/MiniBrowserLibResource.h:
3423         * MiniBrowser/win/toolbar.bmp: Added.
3424
3425 2020-02-20  Aakash Jain  <aakash_jain@apple.com>
3426
3427         Update run-webkit-tests help description for skip-failing-tests
3428         https://bugs.webkit.org/show_bug.cgi?id=208031
3429
3430         Reviewed by Alexey Proskuryakov.
3431
3432         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3433
3434 2020-02-20  Chris Dumez  <cdumez@apple.com>
3435
3436         REGRESSION (r255677): Reloading tab with beforeunload prompt closes tab when asking to stay on page
3437         https://bugs.webkit.org/show_bug.cgi?id=208015
3438         <rdar://problem/59591630>
3439
3440         Reviewed by Geoffrey Garen.
3441
3442         Add API test coverage.
3443
3444         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
3445         (TEST):
3446
3447 2020-02-20  Tim Horton  <timothy_horton@apple.com>
3448
3449         WKWebView with non-zero origin has the wrong top content inset with NSWindowStyleMaskFullSizeContentView
3450         https://bugs.webkit.org/show_bug.cgi?id=207998
3451         <rdar://problem/40942425>
3452
3453         Reviewed by Sam Weinig.
3454
3455         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3456         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKitCocoa/FullscreenTopContentInset.mm.
3457         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
3458         (TestWebKitAPI::TEST):
3459         Add some tests for top content insets.
3460
3461 2020-02-20  Jonathan Bedard  <jbedard@apple.com>
3462
3463         results.webkit.org: Correctly report JSC tests for windows (Follow-up fix)
3464         https://bugs.webkit.org/show_bug.cgi?id=207910
3465
3466         Unreviewed infrastructure fix.
3467
3468         * Scripts/run-javascriptcore-tests:
3469         (configurationForUpload): Use the major version instead of the sub-minor version
3470         for version name.
3471
3472 2020-02-20  Don Olmstead  <don.olmstead@sony.com>
3473
3474         [CMake] Add WPE::libwpe target
3475         https://bugs.webkit.org/show_bug.cgi?id=207970
3476
3477         Reviewed by Adrian Perez de Castro.
3478
3479         Use the WPE::libwpe target.
3480
3481         * MiniBrowser/wpe/CMakeLists.txt:
3482         * TestWebKitAPI/PlatformWPE.cmake:
3483         * TestWebKitAPI/glib/PlatformWPE.cmake:
3484         * wpe/backends/CMakeLists.txt:
3485
3486 2020-02-19  Fujii Hironori  <Hironori.Fujii@sony.com>
3487
3488         [Win][MiniBrowser] Add 'Go Home' menu item and toolbar button
3489         https://bugs.webkit.org/show_bug.cgi?id=207749
3490
3491         Reviewed by Ross Kirsling.
3492
3493         Added "Set Default URL to Current URL" menu item like Mac MiniBrowser.
3494
3495         * MiniBrowser/win/MainWindow.cpp:
3496         (MainWindow::createToolbar):
3497         (MainWindow::WndProc):
3498         (MainWindow::setDefaultURLToCurrentURL):
3499         (MainWindow::goHome): Added.
3500         (MainWindow::onURLBarEnter):
3501         * MiniBrowser/win/MainWindow.h:
3502         * MiniBrowser/win/MiniBrowserLib.rc:
3503         * MiniBrowser/win/MiniBrowserLibResource.h:
3504         * MiniBrowser/win/MiniBrowserReplace.h:
3505         * MiniBrowser/win/WinMain.cpp:
3506         (wWinMain):
3507
3508 2020-02-19  Peng Liu  <peng.liu6@apple.com>
3509
3510         Fix check-webkit-style errors related to AVFoundationSPI.h
3511         https://bugs.webkit.org/show_bug.cgi?id=207834
3512
3513         Reviewed by Daniel Bates.
3514
3515         Revert the change in r256770 regarding the headers ordering.
3516         Headers in the same category should be in sorted order (case sensitive, as done by the command-line sort tool or the Xcode sort selection command).
3517
3518         * Scripts/webkitpy/style/checkers/cpp.py:
3519         (check_include_line):
3520
3521 2020-02-19  Jonathan Bedard  <jbedard@apple.com>
3522
3523         results.webkit.org: Correctly report JSC tests for windows
3524         https://bugs.webkit.org/show_bug.cgi?id=207910
3525
3526         Rubber-stamped by Aakash Jain.
3527
3528         * Scripts/run-javascriptcore-tests:
3529         (configurationForUpload): Give Windows a version name.
3530         * Scripts/webkitdirs.pm:
3531         (determineWinVersion): Correctly parse Windows 10 version numbers, conform to
3532         Version dictionary.
3533
3534 2020-02-19  Chris Dumez  <cdumez@apple.com>
3535
3536         Unreviewed, fix assertions in storage access API layout tests after r256882.
3537
3538         Drop dead testRunner code to toggle storage access API feature.
3539
3540         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3541         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3542         (WTR::TestRunner::setStorageAccessAPIEnabled): Deleted.
3543         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3544         * WebKitTestRunner/TestInvocation.cpp:
3545         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3546
3547 2020-02-18  Zan Dobersek  <zdobersek@igalia.com>
3548
3549         [WPE] Support 2D axis, smooth-motion events
3550         https://bugs.webkit.org/show_bug.cgi?id=207881
3551
3552         Reviewed by Carlos Garcia Campos.
3553
3554         * wpe/jhbuild.modules: Bump to a newer libwpe commit.
3555
3556 2020-02-18  Ryan Haddad  <ryanhaddad@apple.com>
3557
3558         Unreviewed, rolling out r256851.
3559
3560         Broke internal bots
3561
3562         Reverted changeset:
3563
3564         "Stub repositories fail to upload some results due to missing
3565         head svn revision"
3566         https://bugs.webkit.org/show_bug.cgi?id=207684
3567         https://trac.webkit.org/changeset/256851
3568
3569 2020-02-18  Fujii Hironori  <Hironori.Fujii@sony.com>
3570
3571         [Win][MiniBrowser] Support back/forward mouse buttons by handing APPCOMMAND_BROWSER_BACKWARD and APPCOMMAND_BROWSER_FORWARD
3572         https://bugs.webkit.org/show_bug.cgi?id=207883
3573
3574         Reviewed by Ross Kirsling.
3575
3576         Unlike other mouse buttons, 4th and 5th mouse buttons are
3577         processed differently. Clicking them dispatches WM_XBUTTONDOWN and
3578         WM_XBUTTONUP events to the window under the mouse cursor.
3579         Unhandled WM_XBUTTONUP events are automatically converted to
3580         WM_APPCOMMAND. And, unhandle WM_APPCOMMAND are propagated to the
3581         parent window.
3582         <https://docs.microsoft.com/en-us/windows/win32/inputdev/wm-appcommand>
3583
3584         Unlike other WM_* commands, WM_APPCOMMAND should return 1 if it is
3585         handled.
3586
3587         * MiniBrowser/win/BrowserWindow.h:
3588         * MiniBrowser/win/MainWindow.cpp:
3589         (MainWindow::WndProc):
3590         * MiniBrowser/win/WebKitBrowserWindow.cpp:
3591         (WebKitBrowserWindow::navigateForwardOrBackward):
3592         * MiniBrowser/win/WebKitBrowserWindow.h:
3593         * MiniBrowser/win/WebKitLegacyBrowserWindow.cpp:
3594         (WebKitLegacyBrowserWindow::navigateForwardOrBackward):
3595         * MiniBrowser/win/WebKitLegacyBrowserWindow.h:
3596
3597 2020-02-18  Alex Christensen  <achristensen@webkit.org>
3598
3599         Expand WKRemoteObjectCoder supported POD types to encode NSURLResponse types
3600         https://bugs.webkit.org/show_bug.cgi?id=207912
3601         <rdar://problem/59556922>
3602
3603         Reviewed by Brian Weinstein.
3604
3605         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.h:
3606         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistry.mm:
3607         (TEST):
3608         * TestWebKitAPI/Tests/WebKitCocoa/RemoteObjectRegistryPlugIn.mm:
3609         (-[RemoteObjectRegistryPlugIn sendRequest:response:challenge:error:completionHandler:]):
3610
3611 2020-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
3612
3613         [macOS] Web process may crash under ServicesOverlayController::buildPotentialHighlightsIfNeeded
3614         https://bugs.webkit.org/show_bug.cgi?id=207899
3615         <rdar://problem/55658207>
3616
3617         Reviewed by Tim Horton and Simon Fraser.
3618
3619         Make it possible to run tests on macOS with services controls enabled, via a new TestOptions flag.
3620
3621         * WebKitTestRunner/TestController.cpp:
3622         (WTR::updateTestOptionsFromTestHeader):
3623         * WebKitTestRunner/TestOptions.h:
3624         (WTR::TestOptions::hasSameInitializationOptions const):
3625         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3626         (WTR::TestController::platformCreateWebView):
3627
3628 2020-02-18  Matt Lewis  <jlewis3@apple.com>
3629
3630         Stub repositories fail to upload some results due to missing head svn revision
3631         https://bugs.webkit.org/show_bug.cgi?id=207684
3632
3633         Reviewed by Jonathan Bedard.
3634
3635         * Scripts/webkitpy/api_tests/run_api_tests.py:
3636         (main): Added initializing the scm to the host object.
3637         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
3638         (summarize_results): Changed call to head_svn_revision to port.commits_for_upload() to bring
3639         it in line with modern code.
3640         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3641         (main): Added inializing the scm to the host object.
3642         * Scripts/webkitpy/port/base.py:
3643         (Port.commits_for_upload): Removed the forced movement up the systems tree that prevented us
3644         from using mock SCMs and more
3645         * Scripts/webkitpy/test/main.py:
3646         (main):  Removed the forced movement up the systems tree, initialized the SCM on the host object,
3647         and converted the webkit_root variable to the SCM checkout root.
3648         (Tester._run_tests):
3649
3650 2020-02-18  Per Arne Vollan  <pvollan@apple.com>
3651
3652         Move [UIDevice currentDevice] calls to UI process
3653         https://bugs.webkit.org/show_bug.cgi?id=204320
3654
3655         Reviewed by Darin Adler.
3656
3657         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3658         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm: Added.
3659         (TEST):
3660
3661 2020-02-18  Simon Fraser  <simon.fraser@apple.com>
3662
3663         Move from "layer flush" terminology to "rendering update"
3664         https://bugs.webkit.org/show_bug.cgi?id=207870
3665
3666         Reviewed by Tim Horton.
3667
3668         Rename various functions and member variables to move away from the legacy "layer flush"
3669         terminology and instead use "rendering update", matching Page::updateRendering(). The fact
3670         that we have layers is an implementation detail.
3671         
3672         Change LayerFlushThrottlingState to be an OptionSet<>.
3673
3674         * Tracing/SystemTracePoints.plist:
3675
3676 2020-02-17  Zhifei Fang  <zhifei_fang@apple.com>
3677
3678         [Webkit.css] Adding popover style element
3679         This help to prevent us reinventing the wheel ever again
3680         https://bugs.webkit.org/show_bug.cgi?id=207787
3681
3682         Reviewed by Dean Jackson.
3683
3684         * resultsdbpy/resultsdbpy/view/static/library/css/docs.yaml:
3685         * resultsdbpy/resultsdbpy/view/static/library/css/index.html:
3686         * resultsdbpy/resultsdbpy/view/static/library/css/webkit.css:
3687         (.popover):
3688         (.popover>.content):
3689         (.popover.display):
3690         (.popover .arrow):
3691         (.popover .arrow.point-top):
3692         (.popover .arrow.point-bottom):
3693         (.popover .arrow.point-left):
3694         (.popover .arrow.point-right):
3695         (@media (prefers-color-scheme: dark) .popover>.content):
3696         (@media (prefers-color-scheme: dark) .popover.display):
3697         (@media (prefers-color-scheme: dark) .popover .arrow):
3698         (.popover>.content>.section): Deleted.
3699         (.popover:focus>.content, .popover:hover>.content): Deleted.
3700         (.popover.right>.content): Deleted.
3701         (.popover.right :focus>.content, .popover.right:hover>.content): Deleted.
3702         (.popover.left>.content): Deleted.
3703         (.popover.left :focus>.content, .popover.left:hover>.content): Deleted.
3704         (.popover.bottom>.content): Deleted.
3705         (.popover.bottom :focus>.content, .popover.bottom:hover>.content): Deleted.
3706
3707 2020-02-17  Brent Fulgham  <bfulgham@apple.com>
3708
3709         Update WebKit Tools to issue mach extensions as needed
3710         https://bugs.webkit.org/show_bug.cgi?id=207850
3711         <rdar://problem/59521019>
3712
3713         Reviewed by Per Arne Vollan.
3714
3715         Revise the codesign settings for our testing tools to allow the process to vend mach extensions
3716         to its child processes (WebContent, GPU, Network, etc.) as needed.
3717
3718         * MiniBrowser/MiniBrowser.entitlements:
3719         * TestWebKitAPI/Configurations/TestWebKitAPI-macOS.entitlements: Added.
3720         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3721         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3722         * WebKitTestRunner/Configurations/WebKitTestRunner.entitlements:
3723
3724 2020-02-17  Peng Liu  <peng.liu6@apple.com>
3725
3726         Fix check-webkit-style errors related to AVFoundationSPI.h
3727         https://bugs.webkit.org/show_bug.cgi?id=207834
3728
3729         Reviewed by Eric Carlson.
3730
3731         We need to use case-insensitive comparison to check whether the headers are alphabetically sorted in each header section.
3732         Soft-link headers can be included as either "file.h" or <file.h>.
3733
3734         * Scripts/webkitpy/style/checkers/cpp.py:
3735         (_classify_include):
3736         (check_include_line):
3737
3738 2020-02-17  Keith Rollin  <krollin@apple.com>
3739
3740         Unreviewed build fix after r256715.
3741
3742         Fix tvOS and watchOS builds.
3743
3744         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3745
3746 2020-02-17  Per Arne Vollan  <pvollan@apple.com>
3747
3748         Use CF prefs direct mode in the WebContent process
3749         https://bugs.webkit.org/show_bug.cgi?id=203420
3750
3751         Reviewed by Brent Fulgham.
3752
3753         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3754         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm: Added.
3755         (TEST):
3756
3757 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3758
3759         EWS should be able to file Bugzilla bugs
3760         https://bugs.webkit.org/show_bug.cgi?id=207845
3761
3762         Reviewed by Alexey Proskuryakov.
3763
3764         * BuildSlaveSupport/ews-build/steps.py:
3765         (BugzillaMixin.create_bug): Method to file bugzilla bug using bugzilla REST API.
3766
3767 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3768
3769         EWS should be able to comment on Bugzilla
3770         https://bugs.webkit.org/show_bug.cgi?id=201927
3771
3772         Reviewed by Jonathan Bedard.
3773
3774         * BuildSlaveSupport/ews-build/steps.py:
3775         (BugzillaMixin.comment_on_bug): Method to comment on bugzilla bug.
3776         (BugzillaMixin.remove_flags_on_patch): Drive-by fix to correctly identify failure based on status code.
3777         (BugzillaMixin.close_bug): Ditto.
3778         (CommentOnBug): Build step to comment on bugzilla bug.
3779
3780 2020-02-17  Antti Koivisto  <antti@apple.com>
3781
3782         [macOS] Add trace points for layer flush runloop observer
3783         https://bugs.webkit.org/show_bug.cgi?id=207837
3784
3785         Reviewed by Sam Weinig.
3786
3787         * Tracing/SystemTracePoints.plist:
3788
3789 2020-02-17  Don Olmstead  <don.olmstead@sony.com>
3790
3791         [CMake] Use builtin targets
3792         https://bugs.webkit.org/show_bug.cgi?id=205166
3793
3794         Reviewed by Darin Adler.
3795
3796         * TestWebKitAPI/PlatformWin.cmake:
3797
3798 2020-02-17  Aakash Jain  <aakash_jain@apple.com>
3799
3800         [ews] add SetBuildSummary step for Windows EWS
3801         https://bugs.webkit.org/show_bug.cgi?id=207556
3802
3803         Reviewed by Jonathan Bedard.
3804
3805         * BuildSlaveSupport/ews-build/factories.py:
3806         (WindowsFactory.__init__):
3807         (GTKBuildAndTestFactory.__init__):
3808         * BuildSlaveSupport/ews-build/factories_unittest.py:
3809         (TestBuildAndTestsFactory.test_windows_factory): Added unit-test.
3810
3811 2020-02-17  Alberto Garcia  <berto@igalia.com>
3812
3813         [WPE] Change the QML plugin install path
3814         https://bugs.webkit.org/show_bug.cgi?id=207761
3815
3816         Reviewed by Philippe Normand.
3817
3818         * Scripts/run-qt-wpe-minibrowser:
3819         * glib/api_test_runner.py:
3820         (TestRunner._run_test_qt):
3821
3822 2020-02-16  Fujii Hironori  <Hironori.Fujii@sony.com>
3823
3824         Remove remaining WTF_EXPORT and WTF_IMPORT by replacing them with WTF_EXPORT_DECLARATION and WTF_IMPORT_DECLARATION
3825         https://bugs.webkit.org/show_bug.cgi?id=207746
3826
3827         Reviewed by Don Olmstead.
3828
3829         * MiniBrowser/win/stdafx.h:
3830
3831 2020-02-16  Brady Eidson  <beidson@apple.com>
3832
3833         Expose "allowsContentJavaScript" on WKWebpagePreferences
3834         <rdar://problem/51534967> and https://bugs.webkit.org/show_bug.cgi?id=207427
3835
3836         Reviewed by Darin Adler.
3837
3838         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
3839         (TEST):
3840         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3841         (-[WebsitePoliciesNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3842         (TEST):
3843         (-[WebsitePoliciesNavigationDelegate _webView:decidePolicyForNavigationAction:preferences:userInfo:decisionHandler:]): Deleted.
3844         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
3845         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
3846         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:preferences:decisionHandler:]):
3847         (-[TestNavigationDelegate waitForDidFinishNavigationWithPreferences:]):
3848         (-[WKWebView _test_waitForDidFinishNavigationWithPreferences:]):
3849         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]): Deleted.
3850         * TestWebKitAPI/cocoa/TestWKWebView.h:
3851         * TestWebKitAPI/cocoa/TestWKWebView.mm:
3852         (-[WKWebView synchronouslyLoadHTMLString:preferences:]):
3853
3854 2020-02-14  Yusuke Suzuki  <ysuzuki@apple.com>
3855
3856         NetworkLoadMetrics should be shared by multiple ResourceResponse instances
3857         https://bugs.webkit.org/show_bug.cgi?id=207747
3858
3859         Reviewed by Keith Miller.
3860
3861         * TestWebKitAPI/Tests/WebCore/ParsedContentRange.cpp:
3862         (TestWebKitAPI::TEST):
3863
3864 2020-02-14  Alex Christensen  <achristensen@webkit.org>
3865
3866         Allow UIDNAInfo.errors from uidna_nameToUnicode that would not cause URL parsing failures
3867         https://bugs.webkit.org/show_bug.cgi?id=207360
3868         <rdar://problem/57825317>
3869
3870         Reviewed by Ryosuke Niwa.
3871
3872         * TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
3873         (TestWebKitAPI::TEST):
3874
3875 2020-02-14  Don Olmstead  <don.olmstead@sony.com>
3876
3877         [CMake] Add Fontconfig::Fontconfig target
3878         https://bugs.webkit.org/show_bug.cgi?id=207730
3879
3880         Reviewed by Adrian Perez de Castro.
3881
3882         Use the Fontconfig::Fontconfig target.
3883
3884         * WebKitTestRunner/PlatformGTK.cmake:
3885
3886 2020-02-13  Kate Cheney  <katherine_cheney@apple.com>
3887
3888          Expose prevalent domains on a per-page basis
3889          https://bugs.webkit.org/show_bug.cgi?id=207523
3890          <rdar://problem/59270758>
3891
3892         Reviewed by Chris Dumez.
3893
3894         Added WebKitTestRunner functions so this functionality can be tested.
3895         clearPrevalentDomains should be called between tests to reset the
3896         state.
3897
3898         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3899         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3900         (WTR::InjectedBundle::didReceiveMessageToPage):
3901         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3902         (WTR::TestRunner::getPrevalentDomains):
3903         (WTR::TestRunner::callDidReceivePrevalentDomainsCallback):
3904         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3905         * WebKitTestRunner/TestController.cpp:
3906         (WTR::TestController::resetStateToConsistentValues):
3907         (WTR::TestController::getPrevalentDomains):
3908         (WTR::TestController::clearPrevalentDomains):
3909         * WebKitTestRunner/TestController.h:
3910         * WebKitTestRunner/TestInvocation.cpp:
3911         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3912         (WTR::TestInvocation::didReceivePrevalentDomains):
3913         * WebKitTestRunner/TestInvocation.h:
3914         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3915         (WTR::TestController::getPrevalentDomains):
3916         (WTR::TestController::clearPrevalentDomains):
3917
3918 2020-02-13  Fujii Hironori  <Hironori.Fujii@sony.com>
3919
3920         [Win][MiniBrowser] Reimplement the toolbar by using toolbar common control
3921         https://bugs.webkit.org/show_bug.cgi?id=207682
3922
3923         Reviewed by Ross Kirsling.
3924
3925         The toolbar placed button common controls as the toolbar buttons.
3926         However, because these buttons are focusable, shortcut keys don't
3927         work after clicking them.
3928
3929         Added Home button, Add to Bookmarks button, dropdown buttons of
3930         back and forward buttons, but they aren't implemented yet. Just
3931         placeholders at the moment.
3932
3933         * MiniBrowser/win/MainWindow.cpp:
3934         (MainWindow::createToolbar): Added.
3935         (MainWindow::resizeToolbar): Added.
3936         (MainWindow::rescaleToolbar): Added.
3937         (MainWindow::init):
3938         (MainWindow::resizeSubViews):
3939         (MainWindow::updateDeviceScaleFactor):
3940         * MiniBrowser/win/MainWindow.h: Added m_toolbarItemsWidth.
3941
3942 2020-02-13  Ryosuke Niwa  <rniwa@webkit.org>
3943
3944         Dark Mode: In Notes, list item becomes invisible in dark mode after outdenting
3945         https://bugs.webkit.org/show_bug.cgi?id=207676
3946
3947         Reviewed by Wenson Hsieh and Timothy Hatcher.
3948
3949         Added regression tests for pasting content with -apple-system-label and outdenting content.
3950
3951         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
3952         (PasteHTML.TransformColorsOfDarkContentButNotSemanticColor):
3953         (PasteHTML.DoesNotTransformColorsOfLightContentDuringOutdent):
3954
3955 2020-02-13  Alex Christensen  <achristensen@webkit.org>
3956
3957         _WKResourceLoadInfo should conform to NSSecureCoding
3958         https://bugs.webkit.org/show_bug.cgi?id=207667
3959
3960         Reviewed by Brady Eidson.
3961
3962         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadDelegate.mm:
3963         (TEST):
3964
3965 2020-02-13  Stephan Szabo  <stephan.szabo@sony.com>
3966
3967         [PlayStation] Add Buildbots for Debug/Release builds
3968         https://bugs.webkit.org/show_bug.cgi?id=199454
3969
3970         Reviewed by Aakash Jain.
3971
3972         * BuildSlaveSupport/build.webkit.org-config/config.json:
3973         Add PlayStation slaves, builders
3974         * BuildSlaveSupport/build.webkit.org-config/factories.py:
3975         Use higher timeout for playstation as with win bot
3976         * BuildSlaveSupport/build.webkit.org-config/loadConfig.py:
3977         Set PlayStation category for playstation platform
3978         * BuildSlaveSupport/build.webkit.org-config/steps.py:
3979         Use same path as gtk, wincairo, etc for appendCustomBuildFlags
3980         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
3981         Add PlayStation expectations
3982
3983 2020-02-13  Per Arne Vollan  <pvollan@apple.com>
3984
3985         [iOS] Check if PIP is supported in the UI process
3986         https://bugs.webkit.org/show_bug.cgi?id=207406
3987
3988         Reviewed by Brent Fulgham.
3989
3990         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3991         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm: Added.
3992         (TEST):
3993
3994 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
3995
3996         TestWebKitAPI: Conditionalize fullscreen tests on fullscreen API
3997         https://bugs.webkit.org/show_bug.cgi?id=207397
3998         <rdar://problem/59268128>
3999
4000         Reviewed by Jer Noble.
4001
4002         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
4003         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewCloseAllMediaPresentations.mm:
4004
4005 2020-02-13  Jonathan Bedard  <jbedard@apple.com>
4006
4007         TestWebKitAPI: Re-baseline DocumentEditingContext for Catalyst
4008         https://bugs.webkit.org/show_bug.cgi?id=207696
4009
4010         Reviewed by Tim Horton.
4011
4012         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
4013
4014 2020-02-13  Wenson Hsieh  <wenson_hsieh@apple.com>
4015
4016         [iOS] -updateSelectionWithExtentPoint:completionHandler: should work without requiring floating cursor
4017         https://bugs.webkit.org/show_bug.cgi?id=207680
4018         <rdar://problem/59340940>
4019
4020         Reviewed by Tim Horton.
4021
4022         Add a new API test to verify that calling -updateSelectionWithExtentPoint:completionHandler: with a point behind
4023         the current selection works.
4024
4025         * TestWebKitAPI/Tests/ios/UIWKInteractionViewProtocol.mm:
4026         (-[TestWKWebView updateSelectionWithExtentPoint:]):
4027         * TestWebKitAPI/ios/UIKitSPI.h:
4028
4029 2020-02-13  Said Abou-Hallawa  <said@apple.com>
4030
4031         Unreviewed, rolling out r255158, 255405 and r255486
4032
4033         Caused test flakiness and PLT regression.
4034
4035         * DumpRenderTree/mac/DumpRenderTree.mm:
4036         (resetWebPreferencesToConsistentValues):
4037         * DumpRenderTree/win/DumpRenderTree.cpp:
4038         (enableExperimentalFeatures):
4039         * WebKitTestRunner/TestController.cpp:
4040         (WTR::TestController::resetPreferencesToConsistentValues):
4041
4042 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
4043
4044         run-javascriptcore-tests: Allow insecure requests on upload
4045         https://bugs.webkit.org/show_bug.cgi?id=207662
4046
4047         Rubber-stamped by Aakash Jain.
4048
4049         * Scripts/run-javascriptcore-tests:
4050         (uploadResults): Allow insecure curl request when posting results.
4051
4052 2020-02-12  Truitt Savell  <tsavell@apple.com>
4053
4054         Unreviewed, rolling out r256463.
4055
4056         Caused major flakiness on Mac wk2
4057
4058         Reverted changeset:
4059
4060         "REGRESSION (r255158): http/tests/frame-throttling/raf-
4061         throttle-in-cross-origin-subframe.html is a flaky failure"
4062         https://bugs.webkit.org/show_bug.cgi?id=206839
4063         https://trac.webkit.org/changeset/256463
4064
4065 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
4066
4067         results.webkit.org: Remove debug JS logging
4068         https://bugs.webkit.org/show_bug.cgi?id=207663
4069
4070         Reviewed by Aakash Jain.
4071
4072         * resultsdbpy/resultsdbpy/view/static/js/investigate.js:
4073         (elapsed):
4074         * resultsdbpy/resultsdbpy/view/static/js/tooltip.js:
4075         (_ToolTip.prototype.toString):
4076         * resultsdbpy/resultsdbpy/view/static/library/js/Ref.js:
4077         (prototype.addWithDelay):
4078         * resultsdbpy/resultsdbpy/view/templates/archive_list.html:
4079
4080 2020-02-12  Simon Fraser  <simon.fraser@apple.com>
4081
4082         Remove CSS_DEVICE_ADAPTATION
4083         https://bugs.webkit.org/show_bug.cgi?id=203479
4084
4085         Reviewed by Tim Horton.
4086         
4087         CSS Working Group resolved to remove @viewport <https://github.com/w3c/csswg-drafts/issues/4766>,
4088         so remove the code.
4089
4090         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
4091
4092 2020-02-12  Said Abou-Hallawa  <said@apple.com>
4093
4094         REGRESSION (r255158): http/tests/frame-throttling/raf-throttle-in-cross-origin-subframe.html is a flaky failure
4095         https://bugs.webkit.org/show_bug.cgi?id=206839
4096
4097         Reviewed by Simon Fraser.
4098
4099         Remove the WKPreference key 'RenderingUpdateThrottlingEnabled'.
4100
4101         * DumpRenderTree/mac/DumpRenderTree.mm:
4102         (resetWebPreferencesToConsistentValues):
4103         * DumpRenderTree/win/DumpRenderTree.cpp:
4104         (enableExperimentalFeatures):
4105         * WebKitTestRunner/TestController.cpp:
4106         (WTR::TestController::resetPreferencesToConsistentValues):
4107
4108 2020-02-12  Jonathan Bedard  <jbedard@apple.com>
4109
4110         results.webkit.org: Cache archive content
4111         https://bugs.webkit.org/show_bug.cgi?id=207589
4112
4113         Reviewed by Aakash Jain.
4114
4115         * resultsdbpy/resultsdbpy/flask_support/util.py:
4116         (cache_for): Add decorator function which sets the cache values on the returned response.
4117         * resultsdbpy/resultsdbpy/view/archive_view.py:
4118         (ArchiveView): Cache archive content client-side for 12 hours.
4119         * resultsdbpy/resultsdbpy/view/archive_view_unittest.py:
4120         (ArchiveViewUnittest.test_file): Verify that archived content is cached.
4121
4122 2020-02-12  Youenn Fablet  <youenn@apple.com>
4123
4124         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
4125         https://bugs.webkit.org/show_bug.cgi?id=207537
4126
4127         Reviewed by Chris Dumez.
4128
4129         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4130
4131 2020-02-11  Rob Buis  <rbuis@igalia.com>
4132
4133         Bug 207424: Crash in WebCore::ParsedContentType::parseContentType when parsing invalid MIME type
4134         <https://webkit.org/b/207424>
4135         <rdar://problem/59250384>
4136
4137         Reviewed by Rob Buis.
4138
4139         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
4140         (TestWebKitAPI::TEST): Add more tests.
4141
4142 2020-02-11  Commit Queue  <commit-queue@webkit.org>
4143
4144         Unreviewed, rolling out r256314.
4145         https://bugs.webkit.org/show_bug.cgi?id=207594
4146
4147         It is breaking an API test (Requested by youenn on #webkit).
4148
4149         Reverted changeset:
4150
4151         "WebSWServerConnection::registerServiceWorkerClient is not
4152         sending IPC message to UIProcess when it should"
4153         https://bugs.webkit.org/show_bug.cgi?id=207537
4154         https://trac.webkit.org/changeset/256314
4155
4156 2020-02-11  Jonathan Bedard  <jbedard@apple.com>
4157
4158         results.webkit.org: Configuration documentation should include architecture
4159         https://bugs.webkit.org/show_bug.cgi?id=207584
4160
4161         Reviewed by Aakash Jain.
4162
4163         * resultsdbpy/resultsdbpy/view/templates/documentation.html: Add architecture documentation.
4164
4165 2020-02-11  Youenn Fablet  <youenn@apple.com>
4166
4167         Regression: RTCRtpSender.getCapabilities("video") returns null on iOS 13.4 (17E5223h)
4168         https://bugs.webkit.org/show_bug.cgi?id=207325
4169         <rdar://problem/59224810>
4170
4171         Reviewed by Eric Carlson.
4172
4173         * TestWebKitAPI/Tests/WebKit/GetUserMedia.mm:
4174         (TestWebKitAPI::TEST):
4175         Add a test validating that RTCRtpSender.getCapabilities does not return null.
4176         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
4177
4178 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4179
4180         KeyboardInputTests.SupportsImagePaste fails on recent versions of UIKit
4181         https://bugs.webkit.org/show_bug.cgi?id=207557
4182
4183         Reviewed by Jonathan Bedard.
4184
4185         The exception occurs because UIKit attempts to create a QoS interval upon setting the initially selected row in
4186         a UITableView when we focus a date picker. This fails because TestWebKitAPI isn't actually an app, so the call
4187         to `work_interval_create` with `WORK_INTERVAL_TYPE_CA_CLIENT` as the option flag fails. For the time being, work
4188         around this by focusing an empty select element instead (for which we won't attempt to create and select any
4189         table view cells).
4190
4191         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
4192
4193 2020-02-11  Alex Christensen  <achristensen@webkit.org>
4194
4195         Add WKHTTPCookieStore._getCookiesForURL SPI
4196         https://bugs.webkit.org/show_bug.cgi?id=207527
4197
4198         Reviewed by Brady Eidson.
4199
4200         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
4201         (TEST):
4202
4203 2020-02-11  Youenn Fablet  <youenn@apple.com>
4204
4205         WebSWServerConnection::registerServiceWorkerClient is not sending IPC message to UIProcess when it should
4206         https://bugs.webkit.org/show_bug.cgi?id=207537
4207
4208         Reviewed by Chris Dumez.
4209
4210         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
4211
4212 2020-02-11  Lauro Moura  <lmoura@igalia.com>
4213
4214         [WPE][WebDriver] MiniBrowser should react to close session commands
4215         https://bugs.webkit.org/show_bug.cgi?id=207529
4216
4217         Reviewed by Carlos Garcia Campos.
4218
4219         WebDriver delete session command asks to close the WebView associated to the
4220         current automation session. We must react to it to avoid lots of
4221         timeouts and errors.
4222
4223         * MiniBrowser/wpe/main.cpp:
4224         (main): Listen to "close" signal on the main WebView.
4225
4226 2020-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
4227
4228         [iOS] Non-internal API test runners frequently crash due to Objective-C exceptions
4229         https://bugs.webkit.org/show_bug.cgi?id=207525
4230         <rdar://problem/59110543>
4231
4232         Reviewed by Tim Horton.
4233
4234         After the fix for <rdar://problem/56301207>, some scroll view content offset changes will attempt to call into
4235         CoreAnalytics API to try and report data about scrolling velocities. In the iOS 13.3 simulator, this involves
4236         creating a dictionary, of which one of the keys is the bundle identifier of the application. The value is
4237         unconditionally inserted into the dictionary. Since TestWebKitAPI does not run in the context of a
4238         UIApplication, the bundle identifier (that is, `NSBundle.mainBundle.bundleIdentifier`) ends up being nil,
4239         causing us to crash upon trying to create the dictionary.
4240
4241         While it would make things easier, we can't just swizzle -bundleIdentifier for the entirely of every test, since
4242         some tests expect the bundle identifier to be nil (or call into system frameworks that expect the bundle
4243         identifier to be nil). These tests fail or time out when -bundleIdentifier is unconditionally swizzled
4244         throughout the test run. To work around this bug for the time being, simply pretend that we have a bundle
4245         identifier when running API tests on iOS, by swizzling `-[NSBundle bundleIdentifier]` to return a string at the
4246         beginning of each API test.
4247
4248         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4249         * TestWebKitAPI/cocoa/TestWKWebView.mm:
4250         (overrideBundleIdentifier):
4251
4252         Move this to the top of the file, so it can be shared.
4253
4254         (+[WKWebView initialize]):
4255
4256         At the start of each test, force UIKit to cache a fake value for `_UIMainBundleIdentifier()` by invoking an
4257         internal class method that calls into the internal helper function, with no other side effects.
4258
4259         * TestWebKitAPI/ios/UIKitSPI.h:
4260
4261 2020-02-10  Jonathan Bedard  <jbedard@apple.com>
4262
4263         TestWebKitAPI: Support ClipboardTests.ReadMultipleItems on Catalyst
4264         https://bugs.webkit.org/show_bug.cgi?id=207501
4265         <rdar://problem/59323414>
4266
4267         Reviewed by Alex Christensen.
4268
4269         * TestWebKitAPI/Tests/WebKitCocoa/ClipboardTests.mm:
4270         (writeMultipleObjectsToPlatformPasteboard): All iOS family ports should have
4271         The same behavior.
4272
4273 2020-02-10  Alan Sien Wei Hshieh  <hshieh@apple.com>
4274
4275         Add a variant of -[WKWebViewPrivate _getContentsAsStringWithCompletionHandler:] that includes contents from subframes
4276         https://bugs.webkit.org/show_bug.cgi?id=207352
4277         <rdar://problem/59115798>
4278
4279         Reviewed by Alex Christensen.
4280
4281         Add a test to exercise the new SPI.
4282
4283         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm: Add a test for getting text from all frames with
4284         a webpage that contains text in subframes.
4285
4286
4287 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
4288
4289         [iOS] Crash when granting access to asset services
4290         https://bugs.webkit.org/show_bug.cgi?id=207520
4291
4292         Reviewed by Brent Fulgham.
4293
4294         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4295         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm: Added.
4296         (TEST):
4297
4298 2020-02-10  Chris Dumez  <cdumez@apple.com>
4299
4300         [DRT] InternalSettingsGenerated::resetToConsistentState() may override TestOptions
4301         https://bugs.webkit.org/show_bug.cgi?id=207481
4302
4303         Reviewed by Alexey Proskuryakov.
4304
4305         InternalSettingsGenerated::resetToConsistentState() may override TestOptions such as enableBackForwardCache.
4306         This is causing issues such as the back/forward cache sometimes getting enabled on tests where
4307         TestOptions::enableBackForwardCache() is false, because a previous test has enabled the back/forward cache.
4308
4309         * DumpRenderTree/mac/DumpRenderTree.mm:
4310         (resetWebViewToConsistentStateBeforeTesting):
4311         Make sure we reset preferences after we call WebCoreTestSupport::resetInternalsObject(), since
4312         resetInternalsObject() updates settings and TestOptions / DRT preferences should have priority
4313         over internal settings.
4314
4315 2020-02-10  Per Arne Vollan  <pvollan@apple.com>
4316
4317         [watchOS] Notification listener is never unregistered
4318         https://bugs.webkit.org/show_bug.cgi?id=207459
4319