70379cd37b267a48c30ee16607f50782a3cbb25f
[WebKit-https.git] / Tools / ChangeLog
1 2014-03-28  Martin Hock  <mhock@apple.com>
2
3         Unreviewed. Add myself as a committer.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2014-03-28  Martin Robinson  <mrobinson@igalia.com>
8
9         Remove WebKit1 GTK+ bots
10         https://bugs.webkit.org/show_bug.cgi?id=130904
11
12         Reviewed by Anders Carlsson.
13
14         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove references to GTK+ WebKit1 test bot and ensure
15         all bots are testing WebKit2 only.
16         * Scripts/webkitpy/common/config/ews.json: Remove references to GTK+ WK1 EWS.
17         * Scripts/webkitpy/common/config/ports.py: Remove references to GTK+ WK1 bots.
18         * Scripts/webkitpy/common/config/ports_unittest.py: Ditto.
19         * Scripts/webkitpy/port/builders.py: Ditto.
20         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
21         * TestResultServer/static-dashboards/builders.jsonp: Ditto.
22
23 2014-03-28  Timothy Hatcher  <timothy@apple.com>
24
25         Remove Brian Burg's apple.com email address.
26
27         * Scripts/webkitpy/common/config/contributors.json:
28
29 2014-03-28  David Kilzer  <ddkilzer@apple.com>
30
31         bisect-builds should print Trac 'changeset' URL if only one build is detected
32         <http://webkit.org/b/130903>
33
34         Reviewed by Dan Bernstein.
35
36         * Scripts/bisect-builds:
37         (printTracLink): Print a direct link to the Trac 'changeset'
38         URL if there is only one revision in the range.
39
40 2014-03-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
41
42         [EFL] Bump glib version from 2.36 to 2.38 
43         https://bugs.webkit.org/show_bug.cgi?id=130886
44
45         Reviewed by Csaba Osztrogonác.
46
47         There is a build break on EFL port when using glib 2.36 ver. To fix it,
48         we need to bump glib version up to 2.38 as gtk port.
49
50         * efl/jhbuild.modules:
51
52 2014-03-27  Mikhail Pozdnyakov  <mikhail.pozdnyakov@intel.com>
53
54         <https://webkit.org/b/42704> WebKitTestRunner needs to print history delegate information
55
56         Provide an implementation of WKContextHistoryClient that logs when called for tests in
57         the globalhistory directory.
58
59         Reviewed by Sam Weinig.
60
61         * WebKitTestRunner/TestController.cpp:
62         (WTR::TestController::TestController):
63         (WTR::TestController::initialize): Set the history client.
64         (WTR::TestController::resetStateToConsistentValues): Disable logging of history client callbacks.
65         (WTR::TestController::didNavigateWithNavigationData): Log information about the navigation. Some portions
66         of the output are hard-coded to match WebKit1's results for now since they're fixed in our existing tests
67         and we don't yet have API to access the data in question.
68         (WTR::TestController::didPerformClientRedirect):
69         (WTR::TestController::didPerformServerRedirect):
70         (WTR::TestController::didUpdateHistoryTitle):
71         * WebKitTestRunner/TestController.h:
72         (WTR::TestController::setShouldLogHistoryClientCallbacks):
73         * WebKitTestRunner/TestInvocation.cpp:
74         (WTR::shouldLogHistoryClientCallbacks): Log history client callbacks for tests in a globalhistory directory.
75         (WTR::TestInvocation::invoke):
76
77 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
78
79         Revert http://trac.webkit.org/changeset/166386 because it broke builds.
80
81         * Scripts/build-webkit:
82         * Scripts/copy-webkitlibraries-to-product-directory:
83
84 2014-03-27  Filip Pizlo  <fpizlo@apple.com>
85
86         Switch the LLVMForJSC target to using the LLVM in /usr/local rather than /usr/local/LLVMForJavaScriptCore on iOS
87         https://bugs.webkit.org/show_bug.cgi?id=130867
88         <rdar://problem/16432456> 
89
90         Reviewed by Mark Hahnenberg.
91
92         * Scripts/build-webkit:
93         * Scripts/copy-webkitlibraries-to-product-directory:
94
95 2014-03-26  Andy Estes  <aestes@apple.com>
96
97         [Cocoa] Expose DownloadClient::didFail() and DownloadClient::didCancel()
98         https://bugs.webkit.org/show_bug.cgi?id=130805
99
100         Reviewed by Dan Bernstein.
101
102         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
103         (-[DownloadDelegate _download:didReceiveResponse:]):
104         (-[DownloadDelegate _downloadDidFinish:]):
105         (runTest):
106         (TEST):
107         (-[FailingDownloadDelegate _downloadDidFinish:]):
108         (-[FailingDownloadDelegate _download:didFailWithError:]):
109         (-[FailingDownloadDelegate _downloadDidCancel:]):
110         (-[CancelledDownloadDelegate _downloadDidStart:]):
111         (-[CancelledDownloadDelegate _downloadDidFinish:]):
112         (-[CancelledDownloadDelegate _download:didFailWithError:]):
113         (-[CancelledDownloadDelegate _downloadDidCancel:]):
114         (-[DownloadDelegate initWithSourceURL:]): Deleted.
115         (-[DownloadDelegate sourceURL]): Deleted.
116         (runTestWithNavigationDelegate): Deleted.
117
118 2014-03-26  Anders Carlsson  <andersca@apple.com>
119
120         Change MiniBrowser to hold on to window controllers instead of windows
121         https://bugs.webkit.org/show_bug.cgi?id=130797
122
123         Reviewed by Oliver Hunt.
124
125         * MiniBrowser/mac/AppDelegate.h:
126         * MiniBrowser/mac/AppDelegate.m:
127         (-[BrowserAppDelegate init]):
128         (-[BrowserAppDelegate newWindow:]):
129         (-[BrowserAppDelegate browserWindowWillClose:]):
130         (-[BrowserAppDelegate applicationWillTerminate:]):
131         (-[BrowserAppDelegate frontmostBrowserWindowController]):
132
133 2014-03-26  Commit Queue  <commit-queue@webkit.org>
134
135         Unreviewed, rolling out r166264.
136         https://bugs.webkit.org/show_bug.cgi?id=130785
137
138         Broke some window.opener tests for WK2 Mavericks (Requested by
139         brrian__ on #webkit).
140
141         Reverted changeset:
142
143         "Web Replay: resource unique identifiers should be unique-per-
144         frame, not globally"
145         https://bugs.webkit.org/show_bug.cgi?id=130632
146         http://trac.webkit.org/changeset/166264
147
148 2014-03-26  Zoltan Horvath  <zoltan@webkit.org>
149
150         [CSS Shapes] Remove shape-inside support
151         https://bugs.webkit.org/show_bug.cgi?id=130698
152
153         Reviewed by David Hyatt.
154
155         * Scripts/webkitperl/FeatureList.pm:
156
157 2014-02-27  Gurpreet Kaur  <k.gurpreet@samsung.com>
158
159         Unreviewed. Add myself as a committer.
160
161         * Scripts/webkitpy/common/config/contributors.json:
162
163 2014-03-26  Tomas Popela  <tpopela@redhat.com>
164
165         run-launcher is Perl script so use elsif and not elif
166         https://bugs.webkit.org/show_bug.cgi?id=130771
167
168         Reviewed by Carlos Garcia Campos.
169
170         * Scripts/run-launcher:
171
172 2014-03-26  Krzysztof Czech  <k.czech@samsung.com>
173
174         [ATK] Utilize new AtkValue interface coming in ATK 2.11.92
175         https://bugs.webkit.org/show_bug.cgi?id=130575
176
177         Reviewed by Mario Sanchez Prada.
178
179         Change ATK version to 2.11.92. Adjust current implementation.
180
181         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
182         (AccessibilityUIElement::intValue):
183         (AccessibilityUIElement::minValue):
184         (AccessibilityUIElement::maxValue):
185         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
186         (WTR::AccessibilityUIElement::intValue):
187         (WTR::AccessibilityUIElement::minValue):
188         (WTR::AccessibilityUIElement::maxValue):
189         * efl/jhbuild.modules:
190         * gtk/jhbuild.modules:
191
192 2014-03-12  Philippe Normand  <pnormand@igalia.com>
193
194         [GTK] The gnumake package is no longer needed in jhbuild
195         https://bugs.webkit.org/show_bug.cgi?id=130121
196
197         Reviewed by Martin Robinson.
198
199         For GTK build-webkit now relies on cmake and ninja/gnumake. Even
200         for a debug build cmake/system-gnumake worked just fine for me.
201
202         * gtk/jhbuild.modules: Removed gnumake.
203         * gtk/patches/make-3.82-arg-list-length.patch: Removed.
204         * gtk/patches/make-3.82-parallel-build.patch: Removed.
205
206 2014-03-25  Andy Estes  <aestes@apple.com>
207
208         Fix a failing API test on Mountain Lion and remove temporary debug logging.
209
210         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
211         (-[DownloadDelegate _download:didReceiveData:]):
212         (-[DownloadDelegate _downloadDidFinish:]):
213
214 2014-03-25  Brian Burg  <bburg@apple.com>
215
216         Web Replay: resource unique identifiers should be unique-per-frame, not globally
217         https://bugs.webkit.org/show_bug.cgi?id=130623
218
219         Reviewed by Timothy Hatcher.
220
221         The resource loader callback dumping routines assumed that resource identifiers
222         were globally unique. Its map of resource identifiers to URLs must also track the
223         frame associated with the resource.
224
225         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
226         (WTR::dumpResourceURL): Additionally take a WKBundleFrameRef argument, and use the
227         opaque pointer as part of the key for assignedUrlsCache. The frame pointer is
228         stable as long as the frame is valid.
229         (WTR::InjectedBundlePage::didInitiateLoadForResource):
230         (WTR::InjectedBundlePage::willSendRequestForFrame):
231         (WTR::InjectedBundlePage::didReceiveResponseForResource):
232         (WTR::InjectedBundlePage::didFinishLoadForResource):
233         (WTR::InjectedBundlePage::didFailLoadForResource):
234
235 2014-03-25  Andy Estes  <aestes@apple.com>
236
237         Fix one API test expectation failure on Mountain Lion, and add additional logging to help diagnose another.
238
239         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
240         (-[DownloadDelegate _download:didReceiveResponse:]):
241         (-[DownloadDelegate _download:didReceiveData:]):
242
243 2014-03-25  Andy Estes  <aestes@apple.com>
244
245         Add some debug logging to an API test that's failing on Mountain Lion.
246
247         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
248         (-[DownloadDelegate _download:didReceiveResponse:]):
249         (-[DownloadDelegate _downloadDidFinish:]):
250
251 2014-03-25  Anders Carlsson  <andersca@apple.com>
252
253         Add goBack: and goForward: IBActions and move stopLoading: to a new WKIBActions category on WKWebView
254         https://bugs.webkit.org/show_bug.cgi?id=130732
255
256         Reviewed by Tim Horton.
257
258         * MiniBrowser/mac/WK2BrowserWindowController.m:
259         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
260
261 2014-03-25  Martin Robinson  <mrobinson@igalia.com>
262
263         [GTK] Remove the autotools build
264         https://bugs.webkit.org/show_bug.cgi?id=130717
265
266         Reviewed by Anders Carlsson.
267
268         * DumpRenderTree/config.h: Remove references to the autotools configure file.
269         * GNUmakefile.am: Removed.
270         * GtkLauncher/GNUmakefile.am: Removed.
271         * GtkLauncher/main.c: Remove references to the autotools configure file.
272         * MiniBrowser/gtk/BrowserDownloadsBar.c: Ditto.
273         * MiniBrowser/gtk/BrowserSearchBar.c: Ditto.
274         * MiniBrowser/gtk/BrowserWindow.c: Ditto.
275         * MiniBrowser/gtk/GNUmakefile.am: Removed.
276         * MiniBrowser/gtk/main.c: Remove references to the autotools configure file.
277         * Scripts/build-webkit: No longer handle autotools.
278         * Scripts/run-gtk-tests: Ditto.
279         (TestRunner._setup_testing_environment):
280         * Scripts/run-launcher: Ditto.
281         * Scripts/webkitdirs.pm: Ditto.
282         * Scripts/webkitpy/common/config/contributionareas.py: Remove autotools as a contribution area.
283         * Scripts/webkitpy/common/config/contributors.json: Ditto.
284         * Scripts/webkitpy/port/gtk.py: No longer handle autotools.
285         * Scripts/webkitpy/style/checker.py:
286         * TestWebKitAPI/GNUmakefile.am: Removed.
287         * TestWebKitAPI/config.h: Remove references to the autotools configure file.
288         * WebKitTestRunner/GNUmakefile.am: Removed.
289         * WebKitTestRunner/WebKitTestRunnerPrefix.h: Ditto.
290         * gtk/GNUmakefile.am: Removed.
291         * gtk/common.py: Remove checks for the autotools build.
292         * gtk/symbols.filter: Renamed from Source/autotools/symbols.filter.
293
294 2014-03-25  László Langó  <llango.u-szeged@partner.samsung.com>
295
296         prepare-ChangeLog throws false positive warnings for modified files.
297         https://bugs.webkit.org/show_bug.cgi?id=130687
298
299         Reviewed by Darin Adler.
300
301         * Scripts/prepare-ChangeLog:
302         (originalFile): Ignore git commit paremeter.
303         We don't need this to get the unmodified file.
304         (extractLineRangeBeforeChange):
305         Simplify the if statement. Follow-up after r166189.
306
307 2014-03-25  Gabor Rapcsanyi  <rgabor@webkit.org>
308
309         [EFL] Add ARM64 build support
310         https://bugs.webkit.org/show_bug.cgi?id=130506
311
312         Rubber stamped by Gyuyoung Kim.
313
314         * Scripts/webkitdirs.pm:
315         (isARM): Detect aarch64 as ARM.
316
317 2014-03-25  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
318
319         [webkitpy] Improve _parse_bug_description to recognize more descriptions
320         https://bugs.webkit.org/show_bug.cgi?id=130137
321
322         Reviewed by Csaba Osztrogonác.
323
324         * Scripts/webkitpy/common/checkout/changelog.py:
325         (ChangeLogEntry._parse_bug_description):
326         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
327         (test_parse_log_entries_from_changelog):
328         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
329         (CheckoutTest.test_commit_info_for_revision):
330
331 2014-03-24  Andy Estes  <aestes@apple.com>
332
333         Fix the iOS build of TestWebKitAPI.
334
335         * TestWebKitAPI/Configurations/Base.xcconfig:
336         * TestWebKitAPI/PlatformUtilities.h:
337
338 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
339
340         Fix prepare-ChangeLog after r166156.
341         https://bugs.webkit.org/show_bug.cgi?id=130674
342
343         Reviewed by Darin Adler.
344
345         * Scripts/prepare-ChangeLog:
346         (generateFunctionLists):
347         (extractLineRangeBeforeChange):
348
349 2014-03-24  Andy Estes  <aestes@apple.com>
350
351         [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
352         https://bugs.webkit.org/show_bug.cgi?id=129322
353
354         Reviewed by Anders Carlsson.
355
356         Add an API test suite for _WKDownload.
357
358         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
359         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm: Added.
360         (-[DownloadDelegate initWithSourceURL:]):
361         (-[DownloadDelegate sourceURL]):
362         (-[DownloadDelegate _downloadDidStart:]):
363         (-[DownloadDelegate _download:didReceiveResponse:]):
364         (-[DownloadDelegate _download:didReceiveData:]):
365         (-[DownloadDelegate _download:decideDestinationWithSuggestedFilename:allowOverwrite:]):
366         (-[DownloadDelegate _downloadDidFinish:]):
367         (TEST):
368         (runTestWithNavigationDelegate):
369         (-[DownloadNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
370         (-[ConvertResponseToDownloadNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
371
372 2014-03-24  Joseph Pecoraro  <pecoraro@apple.com>
373
374         filter-build-webkit: reduce unfiltered output
375         https://bugs.webkit.org/show_bug.cgi?id=130485
376
377         Reviewed by Brent Fulgham.
378
379         * Scripts/filter-build-webkit:
380         (shouldIgnoreLine):
381
382 2014-03-24  László Langó  <llango.u-szeged@partner.samsung.com>
383
384         prepare-ChangeLog should list functions that have been removed too.
385         https://bugs.webkit.org/show_bug.cgi?id=130508
386
387         Reviewed by Darin Adler.
388
389         The prepare-ChangeLog does not list the deleted functions in the Changelog.
390         We have to read the functions and the line ranges of them from the source
391         before the change, then search for overlaps between them and the changed
392         line ranges from diff.
393
394         * Scripts/prepare-ChangeLog:
395         (originalFile): Get original source command.
396         (generateFunctionLists): Collect deleted functions too.
397         (generateFunctionListsByRanges): Duplicated code is moved to a separate subroutine.
398         (extractLineRangeBeforeChange): Extract line ranges from the original source to get
399         deleted functions ranges too.
400         (extractLineRange): Renamed to extractLineRangeAfterChange.
401
402 2014-03-23  Hyowon Kim  <hw1008.kim@samsung.com>
403
404         Move all EFL typedefs into EflTypedefs.h.
405         https://bugs.webkit.org/show_bug.cgi?id=130511
406
407         Reviewed by Gyuyoung Kim.
408
409         * TestWebKitAPI/PlatformWebView.h: Remove EFL typedefs.
410         * WebKitTestRunner/InjectedBundle/TestRunner.h: Ditto.
411         * WebKitTestRunner/PlatformWebView.h: Ditto.
412
413 2014-03-21  Simon Fraser  <simon.fraser@apple.com>
414
415         Don't flush compositing layers within FrameView::willPaintContents()
416         https://bugs.webkit.org/show_bug.cgi?id=130627
417         <rdar://problem/16368869>
418
419         Reviewed by Sam Weinig.
420         
421         Fix DRT to correctly render tests with layers now that FrameView::paintContents
422         does not flush.
423         
424         Move the -[WebView displayIfNeeded] from -[FrameLoadDelegate webView:didFinishLoadForFrame:]
425         into an explicit function called before dumping. 
426         
427         Then explicitly call _flushCompositingChanges to ensure that GraphicsLayer changes
428         are flushed to CA. They will be pushed to the window by snapshotting.
429
430         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
431         Fix weird path to IOKit.framework.
432         * DumpRenderTree/mac/DumpRenderTree.mm:
433         (updateDisplay):
434         (dump):
435         * DumpRenderTree/mac/FrameLoadDelegate.mm:
436         (-[FrameLoadDelegate webView:locationChangeDone:forDataSource:]): Fix parameter name.
437         (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Remove display call.
438
439 2014-03-21  David Kilzer  <ddkilzer@apple.com>
440
441         fix-blink-patch: tool to fix up renamed directory paths in Blink
442         <http://webkit.org/b/130609>
443
444         Reviewed by Ryosuke Niwa.
445
446         Usage: cat blink.patch | fix-blink-patch | svn-apply
447
448         * Scripts/fix-blink-patch: Added.
449
450 2014-03-21  Darin Adler  <darin@apple.com>
451
452         Remove use of deprecatedCharacters in WebKit API tests
453         https://bugs.webkit.org/show_bug.cgi?id=130602
454
455         Reviewed by Antti Koivisto.
456
457         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
458         (TestWebKitAPI::expectBuilderContent): Use characters8/16 instead of deprecatedCharacters.
459         (TestWebKitAPI::expectEmpty): Use characters8.
460         (TestWebKitAPI::TEST): Use characters8 instead of deprecatedCharacters in most cases.
461
462         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
463         Removed the test that is entirely about 16-bit conversion since that's basically a test of
464         the deprecatedCharacters function itself, which we are about to delete.
465
466 2014-03-21  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
467
468         [webkitpy] Fix has_valid_reviewer()
469         https://bugs.webkit.org/show_bug.cgi?id=130589
470
471         Reviewed by Csaba Osztrogonác.
472
473         * Scripts/webkitpy/common/checkout/changelog.py:
474         (ChangeLogEntry.has_valid_reviewer):
475         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
476         (test_has_valid_reviewer):
477         * Scripts/webkitpy/common/config/committers.py:
478         (CommitterList._reviewer_only):
479         (CommitterList.committer_by_name):
480         (CommitterList.reviewer_by_email):
481         (CommitterList):
482         (CommitterList.reviewer_by_name):
483
484 2014-03-21  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
485
486         Add cache support for jhbuild
487         https://bugs.webkit.org/show_bug.cgi?id=130588
488
489         Reviewed by Csaba Osztrogonác.
490
491         * jhbuild/jhbuildrc_common.py:
492         (init): Jhbuild can now save the dependencies locally, if the JHBUILD_MIRROR environment variable is set.
493
494 2014-03-21  Xabier Rodriguez Calvar  <calvaris@igalia.com>
495
496         [CMake] Add support for MAX_CPU_LOAD translated to -l in ninja and make
497         https://bugs.webkit.org/show_bug.cgi?id=130504
498
499         Reviewed by Martin Robinson.
500
501         * Scripts/build-webkit: Add the maxCPULoad() to the makeArgs in
502         CMake if not specified.
503         * Scripts/webkitdirs.pm:
504         (determineMaxCPULoad): Read MAX_CPU_LOAD as maxCPULoad.
505         (maxCPULoad): determineMaxCPULoad and return maxCPULoad.
506
507 2014-03-21  Andreas Kling  <akling@apple.com>
508
509         RetainPtr API test should use CFArray instead of CFString for testing.
510         <rdar://problem/16384899>
511
512         Unreviewed bot fix.
513
514         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
515         (TestWebKitAPI::TEST):
516         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
517         (TestWebKitAPI::TEST):
518
519 2014-03-20  Hyowon Kim  <hw1008.kim@samsung.com>
520
521         Move to using std::unique_ptr for EFL objects.
522         https://bugs.webkit.org/show_bug.cgi?id=129853
523
524         Reviewed by Gyuyoung Kim.
525
526         EflUniquePtr is a template alias of std::unique_ptr
527         with a custom deleter for each Efl Objects, which is motivated by GUniquePtr.
528         This patch replaces uses of OwnPtr and PassOwnPtr for Efl objects with EflUniquePtr.
529
530         * DumpRenderTree/efl/DumpRenderTree.cpp:
531         (main):
532         * ImageDiff/efl/ImageDiff.cpp:
533         (initEfl):
534         (main):
535
536 2014-03-20  Ryuan Choi  <ryuan.choi@samsung.com>
537
538         Unreviewed buildfix after r165983 for non Cocoa platforms
539
540         Renamed WKPreferencesPrivate.h to WKPreferencesRefPrivate.h
541
542         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
543         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
544         * WebKitTestRunner/TestController.cpp:
545
546 2014-03-20  Zan Dobersek  <zdobersek@igalia.com>
547
548         [GTK][CMake] Add support for building with Clang
549         https://bugs.webkit.org/show_bug.cgi?id=130260
550
551         Reviewed by Martin Robinson.
552
553         * TestWebKitAPI/CMakeLists.txt: When building with Clang TestWebKitAPI should be
554         built with GTEST_HAS_TR1_TUPLE defined to 0 to avoid build failures occuring in the
555         included GTest framework headers.
556         * gtk/generate-gtkdoc:
557         (prepare_environment_for_gtkdoc_generation): Don't modify the CFLAGS env anymore
558         in case of using Clang since that is now set by the CMake rule.
559
560 2014-03-19  Simon Fraser  <simon.fraser@apple.com>
561
562         Expose text and page zoom in WK2 SPI, and hook them up in MiniBrowser
563         https://bugs.webkit.org/show_bug.cgi?id=130476
564
565         Reviewed by Anders Carlsson.
566         
567         Hook up page/text zoom in MiniBrowser, make reload work, remove some logging.
568
569         * MiniBrowser/mac/WK1BrowserWindowController.m:
570         (-[WK1BrowserWindowController webView:decidePolicyForNavigationAction:request:frame:decisionListener:]):
571         Remove log.
572         * MiniBrowser/mac/WK2BrowserWindowController.m:
573         (-[WK2BrowserWindowController awakeFromNib]):
574         (-[WK2BrowserWindowController validateMenuItem:]):
575         (-[WK2BrowserWindowController reload:]):
576         Hook up reload.
577         (-[WK2BrowserWindowController toggleZoomMode:]):
578         (-[WK2BrowserWindowController resetZoom:]):
579         (-[WK2BrowserWindowController canResetZoom]):
580         (-[WK2BrowserWindowController currentZoomFactor]):
581         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
582         (-[WK2BrowserWindowController canZoomIn]):
583         (-[WK2BrowserWindowController canZoomOut]):
584
585 2014-03-19  Alexey Proskuryakov  <ap@apple.com>
586
587         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
588         https://bugs.webkit.org/show_bug.cgi?id=130463
589
590         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm: Disable the test.
591
592 2014-03-18  Samuel White  <samuel_white@apple.com>
593
594         AX: Not able to use arrow keys to read text with VoiceOver before selection is set someplace (anyplace).
595         https://bugs.webkit.org/show_bug.cgi?id=130250
596
597         Reviewed by Chris Fleizach.
598
599         Added ability to toggle enhanced accessibility on and off to support tests that require it.
600
601         * DumpRenderTree/AccessibilityController.cpp:
602         (enableEnhancedAccessibilityCallback):
603         (getEnhancedAccessibilityEnabledCallback):
604         (AccessibilityController::getJSClass):
605         * DumpRenderTree/AccessibilityController.h:
606         * DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
607         (AccessibilityController::enableEnhancedAccessibility):
608         (AccessibilityController::enhancedAccessibilityEnabled):
609         * DumpRenderTree/ios/AccessibilityControllerIOS.mm:
610         (AccessibilityController::enableEnhancedAccessibility):
611         (AccessibilityController::enhancedAccessibilityEnabled):
612         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
613         (AccessibilityController::enableEnhancedAccessibility):
614         (AccessibilityController::enhancedAccessibilityEnabled):
615         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
616         (AccessibilityController::enableEnhancedAccessibility):
617         (AccessibilityController::enhancedAccessibilityEnabled):
618         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
619         (WTR::AccessibilityController::enableEnhancedAccessibility):
620         (WTR::AccessibilityController::enhancedAccessibilityEnabled):
621         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
622         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
623
624 2014-03-18  Filip Pizlo  <fpizlo@apple.com>
625
626         Unreviewed, add some contributors, and fix Nadav's entry (he's not really a reviewer
627         yet).
628
629         * Scripts/webkitpy/common/config/contributors.json:
630
631 2014-03-18  Joseph Pecoraro  <pecoraro@apple.com>
632
633         Web Inspector: Remove stale ReportMemoryUsagePlugin
634         https://bugs.webkit.org/show_bug.cgi?id=130405
635
636         Reviewed by Andreas Kling.
637
638         This clang plugin looks like it was used for the old Inspector memory
639         instrumentation that was removed. So the tool can be removed.
640
641         * clang/ReportMemoryUsagePlugin/CMakeLists.txt: Removed.
642         * clang/ReportMemoryUsagePlugin/Makefile: Removed.
643         * clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp: Removed.
644         * clang/ReportMemoryUsagePlugin/tests/Source/WebCore/Test.cpp: Removed.
645
646 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
647
648         webkit-patch land shouldn't add a reviewer for unreviewed build fixes
649         https://bugs.webkit.org/show_bug.cgi?id=130220
650
651         Reviewed by Csaba Osztrogonác.
652
653         * Scripts/webkitpy/common/checkout/changelog.py:
654         (ChangeLog.set_reviewer):
655         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
656         (test_set_reviewer):
657
658 2014-03-17  Filip Pizlo  <fpizlo@apple.com>
659
660         More FTL enabling.
661
662         Rubber stamped by Dan Bernstein.
663
664         * Tools/Scripts/build-webkit:
665
666 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
667
668         Renable pagination mode in WK2 MiniBrowser
669         https://bugs.webkit.org/show_bug.cgi?id=130374
670
671         Reviewed by Anders Carlsson.
672         
673         Put the implementation of togglePaginationMode: back, and correctly
674         enable the menu item.
675
676         * MiniBrowser/mac/WK2BrowserWindowController.m:
677         (-[WK2BrowserWindowController validateMenuItem:]):
678         (-[WK2BrowserWindowController isPaginated]):
679         (-[WK2BrowserWindowController togglePaginationMode:]):
680
681 2014-03-18  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
682
683         Add --reset option to Tools/Scripts/set-webkit-configuration script
684         https://bugs.webkit.org/show_bug.cgi?id=130401
685
686         Reviewed by Csaba Osztrogonác.
687
688         * Scripts/set-webkit-configuration:
689
690 2014-03-18  Alberto Garcia  <berto@igalia.com>
691
692         [GTK] [CMake] build-webkit-options.txt is not generated during a fresh build
693         https://bugs.webkit.org/show_bug.cgi?id=130388
694
695         Reviewed by Sergio Villar Senin.
696
697         * Scripts/webkitdirs.pm:
698         (shouldRemoveCMakeCache): make sure that the build directory
699         exists before attempting to create a file in it.
700
701 2014-03-18  Robert Plociennik  <r.plociennik@samsung.com>
702
703         [EFL] fontconfig-2.8.0 is not compliant with C++11 leading to a build break
704         https://bugs.webkit.org/show_bug.cgi?id=130336
705
706         Reviewed by Gyuyoung Kim.
707
708         Compilation with gcc 4.8.x results in 'invalid suffix on literal; C++11
709         requires a space between literal and string macro [-Wliteral-suffix]'
710         warning treated as error.
711
712         This patch applies a solution from r162448 to the EFL port.
713
714         * efl/patches/fontconfig-C-11-requires-a-space-between-literal-and-identifier.patch: Added.
715         * efl/jhbuild.modules: Added appropriate patch section.
716
717 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
718
719         webkitpy test rebaseline.
720
721         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
722         (MainTest.test_default_args):
723
724 2014-03-17  Ryosuke Niwa  <rniwa@webkit.org>
725
726         --profile should imply --test-runner-count=1 in run-perf-tests
727         https://bugs.webkit.org/show_bug.cgi?id=130375
728
729         Reviewed by Benjamin Poulain.
730
731         Use the test runner count of 1 when --profile is specified but not --test-runner-count.
732
733         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
734         (PerfTestsRunner._parse_args): Use -1 as the default value.
735         (PerfTestsRunner._collect_tests): If --test-runner-count is set (i.e. it's a positive value),
736         then use that value. Otherwise, if it's never set and --profile is present, test-runner-count
737         should be 1.
738
739 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
740
741         Address some style nits.
742
743         * MiniBrowser/mac/WK2BrowserWindowController.m:
744
745 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
746
747         Add transparent window support back into MiniBrowser
748         https://bugs.webkit.org/show_bug.cgi?id=130363
749
750         Reviewed by Anders Carlsson.
751         
752         Re-enable transparent window support for WK2.
753
754         * MiniBrowser/mac/WK2BrowserWindowController.m:
755         (-[WK2BrowserWindowController validateMenuItem:]):
756         (-[WK2BrowserWindowController toggleTransparentWindow:]):
757
758 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
759
760         Fix the 32-bit build; make the open panel make a WK1 window.
761
762         * MiniBrowser/mac/AppDelegate.m:
763         (-[BrowserAppDelegate openDocument:]):
764
765 2014-03-17  Simon Fraser  <simon.fraser@apple.com>
766
767         Convert MiniBrowser to use WKWebView API
768         https://bugs.webkit.org/show_bug.cgi?id=130061
769
770         Reviewed by Anders Carlsson.
771         
772         Convert the MiniBrowser WK2 window to use WebKit2 API as much
773         as possible.
774         
775         Some functionality was removed temporarily:
776             - text zoom, page zoom
777             - reload
778             - pagination mode
779             - transparent window
780             - dumping source
781             - window.open support
782             - beforeUnload panel
783             - find in page
784
785         * MiniBrowser/mac/AppDelegate.h:
786         * MiniBrowser/mac/AppDelegate.m:
787         (-[BrowserAppDelegate init]):
788         (-[BrowserAppDelegate newWindow:]):
789         (-[BrowserAppDelegate applicationWillTerminate:]):
790         (-[BrowserAppDelegate openDocument:]):
791         * MiniBrowser/mac/WK2BrowserWindowController.h:
792         * MiniBrowser/mac/WK2BrowserWindowController.m:
793         (-[WK2BrowserWindowController awakeFromNib]):
794         (-[WK2BrowserWindowController dealloc]):
795         (-[WK2BrowserWindowController fetch:]):
796         (-[WK2BrowserWindowController validateMenuItem:]):
797         (-[WK2BrowserWindowController reload:]):
798         (-[WK2BrowserWindowController goBack:]):
799         (-[WK2BrowserWindowController goForward:]):
800         (-[WK2BrowserWindowController toggleZoomMode:]):
801         (-[WK2BrowserWindowController resetZoom:]):
802         (-[WK2BrowserWindowController canResetZoom]):
803         (-[WK2BrowserWindowController dumpSourceToConsole:]):
804         (-[WK2BrowserWindowController togglePaginationMode:]):
805         (-[WK2BrowserWindowController validateUserInterfaceItem:]):
806         (-[WK2BrowserWindowController windowShouldClose:]):
807         (-[WK2BrowserWindowController applicationTerminating]):
808         (-[WK2BrowserWindowController currentZoomFactor]):
809         (-[WK2BrowserWindowController setCurrentZoomFactor:]):
810         (-[WK2BrowserWindowController toggleTransparentWindow:]):
811         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
812         (-[WK2BrowserWindowController webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
813         (-[WK2BrowserWindowController webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
814         (-[WK2BrowserWindowController webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
815         (-[WK2BrowserWindowController find:]):
816         (-[WK2BrowserWindowController webView:decidePolicyForNavigationResponse:decisionHandler:]):
817         (-[WK2BrowserWindowController webView:didStartProvisionalNavigation:]):
818         (-[WK2BrowserWindowController webView:didReceiveServerRedirectForProvisionalNavigation:]):
819         (-[WK2BrowserWindowController webView:didFailProvisionalNavigation:withError:]):
820         (-[WK2BrowserWindowController webView:didCommitNavigation:]):
821         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]):
822         (-[WK2BrowserWindowController webView:didFailNavigation:withError:]):
823         * WebKitTestRunner/PlatformWebView.h:
824         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
825         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
826
827 2014-03-17  Zan Dobersek  <zdobersek@igalia.com>
828
829         Use RunLoop objects through references instead of pointers
830         https://bugs.webkit.org/show_bug.cgi?id=130313
831
832         Reviewed by Andreas Kling.
833
834         Adjust the code accordingly now that RunLoop::current() and RunLoop::main()
835         return RunLoop reference instead of a pointer.
836
837         * TestWebKitAPI/Tests/WebKit2Gtk/DOMDOMWindowTest.cpp:
838         (loadedCallback):
839         (clickedCallback):
840
841 2014-03-17  Tim Horton  <timothy_horton@apple.com>
842
843         sort-export-file --help doesn't work (missing 'use')
844         https://bugs.webkit.org/show_bug.cgi?id=130338
845
846         Reviewed by Anders Carlsson.
847
848         * Scripts/sort-export-file:
849         Add a missing 'use', and fix a typo in an error message.
850
851 2014-03-17  Martin Robinson  <mrobinson@igalia.com>
852
853         [GTK][CMake] Ensure that HAVE_GTK_UNIX_PRINTING is defined when appropriate
854         https://bugs.webkit.org/show_bug.cgi?id=130155
855
856         Reviewed by Philippe Normand.
857
858         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt: Add GTK_UNIX_PRINT flags to the build.
859
860 2014-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
861
862         [GTK] MiniBrowser fails to load injected bundle lib
863         https://bugs.webkit.org/show_bug.cgi?id=130332
864
865         Reviewed by Anders Carlsson.
866
867         This is because WEBKIT_INJECTED_BUNDLE_PATH env var is set too late.
868
869         * MiniBrowser/gtk/main.c:
870         (main): Make sure WEBKIT_INJECTED_BUNDLE_PATH is set before a web
871         process is spawn.
872
873 2014-03-16  Kim Byung Jun  <bj1987.kim@samsung.com>
874
875         [EFL] Enable TOUCH_SLIDER macro
876         https://bugs.webkit.org/show_bug.cgi?id=130185
877
878         Reviewed by Gyuyoung Kim.
879
880         * Scripts/webkitperl/FeatureList.pm:
881
882 2014-03-16  Zan Dobersek  <zdobersek@igalia.com>
883
884         [GTK][CMake] Build with -fno-rtti
885         https://bugs.webkit.org/show_bug.cgi?id=130261
886
887         Reviewed by Martin Robinson.
888
889         * TestWebKitAPI/CMakeLists.txt: Build TestWebKitAPI with GTEST_HAS_RTTI macro
890         defined to 0 to prevent typeid use in included GTest headers.
891
892 2014-03-16  Brian Burg  <bburg@apple.com>
893
894         Web Inspector: vended backend commands file should be generated as part of the build
895         https://bugs.webkit.org/show_bug.cgi?id=130110
896
897         Reviewed by Timothy Hatcher.
898
899         * Scripts/build-webkit: build WebInspectorUI after WebCore but before WebKit.
900
901 2014-03-16  Diego Pino García  <dpino@igalia.com>
902
903         [GTK] Minibrowser: Add shortcuts for reloading page and reloading page ignoring cache
904         https://bugs.webkit.org/show_bug.cgi?id=128999
905
906         Reviewed by Philippe Normand.
907
908         * MiniBrowser/gtk/BrowserWindow.c:
909         (reloadPage):
910         (reloadPageIgnoringCache):
911         (browser_window_init):
912
913 2014-03-15  Martin Robinson  <mrobinson@igalia.com>
914
915         [GTK] Improve ninja detection in webkitdirs.pm
916         https://bugs.webkit.org/show_bug.cgi?id=129902
917
918         Reviewed by Daniel Bates.
919
920         * Scripts/webkitdirs.pm:
921         (canUseNinja): Use which instead of trying to invoke ninja directly. This also allows
922         us to look for ninja-build as well.
923
924 2014-03-14  Maciej Stachowiak  <mjs@apple.com>
925
926         Replace "Apple Computer, Inc." with "Apple Inc." in copyright headers
927         https://bugs.webkit.org/show_bug.cgi?id=130276
928         <rdar://problem/16266927>
929         
930         Reviewed by Simon Fraser.
931
932         * BuildSlaveSupport/build-launcher-app:
933         * BuildSlaveSupport/build-launcher-dmg:
934         * DumpRenderTree/DumpRenderTree.h:
935         * DumpRenderTree/DumpRenderTreePrefix.h:
936         * DumpRenderTree/GCController.cpp:
937         * DumpRenderTree/GCController.h:
938         * DumpRenderTree/JavaScriptThreading.cpp:
939         * DumpRenderTree/JavaScriptThreading.h:
940         * DumpRenderTree/PixelDumpSupport.cpp:
941         * DumpRenderTree/PixelDumpSupport.h:
942         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
943         * DumpRenderTree/TestRunner.cpp:
944         * DumpRenderTree/TestRunner.h:
945         * DumpRenderTree/WorkQueue.cpp:
946         * DumpRenderTree/WorkQueue.h:
947         * DumpRenderTree/WorkQueueItem.h:
948         * DumpRenderTree/atk/AccessibilityCallbacks.h:
949         * DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
950         * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
951         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
952         * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
953         * DumpRenderTree/cg/PixelDumpSupportCG.h:
954         * DumpRenderTree/efl/EditingCallbacks.cpp:
955         * DumpRenderTree/efl/EditingCallbacks.h:
956         * DumpRenderTree/efl/EventSender.cpp:
957         * DumpRenderTree/efl/EventSender.h:
958         * DumpRenderTree/efl/GCControllerEfl.cpp:
959         * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
960         * DumpRenderTree/efl/TestRunnerEfl.cpp:
961         * DumpRenderTree/gtk/DumpRenderTree.cpp:
962         * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
963         * DumpRenderTree/gtk/EditingCallbacks.cpp:
964         * DumpRenderTree/gtk/EditingCallbacks.h:
965         * DumpRenderTree/gtk/EventSender.cpp:
966         * DumpRenderTree/gtk/EventSender.h:
967         * DumpRenderTree/gtk/GCControllerGtk.cpp:
968         * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
969         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
970         * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h:
971         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
972         * DumpRenderTree/gtk/TextInputController.cpp:
973         * DumpRenderTree/gtk/TextInputController.h:
974         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/Makefile.PL:
975         * DumpRenderTree/ios/PerlSupport/IPhoneSimulatorNotification/lib/IPhoneSimulatorNotification.pm:
976         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
977         * DumpRenderTree/mac/AppleScriptController.h:
978         * DumpRenderTree/mac/AppleScriptController.m:
979         * DumpRenderTree/mac/CheckedMalloc.cpp:
980         * DumpRenderTree/mac/CheckedMalloc.h:
981         * DumpRenderTree/mac/DumpRenderTree.mm:
982         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
983         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
984         * DumpRenderTree/mac/DumpRenderTreeMac.h:
985         * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
986         * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
987         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
988         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
989         * DumpRenderTree/mac/EditingDelegate.h:
990         * DumpRenderTree/mac/EditingDelegate.mm:
991         * DumpRenderTree/mac/EventSendingController.h:
992         * DumpRenderTree/mac/EventSendingController.mm:
993         * DumpRenderTree/mac/FrameLoadDelegate.h:
994         * DumpRenderTree/mac/FrameLoadDelegate.mm:
995         * DumpRenderTree/mac/GCControllerMac.mm:
996         * DumpRenderTree/mac/MockWebNotificationProvider.h:
997         * DumpRenderTree/mac/MockWebNotificationProvider.mm:
998         * DumpRenderTree/mac/NavigationController.h:
999         * DumpRenderTree/mac/NavigationController.m:
1000         * DumpRenderTree/mac/ObjCController.h:
1001         * DumpRenderTree/mac/ObjCController.m:
1002         * DumpRenderTree/mac/ObjCPlugin.h:
1003         * DumpRenderTree/mac/ObjCPlugin.m:
1004         * DumpRenderTree/mac/ObjCPluginFunction.h:
1005         * DumpRenderTree/mac/ObjCPluginFunction.m:
1006         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1007         * DumpRenderTree/mac/PolicyDelegate.h:
1008         * DumpRenderTree/mac/PolicyDelegate.mm:
1009         * DumpRenderTree/mac/ResourceLoadDelegate.h:
1010         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
1011         * DumpRenderTree/mac/TestRunnerMac.mm:
1012         * DumpRenderTree/mac/TextInputController.h:
1013         * DumpRenderTree/mac/TextInputController.m:
1014         * DumpRenderTree/mac/UIDelegate.h:
1015         * DumpRenderTree/mac/UIDelegate.mm:
1016         * DumpRenderTree/mac/WorkQueueItemMac.mm:
1017         * DumpRenderTree/win/DRTDataObject.cpp:
1018         * DumpRenderTree/win/DRTDataObject.h:
1019         * DumpRenderTree/win/DRTDesktopNotificationPresenter.h:
1020         * DumpRenderTree/win/DRTDropSource.cpp:
1021         * DumpRenderTree/win/DRTDropSource.h:
1022         * DumpRenderTree/win/DraggingInfo.h:
1023         * DumpRenderTree/win/DumpRenderTree.cpp:
1024         * DumpRenderTree/win/DumpRenderTreeWin.h:
1025         * DumpRenderTree/win/EditingDelegate.cpp:
1026         * DumpRenderTree/win/EditingDelegate.h:
1027         * DumpRenderTree/win/EventSender.cpp:
1028         * DumpRenderTree/win/EventSender.h:
1029         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1030         * DumpRenderTree/win/FrameLoadDelegate.h:
1031         * DumpRenderTree/win/GCControllerWin.cpp:
1032         * DumpRenderTree/win/HistoryDelegate.cpp:
1033         * DumpRenderTree/win/HistoryDelegate.h:
1034         * DumpRenderTree/win/MD5.cpp:
1035         * DumpRenderTree/win/MD5.h:
1036         * DumpRenderTree/win/PixelDumpSupportWin.cpp:
1037         * DumpRenderTree/win/PolicyDelegate.cpp:
1038         * DumpRenderTree/win/PolicyDelegate.h:
1039         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
1040         * DumpRenderTree/win/ResourceLoadDelegate.h:
1041         * DumpRenderTree/win/TestRunnerWin.cpp:
1042         * DumpRenderTree/win/TextInputController.cpp:
1043         * DumpRenderTree/win/TextInputController.h:
1044         * DumpRenderTree/win/TextInputControllerWin.cpp:
1045         * DumpRenderTree/win/UIDelegate.cpp:
1046         * DumpRenderTree/win/UIDelegate.h:
1047         * DumpRenderTree/win/WorkQueueItemWin.cpp:
1048         * EWebLauncher/main.c:
1049         * GtkLauncher/main.c:
1050         * ImageDiff/efl/ImageDiff.cpp:
1051         * ImageDiff/gtk/ImageDiff.cpp:
1052         * MiniBrowser/gtk/main.c:
1053         * Scripts/SpacingHeuristics.pm:
1054         * Scripts/VCSUtils.pm:
1055         * Scripts/bisect-builds:
1056         * Scripts/build-dumprendertree:
1057         * Scripts/build-jsc:
1058         * Scripts/build-webkit:
1059         * Scripts/check-dom-results:
1060         * Scripts/check-for-exit-time-destructors:
1061         * Scripts/check-for-global-initializers:
1062         * Scripts/commit-log-editor:
1063         * Scripts/compare-timing-files:
1064         * Scripts/debug-minibrowser:
1065         * Scripts/debug-safari:
1066         * Scripts/do-file-rename:
1067         * Scripts/find-extra-includes:
1068         * Scripts/generate-coverage-data:
1069         * Scripts/make-script-test-wrappers:
1070         * Scripts/malloc-tree:
1071         * Scripts/old-run-webkit-tests:
1072         * Scripts/parse-malloc-history:
1073         * Scripts/report-include-statistics:
1074         * Scripts/resolve-ChangeLogs:
1075         * Scripts/run-bindings-tests:
1076         * Scripts/run-iexploder-tests:
1077         * Scripts/run-javascriptcore-tests:
1078         * Scripts/run-jsc:
1079         * Scripts/run-launcher:
1080         * Scripts/run-leaks:
1081         * Scripts/run-mangleme-tests:
1082         * Scripts/run-minibrowser:
1083         * Scripts/run-pageloadtest:
1084         * Scripts/run-regexp-tests:
1085         * Scripts/run-safari:
1086         * Scripts/run-sunspider:
1087         * Scripts/run-webkit-app:
1088         * Scripts/sampstat:
1089         * Scripts/set-webkit-configuration:
1090         * Scripts/sort-Xcode-project-file:
1091         * Scripts/sort-export-file:
1092         * Scripts/split-file-by-class:
1093         * Scripts/sunspider-compare-results:
1094         * Scripts/svn-apply:
1095         * Scripts/svn-create-patch:
1096         * Scripts/svn-unapply:
1097         * Scripts/test-webkit-scripts:
1098         * Scripts/update-javascriptcore-test-results:
1099         * Scripts/update-webkit:
1100         * Scripts/update-webkit-auxiliary-libs:
1101         * Scripts/update-webkit-dependency:
1102         * Scripts/update-webkit-localizable-strings:
1103         * Scripts/update-webkit-support-libs:
1104         * Scripts/update-webkit-wincairo-libs:
1105         * Scripts/webkit-build-directory:
1106         * Scripts/webkitdirs.pm:
1107         (installedSafariPath):
1108         * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl:
1109         * Scripts/webkitperl/VCSUtils_unittest/parseDiffHeader.pl:
1110         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffFooter.pl:
1111         * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
1112         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl:
1113         * Scripts/webkitperl/VCSUtils_unittest/parseSvnPropertyValue.pl:
1114         * Scripts/webkitperl/features.pm:
1115         * Scripts/webkitperl/httpd.pm:
1116         * Scripts/webkitpy/bindings/main.py:
1117         * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
1118         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
1119         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
1120         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
1121         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp:
1122         * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
1123         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
1124         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1125         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1126         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.h:
1127         * WebKitTestRunner/PixelDumpSupport.cpp:
1128         * WebKitTestRunner/PixelDumpSupport.h:
1129         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1130         * WinLauncher/WinLauncher.cpp:
1131         * WinLauncher/WinLauncher.h:
1132         * WinLauncher/stdafx.cpp:
1133         * WinLauncher/stdafx.h:
1134
1135 2014-03-14  Filip Pizlo  <fpizlo@apple.com>
1136
1137         Sometimes we need to be explicit about the SDK when running ranlib on Darwin
1138         https://bugs.webkit.org/show_bug.cgi?id=130265
1139
1140         Reviewed by Michael Saboff.
1141
1142         * Scripts/build-webkit:
1143         * Scripts/copy-webkitlibraries-to-product-directory:
1144
1145 2014-03-14  Landry Breuil  <landry@openbsd.org>
1146
1147         Recognize openbsd/netbsd and am64 archs in Tools/Scripts.
1148         Also allow to set MAKE in the environment.
1149         https://bugs.webkit.org/show_bug.cgi?id=129991
1150
1151         Reviewed by Andreas Kling.
1152
1153         * Scripts/webkitdirs.pm:
1154         (determineArchitecture):
1155         (determineNumberOfCPUs):
1156         (isBSD):
1157         (buildAutotoolsProject):
1158         * Scripts/webkitpy/common/system/platforminfo.py:
1159         (PlatformInfo.__init__):
1160         (PlatformInfo.is_openbsd):
1161         (PlatformInfo):
1162         (PlatformInfo.is_netbsd):
1163         (PlatformInfo._determine_os_name):
1164
1165 2014-03-14  Dean Jackson  <dino@apple.com>
1166
1167         Remove libWebKitSystemInterfaceLion.a
1168         https://bugs.webkit.org/show_bug.cgi?id=130254
1169
1170         Reviewed by Geoffrey Garen and Andreas Kling.
1171
1172         No need to copy the Lion libraries into the build.
1173
1174         * Scripts/copy-webkitlibraries-to-product-directory:
1175
1176 2014-03-14  Jinwoo Song  <jinwoo7.song@samsung.com>
1177
1178         [EFL][MiniBrowser] Revise help messages of command line parameters
1179         https://bugs.webkit.org/show_bug.cgi?id=130222
1180
1181         Reviewed by Csaba Osztrogonác.
1182
1183         Correct the default value description and make help messages to be consistent.
1184
1185         * MiniBrowser/efl/main.c:
1186
1187 2014-03-12  Sergio Villar Senin  <svillar@igalia.com>
1188
1189         Rename DEFINE_STATIC_LOCAL to DEPRECATED_DEFINE_STATIC_LOCAL
1190         https://bugs.webkit.org/show_bug.cgi?id=129612
1191
1192         Reviewed by Darin Adler.
1193
1194         For new code use static NeverDestroyed<T> instead.
1195
1196         * DumpRenderTree/JavaScriptThreading.cpp:
1197         (javaScriptThreadsMutex):
1198         (javaScriptThreads):
1199         * DumpRenderTree/efl/EventSender.cpp:
1200         (touchPointList):
1201         (delayedEventQueue):
1202         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1203         (delegatesWithDelayedWork):
1204         * Scripts/check-for-exit-time-destructors:
1205         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp:
1206         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1207         (testsMap):
1208
1209 2014-03-13  Sanghyup Lee  <sh53.lee@samsung.com>
1210
1211         [EFL][WK2] Fix compilation warning in Minibrowser
1212         https://bugs.webkit.org/show_bug.cgi?id=130132
1213
1214         Reviewed by Csaba Osztrogonác.
1215
1216         Replace mktemp() with mkstemp() to fix compilation warning in MiniBrowser.
1217
1218         * MiniBrowser/efl/main.c:
1219         (on_download_request):
1220
1221 2014-03-13  Filip Pizlo  <fpizlo@apple.com>
1222
1223         FTL should support IsBlah
1224         https://bugs.webkit.org/show_bug.cgi?id=130202
1225
1226         Reviewed by Geoffrey Garen.
1227         
1228         Running existing JSRegress tests with noInline gives us coverage for these
1229         changes. Chances are, this will also give coverage for other interesting things
1230         as well.
1231
1232         * Scripts/run-jsc-stress-tests:
1233
1234 2014-03-12  Brian Burg  <bburg@apple.com>
1235
1236         Web Inspector: Remove unused callId parameter from evaluateInWebInspector
1237         https://bugs.webkit.org/show_bug.cgi?id=129744
1238
1239         Reviewed by Timothy Hatcher.
1240
1241         * DumpRenderTree/TestRunner.cpp:
1242         (evaluateInWebInspectorCallback):
1243         * DumpRenderTree/TestRunner.h:
1244         * DumpRenderTree/efl/TestRunnerEfl.cpp:
1245         (TestRunner::evaluateInWebInspector):
1246         * DumpRenderTree/gtk/TestRunnerGtk.cpp:
1247         (TestRunner::evaluateInWebInspector):
1248         * DumpRenderTree/mac/TestRunnerMac.mm:
1249         (TestRunner::evaluateInWebInspector):
1250         * DumpRenderTree/win/TestRunnerWin.cpp:
1251         (TestRunner::evaluateInWebInspector):
1252         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1253         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1254         (WTR::TestRunner::evaluateInWebInspector):
1255         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1256
1257 2014-03-13  Jozsef Berta  <jberta.u-szeged@partner.samsung.com>
1258
1259         [GTK] build-webkit shouldn't show error message when ninja isn't installed
1260         https://bugs.webkit.org/show_bug.cgi?id=130129
1261
1262         Reviewed by Csaba Osztrogonác.
1263
1264         * Scripts/webkitdirs.pm:
1265         (canUseNinja): Redirecting stderr to /dev/null
1266
1267 2014-03-13  Andres Gomez  <agomez@igalia.com>
1268
1269         [GTK] "Tools/jhbuild/jhbuild-wrapper --gtk" build fails even after running Tools/gtk/install-dependencies due to missing proper libxml2 python bindings
1270         https://bugs.webkit.org/show_bug.cgi?id=130092
1271
1272         Reviewed by Csaba Osztrogonác.
1273
1274         Added "python-dev" as dependency for deb based distros. It is
1275         already present for rpm based distros. This dependency will allow
1276         libxml2 to generate its python bindings, needed by gtk-doc.
1277
1278         * gtk/install-dependencies:
1279
1280 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1281
1282         Unreviewed. Fix GTK+ cmake build after r165488.
1283
1284         * MiniBrowser/gtk/CMakeLists.txt: Add CMAKE_BINARY_DIR to include dirs.
1285
1286 2014-03-12  Carlos Garcia Campos  <cgarcia@igalia.com>
1287
1288         [GTK][CMAKE] Remove compile warnings about GTK+ deprecated API
1289         https://bugs.webkit.org/show_bug.cgi?id=130014
1290
1291         Reviewed by Martin Robinson.
1292
1293         Include cmake or autotools config header.
1294
1295         * MiniBrowser/gtk/BrowserDownloadsBar.c:
1296         * MiniBrowser/gtk/BrowserSearchBar.c:
1297         * MiniBrowser/gtk/BrowserWindow.c:
1298         * MiniBrowser/gtk/main.c:
1299
1300 2014-03-12  Commit Queue  <commit-queue@webkit.org>
1301
1302         Unreviewed, rolling out r165471.
1303         https://bugs.webkit.org/show_bug.cgi?id=130139
1304
1305         Didn't really fix the issue and broke another bot (Requested
1306         by mrobinson on #webkit).
1307
1308         Reverted changeset:
1309
1310         "[CMake] Newer versions of CMake cannot find older versions of
1311         Freetype"
1312         https://bugs.webkit.org/show_bug.cgi?id=130107
1313         http://trac.webkit.org/changeset/165471
1314
1315 2014-03-11  Filip Pizlo  <fpizlo@apple.com>
1316
1317         It should be possible to build WebKit with FTL on iOS
1318         https://bugs.webkit.org/show_bug.cgi?id=130116
1319
1320         Reviewed by Dan Bernstein.
1321
1322         * Scripts/build-webkit:
1323         * Scripts/copy-webkitlibraries-to-product-directory:
1324
1325 2014-03-12  Brent Fulgham  <bfulgham@apple.com>
1326
1327         [Win] Remove use of QTSDK
1328         https://bugs.webkit.org/show_bug.cgi?id=130049
1329
1330         Reviewed by Darin Adler.
1331
1332         * DumpRenderTree/win/DumpRenderTree.cpp:
1333         (initialize): Remove QuickTime code.
1334         * win/AssembleBuildLogs/AssembleLogs.cmd: Don't grab logs from
1335         building QTMovieWin.
1336
1337 2014-03-12  Martin Robinson  <mrobinson@igalia.com>
1338
1339         [GTK][CMAKE] Too verbose build output
1340         https://bugs.webkit.org/show_bug.cgi?id=130076
1341
1342         Reviewed by Carlos Garcia Campos.
1343
1344         Instead of building with cmake --build which isn't smart about pretty printing and
1345         colors, we build with a script which calls the proper build command.
1346
1347         * Scripts/webkitdirs.pm:
1348         (buildCMakeGeneratedProject): For GTK+ call the script that we generate during
1349         the CMake configuration pass.
1350
1351 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1352
1353         [CMake] Newer versions of CMake cannot find older versions of Freetype
1354         https://bugs.webkit.org/show_bug.cgi?id=130107
1355
1356         Reviewed by Gustavo Noronha Silva.
1357
1358         * gtk/jhbuildrc: Work around a bug in newer CMakes by giving the FREETYPE_DIR hint
1359         to CMake during jhbuild initialization.
1360
1361 2014-03-12  Zalan Bujtas  <zalan@apple.com>
1362
1363         Add hiDPI support for compositing content in DumpRenderTree/WebKitTestRunner
1364         https://bugs.webkit.org/show_bug.cgi?id=129961
1365
1366         Reviewed by Simon Fraser.
1367
1368         Now scaled content can go through the window capturing mechanism too for compositing content.
1369         AppleMagnifiedMode is redundant.
1370
1371         * DumpRenderTree/mac/DumpRenderTree.mm:
1372         (setDefaultsToConsistentValuesForTesting):
1373         (runTest):
1374         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
1375         (createBitmapContextFromWebView):
1376         * WebKitTestRunner/PlatformWebView.h:
1377         * WebKitTestRunner/cg/TestInvocationCG.cpp:
1378         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
1379         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
1380         (WTR::PlatformWebView::didInitializeClients):
1381         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
1382         (WTR::PlatformWebView::forceWindowFramesChanged):
1383         * WebKitTestRunner/mac/main.mm:
1384         (setDefaultsToConsistentValuesForTesting):
1385
1386 2014-03-12  Anton Obzhirov  <a.obzhirov@samsung.com>
1387
1388         Unreviewed. Add myself as a committer.
1389
1390         * Scripts/webkitpy/common/config/contributors.json:
1391
1392 2014-03-12  Ryuan Choi  <ryuan.choi@samsung.com>
1393
1394         Unreviewed build fix on the EFL port when used lower version of ATK
1395
1396         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1397         (WTR::AccessibilityUIElement::y): Fixed typo.
1398
1399 2014-03-11  Myles C. Maxfield  <mmaxfield@apple.com>
1400
1401         Some images are blank in the rebaseline server UI
1402         https://bugs.webkit.org/show_bug.cgi?id=130104
1403
1404         Reviewed by Tim Horton.
1405
1406         Let the server check for images in the 'retries' directory
1407         if it can't find an image otherwise.
1408
1409         * Scripts/webkitpy/tool/servers/rebaselineserver.py:
1410         (RebaselineHTTPRequestHandler.test_result):
1411
1412 2014-03-11  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
1413
1414         [GTK][CMake] --update-gtk has no effect
1415         https://bugs.webkit.org/show_bug.cgi?id=130088
1416
1417         Reviewed by Philippe Normand.
1418
1419         * Scripts/webkitdirs.pm:
1420         (buildCMakeProjectOrExit): call update-webkitgtk-libs if --update-gtk has been passed
1421         as an argument.
1422
1423 2014-03-10  Myles C. Maxfield  <mmaxfield@apple.com>
1424
1425         Add "System Font" to the list of whitelisted DRT fonts
1426         https://bugs.webkit.org/show_bug.cgi?id=130046
1427
1428         Reviewed by Darin Adler.
1429
1430         * DumpRenderTree/mac/DumpRenderTree.mm:
1431         (allowedFontFamilySet):
1432         * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
1433
1434 2014-03-11  Martin Robinson  <mrobinson@igalia.com>
1435
1436         [GTK] The jhbuild environment should set CMAKE_PREFIX_PATH and CMAKE_LIBRARY_PATH
1437         https://bugs.webkit.org/show_bug.cgi?id=130064
1438
1439         Reviewed by Philippe Normand.
1440
1441         * efl/jhbuildrc: Remove duplicated code.
1442         * gtk/jhbuildrc: Remove duplicated code.
1443         * jhbuild/jhbuildrc_common.py:
1444         (init): Move duplicated code from jhbuildrc's and extend setting CMake environment variables to
1445         GTK+. We always set the CMAKE_LIBRARY_PATH, which should be harmless for EFL 32-bit systems.
1446         and is apparently necessary for GTK+.
1447
1448 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1449
1450         check-webkit-style failed to complain about missing braces
1451         https://bugs.webkit.org/show_bug.cgi?id=34189
1452
1453         Reviewed by Ryosuke Niwa.
1454
1455         * Scripts/webkitpy/style/checkers/cpp.py:
1456         (check_braces):
1457         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1458         (WebKitStyleTest.test_braces):
1459
1460 2014-03-11  László Langó  <llango.u-szeged@partner.samsung.com>
1461
1462         Remove Qt cruft from style checker.
1463         https://bugs.webkit.org/show_bug.cgi?id=130085
1464
1465         Reviewed by Csaba Osztrogonác.
1466
1467         There is no 'foreach' keyword in c++. That was a Qt feature
1468         added in: http://trac.webkit.org/changeset/46113
1469         Qt was removed from WebKit, so we should remove the checks
1470         of this keyword from check-webkit-style scripts.
1471
1472         * Scripts/webkitpy/style/checkers/cpp.py:
1473         (check_spacing_for_function_call):
1474         (check_spacing):
1475         (check_braces):
1476         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1477         (CppStyleTest.test_mismatching_spaces_in_parens):
1478         (CppStyleTest.test_spacing_for_fncall):
1479         (WebKitStyleTest.test_braces):
1480
1481 2014-03-11  Martin Hodovan  <mhodovan@inf.u-szeged.hu>
1482
1483         [GTK] update-webkitgtk-libs needs itstool
1484         https://bugs.webkit.org/show_bug.cgi?id=130082
1485
1486         After http://trac.webkit.org/changeset/165110 WebKitGTK+ uses gtk-doc 1.20.
1487         itstool is a dependency of building gtk-doc from version 1.19, so it should
1488         be added to Tools/gtk/install-dependencies script, too.
1489
1490         Reviewed by Philippe Normand.
1491
1492         * gtk/install-dependencies:
1493
1494 2014-03-11  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
1495
1496         webkitbot rollout ChangeLogs should be nicer
1497         https://bugs.webkit.org/show_bug.cgi?id=122654
1498
1499         Reviewed by Csaba Osztrogonác.
1500
1501         Added bug urls and descriptions of rolled out patches to the rollout changelog
1502         if they are present in the original changelog. Additionally removed the list of
1503         changed files and functions.
1504
1505         * Scripts/webkitpy/common/checkout/changelog.py:
1506         (ChangeLog.update_with_unreviewed_message): Cut off the list of modified files.
1507         * Scripts/webkitpy/common/checkout/checkout.py:
1508         (Checkout._changelog_data_for_revision): Store bug description.
1509         * Scripts/webkitpy/common/checkout/checkout_mock.py:
1510         * Scripts/webkitpy/common/checkout/checkout_unittest.py:
1511         (CheckoutTest.test_commit_info_for_revision):
1512         * Scripts/webkitpy/common/checkout/commitinfo.py:
1513         (CommitInfo.bug_description): Added.
1514         (CommitInfo.to_json):
1515         * Scripts/webkitpy/common/checkout/commitinfo_unittest.py:
1516         (CommitInfoTest.test_commit_info_creation):
1517         * Scripts/webkitpy/tool/commands/download.py:
1518         (AbstractRolloutPrepCommand._prepare_state): Store bug ids and descriptions of rolled
1519         out patches for creating rollout changelog.
1520         (CreateRollout._prepare_state): Remove obsolete comments and code, the bug id that
1521         caused the regression is stored in state["bug_blocked"] now.
1522         * Scripts/webkitpy/tool/commands/download_unittest.py:
1523         (test_prepare_rollout):
1524         (test_create_rollout_multiple_revision):
1525         * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
1526         (PrepareChangeLogForRevert._message_for_revert): Add bug urls and descriptions of
1527         rolled out patches to the changelog.
1528         (PrepareChangeLogForRevert.run):
1529         * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
1530         (UpdateChangeLogsForRevertTest):
1531         (test_message_for_revert):
1532         * Scripts/webkitpy/tool/steps/reopenbugafterrollout.py:
1533         (ReopenBugAfterRollout.run):
1534
1535 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1536
1537         [ATK] Adjust WKTR/DRT to use new API from ATK 2.11.90
1538         https://bugs.webkit.org/show_bug.cgi?id=130021
1539
1540         Reviewed by Mario Sanchez Prada.
1541
1542         Replace deprecated functions to use new API from ATK 2.11.90.
1543
1544         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1545         (AccessibilityUIElement::x):
1546         (AccessibilityUIElement::y):
1547         (AccessibilityUIElement::width):
1548         (AccessibilityUIElement::height):
1549         (AccessibilityUIElement::clickPointX):
1550         (AccessibilityUIElement::clickPointY):
1551         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1552         (WTR::AccessibilityUIElement::x):
1553         (WTR::AccessibilityUIElement::y):
1554         (WTR::AccessibilityUIElement::width):
1555         (WTR::AccessibilityUIElement::height):
1556         (WTR::AccessibilityUIElement::clickPointX):
1557         (WTR::AccessibilityUIElement::clickPointY):
1558
1559 2014-03-11  Krzysztof Czech  <k.czech@samsung.com>
1560
1561         [ATK] Expose aria-posinset and aria-setsize through object attributes
1562         https://bugs.webkit.org/show_bug.cgi?id=130011
1563
1564         Reviewed by Chris Fleizach.
1565
1566         Added missing implementation of numberAttributeValue both to WKTR and DRT.
1567
1568         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1569         (AccessibilityUIElement::numberAttributeValue):
1570         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1571         (WTR::AccessibilityUIElement::numberAttributeValue):
1572
1573 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1574
1575         [Win] Unreviewed build fix.
1576
1577         Some bad Windows code was committed at some point that prevents the Apple Windows port
1578         from finding its runtime dependencies reliably.
1579
1580         * win/DLLLauncher/DLLLauncherMain.cpp:
1581         (appleApplicationSupportDirectory): Restored this function.
1582         (modifyPath): Update to use appleApplicationSupportDirectory function.
1583
1584 2014-03-10  Zoltan Horvath  <zoltan@webkit.org>
1585
1586         Let the user define the full address of the performance-site-server for uploading results
1587         https://bugs.webkit.org/show_bug.cgi?id=129819
1588
1589         Reviewed by Ryosuke Niwa.
1590
1591         Currently perftestsrunner.py assumes that the server uses https protocol all the time, which
1592         can be confusing. It's more straightforward, if you need to define explicitly the server's full
1593         address along with the protocol, when you're using this parameter. I added HTTPS as the default
1594         protocol for now, in order to avoid breaking the perf bots.
1595
1596         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1597         (_upload_json):
1598         * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
1599         (MainTest.test_upload_json):
1600
1601 2014-03-10  Brent Fulgham  <bfulgham@apple.com>
1602
1603         [Win] Pass environment to Pre-Build, Pre-Link, and Post-Build Stages.
1604         https://bugs.webkit.org/show_bug.cgi?id=130023
1605
1606         Reviewed by Dean Jackson.
1607
1608         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Add missing
1609         /SAFESEH flag to DLL launcher process.
1610
1611 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1612
1613         RunGtkWebKitGObjectDOMBindingsAPIBreakTests should be added to the BuildAndTestFactory not the TestFactory
1614         https://bugs.webkit.org/show_bug.cgi?id=129980
1615
1616         Reviewed by Carlos Garcia Campos.
1617
1618         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add RunGtkWebKitGObjectDOMBindingsAPIBreakTests to the correct factory.
1619
1620 2014-03-09  Martin Robinson  <mrobinson@igalia.com>
1621
1622         [GTK] Remove the WebView source-mode WebKit1 test
1623         https://bugs.webkit.org/show_bug.cgi?id=129976
1624
1625         Reviewed by Carlos Garcia Campos.
1626
1627         * TestWebKitAPI/Tests/WebKitGtk/testwebview.c: Remove the source-mode test.
1628
1629 2014-03-08  Martin Robinson  <mrobinson@igalia.com>
1630
1631         Unreviewed build fix for GTKbuild after the switch to CMake
1632
1633         * gtk/common.py:
1634         (is_cmake_build): Like r165284, we need to assume CMake by default, since the
1635         test-only bot doesn't have any build files.
1636
1637 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1638
1639         [GTK] built-product-archive does not handle GTK+ CMake build
1640         https://bugs.webkit.org/show_bug.cgi?id=129941
1641
1642         * BuildSlaveSupport/built-product-archive:
1643         (archiveBuiltProduct): Fix the build by adding support to built-product-archive for
1644         the CMake build.
1645
1646 2014-03-07  Lorenzo Tilve  <ltilve@igalia.com>
1647
1648         [GTK] Include CMake into install-dependencies script
1649         https://bugs.webkit.org/show_bug.cgi?id=129909
1650
1651         Reviewed by Martin Robinson.
1652
1653         As since r165267 buid-webkit uses CMake by default, the dependency
1654         with 'cmake' package should be introduced.
1655
1656         * gtk/install-dependencies: Ditto.
1657
1658 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1659
1660         REGRESSION(165267): Broke a webkitpy unit tests
1661         https://bugs.webkit.org/show_bug.cgi?id=129904
1662
1663         Reviewed by Jon Honeycutt.
1664
1665         * Scripts/webkitpy/port/gtk.py: Flip the default test to assume CMake by default.
1666         (GtkPort._is_cmake_build):
1667
1668 2014-03-07  Andres Gomez  <agomez@igalia.com>
1669
1670         [GTK] webkit-patch setup-git-clone fails even after running Tools/gtk/install-dependencies
1671         https://bugs.webkit.org/show_bug.cgi?id=129893
1672
1673         Reviewed by Martin Robinson.
1674
1675         Added "git-svn" as dependency for deb based distros and,
1676         additionally, "subversion" for rpm based distros.
1677
1678         * gtk/install-dependencies:
1679
1680 2014-03-07  Roger Fong  <roger_fong@apple.com>
1681
1682         Remove dummy setSystemWebGLLoadPolicy client method.
1683         https://bugs.webkit.org/show_bug.cgi?id=129873.
1684
1685         Reviewed by Dean Jackson.
1686
1687         * WebKitTestRunner/TestController.cpp:
1688         (WTR::TestController::createWebViewWithOptions):
1689
1690 2014-03-07  Mark Hahnenberg  <mhahnenberg@apple.com>
1691
1692         run-jsc-stress-tests doesn't eagerly report test failures when using the shell runner
1693         https://bugs.webkit.org/show_bug.cgi?id=129886
1694
1695         Reviewed by Mark Lam.
1696
1697         * Scripts/jsc-stress-test-helpers/shell-runner.sh: Added a "verbose" mode to the shell runner.
1698         If we're in verbose mode, then we don't redirect any output when running each test. If we're not
1699         in verbose mode then we redirect stdout to /dev/null and allow any stderr output through.
1700         * Scripts/run-jsc-stress-tests: Redirect any sort of error output to stderr so that it will 
1701         make it through when in non-verbose mode.
1702
1703 2014-03-07  Martin Robinson  <mrobinson@igalia.com>
1704
1705         [GTK] buid-webkit should use CMake by default
1706         https://bugs.webkit.org/show_bug.cgi?id=129855
1707
1708         Reviewed by Carlos Garcia Campos.
1709
1710         Make the CMake build the default GTK+ build when using build-webkit. This will
1711         ensure that all bots are using CMake. We do this by swapping --gtk and --gtkcmake,
1712         so that we have --gtk and --gtkautotools.
1713
1714         * Scripts/webkitdirs.pm: Swap --gtkcmake/--gtk for --gtk/--gtkautotools.
1715         * Scripts/webkitpy/port/gtk.py: Ditto.
1716
1717 2014-03-06  Martin Robinson  <mrobinson@igalia.com>
1718
1719         [CMake] [GTK] Build with ninja when it is available
1720         https://bugs.webkit.org/show_bug.cgi?id=129805
1721
1722         Reviewed by Philippe Normand.
1723
1724         * Scripts/webkitdirs.pm:
1725         (canUseNinja): Added this helper which tries to execute Ninja, in an effort to determine
1726         if it's available on the system.
1727         (cmakeGeneratedBuildfile): Return the path to the generated build file. Only Unix support ATM.
1728         (generateBuildSystemFromCMakeProject): For GTK+ compile with Ninja when possible.
1729
1730 2014-03-06  Filip Pizlo  <fpizlo@apple.com>
1731
1732         If the FTL is build-time enabled then it should be run-time enabled.
1733
1734         Rubber stamped by Geoffrey Garen.
1735
1736         * Scripts/run-jsc-stress-tests:
1737
1738 2014-03-06  Mark Hahnenberg  <mhahnenberg@apple.com>
1739
1740         detectFailures in run-jsc-stress-tests can report everything was ok if too many tests fail
1741         https://bugs.webkit.org/show_bug.cgi?id=129837
1742
1743         Reviewed by Michael Saboff.
1744
1745         ls test_fail_* can fail if there are too many files that match. We then swallow that error, which makes everything seem ok.
1746         The fix is to use find instead of ls like we do in shell-runner.sh.
1747
1748         * Scripts/run-jsc-stress-tests:
1749
1750 2014-03-06  Joseph Pecoraro  <pecoraro@apple.com>
1751
1752         filter-build-webkit should not strip .o
1753         https://bugs.webkit.org/show_bug.cgi?id=129614
1754
1755         Reviewed by Dean Jackson.
1756
1757         This makes it much easier to jump from the failing output at
1758         the end back up to the compile errors earlier in the output.
1759
1760         * Scripts/filter-build-webkit:
1761
1762 2014-03-06  Anders Carlsson  <andersca@apple.com>
1763
1764         Build WebKit2 before building WebKit
1765         https://bugs.webkit.org/show_bug.cgi?id=129831
1766         <rdar://problem/15920020>
1767
1768         Reviewed by Dan Bernstein.
1769
1770         * Scripts/build-webkit:
1771         Always build WebKit2 and make sure to build it before WebKit when building on Mac.
1772
1773 2014-03-06  ChangSeok Oh  <changseok.oh@collabora.com>
1774
1775         make-3.82 fails to build on ARM/Linux
1776         https://bugs.webkit.org/show_bug.cgi?id=107926
1777
1778         Reviewed by Martin Robinson.
1779
1780         Some ARM/Linux systems don't support PAGE_SIZE macro so that it causes a build failure.
1781         The related bug reporting is here. https://lists.debian.org/debian-kernel/2014/02/msg00274.html
1782         To avoid this, I propose to use sysconf(_SC_PAGESIZE) instead of PAGE_SIZE
1783         where it is not defined. See more details, http://linux.die.net/man/2/getpagesize
1784
1785         * gtk/patches/make-3.82-arg-list-length.patch:
1786
1787 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1788
1789         [GTK] Close the page when the view is disposed instead of when finalized
1790         https://bugs.webkit.org/show_bug.cgi?id=129783
1791
1792         Reviewed by Sergio Villar Senin.
1793
1794         Add test case but disabled for now because it's affetected by bug #129684.
1795
1796         * TestWebKitAPI/Tests/WebKit2Gtk/TestMultiprocess.cpp:
1797         (testProcessPerWebView):
1798
1799 2014-03-06  Carlos Garcia Campos  <cgarcia@igalia.com>
1800
1801         [GTK] MiniBrowser crashes when opening several urls passed as command line options
1802         https://bugs.webkit.org/show_bug.cgi?id=129738
1803
1804         Reviewed by Sergio Villar Senin.
1805
1806         The problem is that we are calling g_object_unref() for the
1807         WebKitWebSettings everytime we set it to a WebKitWebView, but the
1808         view only increases the reference counter when the settings is not
1809         the same it currently has. We should release our reference once.
1810
1811         * MiniBrowser/gtk/main.c:
1812         (createBrowserWindow):
1813         (main):
1814
1815 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1816
1817         [GTK][CMake] Tarball is created with wrong tarball paths
1818         https://bugs.webkit.org/show_bug.cgi?id=129496
1819
1820         Reviewed by Daniel Bates.
1821
1822         * gtk/make-dist.py:
1823         (Manifest.__init__): I inadvertently inverted the logic of these checks when
1824         landing the original patch with some suggestions from the reviewer. With the
1825         checks corrected, the tarball path is constructed properly.
1826
1827 2014-03-05  Jae Hyun Park  <jaepark@webkit.org>
1828
1829         Unreviewed. Update my email in contributors.json
1830
1831         * Scripts/webkitpy/common/config/contributors.json:
1832
1833 2014-03-05  Dean Jackson  <dino@apple.com>
1834
1835         [WebGL] Use WKSI to see what the system policy for WebGL is
1836         https://bugs.webkit.org/show_bug.cgi?id=129722
1837         <rdar://problem/15790542>
1838
1839         Reviewed by Tim Horton.
1840
1841         Dummy entry for setSystemWebGLLoadPolicy.
1842
1843         * WebKitTestRunner/TestController.cpp:
1844         (WTR::TestController::createWebViewWithOptions):
1845
1846 2014-03-03  Martin Robinson  <mrobinson@igalia.com>
1847
1848         [GTK][CMake] Generate documentation for the DOM bindings
1849         https://bugs.webkit.org/show_bug.cgi?id=126211
1850
1851         Reviewed by Carlos Garcia Campos.
1852
1853         * gtk/GNUmakefile.am: No longer generation sections and SGML files in the makefile.
1854         * gtk/generate-gtkdoc: Call the code from webkitdom.py to generate sections and SGML files.
1855         * gtk/generate-webkitdom-doc-files: Removed.
1856         * gtk/webkitdom.py: Moved WebKit GObject DOM bindings doc generation code here, so
1857         that it can be called by generate-gtkdoc.
1858
1859 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1860
1861         [GTK][CMake] build-webkit should rerun cmake if the Makefile is missing
1862         https://bugs.webkit.org/show_bug.cgi?id=129380
1863
1864         Reviewed by Philippe Normand.
1865
1866         * Scripts/webkitdirs.pm:
1867         (generateBuildSystemFromCMakeProject): Check for the existence of the Makefile before
1868         skipping CMake execution.
1869
1870 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1871
1872         [GTK] The jhbuild environment should have the latest stable release of gtk-doc
1873         https://bugs.webkit.org/show_bug.cgi?id=129651
1874
1875         Reviewed by Philippe Normand.
1876
1877         * gtk/jhbuild.modules: Add gtk-doc to the list of modules.
1878
1879 2014-03-05  Martin Robinson  <mrobinson@igalia.com>
1880
1881         [GTK] Give the WebKit GObject DOM bindings API break detection it's own buildbot bubble
1882         https://bugs.webkit.org/show_bug.cgi?id=129637
1883
1884         Reviewed by Carlos Garcia Campos.
1885
1886         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1887         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests): Added this test runner.
1888         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.commandComplete): Run the breakage test command and scan the output.
1889         (RunGtkWebKitGObjectDOMBindingsAPIBreakTests.evaluateCommand): Return failure if there is missing API (an API break).
1890         New API typically just requires a rebaseline and isn't necessarily a faiulre.
1891         (TestFactory.__init__): Add the test for GTK+.
1892         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Add a unit test for the new bubble.
1893
1894 2014-03-05  Krzysztof Czech  <k.czech@samsung.com>
1895
1896         [ATK] Expose missing functionalities of AtkTableCell to AT
1897         https://bugs.webkit.org/show_bug.cgi?id=129492
1898
1899         Reviewed by Mario Sanchez Prada.
1900
1901         Reducing some code by using new API of AtkTableCell.
1902
1903         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
1904         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1905
1906 2014-03-04  Alex Christensen  <achristensen@webkit.org>
1907
1908         Preparing to run layout tests on Wincairo.
1909         https://bugs.webkit.org/show_bug.cgi?id=129709
1910
1911         Reviewed by Brent Fulgham.
1912
1913         * Scripts/webkitdirs.pm:
1914         (setPathForRunningWebKitApp):
1915         Add GStreamer directory for WinCairo running layout tests.
1916         * win/DLLLauncher/DLLLauncherMain.cpp:
1917         (modifyPath):
1918         Added the WinCairo bin32 or bin64 directory for running WinLauncher.
1919
1920 2014-03-04  Martin Robinson  <mrobinson@igalia.com>
1921
1922         [GTK] Simplify the GObject DOM bindings API break check into one step
1923         https://bugs.webkit.org/show_bug.cgi?id=129571
1924
1925         Reviewed by Carlos Garcia Campos.
1926
1927         * GNUmakefile.am: Add the API break check to 'make check.'
1928         * gtk/check-for-webkitdom-api-breaks: Added. A combination of the two removed scripts.
1929         * gtk/check-gdom-symbols: Removed.
1930         * gtk/webkitdom.py: Added.
1931         (header_name_list_from_gtkdoc_config_file): Gets the names of all headers from the gtkdoc config file.
1932         (get_all_webkitdom_symbol_files): Find the symbol files from the names.
1933
1934 2014-03-03  Simon Fraser  <simon.fraser@apple.com>
1935
1936         Add Jeremy Jones to the contributors list as a contributor.
1937
1938         * Scripts/webkitpy/common/config/contributors.json:
1939
1940 2014-03-03  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1941
1942         Unreviewed. Update contact email.
1943         https://bugs.webkit.org/show_bug.cgi?id=129610
1944
1945         * Scripts/webkitpy/common/config/contributors.json:
1946
1947 2014-03-02  Brian Burg  <bburg@apple.com>
1948
1949         Web Inspector model tests load wrong inspector page under WebKitTestRunner
1950         https://bugs.webkit.org/show_bug.cgi?id=129460
1951
1952         Reviewed by Dan Bernstein.
1953
1954         Don't unconditionally open the inspector before running an inspector test.
1955         Instead, the test should request that the inspector open when it's ready.
1956
1957         This change was lost during a rebase, but is the same change made to
1958         DumpRenderTree.
1959
1960         * WebKitTestRunner/TestInvocation.cpp:
1961         (WTR::TestInvocation::invoke): 
1962
1963 2014-03-02  Darin Adler  <darin@apple.com>
1964
1965         Split TextIteratorBehavior into a separate header
1966         https://bugs.webkit.org/show_bug.cgi?id=129578
1967
1968         Reviewed by Sam Weinig.
1969
1970         * Scripts/sort-export-file: Added special cases to the script so you can just paste link errors
1971         from WebKit in and the script will add them in as unconditional exports. This makes the "add"
1972         task easy, but the remove is still a bit of a pain.
1973
1974 2014-03-02  Darin Adler  <darin@apple.com>
1975
1976         Sort Mac platform export files so they merge better
1977         https://bugs.webkit.org/show_bug.cgi?id=129581
1978
1979         Reviewed by Sam Weinig.
1980
1981         * Scripts/sort-export-file: Added. Quickly whipped together script that sorts
1982         Mac export files in a "canonical" order for this project.
1983
1984 2014-02-28  Zalan Bujtas  <zalan@apple.com>
1985
1986         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
1987         https://bugs.webkit.org/show_bug.cgi?id=129438
1988
1989         Reviewed by Simon Fraser.
1990
1991         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
1992         offscreen window. It makes testing subpixel rendering and positioning possible.
1993
1994         Both the offscreen window's and WebKit's scaling are set accordingly.
1995
1996         * DumpRenderTree/mac/DumpRenderTree.mm:
1997         (createWebViewAndOffscreenWindow): cleanup
1998         (destroyWebViewAndOffscreenWindow): cleanup
1999         (dumpRenderTree):
2000         (changeWindowScaleIfNeeded):
2001         (runTest):
2002         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2003         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2004         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup
2005         * WebKitTestRunner/PlatformWebView.h:
2006         * WebKitTestRunner/TestInvocation.cpp:
2007         (WTR::changeWindowScaleIfNeeded):
2008         (WTR::TestInvocation::invoke):
2009         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2010         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2011         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2012         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2013         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2014         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2015         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2016         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
2017
2018 2014-02-28  Anders Carlsson  <andersca@apple.com>
2019
2020         Remove logging.
2021
2022         Reviewed by Dan Bernstein.
2023
2024         * MiniBrowser/mac/WK2BrowserWindowController.m:
2025         (-[WK2BrowserWindowController browsingContextController:decidePolicyForNavigationAction:decisionHandler:]):
2026
2027 2014-02-28  Daniel Bates  <dabates@apple.com>
2028
2029         [iOS] DumpRenderTree Perl Support may build against wrong SDK and toolchain
2030         https://bugs.webkit.org/show_bug.cgi?id=129163
2031
2032         Reviewed by David Kilzer.
2033
2034         Fixes an issue where DumpRenderTree Perl Support may build with the specified
2035         iOS Simulator SDK and toolchain instead of using the OS X SDK and toolchain.
2036         This issue manifests itself in a build failure when building the IPhoneSimulatorNotification
2037         bundle.
2038
2039         Currently we build DumpRenderTree Perl Support with respect to the variable SDKROOT,
2040         which is specified either explicitly when building with MAKE(1) or implicitly by
2041         build-{dumprendertree, webkit}. Instead we should always build Perl Support using
2042         the OS X SDK and toolchain since the built products are only applicable to OS X.
2043
2044         * DumpRenderTree/ios/PerlSupport/Makefile:
2045
2046 2014-02-28  Commit Queue  <commit-queue@webkit.org>
2047
2048         Unreviewed, rolling out r164859.
2049         http://trac.webkit.org/changeset/164859
2050         https://bugs.webkit.org/show_bug.cgi?id=129483
2051
2052         caused WK1 crashes (DumpRenderTree) (Requested by zalan on
2053         #webkit).
2054
2055         * DumpRenderTree/mac/DumpRenderTree.mm:
2056         (createWebViewAndOffscreenWindow):
2057         (dumpRenderTree):
2058         (runTest):
2059         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2060         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2061         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
2062         * WebKitTestRunner/PlatformWebView.h:
2063         * WebKitTestRunner/TestInvocation.cpp:
2064         (WTR::TestInvocation::invoke):
2065         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
2066         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
2067         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2068         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2069         (-[WebKitTestRunnerWindow frameRespectingFakeOrigin]):
2070
2071 2014-02-28  Zalan Bujtas  <zalan@apple.com>
2072
2073         Add hiDPI support to DumpRenderTree/WebKitTestRunner without the need of reloading the test case.
2074         https://bugs.webkit.org/show_bug.cgi?id=129438
2075
2076         Reviewed by Simon Fraser.
2077
2078         'hidpi-' prefixed test cases now trigger 2x scale factor on the testing
2079         offscreen window. It makes testing subpixel rendering and positioning possible.
2080
2081         Both the offscreen window's and WebKit's scaling are set accordingly.
2082
2083         * DumpRenderTree/mac/DumpRenderTree.mm:
2084         (createWebViewAndOffscreenWindow): unrelated cleanup.
2085         (destroyWebViewAndOffscreenWindow): unrelated cleanup.
2086         (dumpRenderTree):
2087         (changeOffscreenWindowScaleIfNeeded):
2088         (runTest):
2089         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
2090         * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
2091         (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]): cleanup.
2092         * WebKitTestRunner/PlatformWebView.h:
2093         * WebKitTestRunner/TestInvocation.cpp:
2094         (WTR::changeOffscreenWindowScaleIfNeeded):
2095         (WTR::TestInvocation::invoke):
2096         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2097         (WTR::PlatformWebView::changeOffscreenWindowScaleIfNeeded):
2098
2099 2014-02-27  Brian Burg  <bburg@apple.com>
2100
2101         Web Inspector: model tests should use a special Test.html inspector page
2102         https://bugs.webkit.org/show_bug.cgi?id=129190
2103
2104         Reviewed by Timothy Hatcher.
2105
2106         Remove code that immediately opens the Web Inspector based on the file path of the test.
2107         Instead, the test page should request that the inspector open inside its `test()` method.
2108
2109         This change is necessary because otherwise, the inspector would be opened too early for
2110         InspectorController::isUnderTest to get set in time, so the normal Web Inspector page
2111         will get loaded instead of the minimal test page.
2112
2113         * DumpRenderTree/efl/DumpRenderTree.cpp:
2114         (createTestRunner):
2115         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2116         (runTest):
2117         * DumpRenderTree/mac/DumpRenderTree.mm:
2118         (runTest):
2119         * DumpRenderTree/win/DumpRenderTree.cpp:
2120         (runTest):
2121
2122 2014-02-27  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2123
2124         check-webkit-style indentation false alarm in WebKit/win/WebNodeHighlight.cpp
2125         https://bugs.webkit.org/show_bug.cgi?id=127076
2126
2127         Reviewed by Anders Carlsson.
2128
2129         Avoid match for :: as start of a member initialization list. Modify expression to match
2130         after a colon either non-colon character or end of line.
2131
2132         * Scripts/webkitpy/style/checkers/cpp.py:
2133         (check_member_initialization_list):
2134         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2135         (WebKitStyleTest.test_member_initialization_list):
2136
2137 2014-02-27  Renata Hodovan  <rhodovan.u-szeged@partner.samsung.com>
2138
2139         Unreviewed. Update my email addresses in contributors.json.
2140
2141         * Scripts/webkitpy/common/config/contributors.json:
2142
2143 2014-02-27  Alberto Garcia  <berto@igalia.com>
2144
2145         [gtk-doc] UnicodeEncodeError: 'ascii' codec can't encode character
2146         https://bugs.webkit.org/show_bug.cgi?id=128927
2147
2148         Reviewed by Philippe Normand.
2149
2150         Encode manually the data for sys.{stdout,stderr}.write.
2151
2152         * gtk/gtkdoc.py:
2153         (GTKDoc._run_command):
2154
2155 2014-02-27  Andres Gomez  <agomez@igalia.com>
2156
2157         Unreviewed. Add myself to watchlists
2158
2159         * Scripts/webkitpy/common/config/watchlist: Add myself to
2160         watchlists.
2161
2162 2014-02-27  Andres Gomez  <agomez@igalia.com>
2163
2164         Unreviewed, rolling out r164790.
2165         http://trac.webkit.org/changeset/164790
2166
2167         Revert r164790 because of erroneous commit log
2168
2169         * Scripts/webkitpy/common/config/watchlist:
2170
2171 2014-02-27  Krzysztof Czech  <k.czech@samsung.com>
2172
2173         [ATK] Utilize AtkTableCell to expose directly AccessibilityTableCell to AT
2174         https://bugs.webkit.org/show_bug.cgi?id=129250
2175
2176         Reviewed by Mario Sanchez Prada.
2177
2178         Changing version of ATK to 2.11.90, because it introduces AtkTableCell interface.
2179         Implementing methods so that we could test column/row headers represented as an array of cells.
2180
2181         * DumpRenderTree/AccessibilityUIElement.cpp:
2182         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2183         (AccessibilityUIElement::columnHeaders):
2184         (AccessibilityUIElement::rowHeaders):
2185         * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Adding empty stubs, to not break compilation.
2186         (AccessibilityUIElement::columnHeaders):
2187         (AccessibilityUIElement::rowHeaders):
2188         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2189         (WTR::AccessibilityUIElement::rowHeaders):
2190         (WTR::AccessibilityUIElement::columnHeaders):
2191         * efl/jhbuild.modules:
2192         * gtk/jhbuild.modules:
2193
2194 2014-02-27  Andres Gomez  <agomez@igalia.com>
2195
2196         Unreviewed. Add myself to watchlists
2197
2198         * Scripts/webkitpy/common/config/watchlist: Add myself to
2199         watchlists.
2200
2201 2014-02-27  Andres Gomez  <agomez@igalia.com>
2202
2203         Unreviewed. Add myself as a committer.
2204
2205         * Scripts/webkitpy/common/config/contributors.json:
2206
2207 2014-02-27  Xabier Rodriguez Calvar  <calvaris@igalia.com>
2208
2209         Unreviewed. Add Víctor Jáquez and myself to watchlists
2210
2211         * Scripts/webkitpy/common/config/watchlist: Add Víctor Jáquez and
2212         myself to watchlists.
2213
2214 2014-02-26  Julien Brianceau  <jbriance@cisco.com>
2215
2216         Unreviewed. Add myself as a committer.
2217
2218         * Scripts/webkitpy/common/config/contributors.json:
2219
2220 2014-02-26  Laszlo Vidacs  <lvidacs.u-szeged@partner.samsung.com>
2221
2222         Unreviewed. Moved myself to the list of committers.
2223
2224         * Scripts/webkitpy/common/config/contributors.json:
2225
2226 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2227
2228         [GTK] Reduplicate common.top_level_path in scripts
2229         https://bugs.webkit.org/show_bug.cgi?id=129291
2230
2231         Reviewed by Philippe Normand.
2232
2233         Duplicate common.top_level_path and avoid polluting many scripts with awkward system
2234         path manipulation and weird dependencies on the jhbuild infrastructure.
2235
2236         * Scripts/run-gtk-tests: Use common again.
2237         (TestRunner._setup_testing_environment): Ditto.
2238         * gtk/check-gdom-symbols: Ditto.
2239         * gtk/common.py:
2240         (top_level_path): Re-add top_level_path..
2241         (get_build_path): Use the builtin top_level_path again.
2242         * gtk/find-make-dist-errors: Use common again.
2243         (get_missing_headers): Ditto.
2244         * gtk/generate-inspector-gresource-manifest.py: Ditto.
2245
2246 2014-02-26  Mark Hahnenberg  <mhahnenberg@apple.com>
2247
2248         runscript: line 42: /bin/ls: Argument list too long
2249         https://bugs.webkit.org/show_bug.cgi?id=129376
2250
2251         Reviewed by Michael Saboff.
2252
2253         The "test_script_*" can expand to more things than can be passed as arguments on the command line. 
2254         We should use find instead, which generates the list of files rather than expanding them all on 
2255         the command line and spitting them back out.
2256
2257         * Scripts/jsc-stress-test-helpers/shell-runner.sh: 
2258
2259 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2260
2261         ENABLE_PROMISES is improperly specified as ENABLE_PROMISE in Features.pm
2262         https://bugs.webkit.org/show_bug.cgi?id=129377
2263
2264         Reviewed by Csaba Osztrogonác.
2265
2266         * Scripts/webkitperl/FeatureList.pm: Properly specify the promises feature as ENABLE_PROMISES.
2267
2268 2014-02-26  Manuel Rego Casasnovas  <rego@igalia.com>
2269
2270         [GTK] Re-enable gtk-doc in EWS
2271         https://bugs.webkit.org/show_bug.cgi?id=128369
2272
2273         Reviewed by Carlos Garcia Campos.
2274
2275         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2276
2277         * Scripts/webkitpy/common/config/ports.py:
2278         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2279         (GtkWK2Port.build_webkit_command): Ditto.
2280         * Scripts/webkitpy/common/config/ports_unittest.py:
2281         (DeprecatedPortTest.test_gtk_port): Ditto.
2282         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2283
2284 2014-02-26  Martin Robinson  <mrobinson@igalia.com>
2285
2286         [GTK] generate-gtkdoc can fail with WebKit1 or WebKit2 only builds
2287         https://bugs.webkit.org/show_bug.cgi?id=129319
2288
2289         Reviewed by Carlos Garcia Campos.
2290
2291         * gtk/generate-gtkdoc:
2292         (get_generator_for_config): Properly handle the situation where the pkgconfig file is missing.
2293
2294 2014-02-25  Mihai Maerean  <mmaerean@adobe.com>
2295
2296         Unreviewed. Add myself as a committer.
2297
2298         * Scripts/webkitpy/common/config/contributors.json:
2299
2300 2014-02-25  Sergio Villar Senin  <svillar@igalia.com>
2301
2302         [CSS Grid Layout] Add ENABLE flag
2303         https://bugs.webkit.org/show_bug.cgi?id=129153
2304
2305         Reviewed by Simon Fraser.
2306
2307         Added ENABLE_CSS_GRID_LAYOUT feature flag. It's on by default for
2308         all ports for developer builds.
2309
2310         * Scripts/webkitperl/FeatureList.pm:
2311
2312 2014-02-25  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2313
2314         Added myself as a committer.
2315
2316         Unreviewed.
2317
2318         * Scripts/webkitpy/common/config/contributors.json:
2319
2320 2014-02-25  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
2321
2322         Unreviewed. Moved myself to the list of committers.
2323
2324         * Scripts/webkitpy/common/config/contributors.json:
2325
2326 2014-02-25  Peter Molnar  <pmolnar.u-szeged@partner.samsung.com>
2327
2328         Move myself to the committers list.
2329
2330         Unreviewed.
2331
2332         * Scripts/webkitpy/common/config/contributors.json:
2333
2334 2014-02-25  László Langó  <llango.u-szeged@partner.samsung.com>
2335
2336         Unreviewed. Add myself as a committer.
2337
2338         * Scripts/webkitpy/common/config/contributors.json:
2339
2340 2014-02-25  Commit Queue  <commit-queue@webkit.org>
2341
2342         Unreviewed, rolling out r164639.
2343         http://trac.webkit.org/changeset/164639
2344         https://bugs.webkit.org/show_bug.cgi?id=129302
2345
2346         gtk-doc still have problems in EWS (Requested by rego on
2347         #webkit).
2348
2349         * Scripts/webkitpy/common/config/ports.py:
2350         (GtkPort.build_webkit_command):
2351         (GtkWK2Port.build_webkit_command):
2352         * Scripts/webkitpy/common/config/ports_unittest.py:
2353         (DeprecatedPortTest.test_gtk_port):
2354         (DeprecatedPortTest.test_gtk_wk2_port):
2355
2356 2014-02-25  Manuel Rego Casasnovas  <rego@igalia.com>
2357
2358         [GTK] Re-enable gtk-doc in EWS
2359         https://bugs.webkit.org/show_bug.cgi?id=128369
2360
2361         Reviewed by Carlos Garcia Campos.
2362
2363         Enable again gtk-doc generation in EWS once bug #128417 has been fixed.
2364
2365         * Scripts/webkitpy/common/config/ports.py:
2366         (GtkPort.build_webkit_command): Add --disable-gtk-doc arg.
2367         (GtkWK2Port.build_webkit_command): Ditto.
2368         * Scripts/webkitpy/common/config/ports_unittest.py:
2369         (DeprecatedPortTest.test_gtk_port): Ditto.
2370         (DeprecatedPortTest.test_gtk_wk2_port): Ditto.
2371
2372 2014-02-24  Carlos Garcia Campos  <cgarcia@igalia.com>
2373
2374         [GTK] Mark view source mode methods as deprecated
2375         https://bugs.webkit.org/show_bug.cgi?id=128920
2376
2377         Reviewed by Martin Robinson.
2378
2379         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2380         (beforeAll): Remove view mode test.
2381
2382 2014-02-24  Martin Robinson  <mrobinson@igalia.com>
2383
2384         [GTK] generate-gtkdoc should not generate documentation for source files for unbuilt source files
2385         https://bugs.webkit.org/show_bug.cgi?id=128417
2386
2387         Reviewed by Carlos Garcia Campos.
2388
2389         * gtk/GNUmakefile.am: Make the documentation process depend on the configuration files.
2390         * gtk/generate-gtkdoc: Switch from using hard-coded configurations to reading them from
2391         a makefile. This allows accepting a header list from the build system, which can be used
2392         to dynamically build a list of ignored files. We can ignore any source file that doesn't
2393         have a corresponding header file on the header list. 
2394         * gtk/gtkdoc.py: Now accept a headers parameter, which can be used instead of passing just
2395         source directories to gtkdoc-scan.
2396
2397 2014-02-24  Anders Carlsson  <andersca@apple.com>
2398
2399         Add a DefaultVisitedLinkProvider and route visited link actions through it
2400         https://bugs.webkit.org/show_bug.cgi?id=129285
2401
2402         Reviewed by Dan Bernstein.
2403
2404         * MiniBrowser/mac/AppDelegate.m:
2405         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2406         Set a shared history so we'll get visited link tracking.
2407
2408         * MiniBrowser/mac/WK1BrowserWindowController.m:
2409         (-[WK1BrowserWindowController awakeFromNib]):
2410         Set a group name.
2411
2412 2014-02-24  Dan Bernstein  <mitz@apple.com>
2413
2414         iOS build fix after r164577.
2415
2416         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2417         (AccessibilityUIElement::selectedChildrenCount):
2418         (AccessibilityUIElement::selectedChildAtIndex):
2419
2420 2014-02-24  David Kilzer  <ddkilzer@apple.com>
2421
2422         [ASan] Remove methods from ignore list that no longer cause crashes
2423         <http://webkit.org/b/129257>
2424
2425         Reviewed by Anders Carlsson.
2426
2427         * asan/webkit-asan-ignore.txt: Remove old methods.
2428
2429 2014-02-24  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
2430
2431         Extract common parts from jhbuildrc files.
2432         https://bugs.webkit.org/show_bug.cgi?id=125986
2433
2434         Reviewed by Csaba Osztrogonác.
2435
2436         Co-authored with Peter Szanka <h868064@stud.u-szeged.hu>.
2437
2438         * Scripts/run-gtk-tests:
2439         (TestRunner._setup_testing_environment):
2440         * efl/common.py: Removed.
2441         * efl/jhbuildrc:
2442         * gtk/check-gdom-symbols:
2443         * gtk/common.py:
2444         (binary_build_path):
2445         (get_build_path):
2446         * gtk/find-make-dist-errors:
2447         (get_missing_headers):
2448         * gtk/generate-gtkdoc:
2449         (get_webkit2_options):
2450         (get_webkit1_options.src_path):
2451         (get_webkit1_options):
2452         (get_webkitdom_options.src_path):
2453         (get_webkitdom_options):
2454         * gtk/generate-inspector-gresource-manifest.py:
2455         * gtk/jhbuildrc:
2456         * jhbuild/jhbuildrc_common.py: Added.
2457         (script_path):
2458         (top_level_path):
2459         (init):
2460
2461 2014-02-24  Diego Pino Garcia  <dpino@igalia.com>
2462
2463         Unreviewed. Fix code indentation and spacing.
2464
2465         * Scripts/webkitpy/style/checkers/js.py:
2466         (SingleQuoteChecker.check):
2467
2468 2014-02-24  Krzysztof Czech  <k.czech@samsung.com>
2469
2470         [ATK] Wrong selected element at a given index in a list box.
2471         https://bugs.webkit.org/show_bug.cgi?id=129039
2472
2473         Reviewed by Chris Fleizach.
2474
2475         Added missing implementation and proposed some new function for testing selection
2476         in a list boxes.
2477
2478         * DumpRenderTree/AccessibilityUIElement.cpp:
2479         (setSelectedChildAtIndexCallback):
2480         (removeSelectionAtIndexCallback):
2481         (AccessibilityUIElement::getJSClass):
2482         * DumpRenderTree/AccessibilityUIElement.h:
2483         * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
2484         (AccessibilityUIElement::selectedChildrenCount):
2485         (AccessibilityUIElement::selectedChildAtIndex):
2486         (AccessibilityUIElement::setSelectedChildAtIndex):
2487         (AccessibilityUIElement::removeSelectionAtIndex):
2488         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
2489         (AccessibilityUIElement::selectedChildrenCount):
2490         (AccessibilityUIElement::selectedChildAtIndex):
2491         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
2492         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2493         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2494         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
2495         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2496         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2497         (WTR::AccessibilityUIElement::selectedChildAtIndex):
2498         (WTR::AccessibilityUIElement::selectedChildrenCount):
2499         (WTR::AccessibilityUIElement::setSelectedChildAtIndex):
2500         (WTR::AccessibilityUIElement::removeSelectionAtIndex):
2501
2502 2014-02-23  Diego Pino García  <dpino@igalia.com>
2503
2504         [GTK] Fix build after Web Inspector code reorganization (r164543)
2505         https://bugs.webkit.org/show_bug.cgi?id=129231
2506
2507         Reviewed by Dean Jackson.
2508
2509         * gtk/generate-inspector-gresource-manifest.py:
2510         Modify paths to Web Inspector code.
2511
2512 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2513
2514         [GTK] generate-gtkdoc should use argparse
2515         https://bugs.webkit.org/show_bug.cgi?id=128418
2516
2517         Reviewed by Carlos Garcia Campos.
2518
2519         * gtk/generate-gtkdoc: Get all arguments from argparse, pass then as parameters
2520         to all functions, and guard the main routine with a __name__ == __main__ check.
2521
2522 2014-02-23  Martin Robinson  <mrobinson@igalia.com>
2523
2524         [GTK][CMake] Many plugin tests fail when running WebKit1 layout tests
2525         https://bugs.webkit.org/show_bug.cgi?id=129191
2526
2527         Reviewed by Anders Carlsson.
2528
2529         * DumpRenderTree/PlatformGTK.cmake: Properly specify the library build directory
2530         for the GTK+ DumpRenderTree build. We could manually construct this path, but the
2531         name of the directory is "lib" and not "libs". Instead we should use the CMake
2532         variable specifically assigned to this task.
2533
2534 2014-02-23  David Kilzer  <ddkilzer@apple.com>
2535
2536         [ASan] Add JSC::DFG::prepareOSREntry() to ignore list
2537         <http://webkit.org/b/129209>
2538
2539         Reviewed by Geoffrey Garen.
2540
2541         * asan/webkit-asan-ignore.txt: Add DFG::prepareOSREntry() to the
2542         ignore list to make ASan builds usable again.  Follow-up
2543         investigation is tracked by <rdar://problem/16055903>.
2544
2545 2014-02-20  David Farler  <dfarler@apple.com>
2546
2547         Make old-run-webkit-tests work with iOS Simulator WebKitTestRunner
2548         https://bugs.webkit.org/show_bug.cgi?id=128622
2549
2550         Reviewed by Simon Fraser.
2551
2552         With this change, we now have layout tests running in both DumpRenderTree
2553         and WebKitTestRunner, with WebKit and WebKit2 used respectively in the iOS
2554         simulator.
2555
2556         * Scripts/old-run-webkit-tests:
2557         In general, make any specific reference to DumpRenderTree
2558         able to refer to WebKitTestRunner wherever possible:
2559         - Rename functions to remove DRT-specific naming.
2560         - Name FIFOs after the tool that is being used.
2561         -- Clean up FIFO creation code
2562         Other necessary changes:
2563         - Allow use of an ios-sim-wk2 platform.
2564         - Clean up platform hierarchy creation where the simulator platform behavior differed.
2565         * WebKitTestRunner/TestController.cpp:
2566         Open FIFOs to get dumps out of the simulator as we do in DumpRenderTree.
2567         (WTR::TestController::TestController):
2568         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2569         Copy the injected bundle into the app bundle.
2570
2571 2014-02-21  Joseph Pecoraro  <pecoraro@apple.com>
2572
2573         run-webkit-httpd fails to find httpd configuation file.
2574
2575         Reviewed by Ryosuke Niwa.
2576
2577         * Scripts/webkitperl/httpd.pm:
2578         (getHTTPDConfigPathForTestDirectory):
2579
2580 2014-02-21  Eric Carlson  <eric.carlson@apple.com>
2581
2582         Fix TimeRanges layering violations
2583         https://bugs.webkit.org/show_bug.cgi?id=128717
2584
2585         Reviewed by Jer Noble.
2586
2587         * TestWebKitAPI/Tests/WebCore/TimeRanges.cpp: TimeRanges* -> TimeRanges&.
2588         (TestWebKitAPI::TEST):
2589
2590 2014-02-21  Diego Pino García  <dpino@igalia.com>
2591
2592         Web Inspector: update check-webkit-style to flag single quotes in WebInspectorUI projects
2593         https://bugs.webkit.org/show_bug.cgi?id=128422
2594
2595         Reviewed by Joseph Pecoraro.
2596
2597         * Scripts/webkitpy/style/checkers/js.py:
2598         (JSChecker.__init__):
2599         (JSChecker.check):
2600         (SingleQuoteChecker):
2601         (SingleQuoteChecker.__init__):
2602         (SingleQuoteChecker.check):
2603         * Scripts/webkitpy/style/checkers/js_unittest.py:
2604         (JSTestCase.assertError.error_for_test):
2605         (JSTestCase.assertError):
2606         (JSTestCase.test_no_error):
2607         (JSTestCase.test_error):
2608
2609 == Rolled over to ChangeLog-2014-02-20 ==