Tools/ChangeLog

   1 2015-06-25  Alex Christensen  <achristensen@webkit.org>
   2
   3         [Content Extensions] Add a way to match a domain but not subdomains
   4         https://bugs.webkit.org/show_bug.cgi?id=146241
   5         rdar://problem/21557754
   6
   7         Reviewed by Darin Adler.
   8
   9         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
  10         (TestWebKitAPI::TEST_F):
  11         Update subdomain test because of changed behavior and add test for new '*' functionality.
  12
  13 2015-06-25  Jaehun Lim  <ljaehun.lim@samsung.com>
  14
  15         Cleanup ENABLE_CSS3_CONDITIONAL_RULES codes.
  16         https://bugs.webkit.org/show_bug.cgi?id=146308
  17
  18         Reviewed by Csaba Osztrogonác.
  19
  20         ENABLE_CSS3_CONDITIONAL_RULES guard was removed from r174536.
  21
  22         * Scripts/webkitperl/FeatureList.pm:
  23
  24 2015-06-25  Carlos Garcia Campos  <cgarcia@igalia.com>
  25
  26         [GTK] Add initial WebKitWebsiteDataManager API for process configuration options
  27         https://bugs.webkit.org/show_bug.cgi?id=146149
  28
  29         Reviewed by Sergio Villar Senin.
  30
  31         Update unit tests to use WebKitWebsiteDataManager.
  32
  33         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
  34         (testWebContextConfiguration):
  35         (serverCallback):
  36         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
  37         (Test::Test): Use WebKitWebsiteDataManager and set all possible
  38         values to ensure unit tests don't write outside the temporary directory.
  39         (Test::~Test): Explicitly reset the web context to ensure its
  40         objects are released before the leaks check.
  41         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
  42         (WebViewTest::wait): Fix the GSource used, since we are receiving
  43         a double in seconds, but using g_timeout_add_seconds() that
  44         expects an unsigned in seconds. Use GMainLoopSource to correctly
  45         handle the value and simplify the code.
  46
  47 2015-06-24  Jason Marcell  <jmarcell@apple.com>
  48
  49         Work towards: Add status of Safari projects on iOS Dashboard on build-safari
  50         https://bugs.webkit.org/show_bug.cgi?id=146126
  51         <rdar://problem/18226291>
  52
  53         Reviewed by Alexey Proskuryakov.
  54
  55         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
  56         (documentReady): Using combined queues to display iOS projects
  57
  58 2015-06-24  Doug Russell  <d_russell@apple.com>
  59
  60         Bug 146177 - AX: AXObjectCache should try to use an unignored accessibilityObject
  61         when posting a selection notification when on the border between two accessibilityObjects
  62         https://bugs.webkit.org/show_bug.cgi?id=146177
  63
  64         Reviewed by Darin Adler.
  65
  66         Add support for mapping WebCore Accessibility types into JSValueRef types
  67         so they can be used in tests.
  68
  69         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm:
  70         (webAccessibilityObjectWrapperClass):
  71         (-[AccessibilityNotificationHandler startObserving]):
  72         (makeValueRefForValue):
  73         (makeArrayRefForArray):
  74         (makeObjectRefForDictionary):
  75         (-[AccessibilityNotificationHandler _notificationReceived:]):
  76         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm:
  77         (webAccessibilityObjectWrapperClass):
  78         (-[AccessibilityNotificationHandler startObserving]):
  79         (makeValueRefForValue):
  80         (makeArrayRefForArray):
  81         (makeObjectRefForDictionary):
  82         (-[AccessibilityNotificationHandler _notificationReceived:]):
  83
  84 2015-06-24  Zalan Bujtas  <zalan@apple.com>
  85
  86         Subpixel rendering: roundToDevicePixel() snaps to wrong value.
  87         https://bugs.webkit.org/show_bug.cgi?id=146273
  88         rdar://problem/18509840
  89
  90         Reviewed by Simon Fraser.
  91
  92         Due to the floating point approximate representation, we can't always produce
  93         the correct snap value. This patch addresses the issue by removing redundant kFixedPointDenominator multiplication
  94         and by changing the rounding in roundToDevicePixel() from float to double.
  95
  96         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
  97         (TestWebKitAPI::TEST):
  98
  99 2015-06-24  Brady Eidson  <beidson@apple.com>
 100
 101         Update JavaScript dialog delegates to include a WKSecurityOriginRef argument.
 102         <rdar://problem/21269187> and https://bugs.webkit.org/show_bug.cgi?id=146249
 103
 104         Reviewed by Alex Christensen.
 105
 106         - Update WKTR to the new client structure.
 107         - Update existing TestWebKitAPI tests to either use the new client structure or
 108           assign the old function signature to the updated variable name.
 109         - Include a new test.
 110
 111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 112
 113         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
 114         (TestWebKitAPI::runJavaScriptAlert):
 115
 116         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
 117         (TestWebKitAPI::TEST):
 118
 119         * TestWebKitAPI/Tests/WebKit2/ModalAlertsSPI.cpp:
 120         (TestWebKitAPI::analyzeDialogArguments):
 121         (TestWebKitAPI::runJavaScriptAlert):
 122         (TestWebKitAPI::runJavaScriptConfirm):
 123         (TestWebKitAPI::runJavaScriptPrompt):
 124         (TestWebKitAPI::createNewPage):
 125         (TestWebKitAPI::TEST):
 126
 127         * TestWebKitAPI/Tests/mac/FullscreenZoomInitialFrame.mm:
 128         (TestWebKitAPI::FullscreenZoomInitialFrame::initializeView):
 129
 130         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
 131         (TestWebKitAPI::PageVisibilityStateWithWindowChanges::initializeView):
 132
 133         * WebKitTestRunner/TestController.cpp:
 134         (WTR::TestController::createOtherPage):
 135         (WTR::TestController::createWebViewWithOptions):
 136
 137 2015-06-23  Dewei Zhu  <dewei_zhu@apple.com>
 138
 139         Refactoring benchmark runner script to follow pep8 code style.
 140         https://bugs.webkit.org/show_bug.cgi?id=146264
 141
 142         Reviewed by Ryosuke Niwa.
 143
 144         Refactor benchmark runner script to follow pep8 code style.
 145
 146         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
 147         (GenericBenchmarkBuilder.prepare):
 148         (GenericBenchmarkBuilder._run_create_script):
 149         (GenericBenchmarkBuilder._copy_benchmark_to_temp_dir):
 150         (GenericBenchmarkBuilder._fetch_remote_archive):
 151         (GenericBenchmarkBuilder):
 152         (GenericBenchmarkBuilder._checkout_with_subversion):
 153         (GenericBenchmarkBuilder._apply_patch):
 154         (GenericBenchmarkBuilder.clean):
 155         (GenericBenchmarkBuilder._runCreateScript): Deleted.
 156         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Deleted.
 157         (GenericBenchmarkBuilder._fetchRemoteArchive): Deleted.
 158         (GenericBenchmarkBuilder._checkoutWithSubverion): Deleted.
 159         (GenericBenchmarkBuilder._applyPatch): Deleted.
 160         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
 161         (BenchmarkRunner.__init__):
 162         (BenchmarkRunner._find_plan_file):
 163         (BenchmarkRunner.execute):
 164         (BenchmarkRunner._cleanup):
 165         (BenchmarkRunner._dump):
 166         (BenchmarkRunner._wrap):
 167         (BenchmarkRunner._merge):
 168         (BenchmarkRunner._show_results):
 169         (BenchmarkRunner._findPlanFile): Deleted.
 170         (BenchmarkRunner.cleanup): Deleted.
 171         (BenchmarkRunner.dump): Deleted.
 172         (BenchmarkRunner.wrap): Deleted.
 173         (BenchmarkRunner.merge): Deleted.
 174         (BenchmarkRunner.show_results): Deleted.
 175         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
 176         (BrowserDriver.prepare_env):
 177         (BrowserDriver.launch_url):
 178         (BrowserDriver.close_browsers):
 179         (BrowserDriver.prepareEnv): Deleted.
 180         (BrowserDriver.launchUrl): Deleted.
 181         (BrowserDriver.closeBrowser): Deleted.
 182         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
 183         (OSXBrowserDriver):
 184         (OSXBrowserDriver.prepare_env):
 185         (OSXBrowserDriver.close_browsers):
 186         (OSXBrowserDriver._launch_process):
 187         (OSXBrowserDriver._terminiate_processes):
 188         (OSXBrowserDriver._launch_process_with_caffinate):
 189         (OSXBrowserDriver._screen_size):
 190         (OSXBrowserDriver.prepareEnv): Deleted.
 191         (OSXBrowserDriver.closeBrowsers): Deleted.
 192         (OSXBrowserDriver.launchProcess): Deleted.
 193         (OSXBrowserDriver.terminateProcesses): Deleted.
 194         (OSXBrowserDriver.launchProcessWithCaffinate): Deleted.
 195         (OSXBrowserDriver.screenSize): Deleted.
 196         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
 197         (OSXChromeDriver):
 198         (OSXChromeDriver.launch_url):
 199         (OSXChromeCanaryDriver):
 200         (OSXChromeCanaryDriver.launch_url):
 201         (OSXChromeDriver.launchUrl): Deleted.
 202         (OSXChromeCanaryDriver.launchUrl): Deleted.
 203         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
 204         (OSXFirefoxDriver):
 205         (OSXFirefoxDriver.launch_url):
 206         (OSXFirefoxNightlyDriver):
 207         (OSXFirefoxNightlyDriver.launch_url):
 208         (OSXFirefoxDriver.launchUrl): Deleted.
 209         (OSXFirefoxNightlyDriver.launchUrl): Deleted.
 210         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
 211         (OSXSafariDriver):
 212         (OSXSafariDriver.prepare_env):
 213         (OSXSafariDriver.launch_url):
 214         (OSXSafariDriver.close_browsers):
 215         (OSXSafariDriver._maximize_window):
 216         (OSXSafariDriver.prepareEnv): Deleted.
 217         (OSXSafariDriver.launchUrl): Deleted.
 218         (OSXSafariDriver.closeBrowsers): Deleted.
 219         (OSXSafariDriver.maximizeWindow): Deleted.
 220         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
 221         (HTTPServerDriver.fetch_result):
 222         (HTTPServerDriver.kill_server):
 223         (HTTPServerDriver.get_return_code):
 224         (HTTPServerDriver.set_device_id):
 225         (HTTPServerDriver.fetchResult): Deleted.
 226         (HTTPServerDriver.killServer): Deleted.
 227         (HTTPServerDriver.getReturnCode): Deleted.
 228         (HTTPServerDriver.setDeviceID): Deleted.
 229         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
 230         (SimpleHTTPServerDriver.serve):
 231         (SimpleHTTPServerDriver.base_url):
 232         (SimpleHTTPServerDriver.fetch_result):
 233         (SimpleHTTPServerDriver.kill_server):
 234         (SimpleHTTPServerDriver.get_return_code):
 235         (SimpleHTTPServerDriver): Deleted.
 236         (SimpleHTTPServerDriver.baseUrl): Deleted.
 237         (SimpleHTTPServerDriver.fetchResult): Deleted.
 238         (SimpleHTTPServerDriver.killServer): Deleted.
 239         (SimpleHTTPServerDriver.getReturnCode): Deleted.
 240         * Scripts/webkitpy/benchmark_runner/utils.py:
 241         (get_path_from_project_root):
 242         (force_remove):
 243         (getPathFromProjectRoot): Deleted.
 244         (forceRemove): Deleted.
 245
 246 2015-06-23  Anders Carlsson  <andersca@apple.com>
 247
 248         Add operator! and copy/move constructors to WeakObjCPtr
 249         https://bugs.webkit.org/show_bug.cgi?id=146255
 250
 251         Reviewed by Andreas Kling.
 252
 253         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm:
 254         (TEST):
 255
 256 2015-06-23  Simon Fraser  <simon.fraser@apple.com>
 257
 258         Expose some more rendering progress events, and have MiniBrowser log for each of them
 259         https://bugs.webkit.org/show_bug.cgi?id=146227
 260
 261         Reviewed by Darin Adler.
 262
 263         Register for layout milestones/rendering progress events in the WK1 and WK2
 264         browser window controllers, and, if logging is turned on, log when they are
 265         reached.
 266
 267         * MiniBrowser/mac/WK1BrowserWindowController.m:
 268         (-[WK1BrowserWindowController awakeFromNib]):
 269         (-[WK1BrowserWindowController webView:didLayout:]):
 270         * MiniBrowser/mac/WK2BrowserWindowController.m:
 271         (-[WK2BrowserWindowController awakeFromNib]):
 272         (-[WK2BrowserWindowController _webView:renderingProgressDidChange:]):
 273
 274 2015-06-23  Brady Eidson  <beidson@apple.com>
 275
 276         WKFrameInfo should have an accessor for the Frame's current security origin.
 277         https://bugs.webkit.org/show_bug.cgi?id=146162
 278
 279         Reviewed by Dan Bernstein.
 280
 281         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 282         * TestWebKitAPI/Tests/WebKit2/modal-alerts-in-new-about-blank-window.html: Added.
 283         * TestWebKitAPI/Tests/WebKit2Cocoa/ModalAlerts.mm: Added.
 284         (sawDialog):
 285         (-[ModalAlertsUIDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
 286         (-[ModalAlertsUIDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
 287         (-[ModalAlertsUIDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
 288         (-[ModalAlertsUIDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
 289         (TEST):
 290
 291 2015-06-23  Tanay C  <tanay.c@samsung.com>
 292
 293         Remove build warnings in Tools/DumpRenderTree/TestNetscapePlugIn
 294         https://bugs.webkit.org/show_bug.cgi?id=146007
 295
 296         Reviewed by Darin Adler.
 297
 298         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
 299         * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp: Add attribute to functions.
 300         (pluginLogWithWindowObject):
 301         (pluginLogWithArguments):
 302         (pluginLog):
 303         * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp: Add attribute to functions.
 304         (PluginTest::executeScript):
 305         (PluginTest::log):
 306
 307 2015-06-23  Csaba Osztrogonác  <ossy@webkit.org>
 308
 309         [EFL] Add libhyphen-dev as dependency after r185862
 310         https://bugs.webkit.org/show_bug.cgi?id=146230
 311
 312         Reviewed by Gyuyoung Kim.
 313
 314         * efl/install-dependencies:
 315
 316 2015-06-22  Ryuan Choi  <ryuan.choi@navercorp.com>
 317
 318         [EFL] Hyphenation is not supported
 319         https://bugs.webkit.org/show_bug.cgi?id=89830
 320
 321         Reviewed by Gyuyoung Kim.
 322
 323         * efl/jhbuild.modules: Added webkitgtk-test-dicts for layout test.
 324
 325 2015-06-22  Dewei Zhu  <dewei_zhu@apple.com>
 326
 327         Get rid of factory json files in benchmark_runner
 328         https://bugs.webkit.org/show_bug.cgi?id=146175
 329
 330         Reviewed by Ryosuke Niwa.
 331
 332         Get rid of factory json files in benchmark_runner and refactoring the code.
 333
 334         * Scripts/webkitpy/benchmark_runner/benchmark_builder/__init__.py:
 335         (benchmark_builder_loader):
 336         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builder_factory.py:
 337         (BenchmarkBuilderFactory):
 338         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Removed.
 339         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
 340         (GenericBenchmarkBuilder):
 341         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
 342         (BenchmarkRunner.__init__):
 343         (BenchmarkRunner.execute):
 344         * Scripts/webkitpy/benchmark_runner/browser_driver/__init__.py:
 345         (browser_driver_loader):
 346         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
 347         (BrowserDriver):
 348         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
 349         (BrowserDriverFactory):
 350         (BrowserDriverFactory.available_platforms):
 351         (BrowserDriverFactory.available_browsers):
 352         (BrowserDriverFactory.add_browser_driver):
 353         (BrowserDriverFactory.create):
 354         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json: Removed.
 355         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
 356         (OSXBrowserDriver):
 357         (OSXBrowserDriver.prepareEnv):
 358         (OSXBrowserDriver.terminateProcesses):
 359         (OSXBrowserDriver.screenSize):
 360         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
 361         (OSXChromeDriver):
 362         (OSXChromeCanaryDriver):
 363         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
 364         (OSXFirefoxDriver):
 365         (OSXFirefoxNightlyDriver):
 366         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
 367         (OSXSafariDriver):
 368         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
 369         (GenericFactory.create):
 370         (GenericFactory.add):
 371         (GenericFactory.iterateGetItem): Deleted.
 372         * Scripts/webkitpy/benchmark_runner/http_server_driver/__init__.py:
 373         (http_server_driver_loader):
 374         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
 375         (HTTPServerDriver):
 376         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver_factory.py:
 377         (HTTPServerDriverFactory):
 378         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_drivers.json: Removed.
 379         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
 380         (SimpleHTTPServerDriver):
 381         * Scripts/webkitpy/benchmark_runner/utils.py:
 382         (is_subclass):
 383         (load_subclasses):
 384         (ModuleNotFoundError): Deleted.
 385         (loadModule): Deleted.
 386         (loadJSONFromFile): Deleted.
 387
 388 2015-06-22  Simon Fraser  <simon.fraser@apple.com>
 389
 390         Make it possible to enable incremental rendering suppression in MiniBrowser
 391         https://bugs.webkit.org/show_bug.cgi?id=146223
 392
 393         Reviewed by Tim Horton.
 394
 395         Add a menu item to enable incremental rendering suppression to MiniBrowser.
 396
 397         For WK1, this just toggles a pref, and takes effect immediately.
 398
 399         For WK2, this is a WKConfiguration property, so only affects new web views.
 400
 401         Also remove a toolbar item connection to toggleUseMinimumViewSize: that caused
 402         logging on launch.
 403
 404         * MiniBrowser/mac/AppDelegate.m:
 405         (defaultConfiguration):
 406         * MiniBrowser/mac/BrowserWindow.xib:
 407         * MiniBrowser/mac/SettingsController.h:
 408         * MiniBrowser/mac/SettingsController.m:
 409         (-[SettingsController _populateMenu]):
 410         (-[SettingsController validateMenuItem:]):
 411         (-[SettingsController toggleIncrementalRenderingSuppressed:]):
 412         (-[SettingsController incrementalRenderingSuppressed]):
 413         * MiniBrowser/mac/WK1BrowserWindowController.m:
 414         (-[WK1BrowserWindowController didChangeSettings]):
 415
 416 2015-06-19  Filip Pizlo  <fpizlo@apple.com>
 417
 418         Run CDjs as part of JSC stress testing
 419         https://bugs.webkit.org/show_bug.cgi?id=146174
 420
 421         Reviewed by Geoffrey Garen.
 422
 423         * Scripts/run-javascriptcore-tests:
 424         (runJSCStressTests): Make this aware of the cdjs-tests.yaml.
 425         * Scripts/run-jsc-stress-tests:
 426         - Teach this about tests that indicate error by returning an error code while also having lots of output even when they succeed.
 427         - Add the ability to have "tests" be a list of tests rather than just one test. This could also be a list of directories that have tests.
 428         - Fix a bug with bundle copying: whether the $collection should have the basename appended depends on whether we copy into bundleDir.dirname, not on whether absoluteCollection is a directory.
 429
 430 2015-06-21  Alexey Proskuryakov  <ap@apple.com>
 431
 432         REGRESSION (r172975): navigator.language unable to tell region for Traditional Chinese users
 433         https://bugs.webkit.org/show_bug.cgi?id=146121
 434         rdar://problem/21395180
 435
 436         Reviewed by Darin Adler.
 437
 438         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 439         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm: Added.
 440         (-[NavigatorLanguageDelegate webView:didFinishLoadForFrame:]):
 441         (TestWebKitAPI::overrideAppleLanguages):
 442         (TestWebKitAPI::languageForSystemLanguage):
 443         (TestWebKitAPI::TEST):
 444
 445 2015-06-21  Michael Catanzaro  <mcatanzaro@igalia.com>
 446
 447         [CMake] Ignore warnings from system headers when compiling Tools
 448         https://bugs.webkit.org/show_bug.cgi?id=146185
 449
 450         Reviewed by Martin Robinson.
 451
 452         Use the SYSTEM argument to the include_directories() command to silence compiler warnings
 453         from system headers that we don't control.
 454
 455         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
 456         * ImageDiff/CMakeLists.txt: Also, remove an EFL include directory from here...
 457         * ImageDiff/PlatformEfl.cmake: ...and put it here where it belongs.
 458         * ImageDiff/PlatformGTK.cmake:
 459         * MiniBrowser/efl/CMakeLists.txt:
 460         * MiniBrowser/gtk/CMakeLists.txt:
 461         * TestWebKitAPI/PlatformEfl.cmake:
 462         * TestWebKitAPI/PlatformGTK.cmake:
 463         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
 464         * WebKitTestRunner/CMakeLists.txt:
 465         * WebKitTestRunner/PlatformEfl.cmake:
 466         * WebKitTestRunner/PlatformGTK.cmake:
 467
 468 2015-06-20  Michael Catanzaro  <mcatanzaro@igalia.com>
 469
 470         [GTK] Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser
 471         https://bugs.webkit.org/show_bug.cgi?id=146186
 472
 473         Reviewed by Martin Robinson.
 474
 475         Define GDK_VERSION_MIN_REQUIRED when compiling MiniBrowser to silence several dozen
 476         deprecation warnings. (MiniBrowser is unique in that it does not include wtf/Platform.h.)
 477
 478         * MiniBrowser/gtk/CMakeLists.txt:
 479
 480 2015-06-19  Ryosuke Niwa  <rniwa@webkit.org>
 481
 482         Build fix after r146125.
 483
 484         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
 485         (OSXSafariDriver):
 486         (OSXSafariDriver.prepareEnv):
 487
 488 2015-06-19  Brady Eidson  <beidson@apple.com>
 489
 490         Rename WKSecurityOrigin.h/cpp to WKSecurityOriginRef.h/cpp.
 491         https://bugs.webkit.org/show_bug.cgi?id=146152
 492
 493         Reviewed by Dan Bernstein.
 494
 495         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
 496         * WebKitTestRunner/WebNotificationProvider.cpp:
 497
 498 2015-06-19  Mark Lam  <mark.lam@apple.com>
 499
 500         CheckedArithmetic's operator bool() and operator==() is broken.
 501         https://bugs.webkit.org/show_bug.cgi?id=146129
 502
 503         Reviewed by Geoffrey Garen and Oliver Hunt.
 504
 505         Added API tests for operator ==, !=, <, <=, >, and >=, and tested for both normal
 506         and overflow scenarios in usage of the Checked arithmetic class.
 507
 508         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
 509         (TestWebKitAPI::OverflowCrashLogger::overflowed):
 510         (TestWebKitAPI::OverflowCrashLogger::clearOverflow):
 511         (TestWebKitAPI::OverflowCrashLogger::crash):
 512         (TestWebKitAPI::OverflowCrashLogger::reset):
 513         (TestWebKitAPI::OverflowCrashLogger::hasOverflowed):
 514         (TestWebKitAPI::OverflowCrashLogger::overflowCount):
 515         (TestWebKitAPI::OverflowCrashLogger::didCrash):
 516         - crash logger for verifying that a crash occurs when expected.
 517
 518         (TestWebKitAPI::resetOverflow):
 519         - convenience function for resetting a test value to an initial overflowed state
 520           before a crash.  We will use this value in the overflow testing.
 521
 522         (TestWebKitAPI::CheckedArithmeticTester::run):
 523         - Added new tests for all the comparison operators.
 524
 525 2015-06-19  Per Arne Vollan  <peavo@outlook.com>
 526
 527         Fix the Windows build after r185721
 528         https://bugs.webkit.org/show_bug.cgi?id=146146
 529
 530         Reviewed by Csaba Osztrogonác.
 531
 532         Speculative buildfix.
 533
 534         * DumpRenderTree/win/UIDelegate.h:
 535         (UIDelegate::unused4): Added.
 536         (UIDelegate::webViewShouldInterruptJavaScript): Deleted.
 537
 538 2015-06-19  Diego Pino Garcia  <dpino@igalia.com>
 539
 540         Unreviewed. Add myself as a committer.
 541
 542         * Scripts/webkitpy/common/config/contributors.json:
 543
 544 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
 545
 546         Remove unnecessary svn:executable flags
 547         https://bugs.webkit.org/show_bug.cgi?id=146107
 548
 549         Reviewed by Alexey Proskuryakov.
 550
 551         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Removed property svn:executable.
 552         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Removed property svn:executable.
 553         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/daterangepicker.css: Removed property svn:executable.
 554         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/jquery.daterangepicker.js: Removed property svn:executable.
 555         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/External/moment.min.js: Removed property svn:executable.
 556         * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Removed property svn:executable.
 557         * CygwinDownloader/cygwin-downloader.zip: Removed property svn:executable.
 558         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Removed property svn:executable.
 559         * DumpRenderTree/win/TextInputController.cpp: Removed property svn:executable.
 560         * DumpRenderTree/win/TextInputController.h: Removed property svn:executable.
 561         * DumpRenderTree/win/TextInputControllerWin.cpp: Removed property svn:executable.
 562         * Scripts/webkitpy/port/base_unittest.py: Removed property svn:executable.
 563         * Scripts/webkitpy/port/driver.py: Removed property svn:executable.
 564         * Scripts/webkitpy/w3c/test_parser.py: Removed property svn:executable.
 565
 566 2015-06-19  Csaba Osztrogonác  <ossy@webkit.org>
 567
 568         Disable tests on the WinCairo buildbot
 569         https://bugs.webkit.org/show_bug.cgi?id=146106
 570
 571         Reviewed by Alexey Proskuryakov.
 572
 573         * BuildSlaveSupport/build.webkit.org-config/config.json:
 574         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
 575
 576 2015-06-19  Hunseop Jeong  <hs85.jeong@samsung.com>
 577
 578         [EFL] Fix the minibrowser after r185725
 579         https://bugs.webkit.org/show_bug.cgi?id=146135
 580
 581         Reviewed by Gyuyoung Kim.
 582
 583         Removed the HAVE_ECORE_X guard in MiniBrowser because it is an unnecessary guard
 584         for the elm_config_accel_preference_set() to set the config of acceleration preference.
 585
 586         * MiniBrowser/efl/main.c:
 587         (elm_main): Deleted the HAVE_ECORE_X guard.
 588
 589 2015-06-18  Dewei Zhu  <dewei_zhu@apple.com>
 590
 591         Extend capability of run-benchmark script to support mobile device
 592         https://bugs.webkit.org/show_bug.cgi?id=146125
 593
 594         Reviewed by Ryosuke Niwa.
 595
 596         Extend capability of run-benchmark to support mobile device, and move majority of run-benchmark script code to
 597         benchmark_runner directory, and make run-benchmark a wrapping script. Also correct a typo.
 598
 599         * Scripts/run-benchmark:
 600         (main): Deleted.
 601         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
 602         (BenchmarkRunner.__init__):
 603         (BenchmarkRunner.execute):
 604         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
 605         (BrowserDriver.prepareEnv):
 606         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
 607         (OSXBrowserDriver.prepareEnv):
 608         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
 609         (OSXSafariDriver.prepareEnv):
 610         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server_driver.py:
 611         (HTTPServerDriver.getReturnCode):
 612         (HTTPServerDriver):
 613         (HTTPServerDriver.setDeviceID):
 614         * Scripts/webkitpy/benchmark_runner/run_benchmark.py: Copied from Tools/Scripts/run-benchmark.
 615         (parse_args):
 616         (start):
 617         (main):
 618         * Scripts/webkitpy/benchmark_runner/utils.py:
 619         (getPathFromProjectRoot):
 620
 621 2015-06-18  Jon Lee  <jonlee@apple.com>
 622
 623         Unreviewed. Add Matt Daiter as a contributor.
 624
 625         * Scripts/webkitpy/common/config/contributors.json:
 626
 627 2015-06-18  Mark Lam  <mark.lam@apple.com>
 628
 629         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
 630         https://bugs.webkit.org/show_bug.cgi?id=146103
 631
 632         Not reviewed.
 633
 634         Follow up to fix some typos not caught before original patch was landed.
 635
 636         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
 637         (TestWebKitAPI::CheckedArithmeticTester::run):
 638         (TestWebKitAPI::AllowMixedSignednessTest::run):
 639         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
 640
 641 2015-06-18  Daniel Bates  <dabates@apple.com>
 642
 643         Make webkitdirs::runGitUpdate() work when invoked in more than one Git checkout
 644         https://bugs.webkit.org/show_bug.cgi?id=146082
 645
 646         Reviewed by Darin Adler.
 647
 648         The function webkitdirs::runGitUpdate may not update the Git checkout in the current
 649         working directory after being invoked in a different Git checkout. In particular,
 650         calling runGitUpdate() inside a Git SVN checkout and subsequently calling it inside
 651         a pure Git checkout g will fail to update g.
 652
 653         Currently webkitdirs::runGitUpdate() calls VCSUtils::isGitSVN() to determine whether
 654         the current working directory is a Git SVN checkout. And isGitSVN() caches its result
 655         to speed up subsequent queries. This prevents runGitUpdate() from being used to update
 656         an arbitrary Git checkout (since isGitSVN() may return a cached result for a directory
 657         different than the current working directory). Instead runGitUpdate() should check
 658         whether the current working directory is a Git SVN checkout on each invocation.
 659
 660         * Scripts/VCSUtils.pm: Export function isGitSVNDirectory so that it can be used from webkitdirs::runGitUpdate().
 661         (isGitSVNDirectory): Extracted logic to determine whether a directory is a Git
 662         SVN directory from isGitSVN().
 663         (isGitSVN): Implemented in terms of isGitSVNDirectory().
 664         * Scripts/webkitdirs.pm:
 665         (runGitUpdate): Modified to use isGitSVNDirectory().
 666
 667 2015-06-18  Mark Lam  <mark.lam@apple.com>
 668
 669         Refactor CheckedArithmeticOperations.cpp to use templates instead of macros.
 670         https://bugs.webkit.org/show_bug.cgi?id=146103
 671
 672         Reviewed by Anders Carlsson.
 673
 674         Presently, the tests in CheckedArithmeticOperations.cpp are all implemented as
 675         part of a large macro.  This makes them harder to:
 676
 677         1. write: no editor help with indentations, have to add trailing '\'s,
 678            inconvenient to add line breaks and comments.
 679
 680         2. read: no chroma coding / syntax highlighting.
 681
 682         3. debug: compile time errors are reported as being on the single line where
 683            the macro is used.
 684
 685         Refactoring the tests to use C++ templates solves all these issues.
 686
 687         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
 688         (TestWebKitAPI::CheckedArithmeticTester::run):
 689         (TestWebKitAPI::AllowMixedSignednessTest::run):
 690         (TestWebKitAPI::IgnoreMixedSignednessTest::run):
 691         (TestWebKitAPI::CoerceLiteralToUnsigned::coerce):
 692         (TestWebKitAPI::CoerceLiteralNop::coerce):
 693
 694 2015-06-18  Christophe Dumez  <ch.dumez@sisa.samsung.com>
 695
 696         [EFL][WK2] Use Web Browser cache model in MiniBrowser
 697         https://bugs.webkit.org/show_bug.cgi?id=112273
 698
 699         Reviewed by Laszlo Gombos.
 700
 701         Set cache model to EWK_CACHE_MODEL_PRIMARY_WEBBROWSER in EFL's MiniBrowser
 702         instead of leaving the default value (EWK_CACHE_MODEL_DOCUMENT_VIEWER).
 703         This way we have a decent cache capacity and the page cache actually works.
 704
 705         * MiniBrowser/efl/main.c:
 706         (elm_main):
 707
 708 2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
 709
 710         Remove redundant Chromium bug keyword
 711         https://bugs.webkit.org/show_bug.cgi?id=146097
 712
 713         Reviewed by Csaba Osztrogonác.
 714
 715         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 716         (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
 717         (TestExpectationLine._format_line): Deleted.
 718
 719 2015-06-17  Daniel Bates  <dabates@apple.com>
 720
 721         Client may receive began editing callback for already focused text field
 722         https://bugs.webkit.org/show_bug.cgi?id=146074
 723         <rdar://problem/21293562>
 724
 725         Reviewed by Darin Adler.
 726
 727         Add a unit test to ensure that a client receives exactly one began editing
 728         callback when a text field is newly focused. In particular, dispatching
 729         a DOM focus event at an already focused text field does not dispatch a
 730         began editing callback to the client.
 731
 732         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
 733         (TestWebKitAPI::TEST_F):
 734
 735 2015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
 736
 737         [Win]Implement layoutTestController.dispatchPendingLoadRequests.
 738         https://bugs.webkit.org/show_bug.cgi?id=26481
 739
 740         Reviewed by Darin Adler.
 741
 742         Implement WebView::dispatchPendingLoadRequests() private API for test runner.
 743
 744         * DumpRenderTree/win/TestRunnerWin.cpp:
 745         (TestRunner::dispatchPendingLoadRequests):
 746         (TestRunner::overridePreference):
 747
 748 2015-06-17  Alex Christensen  <achristensen@webkit.org>
 749
 750         [Content Extensions] Fail to parse invalid arrays
 751         https://bugs.webkit.org/show_bug.cgi?id=146079
 752         rdar://problem/21422649
 753
 754         Reviewed by Benjamin Poulain.
 755
 756         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 757         (TestWebKitAPI::TEST_F):
 758         Correct and add parsing tests with invalid arrays.
 759
 760 2015-06-17  Matt Rajca  <mrajca@apple.com>
 761
 762         Unreviewed. Added myself as a committer.
 763
 764         * Scripts/webkitpy/common/config/contributors.json:
 765
 766 2015-06-17  Daniel Bates  <dabates@apple.com>
 767
 768         Export VCSUtils::gitTreeDirectory()
 769         <rdar://problem/21248901>
 770
 771         Rubber-stamped by Alexey Proskuryakov.
 772
 773         * Scripts/VCSUtils.pm:
 774
 775 2015-06-17  Tim Horton  <timothy_horton@apple.com>
 776
 777         Safari tabs still have shrunken content after coming out of fullscreen
 778         https://bugs.webkit.org/show_bug.cgi?id=146037
 779         <rdar://problem/21105960>
 780
 781         Reviewed by Simon Fraser and Darin Adler.
 782
 783         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 784         * TestWebKitAPI/Tests/WebKit2Cocoa/ShrinkToFit.mm: Added.
 785         (-[ShrinkToFitNavigationDelegate webView:didFinishNavigation:]):
 786         (TEST):
 787         Add a test that ensures that disabling scale-to-fit mode correctly updates
 788         the page's layout.
 789
 790 2015-06-17  Dan Bernstein  <mitz@apple.com>
 791
 792         [Cocoa] Expose UIDelegate::UIClient::close via WKUIDelegate
 793         https://bugs.webkit.org/show_bug.cgi?id=145957
 794
 795         Reviewed by Darin Adler.
 796
 797         * TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm:
 798         (-[OpenAndCloseWindowUIDelegate webViewDidClose:]): Renamed from -_webViewClose:.
 799
 800 2015-06-15  Chris Fleizach  <cfleizach@apple.com>
 801
 802         AX:  iOS accessibility tests are not running because we need WKTR support
 803         https://bugs.webkit.org/show_bug.cgi?id=145991
 804
 805         Reviewed by Daniel Bates.
 806
 807         Add support for WKTR iOS accessibility.
 808         Utilize the notification handling mechanisms that Mac already uses.
 809         Rename iphone* DRT methods to either use existing methods that are similar, or rename to more generic names.
 810
 811         * DumpRenderTree/AccessibilityUIElement.cpp:
 812         (stringForSelectionCallback):
 813         (getIdentifierCallback):
 814         (getTraitsCallback):
 815         (getElementTextPositionCallback):
 816         (getElementTextLengthCallback):
 817         (AccessibilityUIElement::getJSClass):
 818         (getIPhoneLabelCallback): Deleted.
 819         (getIPhoneHintCallback): Deleted.
 820         (getIPhoneValueCallback): Deleted.
 821         (getIPhoneIdentifierCallback): Deleted.
 822         (getIPhoneTraitsCallback): Deleted.
 823         (getIPhoneIsElementCallback): Deleted.
 824         (getIPhoneElementTextPositionCallback): Deleted.
 825         (getIPhoneElementTextLengthCallback): Deleted.
 826         * DumpRenderTree/AccessibilityUIElement.h:
 827         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
 828         (AccessibilityUIElement::identifier):
 829         (AccessibilityUIElement::traits):
 830         (AccessibilityUIElement::elementTextPosition):
 831         (AccessibilityUIElement::elementTextLength):
 832         (AccessibilityUIElement::description):
 833         (AccessibilityUIElement::orientation):
 834         (AccessibilityUIElement::stringValue):
 835         (AccessibilityUIElement::language):
 836         (AccessibilityUIElement::helpText):
 837         (AccessibilityUIElement::intValue):
 838         (AccessibilityUIElement::isSelected):
 839         (AccessibilityUIElement::isExpanded):
 840         (AccessibilityUIElement::documentURI):
 841         (AccessibilityUIElement::addNotificationListener):
 842         (AccessibilityUIElement::removeNotificationListener):
 843         (AccessibilityUIElement::isFocusable):
 844         (AccessibilityUIElement::isIgnored):
 845         (AccessibilityUIElement::hasPopup):
 846         (AccessibilityUIElement::iphoneLabel): Deleted.
 847         (AccessibilityUIElement::iphoneHint): Deleted.
 848         (AccessibilityUIElement::iphoneValue): Deleted.
 849         (AccessibilityUIElement::iphoneIdentifier): Deleted.
 850         (AccessibilityUIElement::iphoneTraits): Deleted.
 851         (AccessibilityUIElement::iphoneIsElement): Deleted.
 852         (AccessibilityUIElement::iphoneElementTextPosition): Deleted.
 853         (AccessibilityUIElement::iphoneElementTextLength): Deleted.
 854         (_accessibilityNotificationCallback): Deleted.
 855         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
 856         (WTR::AccessibilityUIElement::isValid):
 857         (WTR::AccessibilityUIElement::identifier):
 858         (WTR::AccessibilityUIElement::traits):
 859         (WTR::AccessibilityUIElement::elementTextPosition):
 860         (WTR::AccessibilityUIElement::elementTextLength):
 861         (WTR::AccessibilityUIElement::stringForSelection):
 862         (WTR::AccessibilityUIElement::elementsForRange):
 863         (WTR::AccessibilityUIElement::increaseTextSelection):
 864         (WTR::AccessibilityUIElement::decreaseTextSelection):
 865         (WTR::AccessibilityUIElement::linkedElement):
 866         (WTR::AccessibilityUIElement::headerElementAtIndex):
 867         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
 868         (WTR::AccessibilityUIElement::characterAtOffset):
 869         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
 870         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
 871         * WebKitTestRunner/InjectedBundle/ios/AccessibilityControllerIOS.mm:
 872         (WTR::findAccessibleObjectById):
 873         (WTR::AccessibilityController::accessibleElementById):
 874         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
 875         (+[NSString stringWithJSStringRef:]):
 876         (-[NSString createJSStringRef]):
 877         (WTR::convertNSArrayToVector):
 878         (WTR::concatenateAttributeAndValue):
 879         (WTR::AccessibilityUIElement::AccessibilityUIElement):
 880         (WTR::AccessibilityUIElement::isEqual):
 881         (WTR::AccessibilityUIElement::headerElementAtIndex):
 882         (WTR::AccessibilityUIElement::linkedElement):
 883         (WTR::AccessibilityUIElement::getLinkedUIElements):
 884         (WTR::AccessibilityUIElement::elementAtPoint):
 885         (WTR::convertElementsToObjectArray):
 886         (WTR::AccessibilityUIElement::elementsForRange):
 887         (WTR::AccessibilityUIElement::indexOfChild):
 888         (WTR::AccessibilityUIElement::stringAttributeValue):
 889         (WTR::AccessibilityUIElement::description):
 890         (WTR::AccessibilityUIElement::orientation):
 891         (WTR::AccessibilityUIElement::stringValue):
 892         (WTR::AccessibilityUIElement::language):
 893         (WTR::AccessibilityUIElement::helpText):
 894         (WTR::AccessibilityUIElement::x):
 895         (WTR::AccessibilityUIElement::clickPointX):
 896         (WTR::AccessibilityUIElement::clickPointY):
 897         (WTR::AccessibilityUIElement::intValue):
 898         (WTR::AccessibilityUIElement::minValue):
 899         (WTR::AccessibilityUIElement::maxValue):
 900         (WTR::AccessibilityUIElement::valueDescription):
 901         (WTR::AccessibilityUIElement::isSelected):
 902         (WTR::AccessibilityUIElement::isSelectedOptionActive):
 903         (WTR::AccessibilityUIElement::stringForRange):
 904         (WTR::AccessibilityUIElement::attributedStringForRange):
 905         (WTR::AccessibilityUIElement::attributesOfHeader):
 906         (WTR::AccessibilityUIElement::traits):
 907         (WTR::AccessibilityUIElement::identifier):
 908         (WTR::AccessibilityUIElement::rowCount):
 909         (WTR::AccessibilityUIElement::rowIndexRange):
 910         (WTR::AccessibilityUIElement::columnIndexRange):
 911         (WTR::AccessibilityUIElement::cellForColumnAndRow):
 912         (WTR::AccessibilityUIElement::horizontalScrollbar):
 913         (WTR::AccessibilityUIElement::documentURI):
 914         (WTR::AccessibilityUIElement::assistiveTechnologySimulatedFocus):
 915         (WTR::AccessibilityUIElement::increaseTextSelection):
 916         (WTR::AccessibilityUIElement::decreaseTextSelection):
 917         (WTR::AccessibilityUIElement::stringForSelection):
 918         (WTR::AccessibilityUIElement::elementTextPosition):
 919         (WTR::AccessibilityUIElement::elementTextLength):
 920         (WTR::AccessibilityUIElement::url):
 921         (WTR::AccessibilityUIElement::addNotificationListener):
 922         (WTR::AccessibilityUIElement::removeNotificationListener):
 923         (WTR::AccessibilityUIElement::isFocusable):
 924         (WTR::AccessibilityUIElement::isIgnored):
 925         (WTR::AccessibilityUIElement::hasPopup):
 926         (WTR::AccessibilityUIElement::mathPrescriptsDescription):
 927         (WTR::_CGPathEnumerationIteration):
 928         (WTR::AccessibilityUIElement::pathDescription):
 929         (WTR::AccessibilityUIElement::supportedActions):
 930
 931 2015-06-16  Mark Lam  <mark.lam@apple.com>
 932
 933         Use NakedPtr<Exception>& to return exception results.
 934         https://bugs.webkit.org/show_bug.cgi?id=145870
 935
 936         Reviewed by Anders Carlsson and Filip Pizlo.
 937
 938         * TestWebKitAPI/CMakeLists.txt:
 939         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
 940         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
 941         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
 942         * TestWebKitAPI/Tests/WTF/NakedPtr.cpp: Added.
 943         (TestWebKitAPI::TEST):
 944         (TestWebKitAPI::nakedPtrFoo):
 945
 946 2015-06-16  Tobias Reiss  <tobi+webkit@basecode.de>
 947
 948         Unreviewed. Adding myself as a committer.
 949
 950         * Scripts/webkitpy/common/config/contributors.json:
 951
 952 2015-06-15  Alexey Proskuryakov  <ap@apple.com>
 953
 954         Add test expectations for El Capitan
 955         https://bugs.webkit.org/show_bug.cgi?id=146005
 956
 957         Rubber-stamped by Dan Bernstein.
 958
 959         Add appropriate tools code.
 960
 961         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
 962         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
 963         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
 964         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
 965         Added dashboard support.
 966
 967         * BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
 968         * BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
 969         Trigger the right build queues on check-in.
 970
 971         * Scripts/webkitpy/common/system/platforminfo.py:
 972         * Scripts/webkitpy/common/system/platforminfo_unittest.py:
 973         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
 974         * Scripts/webkitpy/port/mac.py:
 975         * Scripts/webkitpy/port/mac_unittest.py:
 976         * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 977         * TestResultServer/static-dashboards/flakiness_dashboard.js:
 978         Added cases for El Capitan, and updated tests for new baseline search paths.
 979
 980 2015-06-15  Alex Christensen  <achristensen@webkit.org>
 981
 982         [Content Extensions] Make max NFA size and max rule count user defaults.
 983         https://bugs.webkit.org/show_bug.cgi?id=145663
 984
 985         Reviewed by Benjamin Poulain.
 986
 987         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
 988         (TestWebKitAPI::TEST_F):
 989
 990 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
 991
 992         -[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
 993         https://bugs.webkit.org/show_bug.cgi?id=145900
 994
 995         Reviewed by Sam Weinig.
 996
 997         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
 998         (TEST): Added tests.
 999
1000 2015-06-15  Carlos Garcia Campos  <cgarcia@igalia.com>
1001
1002         [SOUP] Custom URI schemes don't work for requests containing a fragment identifier
1003         https://bugs.webkit.org/show_bug.cgi?id=145969
1004
1005         Reviewed by Sergio Villar Senin.
1006
1007         Add a test case to the custom URI schemes unit test.
1008
1009         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1010         (testWebContextURIScheme):
1011
1012 2015-06-15  Csaba Osztrogonác  <ossy@webkit.org>
1013
1014         [GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
1015         https://bugs.webkit.org/show_bug.cgi?id=145922
1016
1017         Reviewed by Carlos Garcia Campos.
1018
1019         * gtk/jhbuild.modules:
1020         * gtk/patches/glib-warning-fix.patch: Added.
1021
1022 2015-06-12  Alexey Proskuryakov  <ap@apple.com>
1023
1024         Update springLoadingHighlight type
1025         https://bugs.webkit.org/show_bug.cgi?id=145939
1026         rdar://problem/20880213
1027
1028         Reviewed by Darin Adler.
1029
1030         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
1031         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
1032         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
1033         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
1034
1035 2015-06-12  Dewei Zhu  <dewei_zhu@apple.com>
1036
1037         Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
1038         https://bugs.webkit.org/show_bug.cgi?id=145945
1039
1040         Reviewed by Stephanie Lewis.
1041
1042         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1043         (OSXBrowserDriver.prepareEnv):
1044         (OSXBrowserDriver.moveCursor): Deleted.
1045         (OSXBrowserDriver): Deleted.
1046         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1047         (OSXSafariDriver.prepareEnv):
1048
1049 2015-06-12  Brent Fulgham  <bfulgham@apple.com>
1050
1051         Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
1052         https://bugs.webkit.org/show_bug.cgi?id=145938
1053
1054         Reviewed by Alexey Proskuryakov.
1055
1056         * Scripts/update-webkit-dependency: Switch from LWP::Simple to
1057         LWP::UserAgent to get access to more robust HTTPS support.
1058
1059 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1060
1061         [GTK] Fix return type warning in WebViewTest.cpp
1062         https://bugs.webkit.org/show_bug.cgi?id=145914
1063
1064         Reviewed by Darin Adler.
1065
1066         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
1067         (WebViewTest::isEditable):
1068
1069 2015-06-12  Zan Dobersek  <zdobersek@igalia.com>
1070
1071         [GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
1072         https://bugs.webkit.org/show_bug.cgi?id=145799
1073
1074         Reviewed by Carlos Garcia Campos.
1075
1076         Update header inclusions for headers that have been moved
1077         to Source/WTF/wtf/glib/.
1078
1079         Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
1080         to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
1081
1082         * TestWebKitAPI/PlatformGTK.cmake:
1083         * TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
1084         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
1085         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
1086         (TestWebKitAPI::GMainLoopSourceTest::runLoop):
1087         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
1088         (TestWebKitAPI::GMainLoopSourceTest::finish):
1089         (TestWebKitAPI::GMainLoopSourceTest::source):
1090         (TestWebKitAPI::basicRescheduling):
1091         (TestWebKitAPI::TEST):
1092         (TestWebKitAPI::reentrantRescheduling):
1093         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
1094         (TestWebKitAPI::basicDestroyCallbacks):
1095         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
1096         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
1097         * TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
1098         (log):
1099         (takeLogStr):
1100         (TestWebKitAPI::TEST):
1101         (TestWebKitAPI::returnOutChar):
1102         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
1103         * TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
1104         (TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
1105         (TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
1106         (TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
1107         (TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
1108         (TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
1109         (TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
1110         (TestWebKitAPI::basicRescheduling): Deleted.
1111         (TestWebKitAPI::TEST): Deleted.
1112         (TestWebKitAPI::reentrantRescheduling): Deleted.
1113         (TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
1114         (TestWebKitAPI::basicDestroyCallbacks): Deleted.
1115         (TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
1116         (TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
1117         * TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
1118         (log): Deleted.
1119         (takeLogStr): Deleted.
1120         (TestWebKitAPI::TEST): Deleted.
1121         (TestWebKitAPI::returnOutChar): Deleted.
1122         * TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
1123         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
1124         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
1125         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
1126         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1127         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1128         * TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
1129         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
1130         * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
1131         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
1132         * TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
1133         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1134         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
1135         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
1136         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1137         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
1138         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
1139         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1140         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
1141         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1142         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1143         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
1144         * TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
1145         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
1146         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
1147         * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
1148         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
1149         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
1150         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
1151         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
1152         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
1153         * TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
1154         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1155         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1156         * WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
1157         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1158         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
1159         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1160         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1161         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1162         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
1163         * WebKitTestRunner/PlatformGTK.cmake:
1164         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
1165         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1166
1167 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1168
1169         [EFL] Fix deprecated declarations warnings related to WK2 versioned structs
1170         https://bugs.webkit.org/show_bug.cgi?id=145913
1171
1172         Reviewed by Gyuyoung Kim.
1173
1174         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
1175         (TestWebKitAPI::setupGeolocationProvider):
1176         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
1177         (TestWebKitAPI::setPageLoaderClient):
1178         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
1179         (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
1180         * WebKitTestRunner/GeolocationProviderMock.cpp:
1181         (WTR::GeolocationProviderMock::GeolocationProviderMock):
1182         * WebKitTestRunner/WebNotificationProvider.cpp:
1183         (WTR::WebNotificationProvider::provider):
1184
1185 2015-06-12  Csaba Osztrogonác  <ossy@webkit.org>
1186
1187         Fix the libusrsctp build with clang
1188         https://bugs.webkit.org/show_bug.cgi?id=145128
1189
1190         Reviewed by Gyuyoung Kim.
1191
1192         * efl/jhbuild.modules:
1193         * gtk/jhbuild.modules:
1194
1195 2015-06-11  Mark Lam  <mark.lam@apple.com>
1196
1197         WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
1198         https://bugs.webkit.org/show_bug.cgi?id=145872
1199
1200         Reviewed by Michael Saboff.
1201
1202         * TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
1203         (-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
1204         - Exercises the JSC ObjC API to call a function which throws an exception.  That
1205           exception will be returned as a JSValue instead of an Exception object.  We
1206           will use this JSValue to test WebCore::reportException() to confirm that it is
1207           able to handle an exception value which is not an Exception object.
1208
1209 2015-06-11  Dewei Zhu  <dewei_zhu@apple.com>
1210
1211         Move cursor to corner and fix safari window size before running benchmark
1212         https://bugs.webkit.org/show_bug.cgi?id=145858
1213
1214         Reviewed by Ryosuke Niwa
1215
1216         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1217         (OSXBrowserDriver.prepareEnv):
1218         (OSXBrowserDriver):
1219         (OSXBrowserDriver.moveCursor):
1220         (OSXBrowserDriver.getScreenSize):
1221         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
1222         (OSXChromeDriver.launchUrl):
1223         (OSXChromeCanaryDriver.launchUrl):
1224         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
1225         (OSXFirefoxDriver.launchUrl):
1226         (OSXFirefoxNightlyDriver.launchUrl):
1227         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1228         (OSXSafariDriver.prepareEnv):
1229         (OSXSafariDriver):
1230         (OSXSafariDriver.maximizeWindow):
1231
1232 2015-06-11  Daniel Bates  <dabates@apple.com>
1233
1234         [iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
1235         https://bugs.webkit.org/show_bug.cgi?id=145319
1236
1237         Reviewed by David Kilzer.
1238
1239         Add SPI wrapper header for CoreSimulator and update the source files to reference
1240         it instead of directly referencing the CoreSimulator header.
1241
1242         * LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
1243         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
1244         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1245         * LayoutTestRelay/LayoutTestRelay/main.m:
1246
1247 2015-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>
1248
1249         [EFL] dimmed area for popup does not cover the fullscreen mode.
1250         https://bugs.webkit.org/show_bug.cgi?id=145133
1251
1252         Reviewed by Gyuyoung Kim.
1253
1254         By calling elm_win_resize_object_add(), popup was added as a resize object of elm_win.
1255         as a result, popup can cover the fullscreen area when it enters a fullscreen mode.
1256
1257         * MiniBrowser/efl/main.c:
1258         (on_fullscreen_accept):
1259         (on_fullscreen_deny):
1260         (on_fullscreen_enter):
1261
1262 2015-06-10  Commit Queue  <commit-queue@webkit.org>
1263
1264         Unreviewed, rolling out r185442.
1265         https://bugs.webkit.org/show_bug.cgi?id=145871
1266
1267         seems to have broken WTF.StringOperators test (Requested by
1268         alexchristensen on #webkit).
1269
1270         Reverted changeset:
1271
1272         "[Content Extensions] Limit number of rules."
1273         https://bugs.webkit.org/show_bug.cgi?id=145663
1274         http://trac.webkit.org/changeset/185442
1275
1276 2015-06-10  Alex Christensen  <achristensen@webkit.org>
1277
1278         [Content Extensions] Make max NFA size and max rule count user defaults.
1279         https://bugs.webkit.org/show_bug.cgi?id=145663
1280         rdar://problem/21242407
1281
1282         Reviewed by Benjamin Poulain.
1283
1284         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1285         (TestWebKitAPI::TEST_F):
1286
1287 2015-06-10  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1288
1289         [EFL] Execute Javascript method in mini browser address bar.
1290         https://bugs.webkit.org/show_bug.cgi?id=145725
1291
1292         Reviewed by Gyuyoung Kim.
1293
1294         Support 'javascript:' scheme in WebKit EFL Mini Browser.
1295
1296         * MiniBrowser/efl/main.c:
1297         (url_from_user_input):
1298         (url_load_from_user_input):
1299         (on_url_bar_activated):
1300         (elm_main):
1301
1302 2015-06-09  Hyungwook Lee  <hyungwook.lee@navercorp.com>
1303
1304         Implement dumpProgressFinishedCallback() for Win layoutTestController.
1305         https://bugs.webkit.org/show_bug.cgi?id=66773
1306
1307         Reviewed by Darin Adler.
1308
1309         * DumpRenderTree/win/FrameLoadDelegate.cpp:
1310         * DumpRenderTree/win/FrameLoadDelegate.h:
1311
1312 2015-06-09  Ryosuke Niwa  <rniwa@webkit.org>
1313
1314         run-benchmark should either checkout JetStream 1.0.1 or support running the latest version
1315         https://bugs.webkit.org/show_bug.cgi?id=145764
1316
1317         Reviewed by Darin Adler.
1318
1319         Added the support for checkout a subversion directory in run-benchmark and used in the plans for
1320         JetStream and SunSpider.
1321
1322         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1323         (GenericBenchmarkBuilder):
1324         (GenericBenchmarkBuilder.prepare): Instead of taking each argument from benchmark plan, just accept
1325         the whole JSON as the input.
1326         (GenericBenchmarkBuilder._checkoutWithSubverion): Added.
1327         (GenericBenchmarkBuilder._applyPatch): Check the existence of benchmark_patch in prepare() instead.
1328         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1329         (BenchmarkRunner.execute): Removed the check for having either 'local_copy' or 'remote_archive' in
1330         a benchmark plan now that it's checkedi in GenericBenchmarkBuilder.prepare.
1331         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
1332         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
1333
1334 2015-06-09  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1335
1336         Remove ewstool scripts used by chromium port
1337         https://bugs.webkit.org/show_bug.cgi?id=145789
1338
1339         Reviewed by Csaba Osztrogonác.
1340
1341         * EWSTools/GoogleComputeEngine/build-chromium-ews.sh: Removed.
1342         * EWSTools/GoogleComputeEngine/build-commit-queue.sh: Removed.
1343         * EWSTools/GoogleComputeEngine/build-cr-linux-debug-ews.sh: Removed.
1344         * EWSTools/GoogleComputeEngine/build-feeder-style-sheriffbot.sh: Removed.
1345         * EWSTools/GoogleComputeEngine/findzone.sh: Removed.
1346
1347 2015-06-09  Michał Pakuła vel Rutka  <m.pakula@samsung.com>
1348
1349         Unreviewed, updated my list of email addresses.
1350
1351         * Scripts/webkitpy/common/config/contributors.json:
1352
1353 2015-06-09  Csaba Osztrogonác  <ossy@webkit.org>
1354
1355         [cmake] Fix the style issues in cmake project files
1356         https://bugs.webkit.org/show_bug.cgi?id=145755
1357
1358         Reviewed by Darin Adler.
1359
1360         * TestWebKitAPI/CMakeLists.txt:
1361         * TestWebKitAPI/PlatformEfl.cmake:
1362
1363 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1364
1365         Fix a typo in r185345.
1366
1367         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1368         (OSXSafariDriver.closeBrowsers):
1369
1370 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1371
1372         Yet another unreviewed build fix :(
1373
1374         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1375         (OSXSafariDriver):
1376         (OSXSafariDriver.launchUrl):
1377         (OSXSafariDriver.closeBrowsers):
1378
1379 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1380
1381         Unreviewed build fix. Initialize result in the case things blow up below.
1382
1383         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1384         (BenchmarkRunner.execute):
1385
1386 2015-06-08  Ryosuke Niwa  <rniwa@webkit.org>
1387
1388         Partially revert and fix after r185243.
1389
1390         * Scripts/benchmark_runner/benchmark_runner.py:
1391         * Scripts/run-benchmark:
1392
1393 2015-06-08  Daniel Bates  <dabates@apple.com>
1394
1395         Many LayoutTests/http tests time out in DumpRenderTree
1396         https://bugs.webkit.org/show_bug.cgi?id=145770
1397         <rdar://problem/19593910>
1398
1399         Reviewed by Alexey Proskuryakov.
1400
1401         * DumpRenderTree/ios/Info.plist: Add ATS key.
1402         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1403         (-[LTRelayController _environmentVariables]): Copy environment variables LOCAL_RESOURCE_ROOT
1404         and DUMPRENDERTREE_TEMP to the simulator environment to avoid assertion failures in tests
1405         that make use of testRunner.pathToLocalResource().
1406
1407 2015-06-08  Csaba Osztrogonác  <ossy@webkit.org>
1408
1409         [GTK] Fix parentheses warning in TestWebKitWebView.cpp
1410         https://bugs.webkit.org/show_bug.cgi?id=145759
1411
1412         Reviewed by Carlos Garcia Campos.
1413
1414         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1415         (testWebViewSave):
1416
1417 2015-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
1418
1419         [GTK] Add editor mode to MiniBrowser
1420         https://bugs.webkit.org/show_bug.cgi?id=145595
1421
1422         Reviewed by Sergio Villar Senin.
1423
1424         It loads an empty editable web view with an edit toolbar. It makes
1425         easier to test the editor, editing commands and input methods.
1426
1427         * MiniBrowser/gtk/BrowserWindow.c:
1428         (editingCommandCallback):
1429         (browserWindowSetupEditorToolbar):
1430         (browserWindowConstructed):
1431         * MiniBrowser/gtk/main.c:
1432         (createBrowserWindow):
1433
1434 2015-06-05  Zalan Bujtas  <zalan@apple.com>
1435
1436         From r185273 on WTF::RefCounter exposes the actual refcount instead of a boolean value.
1437
1438         Reviewed by Dan Bernstein.
1439
1440         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1441         (TestWebKitAPI::TEST):
1442
1443 2015-06-05  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1444
1445         [EFL] API test has been broken since r184357
1446         https://bugs.webkit.org/show_bug.cgi?id=145635
1447
1448         Reviewed by Darin Adler.
1449
1450         r184357 suppress cmake build warning using TARGET_FILE property. However
1451         many EFL API test cases have been broken after applying it.
1452
1453         * TestWebKitAPI/CMakeLists.txt:
1454
1455 2015-06-05  Anders Carlsson  <andersca@apple.com>
1456
1457         Make the network cache directory part of WKContextConfigurationRef
1458         https://bugs.webkit.org/show_bug.cgi?id=145711
1459
1460         Reviewed by Antti Koivisto.
1461
1462         * WebKitTestRunner/TestController.cpp:
1463         (WTR::TestController::initialize):
1464
1465 2015-06-05  Anders Carlsson  <andersca@apple.com>
1466
1467         Make the application cache directory part of WKContextConfigurationRef
1468         https://bugs.webkit.org/show_bug.cgi?id=145704
1469
1470         Reviewed by Geoffrey Garen.
1471
1472         * WebKitTestRunner/TestController.cpp:
1473         (WTR::TestController::initialize):
1474
1475 2015-06-04  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1476
1477         check-webkit-style should recommend using nullptr instead of recommending using 0 for the null pointer in C++ code.
1478         https://bugs.webkit.org/show_bug.cgi?id=145680
1479
1480         Reviewed by Brent Fulgham.
1481
1482         * Scripts/webkitpy/style/checkers/cpp.py:
1483         (check_for_null):
1484         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1485         (WebKitStyleTest.test_null_false_zero):
1486
1487 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1488
1489         Make the web server more robust to timing issues..
1490
1491         Reviewed by Ryosuke Niwa.
1492
1493         Cleaned up exception handling.
1494         Test server is actually serving pages before returning.
1495         Clean up some style issues.
1496
1497         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1498         * Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py:
1499         (SimpleHTTPServerDriver.__init__):
1500         (SimpleHTTPServerDriver.serve): check output, wait for pages to serve
1501         (SimpleHTTPServerDriver.baseUrl):
1502         (SimpleHTTPServerDriver.fetchResult):
1503         (SimpleHTTPServerDriver.killServer):
1504         (SimpleHTTPServerDriver.getReturnCode):
1505
1506 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1507
1508
1509         Add errors to run-benchmark exception handling.
1510
1511         Reviewed by Ryosuke Niwa.
1512
1513         * Scripts/run-benchmark:
1514         (main):
1515         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
1516         (GenericBenchmarkBuilder.prepare):
1517         (GenericBenchmarkBuilder._runCreateScript):
1518         (GenericBenchmarkBuilder._applyPatch):
1519         (GenericBenchmarkBuilder.clean):
1520         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1521         (BenchmarkRunner.__init__):
1522         (BenchmarkRunner.execute):
1523         (BenchmarkRunner):
1524         (BenchmarkRunner.cleanup):
1525         * Scripts/webkitpy/benchmark_runner/generic_factory.py:
1526         (GenericFactory.iterateGetItem):
1527         (GenericFactory.create):
1528         * Scripts/webkitpy/benchmark_runner/utils.py:
1529         (loadModule):
1530         (loadJSONFromFile):
1531         (forceRemove):
1532
1533 2015-06-05  Stephanie Lewis  <slewis@apple.com>
1534
1535         Streamline run-benchmark browser
1536
1537         Reviewed by Ryosuke Niwa.
1538
1539         Add Caffeinate so computer won't sleep while running.
1540         Remove calls to collect output since we were just dumping to stdout anyway.
1541         Add xpc dyld_path.
1542         Default to system safari.
1543
1544         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
1545         (OSXBrowserDriver.launchProcess):
1546         (OSXBrowserDriver.terminateProcesses):
1547         (OSXBrowserDriver):
1548         (OSXBrowserDriver.launchCaffeinateForProcess):
1549         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
1550         (OSXSafariDriver.launchUrl):
1551         (OSXSafariDriver.closeBrowsers):
1552
1553 2015-06-04  Benjamin Poulain  <bpoulain@apple.com>
1554
1555         Combine tiny DFAs into slightly larger ones
1556         https://bugs.webkit.org/show_bug.cgi?id=145572
1557
1558         Reviewed by Alex Christensen.
1559
1560         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1561         * TestWebKitAPI/Tests/WebCore/DFACombiner.cpp: Added.
1562         (TestWebKitAPI::DFACombinerTest::SetUp):
1563         (TestWebKitAPI::combine):
1564         (TestWebKitAPI::TEST_F):
1565         * TestWebKitAPI/Tests/WebCore/DFAHelpers.h: Copied from Source/WebCore/contentextensions/DFA.h.
1566         (TestWebKitAPI::countLiveNodes):
1567         (TestWebKitAPI::createNFAs):
1568         (TestWebKitAPI::buildDFAFromPatterns):
1569         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
1570         (TestWebKitAPI::countLiveNodes): Deleted.
1571         (TestWebKitAPI::createNFAs): Deleted.
1572         (TestWebKitAPI::buildDFAFromPatterns): Deleted.
1573
1574 2015-06-04  Alexey Proskuryakov  <ap@apple.com>
1575
1576         WebKitTestRunner leaks strings in generateWhitelist()
1577         https://bugs.webkit.org/show_bug.cgi?id=145665
1578
1579         Reviewed by Myles C. Maxfield.
1580
1581         * WebKitTestRunner/mac/TestControllerMac.mm:
1582         (WTR::generateWhitelist):
1583
1584 2015-06-03  Yusuke Suzuki  <utatane.tea@gmail.com>
1585
1586         Fix options in build-jsc for CMake builds
1587         https://bugs.webkit.org/show_bug.cgi?id=145636
1588
1589         Reviewed by Gyuyoung Kim.
1590
1591         CMake only accepts -DXXX=YYY style options.
1592         And ensured that ENABLE_JIT=OFF when specifying `--cloop`.
1593
1594         * Scripts/build-jsc:
1595
1596 2015-06-03  Matthew Daiter  <mdaiter@apple.com>
1597
1598         Added a patch so that the colors displayed on the page could be toggled
1599         in case people need accessibility colors displayed in their browser.
1600         https://bugs.webkit.org/show_bug.cgi?id=145570
1601         <rdar://problem/20994468>
1602
1603         Added in CSS colors and toggle buttons for checkmarks in the page, so that
1604         the page could be rendered in a specific way for accessibility needs if needed.
1605
1606         Reviewed by Alexey Proskuryakov.
1607
1608         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1609         (updateHiddenPlatforms):
1610         (applyAccessibilityColorSetting): Initial loading of accessibility colors if necessary
1611         (toggleAccessibilityColors): Toggle colors on and off
1612         (documentReady): Needed to make changes to the initialization
1613         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
1614         (a:hover):
1615         (div.cellButton, div.accessibilityButton): Added in similar properties for cellButton and accessibilityButton
1616         (div.cellButton.hide, div.accessibilityButton.hide):
1617         (div.cellButton.unhide, div.accessibilityButton.unhide):
1618         (.settings-visible div.accessibilityButton.hide, .settings-visible div.accessibilityButton.unhide):
1619         (.popover-tracking:hover):
1620         (.accessibilityButton):
1621         (div.cellButton): Deleted.
1622         (div.cellButton.hide): Deleted.
1623         (div.cellButton.unhide): Deleted.
1624         (.settings-visible div.cellButton.hide, .settings-visible div.cellButton.unhide): Deleted.
1625         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
1626         (.status-line.neutral .bubble):
1627         (.status-line.unauthorized .bubble):
1628         (.status-line.danger .bubble.pictogram):
1629         (.status-line.bad .bubble.pictogram):
1630         (.status-line.no-bubble .message):
1631         (.status-line.bad .bubble):
1632         (.status-line.good .bubble):
1633         (.status-line.good .message):
1634         (.status-line.bad .message):
1635         (body.accessibility-colors .status-line.good .bubble):
1636         (body.accessibility-colors .status-line.bad .bubble):
1637         (body.accessibility-colors .status-line.good .message):
1638         (body.accessibility-colors .status-line.bad .message):
1639         (.status-line.danger .message):
1640         (.status-line.unauthorized .message):
1641
1642 2015-06-03  Ryosuke Niwa  <rniwa@webkit.org>
1643
1644         Unreviewed build fix for Dromaeo.
1645
1646         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1647         (BenchmarkResults._aggregate_results_for_test):
1648
1649 2015-06-03  Anders Carlsson  <andersca@apple.com>
1650
1651         Fix build.
1652
1653         * DumpRenderTree/mac/TestRunnerMac.mm:
1654
1655 2015-06-03  Daniel Bates  <dabates@apple.com>
1656
1657         WebKit2.TextFieldDidBeginAndEndEditing is flaky on Mac
1658         https://bugs.webkit.org/show_bug.cgi?id=145616
1659
1660         Skip the test on Mac for now to avoid having the bots turn red due to the flakiness
1661         of the test. Further investigation is needed.
1662
1663         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp:
1664         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp:
1665
1666 2015-06-03  Brady Eidson  <beidson@apple.com>
1667
1668         REGRESSION (r183498): Certain types of frame loads in iframes with <base target="_blank"> can open urls in new window/tabs
1669         https://bugs.webkit.org/show_bug.cgi?id=145580
1670
1671         Reviewed by Mark Lam.
1672
1673         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1674         (WTR::InjectedBundlePage::didSameDocumentNavigationForFrame): Implement the dump for "didChangeLocationWithinPageForFrame"
1675
1676 2015-06-03  Alexey Proskuryakov  <ap@apple.com>
1677
1678         Attempt to fix CSSPropertyParserTest.GridTrackLimits API test after http://trac.webkit.org/r185147
1679
1680         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
1681         (TestWebKitAPI::TEST): Update the syntax.
1682
1683 2015-06-02  Mark Lam  <mark.lam@apple.com>
1684
1685         build-jsc's --cloop option is broken.
1686         https://bugs.webkit.org/show_bug.cgi?id=145516
1687
1688         Reviewed by Darin Adler.
1689
1690         * Scripts/build-jsc:
1691         - Make sure to disable the JIT when --cloop is specified.
1692           Did analogous fix for --ftljit.
1693
1694 2015-06-02  Daniel Bates  <dabates@apple.com>
1695
1696         Update ATS keys used in MiniBrowser and WebKitTestRunnerApp
1697
1698         Rubber-stamped by Alexey Proskuryakov.
1699
1700         * MiniBrowser/mac/Info.plist:
1701         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1702
1703 2015-06-01  Commit Queue  <commit-queue@webkit.org>
1704
1705         Unreviewed, rolling out r185066.
1706         https://bugs.webkit.org/show_bug.cgi?id=145543
1707
1708         it breaks the FTL JIT builds with a local checkout of llvm
1709         (Requested by pizlo on #webkit).
1710
1711         Reverted changeset:
1712
1713         "build-jsc's --cloop option is broken."
1714         https://bugs.webkit.org/show_bug.cgi?id=145516
1715         http://trac.webkit.org/changeset/185066
1716
1717 2015-06-01  Daniel Bates  <dabates@apple.com>
1718
1719         Notify client that we began editing when text field is focused
1720         https://bugs.webkit.org/show_bug.cgi?id=145439
1721         <rdar://problem/21142108>
1722
1723         Reviewed by Anders Carlsson.
1724
1725         Add API test to ensure that we dispatch textFieldDid{Begin, End}Editing callbacks when
1726         a text field is focused and defocused.
1727
1728         * TestWebKitAPI/CMakeLists.txt:
1729         * TestWebKitAPI/PlatformEfl.cmake:
1730         * TestWebKitAPI/PlatformGTK.cmake:
1731         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1732         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing.cpp: Added.
1733         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didReceiveMessageFromInjectedBundle):
1734         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::didFinishLoadForFrame):
1735         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setInjectedBundleClient):
1736         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::setPageLoaderClient):
1737         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::nullJavaScriptCallback):
1738         (TestWebKitAPI::WebKit2TextFieldBeginAndEditEditingTest::executeJavaScriptAndCheckDidReceiveMessage):
1739         (TestWebKitAPI::TEST_F):
1740         * TestWebKitAPI/Tests/WebKit2/TextFieldDidBeginAndEndEditing_Bundle.cpp: Added.
1741         (TestWebKitAPI::textFieldDidBeginEditing):
1742         (TestWebKitAPI::textFieldDidEndEditing):
1743         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::TextFieldDidBeginAndEndEditingEventsTest):
1744         (TestWebKitAPI::TextFieldDidBeginAndEndEditingEventsTest::didCreatePage):
1745         * TestWebKitAPI/Tests/WebKit2/input-focus-blur.html: Added.
1746
1747 2015-06-01  Alex Christensen  <achristensen@webkit.org>
1748
1749         [Content Extensions] resource-type and load-type should be independent.
1750         https://bugs.webkit.org/show_bug.cgi?id=145528
1751         rdar://problem/21190765
1752
1753         Reviewed by Benjamin Poulain.
1754
1755         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
1756         (TestWebKitAPI::TEST_F):
1757
1758 2015-06-01  Daniel Bates  <dabates@apple.com>
1759
1760         Add ATS keys to WebKitTestRunnerApp
1761         https://bugs.webkit.org/show_bug.cgi?id=145519
1762
1763         Reviewed by Alexey Proskuryakov.
1764
1765         Add ATS keys for WebKitTestRunnerApp as we did for MiniBrowser in bug #145141.
1766
1767         * WebKitTestRunner/WebKitTestRunnerApp/WebKitTestRunnerApp-Info.plist:
1768
1769 2015-06-01  Brady Eidson  <beidson@apple.com>
1770
1771         Add WKTR support for "should open external URLs".
1772         https://bugs.webkit.org/show_bug.cgi?id=145505
1773
1774         Reviewed by Darin Adler.
1775
1776         - Add a new option to "queueLoad" to allow javascript to queue a load that has the
1777           "should open external URLs" bit set.
1778
1779         - Add a new "dumpPolicyDelegateCallbacks" call to dump the NavigationAction in
1780           the policy delegate, including whether or not the bit was set.
1781
1782         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1783         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1784         (WTR::TestRunner::queueLoad):
1785         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1786         (WTR::TestRunner::dumpPolicyDelegateCallbacks):
1787         (WTR::TestRunner::shouldDumpPolicyCallbacks):
1788
1789         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1790         (WTR::InjectedBundle::queueLoad):
1791         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1792
1793         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1794         (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
1795
1796         * WebKitTestRunner/TestInvocation.cpp:
1797         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
1798
1799         * WebKitTestRunner/WorkQueueManager.cpp:
1800         (WTR::WorkQueueManager::queueLoad):
1801         * WebKitTestRunner/WorkQueueManager.h:
1802
1803 2015-06-01  Mark Lam  <mark.lam@apple.com>
1804
1805         build-jsc's --cloop option is broken.
1806         https://bugs.webkit.org/show_bug.cgi?id=145516
1807
1808         Reviewed by Darin Adler.
1809
1810         * Scripts/build-jsc:
1811         - Make sure to disable the JIT when --cloop is specified.
1812           Did analogous fix for --ftljit.
1813
1814 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1815
1816         [CMake] check-webkit-style provides bogus explanation for alphabetical sorting error
1817         https://bugs.webkit.org/show_bug.cgi?id=144959
1818
1819         Reviewed by Darin Adler.
1820
1821         * Scripts/webkitpy/style/checkers/cmake.py:
1822         (CMakeChecker.check): Use enumerate instead of xrange.
1823         (CMakeChecker._check_list_order): Use enumerate instead of incrementing line_number manually.
1824         * Scripts/webkitpy/style/checkers/cmake_unittest.py:
1825         (CMakeCheckerTest.test_check): Update the expected results.
1826
1827 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1828
1829         Fix the webkitpy scm unittests after r174051
1830         https://bugs.webkit.org/show_bug.cgi?id=145511
1831
1832         Reviewed by Darin Adler.
1833
1834         * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
1835         (GitTestWithMock.make_scm):
1836
1837 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1838
1839         EWS provides misleading information for not applyable patches
1840         https://bugs.webkit.org/show_bug.cgi?id=145307
1841
1842         Reviewed by Alexey Proskuryakov.
1843
1844         * Scripts/svn-apply: Die if there is no applyable diff in the patch.
1845
1846 2015-06-01  Alexey Proskuryakov  <ap@apple.com>
1847
1848         Further tweak results of WebKit1.StringTruncator after r184965.
1849
1850         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
1851
1852 2015-06-01  Csaba Osztrogonác  <ossy@webkit.org>
1853
1854         [cmake] Suppress unused parameter warnings in WebKit2 and TestNetscapePlugIn
1855         https://bugs.webkit.org/show_bug.cgi?id=145264
1856
1857         Reviewed by Carlos Garcia Campos.
1858
1859         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt: Set extra compiler flags and suppress only unused parameter warnings.
1860
1861 2015-05-30  Ryosuke Niwa  <rniwa@webkit.org>
1862
1863         Unreviewed build fix after r185014. Some tests only have subtests and not metrics.
1864
1865         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1866         (BenchmarkResults._lint_subtest_results):
1867         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py:
1868         (test_aggregate_nested_results):
1869         (test_lint_results):
1870         * WinLauncher/WinLauncher.vcxproj/WinLauncherResource.h:
1871
1872 2015-05-29  Ryosuke Niwa  <rniwa@webkit.org>
1873
1874         run-benchmark should print out the results
1875         https://bugs.webkit.org/show_bug.cgi?id=145398
1876
1877         Reviewed by Antti Koivisto.
1878
1879         Added BenchmarkResults to compute and format the aggregated values. It also does the syntax/semantic check
1880         of the output to catch early errors.
1881
1882         * Scripts/webkitpy/benchmark_runner/benchmark_results.py: Added.
1883         (BenchmarkResults): Added.
1884         (BenchmarkResults.__init__): Added.
1885         (BenchmarkResults.format): Added.
1886         (BenchmarkResults._format_tests): Added. Used by BenchmarkResults.format.
1887         (BenchmarkResults._format_values): Formats a list of values measured for a given metric on a given test.
1888         Uses the sample standard deviation to compute the significant figures for the value.
1889         (BenchmarkResults._unit_from_metric): Added.
1890         (BenchmarkResults._aggregate_results): Added.
1891         (BenchmarkResults._aggregate_results_for_test): Added.
1892         (BenchmarkResults._flatten_list): Added.
1893         (BenchmarkResults._subtest_values_by_config_iteration): Added. Organizes values measured for subtests
1894         by the iteration number so that i-th array contains values for all subtests at i-th iteration.
1895         (BenchmarkResults._aggregate_values): Added.
1896         (BenchmarkResults._lint_results): Added.
1897         (BenchmarkResults._lint_subtest_results): Added.
1898         (BenchmarkResults._lint_aggregator_list): Added.
1899         (BenchmarkResults._lint_configuration): Added.
1900         (BenchmarkResults._lint_values): Added.
1901         (BenchmarkResults._is_numeric): Added.
1902         * Scripts/webkitpy/benchmark_runner/benchmark_results_unittest.py: Added.
1903         (BenchmarkResultsTest):
1904         (BenchmarkResultsTest.test_init):
1905         (BenchmarkResultsTest.test_format):
1906         (test_format_values_with_large_error):
1907         (test_format_values_with_small_error):
1908         (test_format_values_with_time):
1909         (test_format_values_with_no_error):
1910         (test_format_values_with_small_difference):
1911         (test_aggregate_results):
1912         (test_aggregate_results_with_gropus):
1913         (test_aggregate_nested_results):
1914         (test_lint_results):
1915         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1916         (BenchmarkRunner.execute): Added a call to show_results
1917         (BenchmarkRunner.wrap): Only dump the merged JSON when debugging.
1918         (BenchmarkRunner.show_results): Added.
1919
1920 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
1921
1922         run_benchmark should have an option to specify the number of runs
1923         https://bugs.webkit.org/show_bug.cgi?id=145091
1924
1925         Reviewed by Antti Koivisto.
1926
1927         Added --count option.
1928
1929         * Scripts/run-benchmark:
1930         (main):
1931         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1932         (BenchmarkRunner.__init__):
1933
1934 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
1935
1936         Update results of WebKit1.StringTruncator after r184965. I missed one letter.
1937
1938         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
1939
1940 2015-05-28  Alexey Proskuryakov  <ap@apple.com>
1941
1942         Update results of WebKit1.StringTruncator after r184965.
1943
1944         * TestWebKitAPI/Tests/mac/StringTruncator.mm: (TestWebKitAPI::TEST):
1945
1946 2015-05-28  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
1947
1948         Unreviewed, updated my list of email addresses.
1949
1950         * Scripts/webkitpy/common/config/contributors.json:
1951
1952 2015-05-27  Dean Jackson  <dino@apple.com>
1953
1954         img.currentSrc problem in strict mode with old picturefill
1955         https://bugs.webkit.org/show_bug.cgi?id=144095
1956         <rdar://problem/21087013>
1957
1958         Reviewed by Simon Fraser.
1959
1960         Add a PICTURE_SIZES flag.
1961
1962         * Scripts/webkitperl/FeatureList.pm:
1963
1964 2015-05-26  Dana Burkart  <dburkart@apple.com>
1965
1966         Fixes compatibility issues with recent dashboard cleanup.
1967         https://bugs.webkit.org/show_bug.cgi?id=144814
1968
1969         Reviewed by Alexey Proskuryakov.
1970
1971         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
1972         (BuildbotStaticAnalyzerQueueView):
1973         (BuildbotStaticAnalyzerQueueView.prototype.update):
1974         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1975         (documentReady):
1976
1977 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
1978
1979         Botwatcher's dashboard doesn't show JSC test regressions on Apple bots
1980         https://bugs.webkit.org/show_bug.cgi?id=143091
1981         rdar://problem/19330328
1982
1983         Reviewed by Darin Adler and Timothy Hatcher.
1984
1985         We have many of these, which are hard to fit on the dashboard. Added a view that
1986         collapses to a single green bubble when everything is good, and expands when there
1987         are failures (or manually).
1988
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/index.html: Added BuildbotCombinedQueueView.js
1990
1991         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1992         (Buildbot.prototype.set isAuthenticated):
1993         (Buildbot.prototype._normalizeQueueInfo):
1994         (Buildbot.prototype._normalizeQueuesInfo):
1995         (Buildbot.prototype.updateQueues):
1996         Moved queue info normalization here from BuildbitQueue. The latter is a model class
1997         that shouldn't have to know about presentation, and this lets us leep the knowledge
1998         about combined queues out if it. Later, we can refactor existing code, and move out
1999         all knowledge about headings and such.
2000
2001         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
2002         Added the new view. It's not quite universal, and doesn't have as helpful popovers
2003         as other views, but we can extend it when/if we use it for more than JSC.
2004
2005         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2006         (BuildbotQueue): Now that info is normalized before creating a queue, don't do that here.
2007
2008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2009         (documentReady): Added support for combined queues. These are currently always ending up
2010         in Other column, but it's easy to customize in the future if we need to.
2011
2012         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2013         (WebKitBuildbot): Added JSC queus.
2014
2015         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:
2016         (.combined-queue-popover):
2017         (.combined-queue-popover .revision):
2018         Added styles for the combined view.
2019
2020 2015-05-26  Dan Bernstein  <mitz@apple.com>
2021
2022         Changed a file to use Unix line endings.
2023
2024         * LayoutTestRelay/Configurations/DebugRelease.xcconfig:
2025
2026 2015-05-26  Dan Bernstein  <mitz@apple.com>
2027
2028         <rdar://problem/21104551> Update build settings
2029
2030         Reviewed by Anders Carlsson.
2031
2032         * ContentExtensionTester/Configurations/DebugRelease.xcconfig:
2033         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2034         * MiniBrowser/Configurations/DebugRelease.xcconfig:
2035         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2036         * WebEditingTester/Configurations/DebugRelease.xcconfig:
2037         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2038         * asan/asan.xcconfig:
2039
2040 2015-05-26  Anders Carlsson  <andersca@apple.com>
2041
2042         Fix build.
2043
2044         * WebKitTestRunner/mac/EventSenderProxy.mm:
2045         (WTR::EventSenderProxy::mouseForceDown):
2046         (WTR::EventSenderProxy::mouseForceUp):
2047         (WTR::EventSenderProxy::mouseForceChanged):
2048
2049 2015-05-26  Alexey Proskuryakov  <ap@apple.com>
2050
2051         build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
2052         https://bugs.webkit.org/show_bug.cgi?id=145342
2053
2054         Reviewed by Darin Adler.
2055
2056         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2057         (BuildbotIteration.prototype._parseData):
2058
2059 2015-05-26  Milan Crha  <mcrha@redhat.com>
2060
2061         [GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
2062         https://bugs.webkit.org/show_bug.cgi?id=138134
2063
2064         Reviewed by Žan Doberšek.
2065
2066         * gtk/generate-inspector-gresource-manifest.py:
2067         (get_filenames): Command line with expanded resources exceeds 32KB, which
2068         is a limit on Windows. It's better to expand wildcards inside the python script.
2069
2070 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2071
2072         [GTK] Add construct property to WebKitWebContext to set the IndexedDB database directory
2073         https://bugs.webkit.org/show_bug.cgi?id=140882
2074
2075         Reviewed by Gustavo Noronha Silva.
2076
2077         Make sure unit tests write IndexedDB databases to the temporary
2078         directory, and add a test case to check that the directory is
2079         correctly created at the expected path.
2080
2081         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
2082         (testWebContextConfiguration):
2083         (serverCallback):
2084         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2085         (Test::Test):
2086
2087 2015-05-25  Carlos Garcia Campos  <cgarcia@igalia.com>
2088
2089         [GTK] Enable IndexedDB
2090         https://bugs.webkit.org/show_bug.cgi?id=98932
2091
2092         Reviewed by Žan Doberšek.
2093
2094         * Scripts/webkitperl/FeatureList.pm: Enable IndexedDB for the GTK port.
2095
2096 2015-05-24  Sam Weinig  <sam@webkit.org>
2097
2098         Crash when using a removed ScriptMessageHandler
2099         <rdar://problem/20888499>
2100         https://bugs.webkit.org/show_bug.cgi?id=145359
2101
2102         Reviewed by Dan Bernstein.
2103
2104         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2105         Add tests for removing script message handlers.
2106
2107 2015-05-23  Dan Bernstein  <mitz@apple.com>
2108
2109         Remove unused definitions of WEBKIT_VERSION_MIN_REQUIRED
2110         https://bugs.webkit.org/show_bug.cgi?id=145345
2111
2112         Reviewed by Sam Weinig.
2113
2114         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2115         * LayoutTestRelay/Configurations/Base.xcconfig:
2116         * TestWebKitAPI/Configurations/Base.xcconfig:
2117         * WebKitTestRunner/Configurations/Base.xcconfig:
2118
2119 2015-05-23  Yusuke Suzuki  <utatane.tea@gmail.com>
2120
2121         Introduce UniquedStringImpl and SymbolImpl to separate symbolic strings from AtomicStringImpl
2122         https://bugs.webkit.org/show_bug.cgi?id=144848
2123
2124         Reviewed by Darin Adler.
2125
2126         Use UniquedStringImpl, SymbolImpl and AtomicStringImpl.
2127
2128         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2129
2130 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2131
2132         Fix one more merge error in static analyzer support.
2133
2134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2135         (BuildbotStaticAnalyzerQueueView):
2136
2137 2015-05-22  Dana Burkart  <dburkart@apple.com>
2138
2139         Fix internal dashboard breakage from recent commit.
2140         https://bugs.webkit.org/show_bug.cgi?id=144814
2141
2142         Unreviewed build fix.
2143
2144         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js:
2145         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2146         (BuildbotStaticAnalyzerQueueView.prototype.update):
2147
2148 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2149
2150         REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
2151         https://bugs.webkit.org/show_bug.cgi?id=130463
2152         rdar://problem/20461342
2153
2154         Reviewed by Tim Horton.
2155
2156         This was more of a timing related flakiness than an actual OS version specific bug,
2157         we weren't getting window visibility notifications.
2158
2159         I will look into adding this function call to DumpRenderTree separately, layout tests
2160         might actually rely on the broken behavior.
2161
2162         * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
2163         (TestWebKitAPI::TEST_F):
2164         * TestWebKitAPI/mac/mainMac.mm:
2165         (main):
2166
2167 2015-05-22  Dana Burkart  <dburkart@apple.com>
2168
2169         Add missing file from r184804 (mis-applied diff).
2170         https://bugs.webkit.org/show_bug.cgi?id=144814
2171
2172         Reviewed by Alexey Proskuryakov.
2173
2174         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotStaticAnalyzerQueueView.js: Added.
2175         (BuildbotStaticAnalyzerQueueView):
2176         (BuildbotStaticAnalyzerQueueView.prototype.update.appendStaticAnalyzerQueueStatus):
2177         (BuildbotStaticAnalyzerQueueView.prototype.update):
2178
2179 2015-05-22  Dana Burkart  <dburkart@apple.com>
2180
2181         Add support to the botwatchers dashboard for a static analyzer bot.
2182         https://bugs.webkit.org/show_bug.cgi?id=144814
2183
2184         Reviewed by Alexey Proskuryakov.
2185
2186         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
2187         scan-build should be considered a productive step.
2188
2189         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:
2190         (BuildbotQueue):
2191         Adds support for the staticAnalyzer property
2192
2193         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
2194         (BuildbotTestResults.prototype._parseResults):
2195         Get bug count from the scan-build step output
2196
2197         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2198         (documentReady):
2199         Rename the performance column 'Other', and merge the current 'Other' column with it.
2200
2201         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
2202         (WebKitBuildbot):
2203         Now that performance bots are part of the 'Other' column, give them better headings.
2204
2205 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2206
2207         Turn on autosaving of toolbar configuration in MiniBrowser
2208
2209         Rubber-stamped by Dan Bernstein.
2210
2211         * MiniBrowser/mac/BrowserWindow.xib:
2212
2213 2015-05-22  Alexey Proskuryakov  <ap@apple.com>
2214
2215         build.webkit.org/dashboard: Simplify BuildbotQueueView creation code
2216         https://bugs.webkit.org/show_bug.cgi?id=145297
2217
2218         Reviewed by Tim Horton.
2219
2220         This is a refactoring to simplify code, and to make it more logical.
2221
2222         It is up to the view to decide how to present the queues, and whether to split
2223         them into debug and release, or in some different way.
2224
2225         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
2226         (BuildbotBuilderQueueView.filterQueues):
2227         (BuildbotBuilderQueueView):
2228         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotLeaksQueueView.js:
2229         (BuildbotLeaksQueueView):
2230         (BuildbotLeaksQueueView.prototype.update):
2231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotPerformanceQueueView.js:
2232         (BuildbotPerformanceQueueView):
2233         (BuildbotPerformanceQueueView.prototype.update):
2234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
2235         (BuildbotQueueView):
2236         (BuildbotQueueView.prototype._updateQueues):
2237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
2238         (BuildbotTesterQueueView):
2239         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
2240         (documentReady):
2241
2242 2015-05-22  Tim Horton  <timothy_horton@apple.com>
2243
2244         Remove action menu support
2245         https://bugs.webkit.org/show_bug.cgi?id=145305
2246         <rdar://problem/21070771>
2247
2248         Reviewed by Anders Carlsson.
2249
2250         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2251         * TestWebKitAPI/Tests/WebKit2/action-menu-target.pdf: Removed.
2252         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Removed.
2253         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Removed.
2254         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Removed.
2255         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundleSPI.h: Removed.
2256         Remove the tests.
2257
2258 2015-05-22  Dan Bernstein  <mitz@apple.com>
2259
2260         Removed the Use Shrink To Fit button from the toolbar’s default set.
2261
2262         Rubber-stamped by Tim Horton.
2263
2264         * MiniBrowser/mac/BrowserWindow.xib:
2265
2266 2015-05-21  Joanmarie Diggs  <jdiggs@igalia.com>
2267
2268         AX: [GTK] Implement computedRoleString in AccessibilityUIElement
2269         https://bugs.webkit.org/show_bug.cgi?id=128420
2270
2271         Reviewed by Chris Fleizach.
2272
2273         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2274         (WTR::AccessibilityUIElement::computedRoleString): Implemented.
2275
2276 2015-05-21  Csaba Osztrogonác  <ossy@webkit.org>
2277
2278         [EFL] Bump libsoup version to 2.50.0
2279         https://bugs.webkit.org/show_bug.cgi?id=145127
2280
2281         Reviewed by Gyuyoung Kim.
2282
2283         * efl/jhbuild.modules:
2284         * efl/patches/soup-clang-warning-fix1.patch: Removed.
2285         * efl/patches/soup-clang-warning-fix2.patch: Removed.
2286
2287 2015-05-20  Zan Dobersek  <zdobersek@igalia.com>
2288
2289         [GTK] Move MainThreadGtk, RunLoopGtk, WorkQueueGtk under Source/WTF/wtf/glib/
2290         https://bugs.webkit.org/show_bug.cgi?id=145117
2291
2292         Reviewed by Csaba Osztrogonác.
2293
2294         Rename the WorkQueueGtk.cpp file to WorkQueueGLib.cpp, and move it under
2295         Tools/TestWebKitAPI/Tests/WTF/glib/.
2296
2297         * TestWebKitAPI/PlatformGTK.cmake:
2298         * TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp.
2299         (TestWebKitAPI::TEST):
2300
2301 2015-05-20  KwangHyuk Kim  <hyuki.kim@samsung.com>
2302
2303         [EFL] fix efreet error
2304         https://bugs.webkit.org/show_bug.cgi?id=143670
2305
2306         Reviewed by Gyuyoung Kim.
2307
2308         Fix efreet error by using external variable efreet_cache_update.
2309         As 0 value of efreet_cache_update prevents monitoring of icon and desktop cache,
2310         efreet error for efreet_cache does not occur.
2311
2312         * MiniBrowser/efl/main.c:
2313         (elm_main):
2314
2315 2015-05-20  Michael Saboff  <msaboff@apple.com>
2316
2317         Add option to run_jsc_stress_tests to disable JIT testing
2318         https://bugs.webkit.org/show_bug.cgi?id=145233
2319
2320         Reviewed by Mark Lam.
2321
2322         Added --no-jit option.
2323
2324         * Scripts/run-jsc-stress-tests:
2325
2326 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2327
2328         Use correct String for StringView in WTF API tests
2329         https://bugs.webkit.org/show_bug.cgi?id=145226
2330         rdar://problem/20361786
2331
2332         Reviewed by Benjamin Poulain.
2333
2334         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2335         (TestWebKitAPI::TEST):
2336         Use patternHolder for pattern.
2337
2338 2015-05-20  Alex Christensen  <achristensen@webkit.org>
2339
2340         [Content Extensions] Relax restrictions on triggers that match everything.
2341         https://bugs.webkit.org/show_bug.cgi?id=145069
2342
2343         Reviewed by Benjamin Poulain.
2344
2345         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2346         (TestWebKitAPI::TEST_F):
2347         Update and add tests for new possibilities with .*
2348
2349 2015-05-20  Rohit Kumar  <kumar.rohit@samsung.com>
2350
2351         [EFL][Minibrowser] Hide URL bar on fullscreen mode for HTML elements and browser window in WebKit EFL Minibrowser
2352         https://bugs.webkit.org/show_bug.cgi?id=144992
2353
2354         Reviewed by Gyuyoung Kim.
2355
2356         * MiniBrowser/efl/main.c:
2357         (toggle_window_fullscreen): Method to toggle between fullscreen and normal mode.
2358         (on_key_down):
2359         (on_fullscreen_enter):
2360         (on_fullscreen_exit):
2361         (window_create):
2362
2363 2015-05-19  Yusuke Suzuki  <utatane.tea@gmail.com>
2364
2365         Move AtomicStringImpl table related operations from AtomicString to AtomicStringImpl
2366         https://bugs.webkit.org/show_bug.cgi?id=145109
2367
2368         Reviewed by Darin Adler.
2369
2370         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2371         (TestWebKitAPI::TEST):
2372
2373 2015-05-19  Anders Carlsson  <andersca@apple.com>
2374
2375         Add alternate menu items for performing operations on the default data store
2376         https://bugs.webkit.org/show_bug.cgi?id=145184
2377
2378         Reviewed by Sam Weinig.
2379
2380         This makes it possible to test WKWebsiteDataStore code paths when there are no live web views
2381         associated with a data store.
2382
2383         * MiniBrowser/mac/AppDelegate.m:
2384         (-[BrowserAppDelegate fetchDefaultStoreWebsiteData:]):
2385         (-[BrowserAppDelegate fetchAndClearDefaultStoreWebsiteData:]):
2386         (-[BrowserAppDelegate clearDefaultStoreWebsiteData:]):
2387         * MiniBrowser/mac/MainMenu.xib:
2388
2389 2015-05-19  Csaba Osztrogonác  <ossy@webkit.org>
2390
2391         Fix tautological-compare warning in AtomicString.cpp
2392         https://bugs.webkit.org/show_bug.cgi?id=145120
2393
2394         Reviewed by Alexey Proskuryakov.
2395
2396         * TestWebKitAPI/Tests/WTF/AtomicString.cpp:
2397         (TestWebKitAPI::TEST): Removed always true assert.
2398
2399 2015-05-18  Csaba Osztrogonác  <ossy@webkit.org>
2400
2401         [EFL] Fix unsequenced warning in MiniBrowser's main.c
2402         https://bugs.webkit.org/show_bug.cgi?id=145123
2403
2404         Reviewed by Gyuyoung Kim.
2405
2406         * MiniBrowser/efl/main.c:
2407         (on_key_down):
2408
2409 2015-05-18  Daniel Bates  <dabates@apple.com>
2410
2411         prepare-ChangeLog reports function above deleted function as deleted; uninitialized value warning
2412         when staged non-empty file for commit
2413         https://bugs.webkit.org/show_bug.cgi?id=145082
2414
2415         Reviewed by Darin Adler.
2416
2417         Fixes two issues when running prepare-ChangeLog:
2418             1. The function above a deleted function is reported as changed.
2419             2. With a Git checkout of WebKit, a Perl uninitialized value warning is emitted when
2420             a new non-empty file is staged for commit (e.g. extractLineRangeBeforeAndAfterChange.pl,
2421             included in this patch).
2422
2423         Simplify code by using unified diff parsing logic for both SVN and Git support. Currently
2424         prepare-ChangeLog has logic to parse normal diff- and unified diff- chunk range lines as
2425         generated by `svn diff` and `git diff`, respectively. The logic for parsing these formats
2426         has correctness issues. We should make use of the VCSUtil::parseChunkRange() to parse
2427         chunk range lines of a unified diff as opposed to having specialized logic in prepare-ChangeLog.
2428         VCSUtil::parseChunkRange() has existing test coverage.
2429
2430         * Scripts/prepare-ChangeLog:
2431         (generateFunctionLists): Only add a line range to %line_ranges_before_changed, %line_ranges_after_changed
2432         when the beginning line number, ending line number >= 1. Modified for-loop condition to iterate over
2433         all the files represented by %line_ranges_before_changed and %line_ranges_after_changed so that we
2434         examine files that only have deletions. Currently this works as a side effect of the behavior of
2435         extractLineRangeAfterChange(), which always returns a well-formed (though nonsensical) line range for
2436         a change that represents a deletion (e.g. extractLineRangeAfterChange("@@ -166,6 +165,0 @@") => [165, 165]).
2437         (diffCommand): Generate a unified diff instead of a normal diff when using a SVN checkout of WebKit.
2438         (extractLineRangeAfterChange): Remove logic to parse a normal diff chunk range line and write
2439         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2440         We return (-1, -1) when the change represents a deletion.
2441         (extractLineRangeBeforeChange): Remove logic to parse a normal diff chunk range line and write
2442         the logic to parse a unified diff chunk range line in terms of VCSUtil::parseChunkRange().
2443         We return (-1, -1) when the change represents an addition.
2444         * Scripts/webkitperl/prepare-ChangeLog_unittest/extractLineRangeBeforeAndAfterChange.pl: Added;
2445         unit tests.
2446
2447 2015-05-18  Anders Carlsson  <andersca@apple.com>
2448
2449         Add ATS keys to MiniBrowser
2450         https://bugs.webkit.org/show_bug.cgi?id=145141
2451
2452         Reviewed by Sam Weinig.
2453
2454         * MiniBrowser/mac/Info.plist:
2455
2456 2015-05-17  David Kilzer  <ddkilzer@apple.com>
2457
2458         bisect-builds: Add 'retry' option when prompting whether the bug reproduced
2459         <http://webkit.org/b/145100>
2460
2461         Reviewed by Darin Adler.
2462
2463         * Scripts/bisect-builds:
2464         - Add PROMPT_ANSWER_* constants for yes/no/retry/broken prompt.
2465         - Switch to using PROMPT_RESPONSE_* constants when testing the
2466           value of $didReproduceBug.
2467         - Add do { } while loops to implement 'retry' mode.
2468         (promptForTest):
2469         - Switch to returning PROMPT_RESPONSE_* constants.
2470         - Add support for 'retry' response.
2471
2472 2015-05-16  Tanay C  <tanay.c@samsung.com>
2473
2474         [EFL][WK2] Minibrowser : Add search icon to search bar
2475         https://bugs.webkit.org/show_bug.cgi?id=139773
2476
2477         Reviewed by Gyuyoung Kim.
2478
2479         * MiniBrowser/efl/main.c:
2480         (search_icon_show): Added.
2481         (search_box_show): Modified.
2482
2483 2015-05-15  Ryosuke Niwa  <rniwa@webkit.org>
2484
2485         run_benchmark should have an option to specify the number of runs
2486         https://bugs.webkit.org/show_bug.cgi?id=145091
2487
2488         Reviewed by Stephanie Lewis.
2489
2490         Added --count option.
2491
2492         * Scripts/run-benchmark:
2493         (main):
2494         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2495         (BenchmarkRunner.__init__):
2496
2497 2015-05-15  Timothy Horton  <timothy_horton@apple.com>
2498
2499         Temporarily disable failing API test.
2500
2501         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2502         (TestWebKitAPI::TEST):
2503
2504 2015-05-15  Ravi Phaneendra Kasibhatla  <r.kasibhatla@samsung.com>
2505
2506         User interruption while running of run-webkit-tests should also generate results.html
2507         https://bugs.webkit.org/show_bug.cgi?id=122154
2508
2509         Reviewed by Csaba Osztrogonác.
2510
2511         Generation of results.html on execution of run-webkit-tests happens only
2512         on completion of entire layout tests run. It should be created even when
2513         the execution has been interrupted - either by user (by pressing Ctrl+C)
2514         or because of other interruptions (like exit-after-n-failures option).
2515
2516         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2517         (LayoutTestRunner.run_tests):
2518         * Scripts/webkitpy/layout_tests/controllers/manager.py:
2519         (Manager.run):
2520         * Scripts/webkitpy/layout_tests/models/test_run_results.py:
2521         (TestRunResults.__init__):
2522         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2523         (main):
2524         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2525         (RunTest.test_keyboard_interrupt):
2526         (MainTest.test_exception_handling):
2527
2528 2015-05-15  Csaba Osztrogonác  <ossy@webkit.org>
2529
2530         [buildbot] Fix the URL of the performance bots
2531         https://bugs.webkit.org/show_bug.cgi?id=145043
2532
2533         Reviewed by Ryosuke Niwa.
2534
2535         * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
2536
2537 2015-05-14  Timothy Horton  <timothy_horton@apple.com>
2538
2539         Add a layout mode that scales down the view to try to fit the document
2540         https://bugs.webkit.org/show_bug.cgi?id=145022
2541         <rdar://problem/19790341>
2542
2543         Reviewed by Dean Jackson.
2544
2545         * MiniBrowser/mac/BrowserWindow.xib:
2546         * MiniBrowser/mac/BrowserWindowController.h:
2547         * MiniBrowser/mac/WK2BrowserWindowController.m:
2548         (-[WK2BrowserWindowController toggleShrinkToFit:]):
2549         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]): Deleted.
2550         Switch to _WKLayoutModeDynamicSizeComputedFromMinimumDocumentSize.
2551
2552 2015-05-14  Michael Catanzaro  <mcatanzaro@igalia.com>
2553
2554         [CMake] Don't read the LOCATION property of targets
2555         https://bugs.webkit.org/show_bug.cgi?id=145018
2556
2557         Reviewed by Martin Robinson.
2558
2559         Use the TARGET_FILE_DIR generator expression to determine the location of the test injected
2560         bundle, rather than assuming that the LOCATION property of TestWebKitAPIInjectedBundle will
2561         be the same at configure-time as it is at generate-time.
2562
2563         * TestWebKitAPI/CMakeLists.txt:
2564
2565 2015-05-14  Myles C. Maxfield  <mmaxfield@apple.com>
2566
2567         Add String literal overloads to equalIgnoringASCIICase()
2568         https://bugs.webkit.org/show_bug.cgi?id=145008
2569
2570         Reviewed by Benjamin Poulain.
2571
2572         Test changes to WTF.
2573
2574         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2575         (WTF.StringImplEqualIgnoringASCIICaseBasic): Test const char*.
2576         (WTF.StringImplEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2577         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2578         (WTF.StringViewEqualIgnoringASCIICaseBasic): Ditto.
2579         (WTF.StringViewEqualIgnoringASCIICaseWithLatin1Characters): Ditto.
2580
2581 2015-05-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
2582
2583         SharedBuffer::createWithContentsOfFile should use map file routines
2584         https://bugs.webkit.org/show_bug.cgi?id=144192
2585
2586         Reviewed by Darin Adler.
2587
2588         Adding SharedBuffer and FileSystem Unit tests to Mac and GTK, not yet for EFL.
2589
2590         * TestWebKitAPI/PlatformGTK.cmake:
2591         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2592         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Added.
2593         (TestWebKitAPI::FileSystemTest::tempFilePath):
2594         (TestWebKitAPI::FileSystemTest::tempEmptyFilePath):
2595         (TestWebKitAPI::TEST_F):
2596         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Added.
2597         (TestWebKitAPI::SharedBufferTest::tempFilePath):
2598         (TestWebKitAPI::SharedBufferTest::tempEmptyFilePath):
2599         (TestWebKitAPI::TEST_F):
2600
2601 2015-05-13  Alex Christensen  <achristensen@webkit.org>
2602
2603         [Content Extensions] Test interactions between multiple extensions and multiple domains.
2604         https://bugs.webkit.org/show_bug.cgi?id=144967
2605
2606         Reviewed by Benjamin Poulain.
2607
2608         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2609         Xcode wanted to fix an alphabetization issue.
2610         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2611         (TestWebKitAPI::TEST_F):
2612         Test interactions that worked but were not explicitly tested before.
2613
2614 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2615
2616         Unreviewed build fix.
2617
2618         Added the missing metric name and wrapped values in an array as done in SunSpider.patch.
2619
2620         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch:
2621
2622 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2623
2624         Fix the previous commit, which made both bubbles green.
2625
2626         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2627         (.status-line.good .bubble):
2628         (.status-line.bad .bubble):
2629         (.status-line.good .message):
2630
2631 2015-05-12  Ryosuke Niwa  <rniwa@webkit.org>
2632
2633         People with Deuteranopia can't tell red and green apart on bot watcher's dashboard
2634         https://bugs.webkit.org/show_bug.cgi?id=144929
2635
2636         Reviewed by Eric Carlson.
2637
2638         Tweaked colors as I see fit.
2639
2640         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/StatusLineView.css:
2641         (.status-line.good .bubble):
2642         (.status-line.bad .bubble):
2643
2644 2015-05-11  Alexey Proskuryakov  <ap@apple.com>
2645
2646         [Mac] Share cookie storage between UI process and secondary processes
2647         https://bugs.webkit.org/show_bug.cgi?id=144820
2648         rdar://problem/20572830
2649
2650         Reviewed by Darin Adler.
2651
2652         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize):
2653         Don't set cookie storage directory, as it's a no-op, we use an ephemeral session
2654         for testing.
2655
2656 2015-05-12  Jake Nielsen  <jacob_nielsen@apple.com>
2657
2658         Fix internal build configuration issues
2659         https://bugs.webkit.org/show_bug.cgi?id=144762
2660
2661         Reviewed by David Kilzer.
2662
2663         Modifies DumpRenderTree's xcconfig files to use SDK selectors.
2664
2665         * DumpRenderTree/mac/Configurations/Base.xcconfig:
2666         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
2667         * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
2668         * DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
2669         * DumpRenderTree/mac/Configurations/DumpRenderTreeLibrary.xcconfig:
2670         * DumpRenderTree/mac/Configurations/ImageDiff.xcconfig:
2671         * DumpRenderTree/mac/Configurations/LayoutTestHelper.xcconfig:
2672         * DumpRenderTree/mac/Configurations/TestNetscapePlugIn.xcconfig:
2673
2674 2015-05-12  David Kilzer  <ddkilzer@apple.com>
2675
2676         Switch to launching iOS Simulator using bundle ID
2677         <rdar://problem/20916096>
2678
2679         This is required to fix the layout tests on internal bots.
2680
2681         * Scripts/webkitdirs.pm:
2682         (relaunchIOSSimulator): Switch to use bundle ID to launch iOS
2683         Simulator.  Add FIXME.
2684         (quitIOSSimulator): Add FIXME.
2685         * Scripts/webkitpy/port/ios.py:
2686         (IOSSimulatorPort.setup_test_run): Switch to use bundle ID to
2687         launch iOS Simulator.  Add FIXME.
2688         (IOSSimulatorPort.check_sys_deps): Add FIXME.
2689
2690 2015-05-12  Per Arne Vollan  <peavo@outlook.com>
2691
2692         Fix run-javascriptcore-tests step on the WinCairo bot
2693         https://bugs.webkit.org/show_bug.cgi?id=144866
2694
2695         Reviewed by Csaba Osztrogonác.
2696
2697         Catch exception when failing to create soft link, so we can fall back to copy.
2698
2699         * Scripts/run-jsc-stress-tests:
2700
2701 2015-05-12  Joanmarie Diggs  <jdiggs@igalia.com>
2702
2703         [GTK][WK2] rowAtIndex is not implemented in DRT/WKTR
2704         https://bugs.webkit.org/show_bug.cgi?id=116971
2705
2706         Reviewed by Chris Fleizach.
2707
2708         Implement rowAtIndex for ATK.
2709
2710         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2711         (WTR::AccessibilityUIElement::rowAtIndex):
2712
2713 2015-05-11  Dan Bernstein  <mitz@apple.com>
2714
2715         Test for <rdar://problem/20878075> Trying to navigate to an invalid URL loads about:blank, but -[WKWebView URL] returns the invalid URL
2716
2717         Reviewed by Alexey Proskuryakov.
2718
2719         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2720         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Fixed copyright header.
2721         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm: Added.
2722         (-[ProvisionalURLChangeController webView:didFinishNavigation:]):
2723
2724 2015-05-11  Jake Nielsen  <jacob_nielsen@apple.com>
2725
2726         Fix internal build configuration issues
2727         https://bugs.webkit.org/show_bug.cgi?id=144762
2728
2729         Reviewed by Darin Adler.
2730
2731         Modifies TestWebKitAPI and WebKitTestRunner's xcconfig files to use SDK selectors.
2732
2733         * TestWebKitAPI/Configurations/Base.xcconfig:
2734         * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
2735         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2736         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2737         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
2738         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
2739         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
2740
2741 2015-05-11  Brent Fulgham  <bfulgham@apple.com>
2742
2743         [Win] Move Windows build target to Windows 7 (or newer)
2744         https://bugs.webkit.org/show_bug.cgi?id=144890
2745         <rdar://problem/20707307>
2746
2747         Reviewed by Anders Carlsson.
2748
2749         Update linked SDK and minimal Windows level to be compatible with
2750         Windows 7 or newer.
2751
2752         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
2753         * DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
2754         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj:
2755         * DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
2756         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
2757         * DumpRenderTree/config.h:
2758         * TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
2759         * WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
2760         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj:
2761         * WinLauncher/stdafx.h:
2762
2763 2015-05-11  Commit Queue  <commit-queue@webkit.org>
2764
2765         Unreviewed, rolling out r184119.
2766         https://bugs.webkit.org/show_bug.cgi?id=144888
2767
2768         broke JSC tests on Apple Windows bots (Requested by kling on
2769         #webkit).
2770
2771         Reverted changeset:
2772
2773         "Fix run-javascriptcore-tests step on the WinCairo bot"
2774         https://bugs.webkit.org/show_bug.cgi?id=144866
2775         http://trac.webkit.org/changeset/184119
2776
2777 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2778
2779         run-benchmark should support Dromaeo
2780         https://bugs.webkit.org/show_bug.cgi?id=144849
2781
2782         Reviewed by Chris Dumez.
2783
2784         Added the benchmark plans for Dromaeo DOM tests. We only run these tests once since
2785         they can take as much as 15 minutes to run each.
2786
2787         * Scripts/webkitpy/benchmark_runner/data/patches/Dromaeo.patch: Added.
2788         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan: Added.
2789         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan: Added.
2790         * Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan: Added.
2791
2792 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2793
2794         Build fix. jetstream has a local copy, not remote archive.
2795
2796         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
2797
2798 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2799
2800         run-benchmark should support SunSpider, Kraken and Octane
2801         https://bugs.webkit.org/show_bug.cgi?id=144840
2802
2803         Reviewed by Darin Adler.
2804
2805         Added the support for SunSpider, Kraken, and Octane. Because of the licensing issues, we can't commit the
2806         Kraken source code into the WebKit repository as done for other benchmarks. Instead, we'll dynamically
2807         download it from the remote server using newly added RemoteZipBenchmarkBuilder. We do the same for Octane
2808         for simplicity. Use newly added --local-copy option to specify the location of a local copy if there is any.
2809
2810         Renamed "original_benchmark in the plan file to "local_copy" and added a new optional "remote_archive" to
2811         specify the URL to a remote ZIP file. This optional field is used by Kraken and Octane benchmark plans.
2812
2813         In addition, generalized the ability to run a "create script" in JetStreamBenchmarkBuilder since it's also
2814         needed for SunSpider and Kraken. This feature has now been folded into GenericBenchmarkBuilder.
2815
2816         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Added
2817         RemoteZipBenchmarkBuilder for Kraken and removed JetStreamBenchmarkBuilder since GenericBenchmarkBuilder
2818         now has the ability to run an arbitrary "create script".
2819
2820         * Scripts/run-benchmark:
2821         (main): Added an optional argument, --local-copy, to override the location of the benchmark's local copy.
2822         This also overrides the remote archive URL specified in the plan.
2823
2824         * Scripts/webkitpy/benchmark_runner/README.md: Updated the description.
2825
2826         * Scripts/webkitpy/benchmark_runner/benchmark_builder/benchmark_builders.json: Deleted the entry for
2827         JetStreamBenchmarkBuilder.
2828
2829         * Scripts/webkitpy/benchmark_runner/benchmark_builder/generic_benchmark_builder.py:
2830         (GenericBenchmarkBuilder.prepare): Call _fetchRemoteArchive if local_copy is not specified in the plan or
2831         by --local-copy option but remote_archive is specified. Also call self.clean() here instead of relying on
2832         _runCreateScript and _applyPatch to clean after themselves.
2833         (GenericBenchmarkBuilder._runCreateScript): Moved from JetStreamBenchmarkBuilder._runCreateScript since
2834         JetStream, SunSpider, Kraken all use this feature.
2835         (GenericBenchmarkBuilder._copyBenchmarkToTempDir): Use self.name as the destination location instead of
2836         the leaf directory name since the latter is not available when a remote ZIP file is used.
2837         (GenericBenchmarkBuilder._fetchRemoteArchive): Added.
2838         (GenericBenchmarkBuilder._applyPatch): Apply the patch inside destination directory to avoid hard coding
2839         the benchmark name in the patches.
2840
2841         * Scripts/webkitpy/benchmark_runner/benchmark_builder/jetstream_benchmark_builder.py: Removed.
2842
2843         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2844         (BenchmarkRunner.__init__): Set self.planName. Also override 'local_copy' when --local-copy option is used.
2845         (BenchmarkRunner.execute): Exit early if neither local_copy nor remote_archive is specified. Prefix the URL
2846         the browser opens by planName as the plan file no longer contains that.
2847
2848         * Scripts/webkitpy/benchmark_runner/data/patches/JetStream.patch: Changed the path to be relative against
2849         the top directory of JetStream instead of its parent.
2850         * Scripts/webkitpy/benchmark_runner/data/patches/Kraken.patch: Added.
2851         * Scripts/webkitpy/benchmark_runner/data/patches/Octane.patch: Added.
2852         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Changed the path to be relative against
2853         the top directory of JetStream instead of its parent.
2854         * Scripts/webkitpy/benchmark_runner/data/patches/SunSpider.patch: Added.
2855         * Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan: Uses GenericBenchmarkBuilder and specifies
2856         the script to run. The entry point was changed to the relative path from the top directory of JetStream as
2857         done in JetStream.patch.
2858         * Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan: Added.
2859         * Scripts/webkitpy/benchmark_runner/data/plans/octane.plan: Added.
2860         * Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan: The entry point was changed to the relative
2861         path from the top directory of JetStream as done in JetStream.patch.
2862         * Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan: Added.
2863
2864 2015-05-11  Csaba Osztrogonác  <ossy@webkit.org>
2865
2866         Fix run-javascriptcore-tests step on the WinCairo bot
2867         https://bugs.webkit.org/show_bug.cgi?id=144866
2868
2869         Reviewed by Darin Adler.
2870
2871         * Scripts/run-jsc-stress-tests:
2872
2873 2015-05-11  Alex Christensen  <achristensen@webkit.org>
2874
2875         [Content Extensions] Support domain-specific rules and exceptions.
2876         https://bugs.webkit.org/show_bug.cgi?id=144833
2877
2878         Reviewed by Darin Adler.
2879
2880         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
2881         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
2882         (TestWebKitAPI::InMemoryCompiledContentExtension::create):
2883         (TestWebKitAPI::InMemoryCompiledContentExtension::InMemoryCompiledContentExtension):
2884         Moved CompiledContentExtensionData from ContentExtensionCompiler.h because it is only used for testing.
2885         (TestWebKitAPI::mainDocumentRequest):
2886         (TestWebKitAPI::subResourceRequest):
2887         (TestWebKitAPI::TEST_F):
2888         (TestWebKitAPI::checkCompilerError):
2889         Added tests for parsing and functionality of if-domain and unless-domain.
2890
2891 2015-05-11  Ryosuke Niwa  <rniwa@webkit.org>
2892
2893         run-benchmark should support Chrome Canary and Firefox Nightly
2894         https://bugs.webkit.org/show_bug.cgi?id=144850
2895
2896         Reviewed by Darin Adler.
2897
2898         Added the support for Chrome Canary, Firefox (release), and Firefox Nightly.
2899
2900         This patch also extracts OSXBrowserDriver to launch and terminate processes on OS X.
2901
2902         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_drivers.json:
2903         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py: Added.
2904         (OSXBrowserDriver):
2905         (OSXBrowserDriver.prepareEnv): Extracted from ChromeBrowserDriver.prepareEnv.
2906         (OSXBrowserDriver.closeBrowsers): Ditto.
2907         (OSXBrowserDriver.launchProcess): Ditto.
2908         (OSXBrowserDriver.terminateProcesses): Ditto.
2909         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2910         (OSXChromeDriver): Removed the unused self.chromePreferences.
2911         (OSXChromeDriver.prepareEnv): Moved to OSXBrowserDriver.
2912         (OSXChromeDriver.closeBrowsers): Ditto.
2913         (OSXChromeDriver.launchUrl):
2914         (OSXChromeCanaryDriver): Added.
2915         (OSXChromeCanaryDriver.launchUrl):
2916         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: Added.
2917         (OSXFirefoxDriver): Added.
2918         (OSXFirefoxDriver.launchUrl):
2919         (OSXFirefoxNightlyDriver): Added.
2920         (OSXFirefoxNightlyDriver.launchUrl):
2921         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2922         (OSXSafariDriver):
2923         (OSXSafariDriver.closeBrowsers):
2924
2925 2015-05-11  Tim Horton  <timothy_horton@apple.com>
2926
2927         Page overlay action context override should indicate the source of the request
2928         https://bugs.webkit.org/show_bug.cgi?id=144832
2929         <rdar://problem/20562594>
2930
2931         Reviewed by Darin Adler.
2932
2933         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
2934         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
2935
2936 2015-05-10  Martin Robinson  <mrobinson@igalia.com>
2937
2938         [GTK] fast/events/page-visibility-transition-test.html is timing out
2939         https://bugs.webkit.org/show_bug.cgi?id=114789
2940
2941         Reviewed by Darin Adler.
2942
2943         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2944         (WTR::TestController::setHidden): Map and unmap the WebView when the harness
2945         requests visibility changes.
2946
2947 2015-05-10  Csaba Osztrogonác  <ossy@webkit.org>
2948
2949         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04
2950         https://bugs.webkit.org/show_bug.cgi?id=144798
2951
2952         Reviewed by Darin Adler.
2953
2954         * efl/install-dependencies:
2955
2956 2015-05-09  Ryosuke Niwa  <rniwa@webkit.org>
2957
2958         Make arguments of run-benchmark more user friendly
2959         https://bugs.webkit.org/show_bug.cgi?id=144835
2960
2961         Reviewed by Darin Adler.
2962
2963         Made --build-directory optional since I don't expect a typical WebKit developer to have a local build
2964         of Chrome and Firefox. Also made --plan accept just a filename so that we can just say "speedometer"
2965         instead of "Tools/Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan". Finally, removed
2966         default values from --platform and --browser as they are required arguments.
2967
2968         * Scripts/run-benchmark:
2969         (main): Made --build-directory optional, and removed default values from --platform and --browser.
2970         Also added help text for --build-directory and --plan. In addition, the list of platforms and browsers
2971         are not dynamically obtained via BrowserDriverFactory.
2972         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2973         (BenchmarkRunner.__init__): Raise when we can't find the plan file or the plan file is not a valid JSON
2974         file instead of suppressing the error here and blowing up later mysteriously since we won't be able to
2975         run any benchmark in that case.
2976         (BenchmarkRunner._findPlanFile): Added. Look for the plan in webkitpy/benchmark_runner/data/plans if
2977         the specified file isn't a valid relative or an absolute path.
2978         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:
2979         (BrowserDriverFactory.available_platforms): Added. Used in main to provide the list of valid platforms
2980         and browsers.
2981         (BrowserDriverFactory.available_browsers): Ditto.
2982         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2983         (OSXChromeDriver.launchUrl): browserBuildPath is never optional since BenchmarkRunner.execute always
2984         calls launchUrl with this argument so removed the default value. Also added a fallback path for when
2985         browserBuildPath was None.
2986         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2987         (OSXSafariDriver.launchUrl): Ditto. We also fallback when the build directory doesn't contain Safari
2988         so that we can use locally built WebKit to launch Safari.
2989
2990 2015-05-09  Yoav Weiss  <yoav@yoav.ws>
2991
2992         Remove the PICTURE_SIZES build flag
2993         https://bugs.webkit.org/show_bug.cgi?id=144679
2994
2995         Reviewed by Benjamin Poulain.
2996
2997         Removed the PICTURE_SIZES build time flag.
2998
2999         * Scripts/webkitperl/FeatureList.pm:
3000
3001 2015-05-09  David Kilzer  <ddkilzer@apple.com>
3002
3003         Layout tests broke due to unexpected simctl output
3004
3005         * Scripts/webkitpy/xcode/simulator.py:
3006         (Simulator._parse_devices): Handle new Device Pairs header.
3007         * Scripts/webkitpy/xcode/simulator_unittest.py:
3008         (test_device_pairs): Add unit test for Device Pairs header.
3009
3010 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3011
3012         Remove convenience constructors for TextRun
3013         https://bugs.webkit.org/show_bug.cgi?id=144752
3014
3015         Reviewed by Anders Carlsson.
3016
3017         Test the StringView which takes a StringImpl*.
3018
3019         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3020         (StringView8Bit): Testing is8Bit() on StringView
3021
3022 2015-05-07  Sam Weinig  <sam@webkit.org>
3023
3024         [Content Extensions] Add simple tester that takes an extension and compiles it
3025         https://bugs.webkit.org/show_bug.cgi?id=144781
3026
3027         Reviewed by Dan Bates.
3028
3029         * ContentExtensionTester: Added.
3030         * ContentExtensionTester/Configurations: Added.
3031         * ContentExtensionTester/Configurations/Base.xcconfig: Copied from Source/bmalloc/Configurations/Base.xcconfig.
3032         * ContentExtensionTester/Configurations/ContentExtensionTester.xcconfig: Copied from Source/bmalloc/Configurations/bmalloc.xcconfig.
3033         * ContentExtensionTester/Configurations/DebugRelease.xcconfig: Copied from Source/bmalloc/Configurations/DebugRelease.xcconfig.
3034         * ContentExtensionTester/ContentExtensionTester.xcodeproj: Added.
3035         * ContentExtensionTester/ContentExtensionTester.xcodeproj/project.pbxproj: Added.
3036         * ContentExtensionTester/Makefile: Copied from Tools/TestWebKitAPI/Makefile.
3037         * ContentExtensionTester/main.m: Added.
3038         * Scripts/run-content-extension-tester: Copied from Tools/Scripts/run-webkit-tests.
3039
3040 2015-05-08  Alexey Proskuryakov  <ap@apple.com>
3041
3042         Build fix.
3043
3044         Reviewed by Dan Bernstein.
3045
3046         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
3047         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3048         (-[DumpRenderTreeDraggingInfo springLoadingHighlight]):
3049         (-[DumpRenderTreeDraggingInfo resetSpringLoading]):
3050         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
3051         * WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
3052         (-[WebKitTestRunnerDraggingInfo springLoadingHighlight]):
3053         (-[WebKitTestRunnerDraggingInfo resetSpringLoading]):
3054
3055 2015-05-08  Martin Robinson  <mrobinson@igalia.com>
3056
3057         [GTK] Some tests fail because they do not assume the popup menu captures click events
3058         https://bugs.webkit.org/show_bug.cgi?id=40601
3059
3060         Reviewed by Carlos Garcia Campos.
3061
3062         Popdown all attached menus when moving between tests and between each new
3063         event sent to the WebView. This prevents context and popup menus from eating
3064         events.
3065
3066         * WebKitTestRunner/PlatformWebView.h: Added a helper method to do menu popdown.
3067         * WebKitTestRunner/TestController.cpp: Add a specialization of these methods for GTK+.
3068         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3069         (WTR::dispatchEvent): Popdown all menus between dispatching events.
3070         (WTR::EventSenderProxy::replaySavedEvents): Pass the view when dispatching events.
3071         (WTR::EventSenderProxy::sendOrQueueEvent): Pass the view when dispatching events.
3072         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3073         (WTR::PlatformWebView::hideAllPopupMenus): Added this helper.
3074         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3075         (WTR::TestController::platformConfigureViewForTest): Added this stub, which is no
3076         longer in the platform-independent file.
3077         (WTR::TestController::platformResetPreferencesToConsistentValues): Popdown menus.
3078
3079 015-05-08  Michael Catanzaro  <mcatanzaro@igalia.com>, Martin Robinson <mrobinson@igalia.com>
3080
3081         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3082         https://bugs.webkit.org/show_bug.cgi?id=144746
3083
3084         Reviewed by Carlos Garcia Campos.
3085
3086         Use ENABLE_DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3087
3088         * MiniBrowser/gtk/main.c:
3089         (main):
3090
3091 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3092
3093         Unreviewed, rolling out r183996.
3094         https://bugs.webkit.org/show_bug.cgi?id=144806
3095
3096         ASan detected use-after free (Requested by ap on #webkit).
3097
3098         Reverted changeset:
3099
3100         "Remove convenience constructors for TextRun"
3101         https://bugs.webkit.org/show_bug.cgi?id=144752
3102         http://trac.webkit.org/changeset/183996
3103
3104 2015-05-08  Myles C. Maxfield  <mmaxfield@apple.com>
3105
3106         Remove convenience constructors for TextRun
3107         https://bugs.webkit.org/show_bug.cgi?id=144752
3108
3109         Reviewed by Anders Carlsson.
3110
3111         Test the StringView which takes a StringImpl*.
3112
3113         * TestWebKitAPI/Tests/WTF/StringView.cpp:
3114         (StringView8Bit): Testing is8Bit() on StringView
3115
3116 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3117
3118         [GTK] WTR doesn't correctly handle the Escape key
3119         https://bugs.webkit.org/show_bug.cgi?id=144788
3120
3121         Reviewed by Martin Robinson.
3122
3123         Correctly handle 0x001B character code in GTK+ event sender to be
3124         recognized as Escape key, because gdk_unicode_to_keyval() doesn't
3125         handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
3126         to dismiss popup menus.
3127
3128         Fixes editing/selection/5354455-1.html.
3129
3130         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
3131         (WTR::getGDKKeySymForKeyRef):
3132
3133 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
3134
3135         [GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
3136         https://bugs.webkit.org/show_bug.cgi?id=144748
3137
3138         Reviewed by Sergio Villar Senin.
3139
3140         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
3141         (testWebKitSettings): Check the new setting is correctly
3142         initialized and updated.
3143         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
3144         (testWebContextSecurityFileXHR): Check XHR to local files is
3145         allowed from file URLs after changing the setting.
3146         (beforeAll): Add new test.
3147
3148 2015-05-08  Commit Queue  <commit-queue@webkit.org>
3149
3150         Unreviewed, rolling out r183945.
3151         https://bugs.webkit.org/show_bug.cgi?id=144789
3152
3153         "It broke all the GTK+ tests" (Requested by KaL on #webkit).
3154
3155         Reverted changeset:
3156
3157         "[GTK] Checks for DEVELOPMENT_BUILD are all wrong"
3158         https://bugs.webkit.org/show_bug.cgi?id=144746
3159         http://trac.webkit.org/changeset/183945
3160
3161 2015-05-07  Anders Carlsson  <andersca@apple.com>
3162
3163         Build fixes.
3164
3165         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
3166         (TestWebKitAPI::TEST):
3167         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
3168         (TestWebKitAPI::TEST):
3169         Add casts.
3170
3171 2015-05-07  Filip Pizlo  <fpizlo@apple.com>
3172
3173         GC has trouble with pathologically large array allocations
3174         https://bugs.webkit.org/show_bug.cgi?id=144609
3175
3176         Reviewed by Geoffrey Garen.
3177
3178         Add a --filter option that restricts the set of tests we run. I needed it to fix this bug
3179         and it's a frequently requested feature.
3180
3181         Also add the ability to run a test pretending that your system has a particular RAM size.
3182         This is useful for GC tests, and the new GC test that I added uses this.
3183
3184         * Scripts/run-javascriptcore-tests:
3185         (runJSCStressTests):
3186         * Scripts/run-jsc-stress-tests:
3187
3188 2015-05-07  Csaba Osztrogonác  <ossy@webkit.org>
3189
3190         [EFL] Bump EFL version to 1.14.0
3191         https://bugs.webkit.org/show_bug.cgi?id=144743
3192
3193         Reviewed by Darin Adler.
3194
3195         Bump EFL and elementary version to 1.14.0 and removed
3196         md5sum, because it isn't used at all if hash is present.
3197
3198         * efl/jhbuild.modules:
3199
3200 2015-05-07  Saam Barati  <saambarati1@gmail.com>
3201
3202         exceptionFuzz tests should explicitly initialize the exceptionFuzz boolean in JavaScript code through a function in jsc.cpp
3203         https://bugs.webkit.org/show_bug.cgi?id=144753
3204
3205         Reviewed by Mark Lam.
3206
3207         * Scripts/jsc-stress-test-helpers/js-exception-fuzz:
3208
3209 2015-05-07  Beth Dakin  <bdakin@apple.com>
3210
3211         New force-related DOM events should fire in WK1 views
3212         https://bugs.webkit.org/show_bug.cgi?id=144663
3213         -and corresponding-
3214         rdar://problem/20281886
3215
3216         Reviewed by Sam Weinig.
3217
3218         PlatformEventFactory::createPlatformMouseEvent() takes the last pressure event
3219         now. Just send nil.
3220         * TestWebKitAPI/Tests/mac/MenuTypesForMouseEvents.mm:
3221         (TestWebKitAPI::buildAndPerformTest):
3222
3223 2015-05-07  Michael Catanzaro  <mcatanzaro@igalia.com>
3224
3225         [GTK] Checks for DEVELOPMENT_BUILD are all wrong
3226         https://bugs.webkit.org/show_bug.cgi?id=144746
3227
3228         Reviewed by Martin Robinson.
3229
3230         Use DEVELOPER_MODE rather than DEVELOPMENT_BUILD.
3231
3232         * MiniBrowser/gtk/main.c:
3233         (main):
3234
3235 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3236
3237         Revert "Introducing the Platform Abstraction Layer (PAL)"
3238         https://bugs.webkit.org/show_bug.cgi?id=144751
3239
3240         Unreviewed.
3241
3242         PAL should be a new target inside WebCore, rather than a top-level folder.
3243
3244         * Scripts/build-webkit: Add it to build-webkit.
3245
3246 2015-05-07  Ada Chan  <adachan@apple.com>
3247
3248         Add a test for WKPageCopySessionState() with filtering.
3249         https://bugs.webkit.org/show_bug.cgi?id=144666
3250
3251         Reviewed by Darin Adler.
3252
3253         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3254         * TestWebKitAPI/Tests/WebKit2/WKPageCopySessionStateWithFiltering.cpp: Added.
3255         (TestWebKitAPI::didFinishLoadForFrame):
3256         (TestWebKitAPI::setPageLoaderClient):
3257         (TestWebKitAPI::filterFirstItemCallback):
3258         (TestWebKitAPI::filterAllItemsCallback):
3259         (TestWebKitAPI::createSessionStates):
3260         (TestWebKitAPI::TEST):
3261
3262 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3263
3264         iOS build fix attempt
3265
3266         Link WebKitTestRunnerApp to WebKit, now that we don't have WebKit2.
3267
3268         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3269
3270 2015-05-06  Matt Baker  <mattbaker@apple.com>
3271
3272         Unreviewed, updated my list of email addresses.
3273
3274         * Scripts/webkitpy/common/config/contributors.json:
3275
3276 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3277
3278         Do not link tools to WebKit2.framework
3279         https://bugs.webkit.org/show_bug.cgi?id=144699
3280
3281         Unreviewed build fix.
3282
3283         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
3284         * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
3285         These linked to WebKit2 in two ways, eliminating the other one.
3286
3287 2015-05-05  Myles C. Maxfield  <mmaxfield@apple.com>
3288
3289         Introducing the Platform Abstraction Layer (PAL)
3290         https://bugs.webkit.org/show_bug.cgi?id=143358
3291
3292         Reviewed by Simon Fraser.
3293
3294         * Scripts/build-webkit: Add it to build-webkit.
3295
3296 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3297
3298         Fix api tests after r183877.
3299
3300         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3301         (TestWebKitAPI::TEST_F):
3302         Generate all DFAs before compiling them.
3303
3304 2015-05-06  Alexey Proskuryakov  <ap@apple.com>
3305
3306         Do not link tools to WebKit2.framework
3307         https://bugs.webkit.org/show_bug.cgi?id=144699
3308
3309         Reviewed by Tim Horton.
3310
3311         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
3312         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3313         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3314
3315 2015-05-06  Alex Christensen  <achristensen@webkit.org>
3316
3317         [Content Extensions] Test splitting NFAs by max NFA size.
3318         https://bugs.webkit.org/show_bug.cgi?id=144659
3319
3320         Reviewed by Darin Adler.
3321
3322         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3323         (TestWebKitAPI::createNFAs):
3324         (TestWebKitAPI::TEST_F):
3325         * TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
3326         (TestWebKitAPI::createNFAs):
3327
3328 2015-05-05  daegyu lee  <daegyu.lee@navercorp.com>
3329
3330         Remove the remaining vestiges of SVG feature define
3331         https://bugs.webkit.org/show_bug.cgi?id=144655
3332
3333         Reviewed by Alexey Proskuryakov.
3334
3335         * Scripts/webkitperl/FeatureList.pm:
3336
3337 2015-05-05  Timothy Horton  <timothy_horton@apple.com>
3338
3339         Add a layout mode for computing fixed layout size from a minimum size
3340         https://bugs.webkit.org/show_bug.cgi?id=144610
3341         <rdar://problem/19790341>
3342
3343         Reviewed by Simon Fraser.
3344
3345         * MiniBrowser/mac/BrowserWindow.xib:
3346         * MiniBrowser/mac/BrowserWindowController.h:
3347         * MiniBrowser/mac/WK1BrowserWindowController.m:
3348         (-[WK1BrowserWindowController toggleUseMinimumViewSize:]):
3349         * MiniBrowser/mac/WK2BrowserWindowController.m:
3350         (-[WK2BrowserWindowController toggleUseMinimumViewSize:]):
3351         Add a optional toolbar item to toggle a minimum view size of 1024x0.
3352
3353 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3354
3355         [Content Extensions] Release input NSString when finished copying it.
3356         https://bugs.webkit.org/show_bug.cgi?id=144642
3357
3358         Reviewed by Brian Weinstein.
3359
3360         * WebKitTestRunner/mac/TestControllerMac.mm:
3361         (WTR::TestController::platformConfigureViewForTest):
3362         Use alloc and initWithContentsOfURL to prevent over-releasing an autoreleased object.
3363
3364 2015-05-05  Brent Fulgham  <bfulgham@apple.com>
3365
3366         Unreviewed test fix after r183798.
3367
3368         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3369         (convertToDRTLabel): Mimic behavior of Mac accessibility output
3370         so we can share results.
3371
3372 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3373
3374         [Content Extensions] Use less memory to store the json input.
3375         https://bugs.webkit.org/show_bug.cgi?id=144604
3376
3377         Reviewed by Benjamin Poulain.
3378
3379         * MiniBrowser/mac/ExtensionManagerWindowController.m:
3380         (-[ExtensionManagerWindowController add:]):
3381         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3382         (TestWebKitAPI::InMemoryCompiledContentExtension::createFromFilter):
3383         * WebKitTestRunner/mac/TestControllerMac.mm:
3384         (WTR::TestController::platformConfigureViewForTest):
3385
3386 2015-05-05  Yusuke Suzuki  <utatane.tea@gmail.com>
3387
3388         Unreviewed. Make myself a WebKit reviewer.
3389
3390         * Scripts/webkitpy/common/config/contributors.json:
3391
3392 2015-05-05  Joanmarie Diggs  <jdiggs@igalia.com>
3393
3394         [GTK] r183783 breaks build
3395         https://bugs.webkit.org/show_bug.cgi?id=144632
3396
3397         Reviewed by Martin Robinson.
3398
3399         Return false rather than nullptr for unimplemented AccessibilityUIElement::setSelectedVisibleTextRange
3400
3401         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3402         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3403
3404 2015-05-05  Alex Christensen  <achristensen@webkit.org>
3405
3406         [Content Extensions] Combine NFAs properly and free memory as we compile.
3407         https://bugs.webkit.org/show_bug.cgi?id=144485
3408
3409         Reviewed by Benjamin Poulain.
3410
3411         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3412         (TestWebKitAPI::TEST_F):
3413         Added tests for correctly splitting up NFAs with unquantified terms after quantified terms.
3414         Added tests for deep NFAs.
3415
3416 2015-05-04  Alex Christensen  <achristensen@webkit.org>
3417
3418         [Content Extensions] Use less memory when writing byte code to file
3419         https://bugs.webkit.org/show_bug.cgi?id=144602
3420
3421         Reviewed by Darin Adler.
3422
3423         * TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
3424
3425 2015-05-05  Carlos Garcia Campos  <cgarcia@igalia.com>
3426
3427         [GTK] Async operations running in the WorkQueue thread should schedule their sources to the WorkQueue main lopp
3428         https://bugs.webkit.org/show_bug.cgi?id=144541
3429
3430         Reviewed by Žan Doberšek.
3431
3432         Add a test case to WorkQueue unit test, to check that sources of
3433         asynchronous IO operations running in the WorkQueue thread are
3434         dispatched by the WorkQueue main loop.
3435
3436         * TestWebKitAPI/PlatformGTK.cmake:
3437         * TestWebKitAPI/Tests/WTF/gtk/WorkQueueGtk.cpp: Added.
3438         (TestWebKitAPI::TEST):
3439
3440 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3441
3442         Correct '--show-webview' option for Tiled Drawing tests
3443         https://bugs.webkit.org/show_bug.cgi?id=144621
3444
3445         Reviewed by Simon Fraser.
3446
3447         The scrolling thread/tiled drawing tests recreate the standard test runner web view. My earlier patch did not make
3448         sure that the state of the '--show-webview' option was propagated to this additional view creation routine.
3449
3450         * WebKitTestRunner/mac/TestControllerMac.mm:
3451         (WTR::TestController::platformConfigureViewForTest): Include the value of the 'shouldShowWebView' state in the
3452         WKMutableDictionary passed to the 'ensureViewSupportsOptions' method.
3453
3454 2015-05-04  Filip Pizlo  <fpizlo@apple.com>
3455
3456         Large array shouldn't be slow
3457         https://bugs.webkit.org/show_bug.cgi?id=144617
3458
3459         Reviewed by Geoffrey Garen.
3460
3461         Add the hash-map benchmark to LongSpider. LongSpider was already not a perfect match of
3462         SunSpider. It's not an official benchmark. It contains benchmarks that are relatively
3463         long-running. So, hash-map sort of belongs here.
3464
3465         * Scripts/run-jsc-benchmarks:
3466
3467 2015-05-04  Doug Russell  <d_russell@apple.com>
3468
3469         AX: setting focus via accessibility object needs to set isSynchronizing in resulting selection intent
3470         https://bugs.webkit.org/show_bug.cgi?id=144489
3471
3472         Reviewed by Chris Fleizach.
3473
3474         Resolves infinite looping when navigating rapidly between controls with the search API and then focusing
3475         on the returned control.
3476         Remove isSynchronizing flag from AXTextStateChangeIntent and put it on AXObjectCache.
3477         Move AXTextStateChangeIntent logic in AccessibilityRenderObject into a helper method.
3478         Call new AXTextStateChangeIntent helper from AccessibilityRenderObject::setFocus().
3479         Add support for setSelectedVisibleTextRange() in accessibility tests.
3480
3481         * DumpRenderTree/AccessibilityUIElement.cpp:
3482         (setSelectedVisibleTextRangeCallback):
3483         (AccessibilityUIElement::setSelectedVisibleTextRange):
3484         (AccessibilityUIElement::getJSClass):
3485         (AccessibilityUIElement::textMarkerForIndex): Deleted.
3486         * DumpRenderTree/AccessibilityUIElement.h:
3487         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3488         (AccessibilityUIElement::setSelectedVisibleTextRange):
3489         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
3490         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3491         (WTR::AccessibilityUIElement::setSelectedTextRange): Deleted.
3492         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
3493         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
3494         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3495         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3496         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3497         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3498         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3499         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
3500
3501 2015-05-04  Brent Fulgham  <bfulgham@apple.com>
3502
3503         [Win] Implement the "--show-webview" option for Windows
3504         https://bugs.webkit.org/show_bug.cgi?id=144589
3505
3506         Reviewed by Alex Christensen.
3507
3508         Add another runtime flag (--show-webview) that causes DumpRenderTree
3509         to draw its view on-screen, rather than the standard offscreen mode.
3510
3511         * DumpRenderTree/win/DumpRenderTree.cpp:
3512         (createWebViewAndOffscreenWindow): Honor the 'showWebView' flag.
3513         (initializeGlobalsFromCommandLineOptions): Recognize the new
3514         command-line argument, and set the global 'showWebView' state if
3515         appropriate.
3516
3517 2015-05-04  Csaba Osztrogonác  <ossy@webkit.org>
3518
3519         Remove dead code from TestInvocationCairo.cpp
3520         https://bugs.webkit.org/show_bug.cgi?id=144564
3521
3522         Reviewed by Gyuyoung Kim.
3523
3524         Only EFL and GTK port use TestInvocationCairo.cpp, there isn't other platform.
3525
3526         * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
3527         (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
3528
3529 2015-05-04  Joonghun Park  <jh718.park@samsung.com>
3530
3531         [GTK] Add libnotify in gtk install-dependencies
3532         https://bugs.webkit.org/show_bug.cgi?id=144379
3533
3534         Reviewed by Csaba Osztrogonác.
3535
3536         * gtk/install-dependencies:
3537
3538 2015-05-01  Dan Bernstein  <mitz@apple.com>
3539
3540         Test for <rdar://problem/8636045> Back/forward navigation to an error page in Safari breaks the back-forward list
3541         https://bugs.webkit.org/show_bug.cgi?id=144501
3542
3543         Reviewed by Darin Adler.
3544
3545         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3546         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadAlternateHTMLString.mm: Added.
3547         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFailProvisionalNavigation:withError:]):
3548         (-[LoadAlternateHTMLStringFromProvisionalLoadErrorController webView:didFinishNavigation:]):
3549
3550 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3551
3552         check-webkit-style fails due to system pylint
3553         https://bugs.webkit.org/show_bug.cgi?id=144360
3554
3555         Reviewed by Darin Adler.
3556
3557         Make sure that the directory containing third party autoinstalled modules
3558         is at the beginning of the search path, to avoid conflicts with other
3559         versions of the same modules installed in the system (e.g. pylint).
3560
3561         * Scripts/webkitpy/thirdparty/__init__.py: Prepend the autoinstalled
3562         modules directory to sys.path, instead of appending it.
3563
3564 2015-05-01  Mario Sanchez Prada  <mario@endlessm.com>
3565
3566         Unreviewed, updated my list of email addresses.
3567
3568         * Scripts/webkitpy/common/config/contributors.json: Updated.
3569
3570 2015-05-01  Martin Robinson  <mrobinson@igalia.com>
3571
3572         USE(...) macro should expect unprefixed variables
3573         https://bugs.webkit.org/show_bug.cgi?id=144454
3574
3575         Reviewed by Daniel Bates.
3576
3577         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Replace all occurrences WTF_USE with USE.
3578         * DumpRenderTree/config.h: Ditto.
3579         * TestWebKitAPI/config.h: Ditto.
3580
3581 2015-05-01  Basile Clement  <basile_clement@apple.com>
3582
3583         Unreviewed. Add myself as a commiter in contributors.json.
3584
3585         * Scripts/webkitpy/common/config/contributors.json:
3586
3587 2015-05-01  Dewei Zhu  <dewei_zhu@apple.com>
3588
3589         Update speedometer patch to provide better UI, fix merge result bug and add "Score" metric to speedometer benchmark.
3590         https://bugs.webkit.org/show_bug.cgi?id=144487
3591
3592         Reviewed by Ryosuke Niwa.
3593
3594         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
3595         (BenchmarkRunner.merge): Fix bug.
3596         * Scripts/webkitpy/benchmark_runner/data/patches/Speedometer.patch: Update appearance and add "Score" metric.
3597
3598 2015-05-01  Brady Eidson  <beidson@apple.com>
3599
3600         Add API to disable meta refreshes.
3601         <rdar://problem/20333198> and https://bugs.webkit.org/show_bug.cgi?id=144269
3602
3603         Reviewed by Alexey Proskuryakov.
3604
3605         * DumpRenderTree/mac/DumpRenderTree.mm:
3606         (resetWebPreferencesToConsistentValues): Reset the meta refresh pref between tests.
3607
3608 2015-05-01  Brent Fulgham  <bfulgham@apple.com>
3609
3610         Provide a runtime flag to run-webkit-tests that shows the test view
3611         https://bugs.webkit.org/show_bug.cgi?id=144079.
3612
3613         Unreviewed correction to r183651.
3614
3615         * WebKitTestRunner/TestController.cpp:
3616         (WTR::TestController::initialize): Make sure the state of the '--show-webview'
3617         flag is included in the options dictionary passed to the PlatformWebView.
3618
3619 2015-05-01  Antti Koivisto  <antti@apple.com>
3620
3621         Remove network process load serialization code
3622         https://bugs.webkit.org/show_bug.cgi?id=144448
3623
3624         Reviewed by Alexey Proskuryakov.
3625
3626         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3627         (WTR::InjectedBundle::beginTesting):
3628         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3629         (WTR::TestRunner::setSerializeHTTPLoads):
3630         (WTR::TestRunner::dispatchPendingLoadRequests):
3631
3632 2015-05-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
3633
3634         [GTK] Add libhyphen-dev to the build dependencies
3635         https://bugs.webkit.org/show_bug.cgi?id=144452
3636
3637         Reviewed by Martin Robinson.
3638
3639         * gtk/install-dependencies: Added hyphen as Fedora and Arch
3640         dependencies.
3641
3642 2015-04-30  Brent Fulgham  <bfulgham@apple.com>
3643
3644         Provide a runtime flag to run-webkit-tests that shows the test view
3645         https://bugs.webkit.org/show_bug.cgi?id=144079.
3646
3647         Reviewed by Dean Jackson.
3648
3649         Add a new flag (--show-webview) that causes DumpRenderTree and WebKitTestRunner to display
3650         their WebViews on-screen. This can be used when running tests via the "--additional-drt-flag"
3651         option: