[GTK][CMake] Make gtk-unix-print a component of FindGTK.cmake
[WebKit-https.git] / Tools / ChangeLog
1 2020-04-21  Adrian Perez de Castro  <aperez@igalia.com>
2
3         [GTK][CMake] Make gtk-unix-print a component of FindGTK.cmake
4         https://bugs.webkit.org/show_bug.cgi?id=210792
5
6         Reviewed by Carlos Garcia Campos.
7
8         * TestWebKitAPI/glib/PlatformGTK.cmake: Use the GTK::UnixPrint imported target.
9
10 2020-04-21  Philippe Normand  <pnormand@igalia.com>
11
12         [Flatpak SDK] Silence git stderr output
13         https://bugs.webkit.org/show_bug.cgi?id=210789
14
15         Reviewed by Sergio Villar Senin.
16
17         * flatpak/flatpakutils.py:
18         (WebkitFlatpak.is_branch_build): Don't display git errors, usually
19         emitted when operating on a SVN checkout.
20
21 2020-04-21  Philippe Normand  <pnormand@igalia.com>
22
23         [CMake][Flatpak SDK] gst-build-backed build fails
24         https://bugs.webkit.org/show_bug.cgi?id=210742
25
26         Reviewed by Xabier Rodriguez-Calvar.
27
28         Add non-core GStreamer include-dirs necessary for the compilation
29         of the GStreamer API test. Usually GSTREAMER_INCLUDE_DIRS is
30         sufficient because on a GStreamer system-wide installation, all
31         headers are stored in the same root include dir, the same as the
32         core GStreamer library.
33
34         But when building with gst-build, include-dirs are scattered all
35         over the place.
36
37         * TestWebKitAPI/PlatformGTK.cmake:
38         * TestWebKitAPI/PlatformWPE.cmake:
39
40 2020-04-20  Ross Kirsling  <ross.kirsling@sony.com>
41
42         Classes marked final should not use protected access specifier
43         https://bugs.webkit.org/show_bug.cgi?id=210775
44
45         Reviewed by Daniel Bates.
46
47         * DumpRenderTree/win/DefaultPolicyDelegate.h:
48         * DumpRenderTree/win/UIDelegate.h:
49
50 2020-04-20  Peng Liu  <peng.liu6@apple.com>
51
52         Fix build failures when video fullscreen and picture-in-picture is disabled
53         https://bugs.webkit.org/show_bug.cgi?id=210777
54
55         Reviewed by Eric Carlson.
56
57         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
58
59 2020-04-20  Alex Christensen  <achristensen@webkit.org>
60
61         SPI clients using fastServerTrustEvaluationEnabled need SPI to inform them of modern TLS negotiation
62         https://bugs.webkit.org/show_bug.cgi?id=210533
63
64         Reviewed by Brady Eidson.
65
66         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
67         (-[TLSNavigationDelegate waitForDidNegotiateModernTLS]):
68         (-[TLSNavigationDelegate _webView:didNegotiateModernTLS:]):
69         (TestWebKitAPI::TEST):
70
71 2020-04-20  Kate Cheney  <katherine_cheney@apple.com>
72
73         App-bound domain behavior should abide by the limitsNavigationsToAppBoundDomains argument in WKWebView configuration
74         https://bugs.webkit.org/show_bug.cgi?id=210769
75         <rdar://problem/62065241>
76
77         Reviewed by Brent Fulgham.
78
79         Removes any tests for swapping between app-bound and non app-bound
80         domains as this behavior is no longer supported.
81
82         Sets the limitsNavigationsToAppBoundDomains flag for tests which should
83         have app-bound behavior to maintain test functionality.
84
85         Adds 5 new tests for new behavior.
86
87         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
88         (TEST):
89         (-[AppBoundDomainDelegate webView:didFinishNavigation:]):
90         (-[AppBoundDomainDelegate webView:didFailProvisionalNavigation:withError:]):
91         (-[AppBoundDomainDelegate waitForDidFinishNavigation]):
92         (-[AppBoundDomainDelegate waitForDidFailProvisionalNavigationError]):
93
94 2020-04-20  Megan Gardner  <megan_gardner@apple.com>
95
96         Date and Time form controls not showing correct initial values on immediate second invocation.
97         https://bugs.webkit.org/show_bug.cgi?id=210613
98
99         Reviewed by Wenson Hsieh.
100
101         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
102         * TestRunnerShared/UIScriptContext/UIScriptController.h:
103         (WTR::UIScriptController::timePickerValueHour const):
104         (WTR::UIScriptController::timePickerValueMinute const):
105         * WebKitTestRunner/ios/UIScriptControllerIOS.h:
106         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
107         (WTR::UIScriptControllerIOS::timePickerValueHour const):
108         (WTR::UIScriptControllerIOS::timePickerValueMinute const):
109
110 2020-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
111
112         Text manipulation sometimes fails to replace text in title elements
113         https://bugs.webkit.org/show_bug.cgi?id=210750
114         <rdar://problem/61066103>
115
116         Reviewed by Tim Horton and Darin Adler.
117
118         Add a new API test to verify that a single title or option element may be replaced with multiple tokens, as long
119         as all the token identifiers match.
120
121         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
122
123 2020-04-20  Stephan Szabo  <stephan.szabo@sony.com>
124
125         [PlayStation] Fix build after r260277
126         https://bugs.webkit.org/show_bug.cgi?id=210756
127
128         Reviewed by Don Olmstead.
129
130         * TestWebKitAPI/PlatformPlayStation.cmake:
131
132 2020-04-20  Wenson Hsieh  <wenson_hsieh@apple.com>
133
134         Oversized caret and selection rects in text fields on ganji.com and netflix.com/login
135         https://bugs.webkit.org/show_bug.cgi?id=210622
136         <rdar://problem/45945636>
137
138         Reviewed by Darin Adler.
139
140         Rebaseline some expected selection and caret rects in some iOS API tests.
141
142         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
143         (TestWebKitAPI::TEST):
144         * TestWebKitAPI/Tests/ios/AutocorrectionTestsIOS.mm:
145         (TEST):
146         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
147         (TestWebKitAPI::TEST):
148
149 2020-04-20  Darin Adler  <darin@apple.com>
150
151         Use #import instead of #include in Objective-C and don't use #pragma once
152         https://bugs.webkit.org/show_bug.cgi?id=210724
153
154         Reviewed by David Kilzer.
155
156         * DumpRenderTree/TestNetscapePlugIn/PluginObjectMac.mm:
157         * DumpRenderTree/ios/DumpRenderTreeAppMain.mm:
158         * DumpRenderTree/mac/AccessibilityCommonMac.h:
159         * DumpRenderTree/mac/DumpRenderTreeMain.mm:
160         * TestRunnerShared/cocoa/ClassMethodSwizzler.mm:
161         * TestRunnerShared/cocoa/InstanceMethodSwizzler.mm:
162         * TestRunnerShared/cocoa/LayoutTestSpellChecker.h:
163         * TestRunnerShared/mac/NSPasteboardAdditions.h:
164         * TestRunnerShared/spi/AppKitTestSPI.h:
165         * TestRunnerShared/spi/PencilKitTestSPI.h:
166         * TestWebKitAPI/DataDetectorsCoreSPI.h:
167         * TestWebKitAPI/EditingTestHarness.h:
168         * TestWebKitAPI/EditingTestHarness.mm:
169         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm:
170         * TestWebKitAPI/Tests/WebCore/LineBreaking.mm:
171         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
172         * TestWebKitAPI/Tests/WebCore/cocoa/DatabaseTrackerTest.mm:
173         * TestWebKitAPI/Tests/WebKit/AGXCompilerService.mm:
174         * TestWebKitAPI/Tests/WebKit/AccessibilityRemoteUIApp.mm:
175         * TestWebKitAPI/Tests/WebKit/BacklightLevelNotification.mm:
176         * TestWebKitAPI/Tests/WebKit/Battery.mm:
177         * TestWebKitAPI/Tests/WebKit/DeferredViewInWindowStateChange.mm:
178         * TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:
179         * TestWebKitAPI/Tests/WebKit/FindMatches.mm:
180         * TestWebKitAPI/Tests/WebKit/GrantAccessToMobileAssets.mm:
181         * TestWebKitAPI/Tests/WebKit/GrantAccessToPreferencesService.mm:
182         * TestWebKitAPI/Tests/WebKit/LocalizedDeviceModel.mm:
183         * TestWebKitAPI/Tests/WebKit/MimeTypes.mm:
184         * TestWebKitAPI/Tests/WebKit/NoHistoryItemScrollToFragment.mm:
185         * TestWebKitAPI/Tests/WebKit/PasteboardNotifications.mm:
186         * TestWebKitAPI/Tests/WebKit/PictureInPictureSupport.mm:
187         * TestWebKitAPI/Tests/WebKit/PreferenceChanges.mm:
188         * TestWebKitAPI/Tests/WebKit/SleepDisabler.mm:
189         * TestWebKitAPI/Tests/WebKit/ViewportSizeForViewportUnits.mm:
190         * TestWebKitAPI/Tests/WebKit/WKThumbnailView.mm:
191         * TestWebKitAPI/Tests/WebKit/WebFilter.mm:
192         * TestWebKitAPI/Tests/WebKit/mac/AttributedSubstringForProposedRangeWithImage.mm:
193         * TestWebKitAPI/Tests/WebKit/mac/ContextMenuDownload.mm:
194         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.h:
195         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm:
196         * TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter_Bundle.mm:
197         * TestWebKitAPI/Tests/WebKit/mac/EditorCommands.mm:
198         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle.mm:
199         * TestWebKitAPI/Tests/WebKit/mac/ForceLightAppearanceInBundle_Bundle.mm:
200         * TestWebKitAPI/Tests/WebKitCocoa/AnimatedResize.mm:
201         * TestWebKitAPI/Tests/WebKitCocoa/AutoLayoutIntegration.mm:
202         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewAfterEnterFullscreen.mm:
203         * TestWebKitAPI/Tests/WebKitCocoa/CloseWebViewDuringEnterFullscreen.mm:
204         * TestWebKitAPI/Tests/WebKitCocoa/CookieAcceptPolicy.mm:
205         * TestWebKitAPI/Tests/WebKitCocoa/CookiePrivateBrowsing.mm:
206         * TestWebKitAPI/Tests/WebKitCocoa/CopyHTML.mm:
207         * TestWebKitAPI/Tests/WebKitCocoa/CopyRTF.mm:
208         * TestWebKitAPI/Tests/WebKitCocoa/CopyURL.mm:
209         * TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm:
210         * TestWebKitAPI/Tests/WebKitCocoa/DataDetection.mm:
211         * TestWebKitAPI/Tests/WebKitCocoa/DecidePolicyForNavigationAction.mm:
212         * TestWebKitAPI/Tests/WebKitCocoa/DeviceManagementRestrictions.mm:
213         * TestWebKitAPI/Tests/WebKitCocoa/DoAfterNextPresentationUpdateAfterCrash.mm:
214         * TestWebKitAPI/Tests/WebKitCocoa/EditorStateTests.mm:
215         * TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm:
216         * TestWebKitAPI/Tests/WebKitCocoa/FindInPage.mm:
217         * TestWebKitAPI/Tests/WebKitCocoa/FindInPageAPI.mm:
218         * TestWebKitAPI/Tests/WebKitCocoa/FirstVisuallyNonEmptyMilestone.mm:
219         * TestWebKitAPI/Tests/WebKitCocoa/FixedLayoutSize.mm:
220         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm:
221         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenDelegate.mm:
222         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenLayoutConstraints.mm:
223         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
224         * TestWebKitAPI/Tests/WebKitCocoa/InteractionDeadlockAfterCrash.mm:
225         * TestWebKitAPI/Tests/WebKitCocoa/JavaScriptDuringNavigation.mm:
226         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm:
227         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm:
228         * TestWebKitAPI/Tests/WebKitCocoa/LoadInvalidURLRequest.mm:
229         * TestWebKitAPI/Tests/WebKitCocoa/MediaBufferingPolicy.mm:
230         * TestWebKitAPI/Tests/WebKitCocoa/MediaType.mm:
231         * TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
232         * TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm:
233         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm:
234         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm:
235         * TestWebKitAPI/Tests/WebKitCocoa/NetworkProcessCrashNonPersistentDataStore.mm:
236         * TestWebKitAPI/Tests/WebKitCocoa/NoPauseWhenSwitchingTabs.mm:
237         * TestWebKitAPI/Tests/WebKitCocoa/NowPlaying.mm:
238         * TestWebKitAPI/Tests/WebKitCocoa/NowPlayingControlsTests.mm:
239         * TestWebKitAPI/Tests/WebKitCocoa/ObservedRenderingProgressEventsAfterCrash.mm:
240         * TestWebKitAPI/Tests/WebKitCocoa/OpenAndCloseWindow.mm:
241         * TestWebKitAPI/Tests/WebKitCocoa/OverrideViewportArguments.mm:
242         * TestWebKitAPI/Tests/WebKitCocoa/PageZoom.mm:
243         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenTests.mm:
244         * TestWebKitAPI/Tests/WebKitCocoa/PasteHTML.mm:
245         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
246         * TestWebKitAPI/Tests/WebKitCocoa/PasteMixedContent.mm:
247         * TestWebKitAPI/Tests/WebKitCocoa/PasteRTFD.mm:
248         * TestWebKitAPI/Tests/WebKitCocoa/PasteWebArchive.mm:
249         * TestWebKitAPI/Tests/WebKitCocoa/PictureInPictureDelegate.mm:
250         * TestWebKitAPI/Tests/WebKitCocoa/PreferredAudioBufferSize.mm:
251         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm:
252         * TestWebKitAPI/Tests/WebKitCocoa/ReparentWebViewTimeout.mm:
253         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
254         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimer.mm:
255         * TestWebKitAPI/Tests/WebKitCocoa/ResponsivenessTimerDoesntFireEarly.mm:
256         * TestWebKitAPI/Tests/WebKitCocoa/RestoreSessionStateWithoutNavigation.mm:
257         * TestWebKitAPI/Tests/WebKitCocoa/ShouldGoToBackForwardListItem.mm:
258         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
259         * TestWebKitAPI/Tests/WebKitCocoa/ShrinkToFit.mm:
260         * TestWebKitAPI/Tests/WebKitCocoa/StopSuspendResumeAllMedia.mm:
261         * TestWebKitAPI/Tests/WebKitCocoa/StorageQuota.mm:
262         * TestWebKitAPI/Tests/WebKitCocoa/SystemColors.mm:
263         * TestWebKitAPI/Tests/WebKitCocoa/TLSDeprecation.mm:
264         * TestWebKitAPI/Tests/WebKitCocoa/TabOutOfWebView.mm:
265         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.h:
266         * TestWebKitAPI/Tests/WebKitCocoa/TestURLSchemeHandler.mm:
267         * TestWebKitAPI/Tests/WebKitCocoa/TextManipulation.mm:
268         * TestWebKitAPI/Tests/WebKitCocoa/TextSize.mm:
269         * TestWebKitAPI/Tests/WebKitCocoa/TextWidth.mm:
270         * TestWebKitAPI/Tests/WebKitCocoa/TopContentInset.mm:
271         * TestWebKitAPI/Tests/WebKitCocoa/UserInitiatedActionInNavigationAction.mm:
272         * TestWebKitAPI/Tests/WebKitCocoa/VideoControlsManager.mm:
273         * TestWebKitAPI/Tests/WebKitCocoa/VideoQualityDisplayCompositing.mm:
274         * TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
275         * TestWebKitAPI/Tests/WebKitCocoa/WKPDFView.mm:
276         * TestWebKitAPI/Tests/WebKitCocoa/WKRequestActivatedElementInfo.mm:
277         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewFindString.mm:
278         * TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm:
279         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
280         * TestWebKitAPI/Tests/WebKitCocoa/_WKInputDelegate.mm:
281         * TestWebKitAPI/Tests/WebKitLegacy/ios/ScrollingDoesNotPauseMedia.mm:
282         * TestWebKitAPI/Tests/WebKitLegacy/mac/AccessingPastedImage.mm:
283         * TestWebKitAPI/Tests/ios/AccessibilityTestsIOS.mm:
284         * TestWebKitAPI/Tests/ios/DataDetectorsTestIOS.mm:
285         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
286         * TestWebKitAPI/Tests/ios/KeyboardInputTestsIOS.mm:
287         * TestWebKitAPI/Tests/ios/OverflowScrollViewTests.mm:
288         * TestWebKitAPI/Tests/ios/RenderingProgressTests.mm:
289         * TestWebKitAPI/Tests/ios/ScrollViewInsetTests.mm:
290         * TestWebKitAPI/Tests/ios/ScrollViewScrollabilityTests.mm:
291         * TestWebKitAPI/Tests/ios/SelectionByWord.mm:
292         * TestWebKitAPI/Tests/ios/SelectionModifyByParagraphBoundary.mm:
293         * TestWebKitAPI/Tests/ios/TestInputDelegate.h:
294         * TestWebKitAPI/Tests/ios/TestInputDelegate.mm:
295         * TestWebKitAPI/Tests/ios/TextAutosizingBoost.mm:
296         * TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:
297         * TestWebKitAPI/Tests/ios/WKScrollViewTests.mm:
298         * TestWebKitAPI/Tests/ios/WKWebViewAutofillTests.mm:
299         * TestWebKitAPI/Tests/ios/WKWebViewPausePlayingAudioTests.mm:
300         * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
301         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm:
302         * TestWebKitAPI/Tests/mac/BackForwardList.mm:
303         * TestWebKitAPI/Tests/mac/BackgroundColor.mm:
304         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
305         * TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
306         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
307         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
308         * TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
309         * TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
310         * TestWebKitAPI/Tests/mac/IsNavigationActionTrusted.mm:
311         * TestWebKitAPI/Tests/mac/LegacyDragAndDropTests.mm:
312         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
313         * TestWebKitAPI/Tests/mac/SSLKeyGenerator.mm:
314         * TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
315         * TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
316         * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
317         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm:
318         * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm:
319         * TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm:
320         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm:
321         * TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
322         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
323         * TestWebKitAPI/cocoa/NSItemProviderAdditions.h:
324         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
325         * TestWebKitAPI/cocoa/TestContextMenuDriver.h:
326         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
327         * TestWebKitAPI/cocoa/TestProtocol.mm:
328         * TestWebKitAPI/cocoa/TestUIDelegate.h:
329         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm:
330         * TestWebKitAPI/ios/PencilKitTestSPI.h:
331         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
332         * TestWebKitAPI/mac/NSFontPanelTesting.h:
333         * TestWebKitAPI/mac/NSFontPanelTesting.mm:
334         * TestWebKitAPI/mac/OffscreenWindow.h:
335         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
336         * TestWebKitAPI/mac/TestBrowsingContextLoadDelegate.mm:
337         * TestWebKitAPI/mac/TestDraggingInfo.h:
338         * TestWebKitAPI/mac/TestFilePromiseReceiver.h:
339         * TestWebKitAPI/mac/TestFontOptions.h:
340         * TestWebKitAPI/mac/TestInspectorBar.h:
341         * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
342         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
343         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.h:
344         * WebKitTestRunner/mac/PoseAsClass.mm:
345         More #import, less #pragma once.
346
347 2020-04-20  Diego Pino Garcia  <dpino@igalia.com>
348
349         [Flatpak SDK] Prevent exception when calling git in a non-git repository
350         https://bugs.webkit.org/show_bug.cgi?id=210737
351
352         Reviewed by Philippe Normand.
353
354         * flatpak/flatpakutils.py:
355         (WebkitFlatpak.is_branch_build): Return false if command executes in a
356         non-git repository (i.e SVN).
357
358 2020-04-20  Philippe Normand  <pnormand@igalia.com>
359
360         [Flatpak SDK] Drive-by fixes
361         https://bugs.webkit.org/show_bug.cgi?id=210557
362
363         Reviewed by Žan Doberšek.
364
365         * flatpak/flatpakutils.py:
366         (WebkitFlatpak.run_in_sandbox): Properly format error message.
367         (WebkitFlatpak.main): Show flatpak update output.
368
369 2020-04-20  Sergio Villar Senin  <svillar@igalia.com>
370
371         [WebXR][WPE] Let XR_RUNTIME_JSON environment variable go through for testing
372         https://bugs.webkit.org/show_bug.cgi?id=210738
373
374         Reviewed by Žan Doberšek.
375
376         The OpenXR loader might be instructed to load a specific runtime by
377         using the XR_RUNTIME_JSON environment variable. Let it get in for testing.
378
379         * Scripts/webkitpy/port/wpe.py:
380         (WPEPort.setup_environ_for_server): Copy XR_RUNTIME_JSON if set.
381
382 2020-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>
383
384         [GTK][WPE] Enable resource load statistics
385         https://bugs.webkit.org/show_bug.cgi?id=210184
386
387         Reviewed by Žan Doberšek.
388
389         Implement TestController::loadedThirdPartyDomains() and TestController::clearLoadedThirdPartyDomains() for
390         non-cocoa ports.
391
392         * WebKitTestRunner/TestController.cpp:
393         (WTR::LoadedThirdPartyDomainsCallbackContext::LoadedThirdPartyDomainsCallbackContext):
394         (WTR::loadedThirdPartyDomainsCallback):
395         (WTR::TestController::loadedThirdPartyDomains):
396         (WTR::TestController::clearLoadedThirdPartyDomains):
397
398 2020-04-20  David Kilzer  <ddkilzer@apple.com>
399
400         check-webkit-style should not complain about missing config.h header in WebKitLegacy source files
401         <https://webkit.org/b/210734>
402
403         Reviewed by Darin Adler.
404
405         * Scripts/webkitpy/style/checkers/cpp.py:
406         (_NO_CONFIG_H_PATH_PATTERNS):
407         - Add '^Source/WebKitLegacy/' to the list.
408         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
409         (OrderOfIncludesTest.test_primary_header):
410         - Add test for Source/WebKitLegacy source file.
411
412 2020-04-19  Brady Eidson  <beidson@apple.com>
413
414         Add WKScriptMessageHandler API that asynchronously responds with a promise.
415         rdar://problem/57243492 and https://bugs.webkit.org/show_bug.cgi?id=206398
416
417         Reviewed by Andy Estes.
418
419         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
420         (TEST):
421         (webViewForScriptMessageHandlerMultipleHandlerRemovalTest):
422         (-[AsyncScriptMessageHandler userContentController:didReceiveScriptMessage:replyHandler:]):
423
424 2020-04-19  Ross Kirsling  <ross.kirsling@sony.com>
425
426         [ECMA-402] Intl.RelativeTimeFormat missing in WebKit
427         https://bugs.webkit.org/show_bug.cgi?id=209770
428
429         Reviewed by Darin Adler.
430
431         * Scripts/run-jsc-stress-tests:
432         Add runIntlRelativeTimeFormatEnabled.
433
434 2020-04-19  Don Olmstead  <don.olmstead@sony.com>
435
436         [CMake] Consolidate TestNetscapePlugin build
437         https://bugs.webkit.org/show_bug.cgi?id=210691
438
439         Reviewed by Fujii Hironori.
440
441         The DumpRenderTree CMakeLists.txt contained a definition of TestNetscapePlugIn
442         which was used for WebKitLegacy ports. The TestNetscapePlugIn directory also had
443         a CMakeLists.txt used by GTK for its port. The definitions in DumpRenderTree's
444         CMake are moved into the TestNetscapePlugIn CMake to provide a common definition
445         for all ports that ENABLE_NETSCAPE_PLUGIN_API.
446
447         * DumpRenderTree/CMakeLists.txt:
448         * DumpRenderTree/PlatformWin.cmake:
449         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
450         * DumpRenderTree/TestNetscapePlugIn/PlatformGTK.cmake: Added.
451         * DumpRenderTree/TestNetscapePlugIn/PlatformWin.cmake: Added.
452         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugIn.def: Renamed from Tools/DumpRenderTree/win/TestNetscapePlugin.def.
453         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugIn.rc: Renamed from Tools/DumpRenderTree/win/TestNetscapePlugin.rc.
454         * DumpRenderTree/TestNetscapePlugIn/win/resource.h: Renamed from Tools/DumpRenderTree/win/resource.h.
455
456 2020-04-19  Emilio Cobos Álvarez  <emilio@crisal.io>
457
458         Allow to override sccache server port.
459         https://bugs.webkit.org/show_bug.cgi?id=210722
460
461         Reviewed by Philippe Normand.
462
463         This is useful so that sccache can work both inside and outside the sandbox,
464         without getting confused about flatpak's chroot.
465
466         * flatpak/flatpakutils.py:
467         (WebkitFlatpak.run_in_sandbox):
468
469 2020-04-19  Darin Adler  <darin@apple.com>
470
471         REGRESSION (r260334): SpacebarScrolling.cpp (test in TestWebKitAPI) fails to compile because it includes an Objective-C header
472         https://bugs.webkit.org/show_bug.cgi?id=210723
473
474         Reviewed by Brady Eidson.
475
476         * TestWebKitAPI/Tests/WebKit/SpacebarScrolling.cpp: Instead of including
477         WKPreferencesPrivate.h, an Objective-C header, include WKPreferencesRefPrivate.h,
478         the header with the functions this test is trying to use.
479
480 2020-04-18  Darin Adler  <darin@apple.com>
481
482         Update header postprocessing version cutoff to keep Apple internal builds working
483         https://bugs.webkit.org/show_bug.cgi?id=210708
484
485         Reviewed by Brady Eidson.
486
487         * DumpRenderTree/ios/TextInputControllerIOS.m:
488         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
489         * DumpRenderTree/mac/EditingDelegate.mm:
490         * DumpRenderTree/mac/EventSendingController.h:
491         * DumpRenderTree/mac/EventSendingController.mm:
492         * DumpRenderTree/mac/FrameLoadDelegate.mm:
493         * DumpRenderTree/mac/ObjCPlugin.m:
494         * DumpRenderTree/mac/PixelDumpSupportMac.mm:
495         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
496         * DumpRenderTree/mac/UIScriptControllerMac.mm:
497         Removed includes of <WebKit/WebKit.h>, the header for modern WebKit, from the files
498         here that are intending to use WebKitLegacy. This is harmless, except for if someone
499         builds DumpRenderTree *before* building WebKit as I just did.
500
501 2020-04-18  Brady Eidson  <beidson@apple.com>
502
503         Fix WebUserContentControllerProxy vs ContentWorld lifetime
504         https://bugs.webkit.org/show_bug.cgi?id=210700
505
506         Reviewed by Alex Christensen.
507
508         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEvaluateJavaScript.mm:
509         (-[DummyMessageHandler userContentController:didReceiveScriptMessage:]):
510         (TEST): Make sure removing a script message handler from a particular world
511           doesn't also destroy the other JavaScript contents of that world.
512
513 2020-04-18  Daniel Bates  <dabates@apple.com>
514
515         Add some more tests for -focusTextInputContext:placeCaretAt:completionHandler:
516         https://bugs.webkit.org/show_bug.cgi?id=210624
517
518         Reviewed by Simon Fraser.
519
520         Test behavior when the target element is already focused, when the target element
521         is programmatically replaced, and focusing the target element after the page was
522         navigated away.
523
524         Also while I am here, fix up the test FocusFieldAndPlaceCaretOutsideField to
525         use the size of the exampleText constant - 1 instead of hardcoding this value.
526         This will future proof this test should the example text string literal change.
527
528         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
529         (TEST):
530
531 2020-04-18  Alex Christensen  <achristensen@webkit.org>
532
533         Fix client certificate authentication when using non-default WKWebsiteDataStores
534         https://bugs.webkit.org/show_bug.cgi?id=210681
535
536         Reviewed by Brady Eidson.
537
538         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
539         (TestWebKitAPI::TEST):
540
541 2020-04-17  Kate Cheney  <katherine_cheney@apple.com>
542
543         Enable service workers for app-bound domains
544         https://bugs.webkit.org/show_bug.cgi?id=210451
545         <rdar://problem/61479474>
546
547         Reviewed by Brent Fulgham.
548
549         Adds 2 test cases to make sure service workers behave properly on
550         app bound domains, and that the APIs are not available on non-app
551         bound domains.
552
553         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
554         (-[SWInAppBrowserPrivacyMessageHandler userContentController:didReceiveScriptMessage:]):
555
556 2020-04-17  Alex Christensen  <achristensen@webkit.org>
557
558         NetworkSessionCocoa should request client certificate only once per host/port
559         https://bugs.webkit.org/show_bug.cgi?id=210626
560         <rdar://problem/60340449>
561
562         Reviewed by Geoffrey Garen.
563
564         * TestWebKitAPI/Tests/WebKitCocoa/Challenge.mm:
565         (TestWebKitAPI::clientCertServerWithCertVerifier):
566         (TestWebKitAPI::TEST):
567         * TestWebKitAPI/cocoa/HTTPServer.h:
568         (TestWebKitAPI::HTTPServer::HTTPResponse::HTTPResponse):
569         * TestWebKitAPI/cocoa/HTTPServer.mm:
570         (TestWebKitAPI::HTTPServer::HTTPServer):
571
572 2020-04-17  David Kilzer  <ddkilzer@apple.com>
573
574         Bug 210645: REGRESSION (r211095): [iOS] TestRunnerWKWebView leaks @property accessibilitySpeakSelectionContent
575         <https://webkit.org/b/210645>
576         <rdar://problem/61927607>
577
578         Reviewed by Chris Fleizach.
579
580         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
581         (-[TestRunnerWKWebView dealloc]):
582         - Release accessibilitySpeakSelectionContent in -dealloc.
583
584 2020-04-17  Brady Eidson  <beidson@apple.com>
585
586         Pass sandbox extensions for back/forward list navigations after the policy is decided at process-swap time.
587         <rdar://problem/59535167> and https://bugs.webkit.org/show_bug.cgi?id=210623
588
589         Reviewed by Geoff Garen.
590
591         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
592
593 2020-04-17  Brent Fulgham  <bfulgham@apple.com>
594
595         Unreviewed build fix after r260269.
596
597         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
598         (TEST): Correct argument order.
599
600 2020-04-17  Jer Noble  <jer.noble@apple.com>
601
602         Bring Fullscreen API + alert() behavior from iOS to macOS
603         https://bugs.webkit.org/show_bug.cgi?id=210662
604
605         Reviewed by Eric Carlson.
606
607         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
608         * TestWebKitAPI/Tests/WebKitCocoa/FullscreenAlert.mm: Added.
609         (TestWebKitAPI::TEST):
610
611 2020-04-17  Don Olmstead  <don.olmstead@sony.com>
612
613         [CMake] Add WebKit::WebCore target
614         https://bugs.webkit.org/show_bug.cgi?id=210445
615
616         Reviewed by Michael Catanzaro.
617
618         Use the WebKit::WebCore target within tests and developer tools.
619
620         * DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
621         * MiniBrowser/wpe/CMakeLists.txt:
622         * TestWebKitAPI/CMakeLists.txt:
623         * TestWebKitAPI/PlatformGTK.cmake:
624         * TestWebKitAPI/PlatformWPE.cmake:
625         * TestWebKitAPI/PlatformWin.cmake:
626         * TestWebKitAPI/glib/CMakeLists.txt:
627
628 2020-04-17  Antoine Quint  <graouts@apple.com>
629
630         Stop including style rules related to media controls in the UA style sheet when Modern Media Controls are enabled
631         https://bugs.webkit.org/show_bug.cgi?id=210606
632
633         Unreviewed build fix after r260261.
634
635         * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
636         (TEST):
637
638 2020-04-17  Claudio Saavedra  <csaavedra@igalia.com>
639
640         [GTK] Update for GdkKeymap API changes
641         https://bugs.webkit.org/show_bug.cgi?id=210642
642
643         Reviewed by Adrian Perez de Castro.
644
645         No new tests needed.
646
647         gdk_keymap_get_default() is deprecated in GTK+ 3.22, so use
648         gdk_keymap_get_for_display() instead. Since in GTK4 this method is
649         removed to gdk_display_get_keymap(), add a helper to
650         GtkVersioning.h to avoid cluttering with ifdefs all over the
651         place.
652
653         * TestWebKitAPI/glib/WebKitGLib/gtk/WebViewTestGtk.cpp:
654         (WebViewTest::keyStroke):
655         * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
656         (TestWebKitAPI::doKeyStroke):
657         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
658         (WTR::EventSenderProxy::keyDown):
659
660 2020-04-17  Antoine Quint  <graouts@apple.com>
661
662         Allow the UserStyleLevel to be set through _WKUserStyleSheet
663         https://bugs.webkit.org/show_bug.cgi?id=210653
664         <rdar://problem/60506645>
665
666         Reviewed by Tim Horton.
667
668         Add new tests for the "level" parameter when creating a _WKUserStyleSheet.
669
670         * TestWebKitAPI/Tests/WebKitCocoa/UserContentController.mm:
671         (TEST):
672
673 2020-04-17  David Kilzer  <ddkilzer@apple.com>
674
675         REGRESSION (r162729): [iOS] WebKitTestRunner over-releases UITextField in WTR::PlatformWebView::removeChromeInputField()
676         <https://webkit.org/b/210643>
677         <rdar://problem/61927190>
678
679         Reviewed by Wenson Hsieh.
680
681         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
682         (WTR::PlatformWebView::removeChromeInputField):
683         - Remove unnecessary -release.
684
685 2020-04-17  Per Arne Vollan  <pvollan@apple.com>
686
687         [iOS] Deny iokit open access to graphics related classes
688         https://bugs.webkit.org/show_bug.cgi?id=210616
689
690         Reviewed by Darin Adler.
691
692         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
693         * TestWebKitAPI/Tests/WebKit/AGXCompilerService.mm: Added.
694         (TEST):
695
696 2020-04-17  Philippe Normand  <pnormand@igalia.com>
697
698         [Flatpak SDK] Not fully hooked in BuildSlaveSupport
699         https://bugs.webkit.org/show_bug.cgi?id=210548
700
701         Reviewed by Carlos Alberto Lopez Perez.
702
703         * Scripts/webkitdirs.pm:
704         (determineBaseProductDir): Flatpak SDK builds use a dedicated product directory per port.
705
706 2020-04-16  Lauro Moura  <lmoura@igalia.com>
707
708         [GTK] A couple of API tests are flaky failing on X11.
709
710         Unreviewed test gardening.
711
712         * TestWebKitAPI/glib/TestExpectations.json:
713
714 2020-04-16  Daniel Bates  <dabates@apple.com>
715
716         Remove unused -_focusTextInputContext
717         https://bugs.webkit.org/show_bug.cgi?id=210619
718
719         Reviewed by Darin Adler.
720
721         Remove test now that the SPI was removed.
722
723         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
724         (-[TestWKWebView synchronouslyFocusTextInputContext:]): Deleted.
725
726 2020-04-16  Yusuke Suzuki  <ysuzuki@apple.com>
727
728         Add slack-aware WKR implementation
729         https://bugs.webkit.org/show_bug.cgi?id=210425
730
731         Reviewed by Alexey Proskuryakov.
732
733         This patch adds new WKR implementation, which is posting changes to #changes in WebKit slack.
734         Currently, we are polling git.webkit.org's feed once a minute. The more efficient way to implement
735         this bot is introducing post-commit hook, but for now, this polling strategy just works.
736
737         * WKR/.gitignore: Added.
738         * WKR/ReadMe.md: Added.
739         * WKR/WKR.mjs: Added.
740         * WKR/data/.gitignore: Added.
741         * WKR/package-lock.json: Added.
742         * WKR/package.json: Added.
743
744 2020-04-16  Daniel Bates  <dabates@apple.com>
745
746         [iOS] Add a way to focus a text input and place a caret
747         https://bugs.webkit.org/show_bug.cgi?id=210611
748         <rdar://problem/61893062>
749
750         Reviewed by Darin Adler.
751
752         Add some tests.
753
754         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
755         (-[TestWKWebView synchronouslyFocusTextInputContext:placeCaretAt:]): Added.
756         (webViewLoadHTMLStringAndWaitForAllFramesToPaint): Use the bundle's TestWebKitAPI.resources directory
757         as the base URL so that we have a valid file URL. Some of the tests will then
758         call -_setAllowUniversalAccessFromFileURLs to allow the main frame access to
759         the unique-origin child frame contents.
760         (TEST):
761
762 2020-04-16  Daniel Bates  <dabates@apple.com>
763
764         REGRESSION (r259762): Should always hit test for editable elements if the WKWebView is fully editable
765         https://bugs.webkit.org/show_bug.cgi?id=210558
766         <rdar://problem/61798347>
767
768         Reviewed by Wenson Hsieh.
769
770         Add a test.
771
772         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
773         (TEST):
774
775 2020-04-16  Daniel Bates  <dabates@apple.com>
776
777         Move -_requestTextInputContextsInRect to WKContentView to simplify implementation
778         https://bugs.webkit.org/show_bug.cgi?id=210398
779         <rdar://problem/61656931>
780
781         Reviewed by Darin Adler.
782
783         Update test now that -_requestTextInputContextsInRect has moved from WKWebView to WKContentView.
784         I expose new testing-only WKWebView SPI to access it on the content view.
785
786         * TestWebKitAPI/Tests/WebKitCocoa/DocumentEditingContext.mm:
787         (-[TestWKWebView synchronouslyRequestDocumentContext:]): Added; due to category name change.
788         (-[TestWKWebView synchronouslyAdjustSelectionWithDelta:]): Added; due to category name change.
789         * TestWebKitAPI/Tests/WebKitCocoa/RequestTextInputContext.mm:
790         (-[WKWebView synchronouslyRequestTextInputContextsInRect:]): Deleted; due to category name change.
791         (-[WKWebView synchronouslyFocusTextInputContext:]): Deleted; due to category name change.
792         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
793         (WTR::UIScriptControllerIOS::mayContainEditableElementsInRect): Convert from content coordinates
794         to WKWebView coordinates now that -_mayContainEditableElementsInRect expects it.
795
796 2020-04-16  Philippe Normand  <pnormand@igalia.com>
797
798         Unreviewed, GTK clean build fix after r260132.
799
800         * TestWebKitAPI/gtk/main.cpp:
801         (main): Don't use GtkVersioning here. A dependency on the WebCore
802         private headers for this single file is overkill.
803
804 2020-04-16  Carlos Alberto Lopez Perez  <clopez@igalia.com>
805
806         [GTK] MiniBrowser opens new windows too small causing failures on some WPT tests
807         https://bugs.webkit.org/show_bug.cgi?id=210206
808
809         Reviewed by Carlos Garcia Campos.
810
811         Add two API test to check that window.open() by default gets a size
812         request equal to the old window if there is no default window size,
813         or to the default window if there is a default window size.
814
815         A new function helper setCreateNewWebViewsInWindowsWithDefaultSize()
816         its added to create new webviews in new windows automatically, which
817         its needed to test the case of having a default window size.
818
819         * TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:
820         (testWebViewWindowProperties):
821         (testWebViewOpenWindowDefaultSize):
822         (testWebViewOpenWindowNoDefaultSize):
823         (beforeAll):
824
825 2020-04-15  Tim Horton  <timothy_horton@apple.com>
826
827         REGRESSION (r258337): Crash when right clicking on link that uses the system UI font with optimizeLegibility on Mojave
828         https://bugs.webkit.org/show_bug.cgi?id=210575
829         <rdar://problem/61646717>
830
831         Reviewed by Darin Adler.
832
833         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewGetContents.mm:
834         (TEST):
835         Add an API test ensuring that we can encode and decode a NSAttributedString
836         that includes a system-ui font with optimizeLegibility on.
837
838 2020-04-15  John Wilander  <wilander@apple.com>
839
840         Add SPI to configure WebsiteDataStores with a URL for standalone web applications and use it to disable first-party website data removal in ITP
841         https://bugs.webkit.org/show_bug.cgi?id=209634
842         <rdar://problem/60943970>
843
844         Reviewed by Alex Christensen.
845
846         Added a new test option called standaloneWebApplicationURL so that layout tests can
847         configure the website data store accordingly. Picking it up and using it requires
848         creating a new website data store with a configuration that has the standalone web
849         application URL.
850
851         * WebKitTestRunner/TestController.cpp:
852         (WTR::TestController::configureWebsiteDataStoreTemporaryDirectories):
853         (WTR::TestController::defaultWebsiteDataStore):
854         (WTR::parseStringTestHeaderValueAsURL):
855         (WTR::updateTestOptionsFromTestHeader):
856         * WebKitTestRunner/TestController.h:
857         * WebKitTestRunner/TestOptions.h:
858         (WTR::TestOptions::hasSameInitializationOptions const):
859         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
860         (WTR::TestController::platformCreateWebView):
861
862 2020-04-15  Chris Dumez  <cdumez@apple.com>
863
864         [IPC Hardening] MachMessage::messageSize() should use checked arithmetic
865         https://bugs.webkit.org/show_bug.cgi?id=210567
866         <rdar://problem/61734355>
867
868         Reviewed by Geoff Garen.
869
870         Add API test coverage for / operator in Checked.
871
872         * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
873         (TestWebKitAPI::TEST):
874
875 2020-04-15  Brent Fulgham  <bfulgham@apple.com>
876
877         [Cocoa] Remove generic parameter serialization fallback
878         https://bugs.webkit.org/show_bug.cgi?id=210509
879         <rdar://problem/55522650>
880
881         Reviewed by Geoffrey Garen.
882
883         * TestWebKitAPI/Tests/WebKitCocoa/BundleFormDelegate.mm:
884         (WKWebProcessPlugInWithoutRegisteredCustomClass): Update to reflect
885         fact that we block serialization of unregistered classes.
886
887 2020-04-15  Carlos Garcia Campos  <cgarcia@igalia.com>
888
889         [GTK4] Fix use of gtk init functions
890         https://bugs.webkit.org/show_bug.cgi?id=210550
891
892         Reviewed by Adrian Perez de Castro.
893
894         Include GtkVersioning.h instead of gtk.h.
895
896         * TestWebKitAPI/Tests/WebKitGtk/AccessibilityTestServer.cpp:
897         * TestWebKitAPI/Tests/WebKitGtk/InspectorTestServer.cpp:
898         * TestWebKitAPI/gtk/main.cpp:
899         * WebKitTestRunner/gtk/main.cpp:
900
901 2020-04-15  Jonathan Bedard  <jbedard@apple.com>
902
903         REGRESSION: [ Mojave+ Debug WK1 ] Layout Test imported/blink/storage/indexeddb/blob-basics-metadata.html is a flaky timeout
904         https://bugs.webkit.org/show_bug.cgi?id=199117
905         <rdar://problem/52967035>
906
907         Reviewed by Alexey Proskuryakov.
908
909         * Scripts/run-javascriptcore-tests: Set JSC_useKernTCSM to false.
910         * Scripts/webkitpy/port/base.py:
911         (Port.setup_environ_for_server): Forward JSC_useKernTCSM.
912         * Scripts/webkitpy/port/driver.py:
913         (Driver._setup_environ_for_driver): Set JSC_useKernTCSM to false.
914
915 2020-04-15  Devin Rousso  <drousso@apple.com>
916
917         [ESNext] Implement logical assignment operators
918         https://bugs.webkit.org/show_bug.cgi?id=209716
919
920         Reviewed by Ross Kirsling.
921
922         * Scripts/run-jsc-stress-tests:
923
924 2020-04-14  Jer Noble  <jer.noble@apple.com>
925
926         WKTR always enables capturing audio/video in GPUProcess
927         https://bugs.webkit.org/show_bug.cgi?id=210319
928
929         Reviewed by Tim Horton.
930
931         Capturing in the GPUProcess should be off by default. GPU capture can be enabled at runtime via
932         the --internal-feature flag of run-webkit-tests.
933
934         * WebKitTestRunner/TestOptions.h:
935
936 2020-04-14  Peng Liu  <peng.liu6@apple.com>
937
938         Adopt interface AVAudioRoutingArbiter for Mac
939         https://bugs.webkit.org/show_bug.cgi?id=210167
940
941         Reviewed by Eric Carlson.
942
943         Add test for softlink of AVAudioRoutingArbiter.
944
945         * TestWebKitAPI/Tests/WebCore/cocoa/AVFoundationSoftLinkTest.mm:
946         (TestWebKitAPI::TEST):
947
948 2020-04-14  Per Arne Vollan  <pvollan@apple.com>
949
950         [iOS] Content filtering needs access to the frontboard service
951         https://bugs.webkit.org/show_bug.cgi?id=210505
952
953         Reviewed by Geoffrey Garen.
954
955         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
956         * TestWebKitAPI/Tests/WebKit/WebFilter.mm: Added.
957         (isManagedSessionMethodOverride):
958         (TEST):
959
960 2020-04-14  Andres Gonzalez  <andresg_22@apple.com>
961
962         Make WTR::AccessibilityUIElements calls to accessibilitySetValue run on AX secondary thread.
963         https://bugs.webkit.org/show_bug.cgi?id=210500
964
965         Reviewed by Chris Fleizach.
966
967         Needed to test accessibility isolated tree mode. Follow up to
968         https://bugs.webkit.org/show_bug.cgi?id=210392.
969
970         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
971         (AccessibilityUIElement::setBoolAttributeValue):
972         (AccessibilityUIElement::resetSelectedTextMarkerRange):
973         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
974         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
975         (WTR::setAttributeValue):
976         (WTR::attributesOfElement):
977         (WTR::descriptionOfElements):
978         (WTR::AccessibilityUIElement::stringDescriptionOfAttributeValue):
979         (WTR::AccessibilityUIElement::stringAttributeValue):
980         (WTR::AccessibilityUIElement::uiElementArrayAttributeValue const):
981         (WTR::AccessibilityUIElement::uiElementAttributeValue const):
982         (WTR::AccessibilityUIElement::boolAttributeValue):
983         (WTR::AccessibilityUIElement::setBoolAttributeValue):
984         (WTR::AccessibilityUIElement::setValue):
985         (WTR::AccessibilityUIElement::setSelectedTextRange):
986         (WTR::AccessibilityUIElement::setSelectedVisibleTextRange):
987         (WTR::AccessibilityUIElement::setSelectedChild const):
988         (WTR::AccessibilityUIElement::setSelectedChildAtIndex const):
989         (WTR::AccessibilityUIElement::removeSelectionAtIndex const):
990         (WTR::AccessibilityUIElement::takeFocus):
991         (WTR::AccessibilityUIElement::resetSelectedTextMarkerRange):
992
993 2020-04-14  Brent Fulgham  <bfulgham@apple.com>
994
995         InjectedBundle parameters often need initialization function called before unarchiving
996         https://bugs.webkit.org/show_bug.cgi?id=189709
997         <rdar://problem/44573653>
998
999         Reviewed by Ryosuke Niwa.
1000
1001         * TestWebKitAPI/cocoa/WebProcessPlugIn/WebProcessPlugIn.mm:
1002         (-[WebProcessPlugIn additionalClassesForParameterCoder]): Added.
1003
1004 2020-04-14  Sergio Villar Senin  <svillar@igalia.com>
1005
1006         [Flatpak] Make run-webkit-tests obey WEBKIT_JHBUILD
1007         https://bugs.webkit.org/show_bug.cgi?id=210497
1008
1009         Reviewed by Philippe Normand.
1010
1011         run-webkit-tests in linux uses the flatpak SDK if the flatpak
1012         directories are found in the build directory. However it might the the case
1013         that a developer wants to run them using the jhbuild SDK which can be
1014         configured in parallel. We have the WEBKIT_JHBUILD environment variable to
1015         force other scripts to use jhbuild instead of flatpak so we can use it as well
1016         for this use case.
1017
1018         * flatpak/flatpakutils.py:
1019         (run_in_sandbox_if_available):
1020
1021 2020-04-14  Carlos Garcia Campos  <cgarcia@igalia.com>
1022
1023         [GTK] Bring back support for rendering scrollbars using the system appearance
1024         https://bugs.webkit.org/show_bug.cgi?id=209805
1025
1026         Reviewed by Michael Catanzaro.
1027
1028         Do not use system appearance for scrollbars in MiniBrowser and unit tests.
1029
1030         * MiniBrowser/gtk/main.c:
1031         (main):
1032         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
1033         (Test::Test):
1034
1035 2020-04-13  Devin Rousso  <drousso@apple.com>
1036
1037         REGRESSION (r259900) : Speedometer failing on Catalina-Release-WK2-Perf bot
1038         https://bugs.webkit.org/show_bug.cgi?id=210442
1039         <rdar://problem/61727169>
1040
1041         Reviewed by Stephanie Lewis.
1042
1043         * Scripts/webkitpy/performance_tests/perftest.py:
1044         (PerfTest):
1045
1046 2020-04-13  David Kilzer  <ddkilzer@apple.com>
1047
1048         check-webkit-style should warn about attributes that appear after function definitions
1049         <https://webkit.org/b/210459>
1050
1051         Reviewed by Darin Adler.
1052
1053         * Scripts/webkitpy/style/checkers/cpp.py:
1054         (_FunctionState.attributes_after_definition): Add.
1055         - Return list of attributes that appear after a function
1056           definition.
1057         (check_function_definition):
1058         - Add new check for attributes that appear after a function
1059           definition.
1060
1061         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1062         (CppStyleTest.test_decode_functions_missing_warn_unused_return):
1063         - Update test to fix new warning.
1064         (CppStyleTest.test_function_readability_for_attributes): Add.
1065         - Add tests.
1066
1067 2020-04-13  Kate Cheney  <katherine_cheney@apple.com>
1068
1069         http/tests/in-app-browser-privacy/app-bound-domain.html is a constant failure on iOS
1070         https://bugs.webkit.org/show_bug.cgi?id=210344
1071         <rdar://problem/61583925>
1072
1073         Reviewed by Brent Fulgham.
1074
1075         This patch creates a new TestOption parameter for enabling In-App
1076         Browser Privacy because its NSUserDefaults key is not set using the 
1077         internal or experimental keywords. It enables this flag for
1078         WebKitTestRunner if the option is set (and disables it otherwise).
1079
1080         * WebKitTestRunner/TestController.cpp:
1081         (WTR::updateTestOptionsFromTestHeader):
1082         * WebKitTestRunner/TestOptions.h:
1083         (WTR::TestOptions::hasSameInitializationOptions const):
1084         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1085         (WTR::TestController::platformAddTestOptions const):
1086         * WebKitTestRunner/ios/TestControllerIOS.mm:
1087         (WTR::TestController::platformResetStateToConsistentValues):
1088
1089 2020-04-13  Per Arne Vollan  <pvollan@apple.com>
1090
1091         [iOS] Remove unused UTType swizzler code
1092         https://bugs.webkit.org/show_bug.cgi?id=210435
1093
1094         Unreviewed rollout of r258120.
1095
1096         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1097         * TestWebKitAPI/Tests/WebKit/UTIFromTag.mm: Removed.
1098
1099 2020-04-13  Andres Gonzalez  <andresg_22@apple.com>
1100
1101         Make WTR::AccessibilityUIElement methods run on AX secondary thread.
1102         https://bugs.webkit.org/show_bug.cgi?id=210392
1103
1104         Reviewed by Chris Fleizach.
1105
1106         In order to test accessibility isolated tree mode, it is necessary to
1107         run WTR::AccessibilityUIElement methods on the AX secondary thread. This
1108         change uses the functionality built-in AccessibilityController to
1109         dispatch the calls to WebAccessibilityObjectWrapper to the AX thread.
1110
1111         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1112         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1113         (WTR::AccessibilityUIElement::AccessibilityUIElement):
1114         (WTR::supportedAttributes):
1115         (WTR::attributeValue):
1116         (WTR::descriptionOfValue):
1117         (WTR::attributesOfElement):
1118         (WTR::AccessibilityUIElement::getLinkedUIElements):
1119         (WTR::AccessibilityUIElement::getDocumentLinks):
1120         (WTR::AccessibilityUIElement::getUIElementsWithAttribute const):
1121         (WTR::AccessibilityUIElement::getChildren):
1122         (WTR::AccessibilityUIElement::getChildrenWithRange):
1123         (WTR::AccessibilityUIElement::rowHeaders const):
1124         (WTR::AccessibilityUIElement::columnHeaders const):
1125         (WTR::AccessibilityUIElement::elementAtPoint):
1126         (WTR::AccessibilityUIElement::indexOfChild):
1127         (WTR::AccessibilityUIElement::elementForAttribute const):
1128         (WTR::AccessibilityUIElement::elementForAttributeAtIndex const):
1129         (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
1130         (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
1131         (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
1132         (WTR::AccessibilityUIElement::ariaControlsElementAtIndex):
1133         (WTR::AccessibilityUIElement::ariaDetailsElementAtIndex):
1134         (WTR::AccessibilityUIElement::ariaErrorMessageElementAtIndex):
1135         (WTR::AccessibilityUIElement::disclosedRowAtIndex):
1136         (WTR::AccessibilityUIElement::rowAtIndex):
1137         (WTR::AccessibilityUIElement::selectedChildAtIndex const):
1138         (WTR::AccessibilityUIElement::selectedChildrenCount const):
1139         (WTR::AccessibilityUIElement::selectedRowAtIndex):
1140         (WTR::AccessibilityUIElement::titleUIElement):
1141         (WTR::AccessibilityUIElement::parentElement):
1142         (WTR::AccessibilityUIElement::disclosedByRow):
1143         (WTR::AccessibilityUIElement::numberAttributeValue):
1144         (WTR::AccessibilityUIElement::isAttributeSupported):
1145         (WTR::AccessibilityUIElement::isSelected const):
1146         (WTR::AccessibilityUIElement::selectTextWithCriteria):
1147
1148 2020-04-13  Lauro Moura  <lmoura@igalia.com>
1149
1150         [Flatpak SDK] test262-runner fails to run with WEBKIT_JHBUILD enabled
1151         https://bugs.webkit.org/show_bug.cgi?id=210430
1152
1153         Make sure we check the WEBKIT_JHBUILD env var directly to avoid
1154         requiring webkitdirs early and messing up Runner.pm compilation.
1155
1156         Reviewed by Philippe Normand.
1157
1158         * Scripts/test262-runner:
1159
1160 2020-04-13  David Kilzer  <ddkilzer@apple.com>
1161
1162         Add WARN_UNUSED_RETURN to decode methods in Source/WebKit
1163         <https://webkit.org/b/210423>
1164         <rdar://problem/61715582>
1165
1166         Reviewed by Alex Christensen.
1167
1168         * Scripts/webkitpy/style/checkers/cpp.py:
1169         (check_function_definition):
1170         - Add check for platformDecode() methods.
1171         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1172         (CppStyleTest):
1173         - Add tests for platformDecode() methods.
1174
1175 2020-04-13  Aakash Jain  <aakash_jain@apple.com>
1176
1177         [ews] Improve handling of unexpected network issues while communicating with Bugzilla
1178         https://bugs.webkit.org/show_bug.cgi?id=210377
1179
1180         Reviewed by Jonathan Bedard.
1181
1182         * BuildSlaveSupport/ews-app/ews/common/bugzilla.py:
1183         (BugzillaBeautifulSoup.authenticate):
1184
1185 2020-04-13  Aakash Jain  <aakash_jain@apple.com>
1186
1187         ews status-bubble hover-over message include unhelpful message 'Crash collection has quiesced'
1188         https://bugs.webkit.org/show_bug.cgi?id=210378
1189
1190         Reviewed by Jonathan Bedard.
1191
1192         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1193         (StatusBubble):
1194
1195 2020-04-11  Wenson Hsieh  <wenson_hsieh@apple.com>
1196
1197         [macOS] [WK1] Touch Bar flashes when typing in Vietnamese in Mail
1198         https://bugs.webkit.org/show_bug.cgi?id=210394
1199         <rdar://problem/60099560>
1200
1201         Reviewed by Tim Horton.
1202
1203         Add an API test that inserts an attributed string with the text replacement attribute, and verifies that we
1204         show the candidate list when inserting the string, and also don't temporarily hide the candidate list in the
1205         process of doing so.
1206
1207         To achieve this, we swizzle out calls to -[NSCandidateListTouchBarItem updateWithInsertionPointVisibility:] to
1208         detect when the candidate list is either hidden or made visible.
1209
1210         * TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h:
1211         * TestWebKitAPI/Tests/mac/CandidateTests.mm:
1212
1213         Fix a leak in an adjacent test too, while I'm touching this file.
1214
1215         (TestWebKitAPI::updateCandidateListWithVisibility):
1216
1217 2020-04-11  Aakash Jain  <aakash_jain@apple.com>
1218
1219         Buildbot: Force crash log submission after each test run (follow-up fix)
1220         https://bugs.webkit.org/show_bug.cgi?id=210202
1221         <rdar://problem/60508929>
1222
1223         Unreviewed follow-up fix.
1224
1225         * BuildSlaveSupport/ews-build/steps.py:
1226         (WaitForCrashCollection): Remove spaces from step name.
1227
1228 2020-04-11  Aakash Jain  <aakash_jain@apple.com>
1229
1230         Buildbot: Force crash log submission after each test run (follow-up fix)
1231         https://bugs.webkit.org/show_bug.cgi?id=210202
1232         <rdar://problem/60508929>
1233
1234         Unreviewed follow-up fix.
1235
1236         * BuildSlaveSupport/wait-for-crash-collection: Improved error message.
1237
1238 2020-04-11  David Kilzer  <ddkilzer@apple.com>
1239
1240         check-webkit-style should warn about 'decode' functions with missing WARN_UNUSED_RETURN attribute
1241         <https://webkit.org/b/210336>
1242         <rdar://problem/61585835>
1243
1244         Reviewed by Jonathan Bedard.
1245
1246         * Scripts/webkitpy/style/checkers/cpp.py:
1247         (_FunctionState.post_modifiers): Add.  Returns string of text
1248         that appears after the function definition's list of parameters.
1249         This is used to find the WARN_UNUSED_RETURN attribute in
1250         function declarations in header files.
1251         (_FunctionState.has_attribute): Add.  Takes a string (or regex)
1252         and searchs before and after the function definition for the
1253         attribute.
1254         (_FunctionState.has_return_type): Add.  Takes a string (or
1255         regex) and checks the return type of the fuction.
1256         (_FunctionState.is_static): Add.  Returns True for functions
1257         with the 'static' modifier.
1258         (check_function_definition): Add check for decode() functions
1259         with missing WARN_UNUSED_RETURN attribute.
1260         (CppChecker): Add 'security/missing_warn_unused_return' to the
1261         list of enabled style checkers.
1262
1263         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1264         (CppStyleTestBase.perform_function_definition_check): Add.  This
1265         runs the check_function_definition() function in cpp.py.
1266         (CppStyleTest.test_decode_functions_missing_warn_unused_return): Add.
1267         Tests for the new warning.
1268
1269 2020-04-10  Alex Christensen  <achristensen@webkit.org>
1270
1271         Add SPI to handle proxy authentication and require secure proxy connections
1272         https://bugs.webkit.org/show_bug.cgi?id=210343
1273         <rdar://problem/61546396> <rdar://problem/61546519> and <rdar://problem/61546658>
1274
1275         Reviewed by Geoffrey Garen.
1276
1277         * TestWebKitAPI/TCPServer.cpp:
1278         (TestWebKitAPI::TCPServer::startSecureConnection):
1279         (TestWebKitAPI::TCPServer::TCPServer):
1280         * TestWebKitAPI/TCPServer.h:
1281         * TestWebKitAPI/Tests/WebKitCocoa/Proxy.mm:
1282         (-[ProxyDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
1283         (-[ProxyDelegate waitForAlert]):
1284         (-[ProxyDelegate webView:didReceiveAuthenticationChallenge:completionHandler:]):
1285         (TestWebKitAPI::TEST):
1286
1287 2020-04-10  Devin Rousso  <drousso@apple.com>
1288
1289         Changes to shared testing JS files should not cause test failures due to console message line numbers changing
1290         https://bugs.webkit.org/show_bug.cgi?id=210303
1291
1292         Reviewed by Simon Fraser.
1293
1294         * DumpRenderTree/mac/UIDelegate.mm:
1295         (-[UIDelegate webView:addMessageToConsole:withSource:]):
1296         * DumpRenderTree/win/UIDelegate.cpp:
1297         (UIDelegate::webViewAddMessageToConsole):
1298         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
1299         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1300         (WTR::InjectedBundlePage::willAddMessageToConsole):
1301
1302 2020-04-10  Simon Fraser  <simon.fraser@apple.com>
1303
1304         Reset view navigation gesture state between tests
1305         https://bugs.webkit.org/show_bug.cgi?id=210283
1306
1307         Re-land r259818 with a null-check on m_webPageProxyForBackForwardListForCurrentSwipe.
1308
1309         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1310         (WTR::TestController::cocoaResetStateToConsistentValues):
1311
1312 2020-04-10  Alicia Boya García  <aboya@igalia.com>
1313
1314         [WTF] DataMutex: Add runUnlocked()
1315         https://bugs.webkit.org/show_bug.cgi?id=209811
1316
1317         Reviewed by Xabier Rodriguez-Calvar.
1318
1319         Tests for runUnlocked() and DataMutex checks are introduced.
1320
1321         * TestWebKitAPI/Tests/WTF/DataMutex.cpp:
1322         (TestWebKitAPI::TEST):
1323
1324 == Rolled over to ChangeLog-2020-04-10 ==