Support configurable autocapitalization.
[WebKit-https.git] / Tools / ChangeLog
1 2016-06-17  Enrique Ocaña González  <eocanha@igalia.com>
2
3         Unreviewed. Added myself to the list of committers.
4
5         * Scripts/webkitpy/common/config/contributors.json:
6
7 2016-06-16  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
8
9         [EFL][GTK] LayoutTest doesn't run on Ubuntu 16.04
10         https://bugs.webkit.org/show_bug.cgi?id=158141
11
12         Reviewed by Michael Catanzaro.
13
14         * Scripts/webkitpy/port/base.py: Detect php version in system, then use it.
15         (Port._is_debian_php_version_7):
16         (Port._debian_php_version):
17         (Port._apache_config_file_name_for_platform):
18         * efl/install-dependencies:
19         * gtk/install-dependencies:
20
21 2016-06-16  Filip Pizlo  <fpizlo@apple.com>
22
23         Baseline JIT should be concurrent
24         https://bugs.webkit.org/show_bug.cgi?id=158755
25
26         Reviewed by Geoffrey Garen.
27         
28         Need to disable concurrent JIT when running profiler tests. We should have been doing this
29         all along.
30
31         * Scripts/run-jsc-stress-tests:
32
33 2016-06-16  Per Arne Vollan  <pvollan@apple.com>
34
35         [Win] Accessibility implementation unable to recurse through document (sometimes) to find named elements
36         https://bugs.webkit.org/show_bug.cgi?id=140798
37
38         Reviewed by Brent Fulgham.
39        
40         Make sure layout is up-to-date before trying to find named elements. 
41
42         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
43         (AccessibilityController::rootElement):
44
45 2016-06-16  Chris Dumez  <cdumez@apple.com>
46
47         Unreviewed, rolling out r202002 and r202111.
48
49         Ryosuke says this was a JSBench regression on iOS
50
51         Reverted changesets:
52
53         "Make HashMap and HashSet work with Refs"
54         https://bugs.webkit.org/show_bug.cgi?id=158638
55         http://trac.webkit.org/changeset/202002
56
57         "Improve HashMap and HashSet support for Ref"
58         https://bugs.webkit.org/show_bug.cgi?id=158789
59         http://trac.webkit.org/changeset/202111
60
61 2016-06-15  Simon Fraser  <simon.fraser@apple.com>
62
63         [iOS WK2] On iPad, indirect focussing of a text field doesn't always scroll to the correct location
64         https://bugs.webkit.org/show_bug.cgi?id=158828
65
66         Reviewed by Enrica Casucci.
67         
68         Expose "forceIPadStyleZoomOnInputFocus" on UIScriptController, which allows iPad-style
69         zooming behavior on <input> focus in the iPhone simulator, which is used for testing.
70
71         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
72         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
73         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
74         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
75         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
76         * WebKitTestRunner/ios/TestControllerIOS.mm:
77         (WTR::TestController::platformResetStateToConsistentValues):
78         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
79         (WTR::UIScriptController::forceIPadStyleZoomOnInputFocus):
80         (WTR::UIScriptController::setForceIPadStyleZoomOnInputFocus):
81
82 2016-06-15  Sam Weinig  <sam@webkit.org>
83
84         Forward/Back keyboard shortcuts need to flip for RTL
85         https://bugs.webkit.org/show_bug.cgi?id=158823
86         <rdar://problem/25975359>
87
88         Reviewed by Darin Adler.
89
90         Add tests for flipping the behavior of command-left and command-right
91         under RTL mode.
92
93         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
94         * TestWebKitAPI/Tests/WebKit2Cocoa/CommandBackForward.mm: Added.
95         (-[CommandBackForwardOffscreenWindow isKeyWindow]):
96         (-[CommandBackForwardOffscreenWindow isVisible]):
97         (simulateCommandArrow):
98         (WebKit2_CommandBackForwardTest::SetUp):
99         (WebKit2_CommandBackForwardTestWKView::didFinishLoadForFrame):
100         (WebKit2_CommandBackForwardTestWKView::SetUp):
101         (WebKit2_CommandBackForwardTestWKView::loadFiles):
102         (-[CommandBackForwardNavigationDelegate webView:didFinishNavigation:]):
103         (WebKit2_CommandBackForwardTestWKWebView::SetUp):
104         (WebKit2_CommandBackForwardTestWKWebView::loadFiles):
105
106 2016-06-15  Tim Horton  <timothy_horton@apple.com>
107
108         Expose _shouldExpandContentToViewHeightForAutoLayout SPI on WKWebView
109         https://bugs.webkit.org/show_bug.cgi?id=158824
110         <rdar://problem/23713857>
111
112         Reviewed by Simon Fraser.
113
114         * TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:
115         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
116         (-[AutoLayoutWKWebView load:withWidth:expectingContentSize:resettingWidth:]):
117         (-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:resettingWidth:]):
118         (TEST):
119         Add a test for _shouldExpandContentToViewHeightForAutoLayout.
120
121 2016-06-13  Simon Fraser  <simon.fraser@apple.com>
122
123         [iOS WK2] Make it possible to test the Next/Previous buttons in the keyboard accessory bar
124         https://bugs.webkit.org/show_bug.cgi?id=158714
125
126         Reviewed by Enrica Casucci.
127
128         Add UIScriptController.keyboardAccessoryBar{Next,Previous} and hook it up to the WKContentView
129         method that gets called from UIKit.
130
131         Add a test that exercises it.
132
133         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
134         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
135         (WTR::UIScriptController::keyboardAccessoryBarNext):
136         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
137         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
138         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
139         (WTR::UIScriptController::keyboardAccessoryBarNext):
140         (WTR::UIScriptController::keyboardAccessoryBarPrevious):
141
142 2016-06-15  Sam Weinig  <sam@webkit.org>
143
144         Improve HashMap and HashSet support for Ref
145         https://bugs.webkit.org/show_bug.cgi?id=158789
146
147         Reviewed by Chris Dumez.
148
149         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
150         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
151         Add more cases to WTF_HashMap.Ref_Key, WTF_HashMap.Ref_Value and WTF_HashSet.Ref
152
153 2016-06-15  Aakash Jain  <aakash_jain@apple.com>
154
155         Too much log data generated during layout-tests on iOS Simulator
156         https://bugs.webkit.org/show_bug.cgi?id=158751
157
158         Reviewed by Alexey Proskuryakov.
159
160         * Scripts/webkitpy/port/ios.py:
161         (IOSSimulatorPort.developer_dir): memoized the property so that it is not called
162         repeatedly.
163
164 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
165
166         [Win][CMake] Changes in WebKit options are not reflected in incremental builds.
167         https://bugs.webkit.org/show_bug.cgi?id=158727
168
169         Reviewed by Alex Christensen.
170
171         Delete CMake cache file if WebKit options have been modified.
172
173         * Scripts/build-webkit:
174         * Scripts/webkitdirs.pm:
175         (shouldRemoveCMakeCache):
176
177 2016-06-15  Romain Bellessort  <romain.bellessort@crf.canon.fr>
178
179         Enabling Shadow DOM for all platforms
180         https://bugs.webkit.org/show_bug.cgi?id=158738
181
182         Reviewed by Ryosuke Niwa.
183
184         Removed Shadow DOM from options (enabled by default)
185
186         * Scripts/webkitperl/FeatureList.pm:
187         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
188
189 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
190
191         [Win] The test accessibility/selected-text-range-aria-elements.html is failing.
192         https://bugs.webkit.org/show_bug.cgi?id=158732
193
194         Reviewed by Brent Fulgham.
195
196         Implement selectedTextRange() method.
197
198         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
199         (AccessibilityUIElement::selectedTextRange):
200
201 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
202
203         [Win] MiniBrowser is not DPI aware.
204         https://bugs.webkit.org/show_bug.cgi?id=158733
205
206         Reviewed by Brent Fulgham.
207
208         Call Win32 api function to let Windows know that we will scale the contents ourselves.
209
210         * MiniBrowser/win/WinMain.cpp:
211         (wWinMain):
212
213 2016-06-15  Per Arne Vollan  <pvollan@apple.com>
214
215         Unreviewed: add new email address to contributors.json.
216
217         * Scripts/webkitpy/common/config/contributors.json:
218
219 2016-06-14  Keith Miller  <keith_miller@apple.com>
220
221         JSBench should use geometric mean
222         https://bugs.webkit.org/show_bug.cgi?id=158775
223
224         Reviewed by Mark Lam.
225
226         For some reason JSBench was using algebraic mean. Since each test
227         is pretty substantially different it should use geometric mean
228         instead.
229
230         * Scripts/run-jsc-benchmarks:
231
232 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
233
234         Debug crash logs are not fully symbolicated on Yosemite
235         https://bugs.webkit.org/show_bug.cgi?id=158760
236
237         Reviewed by Darin Adler.
238
239         * BuildSlaveSupport/build.webkit.org-config/master.cfg: Don't enable dSYM generation
240         for debug builds on Yosemite.
241
242 2016-06-14  Alexey Proskuryakov  <ap@apple.com>
243
244         Tests don't work in iOS Simulator when ASan is enabled
245         https://bugs.webkit.org/show_bug.cgi?id=158726
246
247         Reviewed by David Kilzer.
248
249         * Scripts/webkitpy/port/driver.py:
250         (Driver._setup_environ_for_driver): Added a FIXME.
251         * Scripts/webkitpy/port/ios.py:
252         (IOSSimulatorPort.setup_environ_for_server): Don't try to insert a dylib built for
253         simulator into LayoutTestRelay, which is a macOS tool.
254
255 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
256
257         Continuous "Reentrancy avoided" error messages in run-webkit-tests if Simulator quits unexpectedly
258         https://bugs.webkit.org/show_bug.cgi?id=158756
259
260         Reviewed by Alexey Proskuryakov.
261
262         * Scripts/webkitpy/xcode/simulator.py:
263         (Simulator.wait_until_device_is_booted): If checking Simulator boot state fails, verify if
264         the "simulator device" is still in booted state. Since we ensured that simulator device 
265         was in booted state earlier in this method, this indicates that simulator device has shut down
266         unexpectedly.
267
268 2016-06-14  David Kilzer  <ddkilzer@apple.com>
269
270         Follow-up fix #2: REGRESSION (r202020): El Capitan CMake Debug build broken
271         <https://webkit.org/b/158743>
272
273         Unreviewed build fix.
274
275         * DumpRenderTree/PlatformMac.cmake: Fix silly typo.
276
277 2016-06-14  Aakash Jain  <aakash_jain@apple.com>
278
279         Too much log data generated during layout-tests on iOS Simulator
280         https://bugs.webkit.org/show_bug.cgi?id=158751
281
282         Reviewed by Alexey Proskuryakov.
283
284         * Scripts/webkitpy/port/ios.py:
285         (IOSSimulatorPort._quit_ios_simulator): Do not use -v flag.
286         (IOSSimulatorPort.clean_up_test_run): Ditto.
287         (IOSSimulatorPort._createSimulatorApp): Ditto.
288
289 2016-06-14  David Kilzer  <ddkilzer@apple.com>
290
291         Follow-up fix: REGRESSION (r202020): El Capitan CMake Debug build broken
292         <https://webkit.org/b/158743>
293
294         Unreviewed build fix.
295
296         The fix in r202056 clobbered DumpRenderTree_SOURCES and
297         TestNetscapePlugin_SOURCES from DumpRenderTree/CMakeLists.txt,
298         so the build failure is now that we're not building the common
299         sources.
300
301         Fix that by saving the common sources (which are all C++ source
302         files) into *_Cpp_SOURCES lists first, then setting the compiler
303         flags, then creating the final *_SOURCES lists.
304
305         * DumpRenderTree/PlatformMac.cmake: Add
306         ${TestNetscapePlugin_Cpp_SOURCES} to list that needs
307         "-std=c++14" compiler switch.
308         (TestNetscapePlugin_Cpp_SOURCES): Add new list for C++ source
309         files for TestNetscapePlugin.  Seeded with
310         ${TestNetscapePlugin_SOURCES} from CMakeLists.txt.
311         (TestNetscapePlugin_SOURCES): Add
312         ${TestNetscapePlugin_Cpp_SOURCES} to the list of files.
313         (DumpRenderTree_Cpp_SOURCES): Seed list for C++ source files
314         with ${DumpRenderTree_SOURCES} from CMakeLists.txt.
315         (DumpRenderTree_SOURCES): Reformat and sort source lists.
316
317 2016-06-14  David Kilzer  <ddkilzer@apple.com>
318
319         REGRESSION (r202020): El Capitan CMake Debug build broken
320         <https://webkit.org/b/158743>
321
322         Reviewed by Alex Christensen.
323
324         The bug was that pure C++ source files (and Objective-C source
325         files) were being compiled as Objective-C++ source files.  This
326         is obviously incorrect, so the fix was to split out the list of
327         source files by language, then define compiler switches based on
328         each file type.
329
330         * DumpRenderTree/PlatformMac.cmake: Replace add_definitions()
331         with separate foreach loops that set compiler flags based on
332         each source file's type.
333         (TestNetscapePlugin_ObjCpp_SOURCES): Rename from
334         TestNetscapePlugin_SOURCES.
335         (TestNetscapePlugin_SOURCES): Create based on
336         ${TestNetscapePlugin_ObjCpp_SOURCES}.
337         (DumpRenderTree_ObjC_SOURCES): Split from DumpRenderTree_SOURCES.
338         (DumpRenderTree_Cpp_SOURCES): Ditto.
339         (DumpRenderTree_ObjCpp_SOURCES): Ditto.
340         (DumpRenderTree_SOURCES): Create from above three lists.
341
342 2016-06-14  Lucas Forschler  <lforschler@apple.com>
343
344         <rdar://problem/26685782>
345         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
346
347         Rubber-stamped by Jessie Berlin.
348
349         * Scripts/copy-webkitlibraries-to-product-directory:
350
351 2016-06-14  Youenn Fablet  <youenn.fablet@crf.canon.fr>
352
353         Activate CMake export compile commands option
354         https://bugs.webkit.org/show_bug.cgi?id=158734
355
356         Reviewed by Alex Christensen.
357
358         * Scripts/webkitdirs.pm:
359         (generateBuildSystemFromCMakeProject): Activating this option for all CMake builds.
360         This allows using ymcd for WebKit hacking.
361
362 2016-06-14  David Kilzer  <ddkilzer@apple.com>
363
364         Modernize DumpRenderTreeMac.h
365         <https://webkit.org/b/158721>
366
367         Reviewed by Andy Estes.
368
369         * DumpRenderTree/mac/DumpRenderTreeMac.h:
370         - Update copyright.
371         - Update license.
372         - Use #pragma once.
373         - Use OBJC_CLASS macro.
374
375 2016-06-13  David Kilzer  <ddkilzer@apple.com>
376
377         False-positive over-release of WebView in destroyWebViewAndOffscreenWindow() in DumpRenderTree.mm
378         <https://webkit.org/b/158716>
379
380         Reviewed by Andy Estes.
381
382         * DumpRenderTree/mac/DumpRenderTree.mm:
383         (destroyWebViewAndOffscreenWindow): Change this function to take
384         a WebView, and assert that it's the same as [mainFrame webView].
385         (dumpRenderTree): Pass 'webView' into
386         destroyWebViewAndOffscreenWindow().
387         * DumpRenderTree/mac/DumpRenderTreeMac.h:
388         (createWebViewAndOffscreenWindow): Add NS_RETURNS_RETAINED since
389         this function returns a +1 WebView.  Declare this method only for
390         Objective-C[++] source.
391
392 2016-06-13  Sam Weinig  <sam@webkit.org>
393
394         Make HashMap and HashSet work with Refs
395         https://bugs.webkit.org/show_bug.cgi?id=158638
396
397         Reviewed by Darin Adler.
398
399         * TestWebKitAPI/Tests/WTF/HashMap.cpp:
400         (TestWebKitAPI::TEST):
401         * TestWebKitAPI/Tests/WTF/HashSet.cpp:
402         (TestWebKitAPI::TEST):
403         Add tests for using Refs in HashMaps (both as key and value) and HashSets.
404
405 2016-06-13  Mark Lam  <mark.lam@apple.com>
406
407         Add a mechanism for collecting LLINT stats.
408         https://bugs.webkit.org/show_bug.cgi?id=158668
409
410         Reviewed by Filip Pizlo.
411
412         * DumpRenderTree/mac/DumpRenderTree.mm:
413         (DumpRenderTreeMain):
414
415 2016-06-13  Romain Bellessort  <romain.bellessort@crf.canon.fr>
416
417         [GTK] Enabling Shadow DOM by default
418         https://bugs.webkit.org/show_bug.cgi?id=158686
419
420         Reviewed by Carlos Garcia Campos.
421
422         Added support for enabling Shadow DOM by default for GTK.
423         Changed GTK test expectations for fast/shadow-dom tests (most tests
424         pass).
425
426         * Scripts/webkitperl/FeatureList.pm:
427
428 2016-06-12  Aakash Jain  <aakash_jain@apple.com>
429
430         run-safari/run-webkit-app fail to quit iOS simulator after Xcode installation
431         https://bugs.webkit.org/show_bug.cgi?id=158651
432         rdar://problem/26499824
433
434         Reviewed by Daniel Bates.
435
436         This change is to make our tools more robust. Sometimes run-safari/run-webkit-app fails 
437         to start the tests as one of the first thing these scripts do is to relaunch iOS Simulators,
438         and in process call quitIOSSimulator. In case the Simulator is not registered in LaunchServices
439         for some reason, quitIOSSimulator fails and the script stops. This change will make the scripts
440         still continue when they fail to quit iOS Simuator, and modify the way Simulator is opened, 
441         so that Simulator is implicitly registered with LaunchServices while opening it.
442
443         * Scripts/webkitdirs.pm:
444         (relaunchIOSSimulator):
445         Launch iOS Simulator using complete path. Partially reverting http://trac.webkit.org/changeset/184202.
446         (quitIOSSimulator):
447         Do not die if quitting ios Simulator fails, so that relaunchIOSSimulator can still 
448         attempt to launch the simulator.
449         (waitUntilIOSSimulatorDeviceIsInState):
450         Added a FIXME.
451
452 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
453
454         Addressing post-review comments after r201978.
455         https://bugs.webkit.org/show_bug.cgi?id=158649
456         <rdar://problem/13258122>
457
458         Unreviewed.
459
460         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
461         (TestWebKitAPI::TEST):
462
463 2016-06-11  Alexey Proskuryakov  <ap@apple.com>
464
465         Unreviewed leak fix after r201863.
466
467         * DumpRenderTree/mac/DumpRenderTree.mm:
468         (dumpFramesAsText):
469
470 2016-06-11  Myles C. Maxfield  <mmaxfield@apple.com>
471
472         [Cocoa] Map commonly used Chinese Windows font names to names present on Cocoa operating systems
473         https://bugs.webkit.org/show_bug.cgi?id=158649
474         <rdar://problem/13258122>
475
476         Reviewed by Darin Adler.
477
478         * TestWebKitAPI/Tests/WTF/WTFString.h:
479         (TestWebKitAPI::TEST):
480
481 2016-06-10  Alex Christensen  <achristensen@webkit.org>
482
483         Fix CMake build.
484
485         * TestWebKitAPI/PlatformMac.cmake:
486
487 2016-06-10  Filip Pizlo  <fpizlo@apple.com>
488
489         Rename JSAir to Air.js
490
491         Rubber stamped by Mark Lam.
492
493         * Scripts/run-javascriptcore-tests:
494
495 2016-06-10  Filip Pizlo  <fpizlo@apple.com>
496
497         JSC Stress Test failing: jsair-tests.yaml/test.js.ftl-eager-no-cjit
498         https://bugs.webkit.org/show_bug.cgi?id=158571
499
500         Reviewed by Keith Miller.
501         
502         Unskip the JSAir test.
503
504         * Scripts/run-javascriptcore-tests:
505         (runJSCStressTests):
506
507 2016-06-10  Sam Weinig  <sam@webkit.org>
508
509         Re-disable the UserMedia tests which are timing out.
510
511         They used to be accidentally disabled, due to not including
512         the FeatureDefines correctly, but not we explicitly disable it.
513
514         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
515         (TestWebKitAPI::TEST):
516
517 2016-06-10  Alex Christensen  <achristensen@webkit.org>
518
519         Introduce WTF::UniqueRef
520         https://bugs.webkit.org/show_bug.cgi?id=158596
521
522         Reviewed by Brady Eidson.
523
524         * TestWebKitAPI/CMakeLists.txt:
525         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
526         * TestWebKitAPI/Tests/WTF/UniqueRef.cpp: Added.
527         (TestWebKitAPI::B::B):
528         (TestWebKitAPI::C::C):
529         (TestWebKitAPI::function):
530         (TestWebKitAPI::TEST):
531
532 2016-06-10  Sam Weinig  <sam@webkit.org>
533
534         Refactor TestWebKitAPI to allow just testing WTF
535         https://bugs.webkit.org/show_bug.cgi?id=158625
536
537         Reviewed by Tim Horton.
538
539         Extract all the WTF tests into a new target to allow a faster build / test / fix
540         cycle when working on WTF bugs and features.
541         
542         By calling `run-api-tests --wtf-only`, you don't need to have a build of JavaScriptCore/WebCore/etc
543         to test WTF only changes.
544
545         * Scripts/build-api-tests:
546         * Scripts/run-api-tests:
547         (buildTestTool):
548         (testToolPaths):
549         Add new options to build-api-tests and run-api-tests to only build/run the WTF test runner.
550
551         * TestWebKitAPI/CMakeLists.txt:
552         * TestWebKitAPI/Configurations/TestWTF.xcconfig: Added.
553         * TestWebKitAPI/Configurations/TestWTFLibrary.xcconfig: Added.
554         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
555         Add two new targets, TestWTFLibrary which contains all the WTF tests, and TestWTF,
556         the test runner that runs the WTF tests.
557     
558         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
559         Use Utilities.h rather than PlatformUtilities.h.
560
561         * TestWebKitAPI/Utilities.h: Added.
562         * TestWebKitAPI/PlatformUtilities.h:
563         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm:
564         * TestWebKitAPI/cocoa/UtilitiesCocoa.mm: Added.
565         Move the sleep and run functions into a new Utilities.h/cpp file. This file contains utilities
566         that don't depend on anything in the WebKit project. 
567
568 2016-06-10  Brady Eidson  <beidson@apple.com>
569
570         REGRESSION(r201928?) API test WTF.StringOperators failing
571         https://bugs.webkit.org/show_bug.cgi?id=158623
572
573         Unreviewed, but buddy coded with Alex Christensen.
574
575         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
576         (TestWebKitAPI::LifetimeLogger::fullName): Only one file in all of TestWebKitAPI is allowed
577           to use string concatenation, otherwise the linker will mess up on the symbol related to
578           this bizarre WTF_STRINGTYPEADAPTER_COPIED_WTF_STRING macro expansion.
579
580 2016-06-10  Brady Eidson  <beidson@apple.com>
581
582         WTF_CrossThreadTask.Basic fails in all non mac ports.
583         https://bugs.webkit.org/show_bug.cgi?id=158612
584
585         Reviewed by Alex Christensen.
586
587         The test is very sensitive to argument evaluation order which is explicitly undefined in C++.
588         
589         Instead, we should just count the appropriate events to forget their order.
590         
591         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
592         (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
593         (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
594         (TestWebKitAPI::LifetimeLogger::isolatedCopy):
595         (TestWebKitAPI::LifetimeLogger::fullName):
596         (TestWebKitAPI::testFunction):
597         (TestWebKitAPI::TEST):
598         (TestWebKitAPI::LifetimeLogger::log): Deleted.
599         (TestWebKitAPI::LifetimeLogger::takeLogStr): Deleted.
600
601 2016-06-09  Alex Christensen  <achristensen@webkit.org>
602
603         Clean up Tools *.vcxproj after switching to CMake.
604
605         * DumpRenderTree/DumpRenderTree.sln: Removed.
606         * DumpRenderTree/DumpRenderTree.vcxproj: Removed.
607         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Removed.
608         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Removed.
609         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Removed.
610         * DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Removed.
611         * DumpRenderTree/PlatformWin.cmake:
612         * DumpRenderTree/win/TestNetscapePlugin.def: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def.
613         * DumpRenderTree/win/TestNetscapePlugin.rc: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc.
614         * DumpRenderTree/win/resource.h: Copied from DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h.
615         * MiniBrowser/MiniBrowser.vcxproj: Removed.
616         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico: Removed.
617         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc: Removed.
618         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc: Removed.
619         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h: Removed.
620         * MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h: Removed.
621         * MiniBrowser/MiniBrowser.vcxproj/small.ico: Removed.
622         * MiniBrowser/win/CMakeLists.txt:
623         * MiniBrowser/win/MiniBrowser.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.ico.
624         * MiniBrowser/win/MiniBrowser.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowser.rc.
625         * MiniBrowser/win/MiniBrowserLib.rc: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLib.rc.
626         * MiniBrowser/win/MiniBrowserLibResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserLibResource.h.
627         * MiniBrowser/win/MiniBrowserResource.h: Copied from MiniBrowser/MiniBrowser.vcxproj/MiniBrowserResource.h.
628         * MiniBrowser/win/small.ico: Copied from MiniBrowser/MiniBrowser.vcxproj/small.ico.
629         * WebKitTestRunner/WebKitTestRunner.sln: Removed.
630         * win/DLLLauncher/DLLLauncherWinCairo.props: Removed.
631
632 2016-06-09  Zalan Bujtas  <zalan@apple.com>
633
634         Add testing support for 3x device scale factor.
635         https://bugs.webkit.org/show_bug.cgi?id=158597
636
637         Reviewed by Simon Fraser.
638
639         Set 3x device scale factor on the test canvas when the test url is prefixed with hidpi-3x-. 
640
641         * DumpRenderTree/mac/DumpRenderTree.mm:
642         (changeWindowScaleIfNeeded):
643         * WebKitTestRunner/TestController.cpp:
644         (WTR::TestController::updateWindowScaleForTest):
645         * WebKitTestRunner/TestOptions.cpp:
646         (WTR::deviceScaleFactorForTest):
647         (WTR::TestOptions::TestOptions):
648         (WTR::isHiDPITestPath): Deleted.
649         * WebKitTestRunner/TestOptions.h:
650
651 2016-06-09  Michael Catanzaro  <mcatanzaro@igalia.com>
652
653         Add comments to clarify feature enablement
654         https://bugs.webkit.org/show_bug.cgi?id=158567
655
656         Reviewed by Alex Christensen.
657
658         * Scripts/webkitperl/FeatureList.pm:
659
660 2016-06-09  Filip Pizlo  <fpizlo@apple.com>
661
662         Unreviewed, skip jsair tests while we figure out the debug timeouts.
663
664         * Scripts/run-javascriptcore-tests:
665         (runJSCStressTests):
666
667 2016-06-09  Commit Queue  <commit-queue@webkit.org>
668
669         Unreviewed, rolling out r201815.
670         https://bugs.webkit.org/show_bug.cgi?id=158570
671
672         This broke the cmake build. (Requested by lforschler on
673         #webkit).
674
675         Reverted changeset:
676
677         "Teach cmake about libWebKitSystemInterfaceOSX10.12"
678         http://trac.webkit.org/changeset/201815
679
680 2016-06-09  Brady Eidson  <beidson@apple.com>
681
682         Greatly simplify CrossThreadTask.h.
683         https://bugs.webkit.org/show_bug.cgi?id=158542
684
685         Reviewed by Darin Adler.
686
687         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
688         (TestWebKitAPI::TEST):
689
690 2016-06-09  Chris Dumez  <cdumez@apple.com>
691
692         Unreviewed, rolling out r201836, r201845, and r201848.
693
694         Looks like a 1-2% PLT regression on iOS
695
696         Reverted changesets:
697
698         "[JSC] Change some parameters based on a random search"
699         https://bugs.webkit.org/show_bug.cgi?id=158514
700         http://trac.webkit.org/changeset/201836
701
702         "Tempory fix for the debug bots"
703         http://trac.webkit.org/changeset/201845
704
705         "Change thresholdForOptimizeSoon to match
706         thresholdForOptimizeAfterWarmUp"
707         http://trac.webkit.org/changeset/201848
708
709 2016-06-09  Michael Saboff  <msaboff@apple.com>
710
711         WebKitTestRunner and DumpRenderTree do not handle dangling surrogate characters
712         https://bugs.webkit.org/show_bug.cgi?id=154863
713
714         Reviewed by Alexey Proskuryakov.
715
716         Added a non-strict verions of WKStringGetUTF8CString() that will handle dangling
717         surrogates.  Changed the extraction of inner text from frames in DumpRenderTree
718         to use the new WKStringGetUTF8CStringNonStrict() function instead of NSString
719         conversion since NSString doesn't have a way to handle dangling surrogates.
720         The code added in DumpRenderTree matches what was changed in WebKitTestRunner.
721
722         * DumpRenderTree/mac/DumpRenderTree.mm:
723         (dumpFramesAsText):
724         * WebKitTestRunner/StringFunctions.h:
725         (WTR::toWTFString):
726
727 2016-06-08  Hunseop Jeong  <hs85.jeong@samsung.com>
728
729         Try to fix the EFL build. 
730
731         Unreviewed. 
732
733         * TestWebKitAPI/CMakeLists.txt:
734
735 2016-06-08  Alex Christensen  <achristensen@webkit.org>
736
737        Fix WinCairo build
738
739         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
740
741 2016-06-08  Alex Christensen  <achristensen@webkit.org>
742
743         Fix WinCairo build
744
745         * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
746         (BitmapContext::createByAdoptingBitmapAndContext):
747         (BitmapContext::~BitmapContext):
748
749 2016-06-08  Benjamin Poulain  <benjamin@webkit.org>
750
751         [JSC] Change some parameters based on a random search
752         https://bugs.webkit.org/show_bug.cgi?id=158514
753
754         Reviewed by Filip Pizlo.
755
756         * Scripts/run-jsc-stress-tests:
757
758 2016-06-08  Aakash Jain  <aakash_jain@apple.com>
759
760         tests fail if display sleeps while run-webkit-tests is running
761         https://bugs.webkit.org/show_bug.cgi?id=153919
762
763         Reviewed by Alexey Proskuryakov.
764
765         * DumpRenderTree/mac/LayoutTestHelper.m:
766         (releaseSleepAssertions): Release both Display sleep and System sleep assertions.
767         (addSleepAssertions): Add sleep assertion for both Display sleep and System sleep.
768
769 2016-06-08  Lucas Forschler  <lforschler@apple.com>
770
771         Reverted changeset 201814.
772
773         * Scripts/copy-webkitlibraries-to-product-directory:
774
775 2016-06-08  Per Arne Vollan  <pvollan@apple.com>
776
777         [Win] Shadow DOM tests are failing.
778         https://bugs.webkit.org/show_bug.cgi?id=158524
779
780         Reviewed by Brent Fulgham.
781
782         Enable Shadow DOM when running tests.
783
784         * DumpRenderTree/win/DumpRenderTree.cpp:
785         (resetWebPreferencesToConsistentValues):
786
787 2016-06-08  Lucas Forschler  <lforschler@apple.com>
788
789         Teach cmake about libWebKitSystemInterfaceOSX10.12
790         This patch also removes duplicated logic inside DumpRenderTree/PlatformMac.cmake
791
792         Rubber-stamped by Alex Christensen.
793  
794         * DumpRenderTree/PlatformMac.cmake:
795         * WebKitTestRunner/PlatformMac.cmake:
796
797 2016-06-07  Lucas Forschler  <lforschler@apple.com>
798
799         <rdar://problem/26685782>
800         Teach the copy-webkitlibraries-to-product-directory script about WebKitSystemInterfaceOSX10.12
801
802         Rubber-stamped by Jessie Berlin.
803
804         * Scripts/copy-webkitlibraries-to-product-directory:
805
806 2016-06-08  Aakash Jain  <aakash_jain@apple.com>
807
808         Don't try to cleanup non-existing ios Simulators
809         https://bugs.webkit.org/show_bug.cgi?id=158510
810
811         Reviewed by Alexey Proskuryakov.
812
813         * Scripts/webkitpy/port/ios.py:
814         (IOSSimulatorPort.clean_up_test_run): 
815         Check if simulator exists before trying to clean it up.
816
817 2016-06-08  Brady Eidson  <beidson@apple.com>
818
819         Try to fix the Windows build.
820
821         Unreviewed.
822
823         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
824         (TestWebKitAPI::LifetimeLogger::log):
825         (TestWebKitAPI::LifetimeLogger::takeLogStr):
826         (TestWebKitAPI::testFunction):
827         (TestWebKitAPI::TEST):
828         (TestWebKitAPI::log): Deleted. (VS was seeing it as a dupe symbol)
829         (TestWebKitAPI::takeLogStr): Deleted. (VS was seeing it as a dupe symbol)
830
831 2016-06-08  Brady Eidson  <beidson@apple.com>
832
833         Make CrossThreadCopier more efficient (fewer copies!).
834         https://bugs.webkit.org/show_bug.cgi?id=158456
835
836         Reviewed by Alex Christensen.
837
838         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:
839         (TestWebKitAPI::TEST):
840
841 2016-06-07  Filip Pizlo  <fpizlo@apple.com>
842
843         Add result validation to JSAir
844         https://bugs.webkit.org/show_bug.cgi?id=158493
845
846         Reviewed by Saam Barati.
847         
848         Run JSAir.
849
850         * Scripts/run-javascriptcore-tests:
851         (runJSCStressTests):
852
853 2016-06-08  Brady Eidson  <beidson@apple.com>
854
855         Add an API test that confirms object constructor/destructor calls during creation of a CrossThreadTask.
856         https://bugs.webkit.org/show_bug.cgi?id=158528
857
858         Reviewed by Alex Christensen.
859
860         * TestWebKitAPI/CMakeLists.txt:
861         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
862         * TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp: Added.
863         (TestWebKitAPI::log):
864         (TestWebKitAPI::takeLogStr):
865         (TestWebKitAPI::LifetimeLogger::LifetimeLogger):
866         (TestWebKitAPI::LifetimeLogger::~LifetimeLogger):
867         (TestWebKitAPI::LifetimeLogger::isolatedCopy):
868         (TestWebKitAPI::testFunction):
869         (TestWebKitAPI::TEST):
870
871 2016-06-08  Konstantin Tokarev  <annulen@yandex.ru>
872
873         TestWebKitAPI: Removed redunandant check PLATFORM(GTK) && !defined(BUILDING_WEBKIT2__)
874         https://bugs.webkit.org/show_bug.cgi?id=158521
875
876         Reviewed by Carlos Garcia Campos.
877
878         * TestWebKitAPI/config.h:
879
880 2016-06-07  Carlos Garcia Campos  <cgarcia@igalia.com>
881
882         [GTK] Use a longer timeout for glib unit tests
883         https://bugs.webkit.org/show_bug.cgi?id=158476
884
885         Reviewed by Darin Adler.
886
887         The timeout is supposed to be per test case, but in the case of GLib tests it affects all the tests cases of the
888         same test program. Some test programs like TestLoaderClient, that have a lot of test cases, often time out in
889         the bots because the timeout is not enough to run all the tests cases. So, we should use a longer timeout for
890         GLib tests.
891
892         * Scripts/run-gtk-tests:
893         (TestRunner._run_test_glib):
894
895 2016-06-07  Keith Rollin  <krollin@apple.com>
896
897         Remove all uses of PassRefPtr in WTF
898         https://bugs.webkit.org/show_bug.cgi?id=157596
899         <rdar://problem/26234391>
900
901         Reviewed by Chris Dumez.
902
903         Update calls to interfaces that no longer take or return PassRefPtrs.
904
905         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
906         (TestWebKitAPI::stringFromUTF8):
907         (TestWebKitAPI::TEST):
908
909 2016-06-07  Per Arne Vollan  <pvollan@apple.com>
910
911         [Win] Imported markup insertion test is failing.
912         https://bugs.webkit.org/show_bug.cgi?id=158477
913
914         Reviewed by Darin Adler.
915
916         Make sure the empty synchronous request is loaded after each test.
917
918         * DumpRenderTree/win/DumpRenderTree.cpp:
919         (runTest):
920
921 2016-06-06  Carlos Alberto Lopez Perez  <clopez@igalia.com>
922
923         REGRESSION(r201449) [GTK] ARMv7 build fails with libicudata.so.55: cannot open shared object file on gtkdoc-scangobj step.
924         https://bugs.webkit.org/show_bug.cgi?id=158417
925
926         Reviewed by Michael Catanzaro.
927
928         The toolchain on armhf (ARMv7) seems unable to properly handle
929         a shared library that doesn't link with anything.
930
931         And libicudata is built by default in this way because it only
932         contains static data.
933
934         That makes icu unusable on armhf because the linker will be
935         unable to resolve the libicudata dependencies.
936
937         Most (if not all) distributions workaround this by linking
938         libicudata with libc6, which is already a needed dependency for
939         any of the other icu shared libraries.
940
941         So import here the Debian patch fixing this issue. For further
942         details check https://bugs.debian.org/653457
943
944         * gtk/jhbuild.modules:
945         * gtk/patches/icudata-stdlibs.patch: Added.
946
947 2016-06-06  Per Arne Vollan  <pvollan@apple.com>
948
949         REGRESSION (r104174): 500+ tests failing on Windows
950         https://bugs.webkit.org/show_bug.cgi?id=75965
951
952         Reviewed by Michael Catanzaro.
953
954         Reset WebView scale factors before running next test.
955
956         * DumpRenderTree/win/DumpRenderTree.cpp:
957         (resetWebViewToConsistentStateBeforeTesting):
958
959 2016-06-04  Alexey Proskuryakov  <ap@apple.com>
960
961         REGRESSION (r201263): Some tests have become flaky timeouts.
962         https://bugs.webkit.org/show_bug.cgi?id=157990
963
964         Reviewed by Darin Adler.
965
966         * WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::invoke):
967         It is somewhat legitimate for WebContent to not respond to messages after the test
968         is done; it can be e.g. re-doing a costly repaint. So, we should restart is silently,
969         without making the current test fail.
970
971 2016-06-03  Youenn Fablet  <youenn.fablet@crf.canon.fr>
972
973         [GTK] Update YouCompleteMe script to make all include paths absolute
974         https://bugs.webkit.org/show_bug.cgi?id=158301
975
976         Reviewed by Michael Catanzaro.
977
978         Before this patch, some include paths were not made absolute.
979         This could make YouCompleteMe plugin to fail extracting information or validating cpp files.
980
981         * gtk/ycm_extra_conf.py:
982
983 2016-06-03  Nael Ouedraogo  <nael.ouedraogo@crf.canon.fr>
984
985         Unreviewed: add myself to the committers list.
986
987         * Scripts/webkitpy/common/config/contributors.json:
988
989 2016-06-02  Per Arne Vollan  <pvollan@apple.com>
990
991         [Win] Fetch API tests are failing.
992         https://bugs.webkit.org/show_bug.cgi?id=158296
993
994         Reviewed by Alex Christensen.
995
996         Enable Fetch API when running tests.
997
998         * DumpRenderTree/win/DumpRenderTree.cpp:
999         (resetWebPreferencesToConsistentValues):
1000
1001 2016-06-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1002
1003         Really display failing JSC stress tests in buildbot dashboard
1004         https://bugs.webkit.org/show_bug.cgi?id=158324
1005
1006         Reviewed by Alexey Proskuryakov.
1007
1008         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1009         (BuildbotCombinedQueueView.prototype.update): Correctly check for string membership in array.
1010         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1011         (BuildbotIteration.prototype._parseData): Correctly check for string membership in array.
1012         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1013         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Correctly check for string
1014         membership in array.
1015         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Ensure that the correct URL is
1016         generated after the first time.
1017         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1018         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Correctly check for string membership in array.
1019
1020 2016-06-02  Michael Saboff  <msaboff@apple.com>
1021
1022         [iOS]: Some JSC stress tests fail running out of executable memory when the LLInt is disabled
1023         https://bugs.webkit.org/show_bug.cgi?id=158317
1024
1025         Reviewed by Saam Barati.
1026
1027         Added defaultNoNoLLIntRun variant to run the default tests with the exception of the no-llint
1028         variant.
1029
1030         * Scripts/run-jsc-stress-tests:
1031
1032 2016-06-02  Aakash Jain  <aakash_jain@apple.com>
1033
1034         LayoutTests time out intermittently due to alert about reopening Simulator after it unexpectedly quit
1035         https://bugs.webkit.org/show_bug.cgi?id=158305
1036
1037         Reviewed by Alexey Proskuryakov.
1038
1039         * Scripts/webkitpy/port/ios.py:
1040         (IOSSimulatorPort.clean_up_test_run): Delete simulator's savedState directories during cleanup.
1041
1042 2016-06-01  Brian Burg  <bburg@apple.com>
1043
1044         REGRESSION(r191907): Can't enter combining diacritic marks in Web Inspector fields
1045         https://bugs.webkit.org/show_bug.cgi?id=158227
1046         <rdar://problem/26232464>
1047
1048         Reviewed by Alexey Proskuryakov.
1049
1050         Add a regression test that runs on Mac only.
1051
1052         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1053         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewTextInput.mm: Added.
1054         (-[DummyNavigationDelegate webView:didFinishNavigation:]):
1055         (TEST):
1056         * TestWebKitAPI/Tests/WebKit2Cocoa/editable-body.html: Added.
1057
1058 2016-06-01  Chris Fleizach  <cfleizach@apple.com>
1059
1060         AX: iOS: VoiceOver can't access attachments in mail messages
1061         https://bugs.webkit.org/show_bug.cgi?id=158198
1062
1063         Reviewed by Joanmarie Diggs.
1064
1065         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
1066         (AccessibilityUIElement::stringForRange):
1067         (AccessibilityUIElement::attributedStringForRange):
1068         (AccessibilityUIElement::attributedStringRangeIsMisspelled):
1069         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
1070         (WTR::AccessibilityUIElement::attributedStringForRange):
1071         (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
1072
1073 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1074
1075         Unreviewed. Mark GTK+ test /webkit2/WebKitWebInspectorServer/test-open-debugging-session as slow.
1076
1077         It's timing out in the bots, but it seems to pass when running run-gtk-tests with no timeout. For GLib tests the
1078         timeout is applied per tester program not per test case, so we need to mark the whole test
1079         WebKit2Gtk/TestInspectorServer as slow.
1080
1081         * Scripts/run-gtk-tests:
1082         (TestRunner):
1083         (TestRunner._run_test_glib):
1084
1085 2016-06-01  Carlos Garcia Campos  <cgarcia@igalia.com>
1086
1087         Unreviewed. Skip media permission request GTK+ unit tests.
1088
1089         They are timing out in the bots.
1090
1091         * Scripts/run-gtk-tests:
1092         (TestRunner):
1093
1094 2016-05-31  Jer Noble  <jer.noble@apple.com>
1095
1096         Yet another unreviewed build fix; move the closing brace of the namespace declaration inside
1097         the #if check.
1098
1099         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1100
1101 2016-05-31  Jer Noble  <jer.noble@apple.com>
1102
1103         Further unreviewed build fix; only run FullscreenTopContentInset test on Mac.
1104
1105         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1106
1107 2016-05-31  Jer Noble  <jer.noble@apple.com>
1108
1109         Unreviewed build fix; only run FullscreetTopContentInset test on platforms
1110         where WK_API_ENABLED is set.
1111
1112         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
1113
1114 2016-05-31  Jer Noble  <jer.noble@apple.com>
1115
1116         REGRESSION (r201405): trailers.apple.com HUD is missing in fullscreen
1117         https://bugs.webkit.org/show_bug.cgi?id=158156
1118         <rdar://problem/26519589>
1119
1120         Reviewed by Darin Adler.
1121
1122         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1123         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.html: Added.
1124         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm: Added.
1125         (-[FullscreenChangeMessageHandler userContentController:didReceiveScriptMessage:]):
1126         (TestWebKitAPI::TEST):
1127
1128 2016-05-31  Jon Lee  <jonlee@apple.com>
1129
1130         Unreviewed: add myself to the reviewers list.
1131
1132         * Scripts/webkitpy/common/config/contributors.json:
1133
1134 2016-05-31  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1135
1136         [GTK] Provide alternative mirror for the ICU tarball.
1137         https://bugs.webkit.org/show_bug.cgi?id=154530
1138
1139         Unreviewed.
1140
1141         * gtk/jhbuild.modules: After r201449 the GTK+ ARM buildbot is having
1142         a hard time trying to download the ICU tarball from download.icu-project.org
1143         (which redirects to sourceforge and gives problems with something related to
1144         SSL). Provide this alternative mirror to make things working back.
1145
1146 2016-05-31  Carlos Garcia Campos  <cgarcia@igalia.com>
1147
1148         [GTK] Test /webkit2/WebKitWebView/geolocation-permission-requests is failing since r201423
1149         https://bugs.webkit.org/show_bug.cgi?id=158200
1150
1151         Reviewed by Philippe Normand.
1152
1153         This is because geolocation is no longer allowed for non secure sites, like HTTP. In that case
1154         POSITION_UNAVAILABLE is returned without asking the API layer.
1155
1156         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
1157         (testWebViewGeolocationPermissionRequests): Keep the HTTP case to check that it indeed returns
1158         POSITION_UNAVAILABLE and use HTTPS URLs to check permission requests are allowed or denied. Also stop using the
1159         document title, and use user script messages that are more reliable instead.
1160
1161 2016-05-28  Aakash Jain  <aakash_jain@apple.com>
1162
1163         tests fail if display sleeps while run-webkit-tests is running
1164         https://bugs.webkit.org/show_bug.cgi?id=153919
1165
1166         Reviewed by Darin Adler.
1167
1168         * DumpRenderTree/mac/LayoutTestHelper.m:
1169         (addDisplaySleepAssertion): Use PreventUserIdleSystemSleep flag, same as set by caffeinate tool.
1170
1171 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1172
1173         Display failing JSC stress tests in buildbot dashboard
1174         https://bugs.webkit.org/show_bug.cgi?id=156595
1175
1176         Reviewed by Alexey Proskuryakov.
1177
1178         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1179         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
1180         (Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
1181         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1182         (BuildbotCombinedQueueView.prototype.update):
1183         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1184         (BuildbotIteration):
1185         (BuildbotIteration.prototype._parseData):
1186         (BuildbotIteration.prototype.loadLayoutTestResults):
1187         (BuildbotIteration.prototype.):
1188         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults):
1189         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1190         (BuildbotQueueView.prototype._createLoadingIndicator):
1191         (BuildbotQueueView.prototype.):
1192         (BuildbotQueueView.prototype._onPopoverCopy):
1193         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions):
1194         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions):
1195         (BuildbotQueueView.prototype._addIterationHeadingToPopover):
1196         (BuildbotQueueView.prototype._testStepFailureDescription):
1197         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount):
1198         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1199         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
1200         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1201         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus):
1202         (BuildbotTesterQueueView.prototype.update):
1203         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
1204         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions):
1205         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted.
1206         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted.
1207         (BuildbotTesterQueueView.prototype.): Deleted.
1208         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted.
1209         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html:
1210         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
1211         (MockBuildbot):
1212         (MockBuildbot.prototype.buildPageURLForIteration):
1213         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration):
1214         (MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration):
1215         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
1216         (MockBuildbotQueue):
1217         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js.
1218         (MockBuildbotTestResults):
1219         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures):
1220         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
1221         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
1222
1223 2016-05-27  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1224
1225         Display failing JSC stress tests in buildbot dashboard
1226         https://bugs.webkit.org/show_bug.cgi?id=156595
1227
1228         Reviewed by Alexey Proskuryakov.
1229
1230         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
1231         (Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Generate the URL for raw JSON output of
1232         JSC tests.
1233         (Buildbot.prototype.javaScriptCoreTestStdioURLForIteration): Generate the URL for human-readable stdio output
1234         of JSC tests.
1235         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1236         (BuildbotCombinedQueueView.prototype.update): Display JSC test results in popover.
1237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
1238         (BuildbotIteration): Add javaScriptCoreTestResults variable.
1239         (BuildbotIteration.prototype.): Check for javascriptcore tests step.
1240         (BuildbotIteration.prototype.loadLayoutTestResults): Add comma at closing brace.
1241         (BuildbotIteration.prototype.loadJavaScriptCoreTestResults): Fetch JSON from Buildbot server.
1242         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1243         (BuildbotQueueView.prototype._createLoadingIndicator): Reusable function.
1244         (BuildbotQueueView.prototype._onPopoverCopy): Reusable copy event handler to allow accurate copying of text
1245         from popovers.
1246         (BuildbotQueueView.prototype._popoverContentForJavaScriptCoreTestRegressions): Generates the popover bubble's
1247         inner HTML from the JSC failure data.
1248         (BuildbotQueueView.prototype._presentPopoverForJavaScriptCoreTestRegressions): Generate the popover bubble
1249         for JSC results and handle request failures.
1250         (BuildbotQueueView.prototype._testStepFailureDescription): Moved from subclass.
1251         (BuildbotQueueView.prototype._testStepFailureDescriptionWithCount): Moved from subclass.
1252         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:
1253         (BuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Parse JSON into a list of failing tests.
1254         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1255         (BuildbotTesterQueueView.prototype.appendBuilderQueueStatus): Instantiate PopoverTrackers for builds whose 
1256         only failures are JSC tests.
1257         (BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions): Use _onPopoverCopy.
1258         (BuildbotTesterQueueView.prototype._presentPopoverForLayoutTestRegressions): Use _createLoadingIndicator.
1259         (BuildbotTesterQueueView.prototype._testStepFailureDescription): Deleted. Moved to superclass.
1260         (BuildbotTesterQueueView.prototype._testStepFailureDescriptionWithCount): Deleted. Moved to superclass.
1261         (BuildbotTesterQueueView.prototype.content.oncopy): Deleted. Using superclass's reusable function as copy handler instead.
1262         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Add new script files.
1263         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js: Added.
1264         (MockBuildbot): Mocked version of Buildbot, only containing URL methods.
1265         (MockBuildbot.prototype.buildPageURLForIteration): Same as real Buildbot.js
1266         (MockBuildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Points to local file containing JSON for test.
1267         (MockBuildbot.prototype.javaScriptCoreTestStdioURLForIteration): Same as real Buildbot.js
1268         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js:
1269         (MockBuildbotQueue): Use a MockBuildbot() instead of a string.
1270         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotTestResults.js: Added.
1271         (MockBuildbotTestResults): Mocked version of BuildbotTestResults.
1272         (MockBuildbotTestResults.prototype.addJavaScriptCoreTestFailures): Sets the 'regressions' variable.
1273         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-jsc-results.json: Added.
1274         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Add four groups of tests.
1275
1276 2016-05-27  Chris Dumez  <cdumez@apple.com>
1277
1278         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables
1279         https://bugs.webkit.org/show_bug.cgi?id=158111
1280
1281         Reviewed by Darin Adler.
1282
1283         WorkQueue::dispatch() / RunLoop::dispatch() should not copy captured lambda variables.
1284         These are often used cross-thread and copying the captured lambda variables can be
1285         dangerous (e.g. we do not want to copy a String after calling isolatedCopy() upon
1286         capture).
1287
1288         * WebKitTestRunner/TestController.cpp:
1289         (WTR::TestController::decidePolicyForNavigationAction):
1290
1291 2016-05-27  Brady Eidson  <beidson@apple.com>
1292
1293         Modern IDB: After closing a Netflix video, trying to watch it again fails.
1294         <rdar://problem/25092473> and https://bugs.webkit.org/show_bug.cgi?id=158160
1295
1296         Reviewed by Alex Christensen.
1297
1298         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1299         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-1.html: Added.
1300         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup-2.html: Added.
1301         * TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm: Added.
1302
1303 2016-05-27  Joanmarie Diggs  <jdiggs@igalia.com>
1304
1305         AX: [ATK] accessibility/gtk/no-notification-for-unrendered-iframe-children.html began failing after r201416
1306         https://bugs.webkit.org/show_bug.cgi?id=158152
1307
1308         Reviewed by Chris Fleizach.
1309
1310         The failure is actually a bug fix because only one child is being added, but two
1311         notifications were being emitted. Now there is only one notification. To verify
1312         this was the case, we really should examine the child reportedly being added. That
1313         child is the ATK event's any_data, so pass along that child to the listener.
1314
1315         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1316
1317 2016-05-26  Alex Christensen  <achristensen@webkit.org>
1318
1319         Expose content extension failure error codes in SPI
1320         https://bugs.webkit.org/show_bug.cgi?id=158095
1321         rdar://problem/26475651
1322
1323         Reviewed by Anders Carlsson.
1324
1325         * TestWebKitAPI/Tests/WebKit2Cocoa/_WKUserContentExtensionStore.mm:
1326         (checkDomain):
1327         (TEST_F):
1328         Add tests that use the new enum.
1329
1330 2016-05-27  Carlos Garcia Campos  <cgarcia@igalia.com>
1331
1332         New intl-numberformat.js test fails on many Linux platforms
1333         https://bugs.webkit.org/show_bug.cgi?id=154530
1334
1335         Reviewed by Darin Adler.
1336
1337         The test is actually failing because of a bug in the icu version installed in the bots, using a newer version of
1338         icu makes the tests pass and explains why it worked for some people. So, let's add icu 55.1 to the internal
1339         jhbuild to ensure JSC tests pass in the bots no matter what the icu version installed is.
1340
1341         * gtk/jhbuild.modules:
1342
1343 2016-05-26  Yusuke Suzuki  <utatane.tea@gmail.com>
1344
1345         [JSC] Allow JSBench to use precise time
1346         https://bugs.webkit.org/show_bug.cgi?id=158050
1347
1348         Reviewed by Geoffrey Garen.
1349
1350         JSBench use `new Date().getTime()` without options and there is no way to use precise time.
1351         This patch modifies the JSBench code to inject the code taking the precise time.
1352         `currentTimeInMS` is given by the benchmerk harness and JSBench uses it.
1353         run-jsc-benchmark switches this function's implementation between `Date.now()` and
1354         testRunner's precise time one.
1355
1356         While this patch modifies the code of JSBench, the last release of JSBench is Jan 2013 and
1357         the contents are not changed for a long time. As described in the original paper[1], the
1358         tests can be generated by using JSBench's record & replay system, but in that case, we can
1359         adopt this modification by changing the tool side.
1360
1361         We also add currentTimeInMS implementation in harness.js and u?rem.js directly.
1362         u?rem.js implementation is required when it is executed in u?rem.html without harness.
1363         And harness.js implementation is required when it is executed in the JSBench's harness.
1364         In these implementation, we follow the JetStream's time measuring function: performance.now(),
1365         preciseTime(), or Date.now().
1366
1367         [1]: http://dl.acm.org/citation.cfm?id=2048119
1368
1369         * Scripts/run-jsc-benchmarks:
1370
1371 2016-05-26  Brent Fulgham  <bfulgham@apple.com>
1372
1373         Unreviewed test fix after r201427.
1374         https://bugs.webkit.org/show_bug.cgi?id=157423
1375         <rdar://problem/23751632>
1376
1377         A debug assertion was firing during some test runs due to the Geolocation permission
1378         being turned off during the test. The timer logic was originally written to assert
1379         if the timer fired when permissions were disabled. But this is no longer valid,
1380         because we expect the Geolocation system to be active and become deactivated if the
1381         browsing context violates one of the security criteria.
1382
1383         * DumpRenderTree/mac/UIDelegate.mm:
1384         (-[UIDelegate timerFired]): Remove invalid assertion.
1385
1386 2016-05-26  Filip Pizlo  <fpizlo@apple.com>
1387
1388         ScopedLambda should have a lifetime story that makes sense to the compiler
1389         https://bugs.webkit.org/show_bug.cgi?id=158118
1390
1391         Reviewed by Mark Lam.
1392         
1393         Added a test case. This test crashes before the fix and now it passes.
1394
1395         * TestWebKitAPI/CMakeLists.txt:
1396         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1397         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp: Added.
1398         (TestWebKitAPI::TEST):
1399
1400 2016-05-26  Myles C. Maxfield  <mmaxfield@apple.com>
1401
1402         Build fix
1403
1404         Rubber stamped by Lucas Forschler.
1405
1406         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
1407         * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
1408
1409 2016-05-25  Anders Carlsson  <andersca@apple.com>
1410
1411         Get rid of WTF/Functional.h
1412         https://bugs.webkit.org/show_bug.cgi?id=158081
1413
1414         Reviewed by Chris Dumez.
1415
1416         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1417         * TestWebKitAPI/Tests/WTF/Functional.cpp: Removed.
1418         (TestWebKitAPI::returnFortyTwo): Deleted.
1419         (TestWebKitAPI::TEST): Deleted.
1420         (TestWebKitAPI::multiplyByTwo): Deleted.
1421         (TestWebKitAPI::multiplyByOneAndAHalf): Deleted.
1422         (TestWebKitAPI::multiply): Deleted.
1423         (TestWebKitAPI::subtract): Deleted.
1424         (TestWebKitAPI::A::A): Deleted.
1425         (TestWebKitAPI::A::f): Deleted.
1426         (TestWebKitAPI::A::addF): Deleted.
1427         (TestWebKitAPI::B::B): Deleted.
1428         (TestWebKitAPI::B::~B): Deleted.
1429         (TestWebKitAPI::B::ref): Deleted.
1430         (TestWebKitAPI::B::deref): Deleted.
1431         (TestWebKitAPI::B::f): Deleted.
1432         (TestWebKitAPI::B::g): Deleted.
1433         (TestWebKitAPI::Number::create): Deleted.
1434         (TestWebKitAPI::Number::~Number): Deleted.
1435         (TestWebKitAPI::Number::value): Deleted.
1436         (TestWebKitAPI::Number::Number): Deleted.
1437         (TestWebKitAPI::multiplyNumberByTwo): Deleted.
1438
1439 2016-05-25  Daniel Bates  <dabates@apple.com> and Brent Fulgham  <bfulgham@apple.com>
1440
1441         [WebSockets] No infrastructure for testing secure web sockets (wss)
1442         https://bugs.webkit.org/show_bug.cgi?id=157884
1443         <rdar://problem/26477197>
1444
1445         Reviewed by Andy Estes.
1446
1447         Add support to webkitpy to start and stop a secure Web Socket server running on port 9323
1448         using the certificate, private-key from file LayoutTests/http/conf/webkit-httpd.pem. Also
1449         teaches run-webkit-httpd to start and stop the Web Socket servers.
1450
1451         Modify DumpRenderTree and WebKitTestRunner to understand a new testRunner method,
1452         'setAllowsAnySSLCertificate', which allows us to use the same self-signed test certificate
1453         we do for our HTTPS tests.
1454         
1455         * DumpRenderTree/TestRunner.cpp:
1456         (setAllowsAnySSLCertificateCallback):
1457         (TestRunner::setAllowsAnySSLCertificate):
1458         * DumpRenderTree/TestRunner.h:
1459         * DumpRenderTree/mac/DumpRenderTree.mm:
1460         (resetWebViewToConsistentStateBeforeTesting): Make sure we turn off the new flag between tests.
1461         * Scripts/run-webkit-httpd:
1462         (main): Start the websocket server at launch.
1463         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1464         (Manager.__init__): Remove dead code.
1465         * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
1466         (PyWebSocket.__init__): Cleanup code.
1467         (PyWebSocket): Pass '--tls-client-ca' to start command.
1468         (PyWebSocket._prepare_config): Cleanups.
1469         * Scripts/webkitpy/port/base.py:
1470         (Port.to.start_http_server):
1471         (Port.to):
1472         (Port.to._extract_certificate_from_pem): Added.
1473         (Port.to._extract_private_key_from_pem): Added.
1474         (Port.to.start_websocket_server): Start secure socket server.
1475         (Port.to.stop_websocket_server): Stop secure socket server.
1476         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Add new API.
1477         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1478         (WTR::InjectedBundle::setAllowsAnySSLCertificate): Added.
1479         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1480         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1481         (WTR::TestRunner::setAllowsAnySSLCertificate): Added.
1482         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1483
1484 2016-05-25  Keith Miller  <keith_miller@apple.com>
1485
1486         run-jsc-benchmarks should use the new JSBench rather than look for it in the config file.
1487         https://bugs.webkit.org/show_bug.cgi?id=158077
1488
1489         Reviewed by Mark Lam.
1490
1491         Since we didn't have JSBench in the tree before we needed to lookup the path to it from
1492         benchmark config file. That's no longer the case so we should just fix it in the script.
1493
1494         * Scripts/run-jsc-benchmarks:
1495
1496 2016-05-24  Aakash Jain  <aakash_jain@apple.com>
1497
1498         Reorganize dashboard code: move code from _timeIntervalString to base class
1499         https://bugs.webkit.org/show_bug.cgi?id=158047
1500         rdar://problem/26457274
1501
1502         Reviewed by Alexey Proskuryakov and Dean Johnson.
1503
1504         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
1505         (BubbleQueueView.prototype._timeIntervalString): Moved core logic to base class so as to make it re-usable.
1506         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
1507         (QueueView.prototype._readableTimeString): Same.
1508
1509 2016-05-24  Yusuke Suzuki  <utatane.tea@gmail.com>
1510
1511         [JSC][GTK][EFL] Allow run-jsc-benchmark to use WebKitTestRunner in EFL / GTK ports
1512         https://bugs.webkit.org/show_bug.cgi?id=158016
1513
1514         Reviewed by Darin Adler.
1515
1516         This patch easily allows run-jsc-benchmark to run WebKitTestRunner-based tests in GTK / EFL ports.
1517         This change encourages us to run tests with the browser-heap in nix environments.
1518         Two things are modified.
1519
1520         1. Add a fall-back to look up the library path in GTK / EFL / JSCOnly environment.
1521
1522             In GTK / EFL / JSCOnly ports, the hierarchy of the build directory is slightly different from Apple port.
1523             For example, the jsc bin locate at "WebKitBuild/XXX/Release/bin/jsc" and the lib path is "WebKitBuild/XXX/Release/lib"
1524             while the one of Apple port is "WebKitBuild/XXX/Release/jsc" and "WebKitBuild/XXX/Release/lib".
1525             And based on this library path, we configure the required environment variables to run WebKitTestRunner in GTK / EFL ports.
1526
1527         2. Add --dependencies option to add dependent library paths.
1528
1529             While Apple ports does not require any additional dependent library path, GTK and EFL ports require this path,
1530             typically WebKitBuild/DependenciesGTK and WebKitBuild/DependenciesEFL respectively. So we need to add such paths to LD_LIBRARY_PATH.
1531             Instead of adding platform options like --gtk / --efl, we add --dependencies option to add the additional dependent library paths.
1532             The platform options still require the build path to look up the dependent library directory. So we pass it directly through --dependencies.
1533             Multiple additional dependent library paths can be added by using --dependencies multiple times.
1534
1535         By using these change, we can run benchmarks that require WebKitTestRunner in GTK / EFL ports (If you would like to run them in a headless manner, you can use xvbuf.).
1536         Example:
1537             `Tools/Scripts/run-jsc-benchmarks baseline:WebKitBuild/baseline/Release/bin/WebKitTestRunner patched:WebKitBuild/patched/Release/bin/WebKitTestRunner --dependencies WebKitBuild/DependenciesGTK/Root/lib --js-bench`
1538
1539         * Scripts/run-jsc-benchmarks:
1540
1541 2016-05-20  Keith Miller  <keith_miller@apple.com>
1542         We should have JSBench in PerformanceTests
1543         https://bugs.webkit.org/show_bug.cgi?id=157952
1544
1545         Rubber-stamped by Saam Barati.
1546
1547         This changes the runner to use the layout of the newest version of JSBench.
1548
1549         * Scripts/run-jsc-benchmarks:
1550
1551 2016-05-24  Chris Dumez  <cdumez@apple.com>
1552
1553         Use auto for some of our lambda function parameters
1554         https://bugs.webkit.org/show_bug.cgi?id=158001
1555
1556         Reviewed by Darin Adler.
1557
1558         Use auto for some of our lambda function parameters now that we build with c++14.
1559
1560         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1561         (WTR::InjectedBundle::willDestroyPage):
1562
1563 2016-05-23  Brady Eidson  <beidson@apple.com>
1564
1565         check-webkit-style gets flags std::literals::chrono_literals as bad naming.
1566         https://bugs.webkit.org/show_bug.cgi?id=157969
1567
1568         Reviewed by Alex Christensen.
1569
1570         * Scripts/webkitpy/style/checkers/cpp.py:
1571         (check_identifier_name_in_declaration):
1572         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1573         (WebKitStyleTest.test_names):
1574
1575 2016-05-22  Alexey Proskuryakov  <ap@apple.com>
1576
1577         RELEASE_ASSERT(TestController::singleton().isCurrentInvocation(testInvocation)) is sometimes hit when running tests
1578         https://bugs.webkit.org/show_bug.cgi?id=157977
1579         rdar://problem/20874156
1580
1581         Reviewed by David Kilzer.
1582
1583         * WebKitTestRunner/TestInvocation.cpp:
1584         (WTR::TestInvocation::invoke): Be more certain to launch a new process when there was
1585         a timeout detected. If we don't, there is a chance that the process is not quite frozen,
1586         and will still send a response that we no longer expect.
1587         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Print timeout details to stderr
1588         too, as stdout is not available, at least not in the case that I was observing.
1589
1590 2016-05-22  Brady Eidson  <beidson@apple.com>
1591
1592         Move to C++14.
1593         https://bugs.webkit.org/show_bug.cgi?id=157948
1594
1595         Reviewed by Michael Catanzaro.
1596
1597         * DumpRenderTree/mac/Configurations/Base.xcconfig:
1598         * MiniBrowser/Configurations/Base.xcconfig:
1599         * TestWebKitAPI/Configurations/Base.xcconfig:
1600         * WebKitTestRunner/Configurations/Base.xcconfig:
1601
1602 2016-05-21  Aakash Jain  <aakash_jain@apple.com>
1603
1604         Simulator launch fails intermittently due to failure in checking simulator boot status
1605         https://bugs.webkit.org/show_bug.cgi?id=157965
1606         rdar://problem/26402404
1607
1608         Reviewed by Alexey Proskuryakov.
1609
1610         * Scripts/webkitpy/xcode/simulator.py:
1611         (Simulator.wait_until_device_is_booted): Ignore CalledProcessError exception while checking
1612         whether simulator has finished booting.
1613
1614 2016-05-21  Dan Bernstein  <mitz@apple.com>
1615
1616         Silence warnings from svn propget when using newer versions of Subversion.
1617         https://bugs.webkit.org/show_bug.cgi?id=157879
1618
1619         Reviewed by Daniel Bates.
1620
1621         * Scripts/prepare-ChangeLog:
1622         (attributeCommand): Redirect svn propget stderr to /dev/null.
1623         * Scripts/svn-create-patch:
1624         (findMimeType): Ditto.
1625
1626 2016-05-20  Ryosuke Niwa  <rniwa@webkit.org>
1627
1628         run-benchmark's results should contain Animometer's debug output
1629         https://bugs.webkit.org/show_bug.cgi?id=157941
1630
1631         Reviewed by Stephanie Lewis.
1632
1633         Modified the Animometer patch to store debug output and made benchmark_runner extract them together as a single array.
1634         The result can be dragged and dropped into Animometer's developer.html page.
1635
1636         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
1637         (BenchmarkRunner._run_one_test): Parse JSON here instead of doing it in multiple call sites.
1638         (BenchmarkRunner._run_benchmark): Strip debugOutput from individual test result, and merge them together separately.
1639         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch:
1640         Modified the patch to store the debug output.
1641         * Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py:
1642         (ServerControl.render_POST): Fixed a bug that POST to /report results in 500 because getvalue is not defined
1643         when the request body is larger than a certain size on twisted.
1644
1645 2016-05-20  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1646
1647         Use clearer names for JSON output of javascriptcore test results
1648         https://bugs.webkit.org/show_bug.cgi?id=157921
1649
1650         Reviewed by Alexey Proskuryakov.
1651
1652         "failures" and "apiTestResult" were somewhat ambiguous names. 
1653         
1654         * Scripts/run-javascriptcore-tests:
1655         (runJSCStressTests): "failures" -> "stressFailures", "apiTestResult" -> "allApiTestsPassed".
1656
1657 2016-05-20  Chris Dumez  <cdumez@apple.com>
1658
1659         Unreviewed, fix API test introduced in r201213.
1660
1661         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1662         (TestWebKitAPI::TEST):
1663
1664 2016-05-20  Rawinder Singh  <rawinder.singh-webkit@cisra.canon.com.au>
1665
1666         Implement operator== for WeakPtr
1667         https://bugs.webkit.org/show_bug.cgi?id=157883
1668
1669         Reviewed by Chris Dumez.
1670
1671         Implement operator== and operator!= for WeakPtr and update code to use the operators.
1672
1673         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
1674         (TestWebKitAPI::TEST):
1675
1676 2016-05-19  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1677
1678         Add JSON results to 32-bit and CLoop JSC tests
1679         https://bugs.webkit.org/show_bug.cgi?id=157929
1680
1681         Reviewed by Alexey Proskuryakov.
1682
1683         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1684         (RunLLINTCLoopTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
1685         (Run32bitJSCTests): Change command-line parameters to run-javascriptcore-tests in order to get JSON output.
1686
1687 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1688
1689         Typo fix in import-test262-tests
1690         https://bugs.webkit.org/show_bug.cgi?id=157902
1691
1692         Reviewed by Keith Miller.
1693
1694         * Scripts/import-test262-tests:
1695
1696 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1697
1698         [EFL] Fix the gst-libav build on ARM Thumb2 after r199649
1699         https://bugs.webkit.org/show_bug.cgi?id=157893
1700
1701         Reviewed by Antonio Gomes.
1702
1703         * efl/patches/gst-libav.patch:
1704
1705 2016-05-19  Jer Noble  <jer.noble@apple.com>
1706
1707         REGRESSION(r200951): VideoControlsManager API tests time out
1708         https://bugs.webkit.org/show_bug.cgi?id=157896
1709         <rdar://problem/26326293>
1710
1711         Reviewed by Eric Carlson.
1712
1713         Explicitly disable user gesture requirements for playback.
1714
1715         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1716         (TestWebKitAPI::TEST):
1717
1718 2016-05-19  Csaba Osztrogonác  <ossy@webkit.org>
1719
1720         Slow JSC stress tests times out in 32 bit debug mode
1721         https://bugs.webkit.org/show_bug.cgi?id=154964
1722
1723         Reviewed by Michael Catanzaro.
1724
1725         * Scripts/run-javascriptcore-tests:
1726         (runJSCStressTests): Pass through the --debug option.
1727         * Scripts/run-jsc-stress-tests: Increase the timeout for debug builds.
1728
1729 2016-05-18  Aakash Jain  <aakash_jain@apple.com>
1730
1731         Remove underline from Status Bubbles on dashboard
1732         https://bugs.webkit.org/show_bug.cgi?id=157870
1733         rdar://problem/26332321
1734
1735         Reviewed by Alexey Proskuryakov.
1736
1737         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css: Reverted style 
1738         change made in http://trac.webkit.org/r200880
1739
1740 2016-05-18  Michael Saboff  <msaboff@apple.com>
1741
1742         r199812 broke test262
1743         https://bugs.webkit.org/show_bug.cgi?id=157595
1744
1745         Reviewed by Filip Pizlo.
1746
1747         Added a new run type, runOneLargeHeap, for tests that use a large amount of memory.
1748         This run type will not run with the --memory-limited option.  Without that option,
1749         we'll only the default test variant.
1750
1751         * Scripts/run-jsc-stress-tests:
1752
1753 2016-05-18  Simon Fraser  <simon.fraser@apple.com>
1754
1755         REGRESSION (r200534) Command-+ no longer zooms pages 
1756         https://bugs.webkit.org/show_bug.cgi?id=157826
1757         rdar://problem/26334636
1758
1759         Reviewed by Dean Jackson.
1760
1761         * DumpRenderTree/mac/DumpRenderTree.mm:
1762         (resetWebPreferencesToConsistentValues): Remove ENABLE() #ifdefs that do nothing (see http://webkit.org/b/157828).
1763
1764 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
1765
1766         [GTK] accessibility/meter-element.html is failing
1767         https://bugs.webkit.org/show_bug.cgi?id=115633
1768
1769         Reviewed by Chris Fleizach.
1770
1771         Implement AccessibilityUIElement::valueDescription() and add mapping
1772         from ATK_ROLE_LEVEL_BAR to AXProgressIndicator.
1773
1774         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1775         (WTR::AccessibilityUIElement::valueDescription):
1776
1777 2016-05-18  Brady Eidson  <beidson@apple.com>
1778
1779         Modern IDB: Make TestRunner.clearAllDatabases also delete IndexedDB databases (once doing so is supported).
1780         https://bugs.webkit.org/show_bug.cgi?id=157823
1781
1782         Reviewed by Alex Christensen.
1783
1784         * DumpRenderTree/mac/TestRunnerMac.mm:
1785         (TestRunner::clearAllDatabases):
1786         
1787         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1788         (WTR::TestRunner::clearAllDatabases):
1789         
1790         * WebKitTestRunner/TestInvocation.cpp:
1791         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1792
1793 2016-05-18  Joanmarie Diggs  <jdiggs@igalia.com>
1794
1795         AX: [ATK] Use WebCore Accessibility's AccessibilityText for AtkObject name and description
1796         https://bugs.webkit.org/show_bug.cgi?id=157822
1797
1798         Reviewed by Chris Fleizach.
1799
1800         Fix AccessibilityUIElement::helpText() so that it returns an empty string rather than
1801         nullptr upon failure.
1802
1803         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1804         (WTR::AccessibilityUIElement::helpText):
1805
1806 2016-05-17  Beth Dakin  <bdakin@apple.com>
1807
1808         Make handleAcceptedCandidate a public function
1809         https://bugs.webkit.org/show_bug.cgi?id=157763
1810         -and corresponding-
1811         rdar://problem/26206397
1812
1813         Reviewed by Tim Horton.
1814
1815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1816         * TestWebKitAPI/Tests/WebKit2Cocoa/autofocused-text-input.html: Added.
1817         * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm: Added.
1818         (-[DoNotLeakWebView dealloc]):
1819         (-[DoNotLeakWebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
1820         (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
1821         (TestWebKitAPI::TEST):
1822
1823 2016-05-17  Keith Miller  <keith_miller@apple.com>
1824
1825         Add test262 harness support code
1826         https://bugs.webkit.org/show_bug.cgi?id=157797
1827
1828         Reviewed by Filip Pizlo.
1829
1830         The import-test262-tests script is used to generate the yaml file used to run test262. It
1831         takes a path to the local copy of the Test262 repository as well as an optional path to file
1832         containing a list of failures. This script currently just creates the yaml file used to run
1833         the script. It does not relocate the test files into our tests directory. In the future I
1834         plan to add that feature but it didn't seem essential for the first iteration. Since many
1835         test262 tests need to be run in both strict and non-strict mode, import-test262-tests
1836         creates two separate runs for those tests. This enables us to distinguish between failures
1837         in only one of the two modes.
1838
1839         This patch also updates the run-jsc-stress-tests Script to run tests from Test262. In order
1840         to do so two new run commands were needed runTest262 and prepareTest262Fixture. runTest262
1841         takes an actual test file along with the metadata associated with it. prepareTest262Fixture
1842         takes a fixture file (used by module tests for importing) and makes sure that file is
1843         properly relocated to the test runner directory.
1844
1845         The proccess I used to import the tests was to first run import-test262-tests to create a
1846         yaml for all the tests (import-test262-tests assumes all tests pass if to failures file is
1847         passed). Then I ran the generated yaml file with "run-jsc-stress-tests -v -c 1" piping the
1848         output to a file and collected all the lines with "FAIL" in it. Finally, I reran
1849         import-test262-tests with the new failure file to create the final yaml.
1850
1851         * Scripts/import-test262-tests: Added.
1852         * Scripts/run-jsc-stress-tests:
1853
1854 2016-05-16  Enrica Casucci  <enrica@apple.com>
1855
1856         build fix after r200968 and r200969
1857
1858         Unreviewed.
1859
1860         * DumpRenderTree/mac/EventSendingController.mm:
1861         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1862
1863 2016-05-16  Jer Noble  <jer.noble@apple.com>
1864
1865         API test WebKit2.MSEIsPlayingAudio timing out after r200951
1866         https://bugs.webkit.org/show_bug.cgi?id=157748
1867
1868         Reviewed by Eric Carlson.
1869
1870         The file-with-mse.html testcase only calls play() once it's own XHR loading is complete; the
1871         "user gesture" check fails at that point.  Call play() up front; playback will begin as soon
1872         as enough data is loaded.
1873
1874         * TestWebKitAPI/Tests/WebKit2/file-with-mse.html:
1875
1876 2016-05-16  Enrica Casucci  <enrica@apple.com>
1877
1878         Remove unused initializer for WebEvent on iOS.
1879         https://bugs.webkit.org/show_bug.cgi?id=157689
1880
1881         Reviewed by Anders Carlsson.
1882
1883         Adopting different initializer for WebEvent to fix the build.
1884
1885         * DumpRenderTree/mac/EventSendingController.mm:
1886         (-[EventSendingController keyDown:withModifiers:withLocation:]):
1887
1888 2016-05-16  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
1889
1890         Add machine-readable results for JSC API tests to the Buildbot json log
1891         https://bugs.webkit.org/show_bug.cgi?id=157642
1892
1893         Reviewed by Geoffrey Garen.
1894
1895         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1896         (RunJavaScriptCoreTests): Use --no-fail-fast option on run-javascriptcore-tests
1897         * Scripts/run-javascriptcore-tests:
1898         (runJSCStressTests): Abstracted out writing JSON to file (new function below)
1899         (writeJsonDataIfApplicable): Added
1900
1901 2016-04-06  Jer Noble  <jer.noble@apple.com>
1902
1903         [WK2] Add API to WKWebViewConfiguration to control autoplay policy.
1904         https://bugs.webkit.org/show_bug.cgi?id=156312
1905
1906         Reviewed by Dan Bernstein.
1907
1908         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1909         (WTR::initializeWebViewConfiguration):
1910         * TestWebKitAPI/Tests/WebKit2Cocoa/RequiresUserActionForPlayback.mm:
1911         (TEST_F):
1912
1913 2016-05-16  Brent Fulgham  <bfulgham@apple.com>
1914
1915         REGRESSION (r192098): Content missing after copy and paste to Notes App on retina displays
1916         https://bugs.webkit.org/show_bug.cgi?id=157630
1917         <rdar://problem/25277577>
1918
1919         Reviewed by Simon Fraser.
1920
1921         Update test infrastructure to support checking the number of images in the pasteboard.
1922
1923         * DumpRenderTree/TestRunner.cpp:
1924         (imageCountInGeneralPasteboardCallback): Added.
1925         (TestRunner::staticFunctions):
1926         * DumpRenderTree/TestRunner.h:
1927         * DumpRenderTree/mac/TestRunnerMac.mm:
1928         (TestRunner::imageCountInGeneralPasteboard): Added.
1929         * DumpRenderTree/win/TestRunnerWin.cpp:
1930         (TestRunner::imageCountInGeneralPasteboard): Added stub method.
1931         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1932         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1933         (WTR::InjectedBundle::imageCountInGeneralPasteboard): Added.
1934         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
1935         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1936         (WTR::TestRunner::imageCountInGeneralPasteboard): Added.
1937         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1938         * WebKitTestRunner/TestController.cpp:
1939         (WTR::TestController::imageCountInGeneralPasteboard): Added stub implementation.
1940         * WebKitTestRunner/TestController.h:
1941         * WebKitTestRunner/TestInvocation.cpp:
1942         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Handle copy message.
1943         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1944         (WTR::TestController::imageCountInGeneralPasteboard): Added.
1945
1946 2016-05-13  Dewei Zhu  <dewei_zhu@apple.com>
1947
1948         Fix JSBench which causes math domain error in run-benchmark script.
1949         https://bugs.webkit.org/show_bug.cgi?id=157697
1950         <rdar://problem/26279292>
1951
1952         Reviewed by Ryosuke Niwa.
1953
1954         Some tests of JSBench give time usage to be 0 ms which will causes error while calculating geometric mean.
1955         Also fix a round-off error while calculating stdev.
1956
1957         * Scripts/webkitpy/benchmark_runner/benchmark_results.py:
1958         (BenchmarkResults._format_values):
1959         * Scripts/webkitpy/benchmark_runner/data/patches/JSBench.patch:
1960
1961 2016-05-13  Brady Eidson  <beidson@apple.com>
1962
1963         Extend protector naming code style guideline to cover operator= assignment.
1964         https://bugs.webkit.org/show_bug.cgi?id=157693
1965
1966         Reviewed by Darin Adler.
1967
1968         * Scripts/webkitpy/style/checkers/cpp.py:
1969         (check_identifier_name_in_declaration):
1970         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
1971         (WebKitStyleTest.test_names):
1972
1973 2016-05-13  Aakash Jain  <aakash_jain@apple.com>
1974
1975         Dashboard code restructuring
1976         https://bugs.webkit.org/show_bug.cgi?id=157680
1977         <rdar://problem/14736888>
1978
1979         Reviewed by Alexey Proskuryakov.
1980
1981         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueView.js:
1982         (BubbleQueueView.prototype.addLinkToRow): Moved to base class.
1983         (BubbleQueueView.prototype.addTextToRow): Moved to base class.
1984         (BubbleQueueView.prototype._addDividerToPopover): Moved to base class.
1985         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotBuilderQueueView.js:
1986         (BuildbotBuilderQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
1987         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotCombinedQueueView.js:
1988         (BuildbotCombinedQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
1989         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:
1990         (BuildbotTesterQueueView.prototype.update): Passing additional argument to _appendPendingRevisionCount.
1991         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:
1992         (BuildbotQueueView.prototype._appendPendingRevisionCount): Moved to base class and modified to take
1993         additional argument.
1994         (BuildbotQueueView.prototype._popoverLinesForCommitRange): Moved to base class.
1995         (BuildbotQueueView.prototype._presentPopoverForPendingCommits): Moved to base class.
1996         (BuildbotQueueView.prototype._addDividerToPopover): Moved to base class.
1997         (BuildbotQueueView.prototype._formatRevisionForDisplay): Moved to base class.
1998         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
1999         (documentReady): Display any customView if available.
2000         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/QueueView.js:
2001         (QueueView.prototype.addLinkToRow): Moved from child class, no changes.
2002         (QueueView.prototype.addTextToRow): Moved from child class, no changes.
2003         (QueueView.prototype._addDividerToPopover): Moved from child class, no changes.
2004         (QueueView.prototype._appendPendingRevisionCount): Moved from child class, made it more generic
2005         by taking latestIterationGetter method as an argument.
2006         (QueueView.prototype._popoverLinesForCommitRange): Moved from child class, no changes.
2007         (QueueView.prototype._presentPopoverForPendingCommits): Moved from child class, no changes.
2008         (QueueView.prototype._formatRevisionForDisplay): Moved from child class, no changes.
2009         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
2010         (a:hover:link): Underline only when there is a link.
2011
2012 2016-05-13  Yoav Weiss  <yoav@yoav.ws>
2013
2014         Turn on WEB_TIMING for all ports
2015         https://bugs.webkit.org/show_bug.cgi?id=157673
2016
2017         Reviewed by Alex Christensen.
2018
2019         * Scripts/webkitperl/FeatureList.pm: Make sure that WEB_TIMING is on by default.
2020
2021 2016-05-13  Brady Eidson  <beidson@apple.com>
2022
2023         Protector Ref/RefPtrs should have a specified naming style.
2024         https://bugs.webkit.org/show_bug.cgi?id=157591
2025
2026         Reviewed by Darin Adler.
2027
2028         * Scripts/webkitpy/style/checkers/cpp.py:
2029         (check_identifier_name_in_declaration):
2030         (CppChecker):
2031         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2032         (WebKitStyleTest.test_names):
2033
2034 2016-05-12  Csaba Osztrogonác  <ossy@webkit.org>
2035
2036         Remove ENABLE(ES6_ARROWFUNCTION_SYNTAX) guards
2037         https://bugs.webkit.org/show_bug.cgi?id=157564
2038
2039         Reviewed by Darin Adler.
2040
2041         * Scripts/webkitperl/FeatureList.pm:
2042         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2043
2044 2016-05-11  Joanmarie Diggs  <jdiggs@igalia.com>
2045
2046         [GTK] accessibility/aria-readonly.html is failing
2047         https://bugs.webkit.org/show_bug.cgi?id=98357
2048
2049         Reviewed by Chris Fleizach.
2050
2051         Add checks to isAttributeSettable() for ATK_STATE_READ_ONLY and the 'readonly'
2052         AtkObject attribute along with ATK_STATE_CHECKABLE for toggle-able elements,
2053         ATK_STATE_SELECTABLE for select elements, and ATK_STATE_FOCUSABLE combined
2054         with range verification for inputs which implement AtkValue. The latter two
2055         additions are admittedly a heuristic workaround for platform accessibility
2056         API differences. But they should be sufficient to facilitate cross-platform
2057         testing of isAttributeSettable() for form elements which lack ARIA attributes.
2058
2059         Bump the minimum version of at-spi2-core and at-spi2-atk
2060         to 2.15.4 (earliest version that supports STATE_READ_ONLY).
2061
2062         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2063         (WTR::AccessibilityUIElement::isAttributeSettable):
2064         * gtk/jhbuild.modules:
2065
2066 2016-05-10  Ryan Haddad  <ryanhaddad@apple.com>
2067
2068         Another attempt to fix the build after r200668.
2069
2070         Unreviewed build fix.
2071
2072         * TestWebKitAPI/Tests/WebKit2Cocoa/Coding.mm:
2073         (TEST):
2074
2075 2016-05-10  Dan Bernstein  <mitz@apple.com>
2076
2077         Tried to fix the Mac build after r200668.
2078
2079         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2080         (WTR::TestController::platformCreateWebView):
2081
2082 2016-05-10  Sam Weinig  <sam@webkit.org>
2083
2084         Tweak underline style for data detected links
2085         https://bugs.webkit.org/show_bug.cgi?id=157546
2086
2087         Reviewed by Tim Horton.
2088
2089         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2090         * TestWebKitAPI/Tests/WebCore/Color.cpp: Added.
2091         (TestWebKitAPI::TEST):
2092         Add tests for the new Color::getHSV() function.
2093
2094 2016-05-10  Filip Pizlo  <fpizlo@apple.com>
2095
2096         Internal JSC profiler should have a timestamped log of events for each code block
2097         https://bugs.webkit.org/show_bug.cgi?id=157538
2098
2099         Reviewed by Benjamin Poulain.
2100
2101         * Scripts/display-profiler-output:
2102
2103 2016-05-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2104
2105         [Linux] Remove seccomp filters support
2106         https://bugs.webkit.org/show_bug.cgi?id=157380
2107
2108         Reviewed by Darin Adler.
2109
2110         * Scripts/webkitperl/FeatureList.pm:
2111         * TestWebKitAPI/PlatformEfl.cmake:
2112         * TestWebKitAPI/PlatformGTK.cmake:
2113         * TestWebKitAPI/Tests/WebKit2/SeccompFilters.cpp: Removed.
2114         * efl/jhbuild.modules:
2115         * gtk/jhbuild.modules:
2116
2117 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
2118
2119         [iOS] visibility:hidden -webkit-overflow-scrolling: touch divs can interfere with page scrolling
2120         https://bugs.webkit.org/show_bug.cgi?id=157496
2121         rdar://problem/22963278
2122
2123         Reviewed by Tim Horton.
2124
2125         Enhance UIScriptController to generate a drag, which is useful for scrolling.
2126
2127         * WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
2128         * WebKitTestRunner/UIScriptContext/UIScriptController.cpp:
2129         (WTR::UIScriptController::dragFromPointToPoint):
2130         * WebKitTestRunner/UIScriptContext/UIScriptController.h:
2131         * WebKitTestRunner/ios/HIDEventGenerator.h:
2132         * WebKitTestRunner/ios/HIDEventGenerator.mm:
2133         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
2134         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2135         (WTR::UIScriptController::dragFromPointToPoint):
2136
2137 2016-05-09  Simon Fraser  <simon.fraser@apple.com>
2138
2139         Remove testRunner.setTextAutosizingEnabled and migrate the one test that uses it
2140         https://bugs.webkit.org/show_bug.cgi?id=157480
2141
2142         Reviewed by Zalan Bujtas.
2143
2144         Migrate the one test that used testRunner.setTextAutosizingEnabled() to window.internals.settings.setTextAutosizingEnabled()
2145         and move it next to the other iOS text autosizing tests.
2146         
2147         Remove testRunner.setTextAutosizingEnabled(), which was only implemented in DumpRenderTree.
2148
2149         * DumpRenderTree/TestRunner.cpp:
2150         (setTextAutosizingEnabledCallback): Deleted.
2151         (TestRunner::staticFunctions): Deleted.
2152         * DumpRenderTree/mac/TestRunnerMac.mm:
2153         (TestRunner::setTextAutosizingEnabled): Deleted.
2154
2155 2016-05-07  Darin Adler  <darin@apple.com>
2156
2157         Next step on dictionary bindings, along with other bindings refinements
2158         https://bugs.webkit.org/show_bug.cgi?id=157451
2159
2160         Reviewed by Chris Dumez.
2161
2162         * Scripts/do-webcore-rename: Use this to rename JSDOMBuild.h to JSDOMConvert.h.
2163         Also skip test expectations in a directory that this was modifying unnecessarily.
2164
2165 2016-05-06  Simon Fraser  <simon.fraser@apple.com>
2166
2167         Enable IOS_TEXT_AUTOSIZING on Mac and make it testable
2168         https://bugs.webkit.org/show_bug.cgi?id=157432
2169         rdar://problem/16406720
2170
2171         Reviewed by Dean Jackson.
2172
2173         Enable IOS_TEXT_AUTOSIZING on Mac so it can be tested.
2174
2175         Make the setTextAutosizingEnabled() Setting work, and plumb it through WK1 and WK2
2176         preferences for WTR and DRT. Make textAutosizingWindowSizeOverride() work, for layout tests.
2177         These two settings are shared with TEXT_AUTOSIZING.
2178
2179         Add a TextAutosizing log channel, which is useful for generated -expected.html results.
2180
2181         Move adjustComputedFontSizesOnBlocks() and related code from RenderObject to RenderElement
2182         without changes.
2183
2184         An implication of this set of changes is that the way clients enable text autosizing
2185         has changed. Previously, they set the "MinimumZoomFontSize" preference to 0.
2186         Settings::defaultMinimumZoomFontSize() used to do this in order to enable text autosizing
2187         on iPhone only, not iPad.
2188
2189         Now the preferred technique is to leave minimumZoomFontSize alone, and to use textAutosizingEnabled()
2190         instead. Settings::defaultTextAutosizingEnabled() now does the check for iPhone.
2191
2192         UIWebView calls WebKitGetMinimumZoomFontSize() to setup the default minimum font zoom size,
2193         which will now always return 15, but had no other code that toggled this. So it's safe to just rely
2194         on Settings::defaultTextAutosizingEnabled() doing the right thing for iPhone/iPad.
2195
2196         * DumpRenderTree/mac/DumpRenderTree.mm:
2197         (resetWebPreferencesToConsistentValues):
2198         * DumpRenderTree/mac/TestRunnerMac.mm:
2199         (TestRunner::setTextAutosizingEnabled):
2200         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2201         * WebKitTestRunner/ios/TestControllerIOS.mm:
2202         (WTR::TestController::platformResetPreferencesToConsistentValues):
2203
2204 2016-05-06  Dean Jackson  <dino@apple.com>
2205
2206         Regions, Shapes and Tracks don't need runtime features
2207         https://bugs.webkit.org/show_bug.cgi?id=157426
2208         <rdar://problem/26146262>
2209
2210         Reviewed by Simon Fraser.
2211
2212         The following RuntimeEnabledFeatures can be removed since
2213         we have no need to disable them (they are stable and have
2214         shipped for a while):
2215         - CSS Regions
2216         - CSS Shapes
2217         - Media tracks
2218
2219         * DumpRenderTree/mac/DumpRenderTree.mm:
2220         (resetWebPreferencesToConsistentValues): Deleted.
2221
2222 2016-05-06  Ryan Haddad  <ryanhaddad@apple.com>
2223
2224         Increase delay when launching multiple ios-simulators in parallel
2225         https://bugs.webkit.org/show_bug.cgi?id=157422
2226
2227         Reviewed by Alexey Proskuryakov.
2228
2229         Tests are intermittently failing when launching multiple simulators in parallel due to "You are opening
2230         this application for the first time" confirmation dialogs. Increasing the delay to alleviate this issue.
2231
2232         * Scripts/webkitpy/port/ios.py:
2233         (IOSSimulatorPort.setup_test_run):
2234
2235 2016-05-06  Per Arne Vollan  <peavo@outlook.com>
2236
2237         [Win] Remove WinXP support.
2238         https://bugs.webkit.org/show_bug.cgi?id=157416
2239
2240         Reviewed by Brent Fulgham.
2241
2242         * win/DLLLauncher/DLLLauncherMain.cpp:
2243         (enableTerminationOnHeapCorruption):
2244
2245 2016-05-06  Manuel Rego Casasnovas  <rego@igalia.com>
2246
2247         [css-grid] Unprefix CSS Grid Layout properties
2248         https://bugs.webkit.org/show_bug.cgi?id=157137
2249
2250         Reviewed by Simon Fraser.
2251
2252         Remove "-webkit" prefix from all the grid layout properties,
2253         including the display value.
2254         Update the source code to remove the prefix where it was used too.
2255
2256         * TestWebKitAPI/Tests/WebCore/CSSParser.cpp:
2257         (TestWebKitAPI::TEST):
2258
2259 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
2260
2261         Partially revert http://trac.webkit.org/r200504
2262         Improve HTTP test names in WebKitTestRunner's crash report information
2263         https://bugs.webkit.org/show_bug.cgi?id=157389
2264
2265         * WebKitTestRunner/cocoa/CrashReporterInfo.mm: Turns out that we can't have URLs
2266         in crash reporter information.
2267
2268 2016-05-05  Alexey Proskuryakov  <ap@apple.com>
2269
2270         Improve HTTP test names in WebKitTestRunner's crash report information
2271         https://bugs.webkit.org/show_bug.cgi?id=157389
2272
2273         Reviewed by Alex Christensen.
2274
2275         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
2276         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame): Added a FIXME.
2277
2278         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
2279         (WTR::testDescription): Don't bail out if the port is neither 8000 nor 8443; we
2280         use other port numbers too. For http tests, return the complete URL string, not
2281         just the path.
2282
2283 2016-05-04  Alex Christensen  <achristensen@webkit.org>
2284
2285         Blocked redirected main resource requests need descriptive errors
2286         https://bugs.webkit.org/show_bug.cgi?id=156828
2287         rdar://problem/25711316
2288
2289         Reviewed by Daniel Bates.
2290
2291         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2292         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame):
2293         Print out the error type to make sure we have the most descriptive error type.
2294
2295 2016-05-05  Enrique Ocaña González  <eocanha@igalia.com>
2296
2297         [GStreamer] Bump internal jhbuild versions to 1.8.0 and patches to support MSE
2298         https://bugs.webkit.org/show_bug.cgi?id=157341
2299
2300         Reviewed by Xabier Rodriguez-Calvar.
2301
2302         * gtk/jhbuild.modules:
2303         * gtk/patches/gst-plugins-good-Revert-qtdemux-expose-streams-with-first-moof-for-fr.patch: Added.
2304         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch: Added.
2305
2306 2016-05-04  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2307
2308         Add JSC test results in JSON format to a Buildbot log
2309         https://bugs.webkit.org/show_bug.cgi?id=156920
2310
2311         Reviewed by Daniel Bates.
2312
2313         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2314         (RunJavaScriptCoreTests): Move command-line option for output file out
2315         of WithProperties.
2316
2317 2016-05-04  Dean Jackson  <dino@apple.com>
2318
2319         TestRunner should always enable all the experimental features
2320         https://bugs.webkit.org/show_bug.cgi?id=157360
2321         <rdar://problem/26099748>
2322
2323         Reviewed by Anders Carlsson.
2324
2325         Call the new SPI that enables all the experimental features.
2326
2327         * WebKitTestRunner/TestController.cpp:
2328         (WTR::TestController::resetPreferencesToConsistentValues):
2329
2330 2016-05-04  Mark Lam  <mark.lam@apple.com>
2331
2332         ES6 Function.name inferred from property names of literal objects can break some websites.
2333         https://bugs.webkit.org/show_bug.cgi?id=157246
2334
2335         Reviewed by Geoffrey Garen.
2336
2337         * WebKitTestRunner/TestController.cpp:
2338         (WTR::TestController::resetPreferencesToConsistentValues):
2339         (WTR::updateTestOptionsFromTestHeader):
2340         * WebKitTestRunner/TestOptions.h:
2341
2342         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
2343         (WTR::PlatformWebView::viewSupportsOptions):
2344         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
2345         (WTR::PlatformWebView::viewSupportsOptions):
2346         - Add needsSiteSpecificQuirks to WKTR options that can be set. 
2347
2348 2016-05-04  Joanmarie Diggs  <jdiggs@igalia.com>
2349
2350         AX: ARIA 'region' role is now a landmark; HTML 'section' element should be a landmark only if named
2351         https://bugs.webkit.org/show_bug.cgi?id=157331
2352
2353         Reviewed by Chris Fleizach.
2354
2355         Add AXLandmarkRegion to the landmark strings handled by roleToString
2356         for objects with ATK_ROLE_LANDMARK.
2357
2358         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2359
2360 2016-05-03  Beth Dakin  <bdakin@apple.com>
2361
2362         Add VideoControlsManager tests
2363         https://bugs.webkit.org/show_bug.cgi?id=157332
2364         -and corresponding-
2365         rdar://problem/24358431
2366
2367         Reviewed by Sam Weinig.
2368
2369         This patch adds three VideoControlsManager tests.
2370
2371         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2372         * TestWebKitAPI/Tests/WebKit/ios/video-with-audio.html:
2373         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm: Added.
2374         (-[DidPlayMessageHandler initWithWKWebView:]):
2375         (-[DidPlayMessageHandler userContentController:didReceiveScriptMessage:]):
2376         (TestWebKitAPI::TEST):
2377         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.html: Added.
2378         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-with-audio.mp4: Added.
2379         * TestWebKitAPI/Tests/WebKit2Cocoa/large-video-without-audio.html: Added.
2380
2381 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
2382
2383         [ATK] accessibility/document-attributes.html is failing
2384         https://bugs.webkit.org/show_bug.cgi?id=125348
2385
2386         Reviewed by Chris Fleizach.
2387
2388         The test was failing because the WebArea is now being exposed with the role of
2389         ATK_ROLE_DOCUMENT_WEB; not ATK_ROLE_DOCUMENT_FRAME. Unfortunately, when that
2390         change was made, documentEncoding() and documentURI() were not updated accordingly.
2391
2392         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2393         (WTR::AccessibilityUIElement::documentEncoding):
2394         (WTR::AccessibilityUIElement::documentURI):
2395
2396 2016-05-03  Brent Fulgham  <bfulgham@apple.com>
2397
2398         [Win] Unreviewed build fix.
2399
2400         * EWSTools/start-queue-win.sh: Establish proper VS2015 build
2401         environment at start of queue run.
2402
2403 2016-05-03  Joanmarie Diggs  <jdiggs@igalia.com>
2404
2405         [ATK] accessibility/content-editable-as-textarea.html fails
2406         https://bugs.webkit.org/show_bug.cgi?id=155353
2407
2408         Reviewed by Darin Adler.
2409
2410         The test was timing out because it expected an AXValueChanged notification.
2411         In ATK, AXValueChanged notifications are made for widgets which implement
2412         the AtkValue interface (sliders, progress bars, etc.). We should be listening
2413         for AXTextChanged instead. AtkText's text-insert and text-remove have been
2414         added to the AccessibilityNotificationHandler.
2415
2416         Also, ATK's AccessibilityUIElement support had a number of unimplemented
2417         methods that are being used as part of the previously-failing test. Those
2418         methods are now implemented so that the ATK results are much more similar
2419         to those on the Mac.
2420
2421         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
2422         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
2423         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2424         (WTR::AccessibilityUIElement::stringAttributeValue):
2425         (WTR::AccessibilityUIElement::rangeForLine):
2426         (WTR::AccessibilityUIElement::boundsForRange):
2427         (WTR::AccessibilityUIElement::attributedStringForRange):
2428
2429 2016-05-02  Brady Eidson  <beidson@apple.com>
2430
2431         Add the ability to accumulate logs for specific logging channels to help diagnose test timeouts.
2432         https://bugs.webkit.org/show_bug.cgi?id=157274
2433
2434         Reviewed by Alex Christensen.
2435
2436         Add the new accumulate method to DRT's TestRunner, dump the accumulated logs if there's a timeout,
2437         and reset them in between tests:
2438         * DumpRenderTree/TestRunner.cpp:
2439         (accummulateLogsForChannel):
2440         (TestRunner::staticFunctions):
2441         (TestRunner::waitToDumpWatchdogTimerFired):
2442         (TestRunner::setAccummulateLogsForChannel):
2443         * DumpRenderTree/TestRunner.h:
2444         * DumpRenderTree/mac/DumpRenderTree.mm:
2445         (resetWebViewToConsistentStateBeforeTesting):
2446
2447         Also add the new method to WKTR's TestRunner, but just stubbed for now:
2448         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2449         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2450         (WTR::TestRunner::accummulateLogsForChannel):
2451         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2452
2453 2016-05-02  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2454
2455         Add fail-fast option to run-javascriptcore-tests
2456         https://bugs.webkit.org/show_bug.cgi?id=157270
2457
2458         Reviewed by Geoffrey Garen.
2459
2460         * Scripts/run-javascriptcore-tests: Add fail-fast command line option.
2461         Defaults to yes, which is the current behavior.
2462
2463 2016-05-02  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2464
2465         [CMake] MiniBrowser fails to build because libsoup link flags are not defined.
2466         https://bugs.webkit.org/show_bug.cgi?id=157268
2467
2468         Reviewed by Michael Catanzaro.
2469
2470         * MiniBrowser/gtk/CMakeLists.txt:
2471
2472 2016-04-30  Darin Adler  <darin@apple.com>
2473
2474         Streamline and remove unused bindings generation code
2475         https://bugs.webkit.org/show_bug.cgi?id=157237
2476
2477         Reviewed by Chris Dumez.
2478
2479         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
2480         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
2481         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2482         Replace non-standard "int" with standard "long", which means the same thing.
2483
2484 2016-04-30  Darin Adler  <darin@apple.com>
2485
2486         Next batch of conversions to use C++ enum class instead of strings for enumerations
2487         https://bugs.webkit.org/show_bug.cgi?id=157232
2488
2489         Reviewed by Chris Dumez.
2490
2491         * Scripts/webkitpy/style/checker.py: Skip the bindings script tests when doing style
2492         checking. We don't want to waste time trying to make our generated code match our style.
2493
2494 2016-04-29  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2495
2496         Add JSC test results in JSON format to a Buildbot log.
2497         https://bugs.webkit.org/show_bug.cgi?id=156920
2498
2499         Reviewed by Daniel Bates.
2500
2501         Generate JSON results for JSC tests and upload them to the master
2502         using Buildbot's logfiles machinery.
2503
2504         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2505         (RunJavaScriptCoreTests): Use --json-output option when invoking the
2506         run-javascriptcore-tests Perl script, and expose this JSON output as a 
2507         Buildbot log.
2508         * Scripts/run-javascriptcore-tests:
2509         (runJSCStressTests): Change key names and remove redundant count key.
2510
2511 2016-04-29  Joanmarie Diggs  <jdiggs@igalia.com>
2512
2513         [ATK] Expose the value of aria-roledescription via an AtkObject attribute
2514         https://bugs.webkit.org/show_bug.cgi?id=146719
2515
2516         Reviewed by Chris Fleizach.
2517
2518         Implement roleDescription() so that the implementation can be tested.
2519
2520         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
2521         (WTR::AccessibilityUIElement::roleDescription):
2522
2523 2016-04-27  Alexey Proskuryakov  <ap@apple.com>
2524
2525         Don't throttle GuardMalloc on 8-core Macs
2526         https://bugs.webkit.org/show_bug.cgi?id=157108
2527
2528         Reviewed by Alex Christensen.
2529
2530         This was making them slower unnecessarily.
2531
2532         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
2533
2534 2016-04-26  Konstantin Tokarev  <annulen@yandex.ru>
2535
2536         Unreviewed: add myself to the committers list.
2537
2538         * Scripts/webkitpy/common/config/contributors.json:
2539
2540 2016-04-26  Ryosuke Niwa  <rniwa@webkit.org>
2541
2542         Fix text in log files autogenerated by import-w3c-tests
2543         https://bugs.webkit.org/show_bug.cgi?id=157021
2544
2545         Unreviewed. Fixing the second typo.
2546
2547         * Scripts/webkitpy/w3c/test_importer.py:
2548         (TestImporter.write_import_log):
2549
2550 2016-04-26  Filip Pizlo  <fpizlo@apple.com>
2551
2552         WebCore on Mac ignores the user's preferred region (country) while getting the language
2553         https://bugs.webkit.org/show_bug.cgi?id=156993
2554
2555         Reviewed by Geoffrey Garen.
2556
2557         Change the test expectations for this test. If the variant is not explicitly specified in
2558         the AppleLanguage, then we use the locale's country code, which this test assumes is US.
2559
2560         * TestWebKitAPI/Tests/mac/NavigatorLanguage.mm:
2561         (TestWebKitAPI::languageForSystemLanguage):
2562         (TestWebKitAPI::TEST):
2563
2564 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2565
2566         Remove the build flag for template elements
2567         https://bugs.webkit.org/show_bug.cgi?id=157022
2568
2569         Reviewed by Daniel Bates.
2570
2571         Removed the build option.
2572
2573         * Scripts/webkitperl/FeatureList.pm:
2574
2575 2016-04-25  Ryosuke Niwa  <rniwa@webkit.org>
2576
2577         Fix text in log files autogenerated by import-w3c-tests
2578         https://bugs.webkit.org/show_bug.cgi?id=157021
2579
2580         Reviewed by Chris Dumez.
2581
2582         s/Webkit/WebKit/ and end each sentence with a period.
2583
2584         * Scripts/webkitpy/w3c/test_importer.py:
2585         (TestImporter.write_import_log):
2586
2587 2016-04-25  Myles C. Maxfield  <mmaxfield@apple.com>
2588
2589         [Cocoa] Guarantee FontPlatformData's m_cgFont is never nullptr
2590         https://bugs.webkit.org/show_bug.cgi?id=156929
2591
2592         Reviewed by Darin Adler.
2593
2594         * TestWebKitAPI/Tests/mac/StringTruncator.mm:
2595         (TestWebKitAPI::TEST):
2596
2597 2016-04-25  Caitlin Potter  <caitp@igalia.com>
2598
2599         [Tools] whitelist all-uppercase JSTokenType enum in JavaScriptCore
2600         https://bugs.webkit.org/show_bug.cgi?id=156976
2601
2602         Reviewed by Darin Adler.
2603
2604         Mitigate style-checker spam on bugs which introduce new JavaScript
2605         token types.
2606
2607         * Scripts/webkitpy/style/checkers/cpp.py:
2608         (_EnumState.__init__):
2609         (_EnumState.process_clean_line):
2610         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2611         (NoNonVirtualDestructorsTest.test_enum_casing):
2612
2613 2016-04-25  Simon Fraser  <simon.fraser@apple.com>
2614
2615         Fix issues with content-animation performance tests
2616         https://bugs.webkit.org/show_bug.cgi?id=157001
2617
2618         Reviewed by Sam Weinig.
2619
2620         Add patch content for svg-animation.html, and fix the paths in the patch so
2621         it applies correctly.
2622
2623         Add the patch file to the .plan file.
2624
2625         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch:
2626         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2627
2628 2016-04-25  Brady Eidson  <beidson@apple.com>
2629
2630         Tweaking IndexedDB watchlist and adding myself to it.
2631
2632         * Scripts/webkitpy/common/config/watchlist:
2633
2634 2016-04-25  Commit Queue  <commit-queue@webkit.org>
2635
2636         Unreviewed, rolling out r199916.
2637         https://bugs.webkit.org/show_bug.cgi?id=156989
2638
2639         Might break buildbot when master is restarted (Requested by
2640         Srinivasan Vijayaraghava, Guest100, on #webkit).
2641
2642         Reverted changeset:
2643
2644         "Add JSC test results in json format to a buildbot log"
2645         https://bugs.webkit.org/show_bug.cgi?id=156920
2646         http://trac.webkit.org/changeset/199916
2647
2648 2016-04-23  Chris Dumez  <cdumez@apple.com>
2649
2650         [WebIDL] Drop [Default] WebKit-IDL extended attribute
2651         https://bugs.webkit.org/show_bug.cgi?id=156955
2652
2653         Reviewed by Darin Adler.
2654
2655         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2656
2657 2016-04-23  Csaba Osztrogonác  <ossy@webkit.org>
2658
2659         Really enable INDEXED_DATABASE on Apple Mac cmake build
2660         https://bugs.webkit.org/show_bug.cgi?id=156902
2661
2662         Reviewed by Michael Catanzaro.
2663
2664         * Scripts/webkitperl/FeatureList.pm:
2665
2666 2016-04-23  Andy Estes  <aestes@apple.com>
2667
2668         check-webkit-style: fix false-positive warnings about @synchronized
2669         https://bugs.webkit.org/show_bug.cgi?id=156957
2670
2671         Reviewed by Dan Bernstein.
2672
2673         * Scripts/webkitpy/style/checkers/cpp.py:
2674         (check_spacing_for_function_call): Ignore @synchronized lines.
2675         (check_braces): Ditto.
2676         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2677         (CppStyleTest.test_brace_at_begin_of_line): Added a test case.
2678
2679 2016-04-22  Srinivasan Vijayaraghavan  <svijayaraghavan@apple.com>
2680
2681         Add JSC test results in json format to a buildbot log
2682         https://bugs.webkit.org/show_bug.cgi?id=156920
2683
2684         Reviewed by Alexey Proskuryakov.
2685
2686         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2687         (RunJavaScriptCoreTests):
2688         Add runtime flag to output json into buildbot
2689         * Scripts/run-javascriptcore-tests:
2690         (runJSCStressTests):
2691         Change key names and remove redundant count key
2692
2693 2016-04-22  Ryan Haddad  <ryanhaddad@apple.com>
2694
2695         Update expected result for WKPreferencesGetOfflineWebApplicationCacheEnabled after r199854
2696
2697         Unreviewed test gardening.
2698
2699         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2700         (TestWebKitAPI::TEST):
2701
2702 2016-04-22  Carlos Garcia Campos  <cgarcia@igalia.com>
2703
2704         [GTK] Enable the download attribute support
2705         https://bugs.webkit.org/show_bug.cgi?id=99025
2706
2707         Reviewed by Žan Doberšek.
2708
2709         * Scripts/webkitperl/FeatureList.pm:
2710
2711 2016-04-21  Keith Miller  <keith_miller@apple.com>
2712
2713         WebScriptObject description swizzler should work in a multi-threaded world
2714         https://bugs.webkit.org/show_bug.cgi?id=156808
2715
2716         Add a test for our NSObject swizzling TLS implementation. The test runs on
2717         two threads. One in JS and another in Objective-C. We expect the JS thread
2718         to use our NSObject description override and the Objective-C thread to act
2719         as though it was using the original NSObject description method.
2720
2721         Reviewed by Geoffrey Garen.
2722
2723         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2724         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.html: Added.
2725         * TestWebKitAPI/Tests/mac/WebScriptObjectDescription.mm: Added.
2726         (nsObjectDescriptionTest):
2727         (-[WebScriptDescriptionTest webView:didFinishLoadForFrame:]):
2728         (TestWebKitAPI::TEST):
2729
2730 2016-04-21  Carlos Garcia Campos  <cgarcia@igalia.com>
2731
2732         [GTK] WebKitWebView should claim the contents size as its natural size
2733         https://bugs.webkit.org/show_bug.cgi?id=156835
2734
2735         Reviewed by Žan Doberšek.
2736
2737         Add test case to check the WebKitWebView preferred size.
2738
2739         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2740         (testWebViewPreferredSize):
2741         (beforeAll):
2742
2743 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
2744
2745         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
2746         https://bugs.webkit.org/show_bug.cgi?id=156827
2747         
2748         Update the .plan file now that the files are present in SVN.
2749
2750         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
2751
2752 2016-04-20  Simon Fraser  <simon.fraser@apple.com>
2753
2754         Add content animation tests to benchmark_runner, and allow the runner to collect device data as part of the results
2755         https://bugs.webkit.org/show_bug.cgi?id=156827
2756         rdar://problem/24358135
2757
2758         Reviewed by Stephanie Lewis.
2759
2760         Enhance benchmark_runner so that a benchmark can load a set of tests sequentially,
2761         and collate results across them. Also add the ability for the browser_driver to supply
2762         additional results, allowing for tests that collect results data in native code, rather
2763         than generating it in the web page.
2764
2765         Add a set of "content animation" tests that use this new functionality, which test
2766         CSS animation and requestAnimationFrame performance.
2767
2768         'plan' files have two new optional keys:
2769             'test_files': a list of files to run as a suite
2770             'options': optional parameters. Currently supports one new option,
2771                 'animation_command', which affects the way that iOS tests are run,
2772                 and is passed to MobileSafari as a parameter on launch.
2773
2774         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
2775         (BenchmarkRunner.__init__): If options is not specified in the plan file, set it to an empty dictionary.
2776         (BenchmarkRunner._get_result): Allow the browser_driver to modify the test results.
2777         (BenchmarkRunner):
2778         (BenchmarkRunner._run_one_test): Factored out of _run_benchmark, this contains logic for
2779         running a single test. It starts and stops the http_server_driver.
2780         (BenchmarkRunner._run_benchmark): Run a test in the traditional way if the plan has an 'entry_point'
2781         key, otherwise look for the new 'test_files' and load each in a loop.
2782         (BenchmarkRunner._dump):
2783         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
2784         (BrowserDriver.launch_url): Pass options.
2785         (BrowserDriver.add_additional_results): Allow a driver to supply additional results.
2786         (BrowserDriver):
2787         * Scripts/webkitpy/benchmark_runner/browser_driver/gtk_minibrowser_driver.py:
2788         (GTKMiniBrowserDriver.launch_url):
2789         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
2790         (OSXBrowserDriver.close_browsers):
2791         (OSXBrowserDriver._terminate_processes): Fix spelling mistake.
2792         (OSXBrowserDriver._terminiate_processes): Deleted.
2793         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
2794         (OSXChromeDriver.launch_url):
2795         (OSXChromeCanaryDriver.launch_url):
2796         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
2797         (OSXFirefoxDriver.launch_url):
2798         (OSXFirefoxNightlyDriver.launch_url):
2799         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
2800         (OSXSafariDriver.launch_url):
2801         * Scripts/webkitpy/benchmark_runner/data/patches/ContentAnimation.patch: Added.
2802         * Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan: Added.
2803
2804 2016-04-20  Dustin Falgout  <dustin@falgout.us>
2805
2806         [GTK] Expose AllowUniversalAccessFromFileURLs preference now that calling localStorage.getItem() results in SecurityError: DOM Exception 18
2807         https://bugs.webkit.org/show_bug.cgi?id=156651
2808
2809         Reviewed by Michael Catanzaro.
2810
2811         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
2812         (testWebKitSettings):
2813
2814 2016-04-20  Brady Eidson  <beidson@apple.com>
2815
2816         Modern IDB (Workers): Enable INDEXED_DATABASE_IN_WORKERS compile time flag, but disabled in RuntimeEnabledFeatures.
2817         https://bugs.webkit.org/show_bug.cgi?id=156782
2818
2819         Reviewed by Alex Christensen.
2820
2821         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2822
2823 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
2824
2825         Unreviewed build fix after r199752.
2826
2827         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2828         (FrameLoadDelegate::didChangeIcons): Remove call to removed function.
2829
2830 2016-04-19  Brent Fulgham  <bfulgham@apple.com>
2831
2832         Remove remaining bits of dynamic <link> rel='icon' loading
2833         https://bugs.webkit.org/show_bug.cgi?id=156727
2834
2835         Reviewed by Darin Adler.
2836
2837         Remove unused test infrastructure. This code never existed in WebKit2
2838         testing since was only used on Windows.
2839
2840         * DumpRenderTree/TestRunner.cpp:
2841         (dumpIconChangesCallback): Deleted.
2842         * DumpRenderTree/TestRunner.h:
2843         (TestRunner::dumpIconChanges): Deleted.
2844         (TestRunner::setDumpIconChanges): Deleted.
2845
2846 2016-04-19  Keith Miller  <keith_miller@apple.com>
2847
2848         ObjcInstance::stringValue should not call NSObject's description method
2849         https://bugs.webkit.org/show_bug.cgi?id=156758
2850
2851         Reviewed by Geoffrey Garen.
2852
2853         Add new methods to ObjCController that expose two Types of WebScriptObjects. The first is
2854         an NSObject and the second is an NSArray of NSObjects. These are used to test that we don't
2855         call the NSObjects description method without first swizzling it.
2856
2857         * DumpRenderTree/mac/ObjCController.m:
2858         (+[ObjCController isSelectorExcludedFromWebScript:]):
2859         (+[ObjCController webScriptNameForSelector:]):
2860         (-[ObjCController testArrayOfObjects]):
2861         (-[ObjCController testObject]):
2862
2863 2016-04-18  Dan Bernstein  <mitz@apple.com>
2864
2865         Fixed building with old Xcode.
2866
2867         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2868         (TEST):
2869
2870 2016-04-18  Dean Jackson  <dino@apple.com>
2871
2872         New SPI to export a dictionary of runtime features
2873         https://bugs.webkit.org/show_bug.cgi?id=156645
2874         <rdar://problem/23621666>
2875
2876         Reviewed by Darin Adler.
2877
2878         Test the experimental features SPI on WKPreferences.
2879
2880         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
2881
2882 2016-04-18  Yusuke Suzuki  <utatane.tea@gmail.com>
2883
2884         [JSCOnly] Implement RunLoop and remove glib dependency
2885         https://bugs.webkit.org/show_bug.cgi?id=155706
2886
2887         Reviewed by Michael Catanzaro.
2888
2889         Add TestWTF to JSCOnly port to test WorkQueue and RunLoop.
2890         Platform specific ones locate under jsconly directory since
2891         it is not `generic` (Since it includes the GLIB event loop case).
2892
2893         * CMakeLists.txt:
2894         * TestWebKitAPI/PlatformJSCOnly.cmake: Added.
2895         * TestWebKitAPI/PlatformUtilities.h:
2896         * TestWebKitAPI/Tests/WTF/RunLoop.cpp:
2897         (TestWebKitAPI::TEST):
2898         * TestWebKitAPI/config.h:
2899         * TestWebKitAPI/jsconly/PlatformUtilitiesJSCOnly.cpp: Renamed from Source/WTF/wtf/none/RunLoopNone.cpp.
2900         (TestWebKitAPI::Util::run):
2901         (TestWebKitAPI::Util::sleep):
2902         * TestWebKitAPI/jsconly/main.cpp: Renamed from Source/WTF/wtf/none/WorkQueueNone.cpp.
2903         (main):
2904
2905 2016-04-18  Jon Lee  <jonlee@apple.com>
2906
2907         Update Animometer plan.
2908         https://bugs.webkit.org/show_bug.cgi?id=156652
2909
2910         Reviewed by Darin Adler.
2911
2912         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199616.
2913
2914 2016-04-18  Dana Burkart  <dburkart@apple.com>
2915
2916         svn-apply: add option for ignoring changes to ChangeLog files
2917         https://bugs.webkit.org/show_bug.cgi?id=156618
2918
2919         Reviewed by Darin Adler.
2920
2921         This change adds a new option to svn-apply, --skip-changelogs, which short-circuits out of
2922         patch() if the file in question is a ChangeLog.
2923
2924         * Scripts/svn-apply:
2925         (patch):
2926
2927 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2928
2929         Pending API Request URL is wrong after reloading
2930         https://bugs.webkit.org/show_bug.cgi?id=139342
2931
2932         Reviewed by Darin Adler.
2933
2934         Update test case to check that the active URL should remain the
2935         same after a reload.
2936
2937         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp:
2938         (TestWebKitAPI::TEST):
2939
2940 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2941
2942         Pending API request URL no set when loading Data, Alternate HTML or plain text
2943         https://bugs.webkit.org/show_bug.cgi?id=136916
2944
2945         Reviewed by Darin Adler.
2946
2947         Add new test to check that active URL is the requested one right
2948         after calling WKPage load methods.
2949
2950         * TestWebKitAPI/PlatformEfl.cmake:
2951         * TestWebKitAPI/PlatformGTK.cmake:
2952         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2953         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
2954         (TestWebKitAPI::TEST):
2955         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2956         (WebViewTest::loadPlainText): Remove FIXME.
2957         (WebViewTest::loadBytes): Ditto.
2958         (WebViewTest::loadAlternateHTML): Ditto.
2959
2960 2016-04-18  Commit Queue  <commit-queue@webkit.org>
2961
2962         Unreviewed, rolling out r199660.
2963         https://bugs.webkit.org/show_bug.cgi?id=156691
2964
2965         It broke the iOS build (Requested by KaL on #webkit).
2966
2967         Reverted changeset:
2968
2969         "Pending API request URL no set when loading Data, Alternate
2970         HTML or plain text"
2971         https://bugs.webkit.org/show_bug.cgi?id=136916
2972         http://trac.webkit.org/changeset/199660
2973
2974 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
2975
2976         Pending API request URL no set when loading Data, Alternate HTML or plain text
2977         https://bugs.webkit.org/show_bug.cgi?id=136916
2978
2979         Reviewed by Darin Adler.
2980
2981         Add new test to check that active URL is the requested one right
2982         after calling WKPage load methods.
2983
2984         * TestWebKitAPI/PlatformEfl.cmake:
2985         * TestWebKitAPI/PlatformGTK.cmake:
2986         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2987         * TestWebKitAPI/Tests/WebKit2/PendingAPIRequestURL.cpp: Added.
2988         (TestWebKitAPI::TEST):
2989         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2990         (WebViewTest::loadPlainText): Remove FIXME.
2991         (WebViewTest::loadBytes): Ditto.
2992         (WebViewTest::loadAlternateHTML): Ditto.
2993
2994 2016-04-18  Jeremy Huddleston Sequoia  <jeremyhu@apple.com>
2995
2996         Fix incorrect assumption that APPLE implies Mac.
2997         https://bugs.webkit.org/show_bug.cgi?id=156679
2998
2999         Addresses build failure introduced in r198947
3000
3001         Reviewed by Alex Christensen.
3002
3003         * CMakeLists.txt:
3004
3005 2016-04-18  Carlos Garcia Campos  <cgarcia@igalia.com>
3006
3007         [GTK] Test /webkit2/WebKitWebView/mouse-target fails with overlay scrollbars
3008         https://bugs.webkit.org/show_bug.cgi?id=156621
3009
3010         Reviewed by Martin Robinson.
3011
3012         This is a problem of the test itself, we are using an overflow that is not actually scrollable, but that shows
3013         scrollbar troughs when not using overlay scrollbars because it's marked as scrollable. It would be easier to
3014         simply use the main frame scrollbars to test that and it will work no matter of scrollbars are overlay or not.
3015
3016         * TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
3017         (testWebViewMouseTarget): Remove the div and move the mouse over the main frame scrollbar to test scrolbars hit test.
3018
3019 2016-04-17  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
3020
3021         [EFL] Bump gstreamer from 1.4.4 to 1.6.3
3022         https://bugs.webkit.org/show_bug.cgi?id=156655
3023
3024         Reviewed by Antonio Gomes.
3025
3026         To support html5 video feature, we should bump gstreamer version.
3027
3028         * efl/jhbuild.modules:
3029         * efl/patches/gst-libav.patch: Update against newer version.
3030         * efl/patches/gst-plugins-bad-remove-gnustep-support.patch: Removed because this patch was merged.
3031
3032 2016-04-16  Sam Weinig  <sam@webkit.org>
3033
3034         More build fixing.
3035
3036         * MiniBrowser/mac/BrowserWindowController.m:
3037         (-[BrowserWindowController share:]):
3038
3039 2016-04-16  Sam Weinig  <sam@webkit.org>
3040
3041         Another build fix.
3042
3043         * MiniBrowser/mac/BrowserWindowController.m:
3044         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
3045
3046 2016-04-16  Sam Weinig  <sam@webkit.org>
3047
3048         Fix 32-bit build.
3049
3050         * MiniBrowser/mac/BrowserWindowController.m:
3051         (-[BrowserWindowController share:]):
3052         (-[BrowserWindowController fetch:]):
3053         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
3054
3055 2016-04-15  Sam Weinig  <sam@webkit.org>
3056
3057         Add support for NSSharingService to MiniBrowser, for no great reasons
3058         https://bugs.webkit.org/show_bug.cgi?id=156658
3059
3060         Reviewed by Darin Adler.
3061
3062         * MiniBrowser/mac/BrowserWindow.xib:
3063         * MiniBrowser/mac/BrowserWindowController.h:
3064         Add the share button.
3065
3066         * MiniBrowser/mac/BrowserWindowController.m:
3067         (-[BrowserWindowController windowDidLoad]):
3068         Set the share button to fire it's actions on mouse down, as it is supposed to act like a menu.
3069
3070         (-[BrowserWindowController share:]):
3071         Show the picker when the button is pressed.
3072         (-[BrowserWindowController mainContentView]):
3073         Add a new override to get the main content view of derived classes (either a WKWebView or the WebView).
3074
3075         (-[BrowserWindowController sharingServicePicker:sharingServicesForItems:proposedSharingServices:]):
3076         (-[BrowserWindowController sharingServicePicker:delegateForSharingService:]):
3077         (-[BrowserWindowController sharingServicePicker:didChooseSharingService:]):
3078         (-[BrowserWindowController sharingService:sourceFrameOnScreenForShareItem:]):
3079         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
3080         (-[BrowserWindowController sharingService:sourceWindowForShareItems:sharingContentScope:]):
3081         Add delegate methods.
3082
3083         * MiniBrowser/mac/WK1BrowserWindowController.m:
3084         (-[WK1BrowserWindowController mainContentView]):
3085         * MiniBrowser/mac/WK2BrowserWindowController.m:
3086         (-[WK2BrowserWindowController mainContentView]):
3087         Implement to return the web view.
3088
3089 2016-04-16  Alexey Proskuryakov  <ap@apple.com>
3090
3091         Build fix.
3092
3093         Temporary workaround for rdar://problem/25754945.
3094
3095         * LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h:
3096
3097 2016-04-15  Commit Queue  <commit-queue@webkit.org>
3098
3099         Unreviewed, rolling out r199600.
3100         https://bugs.webkit.org/show_bug.cgi?id=156642
3101
3102         It didn't help (Requested by ap_ on #webkit).
3103
3104         Reverted changeset:
3105
3106         "Build fix."
3107         http://trac.webkit.org/changeset/199600
3108
3109 2016-04-15  Alexey Proskuryakov  <ap@apple.com>
3110
3111         Build fix.
3112
3113         * LayoutTestRelay/LayoutTestRelay/main.m: Allow some deprecated methods.
3114
3115 2016-04-14  Alexey Proskuryakov  <ap@apple.com>
3116
3117         Some GuardMalloc bots are not happy when running many parallel processes
3118         https://bugs.webkit.org/show_bug.cgi?id=156614
3119         rdar://problem/24711525
3120
3121         Reviewed by David Kilzer.
3122
3123         * Scripts/webkitpy/port/mac.py: (MacPort.default_child_processes):
3124
3125 2016-04-14  Brent Fulgham  <bfulgham@apple.com>
3126
3127         Make <a download> a runtime enabled option
3128         https://bugs.webkit.org/show_bug.cgi?id=156583
3129         <rdar://problem/25733449>
3130
3131         Reviewed by Alex Christensen.
3132
3133         * DumpRenderTree/mac/DumpRenderTree.mm:
3134         (resetWebPreferencesToConsistentValues):
3135         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3136         (WTR::InjectedBundle::beginTesting):
3137         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3138         (WTR::TestRunner::setDownloadAttributeEnabled):
3139         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3140
3141 2016-04-14  Anders Carlsson  <andersca@apple.com>
3142
3143         Another build fix attempt.
3144
3145         * MiniBrowser/mac/WK2BrowserWindowController.m:
3146
3147 2016-04-14  Anders Carlsson  <andersca@apple.com>
3148
3149         Fix build.
3150
3151         * MiniBrowser/mac/WK2BrowserWindowController.m:
3152         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3153
3154 2016-04-14  Anders Carlsson  <andersca@apple.com>
3155
3156         [Mac] Add API for open panel handling to WKWebView
3157         https://bugs.webkit.org/show_bug.cgi?id=137759
3158         rdar://problem/23278623
3159
3160         Reviewed by Tim Horton.
3161
3162         Have MiniBrowser implement the new delegate method.
3163
3164         * MiniBrowser/mac/WK2BrowserWindowController.m:
3165         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3166
3167 2016-04-14  Jiewen Tan  <jiewen_tan@apple.com>
3168
3169         Unreviewed, rolling out r199554.
3170
3171         The change breaks Yosemite Release/Debug build
3172
3173         Reverted changeset:
3174
3175         "[Mac] Add API for open panel handling to WKWebView"
3176         https://bugs.webkit.org/show_bug.cgi?id=137759
3177         http://trac.webkit.org/changeset/199554
3178
3179 2016-04-14  Anders Carlsson  <andersca@apple.com>
3180
3181         [Mac] Add API for open panel handling to WKWebView
3182         https://bugs.webkit.org/show_bug.cgi?id=137759
3183         rdar://problem/23278623
3184
3185         Reviewed by Tim Horton.
3186
3187         Have MiniBrowser implement the new delegate method.
3188
3189         * MiniBrowser/mac/WK2BrowserWindowController.m:
3190         (-[WK2BrowserWindowController webView:runOpenPanelWithParameters:initiatedByFrame:completionHandler:]):
3191
3192 2016-04-14  Jon Lee  <jonlee@apple.com>
3193
3194         Update Animometer plan
3195         https://bugs.webkit.org/show_bug.cgi?id=156569
3196
3197         Reviewed by Alex Christensen.
3198
3199         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to r199328. Includes update to screen
3200         resolution, starting with complexity of 1, and fixing SVG, multiply, and text tests.
3201
3202 2016-04-13  Alex Christensen  <achristensen@webkit.org>
3203
3204         CMake MiniBrowser should be an app bundle
3205         https://bugs.webkit.org/show_bug.cgi?id=156521
3206
3207         Reviewed by Brent Fulgham.
3208
3209         * MiniBrowser/mac/CMakeLists.txt:
3210         Make an app bundle and compile nibs.
3211         * MiniBrowser/mac/Info.plist:
3212         CMake doesn't know what to do with :rfc1034identifier and there's no reason to keep it.  This is just MiniBrowser.
3213
3214 2016-04-13  Chris Dumez  <cdumez@apple.com>
3215
3216         We should not speculatively revalidate cached redirects
3217         https://bugs.webkit.org/show_bug.cgi?id=156548
3218         <rdar://problem/25583886>
3219
3220         Reviewed by Darin Adler.
3221
3222         Re-enable speculative loading in the context of layout tests. This was
3223         turned off by mistake when speculative loading was turned into a
3224         setting recently.
3225
3226         * WebKitTestRunner/TestController.cpp:
3227         (WTR::TestController::generatePageConfiguration):
3228
3229 2016-04-12  Alexey Proskuryakov  <ap@apple.com>
3230
3231         Python test webkitpy.common.system.executive_unittest.ExecutiveTest.serial_test_kill_process is flaky
3232         https://bugs.webkit.org/show_bug.cgi?id=155367
3233
3234         Reviewed by Darin Adler.
3235
3236         * Scripts/webkitpy/common/system/executive.py: (Executive.kill_process):
3237         Don't flakily consume the return code with waitpid, callers need to do waitpid on
3238         their own. Not sure if this line of code was even intentional.
3239
3240 2016-04-12  Myles C. Maxfield  <mmaxfield@apple.com>
3241
3242         [OS X] Flakey crash after ScrollAnimatorMac destruction
3243         https://bugs.webkit.org/show_bug.cgi?id=156372
3244
3245         Reviewed by Darin Adler.
3246
3247         Implement the new <!-- webkit-test-runner --> flag.
3248
3249         * WebKitTestRunner/TestController.cpp:
3250         (WTR::TestController::createWebViewWithOptions):
3251         (WTR::TestController::ensureViewSupportsOptionsForTest):
3252         (WTR::TestController::resetPreferencesToConsistentValues):
3253         (WTR::TestController::resetStateToConsistentValues):
3254         (WTR::updateTestOptionsFromTestHeader):
3255         * WebKitTestRunner/TestController.h:
3256         * WebKitTestRunner/TestInvocation.cpp:
3257         (WTR::TestInvocation::invoke):
3258         * WebKitTestRunner/TestOptions.h:
3259         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3260         (WKR::PlatformWebView::viewSupportsOptions):
3261
3262 2016-04-12  Tomas Popela  <tpopela@redhat.com>
3263
3264         Modify the CXXFLAGS in webkitdirs.pm just on architectures where the flags are supported
3265         https://bugs.webkit.org/show_bug.cgi?id=156338
3266
3267         Reviewed by Michael Catanzaro.
3268
3269         Add the "-march=pentium4 -msse2 -mfpmath=sse " into the CXXFLAGS just
3270         for the i686 where it is supported and not for other architectures
3271         (such as s390(x) and ppc(64)) where the build will fail with these
3272         CXXFLAGS.
3273
3274         * Scripts/webkitdirs.pm:
3275         (generateBuildSystemFromCMakeProject):
3276
3277 2016-04-11  Alex Christensen  <achristensen@webkit.org>
3278
3279         Build MiniBrowser with CMake on Mac
3280         https://bugs.webkit.org/show_bug.cgi?id=156471
3281
3282         Reviewed by Daniel Bates.
3283
3284         * CMakeLists.txt:
3285         * DumpRenderTree/CMakeLists.txt:
3286         * DumpRenderTree/PlatformWin.cmake:
3287         * MiniBrowser/mac/CMakeLists.txt: Added.
3288
3289 2016-04-11  Ryuan Choi  <ryuan.choi@navercorp.com>
3290
3291         [EFL] Do not pass context to EwkViewCreate
3292         https://bugs.webkit.org/show_bug.cgi?id=156461
3293
3294         Reviewed by Darin Adler.
3295
3296         * TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
3297         (TestWebKitAPI::TEST): Removed context argument from EwkViewCreate calls.
3298         * TestWebKitAPI/efl/PlatformWebView.cpp:
3299         (TestWebKitAPI::PlatformWebView::PlatformWebView): Ditto.
3300         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3301         (WTR::PlatformWebView::PlatformWebView): Ditto.
3302
3303 2016-04-11  Fujii Hironori  <Hironori.Fujii@jp.sony.com>
3304
3305         [CMake] Make FOLDER property INHERITED
3306         https://bugs.webkit.org/show_bug.cgi?id=156460
3307
3308         Reviewed by Brent Fulgham.
3309
3310         * CMakeLists.txt:
3311         * DumpRenderTree/CMakeLists.txt:
3312         * DumpRenderTree/PlatformWin.cmake:
3313         * ImageDiff/CMakeLists.txt:
3314         * MiniBrowser/efl/CMakeLists.txt:
3315         * MiniBrowser/gtk/CMakeLists.txt:
3316         * MiniBrowser/win/CMakeLists.txt:
3317         Set FOLDER property as a directory property not a target property
3318
3319 2016-04-10  Caitlin Potter  <caitp@igalia.com>
3320
3321         [Tools] correctly check for braces in multiline branches in macro definition
3322         https://bugs.webkit.org/show_bug.cgi?id=156441
3323
3324         Reviewed by Darin Adler.
3325
3326         Prevents emitting whitespace/braces warning for code like the
3327         following:
3328
3329         ```
3330         #define MACRO(x) \
3331             if (x) { \
3332                 doTheThing(); \
3333                 continue; \
3334             }
3335         ```
3336
3337         * Scripts/webkitpy/style/checkers/cpp.py:
3338         (check_braces):
3339         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
3340         (WebKitStyleTest.test_line_breaking):
3341
3342 2016-04-08  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3343
3344         Testharness-based tests that time out should be able to produce a detailed output
3345         https://bugs.webkit.org/show_bug.cgi?id=145313
3346
3347         Reviewed by Xabier Rodriguez-Calvar.
3348
3349         Adding timeout readonly accessor to TestRunner for both WK1 and WK2.
3350
3351         * DumpRenderTree/TestRunner.cpp:
3352         (getTimeoutCallback): The js "timeout" property getter.
3353         (TestRunner::staticValues): Adding "timeout" property to DumpRenderTree so that testRunner.timeout called from JS returns the timeout value.
3354         * DumpRenderTree/TestRunner.h:
3355         (TestRunner::timeout): Adding access to DRT m_timeout private value.
3356         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Adding timeout readonly attribute so that testRunner.timeout can be called from JS.
3357         * WebKitTestRunner/InjectedBundle/TestRunner.h: Adding DOM timeout getter to implement timeout IDL definition.
3358         (WTR::TestRunner::timeout):
3359
3360 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
3361
3362         stylebot should know about TestWebKitAPI FeatureDefines.xcconfig
3363         https://bugs.webkit.org/show_bug.cgi?id=156387
3364
3365         Rubber-stamped by Dan Bernstein.
3366
3367         * Scripts/webkitpy/style/checkers/featuredefines.py:
3368         (FeatureDefinesChecker.check):
3369
3370 2016-04-07  Joseph Pecoraro  <pecoraro@apple.com>
3371
3372         Remove ENABLE(ENABLE_ES6_CLASS_SYNTAX) guards
3373         https://bugs.webkit.org/show_bug.cgi?id=156384
3374
3375         Reviewed by Ryosuke Niwa.
3376
3377         * Scripts/webkitperl/FeatureList.pm:
3378         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3379
3380 2016-04-06  Dean Jackson  <dino@apple.com>
3381
3382         Watchlist modifications:
3383         - remove roger_fong
3384         - add myself to a few areas
3385         - remove graouts from WebInspectorAPI
3386
3387         * Scripts/webkitpy/common/config/watchlist:
3388
3389 2016-04-07  Simon Fraser  <simon.fraser@apple.com>
3390
3391         Make it possible to test effect of view exposed rect on tiled backing
3392         https://bugs.webkit.org/show_bug.cgi?id=156365
3393
3394         Reviewed by Tim Horton.
3395
3396         Expose testRunner.setViewSize() and internals.setViewExposedRect() to enable
3397         testing of tile coverage when setViewExposedRect() is passed a non-null rectangle.
3398
3399         testRunner.setViewSize() is used instead of using window.resizeTo(), since we
3400         can't easily resize a window to larger than the screen being tested on.
3401
3402         * DumpRenderTree/TestRunner.cpp:
3403         (setViewSizeCallback):
3404         (TestRunner::staticFunctions):
3405         * DumpRenderTree/TestRunner.h:
3406         * DumpRenderTree/mac/TestRunnerMac.mm:
3407         (TestRunner::setViewSize):
3408         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3409         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3410         (WTR::InjectedBundle::postSetViewSize):
3411         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3412         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3413         (WTR::TestRunner::setViewSize):
3414         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3415         * WebKitTestRunner/TestInvocation.cpp:
3416         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3417
3418 2016-04-07  Jason Marcell  <jmarcell@apple.com>
3419
3420         Adding layout tests for the bot watcher's dashboard QUnit tests.
3421         https://bugs.webkit.org/show_bug.cgi?id=155272
3422
3423         Reviewed by Daniel Bates.
3424
3425         Moved supporting resources into a resources folder and updated index.html accordingly
3426         to point to the new locations. Added code to tests.js to dumpAsText when QUnit is done.
3427
3428         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index-expected.txt: Added.
3429         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/index.html: Updated to point to tests.js and Mock files in resources directory.
3430         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueue.js: Renamed from
3431         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueue.js.
3432         (MockBuildbotQueue):
3433         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbotQueueView.js: Renamed from
3434         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockBuildbotQueueView.js.
3435         (MockBuildbotQueueView):
3436         (MockBuildbotQueueView.prototype._latestProductiveIteration):
3437         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js: Renamed from
3438         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js.
3439         (MockTrac):
3440         (MockTrac.prototype.get oldestRecordedRevisionNumber):
3441         (MockTrac.prototype.get latestRecordedRevisionNumber):
3442         (MockTrac.prototype.loadMoreHistoricalData):
3443         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-git-trac-rss.xml: Renamed from
3444         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml.
3445         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/test-fixture-trac-rss.xml: Renamed from
3446         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-trac-rss.xml.
3447         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js: Renamed from
3448         Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js.
3449         Updated the unit tests for Trac._loaded() to point to the XML files that are now located in the 'resources' directory.
3450         (QUnit.done): Added. Removes machine-specific output from test results and calls testRunner.notifyDone to let the layout test harness know that all testing is done.
3451         * Scripts/run-dashboard-tests: Added.
3452
3453 2016-04-06  ChangSeok Oh  <changseok@webkit.org>
3454
3455         Unreviewed, Update my primary email address and expertise.
3456
3457         * Scripts/webkitpy/common/config/contributors.json:
3458
3459 2016-04-06  Jon Lee  <jonlee@apple.com>
3460
3461         Update the Animometer patch and plan files
3462         https://bugs.webkit.org/show_bug.cgi?id=156263
3463
3464         Reviewed by Ryosuke Niwa.
3465
3466         Measure the latest set of tests by updating the plan revision to r199134.
3467
3468         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Update to run the master suite only.
3469         * Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan: Update to use the release page instead
3470         of the developer page.
3471
3472 2016-04-06  Saam barati  <sbarati@apple.com>
3473
3474         jsc-layout-tests.yaml/js/script-tests/regress-141098.js failing on Yosemite Debug after r198989
3475         https://bugs.webkit.org/show_bug.cgi?id=156187
3476
3477         Reviewed by Keith Miller.
3478
3479         * Scripts/run-jsc-stress-tests:
3480
3481 2016-04-06  Alex Christensen  <achristensen@webkit.org>
3482
3483         Compile WebKitTestRunner with CMake on Mac
3484         https://bugs.webkit.org/show_bug.cgi?id=156310
3485
3486         Reviewed by Daniel Bates.
3487
3488         * CMakeLists.txt:
3489         * WebKitTestRunner/CMakeLists.txt:
3490         * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
3491         * WebKitTestRunner/PlatformEfl.cmake:
3492         * WebKitTestRunner/PlatformGTK.cmake:
3493         * WebKitTestRunner/PlatformMac.cmake: Added.
3494
3495 2016-04-05  Simon Fraser  <simon.fraser@apple.com>
3496
3497         Implement operator== and operator!= for Optional<>
3498         https://bugs.webkit.org/show_bug.cgi?id=156266
3499
3500         Reviewed by Anders Carlsson.
3501
3502         * TestWebKitAPI/Tests/WTF/Optional.cpp:
3503         (TestWebKitAPI::TEST):
3504
3505 2016-04-05  Alex Christensen  <achristensen@webkit.org>
3506
3507         Make CMake-generated binaries on Mac able to run
3508         https://bugs.webkit.org/show_bug.cgi?id=156268
3509
3510         Reviewed by Daniel Bates.
3511
3512         * DumpRenderTree/CMakeLists.txt:
3513         * DumpRenderTree/PlatformMac.cmake:
3514         * DumpRenderTree/PlatformWin.cmake:
3515         * TestWebKitAPI/PlatformMac.cmake:
3516
3517 2016-04-05  Youenn Fablet  <youenn.fablet@crf.canon.fr>
3518
3519         [Fetch API] Add a runtime flag to fetch API and related constructs
3520         https://bugs.webkit.org/show_bug.cgi?id=156113
3521  
3522         Reviewed by Alex Christensen.
3523
3524         * DumpRenderTree/TestRunner.h:
3525         * DumpRenderTree/mac/DumpRenderTree.mm:
3526         (resetWebPreferencesToConsistentValues):
3527         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3528         (WTR::InjectedBundle::beginTesting):
3529         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3530         (WTR::TestRunner::setWebGL2Enabled):
3531         (WTR::TestRunner::setFetchAPIEnabled):
3532         (WTR::TestRunner::setAllowUniversalAccessFromFileURLs):
3533         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3534
3535 2016-04-05  Keith Miller  <keith_miller@apple.com>
3536
3537         Make Keith a reviewer!
3538         https://bugs.webkit.org/show_bug.cgi?id=156246
3539
3540         Reviewed by Mark Lam.
3541
3542         * Scripts/webkitpy/common/config/contributors.json:
3543
3544 2016-04-05  Antoine Quint  <graouts@apple.com>
3545
3546         [WebGL2] Allow enabling WebGL2 with a runtime flag
3547         https://bugs.webkit.org/show_bug.cgi?id=156166
3548         <rdar://problem/25526929>
3549
3550         Always enable WebGL2 during testing.
3551
3552         Reviewed by Dean Jackson.
3553
3554         * DumpRenderTree/mac/DumpRenderTree.mm:
3555         (resetWebPreferencesToConsistentValues):
3556         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3557         (WTR::InjectedBundle::beginTesting):
3558         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3559         (WTR::TestRunner::setWebGL2Enabled):
3560         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3561
3562 2016-04-04  Bill Ming  <mbbill@gmail.com>
3563
3564         [win] run-webkit-tests failed to launch DumpRenderTree
3565         https://bugs.webkit.org/show_bug.cgi?id=156150
3566
3567         Reviewed by Alex Christensen.
3568
3569         * Tools/Scripts/webkitpy/port/base.py:
3570
3571 2016-04-04  Bill Ming  <mbbill@gmail.com>
3572
3573         prepare-ChangeLog set endl incorrectly.
3574         https://bugs.webkit.org/show_bug.cgi?id=156151
3575
3576         Reviewed by Alex Christensen.
3577
3578         * Tools/Scripts/prepare-ChangeLog:
3579
3580 2016-04-03  Sam Weinig  <sam@webkit.org>
3581
3582         Add SPI to allow install script message handlers in isolated worlds
3583         https://bugs.webkit.org/show_bug.cgi?id=156153
3584
3585         Reviewed by Anders Carlsson.
3586
3587         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
3588         Add new test, WKUserContentController.ScriptMessageHandlerBasicPostIsolatedWorld
3589
3590 2016-04-04  Jiewen Tan  <jiewen_tan@apple.com>
3591
3592         Build fix for r198956.
3593
3594         Unreviewed.
3595
3596         * TestWebKitAPI/Tests/WebKit2Cocoa/LoadInvalidURLRequest.mm:
3597         (-[LoadInvalidURLNavigationActionDelegate webView:didFailProvisionalNavigation:withError:]):
3598         * TestWebKitAPI/Tests/mac/LoadInvalidURLRequest.mm:
3599         (-[LoadInvalidURLWebFrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]):
3600
3601 2016-04-04  Bill Ming  <mbbill@gmail.com>
3602
3603         [win] prepare-ChangeLog should treat windows path differently.
3604         https://bugs.webkit.org/show_bug.cgi?id=156120
3605
3606         Reviewed by Brent Fulgham.
3607
3608         * Scripts/prepare-ChangeLog:
3609
3610 2016-04-04  Alejandro G. Castro  <alex@igalia.com>
3611
3612         REGRESSION(r198492): [GTK] The WEB_RTC flag was not correctly added in some situations
3613         https://bugs.webkit.org/show_bug.cgi?id=156164
3614
3615         Reviewed by Philippe Normand.
3616
3617         Enable the new WEB_RTC option by default for Gtk+.
3618
3619         * Scripts/webkitperl/FeatureList.pm:
3620
3621 2016-04-03  Dan Bernstein  <mitz@apple.com>
3622
3623         Use the correct value for the first nightly build with frameworks built for OS X 10.11.
3624
3625         * Scripts/bisect-builds:
3626         (makeNightlyList):
3627
3628 2016-04-03  Dan Bernstein  <mitz@apple.com>
3629
3630         Made bisect-builds work again.
3631
3632         Rubber-stamped by Sam Weinig.
3633
3634         * Scripts/bisect-builds:
3635         Changed to use HTTPS to access nightly.webkit.org, and added a minimum revision for OS X 10.11.
3636
3637 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
3638
3639         Build fix for r198956.
3640
3641         Unreviewed.
3642
3643         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3644         * TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLNotChange.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2Cocoa/ProvisionalURLChange.mm.
3645         (-[ProvisionalURLNotChangeController webView:didFinishNavigation:]):
3646         (-[ProvisionalURLNotChangeController webView:didFailProvisionalNavigation:withError:]):
3647         (TEST):
3648         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
3649         (-[LoadInvalidSchemeDelegate browsingContextController:didFailProvisionalLoadWithError:]):
3650         (TestWebKitAPI::TEST):
3651
3652 2016-04-01  Jiewen Tan  <jiewen_tan@apple.com>
3653
3654         WebKit should dispatchDidFailProvisionalLoad while loading invalid URLs
3655         https://bugs.webkit.org/show_bug.cgi?id=155995
3656         <rdar://problem/14967004>
3657
3658         Reviewed by Andy Estes.
3659
3660         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: