6d3c018f48f08dd1c82cbe62a8f8aa46fe24f906
[WebKit-https.git] / Tools / ChangeLog
1 2012-01-05  Kentaro Hara  <haraken@chromium.org>
2
3         prepare-ChangeLog cannot parse python code that nests classes and defs
4         https://bugs.webkit.org/show_bug.cgi?id=75524
5
6         Reviewed by Ryosuke Niwa.
7
8         This patch fixes the python parser of prepare-ChangeLog so that it can parse
9         python code that nests classes and defs, like this:
10
11         class C:
12             pass
13             def f():
14                 pass
15             pass
16
17         Also, this patch fixes the python parser so that it inserts a dummy line
18         at the end of the file to pop out all popped scopes.
19
20         * Scripts/prepare-ChangeLog:
21         (get_function_line_ranges_for_python):
22
23         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
24         Added test cases that nest classes and defs.
25         (func7):
26         (func7.func8):
27         (func7.func8.func9):
28         (Class2):
29         (Class2.Class3):
30         (Class2.Class3.Class4):
31         (Class5):
32         (Class5.func10):
33         (Class5.func11):
34         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
35
36 2012-01-05  Carlos Garcia Campos  <cgarcia@igalia.com>
37
38         [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
39         https://bugs.webkit.org/show_bug.cgi?id=75433
40
41         Reviewed by Martin Robinson.
42
43         * MiniBrowser/gtk/BrowserWindow.c:
44         (webViewLoadFailed): Reset the progress bar when load fails.
45         (browserWindowConstructed): Connect to load-failed signal.
46
47 2012-01-04  Dan Bernstein  <mitz@apple.com>
48
49         Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
50         start WebProcess under gdb and WebProcess will then run the client executable.
51
52         This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
53
54         Reviewed by Anders Carlsson.
55
56         * Scripts/webkitdirs.pm:
57         (shouldTargetWebProcess): Added.
58         (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
59         (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
60         app using the -client-executable option if targeting the web process.
61
62 2012-01-04  Viatcheslav Ostapenko  <ostapenko.viatcheslav@nokia.com>
63
64         Adding myself to committers list.
65
66         Unreviewed.
67
68         * Scripts/webkitpy/common/config/committers.py:
69
70 2012-01-04  David Kilzer  <ddkilzer@apple.com>
71
72         Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
73
74         This reverts commit r103546.
75
76         * TestWebKitAPI/TestsController.cpp:
77         (TestWebKitAPI::TestsController::TestsController):
78
79 2012-01-04  James Robinson  <jamesr@chromium.org>
80
81         [chromium] Move WebMimeRegistry and dependencies to Source/Platform
82         https://bugs.webkit.org/show_bug.cgi?id=74583
83
84         Reviewed by Darin Fisher.
85
86         Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
87
88         * Scripts/webkitpy/style/checkers/cpp.py:
89         (check_function_definition):
90
91 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
92
93         [Qt] Fix link order of static libraries and unbreak QtWin32
94
95         We were keeping the correct static link order between the intermediate
96         WebKit libraries, but not the internal dependencies for each of those
97         libraries. The load() will in some instances mess with LIBS, so we need
98         to ensure that the dependent libraries are added after the library we
99         are linking against.
100
101         Reviewed by Simon Hausmann.
102
103         * qmake/mkspecs/features/default_post.prf:
104
105 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
106
107         [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
108
109         The custom qmake variable 'WEBKIT' is used for signaling that a
110         target depends in some way on other subproject of the WebKit
111         project. For now this is limited to the set of intermediate
112         libraries: wtf, javascriptcore, webcore, and webkit2.
113
114         This replaces the previous convension of using load(foo) for
115         just include paths, and CONFIG += foo to also link against foo.
116
117         Adding a dependency results in additional include paths being
118         available, and potentially linking to the library. This is
119         decided by the build system based on conditions such as what
120         kind of target is being built and the general build config.
121
122         An advantage to his approach is that it simplifies the individual
123         foo.prf files, for example by allowing us to use INCLUDEPATH +=
124         and LIBS += as normal instead of prepending.
125
126         Reviewed by Simon Hausmann.
127
128         * DumpRenderTree/qt/DumpRenderTree.pro:
129         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
130         * QtTestBrowser/QtTestBrowser.pro:
131         * WebKitTestRunner/InjectedBundle/Target.pri:
132         * WebKitTestRunner/Target.pri:
133         * qmake/README:
134         * qmake/mkspecs/features/default_post.prf:
135         * qmake/mkspecs/features/functions.prf:
136         * qmake/mkspecs/features/javascriptcore.prf:
137         * qmake/mkspecs/features/qtwebkit.prf:
138         * qmake/mkspecs/features/webcore.prf:
139         * qmake/mkspecs/features/webkit2.prf:
140         * qmake/mkspecs/features/wtf.prf:
141
142 2012-01-04  Alexander Færøy  <ahf@0x90.dk>
143
144         [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
145         https://bugs.webkit.org/show_bug.cgi?id=75488
146
147         Reviewed by Tor Arne Vestbø.
148
149         * MiniBrowser/qt/MiniBrowser.qrc:
150         * MiniBrowser/qt/qml/BrowserWindow.qml:
151         * MiniBrowser/qt/qml/Dialog.qml:
152         * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
153         * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
154
155 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
156
157         [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
158
159         It wasn't really a problem at runtime since the right QtWebKit was
160         already loaded as a dependency of the web process, but the ldd output
161         would still be busted.
162
163         Reviewed by Simon Hausmann.
164
165         * WebKitTestRunner/InjectedBundle/Target.pri:
166
167 2012-01-04  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
168
169         [Qt] Move use of $$qtLibraryTarget() to a single place
170
171         Reviewed by Kenneth Rohde Christiansen.
172
173         * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
174         * WebKitTestRunner/InjectedBundle/Target.pri:
175         * qmake/mkspecs/features/default_post.prf:
176         * qmake/mkspecs/features/webcore.prf:
177
178 2012-01-04  Mary Wu  <mary.wu@torchmobile.com.cn>
179
180         Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
181         https://bugs.webkit.org/show_bug.cgi?id=75238
182
183         Reviewed by Antonio Gomes.
184
185         Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that 
186         it could initiate download directly if it has the download attribute in the link 
187         and doesn't need to open new blank page for the target="_blank". Enabling this 
188         feature in the BlackBerry porting also prepares for later blob feature implementation.
189
190         * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
191         for the BlackBerry porting.
192
193 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
194
195         [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
196         https://bugs.webkit.org/show_bug.cgi?id=75475
197
198         Reviewed by Martin Robinson.
199
200         The problem is that the property blurb contains <a ping> and tree
201         view uses gtk_tooltip_set_markup() internally, so we need to
202         escape the text.
203
204         * MiniBrowser/gtk/BrowserSettingsDialog.c:
205         (browserSettingsDialogConstructed): Escape property blurb before
206         storing it in the GtkTreeModel.
207
208 2012-01-03  Jochen Eisinger  <jochen@chromium.org>
209
210         When showing results.html pass a correct URL to webbrowser.open
211         https://bugs.webkit.org/show_bug.cgi?id=75438
212
213         Reviewed by Adam Barth.
214
215         * Scripts/webkitpy/common/system/filesystem.py:
216         (file_path_as_url):
217         * Scripts/webkitpy/common/system/filesystem_mock.py:
218         (file_path_as_url):
219         * Scripts/webkitpy/common/system/filesystem_unittest.py:
220         (test_file_path_as_url):
221         * Scripts/webkitpy/layout_tests/port/base.py:
222         (show_results_html_file):
223         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
224         (test_show_results_html_file):
225         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
226         (test_results_directory_relative):
227
228 2012-01-03  Ojan Vafai  <ojan@chromium.org>
229
230         shrink the header on the flakiness dashboard
231         https://bugs.webkit.org/show_bug.cgi?id=65153
232
233         Reviewed by Adam Roben.
234
235         Move some of the "show" links to be to the right of the header
236         instead of below the header when they content they're showing
237         is hidden. That way we don't waste vertical space on them.
238
239         No new tests. This code is covered by existing tests.
240
241         * TestResultServer/static-dashboards/flakiness_dashboard.html:
242
243 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
244
245         Add a tool to analyze change logs
246         https://bugs.webkit.org/show_bug.cgi?id=72243
247
248         Reviewed by Eric Seidel.
249
250         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
251         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
252         for visualizing json files.
253
254         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
255         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
256         generates json files, and N is the number of changelogs to parse.
257
258         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
259         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
260         * Scripts/webkitpy/tool/commands/__init__.py:
261         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
262         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
263         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
264         * Scripts/webkitpy/tool/steps/options.py:
265
266 2012-01-03  Ryosuke Niwa  <rniwa@webkit.org>
267
268         Add a tool to analyze change logs
269         https://bugs.webkit.org/show_bug.cgi?id=72243
270
271         Reviewed by Eric Seidel.
272
273         Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
274         in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
275         for visualizing json files.
276
277         Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
278         where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
279         generates json files, and N is the number of changelogs to parse.
280
281         * Scripts/webkitpy/common/config/contributionareas.py: Added names().
282         * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
283         * Scripts/webkitpy/tool/commands/__init__.py:
284         * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
285         * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
286         * Scripts/webkitpy/tool/commands/data/summary.html: Added.
287         * Scripts/webkitpy/tool/steps/options.py:
288
289 2012-01-03  Adam Roben  <aroben@apple.com>
290
291         Make Port subclasses override the operating_system method rather than setting an attribute
292
293         Without this patch, any use of Port.operating_system() within a port's __init__ method would
294         return the default value ("mac"). This was confusing the version-checking logic inside
295         ApplePort.__init__ on Windows.
296
297         Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
298         crashes on launch on Windows 7 SP1
299
300         Reviewed by Eric Seidel.
301
302         * Scripts/webkitpy/layout_tests/port/apple.py:
303         (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
304
305         * Scripts/webkitpy/layout_tests/port/base.py:
306         (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
307         should now override the operating_system method instead.
308         (Port.operating_system): Changed to always return "mac". Subclasses should override to
309         return something else.
310
311         * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
312         (ChromiumLinuxPort.__init__):
313         (ChromiumLinuxPort.operating_system):
314         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
315         (ChromiumMacPort.__init__):
316         (ChromiumMacPort.operating_system):
317         * Scripts/webkitpy/layout_tests/port/chromium_win.py:
318         (ChromiumWinPort.__init__):
319         (ChromiumWinPort.operating_system):
320         * Scripts/webkitpy/layout_tests/port/mac.py:
321         (MacPort.__init__):
322         (MacPort.operating_system):
323         * Scripts/webkitpy/layout_tests/port/win.py:
324         (WinPort.__init__):
325         (WinPort.operating_system):
326         Changed to override the operating_system method rather than setting the _operating_system
327         attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
328
329         * Scripts/webkitpy/layout_tests/port/qt.py:
330         (QtPort.__init__):
331         (QtPort._path_to_webcore_library):
332         Changed to use self.operating_system() instead of self._operating_system, for consistency
333         with other Port-related code.
334
335         (QtPort.operating_system): Added this override of Port.operating_system that returns the
336         value we determined in our __init__ method.
337
338         * Scripts/webkitpy/layout_tests/port/test.py:
339         (TestPort.operating_system): Added this override of Port.operating_system that returns the
340         value we determined in our __init__ method.
341
342         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
343         (PortTest.test_operating_system):
344         * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
345         (ChromiumLinuxPortTest.test_operating_system):
346         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
347         (ChromiumMacPortTest.test_operating_system):
348         * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
349         (ChromiumWinPortTest.test_operating_system):
350         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
351         (MacPortTest.test_operating_system):
352         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
353         (QtPortTest.test_operating_system):
354         * Scripts/webkitpy/layout_tests/port/win_unittest.py:
355         (WinPortTest.test_operating_system):
356         Test that all ports return the expected operating system string.
357
358 2012-01-03  Mario Sanchez Prada  <msanchez@igalia.com>
359
360         [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
361         https://bugs.webkit.org/show_bug.cgi?id=75474
362
363         Reviewed by Philippe Normand.
364
365         * Scripts/run-gtk-tests: Ignore files whose name does not start
366         with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
367
368 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
369
370         [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
371         https://bugs.webkit.org/show_bug.cgi?id=75472
372
373         Reviewed by Tor Arne Vestbø.
374
375         * MiniBrowser/qt/MiniBrowser.pro:
376         * MiniBrowser/qt/MiniBrowser.qrc:
377         * MiniBrowser/qt/qml/BrowserWindow.qml:
378         * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
379
380 2012-01-03  Alexander Færøy  <alexander.faeroy@nokia.com>
381
382         [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
383         https://bugs.webkit.org/show_bug.cgi?id=75471
384
385         Reviewed by Tor Arne Vestbø.
386
387         Add simple UI for JavaScript Alert dialogs. This patch also adds a
388         simple DialogButton QML type and a Dialog QML type which will be
389         reusable for other JavaScript dialogs.
390
391         * MiniBrowser/qt/MiniBrowser.qrc:
392         * MiniBrowser/qt/qml/AlertDialog.qml: Added.
393         * MiniBrowser/qt/qml/BrowserWindow.qml:
394         * MiniBrowser/qt/qml/Dialog.qml: Added.
395         * MiniBrowser/qt/qml/DialogButton.qml: Added.
396
397 2012-01-03  Rafael Brandao  <rafael.lobo@openbossa.org>
398
399         [Qt][WK2] MiniBrowser doesn't show url bar
400         https://bugs.webkit.org/show_bug.cgi?id=75470
401
402         Reviewed by Tor Arne Vestbø.
403
404         * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
405         on QtDeclarative (QTBUG-23422).
406
407 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
408
409         [GTK] Simplify loader client WebKit2 GTK+ API
410         https://bugs.webkit.org/show_bug.cgi?id=74605
411
412         Reviewed by Gustavo Noronha Silva.
413
414         * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
415         private API.
416
417 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
418
419         [Qt] Clean up detection of fontconfig
420
421         We decide in features.prf whether or not fontconfig is available, and
422         set the HAVE_FONTCONFIG define accordingly. All leaf project files
423         should use this define to decide whether or not to link against
424         fontconfig, not do their own detection.
425
426         We don't need to add link_pkgconfig to CONFIG in each project file,
427         as we selectivly enable that configuration in defaults_post when
428         needed.
429
430         Reviewed by Ossy.
431
432         * DumpRenderTree/qt/DumpRenderTree.pro:
433         * QtTestBrowser/QtTestBrowser.pro:
434         * WebKitTestRunner/InjectedBundle/Target.pri:
435         * qmake/mkspecs/features/unix/default_post.prf:
436         * qmake/mkspecs/features/unix/default_pre.prf:
437
438 2012-01-03  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
439
440         [Qt] Introduce qmake replace function for the active build config
441
442         Reviewed by Ossy.
443
444         * qmake/mkspecs/features/default_post.prf:
445         * qmake/mkspecs/features/functions.prf:
446
447 2012-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
448
449         [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
450         https://bugs.webkit.org/show_bug.cgi?id=75435
451
452         Reviewed by Martin Robinson.
453
454         * GNUmakefile.am: Make sure DRT links to X11.
455         * WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
456
457 2011-12-04  Philippe Normand  <pnormand@igalia.com>
458
459         [WK2][GTK] WebSettings support in MiniBrowser
460         https://bugs.webkit.org/show_bug.cgi?id=73773
461
462         Reviewed by Martin Robinson.
463
464         Patch heavily inspired from the WebKit GtkLauncher to support
465         command-line WebSettings. Example: --enable-fullscreen=TRUE.
466         The full list of options can be consulted with --help-websettings.
467
468         * MiniBrowser/gtk/main.c:
469         (loadURI):
470         (parseOptionEntryCallback):
471         (isValidParameterType):
472         (getOptionEntriesFromWebKitSettings):
473         (addSettingsGroupToContext):
474         (main):
475
476 2012-01-02  Philippe Normand  <pnormand@igalia.com>
477
478         [GTK] GtkLauncher settings improvements
479         https://bugs.webkit.org/show_bug.cgi?id=75439
480
481         Reviewed by Martin Robinson.
482
483         * GtkLauncher/main.c:
484         (filenameToURL): We can use NULL in C.
485         (isValidParameterType): Utility function to filter GParamTypes
486         that can be edited.
487         (getOptionEntriesFromWebKitWebSettings): Avoid handling
488         construct-only properties and use the isValidParameterType
489         function. Makes the code a bit cleaner.
490
491 2012-01-02  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
492
493         [EFL] Remove whitespace/declaration style exception
494         https://bugs.webkit.org/show_bug.cgi?id=75424
495
496         Reviewed by David Levin.
497
498         Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
499         application. So, they still need to use EFL coding style.
500
501         * Scripts/webkitpy/style/checker.py:
502
503 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
504
505         [GTK] Add a way to change web view settings in MiniBrowser
506         https://bugs.webkit.org/show_bug.cgi?id=71568
507
508         Reviewed by Philippe Normand.
509
510         Add a preferences button to the toolbar that shows a dialog to
511         change settings of the current web view. It uses a GtkTreeView
512         with a custom cell renderer to support multiple types of values.
513
514         * MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.
515         (browserCellRendererVariantFinalize):
516         (browserCellRendererVariantGetProperty):
517         (browserCellRendererVariantSetModeForValue):
518         (browserCellRendererVariantSetProperty):
519         (browserCellRendererVariantGetRendererForValue):
520         (browserCellRendererVariantCellRendererTextEdited):
521         (browserCellRendererVariantCellRendererSpinEdited):
522         (browserCellRendererVariantCellRendererActivate):
523         (browserCellRendererVariantCellRendererRender):
524         (browserCellRendererVariantCellRendererStartEditing):
525         (browserCellRendererVariantCellRendererGetPreferredWidth):
526         (browserCellRendererVariantCellRendererGetPreferredHeight):
527         (browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
528         (browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
529         (browserCellRendererVariantCellRendererGetAlignedArea):
530         (browser_cell_renderer_variant_init):
531         (browser_cell_renderer_variant_class_init):
532         (browser_cell_renderer_variant_new):
533         * MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
534         * MiniBrowser/gtk/BrowserSettingsDialog.c: Added.
535         (cellRendererChanged):
536         (browserSettingsDialogSetProperty):
537         (browser_settings_dialog_init):
538         (browserSettingsDialogConstructed):
539         (browser_settings_dialog_class_init):
540         (browser_settings_dialog_new):
541         * MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
542         * MiniBrowser/gtk/BrowserWindow.c:
543         (settingsCallback):
544         (browser_window_init):
545         * MiniBrowser/gtk/GNUmakefile.am:
546         * MiniBrowser/gtk/browser-marshal.list: Added.
547
548 2012-01-02  Carlos Garcia Campos  <cgarcia@igalia.com>
549
550         [GTK] Implement create/ready-to-show/close signals in MiniBrowser
551         https://bugs.webkit.org/show_bug.cgi?id=74711
552
553         Reviewed by Philippe Normand.
554
555         * MiniBrowser/gtk/BrowserWindow.c:
556         (webViewClose): Destroy the window.
557         (webViewReadyToShow): Use WindowProperties of the new view to
558         setup and show the window.
559         (webViewCreate): Create a new view and add it to a browser window.
560         (browser_window_init):
561         (browserWindowConstructed): Connect to WebKitWebView::create signal.
562
563 2011-12-31  Dan Bernstein  <mitz@apple.com>
564
565         MiniBrowser sets the WKView’s frame incorrectly
566         https://bugs.webkit.org/show_bug.cgi?id=75393
567
568         Reviewed by Anders Carlsson.
569
570         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,
571         which is not needed since the binray is linked with the frameworks search path set to the
572         built products directory.
573         * MiniBrowser/mac/BrowserWindowController.m:
574         (-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
575         container’s bounds rather than its frame.
576         * MiniBrowser/mac/make-launchable.sh: Removed.
577
578 2011-12-29  Dan Bernstein  <mitz@apple.com>
579
580         debug-safari --no-saved-state fails to start the debugger
581         https://bugs.webkit.org/show_bug.cgi?id=75374
582
583         Reviewed by Sam Weinig.
584
585         * Scripts/webkitdirs.pm:
586         (execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
587         the executable being debugged.
588
589 2011-12-29  Sam Weinig  <sam@webkit.org>
590
591         It should be easier to iterate a Vector backwards
592         https://bugs.webkit.org/show_bug.cgi?id=75359
593
594         Reviewed by Anders Carlsson.
595
596         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
597         * TestWebKitAPI/TestWebKitAPI.gypi:
598         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
599         Add new Vector test.
600
601         * TestWebKitAPI/Tests/Vector.cpp: Added.
602         (TestWebKitAPI::TEST):
603         Test Vector iterators, reverse_iterators and new reversed proxy.
604
605 2011-12-28  Dmitry Lomov  <dslomov@google.com>
606
607         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
608         https://bugs.webkit.org/show_bug.cgi?id=66509
609         Just renames, merges and removal of dead code. Here are the list of renames:
610           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
611           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
612           - WebWorkerBase merged into WebSharedWorkerImpl
613           - NewWebWorkerBase renamed into WebWorkerBase
614  
615         Reviewed by David Levin.
616
617         * DumpRenderTree/chromium/TestWebWorker.h:
618         (TestWebWorker::createWorker):
619         * DumpRenderTree/chromium/WebViewHost.cpp:
620         (WebViewHost::createWorker):
621         * DumpRenderTree/chromium/WebViewHost.h:
622
623 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
624
625         Unreviewed, rolling out r103785.
626         http://trac.webkit.org/changeset/103785
627         https://bugs.webkit.org/show_bug.cgi?id=75332
628
629         Broke builders; looks like clobbering didnt help (Requested by
630         dslomov on #webkit).
631
632         * DumpRenderTree/chromium/TestWebWorker.h:
633         (TestWebWorker::createWorker):
634         * DumpRenderTree/chromium/WebViewHost.cpp:
635         (WebViewHost::createWorker):
636         * DumpRenderTree/chromium/WebViewHost.h:
637
638 2011-12-28  Dmitry Lomov  <dslomov@google.com>
639
640
641         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
642         https://bugs.webkit.org/show_bug.cgi?id=66509
643         Just renames, merges and removal of dead code. Here are the list of renames:
644           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
645           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
646           - WebWorkerBase merged into WebSharedWorkerImpl
647           - NewWebWorkerBase renamed into WebWorkerBase
648  
649         Reviewed by David Levin.
650
651         * DumpRenderTree/chromium/TestWebWorker.h:
652         (TestWebWorker::createWorker):
653         * DumpRenderTree/chromium/WebViewHost.cpp:
654         (WebViewHost::createWorker):
655         * DumpRenderTree/chromium/WebViewHost.h:
656
657 2011-12-28  Sheriff Bot  <webkit.review.bot@gmail.com>
658
659         Unreviewed, rolling out r103620.
660         http://trac.webkit.org/changeset/103620
661         https://bugs.webkit.org/show_bug.cgi?id=75316
662
663         Causes many crashes (Requested by abarth on #webkit).
664
665         * DumpRenderTree/chromium/LayoutTestController.cpp:
666         (LayoutTestController::LayoutTestController):
667         (LayoutTestController::reset):
668         * DumpRenderTree/chromium/LayoutTestController.h:
669         * DumpRenderTree/chromium/WebViewHost.cpp:
670         * DumpRenderTree/chromium/WebViewHost.h:
671
672 2011-12-27  Sheriff Bot  <webkit.review.bot@gmail.com>
673
674         Unreviewed, rolling out r103734.
675         http://trac.webkit.org/changeset/103734
676         https://bugs.webkit.org/show_bug.cgi?id=75278
677
678         Broke cr-mac (Requested by dslomov on #webkit).
679
680         * DumpRenderTree/chromium/TestWebWorker.h:
681         (TestWebWorker::createWorker):
682         * DumpRenderTree/chromium/WebViewHost.cpp:
683         (WebViewHost::createWorker):
684         * DumpRenderTree/chromium/WebViewHost.h:
685
686 2011-12-27  Dmitry Lomov  <dslomov@google.com>
687
688
689         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
690         https://bugs.webkit.org/show_bug.cgi?id=66509
691         Just renames, merges and removal of dead code. Here are the list of renames:
692           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
693           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
694           - WebWorkerBase merged into WebSharedWorkerImpl
695           - NewWebWorkerBase renamed into WebWorkerBase
696  
697         Reviewed by David Levin.
698
699         * DumpRenderTree/chromium/TestWebWorker.h:
700         (TestWebWorker::createWorker):
701         * DumpRenderTree/chromium/WebViewHost.cpp:
702         (WebViewHost::createWorker):
703         * DumpRenderTree/chromium/WebViewHost.h:
704
705 2011-12-27  Anders Carlsson  <andersca@apple.com>
706
707         Function should handle wrapping/unwrapping RefPtr and PassRefPtr
708         https://bugs.webkit.org/show_bug.cgi?id=75266
709
710         Reviewed by Sam Weinig.
711
712         * TestWebKitAPI/Tests/WTF/Functional.cpp:
713         (TestWebKitAPI::Number::create):
714         (TestWebKitAPI::Number::~Number):
715         (TestWebKitAPI::Number::value):
716         (TestWebKitAPI::Number::Number):
717         (TestWebKitAPI::multiplyNumberByTwo):
718         (TestWebKitAPI::TEST):
719
720 2011-12-24  Kentaro Hara  <haraken@chromium.org>
721
722         Add unittests for the C++ parser of prepare-ChangeLog
723         https://bugs.webkit.org/show_bug.cgi?id=75191
724
725         Reviewed by Ryosuke Niwa.
726
727         cpp_unittests.cpp is the unittests for get_function_line_ranges_for_cpp()
728         of prepare-ChangeLog.
729
730         * Scripts/prepare-ChangeLog:
731         (get_function_line_ranges): Renames get_function_line_ranges_for_c()
732         to get_function_line_ranges_for_cpp().
733         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
734         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Added.
735         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added.
736         (func1):
737         (func2):
738         (func3):
739         (func4):
740         (func5):
741         (func6):
742         (func7):
743         (func8):
744         (func9):
745         (func10):
746         (func11):
747         (func12):
748         (func13):
749         (func14):
750         (func15):
751         (funcOverloaded):
752         (Class::func16):
753         (Class1::Class2::func17):
754         (Class2::func18):
755         (Class2::func19):
756         (Class2::func20):
757         (Class2::func21):
758         (Class2::func22):
759         (func23):
760         (func24):
761         (Class2::func25):
762         (Class1::func26):
763         (Class2::func27):
764         (Class3::func28):
765         (Class7::operator+):
766         (Class100::Class100):
767         (Class101::~Class101):
768         (Class102::Class102):
769         (Class103::Class103):
770         (Struct1::func29):
771         (Struct2::func30):
772         (NameSpace1::func30):
773         (NameSpace1::NameSpace2::func31):
774
775 2011-12-24  Kentaro Hara  <haraken@chromium.org>
776
777         Add unittests for the Java parser of prepare-ChangeLog
778         https://bugs.webkit.org/show_bug.cgi?id=75195
779
780         Reviewed by Ryosuke Niwa.
781
782         java_unittests.java is unittest cases for get_function_line_ranges_for_java()
783         of prepare-ChangeLog.
784
785         * Scripts/prepare-ChangeLog:
786         (get_function_line_ranges_for_java): Fixed a parser bug.
787
788             interface I
789             {
790                 void f()
791                 {
792                 }
793             }
794
795         should be recognized as "I.f", and
796
797             class C interface I
798             {
799                 void f()
800                 {
801                 }
802             }
803
804         should be recognized as "C.f".
805         Without this patch, both are recognized as "I.f".
806
807         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
808         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Added.
809         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests.java: Added.
810         (Simple):
811         (Simple.func1):
812         (Simple.func2):
813         (Simple.func3):
814         (Simple.func4):
815         (Simple.func5):
816         (Simple.func6):
817         (Simple.func7):
818         (Simple.func8):
819         (Simple.func9):
820         (Simple.func10):
821         (Simple.funcOverloaded):
822         (Simple.func11):
823         (Simple.func12):
824         (Simple.func13):
825         (Simple.func14):
826         (Simple.func15):
827         (Simple.func16):
828         (Simple.func17):
829         (Simple.func18):
830         (Simple.func19):
831         (Simple.func20):
832         (Simple.func21):
833         (Derived1):
834         (Derived1.Derived1):
835         (Derived1.func22):
836         (Interface1):
837         (Interface2):
838         (Interface2.func23):
839         (Derived2):
840         (Derived2.Derived2):
841         (Derived2.func23):
842
843 2011-12-24  Kentaro Hara  <haraken@chromium.org>
844
845         Add unittests for the Python parser of prepare-ChangeLog
846         https://bugs.webkit.org/show_bug.cgi?id=75197
847
848         Reviewed by Ryosuke Niwa.
849
850         python_unittests.py is the unittest for get_function_line_ranges_for_python()
851         of prepare-ChangeLog. The unittest just contains classes and defs that are not nested.
852         This is because the current python parser is wrong, and it cannot correctly parse nested
853         classes and defs (even one def in a class), nor class inheritance.
854         We will fix it in another patch.
855
856         * Scripts/prepare-ChangeLog:
857         (get_function_line_ranges_for_python): Ignores comment lines that starts from #.
858         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
859         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Added.
860         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py: Added.
861         (func1):
862         (func2):
863         (func3):
864         (funcInsideComment):
865         (func4):
866         (func5):
867         (func6):
868         (funcOverloaded):
869         (Class1):
870
871 2011-12-24  Dan Bernstein  <mitz@apple.com>
872
873         Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.
874
875         Reviewed by Anders Carlsson.
876
877         * Scripts/webkitdirs.pm:
878         (determineBaseProductDir):
879
880 2011-12-24  Dan Bernstein  <mitz@apple.com>
881
882         Make build-webkit aware of additional Xcode build location defaults.
883
884         Reviewed by Anders Carlsson.
885
886         * Scripts/webkitdirs.pm:
887         (determineXcodeVersion): Added. This was previously in determineBaseProductDir().
888         (readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
889         (determineBaseProductDir): Changed to check for a custom build location
890         style specified as an absolute location.
891
892 2011-12-24  Ryosuke Niwa  <rniwa@webkit.org>
893
894         Unreviewed, rolling out r103619.
895         http://trac.webkit.org/changeset/103619
896         https://bugs.webkit.org/show_bug.cgi?id=66509
897
898         Broke chromium clang build
899
900         * DumpRenderTree/chromium/TestWebWorker.h:
901         (TestWebWorker::createWorker):
902         * DumpRenderTree/chromium/WebViewHost.cpp:
903         (WebViewHost::createWorker):
904         * DumpRenderTree/chromium/WebViewHost.h:
905
906 2011-12-23  Daniel Bates  <dbates@webkit.org>
907
908         Provide option to disable Mac OS 10.7 application resume when using
909         {debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
910         https://bugs.webkit.org/show_bug.cgi?id=66902
911
912         Reviewed by David Kilzer.
913
914         Add an optional command line argument --no-saved-state to disable
915         application resume (state restoration) for the session on Mac OS 10.7.
916
917         For instance, when debugging an issue in Safari it is useful to be able
918         to temporarily disable application resume. Currently you can disable
919         application resume when launching Safari from within Xcode. We should
920         expose a similar option in our command line tools.
921
922         * Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()
923         to print a help message and exit() if the command line argument --help was given.
924         * Scripts/debug-safari: Ditto.
925         * Scripts/debug-test-runner: Ditto.
926         * Scripts/run-minibrowser: Ditto.
927         * Scripts/run-safari: Ditto.
928         * Scripts/run-test-runner: Ditto.
929         * Scripts/run-test-webkit-api: Ditto.
930         * Scripts/run-webkit-app: Ditto.
931         * Scripts/webkitdirs.pm:
932         (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
933         (argumentsForRunAndDebugMacWebKitApp): Added.
934         (runMacWebKitApp): If the --no-saved-state command line argument was given then
935         disable application resume for the session.
936         (execMacWebKitAppForDebugging): Ditto.
937
938 2011-12-23  Dmitry Lomov  <dslomov@google.com>
939
940         [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
941         https://bugs.webkit.org/show_bug.cgi?id=66509
942         Just renames, merges and removal of dead code. Here are the list of renames:
943           - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
944           - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
945           - WebWorkerBase merged into WebSharedWorkerImpl
946           - NewWebWorkerBase renamed into WebWorkerBase
947  
948         Reviewed by David Levin.
949
950         * DumpRenderTree/chromium/TestWebWorker.h:
951         (TestWebWorker::createWorker):
952         * DumpRenderTree/chromium/WebViewHost.cpp:
953         (WebViewHost::createWorker):
954         * DumpRenderTree/chromium/WebViewHost.h:
955
956 2011-12-23  Kentaro Hara  <haraken@chromium.org>
957
958         Let parser_unittests.pl call different language parsers
959         https://bugs.webkit.org/show_bug.cgi?id=75081
960
961         Reviewed by David Kilzer.
962
963         We introduced parser_unittests.pl in bug 74994 , but it is implemented
964         to always call get_function_line_ranges_for_perl(). In order to enable unittests
965         for other languages, this patch lets parser_unittests.pl call different language
966         parsers depending on the languages.
967
968         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
969
970         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
971
972 2011-12-22  Adam Roben  <aroben@apple.com>
973
974         Snow Leopard test fix
975
976         * Scripts/webkitpy/test/main.py:
977         (Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to
978         unittest.main, even though that's the default. So now we explicitly specify a
979         TextTestRunner.
980
981 2011-12-22  Chris Fleizach  <cfleizach@apple.com>
982
983         AX: attributed strings do not include AXHeading information when a link is contained within the heading
984         https://bugs.webkit.org/show_bug.cgi?id=75059
985
986         Reviewed by Darin Adler.
987
988         Support the ability to check if an arbitrary attribute is present within an
989         attributed string that can be retrieved through an AccessibilityTextMarkerRange.
990
991         * DumpRenderTree/AccessibilityUIElement.cpp:
992         (attributedStringForTextMarkerRangeContainsAttributeCallback):
993         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
994         (AccessibilityUIElement::getJSClass):
995         * DumpRenderTree/AccessibilityUIElement.h:
996         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
997         (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
998         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
999         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1000         * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
1001         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
1002         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
1003         (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
1004
1005 2011-12-22  David Kilzer  <ddkilzer@apple.com>
1006
1007         run-api-tests: runAllTests() and runTest() should not use global variables
1008
1009         Reviewed by Adam Roben.
1010
1011         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1012
1013         * Scripts/run-api-tests:
1014         (runTestsBySuite): Rename from runAllTests().  Add arguments for
1015         list of tests and $verbose.
1016         (runTest): Add $verbose argument.
1017
1018 2011-12-22  David Kilzer  <ddkilzer@apple.com>
1019
1020         run-api-tests: inline runAllTestsInSuite() into runAllTests()
1021
1022         Reviewed by Adam Roben.
1023
1024         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1025
1026         In order to make it easy to run one or more individual suites,
1027         or one more individual tests, it's easier to call a single
1028         method with different data structures than individual methods.
1029
1030         * Scripts/run-api-tests:
1031         (runAllTests): Inline runAllTestsInSuite().
1032
1033 2011-12-22  Adam Roben  <aroben@apple.com>
1034
1035         Add a --xml flag to test-webkitpy
1036
1037         test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
1038         JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
1039         This is useful for working with tools that consume JUnit-style XML files.
1040
1041         Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
1042         running test-webkitpy
1043
1044         Reviewed by Darin Adler.
1045
1046         * Scripts/webkitpy/test/main.py:
1047         (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
1048         unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
1049
1050         * Scripts/webkitpy/thirdparty/__init__.py:
1051         (AutoinstallImportHook.find_module):
1052         (AutoinstallImportHook._install_xmlrunner):
1053         Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
1054         This change is untested because it's basically impossible to get a test to pass when --xml
1055         is passed to test-webkitpy (because xmlrunner will already have been imported by the time
1056         the test runs).
1057
1058 2011-12-22  David Kilzer  <ddkilzer@apple.com>
1059
1060         TestWebKitAPI: initialize the main thread before running tests
1061         <http://webkit.org/b/75064>
1062
1063         Reviewed by Adam Roben.
1064
1065         * TestWebKitAPI/TestsController.cpp:
1066         (TestWebKitAPI::TestsController::TestsController): Call
1067         WTF::initializeMainThread() to prevent assertions in Debug
1068         builds.
1069
1070 2011-12-22  David Kilzer  <ddkilzer@apple.com>
1071
1072         run-api-tests: dumpAllTests() should not use global variables
1073
1074         Reviewed by Adam Roben.
1075
1076         Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
1077
1078         * Scripts/run-api-tests: Renamed $dump to $dumpTests.
1079         (dumpTestsBySuite): Rename from dumpAllTests() and pass in
1080         global data as an argument.  Sort suite names and test names
1081         alphabetically to match output when running tests.
1082
1083 2011-12-22  Leo Yang  <leo.yang@torchmobile.com.cn>
1084
1085         [BlackBerry] Enable blob for the BlackBerry porting
1086         https://bugs.webkit.org/show_bug.cgi?id=75074
1087
1088         Reviewed by George Staikos.
1089
1090         * Scripts/build-webkit:
1091
1092 2011-12-22  Kentaro Hara  <haraken@chromium.org>
1093
1094         Add unittests for the Perl parser of prepare-ChangeLog
1095         https://bugs.webkit.org/show_bug.cgi?id=74994
1096
1097         Reviewed by David Kilzer.
1098
1099         This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
1100
1101         Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
1102
1103         * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
1104         Runs unittests specified in @testFiles.
1105         You can reset expected results by specifying a --reset-results option.
1106         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
1107         Contains simple methods.
1108         (func1):
1109         (func2):
1110         (func3):
1111         (func4):
1112         (func5):
1113         (func6):
1114         * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
1115         This test result is generated by the --reset-results option.
1116
1117 2011-12-21  Eric Seidel  <eric@webkit.org>
1118
1119         Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
1120         so that they appear in the bugzilla autocomplete CC list.
1121         I also removed the "radar" irc nick (which I believe does not exist)
1122         and removed the uneeded [] around the radar bugzilla email.
1123
1124         Unreviewed.
1125
1126         * Scripts/webkitpy/common/config/committers.py:
1127
1128 2011-12-21  Daniel Bates  <dbates@rim.com>
1129
1130         Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
1131         https://bugs.webkit.org/show_bug.cgi?id=74985
1132
1133         Reviewed by Eric Seidel.
1134
1135         * Scripts/build-jsc:
1136         * Scripts/webkitdirs.pm:
1137         (cmakeBasedPortName): Added.
1138
1139 2011-12-21  Daniel Bates  <dbates@rim.com>
1140
1141         Extract BlackBerry CMake arguments from build-webkit into separate function
1142         https://bugs.webkit.org/show_bug.cgi?id=74981
1143
1144         Reviewed by Rob Buis.
1145
1146         Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
1147         the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
1148         and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
1149         This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
1150         that we can pass them to the CMake build system when building JavaScriptCore.
1151
1152         * Scripts/build-webkit: Move construction of CMake argument list from here to
1153         webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
1154         since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
1155         call it from build-webkit.
1156         * Scripts/webkitdirs.pm:
1157         (blackberryCMakeArguments): Added.
1158         (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
1159         BlackBerry port.
1160
1161 2011-12-21  Daniel Bates  <dbates@webkit.org>
1162
1163         Extract WinCE CMake arguments from build-webkit into separate function
1164         https://bugs.webkit.org/show_bug.cgi?id=74983
1165
1166         Reviewed by Rob Buis.
1167
1168         Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
1169         WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
1170         This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
1171         that we can pass it to the CMake build system when building JavaScriptCore.
1172
1173         * Scripts/build-webkit:
1174         * Scripts/webkitdirs.pm:
1175         (cmakeBasedPortArguments): Added.
1176
1177 2011-12-21  Kentaro Hara  <haraken@chromium.org>
1178
1179         In prepare-ChangeLog, replace constant global variables with "use constant"
1180         https://bugs.webkit.org/show_bug.cgi?id=74992
1181
1182         Reviewed by Ryosuke Niwa.
1183
1184         This patch replaces the following constant global variables with "use constant"s.
1185             - $changeLogTimeZone
1186             - $SVN
1187             - $GIT
1188             - %supportedTestExtensions
1189
1190         * Scripts/prepare-ChangeLog:
1191         (changeLogNameFromArgs):
1192         (changeLogEmailAddressFromArgs):
1193         (resolveConflictedChangeLogs):
1194         (generateNewChangeLogs):
1195         (diffCommand):
1196         (statusCommand):
1197         (createPatchCommand):
1198         (findOriginalFileFromSvn):
1199         (determinePropertyChanges):
1200         (generateFileList):
1201         (reviewerAndDescriptionForGitCommit):
1202
1203 2011-12-20  Dirk Pranke  <dpranke@chromium.org>
1204
1205         nrwt: rename field references from _fs to _filesystem
1206         https://bugs.webkit.org/show_bug.cgi?id=74898
1207
1208         Reviewed by Adam Barth.
1209
1210         This is a simple cleanup; most of the code uses
1211         self._filesystem, but some used self._fs; this change renames
1212         the latter to the former to be more consistent.
1213
1214         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1215         (Manager.__init__):
1216         (Manager.collect_tests):
1217         (Manager._strip_test_dir_prefix):
1218         (Manager._split_into_chunks_if_necessary):
1219         (Manager.results_directory):
1220         (Manager._clobber_old_results):
1221         (Manager._upload_json_files):
1222         (Manager.print_config):
1223         (Manager._copy_results_html_file):
1224         (Manager._show_results_html_file):
1225         (Manager._log_worker_stack):
1226         * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
1227         (JSONLayoutResultsGenerator._normalize_results_json):
1228         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
1229         (JSONResultsGeneratorBase.__init__):
1230         (JSONResultsGeneratorBase.generate_json_output):
1231         (JSONResultsGeneratorBase.generate_times_ms_file):
1232         (JSONResultsGeneratorBase.upload_json_files):
1233         (JSONResultsGeneratorBase._get_svn_revision):
1234         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1235         (Base.__init__):
1236
1237 2011-12-20  Kentaro Hara  <haraken@chromium.org>
1238
1239         Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
1240         https://bugs.webkit.org/show_bug.cgi?id=74836
1241
1242         Reviewed by David Kilzer.
1243
1244         webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
1245         This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
1246         for unit-testing of other Perl scripts. We are planning to use it for unit-testing
1247         of prepare-ChangeLog.
1248
1249         Using LoadAsModule.pm, you can load a Perl script as follows.
1250         The first argument is the arbitrary package name you want to use, and the second argument
1251         is the name of the Perl script you want to load.
1252
1253             use LoadAsModule qw(RunLeaks run-leaks);
1254             RunLeaks::someFunctionDefinedInRunLeaks(...);
1255
1256         Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
1257                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
1258                Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
1259
1260         * Scripts/webkitperl/LoadAsModule.pm: Added.
1261         * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
1262         (import):
1263         (readFile):
1264         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
1265         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
1266         * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
1267
1268 2011-12-20  Balazs Kelemen  <kbalazs@webkit.org>
1269
1270         [Qt] WK2 Debugging quirks need some improvement
1271         https://bugs.webkit.org/show_bug.cgi?id=74859
1272
1273         Reviewed by Simon Hausmann.
1274
1275         Improvements added to make debugging WebKit2 more
1276         confortable and efficient:
1277         1. Unify debugging quirks. From now all of them are controlled
1278         by the QT_WEBKIT2_DEBUG environment variable.
1279         2. Disable crash handlers for WebKitTestRunner if debugging quirks
1280         are used to make it possible to use postmortem debugging via core dumps
1281         which is extremely useful for debugging bugs triggered by layout tests.
1282         3. Disable test timeout for WebKitTestRunner if debugging quirks
1283         are used because that makes debugging impossible.
1284
1285         * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
1286         (WTR::InjectedBundle::platformInitialize):
1287         * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
1288         (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
1289         * WebKitTestRunner/qt/TestControllerQt.cpp:
1290         (WTR::TestController::platformRunUntil):
1291
1292 2011-12-20  Rafael Brandao  <rafael.lobo@openbossa.org>
1293
1294         [Qt][WK2] Implement favicon support
1295         https://bugs.webkit.org/show_bug.cgi?id=71082
1296
1297         Reviewed by Simon Hausmann.
1298
1299         A favorite icon was added on MiniBrowser's url bar as example.
1300         We display a default icon when the page doesn't have an icon ready.
1301
1302         * MiniBrowser/qt/MiniBrowser.qrc:
1303         * MiniBrowser/qt/icons/favicon.png: Added.
1304         * MiniBrowser/qt/qml/BrowserWindow.qml:
1305
1306 2011-12-19  Sam Weinig  <sam@webkit.org>
1307
1308         Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
1309         https://bugs.webkit.org/show_bug.cgi?id=74907
1310
1311         Reviewed by Dan Bernstein.
1312
1313         Add ScrollByLineCommands API test.
1314
1315         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1316         * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
1317         * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
1318
1319 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
1320
1321         webkitpy: remove port.executive, port.filesystem, port.user properties
1322         https://bugs.webkit.org/show_bug.cgi?id=74896
1323
1324         Reviewed by Eric Seidel.
1325
1326         Following on the refactoring of the port and host objects, this
1327         removes the public executive, filesystem, and user properties
1328         from the Port interface (protected versions of executive and
1329         filesystem still exist). There is still some more clean up to
1330         make the code more consistent and rearrange some other files to
1331         talk to Hosts directly instead of getting them off of the Port
1332         class.
1333
1334         * Scripts/webkitpy/layout_tests/controllers/manager.py:
1335         (Manager.__init__):
1336         (Manager.results_directory):
1337         (Manager._log_worker_stack):
1338         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
1339         (ManagerTest.test_fallback_path_in_config):
1340         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1341         (_InlineManager.start_worker):
1342         (_InlineWorkerConnection.__init__):
1343         * Scripts/webkitpy/layout_tests/controllers/worker.py:
1344         (Worker.safe_init):
1345         * Scripts/webkitpy/layout_tests/models/test_configuration.py:
1346         (TestConfiguration.from_port):
1347         * Scripts/webkitpy/layout_tests/port/base.py:
1348         (Port.__init__):
1349         (Port.tests):
1350         (Port.show_results_html_file):
1351         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1352         (PortTest.test_layout_tests_skipping):
1353         (PortTest.test_test_dirs):
1354         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
1355         (_set_up_derived_options):
1356         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
1357         (PerfTestsRunner.__init__):
1358         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1359         (HtmlGenerator.__init__):
1360         (HtmlGenerator.show_html):
1361         (real_main):
1362         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1363         (TestHtmlGenerator.make_generator):
1364
1365 2011-12-19  Daniel Bates  <dbates@webkit.org>
1366
1367         Pass command line arguments to GDB when debugging a Mac WebKit application
1368         https://bugs.webkit.org/show_bug.cgi?id=72829
1369
1370         Reviewed by David Kilzer.
1371
1372         Pass through any command line arguments given to debug-{safari, minibrowser}
1373         to GDB so that they may influence the application instance launched by GDB.
1374
1375         * Scripts/webkitdirs.pm:
1376         (execMacWebKitAppForDebugging):
1377
1378 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
1379
1380         webkitpy: remove executive,filesystem,user parameters from Port constructor
1381         https://bugs.webkit.org/show_bug.cgi?id=74878
1382
1383         Reviewed by Eric Seidel.
1384
1385         This change concludes the refactoring that makes Host a required
1386         parameter for Port and ensures that all access to filesystem,
1387         executives, etc. is going through the Host.
1388
1389         * Scripts/webkitpy/layout_tests/port/base.py:
1390         (Port.__init__):
1391
1392 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
1393
1394         webkitpy: finish refactoring port classes to make a host mandatory
1395         https://bugs.webkit.org/show_bug.cgi?id=74566
1396
1397         Reviewed by Eric Seidel.
1398
1399         This change makes all Port objects take a required (System)Host
1400         parameter, and updates the TestPort object to no longer create a
1401         mock filesystem or add files to the existing filesystem by
1402         default.
1403
1404         * Scripts/webkitpy/layout_tests/port/base.py:
1405         (Port.__init__):
1406         * Scripts/webkitpy/layout_tests/port/factory.py:
1407         (PortFactory.__init__):
1408         (PortFactory._get_kwargs):
1409         * Scripts/webkitpy/layout_tests/port/test.py:
1410         (TestInstance.__init__):
1411         (TestPort.__init__):
1412         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
1413         (passing_run):
1414         (logging_run):
1415         (get_tests_run):
1416         (MainTest.test_single_file):
1417         (MainTest.test_stderr_is_saved):
1418         (MainTest.test_test_list):
1419         (MainTest.test_test_list_with_prefix):
1420         (MainTest.test_missing_and_unexpected_results):
1421         (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
1422         (MainTest.test_crash_with_stderr):
1423         (MainTest.test_no_image_failure_with_image_diff):
1424         (MainTest.test_crash_log):
1425         (MainTest.test_web_process_crash_log):
1426         (MainTest.test_exit_after_n_failures_upload):
1427         (MainTest.test_results_directory_absolute):
1428         (MainTest.test_results_directory_relative):
1429         (MainTest.test_retries_directory):
1430         (MainTest.test_tolerance.get_port_for_run):
1431         (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
1432         (EndToEndTest.test_end_to_end):
1433         (EndToEndTest.test_reftest_with_two_notrefs):
1434         (RebaselineTest.test_reset_results):
1435         (RebaselineTest.test_missing_results):
1436         (RebaselineTest.test_new_baseline):
1437         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
1438         (Rebaseliner.__init__):
1439         (main):
1440         (real_main):
1441         * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
1442         (test_host_port_and_filesystem):
1443         (TestRebaseliner.make_rebaseliner):
1444         (TestRealMain.test_all_platforms):
1445         (TestHtmlGenerator.make_generator):
1446
1447 2011-12-19  Dirk Pranke  <dpranke@chromium.org>
1448
1449         webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
1450         https://bugs.webkit.org/show_bug.cgi?id=74562
1451
1452         Reviewed by Eric Seidel.
1453
1454         Apart from a minor change to style/checkers/test_expectations.py
1455         to take a host as a parameter to a TestExpectationsChecker(),
1456         there are only refactoring changes to unit tests here.
1457
1458         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
1459         (TestResultWriterTest.test_reftest_diff_image):
1460         * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
1461         (JSONGeneratorTest._test_json_generation):
1462         (JSONGeneratorTest.test_test_timings_trie):
1463         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1464         (Base.__init__):
1465         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1466         (PortTest.make_port):
1467         (PortTest.test_layout_tests_skipping):
1468         (PortTest.test_test_dirs):
1469         (PortTest.test_additional_platform_directory):
1470         (PortTest.test_uses_test_expectations_file):
1471         (PortTest.test_find_no_paths_specified):
1472         (PortTest.test_find_one_test):
1473         (PortTest.test_find_glob):
1474         (PortTest.test_find_with_skipped_directories):
1475         (PortTest.test_find_with_skipped_directories_2):
1476         (PortTest.test_parse_reftest_list):
1477         * Scripts/webkitpy/layout_tests/port/dryrun.py:
1478         (DryRunPort.__init__):
1479         * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
1480         (FactoryTest.setUp):
1481         (FactoryTest.tearDown):
1482         (FactoryTest.assert_port):
1483         (FactoryTest.assert_platform_port):
1484         (FactoryTest.test_unknown_specified):
1485         (FactoryTest.test_unknown_default):
1486         * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
1487         (GetGoogleChromePortTest._verify_expectations_overrides):
1488         * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
1489         (MockDRTPortTest.make_port):
1490         (MockDRTTest.assertTest):
1491         (MockDRTTest.test_main):
1492         (MockChromiumDRTTest.test_pixeltest__fails):
1493         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
1494         (QtPortTest._assert_search_path):
1495         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
1496         (TestWebKitPort.__init__):
1497         (WebKitPortTest.test_skipped_directories_for_symbols):
1498         (test_skipped_directories_for_features):
1499         (test_skipped_layout_tests):
1500         (test_skipped_file_search_paths):
1501         (test_root_option):
1502         (test_test_expectations):
1503         (test_build_driver):
1504         (test_linux_distro_detection):
1505         (test_apache_config_file_name_for_platform):
1506         (test_path_to_apache_config_file):
1507         (WebKitDriverTest.test_read_block):
1508         * Scripts/webkitpy/style/checkers/test_expectations.py:
1509         (TestExpectationsChecker.__init__):
1510         * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
1511         (TestExpectationsTestCase._expect_port_for_expectations_path):
1512         (TestExpectationsTestCase.assert_lines_lint):
1513         * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
1514         (get_test_config.TestMacPort):
1515
1516 2011-12-19  Raphael Kubo da Costa  <kubo@profusion.mobi>
1517
1518         [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
1519         https://bugs.webkit.org/show_bug.cgi?id=74854
1520
1521         Reviewed by Csaba Osztrogonác.
1522
1523         Since r101052, libewebkit.so is built in a different location, so we
1524         need to adjust the path returned by builtDylibPathForName.
1525
1526         usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
1527         port also respects Release/Debug configurations.
1528
1529         These changes should make run-launcher finally work correctly with
1530         webkit-efl.
1531
1532         * Scripts/webkitdirs.pm:
1533         (usesPerConfigurationBuildDirectory):
1534         (builtDylibPathForName):
1535
1536 2011-12-19  Simon Hausmann  <simon.hausmann@nokia.com>
1537
1538         [Qt][WK2] Add support for modal event loop processing for WTR
1539         https://bugs.webkit.org/show_bug.cgi?id=74852
1540
1541         Reviewed by Kenneth Rohde Christiansen.
1542
1543         Rewrote event loop processing: Instead of terminating the event loop
1544         in notifyDone() - something no other platform does - we now respect the
1545         "bool& condition" parameter passed to platformRunUntil. This ensures
1546         proper termination even when the condition is changed from within a
1547         nested event loop, because only when we _exit_ from the nested event
1548         loop we will check the condition and terminate the test properly.
1549
1550         In addition this patch implements TestController::runModal by means of
1551         a nested event loop, which is passed to the platform webview that is
1552         supposed to be modal. It is that view's responsibility to exit the
1553         loop, upon destruction. I believe that's similar to how it works on the Mac,
1554         where it doesn't seem that NSApp's runModalForWindow is terminate via
1555         abort/stopModal but simply because the window is closed.
1556
1557         * WebKitTestRunner/PlatformWebView.h:
1558         (WTR::PlatformWebView::setModalEventLoop):
1559         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
1560         (WTR::PlatformWebView::PlatformWebView):
1561         (WTR::PlatformWebView::~PlatformWebView):
1562         * WebKitTestRunner/qt/TestControllerQt.cpp:
1563         (WTR::TestController::notifyDone):
1564         (WTR::TestController::platformRunUntil):
1565         (WTR::TestController::runModal):
1566
1567 2011-12-18  Kentaro Hara  <haraken@chromium.org>
1568
1569         REGRESSION(r103149): prepare-ChangeLog outputs a warning
1570         https://bugs.webkit.org/show_bug.cgi?id=74808
1571
1572         Reviewed by David Kilzer.
1573
1574         Added the prototype declaration of main() to avoid warning messages.
1575         Sorted subroutine declarations in the alphabetical order.
1576
1577         * Scripts/prepare-ChangeLog:
1578
1579 2011-12-17  Adenilson Cavalcanti  <cavalcantii@gmail.com>
1580
1581         [Qt] Fix QtTestBrowser compilation with QtWidgets module
1582         https://bugs.webkit.org/show_bug.cgi?id=74791
1583
1584         Reviewed by Andreas Kling.
1585
1586         * QtTestBrowser/QtTestBrowser.pro:
1587
1588 2011-12-17  Kentaro Hara  <haraken@chromium.org>
1589
1590         Remove top-level code completely from prepare-ChangeLog
1591         https://bugs.webkit.org/show_bug.cgi?id=74698
1592
1593         Reviewed by Darin Adler.
1594
1595         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
1596         This patch just moves all top-level code into main().
1597
1598         * Scripts/prepare-ChangeLog:
1599         (main):
1600
1601 2011-12-16  Dean Jackson  <dino@apple.com>
1602
1603         Move webkit-bug-importer to Contributor. It won't
1604         autocomplete as an Account.
1605         See https://bugs.webkit.org/show_bug.cgi?id=74739
1606         for some discussion.
1607
1608         Unreviewed.
1609
1610         * Scripts/webkitpy/common/config/committers.py:
1611
1612 2011-12-16  Dean Jackson  <dino@apple.com>
1613
1614         Add webkit-bug-importer@group.apple.com to accounts
1615         so that it autocompletes in bugzilla.
1616
1617         Unreviewed.
1618
1619         * Scripts/webkitpy/common/config/committers.py:
1620
1621 2011-12-16  Philippe Normand  <pnormand@igalia.com>
1622
1623         Unreviewed, skipping 3 failing GTK API tests.
1624
1625         * Scripts/run-gtk-tests:
1626
1627 2011-12-16  Philippe Normand  <pnormand@igalia.com>
1628
1629         Unreviewed, GTK API tests build fix attempt.
1630
1631         * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
1632
1633 2011-12-16  Philippe Normand  <pnormand@igalia.com>
1634
1635         Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
1636
1637         * Scripts/run-gtk-tests:
1638
1639 2011-12-16  Simon Hausmann  <simon.hausmann@nokia.com>
1640
1641         [Qt] Fix the build for newer Qt5
1642         https://bugs.webkit.org/show_bug.cgi?id=74703
1643
1644         Reviewed by Csaba Osztrogonác.
1645
1646         * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
1647         * DumpRenderTree/qt/EventSenderQt.cpp:
1648         (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
1649         * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
1650         (WTR::EventSenderProxy::sendTouchEvent):
1651         * MiniBrowser/qt/MiniBrowserApplication.cpp:
1652         (MiniBrowserApplication::sendTouchEvent): Ditto.
1653         (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
1654
1655 2011-12-16  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1656
1657         [Qt] Detect and force clean build when feature defines are added
1658
1659         Reviewed by Ossy.
1660
1661         https://bugs.webkit.org/show_bug.cgi?id=74689
1662
1663         * Scripts/webkitdirs.pm:
1664
1665 2011-12-16  Kentaro Hara  <haraken@chromium.org>
1666
1667         [Refactoring] Remove all global variables from prepare-ChangeLog
1668         https://bugs.webkit.org/show_bug.cgi?id=74681
1669
1670         Reviewed by Ryosuke Niwa.
1671
1672         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1673         manner. This bug is one of the incremental refactorings to remove all top-level
1674         code and global variables from prepare-ChangeLog. In this patch,
1675         we make the following global variables be used only through parameter passing.
1676         This patch removes all global variables from prepare-ChangeLog.
1677             - $mergeBase
1678             - $gitCommit
1679             - $gitIndex
1680
1681         * Scripts/prepare-ChangeLog:
1682         (generateFunctionLists):
1683         (changeLogNameFromArgs):
1684         (changeLogEmailAddressFromArgs):
1685         (generateNewChangeLogs):
1686         (printDiff):
1687         (diffFromToString):
1688         (diffCommand):
1689         (statusCommand):
1690         (createPatchCommand):
1691         (generateFileList):
1692         (isConflictStatus):
1693
1694 2011-12-15  Philippe Normand  <pnormand@igalia.com>
1695
1696         [GTK] Rounding errors on 32-bit machines causes tests to fail
1697         https://bugs.webkit.org/show_bug.cgi?id=72254
1698
1699         Initial patch by vanuan@gmail.com.
1700         Reviewed by Martin Robinson.
1701
1702         * Scripts/webkitdirs.pm:
1703         (runAutogenForAutotoolsProjectIfNecessary): Pass additional
1704         CXXFLAGS to autogen in an attempt to harmonize floating point
1705         values between 32-bit and 64-bit architectures.
1706
1707 2011-12-16  Martin Robinson  <mrobinson@igalia.com>
1708
1709         [GTK] Make distcheck fails during the install
1710         https://bugs.webkit.org/show_bug.cgi?id=74274
1711
1712         No review, since this is a build fix.
1713
1714         * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
1715         step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
1716         always runs. This means that the gtkdoc step was always running when make was
1717         invoked. Generating gtkdoc during 'make install' was triggering a race condition
1718         with the library file. Later we can fix generate-forwarding-headers and unbreak
1719         'make docs,' but this bandaid is sufficient to let us release.
1720
1721 2011-12-15  Eric Seidel  <eric@webkit.org>
1722
1723         NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
1724         https://bugs.webkit.org/show_bug.cgi?id=74650
1725
1726         Reviewed by Adam Barth.
1727
1728         * Scripts/webkitpy/common/system/platforminfo.py:
1729         (PlatformInfo._compute_bytes_from_vm_stat_output):
1730         * Scripts/webkitpy/layout_tests/port/base.py:
1731         (Port.default_child_processes):
1732         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
1733         (PortTest.test_default_child_processes):
1734
1735 2011-12-15  Filip Pizlo  <fpizlo@apple.com>
1736
1737         bencher script should support remote benchmarking on platforms that don't have ruby
1738         https://bugs.webkit.org/show_bug.cgi?id=74659
1739
1740         Rubber-stamped by Sam Weinig.
1741         
1742         Added the ability to have bencher generate a benchmarking playload that consists of
1743         copies of all of the benchmarks, optionally copies of all of the frameworks and
1744         binaries to run all of the VMs, and a sh script that runs the benchmarks in random
1745         order, which then spits out a raw results file that bencher can parse.
1746         
1747         In normal operating mode, you never see this, as it just generates the payload and
1748         script internally, runs it, parses the results, and spits them out.
1749         
1750         The --remote mode has been changed to use this style, so any remote host that has
1751         sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
1752         a sh-compatible shell can be used for remote benchmarking.
1753         
1754         The feature to include VMs in the benchmarking payload is by default only activated
1755         when using --remote, but it can also be activated when doing local benchmarking; the
1756         benefit is that you remove any pathname-related performance pathologies. All VMs
1757         become equal because they are all located in
1758         /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
1759         (usually 0 or 1).
1760         
1761         Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
1762         through DumpRenderTree. This is only a bit slower than running in jsc.
1763
1764         * Scripts/bencher:
1765
1766 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
1767
1768         webkitpy: clean up TestPort to (mostly) not create a new filesystem
1769         https://bugs.webkit.org/show_bug.cgi?id=74556
1770
1771         This change modifies the TestPort to be ready to add tests to an
1772         existing filesystem instead of creating a new filesystem; we
1773         leave unit_test_filesystem() in for now for compatibility.
1774
1775         * Scripts/webkitpy/common/host_mock.py:
1776         (MockHost.__init__):
1777           - call add_unit_tests_to_mock_filesystem by default to make
1778             the MockHost more generally useful for layout_test unit tests.
1779         * Scripts/webkitpy/layout_tests/port/test.py:
1780         (TestInstance.__init__):
1781         (add_unit_tests_to_mock_filesystem):
1782         (add_file):
1783         (unit_test_filesystem):
1784         (TestPort.__init__):
1785         (TestPort._set_default_overriding_none):
1786
1787 2011-12-15  Dirk Pranke  <dpranke@chromium.org>
1788
1789         webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
1790         https://bugs.webkit.org/show_bug.cgi?id=74551
1791
1792         This is some minor cleanup prior to making all of the host/port
1793         changes described in bug 74138.
1794
1795         * Scripts/webkitpy/common/host_mock.py:
1796         (MockHost.__init__):
1797           - make sure the scm object is initialized with the same mock
1798             executive and filesystem objects.
1799
1800         * Scripts/webkitpy/common/system/filesystem_mock.py:
1801         (MockFileSystem.clear_written_files):
1802           - add a routine that will be useful in testing.
1803         (MockFileSystem.maybe_make_directory):
1804         (MockFileSystem.write_binary_file):
1805           - fix bugs to make sure directories are created properly.
1806         * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
1807         (_Process.run):
1808           - add clarifying comments.
1809         * Scripts/webkitpy/layout_tests/port/mock_drt.py:
1810         (MockDRTPort.__init__):
1811         (MockDRT.__init__):
1812           - add clarifying comments.
1813
1814 2011-12-15  Anders Carlsson  <andersca@apple.com>
1815
1816         Regression (r102866): Navigating away from or closing a page with a plugin crashes
1817         https://bugs.webkit.org/show_bug.cgi?id=74655
1818
1819         Reviewed by Sam Weinig.
1820
1821         Add a bunch of tests.
1822
1823         * TestWebKitAPI/Tests/WTF/Functional.cpp:
1824
1825 2011-12-15  Stephanie Lewis  <slewis@apple.com>
1826
1827         https://bugs.webkit.org/show_bug.cgi?id=74469
1828         Escape paths to svn commands so our tools can handle filenames with @ symbols.
1829
1830         Reviewed by Adam Roben.
1831
1832         * Scripts/VCSUtils.pm:
1833         (scmMoveOrRenameFile):
1834         (scmAddExecutableBit):
1835         (scmRemoveExecutableBit):
1836         (determineSVNRoot):
1837         (svnRevisionForDirectory):
1838         (pathRelativeToSVNRepositoryRootForPath):
1839         (svnStatus):
1840         (escapeSubversionPath):
1841         * Scripts/parse-malloc-history:
1842         (main):
1843         * Scripts/prepare-ChangeLog:
1844         (diffCommand):
1845         (statusCommand):
1846         (findOriginalFileFromSvn):
1847         (determinePropertyChanges):
1848         * Scripts/resolve-ChangeLogs:
1849         (conflictFiles):
1850         (resolveConflict):
1851         (showStatus):
1852         * Scripts/svn-apply:
1853         (patch):
1854         (scmCopy):
1855         (scmAdd):
1856         (scmRemove):
1857         * Scripts/svn-create-patch:
1858         (findBaseUrl):
1859         (findMimeType):
1860         (findSourceFileAndRevision):
1861         (generateDiff):
1862         (generateFileList):
1863         (manufacturePatchForAdditionWithHistory):
1864         * Scripts/svn-unapply:
1865         (patch):
1866         (revertDirectories):
1867
1868 2011-12-15  Michael Bruning  <michael.bruning@nokia.com>
1869
1870         [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
1871         https://bugs.webkit.org/show_bug.cgi?id=74617
1872
1873         Reviewed by Kenneth Rohde Christiansen.
1874
1875         * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
1876         for viewport info button, adjusted height and added rounded corners.
1877
1878 2011-12-15  Andy Estes  <aestes@apple.com>
1879
1880         TestFailures: store the name of the buildbot results directory in a property
1881         https://bugs.webkit.org/show_bug.cgi?id=74663
1882
1883         Reviewed by Adam Barth.
1884         
1885         Store the name of the results directory as a property on Buildbot's
1886         prototype. This allows subclasses of Buildbot to customize the results
1887         directory.
1888
1889         * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
1890         (Buildbot.prototype.resultsDirectoryURL):
1891
1892 2011-12-15  Tony Chang  <tony@chromium.org>
1893
1894         [chromium] pass --delete_unversioned_trees to gclient on the bots
1895         https://bugs.webkit.org/show_bug.cgi?id=74565
1896
1897         Reviewed by Kenneth Russell.
1898
1899         It was temporarily removed in r102891 to keep the bots green.  Now
1900         that the bots have cycled, we can add it back.
1901
1902         * Scripts/update-webkit-chromium:
1903
1904 2011-12-15  Kentaro Hara  <haraken@chromium.org>
1905
1906         [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
1907         https://bugs.webkit.org/show_bug.cgi?id=74497
1908
1909         Reviewed by Ryosuke Niwa.
1910
1911         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
1912         manner. This bug is one of the incremental refactorings to remove all top-level
1913         code and global variables from prepare-ChangeLog. In this patch,
1914         we make the following global variables be used only through parameter passing.
1915             - $bugDescription
1916             - $bugNumber
1917             - $name
1918             - $emailAddress
1919             - $gitReviewer
1920             - $writeChangeLogs
1921
1922         * Scripts/prepare-ChangeLog:
1923         (fetchBugDescriptionFromURL):
1924         (generateNewChangeLogs):
1925         (reviewerAndDescriptionForGitCommit):
1926
1927 2011-12-15  Raphael Kubo da Costa  <kubo@profusion.mobi>
1928
1929         [EFL] Add a few more web database functions to ewk_settings.
1930         https://bugs.webkit.org/show_bug.cgi?id=72148
1931
1932         Reviewed by Antonio Gomes.
1933
1934         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
1935         (LayoutTestController::clearAllDatabases):
1936         (LayoutTestController::setDatabaseQuota):
1937
1938 2011-12-15  Martin Kosiba  <mkosiba@google.com>
1939
1940         Fix find on web pages with -webkit-user-select: none for Chromium
1941         https://bugs.webkit.org/show_bug.cgi?id=72281
1942
1943         Reviewed by Ryosuke Niwa.
1944
1945         Provided a partial findString implementation. This doesn't support
1946         all of the FindOptions since they're not exposed via WebFindOptions.
1947
1948         * DumpRenderTree/chromium/LayoutTestController.cpp:
1949         (LayoutTestController::LayoutTestController):
1950         (LayoutTestController::findString):
1951         * DumpRenderTree/chromium/LayoutTestController.h:
1952
1953 2011-12-15  Kenneth Russell  <kbr@google.com>
1954
1955         [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
1956         https://bugs.webkit.org/show_bug.cgi?id=74581
1957
1958         Reviewed by Darin Fisher.
1959
1960         * DumpRenderTree/chromium/LayoutTestController.cpp:
1961         (LayoutTestController::overridePreference):
1962         * DumpRenderTree/chromium/WebPreferences.cpp:
1963         (WebPreferences::reset):
1964         (WebPreferences::applyTo):
1965         * DumpRenderTree/chromium/WebPreferences.h:
1966
1967 2011-12-15  Kenneth Rohde Christiansen  <kenneth@webkit.org>
1968
1969         [Qt] Improve the look of the viewport info overlay
1970
1971         Reviewed by Tor Arne Vestbø.
1972
1973         * MiniBrowser/qt/qml/ViewportInfoItem.qml:
1974
1975 2011-12-15  Igor Oliveira  <igor.oliveira@openbossa.org>
1976
1977         [Qt] Support requestAnimationFrame API
1978         https://bugs.webkit.org/show_bug.cgi?id=74528
1979
1980         Add build-option for requestAnimationFrame feature.
1981
1982         Reviewed by Kenneth Rohde Christiansen.
1983
1984         * qmake/mkspecs/features/features.prf:
1985
1986 2011-12-15  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
1987
1988         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
1989
1990         Reviewed by Simon Hausmann.
1991
1992         * qmake/mkspecs/features/webcore.prf:
1993
1994 2011-12-15  Michael Brüning  <michael.bruning@nokia.com>
1995
1996         [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
1997         https://bugs.webkit.org/show_bug.cgi?id=72893
1998
1999         Reviewed by Kenneth Rohde Christiansen.
2000
2001         This patch extends QQuickWebViewExperimental by a property named
2002         viewportInfo, which contains the viewport scalability and
2003         layout and contents size information. This property is exposed to
2004         QML through the experimental extension for QQuickWebView.
2005
2006         * MiniBrowser/qt/MiniBrowser.pro:
2007         * MiniBrowser/qt/MiniBrowser.qrc:
2008         * MiniBrowser/qt/icons/info.png: Added.
2009         * MiniBrowser/qt/qml/BrowserWindow.qml:
2010         * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
2011
2012 2011-12-15  Shinya Kawanaka  <shinyak@google.com>
2013
2014         [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
2015         https://bugs.webkit.org/show_bug.cgi?id=74586
2016
2017         Reviewed by Hajime Morita.
2018
2019         No new tests. Covered by existing tests.
2020
2021         * DumpRenderTree/chromium/WebViewHost.cpp:
2022         (WebViewHost::requestCheckingOfText):
2023           Returns immediately if text is empty.
2024
2025 2011-12-15  Alexander Færøy  <ahf@0x90.dk>
2026
2027         [Qt] QtWebKit fails to build on Mac OS X after r102776
2028         https://bugs.webkit.org/show_bug.cgi?id=74593
2029
2030         Reviewed by Simon Hausmann.
2031
2032         CONFIG =+ link_pkgconfig is needed such that the correct parameters
2033         are passed to the compiler.
2034
2035         * DumpRenderTree/qt/DumpRenderTree.pro:
2036
2037 2011-12-14  Tony Chang  <tony@chromium.org>
2038
2039         [chromium] Remove redundant third_party entries from chromium DEPS
2040         https://bugs.webkit.org/show_bug.cgi?id=74472
2041
2042         Reviewed by Kenneth Russell.
2043
2044         * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
2045
2046 2011-12-14  Kentaro Hara  <haraken@chromium.org>
2047
2048         [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
2049         VCSUtils::isGit() and VCSUtils::isSVN().
2050         https://bugs.webkit.org/show_bug.cgi?id=74485
2051
2052         Reviewed by David Kilzer.
2053
2054         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
2055         manner. This bug is one of the incremental refactorings to remove all top-level
2056         code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
2057         with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
2058         assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
2059         just by looking at the current working directory.
2060
2061         * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
2062         (diffFromToString):
2063         (diffCommand):
2064         (statusCommand):
2065         (createPatchCommand):
2066         (diffHeaderFormat):
2067         (generateFileList):
2068         (isAddedStatus):
2069         (isConflictStatus):
2070         (statusDescription):
2071         (extractLineRange):
2072
2073 2011-12-14  Sam Weinig  <weinig@apple.com>
2074
2075         Remove whitespace from InheritedPropertySheets attributes in
2076         vsprops files to appease the Visual Studio project migrator.
2077
2078         Reviewed by Adam Roben.
2079
2080         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
2081         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
2082         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
2083         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
2084         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
2085         * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
2086         * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
2087         * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
2088         * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
2089         * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
2090         * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
2091         * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
2092         * DumpRenderTree/win/ImageDiffDebug.vsprops:
2093         * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
2094         * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
2095         * DumpRenderTree/win/ImageDiffProduction.vsprops:
2096         * DumpRenderTree/win/ImageDiffRelease.vsprops:
2097         * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
2098         * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
2099         * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
2100         * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
2101         * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
2102         * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
2103         * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
2104         * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
2105         * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
2106         * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
2107         * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
2108         * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
2109         * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
2110         * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
2111         * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
2112         * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
2113         * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
2114         * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
2115         * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
2116         * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
2117         * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
2118         * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
2119         * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
2120         * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
2121         * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
2122         * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
2123         * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
2124         * WinLauncher/WinLauncherDebug.vsprops:
2125         * WinLauncher/WinLauncherDebugAll.vsprops:
2126         * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
2127         * WinLauncher/WinLauncherProduction.vsprops:
2128         * WinLauncher/WinLauncherRelease.vsprops:
2129         * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
2130         * record-memory-win/record-memory-winDebug.vsprops:
2131         * record-memory-win/record-memory-winDebugAll.vsprops:
2132         * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
2133         * record-memory-win/record-memory-winProduction.vsprops:
2134         * record-memory-win/record-memory-winRelease.vsprops:
2135         * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
2136
2137 2011-12-14  Anders Carlsson  <andersca@apple.com>
2138
2139         Windows build fix.
2140
2141         Move CHECKs out of the destructor.
2142
2143         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2144         (TestWebKitAPI::B::~B):
2145         (TestWebKitAPI::TEST):
2146
2147 2011-12-14  Anders Carlsson  <andersca@apple.com>
2148
2149         binding a member function should ref/deref the object pointer if needed
2150         https://bugs.webkit.org/show_bug.cgi?id=74552
2151
2152         Reviewed by Sam Weinig.
2153
2154         Add new tests.
2155
2156         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2157         (TestWebKitAPI::B::B):
2158         (TestWebKitAPI::B::~B):
2159         (TestWebKitAPI::B::ref):
2160         (TestWebKitAPI::B::deref):
2161         (TestWebKitAPI::B::f):
2162         (TestWebKitAPI::B::g):
2163         (TestWebKitAPI::TEST):
2164
2165 2011-12-14  Hajime Morrita  <morrita@chromium.org>
2166
2167         JS_INLINE and WTF_INLINE should be visible from WebCore
2168         https://bugs.webkit.org/show_bug.cgi?id=73191
2169
2170         Reviewed by Kevin Ollivier.
2171
2172         Removed macro definitions which is now provided by Platform.h
2173
2174         * DumpRenderTree/chromium/config.h:
2175         * DumpRenderTree/config.h:
2176         * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
2177         * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
2178         * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
2179         * TestWebKitAPI/config.h:
2180         * WebKitTestRunner/config.h:
2181
2182 2011-12-14  Kentaro Hara  <haraken@chromium.org>
2183
2184         Unreviewed, rolling out r102761.
2185         http://trac.webkit.org/changeset/102761
2186         https://bugs.webkit.org/show_bug.cgi?id=74485
2187
2188         we came up with a better fix than this (see comments in bug
2189         74485)
2190
2191         * Scripts/prepare-ChangeLog:
2192         (generateFunctionLists):
2193         (printDiff):
2194         (diffCommand):
2195         (statusCommand):
2196         (createPatchCommand):
2197         (generateFileList):
2198         (isAddedStatus):
2199         (isConflictStatus):
2200         (statusDescription):
2201         (extractLineRange):
2202
2203 2011-12-14  Anders Carlsson  <andersca@apple.com>
2204
2205         Work around a bug in the MSVC2005 compiler
2206         https://bugs.webkit.org/show_bug.cgi?id=74550
2207
2208         Reviewed by Sam Weinig.
2209
2210         Re-enable tests.
2211
2212         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2213
2214 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
2215
2216         [Qt] Test fonts are not used with Qt5
2217         https://bugs.webkit.org/show_bug.cgi?id=72513
2218
2219         My last unreviewed buildfix for this crazy bug.
2220
2221         * qmake/mkspecs/features/features.prf:
2222
2223 2011-12-14  Anders Carlsson  <andersca@apple.com>
2224
2225         Another attempt at fixing the Windows build.
2226
2227         Disable all the tests until I can figure out what's going on here.
2228
2229         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2230
2231 2011-12-14  Anders Carlsson  <andersca@apple.com>
2232
2233         Fix the Windows build.
2234
2235         Disable some of the tests for now.
2236
2237         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2238
2239 2011-12-14  Anders Carlsson  <andersca@apple.com>
2240
2241         bind should handle member functions
2242         https://bugs.webkit.org/show_bug.cgi?id=74529
2243
2244         Reviewed by Sam Weinig.
2245
2246         Add tests.
2247
2248         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2249         (TestWebKitAPI::A::A):
2250         (TestWebKitAPI::A::f):
2251         (TestWebKitAPI::A::addF):
2252         (TestWebKitAPI::TEST):
2253
2254 2011-12-14  Anders Carlsson  <andersca@apple.com>
2255
2256         Add unary and binary bind overloads
2257         https://bugs.webkit.org/show_bug.cgi?id=74524
2258
2259         Reviewed by Sam Weinig.
2260
2261         Add tests.
2262
2263         * TestWebKitAPI/Tests/WTF/Functional.cpp:
2264         (TestWebKitAPI::TEST):
2265         (TestWebKitAPI::multiplyByTwo):
2266         (TestWebKitAPI::multiplyByOneAndAHalf):
2267         (TestWebKitAPI::multiply):
2268         (TestWebKitAPI::subtract):
2269
2270 2011-12-14  Holger Hans Peter Freyther  <holger@moiji-mobile.com>
2271
2272         [Qt] Test fonts are not used with Qt5
2273         https://bugs.webkit.org/show_bug.cgi?id=72513
2274
2275         MIPS and SH4 buildfix after r102776 and r102795.
2276
2277         Reviewed by Csaba Osztrogonác.
2278
2279         * qmake/mkspecs/features/features.prf:
2280
2281 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
2282
2283         [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
2284
2285         * qmake/mkspecs/features/features.prf:
2286
2287 2011-12-14  Andreas Kling  <kling@webkit.org>
2288
2289         Make my e-mail address a little more awesome.
2290
2291         * Scripts/webkitpy/common/config/committers.py:
2292
2293 2011-12-14  Csaba Osztrogonác  <ossy@webkit.org>
2294
2295         [Qt] Rollout r102769, because it broke Qt-4.8 builds.
2296
2297         * qmake/mkspecs/features/webcore.prf:
2298
2299 2011-12-14  Balazs Kelemen  <kbalazs@webkit.org>
2300
2301         [Qt] Test fonts are not used with Qt5
2302         https://bugs.webkit.org/show_bug.cgi?id=72513
2303
2304         Reviewed by Simon Hausmann.
2305
2306         Don't depend on Q_WS_X11 anymore since it's not the Qt5
2307         way to detect the platform. Make the guards depend
2308         on our own configtest for fontconfig. For Qt4 we can still
2309         use the preassumption that we have it on Linux.
2310
2311         * DumpRenderTree/qt/DumpRenderTree.pro:
2312         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2313         (WebCore::DumpRenderTree::open):
2314         (WebCore::DumpRenderTree::initializeFonts):
2315         * DumpRenderTree/qt/DumpRenderTreeQt.h:
2316         * DumpRenderTree/qt/main.cpp:
2317         (main): Additionally remove a nonsense piece of code that was
2318         trying to reset the font settings - which is not necessary -
2319         after we have already returned from main.
2320         * WebKitTestRunner/InjectedBundle/Target.pri:
2321         * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
2322         (WTR::activateFonts):
2323         * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
2324         from WTR. It is not needed. We set up the fonts via the injected bundle.
2325         * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
2326         (main):
2327         * qmake/config.tests/fontconfig/fontconfig.pro: Added.
2328         * qmake/mkspecs/features/features.prf:
2329         * qmake/sync.profile:
2330
2331 2011-12-14  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2332
2333         [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
2334
2335         Followup to r102679
2336
2337         https://bugs.webkit.org/show_bug.cgi?id=74413
2338
2339         Reviewed by Simon Hausmann.
2340
2341         * qmake/mkspecs/features/webcore.prf:
2342
2343 2011-12-14  Pierre Rossi  <pierre.rossi@gmail.com>
2344
2345         [Qt] Mobile theme could use a little refresh
2346         https://bugs.webkit.org/show_bug.cgi?id=74293
2347
2348         Have MiniBrowser use the mobile theme when not
2349         passed --desktop.
2350
2351         Reviewed by Kenneth Rohde Christiansen.
2352
2353         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2354         (MiniBrowserApplication::handleUserOptions):
2355
2356 2011-12-14  João Paulo Rechi Vita  <jprvita@openbossa.org>
2357
2358         [Qt] [Gardening] Remove qt-4.7 layout tests dir
2359         https://bugs.webkit.org/show_bug.cgi?id=74426
2360
2361         Building trunk now depends on Qt >= 4.8, so no need to keep this directory
2362         on the tree.
2363
2364         Reviewed by Csaba Osztrogonác.
2365
2366         * Scripts/webkitpy/layout_tests/port/qt.py:
2367         (QtPort.qt_version):
2368         (QtPort.baseline_search_path):
2369         (QtPort._skipped_file_search_paths):
2370         * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
2371         (QtPortTest._assert_search_path):
2372
2373 2011-12-14  Kentaro Hara  <haraken@chromium.org>
2374
2375         [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
2376         through parameter passing
2377         https://bugs.webkit.org/show_bug.cgi?id=74485
2378
2379         Reviewed by Ryosuke Niwa.
2380
2381         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
2382         manner. This bug is one of the incremental refactorings to remove all top-level
2383         code and global variables from prepare-ChangeLog. In this patch,
2384         we make the following global variables be used only through parameter passing.
2385             - $isGit
2386             - $isSVN
2387
2388         * Scripts/prepare-ChangeLog:
2389         (generateFunctionLists):
2390         (printDiff):
2391         (diffFromToString):
2392         (diffCommand):
2393         (statusCommand):
2394         (createPatchCommand):
2395         (diffHeaderFormat):
2396         (generateFileList):
2397         (isAddedStatus):
2398         (isConflictStatus):
2399         (statusDescription):
2400         (extractLineRange):
2401
2402 2011-12-14  Alexander Færøy  <alexander.faeroy@nokia.com>
2403
2404         [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
2405         https://bugs.webkit.org/show_bug.cgi?id=74417
2406
2407         Reviewed by Simon Hausmann.
2408
2409         Based on original patch by Kenneth Christiansen.
2410
2411         Already covered by current tests.
2412
2413         * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
2414         (WebCore::DumpRenderTree::DumpRenderTree):
2415         (WebCore::DumpRenderTree::~DumpRenderTree):
2416         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2417         (LayoutTestController::setMockDeviceOrientation):
2418
2419 2011-12-03  Philippe Normand  <pnormand@igalia.com>
2420
2421         [GTK] Bad text rendering since r101343
2422         https://bugs.webkit.org/show_bug.cgi?id=73744
2423
2424         Reviewed by Martin Robinson.
2425
2426         Turn cairo hint metrics off for better font metrics reporting in
2427         the tests. This is especially important for SVG.
2428
2429         * DumpRenderTree/gtk/DumpRenderTree.cpp:
2430         (initializeGtkFontSettings):
2431         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
2432         (WTR::initializeGtkSettings):
2433
2434 2011-12-13  Kentaro Hara  <haraken@chromium.org>
2435
2436         [Refactoring] Remove several global variables from prepare-ChangeLog
2437         https://bugs.webkit.org/show_bug.cgi?id=74389
2438
2439         Reviewed by David Kilzer.
2440
2441         We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
2442         manner. This bug is one of the incremental refactorings to remove all top-level
2443         code and global variables from prepare-ChangeLog. In this patch,
2444         we make the following global variables being used only through parameter passing.
2445             - %paths
2446             - $changedFiles
2447             - $conflictFiles
2448             - $functionLists
2449             - $bugURL
2450
2451         * Scripts/prepare-ChangeLog:
2452         (findChangeLogs):
2453         (generateNewChangeLogs):
2454         (processPaths):
2455         (generateFileList):
2456         (firstDirectoryOrCwd):
2457
2458 2011-12-13  Anders Carlsson  <andersca@apple.com>
2459
2460         Add a very bare-bones implementation of bind and Function to WTF
2461         https://bugs.webkit.org/show_bug.cgi?id=74462
2462
2463         Reviewed by Sam Weinig.
2464
2465         Add basic tests for WTF::Function and WTF::bind.
2466
2467         * TestWebKitAPI/TestWebKitAPI.gypi:
2468         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2469         * TestWebKitAPI/Tests/Functional.cpp: Added.
2470         (TestWebKitAPI::returnFortyTwo):
2471         (TestWebKitAPI::TEST):
2472         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
2473
2474 2011-12-13  Robin Dunn  <robin@alldunn.com>
2475
2476         [wx] Add a URL argument to wxWebView constructor.
2477         https://bugs.webkit.org/show_bug.cgi?id=74316
2478         
2479         Reviewed by Kevin Ollivier.
2480
2481         * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
2482         (MyApp::OnInit):
2483         * wx/browser/browser.cpp:
2484         (MyApp::OnInit):
2485
2486 2011-12-13  Raphael Kubo da Costa  <kubo@profusion.mobi>
2487
2488         watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
2489         https://bugs.webkit.org/show_bug.cgi?id=74430
2490
2491         Reviewed by David Levin.
2492
2493         * Scripts/webkitpy/common/config/watchlist:
2494
2495 2011-12-13  Peter Beverloo  <peter@chromium.org>
2496
2497         [Chromium] Pull in FreeType and decrease check-out complexity for Android
2498         https://bugs.webkit.org/show_bug.cgi?id=74401
2499
2500         Decrease the check-out complexity by removing the need to first run
2501         "update-webkit-chromium --chromium" prior to running it with
2502         "--chromium-android", which was caused by an unversioned third_party/
2503         directory being created. This moves the Android NDK to Source/WebKit/
2504         chromium/, coming from third_party/ in that directory.
2505
2506         Reviewed by Adam Barth.
2507
2508         * Scripts/update-webkit-chromium:
2509         * Scripts/webkitdirs.pm:
2510         (buildChromiumMakefile):
2511
2512 2011-12-13  Andy Wingo  <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
2513
2514         build-jsc passing incorrect args to buildGtkProject
2515         https://bugs.webkit.org/show_bug.cgi?id=74308
2516
2517         Reviewed by Gustavo Noronha Silva.
2518
2519         * Scripts/build-webkit: Instead of invoking buildGtkProject with
2520         another argument about webkit2, unshift a --disable-webkit2
2521         argument onto the buildArgs.
2522         * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
2523         arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
2524         and build-jsc are run one after the other.
2525
2526 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
2527
2528         [Qt] REGRESSION(102679): It broke Qt5-WK1 build
2529         https://bugs.webkit.org/show_bug.cgi?id=74413
2530
2531         Unreviewed buildfix.
2532
2533         * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
2534
2535 2011-12-13  Csaba Osztrogonác  <ossy@webkit.org>
2536
2537         [Qt] Unreviewed speculativ debug buildfix after r102679.
2538
2539         * QtTestBrowser/QtTestBrowser.pro:
2540         * QtTestBrowser/main.cpp:
2541
2542 2011-12-13  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2543
2544         [Qt] Get rid of layering violations in includes
2545
2546         WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
2547         in the webcore.prf, but rather in each target that specificly needs
2548         headers in these location. We used to include them directly in webcore
2549         since we had layering violations between WebCore and WebKit, but now
2550         that they are gone there's no reason to do that.
2551
2552         Reviewed by Simon Hausmann.
2553
2554         * DumpRenderTree/qt/DumpRenderTree.pro:
2555         * QtTestBrowser/launcherwindow.h:
2556         * WebKitTestRunner/InjectedBundle/Target.pri:
2557         * qmake/mkspecs/features/webcore.prf:
2558         * qmake/mkspecs/features/webkit2.prf:
2559
2560 2011-12-13  János Badics  <dicska@gmail.com>
2561
2562         [NRWT] It crashes intermittently when there are WebProcess crashes
2563         https://bugs.webkit.org/show_bug.cgi?id=73451
2564
2565         Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
2566
2567         Reviewed by Kenneth Rohde Christiansen.
2568
2569         * Scripts/webkitpy/layout_tests/port/server_process.py:
2570         (ServerProcess._check_for_crash):
2571
2572 2011-12-13  Carlos Garcia Campos  <cgarcia@igalia.com>
2573
2574         Unreviewed. Fix GTK+ API docs build.
2575
2576         * gtk/generate-gtkdoc:
2577         (get_webkit2_options): Ignore WebKitUIClient since it's private
2578         API.
2579
2580 2011-12-13  Kenichi Ishibashi  <bashi@chromium.org>
2581
2582         Reviewed, removed one of my email addresses to use the apprpriate one.
2583
2584         * Scripts/webkitpy/common/config/committers.py:
2585
2586 2011-12-12  Ádám Kallai  <Kallai.Adam@stud.u-szeged.hu>
2587
2588         [Qt] Fix skip list search path and expected file search path in ORWT
2589         https://bugs.webkit.org/show_bug.cgi?id=74281
2590
2591         Expected file search path fixed.
2592
2593         Print all used skipped list and expected search path in verbose mode similar to NRWT.
2594
2595         Reviewed by Csaba Osztrogonác.
2596
2597         * Scripts/old-run-webkit-tests:
2598         (buildPlatformResultHierarchy):
2599         (buildPlatformTestHierarchy):
2600         (readSkippedFiles):
2601
2602 2011-12-12  Nándor Huszka  <huszka.nandor@stud.u-szeged.hu>
2603
2604         [Qt] Missing layoutTestController.dumpWillCacheResponse
2605         https://bugs.webkit.org/show_bug.cgi?id=74287
2606
2607         Reviewed by Csaba Osztrogonác.
2608
2609         * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
2610         (LayoutTestController::reset):
2611         (LayoutTestController::dumpWillCacheResponse):
2612         * DumpRenderTree/qt/LayoutTestControllerQt.h:
2613
2614 2011-12-12  Martin Robinson  <mrobinson@igalia.com>
2615
2616         [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
2617         https://bugs.webkit.org/show_bug.cgi?id=73771
2618
2619         Reviewed by Gustavo Noronha Silva.
2620
2621         When using a fallback font during testing, always use DejaVu Sans. This prevents
2622         falling back to DejaVu Serif on some systems.
2623
2624         * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
2625
2626 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
2627
2628         Add myself as a committer
2629
2630         * Scripts/webkitpy/common/config/committers.py:
2631
2632 2011-12-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>
2633
2634         [Qt] [WK2] Support customizing popup menus with QML
2635         https://bugs.webkit.org/show_bug.cgi?id=73560
2636
2637         Reviewed by Tor Arne Vestbø.
2638
2639         Add an Item Selector to our WebView using the experimental API.
2640
2641         * MiniBrowser/qt/MiniBrowser.pro:
2642         * MiniBrowser/qt/MiniBrowser.qrc:
2643         * MiniBrowser/qt/qml/BrowserWindow.qml:
2644         * MiniBrowser/qt/qml/ItemSelector.qml: Added.
2645
2646 2011-12-12  Alexander Færøy  <alexander.faeroy@nokia.com>
2647
2648         [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
2649         https://bugs.webkit.org/show_bug.cgi?id=74283
2650
2651         Reviewed by Simon Hausmann.
2652
2653         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2654         (MiniBrowserApplication::sendTouchEvent):
2655
2656 2011-12-12  Kentaro Hara  <haraken@chromium.org>
2657
2658         [Refactoring] In prepare-ChangeLog, move into a method the top-level code
2659         to show ChangeLogs diff and open ChangeLogs in an editor
2660         https://bugs.webkit.org/show_bug.cgi?id=74266
2661
2662         Reviewed by Ryosuke Niwa.
2663
2664         We are planning to write unit-tests for prepare-ChangeLog
2665         in a run-leaks_unittest manner. This patch is one of the incremental
2666         refactorings to remove all top-level code and global variables from
2667         prepare-ChangeLog.
2668
2669         * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
2670         Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
2671         Renamed @changed_files to @changedFiles.
2672         Renamed %conflict_files to %conflictFiles.
2673         (generateFunctionLists):
2674         (printDiff):
2675         (openChangeLogs):
2676
2677 2011-12-11  Kentaro Hara  <haraken@chromium.org>
2678
2679         [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
2680         https://bugs.webkit.org/show_bug.cgi?id=74257
2681
2682         Reviewed by Ryosuke Niwa.
2683
2684         We are planning to write unit-tests for prepare-ChangeLog
2685         in a run-leaks_unittest/ manner. This patch is one of the incremental
2686         refactorings to remove all top-level code and global variables from
2687         prepare-ChangeLog.
2688
2689         * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
2690         into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
2691         into resolveConflictedChangeLogs().
2692         (getLatestChangeLogs):
2693         (resolveConflictedChangeLogs):
2694
2695 2011-12-11  Kentaro Hara  <haraken@chromium.org>
2696
2697         [Refactoring] Move top-level code to generate a new ChangeLog into a method
2698         https://bugs.webkit.org/show_bug.cgi?id=74253
2699
2700         Reviewed by David Kilzer.
2701
2702         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
2703         which requires to remove top-level code and global variables. This patch is one of
2704         the incremental refactorings for that.
2705
2706         * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
2707         (generateFunctionLists):
2708         (findChangeLogs):
2709         (generateNewChangeLogs):
2710         (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
2711
2712 2011-12-10  Kentaro Hara  <haraken@chromium.org>
2713
2714         [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
2715         https://bugs.webkit.org/show_bug.cgi?id=74175
2716
2717         Reviewed by Ryosuke Niwa.
2718
2719         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
2720         This requires to remove top-level code. This patch is one of the incremental refactorings
2721         for that.
2722
2723         * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
2724         (findChangeLogs):
2725
2726 2011-12-10  Andreas Kling  <kling@webkit.org>
2727
2728         Add my Apple e-mail to committers.py.
2729
2730         * Scripts/webkitpy/common/config/committers.py:
2731
2732 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
2733
2734         chromium win build: revert build_webkit_exes_from_webkit_gyp change
2735         https://bugs.webkit.org/show_bug.cgi?id=74225
2736
2737         This change sets build_webkit_exes_from_webkit_gyp back to 1;
2738         the "All.gyp" solution doesn't work on windows.
2739
2740         * Scripts/webkitdirs.pm:
2741         (buildChromium):
2742
2743 2011-12-09  Hugo Parente Lima  <hugo.lima@openbossa.org>
2744
2745         [Qt] Click's count is limited to three continuous clicks.
2746         https://bugs.webkit.org/show_bug.cgi?id=45666
2747
2748         Reviewed by Kenneth Rohde Christiansen.
2749
2750         Update m_time at every call to leapForward, so double clicks
2751         event are correctly sent by EventSender.
2752
2753         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
2754         (WTR::EventSenderProxy::updateClickCountForButton):
2755         (WTR::EventSenderProxy::leapForward):
2756
2757 2011-12-09  Kentaro Hara  <haraken@chromium.org>
2758
2759         [Refactoring] Reduce top-level code in prepare-ChangeLog
2760         https://bugs.webkit.org/show_bug.cgi?id=74172
2761
2762         Reviewed by Ryosuke Niwa.
2763
2764         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
2765         This requires to remove top-level code. This patch is one of the incremental refactorings
2766         for that.
2767
2768         * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
2769         (generateFunctionLists):
2770
2771 2011-12-09  Sam Weinig  <sam@webkit.org>
2772
2773         Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
2774         https://bugs.webkit.org/show_bug.cgi?id=74218
2775
2776         Reviewed by Anders Carlsson.
2777
2778         Add a test of the WKConnectionRef API.
2779
2780         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2781         * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
2782         (TestWebKitAPI::didCreateConnection):
2783         (TestWebKitAPI::connectionDidReceiveMessage):
2784         (TestWebKitAPI::connectionDidClose):
2785         (TestWebKitAPI::TEST):
2786         * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
2787         (TestWebKitAPI::connectionDidReceiveMessage):
2788         (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
2789         (TestWebKitAPI::WKConnectionTest::initialize):
2790
2791 2011-12-09  David Levin  <levin@chromium.org>
2792
2793         Hash* iterators should allow comparison between const and const versions.
2794         https://bugs.webkit.org/show_bug.cgi?id=73370
2795
2796         Reviewed by Darin Adler.
2797
2798         * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
2799         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
2800         * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
2801         * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
2802         (TestWebKitAPI::TEST): Add a test for the new functionality.
2803
2804 2011-12-09  Dirk Pranke  <dpranke@chromium.org>
2805
2806         chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
2807         https://bugs.webkit.org/show_bug.cgi?id=74212
2808
2809         Reviewed by Tony Chang.
2810
2811         The change introduced in r102201 to split the executables out of
2812         WebKit.gyp apparently doesn't work right on Windows, since
2813         WebKit.gyp and Tools.gyp refer to dependent projects by
2814         different relative paths (it appears gyp doesn't normalize the
2815         paths). This change moves Tools.gyp to be in the same directory
2816         as WebKit.gyp (and All.gyp), which should fix this and
2817         conveniently will also solve the problem of how to add Tools.gyp
2818         to the chromium DEPS file.
2819
2820         * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
2821
2822 2011-12-09  Kentaro Hara  <haraken@chromium.org>
2823
2824         [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
2825         https://bugs.webkit.org/show_bug.cgi?id=74173
2826
2827         Reviewed by Ryosuke Niwa.
2828
2829         The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
2830         This requires to remove top-level code. This patch is one of the incremental refactorings
2831         for that.
2832
2833         * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
2834         (fetchBugDescriptionFromURL):
2835
2836 2011-12-09  Tony Chang  <tony@chromium.org>
2837
2838         Switch the chromium mac bots to using skia test results
2839         https://bugs.webkit.org/show_bug.cgi?id=74201
2840
2841         Reviewed by Ryosuke Niwa.
2842
2843         This is reverting http://trac.webkit.org/changeset/97781 and changing
2844         the name in master.cfg to no longer have cg in the name.
2845
2846         * BuildSlaveSupport/build.webkit.org-config/config.json:
2847         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2848         (appendCustomBuildFlags):
2849         (RunWebKitTests.start):
2850
2851 2011-12-09  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>
2852
2853         [Qt] Remove a wrongly placed ASSERT.
2854
2855         Reviewed by Tor Arne Vestbø.
2856
2857         * MiniBrowser/qt/MiniBrowserApplication.cpp:
2858         (MiniBrowserApplication::notify):
2859
2860 2011-12-09  Cary Clark  <caryclark@google.com>
2861
2862         layout_test update to accommodate new use_skia=1 default on Chromium-Mac
2863         https://bugs.webkit.org/show_bug.cgi?id=74118
2864
2865         Reviewed by Adam Barth.
2866
2867         * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
2868         (get):
2869         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
2870         (ChromiumMacPort.__init__):
2871         * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
2872         (ChromiumMacPortTest.test_versions):
2873         (ChromiumMacPortTest.test_graphics_type):
2874
2875 2011-12-09  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>
2876
2877         [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
2878
2879         The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
2880         this failed when moving files in the source tree, as the .d file would contain
2881         stale dependencies on the old source file location. By keeping the object files
2882         (and hence the depdendency files) in a proper tree structure inside the objects
2883         directory we can prevent this failure.
2884
2885         A side benefit is that we can also have objects with the same name inside the
2886         same project.
2887
2888         Reviewed by Simon Hausmann.
2889
2890         * qmake/mkspecs/features/unix/default_pre.prf:
2891
2892 2011-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2893
2894         Unreviewed. Update unit test after r102412.
2895
2896         * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
2897         (IRCCommandTest.test_whois):
2898
2899 2011-12-09  Kentaro Hara  <haraken@chromium.org>
2900
2901         REGRESSION(r102105): run-bindings-tests should output full diff results
2902         https://bugs.webkit.org/show_bug.cgi?id=74166
2903
2904         Reviewed by Adam Barth.
2905
2906         Since r102105, the output of run-bindings-tests is truncated to 500 characters.
2907         run-bindings-tests should output full diff results.
2908
2909         * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
2910         (BindingsTests.generate_from_idl):
2911         (BindingsTests.generate_supplemental_dependency):
2912         (BindingsTests.detect_changes):
2913
2914 2011-12-09  Simon Hausmann  <simon.hausmann@nokia.com>
2915
2916         [Qt] Fix compilation with newly separated Qt 5 QtQuick module
2917         https://bugs.webkit.org/show_bug.cgi?id=73990
2918
2919         Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
2920
2921         Fix QtQuick includes after move from QtDeclarative to QtQuick.
2922
2923         * MiniBrowser/qt/BrowserWindow.h:
2924         * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
2925
2926 2011-12-08  Adam Klein  <adamk@chromium.org>
2927
2928         [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
2929         https://bugs.webkit.org/show_bug.cgi?id=73492
2930
2931         Reviewed by Adam Barth.
2932
2933         Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
2934         keypress event without any script on the stack.
2935
2936         * DumpRenderTree/chromium/EventSender.cpp:
2937         (EventSender::EventSender):
2938         (EventSender::keyDown):
2939         (KeyDownTask::KeyDownTask):
2940         (KeyDownTask::runIfValid):
2941         (EventSender::scheduleAsynchronousKeyDown):
2942         * DumpRenderTree/chromium/EventSender.h:
2943
2944 2011-12-08  Hayato Ito  <hayato@chromium.org>
2945
2946         [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
2947         https://bugs.webkit.org/show_bug.cgi?id=73980
2948
2949         Reviewed by Tony Chang.
2950
2951         * gdb/webkit.py:
2952         (guess_string_length):
2953         (ustring_to_string):
2954         (lstring_to_string):
2955         (LCharStringPrinter):
2956         (LCharStringPrinter.to_string):
2957         (WTFStringImplPrinter.get_length):
2958         (WTFStringImplPrinter.to_string):
2959         (WTFStringImplPrinter.is_8bit):
2960         (WTFStringPrinter.stringimpl_ptr):
2961         (WTFStringPrinter.get_length):
2962         (WTFStringPrinter.to_string):
2963         (add_pretty_printers.lookup_function):
2964
2965 2011-12-08  Pierre Rossi  <pierre.rossi@gmail.com>
2966
2967         Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
2968         https://bugs.webkit.org/show_bug.cgi?id=73916
2969
2970         Reviewed by Kent Tamura.
2971
2972         * qmake/mkspecs/features/features.prf:
2973
2974 2011-12-08  Adrienne Walker  <enne@google.com>
2975
2976         Unreviewed contributor additions to committers.py.
2977
2978         * Scripts/webkitpy/common/config/committers.py:
2979
2980 2011-12-08  David Reveman  <reveman@chromium.org>
2981
2982         [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
2983         https://bugs.webkit.org/show_bug.cgi?id=74017
2984
2985         Reviewed by James Robinson.
2986         
2987         Add support for command line flag enable-per-tile-painting in DumpRenderTree.
2988
2989         * DumpRenderTree/chromium/DumpRenderTree.cpp:
2990         (main):
2991         * DumpRenderTree/chromium/TestShell.cpp:
2992         (TestShell::TestShell):
2993         (TestShell::resetWebSettings):
2994         * DumpRenderTree/chromium/TestShell.h:
2995         (TestShell::setAcceleratedPaintingEnabled):
2996         (TestShell::setPerTilePaintingEnabled):
2997         * DumpRenderTree/chromium/WebPreferences.cpp:
2998         (WebPreferences::reset):
2999         (WebPreferences::applyTo):
3000         * DumpRenderTree/chromium/WebPreferences.h:
3001         * Scripts/webkitpy/layout_tests/port/chromium.py:
3002         (ChromiumDriver._wrapper_options):
3003         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3004         (parse_args):
3005
3006 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
3007
3008         create a "SystemHost" object for webkitpy to slim down the Host object
3009         https://bugs.webkit.org/show_bug.cgi?id=72680
3010
3011         Reviewed by Eric Siedel.
3012
3013         This creates a SystemHost object that other objects that should
3014         only have dependencies on functionality in webkitpy.common.system
3015         can use; this will allow them to not require a full Host.
3016
3017         * Scripts/webkitpy/common/host.py:
3018         * Scripts/webkitpy/common/host_mock.py:
3019         * Scripts/webkitpy/common/system/systemhost.py: Added.
3020         * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
3021
3022 2011-12-08  Chris Fleizach  <cfleizach@apple.com>
3023
3024         AX: platform/mac/accessibility/search-with-frames.html crashes
3025         https://bugs.webkit.org/show_bug.cgi?id=74093
3026
3027         Reviewed by Darin Adler.
3028
3029         Take care of the case when an incoming element is null.
3030
3031         * DumpRenderTree/AccessibilityUIElement.cpp:
3032         (uiElementForSearchPredicateCallback):
3033         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3034         (AccessibilityUIElement::uiElementForSearchPredicate):
3035         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3036         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
3037
3038 2011-12-08  Alexander Færøy  <ahf@0x90.dk>
3039
3040         [Qt] Visualize mock point ID's in the MiniBrowser
3041         https://bugs.webkit.org/show_bug.cgi?id=74098
3042
3043         Reviewed by Tor Arne Vestbø.
3044
3045         * MiniBrowser/qt/BrowserWindow.cpp:
3046         (BrowserWindow::updateVisualMockTouchPoints):
3047         * MiniBrowser/qt/qml/MockTouchPoint.qml:
3048
3049 2011-12-08  Dominic Mazzoni  <dmazzoni@google.com>
3050
3051         Accessibility: AccessibilityController should support listening to notifications on all elements.
3052         https://bugs.webkit.org/show_bug.cgi?id=72866
3053
3054         Adds addNotificationListener and removeNotificationListener methods
3055         to AccessibilityController, to listen to notifications on any element
3056         rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
3057         implementations are all contained in this change.
3058
3059         On Mac, refactors AccessibilityNotificationHandler into its own
3060         source file that can be used by both AccessibilityController and
3061         AccessibilityUIElement. (Both DRT and WKTR.)
3062
3063         Reviewed by Chris Fleizach.
3064
3065         * DumpRenderTree/AccessibilityController.cpp:
3066         (addNotificationListenerCallback):
3067         (removeNotificationListenerCallback):
3068         (AccessibilityController::getJSClass):
3069         * DumpRenderTree/AccessibilityController.h:
3070         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3071         * DumpRenderTree/chromium/AccessibilityController.cpp:
3072         (AccessibilityController::AccessibilityController):
3073         (AccessibilityController::notificationReceived):
3074         (AccessibilityController::addNotificationListenerCallback):
3075         (AccessibilityController::removeNotificationListenerCallback):
3076         * DumpRenderTree/chromium/AccessibilityController.h:
3077         * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
3078         (AccessibilityController::addNotificationListener):
3079         (AccessibilityController::removeNotificationListener):
3080         * DumpRenderTree/mac/AccessibilityControllerMac.mm:
3081         (AccessibilityController::~AccessibilityController):
3082         (AccessibilityController::addNotificationListener):
3083         (AccessibilityController::removeNotificationListener):
3084         * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
3085         * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
3086         (-[NSString createJSStringRef]):
3087         (-[AccessibilityNotificationHandler init]):
3088         (-[AccessibilityNotificationHandler setPlatformElement:]):
3089         (-[AccessibilityNotificationHandler dealloc]):
3090         (-[AccessibilityNotificationHandler setCallback:]):
3091         (-[AccessibilityNotificationHandler startObserving]):
3092         (-[AccessibilityNotificationHandler _notificationReceived:]):
3093         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
3094         (AccessibilityUIElement::addNotificationListener):
3095         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
3096         (notificationListenerProc):
3097         (AccessibilityController::addNotificationListener):
3098         (AccessibilityController::removeNotificationListener):
3099         (AccessibilityController::winNotificationReceived):
3100         (AccessibilityController::winAddNotificationListener):
3101         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
3102         (AccessibilityUIElement::addNotificationListener):
3103         * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
3104         (WTR::AccessibilityController::addNotificationListener):
3105         (WTR::AccessibilityController::removeNotificationListener):
3106         * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
3107         (WTR::AccessibilityController::logAccessibilityEvents):
3108         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
3109         (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
3110         * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
3111         (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
3112         * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
3113         * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
3114         (WTR::AccessibilityController::addNotificationListener):
3115         (WTR::AccessibilityController::removeNotificationListener):
3116         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
3117         * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
3118         (-[NSString createJSStringRef]):
3119         (-[AccessibilityNotificationHandler init]):
3120         (-[AccessibilityNotificationHandler setPlatformElement:]):
3121         (-[AccessibilityNotificationHandler dealloc]):
3122         (-[AccessibilityNotificationHandler setCallback:]):
3123         (-[AccessibilityNotificationHandler startObserving]):
3124         (-[AccessibilityNotificationHandler _notificationReceived:]):
3125         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
3126         (WTR::AccessibilityUIElement::AccessibilityUIElement):
3127         (WTR::AccessibilityUIElement::verticalScrollbar):
3128         (WTR::AccessibilityUIElement::addNotificationListener):
3129         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3130
3131 2011-12-08  Csaba Osztrogonác  <ossy@webkit.org>
3132
3133         [Qt][WK2] Unreviewed buildfix after r102352.
3134
3135         * qmake/mkspecs/features/webkit2.prf:
3136
3137 2011-12-08  Adam Roben  <aroben@apple.com>
3138
3139         Make finding crash logs by PID work on Snow Leopard
3140
3141         Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
3142         were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
3143         read the first line of the crash log and pull the PID out of there.
3144
3145         Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
3146         Snow Leopard
3147
3148         Reviewed by Darin Adler.
3149
3150         * Scripts/webkitpy/common/system/crashlogs.py:
3151         (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
3152         name and PID for the log, rather than checking the Lion-only app_description extended
3153         attribute. We now also reject the log if the process name doesn't match what we expect.
3154
3155         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3156         (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
3157         PID.
3158         (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
3159         unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
3160         (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
3161         the new make_mock_crash_report_darwin function. Also added tests for files that can't be
3162         read, files that actually contain a crash log for some other process, and files that are
3163         misformatted.
3164
3165         * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
3166         unused.
3167
3168         * Scripts/webkitpy/common/system/filesystem_mock.py:
3169         (MockFileSystem.__init__): Removed xattr support, which is now unused.
3170         (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
3171         ReadableTextFileObject. This function was completely broken before!
3172         (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
3173         bugs like the above.
3174         (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
3175         things like readline() and seek().
3176
3177         (ReadableTextFileObject.close):
3178         (ReadableTextFileObject.read):
3179         Added. We override the superclass implementation to account for using a StringIO object.
3180
3181         (ReadableTextFileObject.readline):
3182         (ReadableTextFileObject.seek):
3183         Added. These just call through to StringIO.
3184
3185         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3186         (MainTest.test_crash_log):
3187         (MainTest.test_web_process_crash_log):
3188         Changed to use make_mock_crash_report_darwin.
3189
3190 2011-12-06  Jon Lee  <jonlee@apple.com>
3191
3192         [WK2] Add permissions support (73960)
3193         https://bugs.webkit.org/show_bug.cgi?id=73960
3194         <rdar://problem/10357008>
3195
3196         Reviewed by Darin Adler.
3197
3198         Add null function item to comply with added callback to WKPageUIClient.
3199
3200         * MiniBrowser/mac/BrowserWindowController.m:
3201         (-[BrowserWindowController awakeFromNib]):
3202         * WebKitTestRunner/TestController.cpp:
3203         (WTR::TestController::createOtherPage):
3204         (WTR::TestController::initialize):
3205
3206 2011-12-08  Alexander Færøy  <alexander.faeroy@nokia.com>
3207
3208         [Qt] Visualize mock points in the Qt MiniBrowser
3209         https://bugs.webkit.org/show_bug.cgi?id=74074
3210
3211         Reviewed by Tor Arne Vestbø.
3212
3213         * MiniBrowser/qt/BrowserWindow.cpp:
3214         (BrowserWindow::updateVisualMockTouchPoints):
3215         * MiniBrowser/qt/BrowserWindow.h:
3216         * MiniBrowser/qt/MiniBrowser.qrc:
3217         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3218         (MiniBrowserApplication::notify):
3219         (MiniBrowserApplication::sendTouchEvent):
3220         * MiniBrowser/qt/MiniBrowserApplication.h:
3221         * MiniBrowser/qt/icons/touchpoint.png: Added.
3222         * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
3223
3224 2011-12-08  Simon Hausmann  <simon.hausmann@nokia.com>
3225
3226         [Qt] WebKitTestRunner crashes with debug builds
3227         https://bugs.webkit.org/show_bug.cgi?id=74090
3228
3229         Reviewed by Tor Arne Vestbø.
3230
3231         * WebKitTestRunner/qt/TestControllerQt.cpp:
3232         (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
3233         to ensure WTF/JSC threading is initialized.
3234
3235 2011-12-08  Dirk Pranke  <dpranke@chromium.org>
3236
3237         fix build-webkit --chromium after breakage in r102201
3238         https://bugs.webkit.org/show_bug.cgi?id=74031
3239
3240         Reviewed by Tony Chang.
3241
3242         * Scripts/webkitdirs.pm:
3243         (buildChromium):
3244
3245 2011-12-08  Kentaro Hara  <haraken@chromium.org>
3246
3247         Unreviewed, rolling out r102280.
3248         http://trac.webkit.org/changeset/102280
3249         https://bugs.webkit.org/show_bug.cgi?id=74031
3250
3251         Chromium/Windows build is broken
3252
3253         * Scripts/webkitdirs.pm:
3254         (buildChromium):
3255
3256 2011-12-08  Nayan Kumar K  <nayankk@motorola.com>
3257
3258         Adding myself to committers list.
3259
3260         Unreviewed.
3261
3262         * Scripts/webkitpy/common/config/committers.py:
3263
3264 2011-12-07  Michael Saboff  <msaboff@apple.com>
3265
3266         StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
3267         https://bugs.webkit.org/show_bug.cgi?id=73995
3268
3269         Reenabled failing tests that the code part of the patch fixes.
3270
3271         Reviewed by Geoffrey Garen.
3272
3273         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3274         (TestWebKitAPI::TEST):
3275
3276 2011-12-07  MORITA Hajime  <morrita@google.com>
3277
3278         [filter-build-webkit] should not emit reset color when --no-color is given
3279         https://bugs.webkit.org/show_bug.cgi?id=73992
3280
3281         Reviewed by Daniel Bates.
3282
3283         Stop printing control sequences when --no-color is given.
3284         After this change, the filter runs nicely even on environments
3285         like Emacs compilation-mode which cannot understand the control sequence.
3286
3287         * Scripts/filter-build-webkit:
3288         (printLine):
3289
3290 2011-12-07  Eric Seidel  <eric@webkit.org>
3291
3292         Use free memory to determine if we have space for DRT instances instead of total memory
3293         https://bugs.webkit.org/show_bug.cgi?id=74021
3294
3295         Reviewed by Adam Barth.
3296
3297         This will hopefully make the Mac buildbots behave better.
3298
3299         I also reduced the expected memory needed per DRT now that
3300         we're properly accounting for the system memory in our calculations.
3301
3302         * Scripts/webkitpy/common/system/platforminfo.py:
3303         (PlatformInfo.total_bytes_memory):
3304         (PlatformInfo._compute_free_bytes_from_vm_stat_output):
3305         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3306         (MockPlatformInfo.total_bytes_memory):
3307         * Scripts/webkitpy/layout_tests/port/base.py:
3308         (Port.default_child_processes):
3309         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3310         (PortTest.test_default_child_processes):
3311
3312 2011-12-07  Dirk Pranke  <dpranke@chromium.org>
3313
3314         fix build-webkit --chromium after breakage in r102201
3315         https://bugs.webkit.org/show_bug.cgi?id=74031
3316
3317         Reviewed by Tony Chang.
3318
3319         r102201 introduced a change to the chromium build that splits
3320         the executables out of WebKit.gyp into other gyp files, and adds
3321         a new "All.gyp" that builds everything. However, I forgot to
3322         update the build script to use All.gyp.
3323
3324         * Scripts/webkitdirs.pm:
3325         (buildChromium):
3326
3327 2011-12-07  Tom Zakrajsek  <tomz@codeaurora.org>
3328
3329         Moved myself to the committers list.
3330
3331         * Scripts/webkitpy/common/config/committers.py:
3332
3333 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
3334
3335         [Qt] Fix debug shlib build with V8.
3336
3337         Reviewed by Tor Arne Vestbø.
3338
3339         * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
3340         v8 builds.
3341
3342 2011-11-30  Simon Hausmann  <simon.hausmann@nokia.com>
3343
3344         [Qt] V8 build fixes.
3345
3346         Reviewed by Tor Arne Vestbø.
3347
3348         * qmake/mkspecs/features/javascriptcore.prf: Don't add
3349         Source/Thirdparty to the include search path here.
3350         * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
3351         used when building WebCore as well as using it, because header files like
3352         GraphicsContext3D.h include stuff from ThirdParty.
3353
3354 2011-12-07  Peter Beverloo  <peter@chromium.org>
3355
3356         [Chromium] Fix project file generation for the Android bot after r102201
3357         https://bugs.webkit.org/show_bug.cgi?id=73996
3358
3359         The gyp refactoring in r102201 was didn't explicitly exclude
3360         the Android operating system in Tools/Tools.gyp, which broke
3361         as gcc_version is not defined for that configuration.
3362
3363         Reviewed by Andreas Kling.
3364
3365         * Tools.gyp:
3366
3367 2011-12-07  Vsevolod Vlasov  <vsevik@chromium.org>
3368
3369         Unreviewed. Disabled failing tests on chromium.
3370
3371         * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
3372         (TestWebKitAPI::TEST):
3373
3374 2011-12-06  Dirk Pranke  <dpranke@chromium.org>
3375
3376         binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
3377         https://bugs.webkit.org/show_bug.cgi?id=73382
3378
3379         Reviewed by Tony Chang.
3380
3381         XCode (and hence GYP) can't handle circular dependencies between
3382         files (and projects). Accordingly, although the binaries in
3383         WebKit.gyp depend on webkit_support and webkit_support depends
3384         on webkit, we don't mention the latter dependency in the file.
3385         To fix this, this change moves the binaries like DRT into a new
3386         GYP file, and modifies gyp_webkit to build from that file
3387         instead of WebKit.gyp.
3388
3389         * Tools.gyp: Added.
3390
3391 2011-12-06  Adam Roben  <aroben@apple.com>
3392
3393         Add a pid parameter to CrashLogs.find_newest_log
3394
3395         When a PID is passed, only crash logs corresponding to a crashed process with that PID are
3396         considered.
3397
3398         Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
3399         process whose crash log you want to find
3400
3401         Reviewed by Dirk Pranke.
3402
3403         * Scripts/webkitpy/common/system/crashlogs.py:
3404         (CrashLogs.find_newest_log): Added an optional pid parameter.
3405         (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
3406         candidate log's app_description extended attribute to see if that log corresponds to a
3407         crashed process with the specified PID.
3408
3409         * Scripts/webkitpy/common/system/crashlogs_unittest.py:
3410         (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
3411         contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
3412         respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
3413
3414         * Scripts/webkitpy/common/system/filesystem.py:
3415         (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
3416         systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
3417         present.
3418
3419         * Scripts/webkitpy/common/system/filesystem_mock.py:
3420         (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
3421         (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
3422         dictionary.
3423
3424         * Scripts/webkitpy/tool/commands/queries.py:
3425         (CrashLog): Added help text. Added an optional PID parameter.
3426         (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
3427
3428 2011-12-06  Adam Roben  <aroben@apple.com>
3429
3430         Wait for Crash Reporter to finish even when it lets the crashed process die quickly
3431
3432         NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
3433         alive beyond the normal timeout limit. In cases where the crashed process was able to die
3434         faster, NRWT would assume that Crash Reporter had finished even though it often was still
3435         running, which would lead to an incorrect crash log being picked up.
3436
3437         Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
3438
3439         Reviewed by Dirk Pranke.
3440
3441         * Scripts/webkitpy/layout_tests/port/server_process.py:
3442         (ServerProcess._reset):
3443         (ServerProcess.write):
3444         (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
3445         .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
3446         set_crashed.
3447
3448         (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
3449         .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
3450         we bail out of handling the failure as a timeout if we find out that the process in fact
3451         crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
3452         so.
3453         (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
3454         finish running (unless directed otherwise) so we can be sure the crash log has been saved to
3455         disk.
3456
3457         * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
3458         (TrivialMockPort.is_crash_reporter): Added.
3459
3460         * Scripts/webkitpy/layout_tests/port/webkit.py:
3461         (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
3462         that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
3463
3464 2011-12-06  Adam Barth  <abarth@webkit.org>
3465
3466         NRWT fails on unreleased versions of Mac OS X
3467         https://bugs.webkit.org/show_bug.cgi?id=72748
3468
3469         Reviewed by Dirk Pranke.
3470
3471         Hopefully this patch will make NRWT work on future versions on Mac OS X.
3472         Most of the infrastructure was already in place, but there were some
3473         asserts that failed.  I've tested this patch by haxoring the version
3474         detection logic to simulate an unknown version.  We might need to
3475         iterate based on feedback from folks with a real future version.
3476
3477         * Scripts/webkitpy/layout_tests/port/apple.py:
3478         (ApplePort.__init__):
3479             - mac-future is an allowed port_name that's used internally by
3480               webkitpy to represent future versions of Mac OS X.
3481         * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
3482         (test_versions):
3483             - Test that we don't throw exceptions when dealing with future
3484               versions of Mac OS X.
3485         * Scripts/webkitpy/layout_tests/port/webkit.py:
3486         (WebKitPort._expectations_from_skipped_files):
3487             - Demote this logging message to "debug".  It's expected that
3488               mac-future doesn't have a Skipped file.
3489         * Scripts/webkitpy/layout_tests/port/mac.py:
3490         (MacPort.__init__):
3491         * Scripts/webkitpy/layout_tests/port/win.py:
3492         (WinPort.__init__):
3493             - Re-order some code in these constructors so that
3494               self._operating_system is available to the ApplePort constructor.
3495
3496 2011-12-06  Tommy Widenflycht  <tommyw@google.com>
3497
3498         Added myself as a committer.
3499
3500         * Scripts/webkitpy/common/config/committers.py:
3501
3502 2011-12-06  Peter Beverloo  <peter@chromium.org>
3503
3504         Added myself as a committer.
3505
3506         * Scripts/webkitpy/common/config/committers.py:
3507
3508 2011-12-06  Kentaro Hara  <haraken@chromium.org>
3509
3510         [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
3511         https://bugs.webkit.org/show_bug.cgi?id=73637
3512
3513         Reviewed by Adam Barth.
3514
3515         This patch replaces subprocess.Popen() with Executive, similar to other
3516         Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
3517         works well for cases where no exception is raised, no exception is raised
3518         but diff is found, and ScriptError is raised.
3519
3520         * Scripts/run-bindings-tests:
3521         (main):
3522         * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
3523         (BindingsTests.__init__):
3524         (BindingsTests.generate_from_idl):
3525         (BindingsTests.generate_supplemental_dependency):
3526         (BindingsTests.detect_changes):
3527
3528 2011-12-05  Alexander Færøy  <alexander.faeroy@nokia.com>
3529
3530         [Qt] MiniBrowser should default to touch behavior
3531         https://bugs.webkit.org/show_bug.cgi?id=73863
3532
3533         Reviewed by Chang Shu.
3534
3535         MiniBrowser currently defaults to the traditional desktop behaviour
3536         instead of touch behaviour which is prefered.
3537
3538         * MiniBrowser/qt/BrowserWindow.cpp:
3539         (BrowserWindow::BrowserWindow):
3540         * MiniBrowser/qt/MiniBrowserApplication.cpp:
3541         (printHelp):
3542         (MiniBrowserApplication::handleUserOptions):
3543         * MiniBrowser/qt/MiniBrowserApplication.h:
3544         (WindowOptions::WindowOptions):
3545         (WindowOptions::setUseTraditionalDesktopBehavior):
3546         (WindowOptions::useTraditionalDesktopBehavior):
3547
3548 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
3549
3550         webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
3551         https://bugs.webkit.org/show_bug.cgi?id=73878
3552
3553         Reviewed by Tony Chang.
3554
3555         r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
3556         r98785 made webkit.py always use m_data16, which does not work when
3557         the string is an 8-bit string (such as KURL::string()).
3558
3559         I was not able to directly call StringImpl::is8Bit() in the Python
3560         code, so I just reproduced the implementation there.
3561
3562         * gdb/webkit.py:
3563         (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
3564         (WTFStringPrinter.to_string):
3565         (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
3566         (JSCUStringPrinter.to_string):
3567
3568 2011-12-05  Eric Seidel  <eric@webkit.org>
3569
3570         Up the "expected ram for each DRT instance" to 400MB instead of 300MB
3571         in hopes of making the Snow Leopard bot stop timing out.
3572
3573         Unreviewed.
3574
3575         * Scripts/webkitpy/layout_tests/port/base.py:
3576         (Port.default_child_processes):
3577         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3578         (PortTest.test_default_child_processes):
3579
3580 2011-12-05  Eric Seidel  <eric@webkit.org>
3581
3582         NRWT creates too many workers on RAM-limited machines
3583         https://bugs.webkit.org/show_bug.cgi?id=73847
3584
3585         Reviewed by Dirk Pranke.
3586
3587         Make NRWT restrict its number of workers when there isn't enough
3588         RAM to support them.
3589         Also re-enable parallel testing on the Mac bots which were
3590         failing due to not enough ram.
3591
3592         * Scripts/run-webkit-tests:
3593         (platformIsReadyForParallelTesting):
3594         * Scripts/webkitpy/common/host.py:
3595         (Host.__init__):
3596         * Scripts/webkitpy/common/system/executive_mock.py:
3597         (MockExecutive.cpu_count):
3598         * Scripts/webkitpy/common/system/platforminfo.py:
3599         (PlatformInfo.__init__):
3600         (PlatformInfo.display_name):
3601         * Scripts/webkitpy/common/system/platforminfo_mock.py:
3602         (MockPlatformInfo.display_name):
3603         * Scripts/webkitpy/layout_tests/port/base.py:
3604         (Port.default_child_processes):
3605         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
3606         (PortTest.test_default_child_processes):
3607         (PortTest.test_pretty_patch_os_error):
3608
3609 2011-12-05  Hugo Parente Lima  <hugo.lima@openbossa.org>
3610
3611         Last mouse event could be lost if a JS call to eventSender.leapForward is made
3612         https://bugs.webkit.org/show_bug.cgi?id=73366
3613
3614         Reviewed by Kenneth Rohde Christiansen.
3615
3616         Empty the entire event queue when requested besides using
3617         sendEvent instead of postEvent to make sure all events were
3618         delivered.
3619
3620         * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
3621         (WTR::EventSenderProxy::EventSenderProxy):
3622         (WTR::EventSenderProxy::sendOrQueueEvent):
3623         (WTR::EventSenderProxy::replaySavedEvents):
3624
3625 2011-12-05  Adam Barth  <abarth@webkit.org>
3626
3627         [Chromium] Remove no-longer-used forwarding headers in the WebKit API
3628         https://bugs.webkit.org/show_bug.cgi?id=73845
3629
3630         Reviewed by Darin Fisher.
3631
3632         Update includes to point to the new header locations.
3633
3634         * DumpRenderTree/chromium/AccessibilityController.cpp:
3635         * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
3636         * DumpRenderTree/chromium/CppBoundClass.cpp:
3637         * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
3638         * DumpRenderTree/chromium/DRTDevToolsAgent.h:
3639         * DumpRenderTree/chromium/DRTDevToolsClient.h:
3640         * DumpRenderTree/chromium/EventSender.cpp:
3641         * DumpRenderTree/chromium/EventSender.h:
3642         * DumpRenderTree/chromium/GamepadController.h:
3643         * DumpRenderTree/chromium/LayoutTestController.cpp:
3644         * DumpRenderTree/chromium/LayoutTestController.h:
3645         * DumpRenderTree/chromium/MockSpellCheck.cpp:
3646         * DumpRenderTree/chromium/NotificationPresenter.cpp:
3647         * DumpRenderTree/chromium/PlainTextController.cpp:
3648         * DumpRenderTree/chromium/Task.cpp:
3649         * DumpRenderTree/chromium/TestNavigationController.h:
3650         * DumpRenderTree/chromium/TestShell.cpp:
3651         * DumpRenderTree/chromium/TestWebPlugin.cpp:
3652         * DumpRenderTree/chromium/TestWebPlugin.h:
3653         * DumpRenderTree/chromium/TextInputController.cpp:
3654         * DumpRenderTree/chromium/WebPermissions.cpp:
3655         * DumpRenderTree/chromium/WebPreferences.h:
3656         * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
3657         * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
3658         * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
3659         * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
3660         * DumpRenderTree/chromium/WebViewHost.cpp:
3661
3662 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
3663
3664         Add Aharon Lanin to the contributors list.
3665
3666         * Scripts/webkitpy/common/config/committers.py:
3667
3668 2011-12-05  Jarred Nicholls  <jarred@sencha.com>
3669
3670         Moving myself from contributors to committers.
3671
3672         * Scripts/webkitpy/common/config/committers.py:
3673
3674 2011-12-05  Raphael Kubo da Costa  <kubo@profusion.mobi>
3675
3676         Add myself as a committer.
3677
3678         * Scripts/webkitpy/common/config/committers.py:
3679
3680 2011-12-05  Michael Brüning  <michael.bruning@nokia.com>
3681
3682         [Qt] Rename QQuickWebView::canStop property to just loading 
3683         https://bugs.webkit.org/show_bug.cgi?id=73813
3684
3685         Reviewed by Kenneth Rohde Christiansen.
3686
3687         Replaced references to WebView.canStop with WebView.loading.
3688
3689         * MiniBrowser/qt/qml/BrowserWindow.qml:
3690
3691 2011-12-05  Dirk Pranke  <dpranke@chromium.org>
3692
3693         run-webkit-tests: limit --child-processes properly on apple mac
3694         https://bugs.webkit.org/show_bug.cgi?id=73856
3695
3696         Reviewed by Adam Roben.
3697
3698         Fix typos in r102013 so that we correctly pass --child-processes=1 on
3699         the apple mac bots temporarily.
3700
3701         * Scripts/run-webkit-tests:
3702         (platformIsReadyForParallelTesting):
3703
3704 2011-12-05  Ryosuke Niwa  <rniwa@webkit.org>
3705
3706         Temporarily set --child-process=1 on Mac because 20+ tests are timing out
3707         https://bugs.webkit.org/show_bug.cgi?id=73840
3708
3709         Reviewed by Simon Fraser.
3710
3711         Temporarily go back to single process mode on Mac.
3712
3713         * Scripts/run-webkit-tests:
3714         (platformIsReadyForParallelTesting):
3715
3716 2011-12-05  Adam Roben  <aroben@apple.com>
3717
3718         Redeploy apple-macpro-7 and apple-xserve-1
3719
3720         These slaves have been sitting idle since we removed our Leopard builders in r97496.
3721
3722         Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
3723         sitting idle
3724
3725         Reviewed by Sam Weinig.
3726
3727         * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
3728         apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
3729         allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
3730         (WebKit2 Tests)".
3731
3732 2011-12-05  Kenneth Rohde Christiansen  <kenneth@webkit.org>
3733
3734         [Qt] Make the UI of the MiniBrowser slightly nicer
3735
3736         Rubberstamped by Simon Hausmann.
3737
3738         - Add proper padding
3739         - Show feedback when pressing on the toolbar icons
3740         - Make the text entry better looking
3741
3742         * MiniBrowser/qt/qml/BrowserWindow.qml:
3743
3744 2011-12-05  Kristóf Kosztyó  <kkristof@inf.u-szeged.hu>
3745
3746         NRWT should handle duplicated expectations
3747         https://bugs.webkit.org/show_bug.cgi?id=69750
3748
3749         Reviewed by Dirk Pranke.
3750
3751         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3752         (TestExpectations.__init__):
3753         (TestExpectations._report_errors):
3754         (TestExpectations._add_expectations):
3755         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
3756         (test_add_skipped_tests):
3757         * Scripts/webkitpy/layout_tests/port/base.py:
3758         (Port.skipped_tests):
3759         * Scripts/webkitpy/layout_tests/port/webkit.py:
3760         (WebKitPort.test_expectations):
3761         (WebKitPort.skipped_tests):
3762         * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
3763         (test_test_expectations):
3764
3765 2011-12-04  Eric Seidel  <eric@webkit.org>
3766
3767         After success with Mac, Win and Gtk, turning on parallel testing
3768         by default for all platforms (except Qt).
3769
3770         We'll add more platforms to the blacklist if we see problems.
3771
3772         Unreviewed.
3773
3774         * Scripts/run-webkit-tests:
3775         (platformIsReadyForParallelTesting):
3776
3777 2011-12-04  Sam Weinig  <sam@webkit.org>
3778
3779         Add tests for RetainPtr::adoptNS/adoptCF
3780         https://bugs.webkit.org/show_bug.cgi?id=73470
3781
3782         Reviewed by Adam Roben and Darin Adler.
3783
3784         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3785         * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
3786         (TestWebKitAPI::TEST):
3787         Test that adopting using adoptCF creates a RetainPtr with a
3788         value whose retain count is 1.
3789
3790         * TestWebKitAPI/Tests/WTF/ns: Added.
3791         * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
3792         (TestWebKitAPI::TEST):
3793         Test that adopting using adoptNS creates a RetainPtr with a
3794         value whose retain count is 1.
3795
3796 2011-12-04  Martin Robinson  <mrobinson@igalia.com>
3797
3798         [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
3799         https://bugs.webkit.org/show_bug.cgi?id=73748
3800
3801         Reviewed by Gustavo Noronha Silva.
3802
3803         * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
3804
3805 2011-12-04  Philippe Normand  <pnormand@igalia.com>
3806
3807         Another GTK build fix after r101922.
3808
3809         Rubber-stamped by Martin Robinson.
3810
3811         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3812         (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
3813
3814 2011-12-04  Xan Lopez  <xlopez@igalia.com>
3815
3816         Fix compiler warning in LayoutTestController
3817
3818         Reviewed by Philippe Normand.
3819
3820         * DumpRenderTree/LayoutTestController.cpp:
3821         (LayoutTestController::LayoutTestController): fix warning.
3822
3823 2011-12-04  Alexandre Mazari  <scaroo@gmail.com>
3824
3825         Add missing methods used by fast/notifications tests to LayoutTestController
3826         https://bugs.webkit.org/show_bug.cgi?id=63616
3827
3828         Reviewed by Martin Robinson.
3829
3830         Add missing simulateDesktopNotificationClick method used by
3831         fast/notifications. Provide a default implementation for
3832         areDesktopNotificationPermissionRequestsIgnored and
3833         ignoreDesktopNotificationPermissionRequests.
3834
3835         * DumpRenderTree/LayoutTestController.cpp:
3836         (LayoutTestController::LayoutTestController): call into the port implementation.
3837         (simulateDesktopNotificationClickCallback): ditto.
3838         (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
3839         (LayoutTestController::staticFunctions): declare new methods.
3840         (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
3841         * DumpRenderTree/LayoutTestController.h:
3842         (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
3843         * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
3844         (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
3845         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3846         (LayoutTestController::simulateDesktopNotificationClick): ditto.
3847         * DumpRenderTree/mac/LayoutTestControllerMac.mm:
3848         (LayoutTestController::simulateDesktopNotificationClick): ditto.
3849         * DumpRenderTree/win/LayoutTestControllerWin.cpp:
3850         (LayoutTestController::simulateDesktopNotificationClick): ditto.
3851         * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
3852         (LayoutTestController::simulateDesktopNotificationClick): ditto.
3853
3854 2011-12-03  Mario Sanchez Prada  <msanchez@igalia.com>
3855
3856         [GTK] Don't log document events in DRT
3857         https://bugs.webkit.org/show_bug.cgi?id=73746
3858
3859         Reviewed by Martin Robinson.
3860
3861         Stop connecting globally to document-related events.
3862
3863         * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
3864         (connectAccessibilityCallbacks): Removed connections.
3865         (disconnectAccessibilityCallbacks): Removed disconnections.
3866
3867 2011-12-03  Dan Bernstein  <mitz@apple.com>
3868
3869         Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
3870
3871         Reviewed by Darin Adler.
3872
3873         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3874         * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
3875         (TestWebKitAPI::TEST):
3876
3877 2011-12-03  Philippe Normand  <pnormand@igalia.com>
3878
3879         Another GTK build fix after r101922.
3880
3881         Rubber-stamped by Martin James Robinson.
3882
3883         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3884         (LayoutTestController::pathToLocalResource): return value needs to
3885         be a URI.
3886
3887 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3888
3889         Small fix for my previous patch. Do not try to delete a member
3890         of a dictionary that does not exist.
3891
3892         Reviewed by Gustavo Noronha Silva.
3893
3894         * gtk/run-with-jhbuild:
3895         (install_and_run_jhbuild):
3896
3897 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3898
3899         Fix jhbuild installation for people who have unusual MAKE environment
3900         variables such as 'make -j4' as the jhbuild build does not handle it.
3901
3902         Reviewed by Gustavo Noronha Silva.
3903
3904         * gtk/run-with-jhbuild:
3905         (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
3906
3907 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3908
3909         Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
3910         when run for the first time.
3911
3912         Reviewed by Gustavo Noronha Silva.
3913
3914         * Scripts/update-webkitgtk-libs: Fix first run.
3915
3916 2011-12-03  Philippe Normand  <pnormand@igalia.com>
3917
3918         Unreviewed, GTK build fix after r101922.
3919
3920         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3921         (LayoutTestController::pathToLocalResource): Added sentinel in
3922         g_build_filename call.
3923
3924 2011-12-03  Philippe Normand  <pnormand@igalia.com>
3925
3926         GTK API tests build fix. Run the tests inside jhbuild.
3927
3928         Rubber-stamped by Gustavo Noronha Silva.
3929
3930         * Scripts/run-gtk-tests:
3931         (TestRunner.__init__):
3932         (TestRunner.run._error_handler):
3933         (TestRunner):
3934         (TestRunner.run):
3935
3936 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3937
3938         Small build fix. Properly specify the path to the locally installed jhbuild.
3939
3940         * Scripts/update-webkitgtk-libs: Fix jhbuild path.
3941
3942 2011-12-03  Martin Robinson  <mrobinson@igalia.com>
3943
3944         [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
3945         https://bugs.webkit.org/show_bug.cgi?id=67256
3946
3947         Reviewed by Philippe Normand.
3948
3949         Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing 
3950         WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
3951         which points to the more generic top-level path of the WebKit checkout. This code is
3952         duplicated between WK1 and WK2 harnesses because we do not currently have a way to
3953         share code here.
3954
3955         If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
3956         location. This will cause the fallback to fail if you build into a non-typical location
3957         or even fake it with a symlink. In this case it's important to use the environment variable.
3958
3959         * DumpRenderTree/gtk/DumpRenderTree.cpp:
3960         (getTopLevelPath): Added.
3961         (initializeFonts): Use the new helper to get the font path.
3962         * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
3963         * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
3964         (LayoutTestController::pathToLocalResource):Use the new helper to normalize
3965         test paths.
3966         * Scripts/webkitpy/layout_tests/port/gtk.py:
3967         (GtkPort.setup_environ_for_server):Pass the top-level path of the
3968         checkout instead of passing the font path.
3969         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
3970         (WTR::getTopLevelPath): Added this helper.
3971         (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
3972
3973 2011-12-02  David Levin  <levin@chromium.org>
3974
3975         Rename WTF class from TemporarilyChange to TemporaryChange.
3976         https://bugs.webkit.org/show_bug.cgi?id=73479
3977
3978         Reviewed by Eric Seidel.
3979
3980         * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
3981         * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
3982         * TestWebKitAPI/TestWebKitAPI.gypi:
3983         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3984         * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
3985         (TestWebKitAPI::TEST):
3986         * TestWebKitAPI/win/TestWebKitAPI.vcproj:
3987
3988 2011-12-02  Tony Chang  <tony@chromium.org>
3989
3990         [NRWT] reftest asserts intermittently on the Qt-WK2 bot
3991         https://bugs.webkit.org/show_bug.cgi?id=73453
3992
3993         Reviewed by Ryosuke Niwa.
3994
3995         We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
3996         The verbose output will include the failure reason.
3997
3998         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
3999         * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
4000         (write_test_result):
4001         * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
4002         * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
4003         (determine_result_type):
4004         (FailureReftestNoImagesGenerated.__init__):
4005         (FailureReftestNoImagesGenerated):
4006         (FailureReftestNoImagesGenerated.message):
4007         * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
4008         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
4009         (MainTest.test_run_singly_actually_runs_tests):
4010         (MainTest.test_unexpected_failures):
4011         (EndToEndTest.test_end_to_end):
4012
4013 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
4014
4015         ChangeLog should be able to parse annotated changelogs
4016         https://bugs.webkit.org/show_bug.cgi?id=72703
4017
4018         Reviewed by Eric Seidel.
4019
4020         Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
4021         and extract the revision number for each entry.
4022
4023         Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
4024
4025         * Scripts/webkitpy/common/checkout/changelog.py:
4026         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
4027         * Scripts/webkitpy/common/checkout/scm/git.py:
4028         * Scripts/webkitpy/common/checkout/scm/scm.py:
4029         * Scripts/webkitpy/common/checkout/scm/svn.py:
4030
4031 2011-12-02  Eric Seidel  <eric@webkit.org>
4032
4033         Enable parallel testing for Win and Gtk bots
4034         after confirming with Lucas and Martin the bots should be OK.
4035
4036         Unreviewed. (I ran the idea by Lucas and Martin.)
4037
4038         * Scripts/run-webkit-tests:
4039         (platformIsReadyForParallelTesting):
4040
4041 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
4042
4043         Try to fix the GTK+ build.
4044
4045         * gtk/jhbuild.modules: Properly specify the glib-networking
4046         dependency for soup.
4047
4048 2011-12-02  Martin Robinson  <mrobinson@igalia.com>
4049
4050         Fix a syntax error in the committers.py file.
4051
4052         * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
4053
4054 2011-12-02  Ryosuke Niwa  <rniwa@webkit.org>
4055
4056         Add Alan Stearns and Peter Linss to the contributors list.
4057
4058         * Scripts/webkitpy/common/config/committers.py:
4059
4060 2011-12-02  Kent Tamura  <tkent@chromium.org>
4061
4062         [Chromium] Fix compilation warnings for ASSERT()
4063         https://bugs.webkit.org/show_bug.cgi?id=73623
4064
4065         Reviewed by Tony Chang.
4066
4067         * DumpRenderTree/chromium/ImageDiff.cpp:
4068          - Fix fprintf format: %s -> %d for __LINE__
4069          - Do nothing for ASSERT() if NDEBUG.
4070
4071 2011-12-02  Eric Seidel  <eric@webkit.org>
4072
4073         Enable parallel testing for all Mac bots.
4074
4075         Unreviewed.
4076
4077         * Scripts/run-webkit-tests:
4078         (platformIsReadyForParallelTesting):
4079
4080 2011-12-02  Eric Seidel  <eric@webkit.org>
4081
4082         Enable parallel testing for run-webkit-tests on Mac Lion.
4083         I plan to move all the machines to parallel testing shortly
4084         but we're starting with Lion.
4085
4086         Unreviewed.
4087
4088         * Scripts/run-webkit-tests:
4089         (platformIsReadyForParallelTesting):
4090
4091 2011-12-02  Kausalya Madhusudhanan  <kmadhusu@chromium.org>
4092
4093         Added helper method to identify whether the page has custom page size style.
4094         https://bugs.webkit.org/show_bug.cgi?id=73585
4095
4096         Reviewed by Darin Fisher.
4097
4098         * DumpRenderTree/chromium/LayoutTestController.cpp:
4099         (LayoutTestController::LayoutTestController):
4100         (LayoutTestController::hasCustomPageSizeStyle):
4101         * DumpRenderTree/chromium/LayoutTestController.h:
4102
4103 2011-12-01  Ryosuke Niwa  <rniwa@webkit.org>
4104
4105         [NRWT] reftest should support having multiple references per test
4106         https://bugs.webkit.org/show_bug.cgi?id=73613
4107
4108         Reviewed by Dirk Pranke.
4109
4110         Add a support for having multiple reference files for a single test.
4111
4112         Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
4113         at least one of expected mismatches, we compare expected mismatches first in order to minimize
4114         the number of reference files to open on DRT.
4115
4116         * Scripts/webkitpy/layout_tests/controllers/manager.py:
4117         (interpret_test_failures): Remove checks no longer applicable.
4118         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
4119         (ResultSummaryTest.test_interpret_test_failures): Ditto.
4120         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
4121         (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
4122         (SingleTestRunner._driver_input):
4123         (SingleTestRunner.run):
4124         (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
4125         * Scripts/webkitpy/layout_tests/models/test_input.py:
4126         (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
4127         * Scripts/webkitpy/layout_tests/port/base.py:
4128         (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
4129         (_parse_reftest_list): Now supports parsing multiple entries for a single test.
4130         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4131         (PortTest.test_parse_reftest_list):
4132         * Scripts/webkitpy/layout_tests/port/test.py:
4133         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
4134         (MainTest.test_unexpected_failures):
4135         (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
4136         (EndToEndTest.test_end_to_end):
4137         (EndToEndTest.test_reftest_with_two_notrefs): Added.
4138
4139 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
4140
4141         Build libsoup without gnome dependencies (like keyring).
4142
4143         * gtk/jhbuild.modules:
4144
4145 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
4146
4147         Also build gcrypt and p11-kit, and make them dependencies of
4148         gnutls.
4149
4150         * gtk/jhbuild.modules:
4151
4152 2011-12-02  Kevin Ollivier  <kevino@theolliviers.com>
4153
4154         [wx] Unreviewed build fixes for Windows build.
4155
4156         * waf/build/wxpresets.py:
4157
4158 2011-12-01  Eric Seidel  <eric@webkit.org>
4159
4160         Reviewed by Adam Barth.
4161
4162         webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
4163         https://bugs.webkit.org/show_bug.cgi?id=32006
4164
4165         I decided not to make it warn, and just have it re-open the bug.
4166         That's not that different from today's behavior which will
4167         just silently attach the patch.
4168
4169         This patch makes behavior between upload and land-safely consistent
4170         (previously one would assign patches and the other would not)
4171         as well as adds the ability for both to ensure that the bug is open.
4172
4173         To test this I had to add a few more methods to MockBugzilla which
4174         (positively) affected a few other test results.
4175
4176         I also made AbstractStep keep a cached copy of the Bug object
4177         and used the cached copy where appropriate (including for 'bug_title').
4178         This should reduce the number of bug fetches we perform.
4179
4180         * Scripts/webkitpy/tool/commands/download_unittest.py:
4181         * Scripts/webkitpy/tool/commands/upload.py:
4182         * Scripts/webkitpy/tool/commands/upload_unittest.py:
4183         * Scripts/webkitpy/tool/mocktool.py:
4184         * Scripts/webkitpy/tool/steps/__init__.py:
4185         * Scripts/webkitpy/tool/steps/abstractstep.py:
4186         * Scripts/webkitpy/tool/steps/closebug.py:
4187         * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
4188         * Scripts/webkitpy/tool/steps/postdiff.py:
4189         * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
4190         * Scripts/webkitpy/tool/steps/preparechangelog.py:
4191         * Scripts/webkitpy/tool/steps/steps_unittest.py:
4192         * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
4193
4194 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
4195
4196         Also pass --no-interact to jhbuild when updating dependencies.
4197
4198         * Scripts/update-webkitgtk-libs:
4199
4200 2011-12-02  Alice Boxhall  <aboxhall@chromium.org>
4201
4202         Make _build_path check more thoroughly that build paths exist.
4203         https://bugs.webkit.org/show_bug.cgi?id=73601
4204
4205         Reviewed by Ojan Vafai.
4206
4207         * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
4208         (ChromiumMacPort._build_path):
4209
4210 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
4211
4212         Add libffi to the jhbuild modules list as a glib dependency.
4213
4214         Rubber-stamped by Martin Robinson.
4215
4216         * gtk/jhbuild.modules:
4217
4218 2011-12-02  Gustavo Noronha Silva  <gns@gnome.org>
4219
4220         Build fix. Use internal pcre on glib, make gnutls a dependency of
4221         glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
4222         in non-interactive mode.
4223
4224         * Scripts/update-webkitgtk-libs:
4225         * gtk/jhbuild.modules:
4226         * gtk/run-with-jhbuild:
4227
4228 2011-12-02  Adam Roben  <aroben@apple.com>
4229
4230         Fix for Python 2.6
4231
4232         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4233         (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
4234         in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
4235         searching for "Tests that timed out:" etc. This makes our check less strict, but it
4236         shouldn't matter given the kinds of content we parse.
4237
4238 2011-12-02  Adam Roben  <aroben@apple.com>
4239
4240         Fix names of failed/timed out tests in run-api-tests output
4241
4242         Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
4243         out tests
4244
4245         We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
4246
4247         Reviewed by Simon Fraser.
4248
4249         * Scripts/run-api-tests:
4250         (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
4251         of this function.
4252
4253 2011-11-29  Martin Robinson  <mrobinson@igalia.com>
4254
4255         [GTK] generate-gtkdoc should respect build type
4256         https://bugs.webkit.org/show_bug.cgi?id=73296
4257
4258         Reviewed by Philippe Normand.
4259
4260         * Scripts/webkitdirs.pm:
4261         (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
4262         * gtk/common.py: If --build is passed give preference to the Debug build directory.
4263
4264 2011-12-02  Tony Chang  <tony@chromium.org>
4265
4266         [nrwt] fix wdiff output
4267         https://bugs.webkit.org/show_bug.cgi?id=73604
4268
4269         Reviewed by Adam Barth.
4270
4271         * Scripts/webkitpy/layout_tests/port/base.py:
4272         (Port.wdiff_text):
4273         * Scripts/webkitpy/layout_tests/port/base_unittest.py:
4274         (PortTest.test_wdiff_text):
4275
4276 2011-12-02  Adam Roben  <aroben@apple.com>
4277
4278         Teach build.webkit.org to display how many unit tests failed or timed out
4279
4280         Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
4281         build.webkit.org
4282
4283         We now display something like "5 unit tests failed or timed out". Eventually we might want
4284         to split out how many failure vs. timeouts there were.
4285
4286         Reviewed by Darin Adler.
4287
4288         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
4289         (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
4290         classes that may want to subclass it.
4291         (RunUnitTests): Changed to inherit from TestWithFailureCount.
4292         (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
4293         timed out:" and "Tests that failed:" lines, if present.
4294
4295         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4296         (StubStdio):
4297         (StubRemoteCommand):
4298         Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
4299
4300         (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
4301         the test run correctly.
4302
4303         (RunUnitTestsTest.test_no_failures_or_timeouts):
4304         (RunUnitTestsTest.test_one_failure):
4305         (RunUnitTestsTest.test_multiple_failures):
4306         (RunUnitTestsTest.test_one_timeout):
4307         (RunUnitTestsTest.test_multiple_timeouts):
4308         (RunUnitTestsTest.test_multiple_failures_and_timeouts):
4309         Test various cases.
4310
4311 2011-12-02  Adam Roben  <aroben@apple.com>
4312
4313         Teach prepare-ChangeLog to treat master.cfg as a Python file
4314
4315         Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
4316         in buildbot's master.cfg
4317
4318         Reviewed by Darin Adler.