Fix the pre-Yosemite build.
[WebKit-https.git] / Tools / ChangeLog
1 2015-01-23  Sergio Villar Senin  <svillar@igalia.com>
2
3         REGRESSION: run-perf-tests --profiler= seems to have broken
4         https://bugs.webkit.org/show_bug.cgi?id=113528
5
6         Reviewed by Daniel Bates.
7
8         The problem is that "perf --record" (or the equivalent call for
9         other profilers) is never called whenever there is a wrapper
10         option in the port. We should inject the profiler call first
11         (should it exists) and then use the port wrapper.
12
13         * Scripts/webkitpy/port/driver.py:
14         (Driver._command_wrapper):
15         * Scripts/webkitpy/port/driver_unittest.py:
16         (DriverTest.test_profiler_and_wrapper): New unit test.
17
18 2015-01-22  David Kilzer  <ddkilzer@apple.com>
19
20         configure-xcode-for-ios-development needs to import webkitdirs.pm
21         <http://webkit.org/b/140704>
22
23         Fixes the following runtime error:
24
25             Undefined subroutine &main::exitStatus called at ./Tools/Scripts/configure-xcode-for-ios-development line 167.
26
27         * Scripts/configure-xcode-for-ios-development: Add back code to
28         import webkitdirs.pm for the exitStatus() method.  Not sure why
29         I removed it before patch review.
30
31 2015-01-22  Timothy Horton  <timothy_horton@apple.com>
32
33         REGRESSION (r178847): Yosemite 32-bit bot isn't doing any work
34         https://bugs.webkit.org/show_bug.cgi?id=140795
35
36         Reviewed by Jon Honeycutt.
37
38         * BuildSlaveSupport/build.webkit.org-config/config.json:
39         r178847 accidentally remove the scheduler for this bot. Re-add it to the
40         Yosemite scheduler.
41
42 2015-01-22  Brent Fulgham  <bfulgham@apple.com>
43
44         [Win] Expose missing editing features through WebView interface
45         https://bugs.webkit.org/show_bug.cgi?id=140773
46         <rdar://problem/19565421>
47
48         Reviewed by Dean Jackson.
49
50         Connect the various WebView editing delegate methods to our
51         test infrastructure. Also prefer _bstr_t to raw BSTR types
52         to simplify life cycle management.
53
54         * DumpRenderTree/win/DumpRenderTree.cpp:
55         (resetWebViewToConsistentStateBeforeTesting):
56         * DumpRenderTree/win/EditingDelegate.cpp:
57         (EditingDelegate::QueryInterface):
58         (dumpPath):
59         (dump):
60         (EditingDelegate::shouldBeginEditingInDOMRange):
61         (EditingDelegate::shouldEndEditingInDOMRange):
62         (EditingDelegate::shouldInsertNode):
63         (EditingDelegate::shouldInsertText):
64         (EditingDelegate::shouldDeleteDOMRange):
65         (EditingDelegate::shouldChangeSelectedDOMRange):
66         (EditingDelegate::shouldApplyStyle):
67         (EditingDelegate::shouldChangeTypingStyle):
68         (EditingDelegate::doPlatformCommand):
69         (EditingDelegate::webViewDidBeginEditing):
70         (EditingDelegate::webViewDidChange):
71         (EditingDelegate::webViewDidEndEditing):
72         (EditingDelegate::webViewDidChangeTypingStyle):
73         (EditingDelegate::webViewDidChangeSelection):
74         (EditingDelegate::checkSpellingOfString):
75         (EditingDelegate::onNotify):
76         * DumpRenderTree/win/EditingDelegate.h:
77
78 2015-01-22  Ryosuke Niwa  <rniwa@webkit.org>
79
80         Add a build flag for ES6 class syntax
81         https://bugs.webkit.org/show_bug.cgi?id=140760
82
83         Reviewed by Michael Saboff.
84
85         * Scripts/webkitperl/FeatureList.pm:
86
87 2015-01-22  Daniel Bates  <dabates@apple.com>
88
89         [iOS] run-webkit-tests --ios-sim dies with an error; fails to parse Apple Internal
90         runtime in simctl output
91         https://bugs.webkit.org/show_bug.cgi?id=140751
92
93         Reviewed by David Kilzer.
94
95         Following the fix for <rdar://problem/19444383>, run-webkit-tests --ios-sim dies
96         with an error because it does not know how to parse the output of the simctl tool
97         to identify an Apple Internal runtime.
98
99         * Scripts/webkitpy/xcode/simulator.py:
100         (Runtime.__init__): Add parameter is_internal_runtime (defaults to False).
101         (Runtime.__eq__): Take is_internal_runtime when comparing two Runtime objects for equality.
102         (Runtime.__repr__): Update printable representation of Runtime object to indicate whether
103         the runtime is an internal runtime.
104         (Simulator): Update regular expressions runtime_re and version_re to match an internal runtime.
105         (Simulator._parse_runtimes): Pass is_internal_runtime to the Runtime constructor with the
106         appropriate value.
107         (Simulator._parse_devices): Pass argument is_internal_runtime to Simulator.runtime() so that
108         it updates the appropriate Runtime object.
109         (Simulator.runtime): Added optional parameter, is_internal_runtime. Modified to support
110         looking up a Runtime object for an internal runtime.
111
112 2015-01-22  Alexey Proskuryakov  <ap@apple.com>
113
114         LeaksViewer doesn't show recent builds if there are less than 10
115         https://bugs.webkit.org/show_bug.cgi?id=140716
116
117         Reviewed by Tim Horton.
118
119         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
120
121 2015-01-22  Lucas Forschler  <lforschler@apple.com>
122
123         Add Apple build slaves.
124         Fixed text alignment for slave list.
125         
126         Unreviewed.
127         
128         * BuildSlaveSupport/build.webkit.org-config/config.json:
129
130 2015-01-21  Lucas Forschler  <lforschler@apple.com>
131
132         Teach build.webkit.org about bot308 and bot309.
133         
134         Unreviewed.
135         
136         * BuildSlaveSupport/build.webkit.org-config/config.json:
137
138 2015-01-21  Lucas Forschler  <lforschler@apple.com>
139
140         Add two Apple Mavericks slaves.
141         
142         Unreviewed.
143         
144         * BuildSlaveSupport/build.webkit.org-config/config.json:
145
146 2015-01-21  Daniel Bates  <dabates@apple.com>
147
148         Add iOS WebKit1 TestExpectation file
149         https://bugs.webkit.org/show_bug.cgi?id=140739
150
151         Reviewed by David Kilzer.
152
153         Teach run-webkit-tests to look for iOS WebKit1-specific test results and
154         expectations in directory LayoutTests/platform/ios-simulator-wk1.
155
156         * Scripts/webkitpy/port/ios.py:
157         (IOSSimulatorPort.default_baseline_search_path):
158
159 2015-01-21  David Kilzer  <ddkilzer@apple.com>
160
161         [iOS] Update configure-xcode-for-ios-development to copy missing headers to iphoneos SDK
162         <http://webkit.org/b/140704>
163
164         Reviewed by Daniel Bates.
165
166         * Scripts/configure-xcode-for-ios-development:
167         - Update copyright.
168         - Remove FIXME addressed by r178709.
169         - Call copyMissingHeadersToIPhoneOSSDKIfNeeded().
170         (copyMissingHeadersToIPhoneOSSDKIfNeeded): Add method to copy
171         missing headers from iphonesimulator SDK to iphoneos SDK.
172         (sdkDirectory): Add method that returns SDK directory.
173         (sdkPlatformDirectory): Extract method from
174         xcodeSDKSpecificationsPath() that returns SDK platform
175         directory.
176         (xcodeSDKSpecificationsPath): Update to use
177         sdkPlatformDirectory().
178
179 2015-01-21  Alexey Proskuryakov  <ap@apple.com>
180
181         https://build.webkit.org/dashboard/metrics.html fails because of ios-ews
182         https://bugs.webkit.org/show_bug.cgi?id=140731
183
184         Reviewed by Tim Horton.
185
186         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/MetricsAnalyzer.js:
187         (Analyzer.prototype._analyzeAllBubblesPerformance): Corrected a typo.
188
189 2015-01-21  Brent Fulgham  <bfulgham@apple.com>
190
191         [Win] eventSender does not support scalePageBy
192         https://bugs.webkit.org/show_bug.cgi?id=140726
193         <rdar://problem/19549865>
194
195         Reviewed by Dean Jackson.
196
197         * DumpRenderTree/win/EventSender.cpp:
198         (scalePageByCallback): Provide implementation using new WebView method.
199
200 2015-01-21  Lucas Forschler  <lforschler@apple.com>
201
202         Remove Apple Mountain Lion Build & Test slaves.
203         
204         Unreviewed.
205
206         * BuildSlaveSupport/build.webkit.org-config/config.json:
207
208 2015-01-21  Csaba Osztrogonác  <ossy@webkit.org>
209
210         Remove ENABLE(INSPECTOR) ifdef guards
211         https://bugs.webkit.org/show_bug.cgi?id=140668
212
213         Reviewed by Darin Adler.
214
215         * DumpRenderTree/mac/TestRunnerMac.mm:
216         (TestRunner::showWebInspector):
217         (TestRunner::closeWebInspector):
218         (TestRunner::evaluateInWebInspector):
219         * Scripts/webkitperl/FeatureList.pm:
220         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
221         (WTR::TestRunner::showWebInspector):
222         (WTR::TestRunner::closeWebInspector):
223         (WTR::TestRunner::evaluateInWebInspector):
224         * WebKitTestRunner/TestInvocation.cpp:
225         (WTR::TestInvocation::invoke):
226
227 2015-01-20  Alexey Proskuryakov  <ap@apple.com>
228
229         Update build.webkit.org/dashboard to match current Mac queues.
230
231         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion.png: Removed.
232         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/Lion@2x.png: Removed.
233         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion.png: Removed.
234         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/MountainLion@2x.png: Removed.
235         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
236         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
237         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
238         (table.queue-grid tr.platform.mac-os-x-mountain-lion img.logo): Deleted.
239         (table.queue-grid tr.platform.mac-os-x-lion img.logo): Deleted.
240
241 2015-01-20  Lucas Forschler  <lforschler@apple.com>
242
243         Update Apple MountainLion Leaks slave to Yosemite
244         Update Apple MountainLion Release (32-bit) Build slave to Yosemite
245         
246         Unreviewed.
247
248         * BuildSlaveSupport/build.webkit.org-config/config.json:
249
250 2015-01-20  Lucas Forschler  <lforschler@apple.com>
251
252         Update LeaksViewer from MountainLion to Yosemite
253         
254         Reviewed by Alexey Proskuryakov.
255
256         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
257         (LeaksViewer._displayURLPrompt):
258
259 2015-01-20  Jake Nielsen  <jacob_nielsen@apple.com>
260
261         Fix EWS python unit tests and address code comments as per 140476
262         https://bugs.webkit.org/show_bug.cgi?id=140637
263
264         Reviewed by David Kilzer.
265
266         * Scripts/webkitpy/port/base.py:
267         (Port):
268         (Port.__init__):
269         Adds DEFAULT_ARCHITECTURE member.
270         (Port.architecture):
271         Removes architecture member and instead uses
272         self.get_option('architecture'). Also removes redundant architecture
273         method.
274         (Port.set_architecture):
275         Adds a setter for the architecture variable to be able to set a flag
276         upon modification.
277         (Port.test_configuration):
278         Uses self.architecture() instead of self._architecture.
279         * Scripts/webkitpy/port/ios.py:
280         Overrides DEFAULT_ARCHITECTURE.
281         (IOSPort):
282         (IOSPort.determine_full_port_name):
283         Uses subprocess.check_output instead of Popen. Uses rstrip instead of
284         strip. Fixes regex to not match arbitrary characters after the
285         relevent digits are matched.
286         (IOSPort.__init__):
287         Removes old _architecture defaulting strategy.
288         (IOSPort._build_driver_flags):
289         Uses self.architecture() instead of self._architecture.
290         (IOSSimulatorPort):
291         Overrides DEFAULT_ARCHITECTURE.
292         (IOSSimulatorPort.__init__):
293         Removes old _architecture defaulting strategy.
294         * Scripts/webkitpy/port/mac.py:
295         (MacPort):
296         Overrides DEFAULT_ARCHITECTURE.
297         (MacPort.__init__):
298         Removes old _architecture defaulting strategy.
299         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
300         (AbstractEarlyWarningSystem.run_command):
301         Checks the did_override_architecture flag to determine whether to add
302         the --architecture option.
303         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
304         Uses ews.architecture rather than trying to discern the correct
305         architecture using a port object.
306         (EarlyWarningSystemTest._default_expected_logs):
307         * Scripts/webkitpy/tool/commands/queues.py:
308         Removes use of optparse, and removes the import statement.
309         (AbstractQueue.__init__):
310         (PatchProcessingQueue.begin_work_queue):
311
312 2015-01-20  Sam Weinig  <sam@webkit.org>
313
314         Attempt to fix Mountain Lion and EFL tests.
315
316         * WebKitTestRunner/TestController.cpp:
317         (WTR::TestController::initialize):
318         Disable Process-per-tab and network process on Mountain Lion and EFL.
319
320 2015-01-20  Darin Adler  <darin@apple.com>
321
322         Remove SVGElementInstanceList, m_instanceUnderMouse, DUMP_INSTANCE_TREE, DUMP_SHADOW_TREE
323         https://bugs.webkit.org/show_bug.cgi?id=140679
324
325         Reviewed by Anders Carlsson.
326
327         * Scripts/webkitperl/filter-build-webkit_unittest/shouldIgnoreLine_unittests.pl:
328         Removed a reference to SVGElementInstanceList.
329
330 2015-01-20  Michael Catanzaro  <mcatanzaro@igalia.com>
331
332         [GTK] WebViewTest should prohibit overriding initializeWebExtensions()
333         https://bugs.webkit.org/show_bug.cgi?id=140028
334
335         Reviewed by Carlos Garcia Campos.
336
337         This won't work as expected, since this function is called before the
338         WebViewTest constructor completes.
339
340         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
341
342 2015-01-20  David Kilzer  <ddkilzer@apple.com>
343
344         configure-xcode-for-ios-development needs to update iPhoneOS SDK
345         <http://webkit.org/b/140661>
346
347         Reviewed by Daniel Bates.
348
349         * Scripts/configure-xcode-for-ios-development: Add for() loop to
350         run createXcodeSpecificationFilesForSDKIfNeeded() for both
351         "iphoneos" and "iphonesimulator" SDKs.
352         (createXcodeSpecificationFilesForSDKIfNeeded): Extracted from
353         the main body of the script.
354
355 2015-01-20  Tomas Popela  <tpopela@redhat.com>
356
357         [GTK] Add API to set the web view editable into WebKit2 GTK+ API
358         https://bugs.webkit.org/show_bug.cgi?id=139443
359
360         Reviewed by Carlos Garcia Campos.
361
362         Create the new test cases for setting the editable property on the web
363         view and on the contenteditable enabled document. Also rework the
364         current tests that are expecting that the web view is editable.
365
366         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
367         (loadTestHtml):
368         (testWebViewEditorCutCopyPasteNonEditable):
369         (testWebViewEditorCutCopyPasteEditable):
370         (testWebViewEditorSelectAllNonEditable):
371         (testWebViewEditorSelectAllEditable):
372         (runEditorEditableCutTests):
373         (testWebViewEditorEditableOnNonEditable):
374         (testWebViewEditorEditableOnContentEditable):
375         (testWebViewEditorNonEditable):
376         (beforeAll):
377         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
378         (WebViewTest::isEditable):
379         (WebViewTest::setEditable):
380
381 2015-01-20  Carlos Garcia Campos  <cgarcia@igalia.com>
382
383         [GTK] Add an option to create WebKitWebView snapshots with transparent background
384         https://bugs.webkit.org/show_bug.cgi?id=140617
385
386         Reviewed by Gustavo Noronha Silva.
387
388         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
389         (testWebViewSnapshot): Check that the same snapshot with
390         transparent background is different than the default one filled
391         with white.
392
393 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
394
395         [GTK] Add API to change the WebKitWebView background color
396         https://bugs.webkit.org/show_bug.cgi?id=140610
397
398         Reviewed by Gustavo Noronha Silva.
399
400         Add --bg-color command line option to MiniBrowser to be able to
401         manually test the API passing any RGBA color to MiniBrowser.
402         Also add a simple unit test to check that getting and setting
403         colors from the API point of view.
404
405         * MiniBrowser/gtk/BrowserWindow.c:
406         (browser_window_set_background_color):
407         * MiniBrowser/gtk/BrowserWindow.h:
408         * MiniBrowser/gtk/main.c:
409         (createBrowserWindow):
410         (parseBackgroundColor):
411         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
412         (testWebViewBackgroundColor):
413         (beforeAll):
414
415 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
416
417         [Win] Layout Test fast/xmlhttprequest/xmlhttprequest-no-file-access.html is failing
418         https://bugs.webkit.org/show_bug.cgi?id=140665
419
420         Reviewed by Brian Burg.
421
422         * DumpRenderTree/win/UIDelegate.cpp:
423         (UIDelegate::webViewAddMessageToConsole): Correct string search and concatenation to
424         match expected test output.
425
426 2015-01-19  Benjamin Poulain  <bpoulain@apple.com>
427
428         Remove the support for custom suffixes on ChangeLog
429         https://bugs.webkit.org/show_bug.cgi?id=140648
430
431         Reviewed by David Kilzer.
432
433         Custom suffixes were used for the iOS branch of WebKit.
434         Now that everything is opensource, there is no need for it.
435
436         * Scripts/VCSUtils.pm:
437         (changeLogSuffix): Deleted.
438         (changeLogFileName): Deleted.
439         * Scripts/commit-log-editor:
440         * Scripts/prepare-ChangeLog:
441         (getLatestChangeLogs):
442         (generateNewChangeLogs):
443         (generateFileList):
444         * Scripts/resolve-ChangeLogs:
445         (findChangeLog):
446
447 2015-01-19  Timothy Horton  <timothy_horton@apple.com>
448
449         Adjust naming of action menu SPI
450         https://bugs.webkit.org/show_bug.cgi?id=140644
451         <rdar://problem/19448129>
452
453         Reviewed by Brian Weinstein.
454
455         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
456         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
457         (TestWebKitAPI::TEST):
458
459 2015-01-19  Michael Catanzaro  <mcatanzaro@igalia.com>
460
461         [GTK] Generate the make dist manifest from a CMake template file
462         https://bugs.webkit.org/show_bug.cgi?id=139387
463
464         Reviewed by Martin Robinson.
465
466         Remove the code that performs variable substitution on manifest.txt.
467         Replace the custom variables used in that file with CMake variables.
468
469         * gtk/make-dist.py:
470         (Manifest.add_directory):
471         (Manifest.get_full_source_path):
472         (Manifest.process_line):
473         (Manifest.resolve_variables): Deleted.
474         (Manifest.get_full_tarball_path): Deleted.
475         * gtk/manifest.txt.in: Renamed from Tools/gtk/manifest.txt.
476
477 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
478
479         [Win] Correct merge error in last commit.
480
481         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
482         (findAccessibleObjectById): Undo accidental paste made during landing.
483
484 2015-01-19  Brent Fulgham  <bfulgham@apple.com>
485
486         [Win] Periodic failure in DumpRenderTree related to WebActionPropertyBag::Read
487         https://bugs.webkit.org/show_bug.cgi?id=139906
488
489         Reviewed by Dean Jackson.
490
491         WebKit on Windows was creating uninitialized VARIANT structures, then attempting
492         to use them. This patch fixes that.
493
494         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
495         (findAccessibleObjectById):
496         (AccessibilityController::focusedElement):
497         (logEventProc):
498         (notificationListenerProc):
499         * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
500         (AccessibilityUIElement::getChildAtIndex):
501         (AccessibilityUIElement::titleUIElement):
502         (self):
503         (AccessibilityUIElement::role):
504         (AccessibilityUIElement::valueDescription):
505         (accessibilityState):
506         (AccessibilityUIElement::isChecked):
507         * DumpRenderTree/win/DumpRenderTree.cpp:
508         (dumpFrameScrollPosition):
509         (dumpFramesAsText):
510         * DumpRenderTree/win/PolicyDelegate.cpp:
511         (PolicyDelegate::decidePolicyForNavigationAction):
512         * DumpRenderTree/win/UIDelegate.cpp:
513         (UIDelegate::exceededDatabaseQuota):
514         * WinLauncher/Common.cpp:
515         (setWindowText):
516
517 2015-01-19  Dean Jackson  <dino@apple.com>
518
519         Add "override" to fix the build with newer clangs.
520
521         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
522         (TestWebKitAPI::CalculationDeletionTestNode::operator==):
523
524 2015-01-19  David Kilzer  <ddkilzer@apple.com>
525
526         [iOS] Do not hard-code iphoneos.internal SDK in buildXCodeProject()
527         <http://webkit.org/b/140623>
528
529         Reviewed by Daniel Bates.
530
531         * Scripts/build-webkit: Update help for --device switch.
532         * Scripts/webkitdirs.pm:
533         (determineXcodeSDK): When passing --device, prefer the internal
534         iOS SDK if it exists, else fall back to the external iOS SDK.
535         (buildXCodeProject): Use xcodeSDK() as -sdk argument for
536         xcodebuild instead of trying to sanitize values.
537
538 2015-01-19  Alexey Proskuryakov  <ap@apple.com>
539
540         "Unknown option: sharedworkerglobalscopeconstructorsfile" when running bindings tests.
541         https://bugs.webkit.org/show_bug.cgi?id=140606
542
543         Reviewed by Csaba Osztrogonác.
544
545         * Scripts/webkitpy/bindings/main.py:
546         (BindingsTests.generate_supplemental_dependency):
547         (BindingsTests.main):
548
549 2015-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
550
551         [GTK] [WK2] TestWebKitWebView snapshot fails
552         https://bugs.webkit.org/show_bug.cgi?id=120404
553
554         Reviewed by Žan Doberšek.
555
556         Rework the test to make sure the snapshot is always created at the
557         desired size.
558
559         * Scripts/run-gtk-tests:
560         (TestRunner): Unskip /webkit2/WebKitWebView/snapshot.
561         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
562         (testWebViewSnapshot): Use a fixed size for the document, and
563         disable scrollbars to make sure the visible area is always the
564         WebView size.
565         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
566         (WebViewTest::showInWindowAndWaitUntilMapped): Add optional width
567         and height parameters to create the window with a given size.
568         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
569
570 2015-01-18  David Kilzer  <ddkilzer@apple.com>
571
572         iOS EWS queue name should be consistent
573         <http://webkit.org/b/140585>
574
575         Reviewed by Daniel Bates.
576
577         * Scripts/webkitpy/common/config/ews.json: Rename 'ios-device'
578         to 'ios'.
579         * Scripts/webkitpy/common/config/ports.py: Ditto.
580         (DeprecatedPort.port):
581         (IOSPort):
582         * Scripts/webkitpy/port/ios.py: Ditto.
583         (IOSPort):
584
585         * Scripts/webkitpy/port/factory.py:
586         (PortFactory): Re-order PORT_CLASSES so ios.IOSSimulatorPort
587         appears before ios.IOSPort.  If this is not done,
588         `run-webkit-tests --ios-simulator` will get the wrong Port class
589         (IOSPort instead of IOSSimulatorPort) due to the way that
590         PortFactory.get() uses prefix matching of <Port>.port_name to
591         find the correct class to use.
592
593 2015-01-18  Alexey Proskuryakov  <ap@apple.com>
594
595         build.webkit.org/dashboard: OS X EWS is now on Mavericks
596         https://bugs.webkit.org/show_bug.cgi?id=140595
597
598         Reviewed by Csaba Osztrogonác.
599
600         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
601         (BubbleQueueServer):
602
603 2015-01-17  David Kilzer  <ddkilzer@apple.com>
604
605         Attempt to fix webkitpy tests on Mountain Lion, Mavericks bots
606
607         * Scripts/webkitpy/port/ios.py:
608         (IOSPort): Add 'ios-device-7' to VERSION_FALLBACK_ORDER so that
609         test-webkitpy doesn't fail since iOS 7.x SDKs are installed on
610         the Mountain Lion and Mavericks bots.
611
612 2015-01-17  David Kilzer  <ddkilzer@apple.com>
613
614         Attempt to fix webkitpy tests on GTK Linux ports
615
616         * Scripts/webkitpy/port/ios.py:
617         (IOSPort.determine_full_port_name): Set a sensible default if
618         not running on a Mac platform or if no iOS SDK is installed.
619
620 2015-01-17  Jake Nielsen  <jacob_nielsen@apple.com>
621
622         Create iOS-EWS client queue
623         https://bugs.webkit.org/show_bug.cgi?id=140476
624
625         Reviewed by Alexey Proskuryakov.
626
627         * EWSTools/start-queue-mac.sh:
628         Adds call to configure-xcode-for-ios-development for iOS EWS.
629         * Scripts/webkitpy/common/config/ews.json:
630         Adds the iOS EWS config entry.
631         * Scripts/webkitpy/common/config/ports.py:
632         (DeprecatedPort.port):
633         Adds IOSPort to the port map.
634         (IOSPort):
635         (IOSPort.build_webkit_command):
636         Adds --sdk=iphoneos to the webkit build command.
637         * Scripts/webkitpy/port/base.py:
638         (Port.architecture):
639         Adds an accessor for the architecture member variable.
640         * Scripts/webkitpy/port/factory.py:
641         (PortFactory):
642         Adds IOSPort to the port class list.
643         * Scripts/webkitpy/port/ios.py:
644         Adds the IOSPort to encapsulate iOS-specific things.
645         (IOSPort):
646         (IOSPort.determine_full_port_name):
647         (IOSPort.__init__):
648         (IOSPort._build_driver_flags):
649         (IOSPort.operating_system):
650         * Scripts/webkitpy/tool/commands/download_unittest.py:
651         Adds the archetecture option to the mock options.
652         (DownloadCommandsTest._default_options):
653         * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
654         Appends the archetecture option into calls to webkit-patch.
655         (AbstractEarlyWarningSystem.review_patch):
656         (AbstractEarlyWarningSystem.run_command):
657         (AbstractEarlyWarningSystem.load_ews_classes):
658         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
659         Adds logic to soothe the unittest now that --architecture is being
660         thrown around everywhere.
661         (EarlyWarningSystemTest._default_expected_logs):
662         * Scripts/webkitpy/tool/commands/queues.py:
663         Adds glue code to ferry the --architecture option around.
664         (AbstractQueue.__init__):
665         (PatchProcessingQueue.begin_work_queue):
666         * Scripts/webkitpy/tool/steps/abstractstep.py:
667         Adds the archetecture option to all AbstractSteps so that
668         EarlyWarningSystem doesn't start shoving --architecture into
669         unsuspecting commands.
670         (AbstractStep.options):
671         * Scripts/webkitpy/tool/steps/build.py:
672         Translates the --architecture option into an ARCHS= format to pass to
673         build-webkit.
674         (Build.build):
675         * Scripts/webkitpy/tool/steps/options.py:
676         Adds a definition for the --architecture option.
677         (Options):
678
679 2015-01-16  Sam Weinig  <sam@webkit.org>
680
681         Add a basic configuration object for WKView
682         https://bugs.webkit.org/show_bug.cgi?id=140559
683
684         Reviewed by Anders Carlsson.
685
686         Add tests for WKPageConfigurationRef.
687
688         * TestWebKitAPI/PlatformWebView.h:
689         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
690         * TestWebKitAPI/Tests/WebKit2/WKPageConfiguration.cpp: Added.
691         (TestWebKitAPI::TEST):
692         (TestWebKitAPI::didFinishLoadForFrame):
693         (TestWebKitAPI::setPageLoaderClient):
694         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
695         (TestWebKitAPI::PlatformWebView::initialize):
696         (TestWebKitAPI::PlatformWebView::PlatformWebView):
697
698 2015-01-16  Myles C. Maxfield  <mmaxfield@apple.com>
699
700         WeakPtr functions crash when created with default constructor
701         https://bugs.webkit.org/show_bug.cgi?id=140479
702
703         Reviewed by Andreas Kling.
704
705         Add WeakPtr API tests.
706
707         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
708         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp: Added.
709         * TestWebKitAPI/Tests/WTF/Ref.cpp: Update to not use copy constructor.
710
711 2015-01-16  Chris Dumez  <cdumez@apple.com>
712
713         Regression(r178586): Caused webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties to fail
714         https://bugs.webkit.org/show_bug.cgi?id=140568
715
716         Reviewed by Alexey Proskuryakov.
717
718         Fix the script parsing CSSPropertyNames.in to stop splitting lines
719         on '=' sign. The '=' sign is also used in StyleBuilder parameters:
720         e.g. "Longhands=background-position-x|background-position-y".
721         This would confuse the script and treat this as a CSS property:
722         "background-position-x|background-position-y".
723
724         We now split on white space and treat the first string on the line
725         to be the property name (this is the syntax in this file).
726
727         * Scripts/webkitpy/w3c/test_converter.py:
728         (_W3CTestConverter.__init__):
729         (_W3CTestConverter.read_webkit_prefixed_css_property_list):
730
731 2015-01-16  Daniel Bates  <dabates@apple.com>
732
733         REGRESSION (r171968): run-safari --simulator fails to launch Safari on iOS
734         https://bugs.webkit.org/show_bug.cgi?id=135589
735
736         Reviewed by David Kilzer.
737
738         Derived from a patch by David Farler.
739
740         Following the removal IPhoneSimulatorNotification.pm in <http://trac.webkit.org/changeset/171968>
741         run-safari --simulator fails to launch Safari on iOS. We need to implement run-safari
742         in terms of the simctl command line utility.
743
744         * Scripts/webkitdirs.pm: Added constant SIMULATOR_DEVICE_STATE_BOOTED.
745         (eraseIOSSimulatorDevice): Added.
746         (bootedIOSSimulatorDevice): Added.
747         (iosSimulatorApplicationsPath): Added.
748         (installedMobileSafariBundle): Implemented in terms of iosSimulatorApplicationsPath().
749         (openIOSSimulator): Modified to launch iOS Simulator using OPEN(1).
750         (quitIOSSimulator): Added.
751         (iosSimulatorDeviceByName): Modified to find the first simulator device that matches
752         the specified name and currently selected iOS runtime.
753         (isIOSSimulatorSystemInstalledApp): Added.
754         (runIOSWebKitAppInSimulator): Modified to use simctl launch to launch an app in the simulator.
755         (deleteiOSSimulatorDevice): Deleted.
756         (loadIPhoneSimulatorNotificationIfNeeded): Deleted.
757         (installAndLaunchIOSWebKitAppInSimulator): Deleted.
758
759 2015-01-16  Alex Christensen  <alex.christensen@flexsim.com>
760
761         Resurrect the WinCairo bot.
762         https://bugs.webkit.org/show_bug.cgi?id=139908
763
764         Reviewed by Csaba Osztrogonác.
765
766         * BuildSlaveSupport/build.webkit.org-config/config.json:
767         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
768         (appendCustomBuildFlags):
769         * BuildSlaveSupport/test-result-archive:
770         (archiveTestResults):
771         Add WinCairo buildbot.
772
773 2015-01-16  Chris Dumez  <cdumez@apple.com>
774
775         webkit-patch should auto-install the keyring python module
776         https://bugs.webkit.org/show_bug.cgi?id=140547
777
778         Reviewed by David Kilzer.
779
780         Auto-install the keyring python module. This is the module that
781         webkit-patch uses for cross-platform access to the keyring
782         service.
783
784         Without this module, if the password if not in the keychain,
785         webkit-patch will keep asking for your username / password and
786         never remember them.
787
788         * Scripts/webkitpy/common/net/credentials.py:
789         * Scripts/webkitpy/thirdparty/__init__.py:
790         (AutoinstallImportHook.find_module):
791         (AutoinstallImportHook._install_keyring):
792
793 2015-01-15  Csaba Osztrogonác  <ossy@webkit.org>
794
795         Remove ENABLE(SQL_DATABASE) guards
796         https://bugs.webkit.org/show_bug.cgi?id=140434
797
798         Reviewed by Darin Adler.
799
800         * Scripts/webkitperl/FeatureList.pm:
801
802 2015-01-15  Daniel Bates  <dabates@apple.com>
803
804         [iOS] REGRESSION (r174642): DumpRenderTree.app test may dump result twice
805         https://bugs.webkit.org/show_bug.cgi?id=139685
806         <rdar://problem/19281317>
807
808         Reviewed by Simon Fraser.
809
810         Fixes an issue where a test in DumpRenderTree.app may dump its result twice. In particular,
811         the test LayoutTests/fast/dom/gc-10.html may dump its result twice.
812
813         Following <http://trac.webkit.org/changeset/174642>, we dump the test result asynchronously
814         as opposed to synchronously. So, the WebThread or the main thread may perform other tasks
815         before DRT dumps the output of a test. In particular, the WebThread may start a new page
816         load (say, as a result of continued JavaScript execution), which will ultimately lead to
817         dumping the test result again. Instead we want DRT to dump the test result synchronously
818         such that we capture the state of the web page either when the page is loaded or when
819         window.testRunner.notifyDone() is called.
820
821         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
822         (createBitmapContextFromWebView): Moved logic to re-enable tile painting and update the
823         state of the display from here to updateDisplay(). Added call to -[CATransaction flush] to
824         flush CA transactions to the window.
825         * DumpRenderTree/mac/DumpRenderTree.mm:
826         (updateDisplay): Added iOS-specific code to update tiles and tell WebKit to flush
827         compositing changes to ensure that we have up-to-date tile content for a pixel/ref-test.
828         (dump): Renamed; formerly named dumpTestResults().
829         (displayWebView): Removed outdated FIXME comment. Added FIXME comment to investigate
830         enabling repaint support on iOS.
831         (-[DumpRenderTree _deferDumpToMainThread]): Deleted.
832         (-[DumpRenderTree _waitForWebThreadThenDump]): Deleted.
833         (dumpTestResults): Deleted.
834
835 2015-01-15  Brent Fulgham  <bfulgham@apple.com>
836
837         [Win] Miscellaneous DRT fixes
838         https://bugs.webkit.org/show_bug.cgi?id=116562
839
840         Reviewed by Tim Horton.
841
842         While investigating the cause of several Windows crashes, I found:
843         (1) Messy conversions to and from BSTR types
844         (2) Weird mixes of wide-string and narrow string conversions
845         (3) Passing nullptr to some CoreFoundation routines that do not
846             permit null arguments.
847         (4) Commands to link the executable to the VS2005 runtime.
848
849         This patch cleans up these issues to improve DRT reliability on
850         Windows.
851
852         * DumpRenderTree/cg/ImageDiffCG.cpp:
853         (main): Get rid of VS2005 runtime linking.
854         * DumpRenderTree/win/DumpRenderTree.cpp:
855         (urlSuitableForTestResult): Protect against being asked
856         to process an empty URL.
857         (dumpHistoryItem): Do BSTR string building using _bstr_t, rather
858         than converting to/from wchar_t buffers.
859         (runTest): Simplify string and BSTR handling.
860         (createWebViewAndOffscreenWindow): Ditto.
861         (main): Get rid of VS2005 runtime linking.
862         * DumpRenderTree/win/TestRunnerWin.cpp:
863         (jsStringRefToWString): Simplify code.
864         (TestRunner::pathToLocalResource):
865         (TestRunner::setUserStyleSheetLocation):
866         * TestWebKitAPI/win/main.cpp: Get rid of
867         VS2005 runtime linking.
868         * win/DLLLauncher/DLLLauncherMain.cpp:
869         (wWinMain): Ditto.
870
871 2015-01-15  Alexey Proskuryakov  <ap@apple.com>
872
873         Stop hardcoding mac-mountainlion in commit queue
874         https://bugs.webkit.org/show_bug.cgi?id=140492
875
876         Reviewed by Anders Carlsson.
877
878         Use "mac", not "mac-<platform>". This matches how EWS queues are initialized, and
879         there should be no change in behavior, because:
880         1. PatchProcessingQueue converts the name with _new_port_name_from_old() before
881         using it to create a port object.
882         2. Although it doesn't convert the name before using DeprecatedPort.port(), it
883         is actually correct to use "mac" for the name there. We only used to get the expected
884         behavior with "mac-mountainlion" accidentally, because of a fallback to "mac"
885         for unknown deprecated port names.
886
887         * Scripts/webkitpy/tool/commands/queues.py: (CommitQueue):
888
889 2015-01-14  Jake Nielsen  <jacob_nielsen@apple.com>
890
891         Create iOS-EWS server queue
892         https://bugs.webkit.org/show_bug.cgi?id=140473
893
894         Reviewed by Benjamin Poulain.
895
896         * QueueStatusServer/app.yaml: Updates the SVN version number.
897         * QueueStatusServer/config/queues.py: Add ios-ews queue.
898         * QueueStatusServer/model/queues.py:         
899         (Queue.display_name): Makes sure the display name is pretty!
900
901 2015-01-14  Daniel Bates  <dabates@apple.com>
902
903         [iOS] run-webkit-tests --ios hangs trying to launch iOS Simulator with unavailable runtime
904         https://bugs.webkit.org/show_bug.cgi?id=140301
905         <rdar://problem/19389266>
906
907         Reviewed by Jon Honeycutt.
908
909         Fixes an issue where run-webkit-tests --ios will hang when trying to launch iOS Simulator
910         with an unavailable runtime.
911
912         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
913         (_set_up_derived_options): Modified to access property Simulator.latest_available_runtime,
914         which was formerly called Simulator.latest_runtime. Additionally, raise an exception if the
915         specified runtime cannot be used because it is unavailable.
916         * Scripts/webkitpy/port/ios.py:
917         (IOSSimulatorPort.testing_device): Modified to call Simulator.lookup_or_create_device(),
918         which was formerly named testing_device.
919         * Scripts/webkitpy/xcode/simulator.py:
920         (Device.create): Modified to lookup created device by the UDID returned by simctl, which is
921         more robust than looking up the simulator device by name and runtime. This approach also
922         avoids returning the wrong device due to <rdar://problem/19444383> (simctl list shows
923         unavailable runtimes under the same iOS heading it would use to show it as available).
924         (Simulator.find_device_by_udid): Added.
925         (Simulator.device): Added optional parameter should_ignore_unavailable_devices (defaults
926         to False) to ignore devices that are unavailable (say, because their runtime is unavailable).
927         (Simulator.available_runtimes): Added.
928         (Simulator.latest_available_runtime): Renamed; formerly named latest_runtime. Take advantage
929         of the reverse=True argument to sorted() to sort the list of available runtimes such that the
930         first element of the sorted list is the runtime with the highest version number.
931         (Simulator.lookup_or_create_device): Renamed; formerly named testing_device.
932
933 2015-01-14  Csaba Osztrogonác  <ossy@webkit.org>
934
935         Remove WK2 Windows cruft
936         https://bugs.webkit.org/show_bug.cgi?id=140440
937
938         Reviewed by Anders Carlsson.
939
940         * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp: Removed.
941         * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Removed.
942         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp: Removed.
943
944 2015-01-13  Hunseop Jeong  <hs85.jeong@samsung.com>
945
946         Fix TestWTF failed in TestWebKitAPI
947         https://bugs.webkit.org/show_bug.cgi?id=140333
948
949         Reviewed by Sam Weinig.
950
951         Clear the std::ostringstream before starting test.
952
953         * TestWebKitAPI/Tests/WTF/RefLogger.h:
954         (TestWebKitAPI::DerivedRefLogger::DerivedRefLogger):
955
956 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
957
958         TestWebKitWebContext depends on British English spellcheck dictionary
959         https://bugs.webkit.org/show_bug.cgi?id=140403
960
961         Reviewed by Martin Robinson.
962
963         Install all English hunspell dictionaries on Fedora and Arch.
964
965         * gtk/install-dependencies:
966
967 2015-01-13  Michael Catanzaro  <mcatanzaro@igalia.com>
968
969         [GTK] install-dependencies should grok dnf
970         https://bugs.webkit.org/show_bug.cgi?id=140396
971
972         Reviewed by Martin Robinson.
973
974         Fedora: install dependencies with dnf if yum is not installed.
975
976         * gtk/install-dependencies:
977
978 2015-01-12  Hunseop Jeong  <hs85.jeong@samsung.com>
979
980         [EFL][GTK] Fix build after r178309  
981         https://bugs.webkit.org/show_bug.cgi?id=140381
982
983         Reviewed by Gyuyoung Kim.
984
985         * TestWebKitAPI/CMakeLists.txt: Added the API directory
986
987 2015-01-11  Sam Weinig  <sam@webkit.org>
988
989         Remove support for SharedWorkers
990         https://bugs.webkit.org/show_bug.cgi?id=140344
991
992         Reviewed by Anders Carlsson.
993
994         * Scripts/webkitperl/FeatureList.pm:
995
996 2015-01-12  Anders Carlsson  <andersca@apple.com>
997
998         Make delegates conform to formal delegate protocols
999         https://bugs.webkit.org/show_bug.cgi?id=140370
1000
1001         Reviewed by Dan Bernstein.
1002
1003         * DumpRenderTree/mac/TestRunnerMac.mm:
1004         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1005         (TestRunner::setGeolocationPermission):
1006
1007 2015-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
1008
1009         build-webkit: silence output of 'which'
1010         https://bugs.webkit.org/show_bug.cgi?id=140278
1011
1012         Reviewed by Daniel Bates.
1013
1014         Use a more elegent test for the existance of ninja and eclipse.
1015
1016         * Scripts/webkitdirs.pm:
1017         (commandExists): Don't assume the command supports --version
1018         (canUseNinja): Use commandExists()
1019         (canUseEclipse): Use commandExists()
1020
1021 2015-01-09  Sam Weinig  <sam@webkit.org>
1022
1023         Update the output format for run-api-tests
1024         https://bugs.webkit.org/show_bug.cgi?id=140332
1025
1026         Reviewed by Dan Bernstein.
1027
1028         Changes the output format for run-api-tests be a bit simpler (no longer 
1029         indented based on suite, as we were not really using suite very well) but
1030         also include details in the case of failure.
1031
1032         Changes verbose mode to no longer spew out the gtest default printer output,
1033         as the custom printer now includes the failure information.
1034
1035         * Scripts/run-api-tests:
1036         (runTestsBySuite):
1037         (runTest):
1038         Augment the custom gtest printer by replacing the tokens "**PASS**" and "**FAIL**"
1039         with colorized variants and strip out leaks spew (the leaks can be added back using
1040         the new --show-leaks argument).
1041
1042         * TestWebKitAPI/TestsController.cpp:
1043         (TestWebKitAPI::Printer::OnTestPartResult):
1044         (TestWebKitAPI::Printer::OnTestEnd):
1045         (TestWebKitAPI::TestsController::run):
1046         Implement a custom result printer that just prints out the information we want.
1047
1048 2015-01-09  Sam Weinig  <sam@webkit.org>
1049
1050         TestWebKitAPI should print out the lists that fail at the end
1051         https://bugs.webkit.org/show_bug.cgi?id=140329
1052
1053         Reviewed by Tim Horton.
1054
1055         * Scripts/run-api-tests:
1056         (runTestsBySuite):
1057         Print out failures and timeouts in all modes, not just verbose.
1058
1059 2015-01-07  Geoffrey Garen  <ggaren@apple.com>
1060
1061         Make bmalloc work with ASan
1062         https://bugs.webkit.org/show_bug.cgi?id=140194
1063
1064         Reviewed by Mark Lam.
1065
1066         * asan/asan.xcconfig: No need to disable FastMalloc; bmalloc supports
1067         ASan automatically (by forwarding to system malloc at runtime).
1068
1069 2015-01-09  Daniel Bates  <dabates@apple.com>
1070
1071         [iOS] Make DumpRenderTree build with public SDK
1072         https://bugs.webkit.org/show_bug.cgi?id=140311
1073
1074         Reviewed by Sam Weinig.
1075
1076         Use CGRound() instead of the obsolete macro function _ROUNDF_ (defined in
1077         header UIKit/UIMath.h), and std::max() instead of the macro function MAX.
1078         Additionally, remove unused header CoreGraphics/CGFontDB.h.
1079
1080         * DumpRenderTree/mac/DumpRenderTree.mm:
1081         (-[ScrollViewResizerDelegate view:didSetFrame:oldFrame:asResultOfZoom:]):
1082
1083 2015-01-09  Alexey Proskuryakov  <ap@apple.com>
1084
1085         platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html fails on Retina machines
1086         https://bugs.webkit.org/show_bug.cgi?id=140300
1087
1088         Reviewed by Simon Fraser.
1089
1090         * WebKitTestRunner/TestController.cpp:
1091         (WTR::TestController::createOtherPage):
1092         (WTR::TestController::updateWindowScaleForTest):
1093         (WTR::TestController::configureViewForTest):
1094         * WebKitTestRunner/TestController.h:
1095
1096 2015-01-09  Tibor Meszaros  <tmeszaros.u-szeged@partner.samsung.com>
1097
1098         Unreviewed. Moving myself to the committer section.
1099
1100         * Scripts/webkitpy/common/config/contributors.json:
1101
1102 2015-01-09  Carlos Garcia Campos  <cgarcia@igalia.com>
1103
1104         Add a script to check for platform layering violations
1105         https://bugs.webkit.org/show_bug.cgi?id=140248
1106
1107         Reviewed by Darin Adler.
1108
1109         It prints all the cases where files inside platform include
1110         headers that are not in platform directory.
1111
1112         * Scripts/check-for-platform-layering-violations: Added.
1113         (get_platform_headers):
1114         (check_source_file):
1115
1116 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1117
1118         [Mac WK2] Test snapshots are 1600x1200 on Retina devices
1119         https://bugs.webkit.org/show_bug.cgi?id=139884
1120
1121         Reviewed by Tim Horton.
1122
1123         * WebKitTestRunner/mac/PlatformWebViewMac.mm: (WTR::PlatformWebView::windowSnapshotImage):
1124         Tell CGWindowListCreateImage to use the correct resolution. I don't really understand
1125         what the "nominal resolution" is, but this appears to work in practice.
1126
1127 2015-01-08  Brent Fulgham  <bfulgham@apple.com>
1128
1129         [Win] DumpRenderTree is always using 800x600 size, even if tests need other size.
1130         https://bugs.webkit.org/show_bug.cgi?id=140256
1131
1132         Reviewed by Anders Carlsson.
1133
1134         * DumpRenderTree/win/DumpRenderTree.cpp:
1135         (resetWebPreferencesToConsistentValues): Drive-by fix of a buffer overrun found while
1136         running with heap validation checks.
1137         (sizeWebViewForCurrentTest): Check both path separators ('/' and '\\') when checking for
1138         the "svg\\W3C-SVG-1.1" test directory.
1139         (removeFontFallbackIfPresent): Use nullptr instead of 0.
1140         * DumpRenderTree/win/TestRunnerWin.cpp:
1141         (TestRunner::clearPersistentUserStyleSheet): Ditto.
1142
1143 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1144
1145         Follow-up to:  When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
1146         https://bugs.webkit.org/show_bug.cgi?id=140218
1147
1148         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash_or_unresponsiveness):
1149         Undone an accidental change - check for self.has_crashed() again. This code path
1150         is for ports that don't have a signal handler printing #CRASHED when main process
1151         crashes.
1152
1153         * Scripts/webkitpy/port/driver_unittest.py:
1154         (DriverTest.test_check_for_driver_crash.assert_crash):
1155         (DriverTest.test_check_for_driver_crash):
1156         Updated the tests, all changes are expected.
1157
1158 2015-01-08  Alexey Proskuryakov  <ap@apple.com>
1159
1160         When WebProcess is slow to respond to IPC, that's mistakenly reported as crash
1161         https://bugs.webkit.org/show_bug.cgi?id=140218
1162
1163         Reviewed by Darin Adler.
1164
1165         * Scripts/webkitpy/port/driver.py:
1166         (Driver.__init__): Removed _subprocess_was_unresponsive that was a modifier for
1167         "process crashed" condition. These don't make sense together - it's either a crash
1168         or a timeout, and we should detect those properly at a much lower level.
1169         (Driver.run_test): Ditto.
1170         (Driver._check_for_driver_crash_or_unresponsiveness): Split crash and unresponsiveness
1171         cases.
1172
1173         * WebKitTestRunner/TestController.h:
1174         * WebKitTestRunner/TestController.cpp:
1175         (WTR::TestController::webProcessName): 
1176         (WTR::TestController::processDidCrash):
1177         Factored out hardcoded child process names, as we now use these in two places.
1178
1179         * WebKitTestRunner/TestInvocation.cpp:
1180         (WTR::TestInvocation::dumpWebProcessUnresponsiveness): Dump an accurate child
1181         process name, so that it can be sampled (fixes sampling on Mavericks and above).
1182
1183 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
1184
1185         Reorder my list of email addresses, keeping the Bugzilla address at the
1186         top since Bugzilla and other webkitpy scripts rely on that ordering.
1187
1188         * Scripts/webkitpy/common/config/contributors.json:
1189
1190 2015-01-08  Zan Dobersek  <zdobersek@igalia.com>
1191
1192         Moving myself to the reviewers section and updating
1193         the list of my email addresses.
1194
1195         * Scripts/webkitpy/common/config/contributors.json:
1196
1197 2015-01-07  Michael Catanzaro  <mcatanzaro@igalia.com>
1198
1199         [GTK] Build gtk-doc without gtkdoc-mktmpl
1200         https://bugs.webkit.org/show_bug.cgi?id=140225
1201
1202         Reviewed by Darin Adler.
1203
1204         Stop calling gtkdoc-mktmpl. It's being removed upstream, and since we
1205         don't modify the tmpl files that it generates, it's not doing anything
1206         for us.
1207
1208         * gtk/gtkdoc.py:
1209         (GTKDoc.generate):
1210         (GTKDoc._run_gtkdoc_scangobj):
1211         (GTKDoc._run_gtkdoc_mktmpl): Deleted.
1212
1213 2015-01-07  Gwang Yoon Hwang  <yoon@igalia.com>
1214
1215         [GTK][ThreadedCompositor] Add support for threaded compositor.
1216         https://bugs.webkit.org/show_bug.cgi?id=118265
1217
1218         Reviewed by Martin Robinson.
1219
1220         Added the ENABLE_THREADED_COMPOSITOR feature flag to the cmake and
1221         autotools build systems. The feature is disabled by default.
1222         And remove deprecated the WTF_USE_TILED_BACKING_STORE feature flag
1223         from the feature flags.
1224
1225         * Scripts/webkitperl/FeatureList.pm:
1226
1227 2015-01-07  Daniel Bates  <dabates@apple.com>
1228
1229         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1230         https://bugs.webkit.org/show_bug.cgi?id=137371
1231
1232         Reviewed by David Kilzer.
1233
1234         Use SPI wrapper headers instead of directly referencing private SPI headers.
1235
1236         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1237         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1238         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
1239         to the list of iOS header search directories so that we can include header UIKitSPI.h.
1240         * DumpRenderTree/mac/DumpRenderTree.mm:
1241         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1242         * DumpRenderTree/mac/EventSendingController.mm:
1243         * DumpRenderTree/mac/TestRunnerMac.mm:
1244
1245 2015-01-07  Commit Queue  <commit-queue@webkit.org>
1246
1247         Unreviewed, rolling out r178068.
1248         https://bugs.webkit.org/show_bug.cgi?id=140235
1249
1250         Breaks the iOS build (Requested by enrica on #webkit).
1251
1252         Reverted changeset:
1253
1254         "[iOS] Make WebKit2 build with public iOS SDK and more build
1255         fixes for DRT"
1256         https://bugs.webkit.org/show_bug.cgi?id=137371
1257         http://trac.webkit.org/changeset/178068
1258
1259 2015-01-07  Daniel Bates  <dabates@apple.com>
1260
1261         [iOS] Make WebKit2 build with public iOS SDK and more build fixes for DRT
1262         https://bugs.webkit.org/show_bug.cgi?id=137371
1263
1264         Reviewed by David Kilzer.
1265
1266         Use SPI wrapper headers instead of directly referencing private SPI headers.
1267
1268         * DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
1269         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
1270         * DumpRenderTree/mac/Configurations/Base.xcconfig: Append directory Source/WebKit2/Platform/spi/ios
1271         to the list of header search directories so that we can include header UIKitSPI.h.
1272         * DumpRenderTree/mac/DumpRenderTree.mm:
1273         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
1274         * DumpRenderTree/mac/EventSendingController.mm:
1275         * DumpRenderTree/mac/TestRunnerMac.mm:
1276
1277 2015-01-07  Brent Fulgham  <bfulgham@apple.com>
1278
1279         [Win] Unreviewed test change to improve run reproducibility
1280
1281         * Scripts/webkitpy/port/win.py:
1282         (WinPort.default_child_processes): Run a single DRT instance to help
1283         identify failures caused by earlier test runs.
1284
1285 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
1286
1287         Myles C. Maxfield is a reviewer now
1288         https://bugs.webkit.org/show_bug.cgi?id=140196
1289
1290         Reviewed by Dean Jackson.
1291
1292         * Scripts/webkitpy/common/config/contributors.json:
1293
1294 2015-01-07  Myles C. Maxfield  <mmaxfield@apple.com>
1295
1296         Make webkit-patch try harder to find keychain credentials
1297         https://bugs.webkit.org/show_bug.cgi?id=140170
1298
1299         Reviewed by Ryosuke Niwa.
1300
1301         When the user manually enters a password into webkit-patch, we hand that off to the
1302         Keyring Python module. However, that module creates a generic password entry instead
1303         of an internet password entry. We should look for both kinds.
1304
1305         * Scripts/webkitpy/common/net/credentials.py:
1306         (Credentials._run_security_tool):
1307         (Credentials._credentials_from_keychain):
1308         * Scripts/webkitpy/common/net/credentials_unittest.py:
1309         (test_security_output_parse_entry_not_found):
1310         (_assert_security_call):
1311
1312 2015-01-06  Anders Carlsson  <andersca@apple.com>
1313
1314         Try to fix the Mountain Lion build.
1315
1316         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1317         (TestWebKitAPI::didGetImageForMatchResult):
1318
1319 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
1320
1321         Debug ASan builds frequently crash in Register::jsValue under DFG::prepareOSREntry
1322         https://bugs.webkit.org/show_bug.cgi?id=140095
1323
1324         Reviewed by Anders Carlsson.
1325
1326         * asan/webkit-asan-ignore.txt: Blacklist a function that gets inlined in release
1327         builds, but not in debug ones.
1328
1329 2015-01-06  Brent Fulgham  <bfulgham@apple.com>
1330
1331         [Win] Extend WinLauncher with support for Page Zoom
1332         https://bugs.webkit.org/show_bug.cgi?id=140152
1333
1334         Reviewed by Anders Carlsson.
1335
1336         * WinLauncher/Common.cpp:
1337         (WndProc):
1338         * WinLauncher/WinLauncher.cpp:
1339         (WinLauncher::resetZoom):
1340         (WinLauncher::zoomIn):
1341         (WinLauncher::zoomOut):
1342         * WinLauncher/WinLauncher.h:
1343         * WinLauncher/WinLauncher.vcxproj/WinLauncherLib.rc:
1344         * WinLauncher/WinLauncher.vcxproj/WinLauncherLibResource.h:
1345         * win/DLLLauncher/DLLLauncherMain.cpp:
1346         (wWinMain):
1347
1348 2015-01-06  Anders Carlsson  <andersca@apple.com>
1349
1350         Fix API tests that are broken under HiDPI
1351         https://bugs.webkit.org/show_bug.cgi?id=140146
1352
1353         Reviewed by Tim Horton.
1354
1355         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
1356         (TestWebKitAPI::didGetImageForMatchResult):
1357         NSImages are measured in points, so grab the underlying bitmap image and get its size in pixels.
1358
1359         * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
1360         (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
1361         Don't assume that a web view not in a window has a backing scale factor of 1. Instead, always have web views start
1362         out in a window that has a backing scale factor of 1.
1363  
1364         * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
1365         (TestWebKitAPI::DynamicDeviceScaleFactor::runTest):
1366         Ditto.
1367
1368 2015-01-06  Alexey Proskuryakov  <ap@apple.com>
1369
1370         ADDRESS_SANITIZER macro is overloaded
1371         https://bugs.webkit.org/show_bug.cgi?id=140130
1372
1373         Reviewed by Anders Carlsson.
1374
1375         * WebKitTestRunner/TestController.cpp: Use the new macro.
1376
1377 2015-01-05  Joseph Pecoraro  <pecoraro@apple.com>
1378
1379         Remove some stale class names in check-for-inappropriate-objc-class-names
1380         https://bugs.webkit.org/show_bug.cgi?id=140104
1381
1382         Reviewed by Darin Adler.
1383
1384         * Scripts/check-for-inappropriate-objc-class-names:
1385         These UIWK* classes no longer exist.
1386
1387 2015-01-05  Anders Carlsson  <andersca@apple.com>
1388
1389         heap-buffer-overflow on fast/loader/reload-zero-byte-plugin.html
1390         https://bugs.webkit.org/show_bug.cgi?id=140096
1391         rdar://problem/19368938
1392
1393         Reviewed by Alexey Proskuryakov.
1394
1395         When creating a new page, don't pass clientInfo when setting up the frame and policy clients,
1396         since clientInfo points to a web view, not the test controller.
1397
1398         * WebKitTestRunner/TestController.cpp:
1399         (WTR::TestController::createOtherPage):
1400
1401 2015-01-05  Hunseop Jeong  <hs85.jeong@samsung.com>
1402
1403         [EFL][GTK] WKPreferencesDefaults test failed after r177506 
1404         https://bugs.webkit.org/show_bug.cgi?id=140077
1405
1406         Reviewed by Csaba Osztrogonác.
1407
1408         WebKit C SPI is available on EFL,GTK.
1409         Changed the define order to pass the API test.
1410
1411         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
1412         (TestWebKitAPI::TEST):
1413
1414 2015-01-01  Alexey Proskuryakov  <ap@apple.com>
1415
1416         Simplify WebKitTestRunner timeout tracking
1417         https://bugs.webkit.org/show_bug.cgi?id=140036
1418
1419         Reviewed by Darin Adler.
1420
1421         The code for configuring timeouts was mostly dead, because run-webkit-tests never
1422         passes the --timeout option to WebKitTestRunner.
1423
1424         * WebKitTestRunner/Options.h:
1425         * WebKitTestRunner/Options.cpp:
1426         (WTR::Options::Options):
1427         (WTR::OptionsHandler::OptionsHandler):
1428         (WTR::handleOptionTimeout): Deleted.
1429         Removed support for --timeout. Timeouts are passed for each test individually,
1430         and defaults are good enough for the rare cases where WebKitTestRunner is run
1431         manually without run-webkit-tests.
1432
1433         * WebKitTestRunner/TestController.cpp:
1434         (WTR::TestController::TestController):
1435         (WTR::TestController::initialize):
1436         (WTR::TestController::resetStateToConsistentValues):
1437         (WTR::TestController::reattachPageToWebProcess):
1438         (WTR::TestController::runUntil):
1439         * WebKitTestRunner/TestController.h:
1440         Simplified runUntil by passing the actual timeout, not an enum.
1441         Increased short timeout for ASan enabled builds, as WebProcess launching takes
1442         quite a while.
1443
1444         * WebKitTestRunner/TestInvocation.cpp:
1445         (WTR::TestInvocation::invoke): Removed dead code that handled a timeout from NoTimeout.
1446
1447         * WebKitTestRunner/efl/TestControllerEfl.cpp:
1448         (WTR::TestController::platformRunUntil):
1449         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
1450         (WTR::TestController::platformRunUntil):
1451         Build fixes.
1452
1453 2015-01-02  Anders Carlsson  <andersca@apple.com>
1454
1455         Remove now unused storage tracker glue from DumpRenderTree
1456         https://bugs.webkit.org/show_bug.cgi?id=140045
1457
1458         Reviewed by Darin Adler.
1459
1460         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1461         * DumpRenderTree/StorageTrackerDelegate.h: Removed.
1462         * DumpRenderTree/StorageTrackerDelegate.mm: Removed.
1463         * DumpRenderTree/TestRunner.cpp:
1464         (TestRunner::staticFunctions):
1465         (syncLocalStorageCallback): Deleted.
1466         (observeStorageTrackerNotificationsCallback): Deleted.
1467         (deleteAllLocalStorageCallback): Deleted.
1468         (deleteLocalStorageForOriginCallback): Deleted.
1469         (localStorageDiskUsageForOriginCallback): Deleted.
1470         (originsWithLocalStorageCallback): Deleted.
1471         * DumpRenderTree/TestRunner.h:
1472         * DumpRenderTree/mac/DumpRenderTree.mm:
1473         (allocateGlobalControllers):
1474         (releaseGlobalControllers):
1475         * DumpRenderTree/mac/DumpRenderTreeMac.h:
1476         * DumpRenderTree/mac/TestRunnerMac.mm:
1477         (TestRunner::syncLocalStorage): Deleted.
1478         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1479         (TestRunner::observeStorageTrackerNotifications): Deleted.
1480         (TestRunner::deleteAllLocalStorage): Deleted.
1481         (TestRunner::originsWithLocalStorage): Deleted.
1482         (TestRunner::deleteLocalStorageForOrigin): Deleted.
1483         * DumpRenderTree/win/TestRunnerWin.cpp:
1484         (TestRunner::syncLocalStorage): Deleted.
1485         (TestRunner::localStorageDiskUsageForOrigin): Deleted.
1486         (TestRunner::observeStorageTrackerNotifications): Deleted.
1487         (TestRunner::deleteAllLocalStorage): Deleted.
1488         (TestRunner::originsWithLocalStorage): Deleted.
1489         (TestRunner::deleteLocalStorageForOrigin): Deleted.
1490
1491 2015-01-01  Darin Adler  <darin@apple.com>
1492
1493         We often misspell identifier as "identifer"
1494         https://bugs.webkit.org/show_bug.cgi?id=140025
1495
1496         Reviewed by Michael Saboff.
1497
1498         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
1499         * Scripts/webkitdirs.pm:
1500         (appIdentifierFromBundle):
1501         (installAndLaunchIOSWebKitAppInSimulator):
1502         Fix misspellings
1503
1504 2015-01-01  Zalan Bujtas  <zalan@apple.com>
1505
1506         Saturated arithmetics: Incorrect float/double clamping.
1507         https://bugs.webkit.org/show_bug.cgi?id=139888
1508         rdar://problem/19330885
1509
1510         Reviewed by Simon Fraser.
1511
1512         Clamp float and double values correctly when applying saturated arithmetics.
1513
1514         * TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:
1515         (TestWebKitAPI::TEST):
1516
1517 2014-12-30  Krzysztof Czech  <k.czech@samsung.com>
1518
1519         [EFL] Bump version of ATK used by jhbuild to 2.15.2
1520         https://bugs.webkit.org/show_bug.cgi?id=139816
1521
1522         Reviewed by Gyuyoung Kim.
1523
1524         Bump version of ATK used by jhbuild to 2.15.2
1525
1526         * efl/jhbuild.modules:
1527
1528 2014-12-29  Fabien Vallée  <fvallee@connected-labs.com>
1529
1530         [jhBuild] cairo build error (-flto)
1531         https://bugs.webkit.org/show_bug.cgi?id=139056
1532
1533         Reviewed by Philippe Normand.
1534
1535         cairo fails to link  with gcc 4.9 due to lto
1536         related issue. This problem has been partially
1537         addressed by cairo:
1538         http://cgit.freedesktop.org/cairo/commit/?id=c3645d97ebd24c6f7ad850785d585aebc706a11c
1539         use the cairo --disable-lto option and remove jhbuild
1540         makeargs fixes the issue.
1541
1542         * gtk/jhbuild.modules:
1543         * gtk/patches/cairo-1.12.8-add_disable-lto.patch: Added.
1544
1545 2014-12-27  Myles C. Maxfield  <mmaxfield@apple.com>
1546         [Mac] Enable kerning, ligatures, and printer fonts 
1547         https://bugs.webkit.org/show_bug.cgi?id=139970
1548
1549         Rubber stamped by Simon Fraser.
1550
1551         Flip the switch.
1552
1553         * DumpRenderTree/mac/DumpRenderTree.mm:
1554         * WebKitTestRunner/TestController.cpp:
1555         * WebKitTestRunner/mac/main.mm:
1556
1557 2014-12-26  Dan Bernstein  <mitz@apple.com>
1558
1559         <rdar://problem/19348208> REGRESSION (r177027): iOS builds use the wrong toolchain
1560         https://bugs.webkit.org/show_bug.cgi?id=139950
1561
1562         Reviewed by David Kilzer.
1563
1564         * asan/asan.xcconfig: Only define TOOLCHAINS when building for OS X, doing so
1565         in a manner that works with Xcode 5.1.1.
1566
1567 2014-12-24  Dan Bernstein  <mitz@apple.com>
1568
1569         Engineering builds of MiniBrowser ignore deprecated declaration warnings
1570         https://bugs.webkit.org/show_bug.cgi?id=139941
1571
1572         Reviewed by Darin Adler.
1573
1574         * MiniBrowser/Configurations/Base.xcconfig: Added semicolon.
1575         * MiniBrowser/Configurations/DebugRelease.xcconfig: Set GCC_WARN_ABOUT_DEPRECATED_FUNCTIONS
1576         to YES.
1577         * MiniBrowser/mac/AppDelegate.m:
1578         (-[BrowserAppDelegate openDocument:]): Use NSFileHandlingPanelOKButton instead of
1579         deprecated NSOKButton.
1580
1581 2014-12-24  Youenn Fablet  <youenn.fablet@crf.canon.fr>
1582
1583         W3C test importer should have an option to disable testharness.js/testharnessreport.js link conversion
1584         https://bugs.webkit.org/show_bug.cgi?id=134763
1585
1586         Reviewed by Ryosuke Niwa.
1587
1588         Adding an option to disable test harness link conversion.
1589
1590         * Scripts/webkitpy/w3c/test_converter.py:
1591         (convert_for_webkit):
1592         (_W3CTestConverter.__init__):
1593         (_W3CTestConverter.convert_attributes_if_needed):
1594         * Scripts/webkitpy/w3c/test_importer.py:
1595         (parse_args):
1596         (TestImporter.import_tests):
1597
1598 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1599
1600         DumpRenderTree crashes are mis-reported as timeouts on Yosemite
1601         https://bugs.webkit.org/show_bug.cgi?id=139933
1602
1603         Reviewed by Daniel Bates.
1604
1605         Crash logs take a very long time to be generated on Yosemite (rdar://problem/18701447),
1606         and there is no way for run-webkit-tests to tell a crashed process from a frozen one
1607         until ReportCrash lets it go.
1608
1609         Reuse existing machinery that tells run-webkit-tests about crashes. The script may
1610         even get the actual crash log eventually - even when it times out waiting for the log, it
1611         makes a second lookup at the very end, after all tests finish. There may be further
1612         improvements needed here, but this small fix addresses most cases that happen in practice.
1613
1614         * DumpRenderTree/mac/DumpRenderTree.mm:
1615         (writeCrashedMessageOnFatalError):
1616         (dumpRenderTree):
1617         Removed PLATFORM(IOS) ifdefs, this code is just as helpful on Mac.
1618
1619         * Scripts/webkitpy/port/driver.py: (Driver._check_for_driver_crash): Removed an
1620         unhelpful comment.
1621
1622 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1623
1624         Don't force -O1 for debug ASan builds
1625         https://bugs.webkit.org/show_bug.cgi?id=139926
1626
1627         Reviewed by Darin Adler.
1628
1629         * asan/asan.xcconfig:
1630
1631 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1632
1633         Simplify building with ASan
1634         https://bugs.webkit.org/show_bug.cgi?id=139916
1635
1636         Reviewed by Mark Rowe.
1637
1638         * Scripts/set-webkit-configuration: Store ASan state into a new configuration file.
1639         We could also update Configuration file format, but that's a little scary because
1640         of how many places in code read it.
1641
1642         * Scripts/webkitdirs.pm:
1643         (determineASanIsEnabled): Read it from ASan configuration file.
1644         (argumentsForConfiguration): Added a FIXME.
1645         (asanIsEnabled): A caching wrapper similar to what we have for other configuration options.
1646         (XcodeOptions): Pass the options needed for ASan.
1647
1648         * asan/asan.xcconfig: Use the right toolchains. Made warnings fatal again, as there
1649         no warnings to avoid. Removed explicit linking options, as -fsanitize=address does
1650         that automatically.
1651
1652 2014-12-23  Alexey Proskuryakov  <ap@apple.com>
1653
1654         TestWebKitAPI build is broken when ASan is enabled
1655         https://bugs.webkit.org/show_bug.cgi?id=139902
1656
1657         Reviewed by Darin Adler.
1658
1659         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
1660         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig:
1661         Inherit linker flags from DebugRelease, which respects ASAN.
1662
1663 2014-12-22  Simon Fraser  <simon.fraser@apple.com>
1664
1665         Sort the Xcode project file.
1666
1667         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1668
1669 2014-12-22  Lucas Forschler  <lforschler@apple.com>
1670
1671         Update apple-mac-114 to bot629.
1672         
1673         Unreviewed.
1674         
1675         * BuildSlaveSupport/build.webkit.org-config/config.json:
1676
1677 2014-12-22  Lucas Forschler  <lforschler@apple.com>
1678
1679         Replace Apple bot104 with bot124.
1680         
1681         Unreviewed.
1682         
1683         * BuildSlaveSupport/build.webkit.org-config/config.json:
1684
1685 2014-12-22  Csaba Osztrogonác  <ossy@webkit.org>
1686
1687         URTBF after r177639.
1688
1689         * TestWebKitAPI/CMakeLists.txt:
1690
1691 2014-12-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
1692
1693         [EFL] MiniBrowser steals web view's focus
1694         https://bugs.webkit.org/show_bug.cgi?id=139482
1695
1696         Reviewed by Gyuyoung Kim.
1697
1698         Although we set focus on ewk_view while MiniBrowser initialization
1699         Ecore steals it in a favor of main window. As a result
1700         focused element on web page is unable to receive events.
1701
1702         * MiniBrowser/efl/main.c:
1703         (window_create):
1704         Prevent window from stealing web view's focus on start up.
1705
1706 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
1707
1708         [Win] Revise DRT logic to match Mac.
1709
1710         Rubberstamped by Anders Carlsson.
1711
1712         Update the Windows logic to perform initialization of preferences and WebKit
1713         settings to match Mac. Also make sure that we only ever emit #EOF tokens under
1714         the same circumstances as the Mac version.
1715
1716         * DumpRenderTree/win/DumpRenderTree.cpp:
1717         (dump):
1718         (resetWebPreferencesToConsistentValues):
1719         (setDefaultsToConsistentValuesForTesting):
1720         (resetWebViewToConsistentStateBeforeTesting):
1721         (sizeWebViewForCurrentTest):
1722         (runTest):
1723         (createWebViewAndOffscreenWindow):
1724         (allocateGlobalControllers):
1725         (prepareConsistentTestingEnvironment):
1726         (main):
1727         (resetDefaultsToConsistentValues): Deleted.
1728
1729 2014-12-19  Roger Fong  <roger_fong@apple.com>
1730
1731         Unreviewed. Rollout r177605.
1732
1733         * EWSTools/start-queue-win.sh:
1734
1735 2014-12-19  Roger Fong  <roger_fong@apple.com>
1736
1737         Unreviewed. Try running EWS scripts without —no-confirm, since it defaults to true.
1738
1739         * EWSTools/start-queue-win.sh:
1740
1741 2014-12-19  Daniel Bates  <dabates@apple.com>
1742
1743         [iOS] Add WebKitSystemInterface for iOS 8.1
1744         https://bugs.webkit.org/show_bug.cgi?id=139831
1745
1746         Reviewed by Alexey Proskuryakov.
1747
1748         Implement support in copy-webkitlibraries-to-product-directory to copy
1749         WebKitSystemInterface for iOS to the product directory and have build-webkit
1750         pass --wksi to copy-webkitlibraries-to-product-directory when building for iOS.
1751
1752         * Scripts/build-webkit:
1753         * Scripts/copy-webkitlibraries-to-product-directory:
1754
1755 2014-12-19  Daniel Bates  <dabates@apple.com>
1756
1757         copy-webkitlibraries-to-product-directory uses wrong SDK when called from build-webkit
1758         https://bugs.webkit.org/show_bug.cgi?id=139829
1759
1760         Reviewed by Alexey Proskuryakov.
1761
1762         The script build-webkit calls script copy-webkitlibraries-to-product-directory with
1763         argument --sdk to specify the Xcode SDK to use, but copy-webkitlibraries-to-product-directory
1764         expects the Xcode SDK to be specified using the --sdk-name command line argument.
1765
1766         Currently copy-webkitlibraries-to-product-directory has its own logic to handle
1767         parsing for a specified Xcode SDK. Instead we should make use of the webkitdirs.pm
1768         logic to both avoid duplicating effort and make the command line options for
1769         copy-webkitlibraries-to-product-directory for specify the Xcode SDK consistent
1770         with the approach used in other WebKit tools.
1771
1772         As a side effect of making use of the webkitdirs.pm logic for determining the Xcode SDK
1773         copy-webkitlibraries-to-product-directory now recognizes --device and --simulator
1774         shorthands for --sdk=iphoneos.internal and --sdk=iphonesimulator, respectively.
1775
1776         * Scripts/copy-webkitlibraries-to-product-directory: Also, renamed some variables to
1777         improve the readability of the code.
1778         (executeRanlib): Added; convenience function that calls the RANLIB(1) with the appropriate
1779         Xcode SDK. We pass -no_warning_for_no_symbols to RANLIB(1) when using an Xcode SDK
1780         for iOS since it's acceptable that an empty object file (say, for a Mac-specific feature)
1781         be included in a library.
1782         (unpackIfNecessary): Modified to call executeRanlib().
1783
1784 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
1785
1786         REGRESSION (177368): Some tests started to immediately time out
1787         https://bugs.webkit.org/show_bug.cgi?id=139826
1788
1789         Reviewed by Daniel Bates.
1790
1791         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::done):
1792         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::InjectedBundlePage::dump):
1793         Move invalidateWaitToDumpWatchdogTimer() call from dump() to done(). When a test
1794         ends in a load failure, we don't dump, so we used to leak the timer.
1795         
1796         * WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::notifyDone):
1797         Added a comment.
1798
1799 2014-12-19  Brent Fulgham  <bfulgham@apple.com>
1800
1801         [Win] Add accessor for serializing HTTP loads
1802         https://bugs.webkit.org/show_bug.cgi?id=139817
1803
1804         Reviewed by Mark Lam.
1805
1806         * DumpRenderTree/win/DumpRenderTree.cpp: Reset serialized HTTP loads in our reset method.
1807         * DumpRenderTree/win/TestRunnerWin.cpp: Provide implementation for serializing HTTP. Also
1808         remove some redundant code from the destructor.
1809
1810 2014-12-19  Alexey Proskuryakov  <ap@apple.com>
1811
1812         Clean up a fix for performance test bot failing to build
1813         https://bugs.webkit.org/show_bug.cgi?id=139818
1814
1815         Reviewed by Csaba Osztrogonác.
1816
1817         The "_1" in step name was annoying.
1818
1819         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1820         (CleanBuildIfScheduled.start):
1821         (RunAndUploadPerfTests):
1822         (DownloadAndPerfTestFactory.__init__):
1823         (DownloadAndPerfTestWebKit2Factory.__init__):
1824         (CleanBuildUnconditionally): Deleted.
1825         (CleanBuildUnconditionally.start): Deleted.
1826
1827 2014-12-19  Csaba Osztrogonác  <ossy@webkit.org>
1828
1829         REGRESSION(r177535): It broke the GTK performance bot
1830         https://bugs.webkit.org/show_bug.cgi?id=139811
1831
1832         Reviewed by Carlos Garcia Campos.
1833
1834         Trigger clean build only on mac platform.
1835
1836         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1837         (DownloadAndPerfTestFactory.__init__):
1838         (DownloadAndPerfTestWebKit2Factory.__init__):
1839
1840 2014-12-18  KwangHyuk Kim  <hyuki.kim@samsung.com>
1841
1842         Unreviewed, moved myself to the list of committers.
1843
1844         * Scripts/webkitpy/common/config/contributors.json:
1845
1846 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
1847
1848         [Win] Update DumpRenderTree to more closely match Mac version
1849         https://bugs.webkit.org/show_bug.cgi?id=139799
1850
1851         Reviewed by Tim Horton.
1852
1853         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1854         (AccessibilityController::accessibleElementById): Correct
1855         use of BSTR to avoid leak.
1856         * DumpRenderTree/win/DumpRenderTree.cpp: Reorder methods and
1857         update to match Mac version more closely.
1858         (dumpFramesAsText):
1859         (dump):
1860         (resetDefaultsToConsistentValues):
1861         (resetWebViewToConsistentStateBeforeTesting):
1862         (sizeWebViewForCurrentTest):
1863         (runTest):
1864         (openWindows):
1865         (windowToWebViewMap):
1866         (createWebViewAndOffscreenWindow):
1867         (sharedCFURLCache):
1868         (initializeGlobalsFromCommandLineOptions):
1869         (main):
1870         * DumpRenderTree/win/TestRunnerWin.cpp: Ditto.
1871         (TestRunner::addDisallowedURL):
1872         (TestRunner::applicationCacheDiskUsageForOrigin):
1873         (TestRunner::syncLocalStorage):
1874         (TestRunner::localStorageDiskUsageForOrigin):
1875         (TestRunner::observeStorageTrackerNotifications):
1876         (TestRunner::clearApplicationCacheForOrigin):
1877         (TestRunner::originsWithApplicationCache):
1878         (TestRunner::deleteAllLocalStorage):
1879         (TestRunner::setStorageDatabaseIdleInterval):
1880         (TestRunner::closeIdleLocalStorageDatabases):
1881         (TestRunner::originsWithLocalStorage):
1882         (TestRunner::deleteLocalStorageForOrigin):
1883         (TestRunner::copyDecodedHostName):
1884         (TestRunner::copyEncodedHostName):
1885         (TestRunner::keepWebHistory):
1886         (TestRunner::numberOfPendingGeolocationPermissionRequests):
1887         (TestRunner::setAppCacheMaximumSize):
1888         (TestRunner::setCustomPolicyDelegate):
1889         (TestRunner::goBack):
1890         (TestRunner::setDefersLoading):
1891         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
1892         (TestRunner::setMockDeviceOrientation):
1893         (TestRunner::setMockGeolocationPosition):
1894         (TestRunner::setMockGeolocationPositionUnavailableError):
1895         (TestRunner::setIconDatabaseEnabled):
1896         (TestRunner::setMainFrameIsFirstResponder):
1897         (TestRunner::setSpatialNavigationEnabled):
1898         (TestRunner::setPluginsEnabled):
1899         (TestRunner::setAutomaticLinkDetectionEnabled):
1900         (TestRunner::setUseDashboardCompatibilityMode):
1901         (TestRunner::dispatchPendingLoadRequests):
1902         (TestRunner::findString):
1903         (TestRunner::setCacheModel):
1904         (TestRunner::apiTestNewWindowDataLoadBaseURL):
1905         (TestRunner::setWebViewEditable):
1906         (TestRunner::authenticateSession):
1907         (TestRunner::abortModal):
1908         (TestRunner::setSerializeHTTPLoads):
1909         (TestRunner::addChromeInputField):
1910         (TestRunner::removeChromeInputField):
1911         (TestRunner::focusWebView):
1912         (TestRunner::setBackingScaleFactor):
1913         (TestRunner::grantWebNotificationPermission):
1914         (TestRunner::denyWebNotificationPermission):
1915         (TestRunner::removeAllWebNotificationPermissions):
1916         (TestRunner::simulateWebNotificationClick):
1917
1918 2014-12-18  Gavin Barraclough  <barraclough@apple.com>
1919
1920         Add strong typing to RefCounter interface, return value as a bool.
1921         https://bugs.webkit.org/show_bug.cgi?id=139776
1922
1923         Reviewed by Geoff Garen.
1924
1925         Currently all token vended by a RefCounter have the same type - Ref<RefCounter::Count>.
1926         This means there is no compile time type checking to prevent mistakes. Update the count()
1927         method to token<>(), templated on type used to identify the token being returned.
1928         Calls to token<T>() will return a result of type RefCounter::Token<T>.
1929
1930         There are a few problems with the fact the counter will return you an exact count of the
1931         number of outstanding tokens:
1932           - It is desirable to only fire the callback on zero-edge changes; it is more consistent
1933             to do so if the value is only readable as a boolean.
1934           - It is desirable to provide the value as an argument to the callback, however to make
1935             this useful for integer values it is also necessary to indicate the direction of change
1936             (0->1 is often interesting where 2->1 is not).
1937           - There is a mismatch between the precision of returning a count, and the inherent
1938             imprecision of a token based mechanism, where it may be difficult to guarantee
1939             absolutely no unnecessary refcount churn, and thus unintentional counter values.
1940
1941         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
1942         (TestWebKitAPI::TEST):
1943             - update API test.
1944
1945 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1946
1947         Disable retries on Mac Release WK2 testers
1948         https://bugs.webkit.org/show_bug.cgi?id=139798
1949
1950         Reviewed by Simon Fraser.
1951
1952         * BuildSlaveSupport/build.webkit.org-config/config.json:
1953
1954 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1955
1956         Perf tests frequently fail saying "build not up to date"
1957         https://bugs.webkit.org/show_bug.cgi?id=139786
1958
1959         Illegitimately yet authoritatively reviewed by Lucas Forschler.
1960
1961         Undo the rest of the first fix, and implement the behavior differently.
1962
1963         is_clean isn't automatically forwarded from config.json to properties.
1964
1965         * BuildSlaveSupport/build.webkit.org-config/config.json:
1966         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1967         (CleanBuildUnconditionally):
1968         (CleanBuildUnconditionally.start):
1969         (DownloadAndPerfTestFactory.__init__):
1970         (DownloadAndPerfTestWebKit2Factory.__init__):
1971
1972 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1973
1974         Roll out part of the previous patch - BuildAndPerfTestWebKit2 is used by Efl.
1975         I thought that it was unused because grepping for BuildAndPerfTestWebKit2Factory
1976         found nothing.
1977
1978         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
1979         (BuildAndPerfTestFactory):
1980         (BuildAndPerfTestWebKit2Factory):
1981
1982 2014-12-18  Alexey Proskuryakov  <ap@apple.com>
1983
1984         Perf tests frequently fail saying "build not up to date"
1985         https://bugs.webkit.org/show_bug.cgi?id=139786
1986
1987         Reviewed by Ryosuke Niwa.
1988
1989         Perf tests only build DumpRenderTree, not WebKit itself. Just clean the build
1990         directory to get rid of stale precompiled headers, and let it rebuild
1991         DumpRenderTree each time, that's fast.
1992
1993         Also, removed unused "build and perf test" code.
1994
1995         * BuildSlaveSupport/build.webkit.org-config/config.json:
1996
1997 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
1998
1999         [Win] Unreviewed gardening. Reorder file contents to match Mac version.
2000
2001         Reorder the contents of the TestRunnerWin so that it matches TestRunnerMac. This makes
2002         it easier to see what steps are missing when running under Windows.
2003
2004         * DumpRenderTree/win/TestRunnerWin.cpp:
2005         (TestRunner::callShouldCloseOnWebView):
2006         (TestRunner::clearAllApplicationCaches):
2007         (TestRunner::applicationCacheDiskUsageForOrigin):
2008         (TestRunner::syncLocalStorage):
2009         (TestRunner::localStorageDiskUsageForOrigin):
2010         (TestRunner::observeStorageTrackerNotifications):
2011         (TestRunner::clearApplicationCacheForOrigin):
2012         (TestRunner::originsWithApplicationCache):
2013         (TestRunner::clearAllDatabases):
2014         (TestRunner::deleteAllLocalStorage):
2015         (TestRunner::setStorageDatabaseIdleInterval):
2016         (TestRunner::closeIdleLocalStorageDatabases):
2017         (TestRunner::originsWithLocalStorage):
2018         (TestRunner::deleteLocalStorageForOrigin):
2019         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2020         (jsStringRefToWString):
2021         (TestRunner::setAppCacheMaximumSize):
2022         (TestRunner::setDatabaseQuota):
2023         (TestRunner::goBack):
2024         (TestRunner::setDefersLoading):
2025         (TestRunner::setDomainRelaxationForbiddenForURLScheme):
2026         (TestRunner::setAutomaticLinkDetectionEnabled):
2027         (TestRunner::dispatchPendingLoadRequests):
2028         (TestRunner::overridePreference):
2029         (TestRunner::removeAllVisitedLinks):
2030         (TestRunner::waitForPolicyDelegate):
2031         (TestRunner::resetPageVisibility):
2032         (TestRunner::setPageVisibility):
2033         (TestRunner::grantWebNotificationPermission):
2034         (TestRunner::denyWebNotificationPermission):
2035         (TestRunner::removeAllWebNotificationPermissions):
2036         (TestRunner::simulateWebNotificationClick):
2037         (TestRunner::simulateLegacyWebNotificationClick):
2038
2039 2014-12-18  Brent Fulgham  <bfulgham@apple.com>
2040
2041         [Win] Correct Windows tests after Bug 139149 (edit)
2042         https://bugs.webkit.org/show_bug.cgi?id=139781
2043
2044         Reviewed by Anders Carlsson.
2045
2046         * DumpRenderTree/win/TestRunnerWin.cpp:
2047         (TestRunner::clearAllApplicationCaches): Use new WebApplicationCache
2048         interface.
2049
2050 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
2051
2052         [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts
2053         https://bugs.webkit.org/show_bug.cgi?id=139748
2054
2055         Reviewed by Daniel Bates.
2056         
2057         Staging change to support --ios-sim and --ios-simulator temporarily until the bots
2058         have all been updated.
2059
2060         * Scripts/webkitpy/port/factory.py:
2061         (platform_options):
2062
2063 2014-12-18  Simon Fraser  <simon.fraser@apple.com>
2064
2065         Build more of TestWebKitAPI for iOS
2066         https://bugs.webkit.org/show_bug.cgi?id=139747
2067
2068         Reviewed by Daniel Bates.
2069         
2070         Base.xcconfig removed many test files from the iOS build via EXCLUDED_SOURCE_FILE_NAMES,
2071         which excluded some tests that should be run for iOS.
2072         
2073         Fix by removing some patterns from EXCLUDED_SOURCE_FILE_NAMES, and #ifdeffing
2074         source files instead. config.h defines WK_HAVE_C_SPI when the WebKit C SPI is
2075         available (i.e. Mac OS X), and most files use that. Some files with Mac-only
2076         functionality (ActionMenus, Downloads) use #if PLATFORM(MAC).
2077         
2078         Added PlatformUtilitiesCocoa.mm and moved WeakObjCPtr.mm into a cocoa directory
2079         to share code between Mac and iOS.
2080
2081         * TestWebKitAPI/Configurations/Base.xcconfig:
2082         * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
2083         * TestWebKitAPI/InjectedBundleController.cpp:
2084         * TestWebKitAPI/InjectedBundleMain.cpp:
2085         * TestWebKitAPI/JavaScriptTest.cpp:
2086         * TestWebKitAPI/PlatformUtilities.cpp:
2087         * TestWebKitAPI/PlatformUtilities.h:
2088         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2089         * TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
2090         * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
2091         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
2092         * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
2093         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp:
2094         * TestWebKitAPI/Tests/WebKit2/CloseThenTerminate.cpp:
2095         * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
2096         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
2097         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
2098         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
2099         * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp:
2100         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls.cpp:
2101         * TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
2102         * TestWebKitAPI/Tests/WebKit2/DidNotHandleKeyDown.cpp:
2103         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
2104         * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
2105         * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
2106         * TestWebKitAPI/Tests/WebKit2/EphemeralSessionPushStateNoHistoryCallback.cpp:
2107         * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
2108         * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
2109         * TestWebKitAPI/Tests/WebKit2/Find.cpp:
2110         * TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
2111         * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
2112         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
2113         * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
2114         * TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
2115         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback.cpp:
2116         * TestWebKitAPI/Tests/WebKit2/GetInjectedBundleInitializationUserDataCallback_Bundle.cpp:
2117         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
2118         * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
2119         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
2120         * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
2121         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest.cpp:
2122         * TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
2123         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins.cpp:
2124         * TestWebKitAPI/Tests/WebKit2/InjectedBundleInitializationUserDataCallbackWins_Bundle.cpp:
2125         * TestWebKitAPI/Tests/WebKit2/LayoutMilestonesWithAllContentInFrame.cpp:
2126         * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp:
2127         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
2128         * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
2129         * TestWebKitAPI/Tests/WebKit2/LoadPageOnCrash.cpp:
2130         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
2131         * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
2132         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
2133         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
2134         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
2135         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp:
2136         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp:
2137         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
2138         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
2139         * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
2140         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
2141         * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
2142         * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp:
2143         * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp:
2144         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications.mm:
2145         * TestWebKitAPI/Tests/WebKit2/PasteboardNotifications_Bundle.cpp:
2146         * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
2147         * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp:
2148         * TestWebKitAPI/Tests/WebKit2/ReloadPageAfterCrash.cpp:
2149         * TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
2150         * TestWebKitAPI/Tests/WebKit2/ResizeWindowAfterCrash.cpp:
2151         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
2152         * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
2153         * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
2154         * TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp:
2155         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:
2156         * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp:
2157         * TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:
2158         * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
2159         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad.cpp:
2160         * TestWebKitAPI/Tests/WebKit2/StopLoadingDuringDidFailProvisionalLoad_bundle.cpp:
2161         * TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp:
2162         * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
2163         * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp:
2164         * TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp:
2165         * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp:
2166         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
2167         * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
2168         (TestWebKitAPI::TEST):
2169         * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
2170         * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
2171         * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
2172         * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
2173         * TestWebKitAPI/Tests/WebKit2/WebCoreStatisticsWithNoWebProcess.cpp:
2174         * TestWebKitAPI/Tests/WebKit2/WillLoad.cpp:
2175         * TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
2176         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp:
2177         * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp:
2178         * TestWebKitAPI/Tests/WebKit2/cocoa/WeakObjCPtr.mm: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/mac/WeakObjCPtr.mm.
2179         (TEST):
2180         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
2181         * TestWebKitAPI/Tests/WebKit2Cocoa/UserContentController.mm:
2182         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2183         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm:
2184         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm:
2185         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
2186         * TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm:
2187         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing.mm:
2188         * TestWebKitAPI/Tests/WebKit2ObjC/PreventImageLoadWithAutoResizing_Bundle.cpp:
2189         * TestWebKitAPI/Tests/WebKit2ObjC/UserContentTest.mm:
2190         * TestWebKitAPI/cocoa/PlatformUtilitiesCocoa.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2/WKImageCreateCGImageCrash.cpp.
2191         (TestWebKitAPI::Util::run):
2192         (TestWebKitAPI::Util::sleep):
2193         (TestWebKitAPI::Util::toSTD):
2194         * TestWebKitAPI/config.h:
2195         * TestWebKitAPI/mac/JavaScriptTestMac.mm:
2196         * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
2197         (TestWebKitAPI::Util::run): Deleted.
2198         (TestWebKitAPI::Util::sleep): Deleted.
2199         (TestWebKitAPI::Util::toSTD): Deleted.
2200
2201 2014-12-18  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2202
2203         [GTK] Add support for FTL JIT on ARM64
2204         https://bugs.webkit.org/show_bug.cgi?id=139677
2205
2206         Reviewed by Csaba Osztrogonác.
2207
2208         * gtk/jhbuild-optional.modules:
2209         * gtk/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
2210         * gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
2211
2212 2014-12-18  Adrian Perez de Castro  <aperez@igalia.com>
2213
2214         [GTK] Implement webkit_web_view_is_playing_audio()
2215         https://bugs.webkit.org/show_bug.cgi?id=138918
2216
2217         Reviewed by Carlos Garcia Campos.
2218
2219         Add test case case for webkit_web_view_is_playing_audio() and the
2220         WebKitWebView::is-playing-audio property.
2221
2222         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2223         (urlForResource): Utility function to get URLs pointing to resources
2224         under the Tools/TestWebKitAPI/Tests/WebKit2/ directory.
2225         (testWebViewIsPlayingAudio): Added.
2226         (beforeAll):
2227         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2228         (getResourcesDir): Allow passing a flag to choose from the WebKit2 GTK
2229         API tests resources directory, or the WebKit2 C API tests resources
2230         directory. The default value of the flag is to use the WebKit2 GTK
2231         one, to avoid having to change existing tests.
2232         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2233         (isPlayingAudioChanged): Added.
2234         (WebViewTest::waitUntilIsPlayingAudioChanged): Added.
2235         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2236
2237 2014-12-18  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2238
2239         [GTK] [EFL] Enable per_test_timeout
2240         https://bugs.webkit.org/show_bug.cgi?id=139771
2241
2242         Reviewed by Csaba Osztrogonác.
2243
2244         This is needed to make WKTR use either the default port timeout, or the
2245         user supplied timeout via the "--time-out-ms" parameter of run-webkit-tests.
2246         Otherwise WTR will use the default (30 seconds after r177363 and r177471).
2247
2248         * Scripts/webkitpy/port/efl.py:
2249         (EflPort.supports_per_test_timeout): Enabled.
2250         * Scripts/webkitpy/port/gtk.py:
2251         (GtkPort.supports_per_test_timeout): Enabled.
2252
2253 2014-12-17  Lucas Forschler  <lforschler@apple.com>
2254
2255         Move Apple buildbot slaves to their new home.
2256         
2257         Reviewed by Roger Fong.
2258
2259         * BuildSlaveSupport/build.webkit.org-config/config.json:
2260
2261 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
2262
2263         REGRESSION (r177363): Gtk and Efl testing is broken
2264         https://bugs.webkit.org/show_bug.cgi?id=139734
2265
2266         Reviewed by Simon Fraser.
2267
2268         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2269         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
2270         affected both script and tool timeout. This is still the right place for this logic,
2271         but it would be a larger refactoring than I can do right now.
2272
2273         * Scripts/webkitpy/port/base.py:
2274         (Port.supports_per_test_timeout): Added a FIXME.
2275         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
2276         to avoid making tests take more time.
2277
2278         * Scripts/webkitpy/port/driver.py:
2279         (Driver.run_test): Adjust script timeout here.
2280         (Driver._check_for_driver_timeout): Fix the timeout detection.
2281         (Driver._read_block): Actually use the timeout detection code.
2282
2283         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
2284         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
2285
2286         * Scripts/webkitpy/port/port_testcase.py: (PortTestCase.test_default_timeout_ms):
2287         Update results for the new default.
2288
2289         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2290         (RunTest.test_hung_thread): Restore a test that I previously deleted, it was
2291         actually a good one.
2292
2293 2014-12-17  Commit Queue  <commit-queue@webkit.org>
2294
2295         Unreviewed, rolling out r177456.
2296         https://bugs.webkit.org/show_bug.cgi?id=139749
2297
2298         Broke webkitpy and Mac tests (Requested by ap on #webkit).
2299
2300         Reverted changeset:
2301
2302         "REGRESSION (r177363): Gtk and Efl testing is broken"
2303         https://bugs.webkit.org/show_bug.cgi?id=139734
2304         http://trac.webkit.org/changeset/177456
2305
2306 2014-12-17  Alexey Proskuryakov  <ap@apple.com>
2307
2308         REGRESSION (r177363): Gtk and Efl testing is broken
2309         https://bugs.webkit.org/show_bug.cgi?id=139734
2310
2311         Reviewed by Simon Fraser.
2312
2313         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2314         (SingleTestRunner.__init__): Remove timeout adjustment from here, because it
2315         affected both script and tool timeout. This is still the right place for this logic,
2316         but it would be a larger refactoring than I can do right now.
2317
2318         * Scripts/webkitpy/port/base.py:
2319         (Port.supports_per_test_timeout): Added a FIXME.
2320         (Port.default_timeout_ms): Now that the effective timeout is longer, change this
2321         to avoid making tests take more time.
2322
2323         * Scripts/webkitpy/port/driver.py: (Driver.run_test): Adjust script timeout here.
2324
2325         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp: (WTR::InjectedBundle::beginTesting):
2326         Use TestRunner default timeout when there isn't a timeout passed from command line for the test.
2327
2328 2014-12-17  Carlos Garcia Campos  <cgarcia@igalia.com>
2329
2330         [GTK] Simplify timeout handling in TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded
2331         https://bugs.webkit.org/show_bug.cgi?id=139725
2332
2333         Reviewed by Martin Robinson.
2334
2335         The timeout is already in milliseconds, so we don't need to do any conversion.
2336
2337         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2338         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2339
2340 2014-12-17  Hunseop Jeong  <hs85.jeong@samsung.com>
2341
2342         [EFL]Fix build warning in MiniBrowser
2343         https://bugs.webkit.org/show_bug.cgi?id=139723
2344
2345         Reviewed by Darin Adler.
2346
2347         The warning is caused by the compiler wanting the first argument to be a
2348         string literal, not a dynamically created string.
2349
2350         * MiniBrowser/efl/main.c:
2351         (quit):
2352
2353 2014-12-16  Sam Weinig  <sam@webkit.org>
2354
2355         TestWebKitAPI should use a static lib to support both Mac and iOS cleanly
2356         https://bugs.webkit.org/show_bug.cgi?id=139718
2357
2358         Reviewed by Mark Rowe.
2359
2360         Change TestWebKitAPI to be more like DumpRenderTree by moving all the source
2361         files into a static lib which the command line utility can link link against.
2362         This will allow us to create a TestWebKitAPI.app that can run on iOS.
2363
2364         * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
2365         * TestWebKitAPI/Configurations/TestWebKitAPILibrary.xcconfig: Added.
2366         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2367
2368 2014-12-16  Alexey Proskuryakov  <ap@apple.com>
2369
2370         Sort out timeout implementations in DRT and WKTR
2371         https://bugs.webkit.org/show_bug.cgi?id=139671
2372
2373         Remove an obsolete test that doesn't capture how run-webkit-tests interacts
2374         with the tool.
2375
2376         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2377         (RunTest.test_hung_thread):
2378
2379 2014-12-15  Alexey Proskuryakov  <ap@apple.com>
2380
2381         Sort out timeout implementations in DRT and WKTR
2382         https://bugs.webkit.org/show_bug.cgi?id=139671
2383
2384         Reviewed by Simon Fraser.
2385
2386         Test timeout implementation had many deficiencies, please see the bug for details.
2387         Most notably, we shouldn't have the tool confused about timeouts vs. failures, and
2388         [ Slow ] modifiers should work a lot better.
2389
2390         * DumpRenderTree/TestRunner.cpp: (TestRunner::TestRunner):
2391         * DumpRenderTree/TestRunner.h: (TestRunner::setCustomTimeout):
2392         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest):
2393         * DumpRenderTree/mac/TestRunnerMac.mm: (TestRunner::setWaitToDump):
2394         DumpRenderTree already read the --timeout option from command line, and webkitpy
2395         was already configured to pass it on Mac and iOS. Let's actually use it.
2396         TestCommand already had the same 30 second default, so this doesn't change behavior
2397         when DRT is ran manually without the option.
2398         Windows DumpRenderTree will need to be fixed separately (that's easy).
2399
2400         * DumpRenderTree/TestRunner.cpp: (TestRunner::waitToDumpWatchdogTimerFired()):
2401         Don't print the timeout message to stdout to match WebKitTestRunner. It would be
2402         slightly better to use stderr in both, as this is an out of band message, but
2403         that's a larger refactoring, and the difference is minimal in practice.
2404
2405         * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
2406         (SingleTestRunner.__init__): Ensure that script and tool timeouts are substantially
2407         different. We want the tool to reliably detect timeouts that can be detected, and
2408         not race with the script for that.
2409
2410         * Scripts/webkitpy/port/base.py: (Port.default_timeout_ms): Don't make WebKit2
2411         timeout longer than WebKit1 one, I doubt that this is necessary. Now that the value
2412         is honored inmore cases, that could make tests run slower.
2413         * Scripts/webkitpy/port/driver.py:
2414         (Driver.__init__):
2415         (Driver.run_test):
2416         (Driver.cmd_line):
2417         (Driver._check_for_driver_timeout):
2418         Detect tests that have the timeout output, and make these have the proper Timeout result.
2419
2420         * Scripts/webkitpy/port/ios.py: (IOSSimulatorPort.default_timeout_ms): Remove an
2421         incorrect recent change - 80 * 1000 is 80 seconds, not 80 milliseconds.
2422
2423         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2424         (WTR::TestRunner::setCustomTimeout): Deleted.
2425         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2426         (WTR::TestRunner::setCustomTimeout):
2427         * WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:
2428         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2429         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
2430         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2431         * WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:
2432         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2433         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2434         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2435         Updated to use a timeout passed from UI process, which used to be ignored.
2436
2437         * WebKitTestRunner/TestController.cpp:
2438         (WTR::TestController::TestController):
2439         (WTR::TestController::runUntil):
2440         (WTR::TestController::getCustomTimeout): Deleted.
2441         * WebKitTestRunner/TestController.h:
2442         Delete unused m_timeout. First, it was always 0, and second, we don't need it at all.
2443         Changed default message timeouts to match new run-webkit-tests timeout. These don't
2444         affect ports where timeout is passed per test (shouldn't they all be like that?).
2445
2446         * WebKitTestRunner/TestInvocation.cpp:
2447         (WTR::TestInvocation::invoke):
2448         (WTR::TestInvocation::setCustomTimeout): Deleted.
2449         * WebKitTestRunner/TestInvocation.h:
2450         (WTR::TestInvocation::setCustomTimeout):
2451         (WTR::TestInvocation::customTimeout):
2452         Ditto.
2453
2454 2014-12-16  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2455
2456         [EFL] Add logging domain for MiniBrowser
2457         https://bugs.webkit.org/show_bug.cgi?id=139642
2458
2459         Reviewed by Gyuyoung Kim.
2460
2461         Similarly to EWebKit2, provide logging facility for MiniBrowser
2462         based on Eina Log module to have a convenient way to display
2463         all/subset/none messages for EFL based libraries and MiniBrowser.
2464
2465         Usage:
2466         1. Disable all messages:
2467            EINA_LOG_LEVEL=0 ./Tools/Scripts/run-launcher --efl
2468
2469         2. Enable all messages:
2470            EINA_LOG_LEVEL=7 ./Tools/Scripts/run-launcher --efl
2471
2472         3. Enable MiniBrowser and EWebkit2 messages only:
2473            EINA_LOG_LEVELS="minibrowser:7,ewebkit2:7" ./Tools/Scripts/run-launcher --efl
2474
2475         More information and examples you can find here:
2476         http://docs.enlightenment.org/auto/eet/tutorial_log_page.html
2477
2478         * MiniBrowser/efl/main.c:
2479         (on_mouse_wheel):
2480         (on_window_resize):
2481         (save_page_contents_callback):
2482         (script_execute_callback):
2483         (on_key_down):
2484         (on_download_request):
2485         (on_download_finished):
2486         (on_download_failed):
2487         (quit):
2488         (on_refresh_button_clicked):
2489         (on_stop_button_clicked):
2490         (navigation_button_longpress_process):
2491         (on_popup_menu_item_clicked):
2492         (popup_menu_populate):
2493         (on_popup_menu_show):
2494         (on_window_create):
2495         (context_menu_item_selected_cb):
2496         (context_menu_populate):
2497         (on_context_menu_show):
2498         (on_context_menu_hide):
2499         (on_navigation_policy_decision):
2500         (window_create):
2501         (parse_cookies_policy):
2502         (elm_main):
2503         (has_scheme):
2504         (list_item_label_get):
2505         (on_popup_menu_hide):
2506         (on_window_close):
2507         (on_home_button_clicked):
2508         Replace locally info() macro with newly introduced
2509         one which uses Eina Log module. There is no logic change.
2510
2511 2014-12-15  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
2512
2513         [EFL] FTL JIT not working on ARM64
2514         https://bugs.webkit.org/show_bug.cgi?id=139295
2515
2516         Reviewed by Michael Saboff.
2517
2518         Added patches for llvm to add ARM64 support for FTL JIT
2519
2520         * efl/jhbuild.modules:
2521         * efl/patches/llvm-elf-add-stackmaps-arm64.patch: Added.
2522         * efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range-arm64.patch: Added.
2523
2524 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2525
2526         Move Said to the committers section.
2527
2528         * Scripts/webkitpy/common/config/contributors.json:
2529
2530 2014-12-15  Timothy Horton  <timothy_horton@apple.com>
2531
2532         Implement Data Detectors immediate actions for WebKit2
2533         https://bugs.webkit.org/show_bug.cgi?id=139617
2534         <rdar://problem/19198539>
2535
2536         Reviewed by Beth Dakin.
2537
2538         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm:
2539         (TestWebKitAPI::TEST):
2540         Temporarily disable the action menu tests while the
2541         underlying code is in flux.
2542
2543 2014-12-14  Andreas Kling  <akling@apple.com>
2544
2545         Replace PassRef with Ref/Ref&& across the board.
2546         <https://webkit.org/b/139587>
2547
2548         Reviewed by Darin Adler.
2549
2550         * TestWebKitAPI/Tests/WTF/Ref.cpp:
2551         (TestWebKitAPI::passWithRef):
2552         (TestWebKitAPI::TEST):
2553         (TestWebKitAPI::passWithPassRef): Deleted.
2554         * TestWebKitAPI/Tests/WTF/RefCounter.cpp:
2555         (TestWebKitAPI::TEST):
2556         * TestWebKitAPI/Tests/WTF/RefPtr.cpp:
2557         (TestWebKitAPI::TEST):
2558         * TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
2559         (TestWebKitAPI::createTestValue):
2560
2561 2014-12-13  Grzegorz Czajkowski  <g.czajkowski@samsung.com>
2562
2563         [EFL] MiniBrowser's window_create may return NULL
2564         https://bugs.webkit.org/show_bug.cgi?id=139585
2565
2566         Reviewed by Gyuyoung Kim.
2567
2568         Move NULL checking before using object which window_create
2569         returns.
2570
2571         * MiniBrowser/efl/main.c:
2572         (elm_main):
2573
2574 2014-12-12  Alexey Proskuryakov  <ap@apple.com>
2575
2576         Layout Test http/tests/loading/307-after-303-after-post.html is flaky
2577         https://bugs.webkit.org/show_bug.cgi?id=73030
2578
2579         Reviewed by Anders Carlsson.
2580
2581         * WebKitTestRunner/TestController.cpp: (WTR::TestController::initialize): Set icon
2582         database to empty to avoid having it fetch default favicons at random times.
2583         DumpRenderTree also disables it, and also it has a way for tests to temporarily
2584         enable it.
2585
2586 2014-12-12  Lucas Forschler  <lforschler@apple.com>
2587
2588         Update Apple owned build slaves after infrastructure update.
2589         
2590         Reviewed by Ryosuke Niwa.
2591
2592         * BuildSlaveSupport/build.webkit.org-config/config.json:
2593
2594 2014-12-11  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2595
2596         [GTK] REGRESSION(r175555) GTK API Tests run outside the JHBuild.
2597         https://bugs.webkit.org/show_bug.cgi?id=139537
2598
2599         Reviewed by Carlos Garcia Campos.
2600
2601         * jhbuild/jhbuild-wrapper: Pass the port name in the invocation
2602         of get_dependencies_path().
2603         * jhbuild/jhbuildutils.py:
2604         (get_dependencies_path): Fix the function to return the new
2605         dependencies path: DependenciesPORT.
2606         (enter_jhbuild_environment_if_available): Pass the port name
2607         when invoking get_dependencies_path().
2608
2609 2014-12-10  Lucas Forschler  <lforschler@apple.com>
2610
2611         Update Apple owned build slaves.
2612         
2613         Rubber-stamped by Dana Burkart.
2614         
2615         * BuildSlaveSupport/build.webkit.org-config/config.json:
2616
2617 2014-12-10  Daniel Bates  <dabates@apple.com>
2618
2619         [iOS] REGRESSION (r174642): Watchdog timer expiration reported as DumpRenderTree.app
2620         timeout instead of test failure
2621         https://bugs.webkit.org/show_bug.cgi?id=139525
2622
2623         Reviewed by Zalan Bujtas.
2624
2625         Increase the default process timeout limit in run-webkit-tests to 80ms to prevent
2626         run-webkit-tests from prematurely terminating DumpRenderTree.app before it dumps
2627         output.
2628
2629         Following <http://trac.webkit.org/changeset/174642>, DumpRenderTree.app waits
2630         for the WebThread to spin its run loop before dumping its output. A test that
2631         calls testRunner.waitUntilDone() and does not subsequently call testRunner.notifyDone()
2632         before DumpRenderTree.app's watchdog timer expires may be incorrectly reported
2633         by run-webkit-tests as a DumpRenderTree.app timeout instead of a test failure
2634         because run-webkit-tests may terminate a DumpRenderTree.app process when it
2635         exceeds its process time limit (defaults to 35ms) regardless of whether such
2636         a DumpRenderTree.app process was waiting for the WebThread to run so as to dump output.
2637
2638         * Scripts/webkitpy/port/ios.py:
2639         (IOSSimulatorPort.default_timeout_ms):
2640
2641 2014-12-09  Gustavo Noronha Silva  <gustavo.noronha@collabora.com>
2642
2643         [GTK][WK2] Add HTML5 Notifications support
2644         https://bugs.webkit.org/show_bug.cgi?id=61140
2645
2646         Reviewed by Carlos Garcia Campos.
2647
2648         * Scripts/webkitperl/FeatureList.pm: enable notifications for GTK+.
2649         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2650         (testWebViewNotification):
2651         (beforeAll):
2652         * MiniBrowser/gtk/BrowserWindow.c: also handle notification permission requests.
2653         (permissionRequestDialogCallback):
2654         (webViewDecidePermissionRequest):
2655         (geolocationRequestDialogCallback): Deleted.
2656
2657 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
2658
2659         Fix webkitpy test expectation
2660
2661         Not sure what I messed up, but TOTAL_SKIPS was not right.
2662
2663         * Scripts/webkitpy/port/test.py:
2664
2665 2014-12-09  Benjamin Poulain  <bpoulain@apple.com>
2666
2667         Remove virtual test support from webkitpy
2668         https://bugs.webkit.org/show_bug.cgi?id=139427
2669
2670         Reviewed by Alexey Proskuryakov.
2671
2672         It seems that the only concrete client of virtual tests is the unit tests :D
2673
2674         This patch tries to clean as much useless code as possible.
2675
2676         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
2677         (RunTest.test_tolerance):
2678         (RunTest.test_virtual): Deleted.
2679         * Scripts/webkitpy/layout_tests/views/printing.py:
2680         (Printer._print_test_trace):
2681         * Scripts/webkitpy/port/base.py:
2682         (Port.expected_filename):
2683         (Port.tests):
2684         (Port.test_isfile):
2685         (Port.test_isdir):
2686         (Port.sample_process):
2687         (Port.find_system_pid):
2688         (Port.test_expectations_file_position):
2689         (Port.virtual_test_suites): Deleted.
2690         (Port): Deleted.
2691         (Port.populated_virtual_test_suites): Deleted.
2692         (Port._virtual_tests): Deleted.
2693         (Port.lookup_virtual_test_base): Deleted.
2694         (Port.lookup_virtual_test_args): Deleted.
2695         (VirtualTestSuite): Deleted.
2696         (VirtualTestSuite.__init__): Deleted.
2697         (VirtualTestSuite.__repr__): Deleted.
2698         * Scripts/webkitpy/port/base_unittest.py:
2699         (PortTest.test_test_exists):
2700         (PortTest.test_test_isfile):
2701         (PortTest.test_test_isdir):
2702         (PortTest.test_tests):
2703         * Scripts/webkitpy/port/driver.py:
2704         (DriverProxy.run_test): Deleted.
2705         * Scripts/webkitpy/port/test.py:
2706         (TestPort._skipped_tests_for_unsupported_features):
2707         (TestPort.all_baseline_variants):
2708         (TestPort.virtual_test_suites): Deleted.
2709         * Scripts/webkitpy/tool/commands/queries.py:
2710         (PrintBaselines.__init__):
2711         (PrintBaselines.execute):
2712         * Scripts/webkitpy/tool/commands/queries_unittest.py:
2713         (PrintBaselinesTest.test_basic):
2714         (PrintBaselinesTest.test_multiple):
2715         (PrintBaselinesTest.test_csv):
2716
2717 2014-12-09  Csaba Osztrogonác  <ossy@webkit.org>
2718
2719         Blink Merge: Remove 'http_lock' code from webkitpy
2720         https://bugs.webkit.org/show_bug.cgi?id=136722
2721
2722         Reviewed by Alexey Proskuryakov.
2723
2724         Based on Blink commit by Dirk Pranke <dpranke@chromium.org>
2725         https://chromium.googlesource.com/chromium/blink/+/196f8146a948275c2f1594b13e30ab19a6e6fd66
2726
2727         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
2728         (LayoutTestRunner.__init__):
2729         (LayoutTestRunner.run_tests):
2730         (LayoutTestRunner.start_servers): Renamed from start_servers_with_lock.
2731         (LayoutTestRunner.stop_servers): Renamed from stop_servers_with_lock.
2732         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
2733         (FakePrinter.flush):
2734         (LayoutTestRunnerTests._runner):
2735         (LayoutTestRunnerTests._run_tests):
2736         (LayoutTestRunnerTests.test_servers_started):
2737         (LockCheckingRunner): Deleted.
2738         (LockCheckingRunner.__init__): Deleted.
2739         (LockCheckingRunner.handle_finished_list): Deleted.
2740         (LayoutTestRunnerTests.test_http_locking): Deleted.
2741         * Scripts/webkitpy/port/base.py:
2742         (Port.__init__):
2743         (Port.to.http_server_supports_ipv6):
2744         (Port.to.stop_websocket_server):
2745         (Port.to.acquire_http_lock): Deleted.
2746         (Port.to.release_http_lock): Deleted.
2747         * Scripts/webkitpy/port/http_lock.py: Removed.
2748         * Scripts/webkitpy/port/http_lock_unittest.py: Removed.
2749         * Scripts/webkitpy/port/ios.py:
2750         (IOSSimulatorPort.show_results_html_file):
2751         (IOSSimulatorPort.acquire_http_lock): Deleted.
2752         (IOSSimulatorPort): Deleted.
2753         (IOSSimulatorPort.release_http_lock): Deleted.
2754         * Scripts/webkitpy/port/mac.py:
2755         (MacPort.show_results_html_file):
2756         (MacPort): Deleted.
2757         (MacPort.acquire_http_lock): Deleted.
2758         (MacPort.release_http_lock): Deleted.
2759         * Scripts/webkitpy/port/mock_drt.py:
2760         (MockDRTPort.start_websocket_server):
2761         (MockDRTPort.stop_websocket_server):
2762         (MockDRTPort.acquire_http_lock): Deleted.
2763         (MockDRTPort.release_http_lock): Deleted.
2764         * Scripts/webkitpy/port/mock_drt_unittest.py:
2765         (MockDRTPortTest.test_uses_apache):
2766         (MockDRTPortTest.integration_test_http_lock): Deleted.
2767         * Scripts/webkitpy/port/port_testcase.py:
2768         (PortTestCase.assert_servers_are_up):
2769         (PortTestCase.integration_test_http_lock): Deleted.
2770         * Scripts/webkitpy/port/test.py:
2771         (TestPort.start_websocket_server):
2772         (TestPort.stop_websocket_server):
2773         (TestPort.acquire_http_lock): Deleted.
2774         (TestPort.release_http_lock): Deleted.
2775
2776 2014-12-09  Alberto Garcia  <berto@igalia.com>
2777
2778         convertToUTF8String converts null string to empty string
2779         https://bugs.webkit.org/show_bug.cgi?id=133904
2780
2781         Reviewed by Carlos Garcia Campos.
2782
2783         Test that trying to get the value of a non-existent attribute
2784         returns 0 instead of an empty string.
2785
2786         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
2787         (WebKitDOMNodeTest::testInsertion):
2788
2789 2014-12-09  Joanmarie Diggs  <jdiggs@igalia.com>
2790
2791         [GTK] Bump minimum version of ATK used by jhbuild to at least 2.15.2
2792         https://bugs.webkit.org/show_bug.cgi?id=139070
2793
2794         Reviewed by Carlos Garcia Campos.
2795
2796         * gtk/jhbuild.modules:
2797
2798 2014-12-08  Tim Horton  <timothy_horton@apple.com>
2799
2800         Add action menu tests
2801         https://bugs.webkit.org/show_bug.cgi?id=139156
2802
2803         Reviewed by Dean Jackson.
2804
2805         * TestWebKitAPI/PlatformWebView.h:
2806         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
2807         (TestWebKitAPI::PlatformWebView::PlatformWebView):
2808         Add a mechanism allowing tests to provide their own WKView subclass.
2809
2810         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2811         * TestWebKitAPI/Tests/WebKit2/action-menu-targets.html: Added.
2812         Add a file with lots of menu targets.
2813
2814         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenus.mm: Added.
2815         (-[ActionMenusTestWKView _actionMenuItemsForHitTestResult:withType:defaultActionMenuItems:userData:]):
2816         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preMenuNeedsUpdateHandler:preWillOpenMenuHandler:preDidCloseMenuHandler:]):
2817         (-[ActionMenusTestWKView runMenuSequenceAtPoint:preDidCloseMenuHandler:]):
2818         Run through the normal sequence of callbacks, recording what items and type were returned, and give clients a chance to do work at various points in the process.
2819
2820         (-[ActionMenusTestWKView _setOverrideActionMenuItems:]):
2821
2822         (TestWebKitAPI::didFinishLoadForFrameCallback):
2823         (TestWebKitAPI::didFinishDownloadCallback):
2824         (TestWebKitAPI::didCreateDownloadDestinationCallback):
2825         Watch downloads and ensure that they match the content we expect.
2826
2827         (TestWebKitAPI::watchPasteboardForString):
2828         (TestWebKitAPI::watchPasteboardForImage):
2829         (TestWebKitAPI::JavaScriptStringCallbackContext::JavaScriptStringCallbackContext):
2830         (TestWebKitAPI::JavaScriptBoolCallbackContext::JavaScriptBoolCallbackContext):
2831         (TestWebKitAPI::javaScriptStringCallback):
2832         (TestWebKitAPI::javaScriptBoolCallback):
2833         (TestWebKitAPI::callJavaScriptReturningString):
2834         (TestWebKitAPI::callJavaScriptReturningBool):
2835         (TestWebKitAPI::watchEditableAreaForString):
2836         (TestWebKitAPI::waitForVideoReady):
2837         (TestWebKitAPI::retrieveSelection):
2838         (TestWebKitAPI::retrieveSelectionInElement):
2839         (TestWebKitAPI::performMenuItemAtIndexOfTypeAsync):
2840         (TestWebKitAPI::ensureMenuItemAtIndexOfTypeIsDisabled):
2841         Add many helpers for testing, especially to make asynchronous things synchronous.
2842
2843         (TestWebKitAPI::windowPointForTarget):
2844         (TestWebKitAPI::inset8):
2845         Hard-code points in action-menu-targets.html for hit testing.
2846
2847         (TestWebKitAPI::TEST):
2848         Add a suite of tests for WebKit2 action menus.
2849
2850         * TestWebKitAPI/Tests/WebKit2ObjC/ActionMenusBundle.mm: Added.
2851         (TestWebKitAPI::createActionContextForPhoneNumber):
2852         (TestWebKitAPI::ActionMenuTest::ActionMenuTest):
2853         (TestWebKitAPI::ActionMenuTest::prepareForActionMenu):
2854         (TestWebKitAPI::ActionMenuTest::actionContextForResultAtPoint):
2855         (TestWebKitAPI::ActionMenuTest::drawRect):
2856         (TestWebKitAPI::ActionMenuTest::didCreatePage):
2857         Add a bundle with a PageOverlay and a actionContextForResultAtPoint override,
2858         so that we can test that infrastructure.
2859
2860 2014-12-08  Philippe Normand  <pnormand@igalia.com>
2861
2862         [GTK] UserMedia Permission Request API
2863         https://bugs.webkit.org/show_bug.cgi?id=136449
2864
2865         Reviewed by Carlos Garcia Campos.
2866
2867         The GTK version of the MiniBrowser has gained UserMedia permission
2868         request support.
2869
2870         * MiniBrowser/gtk/BrowserWindow.c: Show a popup when the page
2871         requires user permission to access audio/video devices.
2872         (permissionRequestDialogCallback):
2873         (webViewDecidePermissionRequest):
2874         (geolocationRequestDialogCallback): Deleted.
2875
2876 2014-12-08  Anders Carlsson  <andersca@apple.com>
2877
2878         Add a stubbed out method for clearing out the website data store
2879         https://bugs.webkit.org/show_bug.cgi?id=139404
2880
2881         Reviewed by Antti Koivisto.
2882
2883         Add a debug menu item for testing clearing of website data.
2884
2885         * MiniBrowser/mac/MainMenu.xib:
2886         * MiniBrowser/mac/WK2BrowserWindowController.m:
2887         (-[WK2BrowserWindowController clearWebsiteData:]):
2888
2889 2014-12-07  Gwang Yoon Hwang  <yoon@igalia.com>
2890
2891         Update style checker to deal with "const override"
2892         https://bugs.webkit.org/show_bug.cgi?id=139371
2893
2894         Reviewed by Csaba Osztrogonác.
2895
2896         check-webkit-style shouldn't complain about an open brace to start a
2897         line after a function definition with const override.
2898
2899         * Scripts/webkitpy/style/checkers/cpp.py:
2900         (check_braces):
2901         * Scripts/webkitpy/style/checkers/cpp_unittest.py:
2902         (CppStyleTest.test_brace_at_begin_of_line):
2903
2904 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2905
2906         [GTK] Fix GObject DOM bindings API break tests after r176920
2907         https://bugs.webkit.org/show_bug.cgi?id=139368
2908
2909         Reviewed by Gustavo Noronha Silva.
2910
2911         Remove the @version from the symbol name before comparing.
2912
2913         * gtk/check-for-webkitdom-api-breaks:
2914         (read_expected_api):
2915
2916 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2917
2918         Remove the option to automatically update the GObject DOM bindings symbols file
2919         https://bugs.webkit.org/show_bug.cgi?id=139366
2920
2921         Reviewed by Martin Robinson.
2922
2923         It's currently broken, because symbols now need to be in a
2924         specific order. Now that the symbols file only contains stable
2925         API, it's not a problem to manually update it every time new API
2926         is added.
2927
2928         * gtk/check-for-webkitdom-api-breaks:
2929         (read_expected_api):
2930         (check_api):
2931         (write_expected_api): Deleted.
2932
2933 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2934
2935         [GTK] Use GMainLoopSource in WebKitTestRunner
2936         https://bugs.webkit.org/show_bug.cgi?id=138831
2937
2938         Reviewed by Sergio Villar Senin.
2939
2940         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2941         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
2942         (WTR::TestRunner::platformInitialize):
2943         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
2944         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
2945         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
2946         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
2947         (WTR::TestController::notifyDone):
2948         (WTR::TestController::platformRunUntil):
2949         (WTR::cancelTimeout): Deleted.
2950
2951 2014-12-07  Carlos Garcia Campos  <cgarcia@igalia.com>
2952
2953         [GTK] Missing API detected in GObject DOM bindings after r176630
2954         https://bugs.webkit.org/show_bug.cgi?id=139201
2955
2956         Reviewed by Gustavo Noronha Silva.
2957
2958         Handle deprecated symbols again when generating the GObject DOM
2959         bindings documentation.
2960
2961         * gtk/webkitdom.py:
2962         (WebKitDOMDocGenerator):
2963         (WebKitDOMDocGenerator.is_deprecated_symbol_file):
2964         (WebKitDOMDocGenerator.generate):
2965         (WebKitDOMDocGeneratorSections.__init__):
2966         (WebKitDOMDocGeneratorSections._find_deprecated_symbols):
2967         (WebKitDOMDocGeneratorSections.write_section):
2968
2969 2014-12-07  Csaba Osztrogonác  <ossy@webkit.org>
2970
2971         [EFL][jhbuild] Fix libsoup build with clang
2972         https://bugs.webkit.org/show_bug.cgi?id=139088
2973
2974         Reviewed by Gyuyoung Kim.
2975
2976         * efl/jhbuild.modules:
2977         * efl/patches/soup-clang-warning-fix1.patch: Added.
2978         * efl/patches/soup-clang-warning-fix2.patch: Added.
2979
2980 2014-12-06  Alexey Proskuryakov  <ap@apple.com>
2981
2982         [Mac] DumpRenderTree sets storage directory incorrectly
2983         https://bugs.webkit.org/show_bug.cgi?id=139347
2984
2985         Reviewed by Dan Bernstein.
2986
2987         * DumpRenderTree/mac/DumpRenderTree.mm: (setDefaultsToConsistentValuesForTesting):
2988         Don't use user defaults to pass per-instance paths, as user defaults are shared
2989         across all instances.
2990
2991 2014-12-05  Chris Fleizach  <cfleizach@apple.com>
2992
2993         AX: I cannot activate links on the mobile version of news.google.com
2994         https://bugs.webkit.org/show_bug.cgi?id=139330
2995
2996         Reviewed by Simon Fraser.
2997
2998         Implement press for iOS.
2999
3000         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
3001         (AccessibilityUIElement::press):
3002
3003 2014-12-05  Daniel Bates  <dabates@apple.com>
3004
3005         [iOS] Query -[WAKWindow screenScale] instead of using WKGetScreenScaleFactor()
3006         https://bugs.webkit.org/show_bug.cgi?id=139326
3007
3008         Reviewed by Anders Carlsson.
3009
3010         Ask the window for its screen scale factor instead of calling WKGetScreenScaleFactor()
3011         to query the OS for it. This approach will ensure DumpRenderTree takes the snapshot
3012         using the same scale factor as used in WebKit.
3013
3014         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3015         (createBitmapContextFromWebView):
3016
3017 2014-12-05  Anders Carlsson  <andersca@apple.com>
3018
3019         REGRESSION (r176677): All tests crash on Windows
3020         https://bugs.webkit.org/show_bug.cgi?id=139321
3021
3022         Reviewed by Alexey Proskuryakov.
3023
3024         * DumpRenderTree/win/DumpRenderTree.cpp:
3025         (runTest):
3026         Don't call CFRelease on the url while we have an outstanding pointer to its string,
3027         and use the right number of bytes when allocating the testURL buffer.
3028
3029 2014-12-05  Daniel Bates  <dabates@apple.com>
3030
3031         [iOS] DumpRenderTree produces many reference test mismatches
3032         https://bugs.webkit.org/show_bug.cgi?id=139314
3033
3034         Reviewed by Simon Fraser.
3035
3036         Fixes an issue where the scale factor used to render the snapshot taken by
3037         DumpRenderTree may differ from the device scale factor. In particular, the
3038         scale factor used to render a snapshot of a test may differ from the scale
3039         factor used to render the snapshot of its expected result.
3040
3041         Currently DumpRenderTree uses SPI, -[UIView newSnapshotForRect], on iOS to
3042         snapshot the UIWebBrowserView. This SPI always render using a scale factor
3043         of one when the backing store for the LegacyTileLayer objects were out-of-
3044         date regardless of the device scale factor. Instead we should use UIImage
3045         and CALayer API to perform the snapshot with respect to the device scale
3046         factor.
3047
3048         Additionally write iOS pixel dump support logic in terms of existing
3049         DumpRenderTree abstractions so as to support generating and comparing
3050         pixel dump checksums as well as make the iOS code more consistent with
3051         the logic used by other ports.
3052
3053         * DumpRenderTree/PixelDumpSupport.cpp:
3054         (dumpWebViewAsPixelsAndCompareWithExpected): Removed !PLATFORM(IOS)-guard.
3055         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3056         (BitmapContext::createFromUIImage): Added.
3057         (BitmapContext::pixelData): Added.
3058         (BitmapContext::BitmapContext): Added.
3059         (computeMD5HashStringForBitmapContext): Added.
3060         (dumpBitmap): Added.
3061         (createBitmapContextFromWebView): Moved logic from dumpWebViewAsPixelsAndCompareWithExpected() to here.
3062         (dumpWebViewAsPixelsAndCompareWithExpected): Deleted.
3063
3064 2014-12-05  Anders Carlsson  <andersca@apple.com>
3065
3066         Give all web pages a website data store
3067         https://bugs.webkit.org/show_bug.cgi?id=139317
3068
3069         Reviewed by Tim Horton.
3070
3071         * MiniBrowser/mac/AppDelegate.m:
3072         (-[BrowserAppDelegate newPrivateWindow:]):
3073         Don't release the controller - it's implicitly retained by the window.
3074
3075 2014-12-05  Daniel Bates  <dabates@apple.com>
3076
3077         [iOS] DumpRenderTree fails to render every other test when pixel tests are on
3078         https://bugs.webkit.org/show_bug.cgi?id=137581
3079         <rdar://problem/18642906>
3080
3081         Reviewed by Simon Fraser.
3082
3083         Fixes an issue where the DumpRenderTree snapshot may reflect the rendered content
3084         of the test that proceeded the currently running test.
3085
3086         * DumpRenderTree/ios/PixelDumpSupportIOS.mm:
3087         (dumpWebViewAsPixelsAndCompareWithExpected): Ensure that UIKit has performed a layout
3088         of the UIWebBrowserView view. Also, remove unnecessary call to -[UIWebDocumentView layoutTilesNow]
3089         as -[UIWebDocumentView newSnapshotWithRect] will layout the tiles.
3090
3091 2014-12-05  Jer Noble  <jer.noble@apple.com>
3092
3093         [WTF] MediaTime should support round-tripping from and to doubles.
3094         https://bugs.webkit.org/show_bug.cgi?id=139248
3095
3096         Reviewed by Eric Carlson.
3097
3098         Add API tests for new features of MediaTime. Update the LLDB python provider to correctly display
3099         the MediaTimes after this change.
3100
3101         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
3102         (WTF::operator<<):
3103         (TestWebKitAPI::TEST):
3104         * lldb/lldb_webkit.py:
3105         (WTFMediaTime_SummaryProvider):
3106         (WTFMediaTimeProvider.timeValueAsDouble):
3107         (WTFMediaTimeProvider.isIndefinite):
3108         (WTFMediaTimeProvider):
3109         (WTFMediaTimeProvider.hasDoubleValue):
3110
3111 2014-12-05  Anders Carlsson  <andersca@apple.com>
3112
3113         Add a private browsing mode to MiniBrowser
3114         https://bugs.webkit.org/show_bug.cgi?id=139308
3115
3116         Reviewed by Sam Weinig.
3117
3118         * MiniBrowser/mac/AppDelegate.m:
3119         (defaultConfiguration):
3120         (-[BrowserAppDelegate newWindow:]):
3121         (-[BrowserAppDelegate newPrivateWindow:]):
3122         * MiniBrowser/mac/MainMenu.xib:
3123         * MiniBrowser/mac/WK2BrowserWindowController.h:
3124         * MiniBrowser/mac/WK2BrowserWindowController.m:
3125         (-[WK2BrowserWindowController awakeFromNib]):
3126         (-[WK2BrowserWindowController initWithConfiguration:]):
3127         (-[WK2BrowserWindowController dealloc]):
3128         (-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
3129
3130 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
3131
3132         Run http tests parallel
3133         https://bugs.webkit.org/show_bug.cgi?id=138958
3134
3135         Reviewed by Daniel Bates.
3136
3137         Remove the concept of "locked shard". Now http tests are just like any other tests.
3138         We start HTTP and WebSocket servers at the start if we need them, and terminate them
3139         when done with all the tests (not when the last http test runs, which is unnecessarily
3140         unpredictable).
3141
3142         This makes debug tests run in 8 minutes and 12 seconds on my Mac Pro. Without the
3143         patch, they used to take over 15 minutes.
3144
3145         As part of the fix, we no longer pass the number of servers to Apache. I don't
3146         think that these parameters did what we wanted them to do; Apache handles the load
3147         just fine without them.
3148
3149         The change applies to all platforms. I fixed everything I could find on Mac, and
3150         Ossy told me that he's been running http tests in parallel for a long time. If
3151         there is increased instability for some ports, it will need to be fixed - there is
3152         generally nothing special about http tests at this point, and most code is
3153         cross-platform in WebKit2.
3154
3155         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3156         (LayoutTestRunner.__init__):
3157         (LayoutTestRunner.run_tests):
3158         (LayoutTestRunner.start_servers_with_lock):
3159         (LayoutTestRunner._handle_started_test):
3160         (Worker.handle):
3161         (Sharder.__init__):
3162         (Sharder.shard_tests):
3163         (Sharder._shard_every_file):
3164         (Sharder._shard_by_directory):
3165         (LayoutTestRunner._handle_finished_test_list): Deleted.
3166         (LayoutTestRunner._handle_finished_test_list.find): Deleted.
3167         (Sharder._shard_in_two): Deleted.
3168         (Sharder): Deleted.
3169         (Sharder._resize_shards): Deleted.
3170         (Sharder._resize_shards.divide_and_round_up): Deleted.
3171         (Sharder._resize_shards.extract_and_flatten): Deleted.
3172         (Sharder._resize_shards.split_at): Deleted.
3173         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3174         (FakePrinter.print_workers_and_shards):
3175         (LayoutTestRunnerTests.test_servers_started.start_http_server):
3176         (LayoutTestRunnerTests.test_servers_started):
3177         (SharderTests.get_shards):
3178         (SharderTests.test_shard_by_dir):
3179         (SharderTests.test_shard_every_file):
3180         (SharderTests): Deleted.
3181         (SharderTests.test_shard_in_two): Deleted.
3182         (SharderTests.test_shard_in_two_has_no_locked_shards): Deleted.
3183         (SharderTests.test_shard_in_two_has_no_unlocked_shards): Deleted.
3184         (SharderTests.test_multiple_locked_shards): Deleted.
3185         * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
3186         (ManagerTest.test_needs_servers.get_manager):
3187         (ManagerTest.integration_test_needs_servers.get_manager):
3188         (ManagerTest.test_look_for_new_crash_logs.get_manager):
3189         (ManagerTest):
3190         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
3191         (_set_up_derived_options):
3192         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3193         (RunTest.test_batch_size):
3194         (RunTest.test_max_locked_shards): Deleted.
3195         * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
3196         (LayoutTestApacheHttpd.__init__):
3197         * Scripts/webkitpy/layout_tests/servers/apache_http_server_unittest.py:
3198         (TestLayoutTestApacheHttpd.test_start_cmd):
3199         * Scripts/webkitpy/layout_tests/servers/http_server.py:
3200         (Lighttpd.__init__):
3201         * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
3202         (HttpServerBase.__init__):
3203         * Scripts/webkitpy/layout_tests/views/printing.py:
3204         (Printer.print_workers_and_shards):
3205         * Scripts/webkitpy/port/base.py:
3206         (Port.default_child_processes):
3207         (Port.to.start_http_server):
3208         (Port.default_max_locked_shards): Deleted.
3209         * Scripts/webkitpy/port/port_testcase.py:
3210         (PortTestCase.make_port):
3211         (PortTestCase.test_default_max_locked_shards): Deleted.
3212         * Scripts/webkitpy/port/test.py:
3213         (TestPort.start_http_server):
3214
3215 2014-12-04  Alexey Proskuryakov  <ap@apple.com>
3216
3217         Don't lock perf tests in run-webkit-tests
3218         https://bugs.webkit.org/show_bug.cgi?id=139264
3219
3220         Reviewed by Daniel Bates.
3221
3222         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:
3223         * Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:
3224         * Scripts/webkitpy/layout_tests/controllers/manager.py:
3225         * Scripts/webkitpy/layout_tests/models/test_input.py:
3226         * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
3227
3228 2014-12-03  Alexey Proskuryakov  <ap@apple.com>
3229
3230         http/tests/security/mixedContent/about-blank-iframe-in-main-frame.html fails unless certain other tests run before it
3231         https://bugs.webkit.org/show_bug.cgi?id=139243
3232
3233         Reviewed by Anders Carlsson.
3234
3235         We didn't get WKPageLoaderClient calls in secondary windows, so we didn't have a
3236         chance to allow untrusted certificates.
3237
3238         * WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage):
3239         Set up more client objects for secondary windows. We may be able to share some of the
3240         code with main view creation function, but it's not exactly the same (notably, we
3241         do not focus a secondary window when it's done loading).
3242
3243 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
3244
3245         AX: [ATK] Inline text elements with accessible object attributes and/or event handlers are not exposed
3246         https://bugs.webkit.org/show_bug.cgi?id=139071
3247
3248         Reviewed by Chris Fleizach.
3249
3250         Add string value for ATK_ROLE_STATIC in roleToString.
3251
3252         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3253
3254 2014-12-03  Renato Nagy  <rnagy@inf.u-szeged.hu>
3255
3256         check-webkit-style is confused by ternary expression inside first member initializer
3257         https://bugs.webkit.org/show_bug.cgi?id=136442
3258
3259         Reviewed by Csaba Osztrogonác.
3260
3261         * Scripts/webkitpy/style/checkers/cpp.py:
3262         (check_member_initialization_list):
3263
3264 2014-12-03  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3265
3266         [GTK] [JHBuild] gst-plugins-bad fails to build if the GNUStep libraries are installed.
3267         https://bugs.webkit.org/show_bug.cgi?id=139220
3268
3269         Reviewed by Philippe Normand.
3270
3271         * gtk/jhbuild.modules:
3272         * gtk/patches/gst-plugins-bad-remove-gnustep-support.patch: Added.
3273
3274 2014-12-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
3275
3276         Remove unused JSC runtime options
3277         https://bugs.webkit.org/show_bug.cgi?id=133070
3278
3279         Reviewed by Csaba Osztrogonác.
3280
3281         * Scripts/run-jsc-stress-tests:
3282
3283 2014-12-03  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3284
3285         [EFL] Add subtle crypto to the build system
3286         https://bugs.webkit.org/show_bug.cgi?id=138612
3287
3288         Reviewed by Csaba Osztrogonác.
3289
3290         * Scripts/webkitperl/FeatureList.pm:
3291
3292 2014-12-02  Joanmarie Diggs  <jdiggs@igalia.com>
3293
3294         AX: [ATK] Table captions and table rows are missing from the accessible hierarchy
3295         https://bugs.webkit.org/show_bug.cgi?id=139005
3296
3297         Reviewed by Chris Fleizach.
3298
3299         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
3300         Add mapping for ATK_ROLE_CAPTION to roleToString
3301
3302 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
3303
3304         http/tests/appcache/main-resource-fallback-for-network-error-crash.html can break subsequent tests
3305         https://bugs.webkit.org/show_bug.cgi?id=139149
3306
3307         Reviewed by Anders Carlsson.
3308
3309         WebKit2 already cleared application caches between runs (although it wasn't entirely
3310         effective without WebCore changes in this patch).
3311
3312         * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Clear applicaiton caches between runs.
3313
3314         * DumpRenderTree/win/DumpRenderTree.cpp: (runTest): Ditto (unfortunately, this
3315         function is not implemented on Windows, see below).
3316
3317         * DumpRenderTree/win/TestRunnerWin.cpp: (TestRunner::clearAllApplicationCaches):
3318         Ameded a FIXME.
3319
3320 2014-12-02  Gavin Barraclough  <barraclough@apple.com>
3321
3322         Generalize PageActivityAssertionToken
3323         https://bugs.webkit.org/show_bug.cgi?id=139106
3324
3325         Reviewed by Sam Weinig.
3326
3327         Add an API test for WTF::RefCounter.
3328
3329         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3330         * TestWebKitAPI/Tests/WTF/RefCounter.cpp: Added.
3331         (TestWebKitAPI::TEST):
3332             - added RefCounter test.
3333
3334 2014-12-02  Alexey Proskuryakov  <ap@apple.com>
3335
3336         [Mac, iOS] Crash log application information contains latest main frame URL instead of test URL
3337         https://bugs.webkit.org/show_bug.cgi?id=139174
3338
3339         Reviewed by Simon Fraser.
3340
3341         * DumpRenderTree/TestRunner.cpp:
3342         * DumpRenderTree/TestRunner.h:
3343         Renamed testPathOrURL to testURL, because this variable always contains a URL.
3344
3345         * DumpRenderTree/mac/DumpRenderTree.mm:
3346         (sizeWebViewForCurrentTest): Updated for testPathOrURL renaming.
3347         (testPathFromURL): Moved from FrameLoadDelegate.mm.
3348         (runTest): Set crash reporter information here, as we know the exact test URL.
3349
3350         * DumpRenderTree/mac/FrameLoadDelegate.mm:
3351         (-[FrameLoadDelegate webView:didStartProvisionalLoadForFrame:]): Don't set crash
3352         reporter information here.
3353
3354         * DumpRenderTree/mac/ResourceLoadDelegate.mm:
3355         * DumpRenderTree/mac/TestRunnerMac.mm:
3356         Updated for testPathOrURL renaming.
3357
3358         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3359         (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): WebProcess doesn't know
3360         test URL until load starts, so save it into TestRunner now. A new TestRunner object
3361         is created for each test.
3362
3363         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3364         (WTR::TestRunner::testURL):
3365         (WTR::TestRunner::setTestURL):
3366         Make TestRunner know the test name. For now, it's good enough to have it once load
3367         starts, but if we ever need it earlier, we can send it with BeginTest message.
3368
3369         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3370         (WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):
3371         Use test URL, not currently loading URL for CrashReporter.
3372
3373         * WebKitTestRunner/cocoa/CrashReporterInfo.mm:
3374         (WTR::setCrashReportApplicationSpecificInformationToURL): Added a space after colon
3375         (WebKit1 already had it right).
3376
3377         * DumpRenderTree/win/DumpRenderTree.cpp:
3378         (sizeWebViewForCurrentTest):
3379         (runTest):
3380         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
3381         (ResourceLoadDelegate::willSendRequest):
3382         Changed Windows DumpRenderTree to also use URL in TestRunner.
3383
3384 2014-12-02  Daniel Bates  <dabates@apple.com>
3385
3386         [iOS] run-webkit-tests records most DumpRenderTree.app crashes as time-outs
3387         https://bugs.webkit.org/show_bug.cgi?id=139143
3388
3389         Reviewed by David Kilzer.
3390
3391         Similar to the Windows-specific fix in <https://bugs.webkit.org/show_bug.cgi?id=37859>,
3392         teach DumpRenderTree for iOS to write "#CRASHED" to the standard error stream when it
3393         crashes. Run-webkit-tests will record as crashing the test associated with the
3394         DumpRenderTree instance that wrote that string.
3395
3396         Currently almost all of the DumpRenderTree.app crashes are recorded by run-
3397         webkit-tests as a time-out because ReportCrash(8) delays delivery of the
3398         process exit notification for DumpRenderTree.app to LayoutTestRelay, which
3399         launched DumpRenderTree.app, past the time-out time limit. Notice LayoutTestRelay
3400         was launched by run-webkit-tests. So, run-webkit-tests kills LayoutTestRelay
3401         (since it exceeded the time-out time limit) before it can inform rub-webkit-tests
3402         about a crash.
3403
3404         Additionally, update the crash message format written to standard error when LayoutTestRelay
3405         detects that {WebKitTestRunner, DumpRenderTree}.app crashed so as to be similar to the
3406         crash message format used by WebKitTestRunner when it detects that the WebProcess crashed.
3407         Then run-webkit-tests will collect the crash logs for {WebKitTestRunner, DumpRenderTree}.app
3408         when they crash in their test machinery logic/UI process code.
3409
3410         * DumpRenderTree/mac/DumpRenderTree.mm:
3411         (writeCrashedMessageOnFatalError): Added.
3412         (dumpRenderTree): Register signal handler, writeCrashedMessageOnFatalError(), for signals:
3413         SIGILL, SIGFPE, SIGBUS and SIGSEGV.
3414         * LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
3415         (-[LTRelayController didCrashWithMessage:]): Emit a crash message with a format
3416         similar to the format used by WebKitTestRunner so that run-webkit-tests will collect
3417         the crash logs for WebKitTestRunner/DumpRenderTree.app.
3418         * Scripts/webkitpy/port/driver.py:
3419         (Driver.__init__): Update comment.
3420         (Driver._check_for_driver_crash): Ditto.
3421         * Scripts/webkitpy/port/ios.py:
3422         (IOSSimulatorPort): Add class constant SUBPROCESS_CRASH_REGEX, which represents a compiled
3423         regular expression. This constant is used as an optimization to avoid compiling the same
3424         regular expression across invocations of _get_crash_log().
3425         (IOSSimulatorPort._get_crash_log): Modified to parse the WebKitTestRunner-like crash message
3426         for the subprocess name and pid. Also, moved variables crash_log, crash_logs, and now to be
3427         closer to where they are used.
3428
3429 2014-12-01  Anders Carlsson  <andersca@apple.com>
3430
3431         Remove WKBundleRemoveAllVisitedLinks
3432         https://bugs.webkit.org/show_bug.cgi?id=139163
3433
3434         Reviewed by Sam Weinig.
3435
3436         Remove the call to WKBundleRemoveAllVisitedLinks and add a FIXME instead.
3437
3438         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3439         (WTR::InjectedBundle::beginTesting):
3440         * WebKitTestRunner/TestInvocation.cpp:
3441         (WTR::TestInvocation::invoke):
3442
3443 2014-12-02  Anders Carlsson  <andersca@apple.com>
3444
3445         Fix Windows build.
3446
3447         * DumpRenderTree/win/DumpRenderTree.cpp:
3448         (setAlwaysAcceptCookies):
3449
3450 2014-12-02  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
3451
3452         [EFL] Remove edbus dependency from jhbuild
3453         https://bugs.webkit.org/show_bug.cgi?id=139130
3454
3455         Reviewed by Gyuyoung Kim.
3456
3457         After http://trac.webkit.org/changeset/176555 we
3458         don't need it anymore.
3459
3460         * efl/jhbuild.modules:
3461
3462 2014-12-02  Philippe Normand  <pnormand@igalia.com>
3463
3464         [jhbuild] wrong Dependencies path
3465         https://bugs.webkit.org/show_bug.cgi?id=139176
3466
3467         Reviewed by Martin Robinson.
3468
3469         * Scripts/webkitpy/port/base.py:
3470         (Port._should_use_jhbuild):
3471
3472 2014-12-02  Philippe Normand  <pnormand@igalia.com>
3473
3474         [GStreamer] Bump internal jhbuild versions to 1.4.4
3475         https://bugs.webkit.org/show_bug.cgi?id=138866
3476
3477         Reviewed by Carlos Garcia Campos.
3478
3479         * gtk/jhbuild.modules:
3480         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
3481         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
3482         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3483
3484 2014-12-01  Commit Queue  <commit-queue@webkit.org>
3485
3486         Unreviewed, rolling out r176566.
3487         https://bugs.webkit.org/show_bug.cgi?id=139124
3488
3489         It broke the GTK performance tests. (Requested by clopez on
3490         #webkit).
3491
3492         Reverted changeset:
3493
3494         "[GTK] Use GMainLoopSource in WebKitTestRunner"
3495         https://bugs.webkit.org/show_bug.cgi?id=138831
3496         http://trac.webkit.org/changeset/176566
3497
3498 2014-11-29  Anders Carlsson  <andersca@apple.com>
3499
3500         Crash when calling WKPageClose on the originated page from within createNewPage callback
3501         https://bugs.webkit.org/show_bug.cgi?id=139099
3502         <rdar://problem/19052564>
3503
3504         Reviewed by Sam Weinig.
3505
3506         Add a test.
3507
3508         * TestWebKitAPI/PlatformWebView.h:
3509         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3510         * TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.
3511         (TestWebKitAPI::runJavaScriptAlert):
3512         (TestWebKitAPI::createNewPage):
3513         (TestWebKitAPI::TEST):
3514         * TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
3515         * TestWebKitAPI/mac/PlatformWebViewMac.mm:
3516         (TestWebKitAPI::PlatformWebView::PlatformWebView):
3517
3518 2014-11-28  Commit Queue  <commit-queue@webkit.org>
3519
3520         Unreviewed, rolling out r176564.
3521         https://bugs.webkit.org/show_bug.cgi?id=139093
3522
3523         massive failures on release test bot (Requested by philn on
3524         #webkit).
3525
3526         Reverted changeset:
3527
3528         "[GStreamer] Bump internal jhbuild versions to 1.4.4"
3529         https://bugs.webkit.org/show_bug.cgi?id=138866
3530         http://trac.webkit.org/changeset/176564
3531
3532 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3533
3534         [GTK] Use GMainLoopSource in WebKitTestRunner
3535         https://bugs.webkit.org/show_bug.cgi?id=138831
3536
3537         Reviewed by Sergio Villar Senin.
3538
3539         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3540         * WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
3541         (WTR::TestRunner::platformInitialize):
3542         (WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
3543         (WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
3544         (WTR::waitToDumpWatchdogTimerCallback): Deleted.
3545         * WebKitTestRunner/gtk/TestControllerGtk.cpp:
3546         (WTR::TestController::notifyDone):
3547         (WTR::TestController::platformRunUntil):
3548         (WTR::cancelTimeout): Deleted.
3549
3550 2014-11-24  Philippe Normand  <pnormand@igalia.com>
3551
3552         [GStreamer] Bump internal jhbuild versions to 1.4.4
3553         https://bugs.webkit.org/show_bug.cgi?id=138866
3554
3555         Reviewed by Carlos Garcia Campos.
3556
3557         * gtk/jhbuild.modules:
3558         * gtk/patches/gst-events-arent-gstobjects.patch: Removed.
3559         * gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
3560         * gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
3561
3562 2014-11-28  Carlos Garcia Campos  <cgarcia@igalia.com>
3563
3564         [GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
3565         https://bugs.webkit.org/show_bug.cgi?id=138834
3566
3567         Reviewed by Sergio Villar Senin.
3568
3569         It makes everyting simpler and the tests run faster too, since we
3570         don't need to spawn the private bus and wait until the DBus name
3571         is registered. The web extension registers a new JavaSCript class
3572         with a status method to run the tests, similar to the DBus
3573         method. In the UI process side, tests use webkit_web_view_run_java_script()
3574         instead of sending a DBus message.
3575
3576         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
3577         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
3578         (WebKitDOMNodeFilterTest::create):
3579         (WebKitDOMNodeFilterTest::testTreeWalker):
3580         (WebKitDOMNodeFilterTest::testNodeIterator):
3581         (WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
3582         (WebKitDOMNodeFilterTest::runTest): Deleted.
3583         * TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
3584         (WebKitDOMNodeTest::create):
3585         (WebKitDOMNodeTest::testHierarchyNavigation):
3586         (WebKitDOMNodeTest::testInsertion):
3587         (WebKitDOMNodeTest::testTagNames):
3588         (WebKitDOMNodeTest::webPageFromArgs): Deleted.
3589         (WebKitDOMNodeTest::runTest): Deleted.
3590         * TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
3591         (WebKitDOMXPathNSResolverTest::create):
3592         (WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
3593         (WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
3594         (WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
3595         (WebKitDOMXPathNSResolverTest::runTest): Deleted.
3596         * TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:
3597         (WebKitFrameTest::create):
3598         (WebKitFrameTest::testMainFrame):
3599         (WebKitFrameTest::testURI):
3600         (WebKitFrameTest::testJavaScriptContext):
3601         (WebKitFrameTest::webPageFromArgs): Deleted.
3602         (WebKitFrameTest::runTest): Deleted.
3603         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:
3604         (testWebKitDOMNodeHierarchyNavigation):
3605         (testWebKitDOMNodeInsertion):
3606         (testWebKitDOMNodeTagNames):
3607         (beforeAll):
3608         (afterAll):
3609         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:
3610         (runTest):
3611         (beforeAll):
3612         (afterAll):
3613         * TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:
3614         (testWebKitDOMXPathNSResolverNative):
3615         (testWebKitDOMXPathNSResolverCustom):
3616         (beforeAll):
3617         (afterAll):
3618         (runTest): Deleted.
3619         * TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:
3620         (webkitFrameTestRun):
3621         (beforeAll):
3622         (afterAll):
3623         * TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
3624    &nbs