[Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of...
[WebKit-https.git] / Tools / ChangeLog
1 2017-02-07  Myles C. Maxfield  <mmaxfield@apple.com>
2
3         [Win] [GTK] [EFL] Compile (but don't use, yet) the platform-independent piece of ComplexTextController
4         https://bugs.webkit.org/show_bug.cgi?id=167927
5
6         Reviewed by Brent Fulgham.
7
8         Enable ComplexTextController API tests on the Win and GTK ports.
9
10         * TestWebKitAPI/PlatformGTK.cmake:
11         * TestWebKitAPI/PlatformWin.cmake:
12
13 2017-02-07  Jonathan Bedard  <jbedard@apple.com>
14
15         File index appended to previous file in svn-create-patch with SVN 1.9
16         https://bugs.webkit.org/show_bug.cgi?id=167903
17         <rdar://problem/30387395>
18
19         Reviewed by Daniel Bates.
20
21         * Scripts/VCSUtils.pm:
22         (fixSVNPatchForAdditionWithHistory): Append a trailing newline character.
23         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Do not remove
24         trailing newline character from the expected result before comparing it to the actual result.
25
26 2017-02-07  Olivier Blin  <olivier.blin@softathome.com>
27
28         [webkitdirs] remove unused host_processor variable in determineArchitecture()
29         https://bugs.webkit.org/show_bug.cgi?id=167936
30
31         Reviewed by Michael Catanzaro.
32
33         * Scripts/webkitdirs.pm:
34         (determineArchitecture):
35         The host_processor variable in webkitdirs.pm's determineArchitecture() is not used anymore,
36         since r195083.
37
38 2017-02-07  Youenn Fablet  <youenn@apple.com>
39
40         Use a JSON file to define which WPT files/folders to import
41         https://bugs.webkit.org/show_bug.cgi?id=167923
42
43         Reviewed by Alex Christensen.
44
45         * Scripts/webkitpy/w3c/test_downloader.py:
46         (TestDownloader.__init__):
47         (TestDownloader._init_paths_from_expectations):
48         * Scripts/webkitpy/w3c/test_importer.py:
49         (parse_args):
50         * Scripts/webkitpy/w3c/test_importer_unittest.py:
51
52 2017-02-06  Fujii Hironori  <Hironori.Fujii@sony.com>
53
54         [GTK] jhbuild fails: mesa-11.0.6.tar.xz: 404 Not Found
55         https://bugs.webkit.org/show_bug.cgi?id=167916
56
57         Reviewed by Carlos Garcia Campos.
58
59         URL of mesa-11.0.6.tar.xz has been moved.
60
61         * gtk/jhbuild.modules: Fix the module path.
62
63 2017-02-06  Joseph Pecoraro  <pecoraro@apple.com>
64
65         Static Analyzer: Address some leaks in MiniBrowser
66         https://bugs.webkit.org/show_bug.cgi?id=167897
67
68         Reviewed by Alexey Proskuryakov.
69
70         * MiniBrowser/mac/BrowserWindowController.m:
71         (-[BrowserWindowController sharingService:transitionImageForShareItem:contentRect:]):
72         * MiniBrowser/mac/ExtensionManagerWindowController.m:
73         (-[ExtensionManagerWindowController add:]):
74         (-[ExtensionManagerWindowController remove:]):
75         * MiniBrowser/mac/SettingsController.m:
76         (-[SettingsController _populateMenu]):
77         (-[SettingsController togglePerWindowWebProcessesDisabled:]):
78         Address obvious leaks caught by the static analyzer.
79
80 2017-02-06  Myles C. Maxfield  <mmaxfield@apple.com>
81
82         Migrate ComplexTextController to use platform-independent types
83         https://bugs.webkit.org/show_bug.cgi?id=167833
84
85         Reviewed by Brent Fulgham.
86
87         Migrate tests away from platform-dependent types.
88
89         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
90         (TestWebKitAPI::TEST_F):
91
92 2017-02-06  Brent Fulgham  <bfulgham@apple.com>
93
94         Correct File Path Handling in SecurityOrigin and FileSystem
95         https://bugs.webkit.org/show_bug.cgi?id=167894
96         <rdar://problem/30380080>
97
98         Reviewed by Alexey Proskuryakov.
99
100         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp: Don't encode the temporary files,
101         and perform same-volume checks using filesystem-compatible paths.        
102         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Create SecurityOrigins from
103         filesystem paths, and perform validation of same-volume checks.
104         (TestWebKitAPI::SecurityOriginTest::tempFilePath): Added.
105         (TestWebKitAPI::SecurityOriginTest::spaceContainingFilePath): Added.
106         (TestWebKitAPI::SecurityOriginTest::bangContainingFilePath): Added.
107         (TestWebKitAPI::SecurityOriginTest::quoteContainingFilePath): Added.
108
109 2017-02-06  Jer Noble  <jer.noble@apple.com>
110
111         Playback stalls when a SourceBuffer append causes frame eviction
112         https://bugs.webkit.org/show_bug.cgi?id=167834
113
114         Reviewed by Eric Carlson.
115
116         Add new correctness tests for the Webcore::SampleMap class. Add additional subtests
117         for the WTF::MediaTime class.
118
119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
120         * TestWebKitAPI/Tests/WTF/MediaTime.cpp:
121         (TestWebKitAPI::TEST):
122         * TestWebKitAPI/Tests/WebCore/SampleMap.cpp: Added.
123         (WTF::operator<<):
124         (TestWebKitAPI::TestSample::create):
125         (TestWebKitAPI::TestSample::TestSample):
126         (TestWebKitAPI::TEST_F):
127
128 2017-02-06  Ryan Haddad  <ryanhaddad@apple.com>
129
130         Change capitalization in platform name after r211735.
131
132         Unreviewed dashboard fix.
133
134         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
135         (WebKitBuildbot):
136
137 2017-02-06  Alexey Proskuryakov  <ap@apple.com>
138
139         Move the Leaks bot to Sierra
140         https://bugs.webkit.org/show_bug.cgi?id=167886
141
142         Reviewed by Daniel Bates.
143
144         * BuildSlaveSupport/build.webkit.org-config/config.json:
145         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
146         * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
147         (LeaksViewer._displayURLPrompt):
148         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
149         (WebKitBuildbot):
150
151 2017-02-06  Jonathan Bedard  <jbedard@apple.com>
152
153         Prevent app crash on launch during simctl install workaround
154         https://bugs.webkit.org/show_bug.cgi?id=167685
155
156         Reviewed by Daniel Bates.
157
158         * Scripts/webkitpy/port/simulator_process.py:
159         (SimulatorProcess.__init__): Pass environment to install.
160         * Scripts/webkitpy/xcode/simulator.py:
161         (Device.install_app): Accept environment, pass environment to launch.
162
163 2017-02-06  Alex Christensen  <achristensen@webkit.org>
164
165         Rebase API tests after r211638
166         https://bugs.webkit.org/show_bug.cgi?id=167779
167
168         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
169         (TestWebKitAPI::TEST_F):
170         URLs with non-special schemes and characters like % in the host now fail to parse,
171         more like their special counterparts and according to spec.
172
173 2017-02-06  Csaba Osztrogonác  <ossy@webkit.org>
174
175         Unreviewed trivial fix after r211697.
176         https://bugs.webkit.org/show_bug.cgi?id=167863
177
178         * Scripts/run-javascriptcore-tests:
179         (runJSCStressTests): Renamed ES6SampleBench to ARES-6.
180
181 2017-02-04  Simon Fraser  <simon.fraser@apple.com>
182
183         Clean up how GraphicsLayer's "inWindow" state is set, and fix some issues with Page Overlays
184         https://bugs.webkit.org/show_bug.cgi?id=167850
185
186         Reviewed by Tim Horton.
187
188         * DumpRenderTree/TestRunner.cpp:
189         (TestRunner::uiScriptDidComplete): Fix an assertion that fires for non-16-bit strings.
190
191 2017-02-04  Andreas Kling  <akling@apple.com>
192
193         Plug some leaks in TestController and UIScriptContext.
194         <https://webkit.org/b/167839>
195
196         Reviewed by Alexey Proskuryakov.
197
198         Fix a couple of the leaks seen on the leaks bot.
199
200         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
201         (UIScriptContext::runUIScript):
202         * WebKitTestRunner/TestController.cpp:
203         (WTR::TestController::handleCheckOfUserMediaPermissionForOrigin):
204         (WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible):
205
206 2017-02-03  Jeremy Jones  <jeremyj@apple.com>
207
208         WK1 mouse events are missing movementX and movementY for pointerlock.
209         https://bugs.webkit.org/show_bug.cgi?id=167775
210         rdar://problem/30343810
211
212         Reviewed by Alexey Proskuryakov.
213
214         Set kCGMouseEventDeltaX and kCGMouseEventDeltaY when synthesizing mouse move events.
215
216         * DumpRenderTree/mac/EventSendingController.mm:
217         (-[EventSendingController mouseMoveToX:Y:]):
218         * WebKitTestRunner/mac/EventSenderProxy.mm:
219         (WTR::EventSenderProxy::mouseMoveTo):
220
221 2017-02-03  Simon Fraser  <simon.fraser@apple.com>
222
223         Correctly set the "inWindow" flag for TileControllers that aren't the page tiles, and clarify "usingTiledBacking" logic
224         https://bugs.webkit.org/show_bug.cgi?id=167774
225
226         Reviewed by Tim Horton.
227
228         Implement UIScriptController removeViewFromWindow() and addViewToWindow(), and hook
229         up for Mac WK1 and WK2, and iOS WK2. It takes a callback because view state updates to the
230         web process are async, so the callback fires after the web process gets the new state.
231
232         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
233         (WTR::UIScriptController::removeViewFromWindow):
234         (WTR::UIScriptController::addViewToWindow):
235         * DumpRenderTree/mac/DumpRenderTree.mm:
236         (createWebViewAndOffscreenWindow):
237         (resetWebViewToConsistentStateBeforeTesting):
238         * DumpRenderTree/mac/DumpRenderTreeMac.h:
239         * DumpRenderTree/mac/UIScriptControllerMac.mm:
240         (WTR::UIScriptController::removeViewFromWindow):
241         (WTR::UIScriptController::addViewToWindow):
242         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
243         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
244         (WTR::UIScriptController::removeViewFromWindow):
245         (WTR::UIScriptController::addViewToWindow):
246         * TestRunnerShared/UIScriptContext/UIScriptController.h:
247         * WebKitTestRunner/PlatformWebView.h:
248         * WebKitTestRunner/TestController.cpp:
249         (WTR::TestController::resetStateToConsistentValues):
250         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
251         (WTR::PlatformWebView::removeFromWindow):
252         (WTR::PlatformWebView::addToWindow):
253         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
254         (WTR::UIScriptController::removeViewFromWindow):
255         (WTR::UIScriptController::addViewToWindow):
256         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
257         (WTR::PlatformWebView::removeFromWindow):
258         (WTR::PlatformWebView::addToWindow):
259         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
260         (WTR::UIScriptController::removeViewFromWindow):
261         (WTR::UIScriptController::addViewToWindow):
262
263 2017-02-03  Alexey Proskuryakov  <ap@apple.com>
264
265         Remove check for SkipSafariExecutableEntitlementChecks
266         https://bugs.webkit.org/show_bug.cgi?id=167762
267
268         Reviewed by Dan Bernstein.
269
270         Follow-up fix: don't break internal behavior.
271
272         * Scripts/webkitdirs.pm:
273         (safariPath):
274         (executableHasEntitlements): Deleted.
275         (safariPathFromSafariBundle): Deleted.
276         (installedSafariPath): Deleted.
277
278 2017-02-03  Daniel Bates  <dabates@apple.com>
279
280         [Mac][WK2] Add SPI to override the Content Security Policy of a page
281         https://bugs.webkit.org/show_bug.cgi?id=167810
282         <rdar://problem/30102568>
283
284         Reviewed by Anders Carlsson.
285
286         Add tests to ensure that we do not regress -[WKWebView _setOverrideContentSecurityPolicy:].
287
288         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
289         * TestWebKitAPI/Tests/WebKit2Cocoa/OverrideContentSecurityPolicy.mm: Added.
290         (TEST):
291         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp-iframe.html: Added.
292         * TestWebKitAPI/Tests/WebKit2Cocoa/page-with-csp.html: Added.
293         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp-iframe.html: Added.
294         * TestWebKitAPI/Tests/WebKit2Cocoa/page-without-csp.html: Added.
295
296 2017-02-02  Alex Christensen  <achristensen@webkit.org>
297
298         URLParser: Fix parsing invalid IPv4 addresses with non-ASCII characters
299         https://bugs.webkit.org/show_bug.cgi?id=167773
300         <rdar://problem/30221102>
301
302         Reviewed by Ryosuke Niwa.
303
304         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
305         (TestWebKitAPI::TEST_F):
306
307 2017-02-02  Alexey Proskuryakov  <ap@apple.com>
308
309         Remove check for SkipSafariExecutableEntitlementChecks
310         https://bugs.webkit.org/show_bug.cgi?id=167762
311         rdar://problem/22480673
312
313         Reviewed by Dan Bernstein.
314
315         * Scripts/webkitdirs.pm:
316         (safariPathFromSafariBundle):
317         (skipSafariExecutableEntitlementChecks): Deleted.
318
319 2017-02-02  Jonathan Bedard  <jbedard@apple.com>
320
321         Undefined subroutine in svn-create-patch
322         https://bugs.webkit.org/show_bug.cgi?id=167742
323
324         Unreviewed build-fix after r211543.
325
326         * Scripts/VCSUtils.pm: fixSVNPatchForAdditionWithHistory was not exported.
327
328 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
329
330         Unreviewed. Fix jhbuild dependencies build.
331
332         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch:
333         Patch updated.
334
335 2017-02-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
336
337         [EME][GStreamer] Fixed decryptor selection
338         https://bugs.webkit.org/show_bug.cgi?id=167588
339
340         Reviewed by Žan Doberšek.
341
342         This patches are pending at https://bugzilla.gnome.org/show_bug.cgi?id=770107
343
344         * gtk/jhbuild.modules: Added patches to gstreamer and
345         gst-plugins-good packages.
346         * gtk/patches/gst-plugins-good-0004-qtdemux-add-context-for-a-preferred-protection.patch: Added.
347         * gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Added.
348
349 2017-02-01  Dewei Zhu  <dewei_zhu@apple.com>
350
351         Make run-benchmark script supports 'config' key in test plan.
352         https://bugs.webkit.org/show_bug.cgi?id=167715
353
354         Reviewed by Ryosuke Niwa.
355
356         Add support for 'config' key in test paln.
357         'config' key is a dictionary that specifies environment configurations while test is running.
358         Specifies orientation to be portrait in MotionMark benchmark.
359
360         * Scripts/webkitpy/benchmark_runner/README.md:
361         * Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
362         (BenchmarkRunner.__init__):
363         (BenchmarkRunner._run_benchmark):
364         * Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
365         (BrowserDriver.prepare_env):
366         * Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
367         (LinuxBrowserDriver.prepare_env):
368         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
369         (OSXBrowserDriver.prepare_env):
370         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
371         (OSXSafariDriver.prepare_env):
372         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
373
374 2017-02-01  Daniel Bates  <dabates@apple.com>
375
376         REGRESSION (r210820): svn-create-patch does not emit property change only diff
377         https://bugs.webkit.org/show_bug.cgi?id=167169
378
379         Reviewed by David Kilzer.
380
381         More directly handle the SVN 1.9 or newer syntax change for a diff of a copied or moved file
382         - a SVN diff header and an empty body. In particular, remove a duplicate leading SVN diff
383         header from the output of "svn diff" on a file that was copied or moved.
384
385         Following r210820 svn-create-patch emits to standard output a diff only if it has at least one
386         chunk range line (e.g. @@ -0,0 +1,7 @@) as a means to workaround a syntax change in the diff
387         output of a copied or moved file in SVN version 1.9 or newer. In SVN 1.9 or newer "svn diff"
388         of a copied or moved file always emits to standard output a leading SVN diff header (an "Index:"
389         line followed by a separator line) with an empty body; => no chunk range lines. However a diff
390         of a file with only a property change also does not contain any chunk range lines. Therefore
391         svn-create-patch no longer emitted to standard output such a diff. Instead of indirectly detecting
392         a SVN diff header with an empty body by counting the number of chunk range lines in the diff
393         we should directly test for the presence of a leading SVN diff header with an empty body and
394         remove such lines from the diff.
395
396         * Scripts/VCSUtils.pm:
397         (fixSVNPatchForAdditionWithHistory): Added.
398         * Scripts/svn-create-patch:
399         (generateDiff): Pass the output from "svn diff" to fixSVNPatchForAdditionWithHistory() when
400         we have a non empty patch for an added file with history (i.e. a copied or moved file).
401         * Scripts/webkitperl/VCSUtils_unittest/fixSVNPatchForAdditionWithHistory.pl: Added.
402
403 2017-02-01  Eric Carlson  <eric.carlson@apple.com>
404
405         [Mac] Update CARingBuffer class
406         https://bugs.webkit.org/show_bug.cgi?id=167656
407
408         Reviewed by Jer Noble.
409
410         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
411         * TestWebKitAPI/Tests/WebCore/CARingBuffer.cpp: Added.
412         (TestWebKitAPI::CARingBufferTest::SetUp):
413         (TestWebKitAPI::CARingBufferTest::setup):
414         (TestWebKitAPI::CARingBufferTest::setListDataBuffer):
415         (TestWebKitAPI::CARingBufferTest::description):
416         (TestWebKitAPI::CARingBufferTest::bufferList):
417         (TestWebKitAPI::CARingBufferTest::ringBuffer):
418         (TestWebKitAPI::CARingBufferTest::capacity):
419         (TestWebKitAPI::CARingBufferTest::audioBufferListSizeForStream):
420         (TestWebKitAPI::CARingBufferTest::configureBufferListForStream):
421         (TestWebKitAPI::TEST_F):
422         (TestWebKitAPI::MixingTest::run):
423
424 2017-02-01  Alexey Proskuryakov  <ap@apple.com>
425
426         [Mac] TestWebKitAPI includes system frameworks incorrectly
427         https://bugs.webkit.org/show_bug.cgi?id=167703
428         rdar://problem/30301498
429
430         Reviewed by Ryosuke Niwa.
431
432         FRAMEWORK_SEARCH_PATH results in frameworks being treated as user ones, not system.
433         Make TestWebKitAPI use -iframework instead, like the rest of WebKit does.
434
435         Also, reduced the number of subframework search paths, looks like we only need one now.
436
437         * TestWebKitAPI/Configurations/Base.xcconfig:
438
439 2017-02-01  Brent Fulgham  <bfulgham@apple.com>
440
441         Correct "filesHaveSameVolume" predicate
442         https://bugs.webkit.org/show_bug.cgi?id=167696
443         <rdar://problem/30298722>
444
445         Reviewed by David Kilzer.
446
447         Add new tests that confirm that the 'filesHaveSamePath' predicate properly handles
448         percent-escaped path inputs.
449
450         * TestWebKitAPI/Tests/WebCore/FileSystem.cpp:
451         (TestWebKitAPI::FileSystemTest::spaceContainingFilePath):
452         (TestWebKitAPI::FileSystemTest::bangContainingFilePath):
453         (TestWebKitAPI::FileSystemTest::quoteContainingFilePath):
454         (TestWebKitAPI::TEST_F):
455
456 2017-02-01  Tomas Popela  <tpopela@redhat.com>
457
458         Unreviewed. Fix coding style in MiniBrowser
459
460         * MiniBrowser/gtk/BrowserWindow.c:
461         (editingCommandCallback):
462         (insertImageCommandCallback):
463         (insertLinkCommandCallback):
464
465 2017-02-01  Tomas Popela  <tpopela@redhat.com>
466
467         [GTK] Add an API to add a custom tab into the print dialog
468         https://bugs.webkit.org/show_bug.cgi?id=151998
469
470         Reviewed by Carlos Garcia Campos.
471
472         Add a new WebKitPrintOperation/custom-widget test in TestPrinting
473         that is testing a newly added API.
474
475         * TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
476         (testPrintCustomWidget):
477         (beforeAll):
478
479 2017-02-01  Enrique Ocaña González  <eocanha@igalia.com>
480
481         [GStreamer][MSE] qtdemux: Update the tfdt patch to the version finally accepted upstream
482         https://bugs.webkit.org/show_bug.cgi?id=166529
483
484         Reviewed by Xabier Rodriguez-Calvar.
485
486         * gtk/patches/gst-plugins-good-use-the-tfdt-decode-time.patch:
487         New patch version accepted in GStreamer upstream.
488
489 2017-02-01  Xabier Rodriguez Calvar  <calvaris@igalia.com>
490
491         [GTK] Install either libxfont1-dev or libxfont-dev as dependency
492         https://bugs.webkit.org/show_bug.cgi?id=167498
493
494         Reviewed by Carlos Garcia Campos.
495
496         Depending on the distro version you can need either libxfont1-dev
497         or libfont-dev to build with jhbuild.
498
499         * gtk/install-dependencies:
500
501 2017-01-31  Ryan Haddad  <ryanhaddad@apple.com>
502
503         Disable API test WebKit2.WKWebProcessPlugInRangeHandle
504         https://bugs.webkit.org/show_bug.cgi?id=167594
505
506         Unreviewed test gardening.
507
508         Disabling this test while we investigate the cause of a timeout on ios-simulator.
509
510         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm:
511         (TEST):
512
513 2017-01-31  Filip Pizlo  <fpizlo@apple.com>
514
515         Move slow-running microbenchmarks out of JSTests/microbenchmarks
516         https://bugs.webkit.org/show_bug.cgi?id=167676
517
518         Reviewed by Saam Barati.
519
520         * Scripts/run-javascriptcore-tests:
521         (runJSCStressTests): Add slowMicrobenchmarks.yaml.
522
523 2017-01-31  Megan Gardner  <megan_gardner@apple.com>
524
525         Make Dump Render Tree not crash
526         https://bugs.webkit.org/show_bug.cgi?id=167667
527
528         DumpRenderTree is crashing when running WK2 tests that it's not supposed to be running. 
529         DumpRenderTree uses RunLoop::main.dispatch(), but that crashes because it's not set up on iOS.
530         So we're making use of RunWebThread, which is the correct thing to do on iOS, and it doesn't crash.
531         This does not fix any tests, it just fixes the crash.
532         
533         Reviewed by Simon Fraser.
534
535         * DumpRenderTree/TestRunner.cpp:
536         (TestRunner::callUIScriptCallback):
537
538 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
539
540         Workaround for simctl install failing to report install failure
541         https://bugs.webkit.org/show_bug.cgi?id=167654
542
543         Reviewed by Daniel Bates.
544
545         simctl install will sometimes report success even though install has failed.
546         To workaround this bug, we attempt an app launch after install to ensure
547         install has succeeded.
548
549         * Scripts/webkitpy/xcode/simulator.py:
550         (Device.install_app): Attempt app launch after install, retry install if launch fails.
551         (Device.launch_app): Correct comment.
552
553 2017-01-31  Jonathan Bedard  <jbedard@apple.com>
554
555         Unreviewed webkitpy fix after r211405.
556
557         * Scripts/webkitpy/xcode/simulator.py:
558         (Device.launch_app): Remove @staticmethod on _log_debug_error.
559
560 2017-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
561
562         Unreviewed. Do not include libwebrtc and qunit in GTK+ tarballs.
563
564         * gtk/manifest.txt.in:
565
566 2017-01-31  Chris Fleizach  <cfleizach@apple.com>
567
568         AX: enable search predication for iOS
569         https://bugs.webkit.org/show_bug.cgi?id=167558
570         <rdar://problem/30251367>
571
572         Reviewed by Joanmarie Diggs.
573
574         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
575         (AccessibilityUIElement::uiElementForSearchPredicate):
576         * DumpRenderTree/mac/AccessibilityCommonMac.h:
577         * DumpRenderTree/mac/AccessibilityCommonMac.mm:
578         (searchPredicateParameterizedAttributeForSearchCriteria):
579         * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
580         (searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
581         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
582         (WTR::AccessibilityUIElement::uiElementCountForSearchPredicate):
583         (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
584         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.h:
585         * WebKitTestRunner/InjectedBundle/mac/AccessibilityCommonMac.mm:
586         (WTR::searchPredicateParameterizedAttributeForSearchCriteria):
587         * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
588         (WTR::searchPredicateParameterizedAttributeForSearchCriteria): Deleted.
589         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
590
591 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
592
593         Workaround for simctl launch bug
594         https://bugs.webkit.org/show_bug.cgi?id=167613
595
596         Reviewed by Daniel Bates.
597
598         simctl launch will sometimes fail because of a race condition when many
599         simulators are being run simultaneously. These failures will always have
600         an exit code of 1. This change attempts to launch an app multiple times
601         before reporting a failure to workaround this bug.
602
603         * Scripts/webkitpy/xcode/simulator.py:
604         (Device.launch_app): Execute multiple launch attempts, better logging of failures.
605
606 2017-01-30  Alexey Proskuryakov  <ap@apple.com>
607
608         Commit queue fails to look at real name aliases for the reviewer
609         https://bugs.webkit.org/show_bug.cgi?id=167422
610
611         Reviewed by Joseph Pecoraro.
612
613         * Scripts/webkitpy/common/checkout/changelog_unittest.py:
614         (test_has_valid_reviewer): Added tests.
615
616         * Scripts/webkitpy/common/config/committers.py:
617         (CommitterList._name_to_contributor_map):
618         Made _name_to_contributor_map include alias names.
619
620         * Scripts/webkitpy/common/config/committers_unittest.py:
621         (CommittersTest.test_contributors_by_fuzzy_match):
622         Removed subtests that are now obsolete, as these matches are strict. It is not
623         obvious if distance based fuzzy matching for names is useful at all, but we can
624         look into that some other time.
625
626 2017-01-30  Aakash Jain  <aakash_jain@apple.com>
627
628         QueueStatusServer should have an explicit timeout for _fetch_url
629         https://bugs.webkit.org/show_bug.cgi?id=167467
630
631         Reviewed by Alexey Proskuryakov.
632
633         * Scripts/webkitpy/common/net/statusserver.py:
634         (StatusServer._fetch_url): Add an explicit timeout of 300s.
635
636 2017-01-30  Kocsen Chung  <kocsen_chung@apple.com>
637
638         Add support for Trac instances that host multiple projects.
639         https://bugs.webkit.org/show_bug.cgi?id=167524
640
641         Reviewed by Alexey Proskuryakov.
642
643         When multiple projects are hosted on a single Trac instance, the current
644         behavior will retrieve changesets from all tracked projects.
645         This patch teaches Trac.js to get project-specific changesets from Trac.
646         We do this by replacing the parameter `changeset=on` to `repo-projectname=on`
647         when querying the Trac timeline.
648
649         To tell Trac to be aware of multi-project instances we leverage the 
650         `options` parameter when creating a new instance: 
651
652             new Trac("https://mytrac.com/", { projectIdentifier: "tracProjectName" });
653
654         If this option is not provided, the original behaviour will prevail.
655         Additionally, add corresponding tests.
656
657         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:
658         (Trac): Reason about new optional parameter 'projectIdentifier'.
659         (Trac.prototype.revisionURL): Given a projectIdentifier, append it to the end of the URL.
660         (Trac.prototype._xmlTimelineURL): Given a projectIdentifier,
661         replace default parameter `changeset=on` with `repo-projectname=on`.
662         (Trac.prototype._convertCommitInfoElementToObject): Fix missing ';'.
663         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockTrac.js:
664         (MockTrac): Add support for instantiating Trac with a projectIdentifier.
665         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/tests.js:
666         (setup): Provide a multiple-project MockTrac instance to all test cases for testing.
667         Add the following tests:
668             test("revisionURL")
669             test("revisionURL with Trac Identifier")
670             test("_xmlTimelineURL")
671             test("_xmlTimelineURL with Trac Identifier")
672         (this.view._latestProductiveIteration): Fix missing ';'.
673
674 2017-01-30  Myles C. Maxfield  <mmaxfield@apple.com>
675
676         Correct spacing regression on inter-element complex path shaping on some fonts
677         https://bugs.webkit.org/show_bug.cgi?id=166013
678
679         Reviewed by Simon Fraser.
680
681         Unskip existing tests and make some new tests:
682         - Testing complex text with no origins
683         - Testing initial expansions
684         - Testing the sign of vertical advances
685
686         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
687         (TestWebKitAPI::TEST_F):
688
689 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
690
691         [GTK][EFL] Avoid using a thin directory to create the built product on the archive-built-product step.
692         https://bugs.webkit.org/show_bug.cgi?id=167596
693
694         Reviewed by Daniel Bates.
695
696         We avoid needing a thin directory by invoking the zip program with
697         the list of directories from the build directory to be zipped,
698         and by using the zip feature to exclude files matching a pattern.
699
700         * BuildSlaveSupport/built-product-archive:
701         (copyBuildFiles):
702         (createZipFromList):
703         (archiveBuiltProduct):
704
705 2017-01-30  Jonathan Bedard  <jbedard@apple.com>
706
707         Use simctl instead of LayoutTestRelay
708         https://bugs.webkit.org/show_bug.cgi?id=165927
709
710         Reviewed by Daniel Bates.
711
712         Part 1
713
714         LayoutTestRelay uses SPI, since recent versions of the iOS SDK allow for installing apps on
715         simulators through simctl (iOS 10 and later), use this functionality instead.
716
717         * Scripts/webkitpy/port/base.py:
718         (Port.__init__): Added _test_runner_process_constructor.
719         * Scripts/webkitpy/port/darwin.py:
720         (DarwinPort.app_identifier_from_bundle): Added function to extract bundle ID from plist.
721         * Scripts/webkitpy/port/driver.py:
722         (Driver._start): Pass worker_number to server_process so we can look up the correct simulator device to use.
723         (IOSSimulatorDriver): Deleted.
724         * Scripts/webkitpy/port/driver_unittest.py:
725         (DriverTest.test_stop_cleans_up_properly): Set _test_runner_process_constructor for testing.
726         (DriverTest.test_two_starts_cleans_up_properly): Ditto.
727         (DriverTest.test_start_actually_starts): Ditto.
728         * Scripts/webkitpy/port/ios.py:
729         (IOSSimulatorPort): Remove relay_name.
730         (IOSSimulatorPort.__init__): Set _test_runner_process_constructor to SimulatorProcess for IOSSimulatorPort.
731         (IOSSimulatorPort._create_simulators): Formatting change.
732         (IOSSimulatorPort.relay_path): Deleted.
733         (IOSSimulatorPort._check_relay): Deleted.
734         (IOSSimulatorPort._check_port_build): Deleted. Use base class implementation
735         (IOSSimulatorPort._build_relay): Deleted.
736         (IOSSimulatorPort._build_driver): Deleted. Use base class implementation
737         (IOSSimulatorPort._driver_class): Deleted. Use base class implementation
738         * Scripts/webkitpy/port/ios_unittest.py:
739         (iosTest.test_32bit): Update test.
740         (iosTest.test_64bit): Update test.
741         * Scripts/webkitpy/port/server_process.py:
742         (ServerProcess.__init__): Added argument worker_number. This class does not make use of it. We will make use of this argument in SimulatorProcess to lookup the associated simulator device.
743         (ServerProcess._set_file_nonblocking): Added to share common code.
744         * Scripts/webkitpy/port/server_process_mock.py:
745         (MockServerProcess.__init__): Added argument worker_number.
746         * Scripts/webkitpy/port/simulator_process.py: Added.
747         (SimulatorProcess): Added.
748         (SimulatorProcess.Popen): Added.
749         (SimulatorProcess.Popen.__init__): Added. Initialize Popen structure with stdin, stdout, stderr and pid.
750         (SimulatorProcess.Popen.poll): Added. Check if the process is running.
751         (SimulatorProcess.Popen.wait): Added. Wait for process to close.
752         (SimulatorProcess.__init__): Added. Install app to device specified through port and worker_number.
753         (SimulatorProcess._reset): Added. Unlink fifos.
754         (SimulatorProcess._start): Added. Launch app on simulator, link fifos.
755         (SimulatorProcess._kill): Added. Shutdown app on simulator.
756         * Scripts/webkitpy/xcode/simulator.py:
757         (Device.__init__): Accept host to run install/launch/terminate.
758         (Device.install_app): Install app to target Device.
759         (Device.launch_app): Launch app on target Device.
760         (Device.terminate_app): Shutdown app on target Device.
761         (Simulator._parse_devices): Pass host to Device.
762
763 2017-01-30  Carlos Alberto Lopez Perez  <clopez@igalia.com>
764
765         [GTK] pixman fails to compile on Raspberry Pi (GCC crash)
766         https://bugs.webkit.org/show_bug.cgi?id=167411
767
768         Reviewed by Michael Catanzaro.
769
770         Disable the ARM iwMMXt fast path for pixman, because it triggers
771         a GCC bug on the RPi with Raspbian/PIXEL causing a build failure.
772
773         * gtk/jhbuild.modules:
774
775 2017-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
776
777         [GTK] Add API to handle the accelerated compositing policy
778         https://bugs.webkit.org/show_bug.cgi?id=167509
779
780         Reviewed by Michael Catanzaro.
781
782         Handle new setting in MiniBrowser. The settings dialog doesn't support enum settings so it needs to be handled
783         as a special case. Also add test cases to the get/set API.
784
785         * MiniBrowser/gtk/BrowserSettingsDialog.c:
786         (hardwareAccelerationPolicyToString):
787         (stringToHardwareAccelerationPolicy):
788         (cellRendererChanged):
789         (browserSettingsDialogConstructed):
790         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
791         (testWebKitSettings):
792
793 2017-01-29  Andy Estes  <aestes@apple.com>
794
795         [QuickLook] Add a WebPreference to enable saving QuickLook documents in WebKitLegacy
796         https://bugs.webkit.org/show_bug.cgi?id=167563
797         <rdar://problem/30253207>
798
799         Reviewed by Andreas Kling.
800
801         * TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
802         (-[QuickLookNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
803         (-[QuickLookNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
804         (runTest):
805         (-[QuickLookFrameLoadDelegate webView:didFinishLoadForFrame:]):
806         (TEST):
807
808 2017-01-29  Dan Bernstein  <mitz@apple.com>
809
810         [iOS] Expose WebCore::DataDetection::detectContentInRange WKWebProcessPlugInRangeHandle
811         https://bugs.webkit.org/show_bug.cgi?id=167565
812
813         Reviewed by Sam Weinig.
814
815         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
816         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandle.mm: Added.
817         (-[BundleRangeHandleRemoteObject textFromBodyRange:]):
818         (-[BundleRangeHandleRemoteObject bodyInnerHTMLAfterDetectingData:]):
819         (TEST):
820         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandlePlugIn.mm: Added.
821         (-[BundleRangeHandlePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
822         (-[BundleRangeHandlePlugIn webProcessPlugInBrowserContextController:didFinishDocumentLoadForFrame:]):
823         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleRangeHandleProtocol.h: Added.
824
825 2017-01-28  Yoav Weiss  <yoav@yoav.ws>
826
827         Add Link Preload as an off-by-default experimental feature menu item.
828         https://bugs.webkit.org/show_bug.cgi?id=167201
829
830         Reviewed by Ryosuke Niwa.
831
832         * DumpRenderTree/mac/DumpRenderTree.mm:
833         (resetWebPreferencesToConsistentValues):
834         * DumpRenderTree/win/DumpRenderTree.cpp:
835         (resetWebPreferencesToConsistentValues):
836
837 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
838
839         Add User Timing Experimental Feature
840         https://bugs.webkit.org/show_bug.cgi?id=167542
841         <rdar://problem/22746307>
842
843         Reviewed by Ryosuke Niwa.
844
845         * DumpRenderTree/mac/DumpRenderTree.mm:
846         (enableExperimentalFeatures):
847         (resetWebPreferencesToConsistentValues):
848         * DumpRenderTree/win/DumpRenderTree.cpp:
849         (enableExperimentalFeatures):
850
851 2017-01-28  Joseph Pecoraro  <pecoraro@apple.com>
852
853         Patch Review: EWS Bubbles wrap to multiple lines but can fit on one line
854         https://bugs.webkit.org/show_bug.cgi?id=167519
855
856         Reviewed by Ryosuke Niwa.
857
858         * QueueStatusServer/templates/statusbubble.html:
859         To measure the bubbleContainer's width, it must not be wrapping based
860         on its parent container. So when measuring the width temporarily set
861         the parent to a very large width so as to not artificially wrap us.
862         Restore the parent's width after measuring.
863
864 2017-01-27  Andy Estes  <aestes@apple.com>
865
866         [iOS] Add a test for _WKNSFileManagerExtras
867         https://bugs.webkit.org/show_bug.cgi?id=167478
868
869         Reviewed by Andreas Kling.
870
871         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
872         * TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm: Added.
873         (expectAttributes):
874         (TEST):
875
876 2017-01-27  Keith Miller  <keith_miller@apple.com>
877
878         run-benchmarks should make sure it passes the test url to the right application
879         https://bugs.webkit.org/show_bug.cgi?id=167533
880
881         Reviewed by Joseph Pecoraro.
882
883         This fixes an issue when trying to run-benchmark script with the
884         system default browser set to STP. Previously, it would run
885         the test in STP rather than the provided build. Now, it should run
886         in the provided build.
887
888         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
889         (OSXSafariDriver.launch_url):
890
891 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
892
893         [Cocoa] Prepare ComplexTextController for unit testing
894         https://bugs.webkit.org/show_bug.cgi?id=167493
895
896         Reviewed by Simon Fraser.
897
898         Addressing post-review comments from Simon Fraser.
899
900         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp:
901         (TestWebKitAPI::TEST_F):
902
903 2017-01-27  Myles C. Maxfield  <mmaxfield@apple.com>
904
905         [Cocoa] Prepare ComplexTextController for unit testing
906         https://bugs.webkit.org/show_bug.cgi?id=167493
907
908         Reviewed by Dean Jackson.
909
910         Create four unit tests.
911
912         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
913         * TestWebKitAPI/Tests/WebCore/ComplexTextController.cpp: Added.
914         (TestWebKitAPI::ComplexTextControllerTest::SetUp):
915         (TestWebKitAPI::TEST_F):
916
917 2017-01-26  Chris Dumez  <cdumez@apple.com>
918
919         Crash when navigating back to a page in PacheCache when one of its frames has been removed
920         https://bugs.webkit.org/show_bug.cgi?id=167421
921         <rdar://problem/30188490>
922
923         Reviewed by Darin Adler.
924
925         Add a new setting allowing layout tests to enable PageCache in a window
926         that has an opener, for convenience.
927
928         * DumpRenderTree/mac/DumpRenderTree.mm:
929         (resetWebPreferencesToConsistentValues):
930         * DumpRenderTree/win/DumpRenderTree.cpp:
931         (resetWebPreferencesToConsistentValues):
932         * WebKitTestRunner/TestController.cpp:
933         (WTR::TestController::resetPreferencesToConsistentValues):
934
935 2017-01-26  Keith Miller  <keith_miller@apple.com>
936
937         classInfo should take a VM so it is not materialized from the object on each call
938         https://bugs.webkit.org/show_bug.cgi?id=167424
939
940         Rubber Stamped by Michael Saboff.
941
942         Previously, classInfo() would get the VM from the target's
943         MarkedBlock.  Most callers already have a VM on hand, so it is
944         wasteful to compute the VM from the marked block every time. This
945         patch refactors some of the most common callers of classInfo(),
946         jsDynamicCast and inherits to take a VM as well.
947
948         * DumpRenderTree/TestRunner.cpp:
949         (setAudioResultCallback):
950
951 2017-01-26  Jer Noble  <jer.noble@apple.com>
952
953         Autoplay muted videos stop playback of any streaming app in the background
954         https://bugs.webkit.org/show_bug.cgi?id=163993
955         <rdar://problem/29020431>
956
957         Reviewed by Eric Carlson.
958
959         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
960         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
961         (TestWebKitAPI::TEST):
962         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio-and-webaudio.html: Added.
963
964 2017-01-26  Ryan Haddad  <ryanhaddad@apple.com>
965
966         Disable API test WebKit2.WebsitePoliciesPlayAfterPreventedAutoplay.
967         https://bugs.webkit.org/show_bug.cgi?id=167466
968
969         Unreviewed test gardening.
970
971         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
972         (TEST):
973
974 2017-01-26  Matt Rajca  <mrajca@apple.com>
975
976         Notify clients when the user plays media otherwise prevented from autoplaying
977         https://bugs.webkit.org/show_bug.cgi?id=167390
978
979         Reviewed by Alex Christensen.
980
981         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
982         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
983         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
984         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
985         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
986         (TEST):
987         * TestWebKitAPI/cocoa/TestWKWebView.h:
988         * TestWebKitAPI/cocoa/TestWKWebView.mm:
989         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
990         (-[TestWKWebView waitForLoad]):
991         (-[TestWKWebView mouseUpAtPoint:]):
992         * WebKitTestRunner/TestController.cpp:
993         (WTR::TestController::createOtherPage):
994         (WTR::TestController::createWebViewWithOptions):
995
996 2017-01-26  Per Arne Vollan  <pvollan@apple.com>
997
998         Crash when setting custom scale factor.
999         https://bugs.webkit.org/show_bug.cgi?id=167369
1000
1001         Reviewed by Sam Weinig.
1002
1003         Added API test.
1004
1005         * TestWebKitAPI/PlatformWin.cmake:
1006         * TestWebKitAPI/Tests/WebKit/win/ScaleWebView.cpp: Added.
1007         (TestWebKitAPI::WebKitCreateInstance):
1008         (TestWebKitAPI::ScaleWebView::SetUp):
1009         (TestWebKitAPI::ScaleWebView::TearDown):
1010         (TestWebKitAPI::TEST_F):
1011
1012 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1013
1014         run-benchmark nests MotionMark results by the suite name twice
1015         https://bugs.webkit.org/show_bug.cgi?id=164948
1016
1017         Reviewed by Said Abou-Hallawa.
1018
1019         Use a single level MotionMark now that this is the name of the benchmark,
1020         and we no longer have tests that aren't part of the MotionMark suite.
1021
1022         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch:
1023
1024 2017-01-25  Ryan Haddad  <ryanhaddad@apple.com>
1025
1026         Unreviewed, rolling out r211193.
1027
1028         This change broke internal builds.
1029
1030         Reverted changeset:
1031
1032         "Notify clients when the user plays media otherwise prevented
1033         from autoplaying"
1034         https://bugs.webkit.org/show_bug.cgi?id=167390
1035         http://trac.webkit.org/changeset/211193
1036
1037 2017-01-25  Matt Rajca  <mrajca@apple.com>
1038
1039         Notify clients when the user plays media otherwise prevented from autoplaying
1040         https://bugs.webkit.org/show_bug.cgi?id=167390
1041
1042         Reviewed by Alex Christensen.
1043
1044         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1045         * TestWebKitAPI/Tests/WebKit2/autoplay-with-controls.html: Added.
1046         * TestWebKitAPI/Tests/WebKit2/js-play-with-controls.html: Added.
1047         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1048         (didPlayMediaPreventedFromPlayingWithoutUserGesture):
1049         (TEST):
1050         * TestWebKitAPI/cocoa/TestWKWebView.h:
1051         * TestWebKitAPI/cocoa/TestWKWebView.mm:
1052         (-[TestWKWebViewHostWindow _mouseUpAtPoint:]):
1053         (-[TestWKWebView waitForLoad]):
1054         (-[TestWKWebView mouseUpAtPoint:]):
1055         * WebKitTestRunner/TestController.cpp:
1056         (WTR::TestController::createOtherPage):
1057         (WTR::TestController::createWebViewWithOptions):
1058
1059 2017-01-25  Matt Rajca  <mrajca@apple.com>
1060
1061         [ios-simulator] API test WebKit2.WebsitePoliciesAutoplayEnabled timing out
1062         https://bugs.webkit.org/show_bug.cgi?id=167385
1063
1064         Reviewed by Alex Christensen.
1065
1066         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Avoid arbitrary timeouts in favor of promises.
1067         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html:
1068         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1069         (TEST): Allow inline (rather than full screen) media playback on iOS.
1070
1071 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1072
1073         [GTK] Icon Database should be in private browsing mode for ephemeral web views
1074         https://bugs.webkit.org/show_bug.cgi?id=167414
1075
1076         Reviewed by Michael Catanzaro.
1077
1078         Add a test case to check ephemeral web views don't write favicons to the database.
1079
1080         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
1081         (ephemeralViewLoadChanged):
1082         (testPrivateBrowsing):
1083         (testFaviconDatabase):
1084
1085 2017-01-25  Carlos Garcia Campos  <cgarcia@igalia.com>
1086
1087         [GTK] Add a private browsing mode to MiniBrowser
1088         https://bugs.webkit.org/show_bug.cgi?id=167413
1089
1090         Reviewed by Michael Catanzaro.
1091
1092         Add -p/--private command line option to create a private instance. Also add CTRL+SHIFT+P shortcut to create
1093         private windows, even on non-private instances.
1094
1095         * MiniBrowser/gtk/BrowserWindow.c:
1096         (webViewTitleChanged): Add [Private] to title window for private windows.
1097         (webViewCreate): Pass web context to browser_window_new.
1098         (openPrivateWindow): Create a new ephemeral web view and add it to a new window.
1099         (browserWindowFinalize): Disconnect web context signal handlers.
1100         (browser_window_init): Add shortcut for opening private window.
1101         (browser_window_new): It now receives the context and connect to download-started here.
1102         (browser_window_get_web_context): Return the context.
1103         * MiniBrowser/gtk/BrowserWindow.h:
1104         * MiniBrowser/gtk/main.c:
1105         (createBrowserTab): Create the web view for the window web context.
1106         (aboutDataScriptMessageReceivedCallback): Do not use the default web context, but the window one.
1107         (aboutDataHandleRequest): Ditto.
1108         (aboutURISchemeRequestCallback): Ditto.
1109         (main): Create ephemeral web context if private command line option is used.
1110
1111 2017-01-25  Ryosuke Niwa  <rniwa@webkit.org>
1112
1113         collectMatchingElementsInFlatTree should not find elements inside an user agent shadow tree
1114         https://bugs.webkit.org/show_bug.cgi?id=167409
1115
1116         Reviewed by Antti Koivisto.
1117
1118         Added a test case for collectMatchingElementsInFlatTree not finding elements inside an user agent shadow tree
1119         as well as tests for the newly added matchingElementInFlatTree.
1120
1121         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen.cpp:
1122         (TestWebKitAPI::runJavaScriptAlert):
1123         * TestWebKitAPI/Tests/WebKit2/InjectedBundleMakeAllShadowRootsOpen_Bundle.cpp:
1124         (TestWebKitAPI::InjectedBundleMakeAllShadowRootOpenTest::initialize):
1125         * TestWebKitAPI/Tests/WebKit2/closed-shadow-tree-test.html:
1126
1127 2017-01-24  Carlos Garcia Campos  <cgarcia@igalia.com>
1128
1129         [GTK] Add API to create ephemeral web views and deprecate the private browsing setting
1130         https://bugs.webkit.org/show_bug.cgi?id=167370
1131
1132         Reviewed by Michael Catanzaro.
1133
1134         Add several test cases of ephemeral web views.
1135
1136         * TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
1137         (testWebViewAuthenticationStorage):
1138         * TestWebKitAPI/Tests/WebKit2Gtk/TestCookieManager.cpp:
1139         (ephemeralViewloadChanged):
1140         (testCookieManagerEphemeral):
1141         (beforeAll):
1142         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
1143         (testWebKitSettings):
1144         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1145         (testWebContextEphemeral):
1146         (ephemeralViewloadChanged):
1147         (testWebContextProxySettings):
1148         (beforeAll):
1149         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1150         (ephemeralViewloadChanged):
1151         (testWebViewEphemeral):
1152         (beforeAll):
1153         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp:
1154         (ephemeralViewloadChanged):
1155         (testWebsiteDataEphemeral):
1156         (beforeAll):
1157
1158 2017-01-24  Alex Christensen  <achristensen@webkit.org>
1159
1160         REGRESSION (r208902): URLWithUserTypedString returns nil with file URLs
1161         https://bugs.webkit.org/show_bug.cgi?id=167402
1162
1163         Reviewed by Ryosuke Niwa.
1164
1165         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm:
1166         (TestWebKitAPI::TEST):
1167
1168 2017-01-24  Zalan Bujtas  <zalan@apple.com>
1169
1170         Add simple line layout toggle to MiniBrowser
1171         https://bugs.webkit.org/show_bug.cgi?id=167405
1172
1173         Reviewed by Andreas Kling.
1174
1175         * MiniBrowser/mac/SettingsController.h:
1176         * MiniBrowser/mac/SettingsController.m:
1177         (-[SettingsController _populateMenu]):
1178         (-[SettingsController validateMenuItem:]):
1179         (-[SettingsController toggleSimpleLineLayoutEnabled:]):
1180         (-[SettingsController simpleLineLayoutEnabled]):
1181         * MiniBrowser/mac/WK1BrowserWindowController.m:
1182         (-[WK1BrowserWindowController didChangeSettings]):
1183         * MiniBrowser/mac/WK2BrowserWindowController.m:
1184         (-[WK2BrowserWindowController didChangeSettings]):
1185
1186 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1187
1188         WKR does not include my nick when commit-queue lands my patch
1189         https://bugs.webkit.org/show_bug.cgi?id=167388
1190
1191         Reviewed by Ryosuke Niwa.
1192
1193         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1194         (NewCommitBot._summarize_commit_log):
1195         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py:
1196         Perform nickname insertion before grabbing "Patch by" details.
1197         This way we can include the nickname with the full name.
1198
1199 2017-01-24  Joseph Pecoraro  <pecoraro@apple.com>
1200
1201         Fold USER_TIMING into WEB_TIMING and make it a RuntimeEnabledFeature
1202         https://bugs.webkit.org/show_bug.cgi?id=167394
1203
1204         Reviewed by Ryosuke Niwa.
1205
1206         * Scripts/webkitperl/FeatureList.pm:
1207         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1208
1209 2017-01-24  Youenn Fablet  <youenn@apple.com>
1210
1211         [WebRTC] Use HAVE_PTHREAD_COND_TIMEDWAIT_RELATIVE for libwebrtc
1212         https://bugs.webkit.org/show_bug.cgi?id=167353
1213
1214         Reviewed by Alex Christensen.
1215
1216         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1217         (CMakeGenerator.initialize_targets):
1218
1219 2017-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
1220
1221         WKR should not confuse Miguel Gomez with Andres Gomez
1222         https://bugs.webkit.org/show_bug.cgi?id=167389
1223
1224         Reviewed by Lucas Forschler.
1225
1226         Andres's email is a substring of Miguel's, causing WKR to credit Miguel's commits to
1227         "mAndres Gomez". Fix this.
1228
1229         * Scripts/webkitpy/tool/commands/newcommitbot.py:
1230         (NewCommitBot._summarize_commit_log): Be stricter about matching emails. SVN logs include a
1231         space on each side of the email address, so expect both spaces to be there before
1232         considering the email for replacement.
1233         * Scripts/webkitpy/tool/commands/newcommitbot_unittest.py: Add a test.
1234
1235 2017-01-24  Matt Rajca  <mrajca@apple.com>
1236
1237         Pass down website autoplay policies to media elements
1238         https://bugs.webkit.org/show_bug.cgi?id=167355
1239
1240         Reviewed by Alex Christensen.
1241
1242         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1243         * TestWebKitAPI/Tests/WebKit2/autoplay-check.html: Renamed from Tools/TestWebKitAPI/Tests/WebKit2/autoplayCheck.html to match our naming conventions.
1244         * TestWebKitAPI/Tests/WebKit2/autoplay-no-audio-check.html: Added.
1245         * TestWebKitAPI/Tests/WebKit2/test-without-audio-track.mp4: Added.
1246         * TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
1247         (-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
1248         (TEST):
1249
1250 2017-01-24  Nan Wang  <n_wang@apple.com>
1251
1252         AX: Speak Selection does not work in an iframe
1253         https://bugs.webkit.org/show_bug.cgi?id=166794
1254         <rdar://problem/29913013>
1255
1256         Reviewed by Chris Fleizach.
1257
1258         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
1259         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1260         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1261         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
1262         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
1263         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1264         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1265         * TestRunnerShared/UIScriptContext/UIScriptController.h:
1266         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
1267         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
1268         (-[TestRunnerWKWebView dealloc]):
1269         (-[TestRunnerWKWebView _accessibilityDidGetSpeakSelectionContent:]):
1270         (-[TestRunnerWKWebView accessibilityRetrieveSpeakSelectionContentWithCompletionHandler:]):
1271         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1272         (WTR::UIScriptController::retrieveSpeakSelectionContent):
1273         (WTR::UIScriptController::accessibilitySpeakSelectionContent):
1274
1275 2017-01-24  Daniel Bates  <dabates@apple.com>
1276
1277         StringView.split() should use an iterator design pattern instead of allocating a Vector
1278         https://bugs.webkit.org/show_bug.cgi?id=163225
1279
1280         Reviewed by Darin Adler.
1281
1282         Add unit tests for StringView.split().
1283
1284         * TestWebKitAPI/Tests/WTF/StringView.cpp:
1285         (TestWebKitAPI::stringViewFromLiteral): Moved to the top of the file so that it can be
1286         used in the StringView.split() unit tests.
1287         (TestWebKitAPI::stringViewFromUTF8): Ditto.
1288         (TestWebKitAPI::vectorFromSplitResult): Convenience function to convert a StringView::SplitResult
1289         object to a Vector of String objects.
1290         (TestWebKitAPI::TEST): Added the following tests:
1291             - WTF.StringViewSplitEmptyAndNullStrings
1292             - WTF.StringViewSplitBasic
1293             - WTF.StringViewSplitWithConsecutiveSeparators
1294
1295 2017-01-23  Anders Carlsson  <andersca@apple.com>
1296
1297         The Score Esports crashes on launch
1298         https://bugs.webkit.org/show_bug.cgi?id=167338
1299         rdar://problem/29948645
1300
1301         Reviewed by Dan Bernstein.
1302
1303         * TestWebKitAPI/Tests/WebKit2Cocoa/WKObject.mm:
1304         (TestWebKitAPI::TEST):
1305         Add a test.
1306
1307 2017-01-23  Carlos Garcia Campos  <cgarcia@igalia.com>
1308
1309         [GTK] Add API to WebKitWebsiteDataManager to handle website data
1310         https://bugs.webkit.org/show_bug.cgi?id=146589
1311
1312         Reviewed by Michael Catanzaro.
1313
1314         Add about:data handler to MiniBrowser to manually test the website data API. Also add unit tests to test all the
1315         new API, moving the WebKitWebsiteDataManager configuration API to the new file too.
1316
1317         * MiniBrowser/gtk/BrowserWindow.c:
1318         (webViewDecidePolicy):
1319         (newTabCallback):
1320         * MiniBrowser/gtk/main.c:
1321         (createBrowserTab):
1322         (aboutDataRequestFree):
1323         (aboutDataRequestNew):
1324         (aboutDataRequestForView):
1325         (websiteDataRemovedCallback):
1326         (websiteDataClearedCallback):
1327         (aboutDataScriptMessageReceivedCallback):
1328         (domainListFree):
1329         (aboutDataFillTable):
1330         (gotWebsiteDataCallback):
1331         (aboutDataHandleRequest):
1332         (aboutURISchemeRequestCallback):
1333         (main):
1334         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
1335         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1336         (serverCallback):
1337         (beforeAll):
1338         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebsiteData.cpp: Added.
1339         (serverCallback):
1340         (WebsiteDataTest::WebsiteDataTest):
1341         (WebsiteDataTest::~WebsiteDataTest):
1342         (WebsiteDataTest::fetch):
1343         (WebsiteDataTest::remove):
1344         (WebsiteDataTest::clear):
1345         (testWebsiteDataConfiguration):
1346         (testWebsiteDataCache):
1347         (testWebsiteDataStorage):
1348         (testWebsiteDataDatabases):
1349         (testWebsiteDataAppcache):
1350         (beforeAll):
1351         (afterAll):
1352
1353 2017-01-23  Commit Queue  <commit-queue@webkit.org>
1354
1355         Unreviewed, rolling out r211062.
1356         https://bugs.webkit.org/show_bug.cgi?id=167354
1357
1358         broke API tests (Requested by alexchristensen on #webkit).
1359
1360         Reverted changeset:
1361
1362         "Pass down website autoplay policies to media elements"
1363         https://bugs.webkit.org/show_bug.cgi?id=167132
1364         http://trac.webkit.org/changeset/211062
1365
1366 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1367
1368         URLParser should fail to parse percent-encoded invalid UTF-8 sequences
1369         https://bugs.webkit.org/show_bug.cgi?id=167330
1370
1371         Reviewed by Tim Horton.
1372
1373         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1374         (TestWebKitAPI::TEST_F):
1375
1376 2017-01-23  Alex Christensen  <achristensen@webkit.org>
1377
1378         Make URLs with non-special schemes and a query or fragment but no slash after the host more compatible
1379         https://bugs.webkit.org/show_bug.cgi?id=167317
1380
1381         Reviewed by Sam Weinig.
1382
1383         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
1384         (TestWebKitAPI::TEST_F):
1385
1386 2017-01-23  Jonathan Bedard  <jbedard@apple.com>
1387
1388         svn-create-patch should emit properties when files are moved or copied
1389         https://bugs.webkit.org/show_bug.cgi?id=167264
1390
1391         Reviewed by Daniel Bates.
1392
1393         * Scripts/svn-create-patch:
1394         (manufacturePatchForAdditionWithHistory): Diff the source file against nothing to get properties.
1395
1396 2017-01-23  Youenn Fablet  <youenn@apple.com>
1397
1398         [WebRTC] Filter libwebrtc link flags
1399         https://bugs.webkit.org/show_bug.cgi?id=167287
1400
1401         Reviewed by Alex Christensen.
1402
1403         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1404         (CMakeGenerator._compute_link_flags):
1405         (CMakeGenerator._compute_link_flags.keep_flag):
1406         (CMakeGenerator._generate_compile_target_options):
1407
1408 2017-01-23  Youenn Fablet  <youennf@gmail.com>
1409
1410         [WebRTC] Make VP8 optional in libwebrtc
1411         https://bugs.webkit.org/show_bug.cgi?id=167257
1412
1413         Reviewed by Darin Adler.
1414
1415         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1416         (CMakeGenerator.remove_libvpx): Adding vp8_noop.cc to the build system.
1417
1418 2017-01-23  Jer Noble  <jer.noble@apple.com>
1419
1420         Video details does not apear and missing scrubber in Control Center
1421         https://bugs.webkit.org/show_bug.cgi?id=167233
1422
1423         Reviewed by Alex Christensen.
1424
1425         Refactor TestWKWebViewMac to work on PLATFORM(IOS). Add a new test to
1426         NowPlayingControlTests for iOS.
1427
1428         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1429         * TestWebKitAPI/Tests/WebKit2Cocoa/NowPlayingControlsTests.mm:
1430         (-[NowPlayingTestWebView setWindowVisible:]):
1431         (TestWebKitAPI::TEST):
1432         * TestWebKitAPI/Tests/WebKit2Cocoa/SnapshotStore.mm:
1433         * TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:
1434         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewCandidateTests.mm:
1435         * TestWebKitAPI/cocoa/TestWKWebView.h: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.h.
1436         * TestWebKitAPI/cocoa/TestWKWebView.mm: Renamed from Tools/TestWebKitAPI/mac/TestWKWebViewMac.mm.
1437         (SOFT_LINK_CLASS):
1438         (-[TestMessageHandler addMessage:withHandler:]):
1439         (-[TestMessageHandler userContentController:didReceiveScriptMessage:]):
1440         (__simulated_forceClickAssociatedEventsMask):
1441         (-[TestWKWebViewHostWindow _mouseDownAtPoint:simulatePressure:]):
1442         (-[TestWKWebViewHostWindow isKeyWindow]):
1443         (-[TestWKWebViewHostWindow makeKeyWindow]):
1444         (-[TestWKWebViewHostWindow resignKeyWindow]):
1445         (-[TestWKWebView initWithFrame:]):
1446         (-[TestWKWebView initWithFrame:configuration:]):
1447         (-[TestWKWebView _setUpTestWindow:]):
1448         (-[TestWKWebView performAfterReceivingMessage:action:]):
1449         (-[TestWKWebView loadTestPageNamed:]):
1450         (-[TestWKWebView synchronouslyLoadTestPageNamed:]):
1451         (-[TestWKWebView stringByEvaluatingJavaScript:]):
1452         (-[TestWKWebView waitForMessage:]):
1453         (-[TestWKWebView performAfterLoading:]):
1454         (-[TestWKWebView mouseDownAtPoint:simulatePressure:]):
1455         (-[TestWKWebView typeCharacter:]):
1456
1457 2017-01-21  Carlos Garcia Campos  <cgarcia@igalia.com>
1458
1459         Unreviewed. Bring back gtk-doc error messages after r209981.
1460
1461         Since r209981, if gtk-doc shows warnings the build fails but those warnings are not printed to stdout so it's
1462         impossible to know what's wrong.
1463
1464         * gtk/gtkdoc.py:
1465         (GTKDoc._run_command): Make print_output True by default again and use debug instead of info to log "Running" messages.
1466
1467 2017-01-20  Youenn Fablet  <youennf@gmail.com>
1468
1469         [WebRTC] Update build system to make G711 optional in libwebrtc
1470         https://bugs.webkit.org/show_bug.cgi?id=167256
1471
1472         Reviewed by Alex Christensen.
1473
1474         * Scripts/webkitpy/libwebrtc/generate_cmake.py:
1475         (CMakeGenerator.remove_webrtc_g711): Adding a missing file to the build system as this file includes generic pcm encoder functions.
1476
1477 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1478
1479         Cleanup RuntimeEnabledFeatures
1480         https://bugs.webkit.org/show_bug.cgi?id=167228
1481
1482         Reviewed by Simon Fraser.
1483
1484         * DumpRenderTree/mac/DumpRenderTree.mm:
1485         (enableExperimentalFeatures):
1486         (resetWebPreferencesToConsistentValues):
1487         (setWebPreferencesForTestOptions):
1488         (resetWebViewToConsistentStateBeforeTesting):
1489         * DumpRenderTree/win/DumpRenderTree.cpp:
1490         (enableExperimentalFeatures):
1491         (resetWebPreferencesToConsistentValues):
1492         More closely match WebKitTestRunner initialization of preferences
1493         for experimental features.
1494
1495 2017-01-20  Alex Christensen  <achristensen@webkit.org>
1496
1497         Build Fix for Windows DumpRenderTree after r210976
1498         https://bugs.webkit.org/show_bug.cgi?id=167115
1499
1500         * DumpRenderTree/win/DumpRenderTree.cpp:
1501         (resetWebPreferencesToConsistentValues):
1502
1503 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1504
1505         Remove outdated ENABLE(CSP_NEXT) build flag
1506         https://bugs.webkit.org/show_bug.cgi?id=167252
1507
1508         Reviewed by Brent Fulgham.
1509
1510         * Scripts/webkitperl/FeatureList.pm:
1511         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1512
1513 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1514
1515         Build Fix for Windows DumpRenderTree after r210976
1516
1517         * DumpRenderTree/win/DumpRenderTree.cpp:
1518         (resetWebPreferencesToConsistentValues):
1519
1520 2017-01-20  Antoine Quint  <graouts@apple.com>
1521
1522         Web Animations should be off by default and enabled as an experimental feature
1523         https://bugs.webkit.org/show_bug.cgi?id=167115
1524         <rdar://problem/30048963>
1525
1526         Reviewed by Joseph Pecoraro.
1527
1528         Turn Web Animations on in DRT.
1529
1530         * DumpRenderTree/mac/DumpRenderTree.mm:
1531         (resetWebPreferencesToConsistentValues):
1532         * DumpRenderTree/win/DumpRenderTree.cpp:
1533         (resetWebPreferencesToConsistentValues):
1534
1535 2017-01-20  Youenn Fablet  <youenn@apple.com>
1536
1537         [WebRTC] Add libwebrtc build infrastructure
1538         https://bugs.webkit.org/show_bug.cgi?id=167207
1539
1540         Reviewed by Alex Christensen.
1541
1542         Adding a script doing the libwebrtc project json to CMake file conversion.
1543
1544         * Scripts/generate-libwebrtc-cmake: Added.
1545         * Scripts/webkitpy/libwebrtc/__init__.py: Added.
1546         * Scripts/webkitpy/libwebrtc/generate_cmake.py: Added.
1547
1548 2017-01-20  Joseph Pecoraro  <pecoraro@apple.com>
1549
1550         Mini Browser: Show tooltip for Experimental Features
1551         https://bugs.webkit.org/show_bug.cgi?id=167225
1552
1553         Reviewed by Alex Christensen.
1554
1555         * MiniBrowser/mac/SettingsController.m:
1556         (-[SettingsController _populateMenu]):
1557         Include the full details string as a tooltip.
1558
1559 2017-01-20  Per Arne Vollan  <pvollan@apple.com>
1560
1561         [Win] Test output results should not be written twice.
1562         https://bugs.webkit.org/show_bug.cgi?id=167197
1563
1564         Reviewed by Brent Fulgham.
1565
1566         Prevent test output from being written twice by returning early from
1567         the dump() function, if it already has been called.
1568         This patch also adds a missing newline to a test output line. 
1569         
1570         * DumpRenderTree/win/DumpRenderTree.cpp:
1571         (dump):
1572
1573 2017-01-20  Antoine Quint  <graouts@apple.com>
1574
1575         [Modern Media Controls] Turn modern media controls on by default
1576         https://bugs.webkit.org/show_bug.cgi?id=165668
1577
1578         Reviewed by Dean Jackson.
1579
1580         Enabled modern media controls by default in test runners.
1581
1582         * DumpRenderTree/TestOptions.h:
1583         * WebKitTestRunner/TestOptions.h:
1584
1585 2017-01-19  Chris Dumez  <cdumez@apple.com>
1586
1587         iterable<> should be enabled on WK1
1588         https://bugs.webkit.org/show_bug.cgi?id=167221
1589         <rdar://problem/30108531>
1590
1591         Reviewed by Youenn Fablet.
1592
1593         * DumpRenderTree/mac/DumpRenderTree.mm:
1594         (resetWebPreferencesToConsistentValues):
1595         * DumpRenderTree/win/DumpRenderTree.cpp:
1596         (resetWebPreferencesToConsistentValues):
1597         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
1598         (WTR::InjectedBundle::beginTesting):
1599         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1600         (WTR::TestRunner::setDOMIteratorEnabled): Deleted.
1601         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1602
1603 2017-01-19  Aakash Jain  <aakash_jain@apple.com>
1604
1605         Ensure status server logs go to log file
1606         https://bugs.webkit.org/show_bug.cgi?id=167210
1607
1608         Reviewed by Alexey Proskuryakov.
1609
1610         * Scripts/webkitpy/common/net/statusserver.py:
1611         (StatusServer.next_work_item): Change log level from debug to info in
1612         order to facilitate deubgging issues.
1613         (StatusServer.update_work_items): Same.
1614
1615 2017-01-19  Megan Gardner  <megan_gardner@apple.com>
1616
1617         Additional selection tests and interpolation fix
1618         https://bugs.webkit.org/show_bug.cgi?id=167171
1619
1620         Reviewed by Simon Fraser.
1621
1622         We weren't adding the final event when interpolating event streams.
1623
1624         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1625         (-[HIDEventGenerator interpolatedEvents:]):
1626
1627 2017-01-19  Myles C. Maxfield  <mmaxfield@apple.com>
1628
1629         [Cocoa] Variation fonts are erroneously disabled on iOS
1630         https://bugs.webkit.org/show_bug.cgi?id=167172
1631
1632         Reviewed by Simon Fraser.
1633
1634         OpenSource builders don't seem to understand sdk=embedded*.
1635
1636         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1637
1638 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1639
1640         Unreviewed. Fix GTK+ unit tests failing since r210531.
1641
1642         Avoid using paths to files that don't actually exist.
1643
1644         * TestWebKitAPI/Tests/WebKit2Gtk/TestConsoleMessage.cpp:
1645         (testWebKitConsoleMessageNetworkError):
1646         * TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
1647         (testContextMenuDefaultMenu):
1648         * TestWebKitAPI/Tests/WebKit2Gtk/resources/silence.mpg: Added.
1649         * TestWebKitAPI/Tests/WebKit2Gtk/resources/simple.json: Added.
1650         * TestWebKitAPI/Tests/WebKit2Gtk/resources/tracks.ogg: Added.
1651
1652 2017-01-19  Carlos Garcia Campos  <cgarcia@igalia.com>
1653
1654         [GTK] Provide API to set proxy settings
1655         https://bugs.webkit.org/show_bug.cgi?id=128674
1656
1657         Reviewed by Michael Catanzaro.
1658
1659         Add tests for new proxy settings API.
1660
1661         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
1662         (serverCallback):
1663         (ProxyTest::ProxyTest):
1664         (ProxyTest::~ProxyTest):
1665         (ProxyTest::loadURIAndGetMainResourceData):
1666         (ProxyTest::proxyServerPortAsString):
1667         (testWebContextProxySettings):
1668         (beforeAll):
1669
1670 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1671
1672         Add back my old email address so old commits will still match it.
1673
1674         * Scripts/webkitpy/common/config/contributors.json:
1675
1676 2017-01-19  Timothy Hatcher  <timothy@hatcher.name>
1677
1678         Remove my old email address from contributors.json and watchlist.
1679
1680         * Scripts/validate-committer-lists:
1681         (CommitterListFromGit): Change the mapping to the correct email.
1682         * Scripts/webkitpy/common/config/contributors.json:
1683         * Scripts/webkitpy/common/config/watchlist:
1684
1685 2017-01-18  Ryan Haddad  <ryanhaddad@apple.com>
1686
1687         Unreviewed, rolling out r210848.
1688
1689         This change introduced media-related LayoutTest failures and
1690         crashes on macOS.
1691
1692         Reverted changeset:
1693
1694         "[Modern Media Controls] Turn modern media controls on by
1695         default"
1696         https://bugs.webkit.org/show_bug.cgi?id=165668
1697         http://trac.webkit.org/changeset/210848
1698
1699 2017-01-18  Andreas Kling  <akling@apple.com>
1700
1701         Document::securityOrigin() should return a reference.
1702         <https://webkit.org/b/167124>
1703
1704         Reviewed by Sam Weinig.
1705
1706         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
1707         (TestWebKitAPI::TEST_F):
1708
1709 2017-01-18  Per Arne Vollan  <pvollan@apple.com>
1710
1711         [Win] Clipboard tests are flaky.
1712         https://bugs.webkit.org/show_bug.cgi?id=167088
1713
1714         Reviewed by Brent Fulgham.
1715
1716         Tests involving the clipboard are flaky when running with multiple DRTs, since the clipboard is global. 
1717         We can fix this by assigning each DRT a separate window station (each window station has its own clipboard).
1718
1719         * DumpRenderTree/win/DumpRenderTree.cpp:
1720         (main):
1721
1722 2017-01-18  Antoine Quint  <graouts@apple.com>
1723
1724         [Modern Media Controls] Turn modern media controls on by default
1725         https://bugs.webkit.org/show_bug.cgi?id=165668
1726
1727         Reviewed by Dean Jackson.
1728
1729         Enabled modern media controls by default in test runners. 
1730
1731         * DumpRenderTree/TestOptions.h:
1732         * WebKitTestRunner/TestOptions.h:
1733
1734 2017-01-17  Michael Catanzaro  <mcatanzaro@igalia.com>
1735
1736         Unreviewed, rolling out r210834
1737         https://bugs.webkit.org/show_bug.cgi?id=165668
1738
1739         It introduced dozens of test timeouts.
1740
1741         Reverted changeset:
1742         "[Modern Media Controls] Turn modern media controls on by default"
1743         https://bugs.webkit.org/show_bug.cgi?id=165668
1744         http://trac.webkit.org/changeset/210834
1745
1746 2017-01-17  Antoine Quint  <graouts@apple.com>
1747
1748         [Modern Media Controls] Turn modern media controls on by default
1749         https://bugs.webkit.org/show_bug.cgi?id=165668
1750
1751         Reviewed by Dean Jackson.
1752
1753         Enabled modern media controls by default in test runners. 
1754
1755         * DumpRenderTree/TestOptions.h:
1756         * WebKitTestRunner/TestOptions.h:
1757
1758 2017-01-17  Chris Dumez  <cdumez@apple.com>
1759
1760         Document title changed twice when setting document.title
1761         https://bugs.webkit.org/show_bug.cgi?id=167065
1762
1763         Reviewed by Darin Adler.
1764
1765         Add WebKit2GTK API test that was written by Michael Catanzaro.
1766
1767         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
1768         (testWebViewTitleChange):
1769         (beforeAll):
1770
1771 2017-01-17  Joseph Pecoraro  <pecoraro@apple.com>
1772
1773         ENABLE(USER_TIMING) Not Defined for Apple Windows or OS X Ports
1774         https://bugs.webkit.org/show_bug.cgi?id=116551
1775         <rdar://problem/13949830>
1776
1777         Reviewed by Alex Christensen.
1778
1779         * Scripts/webkitperl/FeatureList.pm:
1780         Remove stale RESOURCE_TIMING references which are now a runtime enabled feature
1781         that is part of the existing WEB_TIMING feature.
1782
1783         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1784
1785 2017-01-17  Jonathan Bedard  <jbedard@apple.com>
1786
1787         'webkit-patch post' no longer works with moved/copied files
1788         https://bugs.webkit.org/show_bug.cgi?id=166914
1789         <rdar://problem/29979707>
1790
1791         Reviewed by Daniel Bates.
1792
1793         SVN 1.9 has a bug where when a file has been moved or copied, the svn diff of the new
1794         file outputs only the "Index:" line with an empty body.  This workaround
1795         ignores such output from svn diff.  A issue has been filed with SVN, a link to the
1796         public email list tracking this bug is below.
1797         http://mail-archives.apache.org/mod_mbox/subversion-users/201701.mbox/%3cCF9BDE0A-7454-4405-8259-1120C6B76A03@apple.com%3e
1798         
1799
1800         * Scripts/svn-create-patch:
1801         (generateDiff): Ignore an "Index:" line with an empty body.
1802
1803 2017-01-16  Joseph Pecoraro  <pecoraro@apple.com>
1804
1805         Remove the REQUEST_ANIMATION_FRAME flag
1806         https://bugs.webkit.org/show_bug.cgi?id=156980
1807         <rdar://problem/25906849>
1808
1809         Reviewed by Simon Fraser.
1810
1811         * Scripts/webkitperl/FeatureList.pm:
1812         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1813
1814 2017-01-15  Sam Weinig  <sam@webkit.org>
1815
1816         Add the ability to use numbers in makeString()
1817         https://bugs.webkit.org/show_bug.cgi?id=167087
1818
1819         Reviewed by Darin Adler.
1820
1821         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1822         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Added.
1823         Add tests for StringConcatenate, focusing on new numeric additions.
1824
1825 2017-01-15  Michael Catanzaro  <mcatanzaro@igalia.com>
1826
1827         Unreviewed, remove stale comment.
1828
1829         This test was fixed by r163173.
1830
1831         * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
1832
1833 2017-01-14  Yusuke Suzuki  <utatane.tea@gmail.com>
1834
1835         Annotate large string tests with largeHeap
1836         https://bugs.webkit.org/show_bug.cgi?id=167054
1837
1838         Reviewed by Filip Pizlo.
1839
1840         * Scripts/run-javascriptcore-tests:
1841         * Scripts/run-jsc-stress-tests:
1842
1843 2017-01-14  Joseph Pecoraro  <pecoraro@apple.com>
1844
1845         Remove stale references to ENABLE_ES6_GENERATORS and ENABLE_PROMISES
1846         https://bugs.webkit.org/show_bug.cgi?id=167043
1847
1848         Reviewed by Darin Adler.
1849
1850         * Scripts/webkitperl/FeatureList.pm:
1851
1852 2017-01-13  Joseph Pecoraro  <pecoraro@apple.com>
1853
1854         Remove ENABLE(DETAILS_ELEMENT) guards
1855         https://bugs.webkit.org/show_bug.cgi?id=167042
1856
1857         Reviewed by Alex Christensen.
1858
1859         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1860
1861 2017-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
1862
1863         26 MotionMark performance tests failing
1864         https://bugs.webkit.org/show_bug.cgi?id=166854
1865
1866         Reviewed by Ryosuke Niwa.
1867
1868         Unrelated change. This is the last place that we need to rename Animometer
1869         to MotionMark.
1870
1871         * Scripts/webkitpy/common/config/watchlist:
1872
1873 2017-01-13  Yusuke Suzuki  <utatane.tea@gmail.com>
1874
1875         run-jsc-benchmarks' echo should have -e option
1876         https://bugs.webkit.org/show_bug.cgi?id=167009
1877
1878         Reviewed by Sam Weinig.
1879
1880         echo requires `-e` option to use escape sequence.
1881         Without it, in some environment (in my Fedora 25), the escape sequence is not
1882         recognized and just dumped as `\c` etc.
1883
1884         * Scripts/run-jsc-benchmarks:
1885
1886 2017-01-12  Chris Dumez  <cdumez@apple.com>
1887
1888         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1889         https://bugs.webkit.org/show_bug.cgi?id=166995
1890
1891         Reviewed by Jer Noble.
1892
1893         Add KEYBOARD_KEY_ATTRIBUTE / KEYBOARD_CODE_ATTRIBUTE to FeatureDefines.xcconfig
1894         as some people are having trouble building without it.
1895
1896         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
1897
1898 2017-01-12  Sam Weinig  <sam@webkit.org>
1899
1900         Add the ability to filter the set of bindings tests you want to run
1901         https://bugs.webkit.org/show_bug.cgi?id=166977
1902
1903         Reviewed by Tim Horton.
1904
1905         Allows doing things like:
1906             run-bindings-tests TestObj* TestCEReactions*
1907         
1908         to run only those tests that match the patterns.
1909
1910         * Scripts/run-bindings-tests:
1911         (main):
1912         Switch to using optparse and pass the remaining args as the filters.
1913
1914         * Scripts/webkitpy/bindings/main.py:
1915         (BindingsTests.__init__):
1916         Store the pattens.
1917
1918         (BindingsTests.test_matches_patterns):
1919         Add helper predicate to determine if a test should be run. When no
1920         patterns are present, all tests should run.
1921
1922         (BindingsTests.run_tests):
1923         Filter tests using the passed in patterns.
1924
1925 2017-01-12  Per Arne Vollan  <pvollan@apple.com>
1926
1927         Followup fix after r210503.
1928         https://bugs.webkit.org/show_bug.cgi?id=166887
1929
1930         Reviewed by Alex Christensen.
1931
1932         After <http://trac.webkit.org/changeset/210503>, test results are written to a
1933         duplicated file handle on Windows. This patch fixes the remaining call sites.
1934
1935         * DumpRenderTree/PixelDumpSupport.cpp:
1936         * DumpRenderTree/TestRunner.cpp:
1937         (TestRunner::waitToDumpWatchdogTimerFired):
1938         * DumpRenderTree/TestRunner.h:
1939         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
1940         * DumpRenderTree/win/DumpRenderTree.cpp:
1941         * DumpRenderTree/win/DumpRenderTreeWin.h:
1942         * DumpRenderTree/win/TestRunnerWin.cpp:
1943         (TestRunner::setSpellCheckerLoggingEnabled):
1944
1945 2017-01-11  Megan Gardner  <megan_gardner@apple.com>
1946
1947         Add committer status for Megan
1948         https://bugs.webkit.org/show_bug.cgi?id=166954
1949
1950         Reviewed by Tim Horton.
1951
1952         Add committer status for Megan Gardner
1953
1954         * Scripts/webkitpy/common/config/contributors.json:
1955
1956 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1957
1958         Unreviewed test fix after r210599.
1959
1960         * TestWebKitAPI/Tests/WebKit2/WKPageIsPlayingAudio.cpp:
1961         (TestWebKitAPI::TEST): Remove debugging code that was causing a timeout.
1962
1963 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1964
1965         Unreviewed build fix after r210599.
1966
1967         Add missing files.
1968
1969         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1970         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1971
1972 2017-01-11  Brent Fulgham  <bfulgham@apple.com>
1973
1974         File scheme should not allow access of a resource on a different volume.
1975         https://bugs.webkit.org/show_bug.cgi?id=158552
1976         <rdar://problem/15307582>
1977
1978         Reviewed by Alex Christensen.
1979
1980         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
1981         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
1982         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
1983
1984 2017-01-11  Ryan Haddad  <ryanhaddad@apple.com>
1985
1986         Unreviewed, rolling out r210571.
1987
1988         This change broke the 32-bit macOS build and caused LayoutTest
1989         failures.
1990
1991         Reverted changeset:
1992
1993         "File scheme should not allow access of a resource on a
1994         different volume."
1995         https://bugs.webkit.org/show_bug.cgi?id=158552
1996         http://trac.webkit.org/changeset/210571
1997
1998 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
1999
2000         [GTK] install-dependencies script misses gdb
2001         https://bugs.webkit.org/show_bug.cgi?id=166917
2002
2003         Reviewed by Michael Catanzaro.
2004
2005         gdb is needed for generating the crash logs.
2006
2007         * gtk/install-dependencies:
2008
2009 2017-01-10  Michael Catanzaro  <mcatanzaro@igalia.com>
2010
2011         [GTK] No way for applications to set notification permissions without waiting for permission request
2012         https://bugs.webkit.org/show_bug.cgi?id=163366
2013
2014         Reviewed by Carlos Garcia Campos.
2015
2016         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
2017         (testWebViewNotification):
2018         (setInitialNotificationPermissionsAllowedCallback):
2019         (setInitialNotificationPermissionsDisallowedCallback):
2020         (testWebViewNotificationInitialPermissionAllowed):
2021         (testWebViewNotificationInitialPermissionDisallowed):
2022         (beforeAll):
2023         * TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
2024         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
2025         (WebViewTest::WebViewTest):
2026         (WebViewTest::initializeWebView):
2027         * TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
2028
2029 2017-01-10  Tim Horton  <timothy_horton@apple.com>
2030
2031         MobileMiniBrowser tests don't work by default
2032         https://bugs.webkit.org/show_bug.cgi?id=166910
2033
2034         Reviewed by Alex Christensen.
2035
2036         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/xcshareddata/xcschemes/MobileMiniBrowserUITests.xcscheme: Added.
2037         Add a shared scheme; the Makefile depends on the MobileMiniBrowserUITests scheme existing, at the very least.
2038
2039 2017-01-10  Brent Fulgham  <bfulgham@apple.com>
2040
2041         File scheme should not allow access of a resource on a different volume.
2042         https://bugs.webkit.org/show_bug.cgi?id=158552
2043         <rdar://problem/15307582>
2044
2045         Reviewed by Alex Christensen.
2046
2047         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2048         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2049         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2050
2051 2017-01-10  Mark Lam  <mark.lam@apple.com>
2052
2053         Reverting run-jsc-stress-tests' $buildType to use string values.
2054         https://bugs.webkit.org/show_bug.cgi?id=166912
2055
2056         Rubber stamped by Filip Pizlo.
2057
2058         This is so that we can test for it in the tests e.g.
2059         //@ if $buildType == "debug" then runDefault("--maxSingleAllocationSize=1048576") else skip end
2060
2061         * Scripts/run-jsc-stress-tests:
2062
2063 2017-01-10  Ryosuke Niwa  <rniwa@webkit.org>
2064
2065         Temporarily add back the file removed in r210463 to unbreak internal bots.
2066
2067         * Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch: Copied from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2068
2069 2017-01-10  Jonathan Bedard  <jbedard@apple.com>
2070
2071         svn-apply failed to apply a patch (deleting file with svn property)
2072         https://bugs.webkit.org/show_bug.cgi?id=165953
2073
2074         Reviewed by Daniel Bates.
2075
2076         * Scripts/VCSUtils.pm:
2077         (parseSvnPropertyValue): The beginning of a diff will cause an early exit in the case of no empty newlines.
2078         * Scripts/webkitperl/VCSUtils_unittest/parseSvnProperty.pl: Add tests without break between diffs for properties.
2079
2080 2017-01-10  Ryan Haddad  <ryanhaddad@apple.com>
2081
2082         Update flakiness dashboard configuration.
2083         https://bugs.webkit.org/show_bug.cgi?id=166869
2084
2085         Reviewed by Alexey Proskuryakov.
2086
2087         * TestResultServer/static-dashboards/builders.jsonp:
2088         * TestResultServer/static-dashboards/flakiness_dashboard.js:
2089
2090 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2091
2092         [GTK] Stop honoring the environment variable USE_NATIVE_XDISPLAY
2093         https://bugs.webkit.org/show_bug.cgi?id=165232
2094
2095         Unreviewed follow-up patch after r210539 and r210523.
2096
2097         Instead of using that environment variable, the argument
2098         --display-server=xorg should be passed now.
2099
2100         The GTK+ performance bot was the only bot using this, and is
2101         already passing --display-server=xorg after r210539.
2102
2103         * Scripts/webkitpy/port/gtk.py:
2104         (GtkPort._driver_class):
2105
2106 2017-01-10  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2107
2108         [GTK] Add a new release test bot for Wayland and pass --display-server=xorg to the GTK Perf bot.
2109         https://bugs.webkit.org/show_bug.cgi?id=166872
2110
2111         Reviewed by Michael Catanzaro.
2112
2113         Add the new wayland release test bot as a test-only bot. It will download the built product from the release build-only bot.
2114         Define the required "--display-server=driver" in the bot additionalArguments config entry.
2115         Implement support for honoring additionalArguments on the RunGtkAPITests and RunAndUploadPerfTests steps.
2116         The step RunWebKitTests already has support for it.
2117
2118         * BuildSlaveSupport/build.webkit.org-config/config.json:
2119         * BuildSlaveSupport/build.webkit.org-config/master.cfg:
2120         (RunGtkAPITests.start):
2121         (RunAndUploadPerfTests.start):
2122         * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
2123
2124 2017-01-09  Ryan Haddad  <ryanhaddad@apple.com>
2125
2126         Unreviewed, rolling out r210531.
2127
2128         This change broke the 32-bit macOS build and caused LayoutTest
2129         failures.
2130
2131         Reverted changeset:
2132
2133         "File scheme should not allow access of a resource on a
2134         different volume."
2135         https://bugs.webkit.org/show_bug.cgi?id=158552
2136         http://trac.webkit.org/changeset/210531
2137
2138 2017-01-09  Brent Fulgham  <bfulgham@apple.com>
2139
2140         File scheme should not allow access of a resource on a different volume.
2141         https://bugs.webkit.org/show_bug.cgi?id=158552
2142         <rdar://problem/15307582>
2143
2144         Reviewed by Alex Christensen.
2145
2146         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
2147         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.html: Added.
2148         * TestWebKitAPI/Tests/mac/CrossPartitionFileSchemeAccess.mm: Added.
2149
2150 2017-01-09  Carlos Alberto Lopez Perez  <clopez@igalia.com>
2151
2152         [GTK][Wayland] Allow running the layout tests under a native Wayland environment.
2153         https://bugs.webkit.org/show_bug.cgi?id=165232
2154
2155         Reviewed by Michael Catanzaro.
2156
2157         Add a new WaylandDriver to run the tests in the user current wayland session.
2158
2159         Also merge all the configuration options for selecting the display server inside one
2160         switch --display-server=xvfb/xorg/wayland/weston (defaulting to xvfb).
2161
2162         This switch is supported on the scripts: run-gtk-tests, run-perf-tests and run-webkit-tests.
2163
2164         * Scripts/run-gtk-tests: Add missing logging.basicConfig() initialization for the error logger.
2165         (TestRunner._create_driver):
2166         * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2167         (parse_args):
2168         * Scripts/webkitpy/performance_tests/perftestsrunner.py:
2169         (PerfTestsRunner._parse_args):
2170         * Scripts/webkitpy/port/gtk.py:
2171         (GtkPort.__init__):
2172         (GtkPort._driver_class):
2173         (GtkPort._search_paths):
2174         * Scripts/webkitpy/port/waylanddriver.py: Added.
2175         (WaylandDriver):
2176         (WaylandDriver.check_driver):
2177         (WaylandDriver._setup_environ_for_test):
2178         (WaylandDriver._start):
2179
2180 2017-01-09  Andy Estes  <aestes@apple.com>
2181
2182         [QuickLook] Add a layout test for webkit.org/b/135651
2183         https://bugs.webkit.org/show_bug.cgi?id=166855
2184
2185         Reviewed by Andreas Kling.
2186
2187         * DumpRenderTree/mac/FrameLoadDelegate.mm:
2188         (-[FrameLoadDelegate webView:didFailProvisionalLoadWithError:forFrame:]): Added output for
2189         errors with code WebKitErrorCannotShowURL.
2190         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2191         (WTR::InjectedBundlePage::didFailProvisionalLoadWithErrorForFrame): Made the error output
2192         not specific to WebKit2 error codes.
2193
2194 2017-01-09  Antoine Quint  <graouts@apple.com>
2195
2196         Support webkit-test-runner key-value pairs in http tests in DumpRenderTree
2197         https://bugs.webkit.org/show_bug.cgi?id=166837
2198
2199         Reviewed by Alex Christensen.
2200
2201         We now correctly handle the --absolutePath argument in DumpRenderTree and use
2202         the provided value when trying to determine the path to the test file. Failing
2203         that, we use the computed URL or the raw path provided to cover all cases.
2204         
2205         This was tested in the context of https://bugs.webkit.org/show_bug.cgi?id=165668
2206         by applying this patch and seeing the number test failures dramatically reduced
2207         with WK1 due to the option to turn modern media controls off for older media controls
2208         tests.
2209
2210         * DumpRenderTree/DumpRenderTree.h:
2211         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2212         (parseInputLine):
2213         * DumpRenderTree/TestOptions.h:
2214         * DumpRenderTree/TestOptions.mm:
2215         (TestOptions::TestOptions):
2216         * DumpRenderTree/mac/DumpRenderTree.mm:
2217         (runTest):
2218
2219 2017-01-09  Milan Crha  <mcrha@redhat.com>
2220
2221         prepare-ChangeLog: Correct help string for --style option
2222         https://bugs.webkit.org/show_bug.cgi?id=166725
2223
2224         Reviewed by Alexey Proskuryakov.
2225
2226         * Scripts/prepare-ChangeLog:
2227         (main):
2228
2229 2017-01-09  Lucas Forschler  <lforschler@apple.com>
2230
2231         https://bugs.webkit.org/show_bug.cgi?id=166839
2232         Add php7 support for macOS.
2233         Mirror the debian logic to look for a php7 module on disk, and return the appropriate apache config file.
2234
2235         Reviewed by Alexey Proskuryakov.
2236
2237         * Scripts/webkitpy/port/base.py:
2238         (Port._is_darwin_php_version_7):
2239         (Port._debian_php_version):
2240         (Port):
2241         (Port._darwin_php_version):
2242         (Port._apache_config_file_name_for_platform):
2243
2244 2017-01-06  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>
2245
2246         [GTK] Should support key and code properties on keyboard events
2247         https://bugs.webkit.org/show_bug.cgi?id=166759
2248
2249         Reviewed by Carlos Garcia Campos.
2250
2251         * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
2252         (WTR::getGDKKeySymForKeyRef): add missing modifier keys which were being reported as 'l' and 'r' only
2253         on tests.
2254
2255 2017-01-06  Per Arne Vollan  <pvollan@apple.com>
2256
2257         [Win] Some tests are flaky because certain DLLs are writing to stdout.
2258         https://bugs.webkit.org/show_bug.cgi?id=166760
2259
2260         Reviewed by Darin Adler.
2261
2262         Some tests are flaky because certain DLLs are writing to stdout, giving incorrect test results.
2263         We can work around that by duplicating and redirecting stdout.
2264
2265         * DumpRenderTree/PixelDumpSupport.cpp:
2266         (dumpWebViewAsPixelsAndCompareWithExpected):
2267         (printPNG):
2268         * DumpRenderTree/win/AccessibilityControllerWin.cpp:
2269         (logEventProc):
2270         * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
2271         (DRTDesktopNotificationPresenter::showDesktopNotification):
2272         (DRTDesktopNotificationPresenter::cancelDesktopNotification):
2273         (DRTDesktopNotificationPresenter::requestNotificationPermission):
2274         * DumpRenderTree/win/DumpRenderTree.cpp:
2275         (dumpFrameScrollPosition):
2276         (dumpHistoryItem):
2277         (dumpBackForwardList):
2278         (dump):
2279         (runTest):
2280         (main):
2281         * DumpRenderTree/win/DumpRenderTreeWin.h:
2282         * DumpRenderTree/win/EditingDelegate.cpp:
2283         (EditingDelegate::shouldBeginEditingInDOMRange):
2284         (EditingDelegate::shouldEndEditingInDOMRange):
2285         (EditingDelegate::shouldInsertNode):
2286         (EditingDelegate::shouldInsertText):
2287         (EditingDelegate::shouldDeleteDOMRange):
2288         (EditingDelegate::shouldChangeSelectedDOMRange):
2289         (EditingDelegate::shouldApplyStyle):
2290         (EditingDelegate::shouldChangeTypingStyle):
2291         (EditingDelegate::doPlatformCommand):
2292         (EditingDelegate::webViewDidBeginEditing):
2293         (EditingDelegate::webViewDidChange):
2294         (EditingDelegate::webViewDidEndEditing):
2295         (EditingDelegate::webViewDidChangeTypingStyle):
2296         (EditingDelegate::webViewDidChangeSelection):
2297         * DumpRenderTree/win/FrameLoadDelegate.cpp:
2298         (FrameLoadDelegate::didStartProvisionalLoadForFrame):
2299         (FrameLoadDelegate::didReceiveServerRedirectForProvisionalLoadForFrame):
2300         (FrameLoadDelegate::didChangeLocationWithinPageForFrame):
2301         (FrameLoadDelegate::didFailProvisionalLoadWithError):
2302         (FrameLoadDelegate::didCommitLoadForFrame):
2303         (FrameLoadDelegate::didReceiveTitle):
2304         (FrameLoadDelegate::didFinishLoadForFrame):
2305         (FrameLoadDelegate::didFailLoadWithError):
2306         (FrameLoadDelegate::willPerformClientRedirectToURL):
2307         (FrameLoadDelegate::didCancelClientRedirectForFrame):
2308         (FrameLoadDelegate::windowScriptObjectAvailable):
2309         (FrameLoadDelegate::didFinishDocumentLoadForFrame):
2310         (FrameLoadDelegate::didHandleOnloadEventsForFrame):
2311         (FrameLoadDelegate::didDisplayInsecureContent):
2312         (FrameLoadDelegate::didRunInsecureContent):
2313         (FrameLoadDelegate::webViewProgressFinishedNotification):
2314         * DumpRenderTree/win/HistoryDelegate.cpp:
2315         (HistoryDelegate::didNavigateWithNavigationData):
2316         (HistoryDelegate::didPerformClientRedirectFromURL):
2317         (HistoryDelegate::didPerformServerRedirectFromURL):
2318         (HistoryDelegate::updateHistoryTitle):
2319         (HistoryDelegate::populateVisitedLinksForWebView):
2320         * DumpRenderTree/win/PolicyDelegate.cpp:
2321         (PolicyDelegate::decidePolicyForNavigationAction):
2322         (PolicyDelegate::unableToImplementPolicyWithError):
2323         * DumpRenderTree/win/ResourceLoadDelegate.cpp:
2324         (ResourceLoadDelegate::willSendRequest):
2325         (ResourceLoadDelegate::didReceiveAuthenticationChallenge):
2326         (ResourceLoadDelegate::didReceiveResponse):
2327         (ResourceLoadDelegate::didFinishLoadingFromDataSource):
2328         (ResourceLoadDelegate::didFailLoadingWithError):
2329         * DumpRenderTree/win/TestRunnerWin.cpp:
2330         (TestRunner::addDisallowedURL):
2331         (TestRunner::originsWithApplicationCache):
2332         (TestRunner::setStorageDatabaseIdleInterval):
2333         (TestRunner::closeIdleLocalStorageDatabases):
2334         (TestRunner::copyDecodedHostName):
2335         (TestRunner::copyEncodedHostName):
2336         (TestRunner::numberOfPendingGeolocationPermissionRequests):
2337         (TestRunner::isGeolocationProviderActive):
2338         (TestRunner::pathToLocalResource):
2339         (TestRunner::setMockDeviceOrientation):
2340         (TestRunner::setMockGeolocationPosition):
2341         (TestRunner::setMockGeolocationPositionUnavailableError):
2342         (TestRunner::setSpatialNavigationEnabled):
2343         (TestRunner::setAutomaticLinkDetectionEnabled):
2344         (TestRunner::isCommandEnabled):
2345         (TestRunner::authenticateSession):
2346         (TestRunner::addChromeInputField):
2347         (TestRunner::removeChromeInputField):
2348         (TestRunner::focusWebView):
2349         (TestRunner::grantWebNotificationPermission):
2350         (TestRunner::denyWebNotificationPermission):
2351         (TestRunner::removeAllWebNotificationPermissions):
2352         (TestRunner::simulateWebNotificationClick):
2353         (TestRunner::imageCountInGeneralPasteboard):
2354         * DumpRenderTree/win/UIDelegate.cpp:
2355         (UIDelegate::runJavaScriptAlertPanelWithMessage):
2356         (UIDelegate::runJavaScriptConfirmPanelWithMessage):
2357         (UIDelegate::runJavaScriptTextInputPanelWithPrompt):
2358         (UIDelegate::runBeforeUnloadConfirmPanelWithMessage):
2359         (UIDelegate::webViewAddMessageToConsole):
2360         (UIDelegate::exceededDatabaseQuota):
2361         (UIDelegate::setStatusText):
2362         (UIDelegate::didPressMissingPluginButton):
2363
2364 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2365
2366         Add a setting to create editable MiniBrowser windows by default
2367         https://bugs.webkit.org/show_bug.cgi?id=166806
2368
2369         Reviewed by Beth Dakin.
2370
2371         * MiniBrowser/mac/AppDelegate.m:
2372         (-[BrowserAppDelegate createBrowserWindowController:]):
2373         (-[BrowserAppDelegate applicationDidFinishLaunching:]):
2374         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2375         * MiniBrowser/mac/SettingsController.h:
2376         * MiniBrowser/mac/SettingsController.m:
2377         (-[SettingsController _populateMenu]):
2378         (-[SettingsController validateMenuItem:]):
2379         (-[SettingsController toggleCreateEditorByDefault:]):
2380         (-[SettingsController createEditorByDefault]):
2381         Add a setting and update the key equivalents accordingly.
2382         Also make sure to make the right kind of window on launch.
2383
2384 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2385
2386         Fix the 32-bit build.
2387
2388         * MiniBrowser/mac/BrowserWindowController.h:
2389         * MiniBrowser/mac/BrowserWindowController.m:
2390
2391 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2392
2393         Fix the 32-bit build.
2394
2395         * MiniBrowser/mac/BrowserWindowController.m:
2396
2397 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2398
2399         Make it possible to drop HTML files on the MiniBrowser icon
2400         https://bugs.webkit.org/show_bug.cgi?id=166802
2401
2402         Reviewed by Simon Fraser.
2403
2404         * MiniBrowser/mac/AppDelegate.m:
2405         (-[BrowserAppDelegate application:openFile:]):
2406         * MiniBrowser/mac/Info.plist:
2407         If you're using an editable window, the usual trick of dropping on the
2408         window doesn't work anymore (it makes an <attachment> instead).
2409
2410 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2411
2412         MiniBrowser window gets smaller each time it is instantiated
2413         https://bugs.webkit.org/show_bug.cgi?id=166807
2414
2415         Reviewed by Andy Estes.
2416
2417         * MiniBrowser/mac/BrowserWindowController.m:
2418         (-[BrowserWindowController windowDidLoad]):
2419         * MiniBrowser/mac/BrowserWindow.xib:
2420         Turn on full-window content view support with IB, instead of waiting
2421         until after the views have been loaded. This seems to resolve the
2422         longstanding ever-shrinking-window problem.
2423
2424 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2425
2426         Add indent/outdent items to MiniBrowser's new format menu
2427         https://bugs.webkit.org/show_bug.cgi?id=166805
2428
2429         Reviewed by Dan Bernstein.
2430
2431         * MiniBrowser/mac/MainMenu.xib:
2432
2433 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2434
2435         Add a stock Format menu to MiniBrowser
2436         https://bugs.webkit.org/show_bug.cgi?id=166804
2437
2438         Reviewed by Andy Estes.
2439
2440         * MiniBrowser/mac/MainMenu.xib:
2441         Many of the features automatically work with editable web views.
2442         However, this seems to expose a bug where none of the font-related features
2443         (Cmd-B, for example) work until the first time the font panel is shown,
2444         per process, which will need to be investigated separately.
2445
2446 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2447
2448         Remove unused applicationWillTerminate methods from MiniBrowser
2449         https://bugs.webkit.org/show_bug.cgi?id=166803
2450
2451         Reviewed by Andy Estes.
2452
2453         * MiniBrowser/mac/AppDelegate.m:
2454         (-[BrowserAppDelegate applicationWillTerminate:]): Deleted.
2455         * MiniBrowser/mac/BrowserWindowController.h:
2456         * MiniBrowser/mac/BrowserWindowController.m:
2457         (-[BrowserWindowController applicationTerminating]): Deleted.
2458         * MiniBrowser/mac/WK1BrowserWindowController.m:
2459         (-[WK1BrowserWindowController applicationTerminating]): Deleted.
2460         * MiniBrowser/mac/WK2BrowserWindowController.m:
2461         (-[WK2BrowserWindowController applicationTerminating]): Deleted.
2462
2463 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2464
2465         Add the ability to create empty contentEditable windows in MiniBrowser
2466         https://bugs.webkit.org/show_bug.cgi?id=166801
2467
2468         Reviewed by Wenson Hsieh.
2469
2470         * MiniBrowser/mac/AppDelegate.h:
2471         * MiniBrowser/mac/AppDelegate.m:
2472         (-[BrowserAppDelegate createBrowserWindowController:]):
2473         (-[BrowserAppDelegate newWindow:]):
2474         (-[BrowserAppDelegate newEditorWindow:]):
2475         (-[BrowserAppDelegate openDocument:]):
2476         (-[BrowserAppDelegate _updateNewWindowKeyEquivalents]):
2477         * MiniBrowser/mac/BrowserWindowController.h:
2478         * MiniBrowser/mac/BrowserWindowController.m:
2479         (-[BrowserWindowController loadHTMLString:]):
2480         (-[BrowserWindowController toggleEditable:]):
2481         * MiniBrowser/mac/MainMenu.xib:
2482         * MiniBrowser/mac/WK1BrowserWindowController.m:
2483         (-[WK1BrowserWindowController awakeFromNib]):
2484         (-[WK1BrowserWindowController loadHTMLString:]):
2485         (-[WK1BrowserWindowController validateMenuItem:]):
2486         (-[WK1BrowserWindowController setEditable:]):
2487         (-[WK1BrowserWindowController updateTitle:]):
2488         * MiniBrowser/mac/WK2BrowserWindowController.m:
2489         (-[WK2BrowserWindowController awakeFromNib]):
2490         (-[WK2BrowserWindowController validateMenuItem:]):
2491         (-[WK2BrowserWindowController setEditable:]):
2492         (-[WK2BrowserWindowController updateTitle:]):
2493         (-[WK2BrowserWindowController loadHTMLString:]):
2494         Merge more functionality from WebEditingTester.
2495         Add two menu items for creating empty editable WebKit1/2 windows.
2496         Add a menu item to the Edit menu to toggle editability on any window.
2497
2498 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2499
2500         Implement find-in-page in MiniBrowser
2501         https://bugs.webkit.org/show_bug.cgi?id=166799
2502
2503         Reviewed by Andy Estes.
2504
2505         * MiniBrowser/mac/BrowserWindow.xib:
2506         * MiniBrowser/mac/BrowserWindowController.h:
2507         * MiniBrowser/mac/BrowserWindowController.m:
2508         (-[BrowserWindowController find:]): Deleted.
2509         * MiniBrowser/mac/MainMenu.xib:
2510         * MiniBrowser/mac/WK1BrowserWindowController.m:
2511         (-[WK1BrowserWindowController toggleShrinkToFit:]):
2512         (-[WK1BrowserWindowController find:]): Deleted.
2513         * MiniBrowser/mac/WK2BrowserWindowController.m:
2514         (-[WK2BrowserWindowController awakeFromNib]):
2515         (-[WK2BrowserWindowController dealloc]):
2516         (-[WK2BrowserWindowController validateMenuItem:]):
2517         (-[WK2BrowserWindowController performTextFinderAction:]):
2518         (-[WK2BrowserWindowController findBarView]):
2519         (-[WK2BrowserWindowController setFindBarView:]):
2520         (-[WK2BrowserWindowController isFindBarVisible]):
2521         (-[WK2BrowserWindowController setFindBarVisible:]):
2522         (-[WK2BrowserWindowController contentView]):
2523         (-[WK2BrowserWindowController findBarViewDidChangeHeight]):
2524         (-[WK2BrowserWindowController performFindPanelAction:]): Deleted.
2525         (-[WK2BrowserWindowController find:]): Deleted.
2526         Implement find-in-page using WKWebView's conformance to the NSTextFinderClient
2527         protocol. At first glance, it's pretty broken, but vaguely works.
2528
2529 2017-01-07  Tim Horton  <timothy_horton@apple.com>
2530
2531         Share the implementation of MiniBrowser view hiding functionality
2532         https://bugs.webkit.org/show_bug.cgi?id=166800
2533
2534         Reviewed by Andy Estes.
2535
2536         * MiniBrowser/mac/BrowserWindowController.m:
2537         (-[BrowserWindowController showHideWebView:]):
2538         (-[BrowserWindowController removeReinsertWebView:]):
2539         * MiniBrowser/mac/WK1BrowserWindowController.m:
2540         (-[WK1BrowserWindowController showHideWebView:]): Deleted.
2541         (-[WK1BrowserWindowController removeReinsertWebView:]): Deleted.
2542         * MiniBrowser/mac/WK2BrowserWindowController.m:
2543         (-[WK2BrowserWindowController showHideWebView:]): Deleted.
2544         (-[WK2BrowserWindowController removeReinsertWebView:]): Deleted.
2545         Move the implementation of these two things to the shared superclass,
2546         since they don't depend on WebKit-specific things.
2547         Also, there was no reason to retain the (WK)WebView while it was unparented,
2548         as the BrowserWindowController maintains a reference the entire time.
2549
2550 2017-01-06  Andy Estes  <aestes@apple.com>
2551
2552         [Cocoa] Consolidate duplicate copies of WebArchiveDumpSupport in DRT and WKTR into WebCoreTestSupport
2553         https://bugs.webkit.org/show_bug.cgi?id=166789
2554
2555         Reviewed by Alex Christensen.
2556
2557         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2558         * DumpRenderTree/PlatformMac.cmake:
2559         * DumpRenderTree/cf/WebArchiveDumpSupport.cpp: Removed.
2560         * DumpRenderTree/cf/WebArchiveDumpSupport.h: Removed.
2561         * DumpRenderTree/mac/DumpRenderTree.mm:
2562         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2563         createXMLStringFromWebArchiveData().
2564         * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm: Removed.
2565         * WebKitTestRunner/Configurations/Base.xcconfig:
2566         Added $(BUILT_PRODUCTS_DIR)/WebCoreTestSupport to HEADER_SEARCH_PATHS.
2567         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2568         (WTR::InjectedBundlePage::dumpDOMAsWebArchive):
2569         Called WebCoreTestSupport::createXMLStringFromWebArchiveData() instead of
2570         createXMLStringFromWebArchiveData().
2571         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Removed.
2572         * WebKitTestRunner/PlatformMac.cmake:
2573         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
2574         * WebKitTestRunner/cf/WebArchiveDumpSupport.h: Removed.
2575
2576 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2577
2578         Minor cleanups to IndentOutdentCommand and related code
2579         https://bugs.webkit.org/show_bug.cgi?id=166791
2580
2581         Reviewed by Simon Fraser.
2582
2583         * WebEditingTester/EditingOperations.m:
2584         (editingOperations):
2585         Add the outdent operation to WebEditingTester.
2586
2587 2017-01-06  Said Abou-Hallawa  <sabouhallawa@apple.com>
2588
2589         Create a plan and a patch files for MotionMark and delete the Animometer's ones
2590         https://bugs.webkit.org/show_bug.cgi?id=166785
2591
2592         Reviewed by Ryosuke Niwa.
2593
2594         * Scripts/webkitpy/benchmark_runner/data/patches/MotionMark.patch: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/patches/Animometer.patch.
2595         * Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan: Renamed from Tools/Scripts/webkitpy/benchmark_runner/data/plans/animometer.plan.
2596
2597 2017-01-06  Antoine Quint  <graouts@apple.com>
2598
2599         Support webkit-test-runner key-value pairs in http tests
2600         https://bugs.webkit.org/show_bug.cgi?id=149812
2601
2602         Reviewed by Alex Christensen.
2603
2604         We pass the absolute path for a test through to WKTR so that we can parse
2605         tests that are running as URLs for webkit-test-runner options.
2606
2607         * DumpRenderTree/DumpRenderTreeCommon.cpp:
2608         (parseInputLine):
2609
2610         Explicitly skip the --absolute-path option in DRT or else we'd crash.
2611
2612         * Scripts/webkitpy/port/driver.py:
2613         (Driver._command_from_driver_input):
2614
2615         Pass the absolute path to the file through the CLI.
2616
2617         * WebKitTestRunner/TestController.cpp:
2618         (WTR::updateTestOptionsFromTestHeader):
2619         (WTR::TestController::testOptionsForTest):
2620         (WTR::parseInputLine):
2621         (WTR::TestController::runTest):
2622         * WebKitTestRunner/TestController.h:
2623
2624 2017-01-06  Tim Horton  <timothy_horton@apple.com>
2625
2626         Warning about unconnectable outlets when opening a MiniBrowser window
2627         https://bugs.webkit.org/show_bug.cgi?id=166756
2628
2629         Reviewed by Dan Bernstein.
2630
2631         * MiniBrowser/mac/BrowserWindow.xib:
2632         When launching MiniBrowser, it says:
2633         Failed to connect (Share) outlet from (WK1BrowserWindowController) to
2634             (MBToolbarItem): missing setter or instance variable
2635         Failed to connect (shareButton) outlet from (WK1BrowserWindowController) to
2636             (NSButtonCell): missing setter or instance variable.
2637
2638         It looks like someone added the connection from the share button
2639         to the BrowserWindowController three times; only one of the connections
2640         is valid. Remove the other two.
2641
2642 2017-01-05  Keith Rollin  <krollin@apple.com>
2643
2644         Add WebCore::URL::protocolHostAndPort
2645         https://bugs.webkit.org/show_bug.cgi?id=166426
2646
2647         Reviewed by Alex Christensen.
2648
2649         Add test for protocolHostAndPort.
2650
2651         * TestWebKitAPI/Tests/WebCore/URL.cpp:
2652         (TestWebKitAPI::TEST_F):
2653
2654 2017-01-05  Per Arne Vollan  <pvollan@apple.com>
2655
2656         [Win] Archive test result is failing.
2657         https://bugs.webkit.org/show_bug.cgi?id=166720
2658
2659         Reviewed by Alex Christensen.
2660
2661         Deleting the layout test result folder is sometimes failing
2662         on Windows. This is not a critical error.
2663
2664         * BuildSlaveSupport/test-result-archive:
2665         (archiveTestResults):
2666
2667 2017-01-04  Tomas Popela  <tpopela@redhat.com>
2668
2669         [GTK] Minibrowser: Add printing support
2670         https://bugs.webkit.org/show_bug.cgi?id=165298
2671
2672         Open a print dialog when the Ctrl + P shortcut is pressed. If there is
2673         an error during the print, it's printed on the console.
2674
2675         Reviewed by Michael Catanzaro.
2676
2677         * MiniBrowser/gtk/BrowserWindow.c:
2678         (webKitPrintOperationFailedCallback):
2679         (printPage):
2680         (browser_window_init):
2681
2682 2017-01-04  Manuel Rego Casasnovas  <rego@igalia.com>
2683
2684         [css-grid] Fix crash clamping grid lines
2685         https://bugs.webkit.org/show_bug.cgi?id=166637
2686
2687         Reviewed by Darin Adler.
2688
2689         Creates new unit test to verify that the maximum tracks limit
2690         is used in GridPosition too.
2691
2692         * TestWebKitAPI/PlatformEfl.cmake:
2693         * TestWebKitAPI/PlatformGTK.cmake:
2694         * TestWebKitAPI/PlatformWin.cmake:
2695         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2696         * TestWebKitAPI/Tests/WebCore/GridPosition.cpp: Added.
2697         (TestWebKitAPI::TEST):
2698
2699 2017-01-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2700
2701         Move editing history scripts to WebCore PrivateHeaders
2702         https://bugs.webkit.org/show_bug.cgi?id=166709
2703         <rdar://problem/29876612>
2704
2705         Reviewed by Dan Bernstein.
2706
2707         Update references to editing script files in WebCore that were moved.
2708
2709         * EditingHistory/EditingHistory.xcodeproj/project.pbxproj:
2710
2711 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2712
2713         Unreviewed, build fix after r210313 part 2
2714         https://bugs.webkit.org/show_bug.cgi?id=166676
2715
2716         Add 'U' suffix.
2717
2718         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2719         (TestWebKitAPI::TEST):
2720         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2721         (TestWebKitAPI::TEST):
2722
2723 2017-01-04  Yusuke Suzuki  <utatane.tea@gmail.com>
2724
2725         Limit thread name appropriately
2726         https://bugs.webkit.org/show_bug.cgi?id=166676
2727
2728         Reviewed by Sam Weinig.
2729
2730         * TestWebKitAPI/Tests/WTF/StringView.cpp:
2731         (TestWebKitAPI::TEST):
2732         * TestWebKitAPI/Tests/WTF/WTFString.cpp:
2733         (TestWebKitAPI::TEST):
2734
2735 2017-01-04  Andy Estes  <aestes@apple.com>
2736
2737         [Cocoa] Teach SharedBuffer to return an NSArray of data segments to avoid flattening
2738         https://bugs.webkit.org/show_bug.cgi?id=166696
2739
2740         Reviewed by Tim Horton.
2741
2742         * TestWebKitAPI/PlatformGTK.cmake:
2743         * TestWebKitAPI/PlatformWin.cmake:
2744         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2745         * TestWebKitAPI/Tests/WebCore/SharedBuffer.cpp: Moved class SharedBufferTest to SharedBufferTest.{cpp,h}.
2746         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.cpp: Moved class SharedBufferTest from SharedBuffer.cpp.
2747         * TestWebKitAPI/Tests/WebCore/SharedBufferTest.h: Ditto.
2748         * TestWebKitAPI/Tests/WebCore/cocoa/SharedBuffer.mm: Added.
2749         (TestWebKitAPI::expectDataArraysEqual): Added a helper to assert that two NSArrays of NSData are equal.
2750         (TestWebKitAPI::TEST_F): Added a test for createNSDataArray.
2751
2752 2017-01-03  Brian Burg  <bburg@apple.com>
2753
2754         Web Inspector: teach the protocol generator about platform-specific types, events, and commands
2755         https://bugs.webkit.org/show_bug.cgi?id=166003
2756         <rdar://problem/28718990>
2757
2758         Reviewed by Joseph Pecoraro.
2759
2760         Teach run-inspector-generator-tests to generate test output using the platform name
2761         derived from the directory that the test is in. For example, tests in the /generic/
2762         subdirectory will pass `--platform generic` to generate-inspector-protocol-bindings.py.
2763
2764         * Scripts/webkitpy/inspector/main.py:
2765         (InspectorGeneratorTests.generate_from_json):
2766         (InspectorGeneratorTests.run_tests):
2767         (InspectorGeneratorTests.main):
2768
2769 2017-01-04  Csaba Osztrogonác  <ossy@webkit.org>
2770
2771         Unreviewed cmake buildfix after r210266.
2772
2773         * DumpRenderTree/PlatformMac.cmake:
2774
2775 2017-01-04  Tim Horton  <timothy_horton@apple.com>
2776
2777         Provide a setting for clients to always prefer low-power WebGL
2778         https://bugs.webkit.org/show_bug.cgi?id=166675
2779         <rdar://problem/29834093>
2780
2781         Reviewed by Dan Bernstein.
2782
2783         * MiniBrowser/mac/Info.plist:
2784         Have MiniBrowser claim to be a modern app that supports
2785         automatic graphics switching. WebKit needs to support automatic
2786         graphics switching, so our test app might as well. Without this
2787         Info.plist parameter, this change has no effect, and bringing up
2788         a WebGL context still brings up the discrete GPU (also true of the
2789         existing web-exposed preferLowPowerToHighPerformance API).
2790
2791 2017-01-03  Yusuke Suzuki  <utatane.tea@gmail.com>
2792
2793         WorkQueueGeneric's platformInvalidate() can deadlock when called on the RunLoop's thread
2794         https://bugs.webkit.org/show_bug.cgi?id=166645
2795
2796         Reviewed by Carlos Garcia Campos.
2797
2798         * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
2799         (TestWebKitAPI::TEST):
2800
2801 2017-01-03  Andy Estes  <aestes@apple.com>
2802
2803         Place all the Cocoa WebCore API tests in the same directory
2804         https://bugs.webkit.org/show_bug.cgi?id=166673
2805
2806         Reviewed by Michael Catanzaro.
2807
2808         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2809         * TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/SerializedCryptoKeyWrap.mm.
2810         * TestWebKitAPI/Tests/WebCore/cocoa/URLExtras.mm: Renamed from Tools/TestWebKitAPI/Tests/Cocoa/URLExtras.mm.
2811         * TestWebKitAPI/Tests/WebCore/cocoa/WebCoreNSURLSession.mm: Renamed from Tools/TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm.
2812
2813 2017-01-03  Tim Horton  <timothy_horton@apple.com>
2814
2815         NSSpellChecker's recordResponse isn't called for unseen automatic corrections
2816         https://bugs.webkit.org/show_bug.cgi?id=166450
2817         <rdar://problem/29447824>
2818
2819         Reviewed by Darin Adler.
2820
2821         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
2822         * DumpRenderTree/TestRunner.cpp:
2823         (TestRunner::staticFunctions):
2824         * DumpRenderTree/mac/TestRunnerMac.mm:
2825         (setSpellCheckerLoggingEnabledCallback):
2826         * DumpRenderTree/win/TestRunnerWin.cpp:
2827         (setSpellCheckerLoggingEnabledCallback):
2828         * DumpRenderTree/mac/DumpRenderTree.mm:
2829         (resetWebViewToConsistentStateBeforeTesting):
2830         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.h: Added.
2831         * DumpRenderTree/mac/DumpRenderTreeSpellChecker.mm: Added.
2832         (stringForCorrectionResponse):
2833         (drt_NSSpellChecker_recordResponseToCorrection):
2834         (swizzleNSSpellCheckerMethodsIfNeeded):
2835         (setSpellCheckerLoggingEnabled):
2836         Add a new testRunner method, setSpellCheckerLoggingEnabled, which, when
2837         set to true, logs to stdout (which ends up in the test result) whenever
2838         NSSpellChecker recordResponse:toCorrection:forWord:language:inSpellDocumentWithTag:
2839         is called, and then calls the original method. It is reset to false between tests.
2840
2841 2017-01-03  Sam Weinig  <sam@webkit.org>
2842
2843         Make WTF::Expected support Ref template parameters
2844         https://bugs.webkit.org/show_bug.cgi?id=166662
2845
2846         Reviewed by Alex Christensen.
2847
2848         * TestWebKitAPI/Tests/WTF/Expected.cpp:
2849         (TestWebKitAPI::TEST):
2850         Add tests for using Ref with Expected.
2851
2852 2017-01-03  Michael Catanzaro  <mcatanzaro@igalia.com>
2853
2854         [GTK] Expose WebKitSecurityOrigin API
2855         https://bugs.webkit.org/show_bug.cgi?id=166632
2856
2857         Reviewed by Carlos Garcia Campos.
2858
2859         * TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
2860         * TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSecurityOrigin.cpp: Added.
2861         (testSecurityOriginBasicConstructor):
2862         (testSecurityOriginURIConstructor):
2863         (testSecurityOriginDefaultPort):
2864         (testSecurityOriginFileURI):
2865         (testSecurityOriginDataURI):
2866         (beforeAll):
2867         (afterAll):
2868
2869 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2870
2871         [GTK] HTTP auth layout tests are flaky
2872         https://bugs.webkit.org/show_bug.cgi?id=158919
2873
2874         Reviewed by Michael Catanzaro.
2875
2876         * gtk/jhbuild.modules: Update libsoup to version 2.57.1.
2877         * gtk/jhbuildrc: Stop passing --enable-introspection unconditionally to all modules. We don't really need
2878         introspection for the dependencies in the internal build, and it makes newer libsoup build fail because of
2879         missing valac in the bots.
2880
2881 2017-01-03  Carlos Garcia Campos  <cgarcia@igalia.com>
2882
2883         REGRESSION(r173753): [GTK] Source/WebKit is distributed in tarballs
2884         https://bugs.webkit.org/show_bug.cgi?id=165797
2885
2886         Reviewed by Michael Catanzaro.
2887
2888         Move directory ruleset after all exclude rules of Source rulset.
2889
2890         * gtk/manifest.txt.in:
2891
2892 2017-01-02  Yusuke Suzuki  <utatane.tea@gmail.com>
2893
2894         Leverage Substring to create new AtomicStringImpl for StaticStringImpl and SymbolImpl
2895         https://bugs.webkit.org/show_bug.cgi?id=166636
2896
2897         Reviewed by Darin Adler.
2898
2899         * TestWebKitAPI/Tests/WTF/StringImpl.cpp:
2900         (TestWebKitAPI::TEST):
2901
2902 2017-01-02  Manuel Rego Casasnovas  <rego@igalia.com>
2903
2904         [GTK] WebCore/CSSParser unit test is not being built
2905         https://bugs.webkit.org/show_bug.cgi?id=166492
2906
2907         Reviewed by Michael Catanzaro.
2908
2909         This test was introduced in r175930, but we were not building
2910         it on GTK+ port since r176015.
2911         This patch marks the test to be built again on GTK+.
2912         JFTR, the test is passing right now.
2913
2914         * TestWebKitAPI/PlatformGTK.cmake: Add CSSParser.cpp test file and use
2915         ADD_WHOLE_ARCHIVE_TO_LIBRARIES to avoid linking errors.
2916
2917 2017-01-02  Chris Fleizach  <cfleizach@apple.com>
2918
2919         AX: Expose block quote level to iOS API
2920         https://bugs.webkit.org/show_bug.cgi?id=166629
2921         <rdar://problem/29834793>
2922
2923         Reviewed by Darin Adler.
2924
2925         * DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
2926         (AccessibilityUIElement::numberAttributeValue):
2927         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
2928         (WTR::AccessibilityUIElement::numberAttributeValue):
2929
2930 2016-12-31  Michael Catanzaro  <mcatanzaro@igalia.com>
2931
2932         SecurityOrigin::create triplet constructor does not canonicalize port
2933         https://bugs.webkit.org/show_bug.cgi?id=166624
2934
2935         Reviewed by Daniel Bates.
2936
2937         * TestWebKitAPI/PlatformGTK.cmake:
2938         * TestWebKitAPI/PlatformWin.cmake:
2939         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2940         * TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp: Added.
2941         (TestWebKitAPI::SecurityOriginTest::SetUp):
2942         (TestWebKitAPI::TEST_F):
2943
2944 2016-12-30  Michael Catanzaro  <mcatanzaro@igalia.com>
2945
2946         [GTK] Improve user agent construction
2947         https://bugs.webkit.org/show_bug.cgi?id=142074
2948
2949         Reviewed by Carlos Garcia Campos.
2950
2951         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2952         (TestWebKitAPI::assertUserAgentForURLHasChromeBrowserQuirk):
2953         (TestWebKitAPI::assertUserAgentForURLHasFirefoxBrowserQuirk):
2954         (TestWebKitAPI::assertUserAgentForURLHasLinuxPlatformQuirk):
2955         (TestWebKitAPI::assertUserAgentForURLHasMacPlatformQuirk):
2956         (TestWebKitAPI::TEST):
2957
2958 2016-12-27  Michael Catanzaro  <mcatanzaro@igalia.com>
2959
2960         [GTK] Improve user agent construction
2961         https://bugs.webkit.org/show_bug.cgi?id=142074
2962
2963         Reviewed by Carlos Garcia Campos.
2964
2965         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
2966         (TestWebKitAPI::TEST):
2967
2968 2016-12-23  Simon Fraser  <simon.fraser@apple.com>
2969
2970         REGRESSION (r209299): Selection is broken when you zoom in webpage using trackpad
2971         https://bugs.webkit.org/show_bug.cgi?id=166472
2972         rdar://problem/29675551
2973
2974         Reviewed by Tim Horton.
2975
2976         These changes are necessary to allow the mouse to leave the WTR window while
2977         drag-scrolling, to test autoscroll. Previously, we were never calling -mouseDragged
2978         (which DRT does); we'd always go through mouseMoved, which hits an early return
2979         in WebViewImpl::mouseMoved() when the point is outside the view.
2980
2981         * WebKitTestRunner/mac/EventSenderProxy.mm:
2982         (WTR::EventSenderProxy::mouseMoveTo):
2983
2984 2016-12-23  Andy Estes  <aestes@apple.com>
2985
2986         [iOS] Fix some crashing webarchive tests
2987         https://bugs.webkit.org/show_bug.cgi?id=166470
2988
2989         Reviewed by Andreas Kling.
2990
2991         Tests that use TestRunner.dumpDOMAsWebArchive() crashed on iOS due to a stub implementation
2992         of WebArchiveDumpSupport in WebKitTestRunner. The Mac implementation works fine on iOS too,
2993         so this change uses that on both platforms.
2994
2995         * WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Removed
2996         WebArchiveDumpSupportMac.mm from EXCLUDED_SOURCE_FILE_NAMES.
2997         * WebKitTestRunner/InjectedBundle/cocoa/WebArchiveDumpSupportCocoa.mm: Renamed from
2998         Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm.
2999         * WebKitTestRunner/PlatformMac.cmake:
3000         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3001         * WebKitTestRunner/ios/WebArchiveDumpSupportIOS.mm: Removed.
3002
3003 2016-12-22  Saam Barati  <sbarati@apple.com>
3004
3005         WebAssembly: Silence the output of the spec-tests
3006         https://bugs.webkit.org/show_bug.cgi?id=166417
3007
3008         Reviewed by Mark Lam.
3009
3010         * Scripts/run-jsc-stress-tests:
3011
3012 2016-12-22  Zhuo Li  <zachli@apple.com>
3013
3014         [Cocoa] SPI for setloadsImagesAutomatically.
3015         https://bugs.webkit.org/show_bug.cgi?id=166401.
3016
3017         Reviewed by Darin Adler.
3018
3019         * TestWebKitAPI/Tests/WebKit2Cocoa/Preferences.mm:
3020         (TEST): Test the _setLoadsImagesAutomatically SPI. By default,
3021         _loadsImagesAutomatically returns YES.
3022
3023 2016-12-22  Wenson Hsieh  <wenson_hsieh@apple.com>
3024
3025         fast/events/ios/viewport-shrink-to-fit-allows-double-tap.html is flaky/order dependent
3026         https://bugs.webkit.org/show_bug.cgi?id=161328
3027         <rdar://problem/28475977>
3028
3029         Reviewed by Darin Adler.
3030
3031         Running a test that scales the viewport and listens to a didEndZooming callback (such as
3032         viewport-shrink-to-fit-allows-double-tap.html) immediately after a test that may begin to trigger viewport
3033         scaling as the test completes (such as viewport-device-width-at-initial-scale-fast-clicks.html) may result in
3034         the didEndZooming callback of the latter test being fired early due to the previous test triggering a zoom
3035         animation. Ideally, -[WKScrollView _stopScrollingAndZoomingAnimations], which is called when committing the page
3036         load, should prevent this from happening, but from reading documentation and code inspection, this is not
3037         intended to fire any associated delegate methods or notifications of the UIScrollView, instead deferring them
3038         for later. Instead, what we need in this case is to clear out any started but not yet completed animations after
3039         we finish running a test and before we load the next test.
3040
3041         One way to do this is to remove all animations from the WKScrollView's layer, and the layers of its children,
3042         recursively. Doing so causes scrollViewDidEndZooming:withView:atScale: to fire at the end of the runloop if the
3043         previous test started zooming and then finished before zooming completed. Since this happens before the next
3044         test has a chance to run UI-side scripts, we won't end up firing this callback prematurely during the next test.
3045
3046         * WebKitTestRunner/ios/TestControllerIOS.mm:
3047         (WTR::TestController::platformResetStateToConsistentValues):
3048
3049 2016-12-22  Jer Noble  <jer.noble@apple.com>
3050
3051         Muted media element playback should not interrupt other audio playback
3052         https://bugs.webkit.org/show_bug.cgi?id=166347
3053
3054         Reviewed by Eric Carlson.
3055
3056         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3057         * TestWebKitAPI/Tests/WebKit/ios/AudioSessionCategoryIOS.mm:
3058         (TestWebKitAPI::TEST):
3059         * TestWebKitAPI/Tests/WebKit/ios/video-with-muted-audio.html: Added.
3060
3061 2016-12-22  Alejandro G. Castro  <alex@igalia.com>
3062
3063         [WebRTC] Add support for runtime PeeConnection setting, required after r209757
3064         https://bugs.webkit.org/show_bug.cgi?id=166346
3065
3066         Reviewed by Carlos Garcia Campos.
3067
3068         Enable WebRTC by default to simplify testing.
3069
3070         * MiniBrowser/gtk/main.c:
3071         (main):
3072
3073 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3074
3075         REGRESSION: API test failure: WKWebView.LocalStorageClear
3076         https://bugs.webkit.org/show_bug.cgi?id=166032
3077         <rdar://problem/29758423>
3078
3079         Reviewed by Simon Fraser.
3080
3081         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3082         to ensure that the view is destroyed before the callback fires.
3083
3084         * TestWebKitAPI/Tests/WebKit2Cocoa/LocalStorageClear.mm:
3085         (TEST):
3086
3087 2016-12-21  Saam Barati  <sbarati@apple.com>
3088
3089         WebAssembly: Import spec tests
3090         https://bugs.webkit.org/show_bug.cgi?id=166395
3091
3092         Rubber stamped by Keith Miller.
3093
3094         * Scripts/run-jsc-stress-tests:
3095
3096 2016-12-21  Alexey Proskuryakov  <ap@apple.com>
3097
3098         REGRESSION: API test failure: _WKDownload.OriginatingWebView
3099         https://bugs.webkit.org/show_bug.cgi?id=166033
3100         <rdar://problem/29758428>
3101
3102         Reviewed by Simon Fraser.
3103
3104         Add an @autoreleasepool around the code that allocates the WKWebView, 
3105         so that it can be destroyed by removing the last reference in _downloadDidStart.
3106
3107         * TestWebKitAPI/Tests/WebKit2Cocoa/Download.mm:
3108         (TEST):
3109
3110 2016-12-21  Daniel Bates  <dabates@apple.com>
3111
3112         WebKitTestRunner: Add comment to TestRunner::setCanOpenWindows()
3113         https://bugs.webkit.org/show_bug.cgi?id=166356
3114
3115         Add comment in TestRunner::setCanOpenWindows() to elaborate further on its purpose
3116         as a means to allow a test to explicit allow an embedding client to open a new windows
3117         such that the default behavior is for the embedding client to forbid such an action.
3118         The test plugins/get-url-with-blank-target.html assumes this default behavior though
3119         it is currently skipped on WebKit2 because questions were raised in the patch for
3120         <https://bugs.webkit.org/show_bug.cgi?id=43389> about its correctness and usefulness.
3121         We will need to implement TestRunner::setCanOpenWindows() should we decide to unskip
3122         this test.
3123
3124         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3125         (WTR::TestRunner::setCanOpenWindows):
3126
3127 2016-12-20  Simon Fraser  <simon.fraser@apple.com>
3128
3129         REGRESSION: API test failure: WKWebView.EvaluateJavaScriptBlockCrash
3130         https://bugs.webkit.org/show_bug.cgi?id=166031
3131
3132         Reviewed by Tim Horton.
3133         
3134         Add an @autoreleasepool around the code that allocates then clears the WKWebView, 
3135         to ensure that the view is destroyed before the callback fires.
3136
3137         * TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
3138
3139 2016-12-20  Megan Gardner  <megan_gardner@apple.com>
3140
3141         Throw Exception when test doesn't clean up HID Events properly
3142         https://bugs.webkit.org/show_bug.cgi?id=166271
3143
3144         Reviewed by Simon Fraser.
3145
3146         Add in a check when UIScriptController is deleted to make sure that the HID event
3147         callback dictionary is empty. If it is not, and a HID event is hit, this will cause
3148         the program to crash without any good information. Crashes are race-y, and will still
3149         happen with malformed test, but the information will be much more helpful. 
3150
3151         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3152         (WTR::UIScriptController::checkForClean):
3153         * TestRunnerShared/UIScriptContext/UIScriptContext.cpp:
3154         (UIScriptContext::~UIScriptContext):
3155         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3156         (WTR::UIScriptController::checkForClean):
3157         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3158         * WebKitTestRunner/ios/HIDEventGenerator.h:
3159         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3160         (-[HIDEventGenerator checkHIDCallbacksClear]):
3161         * WebKitTestRunner/ios/TestControllerIOS.mm:
3162         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3163         (WTR::UIScriptController::checkForClean):
3164
3165 2016-12-20  Andy Estes  <aestes@apple.com>
3166
3167         [Cocoa] REGRESSION (r209558): Calling decisionHandler multiple times in webView:decidePolicyForNavigationAction:decisionHandler: leads to a crash
3168         https://bugs.webkit.org/show_bug.cgi?id=165992
3169
3170         Reviewed by Brady Eidson.
3171
3172         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3173         * TestWebKitAPI/Tests/WebKit2Cocoa/DuplicateCompletionHandlerCalls.mm: Added.
3174         (expectException):
3175         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
3176         (-[DuplicateCompletionHandlerCallsDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
3177         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
3178         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
3179         (-[DuplicateCompletionHandlerCallsDelegate webView:runJavaScriptTextInputPanelWithPrompt:defaultText:initiatedByFrame:completionHandler:]):
3180         (-[DuplicateCompletionHandlerCallsDelegate _webView:decideDatabaseQuotaForSecurityOrigin:currentQuota:currentOriginUsage:currentDatabaseUsage:expectedUsage:decisionHandler:]):
3181         (-[DuplicateCompletionHandlerCallsDelegate _webView:willSubmitFormValues:userObject:submissionHandler:]):
3182         (TEST):
3183         * TestWebKitAPI/Tests/WebKit2Cocoa/duplicate-completion-handler-calls.html: Added.
3184
3185 2016-12-20  Dean Jackson  <dino@apple.com>
3186
3187         Remove INDIE_UI
3188         https://bugs.webkit.org/show_bug.cgi?id=165881
3189         <rdar://problem/29672532>
3190
3191         Reviewed by Simon Fraser.
3192
3193         The Indie UI work has been discontinued.
3194
3195         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3196
3197 2016-12-19  Yusuke Suzuki  <utatane.tea@gmail.com>
3198
3199         [ES6] Enable ES6 Modules
3200         https://bugs.webkit.org/show_bug.cgi?id=165849
3201
3202         Reviewed by Geoffrey Garen.
3203
3204         * DumpRenderTree/mac/DumpRenderTree.mm:
3205         (resetWebPreferencesToConsistentValues):
3206         * DumpRenderTree/win/DumpRenderTree.cpp:
3207         (resetWebPreferencesToConsistentValues):
3208         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3209         (WTR::InjectedBundle::beginTesting):
3210         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3211         (WTR::TestRunner::setES6ModulesEnabled): Deleted.
3212         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3213
3214 2016-12-19  Ryan Haddad  <ryanhaddad@apple.com>
3215
3216         Repurpose bots and clean up dashboard.
3217         https://bugs.webkit.org/show_bug.cgi?id=166045
3218
3219         Reviewed by Lucas Forschler.
3220
3221         * BuildSlaveSupport/build.webkit.org-config/config.json:
3222         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
3223         (BubbleQueueServer):
3224         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
3225         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3226         (WebKitBuildbot):
3227         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
3228         (table.queue-grid tr.platform.mac-os-x-yosemite img.logo): Deleted.
3229
3230 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3231
3232         [CMake] TestWebKitAPIBase links to itself
3233         https://bugs.webkit.org/show_bug.cgi?id=165985
3234
3235         Reviewed by Alex Christensen.
3236
3237         Fix CMake warning about a target linking to itself, which makes no sense.
3238
3239         * TestWebKitAPI/CMakeLists.txt:
3240
3241 2016-12-19  Michael Catanzaro  <mcatanzaro@igalia.com>
3242
3243         [GTK] GtkDoc build should be quieter
3244         https://bugs.webkit.org/show_bug.cgi?id=165994
3245
3246         Reviewed by Carlos Garcia Campos.
3247
3248         Make it not print by default.
3249
3250         * gtk/generate-gtkdoc:
3251         (get_generator_for_config):
3252         (generate_doc):
3253         * gtk/gtkdoc.py:
3254         (GTKDoc._run_command):
3255         (GTKDoc._copy_doc_files_to_output_dir):
3256
3257 2016-12-18  Simon Fraser  <simon.fraser@apple.com>
3258
3259         Expose a way for MiniBrowser to simulate header and footer banners
3260         https://bugs.webkit.org/show_bug.cgi?id=166005
3261
3262         Reviewed by Wenson Hsieh.
3263         
3264         Add a MiniBrowser menu item and setting to toggle adding space for header and footer
3265         banners. This only works in WebKit2.
3266         
3267         We need to reset these on each navigation, since newly created FrameViews
3268         don't re-fetch the header and footer height stored on Page.
3269         
3270         Also fix the signature of webView:didFinishNavigation: to follow API changes,
3271         as well as fixing webViewWebContentProcessDidTerminate:
3272
3273         * MiniBrowser/mac/SettingsController.h:
3274         * MiniBrowser/mac/SettingsController.m:
3275         (-[SettingsController _populateMenu]):
3276         (-[SettingsController validateMenuItem:]):
3277         (-[SettingsController toggleReserveSpaceForBanners:]):
3278         (-[SettingsController isSpaceReservedForBanners]):
3279         * MiniBrowser/mac/WK2BrowserWindowController.m:
3280         (-[WK2BrowserWindowController didChangeSettings]):
3281         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
3282         (-[WK2BrowserWindowController webViewWebContentProcessDidTerminate:]):
3283         (-[WK2BrowserWindowController webView:didFinishLoadingNavigation:]): Deleted.
3284         (-[WK2BrowserWindowController _webViewWebProcessDidCrash:]): Deleted.
3285
3286 2016-12-17  Simon Fraser  <simon.fraser@apple.com>
3287
3288         Fix iOS test results after r209967.
3289         
3290         Subtracting out the status bar height was erroneously happening for all tests,
3291         not just for flexible viewport tests.
3292         
3293         Fix by plumbing WebViewSizingMode through resizeTo() and setWindowFrame().
3294
3295         * WebKitTestRunner/PlatformWebView.h:
3296         * WebKitTestRunner/TestController.cpp:
3297         (WTR::TestController::resetStateToConsistentValues):
3298         * WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
3299         (WTR::PlatformWebView::resizeTo):
3300         (WTR::PlatformWebView::setWindowFrame):
3301         * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
3302         (WTR::PlatformWebView::resizeTo):
3303         (WTR::PlatformWebView::setWindowFrame):
3304         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3305         (WTR::PlatformWebView::resizeTo):
3306         (WTR::PlatformWebView::setWindowFrame):
3307         * WebKitTestRunner/ios/TestControllerIOS.mm:
3308         (WTR::TestController::platformConfigureViewForTest):
3309         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3310         (WTR::PlatformWebView::resizeTo):
3311         (WTR::PlatformWebView::setWindowFrame):
3312
3313 2016-12-17  Joonghun Park  <jh718.park@samsung.com>
3314
3315         [EFL] bump EFL version to 1.18.4
3316         https://bugs.webkit.org/show_bug.cgi?id=166004
3317
3318         Reviewed by Gyuyoung Kim.
3319
3320         * efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.
3321
3322 2016-12-17  Wenson Hsieh  <wenson_hsieh@apple.com>
3323
3324         Visual viewports: bottom fixed elements disappear behind the keyboard
3325         https://bugs.webkit.org/show_bug.cgi?id=165983
3326         <rdar://problem/29409852>
3327
3328         Reviewed by Simon Fraser.
3329
3330         Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
3331         the keyboard when it is up.
3332
3333         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3334         (WTR::UIScriptController::inputViewBounds):
3335         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3336         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3337         (WTR::UIScriptController::inputViewBounds):
3338         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3339         * WebKitTestRunner/ios/PlatformWebViewIOS.mm:
3340         (WTR::viewRectForWindowRect):
3341
3342         Previously, we accounted for the status bar height by translating the entire web view down by the height of the
3343         status bar. However, we did not shrink the height of the web view itself, which means that for tests which
3344         involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.
3345
3346         (WTR::PlatformWebView::PlatformWebView):
3347         (WTR::PlatformWebView::setWindowFrame):
3348         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3349         (WTR::UIScriptController::inputViewBounds):
3350
3351 2016-12-16  Ryosuke Niwa  <rniwa@webkit.org>
3352
3353         Deleting a character converted from pinyin after an image causes a Safari crash
3354         https://bugs.webkit.org/show_bug.cgi?id=165839
3355         <rdar://problem/27951933>
3356
3357         Reviewed by Wenson Hsieh.
3358
3359         Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
3360         while the proposed range contains an image. This should not cause a WebProcess to crash
3361         or send an invalid message to the UIProcess.
3362
3363         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3364         * TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
3365         * TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.
3366         (TestWebKitAPI::didFinishLoadForFrame):
3367         (TestWebKitAPI::processDidCrash):
3368         (TestWebKitAPI::invalidMessageFunction):
3369         (TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):
3370
3371 2016-12-16  Wenson Hsieh  <wenson_hsieh@apple.com>
3372
3373         Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
3374         https://bugs.webkit.org/show_bug.cgi?id=165767
3375         <rdar://problem/29602382>
3376
3377         Reviewed by Simon Fraser.
3378
3379         Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
3380         WebKit2 ChangeLog for more details.
3381
3382         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
3383         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3384         (WTR::UIScriptController::textSelectionCaretRect):
3385         * DumpRenderTree/mac/UIScriptControllerMac.mm:
3386         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3387         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3388         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
3389         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3390         (WTR::UIScriptController::textSelectionCaretRect):
3391         * TestRunnerShared/UIScriptContext/UIScriptController.h:
3392         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
3393         (-[TestRunnerWKWebView _setStableStateOverride:]):
3394
3395         Force the WKWebView to update its visible content rects when changing the stable state override.
3396
3397         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3398         (WTR::toNSDictionary):
3399         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3400         (WTR::UIScriptController::selectionRangeViewRects):
3401         (WTR::UIScriptController::textSelectionCaretRect):
3402         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
3403         (WTR::UIScriptController::doAfterNextStablePresentationUpdate):
3404
3405 2016-12-15  Brent Fulgham  <bfulgham@apple.com>
3406
3407         Arguments called in wrong order
3408         https://bugs.webkit.org/show_bug.cgi?id=165923
3409
3410         Reviewed by Simon Fraser.
3411
3412         The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
3413         and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.
3414
3415         * TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:
3416         (TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
3417         order of arguments to WKUserMediaPermissionRequestAllow are flipped.
3418
3419 2016-12-16  Hunseop Jeong  <hs85.jeong@samsung.com>
3420
3421         [EFL] Disable non-srcdir builds for failing libraries
3422         https://bugs.webkit.org/show_bug.cgi?id=165896
3423
3424         Reviewed by Gyuyoung Kim.
3425
3426         * efl/jhbuild.modules: Set non srcdir builds to no
3427
3428 2016-12-15  Daniel Bates  <dabates@apple.com>
3429
3430         check-style should not complain about code in icu directories
3431         https://bugs.webkit.org/show_bug.cgi?id=53929
3432
3433         Reviewed by Darin Adler.
3434
3435         Skip style checking of imported ICU headers to avoid a deluge of style issues
3436         as they do not conform to the WebKit Code Style guideline. We want to preserve
3437         the formatting of these headers so as to make it straightforward to merge
3438         changes to them, if necessary.
3439
3440         * Scripts/webkitpy/style/checker.py:
3441
3442 2016-12-15  Alexey Proskuryakov  <ap@apple.com>
3443
3444         Move JSC testers from Yosemite to Sierra
3445         https://bugs.webkit.org/show_bug.cgi?id=165925
3446
3447         Reviewed by Lucas Forschler.
3448
3449         * BuildSlaveSupport/build.webkit.org-config/config.json:
3450         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
3451         (WebKitBuildbot):
3452
3453 2016-12-15  Megan Gardner  <megan_gardner@apple.com>
3454
3455         Add coordinate space to event streams and streamline tests
3456         https://bugs.webkit.org/show_bug.cgi?id=165119
3457
3458         Reviewed by Simon Fraser.
3459
3460         Update event streams to allow for both content and global coordinate space.
3461         Update example script to more accurately show all the available options.
3462
3463         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
3464         * WebKitTestRunner/ios/HIDEventGenerator.h:
3465         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3466         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3467         (WTR::convertCoordinates):
3468         (WTR::UIScriptController::sendEventStream):
3469
3470 2016-12-15  Claudio Saavedra  <csaavedra@igalia.com>
3471
3472         [GTK] Ensure gst* docs are not built with update-webkitgtk-libs
3473         https://bugs.webkit.org/show_bug.cgi?id=165855
3474
3475         Reviewed by Philippe Normand.
3476
3477         GStreamer's autogen.sh enables gtk-doc always so we end up building
3478         docs even if we disable them. Use the configure script instead, since
3479         we build from packages and these include it already.
3480
3481         * gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for
3482         upstream gstreamer packages.
3483
3484 2016-12-15  Alex Christensen  <achristensen@webkit.org>
3485
3486         REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
3487         https://bugs.webkit.org/show_bug.cgi?id=165885
3488         <rdar://problem/29476917>
3489
3490         Reviewed by Darin Adler.
3491
3492         * TestWebKitAPI/Tests/WebCore/URLParser.cpp:
3493         (TestWebKitAPI::utf16String): Deleted.
3494         * TestWebKitAPI/Tests/mac/PublicSuffix.mm:
3495         (TestWebKitAPI::TEST_F):
3496         * TestWebKitAPI/WTFStringUtilities.h:
3497         (utf16String):
3498         Moved from URLParser to share with other tests.
3499
3500 2016-12-14  Ryosuke Niwa  <rniwa@webkit.org>
3501
3502         iOS: An element with tabindex is not focusable unless there is no mouse event handler
3503         https://bugs.webkit.org/show_bug.cgi?id=165843
3504
3505         Reviewed by Antti Koivisto.
3506
3507         Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
3508         Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
3509         and DumpRenderTree's runUIScript would hit an assertion :(
3510
3511         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3512         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3513         (WTR::TestRunner::isWebKit2):
3514
3515 2016-12-14  Brady Eidson  <beidson@apple.com>
3516
3517         IndexedDB 2.0: Massively speedup IDBIndex.get().
3518         https://bugs.webkit.org/show_bug.cgi?id=165802
3519
3520         Reviewed by Alex Christensen.
3521
3522         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3523         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
3524         * TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
3525         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
3526         * TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.
3527
3528 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3529
3530         [GTK][EFL] Update the JHBuild version.
3531         https://bugs.webkit.org/show_bug.cgi?id=165838
3532
3533         Reviewed by Michael Catanzaro.
3534
3535         * jhbuild/jhbuild-wrapper: This new version fixes a bug with the
3536         usage of the JHBUILD_MIRROR feature with git repositories.
3537
3538 2016-12-14  Carlos Alberto Lopez Perez  <clopez@igalia.com>
3539
3540         [GTK] Yasm is needed for building the JHBuild after r208940
3541         https://bugs.webkit.org/show_bug.cgi?id=165837
3542
3543         Reviewed by Alejandro G. Castro.
3544
3545         * gtk/install-dependencies: Yasm is needed for building libvpx.
3546
3547 2016-12-14  Youenn Fablet  <youenn@apple.com>
3548
3549         Test infrastructure should allow to filter out text output before doing a comparison with the baseline
3550         https://bugs.webkit.org/show_bug.cgi?id=161310
3551
3552         Reviewed by Ryosuke Niwa.
3553
3554         Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
3555         When set, WTR and DRT output JS console log in the stderr and not the test output.
3556         This allows removing potentially flaky information while still being able to read it for investigation.
3557
3558         Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.
3559
3560         Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
3561         This test should have this option when fetch API will start logging resource loader errors.
3562
3563         * DumpRenderTree/DumpRenderTree.h:
3564         (TestCommand::TestCommand): Deleted.
3565         * DumpRenderTree/DumpRenderTreeCommon.cpp:
3566         (parseInputLine):
3567         * DumpRenderTree/TestRunner.h:
3568         (TestRunner::setDumpJSConsoleLogInStdErr):
3569         (TestRunner::dumpJSConsoleLogInStdErr):
3570         * DumpRenderTree/mac/DumpRenderTree.mm:
3571         (runTest):
3572         * DumpRenderTree/mac/UIDelegate.mm:
3573         (-[UIDelegate webView:addMessageToConsole:withSource:]):
3574         * DumpRenderTree/win/DumpRenderTree.cpp:
3575         (runTest):
3576         * DumpRenderTree/win/UIDelegate.cpp:
3577         (UIDelegate::webViewAddMessageToConsole):
3578         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
3579         (TestExpectationParser._tokenize_line):
3580         * Scripts/webkitpy/port/driver.py:
3581         (Driver._command_from_driver_input):
3582         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
3583         (WTR::InjectedBundle::didReceiveMessageToPage):
3584         (WTR::InjectedBundle::dumpToStdErr):
3585         * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
3586         (WTR::InjectedBundle::dumpJSConsoleLogInStdErr):
3587         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
3588         (WTR::InjectedBundlePage::willAddMessageToConsole):
3589         * WebKitTestRunner/TestController.cpp:
3590         (WTR::parseInputLine):
3591         (WTR::TestController::runTest):
3592         (WTR::TestCommand::TestCommand): Deleted.
3593         * WebKitTestRunner/TestInvocation.cpp:
3594         (WTR::TestInvocation::invoke):
3595         (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
3596         * WebKitTestRunner/TestInvocation.h:
3597         (WTR::TestInvocation::setDumpJSConsoleLogInStdErr):
3598
3599
3600 2016-12-14  Enrique Ocaña González  <eocanha@igalia.com>
3601
3602         REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
3603         https://bugs.webkit.org/show_bug.cgi?id=164022
3604
3605         Reviewed by Xabier Rodriguez-Calvar.
3606
3607         * Scripts/webkitperl/FeatureList.pm:
3608           Re-enable MEDIA_SOURCE for the GTK+ port.
3609
3610 2016-12-13  Alex Christensen  <achristensen@webkit.org>
3611
3612         Fix CMake build.
3613
3614         * DumpRenderTree/PlatformMac.cmake:
3615         Define NS_RETURNS_RETAINED as nothing for now.
3616
3617 2016-12-13  Jer Noble  <jer.noble@apple.com>
3618
3619         Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
3620         https://bugs.webkit.org/show_bug.cgi?id=165697
3621
3622         Reviewed by Tim Horton.
3623
3624         * TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:
3625         (TestWebKitAPI::TEST):
3626
3627 2016-12-13  Andy Estes  <aestes@apple.com>
3628
3629         [Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
3630         https://bugs.webkit.org/show_bug.cgi?id=165785
3631         <rdar://problem/26929398>
3632
3633         Reviewed by Darin Adler.
3634
3635         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:
3636         (-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
3637         expectations for the text, range, and action.
3638         (TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
3639         will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
3640         plain-text string to the pasteboard, executed a paste action, and verified that the selected
3641         text in the web view did not change.
3642         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
3643         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
3644         _editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
3645         parameter.
3646         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
3647         Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
3648         and returned the value of _editingDelegateShouldInsertText.
3649         * TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared
3650         -shouldInsertText:replacingRange:givenAction:.
3651
3652 2016-12-13  Chris Dumez  <cdumez@apple.com>
3653
3654         Unreviewed, rolling out r209544.
3655
3656         Looks like r209489 did not cause the performance regression
3657         after all
3658
3659         Reverted changeset:
3660