6ae8ba05fba8c4001c856d30d07dd90dfa93a82a
[WebKit-https.git] / Tools / ChangeLog
1 2019-03-08  Saam barati  <sbarati@apple.com>
2
3         Add a compare-results script to compare benchmark results
4         https://bugs.webkit.org/show_bug.cgi?id=195486
5         <rdar://problem/48723397>
6
7         Reviewed by Geoffrey Garen.
8
9         This patch adds a script to compare benchmark results using Welch's two-tailed t test.
10         Initially, this patch only reasons about PLT5/JetStream2/Speedometer2. It will be easy
11         to extend it to learn about our other benchmarks.
12
13         * Scripts/compare-results: Added.
14         (readJSONFile):
15         (detectJetStream2):
16         (JetStream2Results):
17         (detectSpeedometer2):
18         (Speedometer2Results):
19         (detectPLT5):
20         (PLT5Results):
21         (detectBenchmark):
22         (biggerIsBetter):
23         (ttest):
24         (getOptions):
25         (main):
26
27 2019-03-08  Stephanie Lewis  <slewis@apple.com>
28
29         Ensure old tab state is cleared between iterations of run-benchmark
30         https://bugs.webkit.org/show_bug.cgi?id=195393
31         <rdar://problem/46885583>
32
33         Reviewed by Dewei Zhu.
34
35         a) ensure the default to restore state is not set
36         b) terminate Safari correctly
37         c) Set the system default to ignore Persistent State in Safari
38
39         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
40         (OSXBrowserDriver): fix terminate processes to call terminate before killing.
41         (OSXBrowserDriver.prepare_env): 
42         (OSXBrowserDriver.restore_env):
43         (OSXBrowserDriver.close_browsers):
44         (OSXBrowserDriver._terminate_processes):
45         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py: add bundle id
46         (OSXChromeDriver):
47         (OSXChromeCanaryDriver):
48         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py: ditto
49         (OSXFirefoxDriver):
50         (OSXFirefoxNightlyDriver):
51         * Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py: add preferences to not restore state, bundle id
52         (OSXSafariDriver):
53         (OSXSafariDriver.prepare_env):
54
55 2019-03-08  Diego Pino Garcia  <dpino@igalia.com>
56
57         [GTK] Several InputMethodFilter tests are failing
58         https://bugs.webkit.org/show_bug.cgi?id=195408
59
60         Reviewed by Carlos Garcia Campos.
61
62         * TestWebKitAPI/Tests/WebKit/gtk/InputMethodFilter.cpp:
63         Regressed in r241751.
64         Hexadecimal values of keycodes are expressed now in upper letters.
65         Composited characters should be cast to UTF8 strings.
66
67         (TestWebKitAPI::TEST):
68
69 2019-03-07  Tomas Popela  <tpopela@redhat.com>
70
71         [GTK] Make Tools/gtkdoc python3 compatible
72         https://bugs.webkit.org/show_bug.cgi?id=195359
73
74         Reviewed by Carlos Garcia Campos.
75
76         * gtkdoc/generate-gtkdoc:
77         ConfigParser was reworked in Python 3.2 so we have adapt the code to
78         work with Python 2 and 3.
79         (get_gtkdoc_module_paths):
80         The iteritems() was removed in Python 3, so let's use items() that's
81         available in Python 2 and 3.
82         (get_generator_for_config):
83         * gtkdoc/gtkdoc.py:
84         (GTKDoc._run_command):
85         The sys.stdout.write() is expecting str in Python 3 and not bytes
86         (that are coming from stdout.encode()). Use sys.stdout.buffer.write()
87         for passing the bytes there.
88
89 2019-03-07  Fujii Hironori  <Hironori.Fujii@sony.com>
90
91         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
92         https://bugs.webkit.org/show_bug.cgi?id=195346
93         <rdar://problem/48667048>
94
95         Unreviewed build fix for clang-cl.
96
97         * DumpRenderTree/win/DumpRenderTree.cpp:
98         (setApplicationId): Replaced calling String::charactersWithNullTermination with String::wideCharacters to get wchar_t.
99
100 2019-03-07  Said Abou-Hallawa  <sabouhallawa@apple.com>
101
102         requestAnimationFrame should execute before the next frame
103         https://bugs.webkit.org/show_bug.cgi?id=177484
104
105         Reviewed by Simon Fraser.
106
107         Add trace points for the page RenderingUpdate.
108
109         * Tracing/SystemTracePoints.plist:
110
111 2019-03-07  Zalan Bujtas  <zalan@apple.com>
112
113         [ContentChangeObserver] Add a setting to be able to turn content change observation on/off
114         https://bugs.webkit.org/show_bug.cgi?id=195353
115         <rdar://problem/48626394>
116
117         Reviewed by Simon Fraser.
118
119         * WebKitTestRunner/ios/TestControllerIOS.mm:
120         (WTR::TestController::platformResetPreferencesToConsistentValues):
121
122 2019-03-07  John Wilander  <wilander@apple.com>
123
124         Resource Load Statistics: Make it possible to purge only script-accessible cookies
125         https://bugs.webkit.org/show_bug.cgi?id=195383
126         <rdar://problem/48570136>
127
128         Reviewed by Brent Fulgham.
129
130         This patch adds test infrastructure to purge only script-accessible cookies,
131         including a new testRunner function called statisticsDeleteCookiesForHost().git a
132
133         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
134         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
135         (WTR::TestRunner::statisticsDeleteCookiesForHost):
136         * WebKitTestRunner/InjectedBundle/TestRunner.h:
137         * WebKitTestRunner/TestController.cpp:
138         (WTR::TestController::statisticsDeleteCookiesForHost):
139         * WebKitTestRunner/TestController.h:
140         * WebKitTestRunner/TestInvocation.cpp:
141         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
142
143 2019-03-07  Commit Queue  <commit-queue@webkit.org>
144
145         Unreviewed, rolling out r242354.
146         https://bugs.webkit.org/show_bug.cgi?id=195402
147
148         breaks layout tests in all configurations (Requested by
149         zdobersek on #webkit).
150
151         Reverted changeset:
152
153         "[WPE] Enable web process sandbox"
154         https://bugs.webkit.org/show_bug.cgi?id=195169
155         https://trac.webkit.org/changeset/242354
156
157 2019-03-06  Ross Kirsling  <ross.kirsling@sony.com>
158
159         [Win] Remove -DUCHAR_TYPE=wchar_t stopgap and learn to live with char16_t.
160         https://bugs.webkit.org/show_bug.cgi?id=195346
161
162         Reviewed by Fujii Hironori.
163
164         * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
165         (TestWebKitAPI::TEST):
166         Delete wchar tests -- these are MSVC-only and we won't be using String::operator+ going forward anyway.
167
168         * DumpRenderTree/win/DumpRenderTree.cpp:
169         (findFontFallback):
170         (addFontFallbackIfPresent):
171         (removeFontFallbackIfPresent):
172         (main):
173         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
174         (TestWebKitAPI::Util::moduleDirectory):
175         (TestWebKitAPI::Util::createInjectedBundlePath):
176         Use wchar helpers as needed.
177
178 2019-03-06  Rob Buis  <rbuis@igalia.com>
179
180         Consider supporting the `referrerpolicy` attribute.
181         https://bugs.webkit.org/show_bug.cgi?id=179053
182
183         Reviewed by Darin Adler.
184
185         Add a runtime flag for referrerpolicy attribute.
186
187         * DumpRenderTree/mac/DumpRenderTree.mm:
188         (enableExperimentalFeatures):
189
190 2019-03-05  Daniel Bates  <dabates@apple.com>
191
192         Update expected API test result following r242379
193         (https://bugs.webkit.org/show_bug.cgi?id=195125)
194
195         Update expected x-coordinate of selection rect now that the left padding of
196         a textarea is sized in ems (so dependent on the font size) just like the left
197         padding of a text field.
198
199         * TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:
200         (TestWebKitAPI::TEST):
201
202 2019-03-05  David Quesada  <david_quesada@apple.com>
203
204         [WK2] It should be possible to follow links with 'download' attributes
205         https://bugs.webkit.org/show_bug.cgi?id=195145
206         rdar://problem/48462642
207
208         Reviewed by Alex Christensen.
209
210         Add a unit test to verify that activating links with 'download' attributes now
211         navigates to the linked resource, rather than starts downloading it. Add another
212         to verify that it is still possible to explicitly download the link via the
213         'Download' navigation action policy.
214
215         * TestWebKitAPI/Tests/WebKitCocoa/Download.mm:
216         (-[DownloadAttributeTestDelegate init]):
217         (-[DownloadAttributeTestDelegate waitForDidFinishNavigation]):
218         (-[DownloadAttributeTestDelegate waitForDownloadDidStart]):
219         (-[DownloadAttributeTestDelegate webView:didFinishNavigation:]):
220         (-[DownloadAttributeTestDelegate webView:didStartProvisionalNavigation:]):
221         (-[DownloadAttributeTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
222         (-[DownloadAttributeTestDelegate _downloadDidStart:]):
223         (TEST):
224         * WebKitTestRunner/TestController.cpp:
225         (WTR::TestController::decidePolicyForNavigationAction):
226         * WebKitTestRunner/TestController.h:
227
228 2019-03-05  Takashi Komori  <Takashi.Komori@sony.com>
229
230         [Curl] Implement Cookie Accept Policy.
231         https://bugs.webkit.org/show_bug.cgi?id=191645
232
233         Reviewed by Fujii Hironori.
234
235         * TestWebKitAPI/Tests/WebCore/curl/Cookies.cpp:
236         (TestWebKitAPI::Curl::TEST_F):
237
238 2019-03-05  Youenn Fablet  <youenn@apple.com>
239
240         Rename requestCacheStorageSpace to requestStorageSpace
241         https://bugs.webkit.org/show_bug.cgi?id=195282
242
243         Reviewed by Chris Dumez.
244
245         * WebKitTestRunner/cocoa/TestWebsiteDataStoreDelegate.mm:
246         (-[TestWebsiteDataStoreDelegate requestStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]):
247         (-[TestWebsiteDataStoreDelegate requestCacheStorageSpace:frameOrigin:quota:currentSize:spaceRequired:decisionHandler:]): Deleted.
248
249 2019-03-05  Brady Eidson  <beidson@apple.com>
250
251         Correctly handle sandbox extensions when the same WKWebView loads multiple file:// URLs.
252         <rdar://problem/47820581> and https://bugs.webkit.org/show_bug.cgi?id=195291
253
254         Reviewed by Tim Horton.
255
256         Loading a file: URL into a WKWebView and then loading another file: url from a completely
257         different directory into that same WKWebView should work.
258
259         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
260         * TestWebKitAPI/Tests/WebKitCocoa/LoadFileURL.mm: Added.
261
262 2019-02-28  Ryosuke Niwa  <rniwa@webkit.org>
263
264         Add WeakHashSet
265         https://bugs.webkit.org/show_bug.cgi?id=195152
266
267         Reviewed by Antti Koivisto.
268
269         Added tests for WeakHashSet.
270
271         * TestWebKitAPI/Tests/WTF/WeakPtr.cpp:
272         (TestWebKitAPI::Base::Base): Moved.
273         (TestWebKitAPI::Derived::foo): Moved.
274         (WTF::WeakReference<TestWebKitAPI::Base>): Added to track the number of live WeakReference.
275         (WTF::WeakReference<TestWebKitAPI::Base>::WeakReference):
276         (WTF::WeakReference<TestWebKitAPI::Base>::~WeakReference):
277         (TestWebKitAPI::computeSizeOfWeakHashSet): Added.
278
279 2019-03-04  Chris Dumez  <cdumez@apple.com>
280
281         Do not share WebProcesses between private and regular sessions
282         https://bugs.webkit.org/show_bug.cgi?id=195189
283         <rdar://problem/48421064>
284
285         Reviewed by Alex Christensen.
286
287         Add API test coverage.
288
289         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
290         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
291
292 2019-03-04  Michael Catanzaro  <mcatanzaro@igalia.com>
293
294         [WPE] Enable web process sandbox
295         https://bugs.webkit.org/show_bug.cgi?id=195169
296
297         Reviewed by Daniel Bates.
298
299         * wpe/install-dependencies:
300         * wpe/jhbuild.modules:
301
302 2019-03-04  Carlos Garcia Campos  <cgarcia@igalia.com>
303
304         [GLib] Returning G_TYPE_OBJECT from a constructor does not work
305         https://bugs.webkit.org/show_bug.cgi?id=195206
306
307         Reviewed by Žan Doberšek.
308
309         Add a new test case.
310
311         * TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:
312         (testJSCClass):
313
314 2019-03-04  Charlie Turner  <cturner@igalia.com>
315
316         [WPE] Inline wl_array_for_each to workaround C++ compatibility issue
317         https://bugs.webkit.org/show_bug.cgi?id=194898
318
319         Reviewed by Žan Doberšek.
320
321         * wpe/backends/WindowViewBackend.cpp: wl_array_for_each relies on
322         a GCC extension that permits arithmetic on void* pointer. Inline
323         the macro until this issue is fixed upstream.
324
325 2019-03-03  Tim Horton  <timothy_horton@apple.com>
326
327         Rid the world of WK_API_ENABLED
328         https://bugs.webkit.org/show_bug.cgi?id=195263
329
330         Reviewed by Dan Bernstein.
331
332         List of changed files elided because it's useless.
333
334 2019-03-03  Ross Kirsling  <ross.kirsling@sony.com>
335
336         Unreviewed follow-up to r242292.
337
338         By Darin's suggestion, adopt an approach that uses EXPECT_STREQ without scattering utf8().data() everywhere.
339
340         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
341         (TestWebKitAPI::testStrip): Renamed from strip.
342         (TestWebKitAPI::TEST):
343
344 2019-03-03  Michael Catanzaro  <mcatanzaro@igalia.com>
345
346         Unreviewed, remove accidentally-committed URLHelpers.cpp test
347
348         This test isn't built by any port and was committed in r240962 by mistake. See bug #174816
349         and bug #194272 for details.
350
351         * TestWebKitAPI/Tests/WTF/URLHelpers.cpp: Removed.
352
353 2019-03-03  Tim Horton  <timothy_horton@apple.com>
354
355         Remove some more unused 32-bit code
356         https://bugs.webkit.org/show_bug.cgi?id=195255
357
358         Reviewed by Darin Adler.
359
360         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
361         * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Removed.
362         * DumpRenderTree/TestNetscapePlugIn/main.cpp:
363         (NPP_New):
364         (NPP_HandleEvent):
365         (handleEventCarbon): Deleted.
366
367 2019-03-02  Ross Kirsling  <ross.kirsling@sony.com>
368
369         Unreviewed follow-up to r242292. Keep EXPECT_STREQ in tests per Darin's request.
370
371         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
372         (TestWebKitAPI::TEST):
373
374 2019-03-01  Darin Adler  <darin@apple.com>
375
376         Finish removing String::format
377         https://bugs.webkit.org/show_bug.cgi?id=194893
378
379         Reviewed by Daniel Bates.
380 '
381         * Tools/TestWebKitAPI/Tests/WTF/StringConcatenate.cpp: Add tests for pad().
382
383 2019-03-01  Alex Christensen  <achristensen@webkit.org>
384
385         Add setters on WKWebsiteDataStore for sourceApplicationBundleIdentifier and sourceApplicationSecondaryIdentifier
386         https://bugs.webkit.org/show_bug.cgi?id=195229
387         <rdar://problem/48520362>
388
389         Reviewed by Chris Dumez.
390
391         * TestWebKitAPI/Tests/WebKitCocoa/WebsiteDataStoreCustomPaths.mm:
392         (TEST):
393
394 2019-03-01  Simon Fraser  <simon.fraser@apple.com>
395
396         Add a system trace scope for event region building
397         https://bugs.webkit.org/show_bug.cgi?id=195226
398
399         Reviewed by Jon Lee.
400
401         This trace scope measures the time spend converting element rects into Region objects,
402         which can be large on some pages.
403
404         The value for "Display Refresh Dispatch to main thread" was wrong and I fixed it.
405
406         * Tracing/SystemTracePoints.plist:
407
408 2019-03-01  Ross Kirsling  <ross.kirsling@sony.com>
409
410         EnvironmentUtilities::stripValuesEndingWithString isn't thread-safe
411         https://bugs.webkit.org/show_bug.cgi?id=194612
412
413         Reviewed by Alex Christensen.
414
415         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
416         Just test the new string-processing function and don't touch the actual environment.
417         (Test cases are all as before, but based on operator== instead of strcmp.)
418
419 2019-03-01  Aakash Jain  <aakash_jain@apple.com>
420
421         [ews-app] Update primary keys for handling multiple Buildbot instances
422         https://bugs.webkit.org/show_bug.cgi?id=195120
423
424         Reviewed by Stephanie Lewis.
425
426         Use a new primary key uid for build and step tables. Previous primary keys build_id and step_id
427         were not enough to handle multiple buildbot instances. This new primary key uid would be generated
428         by a combination of buildbot_instance_id and current primary key. e.g.: buildbot_instance_id + build_id
429
430         * BuildSlaveSupport/ews-app/ews/models/build.py: Added new primary key uid.
431         * BuildSlaveSupport/ews-app/ews/models/step.py: Ditto.
432         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Generate uid and instance_id.
433         * BuildSlaveSupport/ews-app/ews/views/results.py: Updated to receive hostname in events.
434         * BuildSlaveSupport/ews-build/events.py: Send hostname along-with events.
435         * BuildSlaveSupport/ews-build/master.cfg: Ditto.
436
437 2019-03-01  Don Olmstead  <don.olmstead@sony.com>
438
439         [WinCairo] Enable service worker
440         https://bugs.webkit.org/show_bug.cgi?id=188318
441
442         Reviewed by Youenn Fablet.
443
444         * DumpRenderTree/DumpRenderTreePrefix.h:
445         * TestWebKitAPI/PlatformWin.cmake:
446         * TestWebKitAPI/win/TestWebKitAPIPrefix.h:
447         * WebKitTestRunner/InjectedBundle/win/TestRunnerInjectedBundlePrefix.h:
448         * WebKitTestRunner/WebKitTestRunnerPrefix.h:
449
450 2019-03-01  Justin Fan  <justin_fan@apple.com>
451
452         [Web GPU] 32-bit builds broken by attempt to disable WebGPU on 32-bit
453         https://bugs.webkit.org/show_bug.cgi?id=195191
454
455         Rubber-stamped by Dean Jackson.
456
457         Dropping support for 32-bit entirely, so I'm intentionally leaving 32-bit broken.
458
459         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
460
461 2019-03-01  Yusuke Suzuki  <ysuzuki@apple.com>
462
463         Unreviewed, fix lldb webkitpy tests
464         https://bugs.webkit.org/show_bug.cgi?id=194375
465
466         Since we changed the value of Is8Bit flag in StringImpl, we change lldb webkitpy tests accordingly.
467
468         * lldb/lldb_webkit.py:
469         (WTFStringImplProvider.is_8bit):
470
471 2019-02-28  David Quesada  <david_quesada@apple.com>
472
473         Expose APINavigationAction.shouldPerformDownload() on WKNavigationAction
474         https://bugs.webkit.org/show_bug.cgi?id=195121
475         rdar://problem/48450302
476
477         Reviewed by Alex Christensen.
478
479         Add API tests for -WKNavigationAction._shouldPerformDownload in various
480         configurations where the 'download' attribute is absent, blank, or populated
481         with a filename, and where the anchor element is same-origin or cross-origin
482         (meaning the 'download' attribute shouldn't be honored).
483
484         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
485         * TestWebKitAPI/Tests/WebKitCocoa/NavigationAction.mm: Added.
486         (-[NavigationActionTestDelegate init]):
487         (-[NavigationActionTestDelegate navigationAction]):
488         (-[NavigationActionTestDelegate waitForNavigationActionCallback]):
489         (-[NavigationActionTestDelegate waitForDidFinishNavigation]):
490         (-[NavigationActionTestDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
491         (-[NavigationActionTestDelegate webView:didFinishNavigation:]):
492         (TEST):
493
494 2019-02-28  Antoine Quint  <graouts@apple.com>
495
496         Enable the Pointer Events runtime flag by default
497         https://bugs.webkit.org/show_bug.cgi?id=195156
498
499         Reviewed by Dean Jackson.
500
501         * DumpRenderTree/mac/DumpRenderTree.mm:
502         (enableExperimentalFeatures):
503
504 2019-02-28  Wenson Hsieh  <wenson_hsieh@apple.com>
505
506         Several PasteImage API tests are flaky
507         https://bugs.webkit.org/show_bug.cgi?id=195160
508
509         Reviewed by Tim Horton.
510
511         Some of these tests, such as PasteTIFFImage, don't wait for the inserted image element to finish loading before
512         querying the image element's size; a few other tests, such as PastePNGFile, are racy since they may begin
513         listening for a "load" event after image load is already complete.
514
515         To address this, make these tests first register a "load" event handler, then run script to insert an image
516         element into the document, and finally wait until the load event is observed before checking image size.
517
518         * TestWebKitAPI/Tests/WebKitCocoa/PasteImage.mm:
519
520 2019-02-28  Chris Dumez  <cdumez@apple.com>
521
522         Flaky API Test: TestWebKitAPI.ProcessSwap.PageZoomLevelAfterSwap
523         https://bugs.webkit.org/show_bug.cgi?id=195107
524
525         Reviewed by Alex Christensen.
526
527         Give some time for the zoom level to get restored.
528
529         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
530
531 2019-02-28  Sihui Liu  <sihui_liu@apple.com>
532
533         Stop using legacy IDB path by default when creating WebProcessPool from websiteDataStore
534         https://bugs.webkit.org/show_bug.cgi?id=194958
535
536         Reviewed by Geoffrey Garen.
537
538         * TestWebKitAPI/Tests/WebKitCocoa/IndexedDBUserDelete.mm:
539         (TEST):
540
541 2019-02-28  Aakash Jain  <aakash_jain@apple.com>
542
543         [ews-app] Update method to save build to handle builder_display_name
544         https://bugs.webkit.org/show_bug.cgi?id=195047
545
546         Reviewed by Dewei Zhu.
547
548         * BuildSlaveSupport/ews-app/ews/models/build.py: Updated to handle builder_name and builder_display_name.
549         * BuildSlaveSupport/ews-app/ews/views/results.py: Ditto.
550
551 2019-02-28  Justin Fan  <justin_fan@apple.com>
552
553         [Web GPU] Enable Web GPU only on 64-bit
554         https://bugs.webkit.org/show_bug.cgi?id=195139
555
556         Because Metal is only supported on 64 bit apps.
557
558         Unreviewed build fix.
559
560         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
561
562 2019-02-27  Youenn Fablet  <youenn@apple.com>
563
564         Flaky API Test: TestWebKitAPI.ServiceWorkers.ServiceWorkerAndCacheStorageSpecificDirectories
565         https://bugs.webkit.org/show_bug.cgi?id=194959
566
567         Reviewed by Chris Dumez.
568
569         Spin loop until getting the condition to remove flakiness.
570
571         * TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:
572
573 2019-02-27  Aakash Jain  <aakash_jain@apple.com>
574
575         [ews-build] Buildbot should include builder_display_name in the build events
576         https://bugs.webkit.org/show_bug.cgi?id=195045
577
578         Reviewed by Dewei Zhu.
579
580         * BuildSlaveSupport/ews-build/events.py:
581         (Events.buildStarted): Included builder_display_name in event data. Also renamed
582         buildername to builder_name to be consistent in naming style.
583         (Events.buildFinished): Ditto.
584
585 2019-02-27  Chris Dumez  <cdumez@apple.com>
586
587         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage
588         https://bugs.webkit.org/show_bug.cgi?id=194480
589
590         Reviewed by Brady Eidson.
591
592         Update existing API test to make it more likely to reproduce the issue.
593
594         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
595
596 2019-02-27  Brady Eidson  <beidson@apple.com>
597
598         Universal links from Google search results pages don't open the app.
599         <rdar://problem/46887179> and https://bugs.webkit.org/show_bug.cgi?id=195126
600
601         Reviewed by Geoffrey Garen.
602
603         * TestWebKitAPI/Tests/WebKitCocoa/ShouldOpenExternalURLsInNewWindowActions.mm:
604         * TestWebKitAPI/cocoa/TestNavigationDelegate.h:
605         * TestWebKitAPI/cocoa/TestNavigationDelegate.mm:
606         (-[TestNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
607
608 2019-02-27  Chris Dumez  <cdumez@apple.com>
609
610         Flaky API Test: TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses
611         https://bugs.webkit.org/show_bug.cgi?id=195102
612
613         Reviewed by Geoffrey Garen.
614
615         If the number of processes is not yet what we expect, wait a bit and check again to give
616         processes some time to exit.
617
618         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
619
620 2019-02-27  Chris Dumez  <cdumez@apple.com>
621
622         Flaky API Test: TestWebKitAPI.ProcessSwap.NavigateToDataURLThenBack
623         https://bugs.webkit.org/show_bug.cgi?id=194545
624
625         Reviewed by Brady Eidson.
626
627         Make sure the test navigates forward and then back only once. Previously, navigating
628         back would trigger a navigation again in a timer.
629
630         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
631
632 2019-02-13  Ryan Haddad  <ryanhaddad@apple.com>
633
634         High Sierra Debug JSC test queue should use faster hardware
635         https://bugs.webkit.org/show_bug.cgi?id=194603
636
637         Rubber-stamped by Alexey Proskuryakov.
638
639         Adjust queues to free up faster hardware for use on the High Sierra Debug JSC queue.
640
641         * BuildSlaveSupport/build.webkit.org-config/config.json:
642         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
643         (BubbleQueueServer):
644         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
645         (WebKitBuildbot):
646         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py:
647         * QueueStatusServer/config/queues.py:
648         * Scripts/webkitpy/common/config/ews.json:
649         * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
650         (test_ews_name):
651
652 2019-02-27  John Wilander  <wilander@apple.com>
653
654         Adopt WebCore::RegistrableDomain in WebCore::ResourceLoadStatistics and WebKit::NetworkProcessProxy
655         https://bugs.webkit.org/show_bug.cgi?id=195071
656         <rdar://problem/48417690>
657
658         Reviewed by Alex Christensen and Brent Fulgham.
659
660         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
661         (TestWebKitAPI::createURL):
662             Convenience function.
663         (TestWebKitAPI::TEST):
664             WebCore::AdClickAttribution now takes a URL when creating Source and
665             Destination.
666         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp:
667         (TestWebKitAPI::TEST):
668             WebCore::AdClickAttribution now takes a URL when creating Source and
669             Destination.
670
671 2019-02-27  Antoine Quint  <graouts@apple.com>
672
673         Support Pointer Events on macOS
674         https://bugs.webkit.org/show_bug.cgi?id=195008
675         <rdar://problem/47454419>
676
677         Reviewed by Dean Jackson.
678
679         * DumpRenderTree/mac/DumpRenderTree.mm:
680         (enableExperimentalFeatures): Enable the PointerEvents runtime feature in DumpRenderTree such that tests targeting WK1 may test the Pointer Events feature.
681         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
682
683 2019-02-26  Mark Lam  <mark.lam@apple.com>
684
685         Remove remaining poisoning code.
686         https://bugs.webkit.org/show_bug.cgi?id=194138
687
688         Reviewed by Saam Barati.
689
690         * TestWebKitAPI/CMakeLists.txt:
691         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
692         * TestWebKitAPI/Tests/WTF/Poisoned.cpp: Removed.
693         * TestWebKitAPI/Tests/WTF/PoisonedRef.cpp: Removed.
694         * TestWebKitAPI/Tests/WTF/PoisonedRefPtr.cpp: Removed.
695         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp: Removed.
696         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp: Removed.
697         * TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp: Removed.
698
699 2019-02-26  Alex Christensen  <achristensen@webkit.org>
700
701         Move ephemeral local storage from WebProcess to UIProcess
702         https://bugs.webkit.org/show_bug.cgi?id=195074
703         <rdar://problem/47937975>
704
705         Reviewed by Geoff Garen.
706
707         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
708
709 2019-02-20  Jer Noble  <jer.noble@apple.com>
710
711         [Cocoa] Media elements will restart network buffering just before suspending
712         https://bugs.webkit.org/show_bug.cgi?id=193691
713
714         Reviewed by Eric Carlson.
715
716         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
717         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
718         (TEST):
719
720 2019-02-26  Takashi Komori  <Takashi.Komori@sony.com>
721
722         [Curl] Load HTTP body of 401 response when AuthenticationChange is cancelled.
723         https://bugs.webkit.org/show_bug.cgi?id=191652
724
725         Reviewed by Alex Christensen.
726
727         Fix WinCairo MiniBrowser behavior of authentication dialog.
728
729         * MiniBrowser/win/WebKitBrowserWindow.cpp:
730         (WebKitBrowserWindow::didReceiveAuthenticationChallenge):
731
732 2019-02-26  Youenn Fablet  <youenn@apple.com>
733
734         WebPageProxy should nullify m_userMediaPermissionRequestManager after resetting the media state
735         https://bugs.webkit.org/show_bug.cgi?id=195028
736         <rdar://problem/48243733>
737
738         Reviewed by Eric Carlson.
739
740         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
741
742 2019-02-26  Philippe Normand  <pnormand@igalia.com>
743
744         [WPE] Add API for webview background color configuration
745         https://bugs.webkit.org/show_bug.cgi?id=192305
746
747         Reviewed by Michael Catanzaro.
748
749         * MiniBrowser/wpe/main.cpp:
750         (main): Add a new option to configure the webview background
751         color. Example: --bg-color=transparent.
752         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitWebView.cpp:
753         (testWebViewBackgroundColor): Enable background color API tests for WPE.
754         (beforeAll): Ditto.
755
756 2019-02-25  Yongjun Zhang  <yongjun_zhang@apple.com>
757
758         scalableNativeWebpageParameters() is not preserved on new page navigation.
759         https://bugs.webkit.org/show_bug.cgi?id=194892
760         <rdar://problem/47538280>
761
762         Reviewed by Wenson Hsieh.
763         
764         Allow UIScriptController to set WKWebView's _allowsViewportShrinkToFit property with a new `setAllowsViewportShrinkToFit` method.
765
766         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
767         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
768         * DumpRenderTree/mac/UIScriptControllerMac.mm:
769         (WTR::UIScriptController::allowsViewportShrinkToFit):
770         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
771         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
772         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
773         * TestRunnerShared/UIScriptContext/UIScriptController.h:
774         * WebKitTestRunner/UIScriptControllerCocoa.mm:
775         (WTR::UIScriptController::setAllowsViewportShrinkToFit):
776
777 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
778
779         [ews-app] Add model for handling multiple Buildbot instances
780         https://bugs.webkit.org/show_bug.cgi?id=194863
781
782         Reviewed by Stephanie Lewis.
783
784         * BuildSlaveSupport/ews-app/ews/models/buildbotinstance.py: Added.
785
786 2019-02-25  Aakash Jain  <aakash_jain@apple.com>
787
788         [ews-app] Remove BuilderMapping table
789         https://bugs.webkit.org/show_bug.cgi?id=194961
790
791         Reviewed by Stephanie Lewis.
792
793         Store builder name directly in build table, instead of having a separate
794         table for it.
795
796         * BuildSlaveSupport/ews-app/ews/models/__init__.py:
797         * BuildSlaveSupport/ews-app/ews/models/build.py:
798         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py: Removed.
799         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
800
801 2019-02-25  John Wilander  <wilander@apple.com>
802
803         Introduce and adopt new class RegistrableDomain for eTLD+1
804         https://bugs.webkit.org/show_bug.cgi?id=194791
805         <rdar://problem/48179240>
806
807         Reviewed by Alex Christensen, Fujii Hironori, and Brent Fulgham.
808
809         This patch adds an API test and replaces two instances of
810         "TopPrivatelyOwnedDomains" with "RegistrableDomains" in message names.
811
812         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
813         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
814         (TestWebKitAPI::TEST):
815             Changed two strings to make sure the registrable domains are still considered
816             invalid and pass the test.
817         * TestWebKitAPI/Tests/WebCore/RegistrableDomain.cpp: Added.
818         (TestWebKitAPI::TEST):
819         * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
820         (WTR::InjectedBundle::didReceiveMessageToPage):
821
822 2019-02-25  Adrian Perez de Castro  <aperez@igalia.com>
823
824         [WPE] Bump WPEBackend-fdo requirement to API version 1.0
825         https://bugs.webkit.org/show_bug.cgi?id=195001
826
827         Reviewed by Carlos Garcia Campos.
828
829         API version 1.0 always includes the functionality previously guarded with
830         WPE_BACKEND_CHECK_VERSION(): remove the guards and always use the new functions
831         unconditionally.
832
833         * TestWebKitAPI/glib/WebKitGLib/TestMain.h:
834         (Test::createWebViewBackend): Remove usage of WPE_BACKEND_CHECK_VERSION().
835         * TestWebKitAPI/glib/WebKitGLib/wpe/WebViewTestWPE.cpp:
836         (WebViewTest::showInWindow): Ditto.
837         (WebViewTest::hideView): Ditto.
838         * wpe/backends/HeadlessViewBackend.cpp:
839         (WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend): Ditto.
840         * wpe/backends/ViewBackend.cpp:
841         (WPEToolingBackends::ViewBackend::ViewBackend): Use libWPEBackend-fdo-1.0 as library name.
842         * wpe/backends/WindowViewBackend.cpp:
843         (WPEToolingBackends::WindowViewBackend::WindowViewBackend): Remove usage of
844         WPE_BACKEND_CHECK_VERSION().
845         * wpe/jhbuild.modules: Build a version WPEBackend-fdo with the updated API version.
846
847 2019-02-25  Thibault Saunier  <tsaunier@igalia.com>
848
849         [Flatpak] Add support for flatpak > 1.1.2
850         https://bugs.webkit.org/show_bug.cgi?id=194088
851
852         Flatpak 1.2 is now out so we need to support that
853         version now.
854
855         Reviewed by Michael Catanzaro.
856
857         * flatpak/flatpakutils.py:
858         (check_flatpak):
859         (FlatpakPackages.__init__):
860         (FlatpakPackages.__detect_packages):
861         (FlatpakPackages.__detect_packages.in):
862         (FlatpakRepos.update):
863
864 2019-02-25  Zan Dobersek  <zdobersek@igalia.com>
865
866         [WPE] Bump WPEBackend-fdo Jhbuild package to latest changes
867         https://bugs.webkit.org/show_bug.cgi?id=194998
868
869         Reviewed by Carlos Garcia Campos.
870
871         * wpe/jhbuild.modules: Bump the WPEBackend-fdo package, converting it
872         to a Git checkout and using the latest commit containing various fixes
873         and improvements.
874
875 2019-02-24  Michael Catanzaro  <mcatanzaro@igalia.com>
876
877         [WPE][GTK] Remove user agent quirk for washingtonpost.com
878         https://bugs.webkit.org/show_bug.cgi?id=194981
879
880         Reviewed by Žan Doberšek.
881
882         * TestWebKitAPI/Tests/WebCore/UserAgentQuirks.cpp:
883         (TestWebKitAPI::TEST):
884
885 2019-02-23  Keith Miller  <keith_miller@apple.com>
886
887         Add new mac target numbers
888         https://bugs.webkit.org/show_bug.cgi?id=194955
889
890         Reviewed by Tim Horton.
891
892         * DumpRenderTree/mac/Configurations/Base.xcconfig:
893         * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
894         * MiniBrowser/Configurations/Base.xcconfig:
895         * TestWebKitAPI/Configurations/Base.xcconfig:
896         * WebKitTestRunner/Configurations/Base.xcconfig:
897
898 2019-02-22  Basuke Suzuki  <basuke.suzuki@sony.com>
899
900         [WinCairo] Enable wk1/wk2 suffix for platform search path.
901         https://bugs.webkit.org/show_bug.cgi?id=194846
902
903         Reviewed by Don Olmstead.
904
905         Added _search_paths() and _port_specific_expectations_files() for
906         WinCairoPort.
907
908         * Scripts/webkitpy/port/win.py:
909         (WinCairoPort.default_baseline_search_path):
910         (WinCairoPort):
911         (WinCairoPort._port_specific_expectations_files):
912         (WinCairoPort._search_paths):
913
914 2019-02-22  Tim Horton  <timothy_horton@apple.com>
915
916         ProcessSwap.PageOverlayLayerPersistence fails on iOS and in debug builds
917         https://bugs.webkit.org/show_bug.cgi?id=194963
918
919         Reviewed by Dean Jackson.
920
921         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
922         Do a `contains` check instead of `equals`, because in debug builds we
923         put the GraphicsLayer pointer in a prefix.
924
925 2019-02-22  Wenson Hsieh  <wenson_hsieh@apple.com>
926
927         [iOS] Callout menu overlaps in-page controls when editing a comment in github.com's issue tracker
928         https://bugs.webkit.org/show_bug.cgi?id=194873
929         <rdar://problem/46701974>
930
931         Reviewed by Tim Horton.
932
933         Add a couple of UIScriptController methods to make callout menu testing on iOS easier (see below).
934
935         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
936         (WTR::UIScriptController::menuRect const):
937         (WTR::UIScriptController::isShowingMenu const):
938         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
939         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
940         (WTR::UIScriptController::menuRect const):
941
942         Add a function to query the bounds of the callout menu in content coordinates.
943
944         (WTR::UIScriptController::isShowingMenu const):
945
946         Add a function to query whether the callout menu is shown (i.e., has finished its appearance animation).
947
948         * TestRunnerShared/UIScriptContext/UIScriptController.h:
949         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
950         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
951         (WTR::UIScriptController::rectForMenuAction const):
952         (WTR::UIScriptController::menuRect const):
953         (WTR::UIScriptController::isShowingMenu const):
954         (WTR::findViewInHierarchyOfType): Deleted.
955
956 2019-02-22  Chris Dumez  <cdumez@apple.com>
957
958         Regression(PSON) Unable to preview password-protected documents on iCloud.com
959         https://bugs.webkit.org/show_bug.cgi?id=194954
960         <rdar://problem/48127957>
961
962         Reviewed by Alex Christensen.
963
964         Add API test coverage.
965
966         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
967         (-[PSONNavigationDelegate _webViewDidRequestPasswordForQuickLookDocument:]):
968         (-[PSONNavigationDelegate _webView:didStartLoadForQuickLookDocumentInMainFrameWithFileName:uti:]):
969         (-[PSONNavigationDelegate _webView:didFinishLoadForQuickLookDocumentInMainFrame:]):
970
971 2019-02-22  Chris Dumez  <cdumez@apple.com>
972
973         REGRESSION(PSON) Scroll position is sometimes not restored on history navigation
974         https://bugs.webkit.org/show_bug.cgi?id=194924
975         <rdar://problem/48216125>
976
977         Reviewed by Geoffrey Garen.
978
979         Add API test coverage.
980
981         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
982
983 2019-02-22  Chris Dumez  <cdumez@apple.com>
984
985         Unreviewed, disable API test added in r241928 on iOS.
986
987         The cache is not enabled on devices with less than 3GB of RAM.
988
989         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
990
991 2019-02-21  Simon Fraser  <simon.fraser@apple.com>
992
993         Hardcode Visual Viewports on everywhere except iOS WK1
994         https://bugs.webkit.org/show_bug.cgi?id=194928
995
996         Reviewed by Zalan Bujtas.
997
998         Remove the WK1 and WK2 preferences and MiniBrowser menu item for "visual viewports",
999         change the default value of the Setting to 'true', and hardcode WebView on iOS to
1000         set it to false. The setting has shipped for several years and there's no need to turn
1001         it off now.
1002
1003         Similarly, disable the "Visual Viewport API" on iOS WK1, since it makes no sense if
1004         Visual Viewports are not enabled.
1005         
1006         Remove the "visualViewportEnabled" flag and unused code paths from scrolling tree code
1007         that only runs in WK2
1008
1009         * MiniBrowser/mac/SettingsController.h:
1010         * MiniBrowser/mac/SettingsController.m:
1011         (-[SettingsController init]):
1012         (-[SettingsController _populateMenu]):
1013         (-[SettingsController validateMenuItem:]):
1014         (-[SettingsController visualViewportEnabled]): Deleted.
1015         (-[SettingsController toggleVisualViewportEnabled:]): Deleted.
1016         * MiniBrowser/mac/WK1BrowserWindowController.m:
1017         (-[WK1BrowserWindowController didChangeSettings]):
1018         * MiniBrowser/mac/WK2BrowserWindowController.m:
1019         (-[WK2BrowserWindowController didChangeSettings]):
1020
1021 2019-02-21  Ryosuke Niwa  <rniwa@webkit.org>
1022
1023         Discard cached processes when clearing website data store
1024         https://bugs.webkit.org/show_bug.cgi?id=194894
1025
1026         Reviewed by Chris Dumez.
1027
1028         Added a test case.
1029
1030         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1031         (TestWebKitAPI.ProcessSwap.NumberOfCachedProcesses): Added.
1032
1033 2019-02-21  Alex Christensen  <achristensen@webkit.org>
1034
1035         Clicking "Go Back" on a safe browsing warning before a WKWebView has loaded any page should request to close the WKWebView
1036         https://bugs.webkit.org/show_bug.cgi?id=194914
1037         <rdar://problem/47586889>
1038
1039         Reviewed by Geoffrey Garen.
1040
1041         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1042         (-[SafeBrowsingNavigationDelegate webViewDidClose:]):
1043         (TEST):
1044         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]): Deleted.
1045
1046 2019-02-21  David Kilzer  <ddkilzer@apple.com>
1047
1048         Leak of CFErrorRef objects (1.92 Kbytes) in com.apple.WebKit.WebContent.Development running WebKit layout tests on iOS Simulator
1049         <https://webkit.org/b/194761>
1050
1051         Reviewed by Myles Maxfield.
1052
1053         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
1054         (WTR::activateSystemCoreWebFonts): Log `error` to console if
1055         CTFontManagerRegisterFontsForURL() fails (macOS only).  Update
1056         to use ARC-compliant cast.
1057         (WTR::activateFonts): Change `0` to `nullptr`.  Update to use
1058         ARC-compliant cast.
1059         (WTR::installFakeHelvetica): Log `error` to console if
1060         CTFontManagerRegisterFontsForURL() fails, but only on supported
1061         platforms (macOS Mojave/iOS 12 and newer, not iOS Simulator).
1062         Call CFRelease() on `error` to fix the leak.  Update to use
1063         ARC-compliant cast.
1064         (WTR::uninstallFakeHelvetica): Update to use ARC-compliant
1065         cast.
1066
1067 2019-02-21  Chris Dumez  <cdumez@apple.com>
1068
1069         Flaky API Test: TestWebKitAPI.ProcessSwap.SuspendedPageLimit
1070         https://bugs.webkit.org/show_bug.cgi?id=194481
1071
1072         Reviewed by Alex Christensen.
1073
1074         Give the processes a chance to shutdown and wait until we reached the expected number
1075         of processes.
1076
1077         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1078
1079 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1080
1081         Fix the macOS build
1082
1083         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1084
1085 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1086
1087         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1088
1089         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1090         I am a backwards.
1091
1092 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1093
1094         Fix ProcessSwap.PageOverlayLayerPersistence on macOS
1095
1096         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1097         We can't find the UI-side layer on macOS because we don't use UI-side compositing.
1098         We could force on UI-side compositing, but I feel like the test might be more
1099         valuable exercising the normal path on each platform (though the original
1100         bug was also UI-side specific). Though we can't validate that the overlay
1101         layer was installed successfully, there are layout tests that do that.
1102
1103 2019-02-21  Tim Horton  <timothy_horton@apple.com>
1104
1105         Crash under RemoteLayerTreePropertyApplier::applyProperties when reattaching to old process
1106         https://bugs.webkit.org/show_bug.cgi?id=194845
1107         <rdar://problem/47944579>
1108
1109         Reviewed by Antti Koivisto.
1110
1111         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1112         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1113
1114 2019-02-21  Zalan Bujtas  <zalan@apple.com>
1115
1116         [LFC][Floats] Add support for placing formatting roots in-between floats.
1117         https://bugs.webkit.org/show_bug.cgi?id=194902
1118
1119         Reviewed by Antti Koivisto.
1120
1121         * LayoutReloaded/misc/LFC-passing-tests.txt:
1122
1123 2019-02-21  Adrian Perez de Castro  <aperez@igalia.com>
1124
1125         [WPE] Do not hardcode WPEBackend-fdo library name for linking tests
1126         https://bugs.webkit.org/show_bug.cgi?id=194901
1127
1128         Unreviewed build fix.
1129
1130         * TestWebKitAPI/PlatformWPE.cmake: Set TestWebKitAPIBase to be linked
1131         against the detected ${WPEBACKEND_FDO_LIBRARIES} instead of hardcoding
1132         WPEBackend-fdo-0.1 as library name.
1133
1134 2019-02-21  Rob Buis  <rbuis@igalia.com>
1135
1136         Update MIME type parser
1137         https://bugs.webkit.org/show_bug.cgi?id=180526
1138
1139         Reviewed by Darin Adler.
1140
1141         Add tests involving leading and trailing whitespace, non-token
1142         characters and quoted strings.
1143
1144         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
1145         (TestWebKitAPI::TEST):
1146
1147 2019-02-20  Don Olmstead  <don.olmstead@sony.com>
1148
1149         [CMake][Win] Only build DumpRenderTree when WebKit Legacy is enabled
1150         https://bugs.webkit.org/show_bug.cgi?id=194884
1151
1152         Reviewed by Michael Catanzaro.
1153
1154         * PlatformWin.cmake:
1155
1156 2019-02-20  Chris Dumez  <cdumez@apple.com>
1157
1158         Add API test for <rdar://problem/47471222>
1159         https://bugs.webkit.org/show_bug.cgi?id=194847
1160
1161         Reviewed by Alex Christensen.
1162
1163         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1164
1165 2019-02-20  Chris Dumez  <cdumez@apple.com>
1166
1167         Regression(PSON) "Reload without content extensions" does not work when the main resource is blocked
1168         https://bugs.webkit.org/show_bug.cgi?id=194872
1169         <rdar://problem/47924500>
1170
1171         Reviewed by Alex Christensen.
1172
1173         Add API test coverage.
1174
1175         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1176
1177 2019-02-20  Jer Noble  <jer.noble@apple.com>
1178
1179         Add a git utility method that allows the caller to determine if a specific commitish is within a specified range of commits.
1180         https://bugs.webkit.org/show_bug.cgi?id=191332
1181
1182         Reviewed by Dean Jackson.
1183
1184         * Scripts/git-is-in-range: Added.
1185
1186 2019-02-20  Andy Estes  <aestes@apple.com>
1187
1188         [Xcode] Add SDKVariant.xcconfig to various Xcode projects
1189         https://bugs.webkit.org/show_bug.cgi?id=194869
1190
1191         Rubber-stamped by Jer Noble.
1192
1193         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1194         * ImageDiff/ImageDiff.xcodeproj/project.pbxproj:
1195         * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
1196         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
1197         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1198         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
1199
1200 2019-02-20  Chris Dumez  <cdumez@apple.com>
1201
1202         Regression(PSON) Crash under WebKit::WebPageProxy::decidePolicyForNavigationActionSync
1203         https://bugs.webkit.org/show_bug.cgi?id=194857
1204         <rdar://problem/47759323>
1205
1206         Reviewed by Alex Christensen.
1207
1208         Add API test coverage.
1209
1210         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1211
1212 2019-02-20  Chris Dumez  <cdumez@apple.com>
1213
1214         [WKTR] Avoid starting new NetworkProcesses unnecessarily when running the layout tests
1215         https://bugs.webkit.org/show_bug.cgi?id=194829
1216         <rdar://problem/47889906>
1217
1218         Reviewed by Alexey Proskuryakov.
1219
1220         Every time the TestOptions were changing we were creating both a new Web view and
1221         a new WKContext, which would start a new Network process. In most cases, we only
1222         need to contruct a new Web view and we do can keep reusing the same WKContext.
1223         This patch implements this optimization and thus avoids spinning a lot of new
1224         Network processes while running the layout tests.
1225
1226         * WebKitTestRunner/TestController.cpp:
1227         (WTR::TestController::generateContextConfiguration const):
1228         (WTR::TestController::generatePageConfiguration):
1229         (WTR::TestController::createWebViewWithOptions):
1230         (WTR::TestController::resetPreferencesToConsistentValues):
1231         (WTR::updateTestOptionsFromTestHeader):
1232         * WebKitTestRunner/TestController.h:
1233         * WebKitTestRunner/TestOptions.h:
1234         (WTR::TestOptions::ContextOptions::hasSameInitializationOptions const):
1235         (WTR::TestOptions::ContextOptions::shouldEnableProcessSwapOnNavigation const):
1236         (WTR::TestOptions::hasSameInitializationOptions const):
1237         (WTR::TestOptions::shouldEnableProcessSwapOnNavigation const): Deleted.
1238         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1239         (WTR::TestController::platformAddTestOptions const):
1240
1241 2019-02-20  Adrian Perez de Castro  <aperez@igalia.com>
1242
1243         [WPE][GTK] Enable support for CONTENT_EXTENSIONS
1244         https://bugs.webkit.org/show_bug.cgi?id=167941
1245
1246         Reviewed by Carlos Garcia Campos.
1247
1248         * MiniBrowser/gtk/main.c:
1249         (filterSavedCallback): Added.
1250         (main): Support loading a JSON rule set file for content filtering.
1251         * MiniBrowser/wpe/main.cpp:
1252         (filterSavedCallback): Added.
1253         (main): Support loading a JSON rule set file for content filtering.
1254         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentFilterStore.cpp: Added.
1255         (WTF::refGPtr): Added locally for WebKitUserContentFilter, as it would not be used anywhere else.
1256         (WTF::derefGPtr): Ditto.
1257         (testEmptyStore):
1258         (testSaveInvalidFilter):
1259         (testSaveLoadFilter):
1260         (testSavedFilterIdentifierMatch):
1261         (testRemoveFilter):
1262         (testSaveMultipleFilters):
1263         (testSaveFilterFromFile):
1264         (testFilterPersistence):
1265         (beforeAll):
1266         (afterAll):
1267         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitUserContentManager.cpp:
1268         (removeOldInjectedContentAndResetLists): Also reset content filters.
1269         (isCSSBlockedForURLAtPath): Added. Tests whether the test filter, which blocks a
1270         CSS style sheet, has blocked the load of the CSS by looking at the resulting style of
1271         the element affected by the style sheet.
1272         (getUserContentFilter): Added. Stores the test filter in a WebKitUserContentFilterStore
1273         and returns it to be used by tests.
1274         (testUserContentManagerContentFilter): Added. Tests whether adding and removing a filter
1275         from the WebKitUserContentManager results in the a CSS style sheet being blocked.
1276         (serverCallback): Add support for serving a CSS style sheet for testing.
1277         (beforeAll): Add call to testUserContentManagerContentFilter().
1278         * TestWebKitAPI/glib/CMakeLists.txt: Added TestWebKitUserContentFilterStore.
1279
1280 2019-02-19  Keith Rollin  <krollin@apple.com>
1281
1282         Add timing information to build output
1283         https://bugs.webkit.org/show_bug.cgi?id=194839
1284         <rdar://problem/48219609>
1285
1286         Reviewed by Alexey Proskuryakov.
1287
1288         Configure xcodebuild with -ShowBuildOperationDuration, causing it to
1289         emit each project's build time to its output. E.g.,
1290
1291             ** BUILD SUCCEEDED ** [0.132 sec]
1292
1293         * Scripts/webkitdirs.pm:
1294         (XcodeOptions):
1295
1296 2019-02-19  Truitt Savell  <tsavell@apple.com>
1297
1298         Unreviewed, rolling out r241784.
1299
1300         Broke all OpenSource builds.
1301
1302         Reverted changeset:
1303
1304         "Web Inspector: Improve ES6 Class instances in Heap Snapshot
1305         instances view"
1306         https://bugs.webkit.org/show_bug.cgi?id=172848
1307         https://trac.webkit.org/changeset/241784
1308
1309 2019-02-19  Zalan Bujtas  <zalan@apple.com>
1310
1311         [LFC][Floats] Remove redundant intersecting logic
1312         https://bugs.webkit.org/show_bug.cgi?id=194804
1313
1314         Reviewed by Antti Koivisto.
1315
1316         * LayoutReloaded/misc/LFC-passing-tests.txt:
1317
1318 2019-02-19  Dean Jackson  <dino@apple.com>
1319
1320         Clean-up output from generate-xcfilelists so it can be filtered
1321         https://bugs.webkit.org/show_bug.cgi?id=194795
1322
1323         Reviewed by Joseph Pecoraro (and Keith Rollin).
1324
1325         Replace the "..." with "GXCF:" in generate-xcfilelists output, and
1326         make a slight tweak to filter-build-webkit so such lines are marked
1327         as plain.
1328
1329         * Scripts/filter-build-webkit:
1330         * Scripts/generate-xcfilelists:
1331
1332 2019-02-19  Pablo Saavedra  <psaavedra@igalia.com>
1333
1334         pytest is not correctly auto-installed
1335         https://bugs.webkit.org/show_bug.cgi?id=194707
1336
1337         Reviewed by Carlos Garcia Campos.
1338
1339         * Scripts/webkitpy/thirdparty/__init__.py:
1340         (AutoinstallImportHook._install_pytest):
1341
1342 2019-02-18  Chris Dumez  <cdumez@apple.com>
1343
1344         REGRESSION (PSON): Can't access optumbank.com from myuhc.com
1345         https://bugs.webkit.org/show_bug.cgi?id=194797
1346         <rdar://problem/48055151>
1347
1348         Reviewed by Geoffrey Garen.
1349
1350         Add API test coverage.
1351
1352         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1353
1354 2019-02-18  Wenson Hsieh  <wenson_hsieh@apple.com>
1355
1356         [iOS] Support pasting item-provider-backed data on the pasteboard as attachment elements
1357         https://bugs.webkit.org/show_bug.cgi?id=194670
1358         <rdar://problem/39066529>
1359
1360         Reviewed by Tim Horton.
1361
1362         Remove code and tests for subresource URL replacement, and also add a new test to verify that copied data can be
1363         pasted in an editable area as attachment elements.
1364
1365         * TestWebKitAPI/Tests/WebKitCocoa/BundleEditingDelegatePlugIn.mm:
1366         (-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
1367         (-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:replacementURLForResource:mimeType:]): Deleted.
1368         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1369         (TestWebKitAPI::TEST):
1370         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
1371         (WTR::InjectedBundlePage::InjectedBundlePage):
1372
1373 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1374
1375         Fix API test after r241728
1376        ​https://bugs.webkit.org/show_bug.cgi?id=194723
1377
1378         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1379         (TEST):
1380         The test should check the default preference value, not make sure the preference is NO after setting it to YES :/
1381
1382 2019-02-18  Daniel Bates  <dabates@apple.com>
1383
1384         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
1385         https://bugs.webkit.org/show_bug.cgi?id=192824
1386         <rdar://problem/47100332>
1387
1388         Reviewed by Wenson Hsieh.
1389
1390         Fix a bug where the wrong usage code was used for F13 thru F24.
1391
1392         * WebKitTestRunner/ios/HIDEventGenerator.mm:
1393         (keyCodeForDOMFunctionKey):
1394
1395 2019-02-18  Tadeu Zagallo  <tzagallo@apple.com>
1396
1397         Bytecode cache should a have a boot-specific validation
1398         https://bugs.webkit.org/show_bug.cgi?id=194769
1399         <rdar://problem/48149509>
1400
1401         Reviewed by Keith Miller.
1402
1403         Add test for WTF::bootSessionUUIDString()
1404
1405         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1406         * TestWebKitAPI/Tests/WTF/UUID.cpp: Added.
1407         (TEST):
1408
1409 2019-02-18  Alex Christensen  <achristensen@webkit.org>
1410
1411         Disable safe browsing in WKWebView and remove its WKPreferences API
1412         https://bugs.webkit.org/show_bug.cgi?id=194723
1413         <rdar://problem/48122993>
1414
1415         Reviewed by Geoffrey Garen.
1416
1417         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1418         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
1419         (TEST):
1420         (safeBrowsingView):
1421         Make tests use SPI instead of API.
1422
1423 2019-02-17  Fujii Hironori  <Hironori.Fujii@sony.com>
1424
1425         Use dumpJSConsoleLogInStdErr=true webkit-test-runner option for non-imported tests instead of using DumpJSConsoleLogInStdErr expectation in TestExpectations
1426         https://bugs.webkit.org/show_bug.cgi?id=194586
1427
1428         Reviewed by Ross Kirsling.
1429
1430         * DumpRenderTree/win/DumpRenderTree.cpp:
1431         (runTest): Pass true to setDumpJSConsoleLogInStdErr if options.dumpJSConsoleLogInStdErr is true.
1432         * Scripts/webkitpy/port/driver.py:
1433         (Driver._command_from_driver_input): Convert Cygwin absolute path of tests to Windows path.
1434
1435 2019-02-17  David Kilzer  <ddkilzer@apple.com>
1436
1437         Unreviewed, rolling out r241620.
1438
1439         "Causes use-after-free crashes running layout tests with ASan and GuardMalloc."
1440         (Requested by ddkilzer on #webkit.)
1441
1442         Reverted changeset:
1443
1444         "[WTF] Add environment variable helpers"
1445         https://bugs.webkit.org/show_bug.cgi?id=192405
1446         https://trac.webkit.org/changeset/241620
1447
1448 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1449
1450         [LFC] RenderImage's default intrinsic size is 0.
1451         https://bugs.webkit.org/show_bug.cgi?id=194745
1452
1453         Reviewed by Antti Koivisto.
1454
1455         * LayoutReloaded/misc/LFC-passing-tests.txt:
1456
1457 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1458
1459         [LFC][BFC] Add support for block replaced intrinsic width.
1460         https://bugs.webkit.org/show_bug.cgi?id=194705
1461
1462         Reviewed by Simon Fraser.
1463
1464         * LayoutReloaded/misc/LFC-passing-tests.txt:
1465
1466 2019-02-16  Zalan Bujtas  <zalan@apple.com>
1467
1468         [LFC] Apply min/max width constraints to preferred width computation
1469         https://bugs.webkit.org/show_bug.cgi?id=194739
1470
1471         Reviewed by Simon Fraser.
1472
1473         * LayoutReloaded/misc/LFC-passing-tests.txt:
1474
1475 2019-02-15  Ross Kirsling  <ross.kirsling@sony.com>
1476
1477         [WTF] Add environment variable helpers
1478         https://bugs.webkit.org/show_bug.cgi?id=192405
1479
1480         Reviewed by Michael Catanzaro.
1481
1482         * DumpRenderTree/mac/DumpRenderTree.mm:
1483         (libraryPathForDumpRenderTree):
1484         * DumpRenderTree/win/DumpRenderTree.cpp:
1485         (libraryPathForDumpRenderTree):
1486         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1487         (setUpIOSLayoutTestCommunication):
1488         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1489         (beforeAll):
1490         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1491         (main):
1492         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1493         (WebKitTestBus::run):
1494         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1495         (WTR::getOutputDir):
1496         (WTR::initializeFontConfigSetting):
1497         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1498         (WTR::InjectedBundle::platformInitialize):
1499         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1500         (WTR::topLevelPath):
1501         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1502         (WTR::topLevelPath):
1503         (WTR::getOutputDir):
1504         (WTR::activateFonts):
1505         * WebKitTestRunner/TestController.cpp:
1506         (WTR::TestController::libraryPathForTesting):
1507         (WTR::TestController::generateContextConfiguration const):
1508         (WTR::TestController::generatePageConfiguration):
1509         (WTR::TestController::decideDestinationWithSuggestedFilename):
1510         (WTR::TestController::platformAdjustContext):
1511         * WebKitTestRunner/TestController.h:
1512         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1513         (WTR::TestController::cocoaPlatformInitialize):
1514         (WTR::TestController::platformAdjustContext):
1515         * WebKitTestRunner/gtk/main.cpp:
1516         (main):
1517         * WebKitTestRunner/mac/TestControllerMac.mm:
1518         (WTR::TestController::configureContentExtensionForTest):
1519         * WebKitTestRunner/wpe/main.cpp:
1520         (main):
1521         Utilize WTF::Environment where possible.
1522
1523 2019-02-15  Wenson Hsieh  <wenson_hsieh@apple.com>
1524
1525         [iOS] WKWebView callout bar is missing Change Writing Direction item
1526         https://bugs.webkit.org/show_bug.cgi?id=190015
1527         <rdar://problem/44810366>
1528
1529         Reviewed by Tim Horton.
1530
1531         Make an existing API test that exercises platform SPI to change the inline text writing direction run only on
1532         macOS, and add a new API test that uses similarly named SPI on iOS to change the base writing direction.
1533
1534         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewEditActions.mm:
1535         (TestWebKitAPI::TEST):
1536
1537 2019-02-15  Chris Dumez  <cdumez@apple.com>
1538
1539         Regression(PSON) Navigating quickly back and forth can lead to getting 'about:blank' in the backforward list
1540         https://bugs.webkit.org/show_bug.cgi?id=194717
1541         <rdar://problem/47884404>
1542
1543         Reviewed by Brady Eidson.
1544
1545         Add API test coverage.
1546
1547         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1548
1549 2019-02-15  Youenn Fablet  <youenn@apple.com>
1550
1551         Make navigator.mediaDevices SecureContext
1552         https://bugs.webkit.org/show_bug.cgi?id=194666
1553
1554         Reviewed by Eric Carlson.
1555
1556         * TestWebKitAPI/Tests/WebKitCocoa/UserMediaDisabled.mm:
1557         (MediaCaptureDisabledTest::loadTestAndWaitForMessage):
1558         (TEST_F):
1559
1560 2019-02-15  Brian Burg  <bburg@apple.com>
1561
1562         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1563         https://bugs.webkit.org/show_bug.cgi?id=194411
1564         <rdar://problem/47787614>
1565
1566         Reviewed by Joseph Pecoraro.
1567
1568         Remove unnecessary soft linking macro usage.
1569
1570         * DumpRenderTree/mac/TestRunnerMac.mm:
1571         (TestRunner::inspectorTestStubURL):
1572         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1573         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1574         (WTR::TestRunner::inspectorTestStubURL):
1575
1576 2019-02-15  Commit Queue  <commit-queue@webkit.org>
1577
1578         Unreviewed, rolling out r241559 and r241566.
1579         https://bugs.webkit.org/show_bug.cgi?id=194710
1580
1581         Causes layout test crashes under GuardMalloc (Requested by
1582         ryanhaddad on #webkit).
1583
1584         Reverted changesets:
1585
1586         "[WTF] Add environment variable helpers"
1587         https://bugs.webkit.org/show_bug.cgi?id=192405
1588         https://trac.webkit.org/changeset/241559
1589
1590         "Unreviewed build fix for WinCairo Debug after r241559."
1591         https://trac.webkit.org/changeset/241566
1592
1593 2019-02-15  Zalan Bujtas  <zalan@apple.com>
1594
1595         [LFC] Out-of-flow box is never a float box
1596         https://bugs.webkit.org/show_bug.cgi?id=194704
1597
1598         Reviewed by Antti Koivisto.
1599
1600         * LayoutReloaded/misc/LFC-passing-tests.txt:
1601
1602 2019-02-10  Darin Adler  <darin@apple.com>
1603
1604         Replace more uses of String::format with StringConcatenate (mostly non-Apple platform-specific cases)
1605         https://bugs.webkit.org/show_bug.cgi?id=194487
1606
1607         Reviewed by Daniel Bates.
1608
1609         * DumpRenderTree/win/DumpRenderTree.cpp:
1610         (applicationId): Use makeString instead of String::format.
1611         (main): Ditto.
1612         * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
1613         (TestWebKitAPI::Util::createURLForResource): Ditto.
1614         * WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
1615         (WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks): Ditto.
1616
1617         * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
1618         (WTR::attributeSetToString): Use StringBuilder functions directly instead of g_strconcat.
1619         (WTR::attributesOfElement): Use StringBuilder functions directly instead of String::format.
1620         (WTR::createStringWithAttributes): Use appendLiteral.
1621         (WTR::AccessibilityUIElement::helpText const): Ditto.
1622         (WTR::AccessibilityUIElement::attributedStringForRange): Use StringBuilder functions
1623         directly instead of using String::format.
1624         (WTR::AccessibilityUIElement::url): Use makeString instead of String::format.
1625         (WTR::stringAtOffset): Use StringBuilder::appendNumber instead of String::format.
1626
1627 2019-02-15  Truitt Savell  <tsavell@apple.com>
1628
1629         Unreviewed, rolling out r241564.
1630
1631         Caused 50+ Timeouts on Mac WK2, mostly in the http/ directory
1632
1633         Reverted changeset:
1634
1635         "[Mac] WebInspectorUI.framework does not need to be soft-
1636         linked anymore"
1637         https://bugs.webkit.org/show_bug.cgi?id=194411
1638         https://trac.webkit.org/changeset/241564
1639
1640 2019-02-15  Saam barati  <sbarati@apple.com>
1641
1642         [WebAssembly] Write a new register allocator for Air O0 and make BBQ use it
1643         https://bugs.webkit.org/show_bug.cgi?id=194036
1644
1645         Reviewed by Yusuke Suzuki.
1646
1647         * Scripts/run-jsc-stress-tests:
1648
1649 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1650
1651         Fix the build.
1652
1653         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1654         (WTR::UIScriptController::drawSquareInEditableImage):
1655         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1656         (TestWebKitAPI::drawSquareInEditableImage):
1657
1658 2019-02-14  Tim Horton  <timothy_horton@apple.com>
1659
1660         Fix the build.
1661
1662         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
1663         (WTR::UIScriptController::drawSquareInEditableImage):
1664         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
1665         (TestWebKitAPI::drawSquareInEditableImage):
1666
1667 2019-02-14  Brian Burg  <bburg@apple.com>
1668
1669         [Mac] WebInspectorUI.framework does not need to be soft-linked anymore
1670         https://bugs.webkit.org/show_bug.cgi?id=194411
1671         <rdar://problem/47787614>
1672
1673         Reviewed by Joseph Pecoraro.
1674
1675         Remove unnecessary soft linking macro usage.
1676
1677         * DumpRenderTree/mac/TestRunnerMac.mm:
1678         (TestRunner::inspectorTestStubURL):
1679         (SOFT_LINK_STAGED_FRAMEWORK): Deleted.
1680         * WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
1681         (WTR::TestRunner::inspectorTestStubURL):
1682
1683 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1684
1685         [ews-app] status bubble should fetch builder name info from BuilderMapping table
1686         https://bugs.webkit.org/show_bug.cgi?id=194599
1687
1688         Reviewed by Lucas Forschler.
1689
1690         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1691         (StatusBubble._build_bubble):
1692
1693 2019-02-14  Aakash Jain  <aakash_jain@apple.com>
1694
1695         [ews-app] Set Foreign Key in Django build model
1696         https://bugs.webkit.org/show_bug.cgi?id=194667
1697
1698         Reviewed by Lucas Forschler.
1699
1700         * BuildSlaveSupport/ews-app/ews/models/build.py:
1701         (Build):
1702
1703 2019-02-14  Ross Kirsling  <ross.kirsling@sony.com>
1704
1705         [WTF] Add environment variable helpers
1706         https://bugs.webkit.org/show_bug.cgi?id=192405
1707
1708         Reviewed by Michael Catanzaro.
1709
1710         * DumpRenderTree/mac/DumpRenderTree.mm:
1711         (libraryPathForDumpRenderTree):
1712         * DumpRenderTree/win/DumpRenderTree.cpp:
1713         (libraryPathForDumpRenderTree):
1714         * TestRunnerShared/IOSLayoutTestCommunication.cpp:
1715         (setUpIOSLayoutTestCommunication):
1716         * TestWebKitAPI/Tests/WebKit/EnvironmentUtilitiesTest.cpp:
1717         (TestWebKitAPI::strip):
1718         * TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
1719         (beforeAll):
1720         * TestWebKitAPI/glib/WebKitGLib/TestMain.cpp:
1721         (main):
1722         * TestWebKitAPI/glib/WebKitGLib/WebKitTestBus.cpp:
1723         (WebKitTestBus::run):
1724         * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
1725         (WTR::getOutputDir):
1726         (WTR::initializeFontConfigSetting):
1727         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
1728         (WTR::InjectedBundle::platformInitialize):
1729         * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
1730         (WTR::topLevelPath):
1731         * WebKitTestRunner/InjectedBundle/wpe/ActivateFontsWPE.cpp:
1732         (WTR::topLevelPath):
1733         (WTR::getOutputDir):
1734         (WTR::activateFonts):
1735         * WebKitTestRunner/TestController.cpp:
1736         (WTR::TestController::libraryPathForTesting):
1737         (WTR::TestController::generateContextConfiguration const):
1738         (WTR::TestController::generatePageConfiguration):
1739         (WTR::TestController::decideDestinationWithSuggestedFilename):
1740         (WTR::TestController::platformAdjustContext):
1741         * WebKitTestRunner/TestController.h:
1742         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
1743         (WTR::TestController::cocoaPlatformInitialize):
1744         (WTR::TestController::platformAdjustContext):
1745         * WebKitTestRunner/gtk/main.cpp:
1746         (main):
1747         * WebKitTestRunner/mac/TestControllerMac.mm:
1748         (WTR::TestController::configureContentExtensionForTest):
1749         * WebKitTestRunner/wpe/main.cpp:
1750         (main):
1751         Utilize WTF::Environment where possible.
1752
1753 2019-02-14  Chris Dumez  <cdumez@apple.com>
1754
1755         [PSON] Introduce a WebContent Process cache
1756         https://bugs.webkit.org/show_bug.cgi?id=194594
1757         <rdar://problem/46793397>
1758
1759         Reviewed by Geoff Garen.
1760
1761         Update API tests to turn on the WebContent Process cache.
1762
1763         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1764
1765 2019-02-14  Jiewen Tan  <jiewen_tan@apple.com>
1766
1767         Unreviewed, build fix after r241480
1768
1769         * TestWebKitAPI/ios/DragAndDropSimulatorIOS.mm:
1770         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1771         (-[DragAndDropSimulator initWithWebView:]):
1772
1773 2019-02-14  Chris Fleizach  <cfleizach@apple.com>
1774
1775         AX: ARIA Reflection was disabled in error
1776         https://bugs.webkit.org/show_bug.cgi?id=194647
1777         <rdar://problem/48068336>
1778
1779         Reviewed by Ryosuke Niwa.
1780
1781         Remove test override now that this feature should be enabled by default.
1782
1783         * WebKitTestRunner/TestController.cpp:
1784         (WTR::TestController::resetPreferencesToConsistentValues):
1785
1786 2019-02-14  Commit Queue  <commit-queue@webkit.org>
1787
1788         Unreviewed, rolling out r241486.
1789         https://bugs.webkit.org/show_bug.cgi?id=194655
1790
1791         causing API failures in builds (Requested by ShawnRoberts on
1792         #webkit).
1793
1794         Reverted changeset:
1795
1796         "[Cocoa] Media elements will restart network buffering just
1797         before suspending"
1798         https://bugs.webkit.org/show_bug.cgi?id=193691
1799         https://trac.webkit.org/changeset/241486
1800
1801 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1802
1803         [LFC][BFC][MarginCollapse] Replaced boxes don't collapse through their margins
1804         https://bugs.webkit.org/show_bug.cgi?id=194622
1805
1806         Reviewed by Antti Koivisto.
1807
1808         * LayoutReloaded/misc/LFC-passing-tests.txt:
1809
1810 2019-02-14  Zalan Bujtas  <zalan@apple.com>
1811
1812         [LFC] Shrink-to-fit-width should be constrained by min/max width
1813         https://bugs.webkit.org/show_bug.cgi?id=194653
1814
1815         Reviewed by Antti Koivisto.
1816
1817         * LayoutReloaded/misc/LFC-passing-tests.txt:
1818
1819 2019-02-13  Ryosuke Niwa  <rniwa@webkit.org>
1820
1821         Crash in WKBundleFrameGetParentFrame when called inside didRemoveFrameFromHierarchy
1822         https://bugs.webkit.org/show_bug.cgi?id=194641
1823
1824         Reviewed by Geoffrey Garen.
1825
1826         Added a call to WKBundleFrameGetParentFrame to an existing test for didRemoveFrameFromHierarchy
1827         so that the test would fail without this fix.
1828
1829         * TestWebKitAPI/Tests/WebKit/DidRemoveFrameFromHiearchyInPageCache_Bundle.cpp:
1830         (TestWebKitAPI::didRemoveFrameFromHierarchyCallback):
1831
1832 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1833
1834         [ews-app] Change log level for a log statement
1835
1836         Unreviewed minor fix.
1837
1838         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1839         (Patch.save_patch):
1840
1841 2019-02-13  Jer Noble  <jer.noble@apple.com>
1842
1843         [Cocoa] Media elements will restart network buffering just before suspending
1844         https://bugs.webkit.org/show_bug.cgi?id=193691
1845
1846         Reviewed by Eric Carlson.
1847
1848         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1849         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSuspendMediaBuffering.mm: Added.
1850         (TEST):
1851
1852 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1853
1854         [ews-app] Fetch builder id to name mapping
1855         https://bugs.webkit.org/show_bug.cgi?id=194355
1856
1857         Reviewed by Lucas Forschler.
1858
1859         * BuildSlaveSupport/ews-app/ews/common/buildbot.py:
1860         (Buildbot.get_builder_id_to_name_mapping):
1861         (Buildbot._get_display_name_from_builder_name):
1862
1863 2019-02-12  Jiewen Tan  <jiewen_tan@apple.com>
1864
1865         Further restricting webarchive loads
1866         https://bugs.webkit.org/show_bug.cgi?id=194567
1867         <rdar://problem/47610130>
1868
1869         Reviewed by Youenn Fablet.
1870
1871         Besides adding API tests, this patch also enhances DragAndDropSimulator to allow
1872         navigations on drop.
1873
1874         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
1875         * TestWebKitAPI/Tests/mac/LoadWebArchive.mm: Added.
1876         (-[TestLoadWebArchiveNavigationDelegate webView:didFinishNavigation:]):
1877         (-[TestLoadWebArchiveNavigationDelegate webView:didFailProvisionalNavigation:withError:]):
1878         (-[TestLoadWebArchiveNavigationDelegate webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
1879         (TestWebKitAPI::TEST):
1880         * TestWebKitAPI/Tests/mac/helloworld.webarchive: Added.
1881         * TestWebKitAPI/Tests/mac/load-web-archive-1.html: Added.
1882         * TestWebKitAPI/Tests/mac/load-web-archive-2.html: Added.
1883         * TestWebKitAPI/cocoa/DragAndDropSimulator.h:
1884         * TestWebKitAPI/mac/DragAndDropSimulatorMac.mm:
1885         (-[DragAndDropSimulator initWithWebViewFrame:configuration:]):
1886         (-[DragAndDropSimulator _webView:dragDestinationActionMaskForDraggingInfo:]):
1887
1888 2019-02-13  John Wilander  <wilander@apple.com>
1889
1890         Store Ad Click Attribution requests in the network process
1891         https://bugs.webkit.org/show_bug.cgi?id=194510
1892         <rdar://problem/47650118>
1893
1894         Reviewed by Alex Christensen and Daniel Bates.
1895
1896         This patch adds two TestRunner functions:
1897         - dumpAdClickAttribution()
1898         - clearAdClickAttribution()
1899
1900         They call into the network process to dump and clear Ad Click
1901         Attribution state, respectively.
1902
1903         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
1904         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
1905         (WTR::TestRunner::dumpAdClickAttribution):
1906         (WTR::TestRunner::clearAdClickAttribution):
1907         * WebKitTestRunner/InjectedBundle/TestRunner.h:
1908         * WebKitTestRunner/TestController.cpp:
1909         (WTR::TestController::resetStateToConsistentValues):
1910         (WTR::AdClickAttributionStringResultCallbackContext::AdClickAttributionStringResultCallbackContext):
1911         (WTR::adClickAttributionStringResultCallback):
1912         (WTR::TestController::dumpAdClickAttribution):
1913         (WTR::AdClickAttributionVoidCallbackContext::AdClickAttributionVoidCallbackContext):
1914         (WTR::adClickAttributionVoidCallback):
1915         (WTR::TestController::clearAdClickAttribution):
1916         * WebKitTestRunner/TestController.h:
1917         * WebKitTestRunner/TestInvocation.cpp:
1918         (WTR::TestInvocation::dumpResults):
1919         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
1920         (WTR::TestInvocation::dumpAdClickAttribution):
1921         * WebKitTestRunner/TestInvocation.h:
1922
1923 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1924
1925         [ews-app] Generate status-bubble
1926         https://bugs.webkit.org/show_bug.cgi?id=194572
1927
1928         Reviewed by Lucas Forschler.
1929
1930         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
1931         (StatusBubble._build_bubble):
1932         (StatusBubble._should_show_bubble_for):
1933         (StatusBubble._build_bubbles_for_patch):
1934
1935 2019-02-13  Aakash Jain  <aakash_jain@apple.com>
1936
1937         [ews-app] Add status bubble html template
1938         https://bugs.webkit.org/show_bug.cgi?id=194571
1939
1940         Reviewed by Lucas Forschler.
1941
1942         * BuildSlaveSupport/ews-app/ews/templates: Added.
1943         * BuildSlaveSupport/ews-app/ews/templates/statusbubble.html: Copied from QueueStatusServer/templates/statusbubble.html.
1944
1945 2019-02-12  Chris Dumez  <cdumez@apple.com>
1946
1947         Regression(PSON) MESSAGE_CHECK() hit under WebPageProxy::didFailProvisionalLoadForFrameShared()
1948         https://bugs.webkit.org/show_bug.cgi?id=194568
1949         <rdar://problem/47944490>
1950
1951         Reviewed by Ryosuke Niwa.
1952
1953         Add API test coverage.
1954
1955         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
1956         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
1957
1958 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
1959
1960         webkitpy: Remove bug_dummy from parsed test expectations
1961         https://bugs.webkit.org/show_bug.cgi?id=194562
1962         <rdar://problem/47853999>
1963
1964         Reviewed by Lucas Forschler.
1965
1966         * Scripts/webkitpy/layout_tests/models/test_expectations.py:
1967         (TestExpectationParser):
1968         (TestExpectationParser.expectation_for_skipped_test): Remove DUMMY_BUG_MODIFIER from
1969         skipped tests.
1970         * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
1971
1972 2019-02-12  Aakash Jain  <aakash_jain@apple.com>
1973
1974         [ews-app] Add method to fetch patch
1975         https://bugs.webkit.org/show_bug.cgi?id=194518
1976
1977         Reviewed by Lucas Forschler.
1978
1979         * BuildSlaveSupport/ews-app/ews/models/patch.py:
1980         (Patch.get_patch):
1981
1982 2019-02-12  Zalan Bujtas  <zalan@apple.com>
1983
1984         [LFC] Expand tests coverage (60 new tests -> 860)
1985
1986         Unreviewed test gardening (run-singly, --child-processes=1).
1987
1988         * LayoutReloaded/misc/LFC-passing-tests.txt:
1989
1990 2019-02-12  Wenson Hsieh  <wenson_hsieh@apple.com>
1991
1992         Allow pages to trigger programmatic paste from script on iOS
1993         https://bugs.webkit.org/show_bug.cgi?id=194271
1994         <rdar://problem/47808810>
1995
1996         Reviewed by Tim Horton.
1997
1998         Add support for interacting with the callout bar on iOS during layout tests. See below for more detail.
1999
2000         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2001         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2002         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2003         (WTR::UIScriptController::rectForMenuAction const):
2004
2005         Add new mechanisms to make it possible to interact with and query the state of the callout menu on iOS. This
2006         includes determining the rect (in content view coordinates) of the menu's controls, and callbacks to register
2007         for when the menu is shown or hidden.
2008
2009         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2010         * TestRunnerShared/UIScriptContext/UIScriptContext.h:
2011         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2012         (WTR::UIScriptController::setDidShowMenuCallback):
2013         (WTR::UIScriptController::didShowMenuCallback const):
2014         (WTR::UIScriptController::setDidHideMenuCallback):
2015         (WTR::UIScriptController::didHideMenuCallback const):
2016         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2017         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2018         (WTR::UIScriptController::rectForMenuAction const):
2019         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2020         * WebKitTestRunner/TestController.cpp:
2021         (WTR::TestController::resetPreferencesToConsistentValues):
2022         (WTR::updateTestOptionsFromTestHeader):
2023         * WebKitTestRunner/TestOptions.h:
2024
2025         Add a new test option to determine whether DOM paste is enabled. DOM paste is currently enabled everywhere by
2026         default, but these new programmatic paste tests require it to be disabled in order for confirmation UI to show.
2027
2028         (WTR::TestOptions::hasSameInitializationOptions const):
2029         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2030         (WTR::UIScriptController::calendarType const):
2031         (WTR::UIScriptController::platformUndoManager const):
2032         * WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
2033         * WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:
2034         (-[TestRunnerWKWebView initWithFrame:configuration:]):
2035         (-[TestRunnerWKWebView dealloc]):
2036         (-[TestRunnerWKWebView _didShowMenu]):
2037         (-[TestRunnerWKWebView _didHideMenu]):
2038
2039         Listen to when the callout bar is presented and dismissed, and invoke testing callbacks as needed.
2040
2041         * WebKitTestRunner/ios/TestControllerIOS.mm:
2042         (WTR::handleMenuWillHideNotification):
2043         (WTR::handleMenuDidHideNotification):
2044         (WTR::TestController::platformInitialize):
2045         (WTR::TestController::platformDestroy):
2046         (WTR::TestController::platformResetStateToConsistentValues):
2047
2048         Additionally ensure that any callout menu presented by a previous layout test is dismissed before running the
2049         next test by hiding the callout bar if necessary, and then waiting for the "DidHide" notification.
2050
2051         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2052         (WTR::forEachViewInHierarchy):
2053         (WTR::findViewInHierarchyOfType):
2054
2055         Move `forEachViewInHierarchy` so that we can use it throughout the file, and then add some additional helper
2056         functions that dig through a given view's hierarchy in search of a view of a given class.
2057
2058         (WTR::UIScriptController::selectionStartGrabberViewRect const):
2059         (WTR::UIScriptController::selectionEndGrabberViewRect const):
2060         (WTR::UIScriptController::selectionCaretViewRect const):
2061         (WTR::UIScriptController::selectionRangeViewRects const):
2062         (WTR::UIScriptController::platformSetDidShowMenuCallback):
2063         (WTR::UIScriptController::platformSetDidHideMenuCallback):
2064
2065         Tweak these to use `platformContentView` instead of grabbing the content view from WKWebView directly.
2066
2067         (WTR::UIScriptController::rectForMenuAction const):
2068
2069         Add a new UIScriptController method to get the rect of the action in the contextual menu (on iOS, this is the
2070         callout bar) whose label matches the given string.
2071
2072         (WTR::UIScriptController::platformContentView const):
2073
2074         Add a `platformContentView()` helper on UIScriptController so that we can stop grabbing the value for key
2075         "_currentContentView" from various places in this file. Additionally, rewrite `platformUndoManager()` in terms
2076         of this new helper, and move the code out from iOS/macOS-specific files into UIScriptControllerCocoa.
2077
2078         (WTR::UIScriptController::platformUndoManager const): Deleted.
2079         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2080         (WTR::UIScriptController::platformContentView const):
2081         (WTR::UIScriptController::platformUndoManager const): Deleted.
2082
2083 2019-02-12  Jonathan Bedard  <jbedard@apple.com>
2084
2085         webkitpy: No option to only show unexpected failures in results.html for iPad
2086         https://bugs.webkit.org/show_bug.cgi?id=194554
2087         <rdar://problem/47922442>
2088
2089         Rubber-stamped by Aakash Jain.
2090
2091         Just because a TestExpecations file does not exist for a specific platform does not mean that
2092         TestExpecations are not being used, given that platforms inherit test expectations.
2093
2094         * Scripts/webkitpy/port/base.py:
2095         (Port.uses_test_expectations_file): Check all possible locations of a TestExpectations file.
2096         * Scripts/webkitpy/port/base_unittest.py:
2097         (PortTest.test_uses_test_expectations_file):
2098
2099 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2100
2101         Remove setDefersLoading infrastructure from WebKit2
2102         https://bugs.webkit.org/show_bug.cgi?id=194506
2103
2104         Reviewed by Brady Eidson.
2105
2106         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2107         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2108         (WTR::TestRunner::setDefersLoading): Deleted.
2109         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2110
2111 2019-02-12  Alex Christensen  <achristensen@webkit.org>
2112
2113         WebPage::close needs to remove all message receivers associated with that WebPage, not WebPage::~WebPage
2114         https://bugs.webkit.org/show_bug.cgi?id=194522
2115         <rdar://problem/47789393>
2116
2117         Reviewed by Chris Dumez.
2118
2119         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2120         * TestWebKitAPI/Tests/WebKitCocoa/BundleRetainPagePlugIn.mm: Added.
2121         (-[BundleRetainPagePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
2122         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2123
2124 2019-02-12  Andy Estes  <aestes@apple.com>
2125
2126         [iOSMac] Enable Parental Controls Content Filtering
2127         https://bugs.webkit.org/show_bug.cgi?id=194521
2128         <rdar://39732376>
2129
2130         Reviewed by Tim Horton.
2131
2132         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
2133
2134 2019-02-12  Zalan Bujtas  <zalan@apple.com>
2135
2136         [LFC][IFC] Add intrinsic width support for float boxes.
2137         https://bugs.webkit.org/show_bug.cgi?id=194528
2138
2139         Reviewed by Antti Koivisto.
2140
2141         Expand tests coverage (2 new tests -> 800).
2142         (This is the correct test ordering --runs-singly --child-processes=1)
2143
2144         * LayoutReloaded/misc/LFC-passing-tests.txt:
2145
2146 2019-02-12  Rob Buis  <rbuis@igalia.com>
2147
2148         Implement serializing in MIME type parser
2149         https://bugs.webkit.org/show_bug.cgi?id=193909
2150
2151         Reviewed by Darin Adler.
2152
2153         Add various tests involving upper case, non-ASCII, control/null characters,
2154         various HTTP whitespace, single quotes and an unpaired surrogate.
2155
2156         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
2157         (TestWebKitAPI::escapeNonASCIIPrintableCharacters):
2158         (TestWebKitAPI::serializeIfValid):
2159         (TestWebKitAPI::TEST):
2160
2161 2019-02-11  Myles C. Maxfield  <mmaxfield@apple.com>
2162
2163         [Cocoa] Ask platform for generic font family mappings
2164         https://bugs.webkit.org/show_bug.cgi?id=187723
2165         <rdar://problem/41892438>
2166
2167         Reviewed by Brent Fulgham.
2168
2169         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2170
2171         * DumpRenderTree/mac/DumpRenderTree.mm:
2172         (allowedFontFamilySet):
2173         * WebKitTestRunner/mac/TestControllerMac.mm:
2174         (WTR::allowedFontFamilySet):
2175
2176 2019-02-11  Adrian Perez de Castro  <aperez@igalia.com>
2177
2178         [GTK][WPE] Add content extensions support in WKTR and unskip layout tests
2179         https://bugs.webkit.org/show_bug.cgi?id=193622
2180
2181         Reviewed by Michael Catanzaro.
2182
2183         This adds support for loading content extension rule sets from the JSON files which
2184         accompany the corresponding layout test, using the C API. The Cocoa specific parts
2185         of WKTR for this could be removed, but that is left for a follow-up patch with
2186         cleanups.
2187
2188         * Scripts/webkitperl/FeatureList.pm: Add an option to toggle CONTENT_EXTENSIONS.
2189         * WebKitTestRunner/TestController.cpp:
2190         (WTR::testPath): Subtract one from the length when constructing the result std::string to
2191         avoid having the null-terminator copied into the result.
2192         (WTR::TestController::configureViewForTest): Call configureContentExtensionForTest() as
2193         part of the preparations to run a test.
2194         (WTR::ContentExtensionStoreCallbackContext::ContentExtensionStoreCallbackContext): Added.
2195         (WTR::contentExtensionStoreCallback): Added.
2196         (WTR::contentExtensionJSONPath): Used to calculate the path to the JSON rule set to be
2197         used for content extensions test.
2198         (WTR::TestController::configureContentExtensionForTest): Added, handles enabling content
2199         extensions and compiling the JSON rule set for tests involving content extensions.
2200         (WTR::TestController::resetContentExtensions): Removes the content extension built for
2201         testing and disables content extensions.
2202         (WTR::TestController::resetPreferencesToConsistentValues): Add a call to
2203         resetContentExtensions().
2204         (WTR::TestController::userContentController): Added implementation for ports other than Cocoa.
2205         * WebKitTestRunner/TestController.h: Add declarations for resetContentExtensions(),
2206         configureContentExtensionForTest(), and userContentController().
2207
2208 2019-02-11  Daniel Bates  <dabates@apple.com>
2209
2210         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2211         https://bugs.webkit.org/show_bug.cgi?id=191446
2212         <rdar://problem/45929460>
2213
2214         Reviewed by Tim Horton.
2215
2216         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2217
2218         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2219         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2220         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2221         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2222         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2223         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2224         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2225         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2226         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2227         (WTR::arrayLength):
2228         (WTR::parseModifierArray):
2229         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2230         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2231         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2232         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2233
2234 2019-02-11  Commit Queue  <commit-queue@webkit.org>
2235
2236         Unreviewed, rolling out r241272 and r241276.
2237         https://bugs.webkit.org/show_bug.cgi?id=194514
2238
2239         Broke the Apple Internal build and the fix requires human
2240         intervention :( (Requested by dydz on #webkit).
2241
2242         Reverted changesets:
2243
2244         "[iOS] Mouse/Touch/Pointer events are missing modifier keys"
2245         https://bugs.webkit.org/show_bug.cgi?id=191446
2246         https://trac.webkit.org/changeset/241272
2247
2248         "Fix internal iOS build after r241272"
2249         https://bugs.webkit.org/show_bug.cgi?id=191446
2250         https://trac.webkit.org/changeset/241276
2251
2252 2019-02-11  Truitt Savell  <tsavell@apple.com>
2253
2254         Unreviewed, rolling out r241269.
2255
2256         Caused 5 layout tests crashes on Mac WK1
2257
2258         Reverted changeset:
2259
2260         "DumpRenderTree should report unknown options"
2261         https://bugs.webkit.org/show_bug.cgi?id=191303
2262         https://trac.webkit.org/changeset/241269
2263
2264 2019-02-11  Wenson Hsieh  <wenson_hsieh@apple.com>
2265
2266         fast/forms/ios/force-gregorian-calendar-for-credit-card-expiry.html does not work on iPad
2267         https://bugs.webkit.org/show_bug.cgi?id=194313
2268
2269         Reviewed by Tim Horton.
2270
2271         Add a helper to determine whether the web view is presenting modal UI.
2272
2273         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2274         (WTR::UIScriptController::isPresentingModally const):
2275         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2276         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2277         (WTR::UIScriptController::isPresentingModally const):
2278         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2279         * WebKitTestRunner/UIScriptControllerCocoa.mm:
2280         (WTR::UIScriptController::calendarType const): Deleted.
2281         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2282         (WTR::UIScriptController::isPresentingModally const):
2283         (WTR::UIScriptController::calendarType const):
2284         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
2285         (WTR::UIScriptController::calendarType const):
2286
2287 2019-02-11  Joseph Pecoraro  <pecoraro@apple.com>
2288
2289         GCHeapInspector: Show the retained sizes in more places
2290         https://bugs.webkit.org/show_bug.cgi?id=194464
2291
2292         Reviewed by Simon Fraser.
2293
2294         * GCHeapInspector/gc-heap-inspector.html:
2295         * GCHeapInspector/script/interface.js:
2296         (HeapInspectorUtils.humanReadableSize):
2297         (HeapInspectorUtils.spanForNode.let.nodeHTML.node.className.span):
2298         (HeapInspectorUtils.spanForNode.span.span):
2299         (HeapSnapshotInspector.prototype.buildAllObjectsByType):
2300         (HeapSnapshotInspector.prototype.buildRoots):
2301
2302 2019-02-11  Daniel Bates  <dabates@apple.com>
2303
2304         [iOS] Mouse/Touch/Pointer events are missing modifier keys
2305         https://bugs.webkit.org/show_bug.cgi?id=191446
2306         <rdar://problem/45929460>
2307
2308         Reviewed by Tim Horton.
2309
2310         Add support infrastructure for testing touch and stylus taps when holding modifier keys. 
2311
2312         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
2313         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2314         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2315         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
2316         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
2317         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2318         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2319         * TestRunnerShared/UIScriptContext/UIScriptController.h:
2320         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
2321         (WTR::arrayLength):
2322         (WTR::parseModifierArray):
2323         (WTR::UIScriptController::singleTapAtPoint): Implemented in terms of singleTapAtPointWithModifiers().
2324         (WTR::UIScriptController::singleTapAtPointWithModifiers): Added.
2325         (WTR::UIScriptController::stylusTapAtPoint): Implemented in terms of stylusTapAtPointWithModifiers().
2326         (WTR::UIScriptController::stylusTapAtPointWithModifiers): Added.
2327
2328 2019-02-11  Darshan Kadu  <dkadu@igalia.com>
2329
2330         DumpRenderTree should report unknown options
2331         https://bugs.webkit.org/show_bug.cgi?id=191303
2332
2333         Reviewed by Frédéric Wang.
2334
2335         Added RELEASE_ASSERT_NOT_REACHED for DumpRenderTree/TestOptions.cpp
2336         to report unknown options.
2337         Added and assigned test options which are currently used in tests.
2338
2339         * DumpRenderTree/TestOptions.cpp:
2340         (TestOptions::TestOptions):
2341
2342 2019-02-11  Truitt Savell  <tsavell@apple.com>
2343
2344         Unreviewed, rolling out r241229.
2345
2346         Revision broke internal builds for watchOS.
2347
2348         Reverted changeset:
2349
2350         "[Cocoa] Ask platform for generic font family mappings"
2351         https://bugs.webkit.org/show_bug.cgi?id=187723
2352         https://trac.webkit.org/changeset/241229
2353
2354 2019-02-11  Takashi Komori  <Takashi.Komori@sony.com>
2355
2356         [WinCairo][MiniBrowser] Basic authentication always fails.
2357         https://bugs.webkit.org/show_bug.cgi?id=194496
2358
2359         Reviewed by Don Olmstead.
2360
2361         * MiniBrowser/win/DialogHelper.h:
2362         (Dialog::getText):
2363
2364 2019-02-11  Philippe Normand  <pnormand@igalia.com>
2365
2366         [GStreamer] GstMappedBuffer testsuite build fails
2367         https://bugs.webkit.org/show_bug.cgi?id=194495
2368
2369         Reviewed by Carlos Garcia Campos.
2370
2371         Fix the build by explicitely adding the gstreamer1.0-audio include
2372         directories to the include path.
2373
2374         * TestWebKitAPI/PlatformGTK.cmake:
2375         * TestWebKitAPI/PlatformWPE.cmake:
2376
2377 2019-02-04  Carlos Garcia Campos  <cgarcia@igalia.com>
2378
2379         [GTK][WPE] Add enable-javascript-markup setting
2380         https://bugs.webkit.org/show_bug.cgi?id=193439
2381
2382         Reviewed by Michael Catanzaro.
2383
2384         Add test cases to check the new setting.
2385
2386         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2387         (testWebKitSettings):
2388         (testWebKitSettingsJavaScriptMarkup):
2389         (beforeAll):
2390
2391 2019-02-10  Darin Adler  <darin@apple.com>
2392
2393         Switch uses of StringBuilder with String::format for hex numbers to use HexNumber.h instead
2394         https://bugs.webkit.org/show_bug.cgi?id=194485
2395
2396         Reviewed by Daniel Bates.
2397
2398         * WebKitTestRunner/TestController.cpp: Removed unnecessary include of HexNumber.h.
2399
2400 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2401
2402         Add more tests for clampTo<>()
2403         https://bugs.webkit.org/show_bug.cgi?id=194462
2404
2405         Reviewed by Geoffrey Garen.
2406
2407         Darin suggested to test the very last floating point number
2408         at the boundaries when truncating to integer.
2409         I added test for max/min and max-1/min-1.
2410
2411         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2412         (TestWebKitAPI::TEST):
2413
2414 2019-02-09  Darin Adler  <darin@apple.com>
2415
2416         Eliminate unnecessary String temporaries by using StringConcatenateNumbers
2417         https://bugs.webkit.org/show_bug.cgi?id=194021
2418
2419         Reviewed by Geoffrey Garen.
2420
2421         * TestWebKitAPI/Tests/WTF/StringConcatenate.cpp:
2422         (TestWebKitAPI::TEST): Change tests to use EXPECT_STREQ so failure messages are easier
2423         to understand. Updated tests for changes to FormattedNumber::fixedPrecision.
2424
2425 2019-02-09  Zalan Bujtas  <zalan@apple.com>
2426
2427         [LFC][IFC] Add intrinsic width support for basic inline containers
2428         https://bugs.webkit.org/show_bug.cgi?id=194473
2429
2430         Reviewed by Antti Koivisto.
2431
2432         Expand tests coverage (11 new tests -> 798)
2433
2434         * LayoutReloaded/misc/LFC-passing-tests.txt: not sure why run-singly keeps producing different ordering.
2435
2436 2019-02-09  Benjamin Poulain  <benjamin@webkit.org>
2437
2438         Fix MiniBrowser's entitlements
2439         https://bugs.webkit.org/show_bug.cgi?id=192431
2440
2441         Reviewed by Joseph Pecoraro.
2442
2443         MiniBrowser's Extensions Manager was broken. The entitlement was missing for opening
2444         files, making it impossible to load any extension.
2445
2446         * MiniBrowser/MiniBrowser.entitlements:
2447
2448 2019-02-08  Myles C. Maxfield  <mmaxfield@apple.com>
2449
2450         [Cocoa] Ask platform for generic font family mappings
2451         https://bugs.webkit.org/show_bug.cgi?id=187723
2452         <rdar://problem/41892438>
2453
2454         Reviewed by Brent Fulgham.
2455
2456         Allow testing infrastructure to use fonts that are returned from CTFontDescriptorCreateForCSSFamily().
2457
2458         * DumpRenderTree/mac/DumpRenderTree.mm:
2459         (allowedFontFamilySet):
2460         * WebKitTestRunner/mac/TestControllerMac.mm:
2461         (WTR::allowedFontFamilySet):
2462
2463 2019-02-08  Alexander Mikhaylenko  <exalm7659@gmail.com>
2464
2465         [GTK] Implement back/forward touchpad gesture
2466         https://bugs.webkit.org/show_bug.cgi?id=193919
2467
2468         Reviewed by Michael Catanzaro.
2469
2470         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
2471         (testWebKitSettings): Add a test for 'enable-back-forward-navigation-gestures' property.
2472
2473 2019-02-08  Alex Christensen  <achristensen@webkit.org>
2474
2475         Add SPI to use networking daemon instead of XPC service
2476         https://bugs.webkit.org/show_bug.cgi?id=194427
2477
2478         Reviewed by Geoffrey Garen
2479
2480         * MiniBrowser/MiniBrowser.entitlements:
2481
2482 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2483
2484         [ews-build] Ensure that every builder in config.json has short name
2485         https://bugs.webkit.org/show_bug.cgi?id=194461
2486
2487         Reviewed by Lucas Forschler.
2488
2489         * BuildSlaveSupport/ews-build/loadConfig.py:
2490         * BuildSlaveSupport/ews-build/loadConfig_unittest.py: Updated unit-tests.
2491
2492 2019-02-08  Aakash Jain  <aakash_jain@apple.com>
2493
2494         [ews-build] Add short name to config.json
2495         https://bugs.webkit.org/show_bug.cgi?id=194456
2496
2497         Reviewed by Lucas Forschler.
2498
2499         * BuildSlaveSupport/ews-build/config.json: Added short name.
2500         * BuildSlaveSupport/ews-build/loadConfig.py:
2501         (loadBuilderConfig): Set the short name as the builder description.
2502
2503 2019-02-08  Jonathan Bedard  <jbedard@apple.com>
2504
2505         webkitpy: CrashLogs.find_all_logs may return a string or a dictionary
2506         https://bugs.webkit.org/show_bug.cgi?id=194418
2507
2508         Reviewed by Lucas Forschler.
2509
2510         Do not include errors trying when finding crashlogs at the end of
2511         a run-webkit-tests run since we don't process those errors.
2512
2513         * Scripts/webkitpy/port/darwin.py:
2514         (DarwinPort._look_for_all_crash_logs_in_log_dir):
2515         * Scripts/webkitpy/port/ios_device.py:
2516         (IOSDevicePort._look_for_all_crash_logs_in_log_dir):
2517         * Scripts/webkitpy/port/watch_device.py:
2518         (WatchDevicePort._look_for_all_crash_logs_in_log_dir):
2519
2520 2019-02-08  Beth Dakin  <bdakin@apple.com>
2521
2522         Add afterScreenUpdates to WKSnapshotConfiguration
2523         https://bugs.webkit.org/show_bug.cgi?id=194362
2524         -and corresponding-
2525         <rdar://problem/40655528> Please add an "after screen updates" property to 
2526         WKSnapshotConfiguration (to solve blank snapshots)
2527
2528         Reviewed by Tim Horton.
2529
2530         * TestWebKitAPI/Tests/WebKitCocoa/WKWebViewSnapshot.mm:
2531         (TEST):
2532
2533 2019-02-08  Benjamin Poulain  <benjamin@webkit.org>
2534
2535         clampTo(): do not convert the input to double when dealing with integers
2536         https://bugs.webkit.org/show_bug.cgi?id=194263
2537         <rdar://problem/47692312>
2538
2539         Reviewed by Darin Adler.
2540
2541         * TestWebKitAPI/Tests/WTF/MathExtras.cpp:
2542         (TestWebKitAPI::testClampFloatingPointToFloatingPoint):
2543         (TestWebKitAPI::testClampFloatingPointToInteger):
2544         (TestWebKitAPI::testClampSameSignIntegers):
2545         (TestWebKitAPI::testClampUnsignedToSigned):
2546         (TestWebKitAPI::testClampSignedToUnsigned):
2547
2548 2019-02-07  Jonathan Bedard  <jbedard@apple.com>
2549
2550         webkitpy: Respect --dedicated-simulators flag
2551         https://bugs.webkit.org/show_bug.cgi?id=194416
2552         <rdar://problem/47894722>
2553
2554         Reviewed by Lucas Forschler.
2555
2556         * Scripts/webkitpy/port/device_port.py:
2557         (DevicePort.supported_device_types): If --dedicated-simulators is passed, all
2558         available devices can be safely ignored.
2559
2560 2019-02-07  Keith Rollin  <krollin@apple.com>
2561
2562         Remove extra copy of 100x100-red.tga
2563         https://bugs.webkit.org/show_bug.cgi?id=194371
2564         <rdar://problem/47873465>
2565
2566         Reviewed by Said Abou-Hallawa.
2567
2568         In order to help it pass its tests, Bug 194190 added a second copy of
2569         the file 100x100-red.tga. However, it turns out that this additional
2570         file wasn't actually needed, and that that sole previous copy was
2571         sufficient. At the same time, this second copy -- which was copied to
2572         the same location in the build output as the first copy -- now caused
2573         XCBuild to complain because there were two production rules for the
2574         same output file. Address this by removing the newly-added extra copy.
2575
2576         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2577         * TestWebKitAPI/Tests/mac/100x100-red.tga: Removed.
2578
2579 2019-02-07  Alex Christensen  <achristensen@webkit.org>
2580
2581         Deprecate WKBundlePageSetDefersLoading
2582         https://bugs.webkit.org/show_bug.cgi?id=191394
2583
2584         Reviewed by Dean Jackson.
2585
2586         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2587         (WTR::TestRunner::setDefersLoading):
2588
2589 2019-02-07  Zalan Bujtas  <zalan@apple.com>
2590
2591         [LFC][Out-of-flow] Use the containing block's padding width when computing min/max width.
2592         https://bugs.webkit.org/show_bug.cgi?id=194391
2593
2594         Reviewed by Antti Koivisto.
2595
2596         * LayoutReloaded/misc/LFC-passing-tests.txt:
2597
2598 2019-02-06  Keith Rollin  <krollin@apple.com>
2599
2600         Remove Info.plist from MobileMiniBrowser.framework's Copy Bundle Resources phase
2601         https://bugs.webkit.org/show_bug.cgi?id=193975
2602         <rdar://problem/47643306>
2603
2604         Reviewed by Tim Horton.
2605
2606         The MobileMiniBrowser.framework's Copy Bundle Resources phase copies
2607         the Info.plist file into the bundle. This step is not necessary as the
2608         implicit "bundle up all the build products into a framework" build
2609         phase does this already. Having the Copy Bundle Resources phase do
2610         this causes a conflict under XCBuild, which objects to two build
2611         phases producing the same file (Info.plist). Address this by removing
2612         Info.plist from the Copy Bundle Resources phase.
2613
2614         * MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
2615
2616 2019-02-06  Keith Rollin  <krollin@apple.com>
2617
2618         Really enable the automatic checking and regenerations of .xcfilelists during builds
2619         https://bugs.webkit.org/show_bug.cgi?id=194357
2620         <rdar://problem/47861231>
2621
2622         Reviewed by Chris Dumez.
2623
2624         Bug 194124 was supposed to enable the automatic checking and
2625         regenerating of .xcfilelist files during the build. While related
2626         changes were included in that patch, the change to actually enable the
2627         operation somehow was omitted. This patch actually enables the
2628         operation. The check-xcfilelist.sh scripts now check
2629         WK_DISABLE_CHECK_XCFILELISTS, and if it's "1", opts-out the developer
2630         from the checking.
2631
2632         * DumpRenderTree/Scripts/check-xcfilelists.sh:
2633         * WebKitTestRunner/Scripts/check-xcfilelists.sh:
2634
2635 2019-02-06  David Kilzer  <ddkilzer@apple.com>
2636
2637         WTR::InjectedBundlePage::willSendRequestForFrame() leaks a WKDataRef
2638         <https://webkit.org/b/194286>
2639         <rdar://problem/47815558>
2640
2641         Reviewed by Alexey Proskuryakov.
2642
2643         * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
2644         (WTR::InjectedBundlePage::willSendRequestForFrame): Use
2645         WKRetainPtr<> to avoid leaking the WKDataRef.
2646
2647 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2648
2649         Unreviewed, fix a typo
2650
2651         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2652
2653 2019-02-06  Olivier Blin  <olivier.blin@softathome.com>
2654
2655         [GTK][WPE] force libpsl build to use ICU in jhbuild
2656         https://bugs.webkit.org/show_bug.cgi?id=194288
2657
2658         Reviewed by Carlos Garcia Campos.
2659
2660         * gtk/jhbuild.modules:
2661         Require ICU for libpsl build in jhbuild, like done in WPE.
2662
2663 2019-02-06  Michael Catanzaro  <mcatanzaro@igalia.com>
2664
2665         REGRESSION(r240785): [SOUP] Broke cookie persistent storage
2666         https://bugs.webkit.org/show_bug.cgi?id=194209
2667
2668         Reviewed by Carlos Garcia Campos.
2669
2670         Enhance TestCookieManager to ensure this doesn't happen again.
2671
2672         * TestWebKitAPI/Tests/WebKitGLib/TestCookieManager.cpp:
2673         (testCookieManagerPersistentStorage):
2674         (beforeAll):
2675
2676 2019-02-05  Wenson Hsieh  <wenson_hsieh@apple.com>
2677
2678         Rename TestOptions.ignoreSynchronousMessagingTimeoutsForTesting
2679         https://bugs.webkit.org/show_bug.cgi?id=194324
2680
2681         Reviewed by Andy Estes.
2682
2683         Rename ignoreSynchronousMessagingTimeoutsForTesting to just ignoreSynchronousMessagingTimeouts. The -ForTesting
2684         part of the name is already implicit, since this is in testing code in TestOptions.
2685
2686         * WebKitTestRunner/TestController.cpp:
2687         (WTR::TestController::generateContextConfiguration const):
2688         (WTR::updateTestOptionsFromTestHeader):
2689         * WebKitTestRunner/TestOptions.h:
2690         (WTR::TestOptions::hasSameInitializationOptions const):
2691
2692 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2693
2694         [ews-build] Allow * as platform for builders and workers
2695         https://bugs.webkit.org/show_bug.cgi?id=188533
2696
2697         Reviewed by Lucas Forschler.
2698
2699         * BuildSlaveSupport/ews-build/loadConfig.py:
2700         (checkWorkersAndBuildersForConsistency):
2701
2702 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2703
2704         [ews-build] Add few bots to config.json
2705         https://bugs.webkit.org/show_bug.cgi?id=194304
2706
2707         Reviewed by Lucas Forschler.
2708
2709         * BuildSlaveSupport/ews-build/config.json:
2710
2711 2019-02-05  Keith Rollin  <krollin@apple.com>
2712
2713         Enable the automatic checking and regenerations of .xcfilelists during builds
2714         https://bugs.webkit.org/show_bug.cgi?id=194124
2715         <rdar://problem/47721277>
2716
2717         Reviewed by Tim Horton.
2718
2719         Bug 193790 add a facility for checking -- during build time -- that
2720         any needed .xcfilelist files are up-to-date and for updating them if
2721         they are not. This facility was initially opt-in by setting
2722         WK_ENABLE_CHECK_XCFILELISTS until other pieces were in place and until
2723         the process seemed robust. Its now time to enable this facility and
2724         make it opt-out. If there is a need to disable this facility, set and
2725         export WK_DISABLE_CHECK_XCFILELISTS=1 in your environment before
2726         running `make` or `build-webkit`, or before running Xcode from the
2727         command line.
2728
2729         Additionally, remove the step that generates a list of source files
2730         going into the UnifiedSources build step. It's only necessarily to
2731         specify Sources.txt and SourcesCocoa.txt as inputs.
2732
2733         * Scripts/generate-xcfilelists:
2734
2735 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2736
2737         [GTK][WPE] force libpsl build to use ICU in jhbuild
2738         https://bugs.webkit.org/show_bug.cgi?id=194288
2739
2740         Reviewed by Philippe Normand.
2741
2742         In jhbuild, libpsl depends on ICU, but its configure script may decide to use libidn instead of ICU.
2743         This can cause build failures if libidn is detected but libunistring is not available.
2744
2745         Make sure that ICU is used for runtime and builtin PSL data.
2746
2747         * gtk/jhbuild.modules:
2748         * wpe/jhbuild.modules:
2749
2750 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2751
2752         [ews-app] Modified timestamp should be updated on updating data
2753         https://bugs.webkit.org/show_bug.cgi?id=194295
2754
2755         Reviewed by Lucas Forschler.
2756
2757         * BuildSlaveSupport/ews-app/ews/models/build.py:
2758         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2759         * BuildSlaveSupport/ews-app/ews/models/step.py:
2760
2761 2019-02-05  Ryan Haddad  <ryanhaddad@apple.com>
2762
2763         Unreviewed, rolling out r240742.
2764
2765         Causes crashes on iOS simulator.
2766
2767         Reverted changeset:
2768
2769         "[iOS] Keyups for non-modifier keys identified as "Dead" when
2770         not focused in a content-editable element"
2771         https://bugs.webkit.org/show_bug.cgi?id=192824
2772         https://trac.webkit.org/changeset/240742
2773
2774 2019-02-05  Jonathan Bedard  <jbedard@apple.com>
2775
2776         run-webkit-tests emits message "...running None" when running tests
2777         https://bugs.webkit.org/show_bug.cgi?id=194133
2778         <rdar://problem/47724738>
2779
2780         Reviewed by Lucas Forschler.
2781
2782         * Scripts/webkitpy/xcode/device_type.py:
2783         (DeviceType.__str__): Use both version mapping tables and use just the variant
2784         name if no version name is available.
2785         * Scripts/webkitpy/xcode/device_type_unittest.py:
2786         (DeviceTypeTest):
2787         (DeviceTypeTest.test_unmapped_version): Test case where the version does not have
2788         an associated named.
2789
2790 2019-02-05  Olivier Blin  <olivier.blin@softathome.com>
2791
2792         [WPE] require python3-setuptools for meson build in jhbuild
2793         https://bugs.webkit.org/show_bug.cgi?id=194287
2794
2795         Reviewed by Philippe Normand.
2796
2797         python3-setuptools is needed to build meson in jhbuild.
2798         It is already required by the GTK port.
2799
2800         * wpe/install-dependencies:
2801
2802 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2803
2804         [ews-app] Add method to save BuilderMapping to database
2805         https://bugs.webkit.org/show_bug.cgi?id=194264
2806
2807         Reviewed by Lucas Forschler.
2808
2809         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2810         (BuilderMapping.__str__):
2811         (BuilderMapping):
2812         (BuilderMapping.save_mapping):
2813         (BuilderMapping.update_mapping):
2814         (BuilderMapping.get_existing_mapping):
2815         (BuilderMapping.is_valid_mapping):
2816
2817 2019-02-05  Aakash Jain  <aakash_jain@apple.com>
2818
2819         [ews-app] Add timestamp fields for BuilderMappings
2820         https://bugs.webkit.org/show_bug.cgi?id=194266
2821
2822         Reviewed by Lucas Forschler.
2823
2824         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
2825         (BuilderMapping):
2826
2827 2019-02-04  Ms2ger  <Ms2ger@igalia.com>
2828
2829         [GTK][WPE] Need a function to convert internal URI to display ("pretty") URI
2830         https://bugs.webkit.org/show_bug.cgi?id=174816
2831
2832         Reviewed by Michael Catanzaro.
2833
2834         Add tests for webkit_uri_for_display().
2835
2836         * TestWebKitAPI/Tests/WebKitGLib/TestWebKitURIUtilities.cpp: Added.
2837         (testURIForDisplayUnaffected):
2838         (testURIForDisplayAffected):
2839         (beforeAll):
2840         (afterAll):
2841         * TestWebKitAPI/glib/CMakeLists.txt:
2842
2843 2019-02-04  Jonathan Bedard  <jbedard@apple.com>
2844
2845         webkitpy: Precedence of booted devices should match precedence in DEFAULT_DEVICE_TYPES
2846         https://bugs.webkit.org/show_bug.cgi?id=194158
2847         <rdar://problem/47737268>
2848
2849         Rubber-stamped by Aakash Jain.
2850
2851         * Scripts/webkitpy/port/device_port.py:
2852         (DevicePort.supported_device_types): Sort supported device types by the DEFAULT_DEVICE_TYPES.
2853
2854 2019-02-04  Said Abou-Hallawa  <said@apple.com>
2855
2856         [CG] Enable setAdditionalSupportedImageTypes for WK1
2857         https://bugs.webkit.org/show_bug.cgi?id=194190
2858
2859         Reviewed by Tim Horton.
2860
2861         Add a test similar to the one under WebKit Cocoa but make it create a
2862         WebView instead of a WKWebView.
2863
2864         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2865         * TestWebKitAPI/Tests/mac/100x100-red.tga: Added.
2866         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.html: Added.
2867         * TestWebKitAPI/Tests/mac/AdditionalSupportedImageTypes.mm: Added.
2868         (-[AdditionalSupportedImageTypesTest webView:didFinishLoadForFrame:]):
2869         (TestWebKitAPI::runTest):
2870         (TestWebKitAPI::TEST):
2871
2872 2019-02-04  Zalan Bujtas  <zalan@apple.com>
2873
2874         [First paint] Adjust "finishedParsingMainDocument" flag by taking deferred and async scripts into account.
2875         https://bugs.webkit.org/show_bug.cgi?id=194168
2876
2877         Reviewed by Simon Fraser.
2878
2879         Test if the firstVisuallyNoneEmpty milestone fires before the deferred script's post-message. 
2880
2881         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
2882         * TestWebKitAPI/Tests/WebKit/FirstVisuallyNonEmptyMilestoneWithDeferredScript.mm: Added.
2883         (-[FirstPaintMessageHandler userContentController:didReceiveScriptMessage:]):
2884         (-[RenderingProgressNavigationDelegate _webView:renderingProgressDidChange:]):
2885         (TEST):
2886         * TestWebKitAPI/Tests/WebKit/deferred-script-load.html: Added.
2887         * TestWebKitAPI/Tests/WebKit/deferred-script.js: Added.
2888
2889 2019-02-04  Dean Johnson  <dean_johnson@apple.com>
2890
2891         REGRESSION (r237269): webkit-patch what-broke is broken 
2892         https://bugs.webkit.org/show_bug.cgi?id=193025
2893
2894         Reviewed by Aakash Jain.
2895
2896         * Scripts/webkitpy/common/host.py:
2897         (Host.buildbot):
2898         (Host.bugzilla): Renamed to 'buildbot'.
2899
2900 2019-02-04  Wenson Hsieh  <wenson_hsieh@apple.com>
2901
2902         [iOS] API test WKAttachmentTests.InsertAndRemoveDuplicateAttachment is failing after r240902
2903         https://bugs.webkit.org/show_bug.cgi?id=194207
2904
2905         Reviewed by Tim Horton.
2906
2907         Fix this API test by making it robust against smart paste on iOS. Currently, this test pastes an attachment
2908         element and assumes that the pasted attachment is adjacent to the original one. However, after enabling smart
2909         paste, we now insert an extra space in between. Instead of executing "DeleteBackward" twice to test removing the
2910         attachment elements, we delete backwards once to remove the pasted attachment, and move the selection to the
2911         start and delete forwards to remove the original attachment.
2912
2913         * TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
2914         (TestWebKitAPI::TEST):
2915
2916 2019-02-04  Youenn Fablet  <youenn@apple.com>
2917
2918         Capture state should be managed consistently when doing process swapping
2919         https://bugs.webkit.org/show_bug.cgi?id=194122
2920         <rdar://problem/47609293>
2921
2922         Reviewed by Eric Carlson.
2923
2924         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
2925         (-[GetUserMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
2926         (-[GetUserMediaUIDelegate _webView:checkUserMediaPermissionForURL:mainFrameURL:frameIdentifier:decisionHandler:]):
2927         (-[GetUserMediaUIDelegate _webView:mediaCaptureStateDidChange:]):
2928         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
2929         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
2930         (WTR::TestRunner::isDoingMediaCapture const):
2931         * WebKitTestRunner/InjectedBundle/TestRunner.h:
2932         * WebKitTestRunner/TestController.cpp:
2933         (WTR::TestController::isDoingMediaCapture const):
2934         * WebKitTestRunner/TestController.h:
2935         * WebKitTestRunner/TestInvocation.cpp:
2936         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
2937         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
2938         (WTR::TestController::isDoingMediaCapture const):
2939
2940 2019-02-03  Fujii Hironori  <Hironori.Fujii@sony.com>
2941
2942         [Win] WebKitTestRunners is failing to create the IndexedDB directory.
2943         https://bugs.webkit.org/show_bug.cgi?id=194142
2944
2945         Reviewed by Ross Kirsling.
2946
2947         There three 'separator' variables in TestController.cpp. Renamed
2948         it 'pathSeparator', and unified them.
2949
2950         * WebKitTestRunner/TestController.cpp:
2951         (WTR::TestController::generateContextConfiguration const):
2952         (WTR::createTestURL):
2953         (WTR::TestController::platformAdjustContext):
2954
2955 2019-02-03  Simon Fraser  <simon.fraser@apple.com>
2956
2957         Make setNeedsLayout on the root more explicitly about triggering its side-effects
2958         https://bugs.webkit.org/show_bug.cgi?id=194198
2959
2960         Reviewed by Antti Koivisto.
2961
2962         No need to set the banner heights on navigation now, since Page stores them.
2963
2964         * MiniBrowser/mac/WK2BrowserWindowController.m:
2965         (-[WK2BrowserWindowController webView:didFinishNavigation:]):
2966
2967 2019-02-03  John Wilander  <wilander@apple.com>
2968
2969         Parse and handle Ad Click Attribution attributes in HTMLAnchorElement::handleClick()
2970         https://bugs.webkit.org/show_bug.cgi?id=194104
2971         <rdar://problem/47649991>
2972
2973         Reviewed by Chris Dumez, Daniel Bates, and Darin Adler.
2974
2975         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp:
2976         (TestWebKitAPI::TEST):
2977             Changed numeric types from unsigned short to uint32_t.
2978
2979 2019-02-02  David Kilzer  <ddkilzer@apple.com>
2980
2981         Leak of NSArray (4.25 Kbytes) in com.apple.WebKit.WebContent running WebKit layout tests on iOS Simulator
2982         <https://webkit.org/b/194178>
2983         <rdar://problem/47753473>
2984
2985         Reviewed by Alexey Proskuryakov.
2986
2987         * WebKitTestRunner/InjectedBundle/cocoa/ActivateFontsCocoa.mm:
2988         (WTR::uninstallFakeHelvetica): Pass nullptr into
2989         CTFontManagerUnregisterFontsForURLs() to ignore any errors.
2990
2991 2019-02-02  Zalan Bujtas  <zalan@apple.com>
2992
2993         [LFC] Initialize ICB's style with fixed width/height.
2994         https://bugs.webkit.org/show_bug.cgi?id=194188
2995
2996         Reviewed by Antti Koivisto.
2997
2998         * LayoutReloaded/misc/LFC-passing-tests.txt:
2999
3000 2019-02-02  Zalan Bujtas  <zalan@apple.com>
3001
3002         [LFC] Add missing case to out-of-flow non-replaced horizontal used margin value computation
3003         https://bugs.webkit.org/show_bug.cgi?id=194185
3004
3005         Reviewed by Antti Koivisto.
3006
3007         * LayoutReloaded/misc/LFC-passing-tests.txt:
3008
3009 2018-12-16  Darin Adler  <darin@apple.com>
3010
3011         Convert additional String::format clients to alternative approaches
3012         https://bugs.webkit.org/show_bug.cgi?id=192746
3013
3014         Reviewed by Alexey Proskuryakov.
3015
3016         * WebKitTestRunner/TestController.cpp:
3017         (WTR::originUserVisibleName): Use makeString and reduce the use of std::string
3018         as an intermediate in code that ultimately constructs a WTF::String.
3019         (WTR::userMediaOriginHash): Use makeString.
3020         (WTR::TestController::didNavigateWithNavigationData): More of the same.
3021         (WTR::TestController::didPerformClientRedirect): Ditto.
3022         (WTR::TestController::didPerformServerRedirect): Ditto.
3023         (WTR::TestController::didUpdateHistoryTitle): Ditto.
3024
3025 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3026
3027         [ews-build] Add unit test to verify builder keys
3028         https://bugs.webkit.org/show_bug.cgi?id=194152
3029
3030         Reviewed by Lucas Forschler.
3031
3032         * BuildSlaveSupport/ews-build/loadConfig_unittest.py:
3033         (ConfigDotJSONTest.test_builder_keys): Added unit-test.
3034
3035 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3036
3037         [LFC] Expand tests coverage (12 new tests -> 787)
3038
3039         Unreviewed test gardening.
3040
3041         * LayoutReloaded/misc/LFC-passing-tests.txt:
3042
3043 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3044
3045         [LFC] Fix statically positioned replaced out-of-flow horizontal geometry
3046         https://bugs.webkit.org/show_bug.cgi?id=194163
3047
3048         Reviewed by Simon Fraser.
3049
3050         775
3051
3052         * LayoutReloaded/misc/LFC-passing-tests.txt:
3053
3054 2019-02-01  Wenson Hsieh  <wenson_hsieh@apple.com>
3055
3056         [iOS] Consistent 1 sec hang when triggering modal alerts while handling synchronous touch events
3057         https://bugs.webkit.org/show_bug.cgi?id=194140
3058         <rdar://problem/47728098>
3059
3060         Reviewed by Tim Horton.
3061
3062         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3063         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3064         (WTR::TestRunner::setShouldDismissJavaScriptAlertsAsynchronously):
3065
3066         Add a new TestRunner hook to make modal JavaScript alerts dismiss asynchronously. This is used by the new layout
3067         test to induce an IPC deadlock when presenting a modal alert during touch start.
3068
3069         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3070         * WebKitTestRunner/TestController.cpp:
3071         (WTR::runJavaScriptAlert):
3072
3073         Add a client callback function for running JavaScript alerts.
3074
3075         (WTR::TestController::createOtherPage):
3076         (WTR::TestController::generateContextConfiguration const):
3077
3078         Add a test option to disable IPC timeouts for a layout test. This forces the test to reliably time out without
3079         the fix in this patch.
3080
3081         (WTR::TestController::createWebViewWithOptions):
3082
3083         Plumb TestOptions to generateContextConfiguration.
3084
3085         (WTR::TestController::resetPreferencesToConsistentValues):
3086         (WTR::TestController::resetStateToConsistentValues):
3087         (WTR::updateTestOptionsFromTestHeader):
3088         (WTR::TestController::setShouldDismissJavaScriptAlertsAsynchronously):
3089         (WTR::TestController::handleJavaScriptAlert):
3090         * WebKitTestRunner/TestController.h:
3091         * WebKitTestRunner/TestInvocation.cpp:
3092         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3093         * WebKitTestRunner/TestOptions.h:
3094         (WTR::TestOptions::hasSameInitializationOptions const):
3095
3096 2019-02-01  Chris Dumez  <cdumez@apple.com>
3097
3098         REGRESSION: Flaky ASSERTION FAILED: m_uncommittedState.state == State::Committed on http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html
3099         https://bugs.webkit.org/show_bug.cgi?id=193740
3100         <rdar://problem/47527267>
3101
3102         Reviewed by Alex Christensen.
3103
3104         Add API test coverage.
3105
3106         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3107
3108 2019-02-01  Aakash Jain  <aakash_jain@apple.com>
3109
3110         [ews-app] Add display name field to BuilderMapping model
3111         https://bugs.webkit.org/show_bug.cgi?id=194153
3112
3113         Reviewed by Lucas Forschler.
3114
3115         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3116         (BuilderMapping):
3117
3118 2019-02-01  Youenn Fablet  <youenn@apple.com>
3119
3120         API Test broken: TestWebKitAPI.WebKit2.GetUserMediaReprompt
3121         https://bugs.webkit.org/show_bug.cgi?id=194155
3122
3123         Reviewed by Eric Carlson.
3124
3125         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3126         Revert use of async functions as it seems it cannot be evaluated from TestWebKitAPI.
3127         Keep calling enumerateDevices to continue cover https://bugs.webkit.org/show_bug.cgi?id=194106.
3128
3129 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3130
3131         [LFC] Adjust replaced element's intrinsic ratio
3132         https://bugs.webkit.org/show_bug.cgi?id=194154
3133
3134         Reviewed by Antti Koivisto.
3135
3136         761
3137
3138         * LayoutReloaded/misc/LFC-passing-tests.txt:
3139
3140 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3141
3142         [WPE] Show test results in minibrowser
3143         https://bugs.webkit.org/show_bug.cgi?id=194150
3144
3145         Reviewed by Žan Doberšek.
3146
3147         * Scripts/webkitpy/port/wpe.py:
3148         (WPEPort.show_results_html_file):
3149
3150 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3151
3152         [WPE] MiniBrowser: add ky bindings for back/forward navigation
3153         https://bugs.webkit.org/show_bug.cgi?id=194151
3154
3155         Reviewed by Žan Doberšek.
3156
3157         ALT + <- go back
3158         ALT + -> go forward
3159
3160         * MiniBrowser/wpe/main.cpp:
3161         (main):
3162
3163 2019-02-01  Zalan Bujtas  <zalan@apple.com>
3164
3165         [LFC] Set intrinsic size on Layout::Replaced
3166         https://bugs.webkit.org/show_bug.cgi?id=194139
3167
3168         Reviewed by Antti Koivisto.
3169
3170         744
3171
3172         * LayoutReloaded/misc/LFC-passing-tests.txt:
3173
3174 2019-02-01  Carlos Garcia Campos  <cgarcia@igalia.com>
3175
3176         [WPE] MiniBrowser: use g_file_new_for_commandline_arg
3177         https://bugs.webkit.org/show_bug.cgi?id=194146
3178
3179         Reviewed by Xabier Rodriguez-Calvar.
3180
3181         It allows to open relative paths.
3182
3183         * MiniBrowser/wpe/main.cpp:
3184         (main):
3185
3186 2019-01-31  Ryan Haddad  <ryanhaddad@apple.com>
3187
3188         Update flakiness dashboard configuration after recent queue changes
3189         https://bugs.webkit.org/show_bug.cgi?id=194127
3190
3191         Rubber-stamped by Aakash Jain.
3192
3193         Apple Windows queues were updated in r237755, and Sierra was removed in r239859.
3194
3195         * TestResultServer/static-dashboards/builders.jsonp:
3196
3197 2019-01-31  Youenn Fablet  <youenn@apple.com>
3198
3199         Add an API test to cover UIClient checkUserMediaPermissionForOrigin being nullptr
3200         https://bugs.webkit.org/show_bug.cgi?id=194106
3201         <rdar://problem/47676333>
3202
3203         Reviewed by Ryosuke Niwa.
3204
3205         * TestWebKitAPI/Tests/WebKit/UserMedia.cpp:
3206         (TestWebKitAPI::didFinishNavigation):
3207         (TestWebKitAPI::TEST):
3208         * TestWebKitAPI/Tests/WebKit/getUserMedia.html:
3209
3210 2019-01-31  Chris Dumez  <cdumez@apple.com>
3211
3212         Page zoom level is lost after a process swap or a crash
3213         https://bugs.webkit.org/show_bug.cgi?id=194105
3214         <rdar://problem/47610781>
3215
3216         Reviewed by Alex Christensen.
3217
3218         Add API test coverage.
3219
3220         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3221         (-[PSONNavigationDelegate webView:didCommitNavigation:]):
3222
3223 2019-01-31  Alex Christensen  <achristensen@webkit.org>
3224
3225         Revert r238819 which is unneeded and caused a performance regression.
3226         https://bugs.webkit.org/show_bug.cgi?id=192272
3227         <rdar://problem/46664625>
3228
3229         * TestWebKitAPI/Tests/WebKitCocoa/ParserYieldTokenPlugIn.mm:
3230         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:didCommitLoadForFrame:]):
3231         (-[ParserYieldTokenPlugIn webProcessPlugInBrowserContextController:willStartProvisionalLoadForFrame:completionHandler:]): Deleted.
3232
3233 2019-01-31  Jiewen Tan  <jiewen_tan@apple.com>
3234
3235         Formalize WebKitAdditions mechanism of LoadOptimizer
3236         https://bugs.webkit.org/show_bug.cgi?id=193886
3237         <rdar://problem/47696809>
3238
3239         Reviewed by Brent Fulgham.
3240
3241         * MiniBrowser/MiniBrowser.entitlements:
3242         Make com.apple.security.temporary-exception.mach-lookup.global-name an array.
3243
3244 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3245
3246         [LFC] Margin before/after/start/end initial value is 0 and not auto.
3247         https://bugs.webkit.org/show_bug.cgi?id=194090
3248
3249         Reviewed by Antti Koivisto.
3250
3251         * LayoutReloaded/misc/LFC-passing-tests.txt:
3252
3253 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3254
3255         [LFC] Use the used margin values in outOfFlowReplacedHorizontalGeometry consistently
3256         https://bugs.webkit.org/show_bug.cgi?id=194074
3257
3258         Reviewed by Antti Koivisto.
3259
3260         * LayoutReloaded/misc/LFC-passing-tests.txt:
3261
3262 2019-01-31  Zalan Bujtas  <zalan@apple.com>
3263
3264         [LFC][BFC] Add support for block level replaced box.
3265         https://bugs.webkit.org/show_bug.cgi?id=194071
3266
3267         Reviewed by Antti Koivisto.
3268
3269         * LayoutReloaded/misc/LFC-passing-tests.txt:
3270
3271 2019-01-31  Fujii Hironori  <Hironori.Fujii@sony.com>
3272
3273         Fix WebKitTestRunner's testPath with Windows full paths
3274         https://bugs.webkit.org/show_bug.cgi?id=194012
3275
3276         Reviewed by Alex Christensen.
3277
3278         updateTestOptionsFromTestHeader failed to open test files because
3279         testPath returned wrong file paths. It returned a path "/C:/..."
3280         if a URL "file:///C:/..." was given.
3281
3282         * WebKitTestRunner/TestController.cpp:
3283         (WTR::testPath): Removed the first '/' if the path starts with something like "/C:/".
3284
3285 2019-01-31  Carlos Garcia Campos  <cgarcia@igalia.com>
3286
3287         [WPE] Bump font related dependencies to match the GTK+ port
3288         https://bugs.webkit.org/show_bug.cgi?id=194017
3289
3290         Reviewed by Žan Doberšek.
3291
3292         * wpe/jhbuild.modules:
3293         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3294         * wpe/patches/icudata-stdlibs.patch: Added.
3295
3296 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3297
3298         Enable swipe tests on iOS
3299         https://bugs.webkit.org/show_bug.cgi?id=194076
3300
3301         Reviewed by Geoffrey Garen.
3302
3303         Removed the superflous call to prepareForAsyncTask and asyncTaskComplete as
3304         it causes a debug assertion failure in runUIScript.
3305
3306         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
3307         (WTR::UIScriptController::beginBackSwipe):
3308         (WTR::UIScriptController::completeBackSwipe):
3309
3310 2019-01-30  Keith Rollin  <krollin@apple.com>
3311
3312         Use correct printf format specifier
3313         https://bugs.webkit.org/show_bug.cgi?id=194062
3314         <rdar://problem/47686167>
3315
3316         Reviewed by Alexey Proskuryakov.
3317
3318         LayoutTestSpellChecker.mm is trying to format a variable of type
3319         NSTextCheckingType with %tu (unsigned ptrdiff_t), when the type is
3320         actually an unsigned long long. Fix this by formatting with %llu.
3321
3322         * TestRunnerShared/cocoa/LayoutTestSpellChecker.mm:
3323         (-[LayoutTestTextCheckingResult description]):
3324
3325 2019-01-30  Ryosuke Niwa  <rniwa@webkit.org>
3326
3327         REGRESSION(r240541): WebKit.WebsitePoliciesCustomJavaScriptUserAgent is failing since introduction on iOS
3328         https://bugs.webkit.org/show_bug.cgi?id=193979
3329
3330         Reviewed by Wenson Hsieh.
3331
3332         Fix the test for iOS. Make the test work with iOS UA string.
3333
3334         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3335
3336 2019-01-30  Ryan Haddad  <ryanhaddad@apple.com>
3337
3338         Replace High Sierra LLINT CLoop bot due to hardware failure
3339         https://bugs.webkit.org/show_bug.cgi?id=194066
3340
3341         Reviewed by Aakash Jain.
3342
3343         * BuildSlaveSupport/build.webkit.org-config/config.json:
3344
3345 2019-01-30  Keith Rollin  <krollin@apple.com>
3346
3347         [NSDragItem init] is unavailable
3348         https://bugs.webkit.org/show_bug.cgi?id=194059
3349         <rdar://problem/47685715>
3350
3351         Reviewed by Wenson Hsieh.
3352
3353         [NSDragItem init] is marked as NS_UNAVAILABLE. This affects
3354         DumpRenderTree and TestWebKitAPI, which both try to create an
3355         NSDragItem in a manner that invokes this method. Address this by using
3356         -initWithPasteboardWriter instead.
3357
3358         Note that the parameter passed to initWithPasteboardWriter is likely
3359         incorrect. In both cases, the object passed does not conform to
3360         NSPasteboardWriting. However, with this fix, we're no worse off than
3361         before, and can now perform builds with newer compilers and SDKs until
3362         a real fix can be crafted. That work is tracked in
3363         https://bugs.webkit.org/show_bug.cgi?id=194060
3364
3365         * DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
3366         (-[DumpRenderTreeDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3367         * TestWebKitAPI/mac/TestDraggingInfo.mm:
3368         (-[TestDraggingInfo enumerateDraggingItemsWithOptions:forView:classes:searchOptions:usingBlock:]):
3369
3370 2019-01-30  Daniel Bates  <dabates@apple.com>
3371
3372         [iOS] Keyups for non-modifier keys identified as "Dead" when not focused in a content-editable element
3373         https://bugs.webkit.org/show_bug.cgi?id=192824
3374         <rdar://problem/47100332>
3375
3376         Reviewed by Wenson Hsieh.
3377
3378         Fix a bug where the wrong usage code was used for F13 thru F24.
3379
3380         * WebKitTestRunner/ios/HIDEventGenerator.mm:
3381         (keyCodeForDOMFunctionKey):
3382
3383 2019-01-30  Chris Dumez  <cdumez@apple.com>
3384
3385         Regression(PSON) Load hang can occur on history navigation
3386         https://bugs.webkit.org/show_bug.cgi?id=194030
3387         <rdar://problem/47656939>
3388
3389         Reviewed by Antti Koivisto.
3390
3391         Add API test coverage.
3392
3393         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3394
3395 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3396
3397         [LFC] Expand tests coverage.
3398
3399         Unreviewed test gardening.
3400
3401         * LayoutReloaded/misc/LFC-passing-tests.txt:
3402
3403 2019-01-30  Thibault Saunier  <tsaunier@igalia.com>
3404
3405         [Flatpak] Add openjpeg support
3406         https://bugs.webkit.org/show_bug.cgi?id=194019
3407
3408         Reviewed by Michael Catanzaro.
3409
3410         * flatpak/org.webkit.CommonModules.yaml:
3411
3412 2019-01-30  Commit Queue  <commit-queue@webkit.org>
3413
3414         Unreviewed, rolling out r240708.
3415         https://bugs.webkit.org/show_bug.cgi?id=194022
3416
3417         It broke WPE build (Requested by KaL on #webkit).
3418
3419         Reverted changeset:
3420
3421         "[WPE] Bump font related dependencies to match the GTK+ port"
3422         https://bugs.webkit.org/show_bug.cgi?id=194017
3423         https://trac.webkit.org/changeset/240708
3424
3425 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3426
3427         [LFC][IFC] nextBreakablePosition returns the same position on hyphen characters
3428         https://bugs.webkit.org/show_bug.cgi?id=194001
3429
3430         Reviewed by Antti Koivisto.
3431
3432         * LayoutReloaded/misc/LFC-passing-tests.txt:
3433
3434 2019-01-30  Zalan Bujtas  <zalan@apple.com>
3435
3436         [LFC] Use the used margin values in outOfFlowReplacedVerticalGeometry consistently
3437         https://bugs.webkit.org/show_bug.cgi?id=194020
3438
3439         Reviewed by Antti Koivisto.
3440
3441         * LayoutReloaded/misc/LFC-passing-tests.txt:
3442
3443 2019-01-30  Chris Fleizach  <cfleizach@apple.com>
3444
3445         AX: Support color well on iOS
3446         https://bugs.webkit.org/show_bug.cgi?id=194010
3447
3448         Reviewed by Joanmarie Diggs.
3449
3450         * WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:
3451         (WTR::AccessibilityUIElement::stringAttributeValue):
3452
3453 2019-01-30  Carlos Garcia Campos  <cgarcia@igalia.com>
3454
3455         [WPE] Bump font related dependencies to match the GTK+ port
3456         https://bugs.webkit.org/show_bug.cgi?id=194017
3457
3458         Reviewed by Žan Doberšek.
3459
3460         * wpe/jhbuild.modules:
3461         * wpe/patches/cairo-ft-Use-FT_Done_MM_Var-instead-of-free-when-available.patch: Added.
3462         * wpe/patches/icudata-stdlibs.patch: Added.
3463
3464 2019-01-29  Alexey Proskuryakov  <ap@apple.com>
3465
3466         [Mac] Update window scale API usage
3467         https://bugs.webkit.org/show_bug.cgi?id=193991
3468         rdar://problem/47614795
3469
3470         Reviewed by Tim Horton.
3471
3472         * DumpRenderTree/mac/DumpRenderTree.mm:
3473         (changeWindowScaleIfNeeded):
3474         * DumpRenderTree/mac/DumpRenderTreeWindow.h:
3475         * WebKitTestRunner/mac/PlatformWebViewMac.mm:
3476         (WTR::PlatformWebView::changeWindowScaleIfNeeded):
3477
3478 2019-01-29  Chris Dumez  <cdumez@apple.com>
3479
3480         REGRESSION: ProcessSwap.DoSameSiteNavigationAfterCrossSiteProvisionalLoadStarted Failing on iOS
3481         https://bugs.webkit.org/show_bug.cgi?id=193977
3482         <rdar://problem/47643716>
3483
3484         Reviewed by Geoff Garen.
3485
3486         Update API test to address flakiness on iOS. Instead of doing the last navigation after receiving the
3487         didStartProvisionalLoad, do we right after we answer the navigation policy request. Flakiness was due
3488         to the previous provisional committing *before* we make the last load. 
3489
3490         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3491
3492 2019-01-29  Youenn Fablet  <youenn@apple.com>
3493
3494         Adopt new SPI to evaluate server certificate trust
3495         https://bugs.webkit.org/show_bug.cgi?id=193355
3496
3497         Reviewed by Alex Christensen.
3498
3499         Add infrastructure to handle HTTPS server trust evaluation testing.
3500
3501         * WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
3502         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3503         (WTR::TestRunner::setCanHandleHTTPSServerTrustEvaluation):
3504         (WTR::TestRunner::canDoServerTrustEvaluationInNetworkProcess):
3505         (WTR::TestRunner::serverTrustEvaluationCallbackCallsCount):
3506         * WebKitTestRunner/InjectedBundle/TestRunner.h:
3507         * WebKitTestRunner/TestController.cpp:
3508         (WTR::TestController::resetPreferencesToConsistentValues):
3509         (WTR::TestController::didReceiveAuthenticationChallenge):
3510         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3511         * WebKitTestRunner/TestController.h:
3512         (WTR::TestController::serverTrustEvaluationCallbackCallsCount const):
3513         * WebKitTestRunner/TestInvocation.cpp:
3514         (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
3515         * WebKitTestRunner/cocoa/TestControllerCocoa.mm:
3516         (WTR::TestController::canDoServerTrustEvaluationInNetworkProcess const):
3517
3518 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3519
3520         [ews-build] Add build step to print bot Configuration
3521         https://bugs.webkit.org/show_bug.cgi?id=193887
3522
3523         Reviewed by Lucas Forschler.
3524
3525         * BuildSlaveSupport/ews-build/steps.py:
3526         (PrintConfiguration): Build step to print configuration.
3527         * BuildSlaveSupport/ews-build/factories.py:
3528
3529 2019-01-29  Chris Dumez  <cdumez@apple.com>
3530
3531         Regression (r240046): [PSON] Spurious changes to [WKWebView url] and [WKWebView loading] after [WKWebView loadRequest]
3532         https://bugs.webkit.org/show_bug.cgi?id=193967
3533         <rdar://problem/47635348>
3534
3535         Reviewed by Alex Christensen.
3536
3537         Add API test coverage.
3538
3539         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3540         (-[PSONLoadingObserver observeValueForKeyPath:ofObject:change:context:]):
3541
3542 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3543
3544         [ews-app] Handle incoming results data
3545         https://bugs.webkit.org/show_bug.cgi?id=193973
3546
3547         Reviewed by Lucas Forschler.
3548
3549         * BuildSlaveSupport/ews-app/ews/views/results.py:
3550
3551 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3552
3553         [ews-app] Make the results url generic
3554         https://bugs.webkit.org/show_bug.cgi?id=193928
3555
3556         Reviewed by Lucas Forschler.
3557
3558         * BuildSlaveSupport/ews-app/ews/urls.py:
3559
3560 2019-01-29  Aakash Jain  <aakash_jain@apple.com>
3561
3562         [ews-build] Configure buildbot to send events to ews-app
3563         https://bugs.webkit.org/show_bug.cgi?id=193968
3564
3565         Reviewed by Lucas Forschler.
3566
3567         * BuildSlaveSupport/ews-build/events.py: Added.
3568         * BuildSlaveSupport/ews-build/master.cfg:
3569
3570 2019-01-29  Keith Rollin  <krollin@apple.com>
3571
3572         Add .xcfilelists to Run Script build phases
3573         https://bugs.webkit.org/show_bug.cgi?id=193792
3574         <rdar://problem/47201785>
3575
3576         Reviewed by Alex Christensen.
3577
3578         As part of supporting XCBuild, update the necessary Run Script build
3579         phases in their Xcode projects to refer to their associated
3580         .xcfilelist files.
3581
3582         Note that the addition of these files bumps the Xcode project version
3583         number to something that's Xcode 10 compatible. This change means that
3584         older versions of the Xcode IDE can't read these projects. Nor can it
3585         fully load workspaces that refer to these projects (the updated
3586         projects are shown as non-expandable placeholders). `xcodebuild` can
3587         still build these projects; it's just that the IDE can't open them.
3588
3589         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3590         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3591
3592 2019-01-29  John Wilander  <wilander@apple.com>
3593
3594         Add data abstraction and validation for Ad Click Attribution
3595         https://bugs.webkit.org/show_bug.cgi?id=193916
3596         <rdar://problem/47603481>
3597
3598         Reviewed by Daniel Bates, Brent Fulgham, and Alex Christensen.
3599
3600         Ad click attribution has two steps. First, the storage of an ad
3601         campaign ID for a click that takes the user to a destination
3602         site. Second, a conversion on the destination site that can be
3603         attributed to the ad click.
3604
3605         This patch adds a class that represents a request for ad click
3606         attribution. Validation makes sure that the bits of entropy
3607         reported through this mechanism is limited.
3608
3609         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3610         * TestWebKitAPI/Tests/WebCore/AdClickAttribution.cpp: Added.
3611         (TestWebKitAPI::TEST):
3612
3613 2019-01-29  Chris Dumez  <cdumez@apple.com>
3614
3615         REGRESSION (PSON): Twitter link gets stuck at t.co after navigating back in tab
3616         https://bugs.webkit.org/show_bug.cgi?id=193932
3617         <rdar://problem/47598947>
3618
3619         Reviewed by Brady Eidson.
3620
3621         Add API test coverage.
3622
3623         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3624
3625 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3626
3627         Adding new passing LFC tests.
3628
3629         Unreviewed test gardening.
3630
3631         * LayoutReloaded/misc/LFC-passing-tests.txt:
3632
3633 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3634
3635         [LFC][BFC][MarginCollapsing] Remove incorrect downcast<Container>
3636         https://bugs.webkit.org/show_bug.cgi?id=193964
3637
3638         Reviewed by Antti Koivisto.
3639
3640         * LayoutReloaded/misc/LFC-passing-tests.txt:
3641
3642 2019-01-29  Zalan Bujtas  <zalan@apple.com>
3643
3644         [LFC][BFC] Do not ignore next sibling box while laying out BFC.
3645         https://bugs.webkit.org/show_bug.cgi?id=193954
3646
3647         Reviewed by Antti Koivisto.
3648
3649         * LayoutReloaded/misc/LFC-passing-tests.txt:
3650
3651 2019-01-29  Carlos Garcia Campos  <cgarcia@igalia.com>
3652
3653         WebDriver: add support for running subtests
3654         https://bugs.webkit.org/show_bug.cgi?id=193904
3655
3656         Reviewed by Michael Catanzaro.
3657
3658         pytest already supports it by passing test.py::subtest, so we can do the same.
3659
3660         * Scripts/webkitpy/webdriver_tests/pytest_runner.py:
3661         (get_item_name): Made this global.
3662         (CollectRecorder.__init__): Receive the parameter to ignore.
3663         (CollectRecorder.pytest_collectreport): Collect also the subtests.
3664         (TestExpectationsMarker.pytest_collection_modifyitems): Use get_item_name().
3665         (collect): Add parameter to ignore.
3666         * Scripts/webkitpy/webdriver_tests/webdriver_selenium_executor.py:
3667         (WebDriverSeleniumExecutor.collect): Pass the driver name as parameter to ignore.
3668         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_selenium.py:
3669         (WebDriverTestRunnerSelenium.collect_tests): Handle subtest name in test path.
3670         (WebDriverTestRunnerSelenium.run): Ditto.
3671         * Scripts/webkitpy/webdriver_tests/webdriver_test_runner_w3c.py:
3672         (WebDriverTestRunnerW3C.collect_tests): Ditto.
3673         (WebDriverTestRunnerW3C.run): Ditto.
3674
3675 2019-01-28  Ryosuke Niwa  <rniwa@webkit.org>
3676
3677         User agent string override for navigator.userAgent should be site specific quirks
3678         https://bugs.webkit.org/show_bug.cgi?id=193950
3679
3680         Reviewed by Brent Fulgham.
3681
3682         Updated per the _WKWebsitePolicies rename.
3683
3684         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3685         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3686
3687 2019-01-28  Ross Kirsling  <ross.kirsling@sony.com>
3688
3689         Remove unnecessary `using namespace WTF`s (or at least restrict their scope).
3690         https://bugs.webkit.org/show_bug.cgi?id=193941
3691
3692         Reviewed by Alex Christensen.
3693
3694         * TestWebKitAPI/Tests/WTF/ConcurrentPtrHashSet.cpp:
3695         * TestWebKitAPI/Tests/WTF/Condition.cpp:
3696         * TestWebKitAPI/Tests/WTF/Lock.cpp:
3697         * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
3698         * TestWebKitAPI/Tests/WTF/ParkingLot.cpp:
3699         * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
3700         * TestWebKitAPI/Tests/WTF/ScopedLambda.cpp:
3701         * TestWebKitAPI/Tests/WTF/Time.cpp:
3702         * TestWebKitAPI/Tests/WTF/UniqueArray.cpp:
3703         * TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:
3704         * TestWebKitAPI/Tests/WebCore/Logging.cpp:
3705         * WebKitTestRunner/InjectedBundle/cocoa/InjectedBundlePageCocoa.mm:
3706
3707 2019-01-28  Yusuke Suzuki  <ysuzuki@apple.com>
3708
3709         Unreviewed, reorder my emails to fix autocomplete in bugzilla
3710
3711         * Scripts/webkitpy/common/config/contributors.json:
3712
3713 2019-01-28  Andy Estes  <aestes@apple.com>
3714
3715         [watchOS] Enable Parental Controls content filtering
3716         https://bugs.webkit.org/show_bug.cgi?id=193939
3717         <rdar://problem/46641912>
3718
3719         Reviewed by Ryosuke Niwa.
3720
3721         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3722
3723 2019-01-28  David Kilzer  <ddkilzer@apple.com>
3724
3725         REGRESSION (r236481): Move soft-linking of LocalAuthentication.framework out of LocalAuthenticationSoftLink.h
3726         <https://webkit.org/b/193884>
3727
3728         Reviewed by Jiewen Tan.
3729
3730         * Scripts/webkitpy/style/checkers/cpp.py:
3731         (check_language): Add LocalAuthentication to
3732         `frameworks_with_soft_links`.
3733
3734 2019-01-28  Fujii Hironori  <Hironori.Fujii@sony.com>
3735
3736         [Win][WebKitTestRunner] Error: test and reference images have different sizes. Test image is 784x561, reference image is 800x600
3737         https://bugs.webkit.org/show_bug.cgi?id=193891
3738
3739         Reviewed by Ross Kirsling.
3740
3741         There were three problems in window sizes of WebView and the host window.
3742         1. The sizes of pixel image output were incorrect.
3743         2. The host window is going to appear after window.resize was invoked.
3744         3. window.resize resized only the host window, not WebView.
3745
3746         This change solves them with a following approach.
3747         a. PlatformWebView::PlatformWebView creates the initial host window as zero size.
3748         b. Changes the host window style from WS_OVERLAPPEDWINDOW to WS_POPUP
3749            as well as DumpRenderTree in order to match the client area and the window area.
3750         c. PlatformWebView::resizeTo simply calls PlatformWebView::setWindowFrame as well as Mac port and GTK port.
3751         d. PlatformWebView::setWindowFrame changes both window sizes.
3752         e. PlatformWebView::setWindowFrame moves the host window to the out side of screen if m_options.shouldShowWebView.
3753
3754         * WebKitTestRunner/win/PlatformWebViewWin.cpp:
3755         (WTR::PlatformWebView::PlatformWebView): Create the host window
3756         and WebView as zero size. Use WS_POPUP instead of WS_OVERLAPPEDWINDOW.
3757         (WTR::PlatformWebView::resizeTo): Calls PlatformWebView::setWindowFrame.
3758         (WTR::PlatformWebView::setWindowFrame): Change both window sizes.
3759
3760 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3761
3762         [ews-app] Add method to save Step data to database
3763         https://bugs.webkit.org/show_bug.cgi?id=193890
3764
3765         Reviewed by Lucas Forschler.
3766
3767         * BuildSlaveSupport/ews-app/ews/models/step.py:
3768         (Step.save_step): Method to save step data.
3769         (Step.update_step): Method to update step data.
3770         (Step.get_existing_step): Method to fetch existing step from database.
3771         (Step.is_valid_result): Method to validate valid step result.
3772
3773 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3774
3775         [ews-app] Add method to save Build data to database
3776         https://bugs.webkit.org/show_bug.cgi?id=193735
3777
3778         Reviewed by Lucas Forschler.
3779
3780         * BuildSlaveSupport/ews-app/ews/models/build.py:
3781         (Build.save_build): Method to save build information to database.
3782         (Build.get_existing_build): Method to fetch existing build from database.
3783         (Build.is_valid_result): Method to validate build result.
3784         * BuildSlaveSupport/ews-app/ews/common/util.py:
3785         (is_valid_int_id): Method to validate valid id.
3786
3787 2019-01-28  Chris Dumez  <cdumez@apple.com>
3788
3789         Regression(PSON) Crash under WebPageProxy::didStartProgress()
3790         https://bugs.webkit.org/show_bug.cgi?id=193915
3791         <rdar://problem/47560907>
3792
3793         Reviewed by Alex Christensen.
3794
3795         Add API test coverage.
3796
3797         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3798
3799 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3800
3801         [ews-app] Rename id variables
3802         https://bugs.webkit.org/show_bug.cgi?id=193883
3803
3804         Reviewed by Lucas Forschler.
3805
3806         * BuildSlaveSupport/ews-app/ews/models/build.py:
3807         * BuildSlaveSupport/ews-app/ews/models/buildermapping.py:
3808         * BuildSlaveSupport/ews-app/ews/models/step.py:
3809         * BuildSlaveSupport/ews-app/ews/urls.py:
3810         * BuildSlaveSupport/ews-app/ews/views/patch.py:
3811         * BuildSlaveSupport/ews-app/ews/views/results.py:
3812         * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
3813
3814 2019-01-28  Aakash Jain  <aakash_jain@apple.com>
3815
3816         [ews-app] Allow certain fields to be empty
3817         https://bugs.webkit.org/show_bug.cgi?id=193892
3818
3819         Reviewed by Lucas Forschler.
3820
3821         * BuildSlaveSupport/ews-app/ews/models/build.py:
3822         * BuildSlaveSupport/ews-app/ews/models/step.py:
3823
3824 2019-01-28  Rob Buis  <rbuis@igalia.com>
3825
3826         Update MIME type parser
3827         https://bugs.webkit.org/show_bug.cgi?id=180526
3828
3829         Reviewed by Frédéric Wang.
3830
3831         * TestWebKitAPI/Tests/WebCore/ParsedContentType.cpp:
3832         (TestWebKitAPI::TEST):
3833
3834 2019-01-28  Zalan Bujtas  <zalan@apple.com>
3835
3836         [LFC][MarginCollapsing][Quirks] Quirk margin values get propagated through margin collapsing
3837         https://bugs.webkit.org/show_bug.cgi?id=193896
3838
3839         Reviewed by Antti Koivisto.
3840
3841         * LayoutReloaded/misc/LFC-passing-tests.txt:
3842
3843 2018-12-15  Darin Adler  <darin@apple.com>
3844
3845         Replace many uses of String::format with more type-safe alternatives
3846         https://bugs.webkit.org/show_bug.cgi?id=192742
3847
3848         Reviewed by Mark Lam.
3849
3850         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
3851         (WTR::cacheTestRunnerCallback): Use makeString.
3852         * WebKitTestRunner/TestController.cpp:
3853         (WTR::TestController::didReceiveAuthenticationChallenge): Use makeString.
3854         (WTR::TestController::downloadDidFail): Use an ASCIILiteral via the _s syntax.
3855
3856 2019-01-27  Jiewen Tan  <jiewen_tan@apple.com>
3857
3858         Use a load optimizer for some sites
3859         https://bugs.webkit.org/show_bug.cgi?id=193881
3860         <rdar://problem/46325455>
3861
3862         Reviewed by Brent Fulgham.
3863
3864         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
3865         * TestWebKitAPI/Tests/WebKitCocoa/TestLoadOptimizer.mm: Added.
3866
3867 2019-01-27  Chris Fleizach  <cfleizach@apple.com>
3868
3869         AX: Introduce a static accessibility tree
3870         https://bugs.webkit.org/show_bug.cgi?id=193348
3871         <rdar://problem/47203295>
3872
3873         Reviewed by Ryosuke Niwa.
3874
3875         * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
3876
3877 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3878
3879         [LFC] The default values for top/bottom in contentHeightForFormattingContextRoot should not be 0.
3880         https://bugs.webkit.org/show_bug.cgi?id=193867
3881
3882         Reviewed by Antti Koivisto.
3883
3884         * LayoutReloaded/misc/LFC-passing-tests.txt:
3885
3886 2019-01-26  Zalan Bujtas  <zalan@apple.com>
3887
3888         [LFC][BFC] Ignore last inflow child's collapsed through margin after when computing containing block's height.
3889         https://bugs.webkit.org/show_bug.cgi?id=193865
3890
3891         Reviewed by Antti Koivisto.
3892
3893         * LayoutReloaded/misc/LFC-passing-tests.txt:
3894
3895 2019-01-25  Ryosuke Niwa  <rniwa@webkit.org>
3896
3897         Need a mechanism to override navigator.userAgent
3898         https://bugs.webkit.org/show_bug.cgi?id=193762
3899         <rdar://problem/47504939>
3900
3901         Reviewed by Brent Fulgham.
3902
3903         Added test cases for _WKWebsitePolicies.customJavaScriptUserAgent.
3904
3905         * TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:
3906         (-[CustomJavaScriptUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
3907         (-[CustomJavaScriptUserAgentDelegate webView:didFinishNavigation:]):
3908
3909 2019-01-25  Dean Jackson  <dino@apple.com>
3910
3911         REGRESSION: Some USDz from 3rd party websites don't go directly to AR QL
3912         https://bugs.webkit.org/show_bug.cgi?id=193831
3913         <rdar://problem/47399263>
3914
3915         Reviewed by Chris Dumez.
3916
3917         Two new tests that exercise cross-origin and same-origin System
3918         Previews.
3919
3920         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
3921
3922 2019-01-25  Keith Rollin  <krollin@apple.com>
3923
3924         Update Xcode projects with "Check .xcfilelists" build phase
3925         https://bugs.webkit.org/show_bug.cgi?id=193790
3926         <rdar://problem/47201374>
3927
3928         Reviewed by Alex Christensen.
3929
3930         Support for XCBuild includes specifying inputs and outputs to various
3931         Run Script build phases. These inputs and outputs are specified as
3932         .xcfilelist files. Once created, these .xcfilelist files need to be
3933         kept up-to-date. In order to check that they are up-to-date or not,
3934         add an Xcode build step that invokes an external script that performs
3935         the checking. If the .xcfilelists are found to be out-of-date, update
3936         them, halt the build, and instruct the developer to restart the build
3937         with up-to-date files.
3938
3939         At this time, the checking and regenerating is performed only if the
3940         WK_ENABLE_CHECK_XCFILELISTS environment variable is set to 1. People
3941         who want to use this facility can set this variable and test out the
3942         checking/regenerating. Once it seems like there are no egregious
3943         issues that upset a developer's workflow, we'll unconditionally enable
3944         this facility.
3945
3946         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3947         * DumpRenderTree/Scripts/check-xcfilelists.sh: Added.
3948         * WebKitTestRunner/Scripts/check-xcfilelists.sh: Added.
3949         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3950
3951 2019-01-25  Keith Rollin  <krollin@apple.com>
3952
3953         Update Xcode projects with "Apply Configuration to XCFileLists" build target
3954         https://bugs.webkit.org/show_bug.cgi?id=193781
3955         <rdar://problem/47201153>
3956
3957         Reviewed by Alex Christensen.
3958
3959         Part of generating the .xcfilelists used as part of adopting XCBuild
3960         includes running `make DerivedSources.make` from a standalone script.
3961         It’s important for this invocation to have the same environment as
3962         when the actual build invokes `make DerivedSources.make`. If the
3963         environments are different, then the two invocations will provide
3964         different results. In order to get the same environment in the
3965         standalone script, have the script launch xcodebuild targeting the
3966         "Apply Configuration to XCFileLists" build target, which will then
3967         re-invoke our standalone script. The script is now running again, this
3968         time in an environment with all workspace, project, target, xcconfig
3969         and other environment variables established.
3970
3971         The "Apply Configuration to XCFileLists" build target accomplishes
3972         this task via a small embedded shell script that consists only of:
3973
3974             eval "${WK_SUBLAUNCH_SCRIPT_PARAMETERS[@]}"
3975
3976         The process that invokes "Apply Configuration to XCFileLists" first
3977         sets WK_SUBLAUNCH_SCRIPT_PARAMETERS to an array of commands to be
3978         evaluated and exports it into the shell environment. When xcodebuild
3979         is invoked, it inherits the value of this variable and can `eval` the
3980         contents of that variable. Our external standalone script can then set
3981         WK_SUBLAUNCH_SCRIPT_PARAMETERS to the path to itself, along with a set
3982         of command-line parameters needed to restart itself in the appropriate
3983         state.
3984
3985         * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
3986         * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
3987
3988 2019-01-25  Alex Christensen  <achristensen@webkit.org>
3989
3990         Add SPI to inform an application that "Go Back" has been clicked from a safe browsing warning
3991         https://bugs.webkit.org/show_bug.cgi?id=193802
3992         <rdar://problem/46010580>
3993
3994         Reviewed by Andy Estes.
3995
3996         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
3997         (-[SafeBrowsingNavigationDelegate _webViewDidClickGoBackFromSafeBrowsingWarning:]):
3998         (TEST):
3999
4000 2019-01-25  Daniel Bates  <dabates@apple.com>
4001
4002         [iOS] uiController.keyDown() does not translate Control modified key
4003         https://bugs.webkit.org/show_bug.cgi?id=192898
4004
4005         Reviewed by Wenson Hsieh.
4006
4007         Implement uiController.keyDown() in terms of HIDEventGenerator so that UIKit performs
4008         key translation, as applicable. Among other cases, key translation occurs when performing
4009         a Control key modified key sequence. Writing uiController.keyDown() in terms of HIDEventGenerator
4010         also makes the behavior of uiController.keyDown() more closely match the behavior of a
4011         human pressing down and releasing key(s) using a hardware keyboard.
4012
4013         * WebKitTestRunner/ios/HIDEventGenerator.h:
4014         * WebKitTestRunner/ios/HIDEventGenerator.mm:
4015         (-[HIDEventGenerator sendMarkerHIDEventWithCompletionBlock:]): Renamed; formerly named _sendMarkerHIDEventWithCompletionBlock.
4016
4017         (-[HIDEventGenerator touchDown:touchCount:completionBlock:]):
4018         (-[HIDEventGenerator liftUp:touchCount:completionBlock:]):
4019         (-[HIDEventGenerator stylusDownAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
4020         (-[HIDEventGenerator stylusMoveToPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
4021         (-[HIDEventGenerator stylusUpAtPoint:completionBlock:]):
4022         (-[HIDEventGenerator stylusTapAtPoint:azimuthAngle:altitudeAngle:pressure:completionBlock:]):
4023         (-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
4024         (-[HIDEventGenerator longPress:completionBlock:]):
4025         (-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
4026         Update code for above renaming.
4027
4028         (hidUsageCodeForCharacter): Translate \b to a backspace and teach this function to recognize the
4029         DumpRenderTree EventSender-compatible modifier key names (e.g. "metaKey").
4030
4031         (-[HIDEventGenerator keyDown:]): Added.
4032         (-[HIDEventGenerator keyUp:]): Added.
4033         (-[HIDEventGenerator keyPress:completionBlock:]):
4034         (-[HIDEventGenerator eventDispatchThreadEntry:]):
4035         (-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]): Deleted; renamed to sendMarkerHIDEventWithCompletionBlock.
4036         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4037         (WTR::parseModifierArray): Modified to return a vector of strings that represent the modifier keys to press.
4038         (WTR::UIScriptController::keyDown): Write in terms of HIDEventGenerator.
4039         (WTR::parseModifier): Deleted.
4040
4041 2019-01-25  Keith Rollin  <krollin@apple.com>
4042
4043         Complete the implementation of generate-xcfilelists
4044         https://bugs.webkit.org/show_bug.cgi?id=193782
4045
4046         Reviewed by Alex Christensen.
4047
4048         A preliminary version of generate-xcfilelists was added in r238008.
4049         This patch updates that script in order to:
4050
4051         - Support checking of .xcfilelists
4052         - Perform better execution of `make DerivedSources.make` by
4053           relaunching generate-xcfilelists under xcodebuild
4054         - Support incremental generation and checking of .xcfilelists
4055         - Support supplementary .xcfilelists files from WebKitAdditions
4056         - Support being wrapped by parallel version of generate-xcfilelists in
4057           Internal that adds support for (re)generating WebKit projects in
4058           that repo.
4059         - Support builds that have been performed in WebKitBuild as well as
4060           ~/Library/Developer/code/DerivedData
4061         - Increase robustness and debugging facilities.
4062
4063         * Scripts/generate-xcfilelists:
4064
4065 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
4066
4067         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4068         https://bugs.webkit.org/show_bug.cgi?id=193297
4069         <rdar://problem/47158841>
4070
4071         Unreviewed test case fix.
4072
4073         These test cases require ResourceLoadStatistics to be active, so the feature must be turned on.
4074         Previously, the default data store turned the feature on automatically, allowing these tests to pass.
4075
4076         * TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
4077         (TEST):
4078
4079 2019-01-25  Keith Rollin  <krollin@apple.com>
4080
4081         Update existing .xcfilelists
4082         https://bugs.webkit.org/show_bug.cgi?id=193791
4083         <rdar://problem/47201706>
4084
4085         Reviewed by Alex Christensen.
4086
4087         Many .xcfilelist files were added in r238824 in order to support
4088         XCBuild. Update these with recent changes to the set of build files
4089         and with the current generate-xcfilelist script.
4090
4091         * DumpRenderTree/DerivedSources-input.xcfilelist:
4092         * DumpRenderTree/DerivedSources-output.xcfilelist:
4093         * WebKitTestRunner/DerivedSources-input.xcfilelist:
4094         * WebKitTestRunner/DerivedSources-output.xcfilelist:
4095
4096 2019-01-25  Keith Rollin  <krollin@apple.com>
4097
4098         Fix missing dependencies in extract-dependencies-from-makefile
4099         https://bugs.webkit.org/show_bug.cgi?id=193783
4100         <rdar://problem/47201571>
4101
4102         Reviewed by Alex Christensen.
4103
4104         The extract-dependencies-from-makefile script generates .xcfilelists
4105         for XCBuild by invoking a makefile in --debug mode, parsing the
4106         dependency information in the output, and extracting information
4107         regarding targets and dependents. However, the way `make` emits this
4108         dependency information is not rigorous, and so we need to determine
4109         what lines to look for and parse by trial and error. This approach
4110         didn't coriginally atch all the information we needed to collect, so
4111         update the script to look for the additional lines we now know to look
4112         for.
4113
4114         * Scripts/extract-dependencies-from-makefile:
4115         (Parser):
4116         (Parser.addTarget):
4117         (Parser.addPrereq):
4118         (Parser.doParse):
4119
4120 2019-01-25  Brent Fulgham  <bfulgham@apple.com>
4121
4122         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4123         https://bugs.webkit.org/show_bug.cgi?id=193297
4124         <rdar://problem/47158841>
4125
4126         Reviewed by Alex Christensen.
4127
4128         * TestWebKitAPI/Tests/WebKit Cocoa/ResourceLoadStatistics.mm:
4129             Revise tests to ensure a running NetworkProcess before attempting ResourceLoadStatistics operations.
4130         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4131         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4132         activating the message used to trigger the callback when it is set.
4133
4134 2019-01-25  Alex Christensen  <achristensen@webkit.org>
4135
4136         WKWebView.goBack should reload if there is a safe browsing warning
4137         https://bugs.webkit.org/show_bug.cgi?id=193805
4138         <rdar://problem/46908216>
4139
4140         Reviewed by Geoff Garen.
4141
4142         * TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:
4143         (+[Simple3LookupContext sharedLookupContext]):
4144         (-[Simple3LookupContext lookUpURL:completionHandler:]):
4145         (-[WKWebViewGoBackNavigationDelegate webView:didFinishNavigation:]):
4146         (TEST):
4147
4148 2019-01-25  Chris Dumez  <cdumez@apple.com>
4149
4150         Regression(PSON) cross-site provisional page is not canceled if a new same-site one is started
4151         https://bugs.webkit.org/show_bug.cgi?id=193788
4152         <rdar://problem/47531231>
4153
4154         Reviewed by Alex Christensen.
4155
4156         Add API test coverage.
4157
4158         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4159         (-[PSONNavigationDelegate webView:didStartProvisionalNavigation:]):
4160
4161 2019-01-25  Jonathan Bedard  <jbedard@apple.com>
4162
4163         webkitpy: Missing PID in crashlog name should not be fatal (Follow-up fix)
4164         https://bugs.webkit.org/show_bug.cgi?id=193771
4165
4166         Unreviewed infrastructure fix.
4167
4168         * Scripts/webkitpy/port/darwin.py:
4169         (DarwinPort._merge_crash_logs): Correct syntax for catching multiple exception types.
4170
4171 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4172
4173         * Scripts/webkitpy/common/config/contributors.json: Removing a stray comma.
4174
4175 2019-01-25  Alexey Proskuryakov  <ap@apple.com>
4176
4177         Add contributors.json entries for Ling Ho and for a new bot watchers group.
4178
4179         * Scripts/webkitpy/common/config/contributors.json:
4180
4181 2019-01-25  Chris Dumez  <cdumez@apple.com>
4182
4183         Regression(PSON?) Crash under NavigationState::NavigationClient::decidePolicyForNavigationAction()
4184         https://bugs.webkit.org/show_bug.cgi?id=193779
4185         <rdar://problem/46170903>
4186
4187         Reviewed by Antti Koivisto.
4188
4189         Add API test that quickly navigates forward to a previous process without waiting for it to
4190         suspend. I suspect the crash could have been happening due to receiving leftover IPC from
4191         the process' previous page when reconnecting the it for the forward navigation.
4192
4193         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4194
4195 2019-01-25  Wenson Hsieh  <wenson_hsieh@apple.com>
4196
4197         Need a way for JavaScript (or bundle) code to participate in undo
4198         https://bugs.webkit.org/show_bug.cgi?id=190009
4199         <rdar://problem/44807048>
4200
4201         Reviewed by Ryosuke Niwa.
4202
4203         Add UIScriptController helpers to grab the platform undo and redo action labels. Currently only implemented for
4204         Cocoa platforms in WebKit2. See other ChangeLogs for more detail.
4205
4206         * DumpRenderTree/ios/UIScriptControllerIOS.mm:
4207         (WTR::UIScriptController::lastUndoLabel const):
4208         (WTR::UIScriptController::firstRedoLabel const):
4209         (WTR::UIScriptController::platformUndoManager const):
4210         * DumpRenderTree/mac/UIScriptControllerMac.mm:
4211         (WTR::UIScriptController::lastUndoLabel const):
4212         (WTR::UIScriptController::firstRedoLabel const):
4213         (WTR::UIScriptController::platformUndoManager const):
4214         * TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
4215         * TestRunnerShared/UIScriptContext/UIScriptController.cpp:
4216         (WTR::UIScriptController::lastUndoLabel const):
4217         (WTR::UIScriptController::firstRedoLabel const):
4218         * TestRunnerShared/UIScriptContext/UIScriptController.h:
4219         * WebKitTestRunner/UIScriptControllerCocoa.mm:
4220         (WTR::UIScriptController::lastUndoLabel const):
4221         (WTR::UIScriptController::firstRedoLabel const):
4222         * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
4223         (WTR::UIScriptController::platformUndoManager const):
4224         * WebKitTestRunner/mac/UIScriptControllerMac.mm:
4225         (WTR::UIScriptController::platformUndoManager const):
4226
4227 2019-01-25  Zalan Bujtas  <zalan@apple.com>
4228
4229         [LFC][BFC][MarginCollapsing] Add "clear" to static position computation.
4230         https://bugs.webkit.org/show_bug.cgi?id=193824
4231
4232         Reviewed by Antti Koivisto.
4233
4234         * LayoutReloaded/misc/LFC-passing-tests.txt:
4235
4236 2019-01-24  Ryan Haddad  <ryanhaddad@apple.com>
4237
4238         Update macOS JSC bot configurations
4239         https://bugs.webkit.org/show_bug.cgi?id=193739
4240
4241         Reviewed by Alexey Proskuryakov.
4242
4243         * BuildSlaveSupport/build.webkit.org-config/config.json: Remove 32-bit BuildAndTest queue.
4244         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:
4245         (BubbleQueueServer): Move JSC EWS to Mojave section.
4246         * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
4247         (WebKitBuildbot): Remove 32-bit BuildAndTest queue from dashboard.
4248         * BuildSlaveSupport/build.webkit.org-config/steps_unittest.py: Update unit test.
4249
4250 2019-01-24  Fujii Hironori  <Hironori.Fujii@sony.com>
4251
4252         [Win][WebKitTestRunner] Implement EventSenderProxy
4253         https://bugs.webkit.org/show_bug.cgi?id=193755
4254
4255         Reviewed by Don Olmstead.
4256
4257         * WebKitTestRunner/EventSenderProxy.h: Removed unused members m_buttonState and m_mouseButtonsCurrentlyDown.
4258         * WebKitTestRunner/win/EventSenderProxyWin.cpp:
4259         (WTR::EventSenderProxy::dispatchMessage):
4260         (WTR::EventSenderProxy::EventSenderProxy):
4261         (WTR::EventSenderProxy::mouseDown):
4262         (WTR::EventSenderProxy::mouseUp):
4263         (WTR::EventSenderProxy::mouseMoveTo):
4264         (WTR::EventSenderProxy::mouseScrollBy):
4265         (WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
4266
4267 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>
4268
4269         Unreviewed fix for API test failure after r240437.
4270
4271         TestWTF.WTF.StringOperators apparently can't deal with another test using String::operator+. This is fine...
4272
4273         * TestWebKitAPI/Tests/WTF/FileSystem.cpp:
4274
4275 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4276
4277         [webkitdirs] iosSimulatorApplicationsPath may not have iOS.simruntime in its path
4278         https://bugs.webkit.org/show_bug.cgi?id=193787
4279         <rdar://problem/47497634>
4280
4281         Reviewed by Alexey Proskuryakov.
4282
4283         * Scripts/webkitdirs.pm:
4284         (iosSimulatorApplicationsPath): Pick from available runtime directories.
4285
4286 2019-01-24  Truitt Savell  <tsavell@apple.com>
4287
4288         Unreviewed, rolling out r240446.
4289
4290         Casued 5 API failures
4291
4292         Reverted changeset:
4293
4294         "Activate the WebResourceLoadStatisticsStore in the
4295         NetworkProcess and deactivate it in the UIProcess."
4296         https://bugs.webkit.org/show_bug.cgi?id=193297
4297         https://trac.webkit.org/changeset/240446
4298
4299 2019-01-24  Zalan Bujtas  <zalan@apple.com>
4300
4301         DidFirstVisuallyNonEmptyLayout milestone should always fire at some point.
4302         https://bugs.webkit.org/show_bug.cgi?id=193741
4303         <rdar://problem/47135030>
4304
4305         Reviewed by Antti Koivisto and Simon Fraser.
4306
4307         * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4308         * TestWebKitAPI/Tests/WebKit/LayoutMilestonesWithAllContentInFrame.cpp:
4309         (TestWebKitAPI::TEST):
4310
4311 2019-01-24  Brent Fulgham  <bfulgham@apple.com>
4312
4313         Activate the WebResourceLoadStatisticsStore in the NetworkProcess and deactivate it in the UIProcess.
4314         https://bugs.webkit.org/show_bug.cgi?id=193297
4315         <rdar://problem/47158841>
4316
4317         Reviewed by Alex Christensen.
4318
4319         * WebKitTestRunner/InjectedBundle/TestRunner.cpp:
4320         (WTR::TestRunner::installStatisticsDidScanDataRecordsCallback): Simplify test configuration by
4321         activating the message used to trigger the callback when it is set.
4322
4323 2019-01-24  John Wilander  <wilander@apple.com>
4324
4325         Add Ad Click Attribution as an internal/experimental feature
4326         https://bugs.webkit.org/show_bug.cgi?id=193685
4327         <rdar://problem/47450399>
4328
4329         Reviewed by Brent Fulgham.
4330
4331         Added test option adClickAttributionEnabled.
4332
4333         * DumpRenderTree/TestOptions.cpp:
4334         (TestOptions::TestOptions):
4335         * DumpRenderTree/TestOptions.h:
4336         * DumpRenderTree/mac/DumpRenderTree.mm:
4337         (setWebPreferencesForTestOptions):
4338
4339 2019-01-24  Antti Koivisto  <antti@apple.com>
4340
4341         [PSON] Flash on back navigation on Mac
4342         https://bugs.webkit.org/show_bug.cgi?id=193716
4343         <rdar://problem/47148458>
4344
4345         Reviewed by Chris Dumez.
4346
4347         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4348
4349         Closing of the previous page is delayed so waiting for didFinishNavigation is
4350         not sufficient to guarantee we have received all the messages. Wait for them.
4351
4352 2019-01-24  Chris Dumez  <cdumez@apple.com>
4353
4354         Regression(PSON) Back/Forward list items' URL sometimes gets replaced with the URL of a subframe
4355         https://bugs.webkit.org/show_bug.cgi?id=193761
4356         <rdar://problem/47456405>
4357
4358         Reviewed by Alex Christensen.
4359
4360         Add API test coverage.
4361
4362         * TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
4363
4364 2019-01-24  Jonathan Bedard  <jbedard@apple.com>
4365
4366         webkitpy: Missing PID in crashlog name should not be fatal
4367         https://bugs.webkit.org/show_bug.cgi?id=193771
4368
4369         If we can't determine the PID of a crashlog, just ignore the crashlog instead
4370         of raising an exception.
4371
4372         Reviewed by Lucas Forschler.
4373
4374         * Scripts/webkitpy/port/darwin.py:
4375         (DarwinPort._merge_crash_logs):
4376
4377 2019-01-24  Michael Catanzaro  <mcatanzaro@igalia.com>
4378
4379         test_exporter.py: webkitpy.common.system.executive.ScriptError from create_branch_with_patch
4380         https://bugs.webkit.org/show_bug.cgi?id=193746
4381
4382         Reviewed by Youenn Fablet.
4383
4384         It calls 'git apply --index --abort', but --abort is not a valid argument to 'git apply',
4385         so we'd best just not call it.
4386
4387         * Scripts/webkitpy/w3c/test_exporter.py:
4388         (WebPlatformTestExporter.create_branch_with_patch):
4389
4390 2019-01-24  Ross Kirsling  <ross.kirsling@sony.com>